office-addin-manifest returns success on non-existent manifest file path

Expected behavior
office-addin-manifest should return an error code when the specified manifest filepath is non-existent.
Current behavior
The tools returns a success code.
Steps to Reproduce

Run office-addin-manifest validate not-a-dir/manifest.xml
ENOENT error is printed, but the command's return code is 0.

Context
It looks like this issue has been previously raised and fixed (#372), so this may be a regression. EDIT: looks like that PR prints the appropriate error message, but doesn't change the exit code.

Operating System: Debian 11
Node version: 20.12.0
Office version:
Tool version: 1.13.0

Failure Logs
$ npx office-addin-manifest validate not-a-dir/manifest.xml; echo $?
Error: Unable to read data for manifest file: not-a-dir/manifest.xml.
Error: ENOENT: no such file or directory, open 'not-a-dir/manifest.xml'
0

@tobz1000 it is most likely that when we catch an error, we are just outputting the message and then gracefully completing rather than returning an error code. What is your scenario where you need the specific error code even when the output displays the error?

Since the command is for validating the manifest file, it would make sense to return an error if the file can't be found at all. I use the command in a linting script for my codebase. If the manifest filepath is incorrect, the script succeeds but it should fail.

Thanks for reporting this issue regarding office-addin-manifest validate script not returning the proper error code for this case. It has been put on our backlog. We unfortunately have no timelines to share at this point. However, I would suggest as a workaround that you validate the existence of the manifest before using the office-addin-manifest validate script.
Internal tracking id: Office: 8958771


Impromptu looks strange on iPad iOS 4.x

impromptu 3.1
invocation as follows:
theprompt = $.prompt(txt, {
prefix:'cleanblue',
buttons: {Save:'Save', Close:'Close'},
submit:function(v,m,f){
if (v == 'Save') {
                return false;
			} else {
			    $.prompt.close();
			}
		}
});

any luck?
On Thu, Oct 6, 2011 at 8:07 AM, Trent Richardson <
<EMAIL_ADDRESS>
Ok, I think I've pinpointed the issue.  Some mobile browsers do not support
position:fixed;  So the faded overlay will not keep up with the scroll
position of the window.   I need to compare the document height and window
height and use the largest value for the height so it never falls short
(same with width).  These changes would take place in the positionPrompt
function around line 162
--
Reply to this email directly or view it on GitHub:
https://github.com/trentrichardson/jQuery-Impromptu/issues/1#issuecomment-2310865

I committed a change to the overlay to try and fix this.  Work much better for me on iPad emulator.

ive tried the patched file, it seems the dialog is still getting thrown to the left
im also calling jquery's .draggable() on the impomptu window, and it works, but not on the simulator at all.
also, if the impropmtu window is called to be displayed and the user is scrolled down the page, impromptu will still display at the top of the page, out of the users view (ipad safari)

Yeah, I was reading about this, that iPad's safari browser purposely disables position:fixed css, which is how Impromptu keeps the prompt in the viewing area.  This approach is best for all other devices except ipad/iphone browser.  So I'm not sure if the best solution is to:

implement the scrolling with javascript (it is already implemented for IE6 I believe), but I don't want to get into browser detection as that gets messy quick.
start the prompt within the viewing area, and whether or not position:fixed is supported or not will determine if the prompt stays within the viewing area
ignore this for iPad/iPhone

Your thoughts?

start the prompt within the viewing area, and whether or not position:fixed is supported or not will determine if the prompt stays within the viewing area

otherwise,
browser detection is a pain, but if you can easily detect ipad-safari then you could just use this as the single special case
On Oct 12, 2011, at 11:39 AM, Trent Richardson wrote:

Yeah, I was reading about this, that iPad's safari browser purposely disables position:fixed css, which is how Impromptu keeps the prompt in the viewing area.  This approach is best for all other devices except ipad/iphone browser.  So I'm not sure if the best solution is to:

implement the scrolling with javascript (it is already implemented for IE6 I believe), but I don't want to get into browser detection as that gets messy quick.
start the prompt within the viewing area, and whether or not position:fixed is supported or not will determine if the prompt stays within the viewing area
ignore this for iPad/iPhone

Your thoughts?
--
Reply to this email directly or view it on GitHub:
https://github.com/trentrichardson/jQuery-Impromptu/issues/1#issuecomment-2382795

Matt Schettler
<EMAIL_ADDRESS>

Ok, I'll take a look at that approach

After looking at similar plugins I decided to position it in the window and not try to force the position:fixed;  The fixed position also potentially could have caused problems with smaller windows and large prompts anyway..
As for the left positioning you're having I've not been able to reproduce that.. I'm still thinking this could be result to awkward css document width?

Any update to this?
On Oct 12, 2011, at 1:36 PM, Trent Richardson wrote:

After looking at similar plugins I decided to position it in the window and not try to force the position:fixed;  The fixed position also potentially could have caused problems with smaller windows and large prompts anyway..
As for the left positioning you're having I've not been able to reproduce that.. I'm still thinking this could be result to awkward css document width?
--
Reply to this email directly or view it on GitHub:
https://github.com/trentrichardson/jQuery-Impromptu/issues/1#issuecomment-2385803

Matt Schettler
<EMAIL_ADDRESS>

Yes, version 3.2 addressed this issue by overlaying the entire document and not scrolling with the window.  If the prompt is not in the viewport and the user clicks the fade the window scrolls back to the prompt.


Missing SearchBar composable for desktop

Do you mean a SearchBar from material3? https://www.composables.com/components/material3/searchbar
That's true. It should appear in Compose Mutlipatform material3 lib in the next major release if Jetpack Compose material3 1.2.0 goes stable (we don't base our releases on unstable JC releases).

@eymar Is there a site we can check the current versions of Compose Mutlipatform material3?

@iadcialim (even though you didn't ask me specifically lol) you can check on the releases tab of the repo, under the "Dependencies" heading:
https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.4.1
Illustration:

Otherwise there is no other site I personally know of.

@AfricanBongo i appreciate it. thanks

Somehow it didn't get included in the most recent release that supports Material3 version 1.1.1. What is the reason for its exclusion?

It should be available in 1.5.10-beta01

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


KeeAnywhere 1.5.1 doesn't work with KeePass 2.43

Operation is not valid due to the current state of the object.
KeePass
	at KeePass.Plugins.PlgxPlugin.Compile(String strTmpRoot, PlgxPluginlnfo plgx, String strBuildPre, String strBuildPost)
	at KeePass.Plugins.PlgxPlugin.ReadFile(BinaryReader br, PlgxPluginlnfo plgx, IStatusLogger slStatus)
	at KeePass.Plugins.PlgxPlugin.LoadPriv(String strFilePath, IStatusLogger slStatus, Boolean bAllowCached, Boolean bAllowCompile, Boolean bAllowLoad, TextWriter twLog)
	at KeePass.Plugins.PlgxPlugin.Load(String strFilePath, IStatusLogger slStatus)
	System.String Compile(System.String, KeePass.Plugins.PlgxPluginlnfo, System.String, System.String)

In my case the error is different. The plug-in is unable to load the assembly KeePass.

I've download the source code, change the KeePass.exe and KeePass.XmlSerializers.dll and just recompile the solution and now works fine. Can you upgrade the release file?

Update dependencies to KeePass 2.43.


Editing manual sections

Users can edit manual_section content;
We have added body field to the section show page;
Trello Card

@davidbasalla thanks for the comments, it should be ready to merge now.

@davidbasalla hopefully ready to merge now.

Minor comment about test coverage, apart from that, :+1:


Issue with linking of CommonCrypto

Hello,
I want add HTTP basic auth to my project but when I add CredentialsHTTP package I got error during building the package - http://prntscr.com/ihtfu7
Also I found it's a common issues:
https://github.com/IBM-Swift/BlueCryptor/issues/27
https://github.com/IBM-Swift/BlueCryptor/issues/29
With the same list of packages, but without CredentialsHTTP everything is built fine http://prntscr.com/ihthyi
Please help me with this issue.
Thanks in advance,
Oleksandr

Hi, can you paste your full Package.swift here please?

// swift-tools-version:4.0
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "Server",
    dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(url: "https://github.com/IBM-Swift/Kitura.git", .upToNextMajor(from: "2.2.0")),
        .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", .upToNextMajor(from: "2.1.0")),
        // .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0"),
    ],
    targets: [
        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
        // Targets can depend on other targets in this package, and on products in packages which this package depends on.
        .target(
            name: "Server",
            dependencies: ["Kitura", "SwiftShell", "Credentials"]),
    ]
)

This does resolve for me:
$ swift package resolve
Fetching https://github.com/IBM-Swift/Kitura-Credentials.git
Fetching https://github.com/IBM-Swift/Kitura.git
Fetching https://github.com/IBM-Swift/Kitura-net.git
Fetching https://github.com/IBM-Swift/Kitura-TemplateEngine.git
Fetching https://github.com/IBM-Swift/KituraContracts.git
Fetching https://github.com/IBM-Swift/LoggerAPI.git
Fetching https://github.com/IBM-Swift/BlueSocket.git
Fetching https://github.com/IBM-Swift/CCurl.git
Fetching https://github.com/IBM-Swift/BlueSSLService.git
Fetching https://github.com/IBM-Swift/Kitura-Session.git
Fetching https://github.com/IBM-Swift/BlueCryptor.git
Fetching https://github.com/IBM-Swift/CommonCrypto.git
Cloning https://github.com/IBM-Swift/BlueSocket.git
Resolving https://github.com/IBM-Swift/BlueSocket.git at 0.12.91
Cloning https://github.com/IBM-Swift/LoggerAPI.git
Resolving https://github.com/IBM-Swift/LoggerAPI.git at 1.7.1
Cloning https://github.com/IBM-Swift/CCurl.git
Resolving https://github.com/IBM-Swift/CCurl.git at 0.4.1
Cloning https://github.com/IBM-Swift/Kitura-TemplateEngine.git
Resolving https://github.com/IBM-Swift/Kitura-TemplateEngine.git at 1.7.2
Cloning https://github.com/IBM-Swift/Kitura-Session.git
Resolving https://github.com/IBM-Swift/Kitura-Session.git at 3.0.1
Cloning https://github.com/IBM-Swift/Kitura.git
Resolving https://github.com/IBM-Swift/Kitura.git at 2.2.0
Cloning https://github.com/IBM-Swift/BlueSSLService.git
Resolving https://github.com/IBM-Swift/BlueSSLService.git at 0.12.81
Cloning https://github.com/IBM-Swift/KituraContracts.git
Resolving https://github.com/IBM-Swift/KituraContracts.git at 0.0.19
Cloning https://github.com/IBM-Swift/Kitura-Credentials.git
Resolving https://github.com/IBM-Swift/Kitura-Credentials.git at 2.1.0
Cloning https://github.com/IBM-Swift/CommonCrypto.git
Resolving https://github.com/IBM-Swift/CommonCrypto.git at 0.1.5
Cloning https://github.com/IBM-Swift/BlueCryptor.git
Resolving https://github.com/IBM-Swift/BlueCryptor.git at 0.8.27
Cloning https://github.com/IBM-Swift/Kitura-net.git
Resolving https://github.com/IBM-Swift/Kitura-net.git at 2.0.1

Have you uncommented .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0"), for Package.swift file from above? Exactly this causes an error - http://prntscr.com/ihulnn
Currently there is no Fetching https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git string in your quote above. Without .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0") everything works fine.
Please use this code (same but with uncommented CredentialsHTTP package):
// swift-tools-version:4.0
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "Server",
    dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(url: "https://github.com/IBM-Swift/Kitura.git", .upToNextMajor(from: "2.2.0")),
        .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", .upToNextMajor(from: "2.1.0")),
        .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0"),
    ],
    targets: [
        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
        // Targets can depend on other targets in this package, and on products in packages which this package depends on.
        .target(
            name: "Server",
            dependencies: ["Kitura", "SwiftShell", "Credentials"]),
    ]
)

I'm getting the same error!

@rchatham Thanks for bringing this to our attention. The cause of this a conflict between Kitura-CredentialsHTTP which uses upToNextMinor of Kitura-Credentials from 2.0.0 and Kitura-Credentials which is set to 2.1.0.
You can fix this in your package.swift by changing dependancies to:
.package(url: "https://github.com/IBM-Swift/Kitura.git", .upToNextMinor(from: "2.0.0")),
        .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", .upToNextMinor(from: "2.0.0")),
        .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0"),

We will also create and tag a pull request changing Kitura-CredentialsHTTP to use next major which will make your original package.swift compile.

Actually my Package.swift file looks like this.
// swift-tools-version:4.0
import PackageDescription

let package = Package(
    name: "Server",
    products: [
      .executable(
        name: "Server",
        targets:  [ "Server" ]
      ),
    ],
    dependencies: [
      .package(url: "https://github.com/IBM-Swift/Kitura.git", from: "2.1.0"),
      .package(url: "https://github.com/IBM-Swift/HeliumLogger.git", from: "1.7.1"),
      .package(url: "https://github.com/IBM-Swift/CloudEnvironment.git", from: "6.0.0"),
      .package(url: "https://github.com/RuntimeTools/SwiftMetrics.git", from: "2.2.1"),
      .package(url: "https://github.com/IBM-Swift/Health.git", .upToNextMinor(from: "0.0.0")),
      .package(url: "https://github.com/IBM-Swift/LoggerAPI.git", from: "1.0.0"),
      .package(url: "https://github.com/IBM-Swift/Kitura-CORS.git", .upToNextMinor(from: "2.1.0")),
      .package(url: "https://github.com/IBM-Swift/Swift-Kuery-ORM.git", .upToNextMinor(from: "0.0.1")),
      .package(url: "https://github.com/IBM-Swift/Swift-Kuery-PostgreSQL.git", .upToNextMinor(from: "1.1.0")),
      .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", from: "2.1.0"),
      // .package(url: "https://github.com/IBM-Swift/Kitura-CredentialsHTTP.git", from: "2.0.0"),
      .package(url: "https://github.com/rchatham/ShortCode.git", from: "0.0.5"),
    ],
    targets: [
      .target(
        name: "Server",
        dependencies: [ .target(name: "Application"), "Kitura" , "HeliumLogger" ]
        ),
      .target(
        name: "Application",
        dependencies: [ "Kitura" , "KituraCORS" , "CloudEnvironment" , "SwiftMetrics" , "Health" , "SwiftKueryORM" , "SwiftKueryPostgreSQL" ]
        ),
      .target(
        name: "Models",
        dependencies: [ "Kitura" , "SwiftKueryORM" , "SwiftKueryPostgreSQL" , "ShortCode" ]
        ),
      .target(
        name: "Authentication",
        dependencies: [ "Kitura" , "CredentialsHTTP" ,  "HeliumLogger" ]
        ),

      .testTarget(
        name: "ApplicationTests" ,
        dependencies: [ .target(name: "Application"), "Kitura" , "HeliumLogger" ]
        ),
      .testTarget(
        name: "ModelsTests" ,
        dependencies: [ .target(name: "Models"), "Kitura" , "HeliumLogger" ]
        ),
      // .testTarget(
      //   name: "AuthenticationTests" ,
      //   dependencies: [.target(name: "Authentication"), "Kitura" , "HeliumLogger" ]
      //   ),
    ]
)

@rchatham We have just tagged a patch which should prevent the conflict so if you could try generating your project and see if it works now. You may need to do swift package update so it doesn't use cached dependencies.

@Andrew-Lees11 I managed to get my dependencies to resolve but am now getting the following error. missing required modules: 'CCurl', 'CHTTPParser'. Any ideas?


Dynamic autocomplete

Found these, and they work pretty fast for my 4000 line files
https://github.com/nidu/vscode-copy-json-path
https://github.com/MaloPolese/copy-json-path/tree/main/src
Hopefully helps to figure out how to do the JSON paths so it can be implemented here too.
If you can setup something with these, I'd be more than happy to contribute to make sure it covers every aspect. So like if you can set it up for one component, I'd just follow that syntax and add it for the rest

👍
Got ideas allready for them, just need to make that code setup :)

Alr, do @ me whenever you get that done. Dynamic autocomplete is my primary reason for returning to bridge.


Unexpected key "user" found in initialState

I'm trying to remove all auth / db related code from the starter kit to have a more clean version, so far so good everything works, there is one bit I am not able to figure out in server.jsx file:
const history = createMemoryHistory()
  const store = configureStore({
    user: {
      isWaiting: false,
      message: ''
    }
  }, history)

  const routes = createRoutes(store)

I'm pretty sure it is this one giving me warning:
Unexpected key "user" found in initialState argument passed to createStore. Expected to find one of the known reducer keys instead: "routing". Unexpected keys will be ignored.
but I believe I do need to create routes with some sort of store, how can I edit this to get rid of the warning?

you can pass an empty object (or maybe undefined) to configureStore.
The reason for that error is you removed the user reducer from reducers/index.js, so it's no longer expecting a user as part of the state
[Redux docs for createStore] (http://redux.js.org/docs/api/createStore.html) have some more explanation and examples. Please re-open or comment if you are still having trouble

@psimyn I have same problem. But I want use SSR with redux and webpack chunks (require.ensure).
I need to load reducers dynamic

@LestaD Do you solved your problem? I am facing same situation when injecting reducers asynchronously with require.ensure.


error string issue

Hi folks,
openssl version = 1.1.1d
sometimes we see below error string for some errors
retval = -1, retcode = 1, error:00000001:lib(0):func(0):reason(1)
why is it so?
note: error strings are inited correctly.
note: we get the correct error string in most error cases.
Thanks,
Pavan

That looks like you use a return value as an error code...


[Feature Request] [CLI] Able to scope down the connection.provider setting to flow folder or better each CLI invoke

The connection.provider setting is a global one, stops the developers from having just a subset of flows using Azure connections.
The main scenario blocked is the Azure AI SDK/CLI integration:

I initialized a flow with Azure AI CLI, which set to use Azure connections
Some of my other flows are still using local connections
One of #1 and #2 cannot work properly

Possible options:
a) Honor flowfolder/.promptflow/config.yaml for connection setting. This might cause some confusion for users looking at the connections tab in VSC extension.
b) Add a --config connection.provider=x argument to pf CLI (and SDK as well?)

We already hade some discussions around this (use of config.json, etc.). Let's please spec the behavior here and review it to make sure all learnings from the past are considered.

For CLI: We will expose a suppress argument for cli command, includes pf test and pf run create, in this case, only full workspace resource id is accepted as argument value, for example:
pf test  --connection-provider="azureml:/subscriptions/../resourceGroups/../"
For SDK: We will support connection_provider in kwargs when initializing PFClient, same to cli, only full id is accepted, example usage like:
PFClient(connection_provider="azureml:/...")

Why can't the same simple approach of using "azureml" work as it does with pf config --set connection.provider=azureml? The CLI isn't currently keeping track of the full "workspace resource id" or "project resource id" where the connections are.
I'm not sure why the asymmetry would be wanted by customers or the pf team. Can you clarify why this is a superior design to the previously agreed to approach?
TL;DR: we should be able to specify just azureml
@robch

@lebaro-msft please take a look at the pr description, see if it meets your requirements, thanks.

That looks great @brynn-code thank you! Let's discuss post-Ignite if there is a more robust solution we can have for this - it sounded like there was a per-flow connection design in discussion we may be interested in.

To align with our pf config command, I made some changes to the interface, please take a look again, thanks! @lebaro-msft

The issue is marked as closed as I merged the pr, the change would be brought in next 0b9 version release at about 10/25. If you need the dev version for test, please ping me in teams.

please try with:  pip install promptflow[azure]==0.0.108132407 --extra-index-url https://azuremlsdktestpypi.azureedge.net/promptflow/


esp32-C6无法对ADC电压进行校准 (IDFGH-10836)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
https://docs.espressif.com/projects/esp-idf/zh_CN/v5.1/esp32c6/api-reference/peripherals/adc_calibration.html这篇文章里提到的校准驱动器无法应用到esp32-C6上，esp32-C6只能获得ADC读到的数字而不能获得和数值对应的电压值。

、

5.1 tag上还没有这个。 应该是5.1.1里会有。
现在你可以先用 https://github.com/espressif/esp-idf/blob/release/v5.1/components/esp_adc/esp32c6/include/adc_cali_schemes.h 这一版


typings objection, snakeCaseMappers & knexSnakeCaseMappers

Hi,
In the definition file 'typings/objection/index.d.ts' :
  const snakeCaseMappers: () => ColumnNameMappers;
  const knexSnakeCaseMappers: () => KnexMappers;

the options parameter is missing (see 'lib/utils/identifierMapping.js') :
function knexSnakeCaseMappers(opt = {}) {}
function snakeCaseMappers(opt = {}) {}

The definition should be :
  const snakeCaseMappers: (opt?: any) => ColumnNameMappers;
  const knexSnakeCaseMappers: (opt?: any) => KnexMappers;

Thanks.
Regards

PR merged

When will this fix be released? It's not in 1.6.9, but it would be nice to have it.  Thanks for keeping the typing fixes coming!


InvalidOperationException - Conflit with ViewComponents?

Hi,
In first place, your project is wonderful. Congratulations.
Everything was working fine. So I needed to add a viewcomponent in the project and CRASH!!!
I created a folder with name ViewComponent.

Interesting. I will have to look at it. The error stack however says that you have a missing method in your view component. Are you sure that's not the case ?

Yeah,
I created one view component with different name of the folder of the View.
Sorry for false positive.


Batchnorm track running state

I found out that during inference a larger batch size results in better results than a smaller one. To avoid this the batchnorm layer needs to track the running state.

Hi
We are using pytorch batchnorm instead of torchmeta batch norm
https://github.com/tristandeleu/pytorch-maml/blob/c7d994a3e9900d3d6790dbe921cd63abbc6589d4/maml/model.py#L11
Does the inner loop gradient descent update batch norm parameters?
PS: I am not the author. I am trying to understand the implementation.


[minor][docs][mesos] Clarify that Mesos version is a lower bound.

What changes were proposed in this pull request?
Clarify that 0.21 is only a minimum requirement.
How was the this patch tested?
It's a doc change, so no tests.

Test build #51553 has started for PR 11271 at commit bf1ab2f.

Test build #51553 has finished for PR 11271 at commit bf1ab2f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51553/
Test PASSed.

Thanks - going to merge this.


SRS Review: Issues with Traceability Matrices

I didn't go into detail here since Drasil will do this automatically, but each "X" in a matrix represents an explicit reference. Many of these are missing (For example, none of the LCs reference an assumption.)
Minor issue, but Table 6 probably doesn't need to be on its own page.

I see what you mean. It's quite difficult to have it added in the manual SRS, I'll lean on Drasil now that we're porting anyway. Thank you!


[FEATURE] Group documents into clusters using Cluster layer

Is your feature request related to a problem?
As OpenSearch Maps user, i should be able to reduce points/shapes in an index by grouping them into clusters based on proximity to one another. If large number of points/shapes are very close to each other, it is very hard to know the accurate count of points/shapes. It could be deceptive. Hence, Clustering allows users to visually show those large dataset in concise way in small areas.
What solution would you like?
Maps should support a new layer called "Cluster layer" which can aggregate all points/shapes from an index using geospatial aggregations (metric/bucket).
What alternatives have you considered?
N/A
Do you have any additional context?
A/A
Example of cluster layer output

@vamshin I'm writing the end user documentation for this feature. Will you share the feature brief and demo with me? Alternatively, I can set up a meeting with you to review this feature. Please let me know. Thank you, Melissa

Hi @vagimeli, this feature moved to future release. We will not be releasing for 2.9

Hi @vamshin , may I ask if this is still on the roadmap?


rdf_loader/include include dir not found

Running the Catkin build in Docker results in an error in the 'moveit_ros_planning' project stating that the specified include directory is not found.
the exact error is:
CMake Error at /root/ros_ws/devel/share/moveit_ros_planning/cmake/moveit_ros_planningConfig.cmake:113 (message):
Project 'moveit_ros_planning' specifies
'/root/ros_ws/src/moveit/moveit_ros/planning/rdf_loader/include' as an
include dir, which is not found.  It does neither exist as an absolute
directory nor in
'/root/ros_ws/src/moveit/moveit_ros/planning//root/ros_ws/src/moveit/moveit_ros/planning/rdf_loader/include'.
I tried many times, even with the no-cache option, to build from scratch.
There is nothing in root/ros_ws/src/moveit/.

Right, you need to initialize the submodules of this repository.
Please

Update the code, I fix a problem with .gitmodule
Then, run git submodule update --init --recursive on this repository's directory.

oh, thank you!
now catkin build works, and the demo launch as well.
After open a second terminal (docker exec ...) and running 'rosrun panda_dual_arm_demo simple_path', I get the following error:
[rosrun] Couldn't find executable named simple_path below /root/ros_ws/src/panda_dual_arm_demo
Am I doing something wrong?

For good measure, please rebuild the catkin workspace inside the docker.
catkin build
Then source the workspace
source ~/ros_ws/devel/setup.bash
After that it should work

Sorry for the late reply. Unfortunately it shows the same error. In .bashrc I can see the sourced line:
source ~/ros_ws/devel/setup.bash


v1 of AutoGen Studio on AgentChat

Why are these changes needed?

First step in platforming AutoGen Studio on the AgentChat api. Primary goal is to create a too that enables rapid prototyping and experiments.
This PR introduces a teammanager class that can take a declarative agent spect and return AgentChat runtime instances, streaming agent updates over a websocker and an updated backend api.

Declarative Specification and Team Manager
{
  "name": "weather_team",
  "participants": [
    {
      "name": "writing_agent",
      "model_client": {
        "model": "gpt-4o-2024-08-06",
        "model_type": "OpenAIChatCompletionClient"
      },
      "tools": [
        {
          "name": "get_weather",
          "description": "Get the weather for a city",
          "content": "async def get_weather(city: str) -> str:\n    return f\"The weather in {city} is 73 degrees and Sunny.\""
        }
      ],
      "agent_type": "AssistantAgent"
    }
  ],
  "termination_condition": {
    "termination_type": "MaxMessageTermination",
    "max_messages": 5
  },
  "team_type": "RoundRobinGroupChat",
  "model_client": null
}

The team specification can be loaded as follows:
from autogenstudio.teammanager import TeamManager
import json

wm = TeamManager()
result = await wm.run(task="What is the weather in New York?", team_config= json.load(open("team.json")) )
print(result)

UI
Current updates to the UI include the ability to create a session, attach a team spec (as json) and run tasks.
Intermediate agent steps are streamed to the UI and can be stopped as the task proceeds.

Related issue number

[x] #4007
[x] #4008
[x] #4009
[x] #4010
[x] #4095

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Looks like uv lock needs to be updated.


Showing error on wrong field while using country type field in case of required.

If you used any form fields just before the country type field, then you will get the required field issue on the field which is used just before country field, only if you didn't provide the required value for country field.

There is one extra double quote in data-vv-as custom attribute in:
bagisto/packages/Webkul/Admin/src/Resources/views/configuration/field-type.blade.php

Framework Version: 0.1.4
Fixed


magic_duckdb based magic?

In combination with DuckDB, it seems that magic_duckdb may provide better performance than jupysql.
https://github.com/iqmo-org/magic_duckdb

Yes, looks interesting. I'm not sure whether it's sufficiently mature or not — I notice it's new and has unfinished sentences on the Readme :)  (all tools start somewhere!).
The perf does look much better though, I'm surprised the existing approach has so much overhead

jupysql is really amazing. This performance issue should be solved...
ploomber/jupysql#470
https://twitter.com/ploomber/status/1661824499224915970
https://github.com/ploomber/jupysql/blob/master/CHANGELOG.md

0.7.5 (2023-05-24)
[Feature] Using native DuckDB .df() method when using autopandas

yes, we fixed the performance issue when %autopandas is turned on. And we just started working on https://github.com/ploomber/jupysql/issues/470 to provide further improvements.
If you encounter any performance issues, let us know and we'll fix them!

Thank you @edublancas !


Hi Flyway team , if there is a way we can have flyway output a script instead of executing the commands -

Which version and edition of Flyway are you using?
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Which database are you using (type & version)?
Which operating system are you using?
What did you do?
(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
What did you expect to see?
What did you see instead?

This is a Flyway pro feature, called Dry Run. See more details here: https://flywaydb.org/documentation/dryruns

yes I know that I want for the community edition


tests: use parameterised testing using jest.each for extensions.test.ts

name: ⚙ Improvement
about: Refactoring tests to reduce redundancies using jest.each
labels: enhancement

A Pull Request should be associated with a Discussion.
Refactoring the tests to be using parameters with jest.each
Related discussion: #506

Further notes in Contribution Guidelines
Thank you for your contribution.

Description
This PR improves the test code by refactoring existing unit tests using parameterised testing by jest.each

In case this PR introduced TypeScript/JavaScript code changes:

[x] I have written test cases for the changes in this pull request
[x] I have run npm run format before the commit.
[x] I have run npm run lint before the commit.
[x] I have run npm run release before the commit.
[x] npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

[x] I have checked the edited scripts for syntax.
[ ] I have tested the changes in an integration test (If yes, provide workflow YAML and link). - NA

Merged 🎉


MSID: 96425 Version: 2 DOI: 10.1101/2<IP_ADDRESS>7927

MSID: 96425
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>7927
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96425
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7927

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96425v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>7927
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96425/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."


[red-knot] Incorrect Narrowing Constraint Applied After IfExp

def bool_instance() -> bool:
    return True

x: Literal[42, "hello"] = 42 if bool_instance() else "hello"
reveal_type(x)  # revealed: Literal[42] | Literal["hello"]

_ = 1234 if isinstance(x, str) else 1234

# The `isinstance` test incorrectly narrows the type of `x`.
# As a result, `x` is revealed as Literal["hello"], but it should remain Literal[42, "hello"].
reveal_type(x)  # revealed: Literal["hello"]

This issue is not limited to isinstance. Other narrowing expressions or patterns also cause the same issue.

If this isn't resolved first, #14550 will break some tests.
I'll take a look into it first.


pip install yotta --upgrade breaks yotta on windows 7

Hi
This is what happened:
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$ pip install yotta --upgrade
Downloading/unpacking yotta from https://pypi.python.org/packages/source/y/yotta/yotta-0.1.0.tar.gz#md5=9bead7fee77e43e2
669d1e403163604b
Running setup.py (path:c:\users\simhug01\appdata\local\temp\pip_build_simhug01\yotta\setup.py) egg_info for package yo
tta
Requirement already up-to-date: semantic-version>=2.3.1,<3 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Downloading/unpacking requests>=2.5,<3 from https://pypi.python.org/packages/py2.py3/r/requests/requests-2.6.0-py2.py3-n
one-any.whl#md5=3ab1972bbaf2802d94516fb86b9b0d0b (from yotta)
Requirement already up-to-date: PyGithub>=1.25,<2 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: colorama>=0.3,<0.4 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: hgapi>=1.7,<2 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: Jinja2>=2.7.0,<3 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: PyCrypto==2.6 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: PyJWT>=0.3,<0.4 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: pathlib>=1.0.1,<1.1 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: jsonschema>=2.4.0,<3.0 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Downloading/unpacking valinor>=0.0.0,<1.0 (from yotta)
Downloading valinor-0.0.2.tar.gz
Running setup.py (path:c:\users\simhug01\appdata\local\temp\pip_build_simhug01\valinor\setup.py) egg_info for package
valinor
Requirement already up-to-date: ntfsutils>=0.1.3,<0.2 in c:\mbed_tools\python27\lib\site-packages (from yotta)
Requirement already up-to-date: markupsafe in c:\mbed_tools\python27\lib\site-packages (from Jinja2>=2.7.0,<3->yotta)
Downloading/unpacking pyyaml>=3,<4 (from valinor>=0.0.0,<1.0->yotta)
Running setup.py (path:c:\users\simhug01\appdata\local\temp\pip_build_simhug01\pyyaml\setup.py) egg_info for package p
yyaml
Downloading/unpacking setuptools from https://pypi.python.org/packages/3.4/s/setuptools/setuptools-14.3-py2.py3-none-any
.whl#md5=fc7acea179a69c7d9bf8b854fe44b029 (from valinor>=0.0.0,<1.0->yotta)
Downloading/unpacking pyOCD>=0.3,<1.0 (from valinor>=0.0.0,<1.0->yotta)
Running setup.py (path:c:\users\simhug01\appdata\local\temp\pip_build_simhug01\pyOCD\setup.py) egg_info for package py
OCD
Downloading/unpacking project-generator>=0.3,<1.0 (from valinor>=0.0.0,<1.0->yotta)
Running setup.py (path:c:\users\simhug01\appdata\local\temp\pip_build_simhug01\project-generator\setup.py) egg_info fo
r package project-generator
Installing collected packages: yotta, requests, valinor, pyyaml, setuptools, pyOCD, project-generator
Found existing installation: yotta 0.0.43
Uninstalling yotta:
Successfully uninstalled yotta
Running setup.py install for yotta
Installing yotta-script.py script to C:\mbed_tools\Python27\Scripts
Installing yotta.exe script to C:\mbed_tools\Python27\Scripts
Installing yotta.exe.manifest script to C:\mbed_tools\Python27\Scripts
Installing yt-script.py script to C:\mbed_tools\Python27\Scripts
Installing yt.exe script to C:\mbed_tools\Python27\Scripts
Installing yt.exe.manifest script to C:\mbed_tools\Python27\Scripts

Found existing installation: requests 2.5.3
Uninstalling requests:
Successfully uninstalled requests
Running setup.py install for valinor
Installing valinor-script.py script to C:\mbed_tools\Python27\Scripts
Installing valinor.exe script to C:\mbed_tools\Python27\Scripts
Installing valinor.exe.manifest script to C:\mbed_tools\Python27\Scripts

Running setup.py install for pyyaml
checking if libyaml is compilable
Microsoft Visual C++ 9.0 is required (Unable to find vcvarsall.bat). Get it from http://aka.ms/vcpython27
skipping build_ext
Found existing installation: setuptools 12.4
Uninstalling setuptools:
Successfully uninstalled setuptools
Running setup.py install for pyOCD
Running setup.py install for project-generator
Installing project_generator-script.py script to C:\mbed_tools\Python27\Scripts
Installing project_generator.exe script to C:\mbed_tools\Python27\Scripts
Installing project_generator.exe.manifest script to C:\mbed_tools\Python27\Scripts

Successfully installed yotta requests valinor pyyaml setuptools pyOCD project-generator
Cleaning up...
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$ yotta -h
Traceback (most recent call last):
File "c:\mbed_tools\Python27\Scripts\yotta-script.py", line 9, in
load_entry_point('yotta==0.1.0', 'console_scripts', 'yotta')()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 521, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2632, in load_entry_point
return ep.load()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2312, in load
return self.resolve()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2318, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "C:\mbed_tools\Python27\lib\site-packages\yotta_init_.py", line 6, in
from .main import main
File "C:\mbed_tools\Python27\lib\site-packages\yotta\main.py", line 14, in
from . import version
File "C:\mbed_tools\Python27\lib\site-packages\yotta\version.py", line 14, in
from .lib import component
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\component.py", line 15, in
import access
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\access.py", line 13, in
import target
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\target.py", line 19, in
import pack
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\pack.py", line 32, in
import registry_access
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\registry_access.py", line 35, in
import settings
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\settings.py", line 42, in
os.path.expanduser(os.path.join(folders.prefix(),'yotta.json'))
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\folders.py", line 27, in prefix
fsutils.mkDirP(dirname)
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\fsutils.py", line 14, in mkDirP
os.makedirs(path)
File "C:\mbed_tools\Python27\lib\os.py", line 157, in makedirs
mkdir(name, mode)
WindowsError: [Error 5] Access is denied: 'C:\Program Files (x86)\yotta'
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$ yotta
Traceback (most recent call last):
File "c:\mbed_tools\Python27\Scripts\yotta-script.py", line 9, in
load_entry_point('yotta==0.1.0', 'console_scripts', 'yotta')()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 521, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2632, in load_entry_point
return ep.load()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2312, in load
return self.resolve()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2318, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "C:\mbed_tools\Python27\lib\site-packages\yotta_init_.py", line 6, in
from .main import main
File "C:\mbed_tools\Python27\lib\site-packages\yotta\main.py", line 14, in
from . import version
File "C:\mbed_tools\Python27\lib\site-packages\yotta\version.py", line 14, in
from .lib import component
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\component.py", line 15, in
import access
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\access.py", line 13, in
import target
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\target.py", line 19, in
import pack
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\pack.py", line 32, in
import registry_access
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\registry_access.py", line 35, in
import settings
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\settings.py", line 42, in
os.path.expanduser(os.path.join(folders.prefix(),'yotta.json'))
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\folders.py", line 27, in prefix
fsutils.mkDirP(dirname)
File "C:\mbed_tools\Python27\lib\site-packages\yotta\lib\fsutils.py", line 14, in mkDirP
os.makedirs(path)
File "C:\mbed_tools\Python27\lib\os.py", line 157, in makedirs
mkdir(name, mode)
WindowsError: [Error 5] Access is denied: 'C:\Program Files (x86)\yotta'
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$ type yotta
yotta is hashed (./yotta)
simhug01@E103032 /c/mbed_tools/Python27/Scripts
$ popd
/c/develop/public/jobs/yr2015/2209/work/20150316/mbed /c/develop/public/jobs/yr2015/2209/work/20150316 /c/develop/public
/jobs/yr2015/2209/work/20150318 ~
simhug01@E103032 /c/develop/public/jobs/yr2015/2209/work/20150316/mbed (master)
$ ls -al
total 29
drwxr-xr-x    1 simhug01 Administ     4096 Mar 16 17:03 .
drwxr-xr-x    1 simhug01 Administ        0 Mar 16 16:52 ..
-rw-r--r--    1 simhug01 Administ     4152 Mar 16 16:58 .cproject
drwxr-xr-x    1 simhug01 Administ     4096 Mar 16 16:53 .git
-rw-r--r--    1 simhug01 Administ      246 Mar 16 16:53 .gitattributes
-rw-r--r--    1 simhug01 Administ      767 Mar 16 16:53 .gitignore
-rw-r--r--    1 simhug01 Administ      832 Mar 16 16:58 .project
-rw-r--r--    1 simhug01 Administ      223 Mar 16 16:53 .travis.yml
-rw-r--r--    1 simhug01 Administ     3363 Mar 16 16:53 CONTRIBUTING.md
-rw-r--r--    1 simhug01 Administ     9280 Mar 16 16:53 LICENSE
-rw-r--r--    1 simhug01 Administ       81 Mar 16 16:53 MANIFEST.in
-rw-r--r--    1 simhug01 Administ     6760 Mar 16 16:53 README.md
drwxr-xr-x    1 simhug01 Administ        0 Mar 16 17:44 build
drwxr-xr-x    1 simhug01 Administ        0 Mar 16 16:53 docs
drwxr-xr-x    1 simhug01 Administ     4096 Mar 16 16:53 libraries
-rw-r--r--    1 simhug01 Administ     1783 Mar 16 16:53 setup.py
drwxr-xr-x    1 simhug01 Administ        0 Mar 16 16:53 travis
drwxr-xr-x    1 simhug01 Administ    12288 Mar 20 10:22 workspace_tools
simhug01@E103032 /c/develop/public/jobs/yr2015/2209/work/20150316/mbed (master)
$ type yotta
yotta is /c/mbed_tools/Python27/Scripts/yotta
simhug01@E103032 /c/develop/public/jobs/yr2015/2209/work/20150316/mbed (master)
$ yotta
Traceback (most recent call last):
File "c:\mbed_tools\Python27\Scripts\yotta-script.py", line 9, in
load_entry_point('yotta==0.1.0', 'console_scripts', 'yotta')()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 521, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2632, in load_entry_point
return ep.load()
File "C:\mbed_tools\Python27\lib\site-packages\pkg_resources_init_.py", line 2312, in load
return self.resolve()

This is fixed on master.


meet error when setting contract

I compile my contract successfully, but can't upload to account. the error message is

Reading WAST/WASM from GeneMelee/GeneMelee.wasm...
Using already assembled WASM...
Publishing contract...
Error 3070002: Runtime Error Processing WASM

the detail of the error messge from the log is

2018-07-24T07:16:44.637 thread-0   http_plugin.cpp:476           handle_exception     ] Exception Details: 3070002 wasm_execution_error: Runtime Error Processing WASM
Nested depth exceeded
{}
thread-0  wasm_eosio_validation.hpp:116 accept
pending console output:
{"console":""}
thread-0  apply_context.cpp:61 exec_one

what is the meaning of this error and how can I locate the problem? thx.

in wasm_eosio_validation.hpp, it restrict the nested depth within 1024. so checking the loop/if/else depths would solve the problem I guess~

got it, thx!


Wrap C bindings into higher-level APIs

Maybe a general API entry?
I'm thinking that maybe we can have a general API entry like
Adbc.Database.connect(uri, driver, options)

For example, it could be
# SQLite
Adbc.Database.connect(
  "file:my_db.db",
  "adbc_driver_sqlite",
  option1: value1,
  option2: value2
)

# SQLite with custom driver
Adbc.Database.connect(
  "file:my_encrypted_db.db",
  "adbc_driver_sqlite_encrypted",
  password: "foo",
  option1: string1,
  option2: string2
)

# PostgreSQL
Adbc.Database.connect(
  "postgres[ql]://[username[:password]@][host[:port],]/database[?parameter_list]",
  "adbc_driver_postgresql",
  option1: string1,
  option2: string2
)

# Other custom databases
Adbc.Database.connect(
  "some_uri://some_parameters",
  "adbc_driver_other_cutsom_db",
  option1: string1,
  option2: string2
)

These options will be equivalent to do
Adbc.Database.set_option(database, "option1", string1)
Adbc.Database.set_option(database, "option2", string2)

in Elixir, but now we can do it in one go in NIF (pass options as a map to NIF, and call AdbcDatabaseSetOption for each key-value pair)
Concrete modules for official drivers
We could also have some concrete modules like Adbc.Database.{SQLite,PostgreSQL,SnowFlake,FlightSQL} so that we can write the following code
# SQLite
Adbc.Database.SQLite.connect(
  "file:my_db.db",
  option1: string1,
  option2: string2
)

# SQLite with custom driver
Adbc.Database.SQLite.connect(
  "file:my_encrypted_db.db",
  driver: "adbc_driver_sqlite_encrypted",
  password: "foo",
  option1: string1,
  option2: string2
)

# PostgreSQL
Adbc.Database.PostgreSQL.connect(
  "postgres[ql]://[username[:password]@][host[:port],]/database[?parameter_list]",
  option1: string1,
  option2: string2
)

# ...

Yes, my goal is to explore those during the live stream and build it with the community, if that's ok?

Yeah, that's definitely okay! I left it here as an initial idea. :)

This is well under way now. :)


No "Open Value in Data Viewer" in VS Code Variable View

Type: Bug
It becomes painful that I have to go to the legacy one to view data frames.
Extension version: 2024.3.2024032701
VS Code version: Code - Insiders 1.88.0-insider (aa25485166449aa0f9eb8ebd8d0b70376108633c, 2024-03-28T22:10:25.599Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 7600X 6-Core Processor              (12 x 4700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.16GB (5.82GB free)

Process Argv
--enable-proposed-api ms-vscode.dscopilot-agent --enable-proposed-api ms-toolsai.datawrangler --crash-reporter-id acfa600b-65c9-4131-81cf-ad8200ffb7d3

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593:30376534
py29gd2263:30784851
vscaat:30438846
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialogc:30812479
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
bf62j303:30968145
cppperfnew:30980852
d34g3935:30961436
fegfb526:30952798
bg6jg535:30979844
ccp2r3:30958153
pythonait:30973460
gee8j676:30988845
g1icg217:30999571

Best option here is to contribute an option to search for Dataviewer extensions if they don't have any, but I'm not sure if we are able to do that. Otherwise, we can take the same route as Jupyter's variable view and delegate to the appropriate extension.
We should also get DW extension to contribute their data viewer here.

Given the architecture of the ntoebook editor and output rendering, this will be a very challenging task to achieve.
Unfortunately there are no plans to resolve this issue due to the technical challenges


refactor: l1 l2 messages cleanup

Fixes #5264

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5270  👈
#5206
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

circuit_simulation_time_in_ms (public-kernel-app-logic): 530 (+19%)
circuit_simulation_time_in_ms (public-kernel-tail): 203 (+17%)
tx_sequencer_processing_time_ms (1): 1,452 (+17%)
l2_block_building_time_in_ms (32): 85,632 (+25%)
l2_block_building_time_in_ms (64): 174,988 (+29%)
l2_block_public_tx_process_time_in_ms (32): 56,374 (+42%)
l2_block_public_tx_process_time_in_ms (64): 118,008 (+49%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit edb8c679 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
5,668
18,820
36,356

l1_rollup_calldata_gas
66,388
239,032
469,832

l1_rollup_execution_gas
647,486
929,390
1,306,012

l2_block_processing_time_in_ms
1,347 (+4%)
5,110 (+11%)
9,784 (+4%)

note_successful_decrypting_time_in_ms
166 (-11%)
543 (+2%)
1,020 (+4%)

note_trial_decrypting_time_in_ms
71.1 (-21%)
64.3 (+16%)
56.1 (-53%)

l2_block_building_time_in_ms
18,136
:warning: 85,632 (+25%)
:warning: 174,988 (+29%)

l2_block_rollup_simulation_time_in_ms
8,090 (-1%)
29,203 (+2%)
56,881 (+1%)

l2_block_public_tx_process_time_in_ms
10,025
:warning: 56,374 (+42%)
:warning: 118,008 (+49%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,768 (-1%)
27,381

note_history_successful_decrypting_time_in_ms
1,198 (-4%)
2,382 (-1%)

note_history_trial_decrypting_time_in_ms
64.4 (-33%)
113 (-3%)

node_database_size_in_bytes
19,083,344
35,721,296

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
279 (-1%)
44,366
28,244

private-kernel-ordering
212 (-1%)
52,868
14,326

base-parity
1,804
128
311

base-rollup
721
165,787
925

root-parity
1,629 (+3%)
1,244
311

root-rollup
51.6 (-18%)
4,487
725 (-8%)

private-kernel-inner
636 (-1%)
73,771
28,244

public-kernel-app-logic
:warning: 530 (+19%)
35,260
28,215

public-kernel-tail
:warning: 203 (+17%)
40,926
28,215

merge-rollup
8.40
2,696
925

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.1 (+1%)
16.0
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.589 (+1%)
0.496
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
47.5 (+3%)
73.6 (+2%)
239 (+3%)
443
911 (+3%)
1,739 (+1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.488 (+3%)
0.455 (+2%)
0.436 (+3%)
0.415
0.432 (+3%)
0.417 (+1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
54.2 (-1%)
111 (+4%)
348 (+3%)
659
1,442 (+10%)
2,835 (+9%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
104
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.483 (-1%)
0.501 (+4%)
0.475 (+4%)
0.454
0.501 (+10%)
0.494 (+9%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
62.5 (+2%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.547 (+2%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes

tx_size_in_bytes
22,012

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
3,189 (-2%)
1,727 (-1%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
12.0 (+9%)
:warning: 1,452 (+17%)


[ldd-disp] Axis names are not being validated

Describe the issue identified (if applicable)
The horizontal_display_axis and vertical_display_axis attributes are expected to match the name of an axis in the associated array, but this is not being enforced. Labels where the axis names don't match (for instance, if the case does not match) are passing validation. An example of one such label is attached.
Describe the solution you'd like
I would like to Schematron rules added that require that the horizontal_display_axis and vertical_display_axis attributes match the axis_name of one Axis_Array element in the associated array.
LDD Dictionary Version
<IP_ADDRESS>
Additional context
703_20210708_2B_N19079_01_0004.arch.txt

@jstone-psi Does geom:horizontal_display_axis have the same schema need?
Also should those be enumerated such that only "Sample" and "Line" are available. Could there be other options supported?

@thareUSGS Yes, I believe that geom:horizontal_display_axis and geom:vertical_display_axis will ultimately have the same need. The documentation for those attributes matches the equivalent attributes in the display dictionary.
I don't believe that having only Line and Sample immediately makes sense. Currently, the documentation for the display direction classes only states that it must match an exisitng axis_name. I would think that's intentional, and that it should be enforced as written for now.

Now let's see if I can figure out how to do a schema rule for those...


Occurrences of a libstd or libextra item in the tutorial and manual should link to the docs for it

 Issue by lkuper
Monday May 27, 2013 at 04:42 GMT
For earlier discussion, see https://github.com/rust-lang/rust/issues/6758
This issue was labelled with: A-rustdoc, E-hard, I-wishlist in the Rust repository

Masklinn recently suggested on rust-dev that it would be nice to have cross-linking within the generated HTML docs.  E.g., an occurrence of "println" in the tutorial would be a link to here (if I understand the suggestion correctly).  We could do this cross-linking for all top-level items: types, traits, functions, impls, etc.
I wouldn't expect this to happen for code blocks, just for inline code.  Ideally, there would also be a way to turn it off -- both in the sense that we might want to be able to tell rustdoc not to do cross-linking on a particular run (to make the docs build faster), and in the sense that we might want to be able to specify that particular occurrences should never be cross-linked (because after a point it might hinder readability).
Presumably we'd also eventually want this cross-linking within the documentation itself, too, as well as in the tutorial and manual.

Closing in favor of https://github.com/rust-lang/rust/issues/43466.


update readme files to include node v13 advisories

Fixes #376
This is a simple PR adding a helpful message to users that are using Node version 13. It will help them avoid issues when using create-near-app.

Thanks again, @thisisjoshford!


Composite actions: support for existing audits

#331 will add composite action support. From there, the current audits need to be extended to work with composite actions, where appropriate.

[ ] artipacked
[x] dangerous-triggers (N/A)
[x] excessive-permissions (N/A)
[ ] hardcoded-container-credentials (N/A?)
[x] impostor-commit: #331
[ ] known-vulnerable-actions
[ ] ref-confusion
[ ] self-hosted-runner (N/A?)
[x] template-injection: #331
[ ] use-trusted-publishing
[ ] unpinned-uses
[x] insecure-commands #359
[x] github-env #358
[ ] cache-poisoning (N/A?)

I'm going to keep burning this down, but I would appreciate help as well! If anybody is interested in working on one of these, leave a comment here and I'll assign it to you 🙂

@woodruffw Happy to help here!
Let me give a try on known-vulnerable-actions, unpinned-uses, and ref-confusion`, they don't look too hard and I can learn a bit more about their inner details along the way. I'll raise individual PRs for each one, for the sake of easier reviews 🙂


getter/setter properties don't decompile correctly

For example: Sprite.z, Sprite.left, etc.

@riknoll Last we talked about this I think you said this was fixed (and it is for most), but Sprite.image is still failing to go script->blocks and shows up as a grey block
example

Right... It's probably a bug in our weird dropdown logic. Probably caused by the fact that it's a dropdown with 1 item (or at least it used to be)


route token added

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

[x] Asset is registered to the Cosmos Chain Registry.
[x] Add asset to bottom of zone_assets.json.

[x] chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
[x] path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
[x] osmosis_verified is set to false
[x] listing_date_time_utc is specified and accurate
[ ] Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).

Thanks for the submission but the chain is still missing. Please add a chain to zone_chains, and include the Adding Chains checklist.

Thanks @JeremyParish69, its updated now!

Sorry, the check is failing because the IBC connection is not yet registered at the Cosmos Chain Registry: https://github.com/cosmos/chain-registry/tree/master/_IBC

Thanks, for pointing out. https://github.com/cosmos/chain-registry/pull/5128 raised the PR


Update Python versions

After creating your pull request, tick these boxes if they are applicable to you.

[x] I have tested my changes against the dev branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.9 or higher
[x] I have ensured my code is formatted using Black

Description
The minimum Python version is bumped to 3.9 to fix compatibility with new code.
Where possible, we now try to use the latest Python version (3.12).
Related issues (if applicable)
https://github.com/Just-Some-Bots/MusicBot/issues/2368

I would suggest keeping 3.8 in this PR.  I've fixed my typing blunder with #2370  which will let it work again.
Or at least its an option. :P

I would suggest keeping 3.8 in this PR. I've fixed my typing blunder with #2370 which will let it work again. Or at least its an option. :P

Yeah I guess a maintainer can make a decision on how to proceed 👍

By the way, as far as I know aiohttp a required dependency is still failing on build wheels on 3.12, I'm hoping they fix that soon.
For the time being, I will continue backwards compatibility, until told otherwise from the code owners.

By the way, as far as I know aiohttp a required dependency is still failing on build wheels on 3.12, I'm hoping they fix that soon. For the time being, I will continue backwards compatibility, until told otherwise from the code owners.

I tested all the versions by bumping the version in the Docker file and it ran just fine for all.python versions from 3.9 to 3.12 so I think that problem is fixed

I tested all the versions by bumping the version in the Docker file and it ran just fine for all.python versions from 3.9 to 3.12 so I think that problem is fixed

Using windows 10 22h2, I still fail the build wheel on 3.12.1. The "solution" is to install Microsoft C++ Build Tools. I don't like this as a solution though since it's a 4-6gb download, which is a lot for users who might not have a ton of space on a vps. It builds fine on 3.8-3.11 without the additional tools. So I don't think it's anything on our end in the project.


Adding value_and_jacrev and value_and_jacfwd

In almost all uses (that I have come across), the value of the function is also wanted when calculating the Jacobian. To be able to obtain both of these without running the function and the Jacobian separately (which does two computations of the function) I have moved jacrev and jacfwd to _jacrev and _jacfwd which now take a parameter return_value: bool = False. I have then written thin wrappers,  jacrev, value_and_jacrev, jacfwd and value_and_jacfwd around _jacrev and _jacfwd. This means jacrev and jacfwd act exactly as before but we now can return an evaluatable function which returns the value and the Jacobian exactly like value_and_grad.

@googlebot I fixed it.

@googlebot I fixed it.

Hi, I was just wondering if there was anything in particular stopping this merge?

Hi, I was just wondering if there was anything in particular stopping this merge?

@tomcharnock let me know if you're keen to follow up on this; otherwise I can make some revisions and add commits to this PR!

@googlebot I fixed it.

@tomcharnock let me know if you're keen to follow up on this; otherwise I can make some revisions and add commits to this PR!

Hi @mattjj,
I've just done an update this morning to make value_and_jacrev and value_and_jacfwd follow the stylings of value_and_grad and jacrev and jacfwd to follow grad. I agree that this clears up the code a bit and removes the non-public _jacrev and _jacfwd.
What do you think?


and xOffset :)

https://github.com/MickaelHrndz/entry/blob/7505b0c93c53752f239851b6cd824002e6d0306b/lib/entry.dart#L48

Nice catch, thanks :) Solved with the 0.0.7 release
https://github.com/MickaelHrndz/entry/blob/9ef5e9f2c1c896ca98772ab29af2d93d464723f0/lib/entry.dart#L52


JavaScript different on different platforms?

This issue is a Bug
Reported by Michelle SIntov:
We discussed that in our project, we have iOS JS that is not the same as Android JS. Maybe this is because we are using WKWebView? Here are screen shots of our Android JS and then iOS folders, for what it's worth. I think you said that readium-shared-js should be the same across platforms?
Related issue(s) and/or pull request(s)
None known
Expected Behaviour
shared-js shouldn't vary across platforms
Observed behaviour
It does??
Steps to reproduce
Look at screen shot

Test file(s)
If relevant, please indicate public EPUB URL(s), or whether you can share ebook(s) privately.  It is often next to impossible to reproduce bugs without the original file.
Product
SDKLauncher-iOS vs.
SDKLauncher-Android
Additional information
None available

Something seriously wrong with the shared-js folder on iOS.  See this screen shot of my tree from 0.25-alpha:

Somehow most of the  needed folders are missing.  FPP must be loading the lib from one of the bundle folders.  Not good practice.
@danielweck Any comment?

The source tree for SDK Launcher iOS includes the readium-shared-js Git submodule inside the Resources subfolder, instead of the usual top-level folder (as in OSX and Android launchers):
https://github.com/readium/SDKLauncher-iOS/tree/develop/Resources
However, the App Bundle generated by the XCode build script does not (naturally) include the entire readium-shared-js directory, which would be enormous (including the readium-cfi-js Git submodule too!).
Instead, the XCode project configuration picks a select number of files to be included in the generated App Bundle:
https://github.com/readium/SDKLauncher-iOS/blob/develop/SDKLauncher-iOS.xcodeproj/project.pbxproj
Strictly-speaking, a vendor will typically choose to deploy their app with the single RequireJS module bundle (which includes the Almond lightweight AMD loader), rather than the multiple bundles (one each for CFI lib, external libs, etc.) which require a separate full-fat RequireJS loader script (see contents in https://github.com/readium/readium-shared-js/tree/develop/build-output/_multiple-bundles ).
So, that's basically readium-shared-js/build-output/_single-bundle/readium-shared-js_all.js and its associated source map (in the same folder), see contents in https://github.com/readium/readium-shared-js/tree/develop/build-output/_single-bundle

As for SDKLauncher-Android, the readium-shared-js Git submodule is located in the top / root folder:
https://github.com/readium/SDKLauncher-Android/tree/develop
The Gradle build script (which Android Studio uses to generate the application APK) takes care of copying the RequireJS AMD module bundles to a suitable location:
https://github.com/readium/SDKLauncher-Android/blob/develop/SDKLauncher-Android/app/build.gradle#L20
task buildCssAssets(type: Copy) {
    from '../../readium-shared-js/build-output/css'
    into './src/main/assets/readium-shared-js/builds/css'
}

task buildSingleBundleAssets(type: Copy) {
    from '../../readium-shared-js/build-output/_multiple-bundles'
    into './src/main/assets/readium-shared-js/builds/multiple-bundle'
}

task buildMultipleBundleAssets(type: Copy) {
    from '../../readium-shared-js/build-output/_single-bundle'
    into './src/main/assets/readium-shared-js/builds/single-bundle'
}

It's a similar story with SDKLauncher-OSX:
https://github.com/readium/SDKLauncher-OSX/tree/develop
https://github.com/readium/SDKLauncher-OSX/blob/develop/LauncherOSX.xcodeproj/project.pbxproj
(files copied from readium-shared-js/build-output/ to a suitable project location)

Looking at the file system screenshots in the issue description, I am under the impression that the way ReadiumJS is integrated in the vendor app has diverged from the model used in Readium's "launcher apps".

@msintov


Add application logs section when using tokio-console

Something to see & filter the logs from your application.

Yeah, we'd definitely like to eventually have a way to stream a log of all tracing events from the program. One thing we've also considered is adding a way to filter event logs by task, and display a log of all the events that occurred within a particular task in the Task Details view. Of course, we could also show event logs for all tasks,
Some design considerations:

This should probably be a separate RPC than the main Instrument::watch_updates RPC. We're already streaming a lot of data from the instrumented application, and most of the views the console currently provides probably won't display logs by default. Therefore, we'll probably want to have a way to toggle on and off log streams separately from other data streams, so that we're only streaming them as needed.
How would we want to filter what logs are displayed?
Since we can stream logs as structured data rather than as strings, we can probably display them in some much more interesting ways than just a bunch of lines of text --- e.g. some data can be conditionally hidden or shown. However, we probably want to start with something simple and then iterate on it.


Claimed Addresses - Profile Info

Hi, I'm Hiturunk, founder of penguinparty.eth, the first Uniswap decentralized delegate.
I am submitting this PR to claim our multi-sig wallet's address and to move the focus of our platform to our Medium account, which is our main way of discussing proposals with the community.
I will be happy to sign a message with my key to prove my identity if such is requested to get this PR'd.

Oops, missed a "}". :D Resubmitting..


docs: remove binary in package

Signed-off-by: Allen Sun<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
remove binary in package.
In the source code of Dragonfly, I do not think we should vendor this binary file.
In the future we could make this binary stored in the release link or somewhere else.
Ⅱ. Does this pull request fix one issue?

none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #226   +/-   ##
======================================
  Coverage    72.4%   72.4%
======================================
  Files          29      29
  Lines        1435    1435
======================================
  Hits         1039    1039
  Misses        365     365
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa8035...dd8dbbe. Read the comment docs.

lgtm


Refactor mempool tests

Motivation

I was working on tests for #2682, and I saw an opportunity to tweak unmined_transactions_in_blocks a bit, but ended up getting carried away and refactored some other parts as well. I'm not sure if these are good ideas, so any feedback is welcome.
Solution

The biggest change is that unmined_transactions_in_blocks receives a range of block heights instead of a maximum height, and returns an iterator instead of a tuple with a Vec and the transaction count. The code that use this function were also tweaked a bit in an attempt to make clearer how the unmined transactions were being used and to remove some redundancy.
Review

Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

In https://github.com/ZcashFoundation/zebra/pull/2770 I created a test that had to split the tx list in three parts (the first, the rest except the last, the last, and a reference to the second-to-last). I tried to come up with a non "C-like" way that did not uses indices everywhere, but it relied on some Vec methods (pop()). Here you also had to convert it back to Vec, so maybe unmined_transactions_in_blocks could be reverted to return Vec again, but leaving the other improvements? (Not really sure if that would be better)

In #2770 I created a test that had to split the tx list in three parts (the first, the rest except the last, the last, and a reference to the second-to-last). I tried to come up with a non "C-like" way that did not uses indices everywhere, but it relied on some Vec methods (pop()). Here you also had to convert it back to Vec, so maybe unmined_transactions_in_blocks could be reverted to return Vec again, but leaving the other improvements? (Not really sure if that would be better)

Interesting problem! Regarding keeping the return type as Vec, I think that's not necessary, you can call .collect() after the function call and get the same result. But if you want to do it without using Vec methods, my first thought would be to try something like:
let mut transactions = unmined_transactions_in_blocks(height, network);
let first_transaction = transactions.next().unwrap();
let last_transaction = transactions.next_back().unwrap();

// Then use the "middle" transactions in `transactions`

Another option for when the iterator is not a DoubleEndedIterator is:
let mut transactions = unmined_transactions_in_blocks(height, network);
let first_transactions = transactions.next().unwrap();
let mut transactions: Vec<_> = transactions.collect();
let last_transaction = transactions.pop().unwrap();

Not sure if this helps :sweat_smile:

I don't mind what you do here - whatever works best for writing tests.
But I want to encourage you to merge this refactor soon, so it doesn't block other work, or cause rework.


num_readouts=1 seems broken

genmove b
A19
genmove w
Illegal move (tries to play on A19 again?)

which engine?

I thought it was python.
Offline Andrew thought it's  might be a bad "<" vs "<=" from this code

BOARD_SIZE=19 python3 main.py gtp -l models/000303-olympus -v 3 --resign_threshold=-0.98 --num_readouts 1 --parallel_readouts=1

Reopening this issue:

C++ exhibits the same illegal move behaviour with --num_readouts=1.
As Seth mentioned, Python behaviour with --num_readouts=1 seems weird.

sigh C++ soft pick also has problems when num_readouts=1.


How to tell cythonize() to name the generated extension module source file by another name?

lets say for example someone got an python script named test.py. How can they tell cythonize that instead of generating it as test.c to name the generated c file as testmodule.c?

Should be possible by passing an Extension instance into cythonize().

🤔

Please read the  documentation:
http://docs.cython.org/en/latest/src/reference/compilation.html#configuring-the-c-build
And please do not use the bug tracker for support questions.


⚠ Bofrost.at has degraded performance

In e7885c5, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2274 ms

Resolved: Bofrost.at performance has improved in d31a0b5 after 6 minutes.