refactor BaseSidebarScreen to function

Details

Refactor  BaseSidebarScreen.js  to functional component
Fixed Issues

$ https://github.com/Expensify/App/issues/16272
PROPOSAL: _
Tests

Open the app
Verify a sidebar appears displaying works well

[x] Verify that no errors appear in the JS console

Offline tests
The same with Test

QA Steps
The same with Test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/39086067/b9a05862-3c7f-4634-a76c-5dcbf8377f01

Mobile Web - Chrome
https://github.com/Expensify/App/assets/39086067/5c2ed521-04e2-4b23-9be9-8a32c099cd25

Mobile Web - Safari
https://github.com/Expensify/App/assets/39086067/04b7c19c-cdfd-41f5-b6d7-1006f69e45ab

Desktop
https://github.com/Expensify/App/assets/39086067/45491957-4eb2-4216-a7e6-36063cd3272c

iOS

https://github.com/Expensify/App/assets/39086067/6093358e-389e-44e3-b854-e3a9623a1c91

Android
https://github.com/Expensify/App/assets/39086067/6131f752-ad57-44ae-9e03-46473e2a6fe9

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fixes #77: Find case tags command

Task of user story #214

Pull Request Test Coverage Report for Build 169

30 of 30 (100.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 84.998%

Totals

Change from base Build 167:
0.2%

Covered Lines:
2068

Relevant Lines:
2433

💛  - Coveralls

Test cases implemented #220


Performance visbility

Purpose
Add debugging tools to the deploy task and make a few small changes that might help performance.
How

Adds duration metrics for all the major steps in a deploy
Changes the timeout used by kubectl to 15s (down from 30s)
Adds retries to the cache-population step. The only way I can think of to make multiple kubectl processes request all resources of a given kind in parallel is for this cache to be empty, so let's try harder to make sure it isn't.
Caches the list of CRDs. The call likely isn't very expensive, but I noticed in my debugging efforts that we're requesting them over and over for no good reason.
Makes debug logging more usable
Reverts the batch size optimization. I don't think that it is causing the problem, but it doesn't hurt to eliminate this as a reason for the cache being unpopulated. I also now think there might be better solutions to underlying problem that was trying to solve.

The functional diff is actually quite small. Most of the changes are moving code around and fixing unit tests. The changes are fully tested and all tests are passing.

Was I looking at an older version?
[image: Screen Shot 2018-11-26 at 2.47.54 PM.png]
On Mon, Nov 26, 2018 at 2:38 PM Katrina Verey<EMAIL_ADDRESS>wrote:

@KnVerey commented on this pull request.
In lib/kubernetes-deploy/kubectl.rb
https://github.com/Shopify/kubernetes-deploy/pull/381#discussion_r236455676
:

   end

   if raise_if_not_found && err.match(NOT_FOUND_ERROR_TEXT)

     raise ResourceNotFoundError, err

 out, err, st = nil

 (1..attempts).to_a.each do |attempt|

   @logger.debug "Running command (attempt #{attempt}): #{args.join(' ')}"

   out, err, st = Open3.capture3(*args)

   @logger.debug("Kubectl out: " + out.gsub(/\s+/, ' ')) unless output_is_sensitive?

   if st.success?

     break

   else

     if log_failure

       @logger.warn("The following command failed: #{Shellwords.join(args)}")

It does though:
[image: image]
https://user-images.githubusercontent.com/4789493/49045961-987a1880-f1a0-11e8-9d31-8884e17f62d8.png
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/kubernetes-deploy/pull/381#discussion_r236455676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALoOBov4wCBidh1gEsQRj4M3uN9vvurzks5uzG18gaJpZM4YyPsj
.


POC: neotest integration

Got a response from the author regarding async test discovery & debugging
https://github.com/nvim-neotest/neotest/discussions/322

@s1n7ax  Are you working on this ? I'm would like to impement this.

@atm1020 Give it a shot. I couldn't get it working. Check the linked discussion first.

@s1n7ax should the implementation be in a different repository, or is it fine to include it in the nvim-java repo?

@atm1020 New repo would be ideal.

would be a great feature :)!

@s1n7ax  I think I made some progress, but I skipped using the LSP method to check if the file is a test file. Neotest heavily relies on the is_test_file method,  when I used lsp for this, it made everything really slow (i mean project scan etc). So, I tried to set up the other stuff.  (however, when I tried, the folder filter method didn't work well, so lot of wrong files were sent to to the server)
project repo. It's depends on the nvim-java-test and nvim-java-core project, I added a separate logger to it for better debugging.
Currently, I'm not sure if it's fully async, and I don’t really know the proper way to check it, so I hope you can help with this too.
working features:

run/debug : folder/class/method.

limitation:

With the new neotest version, the project is duplicated in the tree view (fully scanned two times). I think its related to this - pr, but I haven't looked into it yet. (this pr enables the watch feature)

For the treesitter query i used the neotes-java project
I'm curious what you think about it.

@s1n7ax Did you have time to check it?

I'll check now

@atm1020 I see you have not used some of the features from jdtls for instance for is_test_file check. Is it because you cannot do asynchronous with neo-test?

This is good enough for a initial release. I will include this project in the future.

@atm1020 I see you have not used some of the features from jdtls for instance for is_test_file check. Is it because you cannot do asynchronous with neo-test?

Neotest heavily relies on the is_test_file method. When I used LSP for this, it made everything really slow. However, I will check it again because I have some issues with a project scan, so maybe it was running for a lot of unnecessary files

This is good enough for a initial release. I will include this project in the future.

@s1n7ax It has one bigger issue, for some reason, the full project scan runs twice. This is why the project is duplicated in the tree view. I think I need some time to fix it.
The project can be used with the current nvim-java test running feature, so I think it won't cause big issues/headache for the users.(may be it can be released as a preview/optional feature )
Do you have any advice or suggestions for the  project?

The way they scan the file tree is not suitable for java but there is no any other option I guess. Instead of using the hard coded java test package names I would call findTestPackagesAndTypes LS call to get the information. Then de structure the path filter out the paths passed by neotest.
https://github.com/nvim-java/nvim-java-core/blob/1ce1143c595c5f6357bede19e9bf4000bf7f980c/lua/java-core/ls/clients/java-test-client.lua?plain=1#L50-L55
Additionally you have following to get the tests.
https://github.com/nvim-java/nvim-java-core/blob/1ce1143c595c5f6357bede19e9bf4000bf7f980c/lua/java-core/ls/clients/java-test-client.lua?plain=1#L61-L66
I guess you can use request_sync to get the information in respective filter functions.
I would make it independent of nvim-java-core so other people can use it. For dependencies you can copy the files from java-core to the project.

Thanks for the suggestions!
I would make it independent from the nvim-java-test project too. I think theres room to improve the test parser functions or to create better integration for Neotest.  What do you think ?

@s1n7ax  Based on your suggestions I changed the is_test_file and filter_dir functions; now they are based on the jdtls responses.
I think the vscode.java.test.findJavaProjects and vscode.java.test.findTestPackagesAndTypes requests return all the information needed for the is_test_file and filter_dir functions, because  these functions  called heavily, caching the response of the vscode.java.test.findTestPackagesAndTypes request might be a better option (but this one lsp call still froze my editor a little bit..).
So I think the vscode.java.test.findTestPackagesAndTypes  request needs to be recalled whenever a new Java file is created and during the first neotest call (or possibly after the jdtls startup instead of the first neotest call, but I'm not sure about this.)
The stdout is captured by the dap console, the Junit log doesn't contain that. But we can get the dap console bufnum (https://github.com/atm1020/neotest-jdtls/blob/25438fe69aa2e168bd8594d6320d56404fcd10b5/lua/neotest-jdtls/neotest/impl/excute.lua#L216) and  for example create a console for a simple test run or capture the output for the neotest result viewer.

but this one lsp call still froze my editor a little bit..

Do you have the LSP call changes in a branch. I tried to implement that using nio library. Ran into this issue once again
https://github.com/nvim-neotest/neotest/issues/444

We can figure out caching later. Worst case would be using some last updated time to update the current tests.

@s1n7ax  I think  Ive reproduced your bug, and I found that the neotest log contains error message like this:
lazy/nvim-nio/lua/nio/tasks.lua:206: Wrapped function failed: ...cal/share/nvim/share/nvim/runtime/lua/vim/lsp/client.lua:675: E5560: nvim_get_current_buf must not be called in a lua loop callback
stack traceback:

When I use nio.schedules()  before the nio wrapped cliet client calls, it starts to work  (https://github.com/atm1020/neotest-jdtls/blob/5141addd5d6562e6ae53fa44e52744e075994af7/lua/neotest-jdtls/neotest/adapter.lua#L38).
I pushed changes where the test file check is based on the java.project.isTestFile jdtls call like in your example.

@atm1020 Planning to add it this week. Can you see why this is not working in this project? Could be because junit5.
https://github.com/s1n7ax/spring-boot-assignment

@s1n7ax  I think the issue is that the java.project.isTestFile jdtls request returns true for the ReaderData.java file. However since there are no tests in this file the vscode.java.test.findTestPackagesAndTypes command doesn't return it (the is_test_file neotest function was based on this response in the older versions.). So i didnt encounter the problem when vscode.java.test.findTestTypesAndMethods returned nil for a file during the test runs.
I plan to simply mark these kinds of files/packages as skipped.

Currently, the jdtls calls are somewhat mixed, i mean hte is_test_file and filer_dir neotest functions are based on the nio-wrapped client, while the others are not. I think  i wil rewrite everything to use the nio wrapped client.

Could be because junit5. https://github.com/s1n7ax/spring-boot-assignment

As far as i know, the current parser, only supports junit5 .

@s1n7ax  I fixed the problems.
All the jdtls calls now use the nio wrapped lsp. I think this change has also resolved the "editor freeze" problem. Can you check it, please ?


Data Visualization with Tables in React.

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
Data Visualization with Tables in React.
Introduction paragraph (2-3 paragraphs):
Working with tables in React has always been a burden for a very long time now. issue related to the styling, responsiveness, and the proper rendering of data on tables has been encountered by a lot of developers whenever they're trying to render a lot of data onto the UI of a web-application
In this article, we are going to look at an approach that would enable us to properly visualize data on tables with an npm package, called react-table. It is a library that focuses on the React Hooks pattern, therefore abstracting the need to manually create or write out HTML table elements.
Key takeaways:
The reader(s) will be able to:

Create extensively rich tables that would be accessible for people
Interact with JSON dummy data that would be rendered on the table UI
Get an understanding of how columns works, how to create an instance of such column with the JSON data that is available.

References:
None
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Good afternoon and thank you for submitting your topic suggestion. @Caleb335
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Thank you for the feedback @ahmadmardeni1

Great topic 🚀 @Caleb335 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid any potential article closure, it should not overlap with any existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.

Thank you @ahmadmardeni1! ✊
I'd take note of all that you've mentioned.


[release/1.3 backport] Add logging binary support when terminal is true

Backport of #4502. I've cherry-picked the individual commits from that pull request, and added a separate commit for a minor modification required for compatibility with containerd 1.3

Currently the shims only support starting the logging binary process if the
io.Creator Config does not specify Terminal: true. This means that the program
using containerd will only be able to specify FIFO io when Terminal: true,
rather than allowing the shim to fork the logging binary process. Hence,
containerd consumers face an inconsistent behavior regarding logging binary
management depending on the Terminal option.
Allowing the shim to fork the logging binary process will introduce consistency
between the running container and the logging process. Otherwise, the logging
process may die if its parent process dies whereas the container will keep
running, resulting in the loss of container logs.
Signed-off-by: Akshat Kumar<EMAIL_ADDRESS>

@akshat-kmr could you mind to use cherry-pick -x to mark the origin commit? thanks

@akshat-kmr could you mind to use cherry-pick -x to mark the origin commit? thanks

Thanks, I've done so. The first 3 commits are marked with -x and point to the commits merged in the master PR. Let me know if you meant something else.

I think we should only backport security fixes

Agreed, I don't think we should backport this change to 1.3

Sounds good, in that case I will close this PR. The backport to 1.4 should be fine though, correct? If so, I would appreciate if you can take a look when you have a chance @AkihiroSuda https://github.com/containerd/containerd/pull/4615

No, this shouldn't be back ported to 1.4 either, unless there is very specific reason


mova not implemented

In some specific cases, fxc will emit the mova instruction, which moves a float or int value into the a0 address register (which is an integer).
So the source assembly would look like:
dcl_blendindices v6
mova a0.x, v6.x

However, right now the generated GLSL looks like this:
vec4 vs_r1;
ivec4 vs_a0;

// error C7011: implicit cast from "float" to "int"
vs_a0.x = vs_r1.z;

Should be an easy fix, just ensure that we do an explicit cast when handling mova.

This is where the important stuff starts:
https://github.com/FNA-XNA/MojoShader/blob/upstream/profiles/mojoshader_profile_glsl.c#L258
We also need the shader binary in question.

Whoops, it’s actually its own function:
https://github.com/FNA-XNA/MojoShader/blob/upstream/profiles/mojoshader_profile_glsl.c#L1670


Fixed #34515 -- Made LocaleMiddleware prefer language from paths when i18n patterns are used.

ticket-34515
See discussion.

I'm going to squash commits before merging.

buildbot, test on selenium.

Thanks for reviews :+1:


mkdocstrings.plugin: configuration item 'site_url' is required for cross-references

Hi and apologies if this is not the place to ask, but I was not able to find the answer in the documentation or using google search
I am playing with mkdocs (version 1.1.2) and mkdocstrings (version 0.13.0) to try and document a small project (early stage of development) and I am getting this error message
mkdocstrings.plugin: configuration item 'site_url' is required for cross-references
every time I try and run mkdocs build
The structure of the project is below, the content of the mkdocs.yml file is
site_name: dl4seas

theme:
  name: "material"
  palette:
    primary: lime
  features:
    - instant
    - navigation.expand

plugins:
  - search
  - mkdocstrings

repo_url: https://github.com/nicolasfauchereau/dl4seas

nav:
    - Home: index.md
    - Installation: installation.md
    - Code Reference:
        - utils: utils-reference.md

extra:
  social:
    - icon: fontawesome/brands/twitter
      link: https://twitter.com/nfauchereau
    - icon: fontawesome/brands/github
      link: https://github.com/nicolasfauchereau

structure
.
├── docs
│   ├── index.md
│   ├── installation.md
│   └── utils-reference.md
├── init.py
├── IO
│   ├── init.py
│   ├── netcdf_to_TF_records.py
│   └── xarray_to_TF_record.py
├── mkdocs.yml
├── NN
│   ├── init.py
│   ├── PeriodicConv2D.py
│   ├── PeriodicPadding2D.py
│   ├── PrunePeriodicPadding2D.py
│   ├── pycache
│   ├── ResizeLayer.py
│   └── XrDataGenerator.py
├── preprocessing
│   ├── init.py
│   └── train_scaler.py
├── pycache
│   └── init.cpython-37.pyc
├── setup.py
└── utils
├── init.py
├── list_files.py
├── pycache
├── roll_longitudes.py
└── shift_time.py

Hello! It's OK, I'm not yet overwhelmed with questions on my open source projects :slightly_smiling_face:
As the message says, you need to set the site_url value in mkdocs.yml. The error message could state this more clearly :slightly_smiling_face:

For further reference, site_url is documented here: https://www.mkdocs.org/user-guide/configuration/#site_url
and is a top level config value in the YAML.

site_url will not be required anymore in the next version, 0.13.1. Closing!


Loader color

Loader is color isn't changing. Its always white

Hello @adarshmanoharan ,
Thanks you for finding this issue. I've updated the library as version 1.6. Now you can change loader colour with "lb_loaderColor" attribute.


nsh: support watch command

Summary
nsh: support watch command
Impact
Testing
sim

[Experimental Bot, please feedback here]
This PR appears incomplete based on the NuttX requirements. Here's why:

Summary Lacks Detail:

Why?  The summary just states "nsh: support watch command." Explain the reason for this change. Is it a new feature request, a bug fix, or an improvement?
What/How? Provide more detail on the functionality of the watch command. What does it do? How will users interact with it?
Links: Include links to any related NuttX issues or pull requests.

Impact is Empty:  You need to address each impact category:

New/Changed Feature?  Yes, it seems like a new feature. Describe it.
User Impact? Will users need to change anything in their existing scripts or usage?
Build Impact?  Does adding this command change anything about how NuttX is built?
Hardware Impact?  Are there specific hardware requirements for this command?
Documentation? Does this PR include documentation updates for the watch command? If not, mention that it's needed.
Security/Compatibility?  Consider if this command has any security implications or affects compatibility.

Testing is Insufficient:

Build Host Details: Specify the operating system, CPU architecture, and compiler used for testing on your local setup. (e.g., "Linux, x86_64, GCC 12.2")
Target Details: Be more specific than "sim." Which simulator? Provide the architecture and board configuration. (e.g., "qemu-rv32, sim:nsh")
Testing Logs:  You need to provide actual testing logs from before and after the change. These logs should demonstrate the issue you're fixing or the functionality of the new command.

In short: You need to fill out the PR template with much more specific information for it to be considered complete.


Suggestion: Add in an option to separate questions by new bullet points

I'm sorry if this is not the place for a suggestion. I wasn't sure where to put it. I really appreciate this plug-in! Research shows that esting is the most effective way to study.
My suggestion is to give more options for how to distinguish between questions. My review notes are not normally separated by a "space" since I just use a bullet list of questions. It would be beneficial if questions could be separated by new " head bullet points"
ie.

Question one

answer
answer

Question two
- answer
- answer

Thank you for your work on this! I wouldn't know where to begin to create a plug in and this is a tremendous one!

Yeah, I'll add the option for users to choose what they like to use for separating questions in the next release. Thanks for raising the suggestion!


Allowing copy folders inside recipes but restricting docco documentat…

…ion to JS for the first level
Fixes #14
@digitarald do you mind to take a look?

@darkwing do we still need this with #40 being fixed?


Test Lurch for T-17278

Note: FOR INTERNAL USE ONLY. For support questions, please use the EDA Chatter group in The Power of Us Hub.
For feature requests, please use the Ideas tab in The Power of Us Hub.

Do you want to request a feature or report a bug?

What is the current behavior?

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Acceptance Criteria

Given: I am on a certain page
When: I click a button
Then: An action should occur

Keyboard Acceptance Criteria

Given: I am navigating the site using only my keyboard
When: I tab to the button
Then: I should see the button highlighted on focus
And When: I press enter on a highlighted button
Then: An action should occur

Screenreader Acceptance Criteria

Given: I am using a screenreader to navigate the site
When: I tab to the button
Then: I should hear the label of the button
And When: I press enter
Then: I should hear that an action has occurred

**lurch: add

Tracking W-035383

@kdy618 Yay, it works! :) Can you close this issue & the corresponding work item, since it was just a test?


CVEs on goss

Describe the bug
1 High, 2 Medium CVEs on goss

How To Reproduce
Use trivy to detect CVE
Expected Behavior
Clear CVE report
Actual Behavior
Reported CVEe
Environment:
goss  v0.4.8
alpine 3.20.3

@dklimpel @aelsabbahy we ready to help add CVE detection on CI.
As I remember @dklimpel already started that, please let me know if I can help with that :)

hi @dklimpel @aelsabbahy did you have some time to look at this?

Please let me know if the newest version resolves the issue for you.

Please let me know if the newest version resolves the issue for you.

@aelsabbahy unfortunately we replaced goss to another solution, because we have strict SLA on fixing critical CVEs.
Anyway thank you for fixing.

Curious which solution you ended up going with.
I'll let you know once we have nightly CVE checks in case that changes anything in the future.
Many thanks for filing these and bringing this aspect to my attention as an enhancement to the release process.

Many thanks for filing these and bringing this aspect to my attention as an enhancement to the release process.

Thank you too, I super glad that we have such good communication :)

Curious which solution you ended up going with.

Instead of using generic tools for healthchecking, we found optimised for our use case - health check for syslog server by syslog-ng


Clang msan support

Clang ASAN/TSAN support was introduced under https://github.com/lyft/envoy/issues/443 and https://github.com/lyft/envoy/pull/904.
MSAN isn't going to be easy, and questionably worth doing in our current CI environment. You basically need to rebuild lib[std]c++ and all external deps, see https://github.com/google/sanitizers/wiki/MemorySanitizerLibcxxHowTo. I tried it without this and I see false positives such as:
Uninitialized bytes in __interceptor_strlen at offset 18 inside [0x703000000168, 19)
==7==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fe5d4e5d5ce  (/google/src/files/151379707/depot/google3/third_party/crosstool/v18/llvm_unstable/toolchain/x86_64-grtev4-linux-gnu/lib64/libstdc++.so.6+0xc75ce)
    #1 0x44f11cb  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x44f11cb)
    #2 0x4501720  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x4501720)
    #3 0x44e7048  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x44e7048)
    #4 0x427c0a  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x427c0a)
    #5 0x427e91  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x427e91)
    #6 0x452d97d  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x452d97d)
    #7 0x7fe5d3db4cfe  (/usr/grte/v4/lib64/libc.so.6+0x38cfe)
    #8 0x639438  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x639438)

  Uninitialized value was created by a heap allocation
    #0 0x6a86e9  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x6a86e9)
    #1 0x7fe5d4e5d668  (/google/src/files/151379707/depot/google3/third_party/crosstool/v18/llvm_unstable/toolchain/x86_64-grtev4-linux-gnu/lib64/libstdc++.so.6+0xc7668)
    #2 0x427c0a  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x427c0a)
    #3 0x427e91  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x427e91)
    #4 0x452d97d  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x452d97d)
    #5 0x7fe5d3db4cfe  (/usr/grte/v4/lib64/libc.so.6+0x38cfe)
    #6 0x639438  (/usr/local/google/home/htuch/.cache/bazel/_bazel_htuch/89676793239ac96d94294e6c7a44597f/execroot/envoy/bazel-out/local-dbg/bin/test/config_test/example_configs_test+0x639438)

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/google/src/files/151379707/depot/google3/third_party/crosstool/v18/llvm_unstable/toolchain/x86_64-grtev4-linux-gnu/lib64/libstdc++.so.6+0xc75ce)

We should consider adding this when we have better CI resourcing for dynamically rebuilding all libraries (so we don't need to bloat the Docker CI image).

We should consider doing this again now that we are under CNCF and have access to more CI resources. MSAN has found a few bugs internally that would have been caught by CI before merging.

It seems like a lot has changed since this issue originated, I see some configuration for msan on CI and a few bazel configs for it, has anyone tried this recently? I'm curious about how many false positives we would find

It looks like at this point libc++ is setup correctly for this at least https://github.com/envoyproxy/envoy-build-tools/commit/f741613fc395cc489a630122eeb5e611b3cb1a5e

#21348


Epic: Compute Image with all supported versions of Postgres

Motivation
It's hard to manage compute pools for 3 Postgres versions.
(we have a compute image for each version of Postgres (currently, it's 3 for neonVM and 3 for k8s pods; eventually, we will have only neonVMs)).
We can try putting all Postgres versions into a single image, which should dramatically improve pool usage.
Things to keep in mind:

We don't want uncontrollable growth of image size (which will cause slower image download and start). We need to try to optimize it, the most trivial way is to strip binaries.
In Sep 2024 Postgres 17 will be released, will we be ok to just include it into the image?
Consider moving extensions out of the image to keep it slim.

The current situation is:
$ for v in v14 v15 v16; do docker manifest inspect neondatabase/compute-node-${v}:4566 | jq '[.layers[].size] | add'; done
256508639 # ~ 244 MiB
256655597 # ~ 244 MiB
259723983 # ~ 247 MiB

$ for v in v14 v15 v16; do docker manifest inspect neondatabase/vm-compute-node-${v}:4566 | jq '[.layers[].size] | add'; done
322214214 # ~ 307 MiB
322380089 # ~ 307 MiB
325276143 # ~ 310 MiB

DoD

All Postgres (and extensions) are packed into one image

Implementation ideas

Put all Postgreses and extensions into a single image
Teach compute_ctl (?) starts particular Postgres (using spec?)

### Tasks
- [ ] Put all Postgreses and extensions into a single image
- [ ] Teach compute_ctl (?) starts particular Postgres (using spec?)

Other related tasks and Epics

Compute Pools in Grafana: https://neonprod.grafana.net/goto/tWCT0IhSR?orgId=1

@lubennikovaav is there any doc on how to move extension from image to S3? Or may be just a PR where such thing was done?

WIP dashboard is here: https://neonprod.grafana.net/goto/DV6w28oSg?orgId=1
This week: gather feedback, improve the dashboard and move it to general space.

Added RFC: https://github.com/neondatabase/neon/pull/7289/files

Discussion from Istanbul April 2024 off-site is here.
Decisions:

Compute team builds an image with the 3 supported versions
Compute owns the discussion with CP how to implement this
We also need to provide images with older versions (once we move to 17, 14 is no longer supported)
We move rarely used extensions out of the compute image (list tbd)

Removing the infra team from this since there doesn't seem to be anything for us to do (yet?). Feel free to re-add if I'm mistaken or if any help is needed.


20180222 review

NOT READY
AMLNG-575
Description
Copy and paste Description from orginal issue
Acceptance Criteria
Copy and paste Acceptance Criteria from orginal issue
How to test code
Add how to test locally
Please Review
@aml-development/ozp-backend-team
Checklist

[ ] Read CONTRIBUTING.md
[ ] Write code to complete task
[ ] Python Code is PEP8 Compliant
[ ] Add unit tests for new code
[ ] All tests must pass before merging the pull request
[ ] At least 2 people reviewed code

Request
POST /api/token-auth/ HTTP/1.1
Host: <IP_ADDRESS>:8001
Content-Type: application/json

{"username":"bigbrother","password":"password"}

Response
{"token":"eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VybmFtZSI6ImJpZ2Jyb3RoZXIiLCJ1c2VyX2lkIjoxLCJleHAiOjE1MTk3NDkxMzcsImVtYWlsIjoiYmlnYnJvdGhlckBvY2VhbmlhLmdvdiJ9.bA4-sL9PKXNH7SGC7jnKOAsmVSjs3XakGcqzrbr8olA"}

Testing Token
GET /api/category/ HTTP/1.1
Host: <IP_ADDRESS>:8001
Authorization: JWT eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VybmFtZSI6ImJpZ2Jyb3RoZXIiLCJ1c2VyX2lkIjoxLCJleHAiOjE1MTk3NDkxMzcsImVtYWlsIjoiYmlnYnJvdGhlckBvY2VhbmlhLmdvdiJ9.bA4-sL9PKXNH7SGC7jnKOAsmVSjs3XakGcqzrbr8olA
Content-Type: application/json

:+1: works as expected


Do not show bulk actions checkbox in page type usage view

Fixes #10003.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Thanks @laymonage! Cherry-picked in 44dd13289a8a90d44a3796126818370f43d83a56 (main) / f4c42ee74937b64b0f129dd39edb239d8af96e9e (4.2.x) / d8d079292db16fab4412deca90ca79849866ef4f (4.1.x).


Fix the path to match the key in depsByPath Map

In the depsByPath Map,  the key uses the path defined in parser.parseFile().
this.moduleResolver.resolve(i.from.path, i.symOrPath) returns an absolute path, which causes NOT FOUND error after calling this.depsByPath.get(). The issue will be resolved by replacing it with i.from.path.
E.g.
depsByPath:  Map {
'src/js/second.js' => Dependency {
type: 'es6 module',
path: 'src/js/second.js',
closureSymbols: [],
imports: [],
language: 'es6' }}

This will just disable custom resolution, which isn't right (notice after this change that the module resolve ris unused). It seems like the correct thing is to have the keys of the map be absolute paths.

Alternatively use path.join rather than path.resolve in the PathModuleResolver.

Sorry for spamming the commits, I barely use the github UI directly to make commits, seems it sent out 3 commits instead of 1.


kubeapi with kubevirt

This is intended as a potential replacement for #3730
As described in this comment, kubevirt implemented most of their work correctly, but the final clientset was built in a single module with lots of other things, which led to a messy go.mod that makes it very difficult to include in something else.
We leverage their kubevirt.io/api, but copy the minimum needed to fill in the gaps from kubevirt.io/client-go.
This should be compared carefully to #3730, and see if anything is missing.
@naiming-zededa do you mind running your tests again?

Rebased, fixed all of the conflicts, checked that we still get sane k8s.io versions, and checked that still can build with -tags kubevirt. Looking good. Time for tests

Weird yetus complaint here
golangcilint: import 'github.com/lf-edge/eve/pkg/pillar/base' is not allowed from list 'Main' (depguard)

Why would it not be allowed?

Weird yetus complaint here
golangcilint: import 'github.com/lf-edge/eve/pkg/pillar/base' is not allowed from list 'Main' (depguard)

Why would it not be allowed?

Some discussion in https://github.com/golangci/golangci-lint/issues/3877 says it can happen if there is no config file for golangcilint. But why now?

But why now?

No idea. I think we can ignore it for now.

The "PR build" job failure is the same docker hub rate limit issue. It is trying to build the eve-build-runner image and is running into the issue pulling golang.

@deitch i tried to port the 'kubevirt.go' and some change of 'kubeapi.go' into our poc branch, and got those errors:
#31 29.48 # github.com/lf-edge/eve/pkg/pillar/kubeapi
#31 29.48 kubeapi/kubeapi.go:104:78: undefined: kubevirtapi.GroupName
#31 29.48 kubeapi/kubeapi.go:104:98: cannot use kubevirtapi.GroupVersion (variable of type "k8s.io/apimachinery/pkg/runtime/schema".GroupVersion) as string value in struct literal
#31 29.48 kubeapi/kubeapi.go:109:46: undefined: shallowCopy
#31 29.48 kubeapi/kubeapi.go:119:9: cannot use &kubevirtClient{…} (value of type *kubevirtClient) as *KubevirtClientset value in return statement: *kubevirtClient does not implement *KubevirtClientset (type *KubevirtClientset is pointer to interface, not interface)
#31 29.48 kubeapi/kubeapi.go:119:45: unknown field clientSet in struct literal of type kubevirtClient
#31 29.48 kubeapi/kubeapi.go:325:28: clientset.VirtualMachineInstance undefined (type *KubevirtClientset is pointer to interface, not interface)
#31 29.48 kubeapi/kubeapi.go:332:23: clientset.VirtualMachineInstance undefined (type *KubevirtClientset is pointer to interface, not interface)
#31 35.34 make: *** [Makefile:99: vet] Error 1

@naiming-zededa I did manage to vet and build it locally, so I wonder why yours fails. Could be I missed something.
Can you write here exactly how you do that, including pointers to branches and such? I'll try to replicate it locally.

@deitch in my poc branch, first i added the whole file from your kubevirt.go in the kubeapi directory, then this this patch:
patch-diff.txt

then I did 'go mod tidy' and 'go mod vendor' in the pkg/pillar directory. I didn't remove the kubevirt client api used in the other files inside poc branch, not sure if that matters.

That patch doesn't look right to me at first glance, but I haven't dug deeper yet.
You can diff my branch off of master on eve.
Can you link to your poc branch? How is it different than master?

then I did 'go mod tidy' and 'go mod vendor' in the pkg/pillar directory. I didn't remove the kubevirt client api used in the other files inside poc branch, not sure if that matters.

I am quite sure it does.
I built my branch based on the code changes from Milan's branch, removed the references to kubevirt's client-go, and then built up the modules correctly.

@naiming-zededa I got it working, mostly. The reason it failed is that you still had references to kubevirt.io/client-go (with all of its messy dependencies) in 2 other places:

hypervisor/kubevirt.go
cmd/zedkube/vnc.go

Once I got rid of those, the issues went away. There is a branch here on my clone of eve, and I also opened a PR against your poc-dec3 branch in your repo. Feel free to merge that, or use it just a source and close it.

Rebased to resolve conflict. And checked, builds fine both with and without -tags kubevirt.
And everything is pretty much ok except for that odd yetus error. @eriknordmark

@eriknordmark @deitch we'll figure out to submit the rest of the changes for single node into master

Sure thing @naiming-zededa. You might have an easier time just applying the remaining changes to a new branch based on master post-this-PR. If you just apply yours, and share the new branch, I'm happy to go in and match it to this one without the kubevirt.io/client-go dependency

@deitch Thank you for taking care of the k8s dependency issues!

@milan-zededa my pleasure. I just took your work and adapted it; good teamwork. When you are ready with the next one, base it on this and hit me up if you need help.


Transfer Repo?

@avicennax
Do you want me to / can I transfer this repo to your personal Github account? We've moved away from having personal Github repos on the lab account, and as far as I can tell this repo isn't super relevant to the lab, but might be some useful code you want to keep.

Howdy @TomDonoghue; feel free to blow this away.


[FLINK-2445] Add tests for HadoopOutputFormats

Hi @ajaybhat, thanks for opening pull request.
I read your pull request quickly and have a comment.
Currently, Flink has a lot of tests that create a temporary file and write temporary result to the file. It makes time to test slow. So Flink community decided to change these tests to avoid temporary file.
Could you re-implement  DummyRecordWriter to make tests fast?
By the way, the author email of your commit (be59077) seems different email address of your github account. Is this intentional?

Hi @chiwanpark

Could you re-implement DummyRecordWriter to make tests fast?

Its because I saw many tests creating temporary files that I used the same approach.

By the way, the author email of your commit (be59077) seems different email address of your github account. Is this intentional?

Its a mistake, I'll fix it

The build has failed, but the failure seems unrelated to this PR.

Thanks for the PR. This is a good start. The tests needs a few more checks though.
The main purpose of the test is to ensure that the correct methods are called on the Hadoop classes (OutputFormat, OutputCommitter, RecordWriter, ...). I added a few comment for checks to add in line.
Thanks, Fabian

@ajaybhat Do you have any updates on this PR?

As there has not been any activity since the beginning of the year, I thought I'd address the comment in this PR. I wasnt able to push to the current branch, so I made a branch in my repo.
you can find it here
let me know how you would like to proceed.

@mliesenberg Thanks for picking this up. Let's close this PR. Would be great if you could open a new PR based on the branch you linked.

sure, though I cant close it.
Found some things that can still be improved, will add that and open a PR tonight.

Closed this PR as part of PR #1628.
@ajaybhat, your commit was added as 8e4a001b84c36827eb6168adac2724f76e30cc2c
Thanks for the contribution.


Compatible with albacore

It would be interesting to give compatibility with Albacore basecaller output

Has this happened?

Please look at the following branch:
https://github.com/mitenjain/signalAlign


Google C++ style

Is it alright if we standardize on Google's C++ style? https://google.github.io/styleguide/cppguide.html
I find the lack of firm conventions in C++ maddening.

Could you get the cpplint working?  The Stan (math?) submodule should have the Makefile cpplint rules used in Stan but I couldn't get it going in a sane way last time I tried... without cpplint I have not had good luck trying to follow Google's guide...

Yeah, I'll do this next after I get the POC cleaned up. It's working right now but it needs to be cleaned up and hooked up to travis. I'll turn on cpplint there too.


[SPARK-15396] [SQL] [DOC] It can't connect hive metastore database

What changes were proposed in this pull request?
The hive.metastore.warehouse.dir property in hive-site.xml is deprecated since Spark 2.0.0. Users might not be able to connect to the existing metastore if they do not use the new conf parameter spark.sql.warehouse.dir.
This PR is to update the document and example for explaining the latest changes in the configuration of default location of database.
Below is the screenshot of the latest generated docs:

No change is made in the R's example.

How was this patch tested?
N/A

Test build #59007 has started for PR 13225 at commit da9f09c.

Test build #59007 has finished for PR 13225 at commit da9f09c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59007/
Test PASSed.

@rxin @jameszhouyi Do you think the document changes in this PR are clear? Please let me know if anything is missing or inappropriate. Thanks!
Also CC all the Committers who changed the related codes. @yhuai @andrewor14 @cloud-fan @liancheng

LGTM - merging in master/2.0. Thanks!


Seems like unsafe code violates guarantees

I am not very experienced developer on Rust so don't be shy to correct me if I am wrong
What do I mean:
I've been using your create to implement my own graphite-metrics-exporter and in my case I've had to use interior mutability pattern (there is an async Sender inside of recorder). I've implemented this pattern with RefCell and the main problem is that RefCell have been used in multiple threads sometimes, which then become a cause of panic or other problems (remember that RefCell is not Sync). Compiler didn't notice anything for me (of course I would use Mutex if it did).
So, I understand that very safety solutions, which prevent this behavior, may hit performance much, so I want you at least notice this fact in your documentation (that user should pay attention that guarantees may be violated and compiler won't issue that)

In general, I'm confused on why you would need a RefCell.  Most exporter patterns will use a synchronous channel that only requires &self, or if you really need an asynchronous channel, you would use something like Tokio's mpsc channel, whose Sender has blocking_send which only requires &self.
This sounds like it probably comes down not being familiar with the options at hand, so I hesitate to change the documentation in a way that might have people worrying about something they don't need to really worry that much about.
Feel free to come chat with us on Discord -- https://discord.gg/9VngTFZ3hR, #metrics -- if you want some hands-on help with your exporter implementation.  We can probably give you some pointers to avoid needing RefCell. 👍🏻
I'm going to close this ticket for now as it doesn't seem like there's anything specific for us to fix/document.

Yeah, thank you for fast answer!
I've started implement this exporter, when tokio was 0.3, so there wasn't blocking_send method. You gave very good hint, I'll implement it this way, thanks!


ENH: Add an option to compute weighted (in physics called "radical") Voronoi diagram in Scipy.Spatial.Voronoi.

Is your feature request related to a problem? Please describe.
While analyzing the structure of a multi-component system, especially in amorphous materials, it's necessary to take atom type into account, that is, the line segment of each neighbor pair is divided by the Voronoi polyhedron face according to the ratio of the "weights" of the two atoms. In practice, the weight usually depends on the atom radius.
Describe the solution you'd like.
Add an option to Scipy.Spatial.Voronoi, named "weights" or something else, takes one numpy array as a variable, the length of which is the same as the first variable-points, and finally gives the result of a weighted Voronoi diagram.
The default value of the new option "weights" is an array with all elements=1, the length depends on points. The default value will give the previous Voronoi diagram such that each polyhedron face still bisects the neighbor pair segment vertically.
Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
No response

I assume that's the same thing as https://en.wikipedia.org/wiki/Power_diagram ?
From a quick search, it looks like there's an MIT-licensed Python implementation in 2D that leverages SciPy ConvexHull here: https://gist.github.com/marmakoide/45d5389252683ae09c2df49d0548a627
I see a Julia implementation, but looks like GPL license so I won't look at the source.
Are you proposing support in arbitrary (N) dimensions?
It looks like one of the seminal papers (https://doi.org/10.1137/0214006) has been cited 306 times, which perhaps isn't too bad from a general usefulness standpoint.

Not exactly the same as Power diagram. The Power diagram is based on the definition of power distance. However, in 2D case, from the perspective of Euclidean distance, consider the (Euclidean) distance of the neighbor points to the Voronoi edge, the ratio actually depends on the (Euclidean) distance between the center (of the circle).
I prefer the ratio being a prescribed constant, which is independent of the (Euclidean) distance between the center. (Actually I'm not sure whether this idea is reasonable in physical background, and it seems that nobody has discussed this issue academically.)
If this idea is too odd or unusual to be implemented, power diagram still meets the needs for research.
Nevertheless, it will be useful to support arbitrary dimensions, at least 3D, for real space systems. I propose to add such a feature.


Iterator Not Closed in fetchMintAllowanceSupply()

https://skyharbor.certik.com/report/edd5d752-a121-44c7-a833-e4cac9c0206e?findingIndex=MAS-01
Description
The function fetchMintAllowanceSupply() uses an iterator to fetch state by range but does not explicitly close the iterator after its usage. Failing to close the iterator can lead to resource leaks, which can impact the performance and stability of the chaincode, especially if the function is called frequently.
Scenario
When the fetchMintAllowanceSupply function is invoked, it creates an iterator to traverse a range of states. If this function is called multiple times without properly closing the iterator, it can lead to an accumulation of unclosed iterators, eventually exhausting system resources.
Recommendation
Ensure that the iterator is properly closed after its usage by adding a finally block to close the iterator, as shown below:
try {
for await (const kv of iterator) {
// Loop logic...
}
} catch (e) {
throw new Error(Failed to get iterator for getStateByRange with key: ${startKey}, ${iterator}, ${e});
} finally {
await iterator.close();
}
Locations
fetchMintAllowanceSupply.ts#L70-L97: L70-L97

TypeScript (and JavaScript) automatically closes an iterator when using for await...of loop, even if an error is thrown or a break statement is encountered. This is part of the specification for asynchronous iteration in ECMAScript, which TypeScript follows.
The abstract operation AsyncIteratorClose is used to close an iterator when a break, continue, throw, or return statement is encountered within the body of a for-await-of statement.
This means that when you use a for await...of loop, the iterator is automatically closed when the loop is finished, regardless of whether it finished normally or due to an error or break statement.


force route after login please?

Hello,
in router.post('/login', loginRateLimiter, checkAuthentication, async (ctx) => {     const { username, password } = ctx.request.body;     try {         await validateAdminUser(username, password)         ctx.session.isAuthenticated = true;         ctx.session.username = username         return ctx.redirect('/deployments')     }     catch(err){         return await ctx.render('auth/login', {layout : false, login: { username, password, error: err.message }})     } }) i've replaced deployments by services but everytime, it back to deployments... how i can force this please?
Thanks

Solved, need to changed two times:
./src/routes/index.js:45:        return ctx.redirect('/deployments')
./src/middlewares/auth.js:3:        return ctx.redirect('/deployments')
replace deployments by services. completly forgot this ^^


Context menu to add additional references

Description
What is this PR

[ ] Bug fix
[x] Addition of a new feature
[ ] Other

Why is this PR needed?
The main components of atlases we'd like to add as layers include additional reference images.
What does this PR do?
Adds functionality to add additional reference images to napari (if the atlas has them).
This is achieved by a custom context menu which can be opened via a right-click on the atlas table view.
In order to test this well, we now have the mpin_zfish_1um atlas as part of the downloaded test data (as it is the smallest atlas that has additional references, AFAIK).
(Some improving of testing docstrings and variable names are included in this PR)
References
Closes #6
How has this PR been tested?

A new test for the napari atlas representation part of the new functionality is added.
Emulating a right-click to open the context menu was tricky in qtbot and has therefore been kicked down the line.

Is this a breaking change?
Nope
Does this PR require an update to the documentation?
In the future, yes. No high-level documentation for this plugin exists yet.
Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[x] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

right clicking on an atlas without any additional references raises an error:

Should be fixed with 7006970 (#54)
Is it a bug in the atlas data that some atlas metadata has an empty list under the "additional_references" key and other atlas metadata doesn't have that key at all, @adamltyson ?

Is it a bug in the atlas data that some atlas metadata has an empty list under the "additional_references" key and other atlas metadata doesn't have that key at all, @adamltyson ?

Yeah. I think it's because some atlases were generated before we added the additional_references key.

Merging as tests pass on CI and locally for me.


Toncli tests success on out-of-gas

Bug Type
Functional
Reproduction steps
Code example https://gist.github.com/Trinketer22/b511a8f7c3820a3b01e15b4b634224d6
thanks to @Trinketer22
Actual result
INFO: Test [__test_gas_limit] status: [SUCCESS] Test result: [[ 4949 ]] Total gas used (including testing code): [4949]
Expected result
Test status fail
Suggested Severity
Critical
Device
(base) tvorogme in ~/projects/nft_ultimate_sale on master ● ● ● λ toncli --version
INFO: v0.0.43
Additional Context
No response

After #93 is merged, there will no longer success status on such cases. But we need to find better solution to test such cases inside testing VM


[protobuf] Update to 5.29.0

Update to 5.29.0.
Remove patch fix-arm64-msvc.patch that has been fixed upstream.
Use upstream PR 2830 to fix the issue of brpc adapting to protobuf-5.29.0.

[X] Changes comply with the maintainer guide.
[X] SHA512s are updated for each updated download.
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version.~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Usage test passed with x64-windows triplet.

Thanks for the update!


Use John Papa's Style guide

In angular world, the style guide by John Papa is used more and more. In Angular 2, it's even become part of the official documentation. I would like to suggest to adopt John Papa's style guide in m-generator-ionic.
https://github.com/johnpapa/angular-styleguide

Hi @dirkpostma. We've been discussing this for a long time. We'll definitely adopt it for version 2, however not for 1. It's historically grown. We started developing the generator before the community was fixed on any particular style and integrating it now would require a lot of time that we see better invested in version 2.
For now.
Not saying that it will never come for version 1 as well, but not soon.
Hope that is a satisfying answer!

Thanks for answering, I do understand.
I will setup my project based on John Papa's style guide, but I learn a lot of this project, so keep up the good work!

@dirkpostma, glad you find it helpful :) Stay tuned for a version with angular 2 / ionic 2 which will also be based on John Papa's guides.


Download speed on self-hosted runners is significantly slower

👋🏼
We've started working with self-hosted runners, but noticed that the download speed when downloading the cache is significantly slower than on hosted runners. Here's the breakdown of what is happening:

Self-hosted runner version: 2.296.2
Cache size: ~300MB
Average download speed

Hosted runners: 50 MBs/s
Self-hosted runners: 3.5 MBs/s

Hosted:

Self-hosted:

Workflow:
      - name: Cache yarn dependencies
        uses: actions/cache@v3
        id: cache-dependencies
        with:
          path: node_modules
          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
          restore-keys: |
            ${{ runner.os }}-yarn-

      - name: Install dependencies
        if: steps.cache-dependencies.outputs.cache-hit != 'true'
        run: |
          yarn install --frozen-lockfile

I'm pretty confident there's no limitation on our machine, and I'm not sure if this is a limitation on the runner itself, but at that speed installing dependencies takes practically the same time as pulling the cache.
Thanks in advance!

@ajmnz is your self-hosted runner hosted in public cloud or on your private network? One thing to note is that hosted runners are present in the same regional cloud network as the blob storage, that's why the download or upload speed is generally high as compared to self-hosted runners.

Hi @anuragc617, the runner is hosted in public cloud. More specifically, in a dedicated server with plenty of resources available, where the only thing running are the self-hosted runners.
I understand the region issue, but it just seems odd that there would be such a difference in download speeds, with hosted runners sometimes reaching +100 MB/s and self-hosted runners never going above 4-4.5 MB/s. To me, it just looks like there might be some throttling because of how consistent speeds are on self-hosted runners.

I'm having the same issue (10 MB/s in self-hosted, 100 MB/s in GitHub hosted runners), and I'm wondering: why isn't the cache hosted locally (in the runner) so there is no need for internet transfer? Where exactly is it hosted?

We're seeing the exact same, but just to bust some future "It's your network speed" comments:

There also doesn't seem to be a way to specify a custom endpoint. What can we do?

We moved to Self-Hosted Runners to reduce our build times with custom AMIs and bigger instances, but our efforts are being hindered by extremely slow cache download and the post-job upload step. What takes just 10-20 seconds on the GitHub hosted runner sometimes takes up to 15 minutes on our Self-Hosted runners.

Any news?

We are tracking self-hosted runner slowness in https://github.com/actions/cache/issues/720 . Please continue the discussion there. Closing this in the meanwhile.


updated robotjs to compile with nan-2.0.9

Thanks for this! I have a few comments, I'll comment on the relevant lines.

This now works with the latest Nodejs v4.0.0

Thanks! The io.js v3 test is still failing, but I think that's a separate issue (travis config). I'll look into it later today.

Hey @abhishekgarg120!
Could you change your .travis.yml to this and commit it to this PR?
sudo: false
language: node_js
env:
  - CXX=g++-4.8
node_js:
  - 0.10
  - 0.12
  - 4.0.0
  - iojs-v2
  - iojs-v3

matrix:
  allow_failures:
    - node_js: iojs-v3
    - node_js: 4.0.0

addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - libx11-dev
      - zlib1g-dev
      - libpng12-dev
      - libxtst-dev
      - g++-4.8

before_script:
  - export DISPLAY=:99.0
  - sh -e /etc/init.d/xvfb start

Or if you're busy, can you add me as a collaborator to your fork?
Thanks!

Sure, i'll do it, give me a minute.

Adding to the list: https://github.com/nodejs/node/issues/2798.


Config from_envvar doesn't support silent=True properly

Hello,
When I used Flask, I had the following lines of code that would load the config if the env var exists and fail silently if it doesn't.
app = Flask(__name__)
app.config.from_envvar("FLASK_CONFIG", silent=True)

I switched to Quart and wrote basically the same thing:
app = Quart(__name__)
app.config.from_envvar("QUART_CONFIG", silent=True)

However, this throws an error if QUART_CONFIG doesn't exist:
E       TypeError: unsupported operand type(s) for /: 'PosixPath' and 'NoneType'
<path to my venv>/lib/python3.9/site-packages/quart/config.py:197: TypeError

Reading the code for from_envvar, it is clear that the feature hasn't been ported properly from Flask: https://github.com/pallets/quart/blob/main/src/quart/config.py#L109-L113
Environment:

Python version: 3.9
Quart version: 0.17.0

Fixed by 155


fix: update package dependencies

Signed-off-by: fsl<EMAIL_ADDRESS>
What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@fengshunli Thank you for posting pull request.
Would you be able to give the reasons or the background why we need to replace package github.com/dgrijalva/jwt-go with package github.com/golang-jwt/jwt?

@fengshunli Thank you for posting pull request. Would you be able to give the reasons or the background why we need to replace package github.com/dgrijalva/jwt-go with package github.com/golang-jwt/jwt?

github.com/dgrijalva/jwt-go has the CVE-2020-26160 vulnerability, the reference link https://github.com/dgrijalva/jwt-go/pull/426 @rambohe-ch

/lgtm
/approve


Problem with symbol for staged files

I can't see the git_status symbol for staged files, and I found in source code that this snippet (in git_status method from sources/common/components.lua) is the responsible for this behavior:

May be that the output from git diff is wrong? Or maybe that this if-statement should be modified?
For example, in the image below, staged symbol should have appeared in the "highlights.lua" file entry.

This is caused by the #501 fix, which needs to be handled differently. I'll fix it.


how to only include Python files while using *

This is question I guess.  But there are .json (and other non-Python) files in that main directory and they are getting caught too.  I tried excluding JSON files specifically:
black --check --exclude '\.json$' *
But that didn't change anything. I understand that the include/exclude options only happen for recursively reformatting and that maybe because they are in the root directory they aren't thought of as recursive targets.
This basically gets me what I want but it feels like there's a better way and I'm missing something obvious:
find . -name \*\.py |xargs black --check
Operating system: MacOS Mojave
Python version: 3.6
Black version: 19.3b0
Does also happen on master: yes
To answer the last question, you have two options:

Use the online formatter at https://black.now.sh/?version=master, which will use the latest master branch.

Uh, yeah I figured it out 2 minutes later:
black --check .


[R] Default  write_dataset min_rows_per_group parameter, 1L, can lead to very bad performance (time and memory) :

Describe the enhancement requested
I'm not sure it's a request or a bug but when using write_dataset, the resulting dataset can have very small rows_per_group resulting in very bad performance for many queries : at least 20 time slower and 20 time more memory for my dataset of 10GB.
Setting the min_rows_per_group to something around 100000L fixes the problem.
Users are not all aware of min_rows_per_group parameter so setting a "good" default (if it exists) could help them very much.
I'm not qualified enough to know if there's drawbacks.
Component(s)
R

Could you provide a benchmark to reproduce this problem? It's convenient for others to find the problem.

Working on it

To reproduce this problem, you can use code below.
library(arrow)
library(dplyr)

download.file("https://static.data.gouv.fr/resources/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret/20231214-130548/stocketablissement-utf8.parquet", "stocketablissement-utf8.parquet")

# create a partitioned dataset with default min_rows_per_group
open_dataset("stocketablissement-utf8.parquet") |>
  mutate(code = str_sub(activitePrincipaleEtablissement, 1L, 2L)) |>
  write_dataset("stock_ds")

# create a partitioned dataset with min_rows_per_group at 32000L
open_dataset("stocketablissement-utf8.parquet") |>
  mutate(code = str_sub(activitePrincipaleEtablissement, 1L, 2L)) |>
  write_dataset("stock_ds_32000", min_rows_per_group = 32000L)

I check duration and memory usage for this request :
 open_dataset(input) |>
    filter(dateCreationEtablissement < "2018-02-07" & dateDebut > "2020-02-02") |>
    count() |>
    collect()

The result is :
 source                                 duration max_mem
1 stocketablissement-utf8.parquet        3.14    2.17
2 stock_ds                              15.9     6.54
3 stock_ds_32000                         3.38    2.83

I guess that's because a small RecordBatch would been written, causing a small rowgroup. Are you storing on Local fs or S3?

I store on local fs.
I thought it was related to R arrow but it's not. I've just tried the same partitioning with python and it gave the same result : very low mean row group size (around 730) :
Source file : https://static.data.gouv.fr/resources/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret/20231214-130548/stocketablissement-utf8.parquet
import pyarrow.dataset as ds
import pyarrow as pa

ds.write_dataset(ds.dataset("stocketablissement-utf8.parquet"),
                 base_dir='stock_py_32',
                 format='parquet',
                 partitioning = ds.partitioning(
                     schema=pa.schema([('typeVoieEtablissement', pa.utf8())]),
                     flavor='hive'
                 ))

> parquet_metadata("stocketablissement-utf8.parquet") |> summarise(mean = mean(row_group_num_rows), min = min(row_group_num_rows), max = max(row_group_num_rows))
# A tibble: 1 × 3
     mean   min    max
    <dbl> <dbl>  <dbl>
1 123753. 79292 124927

> parquet_metadata("stock_py") |> summarise(mean = mean(row_group_num_rows), min = min(row_group_num_rows), max = max(row_group_num_rows))
# A tibble: 1 × 3
   mean   min   max
  <dbl> <dbl> <dbl>
1  727.     1 22805

it's related to parquet-writer in underlying C++ impl, also why a "1" rowgroup size is used here?

The function I use to get row group size :

row_group_size == 1 might means not buffering data and write the file by row. It's expected to be a bit slow but I may need test it to find out where it spending its time


add self integration tests with dropped packets

Fixes #1162.
This is currently the only way to test loss recovery for IETF QUIC.
These additional tests add about 60-80s execution time to our integration tests, because at the rate that we're dropping packets, we're constantly running into RTOs, that we don't recover from. I'm not even sure if this will improve when we rewrite our loss recovery, I guess 10-20% loss rate is just too high for any transfer to make decent progress. We might want to consider reducing the loss rate significantly (both for these new tests and the gQUIC drop tests).

Codecov Report

Merging #1167 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   91.06%   91.07%   +<.01%
==========================================
  Files         114      114
  Lines        7699     7702       +3
==========================================
+ Hits         7011     7014       +3
  Misses        461      461
  Partials      227      227

Impacted Files
Coverage Δ

internal/ackhandler/packet.go
100% <ø> (ø)
:arrow_up:

packet_packer.go
90.48% <100%> (+0.08%)
:arrow_up:

session.go
80.14% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1248f0f...4538bbb. Read the comment docs.

The test is flaky because of this issue: https://mailarchive.ietf.org/arch/search/?email_list=quic&gbt=1&index=ToJjnanOcgDqY5vk8QHWtfLHFFw

@lucas-clemente: This is ready for review now that #1358 was merged.


Use Buffer.from instead of new Buffer

new Buffer has been deprecated since NodeJS version 6, Buffer.from should be used instead.

Yet another I had planned, you're ahead of me 🤣


Editable installs not recognized by PyCharm

They show up in pip list.

It's easy-install.pth!
Contains
c:\python\general\repos\generalimport
c:\python\general\repos\generallibrary

Might want to comment on

https://youtrack.jetbrains.com/issue/PY-21603
https://youtrack.jetbrains.com/issue/PY-23156

It's easy-install.pth!
Contains
c:\python\general\repos\generalimport
c:\python\general\repos\generallibrary

Might want to comment on

https://youtrack.jetbrains.com/issue/PY-21603
https://youtrack.jetbrains.com/issue/PY-23156

Why was it only import and lib that PyCharm complained about?

Packager().localrepo.pip_install_editable() actually removes an existing easy-install.pth file

Created https://github.com/ManderaGeneral/generalfile/issues/16


[Resource] Add 'What Is Open Source Software and How Does It Work?' to Documentation

Category

[x] Resource Addition
[ ] Documentation
[ ] Codebase
[ ] User Interface
[ ] Feature Addition

Description
Category: Introduction to Open Source
Name: What Is Open Source Software and How Does It Work?
Publisher: Black Duck
Link: https://www.blackduck.com/glossary/what-is-open-source-software.html

Hello, I would like to contribute to your project. :)
Could you describe more detailed what needs to be done for this issue?

Also, I noticed that some parts of your website are not displayed correctly in dark mode, e.g. the cards on the homepage are not highlighted when hovered, like they do in light mode. Plus, the slider navigation on the page "Indrotuction to Open Source" does not look alright, I added a picture for more details. I would be happy to help you on this :)

Sure, @Elaa257!
Firstly, you have to insert the specified resource under the given category in README.md for this issue.
Secondly, the hover animation on the cards on the homepage are kept that way as we couldn't find a suitable color to put in there, like we do in light mode.
Thirdly, you're right about the slider navigation and you can surely help us with that.
Lastly, I'm assigning this issue to you!
Note: For this issue, please add the specified resource in README.md only. Then, for each modification like the slider navigation, just open a separate issue and I'll assign them to you.

@Sriparno08 Thank you for your fast reply! I will start working on this :)


editor: partial legacy port

Moves templates from legacy to Jinja2.

Moves web interface to Flask views.

Creates editor bundles.

Several small changes and bugfixes.

Signed-off-by: Javier Martin Montull<EMAIL_ADDRESS>

Updated.

Changed templates to use {{ url_for('static'

@jmartinm is it 2.0 ready?

Yeah, all the functionality seems to work so should be good to go in 2.0

@jmartinm please fix:

[ ] the failing tests
[ ] copyright years

Thanks

Done

@jmartinm it seems like you were trying to trick the kwalitee. Can you please re-push so kwalitee hook is activated?

:+1: Did I discover a workaround for kwalitee without me knowing? I will try to reproduce my steps and note it down for the future ;)
PS. I will repush

Moved to https://github.com/inveniosoftware/invenio/pull/2722

Why did you close this PR? Please don't do it next time!

Yep, not intended, but something was wrong here.
Kwalitee was not working for some reason and I could not push -f because everything was up-to-date.
Then I tried to remove the branch from my repo and push again but that was not being detected by this PR...

yes, because you have added WIP to title pushed and then removed it.

I see, that explains why the kwalitee did not run on it, I did not realise.
On the other hand I am not sure how could I have done to repush the branch and make kwalitee run on it if I did not have any more modifications to make. Any suggestion for the next time?

example:
git commit --amend --date="`date`"

example:

Thanks


w_scan: 20161022 -> 20170107

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan -h got 0 exit code
ran /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan --help got 0 exit code
ran /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan -V and found version 20170107
ran /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan -h and found version 20170107
ran /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan --help and found version 20170107
found 20170107 in filename of file in /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107

cc @nico202 for review

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘w_scan-20170107’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/video/w_scan/default.nix:13 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
make[1]: Leaving directory '/tmp/nix-build-w_scan-20170107.drv-0/w_scan-20170107'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107
shrinking /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin/w_scan
gzipping man pages under /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107/bin
patching script interpreter paths in /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107
checking for references to /tmp/nix-build-w_scan-20170107.drv-0 in /nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107...
/nix/store/w28jzw0lnbqy9sdpm78lf4n282x05f74-w_scan-20170107

Success on aarch64-linux (full log)
Partial log (click to expand)
make[1]: Leaving directory '/build/w_scan-20170107'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107
shrinking /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107/bin/w_scan
gzipping man pages under /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107/bin
patching script interpreter paths in /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107
checking for references to /build in /nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107...
/nix/store/adn7yjv9sihl5grr6p751lk8k1brwzk5-w_scan-20170107


Use generated IBrowser interface

Closes #1231

Firefox seems to be flaky, locally it's all green (Windows).


Onclick event handler is not executed when TestCafe clicks on the div

Are you requesting a feature or reporting a bug?
bug (converted from discussion)
What is the current behavior?
An error Click occured outside the div!!! is raised during test execution (see the test)
What is the expected behavior?
Test should be passed
Provide the test code and the tested page URL (if applicable)
Test code
import { Selector } from 'testcafe';

fixture `Sample`
.page `https://rawgit.com/p-bakker/cb1113e61bf721551df08917cada1775/raw/3971d3ce01f5822b0675cebcaffb9b2822285335/test.html`;

test('div', async t => {
	const div = Selector('[data-sv-element-name="test"]')

	await t
	    .click(div)
            .expect(div.find('span').textContent).contains('it worked')
            .wait(2000); // just to see the page state
	}
)

Specify your

testcafe version: 0.12.0-alpha5

@AndreyBelym please take it

Okay


Monocle Exercises

Related to https://github.com/julien-truffaut/Monocle/issues/380

https://github.com/scala-exercises/exercises-monocle is ready for PR


Last updated filter field does not work for tasks/projects/jobs

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

Related #https://github.com/ukrbublik/react-awesome-query-builder/issues/1033
Expected Behavior
No response
Possible Solution
No response
Context
No response
Environment
release v2.14.3

@bsekachev also noticed that filtering in tasks doesn't work as expected. When I filter by Label the only thing that happens is that the Label disappears, but the image is still shown

@cile98
That is expected behavior.
This is annotations filters, not frames filter.

@cile98
That is expected behavior. They are annotations filters, not frames filters.

I see. Is there a way to filter frames?

@cile98
Perhaps you want to use filtered frames navigation to visit only frames with objects, corresponding to specific filters
Right click navigation button

@bsekachev that's great thanks! Couldn't find this in the docs actually https://docs.cvat.ai/docs/manual/advanced/filter/

@mdacoca
Let's add a piece of documentation

The issue closed by #8055


fix file upload in collections

Coverage remained the same at 99.751% when pulling 2211e798306fa03e66ec281964df795e7061d54d on BlazingSun:master into aaca0758a4abec1144d7b466375e5569226f61bc on craue:master.

It would be nice to have a test proving that there's an issue at all, as well as proving that this change fixes it, also to avoid future regressions.

Could you set up such a failing scenario, e.g. by forking the demo bundle and modifying the photo upload flow?

@craue Yes, i will see what i can do.

Hi, I just met this issue.
Thank you for your solution, I've just override the method. :)

@jwaschkau, any progress?

This should be merged.

A test is still needed.

What exactly is the issue here? Could you explain?

I can't fix something that's not proven to be broken.

Hi @craue,
i won't be able to provide a testcase, because i am not developing PHP anymore.
In some cases the file upload was not working. I think currentStepData was filled with default values and array_merge just appends uploads as a list and does not overwrite existing values.

@craue I've created repo for this issue: https://github.com/syeikhanugrah/CraueFormFlowBundle276, and try to replace with this: https://gist.github.com/syeikhanugrah/906406e47ec3d763d1fd7d270919e77b.
I don't know why this happened.

@syeikhanugrah  's  solution is correct.
Is it possible to correct this problem?

Unfortunately, the repo @syeikhanugrah mentions is unavailable. We got no test or code exposing the problem and I'm still unable to see the issue. Please enlighten me, @blump.


Ideas concerning building levels and rooms

Instead of static building levels and rooms in the JS, rooms and levels should be dynamic objects stored in the database. There could be an online editor (like the c3nav online editor) to create and edit levels and rooms directly on the map.
If there are no building levels or only one level (i.e. on a campground), "drop point 123 in room xy on level 1" should simply be "drop point 123 in room xy". Accordingly, if a drop point is in a level but not in a room or outside of levels and rooms alltogether.
Rooms could be on levels but do not need to be. Drop points could be on levels or in rooms but do not need to be (not in rooms for hallways etc., not on levels for staircases etc.).
The JS code for automated assignment of drop points to levels and rooms during creation would either need to be generated dynamically or compiled after every edit. Or assignment of drop points to rooms or levels could happen server-side after creation.

Oh, I just saw that we already have this... m)


Option to configure HTTP proxy settings for pulling images behind corporate proxy

Is your feature request related to a problem? Please describe.
When k3s is run behind a corporate proxy, the installer automatically configures the HTTP proxy environment in the k3s.service.env file (one may also explicitly configure the proxy in that file). Doing so allows containerd to pull the system images hosted on Docker Hub over the proxy.
The problem with that approach is that the proxyfied environment is not only applied to the containerd child process but inherited by all internal k3s services such as kube-apiserver, kubelet, etc...
Even if the no_proxy option is carefully crafted to exclude Kubernetes (sub-)domains such as .svc, cluster.local, this can lead to weird issues such as kube-apiserver using the proxy when establishing internal connections.
Describe the solution you'd like
The only k3s component that a user would typically want to be configured to use the corporate proxy is  containerd. There should be an option to either explicitly provide the HTTP proxy configuration for containerd (--containerd-http-proxy) or an option to specify arbitrary environment variables that are applied to the containerd process environment (--containerd-env)
Edit: The second process in addition to containerd that may need HTTP proxy settings is the HelmChart controller.
Describe alternatives you've considered
Using an external container engine/runtime
Additional context

I believe this is resolved by https://github.com/k3s-io/k3s/pull/3553

I can confirm this is resolved by the mentioned PR. Closed a related issue that also applies here: https://github.com/k3s-io/k3s/issues/3552#issuecomment-909596720

Hello, sorry to resurrect this old thread but...

Edit: The second process in addition to containerd that may need HTTP proxy settings is the HelmChart controller.

Have you found a solution for this? Hit the same issue with pulling charts via HelmChart controller.


feat: adding skeleton card example

Related issue: #376

It's about documentation so will mark the commit as docs:


Handling redirects for SegmentURI

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.11 installed via npm for ReactJS
Please ask your question
How are Redirects handled by ShakaPlayer ?
Thank for your time , I'm Shaka-Packager creates a mpd file with segmentTemplate and my storage backend needs me access files via fileId eg. https://www.mystorage.com/file/[fileId]
I plan to write a express server to get the file name and path from request params , query the storage for file id then redirect to the storage file url
HTTP GET
https://express.hostedbyme.com/videoname/segmentname
Shaka Player --> Express Server
Response
HTTP REDIRECT
https://www.myuni.com/file/someid
Thus how can I add Auth Header to the new URL ?
Any opinions much appreciated

Redirects are handled by the browser; we request a URL, and if the server returns a redirect, the browser will make another request to the new URL.  You add the auth header to the original request and the browser should send it to the redirected URL too.


Redirect validation reject self redirect

I've found one case of this in the Publishing API (content_item_id: 645143), and this does cause a redirect loop on the live site.
I'll put up another Pull Request to remove the offending content_item.

Looks cool to me 👍
As there are no tests (I see there's none for that class at all) have you been able to test it ok?

As there are no tests (I see there's none for that class at all) have you been able to test it ok?

I confirmed that it worked as intended for content item 645143.


[Feature] Add Reels Stats

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
The current package doesn't allow passthrough metrics neither it has reels stats making it difficult to measure KPIs on reels (they are no longer considered as videos by meta)
Describe alternatives you've considered
No response
Are you interested in contributing this feature?

[x] Yes.
[ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?
No response

Hi @IbraFal thanks so much for opening this feature request and already getting started on a PR to contribute! I believe this is a valuable addition to the package, especially with Meta changing how reels are recorded in the underlying data.
Looking at your PR, it seems you are on the right track to include the relevant fields to the staging model. In addition to this, you will likely want to incorporate the fields in the downstream instagram_business__posts model. Would you be interested in also opening a PR to incorporate these models downstream?
Additionally, do you feel there is any need to include the reel stats in the aggregated Social Media Reporting package? If so, we will want to figure out the further downstream impacts. If not, we should be able to take the approach of incorporating the fields in the platform specific models. In the meantime, I will investigate if adding these fields will have any other downstream implications.
Thanks again for opening this feature and starting on the PR! 🎉

Hi @fivetran-joemarkiewicz
I opened the PR on the downstream project.
Thanks

Hi @IbraFal I just wanted to post back here that I have reviewed your two PRs and they generally look great! There are a few minor edits I want to make (just to ensure the changes work for all customers). Do you have any issues if I make some minor changes to your branch before merging?
Additionally, I noticed that for my data I am seeing the reel_comment field as reel_comments which is causing an error on my side. I am checking with our product team to see if I just have an older connector, or if the field is in fact reel_comments. Would you be able to confirm you see this field as reel_comment?

Hello @fivetran-joemarkiewicz , no worries you can go ahead and make the changes.
As per your question I have  reel_comments  on my end.

Thanks again for taking the time to review the PR.

Sounds great, thanks for confirming and will update on my end to reflect the data being synced.

Thanks again for all your hard work on integrating these updates into the package @IbraFal!
As of the latest release, these are now included. You can expect these releases to be live at the top of the hour on the dbt hub! Thanks again for your contribution 😄


How do you calculate the ideal min_retry_concurrency for your service??

Title: How to know what is the min_retry_concurrency we can safely set
Description:
I was trying to experiment with different min_retry_concurrency with same retry budget(say 2%) to observe the success rate of both downstream and upstream service but failing to come up with a number where I will not reject transient retry and also protect my upstream from any retry storm in production. from your experience, how did you guys figure out your ideal min_retry_concurrency where you'll not cause unnecessary failure and still safeguard your upstream service? because if you set it too low then at the time you're checking your retry budget, your active requests might go down and you run the risk of rejecting a transient failure request. if you set it too high then your retry budget might not kick in at all. How do you find a balance here?

cc @snowp @tonya11en - any advice here ?

hi @snowp @tonya11en @phlax , any input on this would be appreciated! 🙏

hello, @snowp @tonya11en @phlax sorry to bug you again. I'm having difficulty finding a formula here that I can apply across services in a mesh. my objective is, in a normal situation I don't want to reject retries but my retry budget should be such that it'll still safeguard me from a retry storm. From your expertise, how do you think one should calculate min_retry_concurrency and budget_percent for a service-to-service retry link which achieves the above objective?

also, I was reading finagle implementation of retry budget: https://finagle.github.io/blog/2016/02/08/retry-budgets/ -> which uses retry per sec metrics, which is much easier to comprehend and understand than active requests which are unpredictable. with retry per sec, I can easily calculate it for my service and come up with a recommended number. any reason why we didn't choose this implementation?