Fix Conscrypt NPE workaround

After turning on HTTPS with MockWebServer 4.9.2 we started seeing the transient ssl == null failure described in #5587 on older emulators.
#5590 attempted to fix the problem, but I don't think the catch it introduced will ever be hit because the problematic NPE is wrapped in an InvocationTargetException:
11-05 11:53:36.557  5607 23163 E AndroidRuntime: FATAL EXCEPTION: MockWebServer
11-05 11:53:36.557  5607 23163 E AndroidRuntime: Process: com.xxx.xxx.xxx, PID: 5607
11-05 11:53:36.557  5607 23163 E AndroidRuntime: java.lang.AssertionError: java.lang.reflect.InvocationTargetException
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at okhttp3.internal.platform.android.AndroidSocketAdapter.a(SourceFile:86)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at okhttp3.internal.platform.AndroidPlatform.b(SourceFile:86)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at okhttp3.mockwebserver.MockWebServer$SocketHandler.handle(MockWebServer.kt:516)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at okhttp3.mockwebserver.MockWebServer$serveConnection$$inlined$execute$1.run(Util.kt:580)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:764)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: Caused by: java.lang.reflect.InvocationTargetException
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at okhttp3.internal.platform.android.AndroidSocketAdapter.a(SourceFile:81)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	... 6 more
11-05 11:53:36.557  5607 23163 E AndroidRuntime: Caused by: java.lang.NullPointerException: ssl == null
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at com.android.org.conscrypt.NativeCrypto.getApplicationProtocol(Native Method)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at com.android.org.conscrypt.NativeSsl.getApplicationProtocol(NativeSsl.java:568)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at com.android.org.conscrypt.ConscryptFileDescriptorSocket.getApplicationProtocol(ConscryptFileDescriptorSocket.java:1085)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	at com.android.org.conscrypt.OpenSSLSocketImpl.getAlpnSelectedProtocol(OpenSSLSocketImpl.java:134)
11-05 11:53:36.557  5607 23163 E AndroidRuntime: 	... 8 more

@PhilGlass ughhhh.... and thanks. The folly of trying to fix an exception you haven't been able to reproduce.
Have you completed https://github.com/square/okhttp/blob/master/CONTRIBUTING.md

Would a fix on 4.9.4 be required (our live release branch)? How urgent is this for you?

I've filled in the CLA.
For our use case it's not super urgent, because we can work around it by forcing HTTP 1.1 (with protocolNegotiationEnabled = false) which bypasses that code path.

Thanks!


Stuck on Test 22

I ran the build.sh script while installing the library on my laptop(CentOS Linux release 7.5.1804 (Core)), but it gets stuck on Test #22 due to some reason.
Test project /root/cpp-netlib/build
Start  1: uri_parse_test
1/26 Test  #1: uri_parse_test ......................................   Passed    0.01 sec
Start  2: uri_parse_scheme_test
2/26 Test  #2: uri_parse_scheme_test ...............................   Passed    0.00 sec
Start  3: uri_parse_path_test
3/26 Test  #3: uri_parse_path_test .................................   Passed    0.00 sec
Start  4: uri_test
4/26 Test  #4: uri_test ............................................   Passed    0.01 sec
Start  5: uri_encoding_test
5/26 Test  #5: uri_encoding_test ...................................   Passed    0.00 sec
Start  6: uri_normalization_test
6/26 Test  #6: uri_normalization_test ..............................   Passed    0.01 sec
Start  7: uri_comparison_test
7/26 Test  #7: uri_comparison_test .................................   Passed    0.00 sec
Start  8: uri_reference_test
8/26 Test  #8: uri_reference_test ..................................   Passed    0.00 sec
Start  9: uri_resolve_test
9/26 Test  #9: uri_resolve_test ....................................   Passed    0.01 sec
Start 10: uri_builder_test
10/26 Test #10: uri_builder_test ....................................   Passed    0.01 sec
Start 11: uri_stream_test
11/26 Test #11: uri_stream_test .....................................   Passed    0.00 sec
Start 12: optional_test
12/26 Test #12: optional_test .......................................   Passed    0.00 sec
Start 13: cpp-netlib-utils_thread_pool
13/26 Test #13: cpp-netlib-utils_thread_pool ........................   Passed    0.48 sec
Start 14: cpp-netlib-http-response_incremental_parser_test
14/26 Test #14: cpp-netlib-http-response_incremental_parser_test ....   Passed    0.00 sec
Start 15: cpp-netlib-http-request_incremental_parser_test
15/26 Test #15: cpp-netlib-http-request_incremental_parser_test .....   Passed    0.00 sec
Start 16: cpp-netlib-http-request_linearize_test
16/26 Test #16: cpp-netlib-http-request_linearize_test ..............   Passed    0.00 sec
Start 17: cpp-netlib-http-client_constructor_test
17/26 Test #17: cpp-netlib-http-client_constructor_test .............   Passed    0.01 sec
Start 18: cpp-netlib-http-client_get_test
18/26 Test #18: cpp-netlib-http-client_get_test .....................   Passed    2.94 sec
Start 19: cpp-netlib-http-client_get_different_port_test
19/26 Test #19: cpp-netlib-http-client_get_different_port_test ......   Passed    2.91 sec
Start 20: cpp-netlib-http-client_get_ready_test
20/26 Test #20: cpp-netlib-http-client_get_ready_test ...............   Passed    1.56 sec
Start 21: cpp-netlib-http-client_get_streaming_test
21/26 Test #21: cpp-netlib-http-client_get_streaming_test ...........   Passed    0.01 sec
Start 22: cpp-netlib-http-server_constructor_test
^Cmake: *** [test] Interrupt
As you can see, I had to manually interrupt the process. Why is this happening? Are these tests necessary to be passed before I start using the library?

Can you say which version of the library you're using?

Are these tests necessary to be passed before I start using the library?

No, but running them is a good idea to ensure that what we're expecting to work just fine works. 😄

I have this same issue @deanberris
Most recent commit https://github.com/cpp-netlib/cpp-netlib/commit/0a4d2a6d2c94e7655cc3df09153f1c2d3cbf476a from 0.13-release branch.
Linux 4.15.0-45-generic 16.04.1-Ubuntu
Boost 1.69.0
libssl-dev1.0.2g
It is test 17/19 there,

root@a8bca1811f98:/app# make test
Running tests...
/usr/local/bin/ctest --force-new-ctest-process
Test project /app
Start  1: cpp-netlib-message_test
1/19 Test  #1: cpp-netlib-message_test .............................   Passed    0.00 sec
Start  2: cpp-netlib-message_transform_test
2/19 Test  #2: cpp-netlib-message_transform_test ...................   Passed    0.00 sec
Start  3: cpp-netlib-utils_thread_pool
3/19 Test  #3: cpp-netlib-utils_thread_pool ........................   Passed    0.33 sec
Start  4: cpp-netlib-uri_test
4/19 Test  #4: cpp-netlib-uri_test .................................   Passed    0.02 sec
Start  5: cpp-netlib-uri_builder_test
5/19 Test  #5: cpp-netlib-uri_builder_test .........................   Passed    0.01 sec
Start  6: cpp-netlib-uri_builder_stream_test
6/19 Test  #6: cpp-netlib-uri_builder_stream_test ..................   Passed    0.01 sec
Start  7: cpp-netlib-uri_encoding_test
7/19 Test  #7: cpp-netlib-uri_encoding_test ........................   Passed    0.00 sec
Start  8: cpp-netlib-relative_uri_test
8/19 Test  #8: cpp-netlib-relative_uri_test ........................   Passed    0.00 sec
Start  9: cpp-netlib-http-response_incremental_parser_test
9/19 Test  #9: cpp-netlib-http-response_incremental_parser_test ....   Passed    0.00 sec
Start 10: cpp-netlib-http-request_incremental_parser_test
10/19 Test #10: cpp-netlib-http-request_incremental_parser_test .....   Passed    0.00 sec
Start 11: cpp-netlib-http-request_linearize_test
11/19 Test #11: cpp-netlib-http-request_linearize_test ..............   Passed    0.00 sec
Start 12: cpp-netlib-http-client_constructor_test
12/19 Test #12: cpp-netlib-http-client_constructor_test .............   Passed    0.00 sec
Start 13: cpp-netlib-http-client_get_test
13/19 Test #13: cpp-netlib-http-client_get_test .....................   Passed    7.29 sec
Start 14: cpp-netlib-http-client_get_different_port_test
14/19 Test #14: cpp-netlib-http-client_get_different_port_test ......   Passed    0.67 sec
Start 15: cpp-netlib-http-client_get_ready_test
15/19 Test #15: cpp-netlib-http-client_get_ready_test ...............   Passed    0.46 sec
Start 16: cpp-netlib-http-client_get_streaming_test
16/19 Test #16: cpp-netlib-http-client_get_streaming_test ...........   Passed    1.61 sec
Start 17: cpp-netlib-http-server_constructor_test
^CMakefile:97: recipe for target 'test' failed
make: *** [test] Interrupt


Fix dark/light mode selector

Describe the bug
color-modes.js file needs to move to vue.
To Reproduce
Steps to reproduce the behavior:

Go to homepage
Click on theme selector
Cannot change theme because js is broken.

Expected behavior
Switch themes when selecting a new theme.

Fixed in 1.5.0


Add EmrEtlRunner option to filecrush to hour precision not just day

The filecrush code rolls up all CloudFront files to the day currently:
"--groupBy"           , ".*\\.([0-9]+-[0-9]+-[0-9]+)-[0-9]+\\..*",

For most users, this will be fine - if they run nightly, they will end up with 1 or a handful of LZO-compressed files of 128Mb each.
But for absolutely huge sites and content/ad networks, it may be more efficient to compress at the level of each hour:
"--groupBy"           , ".*\\.([0-9]+-[0-9]+-[0-9]+-[0-9]+)\\..*",

Note the moved ")" in the above. Add a configuration argument to config.yml to support this option.
Low priority - +1 this ticket if you fall into this bucket (sorry).

consolidation is done when moving data from hdfs to s3, closing


refactor(css/parser): Added BadUrl token + error recovery

Added BadUrl token + error recovery

Do you mean we should do breaking change here?

I think we should mark this as a breaking change of swc_css_ast because the changed interface is in it.


feat(helm): use good securityContext by default

Problem Statement
Better default securityContext for the pods, see https://github.com/external-secrets/external-secrets/issues/2207 for details
Related Issue
Fixes https://github.com/external-secrets/external-secrets/issues/2207
Proposed Changes
By using strong securityContext as the default values. User can still lessen the provided configuration, should the need arise.
Additional Information
I have been using the provided securityContexts without issue for some time, although I would appreciate someone other than me testing it as well.
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] I ensured my PR is ready for review with make reviewable

hi @jemag ! Can you also update our helm unit tests?

Updated the tests. First time using the unittest plugin, let me know if the changes are not as expected.

/ok-to-test sha=cb990aa


Documentation

Write basic documentation for both development and usage of Happening

This has been written for most parts of happening but is not yet complete.

Apart from the parts which are still open #47 #49 etc. This is complete.


Fix per unit

this PR resolves #98

Great! Looks good. But you've rebased on top of a separate PR. So we cannot merge both now. I suggest that we review this but not merge it yet. Once the other PR has been merged I can rebase on top of origin/master, remove duplicate commits and then merge this tests pass.

Codecov Report

Merging #99 into master will increase coverage by 0.91%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   79.38%   80.29%   +0.91%
==========================================
  Files          28       28
  Lines        1266     1340      +74
==========================================
+ Hits         1005     1076      +71
- Misses        261      264       +3

Impacted Files
Coverage Δ

src/parsers/standardfiles_parser.jl
100% <100%> (ø)
:arrow_up:

src/parsers/dict_to_struct.jl
93.54% <87.5%> (-0.84%)
:arrow_down:

src/parsers/pm_io/data.jl
83.96% <0%> (+4.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6925f...abdee3e. Read the comment docs.


[WIP] Add kinase inhibitors in solvent test system

This generalizes the sampler testing framework to facilitate automated testing of multiple tests in perses.tests.testsystems, and adds a KinaseInhibitorTestSystem with all FDA-approved kinase inhibitors (from this file) in solvent.

Added T4 lysozyme L99A non-binders and binders.

Test failures seem to be due to #110.

@pgrinaway: Might be useful to include these test systems in the geometry engine tests, since we'll at least need to sample over the T4 lysozyme ligands for the paper, and it would be useful to make sure the geometry engine works for kinase inhibitors.

I will add the T4 lysozyme L99A/M102Q molecules too.

I added a quick fix for #119.
Now I am seeing errors like this:
======================================================================
FAIL: Testing SAMS sampler with T4LysozymeInhibitorsTestSystem 'explicit'
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/choderaj/miniconda/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 701, in run
    self.update()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 688, in update
    self.update_sampler()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 607, in update_sampler
    topology_proposal = self.proposal_engine.propose(system, topology)
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/rjmc/topology_proposal.py", line 924, in propose
    assert smiles_new == proposed_mol_smiles
AssertionError

OK, I think we can deal with these failures separately, so I'll merge this.

The errors look to be discrepancies in the SMILES strings:
======================================================================
ERROR: Testing MultiTargetDesign sampler with T4LysozymeInhibitorsTestSystem transfer free energy from vacuum -> explicit
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/choderaj/miniconda/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 948, in run
    self.update()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 933, in update
    self.update_samplers()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 903, in update_samplers
    sampler.update()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 825, in update
    self.update_sampler()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 799, in update_sampler
    self.sampler.update()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 687, in update
    self.update_sampler()
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/samplers/samplers.py", line 606, in update_sampler
    topology_proposal = self.proposal_engine.propose(system, topology)
  File "/Users/choderaj/github/choderalab/perses/perses.choderalab/perses/rjmc/topology_proposal.py", line 925, in propose
    raise Exception("smiles_new (%s) != proposed_mol_smiles (%s)" % (smiles_new, proposed_mol_smiles))
Exception: smiles_new (c1ccc(cc1)/C=N/O) != proposed_mol_smiles (ON=Cc1ccccc1)

I wonder if this is due to slight differences in how OpenEye SMILES parsing is done.  The input SMILES library may not be the same flavor of canonical isomeric SMILES, so perhaps the first thing SmallMoleculeSetProposal needs to do is to check the input SMILES strings and either transform them into canonical isomeric SMILES or raise an Exception.


Ensure Attestation Cert and Attested Cert are verified

Attempt to fix issue #30
PathLengths are not currently checked, but should be at some point in the future

I'm so sorry I missed this. I just found the same bug.  I'm going to merge this ASAP pending review.

Thank you for this, well reviewed and well written. I've merged this and tagged the v1.4.0 release. Thank you so much.


markdown: Present redesigned code spans.

This PR does two primary things:
First, it rewrites the in-place Markdown styles regarding code spans and blocks as CSS variables.
Second, it implements @terpimost's new look and feel for code spans and blocks as most recently described in this PR comment.
Additionally, it cleans up some CSS to remove unreachable styles. It also makes heavier use of the .codehilite selector, as there are no <pre> elements possible in rendered Markdown that aren't also children of the Pygments-inserted .codehilite class.
Finally, code spans contained inside links remain colored properly.
Fixes one part of #22022.
CZO discussion
Screenshots and screen captures:
As of 2023-11-13 (new Pygments theme):

Light Mode
Dark Mode

As of 2023-10-30:

Light mode
Dark mode

A veritable graveyard of outdated screenshots
As of 2023-10-19:

Light mode
Dark mode

As of 2023-10-13:

Light mode
Dark mode

Light mode, with code-span border
Dark mode, with code-span border

A previous, now dropped commit removed the code-span borders; if we decide to go this route, some cleanup will be needed of unused border-color variables.

Light mode, without code-span border
Dark mode, without code-span border

Light mode, 2023-10-05

Dark mode, 2023-10-05

Before
After

Mention span colors, before
Mention span colors, after

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I think lets just make code span borders and background the same as the code block:
.rendered_markdown code {
...
    background-color: var(--color-markdown-pre-background);
    border: 1px solid var(--color-markdown-pre-border);
}

I don't know how do you want to solve the problem of the text color correction to have the links in code span as they are in a message.
I guess you can write css to avoid <code> inside <pre> to be styled with changed background and stroke, to not have a such affect:

I played with the version I see (for some reason without suggestions that we talked and @karlstolley probably pushed)...
The new context is that for code spans we might not have border on Flutter and it would be nice to see if we can live without them.
Light theme
Regular message background
We make codespan style almost the same as code block:

code span:
  background-color: hsl(208deg 5% 95% / 85%);
  border: 1px solid hsl(208deg 10% 70% / 30%);

code block:
  background-color: hsl(208deg 5% 97% / 85%);
  border: 1px solid hsl(208deg 10% 70% / 30%);

In this case we can remove border and maintain close enough look of blocks
For highlighted messages we use white bg but correct stroke, and style is the same for code span and code block:

  background-color: hsl(0deg 0% 100%);
  border: 1px solid hsl(208deg 10% 70% / 50%);

For highlighted messages code block and code span without border would work well too
Regular message just with a border (same style as for highlighted) is also appropriate:

but in this case when we remove border on the code span we are loosing any distinctiveness:

The last option in this case would be to highlight the code span text in this case there is no good correlation between the block and the span and the previously suggested option with darker background feels right.

color: hsl(20 70% 35% / 1);
    background-color: hsl(20 10% 96% / 1);

If we don't like complexity of styles and want to simplify things... lets just do code span and code block in all backgrounds the same in light theme:
color: hsl(208 15% 23% / 1);
    background-color: hsl(208deg 10% 70% / 15%);
    border: 1px solid hsl(208deg 10% 70% / 40%);

Test-deployed this on chat.zulip.org.

Made some corrections @karlstolley https://github.com/zulip/zulip/pull/27429

This is now deployed on chat.zulip.org.

This has broken highlighting for the diff language.
We should probably be using one of Pygments’ built-in styles, which are more likely to be complete and well-maintained than something from a third party. You can get CSS for the built-in styles with this command (or the get_style_defs API):
$ pygmentize -f html -S github-dark
pre { line-height: 125%; }
td.linenos .normal { color: #6e7681; background-color: #0d1117; padding-left: 5px; padding-right: 5px; }
span.linenos { color: #6e7681; background-color: #0d1117; padding-left: 5px; padding-right: 5px; }
td.linenos .special { color: #e6edf3; background-color: #6e7681; padding-left: 5px; padding-right: 5px; }
span.linenos.special { color: #e6edf3; background-color: #6e7681; padding-left: 5px; padding-right: 5px; }
.hll { background-color: #6e7681 }
.c { color: #8b949e; font-style: italic } /* Comment */
.err { color: #f85149 } /* Error */
.esc { color: #e6edf3 } /* Escape */
.g { color: #e6edf3 } /* Generic */
…
.vg { color: #79c0ff } /* Name.Variable.Global */
.vi { color: #79c0ff } /* Name.Variable.Instance */
.vm { color: #79c0ff } /* Name.Variable.Magic */
.il { color: #a5d6ff } /* Literal.Number.Integer.Long */

Updated the version of this on chat.zulip.org.

Merged, thanks @karlstolley!


Make error messages more clear

Error messages needs to be more clear

@amiraabouhadid  any steps to reproduce this error ?

Should be improved in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/198

Verified, Changes in the error message

Screen will be added once error reproduce.

Weblets Devnet, version 49a9c82 .
Same message error was displayed.

This wants a release, once the playground get released it'll work.


macOS WKWebView doesn't render

Known issue: https://github.com/ShingoFukuyama/WKWebViewTips/issues/7

NOOOOOOOOOOOOO


fixed: rbac

@fleeto , thanks very much for your contribution.  You prompted us to get the right pieces in place to accept your contribution (we just made an update to README.md).  Could you please sign https://github.com/aspenmesh/cla/raw/master/f5-cla.pdf and email it to<EMAIL_ADDRESS>?
Again, many thanks for this!

@fleeto , thanks very much for your contribution. You prompted us to get the right pieces in place to accept your contribution (we just made an update to README.md). Could you please sign https://github.com/aspenmesh/cla/raw/master/f5-cla.pdf and email it to<EMAIL_ADDRESS>?
Again, many thanks for this!

signed.

Thanks @fleeto!


Malfunction regarding residue name containing numbers

version: SINCHO v1.1.1
In case of residue names containing numbers, sincho.pse does not have any scene of candidates.
It probably derives from script_sincho/visualize/pse_gen.py.

This bug was solved in SINCHO v1.1.2.


hardcoded 'partfile_alt_format'

Discussed in https://github.com/copy/v86/discussions/1000

Originally posted by farhan-ct March  5, 2024
Hi,
I observed that the option 'partfile_alt_format' is hardcoded as false, which results in not considering fixed chunks made using gnu split. Is there any specific reason why this was done?
@copy

@copy

It was a prototype that was never used. The current format has the advantage that you can't get the chunk size wrong (you'd get 404s).
Feel free to send a PR to expose the alternative format, if you really want to use it.

This is what I am using currently, same as mentioned in main.js demo page

I edited the built libv86.js file and hardcoded partfile_alt_format to true.
I split my image using split -b 1M -a8 -d --additional-suffix .img <image-name>.img <some-prefix>-

  hda: {
    url: <.img url>,
    size,
    async: true,
    fixed_chunk_size: 1024 * 1024,
    use_parts: true,
  }

and it's working great.
I am closing this issue for now, thank you!


[Bug] jsx-no-constructed-context-values empty schema is incorrect

https://github.com/jsx-eslint/eslint-plugin-react/blob/747fad0e06e73155616df62575626f7953260dec/lib/rules/jsx-no-constructed-context-values.js#LL141C13-L141C15
jsx-no-constructed-context-values empty schema should be [], but it's {}
This leads to incorrect rule type generation by https://github.com/Shinigami92/eslint-define-config
export interface JsxNoConstructedContextValuesRule {
  /**
   * Disallows JSX context provider values from taking values that will cause needless rerenders.
   *
   * @see [jsx-no-constructed-context-values](https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-constructed-context-values.md)
   */
  'react/jsx-no-constructed-context-values': Rule<
    [
      RuleLevel,
      ...{
        [k: string]: any; // <-- `...{}`, explected `...[]` (i.e. no settings)
      },
    ]
  >;
}

I'm not familiar with that tool, but #3106 fixes that - it'd be a breaking change tho, so it's unlikely we'll ever do it.


Replaced != with !Objects.equals()

Hi guys, I'm new to open-source contribution, so I made this PR as an ice breaker; so forgive if the change is so silly and irrelevant.
Anyways, I'd appreciate your feedback on my pull request or if you like me to work on something else.
Thank you!
#1663

@mosbat Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@mosbat Thank you for signing the Contributor License Agreement!

I don't think this change is necessary, so I'll pass, but please send more if you find other things that inspire you.

I don't think this change is necessary, so I'll pass, but please send more if you find other things that inspire you.

Sure, thank you for the feedback. I'm happy to contribute :)


Use deprecated field in actix-web plugin

Writing #[deprecated] has been implemented in codegen (in #131), but it could also be used in the plugin the other way around for operations. It would be nice to have it for cody parameters to but that is not supported in openapi.
https://doc.rust-lang.org/edition-guide/rust-2018/the-compiler/an-attribute-for-deprecation.html
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#operation-object

Using #[deprecated] in codegen makes sense because it'll throw warnings during compilation if the user makes use of the deprecated operation. For server-side, we probably shouldn't use that because the developer is deprecating it in the first place. We can instead have #[api_v2_operation(deprecated, ...)] among other things in the macro.

That makes sense - I'll close this then in favour of adding it with other fields to the macro.


[5.0] Tweaked The Tinker Command

// cc @bobthecow

But this is the wrong direction. Where are all the scope variables and awesome custom presenters and commands? ;)

@bobthecow I clearly didn't understand what you meant then, lol. If there any chance you could send a pull requests to show us what you mean?


raftstore: prevent unsafe local read during merging

What problem does this PR solve?
Issue Number: close https://github.com/tikv/tikv/issues/8034
Problem Summary:
In this PR(https://github.com/tikv/tikv/pull/3116), it prevents unsafe local read by suspecting the leader lease.
https://github.com/tikv/tikv/blob/5755b3e67e910486fcd8ae76084e9979eec2bcd3/components/raftstore/src/store/peer.rs#L1456-L1466
But this may be too late to prevent unsafe local read.
After getting a raft ready, the msg will be sent immediately if it's a leader, which means the followers will know the PrepareMerge log is committed sooner. If a follower knows it, it will apply PrepareMerge log and propose CommitMerge to the target region, the merge process will succeed and can provide services.
In the previous fix, we suspect a leader lease after persisting the ready data. Between this time interval, local read will work as normal but it may get stale data.
I construct a simple test to reproduce this bug.

put (k1, v)
split region
set failpoint(pause) before suspecting the leader lease
merge left region to right region(only in other two pair regions, the leader of left region is stuck due to failpoint)
put (k1, v1)
read to the leader of left region => get (k1, v)

What is changed and how it works?
What's Changed:
Suspect the leader lease before sending msg to other followers if a PrepareMerge log is committed.
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Integration test

Side effects
No.
Release note

Fix an issue that read may get stale data during merging

/bench


Tobin riku pipe stats feature check

Fixes #1179
New check from Riku Salminen to make sure that pipeline stats are enabled when creating a query pool for them.
I added a test to verify that the check works.

Database update?

@karl-lunarg yep, just pushed CL with database update

cherry-picked and pushed to master


Add support for repeat validate_field calls

Calling validate_field multiple times (especially when calling auto_validate and then augmenting after with extra validations) caused all previously validations to be dropped and only those from the last call would be applied.

Tested again locally, error messages are being combined. All looks good.


New Turbinia LLM analyzer, LLM lib interface and LLM lib implemntation for VertexAI

New Turbinia LLM analyzer, LLM lib interface and LLM lib implementation for VertexAI
please assign to @hacktobeer for review, he is aware of this work

New LLM lib interface
LLM lib for Vertex AI (using Gemini pro 1.0 model)
Interface can be extended or implemented for other LLM providers
New configs for Vertex AI
LLM_PROVIDER config value can be used to choose LLM provider (currently only Vertex AI)
New Job to analyze history, log and config files using LLM
New evidence type (ExportedFileArtifactLLM) for FileArtifactExtractionTask to avoid redundant procesing of artifacts between LLM analyzer and other analyzers using same artifacts
Files to analyze are extracted using FileArtifactExtractionTask, i.e. all artifacts supported by image_exporter.py are supported
Tested end to end using evidence/artifact_disk.dd

Excellent @sa3eed3ed  - I have assigned myself and will review before EOW.

Drive-by comment: could we specify a minimum version of the new dependencies in pyproject.toml with "^x.y.z" instead of "*"? That way we are less likely to run into dependency breakages down the line. There's also an open PR that will remove most GCP library dependencies from the Turbinia code base. From what I can tell, the vertexAI package only depends on google-api-core which would be kept anyway so it's not a problem.

Drive-by comment: could we specify a minimum version of the new dependencies in pyproject.toml with "^x.y.z" instead of "*"? That way we are less likely to run into dependency breakages down the line. There's also an open PR that will remove most GCP library dependencies from the Turbinia code base. From what I can tell, the vertexAI package only depends on google-api-core which would be kept anyway so it's not a problem.

Done, added version, I thought even if google-api-core is removed from pyproject.toml the poetry.lock file will have all the deps needed by vertexAI package

Drive-by comment: could we specify a minimum version of the new dependencies in pyproject.toml with "^x.y.z" instead of "*"? That way we are less likely to run into dependency breakages down the line. There's also an open PR that will remove most GCP library dependencies from the Turbinia code base. From what I can tell, the vertexAI package only depends on google-api-core which would be kept anyway so it's not a problem.

Done, added version, I thought even if google-api-core is removed from pyproject.toml the poetry.lock file will have all the deps needed by vertexAI package

Yes, it will have the dependencies. My point was just to add a version, nothing else is needed. :) the core lib is included in libcloudforwnsics dependencies as well , which is already in the tonl file

Thanks @sa3eed3ed. I have reviewed and tested the PR, looks pretty cool, looking forward to getting more real life results! I have no other review comments.
Example output for others following along:
* LLMAnalyzerTask (/evidence/002ef2465f6b46c1a63d2ad93c783a02/1708894370-9c15b072c9bd49f8b5e13fd04b4fbcad-FileArtifactExtractionTask/export/etc/redis/redis.conf): **Summary:** Redis configuration file contains default bind address of "<IP_ADDRESS>", allowing remote clients to connect without authentication.

* LLMAnalyzerTask (/evidence/002ef2465f6b46c1a63d2ad93c783a02/1708894292-8b20bc2016f14f16b5d5bbd8ee39b278-FileArtifactExtractionTask/export/home/dummyuser/.jupyter/jupyter_notebook_config.py): **Summary:** Jupyter Notebook server is exposed to the internet with weak security settings, allowing unauthorized access, remote code execution, and potential compromise of sensitive data.

* LLMAnalyzerTask (/evidence/002ef2465f6b46c1a63d2ad93c783a02/1708894416-d4f26a75a3124996bf90723c51c501a3-FileArtifactExtractionTask/export/etc/ssh/sshd_config): **SSH configuration allows weak ciphers, root login, password authentication, and empty passwords, posing a high security risk.**

@aarontp - before I merge this can I get your opinion on the inclusion of this analyser in all triage recipes?

For future ideas regarding this analyser:

bundling output reports (this is more generic and applies to other analysers as well in case we get eg disk images from GKE nodes with tons of containers)
adding/removing the analyser from any triage recipe depending on real world output results
make module configuration parameters configurable in eg recipes depending

@aarontp - before I merge this can I get your opinion on the inclusion of this analyser in all triage recipes?

Do we have any data about how long it takes to run on a typical input disk?  Assuming it doesn't take too long to run, generally I would say it makes sense to include it anywhere we are including the other analysis tasks, which at the moment are not in the triage recipes as defined by the triage-* recipes here: https://github.com/google/turbinia/tree/master/turbinia/config/recipes, but we do have them in the disk related dftimewolf recipes, so we could include it in the turbinia recipes used by those (I can't remember if those disk related dftimewolf recipes are currently just using the default recipe, or if there is a dedicated recipe, but we do have a goal of making every dftimewolf recipe use a corresponding turbinia recipe this year).

@aarontp - before I merge this can I get your opinion on the inclusion of this analyser in all triage recipes?

Do we have any data about how long it takes to run on a typical input disk? Assuming it doesn't take too long to run, generally I would say it makes sense to include it anywhere we are including the other analysis tasks, which at the moment are not in the triage recipes as defined by the triage-* recipes ....

It's fast, faster than plaso. FileExtraction is fast as the artifact definitions are pretty specific and VertexAI calling is fast as well. It will be done faster than the plaso task that is ran in parallel.

@aarontp - before I merge this can I get your opinion on the inclusion of this analyser in all triage recipes?

Do we have any data about how long it takes to run on a typical input disk? Assuming it doesn't take too long to run, generally I would say it makes sense to include it anywhere we are including the other analysis tasks, which at the moment are not in the triage recipes as defined by the triage-* recipes ....

It's fast, faster than plaso. FileExtraction is fast as the artifact definitions are pretty specific and VertexAI calling is fast as well. It will be done faster than the plaso task that is ran in parallel.

Removed from Triage recipes

Ran local tests and looks good. One final nit.
Can you add below to the configuration template? turbinia/config/turbinia_config_tmpl.py
}, {
    'job': 'LLMAnalysisJob',
    'programs': [],
    'docker_image': None,
    'timeout': 600
}, {
    'job': 'LLMArtifactsExtractionJob',
    'programs': [],
    'docker_image': None,
    'timeout': 600

After that I'll do a final check if the e2e tests run fine and will approve/merge

Ran local tests and looks good. One final nit. Can you add below to the configuration template? turbinia/config/turbinia_config_tmpl.py
}, {
    'job': 'LLMAnalysisJob',
    'programs': [],
    'docker_image': None,
    'timeout': 600
}, {
    'job': 'LLMArtifactsExtractionJob',
    'programs': [],
    'docker_image': None,
    'timeout': 600

After that I'll do a final check if the e2e tests run fine and will approve/merge

done, I made the timeout 3600 matching default https://github.com/google/turbinia/blob/d8c7377e53bff0d88512a660f3dcbdde52b3cb71/turbinia/job_utils.py#L34
I don't expect it to take 1 hour, but there seem to be many other jobs with longer timeouts but if you think this might be problematic feel free to amend


WIP: FileServerResourceManager PowerShell reference update

1871110
Added Input and Output values from PlatyPS.

Docs Build status updates of commit 8d540e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAdrSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmEffectiveNamespace.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMacro.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmRmsTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyValue.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFMJNotification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjCondition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjNotificationAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaThreshold.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmScheduledTask.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Reset-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ae6e241:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAdrSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmEffectiveNamespace.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMacro.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmRmsTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyValue.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFMJNotification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjCondition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjNotificationAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaThreshold.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmScheduledTask.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Reset-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd - This is ready for review.

Docs Build status updates of commit 4efefb1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAdrSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmEffectiveNamespace.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMacro.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmRmsTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmSetting.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Get-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationPropertyValue.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFMJNotification.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjCondition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmFmjNotificationAction.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmQuotaThreshold.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmScheduledTask.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/New-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmAutoQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationPropertyDefinition.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmClassificationRule.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileManagementJob.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenException.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmFileScreenTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmMgmtProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuota.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmQuotaTemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Remove-FsrmStorageReport.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/fileserverresourcemanager/Reset-FsrmFileScreen.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

With 79 Markdown files, I've only reviewed the changes to source and a random selection of preview pages. In that, I didn't see anything that was a problem.


Fix Fade In Effect

Minor tweak to fix the modal fading.

@tiagoapp do you have a demo to see what is the improvement on this for the UI? Thanks!!!

You already have the CSS classes for fading the modal, but they currently don't work (https://solana-svelte-counter.netlify.app/) -- clicking on the 'select wallet' don't fades the modal.
I fixed this by removing the CSS and use the transition:fade from svelte
https://solana-svelte.vercel.app/
So you can see the modal in this case does fade in @silvestrevivo


fix: Limit email length as per RFC 5321

Adds a length check on validating email addresses, as per RFC 5321, quoting here:

<IP_ADDRESS>.1.  Local-part
The maximum total length of a user name or other local-part is 64
octets.
<IP_ADDRESS>.2.  Domain
The maximum total length of a domain name or number is 255 octets.

/ok-to-test<EMAIL_ADDRESS>
Summary by CodeRabbit

New Features

Enhanced email validation based on RFC 5321 standards, ensuring email addresses meet specific length and format requirements before processing.

Improvements

Simplified email validation logic by removing redundant null checks.

Tests

Added tests for inviting users with invalid email addresses, focusing on excessively long local or domain parts.

[!TIP]
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8464010263
Commit: 8af5c9e5e2a5a9862afd8b3293a0eea3106fd8b9
Workflow: PR Automation test suite
Tags: @tag.Sanity

@sharat87 : This looks ok from CE perspective. But there are a couple of flows (UserGroup invite, Role invite, and any new flows coming in in the future). Would it make more sense to move the email validation to UserService.userCreate flow instead? That ways we don't have to handle it at invite level but one common change would handle it all?

@trishaanand, thanks for sharing that. I'd rather add the validation separately there also, so that for the invite flow, we fail fast and fail especially.
For example, in the inviteUsers method, there quite a bit of code happening before we call .userCreate.
But I agree in principle though. I'll add this validation call into userCreate as well. I'd rather we over-validate than under. Does that sound okay?

@trishaanand, thanks for sharing that. I'd rather add the validation separately there also, so that for the invite flow, we fail fast and fail especially.
For example, in the inviteUsers method, there quite a bit of code happening before we call .userCreate.
But I agree in principle though. I'll add this validation call into userCreate as well. I'd rather we over-validate than under. Does that sound okay?

Sounds good to me!


Helm chart configure and create custom service account

Is your feature request related to a problem? Please describe.
There was lack of service account management while using helm charts.
Describe the solution you'd like
Being able to create service account for superset and configure its name.
Additional context
There was ServiceAccountName variable added in the past, so I've implemented new feature as enhancement beside the current solution.
PR: https://github.com/apache/superset/pull/17880

Thank you for helping our efforts on improving superset helm chart

As #17880 and #17920 is merged this issue can be closed.


Pressing Ctrl+Backspace while typing in filter box removes the highlighted cell

System information:

Windows 10
DBeaver 7.1.0

Connection specification:

MySQL

Describe the problem you're observing:
When you type in the filter box and you press Ctrl+Backspace, instead of deleting the text, it removes the highlighted cell in the data viewer.

hi @MedicOP ,
unfortunately cannot reproduce an issue. Probably some special steps are needed?

hi @MedicOP ,
unfortunately cannot reproduce an issue. Probably some special steps are needed?

Hmm.. This happens for both me and my colleague on different machines. We both use Windows 10, maybe that's the common factor?

thanks for the bug report

I can reproduce using following steps:

Open a table in default schema (e.g. Kseniia, sakila, table language4, language)
Select a cell and go to upper filter line
Press Ctrl+Backspace

Actual result: the cell data is set to default.
If you do not reach the actual result, continue:

Close the table
Set other schema as a default
Reopen the table
Select a cell and go to upper filter line
Press Ctrl+Backspace

Actual result: the cell data is set to default.

I have this problem now on 7.1.1, but when writing sql in the editor. Any Ctrl+backspace while writing sql will delete the currently selected cell in the result editor.
Currently using Windows 10, can't say I remember this happening on Kubuntu (that I was using yesterday).

I've fixed focus tracker service usage. Hopefully it will resolve the problem.

Still can be reproduced using steps above. Build <IP_ADDRESS>006241010

Extra fix added (problem with context activation)

verified


docs/concepts/services-networking/service/ needs overhaul

This is a Feature Request

What would you like to be added

Overhaul https://kubernetes.io/docs/concepts/services-networking/service/. From a high level, I guess it would be great to do:

Make it really talk about concept. e.g. what does service do, what is its relationship with label/endpoint/pod, what are the service types and other essential API surface, etc.
Split the kube-proxy implementation details / history to somewhere else.
Remove the cloud specific tutorials / notes.

Why is this needed
The service doc page contains too much unnecessary information. It brings lots of confusion to people who just wants to learn the concept of a kubernete service. The kube-proxy implementation doesn't really matter as they all serve the same service API. It would be more clear to extract those nuances to another place for folks that are willing to dig deeper.
The doc also contains too much cloud provider specific content that really should be served on provider's own place. e.g. how to configure X load balancer feature on Y cloudprovider.
Comments

/kind feature
/language en

Hi @MrHohn
Is this a duplicate of #3735?

Hi @sftim, #3735 focuses more about mentioning Ingress from the Service page so folks can get the right direction while this issue cares more about how Service page is constructed in general. So I don't think it is a duplicate.

The Service page certainly wants more work done on it.

Slightly relevant: #12410 talks about kube-proxy examples.

Discussed in SIG Docs weekly meeting.
/priority important-longterm
cc @cody-clark

Also relevant to #11382 because the current page is heavy on AWS-specific detail.

/remove-lifecycle stale

Also see #18085

/remove-lifecycle stale

Also see #19176

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle stale

/reopen
/lifecycle frozen
We still need to do this

Closed issue https://github.com/kubernetes/website/issues/9122 is apposite too
/sig network
/triage accepted

Also relevant: issue #29107 (about the very first sentence)

Also see issue #29827

Also relevant: #32243

Also see https://github.com/kubernetes/website/pull/38542

This is mostly Done. We can open smaller issues - such as https://github.com/kubernetes/website/issues/41173 - to track specifics.
/close


Cannot Set Maximum size

Good Morning!
I cannot seem to set a maximum radius for a circle.
Sometimes i have very distant data with a relativly small intersection.
This causes the smaller sized object to be nearly invisible.
Manually setting the radius misplaces the diagram totally.
Any way to set a max size/minimum size for a circle?
Thanks!

Probably easier to set a minimum size here - I would do something like
d3.selectAll("circle").attr("r", function(d) { return min(d.radius, 10); }
to put a lower bound on this

@benfred Tried using your suggestion to set minimum radius size, but with no luck.
This is what I used:
d3.selectAll(".venn-circle").attr("r", function(d) {
    return 10;
});

I see that an "r=10" attribute is added to the rendered path.venn-circle but it doesn't affect the circle size.
Tried with differrent values (10,100,1000) - no change.
Is there a way to set a minimum circle size with the library these days?


Device uuid is null on platform browser

Bug Report
Device uuid is null on platform browser
Problem
By running ionic cordova run browser device uuid is null as Device object is empty
What is expected to happen?
Device info should be there as it supports browser platform
What does actually happen?
Device object is empty when running the application on browser platform
Information

Here's my code
import { Device } from '@ionic-native/device/ngx';
constructor(private device: Device) { }
console.log('Device UUID is: ' + this.device.uuid);
Result: Device UUID is: null
Command or Code

ionic cordova run browser
Environment, Platform, Device
Platform is browser using chrome
Version information

@ionic-native/device": "^5.5.0
Please help me out how to resolve this problem. I have tested the code on android device. It's working fine

What value would you expect there?

What value would you expect there?

I expect device object should have some values like device.platform, device.model etc.

Does the plugin return nothing at all or just not the uuid?
And again, what should the uuid field be filled with? What value should be in there and where should it come from? What is the uuid of a browser?

as iOS does not share the UUID which is generated by the plugin from instance to instance (lost after reinstall) i do fallback on a generated GUID which is then saved to localstorage.

The browser platform does not have access to the devices UUID. This is why null is returned for the browser platform.
There are alternatives that you can implement on your own for example Fingerprint.js. The goal of Fingerprint.js is to use all of the features that the browser has access to create a unique identifier. They advertise a 99.5%  identification accuracy. There is a drawback where a user can do something to make the identifier change.
@janpio for some additional feedback to your question, if the browser had the access permission, the UUID would be most likely related with the OS or a hardware ID.
For example:

macOS would fetch the UUID from IOPlatformUUID. If you have a Mac, you can test this with ioreg -rd1 -c IOPlatformExpertDevice | grep IOPlatformUUID
Windows would use the MachineGuid from the registry but can be edited with administrator permission.
Linux would use the dbus machine-id, but can be changed with root access.

For Electron, I have been looking at some npm modules that would use the information that I posted in the example above. Unfortunately, browser, just does not have the necessary permission to access this level of information of the OS for security reasons. Because of that, users must find alternatives solutions like Fingerprint.js or create their own UUID and store it somewhere like IndexDB.


Use beacon package for nav-flash module

Describe your request
I'd like Doom to incorporate the package beacon into the current nav-flash module.
Briefly explain its use-case
beacon performs flashing of cursor position instead of flashing the current line.
Cursor flashing is arguably more useful than line flashing.

When I first wrote nav-flash, I tried beacon and it introduced unacceptable input latency while it animated the flash. Unless that has changed I'm hesitant to introduce it to Doom. Considering the package hasn't been updated in 3 years, I'm pessimistic that this situation has improved.
Anyhow, I'll give it a spin when I have time.


tslint 2.1.0 has regression when using variables-before-functions member ordering rule

Given the following tslint.json:
{
    "rules": {
        "member-ordering": [true,
            "variables-before-functions"
        ]
    }
}

and test.ts:
class Foo {
    private bar(): any {
        var bla: { a: string } = {a: '1'};
    }
}

tslint 1.2.0 reports nothing
tslint 2.1.0 reports: test.ts[3, 20]: Declaration of public instance member variable not allowed to appear after declaration of private instance member function
Using git-bisect indicates that b26988695f263cda8f518178ae074a7c4d075d9d introduced the regression, but I haven't fully understood why yet.

The key part here that the internal variable is an object literal where a is following bar that tslint is complaining about.

@gscshoyru can you look into this? thanks.

Thanks!  When may expect a next release that will include this fix?

we're still fixing a couple of other reported bugs, so tentatively it'll be sometime early next week


Cascade specification doesn't allow static type checking.

The specification of cascade invocation just says that e..suffix is equivalent to  (t){t.suffix; return t;}(e) .
The "t" variable isn't typed, so there should be no warning for, e.g.,
  "abc"..noMethodNamedThis()
Also, the return type of the function literal is dynamic, so the type of e is lost there too:
  ("abc"..toString()).noMethodNamedThis()
should also not give a warning.
Could the spec of cascade be rewritten to not erase the type, e.g.,:
  ... equivalent to  (((T t) { t.suffix; return t;})(e) as T)  where T is the static type of e.
Or, alternatively, give static typing rules for cascades explicitly:
  e..suffix
has the static type T where T is the static type of e, and gives a warning if e.suffix would give a warning.

The cascade specification has been rewritten. It is no longer rewritten as a function invocation.
It still doesn't say what the static type is. I'll fix that.


VectorGraphics

Update  _All shape types (Line,Circle, etc) are immutable, as is VectorGraphics. Need to think about making it easy to replace existing object with an updated version of itself - preferably as one expression.
set gr to gr.replace(frontWheel, copy wheel with x to x + 3)

To appear the Graphics pane
Rendered as SVG (whichs is just Html statements)
Not encouraged to use both BlockGraphics and VectorGraphics in same program, but if you did then each draw would completely overwrite any existing graphics displayed.
Have library types for common shapes e.g. Circle, Line
All shapes implement a common abstract class, SVG say, which defines a method to generate the Html - or parts thereof. Maybe also provides SVG tag name as a property.
You may write your own class that inherits SVG such that you could write any valid SVG, with such properties as you need.
There might be deliberate constraints on Tags. e.g. must come from an enum.

Example code
var gr set to new VectorGraphics()
let frontWheel be new Circle(....)
set gr to gr.add(frontWheel)
call gr.draw()

Basic version implemented and documented, so closing for time being


Scala.JS 1.0 test runner intercepts JS exception

A bit of background first: React allows users to define a componentDidCatch lifecycle hook that is invoked when a child component throws an exception. Users can use this to maybe display the error message on the screen and prevent the error bubbling up further.
I have a test in scalajs-react that covers this behaviour. Since upgrading to Scala.JS 1.0, the error isn't caught by React. Instead it acts as if I typed in ??? rather than render.
I've confirmed that if I run the code in the browser, React catches and handles the error gracefully, rendering exactly what my test case expects. Therefore I think it's something about either the test runner or the node environment.
(Reproduction can be provided soon / on demand)

I've also tried this with both jsdom 9.12.0, 15.something and 16.latest. Same results across the board. This is probably the same as https://github.com/scala-js/scala-js/issues/3458

A reproduction would be awesome!
Does this happen only with the jsdom environment, or can it be reproduce with another environment with DOM support like Selenium?
Harder question: can it be reproduced in a non-DOM environment?

An isolated, minimised reproduction is basically too hard because it's in the React internals that the error is thrown and caught. But I can provide a reproduction using scalajs-react:

Checkout https://github.com/japgolly/scalajs-react/tree/tmp/4029
sbt
test/testOnly -- japgolly.scalajs.react.core.ScalaComponentPTest.lifecycle1

Error occurs at https://github.com/japgolly/scalajs-react/blob/tmp/4029/test/src/test/scala/japgolly/scalajs/react/core/ScalaComponentTest.scala#L171
Regarding the different envs:

JSDOMNodeJSEnv - problem occurs as described
SeleniumJSEnv + Chrome - no problems
SeleniumJSEnv + Firefox - no problems (except the exception provided in the componentDidCatch hook has a different message: "next$1 is null" instead of Cannot read property of null)
no DOM - unfortunately the only way I know to reproduce this is via ReactDOM which requires dom

Also try ... catch doesn't catch the error either :fearful:

When I try your repro, I hit the FileSystemLoopException exception from the other report. What did you change to get to running the test to reproduce the above?

Try with JDK 11

Try with JDK 11

Thanks. Now I can reproduce this.
Just FTR, one's got to love a cs-based installation of Scala. Even on Windows, trying this was as easy as
$ cs launch --jvm 11 sbt-launcher


Invalid node type for language sql

When opening SQL files I am getting the following error:
E5108: Error executing lua /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:261: query: invalid node type at position 315 for language sql
stack traceback:
        [C]: in function '_ts_parse_query'
        /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:261: in function 'get_query'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:50: in function 'new'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:194: in function 'get_query'
        ...tart/playground/lua/nvim-treesitter-playground/utils.lua:52: in function 'fn'
        /usr/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:245: in function 'for_each_tree'
        ...tart/playground/lua/nvim-treesitter-playground/utils.lua:39: in function 'get_hl_groups_at_position'
        ...rt/playground/lua/nvim-treesitter-playground/printer.lua:11: in function 'get_hl_group_for_node'
        ...rt/playground/lua/nvim-treesitter-playground/printer.lua:34: in function 'flatten_node'
        ...rt/playground/lua/nvim-treesitter-playground/printer.lua:77: in function 'process'
        ...t/playground/lua/nvim-treesitter-playground/internal.lua:693: in function 'update'
        ...t/playground/lua/nvim-treesitter-playground/internal.lua:148: in function 'toggle_hl_groups'
        [string ":lua"]:1: in main chunk

I am not sure when this started to happen. The specific dialect I am using is MySQL.

I'm not experiencing this on the latest version of nvim-treesitter. After updating nvim-treesitter try reinstalling the grammar for sql with :TSInstall sql or :TSUpdate.
It would also be helpful to have an example SQL query which causes a problem or a particular tree-sitter query if you're trying to make one.

OK I had to install the tree-sitter CLI and have it compile again from grammar instead of the normal install method. This one works now.


Raz - signing the manifest

Works as a full-time developer for env0.
And would like to individually support this effort too.

Added in https://github.com/opentffoundation/manifesto/pull/903