question regarding TEXT_Files

Hi,
Is it possible to get data under TEXT_Files folder so that I may reduplicate the result?
Best,
Greg

Hi Greg!
Sorry for the extremely belated reply. I unfortunately missed the notification for this issue. I believe that I do still have the input files, and would be happy to send them along. Is there an e-mail you'd like me to send them to?
Cheers,
Heather

Dear Heather,
Yes. Please send the input files to<EMAIL_ADDRESS>Many thanks.
Best,
Greg
On Tue, Feb 12, 2019 at 1:17 AM Heather Lent<EMAIL_ADDRESS>wrote:

Hi Greg!
Sorry for the extremely belated reply. I unfortunately missed the
notification for this issue. I believe that I do still have the input
files, and would be happy to send them along. Is there an e-mail you'd like
me to send them to?
Cheers,
Heather
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hclent/PyPatent/issues/1#issuecomment-462413022, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AaaEk0hSb4OYuX8QT71LHBuLA6184mffks5vMaWlgaJpZM4Zy1ZA
.

I have sent you a zip of the files  :)


[Improvement][API] Make the return value clearer

Describe the question
The return value of some interfaces is not clear, such as you see in xxController.
What are the current deficiencies and the benefits of improvement
Clarifying the type of the method's return value can make the code read better.
Which version of DolphinScheduler:
-[1.3.x]
-[dev]

It is usually recommended that the service return a specific object and be packaged by the controller. This is more intuitive, at least through the controller calling service, we can intuitively see what his specific data return object is. The return interface of service Map<String,Object> is difficult to intuitively understand what it returns.


Remove: Argotronic.ArgusMonitor version <IP_ADDRESS>15

## Newer version exists in repo

[X] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

(Automated response - build 643.)

Automatic Validation ended with:

2024-01-24T13:16:56.4307836Z Processing manifest: manifests\a\Argotronic\ArgusMonitor\<IP_ADDRESS>15
2024-01-24T13:16:56.4308789Z -----------------------------------------------------
2024-01-24T13:16:56.4309496Z Status: Started
2024-01-24T13:16:56.4310159Z Manifest file is Deleted
2024-01-24T13:16:56.4310789Z Status: Completed
2024-01-24T13:16:56.4311430Z ##[error] Result: Failed
2024-01-24T13:16:56.4313152Z ##[error] Sequence contains no elements
2024-01-24T13:16:56.4314621Z ##[error]Manifest Validation Failed

(Automated response - build 643.)

URL: https://www.argusmonitor.com/downloads/ArgusMonitor_Setup.exe
Status Code: 200
(Automated message - build 643)


📎  ERC173 auth lite

A simplified version of Ownable that follows just the EIP spec for ownership I think would be handy, esp if a smart contract would likely hold the role and be able to implement own security and other rules that may or may not be handoff.
POC:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.4;

/// @notice Simple ERC173 ownership mixin.
/// @author Solady (https://github.com/vectorized/solady/blob/main/src/auth/ERC173.sol)
///
/// @dev Note:
/// This implementation does NOT auto-initialize the owner to `msg.sender`.
/// You MUST call the `_initializeOwner` in the constructor / initializer.
abstract contract ERC173 {
    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                       CUSTOM ERRORS                        */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev The caller is not authorized to call the function.
    error Unauthorized();

    /// @dev Cannot double initialize.
    error AlreadyInitialized();

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                           EVENTS                           */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev The ownership is transferred from `oldOwner` to `newOwner`.
    /// This event is intentionally kept the same as OpenZeppelin's Ownable to be
    /// compatible with indexers and [EIP-173](https://eips.ethereum.org/EIPS/eip-173),
    /// despite it not being as lightweight as a single argument event.
    event OwnershipTransferred(address indexed oldOwner, address indexed newOwner);

    /// @dev `keccak256(bytes("OwnershipTransferred(address,address)"))`.
    uint256 private constant _OWNERSHIP_TRANSFERRED_EVENT_SIGNATURE =
        0x8be0079c531659141344cd1fd0a4f28419497f9722a3daafe3b4186f6b6457e0;

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                          STORAGE                           */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev The owner slot is given by:
    /// `bytes32(~uint256(uint32(bytes4(keccak256("_OWNER_SLOT_NOT")))))`.
    /// It is intentionally chosen to be a high value
    /// to avoid collision with lower slots.
    /// The choice of manual storage layout is to enable compatibility
    /// with both regular and upgradeable contracts.
    bytes32 internal constant _OWNER_SLOT =
        0xffffffffffffffffffffffffffffffffffffffffffffffffffffffff74873927;

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                     INTERNAL FUNCTIONS                     */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev Override to return true to make `_initializeOwner` prevent double-initialization.
    function _guardInitializeOwner() internal pure virtual returns (bool guard) {}

    /// @dev Initializes the owner directly without authorization guard.
    /// This function must be called upon initialization,
    /// regardless of whether the contract is upgradeable or not.
    /// This is to enable generalization to both regular and upgradeable contracts,
    /// and to save gas in case the initial owner is not the caller.
    /// For performance reasons, this function will not check if there
    /// is an existing owner.
    function _initializeOwner(address newOwner) internal virtual {
        if (_guardInitializeOwner()) {
            /// @solidity memory-safe-assembly
            assembly {
                let ownerSlot := _OWNER_SLOT
                if sload(ownerSlot) {
                    mstore(0x00, 0x0dc149f0) // "AlreadyInitialized()".
                    revert(0x1c, 0x04)
                }
                // Clean the upper 96 bits.
                newOwner := shr(96, shl(96, newOwner))
                // Store the new value.
                sstore(ownerSlot, or(newOwner, shl(255, iszero(newOwner))))
                // Emit the {OwnershipTransferred} event.
                log3(0, 0, _OWNERSHIP_TRANSFERRED_EVENT_SIGNATURE, 0, newOwner)
            }
        } else {
            /// @solidity memory-safe-assembly
            assembly {
                // Clean the upper 96 bits.
                newOwner := shr(96, shl(96, newOwner))
                // Store the new value.
                sstore(_OWNER_SLOT, newOwner)
                // Emit the {OwnershipTransferred} event.
                log3(0, 0, _OWNERSHIP_TRANSFERRED_EVENT_SIGNATURE, 0, newOwner)
            }
        }
    }

    /// @dev Sets the owner directly without authorization guard.
    function _setOwner(address newOwner) internal virtual {
        if (_guardInitializeOwner()) {
            /// @solidity memory-safe-assembly
            assembly {
                let ownerSlot := _OWNER_SLOT
                // Clean the upper 96 bits.
                newOwner := shr(96, shl(96, newOwner))
                // Emit the {OwnershipTransferred} event.
                log3(0, 0, _OWNERSHIP_TRANSFERRED_EVENT_SIGNATURE, sload(ownerSlot), newOwner)
                // Store the new value.
                sstore(ownerSlot, or(newOwner, shl(255, iszero(newOwner))))
            }
        } else {
            /// @solidity memory-safe-assembly
            assembly {
                let ownerSlot := _OWNER_SLOT
                // Clean the upper 96 bits.
                newOwner := shr(96, shl(96, newOwner))
                // Emit the {OwnershipTransferred} event.
                log3(0, 0, _OWNERSHIP_TRANSFERRED_EVENT_SIGNATURE, sload(ownerSlot), newOwner)
                // Store the new value.
                sstore(ownerSlot, newOwner)
            }
        }
    }

    /// @dev Throws if the sender is not the owner.
    function _checkOwner() internal view virtual {
        /// @solidity memory-safe-assembly
        assembly {
            // If the caller is not the stored owner, revert.
            if iszero(eq(caller(), sload(_OWNER_SLOT))) {
                mstore(0x00, 0x82b42900) // `Unauthorized()`.
                revert(0x1c, 0x04)
            }
        }
    }

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                  PUBLIC UPDATE FUNCTIONS                   */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev Allows the owner to transfer the ownership to `newOwner`.
    function transferOwnership(address newOwner) public payable virtual onlyOwner {
        _setOwner(newOwner);
    }

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                   PUBLIC READ FUNCTIONS                    */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev Returns the owner of the contract.
    function owner() public view virtual returns (address result) {
        /// @solidity memory-safe-assembly
        assembly {
            result := sload(_OWNER_SLOT)
        }
    }

    /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
    /*                         MODIFIERS                          */
    /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

    /// @dev Marks a function as only callable by the owner.
    modifier onlyOwner() virtual {
        _checkOwner();
        _;
    }
}

I think default inclusion of two-step ownership is useful to silence auditoors.

while that's def a thing, heh even OZ puts 2step into sep file. That could also be appr here.

while a bit off-topic: my suggestion would then be to separate concerns of Ownable and 2step, and import Ownable into 2step like OZ.
but otherwise, within 2Step itself, I think it would be useful to remove the 'cancel' and 'expiry' functions to free up some space. These patterns can be addons to customize handoff rules (or via gov). If a pending owner wants to cancel, they can transfer ownership back but this seems feels like an edge case unless I am missing something.

It's just 4 public functions. 🥹
Ownable.sol vs OwnableLite.sol


NIFI-5983: handling parse problems in recordReader implementations

A different take on solving NIFI-5983:
This approach catches the parse (RuntimeException) exceptions early at the recordReader implementations, and re-throwing them as MalformedRecordException, which is handled well (transfers to failure relationship instead of session rollback) in PutDatabaseRecord processor (instead of handling it only & directly in the PutDatabaseRecord processor itself, implemented https://github.com/apache/nifi/pull/3280)
only one of the pr (this or the other: https://github.com/apache/nifi/pull/3280) should be accepted the other thrown away.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks Matt, the changes are pushed now.
On Tue, Feb 5, 2019 at 3:21 PM Matthew Burgess<EMAIL_ADDRESS>wrote:

@mattyb149 commented on this pull request.
In
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/ITApacheCSVRecordReader.java
https://github.com/apache/nifi/pull/3282#discussion_r253881736:

@@ -27,22 +28,30 @@
import org.junit.Test;
import org.mockito.Mockito;

+import avro.shaded.com.google.common.base.Throwables;
This avro.shaded class is back :P
In
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/ITApacheCSVRecordReader.java
https://github.com/apache/nifi/pull/3282#discussion_r253882016:

   CSVFormat csvFormat = CSVFormat.DEFAULT.withFirstRecordAsHeader().withQuoteMode(QuoteMode.ALL).withTrim().withDelimiter(',');

   final int NUM_LINES = 25;

   StringBuilder sb = new StringBuilder("\"id\",\"name\",\"balance\"");

   for (int i = 0; i < NUM_LINES; i++) {

       sb.append(String.format("\"%s\",\"John Doe\",\"4750.89D\"\n", i));

   }

   // cause a parse problem

   sb.append(String.format("\"%s\"dieParser,\"John Doe\",\"4750.89D\"\n", NUM_LINES ));

   sb.append(String.format("\"%s\",\"John Doe\",\"4750.89D\"\n", NUM_LINES + 1));

   final RecordSchema schema = new SimpleRecordSchema(createStringFields(new String[] {"id", "name", "balance"}));

   try (final InputStream bais = new ByteArrayInputStream(sb.toString().getBytes());

        final CSVRecordReader reader = new CSVRecordReader(bais, Mockito.mock(ComponentLog.class), schema, csvFormat, true, false,

                RecordFieldType.DATE.getDefaultFormat(), RecordFieldType.TIME.getDefaultFormat(), RecordFieldType.TIMESTAMP.getDefaultFormat(), "UTF-8")) {

       @SuppressWarnings("unused")

Rather than this annotation, you can probably just replace the while with while
(reader.nextRecord() != null) ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/nifi/pull/3282#pullrequestreview-200096805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaM1vid5midhFYA_P721uscfkusEN3Eks5vKZNsgaJpZM4actZy
.

+1 LGTM, ran full unit and integration tests, and tried on a live NiFi instance with Avro and CSV data. I also tried with the JsonTreeReader and invalid JSON, they appear to throw a checked exception so the error was already handled correctly, no need to add these fixes to that reader ATM.  Thanks for the fix! Merging to master


Persistent logins

Hey, thanks for this. It's really cool.
Not sure if I'm missing it, but is there a way to have session cookies/logins persist between launches?

If the website supports cookies, as far as I am aware, it doessave the cookies unless the website does not support it.
Could you give more details into your problem?

I must have been on a different train of thought, because this is actually how it normally works with this particular web app (protonmail). It would be neat to have saved passwords, but I can open another issue for that.


will there be any issue when using babylon walk with babel/parse

i got confused with this statement in the readme Lightweight AST traversal tools for Babylon ASTs

The output of babel (formerly babylon) is not estree conformant, so that's why it specifies this.
But you can actually use babel parser with the estree plugin, which produces estree compliant AST, and can be traversed by acorn-walk for example.


ISSUES-381 fix rules for stderror in spark_shell

This is fix for this issue.
If you trying to run your scala snippet, you can't see syntax error or error in your SQL request in web UI
The problem is in spark_shell.py
where I found wrong comparison operator for 'traceback' variable.
If you have exception where 'traceback' variable is not equal None, but it is 'traceback': [] then this line if tb is None: is not work and you can see QueryError with empty message (because on line 273 you can see join with empty string). Simple fix from if tb is None: to if tb is None or not tb:

Thanks a lot!
And would you mind adding your name to the list of the legal contributors?
https://github.com/cloudera/hue/wiki/Ccla#online-form

I filled out the online form. I'm not sure is it enough?.. If not, please notify me how to do it correctly.


i18n(de): update guides/environment-variables.mdx

Description (required)

update guides/environment-variables.mdx

Related issues & labels (optional)

#9240
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

de/guides/environment-variables.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Before merging, check out development in #10233


[W5.11][W09-A3] Wee Jia Sheng Richardson

added in sort command

Good job!
Just a minor comment: Classes should have a doc comment summarising its purpose. (for your new Sort Command class)


Handle recent version of urdfdom >= 1.0.0

If you checked it, you can merge.

I checked with recent version of urdfdom >= 1.0.0. It might be necessary to test on an older version of urdfdom.

It's working fine with 0.4.1.


Upgrade all dependencies

Including:

React Navigation (major versions upgrade, some API changes)
Firebase libraries (major versions upgrade)
Other packages like graphql, subscription transport, vector icons (major versions upgrade)
Other minor/patch upgrades
All pods

Please test on Android

Tests pass for me locally but fail here 🤔

This was broken due to jest not being able to transform some of our dependency code.  I told it to ignore the react-navigation library and now the tests are passing. The reason the tests were failing here but not locally is that the tests here run on the pull request and there were changes from main to be rebased.


Version mismatch between d3 and plugins caused UE editor to crash

Current behavior
When there is a version mismatch between d3 and the RenderStream plugin, this causes the UE editor to crash when launched without an error message, making troubleshooting difficult.
Expected behavior
UE editor should not crash, and present an informative error message to the user.

This may have been fixed already in later versions, if we could please get the plugin and d3 version where this happens so we can reproduce or backport the fixes if the issue is still there in specific versions.

I had this issue on the Plugin version 1.25 and d3 version 79811, the Editor when to 9% and crashed out.
Jamie from Bild

The cause is an abort in the d3renderstream.dll due to the FreeLibrary call in RenderStreamLink::unloadExplicit. Logged internally as DSOF-17908

Fixed in r19.2


Application - Test Preferred Name change

There is a change in how name works. Employees can now set preferred name and that will be reflected everywhere employee name is pulled. When this change goes live we need to test our forms in DJ and ensure we handle all impacts of this change.
To do -

[ ] Ensure all "employee name" field in all forms uses the preferred name if that has been set by the employee
[ ] Discuss plan of action for 1.10 where we have a manually entered preferred name

[ ] Do we remove this field, keep it with a note that it doesnt update anything o no change

Update:
There have been no updates so far on the results. I have tested both APIs that we are using to pull employee information.
I replied to the email with the details and tagged Patrick to see if any configuration changes are needed.

Patrick: For clarity, changes to preferred name in ESS would be captured in the first_name column, there is no new fields being added in the API endpoints to expose the preferred names.
Which means we do not need to make any changes on Digital Journey. Test data are not loaded under the correct email, so we are unable to pull any information on the form to test it. This can only be tested via the API, which was done earlier on May 28.

[8:54 a.m.] Bhumin Patel (Guest)
email chain to watch
RE: Agile App Test with Preferred Name Change - Digital Journey


[infra] authentication error on Linux Android Scenarios presubmit check

AccessDeniedException: 403<EMAIL_ADDRESS>does not have storage.objects.create access to flutter_infra/flutter//diff_failures.zip.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8862117484725048624/+/steps/gsutil_upload__flutter__diff_failures.zip_/0/stdout
Which is blocking landing of https://github.com/flutter/engine/pull/22794.

Is this fixed?

This was reverted and the reland is https://flutter-review.googlesource.com/c/recipes/+/9100


QLinearMatMul

Feature Request
Describe the Feature Request
Implementation of ONNX Operator
Describe Preferred Solution
Implementation following the same Operator interface as defined in ONNX. See Contribution Guidelines
Additional Context

ONNX QLinearMatMul Operator

Can I take it ?

Hey, I have a question : in the example in the documentation of onnx (ONNX QLinearMatMul Operator)
the scale et zero point have different types :
a_scale = np.array([0.0066], dtype=np.float32)
a_zero_point = np.array([113], dtype=np.uint8)

the function dequantize_linear as currrently implemented doesn't support different types for scale et zero point :quantize_linear( x: @Tensor<Q>, x_scale: @Tensor<T>, x_zero_point: @Tensor<T>) (same issue for quantize_linear)
Do I make a version of QlinearMatMul limited that only support the cases supported by dequantize_linear and quantize_linear  or should I modify these two functions to support more general cases ?

Hey, I have a question : in the example in the documentation of onnx (ONNX QLinearMatMul Operator)
the scale et zero point have different types :
a_scale = np.array([0.0066], dtype=np.float32)
a_zero_point = np.array([113], dtype=np.uint8)

the function dequantize_linear as currrently implemented doesn't support different types for scale et zero point :quantize_linear( x: @Tensor<Q>, x_scale: @Tensor<T>, x_zero_point: @Tensor<T>) (same issue for quantize_linear)
Do I make a version of QlinearMatMul limited that only support the cases supported by dequantize_linear and quantize_linear or should I modify these two functions to support more general cases ?

If you use two types, you risk having to make conversions, and having compatibility errors in Cairo. I think it's better in our case to use just one type.


chip_detect_error on ESP32-P4

When using espflash 3.1.1 on the P4 dev board, it fails to detect the chip:
$ espflash board-info
[2024-09-12T15:32:39Z INFO ] Serial port: '/dev/ttyUSB0'
[2024-09-12T15:32:39Z INFO ] Connecting...
[2024-09-12T15:32:39Z INFO ] Using flash stub
Error: espflash::chip_detect_error

  × Unrecognized magic value: 0xffffffff
  help: Supported chips are: esp32, esp32c2, esp32c3, esp32c6, esp32h2, esp32p4, esp32s2, esp32s3
        If your chip is supported, try hard-resetting the device and try again

Hard resetting results in the same error.
Flashing a C build with EPS-IDF works fine over the same ttyUSB0. Not sure which details can be provided that would help here.

Addition: I got a different magic value, but only once?
Unrecognized magic value: 0x61632220

It seems the magic value detection is no longer working for the P4:

We have recently found out that the magic number autodetection method is not reliable for ESP32-P4, as the value at the arbitrary address (CHIP_DETECT_MAGIC_REG_ADDR) can change between runs. Due to this, we are now considering changing the address (for all of the previous targets as well).
Fortunately, this is shouldn't be a big deal for P4, as autodetection based on the magic number is just a fallback method. The get_security_info method is primarily used and reliable.

https://github.com/espressif/esptool/pull/1008#issuecomment-2347331479

Thanks for sharing your findings! We are currently not very focused on P4, since its not yet on mass production. The P4 version that I have is quite old, and I was able to flash it with the magic value that we currently have. We would of course accept and appreciate any PR updating this!

I'm still seeing this on the latest v3.2.0 release:
mabez at mGentoo ➜ mabez RUST_LOG="info" espflash board-info
[2024-11-09T15:02:49Z INFO ] Serial port: '/dev/ttyUSB0'
[2024-11-09T15:02:49Z INFO ] Connecting...
[2024-11-09T15:02:50Z INFO ] Using flash stub
Error: espflash::chip_detect_error

  × Unrecognized magic value: 0xffffffff
  help: Supported chips are: esp32, esp32c2, esp32c3, esp32c6, esp32h2, esp32p4, esp32s2, esp32s3
        If your chip is supported, try hard-resetting the device and try again

mabez at mGentoo ➜ mabez RUST_LOG="info" espflash board-info
[2024-11-09T15:02:52Z INFO ] Serial port: '/dev/ttyUSB0'
[2024-11-09T15:02:52Z INFO ] Connecting...
[2024-11-09T15:02:52Z INFO ] Using flash stub
Error: espflash::chip_detect_error

  × Unrecognized magic value: 0xffffffff
  help: Supported chips are: esp32, esp32c2, esp32c3, esp32c6, esp32h2, esp32p4, esp32s2, esp32s3
        If your chip is supported, try hard-resetting the device and try again

mabez at mGentoo ➜ mabez RUST_LOG="info" espflash board-info
[2024-11-09T15:02:53Z INFO ] Serial port: '/dev/ttyUSB0'
[2024-11-09T15:02:53Z INFO ] Connecting...
[2024-11-09T15:02:54Z INFO ] Using flash stub
Chip type:         esp32p4 (revision v0.0)
Crystal frequency: 40 MHz
Flash size:        4MB
Features:          High-Performance MCU
MAC address:       60:55:f9:f8:81:2d

Three runs in a row, two failed and one succeeded.
I think the full solution (and what they use in esptool) is to use get_security_info to get the image chip ID which is unique for each chip: https://github.com/espressif/esptool/blob/ab2e0bf8d69813333e43bb54203a9833150200e3/esptool/targets/esp32p4.py#L16
I only have a rev1 p4 board, so it's unclear to me if this is fixed in later revisions but if esptool are using this method as there primary chip detection tool, we probably should too?
Reopening.


Turn off autocorrect

Question
For bugs/questions:

OS: Windows
Python version import sys; print(sys.version): python 3.7.2
Pydantic version import pydantic; print(pydantic.VERSION): 0.20.1

I want to turn autocorrect type from pydantic. For example I want to get an error when I pass integer to string variable instead of fix it. How to achieve that behaviour? Thanks.

duplicate #284, #360.


Migrate package API to Choreo

 @anuruddhal cloned issue wso2-enterprise/ballerina-registry#2046 on 2023-04-21:

Description:

Migrate package API to Choreo private data plane

Describe your problem(s)
Describe your solution(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

 @xlight05 commented on 2023-05-09:

On hold until choreo supports Ballerina 2201.5.0


include local with "/" as prefix is not recognized

Minimal .gitlab-ci.yml illustrating the issue
structure:
 |- .gitlab-ci.yml
 |- test
     |- nested.yml

.gitlab-ci.yml
---
include:
  - local: '/test/nested.yml'

common/nested.yml
---
job:
  script:
    - echo "Heya"

Expected behavior
"/common/nested.yml" is found

Fallen in the same bug.
According to my tests:

Gitlab.com
gitlab-ci-local

'local: /test/nested.yml'
✔
❌

'local: ./test/nested.yml'
❌
✔

'local: test/nested.yml'
✔
✔


Dropdown button style regressed

Terminal dropdown:

This part is not meant to be there:

what theme is this?

Looks like a padding-right: 4px that should be a margin-left: 4px. Fixed it in the CSS dev tool but can't find the right file.

Happens in dark modern

I can see in insiders but not code - oss? I think this button is DropdownWithPrimaryActionViewItem

@Tyriar this doesn't seem to happen anymore. did you fix it?

Seems fixed, at least on macOS where I verified just now 👌


why i can not add prefab/Fog to my scenes

could you upload all project. i can not add prefab/Fog to my scenes
Tow warnings are  follow:

Unable to instantiate prefab. Prefab may be broken.
UnityEditorInternal.InternalEditorUtility:HierarchyWindowDrag(HierarchyProperty, Boolean, HierarchyDropMode)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Shader warning in 'TheFallenRealm/Fog/Blur': comma expression used where a vector constructor may have been intended at line 79 (on d3d11)

Compiling Vertex program
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_DESKTOP UNITY_COLORSPACE_GAMMA UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_LIGHTMAP_FULL_HDR

Hey sorry for (too) late response.
Are you by any chance using any SRP?
I've uploaded a unitypackage that contains scene setup for both Normal and HDRP Project.
To test HDRP just add the asset file from Settings folder in the package to Project Settings > Graphics > RenderPipeline slot.


Added soft deleting for Scheduled events

Implemented deleting concrete schedule event by id

No description provided.

Please, always provide description for your pull request in the initial comment.


Update getting-started-pwa.md

Thanks for the grammar check @badersur

You are welcome @kaycebasques


Webpack instructions still cause 'fake worker' to load

Configuration:

Web browser and its version: Chrome 52
Operating system and its version: OS X Yosemite
PDF.js version: 1.4.237
Is an extension: No

Steps to reproduce the problem:
My code is:
import pdflib from 'pdfjs-dist'
pdflib.PDFJS.workerSrc = './node_modules/pdfjs-dist/build/pdf.worker.entry.js'

exactly as described in https://github.com/mozilla/pdf.js/wiki/Setup-pdf.js-in-a-website#with-webpack,
yet I get a Warning: Setting up fake worker.' in my console when I actually load a document, which makes it seem like the instructions did not work.
Additionally the wording on the instructions seems wrong as "PDFJS.workerSrc shall be set to point to this file" (the current wording) means that it's automatically set, whereas "PDFJS.workerSrc should be set to point to this file" means you have to set it yourself.
The example code also isn't extremely helpful as it uses the relative paths into the repository (pdfjsLib.PDFJS.workerSrc = '../../build/webpack/pdf.worker.bundle.js';) that a person importing PDFJS would obviously not be able to do (not a very useful example).
I'm also confused as I searched through issues/PRs that are < 1 year old like https://github.com/mozilla/pdf.js/pull/6595 that do some automatic loading of the worker script, but that code seems to no longer exist in the repo, so both setting and not setting the workerSrc cause the fake worker to load for me... The fake worker knows where to find the worker script built by webpack (e.g. 1.bundle.js is the worker when bundle.js is the script), so I'm confused why a real worker couldn't use this logic as well.
I've tried pointing workerSrc to the 1.bundle.js file created and even using webpack's worker-loader to instantiate and replace PDFWorker (pdflib.PDFJS.PDFWorker = require('worker!pdfjs-dist/build/pdf.worker.entry.js')), but that didn't work either, so I'm completely lost as to how the worker is supposed to work with webpack

The fake worker knows where to find the worker script built by webpack (e.g. 1.bundle.js is the worker when bundle.js is the script), so I'm confused why a real worker couldn't use this logic as well.

Check if bundle.js includes worker -- it's wrong (from page loading performance and size) to have it there. Entire pdf.worker.js file shall be placed into separate bundle.

The example code also isn't extremely helpful as it uses the relative paths into the repository (pdfjsLib.PDFJS.workerSrc = '../../build/webpack/pdf.worker.bundle.js';) that a person importing PDFJS would obviously not be able to do (not a very useful example).

pdf.worker.bundle.js file you create that includes pdf.worker.js module (imported from pdfjs-dist)
The description of the issue is not clear. Can you provide complete example source code?

Check if bundle.js includes worker -- it's wrong (from page loading performance and size) to have it there. Entire pdf.worker.js file shall be placed into separate bundle.

Checked the bundled code and can confirm It does not include the worker. As I mentioned, the worker script is bundled as 1.bundle.js. Upon loading a PDF, a script tag for 1.bundle.js is inserted into my <head> tag (not sure if this is from PDFJS or webpack).

pdf.worker.bundle.js file you create as a bundle output that includes pdf.worker.js module (imported from pdfjs-dist)

Is there an example that uses the first, and arguably preferred, method in the Wiki of loading the worker script from node_modules? From the wiki section: "The worker shall be built into a separate bundle: take the file "./node_modules/pdfjs-dist/build/pdf.worker.entry.js"
Also could you elaborate on the auto-detection/loading of the worker in #6595  that seems to no longer be in the codebase? I'm building a library that uses pdf.js, so if someone had to import pdf.js code to make my library work, that would be a bit annoying (managing dependencies of dependencies).

The description of the issue is not clear. Can you provide complete example source code?

I didn't attach source code as there's really not much else helpful or relevant, but here's a < 100 LoC summary: http://pastebin.com/raw/PHs6bfby. The file argument is literally a file from an <input type='file' /> element.

@yurydelendik could you elaborate on the auto-detection/loading of the worker in #6595 that seems to no longer be in the codebase?

This functionality is not intended for bundlers/packagers.

I'm building a library that uses pdf.js, so if someone had to import pdf.js code to make my library work, that would be a bit annoying (managing dependencies of dependencies).

So far we did not find a bundler that properly manages web worker and we don't want give preferences to webpack or browserify -- we had problem with supporting both at the same time.
The solution is to managing dependencies of dependencies is not trivial. But keep in mind that efficient parsing and rendering of PDFs is not trivial task. If you abandon using web worker, and you are free to do that, the UI performance will suffer but it will be your trade-off.

I didn't attach source code as there's really not much else helpful or relevant

You can public small example of a library that demonstrate the intent of what you are trying to achieve. Provided snippets of the code is not useful since they are not: runnable and not what you are trying to do -- a library.

I am experiencing the same issue. See https://cdn.kidoju.com/support/viewer/index.html.
The code can be found at https://github.com/kidoju/Kidoju-Help.

This functionality is not intended for bundlers/packagers.

Didn't realize that 👍

So far we did not find a bundler that properly manages web worker and we don't want give preferences to webpack or browserify -- we had problem with supporting both at the same time.
The solution is to managing dependencies of dependencies is not trivial. But keep in mind that efficient parsing and rendering of PDFs is not trivial task. If you abandon using web worker, and you are free to do that, the UI performance will suffer and it will be your trade-off.

@yurydelendik I'd agree with you but I don't think that trade-off needs to be made. Webpack has worker-loader and Browserify has webworkerify -- wouldn't detecting the bundler system and using one or the other completely solve this problem?
Seems like it could be done here: https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L1132, using the direct path to the worker entry with var worker = require('worker!../pdf.worker.entry.js') in webpack or var worker = require('webworkerify')('../pdf.worker.entry.js') in browserify.
If you think I hit the mark with that, I'd be happy to write a PR for that.

You can publish small example of a library that demonstrate the intent of what you are trying to achieve. Provided snippets of the code is not useful since they are not: runnable and not what you are trying to do -- a library.

The snippet I attached is all of the code that would be in the library for now (pdf-to-dataURL). I could make a quick example that uses that snippet if @jlchereau's example isn't good enough either (it doesn't seem to require pdfjs-dist from NPM, so not sure about the accuracy of it)

Webpack has worker-loader and Browserify has webworkerify -- wouldn't detecting the bundler system and using one or the other completely solve this problem?

Yes, I tried that at #6785, later at #6791 and then reverted that. Having require('worker!... causes issue in browserify, and require('webworkerify')(...) in webpack.

If you think I hit the mark with that, I'd be happy to write a PR for that.

Yes, working PR will really good to have. So far pdfjs-dist somehow works with webpack, browserify along with system.js and node.js; and we will try to keep it this way. Thanks.
Also notice that if worker is not available for some reason: security or just legacy browser. I was planning to add overloaded constructor for PDFWorker that would accept an web worker is a parameter -- this might provide the alternative solution for some webpack/browserify usecases.

btw, webpack has entry-loader which can be used with workerSrc

Yes, I tried that at #6785, later at #6791 and then reverted that. Having require('worker!... causes issue in browserify, and require('webworkerify')(...) in webpack.

But wouldn't your __webpack_require__ check here
https://github.com/mozilla/pdf.js/pull/6785/commits/79c2f69c3288494c5ce2809182c896484bf4be5c#diff-5f93a8d6c23cf0a169c6ee7347477ce8R30  prevent browserify from parsing that statement? (not sure if the ensure part was causing problems)

Yes, working PR will really good to have. So far pdfjs-dist somehow works with webpack, browserify along with system.js and node.js; and we will try to keep it this way. Thanks.

I'll probably get to this later next week -- is there a test to run to check against various bundlers/platforms?

I was planning to add overloaded constructor for PDFWorker that would accept an web worker is a parameter -- this might provide the alternative solution for some webpack/browserify usecases.

I think this would be a fantastic alternative! Specifically, if it could accept a Worker class, then webpack folks could use something like: webworkerify-webpack and browserify folks just use the webworkerify and just pass the loader/Worker as an argument. So it would be var worker = new WorkerFromArgs('../pdf.worker.entry.js') in the overloaded case.
This would offload the configuration of worker loaders logic into user-land so potentially messy PRs that check for platform/bundler into pdf.js aren't necessary

yet I get a Warning: Setting up fake worker.' in my console when I actually load a document, which makes it seem like the instructions did not work.

That's awesome, but as stated above the issue is not addressable without complete example. Shall we close this one and wait for the PR?

@jlchereau gave one example https://github.com/mozilla/pdf.js/issues/7612#issuecomment-245973303 where you can similarly see Warning: Setting up fake worker in the console and I can give another if need be
This issue is still relevant as workerSrc should work in the current implementation, but doesn't.
In any case, the PR would resolve this issue so shouldn't this be left open for tracking until then?
I would also like to hear your feedback to my questions above before starting a PR (regarding why browserify complained when you tried checking  __webpack_require__, as I would do the same in my PR, and if there are any tests I should run to test all bundlers/platforms simultaneously)

@agilgur5
The snippet I attached is all of the code that would be in the library for now (pdf-to-dataURL). I could make a quick example that uses that snippet if @jlchereau's example isn't good enough (it doesn't seem to require pdfjs-dist from NPM, so not sure about the accuracy of it).

See https://github.com/kidoju/Kidoju-Help/blob/master/src/main.js and uncomment as you see fit:
require('../web/viewer.css');
require('../web/compatibility.js');
// require('pdfjs-dist/web/compatibility.js');
require('../web/l10n.js');
window.pdfjsDistBuildPdf = require('../build/pdf.js');
// window.pdfjsDistBuildPdf = require('pdfjs-dist/build/pdf.js');
// require('../web/debugger.js');
require('./viewer.js');

The reason I have been trying both is viewer.js and pdfjs-dist/web/pdf_viewer.js are not the same I have demmed more relevant to keep all files from the same source/version.

@yurydelendik it doesn't seem like you checked out @jlchereau's example yet. I also made pdf-to-dataURL as a tiny package that exhibits this bug.

I was planning to add overloaded constructor for PDFWorker that would accept an web worker is a parameter -- this might provide the alternative solution for some webpack/browserify usecases.

Are there any updates on this? As I previously mentioned, I feel that's a much better solution than the one I proposed (to which you hadn't answered the questions I asked so I couldn't really make a PR anyway) and is far more generic for future use cases and other bundlers.

I ran into the same issue with my webpack project, but I solved it differently.  Instead of relying on webpack's bundling or loaders, I made use of the CopyWebpackPlugin to copy the worker source into my build directory.
In my viewer:
import pdfjsLib from 'pdfjs-dist';

if (process.env.NODE_ENV !== 'production') {
   //in dev, get it from the node_modules directory
   //NOTE: don't use the "entry" file -- the script will fail and the web worker will not be used
   pdfjsLib.PDFJS.workerSrc = `${process.env.APP_ROOT}/node_modules/pdfjs-dist/build/pdf.worker.js`;
} else {
   //in prod, get it from the build directory
   pdfjsLib.PDFJS.workerSrc = `${process.env.APP_ROOT}/build/pdf.worker.js`;
}

In webpack.config.js:
const CopyWebpackPlugin = require('copy-webpack-plugin');

return {
   //... rest of config omitted
   plugins: [{
      new CopyWebpackPlugin([{
         from: 'node_modules/pdfjs-dist/build/pdf.worker.js',
         to: 'pdf.worker.js'
      }])
   }]
}

@agilgur5, I just ran into this issue and it was because I was using the CommonsChunkPlugin. In my case, the webworker was loading but ran into an error Uncaught ReferenceError: webpackJsonp is not defined  (because that code got pulled to a common chunk and wasn't available to the worker). This caused the worker to exit early and fallback to the fake implementation.
You can either not use the CommonsChuckPlugin or use the solution @ctowler suggested.
Hope this solves your problem.

Hey all,
I was struggling a lot to make pdf.js working with Webpack. The key thing is I didn't want the worker to be a separate file.
If anyone is facing problems like:

Warning: Setting up fake worker. message,
Webpack creating trash bundles with non-functional PDF.js worker,
Webpack including worker twice in the bundle,
you should definitely have a look.

Step by step

I included raw-loader in my package.json to be able to import files as plaintext.
"raw-loader": "latest",

I configured Webpack in a way so pdf.worker.js is loaded via raw-loader.
  module: {
    rules: [
      {
        test: /pdf\.worker(\.min)?\.js$/,
        use: 'raw-loader',
      },
      {
        test: /\.(js|jsx)$/,
        exclude: [/node_modules/, /pdf\.worker(\.min)?\.js$/],
        use: 'babel-loader',
      },
    ],
  },

Now comes the tricky part. The only way to pass a worker to PDF.js is via workerSrc setting. Unfortunaetly, doing stuff like
pdfjsLib.PDFJS.workerSrc = require('pdfjs-dist/build/pdf.worker');

won't work.
BUT! We can create URLs on the fly from Blobs, and we can create Blobs from strings on the fly!
So, the working solution for me was:
const pdfjsLib = require('pdfjs-dist');
const pdfjsWorker = require('pdfjs-dist/build/pdf.worker.min');

const pdfjsWorkerBlob = new Blob([pdfjsWorker]);
const pdfjsWorkerBlobURL = URL.createObjectURL(pdfjsWorkerBlob);

pdfjsLib.PDFJS.workerSrc = pdfjsWorkerBlobURL;

🎉 :D

Just one more thing. PDF.js has plenty of fallbacks in case something goes wrong with loading the worker:
require.ensure([], function () {
  var worker;
  worker = require('./pdf.worker.js');
  callback(worker.WorkerMessageHandler);
});

If you care about bundle size and used pdf.worker.min like I did, Webpack will get confused and include pdf.worker.js anyway because of this stuff. What's even worse, even the minified version of PDF.js calls for non-minified pdf.worker.js. So how can we deal with this crap?
We tell Webpack to replace one module with another, just like so:
new webpack.NormalModuleReplacementPlugin(
  /pdf\.worker(\.min)?\.js$/,
  path.join(__dirname, 'node_modules', 'pdfjs-dist', 'build', 'pdf.worker.min.js'),
),

which ensures that every file matching /pdf\.worker(\.min)?\.js$/ - more specifically, pdf.worker.js and pdf.worker.min.js will be replaced with minified version of it.

Phew. Hope this helps anyone!

@wojtekmaj we added pdfjs-dist/webpack for zero-configuration for webpack users. You can see its usage at https://github.com/yurydelendik/pdfjs-react

@yurydelendik Thanks, yes, I was aware of this. Although I didn't manage to get it working in one bundle, and that was a necessity for me, as I wanted to end up with one compiled file.
This is because I'm working on react-pdf and it has to be super easy for my users to install it.
here's no way I could tell them to figure pdf.worker.js on their own, let alone write instructions for webpack, browserify and whatnot.

it has to be super easy for my users to install it. package.json + import, boom, nothing else.

@wojtekmaj I don't really understand your requirements. I don't see how adding pdfjs-dist and using pdfjs-dist/webpack will be impossible to use in a react component project. And user will just include the former.

ending up with one compiled file was a necessity for me.

One compiled file is not what you want: a) for page startup, b) caching and transmission size, c) possible problems with worker -- but it's your choice.

@yurydelendik Eh, not really my choice. I just can't quite figure out how would I do this. I tried to follow the example you provided, and good, I ended up with two bundles - main and pdf.worker. I set workerSrc to './pdf.worker.bundle.js'. Now, this path shall be absolute. If I'm on http://example.com, PDF.js would request for http://example.com/pdf.worker.bundle.js. How can my project know what the final path is going to be on somebody else's project? How do I ensure they create a separate, specifically named bundle for a part of my node_module?
I think the only way to make it easy enough for people to even bother configuring it (I mostly read: "Just use disableWorker = true, that fixes the error") would be to allow passing worker param instead of workerSrc.
If I could do:
const pdfjsLib = require('pdfjs-dist');
pdfjsLib.PDFJS.worker = requie('pdfjs-dist/build/pdf.worker');

I would be so, so happy...

@yurydelendik Oh, sorry, I misread your previous post. I thought you are talking about /examples/webpack which is a completely different thing. It should definitely be updated to use pdfjs/webpack! Thank you!

@yurydelendik
Oh, sorry, I misread your previous post. I thought you are talking about /examples/webpack which is a completely different thing. It should definitely be updated to use pdfjs/webpack! Thank you!
One more thing... Using pdfjs-dist/webpack does not stop pdf.js itself from trying to require pdf.worker.js on its own. I end up with:

entry.bundle.js
abcdef1234567890.worker.bundle.js

When I define pdf.worker as one of the entries, it gets even worse, I end up with:

entry.bundle.js
abcdef1234567890.worker.bundle.js
pdf.worker.bundle.js

How do I fix this problem?

After running yarn build with my react-pdf example above if got following files:
...
File sizes after gzip:

  198.42 KB  build/7b14afe24b211632ecc8.worker.js
  197.76 KB  build/static/js/0.974e8de4.chunk.js
  130.14 KB  build/static/js/main.5a79c9e3.js
  4.19 KB    build/static/css/main.d852b162.css
...

That's normal: the app is 'build/static/js/main.5a79c9e3.js' stuff (pdf.js plus react), 'build/static/js/0.974e8de4.chunk.js' is pdf.worker.js fallback code is loaded when worker is disabled and 'build/7b14afe24b211632ecc8.worker.js' worker code. Am I missing something?
@wojtekmaj please prepare complete react component (example?) with user's test app and report in the separate issue with STR -- I think your particular problem is not related to this issue.

PDFJS.workerSrc = 'scripts.bundle.js';
PDFJS.getDocument(getPdfName).then((pdfFile:any)=>{
this.pdfFile = pdfFile;
this.renderPdfIntoPages(pdfFile, getPdfPages, this.pdfReady);
});
assign the value like this then its works...
Thanks...

While using @yurydelendik solution if anyone gets window not defined error please put
globalObject: 'true'

In the output segment of your webpack config.
There seems to be a bug in webpack, webpack messes up with window object when working with web workers. So the above hack solves that issue.

I may be doing something wrong here, so please correct oh smart people, but I took @wojtekmaj's train of thought, and got it working much more simply.
In webpack.config:
...
            {
                test: /pdf\.worker(\.min)?\.js$/,
                loader: 'file-loader'
            },

And then, in my code:
import PDFJS from 'pdfjs-dist';
import PDFJSWorker from 'pdfjs-dist/build/pdf.worker.min';

PDFJS.GlobalWorkerOptions.workerSrc = PDFJSWorker;
...

Configuration :

pdfjs-dist : 2.1.266
webpack : 4.35.0

Hey, I had some trouble using webpack and pdfjs (and it's worker).
What I think it happens (I don't know pdfjs enough to be sure of anything)
Due to webpack stuff, I had this error trying to load worker :

I couldn't find anything to fix it.
vendors_pdfjsWorker existed but wasn't in this path. In my case, I want the worker to be in the same place where pdf.js are.
At first I tried to change workerSrc, as wojtekmaj explained. But my workerSrc wasn't used by pdfjs to get the worker. Webpack parsing change pdfjs (l.9915) :
  if (typeof window === 'undefined') {
    isWorkerDisabled = true;

    if (typeof require.ensure === 'undefined') {
      require.ensure = require('node-ensure');
    }

    useRequireEnsure = true;
  } else if (typeof require !== 'undefined' && typeof require.ensure === 'function') {
    useRequireEnsure = true;
  }

INTO
  if (typeof window === 'undefined') {
    isWorkerDisabled = true;

    if (typeof require.ensure === 'undefined') {
      require.ensure = require('node-ensure');
    }

    useRequireEnsure = true;
  } else if (true) {
    useRequireEnsure = true;
  }

So, fakeWorkerFilesLoader is set (l.9932) :
fakeWorkerFilesLoader = useRequireEnsure ? function () {
Then, my workerSrc isn't get cause fakeWorkerFilesLoader is defined :
    var loader = fakeWorkerFilesLoader || function () {
      return (0, _dom_utils.loadScript)(_getWorkerSrc()).then(function () {
        return window.pdfjsWorker.WorkerMessageHandler;
      });
    };

How I solved it
In my webpack configuration I added :
    module: {
        noParse: (filename) => {
            return /\\node_modules\\pdfjs-dist\\build\\pdf.js/.test(filename);
        },
        rules: [
        .......................
        ]
    },

And then I had this error :

It tells me my script "ecm_viewer.worker.js" doesn't exist.
I added an entry in my webpack config :
entry: {
    'ecm_viewer': getFileList(),
    'ecm_viewer.worker': './node_modules/pdfjs-dist/build/pdf.worker.entry',
}

And it works perfectly, even if I remove the noParse function. I wasn't able to debug the real error until I add this noParse webpack option.
I don't know if I'm in the right place to write this ; I can move my post on stackoverflow or somewhere else. It may help someone one day.

I ran into the same issue with my webpack project, but I solved it differently. Instead of relying on webpack's bundling or loaders, I made use of the CopyWebpackPlugin to copy the worker source into my build directory.
In my viewer:
import pdfjsLib from 'pdfjs-dist';

if (process.env.NODE_ENV !== 'production') {
   //in dev, get it from the node_modules directory
   //NOTE: don't use the "entry" file -- the script will fail and the web worker will not be used
   pdfjsLib.PDFJS.workerSrc = `${process.env.APP_ROOT}/node_modules/pdfjs-dist/build/pdf.worker.js`;
} else {
   //in prod, get it from the build directory
   pdfjsLib.PDFJS.workerSrc = `${process.env.APP_ROOT}/build/pdf.worker.js`;
}

In webpack.config.js:
const CopyWebpackPlugin = require('copy-webpack-plugin');

return {
   //... rest of config omitted
   plugins: [{
      new CopyWebpackPlugin([{
         from: 'node_modules/pdfjs-dist/build/pdf.worker.js',
         to: 'pdf.worker.js'
      }])
   }]
}

This fixed an issue my team has been hunting down for WEEKS. Thank you @ctowler :D <3

While using @yurydelendik solution if anyone gets window not defined error please put
globalObject: 'true'

In the output segment of your webpack config.
There seems to be a bug in webpack, webpack messes up with window object when working with web workers. So the above hack solves that issue.

@vivektiwary I am running into the same issue. It keeps saying ReferenceError: Can't find variable: window
I did put that globalObject:'true' setting in the Webpack.config file but the app now won't load at all. Are you sure it worked?

While using @yurydelendik solution if anyone gets window not defined error please put
globalObject: 'true'

In the output segment of your webpack config.
There seems to be a bug in webpack, webpack messes up with window object when working with web workers. So the above hack solves that issue.

@vivektiwary I am running into the same issue. It keeps saying ReferenceError: Can't find variable: window
I did put that globalObject:'true' setting in the Webpack.config file but the app now won't load at all. Are you sure it worked?

Yes @taihuuho, did you put that in output obj in the config?
btw what is the error which you are getting?

@vivektiwary I am getting this error ReferenceError: Can't find variable: window when using that pdfjs-dist/webpack

Using file-loader somehow mixed up the rest of my app, because other librairies need it. So the other way that I found is to get the pdf.worker.js file from a cdn:
import pdfjs from 'pdfjs-dist'; pdfjs.GlobalWorkerOptions.workerSrc = //cdnjs.cloudflare.com/ajax/libs/pdf.js/${pdfjs.version}/pdf.worker.js;


ipsec: needs a service controller for MVC service control icons

@fichtner this https://github.com/opnsense/core/commit/ae60b1266d12b67de07381acb94c4970a073e2b0  ?

Yep, thanks a lot ❤


raft: make the repeated log message under bad path debug level

We are spamming logging message with Infof when a member is under a bad path and doing catching up. We should change Infof to Debugf.
/cc @bdarnell

LGTM


fix memory leak of android view

Description
fix memory leak of android view
Related Issues
#50104
Tests

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@Stonekity Thanks for your contribution! As per our policy we require that all changes have a test to ensure that we never regress this behavior and re-introduce the bug. Can you please add a test?

@Stonekity Thanks for your contribution! As per our policy we require that all changes have a test to ensure that we never regress this behavior and re-introduce the bug. Can you please add a test?

@goderbauer, Thanks for your reply, Do you have any relevant documents to explain how to test this problem? At present, I use demo to verify this problem. There is a GIF picture on it, which shows the test results of devtools. The results show that the problem has been solved

@Stonekity : https://github.com/flutter/flutter/pull/46184 is an example memory test that you may follow. Please let me know if you have any questions. I'm very happy to help.

@Stonekity : #46184 is an example memory test that you may follow. Please let me know if you have any questions. I'm very happy to help.

Thanks buddy, I'll take a look at it.

@jason-simmons I remember you may have fixed a similar issue recently

@Stonekity Since this people are waiting for this fix in issue https://github.com/flutter/flutter/issues/56442 I've added a test for you =)


YETUS-1077. Remove jython completely

JIRA: https://issues.apache.org/jira/browse/YETUS-1077

Merged. Thank you @busbey


fixed a few clippy warnings

Just small readability improvements, should be easy to review.

Thanks!

You're welcome.


x/tools/crypto/ssh: handshake: deadlock if other side drops/resets connection during rekeying

The handshakeTransport.readLoop can exit with t.cond locked and any handshakeTransport.writePacket calls will block indefinitely at t.cond.Wait().
Additionally, there's a possible deadlock in handshakeTransport.writePacket that leaves t.mu locked:
if t.writeError != nil {
    // t.mu.Unlock()  // <- missing
    return t.writeError
}

CC @agl<EMAIL_ADDRESS>

@ianlancetaylor - I am 'hanwen' on github, but for some reason the @ mention doesn't work. Do I have to be added to some list?

@hanwen I can't claim to understand github, but I sent you an invitation that may do the trick.

Sorry to bug you but I should've initially created two issues. The deadlock with handshake.readLoop exiting due to an error during rekey attempt and handshake.writePacket being blocked on t.cond is still imminent. Do I need to create another issue for this?

can you make a separate issue?


Bring back Ghost Blocks to 1.21

In recent versions you aren't able to create ghost blocks so its quite annoying if you are doing dungeons on Hypixel Skyblock.
However in 1.8.9 (i think even up to 1.18.2) you could still be able to do that.
I don't know if i am clear so here is a video of 2 dudes creating ghost blocks
1st dude https://www.youtube.com/watch?v=6JDMZaeiDvk
2nd dude, shorter video https://www.youtube.com/watch?v=znUbUFsOgIM
Its probably going to be annoying for other players so its best to set this off by default

There is no safe way to unfix this vanilla bug without a high risk of the player getting banned. It's also technically bug abusing in same vein as block glitching so it wouldn't even be a false ban. Sorry :(
(And yeah, you did use this correctly)

ripp
and alr ty

You can also see #10 for a more detailed reply :)


Fragment definition nodes from other files are not included

Before reporting a bug, please test the beta branch! (✅)
Bug description
When placing GraphQL fragments in a separate file, they are not included in the generated code. This limits reusability of fragments to only a single file. Note: I am not sure if splitting fragments and queries into multiple files is allowed in the GraphQL spec but all web frontend libraries I have used so far supported it.
Specs
Artemis version: 7.1.1-beta.1

build.yaml:
targets:
  $default:
    builders:
      artemis:
        options:
          schema_mapping:
            - schema: lib/schema.graphql
              queries_glob: lib/**/*.graphql
              output: lib/graphql/api.dart
          scalar_mapping:
            - graphql_type: Uuid
              dart_type: String
            - graphql_type: DateTime
              dart_type: DateTime
            - graphql_type: Long
              dart_type: int

Artemis output:
# Please paste the output of
[ +150 ms] executing: [C:\development\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +159 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] d79295af24c3ed621c33713ecda14ad196fd9c31
[   +1 ms] executing: [C:\development\flutter/] git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[ +108 ms] Exit code 0 from: git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[        ] 2.2.2
[   +9 ms] executing: [C:\development\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +44 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [C:\development\flutter/] git ls-remote --get-url origin
[  +85 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +418 ms] executing: [C:\development\flutter/] git rev-parse --abbrev-ref HEAD
[ +150 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[ +163 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +8 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +129 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[ +112 ms] Using C:\development\flutter\.pub-cache for the pub cache.
[   +1 ms] executing: C:\development\flutter\bin\cache\dart-sdk\bin\pub run build_runner build --verbose
[INFO] Entrypoint:Generating build script...
[INFO] Entrypoint:Generating build script completed, took 1.1s

[INFO] BuildDefinition:Initializing inputs
[INFO] BuildDefinition:Reading cached asset graph...
[INFO] BuildDefinition:Reading cached asset graph completed, took 348ms

[INFO] BuildDefinition:Checking for updates since last build...
[INFO] BuildDefinition:Checking for updates since last build completed, took 4.5s

[INFO] Build:Running build...
[INFO] Heartbeat:1.4s elapsed, 1/2 actions completed.
[INFO] Heartbeat:2.8s elapsed, 1/2 actions completed.
[INFO] Heartbeat:4.1s elapsed, 1/2 actions completed.
[INFO] Heartbeat:5.3s elapsed, 1/2 actions completed.
[INFO] Heartbeat:6.3s elapsed, 1/2 actions completed.
[INFO] Heartbeat:7.4s elapsed, 1/2 actions completed.
[INFO] Heartbeat:8.7s elapsed, 1/2 actions completed.
[INFO] Heartbeat:9.8s elapsed, 1/2 actions completed.
[INFO] Heartbeat:10.9s elapsed, 1/2 actions completed.
[INFO] Heartbeat:12.2s elapsed, 1/2 actions completed.
[INFO] Heartbeat:13.5s elapsed, 1/2 actions completed.
[INFO] Heartbeat:14.5s elapsed, 1/2 actions completed.
[INFO] Heartbeat:15.6s elapsed, 1/2 actions completed.
[INFO] Heartbeat:45.9s elapsed, 1/2 actions completed.
[WARNING] Heartbeat:
No actions completed for 44.6s, waiting on:
  - json_serializable:json_serializable on lib/routes/map/map/components/map_filter.dart

[FINE] json_serializable:json_serializable on lib/routes/map/map/components/map_filter.dart:Running JsonSerializableGenerator - 1 of 2
[FINE] json_serializable:json_serializable on lib/routes/map/map/components/map_filter.dart:Running JsonLiteralGenerator - 2 of 2
[INFO] Heartbeat:47.6s elapsed, 2/18 actions completed.
[INFO] Heartbeat:48.7s elapsed, 5/20 actions completed.
[INFO] Heartbeat:50.6s elapsed, 12/28 actions completed.
[INFO] Heartbeat:51.7s elapsed, 16/32 actions completed.
[INFO] Heartbeat:52.8s elapsed, 23/38 actions completed.
[INFO] Heartbeat:53.9s elapsed, 29/45 actions completed.
[INFO] Heartbeat:54.9s elapsed, 41/45 actions completed.
[INFO] Build:Running build completed, took 55.2s

[INFO] Build:Caching finalized dependency graph...
[INFO] Build:Caching finalized dependency graph completed, took 303ms

[INFO] Build:Succeeded after 55.5s with 0 outputs (45 actions)

[+68929 ms] "flutter pub" took 69.228ms.
[ +102 ms] ensureAnalyticsSent: 90ms
[   +4 ms] Running shutdown hooks
[   +1 ms] Shutdown hooks complete
[   +2 ms] exiting with code 0

GraphQL schema:
schema {
    query: Query
    mutation: Mutation
}

type Example {
    id: Uuid!
    name: String!
}

type Query {
    example: Example!
}

type Mutation {
    login: Boolean!
}

scalar Uuid

GraphQL query:
# a.graphql
query ExampleQuery {
    example {
        ...ExampleFragment
    }
}

# b.graphql

fragment ExampleFragment on Example {
    id
    name
}

# Artemis errors on graphql files without mutation or query; this is neither used, nor functional
mutation Login {
    login
}

@geisterfurz007 there is fragments_glob for that purpose
https://github.com/comigor/artemis/blob/beta/CHANGELOG.md#711-beta1
And look into readme configuration section
https://github.com/comigor/artemis/tree/beta#configuration

That requires me to place all fragments that I want to share between query files into one file however, doesn't it (at least that's my understanding of "file", eventhough the config field is called glob)? I have been fiddling around with another codegen package which supports sharing fragments between graphql files out of the box without any configuration required so I am quite surprised to find out this needs configuring in artemis.

This is how it works for now.
Maybe some day we will improve the behavior

Certainly understandable! Thanks for your fast responses :)


Fix ARM64 build with Visual C++.

Correct header is arm64_neon.h, not arm_neon.h
functable.c was missing disabling of NEON check, Visual C++ does not have getauxval()

Why does ARM_NOCHECK_NEON exist?

@nmoinvaz Just like we don't check for SSE2 on x86_64, we don't need to check for NEON on ARM64 because it's always available when compiling with Visual C++, it's mandatory requirement.

vcvarsamd64_arm64.bat and nmake -f win32\Makefile.a64

Needs rebase

Looks like it has been rebased.

@nmoinvaz Yeah... I rebased but Codecov was giving weird errors so I waited if it would fix itself before making a new comment...


chore: update adopters readme with new company

Description
This PR includes a tiny change just to include Agentero in the list of adopters.

Oh nice thank you 👍


Continued issues with plugin with custom URL

So issue #7 has been closed, and 4.0.3 has been released, but I'm still having issues using a custom URL in my plugin.
To even get the field to show up I had to set hasTeamID to true, which results in the URL field being labeled as Shout team (Shout being the plugin). However, even then, setting a URL and clicking the Add button does absolutely nothing at all.
My PR is #16, the only thing different to that in my local test was setting hasTeamID to true.
Help appreciated.

I'll take a look at this in the next couple of days and will update you asap.

@Decipher are you already using Franz 4.0.4?

I am on 4.0.4, and it's definitely an improvement, however one part of the reported issue above is still an issue:
To get the URL to show up I have to set hasTeamID, which is strange as customURL and hostedOnly are already set and should be the only required criteria. There technically isn't a TeamID, only a customURL.

I'm also having this issue. I'm trying to develop a plugin for Quassel-Webserver (https://github.com/magne4000/quassel-webserver). The only way I can get it to work at the moment is by hardcoding the URL to where I host it, then setting customURL to false.


value converter naming convention incompatible with parser

If you call aurelia.withResources(DateFormatValueConverter), the ValueConverter convention kicks in and registers the converter with the name date-format.
The hyphenated name is incompatible with the parser.  This kind of error will occur:
Parser Error: Unexpected token : at column 30 in [repo.updated_at | date-format:'MMMM Do YYYY, h:mm:ss a' ]

If I rename the converter to "DateformatValueConverter" and use "dateformat" instead of "date-format" in the binding expression everything works.
Not sure if the convention or the parser should change.  Changing the convention to use camel-casing seems like it would be the most straight-forward code change.

per @EisenbergEffect-  we're going to change the convention to use underscores instead of hyphens

discussed further with @AshleyGrant  + @EisenbergEffect  - going with camelCase convention


Graph API to list data connectors Sentinel

Because the data connectors in Sentinel change from time to time, it would be great to have an graph api to list all the api's and use them in Bicep or ARM. For example the defender connector has still the mdatp name which can cause a lot confusion. If I would able to query a list of the data connectors using an api that would be really help.

Hi @guidovbrakel,
Hope @jing-microsoft answered to your question and closing this issue as addressed. Please feel free to reopen this issue if you need any further information on this.
Thanks


Fix flaky CI

Import fix to setup-beam once it's approved and tagged.

aa2a37a was also required.


Allow multiple q connections from same file

One use case I have is within one q file I need to run different lines (or blocks) of code on different q processes, some which cannot be connected to each other at the q level (eg development and production environments). I thought it may be useful to allow one line or block of code to point to one q process, and another piece code to point to another q process. For example:
Workflow:

Create new q file
Connect to a q process (qserver1)
Enter some q code in the file (qcode1) and run it on qserver1
Enter some more q code in the same file (qcode2), and while the cursor is in the line (or with selected text for a block) open a connection to another q process (qserver2) and run
Now qcode1 would be associated with qserver1 and qcode2 associated with qserver2. Further q code would be associated with qserver2 until I make a new connection to another q process
qcode1 could be switched to another q process by selecting it (or positioning the cursor in the line) and connecting to another q process
As the user moved the cursor between qcode1 and qcode2 etc the status bar would update to reflect the active q server

Let me know if above is useful or anything is not clear. Happy to provide more details on the use case.

Currently it is possible to connect to several processes, to switch between them you need to click the grin name below. I guess it is possible to add a function that can be associated with a hot key to switch between connections. To remember a server for each line seems an overkill.


UART : uart_driver_delete does not cares on deleting FreeRTOS Queue.  (IDFGH-8527)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
esp_err_t uart_driver_delete(uart_port_t uart_num) does not cares on deleting FreeRTOS Queue.
Neither in code uart.c nor in in documentation.

Is this what you're looking for?


Rename RequestEventsJsonStream  to HystrixRequestEventsJsonStream

NetflixOSS » Hystrix » Hystrix-pull-requests #328 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » Hystrix » Hystrix-pull-requests #329 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » Hystrix » Hystrix-pull-requests #330 SUCCESS
This pull request looks good


Update contracts documentation

The contracts were migrated to Dojo V1 but the corresponding documentation was not updated accordingly.

Update the necessary documentation in the contracts that was during migration to Dojo V1

hey sir i would love to work on this issue
i'm a blockchain dev and i would love to handle this issue
assign me and i'll get to work

Could I take over this issue?

I am new to open source.
Identify all the code annotations, comments, and README files referring to the previous version and update these to have the correct information for Dojo V1, which reflects what's in effect regarding the updated API and architectural changes. Confirm that the documentation is consistent with the most up-to-date codebase.

I would really love to work on this issue. I’ll update the necessary documentation in the contracts to reflect the migration to Dojo V1. This will ensure that the documentation aligns with the latest changes and provides accurate information for developers. I can complete this task within 24 hours.

I would like to work on this issue

I'd like to take this issue.

I am happy to provide the necessary documentations to support the Dojo V1 migration for all the contracts. Let's do this!

I'd be happy to do this.

@ikezuby2012 what's the update on this?

I would like to take this task. Am a web 2 frontend developer, a technical writer, a solidity smart contract developer/auditor and a cairo smart contract developer. Am a graduate of Starknet Cairo Bootcamp. I have successfully done tasks assigned to me in OnlyDust.
If assigned this i would complete it within 1 day.
Here are some articles i have written<EMAIL_ADDRESS>


Not creating conda env properly

When I start a new hermione project, it is not creating a conda env properly. Tested on Windows and Ubuntu 20.04

The problem was spaces in my username which are not compatible with conda environments. We detached hermione from conda and implemented venv.
Closed by release v0.3.1


Sweep BGD cards with all three tests

Establish the failing rate with both FW for all individual cards in BGD:
sweep 14 total n300 cards across t3k systems + 1x n300 system with all three tests:

FW <IP_ADDRESS>; with stagger, 3x 100k iterations
FW <IP_ADDRESS>; without stagger, 3x 100k iterations
classify hangs - pcie live or no?

Compare failing rate with cards from SJC machines and determine if more need to be allocated to BGD
Milos

N150 results:
https://docs.google.com/spreadsheets/d/10uWtBEkLLEM-h5TuuGQ6HW8AjhXwSjFV-cK3iVFYYIU/edit?gid=1717040381#gid=1717040381
with pcc checks:
https://docs.google.com/spreadsheets/d/10uWtBEkLLEM-h5TuuGQ6HW8AjhXwSjFV-cK3iVFYYIU/edit?gid=1376418009#gid=1376418009

On hold for N300 until boards could be used again.

This has been done multiple times with results posted in various tabs in this spreadsheet.
Latest official FW release baseline (<IP_ADDRESS>) is here:
https://docs.google.com/spreadsheets/d/10uWtBEkLLEM-h5TuuGQ6HW8AjhXwSjFV-cK3iVFYYIU/edit?pli=1&gid=1118664107#gid=1118664107
Latest RC FW release (<IP_ADDRESS>):
N300: https://docs.google.com/spreadsheets/d/10uWtBEkLLEM-h5TuuGQ6HW8AjhXwSjFV-cK3iVFYYIU/edit?pli=1&gid=2094403948#gid=2094403948
N150: https://docs.google.com/spreadsheets/d/10uWtBEkLLEM-h5TuuGQ6HW8AjhXwSjFV-cK3iVFYYIU/edit?pli=1&gid=2145444062#gid=2145444062


[DOC] Discuss internal GPU support rather than referring to Blazing

Report incorrect documentation
Location of incorrect documentation
The Quickstart section of the README.
Describe the problems or issues found in the documentation
This section refers users wanting to use GPUs for queries to BlazingSQL.
Steps taken to verify documentation is incorrect
N/A
Suggested fix for documentation
This section should no longer refer to BlazingSQL and should instead talk about GPU support in Dask-SQL. I would make the change myself, but I'm not familiar enough with the project at this stage to know exactly what to say here.

@ayushdg would you be up for fixing the README ?

Yeah, happy to make the change.


dr: spec.distribution.modules.dr.velero.retentionTime has no effect

The on-premises and kfddistribution schemas have a spec.distribution.modules.dr.velero.retentionTime property, but I could not find any reference to its value being used.
The property was added in this commit: https://github.com/sighupio/fury-distribution/commit/256cfec8c070544b7e45cbf441258a666223b436#diff-2fd7b2dd73284fe7fe4036c4938edcb3e53198d6a9d79bc68d3c23cc54ebe492R1313 of the following PR:

https://github.com/sighupio/fury-distribution/pull/151

I'm guessing that the idea was to configure MinIO lifecycle policy but that piece is missing.

After some testing I think it's better to configure the Velero schedule TTL (spec.template.ttl): https://velero.io/docs/v1.14/api-types/schedule/. It's universal and not related to Velero backend. WDYT?

    # The amount of time before backups created on this schedule are eligible for garbage collection. If not specified,
    # a default value of 30 days will be used.

Nice. One doubt though, is the garbage collector enabled by default or should we do something to enable it?

I think it's always enabled

For posteriry, I confirm that it is enabled by default and runs every hour (can be changed passing the flag --garbage-collection-frequency to velero's command)

The effects of expiration are not applied immediately, they are applied when the gc-controller runs its reconciliation loop every hour by default. If needed, you can adjust the frequency of the reconciliation loop using the --garbage-collection-frequency  flag.

Source: https://velero.io/docs/v1.11/how-velero-works/#set-a-backup-to-expire


Design Meeting Notes, 2/12/2021

ECMAScript Module Blocks Proposal
https://github.com/tc39/proposal-js-module-blocks
@RyanCavanaugh's notes

For web workers projects you have an entry point that is a separate file
Typically there is tight coupling between the invoker and the worker
Proposal: Instead of a filename, you can have a "module block"
This block is not lexically scoped (from a value perspective)

So what does TS do with scoping here?

Web workers are already a pain in TS because you need two (or more likely three, for shared types) "projects"
Can we implement this reasonably?
Q: Why do you need two projects?

A: WebWorker is on webworker context, "main" is on DOM. These have conflicting globals

The crux is what "script" (nonmodule) files contribute to each area's globals

Today, all script files constitute your global environment
What if you could configure this on a per-area basis?
https://github.com/microsoft/TypeScript/pull/4913
https://gist.github.com/RyanCavanaugh/702ebd1ca2fc060e58e634b4e30c1c1c
Challenge is making this not too complex

Technically these module blocks can participate in multiple contexts

Maybe we need a concept of a "type" of the global scope, that could be even a union
Is that a real use case?

Downleveling - technically possible in Node?
We need to establish some boundaries on what you can and cannot use this for, e.g. multiple envs vs just single-env configurability
Questions

Could we tool this?
Do we support this proposal broadly?
Mixed opinions. Analogues in other languages are... not great
Some people like the tooling side effects

(joke about "side effects tho")

The scoping is confusing
But the scenario is compelling
Is the configurability desirable in other contexts?

Is this a blocking concern?

🤷♂
Concerns about complexity vs. value calculation
The configurability here is potentially very complex

(Sidebar: Discussion of implementation of program and symbol table incrementality)

My notes from when I forgot Ryan was also taking notes:

One idea is multiple global scopes, merged in different ways.
Ideally, each of these modules would be able to tell you when you're going to run it in an incompatible context.

Need to represent modules as functions from global scope to themselves.

Yes... that's why this proposal feels strange to some on the team. A new type of deferred code block.
That seems potentially fine.

This is very similar to the idea of "strict global environments" that Ryan was playing with a while back.

Problem then and now: how are two utterances of the same type from different global scopes compatible?

From a compilation perspective, there needs to be some place where you specify what exactly you wanted.

Likely we won't do the enforcement of "only allow this module to run in this context". You have to know what context you're going to run the module in, use it responsibly.

Could support module {} blocks, but not separate checking contexts.

// @ts-nocheck at top of module {} 😅
But the proposal champions seem interested in the "can we tool this correctly in TypeScript" case.

Backing up - what is the general feedback about the proposal itself?

Not a fan of new scoping rules
Reminded by blocks, procs confusion from Ruby?
"It's kinda like AppDomains"

"Yeah I didn't like AppDomains either"

Seems like this solves real problems though - "split your project into multiple" seems like a bad solution.

Want to communicate that module blocks will introduce a fair bit of complexity in how users will think about both their global and lexical environments - same applies to tooling authors. Unclear if it's really a net benefit in mental model.

Web workers are really not a simple scenario or API - a novice user who reaches for it might not realize it's overkill. A user who really understands might be building a full project anyway.

We are still interested in supporting multiple global environments.

Emit Change For Imports
https://github.com/microsoft/TypeScript/issues/35420
https://github.com/microsoft/TypeScript/pull/35877

Polyfill for promise.allsettled package.

Does something different depending on the this context.

If you write import allSettled from "promise.allsettled"

we transform references to that to promiseallsettled.default(...)
Babel transforms it to (0, promiseallsettled).default(...)

Point of (0, obj).method(...) is to avoid binding this incorrectly.
Editor's note: this is so annoying.
This is also an issue with namespaces.
Editor's note: 🙄
Perf impact?

Adds a very small amount of time to emit.
Non-zero but negligible
Only hits CommonJS, namespace code.

Pack the PR, get some partner teams to try it out.

Should it be (0, promiseallsettled.default)(...) instead of (0, promiseallsettled).default(...)?

Yeah, thanks for catching!

tc39/proposal-js-module-blocks
...
Concerns about complexity vs. value calculation

I’m happy to chat with y’all about any and all questions and concerns about the value. I have been trying to scope out where workers are useful for a while now.

Regarding multiple scopes/projects, this is also an issue when you have multiple testing frameworks that declare the same globals, e.g. either of jest, mocha, and cypress together. Workarounds to this are possible, but painful.


Webforms resize images are not uploading on s3 bucket

I am uploading review images through webform extension and web forms are uploading images by resizing. I can not upload resize images on the s3 bucket. Can you please suggest me for this.

Hey @arif-qureshi
What is the name of the extension?
Regards
Thai


Import CSV - Presets for Google contacts and Outlook

Extension of #92
The command should be able to take in a preset to import Google contacts and outlook contacts exported csv.
Sub tasks:

Need to modify to allow for potentially empty fields @sharpstorm will need advise if i should do this

Name doesn't need to allow empty but have to modify phone/email/address for sure

Google Contacts:

Due to "dynamic" nature of the fields that are generated, need to check for which column holds details such as Phone number/email, etc.

Outlook Contacts:

Fields are in default places, so this should be pretty simple to implement, but first name and last name field content need to be combined in order to put into the "Name" column.

Potential upgrade:

Support for contact vcard importing (used by Apple devices)

I think having empty fields can be explored, but since this is an application for tracking contact information, either phone or email (or both) must be present.

ok i agree with the idea of either phone or email also. I think a potential for placeholder content for if anything is empty can be text in a more darker font such that it somewhat blends into the background. I did a quick mockup, something like this

Text colour used in this mockup (for ref in case to implement): 888b8c
I choose a colour like this such that the text would be visible enough despite the 3 different potential colours of the background

Does it make sense to further add on options in the importcsv command? Would it be kind of confusing to use?
current format: importcsv f/FILEPATH [n/COLUMNNUM] [p/COLUMN_PERSON] [e/COLUMN_EMAIL] [a/COLUMN_ADDRESS] [t/COLUMN_TAGS]
proposed format: importcsv f/FILEPATH [format/FORMATOPTION] [n/COLUMNNUM] [p/COLUMN_PERSON] [e/COLUMN_EMAIL] [a/COLUMN_ADDRESS] [t/COLUMN_TAGS]
FORMATOPTION = 1 - default
FORMATOPTION = 2 - google
FORMATOPTION = 3 - outlook
another potential option is to do a separate command
importformattedcsv f/FILEPATH format/FORMATOPTION
this would then handle the importing of google/outlook formatted csvs naturally
cc: @sharpstorm

ok i agree with the idea of either phone or email also. I think a potential for placeholder content for if anything is empty can be text in a more darker font such that it somewhat blends into the background. I did a quick mockup, something like this

In terms of the mockup, I my opinion is that phone and email should be adjacent (i.e. move address down), and that address can be empty (no need for placeholder here since its the last item).

Does it make sense to further add on options in the importcsv command? Would it be kind of confusing to use?
current format: importcsv f/FILEPATH [n/COLUMNNUM] [p/COLUMN_PERSON] [e/COLUMN_EMAIL] [a/COLUMN_ADDRESS] [t/COLUMN_TAGS]
proposed format: importcsv f/FILEPATH [format/FORMATOPTION] [n/COLUMNNUM] [p/COLUMN_PERSON] [e/COLUMN_EMAIL] [a/COLUMN_ADDRESS] [t/COLUMN_TAGS]

I think keeping it as a combined command is acceptable, but you should validate that you either take a predefined format, or custom columns.

this going to likely take a backseat, export more important

closing since I think we won't do this as an explicit feature anymore, and what we have is sufficient


[SP-5195] Backport of PDI-18165 - Excel Writer step - Misspelled labe…

…l in File
@pentaho/tatooine
@pentaho-lmartins @ssamora

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/excelwriter/messages/messages_en_US.properties

Still Broken Tests:
org.pentaho.di.core.logging.MetricsPainterTest.testDrawTimeScaleLineInfinityLoop:
:red_circle: org.junit.runners.model.TestTimedOutException
org.junit.runners.model.TestTimedOutException: test timed out after 1000 milliseconds
	at java.lang.ClassLoader.findBootstrapClass(Native Method)
	at java.lang.ClassLoader.findBootstrapClassOrNull(ClassLoader.java:1015)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:413)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.getDeclaredMethods0(

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.2% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:


Fix bad output repo stats

Repo sizes are now set to be the size of the master branch's HEAD commit.
Open questions:

Can the master branch be deleted? If so, how should that case be handled?
Are there any other places where the HEAD commit might be changed?

Fixes #3330

2 small changes requested.

@jdoliner this is ready for another pass. TravisCI says it's still running tests for the PR, but they passed hours ago - you can see if you click through.