cleanup: fix beta apiVersion for csidriver

This change resolves a typo for installing the CSIDriver
resource in Kubernetes clusters before 1.18,
where the apiVersion is incorrect.
See also:
https://kubernetes-csi.github.io/docs/csi-driver-object.html
Closes: #2281

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

@nixpanic can you also fix this in other places as @pkalever mention on the #2281
examples/cephfs/snapshot.yaml:# v1betav1:
examples/cephfs/snapshotclass.yaml:# v1betav1:
examples/rbd/snapshot.yaml:# v1betav1:
examples/rbd/snapshotclass.yaml:# v1betav1:

@Madhu-1 @pkalever addressed the v1betav1 in the examples too now.

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/mini-e2e/k8s-1.20

Failed with #2264

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e/k8s-1.21

/retest ci/centos/mini-e2e/k8s-1.21

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.21

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e-helm/k8s-1.21

Deploying with Helm failed (logs):
+ ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no<EMAIL_ADDRESS>'cd /opt/build/go/src/github.com/ceph/ceph-csi && ./scripts/install-helm.sh install-cephcsi --namespace '\''cephcsi-e2e-1bd346f32df9'\'' --deploy-sc --deploy-secret'
Warning: Permanently added 'n14.dusty.ci.centos.org,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Error from server: etcdserver: request timed out
script returned exit code 1

/retest ci/centos/mini-e2e/k8s-1.19

deploying Vault failed (logs):
Jul 22 07:52:23.792: INFO: Running '/usr/bin/kubectl --server=https://<IP_ADDRESS>:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-a44ec4b4 create -f -'
Jul 22 07:52:33.869: INFO: rc: 1
Jul 22 07:52:33.869: INFO: will run kubectl (create) again (10 seconds elapsed)
Jul 22 07:52:33.869: FAIL: failed to create vault configmap failed to run kubectl: error running /usr/bin/kubectl --server=https://<IP_ADDRESS>:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-a44ec4b4 create -f -:
Command stdout:

stderr:
Error from server: error when creating "STDIN": etcdserver: request timed out

error:
exit status 1


Add interface for GetReplyMarkup method to MaybeInaccessibleMessage

Hello,
I would like to suggest adding a new method GetReplyMarkup() to the MaybeInaccessibleMessage interface. This method will allow access to the ReplyMarkup property in the update.CallbackQuery.Message.ReplyMarkup structure. The proposed method will return data of type any to retrieve the ReplyMarkup information.
Objective:
https://github.com/mymmrac/telego/blob/f0e873e1ac8c0bdf50280d3ed972cabfb4473df1/types.go#L925C1-L932C2
Proposed Changes:

Add a new method GetReplyMarkup() to the MaybeInaccessibleMessage interface.
Define the return type of the method as any to accommodate various data types for ReplyMarkup.

Your consideration and feedback on this proposed enhancement are appreciated. Thank you.

Hello, I will think about this, but most likely will not add this, since ReplyMarkup may not be present in types, so it's misleading to provide it

Thank you for your response. I understand your concern about the potential absence of ReplyMarkup in some types of messages. However, my suggestion to add the GetReplyMarkup() method is to make access to it easier in cases where ReplyMarkup is present. We can handle this issue by returning a null value or using an optional type (such as a pointer) for cases where ReplyMarkup is not available. This change can provide developers with more flexibility to access ReplyMarkup data when needed.


[Modal] Add ability to align Modal to top of window

It would be useful to have the ability to show a modal attached to the top of the window.  This may be as simple as adding an align property to the Modal settings object, and if set to top, the Modal set.position() method sets top to 0.  This may be a naive implementation - I haven't done enough testing with scrolling pages or long modal boxes.

I've been thinking about adding a setting for specifying valign %. I think personally these days I actually prefer something like 33%.

The valign setting is a great idea.  Not sure if I'll get any time to work on it, but will if I can.

Really want this too.
Thanks for anyone could come back to implement this.


Use a slightly faster digest method.

Looks fine.

This is included in https://github.com/livingsocial/rake-pipeline/pull/37.


Test event listeners on request body failures

Flaky test! https://github.com/square/okhttp/issues/3507


Unable to parse instruction Castclass
Unable to parse instruction Castclass
Method with duplicate full name found: System.Void Avalonia.Themes.Default.DefaultTheme::!XamlIlPopulateTrampoline(Avalonia.Themes.Default.DefaultTheme)
Unable to parse instruction Castclass
Unable to parse instruction Castclass
Unable to parse instruction Ldftn
Unable to parse instruction Castclass
Unable to parse instruction Castclass
Unable to parse instruction Ldftn
Unable to parse instruction Castclass
Unable to parse instruction Castclass
Unable to parse instruction Ldftn
Unable to parse instruction Castclass
Unable to parse instruction Castclass
Unable to parse instruction Ldftn
Unable to parse instruction Castclass
Unable to parse instruction Castclass
Unable to parse instruction Ldftn
Unable to parse instruction Castclass
Unable to parse instruction Throw
Unable to parse instruction Throw
Unhandled exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.InvalidCastException: Unable to cast object of type 'Mono.Cecil.ParameterDefinition' to type 'System.Int32'.
   at Cilsil.Cil.Parsers.LdargParser.ParseCilInstructionInternal(Instruction instruction, ProgramState state) in /app/Cilsil/Cil/Parsers/LdargParser.cs:line 21
   at Cilsil.Cil.Parsers.InstructionParser.ParseCilInstruction(Instruction instruction, ProgramState state) in /app/Cilsil/Cil/Parsers/InstructionParser.cs:line 83
   at Cilsil.Services.CfgParserService.ComputeMethodCfg(MethodDefinition method) in /app/Cilsil/Services/CfgParserService.cs:line 113
   at Cilsil.Services.CfgParserService.Execute() in /app/Cilsil/Services/CfgParserService.cs:line 51
   at Cilsil.Services.CfgParserService.ExecuteFromResult(ServiceExecutionResult result) in /app/Cilsil/Services/CfgParserService.cs:line 73
   at Cilsil.Services.ServiceExecutionResult.ThenExecute(IService service) in /app/Cilsil/Services/Results/ServiceExecutionResult.cs:line 11
   at Cilsil.Program.ExecuteTranslation(String[] paths, String printprocs) in /app/Cilsil/Program.cs:line 124
   at Cilsil.Program.Translate(String[] paths, String printprocs, String outcfg, String cfgtxt, String outtenv, String dot) in /app/Cilsil/Program.cs:line 95
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at System.Delegate.DynamicInvoke(Object[] args)
   at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass2_0.<<InvokeAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c.<<UseParseErrorReporting>b__16_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c__DisplayClass8_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c.<<UseSuggestDirective>b__7_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c.<<UseParseDirective>b__6_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c.<<UseHelp>b__14_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass3_0.<<UseVersionOption>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c.<<RegisterWithDotnetSuggest>b__17_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationExtensions.<>c__DisplayClass5_0.<<UseExceptionHandler>b__0>d.MoveNext()
You may see 'Unable to parse instruction xxx' above. This is expected as we have not yet translated all the CIL instructions, which follow a long tail distribution. We are continuing to expand our .NET translation coverage.

Translation completed. Analyzing...

Logs in /github/workspace/infer-out/logs
Uncaught Internal Error: (Sys_error "/github/workspace/tenv.json: No such file or directory")
Error backtrace:
Raised by primitive operation at Stdlib.open_in_gen in file "stdlib.ml", line 398, characters 28-54
Called from Stdlib.open_in in file "stdlib.ml" (inlined), line 403, characters 2-45
Called from Yojson.Safe.from_file in file "lib/read.mll", line 1135, characters 13-25
Called from Backend__InferAnalyzeJson.analyze_json in file "src/backend/InferAnalyzeJson.ml", line 677, characters 24-57
Called from Integration__Driver.execute_analyze_json in file "src/integration/Driver.ml", line 177, characters 6-54
Called from IBase__Utils.timeit in file "src/base/Utils.ml", line 429, characters 16-20
Called from IBase__ScubaLogging.execute_with_time_logging in file "src/base/ScubaLogging.ml", line 79, characters 29-44
Called from Dune__exe__Infer.run in file "src/infer.ml", line 21, characters 2-47
Called from IBase__Utils.timeit in file "src/base/Utils.ml", line 429, characters 16-20
Called from IBase__ScubaLogging.execute_with_time_logging in file "src/base/ScubaLogging.ml", line 79, characters 29-44
Called from Dune__exe__Infer.run in file "src/infer.ml", line 25, characters 22-94

Run the command again with `--keep-going` to try and ignore this error.
cat: infer-out/report.txt: No such file or directory

In the latest docker release you shouldn't see this issue.


Tests for single user mode

Description
Single user mode needs to have tests - testing the application switches correctly every time between single user and multi-tenancy is important
Screenshots
No response
Additional information
No response

I would like to work on this issue @eddiejaoude

Sure, thank you @cperezcapote 👍


CBLBlobWriteStream is leaked when used with CBLBlob_CreateWithStream

Per the doc comments, when a CBLBlobWriteStream is used with CBLBlob_CreateWithStream it should not be closed. If I don't call CBLBlobWriter_Close after using it with CBLBlob_CreateWithStream valgrind reports the stream as leaked.
==212388== 288 bytes in 12 blocks are definitely lost in loss record 197 of 209
==212388==    at 0x4A3A99F: operator new[](unsigned long) (vg_replace_malloc.c:579)
==212388==    by 0x5E46C74: CBLBlobWriter_Create (CBLBlob_CAPI.cc:100)
==212388==    by 0x5425DC9: ???
==212388==    by 0x5425D6C: ???
==212388==    by 0x5425409: ???
==212388==    by 0x542539E: ???
==212388==    by 0x542C23D: ???
==212388==    by 0x542C38B: ???
==212388==    by 0x542CC17: ???
==212388==    by 0x540CC47: ???
==212388==    by 0x540CC05: ???
==212388==    by 0x544D797: ???

I am able to call CBLBlobWriter_Close after CBLBlob_CreateWithStream without a segmentation fault. The stream won't be reported as being leaked in that case.

Did you free the resulting blob of CBLBlob_CreateWithStream ?

Yes, I'm freeing the blob.

I need to look into what should be the expected behavior. Based on the API doc, it looks to me that after creating Blob with the stream, Blob will own the writer and should close the writer as appropriate. However when I read the C++ implementation, the writer will be closed with the C++ wrapper of the writer is released.

I am able to call CBLBlobWriter_Close after CBLBlob_CreateWithStream without a segmentation fault.

I have tested this and from what I see, the behavior is already correct. Closing the writer after creating the stream is not needed and it would cause the steam to be double released. Can you tried again with the latest code in the master branch? If the issue still happens, we can reopen the issue.

I'll try it out and reopen if the issue persists.


Default not to create priority class

Organization Name:

Short summary about the issue/question:
Ref: https://github.com/microsoft/pai/issues/4117
Brief what process you are following:

How to reproduce it:

OpenPAI Environment:

OpenPAI version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Anything else we need to know:

Fixed in #4131.


Added Red Light Green Light

[NEW GAME]: Red Light Green Light #433
closes #433
Screenshot

Kindly follow the guidelines and contribute accordingly. Kindly go through contributing.md for more insights.


Failed to init view stmt

Steps to reproduce the behavior (Required)
Preparation
create database user_center_cn;
use user_center_cn;

CREATE TABLE `dim_mongo_uid` (
  `id` bigint(20) NULL COMMENT "mongo中自增id",
  `info` varchar(65533) NULL COMMENT "游戏玩家信息  id|name"
) ENGINE=OLAP
DUPLICATE KEY(`id`, `info`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`id`) BUCKETS 2
PROPERTIES (
  "replication_num" = "3",
  "in_memory" = "false",
  "storage_format" = "DEFAULT"
);

CREATE TABLE `ods_w4_log` (
  `server_id` tinyint(4) NULL COMMENT "服务器id",
  `uid` int(11) NULL COMMENT "玩家id",
  `record_time` datetime NULL COMMENT "日志生成时间",
  `date` date NULL COMMENT "日期（游戏中4点到4点）",
  `eventname` varchar(60) NULL COMMENT "事件名",
  `env` varchar(20) NULL COMMENT "日志环境（内网测试、外网测试、cbt、正式）",
  `message` varchar(65533) NULL COMMENT "日志内容",
  INDEX env (`env`) USING BITMAP COMMENT 'env mark',
  INDEX eventname (`eventname`) USING BITMAP COMMENT 'eventname mark'
) ENGINE=OLAP
DUPLICATE KEY(`server_id`, `uid`, `record_time`)
PARTITION BY RANGE(`date`)
(PARTITION p20211114 VALUES [('0000-01-01'), ('2021-11-15')),
PARTITION p20211115 VALUES [('2021-11-15'), ('2021-11-16')),
PARTITION p20211116 VALUES [('2021-11-16'), ('2021-11-17')),
PARTITION p20220119 VALUES [('2022-01-19'), ('2022-01-20')),
PARTITION p20220120 VALUES [('2022-01-20'), ('2022-01-21')))
DISTRIBUTED BY HASH(`uid`, `eventname`) BUCKETS 32
PROPERTIES (
    "replication_num" = "2",
    "dynamic_partition.enable" = "true",
    "dynamic_partition.time_unit" = "DAY",
    "dynamic_partition.time_zone" = "Asia/Dubai",
    "dynamic_partition.start" = "-365",
    "dynamic_partition.end" = "3",
    "dynamic_partition.prefix" = "p",
    "dynamic_partition.buckets" = "32",
    "in_memory" = "false",
    "storage_format" = "DEFAULT"
);

CREATE TABLE `ods_user_log` (
    `xid` bigint(20) NULL COMMENT "采集id",
    `ts` bigint(20) NULL COMMENT "采集时间戳",
    `table` varchar(60) NULL COMMENT "表名",
    `date` date NULL COMMENT "日期",
    `record_time` datetime NULL COMMENT "采集时间",
    `type` varchar(20) NULL COMMENT "操作类型",
    `commit` boolean NULL COMMENT "操作类型",
    `database` varchar(60) NULL COMMENT "数据库",
    `message` varchar(65533) NULL COMMENT "信息内容"
) ENGINE=OLAP
DUPLICATE KEY(`xid`, `ts`, `table`)
PARTITION BY RANGE(`date`)
(PARTITION p20211212 VALUES [('2021-12-12'), ('2021-12-13')),
PARTITION p20211213 VALUES [('2021-12-13'), ('2021-12-14')),
PARTITION p20220119 VALUES [('2022-01-19'), ('2022-01-20')),
PARTITION p20220120 VALUES [('2022-01-20'), ('2022-01-21')))
DISTRIBUTED BY HASH(`table`) BUCKETS 4
PROPERTIES (
    "replication_num" = "2",
    "dynamic_partition.enable" = "true",
    "dynamic_partition.time_unit" = "DAY",
    "dynamic_partition.time_zone" = "Asia/Shanghai",
    "dynamic_partition.start" = "-1000",
    "dynamic_partition.end" = "3",
    "dynamic_partition.prefix" = "p",
    "dynamic_partition.buckets" = "4",
    "in_memory" = "false",
    "storage_format" = "DEFAULT"
);

CREATE TABLE `dim_mongo_sdk` (
  `account` varchar(65533) NULL COMMENT "账号id 长码",
  `id` bigint(20) NULL COMMENT "mongo中自增id"
) ENGINE=OLAP
DUPLICATE KEY(`account`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`account`) BUCKETS 2
PROPERTIES (
    "replication_num" = "3",
    "in_memory" = "false",
    "storage_format" = "DEFAULT"
);

CREATE VIEW `dwd_login_view` AS SELECT to_date(from_unixtime(get_json_int(`message`, '$.login_at'))) AS `date`, get_json_int(`message`, '$.channel_id') AS `channel_id`, from_unixtime(get_json_int(`message`, '$.login_at')) AS `login_at`, from_unixtime(get_json_int(`message`, '$.created_at')) AS `created_at`, get_json_int(`message`, '$.login_log_id') AS `login_log_id`, get_json_int(`message`, '$.account_id') AS `account_id`, get_json_string(`message`, '$.long_account_id') AS `long_account_id`, get_json_string(`message`, '$.short_account_id') AS `short_account_id`, get_json_string(`message`, '$.game_code') AS `game_code`, get_json_string(`message`, '$.package_code') AS `package_code`, get_json_string(`message`, '$.login_ip') AS `login_ip`, get_json_string(`message`, '$.device_ua') AS `device_ua`, get_json_string(`message`, '$.device_id') AS `device_id`, get_json_string(`message`, '$.device_net') AS `device_net`, get_json_string(`message`, '$.device_ratio') AS `device_ratio`, get_json_string(`message`, '$.device_os') AS `device_os`, get_json_string(`message`, '$.device_carrier') AS `device_carrier`, get_json_string(`message`, '$.ext') AS `ext` FROM `default_cluster:user_center_cn`.`ods_user_log` WHERE `table` LIKE 'login_log%';

CREATE VIEW `dim_login_view` AS SELECT `user_center_cn`.`dwd_login_view`.`channel_id` AS `channel_id`, `user_center_cn`.`dwd_login_view`.`login_at` AS `login_at`, `user_center_cn`.`dwd_login_view`.`date` AS `date`, `user_center_cn`.`dwd_login_view`.`login_log_id` AS `login_log_id`, `user_center_cn`.`dwd_login_view`.`account_id` AS `account_id`, `user_center_cn`.`dwd_login_view`.`long_account_id` AS `long_account_id`, `user_center_cn`.`dwd_login_view`.`short_account_id` AS `short_account_id`, `user_center_cn`.`dwd_login_view`.`game_code` AS `game_code`, `user_center_cn`.`dwd_login_view`.`package_code` AS `package_code`, `user_center_cn`.`dwd_login_view`.`login_ip` AS `login_ip`, `user_center_cn`.`dwd_login_view`.`device_ua` AS `device_ua`, `user_center_cn`.`dwd_login_view`.`device_id` AS `device_id`, `user_center_cn`.`dwd_login_view`.`device_net` AS `device_net`, `user_center_cn`.`dwd_login_view`.`device_ratio` AS `device_ratio`, `user_center_cn`.`dwd_login_view`.`device_os` AS `device_os`, `user_center_cn`.`dwd_login_view`.`device_carrier`AS `device_carrier`, `user_center_cn`.`dwd_login_view`.`ext` AS `ext`, `user_center_cn`.`dwd_login_view`.`created_at` AS `created_at` FROM `user_center_cn`.`dwd_login_view` WHERE `game_code` = 'w4';

CREATE VIEW `dim_phone_view` AS SELECT to_date(from_unixtime(get_json_int(`message`, '$.created_at'))) AS `date`, from_unixtime(get_json_int(`message`, '$.created_at')) AS `record_time`, get_json_int(`message`, '$.account_id') AS `account_id`, get_json_int(`message`, '$.channel_id') AS `channel_id`, get_json_string(`message`, '$.account_name') AS `account_name`, get_json_string(`message`, '$.email') AS `email`, get_json_string(`message`, '$.identity') AS `identity`, get_json_string(`message`, '$.credential') AS `credential`, get_json_string(`message`, '$.created_at') AS `created_at` FROM `default_cluster:user_center_cn`.`ods_user_log` WHERE (`table` LIKE 'account_credential%') AND (get_json_int(`message`, '$.channel_id') = 11);

CREATE VIEW `dim_account_view` AS SELECT to_date(get_json_string(`message`, '$.created_at')) AS `date`, get_json_int(`message`, '$.account_id') AS `account_id`, get_json_string(`message`, '$.created_at') AS `created_at`, get_json_string(`message`, '$.updated_at') AS `updated_at`, get_json_string(`message`, '$.project') AS `project`, get_json_string(`message`, '$.id_num') AS `id_num`, get_json_string(`message`, '$.name') AS `name`, get_json_string(`message`, '$.pi') AS `pi`, get_json_string(`message`, '$.ai') AS `ai`, get_json_string(`message`, '$.app_id') AS `app_id`, get_json_string(`message`, '$.biz_id') AS `biz_id`, get_json_string(`message`, '$.status') AS `status`, get_json_string(`message`, '$.msg') AS `msg` FROM `default_cluster:user_center_cn`.`ods_user_log` WHERE (`table` = 'idcard') AND (get_json_string(`message`, '$.project') = 'w4');

Create View
CREATE VIEW yao_test
AS
WITH mongo_uid AS (
		SELECT id, regexp_extract(info, '^.+id=([0-9]+).+', 1) AS UID
		FROM dim_mongo_uid
	),
	mongo_all AS (
		SELECT u.id, UID, account
		FROM mongo_uid u
			JOIN dim_mongo_sdk s ON u.id = s.id
	),
	dim_login AS (
		SELECT DISTINCT account_id, long_account_id
		FROM dim_login_view
	),
	dim_phone AS (
		SELECT account_id, IDENTITY AS phone
		FROM dim_phone_view
	),
	dim_account AS (
		SELECT account_id
			, year(curdate()) - substr(id_num, 7, 4) AS age
			, name
		FROM dim_account_view
	),
	dim_all AS (
		SELECT l.account_id, long_account_id, name, phone, age
		FROM dim_login l
			JOIN dim_phone p ON l.account_id = p.account_id
			JOIN dim_account a ON p.account_id = a.account_id
	)
SELECT account_id, long_account_id, name, age, phone , UID
FROM dim_all d
    JOIN mongo_all m ON d.long_account_id = m.account;

Expected behavior (Required)
Create view successfully.
Real behavior (Required)
MySQL client throws the following error:
ERROR 1064 (HY000): failed to init view stmt

fe.warn.log contains the following content:
com.starrocks.common.DdlException: failed to init view stmt
        at com.starrocks.catalog.Catalog.createView(Catalog.java:6069) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.DdlExecutor.execute(DdlExecutor.java:194) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.handleDdlStmt(StmtExecutor.java:900) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:420) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:268) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:415) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:651) ~[starrocks-fe.jar:?]
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:55) ~[starrocks-fe.jar:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_202]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_202]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
Caused by: com.starrocks.common.UserException: Failed to parse view-definition statement of view: yao_test
        at com.starrocks.catalog.View.init(View.java:204) ~[starrocks-fe.jar:?]
        at com.starrocks.catalog.Catalog.createView(Catalog.java:6067) ~[starrocks-fe.jar:?]
        ... 10 more

StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
b82a996d22a564e6dfc036c852d75e32b47454de

I caught the exception：“com.starrocks.common.AnalysisException: Syntax error”

When processing the select statement in the view, some additional slot information is added to cause the parsing failure. The slot information comes from here:

@kangkaisen Can I help with it?

 The slot information comes from here:  @kangkaisen Can I help with it?

Sorry to delay response. we will resolve this issue as soon as possible.

 I guess the reason is WITH_CLAUSE havn't set needToSql, I will try fix the bug.
By the way, the code about VIEW is terrible now, we will refactor it later, hope you will submit a contribution then.


Why do summation tables occasionally do this? "1.800000000000001e+284Y"

net.eth5.txkB_s	0.00	1.800000000000001e+284Y	5e-324	0.00	0.00	0.00
Any ideas on why summation tables occasional do the above to my data?  Sometimes it gives me a 0, and sometimes it says "1.800000000000001e+284Y"

...and this 1.7976931348623157e+308.  At least that number can be found in a google search.  I "think" it's telling me that the metric is out of bounds.

It's just a bug in calculating the min and max in Summation.js. Fixed on the development branch a few days ago.


Throw error if no auth mechanism is match

This pull request aims to close #1555 by returning an error if no auth mechanism is found.
Signed-off-by: glefloch<EMAIL_ADDRESS>

@simonpasquier I have used the types.MultiError object. I am going to have a look to failed tests.

I've restarted the Travis tests as it is probably a flake. In any case, it might be good to add a few unit tests.

@simonpasquier, I have added unit tests. Could you tell me if this is what you expected?

Thanks for this! :+1: for me.


data ingestion stage

[x] update config.yaml

[x] update secret.yaml

[x] update params.yaml

[x] update the entity

[x] update configuration mannager in src config

[x] update the components

[x] update the pipeline

its over

dry run successful


Update PPP

Update weikiat.md

Codecov Report

Merging #208 (94a02f6) into master (bf08f78) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #208   +/-   ##
=========================================
  Coverage     62.17%   62.17%
  Complexity      739      739
=========================================
  Files           133      133
  Lines          2829     2829
  Branches        373      373
=========================================
  Hits           1759     1759
  Misses          928      928
  Partials        142      142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf08f78...94a02f6. Read the comment docs.


[Follow-up PR] Add flag to list all avialable configurations.

Add flag -a to list all active cilium configurations.

could you also post a sample output? just curious to see how the output looks like eyes

Tried to show a sub-set of all configurations. But it contains all the active configurations separated by ###.


Allow swiftgen strings to use a directory as input

assets strings should be allowed to take a directory as parameter and scan for every *.strings files in it.
This would allow people using Base.lproj and one *.strings file for each .xib or .storyboard to work too

:+1: would be awesome!

This could also use #33 to parse multiple Localizable.strings files passed as argument instead of a dir

Issue #39 could be related also

Ping'd in https://github.com/SwiftGen/SwiftGen/issues/497#issuecomment-422438917 with thoughts on cases where folders have multiple .lproj files


Typo "Azure Open AI"→"Azure OpenAI"

https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/generative-ai-azure-openai
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/postgresql/flexible-server/generative-ai-azure-openai.md
#PingMSFTDocs

Looks good. Thank you, @hyoshioka0128.

#sign-off


open files with custom applications for that specific file extension, specified in some config file

Summary
When a file is selected and opened (by hovering on it and pressing o), we should be able to open it with a custom program that we have specified in a custom configuration file.
Configuration file may be .glsrc, and then we can use it later for other configurations

Hi @ozansz! I am interested on working on this issue and was wondering if I could be assigned it? I was also wondering how you go about testing on different operating systems since I only have a windows machine.

Hi @ozansz! I am interested on working on this issue and was wondering if I could be assigned it? I was also wondering how you go about testing on different operating systems since I only have a windows machine.

Hi @JusteenR! You can use Windows Subsystem for Linux, or install a virtual machine inside Windows and run any Linux distro inside the VM to run and test the project. Unfortunately, the project is does not support Windows because it casts os.Lstat's to *syscall.Stat_t struct type to get the files' real size.
If you are interested, you can also open an issue to implement Windows-compatible code. The incompatible code part is here: https://github.com/ozansz/gls/blob/7e7a9b459fc880fb8ffbee80f8d47c7229fde750/internal/fs/walk.go#L30


fix: hover effect

Related Issue
Fixes #476
Description
Added Transition effect
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[ ] I have performed a self-review of my code
[ ] I have read and followed the Contribution Guidelines.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

This is second time i am raising new PR because i am getting merge conflicts. Is it good idea to add only files except package-lock.json

This is second time i am raising new PR because i am getting merge conflicts. Is it good idea to add only files except package-lock.json

Then also we get error at later stages since package requirement varies

@upsaurav12 Kindly share what all difficulties u are facing while updating branch

@SUGAM-ARORA can you check ??


Add local fluxbox theme into config

Lumina can use local fluxbox themes (~/.fluxbox/styles/YOURTHEME) by writing in hard into ~/.lumina/fluxbox-init. For example:
session.styleFile:	~/.fluxbox/styles/solarized
But lumina-config not allow to choose a style into local fluxbox styles unlike lumina themes.

Fixed!
https://github.com/pcbsd/lumina/commit/32ce4568da9ea61b4dafaf8022d48bdda57ec5b2


Rm command  in RTF uninstall steps uses hyphen instead of underscore

https://docs.mulesoft.com/runtime-fabric/1.7/uninstall-manual
In step 5, after running command:
rm /etc/systemd/system/install-teleport-*.service /etc/systemd/system/install-planet-*.service /etc/systemd/system/shrink-*.service /etc/systemd/system/gravity__gravitational.io__teleport__*.service /etc/systemd/system/gravity__gravitational.io__planet-*.service
There were remaining files of type: gravity__gravitational.io__planet_*.service
I believe the hyphen needs to updated to underscore to fully remove these files:
/etc/systemd/system/gravity__gravitational.io__planet-*.service" --> "/etc/systemd/system/gravity__gravitational.io__planet_*.service

@kmendiratta-crm Can you review this?


components workflow filepath replaced

@marqh

@bjlittle Did it anyway.  That's just the kind of girl I am.  I live on the edge.

Coverage remained the same at 99.276% when pulling f04a86c08b9e1bfa9cf063000da05de5d92a82cd on corinnebosley:nb_fix into c563e5da25494ab14204f03d7f0d8293c0ded1b0 on SciTools:master.

Coverage remained the same at 99.276% when pulling cb44e37f16e5865d0ad0759c2e78b9507b0f54ae on corinnebosley:nb_fix into c563e5da25494ab14204f03d7f0d8293c0ded1b0 on SciTools:master.

Coverage remained the same at 99.276% when pulling cb44e37f16e5865d0ad0759c2e78b9507b0f54ae on corinnebosley:nb_fix into c563e5da25494ab14204f03d7f0d8293c0ded1b0 on SciTools:master.

Coverage remained the same at 99.276% when pulling 8d2cc1f96eaeb9271c8d83d71d204ec40abfafa9 on corinnebosley:nb_fix into c563e5da25494ab14204f03d7f0d8293c0ded1b0 on SciTools:master.

:+1: Thanks!


Authentication handling and error messages

Comments on login behaviour:

If user is configured in LDAP and is member of one of olog's groups, login is OK.
If LDAP is not configured, Olog returns a "wrong username or password" error.
When logging in as existing LDAP user, which is not in any olog group (olog-logs, olog-tags, olog-logbooks or olog-admins), Olog ignores the login and keeps "Guest" logged in. No login error is reported.
When logging in as bogus user, e.g. bogus:bogus, the browser's authentication pops up and infinitely requests the login data. No login error is reported by Olog.

Error message in case 2 is misleading. In cases 3 and 4, Olog should return meaningful error messages in the login screen. Message could be equal for both cases, something like "User unknown to olog."?
Cheers!

@AnthonyDionise can you look at this please.


Error in string_input_producer

Environment info
Operating System: Ubuntu 15.04
If installed from sources, provide the commit hash: c1a40c7
Steps to reproduce
Run the following commands:
import tensorflow as tf
sess = tf.InteractiveSession()
filenames = ["1", "2", "3"]
filename_queue = tf.train.string_input_producer(filenames)
test_value = tf.convert_to_tensor(filename_queue.size())
print(sess.run([test_value]))

For me, this last command returns [0]. If I'm understanding things right, I'm assuming it should return [3]. I've also tried to run the dequeue() op, which appears to hang and become unresponsive.
It's also possible I'm just completely misunderstanding how this is supposed to work - in which case, please disregard!

Nevermind, it turns out the command tf.train.start_queue_runners(sess=sess) must be run before the queue gets filled. Works as expected when this is done.


Mycontroller just stopped working

Nothing unusual in the logfile
https://pastebin.com/VdWGTUJB
It just stopped to respond ~12 hours ago. Process was still running.
Could not call the website too ..

.. aparently my dyndns service just didn't refresh ..


Ability to sync global-snippets

Visual Studio Code Version : [ 1.20.1 ]
Code Settings Sync Version : [ 2.8.7 ]
It would be great to be able to sync *.global-snippets introduced at VS Code v1.20.1.

Duplicate of #491


[FR] Disable Intelligent Suggestion Prioritization

Hi there, thanks for this awesome plugin.
I don't wanna keep a history of my snippets. Could you add a button to disable it?

Hi, @MDslash :)
I'll consider it 👍

I have released it in the v9.0.0-beta5 🚀
If you use BRAT, I would appreciate it if you could check it out before the official release.

If you use BRAT, I would appreciate it if you could check it out before the official release.

It worked, thanks!


Update office-365-worldwide-endpoints.md

Hi team,
We are IC3 Data Platform team. Our service host is end with "*.teams.microsoft.com" and we need to update 2 IP address to allow customer visit our service.
Thanks!

Our IP address might changed and will update this doc later.


node 16.0.0 deprecation warning - (node:67086) [DEP0148]

:bug: Bug Report
This is in projen, but shouldn't be specific.
npx projen build
........
🤖 build » package | jsii-pacmak
(node:67086) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/pgollucci/src/github.com/forked/pgollucci/projen/node_modules/yaml/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)

Affected Languages

[X] TypeScript or Javascript
[ ] Python
[ ] Java
[ ] .NET (C#, F#, ...)
[ ] Go

General Information

JSII Version: 1.28.0 (build 1801f4f), typescript 3.9.9

Platform:     Darwin jlhewitt.fios-router.home 20.4.0 Darwin Kernel Version 20.4.0: Fri Mar  5 03:57:04 PST 2021; root:xnu-7195.101.1~4/RELEASE_X86_64 x86_64

node --version
v16.0.0
What is the problem?

Verbose Log
node --trace-deprecation node_modules/.bin/jsii-pacmak --verbose
[jsii-pacmak] [INFO] Found 1 modules to package
[jsii-pacmak] [INFO] Packaging NPM bundles
[jsii-pacmak] [INFO] Loading jsii assemblies and translations
[jsii-pacmak] [INFO] Packaging 'dotnet' for 0 modules
[jsii-pacmak] [INFO] Packaging 'go' for 0 modules
[jsii-pacmak] [INFO] Packaging 'java' for projen
[jsii-pacmak] [INFO] Packaging 'js' for projen
[jsii-pacmak] [INFO] Packaging 'python' for projen
[jsii-pacmak] [INFO] dotnet finished
[jsii-pacmak] [INFO] go finished
(node:73959) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/pgollucci/src/github.com/forked/pgollucci/projen/node_modules/yaml/package.json.
Update this package.json to use a subpath pattern like "./*".
    at emitFolderMapDeprecation (node:internal/modules/esm/resolve:69:11)
    at packageExportsResolve (node:internal/modules/esm/resolve:542:7)
    at resolveExports (node:internal/modules/cjs/loader:477:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:517:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:926:27)
    at Function.resolve (node:internal/modules/cjs/helpers:99:19)
    at Object.resolveDependencyDirectory (/Users/pgollucci/src/github.com/forked/pgollucci/projen/node_modules/jsii-pacmak/lib/util.js:18:33)
    at /Users/pgollucci/src/github.com/forked/pgollucci/projen/node_modules/jsii-pacmak/lib/dependency-graph.js:44:36
    at Array.map (<anonymous>)
    at real$traverseDependencyGraph (/Users/pgollucci/src/github.com/forked/pgollucci/projen/node_modules/jsii-pacmak/lib/dependency-graph.js:43:41)
[jsii-pacmak] [INFO] js finished
[jsii-pacmak] [INFO] python finished
[jsii-pacmak] [INFO] java finished
[jsii-pacmak] [INFO] Packaged. java (52.2s) | python (26.3s) | js (12.4s) | npm pack (3.6s) | load jsii (0.5s) | dotnet (0.0s) | go (0.0s) | cleanup (???)

Are you able to pinpoint which part of the package.json is responsible for this warning?
I don't know that we are using exports maps ourselves at this point..?


leaveChannelEx not supported in this platform

Version of the agora_rtc_engine
6.3.2
Platforms affected

[ ] Android
[ ] iOS
[ ] macOS
[ ] Windows
[X] Web

Steps to reproduce

Join using joinChannelEx with uid 0
Join again for screensharing user only with joinChannelEx with uid 1001
Leave channel only for screensharing user with leaveChannelEx with connection data using uid 1001

Expected results
Joins that happened using joinChannelEx should be able to be left separately
Actual results
[02:51:44:644][Iris warning]:RtcEngineEx_leaveChannelEx_b03ee9a not supported in this platform!
[02:51:44:644][Iris log]:[callIrisApiAsync][result] RtcEngineEx_leaveChannelEx_b03ee9a ret -4
AgoraRtcException(-4, null)
Code sample
Code sample
await _engine
        .leaveChannelEx(
      connection: RtcConnection(
        channelId: rtcChannelName,
        localUid: config.screenSharingUid,
      ),
    )

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

I need to achieve the following workflow:
A. Tried using RtcEngineEx

Join user first with joinChannelEx with uid 0 - this is for normal audio and primary camera
When screensharing, join again with joinChannelEx with uid 1001 - this for screensharing only
When stopped screensharing, I need to disconnect only uid 1001 but still keep uid 0 user connected

So, how can I make leaveChannelEx work to acheive this?
B. Tried using RtcEngine

Create two RtcEngine instances engineA and engineB
Join engineA first with joinChannel with uid 0 - this is for normal audio and primary camera
When screensharing, join engineB with joinChannel with uid 1001 - this for screensharing only
When stopped screensharing, I need to disconnect only uid 1001 but still keep uid 0 user connected
But when i invoke leaveChannel() for engineB, it also affects engineA

So, is it normal behaviour? Anyway I can make this work?
Thanks!

@littleGnAl can you help us with this one?

So, how can I make leaveChannelEx work to acheive this?

The error code -4 means this API is not supported, the leaveChannelEx  is not supported on the web at this time, we will implement it in the future.

B. Tried using RtcEngine

The RtcEngine is a singleton, and the leaveChannel  leaves channel for all the uid, this should be the expected behavior, you can only use the leaveChannelEx to achieve your requirement.

Thanks for the response @littleGnAl . So there is no way to handle stopping of screen share (ex uid: 1001) without kicking the original user (ex uid: 1000) out? When can we expect leaveChannelEx to be available for flutter web?

So there is no way to handle stopping of screen share (ex uid: 1001) without kicking the original user (ex uid: 1000) out?

Yes in a short time.

When can we expect leaveChannelEx to be available for flutter web?

We will implement it when we have resources, but it's so sorry there's no timeline guarantee for it.

@littleGnAl any news on this the cutoff of the sunset plan is 14th September 2024. in that case all of our services will not work since upgrading to latest version cannot fix this problem?

It should be supported now, please try the latest version https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK?tab=readme-ov-file#web-alpha

@littleGnAl is AgoraVideoView now stable on the web?

@littleGnAl
 SingleChildScrollView(                                         scrollDirection: Axis.horizontal,                                         child: Row(                                           children: List.of(                                             rtcMembers.map(                                               (e) {                                                 if (e == 0) {                                                   return const SizedBox(                                                     height: 200,                                                     width: 200,                                                     child: Text("Local"),                                                   );                                                 }                                                 return Container(                                                   width: 200,                                                   height: 200,                                                   decoration: BoxDecoration(                                                       border: Border.all(                                                           color: Colors.blue),                                                       color: Colors.red),                                                   child: AspectRatio(                                                     aspectRatio: 16 / 9,                                                     child: AgoraVideoView(                                                       controller:                                                           VideoViewController                                                               .remote(                                                         rtcEngine: _engine,                                                         canvas: VideoCanvas(                                                           uid: e,                                                           renderMode:                                                               RenderModeType                                                                   .renderModeFit,                                                           sourceType:                                                               VideoSourceType                                                                   .videoSourceScreen,                                                         ),                                                         connection:                                                             RtcConnection(                                                           channelId:                                                               rtcChannelName,                                                         ),                                                       ),                                                     ),                                                   ),                                                 );                                               },                                             ),                                           ),                                         ),                                       ),
why AgoraVideoView not working when using agoraRtcEngineEx but works on agoraRtcEngine? Is it still not working in web just like you said in the other issue? VideoViewController.remote also accepts agoraRtcEngine as parameters and not agoraRtcEngineEx is that the reason why its not working?

@danilo1998271
I think you also need to set the localUid for the RtcConnection.

@littleGnAl can you clarify i still got this error even if i updated to the latest version and followed the instructions given in here https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK?tab=readme-ov-file#web-alpha

@littleGnAl i already updated to iris_web to 0.8.0 can i ask why it still has this errors?

@danilo1998271
Please file a new issue to keep track of these APIs that are not supported, we will implement them when we have resources


[7.x] Modify the alias method to avoid ambiguity

The original alias method is misleading.

The original alias method is misleading

You forgot to update the PHPDoc comment.

It's currently correct.


ASCII Problem

I was downloading this course: https://www.udemy.com/the-complete-react-native-and-redux-course/ and for some reason it gives a error when trying to download lecture 33 from the 7th Section.
Here is the error:
Traceback (most recent call last):   File "udemy-dl.py", line 924, in <module>     main()   File "udemy-dl.py", line 856, in main     udemy.ExtractAndDownload(path=outto, quality=res)   File "udemy-dl.py", line 413, in ExtractAndDownload     _is_converted = vtt2srt.convert(lecture_name)   File "/home/wecarrasco/Descargas/UdemyDl/udemy/_utils.py", line 246, in convert     _textcontainer   = '{}'.format(line) UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 44: ordinal not in range(128)

@wecarrasco thanks for the report will fix this ASAP.


Add address components to Spot

As stated by @railsondhi:
Is there a way we can improve the address_components attribute? Right now it just returns an array of components (eg street address, city, postal code, province). Right now we're leaving it to the end user to get their necessary data from the array, but wouldn't it be nice if this gem had attributes like street_address, city, postal code, and province so we make less work for the end user? Problem is not every Spot has their components organized in the same way. One Spot could have address_components[1] be "city," and another Spot could have it be "road." Silly design from Google.

I believe this is already in the code, here: https://github.com/marceldegraaf/google_places/blob/master/lib/google_places/spot.rb#L82-86
@technologythree can you confirm?

Yay Works!!!! Thanks


Prefix countRepresentedWords with underscore [NFC]

An incidental issue uncovered while reading through the code for other reasons:
Per comments, countRepresentedWords is slated for eventual removal along with _word(at:). It's not a part of SE-0104. Therefore, let's show users that it's not intended for public consumption.
Interestingly, all current uses of the API in the Swift project itself are for implementing _word(at:) or calling _word(at:).

/cc @moiseev

Interestingly, all current uses of the API in the Swift project itself are for implementing _word(at:) or calling _word(at:).

@swift-ci please test source compatibility

@CodaFi These integers were only introduced in 4.0, so there should be no 3.0 code that could use it. And hence no compatibility problems =)

@xwu Thanks!

@swift-ci Please test and merge


Possibility to retag docker images

From docker 1.4 requires to pass a param to be able to retag images. This https://github.com/drone/drone/pull/782 doesn't really solve fully the problem.
We always push to the docker hub the latest image with the branch tag, so we can always pull the latest successful image of a given branch from the repo easily, docker pull repo/image:master instead of using the git hash
We have something like this in the .drone.yml
publish:
    docker:
  ...
        tags: [$(echo $DRONE_BRANCH), $(git rev-parse --short HEAD)]
        force_tags: true

thanks for this! looks like the unit test needs to be updated, and then we'll be able to merge.

yeah, I just saw that, I will try to update them
On Fri, Jan 30, 2015 at 9:24 AM, Brad Rydzewski<EMAIL_ADDRESS>wrote:

thanks for this! looks like the unit test needs to be updated, and then
we'll be able to merge.
—
Reply to this email directly or view it on GitHub
https://github.com/drone/drone/pull/862#issuecomment-72163814.

@bradrydzewski could you merge this please?

:+1:

@ilbambino Could you add this option flag to the docs? drone/docs


Feature Request: Add "Delete Button" behind a row or at the right side

Feature Request
Currently, it is only possible to delete a row/document by "right-clicking it on the left nav-menu > delete document". Maybe there should be another button at the end of the row or on the right side, to faster delete the menu"
Screenshot

Hey I think the delete button on the editor pannel should be good. But it will not solve your case when you want to delete mass amount of documents

Hey I think the delete button on the editor pannel should be good. But it will not solve your case when you want to delete mass amount of documents

What happens when you delete an entire collection? Is every document in there deleted aswell?

Yes, when we delete the collection, all its children gone also

Okay then this can be closed


finish wcoss2 setup

Fixes #359

Which Python are you using on acorn? If that Python version works, then there is no need to change anything

On Sep 29, 2022, at 10:52 AM, Hang-Lei-NOAA @.***> wrote:
@Hang-Lei-NOAA commented on this pull request.
In configs/sites/acorn/compilers.yaml https://github.com/NOAA-EMC/spack-stack/pull/362#discussion_r983792682:

@@ -14,9 +14,27 @@ compilers:
- intel/<IP_ADDRESS>4
- craype/2.7.13
environment:

 prepend_path:

   PATH: '/opt/cray/pe/gcc/11.2.0/snos/bin'

I tested it on acorn. But did not try miniconda python 3.9. I will do one more test on it. We can use gcc/10 if 11 doesn't work.
—
Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/spack-stack/pull/362#discussion_r983792682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RL22FOSGHLBIJMCAKTWAXCLFANCNFSM6AAAAAAQY6QDG4.
You are receiving this because your review was requested.

It is python/3.8.6
On Thu, Sep 29, 2022 at 12:55 PM Dom Heinzeller @.***>
wrote:

Which Python are you using on acorn? If that Python version works, then
there is no need to change anything

On Sep 29, 2022, at 10:52 AM, Hang-Lei-NOAA @.***> wrote:
@Hang-Lei-NOAA commented on this pull request.
In configs/sites/acorn/compilers.yaml <
https://github.com/NOAA-EMC/spack-stack/pull/362#discussion_r983792682>:

@@ -14,9 +14,27 @@ compilers:

intel/<IP_ADDRESS>4
craype/2.7.13
environment:

prepend_path:
PATH: '/opt/cray/pe/gcc/11.2.0/snos/bin'
I tested it on acorn. But did not try miniconda python 3.9. I will do
one more test on it. We can use gcc/10 if 11 doesn't work.

—
Reply to this email directly, view it on GitHub <
https://github.com/NOAA-EMC/spack-stack/pull/362#discussion_r983792682>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AB5C2RL22FOSGHLBIJMCAKTWAXCLFANCNFSM6AAAAAAQY6QDG4
.
You are receiving this because your review was requested.

—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-EMC/spack-stack/pull/362#issuecomment-1262548161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKWSMFAHGCE7PE3IKBIFCPLWAXCVZANCNFSM6AAAAAAQY6QDG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

It is python/3.8.6 On Thu, Sep 29, 2022 at 12:55 PM Dom Heinzeller @.***> wrote:
…

Ok, then I think you should be fine.

@AlexanderRichert-NOAA @edwardhartnett Please review @Hang-Lei-NOAA 's PR and approve if happy. Thanks!

@Hang-Lei-NOAA @AlexanderRichert-NOAA What should we do with this PR, has it gone stale? Please revive and get ready to merge, or close as "not planned". Thanks!

@Hang-Lei-NOAA @AlexanderRichert-NOAA What should we do with this PR, has it gone stale? Please revive and get ready to merge, or close as "not planned". Thanks!

@Hang-Lei-NOAA Do you have a fully working spack-stack installation of UFS deps on Acorn? If not then I want to merge in my changes to the Acorn config (I think the main thing is adding the libfabric module).

@Alexander Richert - NOAA Affiliate @.***> Please
merge your changes to the Acorn config.
On Wed, Dec 28, 2022 at 6:56 PM Alex Richert @.***>
wrote:

@Hang-Lei-NOAA https://github.com/Hang-Lei-NOAA @AlexanderRichert-NOAA
https://github.com/AlexanderRichert-NOAA What should we do with this
PR, has it gone stale? Please revive and get ready to merge, or close as
"not planned". Thanks!
@Hang-Lei-NOAA https://github.com/Hang-Lei-NOAA Do you have a fully
working spack-stack installation of UFS deps on Acorn? If not then I want
to merge in my changes to the Acorn config (I think the main thing is
adding the libfabric module).
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-EMC/spack-stack/pull/362#issuecomment-1366987272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKWSMFHP3YOU44JIYESCJK3WPTHRZANCNFSM6AAAAAAQY6QDG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can we close this, now that https://github.com/NOAA-EMC/spack-stack/pull/428 is merged?


Add custom local storages to sdk dbtool

To rollback the storage or to check its version for test purposes it is possible to use the dbtools of the SDK.
To interact with the dbtools we need to execute the executable file of the tool called (at the time of writing) sidechain-sdk-dbtools-0.3.4. The list of the local storages name is defined in the DbTool java file of the executable file, it contains only the names of the common storages (common to all sidechains) and the Simple App storages. This list can't be changed or updated at runtime.
it would be helpful to have the ability to update this list for example providing them as CLI arguments of the application.

Furthermore: we should update the testing framework to be able to invoke the dbtools with these new additiona parameters, to allow apps to use it in python tests


Build: Remove token permissions button

No longer needed as this is visible in the toolbar above.

Logout too...

Fixed in https://github.com/conix-center/ARENA-core/commit/b52448f06950ce96ea8ae6d29fbe5df058768d71


stable/spinnaker

Describe the bug
The imageTag field for minio doesnt work. Nomatter the tag, it always picks RELEASE.2018-08-25T01-56-38Z as tag.
Version of Helm and Kubernetes:
K8s: 1.12
Helm: v2.14.0
Which chart:
stable/spinnaker
What happened:
Minio always installing with a fixed tag.
What you expected to happen:
Minio installs with the new tag
How to reproduce it (as minimally and precisely as possible):
Try deploying the helm chart for spinnaker, with minio.imageTag : RELEASE.2019-05-23T00-29-34Z
Anything else we need to know:

the chart is generating:
  image:
    pullPolicy: IfNotPresent
    repository: minio/minio
    tag: RELEASE.2018-08-25T01-56-38Z
  imageTag: RELEASE.2019-02-13T19-48-27Z


Range for goto definition response

Location of a symbol for "goto definition" isn't always the word on a given location, so it makes sense to also return optional Range value in response, similar to Hover, so IDEs can highlight the actual symbol that represents a reference, not just a single word.
Here's an example from my experience:
using package.Module.Type;

Here package.Module.Type is the atomic symbol, language doesn't return positions for concrete words here, but for the whole type path instead. However VS Code underlines each word separately, which can be a little confusing to the user, since each of them will point to the same position.
Hence it would be nice to be able to indicate a real symbol's position for highlighting in the IDE.

Good suggestion.

Need to move that due to time constraints.

@nadako I looked into this and the definition request returns Location | Location[] where Location is defined as follows:
export interface Location {
    uri: string;
    range: Range;
}

I must be missing something.

Field 'range' is for target location. This issue is to add new 'range' for place where go to definition was triggered e.g. method invocation. To underline this range.

@mniewrzal can you outline the use case. Is it when a user selects some text beforehand and triggers the definition request that selection should be taken ?

Yes, its exactly the case you described.

Right now client needs to calculate this range (to style text in editor) on its own. Different languages can have different word/variable/identifier definition and it will be hard to prepare one implementation to handle all cases. If it will be on server side the range will be always accurate for language.

@mniewrzal thanks for clarification. I think adding a range to the Goto Definition response is not a good idea. Since it describes the target location.
VS Code current takes the word definition to highlight the link. IN our case is '/' not a word separator.
To make this more flexible I think we should have a separate API to calculate this 'link' range instead of folding it into the result of Goto Definition.

@mniewrzal the idea right now is to have a separate request.

We now have LocationLink https://github.com/Microsoft/vscode-languageserver-node/blob/master/types/src/main.ts#L2400


Shorten the animation when servants or enemies dead

Hello,
I know there is almost a エネミー消滅短縮 option in the battle menu on the JP server.
But I hope you can add the function that can shorten or skip the exit animation of  enemies or servants for other servers.
I think that is very easy to implement by just keeping clicking  a region before a new round comes.

https://github.com/29988122/Fate-Grand-Order_Lua/commit/4e6925760c22cf97a7b286171e15ec4cd325add2
Add a line
UnstableFastSkipDeadAnimation = 1

anywhere in your```FGO_%server%_REGULAR.lua, and you're good to go.
Unfortunately Lua is a single-threaded programming language, thus I (likely) cannot set up a watcher to check every second if we finished battle animations or not. Our current way is time counting, plain and simple.
That means - if you killed enemies real fast, the script could be still clicking, thought it was still skipping dead animations, wasting time; if you killed them slow, the clickings could be already finished, animations not skipped.
Feel free to change line 300~ in regular.lua to fit your need.
Not really useful though...
Can't really insert screen recognition every second, your phone and battery will die QQ


Merge ign-gazebo6 ➡  gz-sim7

➡  Forward port
Port ign-gazebo6  ➡  gz-sim7
Branch comparision: https://github.com/ignitionrobotics/ign-gazebo/compare/gz-sim7...ign-gazebo6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Keeping it as draft because there are features mixed in, and we're in feature freeze. I'm going to cherry-pick #1643 which is a bug fix I need on Jammy.


Potential implementation for a formatting standard

About
This commit potentially implements a formatting convention on all rust files.
I found that my editor automatically ran rust format on any file that I saved.
My main question is: "Would this be something that this project needs?"
Commits

Ran rustfmt on all rust files.

This would be nice if my editor also had the same settings, maybe the PR should include a standard rustfmt.toml instead


feat: Added all inital pages with navbar links

Context

This pull request addresses issue #7 - the need for a basic structure and navigation within the SMARTJ web application. The changes are focused on creating the initial pages and setting up a functional navbar that allows users to navigate between these pages. This foundational work is necessary to start building out the core features of the application.
Closes #7
What Changed?

Created the following pages:

Home: The landing page of the application.
Interview Practice: A page where users can practice interview questions.
Job Finder: A page dedicated to finding job opportunities.
Contact Us: A page where users can get in touch with the team.
My Profile: A user profile page where users can view and edit their information.

Implemented a responsive navbar:

Links to all the newly created pages.

Integrated basic Bootstrap styling for consistency and responsiveness.

How To Review

Start by reviewing the structure of the App.js file to see how the routes and navbar are implemented.
Check the newly created pages in the pages directory:

Home.js
InterviewPractice.js
JobFinder.js
ContactUs.js
MyProfile.js

Test the navigation flow by clicking through the navbar links to ensure all pages are accessible and the layout is responsive.

Testing

Manually tested the navigation to ensure all links in the navbar work as expected.
Verified that the pages load correctly and display the appropriate content.

Risks

Ensure that the routing is set up correctly and that there are no broken links or errors when navigating between pages.
Consider any potential issues with responsiveness or accessibility that might need addressing.

Notes

Future updates will involve adding functionality to these pages, such as interactive components on the Interview Practice page and job search filters on the Job Finder page.

Looks good to me, works as expected. Thanks for setting up the initial pages and setting up the navbar.


Support of Bing AI (GPT4) would be great as well

Would be a cost free alternative to OpenAI's API.

Hey, @codingbutstillalive!
Unfortunately, Microsoft is not providing an API for their Bing AI. There are some projects handling it the hacky way. But I will wait for the official release. Thanks for your idea!


Docker installer artifact installs a very old version

Instead of using the outdated install script, try this:
wget -qO- https://get.docker.com/ | sh

Thank you for your input. Feel free to contribute the changes and we'll be happy to validate it and merge it into the public repo.

Fixed


Implement LogSaver

Is your feature request related to a problem? Please describe.
Log files get full very quickly due to various reasons.
LogSaver would monitor log file used space, and would have the capability to take preventive action based on the defined threshold.

LogSaver has been implemented. Below objects created for same -

Procedure dbo.usp_LogSaver on each server
SQL Agent job (dba) Run-LogSaver on each server
Updated inventory server procedure dbo.usp_GetAllServerCollectedData with data population logic into table dbo.sql_agent_jobs_all_servers
Updated inventory server procedure dbo.usp_wrapper_GetAllServerCollectedData with data population logic into table dbo.sql_agent_jobs_all_servers
Added a panel Log Space Utilization - Require ATTENTION on All Servers dashboard.

No further action required.


The right hand side of editor is somehow highlighted

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69
OS Version: MacOs monterey 12.4

I just opened the editor and saw the right side of editor is highlighted, this happens for all dark themes.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I'm seeing the same after updating to 1.69

/duplicate of #152816

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


help(build): ./ci/do_ci.sh: Permission denied

when I try to build a dev version, I got this error:
[root@instance-1 envoy-1.13.0]# pwd
/root/envoy-1.13.0
[root@instance-1 envoy-1.13.0]# ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev'
bash: ./ci/do_ci.sh: Permission denied
[root@instance-1 envoy-1.13.0]# ll ./ci/do_ci.sh
-rwxrwxrwx. 1 root root 14138 Jan 20 22:06 ./ci/do_ci.sh

[root@instance-1 envoy-1.13.0]# uname -r
3.10.0-1062.9.1.el7.x86_64
[root@instance-1 envoy-1.13.0]# cat /etc/redhat-release
CentOS Linux release 7.7.1908 (Core)

[root@instance-1 envoy-1.13.0]# docker version
Client:
 Version:         1.13.1
 API version:     1.26
 Package version: docker-1.13.1-108.git4ef4b30.el7.centos.x86_64
 Go version:      go1.10.3
 Git commit:      4ef4b30/1.13.1
 Built:           Tue Jan 21 17:16:25 2020
 OS/Arch:         linux/amd64

Server:
 Version:         1.13.1
 API version:     1.26 (minimum version 1.12)
 Package version: docker-1.13.1-108.git4ef4b30.el7.centos.x86_64
 Go version:      go1.10.3
 Git commit:      4ef4b30/1.13.1
 Built:           Tue Jan 21 17:16:25 2020
 OS/Arch:         linux/amd64
 Experimental:    false

Try this and then build again:
mount -o remount,exec /tmp
The run_envoy_docker.sh creates a build dir in /tmp and I bet CentOS mounts tmp with the noexec flag to disallow executing from /tmp for security reasons.

It works fine under Ubuntu OS  18.04 :(
It seems I have to change my working OS.

@membphis glad you got it working. Do you want to close the issue?

many thx


Edit pass over existing iOS contents

Validation Status: Successful
JobID: 9be504b1-6331-4a7c-b552-b694ccdc2e2d

Articles to review
The articles impacted by this PR were staged review at:

http://taco.visualstudio.com/en-us/docs/ios-guide/


Format Document doesn't work when .ts file has {tab}{tab}/*{tab} in it

Issue Type: Bug
With the below code in a file named bug.ts, pressing Shift+Alt+F does not format the document. If I delete one of the three tabs, then it does format the document.
		function foo() {}
}
	/*

*/

VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:10:15.214Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz (4 x 2394)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.91GB (1.95GB free)

Process Argv
--disable-extensions --crash-reporter-id f6d40bd1-e748-48ce-9355-576b0aa9ce40

Screen Reader
no

VM
44%

Extensions disabled
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwtct:30329789
pythonvssor306:30344512
bridge0708:30335490
pygetstartedc2:30351386
vstre464:30350172
bridge0723:30353136
vsdyn321cf:30354108

Can you please revise the code example as markdown formatting messed up the original. I tried adding a fenced code block but it still looks weird

Also does this reproduce in the latest VS Code insiders build with all extensions disabled?

That code doesn't appear to be valid

Behaves the same on insiders build with extensions disabled.
It happened on a large file with valid code- I pared it down to this to isolate the problem.

Please share a valid, self contained  code sample that demonstrates the problems

		function foo() {
}
	/*

*/


Improvement: Search Feature for help expensify

As per the last discussion with @marcochavezf here we are using XML Configuration to handle the Search Feature

Make related components & add gse script
Configure CSP for each inline script
Styling related components
Add relevant setup (Annotations, & Context)

Additional context:

The initial state of https://help.expensify.com/ is having errors on CSP. This PR handles that also.
There's an unrelated error from Google inline script that is related to ads async-ads.js. It's not affected the functionality & already hides the ads anyway.

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23978
PROPOSAL: https://github.com/Expensify/App/issues/23978#issuecomment-1659762731
Tests

Open https://help.expensify.com/
Click Search Icon to open the Search sidebar
On the Opened Search Sidebar Type the query you want to find & Press "Enter" or Click Magnifying glass icon
If there are results, They'll be shown on the list below it.
If there aren't, It'll show Upps no results found, Please try again....
To Clear the result click the X button on the search input.
To Close the Search sidebar, click the X button on the right side top of the Sidebar

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open https://help.expensify.com/
Click Search Icon to open the Search sidebar
On the Opened Search Sidebar Type the query you want to find & Press "Enter" or Click Magnifying glass icon
If there are results, They'll be shown on the list below it.
If there aren't, It'll show Upps no results found, Please try again....
To Clear the result click the X button on the search input.
To Close the Search sidebar, click the X button on the right side top of the Sidebar

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://www.loom.com/share/a50bac0d7ddd4cbf979c694f496b67eb?sid=21a610a0-7d87-4e98-b714-1d5aca004038

Mobile Web - Chrome
https://github.com/Expensify/App/assets/20473526/f1c51089-fa28-4f07-93f7-4e9b8b753770

Mobile Web - Safari
https://github.com/Expensify/App/assets/20473526/08bbaca4-be68-44cd-97a8-c54af5841977

Desktop

iOS

Android

I have read the CLA Document and I hereby sign the CLA

recheck

I have read the CLA Document and I hereby sign the CLA

@eVoloshchak, let me know if you have bandwidth to review it soon. I can jump into the review tomorrow

@studentofcoding thank you for raising the PR! Just one more thing, can you upload videos (instead of screenshots) of the search functionality in the screenshots/videos section? It would be required for design review since it involves different UI changes

@studentofcoding thank you for raising the PR! Just one more thing, can you upload videos (instead of screenshots) of the search functionality in the screenshots/videos section? It would be required for design review since it involves different UI changes

The videos are added @marcochavezf, thanks!

All resolved @marcochavezf

A couple of comments:
It looks like all of the content is cut off at the bottom.
Can you double check that the correct font is being applied to the smaller text under the links?
For the search button, we should just use our standard green button styles here. Same for the text input, can we make sure this matches what we have on NewDot?

It looks like all of the content is cut off at the bottom.
Can you double check that the correct font is being applied to the smaller text under the links?
For the search button, we should just use our standard green button styles here. Same for the text input, can we make sure this matches what we have on NewDot?

Done it all @shawnborton, here are the vercel staging for references https://xml-docs.vercel.app
cc : @marcochavezf

Are the screenshots updated?

Are the screenshots updated?

Yup all is updated

For this UI:

What does the green magnifying glass do? Do you only get search results when you press enter or press the icon?
We shouldn't be using the icon like this though, we should use our standard green button. We can put an icon inside of the button though.
@marcochavezf are there existing mockups that we're working off of?

Yes, as this is inline script from google, how it works is via Enter Key or Clicking the Magnifying Glass icon thus I think we should keep the icon there @shawnborton
On the Button change, could you share with me any ref of it?

This is what our buttons look like:

What about now @shawnborton?

The search input + button should look something like this:

The button is at 40x40, aligned to the baseline of the input. The icon inside of the button is at 16x16
The top header area does not use a "x" button, but rather just uses a back arrow to close. This is consistent with the rest of the NewDot app.

Done it all @shawnborton

Also the video are updated @shawnborton

Noted, are there any other else @shawnborton ?

Is there any other feedback on this @marcochavezf

@studentofcoding thanks for addressing the comments, let's wait for a final UI review. Meanwhile can you update the videos with the latest changes?

Just left a couple more comments. @marcochavezf can you review as well please?

All is updated @marcochavezf @shawnborton, and Videos are updated!

I checked the video and it looks like the input slightly jumps 1-2px when the cursor focuses:

Any ideas?

I checked the video and it looks like the input slightly jumps 1-2px when the cursor focuses:

Any ideas?

Ahh yes, It's should be static now, thanks @shawnborton

I checked the video and it looks like the input slightly jumps 1-2px when the cursor focuses:
Any ideas?

The Jump is fixed & videos are updated @shawnborton
cc: @marcochavezf

Great, thank you! Last thing, and sorry for not catching this sooner, but the close icon should be using our standard icon color (I think it's in the color vars file?) and on hover, it can just use our standard text color.

Great, thank you! Last thing, and sorry for not catching this sooner, but the close icon should be using our standard icon color (I think it's in the color vars file?) and on hover, it can just use our standard text color.

No Problemo @shawnborton, The fix is otw!

Great, thank you! Last thing, and sorry for not catching this sooner, but the close icon should be using our standard icon color (I think it's in the color vars file?) and on hover, it can just use our standard text color.

The Hover is fixed @shawnborton

Thank you! @marcochavezf feel free to do the final review.

Thank you! @marcochavezf feel free to do the final review.

Thank you too @shawnborton !

Let's go @marcochavezf
I'm so excited to finish it, lol!

@studentofcoding thanks for addressing the comments, let's wait for a final UI review. Meanwhile can you update the videos with the latest changes?

All UI Review is done @marcochavezf
I'll standby today to finish all the final feedback 😁

The code is looking great! 👍🏽 Just a few other minor changes

Done it all @marcochavezf

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

LGTM, thank you @studentofcoding!

Can you approve it again? There is lint error before and it's fix now @marcochavezf Thanks!

Hmm the Jest and perf checks already taking 15 mins ++ while I only running lint fix npm run prettier
Do I need to do anything @marcochavezf ?

Hmm the Jest and perf checks already taking 15 mins ++ while I only running lint fix npm run prettier
Do I need to do anything @marcochavezf ?

We'd just need to wait for the checks to pass

Details

Noted

Hmm the Jest and perf checks already taking 15 mins ++ while I only running lint fix npm run prettier
Do I need to do anything @marcochavezf ?

We'd just need to wait for the checks to pass

Noted, and after that, Do I need to merge it or it'll auto Merged @marcochavezf? As I'm already at 3 AM and wonder if I still have to standby
Thanks!

Finally the check is done.
If you still have time, Please kindly check approve it @marcochavezf 🙏🏻
Thanks

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.54-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Hey folks! I've noticed a few things that might have missed QA (or didn't explicitly get considered as "wrong")
Body text color is dark, but it should be bright to match the body text of the rest of the help site
When you misspell a word and get a suggested replacement, the color of the text that says, "Did you mean:" is dark (almost black), but shouldn't be. It should match the text color of the light body text of the rest of the help site.
Keep in mind, we should make sure that the text color will change when we give users the option to switch between dark mode and light mode.

Background color of the pagination is bright. It does not match the background color of the rest of the helpsite.
Keep in mind, we should make sure that the background color of the pagination will change when we give users the option to switch between dark mode and light mode.

CC @shawnborton

Hi @studentofcoding, while reviewing the new implementation, we noticed a few minor visual aspects (posted above by @johncschuster) that might need some attention. Can you create a follow-up PR to address those?

Hi, @marcochavezf sure thing!, Where do I need to connect the branch from, as I checked it's not on main yet. Do I need to connect it based on this PR branch?
And just a follow-up on this requirement Keep in mind, we should make sure that the text color will change when we give users the option to switch between dark mode and light mode.. As this is not based on the issue request, Will it extend the scope, or it's just a note and we can use the same variable color for now?
Thanks
@johncschuster

Noted @shawnborton, like this?

Yup, much better for the text.

PR opened : https://github.com/Expensify/App/pull/24598
@marcochavezf @johncschuster @shawnborton

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Mdx-Media-Mapper media with prohibited url design/UX

Summary
if an mdx file has an image/video with an unsupported url , what should the feedback to the user be?

Should the image be ignored (removed)?
Should we display an inline notification instead that let's the user know that that image can't be rendered due to an unsupported url (if so, what should the message say?)
Other UX?

Example:
File in github.com/organization/repo/path has image with src = '../../other-org/other-repo/other-path'. This will result in a combined url of:
github.com/other-org/other-repo/other-path which we do not support since it'd be getting information from a different repository from a relative URL
Use inline notif:

@francinelucca @andreancardona  First draft is here in this figma: https://www.figma.com/file/WyfqQh9R1VXYZErfmsNDVH/MDX-errors?node-id=0%3A1

LGTM! thanks @kingtraceyj


Remove default views feature

The default views feature is for a deprecated feature and no longer needed after its only reference is being removed in this pr: https://github.com/ManageIQ/manageiq-ui-classic/pull/8965

@miq-bot add_reviewer @Fryguy
@miq-bot assign @Fryguy
@miq-bot add-label technical debt


Parking after identification of parking spot

After the car has found its parking lot, the car will park itself

@Druner just a reminder that user story and acceptance criteria is missing.

removed 1 acceptance criteria, as it should be covered in #45


[gpuCI] Forward-merge branch-21.08 to branch-21.10 [skip ci]

Forward-merge triggered by push to branch-21.08 that creates a PR to keep branch-21.10 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

SUCCESS - forward-merge complete.


GPU tests: disable cusparse_lowering to avoid segfaults.

We've started seeing failures in the GPU CI jobs: https://source.cloud.google.com/results/invocations/8a57fcfe-439c-4fea-9434-ae71d017625e/targets/jax%2Ftesting%2Fcpu%2Fpresubmit_github/log
I suspect this is due to increased test coverage, and similar to the other cusparse-related GPU segfaults we've been seeing.

Hmm, looks like this wasn't the issue.
Now that I look more closely, it's the CPU test that's failing, not the GPU test.
I suspect it's probably a timeout rather than a cusparse issue.


By default, the "Secure transfer required" option is enabled instead of disabled

As titled, with the latest UI change of Ibiza portal, this option now is "enabled" by default. Also the screenshots needs to be updated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5197035-5db9-49c4-a709-82994d1e78e4
Version Independent ID: 1a73b577-4387-5dac-1e89-a41f811a9858
Content: Require secure transfer in Azure Storage
Content Source: articles/storage/common/storage-require-secure-transfer.md
Service: storage
GitHub Login: @fhryo-msft
Microsoft Alias: fryu

@forester123  " Secure transfer " is enabled by default - To add more info, To protect the data which is on transit, it’s always advisable to encrypt the data with the transport level encryption. This can be done with the HTTPS protocol. HTTPS ensure secure communication over public internet. Always enable secure transferred required to force the secure transit of data.
, I have assigned this for author for reviewing this and also for latest portal screen shot update.

Thanks for reporting this issue, @forester123

It's being addressed in https://github.com/MicrosoftDocs/azure-docs-pr/pull/58729

The change is live.

#please-close


Edge Services - Essential Business Functions sample UI 2108.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Prepare SDK for beta.5 release

Prepared all of the packages to be released as beta.5
@raosanat Please add changelog entries to the appropriate section headers in CHANGELOG.md, and set the release date.

/check-enforcer override