Unable to use this plugin

Hi, I usually am able to use this plugin but it starts to crash and shutting down homebridge. I only have this plugin installed on to my homebridge pi
[12/19/2019, 15:23:24] [homebridge-yeelight.yeelight] doing a round of proactive search for known devices.
[12/19/2019, 15:23:24] Error [ERR_SOCKET_CANNOT_SEND]: Unable to send data
at Socket.onListenError (dgram.js:507:22)
at Object.onceWrapper (events.js:300:26)
at Socket.emit (events.js:210:5)
at dgram.js:322:14
at processTicksAndRejections (internal/process/task_queues.js:81:21)
[12/19/2019, 15:23:24] Got SIGTERM, shutting down Homebridge...
Can anyone please guide me. It was working fine for the past weeks

Post your config.json

{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:xx:xx",
"port": 51826,
"pin": "031-45-xxx"
},
"description": "This is an example configuration file with one fake accessory and one fake platform. You can use this as a template for creating your own configuration file containing devices you actually own.",
"ports": {
	"start": 52100,
	"end": 52150,
	"comment": "This section is used to control the range of ports that separate accessory (like camera or television) should be bind to."
},
"accessories": [],

"platforms": [
	{
		"platform": "yeelight",
		"name": "Yeelight",
		"transitions": {
			"power": 400,
			"brightness": 400,
			"color": 1500,
			"temperature": 1500
		},
		"connection": {
			"retries": 5,
			"timeout": 250
		},
		"multicast": {
			"interface": "<IP_ADDRESS>"
		},
		"defaultValue": {
			"aed78s": {
				"name": "Kitchen",
				"blacklist": ["set_hsv"]
			}
		}
	}
]

}

Remove the defaultValue object, and give it a try.

It somehow working fine after 2 days. I am clueless but thanks a lot for the effort to look into my .json file


RangeError: Maximum call stack size exceeded

Hi, just upgraded to v7, here is my server.json:
{
  "public": "build",
  "rewrites": [{ "source": "/**", "destination": "/index.html" }]
}

and here is the error:
INFO: Discovered configuration in `serve.json`
INFO: Accepting connections at http://localhost:3000
(node:44) UnhandledPromiseRejectionWarning: RangeError: Maximum call stack size exceeded
    at String.replace (<anonymous>)
    at escapeString (/usr/local/lib/node_modules/serve/node_modules/path-to-regexp/index.js:208:14)
    at tokensToRegExp (/usr/local/lib/node_modules/serve/node_modules/path-to-regexp/index.js:304:19)
    at stringToRegexp (/usr/local/lib/node_modules/serve/node_modules/path-to-regexp/index.js:288:10)
    at pathToRegexp (/usr/local/lib/node_modules/serve/node_modules/path-to-regexp/index.js:370:10)
    at sourceMatches (/usr/local/lib/node_modules/serve/node_modules/serve-handler/src/index.js:31:22)
    at toTarget (/usr/local/lib/node_modules/serve/node_modules/serve-handler/src/index.js:47:18)
    at applyRewrites (/usr/local/lib/node_modules/serve/node_modules/serve-handler/src/index.js:75:18)
    at applyRewrites (/usr/local/lib/node_modules/serve/node_modules/serve-handler/src/index.js:78:11)
    at applyRewrites (/usr/local/lib/node_modules/serve/node_modules/serve-handler/src/index.js:78:11)
(node:44) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:44) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It's a CRA single page app, with index.html under /build folder. I need to rewrite everything to point to /index.html.
Is V7 production ready?
thanks!

Interesting. Thanks for reporting! I'll look into this first thing tomorrow.

Whoops - wrong button.


Certificate wait for removed Order resource on AKS

Describe the bug:
I had issue with DNS challenges for Letsencrypt on our AKS cluster. I hope it was already solved but Challenge and Order resource was still in stuck so I removed this resources for another renew attempt but I can still see in Certificate resource:
 Message:               The certificate request has failed to complete and will be retried: Failed to wait for order resource "acme-crt-9zf88-1093887857" to become ready: order is in "invalid" state:

acme-crt-9zf88-1093887857  was Order resource which was removed.
Could you pls somebody help me how to remove "waiting" certificate on removed resource and try another issuing ?
Thanks a lot for help
Environment details::

Kubernetes version: v1.17.11
Cloud-provider/provisioner: Azure AKS
cert-manager version: v0.16.1
Install method: helm

/kind bug

Problem solved. There was temporarry issue during Challenges.
So I have to remove invalid resources   : challenges,order and certificaterequests.
It was unblock request new cert.


Allow new lines during JSON generation

Motivation
By default, Outlines does not permit new lines and whitespace formatting during constrained JSON generation. Their rationale is that smaller models have a tendency to enter infinite generation loops otherwise. I have not observed this behavior with any recent smaller models (Llama 3.1 8B and Mistral 7B v3) rather we instead find material quality degradation, even with larger models (Llama 3.1 70B and Mistral Large 2) particularly when the JSON property is a list, and the number of elements is variable.
If you observe the natural generation behavior of these models, they emit syntactically formatted JSON and it strikes me a as a better default to permit such behavior.
Modifications
Modify the default Outlines whitespace regex to permit newlines and additional whitespace.

While this change doesn't impact the issue, one thing to note is that with non-constant whitespace like the regexes generated from schemas or pydantic models, the jump-ahead optimization ends up doing nothing. Having predefined spacing (pretty-printed or compressed) will run much faster. If that reduces quality/accuracy, instructing or fine-tuning models to produce either standard pretty-printed or compressed formatting can help.

Is it truly the case that it would do nothing? It definitely seems that it would reduce the number of jump-ahead opportunities but ultimately once the model has completed whitespace generation, it would still kick in? I have not dug into the implementation, and we are just now starting to evaluate the performance impact. Will report back with empirical results.
That said, I can strongly attest to the fact that restricted whitespace generation greatly reduces quality of larger SOTA models (we have tested basically everything short of L3 405). Ideally of course the jump-ahead would be pretty print aware, but at the very least is seems reasonable to expose a quality vs performance tradeoff to users. The alternative is to make this a per-request parameter, which seemed less desirable to us at first glance.

It's true that jump-ahead will still kick in for field names, etc., but it is common for whitespace to account for a large chunk of the generated tokens. I'm a user, not an sglang developer, so they may have more insight, but in our usage we've seen 30%+ speed increase from using fixed spacing in JSON regexes.
FWIW, for our use case we ended up ditching JSON generation and instead use a free-text user/assistant chat structure that asks for the relevant fields (sometimes in parallel forks) and composing the JSON from the output ourselves, and at least for smaller models we've gotten much better quality output that way.

Yes, this very much I agree with and it's been well studied that JSON generation reduces overall quality (observed on 4o and 3.5 Sonnet). Constrained generation is still very much a trade off, but what we have found is that prompting to "build a list" to elicit data extraction followed by a constrained generation phase is the happy medium.


Does MSAL support authentication within Chrome extensions?

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
tl;dr
Does MSAL support authentication within Chrome extensions using the chrome.identity.launchWebAuthFlow api? Link: https://developer.chrome.com/apps/identity#method-launchWebAuthFlow If so, how so? If not, would you be open to a contribution/PR to do so?
Long version
I'm writing a plain, vanilla, JS Chrome extension and I'd like to add MSA authentication to it. I started experimenting with MSAL to do this but ran into a few troubles. The first one was while configuring my AAD App registration: The Single-page Application Platform Type only supports redirect uris with https (or http) schemas. Chrome extensions require a chrome-extension:// redirect uri schema. Fortunately, I found that I could add a Mobile and Desktop Platform Type to the App Registration and supply the needed style/schema of redirect url there. Unfortunately, even with this work-around I ran into trouble. This time during the auth code/token exchange I believe. MSAL began throwing an error that read something like 'cross-origin token exchanges are only allowed in Single-page Application client types'. This issue lead me to investigate, and discover, how Google supports external authentication within Chrome extensions and that's through the chrome.identity.launchWebAuthFlow api mentioned above.
The launchWebAuthFlow api takes the first url used in the authentication flow along with a callback function that's called when a redirect from the auth flow is received. Upon execution the api call causes Chrome to render a new popup using the login url that you provided. Chrome then supports redirects for your extension through https://.chromiumapp.com/*. When a redirect is received at that url it calls your callback function and provides the full url of the redirect as a parameter (which you can then parse and proceed with the authentication).
I put together a crude proof-of-concept that suggests that this approach/flow would work with MSAL but the approach doesn't seem to be supported within MSAL currently. I think you'd need two new functions on IPublicClientApplication to support this. One that works similar to loginRedirect but just returns the url to kick off the authentication flow instead of trying to redirect the current page and another that works similarly to handleRedirectPromise but takes the hash of the redirect url received in the launchWebAuthFlow callback method. This brings me to my question above: Is Chrome extension authentication supported in MSAL through the chrome.identity.launchWebAuthFlow api (or some other way that I'm not seeing)? If so, how so? If not, would you be open to a contribution/PR to do so?

@blinard Thanks for the information!

The Single-page Application Platform Type only supports redirect uris with https (or http) schemas. Chrome extensions require a chrome-extension:// redirect uri schema.

Correct. I'll see if chrome-extension protocol can be added to that list. cc: @hpsin

One that works similar to loginRedirect but just returns the url to kick off the authentication flow instead of trying to redirect the current page

We added this in v1 (#1691), but have yet to port this to v2 (I can put up a PR for this).

and another that works similarly to handleRedirectPromise but takes the hash of the redirect url received in the launchWebAuthFlow callback method

handleRedirectPromise now takes in a hash value to process.

This brings me to my question above: Is Chrome extension authentication supported in MSAL through the chrome.identity.launchWebAuthFlow api (or some other way that I'm not seeing)? If so, how so? If not, would you be open to a contribution/PR to do so?

We have not tried it, but I'll put together sample to see if it is possible (along with the changes from #1691).

Right now we don't suggest using the SPA type for extensions, as the RTs expire in 24 hours.  The best current method to support browser extensions is to register as a native application, and then use a domain you own to acquire the tokens.  Give your extension rights to read traffic on that domain, and use that to read the code from the browser bar.
Follow this discussion as well here:
https://github.com/MicrosoftDocs/azure-docs/issues/62164

Thanks for the feedback @jasonnutter and @hpsin. That's an interesting approach with registering as a native app and leveraging my own domain for the auth/tokens; I'll do some investigation in that direction. I noticed the 24 hour RT issue for SPAs and have been thinking about how I was going to handle that; I was hoping I'd be able to do a silent auth flow with the identity.launchWebAuthFlow Chrome Api but it sounds like the person on the other thread that you mentioned ran into some trouble with that approach too. That makes the native app registration approach look even more attractive.

You should be able to set chrome-extension as a redirect URI for the native apps too (manually set it in the manifest rather than use the portal UX) - then the code will be sent to your app. The reason I suggest use of your own domain is so that you can benefit from SSO.  Chrome's chrome.identity.launchWebAuthFlow opens a webview that is missing cookies, to our understanding, which means the user has to type in their username and password again, which is not the optimal experience for them.

@blinard I was able to test out MSAL.js v2 with chrome.identity.launchWebAuthFlow and changes in the linked PR, and it appears to work. I'll include a doc and/or sample demonstrating how to set this up.

@blinard Linked PR includes work sample using MSAL Browser and the launchWebAuthFlow APIs.


[DEVOPS-404] cardano-1.0 docker image

Ok, Fine. For testnet, subscribing to 3 public relays is fine, since there's no load anyway. For mainnet I'd prefer exchanges to subscribe to relays where we have better control over AZs (for redundancy) and relays that are lightly loaded (for QoS).

That's the plan as part of DEVOPS-424


Collection of vulnerable Windows drivers

Two years ago, I started a private repository containing a lot of vulnerable Windows drivers. It was meant to be a side project of mine and never became something similar to LOLDrivers. I thought I could help you with your project by making it publicly accessible https://github.com/VoidSec/VulnerableWindowsDrivers
Most drivers have a corresponding (SHA256) hash, signer, and brief description. Drivers that don’t have a hash appended to their name were “new” and never categorized (e.g. the notorious DELL dbutil_2_3.sys - CVE-2021-21551)
Let me know if there's anything I can help you with :)

Thank you for this @VoidSec ! We are using this to test enrichment now and will include in the project! We will credit you. Thank you!

Cool! Let me know if there's any way I can help you with the project :D

Appreciate this @VoidSec ! We have a bunch of enhancements coming out and this really helped with getting the binaries moved to the repo. Thank you!


fixes data-race between Get() and Close() of channelPool

the channelPool.factory modifying need to hold the mutex

Hi @fatih ,
This issue is found by go test -race -run=TestPoolConcurrent3 that make some unittests failed in other repo. Could you review this pr? Thank you.

Thanks @lrita. I receive a lot of emails, feel free to ping me always if I miss it :)


Add CI pipeline and MIT license

cool! thanks for doing this. i havent touched this repo in a long time but I don't think any of these changes can hurt. please add the 2 deleted items back into .gitignore though because I think they were needed for build

Oops, sorry about that, and yes those are valuable so I don't accidentally upload local data.  Here you go!

Thanks @ddugovic !


Vault Issuer: The CA full chain is not included into the ca.pem

Hi everyone!
TL;DR: The intermediate CA is included in the tls.crt and not into the ca.pem. Just wondering if that's on purpose and why? Is this not a problem? What is the motivation regarding this decision?
Following a conversation an slack with @SgtCoDFish we concluded that is worth opening a new issue about this problem that has already been reported several times:

https://github.com/cert-manager/cert-manager/issues/2166 (I was the one who actually opened it 3 years ago :sweat_smile: )
https://github.com/cert-manager/cert-manager/pull/3340
https://github.com/cert-manager/cert-manager/pull/3433
https://github.com/palimarium/istio-vault-ca/issues/4

How to reproduce?
I followed the steps described in this documentation so that I have a working environment with cert-manager and the ClusterIssuer configured properly.
So I have a provision certificate within the secret foobar-tls.

The ca.pem only includes the Root CA

kubectl get secrets foobar-tls -o jsonpath="{.data.ca\.crt}" | base64 -d | openssl x509 -noout -text|grep Subject:
Warning: Reading certificate from stdin since no -in or -new option is given
        Subject: C=FR, ST=France, L=Paris, O=Ogenki, CN=Ogenki<EMAIL_ADDRESS>

The Intermediate CA is included into the tls.crt

bash extract_certs.sh |grep Subject:
        Subject: C=France, O=Ogenki, CN=foobar.priv.cloud.ogenki.io
        Subject: O=Ogenki, CN=Ogenki Vault Issuer
        Subject: C=FR, ST=France, L=Paris, O=Ogenki, CN=Ogenki Intermediate<EMAIL_ADDRESS>
The verification failed
kubectl get secrets foobar-tls -o jsonpath="{.data.ca\.crt}" | base64 -d > /tmp/ca.pem
kubectl get secrets foobar-tls -o jsonpath="{.data.tls\.crt}" | base64 -d > /tmp/tls.pem
openssl verify -CAfile /tmp/ca.pem /tmp/tls.pem
C=France, O=Ogenki, CN=foobar.priv.cloud.ogenki.io
error 20 at 0 depth lookup: unable to get local issuer certificate
error /tmp/tls.pem: verification failed

How does it behaves with Vault?
I ran the following test in order to double check that Vault has the proper information by creating a certificate using the command line

creating a certificate using vault

vault write -format=json pki_private_issuer/issue/pki_private_issuer common_name="foobar.priv.cloud.ogenki.io" ttl="720h" > data.json
extract the CA chain and the certificate
jq -r '.data.ca_chain[]' data.json > vault_ca_chain.pem
jq -r '.data.certificate' data.json > foobar-cert.pem
verify
openssl verify -CAfile vault_ca_chain.pem foobar-cert.pem
foobar-cert.pem: OK

Check each certificate within the CA chain
extract_certs.sh

#!/bin/bash

# Filename of your CA chain
CA_CHAIN="vault_ca_chain.pem"

# Split the CA chain into individual certificates
csplit -z -f cert- ${CA_CHAIN} '/-----BEGIN CERTIFICATE-----/' '{*}'

# Loop through each certificate and display its details
for CERT in cert-*; do
    echo "Displaying ${CERT}"
    openssl x509 -in "${CERT}" -text -noout
    echo "-------------------------------------------"
done

Display the issuers present in the CA chain

bash extract_certs.sh |grep Subject:
        Subject: O=Ogenki, CN=Ogenki Vault Issuer
        Subject: C=FR, ST=France, L=Paris, O=Ogenki, CN=Ogenki Intermediate<EMAIL_ADDRESS>        Subject: C=FR, ST=France, L=Paris, O=Ogenki, CN=Ogenki<EMAIL_ADDRESS>
So, as we can see, the difference is the location of the intermediate certificate.
Environment details::

Kubernetes version: 1.28
Cloud-provider/provisioner: EKS
cert-manager version: 1.13.3
Install method: Flux

/kind bug

Sorry for misunderstanding this when we discussed it on Slack!
I've written an entry in the website's FAQ to describe some of the issues we see with ca.crt which should hopefully motivate why it can be tricky to use correctly. Does the PR make sense?
To be crystal clear, the behaviour we'd expect is:

tls.crt contains the leaf and any intermedates, but not a root.
ca.crt contains a best-effort guess at some issuer in the chain - often a root, sometimes an intermediate cert.

Thank you for clarifying in the FAQ your decision. However, in the case of the Vault issuer, honestly I don't understand why that wouldn't be easier to just take its output where the ca_chain is explicitly provided:
{
  "request_id": "7bfd9642-383d-0e68-c397-8365956d6eb3",
  "lease_id": "",
  "lease_duration": 0,
  "renewable": false,
  "data": {
    "ca_chain": [
      "-----BEGIN CERTIFICATE-----\nMIICQ...\n-----END CERTIFICATE-----",
      "-----BEGIN CERTIFICATE-----\n...xLOG\n-----END CERTIFICATE-----"
    ],
    "certificate": "-----BEGIN CERTIFICATE-----\nMIIC5jCCA...\n-----END CERTIFICATE-----",
    "expiration":<PHONE_NUMBER>,
    "issuing_ca": "-----BEGIN CERTIFICATE-----\nMIICQ...\n-----END CERTIFICATE-----",
    "private_key": "-----BEGIN RSA PRIVATE KEY-----\nMIIEowIBAAKC...\n-----END RSA PRIVATE KEY-----",
    "private_key_type": "rsa",
    "serial_number": "4xxx"
  },
  "warnings": null
}

Am I missing something?

I think the certificate secret content should be independent of the issuer used to issue the certificate. And @SgtCoDFish answered well our expectations. Could the additional output formats feature be extended to support the format(s) you expect?

Ok, I re-read the FAQ and understand what is meant and the reasons behind this decision. Will have to find a good way to load the CA chain inside my docker by another means, sorry for disturbing this convo

@Smana @UXabre, I am going to close this issue now. Feel free to reopen if you think this issue is still relevant (for cert-manager). We have tried to answer out your questions and explained the rationale behind the decision to keep the UX for various issuers in cert-manager consistent.
/close


Is it possible to remove the display of row name column?

In other words is there an option such as index=False in df.to_csv(path, index=False)?
Thanks a lot for the wonderful and very useful wrapper!
Marko

Sorry I don't believe there is a way to do this currently.  You'll have to remove the column from the DataFrame if you don't want it to appear in the grid.  This would be a nice convenience feature to add though, so thanks for filing the issue.

Thanks. Is there a way to remove it from the DataFrame? If I understand correctly the row name qgrid column is not a DataFrame column.

I may have misunderstood the question.  Can you look at the sample notebook here and tell me if either of the examples there have the problem you're talking about? http://nbviewer.jupyter.org/gist/TimShawver/b4bc80d1128407c56c9a
I'm guessing the second example might be what you're talking about, i.e. how a numbered "index" column appears when your DataFrame is lacking an index.  You'll notice that the column is also in the default rendering of the DataFrame though, so it's the correct behavior by Qgrid.  It's impossible to have a DataFrame without an index, so when you don't specify one yourself, pandas adds one for you.
It might be that the workaround for your specific issue would be to use one of the existing columns in the DataFrame as the index.  This stackoverflow article shows how to set the index of your DataFrame to an existing column.

The point is that other dataframe display methods (e.g. to_html()) accept a parameter (index=False) which hides the index column in the resulting html (which you can then render in the notebook using display()).  It would be good if qgrid allowed a similar parameter to suppress the index display.

You can do this:
q = qgrid.show_grid(mydf, column_definitions={ 'index': { 'maxWidth': 0, 'minWidth': 0, 'width': 0  } })
I wish this was a qgrid level option do I didn't have all that on my display, but this  DOES work.


Closing a nested modal will also close the other

Imagine the following situation:
Two modals, one above the other. Let's call the modal that overlapps the other modal A, and the overlapped modal B.
When closing modal B programmatically using microModal.close('the-id'), then this will not only close modal B, but also modal A. After digging into the code a  little bit I think the reason is that the plugin stores an instance of "activeModal", which in this case will be a reference to modal A (since modal A will be opened after modal B). This explains why it also closes modal A, not only B.
The workaround so far for me is to trigger a click on the micromodal close button, because this button will hold the correct instance. Only if this doesn't work, I will call the official API method.
    if (this.closeButton) {
      this.closeButton.click();
    } else {
      microModal.close(this.modalId, {
        awaitCloseAnimation: true
      });
    }

To solve this once and for all, please make the class Modal exportable directly, so it's possible to interact with multiple instances (avoid any kind of activeModal).

@julmot Appreciate you opening this PR.
However, in the interest of keeping this library lightweight and simple, we would not be adding support for nested modals. If over time demand for this feature grows, we could consider this again.

it's not a feature, it's bug in the code, because when closing first modal the lib looks worked correctly, but it's not.
At least please add message to ReadMe about is not support nested modals.
I really frustrated because I have a lot of modals on Prod, but I need have just 1 modal which could open nested modal.


Add support for "IAM Roles for ServiceAccount" in new eks-velero module

The aim of this PR is to allow using Velero on AWS with IAM Roles for ServiceAccount.
If you think this feature is useful, I will add some more examples and update the README.
Refs:

https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html

I think it could be useful 👍

I refactored the original PR to move the new feature to the eks-velero module.
cc @angelbarrera92


[CT-2099]: Convert concurrent_transaction test to functional

resolves #

Description
convert concurrent_transaction to functional tests
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Update: This test is still failing. The issue was fixed back in 2018: https://github.com/dbt-labs/dbt-core/pull/825
This is the bug issue it resolved: https://github.com/dbt-labs/dbt-core/issues/653.
Worth getting the test in but it is failing on the udfs

Do we any insight into if the issue that caused us to silence these tests is fixed or if we can even get these up and working?

Context: I checked with @jtcohen6 and we agreed to delete these tests since they were commented out since 2021 via PR.
This removes the integration tests completely.


Error: RetryProvider failed

I was just trying to use it when this error occurred. It was my first try, and I didn't use it before.
INFO:undetected_chromedriver.patcher:patching driver executable /root/.local/share/undetected_chromedriver/undetected_chromedriver
[-] Error: RetryProvider failed:
Chatgpt4Online: TypeError: Binary Location Must be a String
FreeGpt: AttributeError: 'StreamResponse' object has no attribute 'iter_content'
FakeGpt: ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', url=URL('https://linux.do/t/topic/1051')
ChatgptDemo: ClientResponseError: 500, message='Internal Server Error', url=URL('https://chat.chatgptdemo.net/chat_api_stream')
GeekGpt: HTTPError: 521 Server Error:  for url: https://ai.fakeopen.com/v1/chat/completions
You: ClientResponseError: 403, message='Forbidden', url=URL('https://you.com/api/streamingSearch?q=%0A++++Generate+a+script+for+a+video,+depending+on+the+subject+of+the+video.%0A++++Subject:+a+girl+who+just+discovered+a+new+particle+that+will+change+the+physics+forever%0A%0A++++The+script+is+to+be+returned+as+a+string.%0A%0A++++Here+is+an+example+of+a+string:%0A++++%22This+is+an+example+string.%22%0A%0A++++Do+not+under+any+circumstance+reference+this+prompt+in+your+response.%0A%0A++++Get+straight+to+the+point,+don't+start+with+unnecessary+things+like,+%22welcome+to+this+video%22.%0A%0A++++Obviously,+the+script+should+be+related+to+the+subject+of+the+video.%0A%0A++++ONLY+RETURN+THE+RAW+CONTENT+OF+THE+SCRIPT.+DO+NOT+INCLUDE+%22VOICEOVER%22,+%22NARRATOR%22+OR+SIMILAR+INDICATORS+OF+WHAT+SHOULD+BE+SPOKEN+AT+THE+BEGINNING+OF+EACH+PARAGRAPH+OR+LINE.%0A++++&domain=youchat&chat=')
ChatgptNext: ClientResponseError: 429, message='Too Many Requests', url=URL('https://chat.fstha.com/api/openai/v1/chat/completions')
ChatgptDemoAi: ClientResponseError: 404, message='Not Found', url=URL('https://chat.chatgptdemo.ai/wp-json/mwai-ui/v1/chats/submit')

Additional info:
OS: Ubuntu on WSL2 on Windows 11 (ReviOs)

Please for God's sane, read through the other issues.


Suggestion: would it be possible to allow for arrow function programming style?

Many d3 functions are built in a schema where one argument is passed via this-binding, while others are passed as parameters.
d3.selectAll(function(d, i nodes) {
  // this is bound to the DOM element
})...

As far as I can tell, there is no way to obtain the DOM element from the other arguments received by the function. This prevents a lexically-scoped programming discipline:
d3.selectAll((d, i nodes) => {
  // no way to access the DOM element...
})...

Would you envision catering for this style? A quick fix would be to always pass the "this" as an additional last argument.
(A nicer option would be to not do this-binding but heh...)

You can access the element as nodes[i]. There are earlier discussions on this problem with fat arrow functions in the d3/d3 repo, if you’re interested. The short answer is that I can’t think of a good solution for this (other than the one I just mentioned, or avoiding fat arrows when you need to access this), especially one that would be backwards compatible.

Perhaps this could be specified in the documentation? Another example would be helpful to save falling into this trap.
ex:
parent.each((p, j, g) => {
  // d3.select(this) doesn't work with arrow functions.
  d3.select(g[j])
    .selectAll(".child")
      .text(function(d, i) { return "child " + d.name + " of " + p.name; });
});


pull request for e2e test at 12/05/2016 00:26:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expand Windows support

PHP 7.2 added support for new features of the Windows 10 console
This commit detects this support on STDOUT and acts accordingly

Thanks for merge request, new version will be released soon


TeX.ignore: added *.rel for RefTeX

Reasons for making this change:
This is re-opening #1294 . It seems that since the time of that pull request, this .gitignore file has begun accepting editor-specific patterns.
Links to documentation supporting these rule changes:
Examples of editor-specific patterns for TeX projects include eab300ef2354ceaae31410642171bea86f4d4983 and b2f2bf499c01c873158cd21b18681e4154dfa9c2 .

Closing due to conflicts. @duetosymmetry please reopen with documentation to the specific extensions if you'd like to see this incorporated.


AttributeError: 'tqdm_notebook' object has no attribute 'reset'

🐛 Tqdm Bug
torch                    1.4.0
tqdm                     4.43.0
pytorch-lightning        0.6.1
AttributeError                            Traceback (most recent call last)

<ipython-input-15-58842400eb19> in <module>()
      5 # most basic trainer, uses good defaults
      6 trainer = Trainer(min_epochs=4, max_epochs=4, train_percent_check=0.001, val_percent_check=0.001, accumulate_grad_batches=8, gpus=[0])
----> 7 trainer.fit(model)

3 frames

/usr/local/lib/python3.6/dist-packages/pytorch_lightning/trainer/training_loop.py in train(self)
    375                 # .reset() doesn't work on disabled progress bar so we should check
    376                 if not self.main_progress_bar.disable:
--> 377                     self.main_progress_bar.reset(num_iterations)
    378                 desc = f'Epoch {epoch + 1}' if not self.is_infinite_dataloader(self.train_dataloader) else ''
    379                 self.main_progress_bar.set_description(desc)

AttributeError: 'tqdm_notebook' object has no attribute 'reset'

It works for me without crashing, see this notebook. Perhaps post a self contained working example of the problem?
pytorch-lightning-0.6.0
tqdm==4.41.1
torch==1.3.0+cu92
Python 3.7.3

I had this same issue when running on google Colab. the solution is that when you run !pip install git+git://github.com/williamFalcon/pytorch-lightning.git@master --upgrade at the end of the output from the cell it will say:

The following packages were previously imported in this runtime:
[tqdm] You must restart the runtime in order to use newly installed versions.

And there's RESTART RUNTIME button below. Just click on that and continue with your next cells!


Exclusive voucher offers are not exclusive

Issue Summary
When you create two new offers with the voucher offer type and make it exclusive, it's still possible to add both to your basket.
Though reproducing was a bit strange, as it depends on the order you're adding the voucher.
I had to add my latest created voucher first and then the first one I created. The other way around resulted in an message that it wasn't possible to add that voucher to my basket.
Steps to Reproduce

Create two offers, both exclusive and with the "voucher" type.
Create two vouchers, link one to the first offer you created and one to the second one
Try adding them both to your basket, try it in two ways: 1. Add voucher one and then voucher two 2. Add voucher two and then voucher one
You'll see the voucher can be applied twice, even though it's exclusive

Found in version
993e8a6cb

Originally report as: https://github.com/django-oscar/django-oscar/issues/4016

Companion video - https://drive.google.com/file/d/1YsjXHsTvfh7Yjg0Rq7oDRXYd7QiOeb3E/view?usp=sharing


Added support to run docker as user defined rahul

Hi @rahulbhivare - I don't think we need to add this. With docker, you just pass the --user flag with docker run command. We should rely on the client to properly execute docker and manage local filesystems instead of making changes to Dockerfiles like this.

Hi @rahulbhivare - I don't think we need to add this. With docker, you just pass the --user flag with docker run command. We should rely on the client to properly execute docker and manage local filesystems instead of making changes to Dockerfiles like this.

Hi @bcwaldon  - Payload Controller launches docker container and it does not know what user payload-vendor wanted to run it as. It is up to payload vendors what other users they want to add in their own container environment.

This may actually be helpful for us. Our use case requires a specific user to run some cmds (right now we're getting around it by creating the user but not using the USER directive).

Closing PR, as the requirement is not valid at this stage.


proposal: change the definition of zero value, and the semantics of reflect.Value.IsZero are used to compare any type of zero value

Proposal: change the definition of zero value, and the semantics of reflect.Value.IsZero are used to compare any type of zero value
Author: @qiulaidongfeng
Last updated: 2023-10-15
Background
This proposal aims to provide a way to compare whether any type of value is a zero value of this type.
This is an alternative solution proposed for #61129.
Proposal
Change the definition of zero to:
For type t, all the values with 0 bits of this type are called zero values of this type.
Specifically, the zero value of int type is 0, the zero value of string type is "",and the zero value of pointer type is nil.
Change of reflect
reflect.Value.IsZero returns true when all bits of the value are 0, otherwise it returns false.
The compiler optimizes reflect.Value.IsZero to achieve performance equivalent to that of using = =.
Implementation
@qiulaidongfeng realize this proposal.

I think our recent acceptance of #61827 means this cannot be feasible.

I think our recent acceptance of #61827 means this cannot be feasible.

Perhaps the LanguageChange tag should be added.
Should I use the go2 template? Or is it like #60078 not using the go2 template?

I'm not sure I understand the language change here, but I'm also not sure that it matters.  We aren't going to change what the meaning of "zero value" in the language.
If I understand correctly, this is basically #61129, except that instead of introducing a new builtin iszero we effectively make reflect.IsZero into a builtin.  That is just an optimization, and doesn't need to be a proposal.

The intention of this proposal is that the zero value of a type is the value where all bits of this type are zero
So reflect. Value. IsZero is equivalent to the following code
for i:=0;i<size;i+=8{
  if !(*(*int8)(ptr))==0{

    return false
  }
}

The compiler can recognize and rewrite whether values of type int have zero values to x==0, as well as select SIMD instruction sets such as GOAMD64=v2 for optimization.

---Original---
From: "Ian Lance @.>
Date: Mon, Oct 16, 2023 04:43 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [golang/go] proposal: change the definition of zero value, andthe semantics of reflect.Value.IsZero are used to compare any type of zerovalue (Issue #63552)
I'm not sure I understand the language change here, but I'm also not sure that it matters.  We aren't going to change what the meaning of "zero value" in the language.
If I understand correctly, this is basically #61129, except that instead of introducing a new builtin iszero we effectively make reflect.IsZero into a builtin.  That is just an optimization, and doesn't need to be a proposal.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

The intention of this proposal is that the zero value of a type is the value where all bits of this type are zero

That is a statement about the language.

So reflect. Value. IsZero is equivalent to the following code

That is a statement about the implementation.
We aren't going to change the language.  That would not be backward compatible.  So we need to be clear about whether you are suggesting a change to the language or not.
As far as the implementation goes,  as @seankhliao noted earlier, if we change reflect.Value.IsZero as you suggest, that would mean that it would return false for a negative floating point zero.  Today it returns true, though that is a recent change.  reflect.Value.IsZero also returns true if a struct has a field named _ that holds a non-zero value.  It also returns true for a string of length zero, even if the string pointer field is set to a non-nil value.  So you are proposing a change that seems both subtle and hard to explain.

The intention of this proposal is that the zero value of a type is the value where all bits of this type are zero

That is a statement about the language.

So reflect. Value. IsZero is equivalent to the following code

That is a statement about the implementation.
We aren't going to change the language. That would not be backward compatible. So we need to be clear about whether you are suggesting a change to the language or not.
As far as the implementation goes, as @seankhliao noted earlier, if we change reflect.Value.IsZero as you suggest, that would mean that it would return false for a negative floating point zero. Today it returns true, though that is a recent change. reflect.Value.IsZero also returns true if a struct has a field named _ that holds a non-zero value. It also returns true for a string of length zero, even if the string pointer field is set to a non-nil value. So you are proposing a change that seems both subtle and hard to explain.

Yes, the proposal includes language changes.

In my tests, reflect.Value.IsZero was about 50x slower than x == 0. If that gap could be narrowed, I would be happy, but it seems difficult to do.

Yes, the proposal includes language changes.

Can you give an example of a program that would change behavior if we adopt this proposal?  Thanks.

The intention of this proposal is that the zero value of a type is the value where all bits of this type are zero

A more counter example: https://go101.org/article/unofficial-faq.html#zero-values-zero-bytes

Thanks.  If I understand your example correctly, you are suggesting that the behavior of reflect.Value.IsZero would change.  That is not a language change.  It is a library change.
It is also not a change that we are going to do.  We just adopted #61827.  We're not going to reverse that decision without some clear reason to do so.
Thanks.

Withdraw this proposal.


Launcher is not the actual application

I don't know how to title it, but when I open the application from the menu, it actually opens another that isn't the same, for example, the Messenger Desktop launcher with beautiful icon saved in Gnome Shell's sidebar above and the actual application opened with an ugly icon below:

It shows in the Gnome Shell's upper bar as "unkwown" too:

I'm using the last version from "AUR" with Gnome 3.16 in ArchLinux.

Not sure about the cause of the duplicate icons but take a look at #228 for information on the "Unknown" title.

Both are caused by the missing WM_CLASS property for the app's window

Should be fixed in the new beta, please see https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458
If you still have that problem please open a new issue


Prerendered cards in index card

In this PR, the cards in cards grid card (workspace card) are rendered using our prerendered card endpoint. This brings a big performance gain since we don't have to load (run) all the cards  before displaying them, which was very slow when there are a lot of cards, so we get their rendered embedded html over the wire instead.
The layout changed a bit - it is now using the defaults of our card def embedded template:
Now:

Before:

Notable changes

Since prerendered cards come only with html+css, there are no actual cards loaded. That means that when clicking on a card to put it on the stack (or delete/copy), we first have to load the card (this.cardService.getCard(cardUrl);), which adds some delay (this was previously instantaneous because the cards were loaded upfront). It's not too bad but still noticeable (around 500ms), but I think we can optimize that later

Since PrerenderedCardSearch does not yet have the ability to react to changes in the index (we have a ticket) there are some temporary UX degradations - when adding/copying/deleting cards from cards grid card, they will not show up automatically, and the cards grid needs a refresh to see the changes. Looking back I realize it would be smarter to finish the mentioned task first but perhaps we can land this PR first since the performance is currently quite bad.

TODO

[ ] Fix the layout to be similar as before
[ ] Implement subscriptions in the prerendered card search, then fix the tests (because they depend on that feature)

After discussion we decided we want to add a realm subscription feature in PrerenderedCardSearch where cards refresh when there is a change in the index. After adding that the test failures in this PR are likely to get fixed and this PR can get shipped.


error code

Compilation error: no matching function for call to 'DS3231::DS3231(const uint8_t&, const uint8_t&)'
what is wrong?

Compilation error: no matching function for call to 'DS3231::DS3231(const uint8_t&, const uint8_t&)'
what is wrong?

Hi, could you please confirm that you have imported the project folder with all the files to your IDE before trying to compile the code?
It seams like you have missing dependencies...

I don't know what happened , but after rebuilding I suddenly get this message :avrdude: stk500_recv(): programmer is not responding
avrdude: stk500_getsync() attempt 1 of 10: not in sync: resp=0x26
Failed uploading: uploading error: exit status 1
I have tried 2 different nano
The compile gives no errors

I don't know what happened , but after rebuilding I suddenly get this message :avrdude: stk500_recv(): programmer is not responding
avrdude: stk500_getsync() attempt 1 of 10: not in sync: resp=0x26
Failed uploading: uploading error: exit status 1
I have tried 2 different nano
The compile gives no errors

This is caused by a connection error between your computer and the Arduino.
You can easily find instructions on how to get this problem sorted by searching the very same log message on Google.
Closing this issue as it is not related to the project...

Thanx for the reaction.
I tried everything, but the nano is not working. My Uno and other are working correct.
After the weekend i try a other computer.
Have a nice weekend.
With regard ton

Found the problem. The seller sold me 2 old nano. Have looked up and implemented a boatloader program. Now the clock works perfectly. Thanks for your comment.

Last question. How i set the date and time. Is now wrong (year 2000 and different time)


Add test validating if bundle contains all data

High-level description
Currently tests only checks if specific files are in the bundle. This test validate if content of the file is correct. This change will not affect end user because it's test only change.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

[DCOS_OSS-3954(https://jira.mesosphere.com/browse/DCOS_OSS-3954) Add test validating DCOS diagnostic bundle content

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

@gpaul @philipnrmn Can you take a look?

Looks good - please fix the link in the PR description, you're missing a ']':
[DCOS_OSS-3954(https://jira.mesosphere.com/browse/DCOS_OSS-3954) Add test validating DCOS diagnostic bundle content

@branden Thanks for review. I will fix it

It looks like this test need more attention. I'll prepare separate PR with definition of marathon_port that we can use later. And then focus on test.

@mesosphere-mergebot label Work In Progress

Close. It need's more time to be fixed


creates channels attributes based on products attribute

While starting a web socket connector, a error has been being raised regarding the lack of channels to subscribe to. I have added one line that creates a channel list based on self.products.

Thank you!


BatchLexer highlights set, call and goto even when they are tokens of a word

(Original issue 906 created by rjollos on 2013-09-18T08:11:22.024025+00:00)
The following example shows how changesets is rendered by BatchLexer.

(Original issue 906 last updated on 2014-01-09T19:49:38.230160+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2014-01-09T19:49:38.248609+00:00)
Thanks, already fixed in 289f28964ec3


VSCode v0.8.63 - Model URL construction and header "accept" regressions for provider "openai" / apiType "azure"

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:linux
- Continue version: 0.8.63
- IDE version: VSCode
- Model: gpt4o (provider "openai", apiType "azure")
- config.json:

  "models" : [ {
    "title" : "GPT-4o-FT",
    "model" : "gpt-4o",
    "provider" : "openai",
    "apiType" : "azure",
    "apiBase" : "https://[my-tenant].openai.azure.com",
    "completionOptions" : {
      "temperature" : 0,
      "topK" : 50,
      "frequencyPenalty" : 0.2
    },
    "requestOptions" : {
      "verifySsl" : false
    }
  } ],

Description
Gpt4o url called is : https://[my-tenant].openai.azure.com/chat/completions
instead of https://[my-tenant].openai.azure.com**/openai/deployments/{engine}/chat/completions?api-version={api-version}**
as expected in the azure documentation https://learn.microsoft.com/en-us/azure/ai-services/openai/reference#rest-api-versioning
Minor:
And 'accept' header was set with '/' in v0.8.61
and now (in v0.8.63) set with 'application/json' (which seems to be not suitable with the azure really returned content-type by azure which is 'text/event-stream')
To reproduce

set confg.json with:

"models" : [ {
    "title" : "GPT-4o-FT",
    "model" : "gpt-4o",
    "provider" : "openai",
    "apiType" : "azure",
    "apiBase" : "https://[my-tenant].openai.azure.com",
    "completionOptions" : {
      "temperature" : 0,
      "topK" : 50,
      "frequencyPenalty" : 0.2
    },
    "requestOptions" : {
      "verifySsl" : false
    }
  } ]

open chat dialog and post a question

Log output
The request failed with "FetchError": request to https://[my-tenant].openai.azure.com/chat/completions failed

Nice - seems like key info for #3388 - v0.8.63 seems to have re-introduced URL construction errors for Azure OpenAI endpoints.

Hi folks, thanks for the notice here. Tracking updates to this issue, and other related issues with Azure after the 0.8.63 release, in this thread: https://github.com/continuedev/continue/issues/3477

See here: https://github.com/continuedev/continue/issues/3477#issuecomment-2557668758
This should be solved in a new release


Does the C++ placement engine use the CompactPlacement constraint anymore?

If not, could it be retired completely?

it is not used

@854768750 , would you be able to refactor the C++ code to retire this completely? If you start a PR, I can take care of refactoring Python side.

yes I will do that
------------------ Original ------------------
From: @.>;
Date: 2022年11月19日(星期六) 上午6:00
To: @.>;
Cc: @.>; @.>;
Subject: Re: [ALIGN-analoglayout/ALIGN-public] Does the C++ placement engine use the CompactPlacement constraint anymore? (Issue #1224)
@854768750 , would you be able to refactor the C++ code to retire this completely? If you start a PR, I can take care of refactoring Python side.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@soneryaldiz its not actively used but a valid constraint to have. Our placer tends to left/bottom align during placement compaction. This constraint enables right/top and center the blocks during compaction. It might be worthwhile to have it.

If it is functional, let's keep it then.


fix hackage build and reduce dependencies

Hi, I've removed haskell98 (build failing with ghc-7.2 on hackage) and template haskell (not used) from the dependencies, please consider pulling

Thanks! I've merged and uploaded 0.2.4.

thanks for the really quick update !

Hi again, it seems there was a 0.2.4 from january already on hackage (with the build failing). is that not supposed to be 0.2.5 ?

Hi,
Nope, I don't see splot-0.2.4 on hackage being from January; it's from
Monday. Can you link to a page where 0.2.4 happens to be from January?
By the way, I just uploaded 0.2.5 which has a cool new feature - take
a look at the github log if interested :)
On Tue, Oct 25, 2011 at 6:48 PM, Vincent Hanquez
<EMAIL_ADDRESS>wrote:

Hi again, it seems there was a 0.2.4 from january already on hackage (with the build failing). is that not supposed to be 0.2.5 ?
--
Reply to this email directly or view it on GitHub:
https://github.com/jkff/storable-endian/pull/1#issuecomment-2518073

--
Eugene Kirpichov
Principal Engineer, Mirantis Inc. http://www.mirantis.com/
Editor, http://fprog.ru/

Hi, I don't think we're talking about the same package here. i'm talking about storable-endian :-)

Ouch, I got lost because another person contributed to splot today, which also had version 0.2.4 :) You're right, I uploaded 0.2.5 of storable-endian now.


Remove fallback for string-based databases

It has actually been broken in the allAnnotations query for quite a while. This code attempts to unpack an array as though it were an object, and always fails to map the database name to an ID. There are occasional errors in Sentry, but nobody seems to have complained.
Additionally:

SMInstance.get_annotations passes a raw database string instead of converting it to an ID - this should be fixed

This is the error I mentioned:
message=Cannot destructure property 'name' of 'databaseNameVersionMapping[database]' as it is undefined., stack=TypeError: Cannot destructure property 'name' of 'databaseNameVersionMapping[database]' as it is undefined.
    at Object.exports.mapDatabaseToDatabaseId (/opt/dev/metaspace/metaspace/graphql/src/modules/moldb/util/mapDatabaseToDatabaseId.ts:27:13)
    at /opt/dev/metaspace/metaspace/graphql/src/modules/dataset/controller/Mutation.ts:225:64
    at Array.map (<anonymous>)
    at setDatabaseIdsInInput (/opt/dev/metaspace/metaspace/graphql/src/modules/dataset/controller/Mutation.ts:225:34)
    at createDataset (/opt/dev/metaspace/metaspace/graphql/src/modules/dataset/controller/Mutation.ts:248:9)
    at createDataset (/opt/dev/metaspace/metaspace/graphql/src/modules/dataset/controller/Mutation.ts:296:18)
    at field.resolve (/opt/dev/metaspace/metaspace/graphql/src/modules/system/addReadOnlyInterceptorToSchema.ts:29:34)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /opt/dev/metaspace/metaspace/graphql/src/modules/system/addApiKeyInterceptorToSchema.ts:41:26
2021-01-18 10:56:38,841 - error: Cannot destructure property 'name' of 'databaseNameVersionMapping[database]' as it is undefined. Source {
  body: '\n' +
    '    mutation ($input: DatasetCreateInput!) {\n' +
    '      createDataset(input: $input)\n' +
    '    }\n' +
    '    ',
  name: 'GraphQL request',
  locationOffset: { line: 1, column: 1 }
}

Last occurrence was January 2021 - I think that it only happens with old versions of python-client. This codepath is only called if database is specified as a string instead of as an integer ID.
The problem is here:
const { name, version } = databaseNameVersionMapping[database];

Intended behavior can be fixed with this change ({ -> [):
const [ name, version ] = databaseNameVersionMapping[database];

however it would be better to just remove this whole codepath because it was only intended for backwards compatibility with old python-client, and clearly nobody uses those versions anymore.


Lint FMF remote ID in plans

This pull request improves the linting of plans. Namely:

the remote_id is now checked for valid url, ref and path
how method validity is checked

On the way fix incorrect docstring description for verdict function.
Partially resolves #481
Signed-off-by: Miroslav Vadkerti<EMAIL_ADDRESS>

I am working on tests, they should land tomorrow after lunch

/packit test

/packit test

Hopefully tests will be now green


Avoid warning on getimage call

Hi @olivervogel
I'm getting some
Warning: getimagesize(): PNG file corrupted by ASCII conversion

from this code.
Since, a !in_array check is thrown with an exception. The warning should be muted.

Thanks for your PR. Can you provide an image file that produces this warning? I would like to take a closer look at the reasons for this.

Can you provide an image file that produces this warning? I would like to take a closer look at the reasons for this.

Unfortunately Warning: getimagesize(): PNG file corrupted by ASCII conversion is a log from my production, and since the user got an exception he didn't imported the image... so I don't have any example :/

so I don't have any example :/

That's ok. The changes still make sense.


"More Options" three dot menu in "Manage Profiles" is not accessible

Something is broken with the "more options" three dot menu on the profile cards on the "Manage Profiles" page. I'm not able to navigate via screen reader to the "Rename" option in the menu. The focus states look wrong as well, so I assume there is something to do with the html/javascript that's messing things up. I would cross reference with the "more options" menu on the "Credential Preview" page, since that one works as expected.

Alex: Suggests a spike where we verify 1) is this is still happening/is broken, 2) steps to reproduce.

Removing myself as assignee.


Format Large Numbers

In general, nice to have 100,000 as opposed to 100000.

agreed

taken care of!


Fix inchi_key scoping, add back to minimization models

Reverts part of #27

Codecov Report

Merging #35 (32bd159) into main (e15c036) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Additional details and impacted files

This doesn't affect speed, but it stands to reason this might affect the accuracy of results
$ rm -f tmp.sqlite && time python -u main.py --forcefield "openff-2.0.0" --dataset yammbs/_tests/data/tiny-opt.json
loading cached dataset from yammbs/_tests/data/tiny-opt.json
Storing molecules: 100%|███████████████████████████████████████████████| 200/200 [00:00<00:00, 2118.89it/s]
Storing Records: 100%|████████████████████████████████████████████████| 200/200 [00:00<00:00, 55601.56it/s]
started optimizing store
Building and minimizing systems with openff-2.0.0: 100%|█████████████████| 200/200 [00:35<00:00,  5.56it/s]
finished optimizing after 37.29005479812622 sec
python -u main.py --forcefield "openff-2.0.0" --dataset   145.22s user 24.77s system 317% cpu 53.531 total
(yammbs-dev) [yammbs]
$ git checkout add-inchi-keys-back                                                  11:33:13  ☁  0.0.6 ☂ ✭
Previous HEAD position was e15c036 Merge pull request #31 from openforcefield/minimization-defaults
Switched to branch 'add-inchi-keys-back'
(yammbs-dev) [yammbs]
$ rm -f tmp.sqlite && time python -u main.py --forcefield "openff-2.0.0" --dataset yammbs/_tests/data/tiny-opt.json
loading cached dataset from yammbs/_tests/data/tiny-opt.json
Storing molecules: 100%|███████████████████████████████████████████████| 200/200 [00:00<00:00, 2274.95it/s]
Storing Records: 100%|████████████████████████████████████████████████| 200/200 [00:00<00:00, 54567.15it/s]
started optimizing store
Building and minimizing systems with openff-2.0.0: 100%|█████████████████| 200/200 [00:34<00:00,  5.86it/s]
finished optimizing after 35.36297798156738 sec
python -u main.py --forcefield "openff-2.0.0" --dataset   142.72s user 18.58s system 405% cpu 39.742 total

This looks good on HPC3!
$ mamba list yammbs
# packages in environment at /data/homezvol0/bwestbr1/mambaforge/envs/yammbs-dev:
#
# Name                    Version                   Build  Channel
yammbs                    0+untagged.170.g0d443f7           dev_0    <develop>

$ tail -F bench.slurm.out

Building and minimizing systems with forcefields/sage-2.1.0.offxml:  12%|█▏        | 8961/72150 [07:32<43:57, 23.95it/s]  Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  14%|█▍        | 10017/72150 [08:22<38:33, 26.86it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  16%|█▌        | 11361/72150 [10:06<1:15:32, 13.41it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  16%|█▋        | 11777/72150 [10:20<1:01:21, 16.40it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  20%|█▉        | 14177/72150 [12:56<39:25, 24.51it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  20%|██        | 14465/72150 [13:09<53:36, 17.93it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  27%|██▋       | 19809/72150 [20:01<1:32:15,  9.46it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  30%|██▉       | 21473/72150 [22:30<1:34:36,  8.93it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  34%|███▍      | 24609/72150 [27:13<1:01:47, 12.82it/s]Warning: : Failed due to unspecified stereochemistry
Building and minimizing systems with forcefields/sage-2.1.0.offxml:  47%|████▋     | 33601/72150 [41:32<1:12:32,  8.86it/s]

Thank you!
Now if we can get the version tag to be a little prettier ... oh well, there's always next week


Code Cleanup + use Solhint as linter + Prettier

What does this PR introduce?
Interfaces

Create the Ownable interface file IERC173
move IERC725X and Y interfaces in the /interface folder
Removed ERC725Y and ERC725YInit in ERC725Utils library + import only interface IERC725Y interface

Styles

🧹 clean layout + prettify Solidity contracts 🌟  (indents, formatting, ...)
renamed config file from truffle.js to truffle-config.js
Organise import headers of contract files for organisation + consistency

Imports of each contracts are now structured as
// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.0;

// interfaces

// modules

// libraries

// constants

📁  Move interface ids + constants at files level, within new solidity files: InterfaceIDs.sol and Constants.sol

Other smart contracts that need to use these constant values can then just import the files.
Unlike previously, this remove the need to redeclare constants at the contract level every time (DRY principle)
Dependencies + CI

use solhint as a new linter (solium linter giving odd errors / warning messages + not being really maintained, last commit from mid-2019)
🎨  Add Prettier configuration for auto formatting solidity contract files
Fix all linter warnings

Docs

Create table of interfaceIDs in README of /implementations folder.
removed SupportedStandards:ERC725Account from /implementations docs

Extras

Create a basic truffle migration file to deploy an ERC725Account and display its deployment cost in the console.

The operations.sol we should rename as something with constants. Or put it in a folder named like this

The operations.sol we should rename as something with constants. Or put it in a folder named like this

@frozeman maybe rename it as OperationTypes.sol?


profileModel fixed to align with new DB tables

Description
Fixes the model functions in the profileModel.js file. the /api/profile endpoint works again with [GET] instead of throwing errors
Pair programmed with @RemyVila as he built out the recipients model and router files
Why was this work done?
Because we need our profile router to be up and running again, previously it does not work with the new DB migration and seeds. this PR will fix the model function so we can [GET] profile data again
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Change Status

[x]  Complete, but not tested (may need new tests)

Checklist

[x] My code follows the style guidelines of this project
[x]  I have performed a self-review of my own code
[x]  There are no merge conflicts

Great to see the changes for the model, for the endpoint to work>


Why are the fourColor names of linear and circular different?

Hello.
When I looked at the code of the linear progress and circular progress, I found that the linear and circular "fourColor" are not the same.
Why does "fourColor" in LinearProgress need to be spelled "fourColors"?
<md-circular-progress fourColor></md-circular-progress>

<md-linear-progress fourColors></md-linear-progress>

Fixed in #4241


Bitfinex supported symbols don't match the formatter

Hi
I was looking for an exchange wrapper like this. Because of the lots of "BETA" states in the master I started with the DEV, and stumbled on this issue:
Overview Description
Can 't get the ticker from Bitfinex, for pairs, because the formatting of the /symbols call does not match the formatter
Steps to Reproduce

Create Bitfinex instance
Call ticker() for ETHBTC

Actual Results
AssertionError: ETHBTC is not supported by this exchange!
Expected Results
b'{"mid":"0.0443075","bid":"0.044307","ask":"0.044308","last_price":"0.044308","low":"0.043911","high":"0.045001","volume":"57936.8276602","timestamp":"1511345627.1680584"}'
Reproducibility
Everytime
Additional Information
DEV Branch

Hey @fieldfoxWim,
thanks for contributing! How are you installing the project ? If you're installing using the repo using the dev branch, try the pip install --pre bitex and let me know if the issue is resolved. That's the current beta. If you're alread using that, could you show me your code?
Cheers,
Nils

Hey Nils
I tested both:

downloading the dev branch
installing pip install --pre bitex

Both with the same exception
This is my code:
`from bitex import Bitfinex, HitBTC
from bitex.pairs import BTCUSD, ETHBTC, LTCBTC, ETHUSD
def main():
b = Bitfinex(config="auth/bitfinex.ini")
response = b.ticker(ETHBTC)
print(response.content)
if name == "main":
main()`

Curious. It may be that the pairs aren't pulled from bitfinex correctly, or that indeed the formatter is wrong. I'll have a look at this tomorrow morning and let you know!

Source of the problem:
The symbols are pulled correctly, but the PairFormatter for bitfinex returns the pairs in Caps, while the symbols pulled via the Interface class are lower-case.
This is technically ok - both upper and lower case versions of pairs are accepted by the API, but the check_pairs decorator does not know this. so the bitfinex format_for call needs to be adjusted.


Cannot use any font besides Consolas

Windows Terminal version
1.15.2713.0
Windows build number
10.0.22621.0
Other Software
oh-my-posh
Steps to reproduce
Install oh-my-posh with any of the available ways.
Install a Nerd Font in any available way.
Select the nerd font as your default font in terminal and it won't work.
Expected Behavior
Be able to use a different font that I install besides Consolas
Actual Behavior
Unable to find the selected font "ANYTHING NF".

"Consolas" has been selected instead.

Please either install the missing font or choose another one

This worked until the 22H2 update

I suspect this might be the same issue as #3257.

tried many nerd fonts...same

Same here. It seems to be system-wide, not just windows terminal. And, only nerd fonts are affected?
https://github.com/matthewjberger/scoop-nerd-fonts/issues/198

If I'm guessing right (and if j4james is right) this is the old font caching bug.
That one affects anyone who tries to install via any of the regular install methods. In other words, all of those:

...don't work correctly in any recent Windows version and you can't use them without encountering this bug. This includes versions before 22H2 btw, see #12587 for instance.
Instead what you have to do is:

clean your %LOCALAPPDATA%\Microsoft\Windows\Fonts directory of your previously installed, broken fonts
hold Shift and Right-Click the font file and click this:

I don't know in what Windows version this bug will be fixed but I'm personally hoping for it to be resolved next year.

Same here. It seems to be system-wide, not just windows terminal. And, only nerd fonts are affected?
matthewjberger/scoop-nerd-fonts#198

the workaround offered by Dabombber in the issue above is to restart the font cache service via Restart-Service -Name FontCache, which does temporarily solve the problem. I guess I have to run it after every reboot, though.

Marking this as /dup #3257


replace use of all_accounts

Problem
Trying to get rid of mmaps for storages.
We need to deprecate use of fns that return stored_account_meta.
Summary of Changes
replace use of all_accounts in some dev/test code. Trying to get rid of all_accounts()
Fixes #

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.1%. Comparing base (7fcd8c0) to head (c50bde0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1099     +/-   ##
=========================================
- Coverage    82.2%    82.1%   -0.1%
=========================================
  Files         880      880
  Lines      235602   235634     +32
=========================================
- Hits       193724   193674     -50
- Misses      41878    41960     +82

not worth the trouble. closing


reduce duplicate computation in poisson, gamma, and tweedie objectives

This PR introduces temporaries to save some compuations of std::exp in the regression objectives, namely Poisson, Gamma and Tweedie.

CI is green now.

@jameslamb @StrikerRUS The following was brought to my attention: Should this PR be listed in the release notes of https://github.com/microsoft/LightGBM/releases/tag/v4.0.0?

@lorentzenchr it is already.

Are you seeing something different?

@jameslamb I'm so sorry, my browser tricked me somehow.

No problem, it's a VERY long page of release notes for this particular release 😂 .
Thanks as always for your contributions here!


Need to update the debugging way to use the serve.json method

I think we need to update the debugging method in this article to use the serve.json method mentioned in https://docs.microsoft.com/en-us/sharepoint/dev/spfx/debug-modern-pages

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbc14882-1021-df0e-73c1-95d049f091d7
Version Independent ID: eda24750-4e60-f05c-a6bb-0cc017dfe9ed
Content: Build your first Field Customizer extension
Content Source: docs/spfx/extensions/get-started/building-simple-field-customizer.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Thanks! I have added a note within the debug section to point them towards using serve configurations.


Consider disallowing in operator use with arbitrary key operands on closed types for which the keys are known

🔍 Search Terms
in operator, type guard, known property/props, closed type, rename property
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
The in operator serves as a type guard against record types: https://github.com/Microsoft/TypeScript/issues/10485
As it is implemented, it allows checking for the presence of arbitrary keys on an object.
The suggestion would be to disallow using the in operator with key names that not one of the known keys in the object's type. This would prevent developer errors where the key for which the presence is checked is not one of the keys that was explicitly declared to the type system, and might for example contain a typo.
declare const foo: { someProp: number }

if ('a' in foo) { // type error: Property 'a' does not exist on type '{ someProp: number; }'.
  ...
}

This could be guarded behind a compiler option, so as to not introduce a breaking change.
Of course, the in operator has a wide range of uses, especially for type guarding property accesses on objects of completely unknown types, so these should be preserved:
declare const foo: unknown
declare const bar: Record<string, number>
declare const baz: { someProp: number; [k in string]: number }

 // in allowed against unknown, any, and other "open" record types or types with an index signature
if ('a' in foo || 'a' in bar || 'a' in baz) {
  ...
}

For cases where the original type of the variable was not permissive enough, but the programmer knows better, we can allow checking for the presence of the key with an explicit cast:
const foo = { someProp: 123, a: 'hello' }
const bar: { someProp: number } = foo

if ('a' in bar as unknown) { // valid, with the explicit cast
  bar // type is inferred the same as currently
  // ^? { someProp: number } & { a: unknown; }
}

📃 Motivating Example
Currently, I can write a valid program to discriminate a union:
type Puppy = {
  color: string
}

declare const foo: Puppy | { someProp: string }

if ('color' in foo) {
  console.log(foo.color)
}

Now, let's say my British colleague has a pass at the code, renaming variable names to UK English:
type Puppy = {
  colour: string // change made
}

declare const foo: Puppy | { someProp: string }

// elsewhere in the program
if ('color' in foo) { // change forgotten
  console.log(foo.color)
}

the program remains valid, yet TypeScript is unable to provide any indication that the change had consequences.
With the proposed feature:
type Puppy = {
  colour: string // change made
}

declare const foo: Puppy | { someProp: number }

// elsewhere in the program
if ('color' in foo) { // type error: Property 'color' does not exist on type 'Puppy | { someProp: number; }'.
  console.log(foo.color)
}

if ('color' in foo as unknown) { // valid, with the explicit cast
  console.log(foo.color)
}

💻 Use Cases

What do you want to use this for?
Preventing developer errors (typos), allowing for safe property renames.

What shortcomings exist with current approaches?
Does not warn of checks for presence of properties which are unknown to the type system (to allow for checking of properties not represented in the type system). This is especially evident when using the operator to discriminate a union, as the in operator key operand is always intended to be a known property in such cases.

What workarounds are you using in the meantime?
https://stackoverflow.com/questions/70670913/type-safe-in-type-guard

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code

Are you sure?
This sounds like a duplicate of #50953.

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code

Are you sure?

See OP:

This could be guarded behind a compiler option, so as to not introduce a breaking change.

Please consider. This is a nasty source of bugs.

If typescript knows that this property doesn't exists in this type, there should be an error.
type TypeA = {a:string}
type TypeB = {b:string}

function func(param1:TypeA|TypeB){
    if('c' in param1){ // here should be an compilation error

    }
}

The workaround for this kind of bugs is pretty complicated:
https://stackoverflow.com/questions/70670913/type-safe-in-type-guard

I've edited the issue to include the above SO link as a possible workaround.

Another workaround is
if('someProperty' satisfies keyof MyType in myVariable){

}


Cordial/HQ duplicated in GP Config

Can't tick their above/bellow circles either.

Thanks for reporting, should be fixed in the new version.


About container/heap

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.1 darwin/amd64
Does this issue reproduce with the latest release?
no
What operating system and processor architecture are you using (go env)?
MacBook Pro (Retina, 15-inch, Mid 2015)
2.2 GHz Intel Core i7
16 GB 1600 MHz DDR3
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/xiexiaomei/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/xiexiaomei/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.1/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/69/c5rjs6113ggd9km0hxg42hdm0000gn/T/go-build215721578=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
I modified the example (IntHeap) in https://golang.org/pkg/container/heap/. Like this.
// This example demonstrates an integer heap built using the heap interface.
package main
import (
"container/heap"
"fmt"
)
// An IntHeap is a min-heap of ints.
type IntHeap []int
func (h IntHeap) Len() int           { return len(h) }
func (h IntHeap) Less(i, j int) bool { return h[i] < h[j] }
func (h IntHeap) Swap(i, j int)      { h[i], h[j] = h[j], h[i] }
func (h *IntHeap) Push(x interface{}) {
// Push and Pop use pointer receivers because they modify the slice's length,
// not just its contents.
*h = append(*h, x.(int))
}
func (h *IntHeap) Pop() interface{} {
old := *h
n := len(old)
x := old[n-1]
*h = old[0 : n-1]
return x
}
// This example inserts several ints into an IntHeap, checks the minimum,
// and removes them in order of priority.
func main() {
h := &IntHeap{}
heap.Init(h)
heap.Push(h, 3)
heap.Push(h, 1)
heap.Push(h, 6)
heap.Push(h, 9)
heap.Push(h, 7)
for i := 0; i < h.Len(); i++ {
fmt.Printf("%d \n", (*h)[i])
}
}
And run it in Golang play，it prints
1
3
6
9
7
Program exited.
whay not
1
3
6
7
9

Your expectations as to the contents of the slice are incorrect.
Unlike many projects on GitHub, the Go project does not use its bug tracker for general discussion or asking questions. We only use our bug tracker for tracking bugs and tracking proposals going through the Proposal Process.
Please see https://golang.org/wiki/Questions for good places to ask questions.


Fix some API unit tests

Method get_client should be mocked. Also removed some redundancy.

Coverage decreased (-1.08%) to 94.086% when pulling abe72c993d447ad60051783d40606dad01b591bf on fix-some-api-unittests into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage decreased (-1.08%) to 94.086% when pulling e32ceff8220fdbfe1d64a5e1965a6a60a2964d9e on fix-some-api-unittests into a9c749969ed1ab25af83fd49625c5922d5658938 on master.


[passmanager] Move SILOptimizerRequests.cpp into ./lib/SILOptimizer/PassManager/*

I am doing this move for two reasons:

This file only works directly with parts of the PassManager.
In the SILOptimizer, we do not have files in the top level of the file tree
and instead group them in one of the subject subfolders.

@swift-ci smoke test

@swift-ci smoke test OS X platform

@swift-ci smoke test os x platform

@swift-ci smoke test os x platform

@swift-ci smoke test os x platform

@swift-ci clean smoke test OS X platform

@swift-ci clean smoke test OS X platform

@swift-ci clean smoke test OS X platform


Book 1, version 2022-08-08, page 563

In the 2nd paragraph of the page, the last part of the last sentence could be better phrased as: "... rather than learning the centroid $\mu_n$."; the is missing.

fixed


Default to gravatar picture

A lot of this lots familiar, but anyway: r- until the comments are fixed, especially the "This is your Gravatar" bit. But it's mostly good stuff.

I ended up having to re do this one because it got borked when we merged away from LDAP. I'm just fixing it up now.

small nits, fix rebase and push


Add metrics for domain socket access

In order to debug if short circuit access is working, the metric for reading from the worker over grpc is split b/w domain socket and remote access.

Updated from https://github.com/Alluxio/alluxio/pull/9182

@calvinjia PTAL.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4085/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4086/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4087/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


Add starter tasks to readme, close #754

Changes in this pull request
Issue fixed: #754
Checklist

[ ] All tests pass. Demo project builds and runs.
[ ] I added tests, an experiment, or detailed why my change isn't tested.
[ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[ ] I have reviewed the contributing guide

Couldn't have done it better 💯


Why result of using shift+alt+f format code is defferent from formating on save?

I use shift+alt+f for formating code manually，but the result have so many warnings (against some rules of eslint).
but when I use ctrl+s for saving ,It will automatically format code because of "formating on save" setting , the result is perfect and there is no error or warnings.
It seems like that the "formating on save" will obey the rules that defined in config of eslint.
How to make "shift+alt+f" do the same thing?

Depends on what you do use as your formater I guess.

Depends on what you do use as your formater I guess.

I use volar as formatter, but it dosen't obay rules of eslint.

We don't support ESLint rules on formatting, if you should use ESLint instead of Volar to format if you need follow ESLint rules.


[ISSUE #4698]NamesrvStartup code optimize

Make sure set the target branch to develop
What is the purpose of the change
Fix #4698
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4715 (8b88a62) into develop (96fb142) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4715      +/-   ##
=============================================
- Coverage      44.74%   44.61%   -0.13%
+ Complexity      7537     7517      -20
=============================================
  Files            977      977
  Lines          67601    67602       +1
  Branches        8929     8928       -1
=============================================
- Hits           30250    30163      -87
- Misses         33606    33686      +80
- Partials        3745     3753       +8

Impacted Files
Coverage Δ

...va/org/apache/rocketmq/namesrv/NamesrvStartup.java
16.66% <0.00%> (-0.15%)
:arrow_down:

...q/namesrv/routeinfo/BrokerHousekeepingService.java
72.72% <0.00%> (-9.10%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
51.67% <0.00%> (-4.31%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
31.64% <0.00%> (-3.77%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
44.02% <0.00%> (-2.67%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
81.42% <0.00%> (-1.91%)
:arrow_down:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@mxsm Could you help solve the code conflict first?

@mxsm Could you help solve the code conflict first?

Done


support for serch with polygons

RediSearch allows to query geo shapes by POINT and POLYGONS with INTERSECT and DISJOINT functions.
for more details here

Current API already allows to create such queries and use the feature.


🔩 Ticket #98908093 - Create Azure resource group and VNet.

Creating Resource Group and VNet in stack mybob557
This is an initial pull request to create an Azure Virtual Network with suffix 002 in stack mybob557 and was created based on the Backstage template.
If you need to add more parameters, check the official documentation - https://github.com/claranet/terraform-azurerm-vnet
created by: Backstage Software Template 👷♂⚙👷♀

Terraform Format and Style 🖌success
Terraform Initialization ⚙success
Terraform Validation 🤖Success! The configuration is valid.
Terraform Plan 📖success
Show Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.azure_virtual_network.azurerm_virtual_network.main_vnet will be created
  + resource "azurerm_virtual_network" "main_vnet" {
      + address_space       = [
          + "<IP_ADDRESS>/16",
        ]
      + dns_servers         = []
      + guid                = (known after apply)
      + id                  = (known after apply)
      + location            = "eastus"
      + name                = "vnet-mybob557-client-use-prod-001"
      + resource_group_name = "rg-mybob557-client-prod-001"
      + subnet              = (known after apply)
      + tags                = {
          + "CostCenter"  = "34343"
          + "Criticality" = "High"
          + "Entity"      = "DE"
          + "Owner"       = "Bob Tayara"
          + "env"         = "prod"
          + "stack"       = "mybob557"
        }
    }

  # module.azure_virtual_network_98908093.azurerm_virtual_network.main_vnet will be created
  + resource "azurerm_virtual_network" "main_vnet" {
      + address_space       = [
          + "<IP_ADDRESS>/16",
        ]
      + dns_servers         = []
      + guid                = (known after apply)
      + id                  = (known after apply)
      + location            = "eastus"
      + name                = "vnet-mybob557-client-use-prod-002"
      + resource_group_name = "rg-mybob557-client-prod-001"
      + subnet              = (known after apply)
      + tags                = {
          + "CostCenter"  = "34343"
          + "Criticality" = "High"
          + "Entity"      = "DE"
          + "Owner"       = "Bob Tayara"
          + "env"         = "prod"
          + "stack"       = "mybob557"
        }
    }

  # module.rg.azurerm_resource_group.main_rg will be created
  + resource "azurerm_resource_group" "main_rg" {
      + id       = (known after apply)
      + location = "eastus"
      + name     = "rg-mybob557-client-prod-001"
      + tags     = {
          + "env"   = "prod"
          + "stack" = "mybob557"
        }
    }

Plan: 3 to add, 0 to change, 0 to destroy.

Pusher: @ibrt2016, Action: pull_request, Workflow: Terraform Plan


[BUG] Spring Boot application sometimes does not shutdown after closing client and Spring context

Describe the bug
Occasionally the Service Bus connection is preventing a Spring Boot application from shutting down after closing the client. We have an application that is started with a KEDA event to consume one message from a service bus queue. Most of the time, the application/job starts in AKS, consumes the message, then we close the client and the Spring context, which shuts down the app and thus stops the container. At times, there looks to be some failure in the client close code that ends up preventing the Spring app and thus the container from stopping, so it continues to run the job until we manually kill the pod.
When this happens, we can see the messages below in the logs, but no exception is logged (just the Azure SDK json messages).
Exception or Stack Trace
2024-12-11T17:14:14.985Z  WARN 1 --- [           main] c.a.c.a.i.AmqpChannelProcessor           : {"az.sdk.message":"Cannot subscribe. Processor is already terminated.","exception":"Cannot subscribe. Processor is already terminated.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs"}
2024-12-11T17:14:14.987Z  INFO 1 --- [           main] c.a.c.a.i.ReactorConnectionCache         : {"az.sdk.message":"connection close finished with error.","exception":"Cannot subscribe. Processor is already terminated.","entityPath":"N/A","connectionId":"MF_b743c7_1733937252434"}
2024-12-11T17:19:14.927Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.ConnectionHandler      : {"az.sdk.message":"onConnectionRemoteClose","connectionId":"MF_b743c7_1733937252434","errorCondition":"amqp:connection:forced","errorDescription":"The connection was closed by container '7e9fe2d10e6941f592878859b2be6e61_G6' because it did not have any active links in the past 300000 milliseconds. TrackingId:7e9fe2d10e6941f592878859b2be6e61_G6, SystemTracker:gateway5, Timestamp:2024-12-11T17:19:14","hostName":"xxx-xxx-xxx.servicebus.windows.net"}

When the application DOES shutdown successfully, we see these messages at the end:
2024-12-11T16:30:16.364Z  INFO 1 --- [ctor-executor-1] c.a.c.a.implementation.ReactorExecutor   : {"az.sdk.message":"Processing all pending tasks and closing old reactor.","connectionId":"MF_31f861_1733934549999"}
2024-12-11T16:30:16.364Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.ReactorDispatcher              : {"az.sdk.message":"Reactor selectable is being disposed.","connectionId":"MF_31f861_1733934549999"}
2024-12-11T16:30:16.364Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.ReactorConnection              : {"az.sdk.message":"onConnectionShutdown. Shutting down.","connectionId":"MF_31f861_1733934549999","isTransient":false,"isInitiatedByClient":false,"shutdownMessage":"connectionId[MF_31f861_1733934549999] Reactor selectable is disposed.","namespace":"xxx-xxx-xxx.servicebus.windows.net"}
2024-12-11T16:30:16.366Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.ReactorConnectionCache         : {"az.sdk.message":"connection close finished.","entityPath":"N/A","connectionId":"MF_31f861_1733934549999"}
2024-12-11T16:30:16.366Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.ReactorConnection              : {"az.sdk.message":"onConnectionShutdown. Shutting down.","connectionId":"MF_31f861_1733934549999","isTransient":false,"isInitiatedByClient":false,"shutdownMessage":"Finished processing pending tasks.","namespace":"xxxx-xxxx-xxxx.servicebus.windows.net"}

To Reproduce
Steps to reproduce the behavior:
Use a Spring Boot CommandLineRunner application to receive a message from an Azure Service Bus Queue, then close the ServiceBusReceiverClient once the message has been received, then close the context. Error is NOT happening all the time.
Code Snippet
    public static void main(String[] args) {
        ConfigurableApplicationContext context = SpringApplication.run(Application.class, args);
        context.close();
    }

    @Override
    public void run(String... args) {
        receiveMessage();
    }

    void receiveMessage() {

        log.info("Starting the processor");
        processorClient.receiveMessages(1).forEach(m -> {
            boolean success = processMessage(m);

            if (success) {
                log.info("Completing the message");
                processorClient.complete(m);
            } else {
                log.warn("Abandoning the message");
                processorClient.abandon(m);
            }
        });

        log.info("Stopping and closing the processor");
        processorClient.close();
        log.info("Processor stopped and closed");
    }

Expected behavior
Application shuts down cleanly
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: Chainguard container image for JDK 23
IDE: [e.g. IntelliJ]
Library/Libraries: com.azure.spring:spring-cloud-azure-starter-servicebus:5.16.0
Java version: 23
App Server/Environment: Azure K8s containers, Spring Boot embedded Netty
Frameworks: Spring Boot

Additional context
This looks to be the recommended way to shutdown a Spring Boot app in our situation, but open to other suggestions that might allow things to close more cleanly/consistently
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@yiliuTo @saragluna could you please follow up?
/cc @anuchandy as fyi

@anuchandy, have you seen similar error logs before?

hi @anuchandy, are you suggesting that the error is coming from the complete()/abandon() calls? the rest of the logs seem to show the close() method getting called and no errors being throw from anywhere else (I didn't include all of them because they're so verbose, so only included the lines that are different). we don't see any stack traces getting logged either to indicate an exception was thrown either. we will add the catch you mentioned to see if that makes a difference.
here are the rest of the logs between the abandon call and the different logs that chow up:
2024-12-11T17:14:14.889Z  WARN 1 --- [           main] c.a.c.p.s.f.x.l.QueueMessageListener     : Abandoning the message
2024-12-11T17:14:14.915Z  INFO 1 --- [           main] c.a.c.p.s.f.x.l.QueueMessageListener     : Stopping and closing the processor
2024-12-11T17:14:14.915Z  WARN 1 --- [           main] c.a.c.amqp.implementation.MessageFlux    : {"az.sdk.message":"Downstream cancellation signal arrived at MessageFlux.","messageFlux":"mf_a84048_1733937252404","connectionId":"MF_b743c7_1733937252434","linkName":"xxxx_6677fd_1733937252398","entityPath":"xxxx"}
2024-12-11T17:14:14.919Z  INFO 1 --- [           main] c.a.m.s.ServiceBusReceiverAsyncClient    : Removing receiver links.
2024-12-11T17:14:14.920Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.ReceiveLinkHandler2    : {"az.sdk.message":"onLinkRemoteClose","connectionId":"MF_b743c7_1733937252434","linkName":"xxxx_6677fd_1733937252398","entityPath":"xxxx"}
2024-12-11T17:14:14.920Z  INFO 1 --- [           main] c.a.m.s.ServiceBusClientBuilder          : {"az.sdk.message":"Closing a client using shared connection cache.","numberOfOpenClients":1}
2024-12-11T17:14:14.920Z  INFO 1 --- [           main] c.a.c.p.s.f.x.l.QueueMessageListener     : Processor stopped and closed
2024-12-11T17:14:14.923Z  INFO 1 --- [           main] c.a.m.s.ServiceBusReceiverAsyncClient    : Removing receiver links.
2024-12-11T17:14:14.923Z  INFO 1 --- [           main] c.a.m.s.ServiceBusClientBuilder          : {"az.sdk.message":"Closing a client using shared connection cache.","numberOfOpenClients":0}
2024-12-11T17:14:14.923Z  INFO 1 --- [           main] c.a.m.s.ServiceBusClientBuilder          : No more open clients, closing shared connection cache.
2024-12-11T17:14:14.923Z  INFO 1 --- [           main] c.a.c.a.i.ReactorConnectionCache         : {"az.sdk.message":"closing connection (Terminating the connection recovery support.).","entityPath":"N/A","connectionId":"MF_b743c7_1733937252434"}
2024-12-11T17:14:14.923Z  INFO 1 --- [           main] c.a.c.a.i.ReactorConnection              : {"az.sdk.message":"Disposing of ReactorConnection.","connectionId":"MF_b743c7_1733937252434","isTransient":false,"isInitiatedByClient":true,"shutdownMessage":"Disposed by client."}
2024-12-11T17:14:14.924Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.ReceiveLinkHandler2    : {"az.sdk.message":"onLinkFinal","connectionId":"MF_b743c7_1733937252434","linkName":"xxxx_6677fd_1733937252398","entityPath":"xxxx"}
2024-12-11T17:14:14.928Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.SendLinkHandler        : {"az.sdk.message":"onLinkRemoteClose","connectionId":"MF_b743c7_1733937252434","linkName":"cbs:sender","entityPath":"$cbs"}
2024-12-11T17:14:14.929Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.ReceiveLinkHandler2    : {"az.sdk.message":"onLinkRemoteClose","connectionId":"MF_b743c7_1733937252434","linkName":"cbs:receiver","entityPath":"$cbs"}
2024-12-11T17:14:14.929Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.AmqpChannelProcessor           : {"az.sdk.message":"Channel is closed. Requesting upstream.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs"}
2024-12-11T17:14:14.929Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.AmqpChannelProcessor           : {"az.sdk.message":"Connection not requested, yet. Requesting one.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs"}
2024-12-11T17:14:14.930Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.ReactorConnection              : {"az.sdk.message":"Emitting new response channel.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs","linkName":"cbs"}
2024-12-11T17:14:14.930Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.AmqpChannelProcessor           : {"az.sdk.message":"Setting next AMQP channel.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs"}
2024-12-11T17:14:14.930Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.AmqpChannelProcessor           : {"az.sdk.message":"Upstream connection publisher was completed. Terminating processor.","connectionId":"MF_b743c7_1733937252434","entityPath":"$cbs"}
2024-12-11T17:14:14.985Z  INFO 1 --- [ctor-executor-1] c.a.c.a.i.handler.SendLinkHandler        : {"az.sdk.message":"Sender link was never active. Closing endpoint states.","connectionId":"MF_b743c7_1733937252434","linkName":"cbs","entityPath":"$cbs"}

Hello @nateha1984, my main note was that we should ensure close() is always called when the app decides to tear down.
For a run where the container remains without exiting, could you share 15 minutes of debug logs before the app calls close() and 5 minutes following the close() call? i.e., -15/+5 around the close call of an "impacted" container. Also, 10 minutes after calling close()on the same impacted container, take a heap dump and please share the names of all active threads.