Implement the new two-level header for Manage

Context
The prototype has a two-level header which makes space for the new "Users" and "Organisations" items. We're about to add these so we need the new roomier design.
Changes proposed in this pull request

refactor the way we assign per-environment colours to the relevant UI elements because it's already repetitive and adding a third element (the full-width bar) will make it even more so
add the necessary moj-frontend bits and put the markup in the provider header component
move the Applications item into the new menu

Guidance to review
Does the phase banner look a bit lost?

Link to Trello card
https://trello.com/c/OTojnjhu/2440-implement-the-new-two-level-header-for-manage
Things to check

[ ] This code doesn't rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

On https://design-system.service.gov.uk, the phase banner appears above the navigation. An alternative is to just show a phase badge next to the product name in the header (but that’d break for different environments which have longer labels). The prototype has no banner. Not sure… what are your thoughts on this @adamsilver?

@paulrobertlloyd going to add the phase banner back to the prototype - just an accidental omission. Will follow the GOV.UK Design System.

Spotted another glitch this morning, addressing:

Spotted another glitch this morning, addressing:

This is not because of the navigation bar, but the mast head below has a negative margin on it.

Just discussed with @adamsilver  — closing this PR to split it up

fix the existing menu link generation which was missing some closing s, and add the correct aria attr to the crown
add a phase banner to the provider landing page
add the primary navigation/full-width header bar to the provider interface


Compare Javascript ECS libraries

Winner:
The winner is PicoES.  Documentation is decent but since it's in the README I can't tell if it's up to date or not.
Components appear to be stored directly on the entities, but in this case it's not really relevant.
Library is pretty tiny. It looks to be under 500 lines total, excluding tests.
Looks to hit all the rest of our criteria.
Contenders
Browsing through NPM, culled results for ECS to the following libraries:

https://github.com/ayebear/picoes
https://github.com/ecsjs/ecs
https://github.com/jamesflorentino/laro
https://github.com/odogono/elsinore-js
https://github.com/therealsamf/Sam-ECS

Next Actions:

[x] Flesh out a scorecard
[x] Rate https://github.com/ayebear/picoes
[x] Rate https://github.com/ecsjs/ecs
[x] Rate https://github.com/jamesflorentino/laro
[x] Rate https://github.com/odogono/elsinore-js
[x] Rate https://github.com/therealsamf/Sam-ECS

Scorecard (IN PROGRESS)
Scorecard:
High:

[ ] Serialize to and from JSON.

Versionable.
Easy to edit by hand.
Easy to build an editor.
Easy to save in the naive way.
Ensures a separation of setup code and entity data.
Promotes loading content separately from the engine.
Easy to debug by dumping state each frame.

[ ] Systems register to receive entities, rather than entities registering to systems.

When serializing and deserializing, it's important that systems work on the same entities deterministically.
Attaching a component at runtime or via an editor is enough to alter behavior, less chance to leave out a step and waste time debugging why an entity is not being processed.
Adding a new system does not require touching existing code.

[ ] Documentation for entire API.
[ ] Tutorials for common usage.

Medium:

[ ] ES6 based API.
[ ] Easily register blueprints/prototypes and easily create entities from them.
[ ] Updated within the last 6 months
[ ] Small and focused around providing an ECS and nothing more.

Low:
Probably not the most important in this context, but would be important in a more demanding game or in another language.

[ ] Entities are just an ID

But an entity class wrapping around an ID is perfectly fine.

 Compare Javascript ECS libraries


Changing variable name passed to closure via do construct

One common usage pattern that doesn't seem possible with Coffeescript's syntax is to rename variables passed into a closure. The most popular example I can think of is:
(function ($) {
  // code guaranteed $ variable
})(jQuery);

Using the closure operator do, variables passed into the closure cannot be renamed. Of course, you can manually create the closure doing:
(($) ->

)(jQuery)

but this syntax is not as pretty as it could be. Just a suggestion, thanks!

$ coffee -bep 'do ($ = jQuery) ->'
(function($) {})(jQuery);

Good to know this is possible, but on that note... things like this really need to be documented better. I had no idea that was even possible, and I've scoured the Coffeescript documentation.

I agree, but there's a lot that isn't documented in the quick intro at http://coffeescript.org. @TrevorBurnham's book is a good introductory book, but we need something that aims to be a comprehensive guide to everything coffeescript.


nvim fails to load 'gitsigns' lua module since 499e20f ?

Hi,
I'm not sure if this is a bug or not, but my nvim shows the following error when it tries to load 'gitsigns' lua module using require('gitsigns'):
E5108: Error executing lua [string ":lua"]:1: loop or previous error loading module 'gitsigns'

It started happening since 499e20f. before that, it loaded okay.
The nvim info is
NVIM v0.5.0-dev+1194-gc20ae3aad
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/runner/work/neovim/neovim/build/config -I/home/runner/work/neovim/neovim/src -I/home/runner/work/neovim/neovim/.deps/usr/include -I/usr/include -I/home/runner/work/neovim/neovim/build/src/nvim/auto -I/home/runner/work/neovim/neovim/build/include
Compiled by runner@fv-az166-905

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/home/runner/work/neovim/neovim/build/nvim.AppDir/usr/share/nvim"

Run :checkhealth for more info

I'm using vim-plug.
Can I get some help, please?
Thank you.

Is plenary up to date?

Is plenary up to date?

That did it, thanks!


[LINUX] Not Compiling

sudo cmake --build build -j $(nproc --all)
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/jerryyy/Osiris/build
[ 33%] Linking CXX shared library libOsiris.so
/usr/bin/ld: CMakeFiles/Osiris.dir/dllmain.cpp.o: in function std::__sv_check(unsigned long, unsigned long, char const*)': dllmain.cpp:(.text._ZSt10__sv_checkmmPKc[_ZSt10__sv_checkmmPKc]+0x41): undefined reference to std::__throw_out_of_range_fmt(char const*, ...)'
collect2: error: ld returned 1 exit status
gmake[2]: *** [Source/CMakeFiles/Osiris.dir/build.make:104: Source/libOsiris.so] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:98: Source/CMakeFiles/Osiris.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2
I get this error, I tried to fix it several times, not found any solution.

After repulling the repo with depth 1 somehow it worked.


Bypassing KeyVault alias for List command.

As seen in Azure/azure-sdk-for-go#403, it is mentioned that the KeyVault
swagger is strained because there is an alias for the resources list
function. Instead of endorsing a hack that changes out the targeted API
Version, we'll just publish the direct version.

Updating sample to show a hack-less way of bypassing issue Azure/azure-sdk-for-go#403.


Fix missing Makefile.in in Ruby 2.7

Starting from Ruby 2.7.0.preview2 (ruby/ruby@c7477c3), Makefile.in is no
longer in the root. Instead it has been moved under ./template/.
This patch fixes the problem by allowing makefiles in both places.
Note that this doesn't fix all the problems building Ruby 2.7. It fails to generate builtin_binary.inc but I'm not sure the proper way to fix it.

Thanks for your pull request.
But reusing "#{USER_HOME}/sources/#{RUBY_CC_VERSION}/Makefile.in.bak" for template/Makefile.in is ad-hok. I've fixed this by using ".../template/Makefile.in.bak for Ruby 2.7.

Confirmed to work. Thanks!

@knu Any chance to release 1.0.9? I'm just preparing rake-compiler-dock for ruby-2.7 and this patch is required.

Ah, sorry.
I've released it.


Enable professional-grade mypy

Finally, here it is!
After reading this blog post about "professional-grade" mypy, I began adopting the professional-grade config for ixmp4. This PR is the result of the process.
It type hints everything, though some type hints might still need relaxation or tightening. Even our test suite is type-hinted here. This allows us to trust all variables we're dealing with have the correct type. In particular, refactoring can be done with improved confidence as mypy would catch a wide variety of bugs if the refactoring doesn't fit the existing code. Having these type hints also helps with readability, I think, as it is one kind of documentation in itself. I found this process especially insightful for understanding how the filters work :)
Of course, this PR also bumps mypy to its latest version.
That being said, there are a few points where I think we can still improve the PR, or add improvements through a future PR:

For the create() functions in the DB layer, I often kept the *args and **kwargs since the facade layer often uses positional arguments, while the rest/api layer uses keywords. This is different from tabulate() and list(), which are generally only called via enumerate() and with kwargs, so this would be a place to streamline the signatures.
In data/abstract/meta, I needed to type hint the _type_map, for which I needed to use the built-in type. This led to confusion for mypy since meta already had an attribute called type. I have renamed the attribute to dtype to enable the type hint.
For most kwargs, I have learned that the best way to type hint them is by creating a TypedDict subclass, which explicitly spells out all possible kwargs and their types. I have not done so for some /base/ functions, which mainly act as templates or pass on all *args, **kwargs that they receive. When args or kwargs were unused, I sometimes removed them from the signature and type-hinted them as Any at other times, depending on how I understood the function's purpose. So there are currently two approached visible, which come down to different understandings of type hints, I suppose:
On the one hand, one could try to spell out everything explicitly how it is currently used. This improves the documentation aspect and enables mypy to catch more bugs before they reach production. On the other hand, this would block newly introduced kwargs until they are added to these kwargs-classes, which increases maintenance burden. Alternatively, one could convey the purpose of the function through the type hints, being more general. The pros and cons are essentially the inverse of the above.
For code that I didn't write, it's harder to correctly guess the purpose of functions, so I have generally opted more for the first approach. However, I'm open to discussion here.
Where I did write kwargs-classes, they are sometimes not organized as well as they could, I feel. In the DB layer, for example, EnumerateKwargs could often inherit from CreateKwargs at the moment. For the filter classes, spelling out everything like name__like is also lengthy, we could e.g. think of using mixins there.
For some /base/ functions that pass on their arguments, I used Any because I couldn't get the alternative to work: in theory, this sounds like a job for ParamSpec: "They are used to forward the parameter types of one callable to another callable". However, I couldn't figure out exactly how to do that. On that note, if you know a good tutorial on ParamSpec, I'd be happy to read it as this almost seems like magic to me right now.

Lastly, I applied some type: ignore markers where I couldn't quite understand why mypy was complaining or where I intend to refactor the code very soon, anyway. In principle, though, almost none of that should be necessary, strictly-speaking. "Code I want to change soon" mainly refers to the DB model for parameters, equations, and variables, where I expect a more performant model can make do without the whole column thing. And I would maybe also drop table entirely since this is used nowhere in the tutorials. This is less certain, however, which is why I did type hint table, still.

[!NOTE]
As so nicely displayed by codecov, we don't have 100% test coverage yet (that's another juicy small project goal...). So when reviewing this, please use the branch like main might be used to ensure that things we don't test did not get broken. In particular, this probably means running some CLI commands from this branch.

Another note: while working on this PR, I stumbled upon the setting disallow_any_generics = true. It is not active as of now, as that would introduce a few hundred more errors, but it would be an even stricter rule we could employ (to follow the spirit of using the strictest possible settings for mypy). This rule would prevent us from returning dict or list somewhere: all such generics would need to be explicitly specified as list[int] or some such. Happy to hear your thoughts on whether we should do that.

If we adopt this PR, we should also present a mypy badge in our readme :)

Okay, the update is here :)
It should clear the tests and mypy now, which has almost become strict (only missing no_implicit_reexport, which mypy's docs describe as "not too hard to get passing, but return on investment is lower".
I still need to do some cleanup, I want to look into your suggestion of recursive hints (and maybe employ some TypeAliases) in particular, but right now, I'll have to take a step back and check if we can already support Python 3.13 :)
After I do the cleanup, I'll still raise any remaining questions explicitly.


Binned implementation of PrecisionRecallCurve is extremely slow for large batch sizes

🐛 Bug
Since the classification metrics refactor in torchmetrics 0.10, the update step of PrecisionRecallCurve and metrics based on it (such as AveragePrecision) is extremely slow and memory-consuming when using the binned implementation with many samples. This is, for example, the case in semantic segmentation scenarios, where every pixel is a sample.
The binned implementation is intended to be both faster and memory efficient than computing the exact precision-recall curve. This is currently not the case.
To Reproduce
import torch
from torchmetrics.classification import BinaryAveragePrecision

targets = torch.randint(0, 2, (16, 512, 512), device="cuda")
preds = torch.rand((16, 512, 512), device="cuda")

metric_exact = BinaryAveragePrecision().cuda()
metric_binned = BinaryAveragePrecision(thresholds=200).cuda()

with torch.inference_mode():
    start_exact_evt = torch.cuda.Event(enable_timing=True)
    update_exact_evt = torch.cuda.Event(enable_timing=True)
    compute_exact_evt = torch.cuda.Event(enable_timing=True)
    start_binned_evt = torch.cuda.Event(enable_timing=True)
    update_binned_evt = torch.cuda.Event(enable_timing=True)
    compute_binned_evt = torch.cuda.Event(enable_timing=True)

    start_exact_evt.record()
    metric_exact.update(preds, targets)
    update_exact_evt.record()
    ap_exact = metric_exact.compute()
    compute_exact_evt.record()

    start_binned_evt.record()
    metric_binned.update(preds, targets)
    update_binned_evt.record()
    ap_binned = metric_exact.compute()
    compute_binned_evt.record()

torch.cuda.synchronize()

print("AP (exact):", ap_exact)
print("AP (binned):", ap_binned)
print("Time (exact): {} ms + {} ms".format(
    start_exact_evt.elapsed_time(update_exact_evt),
    update_exact_evt.elapsed_time(compute_exact_evt)
))
print("Time (binned): {} ms + {} ms".format(
    start_binned_evt.elapsed_time(update_binned_evt),
    update_binned_evt.elapsed_time(compute_binned_evt)
))

Output (using an RTX 3090):
AP (exact): tensor(0.5008, device='cuda:0')
AP (binned): tensor(0.5008, device='cuda:0')
Time (exact): 1.8867520093917847 ms + 4.845024108886719 ms
Time (binned): 10816.78515625 ms + 0.002047999994829297 ms

Binned average precision was 1600x slower than exact average precision.
The memory consumption of exact AP on the GPU was 260 MB, while binned AP consumed 20,000 MB.
Expected behavior
The binned implementation of PrecisionRecallCurve, i.e., with thresholds != None, should be faster and more memory-efficient.
Environment

TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source): 0.11.1 (pip)
Python & PyTorch Version (e.g., 1.0): Python 3.7.9, PyTorch 1.12.1
Any other relevant information such as OS (e.g., Linux): Linux

Additional context
The current implementation of _binary_precision_recall_curve_update compares all predictions with all thresholds at once, which is very memory consuming:
len_t = len(thresholds)
preds_t = (preds.unsqueeze(-1) >= thresholds.unsqueeze(0)).long()  # num_samples x num_thresholds
unique_mapping = preds_t + 2 * target.unsqueeze(-1) + 4 * torch.arange(len_t, device=target.device)
bins = _bincount(unique_mapping.flatten(), minlength=4 * len_t)
return bins.reshape(len_t, 2, 2)

Computing preds_t and unique_mapping is quite fast, but both consume large amounts of memory (number of samples * number of thresholds * 8 byte). _bincount, on the other hand, does not consume much memory, but a lot of time.
Iterating over the thresholds one by one is significantly faster (0.6 sec instead of 10 sec) and only consumes 150 MB memory:
confmat = thresholds.new_empty((len(thresholds), 2, 2), dtype=torch.int64)
for i in range(len(thresholds)):
    preds_t = (preds >= thresholds[i]).long()
    unique_mapping = preds_t + 2 * targets
    bins = torch.bincount(unique_mapping, minlength=4)
    confmat[i] = bins.reshape(2, 2)

Using the implementation of BinnedPrecisionRecallCurve from torchmetrics 0.9 is even faster (0.1 sec) and uses only 60 MB:
confmat = thresholds.new_empty((len(thresholds), 2, 2), dtype=torch.int64)
targets_t = targets == 1
for i in range(len(thresholds)):
    preds_t = preds >= thresholds[i]
    confmat[i, 1, 1] = (targets_t & preds_t).sum()
    confmat[i, 0, 1] = ((~targets_t) & preds_t).sum()
    confmat[i, 1, 0] = (targets_t & (~preds_t)).sum()
    confmat[i, 0, 0] = len(preds_t) - confmat[i, 0, 1] - confmat[i, 1, 0] - confmat[i, 1, 1]

I conducted some further experiments with respect to the number of samples, comparing the implementation of the BinaryAveragePrecision update step from torchmetrics 0.11 with that of torchmetrics 0.9:

#Samples
0.11 Speed
0.9 Speed
0.11 Memory
0.9 Memory

100
0.2 ms
23.8 ms
< 1 MB
< 1 MB

1,000
1.1 ms
24.4 ms
20 MB
< 1 MB

25,000
24.0 ms
25.8 ms
200 MB
< 1 MB

100,000
115.3 ms
25.5 ms
722 MB
2 MB

1,000,000
1,012.1 ms
26.7 ms
7,156 MB
2 MB

For small numbers of samples, the new implementation is in fact faster, but never more memory-efficient.
However, it's time consumption scales linearly with the number of samples, while the old implementation is almost constant with respect to the number of samples. It will scale with the number of thresholds though (I used 200 here).  This makes it difficult to switch between implementations depending on the number of samples.
I personally would be in favor of switching back to the old implementation. It is not the fastest in all scenarios, but the most memory efficient and does not get terribly slow for large numbers of samples.


Capability flags should be masked with version mask

https://github.com/DMTF/libspdm/blob/3a69c7bb0faccb2c5ac75c52d2d905fcf92d5510/library/spdm_responder_lib/libspdm_rsp_capabilities.c#L250C5-L250C73
Capability flags actually need to be masked with version mask(e.g. SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_12_MASK).
For example, if the responder supports multiple versions and different/new capabilities, the integrator would expect to set all the supported flags and rely on libspdm to report the flags according to version negotiation results.

This is also needed for algorithms. Ie, EdDSA ed25519 was added in SPDM 1.2.


Update DG Tag implementations

Closes #452.
Changes made:

Fix error in previous sequence diagrams for Tag functions
Add sequence and activity diagram for filtertag
Update TagFeatures section

Codecov Report

Merging #518 (ca449bc) into master (a2b37ef) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #518   +/-   ##
=========================================
  Coverage     65.53%   65.53%
  Complexity      730      730
=========================================
  Files           147      147
  Lines          2553     2553
  Branches        288      288
=========================================
  Hits           1673     1673
  Misses          742      742
  Partials        138      138

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


getNonceForAddress

I want get Nonce For Address

@NGUYENDANGVU-coder can I be assigned to this ?

Yes I'm open to adding this hook.

@fracek can I work on this ?

Hey @ShantelPeters we already have someone working on this sorry.

This will be in the next release dropping soon.


#18 - Implemented basic django admin view for DBTaskResult

Changes:

Configures basic settings to include django admin (+auth, static files)
Add basic django admin view
Django admins are configured to be read-only

Screenshots:

Ref #18

Changes in this push:

Added verbose name (to DBTaskResult and App itself)
Updated settings to not turn on DEBUG or default Task backend if tests are running
Improved admin display and removed delete/change actions


[CSV-239] Add javadoc to CSVFormat

As requested in #41, adds javadoc to new allowDuplicateHeaderNames methods,

Coverage remained the same at 90.807% when pulling e177f5dc37e737b0fcc1649ab08ac3096a610e0d on davidmoten:add-javadoc into dca99998f17a9755dfb40ed30bc1734e54ba0b04 on apache:master.

Merged. Thank you!


Docs pages reorganization

Reorganized the structure of the repo so that the pages match the structure of the TOC.

  This is the expected behavior of the build system.

OPS Build status updates of commit 23aeb9a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

project-rome-docs/TOC.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/api-reference-for-android.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/api-reference-for-ios.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/how-to-guide-for-android.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/how-to-guide-for-ios.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/how-to-guide-for-microsoft-graph.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/ios/api-reference/index.md
:white_check_mark:Succeeded

project-rome-docs/devicerelay/windows/index.md
:white_check_mark:Succeeded

project-rome-docs/includes/android/dev-center-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/android/notifications-app-registration-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/android/notifications-dev-center-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/ios/dev-center-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/ios/notifications-app-registration-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/ios/notifications-dev-center-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/windows/notifications-app-registration-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/includes/windows/notifications-dev-center-onboarding.md
:white_check_mark:Succeeded

project-rome-docs/nearby-sharing/api-reference-for-android.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-android.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/index.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotification.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationChannel.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationPriority.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationReadState.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationReadStateFilter.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationReader.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationReaderOptions.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationReaderStartPosition.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationStatus.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationStatusFilter.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationUpdateResult.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationUserActionState.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/MCDUserNotificationUserActionStateFilter.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-ios/usernotifications/index.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/index.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/index.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/userNotification.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/userNotificationChannel.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/userNotificationReader.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/userNotificationReaderOptions.md
:white_check_mark:Succeeded

project-rome-docs/notifications/api-reference-for-windows/usernotifications/userNotificationUpdateResults.md
:white_check_mark:Succeeded

project-rome-docs/notifications/how-to-guide-for-android.md
:white_check_mark:Succeeded

project-rome-docs/notifications/how-to-guide-for-ios.md
:white_check_mark:Succeeded

project-rome-docs/notifications/how-to-guide-for-windows.md
:white_check_mark:Succeeded

project-rome-docs/notifications/index.md
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/aad_registration_portal.png
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/aad_registration_portal_permissions.png
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/permissions_1_user.png
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/permissions_2_devices.png
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/permissions_3_graph_notifications.png
:white_check_mark:Succeeded

project-rome-docs/notifications/media/aad_registration_portal/permissions_4_wns_push.png
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Migration to HTTP/2 network protocol

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another Pull Request opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[x] Feature change (non-breaking change which change behaviour of an existing functionality)
[ ] Improvement (non-breaking change which improve functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

~This is currently experimental~
Last year the website is migrated to the HTTP/2 protocol
currently the web session is managed by the Requests module which does not support HTTP/2
This PR introduces the use of the HTTPX module, although the HTTP/2 support is still under development in this module seems to work well.
I think that the HTTPX module is the most up-to-date HTTP/2 module of this moment.
The HTTPX package is not provided with Kodi and is unlikely to be included for our request, because this add-on has not been approved for Kodi repository, it could be added if other approved add-ons will use this module,
in the meantime, you will need to include it as internal package including all dependencies and subdependencies.
This PR provides a first solution to this future problem and i think that this PR will not be included in the master branch until the current HTTP1.1 protocol will cause other problems with the endpoints or the website discontinue the support.
TODO List:

~To check if all dependencies and sub-dependencies of each module are in place~
~Check cookies code~
~Check TCP keep-alive communications~
~To implement close session on addon closing~
~Although HTTPX imitates Requests with similar properties/arguments a quick recheck of each method is needed~
~Test all endpoints (currently tested: login, main menu and playback)~
~Test standard login on various systems to ensure no regressions (to check if "Incorrect password" error will be fixed or worsened)~
Investigate for error: httpx.RemoteProtocolError: <ConnectionTerminated error_code:ErrorCodes.COMPRESSION_ERROR, last_stream_id:2147483647, additional_data:485041434b202d20696c6c6567616c20696e6465>happen only sometimes and after playing multiple videos, ATM cause not know, could be also an httpx bug (https://paste.kodi.tv/iyubevuxey) (UPD 23/06/2021 after updated all sub-deps seem there is no more errors at least on Windows)

From my tests this PR seem to fully fix the user+password login issues,
i have tried test logging several times on Windows, Linux Mint, CoreELEC with the result of 100% login success,
hoping it is not a coincidence it would be helpful if someone report login test feedbacks

I tested the login in a clean installation of Kodi 19.1 with the email and password and it worked without any problem without the need for using the authentication key, I'm using windows 10.

good to hear!

hi @betatester3016
when you will have time, can you do a test with this version?
plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1.zip
I need to know a simply thing, if the standard login (user+password) works without raise error "incorrect password",
please take attention when you write the credentials (to not invalidate results),
of course before delete previous addon versions and related data (if installed).
On systems:

Linux desktop computer (like ubuntu etc... as you prefeer, x86)
ARM device with LibreElec (or CoreElec)

I need to know a simply thing, if the standard login (user+password) works without raise error "incorrect password",
please take attention when you write the credentials (to not invalidate results),
of course before delete previous addon versions and related data (if installed).
On systems:

Linux desktop computer (like ubuntu etc... as you prefeer, x86)
ARM device with LibreElec (or CoreElec)

Sorry for the late reply: I'll look into that this evening.

@CastagnaIT Sorry for the late reply, I was of the grid for a few days. I'll look into it this evening.

@CastagnaIT

[x] Ubuntu 20.04.2 LTS on x86
[x] CoreELEC 19.2 RC2 on S905X3

I confirm being able to log in with username and password on both O.S. when using: plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1
No auth key needed

@CastagnaIT

[x] Ubuntu 20.04.2 LTS on x86
[x] CoreELEC 19.2 RC2 on S905X3

I confirm being able to log in with username and password on both O.S. when using: plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1

@CastagnaIT

[x] Ubuntu 20.04.2 LTS on x86
[x] CoreELEC 19.2 RC2 on S905X3

I confirm being able to log in with username and password on both O.S. when using: plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1
The results can be replicated by uninstalling and reinstalling the provided add on.

@CastagnaIT

[x] Ubuntu 20.04.2 LTS / Kodi 19 on x86
[x] CoreELEC 19.2 RC2 on S905X3

I confirm being able to log in with username and password on both O.S. when using: plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1
The results can be replicated by uninstalling and reinstalling the provided add on.

Thank you i am testing/using this version from about 1 month, and to me works good, i do not see wrong behaviours/errors
i'm thinking of merge it soon

Android 9 = Nvidia Shield TV
and plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1
No Problem with user+password login = no authentication key  = all OK

thanks for the report i think to include this on next release if i will find a bit of time


Proposal to remove redundant fields from Precomputed_values.t

The following fields in Precomputed_values.t are just rexported on construction:

genesis_constants
runtime_config
constraint_constants
probably more

These values are already being passed around all over the code base, to me it's confusing why they are accessible from more than one place and often appear alongside eachother. Can we just remove them and have one canonical source for each of these?

We shouldn't really be passing around Precomputed_values.t at all. It's supposed to be the inputs to the genesis proof, but because it had most of the info we want we just used it :(


Weird matTooltip behavior when assigned to a button inside a menu

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Tooltip shows only when mouse is over the according button.
What is the current behavior?
Under certain circumstances the tooltip of a button shows at a more-or-less-random position.

The first tooltip only disappears when hovering the button it originally was intended to for. When hovering over it again, the tooltip shows at the correct position.
What are the steps to reproduce?
StackBlitz: https://stackblitz.com/edit/angular-inhkax (I removed mat-toolbar and mat-toolbar-row, because they do not seem to matter in this bug)
StackBlitz for the workaround (from a SO-user): https://stackblitz.com/edit/angular-2bulfx
Basically following steps are necessary:

Create a button A
Create a menu, which opens when button A is clicked
Create another button B inside the menu with "mat-menu-item"
Set tooltip for button B
-> tooltip appears somewhere next to the button A on click

What is the use-case or motivation for changing an existing behavior?
A tooltip of a button should only appear when the mouse (or perhaps keyboard) is somewhere inside the bounding boxes of that button.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
I am using one of the most recent versions of Angular 6 (please have a look at the dependencies inside the StackBlitz as I cannot copy from there).
Browser-wise I have tried Firefox 61.0b9 (64-Bit), Edge, Chrome (cannot find out the version). The bug happens on every browser.
Is there anything else we should know?
I thought I might be doing something wrong, which is why I first asked a question on SO: https://stackoverflow.com/questions/50594537/weird-mattooltip-behavior-with-toolbar-button-and-nested-button. Apparently it is a bug, but there is a workaround, which seems to work.
Also: this bug seems to not have anything to do with the button responsible for opening the menu. However: only buttons with the mat-menu-item-directive are affected, meaning that if you use buttons with mat-button-directive instead, there is no misplaced tooltip when opening the menu.

The tooltip opens, because the button receives focus once the menu is opened. Yesterday we merged in a fix for the tooltip (https://github.com/angular/material2/commit/74f4364979f25a22e9dafee9c5b514551fbcc4ef) which makes it open only for keyboard focus and which should resolve your issue.

Somehow I am not able to test it yet (perhaps I cannot find the correct version? I have updated to<EMAIL_ADDRESS>and angular/material@6.2.0).
However: I would like the tooltip appear on mouse over, too, because that's default behavior for desktop applications (I agree with it not displaying on touch perhaps, but on mouse over? that's what tooltips were for in my opinion). Then again I can probably make them show / hide manually on trigger so it should not be a big deal, but it indeed would fix my problem from what I see. Not sure how to test it though...

The change was merged yesterday, it should be in the release.

Alright. Thanks. Guess I'll wait a bit longer, because https://www.npmjs.com/package/@angular/material says that the last push was 2 days ago, so it'll probably be in the next update there.
Thanks. Once I found out how, I'll test it, but you're most likely right.

I'll close the issue since I'm fairly certain it'll work and to avoid it getting too stale. Ping me here, if it's still there after the next release, and I'll reopen it.


Config and utils setup

I accidentally merged this pull request onto the USGS-R github instead of my personal one. Take a look anyways and let me know if you see anything that you want to have updated!


Option to deactivate overflow errors when running tests

Tests run with weird fonts, and sometimes it overflows, breaking tests. Some tests don´t care about overflow anyway, so there should be a way to deactivate them.
I have many tests which run ok in the simulator, but break in tests.
Please, allow us to deactivate overflow errors in tests.

The Ahem font overflows everything. We are forced to prevent overflows for widgets which will never overflow in reality, or else provide fonts for the tests just for the sake of not overflowing them. It makes no sense that overflow errors are tested, unless you are doing overflow error tests.

https://stackoverflow.com/questions/57499131/how-to-deactivate-or-ignore-layout-overflow-messages-in-flutter-widget-tests/57499255#57499255

Issue resolvida. https://stackoverflow.com/a/57501230/9440362


store: removed duplicate method call for the same method

the get func was calling path's Join and clean method which is already
being in internalGet(nodePath) func. Hence the func was getting called
unnecessarily twice which is not needed.
#6295

lgtm

@sinsharat Can I ask why do you still look at the v2 store? We pretty much move all of our focus onto v3.

@xiang90 actually at this point i am trying to understand the code of the entire product and how it works. In the process if i feel i can contribute in improving the product i just try to put it forward to you.
Rest of the details i will share offline to you. Thank you.

@xiang90 can you suggest if i have to discuss some things offline, where i can contact you?

@sinsharat Are you in bay area? You can contact me at<EMAIL_ADDRESS>

@xiang90 sure thank you.


Cannot run npm on Yosemite with node 0.12.5

npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.5
npm ERR! npm  v2.11.2
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'mime-db'

The present release of Samplestack isn't compatible with Node 0.12.
If you're in a hurry, you can try this branch, which is where changes for Node 0.12 compatibility are being made. I suspect it will work -- no assurances, though; It hasn't been formally tested, yet. https://github.com/laurelnaiad/marklogic-samplestack/tree/fixes


🍒 [5.7] Add CHANGELOG entry for #41849 and #42332

Original PR: #42360

@AnthonyLatsis do you mind rebasing this to fix the conflict?

Sure.

@swift-ci please test


Change generated code to use response.random()

Depends on #135
Once that feature is available, the generated functions under paths can be reduced to something like this.
export function GET({context, response}) { /* plus query, path, body and/or headers if any of them have parameters */
   return response.random();
}

Done. Not sure why this issue wasn't linked.


Function Literal formatting seems off

function-literal (docs) formatting seems off.
When calling into this function:
@file:Suppress("NO_EXPLICIT_VISIBILITY_IN_API_MODE_WARNING")

package com.capitalone.android.identity.challenge.internal.logic

fun <T1, T2, R> combine(
    result1: Result<T1>,
    result2: Result<T2>,
    transform: suspend (T1, T2) -> R
) {
    TODO()
}

Expected Behavior
I would expect something like this:
fun usageExpected(result1: Result<Int>, result2: Result<String>) {
    combine(
        result1 = result1,
        result2 = result2
    ) { one: Int,
        two: String ->
        "$one$two"
    }
}

Observed Behavior
But instead, we get this:
fun usageActual(result1: Result<Int>, result2: Result<String>) {
    combine(
        result1 = result1,
        result2 = result2
    ) {
            one: Int,
            two: String
        ->
        "$one$two"
    }
}

The parameters (one: Int and two: String) being indented an extra 4 spaces seems very off to me.
Your Environment

Version of ktlint used: 1.3.1

Duplicate of #2816


Fix the validators to support unknown values

Check if the ID and RoleARN are not empty string only if the value is known This enable to use unkonw values like pointing to a different resource output
This PR comes to solve the issue 363

/approve
/lgtm


As a pro user, I should be able to subscribe to pro memberships and update my user information.

Implement Pro Users Subscription and Update User info feature.

Description: Implement and document the backend routes and services for the Plus and Pro Users Subscription and Update User info features.

@FernandoSLuz @ronaldocaldeireirojonson i think this project could help us achieve a good portion of this task for the front-end: https://vercel.com/templates/next.js/tier
we can clone the pricing model from the above links and make it our own. We can sync it with our Stripe "Test Mode" for both our dev and staging environments. We can also push this model to prod as shown in the project, by making use of the Tier CLI using this command where you use the model builder link and set a environment variable called STRIPE_API_KEY which should be a restricted key generated will all permissions in our Stripe live mode.


fix: Dockerfile.provisioner

This conflicts with https://github.com/TBD54566975/ftl/pull/3135
It had some weird istio RBAC errors I am still trying to figure out, as it works fine for me locally

Ah right, maybe I will wait for that to come through.


nixUnstable: 2.4pre20201102_550e11f -> 2.4pre20201105_387f824

Motivation for this change
Most notably

Fix a memory corruption and deadlock caused by new constant-memory source filtering implementation (+ fix implementation error)
Fix nix-copy-closure with drvs
Fix a varargs error in an error message (also a crash?)

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

So just realized that with a nix-daemon on latest nix master (i.e. this revision) all started builds stall, even without Hydra making a rollback to a previous configuration necessary.
Hence :-1: on merging this.

I agree with the statement from @Ma27

NixOS/nix#4235 is currently the only remaining issue. I've added a patch for it to make this branch useful for testing.
I don't think we should be patching Nix here, but for now it's useful for those who want to give this PR a spin.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/to-flake-or-not-to-flake/10047/5

Closing in favor of #104289, in order not to break any pins on this old branch.


Not able to import numpy in VSCODE

Issue Type: Bug
I have numpy installed on my machine but not able to import in vs Code. How it is done? can anyone help?
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-8130U CPU @ 2.20GHz (4 x 2208)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.89GB (0.76GB free)

Process Argv
--crash-reporter-id 7cfeb823-9445-4adc-836b-d3e53e79e668

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.2.0

vscode-docker
ms-
1.9.0

python
ms-
2020.12.424452561

jupyter
ms-
2020.12.414227025

code-spell-checker
str
1.10.2

vscode-icons
vsc
11.0.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python763:30178808
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30211401
wsl2promptcf:30224613
pythonvsdeb440:30237827
unusedprompt:30224610
folderexplorer:30224614
openfilemenucf:30224648
pythonvsded773cf:30236630
pythonvspyt600cf:30239449
vsjup459:30237187

/extPython

It worked . I have reset all th workspace settings and removed all the exts
. Then tried and it worked.
On Wed, 30 Dec 2020, 02:04 VS Code Issue Triage Bot, <
<EMAIL_ADDRESS>wrote:

It looks like this is caused by the Python extension. Please file it with
the repository here https://github.com/microsoft/vscode-python. Make
sure to check their issue reporting template and provide them relevant
information such as the extension version you're using. See also our issue
reporting https://aka.ms/vscodeissuereporting guidelines for more
information.
Happy Coding!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/113433#issuecomment-752232408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZVYJWBNU3N4DZUFGVHTXLSXI4NHANCNFSM4VJOQ74Q
.


Add ACME-DNS certbot plugin

uses https://github.com/pan-net-security/certbot-dns-acmedns in to implement ACME-DNS support.
Requires file in /data with the following layout and permissions 600
# cat /data/acme-registration.json
{
  "something.acme.com": {
    "username": "6e14735c-2c6a-447e-b63d-a23ac4438bd7",
    "password": "dd6gnYS-IxrQfDLbdPRX3hrFhS_SLrwbS0kSl_i8",
    "fulldomain": "3b750a0e-c627-423f-9966-4799c6a9533b.auth.example.org",
    "subdomain": "3b750a0e-c627-423f-9966-4799c6a9533b",
    "allowfrom": []
  }
}

Follow setup at https://github.com/joohoi/acme-dns

Implements #884

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-946

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-946

I tested the plugin and it works fine, thanks for creating the PR.


User testing issue - links aren't visible enough

We've been running some user testing via a third-party company over the last little while. They were testing the new design and implementation of our site, based on the UI toolkit. Their interim report from 22 May 2017 said:

Links don't stand out from body text
In many cases participants did not initially notice key links within / amongst body text. Participants have indicated that they think links could be clearer or bolder in relation to non-link text.

We've changed our link text to a blue that matches our design, the hover to be a lighter blue, and visited to be a dark grey. There is no perfect colour for this so I haven't submitted a PR.

Thanks for the feedback Mark. This is something that hasn't come up in testing here at the DTA and maybe a symptom of content presentation and IA. Improving how 'key links' are presented with a good content strategy could help this. We'll also look in to how we might improve links within body text.

Hi @mgdhs
This should be fixed now with the new body version 1.0.0. Please have a look here: https://gold.service.gov.au/components/body/


Is this really necessary? :)

Have you tried the other option of adding the following to web.config, which is much less work (in system.webServer/rewrite/rules):
    <rule name="AcmeChallenge" patternSyntax="Wildcard">
      <match url=".well-known/acme-challenge*" />
      <action type="Rewrite" url="{R:0}/index.html" />
    </rule>

But, if I get this right, it will require me to move verification file manually to index.html, is not it? So, it means, that once in 90 days it will require manual action... It is OK if you have one web app, but if you have dozen of them?

I'm not sure what you mean? What is it exactly that you do now?

Currently, I used code to check, if there is a file in .well-known folder and serve it as a static file. Rewrite rule you are proposing (if I get it right) - will redirect all request to index.html
Let's Encrypt in Azure wep app creates a check files
So, to verify my web app, it will request this file
curl http://web_app_url/.well-known/acme-challenge/UtxCs7-lA4m-zkK-HdS7h0YwNrQRQS5s4h2vuwjKp08
Rewrite solution requires me to move UtxCs7-lA4m-zkK-HdS7h0YwNrQRQS5s4h2vuwjKp08 to index.html manually.
Owin startup solution does not requires me to do anything manually, allowing automatic verification once in 90 days - so, despite of slight overhead it adds, it is much more profitable IMHO. Do not you agree?

Also, I checked rewrite solution - for me it does not work :( It redirects and returns error 500

if there is a file in .well-known folder and serve it as a static file
so what kind of a file is this? and how do you update it's content?

Yes, there is a file, but it is generated as extensionless file, and, as described here - https://www.jdibble.co.uk/blog/using-letsencrypt-with-umbraco - Umbraco intercepts extensionless requests and tries to map them to Umbraco items. And finally, it generates 404 instead of trying to serve a file.
File is generated automatically along with a content by Let's Encrypt extension for Azure web app

Ah alright then. Yeah, I create it differently, I actually create http://web_app_url/.well-known/acme-challenge/UtxCs7-lA4m-zkK-HdS7h0YwNrQRQS5s4h2vuwjKp08/index,html.
Alrighty then, this seems to be useful for people then! Issue closed.


Flags Germany/Russia

Summary
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated (docs/docs/en)
[ ] Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

[ ] Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Bitte ein einziger PR und nicht 3. Wir sind hier im Pull Request Bereich und nicht im Test Center. Danke

Bitte ein einziger PR und nicht 3. Wir sind hier im Pull Request Bereich und nicht im Test Center. Danke


Shifting the theme button

can you please assign this under gssoc, so that i can make a pull request?
i want to replace the theme buttton , As its not appealing now.after vs before versions are attached below for your reference

Make sure it will work correctly.

We have to enhance the the logic of theme button. issue : THEME FEATURE #83

i want to reopen this issue, there is a bug in code .One function has been removed and we are getting error, i used another approach. Can you please reopen this?


Remove soap ws scanning operations

We removed the SOAP web services in 96cfceb but failed to remove these
methods.
Note:  There's lots more to delete in VmdbOps/SharedOps/MiqVerbs/WebSvcOps and consumers of MiqservicesClient, but this PR was manageable.

cc @gmcculloug @Fryguy

:+1: :fire:

I was sure that certain ones of those were still used, even though the callers were not going through SOAP...like the internal SmartProxy
But, that could be long gone...not sure. @gmcculloug ?

Looks like most of these are safe to remove but @roliveri should review since the code for scanning has been reworked since I last looked at it.

Looks like most of these are safe to remove but @roliveri should review since the code for scanning has been reworked since I last looked at it.

Yes, it looks like the ScanningOperations module was copied to models/mixins/scanning_operations_mixin.rb as a mixin in f9c71b6a62d5130fa0528cc8dacce63851500f3f and all the copied code that is now used has _op suffix, such as status_update_op, but all the other copied but not renamed methods are completely unused in models/mixins/scanning_operations_mixin.rb.  The original ScanningOperations is only used for a handful of methods that could be further investigated and removed.

ASIDE: @gmcculloug @roliveri is the Verbs directory even used anymore?  The option parsing in MiqVerbs.rb was used for the old miqhost that has been removed many months ago.  I don't see anything require it either.  If that's not being used, I believe the whole Verbs directory is unused.  The more unused code, the more newcomers have to comb through and upgrade with new versions of rails/ruby.  I'd rather just :scissors: :fire: it than continue to maintain old unused code.

Thanks for doing this LJ.
Do keep in mind that the REST api sometimes leverages the soap code.
But think those code paths are very discoverable

Thanks @kbrock, that's true, I don't believe the rest-api is using the mapping of the old SOAP methods, but yeah, if I can get @abellotti to confirm, that would help.
I'm just trying to get rid of the old cruft so it's not constantly in the way on upgrades or when I git grep things.  If we need this stuff, we can checkout botvinnik or capablanca and resurrect it.  I will personally help anyone who's unsure of git.  We cannot keep dead code around considering we have over 100 contributors who may look at this old stuff and think it's here for a good reason.

I am thinking PR #3733 removed the need for most, if not all, of the Verbs directory.  @roliveri

@jrafanie @kbrock I think if they are methods available to the REST resource, they will be queryable. I'm looking at https://bugzilla.redhat.com/show_bug.cgi?id=1316578 which is describing exactly this issue.

The only Ws methods the Rest API call uses are AutomationRequest.create_from_ws and MiqProvisionVirtWorkflow.from_ws, common create methods used between REST and SOAP for /api/automation_requests and /api/provision_requests. I'm good with this PR. :+1:

@imtayadeway hardware can be queried in REST via virtual attributes, including the ones that were returned with ws_attributes, they just have to ask for them individually via attributes=.  For the BZ mentioned we could give them an example of what the query would be. Optionally we could provide a helper method (vm specific or mixin that would grab them all for convenience).  Thanks.

I don't think it's used by SSA any longer. I say we remove it and address any breakage if encountered.


Что такое Kubernetes

/triage needs-information

@ILF76 , I am not getting  what you are looking for . So please raise the valid issue with correct description in english.

Please try to  give the heading and description of issue  in English only  So that it can be easy for community to look into it.

It's OK to put a localized page title in the issue description but we also need to know what else we're being told: eg, Typo in page Что такое Kubernetes
Also, please put the page URL in the issue description.

@ILF76   Thank you for your contributions try contributing with proper description and in English . If you think the issue is needful then you can reopen it or  raise the new issue.

For now i am closing this issue marking it as not planned
/close not-planned


feat: preserve commit history and add --fresh flag

BREAKING CHANGE: No longer creates orphaned commits by default

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fairplay Issue

Fails to play the next users queued song.
Randomly picks previously played songs.
Causing a loop sometimes.

Can confirm, in my case it usually jumps back to the first song in the queue list.

Having this issue as well. Anyone else?

Wondering if there's an update on this~~

Still broken.

Hacktoberfest is over :p

And it's still broken.

The cause of the issue seems to be that the fairplay code grabs a copy of the playlist, shuffles it and then finds the index of a fair song. The index gets passed back to the musicQueue object, however since the index was based on a shuffled queue and the original queue remains unchanged, in the original queue the index is not really fair.
If the shuffle is removed from the fairplay code, it would fix the index mismatch problem, but then the player would loop through the first added song of all the people on the list. Having sad(song auto delete) enabled would be an easy way to get the intended behavior.

@floopfloop thanks for the insight :) I will look into it.


Emulate Rambox UI top tab bar

Currently Ferdi has all of the services down the left side in a vertical fashion. Rambox has workspaces (called Groups) down the left side and then the services in a top tab bar.
It would be nice to, at the very least, allow us to have the services across the top instead of down the side.  But it would also be nice to keep the "workspace" drawer open and have small icons, more like this:

This would need to be an optional setting - I like the current layout and don’t like the way Rambox handles this.
This could be a setting in the appearance settings (but it looks like it would be too involved to implement as a small setting like this)

The problem is that some of us use Ferdi on monitors where it makes sense to consume more vertical space than horizontal due to limitations across. In my case I have a few windows on one display and losing this horizontal space is very painful. Thus I would like to be able to have the left sidebar (if it exists at all) as small as possible - or hideable, while having the services predominantly across the top.

The more I think about this, the more I realize the importance of this in relation to this issue:
https://github.com/getferdi/ferdi/issues/62
If we had a small workspace switcher it would be more conducive to actually using workspaces.  Presently using workspaces no only takes two clicks, BUT "out of sight; out of mind" is extremely powerful. If we had this side/tob bar arrangement it would be more conducive to using lighter weight workspaces during times where we'd like to use fewer services or dedicated workspaces, etc.

i second the request: although vertical space is more precious, i've found the Ferdi sidebar not mixing well with services having their own sidebar, which is making the GUI more confusing imo.

Closing this for now as this is a relatively large feature and it looks like there are only few users who are interested in this. I still think that vertical space is more limited and that it makes more sense adding the bar the left side instead.

We could compromise and let the feature request open for now until one of us or someone else can pick it up. I think we could include in the specs that Ferdi should keep it's original layout by default; but proposing different layout could be an interesting feature, especially to attract users of other similar software that are used to said layout. It's quite a big feature I agree, but could be worth it and is already requested by the community, so let's maybe re-open it?
@ylluminate There is higher priorities being worked on at the moment, so please bear with us, that might not be implemented any time soon 🙏

Completely understand and I understand it's not at the top of the list. It's going to be useful and desirable - certainly not something to be forgotten.

If there is actual interest in this we can reopen it, it just looked like there was very little interest in this and I tried closing some old feature request that don't seem to receive enough interest to justify implementing them - I think we need to be careful as to not clutter Ferdi's code with features that are bearly used but may be hard to maintain.
This feature would need a separate stylesheet that gets imported when the setting is active and that overwrites the existing styles. We mainly need that stylesheet as implementing the setting to import it will be trivial to implement.

I am now currently working on implementing this over at #567 as I saw that we need less style code than I initially thought. I would be nice if people who are interested in this feature can build and test the new option to see if everything works as expected.

Hey. I thought I'd piggyback on this issue since it's the only one I found related to the sidebar.
I'd like to be able to make the sidebar hidden unless I hover over. I find it pretty distracting.
Maybe some of you guys can point me to where I'd code this?
Thank you so much for all this.

@arielaco Thank you for your interest. The sidebar is implemented in https://github.com/getferdi/ferdi/blob/develop/src/components/layout/Sidebar.js while Sidebar-related styles are stored in https://github.com/getferdi/ferdi/blob/3a449c20f72ad8a9fd54331b5dc3a5c92989d404/src/styles/tabs.scss

Hi @vantezzen,
Any way to get a version with the sidebar being at the top?
Maybe I've missed something but I'm definitely interested in testing it. I also feel uncomfortable with double sidebar (Ferdi + Slack for example)
Let me know!
Thanks :-)

@AlexKalyo You will currently need to set up a development instance of Ferdi on your computer (https://github.com/getferdi/ferdi#development) as we still need people to test this before we can merge it in.

Thank you so much for adding this into the most recent Ferdi builds. Beta 6 is fantastic!
Just a note, the "Service icon size" only works without a strange vertical scroll for "Very small icons" therein - also the two settings interacting with each other have strange results likewise, but interesting:


ERROR  RangeError: Can not convert <> to a Fragment (looks like multiple versions of prosemirror-model were loaded)[Bug]:

What happened?
While clicking enter in ngx-editor getting range error in google chrome.
Version
14.2.0
Angular Version
16.2.14
What browsers are you seeing the problem on?
Chrome
Link to reproduce
No response
Relevant log output
No response
Willing to submit a PR?
None

Try deleting lockfile and node_modules and re-install again?

I deleted my node_modules and reinstalled it, but it still doesn't work for me.

Hello, I encountered the same issue today and noticed this happens only when we select the end of the text.
Version : 15.3.0
Angular version : 14.2.12
Browser : Chrome
It looks that Enter adds a <p> tag while Shift + Enter adds a <br> tag. Is there any fix or turnaround to prevent default and manually trigger <p> addition at the current position when pressing Enter key

Any update on this? @MaximeOpsommer did you find a workaround?
Deleting node_modules and package.lock and reinstall does not work for me.
I had to add the following in package.json to make it work. Then I had to delete lock file and node_modules and reisntall
"overrides": {
    "prosemirror-model": "1.19.3"
  },

This was the previous corrupted package dependency before

Updating to<EMAIL_ADDRESS>resolved the issue for me. It installs only one version of prosemirror-model

Any update on this? @MaximeOpsommer did you find a workaround?

Nope, my solution was to move to ngx-quill :sweat_smile:

I'll add a documentation for this. This is often repeated and happening because of prosemirror transitive dependencies. The only solution is to re-install prosemirror packages so there are no duplication. And make sure its not installed separately or by any other packages. This mostly happens during the package update I guess.


Add CUJ docs to conduct User Study.

Adding CUJ docs with minimal notes which will be availabe for anyone to
conduct a user study.
These docs contain set of exercies with config, answers to these exercises.
This is to help @bobcatfish  and @aaron-prindle (or any other volunteer) help conduct the exercises.

Looks great! I think my only feedback is wondering if we should add some other docs in the first exercise, but I'm not sure if that defeats the purpose?
/lgtm
Remove if you want to merge as-is:
/hold

/cancel hold

/hold cancel

/lgtm


pilipala: init at 1.0.24-unstable-2024-11-13

PiliPala: Third-party BiliBili client developed with Flutter. https://github.com/guozhigq/pilipala
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why are you adding pilapalax (https://github.com/NixOS/nixpkgs/pull/360265) at the same time? Do we really need to have two apps at the same time?


[Follow-up] Context of elliptical fit for CompassDirection

For the behavior part of the Markowitz/Winthrop conversion, we have a CompassDirection container of a single radial SpatialSeries series named OrientationEllipse with description="Mouse orientation in radians estimated using an ellipse fit."
Overall this is a decent representation as far as NWB goes, but related to the experimental design/processing/analysis it is not super clear to me exactly what that means; @pauladkisson can you explain it to me more in this issue and we can discuss how to improve the description/name of the object to further clarify for future re-users?

From the paper, MoSeq: Preprocessing
"""
MoSeq consists of two essential workflows: one for pre-processing depth data and converting it into a low-dimensional time series that describes pose dynamics, and another for modelling the low-dimensional time-series data. As previously described, in order to focus on pose dynamics, raw depth frames were first background-subtracted to convert depth units from distance to height from the floor (in millimeters). Next, the location of the mouse was identified by finding the centroid of the contour with the largest area using the OpenCV findcontours function. An 80 × 80 pixel bounding box was drawn around the identified centroid, and the orientation was estimated using an ellipse fit (with a previously described correction for ±180-degree ambiguities4,27). The mouse was rotated in the bounding box to face the right side. The 80 × 80 pixel depth video of the centred, oriented mouse was then used to estimate pose dynamics.
"""

Digging deeper into the methods of one of the cited papers, I found this description for a bit more detail:
"""
To subtract the background image of the arena, the median value of the first 30 seconds of data from any imaging stream were taken, and subtracted from all video frames; any spurious values less than zero were by default reset to zero. The image was then binarized and any objects that did not survive three iterations of morphological opening were eliminated. The mouse was defined as the largest object within the arena that survived the subtraction and masking procedures. The centroid of the mouse was identified as the center-of-mass of the preprocessed image; an ellipse was fit to its contour to detect its overall orientation. In order to orient the mouse along the axis of the spine, a random forest classifier was trained on a set of manually oriented mouse images to facilitate automated identification of the head and tail. Although this algorithm was nearly always correct, its output was manually supervised to ensure accuracy. Note that this procedure does not directly identify the spine, but that the ellipse-based alignment procedure has the effect of aligning the animal along this anatomic axis. During episodes when the mouse was reared directly upwards (and therefore appears as a circle against the sensor, which is orthogonal to the axis of the mouse’s spine under these conditions) neither a human nor our algorithm can identify the spinal axis; because we model pose dynamics based upon dimensionally-reduced representations of the pixels (rather than extracted scalar features, like orientation or length), the presence of this symmetry does not adversely affect model performance, and synthetic data generated from the model appropriately captures these rearing episodes without “flipping” the mouse along its spinal axis.
"""

OK, I see now thank you
In light of this I'd request a small PR changing the name of that compass direction spatial series to just HeadOrientation and something in the description mentioning how it used the find contours and elliptical fit
Reason being, it being the name of the entire neurodata object makes it seem like the ellipse part is really important to the experiment, where from this its just an implementation detail about how they estimated the which direction the subject was facing


Rename 'StatsRecord.recordWithExplicitTagContext' to 'record'.

See https://github.com/census-instrumentation/opencensus-java/pull/676/files#r146735409.

Coverage remained the same at 79.387% when pulling 534a586dc1aba439da0271129c57a91219c4de2d on sebright:rename-recordWithExplicitTagContext into eb0ddd49703f0b505a4cd1bc4308f79719acf24e on census-instrumentation:master.

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #728   +/-   ##
=========================================
  Coverage     77.63%   77.63%
  Complexity      767      767
=========================================
  Files           142      142
  Lines          3590     3590
  Branches        331      331
=========================================
  Hits           2787     2787
  Misses          740      740
  Partials         63       63

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/io/opencensus/stats/StatsRecord.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...i/src/main/java/io/opencensus/stats/NoopStats.java
96% <ø> (ø)
4 <0> (ø)
:arrow_down:

.../io/opencensus/implcore/stats/StatsRecordImpl.java
100% <100%> (ø)
6 <1> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0ddd4...534a586. Read the comment docs.


Stop the solver with callback

Use delta objective to stop the solver when using callbacks.
O.w, it went on until MAXITER was reached and because of the timeout only did one run and results were biased (see comment below, thank you @agramfort for noticing the problem).
See nlls PR for a plot.

EDIT: when doing a run without callback, there is some sort of warmup done by the first step, so there is no harm done for the rest of the run. For example, on the plot in nlls PR, we see the PGD in blue at the very beginning much higher in time.
With a callback, this warmup impacts the whole run (more exactly the first rep), as we can see on the same plot with the large shaded orange area... So I made a warmup turn for callback strategy and we get this (which is i.m.o much better, we don't have any danger of seeing this big polygone over everyone anymore). And we can also see here in light blue for PGD acceleration=False that at first, it takes more time (and the csv file tells us that it's only more for the first run).

If you want to put a warmup for everybody or chose to do something else instead (or even at another time), feel free to tell me.
PS: the warmup may also help for Numba/packages that need a computation first, to only count the run without the computation that happens once.

Codecov Report

Merging #149 (b086fee) into master (963b862) will decrease coverage by 0.44%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   70.01%   69.57%   -0.45%
==========================================
  Files          36       36
  Lines        1561     1571      +10
  Branches      250      253       +3
==========================================
  Hits         1093     1093
- Misses        390      397       +7
- Partials       78       81       +3

I didn't know for the compilation thanks for that.
And what I call "warmup" is simply one more rep that isn't stored for the plots/medians (just like what you did with numba, but not made by the user in the solver file, rather directly into the runner).
I don't know why this happens (there is no compilation with PGD as far as I know), but it does
See for example another I found for the PGD with MCP here in benchopt results at the first point there is a large area, meaning that there was a run (the first) which took way longer than the followings.
And it wasn't really impactful without callbacks as it only changed one value of one run
But with callbacks, it impacts the whole first run (technically still the 1st one of the 1st run, but there is intra dependance for the runs now). And without correction, this leads to a big part of the plot shaded (like I posted on your nlls PR) and it isn't good looking.

I didn't know for the compilation thanks for that.
And what I call "warmup" is simply one more rep that isn't stored for the plots/medians (just like what you did with numba, but not made by the user in the solver file, rather directly into the runner).

I am a bit uncomfortable with this. A repetition can be a lot of time.
For large datasets I always set -r 1

I don't know why this happens (there is no compilation with PGD as far as I know), but it does

can you add to the PGD class the call to run(1) to see if it fixes the
pb like we do for numba?
maybe it's the time to load numpy linalg in memory?

And it wasn't really impactful without callbacks as it only changed one value of one run
But with callbacks, it impacts the whole first run (technically still the 1st one of the 1st run, but there is intra dependance for the runs now). And without correction, this leads to a big part of the plot shaded (like I posted on your nlls PR) and it isn't good looking.

let me know if the suggestions above help

Yes, I didn't think of that...

That is the results with a run for PGD in nlls. The blue shade (standard PGD with iteration strategy) for the first point is removed with a self.run(1) and the orange shade (PGD with callback) with self.run(lambda _: False) so we do not enter the while loop.

Actually, I had something a bit more complex in mind for two reasons:
I would like the behaviors to be the same for all stop_strategy with factorized code.
I would like to be able to simply change the behvior to introduce better stopping criterion.
I proposed PR #151 for this, let me know what you think about it.

Closing this one as we merged #151.
Thx for the proposal @tanglef !


Batch requests as workaround to notion api 100 row limit

Hi rfdearborn, Junior/Mid-level Data Engineer here.
I added support for appending to models that have more that 100 columns. It even works when there's no blocks, using the appropriate Notion api function (PATCH/POST/GET). It's being used in production and proves to be a great workaround to the 100 row limit. It can override already existing columns and maintains most of the original code structure with this one added benefit.

Thanks for this @pythonpaul! Will try to carve out time to review this week.

Hey again @pythonpaul - sorry for the delay here! This weekend I've added tests to this project to make it easier to contribute and review. Would you mind rebasing this PR to incorporate them?

@rfdearborn hey just read this, I will rebase the pr to incorporate the test sure thing


Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 3.6.14
ORIGIN: https://github.com/Homebrew/brew
HEAD: 001bacee18c512657e1535dff757c8cfdaefc116
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 64dbb36bcaf850924b361de143030d2d6f0ce055
Core tap last commit: 13 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 2.6.8 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 14.0.0 build 1400
Git: 2.37.1 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.6.1-x86_64
CLT: <IP_ADDRESS>.1.1666437224
Xcode: N/A

What were you trying to do (and why)?
I just updated my box to Monterey and wanted to upgrade by homebrew installations by running brew upgrade
What happened (include all command output)?
e104364@C02F830SMD6P ~ % brew upgrade
==> Upgrading 2 outdated packages:
glib 2.74.0 -> 2.74.3
xz 5.2.7 -> 5.2.9
==> Downloading https://ghcr.io/v2/homebrew/core/glib/manifests/2.74.3
Already downloaded: /Users/e104364/Library/Caches/Homebrew/downloads/01c3163ee1a0c27ac19bed96f462ae592a3efd7928caf9641ede4238ccbb552c--glib-2.74.3.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/glib/blobs/sha256:55aebc872575b
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sh
curl: (18) transfer closed with 6485792 bytes remaining to read
Error: glib: Failed to download resource "glib"
Download failed: https://ghcr.io/v2/homebrew/core/glib/blobs/sha256:55aebc872575b6c4a49bc8b45755b030bc0cedd258f955adfd2d44c15cccdc20
==> Downloading https://ghcr.io/v2/homebrew/core/xz/manifests/5.2.9
Already downloaded: /Users/e104364/Library/Caches/Homebrew/downloads/b948468605557bcd8fe2d2e0dca89971ccfa793d966e4d0daea9c49041b9de93--xz-5.2.9.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/xz/blobs/sha256:0ad360d7faae284
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sh
curl: (18) transfer closed with 462255 bytes remaining to read
Error: xz: Failed to download resource "xz"
Download failed: https://ghcr.io/v2/homebrew/core/xz/blobs/sha256:0ad360d7faae284e54fd50c09a86871ff65be56f78537386d3d97b1df9db34b8
What did you expect to happen?
I expected the packages to download and install
Step-by-step reproduction instructions (by running brew commands)
Simply run brew upgrade

as I thought that it perhaps was my network

It is, sorry.


Extraction of zip file is read from SNAP_ROOT dir instead of PSL9_IP_CORE

In snap/snap_env.sh, user specifies a path to ibm.com_CAPI_PSL9_WRAP_2.00.zip file and assign it to PSL9_IP_CORE variable.
In psl/Makefile, the zip file is searched in current snap path regardless of the PSL9_IP_CORE path!
Thus it is impossible to specify a path to a zip file which is not in the current snap path.

wrong statement but problem of missing zip file must be improved


proof of concept of pitch modification

I should do this first as it might inform #38, which is quite an important puzzle piece

that was simpler than I expected! i love the web audio API!!


Switching apps doesn't keep read position anymore

Since version 5.700 k9 always jumps to the top of the opened email when switching to another app and back to k9. This was previously only happening when the activity was killed and restarted. Now it's always happening.

This seems to be different than the issue fixed with #4390.

This annoyingly also happens when the screen turns off while reading a long email.


Earth Defense Force 4.1: Some HUD elements are not visible

As shown on the screenshots in https://github.com/ValveSoftware/Proton/issues/1193#issuecomment-541857399 since DXVK 1.4.0 some elements like the character model on the menu screen and HUD elements like the minimap and ammo counters are not visible anymore.
Apitrace was created on Windows but since the game was very slow I had to force quit it on the loading screen into the mission, the ingame UI was already visible at that point though, so I hope there's enough in there.
Software information
Game: Earth Defense Force 4.1
System information

GPU: Vega 56
Driver: Mesa 19.2.3
Wine version: 4.11 (Proton)
DXVK version: >= 1.4.0

Apitrace file(s)
https://mega.nz/#!blFkRIgZ!Jr3HfTnrrdUfQtGctQgSHyXeizKnhoOyNMtbGxvwzWg
Log files

d3d11.log:
EDF41_d3d11.log

Replaying the trace looks like this for me, is there anything wrong here? Also, can you reproduce the problem when using DXVK on Windows or does this only happen on Proton?

Your replay looks fine, on that screen the character model on the right would be missing.
I used 1.4.4 on Windows and aside from fullscreen being broken there were no issues, everything showed up correctly.

Does this mean that 1.3.x works fine even with Proton 4.11?
Yes, I've been using Proton 4.11 for all this and just swapping out the dlls, all 1.3.x releases are fine, 1.4.0 is the first with the issue.

I used 1.4.4 on Windows and aside from fullscreen being broken there were no issues, everything showed up correctly.

If that's the case, it's probably not a dxvk bug but some weirdness around mesa (or wine, but unlikely); can you test whether it works with amdvlk? If not, can you bisect which exact commit between 1.3.3 and 1.4 introduced the issue?

The issue still happens with both amdvlk and mesa-git with and without aco enabled.

If not, can you bisect which exact commit between 1.3.3 and 1.4 introduced the issue?

Sure, if I did this correctly it seems to be fdf560150f820a0b6ec944b36d638ae9a9579653

I'll try to get my hands on the game and take a look next week.

All right, thanks!
Also sorry for reporting this on a weekend, I just finally had the time to look into this and record the apitrace today.

Turns out this was my bug after all, but the fact that it worked with 1.3.x was pure luck, the issue was present in older DXVK versions too.


training strategy of generator

from def train_multi(self) in the solver.py in this repository, my understanding is that when training the translation ability, it only involves translation within one dataset(target labels with one) .What about training with target labels across the datasets?

Yes, you can possibly translate celeba images using the rafd labels. In this case, you don’t know about the original label, so that you can not optimize the reconstruction loss, but can optimize the domain classification loss. We did’nt try this strategy, but I think it will improve the visual quality of translation results.


[bug]: update installation instructions

Describe the bug
in the current docs, the installation instructions for vite, they point to paste this code into the vite.config.ts file
code:
`import path from "path"
import react from "@vitejs/plugin-react"
import { defineConfig } from "vite"
export default defineConfig({
plugins: [react()],
resolve: {
alias: {
"@": path.resolve(__dirname, "./src"),
},
},
})
`
however, this code does not include the tailwindcss as part of its plugins, which means the css styling never gets loaded. as such, we need to included it in postcss like this
code:
`import { defineConfig } from 'vite'
import react from '@vitejs/plugin-react'
import tailwindcss from 'tailwindcss'
export default defineConfig({
plugins: [react()],
css: {
postcss: {
plugins: [tailwindcss()],
},
}
})`
Affected component/components
NA
How to reproduce
just paste the current code provided on the docs into your vite.config.ts file and you'll see that none of your styles are being applied at all
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
macos

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Looks like the installation instruction for Remix is also outdated as the latest remix init has Tailwind css built-in already


Add plugin access control. Refactor matrix image upload functionality

This PR does two things:

Allow relay users to restrict access to plugins based on room or user
Refactors the Matrix image upload capability so that other plugins can use it

Closing for now