vue-perf-devtool   vue-devtools = "No Vuex store detected."

Version
4.1.3
Browser and OS info
Firefox 58.0.2 / Windows 10
Steps to reproduce
Install vue-devtools and vue-perf-devtool extensions.
Open a vue project that use Vuex and open vue-devtools panel on Vuex tab.
What is expected?
Detect the Vuex store and show it
What is actually happening?
Show "No Vuex store detected."

If you deactivate vue-perf-devtool everything goes back to normal.
There seem to be some kind of interference between the two devtool panel

We don't maintain that other tool (which you provided no information about). Have you opened an issue in their repository?
I suggest the author(s) of that other tool should look into this first.

Thank you for your answer.
I thought this was part of the same family of devtools for Vue.
My mistake, I will open another issue there.
Have a nice day !
Le 9 févr. 2018 22:53, "Thorsten Lünborg"<EMAIL_ADDRESS>a
écrit :

We don't maintain that other tool (which you provided no information
about). Have you opened an issue in their repository?
I suggest the author(s) of that other tool should look into this first.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-devtools/issues/612#issuecomment-364579894,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT81DlijICwENc_ChqPWgLIufRQKs-gks5tTL5LgaJpZM4R-h0B
.

@lionel-bijaoui vue-perf-devtool is a source of the bug. "Vuex detected" in vue-devtools when I disable it.

just wanted to add that i also get this problem too

Hi @lionel-bijaoui,
you can close this issue, I fixed on 0.0.6 version of vue-perf-devtool.
if the problem persists, you can continue in this thread.
https://github.com/vue-perf-devtool/vue-perf-devtool/issues/7
Regards!

@rafaesc thanks !


Upload repeats process for each image

5 failures = 5 alerts.
5 successes = catastrophe.
need to make sure it only sends the callback when finished checking through the images.

Solved when actual upload was fixed.


startForegroundService() not allowed due to mAllowStartForeground false

Your Environment

Plugin version: 4.9.1
Platform: Android
Device OS version: Android 12
Device manufacturer / model: SM-G991U
Capacitor info (npx cap doctor):
💊   Capacitor Doctor  💊

Latest Dependencies:
@capacitor/cli: 4.4.0
@capacitor/core: 4.4.0
@capacitor/android: 4.4.0
@capacitor/ios: 4.4.0
Installed Dependencies:
@capacitor/cli: 4.2.0
@capacitor/core: 4.2.0
@capacitor/android: 4.2.0
@capacitor/ios: 4.2.0
[success] iOS looking great! 👌
[success] Android looking great! 👌

Plugin config provided to #ready:

let config: Config = {

          desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_MEDIUM,
          distanceFilter: 100,
          stationaryRadius: 0,
          maxRecordsToPersist: 3,
          debug: false,
          autoSync: true,
          autoSyncThreshold: 13,
          batchSync: true,
          stopDetectionDelay: 1,
          stopTimeout: 5,
          disableElasticity: false,
          isMoving:true,

          stopOnTerminate: false,
          stopOnStationary: false,
          startOnBoot: true,

          url: `${this._providerService.getGpsHost()}/gps`,
          headers: {
            'Authorization': `Bearer ${this._providerService.getApiToken('GPS_API_TOKEN')}`,
            'Content-Type': 'application/json'
          },
          extras: {
            "userId": this.userId,
            "driverName": this.driverName,
            "companyId": this.companyId,
            "companyName": this.companyName
          },
          locationTemplate: '{"latitude":<%= latitude %>,"longitude":<%= longitude %>, "timestamp": "<%= timestamp %>", "speed": <%= speed %>, "is_moving": <%= is_moving %>}',
          locationAuthorizationRequest: 'Always',
          disableLocationAuthorizationAlert: this.platform.is('ios') ? true : false,
          locationAuthorizationAlert: {
            titleWhenNotEnabled: "Location-services is not enabled",
            titleWhenOff: "Location-services is OFF",
            instructions: "You must enable 'Always'",
            cancelButton: "Cancel",
            settingsButton: "Settings"
          },
          backgroundPermissionRationale: {
            title: "Allow HaulEx to access to this device's location in the background?",
            message: "To make sure the app works correctly on trip section, please enable 'Always' location permission",
            positiveAction: "Change to 'Always'",
            negativeAction: "Cancel"
          }

Expected Behavior
Gps plugin starts to work in background when app is hidden(not terminated) on Android OS.
Actual Behavior
Error is thrown when app starts to utilise the plugin in the background and no gps coordinates are collected.
Steps to Reproduce

User opens the app with all permissions allowed previously
switches to other windows leaving app in the background
Error occurs when user leaves the geofence

Context

Make sure the plugin works in the background
Debug logs

Logs
android.app.ForegroundServiceStartNotAllowedException: startForegroundService() not allowed due to mAllowStartForeground false: service app.dieseldispatch.DieselDispatch/com.transistorsoft.locationmanager.service.BackgroundTaskService
    at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:54)
    at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:50)
    at android.os.Parcel.readParcelable(Parcel.java:3346)
    at android.os.Parcel.createExceptionOrNull(Parcel.java:2433)
    at android.os.Parcel.createException(Parcel.java:2422)
    at android.os.Parcel.readException(Parcel.java:2405)
    at android.os.Parcel.readException(Parcel.java:2347)
    at android.app.IActivityManager$Stub$Proxy.startService(IActivityManager.java:6969)
    at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1927)
    at android.app.ContextImpl.startForegroundService(ContextImpl.java:1893)
    at android.content.ContextWrapper.startForegroundService(ContextWrapper.java:798)
    at com.transistorsoft.locationmanager.service.AbstractService$a.run
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:226)
    at android.os.Looper.loop(Looper.java:313)
    at android.app.ActivityThread.main(ActivityThread.java:8751)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

Are you sure that error came from v4.9.1?

Yes, it is a current version of the plugin we are using in production app

User launches the app
If he is logged in, he is brought to the home page, if not - at login page.
Once the authorisation is completed, he is asked to give location permissions and sets them to 'Always'. The gps plugin ready method is called with the configuration stated above.(Ready is called only once - when logging in, it is not called on every restart of the app)
User has finished using the app and leaves the app.
User moves out the geofence and the tracking is suppose to start, but instead the error above is thrown and gps plugin does not collect coordinates in the background.

Writing here to say I resolved this error by editing the AndroidManifest.xml to add the record:
android:foregroundServiceType="location"
Specifically to the activity with the tag android:name="com.example.app.MainActivity"
Other service types listed: https://developer.android.com/about/versions/10/features#fg-service-types

android:foregroundServiceType is an attribute of <service>, not <activity>.
The plugin already adds android:foregroundServiceType="location" to its required services (unless you're using an older version of the plugin (you didn't specify which version you're using).

Currently using version 4.9.5.
Interesting that you mention a <service> tag as I do not have one in my AndroidManifest.xml whatsoever. Referencing the Changelog is leading me to believe that I should have 2 <service> tags.

The Android Setup docs are correct: they do not direct you to add <service> elements to your manifest.

Should I expect to find android:foregroundServiceType="location" somewhere within the generated app then?

The plug-in has its own AndroidManifest with all its required elements defined.


feat: disable donations below $500 on 0x & 1inch

Description
When adding donations to 0x and 1inch trades, the increase in contract complexity adds a significant amount of addition gas required to execute a trade.
On the Ethereum chain this can make trades with donations significantly more expensive.
This PR disables donations on trades from the Ethereum chain using 0x and 1inch if the "buy amount" is less than $500 USD.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
Small.
Testing
When the receive amount is less than $500 USD on 0x and 1nch trades, the donation option should no longer show.
Ensure other selected currencies behave as expected.
Engineering
☝
Operations
☝
Screenshots (if applicable)
N/A

Current dependencies on/for this PR:

develop

PR #4536   👈

This comment was auto-generated by Graphite.


Fix AES SPI that leads to memory leaks

When grabbing an AES object to perform AES computation, today, we return a pointer.
This leads to a memory leak (object is never de-allocated).
Instead, we should return a std::unique_ptr

Using std::unique_ptr is no compatible with the support of DYNAMIC_ALLOCATION

Fixed by 187243d77738ce525cdad7343b1ff2d02a35c556


Support passing validation context via the model constructor

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
As part of pydantic V2, #1549 introduced the ability to access context external to model fields when validating data coming through model_validate and model_validate_json. This is achieved via passing in an extra named parameter context, which is available to validators at info.context.
Using these models through the model's constructor does not work:

major: it is not possible to set info.context via the model's __init__
minor: info.context has the value None when using the model's __init__, instead of being an empty dict. This makes defaulting hard to get right.

A demo of how code might look when using the feature
This code is substantially copied from #5593.
class MyModel(BaseModel):
    x: int

    @field_validator("x")
    def validate(cls, value, info):
        return value * info.context.get("multiplier", 1)

# works great
assert MyModel.model_validate({"x": 1}).x == 1
assert MyModel.model_validate({"x": 1}, context={"multiplier": 2}).x == 2

# this line should work, but currently fails validation
model = MyModel(x=1)
assert model.x == 1

# ideal future
model = MyModel(x=1, context={"multiplier": 2})
assert model.x == 2

I would not mind whatsoever if context got changed to _context, _validation_context, or whatever.
Your use case(s) for the feature
Use-cases include:

Having a dynamic set of allowed values
Having validation strictness be controlled by a runtime flag
See also the list in: https://github.com/pydantic/pydantic/issues/1549

My personal immediate use-case is controlling allowed values dynamically.
Why the feature should be added to pydantic (as opposed to another library or just implemented in your code)
Without a way to use context via the constructor, pydantic only partially supports validation context. I think that this is enough justification for bringing a solution into pydantic itself.
Alternatives

Just forget about context altogether, and pass the validation context as part of the model. This should be ruled out because it makes it very easy to create injection attacks whereby the end-user can control validation context by passing in a malicious payload.
Pass context via a ContextVar, as demonstrated here. This is workable, but requires calling into pydantic-internal code directly. If it is the preferred solution, it belongs as a base class / context manager in the library in order to round out validation context usability.
Override the constructor to take a positional argument, as also demonstrated here. This is workable, but thwarts static type-checking if done externally. If this becomes a part of pydantic, then (I assume) it can also be a part of the mypy plugin, giving proper type-checking.

(Thanks @dmontagu for both of the viable alternatives!)
Affected Components

[X] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I think if we were going to make it possible to pass the context to __init__, we'd need it to be a keyword argument starting with __ to prevent collisions with aliased field names.
Also, unfortunately, I think this would not play nice with type checkers that make use of @dataclass_transform.
I did make a proposal of a way to pass context into __init__ without adding any keyword arguments through the use of a ContextVar + contextmanager in https://github.com/pydantic/pydantic/issues/1549#issuecomment-1526632046. This has the upshot of requiring no changes today, but does require the user to override the BaseModle.__init__ function. Fortunately, the (current) behavior of overriding BaseModel.__init__ does exactly what you'd want here, since __init__ is only called if you instantiate the class from Python, but it could lead to issues if we rework how custom __init__ behaves.
@adriangb @samuelcolvin, I'd appreciate your thoughts on this.

I did make a proposal of a way to pass context into __init__ without adding any keyword arguments through the use of a ContextVar + contextmanager in #1549 (comment). This has the upshot of requiring no changes today, but does require the user to override the BaseModle.__init__ function.

Yep! Thanks for the suggestion. I referenced that in alternative #2. I think it's a totally valid way to go, and if taken then should be added to the library itself, in order to complete the validation context functionality in pydantic.

Oh sorry, I didn't read your issue closely enough, and see the alternatives listed there. (Thanks for providing all the detail)

I'll note that the approach using a ContextVar is now officially documented: https://github.com/pydantic/pydantic/blob/6bffa13615ac4b91fa30d6818416f62152944dbe/docs/usage/validators.md?plain=1#L600
I think the main problem I have with having an always-working out-of-the-box solution for this is that, the obvious ways I can see to get that working (such as modifying the BaseModel.__init__ to look for a specific library-provided ContextVar) involve adding overhead for the scenario where this functionality isn't used, and currently I think this will be relevant to only a small fraction of calls to model class __init__ calls.
I personally would be open to adding a library-provided ContextVar and paired @contextmanager, with a bit of documentation (I think it would be enough for it to be in the docstrings of those functions and with minor tweaks to the docs section linked above) of how to use both together with a custom __init__ to achieve this with a bit less user code.
However, given it's not clear to me how high of a priority this is though, I'll hold off on doing this myself until there is more of a widespread request for this. I would be happy to review a PR adding it though.

Sounds sensible to me, thanks for the write-up!

Hello,
Also interested in this feature. Need to pass-around data from parent model to child model and validate depending on context. Would be nice to initiate it via the init function?
Is there a way to set the context during validation or using a special function?

@HarishHary this is documented here: https://docs.pydantic.dev/latest/usage/validators/#using-validation-context-with-basemodel-initialization

Hi, I have same problem with nested model, where child needed to access parent value. I've tried to override Parent constructor and also model_validator(mode="wrap") but with no luck. Both called after Child validator run.
from pydantic import BaseModel, ValidatorInfo, field_validator, conint

allowed_choices = ("a", "b", "c", "d", "e")

class Child(BaseModel):
    choice: str  # need to validate choice

    @field_validator("choice")
    def validate_choice(v, info: ValidatorInfo):
        # _choices = allowed_choices[:Parent.options]  ### how to access Parent.options here?
        _choices = allowed_choices
        if v not in _choices:
            raise ValueError(f"choice must be one of {_choices}")
        return v

class Parent(BaseModel):
    options: conint(ge=1, le=5)

@dmontagu - Thank you for the __init__ workaround, very helpful.
I'm working with a case where I want to vary the validation model for a child attribute based on context, for example:
class Animal(BaseModel):
    name: str

class Dog(Animal):
    # dog-specific fields...

class Cat(Animal):
    # cat-specific fields...

class Person(BaseModel):
    name: str
    pet: Cat | Dog

person_args = {
    "name": "Dan",
    "pet": {
        "name": "Fido",
        # dog-specific fields...
    },
}

# ideally
person = Person(**person_args, context={"pet_type": "dog"})

# or
with init_context({"pet_type": "dog"}):
    person = Person(**person_args)

From examples I can figure out how to do custom validation within a type (within a str or list), but I'm struggling with how to actually set the desired model for validating the child attribute (pet in this case).
Is there a way to set the right member of the union at initialization using the context?


Center vertically Tags

Hey there,
Thank you for a great library. I have question while using you tag view.
How can I center the tag view vertically. You can see in the screen shot, the tags are always on top of tag list view (red background)

Looking forward to hearing from you.
Thank you again,
knn90

Did you ever find a solution?

Did you ever find a solution?

Sorry @az-oolloow, I don't really remember how to overcome this :D. I think it sticks to the top as expected of the author.

I have the same issue. Any ideas?


WIP: Surface upheaval

Bringing resqpy surface classes in line with BaseResqpy and uuid way of working.  This will be a breaking change, removing the extraneous extract_from_xml arguments and also unused parent node argument to create_xml() methods.

Codecov Report

Merging #103 (3dd9616) into master (dfbfc6e) will increase coverage by 0.01%.
The diff coverage is 58.93%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   38.75%   38.77%   +0.01%
==========================================
  Files          49       49
  Lines       21726    21696      -30
==========================================
- Hits         8420     8412       -8
+ Misses      13306    13284      -22

Impacted Files
Coverage Δ

resqpy/rq_import.py
25.85% <0.00%> (ø)

resqpy/surface.py
44.37% <56.59%> (-0.05%)
:arrow_down:

resqpy/grid_surface.py
62.02% <76.47%> (+0.08%)
:arrow_up:

resqpy/model.py
62.03% <100.00%> (+0.14%)
:arrow_up:

resqpy/olio/base.py
97.87% <0.00%> (+2.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbfc6e...3dd9616. Read the comment docs.


Upgrade Assistant from Host V1 does not handle WebHookType

Host V1 HttpTriggers had a WebHookType property that would define some behaviors. For example, [HttpTrigger(WebHookType = "github")]HttpRequestMessage req.
Upgrade Assistant currently does not touch these, and will leave them in the new HttpTrigger attribute, causing a build error. This should be addressed somehow. The behavior of the old property is described in our documentation. Likely, the right thing to do here is to convert this to a standard HttpTrigger and add some handling which captures the logic that these modes represented. MIddleware may be a good fit.

PR for issue: https://devdiv.visualstudio.com/DevDiv/_git/UpgradeAssistant/pullrequest/499386

PR has been merged in


Details about training

Dear authors, thanks for your sharing this wonderful work!
I have some questions about training details, which are not mentioned in your paper.

how many iterations do you train the two branch networks?
How do you add the coordinate map for the input view and target view? element-wise addition or channel-wise concatnation? It looks weird that Plucker ray embedding works poor in your Ablation Table.2

Many thanks for your reply! I am looking forward it @kaz-sony

Hi @fangchuan , Thank you for your interest.

how many iterations do you train the two branch networks?

For each training checkpoints, we used the settings below:

multi1

dataset: RealEstate10K, ACID, ScanNet
trained for 102000 steps with batch size 8

multi2

dataset: RealEstate10K, ACID, ScanNet, MegaScene v1.0
trained for 344000 steps with batch size 32

How do you add the coordinate map for the input view and target view? element-wise addition or channel-wise concatnation? It looks weird that Plucker ray embedding works poor in your Ablation Table.2

It is 'element-wise addition' as you can confirm it with the codes here.
One of the reason why the performance of the Plücker embedding was lower than that of our warped coordinates embedding in our experiment is because ours incorporates the estimated depth information by warping the coordinates while Plücker only carries the information of the relative camera pose. Another reason is that Plücker embedding is known to suffer from scale ambiguity when in the situations like single-shot NVS setting, which is our main target. This is well described in pixelSplat paper (see fig.2). The problem might not be such a big issue when the model is multi-view generation with any given trajectory unlike us, because in such cases the model can find a reasonable scaling by generating images of one object from multiple views (Imagine generating multi-view images of a cat from a camera with a circular motion revolving about the cat). This is the case for the existing methods like SPAD and CAT3D as you may have already seen.
Let us know if you have further questions.

Hi @fangchuan , Thank you for your interest.

how many iterations do you train the two branch networks?

For each training checkpoints, we used the settings below:

multi1

dataset: RealEstate10K, ACID, ScanNet
trained for 102000 steps with batch size 48

multi2

dataset: RealEstate10K, ACID, ScanNet, MegaScene v1.0
trained for 344000 steps with batch size 192

How do you add the coordinate map for the input view and target view? element-wise addition or channel-wise concatnation? It looks weird that Plucker ray embedding works poor in your Ablation Table.2

It is 'element-wise addition' as you can confirm it with the codes here.
One of the reason why the performance of the Plücker embedding was lower than that of our warped coordinates embedding in our experiment is because ours incorporates the estimated depth information by warping the coordinates while Plücker only carries the information of the relative camera pose. Another reason is that Plücker embedding is known to suffer from scale ambiguity when in the situations like single-shot NVS setting, which is our main target. This is well described in pixelSplat paper (see fig.2). The problem might not be such a big issue when the model is multi-view generation with any given trajectory unlike us, because in such cases the model can find a reasonable scaling by generating images of one object from multiple views (Imagine generating multi-view images of a cat from a camera with a circular motion revolving about the cat). This is the case for the existing methods like SPAD and CAT3D as you may have already seen.
Let us know if you have further questions.

Thank you very much, it makes sense. Again, thanks for your reply!


dns tests: enable eve v1 tests for Rust builds.

This PR enables tests that check the DNS JSON v1 log format for Rust. For some tests, the check was moved to YAML instead of the check.sh script.  I'll do another pass later getting rid of most all check.sh scripts.

Could you rebase this on PR #2? I get QA failures that are unrelated to the EVE DNSv1 work.

Looks like a few tests need updating still:

===> eve-alert-metadata-defaults: SKIPPED: eve dns v1 not supported by rust
===> eve-alert-metadata-enable-rule: SKIPPED: eve dns v1 not supported by rust
===> eve-alert-metadata-off: SKIPPED: eve dns v1 not supported by rust

Closing. See https://github.com/OISF/suricata-verify/pull/4


Loading shp witouth cpg

Hi,
Using Apache Cordova, I'm trying to load shp file without .cpg file.
The error is: Failed to load resource: net::ERR_FILE_NOT_FOUND [file:///storage/emulated/0/app/test.cpg]
If I zip the content, code is working well.
test.shp
test.dbf
test.shx
test.prj
function shp2geojson(file, callback) { file = file.replace(".shp", ""); shp(file).then(function(geojson){   callback(geojson); }); }
With best regards,

are you getting an error in the code or seeing an error in the console ? if it's the latter then that's not an issue, since the code doesn't know if there is a cpg on the server so it has to look and the 404 is the web sever telling us that no such file exists.

Dear Calvin,
Exactly, the error occurs in the console, saying that the file was not found.
Can it have a workaround, setting the encoding in utf-8 if the file was not found? Also, why is the code working well using a zip file that does not contain the cpg file?
With best regards,

Again it is not an error, we are looking to see if a cpg file exists and if
it doesn't we assume utf8.
The 'error' you are seeing is not an error the browser prints all 404 level
http responses like they are errors even if they are not related to code
misbehaving.
On Mon, May 4, 2020, 11:53 AM jpchenel<EMAIL_ADDRESS>wrote:

Dear Calvin,
Exactly, the error occurs in the console, saying that the file was not
found.
Can it have a workaround, setting the encoding in utf-8 if the file was
not found? Also, why is the code working well using a zip file that does
not contain the cpg file?
With best regards,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/calvinmetcalf/shapefile-js/issues/125#issuecomment-623547480,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAITRH4ANZEZLGOBTMN2CDLRP3QHDANCNFSM4MYZQWUQ
.

Dear Calvin,
Thank for your follow-up.
Maybe it is a misunderstood of my part, but I think that the function binaryAjax in the file in the /dist/shp.js is not the same version as the function in the /lib/binaryajax.js. The first one only has a handler for the load event.
I've only added the file shp.js to my solution (taken from the release 3.4.3) Does I need to include anything else?
With best regards,

./lib/binaryajax.js is not the version for use in the browser ./lib/binaryajax-browser.js is the file that ends up in the browser build.
Again if the only problem is that you are getting something in your console that's says there is a 404 then there is no error actually present and I don't think there is an actual issue.  Please correct me if I'm wrong and there is an error preventing your app from working correctly.

Calvin,
I've updated the file shp.js with this code to add a handler on the error event. Without it, the shp.combine function was never called.
function binaryAjax(url){
	return new Promise(function(resolve,reject){
		var type = url.slice(-3);
		var ajax = new XMLHttpRequest();

		ajax.open('GET',url,true);

		if(type !== 'prj' && type !== 'cpg'){
			ajax.responseType='arraybuffer';
		}

		ajax.addEventListener('load', function (){
			if(ajax.status>399){
				if(type==='prj' || type === 'cpg'){
					return resolve(false);
				}else{
					return reject(new Error(ajax.status));
				}
			}
			if(type !== 'prj' && type !== 'cpg'){
				return resolve(new Buffer(ajax.response));
			} else {
				return resolve(ajax.response);
			}
		}, false);

		ajax.addEventListener('error', function (){
			if(type==='prj' || type === 'cpg'){
				return resolve(false);
			} else {
				return reject(new Error(ajax.status));
			}
		}, false);

		ajax.send();
	});
}

Regards,

OK that makes more sense, I'll take a look tommorow
On Mon, May 4, 2020, 3:30 PM jpchenel<EMAIL_ADDRESS>wrote:

Calvin,
I've updated the file shp.js with this code to add a handler on the error
event. Without it, the shp.combine function was never called.
function binaryAjax(url){
return new Promise(function(resolve,reject){
var type = url.slice(-3);
var ajax = new XMLHttpRequest();
  ajax.open('GET',url,true);

  if(type !== 'prj' && type !== 'cpg'){
  	ajax.responseType='arraybuffer';
  }

  ajax.addEventListener('load', function (){
  	if(ajax.status>399){
  		if(type==='prj' || type === 'cpg'){
  			return resolve(false);
  		}else{
  			return reject(new Error(ajax.status));
  		}
  	}
  	if(type !== 'prj' && type !== 'cpg'){
  		return resolve(new Buffer(ajax.response));
  	} else {
  		return resolve(ajax.response);
  	}
  }, false);

  ajax.addEventListener('error', function (){
  	if(type==='prj' || type === 'cpg'){
  		return resolve(false);
  	} else {
  		return reject(new Error(ajax.status));
  	}
  }, false);

  ajax.send();

});
}
Regards,
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/calvinmetcalf/shapefile-js/issues/125#issuecomment-623659928,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAITRH3P5WR6ZPLSUKL7UKLRP4JW3ANCNFSM4MYZQWUQ
.

ok I'm somewhat confused, a 404 not found should not trigger an ajax error event, it should trigger a load event with a status set to 404, sigh is this like weird cordova thing where it's triggering an error instead of a success with 404 status?

I think this is something possible, maybe some code in cordova raising another kind of error or manage it differently.

ok try this version


Fix types for CJS projects using TypeScript NodeNext/Node16

Followup to #267 and #275
Tested both ESM and CJS projects (by modifying the example package) and this works.

Frustrating:
The Stackblitz appears to still not be working.
But in a real project, I can update to the latest next version and test both and they work.
I'm not sure why the Stackblitz isn't working... but it does seem to work in the "real world."
Hmm.

And just retested it from the example repo and it works there too. Hm.

@frehner tried to publish the stable version, a bit strange error: https://github.com/tajo/ladle/actions/runs/3229204374/jobs/5286226320#step:8:12

@tajo Ah, I think that happened because we generated the type files for publishing the normal version, and then tried to generate the type files again to publish the next version.
Hmmm, thoughts?

Ah yea, that makes sense

Do you want me to add additional logic to try and fix this? Do you have an idea of how you would like it done?

Do you want me to add additional logic to try and fix this?

Help is always appreciated!

Do you have an idea of how you would like it done?

I think it still makes sense to publish next version together with the stable version (you never want to end up with outdated version after installing @next).


Remove duplicate code

build calls .state/docker-build, removing duplicate code.

Thank you, @sayanarijit! If you're interested in working on a few related Warehouse issues: could I ask you to also review #5980, and/or possibly take over #4961 ?


build 0.6.5

Jira Ticket
Upstream project
dependency for rbcl

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
ERROR: clone/recipe/meta.yaml:15: uses_setup_py: python setup.py install is deprecated.
ERROR: clone/recipe/meta.yaml:55: http_url: http://github.com/defunkt/pystache is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:0: missing_section: The build section is missing.
ERROR: clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
ERROR: clone/recipe/meta.yaml:11: missing_build_number: The recipe is missing a build number
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found


kontena pp logs results in undefined method `[]' for nil:NilClass

having no app yet deployed:
$ kontena app logs
undefined method `[]' for nil:NilClass

$ kontena version
0.10.2

also if not everything from a kontena.yml is deployed yet, this error is shown

having some of these with other app subcommands as well


3.6.0 not on pypi yet

Does it just take some time to appear for pip updates or there was a problem with the push to them? Latest for pip install still shows at 3.5.1, thanks.

@longstone can I add you as a maintainer to the withings package on pypi.org?

Of course https://pypi.org/user/longstone/

@longstone I added you as a maintainer to the project.

https://pypi.org/project/withings-sync/3.6.1/


Scroll UI issue that has persisted for a while.

Hi,
Have a scroll UI issue when I use dynamically calculated heigh cells.
Initial RATreeView control setup
func setupTreeView() {
    treeView = RATreeView(frame: view.bounds)
    treeView.register(UINib(nibName: String(describing: EquipmentListCell.self), bundle: nil), forCellReuseIdentifier: String(describing: EquipmentListCell.self))
    treeView.register(UINib(nibName: String(describing: EquipmentChildCell.self), bundle: nil), forCellReuseIdentifier: String(describing: EquipmentChildCell.self))
    treeView.register(UINib(nibName: String(describing: EquipmentCollectionCellDetail.self), bundle: nil), forCellReuseIdentifier: String(describing: EquipmentCollectionCellDetail.self))
    treeView.register(UINib(nibName: String(describing: EquipmentLevelCell.self), bundle: nil), forCellReuseIdentifier: String(describing: EquipmentLevelCell.self))

    treeView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
    treeView.delegate = self
    treeView.dataSource = self
    treeView.treeFooterView = UIView()
    treeView.estimatedRowHeight = 50

    treeView.backgroundView = loadingView
    view.addSubview(treeView)
}

For example, if I use just this everything is fine
func treeView(_ treeView: RATreeView, heightForRowForItem item: Any) -> CGFloat {
     return 50
}

But, I make different heights for the treeView and under the particular conditions - just hide the cells by setup height = 0. Here, I get a scroll issue
func treeView(_ treeView: RATreeView, heightForRowForItem item: Any) -> CGFloat {
    return stats.total.toInt() == 0 ? 0 : 50
}

Please review this video
Is there some way to fix this?
Thanks!

did u solved this?


charAt, charCodeAt has default parameter value

'asdf'.charAt() // 'a'
'asdf'.charCodeAt() // 97

'asdf'.charAt() // TypeError
'asdf'.charCodeAt() // TypeError

This is intentional. It's much more likely that this is a mistake in the code than the desired behaviour.


Re-order and re-write the questions on the "money you spent" screen

The 2nd question “Balance in dedicated account as your reported on a prior report” should be the first question asked since the instructions say to “start by telling us how much money was in the account as of your last report to SSA”
INCLUDE A HELP WINDOW FOR EACH OF THESE QUESTIONS TO CLARIFY TO THE USER WHAT IS BEING ASKED + RE-WRITE THE QUESTIONS TO MAKE IT EASIER TO UNDERSTAND

There are instructions for each of the questions asked on this screen that show up under the completed form. We should be including the info in these instructions in a “?” or “Help” window while the user is on this screen

Closing issue since this appears to be part of the "dedicated account report" no longer required (replaced by SSA App now available)


pull request for e2e test at 11/13/2016 10:15:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cannot read property 'sizes' of undefined

Hi!
Using<EMAIL_ADDRESS>when I try to run my build command for @std/esm I ran into this error. The app is open and all that jazz.
/Users/jdalton/projects/esm/node_modules/webpack-dashboard/plugin/index.js:57
      inspectpack[action]({
                  ^
TypeError: Cannot read property 'sizes' of undefined
    at Promise.all.bundles.map.bundle (/Users/jdalton/projects/esm/node_modules/webpack-dashboard/plugin/index.js:57:19)
    at Array.map (<anonymous>)
    at INSPECTPACK_INDEPENDENT_ACTIONS.forEach.action

My build is pretty vanilla with no file watchers or webpack-dev-server use.

Hmmm, was this a watched build or a one off build? Where did the error surface?

This is a one off build (no file watchers). The error surfaces during the build (from the console I initiated the build in)

Nice snag, looks like the inspectpack daemon onlys get instantiated in watch mode. @tptee Any reason for that? Or can I just add it on invalidation?

I'm also getting an inspectpack error
inspectpack/lib/parser/extractors.js:15
  const beginningIndex = pathInfoComment.indexOf(beginningToken);
                                        ^

TypeError: Cannot read property 'indexOf' of undefined
    at extractPath (/Users/adamthomann/Documents/code/troops-web-ui/node_modules/inspectpack/lib/parser/extractors.js:15:41)

@jdalton this is running build:prod?
@athomann is this a public repo?

@jdalton this is running build:prod?

This is running npm run build (with the dashboard plugin added to the dev build, so non-prod build)

Hey, getting the same TypeError: Cannot read property 'sizes' of undefined error. Steps I took are below, using this repo.

npm installed webpackdashboard as described in the readme
added the plugin to the webpack config
ran npm start

Afterwards, the 'sizes' error.

@kenwheeler currently not public.  Will work on reproducing in public repo.

Same problem, Dashboard won't work at all for me.  Trying to debug...
 95% emitting/Users/terry.rosen/Development/bap/node_modules/webpack-dashboard/plugin/index.js:57
      inspectpack[action]({
                 ^

TypeError: Cannot read property 'sizes' of undefined
    at Promise.all.bundles.map.bundle (/Users/terry.rosen/Development/bap/node_modules/webpack-dashboard/plugin/index.js:57:18)
    at Array.map (native)
    at INSPECTPACK_INDEPENDENT_ACTIONS.forEach.action (/Users/terry.rosen/Development/bap/node_modules/webpack-dashboard/plugin/index.js:56:25)
    at Array.forEach (native)
    at getBundleMetrics (/Users/terry.rosen/Development/bap/node_modules/webpack-dashboard/plugin/index.js:55:35)
    at Compiler.compiler.plugin.stats (/Users/terry.rosen/Development/bap/node_modules/webpack-dashboard/plugin/index.js:220:7)
    at Compiler.applyPlugins (/Users/terry.rosen/Development/bap/node_modules/tapable/lib/Tapable.js:61:14)
    at emitRecords.err (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:268:11)
    at Compiler.emitRecords (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:375:38)
    at emitAssets.err (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:262:10)
    at applyPluginsAsyncSeries1.err (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:368:12)
    at next (/Users/terry.rosen/Development/bap/node_modules/tapable/lib/Tapable.js:200:11)
    at Compiler.compiler.plugin (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
    at Compiler.applyPluginsAsyncSeries1 (/Users/terry.rosen/Development/bap/node_modules/tapable/lib/Tapable.js:204:13)
    at Compiler.afterEmit (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:365:9)
    at require.forEach.err (/Users/terry.rosen/Development/bap/node_modules/webpack/lib/Compiler.js:360:15)
    at /Users/terry.rosen/Development/bap/node_modules/async/dist/async.js:421:16
    at iteratorCallback (/Users/terry.rosen/Development/bap/node_modules/async/dist/async.js:998:13)
    at /Users/terry.rosen/Development/bap/node_modules/async/dist/async.js:906:16
    at /Users/terry.rosen/Development/bap/node_modules/graceful-fs/graceful-fs.js:43:10
    at FSReqWrap.oncomplete (fs.js:123:15)

Same here, but the electron-webpack-dashboard is working fine for me (I'm using the next.js next.config.js webpack config file) like this:
const DashboardPlugin = require('webpack-dashboard/plugin')

module.exports = {
  webpack: (config, { dev }) => {
    if (dev) {
      config.plugins.push(new DashboardPlugin())
    }

    return config
  }
}

Just that I'm getting the following inspectpack errors in my terminal.
TypeError: Cannot read property 'indexOf' of undefined
    at extractPath (/Users/hbendev/code/bntz/node_modules/inspectpack/lib/parser/extractors.js:15:41)
    at Function.nu (/Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:67:92)
    at /Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:41:252
    at h (/Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:7:90)
    at kr (/Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:41:220)
    at zn.On.toJSON.On.valueOf.On.value (/Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:136:81)
    at Object.getFileName (/Users/hbendev/code/bntz/node_modules/lodash/lodash.min.js:49:85)
    at webpackSections.forEach.element (/Users/hbendev/code/bntz/node_modules/inspectpack/lib/parser/index.js:38:33)
    at Array.forEach (native)
    at extractFromArrayExpression (/Users/hbendev/code/bntz/node_modules/inspectpack/lib/parser/index.js:20:19)
/Users/hbendev/code/bntz/node_modules/inspectpack/lib/models/bundle.js:43
    throw new Error("No code sections found");

Error: No code sections found
    at Bundle.validate (/Users/hbendev/code/bntz/node_modules/inspectpack/lib/models/bundle.js:43:11)
    at Immediate.setImmediate (/Users/hbendev/code/bntz/node_modules/inspectpack/lib/models/bundle.js:268:14)
    at runCallback (timers.js:666:20)
    at tryOnImmediate (timers.js:639:5)
    at processImmediate [as _immediateCallback] (timers.js:611:5)
/Users/hbendev/code/bntz/node_modules/inspectpack/lib/models/bundle.js:43
    throw new Error("No code sections found");

What could it be? 🤔

Getting both issues, first with a one-off build using gulp:
inspectpack[action]({
                 ^

TypeError: Cannot read property 'sizes' of undefined
    at Promise.all.bundles.map.bundle (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack-dashboard/plugin/index.js:57:18)
    at Array.map (native)
    at INSPECTPACK_INDEPENDENT_ACTIONS.forEach.action (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack-dashboard/plugin/index.js:56:25)
    at Array.forEach (native)
    at getBundleMetrics (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack-dashboard/plugin/index.js:55:35)
    at Compiler.compiler.plugin.stats (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack-dashboard/plugin/index.js:220:7)
    at Compiler.applyPlugins (/Users/stefan/Documents/Development/roam-usa/node_modules/tapable/lib/Tapable.js:61:14)
    at emitRecords.err (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:268:11)
    at Compiler.emitRecords (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:375:38)
    at emitAssets.err (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:262:10)
    at applyPluginsAsyncSeries1.err (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:368:12)
    at next (/Users/stefan/Documents/Development/roam-usa/node_modules/tapable/lib/Tapable.js:218:11)
    at Compiler.compiler.plugin (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
    at Compiler.applyPluginsAsyncSeries1 (/Users/stefan/Documents/Development/roam-usa/node_modules/tapable/lib/Tapable.js:222:13)
    at Compiler.afterEmit (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:365:9)
    at require.forEach.err (/Users/stefan/Documents/Development/roam-usa/node_modules/webpack/lib/Compiler.js:354:15)

And then instead ran webpack directly with the --watch flag, everything in the dashboard seems to be there and working but I am hitting this error in the terminal:
/Users/stefan/Documents/Development/roam-usa/node_modules/inspectpack/lib/parser/extractors.js:15
  const beginningIndex = pathInfoComment.indexOf(beginningToken);
                                        ^

TypeError: Cannot read property 'indexOf' of undefined
    at extractPath (/Users/stefan/Documents/Development/roam-usa/node_modules/inspectpack/lib/parser/extractors.js:15:41)
    at Function.nu (/Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:67:92)
    at /Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:41:252
    at h (/Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:7:90)
    at kr (/Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:41:220)
    at zn.On.toJSON.On.valueOf.On.value (/Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:136:81)
    at Object.getFileName (/Users/stefan/Documents/Development/roam-usa/node_modules/lodash/lodash.min.js:49:85)
    at node.properties.forEach.property (/Users/stefan/Documents/Development/roam-usa/node_modules/inspectpack/lib/parser/index.js:63:33)
    at Array.forEach (native)
    at extractFromObjectExpression (/Users/stefan/Documents/Development/roam-usa/node_modules/inspectpack/lib/parser/index.js:62:19)

Just pushed out a new release. @jdalton still getting an unexpected Token name (TokenType) on std/esm, but the dashboard runs. Thinking it has something to with the uglify minification for estimated min sizes. I'll ticket that out separately.
Everyone else, install the latest version of the plugin and the app and you should be all set.

Thinking it has something to with the uglify minification for estimated min sizes. I'll ticket that out separately.

@kenwheeler -- I'm guessing that would be best as an inspectpack ticket. We can switch to babilii or is there a newer es-friendly uglify?

@ryan-roemer theres this https://github.com/mishoo/UglifyJS2

Yeah, from that it looks like https://www.npmjs.com/package/uglify-es might work.

For the webpack-uglify plugin there's v1.0.0-beta.2 which is Uglify v3.


feat: sentry node v7

Updates @sentry/node to version 7.0.0-beta.2

Hi @edwardgou-sentry, Lukas from the JS SDK team here 👋
Thanks for trying out v7 - any Feedback you might have while or after upgrading would be greatly appreciated. Also let me know if you have question, want a review, etc.
Happy to help!

@Lms24 , it would be cool to update this to the second beta before merging.

Hey @edwardgou-sentry , we released a new beta yesterday. It would be cool if you could update the branch to that one instead.

Thanks @Lms24 @vladanpaunovic , I've managed to bump to 7.0.0-beta.2 and ran some testing locally with help from @shruthilayaj . Everything seems to be working fine, I was able to verify events being published to my own dsn.
I'm going to mark this PR ready for review. Please let me know if you think there is anything else that needs to be included as part of this upgrade. Thanks!

Heads-up @edwardgou-sentry @shruthilayaj, we're gonna release 7.0.0-rc.0 in a few hours. Would you guys be able to bump to that version in this PR (or a follow-up one, as you desire)? In terms of changes between beta.2 and rc.0 there shouldn't be anything that's breaking things on your end. You'd just enjoy some bugfixes.


Set db artifacts_dir host dynamically in vagrant.yml

Fix for issue #144

vagrant.yml is intended to be developer-specific. For example I think it best not to assume specific host ports since they may be unavailable on the developer's machine.
For more info, see my StackOverflow answer here:
http://stackoverflow.com/questions/13065576/override-vagrant-configuration-settings-locally-per-dev/23589414#23589414
I do like the dynamic db.artifacts_dir.host though. Can we leave vagrant.yml.sample in place, continue .gitignoring vagrant.yml, remove db.artifacts_dir.host from vagrant.yml.sample, and keep the dynamic bit in Vagrantfile?

Hello,
I have left vagrant.yml.sample in place, added vagrant.yml back to .gitignore, removed the db.artifacts_dir.host from vagrant.yml.sample (set it to an empty string) and added the dynamic bit in Vagrant file, please do let me know if there's anything else I need to modify.
Regarding the original intention and my expectations as a user: when I clone a Vagrant Dev Project I'm expecting to do only two things: "git clone <repo_url>" and run "vagrant up" in the newly created directory so I can start playing with the application as soon as possible and not worry about any configuration details (ports, hosts etc.).

Hey Andrei. It may be that the approach you describe is the appropriate approach for where we are right now. Maybe we want to prioritize removing friction over development flexibility at this point. After all if the development flexibility becomes a problem then we can always reinstate the per-developer configuration.
My suggestion though would be just to inline the config into the Vagrant file (i.e. get rid of vagrant.yml and vagrant.yml.sample), just so people aren't tempted to modify vagrant.yml, thinking it's a local config. If you want to submit another PR for that I'll merge it.


Cut first milestone release

It would be interesting to start publishing what we have for the 0.11.0 release.

Let me know when to cut it and I can take care of it.

After https://github.com/scala/pickling/issues/432 is merged, could you cut 0.11.0-M1 @heathermiller? :smile:

Sure

Actually, after this https://github.com/scala/pickling/pull/434 that correctly sets the version.

@heathermiller you can cut the release now, master's been updated! :dancer:

Ok, 0.11.0-M2 it is. Gimme an hour or two and I'll take care of it

Wow, @jvican has a strong emoji game! :-)

@jvican can you start preparing release notes for 0.11.x?

There's still some ongoing work that needs to go into 0.11.x, so I'd rather write the release notes when everything is ready for the final release, and not the milestone. However, @jsuereth has some release notes here: https://github.com/scala/pickling/blob/0.11.x/notes/0.11.0.markdown.

 People add to the minutes as they make changes to a release. It's a lot easier to iteratively add new lines than to try and remember at the last minute before cutting the release all the stuff that was added/changed.
So I would really encourage you to add to Josh's notes if you can. It'd help you/us down the line on the final release notes, and others who might be watching the project.

Right, I'll get down to it soon then!

Release cut. It normally takes a couple of hours to propagate, but when it's available you should be able to see it here:
http://search.maven.org/#search|gav|1|g%3A"org.scala-lang.modules" AND a%3A"scala-pickling_2.11"

Now live!: http://search.maven.org/#artifactdetails|org.scala-lang.modules|scala-pickling_2.11|0.11.0-M2|jar


Kate/text background

closes #512
Prerequisites:

[x] Unless it is a hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary
I created this pull request mainly to remind myself of how the git process works and get familiar with the codebase. If this is not the way you would like to fix this issue totally fine to just reject this.
Adding background class to map title.
Tweaking desktop @media rule so that the map title has a background, rounded on mobile, flat no edges on desktop.
DESKTOP
Before

After

MOBILE
Before

After

Hey Sam,

Rounded borders on mobile but not desktop: I saw that the rounded border on mobile used to be there in previous versions, but thought that it looked better without the border and rounded corners on desktop (it seemed to me more subtle and less in the way when zooming in and viewing the map). Totally happy to change that if you think it's better for mobile and desktop to be the same.

Text sizing: I took the mention of text sizing in the issue as one of the reasons that the title was not easily readable, and not an issue itself. Totally happy to change that as well though if the text sizing itself is an issue.

I can just comment on the code but I don't know the desired behavior, adding @adamperer for his input

Thanks @kateharwood for jumping in and making a contribution!  Right now, some of these design decisions are admittedly being made ad-hoc -- hopefully Chris can help us coming up with a better process to support the growing team -- so it doesn't rely solely on my (arbitrary) judgment 😄
I definitely think your contribution is an improvement over the current status of the text being challenging to read.    It may make sense to use rounded corners in both designs, as the straight edges seem a bit rough and choppy in Firefox:

Keeping the text small may make sense in this case, to avoid cutting off too much of the map.  @capnrefsmmat , do you think this latest design fixes your issue #512 ?
Again, thanks @kateharwood for taking this initiative!

Hmm, yes, I think this is definitely an improvement.
Regarding rounded corners, I think it could go either way:

If the white box spanned full width, so you didn't see bits of map peeking around the corners, then square corners are fine, because there are no corners.
But if the box is going to span only most of the width, I'd have it be rounded corners. In fact, maybe it can merge into the box above, instead of being a separate rounded thing. (Maybe; merging would also make it feel less like a map title and more like a description for those drop-downs)

Regarding font size, I have no strong opinions. I suspect the right person to ask about 12px font is someone who needs reading glasses. The combination of poor contrast with background and small size definitely made it hard to read, but now that the background is white, it may be better.

Good points! For now I updated desktop to have rounded corners as well. I also tweaked the margin on mobile of the search box so it doesn't butt up against the map.
Seems like merging the title into the box above on desktop also could make sense.
Updated after pics:


v2.11.0 parses not valid ISO-8601 strings

After updating to v 2.11.0 invalid ISO strings are parsed and isValid() returns true. Bad formatted part and next ones are set to 0.
// moment 2.10.6
var m = moment.utc("2013-11-21T15:5:18", moment.ISO_8601);
console.log(m.isValid()) //false
console.log(m.format("D-MMM-YYYY H:mm:ss z")); //'Invalid date'

//moment 2.11.0
var m = moment.utc("2013-11-21T15:5:18", moment.ISO_8601);
console.log(m.isValid()) //true
console.log(m.format("D-MMM-YYYY H:mm:ss z")); //'21-Nov-2013 15:00:00 UTC'

First of all, if you use strict parsing (pass true as a third argument) it is indeed marked as not valid.
Then, you can see its only parsed up to the hour component, and in fact ISO does define a date + 2 digit hour as valid ISO, so there is just some unused input, which is normal in non-strict parsing.
So ':5:18' is correctly reported as unused input:
> moment.utc("2013-11-21T15:5:18", moment.ISO_8601).parsingFlags()
{ empty: false,
  unusedTokens: [],
  unusedInput: [ ':5:18' ],
  overflow: -1,
  charsLeftOver: 5,
  nullInput: false,
  invalidMonth: null,
  invalidFormat: false,
  userInvalidated: false,
  iso: true }

I would say this is a bugfix and not a regression. @icambron @mj1856 what do you think

Yeah, I think the behavior is correct. It made its best effort given the input. As long as strict parsing rejects it, I think it's behaving correctly.

Thanks @icambron !

Agreed.  Perhaps non intuitive, but it seems that strict-parsing is almost always required when testing for validity.

Ideally, we'd just get rid of non-strict parsing.


Datagrid columns visibility are persisted even without clicking OK/Apply button

Select one ...  (check one with "x")
[x] bug
[X] feature request
[ ] enhancement

Expected behavior
What is the role of clr-dg-column-toggle-button clrType="ok" for datagrid column toggle feature?
As a user, I would expect that the column toggling state will be applied/persisted only if I click on that button. If a user make changes to column visibility but doesn't click ok then it should reset back to the old state until you click on OK button. However, we could show changes made on checkbox click as a preview mode but should not persist.
Actual behavior
The current behavior doesn't require to click on clr-dg-column-toggle-button clrType="ok" button.
I feel like this directive/component itself is redundant.
Reproduction of behavior

Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

you could check the behavior from official doc itself
Environment details

Angular version: 5.x.x/4.x.x

**Clarity version:**0.11.x

Browser: all

Per review, we feel the best course of action here is to remove the OK button. It is not consistent with design choices in other components. The suggestion is to simplify the hide/show column experience so it looks more like this...

Will need another issue to clean up the OK button logic for projected buttons.

What about saving columns state ?
Currently I do use click event to persist hidden columns in database.
<clr-dg-column-toggle-button clrType="ok" (click)="saveColumns()">
    Save
</clr-dg-column-toggle-button>

If it removed, event should be exposed on column check/uncheck.


Ability for performRequest() to overwrite CURL options

My problem is that 10s timeout might be too short and there is no way to overwrite the default CURLOPT_TIMEOUT of 10s.
That is because the array is concatenated and hence the array on the left will take precedence over the argument passed in into performRequest()
By changing it to array_merge, I am able to overwrite it because now, the argument passed into performRequest() takes precedence.
Also fixes the PHPDoc of request() because the $data can be a string or array.

Hi, thanks for your PR! I know this is an old one now, I'm just going through and cleaning things up.
I agree with being able to overwrite. If you still want this merged, please feel free to make the PR into develop and ensure it passes all tests. Closing for now, cheers.


YARN-8056. Fix possible NPE when start Application Master

Fix possible NPE when yarn.resourcemanager.webapp.address or yarn.resourcemanager.webapp.https.address is not set in yarn-site.xml (incomplete configuration of HA).

Create issue - https://issues.apache.org/jira/browse/YARN-8056.

J

H

Hha

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1220
trunk passed

+1
compile
28
trunk passed

+1
checkstyle
18
trunk passed

+1
mvnsite
32
trunk passed

+1
shadedclient
789
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
46
trunk passed

_ Patch Compile Tests _

+1
mvninstall
26
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

+1
checkstyle
12
the patch passed

+1
mvnsite
27
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
880
patch has no errors when building and testing our client artifacts.

+1
javadoc
19
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
55
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3433

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f7dd76f5eddb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f1b76c

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1067
trunk passed

+1
compile
24
trunk passed

+1
checkstyle
15
trunk passed

+1
mvnsite
25
trunk passed

+1
shadedclient
633
branch has no errors when building and testing our client artifacts.

+1
javadoc
19
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
35
trunk passed

_ Patch Compile Tests _

+1
mvninstall
22
the patch passed

+1
compile
19
the patch passed

+1
javac
19
the patch passed

+1
checkstyle
11
the patch passed

+1
mvnsite
22
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
681
patch has no errors when building and testing our client artifacts.

+1
javadoc
16
the patch passed

+1
findbugs
40
the patch passed

_ Other Tests _

+1
unit
52
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

2830

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 80b088d0009a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c01e137

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
64
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1044
trunk passed

+1
compile
30
trunk passed

+1
checkstyle
17
trunk passed

+1
mvnsite
29
trunk passed

+1
shadedclient
711
branch has no errors when building and testing our client artifacts.

+1
javadoc
18
trunk passed

0
spotbugs
40
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
39
trunk passed

_ Patch Compile Tests _

+1
mvninstall
22
the patch passed

+1
compile
21
the patch passed

+1
javac
21
the patch passed

+1
checkstyle
11
the patch passed

+1
mvnsite
22
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
704
patch has no errors when building and testing our client artifacts.

+1
javadoc
16
the patch passed

+1
findbugs
43
the patch passed

_ Other Tests _

+1
unit
50
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
24
The patch does not generate ASF License warnings.

2944

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f95f6b6ab0fc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1088
trunk passed

+1
compile
33
trunk passed

+1
checkstyle
18
trunk passed

+1
mvnsite
27
trunk passed

+1
shadedclient
711
branch has no errors when building and testing our client artifacts.

+1
javadoc
16
trunk passed

0
spotbugs
35
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
33
trunk passed

_ Patch Compile Tests _

+1
mvninstall
18
the patch passed

+1
compile
15
the patch passed

+1
javac
15
the patch passed

+1
checkstyle
11
the patch passed

+1
mvnsite
18
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
699
patch has no errors when building and testing our client artifacts.

+1
javadoc
15
the patch passed

+1
findbugs
39
the patch passed

_ Other Tests _

+1
unit
49
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

2969

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4544f37b3578 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1052
trunk passed

+1
compile
19
trunk passed

+1
checkstyle
13
trunk passed

+1
mvnsite
20
trunk passed

+1
shadedclient
639
branch has no errors when building and testing our client artifacts.

+1
javadoc
16
trunk passed

0
spotbugs
32
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
31
trunk passed

_ Patch Compile Tests _

+1
mvninstall
18
the patch passed

+1
compile
14
the patch passed

+1
javac
14
the patch passed

+1
checkstyle
10
the patch passed

+1
mvnsite
16
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
692
patch has no errors when building and testing our client artifacts.

+1
javadoc
15
the patch passed

+1
findbugs
36
the patch passed

_ Other Tests _

+1
unit
45
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
22
The patch does not generate ASF License warnings.

2785

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4cf554282091 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1056
trunk passed

+1
compile
18
trunk passed

+1
checkstyle
13
trunk passed

+1
mvnsite
19
trunk passed

+1
shadedclient
653
branch has no errors when building and testing our client artifacts.

+1
javadoc
16
trunk passed

0
spotbugs
31
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
29
trunk passed

_ Patch Compile Tests _

+1
mvninstall
19
the patch passed

+1
compile
14
the patch passed

+1
javac
14
the patch passed

+1
checkstyle
11
the patch passed

+1
mvnsite
16
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
689
patch has no errors when building and testing our client artifacts.

+1
javadoc
16
the patch passed

+1
findbugs
38
the patch passed

_ Other Tests _

+1
unit
47
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
25
The patch does not generate ASF License warnings.

2809

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2aeb23be1a97 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1304
trunk passed

+1
compile
22
trunk passed

+1
checkstyle
18
trunk passed

+1
mvnsite
23
trunk passed

+1
shadedclient
786
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
34
trunk passed

_ Patch Compile Tests _

+1
mvninstall
23
the patch passed

+1
compile
16
the patch passed

+1
javac
16
the patch passed

+1
checkstyle
12
the patch passed

+1
mvnsite
18
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
855
patch has no errors when building and testing our client artifacts.

+1
javadoc
19
the patch passed

+1
findbugs
42
the patch passed

_ Other Tests _

+1
unit
54
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

3458

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3aa0a6ddc7e8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 61b2df2

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
179
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1300
trunk passed

+1
compile
26
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
854
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
41
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
39
trunk passed

_ Patch Compile Tests _

+1
mvninstall
24
the patch passed

+1
compile
20
the patch passed

+1
javac
20
the patch passed

+1
checkstyle
14
the patch passed

+1
mvnsite
21
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
919
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
59
hadoop-yarn-server-web-proxy in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

3742

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 878d972a426d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
11
https://github.com/apache/hadoop/pull/356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-356/9/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m  1s
trunk passed

+1 :green_heart:
compile
0m 29s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 23s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 20s
trunk passed

+1 :green_heart:
mvnsite
0m 25s
trunk passed

+1 :green_heart:
shadedclient
14m 44s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 25s
hadoop-yarn-server-web-proxy in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 20s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 48s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 46s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
checkstyle
0m 12s
the patch passed

+1 :green_heart:
mvnsite
0m 20s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 10s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 21s
hadoop-yarn-server-web-proxy in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 23s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 54s
hadoop-yarn-server-web-proxy in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

60m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 26835a5fff23 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 5d8600e80ad

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

-1
I think MR AppMaster should fail to start if the HA configuration is incomplete.
AmFilterInitializer#initFilter should check if the URL is null but it should throw some RuntimeException if the URL is null. In addition, MRClientService#serviceStart should not catch exceptions when starting webapp.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 49s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
23m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 15s

the patch passed

+1 :green_heart:
shadedclient
24m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  9s

hadoop-yarn-server-web-proxy in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

94m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/356

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1c202eb2b3b3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0a6fef79a835704000498703d1e14cc9f7a4acf5

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/

Max. process+thread count
521 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Closing this due to no activity.


Fix dropdown menu bug

The bug was caused by the css classes .media & .media-body, as they define overflow: hidden.
This PR adds an 'override' file in app/assets/stylesheets/overrides.scss that is imported last in the pipeline, allowing css rules contained in there to override any previous rules.
(I don't know whether this is the best approach, overriding overflow: hidden might break some
other stuff)
Fixes #373

Aren't those core Bootstrap classes?


Fix the access order for open-existential l-values

Don't eagerly begin the access to the existential l-value in an open-existential l-value during formal evaluation.  There's no reason this can't wait until the access begins.
rdar://32039566

@swift-ci Please test and merge.

@swift-ci Please smoke test.

@swift-ci Please smoke test Linux.


[BUG] "Documents" Folder Is Considered Virtual.

Description :-
After First Time Opening The App, And Selecting To Hide A Folder, App Creates A Blank Folder Called "Documents", If It Doesn't Exists. Even If It Does Exists In The System, This Folder Is Considered Virtual And Blocked By App To Hide It, As "Unsupported Directory". All Other Folders Works Perfectly With App.
Steps To Reproduce The Behavior : -

Make Sure "Documents" Folder Exists In Internal Storage.
Open App And Select This Folder To Hide.
See Error.

Expected Behavior :-
"Documents" Folder Should Be Allowed To Hide By App.
Basic Information :-

Phone :- Redmi 7A
OS :- Android 10, MIUI 12.5
Amarok Version :- 0.8.5b3 (F-Droid Release)

Can Confirm This Issue Still Exists In v0.8.7a2.


[WIP] Add background fill behavior

[x] Add panel for background fill behavior
[ ] Adjust display in the editor accordingly
[ ] Adjust display on the front end accordingly

Fixes #250.

@barklund even with half of it missing? 😄

@dvoytenko @barklund Curious to hear your ideas about actual frontend implementation. I haven't looked much into it, but wanted to avoid going the wrong direction.

@dvoytenko @barklund Curious to hear your ideas about actual frontend implementation. I haven't looked much into it, but wanted to avoid going the wrong direction.

The designer frontend doesn't change for either "fill" value, doesn't it?

I was referring more to the viewer frontend.

I was referring more to the viewer frontend.

So, I think, we actually do the isFullbleed==true already for the output. So, we need to implement isFullbleed==false now. The difference is visible here. Unless I'm very mistaken, all we need to do is to use the same <div className="page-safe-area" style={aspectRatioStyles}> code for non-fullbleed background and that's it. I recommend we change the backgroundElements and nonBackgroundElements vars above to be instead backgroundFullbleedElements and nonBackgroundFullbleedElements and then the rest of the code will be the same :)

I went with isFullbleedBackground for now since we have this one previous migration script that renames isFullbleed to isFill

@dvoytenko What do you think about the new naming?


[Question] How to submit multiple custome fields?

It's not clear in the documentation how we can have multiple fields submitted with an issue:
For example:
 options = {:subject => params[:subject], :comment => { :value => params[:body] },  :requester => { :email => @email, :name => @email },  :custom_fields => {:id => "XXXXXXID", :value => params[:ticket_type]}, :priority => "normal", :status => "pending" }

ZendeskAPI::Ticket.create(client, options)

How can we add multiple custom_fields in this case?

I wish this gem had better docs:
Nevermind, here is a solution from the original API:
custom_fields:	An array of the custom fields of the ticket. See below for details
 "custom_fields": [{"id": 25356371, "value": "I bought it at Buy More."}, ...]
Source:


Process the PE Exception Table (.pdata) to source additional function starts

Use the .pdata list of functions to identify more functions on an initial PE load.
https://msdn.microsoft.com/en-us/library/ft9x1kdx(v=vs.80).aspx
https://msdn.microsoft.com/en-us/library/windows/apps/ms253988(v=vs.80).aspx

Updated URLs:
https://docs.microsoft.com/en-us/cpp/build/exception-handling-x64?redirectedfrom=MSDN&view=vs-2019
https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-runtime_function

Added in  2.1.2365-dev.


Replace SINCE filter by SEEN and UNSEEN approach

This addresses issue #46
The approach, as suggested in the issue, is to get rid fo the SINCE filter and use a SEEN/UNSEEN strategy for IMAP and READ/UNREAD for GmailAPI.
So, we fetch all the emails that are UNSEEN or UNREAD, and then we mark them as SEEN or remove the UNREAD label.
To make this possible, we had to get the extra SCOPE modify in Gmail API integration.

How would this solution work if we have multiple instances of the plugin connected to the same inbox ?
For example, I can imagine having the production instance and the development instance using the same inbox. in this case would all emails be processed by both instances of the plugin or not ?

As you have already foreseen, one email box should be only processed by one instance, because when the email is read, it's is marked as SEEN and other instances will skip it.
I don't see this as a big issue because the development scenario I imagine, each environment would have a different email box integration to not interfere, but if multiple Circuit Maintenance instances interacting with the same box is a requirement, then this is not a valid solution.

closing this because with this approach, only one concurrent integration is possible


feat: add support and testing for ForwardDiff

Added support for Forward Autodiff capabilities in the atmospheric models. I *think this should be the last PR in this effort.

Awesome! Thanks @jmurphy6895 for this amazing work!

Hi @jmurphy6895 !
I did not forget the PRs. I just had personal problems and I still did not have time to test them. I will try to do this by the weekend. Sorry about the delay.

Hey @ronisbr, no worries! This isn't a blocker for the next step or two for me so no rush. Just whenever you get a chance!

Thanks @jmurphy6895 !


Idea: Provide constants for HTTP status codes

Hi,
It would be nice if we could provide some kind of constants including HTTP status codes like Rails does ( http://guides.rubyonrails.org/layouts_and_rendering.html#the-status-option ).

rack already has smth similar, see 1, 2
you can define a helper and use it easily
helpers do
  def with_status(code, &block)
    status Rack::Utils.status_code(code)
    yield if block_given?
  end
end

get '/goodies' do
  with_status :payment_required do
    { error: 'give me some money' }
  end
end

@dm1try thanks for information :), what do you think to support this behaviour:
status :method_not_allowed
If method status detect that given argument is Symbol then it will try resolve correct HTTP code based on some rails-like symbol to http status code mapping table.

rails uses the same rack helper that I mentioned above.
If you are talking about "built-in sugar" for #status then I don't have any strong opinion because I don't use named statuses :)

I would be down with enabling this in Grape via Rack::Utils.status_code(status).

Is somebody already working on this one? I would like to give it a shot.

@dabrorius Give it a shot!

@dblock Looks this issue can be closed.

Yep.


sdp: differentiate between media line disabled or rejected

Most of the time disabling a media line in the SDP answer by setting Port = 0 is fine and acceptable. In baresip/issue#1511, @alfredh mentiont the point, that

you can use port 0 or a=inactive, in practice it is almost the same thing

The RFC3264-Section5.1 writes the following:

A port number of zero in the offer indicates that the
stream is offered but MUST NOT be used. This has no useful semantics
in an initial offer, but is allowed for reasons of completeness,
since the answer can contain a zero port indicating a rejected stream
(Section 6).

Also RFC3264-Section6.1:

If a stream is offered as sendonly, the corresponding stream MUST be
marked as recvonly or inactive in the answer. If a media stream is
listed as recvonly in the offer, the answer MUST be marked as
sendonly or inactive in the answer. If an offered media stream is
listed as sendrecv (or if there is no direction attribute at the
media or session level, in which case the stream is sendrecv by
default), the corresponding stream in the answer MAY be marked as
sendonly, recvonly, sendrecv, or inactive. If an offered media
stream is listed as inactive, it MUST be marked as inactive in the
answer.

I found a case where this differentiation matters:
Using an Asterisk SIP proxy (b2bua) with two registered baresip instances and configuring the early video option. If the callee reject the audio stream in the 183 Session Progress, the end result is a unidirectional audio after the call is established. By setting the corresponding media line as disabled via a=inactive, the call does have bidirectional audio after it is fully established.
This is quite common use case for "door station<->indoor station" communication. Where the one inside want to see the person on the door station before the call is established and has bidirectional audio & video.

PR for retests retest#27


Add "Introducing Flatpak Builds" post

Deploy preview for openbuildservice ready!
Built with commit abad395ea25fa2e804f78e1ecf391746ce06a5d5
https://deploy-preview-284--openbuildservice.netlify.app

Somehow I left an old paragraph in there that I actually had deleted. I removed it now and force pushed.