Update Mermaid

Hello,
I use Learn for my documentation and Mermaid to produce schema inside
To facilitate the creation of Schema, I need a new available mermaid functionality : https://github.com/knsv/mermaid/issues/916
Can you update mermaid, please?
If not, Is it possible to use a different version of mermaid than the one available in Learn ?
thank you

Please feel free to retrieve the latest version of mermaid and propose the upgrade in a pull request. You should include in the pull request a link to where you obtained the file from so that a reviewer can verify the integrity of the file.
It makes more sense for someone else to propose this change for a maintainer to review rather than have someone make the change directly without review.
If you would rather not propose the change in a pull request you can override your own local version of mermaid by creating the file static/mermaid/mermaid.js (note: not themes/hugo-learn-theme/static/...)

I have created a pull request for this to update to 8.2.6 - pull request

Fixed in #443. This issue can be closed


Magic string breaks SArray.explore()

I had an SArray which broke explore(). Eventually tracked the problem down to a single string value: \\x.
Running:  tc.SArray(['\\x']).explore() causes the following to get printed:
Got error: "The data couldn’t be read because it isn’t in the correct format." while trying to read: {"data_spec": {"values": [{"__idx": "0","SArray": "\x"}]}}. A visualization window is create but it never finishes loading.
It seems that having \\x any where in the SArray causes explore to break. We get the same behavior with this code: tc.SArray(['a', 'b', 'foo\\xbar', 'x', 'y', 'z']).explore().

The cause for this is that \x is one of the special character for unicode that needs to be followed by hex number, e.g. \x23, but we didn't detect and add special escape \x character before we pass it to the swift UI.

@sirahd - Thanks for figuring that out. Are there any other special characters that we should be escaping but aren't?

@TobyRoseman Assuming that the special characters are in Swift (where the error was previously thrown), there are \0,\\,\t,\n,\r,\", \' and \x (https://docs.swift.org/swift-book/LanguageGuide/StringsAndCharacters.html). I have tested all of them with two \ characters and they all work properly.


"Generate Commit Message with Copilot" not displayed when in workspace context

It seems that the "sparkles" ✨ button to "Generate Commit Message with Copilot" is not displayed when I'm in a workspace context.
Using folder, everything is working as expected:

Using workspace:

VS Code Version: 1.85.0 (ARM64)
OS Version: macOS 14.1.2 (23B92)

Note that I've tried to fully clean install Visual Studio Code and delete his cache and all extensions.

Same error here, not showing when in a workspace.

Same here, it was working and broke today after gitlens added the same feature and enabled it by default

Same here. Git Lens asked to me to enter a ChatGPT API KEY in order to generate the commit message.

This issue has already been fixed in VS Code Insiders, and will be included in the first VS Code recovery release. Closing this as duplicate of https://github.com/microsoft/vscode/issues/200375


At first sight the "Unable to get node resource" error looks benign, and triggered because we are not ignoring NotFound errors here. My understanding is that the CiliumNode is not necessarily expected to be present at that point, except for some IPAM modes which create it on their own. It is also possible that the CiliumNode store is lagging behind, and it is not yet containing the given CiliumNode although already present in k8s.

If we think this warning is benign, then can we detect the benign scenario and avoid emitting warnings? Or back off and retry to ensure that the warning/error is only reported after repeated attempts once we have the confidence to believe that there is a warning? This behaviour can confuse users and make them think something is going wrong.
Also worth noting that ideally warnings and errors should be actionable by the user. Reporting that a node resource cannot be found doesn't point out any consequences or what someone should do if this occurs.

@joestringer I'll assign myself this issue try reproducing using https://github.com/cilium/cilium/commit/7cfa82b1ddeb1fa2a690eeb52295791cfe1fc5b7 and the latest build. If the issue still exists, I'll fix the benign error.


Saved Work Gone

Issue Type: Bug
Hello,
I repeatedly saved my work yesterday , but just opened up my
VS to see that all of my code was gone. The folders and everything. Please help!
VS Code version: Code 1.41.0 (9579eda04fdb3a9bba2750f15193e5fafe16b959, 2019-12-11T18:37:42.077Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
AMD Ryzen 3 3200U with Radeon Vega Mobile Gfx   (4 x 2595)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
5.95GB (3.46GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

vscode-JS-CSS-HTML-formatter
lon
0.2.3

LiveServer
rit
5.6.1

html5-boilerplate
sid
1.0.3

@ceceliacshelley where did you store the folder on disk?

Hello! I’m at work right now, may I address this when I get home around 5?
 I truly apologize!
On Mon, Dec 23, 2019 at 10:49 AM Dirk Bäumer<EMAIL_ADDRESS>wrote:

@ceceliacshelley https://github.com/ceceliacshelley where did you store
the folder on disk?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/87451?email_source=notifications&email_token=AOCNOEE6ANMJJHLGUM4TH43Q2DMYHA5CNFSM4J6AAEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRMG4Y#issuecomment-568509299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOCNOEAJYCIG4G65MMGQXUTQ2DMYHANCNFSM4J6AAEBA
.

That's fine. Provide the information when you have it.


Autoapply classes for RxViewContext states

Problem Solved By The Feature
Sometimes we want to style the content differently depending on the reactive context.
ATM, it is only possible very clumsy.
Solution
Add class names for the different states to the dom:

suspense
next
error
complete

Maybe also the directive name:

rx-let
rx-if
...

this is a very good idea, so does the cdk. But how would you want to add those classes to the nativeElement? This could be a bit tricky, since the LetDirective often sits on a ng-container element. And which element does the PushPipe applies it's class to? Or is it just for structural directives?

Where is it used in material?

Close it as not needed


Update Google Lighthouse gist

Summary
Brief explanation of the feature.
lighthouse https://hyas.netlify.app/ --view

Basic example
Include a basic example or links here.
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome?

d9b35d2949a62725405d86ad87d2bd2ef838c3bd


Barriers broken by nearby zombies

Barriers should only be "broken" by zombies that are nearby it. They shouldn't be tied to specific spawners

Is this issue still accurate? And can't we just enable all zombies to be able to break every barrier


Fix bug related to newly-opened issues with no transitions yet

@nedbat this is the bug you ran into when first running the script.

OK - tested & confirms it works.


controller factory: add sync wrapper for unmanaged-state operators

cc @mfojtik @sttts

/lgtm

This grew into something that looks a bit more useful than I originally intended, see if we might want what the PR offers now. I'll need to add unit tests if we'd like to adopt this, ofc.

/remove-lifecycle rotten


Properly mark jsesc as a prod dependency

Resolves: #7
Change-type: patch
See: https://github.com/balena-io-modules/balena-compose/blob/d152cb9b57a00c46e3ab0e6225181bf3512f10a4/lib/emulate/index.ts#L20-L62
See: https://github.com/balena-io/balena-cli/issues/2515
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>

@balena-ci I self-certify!


[DmaLoopSubsumption] Fix for strided op in loop without induction var dependency

Fixes an issue exposed by a 128x32x64 matmul: https://github.com/nod-ai/iree-amd-aie/issues/556.
This issue would come up in partial loop dependencies in case of scf.forall:
scf.forall (%arg2, %arg3) in (2, 6) {
  %1 = amdaie.npu.dma_cpy_nd %0([0, %arg3] [8, 16] [16, 1], [] [] [])
  amdaie.npu.dma_wait(%2, S2MM)
}

In this case, the outer iteration upon which the NPU DMA operation didn't depend ( %arg2) would not be considered, resulting in incorrect output IR:
%1 = amdaie.npu.dma_cpy_nd %0([0, 0, 0] [6, 8, 16] [1, 16, 1], [] [] [])
amdaie.npu.dma_wait(%2, S2MM)

However, the outer iteration should be considered as well, making sure the above DMA operation is executed twice, resulting in the below output IR:
%1 = amdaie.npu.dma_cpy_nd %0([0, 0, 0, 0] [2, 6, 8, 16] [0, 1, 16, 1], [] [] [])
amdaie.npu.dma_wait(%2, S2MM)

This PR fixes the issue by adding general support for subsuming loop iterations into strided operations without any loop induction variable dependency.

I noticed only the outermost dimension can be zero in HW, so I will create a follow-up to not perform the loop subsumption in that case. As that is a specific HW limitation, I think it's not needed to alter the general behaviour of this transformation for that, so will use a flag to enable/disable that limitation.


validate_arguments skip arguments.

Feature Request
validate_arguments validates all arguments by default. I would love to be able to choose which ones to validate, e.g.:
@validate_arguments(['arg2', 'arg3'])
def myfunc(arg1: int, arg2: float, arg3: MyType):

happy to consider this, question is how complicated it would be to implement.

probably not that complicated. I'm writing this decorator myself right now. I'm basically applying validate_arguments on a partial version of the decorated function which only takes as input the arguments of interest. The only "challenging" part is to parse the arguments of the function to do so.

Hi there, I would like to know how this issue was going.
Maybe I can contribute.

Is this issue still open to work on? I would be interested if so!

I've taken a look at where I think changes would need to be introduced to make this happen, specifically: pydantic/decorator.py
Introducing this new behavior introduces some ambiguity, for example, say I have a function with required positional arguments:
def do_things(required_field: str, optional_field: Optional[str] = None):
    pass

Applying the following values: @validate_arguments(['optional_field']) basically means I'm turning my required_field into an optional one, which may validate an invalid function. (Meaning, the validator will pass but the function will encounter a TypeError Unless this is desired?)

AHA. I'm reading a bit further, perhaps the correct place to override this behavior is within the config argument of the validator! https://docs.pydantic.dev/usage/validation_decorator/#custom-config
I'll go deeper here. This is fun.

In v2, the right way to do this would be to create an annotation that causes it to skip validation by using a pydantic core any schema. This would be done via:
from typing import Any, Annotated

from pydantic_core import core_schema

from pydantic import validate_call

class SkipValidation:
    @classmethod
    def __get_pydantic_core_schema__(self, _source: Any, _handler: Any) -> core_schema.CoreSchema:
        return core_schema.any_schema()

@validate_call
def my_function(x: int, y: Annotated[int, SkipValidation]) -> None:
    print(repr(x), repr(y))

my_function('1', '2')  # validation will be done to x, but not to y
#> 1 '2'

Actually I will just open a PR adding this type to pydantic proper.


[stable/chart] Prometheus not able to scrape metrics from different namespaces

I have serviceMonitorSelector and serviceMonitorNamespaceSelector configured in values.yml for prometheus like below -
  prometheus-operator:
     prometheusSpec:
       serviceMonitorSelector:
         matchLabels:
           name: prophecy-operator
       serviceMonitorNamespaceSelector:
         matchLabels:
           prometheus: front-end-team

Namespace where servicemonitor is running has been labelled as-
 apiVersion: v1
 kind: Namespace
 metadata:
   creationTimestamp: "2020-03-02T12:33:53Z"
   labels:
     prometheus: front-end-team
     tag: abcd
   name: visa
   resourceVersion: "2069386"
   selfLink: /api/v1/namespaces/visa
   uid: 139112ef-5c82-11ea-9e6e-42010a8001b3
 spec:
   finalizers:
   - kubernetes
 status:
   phase: Active

Still, in service discovery, the service monitor running in this namespace are not listed and hence metrics are not scraped.

webservice_discovery.yaml

---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    app.kubernetes.io/instance: web_service
  name: web-service-discovery
  namespace: monitoring
spec:
  endpoints:
    - interval: 10s
      port: http
      path: /metrics/
  jobLabel: web-service discovery
  namespaceSelector:
    matchNames:
      - {{namespace_name}}
  selector:
    matchLabels:
      app.kubernetes.io/instance: web_service

kubectl create -f webservice_discovery.yaml

helm install --namespace monitoring stable/prometheus-operator \
--set kubelet.serviceMonitor.https=true \
--set prometheus.prometheusSpec.serviceMonitorSelectorNilUsesHelmValues=false

already discussed issue for namespaces :- https://github.com/helm/charts/issues/11310

But this is to select all service monitors in all namespaces and not for filtering by labels. What do I do for that?


You are missing the following 32 bit libraries, libc.so.6

Hi I am trying to get steam working in BashOnWindows and when running the application I get the error "You are missing the following 32-bit libraries, and Steam may not run: libc.so.6" I have tried updating and reinstalling the application but so far it continues to have the error.

Hi @GithubAccount453 , thanks for posting!  WSL does not currently support graphical applications, audio, or 32-bit libraries or applications (it's 64-bit only).  So you're unfortunately going to have a hard time getting Steam to work :-)  If this is something that you care about, I'd suggest posting about it (or upvoting it, if it's already there?) on the UserVoice.

User voice is here FWIW (not that it matters in the context). Very bizarre the "we don't support a 32-bit launcher because some of our games are 32-bit" non-sequitur debate over in steam-land.

Closing as duplicate of Issue #2468


Added Quickview toggle to theme editor via change to schema file

Added quickview toggle
https://jira.bigcommerce.com/browse/MERC-1230

Hey Adam, I just realized we duplicated efforts here. I put in a PR against MERC-558:
https://github.com/bigcommerce/stencil/pull/860
One critique of this PR:
There's already a property covering quick view in the config.json. Yours will either 1) be ignored or 2) override - and you've actually changed the default behavior in yours to HIDE quick view. Is this intended?

@bookernath thanks, I don't know how I missed that existing mention in config.json, I swear I had searched!  I shouldn't do this stuff when I'm tired.  I can adjust the PR pretty easily, or do you already have it covered?

@mcampa if you have a chance to review

Just to close the loop, I closed my PR in favor of this one.


Day 370

Good morning! Here's your coding interview problem for today.
This problem was asked by Postmates.
The “active time” of a courier is the time between the pickup and dropoff of a delivery. Given a set of data formatted like the following:
(delivery id, timestamp, pickup/dropoff)
Calculate the total active time in seconds. A courier can pick up multiple orders before dropping them off. The timestamp is in unix epoch seconds.
For example, if the input is the following:
(1,<PHONE_NUMBER>, 'pickup')
(1,<PHONE_NUMBER>, 'dropoff')
(2,<PHONE_NUMBER>, 'pickup')
(3,<PHONE_NUMBER>, 'pickup')
(3,<PHONE_NUMBER>, 'dropoff')
(2,<PHONE_NUMBER>, 'dropoff')
The total active time would be 1260 seconds.

Thanks for sending me the problem for Day 370 @Birdy-C . I believe the input in the problem statement isn't actually correct and definitely doesn't result in an answer of 1260 seconds.

Resolved by #955 .


Fix harvester_spec.rb test with wrong expect subject

In Harvester spec, fix ".entity_behavior knows its entity_behavior" to expect subject.entity_behavior instead of klass.entity_behavior.
That should normally fail, because klass should not be expected to have included Krikri::Harvester yet.  Depending on the order in which the specs were run, the issue was being masked, because the spec was operating on a klass that had had Harvester included by an earlier spec.

:+1:

Nice work spotting the problem, here.
I think this test really does mean to be testing the class method, though. The description uses the . method prefix (describe '.entity_behavior'), and the class method is what will be called by the Activity.
Maybe we should do expect(subject.entity_behavior).to eq(Krikri::OriginalRecordEntityBehavior).

Maybe we should do `expect(subject.entity_behavior).to eq(Krikri::OriginalRecordEntityBehavior)``.

That's actually what the change is doing: https://github.com/dpla/KriKri/blob/fix/harvester-spec-wrong-subject/spec/lib/krikri/harvester_spec.rb#L36
Since the test is really testing Krikri::Harvester to make sure that the entity_behavior that's defined in that class returns the right thing, you have to use subject in the spec like the other examples in the spec.

Sorry, my suggestion should have read subject.class.entity_behavior. The current test checks the instance method, but the test intends to check the class method.

Looks good. :squash: :question:


Suspend/Deactivate Feed - Feature Request

Feature Request:
It would be nice to have the option to pause/suspend/deactivate a feed from fetching data.

Right now, my current workaround is to change the Feed URL to an unreachable Feed URL to enforce this behavior. Very ugly but works.

+1, used this in v1, and I would certainly use it in v2 as-well.

+1, used this in v1, and I would certainly use it in v2 as-well.

Yes, same here!

+1, perfect for hollidays

This feature is available since version 2.0.17.


Change courses to include GitHub Pages reference in title

Overview
TL;DR
As GitHub Pages is a frequently searched term, I've modified the course title to include GitHub Pages and the specific interface used to interact with Git and GitHub.
Questions

Do people think this change looks 👍 ?

Next Steps

[x] Quick run through of the internal contents of the class to make sure the course title isn't referenced.

Review
I will ping once I have given the content a quick once over.

Ummm, yes? :wink: Thank you for making these updates @beardofedu

Предлагаю помочь мне разработать программу для сбора статистики грамотности каждого участника передачи информации в любом виде, обсудим?


Strange UI behavior when moving File Explorer window with context menus

First, I apologize if this is not FreeRDP related, I just need to rule it out. When using any FreeRDP version from RC4 to present and connecting to Win 8/10/2012 I have a strange UI issue that I was hoping others might see as well. Here is the scenario:
After a FreeRDP connection is established to a Windows 8/10/2012 machine, I start the File Explorer. Then I try to move the window using the following method: right-click the toolbar to bring up the context menu, left-click to select Move. When the All-Direction mouse pointer appears and then I try to use the mouse (left-click) to move the window. The expected behavior is to move the window. None of my three versions of Windows allow me to move the window. I can manually move the window using the arrow keys but not using the mouse. I used an old version of Windows 7 to see what it does and the expected behavior works.
Has anyone else seen this behavior? Again, I apologize if this is not related to this group. If not, I will submit as a bug to Microsoft.

Can anyone confirm they are or are not seeing this Windows behavior as well please?

Sorry for the delay, but I was afk this week.
As for your question, you should add some details to what you are actually using (xfreerdp? wfreerdp? ...)
Anyway, it may be better to use the mailing list or IRC for such questions as this does not seem to be a 'bug' but rather a question.


Chatting with two models at once, second request takes history (first answer) from one model and uses it in request to both models

Bug Report
Installation Method
docker
Environment
v0.3.13
no Ollama, two openai compatible endpoints
Linux, RedHat
Firefox 98.0
Confirmation:

[ X ] I have read and followed all the instructions provided in the README.md.
[ X ] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.
[ X ] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
Chatting with two models at once, second request takes history (first answer) from one model and uses it in request to both models. It was expected that both chats are fully separated and first model answers used as a history in requests to first model, second model answers used as a history in requests to second model.
Actual Behavior:
Initially I noticed quite strange responses on second question, as it looks like one model "stole" answer from another model.
Than I changes models order (first <-> second) and situation wth answers also swapped.
So I checked what are requests coming to OpenAI API and notices that second requests is identical fr both models and contains answer from only one model.
Description
Bug Summary:
Chats with several models are not fully separate, answer from one models used to continue conversation with everal models.
Reproduction Details
Steps to Reproduce:
like described above, no much can be added there
Logs and Screenshots
Browser Console Logs:
not applicable
Docker Container Logs:
not applicable
Screenshots/Screen Recordings (if applicable):
[Attach any relevant screenshots to help illustrate the issue]
Additional Information
The chat history doesn't contain full information about what is send to model on second request and how historical answers added inti second (third, ...) request. So chat logs doesn't help.

Fixed on dev. Please check for duplicate issues before creating one, Thanks.

@tjbck sorry, didn't find it. thank you@

Fixed on dev. Please check for duplicate issues before creating one, Thanks.
@tjbck, could you please share a link to the original issue? This is also applies to me.
Thank you in advance!


Browser Sync from

Just wondering does anyone know how to operate Browser Sync from within a container?
I’ve read https://stackoverflow.com/questions/42456424/browsersync-within-a-docker-container and there’s is a solution there - just wondering what the best configuration for Devilbox would be - a docker-compose.yml.override?

At the moment docker-compose.override.yml is your best option.
Having auto-vhosts for reverse proxies is not yet implemented, but on the agenda.
I will close this ticket in favour of the main one: https://github.com/cytopia/devilbox/issues/240
If you encounter  any issues with the worok-around method, please add it to the above mentioned ticket.

Hi,
I'm just trying to get BrowserSync to work for my next project and just
wanted to get your advice on something. If i create a
docker-compose.override.yml file and expose a few more ports (think
browserSync uses 3000 and 3001 by default) - what is the actual procedure?
If i remove all my images and containers first then do a docker-compose up
-d httpd php mysql again - i won't lose my databases will i? I haven't
touched the initial docker install - it's just as per the documentation.
Listen i know this is possibly a docker based question - but i just wanted
to check first
Thanks again
On Wed, Aug 8, 2018 at 7:39 AM cytopia<EMAIL_ADDRESS>wrote:

At the moment docker-compose.override.yml is your best option.
Having auto-vhosts for reverse proxies is not yet implemented, but on the
agenda.
I will close this ticket in favour of the main one: #240
https://github.com/cytopia/devilbox/issues/240
If you encounter any issues with the worok-around method, please add it to
the above mentioned ticket.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cytopia/devilbox/issues/344#issuecomment-411302488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/An9R4olu_1tSNITFZ2ELTrFs0X_3lHtDks5uOoelgaJpZM4VzUCC
.

@richardcantwell just to get you up to speed.
Anything can now be reverse proxied into/out of the Devilbox, this will also be true for BrowserSync

https://devilbox.readthedocs.io/en/latest/reverse-proxy/reverse-proxy-with-https.html
https://devilbox.readthedocs.io/en/latest/vhost-gen/virtual-host-vs-reverse-proxy.html

Here is an actual example setup for NodeJS:

https://devilbox.readthedocs.io/en/latest/examples/setup-reverse-proxy-nodejs.html

This is so good
On Sun 10 Mar 2019, 14:22 cytopia<EMAIL_ADDRESS>wrote:

@richardcantwell https://github.com/richardcantwell just to get you up
to speed.
Anything can now be reverse proxied into/out of the Devilbox, this will
also be true for BrowserSync

https://devilbox.readthedocs.io/en/latest/reverse-proxy/reverse-proxy-with-https.html
https://devilbox.readthedocs.io/en/latest/vhost-gen/virtual-host-vs-reverse-proxy.html
Here is an actual example setup for NodeJS:

https://devilbox.readthedocs.io/en/latest/examples/setup-reverse-proxy-nodejs.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cytopia/devilbox/issues/344#issuecomment-471310688,
or mute the thread
https://github.com/notifications/unsubscribe-auth/An9R4k0l9iGeaOoEKW3fyIsxoNrg_yt0ks5vVRVCgaJpZM4VzUCC
.

@cytopia apologies for referencing an old issue but I'm having issues understanding what's required to get BrowserSync working? I've copied the default nginx vhost to: ~/devilbox/data/www/project/.devilbox/nginx.yml
Testing this standard webpack/browsersync boilderplate setup:
https://github.com/WeAreAthlon/frontend-webpack-boilerplate


Pytest restart debugger works only with code-workspace files

Type: Bug

Behaviour
Expected vs. Actual
Debugger restart while running pytest should run pytest again. It currently works only for code-workspace files.
Actually, the second time, the debugger runs current python file.
Steps to reproduce:
sample.zip

Open sample_project folder
python3 -m venv .venv
source .venv/bin/activate
pip install pytest
Go to testing tab
Add a breakpoint to test_sample.py
Step inside do_something
Restart debugger
Ko => debugger runs current file

Again, with a code-workspace file:

Open sample_workspace/sample.code-workspace
2-8. Same steps
Ok => debugger runs again the selected test

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.8.10
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

testing
• pytestEnabled: true

Extension version: 2023.8.0
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (16 x 2904)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.72GB (9.62GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (16 x 2904)

Memory (System)
9.72GB (6.29GB free)

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (16 x 2904)

Memory (System)
9.72GB (6.29GB free)

VM
0%

Hi! Thank you for the detailed steps and the example repo! I tried your steps and was unable to see the issue. When I click restart, it looks to run testing once more. Here is a recording of my steps, does this look like what your does? Any other settings which might be influencing the behavior?
https://github.com/microsoft/vscode-python/assets/26030610/019638ea-ad48-48fe-baeb-96754524b690

Ok, I think I see the difference between my setup and yours.
sample_project and sample_workspace should be opened in two separate VSCode instances.
The first with "Open Folder", and the second one with "Open Workspace from file"

https://github.com/microsoft/vscode-python/assets/2413781/ed5cd2d1-5a26-4afd-a62d-f6f2441758be

Hi! I can no longer repro this so I am closing it. We have just fixed up how some of the test flow works on the rewrite and this could have resolved this too. Let me know if you are still seeing this issue and I can take another look. (the more recent changes to the test flow are on insiders right now and will be out on stable later this week).


Add component binding to itself

Thank you for the contribution! Could you please add this feature to the compatibility list?


Replace trial app with bank app.

'trial' app was created for testing. It's not useful now. However, the models created by it are used by the 'contest' app. Replace 'trial' with a 'bank' app that contains model for problem bank. Make 'contest' app compatible with it. Remove unnecessary code from 'trial' app.

Fixed in #23 . Thanks @PrajwalRavi.


bugzilla: use public docker image repo for releaseInfo.Bugs

Using just tag.Name (as used in sync.go) results in the following error:
I0527 20:16:11.174903       1 glog.go:58] Failed to generate bug list: command terminated with exit code 1
$ oc adm release info --bugs=/tmp/git/ --output=name 4.1.0-0.nightly-2020-05-23-080652 4.1.0-0.nightly-2020-05-24-040147
error: the semantic version "4.1.0-0.nightly-2020-05-23-080652" is not present in the cluster version status or in the official versions list, cannot be resolved

This PR changes the bugzilla sync function to use the public docker repo version of the image instead, similar to the way the web interface works.
/cc @stevekuznetsov

/lgtm


No Logs are displayed

Hi,
I was wondering if you can see the Log-messages called by LogHelper.
My build variant is Debug, but Logcat (both Android Studio and ADB) does not show me any messages, which are called via LogHelper... Everything else is there.
Does anyone have an idea what I'm doing wrong?
Many thanks in advance!

never mind, found a workaround

Hi,
I have the same problem than you, ( LogCat does not show me any messages),
Build Variant : Debug, no filters, and Mode Verbose in Logcat.
I'm a total nob, and if you had any information about this issue, I would be very grateful.
Thanks

Check this file:
https://github.com/googlesamples/android-UniversalMusicPlayer/blob/master/mobile/src/main/java/com/example/android/uamp/utils/LogHelper.java
and then comment out the if-clause for v and d:
 public static void v(String tag, Object... messages) {
        // Only log VERBOSE if build type is DEBUG
        if (BuildConfig.DEBUG) {
            log(tag, Log.VERBOSE, null, messages);
        }
    }

to
 public static void v(String tag, Object... messages) {
        // Only log VERBOSE if build type is DEBUG
        //if (BuildConfig.DEBUG) {
            log(tag, Log.VERBOSE, null, messages);
        //}
    }

Worked for me!
Bests, Martin


Improve some documentation in cw-core and cw-proposal-single.

This adds some module level documentation to cw-core and cw-proposal-single. This will be nice to have once we publish cargo packages.

Codecov Report

Merging #379 (6045ba5) into main (3636c7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   96.94%   96.94%
=======================================
  Files          39       39
  Lines        8760     8760
=======================================
  Hits         8492     8492
  Misses        268      268

Impacted Files
Coverage Δ

contracts/cw-proposal-single/src/state.rs
97.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3636c7c...6045ba5. Read the comment docs.


Adding on change event in editable dropdowns when value is changes through code.

This is duplicate of the previous PR #14888 as that one was having many merge conflicts with the main.

@aasimkhan30 please get the CI builds clean before merging.

@alanrenmsft and @Charles-Gagnon. It seems Linux has a different call stack than windows and Mac.
Check this run out:
https://github.com/microsoft/azuredatastudio/pull/14888/checks?check_run_id=2206969319

Pull Request Test Coverage Report for Build 744110863

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
349 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.03%) to 43.579%

Files with Coverage Reduction
New Missed Lines
%

extensions/arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts
20
11.32%

src/sql/base/browser/ui/table/plugins/headerFilter.plugin.ts
24
0.63%

src/sql/workbench/api/common/extHostModelView.ts
305
35.28%

Totals

Change from base Build 734595070:
0.03%

Covered Lines:
26206

Relevant Lines:
54955

💛  - Coveralls

What do you mean "different callstack"?

@alanrenmsft and @Charles-Gagnon. It seems Linux has a different call stack than windows and Mac.
Check this run out:
https://github.com/microsoft/azuredatastudio/pull/14888/checks?check_run_id=2206969319
What do you think is the reason for that?


Handle Escape Click for Zoomed images

This pull request closes (past link to GitHub issue here).
Pre-Flight Checklist
I have made sure to

[x] make sure this PR is set to merge to the correct X-0-stable branch
[ ] add a Storybook example (if necessary)
[x] manually test all the Storybook examples

run $ yarn run storybook
navigate to http://localhost:6006

[x] run $ yarn run build to build the project code & static example
[x] check that the example in example/build/index.html works: $ open example/build/index.html

Thanks for all the comments! They're very informative in my case, only been a dev for about a year now, and I started with ReactJS. I applied the changes based on your comments in another commit. I've enjoyed working on your project. It was really easy to read, very clean code. 👌


Results on part segmentation

Hi, I have another question to ask you.
I am currently using your part seg model, but doesn't seem to get the iou stated on the paper.
However, you have said in the other posts that you have re-run the same exp for multiple times, is it correct?
Why does it make the model to perform better and what is the difference between increasing epochs and re-run the same experiment for multiple times?
Also, how many times have you re-run the experiment to get the values on the paper?
Thank you.

Sorry I have another question regarding the number of k for knn.
In the paper, it says k=20 for 1024 points and k=40 for 2048 points.
Does this mean if I have point cloud larger than 2048 pts e.g.8192 points, then do I have to choose k = 160 for the best outcome?

I suggest you re-run the exp because the optimizer has randomness. For point cloud exp, the randomness is usually big.
In the DGCNN paper, the author only runs the exp on the two settings (k=20 for 1024 points and k=40 for 2048 points).


[ENTESB-8051] Hl7 component module is missing dependency for org.apac…

…he.mina.core
Resolves #2513

retest this please

retest this please


Fish abbreviations

Would be good to have better fish integration.
However this script can do it:
#!/usr/bin/env ruby

lines = File.read('.kubectl_aliases').split("\n")

script = "#!/usr/local/bin/fish\n\n"

lines.each do |line|
  abbr = line.match(/alias (\w+)/)[1]
  cmd = line.match(/\='(.+)'/)[1]
  script << "abbr -a #{abbr} #{cmd};\n"
end

File.write('/tmp/fish-k8s-abbrs', script)

`chmod +x /tmp/fish-k8s-abbrs`
`fish -c /tmp/fish-k8s-abbrs`
`rm /tmp/fish-k8s-abbrs`

For the fish folks that find this. You can put this function in your ~/.config/fish/functions/ folder and it will automatically pull down the latest abbreviations from this repo and convert them as shown above.
function __update_kubectl_abbrs
	curl -s -o /tmp/fish-k8s-abbrs https://raw.githubusercontent.com/ahmetb/kubectl-aliases/master/.kubectl_aliases
    cat /tmp/fish-k8s-abbrs | sed 's/alias /abrr -a /' | sed "s/='/ '/" > ~/.config/fish/conf.d/kubectl_abbrs.fish
    rm /tmp/fish-k8s-abbrs
end

Thanks for the abbreviations!


task.Result never makes call or returns value

I have integrated this example into my application and have followed the code line by line and everything seems to be equivalent however, in the example app you put the email into the ViewBag using the following code
ViewBag.Email = await graphService.GetMyEmailAddress(graphClient);
in my application I am using the following:
String email = graphService.GetMyEmailAddress(graphClient).Result;
but the callout to the service endpoint never happens and this code never resumes - it is like it  just ends abruptly (thread abort)
I am fairly new to the async / await pattern so I am assuming it has something to do with this - but based on my reading this should work
What am I doing wrong?
Thanks in advance.

It's a best practice to use await "all the way down." Have you read this piece on async best practices?
https://msdn.microsoft.com/en-us/magazine/jj991977.aspx

I have narrowed it down to the fact that it is executed in a old style synchronous .ashx handler and because it is executed on a different thread it looks like the call is never made when in fact it is actually making the call correctly (verified thru Fiddler as well as stepping through the code line by line once I got the SDK)
Mixing the asynch/await pattern into my application, which I just converted from aspx pages is not a trivial task (since asynch/await has been likened to a virus that will spread throughout your code and my code-base is large)
I am looking for two things - 1) can anyone support my suspicion that it is mixing the two patterns that is cause the issue (I think jamescro has already done this), and 2) what are my options, is a non asynch/await version of the library going to be made available.
Thanks in advance.

Thanks for the clarifications. Could you post this question to Stack Overflow? It looks like something that others will run into, so any solutions would be recorded in a place where more people could see it. The issue also doesn't related directly to the sample.

Will do
However the last question is definitely relevant to this forum - is an non-async version of this library going to be created (and ideally maintained going forward)

Thanks. You can direct your question about the library (and any other questions about the library) in the microsoft-dotnet-sdk  repo. That's where the library source lives.


update jenkins.version to LTS from 2.150.1 to 2.164.3

https://jenkins.io/changelog-stable/

I support 2 major LTS versions so this change does not make sense yet


Active pulling of model information from model server

Instead of doing the model handling in rasa core (e.g. by pushing a new model through the http API) - rasa core should regularly pull a model server for the model to be used. This scales better in a multi-instance setup and allows continues model updates where needed.
The idea is to start up rasa core with e.g. a model label (e.g. "latest" or "stable" or "production"). Rasa Core then regularly queries the latest model information of that label from a model server (probably a get request to a resource) - the model server responds with information about the most recent model it as with that tag. If the information is different from the information of the model core has loaded, the new model will be downloaded and loaded.

@ricwo can you give a quick status update on what is already done and what still needs to be done?

@tmbo it's done, just needs to be reviewed :)
https://github.com/RasaHQ/rasa_core/pull/645

@ricwo this is not blocked by another task though, it just needs to be reviewed right?


Create plan for security work to disable key-based auth for Azure OpenAI services

We will need to disable key-based auth so this task is to plan the transition

Identify the Azure OpenAI resources that are being used for integration tests and document these
Switch to using specific agreed resources and deploy any required models
Switch integration tests to use Default Azure Credential for authentication


LittleFS error occurs suddenly

on my M5Dial,
Using LittleFS,
Suddenly this error occurs.
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp:920:23: error: cannot declare variable 'file' to be of abstract type 'lgfx::v1::DataWrapperT<fs::LittleFSFS>'
before then, this program normally runs.

In file included from .pio/libdeps/esp32/M5GFX/src/M5GFX.h:22,
from .pio/libdeps/esp32/M5Unified/src/M5Unified.hpp:19,
from .pio/libdeps/esp32/M5Unified/src/M5Unified.h:5,
from src/main.cpp:2:
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp: In instantiation of 'bool lgfx::v1::LGFXBase::drawJpgFile(T&, const char*, int32_t, int32_t, int32_t, int32_t, int32_t, int32_t, float, float, lgfx::v1::datum::datum_t) [with T = fs::LittleFSFS; int32_t = int; lgfx::v1::datum::datum_t = lgfx::v1::textdatum::textdatum_t]':
include/image.h:37:74: required from here
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp:920:23: error: cannot declare variable 'file' to be of abstract type 'lgfx::v1::DataWrapperT[fs::LittleFSFS](javascript:void(0))'

It has been found that drawJpgFile is the problem.
Executing the following line of code:
M5Canvas canvas.drawJpgFile(LittleFS, "/image.jpg", 0, 0);
results in the error mentioned above.

In file included from .pio/libdeps/esp32/M5GFX/src/M5GFX.h:22,
from .pio/libdeps/esp32/M5Unified/src/M5Unified.hpp:19,
from .pio/libdeps/esp32/M5Unified/src/M5Unified.h:5,
from src/main.cpp:2:
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp: In instantiation of 'bool lgfx::v1::LGFXBase::drawJpgFile(T&, const char*, int32_t, int32_t, int32_t, int32_t, int32_t, int32_t, float, float, lgfx::v1::datum::datum_t) [with T = fs::LittleFSFS; int32_t = int; lgfx::v1::datum::datum_t = lgfx::v1::textdatum::textdatum_t]':
include/image.h:47:83: required from here
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp:920:23: error: cannot declare variable 'file' to be of abstract type 'lgfx::v1::DataWrapperT[fs::LittleFSFS](javascript:void(0))'
DataWrapperT<T> file ( &fs ); \
^~~~
.pio/libdeps/esp32/M5GFX/src/lgfx/v1/LGFXBase.hpp:927:5: note: in expansion of macro 'LGFX_FUNCTION_GENERATOR'
LGFX_FUNCTION_GENERATOR(drawJpg, draw_jpg)

Hello, @sastles-com
I don't have your source code so I can only guess, but have you changed the order of your includes?
If you use LittleFS with M5GFXorM5Unified, you need to include the LittleFS headers first.
// include before M5Unified.h
#include <LittleFS.h>

// include after LittleFS.h
#include <M5Unified.h>

void setup(void) {
  M5.begin();
  LittleFS.begin();
  M5.Display.drawJpgFile(LittleFS, "/filename.jpg", 0, 0);
}


Bump version to 1.0.0-X17-SNAPSHOT

As requested by @jvican

To validate this pull request against other sbt modules, please visit this link.

@Krever Thank you!
@sbt/zinc-team: The reason why we bump up the version is because if we publish the bridges locally, the sbt 1.0.0 build will pick them up. This is an issue when we publish binary incompatible changes, because they fail to link when we try to compile anything else in sbt.
That's why it's important that zinc artifacts are always one version ahead of the version that is used in sbt 1.0.

To validate this pull request against other sbt modules, please visit this link.

To validate this pull request against other sbt modules, please visit this link.


[RFC] How to apply configuration

Uart::new() should be infallible, only applying some invalid config should be invalid
Remove the independent change_x mutator methods in favour of apply_config(&mut self, config: &Config) https://github.com/esp-rs/esp-hal/pull/2449

Should all other drivers be reworked to use a config struct? My main worry is that clock speed calculations on SPI aren't trivial and changing any configuration means changing everything with this approach.
Should we keep with_config that moves self, along with apply_config?

Considering https://github.com/esp-rs/esp-hal/issues/2389 and the cost of a full reconfig, do we even want config structs? What if we got rid of them in favour of single option setters?

Considering https://github.com/esp-rs/esp-hal/issues/2389 and the cost of a full reconfig, do we even want config structs? What if we got rid of them in favour of single option setters?

Hmm, I quite like the idea of a config struct because it neatly packages everything in one place. In the case of Uart for example, we have to forward methods from UartRx to Uart and the same for UartTx. All three could just have one apply_config method and each will update there respective parts of the config.
Regarding the cost, we can actually be quite smart about this in the future. We can keep a copy of the current config and then only update the options that have changed. If we didn't want to pay the memory cost of storing the config in the driver, we could also just check the registers themselves (though this wouldn't work for registers that require some calculation from config inputs).

Checking the registers before writing the same or different value into them doesn't make much sense :)

My main worry is that clock speed calculations on SPI aren't trivial

There's a solution for this one. https://github.com/esp-rs/esp-hal/issues/1666#issuecomment-2154512074

I'd like to batch https://github.com/esp-rs/esp-hal/issues/1919 into this issue. Not necessarily for UART, but mainly for SPI - we get per-device configuration for free using https://docs.embassy.dev/embassy-embedded-hal/git/default/shared_bus/asynch/spi/struct.SpiDeviceWithConfig.html

Uart::new() should be infallible, only applying some invalid config should be invalid

We have a few options on how to apply initial configuration, but we'll have to pick which one we'll do:

new() -> Driver; and new_with_config(config) -> Result<Driver, Error> - default config is rarely what the user needs, we don't have to optimize for that
Only have new() -> Driver and apply_config - forces an extra call, which is probably fine for SPI shared bus but not really good elsewhere
new(config) -> Driver. We could panic if the driver is initialized with an invalid config as it's likely the user will just unwrap it and get the panic anyway.
new(config) -> Result<...> - probably the least offensive option. The compiler is often smart enough to remove the panic, but new().unwrap() isn't terribly elegant.

My gut feeling is 4 but my common sense would prefer 3
I assume that people will use fixed configurations so they will see the panic early in development and not have devices crash randomly in the field weeks later

I guess if we choose 3 and someone absolutely needs the driver to not panic but provide an error, they can create the driver with Config::default() and call apply_config with custom configuration. I expect in case bus configuration isn't known at build time (is read from some other source, like persistent storage) this might see some use. I consider this a special enough case to not actively optimize for (which would be option 4).

I like the 3 the most.

I also like 3 most.
I sorta like 4 but I'd prefer if the error handling happened before creating the driver. (i.e. make it impossible to create an invalid config) which just makes it look like 3 anyway.

(i.e. make it impossible to create an invalid config)

Most of the difficulty comes from baud rates, especially where the clock source is configurable. In that case, it is unfortunately rather difficult to check a config in compile time.

I mean something along the lines of Config::set_frequency returning a Result.

I'm leaning towards 3, but I'm wondering about the case where driver initialization might happen later in the program. I see the value in panicking early if it's initialized early, but is it acceptable to panic later?
Another consideration, what if the config is stored on an eeprom at runtime, the next reboot the settings are loaded from there. If someone somehow stored an invalid config we'll essentially bootloop. The solution to this in this case is to always use apply and pass Default::default into the constructor, but it's worth thinking about.

Quoting our API-GUIDELINES

Prefer compile-time checks over runtime checks where possible, prefer a fallible API over panics.

I feel like this pushes us closer to 4 or 2, unless we want to rethink this guideline.

Whilst 3 is my favorite ergonomically, I think to support a wide range of use cases we should go with option 4.
Option 3 relies to heavily on the fact a driver is created at the beginning of the program and lives the entire time. This doesn't play nicely with the peripheral pattern for example, and may end up with unexpected panics.
Option 3 also pushes users to emulate option 2 for the case where they don't want to deal with those panics, meaning they call with default config and use apply_config (applies config twice, not great.)

I sorta like 4 but I'd prefer if the error handling happened before creating the driver. (i.e. make it impossible to create an invalid config) which just makes it look like 3 anyway.

This would be nice, but I don't think it's possible to implement this for every driver, as it can depend on a lot of variables outside of what the config can see. One example would be to choosing a clock source that's not enabled, should the config be checking this and returning an error, or the driver? I would argue a config shouldn't be poking around in clock registers.
I think if we go with option 4 now, we can come up with some more ergonomic helpers to alleviate the pain of unwrap later down the line.


Release and deploy 0.4.12

0.4.12 should include the db optimization (#1779)

It would be cool if we could include this PR in the new release: https://github.com/itchysats/itchysats/pull/1824
This will allow us to embed default peer ids in subsequent taker release.

Closing as this ticket is not needed.


Issue1328 Incorrect setting-to-null of optional constructor argument when using named arguments

Fixes #1328.

The issue is basically fixed; waiting for #1340 fix to pass the tests and check if more fixing required


Fixing the paths to related README.md files

Description
Path to README files for fetch-tool and Fluid Debugger were incorrect and leading to 404 - page not found
Present paths (incorrect) were as follows

https://github.com/microsoft/FluidFramework/blob/main/packages/tools/fluid-fetch/README.md
https://github.com/microsoft/FluidFramework/blob/main/packages/drivers/fluid-debugger/README.md

Corrected paths are as follows

https://github.com/microsoft/FluidFramework/blob/main/packages/tools/fetch-tool/README.md
https://github.com/microsoft/FluidFramework/blob/main/packages/drivers/debugger/README.md

@arafat-java Thank you for the fix!!

@Josmithr It is waiting on "Validate CODEOWNERS Expected — Waiting for status to be reported"

@Josmithr It is waiting on "Validate CODEOWNERS Expected — Waiting for status to be reported"

@arafat-java Can you elaborate on where you're seeing that? The PR has already been merged, so there shouldn't be any remaining checks.

@Josmithr It is waiting on "Validate CODEOWNERS Expected — Waiting for status to be reported"

@arafat-java Can you elaborate on where you're seeing that? The PR has already been merged, so there shouldn't be any remaining checks.

All good now, yesterday while it had not merged it was waiting


Define pads with absolute register addresses

We used to describe a pad with

two absolute addresses to the start of the MUX and PAD group, collectively called a "base"
an offset into the group block

We did this with custom types and typenums. The pad types are unique, because the (base, offset) type pairings are unique. But, there's the chance for a runtime op to compute a pointer offset. And when erasing the types, we need to maintain three pieces of information: two pointers for the base, and one offset.
In this PR, we use const generics to describe absolute MUX and PAD register addresses in Pad types. The types are still unique, since the absolute addresses are unique. There's less chance for a runtime cost for pointer offset, and we can reduce the size of all erased pads by four bytes.
Use tests from #21 and the doctests to show that most documented APIs are unchanged. Note that this PR targets #21's branch.

very nice


Shadow quality depends on screen resolution when camera is orthographic

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (NVIDIA; <IP_ADDRESS>02) - 11th Gen Intel(R) Core(TM) i5-11400F @ 2.60GHz (12 Threads)
Issue description
https://github.com/godotengine/godot/assets/6430599/987e4c17-7502-4cf6-94bd-cbe58f42cdf6
When you change resolution, the quality of shadows changes.  Using the Orthogonal directional shadow mode.
I would expect that the shadow quality is independent of window size.
Steps to reproduce
Run the sample project and resize the window.
Minimal reproduction project
ortho_shadow_bug.zip

That's just mesh level-of-detail (LOD) changing based on how much the mesh takes space on the screen/shadow map and is normal and also affects the shadow. You can either disable automatic LOD generation on reimport, tweaks the LOD bias or manually create better LOD meshes. Closing as not bug, although there are some open issues related to automatic LOD generation quality etc.


Rename "my application letters" to "my events" (#383)

Coverage remained the same at 100.0% when pulling f4df58db5a1162363b937cf03586fd6873685208 on 383-my-events into d5e21cc5ffd9bc12f25af7225121f112283d315a on dev.

Coverage remained the same at 100.0% when pulling eab96a19d627cfdc018845634e646ce116c2ffec on 383-my-events into d5e21cc5ffd9bc12f25af7225121f112283d315a on dev.

Coverage remained the same at 100.0% when pulling 6836988a03c9b9a8908d949c8e17dcc0f738f7b8 on 383-my-events into d4684d64560f3f0b80ed7c8b385b1e49765b34c4 on dev.


docs: add rfc for storage architecture

The main goal is to remove the mysql dependency from the API layer, and we suggest a solution by modifying the storage layer architecture. #1252

let say if we have an API that do update account, after success updating, we need to query the feature table to get number of features then return both value to client. Would you call account storage to update account then call feature storage or would you do it in one storage?

@hvn2k1
https://github.com/bucketeer-io/bucketeer/pull/1290#issuecomment-2443003561
Thank you for your comment.
Is this question about how to maintain consistency when multiple storages need to be updated in one request?

I tried to think of a way to maintain consistency in updating multiple tables from the API side, as shown in the sequence diagram below.

By creating storage instances using the same storage client instance (e.g. mySQLClient, etc.) and controlling transactions using the same transaction instance between different storages, consistency can be maintained for rollbacks and commits.
On the API side, if all storage operations are successful, Commit must be called at the end.

We welcome your comments and questions.

@hvn2k1 @Ubisoft-potato
Please check the comments below when you have free time and look forward to your comments.
https://github.com/bucketeer-io/bucketeer/pull/1290#issuecomment-2449424232

https://github.com/bucketeer-io/bucketeer/pull/1290#issuecomment-2449424232
@kakcy sorry for late reply! I wonder why we only call commit() on countStorage?

@hvn2k1
I tried to think of a way to maintain consistency when updating multiple tables from the API side, as shown in the sequence diagram below.
*Unlike the previous proposal, there is no need to call commit() from the API side.
You can maintain rollback and commit consistency by using the same storage client instance (such as mySQLClient) to create storage instances and using the same transaction instance to control transactions between different storages.

@kakcy  The new transaction flow looks good to me! 👍
As @hvn2k1 said we don't need to call commit mannually, the current implemetation will commit
transaction automatically after all operation finished.

ahh I see, it looks awesome! 💯

Thank you for your review!
I have updated the RFC regarding the transaction you pointed out.

@cre8ivejp @kakcy  The current solution proposal looks good to me.
I think it can resolve the MySQL storage layer dependency architecture issue.

@cre8ivejp @kakcy this solution LGTM! 🚀


Fix bitfield generation bug with const function

Const function can't have variables or blocks.
r? @fitzgen

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon.

@bors-servo r+

:pushpin: Commit 88342c9 has been approved by emilio

:hourglass: Testing commit 88342c9371f3384717f407751bde4848075a6aae with merge 50faeab09f240588e519995e85a2eabbfc691252...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 50faeab09f240588e519995e85a2eabbfc691252 to master...


Introduce more APIs around the audit log destination authoring

In the admin services there is a call
@PostMapping(path = "/audit-log-destinations/connection")
public VoidResponse addAuditLogDestination

I could introduce update and delete calls  as a rest call and in the admin client. I would then also expose these APIs in the server author view.
It would then allow the server author user to supply a name and description for their audit log destination - the calling code would map the audit log destination  type (console , default etc) to the appropriate class for the connection.
As to what to use as the resource identifier:
-there is a Connection open type which extends referencable so it could have a guid. but this is not set in the Connection objects.
I see in ConnectorConfigurationFactory for example that the connection for console is created like this
`public Connection getConsoleAuditLogConnection(List supportedSeverities)
{
final String destinationName = "Console";
    Connection connection = new Connection();

    connection.setDisplayName(destinationName);
    connection.setConnectorType(getConnectorType(CONSOLE_AUDIT_LOG_STORE_PROVIDER));

    setSupportedAuditLogSeverities(supportedSeverities, connection);

    return connection;
}`

So even though the connection is a Referencable there is no guid - I assume because it is not persisted in the repository.
I suggest that the best identifier for me to use in the API would be the display name the server code would only look for this in the CONSOLE_AUDIT_LOG_STORE_PROVIDER type.

@mandy-chessell I would appreciate your thoughts on this approach.

OK to add the extra calls.
On the name - I would have the end user supply the name since they have their own ideas on what the destination's means to them.  The default could be the display name from the connector type but that is not so useful if they set up multiple desintations of the same type.
I do not understand the reference to the open types?  Are you saying that we do not set the GUID of elements in the config - that is true - we did originally but now only set up minimal values to make it easier for people to specify the payloads.
The Connection in the config document is the OCF Connection object.  It does include a guid field if you want to set it.

OK to add the extra calls.
On the name - I would have the end user supply the name since they have their own ideas on what the destination's means to them. The default could be the display name from the connector type but that is not so useful if they set up multiple desintations of the same type.
I do not understand the reference to the open types? Are you saying that we do not set the GUID of elements in the config - that is true - we did originally but now only set up minimal values to make it easier for people to specify the payloads.
The Connection in the config document is the OCF Connection object. It does include a guid field if you want to set it.

thanks for the quick response :-)  Yes you understand correctly - I was thinking I might have been able to use a guid - but as I found out, and you confirmed, there are no guids in the connection in the config. I will put you as a reviewer on this change.


How can StandardJS and ESLint work side-by-side?

What version of this package are you using?
14.3.1
What problem do you want to solve?
When setting up my editor (vim) I'm forced to choose between using Standard and using ESLint. I'd love to be able to use both side-by-side. Any thoughts on the best way to do this?
If I use the config from the readme then repos that use ESLint don't get linting. If I use ESLint, then StandardJS repos don't get linting. Someone's gotta have this figured out, right?
What do you think is the correct solution to this problem?
Add documentation on how to make ESLint and StandardJS work side-by-side.
Are you willing to submit a pull request to implement this change?
Yes.

I had a weird idea about this while falling asleep last night.
Maybe it'd be worthwhile to have a tool that acts as a switch between standard and eslint depending on the current working directory? I don't think it would be very difficult to write some rules to determine whether a given project is using StandardJS or plain ESLint, especially if we can check:

package.json

.devDependencies
.scripts.test

.eslintrc*

I'd imagine that this should probably be investigated as a standalone project, and I'd propose calling this idea common-lint, or clint. :cowboy_hat_face:
Anyway, I'd love some feedback on:

whether this is a good idea at all
suggestions
thoughts
feels
etc

Thanks!

I got carried away and accidentally made a proof of concept: https://github.com/fraction/common-lint
I've tried integrating with Ale but it's only working on StandardJS repos, not ESLint repos.

An ESLint editor plugin should spring into action when an ESLint configuration file is detected or when the plugin is explicitly enabled.
A StandardJS Editor plugin should spring into action when the standard package is locally installed. That's just my opinion.
If the two points above are correct, then I don't see a problem. But you're experiencing a problem. So I am assuming that at least one of these points are wrong in your case. Could you please describe?

Thanks for the thoughtful comment. I'll try to add some more context and be a bit more explicit about the behavior that I'm looking for.
I'd like to be able to use the same linter in every repository, similar to how we use the same text editor in every repository. I'd also like for my text editor to automatically use the linter recommended by the repository I'm editing.

When I'm editing code that calls standard during npm test, I'd like for my linter to use standard.
When I'm editing code that calls eslint during npm test, I'd like for my linter to use eslint.

Currently, the readme recommends the following Vim config:
let g:ale_linters = {
\   'javascript': ['standard'],
\}
let g:ale_fixers = {'javascript': ['standard']}

Adding this to ~/.config/nvim/init.vim ensures that my editor can use StandardJS as a linter, but it means that my editor applies StandardJS to all repositories. This causes problems when working in  non-StandardJS repositories that have an .eslintrc* because my linter will be making different recommendations than the project linter.
Alternatively, I could use:
let g:ale_linters = {
\   'javascript': ['eslint'],
\}
let g:ale_fixers = {'javascript': ['eslint']}

But this would make my editor try to call eslint on all of the files I'm editing, which wouldn't work with modules using StandardJS because they don't have .eslintrc* config files that the editor can pick up.
I think there are a few possible solutions to this problem, assuming it's a problem worth solving:

Recommend a better Vim config. I can't think of a way to do this, but maybe the Ale plugin(s) could be more intelligent and auto-detect which linter to use? I'd rather avoid this solution if possible, but maybe that's just because my VimL skills are bad. This also doesn't solve the CLI problem where people have to remember which tool to use.
Add a layer of abstraction (e.g. common-lint). This would auto-detect which linter to use, but seems to be a pain to integrate with editors and such because standard and eslint have different formats of output. Maybe common-lint should normalize the output? Standardization is fun.
Modify either standard or eslint to be mindful of the other. This is basically an extension of the previous option, where some linter integrated a way to auto-detect the presence of another linter's config and yield to the other linter. This would technically solve the problem, but I'd way rather experiment with this as a standalone tool before making an extension to an existing linter.

I'd be super open to other ideas on how to resolve this, or feedback on the above.

When I'm editing code that calls standard during npm test, I'd like for my linter to use standard.

I'm not sure that this would be the best way to determine. My suggestion is whether standard is locally installed or not. And regarding ESLint, whether one of the default configuration files exists.
A later of abstraction seems redundant to me, in the optimal case where each editor plugin can sensibly figure out whether it should act or not. This way, the various editor plugins do not need to be aware of each other.
I went through the ale code a little bit and didn't find an obvious detection mechanism. So I'm not sure what that depends on. Perhaps you could try uninstalling globally installed standard and eslint packages if you have any in the case the ale might be picking them up and acting on any project. Alternatively, ale might have an option to disable detection of globally installed linters (or specifically standard/eslint).

Considering my understanding that Standard JS is already based on ESLint, you should be able to solve this by using eslint together with eslint-config-standard (and several esint plugins, as documented by the eslint-config-standard package). Or am I missing something deeper here?


Make verifyItem optional

Make verifyItem optional by having a dummy default that always returns true

hmm ok so it's atleast checking prescence? what happens if the stored value is a boolean false?

It isn't checking presence, it'll always return true. I just included the param in the expression to make TS shut up about unused params. :)

after actually reading the code I got it, thanks. LGTM!

PR updated with fix for not using verifyItem when no stored value, as discussed in #17

Here's basically how I visualize it being done, it doesn't matter if the parsing fails/succeeds if the storedItem is not existent, hmm, now, to find a case where this "fixes" something.

Ok took some time, but here's a case:
it('correctly allows null to be stored', async () => {
  localStorage.removeItem('myOtherKey')
  localStorage.setItem('myOtherKey', JSON.stringify(null))
  const atom = localStorageAtom(
    'foo',
    'myOtherKey',
    (v): v is null | 'foo' => v === null || v === 'foo',
  )
  expect(atom.getValue()).toBe(null)
})

Ah! Good catch, good test!

Updated according to Bahtijaragic wisdom above, + handling of unparseable stored values.

Oh! This new failing test is actually interesting. Some thinking required around how you want that to behave!

Oh! This new failing test is actually interesting. Some thinking required around how you want that to behave!

Exactly...
I want to live in a world where we actually verify things at IO boundaries (at runtime), and don't just "assert" that stuff is a type at compile time. I think it's one of the most broken things about other peoples perception of typescript.
But, that's not the world we live in. So we need to allow "bad typescript habits".
In this case, if there's no verifier - we should without verificiation return what's stored in localstore.

So just to be clear:

This is the behavior I'm suggesting.

So, I was actually just being dumb, in my brain !verifier || verifier(val) is what I meant to write. And then I misread the fail. Apologies! :D

Honestly, even if the API enforced passing in a verifier, people like me will still just pass in some dumb always true crap. 😁

Yes, I agree, all things considered this is 100% the way to go!

So, what's the politics here? Am I to push the button myself? :D

wooohoo! this is unprecedented (for klyva)! first PR by another soul

🎉


Clean up the Message table pub_date column name

It'd be great to rename Message.pub_date (which is kinda confusing) to something standard like Message.timestamp.  Fortunately, we already use the name timestamp for this field in the API, so this should be a pretty low-risk change to make, with the main benefit being better readability.

Added a priority tag and updated the description, since I think this is something that'll be more pleasant the sooner we do it.

@zulipbot claim

From what I've seen in the code, there are methods (zerver/lib/timestamp.py) datetime_to_timestamp, which often takes msg.pub_date as an argument, and timestamp_to_datetime, which sometimes is used to set msg.pub_date. Should I rename pub_date to timestamp nonetheless?

From what I've seen there are methods: datetime_to_timestamp converting pub_date to timestamp and timestamp_to_datetime converting timestamp to pub_date, so I wanted to make sure that you want renaming to timestamp or some other name.

I'll do PR in a few days

@zulipbot claim


Don't use chown on /srv/jekyll

Changing ownership permissions affects ownership of the files on the host system. As per the running guide, the line chown jekyll:jekyll /srv/jekyll && \ sets the ownership of whatever directory I mounted to a user of UID 1000.
If it is absolutely required to own this directory, maybe consider not using a user account within the container at all.

Our running guide mentions nothing about chown and it never will.  This image is designed for the average user who wants things working in an orderly fashion and we try our best to guarantee that.  To do what you wish without any valid reason will only sacrifice what others needed and wanted so this is a WONTFIX unless you can come up with a very very good and valid reason as to why it should change.

I wasn't clear, apologies. The container itself, runs that command.
The running guide suggests you do the following to get a running Jekyll container within your current directory:
docker run --rm --label=jekyll --volume=$(pwd):/srv/jekyll \
  -t -p <IP_ADDRESS>:4000:4000 jekyll/jekyll jekyll s

Doing this on any standard system will change the permissions of my entire working directory, on my host system to be owned by the user at 1000. I do not like this, and I don't think it should be regular behaviour. The container should not need to change permission of, or mess with my local files, in order to serve a simple Jekyll instance container with the built version of my site.

Yeah I think we shouldn't need to chown if we can match the host uid to the docker uid

To put it flatly: not easily.  Unless somebody is willing to submit a patch upstream to envygeeks/alpine and envygeeks/ubuntu through envygeeks/docker vendor/common to create a helper (with tests, it needs tests) this will not happen.  Our images do work in line with standard Docker behavior, we run as an unprivileged user, we need to chown and own the folder to bundle install if you ask us to, and even if we don't, your _site folder will be owned by 1000/1000 or 0/0.
Technically we can track the UID/GID and modify the system UID and GID on the fly (that is if Docker even passes it via the mounted volume): https://github.com/envygeeks/docker/blob/master/vendor/common/usr/local/share/docker/helpers#L182 and that is upstream, but we need a helper to parse and pull the UID and GID of the users and it's not work I'm willing to do because we currently fall in line with Docker's native environment (Linux) and use standard user 1000/1000.  We will never run Jekyll as root, even in a container.

The chown-ing in question is at the bottom of this file: https://github.com/jekyll/docker/blob/master/Dockerfile
Is there a workaround for now to chown the /srv/Jekyll or to leave the host files untouched?

The chown in question is here: https://github.com/jekyll/docker/blob/master/copy/etc/startup1.d/01-srv-jekyll-permissions that said, you have two options (both of which I make extra easy for any user who needs to customize our image) delete copy/etc/startup1.d/01-srv-jekyll-permissions and script/build jekyll:whatever-tag-you-use or... modify the Dockerfile and change the UID and GID script/build jekyll:whatever-tag-you-use...
In the end, I'm opting to enforce a conformity to ensure workability than to let things go and then deal with a ton of tickets that ask why this isn't working and that isn't working and why this doesn't behave right and why that doesn't behave right.
I'm not against trying to ensure that the UID can remain the same, I am just not willing to put in the work for it (and it needs to be done upstream where the helpers are) because I already have enough on my backlog and since there are plenty of ways to work around it in the meantime it's a super-low priority thing without help.

Hulk: +split-backlog/jekyll:backlog/docker +envygeeks/docker#1 : This ticket is being split
This ticket is being split into two pieces, one where we only modify our necessary files and folders (_site and vendor/bundle) and the aforementioned ticket where we grab the UID/GID of the user to modify our runtime UID/GID so that when we chown you get consistency.  The former is a jekyll/docker issue the latter is an upstream issue.


showCellStatusBar false still shows status bar

Testing #125013
If the status bar contains the green check and run spinner, toggling show cell status bar is not removing that.

This is because you also have the "afterExecute" setting enabled, which does this by design.


Creation of a Custom Field brocken on 9.1.0

When i create a custom type, following the documentation, ( I use webpack and Field.js that I extend )
I get this error : this._fieldTypes[t] is not a constructor,
After inverstigating : http://stackoverflow.com/questions/10107198/javascript-not-a-constructor-exception-while-creating-objects
The fact is  : fieldTypes[t] corresponding to my freshly defined object, but it's an object , and not a function : throwing that error when trying to use the new operator on it
And when I log this, i see function for every ng-admin native type, but a javascript objet for the one i defined
Any solutions for that Folks ?
Thanks in advance, and have a nice shiny day !
PS : i also post an issue on stackoverlow : http://stackoverflow.com/questions/36451969/ng-admin-custom-type-the-field-class-is-injected-as-an-object-not-a-function

The issus lies in the fact, that require('CustomField') in the registration return an object, not a function, The sollution is to use import wich return a function ( Not the instanciated object ).


Document which default locales are available

The documentation page on locales doesn't inform that there are already some default locales available for some languages. Should this information be added? Should I just edit the documentation wiki?

Feel free to edit the wiki. For 4.0, I link to the locales from the documentation (see d3-format and d3-time-format), and I also make the locales available in the default build using a locale code.


Update README.md

Codecov Report

Merging #112 (231a6c3) into master (76e09d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   95.80%   95.80%
=======================================
  Files           8        8
  Lines         548      548
=======================================
  Hits          525      525
  Misses         23       23

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Modal popup not showing in first click in razor page

Please help me  , when page is loading i can see the all list  items. But i am clicking  the more button on the first time or any the popup is not showing in  the first time.  Again will click it is working. it is  need a double click.
<button @onclick="(e=> SelectProduct(product.Id))" data-toggle="modal" data-target="#productModal"
class="btn btn-primary">
@if (selectedProduct != null)
{

This issue was moved to aspnet/AspNetCore#17202


Update folder path

Latest download of this mod changed the ordering of the words in the directory name.

Tests fine locally. Merging with thanks!


fix(MiniKebabIcon): remove cruft

Overview
Removes some cruft to fix the MiniKebabIcon that was causing some weird behavior.

PR Checklist

[x] Related to designs: sandbox designs
[x] Related to JIRA ticket: EGG-1258
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-icons@5.5.1-alpha.f14c3b.0@codecademy/gamut-kit@0.4.60-alpha.f14c3b.0@codecademy/gamut-labs@19.15.3-alpha.f14c3b.0@codecademy/gamut@34.13.2-alpha.f14c3b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60ddf2cc80187e0aee5b6290--gamut-preview.netlify.appDeploy Logs


added strictQueryParams() pre-hook

We were working with Restify in a large-scale API REST server, while using GET method endpoints to enable receiving query parameters components in http queries, we have detected an annoying issue while parsing query params containing values with ampersand:

When restify fills req.params a parameter with ampersand, it is splitted into two subsections, i.e.: ?key=value&value2 is resulting in an object: {key:value, value2:''}
We though that this kind of "transformation" should not happen, instead it should reject the query with bad request http error
In order to prevent issues with parsing ampersand inside URI components, we have developed a plugin-fix that rejects malformed requests with status code 400, according to HTTP/1.1 protocol #5.1.2 Request-URI.

We expect that it be useful.

Thank you for the PR! Love that the tests are included, that is hugely appreciated! :+1:
While according to the RFC ?key=value&value2 is technically a valid URL, I think this can be useful in certain scenarios. Given that the format is valid, I might suggest renaming this to strictKeyValQueryParams() or something that else that conveys the same idea.

Is a good idea rename it, I think that is more representative. You are right, this is valid url, but if your scenario needs a strict behaviour like our project, with dinamyc routes modification etc. This pre-hook is very usefull. Thanks for your review and comments.

PR updated with your suggestions 👍

Thank you! I left one last comment - sorry I didn't catch it earlier. Apologies for the churn. Really appreciate the help!

@jscMR Thanks for the contribution!


[Display a Visible Switch Between tabs]: Fixes #239 added switch Tabs

As a user I want to see the Expired tab and Completed tab, and be able to switch between them.

Already implemented.


Detailed status window information not updated

CRC version
1.22.0
Description
When starting the cluster from the tray the status detailed window information is never updated. It always shows empty values:

This looks like a side effect of uncaught exception, when the error mentioned in #19 happens, the execution doesn't continue and hence when we click on the Status the status is not updated. however if the tray is restarted after the error in #19 occurs the status window gets populated with all the information.


docs: link to dotnet cli fsharp templates

Added link to dotnet cli templates for F#.

Thank you
Am 09.02.2018 23:39 schrieb "Patrick Drechsler"<EMAIL_ADDRESS>
Added link to dotnet cli templates for F#.
You can view, comment on, or merge this pull request online at:
https://github.com/fsprojects/Paket/pull/3034
Commit Summary

docs: link to dotnet cli fsharp templates

File Changes

M docs/content/paket-and-dotnet-cli.md
https://github.com/fsprojects/Paket/pull/3034/files#diff-0 (2)

Patch Links:

https://github.com/fsprojects/Paket/pull/3034.patch
https://github.com/fsprojects/Paket/pull/3034.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3034, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNClBnb7qQI3chpJimHU_1QL7NU6tks5tTMkogaJpZM4SAoRg
.


Add Threat Stack to adopters list

Codecov Report

Merging #627 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   83.48%   83.53%   +0.04%
==========================================
  Files          70       70
  Lines        2071     2071
  Branches      150      149       -1
==========================================
+ Hits         1729     1730       +1
+ Misses        342      341       -1

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
45.94% <0%> (+2.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1440fda...2002334. Read the comment docs.

Thanks @rpless!


Add tests for federated query against public curie endpoint

@cthoyt this PR adds tests for federated queries from various triplestores to a public instance of the curies mapping service (SPARQL endpoint)
The tests are trying to run a federated query to http://bioregistry.io/sparql for popular public triplestores
When the tests fail they show the error message sent by the triplestore to help debugging
They are currently failing, so you might want to wait to fix the endpoint before merging this
Some notes about blazegraph:
def _start_blazegraph(path):
    import subprocess

    proc_blazegraph = Process(
        target=subprocess.run,
        args=([f"java -jar {path}"]),
        kwargs={
            "shell": True,
        },
        daemon=True,
    )
    proc_blazegraph.start()
    time.sleep(1)
    return proc_blazegraph

    # TODO: blazegraph not actually killed, it will continue to run afterward
    # Not sure how to make sure a java subprocess running as daemon is killed
    # self.proc_blazegraph.kill()

    # manual instructions for cancelling process:
    # 1. shell: ps aux | grep blaze
    # 2. find the number of the process
    # 3. shell: kill #

Codecov Report

Merging #49 (b8874c7) into main (da58e65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          479       479
  Branches       103       103
=========================================
  Hits           479       479

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vemonet I've now simplified this down to run only if there's already a local blazegraph available - this takes the burden of writing code to run blazegraph out of the code itself (for now)


update docstrings to be compatible with dash#1531

This pull request is for updating the docstring comments so they will be compatible with the new style docstrings in dash #1531
This project started with   https://github.com/plotly/dash/issues/1205
You can see results for other libraries in dash-doc #https://github.com/plotly/dash-docs/pull/1063
This repo will need to be rebuilt with a more recent version of docgen than the one currently specified (2.21.0).  I rebuilt the library with docgen 5.3.0, react 16.13.1 and react-dom 16.13.1.  I see that  https://github.com/plotly/dash-cytoscape/pull/81 is still open, so I don't know if these version changes will cause any problems.   The rebuilt library passed all tests.
Here are some before and after screenshots for dash-cytoscape in dash-docs and in the python console.
Before:

After

In the console: Before:

In the console: After:

@AnnMarieW Thank you for opening the PR, the updated docstring looks much better! And thank you for the thorough and well-written PR description.
@alexcjohnson @Marc-Andre-Rivet I noticed that the dash version in requirements.txt is fairly outdated; do you think this could affect the build process wrt the react and react-dom version?

@AnnMarieW Thank you for opening the PR, the updated docstring looks much better! And thank you for the thorough and well-written PR description.
@alexcjohnson @Marc-Andre-Rivet I noticed that the dash version in requirements.txt is fairly outdated; do you think this could affect the build process wrt the react and react-dom version?

@xhlulu I'm glad you like it!  I forgot to mention that I also used the latest version of dash to rebuild and run the tests.  The main issue I ran into was that docgen 2.21.0 didn't recognized PropTypes.exact so it needed to be upgraded.  I just bumped it to a version being used in dash-table

@xhlulu I'm glad you like it!  I forgot to mention that I also used the latest version of dash to rebuild and run the tests.  The main issue I ran into was that docgen 2.21.0 didn't recognized PropTypes.exact so it needed to be upgraded.  I just bumped it to a version being used in dash-table

hah yes, 0.39 is stretching the definition of "fairly" outdated at this point. But what is requirements.txt even used for? setup.py only lists dash (and with no version). There's also tests/requirements.txt listing an extremely old dash (but with >= so it should be getting the latest) as well as pytest-dash - would be great at some point to transition this to dash[testing] but that will require rewriting some of the tests themselves.

hah yes, 0.39 is stretching the definition of "fairly" outdated at this point. But what is requirements.txt even used for? setup.py only lists dash (and with no version). There's also tests/requirements.txt listing an extremely old dash (but with >= so it should be getting the latest) as well as pytest-dash - would be great at some point to transition this to dash[testing] but that will require rewriting some of the tests themselves.

@alexcjohnson Thanks for mentioning this. requirements.txt would ideally be the requirements needed to run the demos locally and developing the libraries. Perhaps it's time to delete test/requirements.txt and move everything to requirements.txt, so we won't have to track/manage two requirements files?
I've also created a project to track everything relating to tests, as well as opened an issue to track the refactoring of tests.

@alexcjohnson Thanks for mentioning this. requirements.txt would ideally be the requirements needed to run the demos locally and developing the libraries. Perhaps it's time to delete test/requirements.txt and move everything to requirements.txt, so we won't have to track/manage two requirements files?
I've also created a project to track everything relating to tests, as well as opened an issue to track the refactoring of tests.

This looks great to me. @AnnMarieW let's get https://github.com/plotly/dash-docs/pull/1063 merged (WITHOUT any updates to the component packages) before we merge any of the updates to the component packages themselves.

This looks great to me. @AnnMarieW let's get https://github.com/plotly/dash-docs/pull/1063 merged (WITHOUT any updates to the component packages) before we merge any of the updates to the component packages themselves.

Sounds good.  And  https://github.com/plotly/dash/pull/1531 will also need to be merged before updating the component packages?

Sounds good.  And  https://github.com/plotly/dash/pull/1531 will also need to be merged before updating the component packages?

@xhlulu Thanks for the suggested changes.  I approved the changes from exact to shape and will leave the rest open for you or the other reviewers.

@AnnMarieW Thank you!
@alexcjohnson I'm happy to merge it as is and I can figure out the right package.json dependencies and building in another PR


add a docker-compose file

with docker-compose starting the container can be simplified to a simple docker-compose up -d
we could also add mount points for apk and the password files by default

Thanks

yay


OSX Yosemite: "Open folder" opens workspace tree before dialog instead of after dialog

Have a workspace open in LightTable that is a single directory
Quit LightTable
Open LightTable again from the Applications folder - you will see the Welcome screen
command-w to close the welcome screen, LightTable is now totally empty
Go to File > Open folder

When I do this, it auto-opens my last folder I had into my current workspace, for no apparent reason, I have not selected a folder in Finder yet, nor have I clicked "Upload"
It should either auto-open my last workspace/folder right when I launch the application, or it should not auto-open anything, especially after it has been sitting there empty for a while.
Nothing should open in LightTable when I am in the Open folder Finder menu, that should only happen after I make a selection and click Upload.

Thanks for the reproducible steps. This boils down to if we prefer opening the workspace tree before or after selecting a folder. I don't have a strong opinion. @LightTable/committers Thoughts on if this behavior should be changed?

Closing as this has been open awhile, no other users have reported this preference and would require a nontrivial amount of shuffling code around


Is the zabbix plugin supposed to work for Grafana instances that are behind SSO/SAML?

We're getting the familiar error that others have run into:
Zabbix plugin error:
Error: fetch error:  404 Not Found Instantiating
I used the grafana-cli to install the plugin.  We're running grafana 6.5.2 in prod.
The relevant section of the ini file is:
[auth.generic_oauth]
enabled = true
We're using our own internal Okta instance for this purpose.  Is this supposed to work?

Hi! auth.generic_oauth is OAuth, not a SAML. I can't realize, are you trying to install plugin and get an error?

@zacharystokes , is there any update coming on zabbix SAML Auth Integration with Grafana? Thanks.


Develop

Hello @gwenchee! Thanks for submitting the PR.

In the file d3ploy/solver.py, following                are the PEP8 issues :

Line 105:31: W291 trailing whitespace

In the file tests/performance_tests/algorithm_performance_tests.py, following                are the PEP8 issues :

Line 2:70: W291 trailing whitespace
Line 4:12: W291 trailing whitespace
Line 7:58: W291 trailing whitespace
Line 8:80: E501 line too long (93 > 79 characters)
Line 8:94: W291 trailing whitespace
Line 9:65: W291 trailing whitespace
Line 41:1: E266 too many leading '#' for block comment
Line 46:1: E265 block comment should start with '# '
Line 46:80: E501 line too long (96 > 79 characters)
Line 63:80: E501 line too long (83 > 79 characters)
Line 68:80: E501 line too long (98 > 79 characters)
Line 73:80: E501 line too long (92 > 79 characters)
Line 125:80: E501 line too long (87 > 79 characters)
Line 135:80: E501 line too long (104 > 79 characters)
Line 138:80: E501 line too long (83 > 79 characters)
Line 139:1: W293 blank line contains whitespace
Line 140:80: E501 line too long (89 > 79 characters)
Line 141:80: E501 line too long (92 > 79 characters)
Line 142:80: E501 line too long (101 > 79 characters)
Line 147:80: E501 line too long (90 > 79 characters)
Line 149:1: E265 block comment should start with '# '
Line 149:80: E501 line too long (90 > 79 characters)
Line 166:80: E501 line too long (83 > 79 characters)
Line 171:80: E501 line too long (98 > 79 characters)
Line 176:80: E501 line too long (92 > 79 characters)
Line 213:80: E501 line too long (95 > 79 characters)
Line 243:80: E501 line too long (104 > 79 characters)
Line 246:80: E501 line too long (111 > 79 characters)
Line 248:80: E501 line too long (102 > 79 characters)
Line 250:80: E501 line too long (84 > 79 characters)
Line 251:32: E225 missing whitespace around operator
Line 251:47: E225 missing whitespace around operator
Line 253:80: E501 line too long (88 > 79 characters)
Line 255:80: E501 line too long (95 > 79 characters)
Line 256:80: E501 line too long (98 > 79 characters)
Line 257:80: E501 line too long (82 > 79 characters)
Line 264:80: E501 line too long (81 > 79 characters)
Line 266:1: W293 blank line contains whitespace
Line 271:1: E265 block comment should start with '# '
Line 271:80: E501 line too long (90 > 79 characters)
Line 288:80: E501 line too long (83 > 79 characters)
Line 293:80: E501 line too long (98 > 79 characters)
Line 298:80: E501 line too long (92 > 79 characters)
Line 335:80: E501 line too long (95 > 79 characters)
Line 352:1: E303 too many blank lines (3)
Line 358:1: E303 too many blank lines (3)
Line 367:80: E501 line too long (104 > 79 characters)
Line 369:80: E501 line too long (111 > 79 characters)
Line 371:80: E501 line too long (102 > 79 characters)
Line 373:80: E501 line too long (84 > 79 characters)
Line 374:32: E225 missing whitespace around operator
Line 374:47: E225 missing whitespace around operator
Line 376:80: E501 line too long (88 > 79 characters)
Line 378:80: E501 line too long (95 > 79 characters)
Line 379:80: E501 line too long (98 > 79 characters)
Line 380:80: E501 line too long (82 > 79 characters)
Line 387:80: E501 line too long (81 > 79 characters)
Line 389:1: W293 blank line contains whitespace
Line 393:1: E265 block comment should start with '# '
Line 393:80: E501 line too long (90 > 79 characters)
Line 410:80: E501 line too long (83 > 79 characters)
Line 415:80: E501 line too long (98 > 79 characters)
Line 420:80: E501 line too long (92 > 79 characters)
Line 457:80: E501 line too long (95 > 79 characters)
Line 487:80: E501 line too long (104 > 79 characters)
Line 489:80: E501 line too long (111 > 79 characters)
Line 491:80: E501 line too long (102 > 79 characters)
Line 493:80: E501 line too long (84 > 79 characters)
Line 494:32: E225 missing whitespace around operator
Line 496:80: E501 line too long (88 > 79 characters)
Line 498:80: E501 line too long (95 > 79 characters)
Line 499:80: E501 line too long (98 > 79 characters)
Line 500:80: E501 line too long (82 > 79 characters)
Line 507:80: E501 line too long (81 > 79 characters)
Line 509:1: W293 blank line contains whitespace

In the file tests/unit_tests/deploy_solver_unit_tests.py, following                are the PEP8 issues :

Line 25:1: W293 blank line contains whitespace
Line 28:80: E501 line too long (108 > 79 characters)
Line 32:1: E302 expected 2 blank lines, found 1
Line 44:63: E231 missing whitespace after ':'
Line 61:48: W291 trailing whitespace
Line 76:45: E127 continuation line over-indented for visual indent
Line 77:45: E127 continuation line over-indented for visual indent
Line 78:45: E127 continuation line over-indented for visual indent
Line 79:45: E127 continuation line over-indented for visual indent


installcredprovider.ps1 -force doesn't actually overwrite previous contents

== Repro ==

Have an older version of the cred provider installed (e.g. <IP_ADDRESS>)
Run installCredProvider.ps1 -AddNetFx -Force
Check the installed version (e.g. via (get-item -Path "$Env:userprofile\.nuget\plugins\netfx\CredentialProvider.Microsoft\CredentialProvi der.Microsoft.exe").VersionInfo | Format-List -Force

The version will still be the old version instead of whatever the current version is (currently <IP_ADDRESS>)

The problem seems to be that this line doesn't actually replace the contents of a directory if it already exists.
Copy-Item <source> -Destination <dest> -Force -Recurse
This does, but doesn't create the destination dir if it's not already there.
Copy-Item <source>\* -Destination <dest> -Force -Recurse
I'm not a PowerShell guru, but possibly the best fix is to just Remove-Item the destination directory before copying to it.

Thanks for filing!


[Improvement-3558][API] Improve DataSourceServiceTest.java

Improvement DataSourceServiceTest #3558
Get rid of some useless arguments to functions in the DataSourceService class.

Hi~
Please add this test to root pom.


tower function

Can the tower be edited at some point?

you can get tower editor right now if you support cutflame or wait for a few months and it should come out.


Editing a Community, Collection or Item doesn't handle errors properly

Found while testing #653
How to reproduce:

Login as a non-Admin user, or "impersonate" a non-Admin user using #653
Edit a Community, Collection or Item (it doesn't matter which).  (Currently, as #664 doesn't yet exist, it's possible to access these pages as any user.)
Make an edit and save.  This will result in a PATCH request to that object.
The server (REST API) will respond with a 403 (forbidden).  However, the UI will show a green/successful message and save your changes into the Angular cache.  It will appear to the user that the changes were saved, even though the backend responded with an error.
Once the object reloads (e.g. if you refresh the page in your browser), the changes will disappear again, as they were never saved on the backend.

Expected behavior is that the UI should show an error message when a 403 is returned. The message should say something like "You do not have privileges to make this change" (as that's what a 403 means).  Other error responses should display appropriate messages as well per the description in the REST Contract: https://github.com/DSpace/Rest7Contract#error-codes

Closing as fixed by #701


Getters getters getters get your getters here!

This has been pulled via https://github.com/SpongePowered/SpongeAPI/commit/bcc994fd84049ff7630d9f241bedefa2d7ba815e