be open-minded about byte and dict headers

This is as discussed in https://github.com/webrecorder/warcio/issues/16
I kind of punted on converting bytes/str/whatever for Python 2 because I don't really understand it. It still does dict -> list for python2.
If the user happens to have multidict installed (part of aiohttp), then the multidict tests will run. This is optional because warcio strives to avoid external dependencies. If there's a more-correct way to get that into the CI, I'd love to know it.

Coverage decreased (-0.1%) to 99.903% when pulling<PHONE_NUMBER>6a10b71b7fa9ead5aec121fb3f04e0 on cocrawler:header-frobbing2 into 173aa90c35e599e8391248d86ee51c0e308ddfae on webrecorder:develop.

I don't understand the coveralls fail.

Coverage remained the same at 100.0% when pulling f8ccd148856eacc19f9f2bec3e88ea2bad68734c on cocrawler:header-frobbing2 into 173aa90c35e599e8391248d86ee51c0e308ddfae on webrecorder:develop.

Coverage remained the same at 100.0% when pulling ff079b2be1f11074ae319ada6fcf8378541499f3 on cocrawler:header-frobbing2 into 173aa90c35e599e8391248d86ee51c0e308ddfae on webrecorder:develop.

Oy. Hit the "squash merge" button :-)

Coverage remained the same at 100.0% when pulling 72ef825434aa4535c0ff1be676fdb9cca0990222 on cocrawler:header-frobbing2 into 173aa90c35e599e8391248d86ee51c0e308ddfae on webrecorder:develop.

Thanks for this, and sorry for the delay.
I wonder if its worth optimizing for headers already being in str format:
if h and type(h[0]) == str and type(h[1]) == str:
   return h

I suppose its unlikely that there'd be a mix of str and byte headers, but not sure if this would really make any difference


nmp run render not draw in sketch

I am beginner and i have a problem :)
I do all by instruction and then run example projects it open sketch, but nothing to draw.
Can anyone help me?
Sketch 43.2
npm -v 3.10.10
node v6.9.5

I'm having the same issue
Sketch 43.2
npm 4.1.2
node 7.7.1

Seems like you just forgot this step Open a new Sketch file

OMG, its working :)
I did close all tabs in Sketch, and restart it, and it's working. Thanks!

Not for me. The new file is open and just in case I tried to restart Sketch, but still nothing. I've managed to link it as a plugin though, but not through npm run render

@raulalgo can you provide console output ?

Same here: Document gets focused, nothing happens. Plugin works fine!

`><EMAIL_ADDRESS>render /Users/ralvarezgo/Documents/personal/2017 04 26 react-sketch/react-sketchapp/examples/basic-setup

skpm build --watch --run

🖨  Copied src/manifest.json in 8ms
Executing post-build scripts
⛏  Built ./my-command.js in 1722ms
(null)`
Same as @ChristophLabacher. The window gets focused but nothing happens.

I think I found something. Is it possible that a space character in one of the parent folder names of the project causes it to fail? Copied everything to a different path and now it works!

Exactly! Now it works!
Thanks everyone!

Is it possible that a space character in one of the parent folder names of the project causes it to fail?

Yes it did. I fixed it in<EMAIL_ADDRESS>(just released)

Looks like everyone got it sorted, sorry for the hiccups. We should figure a way of opening Sketch to a blank document if it's not open yet.

@mathieudutour I still get the same behavior, with<EMAIL_ADDRESS>installed and a new Sketch file open, when there is a space character in a parent folder name. Focus goes to the Sketch window, but nothing is drawn.
➔ npm run render

> colors@ render /Users/Mike/Dropbox/Documents/Work/2017/2017-04/20170427-Yavorsky-Try-React Experiments/react-sketchapp/examples/colors
> skpm build --watch --run

🖨  Copied src/manifest.json in 16ms
Executing post-build scripts
⚒  Built main.js in 4160ms
(null)

Mine is showing as follows, anyone knows why :O?

Hey! What folder are you running it from? The main directory or one of the
examples folders?

@jongold The react-skethapp folder is under my username directory. I try again, and the error becomes below: Still try to figure out :'(

@daouchovny this is a bug with Sketch 44 that we're working on fixing :( https://github.com/airbnb/react-sketchapp/issues/72

@jongold Awesome! Thank you so much! (Yes my Sketch version is 44.1.)


[Configuration] Update the configs for downloading specific resources from Composition Resource

Name of feature to enhance
Update the local configs for downloading the configs for downloading specific resources from Composition Resource
Linked Issue: https://github.com/opensrp/fhircore/issues/1790
Implementation

[ ] Update configuration codebase to all download configuration & content resources when using the app/debug application ID

Can you explain this issue in more detail, it's not clear to me what the task is here

@qaziabubakar-vd is this the ticket where we sync Questionnaires in the Composition resource when in debug mode?

I think this functionality disappeared in the last few refactors

@FikriMilano Yes, I tested this on staging server on "demo" app, was working fine their.
I will check again

@pld I'll update the ticket and add more details.

Can you explain this issue in more detail, it's not clear to me what the task is here

@pld this issue is to make sure the local test app id also uses the composition locally provide composition resource to download the required content.


Use | , & instead of , and ; with frontend.rule

traefik version : 1.1.1
we use traefik with consul catalog as its backend. Registrator popluates data to the consul catalog. Tags are use for configuring front end rules for a service to be picked and configured by traefik. Consul allows storing multiple tags irrespective of the purpose for which they are used, we do use tags for tagging the service with specific metadata, traefik front end rules being one of them. Each of these tags are required to be separated by ',' which in turn get picked as separate tag entries on the catalog for the service.
With traefik having ',' as a separator for || conditions, results in the rules that acutally intened to be part of an or condition, get added a separate tag entires.
eg> traefik.frontend.rule=Host:myservice.domain.com,myservicetwo.domain.com
should result in rules that perform an || condition on the presence of either of the two as Host header values.
since the ',' character is being seen as a separator charter to separate multiple tags, the rules get put in as separate tags rather than a single rule.
consul catalog
myservice {          "traefik.frontend.rule=Host:myservice.domain.com",          "myservicetwo.domain.com" }
instead of
myservice {          "traefik.frontend.rule=Host:myservice.domain.com,myservicetwo.domain.com" }
it would be better if || is used instead of , and && instead of ;

@emilevauge based on your comments on the pull request #1860 we are looking to make the changes to rules.go to add the filtering for || and &&.

Is there any plan to fix this? I find useless the Consul Catalog integration without this feature. I really need to define several traefik.frontend.rulebut the registrator is splitting the tags by the ',' character.

Since the release of Traefik v2, rules now use || and && to build rule chains:
https://docs.traefik.io/v2.0/routing/routers/#rule
For this reason, I will close this issue.


#572: add option to suppress generated source line comments

Hi I implemented the feature.
Since for verilog the functionality was already there,
I did a regex replace on the other two.

Using a regex for this purpose is completely unacceptable.

Using a regex for this purpose is completely unacceptable.

@whitequark  can you give me a clue to where the right place would be for IL? I looked into it, but the src comments are all over the  place in the code.

@whitequark  can you give me a clue to where the right place would be for IL? I looked into it, but the src comments are all over the  place in the code.

I don't think this is necessary to do for the IL at all.

I don't think this is necessary to do for the IL at all.

I got it: in _ModuleBuilder.enter. I would like to actually read and understand the IL too betimes, and also there the source line comments really get in the way of readability

I got it: in _ModuleBuilder.enter. I would like to actually read and understand the IL too betimes, and also there the source line comments really get in the way of readability

In that case you can use Yosys to remove the comments like it is done in back.verilog.

In that case you can use Yosys to remove the comments like it is done in back.verilog.

You mean, run yosys to filter in rtlil.py:convert or external to nmigenl?

You mean, run yosys to filter in rtlil.py:convert or external to nmigenl?


Fix broken module_names in compile_dir for sub-directories

Assume we have a directory structure like this:
test
  nested_test_1
    nested_test_2

Expected module names are:
nested_test_1
nested_test-1.nested_test-2

However in the actual result was:
nested_test_1
nested_test-1nested_test-2

the '.' separator missing

oh, wow. unexpected. how can I test its wrong behavior? I added a test but the test also success for main branch. I want to add a related test for this fix.

https://github.com/xforce/rust-python-repo/blob/incorrect-module-name/src/main.rs
that code will print
Traceback (most recent call last):
  File "<embedded>", line 1, in <module>
ModuleNotFoundError: No module named 'nested1.nested2'

if you change the from nested1.nested2 to from nested1nested2 it works without error.
this is what this PR fixes.

I am at this time unfortunately not familiar enough with this codebase to provide a better test as I haven't fully explored if that particular code path is even involved in the setup that's used for tests

@xforce Thank you! I added a new test based on your example


ceph/rbd: rbdStatus only check output of successful rbd status run

What this PR does / why we need it:
Sync modifications from https://github.com/kubernetes/kubernetes/pull/54454.
cc @wongma7 @rootfs

/lgtm


Byzantine fault behaviour tests 1 #876

Issue Link:

@zyfrank Can you increase the go timeout here? https://github.com/centrifuge/go-centrifuge/blob/0a28657575b925d343b08afae1b0391e91a4bf96/build/scripts/tests/run_testworld.sh#L11
So travis is happy again.


Bundle in subfolder

Hi!
I have separate dirs in my project. For api and frontend. So gemfile is located in subdirectory. Is there way to specify this subfolder to rip tags?

Hm, good question. I'm a bit rusty on bustagem so I had to go back and read the source myself. I don't think this will be particularly easy. Probably the easiest way is to open each folder individually in vscode and do the ripping.
You can also just rebuild from the command line: ripper-tags .... A script would help. Lately I've been wondering if I should rip the tags stuff out of bustagem entirely. I mostly use it for opening gems since the vscode ruby extension is such a mess.
Closing for now. Let me know if you disagree. Thanks @mewcrow!


change deprecated decorator

@abstractclassmethod is deprecated since python3.3.
https://docs.python.org/3.8/library/abc.html#abc.abstractclassmethod

Thanks~


setup kfctl nightly builds

It would be great if we could setup nightly builds for kfctl. It would go well along with the E2E tests and help in development.
/cc @kkasravi @jlewi @yanniszark

@swiftdiaries I've moved the issue into the kubeflow/kfctl repo. Could you provide an update the current status? Do we have a PR? If so what work remains after that PR? What's blocking that PR if anything?

Sorry for the delay. Opened to PR to close this issue. I'll work through the PR and have it done ASAP

After this PR, we need a nightly periodic prow job defined for this repo so that we have nightly builds associated with that run

@swiftdiaries any update on this?

I had a small question on this, have we moved the ProwJobs to oss-test-infra? Or would it be ok if we push changes to the ProwJobs to k8s/test-infra?


[Feature] Save registration output to be compatible with other brainglobe tools.

Hi! Great package so far - manual registration of single brain slice seems to work very well. Are there plans for making the outputs compatible with other brainglobe tools? In particular, I would love to use brainglobe-segmentation.
As far as I can tell, nothing gets saved by default post-registration now and saving the images from Napari doesn't match the brainreg format. Does someone by any chance already have a quick-and-dirty solution to matching the formats?
Thanks!

Hi @StoyoKaramihalev,
That is definately the plan. The aim is that brainglobe-registration will be compatible with all the other tools in the ecosystem. However, it's still early days, so most of the features haven't been implemented yet. https://github.com/brainglobe/brainglobe-registration/issues/12 gives a bit of an idea of where we're heading.
Unfortunately there's no quick-and-dirty solution to get this working with brainglobe-segmentation. We will be creating a new common output format for brainreg, brainglobe-registration and brainglobe-segmentation, so it's not as simple as just converting things into the brainreg format.


SILGen: Purge misuses of pre-exploded RValue constructor.

The RValue(ArrayRef<ManagedValue>, CanType) constructor was intended as a semi-private interface for building an RValue from a pre-exploded array of elements, but was (understandably) widely being misused as a general ManagedValue-to-RValue constructor, causing crashes when working with tuples in various contexts where RValue's methods expected them to be exploded. Make the constructor private and update most improper uses of it to use the exploding RValue constructor, or to use a new RValue::withPreExplodedElements static method that more explicitly communicates the intent of the constructor. Fixes rdar://problem/29500731.

@swift-ci Please smoke test


pre-cal stat

Hi, may I ask what the pre-calculated statistics do? thanks.

Hi, the pre-calculated statistics are used for FID calculation, which contains the statistical information of the real image dataset.
For more information you can refer to https://github.com/bioinf-jku/TTUR.


Add opt-out settings for email notifications

Following bihealth/sodar-core#1417, we should also add similar opt-out settings for landing zone and samplesheet activities.
Tasks

[x] Add opt-out for iRODS data request accept/reject
[x] Add opt-out for landing zone owner status updates
[x] Update tests (see also #1916)
[x] Update user profile and major changes docs

Done.


Adding Role Mangement, Adding Creating and Delete support of projects

Adding three levels of roles - Admin, Annotator, Manager
Admin and Manager can create and delete projects
projects/list will show projects only concerning the current logged in user
Cleaned up code a bit.

LGTM


chore(release): 2.23.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 0a09eb7c11d6b5a3e2768c33ead6e5c66063b99e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 0cbf84deec10f7c18f766c604ddaaf8357968954
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Mobile - Update some logic related to token balance

Describe the task

[x] Fix bug related feature for TAO

Related: https://github.com/Koniverse/SubWallet-Extension/issues/3809, https://github.com/Koniverse/SubWallet-Extension/issues/3788

[x] Re-check and update foregin asset for Asset Hub (Relate: https://github.com/Koniverse/SubWallet-Extension/issues/3852)
[x] Fix bug when transfering local token on Bifrost network (https://github.com/Koniverse/SubWallet-Extension/issues/3896)
[x] Update chainlist: discuss more

Version test:
Device test: IP 13, Black shark 4
Validation passed.

Re-check and update foregin asset for Asset Hub
Fix bug when transfering local token on Bifrost network
Fix bug related feature for TAO


Release 0.5

0.5 doesn't need the CrateDB jdbc driver anymore, but uses the vanilla PostgreSQL one instead.

closing this, the vanilla postgresql attempt didn't work out


Debianized version of this guide

Hi, this wiki is just the sort of thing I've been search for a long time. Thank you, I love it!
The OSVDC seems pretty tied to CentOS and FreeNAS.  As I normally run Debian, I wonder if there's a version of the wiki, or any plans to add to add instructions, so that virtualization with the oVirt Virt. Appliance is shown to be feasble?
What do you think of this idea?  Thanks!

A fascinating idea!
You are correct much of the series is based on upstream Red Hat projects; oVirt, Spacewalk, FreeIPA, and so forth. This is primarily because I am a Red Hat Certified Engineer, 2001. Time and equipment is the other issue but my experience with Debian has been positive. Nothing beyond having to learn the nuances of a new distribution.
If you want to work together to tackle the endeavor, I am open to discussing it. Do you have the equipment? Have you checked to see if Debian has oVirt packages or would we look at a different management tool all together?
Where would you like to start?
Richard

Closing issue due to no response. Please reopen if you want to collaborate. Thank you.


Cython build failure reasons

this issue is to document the reasons Cython worker builds fail:

the cython command generating the pyx needs the mpi4py include -I(mpi4py.get_include())
the mpicxx compile generating the _cython.so needs the numpy include -I(numpy.get_include())

currently this is in the config.mk nor propagated to the code makefiles...
fixing it is possible, but I think the current plan is to remove the cython workers again...

Is anything in AMUSE using Cython these days? If not, let's remove it.

yes, I think we can remove it (this was the plan with Arjen) - I think we may want to leave it in the framework (for development, at some point it may be handy - in one of the ways to achieve parallel transport) but at least remove it from the makefiles of the codes that have it

Cython is used by Hanno Rein's code Rebound.
On May 7 2019, at 6:26 pm, ipelupessy<EMAIL_ADDRESS>wrote:

yes, I think we can remove it (this was the plan with Arjen) - I think we may want to leave it in the framework (for development, at some point it may be handy - in one of the ways to achieve parallel transport) but at least remove it from the makefiles of the codes that have it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/amusecode/amuse/issues/281#issuecomment-490152292), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABCPFTEMX77IZVVVZUXIY2TPUGUU5ANCNFSM4FJFKQIA).

Not for the AMUSE interface, right?
There's a 'regular' and a (for me not working) 'cython' worker for Rebound, and I can imagine the standalone Rebound uses Cython for its Python interface, but we're not using that I think?

I think rebound uses ctypes for its own python interface not cython (at least in the version downloaded by AMUSE)...
in any  case, this is about the amuse cython interface (ie the cython version of the mpi communication channel).

See #452 - close this?

cython is long removed from AMUSE now


helpers should not modify passed options

If you want to store options into a variable to avoid duplication,
unfortunately, the fa_icon changes the passed options. Therefore, the
second time that fa_icon is called with the same variable, some of
values are removed, e.g. class.
- icon_options = { class: 'foo' }
= fa_icon 'user', icon_options
= fa_icon 'tags', icon_options # this one will not have the foo class

+1

Perfect, clean, concise PR. Thanks!

Thank you for quick merge.

v<IP_ADDRESS> was just released with this change. Thanks again! 🍻

https://github.com/bokmann/font-awesome-rails/releases
https://rubygems.org/gems/font-awesome-rails


App doesn't work and I get a system error on start up

Hello,
After disabling security on my Mac and opening the app a pop up ask for the password, then it says the following: Turning off the recording indicator light requires a restart to take effect.
This happens every time I restart, so it takes no effect and the app doesn't work.
Additionally I get a popup on start up from the system, System Extension Error that looks like this:
https://discussions.apple.com/thread/253338157
I'm stuck now since I can't use your app and the error always appears.
Can you help me either removing your app or making it work properly?
Thanks.

In macOS Sonoma 14.4 or later, you can hide the recording indicator on external displays without using Recording Indicator Utility. Learn more ↗


Removal of additional line break at the end of message

TestContext.Progress.WriteLine is unneeded as formatted serilog message already contains line break at the end.
See: https://github.com/serilog/serilog-sinks-console/blob/eafe7d50cd9c2255b25ce3110eee8382ae5c0561/src/Serilog.Sinks.Console/Sinks/SystemConsole/ConsoleSink.cs#L66

Cheers mate. Hope the change works for you. I haven't used this package for a while and the build script needed some TLC.


Adding Sort by Mesh Sorting Order

When merging Spine baked bones, it is necessary to correctly sort the Mesh, otherwise the rendering order will be disordered.

Thank you for opening a pull request. But I see there's many lines are just rearranges the braces position, I hope you don't mess with the formatting when requesting to merge.

I'm sorry it was my negligence, I corrected it.


Board Review: Storage Files

Links to the review materials:

Java: https://apiview.azurewebsites.net/Assemblies/Review/86b15f9f146944c5b72438ac102a6e68
.NET: https://apiview.azurewebsites.net/Assemblies/Review/47c9ebbff8c0458fa2e7904eae34656f
Python: https://github.com/Azure/azure-sdk-for-python/pull/7708
JS: https://github.com/Azure/azure-sdk-for-js/pull/5477

Java Review: https://msit.microsoftstream.com/video/a99f1cf3-5bde-416b-a0a2-5b44d574c7d7

Directory Client:

In setProperties(), difference between filePermissions and permission keys - we want to take both - in .NET, that have a setFilePermissions() API.  FLAG FOR OFFLINE WORK

Rename FileRef to StorageFileItem, and merge with FileItem.

If that doesn't make sense, work offline

forceCloseHandles - maybe split into two APIs (single item and multi-item) and make the multi-item one look like an LRO
In listFilesAndDirectories - maxResults should be maxResultsPerPage
FileHTTPHeaders -> FileHttpHeaders
Upload of ByteBuffer - should align with blobs on upload/download APIs tyle
FileUploadRangeUrlInfo instead of URLInfo
Look at FileClientBuilder -> DirectoryClientBuilder derivation
Make sure SasBuilder is consistent with .NET
ShareSasPermission - .NET is having discussion around the property names
AccessPolicy -> FileAccessPolicy - prefix consistency
setFileProperties - look at how this is represented - OFFLINE DESIGN WORK
Consider hiding the FileProperty type
Rename Metrics -> FileMetrics
Check if NtfsFileAttributes can be replaced by a system enum
Should Range be moved to Azure Core as a Range class?  If you keep it in storage, then rename it to a specific storage type.  Also  be aware of inclusive vs. exclusive range counts.
ShareProperties - lostModified is not settable (remove setter)
set/getQuota - make the naming convention indicate scale
ShareStatistics - remove public constructor
ShareUsageInGB - turn into long / bytes
Change StorageErrorCode to FileStorageErrorCode

Python Review: https://msit.microsoftstream.com/video/921fdd3c-9de0-4bc9-a567-07221623dfe1

What happens when get_directory_client(directory_path: '/')

.NET has a GetRootDirectory()
Is there a difference between / and root?
Decision: Make directory_path required
pathlib takes an array of segments rather than a string

Add delete_directory to share client (not release blocker)
Distinction between create_directory and create_subdirectory is confusing

Decision: create and create_subdirectory - consistent with .NET
OFFLINE DESIGN WORK

.NET Review: https://msit.microsoftstream.com/video/35682be0-e433-4577-8091-398aaa1bacdd

Path should be added
Look at parameterless create() calls offline
forceCloseAllHandles - see below
Remove snapshot params in preference of withSnapshot
How should we name inBytes vs. inGB - do whatever the spec says, but use long for bytes
GetFilesAndDirectoriesOptions should go away
AccessPolicy -> FileAccessPolicy
Expiry -> ExpiresOn
Start -> StartsOn
NtfsFileAttributes - convert to nullable flags enum
StorageHandle -> StorageFileHandle
Remove Header enum
Hide listSharesIncludeType

forceCloseAllHandles:

The continuation token is not required if you fail to close all of them
We care on success or failure - not interim results.
ForceCloseAllHandles(recursive) that returns the # of closed handles and throws on first failure or timeout.
Return Task - total number of items that were closed.

JavaScript Review: https://msit.microsoftstream.com/video/48be60e0-2a97-4a48-96ac-e7cf6bdb2bce

maxResults -> maxPageSize (consider using a swagger transform)
sharesnapshot - fix casing
forceCloseHandlesSegment -> forceCloseAllHandles(recursive?: bool) -> int
parallelism -> concurrency
Use on<blah> for event handlers
downloadToBuffer - follow semantics of node file I/O (buffer is optional and create if needed)
Fix casing HTTP -> Http
uploadBrowserData() -> uploadData() and take node Buffer additionally
Align body: HttpRequestBody with the terminology used in blobs
UploadSeekableBlob -> fix casing
FileDownloadOptions - consider merge with DownloadFromAzureFileOptions

Also, consider changing maxRetryRequests to align with .NET semantics

blobBody -> bodyAsBlob, but also storage consistency may rename to contentAsBlob
NewPipelineOptions - refactor with core-http changes
Logging - refactor with core-logger changes
nextMarker -> continuationToken
dirPath -> path, plus add name
downloadToBuffer - offset can be optional


Dracula Theme

A theme created based on the official Dracula Theme palette found https://draculatheme.com/contribute/. I do not own Dracula, but thought it would be nice to share this with others.

I can squash it when I merge.

awesome. I made the suggested changes, please let me know if anything else is needed. Thank you for your time. I am excited about this~

oops, just added some changes, this should be the last of it. 😅

oops please don't merge.. I tried to squash the commits but ended up doing something wrong

New PR, sorry for the confusion https://github.com/dragonwocky/notion-enhancer/pull/142


one typo in README.md

Hi,
I found one typo in README.md file.
Example web
image2base64("https://whatever-image/")
    .then(
        (response) => {
            console.log(response); //iVBORw0KGgoAAAANSwCAIA...
        }
    )
    .catch(
        (error) => {
            console.log(error); //Exepection error....
        }
    )

to
imageToBase64("https://whatever-image/")
    .then(
        (response) => {
            console.log(response); //iVBORw0KGgoAAAANSwCAIA...
        }
    )
    .catch(
        (error) => {
            console.log(error); //Exepection error....
        }
    )

good luck~!

Hey, thanks a lot
I'm sorry, I'm from Brazil and my English is more less.
Do you wish to open a PR?

I saw that earlier and I already did a pull request. Can be closed.

Thanks a lot, closed issue.
#21


Create "About" window with menu

There has to be at least the next content:

Delete button icon made by Freepik from  www.flaticon.com
Edit button icon made by Becris from  www.flaticon.com
Github link

Solved. Needs improvement as mentioned on #12


:bug: Some of the reference docs are not generated correctly

I would expect this to render a table and not a textual representation of the struct.
This is an example https://docs.rig.dev/api/v1alpha1#capsuleinterfaceingress
https://github.com/rigdev/rig/blob/main/docs/docs/api/v1alpha1.md?plain=1#L64

Is this fixed?


Assets add missing properties

@OliveGerste One remark is that variable name 'fallbackValue' is only valid if you have a dynamic asset but not when you have a static one (no connection to a backend to get the value).
I would call it more like 'staticValueWatt' (with the Unit also ;-))
Also 'fluctuation' -> 'fluctuationPercent'?
Let me know.

@OliveGerste One remark is that variable name 'fallbackValue' is only valid if you have a dynamic asset but not when you have a static one (no connection to a backend to get the value).
I would call it more like 'staticValueWatt' (with the Unit also ;-))
Also 'fluctuation' -> 'fluctuationPercent'?
Let me know.


Cannot find module or its corresponding type declarations from file outside of src/

As title says, When a file is outside of the src folder, intellisense breaks, the build on the other hand works.
steps to reproduce:

create a directory "foo" in root directory.
create a class or vue component inside that directory.
try to import a class or vue component in src.

to make it clearer, consider this file tree:

break

Broken.vue

src

Foo.ts
components

Bar.vue

contents of Broken.vue would be:
<script setup lang="ts">
  import Foo from '@/Foo'
  import Bar from<EMAIL_ADDRESS></script>

You can try add break/Broken.vue to include in tsconfig.


Maven plugin: handle duplicate gatling.conf

If user override config folder with configFolder and have one gatling.conf in both custom and standard folder (src/test/resources), the latter has precedence/comes first in the classpath. It should be the opposite.

Closed by https://github.com/gatling/gatling-maven/commit/1a3bc81eb11fd2814df55d964a521ab302b71a95

Possible explanation of https://github.com/gatling/gatling-maven/issues/4


Clean up UI of "this is a test"... and other WIP before release

For instance:
"this is a test tooltip"

@tdruez @pombredanne Following up on this morning's call and working in my new branch 798-refine-ui, I've removed all traces of jQuery code (with 1 exception noted below) and replaced the empty-form jQuery on the 5 main templates with JS, e.g.:
    function validatePkgForm() {
        var x = document.forms["pkg_form"]["name"].value;
        if (x.trim().length == "") {
            return false;
        }
    }

    function validateVulnForm() {
        var x = document.forms["vuln_form"]["vuln_id"].value;
        if (x.trim().length == "") {
            return false;
        }
    }

However, I now see/recall that the Bulma tabsets on the 2 details pages also use jQuery and no longer work, e.g.,
    $(document).ready(function () {
        $('#tabs li').on('click', function () {
            var tab = $(this).data('tab');

            $('#tabs li').removeClass('is-active');
            $(this).addClass('is-active');

            $('#tab-content div').removeClass('is-active');
            $('div[data-content="' + tab + '"]').addClass('is-active');
        });
    });

I've checked my notes and don't see where I got this code, but evidently not from Bulma, which is CSS-only.  What do you suggest we do?  Use jQuery just for the tabs?  Replace the tabs with some other display?

https://github.com/nexB/scancode.io/blob/main/scancodeio/static/main.js#L61

I see a codepen example here: https://codepen.io/t7team/pen/ZowdRN.  Don't know if it would work for us nor what the license is.
And a youtube video re vanilla JS: https://www.youtube.com/watch?v=jsevCC_nlHc&t=11s

and this comes from Bulma's JS even tho Bulma is CSS-only?  ;-]
https://bulma.io/lib/main.js?v=202104191409

@tdruez Unfortunately I haven't been able to get the tabs working with this SCIO JS code, perhaps because SCIO creates the Bulma tabs differently than I've created them in VCIO.

Chrome devtools indicated that getAll() was not defined, which taught me that my new main.js file also needed this:
// Utils, available globally

function getAll(selector) {
    var parent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : document;
    return Array.prototype.slice.call(parent.querySelectorAll(selector), 0);
}

Now I can click the tabs and the tabs change -- but not the tab content.  ;-[  So somewhere in this SCIO code there might be code tied to the SCIO (but not VCIO) way the tabsets/tabs are structured. . . .
function setupTabs() {
    const $tabLinks = getAll('.tabs a');

    $tabLinks.forEach(function ($el) {
        $el.addEventListener('click', function (event) {
            const activeLink = document.querySelector('.tabs .is-active');
            const activeTabContent = document.querySelector('.tab-content.is-active');
            const target_id = $el.dataset.target;
            const targetTabContent = document.getElementById(target_id);

            activeLink.classList.remove('is-active');
            $el.parentNode.classList.add('is-active');
            if (activeTabContent) activeTabContent.classList.remove('is-active');
            if (targetTabContent) targetTabContent.classList.add('is-active');
        });
    });
}

@tdruez I've been unable to get the SCIO JS code working with the tabsets on the 2 details pages, package_update.html and vulnerability.html, and am reluctant to re-add the jQuery I just finished removing, so I'm pushing the code as it currently exists with the hope you'll be able to help me resolve this.
All 134 local tests pass and all 5 GH checks pass (for PR 813 there are 9, not 5, GH checks, no idea why the diff).

For the record, earlier today I finished replacing the jQuery with JavaScript, including for the Bulma tabsets, and committed and pushed to https://github.com/nexB/vulnerablecode/pull/847.  Next steps include additional cleanup and work on comments, suggestions and issues from earlier this week.

This has been addressed in several recent pushes to https://github.com/nexB/vulnerablecode/pull/847


Error: Failed to initialize resource limits: Operation not permitted (os error 1)

Noseyparker scan action produce this result -
./noseyparker scan --datastore data .
Error: Failed to initialize resource limits: Operation not permitted (os error 1)
Without scan action it starts well -
./noseyparker
Nosey Parker is a command-line program that finds secrets and sensitive information in textual data and Git history.
Usage: noseyparker [OPTIONS] <COMMAND>
...

@kobenys thanks for the report! What platform are you running on?
Adjusting the resource limits — specifically, increasing the open file limit — is done early on to avoid possible crashes later when using a high degree of parallelism and working with a large number of inputs. It's not essential to Nosey Parker operation.
I'll fix this. If attempting to adjust the resource limits at startup fails, a warning should be printed and the operation should attempt to continue on.

This is fixed on main now, and will be included in the next Nosey Parker release (v0.18.0, in the next several weeks). From there, it should get picked up in Homebrew.


Merge 2 functions together in applications MobileNetV2

_inverted_res_block() and _first_inverted_res_block() are nearly the same. Merged them into one function

skip "Expand" part for 0 block
made layers names similar to original TF graph names

Thanks for the PR.
@taehoonlee would you have the bandwidth to review?

@fchollet, @bonlime, This PR can produce the same results as now. LGTM.

@taehoonlee made prefix shorter


Render tracks, paths, trails

This is an overview issue to capture ideas and plans for rendering tracks, paths, and navigable ways that are not part of the general-purpose highway network.
While land-access tracks that may be utilized by motor-vehicles and single-track paths are somewhat different, they overlap in that both vary greatly on:

Access restrictions both overall and mode-specific.
"difficulty" (e.g. tracktype and/or smoothness for difficulty of motor vehicles accessing tracks, or sac_scale and/or mtb:scale for hiking/biking difficulty.
visibility (trail_visibility) as these often less-maintained ways age into abandonment. "Informal" paths may fall into this bucket or their own.
A variety of surfaces from mud and sand to gravel and asphalt.
Inclusion in recreational networks.

A first step is to identify which dimensions of variation this style will ultimately support and what visual language might be used to show each dimension.
Some kickoff questions:

[ ] How will tracks and paths be disambiguated from each other and from general-purpose roads? (e.g. single line of dashes versus double line of dashes a la USGS topo maps? Different line weights a la Carto?)
[ ] Which dimensions (above, and others?) will be distinguished?
[ ] Will sidewalks, cycleways, and other very-improved infrastructure share the same visual language as other tracks and trails or will they have a divergent representation?
[ ] Will tracktype=grade1 (and grade2?) be rendered more like minor roads or more like worse tracks?
[ ] How might this style assist the work of the Trails Working Group? For example diminishing the visual weight and/or not recommending the use of informal, discouraged, illegal, or dangerous trails.

Here are some examples from my map collections. Other examples welcome.
Green Mountain National Forest map published by the US Forest Service:
Note the use double-dashes for tracks and the single dashes for trails. Uses a distinct color for trails of note (in this case the Long Trail and the Appalachian Trail).

Adirondack High Peaks Region
1983, Plinth, Quoin & Cornice Associates
Uses two weights of brown lines for tracks and gray lines for trails. Trail ownership (and/or access?) as well as access modes are indicated by symbols along the line.

Benzie Map & Guide
Published by the Benzie County (MI) Chamber of Commerce. Produced by Michigan Maps Inc, 2006.
Casing and fill is used for snowmobile trails, then colored access-mode dots are used for summer access (the snowmobile trails are multi-use trails in the warm months). The same style of dots is used for hiking/sking paths as well).

Moosalamoo Outdoor Recreation Map
Published by the Moosalamoo Association
Note how the the different access mode dots & dashes get alternated to indicate which are allowed on each path.

Pensylvania Tourism and Transportation Map (2015)
Publish by the PA Department of transportation
No tracks displayed, red dots are used for selected trails (e.g. Appalachian Trail).

Vermont Official Road Map and guide Vermont Attractions
Published by the Vermont Attractions Association
Note the use of green lines (instead of black) for "Recreational Highways". In this case these are US Forest service routes, some of which are tracks of varying grade.

It hasn't been explicitly stated, but I would like to see us firmly distinguish paved from unpaved when rendering these classes of features.  This could be a bit challenging when considering the current rendering for unpaved roads.
Regarding tracks, I would be okay with some level of unification between them and paved (grade1) and unpaved (grade2-5) renderings of our lowest road classes.  The difference between some of these concepts are already so fuzzy that I'm not sure how much we want to visually distinguish them, though I recognize I may be in the minority on this point.

More feedback in the Slack thread...

Bob G (rjgambrel):minnesota:  13 minutes ago
I do not plan to add github to my quiver of communication channels so am providing one reaction to the issue here. Hopefully this will be OK. The specific issue: Will sidewalks, cycleways, and other very-improved infrastructure share the same visual language as other tracks and trails or will they have a divergent representation?  Opinion: hardened (paved) cycleways should definitely be rendered somewhat prominently. More so than unpaved paths, hiking trails, tracks, snowmobile trails, grassy x-c ski trails and the like. This does not have to be a full blown CYCLOSM type rendering, but must include any highway=cycleway. Regarding "sidewalks". I feel less strongly about this but possibly all highway=footway with a hardened surface should also be rendered (differently from cycleways though and less prominently). I don't think footway=sidewalk should be rendered until zoomed WAY IN. (I am basing this on the way I map: a footway next to a street gets footway=sidewalk; one that is not next to a street does not). Here is one more thought about cycleways. As you zoom in, cycleways that are part of a route network should render first, then as you zoom in further all cycleways should be rendered. (And if you want to take this a step further, use the network type -- rcn, etc) to determine zoom level to start rendering.) My two cents.

Typically, both road maps and outdoors maps show trails to a certain extent, but road maps emphasize road classification (and other road attributes) over trail classification, while it’s the reverse with outdoors maps. We could certainly deemphasize road classification at high zoom levels, where it would be less relevant to pedestrians, but should we also try to minimize the number of line treatments for roads at lower zoom levels, to accommodate all the distinctions needed for trails?
By the way, #215 introduces a broken line treatment for roads under construction. I think it’s possible to distinguish between that and broken lines for trails, but we would need to give trails a different line width or color for it to be an effective distinction.

I'd support peaks before or after other features. Fine to create an issue to start planning. It would be helpful to collect images of various American maps as examples of how they are shown. I don't have a sense if implementation will need to wait on a more cohesive POI rendering structure or if we can just add it in alone.

Let’s track peaks (and anything other than trails) in a separate issue. After all, it’s easier to implement multiple disparate things at once than to discuss them in the same unthreaded issue.

Will do. I started writing something up but it was more complicated than I
originally expected to get my thoughts down. It’s still forthcoming though
On Sat, May 28, 2022 at 2:31 PM Minh Nguyễn @.***>
wrote:

Let’s track peaks (and anything other than trails) in a separate issue.
After all, it’s easier to implement multiple disparate things at once than
to discuss them in the same unthreaded issue.
—
Reply to this email directly, view it on GitHub
https://github.com/ZeLonewolf/openstreetmap-americana/issues/216#issuecomment-1140310572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJRYSRVZPDW25ASL5E6NH3VMJQ7DANCNFSM5QDVDO7Q
.
You are receiving this because you commented.Message ID:
@.***>

--
Alex Hall | @.***


b2 build warning in Jamfile

Probably been there a long time...
../libs/contract/test/Jamfile.v2:417: Unescaped special character in argument <define>BOOST_CONTRACT_ON_MISSING_CHECK_DECL="{ throw err(); }"

Warning-free builds are better, though.  If it's a simple fix, please consider it.

I will not generate a new release just for this, but I will consider to include this improvement in the next release when/if that is needed.

I will fix this as suggested in pull request #12.


Use the head.sha instead of head.ref

Using head.ref/base.ref can lead to race conditions where the branch (ref) is modified after a workflow is started which results in either the wrong revision to be checked out or fails when the branch is deleted.

Closing this as permissions from fork dont work with pull request event:  https://github.com/abcxyz/guardian/pull/227


Enable passing additional activation data to the server

The FRL Online package controls which local device parameters (e.g., local OS device name or network hostname) are sent to the server.  The proxy currently will currently ignore these parameters, so when used in store/forward mode it won't actually pass this info to the server (and these parameters won't be available in the local database).  To date this hasn't been an issue, since no packages send these parameters, but customers are asking to be able to report this information, so we should make sure the proxy handles them.
Describe the solution you'd like
The proxy should capture all parameters sent by the device, not just those that are required for activation to succeed.  It should be storing these in the local database and sending them to the server when requests are forwarded.

I've retired from Adobe so I am un-assigning myself from this issue.


Remove: Discord.Discord version 1.0.9003

## .\Tools\YamlCreate.ps1 -PackageIdentifier Discord.Discord -Mode 5 -SkipPRCheck 1.0.9003

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


latest bnb no longer has optim_args attribute on optimizer

What does this PR do?
with latest bitsandbytes:
[rank1]:   File "/root/miniconda3/envs/py3.11/lib/python3.11/site-packages/accelerate/utils/deepspeed.py", line 53, in map_pytorch_optim_to_deepspeed
[rank1]:     is_adaw = isinstance(optimizer, (bnb_opt.AdamW, bnb_opt.AdamW32bit)) and optimizer.optim_bits == 32
[rank1]:                                                                              ^^^^^^^^^^^^^^^^^^^^
[rank1]: AttributeError: 'AdamW' object has no attribute 'optim_bits'

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
@muellerzr

we might have to combine this with #3305 @bursteratom. I think 3305 isn't backwards compatible with older versions of bnb, but it also checks the lion optimizer case.


!include does not work.

Hi there,
I read the section Before reporting a bug but I think the output of the parser is ok because I tested it myself. I have a separate file in the same directory with my JSON Schemas. When I parse it with the js parser you're using, they appear as object in the console (I mean they're parsed perfectly).
When rendering it, I got an error:
Error parsing: while reading /Users/laurentmeyer/Documents/JobNinja%20Doc/API%20RAML/data-model.yaml cannot read /Users/laurentmeyer/Documents/JobNinja%20Doc/API%20RAML/data-model.yaml (Error: ENOENT, open 'path/API%20RAML/data-model.yaml') in "path/API RAML/api.raml", line 36, column 5

It is clear that it is a parsing error but I cannot understand why because, as I mentioned the parser works but I think there is a bug with the %20 character, could it be? Does some of you have experience with these external JSON Schemas?

raml2html doesn't do any parsing, this error comes from raml-js-parser. I'm sorry but I can't help you, you'll have to report/ask here.

I would suggest to try it without spaces first..

Yes, that was it! The problem came from the fact that some folders where named with spaces! :tada:
Ok, then, I do not know if it can be considered as a bug but I could be useful to put this little precision in the readme of the parser (but a reminder in yours cannot be bad :smile: :+1: ).

Looked at all the examples in http://raml.org/spec.html, and they always use - or something instead of spaces. If I were you I'd report this as a bug to https://github.com/raml-org/raml-js-parser and simply don't use spaces in paths.

Ok thanks for your time, I know that's bad practice but I find it looks better in the Finder :grin:


Add proposal template

Adds a proposal template based on the discussion in<EMAIL_ADDRESS>

@jon-wei would you please add a license?

LGTM, thanks for providing that!


Overriding the configured redirectURL for an OAuth2 provider when calling getAccessToken

I'm building a central authentication server which may have a number of login urls across subdomains. Satellizer, for example, now sends a redirectUri parameter along with the code key in the post body. It'd be nice to be able to use that in place of the configured provider redirectURL since otherwise validation will fail. Please let me know if I'm overlooking an existing way to deal with the issue of handling more than a single redirect URL.

But note: There is currently a bug in this implementation. Please look at the comment from @felipefzdz

Fixed with https://github.com/mohiva/play-silhouette/pull/433


Make workspace example use package attributes

https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table defines a table which can be defined in the workspace Cargo.toml which can then be inherited by crates in that workspace.
This PR updates the example to illustrate usage, and at present identifies a bug when license.workspace = true is set in any crate's Cargo.toml:
error:
       … in the condition of the assert statement

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/lib/customisation.nix:222:17:

          221|     in commonAttrs // {
          222|       drvPath = assert condition; drv.drvPath;
             |                 ^
          223|       outPath = assert condition; drv.outPath;

       … in the left operand of the update (//) operator

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/pkgs/stdenv/generic/check-meta.nix:444:17:

          443|       validity = checkValidity attrs;
          444|     in validity // {
             |                 ^
          445|       # Throw an error if trying to evaluate a non-valid derivation

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: cannot coerce a set to a string

Please see https://github.com/yusdacra/nix-cargo-integration/issues/123#issuecomment-1667549767.

I fixed this on master, please update and check it out.


Can no longer connect to ec-2 instances, Error connecting to instance 'i-546456' instance id doesn't exist

I'm getting this error any time I try to connect to an instance:
Error connecting to instance 'i-546456' The instance ID 'i-546456' does not exist

Hi @CanIGetaPR , are you still having this problem? Can you please explain more about what operation you are trying to perform, and where in the Toolkit you are doing it?


About Dpt File

Is the [0001_depth.dpt] file created at runtime or should it be provided as input?

Could anyone provide information about the .dpt file used here?

Should the .dpt file be provided as input along with the 360 image, or is the 360 image alone sufficient?

your insights are greatly appreciated

If you dont have ground-truth dpt then you should follow the README here


feat(track): allow track truncation by time / age out

os.track supports truncation to a specified number of track points. I need something similar, but by age of the points.
That is, old points in the track will be removed if they "age out" beyond a specified time.
The PR includes some minor refactoring and jsdoc fixes.

@bradh FYI Travis stopped building OpenSphere, so you'll have to merge this branch with master to pick up the GH Actions builds.


Refactoring of BuildTools/Common/Profile

This will need quite some refactoring to propperly work with C# 8 Nullable, to guarantee non-null values everywhere.
For now (in #40) everything is set to some default value, but this could lead to some unexpected behaviour (for example, if for whatever reason ClassName isn't set, a class with an empty name will be generated, which means invalid generated code.
Low priority, as it works, but when working with this code, consider refactoring it, or at least take care.

This is rough, as binder JSON was designed in a way that null was actually an acceptable value for most things. Moreover, we have people working on external converters so we can introduce a wider range of APIs to Silk.NET.
Keeping the binder up-to-date has never really been a focus for us, as we were kinda hoping to just leave it to do its magic once it's working. As such, I don't see us making extensive changes because, as you said, it works!
We'll consider this for a future breaking release, maybe a 2.0.

Perfect, that was the intend. Just wanted to leave this here for anyone to find that will be working on it. No need to invest time and effort if nothing needs changes anyways

As of preview 4, we will no longer be maintaining our own bindings generator, as we'll be rewriting the generator and moving it out into its own product - SuperBind - under the SuperTools umbrella.


New benchmark guide not available

How can the optical damage benchmark be registered?
AssertionError: Benchmark optical_damage is not registered.
Registered benchmarks: ['MNIST_tf_keras', 'MNIST_torch', 'em_denoise', 'dms_structure', 'slstr_cloud']
Installation and dataset guide is not available either.

Found in https://github.com/stfc-sciml/sciml-bench/blob/master/sciml_bench/docs/markdown/main/installation.md.


"Mirror" inherits most recent color, shader etc state of draw call

I think this explains many of the sporadic problems we've been seeing with the Rift mirror window for a long time.
Consider this test program.
function lovr.load()
	lovr.graphics.setBackgroundColor(1,1,1,1)
	shader = lovr.graphics.newShader("standard")
end

function lovr.draw()
	lovr.graphics.setShader(shader)
	lovr.graphics.setColor(1,0,0)
	lovr.graphics.cube('fill', 0,1,-1, 0.25)
end

Run this in the desktop driver. Works fine. Run this in the Rift driver. The mirror window is black. Now, try adding the line lovr.graphics.setShader() to the final line of lovr.draw. Now it draws, but there is a red tint over everything

Now try adding lovr.graphics.setColor(1,1,1) to the end of lovr.draw. Now the scene works okay.
The problem is that the draw call for the mirror window inherits the final shader, final collor, final setWireframe() mode etc of the lovr.draw function. We could fix this by adding lovr.graphics.reset() to the default lovr.mirror() but Bjorn points out this would violate expectations re: state persisting between draw calls. Bjorn suggests one solution might be a pipelines approach that allows you to create scoped states or whatever.
See also.

I thought this test was done with the oculus driver, but it was actually done with the steamvr driver with an oculus headset. I'm certain this doesn't change anything

Canvas
Shader
Culling or Winding
Wireframe
Blend Mode
Color
Color Mask
Stencil Test

Is I think everything that could affect the lovr.graphics.fill.  That's a lot.

Not immediately relevant, and details subject to change, but the upcoming graphics stuff has passes.  Render state is reset at the beginning of a pass.
So you can do
lovr.graphics.render(headsetCanvas, function(cmd)
  cmd:setColor(color)
  cmd:cube('fill', x, y, z)
end)

lovr.graphics.render(windowCanvas, function(cmd)
  -- cmd:setState(mirrorState) -- if needed
  cmd:fill(headsetCanvas)
end)

And they will not conflict with each other.  boot.lua will handle the canvases and calls to .render so in a practical sense this just means that lovr.draw and lovr.mirror will not conflict anymore, fixing this issue and a whole class of other issues related to the global graphics state.


skip node local dns ip conntrack when set acl 1.13

Pull Request

[ ] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features
Bug fixes
Docs
Tests

Which issue(s) this PR fixes
Fixes #(issue-number)

The ovs build failed

The ovs build failed

已修复


HBASE-24650 Change the return types of the new CheckAndMutate methods…

… introduced in HBASE-8458

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
checkstyle
2m 29s
master passed

+1 :green_heart:
spotbugs
4m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
checkstyle
2m 26s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  8s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

43m 26s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 92f10dc17f7d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

unsubscribe
Best Regards
Ricky Yang

------------------ 原始邮件 ------------------
发件人: "Toshihiro<EMAIL_ADDRESS>发送时间: 2020年6月28日(星期天) 上午10:01
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>主题: Re: [apache/hbase] HBASE-24650 Change the return types of the new CheckAndMutate methods… (#1991)
@brfrn169 commented on this pull request.
Thank you for taking a look at this!
Yes, the old checkAndXXX methods are not effected. I'm going to add Increment/Append support to CheckAndMutate only for the new checkAndMutate methods.
In hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutateResult.java:
> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + / +package org.apache.hadoop.hbase.client; + +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/* + * Represents a result of a CheckAndMutate operation + */<EMAIL_ADDRESS><EMAIL_ADDRESS>Okay. I will remove the IS annotation. Thanks.
In hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java:
> @@ -349,7 +349,7 @@ private void preCheck() {            loc, stub, mutation,            (rn, rm) -> RequestConverter.buildMutateRequest(rn, row, family, qualifier, op, value,              null, timeRange, rm), -          resp -> resp.getExists())) +          resp -> ((CheckAndMutateResult) resp).isSuccess()))
I will modify it to make use of generic type. Thanks.
In hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java:
>    }      // We need the MultiRequest when constructing the org.apache.hadoop.hbase.client.MultiResponse,    // so here I write a new method as I do not want to change the abstraction of call method.    private <RESP> CompletableFuture<RESP> mutateRow(HBaseRpcController controller,        HRegionLocation loc, ClientService.Interface stub, RowMutations mutation,        Converter<MultiRequest, byte[], RowMutations> reqConvert, -      Function<Result, RESP> respConverter) { +      Function<Object, RESP> respConverter) {
The reason why I changed Result to Object here is that this method is used by both checkAndMutate() and mutateRow() and we need to use different types each case (respectively CheckAndMutateResult and Result). However as you mentioned, we can make use of generic type here. I will modify it. Thanks.
—
You are receiving this because you are subscribed to this thread.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
2m 34s
the patch passed

+1 :green_heart:
javac
2m 34s
the patch passed

+1 :green_heart:
shadedjars
5m 43s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 25s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 50s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

+1 :green_heart:
unit
127m 40s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 21s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 12s
hbase-rest in the patch passed.

169m 45s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b0b754ac7ac1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/testReport/

Max. process+thread count
4397 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
compile
2m 17s
master passed

+1 :green_heart:
shadedjars
6m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
shadedjars
6m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

+1 :green_heart:
unit
200m 28s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 18s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  2s
hbase-rest in the patch passed.

242m 56s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c6441995d13a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/testReport/

Max. process+thread count
2848 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
checkstyle
2m 26s
master passed

+1 :green_heart:
spotbugs
4m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

-0 :warning:
checkstyle
0m 27s
hbase-client: The patch generated 8 new + 34 unchanged - 0 fixed = 42 total (was 34)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

42m 52s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 13e08aacd4d5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
2m 33s
the patch passed

+1 :green_heart:
javac
2m 33s
the patch passed

+1 :green_heart:
shadedjars
5m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 51s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

+1 :green_heart:
unit
128m  2s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 22s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 12s
hbase-rest in the patch passed.

170m 17s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5781817ac100 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/testReport/

Max. process+thread count
3857 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
compile
2m 16s
master passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
shadedjars
6m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 12s
hbase-client in the patch passed.

+1 :green_heart:
unit
201m 31s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 21s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  0s
hbase-rest in the patch passed.

243m 24s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux edcfbc01ae67 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 47742b2083

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/testReport/

Max. process+thread count
3432 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I modified the patch for the review and looks the QA is okay.
@Apache9 Can you please review this? Thank you in advance.

@Apache9 Please let me know if you have any questions about this. Thank you in advance.

I missed that it had some checkstyle errors. I fixed the errors.

Ping @Apache9. Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
checkstyle
2m 41s
master passed

+1 :green_heart:
spotbugs
5m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
checkstyle
2m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

48m 54s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 54f3d51235b3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e614b89c33

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 53s
the patch passed

+1 :green_heart:
compile
2m 59s
the patch passed

+1 :green_heart:
javac
2m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 48s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 33s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 50s
hbase-server in the patch failed.

-0 :warning:
javadoc
1m 13s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 42s
hbase-client in the patch passed.

+1 :green_heart:
unit
218m 54s
hbase-server in the patch passed.

+1 :green_heart:
unit
6m  1s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 56s
hbase-rest in the patch passed.

269m 37s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c3d57c1fb90 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e614b89c33

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/testReport/

Max. process+thread count
3329 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
master passed

+1 :green_heart:
compile
2m 35s
master passed

+1 :green_heart:
shadedjars
6m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
2m 27s
the patch passed

+1 :green_heart:
javac
2m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 12s
hbase-client in the patch passed.

+1 :green_heart:
unit
232m 13s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 50s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 51s
hbase-rest in the patch passed.

276m 48s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 55dfc53b3d84 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e614b89c33

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/testReport/

Max. process+thread count
3330 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
checkstyle
2m 47s
master passed

+1 :green_heart:
spotbugs
4m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
checkstyle
2m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

43m 54s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux bd0126a7ef78 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 32s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

+1 :green_heart:
javac
2m 43s
the patch passed

+1 :green_heart:
shadedjars
6m 22s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 57s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

+1 :green_heart:
unit
191m 51s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 15s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 26s
hbase-rest in the patch passed.

238m 29s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4aef4cce48bd 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/testReport/

Max. process+thread count
3458 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 56s
master passed

+1 :green_heart:
compile
2m 18s
master passed

+1 :green_heart:
shadedjars
6m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 14s
hbase-client in the patch passed.

+1 :green_heart:
unit
202m 13s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 18s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  2s
hbase-rest in the patch passed.

244m 51s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 069beffa18fd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/testReport/

Max. process+thread count
2833 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1991/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


DataGrid : multiLineWrap wrap doesn't apply for the table header

Package
Carbon for IBM Products
Description

Create a Datagrid table and add multiLineWrap = true for one column.
multiLineWrap doesn't wrap the column header

Expectation:
I should be able to wrap Table header. Incase the column name is too big   , adding width will only include (...) in the header. There should be a way user should be able to see the Header name as below

Component(s) impacted
Datagrid
Browser
No response
@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version
"@carbon/ibm-products": "2.40.0",
Suggested Severity
None
Product/offering
NA
CodeSandbox or Stackblitz example
https://codesandbox.io/p/sandbox/datagridfilter-forked-6xz574?file=%2Fsrc%2FExample.js%3A115%2C27
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

### Tasks
- [ ] `multiLineWrap` should wrap only 2 lines for column headers

We've been investigating TanStack Table, a third-party, open-source offering, which provides extensive data table capabilities surpassing what our Carbon Datagrid offers. It provides much more flexibility and customization. TanStack Table is headless which means it can easily be added alongside Datagrid component in your product or application. The benefits of more flexibility for product teams and less maintenance for Carbon makes it a win win. Lastly, it is available in multiple frameworks including React and Web Component so it provides an option to non-React product teams.
For these reasons, we have decided to transition from building our own custom table component to using an example-based approach with TanStack Table. Datagrid will still exist in our library for existing teams but we are announcing the deprecation* of the Datagrid component in v2.54.0 release so teams can begin to work through the transition. Details about how to use both Datagrid and TanStack together can be found here.
*Deprecation means that no new features will be added however sev 1 and sev 2 bugs will be supported.


Send to Unreal wrong scaling.

When send assets to disk and then import them to UE assets has a wrong scale, looks like x100 of original size. Changing pugin export settings not change the scale at all.
Regular Blender export with the same settings don't have such problem and export perfectly.

Addon: Send to Unreal
Steps to Reproduce the Problem:  Export regular model with settings "Collection as folder enabled":

On this screenshot two models with the same export setting one exported manually and second exported with the plugin:

OS: Windows
Addon Version: Send to Unreal 2.4.5
Blender Version: Blender 4.1 - 4.2

EDIT2: When import asset to Unity it has the same wrong scale (x100)

EDIT3: Looks like I found the bug. If UseObjectOrigin is active the scale goes x100
Yep, tested on the fresh project. Very strange place for a bug... Funny thing: even if UseObjectOrigin is not active, objects still use their origin.

Thanks for the report! Can you please attach your blend for me?

To have the correct scale in Unity, you need to check the Experimental!ApplyTransform option. However, if the UseObjectOrigin option is active, the scale becomes incorrect again in UE and Unity.
Here is an example of the same mesh with these settings with UseObjectOrigin ENABLED:

And UseObjectOrigin DISABLED:
In UE and Unity the scale became normal.

_Small notice to picture above: if UseObjectOrigin disabled, the origin in Unity not the same as in UE. But it might be Unity feature to always use origin of the object
So I don't know how the plugin works under the hood but UseObjectOrigin option influences on scale of the object

Thank you, this should resolve the issue. Not sure why I saw no difference in scale on my first test. The mesh shifted tho. Odd. Anyway, I tested again and you were right.

Thank you for supporting this amazing addon!


Simplify zstd cmake logic

Reduce number of ifs
Remove checks on magic variables like CONAN_ZSTD_ROOT and use more generic if (TARGET ...) checks.

@kayoub5
I have currently no good idea to test the conan packaging in this repository when the recipe and sources are in different repos, it looks like a cyclic dependency to me.
The only solution I can provide is the description how to create the conan package of the current working draft:
clone https://github.com/conan-io/conan-center-index.git
recipes/lightpcapng/config.yml:

Add new version

recipes/lightpcapng/all/conandata.yml

add new location where to find the sources + sha256

cd recipes/lightpcapng/all

# and execute:

conan create . lightpcapng/<your_version>@

@kayoub5
Looks good now for the conan build.


Snakemake - Retry mechanisms

Description
Snakemake workflows are all run in separate locations which means that previous steps need to be retried if a customer runs a workflow twice. We should allow customers the ability to run workflows in a specific folder for snakemake so that the workflow can skip through previous steps.
Use Case
It allows customers to dynamically test and validate complex workflows without repeating previous steps.
Proposed Solution
Allow the customer to specify a folder to run the workflow in that will be consistently used between runs.
Other information

Would welcome this, especially for large workflows


Roadmap in Azure

We have created new hierarchy structure starts with Theme & Initiative portfolio. We would like to have our Roadmap view at Theme level. How we can add/include Roadmap at theme level

Sorry, but this code in this repo is not currently being maintained. We recommend you use the Delivery Plans feature that is core to Azure DevOps.


need a getter of GetInstance._singl

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS. THIS SPACE IS DEDICATED ONLY FOR FEATURE REQUESTS
Is your feature request related to a problem? Please describe.
in some page , I need to change configs if it has been registered.(lazyPut)
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Sorry, _singl is private because it is a static variable.
It is not correct to expose static variables which depend on the core of the application, because you can break it if you do not know what you are doing, so I will not expose this api.

@jonataslaw I just want a method like
  List<S> findIsInstance<S>() {     final result = <S>[];     for (var element in _singl.values) {       if (element is S) {         result.add(element.getDependency() as S);       }     }     return result;   }

What's your use-case? maybe there is another way of doing it.
can you explain exactly what you want??

@Nipodemos  I hava a base config class。In every page ，I lazyPut extends class。In setting page，need to change the config of all page.
thx,my English is terrible.

I write a example


Fix docs link on index page

Noticed this while browsing the docs -> url should be relative and point to the right guide page

Awesome, thanks! :beers:


Update requirements.txt

Added future library to requirements

confirm, I had problems without that "future" module on clean installation (I mean I had system without Python, and was installing clean Python and then copier)

@rfominych same here, that's why I recommended this.

Okay, thanks a lot!


n queen problem by backtacking

please assign this issue to me
@Sidhijain
I have also created a pull request #2043  for the same

Please assign this issue to me . I have also made the pr regarding the same


moved files into separate lib for gradle & jitpack

Thanks for the effort!
I would like to say, that this project currently is mostly a playground to me. As such, I don't feel it ready to be published with a version number yet. Most code is rather untested, and I feel there are too little proper features to make it a library just yet.
At this point, this project is intended to showcase some possible uses for decorations and code to copy, modify, and adapt.