[POC] Network metadata mapping

What this PR does / why we need it:
This is the final PR which, based on #1404 and #1407, bridges the gap between different ways on how internal or external systems may provide networking to kubevirt.
It does the following:

[x] Make KubeVirtConfig a real CRD type to allow validation, ...
[x] Let virt-handler search KubeVirtConfig for matching network definitions
[ ] Let virt-handler add or remove matching networks to nodes
[ ] Let virt-handler translate between DefinedNetworks and primitive types (e.g. Bridge) introduced in #1407
[ ] Let virt-handler only propagate labels to nodes when the bridges are  really there
[ ] Let virt-controller add labels or resources to the pod, based on the network definitions.

To highlight again what has been said in #1407 the goal is not that KubeVirt can manage all and everything. This is mostly about laying out a common ground to combine internal and external networking features and do privileged setups and external resource configuration at the right spots.
A VMI can refence a defined network like this:

spec:
  domain:
    devices:
      interfaces:
      - name: if0
networks:
- name: if0
  definedNetwork:
    name: red

Networks can be defined like this:
apiVersion: kubevirt.io/v1alpha2
kind: KubeVirtConfig
metadata:
  creationTimestamp: null
  labels:
  name: kubevirt-config
  namespace: kube-system
networks:
  red:
    labelNetwork:
      definitions:
      - nodeSelector:
          "dc": "1"
        bridge:
          targetName: br100
          type: Bridge

Here an example where all nodes should contain a br2 and they should be attached to network blue:
networks:
  blue:
    labelNetwork:
      definitions:
      - bridge:
          targetName: br2
          type: BridgeOrCreate # virt-handler will check if br2 exists on the node and only then promote the net

Here an example where only datacenter 1 (with label dc=1) contains br2 for network blue:
networks:
  blue:
    labelNetwork:
      definitions:
      - bridge:
          targetName: br2
          type: BridgeOrCreate
        nodeSelector:
          "dc": "1"

Here an example where e.g. an OCI device hook makes sure that the bridge is there (so virt-handler does not have to check for the bridge):
networks:
  blue:
    labelNetwork:
      definitions:
      - bridge:
          targetName: br2
          type: Bridge # Something brings in the bridge on these nodes
        nodeSelector:
          "dc": "1"

Here a mixture, where the same blue network is set up via different mechanisms on different node sets:
networks:
  blue:
    labelNetwork:
      definitions:
      - bridge:
          targetName: br2
          type: Bridge # Something brings in the bridge on these nodes (e.g. oci hook)
        nodeSelector:
          "dc": "1"
      - bridge:
          targetName: br2
          nodeTargetName: brxyz
          type: BridgeOrCreate # virt-handler has to setup the bridge
        nodeSelector:
          "dc": "2"

Finally an example for network devices which may be brought in via a k8s device plugin:
networks:
  random.device.io/green:
    devicePluginNetwork:
      definitions:
      - bridge:
          targetName: br2
          type: Bridge # we juste consume the bridge should just be there

virt-controller would in this case simply add a resource to the pod. virt-handler can pick up this definition whenever it encounters a VMI which references the random.device.io/green network.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

@yuvalif @petrkotas this finally closes the loop regarding to creating and defining brige networks.
This also highlight on how finally something like device plugin network plugins can be integrated, since to goal is not to move "everything" to kubevirt.
Still I suggest to not use any device plugin right now for anything which the current API is not meant for to reduce the amount of moving parts, complexity and hack which do not lead to a better domain specific representation.

@rmohr I like where you're headed with this. Here are a few thoughts.
First, Instead of making the kubevirt-config configmap a CRD, should we instead be considering a CRD to describe networks at the cluster level for KubeVirt? Essentially a ‘VirtualMachineNetwork’ object that’s a logical representation of a network source available for VMIs to consume?
Second, I’m getting hung up on the “BridgeOrCreate” type. From what I gather that’s a network type that represents attaching a bridge on the host to a VMI using a veth pair. Why not just call it ‘type:HostBridge’? So “Bridge” would represent a bridge within the container for the VMI to consume, and “HostBridge” would represent a bridge on the host that kubevirt needs to attach the VMI to.
I like how this concept pretty seamlessly ties into the concept of network device plugins. The KubeVIrt network abstraction simply tells KubeVirt how to properly attach to a network resource provided as a plugin.

regarding extensions, why not use the existing network CRD: https://docs.google.com/document/d/1Ny03h6IDVy_e_vmElOqR7UdTPAG_RNydhVE1Kx54kFQ/ ?


Allow a flag for setting a decrement index base value to the ex-date of the underlying tr

It seems consensus is that this will be kept as an input.


trying to fix tox issue causing failures

resolves #536
Description
errors in workflow caused by old python version
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Question? how far up would we want to upgrade the python version? any preferences here?

I think 3.8+ is reasonable. 3.7 is being dropped by many projects. I would also include 3.10: https://github.com/dbt-labs/dbt-spark/blob/main/setup.py#L93 Python 3.11 has been released recently but hasn't been adopted widely by downstream dependencies, so that might be a bit challenging.


Inconsistent behavior in 2d 4-directional movement

Godot version
3.4.1 stable
System information
Arch Linux 5.15.10, ryzen 5 5600g, mesa 21.3.2
Issue description
When manually setting velocity of KinematicBody2d, in-game actual behavior is not consistent with expected behavior.
Expected behavior:
While holding "move_right" bind, and with player running right, pressing "move_down" should move player down.
While holding "move_down" bind, and with player running down, pressing "move_right" should move player right.
Actual behavior:
While holding "move_right" bind, and with player running right, pressing "move_down" moves player down.
While holding "move_down" bind, and with player running down, pressing "move_right" moves player down.
Steps to reproduce
Player movement script is slightly modified version of what is found on the website. This is player.gd, attached to a kinematicbody2d that is the player character.

extends KinematicBody2D

export (int) var speed = 200

var velocity = Vector2()

func get_input():
	velocity = Vector2()
	if Input.is_action_pressed("right"):
		velocity.x += 1
		velocity.y = 0
	if Input.is_action_pressed("left"):
		velocity.x -= 1
		velocity.y = 0
	if Input.is_action_pressed("down"):
		velocity.y += 1
		velocity.x = 0
	if Input.is_action_pressed("up"):
		velocity.y -= 1
		velocity.x = 0
	velocity = velocity.normalized() * speed

func _physics_process(delta):
	get_input()
	velocity = move_and_slide(velocity)

Minimal reproduction project
minimal_project.zip

if Input.is_action_pressed("down"):
		velocity.y += 1
		velocity.x = 0

^ This gets executed after moving right and resets horizontal position.
Closing, as it's not engine bug. Next time try other community platforms first to make sure this is Godot issue.

if Input.is_action_pressed("right"):
    velocity.x -= 1
    velocity.y = 0

should also reset vertical velocity, but it does not.

Oh, I see what you're saying now. Order of operations here will basically move my so called bug to other directions. Thanks, sorry to bother you!


Emit a better error message when a command failed to execute.

I hit this when 'perl' wasn't installed on my windows machine, when trying to cargo install gitui.
The long and verbose output made it hard to notice the actual error (program not found) hiding in the panic message.
It's still verbose, but the better formatting should improve readability.
Before:
error: failed to run custom build command for `openssl-sys v0.9.72`

Caused by:
  process didn't exit successfully: `D:\Dokumente\Rust\gitui\target\debug\build\openssl-sys-3446ba0d2783aba7\build-script-main` (exit code: 101)
  --- stdout
  [ ... ]

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: NotFound, message: "program not found" }', C:\Users\Julian\.cargo\registry\src\github.com-1ecc6299db9ec823\openssl-src-111.17.0+1.1.1m\src\lib.rs:477:39
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

After:
error: failed to run custom build command for `openssl-sys v0.9.72`

Caused by:
  process didn't exit successfully: `D:\Dokumente\Rust\gitui\target\release\build\openssl-sys-76722f0f88dd29d1\build-script-main` (exit code: 101)
  --- stdout
  [...]

  --- stderr
  thread 'main' panicked at '

  Error configuring OpenSSL build:
      Command: "perl" "./Configure" "--prefix=D:\\Dokumente\\Rust\\gitui\\target\\release\\build\\openssl-sys-e94b178bbce3b1da\\out\\openssl-build\\install" "no-dso
" "no-shared" "no-ssl3" "no-unit-test" "no-comp" "no-zlib" "no-zlib-dynamic" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "no-engine" "
no-asm" "VC-WIN64A"
      Failed to execute: program not found

      ', D:\Dokumente\Rust\openssl-src-rs\src\lib.rs:484:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

Thanks!


Flashing a Hue White Ambiance bulb causes a flashing loop

I added a group containing 1 Hue White Ambiance bulb and selected the flash option on the tile and it triggered a rapid flashing loop, at one point it got so fast I had to switch the bulb off at the switch and remove the group from the smart app to resolve.
This bulb/room is also controlled  by a Hue motion sensor which automatically turns it off after 1 minute of inactivity but the flashing loop started instantly. This was an extract from the IDE logs:
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:45 PM: trace Hue B Smart Lux Group: flash():
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:45 PM: trace Hue B Smart Lux Group: updateStatus ( alert:lselect )
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: debug GROUP: devId = 0017882B83F3/GROUP3
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: debug k = /groups/3/action/alert, split1 = groups, split2 = 3, split3 = action, split4= alert, value = lselect
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: trace [/groups/3/action/alert:lselect]
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:44 PM: trace Hue B Smart Lux Group: flash():
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:44 PM: trace Hue B Smart Lux Group: updateStatus ( alert:lselect )
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: debug GROUP: devId = 0017882B83F3/GROUP3
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: debug k = /groups/3/action/alert, split1 = groups, split2 = 3, split3 = action, split4= alert, value = lselect
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:44 PM: trace [/groups/3/action/alert:lselect]
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:44 PM: trace Hue B Smart Lux Group: flash():
e4d040d2-1eac-4cf2-bb4b-92e0cc13e824  6:35:44 PM: trace Hue B Smart Lux Group: updateStatus ( alert:lselect )
1bd3e7c4-2685-4c37-9750-8c8deda3f213  6:35:44 PM: trace getPhrases(), state.welcomeIssue = null
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:43 PM: debug GROUP: devId = 0017882B83F3/GROUP3
b75e6be3-1d1d-4633-a18f-08ab1abfaef7  6:35:43 PM: debug k = /groups/3/action/alert, split1 = groups, split2 = 3, split3 = action, split4= alert, value = lselect

You may want to make sure your DTH's are up to date, and if they are then ensure the bulbs are of the correct type - the above mentions:
race Hue B Smart Lux Group: flash():
Hue B Smart Lux Group: updateStatus
If the bulbs are ambiance then you should change this in the IDE from devices / edit device to Hue B Smart Ambiance Bulb.
cheers
matt

I can confirm I have the most recent DTH's - for some reason they are being discovered as LUX bulbs when they are not. Changing them as you suggested resolved it

glad it's working now.
cheers
matt


Add missing fields to the user model

This PR adds some missing fields to the user model in floorsense.

Thanks @w-le  , if we keep the privacy one there, would it break anything?

yep I don't think it will break anything so I've approved the PR. We'll let @stakach review as well since he is much more familiar with this driver.


Improper placement of Bar graph when not in full screen mode

The Bar graphs are not placed properly. It can be reproduced if you exit full screen or increase the zoom of web browser.

Do you how can we edit changes in this landscape page??...I mean I didn't found any html file or any such file that runs as this website.

@tehami02 lets wait for a maintainer to comment on this

/assign

Hi!
We've just migrated the CNCF landscape to v2 and this issue probably no longer applies.
Please feel free to reopen if needed 🙂


Cleanup in WagtailAPI module

See commit log

I'll split this up into 4 PRs

Cleanup
Replacing custom renderer with WagtailAPIRouter
Allow "_" GET parameter
DRF browsable API

Split up. Couldn't deserialise the changes much though

What's about django-rest-framework?


Error running build - Spago + language release problem?

Problem
I started getting this issue after I switched to using Spago and a newer PS release came out. I later switched to a new computer and still get the same problem.
After opening a project, I run the build command and get the following error message:
Error running build: Nothing : (Just "/home/user/path/project/")
PureScript (purescript-language-server) /home/user/path/project/

I cannot figure out where that error message appears in the code.
Workarounds

See my later comment
See my concluding comment

Environment info
# Main programs
node: v10.15.3
npm: 6.9.0
purs: 0.12.5
spago: <IP_ADDRESS>
dhall-to-json: 1.2.7

# Atom specifically
Atom    : 1.36.1
Electron: 2.0.18
Chrome  : 61.0.3163.100
Node    : 8.9.3

# Atom packages
atom-ide-ui: 0.13.0
ide-purescript: 0.25.0
language-purescript: 0.9.0

# build command used
spago build -- --json-errors

# OS
Linux Mint 19.1

(Other unrelated content below)

For more context, I sometimes have my learning repo opened at its root directory:
root
- spago project
-- src
-- test
- spago project
- etc...

I open an individual spago project when I need the code completion and whatnot. I'm not sure whether this affects things or not.

Update: not sure why this seems to work, but if I edit a .purs file, save it, and then build the project,
things work fine.

If anything needs to change on upgrading compiler version, I'd thought it was rm -rf output/*
I'd expect opening a project at the root directory to not give completion etc, but not particularly screw things up - actually what you can do is add the spago project as a workspace folder (and move it above the root folder) to have everything open at once with IDE support, I use things like this regularly.
If you are seeing inconsistent behaviour, are there multiple versions of purs available perhaps, eg one from npm somewhere? If you are ending up using different versions from the plugin, from command line, from build etc things may get weird

On this computer, I only have 0.12.4 installed.
I just nuked the output folder to ensure that wasn't causing an issue. However, the issue still arises.
I also opened a project where the project structure is what one would expect in a Spago-based project.
I've found that this workaround is always reliable:

open atom via atom -f
build the project (which fails)
switch to a new file tab that I wasn't looking at before
make a small change (e.g. add a space character)
save the file
build the project (it now builds)

Perhaps there's a caching issue somewhere?

I had a similar problem. I followed (some of) the instructions on https://qiita.com/kimagure/items/570e6f2bbce5b4724564 and that helped. I was missing psc-package. Perhaps that is the same problem?

Thanks for the tip @bblfish. I just tried that, but it did not change anything.

I have another update on this.
First, using my workarounds makes the project build. This means this project is working as expected in at least some situations.
Second, I learned that when I start Atom via the command atom, then this issue arises. However, if I pass it some other commands (e.g. atom -f atom -l atom --enable-electron-logging), then the project builds fine.
So, I think the issue at hand here is something related to Atom, not this project. I'll close this issue for now and edit my original post to link to this comment.

I just picked up development after about a month hiatus and ran into this issue. For me this is what solved it:

Upgraded node from 9.2.0 to 10.15.3 (using nvm)
Updated npm to 6.9.0 (using nvm)
Updated purescript to 0.12.5 (using npm)
Updated pulp to 12.3.1 (using npm)
In the settings of ide-purescript in atom, change the build command from my custom one to the default one. I tried this because of this two year old recommendation, even though my build was working normally merely two months ago. I must have updated atom or a package requiring a later version of psc at some point during the last month without realizing the consequences.

Another factor that might be relevant here... I believe I installed Node via nvm on the new computer rather than manually downloading and installing it on my previous one. @AndrewBrownK Did you install node through that manner as well?

I know this issue is closed, but I recently ran sudo apt-get purge atom, reinstalled it, and this problem went away. So, perhaps I installed an older version of atom at one time, and created a desktop entry that worked for that version of atom. Then, perhaps they released a newer version of atom and when I upgraded to that version, the desktop entry did not also get updated...?


docs(rfc): add declarative configuration rfc

What this PR does / why we need it
This PR adds an RFC for moving to declarative configuration/better structuring devbase in general. This is also the first test of an RFC like system for large scale changes like this.
The idea of an "RFC" is that it will be merged before the work is done on a project, and will contain references to PRs and timelines/plans for a feature. This allows it to gather feedback during the proposal stage, and during implementation for the design to be reviewed/referenced.
RENDERED PREVIEW

Also, I think this RFC process works really well.


python dependency issues

During install, there appear to be some impossible-to-satisfy dependencies.
cat /etc/issue
Ubuntu 16.04.4 LTS

mostly boto3 issues:
boto3 1.7.7 has requirement botocore<1.11.0,>=1.10.7, but you'll have botocore 1.10.6 which is incompatible.
[...]
python -m pip install --no-cache-dir botocore==1.10.6
[...]
dcos-e2e 2<IP_ADDRESS>+98.g17edfcf has requirement botocore==1.10.6, but you'll have botocore 1.10.7 which is incompatible.

and so on.

Solution for a clean install on Ubuntu 16.04:
install pip3 and libssl-dev
alias python to python3
alias pip to pip3
clean build / install after that.


Support SQS in Event-Info (Fixes #89)

This is initial work on support for SQS events.

I believe this is ready for review, it is working properly.


Path search fix

Added searching of external modules for Cython files that need coverage to be checked. In my case, my test suite was accessing my code via an addition to the PYTHONPATH, so the code being tested wasn't directly visible below the test directory. For this case the plugin couldn't find the .pyx files.
This PR will also allow absolute imports. Before, given a directory structure like /foo and /foo/bar, if a Python file in /foo was importing a Cython module in /foo/bar as import bar.cy_module, the plugin worked fine, but if the import was import foo.bar.cy_module, the plugin failed.
Finally, fixed a bug that resulted in a non-Cython C file with the same name as a Python file (like foo.c and foo.py, where foo.c is not from Cython) to disable the plugin.

Thanks for these improvements!


iOS Flutter.podspec version fixed to 1.0.0

Steps to reproduce
Run pod install in any Flutter project, Flutter sdk installed always point to version 1.0.0 on Flutter.podspec, regardless of the Flutter version used. I am currently using Flutter version 3.3.10, and this gets translated into the Podfile.lock.
This is an issue for my project, since we are trying to use automated tools like syft with grype to check for vulnerabilities on our dependencies.
Since it takes an incorrect Flutter version and for that it throws false positives on older versions vulnerabilities like this one.
Some form of this issue was raised in this closed issue.
Expected results
Flutter.podspec
#
# NOTE: This podspec is NOT to be published. It is only used as a local source!
#       This is a generated file; do not edit or check into version control.
#

Pod::Spec.new do |s|
  s.name             = 'Flutter'
  s.version          = '3.3.10'
  s.summary          = 'A UI toolkit for beautiful and fast apps.'
  s.homepage         = 'https://flutter.dev'
  s.license          = { :type => 'BSD' }
  s.author           = { 'Flutter Dev Team' =><EMAIL_ADDRESS>}
  s.source           = { :git => 'https://github.com/flutter/engine', :tag => s.version.to_s }
  s.ios.deployment_target = '11.0'
  # Framework linking is handled by Flutter tooling, not CocoaPods.
  # Add a placeholder to satisfy `s.dependency 'Flutter'` plugin podspecs.
  s.vendored_frameworks = 'path/to/nothing'
end

Podfile.lock
  - ....
  - Flutter (3.3.10)
  - ....

Actual results
Flutter.podspec
#
# NOTE: This podspec is NOT to be published. It is only used as a local source!
#       This is a generated file; do not edit or check into version control.
#

Pod::Spec.new do |s|
  s.name             = 'Flutter'
  s.version          = '1.0.0'
  s.summary          = 'A UI toolkit for beautiful and fast apps.'
  s.homepage         = 'https://flutter.dev'
  s.license          = { :type => 'BSD' }
  s.author           = { 'Flutter Dev Team' =><EMAIL_ADDRESS>}
  s.source           = { :git => 'https://github.com/flutter/engine', :tag => s.version.to_s }
  s.ios.deployment_target = '11.0'
  # Framework linking is handled by Flutter tooling, not CocoaPods.
  # Add a placeholder to satisfy `s.dependency 'Flutter'` plugin podspecs.
  s.vendored_frameworks = 'path/to/nothing'
end

Podfile.lock
  - ....
  - Flutter (1.0.0)
  - ....

Flutter Doctor output
Doctor output

┌─────────────────────────────────────────────────────────┐
│ A new version of Flutter is available!                  │
│                                                         │
│ To update to the latest version, run "flutter upgrade". │
└─────────────────────────────────────────────────────────┘
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.10, on macOS 14.1 23B2073 darwin-arm, locale en-CL)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.91.1)
[✓] Connected device (5 available)
[✓] HTTP Host Availability

• No issues found!

@joaquinricci
did you try following the steps provided in this comment?

I checked this on a newly created Flutter project on the latest stable 3.24.1 and master channels 3.25.0-1.0.pre.130, installed a plugin like camera: ^0.11.0+2 to install a pod and see Flutter.podspec keeps version 1.0.0 as well.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6 23G80 darwin-x64, locale en-VN)
    • Flutter version 3.24.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5874a72aa4 (5 days ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode15.4.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio Koala.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] IntelliJ IDEA Ultimate Edition (version 2<IP_ADDRESS>)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.20629

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.6 23G80 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 128.0.6613.85

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.25.0-1.0.pre.130, on macOS 14.6 23G80 darwin-x64, locale en-VN)
    • Flutter version 3.25.0-1.0.pre.130 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9308a799c6 (6 hours ago), 2024-08-25 13:58:24 -0700
    • Engine revision 365b0c70fa
    • Dart version 3.6.0 (build 3.6.0-175.0.dev)
    • DevTools version 2.39.0-dev.15
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode15.4.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio Koala.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] IntelliJ IDEA Ultimate Edition (version 2<IP_ADDRESS>)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.20629

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.6 23G80 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 128.0.6613.85

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

The comment in the issue you linked https://github.com/flutter/flutter/issues/85820#issuecomment-874103549 is still true:

This Podspec is generated when you execute flutter pub get in a module, this is not published, this is simply generated for the native app.
s.version = '1.0.0' doesn't present any particular Flutter release, this is probably just a default version source

Thanks for explaining your use-case.
Flutter is currently in the process of migrating from CocoaPods to Swift Package Manager, and CocoaPods has moved into maintenance mode.  As such, we are unlikely to start publishing a pod, or change this behavior.
To workaround you can either:

Exclude Flutter from your automated dependency checker.
Replace the podspec in your checkout with one that removes the version and instead points to the remote zip file.  You can run flutter build ios-framework --cocoapods --release to see an example Flutter.podspec. The code that generates it is here:
https://github.com/flutter/flutter/blob/7362d07cb0c812bd8aabad5dcc81973f68099007/packages/flutter_tools/lib/src/commands/build_ios_framework.dart#L373

Thanks for the replay.


should consider weather the len(el.Points) is 0

https://github.com/prometheus/prometheus/blob/c28b9a05741d499fcbcca56165d96fd2d39a8f0e/promql/functions.go#L413

Those validations would be already done before reaching this point. Have you found any way to make this line fail?

Yes,i have found the code,thanks

Closing this issue since the check is not required - should be validated already before reaching this line.


JAV-38 changed log timestamp format

with current timestamp format in logger, docker maven plugin has trouble grabbing the expected log

Changes Unknown when pulling 289d4503573b925f8107f04d1e7058e645ceca1c on JAV-38_log_timestamp into ** on master**.


Use canned JSON responses in mock

TODO:

tests
could this completely replace the Tezos mock infra?
RPC mocks might be a lot more complicated
Figure out what the right paths are for Docker usage

Thanks for the work on this. I've taken inspiration from this in #49, which has been merged now - so closing this.


add Indonesia Readme

Pull Request Status

[x] WIP

Description
Short summary of the changes and goals of this pull request.
Todo's

[X] Todo 1
[ ] Todo 2

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #4   +/-   ##
========================================
  Coverage      92.5%   92.5%
  Complexity       34      34
========================================
  Files             5       5
  Lines            80      80
========================================
  Hits             74      74
  Misses            6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6678499...ad73f7d. Read the comment docs.

Awesome work 👍


Refactor client push into helper function

Related to use case for: #2075
After using a schema1 to schema2 converter, the blobs are written to the content store. In order to migrate schema1 manifests stored on a registry, they need to converted and then re-pushed. In (*Client).Push the client's content store is used, but could be refactored out to take a content.Provider. This PR refactors it out so that outside of client, PushContent helper can be used to push content specified by a descriptor from a content.Provider.

Last commit is missing DCO

LGTM

LGTM


Close Apps on Disconnect

I've had some requests to make this script cause apps to close on disconnect like the native ProXPN clients do. I don't believe there is a way to do this with OpenVPN itself but there might be another way to notify processes if given their ID or name?
This issue is to brainstorm possible solutions

xargs + killall with a list of command names seems like the simplest way to do this off the top of my head.
The problem would be getting a trigger. Does openvpn return when the connection is lost, or does it prompt to reconnect?

Usefull: https://github.com/primaryobjects/vpndemon

VPNdemon relies on networkmanager to detect when the tunnel interface goes down, so if you are aiming for portability you'll need to find a cross platform method.
I had thought using netcat might work: run it as a server listening on the VPN connection and have it return when the interface it was listening on goes down, but at least in the implementation of nc I have, I just keeps listening and never returns.

Yeah it's a bummer the demon is NetworkManager based though mostly I was curious to see the structure of the script itself.
Worst case, if a cross platform method doesn't shake out we can maybe document third party alternatives on various OS's

Wanted to toss my two cents on this conversation.
I use the openvpn native feature 'down' and 'down-pre' to fire scripts that I want executed when a proxpn tunnel is torn down.
It does require that you also have 'script-security' set to 2 at the minimum, which is something to be mindful of.
But I'm finding the 'down script' automation works well enough as long as the openvpn thread gets a SIGTERM signal. ((Apparently SIGQUIT doesn't cause it to fire the 'down script'))
After a couple hours tinkering I have the proxpn bash client running as an init-script. That, after some small changes to /usr/local/bin/proxpn where it reads in the proxpn.ovpn config file. I wanted to move the .ovpn and other config files to /etc/proxpn where they could assume a more service-y type role.
Service goes up, and I'm on the VPN.
Service goes down, and the openvpn Down trigger executes the script provided.
It's pretty rough, and I'd like to refactor openvpn to shed root privileges after launch (which requires some specially crafted sudoers rights for the _openvpn user account to access route and ifconfig), but it works neatly enough.

Sorry for the late reply here, but I've been playing around with down and down-pre as well but wasn't sure how to handle those cases where the down scripts don't run. Haven't found anything better than what you've suggested here.
The trickiest thing I think is how to help folks configure the programs they want killed if the VPN goes down. What is that user experience?


Deep refactoring

Overview
@pwalsh's wrote:
goodtables is very little apart from tabulator + jsontableschema + data-quality-spec + an output report.

Of course there will be issues when you port, but the bottom line is we’ll probably reduce 100s to 1000s of lines of code, some inconsistent internal APIs, and you’ll likely also learn some edge cases and stuff for tabular data handling that can feed back into tabulator

the important thing is: goodtables is the basis for a product, and it is more important, right now, to move on shipping goodtables than to get the other libs to v1, etc

getting them to v1 can be a by-product of goodtables, not the other way around

just because there is lots of interest in goodtables, and before we start the test pilots around GT from beg. October onwards, it would be better to be on a stabler base, as the GT needs serious refactoring by now with all we learned
---
`goodtables.datatable`: completely replace with `tabulator`, but in the code of datatable, might be some edge case handling that is useful, so check it.

- https://github.com/frictionlessdata/goodtables/tree/master/goodtables/datatable
- also in georgiana’s branch she found some more error handling edge cases here ( https://github.com/georgiana-b/goodtables/commit/7e9da1e480938b9c197e91e5d9c79ccbc5c12fa8 )
----
`goodtables.cli`: should be easy, and I assume you will have good ideas

- https://github.com/frictionlessdata/goodtables/tree/master/goodtables/cli
----
`goodtables.pipeline.Pipeline`: Pretty easy once datatable is replaced by tabulator, and now using jsontableschema-py to replace lots of hardcoded stuff

- https://github.com/frictionlessdata/goodtables/blob/master/goodtables/pipeline/pipeline.py
----

`goodtables.pipeline.Batch`: *very* useful batch pipeline runner. Needs proper parallelization

- https://github.com/frictionlessdata/goodtables/blob/master/goodtables/pipeline/batch.py
- georgiana tried to parallelize here but forgot about shared state: https://github.com/georgiana-b/goodtables/commit/5514c3cb769c54a5dbe415df61cf406812600c83
----

`goodtables.processors`: they will essentially be tabulator processors I guess. Again, some hard coded stuff from before we had libs, or really understood the desirable API design. A `pipeline` calls processors, and note we also have an API for custom processors - the tabulator API for that is better

- https://github.com/frictionlessdata/goodtables/tree/master/goodtables/processors (edited)
---
Reports: GoodTables generates reports, and has a few output formats, as well as some tricky (ugly) stuff to shape the output. I absolutely encourage you to break the API of reports for something better, and even preferable, a format that can be streamed (emit report objects as they occur - if possible…)

- `tellme`: rufus wanted me to make that a distinct lib: IMHO it is not really worth it: https://github.com/okfn/tellme but it is what is used for report objects
- “report results”: you’ll see various places with report result definitions ( eg: https://github.com/frictionlessdata/goodtables/blob/master/goodtables/processors/schema.py#L11 ), including recent ones that that georgiana added in unusual places. these should be replaced by use of the new, generic `data-quality-spec`
- data-quality-spec: https://github.com/frictionlessdata/data-quality-spec (edited)
---

- note `self.report` and `def set_report_meta` here: https://github.com/frictionlessdata/goodtables/blob/master/goodtables/pipeline/pipeline.py#L280 (edited)

inspect with ipdb on some sample datasets and you’ll see what goes on there

a better design can come out of seeing what we have there

------

Lastly! “Hooks”! I built a simple hook system into `pipeline.Pipeline` and `pipeline.Batch`: both take a `post_task` argument. We use this, for example, in `data-quality-cli` and also in `goodtables-web` to modify reports. At the time, I kind of needed it, but I am honestly not sure any more if it is required… maybe better way to solve same problem:

- https://github.com/frictionlessdata/goodtables/blob/master/goodtables/pipeline/pipeline.py#L79

Expect full estimate 22nd Sept

@roll maybe dump some of my original notes in here too

@pwalsh
will do, thanks

@jobarratt
First working version - end of this sprint looks realistic for me.

@pwalsh
@akariv
@cyberbikepunk
@georgiana-b
Here's my working branch for goodtables.next. Goals are to simplify user interface and framework internally, make checks testable separately, add parallel execution and use tabulator and jts in a full strength.
https://github.com/roll/goodtables-next
https://roll.github.io/goodtables-next-web/ (for testing but not really ready)

Forgot one thing - 100% streaming. Every row from source we read only once (using http stream without additional requests etc)

Currently there are some redundant checks that might be confusing for users:
Ex: For the header: first_name,,age, I get this result:
{'table-count': 1,
 'tables': [{'error-count': 3,
             'errors': [{'code': 'blank-header',
                         'error-number': 1,
                         'field-number': 2,
                         'message': 'Header for field number 2 is blank'},
                        {'code': 'blank-header',
                         'error-number': 2,
                         'field-number': 4,
                         'message': 'Header for field number 4 is blank'},
                        {'code': 'duplicate-header',
                         'error-number': 3,
                         'field-number': 4,
                         'message': 'Header for field number 4 is '
                                    'duplicated'}],
             'headers': ['first_name', '', 'age', ''],
             'row-count': 0,
             'time': 0.004,
             'valid': False}],
 'time': 0.005,
 'valid': False}

Some suggestions for the spec:

DuplicateRow should require BlankRow
Duplicate Header should require Blank Header
Non-Matching Headers and Badly Ordered Headers should require Missing Headers

This is mostly a matter of high level requirements, but it's worth bringing up since these errors will contribute to the data quality score.

@georgiana-b
good catch - in this current situation we just should not count empty strings as duplicate but still thinking is it possible to have such a granular checks or it's not possible and we should fall back to thinks like table_check, head_check, body_check. Because we need field granularity. It will make the framework not so modular.

@pwalsh
https://github.com/frictionlessdata/goodtables-py/tree/next-initial#profiles
https://github.com/frictionlessdata/goodtables-py/tree/next-initial#is-it-possible-to-use-custom-profile

Fixed in https://github.com/frictionlessdata/goodtables-py/tree/next
next will be tested for several weeks now before we merge onto master.


Further changes adding more guidance for developers on apks

@PaulKinlan This is marked 'do not merge'. Do you need help to move this forward?

@jpmedley not right now, I am waiting on some product decisions.

@petele this is ready from my side. More updates will follow.

Conflicts resolved. @petele @jpmedley

will push live Tuesday AM


Add linting for subprocess.run

Fixes #24
Note: subprocess.run is available only from Python 3.5+

Thank you!


fixing typo with emptyDirs method

It appears the withEmptyDir method is broken due to a typo and attempting to use either signature results in a groovy script error. I've fixed the typo and it works for me now.

Thanks for spotting and fixing!


CHEF-11807 Chef license Usage Telemetry

Description

Adds EULA-specified usage telemetry to Chef Infra.
This telemetry relates to the consumption of the licenses and is being collected under section 1.12 of the EULA. You may also refer to our privacy policy.
Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Adding some additional context to what @johnmccrae said. You'll also want some testing to confirm that the "telemetry disabled when commercial license is present" case, as that's definitely something where you don't want inadvertant regressions. I haven't checked what the failure case is re: license corrupted/missing entirely (Chef Infra Client 19's scope is creeping quite a bit :-/), but given all this data getting pumped out by the host, it would be worth adding a 'fail hard if telemetry isn't disabled at run start' config option for customers who have security/compliance requirements but also have network egress open for whatever reason. Disks go bad, and sending internal info because of a bitflip would be a Real Bad Day for a customer if it happened.

The only way for us to verify whether a customer is a commercial user is by using the license information stored in the licenses.yaml file on disk. If that file becomes corrupted or encounters any issues, the licensing integration will raise an error, and ideally, the execution will not proceed to the point where telemetry is triggered. This would serve as the “fail hard” mechanism in this case. This is the same approach we've been following for InSpec as well—if something goes wrong with the license, telemetry calls are never made. I'll ensure that this remains the case for Chef Infra too.
Within the telemetry logic, there’s already a safeguard to ensure that no data is sent to commercial users. I will thoroughly test this scenario to confirm that the flow functions as expected.
Additionally, every time a telemetry call is made, all related progressions can be viewed in the debug log, providing transparency for users about what data is being processed and sent.

Is there any option for anonymizing the telemetry data? The telemetry captures a LOT of data in the run context. There is a valid concern that Progress/Chef will be receiving all kinds of details about cookbooks, passwords, etc that we really don't need to know about and that don't affect our license management. Also, the volume of data would be really substantial - is there any throttling? What happens when 10,000 nodes send their data every 30 minutes?

Are there concerns around specific data points where you would like to suggest more anonymity? The data that we are sending today is well discussed and if any specific field in that json structure you think needs more changes, can you point to that?
Currently, there is no throttling mechanism in place for telemetry. We send this data after every run, but we’ll need to assess the volume of data that the telemetry service can handle, especially as the number of nodes scales.

@Nik08 can you setup a brief internal meeting and attach a few examples output of the job usage data, with a few different runlets sizes. We need to do a data security review and seeing the output will be a bit easier/faster then guessing from all the code

From PR Review meeting: it seems like this is still awaiting the results of the internal discussion that happened? We're skipping review for this week.

From PR Review meeting: it seems like this is still awaiting the results of the internal discussion that happened? We're skipping review for this week.

We have made some reviews of the data after our internal discussion and I have pushed those changes here. One community discussion is going on here https://github.com/chef/chef/pull/14511#discussion_r1820583786

@Nik08 can you setup a brief internal meeting and attach a few examples output of the job usage data, with a few different runlets sizes. We need to do a data security review and seeing the output will be a bit easier/faster then guessing from all the code

@Nik08  and @GeorgeWestwater  did anything come of this meeting? Any action items we need to address?


Quickstart example fails with Java>1.8

Related to #191, but I cannot reopen that issue.
Building the quickstart example succeeds. But when running the jar, several OSGI errors appear due to several unresolved Import-Packages. At the end, it traces down to the fact that all the javax.* packages were removed from the JDK between version 1.8 and version 11. So, any modern JDK will fail to run.
I am working on a PR.
! Failed to start bundle org.osgi.enroute.examples.quickstart.rest-<IP_ADDRESS>309181042, exception Could not resolve module: org.osgi.enroute.examples.quickstart.rest [14]
  Unresolved requirement: Require-Capability: osgi.contract; osgi.contract="JavaJAXRS"; filter:="(&(osgi.contract=JavaJAXRS)(version=2.1.0))"
    -> Provide-Capability: osgi.contract; version:List<Version>="2.1.0,2.0.0,1.1.0"; osgi.contract="JavaJAXRS"; uses:="javax.ws.rs,javax.ws.rs.client,javax.ws.rs.container,javax.ws.rs.core,javax.ws.rs.ext,javax.ws.rs.sse"
       org.apache.aries.javax.jax.rs-api [3]
         Unresolved requirement: Import-Package: org.apache.geronimo.osgi.registry.api; resolution:="optional"
         Unresolved requirement: Import-Package: javax.xml.bind.annotation
  Unresolved requirement: Import-Package: javax.ws.rs
    -> Export-Package: javax.ws.rs; bundle-symbolic-name="org.apache.aries.javax.jax.rs-api"; bundle-version="1.0.4"; version="2.1.0"; uses:="javax.ws.rs.core"
  Unresolved requirement: Require-Capability: osgi.implementation; filter:="(&(osgi.implementation=osgi.jaxrs)(version>=1.0.0)(!(version>=2.0.0)))"
    -> Provide-Capability: osgi.implementation; version:Version="1.0.0"; osgi.implementation="osgi.jaxrs"; uses:="javax.ws.rs,javax.ws.rs.core,javax.ws.rs.ext,javax.ws.rs.client,javax.ws.rs.container,javax.ws.rs.sse,org.osgi.service.jaxrs.whiteboard"
       org.apache.aries.jax.rs.whiteboard [10]
         Unresolved requirement: Import-Package: javax.activation

org.osgi.framework.BundleException: Could not resolve module: org.osgi.enroute.examples.quickstart.rest [14]
  Unresolved requirement: Require-Capability: osgi.contract; osgi.contract="JavaJAXRS"; filter:="(&(osgi.contract=JavaJAXRS)(version=2.1.0))"
    -> Provide-Capability: osgi.contract; version:List<Version>="2.1.0,2.0.0,1.1.0"; osgi.contract="JavaJAXRS"; uses:="javax.ws.rs,javax.ws.rs.client,javax.ws.rs.container,javax.ws.rs.core,javax.ws.rs.ext,javax.ws.rs.sse"
       org.apache.aries.javax.jax.rs-api [3]
         Unresolved requirement: Import-Package: org.apache.geronimo.osgi.registry.api; resolution:="optional"
         Unresolved requirement: Import-Package: javax.xml.bind.annotation
  Unresolved requirement: Import-Package: javax.ws.rs
    -> Export-Package: javax.ws.rs; bundle-symbolic-name="org.apache.aries.javax.jax.rs-api"; bundle-version="1.0.4"; version="2.1.0"; uses:="javax.ws.rs.core"
  Unresolved requirement: Require-Capability: osgi.implementation; filter:="(&(osgi.implementation=osgi.jaxrs)(version>=1.0.0)(!(version>=2.0.0)))"
    -> Provide-Capability: osgi.implementation; version:Version="1.0.0"; osgi.implementation="osgi.jaxrs"; uses:="javax.ws.rs,javax.ws.rs.core,javax.ws.rs.ext,javax.ws.rs.client,javax.ws.rs.container,javax.ws.rs.sse,org.osgi.service.jaxrs.whiteboard"
       org.apache.aries.jax.rs.whiteboard [10]
         Unresolved requirement: Import-Package: javax.activation

        at org.eclipse.osgi.container.Module.start(Module.java:463)
        at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:439)
        at aQute.launcher.Launcher.start(Launcher.java:686)
        at aQute.launcher.Launcher.startBundles(Launcher.java:666)
        at aQute.launcher.Launcher.activate(Launcher.java:572)
        at aQute.launcher.Launcher.launch(Launcher.java:402)
        at aQute.launcher.Launcher.run(Launcher.java:184)
        at aQute.launcher.Launcher.main(Launcher.java:160)
        at aQute.launcher.pre.EmbeddedLauncher.executeWithRunPath(EmbeddedLauncher.java:170)
        at aQute.launcher.pre.EmbeddedLauncher.findAndExecute(EmbeddedLauncher.java:119)
        at aQute.launcher.pre.EmbeddedLauncher.main(EmbeddedLauncher.java:52)

@dmm9 thanks heaps for the issues in PRs you opened. Since OSGi moved to Eclipse, we haven't put much love in enroute. So thanks for bringing it back to our attention. We will look at what you have provided as soon as we are able. Please hang tight.


parser: add plan recreator statement

What problem does this PR solve?
This is a step in tidb/issues/26325
What is changed and how it works?
Add PLAN RECREATOR statement
Check List
Tests

Unit test
Integration test

Code changes

Has exported function/method change

Side effects

Possible performance regression
Increased code complexity

Related changes

Need to update the documentation
Need to be included in the release note

Rest LGTM. BTW, the document is internal, and there is no corresponding RFC on github.

Here is a description of this feature in https://github.com/pingcap/tidb/issues/26325. This is the new feature for Sprint 4, I'll add documents visible to everyone before this feature GA. Is this OK for you?

@rebelice Sure.

/merge


Gas Reports on Fuzz Tests

Component
Forge
Describe the feature you would like
Log gas reports for tests with fuzzing parameters. I have a codebase that's completely fuzz tests and it would be great to get the gas reports without having to rewrite everything with static method params.
Additional context
No response

We should default to using deterministic seed when gas reports are enabled, similar to what is now done with snapshots as of https://github.com/foundry-rs/foundry/pull/2591

Duplicate of #1023


Fix clones of transparent GD images with a color palette

Currently, cloning a transparent GD image with a color palette results in the transparency being changed to black. This happens because of an incorrect conversion to true color, while also not setting the appropriate transparency color.
With this PR, cloned GD color palette images would no longer be converted to true color and keep their transparency intact.

Thank you. There seems to be an error on PHP 7.1, can you fix this before the merge?
https://travis-ci.org/Intervention/image/builds/253050144

Last I checked this was a php 7.1 error / bug with imagecolorat() returning 0 for full transparency instead of 127 or something like that. (I.e. not directly related to this pr)
Sadly I did not yet find time to investigate this further, but local testing on php 7.1 seems to confirm that this is the case.


Feature request: scratch-codes conform to a measure of 'randomness'

Let me start by saying how useful this PAM module is.
I did note, however, that I can add very simple sequences of numbers to the scratch list. For example '12345678' and '11111111' both work (though '00000000' seemingly does not).
Humans being what they are, I'd worry that a lazy user might script something which appends an entirely guessable scratch code to their ~/.google_authenticator file each time they log in.
Is something like a passcode-strength validator viable? The result would be that we only generate and accept passcodes of a certain complexity - in the same way that many online services won't allow me to use the password '111111' or 'abcdef'.
It may be that the simplest solution is a hard-coded dictionary of forbidden passcodes, but that'd at least provide some level of protection.
Cheers
Mike.

If your threat model is that people change their ga config file, then you should change their location and make them not editable by the user. Using options secret & user.
There are too many things the user could do to a config to make it useful to treat them as an adversary.
For a blocklist of passwords, that could probably better be done as a separate PAM module. That way it could be used more generically as well.

Yeah, a combination of the secret and user settings may well help me out here.
Thanks for the guidance!


chore: update smithy4s-sbt-codegen from 0.17.19 to 0.18.4

About this PR
📦 Updates com.disneystreaming.smithy4s:smithy4s-sbt-codegen from 0.17.19 to 0.18.4
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.17.19).
You might want to review and update them manually.
project/Dependencies.scala

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming.smithy4s", artifactId = "smithy4s-sbt-codegen" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.disneystreaming.smithy4s", artifactId = "smithy4s-sbt-codegen" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

Superseded by #238.


[Event Request] Codeunit 22 OnBeforeSetupSplitJnlLine - make TrackingSpecExists a VAR

Currently the TrackingSpecExists parameter is not a var but it is used immediately after the event call.  This eliminates the ability of the event handler to create new tracking specification records.
    OnBeforeSetupSplitJnlLine(ItemJnlLine2, TrackingSpecExists, TempTrackingSpecification);

    if not ItemJnlLine2.Correction and (ItemJnlLine2."Quantity (Base)" <> 0) and TrackingSpecExists then begin
        if DisableItemTracking then begin

[IntegrationEvent(false, false)]
local procedure OnBeforeSetupSplitJnlLine(var ItemJnlLine2: Record "Item Journal Line"; TrackingSpecExists: Boolean; var TempTrackingSpecification: Record "Tracking Specification" temporary)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Notcoin

Rong token address

This issue is not related to the repo and can be closed. @tolya-yanot


How do i serialize RegContact to store in db?

How do i serialize RegContact to store in db?

erlang:term_to_binary/1


feat: TDE-452 create imagery stac item

stac item is created based on a similar implementation in basemaps
pystac was only used to get the stac version, this can be hardcoded and pystac removed entirely, or the code can be changed to return a pystac item object. -pystac removed

nb: The code has been implemented with thought of how the create_stac_items.py script might run for different datasets.
How it is currently written it could be possible to add a datatype dropdown input in the argo workflow and use this datatype to determine what stac to create.
In topo-processor this was premtively scripted, however on reflection the developers mentioned they wouldn't have implemented it until there were additional datasets, therefore it has not been implemented yet in topo-imagery.

this work has been superceeded by:
https://github.com/linz/topo-imagery/pull/133
https://github.com/linz/topo-imagery/pull/132
https://github.com/linz/topo-imagery/pull/134
https://github.com/linz/topo-imagery/pull/135


Add nav listener unregister on app unmount

Applicate the identical patch that was made for frontend-starter-app: https://github.com/RedHatInsights/frontend-starter-app/pull/513

woops, already slammed in a commit before seeing this 😢 😬 🙈


iter: introduce Iterator with configurable concurrency

Adds configurable concurrency via a new type Iterator with ~no overhead and no API changes:
customIterator := iter.Iterator{Concurrency: 42}
customIterator.ForEach(...)

// to use runtime.GOMAXPROCS(0)
iter.ForEach(...)

// zero value is safe, same behaviour as before
iter.Iterator{}.ForEach(...)

If the API is agreeable, I can make a follow-up PR to introduce something similar for Map and friends.
Relevant to https://github.com/sourcegraph/conc/issues/36, closes https://github.com/sourcegraph/conc/issues/55

Before:
go test -run=XXX -bench=. -benchmem ./iter
goos: darwin
goarch: arm64
pkg: github.com/sourcegraph/conc/iter
BenchmarkForEach/0-10   13291378                77.89 ns/op          120 B/op          4 allocs/op
BenchmarkForEach/1-10    2048739               607.5 ns/op           144 B/op          5 allocs/op
BenchmarkForEach/8-10     441230              2843 ns/op             312 B/op         12 allocs/op
BenchmarkForEach/100-10                   278910              4847 ns/op             360 B/op         14 allocs/op
BenchmarkForEach/1000-10                   42801             31772 ns/op             360 B/op         14 allocs/op
BenchmarkForEach/10000-10                   2192            521428 ns/op             397 B/op         14 allocs/op
BenchmarkForEach/100000-10<PHONE_NUMBER> ns/op            4653 B/op         14 allocs/op
PASS
ok      github.com/sourcegraph/conc/iter        10.492s

After:
go test -run=XXX -bench=. -benchmem ./iter
goos: darwin
goarch: arm64
pkg: github.com/sourcegraph/conc/iter
BenchmarkForEach/0-10   13504274                77.28 ns/op          120 B/op          4 allocs/op
BenchmarkForEach/1-10    2133229               560.1 ns/op           144 B/op          5 allocs/op
BenchmarkForEach/8-10     488190              2274 ns/op             312 B/op         12 allocs/op
BenchmarkForEach/100-10                   295342              3770 ns/op             360 B/op         14 allocs/op
BenchmarkForEach/1000-10                   33836             35229 ns/op             360 B/op         14 allocs/op
BenchmarkForEach/10000-10                   2001            618155 ns/op             402 B/op         14 allocs/op
BenchmarkForEach/100000-10<PHONE_NUMBER> ns/op            4948 B/op         14 allocs/op
PASS
ok      github.com/sourcegraph/conc/iter        10.241s

Codecov Report

Merging #63 (8e738ce) into main (f7fb299) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 8e738ce differs from pull request most recent head aa4b42e. Consider uploading reports for the commit aa4b42e to get more accurate results

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   99.45%   99.45%
=======================================
  Files          10       10
  Lines         364      368    +4
=======================================
+ Hits          362      366    +4
  Misses          2        2

Impacted Files
Coverage Δ

iter/iter.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Reanalyze Function in IL view crashes

Null pointer exception in size_t LowLevelILFunction::GetIndexForInstruction(size_t i)  accessing m_instrs.

Fixed in stable.


GetPaymentStatus API method not supported

The PHP SDK is clearly not maintained as well as the REST API itself, so some methods are missing. This issue is specifically for getPaymentStatus.do, because we need it to be able to finish the Web SDK flow.

Implemented!


Adds UUID data type

Fixes #33

Codecov Report

Merging #36 into master will decrease coverage by 0.24%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   91.18%   90.94%   -0.25%
==========================================
  Files          11       11
  Lines         976     1016      +40
==========================================
+ Hits          890      924      +34
- Misses         86       92       +6

Impacted Files
Coverage Δ

lib/src/query.dart
96% <ø> (ø)
:arrow_up:

lib/src/substituter.dart
97.1% <100%> (+0.04%)
:arrow_up:

lib/src/postgresql_codec.dart
83.47% <85.36%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d82d12...f60e3b1. Read the comment docs.


A more detail tutorial

After the model has been trained and PDF files have been downloaded. How can I use the trained model to extract information on PDF files? Thanks.

Hi @abrielLin, GenerateTestDataOnPDFPapers provides methods to generate testing dataset for any PDF papers, you could apply the trained model on these testing data instances and extract information. Suppose you want to extract TDM triples, so for each testing PDF file, you need to provide the testing TDM hypotheses, this could come from the training data, or any other valid TDM triples which are likely related to the corresponding paper (See Section 7 Zero-shot TDM Classification).

@yufanghou  Thanks for your rapid reply. I will have a try.

Dear @yufanghou  Sorry for a long gap for feedback since I am distracted by other matters.
I downloaded 6 PDF files from ACL, EMNLP and NAACL 2019 and managed to generate test.tsv and test_score.tsv.
Then, I used the trained model to predict the test.tsv. The generated results are something like
0.0042572664	0.99574274
0.004257262	0.99574274
0.004257234	0.99574274
0.0042572706	0.99574274
0.0042572417	0.99574274
0.0042573325	0.9957426
0.0042572585	0.99574274
0.0042572953	0.99574274
0.0042573307	0.9957426
0.0042572767	0.99574274
0.0042572827	0.99574274
0.0042572706	0.99574274
0.004257329	0.9957426
0.004257275	0.99574274
0.004257329	0.9957426
0.0042573386	0.9957426
0.0042572785	0.99574274
0.0042572664	0.99574274
0.0042572827	0.99574274
0.004257252	0.99574274
0.0042572482	0.99574274
0.00425725	0.99574274
0.00425724	0.99574274
0.004257246	0.99574274
0.0042572888	0.99574274
0.0042572664	0.99574274
0.0042572706	0.99574274
0.0042572985	0.9957426
0.0042573027	0.9957426
0.00425724	0.99574274
0.0042572953	0.99574274
0.0042572604	0.99574274
0.0042574145	0.9957426
0.004257262	0.99574274
0.0042573228	0.9957426
0.0042572664	0.99574274
0.004257246	0.99574274
0.004257291	0.99574274
0.0042572953	0.99574274
0.0042572664	0.99574274
0.004257262	0.99574274
0.0042572543	0.99574274
0.0042572664	0.99574274
0.004257262	0.99574274
0.0042572706	0.99574274
0.0042572827	0.99574274
0.004257275	0.99574274
0.004257262	0.99574274
0.0042572888	0.99574274
0.0042572664	0.99574274
0.004257275	0.99574274
0.004257238	0.99574274
0.0042572888	0.99574274
0.0042572864	0.99574274

Which are similar to your https://github.com/IBM/science-result-extractor/blob/master/data/exp/few-shot-setup/NLP-TDMS/test_results.tsv.
My question is why the left side probabilities are always small and the right side probabilities are always big. It seems that the predictions are only one value. I suppose the predictions should be some True and some False.
Thanks.

Another question is that the default setting of run_classifier_sci.py seems to deal with the DocTAET-TDM model. How to change the setting for SC-DM model. Do I miss something? Thanks.

Hi @GabrieLin, regarding the uniform probabilities you've seen in the results, some people had the similar issues before and they found that increasing the batch size from 6 to 11 and freezing the parameters of 0-6 layers works. Maybe try to train the model again with bigger batch size?
For the second question above, the model SC-DM is trained the same way as DocTAET-TDM model, in the final inference stage, TEModelEvalOnNLPTDMS class combines the predictions from these two models and forms TDMS tuples for each paper.

@yufanghou Thanks. Let me try to train it with your suggestions.


Enhancements to genAbi.js for Better Readability and Error Handling

This pull request introduces several improvements to the genAbi.js script, aiming to enhance code readability, standardize formatting, and strengthen error handling mechanisms. Here's a summary of the changes made:

Added Detailed Comments: To improve code understanding and maintainability, detailed comments have been added to functions and critical sections of the code.

Corrected Typos and Grammar: Any typos and grammatical errors within the comments and error messages have been corrected to ensure clarity and professionalism.

Strengthened Error Handling: The error handling logic has been fortified by providing clearer error messages for potential failure points, such as missing or empty npm_execpath environment variable.

Standardized Code Formatting: The code has been reformatted to follow consistent styling guidelines, making it easier to read and understand.

These changes aim to make the genAbi.js script more robust, easier to work with, and more accessible to new contributors. The enhancements also lay the groundwork for future improvements and features.
Motivation:
The motivation behind these changes is to address the lack of comments, occasional typos, and the need for better error handling and code consistency. By tackling these issues, we can improve the overall developer experience and contribute to the project's long-term success.
I look forward to your feedback and any further suggestions for improvement.

@cla-bot check


Hopeful Improvement - Media Player Bubble Card

Hello,
Love the updates - working alot better - especially in the edit mode on HA.
We haev just tried using the Media Player card. Functionality is good, but we find that the icons for the "next-previous-volume etc" are a bit small.
It would be good if the Media Player card was almost double the height and the song information could be above and the buttons below it, and a bit larger
Thanks again

Hi, I'm planning to add the possibility to choose for a larger layout for most of the cards, in the meantime what you want is doable with the custom styles.

This is now possible in the latest betas with the new layouts!


Update SUSE Rancher compatibility matrix info

Rancher v2.8 is generally available, but https://www.suse.com/suse-rancher/support-matrix/all-supported-versions is not updated with compatibility info for Rancher 2.8. Can you please update this info?

Support Matrix will be updated once Rancher v2.8 reaches stable status.


Fix field name and association

Hello,
With the latest version, I found 2 bugs:

An error of check field name association. The process retrieve the field name of join-column, and adding fields of entity, but the field name of join-column is a column name.
And an error during hydration, when the association has a join-column without identities.

@pokap Can you please create a new PR with tests if the error still exists?


(fix) revert quickstart name change

Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

reverts quickstart file name change

fixed


"Remove torrent" deletes data

Everytime I remove a torrent from the Rutorrent it deletes the downloaded data as well.

@rj452 Just comment this section in your .rtorrent.rc


Balance not updating

I am using TotalEconomy's API to add currency to a player's balance. It successfully adds the currency(It updates in the accounts file), but when I run /balance the currency hasn't changed at all. When I restart the server, it changes the balance in the accounts file back to what it was when using /balance. The only way that I can get the balance to update is by restarting the server.

Ok. Let me go ahead and test this out on my end and I will get back to you in a little bit.

Just recreated the issue. I will try to get it fixed today. Thanks for bringing this up.

Ok thanks

Ok I figured it out and will release it later today once I fix up a few more things. Thanks again for bringing this up.

Here is the fix: https://github.com/Erigitic/TotalEconomy/releases/tag/v1.0.8. Please get back to me when you test it just so I can make sure it is working for you as well.

Everything seems to be working, I will let you know if I find anymore bugs

Glad to hear.


[Fix][Server] Fix annotation errors in workspace related DTO

Purpose of this pull request

Check list

[√] Code changed are covered with tests, or it does not need tests for reason:
[√] Change does not need document change

See #159

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


App only displays initial weather data on first load

When the weather app is started for the first time, the app displays the initialWeatherForecast only. The app only starts making network requests from the second refresh onwards. This makes the app ui seem incorrect the first time.
A possible fix would be to call the getForecast after the service worker registration for the first application load.

Hi!
Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.
If you find any issues with the new codelab, please let us know!
Thanks!


OCPCLOUD-2220: Merge https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud:v0.6.0 (02aa85f) into main

/retest

@damdo, Currently we support only Power VS and the test e2e-ibmcloud-techpreview  is not related to Power VS platform and its for ibmcloud platform. Can we consider removing this test .

Yes I also realised this is IBMCloud and not Power VS.
We can ignore the failing test result as that doesn't apply.
I can see if I can remove this test from the presubmits for this repo.

@Karthik-K-N here is the PR to remove the job:
cluster-api-provider-ibmcloud: remove e2e techpreview job https://github.com/openshift/release/pull/44007

@Karthik-K-N here is the PR to remove the job: cluster-api-provider-ibmcloud: remove e2e techpreview job openshift/release#44007

Thank you.

/hold
For manual testing

/hold For manual testing

Will test and update.

Verified the update and it works perfectly fine.
% oc get infrastructureprovider -A
NAMESPACE               NAME       INSTALLEDVERSION   READY
openshift-cluster-api   ibmcloud   v0.6.0             True

%  oc get coreprovider -A
NAMESPACE               NAME          INSTALLEDVERSION   READY
openshift-cluster-api   cluster-api   v1.5.2             True

 % oc get nodes
NAME                              STATUS   ROLES                  AGE   VERSION
powervs-machine-template-wktm7    Ready    worker                 81s   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-0       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-1       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-2       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-mx78x   Ready    worker                 12h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-wdrmw   Ready    worker                 13h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-zhhj2   Ready    worker                 13h   v1.27.3+4aaeaec

/Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:62
  [SKIPPED] in [BeforeAll] - /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 @ 10/12/23 10:56:56.617
  [SKIPPED] in [AfterEach] - /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:55 @ 10/12/23 10:56:56.618
S [SKIPPED] [0.001 seconds]
Cluster API AWS MachineSet [BeforeAll] should be able to run a machine with a default provider spec
  [BeforeAll] /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:41
  [It] /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:62

  [SKIPPED] Skipping AWS E2E tests
  In [BeforeAll] at: /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 @ 10/12/23 10:56:56.617

  Full Stack Trace
    github.com/openshift/cluster-capi-operator/e2e.glob..func1.1()
        /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 +0x10c
------------------------------

Ran 1 of 3 Specs in 1004.833 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2 Skipped
PASS

Ginkgo ran 1 suite in 17m7.734669418s
Test Suite Passed

May be lets wait till hypershift PR to remove the deprecated flag merges, IPI change ref: https://github.com/openshift/cluster-capi-operator/pull/128.
@dharaneeshvrd Please let us know once we are good.
/hold

@Karthik-K-N
Hypershift PR is merged here https://github.com/openshift/hypershift/pull/3028
You can unhold the PR.

@Karthik-K-N Hypershift PR is merged here openshift/hypershift#3028 You can unhold the PR.

Thanks for the update. @damdo we are good to merge this.

/lgtm
/approve

/unhold

/tide refresh


fix: Ensure compatibility with sqlalchemy 1.3 and 2.0

Apparently my prior specific-version install of pip install sqlalchemy~=1.3 was, in fact, installing 1.4. So there were some minimal changes required to support 1.3.
While at it, it seemed prudent to test 2.0.0b4 at the same time. Largely requiring a bunch of changes to tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

54 of 56 (96.43%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 96.515%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sqlalchemy_declarative_extensions/role/ddl.py
4
6
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1551

Relevant Lines:
1605

💛  - Coveralls


balena flow from block(s) to fleet(s)

Would we consider supporting a balena workflow that:
(a) publishes block(s); and
(b) deploys to fleet(s)
I've built this pattern up for a personal project and I feel it works reasonably well.

@ab77 we already have this, you just need to provide the correct balena_slugs
Flowzone will call the deploy-to-balena action and neither care if it's an app, fleet, or block. It just pushes to a slug.

So once we pushed draft block release, we would need to push a draft release to fleet(s), using the draft block release. So we would just run another flowzone job, with different inputs?

Oh I see, you want to chain the events so a draft block can create a draft app which can create a draft fleet, like that?
I would have to think about that, but it seems outside the scope of a single flowzone call, would probably need multiple with versioning disabled on the 2nd and 3rd calls.

chain the events so a draft block can create a draft app which can create a draft fleet, like that

Yeah, which is the flow I've created in the personal project linked above. There is a bit of logic in there and it may not be as clean as it could be..


Update dependency restriction to support rails 5.1

Fixes https://github.com/the-refinery/sparkpost_rails/issues/41
Note specs are failing since the needed templates don't seem to be included in the repository.
Failure/Error: format.text {render text: data[:text_part]}

      ActionView::MissingTemplate:
        Missing template mailer/test_email with {:locale=>[:en], :formats=>[:text], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}

Whoops, not sure why a0d5138 got added to this PR. Feel free to remove that (I can't figure out how)

Any plans to finish this out and add support for Rails 5.1?

See https://github.com/the-refinery/sparkpost_rails/issues/41#issuecomment-329543176

Also @viamin if you wanted to remove that recent commit, you could run git reset --hard HEAD^ and then git push --force

@sman591 Done - I've removed a0d5138.


Error when lazy loading nvim-cmp on InsertEnter event

Hi, I'm not sure whether this is a bug or if it's a mistake in my configuration, but upon adding event = InsertEnter to nvim-cmp's plugin spec, I get the following error: https://pastebin.com/CXgmACiv.
The weird thing is that this error seemingly comes up randomly each time I restart Neovim. Sometimes it gives the error, sometimes everything works perfectly with the lazy loading.
Here's my nvim-cmp spec: https://github.com/WilsonOh/nvim/blob/lazy/lua/core/plugins/cmp.lua.
May I know how I should go about debugging this? Thank you!

Can you provide a minimal init as instructed in the issue template? Otherwise it's hard for me to debug this

I had a similar error, seemingly rising from cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done()), whose traceback is similar to what you get

Error  07:54:53 PM notify.error lazy.nvim Failed to run config for nvim-autopairs

I did not have pcall to ensure that nvim-autopairs is installed before calling it in the configuration for nvim-cmp; in general nvim-cmp, nvim-lsp and nvim-autopairs call one another to have the completion play together with the parentheses, so you may want to check that you have pcalls in all your files to gracefully handle it (and avoid circular dependencies). Not sure if this is your problem too, but worth a suggestion.

Can you provide a minimal init as instructed in the issue template? Otherwise it's hard for me to debug this

Sorry about that! I tried to create a minimal init like this: https://pastebin.com/0uHyUEh0 but I couldn't reproduce the error.
However as @gennaro-tedesco's has suggested, the error came from this this snippet in my nvim-autopairs setup:
  local cmp_autopairs = require("nvim-autopairs.completion.cmp")
  local cmp = require("cmp")
  cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done())

commenting out that snippet from my config resulted in the error going away.  I tried wrapping the requires in pcalls as suggested like so:
  local ok0, npairs = pcall(require, "nvim-autopairs")
  if not ok0 then
    return
  end
  npairs.setup({})
  local ok1, cmp_autopairs = pcall(require, "nvim-autopairs.completion.cmp")
  if not ok1 then
    return
  end
  local ok2, cmp = pcall(require, "cmp")
  if not ok2 then
    return
  end
  cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done())

but that didn't solve the issue. Maybe I'm doing it incorrectly?
The first line of error says:
 Error  11:11:35 PM msg_show.lua_error Error detected while processing InsertEnter Autocommands for "*":
11:11:35 PM msg_show Error executing lua callback: ...l/share/nvim/lazy/cmp-nvim-lsp/lua/cmp_nvim_lsp/init.lua:106: attempt to call field 'register_source' (a nil value)
stack traceback:
	...l/share/nvim/lazy/cmp-nvim-lsp/lua/cmp_nvim_lsp/init.lua:106: in function <...l/share/nvim/lazy/cmp-nvim-lsp/lua/cmp_nvim_lsp/init.lua:95>

cmp-nvim-lsp is listed as a dependency in both nvim-lspconfig and nvim-cmp's specs so could that be the issue? But that's the same as well in the minimal init so I'm out of ideas.

Can you remove all the deps instead and let lazy handle them automatically? So just move the deps top-level and set lazy=true. Lazy should then automatically resolve lua dependencies.
Looking at the error there does indeed seem some sort of circular requires happening though, so not 100% sure this would solve it.

Can you remove all the deps instead and let lazy handle them automatically? So just move the deps top-level and set lazy=true. Lazy should then automatically resolve lua dependencies.
Looking at the error there does indeed seem some sort of circular requires happening though, so not 100% sure this would solve it.

 Just have it as dependency of the latter. In my case I do
	{
		"neovim/nvim-lspconfig",
		event = "BufReadPre",
		config = ...
	},
	{
		"hrsh7th/nvim-cmp",
		event = "InsertEnter",
		dependencies = {
			"hrsh7th/cmp-nvim-lsp",
			"hrsh7th/cmp-buffer",
			"hrsh7th/cmp-path",
			"hrsh7th/cmp-cmdline",
			"saadparwaiz1/cmp_luasnip",
			{
				"windwp/nvim-autopairs",
				config =...
			},
		},
	},

where the lsp configuration contains
local cmq_ok, _ = pcall(require, "cmp_nvim_lsp")
if not cmq_ok then
	return
end

and cmp configuration, in turn
local pairs_ok, cmp_autopairs = pcall(require, "nvim-autopairs.completion.cmp")
if not pairs_ok then
	return
end

and it works. However as folke suggested I could probably get rid of the pcalls altogether (I am also still in the phase of understanding the mechanics of this plugin so don't take this as golden truth).

Basically, with lazy Lua dependencies are not needed.

Ok so it seems like moving this
local cmp_autopairs = require("nvim-autopairs.completion.cmp")
local cmp = require("cmp")
cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done())

from plugins/autopairs.lua to plugins/cmp.lua did the trick. I didn't even have to add nvim-autopairs as a dependency on nvim-cmp...
I guess now I have to look into removing dependencies and letting lazy handle it all.
Thanks @gennaro-tedesco and @folke!


Fields for notice_banner_reject_button_hide + preferences_center_close_button_hide

Hi,
Can you add fields for more configuartion to the UI?
For me it would be very useful to have UI options for notice_banner_reject_button_hide and preferences_center_close_button_hide.
Thanks.

@aim12340 We've added a few options now.

Thanks!


[BUG] "name"-tag conflicts with Child Bridge name on Homebridge 1.3.0

Describe the bug
When running more than one HarmonyHub the "name" tag conflicts with the Child Bridge name. Multiple gateways/hubs with the same name show up in "add new" in Homekit.

To Reproduce
Steps to reproduce the behavior:
Add more than one HamonyHub in settings when running plugin in child bridge mode on Homebridge 1.3.0.
My settings:
{
"name": "Livingroom Harmonyhub",
"hubIP": "<IP_ADDRESS>",
"hubName": "Vardagsrum",
"cleanCache": true,
"TVAccessory": true,
"mainActivity": "TV",
"switchAccessories": false,
"activitiesToPublishAsAccessoriesSwitch": [],
"publishGeneralMuteSwitch": false,
"publishGeneralVolumeSlider": false,
"publishGeneralVolumeSwitches": false,
"linkVolumeControlToTV": false,
"publishSwitchActivitiesAsIndividualAccessories": false,
"otherPlatforms": [
{
"name": "Mediaroom HarmonyHub",
"hubIP": "<IP_ADDRESS>",
"hubName": "Mediarum",
"TVAccessory": true,
"mainActivity": "SHIELD TV",
"activitiesToPublishAsInputForTVMode": [
"TV",
"SHIELD TV",
"PS4"
],
"switchAccessories": false,
"activitiesToPublishAsAccessoriesSwitch": [],
"publishGeneralMuteSwitch": false,
"publishGeneralVolumeSlider": false,
"linkVolumeControlToTV": false
}
EDIT: Added my plugin settings

Hi,
First of all, I suggest you modify your config .
-cleancache should not be let to true
-if you use hubIP (meaning you have fixed IP), you should not use hubName (use only in discovery mode)
Then, you have to add each TV device separately.
What you see I think  is the homebridge platform itself (no TV icon) and The TV device I think . (+ 2 others homekit device that seems not related). Did you have this screen after scanning the QR code or is it a "I don't have code screen" ?
I would need english translation to be sure which screen it is :)

Hi,
First of all, I suggest you modify your config .
-cleancache should not be let to true
Now set to false.

-if you use hubIP (meaning you have fixed IP), you should not use hubName (use only in discovery mode)
Then, you have to add each TV device separately.
They are fixed IPs. I removed the "hubName" on both of the Harmony hubs.

What you see I think is the homebridge platform itself (no TV icon) and The TV device I think . (+ 2 others homekit device that seems not related). Did you have this screen after scanning the QR code or is it a "I don't have code screen" ?
I would need english translation to be sure which screen it is :)
This is the "I do not have a code" screen. The other two devices are my luminarie plugins.

After these mods of the config the add screen looks like this:

Adding the Harmony Child Brigde (device with 3 green dots) to homekit doesn't add the HarmonyHubs as accessories. I have to add these separatly. It would be great if:
A.) Only the Child Bridge is exposed to Homekit and when added all Harmonyhubs are added accessories
B.) Since adding the Child Bridge to Homekit doesn't do anything only expose the HarmonyHubs to Homekit.
My new config settings:
   {
        "name": "Vardagsrum Harmonyhub",
        "hubIP": "<IP_ADDRESS>",
        "cleanCache": false,
        "TVAccessory": true,
        "mainActivity": "TV",
        "switchAccessories": false,
        "publishGeneralMuteSwitch": false,
        "publishGeneralVolumeSlider": false,
        "publishGeneralVolumeSwitches": false,
        "linkVolumeControlToTV": false,
        "publishSwitchActivitiesAsIndividualAccessories": false,
        "otherPlatforms": [
            {
                "name": "Mediarum HarmonyHub",
                "hubIP": "<IP_ADDRESS>",
                "TVAccessory": true,
                "mainActivity": "SHIELD TV",
                "activitiesToPublishAsInputForTVMode": [
                    "TV",
                    "SHIELD TV",
                    "PS4"
                ],
                "switchAccessories": false,
                "publishGeneralMuteSwitch": false,
                "publishGeneralVolumeSlider": false,
                "linkVolumeControlToTV": false
            }

Thank you, that is what I thought.
TV devices are not birdged accessories, so they have ot be added separately and can't be with the hub : can't be added with the bridged accessory.
Will check for the bridge Accessory, indeed since you don't have any switch exposed (which handle them), exposing it is useless (but not sure I can prevent this, will check).

Hi juste tried to reproduce, and can't. Are you sure it is not the homebridge hub itself ? Or that at any point you did not have some cached accesory ? What does configUI-X show in cached and external accessories ?

These are my cached bridges and TVs. As you see "Vardagsrum HarmonyHub" is exposed as both TV and Bridge when I run the plugin as "Child Bridge".

Noticed that I'd left out the Child Bridge part of the previously posted configs. Don't if it's of any help but here it is at the bottom:
    {
        "name": "Vardagsrum HarmonyHub",
        "hubIP": "<IP_ADDRESS>",
        "cleanCache": false,
        "TVAccessory": true,
        "mainActivity": "TV",
        "switchAccessories": false,
        "publishGeneralMuteSwitch": false,
        "publishGeneralVolumeSlider": false,
        "publishGeneralVolumeSwitches": false,
        "linkVolumeControlToTV": false,
        "publishSwitchActivitiesAsIndividualAccessories": false,
        "otherPlatforms": [
            {
                "name": "Mediarum HarmonyHub",
                "hubIP": "<IP_ADDRESS>",
                "TVAccessory": true,
                "mainActivity": "SHIELD TV",
                "activitiesToPublishAsInputForTVMode": [
                    "TV",
                    "SHIELD TV",
                    "PS4"
                ],
                "switchAccessories": false,
                "publishGeneralMuteSwitch": false,
                "publishGeneralVolumeSlider": false,
                "linkVolumeControlToTV": false
            }
        ],
        "platform": "HarmonyHubWebSocket",
        "_bridge": {
            "username": "0E:25:6E:80:A3:81",
            "port": 51202
        }

Hum are you talking about this new option of homebridge that can isolate each platform as a bridge ? If yes I think you don't have to do that if you only expose tv accessories since they are external one and not bridge . This I think it is not really my plugin that is exposing this but homebridge itself .

Yes it's caused by isolating the plugin as "child bridge" in Homebridge 1.3.0. I'll just run the plugin without isolation for the time being. It might help others if you mention not to run the plugin as a "child bridge" under Homebridge 1.3.0 in the readme file.

Ok, thx. I think running as an isolated one might still make sense if you expose switches , but indeed with only a tv accessory it does not make sense

will be added in the readme :)


Stop slow or suspended native miner

TODO:

[x] Timeout only for mining tag;
[x] Configurable mining attempt timeout, default 1 hour;
[x] Update doc in aec_conductor.erl
[x] Record for worker info kept in aec_conductor state
[x] Rebase on recent master

@hanssv @gorillainduction This is ready for your review.


Convert marriage-abroad to use ERB templates

Apologies for the size of this Pull Request.
There's still more tidying up I can do but I figured it's probably better to try to get this merged as soon as possible. The tidying can happen later.
I'm fairly confident that I've converted everything correctly so I guess I'm really interested in whether anyone can spot any obvious mistake that I've made.

Except for the minor comments above this LGTM, good job :+1:
It was also useful to look through the changes and I've made some notes about potential improvements https://github.com/alphagov/smart-answers/issues/1885.

Thanks for reviewing this, @tadast. I'll address your comments and get this merged to master :-)

:confetti_ball:  woot woot! :confetti_ball:


Recieving a bug when running placement with fullplace env

It seems a problem which is easy to debug. However, it is unclear where is your problem from the screenshot.

Assuming you encountered this problem when running "fullplace", make sure you pass in a number instead of a tensor when doing fill_(). You can probably do something like tensor[0] to extract the value.

Have you fixed the problem?