Traffic dropped for identity not found

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When doing cilium monitor --related-to 429 -t policy-verdict to monitor a certain endpoint, I see some requests being denied
Policy verdict log: flow 0x88362923 local EP ID 429, remote ID 6552143, proto 6, ingress, action deny, match none, <IP_ADDRESS>:38764 -> <IP_ADDRESS>:8080 tcp SYN
Policy verdict log: flow 0x34c4a2e6 local EP ID 429, remote ID 6552143, proto 6, ingress, action deny, match none, <IP_ADDRESS>:38764 -> <IP_ADDRESS>:8080 tcp SYN

But then when I try to verify what identity is 6552143 with cilium identity get 6552143 I got
Error: Cannot get identity for given ID 6552143: [GET /identity/{id}][404] getIdentityIdNotFound
Same request show as dropped in Hubble UI with the same identity. Since the identity is not found, I can’t make a policy to allow this traffic

Cilium Version
Client: 1.12.0 9447cd1 2022-07-19T12:22:00+02:00 go version go1.18.4 linux/amd64
Daemon: 1.12.0 9447cd1 2022-07-19T12:22:00+02:00 go version go1.18.4 linux/amd64
Kernel Version
Linux ip-10-210-119-39.eu-west-1.compute.internal 5.4.204-113.362.amzn2.x86_64 #1 SMP Wed Jul 13 21:34:30 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.11-eks-18ef993", GitCommit:"b9628d6d3867ffd84c704af0befd31c7451cdc37", GitTreeState:"clean", BuildDate:"2022-07-06T18:06:23Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
Sysdump
https://drive.google.com/file/d/13EFmujbyu8ljLOvWnrNvlf2PPnfAURQT/view?usp=sharing
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@carloscastrojumo Thanks for the issue. Could you run cilium bpf ipcache get <IP_ADDRESS> from cilium-agent's pod which is running on the node which runs the <IP_ADDRESS> pod?

Hi @brb
This cluster does not exists anymore, but here from another cluster that I was able to replicate the issue.
Policy verdict log: flow 0xca1265fd local EP ID 3985, remote ID 7232340, proto 17, ingress, action deny, match none, <IP_ADDRESS>:58919 -> <IP_ADDRESS>:8125 udp
Policy verdict log: flow 0xca1265fd local EP ID 3985, remote ID 7232340, proto 17, ingress, action deny, match none, <IP_ADDRESS>:58919 -> <IP_ADDRESS>:8125 udp

cilium identity get 7232340
Error: Cannot get identity for given ID 7232340: [GET /identity/{id}][404] getIdentityIdNotFound

By running cilium bpf ipcache get <IP_ADDRESS> from cilium-agent's pod which is running on the node which runs <IP_ADDRESS> pod
root@ip-10-210-97-208:/home/cilium# cilium bpf ipcache get <IP_ADDRESS>
<IP_ADDRESS> maps to identity identity=15602669 encryptkey=0 tunnelendpoint=<IP_ADDRESS>

root@ip-10-210-97-208:/home/cilium# cilium bpf ipcache get <IP_ADDRESS>
<IP_ADDRESS> maps to identity identity=15602669 encryptkey=0 tunnelendpoint=<IP_ADDRESS>

Cilium Sysdump from this new cluster
cilium-sysdump-20220809-091256.zip
.

@carloscastrojumo Are both <IP_ADDRESS> and <IP_ADDRESS> in the same network?

Yes, same cluster.  In fact, same node. <IP_ADDRESS> is a pod running with host port.

Adding to Eric's comment, we're running cilium 1.10.13

As spoken with @aanm in slack

I have been doing lots of tests with different clusters. Here are 2 sysdumps for the same 1.12 single cluster  (not connected to another cluster yet). The first sysdump is using Cluster ID 165, and I can see the phantom identities on cilium monitor

Policy verdict log: flow 0x3f7033e2 local EP ID 1191, remote ID 2432371, proto 17, ingress, action deny, match none, <IP_ADDRESS>:46098 -> <IP_ADDRESS>:8125 udp
Policy verdict log: flow 0x3f7033e2 local EP ID 1191, remote ID 2432371, proto 17, ingress, action deny, match none, <IP_ADDRESS>:46098 -> <IP_ADDRESS>:8125 udp

root@ip-10-210-130-48:/home/cilium# cilium identity get 2432371
Error: Cannot get identity for given ID 2432371: [GET /identity/{id}][404] getIdentityIdNotFound

The second one is from the same cluster but redeployed with helm with cluster id 20 and deleted the cilium endpoint and identity CRDs and restarted cilium operator and cilium agent pods. Can’t see any match none for identities not found like before after that.
cilium-sysdump-clusterid-165.zip
cilium-sysdump-clusterid-20.zip

I found this is a bug specific to the EKS ENI mode.
TLDR
iptables trace result
[ 3745.087686] TRACE: raw:CILIUM_PRE_raw:return:3 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.107683] TRACE: raw:PREROUTING:policy:2 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.128496] TRACE: mangle:PREROUTING:rule:1 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.148672] TRACE: mangle:CILIUM_PRE_mangle:rule:3 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.168986] TRACE: mangle:CILIUM_PRE_mangle:return:10 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f01 <= mark erased

In bpf_lxc.c, Cilium encodes sec identity into the mark and pass it to stack, higher 8bits of the identity are encoded into the lower 8bits of the mark. In above trace case, it is 0x6b990f81
Before routing, it hits the iptables rule -A CILIUM_PRE_mangle -i lxc+ -m comment --comment "cilium: primary ENI" -j CONNMARK --restore-mark --nfmask 0x80 --ctmask 0x80 (introduced in https://github.com/cilium/cilium/commit/c7f9997d7001c8561583d374dcbd4d973bad6fac v1.9-rc1)

This restores the mark with following calculation nfmark = (nfmark & ~nfmask) ^ (ctmark & ctmask)
At this point, ctmark=0x0 and nfmark=0x6b990f81 thus, result would be (0x6b990f81 & ~0x80) ^ (0x0 & 0x80) = 0x6b990f01  it erases the uppermost bit of higher 8bits of the identity.

In the upper 8bits of the identity, we are encoding the ClusterID. Thus, 128 (b10000000) ~ 255 (b11111111) are affected.

Full investigation log.
Setup
eksctl config (eksctl-config.yaml)
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
  name: yutaro-issue-20797
  region: ap-northeast-1
managedNodeGroups:
- name: ng-1
  desiredCapacity: 1
  privateNetworking: true
  taints:
   - key: "node.cilium.io/agent-not-ready"
     value: "true"
     effect: "NoExecute"

Deployment (deploy.yaml)
apiVersion: apps/v1
kind: Deployment
metadata:
  name: netshoot-deployment
  labels:
    app: netshoot
spec:
  replicas: 2
  selector:
    matchLabels:
      app: netshoot
  template:
    metadata:
      labels:
        app: netshoot
    spec:
      containers:
      - name: netshoot
        image: nicolaka/netshoot:latest
        command: ["tail", "-f"]

Network Policy (netpol.yaml)
apiVersion: "cilium.io/v2"
kind: CiliumNetworkPolicy
metadata:
  name: "allow-ingress"
spec:
  endpointSelector:
    matchLabels:
      app: netshoot
  ingress:
  - fromEndpoints:
    - matchLabels:
        app: netshoot
    toPorts:
    - ports:
      - port: "80"
        protocol: TCP

Setup procedure
eksctl create cluster -f ./eksctl-config.yaml
cilium install --helm-set cluster.id=129 --helm-set cluster.name=test --version v1.12.0 --helm-set endpointRoutes.enabled=true
kubectl apply -f deploy.yaml
kubectl apply -f netpol.yaml
// curl from netshoot to netshoot

Investigation

See cilium monitor --related-to <epid> output

// Client side
-> stack flow 0xca05a3ad , identity 8491973->8491973 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:44850 -> <IP_ADDRESS>:80 tcp SYN

// Server side
Policy verdict log: flow 0xf96cf2e7 local EP ID 1607, remote ID 103365, proto 6, ingress, action deny, match none, <IP_ADDRESS>:51670 -> <IP_ADDRESS>:80 tcp SYN
xx drop (Policy denied) flow 0xf96cf2e7 to endpoint 1607, , identity 103365->8491973: <IP_ADDRESS>:51670 -> <IP_ADDRESS>:80 tcp SYN

We can see that the identity is valid before it goes to the stack, but after coming back from the stack, it is changed somehow. The identity is carried to the stack with skb->mark, thus we can see that someone overwrites the mark.

See iptables tracing

iptables -t raw -I PREROUTING 1 -d <destination pod ip> -j TRACE
// curl from netshoot to netshoot

output
[ 3745.087686] TRACE: raw:CILIUM_PRE_raw:return:3 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.107683] TRACE: raw:PREROUTING:policy:2 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.128496] TRACE: mangle:PREROUTING:rule:1 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.148672] TRACE: mangle:CILIUM_PRE_mangle:rule:3 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f81
[ 3745.168986] TRACE: mangle:CILIUM_PRE_mangle:return:10 IN=lxcf6b49f5d512f OUT= MAC=06:2b:96:ba:ba:5f:0a:73:0a:93:f1:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=255 ID=32035 DF PROTO=TCP SPT=57976 DPT=80 SEQ=356477153 ACK=0 WINDOW=62727 RES=0x00 SYN URGP=0 OPT<PHONE_NUMBER>02080AB79F650B0000000001030307) MARK=0x6b990f01 <= mark erased

It hits the rule mangle:CILIUM_PRE_mangle:rule:3 and returns. During that, iptables erases the mark.
See rule 3
$ iptables -t mangle -vL CILIUM_PRE_mangle 3
 3076  245K CONNMARK   all  --  lxc+   any     anywhere             anywhere             /* cilium: primary ENI */ CONNMARK restore mask 0x80

See connmark value
$ conntrack -L -d <IP_ADDRESS>
tcp      6 80 SYN_SENT src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=53602 dport=80 [UNREPLIED] src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=80 dport=53602 mark=0 use=1

CONNMARK calculates the new mark value with (nfmark & ~nfmask) ^ (ctmark & ctmask), substitute this.
(0x6b990f81 & ~0x80) ^ (0x0 & 0x80) = 0x6b990f01

When connmark is 0x0, it always erases the uppermost bit of the lower 8bits of the mark.  In the upper 8bits of the identity, we are encoding the ClusterID. Thus, 128 (b10000000) ~ 255 (b11111111) are affected.

For the moment, the quick workaround would be only using 1-127 as a ClusterID. Let me think about how we can solve this.

@YutaroHayakawa , apologies: I wrote the following up while travelling today and didn't see your comment above. I'd still like to dump my findings here which are close to your own, but we took different approaches. Also, I have a proposed fix.
The following NF table rule clears bit 0x80 of the mark as it passes through:
table ip mangle { # handle 4
...
chain CILIUM_PRE_mangle { # handle 116
...
iifname "lxc*"  counter packets 42077 bytes 5687540 meta mark set ct mark and 0x80 # handle 119

This is the corresponding iptable rule, that is defined in iptables.go:addCiliumENIRules():
-A CILIUM_PRE_mangle -i lxc+ -m comment --comment "cilium: primary ENI" -j CONNMARK --restore-mark --nfmask 0x80 --ctmask 0x80

In certain cases, the mark contains a "serialised" (c.f. set_identity_mark() and get_identity() BPF functions)
form of the pod identity, including cluster ID, as follows:
Offset:          24        16         8         0
Identity: XXXX XXXX CCCC CCCC DDDD CCCC BBBB AAAA
          <unused > <cluster> <   pod identity  >

Serialised
to
mark:     DDDD CCCC BBBB AAAA PPPP PPPP CCCC CCCC

The P bits are untouched by set_identity_mark() and are used to represent other information about the packet.
The iptable rule above performs a bitwise and with 0x80, which in binary is 1000 0000.  This results in clearing the
leftmost bit of the cluster ID, at least in some cases.
I think the bug is simply that the mask used in the iptable rule is incorect: it should be 0x8000 in order to target
the P bits of the mark as represented above.
I've submitted a PR to fix this <>
Here is a partial nftrace showing the rule flip the wrong bit in the mask as it passes through:
trace id 7cf0ad14 inet filter trace_chain packet: iif "lxc367ef851a52e" ether saddr c6:06:c5:20:81:d3 ether daddr b2:79:bf:eb:ba:fa ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> ip dscp cs0 ip ecn not-ect ip ttl 64 ip id 32909 ip protocol tcp ip length 60 tcp sport 37002 tcp dport 80 tcp flags == syn tcp window 26883
trace id 7cf0ad14 inet filter trace_chain rule ip daddr <IP_ADDRESS> meta nftrace set 1 (verdict continue)
trace id 7cf0ad14 inet filter trace_chain verdict continue meta mark 0x31aa0fbd
trace id 7cf0ad14 inet filter trace_chain policy accept meta mark 0x31aa0fbd
trace id 7cf0ad14 ip raw PREROUTING packet: iif "lxc367ef851a52e" ether saddr c6:06:c5:20:81:d3 ether daddr b2:79:bf:eb:ba:fa ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> ip dscp cs0 ip ecn not-ect ip ttl 64 ip id 32909 ip length 60 tcp sport 37002 tcp dport 80 tcp flags == syn tcp window 26883
trace id 7cf0ad14 ip raw PREROUTING rule  counter packets 997478 bytes 709868754 jump CILIUM_PRE_raw (verdict jump CILIUM_PRE_raw)
trace id 7cf0ad14 ip raw CILIUM_PRE_raw verdict continue meta mark 0x31aa0fbd
trace id 7cf0ad14 ip raw PREROUTING verdict continue meta mark 0x31aa0fbd
trace id 7cf0ad14 ip raw PREROUTING policy accept meta mark 0x31aa0fbd                        <<<<< MARK OK
trace id 7cf0ad14 ip mangle PREROUTING packet: iif "lxc367ef851a52e" ether saddr c6:06:c5:20:81:d3 ether daddr b2:79:bf:eb:ba:fa ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> ip dscp cs0 ip ecn not-ect ip ttl 64 ip id 32909 ip length 60 tcp sport 37002 tcp dport 80 tcp flags == syn tcp window 26883
trace id 7cf0ad14 ip mangle PREROUTING rule  counter packets 997478 bytes 709868754 jump CILIUM_PRE_mangle (verdict jump CILIUM_PRE_mangle)
trace id 7cf0ad14 ip mangle CILIUM_PRE_mangle rule iifname "lxc*"  counter packets 32132 bytes 4340095 meta mark set ct mark and 0x80 (verdict continue)
trace id 7cf0ad14 ip mangle CILIUM_PRE_mangle verdict continue meta mark 0x31aa0f3d           <<<<< MARK modified and incorrect
trace id 7cf0ad14 ip mangle PREROUTING verdict continue meta mark 0x31aa0f3d
trace id 7cf0ad14 ip mangle PREROUTING policy accept meta mark 0x31aa0f3d
...

In the trace above, the mark changes as follows:
Mark:     DDDD CCCC BBBB AAAA PPPP PPPP CCCC CCCC
          0011 0001 1010 1010 0000 1111 1011 1101 0x31aa0fbd    833228733  Correct: cluster id = 189
          0011 0001 1010 1010 0000 1111 0011 1101 0x31aa0f3d    833228605  Wrong:   cluster id =  61
                                        ^- cleared bit

@EricMountain Thanks for your info as well!

I suspect the bug is simply that the mask used in the iptable rule is incorect: it should be 0x8000 in order to target the P bits of the mark as represented above. In other words, is the iptable rule simply targeting the wrong byte, or am I being too optimistic?

IIUC, it is not wrong and interfering with ENI CNI marks. We have a mark registry here, and according to that, ENI CNI surely uses the 7th bit. So, the mark should be correct.
https://github.com/fwmark/registry

Connectivity test result for cluster-id=128
📋 Test Report
❌ 12/23 tests failed (26/114 actions), 0 tests skipped, 1 scenarios skipped:
Test [allow-all-except-world]:
  ❌ allow-all-except-world/pod-to-pod/curl-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
  ❌ allow-all-except-world/pod-to-pod/curl-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
  ❌ allow-all-except-world/client-to-client/ping-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>:0)
  ❌ allow-all-except-world/client-to-client/ping-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>:0)
  ❌ allow-all-except-world/pod-to-service/curl-0: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node (echo-same-node:8080)
  ❌ allow-all-except-world/pod-to-service/curl-1: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/echo-same-node (echo-same-node:8080)
Test [client-ingress]:
  ❌ client-ingress/client-to-client/ping-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>:0)
Test [echo-ingress]:
  ❌ echo-ingress/pod-to-pod/curl-0: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
Test [client-ingress-icmp]:
  ❌ client-ingress-icmp/client-to-client/ping-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>:0)
Test [echo-ingress-l7]:
  ❌ echo-ingress-l7/pod-to-pod-with-endpoints/curl-0-public: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-0-public (<IP_ADDRESS>:8080)
  ❌ echo-ingress-l7/pod-to-pod-with-endpoints/curl-0-private: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-0-private (<IP_ADDRESS>:8080)
  ❌ echo-ingress-l7/pod-to-pod-with-endpoints/curl-0-privatewith-header: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-0-privatewith-header (<IP_ADDRESS>:8080)
Test [echo-ingress-l7-named-port]:
  ❌ echo-ingress-l7-named-port/pod-to-pod-with-endpoints/curl-1-public: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-1-public (<IP_ADDRESS>:8080)
  ❌ echo-ingress-l7-named-port/pod-to-pod-with-endpoints/curl-1-private: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-1-private (<IP_ADDRESS>:8080)
  ❌ echo-ingress-l7-named-port/pod-to-pod-with-endpoints/curl-1-privatewith-header: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> curl-1-privatewith-header (<IP_ADDRESS>:8080)
Test [echo-ingress-from-other-client-deny]:
  ❌ echo-ingress-from-other-client-deny/pod-to-pod/curl-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
  ❌ echo-ingress-from-other-client-deny/client-to-client/ping-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>:0)
  ❌ echo-ingress-from-other-client-deny/client-to-client/ping-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>:0)
Test [client-ingress-from-other-client-icmp-deny]:
  ❌ client-ingress-from-other-client-icmp-deny/pod-to-pod/curl-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
  ❌ client-ingress-from-other-client-icmp-deny/pod-to-pod/curl-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
  ❌ client-ingress-from-other-client-icmp-deny/client-to-client/ping-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>:0)
Test [client-egress-to-echo-deny]:
  ❌ client-egress-to-echo-deny/client-to-client/ping-0: cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>) -> cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>:0)
  ❌ client-egress-to-echo-deny/client-to-client/ping-1: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/client-7bdbddd7b-7rrzq (<IP_ADDRESS>:0)
Test [client-ingress-to-echo-named-port-deny]:
  ❌ client-ingress-to-echo-named-port-deny/pod-to-pod/curl-0: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
Test [client-egress-to-echo-expression-deny]:
  ❌ client-egress-to-echo-expression-deny/pod-to-pod/curl-0: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
Test [client-egress-to-echo-service-account-deny]:
  ❌ client-egress-to-echo-service-account-deny/pod-to-pod/curl-0: cilium-test/client2-74f4559c78-xzg5n (<IP_ADDRESS>) -> cilium-test/echo-same-node-7894f8ffcd-vws46 (<IP_ADDRESS>:8080)
connectivity test failed: 12 tests failed


Update CAPAS infrastructure components

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve
/hold

/unhold

/override cluster-api-provider-aws-snow-tooling-presubmit


function to save current matplotlib rcParams to mpltools style file.

ability save the current matplotlibrc settings, stored in the rcParams, into a style file.
the out put of this function works with ConfigObj but mpltools doesnt seem to automatically load the files, even when they are in .mplstyle for some reason i am unsure
along these lines, if the mpltools style syntax is different from matplotlib, then ability to translate between the two would be nice.
i also made a small change to intro doc which you may want to adjust. i thought explicity listing the directory to store the user style files would be useful

Thanks for the PR!
The save_param_dict function is a good idea, but, currently, it will not work as you expect it to. At the moment, ~/.mplstyle and ./mplstyle are files, where styles are stored under various headings (see README.md). This is in contrast to mpltools.style, where styles are stored in separate *.rc files. This is why mpltools isn't loading your styles.
I would like to be able to handle both a single file with multiple style sections and a directory with multiple style files, but I'm not sure how to do it well. I thought about allowing mplstyle to be either a directory or a file, but I thought this might get confusing. Maybe we could allow mplstyle and mplstyles (note the "s"): one could be a file and the other a directory. Thoughts?

ohh, i see. this makes sense. i was unsure because in the example you have styles defined by headers, such as [style1], but in the actual style/ module, you have different files for each such as ieee.transactions.fullpage, ieee.transactions., etc
i would recomend a one or the other approach.

I agree that it is a bit confusing. But I'm not convinced that the alternative is necessarily more attractive.
If I put all the pre-defined styles in a single file, it could get quite long (right now there aren't very many styles, but in theory, this would grow).
On the other hand, any given user will probably only have a few custom styles or a few changes to the default styles, so it makes a bit more sense to put them all in one file.
That's my thinking at the moment, but I'll have to think about this some more.

yeah, i see your point.
i was thinking to automatically read the matplotlibrc (via rcParams ),  into a style, allowing writing of styles in memory to disk would then be sufficient.

This sounds like a good idea, but I think we'll have to figure out a way to reduce the size of these things---especially if it all goes into a single file (i.e. mplstyle) instead of separate files under some config directory (I'm still open to adding a directory in the home path where separate *.rc files could live). Even if files are separate, there would be a lot of noise from unchanged rc params.
I think it would be easy enough to remove settings that are the same as the factory matplotlib-defaults, but it may be a little more difficult to remove the user's matplotlib-defaults (factory defaults + user settings in ~/.matplotlib/matplotlibrc).


Strip IRC formatting before sending to Discord

Coverage increased (+0.01%) to 97.945% when pulling 6bb4b2c14d99dbf243a0b226b5daa12cd729e051 on rossengeorgiev:patch-1 into ad2c9747c36139715bfcf635bff7227ea29fd92d on reactiflux:master.

Maybe a better idea would be to convert the formatting to their Discord counter part, and vice versa? This was implemented by @Kurocon in #97, but the PR was never completed. It's a good implementation though, just needed some finishing touches. If you have time I'm sure he wouldn't mind if you extended his PR and fixed the relevant feedback.

I can't remember seeing anyone ever use underline, italic or bold on IRC for all the years. It is a nice idea, but I don't see any use for it. I am not interested in working on that PR.  Just want clean readable text.
If that PR is ever gets touched, it can easily remove the 2 lines from this one.

That's alright, I could agree with merging this in the meantime. Maybe use an existing library for it instead though? E.g. irc-colors.js has a stripColorsAndStylefunction (which seems to have tests as well).

Why add a dependency for something so simple?

@rossengeorgiev: Because it adds tests for that specific function as well. Regarding the small module discussion there's plenty of arguments here: https://github.com/sindresorhus/ama/issues/10#issuecomment-117766328
I don't really think this is the same discussion as that though, as the function you're adding here really isn't that simple - if you're not overly familiar with IRC formatting escape sequences. That's fine though, as long as it's tested, which in your case it's not.

"I don't see any use for it."
I can. I run an IRC bot that gets the output of a game server's chat, and it color-codes the player names based on their team. It also converts the game's chat color codes to IRC ones.

@StrikerMan780: I'm open to both implementations, but I'm going to close this PR due to inactivity. If anyone wants to give it a go, feel free to read the comments above and send a new PR.


Parse an Ion Text and reporting erroring lines and columns

Hi,
I am having a hard time trying to understand the ionJs documentation. Does ionJs currently support a simple parse and report of error lines? I tried to use ParserTextRaw.error_line but it seems to return an array that does not make much sense to me.

Hello, can you describe what you mean by report of error lines?

Can you describe what you are looking for?

I am looking to get an error message with line number for an invalid ion file. Is this possible?

Are you working on the development branch?

No I am working with the npm package. I think I should make myself clearer, I am trying to parse an ion file (which might have mismatched braces/ or quotes). Can ion js parse and report the error line and column? If so, could you provide a short snippet for the same?

Right now no it cannot. Its error reporting is fairly limited/broken. As is the current package listed on npm.
I would recommend checking out our IonJava package if you're attempting to verify your ion data/get relevant error msgs.
We're currently planning a release come august with comprehensive updates fixing almost all bugs within IonJS.
If you must use IonJS right now I would recommend building from the development branch directly.
Even then it won't propagate the location of the invalid data as an error message.

Right now no it cannot. Its error reporting is fairly limited/broken. As is the current package listed on npm.
I would recommend checking out our IonJava package if you're attempting to verify your ion data/get relevant error msgs.
We're currently planning a release come august with comprehensive updates fixing almost all bugs within IonJS.
If you must use IonJS right now I would recommend building from the development branch directly.
Even then it won't propagate the location of the invalid data as an error message.

Is there a sample code for this lexing/materializing in IonJS? Since VSCode extensions are built in JS or TypeScript, I cannot use IonJava for this purpose.

This example will require you to use the development branch since the current package in npm does not support .value() for all ion types.
function exhaust(reader) {
for (;;) {
let next = reader.next();
if (typeof(next) === 'undefined') {
if (reader.depth() > 0) {
// End of container
reader.stepOut();
} else {
// End of data
break;
}
} else if (next.container && !reader.isNull()) {
reader.stepIn();
} else {
reader.value();
}
}
}

Two questions:

Is '// End of data' where the first error is encountered?
If I build the development branch, can I ship the IonJs version along with the extension?

Cool, is there also a way to get the current offset in the raw text string where the reader is? That way I can easily find the line as well as column in the file.
Regards,
Avin

From: wesboyt<EMAIL_ADDRESS>Sent: May 22, 2018 3:54 AM
To: amzn/ion-js
Cc: Avin; Author
Subject: Re: [amzn/ion-js] Parse an Ion Text and reporting erroring lines and columns (#148)
Errors will be thrown within reader.next() which is where lexing occurs or within reader.value() which is where materialization occurs.
I would wrap those function calls in try/catches and keep an index of how many values you have iterated over / through if you want to know where an error occurred.
Also the reader is stateful and will become corrupted when it runs over bad data so I would not recommend continuing to parse after an error is found.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/amzn/ion-js/issues/148#issuecomment-390801283, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALMDW2lNEqkf4kX04MTkvlzWeZrqCvezks5t0z6hgaJpZM4UFnP-.

The reader has a Parsertextraw which has a StringSpan called _in which has a function position() which is what you're looking for. I do not believe its available publicly within the typescript library but should be accessible within the generated javascript files.
reader._parser._in.position() will tell you where within the input string your reader is looking when reader.next() fails.
reader._parser._start and reader._parser._end will tell you the beginning and end of the value when reader.value() fails.

I do not believe its available publicly within the typescript library but should be accessible within the generated javascript files.
That's too bad. I guess for now I'll just wait for IonJs to mature a bit more.


Update README.md concerning VRChatRPC.dll

I wonder if its better to just remove the entire section completely

Would perhaps suggest it to be more like this. Still relatively amateur to Github so don't know how to directly add suggestions into the commit.

Yeah that works, but I was thinking about keeping the README clean 🤔
If people keep leaving stuff in and adding more notices to it it quickly becomes very cluttered


[Bug] <In nhentai eng sort by recent features not working it's only shows same sort by all time popular>

Device information
App version: 1.4.1 (standard, 7b4311c7d, 12)
Preview build: 325
Android version: 10 (SDK 29)
Android build ID: RMX1851_11_C.10
Device brand: Realme
Steps to reproduce

First step
Second step

Expected behavior
It should be showing recent magazines instead it is showing top popular magazines
Actual behavior
This happened instead.
Other details
Its only happen in sy not in orginal version.
So i think this is sy problem not an extension problem
And also its happening with nhentai all extension is not working its show open in webview

This is a extension issue, if you open NHentai from the Other language in other Tachiyomis, you will see the same behavior

This is a extension issue, if you open NHentai from the Other language in other Tachiyomis, you will see the same behavior

And it's not really a extension issue either. It's how the site is formatted

And it's not really a extension issue either. It's how the site is formatted


API information to README

cc @jnmarcus @bcipolli
Links and description of the disclosure API.

@adborden This is really helpful, thanks!
One piece of API-related information that would also help is understanding how the API is generated from the models (is this related to the Django REST framework? Where in the code)?. Would it be easy to include that here (since your refer to models), or does it make sense to put that in back-end docs?

I think it makes sense to link to the Django REST Framework docs from the backend repo. Referring to the models here is only useful because the swagger docs are incomplete. Once we have more of the routes up, the docs should be all you need and the models won't be relevant.


Selenium Webview2 writing to inaccessible directory

When launching selenium webdriver with UseWebView however the application cannot start because WEBVIEW2_USER_DATA_FOLDER is set C:\WINDOWS\SystemTemp\scoped_dir*.
We tried to overwrite this location to a different location by passing in --user-data-dir= or setting our own environment variable.
When its environment variable is overwritten selenium doesn't know the correct location of the user data directory.
what we are using:

selenium.webdriver 4.12.4
edge 116.0.1938.69
edge webdriver 116.0.1938.69

Hi @jar99 . As you found, --user-data-dir won't work to set the user data folder for the WebView2 runtime because Edge WebDriver is passed that arg to your host app, and not to the underlying WebView2 process.
To set the user data folder and other options seen by the WebView2 process, you need to use the webViewOptions object. Details here: https://learn.microsoft.com/en-us/microsoft-edge/webdriver-chromium/capabilities-edge-options#webviewoptions-object


fix: Reduce iex-webhooks index size to critical fields only

:tada: This PR is included in version 3.27.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Generate YAML from Go struct

This PR allows mdox to generate YAML from Go structs, using the following semantics(for now).
Thus, structs like below,
type Config struct {
	Version int `yaml:"version"`

	Validator []ValidatorConfig `yaml:"validators"`
	Ignore []IgnoreConfig `yaml:"ignore"`
}

type ValidatorConfig struct {
	Type  string `yaml:"type"`
	Regex string `yaml:"regex"`
	Token string `yaml:"token"`

	r *regexp.Regexp
}

type IgnoreConfig struct {
	Url   string `yaml:"url"`
	ID    int    `yaml:"id"`
	Token string `yaml:"token"`
}

Result in markdown like below,
```yaml mdox-gen-go-struct="main.go:Config"
version: 0
validators:
    - type: ""
      regex: ""
      token: ""
ignore:
    - url: ""
      id: 0
      token: ""

```yaml mdox-gen-go-struct="main.go:ValidatorConfig"
type: ""
regex: ""
token: ""

Dependencies added: jennifer,  structtag
Few TODOs:
// TODO(saswatamcode): Add tests.
// TODO(saswatamcode): Check jennifer code for some safety.
// TODO(saswatamcode): Add mechanism for caching output from generated code.
// TODO(saswatamcode): Better errors.

Resolves #23.

Any update on this? @bwplotka

I think @saswatamcode has some comments to be addressed, but quite close.
What do you need this for @Dentrax? Curious about your use case and if this PR fixes it (:

I've created a related issue https://github.com/thanos-io/thanos/issues/4751#issuecomment-967799915 and closed due to inactivity. We want to add support for both comments and default values while generating YAML.

Kind ping, still looking for this feature! @saswatamcode @bwplotka

cc @saswatamcode

I'm trying to look into this, this week and bring it to a nice usable state, rebasing and correcting some of the old code. Plan to clean it up in the next few commits! 🙂


Wrong and misleading docstring for setDatarecordDuration

Hey,
Just wanted to point out that the documentation for EdfWriter.setDatarecordDuration is wrong and a bit misleading.
Looking at the corresponding function edf_set_datarecord_duration in edflib.c it is clear that the duration should be in the range 0.001 to 60 seconds, not 0.05 to 20.0 seconds. This is also documented in edflib.h.
Also, it could be good to point out that the unit of the duration is in 10 microseconds. Now you get the picture that the unit is 1 seconds. This caused me some grey hairs as I tried to set a non-integer sample rate 😄
Appreciate your work on the library!

Thank you for reporting this!


Corrupted artwork on server selection pane

My Setup

Operating System: Windows 10 (OS build 15063.1088)
App Version: 2.11.0

[ X] I have tested with the latest version
[X ] I can simulate the issue easily

Description

I have a user who has reported that the artwork in the server selection area on the left-hand side of the window, comes up with corrupted artwork

Current Behavior

When the user mouses over the area, the artwork looks all broken up.
Expected Behavior

The artwork should remain static.

Interestingly, I have a similar issue after upgrading to 2.11.0. However, for me, the artwork is not messed up. It is just displayed a couple times (as above) when I expect it to be displayed once.

When I mouse over the server selector or the "+" at the top, the extra icons go away and the UI looks as expected.

IMHO this looks like an issue related to #744.

Hey Guys!
What's going on here? :D
still a bug ♥

With the new version it is gone. Thanks!

@gdelavald This issue can be closed :)


Change to /etc/init.d/chef-client on Debian/Ubuntu introduced in 7.0.2 causes failure of script

Cookbook version
7.0.2
Chef-client version
12.13.37
Platform Details
Ubuntu 14.04
Scenario:
Code change introduced by commit https://github.com/chef-cookbooks/chef-client/commit/e271c50b79c3b40c891cca57d73ca8dd7c46a0db causes script to fail
Steps to Reproduce:
Run /etc/init.d/chef-client
Expected Result:
/etc/init.d/chef-client script runs without error
Actual Result:
/etc/init.d/chef-client: 41: [: /opt/chef/embedded/bin/ruby /usr/bin/chef-client -d -P /var/run/chef/client.pid -c /etc/chef/client.rb -i 1800 -s 300 : unexpected operator
Line 41 in templates/default/debian/init.d/chef-client.erb
[ "$cmd" !=~ "$name" ] &&  return 1
is not valid Bourne shell code

7.0.3 has shipped with the fix for this problem.


calendar maximumEntries not working for individual calendars

Setting
maximumEntries =10 for main calendar and maximumEntries=3 for a individual calendar will show 10 entries !

if other settings produces more than 10 entries

This should already be fixed in the develop branch with #2079 in commit https://github.com/MichMich/MagicMirror/pull/2079/commits/73aa35ea2c1310a8953c3c380bf6153db8899b30


What does the monitor widget do?

What does this widget do? The user has the ability to add messages and set some status label. It can also depend on other services. It all seems to be static.
I was expecting something that would monitor REST service endpoints. The monitor would periodically ping some endpoint to determine its health. I don't see anything in the code to do this.
What is the purpose of this widget?

In another two-three weeks this will be replaced by Performance Matrix widget (first version) - first version will have integration with AppDynamics.

Dynatrace integration release date please?

@tabladrum - Can you elaborate on what you mean when you say  " share service availability ".  Is it like monitoring things are up or down. Like health check ? If how does it work. Actually I want to have something like that.

@tabladrum what's the status on the AppD integration?

@MarkRx For monitor widget https://github.com/capitalone/Hygieia/pull/1292
In regards to AppD integration we should be getting a PR soon.

Hi can you please share us the status on AppD


See Records and Show Data - rename, and some content

https://github.com/MicrosoftDocs/powerbi-docs/blob/live/powerbi-docs/desktop-see-data-see-records.md
These options are now "Show as table" and "Show data point as a table" in the context menu, and "Visual table" and "Data point table" in the new ribbon. Please update strings, and screenshots.
Also, for the second one - data point table - we need to add or update the text to state that it will show all the dimension fields related to the data point, not ALL fields. We have customer confusion around this - we don't show all the other values and measures in the table, only the dimensions (non value/measure).

Hi, @MatthLee -- thanks for pointing that out. Referring to the author of https://docs.microsoft.com/en-us/power-bi/desktop-see-data-see-records to take care of it.

Updated - will go out with today's publishing run.


Cockpit shadow moves with headtracking

I realized that the cockpit shadows move slightly when you move your head in VR mode.
This should not happen, as long as the ship does not move, the shadows should be static with respect to the cockpit model.
It happens both with raytracing and shadow mapping modes.
Any ideas why this could be @Prof-Butts ?

Yeah, I think the shadow map is probably computed at the wrong time. It should be computed after the head tracking has been applied, but maybe it's done before that (?) so that's why there's a small delay. Maybe the fix is to apply the "head transform delta" when computing the shadow map (?)


Not compatible with Volto experimental add mode

Volto added a new experimental feature, which enables the add block button on any selected block.
https://6.docs.plone.org/volto/configuration/experimental.html?highlight=experimental
Would it be possible to add this feature on the blocks inside a Columns block?

Thank you very much!

@rotavio Now that we have this plus button în Volto 18.x, yes, we should :thinking:

The major problem was that we can only add new blocks below empty text blocks, and have to manually remove the text afterwards.
I`ve found out later that this is coded into volto by design, and not a bug. In your block, there is a condition like this:
 {!disableNewBlocks && !blockHasValue(data) && (
                <Button
                  icon
                  basic
                  title="Add block"
                  onClick={() => {
                    this.setState({
                      addNewBlockOpened: !this.state.addNewBlockOpened,
                    });
                  }}
                  className="column-block-add-button"
                >
                  <Icon name={addSVG} className="" size="19px" />
                </Button>
              )}

We customizes it to remove the second condition and now the add butto appears for every block.


Limiting number of squares moved

A lot of tactical strategy games have a “limited” movement area. For example, a character can only “step 6 squares” in any direction.
Is this possible to do with this fantastic piece of code?

you can just get the whole path, and only move the first six provided moves


[BUG]Modernization Scanner gets stuck in a loop

Thank you for reporting a bug. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you. Thanks!
Problem Area
We have a huge tenant with over 20k sites on which we are running the scanner. We have tried different options to run it (the tenant as a whole, in batches - site collections starting with the letter 'A' and so on) and it always ends up on a loop after running for a while. We have observed this problem both on a personal machine and on a Windows Server 2019. We are running the tool for only the basic workflow report (not the analysis). This issue is the same as #539.
Expected or Desired Behavior
The Scanner should run to completion and provide a report of all the sites with 2010 workflows.

hi @kaarthik17 : please follow our performance best practices listed here https://docs.microsoft.com/en-us/sharepoint/dev/transform/modernize-scanner-faq#whats-the-impact-of-running-a-scan-and-how-do-i-get-the-best-performance. Also ensure you're using an app-only access method, using MFA will only work for the token lifetime, so typically for one hour.
Also ensure you're using the latest version. I you can capture a fiddler trace when the scanner gets into a loop that would be really helpful to understand what goes wrong

As there was no feedback for 3 weeks I assume the issue is resolved and will close. If you still have issues then please create a new issue and provide the requested details.


ImportError: cannot import name 'init_detector' from 'mmdet3d.apis'

Describe the bug
I got an error about init_detector
Reproduction

What command or script did you run?

CUDA_VISIBLE_DEVICES=0 python demo/pcd_demo.py sunrgbd_000094.bin demo/brnet_8x1_sunrgbd-3d-10class.py checkpoints/brnet_8x1_sunrgbd-3d-10class_trained.pth

What dataset did you use?
sunrgbd_000094.bin

Error traceback
If applicable, paste the error trackback here.
Traceback (most recent call last):
  File "demo/pcd_demo.py", line 3, in <module>
    from mmdet3d.apis import inference_detector, init_detector, show_result_meshlab
ImportError: cannot import name 'init_detector' from 'mmdet3d.apis' (/.../BRNet/mmdetection3d/mmdet3d/apis/__init__.py)

Did you compile success? run command and data are no problem.

This is because 'init_detector' is called 'init_model' in the 'mmdet3d.apis' in the newer version of mmdetection3d. You may try to use the demo/pcd_demo.py file provided in the mmdetection3d folder. https://github.com/open-mmlab/mmdetection3d


The name "Lasso" is already taken by our own library

Hi,
I work for a french company, Entr'ouvert, and we developped, since 2003, a SAML library called Lasso : http://lasso.entrouvert.org/
It has been SAML 2 certified by the liberty Alliance consortium in 2006, it is packaged in Debian, Red Hat, etc. and used by third party projects such as mod_mellon, developed by Uninett in Norway.
It is also used by customers like Cisco, Bloomberg, Miracl and most french universities.
You can easily understand we fear confusion as your project has taken the same name, also in the SSO domain.
For a clear identification of both projects, we'd like to ask you if you could switch your project to something different?
Thank you,

Thanks for reaching out.
We are in the process of renaming "lasso" to "vouch" and will move the repository to https://github.com/vouch/vouch
If you or your customers who are using nginx should ever need to secure their private sites with OAuth2/OIDC please do consider letting them know about vouch.

Hi,
Good news.
Thank you and long live Vouch!


Deployment launcher - underlying dotnet processes get killed if you close Unity

Description
Oh man - this was a fun one. If you close Unity while one of the async tasks are running for uploading/launching/refreshing - the underlying dotnet process gets killed.
I expect this is not the best way to do this - so if anyone has suggestions please let me know 😬
The approach essentially is we create a token and pass it to the RedirectedProcess command. We register a listener OnProcessExit which triggers the cancellation which kills the dotnet process and waits on the task to return (in this case it bubbles up pretty quickly).
Need to update the pin once https://github.com/spatialos/gdk-for-unity/pull/888 is merged
Tests
Ran things, killed Unity, looked for any orphaned processes, couldn't find any.
Documentation
Needs a changelog.
Primary reviewers

Closing this for now. Will be a series of PRs refactoring the depl launcher.


how i use this like it does nothing when i start it

when i use the command nothing happens

Please install docker for this to work


Compact Folder option not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.74.3
OS Version: MacOS Ventura 13.2

Steps to Reproduce:
Either Settings->Features->Explorer activate Compact Folders or create this in json config file: "explorer.compactFolders": true.
Neither makes folders compact when only one child file is present.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!


Verify input to AtomicRef Python class

The numba_dpex.experimental.kernel_iface.AtomicRef class does not check the type of the ref argument. It will lead to issues if the ref argument is a scalar and we later call a fetch_* function on it.
The class constructor for AtomicRef should check the type and raise an error.
Reproducer:
from numba_dpex.experimental.kernel_iface import AtomicRef

v = AtomicRef(1)
out = v.fetch_add(10) # Will raise an error as v._ref is not subscriptable.

recently completed.


Typos

Just a few typos corrected, plus a note or two for HTTP Cache, things I've been looking for for a while.

Can you squash your commits before I merge? Thanks.


Console for D1

Does Miniflare D1 include a console for running SQL queries directly?

Hi @JoyceBabu
No, Miniflare itself doesn't include a console for running SQL queries directly. However, you can access a SQL console on the D1 SQL Database page inside the Cloudflare dashboard.
If you have any future questions, I recommend checking out the workers-sdk repository, as this repository is focused on Miniflare v2, which is only receiving critical security updates.
Thanks!

Thank you. I managed to solve the issue by querying the SQLite file directly.


There's no atan2 function

whoops

Rrgh it's implemented but I must have missed it when porting the stuff to the new system


fix(deviation_evaluator): add autoware prefix to vehicle_velocity_converter

Description
This PR will add the autoware prefix to vehicle_velocity_converter due to the changes in https://github.com/autowarefoundation/autoware.universe/pull/8967 .
Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SakodaShintaro
Do you know how to invoke required CI?


update license files

Coverage decreased (-0.06%) to 54.775% when pulling f049cd3637622284cd887cc0b4e5fae41a6af80d on reasonerjt:update_license into 1403fe09fff04f0b685f209b4edfb6fe5fdd833c on vmware:master.


scripts: vendor string matching must match Zephyr format

The format for the Linux vendor-prefixes.yaml is different
from the dt-vendor.txt format in Zephyr. Here's an example
Linux:
"^arm,.*":
description: ARM Ltd.
Zephyr:
arm	ARM Ltd.
As such, the regex for the vendor string matching needs to
be adapted. The easiest solution is just to use the
previous regex string.
Signed-off-by: Alex Porosanu<EMAIL_ADDRESS>

This is a proposed fix for https://github.com/zephyrproject-rtos/zephyr/issues/25012


Sync UI.

Revert a wrong commit.

Coverage remained the same at 14.33% when pulling aab81398aa68d9d8aa0a203f74b7b2c14cd48aca on ui-fix into 65e11700a2ba8aef143d3088b7785f9fcc9ee032 on master.


image uploading is broken

Not sure when that happened!

Hmmm, I believe there is a bug that this is also happening on v1 in prod...

It worked before all my refactoring. I probably broke it.

Broken in DL3


List component: remaining issues

Description
The List form layout component has been implemented mostly from external contributions from org/pat. While they implemented most of the functionality they needed, some things remain from our list of functional requirements. Copied over from #638, this list contains the remaining requirements.
Related Issue(s)

#578

Requirements

[ ] The component can be configured with a static data source, much like existing options/code lists.

For static data defined in the layout file, sorting can only work on alphabetically sorting strings.

[ ] A row in the List component can be configured to as behaving as a multi-select. This means a checkbox will show up as the first column in the table view. If this is used instead of a radio button, the data model binding should be interpreted as a list data model binding (as used for attachments), i.e. it will store data in an array. It might also be required to interpret the data model binding as a group binding (i.e. prefilling/populating a repeating group structure).
[ ] Support for the component in repeating groups, using the Summary value in the table header
[ ] Support for 'required', with proper/intuitive validation messages when no row is selected
[ ] Support for 'readOnly'?
[ ] Bugfix: Handlechange is called in a loop,  sometimes causing race condition when you have multiple datamodel bindings. Sometimes only one of the datamodelbindings are saved correctly.

Partly fixed in #899, as it no longer causes data corruption, but we still send multiple requests

[ ] Create issue(s) for implementing support for this component in Altinn Studio

Consider extracting some of these out to separate issues if work starts on one or more of these tasks.

Added org/lt label, as they want checkbox support in List:

https://altinn.slack.com/archives/C05NAQK8JUD/p1699007830327159?thread_ts=1699003135.216589&cid=C05NAQK8JUD


Multiple GPU's Not Working when GBM_BACKEND=nvidia-drm is set (not a laptop, displays connected to both integrated and discrete GPU's)

Hyprland Version
Hyprland, built from branch main at commit e5eb11ad0423bfdfd4056964ef868e26b2d3c8 46 dirty (Nix: wrap with gcc). Date: Wed Dec 27 12:27:55 2023 Tag: v0.33.1-101-ge5eb11ad  flags: (if any)
Bug or Regression?
Bug
Description
I am on archcraft using hyprland-git, and I am using a somewhat odd setup: I have an intel iGPU with one monitor plugged into it, and I have an nvidia 980 Ti with two monitors plugged into it.
My nvidia drivers are the dkms version, installed using the "frogging family" installer, and everything seems to work just fine except when trying to enable all the nvidia parameters. I've narrowed it down to it being the GBM_BACKEND=nvidia-drm env variable, as commenting out all other variables in my config and just having the nvidia variables from the readme (and commenting out the GBM_BACKEND line) lets hyprland start. But it's laggy as hell and only barely passes the mark of being useable.
Judging by the output of the log, I'm assuming that it is trying to assign the nvidia-drm to the intel GPU as well, as it mentions a "bad parameter" and an incorrect number of variables being passed. I do not have this issue on other desktop environments/window managers that are wayland based.
How to reproduce

Have a monitor plugged into both the iGPU and the dedicated GPU (intel, nvidia, respectively)
Enable the GBM_BACKEND=nvidia-drm env variable

Hyprland crashes on startup back to login manager

Crash reports, logs, images, videos

Hyprland Crash Report
This was an accident, I swear!
Hyprland received signal 11 (Segmentation fault)
Version: e5eb11ad0423bfdfd4056964ef868e26b2d3c846
Tag: v0.33.1-101-ge5eb11ad
System info:
System name: Linux
Node name: archbtw
Release: 6.6.8-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Thu, 21 Dec 2023 19:01:01 +0000
GPU:
00:02.0 VGA compatible controller [0300]: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics Controller [8086:0412] (rev 06) (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GM200 [GeForce GTX 980 Ti] [10de:17c8] (rev a1) (prog-if 00 [VGA controller])
os-release:
NAME="Archcraft"
PRETTY_NAME="Archcraft"
ID=archcraft
ID_LIKE=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archcraft.io"
DOCUMENTATION_URL="https://wiki.archcraft.io"
SUPPORT_URL="https://www.reddit.com/r/archcraft"
BUG_REPORT_URL="https://github.com/archcraft-os/archcraft/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archcraft
Backtrace:
#0 | Hyprland(_Z12getBacktracev+0x62) [0x55d926ad7d32]
??
??:0
#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x64d) [0x55d926aa464d]
??
??:0
#2 | Hyprland(_Z25handleUnrecoverableSignali+0x48) [0x55d926a386d8]
??
??:0
#3 | /usr/lib/libc.so.6(+0x3e710) [0x7f883e05c710]
??
??:0
#4 | /usr/lib/gbm/nvidia-drm_gbm.so(+0x156eb) [0x7f8831e156eb]
??
??:0
#5 | /usr/lib/gbm/nvidia-drm_gbm.so(+0x159b8) [0x7f8831e159b8]
??
??:0
#6 | /usr/lib/libgbm.so.1(+0x4e09) [0x7f883e53de09]
??
??:0
#7 | /usr/lib/libgbm.so.1(gbm_create_device+0x61) [0x7f883e53f961]
??
??:0
#8 | /usr/lib/libwlroots.so.13032(wlr_gbm_allocator_create+0x87) [0x7f883ea77087]
??
??:0
#9 | /usr/lib/libwlroots.so.13032(+0x3d318) [0x7f883ea77318]
??
??:0
#10 | Hyprland(_ZN11CCompositor10initServerEv+0x1e7) [0x55d926a403a7]
??
??:0
#11 | Hyprland(main+0x79e) [0x55d926a2065e]
??
??:0
#12 | /usr/lib/libc.so.6(+0x27cd0) [0x7f883e045cd0]
??
??:0
#13 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7f883e045d8a]
??
??:0
#14 | Hyprland(_start+0x25) [0x55d926a35c95]
??
??:0
Log tail:
[LOG] Instance Signature: e5eb11ad0423bfdfd4056964ef868e26b2d3c846_1703712825
[LOG] Hyprland PID: 1582
[LOG] ===== SYSTEM INFO: =====
[LOG] System name: Linux
[LOG] Node name: archbtw
[LOG] Release: 6.6.8-arch1-1
[LOG] Version: #1 SMP PREEMPT_DYNAMIC Thu, 21 Dec 2023 19:01:01 +0000
[LOG] GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics Controller [8086:0412] (rev 06) (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GM200 [GeForce GTX 980 Ti] [10de:17c8] (rev a1) (prog-if 00 [VGA controller])
[WARN] Warning: you're using an NVIDIA GPU. Make sure you follow the instructions on the wiki if anything is amiss.
[LOG] os-release:
NAME="Archcraft"
PRETTY_NAME="Archcraft"
ID=archcraft
ID_LIKE=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archcraft.io"
DOCUMENTATION_URL="https://wiki.archcraft.io"
SUPPORT_URL="https://www.reddit.com/r/archcraft"
BUG_REPORT_URL="https://github.com/archcraft-os/archcraft/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archcraft
[LOG] ========================
[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/
[LOG]
Current splash: And all that I can see, is just a yellow lemon tree.
[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] [hookSystem] New hook event registered: configReloaded
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 22.00µs. Estimated average calc time: 0.03µs.
[LOG] Creating the ConfigManager!
[LOG] NOTE: further logs to stdout / logfile are disabled by default. Use debug:disable_logs and debug:enable_stdout_logs to override this.
[LOG] Creating the CHyprError!
[LOG] [hookSystem] New hook event registered: focusedMon
[LOG] [hookSystem] New hook event registered: preRender
[LOG] Creating the LayoutManager!
[LOG] [hookSystem] New hook event registered: preConfigReload
[LOG] Reloading the config!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 9.98µs. Estimated average calc time: 0.03µs.
[LOG] Using config: /home/palmerd/.config/hypr/hyprland.conf
[WARN] source= skipping non-file /home/palmerd/dotfiles/hypr/themes/
[LOG] Registered dynamic var "$background" -> rgb(1a1e25)
[LOG] Registered dynamic var "$foreground" -> rgb(ecdcbd)
[LOG] Registered dynamic var "$color0" -> rgb(1a1e25)
[LOG] Registered dynamic var "$color1" -> rgb(A99778)
[LOG] Registered dynamic var "$color2" -> rgb(D08870)
[LOG] Registered dynamic var "$color3" -> rgb(5A7598)
[LOG] Registered dynamic var "$color4" -> rgb(90768E)
[LOG] Registered dynamic var "$color5" -> rgb(6486AD)
[LOG] Registered dynamic var "$color6" -> rgb(7DA2C2)
[LOG] Registered dynamic var "$color7" -> rgb(ecdcbd)
[LOG] Registered dynamic var "$color8" -> rgb(a59a84)
[LOG] Registered dynamic var "$color9" -> rgb(A99778)
[LOG] Registered dynamic var "$color10" -> rgb(D08870)
[LOG] Registered dynamic var "$color11" -> rgb(5A7598)
[LOG] Registered dynamic var "$color12" -> rgb(90768E)
[LOG] Registered dynamic var "$color13" -> rgb(6486AD)
[LOG] Registered dynamic var "$color14" -> rgb(7DA2C2)
[LOG] Registered dynamic var "$color15" -> rgb(ecdcbd)
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 9.98µs. Estimated average calc time: 0.03µs.
[LOG] Registered dynamic var "$mainMod" -> SUPER
[LOG] Registered dynamic var "$dropterm" -> ^(kitty-dropterm)$
[LOG] Disabling stdout logs! Check the log for further logs.
[EGL] command: eglQueryDmaBufModifiersEXT, error: EGL_BAD_PARAMETER (0x300c), message: "EGL_BAD_PARAMETER error: In eglQueryDmaBufModifiersEXT: Invalid format
"
[render/egl.c:856] Failed to query dmabuf number of modifiers
[EGL] command: eglQueryDmaBufModifiersEXT, error: EGL_BAD_PARAMETER (0x300c), message: "EGL_BAD_PARAMETER error: In eglQueryDmaBufModifiersEXT: Invalid format
"
[render/egl.c:856] Failed to query dmabuf number of modifiers

Probably https://github.com/hyprwm/Hyprland/issues/1878. Try the steps on the multi-gpu wiki page https://wiki.hyprland.org/Configuring/Multi-GPU/

I have a similar issue. In my case, without GBM_BACKEND on the external display (the one connected to NVidia) some applications seem to have rendering refresh delays (gnome-terminal, kitty, ferdium), where the output takes too much to refresh some times.
If I move the mouse, they refresh instantaneously with no delay!
Apps like vscode or firefox are fine.
If I add env = WLR_DRM_DEVICES,/dev/dri/card1 (using nvidia only) the issue does not happen on the external display.

Was it fixed? New backend and all.


Add Linting / Spellcheck to Pipelines

We should add markdown linting and spellchecker to our pipeline to force consistency + correct spelling.
For markdown linting -- this would be things $ should only be present when the code snippet also includes output.

@cnunciato should we close this? move it to pulumi-hugo? something else?

This is a good idea, but I imagine there are some significant barriers to consider. We are currently working on grooming the documentation repo backlog and since we haven't had any motion on this in three years, and half of the ticket is completed, I'm going to close this ticket. If you think it should be re-opened, please leave a comment here and we can revisit it.


[Feature] Support new feature for backup/restore query and metric (#17526)

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #17526
Problem Summary(Required) ：
add some new feature for backup/restore:

support show all backup / show all restore to show all databases' backup/restore info
support show snapshot on repo in (snapshotname) to show specified snapshot
add starrocks_fe_unfinished_backup_job AND starrocks_fe_unfinished_restore_job to indicate the unfinished backup/restore job

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 55 / 84 (65.48%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/backup/RestoreJob.java
1
3
33.33%
[434, 1212]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
24
49
48.98%
[1802, 1803, 1813, 1814, 1815, 1827, 1857, 1858, 1859, 1861, 1862, 1863, 1864, 1866, 1867, 1869, 1872, 1873, 1874, 1875, 1876, 1879, 1880, 1881, 1882]

:large_blue_circle:
com/starrocks/sql/ast/ShowSnapshotStmt.java
3
4
75.00%
[48]

:large_blue_circle:
com/starrocks/backup/Repository.java
4
5
80.00%
[593]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/BackupRestoreAnalyzer.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/metric/MetricRepo.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/backup/BackupJob.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowRestoreStmt.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowBackupStmt.java
3
3
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 67 / 101 (66.34%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/backup/RestoreJob.java
1
3
33.33%
[434, 1212]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
24
49
48.98%
[1802, 1803, 1813, 1814, 1815, 1827, 1857, 1858, 1859, 1861, 1862, 1863, 1864, 1866, 1867, 1869, 1872, 1873, 1874, 1875, 1876, 1879, 1880, 1881, 1882]

:large_blue_circle:
com/starrocks/sql/analyzer/ShowSnapshotAnalyzer.java
12
16
75.00%
[87, 91, 97, 102]

:large_blue_circle:
com/starrocks/sql/ast/ShowSnapshotStmt.java
4
5
80.00%
[49]

:large_blue_circle:
com/starrocks/backup/Repository.java
4
5
80.00%
[593]

:large_blue_circle:
com/starrocks/sql/analyzer/BackupRestoreAnalyzer.java
4
5
80.00%
[269]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/metric/MetricRepo.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/backup/BackupJob.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowRestoreStmt.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowBackupStmt.java
3
3
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 69 / 102 (67.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/backup/RestoreJob.java
1
3
33.33%
[434, 1212]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
24
49
48.98%
[1803, 1804, 1814, 1815, 1816, 1828, 1858, 1859, 1860, 1862, 1863, 1864, 1865, 1867, 1868, 1870, 1873, 1874, 1875, 1876, 1877, 1880, 1881, 1882, 1883]

:large_blue_circle:
com/starrocks/sql/analyzer/ShowSnapshotAnalyzer.java
12
16
75.00%
[87, 91, 97, 102]

:large_blue_circle:
com/starrocks/sql/ast/ShowSnapshotStmt.java
4
5
80.00%
[49]

:large_blue_circle:
com/starrocks/backup/Repository.java
4
5
80.00%
[593]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/BackupRestoreAnalyzer.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/metric/MetricRepo.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/backup/BackupJob.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowRestoreStmt.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowBackupStmt.java
3
3
100.00%
[]

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 50 / 73 (68.49%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/backup/RestoreJob.java
1
3
33.33%
[434, 1219]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
22
37
59.46%
[1802, 1803, 1850, 1851, 1853, 1854, 1857, 1858, 1859, 1860, 1861, 1864, 1865, 1866, 1867]

:large_blue_circle:
com/starrocks/sql/analyzer/ShowSnapshotAnalyzer.java
12
16
75.00%
[87, 91, 97, 102]

:large_blue_circle:
com/starrocks/sql/ast/ShowSnapshotStmt.java
4
5
80.00%
[49]

:large_blue_circle:
com/starrocks/backup/Repository.java
4
5
80.00%
[593]

:large_blue_circle:
com/starrocks/metric/MetricRepo.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/backup/BackupJob.java
3
3
100.00%
[]

run starrocks_admit_test


feature: signin with google option(frontend)

rightnow there is no sign up/login with google option available on both pages.
adding sign up with google(frontend) option-btn and login with google(frontend) option-btn on both the login and sign up page.

@Vin205 can you please assign this issue to me under the gssoc-ext, hacktoberfest-accepted and level labels?

@Palmistry2310 ASSIGNED!


Old version download on rightfield.org.uk

The build available as download on rightfield.org.uk is really old and doesn't run on modern Mac systems without installing a deprecated Java version. A while ago I contributed an update to the Rightfield build process to make it possible to run Rightfield with a modern Oracle Java build. This build is not yet available as download.

@djvanenckevort  - thanks for the heads up - we're running into this issue - can you share your update out of band?  We'd like to build RightField on a newer Mac too!

@alaninmcr  is currently looking into this, and we hope to have a fresh build available soon as a high priority, followed by an overall refresh of RightField and incorporating some new work that has recently been done.
In the meantime, on a Mac it is possible to download and run the Linux version from the .sh file


kpt fn render does not support the same exclude flags supported in kpt fn eval

Expected behavior
kpt fn render supports the same --exclude-* flags supported by kpt fn eval
Actual behavior
kpt fn render does not support any --exclude-* flags
Information
kpt v1.0.0-beta.15 added support for various --exclude-* flags to kpt fn eval, but not kpt fn render. Our config workflow relies on kpt fn render to write results to an output directory. Using v1.0.0-beta.15 and higher, that output directory now contains Kptfile and any external FunctionConfig yamls which we do not want to apply to our k8s cluster.
Steps to reproduce the behavior
kpt fn render --exclude-kind Kptfile --output out . renders results to the directory out without the Kptfile.

@tgjonestx what tool are using to apply to a cluster ?
If you are using kpt live apply for applying to the cluster, then you can add  config.kubernetes.io/local-config: "true" annotation to the functionConfigs and Kptfile as shown below to indicate that they are local-config and doesn't need to be applied to the cluster. kpt live apply will ignore resources with local-config annotations. You can read the reference for the local-config annotation to learn more.
apiVersion: v1
kind: ConfigMap
metadata:
name: my-fn-config
annotations:
config.kubernetes.io/local-config: "true"
data:
test-id: test-01
project-id: test-02
Hope this helps.

@droot - we're not using kpt live to update our clusters; we're using Google Cloud's Config Sync feature, which implements a GitOps pattern, to update our clusters.  We take the output from kpt fn render, commit that to a git repo, and GCP's Confg Sync takes care  of applying the changes to a k8s cluster. We don't want the Kptfile or the function configs to be applied to our cluster.  I tried the local-config annotation with kpt fn render but it apparently ignores that annotation.

We don't want the Kptfile or the function configs to be applied to our cluster. I tried the local-config annotation with kpt fn render but it apparently ignores that annotation.

@tgjonestx config-sync uses the same library that kpt live uses and they ignore resources annotated with local-config annotation. I wanted to clarify one more thing: kpt fn render will not ignore resources annotated with local-config annotation. So the rendered config will have functionConfigs and Kptfile etc., but the applier (config-sync or kpt live) will ignore them.
Including @mortent who is more familiar with config-sync.

Just checking back ...
I find it interesting that GCP config-sync uses the same library as kpt, but even it ignores those files, there are plenty of other deployment solutions that may not (ArgoCD, FluxCD, Spinnaker, harness.io, DIY solutions built around kubectl apply, etc).  Philosophically, if a resource is not being used, then I don't want to add it to my k8s object space.  So if I were using kpt live and kpt live relied on those configuration resources, then fine. But I believe other users who would like to use kpt for configuration, but not deployment, would also like to exclude the functionConfigs from their clusters.

Just checking back ...
I find it interesting that GCP config-sync uses the same library as kpt, but even it ignores those files, there are plenty of other deployment solutions that may not (ArgoCD, FluxCD, Spinnaker, harness.io, DIY solutions built around kubectl apply, etc). Philosophically, if a resource is not being used, then I don't want to add it to my k8s object space. So if I were using kpt live and kpt live relied on those configuration resources, then fine. But I believe other users who would like to use kpt for configuration, but not deployment, would also like to exclude the functionConfigs from their clusters.

That's a fair point. We definitely want to ensure kpt to be easy to use with other gitops tools. Will investigate more.


[3.1.0] The users with the Internal/creator role get blocked after creating one document

Description:
The users with the Internal/creator role can only create one document from the Publisher Portal.
Steps to reproduce:

Login to the Publisher Portal as a user with the Internal/creator role.
Create an API.
Add a document for that API.
If you check the documents tab now, the Add New Document button is nowhere to be found, which result in the creator users are getting blocked after adding one document using the UI.

If you try the same steps with a user with the Internal/publisher role, that user can add multiple documents.

Affected Product Version:
WUM: wso2am-3.1.0<PHONE_NUMBER>606
U2: wso2am-<IP_ADDRESS>
Environment details (with versions):

OS: Ubuntu 20.04.2 LTS
Browser: Chrome, Firefox

This issue exists in APIM 3.0.0 as well.

I am not able to reproduce this behaviour in the master branch.


Plaintext passwords in error.log

Gitea version (or commit ref): 1.3.0 (possibly earlier too)
Git version: n/a
Operating system: Ubuntu 16.04
Database (use [x]):

[ ] PostgreSQL
[x]MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
While debugging a a separate issue, I checked log/error.log/gitea.log. imagine my horror when I saw plaintext usernames and passwords in the log.
This is not OK. Error level logs are enabled by default, stored in a folder owned by the gitea user. Any vulnerability in gitea that would grant access to those logs instantly gives access to all passwords ever entered. Additionally, any exploit of the server gives access to this as well.
I haven't checked how passwords are stored, but I fervently hope that are hashed with salt rather than plaintext in SQL.
log sample
Username, password and repo redacted for privacy.
2017/12/01 11:10:37 [...odels/repo_mirror.go:252 SyncMirrors()] [E] Failed to update mirror repository '/home/git/gitea-repositories/redacted/redacted.git': remote: Invalid username or password.
fatal: Authentication failed for<EMAIL_ADDRESS>error: Could not fetch origin

@issmirnov Agreed that this is a serious vulnerability. We will investigate.
For the record, passwords are salted and hashed; we do not store plaintext passwords in the DB.

@ethantkoenig - thank you for the quick response and clarification about DB password storage. Looking forward to a fix.

Thank you!!


[HOW-TO] Recording motion vector data

In Picamera 1.x.x existed a class PiMotionArray that output the motion vectors of the camera stream as obtained from the h264 encoder.
I couldn't find this class anymore in PiCamera2, is there an equivalent in the library or another option to obtain the motion vector from the h264 encoder, without having to explicitly compute them on the CPU?

We've been moving over to using standard Linux (V4L2)  APIs for things like video encoders, camera devices, and so on. Unfortunately there are no standard V4L2 APIs to access motion vector data so far as I know, so this feature is no longer available.

I see, that's unfortunate, it was a useful feature.


fix systemctl sequense to enable consul.service when it's already ena…

…bled
in case of having error:
==========================

Command start time 2016-02-24 13:32:28
Failed to execute operation: File exists

Connection to <IP_ADDRESS> closed.
SSH command execution finished
host=<IP_ADDRESS>, exitcode=1
Command end time 2016-02-24 13:32:38
Failed to execute operation: File exists

Connection to <IP_ADDRESS> closed.

ERROR: Bootstrap of host <IP_ADDRESS> fails because previous action finished with non-zero exit code (1)
ERROR MESSAGE: Execute of '<bound method BootstrapDefault.deployConsul of <BootstrapDefault(Thread-3, started daemon<PHONE_NUMBER>36384)>>' failed
STDOUT: Try to execute '<bound method BootstrapDefault.deployConsul of <BootstrapDefault(Thread-3, started daemon<PHONE_NUMBER>36384)>>'

fixed here https://github.com/pkutishchev/ambari/commit/36440de701d8ab1144eaa2a15b5b15c26e30533f


Add bonus question for step 2

Coverage increased (+3.7%) to 47.761% when pulling 5e63c376de80578b2899a654946f8dbbf48e1b14 on cat-leap-years into 74089f2a0c05c84a3224d1322ab4dd538d203fb9 on master.

I like it!


preloadPaywalls eventNames com.facebook.react.bridge.ReadableNativeMap cannot be cast to com.facebook.react.bridge.ReadableNativeArray

Seeing the following error on android when using:
Superwall.shared.preloadPaywalls(new Set(['event1', 'event2']));

Using
"@superwall/react-native-superwall": "1.3.4",
"react-native": "0.74.5",

It works if I switch it to an array instead of a Set, but typescript wants the Set:
Superwall.shared.preloadPaywalls(['event1', 'event2']);

Hey @pyb4430 !
Thanks for the report, the issue has been fixed in the latest version 1.3.5!


How would multi-variate transformation change the SHAP values?

I have a Random Forest model that is built on raw features and first-order interactions (tabular data). How should I map the SHAP values to the raw feature space for the interaction terms?

Model stacking is a great question. Exactly solving the problem in all cases is tricky, but for your case I would split the SHAP values given to the interaction terms in half and then add that to each of the SHAP values for the corresponding raw features. I would have think more carefully to decide how close that would be to the true values, but it should be a reasonable approximation.


Add kernelCTF CVE-2023-3776 (lts)

Hi, thanks for the comment.
We will fix the rest of our PRs after this one is merged because it's similar.


Switch to Poetry for package management

One file to rule them all.
(Well, actually, two files until flake8, mypy and coverage add support for pyproject.toml. See https://github.com/flying-sheep/awesome-python-packaging)

Changed my mind on this — the main drawback is that Poetry requires to be installed system-wide to work (running pip install poetry typically produces dependency clashes).
An alternative that doesn't have this issue is flit, which only addresses package publishing (not dependency management), which is one. It doesn't yet support src/ layout, but a PR has been merged earlier today: https://github.com/takluyver/flit/pull/260, which may be released in Flit 2.0 soon.

Also, the current vanilla setup isn't that bad — utility scripts help a lot.


pypi project issue

We where using the previous pypi project build. Did the previous owner transfer or was it abandoned? As our builds are broken today and trying to work out the best way around this.

Ah, sorry! @benjamin-hodgson can you provide the project under a different namespace?
How are you installing the project? You can install from git as a workaround.
pip install git+git://github.com/benjamin-hodgson/build.git

@arunchandarQA here's a work around or you could just inline the code

Yes, I was just looking at the code and it is pretty small so you could just add it to your project.
class Builder:
    """
    A base class for builders, supporting the "with" style of chaining methods.
    "With" methods are dynamically generated based on the names defined
    in the 'defaults' attribute (to be overridden by subclasses) according
    to the template ``with_{name}``.
    To subclass Builder:
        1. Define a class attribute (a list of tuples) called ``defaults``.
        2. Override the ``dict`` method if you need to use a custom dict class
        3. Define a ``build`` method which performs the required steps to
           build the object and returns an instance of the object.
    A 'with' method for each entry in ``defaults`` will be generated for you.
    >>> class MyBuilder(Builder):
    ...     # declare the defaults for the builder
    ...     defaults = [
    ...         ("abc", 123),
    ...         ("def", 456),
    ...         ("xyz", 789)
    ...     ]
    ...
    ...     def build(self):
    ...         # convert self.data into the object you're building
    ...         return self.data
    ...
    >>> result = MyBuilder().with_abc(-1).with_def(-2).build()
    >>> result == {'xyz': 789, 'def': -2, 'abc': -1}
    True
    """

    def __init__(self):
        self.data = self.dict(self.defaults)

    def __getattr__(self, name):
        if not name.startswith("with_"):
            raise AttributeError(name)
        if name[5:] not in self.data:
            raise AttributeError(name)

        def _with(value):
            """
            Sets the value of ``"{}"`` in ``self.data``.
            :param value: The value to set.
            """.format(name[5:])
            self.data[name[5:]] = value
            return self

        _with.__name__ = name

        return _with

    def dict(self, pairs):
        """
        Override me if you want to use a custom :class:`dict`
        subclass for ``self.data``.
        """
        return dict(pairs)

def evaluate_callables(data):
    """
    Call any callable values in the input dictionary;
    return a new dictionary containing the evaluated results.
    Useful for lazily evaluating default values in ``build`` methods.
    >>> data = {"spam": "ham", "eggs": (lambda: 123)}
    >>> result = evaluate_callables(data)
    >>> result == {'eggs': 123, 'spam': 'ham'}
    True
    """
    sequence = ((k, v() if callable(v) else v) for k, v in data.items())
    return type(data)(sequence)

@FFY00 Thanks, we will seek other means to fix our issues. Good luck with your project!

Sorry Toby! Didn't know you lot were still using it. Suggest just pasting the class into your codebase

Okay, I am closing am pinning the issue so that other people can see this :smile:.

@FFY00 Yeah, we'll just copy it into codebase
Bad @benjamin-hodgson  😄

@FFY00 You might wanna unpin this. :)


Add transactions to SpiDevice read/write methods

This addresses #71.

@dbrgn Not sure if you get notifications without being mentioned, so pinging you for visibility.
Could you approve the CI run on this PR?
Thanks, and have a nice weekend!

CI run approved!
I hope I can take a look at this soon-ish. If I forget, feel free to ping me 🙂

@teotwaki with #75, the 1-alpha branch was merged into main. Do you think you could re-apply your changes to main and update your pull request? Ideally with 1, 2 tests as well.

Sure; I'm just back from holiday so I'll look at this in the coming days to see if it's still relevant with the new embedded-hal revisions.


Not getting updated values from store inside onAction

I'm trying to logout user he/she us inactive for x number of minutes, I have two different different scenarios

Onboarding screen before login/register
Screens after login

So I am checking here if user is inactive on any of the Onboarding screens then I have to restart the Onboarding flow, If user login into the app then I have show the idle screen. For checking this status I am using the react native store but when onAction method call it always return the old store.
const performAutoLogout = async () => {
  if (!store.isUserLogin) {
    navigation.reset({
      index: 0,
      routes: [
        {
          name: 'Get Started',
        },
      ],
    })
  } else {
    navigation.reset({
      index: 0,
      routes: [
        {
          name: 'App Idle',
        },
      ],
    })
  }
}

return (
    <UserInactivity
      isActive={false}
      timeForInactivity={authTimeout}
      onAction={(isActive: boolean) => {
        // if timer exceeds x min then isActive = false and logout user
        if (!isActive) {
          performAutoLogout()
        }
      }}
    >
      <Stack.Navigator>
        {store.isUserLogin ? (
          <Stack.Group>
            <Stack.Screen name="Tabs">{() => <TabStack />}</Stack.Screen>
            <Stack.Screen name="Settings">{() => <SettingStack />}</Stack.Screen>
            <Stack.Screen name="Notifications" component={Notifications} />
            <Stack.Screen name="Idle Session" component={IdleSession} initialParams={{ setAuthenticated }} />
          </Stack.Group>
        ) : (
          <Stack.Group>
              <Stack.Screen name="Get Started" component={GetStarted} />
              <Stack.Screen name="Onboarding Screen" component={OnboardingScreen} />
              <Stack.Screen name="Terms" component={Terms} />
             <Stack.Screen name="Conditions" component={Conditions} />
          </Stack.Group>
        )}
      </Stack.Navigator>
    </UserInactivity>
  )

You can try saving and getting the data with async storage.
It's not the best way but it works for now.

You can create a copy of the state into useRef and then pass it, worked for me.


Backslashes need double key presses in Fr-Ca keyboard

Hi!
I have just figures out the problem with the Fr-Ca keyboard layout, but the solution eludes me.
It seems that the backslash needs to be double pressed in order to print properly. It's like the first one was escaping the second...
I tried just doubling them up but this makes the script not always compile, especially when there are only 2.
Is there a way to modify the keyboard.cpp to "double press" the backslash key?

Hello @Build-0-Matic, this seems that this is a system-dependent issue, on what OS are you running ?
Thanks !

I'm running Windows 10 Home Fall creator update 64 bit.

And when you type the \ by hand do you need to type it twice ?

No, when I type by hand it's just AltCar+\

Hello again @Build-0-Matic, this is weird, but I had the same issue in the French layout, and I didn't found any workaround, just maybe type the \ twice ?

That's what I have to do.
I find it quite annoying but I have the feeling that to fix it it would need a full re-write of the code.
I did recently check out how the Hak5 Bash Bunny works. They use the same language files for the USB Rubber Ducky's new HTML encoder. They have a JSON file to which the script passes the keystrokes. The JSON simply says this letter needs to be that key. And they have special combo keys listed separately as these don't change from one keyboard to the next.
In the end it looks like this
    "\"":"02,00,1f",
Where the first key is the modifier, 02 being SHIFT
The second is left empty, hence the 00
The third is the key to press on the keyboard in hex, 1f being the first key of the top row before the 1.
This system doesn't need the double keypress.

Hmm, quite cool, the problem is not in Duckuino tho, it's in the Arduino HID core, because when we say to press \ it doesn't.
But I think there could be a workaround, like I did for the Alt Gr keys.

While working on the rubber ducky keymaps, I did notice that ALT-GR is the same as CTRL+ALT
Maybe there's part of the solution there.
Or maybe get it to type that key as double everytime... but I can't remember if it needed to be pressed 3 or 4 times if you ask for a \


Feat doctor add timeout

Feat doctor add timeout, throw timeout error,  block checker.

Codecov Report

Merging #660 (8221703) into master (d3eaa6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   57.14%   57.14%
=======================================
  Files           1        1
  Lines          70       70
  Branches       18       15    -3
=======================================
  Hits           40       40
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3eaa6a...8221703. Read the comment docs.


Adding chunking functionality

Still need to add tests, but from what I can tell this in large part works. Basically, if you specify chunk_size, each segment gets returned as a generator of chunk_size long chunks. This means even if a segment is less than chunk_size, it will be returned as a generator that will just return one element.

@EthanMarx all the most relevant functionality should be implemented and tested now. Let me know your thoughts and feel free to merge if all good

Note that testing the ProcessPool implementation is tricky because mocks aren't picklable and so can't be passed from process to process

Okay cool. Going to stress test it a bit and then will merge. Would it be straightforward to add retain_order to the find_data API so that users can specify if they want the segments returned in order even when not chunking

Would it be straightforward to add retain_order to the find_data API so that users can specify if they want the segments returned in order even when not chunking

Yeah don't see why not, should pass through pretty straight-forwardly. The thing I guess to be aware of is that when you're chunking, order is always retained: generators for each segment are returned in the order the segments were passed. Not sure if it's worth flagging this to the user if they pass retain_order=False and a value for chunk_size but figured I'd mention it.


Fix noopener regex

This was using [] instead of (), so it was only comparing the last
character of the first word and the first character of the second word.
False positives were still extremely unlikely, so it wasn't a big
problem.

v3.0.1 :tada:


swaylock-effects: 1.6.11 -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/swaylock-effects/versions.
meta.description for swaylock-effects is: Screen locker for Wayland
meta.homepage for swaylock-effects is: https://github.com/jirutka/swaylock-effects
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS> with grep in /nix/store/bgz6w2c0wv5rxi8n5xy1ljlzi0xhgq6s-swaylock-effects-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/bgz6w2c0wv5rxi8n5xy1ljlzi0xhgq6s-swaylock-effects-<IP_ADDRESS>

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
swaylock-effects

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bgz6w2c0wv5rxi8n5xy1ljlzi0xhgq6s-swaylock-effects-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A swaylock-effects https://github.com/r-ryantm/nixpkgs/archive/737479f9a3aae7604e7c3924afc83f0966af15f7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/737479f9a3aae7604e7c3924afc83f0966af15f7#swaylock-effects

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bgz6w2c0wv5rxi8n5xy1ljlzi0xhgq6s-swaylock-effects-<IP_ADDRESS>
ls -la /nix/store/bgz6w2c0wv5rxi8n5xy1ljlzi0xhgq6s-swaylock-effects-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

swaylock-effects

Maintainer pings
cc @gnxlxnxx for testing.

tested + nixpkgs-reviewed it. Worked just fine.


fix full day recurring events not showing

Does the pull request solve a related issue?

If so, can you reference the issue?
#2110 #2111 #2118

What does the pull request accomplish? Use a list if needed.
check for full day event and NOT adjust timezone time (as it should be midnight local), before calling rrule to get the events from the rule. adjusting the time causes today to be skipped as its past midnight.

@MichMich what is wrong here, travis builds failed no env set..  that is not a code problem

@MichMich   this build failed cause prettier failed in travis
The command "npm run test:prettier" exited with 1.

I fixed the issue. For future reference:
npm run test:prettier shows the issues, npm run lint:prettier fixes the issues. :)

I thought the whole point of the husky hook was to not have to run anything?
I don't see where the problem was

Yeah that should happen automatically when you git commit (see https://git-scm.com/docs/githooks#_pre_commit) Do you invoke git with --no-verify ?

@rejas  no.
it did get invoked on my desktop, not on my Chromebook. it looked like a normal precommit hook for prettier. ( on my last commit/push)
trying to figure out what didn't work now. this is 1st commit / push since the prettier stuff was added in 2.12
I added it via precommit hook to all my repos

ok, this is my fault.. when i added the changelog on my chromebook, the hook did not work. and i pushed the bad file.
when I went to my desktop, i forgot the changelog, so when the hook fired it only processed the js file..
sorry.. still didn't see the error in the job log..


go to another view

Hello
I am trying to go to " another view control in main storyboard " by a button in one of the subviews
this what I did :
import UIKit
class GamesViewController: UIViewController {

    @IBAction func goToPlayView(sender: UIButton)

   {
        let mainStb = UIStoryboard(name: "Main", bundle: nil)
        let play = mainStb.instantiateViewControllerWithIdentifier("Play") as! PlayViewController
        self.presentViewController(play, animated: true, completion: nil);
    }
}

and I got this warring :
Presenting view controllers on detached view controllers is discouraged
please help

@AliAyasrah is this question related to BWWalkthrough?!


OGC TMS Spec 2.0

http://www.opengis.net/doc/IS/tms/2.0

https://github.com/OSGeo/gdal/issues/6832#issuecomment-1344626351
https://docs.opengeospatial.org/is/17-083r4/21-066r1.html#Clause_Critical

it looks like this issue may be more relevant to address as per https://github.com/opengeospatial/NamingAuthority/issues/199

I'd be interested in working on this issue. Would you prefer to continue supporting the TMS 1.0 specification (perhaps with a deprecation warning?) or completely overhaul the model to only support TMS 2.0?

🙏 @dchirst
I think we can think about morecantile 4.0 to only support TMS 2.0 !

@vincentsarago Fabulous! I'll start on a draft PR, and will let you know when I've made a first stab at it. There will likely be a few mistakes!


Normalize (and imo improve) periodic statistics collection in MAD.

Adds mappedDimension to PeriodicStatisticsSink to allow renaming of dimension extracted from the data stream and partitioning the output periodic statistics; (e.g. _namespace to namespace)
Converts identifier String creation to use Key for metric+dimension-key (aka statistic tracking).
Removes statistic from that tracking; MAD installs now only compute histogram internally.
Removes period from that tracking; it doesn't really make sense (imo).
Simplifies the AggregatedData iteration.
Clarifies the usage of PeriodicStatistics sink; namely, that it should be used in a single period sink-chain.

Not at the moment. The better solution in my opinion is to support validated with method on the class level.


Explicitly set empty badge text on green and gray flag states (issue #8)

Explicitly set empty badge text on green and gray flag states (issue #8)

Reviewed internally


move metadata for image based gadgets to a versioned location and remove dependencies

This moves some of the metadata structs for image based gadgets out of the run gadgets' scope to be easier accessible by other packages and without having additional dependencies (to cilium/ebpf etc.) - the only remaining dependency (on pkg/params) will probably be removed after #2512.
The metadata extraction is/was part of #2512 - as requested, it has been extended to adopt the changes to the run gadget in this PR.

Thanks for the review!


ZBook 15 G2: TPM ManufacturerID can not be read

An error is shown when the script tries to access the TPM ManufacturerID on a ZBook 15 G2 (newest BIOS). This shouldn't happen

The error was not reproducible and the code is already include in a try/catch block. Leaving this bug report open until a second test machine is accessible.

Tried last week with another 15 G2, no problem reading the TPM ManufacturerID. Assuming broken test device, closing issue.


footer component

remove normal code and use component

bro explain a bit which code should be removed

Hey @HarshithAlfred, looks like someone already fixed it into Bottom Container.


Use OS num CPUs instead of runtime schedulable ones

Why?
runtime.NumCPU() does not report the present/available CPUs it reports the schedulable ones.
What?
Read available CPUs from sysfs.
How?
Using the numcpus package.
Test Plan
Tested locally and it works, and added a metric to report the detected number as well.

Odd, since the library we now use seems to do it correctly: https://github.com/tklauser/numcpus

@brancz , I was referring to this code: https://github.com/parca-dev/parca-agent/blob/2812709a/pkg/profiler/cpu/cpu.go#L812-L819
Note that if the available CPUs is not a contiguous range from 0 to n, this logic is wrong.
I think this is what's causing https://github.com/parca-dev/parca-agent/issues/2639

Ooooooh I see, yes makes sense!