AemEnvironmentIndicatorFilter fails to trigger on the author environment, due to WCMMode being DISABLED

Bug Report
Current Behavior
When configuring the AemEnvironmentIndicatorFilter with the configuration: css-color="#ff00ff", we do not see an environment indicator being shown in the OSGi console, in the AEM interface, etc.
Expected behavior/code
An environment indicator being shown.
Environment

AEM 6.4 SP8
ACS AEM Commons 4.8.0
JRE version 8 build 200+

Possible Solution
It looks like the WCMRequestFilter is being ran after the AemEnvironmentIndicatorFilter. Therefore the AemEnvironmentIndicatorFilter receives WCMMode.DISABLED as the current WCMMode, which is the default excluded WCMMode.

It looks like the filter is being registered as a Jetty filter, while the WCMRequestFilter is a Sling Filter and therefore runs much later in the chain.
It also looks like a recent update changed the way of obtaining the WCMMode from request.getAttribute(...) to WCMMode.fromRequest(request).
https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/wcm/impl/AemEnvironmentIndicatorFilter.java#L371
The problem here is that in the previous case, null was returned, but now WCMMode.DISABLED is returned (since WCMMode.fromRequest()) actually returns WCMMode.DISABLED when the attribute could not be found. Therefore, it never registers the filter.
WDYT @davidjgonzalez @justinedelson ?

If you change it to a Sling Filter instead of a Jetty Filter, you will also get the following problem: the Indicator won't show up in CRX/DE Publish (which it did before) because the WCMMode == WCMMode.DISABLED in that case too.
It looks like the Unit Test is also testing the class not as it should be, because it is using a spy: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/test/java/com/adobe/acs/commons/wcm/impl/AemEnvironmentIndicatorFilterTest.java#L76
Maybe the test can also be updated with actual testing of the accepts method.

Hi @rubnig, thanks for reporting. I will try to investigate on that.
As you already mentioned, this filter has to be registered with the HTTP whiteboard, otherwise it won't appear on the Webconsole and in CRXDE.

@rubnig I tried to reproduce your problem, but the information provided is not sufficient. Can you please be more specific which OSGI property I have to set with the value  css-color="#ff00ff"?
If I follow the documentation at https://adobe-consulting-services.github.io/acs-aem-commons/features/environment-indicator/index.html, it works fine.
Can you please refine your problem description, so I can actually reproduce it?

Hi @joerghoh , did you use the 4.8.0 version in combination with for example AEM 6.4.8?
If you configure it, it might work. If you however restart AEM, it's not working anymore.
While debugging, you can see that the WCMMode.fromRequest(request) yields WCMMode.DISABLED.
The problem is that previously, the method that was determining the WCMMode, was returning null in that case.

hi @henrykuijpers
I tried this approach:

I had 6.4.5 handy.
I deployed ACS AEM Commons 4.8.5-SNAPSHOT
configured the EnvironmentIndicator like this

set the property "ccs-override" to the CSS posted on the documentation page
set the property "inner-html"

refreshed the page, the environment indicator is present in the OSGI webconsole
I restarted the instance to deploy 6.4.8, afterwards the environment indicator is present.
restarted the instance again, the environment indicator is present.

From what I see the last change to the EnvironmentIndicatorFilter has been with #2271 fixing a bug which seems quite unrelated to your problem.
From looking at the code, the WCMMode.DISABLED (if no WCMMode is specified) is not problematic per se.
Do you have set the OSGI property "excluded-wcm-modes" to contain "DISABLED"? In that case you don't get the EnvironmentIndicator set, that's true. But that's going to be expected then.

We'll need to test this a bit further tomorrow then. Can you in the meantime please try with 6.4.8? As that is the exact version we were using when we saw it not working anymore.

I have version 6.4.8 running now, and everything is working fine.

We'll investigate further tomorrow then.
How can WCMMode be available as a request attribute in a jetty filter, if it is being set in the WCMRequestFilter, which is a sling filter and therefore runs much later?
Because, if it is not available a request attribute, WCMMode.fromRequest(request) returns WCMMode.DISABLED. At least, that's what we saw from decompiled code. And since the default excluded WCMMode is DISABLED, it does not render the indicator.
Do you see a value other than DISABLED come back when getWcmMode is being called? @joerghoh

Good catch.
I agree, the WCMMode is never available as request attribute because the environment filter is running earlier than the WCMRequestFilter. Thus any handling based on the wcmMode is unlikely to function (not sure if it ever worked at all), except the case when you provide "DISABLED" to the "excluded-wcm-modes" property.

Hi @joerghoh ,
So I'm using ACS AEM Commons 4.8.0, with the following configuration:
<?xml version="1.0" encoding="UTF-8"?>
<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0"
    jcr:primaryType="sling:OsgiConfig"
    css-color="#ff7676"/>

This is my debugger view when I'm in the accepts-method:

As you can see, I have the css-field set (css-color OSGi property) and I'm using the default excluded WCM modes.
My debugger view when I'm in WCMMode.fromRequest:

As you can see, when the request attribute could not be found (which makes sense, since that request attribute is set in WCMRequestFilter,  which runs after the AemEnvironmentIndicatorFilter, so it can never be set at this point) it defaults to WCMMode.DISABLED.
Then, of course, this method will return true:
    boolean isDisallowedWcmMode(WCMMode currentMode, String[] excludedWcmModes) {
        return currentMode == null || StringUtils.equalsAnyIgnoreCase(currentMode.name(), excludedWcmModes);
    }

and therefore the environment indicator will never be shown. WDYT @joerghoh ?

Hi @henrykuijpers
I am bit confused, because in see in your screenshot, that titlePrefix is empty (""), and thus isImproperlyConfigured() would return false already, thus returning immediately.
And regarding the method "sDisallowedWcmMode(): I agree, that this logic is unlikely to work properly. It just works, if no WcmMode is configured to be excluded.
Can you give it a try with that?
(Yes, we need to fix this logic, but I doubt that we can do that properly without duplicating the wcm-mode logic from AEM. I would rather remove "do not display it in certain runmodes" feature completely.)

@joerghoh , with regards to isImproperlyConfigured, no that is not true: if you look carefully you'll see that "improperly configured" means that both the CSS color and the title prefix are empty. In our case we do not set the title prefix, as we do not want to modify the browser title.
We can indeed try with the disallowed WCMModes being an empty array, but that will also render the indicator on WCMMode.DISABLED, which is obviously not what we want.

OK, got it.
The only way of fix I can think of would be to use an additional filter, which is run after the WcmMode is determined, and which remove the data inserted by the first filter (which is still registered at the HTTP Bridge as today).

This approach would require buffering the whole response. I would rather get rid of the option to enable/disable based on WCM mode (i.e. remove property https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/eb7219a8ac462414b51e3e76cf74bbdbefbe78bb/bundle/src/main/java/com/adobe/acs/commons/wcm/impl/AemEnvironmentIndicatorFilter.java#L149) as this was also never documented at https://adobe-consulting-services.github.io/acs-aem-commons/features/environment-indicator/index.html. Instead I would introduce options to disable for certain path prefixes (/content) and enable for others (i.e. /editor, /sites). That would also cover the "Show as published" option which would not expose the indicator any longer.

@kwin The buffering is already there :-(, see https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/eb7219a8ac462414b51e3e76cf74bbdbefbe78bb/bundle/src/main/java/com/adobe/acs/commons/wcm/impl/AemEnvironmentIndicatorFilter.java#L183
and I don't really like that either, and I also don't see a way to get rid of this behavior without changing the complete approach.
But it's actually not that hard to implement the proper handling of the WcmModes with the mentioned 2 filters.

@henrykuijpers Can you please try https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2407 and check if it fixes the described problem?
In my tests it does, but it's actually hard to write unittests for this, because it relies a lot on behavior of AEM in other areas.

This is a pretty good solution, @joerghoh . I'll make some time tomorrow to test this. :)
I've added some comments in the PR, out of which one is pretty important.
I'd like to highlight something though: We've never configured the excluded wcm modes ourselves. This was default behavior.  Recently, the way of obtaining the WCMMode was changed in the filter code, which made it return DISABLED instead of null. That's when the indicator stopped working for us (and probably almost everyone else). We were not using some sort of exotic configuration. It's the recent code change that broke the filter.
I still don't like the way this filter is unit-tested, the spy-construction that is used prevents important runtime functionality to be properly tested (the WCMMode.disabled issue would have been found a lot earlier with proper rest cases in place), but let's fix one thing at a time. I'd be willing to improve the unit tests together with my colleague in another issue.

I thought it was strange that you didn't remove the WCMMode-check from the accepts-method. Today I had a chance to test the changes and indeed, with that check still in place, accepts would return false when accessing crx/de for example.
So, when I deployed the changed code and then accessed the OSGi console, crx/de, etc. I didn't see an environment indicator. When stepping through the code, it became apparent immediately that the WCMMode check was still in place outside the Sling Filter (where it could work).
Is my environment somehow different? The lack of the environment indicator was spotted immediately in my case.
I suggested another change in the PR.

@henrykuijpers I performed some changes in the mentioned PR and also removed the suggested check for wcmmode in the outer filter. Can you please recheck?

This has been fixed with #2407


_NT_SYMBOL_PATH not work

https://github.com/DarthTon/Blackbone/blob/8dee223515bc9777c738530f6cb0960af66bf59f/src/BlackBone/Symbols/PDBHelper.cpp#L26
MSDN：

If the function fails, the return value is zero.

Yes, that's the purpose of that code, i.e. if there is no NT_SYMBOL_PATH var, store symbols in tmp location.

But if set NT_SYMBOL_PATH var _sympath will empty.

It's fine, NT_SYMBOL_PATH will be used as a cache dir.

OK，tks answer.


Not all cucumber data is added to the reporter

When using CucumberJS standalone you can get an very comprehensive JSON report containing more info than wdio-cucumber-framework is providing.
I miss for example the following data when I try to build my own reporter:

The Given|When|Then keywords
feature descriptions
datatable data

The data itself can be retrieved from the reporter with for example the following feature
Feature: Create data feature
    This is a feature description

    Scenario: a table scenario
        This should be a scenario description
        Given a table step
            | Cucumber     | Cucumis sativus |
            | Burr Gherkin | Cucumis anguria |

When I place some logs in the reporter.js I see I get the data
handleBeforeFeature
feature =  { type: 'Feature',
  tags: [],
  location: { line: 2, column: 1 },
  language: 'en',
  keyword: 'Feature',
  name: 'Create data feature',
  description: '    This is a feature description',
  children:
   [ { type: 'Scenario',
       tags: [],
       location: [Object],
       keyword: 'Scenario',
       name: 'a table scenario',
       description: '        This should be a scenario description',
       steps: [Array] } ] }

handleBeforeScenario
scenario =  { tags: [],
  name: 'a table scenario',
  language: 'en',
  locations: [ { line: 5, column: 5 } ],
  steps:
   [ { text: 'a table step', arguments: [Array], locations: [Array] } ] }

handleBeforeStep
step =  { type: 'Hook',
  location:
   { line: 90,
     column: 0,
     uri: 'Projects/wdio-multiple-cucumber-html-reporter/node_modules/cucumber/src/support_code_library_builder/define_helpers.js' },
  keyword: 'Hook',
  text: '' }

handleBeforeStep
step =  { type: 'Step',
  location: { line: 7, column: 9 },
  keyword: 'Given ',
  text: 'a table step',
  argument:
   { type: 'DataTable',
     location: { line: 8, column: 13 },
     rows: [ [Object], [Object] ] } }

handleBeforeStep
step =  { type: 'Hook',
  location:
   { line: 90,
     column: 0,
     uri: 'Projects/wdio-multiple-cucumber-html-reporter/node_modules/cucumber/src/support_code_library_builder/define_helpers.js' },
  keyword: 'Hook',
  text: '' }

Is there a reason to not expose this data? And if not, do you also allow a PR to add that data? It would help a lot making more readable reports.
Tnx in advance

Status update:
Started with the initial setup. Reporter is already adjusted, now need to add some tests and make a PR, see https://github.com/wswebcreation/wdio-cucumber-framework/blob/feature/enrich-reporter/lib/reporter.js

This has been fixed with https://github.com/webdriverio/wdio-cucumber-framework/pull/136 and released in version 2.2.0


clean up output

Really useful plugin thanks...
this console.log is really just spam.
Most metalsmith plugins use the debug module so you can at least squelch overzealous plugins.
Really though I think the most appropriate output would be a single line reporting how many urls have been included in the sitemap. Anything additional should probably be optional.
Happy to put together a PR if you would consider merging it.

@leviwheatcroft My apologies for the (incredibly) late merge - thanks for the PR.


Adding sender alias

Can we do:
        // Addresses can be specified by the tuple (email, alias)
<EMAIL_ADDRESS>"Firstname Lastname"))

Same as we can do:
        // Addresses can be specified by the tuple (email, alias)
<EMAIL_ADDRESS>"Firstname Lastname"))

This does work already, doesn’t it?

This does work already, doesn’t it?

Indeed.


anchor fm webhook to netlify

As a podcast producer
I can publish a new episode of the podcast
So that share the episode link of the website

For now gatsby build is triggered only when a new article is posted on prismic.
We should have a way to automate the build with anchor fm.

https://twitter.com/DennisCode/status/1515041322180120577?s=20&t=reZ_emOZoi4Odi3dTDQJNA
https://css-tricks.com/netlify-has-scheduled-functions/

✅ with Zapier


FCirc Multi 2 - Format Changes

Summary Change Description
Almost everything changed in here relates to changes necessary to display the fcirc output format for the new tracer/label model structure so that it can be split up by serum sample, tracer, and element.  What was previously 1 row in the FCirc output table can now be a row for every tracer & its labels.
  These changes are just copies of files from the fcirc_multi branch dropped into a new branch off the infusate_label branch (the starting point of the master branch for this effort).  I am breaking that code review up into these smaller PRs that are separated by theme.  I am doing it by file simply because it's easier.  If any code here references something you cannot find, just consult to fcirc_multi branch/PR.
The PRs I will be submitting are:

fcirc_multi_models
fcirc_multi_format (this PR)
fcirc_multi_validation
fcirc_multi_pagination
fcirc_multi_tests
fcirc_multi_minor (comments/renames/etc)

Checklist
These are the checks for the overall change set...

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
Tests

[ ] Tests implemented (or no code changes)
[x] All multi_working tag tests pass locally
[x] All example load tests pass (remotely) (or their failures predated and are unrelated to this branch)
[x] @tag("multi_working") added to newly passing test functions/classes (or no newly passing tests)
[x] @tag("multi_broken"), @tag("multi_unknown"), or @tag("multi_mixed") removed from newly passing test functions/classes (or no newly passing tests)

Will merge from #493


is this project dead ?

it seems to me its implementation gets the job done.

This looks like a viable full replacement https://github.com/apragacz/django-rest-registration
Though JWT support isn't baked in as it is with djoser.

i think it dead

Looks like they came back, and updated the project. I guess not dead yet

Looks like it is not
Ownership should be transferred


RC > Replace JSCS/JSHint with ESLint

Codecov Report

Merging #506 into rc-2.0.0 will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37aee93...ded51d5. Read the comment docs.


fftw: convert to pname+version, use https for fetching, expose withDo…

…c, remove ? null from inputs

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

nixpkgs-review fails with:
error: attribute 'bijiben' missing
Then it tries to fetch a load of packages

nixpkgs-review fails with: error: attribute 'bijiben' missing

bijiben is an alias to gnome notes and nixpkgs-review lately disables aliases. I am not sure why ofborg lists them and how to fix that. Easy workaround is to add --eval local.


[Bug]

Describe the bug
devika modulenotfounderror
How To Reproduce
Steps to reproduce the behavior (example):

Install devika
try to run devika

Windows 11, python 3.11.9
mistralai package exists 100% confirmed
devika>python devika.py
24.08.11 19:38:33: root: INFO   : Initializing Devika...
24.08.11 19:38:33: root: INFO   : checking configurations...
24.08.11 19:38:33: root: INFO   : Initializing Prerequisites Jobs...
24.08.11 19:38:35: root: INFO   : Loading sentence-transformer BERT models...
24.08.11 19:38:37: root: INFO   : BERT model loaded successfully.
Traceback (most recent call last):
File "C:\Users\frenz\Downloads\LLMs\devika\devika.py", line 24, in
from src.agents import Agent
File "C:\Users\frenz\Downloads\LLMs\devika\src\agents_init_.py", line 1, in
from .agent import Agent
File "C:\Users\frenz\Downloads\LLMs\devika\src\agents\agent.py", line 1, in
from .planner import Planner
File "C:\Users\frenz\Downloads\LLMs\devika\src\agents\planner_init_.py", line 1, in
from .planner import Planner
File "C:\Users\frenz\Downloads\LLMs\devika\src\agents\planner\planner.py", line 3, in
from src.llm import LLM
File "C:\Users\frenz\Downloads\LLMs\devika\src\llm_init_.py", line 1, in
from .llm import LLM
File "C:\Users\frenz\Downloads\LLMs\devika\src\llm\llm.py", line 11, in
from .mistral_client import MistralAi
File "C:\Users\frenz\Downloads\LLMs\devika\src\llm\mistral_client.py", line 2, in
from mistralai.models.chat_completion import ChatMessage
ModuleNotFoundError: No module named 'mistralai.models.chat_completion'

Hello,
I encountered the same issue, it seems to be due to a new version of mistralai, so I opted for an older version prior to version 1.0.0. In the requirements.txt, I replaced mistralai with mistralai==0.4.2.

I replaced mistralai with mistralai==0.4.2.

Thanks Bro!
This works for me.


Accessories doesn't sync

Analysis
I've noticed that the Apple TV accessory doesn't change to the correct state when I use the Turn On or Turn Off buttons. Also, it doesn't work the other way around either
Expected Behavior
The Apple TV accessory and buttons should sync properly.
Steps To Reproduce
https://github.com/maxileith/homebridge-appletv-enhanced/assets/2865924/22211fe3-564c-46fa-a827-2b48d5ae06fa
Logs
[1/7/2024, 10:47:36 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: turn_on
[1/7/2024, 10:47:50 AM] [Apple TV Enhanced] Platform: Starting device discovery ...
[1/7/2024, 10:47:57 AM] [Apple TV Enhanced] Platform: finished multicast device discovery
[1/7/2024, 10:47:57 AM] [Apple TV Enhanced] Platform: Found Apple TV Living Room (3) (EC:A9:07:21:AD:F9 / <IP_ADDRESS>).
[1/7/2024, 10:47:57 AM] [Apple TV Enhanced] Platform: Apple TV Living Room (3) (EC:A9:07:21:AD:F9) with UUID 87cca5a0-c5dd-4fd6-a927-d3a53f6858aa already exists. Skipping.
[1/7/2024, 10:47:57 AM] [Apple TV Enhanced] Platform: Finished device discovery.
[1/7/2024, 10:48:00 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: Skipping heartbeat since last command was only 24s before.
[1/7/2024, 10:48:13 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: turn_off
[1/7/2024, 10:48:22 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: turn_off
[1/7/2024, 10:48:29 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: turn_on
[1/7/2024, 10:48:37 AM] [Apple TV Enhanced] Apple TV Living Room (EC:A9:07:21:AD:F9): Rocket Remote: turn_on

Configuration
{
    "mediaTypes": [
        "music",
        "tv",
        "unknown",
        "video"
    ],
    "deviceStates": [],
    "remoteKeysAsSwitch": [
        "turn_off",
        "turn_on"
    ],
    "customInputURIs": [],
    "discover": {
        "unicast": [],
        "blacklist": [],
        "multicast": true
    },
    "name": "Apple TV Enhanced",
    "deviceStateDelay": 0,
    "avadaKedavraAppAmount": 15,
    "disableVolumeControlRemote": false,
    "forceVenvRecreate": false,
    "logLevel": 4,
    "_bridge": {
        "username": "0E:A9:87:29:EB:F0",
        "port": 55391
    },
    "platform": "AppleTVEnhanced"
}

Environment

OS: Raspbian GNU/Linux Bullseye (11)
Docker: false
Homebridge: 4.54.1
Apple TV Enhanced:
Node: v20.10.0
npm: v10.2.3
Python: 3.9.2
pip: 20.3.4

Additional Context
No response

Duplicate of #155

Hey @maxileith it's not the same issue. My interaction in this issue wasn't with the physical remote control.

Does the active state of the Apple TV accessory update when using the physical remote?

I've created another one: https://github.com/maxileith/homebridge-appletv-enhanced/issues/167

Don't mess up the issues. Why not reopen this issue? I am gonna delete #167

From #155 it becomes clear that you are using HomePods as your default speakers.
From the README:

If using external speakers like HomePods as the default, the Apple TV is always reported as powered on. This is a known issue of the dependency pyatv, see postlund/pyatv#1667. As a result, the Apple TV device will only be shown as off in HomeKit when powered off via the Apple TV device in HomeKit. After restarting the plugin the device will always be shown as on.

That's sad. 😢
I will follow the original issue on pyatv thanks!


Average is not defined.

Average is a measure of central tendency. https://en.wikipedia.org/wiki/Average
What measure of central tendency is used for the avg formula?
Is this the mean? median? mode? A combination based on 'best fit'? Each measure of central tendency has it's own strengths and weaknesses, so it's important to know which is used.
Perhaps, this is a poor name for this method, and a more descriptive name could be used. In the mean time the documentation needs to make up for ambiguity caused by the name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29539902-bafe-e576-c61c-904d97521a75
Version Independent ID: 995be722-d19d-562f-4797-345f5db43574
Content: avg() (aggregation function) - Azure Data Explorer
Content Source: data-explorer/kusto/query/avg-aggfunction.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

Hello @wandyezj
I have assigned the issue to the content author for further review and update the doc as appropriate.

Hi @SatishBoddu-MSFT - Thanks for your question. The word 'average' as used here refers to the arithmetic mean, which has been updated in the docs.
#please-close


Adding RecordingStorageMode

@brandber or @tomkau can you kindly help me getting a more complete description for the parameter? I really appreciate.
closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/6114

Docs Build status updates of commit 43e4d88:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 43e4d88:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Changing this to ready for review, in any case if we can get a more complete description for the parameter in the near future.

@yogkumgit ready to be merged

Docs Build status updates of commit b778b94:
:clock10: Full build: the average full build time is 17 min(s) 39 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit b778b94:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 83a4463:
:clock10: Full build: the average full build time is 17 min(s) 39 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 83a4463:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Modify run_micro_bench.py to only have a single list of benchmarks

Any time we add a new microbenchmark, you have add it to run_micro_bench.py in two places:

https://github.com/cmu-db/terrier/blob/master/script/micro_bench/run_micro_bench.py#L31-L40
https://github.com/cmu-db/terrier/blob/master/script/micro_bench/run_micro_bench.py#L716-L725

From the what I can tell, there is no reason to repeat this list and thus it is unnecessarily complex. We should refactor the code to have a single list of benchmarks at the top.
I will fix this.

Fixed in #565


changes for building on osx arm64

…nda-forge-pinning 2<IP_ADDRESS>.57.19

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Changes for building on osx arm64 (a.k.a M1 CPUs)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The osx arm64 build does not work on the azure x86_64 hardware.
Here is an example from the following log.
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=561149&view=logs&j=385a3385-ae8b-54d1-9abe-3c614f74cb73&t=a5f9d343-149e-5621-6ab9-f0278009be04
/bin/sh: /Users/runner/miniforge3/conda-bld/nwchem_1661966075980/work/bin/MACX64/depend.x: Bad CPU type in executable

However, I can build on my M1 laptop.

Apparently, one can request osx arm64 migration by adding the name of the package to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/osx_arm64.txt
Not sure whether that automatic migrator will do anything different from what you did; but maybe worth a try?

Apparently, one can request osx arm64 migration by adding the name of the package to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/osx_arm64.txt
Not sure whether that automatic migrator will do anything different from what you did; but maybe worth a try?

I have just pushed a couple of changes that should survive the cross-compilation. Let's see what happens.

arm64 on x86: skip qa tests
build depend.x with x86 compiler & skip python module

Unfortunately the gfortran  cross-compiler (arm64-apple-darwin20.0.0-gfortran) seems to be able to generate objects but the link phase fails to create an executable with the error
ld: library not found for -lgfortran


How to get all reviews

I am getting 3 comments and related data only how to get all reviews

Per yelp api documentation at most 3 reviews are returned for a business. You may want to contact them for a server-side feature request.
Closing as this is not related to the client code.

Ok Thank you

Can I get the Menus


Add a way to enable authorization on all properties

Is your feature request related to a problem? Please describe.
I am building an api with hotchocolate and one of the feature i use is the @authorize directive
currently most of the queries and mutations require a user so i have to repeat @authorize in front of most of the queries and mutations
Describe the solution you'd like
it would be better if i can make authorization enabled by default on all queries and mutations and introduce a new directive that remove the authorization on specific query or mutation

We are at the moment thinking about authorize on the schema

In v11 we can do the following to require authorization for all operations.
app.UseEndpoints(endpoints =>
{
    endpoints.MapGraphQL().RequireAuthorization();
});


Is this actually connected to Solana?

My wallet never pops up, and I don't see any data displayed or transactions I can send...

Hello @JimLynchCodes  A support ticket has been opened for you. Kindly Talk to Support on the Live support page so that your issue can be looked into. CLICK HERE

Hello @JimLynchCodes
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:
"Priority" labels will show how urgent this is for the team.
"Status" labels will show if this is ready to be worked on, blocked, or in progress.
"Need" labels will indicate if additional input or analysis is required.
Finally, remember to use the official Decentralized Dapps Protocol to initiate a chat with the support team to get immediate support via Solana Decentralized Portal.
Note: Use the chat 💬 icon at the bottom of the page to get started.


move skip_initial_election_timeout_ option to raft_params

Currently, skip_initial_election_timeout_ option is in init_options struct which can only configure through raft_server constructor.  It's not possible to configure it through raft_launcher.  Better move skip_initial_election_timeout_ option to raft_params.
Please review my PR #142 together with some other changes

Merged PR https://github.com/eBay/NuRaft/pull/147.


[Feature]: drop item (almost) anywhere on the window to move it there

Describe the feature
in AdiBags, when moving items between bag/bank or say, character sheet, you can drop the item anywhere on the window (not onto another item) to move it there.
in BetterBags, you have to drop it on the free space slot. i would love to see the same behavior as AdiBags as a toggleable option.
Describe the implementation
to avoid changing behavior unexpectedly, there should be an option in the settings that toggles this behavior, defaulting to the old behavior.

I agree with this and would love to see it extended to dropping on tabs directly as well


Created missing despawn buttons

Fixes #759

created missing sprites,
changed magic position numbers :)

New size:

Maybe shrink them down a bit? - they look a bit too heavy compared to other UI on those info panels.

After testing in-game, found a minor glitch when despawning cims - the info panel is not removed:

Same for both tourists and residents.

After testing in-game, found a minor glitch when despawning cims - the info panel is not removed:

Same for both tourists and residents.
Yeah, noticed that, but I don't know why it behaves like that :/

I think maybe we create issue for that minor glitch (info panel remains) so we can merge this PR and publish hotfix?

I think maybe we create issue for that minor glitch (info panel remains) so we can merge this PR and publish hotfix?

Testing fix :)

@aubergine10 auto-close didn't work on STABLE 11.1.0 also

Fixes minor issue with closing panel after releasing citizen

Panel still not closing, at leasts for tourists. Going to do a fresh build just and test again just in case.

Tested again, it's specifically tourists now that the info panel does not dissapear. It disappers for residents just fine.


customize information

hey, maybe we could customize information, like its location, transparency or something else, just makes it more useful :)

The location of the block/entity info can be adjusted, while the transparency can not, I'll have a try to implement your request to not only the block/entity info but also other features existing in the mod.


⚠ Bofrost.de has degraded performance

In 9dddf09, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1944 ms

Resolved: Bofrost.de performance has improved in 5a712b5.


typescript Type for 	Phaser.Types.Tilemaps.CreateFromObjectLayerConfig classType is incorrect

Version

Phaser Version: 3.55.2

Operating system: webpack running on Ubuntu 20.04, Webbrowser running on Windows 10

Browser: N/A

Description

The type definition for the classType property of CreateFromObjectLayerConfig is incorrect. Which in turn causes errors when trying to use createFromObjects with typescript.
It causes  the following error (where Player is a custom class that extends Phaser.GameObjects.Sprite):
TS2740: Type 'typeof Player' is missing the following properties from type 'GameObject': scene, displayList, type, state, and 42 more.

This can be ignored using  @ts-ignore and the code runs correctly.
[ The background of discovering this issue: https://phaser.discourse.group/t/createfromobjects-classtype-and-typescript-extends/10239/5 ]
Example Test Code
The error is generated by the following line:
 const players: Player[] = <Player[]>map.createFromObjects('players', {
      name: 'player1',
      classType: Player
  });

A complete example:
const map_data = { "backgroundcolor":"#000000",
 "compressionlevel":-1,
 "height":12,
 "infinite":false,
 "layers":[
        {
         "data":[
         ],
         "height":12,
         "id":1,
         "name":"main",
         "opacity":1,
         "type":"tilelayer",
         "visible":true,
         "width":12,
         "x":0,
         "y":0
        },
        {
         "draworder":"topdown",
         "id":2,
         "name":"players",
         "objects":[
                {
                 "gid":20,
                 "height":64,
                 "id":5,
                 "name":"player1",
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":64,
                 "x":320.666666666667,
                 "y":768
                }],
         "opacity":1,
         "type":"objectgroup",
         "visible":true,
         "x":0,
         "y":0
        }],
 "nextlayerid":3,
 "nextobjectid":6,
 "orientation":"orthogonal",
 "renderorder":"right-down",
 "tiledversion":"1.7.2",
 "tileheight":64,
 "tilewidth":64,
 "type":"map",
 "version":"1.6",
 "width":12
}

const sceneConfig: Phaser.Types.Scenes.SettingsConfig = {
    active: false,
    visible: false,
    key: 'Game',
};

export class GameScene extends Phaser.Scene {
    private player: Player;

    constructor() {
        super(sceneConfig);
    }

    public preload() {
        this.load.tilemapTiledJSON('map_test', map_data);
    }

    public create() {

        const map = this.make.tilemap({ key: 'map_test' });

        const players: Player[] = <Player[]>map.createFromObjects('players', {
            name: 'player1',
            classType: Player
        });
        this.player = players[0];
    }

}

export const gameConfig: Phaser.Types.Core.GameConfig = {
    title: 'Sample',

    type: Phaser.AUTO,

    scale: {
        width: window.innerWidth,
        height: window.innerHeight,
    },

    physics: {
        default: 'arcade',
        arcade: {
            debug: false,
        },
    },

    parent: 'game',
    backgroundColor: '#000000',
    scene: GameScene,
};

class Player extends Phaser.GameObjects.Sprite {
    body: Phaser.Physics.Arcade.Body;
    constructor(scene: Phaser.Scene) {
        super(scene, 0, 0, "player_blue");
    }

}

export const game = new Phaser.Game(gameConfig);

Additional Information
I'm new to typescript, so take this with a pinch of salt, but I believe the correct type definition is:
classType?: new (scene: Scene) => Phaser.GameObjects.GameObject;

If I manually modify types/phaser.d.ts, this appears to work.
I attempted to add this to src/tilemaps/tyepdefs/CreateFromObjectLayerConfig.js, but got the following error in tsgen
ERROR: Unable to parse a tag's type expression for source file /home/zem/git/phaser/src/tilemaps/typedefs/CreateFromObjectLayerConfig.js in line 1 with tag title "property" and text "{new (scene: Scene) => Phaser.GameObjects.GameObject} [classType=Phaser.GameObjects.Sprite] - A custom class type to convert the objects in to.": Invalid type expression "new (scene: Scene) => Phaser.GameObjects.GameObject": Expected "|" but "(" found.

At which point, I'm not sure what the correct syntax is, therefore opening an issue instead of a PR

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

It should actually be more like:
classType?: (new(scene: Scene, ...args?: any[]) => Phaser.GameObjects.GameObject) | (new(scene: Scene, ...args: any[]) => Phaser.GameObjects.GameObject) | (new(scene: Scene) => Phaser.GameObjects.GameObject);


Add for each support for tuples

Purpose
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/13165

Codecov Report

Merging #13543 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #13543      +/-   ##
============================================
- Coverage     64.28%   64.27%   -0.01%
  Complexity      661      661
============================================
  Files          2142     2142
  Lines         94294    94308      +14
  Branches      12450    12456       +6
============================================
  Hits          60613    60613
- Misses        28792    28799       +7
- Partials       4889     4896       +7

Impacted Files
Coverage Δ
Complexity Δ

...g/wso2/ballerinalang/compiler/desugar/Desugar.java
92.04% <ø> (ø)
0 <0> (ø)
:arrow_down:

...llerinalang/compiler/semantics/analyzer/Types.java
73.08% <100%> (+0.14%)
0 <0> (ø)
:arrow_down:

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
81.48% <0%> (-11.73%)
0% <0%> (ø)

...va/org/ballerinalang/channels/ChannelRegistry.java
94.59% <0%> (-2.71%)
0% <0%> (ø)

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
50% <0%> (-1.67%)
0% <0%> (ø)

...ain/java/org/ballerinalang/net/websub/hub/Hub.java
69.53% <0%> (-1.57%)
0% <0%> (ø)

...org/ballerinalang/bre/bvm/WaitCallbackHandler.java
84.68% <0%> (-0.91%)
0% <0%> (ø)

.../compiler/semantics/analyzer/SemanticAnalyzer.java
81.79% <0%> (+0.94%)
0% <0%> (ø)
:arrow_down:

...n/java/org/ballerinalang/bre/bvm/BVMScheduler.java
45% <0%> (+2%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d0d5c...9ba31f9. Read the comment docs.


Letsencrypt certicates doesn't work for public domain if using svclb or hostport mode

This issue is verified by https://github.com/rancher/rio/issues/481, closing.


Announce Caddy on HTTP/2 implementations

Caddy ought to announce itself on the HTTP/2 Implementations wiki page.

Thanks for the suggestion, but I didn't implement http/2 for Caddy, I just used bradfitz/http2 which is already on the list.


this one need a bn bump

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Suppress connection exception

Hi, can i catch connection error? I know about socket.on('error'), but i want to suppress the uncaught exception

@ImBrek did you find a way to suppress the message? I want to do it too but I haven't found a way yet.
To give more insight, this is the error message I'm seeing when verification of the JWT token fails:
1488275406345 - Origin: Worker (PID 22988)
   [Warning] Error
    at SCSocket._onSCClose (/Users/jansen/project/socketcluster/node_modules/socketcluster-server/scsocket.js:207:17)
    at SCSocket.disconnect (/Users/jansen/project/socketcluster/node_modules/socketcluster-server/scsocket.js:227:10)
    at disconnectInvalidSocket (/Users/jansen/project/socketcluster/build/utils/disconnect-invalid-socket.js:9:12)
    at SCServer.exports.default (/Users/jansen/project/socketcluster/build/middleware/on-connection.js:9:47)
    at emitOne (events.js:96:13)
    at SCServer.emit (events.js:189:7)
    at SCServer.EventEmitter.emit (/Users/jansen/project/socketcluster/node_modules/sc-domain/index.js:12:31)
    at /Users/jansen/project/socketcluster/node_modules/socketcluster-server/scserver.js:512:12
    at /Users/jansen/project/socketcluster/node_modules/socketcluster-server/scserver.js:368:7
    at /Users/jansen/project/socketcluster/node_modules/jsonwebtoken/verify.js:27:18

Nevermind, I found it. There's an option called logLevel. If you set it to 1 it will (from what I understand) only log exceptions that cause socketcluster to stop working.


[Analysis] How to add a Monad abstraction on top of existing monadic classes.

Here is a Scala example, taken from @travisbrown's abstracted. We need to check what is possible with Java in this direction.
Due to the lack of higher-kinded types, clearly Java's type system is not powerful enough to express this. The intention of this analysis story is, to investigate if we are able to create a Monad abstraction on top of existing classes without modifying them.
case class Box[A](val a: A) {
  def map[B](f: A => B): Box[B] = {
    println("Box's map")
    Box(f(a))
  }

  def flatMap[B](f: A => Box[B]): Box[B] = {
    println("Box's flatMap")
    f(a)
  }
}

And a monad instance for it:
import cats.Monad

implicit val boxMonad: Monad[Box] = new Monad[Box] {
  override def map[A, B](fa: Box[A])(f: A => B): Box[B] = {
    println("Box's functor's map")
    Box(f(fa.a))
  }

  def flatMap[A, B](fa: Box[A])(f: A => Box[B]): Box[B] = {
    println("Box's monad's flatMap")
    f(fa.a)
  }

  def pure[A](a: A): Box[A] = Box(a)
}

Hi Daniel,
There are a couple of things in Cyclops, a relatively new project from Aol, which has a primary focus on interoperability across the different functional style libraries that are emerging, which might be helpful here.
This is still an evolving work in progress - there are a few interfaces that might be helpful for your analysis (either for ideas, reuse or for defining an interoperability standard).
The Monad interface wraps any Java Monad implementation, and makes some attempt to retain type information about the monad's type and the type it targets (i.e. both Stream and String). This can be quite messy in practice.
Monad source code
The AnyM class simplifies things by dropping the type information for the Monad being managed (i.e. it doesn't store Stream just String).
AnyM source code
In both cases the underlying managed monad instance can be accessed again via unwrap(), and it is possible to flatMap to any monad type, so in the case of AnyM it is always possible to extract a monad of a given type, in a type safe way.
Monad operations are managed under the hood by 'Comprehenders' implementations of the [Comprehender interface] (https://github.com/aol/cyclops/blob/master/cyclops-base/src/main/java/com/aol/cyclops/lambda/api/Comprehender.java). These facilititate the existence of the Monad wrapping classes and for comprehensions.
The plan is to create modules in Cyclops for Javaslang that would define Comprehenders for any monads within Javaslang and offer conversion between Javaslang types (and functionaljava, jdk, Guava, TottallyLazy). There are prototypes for some of these conversions already - they could just as easily live  in Javaslang as Cyclops (perhaps it would be better?).
What do you think?

@johnmcclean-aol This sounds great. I also see the emerging 'diversification' of functional style libs in the Java eco-system. My intention creating Javaslang was (the same as for everyone else) to add missing functionality to Java, which in turn was designed with the focus to be backward compatible. I would love to see the new libs converging to a standard. Waiting for Java to include things does not help, it will take too long.
I'm currently busy with reviewing two new functional Java books. Soon I'm able to get back to this issue. I will take a look at your project and give you feedback.

@johnmcclean-aol @danieldietrich Hi John, I will take the time to look at this in the next week.  I haven't looked at the details of your library, how do you handle the type safety and the lack of kinds in your library?

@danieldietrich  @mperry  Thanks guys. When I started working on this the goal was to provide away to get your projects, and the JDK/ Guava /TotallyLazy etc, to work together seamlessly!
Mark, under the hood this was very heavily influenced by the fantastic work you did in FunctionalGroovy (e.g.  Groovy For Comprehensions). It started off totally dynamic and types have been added gradually. It's a process and it's definitely not complete (particularly for For Comprehensions).
I think AnyM is reasonably good (although I'm sure there are still bugs / holes to be found), at least if the Monad/ Monad-like class being wrapped takes a single generic parameter. You can create a factory method such as
 public static <T> AnyM<T> anyM(CompletableFuture<T> anyM){
	  return new MonadWrapper<>(anyM).anyM();
 }

and calling  it will preserve the type safety e.g.
CompletableFuture<Data> cf;
AnyM<Data> monadWithData = asAnyM(cf);

Types would then change as normal when map / flatMap etc are applied.
AnyM<String> monadWithString = monadWithData.map(data -> data.toString());

One concern would be, if you needed to get back to the wrapped CompletableFuture, AnyM could be anything. But something along these lines should work, and be guaranteed to always return a CompletableFuture (i.e. if monadWithString wraps an Optional, we will still get a CompletableFuture back).
CompletableFuture<String> cf2 = asAnyM(CompletableFuture.completedFuture(""))
                                                        .bind( str -> monadWithString.unwrap())
                                                        .unwrap();

It's a little long winded, if you wanted to live dangerously, the following would work in our case (but blow up if code elsewhere passing a Stream or a Try etc).
 CompletableFuture<String> cf2 = monadWithString.unwrap();

Internally when a method is called eventually the actual method to be invoked will be resolved by a Comprehender implementation (and if no specific Comprehender has been implemented for the Monad type being wrapped, an InvokeDynamicComprehender will pass on the method invocation).

@danieldietrich  Hi Daniel,  cyclops-javaslang integration is now available in Maven Central. There are converters to Javaslang types (Tuples, Functions, Streams etc) from Guava, JDK, FunctionalJava and simple-react. But also included are Comprehenders for Javaslang monads (as of Javaslang 1.2.2).
This means you can use Cyclops For Comprehensions (which are now strongly typed) with Javaslang, JDK and Cyclops Monads. E.g. Example below shows a mixed For Comprehension with a JDK CompletableFuture and a Javaslang List.
   CompletableFuture<String> future = CompletableFuture.supplyAsync(this::loadData);
   CompletableFuture<List<String>> results1 = Do.add(future)
													.add(Javaslang.anyM(List.of("first","second")))
													.yield( loadedData -> localData-> loadedData + ":" + localData )
													.unwrap();

Where this::loadData returns "loaded" the output is
  List(loaded:first, loaded:second)

You can also use the AnyM abstraction directly with Javaslang monads (AnyM is released as part of Cyclops 5.0.0). E.g. here is AnyM treating a Javaslang Try as Success biased (default behaviour)
  	assertThat(Javaslang.anyM(Try.of(this::success))
		.map(String::toUpperCase)
		.toSequence()
		.toList(),equalTo(Arrays.asList("HELLO WORLD")));

And a similar example, treating a Javaslang Try as Failure biased
   Exception e = new RuntimeException();
assertThat(Javaslang.anyMFailure(new Failure(e))
			.toSequence()
			.toList(),equalTo(Arrays.asList(e)));

I think we can regard this as something like a first draft, I think we can significantly improve this over time (for example by creating a Javaslang native for comprehension builder) - if there is interest to do so..
These links might be interesting
Cyclops for comprehensions
Cyclops for comprehensions Javadoc
Cyclops AnyM javadoc
@mperry  Hi Mark, I would hope to have a similar module available for FunctionalJava over the next couple of weeks.

@johnmcclean-aol Awesome, thanks for doing all the work. I will check it out.

This may go along with #288. I've a proposal in the pipeline. There will be an article/blog post soon...

This analysis is finished. We re-added the Monad-interface to Javaslang 2.0.0-RC*. We lift functions to monadic functions now.


feat: improve help message for new command

Description

Improved the help message of 'new' command with examples

Related issue(s)
Fixes #162

@LakshyaSatpal looking good man! Please just add a unit test that validates if list of examples is rendered? I'm just pretty sure that in few months someone will say "why do we use sync function here, lemme refactor" 😆
in the test, please do not "hardcode" list of examples as the tests will be affected by changes in examples list. So in test also read examples dynamically

Hi!
I was going through oclif documentation for testing for commands. I'm finding it challenging to write a test to check if a file is rendered.
I mean, I couldn't get what do I have to actually test, validate if the user entered the correct example name from available examples? or only check the working of loadExampleFile synchronous function that we wrote?
Btw, this is the first time I am writing unit tests. Please bear with me 😅

@LakshyaSatpal no worries. Happy to help you if you need.

you need to provide test for new functionality. New functionality is: much better help message with list of examples. We need to have a test, that will evaluate if the list of examples from /assets/examples is included in the help message that you just created.
have a look on existing tests https://github.com/asyncapi/cli/tree/master/test/commands for commands. See how we check if certain message appears in the console

I recommend, especially if it is your first time, first create a test, where you basically hardcode the expected message in the text, so you check if the message printed in terminal match the message that you hardcode in test (with list of examples).
Once ☝🏼 works, then work on making sure that the list of examples is not hardcoded, but you read in dynamically inside the test, from examples dir

@derberg I wrote this simple test

@derberg I wrote this simple test where I checked for help message to contain the first example which I hard coded.
test
		.stdout()
		.command(['new', '--help'])
		.it('help includes available examples', (ctx, done) => {
			expect(ctx.stdout).to.contain('- simple.yml');
			done();
		});

This shows me an error of AssertionError: expected '' to include '- simple.yml'. I believe, it is not getting that I'm checking for help flag command.

@LakshyaSatpal hey, you need a hand? I was out on holidays, but now back 💪🏼

@LakshyaSatpal hey, you need a hand? I was out on holidays, but now back 💪🏼

Hi @derberg, still stuck now the same problem - not able to write a test with help flag 😥, discussed it with @Souvikns as well

@LakshyaSatpal I hope you are still interested with this one. It helps with DX and as you see it is ok that we drop testing part

@derberg Okay, I removed the test and addressed other feedbacks. Please see if we can merge now

@Souvikns ping 😉

@LakshyaSatpal hay can you fix linter issues please

I have no idea why tests are failing 😭
it is not random, it is always [ERR_INVALID_ARG_TYPE]: The "warning" argument must be of type string or an instance of Error. Received an instance of TypeError but why.......#$%
@LakshyaSatpal maybe you could switch to readFile that is already used in the same file, instead of importing readFileSync? or was sync selected because description: await getExamplesFlagDescription() was not possible?

@LakshyaSatpal not sure why but you are having a lot of linter issues. Do you want to continue with this PR?

@LakshyaSatpal can you specify if you plan to continue with this one, or should that be released to other contributors?

no reaction so closing, hope someone will pick it up from https://github.com/asyncapi/cli/issues/162

done with https://github.com/asyncapi/cli/pull/758


Add change_orientation method

Implementation proposal for issue:
Lack of change_orientation functionality #19

Also update readme

merged.


Fixed typo in github pages index.html

Very awesome project BTW. It helps me and the folks @edX to RTL the biggest open courses platform https://edx.org (https://github.com/edx/edx-platform/pull/2682).
The typo here is very nasty, it puzzled me for a couple of moments.

Thanks, glad that it helped 👍

: party:


[ci] Upgrade to chart-testing v2.4.0

/retest

/retest

Initially the upgrade failed due to a missing API service.
See https://github.com/helm/helm/issues/6361.

/cc @helm/charts-maintainers

/hold

/hold cancel

/lgtm


Tts parler for tfs

Hey @Kiingsora, I'm not sure to understand what this issue is for, could you expand ?
Many thanks!


Methods Example

Hi Mohith,
This is not an issue but rather a suggestion to include example of the Meteor Methods example code as well..
I tried to do a pull request to include my suggestion but I don't know how =)
Ralph

@ralphievolt Thanks for your suggestion. The calling of Meteor methods will be different as per your architecture. So I just wrote a line that you can call methods here.
You can clone this repo, do make your suggestions and push it to your cloned repo. Then follow this https://help.github.com/articles/creating-a-pull-request/ to submit a pull-request


Create !crisis, !emergency and !mentalhealth

Both do the same thing - provide a list of crisis resources for quick reference.
Happy to add any other resources that may be of use :)

Good guy dal strikes again ❤

Implements #175

All caps is standard for constants
On Sat., 18 May 2019, 14:53 David Lord<EMAIL_ADDRESS>wrote:

@d-lord commented on this pull request.
In uqcsbot/scripts/crisis.py
https://github.com/UQComputingSociety/uqcsbot/pull/435#discussion_r285329261
:

@@ -0,0 +1,18 @@
+from uqcsbot import bot, Command

+@bot.on_command("crisis")
+@bot.on_command("mentalhealth")
+def handle_crisis(command: Command):

'''
!crisis or !mentalhealth - Get a list of mental health crisis resources.
'''
response = """Mental health/crisis resources

I like Tom's a bit more. response, RESPONSE or?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/UQComputingSociety/uqcsbot/pull/435?email_source=notifications&email_token=AATDF27WUJ5YPMD53GNL6P3PV6DVFA5CNFSM4HNTCX3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZA2XMI#discussion_r285329261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATDF22IQQSHE5LAKPZGS2DPV6DVFANCNFSM4HNTCX3A
.

I'm wondering if it should include !emergency too. Three aliases seems a bit excessive but I want it to be intuitive/accessible. Maybe change !mentalhealth to !emergency?

Hey fam, I've actioned the review and also added !emergency as an alias. Would appreciate a re-review so we can merge and forget about it until it's needed 😄

reopening


Updates for crontabs

Don't blow away existing crontabs during initCrontab() - allows for cron jobs to be created during BOOTSTRAP_HOOK
Added a simple script to restart the server

Hey @YodaDaCoda, thanks for the PR and sorry for the late response.
Can you explain me the use case for the restart script? Wouldn't the docker stop/start or docker compose down/up command be sufficient for this?

Can you explain me the use case for the restart script?

I'm running a Public Resource World server & want to be able to restart the server hourly to reset containers etc back to their initial state. Doing so outside the container isn't quite as simple as using the bootstrap hook to overwrite the save files and setup a cron job.
Understandable if you feel the restart script isn't necessarily something that fits with your vision of this project, but it'd be great to at least include the other change.

The initCrontab change, is no problem - I'll test it locally in the coming days.

Restarting the enshrouded process would be enough, but I didn't see a clear way of doing that cleanly (skill issue). I took inspiration from scripts/default/enshrouded-reset-roles

Hey @YodaDaCoda, I just thought about your use case. You want to restart the enshrouded server periodically with a cronjob script.
Would it not be enough to just call supervisorctl restart enshrouded-server? So no really need of a dedicated script for that, or am I missing something?
I just tested, the enshrouded user, can also call supervisorctl commands.

And the suggested change for the crontab is unfortunately not possible. If you keep the crontab between restarts you basically add duplicates of the same cron.
enshrouded  | 2024-09-19 20:04:38.168 supervisord: enshrouded-bootstrap DEBUG - [24] - */30 * * * * supervisorctl start enshrouded-updater >/dev/null 2>&1
enshrouded  | 2024-09-19 20:04:38.168 supervisord: enshrouded-bootstrap */10 * * * * supervisorctl start enshrouded-backup >/dev/null 2>&1
enshrouded  | 2024-09-19 20:04:38.168 supervisord: enshrouded-bootstrap */30 * * * * supervisorctl start enshrouded-updater >/dev/null 2>&1
enshrouded  | 2024-09-19 20:04:38.168 supervisord: enshrouded-bootstrap */10 * * * * supervisorctl start enshrouded-backup >/dev/null 2>&1

But I see your problem there and have a solution for that. I can move the BOOTSTRAP_HOOK to after the crontab is initialized. So you can add and or modify as you wish.
  info "Running enshrouded-bootstrap"
  prepareEnshroudedAppFolders
  updateOrCreateEnshroudedServerConfig
  prepareSteamA2sPythonLibrary
  # old bootstrapHook position <---

  # no proton bootstrap needed

  initCrontab
  bootstrapHook # <--- moved down
  supervisorctl start enshrouded-updater
  info "Bootstrap complete"

Will this be sufficient?

Would it not be enough to just call supervisorctl restart enshrouded-server? So no really need of a dedicated script for that, or am I missing something?

Yeah that's probably enough. It wasn't clear to me how to achieve it so I thought a script with a name that indicated what it did would be helpful but happy to remove.

If you keep the crontab between restarts you basically add duplicates of the same cron.

You can deconflict this (and I do in my bootstrap hook script), but it's probably more effort than it's worth, particularly if...

I can move the BOOTSTRAP_HOOK to after the crontab is initialized. So you can add and or modify as you wish.

Yes please, this would be fantastic!

@YodaDaCoda, the changes are on the current develop build (e.g. dev-proton). Could you test it and see if the changes work for you?


added one more rating widget

Cool, thank you! I'll move it up a bit so it's next to svelte-rate-it.


Not running in iis node

I am not able to make this running in iis node, where the same conversion runs in standalone node. I am running it from jsreport, but I guess that is not the issue. It doesn't work for dedicated-process strategy nor the electron-server.
It looks to me it is an issue of IPC communication between electron and the main process. The electron.exe is started but there appears to be no communication happening.
The log from electron server.
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:conversion generating new conversion task..
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:conversion conversion task id: 8d4e9cd8-4cad-4b30-9168-7c242bd12c03
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:conversion creating temporal html files in C:\jsreport\playground-test\temp..
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:conversion creating temporal html file [type: html] in C:\jsreport\playground-test\temp\8d4e9cd8-4cad-4b30-9168-7c242bd12c03html.html..
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:conversion starting conversion task [strategy:electron-server][task id:8d4e9cd8-4cad-4b30-9168-7c242bd12c03] with options: { browserWindow: { width: 10, height: 10, webPreferences: { javascript: true } },
  waitForJSVarName: 'JSREPORT_READY_TO_START',
  delay: undefined,
  waitForJS: false,
  converterPath: 'C:\\jsreport\\playground-test\\node_modules\\electron-html-to\\lib\\converters\\pdf.js',
  pdf:
   { marginsType: 0,
     pageSize: 'A4',
     printBackground: true,
     landscape: false },
  htmlFile: 'C:\\jsreport\\playground-test\\temp\\8d4e9cd8-4cad-4b30-9168-7c242bd12c03html.html',
  url: 'file:///electron-html-to/C%3A%5Cjsreport%5Cplayground-test%5Ctemp%5C8d4e9cd8-4cad-4b30-9168-7c242bd12c03html.html',
  chromeCommandLineSwitches: { 'ignore-certificate-errors': null },
  extraHeaders: {},
  output:
   { tmpDir: 'C:\\jsreport\\playground-test\\temp',
     id: '8d4e9cd8-4cad-4b30-9168-7c242bd12c03' } }
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:electron-server-strategy checking if electron workers have started..
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:electron-server-strategy starting electron workers..
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:manager starting 1 worker(s)..
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:manager creating worker 1 with options: { debug: undefined,
  debugBrk: undefined,
  env:
   { chromeCommandLineSwitches: '{"ignore-certificate-errors":null}',
     allowLocalFilesAccess: 'false' },
  stdio: [ null, null, null, 'ipc' ],
  killSignal: 'SIGKILL',
  electronArgs: [],
  pathToElectron: 'C:\\jsreport\\playground-test\\node_modules\\electron-prebuilt\\dist\\electron.exe',
  pathToScript: 'C:\\jsreport\\playground-test\\node_modules\\electron-html-to\\lib\\scripts\\serverScript.js',
  hostEnvVarName: 'ELECTRON_WORKER_HOST',
  portEnvVarName: 'ELECTRON_WORKER_PORT',
  host: '<IP_ADDRESS>',
  portLeftBoundary: undefined,
  portRightBoundary: undefined }
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:worker starting worker [eef3aa90-a19a-11e5-a58e-43f11f925516]..
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:worker trying to find free port..
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:worker spawning process for worker [eef3aa90-a19a-11e5-a58e-43f11f925516] with args: [ 'C:\\jsreport\\playground-test\\node_modules\\electron-html-to\\lib\\scripts\\serverScript.js' ] and options: { env:
   { chromeCommandLineSwitches: '{"ignore-certificate-errors":null}',
     allowLocalFilesAccess: 'false',
     ELECTRON_WORKER_HOST: '<IP_ADDRESS>',
     ELECTRON_WORKER_PORT: 51403,
     ELECTRON_WORKER_ID: 'eef3aa90-a19a-11e5-a58e-43f11f925516' },
  stdio: [ null, null, null, 'ipc' ] }
Sun, 13 Dec 2015 13:10:51 GMT electron-html-to:electron-server-strategy establishing listeners for electron logs in worker [eef3aa90-a19a-11e5-a58e-43f11f925516]..
Sun, 13 Dec 2015 13:10:51 GMT electron-workers:worker checking if worker [eef3aa90-a19a-11e5-a58e-43f11f925516] is alive..
Sun, 13 Dec 2015 13:10:59 GMT electron-workers:worker worker [eef3aa90-a19a-11e5-a58e-43f11f925516] is not alive..
Sun, 13 Dec 2015 13:10:59 GMT electron-workers:manager electron manager could not start all workers..
Sun, 13 Dec 2015 13:10:59 GMT electron-html-to:electron-server-strategy electron workers could not start..
Sun, 13 Dec 2015 13:10:59 GMT electron-html-to:electron-server-strategy conversion ended with error..
2015-12-13T13:10:59.742Z - error: Error when processing render request Error during rendering report: electron manager could not start all workers.. Error: electron manager could not start all workers..
    at startHandler (C:\jsreport\playground-test\node_modules\electron-workers\lib\ElectronManager.js:128:37)
    at C:\jsreport\playground-test\node_modules\electron-workers\lib\ElectronWorker.js:191:18
    at C:\jsreport\playground-test\node_modules\electron-workers\lib\ElectronWorker.js:215:16
    at Socket.<anonymous> (C:\jsreport\playground-test\node_modules\electron-workers\lib\checkPortStatus.js:49:5)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at TCP._onclose (net.js:469:12)
From previous event:
    at Object.electron-pdf (C:\jsreport\playground-test\node_modules\jsreport-core\lib\reporter.js:147:40)
    at C:\jsreport\playground-test\node_modules\toner\lib\toner.js:124:47
    at C:\jsreport\playground-test\node_modules\toner\lib\toner.js:82:17
    at C:\jsreport\playground-test\node_modules\toner\lib\listeners.js:38:17
    at C:\jsreport\playground-test\node_modules\jsreport-core\lib\reporter.js:121:7

For dedicated-process strategy it also spawns electron.exe and then get stucks
Sun, 13 Dec 2015 13:20:27 GMT electron-html-to:dedicated-process-strategy electron executable path returned from electron-prebuilt module: C:\jsreport\playground-test\node_modules\electron-prebuilt\dist\electron.exe
Sun, 13 Dec 2015 13:20:27 GMT electron-html-to:dedicated-process-strategy spawing new electron process..
Sun, 13 Dec 2015 13:20:27 GMT electron-html-to:dedicated-process-strategy processing conversion..

node 4.2.3
electron-prebuilt 0.35.4

seems like iisnode don't handle IPC connections nicely.. let me check on a windows machine with iisnode installed

i found another bug in my windows machine.. at least in windows 7 the electron process hangs for not getting the focus in the current window.
testing with the flag ELECTRON_HTML_TO_DEBUGGING=true enables show the electron window..

are you using azure with iisnode?

ELECTRON_HTML_TO_DEBUGGING=true works nicely on my local windows 10 as well on azure (without iisnode) windows server 2012. The electron window seems to pop up after the rendering. With iisnode it doesn't get opened.
I have the iisnode on custom Azure VM with windows server.

I can mail you the login if you want...

sure, i know how to fix that problem. let me test in my local iisnode, if it works then i will test on your azure account

but lets wait.. maybe with my patch there is no need to test on your account

quick question: how are you setting env vars in iisnode? just wanna mention that issnode has a special way to propagate env vars

Through web.config appSettings
<configuration>
  <appSettings>
    <add key="DEBUG" value="*" />
    <add key="ELECTRON_HTML_TO_DEBUGGING=true" value="true" />
  </appSettings>

after debugging multiple times and in different ways i have discovered that electron hangs (only in iisnode) in this part.. don't know why but i will dive into it

in other words the readFile operation never ends

using fs.readFileSync works! (don't know why.. maybe iisnode patch the fs module?).
one more problem to solve on iisnode.. since electron doesn't give me the number of pages of the PDF, i was forced to use a pdf parser from mozila's pdf.js, the parser is great but is based completly in the web.. i have noticed before that some parts of the parser hangs when running on node.js, i was able to fix that with a hack but now i have discovered that it hangs on iisnode

You made it, cool! I will try it myself.
I use the number of pages information only to charge credits in jsreportonline. But it is not something we need to have I guess.

i will try to make it work.. I do not like to refuse a challenge :smiley:
however i have already asked support in electron for that feature (including header and footer generation in the PDF)
debugging this problem let me discovered some minor bugs.. i will push a fix later so we can try again with a new version

@pofider can you try on latest version?

Unfortunately I observe the same problem - electron executable hangs.

it doesn't work in local o azure? or both?

Azure VM - I will mail you credentials

closing until plain iisnode + electron works -> https://github.com/bjrmatos/iisnode-electron-spawn-bug


Public key for tesseract-4.00~git2686-1.1.x86_64.rpm is not installed

I install tesseract on centos 7 by the following commands:
yum-config-manager --add-repo https://download.opensuse.org/repositories/home:/Alexander_Pozdnyakov/ScientificLinux_7/
yum update
yum install tesseract
yum install tesseract-langpack-deu
the command"yum install tesseract "" show the error informatio:
Downloading packages:
warning: /var/cache/yum/x86_64/7/download.opensuse.org_repositories_home_Alexander_Pozdnyakov_CentOS_7_/packages/tesseract-4.00~git2686-1.1.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID ad8883f8: NOKEY
Public key for tesseract-4.00~git2686-1.1.x86_64.rpm is not installed
Help please!

We do not provide binary packages. Please report issue to packager

You can skip the key check using the --nogpgcheck flag ;)

--nogpgcheck

Ohh that helped a lot for my current build script. Thank you!

nogpgcheck

I use the following:
sudo yum-config-manager --add-repo http://download.opensuse.org/repositories/home:/Alexander_Pozdnyakov/RHEL_7/
sudo yum update -y
sudo yum install tesseract -y --nogpgcheck


Question about targets names and DUD-E dataset

Dear authors, thank you for your work.
I looked into the various targets you shared and compared them with the DUD-E dataset. There are a couple of targets that I can't seem to find in the DUD dataset.
I found the DUD-E dataset here: https://dude.docking.org/targets
Dockstring targets that don't match names from DUD-E:
{'ache',
 'adam17',
 'adora2a',
 'ar',
 'ca2',
 'cyp2c9',
 'cyp3a4',
 'dhfr',
 'drd2',
 'f10',
 'f2',
 'gba',
 'hmgcr',
 'hsd11b1',
 'hsp90aa1',
 'kdr',
 'maob',
 'map2k1',
 'mapk1',
 'mapk14',
 'mapkapk2',
 'nr3c1',
 'pgr',
 'ptgs2',
 'ptk2',
 'ptpn1',
 'ren'}

Do you mind sharing more info about this? From the paper all the targets came from DUD-E so I am wondering if it's just another appellation for the same target?

I did a little bit more research especially by using the 3d position to see if some file in the dude target at the same position.
So I get the following naming for dockstring and DUD-E.
Dockstring -> DUD-E
ache -> aces
adam17 -> ada17
adora2a -> aa2ar
ar ->  andr
ca2 -> cah2
cyp2c9 -> cp2c9
cyp3a4 -> cp3a4
dhfr -> dyr
drd2 (added in dockstring)
f10 -> fa10
f2 -> thrb
gba -> glcm
hmgcr -> hmdh
hsd11b1 -> dhi1
hsp90aa1 -> hs90a
kdr -> vgfr2
maob -> aofb
map2k1 -> mp2k1
mapk1 -> mk01
mapk14 -> mk4
mapkapk2 -> mapk2
nr3c1 -> gcr
pgr -> prgr
ptgs2 -> pgh2
ptk2 -> fak1
ptpn1 -> ptn1
ren -> reni
I am not an expert on protein, but is there any reason for having a different naming convention ?

Hi @vincrichard . You are right: the naming convention in DOCKSTRING is different from that of DUD-E. The reason is that we follow the names in the ExCAPE database, which in turn follows the names from HUGO nomenclature.
We took the protein structures from DUD-E and the ligands from ExCAPE, and we made sure to include active ligands for each target (i.e. active ligands according to the experimental activities recorded in ExCAPE, not to the docking scores produced by Vina; the two should be correlated for a certain protein target if Vina is doing a good job for that target, but this may not be the case in every target). We needed to translate the names in DUD-E (which were not following a single convention as far as I know) to ExCAPE (which was following a well-recognized convention, the HUGO nomenclature) in order to make sense of the two datasets together.
Hope that makes it clear!
By the way I have checked the conversions you've done and I they are correct.

Thank you for the detailed explanation, appreciate it.


:build: improved version strings

Fork of Jim's branch: improved-version-strings
Code review to verify:
https://github.com/google/earthenterprise/pull/597
Comments edited to address previous reviews. To test, per Jim:
Implementation details have been updated.
Without git, a src/version.txt file is referenced to git the latest known build number.
With git, src/version.txt is updated so that the value can be stored in the repository.
If you are on a version-style tag commit, that tag will be returned.
If you have a dirty repository, the datestamp is appended to the latest tag.
Otherwise, the datestamp and current commit (short) hash are appended.
Revision and build numbers and alpha -> beta -> release cycles are updated as appropriate.
Recommended testing:
Tag your local repo with a version-like string such as "5.2.1-1.beta".
Build and check output in src/NA*/gee*txt and src/version.txt
Make a file change to make the repo dirty.
Build and check output files.
Commit that change (git status should be clean, except maybe for src/version.txt)
Build and check output files.
Then:
Tag your repo with a release style tag, such as "5.2.1-2.release".
Repeat the above remaining steps.

Some general comments:

We should know what release we're working on (e.g., alpha, hot fix, next minor release, next major release) before starting to make commits for it.  We should tag the first commit towards the new release, or use a branch for it (which would allow, e.g., working on hot fixes and a next major or minor version simultaneously).

We should avoid using hyphens in version strings.  They'll have to be converted to something else in order to be used in package versions, and there aren't many options for other characters to use.

We should consider having a version component for hot fixes that are released between scheduled releases, e.g. when a vulnerability is found and needs to be fixed quickly.  We may be using the 'revision' component of the version number for scheduled releases, rather than the 'minor' number, and not have a version number for quick fixes, or, perhaps, we don't have any scheduled releases and we're considering everything we're adding a quick fix.

We should consider not putting a commit ID in a version string, but recording it as part of the build context.  They don't allow you tell which version is higher than another, and are probably not anything that someone except a developer debugging a problem would want to know.  They seem to be just packing extra information in a version string, because we didn't find a better place for it.

Timestamps help in determining what version is newer, but it's still possible to build an older commit at a later time.  We can consider using a number connected to the latest commit in the repository before the timestamp.  (E.g., number of commits since release tag.).

@tst-basilhuffman Can you create an issue that summarizes the changes that have been made to link with this PR?

fixes #632


"KeyError: location" when invoking a build job

I am running Jenkins version 1.596.1. When I try and start a build job, I get the following traceback:
Traceback (most recent call last):
File "test.py", line 12, in
ahn.invoke(build_params=bp)
File "/Users/crosebraugh-macbook-pro/jenkins/lib/python2.7/site-packages/jenkinsapi/job.py", line 210, in invoke
redirect_url = response.headers['location']
File "/Users/crosebraugh-macbook-pro/jenkins/lib/python2.7/site-packages/requests/structures.py", line 54, in getitem
return self._store[key.lower()][1]
KeyError: 'location'
I inspected the response object and, sure enough, there is no location header.

This feature have been added in more recent Jenkins versions. @salimfadhley shall we mention this in the README.rst?


cmdb_syncer_api container crashes on startup

Newest Update causes the API container to crash on startup.
* Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: on
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_attribute_outcomes
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_attribute_rewrite
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_checkmk_outcome
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_netbox_outcome
  warnings.warn(text)
Traceback (most recent call last):
  File "/usr/local/bin/flask", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 988, in main
    cli.main()
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 579, in main
    return super().main(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/decorators.py", line 84, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 850, in run_command
    app = DispatchingApp(info.load_app, use_eager_loading=eager_loading)
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 299, in __init__
    self._load_unlocked()
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 333, in _load_unlocked
    self._app = rv = self.loader()
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 393, in load_app
    app = locate_app(import_name, None, raise_if_not_found=False)
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 234, in locate_app
    __import__(module_name)
  File "/srv/app.py", line 5, in <module>
    from application import app
  File "/srv/application/__init__.py", line 196, in <module>
    admin.add_view(FileAdmin(app.config['FILEADMIN_PATH'], name="Files", category="Config"))
  File "/usr/local/lib/python3.10/site-packages/flask_admin/contrib/fileadmin/__init__.py", line 1239, in __init__
    storage = LocalFileStorage(base_path)
  File "/usr/local/lib/python3.10/site-packages/flask_admin/contrib/fileadmin/__init__.py", line 34, in __init__
    raise IOError('FileAdmin path "%s" does not exist or is not accessible' % self.base_path)
OSError: FileAdmin path "/srv/cmdbsyncer_imports" does not exist or is not accessible
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: on
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_attribute_outcomes
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_attribute_rewrite
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_checkmk_outcome
  warnings.warn(text)
/usr/local/lib/python3.10/site-packages/flask_admin/model/base.py:1415: UserWarning: Fields missing from ruleset: render_full_conditions,render_netbox_outcome
  warnings.warn(text)
Traceback (most recent call last):
  File "/usr/local/bin/flask", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 988, in main
    cli.main()
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 579, in main
    return super().m *  Terminal will be reused by tasks, press any key to close it

That's the new Fileadmin, was not aware that there is an effect on docker. Does creating a folder cmdbsyncer_imports fix it? Then I have to create it automatically.

I disabled it. Will change it a way that the existing of the folder is checked, but currently on holidays

I wish a restfull vacation!


Make \yii\db\QueryTrait::limit and \yii\db\QueryTrait::offset methods works with \yii\db\Expression

Make \yii\db\QueryTrait::limit and \yii\db\QueryTrait::offset methods works with \yii\db\Expression
I'd test it only with PostgreSQL, must be checked with other

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
#13221

Tests seems to fail.

Thank you, @Ni-san!


Investigate WebStreams API (Node.js 20.x)

See https://nodejs.org/api/webstreams.html
Motivation: compatibility with all major browser platforms and Node.js 20+ environment.

Additional motivation: compatibility with edge providers like cloudflare.

Additional motivation: compatibility with edge providers like cloudflare.

@clickhouse/client-web should be compatible.


dbdiff seems to hang

I extracted an existing postgresql database into a dbsteward xml file. I then ran dbdiff against that same database.
$ php DBSteward/bin/dbsteward --dbdiff=schema.xml --dbname=tanga_dev --dbhost=localhost --dbuser=monkey

Notice: Undefined index: newxml in /Users/joevandyk/dbsteward/DBSteward/lib/DBSteward/dbsteward.php on line 391
[DBSteward-1] Connecting to localhost:tanga_dev as monkey
[DBSteward-1] Loading XML /Users/joevandyk/dbsteward/schema.xml..
[DBSteward-1] Validating XML (size = 87645) against /Users/joevandyk/dbsteward/DBSteward/lib/DBSteward/dbsteward.dtd
[DBSteward-1] Compositing XML File schema.xml
[DBSteward-1] Validating XML (size = 87645) against /Users/joevandyk/dbsteward/DBSteward/lib/DBSteward/dbsteward.dtd
[DBSteward-1] XML files schema.xml  composited
[DBSteward-1] Saving as ./schema_composite.xml
[DBSteward-1] Building complete file ./schema_build.sql
[DBSteward-3] [File Segment] Fixed output file: ./schema_build.sql

Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'America/Los_Angeles' for 'PDT/-7.0/DST' instead in /Users/joevandyk/dbsteward/DBSteward/lib/DBSteward/sql_format/pgsql8/pgsql8.php on line 276
[DBSteward-1] Calculating table foreign key dependency order..

And it sits there forever.  PHP is using 100% of the CPU.

Much has been improved with regards to database extraction since version 1.2.3. Primarily with the infinite circular foreign key dependency ordering algorithm.
Please reference https://github.com/nkiraly/DBSteward/wiki/Extracting-Existing-Database-Structure and  open a new issue if you find this behavior on your database in DBSteward 1.3.11 or newer.


Multiple cursors appear in nested snippets after code completion is used several times

VSCode Version: 1.41.0
OS Version: Windows 10, MacOS

Multiple cursors appear in nested snippets after code completion is used several times at tab stop position. This may be caused by miscalculation of tab stop indexes. When each new snippet is added inside the existing one, tab stop indexes of the outer snippet are recalculated so that all tab stops inside the outer snippet and after it are numbered sequentially.
At some point, the index numbers are miscalculated so that multiple tab stops with the same index number appear. When the cursor reaches these tab stops, several cursors appear, as several tab stops have the same index.
Steps to Reproduce

Using VSCode's  'Configure user snippets' command (more info here https://code.visualstudio.com/docs/editor/userdefinedsnippets), create simple snippet definition:

"snippet": {
        "scope": "typescript",
        "prefix": "@2",
        "body": [
            "function($1) {$2}"
        ]
}

Create New Typescript file using New File menu option
Start typing @2... Code completion options should appear in a drop down menu. Select @2 option. This will insert function snippet and replace @2 symbols with snippet's text. You should get the following text fragment ( vertical bars | here indicate tab stop positions in the inserted snippet):

function( | ) { | } |

Using Tab button go to the second tab position (which is between curly brackets {} ).
Press Enter and then type @2.

function () {
  @2|
}

Again code completion drop down menu should appear. Selecting option @2 insert second nested snippet. You should get following text:
function() {
    function() {}
}

Repeat actions from step 5 one more time. Result should be following:

function() {
    function() {
        function() { }
   }
}

Using Tab go to position between curly brackets and ask for code completion there, using arrows select some option, for example undefined, and press Enter.

function() {
    function() {
        function() {undefined}
   }
}

Press Tab. Cursor should jump to next tab stop( vertical bar | indicates this position )

function() {
    function() {
        function() {undefined} |
   }
}

Press Enter to insert new line. Type @2, insert snippet as described above, press Tab, Ctrl+space, select 'undefined', press Enter, press Tab. Result should be following:

function() {
    function() {
        function() {undefined}
        function() {undefined} |
    }
}

Using Tab for navigation between tab stop positions and repeating steps described above create structure like this. Do NOT use arrows for navigation, only Tab or Shift+Tab!

function() {
    function() {
        function() { undefined }
        function() { undefined }
    }
    function() {
        function() { undefined }
        function() { undefined }
        function() { undefined }
        function() { undefined }
        function() { undefined }
        function() {}
    }
}

After 6-8 code completions next function snippet appears with multiple cursors.

Expected results
Multiple cursors should not appear.
Actual results
Multiple cursors appear in the newly inserted snippet.

This issue occurs even when all extensions are disabled, (Launch with code --disable-extensions to check.)

I wasn't able to to reproduce. For me snippet mode stays active and completion works as expected also after repeating this many time. Tho, your steps are very complex, please try to make them more minimal. If you are up for it, write a test that exercises what you are describing, find samples here

@jrieken
Have you created 3-level nested snippet structure?
Code completion in tab stops should be done at least 7-times.
Please try to repeat steps captured on video. For me and my colleagues the issue stable reproducible in different file formats (XML, TypeScript), using different snippets (having 2-3 tabstops) and on different platforms (Windows, Mac).
So, crucial requirements to reproduce - code completion many times, at least 6-7 and deeply nested snippet structure ( try to make 3 levels and then return  to 2-nd level and continue. When navigate please use only Tab-button to keep snippet mode active. If still can't reproduce, let me know, I'll try to create test. Thanks!

Hi, @jrieken !
I would like to know, if you tried to reproduce the issue once again following my recommendations?
As for me, the issue is stable reproducible.  But yes, the scenario is not that straight forward. It couldn't be somehow simplified. Please repeat steps how they demonstrated on the attached video. If you do it precisely as described, after code completion of 'undefined' value has done 7 times, the next snippet should appear with two cursors. Please try to reproduce it again.

Hello, @jrieken !
I have not received a response from you. I would like to know what status this problem has. Are you expecting any action from me?

Honestly I have not. It seems like it requires such a long sequence of commands that close to no user will hit this in real life. Since you seem to have strong emotions, how about doing PR that first adds a test reproducing this failure (add it here src/vs/editor/contrib/snippet/test/snippetController2.test.ts) and then try to fix it


Initial oclif command

Created bcoc login, which just checks if a user is logged in to openshift.  Also a test.

Resolved by https://github.com/DerekRoberts/bcoc/pull/1


support node.js v4.2.1

to support node.js v4.2.1, if not using the new version of karma, there will be compiler error for it's module socket.io

@metasong there's no changes in your commits.

@metasong, @ludohenin can you close this?


Change default proportions and allow half-decimal editing

Better initial and default body proportions for people that don't want to calibrate
Now changes bone length to half decimal (0.5). Rounds up to the nearest 0.5.

It could be useful for head offset and neck length, considering those are small values that affect the whole skeleton’s sliding.
I could make a button to toggle 0.5 adjustments. A “Precision adjust” toggle…


string is casted to union of literal strings without any check

Flow version: 0.98.0 (latest)
Expected behavior
i expect this code to error because currentPage and currentPage2 are undefined and not 'PersonalInfo' | 'ContactInfo' | 'ChangePassword'
Actual behavior
string is casted to union of literal strings without any check
Try it for yourself
code
const possiblePages = {
	'personal-info': 'PersonalInfo',
	'contact-info': 'ContactInfo',
 	'change-password': 'ChangePassword'
}
const somePage: string = 'cotne'

const currentPage: $Values<typeof possiblePages> = somePage
	? possiblePages[somePage]
	: 'PersonalInfo'

const currentPage2: ('PersonalInfo' | 'ContactInfo' | 'ChangePassword') = somePage
	? possiblePages[somePage]
	: 'PersonalInfo'

Smaller example:
declare var x: string;
declare var foo: {|foo:'foo'|};
const wat = foo[x]; // wat is now implicitly `any`

// no errors
(wat: boolean);
(wat: string);
(wat: number);
(wat: null);
(wat: void);
(wat: typeof foo);

turns out this is kind of documented and same is true for arrays
https://flow.org/en/docs/types/objects/#toc-objects-as-maps

property accesses are assumed to have the annotated type, even if the object does not have a value in that slot at runtime. It is the programmer’s responsibility to ensure the access is safe, as with arrays.

var obj: { [number]: string } = {};
obj[42].length; // No type error, but will throw at runtime

https://flow.org/en/docs/types/arrays/#toc-array-access-is-unsafe

When you retrieve an element from an array there is always a possibility that it is undefined. You could have either accessed an index which is out of the bounds of the array, or the element could not exist because it is a “sparse array”.

For example, you could be accessing an element that is out of the bounds of the array.

// @flow
let array: Array<number> = [0, 1, 2];
let value: number = array[3]; // Works.
                       // ^ undefined

now i wonder if there is any strict rule i can turn on so that array/object item/property access returns T | void when there is no guarantee that object/array has value for key/property

Those docs are talking specifically about object types with indexers. My example is both missing an indexer in its type and is exact.

@jcready now i see you are right this is much worse then i thought
and i have found that this is already reported https://github.com/facebook/flow/issues/7392
closing this one


Error creating VM

When creating the VM I get
~ ❯❯❯ dinghy create --provider vmware
The VM 'default' already exists in docker-machine.
Run `dinghy up` to bring up the VM, or `dinghy destroy` to delete it.
~ ❯❯❯ dinghy destroy                                                                                ⏎
Stopping the FsEvents daemon
Stopping the default VM...
Stopping "default"...
Machine "default" was stopped.
Stopping NFS daemon, this will require sudo
Password:
About to remove default
Are you sure? (y/n): y
Successfully removed default
~ ❯❯❯ dinghy create --provider vmware
Creating the default VM...
Error creating machine: Error in driver during machine creation: Machine didn't return an IP after 120 seconds, aborting
/usr/local/Cellar/dinghy/4.4.1/cli/dinghy/machine.rb:22:in `create': There was an error creating the VM. (RuntimeError)
	from /usr/local/Cellar/dinghy/4.4.1/cli/cli.rb:59:in `create'
	from /usr/local/Cellar/dinghy/4.4.1/cli/thor/lib/thor/command.rb:27:in `run'
	from /usr/local/Cellar/dinghy/4.4.1/cli/thor/lib/thor/invocation.rb:126:in `invoke_command'
	from /usr/local/Cellar/dinghy/4.4.1/cli/thor/lib/thor.rb:359:in `dispatch'
	from /usr/local/Cellar/dinghy/4.4.1/cli/thor/lib/thor/base.rb:440:in `start'
	from /usr/local/bin/_dinghy_command:12:in `<main>'

~ ❯❯❯ docker --version                                                                                ⏎
Docker version 1.11.2, build b9f10c9
~ ❯❯❯ dinghy version
Dinghy 4.4.1

Any idea what i'm doing wrong ?

I've seen one report of this previous, and the person ended up determining it was an issue with the vmware docker-machine plugin. There's not anything dinghy can do to work around that, unfortunately. I don't know if there's already an open issue against that plugin.


Frameless TAURI available

Frameless Tauri is available since the beta

Hello, could you give me a link to the documentation ? I seeked for it during the example update, but I didn't found information about a frameless mode.
I'll then update examples.
Thanks :)

https://tauri.studio/en/docs/api/config/#tauri.windows

https://tauri.studio/en/docs/usage/guides/visual/window-customization

Oh thanks, I read this page but didn't see the config I was looking for 😄 I will update that !

Frameless example was added, thanks !


leftOffset in px and disable shadow ?

Hello, it's possible to configure "leftOffset" in px but not in percent ?
And if it's possible to disable shadow ?
😇

@NicolasCELLA

No
2.set boxshadow:[],

@NicolasCELLA solved?

Yes thank 👌
In feature I think it would be nice to be able to swipe on the "leftOffset" directly to leave it
(like instagram or twitter)
After that, a think your drawer can be perfect 😎

@NicolasCELLA what is the offset parameter?

The possibility to leave the offsetLeft in sliding in left ! Presently we need to tap the scaffold to come back !
I think that can be nice 😇