Scroll is not working

Hi there, Thank you so much for doing this!
I downloaded and ran the app, it works well but I've found a small problem. The scroll is not working. Once within a chat, when the content is too large, you can not scroll up to read the previous messages.

Hi there, Thank you so much for doing this!
I downloaded and ran the app, it works well but I've found a small problem. The scroll is not working. Once within a chat, when the content is too large, you can not scroll up to read the previous messages.

Thanks for reporting this issue. What browser are you using? I don't see this issue in Chrome.


appBar iconStyleRight bug

I have
render() {
	return <AppBar style={{ position: "fixed" }} title={my Title}

		iconElementLeft={<IconButton><NavigationMenu /></IconButton>}
		iconStyleRight={{color:"red"}}
		iconElementRight={<IconButton>account_circle</IconButton>}
		/>
}

but iconStyleRight is giving me the error
Type '{ [x: number]: undefined; color: any; }' is not assignable to type 'string'

No idea why. I've tried many combinations, including adding a style to the  element, which is ignored.
Is this a bug, or am I doing something wrong?

@HenrikBechmann, it's not a bug and you're not doing anything wrong, it's just very confusing! :smile:
Try this:
<AppBar style={{ position: "fixed" }} title={my Title}

        iconElementLeft={<IconButton><NavigationMenu /></IconButton>}
        iconStyleRight={{color:"red"}}
        iconElementRight={<IconButton>account_circle</IconButton>}
        /><AppBar style={{ position: "fixed" }} title={my Title}

        iconElementLeft={<IconButton iconStyle={{color: 'red'}}><NavigationMenu /></IconButton>}
        iconStyleRight={{color:"red"}}
        iconElementRight={<IconButton>account_circle</IconButton>}
        />

Let me know if it works...

@newoga yeah that worked. Thanks!
As it happens the typedef for iconStyleRight was wrong as well (in material-ui.d.ts, set to string, should have been object -- I'm using typescript), so that compounded the problem with noise. Ugh.
So what's the point of iconStyleRight then?

@HenrikBechmann Honestly, not completely sure. I had to read the source code to even answer your before. Though I think that prop is only used when you're not manually providing an IconButton, IconMenu, or FlatButton to the iconElementRight prop. Not that its clear and documented.
Like I said, it's very confusing. I'm actually in the middle of rewriting the AppBar, and hopefully ToolBar , components to make it simpler and more flexible. I'll keep this design problem in mind!

fyi when I use FontIcon component for the right element:
			iconElementRight={

				<IconButton
					onTouchTap={
						() => { alert('account options go here') }
					}
				>

					<FontIcon
						className = "material-icons"
						style={
							{ marginTop: "-6px", fontSize: "36px" }
						}
					>
						account_circle
					</FontIcon>

				</IconButton>
			}

... then the FontIcon style attribute is also ignored, which is definitely counter-intuitive.
So for the moment the IconStyle attribute on the parent IconButton component is the one that works.
Feels like there might be a bit of a design trap going on...

@newoga Something else you might want to consider: when including a compound component for right element (I wanted to add user name in small print under the user icon) then there were unwanted side effects in icon styling. (I've deferred followup on this until later). So something to consider might be to relegate styling of the icon to the FontIcon component (or svg component as used), and let the rest happen locally/naturally.
all fwiw...


Wizard compatibility

I don't understand how this would work. The cached_result value is set on an instance of ReCaptchaField but field instances are not persistent across requests. As you navigate from one page to another in a wizard that field is recreated. For it to work you need to store the cached_result somewhere else. You can't use the caching backend because (1) some systems round robin requests and if they don't have a shared cache backend it will get lost and (2) caches are inherently volatile.
I suggest storing the cache result on the user's session. You already use thread locals (if 'request' in f.f_locals:) to retrieve the request and can access the session from that.
You will need to find a way that the cached result is valid only for this wizard. That will prove tricky because the recaptchafield has no idea of the flow happening in the wizard it lives inside. Easiest is probably to use request.path_info as part of the key you store in the session, eg. rcf-/some/path/cached-result and bake an expiry time into the value.

Superseded by https://github.com/praekelt/django-recaptcha/pull/196


Bug: deactivating products on RC results in a 500 error

Steps to Reproduce
See Sentry issue: https://sentry.io/organizations/mit-office-of-digital-learning/issues/3609909359/?alert_rule_id=8724694&alert_timestamp=1663787179172&alert_type=email&environment=rc&project=5864687&referrer=alert_email

On RC, use the admin to set the Is Active flag to false for a given product.
Navigate to the course details page for the product's course.

Expected Behavior
The course details page should render, minus the now-disabled upsell messaging.
Actual Behavior
You get a 500 error.
Stacktrace
https://sentry.io/organizations/mit-office-of-digital-learning/issues/3609909359/?alert_rule_id=8724694&alert_timestamp=1663787179172&alert_type=email&environment=rc&project=5864687&referrer=alert_email
Related Issues
Noticed this during a sanity check for https://github.com/mitodl/hq/discussions/227#discussioncomment-3702377 .

Closed via #1026


Check the return value of lockFile.delete().

This statement returns a value that is not checked.
The return value should be checked since it can indicate an unusual or unexpected function execution.
The statement returns false if the destination file could not be successfully deleted (rather than throwing an Exception).
If you don't check the result, you won't notice if the statement signals an unexpected behavior by returning an atypical return value.
http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

Coverage decreased (-0.1%) to 89.925% when pulling 83c39ae5001e579af89d34dc8dc9d72b302f453d on BruceKuiLiu:master2 into fa24ac8a655c30c4b88bd51ce690d0184c342d47 on apache:master.

How about printing out a warning or error message, not throwing an IOException, if lockFile.delete() fails?

Commons IO does not log ATM, to the console or anywhere. I do not think it
should for this case...
Gary
On Oct 14, 2017 04:17, "BruceKuiLiu"<EMAIL_ADDRESS>wrote:

How about printing out a warning or error message, not throwing an
IOException, if lockFile.delete() fails?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-io/pull/47#issuecomment-336625481, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIfN2g9O2ojjKJaXTKF_D2DJivwcMmMks5ssIorgaJpZM4P5Jky
.

Note that this PR would contradict the class' Javadoc:
/**
 * FileWriter that will create and honor lock files to allow simple
 * cross thread file lock handling.
 *

 * This class provides a simple alternative to FileWriter
 * that will use a lock file to prevent duplicate writes.
 *

 * N.B. the lock file is deleted when {@link #close()} is called
 * - or if the main file cannot be opened initially.
 * In the (unlikely) event that the lockfile cannot be deleted,
 * this is not reported, and subsequent requests using
 * the same lockfile will fail.
 *

 * By default, the file will be overwritten, but this may be changed to append.
 * The lock directory may be specified, but defaults to the system property
 * java.io.tmpdir.
 * The encoding may also be specified, and defaults to the platform default.
 *
 */

Note that this PR would contradict the class' Javadoc:
/**
 * FileWriter that will create and honor lock files to allow simple
 * cross thread file lock handling.
 *

 * This class provides a simple alternative to FileWriter
 * that will use a lock file to prevent duplicate writes.
 *

 * N.B. the lock file is deleted when {@link #close()} is called
 * - or if the main file cannot be opened initially.
 * In the (unlikely) event that the lockfile cannot be deleted,
 * this is not reported, and subsequent requests using
 * the same lockfile will fail.
 *

 * By default, the file will be overwritten, but this may be changed to append.
 * The lock directory may be specified, but defaults to the system property
 * java.io.tmpdir.
 * The encoding may also be specified, and defaults to the platform default.
 *
 */

Closing as this was implemented, but differently.

Closing as this was implemented, but differently.


Short term fix for Recall

Is your feature request related to a problem? Please describe
OSB has a bug where recall decreases as soon as users use more clients than the number of CPU cores on the load generation host. This seems to be related to inherited implementations of OSB, its actor system, and Async IO. For more information and worklog reproductions, see https://github.com/opensearch-project/opensearch-benchmark-workloads/issues/347.
Describe the solution you'd like
We should implement a short term fix that prevents users from getting misleading recall results if they are using more search clients than the number of CPU cores on the load generation host.
We can find a long term fix afterwards.
Describe alternatives you've considered
No response
Additional context
No response

Closing this because short term fix was merged in with #626


Coin drop animation + Support for different board sizes

Coin drop animation has been added
Different board sizes are supported
Board pattern can be changed by changing the board1_100px.png image inside the images folder
Some minor bug fixes (like coin drawing while undoing)

Great Work @amanpalariya , currently reviewing your PR.

hey please squash all of these changes into one!

also I have so many concerns right now.. I will address them once you squash all your commits in one.

I'm using git for the first time and don't know what I did just now 🙄.
If there was a contiguous sequence of my commits, I squashed them into one. I hope that is what I was supposed to do.

I'm using git for the first time and don't know what I did just now roll_eyes.
If there was a contiguous sequence of my commits, I squashed them into one. I hope that is what I was supposed to do.

yes, you are supposed to do that only, in your fork I see that you made 13 commits, all I am asking is bring all those commits into 1 single commit and then raise a pull request, this PR is quite messy right now.. do one thing close this PR and raise a new one.. following everything I said in this comment.


[QUERY] Status 404 with AppConfiguration ConfigurationClient in Azure Functions

Query/Question
I'm using the App Configuration SDK (Azure.Data.AppConfiguration 1.0.2) in an Azure Function.
The Azure Function is a timer triggered functions that implement the syncronization between two different App Configuration instances.
I use Event Grid to dispatch events generated by my primary App Configuration to a queue. Every time the function runs, it retrieves the messages in the queue and, using two ConfigurationClient (one for the primary and one for the secondary App Configuration) update the settings.
The code is the following
string queueConnectionString = Environment.GetEnvironmentVariable("SyncQueueConnectionString");
var queueClient = new QueueClient(queueConnectionString, "syncqueue");
if (queueClient.Exists())
{
     string appConfigPrimaryConnectionString = Environment.GetEnvironmentVariable("AppConfigPrimaryConnectionString");
     string appConfigSecondaryConnectionString = Environment.GetEnvironmentVariable("AppConfigSecondaryConnectionString");

     var appConfigPrimaryClient = new ConfigurationClient(appConfigPrimaryConnectionString);
     var appConfigSecondaryClient = new ConfigurationClient(appConfigSecondaryConnectionString);

     var response = await queueClient.ReceiveMessagesAsync(10);
     foreach (var message in response.Value)
     {
           var base64EncodedBytes = Convert.FromBase64String(message.MessageText);
           var @event = JsonConvert.DeserializeObject<Event>(Encoding.UTF8.GetString(base64EncodedBytes));

          if (@event.IsKeyValueModified())
          {
               var primarySetting =  await<EMAIL_ADDRESS>@event.Data.label);
               await appConfigSecondaryClient.SetConfigurationSettingAsync(primarySetting);
          }
          else if (@event.IsKeyValueDeleted())
          {
              await<EMAIL_ADDRESS>@event.Data.label);
          }

         await queueClient.DeleteMessageAsync(message.MessageId, message.PopReceipt);
    }
}

I receive the following error when I call the method GetConfigurationSettingAsync :
Service request failed.
Status: 404 (Not Found)

Headers:
Server: openresty/<IP_ADDRESS>
Date: Tue, 10 Nov 2020 18:17:56 GMT
Connection: keep-alive
x-ms-request-id: REDACTED
x-ms-client-request-id: a1d08379-b9e6-4657-b044-d635a542dce1
x-ms-correlation-request-id: a1a2c2ed-ed9e-4409-b506-4af816e15509
x-ms-tenant-name: REDACTED
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: REDACTED
Strict-Transport-Security: max-age=15724800; includeSubDomains
Content-Length: 0

If I try the same code in a console project, the code works fine.
The connections strings are right.
Thanks
Environment:

Name and version of the Library package used: [e.g. Azure.Data.AppConfiguration 1.02, Azure.StorageQueues 12.4.2]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. .NET Core 3.1 on Azure Function Runtime 3.0.14916.0]
IDE and version : [e.g. Visual Studio 2019]

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@massimobonanni Thanks for all the information.

I'm also looking at the service documentation, and if you are getting 404 from GetConfigurationSettingAsync it means that the key and label combination was not found.
Are you testing your code with a static queue? I wonder if every time you are testing, values are different and there could be a key-label that doesn't exist in appConfigPrimaryClient

Hi, I receive the 404 locally. I don't remember if I received the same when I publish the function. I will check asap. I use a static queue in the storage (it is always the same). The same code, outside the function (in a console project), works perfectly.

Hi, maririos.
I tried again both locally than in Azure and now the function works fine (in both environments). I don't receive the previous error. I don't know what is changed until the day I published the post but now it works. Just to be sure I checked in the App Insight for the error and I find the exceptions I mentioned in the post last time I make the test.
I'm sorry for the post and to use your time. We can consider the issue as a solved issue.
Max

I am glad it is working. Closing issue then


Add pseudo LimitModes ASTRAL, BIRD, MOLE, ROACH

Using an Astral Mushroom gives you five turns of Half-Astral.
The first adventure you take after that sends you to a choice where you choose Bad Trip, Mediocre Trip, or Great Trip.
That did not cost a turn, but the next 5 turns must be spent at a particular location.

There is no "exit" adventure.
Using a llama lama gong sends you right into a choice adventure where you can choose among

3 turns of Form of...Cockroach
12 turns of Shape of...Mole!
15 turns of Form of...Bird!

The Cockroach sends you straight into an uninterruptible chain of three choices.

The Mole opens up Mt. Molehill where you must adventure 12 times.
When the effect wears off, your next adventure lets you talk to your Llama.
The Bird opens up no new area, but all your Combat skills are replaced with bird skills, you may not use items, and you can Pickpocket. Consuming special "bug" drops open up more combat skills.

If you are under the effect of either an astral mushroom (Half-Astral is in effect) or a llama lama gong (one of the effects is active or it has worn off but you have not gotten the Welcome Back NC), you may not use another astral mushroom or llama lava gong.
I can model all of the above as a pseudo LimitMode.
KoL returns limitmode in api.php as 0 for all of them.

When setLimitMode(LimitMode.NONE), if you are Half-Astral, set it to LimitMode.ASTRAL
When you you take the choice to choose a trip, set "currentAstralTrip" to Bad Trip, Mediocre Trip, Good Trip
When Half-Astral wears off, set LimitMode.NONE, which will also clear currentAstralTrip
While you are in LimitMode.ASTRAL, you can adventure only in your chosen trip.
If you have not chosen it, prepareForAdventure will select it, based on which location you selected.
astral mushroom and llama lama gong are limited as described above.
If you try to adventure in an Astral zone, canAdventure will allow it if you are already in LimitMode.ASTRAL - and have either selected that zone or have not yet selected it - and prepareForAdventure will use an astral mushroom and select the trip, if needed.
When you use a gong and select a form, set currentLlamaForm to Mole, Roach, or Bird
setLimitMode(LimitMode.NONE) will look at that setting and give you LimitMode.MOLE, LimitMode.ROACH, or LimitMode.BIRD.
When you are in LimitMode.MOLE, you can adventure only in Mt. Molehill
astral mushrooms and llama lama gongs are limited as above.
When you try to adventure again, Welcome Back will clear currentLlamaForm.
If you try to adventure in Mt. Molehill, canAdventure will allow it if you are not in a LimitMode and have a gong. prepareForAdventure will use a gong and select mole form, if necessary.
When you are in LimitMode.BIRD,
astral mushrooms and llama lama gongs are limited as above.
When the effect wears off, Welcome Back will clear currentLlamaForm.
When you are in LimitMode.ROACH,
astral mushrooms and llama lama gongs are limited as above. Not that you can use them in a choice chain, anyway.
When the effect wears off, Welcome Back is part of the chain and clears your currentLlamaForm

I have LimitMode tests for entering and leaving LimitMode.ASTRAL, LimitMode.MOLE, LimitMode.BIRD, and LimitMode.ROACH

Future considerations (perhaps not in the PR, which was to enable canAdventure/prepareForAdventure fixes):
We have hardcoded "is BIRDFORM active?" checks in various places.
More efficient to just check if currentLimitMode is LimitMode.BIRD, rather than searching the activeEffectsList.
And maybe we could use it to check combat items and combat skills? Perhaps not.

I added tests for entering and leaving LimitMode.BIRD and LimitMode.ROACH.
I look forward to seeing what the final coverage numbers are.
Assuming all goes well, I will merge without awaiting further review, since all that is new is tests.


Remove Chapter 0

I'm the author of Punk Records, the project this one is forked from. 👋🏾
This PR removes Chapter 0: About This Repository from cubari.json and modifies tengen.utils.base_metadata() and tengen.utils.load_cubari() so that Tengen will no longer generate that chapter when run. If you take a look at Chapter 0, I think the reason for this PR is self-evident. 🙃

My bad, I didn't notice that you had deliberately left Chapter 0 in as a way of crediting me. I appreciate it, though it really isn't necessary — I opened this PR because I thought you wouldn't have wanted your project attributed to my name, haha. I'll close this.


Article about vikiival/magick on dev.to

Had idea to write article about Subquery and what we are doing with it for RMRK and beyond
Would be good to migrate indexer under kodadot organization afterwards #1394
Extend with article about rubick
It would help our new developers to onboard how we use indexers from SubSquid and Subquery
#2013

Let's write ✍ on 🚂🚃🚃🚃

We discussed that would be nice to write another article about Rubick (SubSquid in KodaDot) as implementation differs.
https://github.com/kodadot/rubick/

Meanwhile we've dropped SubQuery due poor support not in our timezone


[roles-0.1.0] Update UI for Tabs for Desktop Drawer and Forms

Currently Tabs design in the app are styled to the Mobile Specs even on desktop. but For Desktop and The Vesting Form We will need a new variant/component to match designs
https://www.figma.com/design/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?node-id=3898-7379&t=PvJ1W5ty2r4Gdc3t-4

@Da-Colon this was in the work you did last night, right?

No sir.


ModuleNotFoundError: No module named 'rasa_addons'

Describe the bug
I am trying to build rasa-for-botfront from source code using docker/Dockerfile_botfront, it builds successfully.
when running it raises the below exception
Traceback (most recent call last):
  File "/opt/venv/bin/rasa", line 5, in <module>
    from rasa.__main__ import main
  File "/opt/venv/lib/python3.7/site-packages/rasa/__init__.py", line 9, in <module>
    from rasa.run import run
  File "/opt/venv/lib/python3.7/site-packages/rasa/run.py", line 8, in <module>
    from rasa.core.lock_store import LockStore
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/__init__.py", line 5, in <module>
    from rasa.core.train import train
  File "/opt/venv/lib/python3.7/site-packages/rasa/core/train.py", line 12, in <module>
    from rasa.shared.core.domain import Domain
  File "/opt/venv/lib/python3.7/site-packages/rasa/shared/core/domain.py", line 23, in <module>
    import rasa.shared.core.constants
  File "/opt/venv/lib/python3.7/site-packages/rasa/shared/core/constants.py", line 83, in <module>
    from rasa_addons.core.action_list import action_list # bf
ModuleNotFoundError: No module named 'rasa_addons

To Reproduce
Steps to reproduce the behavior:
run the below command :

docker build -f docker/Dockerfile_botfront -t rasa-local:latest .
docker run -p 5005:5005 rasa-local:latest

Thanks in advance

Hello @pheel , Any thoughts might help here please

Hello @pheel , Any thoughts might help here please

@engahmed1190 Thanks for the report. Addons installation was moved to poetry recently... Dockerfile was not tested, will fix. In the meanwhile you can try building from https://github.com/botfront/rasa-for-botfront/commit/f99cc03adf7867f289c7aa4f2e92759eb99d29f9

@engahmed1190 Thanks for the report. Addons installation was moved to poetry recently... Dockerfile was not tested, will fix. In the meanwhile you can try building from https://github.com/botfront/rasa-for-botfront/commit/f99cc03adf7867f289c7aa4f2e92759eb99d29f9

Fixed by #889


sched/signal: Implement SA_NODEFER

Summary
See the info here:
https://pubs.opengroup.org/onlinepubs/007904875/functions/sigaction.html
Impact
New funcitonality
Testing
Pass CI and ostest

LGTM, but please capitalize the documentation to be consistent.

Fix, thanks for reviewing.


Vessel at production

I'm new to docker and I assume that the docs are written for local development only. It will be nice if the docs tells us the easy way to use it at production since vessel is so easy to set-up.
Thank you

Hi!
Unfortunately if it was suitable for production, it wouldn't be easy anymore! This is mostly said with some sarcasm but is.....not too far from the truth. Docker in production tends to be pretty complicated.
I have a course Shipping Docker that gets into it (starts basic and builds up).  You can also check out some videos here (free) to get a feel for Docker some more: https://serversforhackers.com/t/containers


Firmware Image Uploaded not Resolving String Information in Error Messages

Using the minimal_diagnostics example, I've successfully set up a connection to ESP_Insights. However, when I upload the matching firmware package (I've double checked it's correct according to the ReadMe instructions) it doesn't resolve the string information. I always get the error "We could not find the firmware image to cross-reference this log entry. Please upload a firmware image to get cross-referenced information for this log entry."
For the sake of thoroughness, I've tried this on 2 different esp32s3 modules and one regular esp32 module. Hopefully I'm just an unlucky one as this seems like a fairly big issue.
IDF Version: 5.2
Full Version: v5.2-dev-1890-g28167ea5a3

Hello @connormartin12 the hash of the firmware package has to match to the one which is sending insights from the device.
Could it be that the package you uploaded was built after some changes?
Can you check by flashing the firmware on device and uploading it to the insights dashboard from the same build? The older logs still won't be resolved, as they correspond to some other hash. However, newer logs should get resolved.

Hey @vikramdattu, thanks for the prompt reply.
I noticed this was a requirement while reading through the ReadMe file for the example when setting up Insights. However, as a sanity check, I just now ran a fullclean and erase-flash before building and flashing. I uploaded this matching firmware hash to Insights with no change in outcome.
I'll be happy to provide anything else you might need.

@connormartin12 can you please share firmware sha and the node ID for the device?

@vikramdattu Here's the info you requested. I also enabled debug prints in the menuconfig just incase that shows anything insightful. These packages are currently active for this node, however the debug prints enabled sha is the image currently installed on the node.
Node ID:<PHONE_NUMBER>4C
SHA: Attached
Insights_Example-v1.zip
Insights_Example-v1-debug-prints.zip
debug_prints.txt

Hey @vikramdattu any update on the status of this issue?

Hi @connormartin12 we have found the issue with the messages that are sent from your device.
From debug_prints.txt you attached, your device is sending "sha256" : "4f93c257" as sha sum of the firmware, which is just the first half. Insights backend however expects full sha256 of the firmware, which is 4f93c257cb31a4a4 in your case.
My question is, did you make any changes in the firmware which would lead to this? Please check for changes in esp_insights_cbor_encoder.c.
Also, I can see that you are using master branch of the IDF, can you please switch to release/v5.1 and check if the issue persists for the logs with this new firmware?

@vikramdattu I have confirmed switching to release/v5.1 fixes the issue. Thank you for looking in to this for me!

Hi, I'm using V.5.2.1 and I have the same problem. Shall I switch to release 5.1? Which one do you recommend? Thanks in advance.

Hi @pablojgauto I'm unsure if they've fixed this since I experienced this error. I would recommend switching to the latest stable version of 5.1 and seeing if that solves the issue like it did for me.

I'm having a similar issue, using ESP-IDF release v5.3 on an esp32s3.
My device is connected to insights, and metrics etc. is all working OK but for every log message I get the error: "We could not find the firmware image to cross-reference this log entry. Please upload a firmware image to get cross-referenced information for this log entry."
In my log output I see on boot that I have ELF file SHA256:  8a776829b..., and in the insights dashboard the uploaded firmware is reporting as 8a776829bfc0f0a1 so I think that's OK. The only error message I get in my logs related to insights is esp_insights: Failed to enable insights_cmd_resp, not sure if that's relevant?

@gadget-man command response should not cause the issue you see. Did you try this suggestion: https://github.com/espressif/esp-insights/issues/33#issuecomment-1744314277 ?

Yes I checked that. See my post #45  I've included several screenshots showing exactly the debug log and status in the Insights Dashboard.

I see, can you change the IDF version to release/5.2 or release/5.1 and check if the issue gets resolved. I notice, the issue mentions the IDF version used is 5.3.
If changing IDF version is not an option, setting the config CONFIG_APP_RETRIEVE_LEN_ELF_SHA to 16 (from 9) should fix it.

Thanks, I can confirm that adding CONFIG_APP_RETRIEVE_LEN_ELF_SHA=16 in 5.3 has resolved the issue.


floating step

Is there a way to have a step that floats in the middle of the page, not attached any specific element? I want to have a step at the beginning that just floats in the center of the page, with the backdrop before the steps that go through all the elements on the page. Is this already possible, or would a change be needed?

You can use a zero width and height centered div to achieve this:

.centered-tour-element {
    position: fixed;
    left: 50%;
    top: 50%;
    /* TODO: following should be half of your step component's width and height */
    transform: translate(-140px, -78px);
}

Thanks! That worked perfectly. It would be nice if there was a way to do this built in though, without any extra classes. Like if you didn't pass an anchorId, it should treat it as a centered step. I have seen that kind of thing in other tour packages.


buildSrc setup instructions

Describe your use-case which is not covered by existing documentation.
Hey! I'd like to try this out, but on a smaller scale, just in a single project's convention plugins.
It'd be handy to have instructions for setting up gratatouille in buildSrc, since that's a very lightweight way of configuring plugins.
Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

By using two different modules, Gratatouille ensures that Gradle classes do not leak in your plugin implementation and vice-versa.

It's a bit heavy to create two subprojects if I just want to use Grata for a single task. Could creating separate feature variants help instead? Then a single subproject could have independent source sets. https://docs.gradle.org/current/userguide/feature_variants.html
Are you interested in contributing to the documentation?
Yes. How about we set up a full site? I really like using Docusaurus!

Hey thanks for opening this!
That's definitely something that has been at the back of my mind for a while (see also https://github.com/GradleUp/gratatouille/issues/4). Thanks for the nudge, I'll look into what can be done here.
Re: documentation, I've been toying with Writerside lately. Never used Docusaurus but definitely in to try it out!


Links not rendering

Hello,
I wanted to try adding a Graph to my app.
Sadly I am not getting the links between notes to render.
I am running in .net 8.
The Links seems to be present but it does not render.

i have the same problem, hope to get some help for this

i have the same problem, hope to get some help for this.
A sample of a SSR Blazor application using the new "Blazor Web App" template would be appreciated. It uses app.razor for including css and scripts.
Maybe then i can see why it is not working for me
I really find this package/library very cool and interesting

I needed to add this to my Blazor page 👍
@page "/DiagramOverview"
@rendermode InteractiveServer
then i can see links and also move around


Add Support for Config Encryption

If --password=SOMETHING_SECURE is pass the config should be encrypted if it is not already.
If it is done on the first command an unencrypted config should never hit the drive.
An additional command change_password should be added so the user can change it.
It may be worth have encryption required and printing the generated password to be used (would also ensure secure passwords).
The main code needed is already implemented in dataserv_client/encryptedio

Moved to https://github.com/Storj/storjnode/issues/39 as the config and encryption code now lives there.


Filter data based on extended user profile

I was able to extend the use profile to hold a country relation done with a new UserCountry Table
so user can belong to multiple countries  as below

in another form called PE a record can also belong to multiple countries  as below with a table called PEcountries as below

all working fine data is updated inserted deleted perfectly thanks to Serenity and @volkanceylan
my next objective is to view data in PE Row based on logged in user tried to follow Multi Tenancy tutorial but this is not the behavior I  want as all users login to the same application
any directions is appreciated form any one have implemented successfully filter data by user ,
Again thanks to @volkanceylan for the effort and time spent on the template as its highly sophisticated and professional peace of art

You should do such filtering in repository with exists or IN filters

that's what I have done in the list handler


GraphQL codegen

Resolves https://sovryn.monday.com/boards/2218344956/pulses/2337782951
Added some additional information about scalar types, time travel queries and schema fetching in the monday spec.

Don't merge yet, the graph just got setup on sovryn.app, so I will add the new url and add the fetching mechanism

I've implemented the schema fetching mechanism. I opted to pull in the schema document into the repo and not just fetch it every time from the graph it self, so that you can still update the generated hooks when the graph is down for some reason.


Settings screen-possible enter characters other than numbers after the colon in the port number.

Description:
It is forbidden to enter characters other than numbers after the colon in the port number.

Allow input from 1 to 65535 .0 and everything greater than 65535 to make invalid.

checked


Remove existing SSL management.

Fixes #471
Fixes #662
This still needs client support (emp certs-attach) and associated API endpoint, but this would change how certs are managed via Empire, in that you don't use Empire to manage certs, just attach existing certs to apps.
Note that https://github.com/remind101/empire/pull/700 will still be required to fix the fact that ELB's can't be updated to use new certs.
The basic flow for attaching a cert to an Empire application will be:
$ aws iam upload-server-certificate --server-certificate-name ProdCert
$ emp certs-attach ProdCert -a <app>

I think this will also ultimately work better when we add more backends, since we won't have to try to support varying CertManager implementations.
Also note that this will be backwards compatible with existing certificates inside Empire (see migration).

This looks good so far - are you planning to put the new SSL attachment stuff in this same PR before merging?

Yep, I'll be adding the new endpoint shortly with support in emp.


Enable Refresh() to be called more than once

Describe the bug
Currently a Refresh() can be done only once during the lifetime of an Updater.
This is not optimal for long-living processes so it would be better if we enable calling Refresh() more than once.
References:

https://github.com/rdimitrov/go-tuf-metadata/blob/4e20edf17ab0b724127ca3d2374e5a9580f3b519/metadata/updater/updater.go#L98C1-L98C72

Reproduction steps

...
Expected behavior
Upon calling Refresh() make sure everything is up-to-date and if that's true:

return nil, instead of an error (better imho)
or
return a custom error type so the user can check it via errors.Is (less favourite)

If something else occurred which failed us to refresh the metadata, still return the appropriate error value.
Additional context
No response

cc: @kommendorkapten

FWIW in python-tuf there was an explicit decision to only allow one refresh() call during an Updater's lifetime: https://github.com/theupdateframework/python-tuf/blob/f711997a08cbb558fc8ab91406a846bbe4883d1a/tuf/ngclient/updater.py#L115
Mostly sharing this so that you can dig into the rationale for the choice on the Python side and make an explicit choice to diverge from their implementation approach. I know this codebase started out implementing the same architecture.

👋 @joshuagl I'm working now on integrating this into the Sigstore TUF client, and if you remember, there are some requirements on caching, and especially to allow a client to use the locally cached metadata without performing a TUF update. We know this is a deviation from the TUF spec, but it was still a desired feature to have.
As part of adding that functionality, it would be required to first load the metadata on disk, then if expired, perform an update. This currently fails due to this.
Another example is long-lived processes, such as services that may have a lifetime far beyond the timestamp's expiration time. Such components could of course periodically recycle the client used, but that feels a bit unnecessary. Would be interesting to hear your thoughts here.

Actually I think I can solve most of this in the sigstore tuf client, let me think of that for a while.
But I would still need the deviation from the tuf spec (load metadata on disk only), I'll prepare a PR and we can discuss it more.

See https://github.com/theupdateframework/python-tuf/pull/2472 for some exploration of offline mode for python-tuf

See theupdateframework/python-tuf#2472 for some exploration of offline mode for python-tuf

Yes the last comment hopefully explains why we finally decided not to merge anything yet in python-tuf: At the moment sigstore-python can achieve the same security benefits (roughly none) by just using cached artifacts without verifying them.
If we had https://github.com/theupdateframework/python-tuf/issues/1168 then offline verification would be a little more useful.

Ah, the bootstrapped root functionality is expected to be part of python-tuf itself? My thinking is a bit different, go-tuf requires a root.json (LocalTrustedRoot) and so it would be the the actual program's responsibility to make sure that it can be trusted (and the technique used to protect it can differ between programs).

Closing in favour of https://github.com/theupdateframework/go-tuf/issues/593


Conflict with DF Template Enhancements: MeasuredTemplate no longer references TemplateLayer.gridPrecision

The entity movement controls are not being wrapped by libWrapper and are also not referencing the TemplateLayer.gridPrecision property. This causes a conflict with DF Template Enhancements which adjusts the grid precision for grid intersection snapping.
https://github.com/manuelVo/foundryvtt-drag-ruler/blob/44efabc65675763bdfee25f26741b9f25653897e/js/util.js#L93-L114
Also, I'm not sure if performing your own grid snapping logic is necessary as FoundryVTT provides the following function for exactly this:
// HexagonalGrid and SquareGrid both extend this class
class BaseGrid {
...
/**
	 * Given a pair of coordinates (x1,y1), return the grid coordinates (x2,y2) which represent the snapped position
	 * Under a "gridless" system, every pixel position is a valid snapping position
	 *
	 * @param {number} x          The exact target location x
	 * @param {number} y          The exact target location y
	 * @param {number|null} [interval]  An interval of grid spaces at which to snap.
	 *                                  At interval=1, snapping occurs at pixel intervals defined by the grid size
	 *                                  At interval=2, snapping would occur at the center-points of each grid size
	 *                                  At interval=null, no snapping occurs
	 *
	 * @return {{x, y}}           An object containing the coordinates of the snapped location
	 */
	getSnappedPosition(x, y, interval=null);
...
}

const destination = canvas.grid.grid.getSnappedPosition(x, y, gridPrecision);

I'm able to verify the conflict between the modules. However, I'm unsure to what you're referring about when you're saying

The entity movement controls are not being wrapped by libWrapper

Can you point out the code locations where this is the case?

My apologies, when I was searching where you implemented the template feature I think I was on an old commit before you converted to libWrapper. I initially searched for the commit whose message said it implemented to template feature (Implement measurement template support) which I realise now was actually a very old commit.
I've redacted that part of the original ticket.

Hey, I just checked your commit, I believe you might get NaN on gridless scenes when you call getSnappedPosition()

Thanks. getSnappedPosition is indeed behaving differently on gridless than I expected

Yeah I saw that when I was trying the above solution I proposed. Internally it's doing a Divide-by-Zero when on a Gridless scene which causes the X,Y to be NaN.


Move play / pause buttons to the side of animated time-series

re: https://github.com/CartoDB/cartodb/issues/12387

Cartodb PR: https://github.com/CartoDB/cartodb/pull/12482
Deep-insights.js PR: https://github.com/CartoDB/deep-insights.js/pull/561
Cartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1701

tests pending!

Why didn't we add the tests?

Tests added @matallo, what's your opinion?

🚀


Add Gallary of Past Creations

Hey as discussed yesterday, I have been browsing this https://github.com/browniebroke/gatsby-image-gallery, and https://www.gatsbyjs.org/packages/gatsby-theme-gallery/, and this is what I have so far:

Default images are supposed to be stored in content/gallery but i am not sure if im specifying the config correctly.
PS: When using gatsby theme gallery:  run npm i @emotion/styled and npm install --save gatsby-theme-gallery.
Fixes #26

@faithghlee : As per discussion we will try https://github.com/browniebroke/gatsby-image-gallery

Also follow the example at, https://github.com/browniebroke/gatsby-image-gallery/blob/master/example/src/pages/index.js in that repo to see how the custom gallary image folder is set. :smile:

Closing this on as it's no longer related. :smile:


feat(subscriptions): implement generic subscription for create mutations

Basic subscriptions
This pull request implements a basic and generic subscription model for node creations in the ce-api.
The following subscription query can be used to listen for DigitalDocuments and MusicComposition creations:
subscription {
  ThingCreateMutation(onTypes: [DigitalDocument, MusicComposition]) {
    identifier
    type
  }
}

When for example a DigitalDocument gets created (currently only by using the CreateDigitalDocument mutation and not the MergeDigitalDocument mutation) the following response can be expected:
{
  "data": {
    "ThingCreateMutation": {
      "identifier": "0ae38e36-be80-492f-af92-d3212429325c",
      "type": "MusicComposition"
    }
  }
}

MediaObjects
@musicog
For the following types, I've added specific subscription queries:

MediaObject
AudioObject
VideoObject

All of the above have the option to filter nodes created with a specific encodingFormat:
subscription {
  MediaObjectCreateMutation(encodingFormat:"video/mp4") {
    identifier
    type
  }
}

Currently, if you want to listen for audio and video objects, you'll need two separate subscriptions.
Fixes #35
Future
While researching this subject, I've found the following plugins which would solve multiple issues:
https://neo4j.com/labs/kafka/
https://github.com/ancashoria/graphql-kafka-subscriptions
With the two plugins from above, subscriptions will be triggered based on changes in the Neo4j database. This can possibly solve that Merge mutations aren't triggering events and advanced filtering can be applied for subscriptions.

@alastair after re-reading your comment, I'm using the GraphiQL interface to test the subscriptions. In other client projects, we are using the default Apollo subscriptions.
There is also the NodeJS algorithm POC which uses the subscriptions-transport-ws library: https://github.com/trompamusic/ce-poc-algorithm/blob/master/algorithm/src/index.js#L23

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/commands/QueryAndPublishResolver.js  4

Clones added
============
- src/resolvers/subscription.js  5

See the complete overview on Codacy

ah, that's perfect. Thanks.
I've added to my to-do list to test this functionality before your sprint starts.

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/resolvers/subscription.js  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/resolvers/subscription.js  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5

Clones added
============
- src/resolvers/subscription.js  5
- src/transformers/authenticationFieldTransformer.js  1
- src/transformers/subscriptionFieldTransformer.js  1

See the complete overview on Codacy


Exports

@josef-janousek Wow! Thanks, I will look into it as the first thing tomorrow.

Connects to #121 .

Seems to work just fine.


Healthcheck Webapp for containers

We did notice that every 5 minutes, a prob crawl the following URL /robots933456.txt. I've spent my whole day to figure out how and why...
Is it possible explain that on the documentation? To avoid any surprise for people making some monitoring on app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f970943e-c7b4-919c-65ea-6ba20831e74d
Version Independent ID: 90c5dd06-ea6d-7af8-f88c-9d189e9ceef2
Content: Use a custom Docker image for Web App for Containers - Azure
Content Source: articles/app-service/containers/tutorial-custom-docker-image.md
Service: app-service
GitHub Login: @SyntaxC4
Microsoft Alias: cfowler

Hi @spike008t, thanks for the feedback! We are currently investigating and will update you shortly.

@spike008t This information is now published at https://docs.microsoft.com/en-us/azure/app-service/containers/configure-language-php. If you observe it in a non-PHP app, please let us know. Thanks. #please-close

Thanks @cephalin. We will now proceed to close this thread.

@spike008t This information is now published at https://docs.microsoft.com/en-us/azure/app-service/containers/configure-language-php. If you observe it in a non-PHP app, please let us know. Thanks.

My Python docker app is seeing this request, maybe the documentation shouldn't be PHP specific?

My aspnetcore webapi apps are seeing it as well

One of my worker services running on Docker is failing the health check repeatedly as well, causing the App Service to shut it down because it believes it to be unhealthy. My worker service doesn't have any available HTTP endpoints.

I forget to mention when I post the issue, that's happens under my dockers containers under nodejs and aspnetcore, and I do not have PHP app... For my point of view, that's happens when using docker on app service.

@Grace-MacJones-MSFT please reopen this to have the other stacks considered as reported. We had this come up in support for Python as well.

@dcbrown16 i have reopened the issue.

Sorry for the delay. The text is now reproduced in the other Linux configure docs. #please-close

We're seeing this as wel in Web App for containers that are hosting an ASP.NET Core API.  Although the documentation mentions that we can safely ignore these failed requests, it would be better if those requests do not appear in our logs anyway, as they don't bring any usefull information, only confusion.

We appreciate the feedback @fgheysels. We'll pass along to the product group to see how it can be addressed.


Updated basic debugging

Updated basic debugging topic
What does this PR do?
Adds missing content about printing the model summary if .fit() is not called.
Fixes #14487
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[X] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[X] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @Felonious-Spellfire @akihironitta

@Felonious-Spellfire you can just write
Fixes #<issue_num_1>
Fixes #<issue_num_2>

in the PR description. This will link the issue to the PR, which will close automatically when it gets merged.


error on nix-env -u after channel update

I am getting following error after a channel update:
error: attribute ‘replaceStrings’ missing, at /nix/store/22a8s3q4zvjkcrbpnv9dx8damc0mrzf9-nixpkgs-16.03pre70277.3d0c064/nixpkgs/pkgs/applications/editors/geany/with-vte.nix:2:12

How can I help debug this issue? FWIW:
 $ nix-channel --version
nix-channel (Nix) 1.9

 $ nix-channel --list
nixpkgs https://nixos.org/channels/nixpkgs-unstable

That package is trying to use builtins.replaceStrings which only became available with nix-1.10, so you need to upgrade it to evaluate it.

https://nixos.org/wiki/How_to_update_when_nix_is_too_old_to_evaluate_nixpkgs

Thanks for the quick tip, it works now :+1:

This went to release-15.09: 729ec1ece247741687282b211bee5661b9d670ce
Should really nixpkgs 15.09 require nix 1.10? Wasn't this intended for master alone?

@viric I've reverted it on the 15.09 branch, turns out it wasn't actually needed.


Enable incremental server-side regeneration for store pages  & render all dynamic routes as static files

SALEOR-1566

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1566 Enable incremental server-side regeneration for store pages

Task linked: SALEOR-1566 Enable incremental server-side regeneration for store pages


#507: fix asyncio issues

Work on #507.
Asyncio has some known issues, per their changelog. Namely issues with fixture handling etc., which I believe causes the warnings and test skips in our runs. They recommend using the previous version until they are fixed. It is also why my setup didn't spew up any warnings, my asyncio version was 21.1.
https://pytest-asyncio.readthedocs.io/en/latest/reference/changelog.html
I am wondering if I should mark #507 as closed or not. I do suggest keeping this around if newer versions of asyncio will work as expected, and we can remove the strict version setting in setup.py. Thoughts, @trentmc?

I am wondering if I should mark https://github.com/oceanprotocol/pdr-backend/issues/507 as closed or not

It's fine to close. No need to have the mental overhead to manage.
I just merged this PR into the yaml-cli2 branch (given weekend, to keep things moving). I will also close the issue.


Use ports instead of PC and new_PC variables

The idea is to keep PC in ports in the same manner as ID stage keeps instruction data.
There may be an issue with initial value, two ways to solve it are possible:

add a Core->IF port which propagates startPC in the beginning of the simulation (more difficult, but it's hard to break it)
use startPC if all the ports which may contain PC are empty (easier but has potential issues)

@alex19999 Have you made any progress on this last year?

Oh, sorry, I forgot about this task. If it is necessary, I can try to do it firstly21.02.2018, 21:22, "Pavel I. Kryukov" notifications@github.com:@alex19999 Have you made any progress on this last year?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

That's a very easy task. If you finish it by Feb 26, you got 1 point, otherwise I'll do it myself.

Ok, I understood. I can't promise you a result, because I will work at the "Phystech" olympiad this weekend, so now I must do some homework. No matter I will try.21.02.2018, 21:36, "Pavel I. Kryukov" notifications@github.com:That's a very easy task. If you finish it by Feb 26, you got 1 point, otherwise I'll do it myself.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Pavel Igorevich, may I do Core->IF port without any latency? Or what can I do? I have problems at this stage21.02.2018, 21:36, "Pavel I. Kryukov" notifications@github.com:That's a very easy task. If you finish it by Feb 26, you got 1 point, otherwise I'll do it myself.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Zero-latency ports are possible, but it is better to avoid them.
Why do you need them?

I have a problem, that Core->IF port can't read PC from cycle = 0, but it is necessary to initialize starting PC value

I think the best option is to issue a nop to the pipeline if there is no valid PC

+ability to issue a nop to the pipeline is a direct way to implement instruction cache

Pavel Igorevich, hello. Can you help me?
Firstly, I add function get_PC( Cycle cycle), which helps me to get valid(or not) PC
   template <typename ISA> Addr PerfSim<ISA>::get_PC( Cycle cycle)     {
  const bool is_flush = rp_fetch_flush->is_ready( cycle) && rp_fetch_flush->read( cycle);
  const bool is_stall = rp_decode_2_fetch_stall->is_ready( cycle) && rp_decode_2_fetch_stall->read( cycle);
  if(rp_core_2_fetch_target->is_ready( cycle))
      return rp_core_2_fetch_target->read(cycle);
  if ( is_flush)
      return rp_memory_2_fetch_target->read( cycle);
  else if ( !is_stall)
      if(rp_target->is_ready( cycle))
          return rp_target->read( cycle);
      return NO_VAL32;
   } `

Then I introduce the get_instr(Addr PC) function, which generate  instruction, which will be sent to decode stage
template <typename ISA>  typename PerfSim<ISA>::Instr PerfSim<ISA>::get_instr( Addr PC)   {
 if(PC != NO_VAL32)
      return Instr( memory->fetch_instr( PC), bp->get_bp_info( PC));
  return  Instr( FuncInstr(0x0u),  bp->get_bp_info( PC));
 }

`
In fetch stage I have
 auto PC = get_PC( cycle);
auto instr = get_instr( PC);
 wp_fetch_2_decode->write( instr, cycle);
But in the result there is only mismatch, for example
Mismatch:
Checker output: 0x4000d0: or $t1, $zero, $zero	 [ $t1 = 0x0 ]
PerfSim output: nop
Could you help me?

For invalid PC, use 0 instead of NO_VAL32 as there is some probability that real program will use 0xdeaddead address.
Then you have an instruction with 0 bytes and 0 PC. It should be a special case;

MIPSInstr bool is_bubble() const {
    return is_nop() && PC == 0;
}

Bubbles should be ignored by WB stages:

    auto instr = rp_memory_2_writeback->read( cycle);

    /* perform writeback */
    rf->write_dst( instr);

    /* NEW CODE HERE */
    if ( instr->is_bubble())
        return;

    /* check for traps */
    instr.check_trap();

    /* log */
    sout << instr << std::endl;

    /* perform checks */
    check( instr);

    /* update simulator cycles info */
    ++executed_instrs;
    last_writeback_cycle = cycle;

I added your code and it started working perfectly, but only in one instruction, then I have infinite cycle in writeback. I will try to fix it


Explicitly specify encoding in open file

Without this change, I ran into UnicodeDecodeError in python 3.5.2. I believe this is because newer versions of python support multiple enocdings, and may not choose the correct encoding by default. Specifying the encoding explicitly I think should fix the problem always.

This probably works on Windows systems but causes an issue in Linux/Mac. Hence, we won't be merging this change.


Add LimitPushdown optimization rule and CoalesceBatchesExec fetch

Which issue does this PR close?
Closes #.
Rationale for this change
Physical plans can be optimized further by pushing GlobalLimitExec and LocalLimitExec down through certain nodes, or using versions of their children nodes with fetch limits, without changing the result. This reduces unnecessary data transfer and processing for a more efficient plan execution.
CoalesceBatchesExec can also benefit from this improvement, and as such, a fetch limit functionality is implemented for it.
For example,
GlobalLimitExec: skip=0, fetch=5
  StreamingTableExec: partition_sizes=1, projection=[c1, c2, c3], infinite_source=true

can be turned into
StreamingTableExec: partition_sizes=1, projection=[c1, c2, c3], infinite_source=true, fetch=5

and
GlobalLimitExec: skip=0, fetch=5
  CoalescePartitionsExec
    FilterExec: c3@2 > 0
      RepartitionExec: partitioning=RoundRobinBatch(8), input_partitions=1
        StreamingTableExec: partition_sizes=1, projection=[c1, c2, c3], infinite_source=true

can be turned into
GlobalLimitExec: skip=0, fetch=5
  CoalescePartitionsExec
    LocalLimitExec: fetch=5
      FilterExec: c3@2 > 0
        RepartitionExec: partitioning=RoundRobinBatch(8), input_partitions=1
          StreamingTableExec: partition_sizes=1, projection=[c1, c2, c3], infinite_source=true

without changing the result, but using fewer resources and finishing faster
Other examples can be found in the tests provided in limit_pushdown.rs
What changes are included in this PR?
Implement LimitPushdown Rule:

Introduced new APIs in the ExecutionPlan trait:

with_fetch(&self, fetch: Option<usize>) -> Option<Arc<dyn ExecutionPlan>>: Returns fetching version if supported, None otherwise. The default implementation returns None
supports_limit_pushdown(&self) -> bool: Returns true if a node supports limit pushdown. The default implemenation returns false

Add fetch support to CoalesceBatchesExec:

Add fetch field and with_fetch implementation
Add new_with_fetch constructor
Implement fetch limit functionality

Are these changes tested?
Unit tests are provided for LimitPushdown and the new fetching support for CoalesceBatchesExec
Are there any user-facing changes?
No. The changes only affect performance

Rebased the fork because of conflicts

@alihandroid this PR is in very good shape for initial work. 🚀 🚀 . Most of the plan changes generates better plans. However, some of the plans can be still better. Specifically we have some stacks in the plan
LocalLimit(n)
--Projection
----LocalLimit(n)

These stacks can be converted to the
Projection
--LocalLimit(n)

I think, during pushdown in some cases top limit is not removed. However, I am not sure. Other than this problem, this PR functionally almost complete.

Thanks @alihandroid for this PR. I think this PR is in good shape. @ozankabak will do his own review. After his comments are addressed, this PR is ready to go upstream. Thanks for this work. 🚀 🚀 .

@alihandroid, I reviewed it and it looks good. This will be ready to go upstream after you address @berkaysynnada's comments. Great work!

@berkaysynnada Still working on the coalesce batches test cases but the limit merging is done. The PR at the upstream repo is https://github.com/apache/datafusion/pull/11652

@berkaysynnada Still working on the coalesce batches test cases but the limit merging is done. The PR at the upstream repo is apache#11652

Great job. The tests are failing because there are two concat_batches functions: one that requires the number of rows and another that does not. You should use the one from arrow::compute. I took a quick look, and it seems well done. Good work! 👍🏻

Merged upstream.


Monitoring

Sets up basic monitoring. Lets get this merged to master and push out a new version of the contracts and sdk so I can deploy this to AWS

Summary of changes

rename asset to reserve in eth call contracts
fix all kevin comments
force project to use node 18


Only 6 blocks created in the last 60 minutes.

In the last hour there has only been 6 blocks created, 3751-3755(One orphaned)
I read that there should be a block every 3 or so minutes, there may be a problem with the speed atm.

Closing this issue as it is stale for a long time.


Sp4 407 fix share location switch lag fe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Refactor - Use the command line argument parsing from stanza proper

The current slm project uses a homegrown argument parsing routing to manage the inputs to the program. This works but isn't very flexible and doesn't provide the ability to include help flags, or other flags to control how slm itself functions.
I propose that we use the command line argument parsing from the stanza compiler itself which is defined in the arg-parser package. I've used this for the docgen utility very effectively. This would provide the following benefits:

More complete argument parsing capability with support for:

Required / Optional Arguments
Command / Sub-command processing
Individualized command help text.
Flag and Arg Typing (OneArg, ZeroOrOneArg, etc)

Makes the command line interface for all of the Stanza tooling consistent across the board.

This provides a better user interface and experience.
Consistency builds confidence and reuses acquired knowledge.

Complete.


fix: ratelimit not working with both headers and cidr matches

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #4351

/retest


add inlining pragma

Unboxed records lead to the definition of many functions (on the Agda side) that lift functionality to unboxed records by wrapping and unwrapping accordingly. However, once compiled this overhead disappears and the resulting output could be inlined.
This PR introduces the {-# COMPILE AGDA2HS name inline #-} pragma that tells agda2hs to do the inlining automatically. Underapplied inline functions will be eta-expanded so that the substitution still happens.

record Wrap (a : Set) : Set where
  constructor Wrapped
  field
    unwrap : a
open Wrap public
{-# COMPILE AGDA2HS Wrap unboxed #-}

mapWrap : (f : a → b) → Wrap a → Wrap b
mapWrap f (Wrapped x) = Wrapped (f x)
{-# COMPILE AGDA2HS mapWrap inline #-}

mapWrap2 : (f : a → b → c) → Wrap a → Wrap b → Wrap c
mapWrap2 f (Wrapped x) (Wrapped y) = Wrapped (f x y)
{-# COMPILE AGDA2HS mapWrap2 inline #-}

test1 : Wrap Int → Wrap Int
test1 x = mapWrap (1 +_) x
{-# COMPILE AGDA2HS test1 #-}

test2 : Wrap Int → Wrap Int → Wrap Int
test2 x y = mapWrap2 _+_ x y
{-# COMPILE AGDA2HS test2 #-}

-- partial application of inline function
test3 : Wrap Int → Wrap Int → Wrap Int
test3 x = mapWrap2 _+_ x
{-# COMPILE AGDA2HS test3 #-}

compiles to:
test1 :: Int -> Int
test1 x = 1 + x

test2 :: Int -> Int -> Int
test2 x y = x + y

test3 :: Int -> Int -> Int
test3 x = \ y -> x + y

Right now the names of the inserted lambdas come from the names given to the patterns in the inlined function. I suspect these could shadow names outside of where the inlined function is being used. Suggestions welcomed for making it more robust.

Noticed it can loop on some examples, need to fix it.

@flupe what's the status on this?

Getting back to this now.

Somehow #247 adding test/golden/Haskell/... made the CI unreliable, because the test themselves don't produce this file.
I thought we didn't cache test files but I removed the file anyway since this PR makes it unnecessary.

So the PR is ready. Instead of defining our own routine for inlining, we currently rely on Agda's unfoldDefinitionStep reduce function. This means we're overly conservative currently, as we forbid pattern-matching on anything other than unboxed records constructors.
It should be fine to allow pattern-matching on erased arguments (say, an equally type), but unfoldDefinitionStep would no longer unfold the function and we would have to implement our own matching routine. This is left for a next PR.

Thanks!


Add a script for running tests on cloud (deploy_test_gcp.sh)

Change summary:

Add a script for running tests on cloud (deploy_test_gcp.sh)

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/762

Run time:

macbook pro (1.4 GHz Quad-Core Intel Core i5)
yarn run test_integration_node
=> 9 m 06 s

c2-standard-4:
bash deploy_test_gcp.sh seo 0 --keep-code test_integration_node
=> 8 m 59 s

c2-standard-16:
bash deploy_test_gcp.sh seo 1 --keep-code test_integration_node
=> 8 m 51 s

Thanks for the review, now merging..


Roadmap to v0.5

These PR incorporates all the changes from #108 and all the fixes provided thereafter. So to allow a clear step-by-step plan to a new release (v0.5) that will provide all the improvements in #108 plus all the features implemented in the new traits system.
For a documentation of the process: https://github.com/smartcorelib/smartcore/discussions/185
For a walkthrough starts from this branch's README.
EDIT:
This PR will include important breaking changes and cleanup. For example:

no more bindings for other numerical crates (probably)
no more support for "naive" DenseMatrix (only new DenseMatrix with num-traits)
Goodbye Matrix. Welcome Array2
Goodbye BaseVector. Welcome Array1
introduce use of trait-objects
...

cc: @NikZak @Steboss

ensemble/random_forest_regressor.rs is working ok.
Help needed
I have problems with implementing random_forest_regressor.rs:

the parameter keep_samples: bool, is never used in the code, it should be as it is needed for OOB prediction
at this line the storage of the samples is partially implemented. RandomForestRegressor.samples should be populated.
Expecting:

RandomForestRegressor {
    parameters: parameters,
    trees,
    samples
}

We should have code that:

add the samples: Option<Vec<..>> property to the RandomForestRegressor so that we can store samples if needed
add the code for pushing to the Option<Vec<..>> when keep_samples is true
reimplement predict_oob using the new samples property

@morenol please take a look to the refactoring of src/model_selection/hyper_tuning considering:

SupervisedEstimator now has the trait Predictor
cross_validate has now a different signature (use borrowing where possible)

@montanalow please take a look to the implementations in src/svm.
Notes:
I changed some things in src/svm/mod.rs so that svd.rs and svr.rs need changes accordingly (for example Kernel is now Kernel<T> instead of Kernel<V, T>). Also now SupervisedEstimator is defined differently in api.rs (is now composed with Predictor so that it needs both a fit and predict method).

ndarray-bindings working -> https://github.com/smartcorelib/smartcore-jupyter/blob/main/notebooks/05-ndarray-bindings.ipynb

Please see the new implementation for Kernel trait, using object-safe trait for dynamic dispatch

Current flamegraph for CPU

Some improvements in syscalls and CPU usage, much less malloc present as well

@morenol please take a look to the wasm32 build and tests. I would like to exclude datasets from the wasm32 build and by consequence all the tests that use "datasets" or "make_blobs".

I see that for wasm, failure is due to float eq implementation, let me check what I can do to solve that
  left: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.224623551524334, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`,
 right: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.2246235515243336, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`', src/naive_bayes/multinomial.rs:491:9

I see that for wasm, failure is due to float eq implementation, let me check what I can do to solve that
  left: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.224623551524334, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`,
 right: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.2246235515243336, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`', src/naive_bayes/multinomial.rs:491:9

yes we will probably run into some differences in types for Wasm, we can also go and write dedicated tests.

Look into some Cargo.toml settings:
resolver = "2"

[profile.test]
debug = 1
opt-level = 3
split-debuginfo = "unpacked"

[profile.release]
debug = 1
lto = true
codegen-units = 1
overflow-checks = true


hello

hello~~
The plugin is using so well
Is it possible to adjust 0.5 unit?
I have the desire to precisely set up  XD

Probably yes

Try it out: https://github.com/jackun/USBqemu-wheel/releases/tag/0.8.2-0


implement a $NO_OP return value  that indicates already from the comp…

…onent that nothing was changed
eg. if the application using lit-html already uses a caching layer

I signed it!

Why don't you just not call render if your data hasn't changed? Shouldn't that result in the same?

@NeoLegends
because there are components up the tree which needs to be rendered
A
|-B

lets say render starts with A which uses B but only B can be cached.

Ah, I understand. B cannot render itself (instead of being rendered by A)?

created a new pr: https://github.com/Polymer/lit-html/pull/357


[OperationalInsights] update SDK with latest swagger changes

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

I'm unable to run the generate.ps1 script locally.
running this manual script instead:
autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/operationalinsights/resource-manager/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder="C:\One\SDK_repos\azure-sdk-for-net\sdk"
not sure how to use the script and prevent the discrepancy between my code gen and the automatic code gen in the pipeline


Fix wasm loader check data segment count

When datacount section exists, loader will check whether the data count
read from data segment section is same with the data count read from
datacount section, but the value of latter can be 0, loader should not
skip the check when the latter is 0.

LGTM


Added travis cross compilation support for linux/solaris/windows

Automates having Travis CI build binaries for Linux, Solaris and Windows. It can support any other architectures that golang supports as long as they don't use import "C".
Unfortunately when using CGO, the headers and libraries required to cross compile are not available. The only function currently complaining is procUsage.
You will need to create a GITHUB_TOKEN with repo privileges and assign that as an ENV var in Travis-CI to get everything operational.
@derekcollison @wallyqs

So this currently does not work correct?

It works for the platforms included. Just doesn't include all the platforms we want.

Yeah you shouldn't need mousetrap.

What's the next step on this, folks?

This is ready to go for windows, solaris and linux. The travis file will push built binaries whenever you push a tag.
Here's what the output looks like:
cross_compile ✔ $ ./scripts/cross_compile.sh
Number of parallel builds: 3

-->     windows/386: github.com/zquestz/gnatsd
-->   windows/amd64: github.com/zquestz/gnatsd
-->       linux/386: github.com/zquestz/gnatsd
-->       linux/arm: github.com/zquestz/gnatsd
-->     linux/amd64: github.com/zquestz/gnatsd
-->   solaris/amd64: github.com/zquestz/gnatsd
make pkg/gnatsd-linux_386.zip
make pkg/gnatsd-linux_amd64.zip
make pkg/gnatsd-linux_arm.zip
make pkg/gnatsd-solaris_amd64.zip
make pkg/gnatsd-windows_386.zip
make pkg/gnatsd-windows_amd64.zip

However darwin doesn't function due to the following error:
1 errors occurred:
--> darwin/amd64 error: exit status 2
Stderr: # github.com/nats-io/gnatsd/server
../../nats-io/gnatsd/server/monitor.go:460: undefined: procUsage

Appears the procUsage function in the pse_*.go files break on some platforms.

Thanks, how do we fix for macosx since we do ship release builds for it?

We figure out another way to refactor procUsage to avoid C functions not available on linux. Ideally we figure out a good way to implement procUsage in go to make it more portable.


4k video seekbar is not working

Hi Marcel,
I was testing 4k video but seekbar is not working
If you seek it keeps restarting the video and click on any position on seekbar is not responding..all other 1080 videos are working perfactly but this 4k MKV video is not working i will test another 4k video but this is working perfectly in MX player!
Thanks

Hi. Only way to find out what's going on is to examine the video (sample) so try sharing it here (or send me an email - link in profile). What device (and OS version) are you using?

Hi. Only way to find out what's going on is to examine the video (sample) so try sharing it here (or send me an email - link in profile). What device (and OS version) are you using?


Remove unnecessary schema

I think validations and validateOn properties should be contained in question object.. I am removing misplaced schema.
Kindly review it.

Appreciated.


Minor DOM Fixes

Wasn't sure if there needs to be an official issue for this.

Ignore JetBrains settings folder
Apparently an invalid character was provided after the page directive?
Added closing div tag to Moderation.cshtml
Added closing select to blocked users
Added closing carrot for div in waterfall

The TagzApp.Web project is the older project that is being deprecated in favor of the Blazor projects. I’ll review and we can merge tomorrow on stream. Thanks!JeffOn Mar 6, 2024, at 17:09, Badger @.***> wrote:Wasn't sure if there needs to be an official issue for this.
Ignore JetBrains settings folder
Apparently an invalid character was provided after the page directive?
Added closing div tag to Moderation.cshtml
Added closing select to blocked users
Added closing carrot for div in waterfall
You can view, comment on, or merge this pull request online at:
  https://github.com/FritzAndFriends/TagzApp/pull/392
Commit Summary
d4e4d9f  Minor Fixes
File Changes  (5 files)
M
.gitignore
(3)

M
src/TagzApp.Blazor/Components/Pages/_Waterfall.razor
(2)

M
src/TagzApp.Web/Pages/BlockedUsers.cshtml
(7)

M
src/TagzApp.Web/Pages/Moderation.cshtml
(2)

M
src/TagzApp.Web/Pages/Overlay.cshtml
(2)

Patch Links:
https://github.com/FritzAndFriends/TagzApp/pull/392.patch
https://github.com/FritzAndFriends/TagzApp/pull/392.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

That would make sense! If this is the case, then there's an issue where the docker-compose.local.yml is pointing towards the Blazor project's Dockerfile. Issue being the dockerfile does not exist. Perhaps I'm early to the party lol.


Extend the lifetime of the buffer while copying from a _CocoaArrayWrapper

Fixes rdar://90108215.

@swift-ci swift please smoke test

@swift-ci please smoke test

@lorentey Heads up for any calls to NSArray/NSDictionary getObjects. It copies into a C array without retaining the elements so we need to manually keep the original container alive.

🙀 Wow, thanks for catching this!
I would've probably looked at this for hours, assuming self was kept alive, and completely missing that this is a __consuming method.


README: more generic coqdoc link

As mentioned in https://github.com/coq-community/templates/commit/e506a07d2d00077df2e368e48287c6091d900b6a#r37736651

I haven't really followed the coqdoc support in the templates, so I can't comment on this, but now the coq-community.org domain exists, so every coq-community.github.io could be replaced by coq-community.org.


update sphinx version

We have a sphinx version issue.
I've pinned the sphinx version to 2.0.1 for now (in requirements-docs.txt), but I think when sphinx 3.1.x comes available, we should be able to add the :recursive: option to our .. autosummary:: directives, and get the same behavior.

@amoodie just tried updating my local Sphinx version to the latest (v3.4.1) and I am not seeing the same issues we had previously with the autodocumentation (which if I remember right was missing API documentation of various functions/methods).
So I think we can probably go ahead and remove the fixed versioning of sphinx. I'm not sure what :recursive: adds to our documentation, the way the autosummary stuff is set up now continues to work as it has been.

Yeah, I agree. I just updated my local to the same version and it seems fine :+1:
Yeah, I guess just ignore that, I don't really remember what exactly I had in mind when I wrote that...


Fix RDFS Labels

I got the truth value incorrect (G.objects always returns a generator, which is True) for some of the duplicate RDFS label logic, resulting in missing labels for many concepts. This rectifies the error and ensures that labels are included on Brick concepts.

Tested offline and all tests pass


Crashing on startup with Backslot

Mod Name
Backslot
Mod Homepage
https://legacy.curseforge.com/minecraft/mc-mods/backslot
Describe the bug
when installing backslot the game crashes on startup
Steps to reproduce

...
Logs
https://mclo.gs/9gSp7Vc
Additional context
No response

The mod depends on amecsapi, which conflicts with Forge's keybind modifier system. I'll see if it's possible to create a bridged version in Connector Extras.

Fixed in Connector Extras 1.6.0, which now bundles a Forge port of Amecs API


[FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

What is the purpose of the change
Improve the performance and code structure for org.apache.flink.table.runtime.util.collections.ByteHashSet.
Since there are only 256 possible byte values, the largest possible range is 255, and the condition
range < OptimizableHashSet.DENSE_THRESHOLD
must be satisfied. So ByteHashSet must be in dense mode.
We can make use of this to improve the performance and code structure.
Brief change log

Change the code so it only considers the case for dense mode.

Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Hi @JingsongLi, would you please take a look?

Please change JIRA component and PR name to SQL RUNTIME/Operator and table-runtime-blink.

Please change JIRA component and PR name to SQL RUNTIME/Operator and table-runtime-blink.

Revised. Thanks.

LGTM +1

Thanks for the effort @liyafan82 @JingsongLi .
Merging...

@flinkbot approve all


License

I would like to use your grammar for AutoIt but I don't know what licensing terms you're distributing it under. Any chance you could pick one from here: http://choosealicense.com?

MIT.

https://github.com/AutoIt/SublimeAutoItScript/commit/41171d9b643ea4d99895ecf008fb7d9417ed99ef

@jbrooksuk That was fast :zap: Thanks!

Yeah, Thanks James! :)


Fix typo in oauth2 plugin

Fix issue mentioned by @clausdenk
Closes https://github.com/hellofresh/janus/issues/314

+1


Reenable S3 integration tests against Ceph

Move to ceph/daemon Docker images. It would appear that
ceph/demo has been deprecated a while back (no more updates)
but I failed to find any information about it.
Ignore errors when trying to kill docker container (I'd might
have died already.)

Thanks!


Race event when hosting the cave_app causes the app page to crash on normal reload but not clear cache and hard reload

Thought this was specific to daphne, but it appears to be general to django for us at this point.

@connor-makowski I've fixed this in 0.3.0-dev. Do you want me to add a hotfix branch 0.2.1, or just keep the fix in 0.3.0-dev?

0.3.x is fine
On Sat, Sep 17, 2022, 1:31 PM Will Guter @.***> wrote:

@connor-makowski https://github.com/connor-makowski I've fixed this in
0.3.0-dev. Do you want me to add a hotfix branch 0.2.1, or just keep the
fix in 0.3.0-dev?
—
Reply to this email directly, view it on GitHub
https://github.com/MIT-CAVE/cave_static/issues/42#issuecomment-1250110826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3ICW4CDIOJARKFQENMF7DV6X57FANCNFSM6AAAAAAQOQG4KU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add all orgs and no orgs to filter

What
Allow organisation_id parameter to accept all and none.
all will not apply the organisation filter.
none will return content that has a nil organisation_id.
This is a non-breaking change.
Trello: https://trello.com/c/oWvlfbPR/878-3-index-page-add-all-organisations-and-no-organisations-to-the-organisation-filter

 (3) Index page - Add 'all organisations' and 'no organisations' to the organisation filter

@pmanrubia @peteglondon I feel the behaviour for ALL org-ids isn't consistent with other filters. As they are filters, the absence of an organisation filter should indicate ALL - (this the behaviour of document_type.)

@pmanrubia @peteglondon I feel the behaviour for ALL org-ids isn't consistent with other filters. As they are filters, the absence of an organisation filter should indicate ALL - (this the behaviour of document_type.)

I think this is easier to understand than having a blank parameter. If we want to be consistent we should change the document_type filter.


feat/#2331:When monitoring HTTP, add a User Agent.

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
It is intended to verify that it is an internal check system through a user agent.
By default, you send "Uptime Kuma"
Allows the user to put the User Agent in the character set by the user.
UI: Allows the user to input a user agent to be used for monitoring.
Monitor: Check Health with User Agent input from UI.
Fixes #(issue)
Type of change

New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings

Screenshots (if any)

You can already adjust the http headers - in that you can define the user-agent…
Wouldnt your PR and the existing option then collide e.g. when a user-agent is defined in http headers and your new option-field?

You can already adjust the http headers - in that you can define the user-agent…
Wouldnt your PR and the existing option then collide e.g. when a user-agent is defined in http headers and your new option-field?

Good point. I think the custom headers could override the User Agent already.
Also this implementation is just appending a custom string in front of Uptime-Kuma/1.19.3 which is a bit strange.

I didn't know it had a function.
I'll close the PR.
Thank you.

I didn't know it had a function.
I'll close the PR.
Thank you.