Implement the main customer pages

This PR implements the Customer Search, Add, and Details pages.
Also included:

Adjusted the entities to make some properties nullable.
Refactored the "Create" methods in the entity managers.
Added an "Admin" role.
Modified the relevant DTOs.
Added validators and permissions handlers for Customer and Contact.
Added a bunch of Razor display templates and editor templates.

@tom-karasch Sorry for spamming you with all these failed tests! It took a few tries to get the proper syntax right for fixing the GitHub actions.

Good catch finding that the issue was the .NET and SDK versions. That would have driven me nuts tracking that down.


./image_builder.sh get "e2fsck: Cannot continue, aborting" each time in ubuntu

script -fec 'sudo -E USE_DOCKER=true ./image_builder.sh ${ROOTFS_DIR}'
Script started, file is typescript
[sudo] password for teawater:
Sending build context to Docker daemon  536.9MB
Step 1/3 : From fedora:latest
---> 8c568f104326
Step 2/3 : RUN [ -n "$http_proxy" ] && sed -i '$ a proxy='$http_proxy /etc/dnf/dnf.conf ; true
---> Using cache
---> 5c404d9eadc1
Step 3/3 : RUN dnf install -y qemu-img parted gdisk e2fsprogs
---> Using cache
---> acb3e22760e3
Successfully built acb3e22760e3
Successfully tagged image-builder-osbuilder:latest
[OK] init is installed
[OK] init is systemd
[OK] Agent installed
INFO: Create root disk image. Attempt 1 out of 5.
INFO: Creating raw disk with size 128M
[OK] Image file created
INFO: Creating partitions
[OK] Partitions created
/dev/loop8: gpt partitions 1
INFO: Formatting Image using ext4 filesystem
INFO: Mounting root partition
[OK] Image formatted
INFO: Set filesystem reserved blocks percentage to 3%
[OK] root partition mounted
tune2fs 1.44.3 (10-July-2018)
Setting reserved blocks percentage to 3% (967 blocks)
INFO: Free space root partition  112 MB
INFO: Waiting for /dev/loop8 to detach
INFO: detached
INFO: Create root disk image. Attempt 2 out of 5.
INFO: Image size 128MB too small, trying again with size 256MB
INFO: Creating raw disk with size 256M
[OK] Image file created
INFO: Creating partitions
[OK] Partitions created
/dev/loop8: gpt partitions 1
.INFO: Formatting Image using ext4 filesystem
INFO: Mounting root partition
[OK] Image formatted
INFO: Set filesystem reserved blocks percentage to 3%
[OK] root partition mounted
tune2fs 1.44.3 (10-July-2018)
Setting reserved blocks percentage to 3% (1950 blocks)
INFO: Free space root partition  218 MB
INFO: Waiting for /dev/loop8 to detach
INFO: detached
INFO: Create root disk image. Attempt 3 out of 5.
INFO: Image size 256MB too small, trying again with size 384MB
INFO: Creating raw disk with size 384M
INFO: Creating partitions
[OK] Image file created
[OK] Partitions created
/dev/loop8: gpt partitions 1
INFO: Formatting Image using ext4 filesystem
INFO: Mounting root partition
[OK] Image formatted
INFO: Set filesystem reserved blocks percentage to 3%
[OK] root partition mounted
tune2fs 1.44.3 (10-July-2018)
Setting reserved blocks percentage to 3% (2933 blocks)
INFO: Free space root partition  335 MB
INFO: Waiting for /dev/loop8 to detach
INFO: detached
INFO: Create root disk image. Attempt 4 out of 5.
INFO: Image size 384MB too small, trying again with size 512MB
INFO: Creating raw disk with size 512M
[OK] Image file created
INFO: Creating partitions
[OK] Partitions created
/dev/loop8: gpt partitions 1
INFO: Formatting Image using ext4 filesystem
INFO: Mounting root partition
[OK] Image formatted
INFO: Set filesystem reserved blocks percentage to 3%
[OK] root partition mounted
tune2fs 1.44.3 (10-July-2018)
Setting reserved blocks percentage to 3% (3916 blocks)
INFO: Free space root partition  452 MB
INFO: rootfs size 375 MB
INFO: Copying content from rootfs to root partition
[OK] rootfs copied
e2fsck 1.44.3 (10-July-2018)
e2fsck: Cannot continue, aborting.
/dev/loop8p1 is in use.
Script done, file is typescript

That's weird, since we are running CI tests on a ubuntu host.
So e2fsck is erroring out, and the most obvious reason is that the partition specified is still mounted.
Can you run a add a line with
mount | grep loop

right before this line: https://github.com/kata-containers/osbuilder/blob/ea8004087af3d3a532eecc0567100283302dd416/image-builder/image_builder.sh#L281
This is to check if there's a problem with unmounting the loop device.

@marcov Thanks!
When I tried to add this line, I found that I cannot reproduce this issue.


Imported Data Upload and Rollback

The importing user (PT Providers or QA Managers) should be able to:

preview the data imported
roll back an import (PT Providers can only roll back their own unconfirmed imports. QA Managers can roll back any)
confirm (button) that the data is okay (before it can be accessible from reports)
QA Managers should be able to revoke particular imports (ie remove the confirmation flag).

Sorted


[feature] Change three_d_secure_info to check_payment_method_nonce

This PR changes three_d_secure_info name to check_payment_method_nonce and uses Responses as results.

 Braintree - SSP 3DS & Store Authorizations


Right clicking while on the canvas messes up selection

If we right click on the canvas, then I think that onmouseup isn't triggered and we're no longer deleting the selection object.

Maybe we should listen to context menu as well and clean things up there. Worst case, would be nice to clean up on mousedown if we haven't received mouseup.

I'll try to fix it


Add support for jwks endpoint for service provider

Add the ability to use a jwks end point for service provider related signature validation processes.

Fixed with https://github.com/wso2/carbon-identity-framework/pull/2024


Add a Race item type which functions similarly to the Class item

Basic Goals

The Race item would contain certain metadata about the racial traits or proficiencies which are granted.
Characters should be prevented from adding a 2nd race-type item to enforce that only one is chosen.

Status
This is not a priority in the short term - but something that should be added to the system eventually to provide for better automation in character creation.

Just want to mention that in addition to Item Grant, Races should also allow for Scale Value advancements, this could be used for Dragonborn Breath Weapons, or as a workaround for any homebrew a DM wants to scale off of total character level instead of class level


Bug

Describe the bug
A clear and concise description of what the bug is.
What is the error msg?
Copy File
Copy everything in the testData.json file
Desktop (please complete the following information):

OS: WINDOWS

Additional context
Add any other context about the problem here.

Known error Twitter, shut down the api I was using. Will be fixed in next update.

Any ETA on the next update? Curious on how you'll navigate the API change, if you're strapped for time I can commit the change if you point me in the right direction.

I'll answer all future questions on the discord server https://discord.gg/RPArf67xSu

I'll answer all future questions on the discord server https://discord.gg/RPArf67xSu


activerecord: CollectionProxy#build can take Hash-like object

The current definition of #build, #craete and #create! methods of
ActiveRecord::Associations::CollectionProxy#build take a Hash object.
But they can also take Hash-like object.  Usually, Rails apps pass an
instance of ActionController::Parameters.  The technique is well known
as "Mass Assignment".
Internally, they expects the object should have #each_pair method.
Therefore, this changes the signature of these methods to take a
Hash-like object instead of Hash.
refs: https://github.com/rails/rails/blob/v7.0.0/activemodel/lib/active_model/attribute_assignment.rb#L29

$ bundle exec rbs --repo gems -r activemodel diff --detail --format diff --type-name 'ActiveRecord::Associations::CollectionProxy' --before gems/activerecord/6.0 --after 598
- [::ActiveRecord::Associations::CollectionProxy public] def build: (?::Hash[untyped, untyped] attributes) -> untyped | (?::Hash[untyped, untyped] attributes) { () -> untyped } -> untyped
+ [::ActiveRecord::Associations::CollectionProxy public] def build: (?::ActiveRecord::Associations::CollectionProxy::_EachPair attributes) ?{ () -> untyped } -> untyped

- [::ActiveRecord::Associations::CollectionProxy public] def create: (?::Hash[untyped, untyped] attributes) -> untyped | (?::Hash[untyped, untyped] attributes) { () -> untyped } -> untyped
+ [::ActiveRecord::Associations::CollectionProxy public] def create: (?::ActiveRecord::Associations::CollectionProxy::_EachPair attributes) ?{ () -> untyped } -> untyped

- [::ActiveRecord::Associations::CollectionProxy public] def create!: (?::Hash[untyped, untyped] attributes) -> untyped | (?::Hash[untyped, untyped] attributes) { () -> untyped } -> untyped
+ [::ActiveRecord::Associations::CollectionProxy public] def create!: (?::ActiveRecord::Associations::CollectionProxy::_EachPair attributes) ?{ () -> untyped } -> untyped

/merge


Azure Sentinel Streaming - Table Name error

Customer reported issue with the Big-IP connector to Azure Sentinel.
In the customer incident, data is getting ingested into Azure Sentinel via the F5Telemetry_event_CL table instead of F5Telemetry_LTM_CL.   (BIG IP delivers to Azure Sentinel via REST API and the table name is set by F5 in the header of the post command.)
The currently published data connector, workbook and sample queries  all use  F5Telemetry_LTM_CL.
If this is a planned change, the documentation, workbooks and sample queries will need to be updated.

Environment

Telemetry Streaming Version: f5-telemetry-1.19.0-3.noarch
BIG-IP Version: 14.1.2

Summary
F5 BIG-IP logs are being ingested into F5Telemetry_event_CL but all queries, workbooks and connectors expect the logs to be ingested into F5Telemetry_LTM_CL, F5Telemetry_ASM_CL
Steps To Reproduce
https://devcentral.f5.com/s/articles/Integrating-the-F5-BIGIP-with-Azure-Sentinel

Observe the following error response:
Wrong table name

Expected Behavior
Logs should be ingested into:
F5Telemetry_LTM_CL
F5Telemetry_ASM_CL
Actual Behavior
Logs are being ingested into F5Telemetry_event_CL

I have updated the issue description using the information from the comment that appears to be using the bug template. I have also added the labels that are usually added by a template. Please be sure to use a template in the future when filing an issue so that our tooling and notifications work properly.

I can confirm I'm having the same issue with LTM logging.
Environment
Telemetry Streaming Version: f5-telemetry-1.19.0-3.noarch
BIG-IP Version: 	<IP_ADDRESS>

Summary
F5 BIG-IP logs are being ingested into F5Telemetry_event_CL but all queries, workbooks and connectors expect the logs to be ingested into F5Telemetry_LTM_CL
Steps To Reproduce
https://clouddocs.f5.com/products/extensions/f5-telemetry-streaming/latest/event-listener.html#requestlog
Observe the following error response:
Wrong table name

Expected Behavior
Logs should be ingested into:
F5Telemetry_LTM_CL
Actual Behavior
F5Telemetry_events_CL

hey @michaelebbels can you share the error on request logging profile?

@aleixsb are you able to share your request logging profile? I may be able to spot an issue with it. It sounds like @michaelebbels may have had the request-log-template property configured in a way that resulted in Telemetry Streaming failing to recognize it as an LTM event.

Hi Daniel,
Thanks! finally I managed to fix the issue, there was an error with the
template which I guess was causing the problem.
Best regards,
Aleix Sala Bach
On Thu, Jul 8, 2021 at 12:39 AM Daniel Stokes @.***>
wrote:

@aleixsb https://github.com/aleixsb are you able to share your request
logging profile? I may be able to spot an issue with it. It sounds like
@michaelebbels https://github.com/michaelebbels may have had the
request-log-template property configured in a way that resulted in
Telemetry Streaming failing to recognize it as an LTM event.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/F5Networks/f5-telemetry-streaming/issues/131#issuecomment-875980483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIVPVXUUTBLPKXHGKLKHB3TWTJQXANCNFSM44WLVNEQ
.


Failed to load Wasm module in Istio

HI @anuraaga, thank you for releasing such a great GC strategy in proxy-wasm!
I am having trouble with the default GC in TinyGo(v0.27.0) as well.
When I try to compile my wasm plugin use nottinygc and follow the instructions in the readme, the compilation works. But when I deploy it into a k8s cluster with Istio(v1.14 and v1.16), the envoy shows the error when loading the wasm module.
Here is the error message inside envoy proxy.
Failed to load Wasm module due to a missing import: wasi_snapshot_preview1.sched_yield

Do you have any insights for such an issue? Appreciate your help!

Hi @MengjiaLiang - thanks for the question. This is a known issue with Envoy which I have added docs for, I think that should fix it for you
https://github.com/wasilibs/nottinygc#using-with-envoy
For context, it is the same approach we use here
https://github.com/corazawaf/coraza-proxy-wasm/blob/main/init_tinygo.go#L14

Thank you Anuraag for the quick response!
This works great now!
From my load testing result, the memory usage of Istio(that uses the default GC) increases linearly along with the traffic volume.
After replacing the gc and malloc with nottinygc, I didn't see too much CPU increment, but the memory usage will be stable at some level no matter how much the traffic volume is. This is brilliant!
Appreciate your help again!


feat: add client and server icon

Resolves #791 Added the missing Client and Server Icon and rename ProtocolBadge to ServiceInfoBadge

/rtm


Prow job to push the image docker-ce-build

Prow job to push the image docker-ce-build to https://quay.io/repository/powercloud/docker-ce-build when there is a change detected in the directory images/docker-in-docker

/retest

@florencepascual after our discussion in yesterday's call, were you able to conclude if the x86 image was required?

@florencepascual after our discussion in yesterday's call, were you able to conclude if the x86 image was required?

Sorry I did not see your comment earlier. We have reached the conclusion that we would like to keep it as a multi-arch image.


i18n: correct zh-cn translation

Correct some mistakes in lib/zh-cn/diagnosticMessages.generated.json,  here is the detail of these changes:

Incositent with English version.  ex. current translation of A_const_assertions_can_only_be_applied_to_references_to_enum_members_or_string_number_boolean_array__1355 means A 'const' assertion can only be used to refer to enumeration members, strings, numbers, booleans, arrays, or object literals.
Correct inappropriate wording, ex. literal should be translated to 字面量, currently it has been translated to 文本, 文字, which may lead confusing with string.
Correct grammar error. ex. 对象字面量可以只指定已知属性 should be  对象字面量只可以指定已知属性
Correct use of capitalization, ex.  bigint should be BigInt
Improve consistency of translation.
Keywords should not be translated for better understanding. Some of them have been fixed in #46924, but still some are remained. ex. require() , super call should be super()调用(currently 超级调用)

I'm also slightly confused by the translation workflow on this repo—I hope this is editing the right file.

@csigs @pdostalek can you find a way to upstream these changes?

I finally learned how to refer these changes to Microsoft's internal localisation team. Hopefully they can review them and merge them into the src/loc/lcl/chs files.
For my reference, the two issues are
https://ceapex.visualstudio.com/CEINTL/_workitems/edit/686215
https://ceapex.visualstudio.com/CEINTL/_workitems/edit/685780

The two internal issues were resolved on 18 and 22 August, so I am going to close this PR.


Fix OUTPUT variable check + document that gen_npm3 needs to be run.

Fixes #50

Great! thanks :smile:


No search bar in 0.22.0 or 0.22.1

Updated to the most recent version yesterday, and I wasn't able to use it because I don't see a search bar and I don't see any option to enable it. Testing old versions, it looks like the problem arose in in 0.22.0 as 0.21.5 is working fine.
I'm on Windows 10 Home (64 bits). Not sure what else would be helpful for debugging. Here is a screenshot of what I am seeing in 0.22.1.

Here is what I am seeing in 0.21.5

0.22.x is an experimental version with ctrl-p (or ctrl-f) to show the search pane.

Thank you for the information, and I appreciate that the new builds have this info added. Issue is resolved, so I will be closing this now.

No worries, please let me know if there are issues with it or ways you think it could be better!


Doc to assist Launchdarkly feature flag migration using in-console tool.

🚀 Deployed on https://667b098be1887148a6b7a388--cozy-fox-0defec.netlify.app


cyclists don't use highway=path

It seems that cyclists in a/b street don't use highway=path with bicycle=designated but drive on the carriageway instead. This makes the traffic simulation unrealistic in my city as almost all cycle ways are mapped that way as they are shared with (but segregated from) footways.

Sadly a known limitation right now. :(  highway=path was recently imported in https://github.com/a-b-street/abstreet/pull/994, and the "Behavioral changes" section has notes about what supporting in the simulation layer would take. Also note #996 -- I'm prioritizing work on things like osm2streets right now for the foreseeable future. If you're interested in working on this kind of thing, let me know!


Exception Thrown After File Upload Completes

FTP Server OS: Windows
FTP Server Type:
Client Computer OS: Windows
FluentFTP Version: 49.0.2
Framework: .NET 4.7.2
I am new to FluentFTP. I am running a sample console app doing an async upload. When the upload completes, I see an exception:
Here is my debug output:
Test Started
0.249809715255957
0.499619430511915
.
.
.
99.674076387127
99.923886102383
100
100
Success
**Exception thrown: 'System.InvalidCastException' in FluentFTP.dll**
The program '[15164] MyTest.exe' has exited with code 0 (0x0).

Logs :

<paste VERBOSE logs here>

Thanks for reporting this. See #1461. Perhaps if you explicitly client.Disconnect() prior to disposing the client, you won't see this exception. But without seeing your source code, I cannot say.
The current master of FluentFtp on GitHub should already fix this.


Removed unsupported third-party backends from docs.

Follow up to #12948
These are all looking unmaintained:

https://pypi.org/project/ibm_db_django/#history
https://pypi.org/project/django-firebird/#history
https://pypi.org/project/django-pyodbc/#history

They don't support the latest versions and there is no significant activity on the repos. If they come to life it's easy enough to re-add.

I still believe that django-firebird will release a new version, see https://github.com/maxirobaina/django-firebird/commit/82f637ce83038837ff2a65b758702462a485a5e9.
ibm_db_django promised to support Django 3.0 by the end of the year https://github.com/ibmdb/python-ibmdb-django/issues/49 :shrug:

Django-Firebird : The stable version corresponds with django 2.2 and live into stable/2.2.x branch. The current master branch of this repository is being developed under django 3.0.x. (pre alpha) d66ff96
https://github.com/maxirobaina/django-firebird/commit/d66ff96353cf8cfc5a9e5c0861947abb55c9b680

Also 2.2 alpha package is published to pypi https://pypi.org/project/django-firebird/2.2a1/

Super, thanks for the confirmation @mariuz 👍

Re-added Firebird. ibm_db_django may possibly recover but 3.0 (the docs for which we'd backport this change to) isn't supported.


How to Configure tables (Single navigation property)

I read document in
https://efcorecassandra.readthedocs.io/en/latest/intro/getting-started-with-efcorecassandra.html#configure-tables
Then example in Document I found this
modelBuilder.Entity<Applicant>()   .ToTable("applicants", "cv")   .HasKey(p => new { p.Id, p.LastName }); modelBuilder.Entity<Applicant>()   .ForCassandraSetClusterColumns(s => new { s.LastName });
I want to Design Model  type Single navigation property like this
public class Blog
{
public int BlogId { get; set; }
public string Url { get; set; }
public List<Post> Posts { get; set; }

}
public class Post
{
public int PostId { get; set; }
public string Title { get; set; }
public string Content { get; set; }
}
this referrance
https://docs.microsoft.com/en-us/ef/core/modeling/relationships?tabs=fluent-api%2Cfluent-api-simple-key%2Csimple-key
How to Configure tables Just like this  in EFCore.Cassandra v 2.0.3

Hi,
In cassandra you cannot define foreign key because it's not a relational database, the website https://docs.datastax.com/en/cql-oss/3.3/cql/ddl/dataModelingApproach.html explains how to model your database.
I'm going to make some modifications on the project to support "list<frozen>" & join a sample project to explain how to store a list of "post" as a list of user defined types.

The sample project has been updated in the branch "origin/release/2.0.5".
The application can have one or more phones (a phone is defined as a UDT / User Defined Type).
In the configuration, there is a new UDT:
modelBuilder.Entity<ApplicantPhone>()
.ToUserDefinedType("applicant_phone")
.HasNoKey();

A new navigation property "public ApplicantPhone[] Phones { get; set; }" has been added into the "Applicant".


Bump devise-security to 0.17.0

Coverage decreased (-1.9%) to 96.03% when pulling b4ec2b0acc0a82737c68a5d0af7686260bf40514 on dillonwelch:update-version into 25a74c2777ec381393fb4e11a65f570836b52c6e on devise-security:master.


Improve the filtering of "Search" fields

Topic
The QA team members asked us to improve the filter actions provided by "Search" fields present into the html report.
In the specific, they wanted to filter the failures test cases using the values prensent inside each column of the report section.
For example the image below show you the scenario failures for a specific execution and using th search field, the QA would want to filter using the name of the colulmn (feature, scenario, started) and some combinations.
e.g. They suggested us to adopt the same solution used on Jira Atlassian in order to filter its components :
feature ~ "NRT light" AND scenario not in ("GN-031", "GN-034")
based on this example, the result should display only the line that have a GN code different from 031 and 034 and releted to feature fils "NRT light"

Interesting idea. However, this also sounds like something that could be achieved with tags as well. Also you can click on the feature to open the page that lists all scenarios in this feature and then use the search box.
I will keep this feature in mind for a future iteration.

The table component that is used for Cluecumber does not support using a custom search DSL.


MudTable table state is empty after publishing when using ServerData

Bug type
Component
Component name
MudTable
What happened?
When using the ServerData parameter on MudTable locally the table works as it should, however after publishing the app the table state is empty and results in no data being returned from the API.
Expected behavior
When the app is published the state of MudTable should be returned in the ServerData function, so that the state of the table can be used to paginate and sort data.
Reproduction link
https://github.com/brycehewett/mudblazor-tablebug
Reproduction steps

Setup the MudTable using the ServerData parameter:

<MudTable T="WeatherForecast"
          ServerData="@(new Func<TableState, Task<TableData<WeatherForecast>>>(ServerReload))"
          Hover="true"
          SortLabel="Sort By"
          Elevation="0">
    <HeaderContent>
        <MudTh><MudTableSortLabel SortLabel="date" T="WeatherForecast">Date</MudTableSortLabel></MudTh>
        <MudTh><MudTableSortLabel SortLabel="tempc" T="WeatherForecast">Temp. (C)</MudTableSortLabel></MudTh>
        <MudTh><MudTableSortLabel SortLabel="tempf" T="WeatherForecast">Temp. (F)</MudTableSortLabel></MudTh>
        <MudTh><MudTableSortLabel SortLabel="summary" T="WeatherForecast">Summary</MudTableSortLabel></MudTh>
    </HeaderContent>
    <RowTemplate>
        <MudTd<EMAIL_ADDRESS>        <MudTd DataLabel="Temp<EMAIL_ADDRESS>        <MudTd DataLabel="Temp<EMAIL_ADDRESS>        <MudTd<EMAIL_ADDRESS>    </RowTemplate>
    <PagerContent>
        <MudTablePager PageSizeOptions="new int[]{50, 100}" />
    </PagerContent>
</MudTable>

@code {
    private async Task<TableData<WeatherForecast>> ServerReload(TableState state)
    {
        var res = await Http.PostAsJsonAsync<TableState>("WeatherForecast", state);
        return await res.Content.ReadFromJsonAsync<TableData<WeatherForecast>>();
    }
}

Setup the api to return the related data:

[HttpPost]
public IActionResult GetForecasts(TableState state)
{
    var rng = new Random();
    var data = Enumerable.Range(1, 25).Select(index => new WeatherForecast
    {
        Date = DateTime.Now.AddDays(index),
        TemperatureC = rng.Next(-20, 55),
        Summary = Summaries[rng.Next(Summaries.Length)]
    });

    switch (state.SortLabel)
    {
        case "tempc":
            data = data.OrderByDirection(state.SortDirection, o => o.TemperatureC);
            break;
        case "tempf":
            data = data.OrderByDirection(state.SortDirection, o => o.TemperatureF);
            break;
        case "summary":
            data = data.OrderByDirection(state.SortDirection, o => o.Summary);
            break;
        default:
            data = data.OrderByDirection(state.SortDirection, o => o.Date);
            break;
    }

    return Ok(new TableData<WeatherForecast>() {
        TotalItems = data.Count(),
        Items = data.Skip(state.Page * state.PageSize).Take(state.PageSize)
    });
}

Publish the application
Load table and try sorting or using the table pager

Application Before Publish

Published Application

Relevant log output
No response
Version (bug)
6.0.11
Version (working)
6.0.10
What browsers are you seeing the problem on?
Firefox, Chrome
On what operating system are you experiencing the issue?
Windows, Mac OSX
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

After looking into this some more, I've narrowed this down to a change between 6.0.10 and 6.0.11. Also I'm able to work around this issue by setting false which makes me thinking this is related to the trimming changes in 6.0.11, however I have no idea how to fix it.

I was able to work around this by adding a trimmer config to my project. If anyone else runs into this issue, this solution worked for me.

Add the following to the client project
<ItemGroup><TrimmerRootDescriptor Include="TrimmerConfig.xml" /></ItemGroup>
Add the following to TrimmerConfig.xml in the client project root directory
<linker><assembly fullname="MudBlazor"><type fullname="MudBlazor.TableState"></type></assembly></linker>


Upgrade to core 6.0.18

The SwiftLint failure is unrelated to this and is due to a new check added.


Steam 'n' Rails 1.4 switches compat

Display locations of switch blocks and their current states on the map as a separate layer.

I think it will be better if the state of switch blocks can control in the web page.


understand committee disagreement

Use Gaussian mixture models to cluster the predictions of the committee.

Need to fix up the visualising a bit, but looks like a disagreeing committee behave like the crowd!

It is good that your committee behaves like the crowd.


Extra Credit Point - Drone Moving

Conversation:
As a shop owner, I would like to know where the drones are so I know when they will return and be ready for the next order.
Conversation:
Let's explore different map UI APIs for react
Confirmation:
A map with drone overlays is visible on the employee page.

Its for the owner of the shop, not the map tracking for the customer

Optionally, you may choose to implement a map to show where the drones are, and how they are moving to deliveries. If you choose to implement this, you will receive 10 extra credit points.

Invole in getting the drones information and making that movement on the map

Completed in #67


Docklet starts, but seems to return control to R before IP info is complete

Session Info:
 devtools::session_info()
Session info --------------------------------------------------------------------------------
 setting  value
 version  R version 3.4.4 (2018-03-15)
 system   x86_64, darwin15.6.0
 ui       RStudio (1.2.830)
 language (EN)
 collate  en_US.UTF-8
 tz       America/New_York
 date     2018-08-12

Packages ------------------------------------------------------------------------------------
 package       * version    date       source
 analogsea     * <IP_ADDRESS>10 2018-08-10 Github (sckott/analogsea@8f1f569)

Hey Scott (and others!) great project in Analogsea! I'm running into a couple of little snags, however. When I fire up a DO droplet it seems that the API passes control back to R before an IP is ready or somehow the IP doesn't get passed. So I get the following:
> remote_computer <- docklet_create(region = "sfo2", size = "1gb")
Using default ssh keys: id_rsa.pub
NB: This costs $0.01488 / hour until you droplet_delete() it
Waiting for create .........................
> print (remote_computer$networks$v4[[1]]$ip_address)
Error in remote_computer$networks$v4[[1]] : subscript out of bounds
> print(remote_computer)
<droplet>SweatingOasis (105782768)
  IP:        droplet likely not up yet
  Status:    new
  Region:    San Francisco 2
  Image:     Docker 17.03.0-ce on 14.04
  Size:      1gb
  Volumes:

So analogsea did not receive an IP back... but if I go to my DO dashboard I can see that SweatingOasis is up and running with an IP:

So my questions are two fold:

Any ideas on why analogsea is not getting the IP?
Given that analogsea knows the name of the instance, but not the IP is there a command that will 'refresh' a node instance and ask the API for the missing info? Right now the only thing I know to do is to kill the droplet, restart the R process, and hope it works.

As a side note, I reproduced this behavior from a Ubuntu box as well as my Mac laptop. I don't get an incomplete load every time I try to connect, but more than 20% of the time.
Thanks!

thx for your question! and for using analogsea 🌊
This is a known issue (E.g., https://github.com/sckott/analogsea/issues/113) - not sure why it happens exactly, but could be due to the last ping to the DO API saying that the droplet is up but somehow it's not true. OR because port 22 is not open yet (we have a check for this now).
The fix I do is just to run the output of docklet_create through droplet() like
d <- docklet_create(region = "sfo2", size = "1gb")
d <- droplet(d$id)

then the d object should have the IP address.

@CerebralMastication let me know if that works or does not work

@sckott  sorry for the slow response. The droplet(d$id) approach seems to work for me. Thanks.

@CerebralMastication glad that works.
I'll see if we need to add this tidbit to the docs ...


Powershell plugin does not support accented characters

The Powershell plugin does not support accented characters. Here is an example, with a code modification to better see the problem :

Here the code, if you want to use it to fix the issue :
def enqueue_stream(stream, queue, type):
for line in iter(stream.readline, b''):
try:
decoded_line = line.decode('utf-8').rstrip('\r\n')
queue.put(str(type) + decoded_line)
except UnicodeDecodeError as e:
print(f"Erreur de décodage : {e}")
decoded_line = line.decode('utf-8', errors='ignore').rstrip('\r\n')
queue.put(str(type) + decoded_line)


behat github actions format

first, let me thank you for this great tool - we love writing tests in gherkin and run it with behat <3.
back to topic: we run our behat test-suite within a github action.
when the test fail errors are printed into the github action logs, like they are printed when running themn locally.
it would be a great timesaver if behat would support github action annotations, so the test errors will be rendered into the 'Files changed' tab of a pull request on GitHub.
this feature can be achieved in 2 ways:
a) implement the github annotation format directly in behat
b) implement the "checkstyle" error reporting format - which is kind of standard for code error reporting tools - and propose the use of cs2pr which converts the checkstyle-format into the github annotation format
no matter which route would be chosen, it leads to a new format option on the cli.
what do you guys think? would you be open for a PR?
I am willing to provide a PR, no matter which direction you like more

I'd like this functionality for sure
I'm not sure where the logs would be targetted, is my only question - on the failing step, or on the failing step definition?


dependabot: npm audit fix

Description
For: https://github.com/dust-tt/dust/security/dependabot
Risk
N/A
Deploy Plan

deploy front

PMRR


Use gosu postgres when writing to hba.cnf so that drop-cap dac_override works

fixes #208.

Nice, the rest of this script was already using gosu postgres everywhere it interacted with PGDATA! :+1:
LGTM


Commit automatic sln changes

Description

Commiting the automatic changes Visual Studio keeps doing to the sln files.
Motivation and Context

Should fix #2168
How Has This Been Tested?

Build solutions, ran some tests.
Screenshots (if appropriate):

/azp run

Closing this as #2191 will commit the same changes.


Datasources "include" cleanup - rewriting the grab() function

Right now datasources use a very strange include to do all the hard work.
By itself this is no problem, but because the code included is not split into functions each doing its own thing, it is very hard to build upon. For example, while building the Newsletter plugin I wanted a datasource that grabs filtered, paginated entries from a section, and return it in array format (so, basically it is a standard datasource with a different output). With the current approach, this is not possible without rewriting or copying a lot of the existing code.
In my eyes, there are two ways we can solve this. The first approach (this gets my vote) is to create a class for each datasource type (datasource.author.php, datasource.dynamic_xml.php, etc). If these classes split up the logic in the grab function into seperate functions (getWhere, getJoins, getCount, parseAsXml, etc) it would be a lot easier to build on the existing code.
The second method (which might be easier to code, but is still messy) is to keep the same include logic in the datasources itself, but to rewrite the include files to have seperate functions for each part of the logic.
This feels especially useful, since we are talking about supporting JSON and other formats.

No news at the moment, getting the datasource.*.php as separate classes is definitely still a goal.
I am feeling the best approach to this is Datasources as Extensions.
I think some work in #777 will make 'extending' datasources easier, but it's still not as clean as a Datasource extensions.

Take a look at the providers branch too. That branch makes datasources extensions so I'm guessing we can combine our efforts :)

I'm really excited about this, as it allows me to continue my unhealthy fascination of geographical hierarchies, and create a Datasource API for a great geographical API.
Teh awesomes.
I will get on this ASAP @brendo and post any suggestions from a 'datasource developer's' perspective.

Please do. The documentation will need further fleshing out I feel.
Depending on the #757 work, the buildEditor function may become less confusing :)


Question about release

Hi, first of all congrats for brave project. I was waiting a long time, that someone will take on annotator development. Is there any chance that you will release this as minified javascript file? Because I have just a bunch of errors when I try to build it. Thank you again!

Yes will release a minified js file soon. Could you share some of the errors you are getting so we can address them in case someone is also facing the same

I have added the minified version. It is available in the pkg/ directory


[tensorflow-cc] add support for x64-uwp

Feature request: add support for the x64-uwp triplet to the 2.x tensorflow-cc port.
The expected benefit is to be able to use TF, at least for inference, on Store apps.
It looks like this is realistically feasible (see PR #13028). The resulting TF library may not support all features, though (e.g. those relying on file system access).

I'm looking myself into this. There are no major issues with the code itself that prevent it from running under WinRT, and the missing features won't be showstoppers. I can already share a list of impacted code files and the possible workarounds.
However, the challenge is that some external dependencies (protoc.exe, grpc_cpp_plugin.exe, nasm.exe, def_file_filter.exe), which are a byproduct of the TF build process, are used during the build process itself. This means that these dependencies shouldn't target uwp, but the host config (say x64). .
What I don't know, though, is whether some of the objects built as part of these dependencies are also linked into the final output. If so, we'd have to find a way around this issue. If not, we need to figure out how to pass the right build switches only to the final output (tensorflow_cc.dll) and not the external deps.

What I don't know, though, is whether some of the objects built as part of these dependencies are also linked into the final output.

They are, but luckily the TF build framework already addresses this issue. The switch --distinct_host_configuration does exactly what we want (see https://docs.bazel.build/versions/master/guide.html). Setting it to true allows us to use different configs for the compiler and linker, via --host_copt and --host_linkopt when building the tools that are used in the build process itself. Note that the default value for --distinct_host_configuration is true, but TF sets it to false for Windows builds in the .bazelrc config file, as it assumes that there’s never a need for cross-compilation on Windows.
Now, regarding the source code. As mentioned in #13028, we have to compile with -DWINAPI_FAMILY=WINAPI_FAMILY_APP and -D_WIN32_WINNT=0x0A00, and link with /APPCONTAINER.
It’s worth noting that a couple of TF dependencies already support UWP. So, if we assume that these dependencies are used only to build the main library and not the build tools themselves, we can just configure them, specifically:
SQLite (.bzl_bazel_devtools\ozkcue5a\execroot\org_tensorflow\external\org_sqlite): in BUILD.bazel, set "-DSQLITE_OS_WINRT=1"
CURL (.bzl_bazel_devtools\ozkcue5a\execroot\org_tensorflow\external\curl): in BUILD.bazel, remove the #defines USE_WINDOWS_SSPI and USE_SCHANNEL
ICU (.bzl_bazel_devtools\ozkcue5a\execroot\org_tensorflow\external\icu): in BUILD.bazel, set "-DU_PLATFORM_HAS_WINUWP_API=1" (however, file udata.cpp also has to be patched to avoid the call to setCommonICUDataPointer when U_PLATFORM_HAS_WINUWP_API is defined; this is a bug in ICU)
That’s all for the projects that support UWP, so these will build just fine.
Regarding the rest of the code:
std::getenv isn’t available on UWP and TF uses it in many places. We could just create a function with the same signature that returns nullptr and put it in an include file somewhere. Similarly, no-op versions of the many unsupported Windows functions could be also implemented.
So, eventually it all builds, but I’m nowhere near a final solution: the final DLL is linked against the desktop CRT, not the WinRT one, so I guess I’ll have to build with the /ZW switch or find another solution. More importantly, my main use case fails when loading a frozen graph from memory.
I’ll continue to play with this as I want a UWP TF port so badly. However, given the extent of the patches to be applied, I recognize this would be much better addressed by the upstream project(s) than by vcpkg.

I recognize this would be much better addressed by the upstream project(s) than by vcpkg.

So I also opened an issue in the TF repository.

More importantly, my main use case fails when loading a frozen graph from memory.
This was just a silly config bug, not an actual issue. The resulting DLL works fine with my test model.

Here's a summary of my current approach:

Modify the three BUILD.bazel configs as explained above (including patching udata.cpp).
Compile with -DWINAPI_FAMILY=WINAPI_FAMILY_APP and -D_WIN32_WINNT=0x0A00, and link with /APPCONTAINER and WindowsApp.lib. I added all these options to the .bazelrc config file during development, and of course set --distinct_host_configuration=true
Redirect windows.h to a header file that implements the missing UWP bits as no-op.
Patch \execroot\org_tensorflow\external\aws\aws-cpp-sdk-core\source\platform\windows\FileSystem.cpp to include the redirected windows.h
Redirect cstdlib to a header file that implements std::getenv() by always returning nullptr.

During development, to redirect the headers I modified the actual header files in VC++/Windows SDK on a dev PC. @jgehw : Can you suggest a clean solution to achieve something similar from within vcpkg or bazel, just for building TF? There are way too many files impacted (including external TF deps) to patch them one by one.
The only remaining issue at the moment is the linkage with the desktop CRT (i.e. it should use the libs at VC\Tools\MSVC\14.27.29110\lib\x64\store instead of the ones at VC\Tools\MSVC\14.27.29110\lib\x64). I tried changing the LIB environment variable but unfortunately it didn't help.

The only remaining issue at the moment is the linkage with the desktop CRT

I finally solved this by setting the /LIBPATH linker command-line switch to point to the 'store' version of the CRT libs. Now I have a UWP-compatible TF DLL, which passes the local App Cert Kit validation. My next step is to test it and, if it works, publish a real app in the Store using it.
Bazel calls VCVARSALL.BAT in windows_cc_configure.bzl to set the INCLUDE/LIB environment vars. While VCVARSALL.BAT supports specifying the environment type (e.g. VCVARSALL.BAT amd64 store), it looks like this is not foreseen in the current implementation of windows_cc_configure.bzl. Hopefully someone will look into this at https://github.com/tensorflow/tensorflow/issues/44463

During development, to redirect the headers I modified the actual header files in VC++/Windows SDK on a dev PC. @jgehw : Can you suggest a clean solution to achieve something similar from within vcpkg or bazel, just for building TF? There are way too many files impacted (including external TF deps) to patch them one by one.

I think the best point to address this would be where bazel interacts with VCVARSALL.BAT. An easier dirty workaround might be using the compiler command line switches /X (to ignore the default include path) and /I (to add an include path with a patched version).

My next step is to test it...

It works! I'm running the Spleeter 2 & 4-stem models for audio source separation, which are BTW pretty demanding, in a UWP app. It's worth noting that the 'Code Generation' capability needs to be checked in the app manifest.
The ultimate validation will be getting the app update published in the Store.

I think the best point to address this would be where bazel interacts with VCVARSALL.BAT

Sure it is. However, it's really difficult, as my understanding is that windows_cc_configure.bzl is part of the bazel distribution, and the changes required aren't trivial.
@jgehw :  It's been great to get my problem solved thanks to you! It would be a pity (and selfish) to stop here, though.
Based on what I've documented so far, do you believe it's feasible, or worth it, to do this in vcpkg? I will of course provide line numbers, file paths, content of the patched header files, etc.

Sure it is. However, it's really difficult, as my understanding is that windows_cc_configure.bzl is part of the bazel distribution, and the changes required aren't trivial.

Yes, patching bazel is no fun... That's why I was also working with a workaround for x64-windows in the portfile until my PR in the bazel repo made it into the release.

@jgehw : It's been great to get my problem solved thanks to you! It would be a pity (and selfish) to stop here, though.
Based on what I've documented so far, do you believe it's feasible, or worth it, to do this in vcpkg? I will of course provide line numbers, file paths, content of the patched header files, etc.

If I didn't miss something, beside patching headers and passing various compile/link options, you didn't need to patch anything in the bazel distribution, just bazel files in the build tree, right? Yes, then it should be feasible to do this in vcpkg, please share.

If I didn't miss something, beside patching headers and passing various compile/link options, you didn't need to patch anything in the bazel distribution, just bazel files in the build tree, right? Yes, then it should be feasible to do this in vcpkg, please share.

Right. Here's the full process:

Out of laziness, do a 'vcpkg install tensorflow-cc:x64-windows' first and wait until done, just to get the build tree. I'm patching only the Release build, as I believe that the Debug build would be pointless under UWP.
Patch the file \vcpkg\buildtrees\tensorflow-cc\x64-windows-rel.bazelrc as follows:
Replace the line 'build:windows --distinct_host_configuration=false' (line 321) by the following block (the VC and SDK versions will need to be replaced with the actual ones):
build:windows --distinct_host_configuration=true
build:windows --copt=-DWINAPI_FAMILY=WINAPI_FAMILY_APP
build:windows --copt=-D_WIN32_WINNT=0x0A00
build:windows --linkopt=/APPCONTAINER
build:windows --linkopt=WindowsApp.lib
build:windows --linkopt=""/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\lib\x64\store""
build:windows --linkopt=""/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.18362.0\um\x64""
build:windows --linkopt=/FORCE:MULTIPLE
build:windows --host_copt=-UWINAPI_FAMILY
build:windows --host_linkopt=/APPCONTAINER:NO
Patch the file \vcpkg\buildtrees.bzl_bazel_currentuser\hash\execroot\org_tensorflow\external\org_sqlite\BUILD.bazel by adding in line 16 the following, including the quotes and the comma (note the user name and hash in my file path corresponding to the Release build tree):
"-DSQLITE_OS_WINRT=1",
Patch the file \vcpkg\buildtrees.bzl_bazel_currentuser\hash\execroot\org_tensorflow\external\curl\BUILD.bazel to remove or comment out lines 475 & 477 ("#define USE_WINDOWS_SSPI 1" and "#define USE_SCHANNEL 1").
Patch the file \vcpkg\buildtrees.bzl_bazel_currentuser\hash\execroot\org_tensorflow\external\icu\BUILD.bazel by adding in line 47 the following:
"-DU_PLATFORM_HAS_WINUWP_API=1",
Patch the file \vcpkg\buildtrees.bzl_bazel_currentuser\hash\execroot\org_tensorflow\external\icu\icu4c\source\common\udata.cpp by moving the end of the comment from line 711 to line 715 (i.e. to comment out the call to setCommonICUDataPointer)
Patch the file \vcpkg\buildtrees.bzl_bazel_currentuser\hash\execroot\org_tensorflow\external\aws\aws-cpp-sdk-core\source\platform\windows\FileSystem.cpp to include <windows.h> somewhere (e.g. line 23)
Find a way to force the build to use the attached windows.h (which references uwppatch.h) and cstdlib instead of the default ones.

That's all. Now rebuilding the Release build using the bash script you provided at https://github.com/microsoft/vcpkg/pull/13028#issuecomment-716717755 yields a uwp-ready tensorflow-cc.dll.
@jgehw : Sounds feasible?

@jgehw : Sounds feasible?

Thanks for the details. Directly patching files being present after extracting or configuring is straight-forward. Some files of the external dependencies will only be created during the bazel build process; beside a really ugly hack (run bazel twice, patch in between), patching bazel scripts to apply patches during the bazel process, is a bit more complicated but still sounds feasible with passable effort. There is a bit of uncertainty yet concerning the patched version of windows.h: either my /X /I idea works, then it's straight forward; otherwise we'll have some fun here... We'll see.

The ultimate validation will be getting the app update published in the Store.

Validated! The app release is now in the Store. I also wrote a short blog post about the feature (the app isn't free, but has a fully-functional trial).
@jgehw : A stretch goal could be to get the UWP DLL to compile for ARM64 too. I have hardware to test it on.

I implemented the patches you described. As I'm probably missing some UWP tools on my machine (detect-compiler for UWP fails), I just created a work-in-progress PR to see what happens on CI.

@jgehw : A stretch goal could be to get the UWP DLL to compile for ARM64 too. I have hardware to test it on.

Looking at https://github.com/bazelbuild/bazel/releases there doesn't seem to be ARM support for Windows, only Linux...

Looking at https://github.com/bazelbuild/bazel/releases there doesn't seem to be ARM support for Windows, only Linux...

@jgehw : I meant cross-compiling to ARM64 target on an x64 host, now that we have set --distinct_host_configuration=true. All this would be better addressed in bazel itself, though, so at some point I'll raise the question there (i.e. support for ARM64 as an architecture on Windows and UWP as a platform).

cross-compiling to ARM64 target on an x64 host

@jgehw: I gave it a try and found out that they assume pretty much all over the TF .bzl files that the only possible target on Windows is x64. However, Bazel does support ARM64 as a compilation target through '--cpu=x64_arm64_windows', so I opened https://github.com/tensorflow/tensorflow/issues/45151 for this purpose.


cluster.local cert is not renewing on Istio VM

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I am running Istio VM which is able to connect with Istiod and generates certificate for cluster.local of 1 day expiry. Once the certificate is expired, they are not auto renewed and I have to manually replace the root-ca certificate to get new certificate for cluster.local. When I'm running it with expired certificate, envoy is able to serve traffic until there is change in cluster endpoints IPs, even though the logs says using token instead it seems like the config is not updated by istiod.
Istio logs are showing following logs:
2023-09-11T07:24:37.597659Z     info    xdsproxy        connected to upstream XDS server: istiod-1-16-1.istio-system.svc:15012
2023-09-11T07:24:37.602596Z     warn    xdsproxy        upstream [11531] terminated with unexpected error rpc error: code = Unauthenticated desc = authentication failure
2023-09-11T07:24:38.388719Z     warn    cert expired, using token instead

Version
$ istioctl version
client version: 1.13.1
control plane version: 1.16.1
data plane version: 1.16.1 (265 proxies)

$ kubectl version --short
Client Version: v1.24.16
Kustomize Version: v4.5.4
Server Version: v1.24.14-gke.1200

Additional Information
I am running the envoyproxy in router mode.
mesh values:
defaultConfig:
  discoveryAddress: istiod-1-16-1.istio-system.svc:15012
  meshId: dummy
  proxyMetadata:
    CANONICAL_REVISION: latest
    CANONICAL_SERVICE: envoy
    ISTIO_META_AUTO_REGISTER_GROUP: envoy
    ISTIO_META_CLUSTER_ID: dummy
    ISTIO_META_DNS_CAPTURE: "true"
    ISTIO_META_MESH_ID: dummy
    ISTIO_META_NETWORK: ""
    ISTIO_META_WORKLOAD_NAME: envoy
    ISTIO_METAJSON_LABELS: '{"app":"envoy","service.istio.io/canonical-name":"envoy","service.istio.io/canonical-revision":"latest"}'
    POD_NAMESPACE: envoy
    SERVICE_ACCOUNT: envoy
    TRUST_DOMAIN: cluster.local
  tracing:
    zipkin:
      address: zipkin.istio-system:9411

cluster.env values:
CANONICAL_REVISION='latest'
CANONICAL_SERVICE='envoy'
CA_ADDR='istiod-1-16-1.istio-system.svc:15012'
ISTIO_INBOUND_PORTS='*'
ISTIO_LOCAL_EXCLUDE_PORTS='22,15090,15021,15020'
ISTIO_METAJSON_LABELS='{"app":"envoy","service.istio.io/canonical-name":"envoy","service.istio.io/canonical-revision":"latest"}'
ISTIO_META_AUTO_REGISTER_GROUP='envoy'
ISTIO_META_CLUSTER_ID='dummy'
ISTIO_META_DNS_CAPTURE='true'
ISTIO_META_MESH_ID='dummy'
ISTIO_META_NETWORK=''
ISTIO_META_WORKLOAD_NAME='envoy'
ISTIO_NAMESPACE='envoy'
ISTIO_SERVICE='envoy.envoy'
ISTIO_SERVICE_CIDR='*'
POD_NAMESPACE='envoy'
SERVICE_ACCOUNT='envoy'
TRUST_DOMAIN='cluster.local'
ISTIO_AGENT_FLAGS='router'
ISTIO_CUSTOM_IP_TABLES='true'

How do you provide the cert xd-proxy use for tls connect

The doc https://istio.io/latest/docs/setup/install/virtual-machine/ guided using istio token

I also copied the istio-token as per the documentation and after certificate expiry istio is logging cert expired, using token instead and yet the traffic was being routed to endpoints which were stale. And I'm not able to list the vm in workloadentry.

Sorry by the certificate expiry, can you be more accurate which cert do you mean?

It is the cert for cluster.local  which is default for pointing to istiod.istio-system.svc.cluster.local
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            6e:e6:30:33:aa:42:07:0b:a1:b5:dd:b6:a1:77:95:54
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: O = cluster.local
        Validity
            Not Before: Sep 11 12:01:14 2023 GMT
            Not After : Sep 12 12:03:14 2023 GMT

When I am switching to port 15010 for plain text communication with istiod. I am getting the following error:
2023-09-11T12:23:22.056632Z     info    Pilot SAN: [istiod-1-16-1.istio-system.svc]
2023-09-11T12:23:22.057882Z     info    Starting proxy agent
2023-09-11T12:23:22.057913Z     info    starting
2023-09-11T12:23:22.057932Z     info    Envoy command: [-c etc/istio/proxy/envoy-rev.json --drain-time-s 45 --drain-strategy immediate --local-address-ip-version v4 --file-flush-interval-msec 1000 --disable-hot-restart --allow-unknown-static-fields --log
-format %Y-%m-%dT%T.%fZ   %l      envoy %n %g:%#  %v      thread=%t -l warning --component-log-level misc:error]
2023-09-11T12:23:22.201296Z     error   citadelclient   recreated connection
2023-09-11T12:23:22.214559Z     warn    ca      ca request failed, starting attempt 1 in 103.529595ms
2023-09-11T12:23:22.318975Z     warn    ca      ca request failed, starting attempt 2 in 206.605231ms
2023-09-11T12:23:22.525876Z     warn    ca      ca request failed, starting attempt 3 in 376.376ms
2023-09-11T12:23:22.902669Z     warn    ca      ca request failed, starting attempt 4 in 776.83171ms
2023-09-11T12:23:23.698473Z     warn    sds     failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp: lookup istio
d.istio-system.svc on <IP_ADDRESS>:53: no such host"

I have added ENABLE_CA_SERVER='false' and pointing to port 15010, yet it is failing. Can you please help me get it working?

 failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp: lookup istio d.istio-system.svc on <IP_ADDRESS>:53: no such host"
In the VM, istio d.istio-system.svc can not be resolvable, have you enabled DNS resolve for it

So this error comes when I just switch the port to from 15012 to 15010 and set enableAutoMtls: false
When I am using port 15012, it is able to resolve. And yes I have entry in /etc/hosts for resolving istiod-1-16-1.istio-system.svc

oh but after port changes it is trying to resolving to d.istiod.istio-system.svc, while I have used revision 1-16-1 everywhere.

Mesh config for non mtls:
enableAutoMtls: false
defaultConfig:
  discoveryAddress: istiod-1-16-1.istio-system.svc:15010
  meshId: programmatic-apac
  proxyStatsMatcher:
    inclusionRegexps:
      - .*upstream_rq_total
      - .*upstream_rq_timeout
      - .*upstream_rq_rx_reset
      - .*upstream_rq_tx_reset
      - .*downstream_rq_.*xx
      - .*downstream_rq_http.*_total
    inclusionSuffixes:
      - downstream_rq_total
      - downstream_rq_completed
      - upstream_rq_total
      - downstream_rq_timeout
  proxyMetadata:
    CANONICAL_REVISION: latest
    CANONICAL_SERVICE: envoy
    ISTIO_META_AUTO_REGISTER_GROUP: envoy
    ISTIO_META_CLUSTER_ID: mowx-ase1b-c1
    ISTIO_META_DNS_CAPTURE: "true"
    ISTIO_META_MESH_ID: programmatic-apac
    ISTIO_META_NETWORK: ""
    ISTIO_META_WORKLOAD_NAME: envoy
    ISTIO_METAJSON_LABELS: '{"app":"envoy","service.istio.io/canonical-name":"envoy","service.istio.io/canonical-revision":"latest"}'
    POD_NAMESPACE: envoy
    SERVICE_ACCOUNT: envoy
    TRUST_DOMAIN: cluster.local
  tracing:
    zipkin:
      address: zipkin.istio-system:9411

I added entry in /etc/hosts for istiod.istio-system.svc but now I am getting different error in istio.log file
2023-09-11T12:43:45.251697Z     info    Pilot SAN: [istiod-1-16-1.istio-system.svc]
2023-09-11T12:43:45.252785Z     info    Starting proxy agent
2023-09-11T12:43:45.252819Z     info    starting
2023-09-11T12:43:45.252838Z     info    Envoy command: [-c etc/istio/proxy/envoy-rev.json --drain-time-s 45 --drain-strategy immediate --local-address-ip-version v4 --file-flush-interval-msec 1000 --disable-hot-restart --allow-unknown-static-fields --log
-format %Y-%m-%dT%T.%fZ   %l      envoy %n %g:%#  %v      thread=%t -l warning --component-log-level misc:error]
2023-09-11T12:43:45.387256Z     info    cache   generated new workload certificate      latency=145.319593ms ttl=23h59m59.612754838s
2023-09-11T12:43:45.387298Z     info    cache   Root cert has changed, start rotating root cert
2023-09-11T12:43:45.387315Z     info    ads     XDS: Incremental Pushing:0 ConnectedEndpoints:0 Version:
2023-09-11T12:43:45.387747Z     info    cache   returned workload trust anchor from cache       ttl=23h59m59.61225862s
2023-09-11T12:44:00.123387Z     error   failed scraping envoy metrics: error scraping http://localhost:15090/stats/prometheus: Get "http://localhost:15090/stats/prometheus": dial tcp [::1]:15090: connect: connection refused
2023-09-11T12:45:00.103689Z     error   failed scraping envoy metrics: error scraping http://localhost:15090/stats/prometheus: Get "http://localhost:15090/stats/prometheus": dial tcp [::1]:15090: connect: connection refused
2023-09-11T12:46:00.104215Z     error   failed scraping envoy metrics: error scraping http://localhost:15090/stats/prometheus: Get "http://localhost:15090/stats/prometheus": dial tcp [::1]:15090: connect: connection refused

I am not sure why 15090 is not up, could check if envoy is running

You want OUTPUT_CERTS.

I am not sure why 15090 is not up, could check if envoy is running

On further investigation, we found out that CPU utilization is spiking to 100% for all envoy threads due to which linux is unable to cleanup old sockets or allocate new sockets. The serving comes backup once CPU free up almost after 5 min.
We have increase max FD limit 900,000 but no improvements.
I also disabled access logs to remove disk choking from the picture, no improvements after that either.

I am seeing some issue on similar area
cat /var/lib/istio/envoy/cluster.env;
CANONICAL_REVISION='latest'
CANONICAL_SERVICE='envoy'
CA_ADDR='istiod-1-16-1.istio-system.svc:15012'
ISTIO_INBOUND_PORTS='*'
ISTIO_LOCAL_EXCLUDE_PORTS='22,15090,15021,15020'
ISTIO_METAJSON_LABELS='{"app":"envoy","service.istio.io/canonical-name":"envoy","service.istio.io/canonical-revision":"latest"}'
ISTIO_META_AUTO_REGISTER_GROUP='envoy'
ISTIO_META_CLUSTER_ID='change_name-c1'
ISTIO_META_DNS_CAPTURE='true'
ISTIO_META_MESH_ID='change_name'
ISTIO_META_NETWORK=''
ISTIO_META_WORKLOAD_NAME='envoy'
ISTIO_NAMESPACE='envoy'
ISTIO_SERVICE='envoy.envoy'
ISTIO_SERVICE_CIDR='*'
POD_NAMESPACE='envoy'
SERVICE_ACCOUNT='envoy'
TRUST_DOMAIN='cluster.local'
ISTIO_AGENT_FLAGS='router'
ISTIO_CUSTOM_IP_TABLES='true'
SECRET_TTL='10m'

I restarted my istion service, a new certificate got generated with validity of 10 mins
sudo openssl x509 -in cert-chain.pem -text -noout
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            9b:8c:0b:56:d3:81:02:c0:c9:1b:4b:e1:81:93:61:5c
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: O = cluster.local
        Validity
            Not Before: Dec 11 13:41:24 2023 GMT
            Not After : Dec 11 13:53:24 2023 GMT
        Subject:
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                RSA Public-Key: (2048 bit)
                Modulus:
                    00:b0:73:7e:7c:da:2f:89:a0:65:45:46:00:79:8a:
                    84:26:a4:11:3c:e1:12:bb:33:01:e4:3f:07:92:8b:
                    01:53:8a:a8:95:d4:b0:a8:47:94:cf:92:cf:99:0f:
                    72:96:2b:95:3b:1b:dd:8b:a0:22:62:b1:5a:12:ad:
                    e8:42:cd:f5:9b:a6:c7:ef:62:98:55:ae:e7:ad:e5:
                    98:b3:31:04:cc:22:41:7c:af:30:c9:f8:66:26:d1:
                    49:94:02:d0:01:95:15:69:f1:4d:79:f1:2c:ee:bc:
                    51:74:a7:17:91:89:a3:68:66:55:8e:69:ff:00:54:
                    ee:91:99:9e:93:c4:3b:4a:66:bc:65:11:e3:fc:ac:
                    47:1f:c0:5f:db:fd:eb:3a:23:69:ac:1e:87:ec:ad:
                    c8:6b:2a:ec:f6:4c:95:2a:e6:2a:ec:f9:e8:c1:06:
                    6a:15:ed:5e:08:94:16:67:13:8d:54:2e:f2:a0:cf:
                    9e:20:12:ae:22:d1:9a:ba:c9:57:22:0c:76:c7:5b:
                    d0:ba:51:0b:a5:75:1b:c9:4d:6f:bc:bf:0f:ce:db:
                    2b:a1:88:63:fa:c6:4d:17:f6:3d:82:b7:02:48:de:
                    82:76:cc:f5:67:d5:11:0c:3d:3b:c7:6e:d7:a7:76:
                    2c:70:02:fa:6b:0d:bd:3a:99:1c:29:28:67:12:1c:
                    00:29
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Extended Key Usage:
                TLS Web Server Authentication, TLS Web Client Authentication
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Authority Key Identifier:
                keyid:D2:11:B7:17:7A:C2:E6:29:B3:E0:DC:7F:57:33:D9:D7:9B:E5:AE:46

            X509v3 Subject Alternative Name: critical
                URI:spiffe://cluster.local/ns/envoy/sa/envoy
    Signature Algorithm: sha256WithRSAEncryption
         5d:41:a4:36:75:ce:b5:88:b9:78:5a:43:1b:96:1a:25:51:12:
         3d:01:ed:34:e9:e7:95:b6:27:a7:62:56:95:e5:65:2b:d1:ae:
         11:df:63:ff:cc:5e:13:64:29:39:38:ba:7a:44:ef:b6:7a:de:
         41:36:0d:8b:84:94:2e:4a:77:71:89:f4:28:62:8b:c3:bf:95:
         5f:f6:1f:7d:73:95:41:e2:2c:62:cb:a8:2f:05:27:52:01:85:
         59:a4:f1:eb:e3:8d:ef:9d:2b:77:21:d1:a5:a8:0b:94:b7:cf:
         90:76:e7:95:5d:97:3d:57:f3:de:fe:33:45:40:63:2d:c4:cf:
         35:ae:9a:dd:58:67:70:47:35:ef:dc:bc:11:08:14:36:26:2c:
         f2:29:57:5b:a4:b4:5f:b8:54:3a:d8:61:27:19:6f:61:6e:0e:
         a3:3e:29:03:e6:e3:db:e7:cb:c2:f3:5b:12:1a:74:42:dc:c9:
         67:10:91:0c:9e:8c:66:2d:73:eb:00:2e:af:b0:8a:56:8d:a9:
         bc:d0:31:d8:eb:26:f1:d4:8d:d0:69:c5:20:e1:b6:ae:65:15:
         c6:1b:09:e0:bb:45:41:0c:5e:b6:6a:81:0f:25:73:01:ea:6f:
         66:aa:f5:ab:08:b4:30:b7:99:3f:42:6d:25:41:0d:e5:88:fb:
         75:43:55:19

I had an understanding that this cert will be auto-rotated , however I am not seeing this happening .
and in my istio.log I am seeing below
2023-12-11T14:12:20.039279Z	warn	cert expired, using token instead
2023-12-11T14:12:20.039924Z	info	xdsproxy	connected to upstream XDS server: istiod-1-16-1.istio-system.svc:15012
2023-12-11T14:12:20.043204Z	warn	xdsproxy	upstream [3] terminated with unexpected error rpc error: code = Unauthenticated desc = authentication failure
2023-12-11T14:12:21.011398Z	warn	cert expired, using token instead
2023-12-11T14:12:21.012802Z	info	xdsproxy	connected to upstream XDS server: istiod-1-16-1.istio-system.svc:15012
2023-12-11T14:12:21.017127Z	warn	xdsproxy	upstream [4] terminated with unexpected error rpc error: code = Unauthenticated desc = authentication failure

Is there any possible we can rotate these cert without restart the istio service ?
hzxuzhonghu
howardjohn

Also if I specify something more 90 days, see below error in logs .
2023-12-11T16:11:14.960332Z	warn	sds	failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = InvalidArgument desc = CSR signing error (requested TTL 87600h0m0s is greater than the max allowed TTL 2160h0m0s)
2023-12-11T16:11:25.881440Z	error	citadelclient	Failed to load key pair open etc/certs/cert-chain.pem: no such file or directory
2023-12-11T16:11:25.930740Z	warn	sds	failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = InvalidArgument desc = CSR signing error (requested TTL 87600h0m0s is greater than the max allowed TTL 2160h0m0s)
2023-12-11T16:11:39.253290Z	error	citadelclient	Failed to load key pair open etc/certs/cert-chain.pem: no such file or directory

currently the only way I am rotating the cert is by restarting the istio service, is there any other way we can do , Kindly Guide

At what point the cert renew is triggered? As usually, token will expire before the certificate. @howardjohn
@coder1901 You can increase the certificate duration by adding the SECRET_TTL='2160h0m0s' in cluster.env file. Max is 90 days. And it did auto renew after 90 days for me as well.

also have an issue with Istio on VM, seems that certificate is not being rotated. Any ideas why?

please show some clues like logs and tell us your istio version

Version details:
control plane version: 1.16.1
data plane version: 1.18.0 (43 proxies)
I don't have logs as of now as certs need to expire and I need to induce this scenario to get logs. will share logs asap.


Problem using the gem in docker inside WSL2

https://github.com/titusfortner/webdrivers/blob/7ef83985ee9edf16de7599db60aad0e6df7d54c0/lib/webdrivers/system.rb#L152
This test to check WSL is causing problems if the gem is used inside docker at least if the server is executed in WSL2

I am having the same issue, could we override this with an environment flag?

I am having the same issue, could we override this with an environment flag?

Closed by #196. Fix confirmed to be working by @urubatan.

Closed by #196. Fix confirmed to be working by @urubatan.


siril: 1.0.0 -> 1.0.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/siril/versions.
meta.description for siril is: "Astrophotographic image processing tool"
meta.homepage for siril is: "https://www.siril.org/"
meta.changelog for siril is: "https://gitlab.com/free-astro/siril/-/blob/HEAD/ChangeLog"
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.3 with grep in /nix/store/digb439bx8rnrzls2n7lywivww06hh74-siril-1.0.3
found 1.0.3 in filename of file in /nix/store/digb439bx8rnrzls2n7lywivww06hh74-siril-1.0.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
siril

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/digb439bx8rnrzls2n7lywivww06hh74-siril-1.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A siril https://github.com/r-ryantm/nixpkgs/archive/cb9699aa773b695ac4bd36f2ac42ae53f1f908fe.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/digb439bx8rnrzls2n7lywivww06hh74-siril-1.0.3
ls -la /nix/store/digb439bx8rnrzls2n7lywivww06hh74-siril-1.0.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

siril

Maintainer pings
cc @hjones2199 for testing.

Result of nixpkgs-review pr 184713 run on x86_64-linux 1

1 package built:

siril


fix(filt_vector): fix a problem of list index out of range in filt_vector

Description
Bug fix: filt_vector in lowpass_filter.cpp
https://github.com/autowarefoundation/autoware.universe/blob/ec99b2f2218f6b27a0f9567480df73fe1ed2aea6/control/mpc_lateral_controller/src/lowpass_filter.cpp#L113-L139
case num=3 and u.size()=4 (e.g. u={1.0, 1.0, 1.0, 1.0})
if i=2, then num_tmp=i=2. So j in {-2,-1,0,1,2}.
When j=2, then i+j=4 and u[i+j] is list index out of range.
I have fixed the above problem.
Tests performed
I added new tests to test_lowpass_filter.cpp.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thanku you for your comments.
I made my commit "signed-off".


Using Chrome device emulation with a "tablet device" (iPad, Kindle), suddenly left clicks are not performed anymore, instead it seems they are "turned into" right clicks
What is the Current behavior?
When using Chrome browser emulation with a tablet device, left click commands behave like right click commands
What is the Expected behavior?
Left clicks should be executed as left clicks, always, including when running with Chrome's device emulation mode for tablets.
What is the public URL of the test page? (attach your complete example)
https://testcafe.io/
What is your TestCafe test code?
import { Selector } from 'testcafe'

fixture`Repro`.page`${'https://testcafe.io/'}`
test('Repro', async (t) => {
  await t.click(Selector('.burger')).wait(50000)
})

Run this with e.g.: testcafe chrome:emulation:device=iPad path/to/file.js
Your complete configuration file
No response
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

Create a test file with the given code snippet
Run the with the given command-line arguments
Observe what happens on the click action

TestCafe version
3.5.0
Node.js version
20.11.1
Command-line arguments
testcafe chrome:emulation:device=iPad
Browser name(s) and version(s)
Chrome 122.0.6261.69
Platform(s) and version(s)
Ubuntu 22.04.3
Other
I assume this is probably not a Testcafe bug. But posting this just for the off-chance there is some connection to the Testcafe codebase or the case that maybe someone else runs into this issue and can point out the actual causes.

Hello @sam-yh,
I can't reproduce the issue on my machine (Chrome 122.0.6261.69 / Ubuntu 22.04 / nodeJS 20.11.1)
Maybe you can specify the details that can help us reproduce the problematic behavior.

Thanks for your reply!
I found out that it depends on this configuration file option being set to true
As soon as I comment this option out, the issue is not reproducible anymore. Can you please retry with "disableMultipleWindows": true in your .testcaferc.js?
Updating my post above.

Hello,
We found that the issue was already fixed by the following merged PR:
https://github.com/DevExpress/testcafe/pull/8135/files
The fix will be available in the next TestCafe release.


Safe FS writing

Writing program state to a file is fairly hard to do safely, especially with Node's async FS writing. PS previously reimplemented the code necessary to do it safely basically everywhere it was needed. FS().writeUpdate now consolidates that code so anyone can easily safely update a file.
Would like code review on this.
#4110 should be rebased on this.

The punishments.js change is easier to read ignoring whitespace: https://github.com/Zarel/Pokemon-Showdown/pull/4145/files?w=1

This is a bit off-track, but would it be a good idea to cache FSPath instances by their absolute path from FS? This would optimize code making multiple calls to FS, but more importantly would allow FSPath to be able to be able to keep state without needing to rewrite code in other modules to keep track of their own FSPath instances. FSPath#writeUpdate wouldn't need FS.pendingUpdates in order to function.
Apart from that, I don't have anything to add. This looks good as is.

I really don't like the idea of caching FSPath instances. Memory is limited, and the cost of creating new objects is negligible for how often we do it.


Array distinct value by property decorator

Changes

Added new decorator to validate if array of object contains distinct values based on property passed

How to use
import ArrayDistinct from '@crowdlinker/nestjs-commons/decorators/validations/array-distinct';

interface UserField {
   name: string;
   email: string;
 }

class UserDetailsDto {
  @ArrayDistinct('email', {
      message: 'User emails should be unique.',
    })
  @Type(() => UserField)
  userFields: UserField[]
}

Changes have been added to #10.


Use expand_heap in GC.verify_compaction_references

As double_heap was deprecated in https://github.com/ruby/ruby/commit/a6dd859affc42b667279e513bb94fb75cfb133c1

Thanks for the change! I've seen this warning but didn't get around to fixing it 😅. I think we're still testing some older Rubies, could you make this change conditional on having a Ruby version which supports expand_heap?

Oops didn't realise that CI was testing for more versions


vp8d/vc1d: add report decoded FrameType

-Add reporting type of decoded frame via extended buffer
MFX_EXTBUFF_DECODED_FRAME_INFO
relate to issue: 333

If #333 is only partially address (do you still need a change for VC1?) add: "Fix for #333" instead of Fixes otherwise github will close the bug.

@dvrogozh , I see PR WIP for now.
Have you any concerns for VP8d implementation?

@dmitry-gurulev , please take a look

@dvrogozh , for AVC and HEVC setting frame type implemented in FillOutputSurface() together with GetSurface()
I haven't find implementation for JPEGd, but in MPEG2 feature enabled via SetFrameType - separate function (not member of decoder class) which also called in FillOutputSurface().
I'm not sure that really need to introduce FillOutputSurface for vp8 for vc1 it's FillMFXDataOutputSurface()).
Also for me using an function/method for setting frame type looks better.
I'm not sure, it's make sense to move SetFremaType out the class? Or better keep as const method

For Jpeg, I mixed things with jpeg issue #970, sorry. For the alignment across codecs - talk with @dmitry-gurulev, please, and make a decision.


rpm version install package can never be fully downloaded

I have tested (with friends) in several countries, and we all fail at about 25 MB. The server does not support range/content length header, so resuming interruption is not possible.

Further testing finds out that the server will break the connection once it lasts 20 seconds, so only a connection over 5MBps is possible to download the entire file.

had same issue, checked this: https://gemfury.com/help/yum-repository and made up that the repo url for rpm shall be:
https://yum.fury.io/davidbailey00 -> that works now.


except key error

e.g. levenshtein indices will not written to file according to line 158
had a problem if i try to load my file with the indices again. Levenshtein has no _index attribute an will not written to the file.

Coverage decreased (-0.1%) to 77.644% when pulling 8fb91a38e2ca3457a003b6e08a24d601119ae50c on jbrissier:master into 0a3663c0ec4efd2960e5c9e7334dcfb1d7bdacc6 on datamade:master.

Coverage decreased (-0.1%) to 77.644% when pulling 8fb91a38e2ca3457a003b6e08a24d601119ae50c on jbrissier:master into 0a3663c0ec4efd2960e5c9e7334dcfb1d7bdacc6 on datamade:master.


JSON load can't read req.stream on POST request

As the title says, after my POST request, json.load seems that he can't read the req.stream. Here's my unworking code :
class Register(object):
    def on_post(self, req: falcon.Request, resp: falcon.Response):
        data = json.load(req.stream)

And here's what uWSGI returns me when I do my POST request :
Traceback (most recent call last):
  File "/home/bachrc/dev/serveur-rest-dg2r/env/lib/python3.5/site-packages/falcon/api.py", line 209, in __call__
    responder(req, resp, **params)
  File "./controllers/shop/register.py", line 16, in on_post
    data = json.load(req.stream)
  File "/usr/lib/python3.5/json/__init__.py", line 268, in load
    parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
  File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'

I'm using the Chromium extension Postman to do my POST requests.
I actually tried a lot of things, and with this bribe of code, I can read the answer :
class Register(object):

    def on_post(self, req: falcon.Request, resp: falcon.Response):
        data = json.loads(str(req.stream.read().decode("utf-8")))

I'm not convinced of the efficiency, or the performance of this solution tho'. It's more a trick than an actual solution. And the documentation says json.load(req.stream) is safe, but is obviously not.

Okay. So it seems that to use your example, you should be in Python 3.6, and I was in 3.5 . Lost 3 hours for this. https://docs.python.org/3/library/json.html#json.load

I just did the same thing. That was painful.

Can't you use req.media ?


KE-30503, upgrade spark version

add pom with MultiDelimitSerDe which causes sampling error problems

retest this please


Support for aarch64

We currently use this Docker image to test our cisagov Ansible roles.  I am looking to test our Ansible roles on both aarch64 and arm64 platforms, but this image does not support the former.  It would be nice if it did.

Thanks! I support arm64 on a few of the other builds, but haven't put that code in here yet. For reference: https://github.com/geerlingguy/docker-ubuntu2204-ansible/blob/master/.github/workflows/build.yml#L56


luci-base: fix issues and update Japanese translation

fix translation related issues
sync translations
update Japanese translations

Thanks. If you have time, you could check some of the app translations for fuzziness. There have been some mainly cosmetic changes to strings at least in Adblock and travelmate that affect translations. I partially fixed some issues yesterday, but some fixes require somebody really speaking the language.

Thanks for your work, I'll check it later :)


Not able to update object from iOS on PARSE

I have tried to update Parse object from Parse CloudCode function. I want to update status_id for one particular entry whose objectId is "vZveFx3KcP”. Whenever i call following function no entry gets updated. but whenever i added manual entry or entry from Android device it gets updated without any issue. For iOS i am using latest Parse version "1.11.0". I got this issue only to those entries who gets added by iOS platfrom.
Can any one Please explain where i am going wrong. I am new to javascript programming so let me know if you need additional information from me. You can check my code below. I have tried calling cloud function from Parse API console.
Parse.Cloud.define("freshFunction", function(request, response) {
           var GameScore = Parse.Object.extend("Booking");
           var query = new Parse.Query(GameScore);
           query.equalTo("objectId", "vZveFx3KcP");
           query.first({
                      success: function(results) {

                      alert("Successfully retrieved " + results.length + "user_id");

                      results.set("status_id", 2);
                      results.save();
                      response.success();
                      },
                      error: function(error) {
                      alert("Error: " + error.code + " " + error.message);
                       response.error();
                      }
                      });

           });

I am updating these entries from cloud code. I am able to fetch and update those entries from iOS platform. But those entries are not updating when we call them from cloud code. In cloud code i am getting success message but in reality its not at all updated. This happens to entries who are added from iOS platform. For android and manual entry function works fine.
Can anyone face the same issue ? Let me know if you need additional info from me.
Thanks in Advance,
Akshay Aher.

Hey @akshayaher, this looks to be more related to Cloud Code/JS SDK. I can help you validate the iOS code that you are using, but the JS function looks fine, since it also works on Android.
Another thing I would recommend is to fit an issue on our JS SDK repo.

For adding object i am using following code on iOS platform.
PFObject *gameScore = [PFObject objectWithClassName:@"Booking"];
gameScore[@"book_fromtime"]=[NSNumber numberWithFloat:[[[arrStartTimeUTC objectAtIndex:1] stringByReplacingOccurrencesOfString:@":"<EMAIL_ADDRESS>floatValue]];
gameScore[@"book_totime"] = [NSNumber numberWithFloat:[[[arrEndTimeUTC objectAtIndex:1] stringByReplacingOccurrencesOfString:@":"<EMAIL_ADDRESS>floatValue]];
gameScore[@"book_date"]=[arrStartTimeUTC objectAtIndex:0];
<EMAIL_ADDRESS>gameScore[@"user_id"]=[[NSUserDefaults standardUserDefaults] objectForKey:USER_ID];
<EMAIL_ADDRESS><EMAIL_ADDRESS>gameScore[@"status_id"]=@1;
[gameScore saveInBackgroundWithBlock:^(BOOL succeeded, NSError *error) {
        if (succeeded) {
            // The object has been saved.
            [self hideBusyActivityView];
            [self.navigationController popViewControllerAnimated:YES];
        } else {
            // There was a problem, check error.description
            [self hideBusyActivityView];
            [self showAlertWithMessage:error.localizedDescription];
        }
    }];

With above code object saved successfully. however when i updated that object from cloud code it fail to update.


💡[Feature]: Addition of FAQ page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add the FAQ page which currently does not exist in the website.
@sanjay-kv  Kindly assign me the issue.
Use Case
I will make a new FAQ page which will match the aesthetic and theme of the website
Benefits
FAQ page helps users to get answer of the questions which are very frequently asked.
Add ScreenShots
I will redesign  this Page

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@sanjay-kv kindly assign this task to me under gssoc'24 extd and hacktoberfest.

@sanjay-kv  KIndly assign me the issue so I can contribute.

@sanjay-kv  the FAQ page already exists in the code files . Kindly update the lInk in the github page for BEtter understanding

i think its the deployment issues


Add support for periodic cache clean up.

Purpose

$subject

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Better to support Google Knowledge Panel Blacklist

Current version do not support to remove the content showed in knowledge panel, wish to have this function.

Duplicate of #194


Systemctl status of ood-daemon.service is error

I install Linux DIY-OOD, then find that : Systemctl status of ood-daemon.service is error
root :/ood_test# ps -ef | grep -E cyfs/services
root      969956       1  0 20:38 ?        00:00:00 /cyfs/services/ood-daemon/7jMmeXZck8eSjPSkX2FB5LKWvNqMYco3ti4m4mxihssb/bin/ood-daemon --as-monitor
root      970030  969956  8 20:39 ?        00:00:04 /cyfs/services/ood-daemon/7jMmeXZck8eSjPSkX2FB5LKWvNqMYco3ti4m4mxihssb/bin/ood-daemon --start
root      970122  967403  0 20:40 pts/16   00:00:00 grep --color=auto -E cyfs/services
root :/ood_test#
root :/ood_test# systemctl status ood-daemon.service
× ood-daemon.service
     Loaded: loaded (/etc/init.d/ood-daemon; generated)
     Active: failed (Result: exit-code) since Thu 2023-05-04 20:34:02 CST; 6min ago
       Docs: man:systemd-sysv-generator(8)
        CPU: 470us

May 04 20:34:02 filecoin2 systemd[1]: Starting ood-daemon.service...
May 04 20:34:02 filecoin2 systemd[969200]: ood-daemon.service: Failed to execute /etc/init.d/ood-daemon: No such file or directory
May 04 20:34:02 filecoin2 systemd[969200]: ood-daemon.service: Failed at step EXEC spawning /etc/init.d/ood-daemon: No such file or directory
May 04 20:34:02 filecoin2 systemd[1]: ood-daemon.service: Control process exited, code=exited, status=203/EXEC
May 04 20:34:02 filecoin2 systemd[1]: ood-daemon.service: Failed with result 'exit-code'.
May 04 20:34:02 filecoin2 systemd[1]: Failed to start ood-daemon.service.

What is the version of your linux, probably related to the specific operating system environment?

This is not a bug, but can be considered for improvement:
ood-daemon takes a monitor dual process mode to keep the ood-daemon service running.
This startup sequence is as follows:

ood-daemon process starts
not found the monitor process, and the monitor process is started.
ood-daemon process exits
The monitor process pulls up the ood-daemon process again

This pattern is not very common in linux services. Moreover, ood-installer is started using the traditional init.rc script mode, which does not require monitoring process status
On some systems that support systemd (ubuntu in this case? Am I right?), it tries to do a compatibility with the traditional init script, but apparently it does so incorrectly here ......
Here you can consider replacing the current init script-based startup with a systemd-based one. But considering that init scripts are more widely supported. I'm still hesitant to replace it

Which popular linux distributions that do not yet support systemd?
I think if systemd is a popular choice around popular linux distributions , switching the startup script to systemd is a better choice.
@lizhihongTest

@weiqiushi This is caused by your script error： /etc/init.d/ood-daemon
/etc/init.d/ood-daemon
-bash: /etc/init.d/ood-daemon: /bin/sh^M: bad interpreter: No such file or directory

This error message means that the interpreter that is specified in the first line of the file ("/bin/sh") cannot be found. The "^M" at the end of the error message is a carriage return character, which is a remnant of Windows-style line endings (which use a combination of carriage return and line feed characters to indicate the end of a line).
To fix this issue, you can remove the carriage return characters from the file

@weiqiushi This is caused by your script error： /etc/init.d/ood-daemon
/etc/init.d/ood-daemon
-bash: /etc/init.d/ood-daemon: /bin/sh^M: bad interpreter: No such file or directory

This error message means that the interpreter that is specified in the first line of the file ("/bin/sh") cannot be found. The "^M" at the end of the error message is a carriage return character, which is a remnant of Windows-style line endings (which use a combination of carriage return and line feed characters to indicate the end of a line).
To fix this issue, you can remove the carriage return characters from the file
The /etc/init.d/ood-daemon.sh file, released via ood-installer, is already has unix line endings from long time ago. You can check this by yourself.
https://github.com/buckyos/CYFS/blob/main/src/tools/ood-installer/res/default/ood-daemon.sh

Also, if the file /etc/init.d/ood-daemon is invalid, then ood-daemon should not start.
This does not explain the fact that the ood-daemon process exists in your process list.
@lizhihongTest

The "ood-daemon" process may have been started by "ood-installer" because I ran a DIY-OOD installation package. The error is just caused by the erroneous "^M" character in the script file "/etc/init.d/ood-daemon", and it has no direct relationship with whether the "ood-daemon" process was successfully launched or not.
Pelase you see this error log ,And check your shell code for /etc/init.d/ood-daemon
May 04 20:34:02 filecoin2 systemd[969200]: ood-daemon.service: Failed to execute /etc/init.d/ood-daemon: No such file or directory
May 04 20:34:02 filecoin2 systemd[969200]: ood-daemon.service: Failed at step EXEC spawning /etc/init.d/ood-daemon: No such file or directory

The DIY OOD installation package on the official website is generated by the internal two Windows CI Agent
where the linux version is generated by wsl compilation on Windows.
On the two Agents, one of them has not modified the autocrlf configuration of git to false (on Windows, this option is true by default)
The ood-installer compiled by this machine will release the ood-daemon.sh file with the wrong line end when installed
it will be fixed after DIY OOD Installer <IP_ADDRESS>


Swagger parser v3 unable to load reference file from classpath

Hi,
We need to upgrade our swagger parser, but when we upgrade our tests start to fail since files which reside in our dependency cannot be loaded and we end up with the following error:
"Unable to load RELATIVE ref: ./dependency_Parents.schema.json path: C:\Users\<private>\checkout\swagger-classpath-issue\local\target\classes"
I have created a minimal project which shows the issue occuring and can be found here:
https://github.com/remcosiemonsma/swagger-classpath-issue
If you run the test in the local/src/test/java folder you will notice 1 working and 1 failing test, and the only difference is that in the failing case we try to reference a file from the dependency project instead of from the local project.
It seems this behavior broke in version 2.0.29.
Thanks for your support.

We're seeing the same issue in our projects.
2.0.27 = Works
2.0.28 = Breaks

As the issue is outdated and problem does not appear anymore, I am closing this


Invoking EWS API in multi-threaded environment

Is it possible to leverage the current EWS API in multi-threaded environment?
When querying the shared calendar based on given date range, it may or may not be slow depending on the date range size.
So, I split the date range into smaller ranges, then used RxJava where each thread invokes EWS API to process each small chunk... finally, combine them and return the data back to the caller.
I tried 2 approaches, but couldn't get both working. By the way, I'm using just one credential (a generic account) to connect to Exchange server.
My first approach is to create ExchangeService object, do stuff and then invoke ExchangeService.close() at the end of each thread... and I get this exception from one of the threads:-
Caused by: microsoft.exchange.webservices.data.core.exception.service.remote.ServiceRequestException: The request failed. 40
	at microsoft.exchange.webservices.data.core.request.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:74)
	at microsoft.exchange.webservices.data.core.request.MultiResponseServiceRequest.execute(MultiResponseServiceRequest.java:158)
	at microsoft.exchange.webservices.data.core.ExchangeService.bindToFolder(ExchangeService.java:500)
	at microsoft.exchange.webservices.data.core.ExchangeService.bindToFolder(ExchangeService.java:519)
	at microsoft.exchange.webservices.data.core.service.folder.CalendarFolder.bind(CalendarFolder.java:60)
	at microsoft.exchange.webservices.data.core.service.folder.CalendarFolder.bind(CalendarFolder.java:75)
	at myproject.module.pto.service.impl.MicrosoftExchangeServiceImpl.query(MicrosoftExchangeServiceImpl.java:78)
	... 6 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 40
	at org.apache.http.impl.auth.NTLMEngineImpl$NTLMMessage.addByte(NTLMEngineImpl.java:911)
	at org.apache.http.impl.auth.NTLMEngineImpl$NTLMMessage.addULong(NTLMEngineImpl.java:940)
	at org.apache.http.impl.auth.NTLMEngineImpl$Type1Message.getResponse(NTLMEngineImpl.java:1043)
	at org.apache.http.impl.auth.NTLMEngineImpl.getType1Message(NTLMEngineImpl.java:148)
	at org.apache.http.impl.auth.NTLMEngineImpl.generateType1Msg(NTLMEngineImpl.java:1628)
	at org.apache.http.impl.auth.NTLMScheme.authenticate(NTLMScheme.java:139)
	at org.apache.http.impl.auth.AuthSchemeBase.authenticate(AuthSchemeBase.java:138)
	at org.apache.http.impl.auth.HttpAuthenticator.doAuth(HttpAuthenticator.java:239)
	at org.apache.http.impl.auth.HttpAuthenticator.generateAuthResponse(HttpAuthenticator.java:202)
	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:262)
	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
	at microsoft.exchange.webservices.data.core.request.HttpClientWebRequest.executeRequest(HttpClientWebRequest.java:292)
	at microsoft.exchange.webservices.data.core.request.ServiceRequestBase.getEwsHttpWebResponse(ServiceRequestBase.java:720)
	at microsoft.exchange.webservices.data.core.request.ServiceRequestBase.validateAndEmitRequest(ServiceRequestBase.java:639)
	at microsoft.exchange.webservices.data.core.request.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:62)

My second approach is to create ExchangeService object as singleton where each thread can use it... but I get this error instead:-
The request failed. Connection is still allocated

My goal is to be able to pull the shared calendar info fast enough to be displayed on the web at real time, and to ensure concurrent users try to perform the same query at the same time (using the same generic account) successfully.
What should I change to get this to work?
Thank you.

The ExchangeService class is by no means thread-safe. So you'll have to use one instance per thread. The ArrayIndexOutOfBoundsException could very well be a bug. Perhaps someone else have a look at this?
BTW, why is this issue closed? Did you solve it? If so, could you post your solution for future reference?

The ArrayIndexOutOfBoundsException fits when two threads will try to manipulate the byte[] in NTLMEngineImpl


fix: upgrade to version 3.2.142

from: https://github.com/jenkins-x/jx

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ccojocar
You can assign the PR to them by writing /assign @ccojocar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
b85a674950735a38d237c050b3f58ae7ae2384f2
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


The script tried to execute a method or access a property of an incomplete object.

Getting this error a after doing a Craft 3 Update (Updated to V3.1.26)
lukeyouell\geocookie\services\GeoService::location(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "stdClass" of the object you are trying to operate on was loaded before unserialize() gets called or provide an autoloader to load the class definition
Attached is the full error page I get.
yii_base_ErrorException.htm.zip

I was running into this error as well. I think the plugin is not supported anymore; I submitted a pull request (#14) last October, and the issue was never fixed. Unfortunately, You may want to consider forking the plugin and using that version instead.
As for the fix, I was able to fix it with the following in services/Geocookie.php:
replace:
$location = $cookie->value;

with:
$location = @unserialize($cookie->value);

if ($location === false) {
    $location = $cookie->value;
}

and replace:
'value' => $location,

with:
'value' => serialize($location),

Hopefully that helps!

Thank you @davist11 I applied that same fix to a fork for a project we are working on.

@mrnebbi would you consider forking and maintaining this plugin for a while?


AttributeError: module 'pydantic._internal' has no attribute '_model_construction'

I was stepping through the guide, including the requirements.txt.
I got the attached error.
I have python 3.10.6, pydantic 2.5.0,  and pydantic_core of 2.14.1, ray 2.8.0

Update:
It worked when I downgraded ray to ray 2.6.0

Did anyone look into why that behavior is occurring? I see the same issues as well.


[Bug] TouchEffect.NativeAnimation fires twice on Android

Description
On Android, the ripple effect is carried out twice in a row when you briefly tap an element.
I cannot currently check whether the problem also exists with iOS.
Steps to Reproduce

Add a grid to your page
Set on the grid TouchEffect.NativeAnimation="True"
Run the app and briefly tap the grid

Expected Behavior
The ripple effect is displayed once.
Actual Behavior
The ripple effect is displayed twice.
Basic Information

Version with issue: 1.0.2
Last known good version: -
IDE: Visual Studio 2019 Community
Platform Target Frameworks:

iOS:
Android:
UWP:

Android Support Library Version:
Nuget Packages:
Affected Devices:

Duplicate of already fixed https://github.com/xamarin/XamarinCommunityToolkit/issues/804
@Symxn please check https://github.com/xamarin/XamarinCommunityToolkit/pull/817 it will be fixed in the next release
cc @AndreiMisiukevich

Duplicate of #804