Billing RP spec changes for listInvoiceSectionsWithCreateSubscription…

…Permission API
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

@KrisBash @asarkar84 Hello. Do you discuss about this PR offline? @asarkar84 Do you know how to change this PR?

@MyronFanQiu I have not discussed the changes with @KrisBash offline.
@KrisBash I am not able to see the comments from you in this PR. Please add them.

@KrisBash I have incorporated the review comments. Kindly take a look.

@KrisBash Truly sorry! I just made a mistake that not wait for your confirmation. Could you please check whether the author has solved your comments. @asarkar84 Hello. I'm sorry I just merged this PR. Just as a reminder, we may need further changes. Truly sorry for my mistake.


Google Ads API OCI

This is implemented by PR #124, thanks for the amazing work @gmcro and @jcryan-g!!


Benefits Navigator Overview Page + Card on Home

Benefits Navigator Overview Page + Card on Home
This task creates the benefits navigator overview page on the site. English and french paths working with applied rewrite. Please verify it's design and behaviour by checking out the designs here

Test Instructions

Go to homepage and see that Benefits Navigator card is available
Click the card and navigate to the page
See that page matches the design
Toggle languages during navigation

Definition of Done

[x] Update CHANGELOG

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1445041289.azurewebsites.net

Looks good. was there an update to our formatting rules? I see a few changes in the projectQuery.graphql file that are just format differences. 🔍

I manually formatted with "Format Document" not sure if the rules are new or if they were just haven't been formatted in a long time...


Use $PWD instead of $(pwd)

The former should be faster, because it does not invoke a subshell.

Is there rbenv PR?

Not that I know of - haven't checked.

I couldn't find one in rbenv PRs. I think same can be applied to rbenv and it is definitely useful for them. Please send a PR to them as well.

Ok, will do - but not during the next days probably.
Will close this PR here for now - it should get merged then from rbenv.


KeyError 0801 - error on startup

OpenBazaar Server v0.1 starting...
2015-10-21 21:11:57+1000 [-] Log opened.
2015-10-21 21:11:57+1000 [-] Finding NAT Type..
2015-10-21 21:11:58+1000 [-] Traceback (most recent call last):
2015-10-21 21:11:58+1000 [-]   File "openbazaard.py", line 217, in <module>
2015-10-21 21:11:58+1000 [-]     Parser(OpenBazaard('/tmp/openbazaard.pid'))
2015-10-21 21:11:58+1000 [-]   File "openbazaard.py", line 166, in __init__
2015-10-21 21:11:58+1000 [-]     getattr(self, args.command)()
2015-10-21 21:11:58+1000 [-]   File "openbazaard.py", line 194, in start
2015-10-21 21:11:58+1000 [-]     run(args.testnet)
2015-10-21 21:11:58+1000 [-]   File "openbazaard.py", line 50, in run
2015-10-21 21:11:58+1000 [-]     response = stun.get_ip_info(stun_host="seed.openbazaar.org", source_port=port)
2015-10-21 21:11:58+1000 [-]   File "C:\Python27\lib\site-packages\stun\__init__.py", line 253, in get_ip_info
2015-10-21 21:11:58+1000 [-]     stun_host=stun_host, stun_port=stun_port)
2015-10-21 21:11:58+1000 [-]   File "C:\Python27\lib\site-packages\stun\__init__.py", line 219, in get_nat_type
2015-10-21 21:11:58+1000 [-]     changeRequest)
2015-10-21 21:11:58+1000 [-]   File "C:\Python27\lib\site-packages\stun\__init__.py", line 136, in stun_test
2015-10-21 21:11:58+1000 [-]     bind_resp_msg = dictValToMsgType[msgtype] == "BindResponseMsg"
2015-10-21 21:11:58+1000 [-] KeyError: '0801'

Only encountered this bug when I attempted to start the server with my VPN on.

This is issue #44


Support iter.Seq2 for *FieldValue

closes #355
I added iter.Seq2 support for HSET, HMSET, XADD which have FieldValue() method.
We must support < go 1.23, so we must split file to other files.
It's hard to support auto generation because current implementation does not support code splitting.
So I hand-written the implementation.
When go version in go.mod is go 1.23, I think we can support auto generation by adding flags to *.json and its structs.
Consideration
I named FieldValues, but this is maybe not good to support auto generation in the future because we must consider plural form correctly.
Is FieldValueSeq better?

Is FieldValueSeq better?

I think your original FieldValueIter is better.


All systems operational in readme.md should be All systems are operational.

Describe the bug
In readme.md file line which says All systems operational should be All systems are operational
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Scroll down a little and check in Readme.md file
See error

Expected behavior
the sentence should be All systems are operational

Can you please assign this issue to me I have fixed this issue?


A lot of compile errors

Hi,
First thanks for your great work! Really nice.
I followed the clear instructions and add the Arduino libraries. But I receive a lot of compile errors about redefining.
Is there a solution for this? It was mentioned before but that topic was closed.
Regards,
Bert

Hi Gerben,
I made some progress. It seems to be that the LITTLEFS library is now part of the core Arduino. I use the IDE v1.8.19 macOS version. So there is no need to add that library to the sketch. LITTLEFS is renamed to LittleFS. After those changes I can upload it to ESP32 board. It starts, portal ok, WiFi Ok. But some weird error message after Performing iGrill App Authentication. Guru Meditation Error: Core  0 panic'ed (Double exception).
I need to figure out what is happening here and if I can debug.
Groet,
Bert

Hi Bert, I recall having the same/similar issue. Not too much of an arduino expert myself so I will not be able to guide you any further than sharing that by including the exact library versions (including ESP board) i was able to compile the code without any modification. My ealier attempt to chage LITTLEFS to LittleFS resulted in same error that you currently have over the serial interface. Happy to send you my compiled binary (for DFRobot FireBeetle ESP8266 IoT Development Board - Wi-Fi - ).

I have this fault  if i compile
'custom_MQTT_SERVER_LEN' was not declared in this scope

Is it possible that someone send me the bin file?

Is it possible that someone send me the bin file?
esp32_iGrill.ino.esp32.zip
Hope this helps

Thanks it works!!

Sorry for the delayed response, but this should be fixed now. I've tested and confirmed it working on my end using the latest versions of all the libraries and the built in littlefs library (I updated the README to list the versions i tested with).
Can you try again and let me know if it resolves your issue?

Not the OP, but tried with latest libraries and latest code, seem to be all good.
Also seem to fix the random case where my esp32 would just decide to go offline after a while 👍

Thanks for testing and letting me know it worked for you as well. I am going to go ahead and close this issue now.

This is not working in my instance. I have installed all dependencies using the versions listed in the Readme, yet I still get the following error when attempting to compile:
C:\Workspaces\esp32_iGrill\esp32_iGrill.ino:35:105: fatal error: LittleFS.h: No such file or directory


React support

Users who write awesome React apps should be able to use Stryker to test their apps.
Todo list:

[x] Support mutating modern JS code (stryker-javascript-mutator plugin)
[x] Support Babel projects (stryker-babel-transpiler plugin)
[ ] Support Webpack projects (@Archcry)
[ ] Test React projects

Do you have a React app? Please let us know!
It would be awesome if it's open source but that's not a requirement.
Known users/setups:
@CrazyBS: React, Redux, Babel, Karma, Mocha (#101)
@SxMShaDoW create-react-app -> React, Babel, Jest (#133)
@Venkat-18 React, Jest
The post above will be kept up-to-date and is subject to change!

What tool and command is used to run react tests? For example: angular uses karma, but running tests is done using ng test most of the time.

Typical react projects created with the create-react-app tool don't use an cli, they use simple npm scripts that execute a test suite. The npm test command invokes this file:
'use strict';

// Do this as the first thing so that any code reading it knows the right env.
process.env.BABEL_ENV = 'test';
process.env.NODE_ENV = 'test';
process.env.PUBLIC_URL = '';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
  throw err;
});

// Ensure environment variables are read.
require('../config/env');

const jest = require('jest');
const argv = process.argv.slice(2);

// Watch unless on CI or in coverage mode
if (!process.env.CI && argv.indexOf('--coverage') < 0) {
  argv.push('--watch');
}

jest.run(argv);

My mistake, react does have react-scripts, but it is possible to eject the project with create-react-app eject. I am not sure this is what we want though.

React uses jest as testing framework, this means that it does not use Webpack for testing at all. When jest is configured correctly it should be able to test any react project. The current plugin for jest in Stryker does not support this unfortunately due to the lack of correct configuration.

Hi,
Our project on react. I try to add stryker add got https://github.com/stryker-mutator/stryker/issues/607.
The project was not created via create-react-app
The part of our package.json:
...
"react": "16.2.0",
"redux": "3.7.2",
"@babel/core": "7.0.0-beta.39",
"@babel/polyfill": "7.0.0-beta.39",
"enzyme": "3.3.0",
"jsdom": "11.6.2",
"mocha": "5.0.0",
"webpack": "3.10.0",
"postcss-loader": "2.1.0",
"less": "2.7.3",
"less-loader": "4.0.5",
...

@simondel I'm using webpack css-loader modules option to import css files in jsx (see https://github.com/webpack-contrib/css-loader/blob/master/README.md#modules)

@nabilnaffar could you create a new issue for your error, we will close this issue once we've verified that it works on our react projects.

@nicojs sure. will it support Typescript mutations too?

@nabilnaffar yes it will. The mutation part is a different plugin from the transpiler part.
In other words: you could choose mutator: 'typescript' while still choosing the transpilers: [ 'babel' ]  (or webpack, ...).

I was able to run mutation tests on a combination of Typescript and React created using create-react-app --scripts-version react-scripts-ts. I didn't need to eject it.
I use mutator: 'typescript' and jest as test framework. I don't use the transpilers: ['webpack'] since that's not required for the combination I use.
Didn't experience any problems with that setup.

I'll close this issue for now. If people have trouble getting a React project up and running, let us know!


Adds nparallel multi-process support to CleanRL example

Thanks for checking, as @visuallization also mentioned on Discord that this works, I'll merge .


Some ResourceManagement samples do not compile with SNIPPET symbol

We're working on turning on building snippets for all projects by default to make sure all our source from which snippets are created actually build. This was one major reason we started this project a few years ago. When doing so, however, this means some code is invalid when compiled. Consider the following sample, which I see in a few mgmt projects (networking, storage, etc.):
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

#region Snippet:Changelog_New
            using Azure.Identity;
            using Azure.ResourceManager.Compute.Models;
            using Azure.ResourceManager.Network;
            using Azure.ResourceManager.Network.Models;
            using Azure.ResourceManager.Resources;
            using Azure.ResourceManager.Resources.Models;
            using Azure.Core;
            using System;
            using System.Linq;

#if !SNIPPET
using System.Threading.Tasks;
using NUnit.Framework;

namespace Azure.ResourceManager.Compute.Tests.Samples
{
    public class Changelog
    {
        [Test]
        [Ignore("Only verifying that the sample builds")]
        public async Task NewCode()
        {
#endif
            ArmClient armClient = new ArmClient(new DefaultAzureCredential());

            AzureLocation location = AzureLocation.WestUS;
            // Create ResourceGroupResource
            SubscriptionResource subscription = await armClient.GetDefaultSubscriptionAsync();
            ArmOperation<ResourceGroupResource> rgOperation = await subscription.GetResourceGroups().CreateOrUpdateAsync(WaitUntil.Completed, "myResourceGroup", new ResourceGroupData(location));
            ResourceGroupResource resourceGroup = rgOperation.Value;

When we pass /p:DefineConstants=SNIPPET, part of that source is excluded and now invalid, so the build fails. What we've done in other projects is have separate regions for usings and for code. Even in the sample markdown files, we typically call this out as separate sections like you can see here.
I recommend following a similar approach so code is always compilable regardless of symbols passed.
To test this locally, you can run the following replacing /p:ServiceDirectory=* for the actual service directory e.g., "network":
dotnet build eng/service.proj -warnaserror /t:rebuild /p:DebugType=none /p:SDKType=all /p:ServiceDirectory=* /p:IncludePerf=false /p:IncludeStress=false /p:PublicSign=false /p:Configuration=Release /p:EnableSourceLink=false /p:BuildSnippets=true

This should be fixed now. We are refreshing all the mgmt plane SDKs, no such issues seen until now.
Closing...

Not fixed all, reopen

Fixed all bad samples


Invalid SHA1 during Ivy retrieve

I noticed the following warnings while retrieving the 0.107 Presto Parser:
ivy:retrieve] :::: WARNINGS
[ivy:retrieve] problem while downloading module descriptor: http://repo1.maven.org/maven2/com/facebook/presto/presto-parser/0.107/presto-parser-0.107.pom: invalid sha1: expected=7f2f854a24db4cc9b5c26c3e9c6e46da37abbed1 computed=661fee4927f5b356f91880c308e5bf586568ff3c (180ms)
[ivy:retrieve] problem while downloading module descriptor: http://repo1.maven.org/maven2/com/facebook/presto/presto-root/0.107/presto-root-0.107.pom: invalid sha1: expected=3e2a2729fd8b728fdc29c4062f5dc9a138c433cd computed=2cdf6c93caab02a26e6280862ed25452b862e5bf (218ms)
[ivy:retrie

@jvanzyl any ideas how this could happen? They definitely do not match:
$ curl -sS http://repo1.maven.org/maven2/com/facebook/presto/presto-parser/0.107/presto-parser-0.107.pom | shasum
661fee4927f5b356f91880c308e5bf586568ff3c  -

$ curl -sS http://repo1.maven.org/maven2/com/facebook/presto/presto-parser/0.107/presto-parser-0.107.pom.sha1
7f2f854a24db4cc9b5c26c3e9c6e46da37abbed1

Without checking anything yet, did you try to release this a couple times and try to drop the staging repository in Nexus? I'll look at some other releases but if this is generally the case that's bad because it's probably the Maven Release Plugin. If you had to release/drop/release with Nexus it would not surprise me if it just left the old bits around.

Isn't this something that is checked for when closing a staging repository?

It is, but if there were multiple attempts to release and a repo was dropped it's possible a file got picked up from a dropped repo. I'm running a check on all of central now.

I'm going to this since it's for a very old version and is a problem with Maven Central: http://central.sonatype.org/
We deploy to Central via the standard OSSRH process, which should have checks in place to prevent this from occuring (but apparently something went wrong this release): http://central.sonatype.org/pages/releasing-the-deployment.html


Allow ENV settings through config file AO-7742

update config file template with new settings and explanatory comments
add code to read new settings
make sure there is test coverage for precedence of ENV vars over config file settings and defaults
load config file before initializing oboe and set tracing_mode afterwards

good point! ;)


Data-setup muted not functioning

When muted is passed as part of the data-setup videos are being played with sound regardless of muted being set to true or false.

I cloned this repo, created my own branch, and I will submit a pr for this issue.

@14amoore muted is not any supported parameter. If you want to play videos as soon as they are loaded you can set autoplay to true in that case user has to unmute video because autoplay with sound is not allowed in modern browsers.


[Feature] Stat box widgets

Objective
Introduce a stat box widget to show numbers at a glance. This is new widget, which is made with the help of old widgets (composite widget)

Requirements

Title
Description
Comment

Container
Parent element is the container, Default to 14 rows and 12 columns
-

Text
headerText (para 2, #999999), bodyText (Heading 1, Bold, Black), captionText (para2, Theme success color) will be placed one below the other in the extreme left column
-

IconButton / FAB
Default to solid, Success, Up arrow
The icon button will have a change here, When onClick action is not present the hover state and Click pointer should not occur

Preview

@momcilo-appsmith can you please provide  an icon image for the widget panel for this widget


training with just the preprocessed folder in det_models  folder crashes

Recently I transferred the   'preprocessed'   folder (along with its unpacked preprocessed dataset, etc) alone into   "det_data/Task16_Luna/"    folder   and the 'plan.pkl' file  alone in and as "det_models/Task116_Luna/RetinaUNetV001_D3V001_3d/fold0/plan.pkl".    And all these folders were put in a SSD.    Then started training.   I made several attempts to run,  but the training crashed each  time leaving no error logs.  Could anyone please tell what may be happening ?
Rajesh

The preprocessed folder size is 1.2  Tera Bytes .  I reduced det_num_threads=2  and tried. Even then it used to crash

Hi @DSRajesh,
To identify the problem we need more information, such as the output you got when you ran the training, the environment you used to run the commands, etc. Please check if you can run the training with the toy dataset in that environment. Also, please check that you transferred the dataset.json or dataset.yaml to the Task16_Luna along with the preprocessed folder.
Best,
Partha

Thanks Partha-Ghosh
I got the the following output while training
.
dataset.json was present in the det_data/Task016_Luna  folder.   GPU/CUDA details are as follows.

Thanks Partha-Ghosh
Recently I transferred (as mentioned above) "preprocessed" folder etc, of a nnDetection object detection training model , which had stopped training midway, on a machine 'A'. The probable reason the training code quoted was "RAM becoming full".

And I got the the following output while resuming the training on another machine 'B', using the command line "python scripts/train.py 116 -o train.mode=resume"

and then stopped abruptly without any error logs.
When i tried resuming the training using the command line "python scripts/train.py 116 --sweep -o train.mode=resume" , I got the following extra lines in the output when compared to the output shown above

In the above output we can see the training code was running inferences on all validation datasets one by one (we can see one of the many such inferences being run on validation dataset 127 out of the total of 131)
"dataset.json" was present in the det_data/Task016_Luna folder. GPU/CUDA details are as follows.

I hope these details are sufficient. Was, changing the training location from machine 'A' to 'B' , the reason for this error ? Also why did the training stop in the first place, was it burdening the RAM ? The preprocessed folder was stationed in a SSD.
Thanks again
Rajesh

Thanks Partha-Ghosh
Recently I transferred (as mentioned above) "preprocessed" folder etc, of a nnDetection object detection training model , which had stopped training midway, on a machine 'A'. The probable reason the training code quoted was "RAM becoming full", as shown below.

And I got the the following output while resuming the training on another machine 'B', using the command line "python scripts/train.py 116 -o train.mode=resume"

and then stopped abruptly without any error logs.
When i tried resuming the training using the command line "python scripts/train.py 116 --sweep -o train.mode=resume" , I got the following extra lines in the output when compared to the output shown above

In the above output we can see the training code was running inferences on all validation datasets one by one (we can see one of the many such inferences being run on validation dataset 127 out of the total of 131)
"dataset.json" was present in the det_data/Task016_Luna folder. GPU/CUDA details are as follows.

I hope these details are sufficient. Was, changing the training location from machine 'A' to 'B' , the reason for this error ? Also why did the training stop in the first place, was it burdening the RAM ? The preprocessed folder was stationed in a SSD.
Thanks again
Rajesh

Hi @DSRajesh,
It’s difficult to pinpoint the exact issue from the logs since the initial error suggests that the RAM being full may not be the root cause. Please monitor the RAM consumption to confirm whether it’s actually a memory-related issue.
The patch size might also be a factor. Since nnDetection adjusts patch size based on available GPU resources, you could try reducing it. For instance, setting [80, 192, 160] in the plan.json has worked well on our clusters.
It also looks like you’re resuming the training process at the validation phase, which might indicate that the training has already completed. Without the full log, it's hard to be sure. You could try manually loading the checkpoint to verify the current epoch.
If the issue persists, you might consider restarting the training from scratch on the preferred machine. Additionally, please share the complete log if the problem continues, and we’ll take another look.
Best,
Partha

Thanks a lot Partha
The issue was solved. As you had mentioned, the no of epochs of training i had fixed for the training  had elapsed and hence it was in the validation stage. I increased the no of epochs and resumed training. It works fine now.  Thanks a lot again


[cPP CHANGE] FCS_RBG_EXT.1.2 SFR source(s)

What is the change request for the cPP? Please describe.
In the SFR selection for the sources, "source" should be changed to "source(s)" to be a little more readable since the vendor may choose multiple source selections but the way the sentence is written it is singular.
Describe the solution you'd like
Change these phrases:

[assignment: number of software-based sources] software-based noise source

to

[assignment: number of software-based sources] software-based noise source(s)

and change

assignment: number of hardware-based sources] hardware-based noise source

to

assignment: number of hardware-based sources] hardware-based noise source(s)

Describe alternatives you've considered
N/A
Additional context
N/A

Change Implemented.


jar: reduce redundant allocations and copies (2x-3x speedup)

The io.ReadAll() call is responsible for a bit more than half the allocations observed in a very highly scaled up instance of this [1]. On the local testdata, these commits had quite the positive effect. I ran go test inside the jar/ subdirectory too, and it passed.
Benchmarks:
$ for commit in $(git log --pretty=oneline | head -4 | awk '{print $1}' | tac) ; do
    git checkout $commit
    go build
    hyperfine -i './log4jscanner jar/testdata'
    rm log4jscanner
  done

HEAD is now at https://github.com/aktau/log4jscanner/commit/9d3aceeff48dc332d314d938ef6f3ed7837dfc1e Document commit that removed InitialContext
  Time (mean ± σ):      1.754 s ±  0.260 s    [User: 1.711 s, System: 1.264 s]
  Range (min … max):    1.411 s …  2.182 s    10 runs

HEAD is now at https://github.com/aktau/log4jscanner/commit/2932093ea7873a0df400ec12980ed6206b120ad7 jar: close the zip.File reader before recursing
  Time (mean ± σ):      1.761 s ±  0.312 s    [User: 1.778 s, System: 1.124 s]
  Range (min … max):    1.271 s …  2.239 s    10 runs

HEAD is now at https://github.com/aktau/log4jscanner/commit/f6c1ebcfb928f724f174e9c8ccd818534840a10a jar: prefer io.ReadFull over io.ReadAll
  Time (mean ± σ):     444.8 ms ±  95.3 ms    [User: 353.5 ms, System: 122.3 ms]
  Range (min … max):   337.2 ms … 683.2 ms    10 runs

HEAD is now at 5a28952 jar: reuse buffers for nested .jar's
  Time (mean ± σ):     398.0 ms ±  44.7 ms    [User: 330.6 ms, System: 89.9 ms]
  Range (min … max):   339.7 ms … 471.1 ms    10 runs

[1]:
(pprof) list checkJAR
Total: 213.06GB
         ...
         .     9.89MB    334:           f, err := zf.Open()
         .          .    335:           if err != nil {
         .          .    336:                   return fmt.Errorf("open file %s: %v", p, err)
         .          .    337:           }
         .          .    338:           defer f.Close()
         .   169.96GB    339:           data, err := io.ReadAll(f)
         .          .    340:           if err != nil {
         .          .    341:                   return fmt.Errorf("read file %s: %v", p, err)
         .          .    342:           }
         .          .    343:           br := bytes.NewReader(data)
         .     3.40GB    344:           r2, err := zip.NewReader(br, br.Size())
         ...

(pprof) list ReadAll
Total: 213.06GB
ROUTINE ======================== io.ReadAll in third_party/go/gc/src/io/io.go
  113.40GB   169.96GB (flat, cum) 79.77% of Total
         .          .    638:func ReadAll(r Reader) ([]byte, error) {
         .          .    639:   b := make([]byte, 0, 512)
         .          .    640:   for {
         .          .    641:           if len(b) == cap(b) {
         .          .    642:                   // Add more capacity (let append pick how much).
  113.40GB   113.40GB    643:                   b = append(b, 0)[:len(b)]
         .          .    644:           }
         .    56.56GB    645:           n, err := r.Read(b[len(b):cap(b)])
         .          .    646:           b = b[:len(b)+n]
         .          .    647:           if err != nil {
         .          .    648:                   if err == EOF {
         .          .    649:                           err = nil
         .          .    650:                   }

I'm not sure why this wants me to sign a CLA. This is from<EMAIL_ADDRESS>

Maybe I'm holding it wrong, but I'm not seeing the improvement on our benchmarks
$ git checkout upstream/main
$ go test -run=NONE -bench=. ./... >> old.txt
$ git checkout aktau/main
$ go test -run=NONE -bench=. ./... > new.txt
$ benchstat old.txt new.txt
name             old time/op    new time/op    delta
Parse-8            16.7µs ± 0%    16.8µs ± 0%   ~     (p=1.000 n=1+1)
ParseParallel-8    4.97µs ± 0%    4.97µs ± 0%   ~     (p=1.000 n=1+1)

name             old alloc/op   new alloc/op   delta
Parse-8            4.84kB ± 0%    4.84kB ± 0%   ~     (p=1.000 n=1+1)
ParseParallel-8    4.92kB ± 0%    4.93kB ± 0%   ~     (p=1.000 n=1+1)

name             old allocs/op  new allocs/op  delta
Parse-8              31.0 ± 0%      31.0 ± 0%   ~     (all equal)
ParseParallel-8      31.0 ± 0%      31.0 ± 0%   ~     (all equal)

Maybe I'm holding it wrong, but I'm not seeing the improvement on our benchmarks

Indeed. Even with 10 runs per test we get this:
$ git checkout main ; for commit in $(git log --pretty=oneline | head -4 | awk '{print $1}' | tac) ; do git checkout $commit && ( cd ./jar && go test -run=NONE -bench=. -count=10 | tee ~/tmp/$commit.bench ) ; done
$ benchstat 9d3aceeff48dc332d314d938ef6f3ed7837dfc1e.bench 61ade2d03f307bde6b98ed513f68f01afb9421c9.bench
name             old time/op    new time/op    delta
Parse-4            38.5µs ± 9%    39.5µs ± 9%     ~     (p=0.408 n=7+9)
ParseParallel-4    36.4µs ±23%    31.6µs ±12%  -13.42%  (p=0.035 n=10+9)

name             old alloc/op   new alloc/op   delta
Parse-4            4.92kB ± 0%    4.92kB ± 0%     ~     (p=0.671 n=8+10)
ParseParallel-4    4.94kB ± 0%    4.93kB ± 0%     ~     (p=0.381 n=10+10)

name             old allocs/op  new allocs/op  delta
Parse-4              33.0 ± 0%      33.0 ± 0%     ~     (all equal)
ParseParallel-4      33.0 ± 0%      33.0 ± 0%     ~     (all equal)

However, due to the fact that we see consistent runtime improvements on /log4jscanner jar/testdata, that might be an indication that the benchmarks are not representative of either the data inside testdata, or the data we see in production.
Indeed, given the codepath I'm changing, I'd expect only nested jars to benefit (and it seems like this is fairly common in production).
To verify, I ran all the jars in testdata individually:
$ git checkout main
TMPDIR="$HOME/tmp/tmpdir"
mkdir "$TMPDIR" || true
for file in jar/testdata/* ; do
  RTMPDIR="$TMPDIR/$(basename $file)"
  mkdir "$RTMPDIR" || true
  ln -fv "$PWD/$file" "$RTMPDIR"
done
for commit in $(git log --pretty=oneline | head -4 | awk '{print $1}' | tac) ; do
  git checkout $commit
  go build
  dirs="$(echo $TMPDIR/* | tr ' ' ',')"
  hyperfine --ignore-failure --warmup 1 --parameter-list dir "$dirs" './log4jscanner {dir}'
  rm log4jscanner
done
 ...
 I'd have expected 400mb.jar to not be the fastest thing to run. But individually re-running it confirms it.
Most of these invocations take so little time that it's hard to show statistically significant improvements. So we'll just focus on the four slowest ones (next comment).

(Actually, let's just focus on the slowest one. I've verified that the others don't change in speed over the 4 last commits.)
The results for 400mb_jar_in_jar, which is the only case where runtime is noticeably changed:
Benchmark 1: ./log4jscanner /home/aktau/tmp/tmpdir/400mb_jar_in_jar.jar
  Time (mean ± σ):      1.484 s ±  0.326 s    [User: 1.448 s, System: 0.999 s]
  Range (min … max):    1.119 s …  2.087 s    10 runs

Previous HEAD position was 9d3acee Document commit that removed InitialContext
HEAD is now at 2932093 jar: close the zip.File reader before recursing
Benchmark 1: ./log4jscanner /home/aktau/tmp/tmpdir/400mb_jar_in_jar.jar
  Time (mean ± σ):      1.542 s ±  0.174 s    [User: 1.387 s, System: 1.076 s]
  Range (min … max):    1.245 s …  1.739 s    10 runs

Previous HEAD position was 2932093 jar: close the zip.File reader before recursing
HEAD is now at f6c1ebc jar: prefer io.ReadFull over io.ReadAll
Benchmark 1: ./log4jscanner /home/aktau/tmp/tmpdir/400mb_jar_in_jar.jar
  Time (mean ± σ):     441.6 ms ±  85.7 ms    [User: 355.1 ms, System: 112.7 ms]
  Range (min … max):   318.3 ms … 578.1 ms    10 runs

Previous HEAD position was f6c1ebc jar: prefer io.ReadFull over io.ReadAll
HEAD is now at 61ade2d jar: reuse buffers for nested .jar's
Benchmark 1: ./log4jscanner /home/aktau/tmp/tmpdir/400mb_jar_in_jar.jar
  Time (mean ± σ):     340.7 ms ±  57.9 ms    [User: 269.7 ms, System: 78.8 ms]
  Range (min … max):   298.8 ms … 481.4 ms    10 runs

Si I added a benchmark to test 400mb_jar_in_jar specifically, and the results now do show an improvement (first versus last commit):
benchstat 48d70bfb7e99a469832f21854710f7cddb3e17fd.bench 37376ef3d7fcb898fd5e192d12a2afe4718ffc33.bench
name                                  old time/op    new time/op    delta
Parse/400mb_jar_in_jar.jar-4             1.26s ±27%     0.27s ±10%  -78.51%  (p=0.000 n=10+10)
Parse/safe1.jar-4                       38.0µs ± 9%    43.4µs ±40%  +14.47%  (p=0.006 n=9+9)
ParseParallel/400mb_jar_in_jar.jar-4     1.40s ±26%     0.20s ±32%  -85.39%  (p=0.000 n=10+9)
ParseParallel/safe1.jar-4               33.0µs ± 8%    61.4µs ±11%  +86.03%  (p=0.000 n=9+9)

name                                  old alloc/op   new alloc/op   delta
Parse/400mb_jar_in_jar.jar-4            2.35GB ± 0%   0.05GB ±108%  -97.86%  (p=0.000 n=10+10)
Parse/safe1.jar-4                       4.92kB ± 0%    4.92kB ± 0%     ~     (p=0.810 n=10+10)
ParseParallel/400mb_jar_in_jar.jar-4    2.35GB ± 0%   0.02GB ±336%  -99.18%  (p=0.000 n=10+8)
ParseParallel/safe1.jar-4               4.93kB ± 0%    4.93kB ± 0%   -0.08%  (p=0.032 n=9+9)

name                                  old allocs/op  new allocs/op  delta
Parse/400mb_jar_in_jar.jar-4               102 ±11%        28 ± 8%  -72.43%  (p=0.000 n=10+10)
Parse/safe1.jar-4                         33.0 ± 0%      33.0 ± 0%     ~     (all equal)
ParseParallel/400mb_jar_in_jar.jar-4       180 ± 3%        39 ± 9%  -78.53%  (p=0.000 n=10+8)
ParseParallel/safe1.jar-4                 33.0 ± 0%      33.0 ± 0%     ~     (all equal)

And versus just the io.ReadAll -> io.ReadFull CL:
benchstat 48d70bfb7e99a469832f21854710f7cddb3e17fd.bench 4b23cd3db5400b191c5310c07415848bc0a2bb6d.bench
name                                  old time/op    new time/op    delta
Parse/400mb_jar_in_jar.jar-4             1.26s ±27%     0.30s ±17%  -76.18%  (p=0.000 n=10+9)
Parse/safe1.jar-4                       38.0µs ± 9%    40.3µs ± 8%   +6.15%  (p=0.028 n=9+10)
ParseParallel/400mb_jar_in_jar.jar-4     1.40s ±26%     0.35s ±45%  -74.81%  (p=0.000 n=10+9)
ParseParallel/safe1.jar-4               33.0µs ± 8%    32.2µs ±15%     ~     (p=0.243 n=9+10)

name                                  old alloc/op   new alloc/op   delta
Parse/400mb_jar_in_jar.jar-4            2.35GB ± 0%    0.42GB ± 0%  -82.14%  (p=0.000 n=10+10)
Parse/safe1.jar-4                       4.92kB ± 0%    4.92kB ± 0%     ~     (p=0.463 n=10+10)
ParseParallel/400mb_jar_in_jar.jar-4    2.35GB ± 0%    0.42GB ± 0%  -82.14%  (p=0.000 n=10+10)
ParseParallel/safe1.jar-4               4.93kB ± 0%    4.93kB ± 0%     ~     (p=0.159 n=9+10)

name                                  old allocs/op  new allocs/op  delta
Parse/400mb_jar_in_jar.jar-4               102 ±11%        30 ± 0%  -70.67%  (p=0.000 n=10+6)
Parse/safe1.jar-4                         33.0 ± 0%      33.0 ± 0%     ~     (all equal)
ParseParallel/400mb_jar_in_jar.jar-4       180 ± 3%        52 ±17%  -71.10%  (p=0.000 n=10+10)
ParseParallel/safe1.jar-4                 33.0 ± 0%      33.0 ± 0%     ~     (all equal)

Indicating that the regression in speed of the safe1.jar benchmark may be due to the garbage collector dealing with allocations from the other benchmarks [1].
[1]: Notice how some runs after the sync.Pool introduction allocate ~nothing:
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         299414355 ns/op        104883246 B/op        30 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  5         249801048 ns/op           11801 B/op         26 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         269324904 ns/op           12186 B/op         27 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         262044230 ns/op           12186 B/op         27 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         259753494 ns/op           12186 B/op         27 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         277134852 ns/op        104883246 B/op        30 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         279076490 ns/op        104883246 B/op        30 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  5         263421624 ns/op        83908649 B/op         28 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         264917986 ns/op           12186 B/op         27 allocs/op
BenchmarkParse/400mb_jar_in_jar.jar-4                  4         286430956 ns/op        104883246 B/op        30 allocs/op

The pool is not cleared between benchmark runs.

Okay, taking a step back...
A custom sync.Pool wrapper isn't something that I'm thrilled to maintain long term. Particularly since our internal response has wound down, and we have fewer cycles to work on this project :) We already hit performance oddities with this parser in the past, and I don't want to have to hunt down weird behavior or bugs.
What's the motivation here for this performance work?  Or is this strictly, just trying to improve the performance for its own sake? If it's the latter, I'm inclined to leave this as is.

A custom sync.Pool wrapper isn't something that I'm thrilled to maintain long term.

Removing comments, it's a tiny amount of LoC. At first I had it as a simple if-check on the "put" operation. This results in the same thing but I thought it looked more ergonomic with Get/Put. Most of the code is in the test.

Particularly since our internal response has wound down, and we have fewer cycles to work on this project :)

True, but this could well improve throughput for other users, too. For us internally, it was a bottleneck. See below.

We already hit performance oddities with this parser in the past, ...

Yes, performance seemed noticeably worse after the switchover to this version, though I wasn't able to pin down immediately why even when comparing profiles.

...and I don't want to have to hunt down weird behavior or bugs.

All new code carries the risk of bugs, that's true. If there's another test you'd like that provides stronger guarantees (also for future contributions), I could see whether I could do that.
Otherwise, I'll just leave this code here for others to potentially pull in.

What's the motivation here for this performance work?  Or is this strictly, just trying to improve the performance for its own sake? If it's the latter, I'm inclined to leave this as is.

In the last run we did internally, this was a noticeable bottleneck. This codepath was responsible for >50% of all allocations. Allocations by themselves are very costly in Go, but the more processors (GOMAXPROCS) given to a Go program, the more of a bottleneck this becomes as there are some global datastructures involved. For us, this was very large.
You're right that the response has wound down. But I assume others can benefit from this all the same.

Okay thanks for the reply! This lgtm then

Actually, I see that the commits make sense on their own. Will merge as is


Sunspot.commit doesn't seem to make any difference

Hi there,
I have a number of tests in both RSpec and Cucumber that are displaying the same behaviour.
When records are added, they show up in the DB, but for some reason no results are found in Sunspot. When I repeat the test manually everything works, so I'm happy that the code is ok. It would still be nice to get the tests working though!
As per the instructions, I am calling Sunspot.commit, but it doesn't seem to make any difference. I've checked and the Sunspot instance in definitely starting when the tests are running as it should.
It's hard to debug this one as there aren't any error messages, it just doesn't give the expected result.
A very abbreviated version of my Gemfile is below
gem "rails", "~> 3.1.1"
gem 'mysql2'

gem 'sunspot', '1.2.1'
gem 'sunspot_rails'
gem 'sunspot_test'

group :development, :test do
  gem "mongrel"
  gem "rspec-rails"
  gem "capybara"
  gem 'ruby-debug'
  gem 'database_cleaner'
  gem 'factory_girl_rails'
  gem 'cucumber-rails'
  gem 'ci_reporter'
  gem 'autotest-rails'
  gem 'launchy'
  gem 'email_spec'
  gem 'shoulda-matchers'
end

And below is an example of a failing test.
Background:
  Given I am an anonymous user
  And I am on the home page
  And there is 1 private article in the database
  And the sunspot index is up to date

Scenario: Searching for public article
  Given there is 1 public article in the database
  And the sunspot index is up to date
  When I fill in "search" with "Public"
  And I press "search_submit"

  Then there should be 2 articles in the database
  And there should be 1 public article in the database

  Then I should see "Found 1 result"
  And I should see "Public"

The test fails on the "Found 1 result" line.
Cheers,
Graeme

That was it!
Thanks, and apologies if I'm guilty of not reading the manual. Out of interest, how do you do this for RSpec?
Graeme

using RSpec tags notice the :search => true in the following code followed by the explicit Sunspot.commit
describe "some search thing", :search => true do
  it "searches" do
    book = Factory(:book, :title => "Of Mice and Men")
    Sunspot.commit
    Book.search { keywords "mice"}.results.should == [book]
  end
end


charts: change xenon tag of helm version #172

What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #172
What this PR does?
Summary:
xenon image tag of helm version:
radondb/xenon:1.1.5-alpha -> radondb/xenon:1.1.5-helm
Special notes for your reviewer?

operator version is still radondb/xenon:1.1.5-alpha


fix screen position for server / login / forgot password & mfa

Summary
Fixes the scrolling of the contents of the following screens on iPhone, iPad & Android as part of broken window fixes

Server
Login
Forgot password
MFA

Ticket Link
https://mattermost.atlassian.net/browse/MM-56150
Fixes: #8291
Release Note
NONE

@matthewbirtch is not related to this PR but here is the thing, I can tell you for a fact that enforcing the MFA before the user has logged in, on mobile is not implemented, so the server will return the error and the mobile app will not handle it by requesting the MFA from the user. so you can try it if you enable MFA before logging in.
Yes, we should create a ticket when MFA is enforced after the user has logged in.

https://mattermost.atlassian.net/browse/MM-61834

@matthewbirtch is not related to this PR but here is the thing, I can tell you for a fact that enforcing the MFA before the user has logged in, on mobile is not implemented, so the server will return the error and the mobile app will not handle it by requesting the MFA from the user. so you can try it if you enable MFA before logging in.
Yes, we should create a ticket when MFA is enforced after the user has logged in.

Yep, confirmed I was able to test the MFA token screen now after going through he MFA setup on webapp first.
I'll create a ticket for adding this MFA setup screen to the mobile flow.


Add first availability

It would be very helpful if you could add from which version on specific features are available.
E.g. to unhide page parts, you need BC 16 at least: https://docs.microsoft.com/en-us/dynamics365-release-plan/2020wave1/dynamics365-business-central/unhide-parts-page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc9174f7-cad5-7550-b93b-036158d40e38
Version Independent ID: 8e4dabaa-c112-6a2e-dc18-933253579927
Content: Personalizing Pages - Business Central
Content Source: business-central/ui-personalization-user.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello Natalie,
Thank you for your feedback! The content on Docs.microsoft.com generally reflects the latest version of Dynamics 365 Business Central unless a different version is explicitly specified. I'm leaving this Issue open for a couple of weeks, because I'm heading out on vacation, and might accidentally think about your feedback and come up with a solution, because you're not the first to ask.

Okay, then have a great vacation 🙂

Please compare with https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-table-object#systemid :-)

I'm closing this loop now after 2 years because I believe we have, generally speaking, become better at stating when something became available. However, in the business functionality content, it's less straightforward than in the dev/admin docs, because most changes are a tiny edit to existing content or an alternative to existing functionality that will exist side-by-side for a while.
If you disagree, then do let the team know :-)


feat: rearrange order of tabs

Maps to what is probably the most common user flow:
[ Receive -> Jam / Earn -> Send ]

I updated the cheatsheet to represent this order. also shorten the schedule description and finished the list with a checkmark to underline, that the list ends here.
https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/?node-id=2850%3A67638

I updated the cheatsheet to represent this order. also shorten the schedule description and finished the list with a checkmark to underline, that the list ends here.
https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/?node-id=2850%3A67638

Nice, can you put this into an issue for v0.0.6 so we can keep track of it? 🙏


debootstrap download sed fail

Choose an encryption passphrase for xenial:
Please confirm your passphrase:
Generating keys (move the mouse to generate entropy)...
done
Installing xenial-amd64 chroot to /usr/local/chroots/xenial
Downloading latest debootstrap...
Download from Debian gitweb failed. Trying latest release...
2017-03-10 23:39:18 URL:http://cdn-fastly.deb.debian.org/debian/pool/main/d/debootstrap/ [888/888] -> "-" [1]
Failed to download debootstrap.
Check your internet connection or proxy settings and try again.

debootstrap download fails when creating a chroot
As It’s downloading 888/888 and manually wget’ing the url succeeds, the reason is probably in the wget coming after that. The /installer/ubuntu/bootstrap script pipes the html file into sed, but that html is encoded utf-16, so running
wget -O- --no-verbose --timeout=60 -t2 "http://httpredir.debian.org/debian/pool/main/d/debootstrap/" \
            | sed -ne 's ^.*\(debootstrap_[0-9.]*.tar.gz\).*$ \1 p'

actually fails. For converting utf-16 to utf-8 normally iconv is used, but that’s not available.

All,
A fix had been merged now that seems to address the debootstrap problem.
You can do a quick test with something like the following: crouton -r xenial -d -f xenial.bs
If that completes successfully then you can use the '.bs' bootstrap file to install your new chroot with something like this: sudo sh ~/Downloads/crouton -n xenial -f xenial.bs -t ....
Please re-open this issue if it's not fixed and give us some more details.
-DennisLfromGA


[Feature] 增加一个配置，可以传入js代码

希望在设置中添加一个输入框，可以用户自定义插入js代码。
方便在web端放入类似Umami的探针，记录网络请求数据。

自己改代码就行了，就一行，还不影响你自动同步。

You can also implement it in gateway. e.g. Nginx sub_filter_types sub_filter directive.

You can also implement it in gateway. e.g. Nginx sub_filter_types sub_filter directive.

I try to use a sub_filter.
       sub_filter '' '';
       sub_filter_once off;
       sub_filter_types text/html;

But it didn't work.

You can also implement it in gateway. e.g. Nginx sub_filter_types sub_filter directive.

This method is OK!!! Thanks


Add bodies of water to overworld

The overworld should have bodies of water.

Deep brown hot cocoa pools

Fix cliff sides
Texture cocoa pools
Animate cocoa pools

The overworld now supports water. It will be featured in the new "Cannoli Sandbar" area and can easily be incorporated into earlier areas as well.


vsphere-iso support

Do you think on integrating vsphere-iso support?
https://www.packer.io/docs/builders/vmware/vsphere-iso#http-directory-configuration

@mayn are you still trying to maintain this repo? I'm currently in the process of updating my fork of this project and I was looking to introduce the request here, along with reaching parity with packer 1.6.0.

@DrJZoidberg  if people are using it, ill maintain it. got distracted / discouraged w/ 1.4.x/1.5.x changes. sorry 😞
probably better if i do a series of incremental updates. If you are interested in this feature and want to pr it, i'm open to review it.

@DrJZoidberg if people are using it, ill maintain it. got distracted / discouraged w/ 1.4.x/1.5.x changes. sorry 😞
probably better if i do a series of incremental updates. If you are interested in this feature and want to pr it, i'm open to review it.

lol no need to apologize. I'll look at starting the series of PRs.


Update LICENSE

Hello you did not provide any description, we have closed your PR as licence file is maintained by the club gamma team anyway :)


Node-hosted metrics

As an ELIXIR Node, I want to be able to keep metrics data in my own premises

This requires a distributed design which was discussed during TMD-Tango hackathon 2023 but was considered too complex to tackle during that period.
Some issues were raised, including implications of GDPR, data ownership and data transfer, that require clarification.
Concerns raised and alternatives discussed include:

How data should (or not) be exchanged between different instances of Tango. Both alternatives require a list of known Tango instances or a protocol for self-discovery. Alternatives:

The reporting interface (front-end) directly collecting data from different Tango (back-end) servers
Tango servers (back-end) collecting data from each other (without persistence)

How to resolve/group events organized by multiple nodes - requires a shared unique identifier
Need for additional access control mechanisms (Node-only or internal/private data vs Public data)
Node specific customizations - see also #8
Self-hosting (decoupled or federated) documentation


ShedLock not lock when Sleuth is present

Read the documentation
Read the documentation, especially the troubleshooting section.
We have an application that use ShedLock, and in same app have config spring-cloud-sleuth, however, by default lock doesnt work because on class SpringLockConfigurationExtractor expect an instance of ScheduledMethodRunnable. I add the question to  stackoverflow  here:
https://stackoverflow.com/questions/58973889/shedlock-not-lock-when-sleuth-is-present/58978881#58978881
For now we set the intercept to proxy-method and its working, however, we dont know if this change will have side effects.

Hi, thanks for feedback. Proxy-method will indeed fix the issue for you (it's described at the end of the documentation, there should not be any unintended side effects) In fact, I will most likely make it the default option, to prevent issues like the one you have encountered.

Version 4.0.0 uses PROXY_METHOD by default. Unfortunately, there is no other way I can work around Sleuth.


add variant

figure out best way to add variant information. Probably it is not a great idea to try to do this automatically with all of the various ways of representing variants, but perhaps we can cover some common cases.

done


Error in podspec

v1.5.0 ObjectMapper.podspec file is pointing to wrong version -> "s.version = '1.4.0'"

1.5.0 doesn't seem to be available in the master spec repository at all.

Sorry about that, I just pushed 1.5.0 to cocoapods.


Revert "Remove fields from api_pb2.Image that are no longer used by the server (#2531)"

Still used in unexpected location.

@prbot approve

@prbot automerge


Add isaaclevin.presencelight 3.0.19.yaml

Added latest version of presence light.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

I got it, thanks!

On Sep 2, 2020 at 5:59 PM,  <msftbot[bot] (mailto:notifications@github.com)>  wrote:
Hello  @KevinLaMS (https://github.com/KevinLaMS)!
Because this pull request has the  Validation-Completed  label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.
p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more  here (https://github.com/microsoft/fluentui/wiki/Advanced-auto-merge).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,   view it on GitHub (https://github.com/microsoft/winget-pkgs/pull/3407#issuecomment-686051195), or   unsubscribe (https://github.com/notifications/unsubscribe-auth/ANNLE3CL3N35PT7RUJB2QX3SD255HANCNFSM4QT2KIQQ).

Join me on Snibble, the social video app. https://apps.apple.com/us/app/snibble/id1464594506?ls=1
“GoodLand”

https://images.unsplash.com/photo-1546839535-2e8e927fb5ae?ixlib=rb-1.2.1&q=80&fm=jpg&crop=entropy&cs=tinysrgb&dl=jakob-owens-YoI8fp-xEN0-unsplash.jpg
Shared via the Google app
“GoodLand”


Support for 2.5d sprite

Can we make sprite rotationX, rotatonY, rotationZ, and x, y and z

Not in v4, maybe in v5.

Ok, thanks, can you put in to-do of v5, actually I really hope you guys can make it in v4.5 or provide a plugin:)

hey guys, just wondering if there are any branches or experiments inside or out of pixi relating to this? It would be great to have some 2.5d support, thanks

https://github.com/pixijs/pixi-projection
There's a hope that i'll port my 3d sprites from ]old 3d fork](https://gameofbombs.github.io/pixi-bin/index.html?s=flip&f=cards.js&title=Cards) to this plugin.

v5 baby!

I did my own in my project too, it is webgl only


bridges | Incomplete Implementation of Rotation

IMPORTANT: This is incomplete and will be updated further
Motivation
closes #198
Rotation is an essential feature for the game.
How does it work/Problems
Upon pressing the rotation button ("R") the animal sprite in the drag is rotated clockwise at 90°. Godot does not have an internal way of elegantly doing this. The rotation of T-Rect does not properly work for some sprites, while it does for others. If the sprite is originally square shaped (like the deer) using the internal rotation does weird things that cannot be easily fixed with an offset and reflection, while for rectangular sprite (like the squirrel and snake) the rotation is necessary. This leads to complications that have been mostly fixed, in effect much has to be hard coded and experimented with.
is_allowed obviously also needed major updating. This essentially just boils down to properly adjusting for matrix operations, i.e. checking the correct squares. This works but is most likely not bug free.
update_grid is the major problem and does not work properly. The tiles have to have alternative tiles as to be correctly displayed. This is tedious leg work with much testing. Further implementing the correct orientation for all the tiles is hard, especially because the orientation should change what tiles became ALLOWED, SIDE etc. This is honestly such a mess that it might be worth exploring just implementing a grid for each animals that just displays where goes what and then implementing matrix operations in godot. This is not something I will not do until Tuesday, but it might be necessary in the future.
What works
Displaying the rotation works:
https://github.com/mango-gremlin/arch-enemies/assets/65815628/4f46b1ba-31bd-4868-8d09-73efa7a4966a
The game also checks mostly correctly if the rotated body is allowed to be placed. (This cannot be elegantly shown with a video because the cursor doesn't always update nicely, just believe me)
Some placement for rotated animals work:
https://github.com/mango-gremlin/arch-enemies/assets/65815628/6b03e702-be72-431b-8a24-8a1d179cda6f
What doesn't work
For some animals the rotated placement has not been implement or does not work properly. This has to be worked one, but the code is just very tedious.
Additional Information
This is the biggest feature effort wise (in my opinion). Until Tuesday a functioning demonstration should work but I cannot promise it will be bug free. Further updates will be made but given how complex this one is because of the amount of hard-coding an unfinished update seems helpful for reviewing.

Since we are planning not to implement this at all, should we close this pr, but keep the branch for now?


Palindrome Number

Is your feature request related to a problem? Please describe.
Add a program to check if a number is palindrome or not.
Describe the solution you'd like
I want to add this program in Java
eg. 121 is a palindrome number as it is same both forwards and backwards
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
I'm an LGM SOC participant, I would like to work on this . Please assign it to me.
Programming language

[ ] C
[ ] C++
[x] Java
[ ] Python

can I do it in c++

can i do it in python?

I can do it in C and C++
Assign me, I'm LGMSOC participant

I am LGMSOC participant can i do it in python and C ?
if yes kindly assign it to me

Hey @Ayush7614  please assign me this in C language under Lgmsoc'21

I can do this in c++.
kindly assign me

@TasnimAnas do in C

@Amit366 check PR #613

@Amit366  pr #614

Hey @Amit366 can i work on this issue using java

Hey @Amit366 i would like to work on this issue using java and I'm an LGM SOC participant, I would like to work on this . Please assign it to me.

@viki4545 this issue is already assigned

you have reopened this issue that is why i was asking to do in java

@viki4545 it is already assigned please see

Sry, its ok no problem


pass arguments with run_viz magic method

Description
I just want to run run_viz with --host <IP_ADDRESS> option.
Context
there is no auto-reload option. so just %reload_kedro and %run_viz in notebooks are very easy to see my visualized pipeline.
but I run kedro in a docker container in a remote server, so the host option should not be the default <IP_ADDRESS>.
Checklist

[ ] Include labels so that we can categorise your feature request

BTW, CONTRIBUTING.md says put label Enhancement, but I can't and automatically put Feasture Request. It's no problem, isn't it?

Hi, am I correct that you want to know how to pass host args in your docker container? This is from Kedro-Docker, but does this instruction help? https://github.com/quantumblacklabs/kedro-docker#running-kedro-docker-with-kedro-viz

thanks! but is it any different than docker exec {CONTAINER_NAME} kedro viz --host <IP_ADDRESS>?
Yes, just docker exec will works. I can pass any options.
It's a little pain to re-run the above command when I fix some code in a notebook.

Or maybe What I really want is auto-reload feature.

Closing this, but if you would like to contribute the auto-reload feature, you are welcome to work on it in Kedro side :)


Issue with Audio extension

Unfortunately there's not enough to go from on this bug. Could you please provide more context on what the issue is?

Closing due to inactivity.


Android Handler Async API

I think that performance can be improved by adding an API that can use Message#setAsynchronous() and Handler.createAsync().
https://medium.com/@sweers/rxandroids-new-async-api-4ab5b3ad3e93

@greenrobot Is there any plan to apply it?

Thanks, I also saw this. Maybe this is worth looking into. -ut


Add error handling

The style of error handling was inspired by https://michael-f-bryan.github.io/rust-ffi-guide/errors/index.html it holds errors in local thread storage and exposes functions last_error_message and last_error_length to access the messages over FFI. All functions return POSIX style return codes:

null for references
-1 for longs and lengths

There are couple of things to consider:

[ ] making it completely panic free by catching all errors using std::panic::catch_unwind checkout https://doc.rust-lang.org/nomicon/ffi.html#panic-can-be-stopped-at-an-abi-boundary but this seems like an overkill for non safety critical app
[ ] if there is any possibility that some code will ever check the error messages from other thread than the one that resulted in the problem itself?

Closes #3

I guess catch unwinding might be necessary in context of encapsulation/decapsulation if the code might possibly panic there, do you think it is possible?

I guess catch unwinding might be necessary in context of encapsulation/decapsulation if the code might possibly panic there, do you think it is possible?

It doesn't look like there are panics on the code paths we use in the ohttp crate, but it is probably a good thing to catch them just in case.


Instrumentation worker ffi

What does this PR do?
Add a ddtelemetry-ffi crate that exposes a FFI to submit telemetry data.
The telemetry bindings support:

Setting up, and staring a background telemetry worker that will collect and send telemetry data.
Send dependencies to this background worker
Send logs to this background worker

This ffi code includes macro_rules that generate accessors for rust on structs. For these accessors to be processed by cbindgen, we beed to use the nightly version of the toolchain.
Things that are not included, but plan to add in further PRs:

Generating an artifact for the telemetry library in the build-script
FFI usage examples
Telemetry metrics sending support

Motivation
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Congratz on landing this 👏


Depth First Traversal in C++

Given a connected undirected graph. Perform a Depth First Traversal of the graph.
Note: Use recursive approach.
Input:
The first line of the input contains an integer 'T' denoting the number of test cases. Then 'T' test cases follow. Each test case consists of two lines. Description of testcases is as follows: The First line of each test case contains two integers 'N' and 'E'  which denotes the no of vertices and no of edges respectively. The Second line of each test case contains 'E'  space separated pairs u and v denoting that there is a edge from u to v .
Output:
For each testcase, print the nodes while doing DFS starting from node 0.
Your task:
You don't need to read input or print anything. Your task is to complete the function dfs() which takes the Graph and the number of vertices as inputs and returns a list containing the DFS Traversal of the graph starting from the 0th node.
Expected Time Complexity: O(V + E).
Expected Auxiliary Space: O(V).
Constraints:
1 <= T <= 100
2 <= N <= 104
1 <= E <= (N*(N-1))/2
Graph doesn't contain multiple edges and self loops.
Example:
Input:
2
5 4
0 1 0 2 0 3 2 4
4 3
0 1 1 2 0 3
Output:
0 1 2 4 3
0 1 2 3
Explanation:
Testcase 1:
0 is connected to 1 , 2 , 3
1 is connected to 0
2 is connected to 0 and 4
3 is connected to 0
4 is connected to 2
so starting from 0 , dfs will be 0 1 2 4 3.

Thanks for your contribution.

GREAT JOB!


fix: Ambiguous implicit for automatic refinement

Closes #74
@gvolpe, can you confirm this PR solves your problem?

Confirmed, it fixes it 👍🏽
And I already know how to fix for the Cats instances issues, will submit a PR after work :)


Link to specs from concept pages

I keep finding myself situations like this:

I want to write a .yaml, but I don't know how to spell the thing I'm trying to write
I search for "kubernetes [thing] spec" (for this example, "pod"
The top result is https://kubernetes.io/docs/concepts/workloads/pods
The next few results are more information about pods
The fifth link down is "Kubernetes API Reference Docs", for version 1.26
I manually change the link to 1.29
I scroll down in the sidebar until I find Pod (in this case it doesn't actually need scrolling)
Finally, I am at https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#pod-v1-core, where I wanted to be

I get that the purpose of the concept pages isn't to provide the kind of exhaustive reference that the references, and I don't want the pages themselves to change. What I do want is a link at the beginning of the concepts pages, linking to the relevant part of the reference. For example:

Pods
Pods are the smallest deployable units of computing that you can create and manage in Kubernetes.

Or perhaps more explicitly:

Pods

For the full specification of allowed keys, check the reference

Pods are the smallest deployable units of computing that you can create and manage in Kubernetes.

Or maybe it'd be better to link to https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/ instead -- I don't have any issue with those docs, but they're consistently harder to get to because they never show up in search results, so I have to go to the sidebar, click "References", remember which category the thing is in, and go from there. In contrast, the generated docs have a sidebar listing all the types directly, and it's first in the Ctrl+F order.
(P.S. apologies for not using the template mentioned in the contributing guidelines -- when I click the link it takes me to the "new issue" page, which presents me with just... a blank textbox.)

In most of the concept pages, there is already mention of the corresponding API reference in the "What's Next?" section. For instance, on the Pod concept page:

Pod is a top-level resource in the Kubernetes REST API. The Pod object definition describes the object in detail.

/priority awaiting-more-evidence

/language en

Additionally, it might worth looking into the SEO of the reference page to address why version 1.26 is appearing in search results instead of the latest version, 1.29. This could help ensure users are directed to the most up-to-date information.

Oh, neat! But this is it in context:

It's not useful to anyone trying to find the reference; it's at the very end of the page, hidden in the middle of a block of visually identical items mostly about other resources or concepts, not linking to the resource page. It's useful to people who've just read through the entire page and are looking for more details, sure, I don't have an issue with it staying there, but it doesn't really address my desire to easily and quickly get from the concept page to the reference.
If there's a strong desire to keep this link at the end of the page for some reason, it could at least be given its own section so it shows up in the sidebar:

You can read more about probes in the Pod Lifecycle documentation.
Reference
For the resource specification, refer to the Pod object definition.
What's next
Learn about the lifecycle of a Pod.

On SEO: I agree, but it's not a subject I know anything about so I chose to skip it. Perhaps the better choice would be deemphasizing all of the /generated pages and working to make the /kubernetes-api more prominent? Though it's not like I'd know how to do that any better than prioritizing a specific version.

@nic-hartley this is almost a duplicate of https://github.com/kubernetes/website/issues/38682 and directly duplicates https://github.com/kubernetes/website/issues/24441
/triage duplicate
If anyone wants to work on https://github.com/kubernetes/website/issues/38682, the first task to pick up is: https://github.com/kubernetes/website/issues/43832
If anyone wants to work on https://github.com/kubernetes/website/issues/24441, see https://github.com/kubernetes/website/issues/24441#issuecomment-1369869293

/remove-priority awaiting-more-evidence

Additionally, it might worth looking into the SEO of the reference page to address why version 1.26 is appearing in search results instead of the latest version, 1.29. This could help ensure users are directed to the most up-to-date information.

See https://github.com/kubernetes/website/issues/25505 for our longer term intent here.

@sftim I didn't find t#24441 while searching, fair enough. Though given that it's been four years, the issue has been repeatedly re-closed, and the only substantive discussion on it happened in a Slack I don't have access to, I don't feel particularly qualified to submit a PR for it.
Specifically regarding fact-sheets: I do hope that the plan isn't to wait on adding simple links just because a complex fact sheet format hasn't been added yet. The fact sheets can always just replace the reference links; it's not like it'd be problematic for documentation readers to go from

Pods

For the full specification of allowed keys, check the reference

Pods are the smallest deployable units of computing that you can create and manage in Kubernetes.

to

Pods

Factsheet

Reference: Pod v1 core
whatever other items

BTW, the simple links are tracked as https://github.com/kubernetes/website/issues/24441, and they can land whether or not we have fact sheets designed.

@sftim Yep, I saw. But I couldn't see the discussion around 24441 because it's in a Slack I don't have access to so I'm just kinda blindly hucking my $0.02 in.


Consider parsed version number from issue title

If loaded manifest and version parsed from issue title does not match post some comment Latest version of manifest is <ver>. You reported different version. Please run scoop update and then try again.

if ($problematicVersion -ne $Manifest.Version) { Add-Comment '...'; Close-Issue }


J4-dmenu-desktop with options doesn't seem to work

  key({ mod4 }, "period", util.program.spawn_once("j4-dmenu-desktop --no-generic --term="termite" --dmenu="dmenu -f -nf '#ffffff' -nb '#000000' -sb '#d32f2f' -sf '#ffffff' -i -fn 'Noto Mono'"")),
is my dmenu command, which works fine on i3
bindsym mod4+period exec --no-startup-id j4-dmenu-desktop --no-generic --term="termite" --dmenu="dmenu -f -nf '#ffffff' -nb '#000000' -sb '#d32f2f' -sf '#ffffff' -i -fn 'Noto Mono'"
on way-cooler it tells me
SyntaxError("[string \"chunk\"]:69: \')\' expected near \'termite\'")
unless i'm missing something, it doesn't seem to work.

key({ mod4 }, "period", util.program.spawn_once("j4-dmenu-desktop --no-generic --term="termite" --dmenu="dmenu -f -nf '#ffffff' -nb '#000000' -sb '#d32f2f' -sf '#ffffff' -i -fn 'Noto Mono'"")),

Is it just me or do you have an extra " in there at the end.
 Since this is a string in Lua, you need to escape them with \". So your command will be:
key({ mod4 }, "period", util.program.spawn_once("j4-dmenu-desktop --no-generic --term=\"termite\" --dmenu="dmenu -f -nf '#ffffff' -nb '#000000' -sb '#d32f2f' -sf '#ffffff' -i -fn 'Noto Mono'")),

Just checked, no extra quote.
But yeah that was the problem... thank you, sorry, about that.


python310Packages.mechanicalsoup: 1.1.0 -> 1.2.0

Description of changes
https://mechanicalsoup.readthedocs.io/en/stable/ChangeLog.html#version-1-2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 191786 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.hangouts
python310Packages.hangups
python310Packages.mechanicalsoup
python39Packages.hangups
python39Packages.mechanicalsoup

Result of nixpkgs-review pr 191786 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.hangouts
python310Packages.hangups
python310Packages.mechanicalsoup
python39Packages.hangups
python39Packages.mechanicalsoup


Add argument for Guppy "chunks_per_runner"

In testing buttery-eel with some BLOW5 data for basecalling, I realized that there is no "--chunks_per_runner" argument that could be set and passed through to Guppy.
Is this something that could be easily added to a future release? I had originally tuned Guppy performance with the chunks_per_runner parameter, as opposed to changing chunk_size or max_queued_reads, and being able to set that to the same as my previous runs would allow for direct comparison of basecalling times between buttery-eel and Guppy.
On a related note, is basecalling with buttery-eel using BLOW5 expected to be quicker than native Guppy/FAST5?
Thanks!

Hey,
I'm currently working my way through an update, so I can certainly make sure that --chunks_per_runner is one of the flags that can be accessed.
Any other options you would like to see while I'm at it?
As for performance, fast5/HDF5 is always going to be slower than slow5 if you are IO bound. So if you were using a fast model, slow5 is much faster than fast5. (even with only single threaded slow5 sequential access). Once you get to GPU bound models like HAC and SUP, it's more about the GPU you are running and how many. On the plus side, using this method with slow5 will populate all GPU resources, so that' helps, and then IO won't ever really be an issue either as you scale that.
So short answer, yes, but it depends, lol.
I hope this answers your question, and expect an update soon (a week or so) for the new options.
James

Hi James,
Thanks for your quick reply!
--chunks_per_runner is probably the main flag I'd use in this context. I also use a lot of the demultiplexing and primer/adapter/barcode trimming features of guppy_basecaller, but I imagine that the buttery-eel wrapper was really just designed with basecalling in mind, and that demuxing would be done downstream with guppy_barcoder. Otherwise it quickly becomes a lot of flags to add.
Thanks for the performance info. We use the SUP model usually on our A100 GPUs, so I do think we are still GPU-bound in the end - so in that case I shouldn't expect any big performance gains by basecaling with blow5. However something I noticed when scaling up to 3x or 4x A100 is that I start to become IO bound. Could be interesting to compare fast5/blow5 on these multi-GPU systems. I'll probably do this sometime in the next week or so, and will add a new tab to my benchmark data here for comparison.
Michael

@mshamash Looking at your results, I guess that BLOW5 will benefit the A100s significantly for FAST and HAC models and only slightly for SUP.
What I observed on Tesla V100 GPUs on a spinning disk NAS mounted over NFS for HAC model (dataset had 500,000 reads):

GPUs
FAST5 time (minutes)
BLOW5 time (minutes)

1
69
59

2
64
32

3
64
23

4
65
20

These results are however based on BLOW5 directly integrated to Guppy at C++ level (which we have access to through dev license). I would expect buttery-eel to perform similarly at least closely.

hey @mshamash,
I've got a fresh update on the dev branch which allows for most options to be parsed to guppy. So if you give it --chunks_per_runner it should know exactly what you are doing and work with it.
 So no alignment or barcode demux options just yet, but working on that now.
When I've finished these other additions I'll cut a version on main, but thought i'd give you a chance to checkout a preview if you were keen.
here is the specific working commit (in case more recent commits make the dev branch unstable)
https://github.com/Psy-Fer/buttery-eel/commit/e23521363af082d14fcf9da8b8cee57718f64f9e

James


Fix: Resources should be closed

Java 7 introduced the try-with-resources statement,
which implicitly closes Closeables.
Fixes sonar rule squid:S2095

Coverage increased (+0.003%) to 46.871% when pulling 176a0d77522e6c69099f01cff0a1c88568fabc19 on sepe81:fix-close-resources into ef361b1bd0a2be5412353715960223f65f9ee51b on apache:master.

👍

LGTM 👍


Zigbee and Zwave servers + Node Red + Camera

Describe The Bug
@donavanbecker @bwp91 @NorthernMan54
Are Homebridge and Homebridge UI abandoned projects?
Nothing has been happening for some time:

no new updates
new PRs not merged
you do not respond to reported errors

I realize that this is a big project and I see that only a few people really contribute to develop it. Maybe it's time to change it somehow, improve this process?
Unfortunately, I also have the impression that a similar phenomenon applies to many plugins - have simply been abandoned.
Logs
No response
Config
No response
Homebridge UI Version
4.55.2-beta.15
Homebridge Version
1.7.0
Node.js Version
20
Operating System
Official Homebridge Raspberry Pi Image
Environment Info
None
Raspberry Pi Model
Raspberry Pi 4 B

Oh, I just hit and my thread has a round number - 2000 🥳

@mkz212 personally I’m on a a few month vacation so have limited access to GitHub etc.  so my contributions will be minimal for the near future.
but when you look at homebridge itself, the code base is mature, and Apple has not released anything recently triggering us too make updates.  And that is what you’re seeing.
With plugins as they are community developed and supported by the individual developer. So they are a mixed bag.  With the Verified program we are attempting to restrict the verified flag to only those with support so they should be better.

@NorthernMan54
Thanks for the reply. I was worried that the project had been abandoned.
As for what you write that Apple has not changed too much lately, it's a fact. That a lot is expected to change with the next release.
As for the development of Homebridge and Homebridge UI itself, I think it has a lot of untapped potential and it is easy to fix it:

Zigbee2mqtt server should be as easy to install as deConz / Phoscon (just open hb-config, go to Extra Packages and select Instal deConz), or even should be pre-installed in Rasbian Image
the same should be an easily accessible Z-wave server
the same Node-Red automations
the same Camera UI
These 4 servers should have their links in the Homebridge menu

As the developer of the integration to node-red, I feel strongly about the power of node-red automations.  But is your average Homebridge user prepared to leverage it effectively ?
PS My home is esp based with a mix of tasmota and other devices, so Zigbee and Z-Wave are not a personal priority, but it may be for others?

I think Homebridge's essence is to provide support for:

cameras that do not support HSV (Camera UI)
creating virtual switches for automation purposes in Apple Home (Dummy Switch or Delay Switch)
Integration of plugins running via WiFi or in the cloud (plugins)
Adding Zigbee devices (including Matter and Thread) (Zigbee2mqtt)
Adding Zwave devices

With all this, Homebridge would be the best and most powerful hub.
P.S.: Not everyone knows but for example Hub Aqara only supports Aqara devices, etc. It is not that every Zigbee device works with every hub - that's why Zigbee2mqtt is so good because it supports different manufacturers.

@NorthernMan54
Thanks for the reply. I was worried that the project had been abandoned.
As for what you write that Apple has not changed too much lately, it's a fact. That a lot is expected to change with the next release.
As for the development of Homebridge and Homebridge UI itself, I think it has a lot of untapped potential and it is easy to fix it:

Zigbee2mqtt server should be as easy to install as deConz / Phoscon (just open hb-config, go to Extra Packages and select Instal deConz), or even should be pre-installed in Raspbian Image
the same should be an easily accessible Z-wave server
the same Node-Red automations
the same Camera UI
These 4 servers should have their links in the Homebridge menu

No, they shouldn't. They're arbitrary selections. Leave each project to do what it does best. You never know what other projects choose to do, or not, or evolve, or not. If someone wants to create a meta FAQ or wiki, terrific. But this instinct of "change for change's sake" and "links just because some find it useful" is the path to cruft and UI/UX/documentation confusion.
Keep it simple. 😄
That's what's made this project successful, the unix movement successful, and is good governance.

@NorthernMan54
Thanks for the reply. I was worried that the project had been abandoned.
As for what you write that Apple has not changed too much lately, it's a fact. That a lot is expected to change with the next release.
As for the development of Homebridge and Homebridge UI itself, I think it has a lot of untapped potential and it is easy to fix it:

Zigbee2mqtt server should be as easy to install as deConz / Phoscon (just open hb-config, go to Extra Packages and select Instal deConz), or even should be pre-installed in Raspbian Image
the same should be an easily accessible Z-wave server
the same Node-Red automations
the same Camera UI
These 4 servers should have their links in the Homebridge menu

No, they shouldn't. They're arbitrary selections. Leave each project to do what it does best. You never know what other projects choose to do, or not, or evolve, or not. If someone wants to create a meta FAQ or wiki, terrific. But this instinct of "change for change's sake" and "links just because some find it useful" is the path to cruft and UI/UX/documentation confusion.
Keep it simple. 😄
That's what's made this project successful, the unix movement successful, and is good governance.

After all, I haven't written anywhere about combining it into one big project. Each server would be separate as it is now but:

easy to start / install
in Homebridge UI, a link to each server (only for these enabled), the link, not iframe, not implementing server into Homebridge UI etc., only link.

I didn't write that you advocated combing it all into one project.
I did write that we should not be linking to any other project. And I maintain the position that I wrote.
If you're advocating (which I understand you are) that there be links to other projects from Homebridge (either the site, or the webUI), as I've stated above: no. Again - you may think this is a helpful addition, but I do not. It is counterproductive and an unnecessary distraction for the development team to maintain. This type of stuff belongs with a passionate individual(s) who want to maintain a meta-FAQ or HOWTO. Not links in the software we maintain and document.

I didn't write that you advocated combing it all into one project.
I did write that we should not be linking to any other project. And I maintain the position that I wrote.
If you're advocating (which I understand you are) that there be links to other projects from Homebridge (either the site, or the webUI), as I've stated above: no. Again - you may think this is a helpful addition, but I do not. It is counterproductive and an unnecessary distraction for the development team to maintain. This type of stuff belongs with a passionate individual(s) who want to maintain a meta-FAQ or HOWTO. Not links in the software we maintain and document.

But you will surely agree that easy installation of these servers would not hurt anyone? By easy installation I mean E.G. dedicated one simple command in the terminal. Then everyone will easily launch what they want and need.

I do not agree. Easy installation of Homebridge - which already exists in multiple forms - is the North Star. You can install an RPi image, you can install via NPM, and you can install via preexisting repos that we maintain. That's more the sufficient and already covers the overwhelming majority of the community.


Add support for restoring from snapshot with search replicas

Description
In this PR we are adding,

Support for restoring search replicas from a snapshot taken with search replica
Add validations to ensure compatibility between DOCUMENT and SEGMENT replication type while snapshot restoration. Following are the allowed rules:

Snapshots taken when the replication type is DOCUMENT can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added.
Snapshots taken when the replication type is SEGMENT and without any search replicas can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added.
Snapshots taken when the replication type is SEGMENT and with search replicas can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added. If we are restoring to DOCUMENT type search replica count must be set to 0 in the settings.

Related Issues
Resolves #15532
Related #15306
Check List

[x] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for ca2fd04: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/15812


block comment should insert * when pressing enter

inside of a block comment, when i press enter to start a new line it would be nice if the '*' character is inserted automatically, much like editing a javadoc in IntelliJ.

I'd also appreciate this change; it'd make documnetation comments for protobuf files much easier :smiley:

This issue is closed as plugin is not supported anymore.
Please switch to https://github.com/jvolkman/intellij-protobuf-editor.


how to install emacs with xwidgets support

Hi, I was wondering if someone could give me some advice on how to install emacs with xwidgets support.
When I try brew install emacs --with-xwidgets I get the following Warning: emacs: this formula has no --with-xwidgets option so it will be ignored!
How can I pass the argument --with-xwidgets on brew during ./configure and compilation stages. Is that possible?

brew does not let you pass arbitrary configure options. There would need to be an option for xwidgets in the formula. This is not something we can support because it requires webkitgtk, which was removed from Homebrew in https://github.com/Homebrew/homebrew-core/pull/9053. So you'd need to maintain a personal tap with a tweaked version of the emacs formula and with a resurrected webkitgtk formula.


[BUG] Metadata block does not scale on narrow windows

Describe the bug
In Preview, the Metadata block showing the tags and such does not adjust its width when you make the window narrow (see screenshots).
To Reproduce
Steps to reproduce the behavior:

Add some frontmatter to a notes file (e.g., see below
Click on Preview
Look at  the width of the second block, labeled with 'METADATA'.
Make window less wide
Notice that the 'METADATA' block does not scale to a more narrow size.

Example text:
---
title: Example note
created: 2021-12-06
tags: tagA tagB tagC
---

Expected behavior
Have the block scale to the width of the content of the other block, and of the note itself.
Screenshots
Attached.
Desktop (please complete the following information):

OS: Seeing this both on Linux and on Android.
Obsidian Version: 0.12.19

Obsidian default theme:

Spectrum:

What about when there is text? It should behave the same, the width of a note is at 700px or 750px, so the metablock will adjust to that width.
Do you believe the metadatablock should not do that?

The issue is that with the Spectrum theme, the text and the top block adjust to the width of the note-panel, but the METADATA block does not. The default Obsidian theme makes the Metadata block the same width as the top (also metadata :) ) block and the content that follows (which is shown in the first screenshot), so it does not fall out of the panel like on the second screenshot.
I'm not sure what you mean with your question about text. Instead of the metadata block? Content of the note is already nicely adjusted to the same width as the top block.

i will have a deeper look then. I take it you're using it on desktop and mobile?

Yes, I use it on both :) It's reproducable on desktop when you make the window more narrow; it's how I created the screenshots above.

This should fix the issue.

Cool, seems to look fine now, thanks!


Swift 3 errors

I love Stellar. Animations with Swift like they should be. Thanks.
but...
Swift 3 branch seems to throw compile errors. Any plans on fixing this? Swift 3 officially out today.
thanks.

I will rewrite for Swift 3, it should take some time to do this.

@AugustRush You rock ! This animation framework is the best !!
I'll wait for Swift 3 version :)
Cheers

Thanks!
Cheers  :)


allow plugins to customize their log colors

If the color flag is 0 (expected but undocumented default behaviour of plugins for GetField) NS::Colors::PLUGIN is used as a default.
The Color is packed into a 64 bit integer like this
const Color = packed struct(u64) {
    red: u8,
    green: u8,
    blue: u8,
    _: u40 = 0,
};

The colors only occupy the lower 3 bytes of the integer. The remaining bits are ignored. When determining to use the default color or the provided log color, the lower 12 bits are checked if any is not 0.

Were the plugin field and plugin string enums supposed to be non exhaustive?

yes to allow adding more fields in the future they're supposed to be non exhaustive

Alright a few plugins crashing is fine for now ig
Will review this pr later today probably

Yeah so for some reason it renders as (almost?) black when the colour value is not set which looking at the code shouldn't be the case as it should just be default colour if not set

Current rrplug builds return uninitialized values for colors. If a plugin returns 0 as color, a default will be used

cc @F1F7Y whether you wanna re-review, given that you requested changes. Otherwise if there's no response I'd merge within a day or two to not stall the PR o7


fix(app): Add a qr code simulator if the device is not real

Codecov Report
Patch coverage has no change and project coverage change: -0.37 :warning:

Comparison is base (2d6a1bd) 90.36% compared to head (1c77d21) 90.00%.

:exclamation: Current head 1c77d21 differs from pull request most recent head 798ffb1. Consider uploading reports for the commit 798ffb1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   90.36%   90.00%   -0.37%
==========================================
  Files          60       73      +13
  Lines        2491     2560      +69
==========================================
+ Hits         2251     2304      +53
- Misses        170      180      +10
- Partials       70       76       +6

see 27 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Linux-distro independent build toolchain

I'm following the build instructions on Ubuntu 14.04. The diversity of system toolchains I find is a recipe for brittleness when it comes to developing something like a database with a lot of dependencies. Many Linux packages aren't built with -fPIC, for example.
In the Impala project, they developed a fully self-contained build toolchain (outside stable dependencies like autotools) so that any reasonable Linux is able to produce identical builds with all dependencies statically linked: https://github.com/cloudera/native-toolchain. So you could be on Ubuntu 12.04 through 17.04 and not run into any rough edges with old dependencies. This constraint forces you to pin every dependency, and by controlling all of the build flags up and down the toolchain you can easily create builds with no shared library dependencies. Maybe you are already doing this someplace.
It might take some time (and some CMake modules aren't set up out of the box to pick up non-system versions of some libraries), but it would make MapD development more accessible for outsiders.
I'll post more granular issues for any problems I may run into

We have prebuilt dependencies per https://github.com/mapd/mapd-core#dependencies. Not sure about ABI compatibility with other distros (FIPS? glibc symbol versions?), but they worked at some point on Ubuntu as well, so it's a starting point.
@andrewseidl Have we tried to just use one version of the dependencies at least for our internal CentOS and Ubuntu builds and see how it goes? If we build them on CentOS 6 and tweak the flags properly, I believe we can get an universal version (or maybe two, FIPS and non-FIPS) for all recent distributions.

Are those pre-built dependencies posted online someplace to download? One approach is to build these with RedHat devtoolset-3 or 4 on CentOS 6 to avoid glibc and libstdc++ problems

Yes: https://internal-dependencies.mapd.com/mapd-deps/mapd-deps-latest.tar.xz, per the https://internal-dependencies.mapd.com/mapd-deps/deploy.sh mentioned in the readme. Indeed, using devtoolset on CentOS 6 would be the safest bet for a binary compatible set of dependencies.

@asuhan Do you have a feeling on how difficult it would be to do? Feels like a dozen remaining issues in this repo are around subtle differences in the build scripts, would be great to clean this up once and for all

Easiest (and what we've been planning on doing) is to write some wrapper scripts around the Dockerfile at https://github.com/mapd/mapd-core/blob/master/docker/build/centos7/Dockerfile (that's exactly what we use on some of the build machines that generate the Community and Enterprise Editions).
Example usage is at: https://github.com/mapd/mapd-core/issues/254#issuecomment-410272482

Closing this issue, as I feel like we're at a place where the project reasonably builds with a handful of commands and the /omniscidb/scripts/mapd-deps-prebuilt.sh script.


Loss by multiple GPUS goes unused

With apex enabled, It looks like the code averages out the detached loss, and then takes a gradient step on the original loss from the current process only.
Put another way: it looks like the code currently uses multiple gpus to generate e.g. 8 loss values, calculates their average for logging purposes only, and takes a gradient step only on one of them. I've highlighted the relevant lines from train.py below:
        optim.zero_grad()
        main_loss = net(inputs)

        if args.apex:
            log_main_loss = main_loss.clone().detach_()
            torch.distributed.all_reduce(******log_main_loss*****, # this looks wrong
                                         torch.distributed.ReduceOp.SUM)
            log_main_loss = log_main_loss / args.world_size
        else:
            main_loss = main_loss.mean()
            log_main_loss = main_loss.clone().detach_()

        train_main_loss.update(log_main_loss.item(), batch_pixel_size)
        if args.fp16:
            with amp.scale_loss(main_loss, optim) as scaled_loss:
                scaled_loss.backward()
        else:
            main_loss.backward()

it's not a bug because the model is wrapped behind DistributedDataParallel, which magically reduces gradients


removes left and right content space in filer folder

This pull request fixes the following issues:

BEFORE
AFTER

nice :+1:

LGTM