Theme doesent work, then Breaks 'Brackets Git' extension then wont uninstall

After installing this extension, upon starting brackets I receive a notification from another extension (brackets git) saying it failed to connect to nodejs.
Also, it does not apply at all, i see no change to brackets.
Upon attempting to remove this extension, i get a message saying "Unable to remove one or more extensions: monokai-theme. Brackets will still reload".

I'm having the same problem with Brackets Git as well, i do not think it is Monokai though.

Update: After Restarting the system, Monokai still did not appear, but Removed Correctly. Brackets-Git no longer gives the error, which seems to have been somehow caused by installing Monokai theme.

@htmlguy is this issue logged with brackets?
/cc @zaggino

Just tested, I have absolutely no issues running this theme together with Brackets-Git and I doubt that any theme would break node-connection. Try getting out the logs from your console (f12) and submitting an issue with Brackets-Git if you can find anything useful in there.

@zaggino I really didn't think that they wouldn't mix... I am not even sure why this is even possible.
@htmlguy what other extensions do you installed?

@htmlguy you can use
bracketsGit.getInstalledExtensions()

in the console whe Brackets-Git is installed, you'll get also a list of extensions which are using connection to Node in Brackets.

I was using:

"Brackets Extension - UTF8 converter"
"Brackets Git"
"Install from Bower"
Also: The issue is not logged with brackets AFAIK

@htmlguy  What version of brackets are you running?

I am using latest version: 1.1 (W/O extract)


How to show thumbnail in suggestion dropdown?

I am showing the list of the users in the suggestion dropdown, I want to show the photo of the user at left side of each row. How to do this?
Please see example 2 of below page
http://darylrowland.github.io/angucomplete/

Sorry for not replying sooner.
Unfortunately that's not possible right now. It's in the project backlog, though. Take a look at #99.

Can this issue be closed?


Create Dev Guidelines

@davidevans adding Dev Guidelines. Also are we using pronto-flake8 at any of the projects in theScore right now?

@davidevans will need your 👍  :)

merging after private email with Dave


[FEATURE] Get child term at all levels in Taxonomy Term store

Is your feature request related to a problem? Please describe.
Get-Term works only till the first term (level 1), this require a change to the cmdlet
Exemple :
Store :

Group
--Termset
---Level1_Term
-----Level2_Term

Get-PnPTerm -Identity Level1_Term -TermSet $termSetFonc.Name -TermGroup $group -> Works
Get-PnPTerm -Identity Level2_Term -TermSet $termSetFonc.Name -TermGroup $group -> Don't Works
Solution :
This request to update actual behaivor of Get-PnPTerm so it returns term at any level
Alternatives :
There is a workaround of this problem by using the parent item's context but it's not optimal :
$ParentTerm=Get-PnPTerm -Identity $ParentName -TermSet $termSet -TermGroup $group
$ctx = $ParentTerm.Context
$ctx.Load($ParentTerm.Terms)
$ctx.ExecuteQuery()
Then filter on parent's terms : $TermLevel2 =$ParentTerm.Terms | Where-Object Name -eq $TermName
To get a level 3 term we should reproduce the same process.

Hi, we have added a new parameter -IncludeChildTerms , this will retrieve the child terms from all levels.

@gautamdsheth  Great. Thanks!
Even the -IncludeChildTerms parameter does not work at all.
It does NOT return any data :(


Missed letter in the hye.traineddata

In the hye.traineddata the letter և  is not included.  This letter is replaced by the letter ն . Indeed the two letters aspect are very similar, but they have not the same signification.    I have  found that in the old arm.traineddata there is no such a problem.

Armenian.traineddata contains the missing character, so I suggest to try that model.
Where can I find this model ?


language not worked

Description

Handsontable.languages.getLanguagesDictionaries can found zh-Cn,but when set hot-table language="zh-CN"
console print error:
Language with code "zh-CN" was not found. You should register particular language before using it
Steps to reproduce

1.use    import 'handsontable/languages/zh-CN';
2.set language='zh-CN'
3.i try other language the same happened,
Demo

https://jsfiddle.net/handsoncode/4owqzasd/
Your environment

Vue wrapper version: 2.5.7
Handsontable version:7.0 and vue 4.0
Browser Name and version:chrome
Operating System:win7

Hey @lightning0016
you should add the language pack script. I've added it here https://jsfiddle.net/4xh7n5ou/

Hey @lightning0016
you should add the language pack script. I've added it here https://jsfiddle.net/4xh7n5ou/

but after I add language: 'zh-CN', set dropdownMenu:true，the table's dropdown menu is still English.

Hey @zhangwz
here's the language tutorial that can come in handy https://handsontable.com/docs/7.1.1/tutorial-internationalization.html and the language change example for Vue https://handsontable.com/docs/7.1.1/frameworks-wrapper-for-vue-language-change-example.html


Flux - Filtering on tags and values sometimes returns incorrect results

I have been using Flux since November 2019 and had not faced this issue until the last couple of days. I have attached the sample data (DataSampleNew.txt) to reproduce the error. I must point out upfront that I did not face the issue on similar data which had greater number of unique tag values (DataSampleOld.txt). Since InfluxQL returns consistent results on both sets of data, I think that this is a Flux issue and not a data issue. Nonetheless, I'd be happy to correct the data if the issue lies there.
Steps to reproduce:

Create new influxdb container on a laptop using the latest docker image for 1.7.9
Insert data from the DataSampleNew.txt file attached below, into a measurement in a bucket
Run queries having filter conditions using InfluxQL and then their equivalent Flux queries

Expected behavior:
Should give exact same query results for both InfluxQL and Flux
Actual behavior:
Inconsistent InfluxQL and Flux query results with DataSampleNew.txt

Consistent InfluxQL and Flux query results on DataSampleOld.txt

Environment info:

OS: Ubuntu 18.04 LTS
System info: Linux 5.3.0-28-generic x86_64
InfluxDB version: InfluxDB v1.7.9 (git: 1.7 23bc63d43a8dc05f53afa46e3526ebb5578f3d88)
Other relevant environment details: Installation type: Docker, latest image (1.7.9)

Config:
Modified influxdb.conf to enable flux.
[http]
flux-enabled = true
Data Files:
DataSampleOld.txt
DataSampleNew.txt

@dhruvsgarg thanks for reporting. I've reached out to the Flux and Storage teams to take a look.

Hey, I wanted to know if someone was able to reproduce the issue, or if the cause for the inconsistency has been identified.

I was able to reproduce the issue locally. It seems it is still present in v2 so whatever bug this is is present in 2.0 too if it's a bug.


Unit Test Files

First off great work!
The unit tests reference files that are ignored in .gitignore
'./data/states_0_train.npz'
'./data/st_hb_test.json.gz'
'./data/building_blocks_matched.csv.gz'

can we add these to the repo so the unit tests can be run?

Thanks, Karl!
We have added the building blocks file (forgot to push), and we updated the data prep tests so that they now run with the files available in ./tests/data/.
We are still adding a few more unit tests (the placeholders for these will raise NotImplementedError-s), but the ones that are already implemented should pass.


Upgrade Axon Framework to 4.6.3

This pull request upgrades Axon Framework from 4.6.2 to 4.6.3.

Discussed and reviewed offline, hence I'll proceed and merge this.


[docs][7.2] Add environment documentation

Closes elastic/apm-agent-java#657
Do not merge yet. Blocked by: https://github.com/elastic/kibana/pull/38577
Implements https://github.com/elastic/apm/issues/81

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #666   +/-   ##
=========================================
  Coverage     62.42%   62.42%
  Complexity       68       68
=========================================
  Files           199      199
  Lines          7777     7777
  Branches        950      950
=========================================
  Hits           4855     4855
  Misses         2626     2626
  Partials        296      296

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c1a8e...16ce9dd. Read the comment docs.

Thanks for doing this Eyal. Would love to chat with you about this process at some point so I can learn more about it.

jenkins retest this please

jenkins retest this please
(sorry for the noise, forgot I needed to backport the Kibana changes before the docs ci will pass)


Update SMILES parsing syntax error to include bad token position

This attempts to improve the SMILES parsing procedure to provide more information about bad inputs by pointing to general location of the offending token. The improved error messages currently only apply to syntax errors, inputs with extra close parentheses, and inputs with too large numbers, but this will provide a way to extend that in the future
Some examples of the improved error messages

old version
new version

syntax error while parsing: c%()ccccc%()
syntax error while parsing input: c%()ccccc%()  ~~~^

syntax error while parsing: c%(100000)ccccc%(100000)
syntax error while parsing input:  c%(100000)ccccc%(100000)  ~~~~~~~~^

syntax error while parsing: COc(c1)cccc1C#
syntax error while parsing input:  COc(c1)cccc1C#  ~~~~~~~~~~~~~^

extra close parentheses while parsing: C)
extra close parentheses while parsing input:  C)  ~^

extra close parentheses while parsing: C1C)foo
extra close parentheses while parsing input:  C1C)foo  ~~~^

number too large while parsing: [555555555555555555C]
number too large while parsing input:  [555555555555555555C]  ~~~~~~~~~~^

This was achieves by extending the lexing and parsing procedure to track the current token position with a new variable, so the reported position may not be 100% accurate at all times but should be helpful in reducing the amount of work done to find the bad location.
Additionally, I updated the build instructions to strip the #line macros from the generated C++ files, which required a modern flex/bison versions.

Reference Issue
Implements #7980

@ricrogz @rachelnwalker Would you guys mind reviewing this?

@greglandrum, I had a look at this, and it looks ok to me.

@whosayn, I think this looks good as is and will be a big help, but what about adding reporting about extra opening parentheses too? I think you could do this by changing branch_points from a list of unsigned ints to a list of std::pair<unsigned int,unsigned int> and printing the appropriate error message in smiles_parse_helper()

@whosayn, I think this looks good as is and will be a big help, but what about adding reporting about extra opening parentheses too? I think you could do this by changing branch_points from a list of unsigned ints to a list of std::pair<unsigned int,unsigned int> and printing the appropriate error message in smiles_parse_helper()

good call. I'll also move the printSyntaxErrorMessage api into SmilesParseOps to improve the current error message.

@greglandrum I was able to make the recommended changes :). These are example error messages:
[09:54:03] SMILES Parse Error: extra open parentheses while parsing: C1CC1(CC
[09:54:03] SMILES Parse Error: check for mistakes around position 6:
[09:54:03] C1CC1(CC
[09:54:03] ~~~~~^

[09:54:03] SMILES Parse Error: Failed parsing SMILES 'C1CC1(CC' for input: 'C1CC1(CC'
[09:54:03] SMILES Parse Error: extra open parentheses while parsing: C1CC1(CC(CC
[09:54:03] SMILES Parse Error: check for mistakes around position 6:
[09:54:03] C1CC1(CC(CC
[09:54:03] ~~~~~^

[09:54:03] SMILES Parse Error: extra open parentheses while parsing: C1CC1(CC(CC
[09:54:03] SMILES Parse Error: check for mistakes around position 9:
[09:54:03] C1CC1(CC(CC
[09:54:03] ~~~~~~~~^

Thanks @whosayn !


Issue with ee_to_numpy

Hi Quisheng, first of all, wonderful work done on the development of this plugin. Thanks a lot for the time and effort you've invested in this. I was trying to use the ee_to_numpy functionality on Colab for Sentinel 2 imagery. It repeatedly threw errors. The errors were due to the following reasons. It isn't anything intrinsically wrong with your code, but rather a warning which can be included in the documentation.

The first error was because my image was too large. The sampleRectangle function that you use can only take 262144 pixels. The aoi argument, therefore, needs to be specified and ensured that it is within the given size range.
Once the size error was rectified, another error of unmatched dimensions popped up. This is because the S2 imagery has varying resolutions for the different bands. So a note to users to ensure a resampling and reprojection to a fixed scale will be useful.

@RituAnilkumar Thank you for your suggestions. I have incorporated them into the documentation.


The build failed.  Include your operating system version, exact error message, code sample, and anything else that is relevant.

What are the build errors you're getting?


Feature request: revoke OAuth 2 tokens

From<EMAIL_ADDRESS>on October 25, 2012 07:24:15
I'd appreciate it if there were a native method under gapi.auth for revoking the current OAuth 2 token grant. You can do this manually by making a (JSONP, to avoid cross-domain restrictions) request to
' https://accounts.google.com/o/oauth2/revoke?token=' + gapi.auth.getToken().access_token
but this should be part of the client library.
Original issue: http://code.google.com/p/google-api-javascript-client/issues/detail?id=59

+1
It would be nice to have this as part of the JS library.
For now my approach will be to make an ajax call to my server, then issue a request to the oauth2/revoke endpoint with the most recent access token I got from the user.  Of course, my access token might be expired, in which case this will fail.  At that point it will be silly to ask the user for a new access token solely for the purpose of revoking permissions :-)  But it is very useful to both revoke permissions and track that fact within my app.


update node packages

Description

update node modules

Technical details

extract-loader :    ^5.1.0 >>  ^4.0.3
postcss-loader:  ^5.1.0 >> ^7.2.4

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Holding on this, after making the PR I realized I didn't manually rebuild the project (had assumed it would live rebuild). A SASS build error occurs on rebuild.
./sass/main.scss 39 bytes [built] [code generated] [1 error]

ERROR in ./sass/main.scss
Module build failed (from ./node_modules/extract-loader/lib/extractLoader.js):
/workspaces/creativecommons.github.io-source/webpack/sass/main.scss:2
import ___CSS_LOADER_API_IMPORT___ from "../node_modules/css-loader/dist/runtime/api.js";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at new Script (node:vm:100:7)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:98:28
    at Generator.next (<anonymous>)
    at step (/workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at new Promise (<anonymous>)
    at new F (/workspaces/creativecommons.github.io-source/webpack/node_modules/core-js/library/modules/_export.js:36:28)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12
    at evalModule (/workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:165:63)
    at evalDependencyGraph (/workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:167:12)

webpack 5.80.0 compiled with 1 error in 10219 ms

I'll need to look into this further to verify how to correct this. I have a suspicion that some of these updates are tied to Vocabulary and by proxy Vue and if so these updates may have to hold until Vocabulary is addressed.
Closing for the time being until I can resolve the above.

Likely related: https://github.com/peerigon/extract-loader/issues/99


terminal input bug when typing Chinese

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.95.0 (Universal)
OS Version: macOS 14.3 (23D56)

Steps to Reproduce:

open the terminal and typing the code using by Chinese input method like system built-in 简体中文-简体拼音
input git commit -m "", and then press left arrow btn let cursor inside the double quotes, then continue typing some Chinese

We're tracking problems with Chinese IMEs in the upstream repo: https://github.com/xtermjs/xterm.js/issues/4486


Leftmost repeating character

Description 📜
This will print the Index of the leftmost repeating character in a given string. (C++ language)
Three test cases for better understanding
Fixes # 1473

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] C/CPP

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Hey please review my PR and let me know if any change is required.
Thanks for assigning me this issue :)

Hey, @AastikSharma05 this PR has 77 files changed. This happens when you don't have an updated GWOC repository. I would suggest updating your repo. And then create the PR again. Closing this one for now.


Update to null safety?

First of all, thank you for your package!
And the question:
As Flutter brings a sound of null safety (please see at the link), is this package will support null safety in future?

if there's no WIP on this, I'd be happy to make a PR

Hi @Sameerkash , thank you! People will love it. Happy to review the PR. I am a bit occupied by my day job a the moment but would love to review the PR and contribute.

@lzhuor, great!, I'm on it. will be up within the next couple of days.

Thank you! Merged the PR into master. You can start using it with git ssh before I publish a new version in pub.dev.

@Sameerkash You can access the nullsafety version from https://pub.dev/packages/auto_size_text_field/versions/1.0.0-nullsafety.1 now.
Thanks again for the contribution! 🚀


Add box shadow to buttons

[x] Finish my changes
[ ] Push my commits to GitHub
[ ] Open a pull request


synovial joints - term placement

The following terms should be made direct child terms of abnormal synovial joint morphology (MP:0030804)
temporomandibular joint morphology MP:0011210
abnormal incudomalleolar joint morphology MP:0030109
abnormal incudostapedial joint morphology MP:0030108

This is done.


Home Page: Wording Correction

Home page, latest products section, Flow One

[x] Change Heading to "Flow One"
[x] Change paragraph to:  eSynchrony is a new platform for creating interactive visual communication. With it, medical professionals will be able to synchronize patient care among all staff departments. Together, Zymo and Flow One developed this innovative new software. Our initial market tests yield a reduction of patient wait times by 25-50%. We're excited to watch this technology increase productivity among health care professionals while also improving patients’ experiences at the same time.

Pull request in for it


Changes setting name for kubeconfig TTL.

Issue: https://github.com/rancher/rancher/issues/38456
Problem
The setting name was misleading
Solution
Update the name.
Testing
Verify endpoints are available for the new name.

Were docs updated yet?

@rmweir They are in review but have the updated name https://github.com/rancher/docs/pull/4140


ZelCash v3.0.0 fails to run/build on CentOS 7.x

Downloaded Linux binary release, run failed.
$ ./zelcashd
./zelcashd: /lib64/libstdc++.so.6: version CXXABI_1.3.8' not found (required by ./zelcashd) ./zelcashd: /lib64/libstdc++.so.6: version GLIBCXX_3.4.20' not found (required by ./zelcashd)
./zelcashd: /lib64/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by ./zelcashd) ./zelcashd: /lib64/libc.so.6: version GLIBC_2.18' not found (required by ./zelcashd)
When building, run "./zcutil/build.sh -j$(nproc)", failed at the first time, run again, succeeded but run zelcashd failed.
$ ./src/zelcashd
terminate called after throwing an instance of 'std::regex_error'
what():  regex_error
Aborted
In config.log, it shows errors like:
conftest.cpp:59:34: fatal error: libdb62/db_cxx.h: No such file or directory
#include <libdb62/db_cxx.h>
^
Seems like requiring libdb6.x, but the OS has libdb5.x installed by default.
OS info:
$ lsb_release -a
LSB Version:	:core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID:	CentOS
Description:	CentOS Linux release 7.6.1810 (Core)
Release:	7.6.1810
Codename:	Core

Hey: We do not officially support CentOS, and this is not supported with our build instructions.
But you can try these instructions:
autoconf libtool unzip git python \
wget curl  automake gcc gcc-c++ patch \
glibc-static libstdc++-static

Please execute the below commands in order.
sudo yum install devtoolset-3-gcc devtoolset-3-gcc-c++
sudo update-alternatives --install /usr/bin/gcc-4.9 gcc-4.9 /opt/rh/devtoolset-3/root/usr/bin/gcc 10
sudo update-alternatives --install /usr/bin/g++-4.9 g++-4.9 /opt/rh/devtoolset-3/root/usr/bin/g++ 10
scl enable devtoolset-3 bash

Then get source and build:
cd zelcash
./zcutil/fetch-params.sh
./zcutil/build.sh -j$(nproc)

Let us know how you get on.

Hi Miles,
Still got similar errors after running the commands above.
ZelCash 2.0.0 is OK with CentOS 7.x.
The packages version of CentOS is always lagging behind Ubuntu.

Hmm ok. Could you try the latest ZCash version as you mentioned V2.0.3 and see if you can build from source (out of curiosity)?
We will look into supporting a wider array of linux distributions in the future. For now Ubuntu 16.04 is recommended.
Thanks,
Miles

Hi Miles,
I have ZCash v2.0.3 build. It runs OK.
Thanks for the replies.

Hi,
Ok well that tells me with a little tweaking we can get it working, I will look into merging v2.0.3 Zcash and hopefully we can get ZelCash to compile on Cent OS 7.x
Thanks for the heads up on both issues. I will close them for now.
Miles

@Scribbles-MCAMK Please be aware that you may need to run zcutil/build.sh 2 times when building ZCash v2.0.3. The 1st time may fail, then run the 2nd time immediately without clean up.
zcashd runs well if build passed.
For ZelCash v3.0.0, running zcutil/build.sh 2 times, the build will succeed, but zelcashd cannot run.

@Scribbles-MCAMK
Hi Miles,
Finally, the build passed with zelcashd v3.0.0 running well.
I ran zcutil/build.sh again without clean up.
I suppose it's network issue. The dependencies downloading might be interrupted during build.
Running build.sh again and again resumed the dependencies downloading and finally succeeded.
Thanks again for your help.
Jonathan


[enhancement]: Add released version number to web UI

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Maybe I'm missing something completely obvious, but I'm wondering what version of Invoke I have (since I installed it a couple of weeks ago) and yet I don't see the version number anywhere in the web UI.  I also checked the various settings panels.
Given that, it would be nice for the version number to be readily visible.  I would suggest putting it to the right of the Invoke AI logo, that's in the upper left of the UI.
Anyway, thanks, love the tool!
Alternatives
No response
Aditional Content

you can get the version number overing the invoke.ai logo with your mouse...


AirPlay device picker broken on iOS8 iPad

When I created a MPVolumeView with showsRouteButton=YES and added it inside a view in AGWindowView, I can manipulate volume etc. but when I press the AirPlay button, the device picker window does not appear.
This only happens on iOS 8 and iPad. iPhone seems to have a different style popup and it is working fine.
Any idea why this is happening? Might be a platform bug too because on iOS7 it worked just fine.

The UIPopoverController from Apple has always been very buggy and behaving very differently on different versions and devices.
I'm sorry to hear that AGWindowView is not compliant with the combo mentioned.
Maybe you could hide AGWindowView while the popover is being displayed?

Hi,
Thank you for your quick reply. Yeah, I believe this is really Apple's issue on iOS8 iPad(s). Luckily, in my case I can try to fix the UI in a way that the MPVolumeView will be positioned in a UIView other than AGWindowView so it will work then.
Thank you for your help and for this great library! I'll be using it elsewhere at least.

Ok cool. AGWindowView is built as a robust last resort alternative, but it will definitely not be compatible with all of UIKit's assumptions about view hierarchy (like the popover in ipad ios 8).

Won't fix.


Studio/nav: start with GS

... before How it Works (more of a mid-level explanation type doc)

Hm... This should be covered in the Get Started itself, I think. We're trying to avoid distractions and get fast to demoing the value of the project ⏳


dvclive: Add YOLO page.

Also: https://github.com/iterative/dvclive/pull/650

@daavoo Looks like it's missing from the index

Should we link to https://docs.ultralytics.com/reference/utils/callbacks/dvc/ somewhere?
Also, can we show some example output and/or a summary of what gets logged?


Bump to 0.1.3

Changes:

#237: Fixing the raster tiler so it can handle edges of large-format raster more stably.
#231: Adding SwapChannels augmentation to deal with imagery that has different band order.
#230: Fixing gdal install requirement and a bugfix for checking if models are already downloaded.

A couple of other little fixes here and there (debugging training; making solaris save model state_dicts for torch instead of the whole model; fixing model checkpointing...etc.)

Codecov Report

Merging #239 into master will decrease coverage by 0.63%.
The diff coverage is 19.51%.

@@            Coverage Diff            @@
##           master    #239      +/-   ##
=========================================
- Coverage   66.23%   65.6%   -0.64%
=========================================
  Files          67      67
  Lines        4561    4611      +50
=========================================
+ Hits         3021    3025       +4
- Misses       1540    1586      +46

Impacted Files
Coverage Δ

solaris/raster/image.py
83.33% <ø> (ø)
:arrow_up:

solaris/nets/datagen.py
90% <ø> (ø)
:arrow_up:

setup.py
0% <ø> (ø)
:arrow_up:

solaris/nets/model_io.py
18.18% <0%> (-4.05%)
:arrow_down:

solaris/nets/train.py
12.5% <0%> (-1.3%)
:arrow_down:

solaris/nets/torch_callbacks.py
42.45% <0%> (ø)
:arrow_up:

solaris/__init__.py
100% <100%> (ø)
:arrow_up:

solaris/nets/transform.py
61.34% <34.78%> (-7.66%)
:arrow_down:

solaris/tile/raster_tile.py
71.15% <77.77%> (-0.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2ce05...fe7898a. Read the comment docs.


Fixing reparenting affiliation creating duplicate affiliation

Critical Changes
Changes

We've fixed a bug that created duplicate Affiliations when users reparented an existing Primary Affiliation with a different Contact/Account.

Issues Closed
New Metadata
Deleted Metadata
Testing Notes

Deploy HEDA to a scratch org
Create a non-admin account(business org etc)
Create two contacts
Set the primary field(primary business org for instance) as contact#1
Go to contact#1 and find the new affiliation(affiliation#1) under related list(affiliation account)
Go to affiliation record page and update the parent contact to contact#2
Make sure no new affiliation is created, affiliation#1 is under contact#2 and is primary.

@juliesnow could you review the release note of this PR please? Thank you!

Testing in progress. Also pinged @jacebryan  and @aligeez to check out the changes section for release notes.

This looks good. Will merge once we get the final okay on the suggested changes from @juliesnow.

@xinnanlisf + @annejackson - Looks good!

Merging pull request. All looks good.

@juliesnow added the bullet point to the release note. Fyi. :)

For Release Notes description:
We've fixed a bug that created duplicate Affiliations when users re-parented an existing Primary Affiliation with a different Contact/Account. With this fix, when you re-parent an existing Primary affiliation with a new or different Contact (Account), it will keep the primary affiliation as the sole affiliation without creating any other ones. This does not apply to regular affiliations, just "primary".
@xinnanlisf  - thanks for your help :)

@aligeez - Have provided proposed rewrite in WI. Pls lmk if you have ?s/suggestions. thx!


Still can't select Action

Taking over a project on behalf of @ashlynnrs, and still unable to add an Action in her org. Connected app was created automatically using the new feature, and all other prerequisites have been triple checked. Any further suggestions?

Hi @sherpagabriel, thanks for the persistence here. Are the process builders or flows you want to call active?
For process builder, only ones set to start when invoked by another process will show, ones that start when a record changes will not show.
For flows, only ones without screens in them will show, ones with screens will not show.
I'm trying to think what else might be the issue to check for.

Thanks Doug, the desired process builder is active and invocable. Several
processes actually are active and invocable, and none show in the menu.
Gabriel Vieira
Database Sherpa
"The Wisdom of a Sherpa, the Reward of your Practice"
828-338-8258
Book a call http://gabrielvieira.youcanbook.me/
On Wed, Aug 15, 2018 at 12:25 AM, Doug Ayers<EMAIL_ADDRESS>wrote:

Hi @sherpagabriel https://github.com/sherpagabriel, thanks for the
persistence here. Are the process builders or flows you want to call active?
For process builder, only ones set to start when invoked by another
process will show, ones that start when a record changes will not show.
For flows, only ones without screens in them will show, ones with screens
will not show.
I'm trying to think what else might be the issue to check for.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/douglascayers/sfdx-mass-action-scheduler/issues/39#issuecomment-413090614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoUuegt8NyiIoRn6_4fOlDjwMaMDTQbwks5uQ6KegaJpZM4V4zW1
.

Hi @sherpagabriel,
I was going to suggest re-creating the Named Credential, Auth. Provider, and Connected App, but you said you already used the automatic option to create them.
Hrmm... other thoughts... when you're on the wizard screen to select the action, perhaps not the correct Named Credential is selected? Although I imagine you would have tried selecting all Named Credential options that appeared to see which would work for you.
Another thought is to try it out in another sandbox or free developer edition org to see if you're able to reproduce the problem there. If so, then we know there's something specific to this sandbox's setup that's getting in the way.
Curious, when you're on the wizard screen selecting the options, does the browser's developer console display any JavaScript errors?

Hi Doug,
I am having the same problem where I cant select anything for the Action. No matter what Action Type I select, the Action drop down does not populate. When I inspect the page with Chrome there are a number of errors. I've attached a screenshot.
The process builder is active and it is invocable.

Thanks
Steve

Hi @stevegt321, the Error IDs in your screen shot indicate a value somewhere is null when it shouldn't be. Considering this happens when the code is trying to get a list of the invocable actions, I would double-check the Connected App, Auth. Provider, and Named Credential are configured correctly.
If this happens to be a sandbox that was recently refreshed from production, the  Connected App, Auth. Provider, and Named Credential will have to be re-created to use the sandbox domain url.

Hi Guys,
Did you find the root cause for this?? I'm facing the same issue, please see the attached screenshot

Thanks @gurditta for the screen shot with error details. I’ll lookup those error codes and see if that helps point to the cause.

I have the same issue without a solution, I have followed your suggestions, and I have spent hours and this Mass Action scheduler doesn't work

Hi @ericrayburn, @sherpagabriel, @stevegt321, and @gurditta, Release 2.0 is now available. You can install it from here.
Kindly try out the new version and see if that resolves your issue. This new release does not require Named Credentials anymore, and if that was the issue, then the problem should be gone.
Thanks!


Single spacing

Its worth noting AND THERE SHOULD BE EXAMPLES HERE - that <para> started being double spaced with VS2017 and continues to be doubled spaced in VS2019.  Several issues were raised on MSDN about it and all were closed with no solution provided for creating single-spaced XML intellisense comments in our C# and F# code. All just say "not on our current road map".
It is now necessary to add
 breaks at the end of each line you want to have single spaced.
For example, if you wanted to include a single spaced block of code to your method.
        /// Gets the angle (0-360, 0 being North) between two points. The angle is the direction from point 1 to point 2.
        ///  <para>
        /// GetAngle(0, 0, 1, 0) = 0

        /// GetAngle(0, 0, -1, 0) = 180

        /// GetAngle(0, 0, -1, 0) = 180

        /// GetAngle(0, 0, 0, 1) = 90

        /// GetAngle(0, 0, 0, -1) = 270

        /// </para>
        ///
        /// <param name="lat1"></param>
        /// <param name="long1"></param>
        /// <param name="lat2"></param>
        /// <param name="long2"></param>
        /// <returns></returns>

edit by @billwagner: format sample.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 48fc95e1-59ca-895f-dc67-b7397363689a
Version Independent ID: 8cbd9296-638d-5e83-24a6-569b497835e2
Content: <para> - C# Programming Guide
Content Source: docs/csharp/programming-guide/xmldoc/para.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for creating this issue @tlhintoq I've added it to our backlog for us to address when we next update this article.
I've also added the "up for grabs" and "good first issue" label for any community members that want to address this.

I just wanted to say "thanks for the ACK" on my feedback.  I don't think
I've ever gotten that before from leaving feedback on the microsoft
documentation.
Is it a new mechanism that leaving feedback generates a git issue?  Or
did you do that after reading the feedback?
Regards,
Clint
On 21.11.2019 11:19, Bill Wagner wrote:

Thanks for creating this issue @tlhintoq [1] I've added it to our backlog for us to address when we next update this article.
I've also added the "up for grabs" and "good first issue" label for any community members that want to address this.
--
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [2], or unsubscribe [3].

Links:
[1] https://github.com/tlhintoq
[2]
https://github.com/dotnet/docs/issues/15906?email_source=notifications&email_token=ACWTLUWPOE7HMF55OIDC6C3QU2YI3A5CNFSM4JPUXRN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2ZIKY#issuecomment-557159467
[3]
https://github.com/notifications/unsubscribe-auth/ACWTLUUDU5X24MIFNM7YSC3QU2YI3ANCNFSM4JPUXRNQ

@tlhintoq Are you goingto create the according PR?

reopening to address as part of updating the XML section.


net: config: Rename Kconfig options to correspond to library name

This finishes refactor of splitting off net_config library name from
net_app library, started in c60df1311, c89a06dbc. This commit makes
sure that Kconfig options are prefixed with CONFIG_NET_CONFIG_
instead of CONFIG_NET_APP_, and propagates these changes thru the
app configs in the tree.
Also, minor dependency, etc. tweaks are made.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Codecov Report

Merging #9391 into master will decrease coverage by 3.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9391      +/-   ##
==========================================
- Coverage   52.58%   49.47%   -3.11%
==========================================
  Files         201      196       -5
  Lines       25351    24255    -1096
  Branches     5304     5055     -249
==========================================
- Hits        13331    12001    -1330
- Misses       9921    10470     +549
+ Partials     2099     1784     -315

Impacted Files
Coverage Δ

include/net/net_app.h
0% <0%> (-100%)
:arrow_down:

subsys/net/lib/app/client.c
0% <0%> (-52.42%)
:arrow_down:

subsys/net/lib/app/net_app.c
0% <0%> (-43.88%)
:arrow_down:

subsys/net/lib/sockets/sockets.c
0% <0%> (-42.07%)
:arrow_down:

subsys/net/ip/tcp.c
23.96% <0%> (-35.01%)
:arrow_down:

subsys/net/lib/http/http.c
0% <0%> (-27.36%)
:arrow_down:

drivers/net/loopback.c
56% <0%> (-16%)
:arrow_down:

subsys/net/ip/net_stats.h
57.74% <0%> (-8.09%)
:arrow_down:

subsys/net/ip/net_context.c
60.58% <0%> (-6.64%)
:arrow_down:

include/net/net_pkt.h
80% <0%> (-5.65%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71a1df...1153a34. Read the comment docs.


"see which apps are affecting your battery life"

Thank you for your hard work.
Just one thing please.
I don't see which apps are affecting your battery lifein power options after debloat.
I asked if it could be modified so that only this part could be used.

Hey, thank you!
Try to enable hibernation You can find the script here

Please re-open this issue if you have any issues!


Added feature and bug template

Codecov Report
Base: 91.97% // Head: 91.97% // No change to project coverage :thumbsup:

Coverage data is based on head (9188b41) compared to base (5f13f63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #32   +/-   ##
========================================
  Coverage    91.97%   91.97%
========================================
  Files           22       22
  Lines          162      162
  Branches         3        3
========================================
  Hits           149      149
  Misses          13       13

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[SMALLFIX] Deflake cannotInitializeWithoutMasterHostname test

The MASTER_HOSTNAME maybe set by other tests. In this unit test, I make sure the MASTER_HOSTNAME is unset before the test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4012/
Test PASSed.

jenkins, test this please

Trigger tests several times to make sure it is not flaky any more

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4014/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4015/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4017/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4017/
Test PASSed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4021/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4022/
Test PASSed.

@calvinjia Addressed the comments, PTAL

alluxio-bot, merge this please.


Replaces DeveloperError(s) with Check(s) in Event

Part of #4794

Looks great! Thanks for your first PR @AnimatedRNG

Congrats @AnimatedRNG, welcome!!!


docs: add unplugin-inject-js-snippet

Repository: https://github.com/Levix/unplugin-inject-js-snippet
Support for injecting js snippet into html and js files.

Thank you! I am sorry we no longer accept adding to the showcase list. Instead, you can propose to move your package to https://github.com/unplugin, or later, we might maintain an awesome-unplugin or so.


NGP data format

I have some drive data in the Instant-NGP data format, what would be an easy way to try StreetSurf on that? Moreover, I have one front camera and two side cameras in my data, and the rolling shutter effect can be large for the side camera, does StreeSurf take account of the rolling shutter effect?

Hi, by NGP data format do you mean the NeRF-format mentioned here ? We do have plans to integrate this type of data format.
Rolling shutter effects for LiDARs are partly implemented in Waymo Open Dataset. As for cameras, currently it's not implemented and require some efforts. Also, I hink NGP / NeRF data format does not include information of rolling shutter effect. Can you provide some suggestions for standardize the data formats of rolling shutter effects and the ways to process them? Or I can start to do some research on it, but not recently.

Right, I mean NeRF-format in the link. That's great if you have plans to integrate that.
It seems that NGP does have that rolling shutter in their code:
https://github.com/NVlabs/instant-ngp/blob/7d5e858bba5885bbc593fc65e337e4410b992bef/src/nerf_loader.cu#L205


Pull Request #xxx editor not refresh automatically when PR change

Issue Type: Bug

open PR on a repo, merge it or other operations
rebase, push some commits, open another PR with same branch on same repo

Then, the title of Pull Request #xxx editor changed, yet content of editor is still old, you need to click Refresh button manually. That is not a smooth experience, shall the refreshment on content be triggered at same time?
Extension version: 0.4.0
VS Code version: Code 1.31.1 (1b8e8302e405050205e69b59abb3559592bb9e60, 2019-02-12T02:16:38.656Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6660U CPU @ 2.40GHz (4 x 2400)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 4

Memory (System)
8.00GB (0.03GB free)

Process Argv

Screen Reader
no

VM
0%

Closing as we have no plans to address this issue in the future.


Reduce memory usage

It's time to analyse and reduce the memory footprint.

Story continues with #287


Problem with more than 9 sheet

With an .xlsx file with more than 9 sheets crashes.
For resolve the problem in regular expressions I changed \d with \d+
default:
if (entry.path.match(/xl/worksheets/sheet\d+.xml/)) {
var match = entry.path.match(/xl/worksheets/sheet(\d+).xml/)
var sheetNo = match[1];
promise = self.parseWorksheet(entry)
.then(function(worksheet) {
worksheet.sheetNo = sheetNo;
model.worksheetHash[entry.path] = worksheet;
model.worksheets.push(worksheet);
});
} else if (entry.path.match(/xl/worksheets/_rels/sheet\d+.xml.rels/)) {
var match = entry.path.match(/xl/worksheets/_rels/sheet(\d+).xml.rels/)
var sheetNo = match[1];
promise = self.parseRels(entry)
.then(function(relationships) {
model.worksheetRels[sheetNo] = relationships;
});
} else {
entry.autodrain();
}
break;
is correct?
Thanks

D'oh! Yes, nice find. And your suggested fix is spot on too.
Just published 0.1.5 including this fix.


Error in Data Ingestion step

I have only just started using Notebook 1 of the series and have encountered this error almost straight away.
When running Ingest_Fixture_Rank_Data I got an error in line 38. I think there is a problem with the f string but I can't work out what this is.
Error:
SnowparkSQLException: (1304): 01b56c82-0002-93cd-0071-578700064432: 000668 (22023): SQL compilation error: Invalid template: template must be a non-null JSON array
Traceback:
File "Cell [Ingest_Fixture_Rank_Data]", line 38, in
session.sql(f'''
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/telemetry.py", line 145, in wrap
result = func(*args, **kwargs)
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/dataframe.py", line 597, in collect
return self._internal_collect_with_tag_no_telemetry(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/dataframe.py", line 645, in _internal_collect_with_tag_no_telemetry
return self._session._conn.execute(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 510, in execute
result_set, result_meta = self.get_result_set(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/analyzer/snowflake_plan.py", line 191, in wrap
raise ne.with_traceback(tb) from None
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/analyzer/snowflake_plan.py", line 122, in wrap
return func(*args, **kwargs)
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 612, in get_result_set
result = self.run_query(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 123, in wrap
raise ex
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 117, in wrap
return func(*args, **kwargs)
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 417, in run_query
raise ex
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 402, in run_query
results_cursor = self.execute_and_notify_query_listener(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/snowpark/_internal/server_connection.py", line 354, in execute_and_notify_query_listener
results_cursor = self._cursor.execute(query, **kwargs)
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/connector/cursor.py", line 1016, in execute
Error.errorhandler_wrapper(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/connector/errors.py", line 232, in errorhandler_wrapper
handed_over = Error.hand_to_other_handler(
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/connector/errors.py", line 287, in hand_to_other_handler
cursor.errorhandler(connection, cursor, error_class, error_value)
File "/usr/lib/python_udf/ce75267c55b59dcb26cc0d1658946424aabf4591b3e17629fea65fbc3d463a9c/lib/python3.9/site-packages/snowflake/connector/errors.py", line 165, in default_errorhandler
raise error_class(

I ran it again and it didn't error, so can't reproduce.


[DI] Pass the requested type to the implementation factory to enable dynamic scenarios when the type isn't known statically

Is your feature request related to a problem? Please describe.
I'm trying to enable lazy injection of services, i.e. if I registered a service for IFoo, I'd like to be able to inject a Lazy<IFoo> or Func<IFoo>. This is useful to solve circular dependency issues; Unity does this automatically. So I'd like to be able to do this:
services.AddTransient(typeof(Lazy<>), provider =>
{
    ...
});

However, in the factory delegate, I don't have access to the requested type, so I can't dynamically create a Lazy<T> of the appropriate type.
Describe the solution you'd like
Having overloads of Add* that accept a Func<IServiceProvider, Type, object> would solve this. However it looks like it would be non-trivial, since the Func<IServiceProvider, object> signature is used all the way down to the low-level implementation...
Alternatively, implementing lazy injection like in Unity would solve my immediate problem, but would be less extensible.
Describe alternatives you've considered
Using a third-party container like Unity. But I'd rather keep using the built-in DI container.
Additional context
N/A

+1

Duplicate: https://github.com/aspnet/AspNetCore/issues/3036

@pakrym how did you close this issue citing it as a duplicate of a closed issue? This is obviously not a closed issue.

@pakrym every single one of those is closed, one of these has to be open. Out of everything you linked aspnet/DependencyInjection#474 looks oldest.
This is clearly not a resolved issue. Unless the official answer is literally WILL NOT EVER SUPPORT, NO MATTER WHAT YOU THINK.

It would require a change to https://github.com/aspnet/DependencyInjection/blob/master/src/DI.Abstractions/ServiceDescriptor.cs#L108 property type.
Which would lead to compiler error everywhere it's invoked. It's an easy change to do inside just this repo but the DependencyAbstraction.Package is used by every compatible service provider implementation out there and all of them would get broken,

        public Func<IServiceProvider, object> ImplementationFactory { get; }

        public Func<IServiceProvider, Type, object> ImplementationFactory2 { get; }

        internal Type GetImplementationType()
        {
            if (ImplementationType != null)
            {
                return ImplementationType;
            }
            else if (ImplementationInstance != null)
            {
                return ImplementationInstance.GetType();
            }
            else if (ImplementationFactory2 != null)
            {
                var typeArguments = ImplementationFactory2 .GetType().GenericTypeArguments;

                Debug.Assert(typeArguments.Length == 3);

                return typeArguments[2];
            }
            else if (ImplementationFactory != null)
            {
                var typeArguments = ImplementationFactory.GetType().GenericTypeArguments;

                Debug.Assert(typeArguments.Length == 2);

                return typeArguments[1];
            }

            Debug.Assert(false, "ImplementationType, ImplementationInstance or ImplementationFactory must be non null");
            return null;
        }

etc

I don't see what are you trying to say with this example.

@pakrym  You wouldn't have to change ImplementationFactory, you could have two and then there's no compatibility issues. Not necessarily the prettiest or optimal, but better than what we have today.

But every other container would have to support it or it just won't work with new kind of ServiceDescriptor. It's not a compilation breaking change but a breaking change nevertheless

@pakrym then it should get slated that v+1 should break and just update the factory then.

We haven't broken other service provider implementation since 1.0 and this feature is certainly not worth it. What it's trying to accomplish already exists in other providers

@pakrym this is literally one of the most critical features of a container

Much needed feature. Please consider to implement it.

Much needed feature. Please consider to implement it.

As much as I'd like it, I don't think it will ever be implemented. The team's position is quite clear: they don't want to introduce a breaking change, and it's already possible to do it by using a different container.
In the meantime, I have a solution for my initial problem (lazily resolved service):
public static class ServiceCollectionExtensions
{
    public static IServiceCollection AddLazyResolution(this IServiceCollection services)
    {
        return services.AddTransient(typeof(LazyService<>));
    }
}

public class LazyService<T>
{
    private readonly Lazy<T> _service;

    public LazyService(IServiceProvider serviceProvider)
    {
        _service = new Lazy<T>(() => serviceProvider.GetRequiredService<T>());
    }

    public T Value => _service.Value;
}

Usage:
public void ConfigureServices(IServiceCollection services)
{
    services.AddLazyResolution();
    services.AddSingleton<Foo>();
    services.AddSingleton<Bar>();
}

class Foo
{
    public Foo(Bar bar)
    {
        Bar = bar;
    }

    public Bar Bar { get; }
}

class Bar
{
    private readonly LazyService<Foo> _foo;

    public Bar(LazyService<Foo> foo)
    {
        _foo = foo;
    }

    public Foo Foo => _foo.Value;
}


Huggingface implementation

Great stuff! I saw you have an active huggingface implementation:
https://huggingface.co/helboukkouri/character-bert/tree/main
Is this live? Or when do you expect it to be?
Thanks!

Hi @Tahlor, thanks for the support :) So, the implementation you're looking at should be useable but it's still not part of the transformers library. There is an active pull request for that here: https://github.com/huggingface/transformers/pull/10053
I'll update the repo's README as soon as it's merged. For now you may use the code from the fork you linked but it may have some (probably minor) bugs. If you do find any, please let me know 😊

By the way @Tahlor, although the PR hasn't been merged yet I think that you can start using the code from the branch. I'm just waiting for a couple more reviews before the merge :)


[WIP] Focused tests

This is a work in progress, to implement #185

Coverage increased (+0.06%) to 89.329% when pulling<PHONE_NUMBER>ac4923454376e36d95398b76f19b13 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Coverage increased (+0.06%) to 89.329% when pulling<PHONE_NUMBER>ac4923454376e36d95398b76f19b13 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Coverage increased (+0.06%) to 89.329% when pulling<PHONE_NUMBER>ac4923454376e36d95398b76f19b13 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Thanks for the review man, I'll probably be able to get your suggestions in today sometime.

Coverage increased (+0.03%) to 89.292% when pulling 5108a03b49b07d21360662daa2cab04addb26651 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Coverage increased (+0.03%) to 89.292% when pulling 0ad7e198aea92d0b6ff104950050a0739d826078 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Coverage increased (+0.03%) to 89.292% when pulling 0ad7e198aea92d0b6ff104950050a0739d826078 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

@ezzatron what is your stance on squashing commits? I tend to lean more towards cleaning up commit messages addressing review feedback, but I am open to changing that mindset if you have a preference
Thanks again man!

I tend to squash once all feedback has been addressed. I think I covered all your review points, so I can do that now if that works for you?

Coverage increased (+0.03%) to 89.292% when pulling 1e320a164067149b796cf2887026cc9349e3e911 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.

Coverage increased (+0.03%) to 89.292% when pulling 1e320a164067149b796cf2887026cc9349e3e911 on focused-specs into 01fa66e2517bfca839bf42fd9655f643c6bc8e09 on feature/focused-specs.


Matplotlib 3.7.0 incompatible

Hello! I am teaching a course and we are using the napari-clusters-plotter plugin. I think matplotlib introduced a breaking change in their 3.7.0 release that causes an issue with the plotter widget. When the students launched the plotter widget with matplotlib=3.7.0 installed, the received a keyword argument error.

Thank you so much for reporting this @kevinyamauchi! I will take a look

@kevinyamauchi, it appears to be that the issue was already fixed on the main branch (it was caught by our tests a couple of days ago), but the new release was not made yet, sorry about that! With the latest version (0.6.1) the issue should be gone.
Thanks for using the plugin, and please let us know if there are more issues that your students encounter :)


Create Level1 learning journeys for launch

Currently we have placeholder learning journeys on the Level1 Discover Board https://level1.vercel.app/discover/
It would be nice to launch with a few learning journeys in order to provide value to early users of the platform.
Ideas could be...

how to setup a crypto wallet
how to use Discord
what are DAOs and how to join them

Unschooling learning journey
Some great content shared via Clair at RnDAO
The Case against Education: Why the Education System Is a Waste of Time and Money [book]
https://en.wikipedia.org/wiki/Unschooling
https://en.wikipedia.org/wiki/Summerhill_School
https://denisefenzi.com/2012/04/what-is-relationship/


.abapgit file

to specify minimum version requirement, so that the repository wont install if the version is too low

requirements to other abapGit repositories

which subpackages to ignore

if going for a npm style package mangager, then the settings file will have to include the project name and version
xml style
gui editor

also see #189

closing this, will move to 2 new issues


Testing CI. Dont merge

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.61%. Comparing base (63f116b) to head (e1c79a2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          18       18
  Lines         378      378
=======================================
  Hits          369      369
  Misses          9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(Likely) Scheduled action leaks

It seems likely to me that some - if not all - of the following scheduler.schedule calls will leak actions that are added to another subscription - similar to the leak that was fixed in #6559:
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/observable/combineLatest.ts#L296
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/operators/bufferTime.ts#L120
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/operators/bufferTime.ts#L128-L133
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/operators/mergeInternals.ts#L117
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/operators/windowTime.ts#L139
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/operators/windowTime.ts#L147-L152
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/scheduled/scheduleAsyncIterable.ts#L11-L25
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/scheduled/scheduleObservable.ts#L9-L16
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/scheduled/schedulePromise.ts#L9-L14
https://github.com/ReactiveX/rxjs/blob/5d0e41ee46337f56dba6d9a1ef938002b261ccac/src/internal/util/caughtSchedule.ts#L11-L18
Some of these might leak only a few actions, but any leaked actions will have a closure that could be referencing a resource.
@benlesh

I have some plans for this I think. 🤔


First UI contribution

Fixes

Fixes #[issue number] by @[issue author]
Description

Technical details

Tests

Screenshots

Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main or master).
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

🙌 @MariamOsman11 ….. ma’am I think you would also need to fill out the details in the Issue to indicate what this PR is doing, and what Issue it is resolving?

@dikehprosper appreciated your suggestion

Thank you for this contribution, but these styles are not inline with the current creative commons styles, that this project needs to move towards. ❤
Closing.

@possumbilities on #62 I fixed comment typing error but had no idea doing PR template. I must do better tommorrow.
my third trial will be merged


[SMALLFIX] Add javadoc for MessageSavingHandler#getMessage, MessageSavingHandler#reset

[SMALLFIX] Add javadoc for MessageSavingHandler#getMessage, MessageSavingHandler#reset

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12882/
Test PASSed.

Merged build finished. Test PASSed.

I have fixed that , thx.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12895/
Test PASSed.

Merged build finished. Test PASSed.

@shizihao123 Thanks for these improvements!


feature request: generated docs should support disabling/enabling features

When I read online documentation, the docs are for the library assuming all the features are turned on. When I search with s I see traits, modules, and functions which are only available for certain features. If I have those features turned off in Cargo.toml then this documentation is at best distracting and at worst misleading. So, the generated documentation UI should provide checkboxes or some other way to toggle features on/off so that you can remove the features that you don't have on when browsing documentation.
I understand that this may require changes in rustdoc.

I think there is a better solution to this, and it is already part way implemented.
When you run cargo doc it creates documentation for all dependencies and takes into account features, which is great. But the generated documentation is missing an index page that lists all the crates.
I tried running cargo doc --open to see what page it defaulted to, but that feature appears to be broken for me.
The search functionality works with all the dependencies' docs together, which is great. I think additionally each doc page should link back to the index. (And there should be an index).

cc https://github.com/rust-lang/rust/issues/16103 (cargo doc basically just calls rustdoc on the various crates.)

Closing as a dupe of https://github.com/rust-lang/cargo/issues/1016


add pypy 3.8 to CI

newer versions are not available via setup-python at the moment

ok, the pypy download page is down, maybe that's causing the problem? the syntax is exactly like in the setup-python docs. will retry once I figure out what happened to the download page.


How can I specify HTTP Method in my routes

Hi y'all!
I saw the fantastic video on the PointFree website demonstrating the ability of this library and I wanted to play around with it.
I've got myself a simple little Vapor app with a House entity and Room entity in order to have a one-to-many relation.
I'm setting up my router like this:
func setupRouter(app: Application) throws {
    let houseRouter = OneOf {
        Route(.case(HouseRoute.house)) {
            Path { "houses"; UUID.parser() }
        }
        Route(.case(HouseRoute.create)) {
            Path { "houses"; }
        }
    }
    app.mount(houseRouter, use: houseHandler)
}

And then I have my handler function looks like this:
func houseHandler(request: Request,
                  route: HouseRoute) async throws -> any AsyncResponseEncodable {
    switch route {
    case let .house(houseId: houseId):
        guard let house: House = try await House.query(on: request.db)
            .filter(\House.$id == houseId)
            .first() else {
            throw Abort(.notFound)
        }
        return HouseResponse(house: house)
    case .create:
        let house: House = try request.content.decode(House.self)
        try await house.create(on: request.db)
        return HouseResponse(house: house)
    }
}

When running the request with a POST HTTP method it fails with the following error:

However if I run the request with a GET HTTP method it succeeds even though a GET request shouldn't have a HTTP body according to the spec:

Now my question is how do I specify in the setupRouter method that the HouseRoute.create enum case maps to a POST HTTP method?

Okay so after doing some digging I found out that the root cause of this failing is because of the following line in Route.swift in the swift-url-routing library.
I forked both repositories and updated the method to this which solved the issue:
@inlinable
  public func parse(_ input: inout URLRequestData) throws -> Parsers.Output {
    let output = try self.parsers.parse(&input)
    if input.method != nil {
        if input.method == "GET" {
            try Method.get.parse(&input)
        }
        else if input.method == "POST" {
            try Method.post.parse(&input)
        }
    }
    try PathEnd().parse(input)
    return output
  }

However I'm not sure how the underlying library works and if you want to just go ahead and hardcode the different HTTP methods in a beautiful nested if else statement 🤷♂

@anhar You can use the Method parser:
Route(.case(HouseRoute.create)) {
  Method.post
  Path { "houses" }
}

I found out that the root cause of this failing is because of the following line in Route.swift

The parser uses the GET method by default if it isn't set on the request.
The swift-url-routing Documentation is a good place to start to see what's available. It might be worth checking out the benchmark suite or even the PointFreeRouter for some example use cases.

The parser uses the GET method by default if it isn't set on the request.

That's not true though, the URLRouting.URLRequestData object has its method property set to POST. See the screenshot below:

This code snippet sets the method property to nil somewhere down the callstack:
Route(.case(HouseRoute.create)) {
    Method.post
    Path { "houses"; }
}

See screenshot here:

@anhar You're right. I meant the parser tries to parse the GET method by default. That way Method.get can be omitted for GET (and HEAD) requests.
The Method parser, will parse the method from the request data which sets it to nil.
Does using Method.post solve the problem or is it still not working as expected?

Hi @anhar, Pat is correct in this situation, and your PR is not how the library should work. It may seem weird, but this logic in Route's parse method is correct:
  public func parse(_ input: inout URLRequestData) throws -> Parsers.Output {
    let output = try self.parsers.parse(&input)
    if input.method != nil {
      try Method.get.parse(&input)
    }
    try PathEnd().parse(input)
    return output
  }

In this method, input is the incoming URL request to your server. If after running the parser on this request the method is still not-nil, then it means that your parser chose not to parse the HTTP method ever (this is because the Method parser consumes the method if it succeeds). So, if that is the case then we force the method to be a GET or HEAD.
So, in your first screenshot it is completely expected that input.method would be POST because your parser did not try parsing the method. And in your second screenshot it is correct for input.method to be nil because then you did start using Method.post to parse the method.
With that said, I do believe you want to specify Method.post in your router for creating a house:
let houseRouter = OneOf {
  Route(.case(HouseRoute.house)) {
    Path { "houses"; UUID.parser() }
  }
  Route(.case(HouseRoute.create)) {
    Method.post
    Path { "houses"; }
  }
}

You can also specify Method.get in the first route, but it is not necessary because it is assumed when left off.


Bugfix/encoder types

Fixes a bug where the encoding of payloads would not work as expected because of mismatched integer types. For instance, the encoder:
function Encoder(fields) {
  return fields.foo;
}

With fields = [1, 2, 3]  returns the error Encoder should return an Array of numbers. This is not correct because you'd expect this to work (all values in the array are integers between 0 an 255).
This PR fixes that by allowing more types (byte, int, int32, uint32, int64, uint64, float32 and float64) to be returned. In case of the floating point types, it returns an error when the value is not an integer value.

Looks good

Changes Unknown when pulling e456eab981063b4f388affb62bea1a28ff30889c on bugfix/encoder-types into ** on refactor**.

Changes Unknown when pulling 8e008634cd46f15c19376f419a2afd43679cb0dd on bugfix/encoder-types into ** on refactor**.


Adding upbit exchange via ccxt

As per Issue 159
@macanudo527 Seems to have worked. Is this the intended way of doing this though?

This should work, but did you add the market? like you did for BOBA and XYM?

@macanudo527, yeah I added them, and tested, but thought I'd keep those for a separate commit just to be cleaner as upbit support is separate from support of a specific coin, but happy to add that here as well if preferred.

I just added the ARK/KRW pair, but let me know if you'd like me to take those back out and add back into a PR containing a bunch of other pairs I'll likely be adding.

Sorry, was I supposed to add a subclass for each new exchange like is done for here for binance, coinbase_pro, and kraken? Happy to do so, but wasn't sure if necessary or not (as code ran without them). I recall reading in another issue that these are for clarity, so happy to add them if needed.

I have a bunch more of these locally in their own linear branch history as separate branches. Do you want them in a single PR or each to their own?


DataList::exists() not working correctly

Affected Version
Silverstripe 4.7
nginx 1.18.0
MariaDB  10.5.5
PHP 7.4.13
installed modules:
axllent/silverstripe-image-optimiser
axllent/silverstripe-scaled-uploads
betterbrief/silverstripe-googlemapfield
bummzack/silverstripe-emogrify
bummzack/sortablefile
dnadesign/silverstripe-elemental
firebrandhq/silverstripe-phonelink
fromholdio/silverstripe-csshelpers
fromholdio/silverstripe-dbhtmlanchors
fromholdio/silverstripe-elemental-group
fromholdio/silverstripe-elemental-inheritablearea
fromholdio/silverstripe-elemental-multiarea
fromholdio/silverstripe-errorpagesconfig
fromholdio/silverstripe-externalurlfield
fromholdio/silverstripe-featureimage
fromholdio/silverstripe-globalanchors
fromholdio/silverstripe-gridfield-limiter
fromholdio/silverstripe-grouploginredirect
fromholdio/silverstripe-heroic
fromholdio/silverstripe-minigridfield
fromholdio/silverstripe-paged
fromholdio/silverstripe-schedulable
fromholdio/silverstripe-simplevideo
fromholdio/silverstripe-singular
fromholdio/silverstripe-sortable
fromholdio/silverstripe-superlinker-ctas
fromholdio/silverstripe-superlinker-megamenus
fromholdio/silverstripe-superlinker-menus
fromholdio/silverstripe-superlinker-redirection
fromholdio/silverstripe-superlinker-targets
fromholdio/silverstripe-systemlinks
fromholdio/silverstripe-urlsegmenter
heyday/silverstripe-responsive-images
heyday/silverstripe-wkhtml
innoweb/silverstripe-breadcrumbs
innoweb/silverstripe-bundled-userforms
innoweb/silverstripe-cmsstickymenupreference
innoweb/silverstripe-default-home
innoweb/silverstripe-dms
innoweb/silverstripe-email-obfuscator
innoweb/silverstripe-enhancedrss
innoweb/silverstripe-form-validation
innoweb/silverstripe-googleanalytics
innoweb/silverstripe-mailchimp-signup
innoweb/silverstripe-metacounter
innoweb/silverstripe-minify-html
innoweb/silverstripe-page-icons
innoweb/silverstripe-prefix-requirements
innoweb/silverstripe-requirements-resolver
innoweb/silverstripe-robots
innoweb/silverstripe-sitemap
innoweb/silverstripe-social-metadata
innoweb/silverstripe-social-profiles
innoweb/silverstripe-social-share
innoweb/silverstripe-tinymce-clearfloats
jonom/focuspoint
littlegiant/silverstripe-persistentgridfield
nglasl/silverstripe-misdirection
sheadawson/silverstripe-rateable
silverstripe/blog
silverstripe/html5
silverstripe/recipe-cms
silverstripe/userforms
stevie-mayhew/hasoneedit
symbiote-library/silverstripe-spamprotection-honeypot
symbiote/silverstripe-gridfieldextensions
symbiote/silverstripe-grouped-cms-menu
symbiote/silverstripe-multisites
toastnz/silverstripe-gridfieldversionedorderablerows
unclecheese/display-logic
webbuilders-group/silverstripe-cmspreviewpreference
wilr/silverstripe-googlesitemaps
Description
Parts of the site I'm working on are not loading, e.g. the menu items list is empty, the list of blog posts is empty. Other parts of the website load fine.
When I change `DataList::exists()' back to 4.6 behaviour
public function exists()
{
    return $this->count() > 0;
}

everything works fine again.
On my local machine with MariaDB 10.4.11 and PHP 7.4.2 everything works fine.

So it is working on your local running Maria 10.4.11 but not with Maria 10.5.5?

Correct, yes.

Weird. I wonder if there's some related Maria change that's causing this, or a bug in a later version of Maria. The way the query is written it should be no different in terms of end result - we essentially just moved the > 0 check into the DB for efficiency.

I am having the same issue on my client's live server.
Silverstripe Framework 4.7.0
PHP 7.2.34
MariaDB 10.1.48

So I'm not crazy. Thanks for confirming. ;)

I have another case on different client's server:
Silverstripe Framework 4.7.0
PHP 7.3.11
MySQL 5.5.62
mysqlnd 5.0.12

@3Dgoo can you test locally whether this has to do with the live environment setting?

I have tried but I cannot recreate this locally yet.
I have set my local environment type to live but the issue does not occur.
I have also set the live server environment type to dev but the issue still occurs there.

On environments where this is failing, what does a "SELECT EXISTS(SELECT ...)" query return? This is the form of the query used internally now.

You could also try debugging the result returned on line 485 of vendor/Silverstripe/framework/src/ORM/DataQuery.php
It's doing a strict-type comparison to a few values; it's possible that another potential return value has been missed.

In the DataList exists() function I have added the following:
if (!$this->dataQuery->exists() && $this->count() > 0) {
    print $this->dataQuery->sql();
}

Here are a few results.
On a FAQPage with a has_many relationship to a DataObject called FAQQuestion trying to get related FAQQuestions:
SELECT DISTINCT "FAQQuestion"."ClassName", "FAQQuestion"."LastEdited", "FAQQuestion"."Created", "FAQQuestion"."Title", "FAQQuestion"."Content", "FAQQuestion"."SortOrder", "FAQQuestion"."FAQPageID", "FAQQuestion"."ID", CASE WHEN "FAQQuestion"."ClassName" IS NOT NULL THEN "FAQQuestion"."ClassName" ELSE 'FAQQuestion' END AS "RecordClassName" FROM "FAQQuestion" WHERE ("FAQQuestion"."FAQPageID" = ?)   ORDER BY "SiteTree"."LastEdited" DESC LIMIT 8

I have debugged the DataQuery exists function. In these cases it looks like result returned is string(1) "1"

Perhaps line 488 of DataQuery.php should be changed from this:
return $result === true || $result === 1 || $result === 't';
to this:
return $result === true || $result === 1 || $result === '1' || $result === 't';

You could also try debugging the result returned on line 485 of vendor/Silverstripe/framework/src/ORM/DataQuery.php
It's doing a strict-type comparison to a few values; it's possible that another potential return value has been missed.

Looks like this was correct - but we did consider this when implementing the ->exists patch in the first place - so it looks like something has changed here.

Great work @3Dgoo! Could this be wrapped in another statement (like count or something) to get a more reliable return value?

I was thinking of something similar to https://github.com/silverstripe/silverstripe-framework/commit/02827a66700f3a1d05ffb4065d1e664da94ee49e

Doing a count with SQL defeats the purpose of the SELECT EXISTS query, as the optimisation is the fact that SQL doesn't have to actually care about the number of records for a filter, just that there's at least one record.
I think that a patch that adds the string result to the check would be suitable for now - although fixing the types returned by the adapter properly would be preferable.

what about a SELECT CASE WHEN EXISTS(...) THEN 1 ELSE 0 END?

Adding "1" to the check seems like a reasonable patch here.

Ok. The "case when" would solve this more reliably though?

I'm not sure that it does. The issue is most likely the type conversion of data being pulled from the DB layer (which is non-trivial). So I suspect that the case statement also returns "1" to PhP in that environment.
It would be handy if you could run the ORM unit tests on an environment with this issue and see what fails; we may also want to consider adding it to our build matrix.

Hm. But wouldn't that be the case for any count and other commands?
The commit I have referenced above uses the case when to fix exactly the same problem.

For anyone stumbling over this:
I had similar issues in other places, but not directly related to exists() (at least I think so).
I was able to fix it by switching from MySQLPDODatabase to MySQLDatabase. see https://github.com/silverstripe/silverstripe-framework/issues/8598 for reference.

Wow. Thank you for that information @xini . That is really good to know.

no worries. ;)

PDO is awful 😆

+1 for @xini 's proposal of SELECT CASE WHEN EXISTS(...) THEN 1 ELSE 0 END (albeit in addition to the extra type checking @sminnee proposed and seems to be in 4.7.1 ) because the current implementation of SELECT EXISTS(...) is invalid T-SQL.
Currently any references to DataList::exists() (which includes multiple default CMS UI's) within my 4.7.1 project using SQL Server fail with errors such as:

[Emergency] Uncaught SilverStripe\ORM\Connect\DatabaseException: Couldn't run query: SELECT EXISTS SELECT * FROM "ProcessStep" WHERE ("ProcessStep"."ReferAFriendPageID" = ?)) 42000, 156, [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'EXISTS'.

Based on the SilverStripe Server Requirements SQL Server is still supported and, rightly or wrongly, the MSSQL module doesn't seem to go anywhere near methods like DataQuery::exists()?


Update image_classification_with_vision_transformer.py

Fix the broken API call to ops.shape

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b6df549) 78.89% compared to head (48c0176) 56.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18738       +/-   ##
===========================================
- Coverage   78.89%   56.25%   -22.65%
===========================================
  Files         336      336
  Lines       33937    33937
  Branches     6651     6651
===========================================
- Hits        26776    19091     -7685
- Misses       5584    13398     +7814
+ Partials     1577     1448      -129

Flag
Coverage Δ

keras
56.25% <ø> (-22.54%)
:arrow_down:

keras-jax
?

keras-numpy
56.25% <ø> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 184 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow to leave an empty description, or at least not cancel the current documentation operation if it occur

I should have the ability to skip questions so I can fill them out myself if needed later without the script canceling all the current documentation operation.
Example:
I have multiple packages related to Fontawesome.
The requirement and verification reasoning is the same for each of them.
It's very tedious to enter the same information over and over again.
So I decided not to fill in the fields for the following packages and to copy/paste them myself by hand at the end of the process.
However, when I left a verification reasoning field empty, an error message telling me that it is mandatory appeared, and the script stopped... and I had to start from the beginning again for all of my descriptions...

You can use the --auto_reply parameter for that.


Check for RPATH

Like checksec, being able to detect RPATH and RUNPATH would be helpful; hardened binaries should exclude this information.

TBF, there's nothing wrong with DT_RPATH per se. It depends on the /value/ to which it is set. The real issues are unqualified paths (missing leading /, tree will be presumed to start from CWD), empty specifications (:: means CWD), use of $ORIGIN (can enable hardlink attacks since it expands to the location of the binary itself), directories that are world/group writable. Also, consider DT_RUNPATH too since this offers similar functionality.

On Sat, Mar 26, 2022 at 06:53:52AM -0700, Tim Brown wrote:

TBF, there's nothing wrong with DT_RPATH per se. It depends on the /value/ to which it is set.

While this is true, I always felt that the value of checksec was making it really easy for people without a security background to run a quick test without worrying about exceptions like this.

The real issues are unqualified paths (missing leading /, tree will be presumed to start from CWD), empty specifications (:: means CWD), use of $ORIGIN (can enable hardlink attacks since it expands to the location of the binary itself), directories that are world/group writable. Also, consider DT_RUNPATH too since this offers similar functionality.

A check for these would certainly be better than simply checking for the simple presence of DT_RPATH and DT_RUNPATH. I think it's safe to first simply check for their presence and then consider implementing a check for their values, since people are somewhat accustomed to the former.


[10.x] Add support for custom $PATH's (like DBngin) for the Schema Dump/import command

In short: this PR allows developers to set a custom path for the database binaries using a bin option in the database connection config, in situations where developers have the mysql, mysqldump pg_dump, pg_restore or sqlite3 commands not automatically in their $PATH, like when using DBngin.
Background
I'm using DBngin to create and manage databases like MySQL and Postgres. Since DBngin manages its installation completely by itself and separate from the "normal" mysql bin in the system (if you have it).
I don't have mysql installed on my system in a general bin directory, since I've been always using DBngin and never had a reason for it.
However, this poses a problem when running artisan schema:dump or when importing the dump:
The command "mysql  --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_LOAD_PASSWORD}" --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}" --database="${:LARAVEL_LOAD_DATABASE}" < "${:LARAVEL_LOAD_PATH}"" failed.

Exit Code: 127(Command not found)

Working directory: /Users/ralphjsmit/Documents/Code/Sites/cj

Output:
================

Error Output:
================
sh: mysql: command not found

In order to solve this problem, DBngin offers a special button to export the environment variables to the terminal. This will open a terminal and paste in the following code:
export PATH=/Users/Shared/DBngin/mysql/8.0.19/bin:$PATH

If you then run the artisan schema:dump command directly after the export, it will work, because we now gave an explicit pointer to the location of the mysql command.
However, if you have tests that are running on MySQL as well, this won't work. Because when running tests (also e.g. via PhpStorm) it won't have the export ... command before the test command.
Summary
This PR aims to solve this problem by providing developers with a way to register a custom location of the mysql, mysqldump pg_dump, pg_restore or sqlite3 command using a 'bin' option in the config/database.php.
I have provided a PR https://github.com/laravel/laravel/pull/6268 to keep the skeleton up-to-date as well.
The PR also adds a full new test for the Postgres schema state, which wasn't tested before.
Thanks!

Well, you are supposed to add this export command to your ~/.profile file, so this path is available globally on your bash session.
Mind, depending on the shell you are using, this file might be ~/.bashrc, ~/.zshrc.
And if you want it available globally you can add this command to your /etc/environment file (using sudo).
In Windows you can add custom binary parhs through Control Panel (at least it used to be there, there are some years I don't use Windows for any development task).
In my opinion, having custom binary paths is not something that should be handled by the framework.
People could have custom paths for many things, like Redis, Memcached, and others.
How multiple paths should be handled?
This is an environment detail, that should be handled by the environment, not by the framework.
In this particular case, if you are running a Linux/Unix/macOS box, you can also use a unix socket, which Laravel already supports to have custom paths. There is some performance gains by using a socket, as there is no TCP negotiation involved.

See above.

@rodrigopedra Thanks!
I know about setting up the .zshrc globally and I also get your part about "how many paths should be handled". However, for DBngin's case this path is supposed to be dynamic and not hard-coded anywhere, so I'm a bit weary to add it to my global .zshrc. In order to solve this then, is there a way to like e.g. create a .zshrc per project/folder, which I can then put in the root of my project?

However, for DBngin's case this path is supposed to be dynamic

Well, from their GitHub issue tracker, this would be the case, if you are using it to run multiple database versions.
Anyway, it seems they are considering having the export added to the user's $PATH
https://github.com/TablePlus/DBngin/issues/117#issuecomment-1755706467
I didn't know DBngin from before, but from the example in that issue, it seems the path only changes when you use a different database version:
export PATH="$PATH:/Users/Shared/DBngin/postgresql/15.1/bin"

And, in that case, you would need to update your project's settings anyway, by your proposal.
This is similar to about running a database server from docker. Unless one maps the binary to a known location, one will need to add a custom directory to their $PATH
Mind that adding to your .zshrc is only "globally" regarding the current user session. If you share your computer with someone else, or use a different user account for personal tasks, the other user's $PATH won't be affected.
Also, if you are running, for example, multiple MySQL versions, you could add multiple directories to the path, so your OS will try to find the binary on each of them.
Something like this (untested, just as an example, not even sure there is a postgresql 16.0)
export PATH="$PATH:/Users/Shared/DBngin/postgresql/15.1/bin:/Users/Shared/DBngin/postgresql/16.0/bin"

From what I could understand, on how DBngin works, unless you have multiple versions of a DB running at the same time, only one of these paths will have the binary when a particular version is running, right?
Is it a must to have multiple DB versions, running at the same time? In a manner, that having multiple directories added to your path, would cause a conflict?
As a last resource, you can add an event listener to the Illuminate\Console\Events\ArtisanStarting, or the Illuminate\Console\Events\CommandStarting events, that run that export command for the current artisan run.
Your listener can read those binaries from a config file if you wish.
It would look like this, from a Service Provider's boot method:
Event::listen(ArtisanStarting::class, function () {
    if ($path = config('app.my_cutom_db_path')) {
        shell_exec(sprintf('export PATH = "$PATH:%s"', $path));
    }
});

I hope this helps =)

Thanks! No, in case it's not possible to e.g. have a folder-specific .zshrc then I guess I need to add it globally.
The thing with DBngin is also that each database server takes the MySQL version that was available at the moment the server was created.
So by now I am running 3 different versions 😄

You can't upgrade these individual servers, so the only way would be to create new services, export db and import a dump again. That's quite time-consuming though, so unless I have a reason to upgrade, I won't.
But anyway, I understand that it's not the intention of the framework framework's to take responsibility for all different paths, so I'll just work with it.
Thanks!

Ah, ok, I didn't know it worked like that... and does the event listener solution work?
If it does, you could make it into a package

@ralphjsmit Quick off topic question: Is there any reason you have multiple server instances for the same version? What distinguishes these instances?

I now added the latest DBngin MySQL version in my .zshrc, but I don't like it and it still doesn't work with PhpStorm testing feature. Using the exec()-things feels kind of dirty tbh.

@dennisprudlo When creating a new database, DBngin takes the latest MySQL version at the moment of creation of the service. There is no way to upgrade a version, unless you manually migrate by creating a new service to replace the old one and export/import all databases etc. So that's why you see these different versions. No functional reason for it therefore.

@ralphjsmit then why not simply creating the databases for an existing server instance? I use a single MySQL 8 DBngin server which has all databases for different projects I am developing. This could reduce some running services on your device – not that this is the issue at hand here 😅

@ralphjsmit alright, thanks for the clarification. I thought that maybe I am missing something and theres is a functional difference when using one service per project. But I see the organizational point 👍🏼