Introduce ButtonStyle equivalent customisation for Slider and RangeSlider

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Customizing Slider and RangeSlider should be as easy as customizing buttons.  Currently customizing Slider and RangeSlider is complex and messy.
Right now just to customize the border radius of the slider components such as track or value indicator you need to copy the source code for that component and modify its radius. We don't do this for any other widget.
Some slider components have radius customization but others don't. it'd be better to have consistent customization as we have for different material buttons.
https://github.com/flutter/flutter/blob/ce32282c0c6ecbe163c668a8d6489d2605077bc2/packages/flutter/lib/src/material/slider_theme.dart#L282-L290
There are separate active, inactive, and disabled colors to be provided. These should be using material states.
https://github.com/flutter/flutter/blob/ce32282c0c6ecbe163c668a8d6489d2605077bc2/packages/flutter/lib/src/material/slider_theme.dart#L267C1-L276
slider_theme.dart:

A lot of component code is repeated with only slight variation.
Default component values are hard coded and not available in a single config class.
Many components aren't customizable and require copying the source code for minor and major customizable.

Proposal

Introduce a ButtonStyle equivalent customization class for Slider and RangeSlider
Add something similar to ButtonStyle.from when you want to just customize default components such as radius, size, elevation, etc.
Regular style class to take entire custom shape components like the current SliderThemeData.
Add material state support track color, mark color, and value indicator color.
Make it as simple as possible to customize any default components of Slider and RangeSlider while keeping the ability to provide your own custom shapes.

I will implement this as part of https://github.com/flutter/flutter/issues/125329

cc: @HansMuller @Piinks
Any feedback would be appreciated.

Would this mean eventually deprecating and removing the properties above?
I think this is a good idea, @HansMuller and @guidezpl may have some material specific thoughts though. :)

I think this is a nice idea. It will require some careful planning. A design doc would be helpful.
I agree with @Piinks about deprecating old redundant API however I don't think we want to introduce changes that cannot be flutter fixed (i.e. that can't be migrated automatically), even if that means leaving some of the old API behind.

I think this is a nice idea. It will require some careful planning. A design doc would be helpful.
I agree with @Piinks about deprecating old redundant API however I don't think we want to introduce changes that cannot be flutter fixed (i.e. that can't be migrated automatically), even if that means leaving some of the old API behind. In that sense this would be unlike the migration to the ButtonStyle et al. API.

+1

I think this is a nice idea. It will require some careful planning. A design doc would be helpful.

Thank you! I'm definitely going to create a design doc.


Conda run pipeline testing

Codecov Report

Merging #8548 into master will increase coverage by 0.73%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #8548      +/-   ##
==========================================
+ Coverage    58.7%   59.43%   +0.73%
==========================================
  Files         511      512       +1
  Lines       23306    23714     +408
  Branches     3824     3836      +12
==========================================
+ Hits        13682    14095     +413
+ Misses       8705     8699       -6
- Partials      919      920       +1

Impacted Files
Coverage Δ

src/client/interpreter/contracts.ts
100% <ø> (ø)
:arrow_up:

src/client/common/process/types.ts
100% <ø> (ø)
:arrow_up:

src/client/common/process/pythonDaemon.ts
22.38% <0%> (-0.17%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
72.64% <0%> (-0.63%)
:arrow_down:

src/client/common/process/condaExecutionService.ts
100% <100%> (ø)

...ient/interpreter/locators/services/condaService.ts
84.33% <100%> (ø)
:arrow_up:

src/client/common/process/pythonProcess.ts
96% <100%> (+0.44%)
:arrow_up:

...rc/client/common/process/pythonExecutionFactory.ts
97.5% <100%> (+4.51%)
:arrow_up:

src/client/common/installer/productInstaller.ts
76.71% <0%> (-0.53%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
100% <0%> (ø)
:arrow_up:

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8874744...eb7625b. Read the comment docs.


Ensure that all llvm.allocas are on the helper's init block.

All llvm.alloca (and their dependencies, which should be constants only) should be appended to the init block, otherwise the tail recursion mechanism will keep allocating more and more stack space every iteration, which is precisely what we want to avoid by using that mechanism.

 I'm a first time contributor and would love to introduce myself in the codebase. Let me know if I can grab this or any other issue :)

@azteca1998 Hello mate. When you say llvm.alloca you mean llvm::alloca? Do i have to check in libfuncs for those things?
Where is the init block?

Hello,
With llvm.alloca I'm referring to the alloca instructions in the llvm dialect. In MLIR they're written as llvm.alloca, but we have them available as llvm::alloca in Rust.
The llvm.alloca instruction accepts other values as arguments. In your example, the argument would be value_len. They also need to be on the init block, otherwise the generated MLIR would be invalid.
All llvm.alloca operations must be in the init block instead of entry or whatever other local block every libfunc has. I know there's at least one place where it's not in the init block.

Hello,
With llvm.alloca I'm referring to the alloca instructions in the llvm dialect. In MLIR they're written as llvm.alloca, but we have them available as llvm::alloca in Rust.
The llvm.alloca instruction accepts other values as arguments (which are dependencies). In your example, the argument would be value_len. They also need to be on the init block, otherwise the generated MLIR would be invalid.
All llvm.alloca operations must be in the init block instead of entry or whatever other local block every libfunc has. I know there's at least one place where it's not in the init block.

In the previous example, llvm::alloca and the dependencie, are in the init block right? Because I'm using the helper where is located the init function.
When you say entry, is the variable we use to call init_block() right? And we dont want that, we want the LibFuncHelper, am I right?

helper.init_block() is the block at which the operation is appended. We want to append the init block (helper.init_block()) instead of entry (the default block for each libfunc), or any other block internally created within the libfunc (only present in complex libfuncs).
Basically, every .append_operation(llvm::alloca(...)) and its dependencies (the constant) should append to helper.init_block().

Ok. And i have to look through all the code of the project, not just the libfuncs directory?

Ideally yes, but outside the libfuncs (and a few helper functions I think) you won't have the helper. If you find something outside libfuncs' implementations just letting us know is fine, we'll fix it later.

This is already done

In my PR of someone else did this? @edg-l


Add Trooper descriptions

Describe the PR
Add descriptions to trooper for NCO's to add
Implements
Implements #143
Changes Made

Add DB Table for descriptions
Add Roster Services for descriptions
Add table on public profiles for descriptions

Any updates on this?

Been busy with work, Will hopefully have time this weekend to work on it.


What convention is used to geotag the example imagery?

I'm having issues with providing the GPS location of images within the exif fields of images. I used the same convention as specified in the script https://github.com/mapillary/OpenSfM/blob/master/bin/update_geotag where GPS information written to each image as follows:

metadata["Exif.GPSInfo.GPSLatitude"] = exiv_lat
metadata["Exif.GPSInfo.GPSLatitudeRef"] = lat_deg[3]
metadata["Exif.GPSInfo.GPSLongitude"] = exiv_lon
metadata["Exif.GPSInfo.GPSLongitudeRef"] = lon_deg[3]
metadata["Exif.Image.GPSTag"] = 654
metadata["Exif.GPSInfo.GPSMapDatum"] = "WGS-84"
metadata["Exif.GPSInfo.GPSVersionID"] = '2 0 0 0'
metadata["Exif.GPSInfo.GPSImgDirection"] = exiv_bearing
metadata["Exif.GPSInfo.GPSImgDirectionRef"] = "T"

This seems to geotag the images, with the information visible in the exif folder after running extract_metadata. After testing on my own datasets, it seems that these geotags are being ignored.
My concern, is that this method seems to be different to that provided in the example data - for example the berlin dataset contains GPS information in the image description field:

My final question would be this: how was the GPS and heading information input to the example data? Was the data added manually by the opensfm team, or was it added automatically by the camera? If it was added using a script, can we have access to it?
Thanks alot!

I'm not sure I understand what you want to do. Do you want to add GPS values to the EXIF in the images before running OpenSfM or after?
The update_geotag script will write the GPS positions obtained after running OpenSfM back to the original image. This is a rare need and you should probably not need to do that.
Otherwise, the information in the ImageDescription tag is used by Mapillary to write additional info to the images that are uploaded to mapillary.com. OpenSfM does not use this information at all. It does only use the standard EXIF tags.

Thanks @paulinus,  this answers my question - mainly I was concerned that I needed to be using the image description field to provide geotags (as is seen in the berlin and lund datasets). I see now that I can just copy the method used in "update_geotag" if I want to geotag images before running the OpenSfM pipeline.


Create Manish kumar.md

Created new md file.

A linked list is a sequence of data structures, which are connected together via links.
Linked List is a sequence of links which contains items. Each link contains a connection to another link. Linked list is the second most-used data structure after array. Following are the important terms to understand the concept of Linked List.
Link − Each link of a linked list can store a data called an element.
Next − Each link of a linked list contains a link to the next link called Next.
Linkedlist − A Linked List contains the connection link to the first link called First.
Linked List Representation
Linked list can be visualized as a chain of nodes, where every node points to the next node.
Linked List
As per the above illustration, following are the important points to be considered.
Linked List contains a link element called first.
Each link carries a data field(s) and a link field called next.
Each link is linked with its next link using its next link.
Last link carries a link as null to mark the end of the list.
Types of Linked List
Following are the various types of linked list.
Simple Linked List − Item navigation is forward only.
Doubly Linked List − Items can be navigated forward and backward.
Circular Linked List − Last item contains link of the first element as next and the first element has a link to the last element as previous.

Insertion − Adds an element at the beginning of the list.
Deletion − Deletes an element at the beginning of the list.
Display − Displays the complete list.
Search − Searches an element using the given key.
Delete − Deletes an element using the given key.
Insertion Operation
Adding a new node in linked list is a more than one step activity. We shall learn this with diagrams here. First, create a node using the same structure and find the location where it has to be inserted.
Linked List Insertion
Imagine that we are inserting a node B (NewNode), between A (LeftNode) and C (RightNode). Then point B.next to C −
NewNode.next −> RightNode;
It should look like this −
Linked List Insertion
Now, the next node at the left should point to the new node.
LeftNode.next −> NewNode;
Linked List Insertion
This will put the new node in the middle of the two. The new list should look like this −
Linked List Insertion
Similar steps should be taken if the node is being inserted at the beginning of the list. While inserting it at the end, the second last node of the list should point to the new node and the new node will point to NULL.
Deletion Operation
Deletion is also a more than one step process. We shall learn with pictorial representation. First, locate the target node to be removed, by using searching algorithms.
Linked List Deletion
The left (previous) node of the target node now should point to the next node of the target node −
LeftNode.next −> TargetNode.next;
Linked List Deletion
This will remove the link that was pointing to the target node. Now, using the following code, we will remove what the target node is pointing at.
TargetNode.next −> NULL;
Linked List Deletion
We need to use the deleted node. We can keep that in memory otherwise we can simply deallocate memory and wipe off the target node completely.
Linked List Deletion
Reverse Operation
This operation is a thorough one. We need to make the last node to be pointed by the head node and reverse the whole linked list.
Linked List Reverse Operation
First, we traverse to the end of the list. It should be pointing to NULL. Now, we shall make it point to its previous node −
Linked List Reverse Operation
We have to make sure that the last node is not the last node. So we'll have some temp node, which looks like the head node pointing to the last node. Now, we shall make all left side nodes point to their previous nodes one by one.
Linked List Reverse Operation
Except the node (first node) pointed by the head node, all nodes should point to their predecessor, making them their new successor. The first node will point to NULL.
Linked List Reverse Operation
We'll make the head node point to the new first node by using the temp node.
Doubly Linked List is a variation of Linked list in which navigation is possible in both ways, either forward and backward easily as compared to Single Linked List. Following are the important terms to understand the concept of doubly linked list.
Link − Each link of a linked list can store a data called an element.
Next − Each link of a linked list contains a link to the next link called Next.
Prev − Each link of a linked list contains a link to the previous link called Prev.
LinkedList − A Linked List contains the connection link to the first link called First and to the last link called Last.
Doubly Linked List Representation
Doubly Linked List
As per the above illustration, following are the important points to be considered.
Doubly Linked List contains a link element called first and last.
Each link carries a data field(s) and two link fields called next and prev.
Each link is linked with its next link using its next link.
Each link is linked with its previous link using its previous link.
The last link carries a link as null to mark the end of the list.

Insertion − Adds an element at the beginning of the list.
Deletion − Deletes an element at the beginning of the list.
Insert Last − Adds an element at the end of the list.
Delete Last − Deletes an element from the end of the list.
Insert After − Adds an element after an item of the list.
Delete − Deletes an element from the list using the key.
Display forward − Displays the complete list in a forward manner.
Display backward − Displays the complete list in a backward manner.
Insertion Operation
Following code demonstrates the insertion operation at the beginning of a doubly linked list.
Example
//insert link at the first location
void insertFirst(int key, int data) {
//create a link
struct node link = (struct node) malloc(sizeof(struct node));
link->key = key;
link->data = data;
if(isEmpty()) {
//make it the last link
last = link;
} else {
//update first prev link
head->prev = link;
}
//point it to old first link
link->next = head;
//point first to new first link
head = link;
}
Deletion Operation
Following code demonstrates the deletion operation at the beginning of a doubly linked list.
Example
//delete first item
struct node* deleteFirst() {
//save reference to first link
struct node *tempLink = head;
//if only one link
if(head->next == NULL) {
last = NULL;
} else {
head->next->prev = NULL;
}
head = head->next;
//return the deleted link
return tempLink;
}
Insertion at the End of an Operation
Following code demonstrates the insertion operation at the last position of a doubly linked list.
Example
//insert link at the last location
void insertLast(int key, int data) {
//create a link
struct node link = (struct node) malloc(sizeof(struct node));
link->key = key;
link->data = data;
if(isEmpty()) {
//make it the last link
last = link;
} else {
//make link a new last link
last->next = link;
  //mark old last node as prev of new link
  link->prev = last;

}
//point last to new last node
last = link;
}


swagger-ui redirect on /ui to /ui/ uses absolute URL, breaking things when behind a proxy

Description
If you access the auto-generated GUI at http://HOST/BASE_PATH/ui, you get redirected to the canonical URL http://HOST/BASE_PATH/ui/. However, this redirection uses an absolute URL rather than a relative one, which means if you are accessing the GUI via a reverse proxy, inside a Docker container, etc., the redirect fails.
Expected behaviour
Attempting to access the GUI at http://HOST/BASE_PATH/ui should generate a HTTP 308 redirect where the Location field contains the correct relative path, i.e. /BASE_PATH/ui/.
Actual behaviour
The Location field contains an absolute path, including the hostname and port:
[vagrant@localhost ~]$ wget --no-check-certificate -S https://redacted.ca-central-1.elb.amazonaws.com:85/api/healthcheck/v1.0/ui
--2022-03-30 19:25:14--  https://redacted.ca-central-1.elb.amazonaws.com:85/api/healthcheck/v1.0/ui
Resolving redacted.ca-central-1.elb.amazonaws.com (redacted.ca-central-1.elb.amazonaws.com)... 35.999.999.146, 3.999.999.200
Connecting to redacted.ca-central-1.elb.amazonaws.com (redacted.ca-central-1.elb.amazonaws.com)|35.999.999.146|:85... connected.
WARNING: cannot verify redacted.ca-central-1.elb.amazonaws.com's certificate, issued by ‘/C=ca/ST=redacted/L=redacted/O=redacted/CN=redacted-dev-12.aws/emailAddress=redacted’:
  Self-signed certificate encountered.
    WARNING: certificate common name ‘redacted-dev-12.aws’ doesn't match requested host name ‘redacted.ca-central-1.elb.amazonaws.com’.
HTTP request sent, awaiting response...
  HTTP/1.1 308 PERMANENT REDIRECT
  Date: Wed, 30 Mar 2022 19:25:52 GMT
  Content-Type: text/html; charset=utf-8
  Content-Length: 309
  Connection: keep-alive
  Server: nginx/1.19.2
  Location: http://healthcheck-ms:5000/api/healthcheck/v1.0/ui/
  vary: Origin
  Access-Control-Allow-Origin: *
  Access-Control-Expose-Headers: DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Authorization,Access-Control-Allow-Origin,Upgrade,Connection
  X-Kong-Upstream-Latency: 3
  X-Kong-Proxy-Latency: 3
  Via: kong/2.6.0
  Strict-Transport-Security: max-age=31536000
2022-03-30 19:25:15 ERROR 308: PERMANENT REDIRECT.

Steps to reproduce

Create a minimal Swagger server:

app.py:import connexion.resolver

if __name__ == '__main__':
    app = connexion.App(__name__, specification_dir='swagger/')
    app.add_api('swagger.yaml', resolver=connexion.resolver.RestyResolver('api'), pythonic_params=True)
    app.run(port=5000)

swagger/swagger.yaml:swagger: "2.0"

info:
  version: 1.0.0
  title: Healthcheck Microservice
  license:
    name: MIT

basePath: /api/healthcheck/v1.0

schemes:
  - http
consumes:
  - application/json
produces:
  - application/json

paths:
  /placeholder:
    get:
      summary: "Placeholder"
      responses:
        '200':
          description: 'Placeholder'

api/placeholder.py:def search():
    pass

Run the above server in a Docker container with hostname healthcheck-ms
Set up a reverse proxy which forwards api/healthcheck/ to port 5000 of the Docker container
Attempt to access wget --no-check-certificate -S ${REVERSE_PROXY}/api/healthcheck/v1.0/ui

Additional info:
Python version: 3.7.10
Connexions version: connexion[swagger-ui]==2.6.0
See also:

#887

Hi @macdjord please try the latest version of connexion. It should be fixed there.


Upgrade Almost done.

Backend Packages compatibilities  - FIXED
Minor FrontEnd Issues still present - TO BE FIXED

because of the django_tables2 it is tricky to migrate the changes to the DB
One quick fix would be to migrate in steps:
First we do:
./ manage.py migrate notification

And the we do:
./ manage.py migrate openduty

Then we can check it by running the general migrate
./ manage.py migrate

Operations to perform:
  Apply all migrations: admin, auth, contenttypes, django_celery_beat, django_twilio, notification, openduty, schedule, sessions
Running migrations:
  No migrations to apply.
(.venv) mac:catalin$


The first minute of some of the audio transcriptions is missing [BUG]

The first minute of some of the audio transcriptions is missing.
This happens when I upload multiple audio files to be transcribed.
I'm not sure what causes this, since the audio quality of the first minute is as clear as the rest of the audio.
I use the CPU version on a small laptop, so it may be that because of the processor limitations, and me working on the same laptop with another application, this results in loss of information during the transcription. I will test this with another, stronger PC.
Anyhow, there is no warning or indication that there is data loss or transcription issues. Is there a way for the program to check this in real time?

can you help giving me some sample for it? so that i can replicate the bug

Anyhow, there is no warning or indication that there is data loss or transcription issues. Is there a way for the program to check this in real time?

Hmm, this might actually be possible, i could maybe try splitting up the file input into little pieces. I'm gonna have to think about this first


External renderers to PDF

Feature Description
In short: allow external renderers to output PDF, automatically display it using pdf.js.
Use case: PowerPoint (pptx) files cannot be easily converted to HTML, however, they can be quality printed to PDF.
Printing files of a custom format to PDF may be a good alternative to a lossy conversion to HTML for some other formats too.
I thought about working around this by outputting <iframe ... src=".../viewer.html?file=..."> from a renderer, but it's a hack.

👍🏻 I would like to render $\LaTeX$ to pdf as in HTML* some parts get omitted such as \maketitle.
*Using RENDER_COMMAND  = "timeout 30s pandoc -f latex -t html --self-contained --template /etc/gitea/basic.html" with basic.html only containing $body$
Then again I am not sure am I doing it at all correctly 😅

If we have a generic HTML to PDF, all the requirements could be resolved.

@lunny, it is not about generating PDF, it's about rendering externally-generated PDF in Gitea. As described, and I did so, is possible to write an external rendered that generates a PDF file and outputs <iframe (attributes) src="(URL prefix)/viewer.html?file=(PDF URL)">. It will show an iframe with PDF rendered alright by PDF.js in modern browsers. But there are bits that cannot be solved well without Gitea integration:

(attributes) depend on the Gitea HTML template, the most important are width and height, style may be relevant.
(URL prefix) depends on the Gitea public URL.
(PDF URL) must be accessible according to the permissions configured in Gitea.
It is highly desired to avoid generating the PDF multiple times. But this caching must be after authorization.

Then again I am not sure am I doing it at all correctly 😅

I was not doing it correctly. The solution was to pandoc -D html and pick what I wanted to basic.html expanding from $body$ to
$for(include-before)$
$include-before$
$endfor$
$if(title)$
$title$
$if(subtitle)$
$subtitle$
$endif$
$for(author)$
$author$
$endfor$
$if(date)$
$date$
$endif$
$endif$
$if(toc)$
$idprefix$TOC
$if(toc-title)$
$toc-title$
$endif$
$table-of-contents$
$endif$
$body$
$for(include-after)$
$include-after$
$endfor$

which may bring out more issues or having too much information once I use it more. For example title and author currently appear as normal text.
Regardless of having mostly resolved my $\LaTeX$ rendering issue, I think rendering pdf instead is going to look better and closer to what the document authors wish for.

I completely agree on this!
Allowing external PDF rendering would basically mean, I don't need to compile my Latex code on my computer to view a PDF.
I could just open the .tex file in the web GUI and see the same file, I created on my local environment.
It would very much help me preparing for exams!
I would be willing to pay a bounty on such a PR in case anyone is interested.

Just wanted to add support for this - this would be a very welcome addition. proper latex would be a game changer.


CB-9828 Implements PlatformApi contract for WIndows platform

Implementation for https://issues.apache.org/jira/browse/CB-9827
Main highlights:

All logic from cordova-lib/windows_parser and plugman/windows_handler now moved into platform
Platform is now able to do a prepare and plugin installation (through API)
Console logging was replaced with events usage (shared w/ cordova) so log level now appied to platform as well as to the lib.

The updated platform compatible with old cordova versions (as it still exposes main functionality through batch/shell scripts).
Also the mobliespec application builds sucessfully and mobilespec tests are passing without any regressions.

I looked through all of the PR and didn't find anything concerning other than the one thing I commented on. But it's a lot of code in an area I'm not at all familiar with.

Generally looks fine to me apart from some misplaced "Android" references I mention inline. Also, it concerns me that ConsoleLogger is duplicated across each platform - isn't this something that can live in cordova-common? Why aren't we using the same functionality as cordova-cli?

Addressed notes and fixed compatibility<EMAIL_ADDRESS>Regarding logging, agree, we should move it common, but i propose to follow more general way - add necessary functionality to 'common', release it and update platforms (this affects iOS and Android as well) to use released 'common'. @TimBarham, @jasongin, thoughts?

Refactoring logging into common sounds good, but we shouldn't block this change on it.

This was merged in 58047a3


Update Get-SPEnterpriseSearchQueryScopeRule.md

Format example

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Get-SPEnterpriseSearchQueryScopeRule.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Reference pages for 'tile util' APIs - set 1

Put in some reference pages for the 'arcade-tile-util' APIs. This is just a partial set. I'll do a PR for the balance of them shortly.
Feel free to add/suggest more descriptive info/annotations.
RE: https://github.com/microsoft/pxt-arcade/pull/4691

@riknoll - you'll have to do the merge.


add wandb with api call - suitable for runninng docker images

Run with command
docker run -e WANDB_API_KEY= dockername:dockertag


As a developer, I want to have build tools to help with my development process, and ensure code quality

It is a good idea to start putting in place build tools and a build process for the application, as it is likely to get more complex over time.

+1

Matt Taylor
OS Community Flag-Bearer
Numenta
On Wed, Dec 16, 2015 at 6:50 AM, Jeff Fohl<EMAIL_ADDRESS>wrote:

It is a good idea to start putting in place build tools and a build
process for the application, as it is likely to get more complex over time.
—
Reply to this email directly or view it on GitHub
https://github.com/rhyolight/smartthings.htm.bridge/issues/11.


improvement(libs/header): Check for requested height before fetching it from the store

Overview
Resolves https://github.com/celestiaorg/celestia-node/issues/1697
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Codecov Report

Merging #1706 (a0bd8bc) into main (f66c36f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
+ Coverage   56.07%   56.08%   +0.01%
==========================================
  Files         231      231
  Lines       15148    15157       +9
==========================================
+ Hits         8494     8501       +7
+ Misses       5751     5748       -3
- Partials      903      908       +5

Impacted Files
Coverage Δ

libs/header/interface.go
0.00% <ø> (ø)

libs/header/mocks/store.go
64.91% <100.00%> (-4.18%)
:arrow_down:

libs/header/p2p/server.go
70.12% <100.00%> (-4.10%)
:arrow_down:

libs/header/store/store.go
62.81% <100.00%> (-0.83%)
:arrow_down:

libs/header/p2p/session.go
83.33% <0.00%> (-4.67%)
:arrow_down:

libs/header/p2p/helpers.go
64.58% <0.00%> (-4.17%)
:arrow_down:

share/ipld/get.go
92.14% <0.00%> (-1.24%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


How to see errors from console engine?

I have no idea hot effectively check errors during executions.
I do cargo run => out.txt right now, and then I see the errors in the terminal, but it is not efficient.

Hello ! Thank you for opening this issue.
I'm working on implementing a panic hook when using console_engine. For now it works but I still need to figure out how to properly display the message because the terminal prompt is written above it.
I should have something done soon.

Hello. Thank you for reply. That would be great. This is the only significant problem I found in this engine. Otherwise, it works great.
I wish you luck in solving this problem.

The issue has been fixed, into Release 1.2.0

@gravit22 I forgot to ask you, is the bug fixed with this new version ?

@gravit22 I forgot to ask you, is the bug fixed on your side with this new version ?

Yeah. I can see the errors now. Thank you.


Generate instance keys, improve UI

This adds a better UI for bot instance keys, using Bootstrap modals and clipboard.js.  It also generates keys for existing bot instances (in a migration) and upon creating a new instance (in a before_create callback.)

I actually can't find anything to nitpick in this. Nice! :)


[#3546] fix(core): overwrite the relationship when insert overwrite user and group

What changes were proposed in this pull request?
The user, group insert overwrite semantics are not update the relationship with role.
we should overwrite the relationship
Why are the changes needed?
Fix: #3546
Does this PR introduce any user-facing change?
/
How was this patch tested?
ut

Unrelated CI pipeline is canceled, will merge it anyway.


Proof of Concept for Erubi

Just realized your offer to skim the proof of concept mentioned in tmuxinator#792 needed a matching pull request

@jimtahu I didn't mean to encroach with those commits, but I wanted to bring this PR up-to-date and re-trigger the build to see what Code Climate was complaining about.

I'm inclined to ignore these Code Climate failures and am considering increasing the default complexity threshold which is causing them.

@jimtahu I didn't mean to encroach with those commits, but I wanted to bring this PR up-to-date and re-trigger the build to see what Code Climate was complaining about.

No complaints from me, thanks for the pull up

I'm going to merge this PR soon for all the reasons outlined in the linked issue. It appears to work great and passes all our testing after I recently rebased it with master. Let's finally merge it!


Problem with Nested Tabs in CoreUI Angular

When trying to implement nested tabs in an Angular component using CoreUI Angular's c-tabs and c-tab-panel, the second-level tabs are not working as expected. Specifically:
When clicking on a top-level tab (first level), the nested tabs (second level) appear, but the content of the first nested tab (second level) does not load automatically.
After clicking on another nested tab (second level) and then switching back to the first nested tab, the content is displayed correctly.

@oarque We’re not quite sure what layout you have in mind. Could you please attach a screenshot for reference?


Simplify trait bound used in LogId and Membership

Sure, no problem with that. I think we won't need other types in LeaderId/LogId/etc. in the future anyway.
Probably the same can be done for MembershipConfig, though not 100% sure, since it might be interesting to parameterize the BTreeSet out (linear search on 3-5 node IDs is typically faster than trying anything more fancy, but this is likely not on hot path).

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)

Originally posted by @schreter in https://github.com/datafuselabs/openraft/pull/221#pullrequestreview-895955266

All tasks done


APL/SAND no audio after running setup-audio script using "sof"

Describe the bug
No audio after reboot.  Sound still shows only "Dummy Output".  setup-audio script completed without reporting any errors.  Ran it a second time and rebooted but no change.  This is running under Linuxmint 21 install over Mr ChromeBox UEFI.  For context:  When I was previously working with Breath/Ubuntu, I had audio after running that audio setup script. (I think you know that project was terminated.)
Boardname
SAND
Logs
Attempted to run debugging.sh script but it fails with: lspci not found. Please install pciutils.
Attempted sudo apt install pciutils and it reports pciutils is already the newest version (1:3.7.0-6)
Ran lspci and it identifies a "Multimedia audio controller" (output attached).
Ran hwinfo and it identifies a "Multimedia audio controller" (output attached).
lspci.txt
hwinfo.txt

Can you send dmesg, please?

Any other suggestions of things I can try?  Or things I can check and provide to you for analysis?  This is a clean system -- I can easily rebuild it as needed -- so wondering if installing Ubuntu and trying that would be worth the effort.  As mentioned earlier, I had audio 95% working under Breath/Ubuntu.  That was using PulseAudio; the PipeWire efforts (at that time) weren't working well enough.

This looks like a kernel regression based on dmesg. AVS will likely work just fine, just be careful if you override the speaker protection.

Could you clarify what actually happens with the speakers under AVS with the max98357a?  I'd like to better understand what options I have to manage the risk if I chose to enable the speakers.  Like, do I ensure I never go above 50% volume or something like that?  Or is the risk more invisible to the user so that it is not really controllable?
Quoting you from this thread :
"There is something wrong with the AVS (and older SKL) driver that makes the left channel heat up faster than the right channel, causing damage."

By "heat up", I understand you to mean that the volume level on the left channel increases faster than the right channel and can then blow your left speaker?  Or are you actually referring to physical heat that damages the module?

"software is used to limit the maximum audio output."

By "limit" I understand it means "disables" since the prompt during setup of AVS states the speakers are "disabled".

By "heat up", I understand you to mean that the volume level on the left channel increases faster than the right channel and can then blow your left speaker? Or are you actually referring to physical heat that damages the module?

Physical heat which causes speakers to melt.

By "limit" I understand it means "disables" since the prompt during setup of AVS states the speakers are "disabled".

ChromeOS audio configuration limits the maximum playback db level.

Lastly, is there a way to "revert to stock" if I choose to no longer use your setup-audio? Is it just a matter of reverting to the stock kernel?

What exactly do you mean by stock?

What exactly do you mean by stock?

Sorry, I was unclear.  I was referring to reverting to an earlier kernel; i.e., the 5.15 kernel which LinuxMint 21.1 installs by default.  But, again, my question is really, "If I choose to no longer use your setup-audio, what steps do I take to "undo" what it does?

The kernel doesn't really matter. Idk why you'd want to remove audio but you can just delete the modprobe config in /etc/modprobe.d/, either sof or avs. That will make the kernel use the default driver, which is the non-functional SKL driver. UCM doesn't really matter when the driver does nothing, same with firmware and topology.

The kernel doesn't really matter. Idk why you'd want to remove audio but you can just delete the modprobe config in /etc/modprobe.d/, either sof or avs. That will make the kernel use the default driver, which is the non-functional SKL driver. UCM doesn't really matter when the driver does nothing, same with firmware and topology.

Thanks for clarifying.  I assumed that it used an updated kernel because uname -r returns 6.6.0-chrultrabook and you wrote in this thread that "the minimum supported kernel version is now 6.4".  I just began going through the setup-audio code but I am not a Python programmer.  I became very familiar with the setup-audio script used under Breath so I do know some of what is happening.
My goal is to have: 1) speaker audio, 2) audio over BT headphones, 3) built-in microphone, and 4) audio over HDMI -- in that order.  But neither of the SOF or AVS options seem to provide a driver that does this.  AVS did provide headphone audio on my system but I don't care about that.  SOF is supposed to provide speaker audio but, so far, that hasn't worked on my system.  BT audio works under both (maybe not affected by this driver?).  Neither provide HDMI audio.
If you're willing to keep working on this issue, I'm willing to continue.  Yet, given that SOF isn't doing what you indicate it does on other APL systems, I wonder if I've got a one-off problem.  My reference to "undoing" the changes made by setup-audio is based on my experience and thinking I might need to try going back to what was being done under Breath since that was working on my system at one point.

Thanks for clarifying. I assumed that it used an updated kernel because uname -r returns 6.6.0-chrultrabook and you wrote in this https://github.com/WeirdTreeThing/chromebook-linux-audio/issues/60#issuecomment-1826800430 that "the minimum supported kernel version is now 6.4". I just began going through the setup-audio code but I am not a Python programmer. I became very familiar with the setup-audio script used under Breath so I do know some of what is happening.

Just note that while this script was originally a rewrite of the breath script, it has now evolved into something completely different.

My goal is to have: 1) speaker audio, 2) audio over BT headphones, 3) built-in microphone, and 4) audio over HDMI -- in that order. But neither of the SOF or AVS options seem to provide a driver that does this. AVS did provide headphone audio on my system but I don't care about that. SOF is supposed to provide speaker audio but, so far, that hasn't worked on my system. BT audio works under both (maybe not affected by this driver?). Neither provide HDMI audio.

That is doable when the SOF issues get resolved. Bluetooth is completely unrelated to the internal audio DSP which is why it works just fine, same goes for usb audio. Not sure why HDMI audio didn't work with the AVS driver, since that should work just fine.

If you're willing to keep working on this issue, I'm willing to continue. Yet, given that SOF isn't doing what you indicate it does on other APL systems, I wonder if I've got a one-off problem. My reference to "undoing" the changes made by setup-audio is based on my experience and thinking I might need to try going back to what was being done under Breath since that was working on my system at one point.

APL SOF may just be broken on that kernel version, ideally we can get someone else to test it. Breath used the SKL driver on APL machines which requires old chromeOS kernels with various patches applied on top, which is less than ideal.

That is doable when the SOF issues get resolved.
APL SOF may just be broken on that kernel version, ideally we can get someone else to test it.

SOF was working fully for APL devices previously?  Given that, if you have other things for me to try, let me know; I have time to put into this.
I assume the SOF driver is maintained somewhere?  Is there somewhere I can monitor for updates?  Or is that just going to be here?  Also, I had the impression that AVS was the "new thing" and going to replace SOF -- maybe that's incorrect?

libasound2-data/now 1.2.8-1pop1~1669155503~22.04~a04c9a1 all [installed,local]
libasound2/now 1.2.8-1pop1~1669155503~22.04~a04c9a1 amd64 [installed,local]

Those are the packages from PopOS

Oh, right. Missed seeing the "installed" marker in the apt list  That they didn't appear with ldconfig threw me.
So, what do you recommend add the next step?
Is there merit in submitting an issue to SOF Project?

SOF will likely work on an older kernel, maybe try uninstalling the chrultrabook kernel. apt list --installed | grep linux-image- will get you a list of kernels on your system.

What I did:

Via grub, I reverted to the original 5.15.0 kernel installed with LM 21.2.  I rebooted and still only "Dummy Output" sound device.
Via Synaptics, I removed the 6.6.0-chrultrabook kernel -- yeah, I realize this shouldn't be necessary, but trying anything -- and rebooted.  No change.
Via update manager, I installed the 6.2.0 kernel, rebooted, made it active via grub.  No change.

Are there other steps I need to take besides switching the kernel?

Send dmesg from 5.15.

On 6.2:
[   10.221840] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: sink widget DMic overwritten
[   10.221859] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp3 Tx(*) -> hifi3
[   10.221868] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp3_out -> iDisp3 Tx(*)
[   10.221874] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp2 Tx(*) -> hifi2
[   10.221879] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp2_out -> iDisp2 Tx(*)
[   10.221884] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp1 Tx(*) -> hifi1
[   10.221889] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp1_out -> iDisp1 Tx(*)
[   10.221899] bxt_da7219_max98357a bxt_da7219_mx98357a: snd_soc_bind_card: snd_soc_dapm_add_routes failed: -19

On 6.6:
[    9.165511] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: sink widget DMic overwritten
[    9.165526] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp3 Tx(*) -> hifi3
[    9.165535] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp3_out -> iDisp3 Tx(*)
[    9.165540] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp2 Tx(*) -> hifi2
[    9.165545] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp2_out -> iDisp2 Tx(*)
[    9.165550] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp1 Tx(*) -> hifi1
[    9.165555] bxt_da7219_max98357a bxt_da7219_mx98357a: ASoC: Failed to add route iDisp1_out -> iDisp1 Tx(*)
[    9.165563] bxt_da7219_max98357a bxt_da7219_mx98357a: snd_soc_bind_card: snd_soc_dapm_add_routes failed: -19

These are the exact same errors, which leads me to believe the topology is the problem. I need to do some testing on my APL, I'll get back to you when I find out what's happening.

One thing I thought of is the sof binaries in LM might be too old. Using a newer distro may work better, or you could manually update sof fw/tplg.

Ubuntu 22.04 is the exact same as Linux Mint. I haven't had the time to test on my APL yet, hopefully soon.

Ubuntu 22.04 is the exact same as Linux Mint, you would want to test 23.10. I haven't had the time to test on my APL yet, hopefully soon.

I can give that a try.  However, I had understood that the steps taken in setup-audiodid the necessary to apply the sof fw/tplg to the kernel and that was used after the reboot.  Reading through the SOF materials on their site, that's what I gathered.

The script will install the distro package for sof (with the exception of jasperlake devices) so if your distro has old packages then sof firmware/topology will also be old.

Sof audio is working on my APL running Fedora.

Sof audio is working on my APL running Fedora.

Which version?  Have you tried it on any Ubuntu variant or downstream distro?

Fedora 39. I have not tried Ubuntu.

I just installed Fedora-Cinnamon 39 and ran your setup-audio.  I now have sound through the speakers.  I do not have any microphone.  Does your microphone work?

As per usual on SOF, the mic is pretty quiet. Using commands to increase the volume to 200% does help.

Thanks, I'll look at increasing the mic volume. I also have a really small USB mic that was working previously under Breath so I'll try that, too.
Given that it's working under Fedora, I'm going to try the Ubuntu 23.10 to see if it works there. I'm much more familiar with the Debian/Ubuntu  system model and would prefer not having to learn to do things all over again.  I'll report back.

I confirmed that SOF is working under both Fedora-Cinnamon 39 and Ubuntu 23.10 and all audio devices are present except the headphone jack.
Thank you for your work on this and helping me to find a resolution.  It seems the current options are:

Switch to Fedora 39 and learn new ways of doing things -- like dnf instead of apt.
Switch to Ubuntu 23.10 -- and live with its walled garden of snaps. 👎
Stay on LinuxMint and wait for the release based upon 23.10.

NOTE1: Initially, the microphone was not available as an input device under either OS.  But, for both, I went to mictests.com (which is part of my test list for validation) and was able to select each of the listed audio inputs.  One of the listed audio selections would be the actual microphone (the others were monitor devices) and after selecting it, the test would succeed and then the microphone would appear as a device.  Sort of like some configuration was completed in this selection process to make it available.
NOTE2: Just for completeness, I tried installing the 6.5 mainline kernel (How to Install Linux Kernel 6.5 on Linux Mint 21 or 20) then ran setup-audio but this was not successful; still only Dummy Output appears in the sound app.

Switch to Fedora 39 and learn new ways of doing things -- like dnf instead of apt.

Luckily, the dnf command syntax is similar to apt. So the switch should be relatively easy.

Stay on LinuxMint and wait for the release based upon 23.10.

LM only ships LTS releases of upstream Ubuntu, so the next LM release will be 24.04, which is over 4 months away.

Initially, the microphone was not available as an input device under either OS.

This seems to be a strange issue with GNOME, as I have not been able to reproduce that issue on any other DE.

NOTE2: Just for completeness, I tried installing the 6.5 mainline kernel (How to Install Linux Kernel 6.5 on Linux Mint 21 or 20) then ran setup-audio but this was not successful; still only Dummy Output appears in the sound app.

The kernel isn't the issue, old SOF firmware/topology is the issue. You can manually upgrade SOF by downloading the latest release of sof-bin and following the instructions in the tarball to upgrade. I've never done this before so I don't exactly know how manually upgrading it works.

Back again :-)  I'm trying to get this to work on LinuxMint Edge (which uses the 6.2 kernel).  I tried just using the instructions from the SOF site and running the install.sh script then rebooted, but that didn't fix the audio.
One thing I noticed between the install on fedora (after running your setup-audio script) and the LM default install is that lspci shows fedora Kernel driver in use: sof-audio-pci-intel-aplwhile LM shows Kernel driver in use: snd_soc_skl.  So, there must be something else I need to do to cause it to use the correct driver?  But, so far, I haven't found anything that helps me know what to do to switch the driver.

UPDATE: I installed Pop!_OS to test this and the sound doesn't work there after cloning and running the setup-audio.  (It seemed reasonable to test it given that the topologies for ubuntu and LM are pulled from that distro's repositories.)  Given that it doesn't work on Pop!_OS it makes sense that it doesn't work on LM, either.
$ python3 --version
Python 3.10.12
$ git --version
git version 2.34.1

While I was able to get sound on Fedora 39 Cinnamon, I don''t prefer the constant updates of being on the bleeding edge.

I installed Ubuntu 23.10 and, as before, after running setup-audio, the sound is working.  I'm going to try grabbing the libraries from the 23.10 repositories and see if that gets things working on LM.

One thing I noticed between the install on fedora (after running your setup-audio script) and the LM default install is that lspci shows fedora Kernel driver in use: sof-audio-pci-intel-aplwhile LM shows Kernel driver in use: snd_soc_skl

That would suggest that the SOF driver for APL isn't enabled for whatever reason.

I installed Ubuntu 23.10 and, as before, after running setup-audio, the sound is working. I'm going to try grabbing the libraries from the 23.10 repositories and see if that gets things working on LM.

So 23.10 ships with a new enough kernel and new enough sof.

I saw your note about not supporting ubuntu anymore.  But, for those who might encounter this thread, I wanted to report that running the setup-audio on my device running LinuxMint 22.0 worked without issue.  Again, thanks for all your work on this.

I saw your note about not supporting ubuntu anymore.  But, for those who might encounter this thread, I wanted to report that running the setup-audio on my device running LinuxMint 22.0 worked without issue.  Again, thanks for all your work on this.


remapvid doesn't build on Raspberry Pi Zero 2 W (Bullseye)

The Meson build system
Version: 0.56.2
Source dir: /home/pi/Video/remapvid
Build dir: /home/pi/Video/remapvid/build
Build type: native build
Project name: remapvid
Project version: 0.0.1
C compiler for the host machine: cc (gcc 10.2.1 "cc (Debian 10.2.1-6) 10.2.1 20210110")
C linker for the host machine: cc ld.bfd 2.35.2
Host machine cpu family: aarch64
Host machine cpu: aarch64
meson.build:27:2: ERROR: Include dir /opt/vc/include does not exist.
A full log can be found at /home/pi/Video/remapvid/build/meson-logs/meson-log.txt

You need to build and install userland library on Bullseye.
Please check README on how to do it.


Create guides for how to make an OP payment

We need guides for making a one-time payment and a recurring payment.
/guides/make-onetime-payment.mdx
/guides/make-recurring-payment.mdx

Done


Error report: batch changes and compute delta

Logging of TeX messages to the editor is almost append-only: during a run, content can only be appended, but when backtracking the current output is truncated, before appending again.
To prevent flickering or accidentally scrolling the output, it is necessary for the editor to wait a bit before reflecting these changes.
The heuristic implemented by emacs mode is to truncate only at the end of a run, and replace the output line by line during the run. This provides a decent look'n'feel, but can still feel slow if the output is updated too fun, without any benefits (e.g to receive 100 lines, it can be the case that the editor refresh the screen 100 times, once per line).
This heuristic with extra batching (e.g. wait for a buffer to fill up and delay updates by a bunch of milliseconds) is probably better implemented in TeXpresso itself rather than in the editor mode. Furthermore, if other editors were to be supported in the future (e.g. (n)vim), it is better to place as much logic as possible in TeXpresso itself.

Actually, a line oriented protocol would be simpler.
Rather than "(append text)" and "(truncate length)", it would be "(set-line index text)" and "(set-line-count number)". This could be made opt-in an editor could decide which one is better.
The goal is to make the logic as simple as possible on the editor side and prevent flickering when a buffer is being updated.

Implemented in 6364dc9280326711048975b4e2c9c5313231eeda.


update HISTORY and CHATHISTORY

Suggested by lover. We could use the standard Go syntax for durations.

Originally this ticket was just to make /history take a time duration as an argument. I'm updating it to include implementing a new draft of the chathistory specification.

Closed in #792


Update/Create script to handle the upgrade for non-HA/HA rancher server tags

Update the python script or create a new script better suited to update a rancher/server for non-HA and HA setups that will be used by Jenkins automation for Upgrade Validation.
The script will need to be able to log into the host or hosts and update accordingly for the type of rancher server setup (non-HA or HA)

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Task 5.4 Write a function to write/update company database

Related to user story #13

It works like intended. Done!


Some confusion about blacklist identification.

Hi, @Pooran-Dewari
Thank you for these additions to the Blacklist software for identifying problematic regions of the genome. There are a few more details about identifying Blacklist areas that I'd like your advice on.
The number of Input data is critical if one wants to identify Blacklist regions from scratch, so the collected data often contain different reads lengths and different sequencing models ( Single-end 36bp, Single-end 50bp, Single-end 100bp, Paired-end 100bp , Paired-end 150bp), how should the kmer be chosen at this time, and the limits on the uniqLength. I'm actually trying to integrate data from different lengths of single-ended as well as double-ended to characterize the Blacklist region.
According to your advice, I have changed blacklist.cpp from int uniqueLength = 36 to int uniqueLength = 100. For combined unit8.unique(k75, k100, k150), how should I choose an appropriate uniqLength before compiling, even though the author says that the value of uniqLength needs to correspond to the value of kmer in the generated unit8.unique file?
Looking forward to your reply.
Best regards.
Yao

Hi Yao,
thanks for your email, it's been some time I have run this analysis. If I
remember correctly, for mixed kmers, the value has to be the lowest number.
I think the best would be to ask the developer of the original program,
they reply really quick if you raise an issue on the github.
good luck
On Mon, Oct 21, 2024 at 1:12 PM Miracle-Yao @.***>
wrote:

Hi, @Pooran-Dewari https://github.com/Pooran-Dewari
Thank you for these additions to the Blacklist software for identifying
problematic regions of the genome. There are a few more details about
identifying Blacklist areas that I'd like your advice on.
The number of Input data is critical if one wants to identify Blacklist
regions from scratch, so the collected data often contain different reads
lengths and different sequencing models ( Single-end 36bp, Single-end 50bp,
Single-end 100bp, Paired-end 100bp , Paired-end 150bp), how should the kmer
be chosen at this time, and the limits on the uniqLength. I'm actually
trying to integrate data from different lengths of single-ended as well as
double-ended to characterize the Blacklist region.
According to your advice, I have changed blacklist.cpp from int
uniqueLength = 36 to int uniqueLength = 100. For combined
unit8.unique(k75, k100, k150), how should I choose an appropriate
uniqLength before compiling, even though the author says that the value of
uniqLength needs to correspond to the value of kmer in the generated
unit8.unique file?
Looking forward to your reply.
Best regards.
Yao
—
Reply to this email directly, view it on GitHub
https://github.com/Pooran-Dewari/create-blacklist-fie-for-ChIP-seq-analysis/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQFKS47CKITVG5XWAN4R3NDZ4TVRJAVCNFSM6AAAAABQKAVJI2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDEMZWGAZDGMY
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

--
best wishes
-Pooran

Dr Pooran Dewari
Postdoctoral research associate
Roslin Institute
University of Edinburgh
UK

Thanks for your suggestions! Maybe I should try some more.

Hi, @Pooran-Dewari
There is no record of sex chromosomes in the blacklist file you gave at the end, does this mean that no sex chromosome-associated blacklist region was identified by Blacklist? In fact, I don't have one either, just wanted to throw this out there to discuss with you.
Looking forward to your reply.
Best regards.
Yao


testing: using "go tool test2json dlv test-binary" marks the last test as failed on Mac OS

This is continuation of #23033 which is still actual in go1.13.
To reproduce the issue create <GOPATH>/src/debugTest/foo_test.go:
package foo

import "testing"

func Test1(t *testing.T) {
}

compile it:
go test -c -o testBinary -gcflags "all=-N -l" debugTest

run:
go tool test2json dlv --listen=:2345 --headless exec testBinary -- -test.v

and connect debugger from another console: dlv connect :2345.
In the Delve console type continue and once the testBinary terminates, exit the delve client via the exit command.
Test2json produces output:
{"Action":"run","Test":"Test1"}
{"Action":"output","Test":"Test1","Output":"=== RUN   Test1\r\n"}
{"Action":"output","Test":"Test1","Output":"--- PASS: Test1 (0.00s)\r\n"}
{"Action":"output","Test":"Test1","Output":"PASS\r\n"}
{"Action":"fail","Test":"Test1"}

This happens because on Mac OS Delve runs programs via debugserver and debugserver uses \r\n line-endings. For most of test output it is not a problem because test2json check prefixes and is not affected by line-ending differences. But for final PASS or FAIL the exact Equal check is used and it fails due to added \r.
This behavior was accidentally fixed in d47526ed777958aa4a2542382e931eb7b3c4c6a9, but judging by comments in #31969 the fix will be reverted later.
I understand that this is not a bug in test2json. Test2json assumes the output is produced by the test framework and the test framework always uses \n. It is possible to wrap Delve and replace PASS\r\n in its output to PASS\n, but every test2json client will have to do that. Maybe it is possible to support this case in test2json itself?
In #23033 there was a question: why one would want to debug a test and also see the its final status. The most relevant use-case I can think of is a modification of a program state during debug session. Let's say I have a complex algorithm test for which started to fail. During a debug session I've found a potential problem. I cannot easily change the sources and rerun a test because the fix is complicated, but I can change the program state at runtime. I want to verify that changing some value in a program produces a desirable effect and test starts to pass. At the moment it is not possible as the test status is always "fail".

Why do you run
go tool test2json dlv --listen=:2345 --headless exec testBinary -- -test.v

instead of
dlv --listen=:2345 --headless exec testBinary -- -test.v

?  How does running under go tool test2json make it easier to debug the program?

Why does delve output \r\n rather than \n when its standard output is not a terminal?  Where is that coming from?

Test2json is used to simplify test output parsing, json is easier to parse than the raw output produced by test executable. Test2json output is consumed by an editor and is shown in a dedicated UI where each test has an icon according to its status. It is easier to grasp tests status from such a view than from reading output of all tests. Test2json doesn't change the debugging experience per se, but it is useful to be able both debug a test and see its outcome once debug session is over.
If I understand correctly Delve redirects debugserver output to its stdout without changing anything. @aarzilli could you please confirm?

This thing with tests getting \r\n on macOS came out before and I couldn't figure out where it happens. The way it works is that delve runs the test executable under debugserver and then debugserver sends us the output in a stop packet (it's the 'O' kind). It already contains the \r there so either debugserver is adding it (werid) or possibly the tty layer in the kernel (weirder).

Why not simply add :
bytes.Equal(line, []byte("PASS\r\n"))
in the boolean clause? ( https://github.com/golang/go/blob/5c6f42773cec9eb217e258e104ee058f67253f72/src/cmd/internal/test2json/test2json.go#L158 )
and be done with it?

bump
This breaks GoLand test parsing: https://youtrack.jetbrains.com/issue/GO-6493

It looks like debugserver creates a new pseudo terminal for the inferior and by default terminal has the ONLCR flag set which maps NL to CR-NL.


Say, if social security number is encrypted, in general, how tough is it to crack it down?

That very much depends how it's encrypted. Keyczar can use a lot of different methods. That said, most of them are going to be extremely strong; infeasible to crack given the technology we know about.
However, if someone gets their hands on your keys, it's a different story. If you're worried about security, focus of securing your keys as much as possible.

Well noted and indeed makes sense.


Sidecar ingress ports binds to <IP_ADDRESS>, binding it to instance IP provides more flexibility

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Sidecar ingress ports binds to <IP_ADDRESS>, binding it to instance IP provides more flexibility for other listeners to use the same port.
We (Salesforce) are using the same port for different purposes based on IP. Like:
<IP_ADDRESS>:9090 - Egress Listener
<IP_ADDRESS>:9090 - HostIP + Port - Ingress Listener
Here, we want to use Sidecar to be able to configure both the listeners.
Describe alternatives you've considered
No alternatives found for what we want to achieve as <IP_ADDRESS>:port listener will conflict with any other listener.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
Additional context

Thanks for the PR..
tangent: can the salesforce folks also take a look at https://github.com/istio/api/pull/899 to see if I have captured everything?

The PRs are merged for this functionality, closing the issue. Thanks.


bug in get_relative_airmass(model='youngirvine1967')

Describe the bug
pvlib python implements the Young and Irvine 1967 model as:
    elif 'youngirvine1967' == model:
        am = ((1.0 / np.cos(zenith_rad)) *
              (1 - 0.0012*((1.0 / np.cos(zenith_rad)) ** 2) - 1))

The published formula is
am = sec(z) * (1 - 0.0012 * (sec(z)^2 - 1))

See http://adsbit.harvard.edu/cgi-bin/nph-iarticle_query?bibcode=1967AJ.....72..945Y&db_key=AST&page_ind=3&plate_select=NO&data_type=GIF&type=SCREEN_GIF&classic=YES
If you squint very hard you might notice that pvlib python's implementation is equivalent to
am = sec(z) * (1 - 0.0012 * sec(z)^2 - 1)

Versions:

pvlib.__version__: 0.5.2. I probably broke it when cleaning up code in the 0.1-0.2 era.

Additional context
Discovered when implementing #158. Write good unit tests! I'll make a pr with a fix soon.

Nice squinting.

closed by #546


Suggesting bunx to execute bunpare

I suppose that having bun installed it would make sense to suggest using bunx to execute the bunpare.

Summary by CodeRabbit

Documentation

Updated the prepare script in the README to recommend using bunx bunpare instead of npx bunpare, enhancing clarity on script execution methods.

Chores

Adjusted command execution practices to align with updated recommendations for the Bun environment.

@RobinTail Thank you for your contribution.
Actually, Bun automatically convert npm to bun and npx to bun x, so don't worry.


No text replacement for 'MY_LOCATION'

Text replacement for 'MY_LOCATION' does not work when using it as destination.
Have not confirmed if limited to 'share-trip' branch.

Issue resolved in feature/newtabs and/or other branches?
Pinging @OskarHahr


Why the post/pre hook does not work as expected?

Describe The Bug
[tasks.default]
alias = "lib"

[tasks.lib]
script = "echo lib"

[tasks.post-lib]
script = "echo post-lib"

[tasks.pre-lib]
script = "echo pre-lib"

It seems the post/pre hook does not work, but it is mentioned in the document.
Do I miss something? I need to do some job in this post/pre way.
To Reproduce

Error Stack
The error stack trace

Code Sample
/// paste code here

its not automatic, its just a naming convention and for each default pre/post, i have a task that run all 3 (pre, task, post).


Huge Update (V3.0 ?)

General

Cleaner Code and more Comments
Increased the range of i from (0,4) to (0,5)
The Last Recent Played Match/Run Time has been fixed (didn't came further than 24h)
The Last Recent Played Match/Run Time has Day Support now

Regular Matches / Ranked / League

Because of the increased range of i, the Rich Presence is able to show an extra state/detail for In-Game Name and Level
IGN Support
If player has a prestige, a Level star would show up with a number that indicates how many times the player's Prestiged
The RP will show the Kill (Assist) / Death Ratio now (Was Kill/Death Ratio first)
If the Recent Played Match was in a Ranked Lobby, the RP will show the Players Rank of that specific Played Rank Mode (X Rank/Power Supported)
If the Recent Played Match was in a Ranked Lobby, the RP will show the League Power of it (only after 7 Played League Battles)

Salmon Run

Showing now the Correct Time of Last Played Run (was showing the Last Played Match of Turf, Ranked etc. first)
Checks how many Total Waves were played in Last Run and calculates the total collected Golden Eggs / Power Eggs
Added Save/Death Ratio
Shows how many points you have for your Rank

Misc

A Video Tutorial is being made by me how other people can easily setup the Splatoon 2 Rich Presence with their own Account, coming soon!

Oh my lord this is awesome - give me a few hours to review this and check through the code (living my best mobile life right now)

This seems all good to me!

Thank you! ^^
Here are some examples for Ranked and League
Ranked

League

Again, thank you for merging the Fork!


Support other types of RNNs of cuDNN

cuDNN RNN supports various types of RNNs. Currently Chainer supports only LSTM (NStepLSTM).

[x] ReLU
[x] Tanh
[x] GRU
[x] Bidirectional

I have NStepGRU which wraps cuDNN GRU. I'll send a PR soon.

I am interested in Bidirectional. I'm very glad to see the cuDNN RNN in Chainer. I'd like to use this in spaCy.

I think the NStepLSTM class should be generalised to NStepRNN. Flags can control direction and mode. There can be subclasses for the combinations if desired. I've started work on this:
https://github.com/honnibal/chainer/commit/73ebedc7c932291f2142c21c9095c64f8ccd8036
I haven't tested this yet. Does the approach look okay? It should be quite easy to finish.

Thank you! @ywatanabex @honnibal
Actually we are now developing this feature. And, @honnibal 's implementation is what I want to make!
Now we are investigating the details of the specification of cudnn-rnn. We found two points:

cx can be null when a user selects GRU
definition of GRU is different from Chainer's one

Okay, so you are developing this in another branch?

Thank you! @honnibal
I think there is no-branch for this issue.
Please send your PR, I'll help your code.

Hi, here is my Bidirectional GRU code:
https://github.com/ywatanabex/chainer/commit/865f2b6d0c525e80ae78e62ec0c7ca61df300510
Hopefully, this is helpful to implement general cuDNN-RNN wrapper.

All RNN types are now supported.


Update invalid zip files from previous versions

The existing zip files were from 0.1.2 version. Probably someone forgot to update them when bumping versions in package.config.


Support objects with no prototype

Currently xtend crashes when operation involves objects created via Object.create(null)

Very keen observation. Thank you.

Published v4.0.1


Integration

How to best interface with mimesis, provider only?

more of an epic really

Ensure StatsSchema works with:

dummy provider
multivariable and distribution providers
some mimesis providers
pandas dataframes

Some of the above are now included as tests. Having an accompanying e2e would probably capture this now. Regression tests would be useful once seed setting stable.


Add filtering to "select member for group" view. This commit provides…

… the ability to filter by member, owner, first name, last name, email, identifier, and status. (CO-1881)

Note that pagination conditions are dealt with directly in the select() method of the CoGroupMembersController. Unlike the index() method that separates these out (up in StandardController), there is no select() method in CoGroupMembersController's ancestors.

The force push: I'd forgotten to add the search.inc file to the original commit.

It's not clear that $managed is a sufficient check in isAuthorized().


[ATO-1206] Use FilteringBoundLogger for structlog

Structlog should use FilteringBoundLogger which runs logging pipeline only on the level which is indicated.
Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

BTW, I've flagged to Engine that LM featurizers Windows tests are failing suspiciously, please feel free to skip these tests on Windows so we don't get blocked on PRs.


[Android] - TimePicker instant crashing app

My application crashes as soon as I open TimePicker(only on android, iOS works fine).
Before everything works fine, but some day just start crashing.
I tried already TimePickerAndroid original from react-native and it's work, there is no app crashing.
Please help!!!
My code is:
<DateTimePicker mode="datetime" datePickerModeAndroid={"time"} isVisible={true} onConfirm={this._handleDatePicked} onCancel={this._hideDatePicker} />
Environment:
OS: macOS High Sierra 10.13.6
Node: 10.1.0
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.1 AI-173.4819257
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.4 => 0.55.4
Repo version(I already tried last version, did not help)
"react-native-modal-datetime-picker": "^5.1.0",
Thanks in advance,
kind regards.

Hi @franj0 ,
I'm sorry but we need more details about the crash, do you have any log about it?
Also please try using the example that you can find in the example dir of the app and see if it works correctly for you.

hi @mmazzarolo,
that it's point, I don't have any logs in debug mode in console. App just crash instantly when TimePicker need to be rendered.
I have only logcat from Android Studio and there is some log, but I don't get it.
Tomorrow I'll try example from repo but today I don't have time.

@franj0 your datePickerModeAndroid prop is invalid, the available values are: calendar or spinner.
See the readme and/or the RN docs for more info 👍
Let me know if it fixes your issue.

@franj could you try removing the datePickerModeAndroid prop?

@mmazzarolo thank you, it's working now, you can close this :)

Thank you @arthur31416 , I guess it's just a leftover of an old API change


Update to bitcoinjs-lib v5

This is ready for review & merge IMO, however, I have no issue with waiting some period of time for bitcoinjs v5 to be time tested.

@hstove

@zone117x have you seen any recent issues with v5?

I haven't seen any, I think we should merge this.
The bitcoinjs lib and dependency now reference the native secp256k1 lib as an optionalDependency, so node-gyp errors no longer fail installs.


Signup: Match app to design: alignments, positions and line width

All the signup screen should look alike in terms of alignments, positions and line width
The input field line should be at the same positioning and width at all screens.

dup of #768


introduce devPlatform kit configuration

Hello :wave:
The changes here introduce a devPlatform option for the kit config so that developers can provide their own platform mocking implementation for local development.
Given the conversation in #4292, @rich-harris' pushback), #3535, #8397, and so on... I am aware that the changes here might just get rejected but I wanted to propose them anyways as I think that this could be a valid short/medium term solution that many developers could take advantage of right now (instead of making them indefinitely wait for a better solution that might or might not come at some point in the future).
From an outsider's perspective and the issues I mentioned above (which seem pretty stale) I don't know what the Svelte team's current plan is regarding this issue, if you have a different/better solution in the works that can be applied soon-ish that'd be awesome, but if you don't please give this PR's a second thought since this clearly seems to be an issue that various developers struggle with. Moreover please note that the changes here are pretty minimal so they should be very simple to deprecate/remove in the future if a better alternative does get implemented.
As an example of the use of this devPlatform config, I've implemented this simple demo which shows how this could be used to locally develop an application using a Cloudflare KV binding, you can see here how the devPlatform is being set and here how it is being used.
Currently the only alternative workaround that can allow developers to use bindings with the Vite dev server is by leveraging server hooks, I included an example of that here. As you can see this is much much more cumbersome than the proposed API and also effects the production build, so it's definitely not a great alternative in my opinion.
Additionally I'd like to point out that there's a precedence of such an API, QwikCity is actually doing the exact same thing in their Vite plugin (see their docs), showing that even if not perfect this seems to be an acceptable solution for this problem.

resolves #4292
(also #4908, and maybe more)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This would be great

Yeah, I agree, this doesn't feel like the right API. Until we figure out how we want to have adapters affect dev mode, I think the best option is to have a handle hook that does some assignments in an if (dev) { ... }, as mentioned in the PR description. This gets treeshaken out of production builds. It seems like an entirely acceptable workaround to me.

This feels like the wrong API to me. I think it'd be better if the adapter could be used to provide the platform in dev mode as well

@benmccann are saying that you'd be ok with this approach if I moved the devPlatform to be part of an adaptor config instead? or are you saying that this feels like the wrong approach/API full stop?

Yeah, I agree, this doesn't feel like the right API. Until we figure out how we want to have adapters affect dev mode, I think the best option is to have a handle hook that does some assignments in an if (dev) { ... }, as mentioned in the PR description. This gets treeshaken out of production builds. It seems like an entirely acceptable workaround to me.

As I also mentioned in the PR description, I do agree with you saying that there might be a better solution on how adapters should effect dev mode as a whole, what I am questioning here is: when is that solution going to be implemented? any time soon? if not, wouldn't it be nice to provide a valid stopgap easily-removable/deprecatable solution that can help solving the issue right now?
Regarding the handle solution again I kind of do agree with you that it is a kind of acceptable but it does still required developers to implement this hands-on hack which does have (even if minimal) implications in the production build (since the dev code can be tree shaken away but the handle itself cannot).
Basically what I'm trying to ask here is, are the benefits of implementing such a change outweighed by the cons?

Thinking about what the implementation will look like for some of that stuff, it's probably quite finicky and involves a lot of knowledge of the internals, so if you're cool with it @dario-piotrowicz then maybe it's more logical for us to pick it up from here? Appreciate all the work that you've put into it so far!

I've made a start in https://github.com/sveltejs/kit/pull/11730, though there are a few TODOs and open questions still outstanding

@Rich-Harris Thanks so much for looking into this 🙂
We on the Cloudflare team are really keen and hopeful to get this sort of dev bindings support ready as soon as we can. We're also working with other framework authors to apply the same across the whole js ecosystem.
Whatever you think it's best, both for your framework and for hopefully expedite this feature's implementation works for us, and we're always happy to keep working on this and/or support in any other way we can.
So yeah please feel free to take it over if you want, but I am always here to pick it back up and/or help in any manner I can.

Thank you @dario-piotrowicz! If you have any pointers on how to populate caches and context, and how to test it locally (see notes on the other PR), we'd be very grateful. Also, is it okay that we're not calling bindings.dispose but are just killing the process?

Probably a useless comment here that you are all already aware of, but wrangler-proxy is a great example of how to use wrangler in development for SK - but I thought it might help 🤷♂


TIMEPERIODSUMMARY omitted dataset_count

This product: https://explorer.dev.dea.ga.gov.au/products/ls5_fc_albers is showing total of 33,482 datasets, in the explorer time_overview table adding all the month up total count is 33540. It also lists 58 dataset_count against start_day 2011 but all the center_time are only from 2010 as per snippets below. The listed 2011 is also not showing up in the menu bar

odc=> select start_day, dataset_count, period_type from cubedash.time_overview where product_ref = (select id from cubedash.product where name = 'ls5_fc_albers') and dataset_count > 0;
 start_day  | dataset_count | period_type
------------+---------------+-------------
 2010-11-01 |          3796 | month
 2010-12-01 |          4172 | month
 2010-01-01 |         33482 | year
 2011-01-01 |            58 | year
 2010-01-01 |          3776 | month
 2010-02-01 |          4332 | month
 2010-03-01 |          2120 | month
 2010-04-01 |          3804 | month
 2010-05-01 |          3071 | month
 2010-06-01 |          1430 | month
 2010-07-01 |           740 | month
 2010-08-01 |          1102 | month
 2010-09-01 |          2001 | month
 2010-10-01 |          3138 | month
 2011-01-01 |            58 | month
 1900-01-01 |         33482 | all
(16 rows)

odc=> select sum(dataset_count) from cubedash.time_overview where product_ref = (select id from cubedash.product where name = 'ls5_fc_albers') and dataset_count > 0 and period_type = 'month';
  sum
-------
 33540
(1 row)

odc=> select count(*) from agdc.dataset where dataset_type_ref = (select id from agdc.dataset_type where name = 'ls5_fc_albers') and archived is NULL;
 count
-------
 33540
(1 row)

odc=> select count(*) from agdc.dataset where dataset_type_ref = (select id from agdc.dataset_type where name = 'ls5_fc_albers') and archived is NULL and metadata->'extent'->>'center_dt' LIKE '2011%';
 count
-------
     0
(1 row)

odc=> select count(*) from agdc.dataset where dataset_type_ref = (select id from agdc.dataset_type where name = 'ls5_fc_albers') and archived is NULL and metadata->'extent'->>'center_dt' LIKE '2010%';
 count
-------
 33540
(1 row)

opendatacube=# select start_day, dataset_count, period_type from cubedash.time_overview where product_ref = (select id from cubedash.product where name = 'ls5_fc_albers') and dataset_count > 0;
 start_day  | dataset_count | period_type
------------+---------------+-------------
 1900-01-01 |         33482 | all
 2010-01-01 |         33482 | year
 2010-01-01 |          3776 | month
 2010-02-01 |          4332 | month
 2010-03-01 |          2120 | month
 2010-04-01 |          3804 | month
 2010-05-01 |          3071 | month
 2010-06-01 |          1430 | month
 2010-07-01 |           740 | month
 2010-08-01 |          1102 | month
 2010-09-01 |          2001 | month
 2010-10-01 |          3138 | month
 2010-11-01 |          3796 | month
 2010-12-01 |          4172 | month
(14 rows)

opendatacube=# select count(center_time)  from cubedash.dataset_spatial where center_time between '2010-12-01' and '2010-12-31';
 count
-------
  4059
(1 row)

opendatacube=# select count(center_time)  from cubedash.dataset_spatial where center_time between '2010-12-01' and '2010-12-31 23:';
 count
-------
  4172
(1 row)

opendatacube=# select count(center_time)  from cubedash.dataset_spatial where center_time between '2010-12-01' and '2010-12-31 23:59:59';
 count
-------
  4230
(1 row)

opendatacube=# select count(id) from agdc.dataset;
 count
-------
 33540
(1 row)

opendatacube=# select count(id) from cubedash.dataset_spatial;
 count
-------
 33540
(1 row)

opendatacube=# select count(*) from cubedash.dataset_spatial where tstzrange('2010-12-01 00:00:00+09:30', '2011-01-01 00:00:00+09:30', '[]') @> cubedash.dataset_spatial.center_time;
 count
-------
  4172
(1 row)

opendatacube=# select count(*) from cubedash.dataset_spatial where tstzrange('2010-01-01 00:00:00+09:30', '2011-01-01 00:00:00+09:30', '[]') @> cubedash.dataset_spatial.center_time;
 count
-------
 33482
(1 row)

opendatacube=# select count(*) from cubedash.dataset_spatial where not tstzrange('2010-01-01 00:00:00+09:30', '2011-01-01 00:00:00+09:30', '[]') @> cubedash.dataset_spatial.center_time;
 count
-------
    58
(1 row)

opendatacube=# select center_time from cubedash.dataset_spatial where not tstzrange('2010-01-01 00:00:00+09:30', '2011-01-01 00:00:00+09:30', '[]') @> cubedash.dataset_spatial.center_time limit 10;
       center_time
--------------------------
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
 2010-12-31 23:33:13.5+00
(10 rows)

Proposed solution:

add extra logic to check if total dataset count matches the summary total count, if not match add more years to include the rolled over
make Australia/Darwin configurable for africa and antarctica projects

jez < 1 minute ago
It looks like the product range is stripping time zone in this function -- so the very first/last few hours of a product can be skipped:  https://github.com/opendatacube/datacube-explorer/blob/4afa0dbbb51d541f377c479e7edb914bdb62aef9/cubedash/summary/_stores.py#L131-L154


.entries() does not return keys

Hi
.entries() does not return keys, but values. See example:
var m = Map.Empty;
m = m.set('first', 1);
m = m.set('second', 2);
m = m.set('third', 3);
m.entries();      // [ [ 3, undefined ], [ 1, undefined ], [ 2, undefined ] ]

@myaskevich nice to see see you here!
This project is a part of my research on immutable data structures. All the ground work was done in https://github.com/ActiveObject/immutable-trie. If you are interested in immutable data structures I highly recommend https://facebook.github.io/immutable-js/. It's a mature project that you can use for production.

Hi @ActiveObject
Thanks!
I was looking for Immutable OrderedMap implementation as a separate package and stumbled upon your project.
I didn't want to pull the entire monster-size immutable-js package just to use Maps.
Also it's quite cool to see how the internals work, because immutable-js is huge and it's easy to get lost in details.
Keep up the good work and thanks again for the fix!

Hi @ActiveObject
Thanks!
I was looking for Immutable OrderedMap implementation as a separate package and stumbled upon your project.
I didn't want to pull the entire monster-size immutable-js package just to use Maps.
Also it's quite cool to see how the internals work, because immutable-js is huge and it's easy to get lost in details.
Keep up the good work and thanks again for the fix!


🌱 Add option to execute HTML

Summary
This PR introduces a second generation docs-ecutable technology, which extracts the bash from the generated HTML. This has the advantage of having the Jinja processing already done on it.
This is built on #1548 and will be rebased after that merges.
Related issue(s)
Fixes #

/cc @clubanderson
/cc @francostellari
/cc @pdettori
/cc @ezrasilvera

The force-push to d8e9f7594 is a rebase plus removing the unnecessary Python installs from the workflow.


If save_state support automatic_checkpoint_naming, then load_state should be able to load latest checkpoint

save_state support automatic checkpoint naming (as checkpoint_0, checkpoint_1) and also deleting old checkpoints.
However, when one wants to load_state, he needs to first parse which checkpoint is the latest and also manually set current iteration in project config.
This is quite inconsistent in my opinion.

cc @muellerzr

needs to first parse which checkpoint is the latest and also manually set current iteration in project config.

I think the PR fixed the first issue (checkpoints names are parsed automatically) but not the second one (current iteration is not set). So if I save a checkpoint, load it, and try to save again, I get Checkpoint directory {output_dir} ({self.save_iteration}) already exists... error. Is that correct? If so, I wonder if we should reopen the issue, and I can PR in a fix (or if I'm misunderstanding something, please let me know how to use this functionality correctly).


Missing field: minecraft:breedable/breed_event/filters

Example:
{
    "breed_event": {
        "event": "minecraft:entity_born",
        "target": "self",
        "filters": {
            "test": "is_variant",
            "value": 0,
            "subject": "self"
        }
    }
}

Notes:

self is self
other is also self
player doesn't work

Should be working, can you confirm? @SirLich


Convenient Fuzz Tracing

Saves recompilation for turning on fuzzer debugging

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Wasn't squelch=false in the test runner?
And only true in the actual fuzzer (which is only run in clusterfuzz anyway)?

It was set to true in the .cc file itself, and so the output was squelched when I was manually invoking the fuzzer to fix some bugs: aka, bins/dbg/api_fuzzer

Curious when that would be needed vs just invoking the one_entry variants,
but ok.
On Mon, Aug 7, 2017, 11:31 AM Noah Eisen<EMAIL_ADDRESS>wrote:

It was set to true in the .cc file itself, and so the output was squelched
when I was manually invoking the fuzzer to fix some bugs: aka,
bins/dbg/api_fuzzer
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/12009#issuecomment-320743741, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJpudVP5ew_88jMDub7wxda7PTdPyaY7ks5sV1gIgaJpZM4OpEN7
.


Bluetooth: Controller: ISOAL ASSERT failure

Describe the bug
An ASSERT failure occurs in subsys/bluetooth/controller/ll_sw/isoal.c isoal_get_wrapped_time_us()
To Reproduce
Steps to reproduce the behavior:

Using nRF52840DK
Edit samples/bluetooth/broadcast_audio_source/src/main.c and set
BROADCAST_SOURCE_LIFETIME  (13 * 2 * 30U)
Build samples/bluetooth/broadcast_audio_source
Build samples/bluetooth/broadcast_audio_sink
Run the samples for > 8-9 minutes (until 24-bit ticker wraps)
ASSERT occurs
N.B. subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c isr_rx_iso_data_valid() sets timestamp

Expected behavior
ASSERT should not occur.
Impact
Low priority.
Environment (please complete the following information):

OS: Windows
Toolchain: zephyr-sdk-0.15.1
commit 9a491a1b5b434549ce7b7a83aacab12eab4dd14e

Additional context
RTT log attached.
broadcast_audio_source_20221117.txt

@niag-Oticon could you analyse?

One of the input time values has most likely exceeded what was considered to be the maximum possible absolute time of the controller's clock in microseconds.
i.e. #define ISOAL_TIME_WRAPPING_POINT_US      (HAL_TICKER_TICKS_TO_US(HAL_TICKER_CNTR_MASK))
I guess the sum in isr_rx_iso_data_valid() that sets the time-stamp would probably do that when the ticker reaches the end of it's 24-bit range. Let me see if I can get this running locally. Our environment has issues building the upstream.
But is the rationale that we should not see absolute time values that exceed the controller's clock's range sound for Nordic?

@carlst The fix should be available in v3.3.0-rc1, if you still see issue, please reopen this issue.


Fix shortcodes in “Encrypting Secret Data at Rest”

Fix shortcodes in https://kubernetes.io/docs/tasks/administer-cluster/encrypt-data/ [preview] following Hugo upgrade.

/retitle Fix shortcodes in “Encrypting Secret Data at Rest”

@sftim, Would you squash your commits? Thanks!

@sftim, Looks like there was only a couple of areas that actually required changes.
The rest of the changes are additional cleanup and new note shortcodes.

I've done this as two commits to keep the changes logically separate.

I've done this as two commits to keep the changes logically separate.

@sftim Yes, I understand. However, the changes are on one page and interelated.
If I make an exception for this PR, I will feel obliged to make the same exception for every PR that does not squash the commits.
What do you think?

/assign

If I make an exception for this PR, I will feel obliged to make the same exception for every PR that does not squash the commits.

When changes are logically separate I usually recommend separating them. Both in this project and elsewhere, I've actually asked people to “unsquash” a commit: separating logically separate changes into 2 different commits. It helps with reverts, for example, and with understanding the history from git annotate.
This is different from the situation where you have an initial attempt then several fixups following code review. Once the set of changes look right, it's definitely appropriate to squash the fixups.
In summary: I think it's not only OK to sometimes have PRs with more than 1 commit, it can actually be good thing.

/lgtm

/approve


Adds Grand Lizard (Williams 1986)

Adds vpx-grandlizard
This includes magna save remapping, which could be used on other titles if needed (e.g. Black Knight, World Cup Soccer).

The rest of the PR looks good, but could you modify the root README.MD and add a link to the table?

Nm, on the README.MD. I see the extra commit and it's showing. I must have missed it.
Thanks for using branching.