Update jQuery to 3.7.0

jQuery release note: jQuery 3.7.0 Released: Staying in Order

Hello @pubmikeb
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Nikolay

Thanks for the reminder @pubmikeb, we created an internal backlog item.
Though no promises when we will get around to doing the update :)
From experiences in the past we need to be very careful with compatibility and need extensive testing on applications (also our compat layer to 2.x must be investigated).

In the meantime, jQuery 3.6.4 has been released: https://blog.jquery.com/2023/03/08/jquery-3-6-4-released-selector-forgiveness/
Basically, the less forgiving CSS.supports approach is no longer used in 3.6.4. While I personally think the CSS.supports approach in 3.6.3 would actually help applications detect selectors in their code that are actually invalid according to the Selectors specification, maybe upgrading to 3.6.4 should now be considered to avoid accidentally breaking existing apps.

@pubmikeb I see now that you've changed the title as well.. :)

@Thodd now that Internet Explorer is not supported anymore, do we still need the compat layer to 2.x?

This item will be covered in backlog item CPOUI5FRAMEWORK-445.


Orientation change causes right buttons to be duplicated left and content disappears (1.6.7 only)

Launch demo app in portrait
Swipe left to open right buttons
Change to landscape

Duplication also occurs if left buttons are visible before rotating.
Doesn't happen with 1.6.6.
Possibly related to #314.

It should be fixed in 1.6.8


Only header after install

Hello,
I made a new install on ubuntu. It ran successfully until the end.
But then i can see only the header when i connect the app.
Any help or idea ?
Thanks !

The HEAD of the master branch of the cartodb repo is switching to a new dashboard that at moment is broken. I am working in the pinned branch which pins the cartodb repo to the latest release. The pinned branch show the dashboard OK, but #41 issue is keeping me from merging it to the master branch.

I saw your question on https://groups.google.com/forum/#!topic/cartodb
The feature flag new_dashboard is now enabled for all users in 943c32ff59d08aef2680ffc3b5eeb71d69b99edf and the page is being rendered correctly


must-gather: make Dockerfile compatible with docker and buildah

Problem: Docker has a longstanding bug using globs in COPY directives
(i.e. COPY foo/dir/* /tmp/dir/ ).If the source files matched by the glob
include subdirectories, these subdirectories are not present in the destination.
Buildah - which is used to run builds in OCP 4.x - appears to utilise similar
logic when processing globs.
Solution: use of absolute path and use of simple dir structure.
Signed-off-by: crombus<EMAIL_ADDRESS>

/test ocs-operator-ci

/assign @jarrpa please review this.

/cherry-pick release-4.6


fix: handle deleted files

Codecov Report

Merging #63 into main will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   65.82%   66.25%   +0.42%
==========================================
  Files           5        5
  Lines         158      160       +2
  Branches       21       23       +2
==========================================
+ Hits          104      106       +2
  Misses         53       53
  Partials        1        1

Impacted Files
Coverage Δ

src/annotate.ts
93.54% <100.00%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c07e15...84e2e2f. Read the comment docs.


Slack Invite Link Expired

Tried to join the Slack Group to inquire further about this library, but the link is expired. Please update.

https://join.slack.com/t/swiftuichartview/shared_invite/zt-g6mxioq8-j3iUTF1YKX7D23ML3qcc4g

Thank You


make TemporaryJobs more friendly to use outside of JUnit

The after(..) method should not require a parameter which cannot be
constructed by end-users (the TemporaryJobReports.ReportWriter).

Current coverage is 47.99%

Merging #875 into master will decrease coverage by -0.01% as of c9037df

@@            master    #875   diff @@
======================================
  Files          271     271
  Stmts        12725   12735    +10
  Branches      1639    1642     +3
  Methods          0       0
======================================
+ Hit           6108    6112     +4
+ Partial        466     465     -1
- Missed        6151    6158     +7

Review entire Coverage Diff as of c9037df

Powered by Codecov. Updated on successful CI builds.

@spotify/helios-team

LGTM

:+1:


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #20.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #20

needs https://github.com/conda-forge/quantlib-feedstock/pull/17


Steps to run source generator - "Unable to resolve generated expression"

Not sure if I've missed a step somewhere, Getting the error "Unable to resolve generated expression " and when I view the outputted source in ILSpy it doesn't have the expression on the type at all.
I've tried instance method, static method and extension method.  Come to the conclusion that the source generator might not be running.
I do notice i don't have a reference to EntityFrameworkCore.Projectables.Generator nor doesn't there seem to be a nuget package for it.
Am i missing somethign?

Actually if I change the expression bodied member back to a function I get the error "EFP0001	Method or property '' should expose an expression body definition"
Which means the source generator does run, so must be something else that's happening

Ok looks like it was failing to generate due to a default value on the method.

Reopening this as default values should be either supported or the error message should be descriptive


Do not emit 'and 0 more' in ignored signatures message

The warning code can emit 'and 0 more', as in:
build	19-Oct-2018 10:13:22	[WARNING] Some signatures were ignored because the following classes were not found on classpath:
build	19-Oct-2018 10:13:22	[WARNING]   com.google.common.collect.Lists, com.google.common.collect.Maps, com.google.inject.Guice,... (and 0 more).

OK, merged.


The multiple_windows examples crashes after closing a window

This affects both the egui_multiple_windows and multiple_windows examples.  The applications do not crashes directly when closing a window, but after when trying to navigating in the window that was not closed.

Embarrassing 🤣


Add events

On Bentocache, we have these events that are published by the bus: https://bentocache.dev/docs/events#busmessagepublished
bus:message:published and bus:message:received`. These same events are used for monitoring and by the grafana dashboard: https://bentocache.dev/docs/plugin-prometheus#grafana-dashboard
If we want to migrate to rlanz/bus, we also need this

The Bus class would have to accept an emitter as a parameter when instantiated. With an interface like that https://github.com/Julien-R44/bentocache/blob/main/packages/bentocache/src/types/events.ts#L12 so that it's compatible with Node's EventEmitter but also Emiterry
/**
 * Shape of the emitter accepted by BentoCache
 * Should be compatible with node's EventEmitter and Emittery
 */
export interface Emitter {
  on: (event: string, callback: (...values: any[]) => void) => void
  once: (event: string, callback: (...values: any[]) => void) => void
  off: (event: string, callback: (...values: any[]) => void) => void
  emit: (event: string, ...values: any[]) => void
}

the BusManager probably should also accept this emitter

finally not needed


[IOS] The keyboard opens when I begin scrolling within a TextField.

Hello!
I have a LazyColumn containing numerous TextFields as part of a form. It works fine on Android, but on iOS, when I start scrolling within a TextField by tapping and holding my finger without actually clicking, the keyboard opens up.
Version compose multiplatform 1.5.12

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


[2.0.0] your are using the dead upstream sphinx-panels

It cause this kind of trouble
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063326
could you migrate to
https://tracker.debian.org/pkg/sphinx-design
Cheers
Fred

BTW, I don't recall having this issue when building the doc.

PR #4063 replaces sphinx-panels by sphinx-design in the documentation.


Pod update

Hello
After updating to the latest version, I have the following error:
[!] No podspec found for geolocator_web in .symlinks/plugins/geolocator_web/ios

Could you provide a bit more details on what your are doing exactly (are you trying to run the App using flutter run, are you opening in Xcode, ...)? Could you also include the output of the flutter doctor -v command?
This could be an issue if you are on an older Flutter version (pre 1.20).

Maybe you can verify one more thing, do you get the same if you create a new Flutter app and add the geolocator plugin as a dependency?

I've checked twice :) Still I got this issue.

I am also facing this issue.
[!] No podspec found for geolocator_web in .symlinks/plugins/geolocator_web/ios

I am having problems to reproduce the issue, here the steps I am taking:

Create a new Flutter project: flutter create geo_issue_659;
Change into the new project directory: cd geo_issue_659;
Edit the pubspec.yaml file to add a dependency on the geolocator (@leszekkrol note that I use version 6.2.0, in your issue you mentioned 6.1.20 which I assume is just a typo):

dependencies:
  flutter:
    sdk: flutter

  geolocator: ^6.2.0

Run flutter pub get;
Change into the iOS directory: cd ios;
Run the pod update command: pod update;

I am not running into any issues here, the output of the pod update command is as follows:

pod update
Update all pods
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Installing Flutter (1.0.0)
Installing geolocator (6.2.0)
Generating Pods project
Integrating client project
Pod installation complete! There are 2 dependencies from the Podfile and 2 total pods installed.

[!] Automatically assigning platform `iOS` with version `9.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.

[!] CocoaPods did not set the base configuration of your project because your project already has a custom config set. In order for CocoaPods integration to work at all, please either set the base configurations of the target `Runner` to `Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig` or include the `Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig` in your build configuration (`Flutter/Release.xcconfig`).

I have tested on Flutter Stable same:

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.2 20D64 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/maurits/fvm/versions/stable
    • Framework revision 9b2d32b605 (2 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/maurits/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/maurits/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin installed
    • Dart plugin version 203.6912

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Doing a quick google search on the error message resulted in the following SO post, maybe this will help?
TL;DR:

Delete Podfile and Podfile.lock from ios folder;
Run flutter clean in the root folder of your project;
Change back into the ios folder and run pod install;
All should be good and you should be able to run you App.

Let me know if this works.

@matheusrezende Works fine! I am surprised now because I was following a similar list of steps and it did not work yesterday. Thanks!

That is good to hear, thank you for testing and reporting back. This will also be useful for other users experiencing a similar issue.
I will close this issue now, feel free to leave a comment if you run into additional problems.

i am still facing the same issue please guide how to solve this problem ?

pod update
Update all pods
Updating local specs repositories
Analyzing dependencies
[!] No podspec found for geolocator_web in .symlinks/plugins/geolocator_web/ios

Launching lib/main.dart on iPhone 8 in debug mode...
Running pod install...
CocoaPods' output:
↳
Preparing
Analyzing dependencies

Inspecting targets to integrate
  Using `ARCHS` setting to build architectures of target `Pods-Runner`: (``)

Fetching external sources
-> Fetching podspec for `Flutter` from `Flutter`
-> Fetching podspec for `barcode_scan` from `.symlinks/plugins/barcode_scan/ios`
-> Fetching podspec for `camera` from `.symlinks/plugins/camera/ios`
-> Fetching podspec for `connectivity` from `.symlinks/plugins/connectivity/ios`
-> Fetching podspec for `connectivity_for_web` from `.symlinks/plugins/connectivity_for_web/ios`
-> Fetching podspec for `connectivity_macos` from `.symlinks/plugins/connectivity_macos/ios`
-> Fetching podspec for `device_id` from `.symlinks/plugins/device_id/ios`
-> Fetching podspec for `device_info` from `.symlinks/plugins/device_info/ios`
-> Fetching podspec for `firebase_analytics` from `.symlinks/plugins/firebase_analytics/ios`
-> Fetching podspec for `firebase_core` from `.symlinks/plugins/firebase_core/ios`
-> Fetching podspec for `firebase_core_web` from `.symlinks/plugins/firebase_core_web/ios`
-> Fetching podspec for `firebase_messaging` from `.symlinks/plugins/firebase_messaging/ios`
-> Fetching podspec for `flutter_exif_rotation` from `.symlinks/plugins/flutter_exif_rotation/ios`
-> Fetching podspec for `flutter_facebook_login` from `.symlinks/plugins/flutter_facebook_login/ios`
-> Fetching podspec for `flutter_image_compress` from `.symlinks/plugins/flutter_image_compress/ios`
-> Fetching podspec for `flutter_inappwebview` from `.symlinks/plugins/flutter_inappwebview/ios`
-> Fetching podspec for `flutter_local_notifications` from `.symlinks/plugins/flutter_local_notifications/ios`
-> Fetching podspec for `flutter_plugin_android_lifecycle` from `.symlinks/plugins/flutter_plugin_android_lifecycle/ios`
-> Fetching podspec for `flutter_statusbarcolor` from `.symlinks/plugins/flutter_statusbarcolor/ios`
-> Fetching podspec for `flutter_uploader` from `.symlinks/plugins/flutter_uploader/ios`
-> Fetching podspec for `geolocator` from `.symlinks/plugins/geolocator/ios`
-> Fetching podspec for `geolocator_web` from `.symlinks/plugins/geolocator_web/ios`
[!] No podspec found for `geolocator_web` in `.symlinks/plugins/geolocator_web/ios`

/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/external_sources/path_source.rb:14:in `block in fetch'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/external_sources/path_source.rb:11:in `fetch'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:989:in `fetch_external_source'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:968:in `block (2 levels) in fetch_external_sources'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:967:in `each'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:967:in `block in fetch_external_sources'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:966:in `fetch_external_sources'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/analyzer.rb:117:in `analyze'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:414:in `analyze'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:239:in `block in resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:238:in `resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:160:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command/install.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Error running pod install
Error launching application on iPhone 8.

still the same issue here

any update on this issue ?

@adnankhan74444 what have you tried?
Please check the Flutter version you are using (should be 1.20 or higher). Next make sure to follow these steps:

Delete Podfile and Podfile.lock from ios folder;
Run flutter clean in the root folder of your project;
Change back into the ios folder and run pod install;
All should be good and you should be able to run you App.

any update on this issue ?

@adnankhan74444
These steps worked for me:

Delete Podfile and Podfile.lock
Run flutter clean in the root folder of project.
Run flutter pub get
Open Podfile and specify the minimum iOS version (uncomment the line with the iOS version; change if necessary)
Click the run button on your IDE to build and run your App.

I have the same problem that @adnankhan74444
Any update of this?
I'm trying the @mvanbeusekom solution but doesn't works

same issue
version: 6.2.1
flutter: 1.22.6


Telegram send image: fix mimetype detection

Description:
Sometimes the python-telegram-bot module doesn't recognise the mimetype of the file and looks after a name variable to deduce it.
Related issue (if applicable): fixes #7413
Example entry for configuration.yaml (if applicable):

telegram_bot:
  platform: polling
  api_key: !secret telegram_bot_api_key
  allowed_chat_ids:
    - !secret telegram_bot_chat_id_1
    - !secret telegram_bot_group

script:
  test_telegram_bot_send_image:
    alias: Test Telegram Bot send image
    sequence:
      - service: telegram_bot.send_photo
        data:
          caption: 'Test image'
          url: 'https://cloud.githubusercontent.com/assets/6839756/26528267/0df8c88e-43a8-11e7-9e7a-d3820533e437.jpg'

Looks good! Is there some documentation on this behavior for python-telegram-bot?

@MartinHjelmare, it's a small error in an exception clause: https://github.com/python-telegram-bot/python-telegram-bot/pull/641.
The real problem in #7413 it is that the jpg in discussion is not a 'standard' jpg (it looks like a frame of a video stream, but I'm no expert), and the error is preventing to send the jpg as octect-stream, which works.
The fix here I thinks it's a small and costless solution.

made a small change to redo the Travis CI build


GUACAMOLE-996: Add support for configuring group filter.

This provides ldap-group-search-filter functionallity. Tested and working OK!

@echu2013 Any progress on my most recent feedback? Also, you've got a merge master commit in here, now, so you'll need to untangle that and rebase the PR on top of the current master.

I'm by no means an experienced programmer, but I managed to write a 'monkey see, monkey do' style patch against release 1.3.0. Sorry I didn't make it a pull request ( no free time to master git as a developer ATM ).
I've tested it with and without ldap-group-search-filter set, both resulted in expected behavior.
I didn't test it with guacConfigGroup Schema change.
Since there's 'postgresql-auto-create-accounts', the next logical step would be to implement (take postgresql as an example):
postgresql-auto-create-groups
postgresql-auto-create-groups-assignments
Here's a patch generated using 'diff -udpr' : guacamole-client-1.3.0-ldap-group-filter.txt

Since there's 'postgresql-auto-create-accounts', the next logical step would be to implement (take postgresql as an example):
postgresql-auto-create-groups
postgresql-auto-create-groups-assignments

@msilveirabr, what do you mean? The *-auto-create-accounts property exists for the sake of things like the TOTP extension that expect storage to be available for users once the user logs in. Except in those circumstances, even the user account doesn't need to exist in the database. Under what circumstances would a user's groups need to be automatically created?

This is closed by #629

This is closed by #629

Thanks!


Add camel-k-quarkus example

Add a sub folder named quarkus and add an example and show how to run camel-quarkus route with quarkus extensions etc.

@lburgazzoli I have been trying to run Sample.java as a camel-quarkus application. Not sure how its supposed to work (or will be intended to work).
I have tried with both
kamel run -t quarkus.camel-quarkus-version=0.3.1 -t quarkus.quarkus-version=0.27.0 Sample.java

kamel run -t quarkus.camel-quarkus-version=0.4.0 -t quarkus.quarkus-version=1.0.0.CR1 Sample.java

But they start up as regular camel-main apps without quarkus
Also we should IMHO make it easier to say you want to use quarkus, maybe just -t quarkus is sufficient without having to specify exact versions, and then kamel should auto-detect latest camel-quarkus-catalog we have and use the versions from there etc.

/cc @astefanutti

@davsclaus you should be able to run the integration using Quarkus as runtime with:
$ kamel run -t quarkus.enabled=true <integration>

Then the versions are inferred.

Thanks it works
│ 2019-11-23 14:59:33,858 INFO  [org.apa.cam.qua.cor.FastCamelContext] (main) Total 1 routes, of which 1 are started                                                                           │
│ 2019-11-23 14:59:33,861 INFO  [org.apa.cam.qua.cor.FastCamelContext] (main) Apache Camel 3.0.0-RC3 (CamelContext: camel-1) started in 0.285 seconds                                          │
│ 2019-11-23 14:59:33,863 INFO  [org.apa.cam.k.cor.qua.RuntimeListenerAdapter] (main) Listener org.apache.camel.k.listener.RoutesDumper@a77614d executed in phase Started                      │
│ 2019-11-23 14:59:33,864 INFO  [io.quarkus] (main) camel-k-integration 1.0.0-M4 (running on Quarkus 0.27.0) started in 1.830s.                                                                │
│ 2019-11-23 14:59:33,864 INFO  [io.quarkus] (main) Profile prod activated.                                                                                │
│ 2019-11-23 14:59:33,865 INFO  [io.quarkus] (main) Installed features: [camel-core, camel-k-loader-xml, camel-k-runtime-core, camel-k-runtime-quarkus, camel-log, camel-support-common, camel │
│ support-xml, camel-timer, camel-xml, cdi[]                                                                                │
│ 2019-11-23 14:59:34,890 INFO  [info] (Camel (camel-1) thread #1 - timer://hello) Exchange[ExchangePattern: InOnly, BodyType: String, Body: Hello World!!!]                                   │
│ 2019-11-23 14:59:37,862 INFO  [info] (Camel (camel-1) thread #1 - timer://hello) Exchange[ExchangePattern: InOnly, BodyType: String, Body: Hello World!!!]                                   │
│ 2019-11-23 14:59:40,860 INFO  [info] (Camel (camel-1) thread #1 - timer://hello) Exchange[ExchangePattern: InOnly, BodyType: String, Body: Hello World!!!]                                   │
│ 2019-11-23 14:59:43,859 INFO  [info] (Camel (camel-1) thread #1 - timer://hello) Exchange[ExchangePattern: InOnly, BodyType: String, Body: Hello World!!!]

The current docs was not clear on this, but @nicolaferraro just merged a PR so docs will be up to date in the future

Now that Quarkus is the default runtime and will become the only runtime, would it make sense to close this?

yeah sure


[FLINK-33456] Upgrade maven-shade-plugin to 3.5.1 to support jdk20+

What is the purpose of the change
The issue with current shade plugin is that it does not support jdk 20, 21
The support was added at 3.5.1 within https://issues.apache.org/jira/browse/MSHADE-454
The PR bumps to that version
Brief change log
pom.xml
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes )
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: ( no)
The runtime per-record code paths (performance sensitive): ( no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
The S3 file system connector: ( no )

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable)

Hi @snuyanzin, just out of curiosity, is there any requirement to support JDK20+?

@JingGe it is a subtask of FLINK-33163 to support java 21

Thanks for sharing the info!


Bit of refactor on window stuff

Requires docs update

Still not complete, but I'll do the rest in separate PR-s

I was just curious, why do you still use tkinter even if you are so good at Python? I feel like most people use Tkinter in the begining and switch to Qt or something when they need more advanced functionality.
Even I am thinking about swithcing to PyQt6, beacuse there are some things that you just cant do in Tk that are very annoying: Like the transperentcolor clickthrough thing, or that fact you just cant turn the menu bar dark, or there being some non-themeable witgets and the lack of proper threaded control and system integration.
And I dont think that Tukaan can fix these core issues, so why try to fix something that is fundamentallay flawed?

Why do you still use Tkinter?

I don't use it.

I was just curious, why do you still use Tkinter even if you are so good at Python?
Why try to fix something that is fundamentally flawed?

I ask myself these two questions all the time, but I still haven't figured out, why am I still using Tk.
However Qt just doesn't feel right to me. Tk somehow does things better, even if it's a bit outdated.
There are two things in Tk that I think are brilliantly designed. One is the grid layout manager and the other is event handling. They're incredibly easy to use while having a lot of power.
And to be honest, I don't care about the transperentcolor clickthrough thingy, nor the dark menubar nor the non-themeable widgets.


More csproj cleanup

Removes runtimeconfig.template.json
Stops using build/common.props in sample projects
Removes runtime identifiers for .NET Framework projects (almost...still required in one test project)
Remove redundant settings from Microsoft.NET.Sdk.Web projects.
Sets common version settings in build/dependencies.props

@natemcmaster,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

:bell:

I am fine with this change if this comment  is resolved

The answer is public VS previews no longer require "runtimeconfig.template.json".


Move Jackson Modules to org.embulk.config

As a preparation to move all Jackson Modules to embulk-deps, moving all Jackson Modules to package org.embulk.config to be referred from org.embulk.config.ModelManager without public.

Thanks!


sqrt

1. SDK version（SDK 版本）
{
}

2. In what kind of operation problems appear, and how to reproduce the problem ?（什么样的操作步骤问题会出现，是否是稳定复现，如何复现问题？）
{
}

？？

I have the same problem...
if i use sqrt function with a number (int or float) es:
float tmp = sqrt(2.3);
the compiler do the job without problem... but if i pass a variable
float numb = 2.3;
float tmp = sqrt(numb);
the compiler bring up an error : "undefined exception to 'sqrt'"
I have download and installed the lastest GPRS_C_SDK and CSDTK
thank you very mutch
Alex

I have the same problem...
if i use sqrt function with a number (int or float) es:
float tmp = sqrt(2.3);
the compiler do the job without problem... but if i pass a variable
float numb = 2.3;
float tmp = sqrt(numb);
the compiler bring up an error : "undefined reference to 'sqrt'" and "relocation truncated to fit: R_MIPS16_26 against 'sqrt'"
I have download and installed the lastest GPRS_C_SDK and CSDTK
thank you very mutch
Alex

resolved with a total reinstallation of sdk chaintools...
thanks
Alex


Make program and test suite compatible with Python 3 instead of 2.

There are many differences between string handling, hashing, wxPython, etc. in Python 2 and 3, so this breaks compatibility with Python 2. The test suites all succeed, and the program's features appear to work as intended.

+1

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

Sure; that's the idea behind open source. :) GitHub must have a built-in way to accomplish it. Since these are two forks of the same original repository, it should just be a merge, described here. I mostly stick to the basics with GitHub, though, so don't take my word for it.

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I realized I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

It looks like you started your repository today and have only made a few changes to the readme - I'd say it'd be easier and cleaner all around if you make a note of those changes, delete the repo, and just start fresh with a fork of my repo. How does that sound?


feature: add option to not output repos which had 0 minutes used

Description
Hi! This is a great action I'd like to use in my organization. But we have about 1000 repos, and only 200 are using GHA. So the log is huuuuge and it's hard to navigate inside of it.
So I have added additional input to optionally print only repos with more than 0 minutes usage
Type of change
feature
How Has This Been Tested?
I tested it locally & using built-in test aciton(great idea to have one) on my organization
Checklist:

[x] I have performed a self-review of my own code
[x] I have made changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have labelled my PR

@mononokehime  hi! please take a look

Unsure why the GHAs are failing, so merging and will try later

great, thank you!
can you please release a new version?


Update Readme with dev relevant changes

I already made the edits regarding the description to the readme. Please change the part about deployment and apps to reflect the approach we are taking with the current overhaul.

done


Using getChatStatisticsUrl

I am trying to use getChatStatisticsUrl
The documentation on this link seems to indicate that I need to pass some "parameters", and only description that I get everywhere for this field is this:
Parameters from "tg://statsrefresh?params=******" link.
But how does one access this tg:// url to understand the list of parameters? And what is the format to send this parameters? Should we send them in JSON?
I tried empty string for parameter, but I am getting error PEER_ID_INVALID .
I also looked at the TDLib code, and following links, but couldn't figure it out.
https://core.telegram.org/method/messages.getStatsURL
https://core.telegram.org/type/StatsURL
It would be great if you could guide me here.
While we are at it, could you also suggest how do I identify whether the channel that I am looking at belongs to me or someone else? i.e. the author/admin of it is me or someone else.
Thanks,
Mukesh

There is also a field supergroupFullInfo.can_view_statistics, which indicates whether getChatStatisticsUrl can be called for the channel. Currently this field is false for all channels, because the feature is disabled server-side.
To find your privileges in a supergroup or a channel, you can check the field supergroup.status.

Oh, the feature is disabled itself. Thanks for letting me know. I spent my whole of yesterday trying to make it work.
I don't see the fields supergroupFullInfo.can_view_statistics and supergroup.status in my 'chat' object. Do I have to query Group for that?

supergroup and supergroupFullInfo are separate objects. chat has type field, which will be of type chatTypeSupergroup for supergroups and channels.

Thanks for your help and guidance Aliaksei, as always!


Universal sentence encoder lite 2 empty string

First of all, I apologize if I'm posting this into an inappropriate place but I see other issues about Universal sentence encoder in this project.
Secondly I know that embedding empty strings is not a standard use case of USE but I'm posting this since the behavior is not consistent.
Description
I'm trying to embed texts in batches. Some of the texts can be empty. There are three cases that can occur:

Empty string is not at the last position of the batch: we get embeddings for all the input strings including the empty string.
Empty string at the last position of the batch: the output tensor doesn't include the embedding for this string, i.e. the output tensor shape is smaller than input tensor shape.
Only empty string in the batch: ValueError raised.

Runnable example
Initialization:
import os
import sentencepiece as spm
import tensorflow as tf
import tensorflow_hub as hub

def process_to_IDs_in_sparse_format(sp, sentences):
    # An utility method that processes sentences with the sentence piece processor
    # 'sp' and returns the results in tf.SparseTensor-similar format:
    # (values, indices, dense_shape)
    ids = [sp.EncodeAsIds(x) for x in sentences]
    max_len = max(len(x) for x in ids)
    dense_shape = (len(ids), max_len)
    values = [item for sublist in ids for item in sublist]
    indices = [[row, col] for row in range(len(ids)) for col in range(len(ids[row]))]
    return (values, indices, dense_shape)

os.environ['TFHUB_CACHE_DIR'] = './models'
module = hub.Module("https://tfhub.dev/google/universal-sentence-encoder-lite/2")
sp = spm.SentencePieceProcessor()
sp.Load("models/539544f0a997d91c327c23285ea00c37588d92cc/assets/universal_encoder_8k_spm.model")

Empty string not last:
sentences = [
    "",
    "The quick brown fox jumps over the lazy dog."
]
values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, sentences)

with tf.Session() as session:
    session.run(tf.group([tf.global_variables_initializer(), tf.tables_initializer()]))
    message_embeddings = session.run(
        embeddings,
        feed_dict={input_placeholder.values: values,
                   input_placeholder.indices: indices,
                   input_placeholder.dense_shape: dense_shape})

print(sentences)
print(message_embeddings.shape)
# (2, 512)
print(message_embeddings)
# [[ 0.00235466 -0.03487525  0.01310202 ... -0.05458128 -0.0276587
#    0.03307254]
#  [-0.01353392 -0.04256385  0.03684283 ... -0.02522222  0.02741303
#    0.01377513]]

Empty string last:
sentences = [
    "The quick brown fox jumps over the lazy dog.",
    ""
]

input_placeholder = tf.sparse_placeholder(tf.int64, shape=[None, None])
embeddings = module(
    inputs=dict(
        values=input_placeholder.values,
        indices=input_placeholder.indices,
        dense_shape=input_placeholder.dense_shape))

values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, sentences)

with tf.Session() as session:
    session.run(tf.group([tf.global_variables_initializer(), tf.tables_initializer()]))
    message_embeddings = session.run(
        embeddings,
        feed_dict={input_placeholder.values: values,
                   input_placeholder.indices: indices,
                   input_placeholder.dense_shape: dense_shape})

print(sentences)
print(message_embeddings.shape)
# (1, 512)
print(message_embeddings)
# [[-0.01353392 -0.04256385  0.03684283 ... -0.02522222  0.02741303  0.01377513]]

Only empty string:
sentences = [""]
values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, sentences)

with tf.Session() as session:
    session.run(tf.group([tf.global_variables_initializer(), tf.tables_initializer()]))
    message_embeddings = session.run(
        embeddings,
        feed_dict={input_placeholder.values: values,
                   input_placeholder.indices: indices,
                   input_placeholder.dense_shape: dense_shape})

# ValueError: Cannot feed value of shape (0,) for Tensor 'Placeholder_2:0', which has shape '(?, 2)'

Hi this seems to be a problem with the SentencePiece library actually. By looking at the source code of the sentence piece library it seems like empty lines are removed before they are passed into the SentencePiece model. Here is a link to the trainer_interface code line 325.
The Lite version of the Universal sentence encoder requires the ID generated by the SentencePiece generator as one of the arguments and looking at the different IDs generated by the generator it seems like the generator does not return any ID for whitespaces or empty strings.
print(sp.EncodeAsIds("Hello"))
 # [341, 4125]
print(sp.EncodeAsIds("H"))
 # [341]
print(sp.EncodeAsIds("."))
 # [30, 6]
print(sp.EncodeAsIds(""))
 # []

Now trying to recreate your findings these are what I found out.
When an empty string is passed
messages = [""]

values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, messages)
print(values)
# []
print(indices)
# []
print(dense_shape)
# (1, 0)

feed_dict = {input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape}

with tf.Session() as session:
  session.run([tf.global_variables_initializer(), tf.tables_initializer()])
  message_embeddings = session.run(
      encodings,
      feed_dict={input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape})

print(message_embeddings.shape)
# ValueError: Cannot feed value of shape (0,) for Tensor 'Placeholder_5:0', which has shape '(?, 2)'

The model expects to receive an index value of size (?,2) like [0, 1] but instead it was given [] hence the ValueError
When an empty string is passed in the start
messages = ["",
            "hello"]

values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, messages)
print(values)
# [341, 4125]
print(indices)
# [[1, 0], [1, 1]]
print(dense_shape)
# (2, 2)

feed_dict = {input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape}

with tf.Session() as session:
  session.run([tf.global_variables_initializer(), tf.tables_initializer()])
  message_embeddings = session.run(
      encodings,
      feed_dict={input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape})

print(message_embeddings.shape)
# (2, 512)

Here notice the output of values and indices, The output of indices is [[1, 0], [1, 1]] which means that the 2 values [341, 4125] belong to string present in messages at index 1. ie "Hello" not "". But there are 2 embeddings created one for "" and one for "Hello".
When an empty string is passed in the middle
messages = ["Hello",
            "",
            "Hello"]

values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, messages)
print(values)
# [341, 4125, 341, 4125]
print(indices)
# [[0, 0], [0, 1], [2, 0], [2, 1]]
print(dense_shape)
# (3, 2)

feed_dict = {input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape}

with tf.Session() as session:
  session.run([tf.global_variables_initializer(), tf.tables_initializer()])
  message_embeddings = session.run(
      encodings,
      feed_dict={input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape})

print(message_embeddings.shape)
# (3, 512)

Same here, the values belong to the strings from the messages list at the 0th and 2nd index.
There are three embeddings created and comparing the embedding for created for "" with the previous example embedding for "", they seem to be similar because they have very close cosine similarity. Therefore it seems clear that the model can create embeddings for empty strings.
When an empty string is passed in the end.
messages = ["Hello",
            ""]

values, indices, dense_shape = process_to_IDs_in_sparse_format(sp, messages)
print(values)
# [341, 4125]
print(indices)
# [[0, 0], [0, 1]]
print(dense_shape)
# (2, 2)

feed_dict = {input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape}

with tf.Session() as session:
  session.run([tf.global_variables_initializer(), tf.tables_initializer()])
  message_embeddings = session.run(
      encodings,
      feed_dict={input_placeholder.values: values,
                input_placeholder.indices: indices,
                input_placeholder.dense_shape: dense_shape})

print(message_embeddings.shape)
# (1, 512)

Over here only 1 embedding is created for the string "Hello"
This is not an official explanation but my thinking is that the empty strings in the start are converted to embeddings to maintain the same number of output as the Input but the empty string in the last gets removed because according to some conventions empty line at the end denotes the end of file.
The best thing for you to do however is to just remove empty strings before embedding them.

You can however embed empty strings in the non-lite version of the universal sentence encoder.
If you feel like this issue has been solved, please close the issue :)

@swecooo As mentioned in the above comment, please remove the empty strings before embedding and use it. Please respond if you think otherwise. Thanks!

Thank you for your time and explanation. :)

the (sentencepiece) generator does not return any ID for whitespaces or empty strings.

I completely understand that this is an edge case. I agree with removing empty strings and string containing only whitespaces from the data.
I just thought that the behavior should be consistent to avoid different results for different ordering of the strings but this gets resolved when we remote those invalid strings.


uv picks the wrong version of a package and fails (pip does not)

uv:
https://github.com/rsxdalv/tts-generation-webui/actions/runs/11224348164/job/31200883591
pip:
https://github.com/rsxdalv/tts-generation-webui/actions/runs/11224124790/job/31200229110
context:
Docker image: nvidia/cuda:11.8.0-devel-ubuntu22.04 (Python 3.10.12, uv 0.4.18)
uv pip install --no-cache-dir --system setuptools torch==$TORCH_VERSION torchvision torchaudio
pip3 install --no-cache-dir --upgrade pip==23.3.2 setuptools
breaking point:
uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements.txt
Requirements file:
safetensors
# safetensors==0.3.1 # Until they fix it
ffmpeg-python # Apache 2.0
# gradio==3.48.0
gradio>=4.1.0 # MIT License
python-dotenv==1.0.0
soundfile==0.12.1; sys_platform == 'win32' # torchaudio
# sox # torchaudio for linux
suno-bark @ git+https://github.com/rsxdalv/bark@main#egg=suno-bark # MIT License
vocos==0.1.0 # MIT License
tortoise-tts @ git+https://github.com/rsxdalv/tortoise-tts@main#egg=tortoise-tts # Apache 2.0
beartype>=0.16.1 # workaround for a bug
# no longer required directly # transformers==4.36.1 # cross-compatibility
iso639-lang==2.2.3
pillow==10.3.0 # for gradio, conda fix

Error:
 > [17/27] RUN uv pip install --no-cache-dir --system --verbose torch==2.3.1 -r requirements.txt:
6.923   File "/tmp/.tmpejZquv/builds-v0/.tmpqUIi6D/lib/python3.10/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
6.923     self.run_setup()
6.923   File "/tmp/.tmpejZquv/builds-v0/.tmpqUIi6D/lib/python3.10/site-packages/setuptools/build_meta.py", line 503, in run_setup
6.923     super().run_setup(setup_script=setup_script)
6.923   File "/tmp/.tmpejZquv/builds-v0/.tmpqUIi6D/lib/python3.10/site-packages/setuptools/build_meta.py", line 318, in run_setup
6.923     exec(code, locals())
6.923   File "<string>", line 55, in <module>
6.923   File "<string>", line 52, in _guard_py_ver
6.923 RuntimeError: Cannot install on Python version 3.10.12; only versions >=3.6,<3.10 are supported.

https://github.com/rsxdalv/tts-generation-webui/actions/runs/11224348164/job/31200883591#step:6:8382
Full dockerfile:
# Python 3.10 w/ Nvidia Cuda
FROM nvidia/cuda:11.8.0-devel-ubuntu22.04 AS env_base

# Install Pre-reqs
RUN apt-get update && apt-get install --no-install-recommends -y \
    git vim nano build-essential python3-dev python3-venv python3-pip gcc g++ ffmpeg

ENV NODE_VERSION=22.9.0
RUN apt-get update && apt install -y curl
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
ENV NVM_DIR=/root/.nvm
RUN . "$NVM_DIR/nvm.sh" && nvm install ${NODE_VERSION}
RUN . "$NVM_DIR/nvm.sh" && nvm use v${NODE_VERSION}
RUN . "$NVM_DIR/nvm.sh" && nvm alias default v${NODE_VERSION}
ENV PATH="/root/.nvm/versions/node/v${NODE_VERSION}/bin/:${PATH}"
RUN node --version
RUN npm --version

# Install uv
ADD --chmod=755 https://astral.sh/uv/install.sh /install.sh
RUN /install.sh && rm /install.sh

# Define PyTorch version
ENV TORCH_VERSION=2.3.1

ENV PATH="/root/.cargo/bin:$PATH"
RUN uv pip install --no-cache-dir --system setuptools torch==$TORCH_VERSION torchvision torchaudio

# Set working directory
WORKDIR /app

# Clone the repo
RUN git clone https://github.com/rsxdalv/tts-generation-webui.git

# Set working directory to the cloned repo
WORKDIR /app/tts-generation-webui

RUN pip3 install --no-cache-dir --upgrade pip==23.3.2 setuptools

# Install all requirements
# RUN pip3 install --no-cache-dir torch==$TORCH_VERSION -r requirements.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_bark_hubert_quantizer.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_rvc.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_audiocraft_0.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_audiocraft.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_styletts2.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_vall_e.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_maha_tts.txt
RUN uv pip install --no-cache-dir --system --verbose torch==$TORCH_VERSION -r requirements_stable_audio.txt
# RUN uv pip install --no-cache-dir --system torch==$TORCH_VERSION hydra-core==1.3.2
RUN uv pip install --no-cache-dir --system torch==$TORCH_VERSION nvidia-ml-py

# add postgres & run setup
# Build the React UI
RUN cd react-ui && npm install && npm run build

# Run the server
CMD python server.py --docker

Hi! Thanks for all the details. Did you read the local version identifier section of the pip compatibility guide?

Thank you, I saw some potential causes for this, it seems like it spiraled downwards towards an older version, and I suppose I can try to add an extra constraint on the version and fix everything that way.
On the topic of pip compatibility, it seems that pip is capable of installing packages while there's an app running while uv seems to fail, is this to be expected?
error: failed to remove file .\env\Lib\site-packages\PIL/_imaging.cp310-win_amd64.pyd
Caused by: Access is denied. (os error 5)
For context, I have a python app with extensions system and they currently are being installed while the app itself is running.

There's an issue for the pyd file behavior on Windows https://github.com/astral-sh/uv/issues/7918 — installation should be fine but that suggests that there's an uninstall happening?
Here's another issue with context on selection of old versions when there aren't constraints https://github.com/astral-sh/uv/issues/4372

There's an issue for the pyd file behavior on Windows #7918 — installation should be fine but that suggests that there's an uninstall happening?
Here's another issue with context on selection of old versions when there aren't constraints #4372

Thanks!
Yes, exactly, it seems that the problems begin when an extension causes a reinstall, i.e., PIL > 9 is ok with the app but the extension demands PIL > 10 so we get a reinstall.

Hi! Thanks for all the details. Did you read the local version identifier section of the pip compatibility guide?

I wanted to add a user story in regards to this:
uv pip install --dry-run torch==2.3.0 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
  × No solution found when resolving dependencies:
  ╰─▶ Because there is no version of torch==2.3.0 and you require torch==2.3.0, we can conclude that your requirements
      are unsatisfiable.

as an end user, I don't know exactly what is the + they are using. I think this time I will just try to guess it, but since the + is so ingrained in python right now, there might need to be a way to help find those packages/resolve those conflicts. (After assuming that there's no pytorch 2.5.0 with Cuda 11.8, I thankfully came here to find that it's torch==2.5.0+cu118)
Also great job on uv dry run installs, when trying it with pip I had this:
(C:\Users\admin\Desktop\one-click-installers-tts-main\tts-generation-webui\installer_files\env) C:\Users\admin\Desktop\one-click-installers-tts-main\tts-generation-webui>pip install --dry-run torch==2.3.0 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
Looking in indexes: https://download.pytorch.org/whl/cu118
Collecting torch==2.3.0
  Downloading https://download.pytorch.org/whl/cu118/torch-2.3.0%2Bcu118-cp310-cp310-win_amd64.whl (2673.0 MB)
     ━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.1/2.7 GB 40.9 MB/s eta 0:01:02
ERROR: Operation cancelled by user

(C:\Users\admin\Desktop\one-click-installers-tts-main\tts-generation-webui\installer_files\env) C:\Users\admin\Desktop\one-click-installers-tts-main\tts-generation-webui>pip install --dry-run torch==2.5.0 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
Looking in indexes: https://download.pytorch.org/whl/cu118
Collecting torch==2.5.0
  Downloading https://download.pytorch.org/whl/cu118/torch-2.5.0%2Bcu118-cp310-cp310-win_amd64.whl (2700.2 MB)
     ━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.1/2.7 GB 40.9 MB/s eta 0:01:04
ERROR: Operation cancelled by user

Thus I can testify that uv is already a tool every python dev should have installed, because it's useful even when mixing with pip.


apollo-server -> graphql-server upgrade, node-uuid -> uuid, supertest…

…=2 -> supertest-3

Thanks a lot for the contribution! It's available as<EMAIL_ADDRESS>or remotedev-server@next.


AWS: Tests cannot get executed

I tried the AWS Hello World again and noticed that the Score functionality is currently broken.
Instead of executing the tests, it simply returns:
StdErr: sh: make: command not found

Also, in CodeOcean, we should switch to JUnit 4 (from JUnit 5) for the AWS environment (as this is the version the tests are written in).

This is because our Makefile implementation does not recognise make test CLASS_NAME="%{class_name}" FILENAME="%{filename}" as valid make command matching the pattern ^make(?:\s+(?<startRule>\w*))?$.
Should we implement the make feature of make variables? We should also keep in mind that there are other possibilities, such as putting a static make binary (+ dependencies if necessary) into the aws deployment.

Hm, that's another edge case for Make, true. I would hope, it is the last one...
Regarding the tests: Do you know whether they will work once we fixed that make problem? I am asking as we are also including JUnit 4 with two jars which might or might not be available in AWS. Probably using JUnit 5 is no problem, but any JUnit is required.

Regarding the tests: We can include all dependencies via our maven pom.xml file.
For example, if we remove the test-scope of our junit dependency...
https://github.com/openHPI/poseidon/blob/bb2d989bc51680a29e8c7ebb1ea014ae647b32ac/deploy/aws/java11Exec/pom.xml#L35-L40
... we can access junit.junit-4.13.1.jar in the folder /var/task/lib.
How do we deal with the problem that the path to the library is set statically in the Makefile, but differs between Nomad and AWS?

Okay, that's fine. We use that dependency and Hamcrest (in addition):
<!-- https://mvnrepository.com/artifact/org.hamcrest/hamcrest-core -->
<dependency>
    <groupId>org.hamcrest</groupId>
    <artifactId>hamcrest-core</artifactId>
    <version>1.3</version>
</dependency>

My proposal (for a quick solution, but not tested yet):
.map(s->s.replaceAll("/usr/java/lib/hamcrest-core-1.3.jar", "/<new path>.jar"))
.map(s->s.replaceAll("/usr/java/lib/junit-4.11.jar", "/<new path>.jar"))

This might work somewhere in the stream of the SimpleMakefile, I hope 🤞
Do you think this could work?

Do you think this could work?

Yes, it's a very quick fix :+1:
Unfortunately, the "Score" result only turned from red to orange..

That's easy to fix -- I already did so. Remember my initial comment?

Also, in CodeOcean, we should switch to JUnit 4 (from JUnit 5) for the AWS environment (as this is the version the tests are written in).

In CodeOcean, we use some output parsing (with RegEx) to identify the score. When this is set to the wrong version, our RegEx doesn't match 😁


A kernel mode driver written in C#?

Is this a kernel mode filter driver? if so why is most of the source written in C#? Just trying to get some insights.

The kernel mode driver isn't in the repo and (I'm guessing) is in C/C++

GvFlt is a kernel mode filter driver that sends some of its requests up to user mode. GVFS is the user mode application that responds to those requests. To greatly oversimplify it, GVFS knows how to enumerate a directory or retrieve file contents, and GvFlt knows how to merge those results into NTFS.


Avoid duplicates in select menus (with yadcf)

... this small piece of code works quite well for my needs, but I can't figure it out whitin different situation

This seems like a good change, but there is no test coverage for this. @pankus , do you feel comfortable adding a test that reproduces the desired behaviour? I don't have time right now to look into this, but will do eventually

I can try, even if I don't know where to start !!


[FLINK-6217] ContaineredTaskManagerParameters sets off-heap memory size incorrectly

The failed tests are being addressed in FLINK-6175.

The test failure seems unrelated. Cannot reproduce locally.

Good fix, thanks @haohui
I was wondering - I am a trying to advocate fewer dependencies in Flink (there is always the problem of shading and conflicts) so if there is a way to do this without Guava, that'd be great. I think commons-lang3 has a joiner as well, or we might just add a joiner to Flink...

Totally Agree :-) @StephanEwen please take another look.

+1 to merge this

Thanks for your contribution @haohui and the review @StephanEwen. Changes look good to me. Merging this PR.


Adds a /status endpoint for health checks

Resolves: https://github.com/dimagi/open-chat-studio/issues/548

All checks: /status
Site checks: /status/general/
Celery checks: /status/celery/

Append ?format=json to get JSON response instead of HTML

Are we going to go with betterstack as well?


accelerator for project

Hi @chenhunghan, very cool project. was looking for something like this when i saw that Falcon was out. Any recs on appropriate accelerators for using the 7B and 40B models? I'm going to try your project out, and I'm wondering if you've already experimented with appropriate node pool specifications for running the deployment.
happy to add some tf-templates in the repo for some different providers if you want to collaborate

Hi @chenhunghan, very cool project. was looking for something like this when i saw that Falcon was out. Any recs on appropriate accelerators for using the 7B and 40B models? I'm going to try your project out, and I'm wondering if you've already experimented with appropriate node pool specifications for running the deployment.
happy to add some tf-templates in the repo for some different providers if you want to collaborate

Sure!  I am afraid there is no acceleration for falcon at the moment (just because ggml does support it... not yet afaik). Sorry for the late response, was on vacation :).

Hello @dyllamt , the support for CUDA11/12 and METAL GPU acceleration has landed, check out the latest releases!


Set on_exit_shutdown argument for gz-sim ExecuteProcess

Signed-off-by: Michael Anderson<EMAIL_ADDRESS>🎉 New feature
Summary
Add launch argument to set gz-sim to be a required node: if argument on_exit_shutdown is True, set on_exit=Shutdown()
Test it
Make a launch file that includes gz_sim.launch.py as well as some other node. set gz_args to use --iterations 5000 and set on_exit_shutdown to True. When gz-sim exits, everything should quit.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll It doesn't look like this PR made it into the humble branch

I will backport to iron and humble, thanks.

Humble: https://github.com/gazebosim/ros_gz/pull/451
Iron: https://github.com/gazebosim/ros_gz/pull/452


Error when connected to Mumbai with Metamask wallet

When I connect to mumbai network with Metamask wallet I repeatedly receive the error below. it does not happen with the main Polygon network or Ethereum networks.
Failed to check transaction hash: undefined Error: invalid hash (argument="value", value=undefined, code=INVALID_ARGUMENT, version=providers/5.5.0)
    at Logger.makeError (index.ts:225:1)
    at Logger.throwError (index.ts:237:1)
    at Logger.throwArgumentError (index.ts:241:1)
    at Formatter.hex (formatter.ts:221:1)
    at Formatter.hash (formatter.ts:267:1)
    at Web3Provider.<anonymous> (base-provider.ts:1570:1)
    at Generator.next (<anonymous>)
    at fulfilled (base-provider.ts:1:1)

try to change your RPC provider. We use useDapp and mumbai with alchemy rpc - works as charm.

As for now Mumbai network is supported :)


Tests: PROTEUS simulation with dummy submodules

There are currently no tests which run the PROTEUS code - specifically, the main loop.
With dummy interior and atmosphere models implemented, this should now be significantly easier to do. We can run the PROTEUS loop without compiling SOCRATES, PETSc, or SPIDER.
Depends on:

#184
#73

Test suggestions:

Escape time
Solidification time
Rad eqm time
Atmospheric composition

Use input/dummy.toml for the tests

Check for:

Surface temperature
Melt fraction
Atmosphere has escaped
Atmosphere composition at start
Time
Heat flux at specific time steps

I think we can actually check the whole output csv table, might be easier to see where things diverge in time.


All twitters tab refresh on add-on install

That was quite unexpected. I've got tons of tabs and a lot of them are twitter ones, most are not even loaded at the moment (bad practice, i know, but that's what i got used to). Needless to say that was quite heavy on my Firefox.
I understand this is by design, but maybe you can give a prompt before refreshing each and every one of those tabs and maybe even allow user to opt-out of this massive refresh (but warn about cached data)?

They also seem to refresh on add-on update, which can happen at any moment. Heck, i've been reading my twitter list when the tab suddenly refreshed. Please add a warning at least.

The add-on needs to refresh to activate the changes as sometimes twitter messes with it if it isn't reloaded. I don't know how to only make it refresh on a fresh install. Closed unless someone knows of a solution for this

What about the prompt/warning though?

I can't create a pop-up without injecting it into a webpage.

Um, just to double-check - is it not possible to avoid refreshing unloaded tabs? It also looks like GoodTwitter affects Firefox startup time greatly, so i'm planning on uninstalling it, to my dismay (I only need GT for "See x new tweets" button/counter in lists, and it's still not brought back).

I haven't figured out a way to see if a tab is loaded. It should also only reload tabs on install and updates (I haven't pushed an update in 2 months). As for the startup, I've never experienced anything like that. What version of Firefox/GoodTwitter are you on?

It shouldn't cause anything to slow down the browser on startup. The only reason why that might be is if you have a bunch of Twitter tabs open and your browser reopens them on startup. They way GoodTwitter works is it replaces the User Agent with an old browser so it needs to inspect requests and replace the user agent but that only happens on Twitter tabs

As for reloading tabs - i think it also happened when browser got updated (i have to admit though, i wasn't actually using Firefox, but it's fork Waterfox). I've updated it yesterday (to the latest version - 2019.10) and all my twitter tabs loaded on startup (they don't usually load by themselves). I've tried restarting again and though it was slow, so i tried disabling add-on and for few times it seemed to work, but not anymore, so, yeah, slow startup is most likely not related to GT after all.
Still, what about an option to not refresh tabs automatically, off by default and with a huge warning about requiring force refresh via Ctrl+F5?


proposal: doc: create *NIX manual pages for Go standard library functions

Recently, I started to play around with Go, and one thing that I've really missed were manual pages for standard library functions (such as, for example fmt.Printf()), like there are in another languages (a.k.a /usr/share/man/man3).
This is an example of what I mean:

Sometimes I run into a syntax error and/or misusing the function and I have to access the official documentation on the web just to read about the function itself, what is a setback to me, while I could just type man 3 <function name here> and see what it does and how to use it, like it would be in C or even in Perl (if I recall correctly, Red Hat Linux had manpages packaged for Perl library functions).
If you guys decide to start making manual pages for Go standard library, I offer to help in writing them. It would be a nice opportunity to practice my "documentation writing" skills and to learn the language in a deeper level.
I don't know if something like what I'm proposing already exists by community's hands, so please don't beat me up for asking this, just say if it exists or not.
May this is a duplicate from https://github.com/golang/go/issues/101, but it still pertinent to be talked about since it hasn't been fixed/implemented yet.
Thanks for the attention.

Note that documentation for a specific function is still available on the command line via
$ go doc <package>.<function>

For example
$ go doc strings.Split
package strings // import "strings"

func Split(s, sep string) []string
    Split slices s into all substrings separated by sep and returns a slice of
    the substrings between those separators.

    If s does not contain sep and sep is not empty, Split returns a slice of
    length 1 whose only element is s.

    If sep is empty, Split splits after each UTF-8 sequence. If both s and sep
    are empty, Split returns an empty slice.

    It is equivalent to SplitN with a count of -1.

Note that documentation for a specific function is still available on the command line via

$ go doc .

Thank you man.
I guess I'll just close this issue for now, since it's almost solved in the sense of accessing documentation via command line.

By the way, it could still be more detailed, like manpages, with some syntax example (and, in case of fmt.Printf(), with the table of verbs).

So, although it's solved for my used, I'm reopening so more people will see it.

FYI https://github.com/golang/go/issues/101
IMO this proposal will be declined.

I think this can just be closed as a dup.
There's nothing here that would change the decision made for #101


feat: [Validation] add required_if validation rules

Description
Supersedes #9018
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Whoops, wrong source branch. closing this PRs.


Authorization of the translation

Hello, I want to translate your article into Chinese. Can I get your authorization?

Absolutely! Go right ahead.  It would be great if you could simply add another README file which is a translated version.

Thank you, you can add me to the collaborators? Or do I create a new project?


How often can the frequency be updated per second?

I have been experimenting with using the sound generator to tonally represent G-forces using the userAccelerometer from the motion_sensors package. Through these experiments, I have noticed that the sound generator does not update the frequency of the wave more than about 5 times a second (5hz).
Is it possible to increase this update rate?
Ideally, I would like an update rate of about 30hz.
I apologize if this is the wrong place for this question. If so, please point me to the right place.

Take a look at the AudioTrack.Builder. I changed the SoundGenerator a little bit and now have an instantly changing sound generator: https://github.com/si-gr/sound_generator/commit/beab4ec9b972ba18da14cde82d952a6a864db2f5


Upgrade to 0.19

Tests definitely passed locally :(

@BrianHicks I believe I addressed all your comments!

yeah, I think you did! Do you think it'd be fine to just publish the new version on 0.19 since there are no substantial changes? I'm not sure how it will need to be tagged. Since you've done a couple of them, and guidance?

(I'll merge when we have a solid plan there.)

Just merge, run elm bump, commit the change, then tag on github the same way as before, and publish with elm publish.

Great, thank you! I'll merge and do that soon :)

On Aug 29, 2018, at 1:44 PM, Andrey Kuzmin<EMAIL_ADDRESS>wrote:
Just merge, run elm bump, commit the change, then tag on github the same way as before, and publish with elm publish.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/BrianHicks/elm-trend/pull/1#issuecomment-417062434, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsSQ6rwBOrfjrGK_uSLr63TN6PR0Jbks5uVuEOgaJpZM4WR8VY.


"Skipped" status in progress output is confusing

When the file is "skipped" because of the cache, the correct output should be . for "no changes", not S for "Skipped".

Rationale: The user only cares about whether the file is okay, or not. Imagine if phpunit or behat has a cache, and decides to output "Skipped" for cached tests. That would confuse the heck out of everyone.

Hi and thanks for the suggestion,
It's always helpful to hear what the end users find confusing and what can be tweaked, especially if you work on a project for a while as you might get blind for the details!
If PHPUnit had a cache and cached the test results I would prefer knowing it through some feedback. As such I think have different indicators for different states isn't that bad, but I agree that we don't explain the why something is skipped.
I made a proposal to clarify the state, let me know what you think :)

As a matter of fact, PHPUnit does have a cache now, and it didn't change the progress output, as far as I could tell.

@teohhanhui PHPUnit uses the cache only to change the order of tests - it caches the results to be able to run the failed test first in the next run. No tests is skipped because it is cached.
Thinking from a perspective of PHPUnit user who discovers PHP CS Fixer when seeing S in progress then might think the file was skipped because it was marked to be skipped (like we can do in PHPUnit) and not because the file was already checked and have no changed since.


Fix "nod danbooru.js" command

%path:nobackslash% makes sure the path is passed correctly for users who use subfolders.

LGTM 👍


Switch to CalVer

With regular updates, dependancies on Bootstrap versions and issues whether or not something is a breaking change, CalVer is a better fit for versioning. For example, YY.0M.MICRO.

Fixed in #196.


On MacOS UI is not updated when window goes Fullscreen

Hi!
I've launched the game in Window mode and it looks like that.

Then I changed to fullscreen and got that

Godot 3.5-rc2
MacOs 12.3.1

Whoops, you're right, and this is not limited to MacOS.
This is likely me not using anchors correctly (or at all). Thanks for bringing this to my attention. The design resolution is pretty much my screen resolution so I never noticed :P

Should be fixed with https://github.com/Zireael07/Space-Frontier/commit/62d64d992b400d941e77251b2fd07a84807f8e0d
(Fixing the static UI elements wasn't that difficult. The biggest problem was with dynamically placed ones, i.e. planet labels and AI order overlays)


[AutoPR compute/resource-manager] Dummy entries to check MoT

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2920

(message created by the CI based on PR content)


Switch macOS images to 10.14

Pipelines will remove macOS-10.13 builder, let's switch to 10.15.

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

Hm, I just want to remove 10.13 so let's stay on 10.14.

It seems fine, merging.


Reload application when extension is added for the first time

Is it possible for an extension to prompt the user to reload the application when enabled for the first time? Our extension needs to be able to register some custom USD plugins at startup.
Similar to what you might see in VS Code:

The physics extension in https://github.com/NVIDIA-Omniverse/kit-extension-template-cpp prevents you from enabling the extension until the application is restarted. Maybe that's what we should do too.
https://user-images.githubusercontent.com/915398/231169098-bfdf1368-50d2-4b1e-8efb-7815b723ec03.mp4


[liblas] Add new port

Related issue: #6634

Thanks for the update.
BTW, what does the internal label mean for Vcpkg?

The build of this port on Windows has been passed, and the support for Linux will be added later.

/azp run

Thanks for the PR!


start command gives spawn ./ngrok ENOENT: Error

I use the latest version of ngrok-for-vscode as well as vscode itself.
Since yesterday from a sudden, the start command doesn't work. When I checked the logs, it gives the error below.
[2021-03-09 20:33:07.840] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:35:43.610] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:46:12.124] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:46:29.777] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:46:38.233] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:46:56.419] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:46:59.781] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:47:05.254] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:47:22.414] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:52:30.461] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)
[2021-03-09 20:52:35.216] [renderer1] [error] spawn ./ngrok ENOENT: Error: spawn ./ngrok ENOENT
	at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
	at onErrorNT (internal/child_process.js:469:16)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)

This is weird, as I'm also getting this myself. Will look into it as soon as I can.

This is weird, as I'm also getting this myself. Will look into it as soon as I can.

Yes! Super weird. I cleaned VSCode caches, downgrade the version of ngrok-for-vscode, reinstalled, and none of them did not work.

Same here - nothing much to add but it seems to be around the way spawn is used. could be related to local Node.js version?

I thought it might be something to do with the way spawn was called in the ngrok package, and initially changing ./ngrok to ngrok fixed things. But that was only because it was then calling on my globally installed ngrok executable, not the one provided by the ngrok Node package. So that was a dead end.
It appears that the ngrok executable that is downloaded is present, which makes no sense as it then can't find it (ENOENT).
I wonder if this has anything to do with npm upgrades and how processes are run postinstall.
Other than that, I'm a bit lost right now.

It's really super weird. I really don't want to mix things up, but I have another MacBook with the same environment as I currently use (node versions, VS code versions, etc.) It doesn't have such an issue. So I'm not sure if it is related with node.

It's really super weird. I really don't want to mix things up, but I have another MacBook with the same environment as I currently use (node versions, VS code versions, etc.) It doesn't have such an issue. So I'm not sure if it is related with node.

I recently noticed that my second Macbook started having the issue. Then, realized the vscode updated. So I guess it is a vscode related issue.

Thanks for the update, at least we're finding a reason for consistency and I have somewhere to look. Hope to sort this soon!

Ok, turns out this was a problem upstream in ngrok which I have fixed.
Update ngrok-for-vscode to version 1.8.4 and it should work again.

Ok, turns out this was a problem upstream in ngrok which I have fixed.
Update ngrok-for-vscode to version 1.8.4 and it should work again.

Thank you, Phil!


Modified the listchanneltxn subcommand

Change Description
start_height must be <= end_height, error otherwise
transactions are returned in direct order (oldest first)
an additional flag --reverse is added to change the order (--reverse true, recent first)
Modified docs by modifying comments in the listchaintxn description command
Steps to Test
Carry out a debug installation using this command:
make && make install
Test command:
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000| grep block_height
Expected outcome: transactions are returned in the order, oldest first

./lncli-debug --no-macaroons listchaintxns --start_height 7000 --end_height 200| grep block_height
Expected outcome: Error

./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000 --reverse| grep block_height
Expected outcome: transactions are returned in the reverse order,  newest first

Change after review
Test command:
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000 --reverse| grep block_height
Expected outcome: transactions are returned in the order, oldest first

./lncli-debug --no-macaroons listchaintxns --start_height 7000 --end_height 200| grep block_height
Expected outcome: Error

./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000| grep block_height
Expected outcome: transactions are returned in the order,  newest  first

Thanks would this involve amending existing commit messages or would I have to take Git HEAD to the tip before I started making changes then make all the changes one after the other, to get the commit to look like that

Thanks would this involve amending existing commit messages or would I have to take Git HEAD to the tip before I started making changes then make all the changes one after the other, to get the commit to look like that

In this case I would take the second approach. You can reset your head while keeping the changes (git reset --soft HEAD~2), then add the couple of fixes + create the right commit structure (git commit -p is your friend here).
When the log is in good shape remember to add one last commit updating the release notes (you can check other PRs to see how it's done)

@chinwendu20, remember to re-request review from reviewers when ready

ok working on it @positiveblue

I have made the change @positiveblue

@chinwendu20, remember to re-request review from reviewers when ready

@chinwendu20, remember to re-request review from reviewers when ready

@chinwendu20, remember to re-request review from reviewers when ready

@Chinwendu20  - are you planning to continue work on this? if so, please click the "re-request" review button :)

Yes, thank you. Just seeing that there is a conflict. I will fix it and re-request a review @ellemouton

@Chinwendu20  - it seems that not all the comments left in the previous review have been addressed?

you have to do into "Files Changed" and then click the "Review Changes"  button. Then you will be able to click "Submitt Review" which would submit your comments

Okay thank you

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

Hello @positiveblue please I have made changes to this PR do you mind reviewing it again?

Reverting  the lnrpc changes... hold on

All done. Ready for review.

@positiveblue: review reminder

Hello, I have added the release note and fixed the lint error, do you mind rerunning the workflow?

So sorry for the back and forth, for some reason. I cannot seem to see any error when I run make lint locally:

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@Chinwendu20 Is there anything I could so that we could get this PR in ?

@Chinwendu20 Is there anything I could help with so that we could get this PR in?

@Chinwendu20 I had a similar issue regards running the make lint command since I've 8GB of RAM. This is solved by passing the number of concurrent workers to be 1 so the full command make lint workers=1 hope it works for you :)
So sorry for the back and forth, for some reason. I cannot seem to see any linting error like it is on the CI when I run make lint locally:

Thanks @mohamedawnallah. I think I was waiting for review here?

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

@positiveblue: review reminder

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity


Teach Find command to populate the search box with selected text

Alternative to https://github.com/microsoft/terminal/pull/8510.
Enables single line search by default (aka vscode).
PR Checklist

[x] Closes https://github.com/microsoft/terminal/issues/8307
[x] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated - not yet
[ ] Schema updated
[ ] I've discussed this with core contributors already.

Detailed Description of the Pull Request / Additional comments

If a single line of text is selected, use it to populate the search box.

Validation Steps Performed

Manual tests

@zadjii-msft - can you please kick the CI?

Yea, I was just making sure to update #8495 first. Wanted to look at the log if there was anything revealing in it. I learned nothing.

Yea, I was just making sure to update #8495 first. Wanted to look at the log if there was anything revealing in it. I learned nothing.

@zadjii-msft - do you know to answer the question that I asked there? What is this sleep in the initialization?

Oh jeez, didn't see the reply. I'll follow up on that thread.

@zadjii-msft - we have to approves 😛