Added flat correction

This PR adds flat_correct and its mutating version to the package.

Maybe it is just easier to remove the min_value functionality. I feel like
it makes more sense for the user to modify the flat frame beforehand
instead of adding this tiny bit to the function.
On Sun, May 24, 2020 at 12:32 PM Siddharth Lal<EMAIL_ADDRESS>wrote:

@siddharthlal25 commented on this pull request.
In src/methods.jl
https://github.com/JuliaAstro/CCDReduction.jl/pull/4#discussion_r429681416
:

+function flat_correct!(frame::AbstractArray, flat_frame::AbstractArray; min_value = nothing, norm_value = nothing)

size(frame) != size(flat_frame) && error("size of frame and flat frame are not same")
!(norm_value === nothing) && norm_value < 0 && error("norm_value must be greater than 0")

!(min_value === nothing) && @. flat_frame[flat_frame < min_value] = min_value

if !(norm_value === nothing)

   flat_frame ./= norm_value

else

   flat_frame ./= mean(flat_frame)

end

frame ./= flat_frame
return frame
+end

Secondly, there is a fault with my version, it at times will act mutating
for flat_frame as well (when some elements in the flat_frame is smaller
than min_value), which I think is not something which a user would
prefer. What are your thoughts on this? I was thinking of doing _flat =
deepcopy(flat_frame) and then proceed in the usual way using _flat.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/JuliaAstro/CCDReduction.jl/pull/4#discussion_r429681416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLSIA3QNXT5JOHZ2XRD3WDRTGN6BANCNFSM4NIZQSGQ
.


Attribute public IP address at the deploy for the auto scale instances

Hey there,
So, what about if the auto scale instances doesn't have a public IP address? By default amazon blocks all outgoing requests if you don't have a IP, this would block the git update, and so on.
What about this:

Create a new allocation IP for VPC or Classical
Allocate this IP with the instance
Deploy
Remove allocation

Hi @tryvin
Are requests also blocked when using public DNS name? If that's not the case you could just follow that path.
If that it the case, your idea makes sense but I'm not sure if this gem should be responsible for something like that. Shouldn't another gem be in charge of such task?

Hi @tryvin ,
If you don't have public IP's to your instances you can attach a NAT-gateway to you VPC.
By doing this your instances can send outgoing requests (as long as you don't block them in security groups etc).
Your suggestion would work too but I agree with @marcoschicote that those steps should be handles outside this gem.

Closing this as there has not been activity for quite some time.


Clang 17 on arm build of Dockerfile

@alexander-penev This is the error which arises when trying to build the xeus-clang-repl Dockerfile with llvm-project version 17.x on an arm based architechture , mentioned in PR https://github.com/compiler-research/xeus-clang-repl/pull/77 . I don't currently know enough about the project to be able to fix this, but I'm happy to test the suggestions of others.
+ python -c 'import cppyy'
/home/jovyan/cppyy-backend/python/cppyy_backend/loader.py:154: UserWarning: No precompiled header available (/home/jovyan/cppyy-backend/python/cppyy_backend/etc not writable, set CLING_STANDARD_PCH); this may impact performance.
  warnings.warn('No precompiled header available (%s); this may impact performance.' % msg)
Failed to execute via ::process:Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]
Failure value returned from cantFail wrapped call
Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]
UNREACHABLE executed at /home/jovyan/llvm-project/llvm/include/llvm/Support/Error.h:815!
/bin/bash: line 1: 47760 Aborted                 (core dumped) python -c "import cppyy"

@vgvassilev I have no idea what this could be. Any guesses?

Perhaps similar to https://github.com/llvm/llvm-project/issues/61712 ?


[Enhancement] Support equivalent constant expression rewrite

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

PullUpPredicateRule:

Pulls the predicate up to a position where it cannot go any further, and generates a LogicalFilter there.
This filter will be pushed down again in the subsequent predicate pushdown rule.
A series of equivalence derivations and constant simplifications can be applied during pushdown.

PushDownPredicateAggRule
The column ref in Agg Node/Sort Node can be replaced with the constant equivalent condition of its children.
Where a = 1 Group by a,b => where a = 1 Group by b
Where a = 1 order by a, b => where a = 1 order by b
Join equivalence derivation
Because the qualified filter in the child node of JOIN will be pulled to the upper layer, and then the equivalent predicate will be generated in PushDownJoinPredicate
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 222 / 371 (59.84%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/JoinEquivalentPredicatePushDown.java
0
66
00.00%
[20, 24, 25, 26, 32, 33, 34, 38, 39, 40, 42, 43, 44, 48, 49, 50, 51, 52, 53, 55, 58, 63, 65, 66, 68, 69, 72, 73, 76, 77, 80, 81, 86, 87, 89, 90, 91, 92, 93, 94, 96, 97, 98, 100, 101, 102, 104, 106, 110, 111, 113, 114, 115, 116, 117, 118, 120, 121, 122, 124, 125, 126, 128, 130, 133, 134]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/EquivalentConstantExpressionRewrite.java
0
83
00.00%
[26, 30, 31, 38, 39, 40, 44, 45, 46, 47, 49, 52, 53, 54, 57, 58, 59, 60, 61, 62, 64, 67, 68, 69, 70, 71, 72, 74, 76, 80, 82, 83, 85, 87, 88, 89, 90, 91, 93, 94, 96, 97, 100, 101, 102, 103, 105, 106, 107, 108, 109, 110, 112, 114, 115, 116, 117, 118, 119, 124, 126, 128, 130, 131, 132, 133, 134, 136, 137, 138, 140, 142, 143, 146, 147, 150, 151, 152, 153, 154, 158, 159, 160]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateSortRule.java
34
34
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
64
64
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
119
119
100.00%
[]

use ScalarEquivalenceExtractor to deriver more predicate

[FE PR Coverage Check]
:heart_eyes: pass : 180 / 186 (96.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
0
2
00.00%
[92, 93]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
103
107
96.26%
[202, 203, 208, 209]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 176 / 182 (96.70%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
0
2
00.00%
[92, 93]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
103
107
96.26%
[207, 208, 213, 214]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 180 / 186 (96.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
0
2
00.00%
[92, 93]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
103
107
96.26%
[207, 208, 213, 214]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 196 / 204 (96.08%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
0
2
00.00%
[109, 110]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
118
124
95.16%
[230, 231, 236, 237, 247, 253]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 196 / 204 (96.08%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
0
2
00.00%
[109, 110]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
118
124
95.16%
[230, 231, 236, 237, 247, 253]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 195 / 201 (97.01%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
118
124
95.16%
[230, 231, 236, 237, 247, 253]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 196 / 201 (97.51%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PullUpPredicateRule.java
118
123
95.93%
[227, 228, 233, 234, 245]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateToExternalTableScanRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneTopNColumnsRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAggRule.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneProjectColumnsRule.java
4
4
100.00%
[]

LGTM, you can solve the problem of comments in the next PR.
Pay attention： repeatNode may is bug
and enhancement：
we can support constant expression，not only constant operator


Delete code from master branch

The code for each post now lives in the post-XX branches where XX is the post number. This makes it possible to see the intermittent state of the code after each post. Code changes are pushed to the earliest affected post-XX branch and then subsequently merged into the following branches.
In theory, we could just merge the latest post-XX branch into master on each change to keep it up to date. However, this would extremely clutter the git history since they're up to ten merge commits for each change (post-01 merged into post-02, post-02 merged into post-03 and so on). Therefore, this pull request takes a different approach.
Instead of keeping the master branch up to date, this pull request removes all code from it and instead points to the post branches from the Readme. This makes it a bit more difficult to find the code, but it has multiple advantages:

The readers directly learn about the post branches, which are much more useful when following the blog than the old master branch.
There is no way to accidentally update the code in the master branch instead of the post branches.

Thus, we never need to backport any changes from master to the post branches.

It improves the separation of concerns: The post branches only contain the code and the master branches only contain the blog sources.

No CI jobs are needed for the master branch anymore (apart from the netlify build checks), so we don't need to wait for CI before merging typo fixes.

See #520 and #538 for more information.
cc @Ericson2314
Closes #520

Awesome! Thanks suggesting these changes!

Let's try whether bors still works:
bors r+

bors r-

bors r+

It seems like netlify does not set commit statuses for branches, only for pull requests. I'm just removing the bors.toml now since I don't think that we need bors for master branch.


Do not work with the lastest ui-router release

Subject of the issue
There is no translation applied with ui-router 1.0.1
Your environment

version of angular-translate 2.15.1
version of angular 1.6.4
which browser and its version Chrome

Steps to reproduce
update ui-router to the version 1.0.1 and reload your webite
Expected behaviour
Translations applied
Actual behaviour
No translations

Hello,
as we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.
Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.

Hi,
I had this problem as well, for me this happened because I was registering a partial loader;
$rootScope.$on('$stateChangeStart', function () {       $translatePartialLoader.addPart('translation');       $translate.refresh();     });
Rewriting this for ui-ruiters new transition hooks gives
$transitions.onStart( {}, function (transition) {       $translatePartialLoader.addPart('translation');       $translate.refresh();     });
and then it worked fine. Hope this helps!

Still not working for me... I'm also using the partial loader...
You want a plnkr and maybe some coffee?

A plunker would be great, I tried to make one but it ended up working and now I can't get it to break nicely... (it's at https://plnkr.co/edit/S3RHEs9hsZgS4WVdXRCu?p=preview )

Hello,
this is a general reminder: We are still waiting for your reply with additional details. If you cannot help us, we cannot help you.
Looking forward to hear from you.

Hello,
I'm closing this issue due inactivity. We have asked for additional details, but you could not helped us. Therefore we close this issue as not reproducible.
If you still have an issue, please create a new issue because we cannot be sure to track closed issues.


Colab: Download of pre trained dataset not possible. the-eye.eu is offline

Descriptions
It is currently not possible to access any dataset or pretrained model. the-eye.eu is not accessible. Also the alternative host "eaidata.bmk.sh" does not serve the data. This makes the Google Colab workbook not operational and prevents me from realizing my usecase.
To Reproduce
Try to open one of the following two links:

https://the-eye.eu/public/AI/gptneo-release/GPT3_XL/
http://eaidata.bmk.sh/data/gptneo-release/GPT3_XL/

Expected behavior
Status Code 200 ("Resource found").
Proposed solution
Provide an alternative mirror for the files.
Affected file: GPTNeo_example_notebook.ipynb

The eye is currently offline due to a natural disaster. They are working to get back online and we are working with them and other partners to establish additional hosts for our datasets so that service isn't interrupted in the future.
The models you are specifically looking for are currently available on HuggingFace.


bump osquery version to 3.3.2 to dev

Should this be backported to 3.0 or do we want to test first?


UTF-8 String in MAT_FT_MAT73

I assume there's still some stuff going wrong with unicode characters while writing them to .mat files using MAT_FT_MAT73.
For example : -
When I'm trying to write Omega symbol in the .mat files, I can't see the symbol for that in .mat file
------------------------Creating a file----------------------------------------------
mat_t *pmat2=Mat_CreateVer("test_73.mat",NULL,MAT_FT_MAT73);
--------------------------Creating a matvar_t variable-------------------------
static const QString qstr = QString(QChar(0x03A9));
std::string dataString= ("Gen Imp Drop ("+ qstr +")").toStdString();
size_t sz[2] = { 1, dataString.size() };
matvar_t *matString=Mat_VarCreate("charArray",MAT_C_CHAR,MAT_T_UTF8,2,sz,(void *)dataString.c_str(),0);
And the output when I print this variable using Mat_VarPrint() is as follows:
Name: charArray
Rank: 2
Dimensions: 1 x 17
Class Type: Character Array
Data Type: 16-bit, unsigned integer
{
Gen Imp Drop ()
}
And when I write this string in file version having value as MAT_FT_MAT5, it gives me correct output.
Can someone please help me debug this? Is there something I am missing here? @tbeu
Thanks in advance
Originally posted by @divyesh19399 in https://github.com/tbeu/matio/issues/189#issuecomment-1499240181

Can you please create a minimal compilable example without the QString/QChar dependency? Thanks.

Can you please create a minimal compilable example without the QString/QChar dependency? Thanks.

@divyesh19399 Friendly reminder.

The following code works for me as expected:
#include <string>
#include "matio.h"

int main() {
    mat_t *pmat1 = Mat_CreateVer("test_5.mat", NULL, MAT_FT_MAT5);
    mat_t *pmat2 = Mat_CreateVer("test_73.mat", NULL, MAT_FT_MAT73);

    const char qstr[] = "\xCE\xA9"; // UTF-8 representation of the Greek letter Omega (0x03A9)
    std::string dataString = "Gen Imp Drop (" + std::string(qstr) + ")";

    size_t sz[2] = { 1, dataString.size() };
    matvar_t *matString = Mat_VarCreate("charArray", MAT_C_CHAR, MAT_T_UTF8, 2, sz, (void *)dataString.c_str(), 0);

    Mat_VarPrint(matString, 1);
    Mat_VarWrite(pmat1, matString, MAT_COMPRESSION_NONE);
    Mat_VarWrite(pmat2, matString, MAT_COMPRESSION_NONE);

    Mat_VarFree(matString);
    Mat_Close(pmat1);
    Mat_Close(pmat2);

    return 0;
}

and generates the following two files.


remove setting hydrator in form factory

Coverage increased (+0.2%) to 22.951% when pulling e155fb2a84978d14661ced2ab4165aa8d5169ba4 on part4_form-and-inputfilter into 254681a38b5e2b3bebee2673ee1194d6cf37e116 on part5_updating-and-deleting.


tensorflow keras model.predict() is not thread safe

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.13.0
Custom code
Yes
OS platform and distribution
Linux CentOS 7.9
Mobile device
No response
Python version
3.11.4
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
We executed model.predict() in multi-thread. And sometimes, the code raised the exception: Functional' object has no attribute 'predict_function.
Standalone code to reproduce the issue
def predict(self, x, tf_server=False, port=8501, model_path='', step=0):
        if tf_server:
            return self.predict_tf_server_grpc(x, port, step)
        pred = None
        try:
            if not self.model_trained:
                print('try to load model ...\n')
                self.load_model(model_path)
                self.model_trained = True
            if step == 0:
                pred = self.model.predict(x)
            else:
                pred = self.model.predict(x, steps=step)
        except Exception as ex:
            print(ex)
        return pred

While the exception raised, we executed the code "self.model.predict(x)" in debug window again, and it returned the correct prediction results.

### Relevant log output

_No response_

@henghamao I have tried to replicate the code in both TF v2.12 and 2.13. I haven't faced the issue reported here. Could you find the attached gists and confirm the same? Please let me know if i am missing something to replicate the issue.
Thank you!

Thanks for looking at the issue.
The issue happend with Python 3.11, and we seldom observed the issue with Python 3.8.
In addition, the model prediction were execueted with multi-thread.
Here is an example to show the major process:
import threading
import numpy as np
import tensorflow as tf
from models.model_attention import AttentionModel
from models.model_attention_three_category import AttentionThreeCategoryModel

class PredictTask(object):
    def __init__(self, thread_num):
        self.thread_num = thread_num
        self.result = []
        # modified to the local model path
        self.model1 = AttentionThreeCategoryModel(40, 20, 10)
        self.model1.load_model('/data/model_save')
        self.model2 = AttentionModel(40, 20, 1)
        self.model2.load_model('/data/model_save')

        self.sl = []
        for i in range(8000):
            # generated data to predict
            self.sl.append(np.random.random((1, 40, 20)))
        return

    def start(self):
        pool = []
        for i in range(min(self.thread_num, len(self.sl))):
            t = threading.Thread(target=self.predict_thread, args=(i,))
            pool.append(t)
            t.start()
        for t in pool:
            t.join()
        return

    def predict_thread(self, tid):
        loop = tid
        cnt = 0
        print('Predict thread %d starting...' % tid)
        while loop < len(self.sl):
            cnt += 1
            try:
                self.predict(self.sl[loop])
                if cnt % 10 == 0:
                    print("Thread %d, predict progress: %d/%d" % (tid, loop, len(self.sl)))
                loop += self.thread_num
            except Exception as e:
                print('Fail to predict stock: %s'%self.sl[loop].stock_sym)
                print(e)
                continue

        print('Predict thread %d completed, finished task number %d.' % (tid, cnt))

    def predict(self, x):
        try:
            pred1 = self.model2.model.predict(x)
            pred2 = self.model1.model.predict(x)
        except Exception as ex:
            print(ex)
            exit(0)
        return (pred1, pred2)

def main():
    p = PredictTask(8)
    p.start()

if __name__ == "__main__":
    main()

@henghamao You should use multi processing to utilize all your resources as multi threading is not recommended mostly. Loading several models in several threads have its own overhead. Could you try increasing the batch size?
Thank you!

In the code, we didnot load models in several threads. We loaded the model in the main process, and used multi-thread to do the predictions.
And we found out a simple workaround is to retry model prediction while the exception raised. With this method, we could get all correct prediction results, though we still observed exception raised sometimes.
def predict(self, x, tf_server=False, port=8501, model_path='', step=0):
        if tf_server:
            return self.predict_tf_server_grpc(x, port, step)
        pred = None
        fail_cnt = 0
        max_fail = 5
        while fail_cnt < max_fail:
            try:
                if not self.model_trained:
                    print('try to load model ...\n')
                    self.load_model(model_path)
                    self.model_trained = True
                if step == 0:
                    pred = self.model.predict(x)
                else:
                    pred = self.model.predict(x, steps=step)
                break
            except Exception as ex:
                print(ex)
                fail_cnt += 1
        return pred

@henghamao Could you please downgrade the python version and retry the training as it is not replicating the reported error there. TF v2.13 is also compatible with that. Thank you!

Downgrade python to 3.8, we did not observe the issue.

Hi,
Thanks for reporting the issue.
Tensorflow in general is not considered as Thread safe, since it has the GIL concept, which prevents threads from executing Python code simultaneously in a single process.
Even if your code has executed successfully in other python version, it does not guarantee or makes a valid use case for Tensorflow to work thread safe.

Thanks for the clarifications.
For multi-thread model predictions, we would use tf serving.
And we could close the issue.


glibtoolize:   error: $pkgauxdir is not a directory

What you were trying to do (and why)
i am trying to brew install opencv@2 in docker build from centos7
What happened (include command output)
so i get this error glibtoolize:   error: $pkgauxdir is not a directory
, but when i exec brew install libtool,
i get  libtool 2.4.6_2 is already installed and up-to-date
so i cd /usr/local/ find no /bin or /Cellar,
and i found out when i install brew in docker build from centos7, i first run this
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
i get
 To install Linuxbrew, paste at a terminal prompt:
    sh -c "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/install/master/install.sh)"

so i run like that, and then i get
Don't run this as root!

so i run this
su zcl -c"sh -c "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/install/master/install.sh)""

and it worked,
but my package installed from brew were installed at /home/zcl/.linuxbrew/,
so i link
ln -s /home/zcl/.linuxbrew/bin /usr/local/bin and
 ln -s /home/zcl/.linuxbrew/Cellar /usr/local/Cellar,
and run brew install opencv@2again, and i get the same error,
so how to fix this problem

so how to fix this problem

There is no problem, that's the expected installation location.

i want to know why i get do not run this as an root

And I had installed libtool.why I get plaguxdir is not a directory

Because it's insecure. You can check out the code if you want answers to such questions.
Also, from the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.

I have the same issue. I try to install libtool from source, it works.
brew rm libtool
brew install -s libtool


duplicate steps on the same level

I'm submitting a bug

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
given a graph with 2 levels, parent level with 3 nodes, child level with 3 nodes, each pointing to all 3 parents, will duplicate the children level nodes 3 times, producing 9 steps instead of 3.
Expected behavior
only 3 nodes in child level
Minimal reproduction of the problem with instructions

[
  {
    "stepId": 1,
    "parentIds": [0]
  },
  {
    "stepId": 2,
    "parentIds": [0]
  },
  {
    "stepId": 3,
    "parentIds": [0]
  },
  {
    "stepId": 4,
    "parentIds": [0, 2, 3, 1]
  },
  {
    "stepId": 5,
    "parentIds": [0, 2, 3, 1]
  },
  {
    "stepId": 6,
    "parentIds": [0,  2, 3, 1]
  },
  {
    "stepId": 7,
    "parentIds": [0, 6, 5, 4]
  }
]

Environment

Angular version: 13

Browser:
- [X] Chrome (desktop) version latest
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [X] Firefox version 101
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 16.14.2
- Platform:   Windows

Hi, I'm sorry I've been bad at looking at issues. Can you create a Stackblitz showing this issue? Then I can hopefully play with it and figure it out.

@pjlamb12 thanks for the reply
here is a demo
https://angular-ivy-xvqdp2.stackblitz.io

@shyallegro I looked at this, and while I guess it's technically a bug, it also is an invalid model. The children (steps 4, 5, and 6) shouldn't point at 1, 2, 3 and 0. If you remove the 0, then it displays as it should.


Allow changing IP/Smart things access token after initial configuration

Is your feature request related to a problem? Please describe.
I am doing some network configuration.  The IP for the TV appears to be effectively hard-coded once initially configured, which is very inconvenient when it changes.
Additionally, if you don't configure a SmartThings token when initially setting up the TV, there doesn't seem to be a way to do it in the options.
Describe the solution you'd like
Allow changing of the IP by some option in the settings after the initial setup.
Describe alternatives you've considered
Configuring a new entity each time is doable, but a pain in terms of fixing orphaned mentions of device/services, and requires copying across the settings from the old entity.

If you start again a new config flow the procedure should detect that the new ip refer to the same device and just update the existing one.

It's good to know that things "should" work automatically, but assuming it doesn't - for some obscure reason - the OP's question remains: Is there a way to manually check and possibly edit the IP ?

Nothing is "automatic" in the procedure that I explain. You manually reconfigure, and if the config flow detect that device ID is the same of one existing it update the IP. The only alternative is delete and recreate.


Removed NSLogs

WARNING https://github.com/ApplauseAQI/ASScreenRecorder/pull/4 must be merged before this one

got rid of NSLogs
Added delegate methods to inform about errors
Moved method for custom drawing from delegate to datasource

Please rebase.

I would love to refactor this class a bit, but let's postpone it until we roll out 3.0.0 of the SDK.

Do you mean splitting it into multiple classes?

I mean general refactor, we could definitely improve the quality of the code style.
--
Aleksander Zubala
On Friday 3 July 2015 at 11:39, Łukasz Przytuła wrote:

Do you mean splitting it into multiple classes?
—
Reply to this email directly or view it on GitHub (https://github.com/ApplauseAQI/ASScreenRecorder/pull/5#issuecomment-118298623).


Window specific properties for tasks ?

What are window specific properties I can use in tasks.json ? I can't find much info in the documentation for tasks.

Also where are script naturally read for VSCode ?

@SheepDomination can you explain what you mean by window specific properties. If you refer to variables you can use in tasks, they are documented here: https://code.visualstudio.com/docs/editor/variables-reference


Add support for RTCPeerConnection.setConfiguration()

See https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/setConfiguration

hello and thanks again @philikon


[BUG] Using \ in AndroidManifest.xml, data could be tampered with

Information

Apktool Version (apktool -version) - 2.4.1 and 2.5.0
Operating System (Mac, Linux, Windows) - Windows 10 x64
APK From? (Playstore, ROM, Other) - Other

Steps to Reproduce

apktool b xxx.apk

Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? Yes.
If you are trying to install a modified apk, did you resign it? Yes.
Are you using the latest apktool version? Yes.

Issue
I wanna use a backslash \ in AndroidManifest.xml like so
<meta-data
    android:name="data_name"
    android:value="\1234567890123456789" />

However, after I built apk file it tampered with the data like so
<meta-data
    android:name="data_name"
    android:value="\<PHONE_NUMBER>23456789" />

This is intentional to trick Android into treating it as a string, vs overflow as an int. I don't see changing this.

This is intentional to trick Android into treating it as a string, vs overflow as an int. I don't see changing this.


can't run

hi,it can not identify class 'NonlinearForcingTerm'

Dear @max-yhy
Finally reaching out to you. Thank you for trying out our code!
One thing I want to check: Before you use the code, have you ran setup.m file at the main directory?
If not, please type setup.m on the MATLAB's Command Window and check whether now the NonlinearForcingTerm class is identified.
Looking forward to your response.


General cleanup and one small bugfix

I tried my best to cleanup the code. First I ran cargo fmt to format the code according to the official guidelines. Afterwards I tried to spot some things that can be written more nicely/shorter and replaced those. I hope you, @passcod , don't mind me doing that.
Furthermore I removed a bug (that will probably never occur in reality).
based on these changes I will start the "real" work: addressing the issues #25 and #2 and fixing a few other bugs that I find.

That looks awesome!
One nitpick: instead of adding // TODOs to the code, can you open issues on the repo so we can keep track more easily?
Finally, please do add yourself to the Cargo.toml; given the potentially extensive refactors you're doing, that's well deserved :)
Thanks for your work! (P.S.  I owe you a beer (or drink of your pleasure ;)… if you're ever in New Zealand, say hi!)

One nitpick: instead of adding // TODOs to the code, can you open issues on the repo so we can keep track more easily?

Right, completely forgot about those. I wanted to deal with those, before creating the PR ;) let me see about those later.
And thank you, but I'm afraid I'm not in New Zealand anytime soon :P

Since #30 contains strictly more changes and this PR still has the issues of TODOs and author, I will just close this one.


What license?

Hi,
Great to see this svelte project. Congrats
What is the license?

Hi, Great to see this svelte project. Congrats What is the license?

Hi there,
Glad to hear that you like it.
The license is MIT, and I've uploaded it to the repository.
BTW, I found that it's just a toy when I began to use HandsonTable.
This web component will create EVERY dom to render a spreadsheet, so it has a poor performance when the row count > 1k...
but if the row count is limited, that's OK. 😃

Thank you for your reply and hint about HandsonTable!


Support adding pages, in addition to regular destinations, to the browser history and use it with thumbnails (issue 12440)

While the referenced issue could very well be seen as an edge-case, this patch adds support for updating of the browser history when interacting with the thumbnails in the sidebar (assuming we want to do this).
The main reason for adding the history implementation in the first place, was to simplify navigating back to a previous position in the document when named/explicit destinations are used (e.g. when clicking on "links" or when using the outline in the sidebar).
As such, it never really crossed by mind to update the browser history when the thumbnails are used. However, a user clicking on thumbnails could be regarded as a pretty strong indication of user-intent w.r.t. navigation in the document, hence I suppose that updating the browser history in this particular case probably won't hurt.
Fixes #12440

/botio-linux preview

Wouldn't we then want to do this in more situations? Clicking a thumbnail changes the page number, so then I'd expect this to also work when entering a page number in the textbox or via the hash parameters, and also when clicking an outline item. I'd say those are all signs of navigation within the document. What do you think?

so then I'd expect this to also work when entering a page number in the textbox

That's somewhat more difficult to implement well, given that we support page labels in addition to just page numbers; hence that's not something I want to worry about here (or even at all).

via the hash parameters,

But, that's been supported from the start[1]...

and also when clicking an outline item.

... and so has this, since those are just destinations, given that it's the primary reason for PDFHistory existing in the first place :-)

[1] To the extent that doing so is feasible, since the old PDFHistory implementation showed that you want to steer well clear of trying to navigate back-and-forth between previous history entries in order to edit them.

But, that's been supported from the start

You're completely right; now that I tried it clearly works. Not sure how I tried it yesterday, but sorry for the noise.
The patch seems to work just fine, so let's do this. Thanks!

Not sure how I tried it yesterday, but sorry for the noise.

It's very possible that your initial testing actually uncovered a bug, since all of this is unfortunately pretty complicated[1]. If so, please let me know if you manage to come up with a way to reproduce it.
No worries; thanks for taking the time to test this and think about the various cases involved.

[1] Unless you simply found an edge-case, which is purposely not implemented because doing so would complicate and/or break the primary functionality of PDFHistory; it'd still be good to know though!


Remove yarn

Issue/Task Number: -
Overview
Remove yarn installation and use default npm.
Changes

Remove yarn installation and use default npm.

Implementation Details

Usage

Impact
Not sure, need @sirn to comfirm

Why reverting back to npm?

@sirn yarn was much better, but now npm catches up with the speed and reliability that yarn provided in 2017-2018
So I think we should switch back to npm, we can also remove yarn deps when installing the ewallet.
related article that think the same as me https://medium.com/@vincentnewkirk/npm-vs-yarn-2019-e88757b17038


Fix "appeal your rateable value" document content_id

This document currently points to e47faa45-3a37-4061-a56f-ba88f1cfb37c, which isn't a valid content_id recognised by either the content-store or publishing-api. This causes republishing of this document to fail.
Working the opposite way from the publishing-api, we do find a content_item that matches this document's base_path:
> ciid = Location.find_by(base_path: "/guidance/how-to-appeal-your-rateable-value").content_item_id
> ci = ContentItem.find(ciid).content_id
"e76c9e81-9fce-48e5-8ccb-100fe77ac14c"

Changing the document's content_id to the above appears to fix republishing without adverse effects.

I think using the lookup endpoint to get the correct content_id at migration time is probably better: https://github.com/alphagov/gds-api-adapters/blob/99aa8c3770d5d1ef72494a9c4a9525bcf21075c6/lib/gds_api/publishing_api_v2.rb#L79-L82

Fixed, good call.

:+1:


Different prediction result for tf.learn QuickStart?

Hello,
Today I upgrade tensorflow package and read the tutorials from the beginning.And find the result of classifier prediction is different, it is [1, 1]. I remember that the old version tf run out [1, 2]. So what's the problem?
The OS is OSX EI Capitan, and tensoflow is 0.12.0-rc0
$ `python -c "import tensorflow; print(tensorflow.__version__)"`
-bash: 0.12.0-rc0: command not found

If I turn on the INFO log level, the log lists below:
$ python iris_classifier.py
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:315 in fit.: calling fit (from tensorflow.contrib.learn.python.learn.estimators.estimator) with x is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:315 in fit.: calling fit (from tensorflow.contrib.learn.python.learn.estimators.estimator) with y is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:315 in fit.: calling fit (from tensorflow.contrib.learn.python.learn.estimators.estimator) with batch_size is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:*******************************************************
WARNING:tensorflow:TensorFlow's V1 checkpoint format has been deprecated.
WARNING:tensorflow:Consider switching to the more efficient V2 format:
WARNING:tensorflow:   `tf.train.Saver(write_version=tf.train.SaverDef.V2)`
WARNING:tensorflow:now on by default.
WARNING:tensorflow:*******************************************************
WARNING:tensorflow:*******************************************************
WARNING:tensorflow:TensorFlow's V1 checkpoint format has been deprecated.
WARNING:tensorflow:Consider switching to the more efficient V2 format:
WARNING:tensorflow:   `tf.train.Saver(write_version=tf.train.SaverDef.V2)`
WARNING:tensorflow:now on by default.
WARNING:tensorflow:*******************************************************
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:323 in evaluate.: calling evaluate (from tensorflow.contrib.learn.python.learn.estimators.estimator) with x is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:323 in evaluate.: calling evaluate (from tensorflow.contrib.learn.python.learn.estimators.estimator) with y is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:323 in evaluate.: calling evaluate (from tensorflow.contrib.learn.python.learn.estimators.estimator) with batch_size is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
Accuracy: 0.966667
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:348 in predict.: calling predict (from tensorflow.contrib.learn.python.learn.estimators.estimator) with x is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:348 in predict.: calling predict (from tensorflow.contrib.learn.python.learn.estimators.estimator) with batch_size is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
WARNING:tensorflow:From /Library/Python/2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/dnn.py:348 in predict.: calling predict (from tensorflow.contrib.learn.python.learn.estimators.estimator) with as_iterable is deprecated and will be removed after 2016-12-01.
Instructions for updating:
Estimator is decoupled from Scikit Learn interface by moving into
separate class SKCompat. Arguments x, y and batch_size are only
available in the SKCompat class, Estimator will only accept input_fn.
Example conversion:
  est = Estimator(...) -> est = SKCompat(Estimator(...))
Predictions: [1, 1]

same issue with Linux server ( CentOS Linux release 7.2.1511 (Core) )
tensorflow version 0.12.0
I got the correct predictions [1,2] of my first run, but my following runs were all [1,1]...

same problem .. still no solution ?

Make sure you delete any pre-existing models. Assuming this is the iris tutorial take a look at
classifier = tf.contrib.learn.DNNClassifier(feature_columns=feature_columns,                                             hidden_units=[10, 20, 10],                                             n_classes=3,                                             model_dir="/tmp/iris_model")
If you don't delete the files in model_dir="/tmp/iris_model" you will be modifying the old model rather than creating a new one.

Update to tensorflow 0.12.1. It seems fixed.

Also, does anyone have a way to get rid of the error messages? The API is deprecated and tf.contrib.learn keeps changing so it's a bit hard to keep track of API updates.

I made a fix version of this here. Using the custom pipe lines.
https://github.com/XRayCheng/tensorflow_iris_fix

Looks like @jacktang said this was fixed in 0.12.1, and @XRayCheng has a fix.
I'm closing this out.  Feel free to file issues for new problems you may run in to!

With v1.1.0, this issue still occurs. The first output is [1,2] and all subsequent runs are [1,1] until I destroy the tmp model.
@XRayCheng's "fix" is not actually a fix -- README still forewarns that all non-fresh runs will produce [1,1].
Some kind of clarification would be nice. 😞 Picking up TF for the first time, and it's pretty rough when the main documentation examples aren't replicated locally.

@lukeed You've already found the solution. After you run the model once, it will be trained and stored in the tmp folder. If you do not delete the tmp folder you are retraining an existing model rather than doing one from scratch. It makes sense that it would have different results

@agriasgg Thanks! But if that's truly the case, then that should be included as a note, imo. I was under the assumption that the model was only looking at the same CSV data every time, which means it should have arrived to [1,2] every time.
Nowhere in the example documentation did it say that every run was going to affect the subsequent outputs.


Better use git [clone] commands instead "curl" in 'Procees.run()'

Hello there again 😆,
I would like to suggest you to use git clone command in Process.run(). As I have seen the command in installation console you are using
curl -o flutter_windows_1.17.5-stable.zip https://storage.googleapis.com/flutter_infra/releases/stable/windows/flutter_windows_1.17.5-stable.zip

Here, it gonna take long time to download it and to extract it. so instead using clone will save the time ⏳ and also space.
I'm working on it. and it is about to complete please do check once I request a pull.
Regards 💙

We need to download the tarballs on all platforms so as to not mess with the analytics.

@csells
I agree that. But if you don't mind, could you please do check my #4 #5 issues too. then you will understand why I suggest this.
Regards.

There's no reason to use curl or to start a new process; Dart has a full network and file system stack. I brought this up as feedback initially but it was not addressed.

@csells As the code uses API services in multiple files, It becomes complex to me too search  the whole code. I really appreciate your hard work towards it. But we can build/code this much simpler(suggestion).

Again. No. We can't.


Sankarshan mishra patch 1

added yaml file in .github/workflows
Issue Number: close #8721

used  Include what you use github action to remove unused headers.
Further comments
Kindly guide me and help me out because It is my first opensource contribution.

Dear Maintainer I am waiting for you to kindly review this pull request, and make me realize if I have made some error in it or accept the pull request kindly look into the pull request. Thank You.

Dear Maintainer I am waiting for you to kindly review this pull request, and make me realize if I have made some error in it or accept the pull request kindly look into the pull request. Thank You.

Sorry for the late reply. It seems that there is not much need to solve this issue at the moment; I forgot to close it earlier.
Thanks for your contribution.

Hello Sir,
Thank you for your appreciation of my contributions to the repository! I'm
excited to continue contributing and am eager to explore new areas that
could be beneficial for the project.
While I currently adept with basics Docker, Java, Spring, JUnit testing,
and GitHub workflow actions, I'm open to broadening my skill set to better
align with the project's needs.
Are there specific technologies or domains outside of my current expertise
that you believe would be valuable for contributing to the repository? I'm
keen to hear your suggestions and embark on learning paths that would
enhance my contributions.
Furthermore, if there are any resources or recommended learning materials
you could share to expedite my skill development in these new areas, I
would greatly appreciate it.
Thank you once again for your support, and I look forward to your guidance
on how I can further contribute to the project's success.
Best regards,
Sankarshan Mishra
(21) Sankarshan Mishra | LinkedIn
https://www.linkedin.com/in/sankarshanmishra/
On Tue, 16 Apr 2024 at 12:00, jakevin @.***> wrote:

Sorry for the late reply. It seems that there is not much need to solve
this issue at the moment; I forgot to close it earlier.
Thanks for your contribution.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/doris/pull/33159#issuecomment-2058327514, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5WQPWW6E4WQQM7B3OLPJNTY5TARPAVCNFSM6AAAAABFS3BXRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGMZDONJRGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Updated packages icon

Updated WPS (KingSoft) office icon (New Brand icon)
Updated Spotify icon (using SVG file)
Updated Tor-Browser icon (using SVG file)

:white_check_mark: Package verification completed without issues. PR is now pending human review

What's the purpose behind changing the Spotify and Tor-Browser icons to SVG?
Submitting the Kingsoft image by itself is not going to work. The .nupsec uses an icon which is hosted by rawgit.com (which is no longer operating) and refers to a specific commit.

What's the purpose behind changing the Spotify and Tor-Browser icons to SVG?
Submitting the Kingsoft image by itself is not going to work. The .nupsec uses an icon which is hosted by rawgit.com (which is no longer operating) and refers to a specific commit.

Because in SVG images we do not face the problem of quality reduction.

Because in SVG images we do not face the problem of quality reduction.

Can you point me to where you are seeing a reduced quality image? The package pages look fine to me.
The PNG format for package icons is the preferred format.

Because in SVG images we do not face the problem of quality reduction.

Can you point me to where you are seeing a reduced quality image? The package pages look fine to me.
The PNG format for package icons is the preferred format.

OK, I close this PR.


method signature

Hi,
the sample code says
this.Dialogs.Add(Id, new WaterfallStep[]
{
    async (dc, args, next) => { /* omitted */ }
}
´´´

This method signature does not exist anymore. Instead ```Add()``` only takes the context and a cancellation token. Args are passed through the context.

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: 8a9577ff-cf56-e5de-84c3-bfe10aab5368
* Version Independent ID: b5d62753-f87b-4673-b09b-a5a3fd9360e8
* Content: [Create an integrated set of dialogs - Bot Service](https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-compositcontrol?view=azure-bot-service-4.0&tabs=csharp)
* Content Source: [articles/v4sdk/bot-builder-compositcontrol.md](https://github.com/MicrosoftDocs/bot-docs/blob/live/articles/v4sdk/bot-builder-compositcontrol.md)
* Product: **bot-framework**
* GitHub Login: @v-ducvo
* Microsoft Alias: **v-ducvo**

@mplogas This article is very out of date. We've removed it from the TOC for now. But we missed a link to the topic. I'm removing the link for now, but will put it back in and add the component dialog topic back to the TOC once it is updated. Sorry for the confusion.


Function filtering

In many cases, it is desirable to apply a function to only a subset of resources in a package. Instead of trying to do this on a per-function basis, kpt should provide a generic method to filter which resources a function applies to.
Some examples of concrete requests for this:

#2356 - file-path matching
#2384 - filter by specific resource name+namespace
#2364 - filter by GVK
v0.39 example of applying an annotation to resources by apiVersion
#2315 - filter by annotation

There's a tracking issue for this feature: https://github.com/GoogleContainerTools/kpt/issues/2015


Fix Rational operators for C++20

Based on C++20 rules, one equality operator ends up calling itself recursively. Tests now pass with GCC 10 (before two failed).

LGTM.


fix: fix typo in error message

Proposed Changes

resoling should be resolving

Related Issues/PRs
n/a
Checklist

[ ] I cleaned up my code.
[ ] All the tests and checks passed (npm run test).
[x] I have added necessary documentation and/or updated existing documentation.
[x] I have added or modified tests to cover the changes.

Thank you for your contribution @adamaltman!


Fixed #30785 -- Doc'd that SESSION_COOKIE_DOMAIN supports subdomains.

#30785: Docs for SESSION_COOKIE_DOMAIN extended with hint about subdomain wildcard

@GitRon Thanks for this patch :+1: , however leading dot is not necessary anymore, sorry for confusing (see ticket 28741 and afd375fc343baa46e61036087bc43b3d096bb0ca).
Closing per ticket.

@GitRon Thanks for this patch 👍 , however leading dot is not necessary anymore, sorry for confusing (see ticket 28741 and afd375f).
Closing per ticket.

Hi @felixxm I tried it and it is not working without the dot...


Analyze commands not supported by mcpi

The complete API supported at the server is:
https://github.com/zhuowei/RaspberryJuice
There is a mcpi modded to include the full API: https://github.com/zhuowei/RaspberryJuice/tree/master/src/main/resources/mcpi/api/python/modded/mcpi
With it, for example, entities can be created. And there are a lot of them:
https://github.com/zhuowei/RaspberryJuice/blob/master/src/main/resources/mcpi/api/python/modded/mcpi/entity.py
We are using right now the 1.11 version which includes:
1.11 - spawnEntity, setDirection, setRotation, setPitch
In 1.12 we have also:
1.12 - getEntities, removeEntities, pollProjectileHits, events calls by player and entity
so we need to move to it. In javierete.com we have:
root@javierete:~# ls -1 /home/minecraft/spigot/plugins/
PluginMetrics
RaspberryJuice
bStats
raspberryjuice-1.11.jar

We need to migrate to the last one.
https://www.spigotmc.org/resources/raspberryjuice.22724/

But, is there a mcpi package including the new API calls? I don't think so. So probably, we can extend mcpi from mcthings in some way, or to create a pip package mcpi. Adding entities is pretty cool.

The future seems to be this one: https://github.com/zhuowei/RaspberryJuice/pull/84#issuecomment-544295161
«It feels like time for RaspberryJuice2. A separate plugin which makes a clear distinction about the break in compatibility and takes forward the premise of a real-time Minecraft API.»
But it is a bit unclear how it will be done.

mcpi API (Raspberry PI Minecraft API) has survived more than 10 years, so it is a good thing to adhere to it. And there are a lot of creations done using it. So be careful using other extended APIs.
For example, in minetest, this API is also implemented in:
https://github.com/arpruss/raspberryjammod-minetest
so McThings must work out of then box also with minetest. All the creations done must work equally in Minecraft and in Minetest which is awesome.
So I wold create another version McThings experimental/lab to play with other options.

All of the commands are now supported in mcpi: https://github.com/martinohanlon/mcpi/commit/47c6d5b8280ed280ad5ba72feffd2571abe82605
Great!!! So we can close this issue.


Add more SAMD21

Hi!
I actually use SAMD21G17 and SAMD21J18 in a project of mine, so I’ve added those in.
Might be useful to someone and does no harm!

Hi @homeodor
Thanks for your PR. To be complete and avoid future issue, could you please also add to your PR these

__SAMD21E15A__, __SAMD21E16A__, __SAMD21E17A__, __SAMD21E18A__
__SAMD21G15A__, __SAMD21G16A__
__SAMD21J15A__, __SAMD21J16A__, __SAMD21J17A__

then I'll merge. Waiting for your updated PR.
Thanks and Regards,

Hi @homeodor
The new SAMD_TimerInterrupt releases v1.6.0 has just been published.
Your contribution is noted in Contributions and Thanks even the PR was not merged, but thanks to your idea, many more boards, such as SAMD21E1xA, SAMD21G1xA andSAMD21J1xA, have been supported now.
Best Regards,

Releases v1.6.0

Fix multiple-definitions linker error. Drop src_cpp and src_h directories
Add example multiFileProject to demo for multiple-file project.
Add support to many more boards, such as SAMD21E1xA, SAMD21G1xA andSAMD21J1xA
Optimize library code by using reference-passing instead of value-passing
Update all examples
Update Packages_Patches


atlauncher: add missing libraries

Description of changes
Fixes #319632
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Split into two commits for a simpler diff. Please let me know if it should be squashed into one instead.


95-BE/wrong-metadata-value-separator-was-imported

Problem description
After import metadata value which consist of more values is separated by @@ and not by the ; e.g.

There should be ; as separator.

This issue is resolved in: https://github.com/dataquest-dev/dspace-python-api/issues/11


I can't find appearance matrix B in code

Hi, thanks to make this great code and paper! I really enjoy this.
In Tensorf paper,

appearance values(A_c(x)) are concatenated and then multiplied by appearance matrix B.
And then, sent this into the decoding function S for RGB color regression.
But in this code ,https://github.com/apchenstu/TensoRF/blob/17deeedae5ab4106b30a3295709ec3a8a654c7b1/models/tensoRF.py#L223
I can't find the appearance matrix B.
I understand that plane_coef_point is matrix M and line_coef_point is vector v.
From this line,
https://github.com/apchenstu/TensoRF/blob/17deeedae5ab4106b30a3295709ec3a8a654c7b1/models/tensoRF.py#L239
M and V are multiplied and then go into basis_mat which is nn.Linear(144,27).
And then this 27-dimension outcomes go into positional encoding block and Feature decoding function S.
During this process, I can't find any appearance matrix B mentioned in the paper.
Is the self.basis_mat is matrix B?
If it is not, where is matrix B and what is the self.basis_mat?

I print the tensorf below. It shows that self.basis_mat is the matrix B. It has 144*27 weights. The author uses them to express the matrix B.
TensorVMSplit(   (density_plane): ParameterList(       (0): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x128 (GPU 0)]       (1): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x128 (GPU 0)]       (2): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x128 (GPU 0)]   )   (density_line): ParameterList(       (0): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x1 (GPU 0)]       (1): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x1 (GPU 0)]       (2): Parameter containing: [torch.cuda.FloatTensor of size 1x16x128x1 (GPU 0)]   )   (app_plane): ParameterList(       (0): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x128 (GPU 0)]       (1): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x128 (GPU 0)]       (2): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x128 (GPU 0)]   )   (app_line): ParameterList(       (0): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x1 (GPU 0)]       (1): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x1 (GPU 0)]       (2): Parameter containing: [torch.cuda.FloatTensor of size 1x48x128x1 (GPU 0)]   )   (basis_mat): Linear(in_features=144, out_features=27, bias=False)   (renderModule): MLPRender_Fea(     (mlp): Sequential(       (0): Linear(in_features=150, out_features=128, bias=True)       (1): ReLU(inplace=True)       (2): Linear(in_features=128, out_features=128, bias=True)       (3): ReLU(inplace=True)       (4): Linear(in_features=128, out_features=3, bias=True)     )   ) )

@LiuTielong Oh! Now I can understand this part! Thx for your kind comments!


Support for GitHub Enterprise

Problem
Currently mockito-release-tools works only with github.com. A path to it is hardcoded in the code. This project needs to works with GitHub Enterprise API. A property to configure GitHub Enterprise needs to optional and by default it should works with github.com.
Suggested implementation
ReleaseConfiguration.GitHub should have an optional setting for the url base host.

@mstachniuk, can you confirm suggested implementation above?

I suggest to add 2 options to the configuration:
releasing {
    github.api = "https://github.in.your.company.com/api/v3"
    github.url = "https://github.in.your.company.com"
    // others ...
}

The first one to the API endpoint for generation API requests and second one for generating links for  developers in pom (see: PomCustomizer.groovy)

Nice proposal! I updated "api" -> "apiUrl". Let's make sure they are defaulted so that we don't have to configure it for typical OS builds.


Sticky footer added

Merged all the commits except for the last one (84d110f) which doesn't have functionality, only trying to restore files that were altered involuntarily.


[Bug] Camera set under playermodel

Disable all addons that mess with the camera (CalcView)

^ that, not a problem with beatrun


Remove RefTimeWeight

It was suggested internally that a type alias can be more harm than good.
Rather than doing a newtype construction, I feel it is safe to simply expose u64 as the inner fields of the Weight struct.
polkadot companion: paritytech/polkadot#5964
cumulus companion: paritytech/cumulus#1590

bot merge

bot merge


Data Management Guidelines

DO NOT MERGE, draft version for review
This is the draft of a Data Management Guidelines page for the website.
Technical details regarding folder structure and file sizes line 14, and md5 checksums line 44 needed.

I have to admit, my first worry is where the page is located. If it's going to be under the Usage menu, the title really needs to explain it all. Personally I don't think Data Management Guidelines is enough to explain to someone looking for estimating resource usage that this is a page to look at. Maybe this is just an issue of the layout of the landing page, but I think the Documentation needs to be more front and center with perhaps a little blurb explaining what can be found on each page. I would suggest this (and other pages) needs to have the same visibility as "See what's available", "Run a pipeline", and "Get into the code".
Another suggestion is that a more general introduction to Data Management is needed to convey what the rest of the page contains, and why this is useful to the reader. My personal opinion is that upon starting with reading about a DMP, a reader will just see this as extra work, without understanding the necessity.
Thinking from a very selfish user perspective, I think each section needs to demonstrate why doing this benefits them. Also, it would be beneficial if anything can be automated by a workflow, that it is pointed out, e.g. partial metadata generation.
My last comment is that at the moment, the docs are also very SE / EU centric, and so it would be nice if other international resources were also mentioned, e.g. adding in links for GenBank and DDBJ.

I think the Documentation needs to be more front and center with perhaps a little blurb explaining what can be found on each page.

Yes I think you're probably write. I've been vaguely thinking that the navigation could do with a bit of an overhaul generally. I made a new issue to discuss this: #352

Hi, I have read the new docs and it reads nicely. I was just a bit confused about the context for the docs, as nf-core per se does not offer a data management solution. However, as general information on what are data management guidelines it looks good to me.

The initial discussion started in slack about how it would be a good idea for workflows to provide an estimate of computer resources needed, which are often needed for data management plans. Then data sharing as part of the report was also suggested (how and where workflow users could deposit their newly analysed data to encourage open science).
That was the aim of including this document into nf-core. I'm not sure how to re-angle this so it's presented from that position. The title of Data Management Guidelines then does seem to confuse the situation.

Hi @mahesh-panchal, great, it sounds like a good idea to me to include something on these lines :)

@mahesh-panchal - I think it's fine to have both things. Specific estimates for each pipeline, and also these more general guideline instructions to help groups work with best-practices. I think as long as there is a general introduction giving a more gentle slide in, it should fit ok.

Many thanks for your wok on this @elinkronander - I think it's looking great! I'll merge now, we can always make PRs in the future if any more suggestions come up.
Phil

Ok, new page is live! ✨ https://nf-co.re/usage/data_guidelines
Added to the top navigation in https://github.com/nf-core/nf-co.re/pull/359

Link updated: https://nf-co.re/usage/data_management


No link to RSS feed in template

It still exists but I don't see it linked anywhere in the main template

https://github.com/linode/blog/pull/22


Bug with the EnumPicker editor script, preventing lists of effected enums

There is a bug withing the EnumPicker script which prevents you from creating lists of the effected enums in editor. When trying to add values to the list, an error is thrown in console and the list size remains at 0.
Error in console

Example script for reproducing the bug. The list of enums which are handled by EnumPicker do not work, and the ones not touched still work

The only enum lists that don't work are the ones that EnumPicker touches

Fixed. The EnumPicker was checking if the field was an array, but not if it was a List.


Version info doesn't include 3rd party code

It would be nice to embed the version info for the 3rd party code that is compiled in/linked against
Eg.
asio (code)
jsoncpp (code)
libmodbus (lib)
libmicrohttpd (lib)
tclap (code)
etc.

Git submodule versions are listed in the version info now


Fix potential null diplicate key error on lookups.ipAddress

Fixes https://github.com/RackHD/RackHD/issues/139

:+1: with unit test updates to resolve build failure :-)

Fixed failed test.

:+1:

test this please


Adjust month name to respect Locale

https://github.com/boguszpawlowski/ComposeCalendar/blob/afff02d8cb1c53c0ae6b89b020e0b8ed72f03a7e/library/src/main/java/io/github/boguszpawlowski/composecalendar/header/DefaultMonthHeader.kt#L47
In line 47 of DefaultMonthHeaderwe use the enum name as the month name. This will always default to English!
In Java 8 (used by Android and currently used by this lib) we have the method getDisplayName, which I believe is more suitable to the situation, as it will respect users' locale.
https://docs.oracle.com/javase/8/docs/api/java/time/Month.html#getDisplayName-java.time.format.TextStyle-java.util.Locale-
My UseCase is that my app is in Brazilian-Portuguese, and I'm unable to customize the month display name without reimplementing the DefaultMonthHeader.

@LeoColman Thanks for the contribution, issues should be fixed in 0.4.1-SNAPSHOT. Can you confirm on your end?

Yes!
I tested with 0.4.1-SNAPSHOT and it fixed it to the default locale.
I also took a look at PR #49 and it seems exactly what I would implement if I would do it myself, so the PR seems perfect too 🗡
Thanks for the quick work on this one, @boguszpawlowski !

Great! I have triggered a 4.0.1 release, should be available in Maven Central in about half an hour


Add support for basic auth

Hello!
Would be nice if you added the ability to test the routes protected by basic auth.
Some of my use cases require this thing, and I have to use ab as a fallback, which is something I don't really want...

Plow can specify headers using -H, and BasicAuth is actually a type of header format, so it can be manually converted into user:password format using -H "Authorization: Basic base64(username:password)". The base64 calculation part can be done using some online websites such as https://www.debugbear.com/basic-auth-header-generator.

Well, I know that I can specify just base64 of login:password, but I thought more of options to pass them directly (e.g. -u user -p pass). But thank you anyway for rapid response!


Rotate/flip layers

Hi, I've added the feature to be able to rotate/flip layers. Please take a look at my code, and if you like it, then I'll clean this up a bit before merge (updating documentation, tests, etc)

Does this work for animated GIF?

Hi, I've updated the Gif Engine also, did work for me as expected.
I still have a problem: order of actions could be important when combining rotation and flip, but the current parametrized bag implementation is unaware of that. So this might would need some changes down there also. For now rotation is always executed as first, resample as next, and flip as last.

Imagecraft project is started when my website need to manipulate avatars that users upload, so this is why I forgot to add rotate/flip features to imagecraft.
My code is very complex, especially the GIF part. I‘ve never thought someone could understand my code and add any new feature to it. Anyway, very great job, I have added you as an imagecraft collaborator, you can merge pull request yourself if you think everything is ok.
Also, to solve the order of actions problem, you can combine flip/rotate to one feature: transform(int $rotate, bool $flip), the image must rotate first, then flip.

Rotate would be a great feature, any change this will get merged?


Repetition on group of alternatives is handled incorrectly

The rule for repetition on groups works for a concatenation group but not for a group of alternatives
For example, this EBNF generates wrong BNF
<separator> ::=
    { <comment>
  | <whitespace> }...

The right way is to first replace the group with a new nonterminal like comment_or_whitespace, then replace the repetition on comment_or_whitespace with comment_or_whitespace_list
The result would be
separator: comment_or_whitespace_list

comment_or_whitespace_list: comment_or_whitespace | comment_or_whitespace_list comment_or_whitespace

comment_or_whitespace: comment | whitespace

This solution actually works for concatenation groups too - so one fix is to replace a group with a new nonterminal like group_0 regardless
group: "{" production_combos "}" {
// groups are replaced by new single nonterminal
// move all productions of group to new rule for new nonterminal
  stringstream groupName;
  groupName << "group_" << groupNumber;
  ++groupNumber;
  bisonParam.result[groupName.str()] = $production_combos;
  $$.insert({groupName.str()});
}

repetition: group "..." {
  auto groupName = (*$group.begin())[0];
  auto listRuleName = groupName + "_list";
  bisonParam.result[listRuleName] = { {groupName}, {listRuleName, groupName} };
  $$ = { {listRuleName} };
}

This isn't great because it creates many new nonterminals and rules - concatenation groups are common in the GQL grammar - but only a few groups of alternatives - and just one repetition on a group of alternatives
It would be nice if we can simply restrict the current rule for repetition on group to concatenation groups - and add a new rule for repetition on a group of alternatives
But it's not as simple as something like
repetition: "{" concatenation "}" "..." {
}
| "{" alternative "}" "..." {
}

because this creates shift-reduce conflicts with the rule for production_combos
production_combos: concatenation | alternative

And production_combos is probably impossible to remove or change because it's crucial to the recursive rules in the grammar
I think the better fix is to tag a group as alternative or concatenation and use the tag to generate different BNF in the action for repetition - something like
struct Group {
  enum class Type {concatenation, alternative};
  Production productions;
};

Fixed with #11


[FEATURE] Remove reliance on disk storage, store everything in the database

Describe the feature you'd like
Currently most information is stored in the database with the exception of a few additional things like:

Secrets (encryption and API keys)
File storage
Logs

Additional context
Deploying with a database is easy and common with Kubernetes and container setups, however persistent volume claims are not as simple. Moving the remaining items in the database would simplify deployment a great deal.
The keys would be an easy move as one is a string (and already has an override which can be pulled from a Kubernetes secret) and the other is a JSON string.
The files could be kept in blob storage, there's some additional consideration on file size but it's terribly complex.

actually the uploaded files are stored as base64 string in database, but we are moving away from this and store to a path folder specified by BLOB_STORAGE_PATH.
log files however are not possible to store in database because of its large size
secrets can be stored in database, however it doesnt seems too secured

Thanks for the reply, Henry. The reason is PVC has its own complications when scaling, for example N Flowise pods with a PVC would require read/write on all of them, and there may be issues if they're moving through nodes. A database, especially if using RDS or something else, is a lot easier to manage and is often cheaper.
I think for logs it's actually cheaper per byte to store them in a database typically vs. disk? I would have to run the numbers, but on cloud I think this might be the case.
For secrets you'd encrypt them in the db that's not a problem, and for the salt or hash you can accept that as a secret in the .env which would be a kubectl secret (single string) just like you do today for the override key.
Files are more difficult, as you mentioned depends on size. At a minimum, an option to keep it all in the database would be very nice and make scaling with helm charts easier (at least, for me).

secrets can be stored in database, however it doesnt seems too secured

Cool, how can we persist the API keys? I didn't find it in the docs

You can create a PVC and set the environment variable path to the PVC. Then it'll persist.

+1 for this.
Deploying to Render.com it seems there's no way to enable a zero-downtime deploy because of the dependency on an attached persistent disk.
This has me wondering how other people are achieving zero-downtime deploys (with Render, or other deployment targets).

Thanks for the reply, Henry. The reason is PVC has its own complications when scaling, for example N Flowise pods with a PVC would require read/write on all of them, and there may be issues if they're moving through nodes. A database, especially if using RDS or something else, is a lot easier to manage and is often cheaper.
I think for logs it's actually cheaper per byte to store them in a database typically vs. disk? I would have to run the numbers, but on cloud I think this might be the case.
For secrets you'd encrypt them in the db that's not a problem, and for the salt or hash you can accept that as a secret in the .env which would be a kubectl secret (single string) just like you do today for the override key.
Files are more difficult, as you mentioned depends on size. At a minimum, an option to keep it all in the database would be very nice and make scaling with helm charts easier (at least, for me).

+1.
Switching to a stateless system would greatly improve how we deploy flows to production. Of course we can use Flowise for prototyping and Langchain for moving to production. However, being able to quickly deploy flows and make live changes with Flowise in prod would be very beneficial.
For logs, storing them on disk is fine. In K8S clusters, logs are usually collected and kept by systems like Loki or ELK, so it’s not a problem if we lose disk logs when a pod is terminated.

Agree. We have maybe 6 instances of Flowise deployed in k8s, and all have challenges with PVC.
Would still greatly prefer everything (except logs, which as you mention are optional) to be stored in the database.

Could you explain a bit more how you have those 6 instances deployed?
Some questions that come to my mind:

Is it a single deployment with 6 instances for HA or are those 6 independent deployments?
If it's a single deployment, are those sharing the same PV? or do you have a different PV for each one?

How I'm thinking of solving it for now:

For API keys I'm thinking on storing the api.json file in a secret and mounting it as a file for the pods. Yes, API keys won't be manageable through Flowise, but for me that's not important in a prod environment.
For files, I'm considering having two deployments of Flowise running. One with one replica for the admin panel and a PVC for the files, and another one with at least 3 replicas only used to integrate the flows through the API without access to the admin panel.

And I might even consider not attaching a PVC at all for the admin replica. We will upload new files every time we run the upsert process, so we don't really need the old ones I guess.
Thanks btw! It's great to know there's more people on the same boat.

It's N distinct deployments, but each instance has HPA on it (we deploy via helm). I'm not DevOps, but I believe they put ReadWriteMany on the PVCs to solve the scaling issue. However the name of the PVC can be a problem and is often lost when we upgrade the instance requiring manual intervention.
It's a pain, frequently causes us issues.

I just noticed S3 is supported as storage for the files, it's mentioned in the documentation. I don't know how I missed it.
So from the list:

Secrets:

Encryption: Can be overwritten with an env variable
API keys: Potentially can be overwritten with a k8s secret mounted as a file.

File storage: S3
Logs: Stored in ephemeral storage.

If this works, we can deploy Flowise without PV.

I can confirm the approach mentioned in my previous comment works great, without the need of an attached storage.
Only downside is that API keys are not manageable through the UI, and they need to be modified from the k8s secret or the secret manager tool of your choice.
So as a next improvement, it would be great to have API keys stored in the database with the rest of the configuration. I know it was mentioned in the thread that this is for security reasons, but if access to the DB is managed correctly (non-public access + secure credentials) I don't think this is a real problem.

You can store API keys now to database as well! https://docs.flowiseai.com/configuration/environment-variables#for-flowise-api-keys

Sorry for commenting on closed topics - I've a side question:
One of the comments (https://github.com/FlowiseAI/Flowise/issues/1858#issuecomment-1975325431 ) implies that we can run multiple pods of Flowise.
The helm chart asks us not to change number of replicas from 1 to other number - If I back Flowise with postgres instead of sqlite, I'm wondering why cannot I run more replicas of Flowise pods?
Does anyone have idea a about this?


Add KDL formatter

Add kdlfmt as a local package
Apply treefmt for kdl

Preparation part for GH-724

zed does not have KDL extension, so cannot be detected as KDL even we set file_types
https://github.com/isbecker/treefmt-vscode is unstable. Using it for KDL, the modifying makes race condition for the file...

Replaced in https://github.com/kachick/dotfiles/pull/728/commits/0c2e2f3f562e6850bcbc74851fe4d18dea54e9ad


Closing a help request does not store the conversation correctly

Rocket.Chat Version:
Running Instances:
DB Replicaset OpLog:
Node Version:

[31mSystem ➔ error Smarti - closing room failed: No conversation id for room sRwKYDRLGwykYCASc

In File: Smarti.js
Method: SmartiAdapteronClose

Compare:

RocketChat.models.LivechatExternalMessage.findOneById(room._id); --> IST UNDEFINED
RocketChat.models.HelpRequests.findOneByRoomId(room._id); --> HAS NO CONVERSATION ID

connectivity issued this behavior.


THRIFT-5003: Websocket Connection in Browsers with nodejs code

After some changes to the ws_connection.js file in the nodejs code, I could create a version of the WSConnection, createWSConnection and createWSClient which is able to run similar code of WebSocket connections in the browser and NodeJS.
Solution is package, isomorphic-ws which provides the proper Websocket libs depending on the env (browser or node)

[x] Did you create an Apache Jira ticket?
https://issues.apache.org/jira/browse/THRIFT-5003
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

Besides the Node version issue, this looks OK. I don't personally use the js/node clients so I'd appreciate another +1.

Like we discussed before I updated the node version to 10.18.0 after testing it on my machine. What is left to merge this PR to master?

This PR is quite relevant for us. @dcelasun could you kindly take a look if this can be merged?

Merged, apologies for the delay.


generate new addresses from xpub?

I generated some addresses on an offline machine, and made a note of the first 20 addresses and the xpub for use online.
I just ran out of addresses and want to generate the next 20, but don't currently have access to the offline machine.
Is there some way to generate the next 20 addresses using just the xpub? The field isn't editable on your web page. I used to use bitcore to do that, but it has stopped working since I switched to the newest Bitcoin Core version which updated my utxo database format.
I'm guessing it's quite a small change to allow the user to enter their xpub directly, but don't know if it's something you want to allow.

An xpub can be used in the BIP32 Root Key field.
It may be necessary to select the BIP32 tab and use a derivation path of m to get the addresses, depending where in the hierarchy the xpub comes from.
See also https://github.com/iancoleman/bip39/issues/40

Thanks. I was trying to edit the "BIP32 Extended Key" field on the BIP44 tab and didn't even notice that the "BIP32 Root Key" field was editable up top.
I'll close this, since I can now do exactly what I wanted to do. :)

Same question but for BIP49 addresses. I'd like to be able to paste in an xpub from an m/49'/0'/0' path and see Segwit addresses. Since the BIP49 tab doesn't let us specify the prefix, it fails because it can use a hardened path. The BIP32 path does let us enter m/0 for the path, but it generates standard addresses, not the P2WSH-style addresses.
Is that possible today, or does it require adding an extra option to the BIP32 tab?

s/can/can't/

BIP49 uses "P2WPKH-nested-in-P2SH" addresses. So there needs to be an extra checkbox added to the BIP32 tab so users can select to use this sort of address.
It should be simple to add this feature, the logic is already worked out from the BIP49 tab, it's just a matter of adding the UI element to the BIP32 tab and hooking it all up.
Good suggestion thanks.

See https://github.com/iancoleman/bip39/commit/88311463c74f022177a21c5d88f8928dc8007d8b - Allow P2WPKH nested in P2SH addresses on BIP32 tab

Confirmed with a test xpub -- works perfectly! Thank you.


32-bit float is not range-checked

When converting a Python int to any C integral type, Cython checks the data type's limits and may raise OverflowError. But it doesn't do the same when converting to a 32-bit float, because it simply has:
#define __pyx_PyFloat_AsFloat(x) ((float) __pyx_PyFloat_AsDouble(x))

There are no data type limits for 32-bit floats, only limited precision, and when casting to a float it's explicit that precision is lost. Positive and negative infinity are used as approximations for values that are outside the range that can be finitely represented, and that's correct for this context as well.
(FWIW, unless you're memory-bound, there's little reason these days to use 32-bit floats and lots of reasons not to.)

I see your point, but accidental conversion to infinity could really ruin someone's day. If C won't implicitly convert a double to a float, is it really correct for Cython to do so?

It does it because you asked for it. This conversion is only used in code that explicitly asks for a float instead of a double.

It could also ruin someone's day for 1e-100 to get truncated to 0. Or for a*b to be infinity despite a and b being finite.
Note that this is what NumPy does as well
>>> np.array([1e-100, 1e100], dtype=np.float32)
array([  0.,  inf], dtype=float32)

OK, fair enough.


The default matcher should trim the term

In most cases it is desired to trim the search term before matching, therefore it should be done by default. The trimming would be especially useful when using tags in "multiple" mode, since it would prevent the adding of duplicate entries.
Steps to reproduce:

Go to https://jsbin.com/kinotukika/edit?html,js,output
Type "test " (with a space at the end) into the input

Expected: "test " should match "test".
Actual: nothing matches, "No results found" message is shown.
Select2 version: any
Browser version: any
OS version: any

Can i pick this up?

Any update on this? I'd like to send a PR for this

This discussion will continue inside PR -> https://github.com/select2/select2/pull/5318


Average objective functions

Summary
Objective functions constructed by the neural network classifiers and regressors now include an averaging factor that is evaluated as 1 / number_of_samples. Computed averaged objective values are passed to a user specified callback if any. Users may notice a dramatic decrease in the objective values in their callbacks. This is due to this averaging factor.
Closes #327.
Details and comments
Updated:

Objective functions
Increased number of samples from 5 to 6 in the tests to improve test convergence and stability.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.058%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
2790

Relevant Lines:
3242

💛  - Coveralls

Is there a defined benefit to this as well. I can perhaps see that the values can remain more or less the same if you change the number of samples a little rather than as things were before. This presumably will only change the scale of the plots in the 02_xxx tutorial - the curve will presumably be the same.


adding gap between form elements skill and knowledge

adding gap between form elements skill and knowledge
improved validation and error messages
closes : https://github.com/instructlab/ui/issues/149

@ashapadmashetti can you please also cherry-pick it to release-1.0 branch as well. thanks


Improves the search for fairs where their profileID is different

I believe this should fix https://artsyproduct.atlassian.net/browse/DISCO-257

Dope, that was easy!


[Nexus] Extra ingress for nexus-proxy

Scenario:
with given values.yml
nexusProxy:
  env:
    nexusHttpHost: nexus.example.com
ingress:
    enabled: true
    rules:
      - host: nexus-extra.example.com
        http:
          paths:
            - backend:
                serviceName: <release_name>-sonatype-nexus
                servicePort: 8080
              path: /

It's impossible to access nexus by nexus-extra.example.com:
This page is displayed - https://github.com/travelaudience/nexus-proxy/blob/master/src/main/resources/templates/invalid-host.hbs.
Expected Result
NXRM can be accessув by both host names - nexus.example.com and nexus-extra.example.com.
Workaround
Use nginx.ingress.kubernetes.io/upstream-vhost: nexus.example.com in ingress.annotations.
nexusProxy:
  env:
    nexusHttpHost: nexus.example.com
ingress:
  annotations:
    nginx.ingress.kubernetes.io/upstream-vhost: nexus.example.com
  enabled: true
  rules:
    - host: nexus-extra.example.com
       http:
         paths:
           - backend:
              serviceName: <release_name>-sonatype-nexus
              servicePort: 8080
              path: /

Want to add a section into the Readme for multiple host ingress?

@rjkernick I realized that this approach probably won't work if docker registry is used. Since hostname will be overridden and I suppose nexus-proxy distinguishes between the protocols based on that.
nexusProxy:
  env:
    nexusHttpHost: nexus.example.com
    nexusDockerHost: docker.example.com

I'll verify and update the description/PR accordingly.

@rjkernick Docker repository won't work if the workaround is used as is. A separate ingress must be added to add extra hostnames to the main UI.
Error response from daemon: login attempt to https://dockerhub.example.com/v2/ failed with status: 404 Not Found

My current approach is to use this chart as a subchart and add an extra ingress.

Any updates on this issue? I'd like to see an additional ingress as well. @EvgeniGordeev

@Skaronator Started working on PR. This will require a split of ingress into http ingress and docker registry ingress which would allow to provide any rules separately and support multiple hosts in both cases:
nexusProxy:
  env:
    nexusHttpHost: nexus.example.com
    nexusDockerHost: docker.example.com
ingress:
  enabled: true
  annotations:
    # workaround for https://github.com/helm/charts/issues/5385
    nginx.ingress.kubernetes.io/upstream-vhost: nexus.example.com
  rules:
    - host: nexus-extra.example.com
      http:
        paths:
          - backend:
              serviceName: nexus-sonatype-nexus
              servicePort: 8080
            path: /
ingressDocker:
  enabled: true
  annotations:
    # workaround for https://github.com/helm/charts/issues/5385
    nginx.ingress.kubernetes.io/upstream-vhost: docker.example.com
  rules:
    - host: docker-extra.example.com
      http:
        paths:
          - backend:
              serviceName: nexus-sonatype-nexus
              servicePort: 8080
            path: /