.Net Update Audio Interfaces according to Models doc

OpenAI
According to the Models documentation the interfaces should be names as ITextToSpeech and ISpeechRecognition accordingly.
This issue is to keep track of this needed change, according with @matthewbolanos

Priority
Model
Status
Interface
Deployment type
GitHub issue
Developer
Reviewer

P0
Text-to-speech
Complete
ITextToSpeech
OpenAI API
TBD
dmytrostruk
TBD

P0
Speech-to-text
Complete
ISpeechRecognition
OpenAI API
TBD
dmytrostruk
TBD

I wonder how abstraction should have implemented real-time audio proccessing.
I think it can be done two ways:

Create additional method in these interfaces, but for models which doesn't support live streaming exception will be thrown.
Create ILiveTextToSpeech and ILiveSpeechRecognition
I want to implement whipser-live local models so... #5032


API Help doesn't do anything

Describe the bug
Click on help button in plugin manager or help->Ghidra API help in code browser do not do anything.  This is the first in 11.1.2 i've looked at api docs, it unzips to who knows and that was it.  Doesn't open anything and further clicks do nothing.
Expected behavior
either button or menu item opens file:/// link in browser
Environment (please complete the following information):
Ghidra Version: 11.1.2
Ghidra Release: PUBLIC
Ghidra Build Date: 2024-Jul-09 1157 EDT
Ghidra Revision: 68cad06ddfae2b92c03054357c67c32f2d0553a8
Ghidra Development Mode: false
OS Name: Linux
OS Arch: amd64
OS Version: 6.8.0-40-generic
OS Pretty Name: Ubuntu 22.04.4 LTS
Java Vendor: Ubuntu
Java Version: 21.0.4
Additional context
Add any other context about the problem here.

Are you using the Firefox snap installation?

#4306?

Ill double check if there are any logs related to ff or snap or if it reacts differently if ff is open, but I use chrome (.deb) as my default browser.

i think the snap were annoying me and looks like I uninstalled firefox.   I have chromium-browser and google-chrome
https://github.com/NationalSecurityAgency/ghidra/blob/6a94f1f7ab21e58e934bb3117d2c1085cfc18604/Ghidra/Features/Base/src/main/java/ghidra/util/ManualViewerCommandWrappedOption.java#L126

something like this maybe:
java.awt.Desktop.getDesktop().browse(uri)

Thanks, i'll give this a try on our various platforms.

I guess to fix this in your current installation you can go to Edit -> Tool Options -> Processor Manuals and change the Command String value.  If that works we need to at the very least:

Rename that option to be more generic
Provider a better error message that lets you know that option is there.

Ah thanks!

Hmmm, I tried Desktop.getDesktop().browse() and got java.lang.UnsupportedOperationException: The BROWSE action is not supported on the current platform on Ubuntu 24.04.

Ah, I guess I got lucky, on 22.04/jdk17 , thats all I had tried it on
Desktop.getDesktop().isSupported(Desktop.Action.BROWSE)


improvements to testing workflow

run along side gulp watch for easier integration while developing or separate gulp tests
karma

keep running/watching for changes? integrate in watch? gulp karma:auto

debugging

allow passing argument to gulp task - http://bahmutov.calepin.co/debugging-karma-unit-tests.html
chrome launcher - https://github.com/karma-runner/karma-chrome-launcher

Closing due to inactivity.


[do not merge]Fix rocm gpu targets

@deven-amd could you please take a look at this change before I submit the upstream PR.

keep the target sync here in sync with the one in TF here - https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream/tensorflow/tools/ci_build/Dockerfile.rocm#L81
please drop gfx803, gfx90a and gfx1010 from the support list

@reza-amd , how are CI jobs getting triggered and who is running them?

I think these are the upstream CI jobs. In the actions tab, it shows the upstream workflow. I am not sure if this a bug or a feature.

https://github.com/ROCmSoftwarePlatform/jax/blob/main-rocm/.github/workflows/ci-build.yaml


Integration looses connection and only HA restart gets it to work again

Describe the bug
Aftee a few hours of being connected, the i tegration looses its connection to the Midea Cloud and no further control is possible. A HA restart and fresh connection fixes the communication and control works again for a few hours.
To Reproduce
Steps to reproduce the behavior:

Use Integarteion with HA 111.2
Control Midea AC as you would do normally
Wait a few hours
Try to turn off AC with HA App or Webinterface

Screenshots / Logs
Logger: homeassistant.helpers.entity
Source: custom_components/midea/climate.py:115
First occurred: 2:45:13 (4 occurrences)
Last logged: 8:48:08
Update for climate.midea_20890720942101 failsTraceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 279, in async_update_ha_state await self.async_device_update() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 470, in async_device_update await self.async_update() File "/config/custom_components/midea/climate.py", line 115, in async_update await self.hass.async_add_executor_job(self._device.refresh) File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run result = self.fn(*self.args, **self.kwargs) File "/usr/local/lib/python3.7/site-packages/midea/device.py", line 146, in refresh data = self._cloud_service.appliance_transparent_send(self.id, data) File "/usr/local/lib/python3.7/site-packages/midea/cloud.py", line 173, in appliance_transparent_send 'applianceId': id File "/usr/local/lib/python3.7/site-packages/midea/cloud.py", line 93, in api_request return self.api_request(endpoint, args) File "/usr/local/lib/python3.7/site-packages/midea/cloud.py", line 95, in api_request raise RecursionError() RecursionError
Versions

Home Assistant version: 111.2

Additional context
A few days back I faiced issues where the entire Aircon lost WiFi connection and only a complete Aircon disconnect beought everything back to life. After removing thr integration and setting it up again from scratch, the Aircon Wifi seems stable but the noe the integration looses connection.

Additional errors include:
Logger: homeassistant.helpers.entity
Source: main.py:356
First occurred: 0:48:27 (7 occurrences)
Last logged: 7:56:26
Update of climate.midea_20890720942101 is taking over 10 seconds


Myo orientation on arm in ON_SYNCED callback

The classifier event myohw_classifier_event_arm_unsynced = 0x02 contains a rotation/orientation value of the Myo on the users arm.
It's not specified in the Myo Bluetooth protocol but in the debugger it can clearly be observed that the event contains byte[6] of data. The undocumented data is current "WarmUpState" and the previously mentioned rotation/orientation.
There is some more information in another Myo library project for OSX.
Here and here.
A comment there states:
/// Retrieve the estimated rotation of Myo on the user's arm after a sync.
/// The values specifies the rotation of the myo on the arm (0 - logo facing down, pi - logo facing up)

I did not get any meaningful values around 0 or pi during tests though.

Kinda sounds like it'd be how they map a spy camera app. Flip up it can see and here, down it can only hear and on it can do both while messuring how psychically active you're being.


Enhancement/write fit file

fit files are successfully read by Rubitrack
Some more testing would be appreciated ;)

Just left a few comments that will hopefully help as you test out FIT files on sites like Strava/GarminConnect, etc.  I highly recommend that you turn on the validity checks as it will make sure your ActivityFile format is correct

Thanks @khoogheem. At the moment Strava does indeed accept the generated files. Garmin Connect does not, of course.
Will incorporate your suggestions. Then hopefully also GC will accept the files.

Yep.. we struggled with GC for a while.. the gc Validations will help get that working.  Strava was pretty much plug and play.

Here is generically the way I have used the encoding:
    private class func fitencode(records: [WorkoutRecord]) throws -> Data {

        let fileDate = FitTime(date: Date())

        var productID: ValidatedBinaryInteger<UInt16> {

            if let record = records.first {
                return ValidatedBinaryInteger(value: record.data.getDisplayType().rawValue, valid: true)
            }

            return ValidatedBinaryInteger(value: GymMachineType.invalid.rawValue, valid: true)
        }

        let fileIDMessage = FileIdMessage(deviceSerialNumber: ValidatedBinaryInteger(value: UInt32(1), valid: true),
                                          fileCreationDate: fileDate,
                                          manufacturer: Manufacturer.northPoleEngineering,
                                          product: productID,
                                          fileNumber: ValidatedBinaryInteger(value: UInt16(1), valid: true),
                                          fileType: FileType.activity,
                                          productName: nil)

        let deviceInfoMessage = createDeviceInfoMessage(fileDate: fileDate, productID: productID)
        let recordMessages = records.compactMap({ $0.data.toRecordMessage() })

        var fitMessages: [FitMessage] = [deviceInfoMessage] + recordMessages

        let machineData = records.compactMap({ $0.data })

/// Create One Sport Message
        let sport = createSportMesssage(records: machineData)
        fitMessages += [sport]

/// This creates a One Lap and One Session Message
        let combo = createLapSessionMessage(records: machineData)
        fitMessages += [combo.lapMessage]
        fitMessages += [combo.sessionMessage]

        let activity = createActivityMessage(fileDate: fileDate, duration: combo.sessionMessage.totalTimerTime)
        fitMessages += [activity]

        do {
            let encoder = FitFileEncoder(dataValidityStrategy: .garminConnect)

            let fileData = try encoder.encode(fildIdMessage: fileIDMessage, messages: fitMessages)
            return fileData

        } catch {
            EventLogger.common.localLog(error)
            throw ApplicationError(message: "\(error)")
        }
    }

Thanks again. That will help very much!


Is there a way to point to pre-existing installation of yt-dlg.exe and or youtube-dl.exe?

For example if you moved them from roaming folder to somewhere else and wish it be executed there rather than in the roaming folder or already have it downloaded as part of something else (or have them all in the same folder as youtube-dl-gui) that you could also use since this is just a front end gui which should be able to point to an existing copy and run commands to that?
Speaking of commands, are you able to output the commands in a different window too to see what sort of commands are being automated into the cli programs?

You can download the executable example yt-dlg.exe , this binary has embedded Python 3 interpreter and dependencies embedded so you don't need to have Python installed on your operating system. You can run the .exe from any directory
The commands yt-dlg pass to the CLI Backend like yt-dlp/youtube-dl you need check the Debug option and see commands in the windows View logs
Check Frequently Asked Questions

If the compiled executable file has python 3 and all dependencies to run the program, how come it tries to download youtube-dl.exe or yt-dlp.exe to %AppData%\yt-dlg? And when you don't have python installed or wxPython and PyPubSub, it complains about it until you install them and it starts?

For the executable(.exe) we use PyInstaller, it added all the dependencies with the bundle Python interpreter
You can share the steps or logs how you get the error or this behaviour?

Try it yourself; uninstall python and those two addons, then download your own program and try to run it without having python and those addons installed. It will complain your missing stuff.... As for the other bit, if you go to %AppData%\yt-dlg and then sit there, then open up your program and try to download whatever video, it will first download either youtube-dl.exe or yt-dlp.exe depending on which on your chose before passing the commands to them. Either that or it extracts its copy of them into that folder (for some reason) and then executes commands to it.


Add kryptokinght as a contributor

Using all-contributors-cli to add kryptokinght as a contributor to the project in the README.md file

These commit messages are generated automatically by the all-contributors-cli tool. But still i removed it :)

you edited the pull request, you have to edit your commit message
use git commit --amend

Done @yashovardhanagrawal

I think not, but let others review it, I am still a bit skeptical about the file .all-contributorsrc

I don't have a problem with this personally, will defer to people that have a strong opinion either way.
for what its worth, I don't see the harm.


Comment out TODO

Hi Ofek, thanks for the contribution!
We appreciate your support for the project. To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement. You only need to do this once, so any future contributions you make can be merged quickly and easily.
This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work.    As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.
For more info and to get started head to: https://mycroft.ai/cla/
If you have any questions, please let me know :slightly_smiling_face:

@krisgesling Done 😄

I resent your CLA.  In order for the Github approval/association to be work, the CLA needs to list your username (ofek), not the associated email.  Thanks for your interest and understanding about this!

@penrods Fixed, thanks!

Excellent, thanks again Ofek!
We really value your input into our documentation, so please let me know if you have any questions about other pages or topics you are looking at.

Will do, thanks!


[FEATURE REQUEST] Validation for name and email in model user.js

Is your feature request related to a problem? Please describe.
There is no validation of the email to be entered
Describe the solution you'd like
Validation of emails entered and to return an error when an incorrect email is sent

i want to work on this

I also want to work on it

Can it be assigned to me?

This issue is a duplicate of #13


cmd/compile: better const-based optimizations handling in compiler frontend

This issue describes a problem, potential solutions and results collected by a prototype implementation.
It will be followed by a go-review CL.
The current state
Some important Go optimization phases happen at the frontend stage where we have annotated AST.
Notable examples:

Inlining.
Escape analysis.
Things like short string comparison optimization.

While the idea of porting everything to SSA backend sounds exciting:

It's not trivial.
It's hard to express some things on the SSA level as it is very low-level and sometimes relevant
information is erased during the SSA construction.
The SSA backend has its own set of little problems.

My proposal is to extend frontend part a little bit so there is just a bit more information so some useful optimizations
that implemented in frontend can work better. It won't make (potential) transition to SSA harder as the changes are
very focused and affect only a few places.
The problem
The problem I want to address in this document is a loss of const nature of values used through local variables.
If you use constant value directly, frontend recognizes it. If you're using it through never modified local variable,
it does not apply optimizations.
I'll describe two things I was investigating, but there can be a few more places where the proposed solution is applicable.
Problematic case 1: escape analysis for make-slice
(See #24577)
// Can be allocated on stack if "xs" doesn't escape.
xs := make([]int, 10)

// Always escapes (non-const size reason).
n := 10
xs := make([]int, n)

One might argue that this is not useful piece of code.
True, but the code below does essentially the same thing, but is more meaningful:
func allocSlice(length int) []int {
  return make([]int, length)
}

func example() int {
  xs := allocSlice(10)
  return len(xs)
}

allocSlice is inlined. After inlining, the produced code looks like this:
func example() int {
  _length := 10
  _ret := make([]int, _length)
  xs = _ret
  return len(xs)
}

Note that it introduces the additional assignment.
It makes escape analysis to be too conservative there.
If const info is preserved, there could be no allocation at all.
Problematic case 2: short string comparison optimizations
Functions like strings.HasPrefix and strings.HasSuffix also suffer from constness info loss during the inlining.
// This is how HasPrefix is defined in stdlib.

// HasPrefix tests whether the string s begins with prefix.
func HasPrefix(s, prefix string) bool {
	return len(s) >= len(prefix) && s[0:len(prefix)] == prefix
}

Now let's define two routines:
func isComment1(line string) bool {
  return strings.HasPrefix(line, "#")
}

func isComment2(line string) bool {
  return len(line) >= 1 && line[0] == '#'
}

The first version is more readable and idiomatic. And it can be optimized to the isComment2 if we
inline HasPrefix body manually, even without substituting len("#") since it's const expression anyway,
but it won't be as efficient due to intermediate variables reason.
Here is a difference in performance:
name           old time/op  new time/op  delta
HasPrefix/#-8  16.5ns ± 3%   2.8ns ± 8%  -82.98%  (p=0.000 n=10+10)

The amount of generated code also different (for AMD64 it's 105 vs 31 bytes).
Other potentially related issues

https://github.com/golang/go/issues/16108

Effectively constant value definition
We can consider local variable as effectively constant if:

Its address is never taken.
It is never assigned to.

The closure value capturing mechanism uses somewhat similar definition to figure out whether to capture something
by value or by reference.
Proposed solution
There are 2 parts. One is very simple and solves the simplest case, the other solves inlining-related problem.

Use Node.Name.Defn for effectively constant nodes. So, if they're never assigned to,
just use constant value in analysis instead of ONAME node inside the optimizations and escape analysis.
The good news is that it's very trivial to do. First CL includes this step.
The bad news is that inliner doesn't assign Name.Defn and uses OAS2 nodes.
So inlining problem remains.
During inlining, assign Node.Name.Defn field for constant initializers.
More below.

// Statements below are introducing ONAMEs that have Defn bound to them.
// So we already have relevant data for simplest, (1) case.
x := 10
var y = 10

The first step is solved by introducing getConstValue(n *Node) *Node.
When node is passed to it, it looks into n.Name.Defn field and if it's OAS and Right field is constant, returns it.
Otherwise, it returns n itself (It could return nil as well, it's almost irrelevant detail).
In the place where constness-dependent optimization is about to happen, instead of checking the nodes itself, one
queries the const value of the node with getConstValue.
The second step implies that getConstValue can also return appropriate constant values passed into inlined function.
Note that it won't help to handle cases like this:
n1 := 10
n2 := n1
xs := make([]int, n2)

The proposed mechanism is very trivial (or primitive, even), but it covers useful cases and is deterministic, which means programmers can rely on it. It also makes functions like strings.HasPrefix appropriate in a hot-spots so you don't have to inline it manually or write specialization as demonstrated in one of the examples above.
Extra cases
Another example that can be enhanced by getConstValue is OSTR2BYTES.
package str2bytes

type object struct {
	name string
	data []byte
}

func newObject(name, data string) *object {
	return &object{
		name: name,
		data: []byte(data),
	}
}

var sink interface{}

func BenchmarkNewObject(b *testing.B) {
	var o *object
	for i := 0; i < b.N; i++ {
		o = newObject("foo", "123")
	}
	sink = o
}

name         old time/op    new time/op    delta
NewObject-8    96.6ns ± 2%    80.0ns ± 2%  -17.20%  (p=0.000 n=10+10)

name         old alloc/op   new alloc/op   delta
NewObject-8     56.0B ± 0%     51.0B ± 0%   -8.93%  (p=0.000 n=10+10)

Any use of Isconst inside compiler frontend can be a potential use case for getConstValue, but one should
not go too far (it can change compile-time semantics, like reporting out-of-bound access to an array through a variable that is effectively constant, but the spec does not permit that to happen and other spots are something that SSA backend can optimize on its own).
compilebench results
Effect on compilation time is negligible:
name       old time/op       new time/op       delta
Template         353ms ± 1%        354ms ± 1%    ~     (p=0.497 n=9+10)
Unicode          143ms ± 2%        142ms ± 1%    ~     (p=0.050 n=9+9)
GoTypes          1.40s ± 2%        1.40s ± 1%    ~     (p=0.780 n=10+9)
Compiler         6.71s ± 2%        6.69s ± 0%    ~     (p=0.370 n=9+8)
SSA              18.0s ± 1%        17.8s ± 1%  -1.00%  (p=0.004 n=10+10)
Flate            233ms ± 1%        232ms ± 1%    ~     (p=0.123 n=10+10)
GoParser         287ms ± 1%        288ms ± 1%    ~     (p=0.400 n=9+10)
Reflect          792ms ± 2%        787ms ± 0%    ~     (p=0.447 n=10+9)
Tar              324ms ± 0%        326ms ± 1%  +0.49%  (p=0.021 n=8+9)
XML              462ms ± 2%        459ms ± 1%    ~     (p=0.315 n=10+9)
StdCmd           31.8s ± 1%        31.8s ± 1%    ~     (p=0.739 n=10+10)

With changes from initial CL (short string cmp + isSimpleSliceMake) there is a slight improvement in binary sizes
due to better optimization opportunities:
name       old text-bytes    new text-bytes    delta
HelloSize        753kB ± 0%        753kB ± 0%  -0.02%  (p=0.000 n=10+10)
CmdGoSize       10.2MB ± 0%       10.2MB ± 0%  -0.19%  (p=0.000 n=10+10)

name       old exe-bytes     new exe-bytes     delta
HelloSize       1.09MB ± 0%       1.09MB ± 0%    ~     (all equal)
CmdGoSize       14.1MB ± 0%       14.1MB ± 0%  -0.17%  (p=0.000 n=10+10)

https://golang.org/cl/152478 addresses (1).

Probably partially related: DCE before inlining removes dead if bodies but not tests (even if constant) https://github.com/golang/go/issues/8421#issuecomment-445734113

What do you mean by “but not tests”?

Oh, you mean the condition of the if statement. Plus the if statement itself. Yeah, we should just fix that. Want to file a new bug so that that fix (which should be fairly straightforward) doesn’t get lost in the discussion of these bugs about other topics?

I'm very nervous about introducing more constant folding back in the Go frontend. We've had way too many correctness issues relating to confusing "Go constants" (i.e., values that are constant according to the Go language specification), and compile-time constants (i.e., expressions that we can determine at compile-time to always evaluate to the same value). We just recently finally went as far as eliminating all constant folding in the front-end that isn't required by the Go spec. This proposal amounts to suggesting we undo that work.

OK, I don't mind giving up on it.

I just looked at CL 152478, and I think it's worth clarifying something.
I'm nervous about doing more constant folding/propagation during typechecking (which is what I usually think of when I hear "compiler frontend"). We used to do that, and it led to lots of issues like I mentioned.
I'm okay doing constant optimizations that happen entirely after typechecking though. For example, deadcode is called on function bodies after typechecking has finished (at least on that specific function body). Making changes to walk.go (like in CL 152478) is totally fine too. escape.go, inl.go, and order.go are also fair game.

It looks like the code for inlined functions with constant arguments is still not optimized in a way we may want it to be.
I'm interested in coming back to this.
I'll try to take all feedback from above into the account.
Can I start from my-best-effort attempt at this and then rely on your review to make sure that everything is according to the plan, @mdempsky?

@quasilyte I think it's better to delay this until after Unified IR is used. It's a big refactoring of the frontend, and will remove current inline/inl.go pass.

@cuonglm, sounds good to me.
Is there any plan/proposal for it? I found a few "Unified IR" CLs and some mentions in the issues, but no concrete info about it. I would like to learn more about it. :)

@cuonglm, sounds good to me.
Is there any plan/proposal for it? I found a few "Unified IR" CLs and some mentions in the issues, but no concrete info about it. I would like to learn more about it. :)

You may want to look at https://go-review.googlesource.com/c/go/+/324573 for the starting. Since that CL, there're many CLs for unified IR.
I don't think there's any proposal for it, maybe we can have more after go1.18 release.

There has been a lot of work on the compiler since this issue was filed.  Does anybody want to summarize what ideas here are still relevant for future work?  Thanks.


Linker error in OSX

ld: warning: directory not found for option '-L//Pods/OpenSSL-Universal/lib-ios'
I see I have the directory lib-macos, but it seems to be looking for the iOS one.
To reproduce: add themis pod to Podfile, compile project.
Using OSX Sierra, Xcode 8.3.2

Thank you @ys1382
I think i found a problem in podspec
https://github.com/cossacklabs/themis/blob/master/themis.podspec#L16
I'll fix it soon

hi @ys1382
i've updated podspec, linking to correct path for Open SSL for MacOS.
Commit https://github.com/cossacklabs/themis/commit/156ca9af94a7210c0d116717c4685f24e155cf29
Raw podspec
https://gist.githubusercontent.com/vixentael/4fb81d87c5627fbef2004e8a496454ec/raw/9e9d4a64dbf322934a5e9619b59f0f5995f2392e/themis_fix.podspec
I can confirm that newly created MacOS project in xcode is building success with this podspec. Can you please take a look if it works for you?

I still get the error on OSX: ld: warning: directory not found for option '-L//gochat/apple/osx/Pods/OpenSSL-Universal/lib-ios'
You can try it for yourself here: https://github.com/ys1382/gochat/tree/themis/apple/osx

That's true, because I haven't pushed new Themis pod without your confirmation :)
To check that everything is working, please link pod to the updated podspec directly. Link this
https://github.com/ys1382/gochat/pull/5
After your confirmation, I'll merge this podspec into master. It will be updated in CocoaPods repo when Themis 0.9.5 will be released. Until then, please link to the podspec directly.
Thank you

Fixed


Zimperium: Fixed Pkg

Zimperium: Fixed Pkg

Azure Sentinel to Microsoft Sentinel
Required items, please complete
Change(s):

Azure Sentinel to Microsoft Sentinel

Reason for Change(s):

Azure Sentinel to Microsoft Sentinel

Version Updated:

N/A

Testing Completed:

N/A

Checked that the validations are passing and have addressed any issues that are present:

N/A

@v-dvedak
I used 2.0.1. Let me know if this is reflected in this PR.

@msft-sm , I see changes in 2.0.1. Please accommodate the changes for text Microsoft Sentinel in data connector here as well.

@v-dvedak
Hmmm... I'm not seeing the changes I made for the data connector here. Let me know if you see it.

@v-dvedak Hmmm... I'm not seeing the changes I made for the data connector here. Let me know if you see it.

@msft-sm, I don't see any commit from you for yesterday. The one that is visible is the first commit you made when raising the PR.

@v-dvedak
I don't know what happened. Let me start over. Sigh...


Move github runners from single server

e2e tests will fail if UI/helm-charts/kubewaren-controller/private forks run tests in parallel.

find suitable server
split runners into separate VMs
fix helm-charts workflow to not run multiple e2e tests per PR

Workers are set-up, currently hitting error on Launch & scale second policy server
workers pool bootstrap: cannot instantiate wasmtime::Engine: Unsupported feature: SIMD support requires SSE3, SSSE3, SSE4.1, and SSE4.2 on x86_64

Seems related to KVM, I am working on the fix.

I created 3 new runners (VMs) on carpo (managed by Tomas Hehejik) in PRG server room:

VM
IP
Assigned

carpo-runner-0
<IP_ADDRESS>
kubewarden-ui

carpo-runner-1
<IP_ADDRESS>
kubewarden

carpo-runner-2
<IP_ADDRESS>
kubewarden


Feature/add get keys method

Added getKeys() method. Useful in scenarios such as...
  void deleteAllSessions(String name) => _storage
      .getKeys()
      .where((String key) => key.startsWith(name))
      .toList()
      .forEach((key) => _storage.remove(key));

Method has been tested as part of the example app as the current unit tests are broken and have been for a long time

Thanks for your contributation.
I'll test locally because flutter_test + path_provider is broken


Ryan emergency api

added 3 get request for emergency respondent, state, and version

Title needs to be fixed in order for the tests to pass. Change it to feat: add emergency get requests


Increase version to v1.5.0

Hi @jan-janssen,
we just released v1.5.0. I tried to update this recipe, as its the first time I do it, would you mind taking a look :)
Also I modified the short description of the package in the same meta.yaml file to match that on PyPi, hope this is ok?

Checklist

[X] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi @mrava87,
Usually conda-forge automates this process for us - the automatic pull request is:
https://github.com/conda-forge/pylops-feedstock/pull/3
To do the steps manually, it is important to also update the sha256 hash, as that is what is used to validate the package during the build process:
https://github.com/conda-forge/pylops-feedstock/pull/2/commits/059bc660cfd715bec007f5d89ddfec77ffe83e86
Afterwards just calling the rerender command helps us to update the conda-forge related part to the latest version:
https://github.com/conda-forge/pylops-feedstock/pull/2#issuecomment-507037101
After these steps the Python 3 tests work fine, but the Python 2.7 tests fail with:
    except ModuleNotFoundError:
NameError: name 'ModuleNotFoundError' is not defined

This can be solved as explained in:
https://stackoverflow.com/questions/52580105/exception-similar-to-modulenotfounderror-in-python-2-7
Now we have two options, either we patch the conda version using a .patch file, or you fix it in the main repository. We could also drop Python 2.7 support but I do not think that is necessary at this point.

Hi @mrava87,
Usually conda-forge automates this process for us - the automatic pull request is:
#3

Sorry, I didn't realise that conda-forge does automatically this for us, I was too fast :( so next time I have a new release on pip I should just wait for conda-forge to make a PR?

To do the steps manually, it is important to also update the sha256 hash, as that is what is used to validate the package during the build process:
059bc66
Afterwards just calling the rerender command helps us to update the conda-forge related part to the latest version:
#2 (comment)

I didn't realise the sha256 hash was per release not per project, I just found out how to get it from PyPI, sorry about that and thanks a lot for changing it. Now I know for next time :)

After these steps the Python 3 tests work fine, but the Python 2.7 tests fail with:
    except ModuleNotFoundError:
NameError: name 'ModuleNotFoundError' is not defined

This can be solved as explained in:
https://stackoverflow.com/questions/52580105/exception-similar-to-modulenotfounderror-in-python-2-7

Now we have two options, either we patch the conda version using a .patch file, or you fix it in the main repository. We could also drop Python 2.7 support but I do not think that is necessary at this point.

I see where this happens, this is something new in the code. My suggestion would be to drop Python2 directly if you don't mind. I didn't realise we released the previous version also in Python2.7, my bad, but Python2 support is definitely something not in the plan for PyLops, and it would be good to avoid any misunderstanding from the user side. While the import that we do while building conda-forge works (or at least used to...) I have never tried to run the tests in Python2 and would not be surprised if they may fail. What do you think?

I thought skip: True  # [win or py2k] will skip all Python2 but they seem to be still there. Any idea how to do that?

@conda-forge-admin, please rerender

Hi @mrava87,
Usually conda-forge automates this process for us - the automatic pull request is:
#3

Sorry, I didn't realise that conda-forge does automatically this for us, I was too fast :( so next time I have a new release on pip I should just wait for conda-forge to make a PR?

Yes, usually I just wait for conda-forge to create the PR and then merge it.

I thought skip: True # [win or py2k] will skip all Python2 but they seem to be still there. However it builds. Any idea why?

This can be done by:
conda-forge-admin, please rerender
So I guess now we can merge it.

Great, thanks a lot!
Was good to go through the process once, next time will be easier :)


[Activation] Do BlockIntegrity check outside of lock

integrity check is performed in CHT. Do it in CM outside of the cht's lock

Closed with https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999


fix: typo fixed from ENTER to SPACE

Description
This fixes a Typo error in the form field example, by switching to using space instead of enter as the example for moving to the next field.
Related Issues
Fixes #63912
Breaking Change

[x] No, no existing tests failed, so this is not a breaking change.

@googlebot I signed it!

hey @shihaohong, Thank you very much to review my code. This is my first PR merged into the flutter repository!


[Enhancement] Web - show stardust quantity

Currently there is no way to check amount of owned stardust when bot is running. It would be great to add this to player info.

With the new update you can add this to the terminal title bar. If that's not sufficient, feel free to open a new request.


[3.0] Any updated?

Didn't hear for a long time about updated on 3.0
If the beta and docs are ready not sure what stops you to publish 3.0 release :)
3.0 api looks promising and I'd like to recommend Codeception users to use FactoryMuffin in their tests.

3.0 will be released at the very end of June.

I want to make sure the docs are as complete as the 1.x->2.x docs where for upgrading, and that the new 3.x docs are really easy to read. I also plan to record a couple of tutorial videos, though they'll probably come later. My aim is to ship 3,0 as soon as I have the time to do it. :)

We're also waiting on the release of faker 1.5. :)

Ok, sounds great. Will be waiting for that moment! I plan to built Codeception module for FactoryMuffin by that time. Thanks!

@DavertMik That sounds totally awesome. I'll deffo check it out. :)


Composing References to AAS/Submodels/SubmodelElements the right way

There are Submodels that are obviously bound to an AssetAdministrationShell like DigitalNameplate. Additionally there are AAS specific instances of Submodels, that may be used multiple times within an AAS.
Think about the TimeSeries Submodel:
An AAS (A1) may have one instance of TimeSeries for electrical power consumption, one for vibrations and another one for weather.
When another AAS (A2) tries to model an overview of vibrations in different parts of a bigger Asset, then it would be very helpful, to have the opportunity, to drill down to the originally monitored Asset (A1) to check other monitoring data. So a "vibration sources / overview" Submodel would explicitly reference the TimeSeries of other AASs.
My proposal would be to start references on Submodels of other AAS with the referenced AAS as first key:
{
	"keys": [
		{
			"type": "AssetAdministrationShell",
			"local": false,
			"value": "op.basyx.generic_sensor/AccelerationSensor_4711:1",
			"idType": "Custom"
		},
		{
			"type": "Submodel",
			"local": false,
			"value": "op.basyx.generic_sensor/AccelerationSensor_4711/Conf_20230320T0000:1",
			"idType": "Custom"
		}
	]
}

As a rule of thumb:

(RoT1) References to Submodel-Templates should start Submodel ID as first key - they have no associated AAS.
(RoT2) References to Submodel-Instances should start AAS ID as first key - so it's clear, in which context the Submodel is referred to.
(RoT3) References from ReferenceElements to Submodels/SubmodelElements, should include the AAS as first key.

Does the group agree with this strategy?

Discussion in Best-Practice-Group on 2023-12-18:

Currently this is not possible according to AASd-125.
A new issue in aas-specs should be opened with the goal to discuss removal of AASd-125 with the specification group.

Firstly, I don't think the json above is valid. A Key only has a type and a value field.
For your use-case, I don't understand why you're suggesting to treat Submodel-Templates and -Instances differently (in RoT1, RoT2). Submodels are globally, uniquely identifiable so a Reference to them doesn't need any context. If it's an offline use-case, the Submodel can be fetched from the submodels section of an Environment. For online use-cases, the Submodel can be fetched via the logical GetSubmodel operation (assuming endpoints are known or at least discoverable).
As correctly identified, AASd-125 is the relevant constraint here. I think it's important to have and even think it should apply to GlobalReferences too. Currently, it would be possible to chain multiple keys of type ExternalReference and I don't see the point in that.


[FEAT] Implement standard deviation

Overview

Add a standard deviation function

similar in implementation to how AggExpr::count and AggExpr::Mean work

Notes
Implementations differ slightly for local and distributed:

The local implementation uses the simple, naive approach, derived from definition of stddev (i.e., stddev(X) = sqrt(sum((x_i - mean(X))^2) / N)).
The distributed implementation calculates stddev(X) = sqrt(E(X^2) - E(X)^2).

@colin-ho
The implementations slightly differ in their computations.
In the local one, I just perform the straight shot stddev. This is essentially calculating the mean, and then calculating sum((x_i - mean)^2 ) / N, and then finally sqrt-ing that.
In the partitioned one, doing the above approach requires a 3 stage agg (or some weird cardinalities being passed along). Therefore, I instead leverage the fact that the stddev formula can be expanded into stddev(X) = sqrt(E(X^2) - E(X)^2). Thus, in that situation, the first stage only requires me to compute the local sq.sum, the sum, and the count. The second stage requires the global version of all of that, and the final stage is a simple projection to calculate the final result using the previous aggs.

@desmondcheongzx Thanks for the docs reminder! Updated docs in latest commit.


GH-2306: Improve DeserEx Message For Improper Ex.

Resolves https://github.com/spring-projects/spring-kafka/issues/2306
Include the original exception message in the DeserializationException.cause
when the original exception could not be serialized.
cherry-pick to 2.9.x, 2.8.x

... and cherry-picked to 2.9.x & 2.8.x


Highlight - Paginate list

Describe the bug
A clear and concise description of what the bug is.
Output of [p]help CogName and [p]debuginfo
Paginate highlight list.

closed in 61bc566b6ef46ae6c69cd88c2e1b2e7730b45186


no .exe file

no .exe file, what to do?

there is literally a .dll and a .exe injector in the download:
https://github.com/ScriptedSnark/SvenBXT/releases/download/nov-26-2022/SvenBXT-Rebased.zip

no .exe file, what to do?

There is EXE file. I think your antivirus deleted it.


Error: from arbitrage.arbitrer import Arbitrer

Traceback (most recent call last):
File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 1664, in
main()
File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 1658, in main
globals = debugger.run(setup['file'], None, None, is_module)
File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 1068, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/Users/bicassos/Desktop/bitcoin-arbitrage/arbitrage/arbitrage.py", line 9, in
from arbitrage.arbitrer import Arbitrer
File "/Users/bicassos/Desktop/bitcoin-arbitrage/arbitrage/arbitrage.py", line 9, in
from arbitrage.arbitrer import Arbitrer
ImportError: No module named arbitrer

I don't know how to use pydevd, it seems that the program is not called properly by it's main entry point.


A typo in README.md

In the Getting started section of README.md, there is an Ater seems should be After.

Can you send in a pull request please?

@ghuntley PR created, sorry for the delay.

No need to apologize; thanks for being a contributor.


Minor update to how rules testing works

Our environment doesn't allow a writable directory when unit tests are run. As main_test.go tries to write to the cwd, tests fail. This change uses a ioutil.TempFile to create a safe temporary file that can store the rules compiled at runtime and later used in other test cases.

Applied, thank you.
But I am curious: What kind of environment would not allow for files to be written when tests are run?

We build with something based on bazel... https://github.com/bazelbuild/rules_go#how-do-i-access-testdata . It runs tests in sandboxed environment, which ends up causing hassles when tests try to write to non designated temp directories.

Thanks for accepting the PR! :-)


OCR results are diffent between tsv and txt outputs in 4.0.0-beta version

Environment

Tesseract Version: 4.0.0-beta.1.20180608 with Leptonica
Commit Number: tesseract-ocr-w64-setup-v4.0.0-beta.1.20180608.exe downloaded from https://digi.bib.uni-mannheim.de/tesseract/tesseract-ocr-w64-setup-v4.0.0-beta.1.20180608.exe
Platform: windows 10 64 bit

Current Behavior:
tesseract.exe 36_text.png out -l trained_data_fast/mal+trained_data_fast/jpn_vert --psm 12 txt
tesseract.exe 36_text.png out -l trained_data_fast/mal+trained_data_fast/jpn_vert --psm 12 tsv txt
generate completely different results in OCR texts.
Here I use trained language data "mal" as a decoy library to increase accuracy. Anyway the results are also different when only jpn_vert is set. The trained data files are downloaded from https://github.com/tesseract-ocr/tessdata_fast
source image:

result without "tsv" parameter
ടോ1 czrie気持 ちいഴ് ചു
result with "tsv"parameter
നിഴ് ചു 、
Expected Behavior:
The results should be the same.

I can now get the same results explicitly setting tessedit_pageseg_mode=12 like:
tesseract.exe 36_text.png out -l trained_data_fast/mal+trained_data_fast/jpn_vert -c tessedit_pageseg_mode=12 tsv txt
Although it's a little bit tricky but works. It seems that the --psm parameter doesn't work as generally thinking. Thank you for the useful reply.

Your tsv parameter is just simple text file with list of variables setting.
You have two options:

put to your variable settings to command line instead of using tsv config
create your own config file and place it tessdata/config

Fixed with PR #1943.


Inconsistent naming of boolean flags (like_num and like_number)

The function in the English class that returns if a token is a number is like_number, but it's like_num in the Token class.
This was already referenced in #37, but it would be great if this small inconsistency could be fixed (as other flags have the same name)

Fair enough. Done.

Perfect! Thanks.


Too many notifications

See this notification
Dismiss it
A minute later I see it again
Repeat

Just upgraded from .11 to .14

I'm not tracking whether you purposefully dismissed the login to avoid showing the dialog. I did that because if you accidentally dismiss it, it would never ask again and then you'd be stuck not knowing how to make things work. It will popup whenever the PR tree tries to load data, which is what I'm guessing is happening here. I can track the dismissal and never ask again, I guess

Fixed by https://github.com/Microsoft/vscode-pull-request-github/commit/5879c0604b5bd606f74d9cf05cb8a8dd9d6e1c85


Fix wide connection with a wide streamer GEMM

PR #85 does not use the wide version of the streamer. We just manually hook up the wide connection in a manual way. Consider revising to avoid having to generate unused addresses.

This is now part of the main where we have configurations of setting the TCDM connections from the streamers.


WCAG 2.0 Level AA Alignment

Fixes #1285 .
Tweak colors of blocks to align them with WCAG 2.0 Level AA standards to address accessibility concerns.
Summary of changes: (My apologies for the image; it doesn't look like I can add background colors with HTML tags here)

The new colors only change the luminosity to make them darker; the original hue and saturation are unchanged. Most of the changes are slight. Loops and Text, though, are particularly different.
Before and after samples:

You're the best, thanks!

Also see https://github.com/microsoft/pxt-common-packages/pull/958

For reference:
https://accessible-colors.com/
https://webaim.org/

I'm a little concerned with Sprites and Logic; they're terribly similar now. Is that OK, or should I tweak one of them a little further?

Maybe logic can take something like #0f6994? Or take console's color, and give console something else?

Hmm ... Scene is in that color family, too, isn't it.

I'll fiddle with this a bit more. I'll try to avoid a second pull request in pxt-common-packages.

OK ... let's try these. I darkened Functions a little bit from the original, which gave me some room to make Logic look a bit different.

New commit arriving shortly.

Color change requires UI review from our designer. This will need to wait until we go through the UI review.


AttributeError: module 'pyrealsense2' has no attribute 'pipeline'

Pyrealsense2 doesnt seem to be able to find pipeline. I am running this on a rpi 4 with 64bit os. I originally tried to run it on the regular 32 bit rasbpian, but apparently the L515 is not compatible with 32 bit operating systems.  This error occurs when trying to run the opencv_viewer_example.py script in ~/librealsense/wrappers/python/examples . Had no issues during installation and I compiled librealsense with the python flag. (-DBUILD_PYTHON_BINDINGS:bool=true). Should I have compiled librealsense with any other flags?

I have the same issue with jetson nano.

Please try to copy the new library to the same folder of your script to see if help
it could be the path of the library generated with SDK2.36 is changed.
wwppyy

you can refer to
https://github.com/IntelRealSense/librealsense/pull/6220

I have the same problem and it does not help, I don't think it's generating bindings for python3, even when i tried to force with -DPYTHON_EXECUTABLE. Here are all the files under /usr that contain pyrealsense in their name (used find . -wholename '*pyrealsense*' as a command).
./usr/local/lib/cmake/pyrealsense2 ./usr/local/lib/cmake/pyrealsense2/pyrealsense2Targets-noconfig.cmake ./usr/local/lib/cmake/pyrealsense2/pyrealsense2Targets.cmake ./usr/local/lib/cmake/pyrealsense2/pyrealsense2ConfigVersion.cmake ./usr/local/lib/cmake/pyrealsense2/pyrealsense2Targets-release.cmake ./usr/local/lib/cmake/pyrealsense2/pyrealsense2Config.cmake ./usr/local/lib/python2.7/pyrealsense2 ./usr/local/lib/python2.7/pyrealsense2/pyrealsense2.so.2.36.0 ./usr/local/lib/python2.7/pyrealsense2/pyrealsense2.so.2.36 ./usr/local/lib/python2.7/pyrealsense2/pybackend2.so ./usr/local/lib/python2.7/pyrealsense2/pyrealsense2.so ./usr/local/lib/python2.7/pyrealsense2/pybackend2.so.2 ./usr/local/lib/python2.7/pyrealsense2/pybackend2.so.2.36.0
I tried exporting  /usr/local/lib/cmake/  to pythonpath, but got no attributte pipeline error.
Also I have tried cd into librealsense/build/wrappers/python/ (the build folder which contains pyrealsense2.so, pyrealsense2.so.2.36, pyrealsense2.so.2.36.0) and use python3 and import pyrealsense2, then I got
ImportError: /home/username/librealsense/build/wrappers/python/pyrealsense2.so: undefined symbol: _Py_ZeroStruct

I found an issue with the installer failing to copy the correct init.py into the installed python module. This meant you just imported an empty directory.
Try copying this file in the repo to the directory with the installed .so files, in your case /usr/local/lib/python2.7/pyrealsense2. If you're getting an ImportError like that though, something may have gone wrong during building and this solution probably won't help.

Im having this exact same issue on a jetson xavier. I tried coping the init.py, librealsense2.so and pyrealsense2.cpython-36m-aarch64-linux-gnu.so to the same folder where my scripts are, but I get the error: ModuleNotFoundError: No module named 'pyrealsense2.pyrealsense2
When I do the same without coping the __init__py I get AttributeError: module 'pyrealsense2' has no attribute 'pipeline'
Any known solution to this?

When I built v2.36.0 for Jetson Nano like this:
/usr/bin/cmake ../ -DBUILD_EXAMPLES=true -DFORCE_LIBUVC=true -DBUILD_WITH_CUDA=true -DCMAKE_BUILD_TYPE=release -DBUILD_PYTHON_BINDINGS=bool:true

I got no pyrealsense2 module at all. I tried again, adding -DPYTHON_EXECUTABLE=/usr/bin/python3. That built an empty pyrealsense2 module, getting the error in the subject of this issue.
It would be nice to have a fix for this, since v2.34.0 has roughly 1-second lag in the camera image. Right now, the camera is pretty much useless. When I built v2.34.0, I did not need -DPYTHON_EXECUTABLE=/usr/bin/python3. It would be nice to know how I'm supposed to build, to get a Python 3 pyrealsense2 module.

also the raspberry pi does not detect the l515 when I run realsense-viewer

Please try to copy the new library to the same folder of your script to see if help
it could be the path of the library generated with SDK2.36 is changed.
wwppyy

I tried moving the opencv examples back a folder to the rest of the pyrealsense2 library, but it is now telling me "No module named 'pyrealsense2.pyrealsense2'

you can refer to
#6220

I dont understand what this has to do with our error

A friend of mine figured out a hack to get pyrealsense2 to build. He got it to work in v2.36.0. I successfully built v2.37.0. After you check out the sources you want to build, replace one file with an older copy:
git checkout v2.34.0 -- wrappers/python/CMakeLists.txt

That works, your friend is a hero. Thank you

using the CMakeLists.txt trick on the rpi4 did not work for me. However, using cmake ../ -DFORCE_RSUSB_BACKEND=true -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true
at least lets me see the device in the realsense viewer

all I see in rs is :

vars(rs)
{'name': 'pyrealsense2', 'doc': None, 'package': 'pyrealsense2', 'loader': <_frozen_importlib_external._NamespaceLoader object at 0x7f9f8b7550>, 'spec': ModuleSpec(name='pyrealsense2', loader=<_frozen_importlib_external._NamespaceLoader object at 0x7f9f8b7550>, submodule_search_locations=_NamespacePath(['/usr/lib/python3/dist-packages/pyrealsense2'])), 'file': None, 'path': _NamespacePath(['/usr/lib/python3/dist-packages/pyrealsense2'])}

@skywo1f Your result is consistent with using a post-v2.34.0 version of the wrappers/python/CMakeLists.txt file. I suggest you verify that you really have the old version of that file, during the build. It took me a couple of tries. The build script I was using checks out a version of the source in two different places. I had to add my checkout of the older version of that one file, in both places. And then I verified during the build that the old version of the file was still present.

So if I move my scripts into the /librealsense/build/wrappers/python folder, and re-install my opencv then it works. I also had to change the resolution in the example to 1024 by 768

@skywo1f  Hello , I'm facing the smae problem current and don't know how to fix it .
AttributeError: module 'pyrealsense2' has no attribute 'pipeline'
I try to put the script in the  /home/pi/librealsense/build/wrappers/python/   , like what you do in the end
and run it , it seems it can find pipeline , but another problem show up
it can't find CV2
pi@raspberrypi:~ $ python3 /home/pi/librealsense/build/wrappers/python/align-depth2color.py
Depth Scale is:  0.0010000000474974513
Traceback (most recent call last):
File "/home/pi/librealsense/build/wrappers/python/align-depth2color.py", line 73, in
cv2.imshow('Align Example', images)
cv2.error: OpenCV(4.4.0) /tmp/pip-install-gunf1z13/opencv-python/opencv/modules/highgui/src/window.cpp:651: error: (-2:Unspecified error) The function is not implemented. Rebuild the library with Windows, GTK+ 2.x or Cocoa support. If you are on Ubuntu or Debian, install libgtk2.0-dev and pkg-config, then re-run cmake or configure script in function 'cvShowImage'
Thank you to sharing the info  .

@skywo1f
pi@raspberrypi:~ $ python3 /home/pi/librealsense/build/wrappers/python/align-depth2color.py
Depth Scale is: 0.0010000000474974513
Traceback (most recent call last):
File "/home/pi/librealsense/build/wrappers/python/align-depth2color.py", line 73, in
cv2.imshow('Align Example', images)
cv2.error: OpenCV(4.4.0) /tmp/pip-install-gunf1z13/opencv-python/opencv/modules/highgui/src/window.cpp:651: error: (-2:Unspecified error) The function is not implemented. Rebuild the library with Windows, GTK+ 2.x or Cocoa support. If you are on Ubuntu or Debian, install libgtk2.0-dev and pkg-config, then re-run cmake or configure script in function 'cvShowImage'
After this problem , I try to reinstall the opencv , and things got solved .
Thank you for sharing the repo .

Hello @RealSenseSupport
I see this one is closed, but we are facing the same issue on the rpi4 with the 2.42 version. Are you guys aware of something like this?
Best

I tried with latest build following official docs. Ignore protobuf, cmake and opencv instalation guide from the doc. The problem was if you pip install in ubuntu you have to import it like import pyrealnsense2 as rs .  But when u build it from source you have to import it like import pyrealsense2.pyrealsense2 as rs .
Try like this.

import pyrealsense2.pyrealsense2 as rs
rs.version
'2.49.0'

Let me know if u have any issue regarding dependencies.

I tried with latest build following official docs. Ignore protobuf, cmake and opencv instalation guide from the doc. The problem was if you pip install in ubuntu you have to import it like import pyrealnsense2 as rs . But when u build it from source you have to import it like import pyrealsense2.pyrealsense2 as rs . Try like this.

import pyrealsense2.pyrealsense2 as rs
rs.version
'2.49.0'

Let me know if u have any issue regarding dependencies.

Yup did work!
import pyrealsense2.pyrealsense2 as rs


Can't delete a shape when iframe loses focus

It's gonna take me some time to make a reproducing example. But maybe you have a quick guess about where the bug is.
The repro is roughly as follows:

Embed <iframe> on the page. The iframe content page renders <Excalidraw />.
Draw a shape
Click outside the iframe.

Note the shape still appears selected — Excalidraw doesn't know you clicked outside the iframe. Not ideal but seems okay — I don't know if that's even fixable.

Click on the shape and press Backspace.

Expected: the shape gets deleted.
Actual: the shape is undelete-able — it ignores the key bindings.
The only way to fix it from that point is to draw another shape. Somehow after that, selecting the first shape attaches the key bindings again, and I can Backspace the first shape.

From quick tests I don't actually see any blockers.
I'm fairly certain it's caused by preventing default on pointerdown (though there may be other code paths, too):
https://github.com/excalidraw/excalidraw/blob/785a944ac2c325c213c4bb3b378f60b254ba8790/src/components/App.tsx#L2097-L2098
It was introduced very early in the project to prevent UI text selecting on drag.

It was introduced very early in the project to prevent UI text selecting on drag.

If that's the case, you should be able to just use -webkit-user-select: none; user-select: none; and be done! :)

Thanks!


Contact Page

Closes #421

Can you use animation in this page , its so static
We want in dynamic

@thestarsahil
I can build the website in parts, step by step sp that my number of PRs get increased as I am lagging behind in the Iwoc

@thestarsahil Please merge it


Multiple selection of nodes using checkboxes

I am trying to select multiple tree nodes using checkboxes but when I check one, the other selected node is deselected. The only way I could select more than one would be to use the control key and select the corresponding checkbox but this way does not fit the requirements I have been asked for. Could there be a solution that I am not aware of?
Thanks for your help!

Yeah, in your click handler for the checkbox, call node.selectMulti(). The will preserve other selections. And it will deselect properly I believe.

When you click on the checkbox the other checkboxes are deselected even if selectMulti is used, only if you use the control key and click on the checkbox the previously selected checkboxes are kept.

What's your code look like?

This is the code related to the node
{         selectable &&         !node.data.children?.length &&         <Checkbox           style={{ padding: 0 }}           checked={node.state.isSelected}           onClick={() => tree.selectMulti(node.id)} />       }

Hi  @jameskerr  I  noticed that the multi selection requires the ctrl key to be pressed, is there a way to make it available by default, avoinding this requirement ? Thanks !

Hi @jameskerr , thanks for this lib ! I'm having an issue associated to the selectMulti it seems that the SELECT_ONLY is always dispatched even when using selectMulti, how could i bypass this ? thanks !

Oh! Perhaps this is what's going on.
You may need to call event.stopPropagation() on the event argument in your NodeRenderer's onClick event. Each node is wrapped in a Row component. The Default Row component provided in the library binds the onClick event.

So either stopPropagation in your onClick handler, or provide a custom RowRenderer that doesn't have an onClick handler.

I hope this has addressed this issue. I am now closing.

How can i deselect the node, without key shortcut, i have checkbox multiselect tree and I want to select/deselect the selection if clicked on checkbox. It is not happening right now, I am not able to deselect on checkbox click.

@anupsingh244 Are you able to share the code that is not working?


fix contextMenu on Mobile

Details

/Users/syva80/Expensify.cash/src/pages/home/report/ReportActionItemFragment.js
I'm removing the prop "selectable"
components/RenderHTML.js. -->  components/RenderHTML/index.js  and  index.native.js (remove prop  "textSelectable")
Fixed Issues

Fixes #2279
Tests

Launch the app and login
Select any message from LHN
Long press on any message

QA Steps

Same as above
Tested On

[ ] Web
[x] Mobile Web
[ ] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@roryabraham thanks. I am fix it

updated

Updated

Also, there are merge conflicts

Updated

This does not seem to work on mobile web:

exactly, something broke((

Updated

Updated

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Just a heads up, I don't think we should have blocked the touch on the Web devices that support the Touch interface. So a check for small screens while preventing touch would have been great.

I don't think we should have blocked the touch on the Web devices that support the Touch interface. So a check for small screens while preventing touch would have been great.

Well, this is only for PressableWithSecondaryInteraction. I guess you're saying that it won't work with a regular touch interaction?

Oh yeah. But May it will block the context menu on WEb-touch devices while using touch. Anyways we can keep it as it is for now.

Follow-up here

🚀 Deployed to staging in version: 1.0.74-1🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@roryabraham Serious regression from blocking the touch event.

Can't able to close the Edit message box. Click on cancel or save changes that are not working on Mweb.
Another, https://github.com/Expensify/Expensify.cash/issues/3806

Yea, I was trying to track when #3806 started happening and it's on this commit https://github.com/Expensify/Expensify.cash/commit/a1f2c94cec417a14fac29c2327cac5928cee3196.

Revert PR here. So @Viacheslav80 this means that you'll need to create a follow-up PR to fix the context menu on mobile web without causing other regressions.

@roryabraham ok. I am do it today

@Viacheslav80 I think it's fine if you don't include the fix for blue screen/ full-page highlight. I will tackle that in https://github.com/Expensify/Expensify.cash/issues/2705.

@parasharrajat Hi! I created PR fix - I remove listener on touchstart event and set delayLongPress - 200 ms this help sometimes fix the full-page highlight

iOS - Chat - Context menu flickers continously
Expected Result:
No visual issues and context menu opens without any issue
Actual Result:
Context menu flickers continuously
Actions Performed:

Launch the app and login
Select any message from LHN
Long press on any message

Platform:
iOS ✔
mWeb
Android
Build:
1.0.75-0
Notes/Images/Video:
https://user-images.githubusercontent.com/43996225/124001666-de279f00-d9a2-11eb-8a48-afb96ca1d011.mp4

Confirmed this is fixed https://github.com/Expensify/Expensify.cash/pull/3659#issuecomment-871575307 🎉


Nanoleaf Essential Smart LED bulb PAA attestation certificate for iMX93 [1.0]

Reproduction steps
I am using iMX93 as Open Thread Border Router OTBR and command line chip-tool itself only.
Now I want to test Certified Smart LED bulb (Nanoleaf Essential Smart LED). It showing me no PAA certification error during commissioning
I need to do commission my custom thread border router from NXP to Nanoleaf Essential Smart LED bulb Matter A19 | E26 Smart Bulb (Each) https://nanoleaf.me/en-US/products/essentials/bulbs/?category=A19-E26&standard=matter&size=each.
I need PAA attestation certificate.
From where Can I find PAA attestation certificate for Nanoleaf Essential Smart LED bulb Matter A19 | E26 Smart Bulb.
Kindly help me on this.
Bug prevalence
every time
GitHub hash of the SDK that was being used
master
Platform
IMX8
Platform Version(s)
No response
Type
Spec Compliance Issue
Anything else?
No response

The normal place to find PAA certificates is in the DCL (Distributed Compliance Ledger).

Thank you for correct address to find PAA certificates that DCL.
I have look on https://webui.dcl.csa-iot.org/pki, But did not able to find PAA certificates for NanoLeaf Essenetials.
Can you help me on this please.
Thanks,
Vardhman Modi

Generally, you should ensure you have all PAA certificates in the DCL. Our PAIs trace up to StrongKey PAA.


ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running

Error traceback
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/multiprocessing/spawn.py", line 105, in spawn_main
    exitcode = _main(fd)
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/multiprocessing/spawn.py", line 114, in _main
    prepare(preparation_data)
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/multiprocessing/spawn.py", line 225, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/multiprocessing/spawn.py", line 277, in _fixup_main_from_path
    run_name="__mp_main__")
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/zhanghong/mmdetection/tools/train.py", line 15, in <module>
    from mmdet.apis import set_random_seed, train_detector
  File "/home/zhanghong/mmdetection/mmdet/apis/__init__.py", line 1, in <module>
    from .inference import (async_inference_detector, inference_detector,
  File "/home/zhanghong/mmdetection/mmdet/apis/inference.py", line 11, in <module>
    from mmdet.datasets import replace_ImageToTensor
  File "/home/zhanghong/mmdetection/mmdet/datasets/__init__.py", line 2, in <module>
    from .cityscapes import CityscapesDataset
  File "/home/zhanghong/mmdetection/mmdet/datasets/cityscapes.py", line 16, in <module>
    from .coco import CocoDataset
  File "/home/zhanghong/mmdetection/mmdet/datasets/coco.py", line 14, in <module>
    from .api_wrappers import COCO, COCOeval
  File "/home/zhanghong/mmdetection/mmdet/datasets/api_wrappers/__init__.py", line 1, in <module>
    from .coco_api import COCO, COCOeval
  File "/home/zhanghong/mmdetection/mmdet/datasets/api_wrappers/coco_api.py", line 6, in <module>
    from pycocotools.coco import COCO as _COCO
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/site-packages/pycocotools/coco.py", line 49, in <module>
    import matplotlib.pyplot as plt
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/site-packages/matplotlib/pyplot.py", line 2500, in <module>
    switch_backend(rcParams["backend"])
  File "/home/zhanghong/anaconda3/envs/openmmlab/lib/python3.7/site-packages/matplotlib/pyplot.py", line 288, in switch_backend
    newbackend, required_framework, current_framework))
ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running
.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

Which OS are you using?

Which OS are you using?

in Linux

It seems that you installed OpenCV-headless in your environment. You may try to uninstall it and install opencv.

I also suffer from this problem when matplotlib==3.4.3.
Changing the version of matplotlib  to 3.2.1 maybe solves this problem.

I also suffer from this problem when matplotlib==3.4.3.
Try to change the version of matplotlib to 3.2.1.

I also suffer from this problem when matplotlib==3.4.3. Try to change the version of matplotlib to 3.2.1.

I tried this method and it worked!

我在matplotlib==3.4.3时也遇到了这个问题。尝试将 matplotlib 的版本更改为 3.2.1。

我尝试了这种方法，它奏效了！

这个版本太低了，和我的python版本不适配🤦


RSET clears EHLO

When issuing a RSET command, mailhog will reset the SMTPMessage. This will also clear the original Helo value. Since a "real" mail server will usually keep the smtp HELO value intact, would it be worthwhile to also have that behaviour here?
https://github.com/mailhog/smtp/blob/0c4e9b7e0625fec61d0c30d7b2f6c62852be6c54/protocol.go#L233

I actually have a fix for this in #4. But I think this project is abandoned.


Improve code and readme

A good tutorial on scrapping website using headless Chrome. I have updated the readme and improved some of the code. See if it is useful by any means.

Merged 2 of your commits update readme & improve code


use aggressive filtering before OBBT

@fracek This PR is mostly to make sure you know this functionality exists. In my experience, using this filtering technique can be very beneficial and never hurts.

Nice, thank you a lot for this!


[scripts] add MLR Backbone multicast routing test

This PR tests https://github.com/openthread/ot-br-posix/pull/532:

[x] backbone/test_mlr_multicast_routing.py verifies the basic features of Backbone multicast routing
[x] backbone/test_mlr_multicast_routing_timeout.py verifies that MLR timeout works
[x] backbone/test_mlr_multicast_routing_commissioner_timeout.py verifies that Commissioner MLR timeout works

About OTBR_COMMIT:
This PR is using commit of https://github.com/openthread/ot-br-posix/pull/532 to pass checks. Later OTBR_COMMIT will be updated to ot-br-posix master.

@jwhui any  comments on this PR and https://github.com/openthread/ot-br-posix/pull/532?
I think we need to merge this PR first. Then, I can revise https://github.com/openthread/ot-br-posix/pull/532 to use OT master commit and pass all checks.

@jwhui any comments on this PR and openthread/ot-br-posix#532?
I think we need to merge this PR first.

SGTM. Thanks.


Image detection

Is it possible for react-measure to give back changing heights for a div that only contains a image? I get back a height that is always less than the actual height whenever I resize the browser. I'm guessing this is because that it measures before the image is loaded?

I have not tested with images yet, I will see what I can do. Thank you for the feedback.

Closing this, I'd rather leave image implementation to the user. You could use Image Events to tell when the image is loaded then use shouldMeasure to measure the content when you know the image has loaded.

Hey, I tried using the onLoad Image Event  to detect when the image has loaded, but I didn't get satisfactory results.  Essentially what I've done is when the image has loaded (handleImageLoaded() has been called), change the hasLoaded state property to true.
Here is a video demo.
Here is the code:
import React, {Component} from 'react';
import Measure from '../src/react-measure';
class AtomicImage extends Component {

	constructor() {
		super();
		this.state = {
			hasLoaded: false,
			dimensions: {}
		};
		this.onMeasure = this.onMeasure.bind(this);
		this.handleImageLoaded = this.handleImageLoaded.bind(this);
	}

	onMeasure(dimensions) {
		this.setState({dimensions});
	}

	handleImageLoaded() {
		this.setState({hasLoaded: true});
	}

	render() {

		const {src} = this.props;
		const {hasLoaded, dimensions} = this.state;
		const {width, height} = dimensions;

		return(

Dimensions: {width} x {height}

Image Loaded: {hasLoaded ? 'true' : 'false'}

				<Measure onMeasure={this.onMeasure} shouldMeasure={hasLoaded === true}>

				</Measure>

		);
	}
}

export default AtomicImage;

Here is the parent code.  It's not really important—just passes src to the AtomicImage element:
import React, {Component} from 'react';
import ReactDOM from 'react-dom';
import AtomicImage from './AtomicImage';

class App extends Component {

  constructor() {
    super();
    this.state = {src: ''}
    this.handleOnChange = this.handleOnChange.bind(this);
  }

  handleOnChange(e) {
    this.setState({src: e.target.value});
  }

  render() {

    const {src} = this.state;
    return (

          <input onChange={this.handleOnChange} type="text"/>

        <AtomicImage src={src} />

    )
  }

}

ReactDOM.render(<App />, document.getElementById('app'));

Hey, sorry to bother you again, but I'm really confused.  It only works when the images are cached? (again, I'm using the same code as above):
Here is a demo


Update MD file on new branch 2017-12-09_23-32-46

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


refactor: rename abbreviated namespaces to full pathing for Core/IO/Math

This should be a refactor! no?

Absolutely it should!
I always forget about the ! :'(


Pleast, remove skyblue colors everywhere, it's offensive to non-homosexuals

And pink too, it's color of lesbians

Be good, please don't troll. If you don't like these colors, change theme.
You using maintained Free and good editor, just support developers by file real issues and try solve others issue

Thanks, but I'll never use software from microsoft

Okay, if not using, why creating troll issue?


chore: update Dafny from 4.1 to 4.2

Issue #, if available:
Description of changes:
Updates all CI references from Dafny 4.1 to Dafny 4.2.

Err... shouldn't there be Dependency changes on the Dafny Runtime library?

@justplaz see https://github.com/aws/aws-database-encryption-sdk-dynamodb-java/blob/main/project.properties#L3

https://github.com/aws/aws-database-encryption-sdk-dynamodb-java/pull/476/files duplicates this, and includes a workaround for the Dafny regression causing excessive resource use in this PR.


How to uninstall submariner purely

How to uninstall submariner purely？ l didnot find this in github or https://submariner.io？ is it exist？

We don't have that on the website, and it's slightly different depending on the cable driver you have, I'm adding this to the backlog so we can secure time on following sprints to handle it.

FWIW, this Issue has more information on how to manually remove the Submarine resources from a cluster: https://github.com/submariner-io/submariner-website/issues/272
We still need to automate this and integrate into subctl/Operator, etc.

Closing this against https://github.com/submariner-io/submariner-website/issues/272


Time Intelligence Selection

The feature request
The ability to select the time intelligence new measures at both the group (e.g. Growth .., To-date .. etc.) or at the individual measure within each category (e.g. MOM .. YTD .., MAT.. etc.)
Proposed solution
Add a check box to select/deselect the entire measure group or individual measures within the group.
Additional context
It would be great if we have the selection check box in a matrix the hast the combination of the report measure (e.g. total sales, sales count) and the new time intelligence measures (at both group level and individual level) to provide the max flexibility.

I need a clarification - do you want:

The ability to select the individual Time Intelligence functions to apply to all the selected measures
The ability to select groups of Time Intelligence functions to apply to all the selected measures
The ability to select groups of measures based on folders? (It is already possible by table)

Thanks!

I believe it's the first 2. Basically it would be great if we can have select Time Intelligence Group or Individual Functions with the group to be applied on all or individual exiting measures.
For example:
1- Apply "Growth" on all/individual measures
2- Apply exclude "Moving annual growth"
3- Apply MTD and YTD only on Measure 1 and Measure 2 only
4- etc.
I envision this feature to be a check box combination matrix of all Groups/Function and existing Measures to determine which Group/Function is applicable to which Measure. If it's going to be complex to implement, we can simply add a check box in the Time Intelligence's "Preview" screen with a check box to exclude individual ones.
I hope that helps :)

We have to evaluate whether to include a similar feature in v1 or postpone in future versions.
The issue is that the template could change, so the groups of time intelligence functions could change as well.
We could infer the structure from the metadata of the template, but I'm worried we do not have a feature to support that in the library.
However, this is something we wanted to do, it's just a question of when/how to implement it.

Sounds good and thanks for your hard work! :)


New version: SKDataAS.ORMCore version 202304251

- [X] Have you signed the Contributor License Agreement?

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.4 schema?

Resolves #Issue with encryption of an old connection string
Resolves #that no longer is needed nor used. Encryption removed

Microsoft Reviewers: Open in CodeFlow

Duplicate of #103440


metalibm_functions.ml_acos is broken

in python 3
    print "building mathematical polynomial"
                                           ^
SyntaxError: Missing parentheses in call to 'print'

in python 2:
TBD

ml_acos meta-function was only a skeleton for a future implementation. It should not be considered functionnal


[ENH] Add pooch sys info

Reference issue
Addresses comment in #9798 .
What does this implement/fix?
Adds pooch info to system report.
Additional information
Note: on local machine, mne sys_info does not display the additional pooch info, however python -c "import mne; mne.sys_info() does display it. It's unclear to me if this is the desired behavior.

Thank @jbteves !


[GODSEND Agenda] 1.3.0

Changes / Comments

visual improvements
archetype & species datalists
roll improvements

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


[Numpy] Infer shape partial failed for unknown shapes

I came from a user reported issue here: https://github.com/apache/incubator-mxnet/issues/14751#issuecomment-486866935
In https://github.com/apache/incubator-mxnet/pull/14661, unknown shape in mxnet was represented using 0, and changed to -1, this brought some unexpected behavior on infer_shape_partial of some of the operators in MXNet.
As noted in the PR discussion, when many operators were implemented for the first time, some strong assumption may have been made because zero-dim and zero-size tensors are not introduced.
Also, many of these problems are not revealed in MXNet because unknown dim place holders (0 or -1) are not used often. For now, this change does not bring any other compatibility issue except in the keras-mxnet project. Keras-MXNet relies a lot on unknown shapes and infer_shape_partial internally.
As I'm trying to fix the problem, I m using this issue to record the operators in MXNet where the infer shape logic may be wrong.
Following are the operators I found now, more to come:

[ ] dot
DotShape need to return if lhs or rhs shape is unknow:
adding the following at this line
solves it

if (!shape_is_known(lshape) || !shape_is_known(rshape)) return false;

[ ] transpose
we were checking dim  here

CHECK_LE(shp.ndim(), 6U)

fails if shp.dim() is -1 because it's comparing signed with unsigned and returning false, but -1 is lesser than 6
Thanks, @reminisce for the help to identify these issues, I'm still trying to come up with the full list of ops impacted as I need to convert keras-mxnet bugs to pure mxnet root cause.
cc @junrushao1994 @sandeep-krishnamurthy

@mxnet-label-bot add [Bug, Numpy, Operator]

Hi @iamthebot , we just released MXNet 1.5.0, and keras-mxnet will release <IP_ADDRESS> in next week or so. Tracked here: https://github.com/awslabs/keras-apache-mxnet/issues/234


glfwGetKeyName implementation and bugfix for X11 keypad issue.

Implementation of glfwGetKeyName as per https://sourceforge.net/p/glfw/discussion/247562/thread/c9bd5374/
This returns a correctly translated key name string in UTF-8 as per the users keyboard and locale settings.

what happened to the keyboard branch and to this GetKeyName function ? I am having issues using glfw to properly recognize CTRL+Z combos correctly on my windows machine...

@Extrawurst #464


Dependencies not installed (recipe intef-exe fails)

After commits of 24/8/2020, recipe intef-exe fails, because some dependencies are not installed.
Before those commits, I got the package python-minimal installed in the AppImage. After those commits, this package is no longer installed. The package is a dependency of python 2.7.13-2, whose info is:
Package: python
Source: python-defaults
Version: 2.7.13-2
Architecture: amd64
Maintainer: Matthias Klose<EMAIL_ADDRESS>Installed-Size: 648
Pre-Depends: python-minimal (= 2.7.13-2)
Depends: python2.7 (>= 2.7.13-1~), libpython-stdlib (= 2.7.13-2)
Suggests: python-doc (= 2.7.13-2), python-tk (>= 2.7.13-1~)
Conflicts: python-central (<< 0.5.5)
Breaks: update-manager-core (<< 0.200.5-2)
Replaces: python-dev (<< 2.6.5-2)
Provides: python-ctypes, python-email, python-importlib, python-profiler, python-wsgiref
Section: python
Priority: optional
Multi-Arch: allowed

I think Pre-Depends are probably no longer processed by pkg2appimage.
I am able to build the recipe intef-exe with this commit (patched as in issue #429 ):
https://raw.githubusercontent.com/AppImage/pkg2appimage/8459678c3cb862e75a29b822619ea8e3d3a91db0/pkg2appimage

Which host OS did you run this on?

Pre-Depends currently probably only works on deb-based systems.

I run this on a Debian Sid, dpkg version is 1.20.5
After further investigation, there are 3 missing packages in the AppImage which doesn't work:
python-cffi-backend_1.9.1-2_amd64.deb
python-minimal_2.7.13-2_amd64.deb
python-zope.interface_4.3.2-1_amd64.deb

These are dependencies of the following packages:
Package: python-cryptography
Version: 1.7.1-3+deb9u2
Depends: python (<< 2.8), python (>= 2.7~), python-cffi-backend-api-min (<= 9729), python-cffi-backend-api-max (>= 9729), python-enum34, python-idna (>= 2.0), python-ipaddress, python-pyasn1 (>= 0.1.8), python-setuptools (>= 11.3), python-six (>= 1.4.1), python:any (<< 2.8), python:any (>= 2.7.5-5~), libc6 (>= 2.4), libssl1.1 (>= 1.1.0)

Package: python
Version: 2.7.13-2
Pre-Depends: python-minimal (= 2.7.13-2)
Depends: python2.7 (>= 2.7.13-1~), libpython-stdlib (= 2.7.13-2)

Package: intef-exe
Version: 3:2.5
Depends: python:any (<< 2.8), python:any (>= 2.7.5-5~), python-setuptools, python-zopeinterface (>= 3.0.0-6) | python-zope.interface, python-pil, python-chardet, python-lxml, iceweasel | www-browser, python-feedparser, mimetex, python-bs4, python-suds, python-requests-oauthlib, python-dateutil, python-cssmin | cssmin, python-webassets

So, python-minimal is in a Pre-Depends; python-cffi-backend has a Provides line for the dependency python-cffi-backend-api:
Package: python-cffi-backend
Version: 1.9.1-2
Depends: python (<< 2.8), python (>= 2.7~), python:any (<< 2.8), python:any (>= 2.7~), libc6 (>= 2.14), libffi6 (>= 3.0.4)
Breaks: python-cffi (<< 1)
Replaces: python-cffi (<< 1)
Provides: python-cffi-backend-api-9729, python-cffi-backend-api-max (= 10239), python-cffi-backend-api-min (= 9729)

and python-zope.interface is an alternative dependency with |.
These 3 cases are no longer processed correctly by pkg2appimage.


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1571

Questions ?
Please refer to the Backport tool documentation


Animations plugin : new features and bug fixes

New features

Multiple animations
Set scale in animation
Center on cell
Highlight cells
Control bar in lightbox mode, with play/pause, prev step, next step, restart anim, animation selector
Support for comments in scripts (// comment)
Support for layers

Bug fixes

Stencil shapes with alpha still showed up on init
fading not applied correctly on foreign objects (text boxes...) because foreignObject element not correctly positionned => added a temporary overlay for animation

Hi @davidjgraph, some news about this code review? :)

Hi,
Thanks for your submission. Unfortunately, we're going to have to change our policy on PRs. We just can't accept copyrightable contributions to the codebase and so will have to reject all non trivial PRs.
Apologies for this, we will make that clear on the README.

Hi,
It's sad that users can't contribute improving an enhancing this app anymore, especially concerning plugins...
At least, will there be a way to use external pluggins ? It's currently blocked by CSP policy... leaving us with no way to devellop and / or use custom pluggins. I was using draw.io and then diagrams.net to draw software architecture diagrams professionaly, and used my own custom pluggins to add interractivity to my diagrams, and to prepare presentations for developpers focusing on features with anotations (using animations with pan & zoom).
I'm probably going to need some other tools to do what I used to do with draw.io... :(

Hi @davidjgraph,
Having a closer look, I didn't see what "copyrightable material" you talked about in this PR ? It's only based on native framework, adding some features, but not including any new external library or other material that may be "copyrightable material"...
Could you enlighten me about what is wrong with this PR? Maybe I could rework it to be compliant ?
Thanks by advance.

Hi @davidjgraph,
Having a closer look, I didn't see what "copyrightable material" you talked about in this PR ? It's only based on native framework, adding some features, but not including any new external library or other material that may be "copyrightable material"...
Could you enlighten me about what is wrong with this PR? Maybe I could rework it to be compliant ?
Thanks by advance.

There's nothing with it. When you write code it's implicitly copyrighted to you. The problem is that it's copyright to you, not to someone else. The entire codebase is copyrighted to JGraph, changing that isn't simple.

There's nothing with it. When you write code it's implicitly copyrighted to you. The problem is that it's copyright to you, not to someone else. The entire codebase is copyrighted to JGraph, changing that isn't simple.

Isn't there a way to indicate, maybe with a comment in code header, that I give rights to JGraph for this contribution ?

Isn't there a way to indicate, maybe with a comment in code header, that I give rights to JGraph for this contribution ?

Assigning copyright could be done, yes. But, next the issue is that we are legally responsible for the security of your code when it's deployed app.diagrams.net. If it has a hole and data gets stolen, we gets sued. Have you completely analysed the code for security issues? Are you willing to take liablity for the code.
I know the answer is no, but you see the problem. In an open source desktop app, there aren't these problems. On a codebase that we deploy to millions of users every day, we take significant risk.
I, personally, don't want to take reponsibility for your code. If another member of the team is willing to be personally liable then they can merge it.

Assigning copyright could be done, yes. But, next the issue is that we are legally responsible for the security of your code when it's deployed app.diagrams.net. If it has a hole and data gets stolen, we gets sued. Have you completely analysed the code for security issues? Are you willing to take liablity for the code.
I know the answer is no, but you see the problem. In an open source desktop app, there aren't these problems. On a codebase that we deploy to millions of users every day, we take significant risk.
I, personally, don't want to take reponsibility for your code. If another member of the team is willing to be personally liable then they can merge it.

@davidjgraph it's really unfortunate to see such great feature not accpeted to be reviewed/merged into diagrams.net!
@smazuir If you could create a feauture request for those functionnalities and a link to your PR that will be really nice.
I'm crossing my fingers to see such great features implemented into diagrams.net

@gitown are you willing to fund all bounties for all security vulnerabilities in this code?

@davidjgraph I didn't read the code to know if it contains vulnerabilities!
I'm just kindly asking to consider adding these features as they're very useful features and I'm pretty sure that many users will be happy to see them in diagrams.net!

So, I pay for any vulnerability bounties on someone else's code? I don't understand, why would I do this?

@davidjgraph I don't understand your point of talking about vulnerability bounty and paying for that! If that code contains vulnerabilities don't accept that PR. Full Stop.
Beside that code that contains the vulnerabilities, the community aren't allowed to ask for new features and improvements for your product? I understand that the community aren't allowed to do a PR, but also features request are not allowed?

@davidjgraph I don't understand your point of talking about vulnerability bounty and paying for that! If that code contains vulnerabilities don't accept that PR. Simple.
Beside that code that contains the vulnerabilities, the community aren't allowed to ask for new features and improvements for your product? I understand that the community aren't allowed to do a PR, but also features request are not allowed?

@davidjgraph I don't understand your point of talking about vulnerability bounty and paying for that! If that code contains vulnerabilities don't accept that PR. Simple.
Beside that code that contains the vulnerabilities, the community aren't allowed to ask for new features and improvements for your product? I understand that the community aren't allowed to do a PR, but also features request are not allowed?

Seeing security issues in non-trivial PRs isn't simple. I can see a console.log left in, so this code hasn't been reviewed properly.
You are welcome to ask for new features, but this is a PR, not a new feature issue, that would be posted at https://github.com/jgraph/drawio/issues.


[WIP] Convert to RST for Read The Docs (RTD)

Using modified PR template from TransformCore PR Checklist

- Q. -
- A. -

Tickets
#114

Type
Documentation

BC breaks?
yes

Deprecations?
yes

Docs
updated

Status
WIP

Closing this PR as it has been superseded by https://github.com/domnikl/DesignPatternsPHP/pull/131


Wrong number of arguments for associations whose scope has an argument

I have something like
class Wizard
  has_and_belongs_to_many :schools, ->(wizard) { where castle: wizard.castle }
end

when I use
<%= f.association :schools %>

in a form, I get a wrong number of arguments (given 0, expected 1) exception

Thank you for your report.
Could you please provide more information? Like for example:

Rails version
Simple Form version
Steps to reproduce the error

Will be even more helpful if you provide a sample application or a test case that reproduces the error.

Hi,
Rails version 5.1.4, simple form version 3.5.0
The situation is: I have many castles, each castle has many schools and many wizards. Each wizard can belong to several schools, and each school can host several wizards, but only if the schools and the wizards belong to the same castle. So my models look as follows:
class Castle < ApplicationRecord
has_many :wizards
has_many :schools
end
class School < ApplicationRecord
belongs_to :castle
has_and_belongs_to_many :wizards, ->(school) { where castle: school.castle }
end
class Wizard < ApplicationRecord
belongs_to :castle
has_and_belongs_to_many :schools, ->(wizard) { where castle: wizard.castle }
end
The form for School looks as follows:
<%= simple_form_for school do |form| %>
<%= form.association :wizards %>

  <%= form.button :submit %>

<% end %>
When I try to use it I get the above error
I attach the example. Thanks!
kingdom.tar.gz

Hi @mkamensky.
I tried to run your example but I got another error:
Started GET "/schools/new" for <IP_ADDRESS> at 2017-11-24 11:49:00 -0200
Processing by SchoolsController#new as HTML
  Rendering schools/new.html.erb within layouts/application
  Rendered schools/_form.html.erb (18.2ms)
  Rendered schools/new.html.erb within layouts/application (20.4ms)
Completed 500 Internal Server Error in 62ms (ActiveRecord: 1.3ms)

ActionView::Template::Error (undefined method `castle' for nil:NilClass):
    1: <%= simple_form_for school do |form| %>
    2:   <%= form.association :wizards %>
    3:
    4:

    5:     <%= form.button :submit %>

app/models/school.rb:3:in `block in <class:School>'
app/views/schools/_form.html.erb:2:in `block in _app_views_schools__form_html_erb___2389557724941141719_70125971473920'
app/views/schools/_form.html.erb:1:in `_app_views_schools__form_html_erb___2389557724941141719_70125971473920'
app/views/schools/new.html.erb:3:in `_app_views_schools_new_html_erb__3871778820780610095_70125971575740'

Do you have some logic to build the associations for a new School record?

This is strange, maybe a different version somewhere? Not sure what you meant in the last question, normally I would want to build a Castle, then build wizards and schools in it, and attach them to each other

I think I found the bug. As we are using the instance_exec to execute the scope from the association, when the scope has a parameter, it's breaking. You can see it below:
https://github.com/plataformatec/simple_form/blob/46da2d1e60b01d3cd47a50d5f414831124589fcf/lib/simple_form/form_builder.rb#L464
I'm not sure about that, but I think that the scope's parameter always will be the instance of the own class, in this case, the instance of the school - maybe @rafaelfranca can confirm it. If it's true, we can fix it with something like that:
          if reflection.scope.parameters.any?
            relation = reflection.klass.instance_exec(object, &reflection.scope)
          else
            relation = reflection.klass.instance_exec(&reflection.scope)
          end

@tegon @mkamensky Let me know your thoughts, if I'm right, I can send the PR to fix it later.

This is definitely the situation in my case, and the only way I know of that this parameter is used.

sound like a plan to me


Caching module info

Ref:

Module info
We should cache this as I'm guessing this is expensive to compute every time run is called.

Merging as it is required for another change. Feel free to comment on it for any changes