[v6.6.7] HTML being parsed and re-written breaking  inside  or  elements. (Workaround / Fix inside)

I'm one of these old farts that was around when validating your HTML was cool enough to warrant putting a badge on your site, so still validate my code, and noticed an issue yesterday with our static site. If you write the following HTML:
<video>
        <source src="/media/examples/flower.webm" type="video/webm">
        <source src="/media/examples/flower.mp4" type="video/mp4">

Sorry, your browser doesn't support embedded videos.

</video>

So if your browser cannot play the webm video, it goes to the next element, and tries to play the mp4 video, if it can't do this it goes to the next element, which in this case is just a message saying your browser doesn't support embedded videos.
But, after WP2Static has parsed it with DOMDocument(), you will end up with:
<video><source src="/media/examples/flower.webm" type="video/webm"><source src="/media/examples/flower.mp4" type="video/mp4">
Sorry, your browser doesn't support embedded videos.

</source></source></video>

Which if you add the line-breaks and tabs in, it is clearer why this doesn't work.
<video>
        <source src="/media/examples/flower.webm" type="video/webm">
                <source src="/media/examples/flower.mp4" type="video/mp4">

Sorry, your browser doesn't support embedded videos.

                </source>
        </source>
</video>

Now this isn't correct. What this leads to is if your browser cannot play the webm video, it has nothing to try next, it ignores everything inside <source>, as <source> is not a tag that wraps other tags, technically, </source> isn't a tag, it will fail validation, which is how I discovered this issue.
Fix / Workaround
End your <source> elements XHTML style like this: <source />
<video>
        <source src="/media/examples/flower.webm" type="video/webm" />
        <source src="/media/examples/flower.mp4" type="video/mp4" />

Sorry, your browser doesn't support embedded videos.

</video>

This isn't required by the HTML5 specification, nor is it encouraged as it could lead you to assume the element can wrap or have a separate closing element, but it does resolve the issue and instead of ending up with nested  elements, you end up with this, which browsers will be able to understand (even though it is not the HTML5 specification)
<video>
        <source src="/media/examples/flower.webm" type="video/webm"></source>
        <source src="/media/examples/flower.mp4" type="video/mp4"></source>

Sorry, your browser doesn't support embedded videos.

</video>

This doesn't make your static HTML validate, but browsers should hopefully be able to try each source in order falling back to the next one if they can't play it.
Picture Element
Same workaround applies to the <picture> element if using srcset, close the <source> tags XHTML style like this: <source />
<picture>
        <source srcset="logo-768.png 768w, logo-768-1.5x.png 1.5x" />
        <source srcset="logo-480.png, logo-480-2x.png 2x" />

</picture>

References
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

Hi @lukearmstrong, many thanks for reporting this and providing workarounds!
Invalid/unparsable HTML was one of the most unnecessary blockers for V6.x users, so I've taken that out of the core for upcoming V7. It will reappear in the form of the Advanced HTML Processor add-on, which will provide functions to strip WP footprints and anything other transformations requiring HTML parsing. It's still a way off from a testable build, as I'm focusing on the core functions at the moment, with simple string replacement working for the majority of users.
When the time comes to implement that and close this issue off for the new add-on, I may implement something to address this - perhaps a separate addon to force adjusting the markup of these in the dev site or to transform during processing...
Thanks again!


updated logrus and all other packages

Fixing https://github.com/kubernetes-incubator/external-dns/issues/379

Trying to wake up travis...

@linki is it skipping the travis because the PR has size/XXL and does not have a reviewer assigned?

I merged in master.

Thanks!

how did u fix the broken logrus dependenceis?

I reglided and pinned the version of golang.org/x/sys/unix and golang.org/x/crypto/ssh/terminal to the same versions as defined in https://github.com/kubernetes/client-go/blob/release-3.0/Godeps/Godeps.json.
For some reason golang.org/x/sys/unix was the same as client-go defines but golang.org/x/sys/unix was picked from master (although Godeps.json defines it). However, those versions don't work together (at least on mac).

👍

👍


Clarify vwred* and vfwred* instructions with LMUL=8

Hello,
I have a question about vwred* and vfwred* instructions with LMUL=8.
According sepc

ch5.2 says,

(1)The largest vector register group used by an instruction can not be greater than 8 vector registers, and if a vector instruction would require greater than 8 vector registers in a group, an illegal instruction exception is raised.
(2)attempting a widening operation with LMUL=8 will raise an illegal instruction exception

ch15.2 says,

The unsigned vwredsumu.vs instruction zero-extends the SEW-wide vector elements before summing them, then adds the 2*SEW-width scalar element, and stores the result in a 2*SEW-width scalar element.
According to spec ch5.2(1) and ch15.2, the number of vector register group of vwred* and vfwred* instruction was 8 and these instructions did not violate ch5.2(1) under widening reduction instruction with LMUL=8.
But ch5.2(2) says widening instruction with LMUL=8 will raise an illegal instruction exception.
What's correct?
Thanks,
Larry

The 5.2 text should be clarified to only raise exceptions when a vector register group would need to be LMUL>8.  The scalar reduction in/out operand has an effective LMUL of 1.


{palo-alto} HTML tags are rendering as empty parameter values in reference

Describe the bug
Problem to solve:
HTML tags in source code are causing build warnings in MicrosoftDocs/azure-docs-cli. More importantly, customer-facing reference docs are not instantiating properly -- parameter values formatted with `<>` are missing. Here's an example:

Requested solution:
These values should be escaped with a backtick. Here's an example from az webpubsub.

Published reference guidelines
Guidelines for Parameters used in examples
Related GitHub issues:
This is the same issue as these GitHub issues.
List of HTML tag instances that need update:

File name
Build error

latest/docs-ref-autogen/palo-alto/cloudngfw/firewall.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/palo-alto/cloudngfw/firewall.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/palo-alto/cloudngfw/local-rulestack.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/palo-alto/cloudngfw/local-rulestack.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Related command
az palo-alto
Errors
n/a
Issue script & Debug output
n/a
Expected behavior
n/a
Environment Summary
Azure CLI 2.62.0
Additional context
No response

Thank you for opening this issue, we will look into it.


Proposal: Submitted data restructure

💭 Problem
I've found that the "Components", "Tools", and "Templates" distinction isn't always logical. For example, @sveltejs/adapter-auto is in components.json, while vite-plugin-svelte is in tools.json. "Components" in particular is far more than just UI packages. It would be easy to miss a package because you don't know where to look.
In comparison, I've found the SolidJS Ecosystem pages to be very well structured and logical. They divide their content into "Packages" and "Resources".
🚀 Proposal
I think the packages vs resources division makes a lot of sense. Here is how I think the current data could fit this:
/packages

Things that you can npm install and add to package.json.
Sourced from current components.json and tools.json.
Using the above example, both @sveltejs/adapter-auto and vite-plugin-svelte would be included on this page.

/resources

Templates, sample projects, extensions, tutorials, podcasts, etc.
Sourced from current templates.json, tools.json, and /resources.
For example, SvelteKit i18n Template, Svelte DevTools and Svelte for VS Code would be included on this page.
Opens the door for more resource submissions (e.g. I can't find any references to Joy of Code's channel)

I agree components and tools could be combined. I'm not sure where I'd have the list of editor extensions live, but the rest seem fairly overlapping
I'd keep templates and resources separated. Solid's resources are limited to articles, videos, and podcasts, which is a more reasonable grouping to me than mixing templates in. Especially since we have so many templates it'd overwhelm the rest of the content

I agree components and tools could be combined. I'm not sure where I'd have the list of editor extensions live, but the rest seem fairly overlapping
I'd keep templates and resources separated. Solid's resources are limited to articles, videos, and podcasts, which is a more reasonable grouping to me than mixing templates in. Especially since we have so many templates it'd overwhelm the rest of the content

Thanks for the feedback! Great point about keeping templates and resources separate. Here's how I think this could work:
/packages:

Sourced from current components.json and tools.json (excluding browser and IDE extensions)

/templates:

Unchanged from current templates.json

/resources:

Current resources page converted into JSON, and extensions from tools.json

For me, we need to separate (at least) what is need to create the application and what help to create the application and DX improvement.

Need to create:

Component libs
UI libs
Vite plugin to transform data
Preprocessor
etc.

Help to create:

IDE plugins
Prettier plugins
Templates
HMR plugins
Documentation generation
Tutorials
etc.

The need vs help difference sounds like a pretty difficult line to draw. I would be surprised that vite plugins and preprocessors are on one page, but HMR plugins and prettier plugins are on a different page.

The need vs help difference sounds like a pretty difficult line to draw.

Yeah.
Nothing is simple, and really depend on personal opinion. And maybe even harder to categorized from submission info (often near zero context, and a glance at the project README is not always enough).
I guess need vs help can be defined as: "If you remove it and the application still work, it's help". But yet again, hard to deduce without a "test rig" (which is impossible to create as every package have different setup, effect, etc.)

The need vs help difference sounds like a pretty difficult line to draw. I would be surprised that vite plugins and preprocessors are on one page, but HMR plugins and prettier plugins are on a different page.

I agree with this - I would suggest defining it as "things you add to package.json", which is fairly straightforward and easy to deduce from a README. I've submitted a PR for this proposal at #533 - please let me know if you have any thoughts!


Azure OpenAI Embedding langchain.embeddings.openai.embed_with_retry won't provide any embeddings after retries.

I have the following code:
docsearch = Chroma.from_documents(texts, embeddings,persist_directory=persist_directory)

and get the following error:
Retrying langchain.embeddings.openai.embed_with_retry.<locals>._completion_with_retry in 4.0 seconds as it raised RateLimitError: Requests to the Embeddings_Create Operation under Azure OpenAI API version 2022-12-01 have exceeded call rate limit of your current OpenAI S0 pricing tier. Please retry after 3 seconds. Please contact Azure support service if you would like to further increase the default rate limit.

The length of my texts list is less than 100 and as far as I know azure has a 400 request/min limit. That means I should not receive any limitation error. Can someone explain me what is happening which results to this error?
After these retires by Langchain, it looks like embeddings are lost and not stored in the Chroma DB. Could someone please give me a hint what I'm doing wrong?
using langchain==0.0.125
Many thanks

+1

+1

any suggestion would be very appreciated!

+1

I set max_retries = 10. I am still getting "Retrying langchain.embeddings.openai.embed_with_retry" messages, but I was able to complete the index creation.
embeddings = OpenAIEmbeddings(model="text-embedding-ada-002", chunk_size=1, max_retries=10)

+10000

Any solution to fix this issue ?
+1

So far as I know Azure OpenAI Embedding is different with Open AI official embedding api . it doesn't support us to use
Chroma.from_documents instead we need to use Azure open ai embedding api to do it.

+1111

I tried something like this:
embeddings = OpenAIEmbeddings()
vector_store = FAISS.from_texts(texts=["example1", "example2"], embedding=embeddings)
and
vector_store = Chroma.from_texts(texts=["example1", "example2"], embedding=embeddings)
got:
Retrying langchain.embeddings.openai.embed_with_retry.<locals>._embed_with_retry in 4.0 seconds as it raised RateLimitError: You exceeded your current quota, please check your plan and billing details..
I'm passing a list that has a length of 2, and it is giving me RateLimitError.
Tried two versions of Langchain, 0.0.162 and 0.0.188, and both appeared with the same error.

Retrying langchain.embeddings.openai.embed_with_retry.<locals>._embed_with_retry in 4.0 seconds as it raised APIError: The server had an error processing your request. Sorry about that! You can retry your request, or contact us through our help center at help.openai.com if you keep seeing this error. (Please include the request ID 25115737c4fe3e6d4deef4961066ba2e in your email.) {
  "error": {
    "message": "The server had an error processing your request. Sorry about that! You can retry your request, or contact us through our help center at help.openai.com if you keep seeing this error. (Please include the request ID 25115737c4fe3e6d4deef4961066ba2e in your email.)",
    "type": "server_error",
    "param": null,
    "code": null
  }
}
 500 {'error': {'message': 'The server had an error processing your request. Sorry about that! You can retry your request, or contact us through our help center at help.openai.com if you keep seeing this error. (Please include the request ID 25115737c4fe3e6d4deef4961066ba2e in your email.)', 'type': 'server_error', 'param': None, 'code': None}} {'Date': 'Fri, 16 Jun 2023 01:43:24 GMT', 'Content-Type': 'application/json', 'Content-Length': '366', 'Connection': 'keep-alive', 'access-control-allow-origin': '*', 'openai-organization': 'provectus-algae-pem6gx', 'openai-processing-ms': '5602', 'openai-version': '2020-10-01', 'strict-transport-security': 'max-age=15724800; includeSubDomains', 'x-ratelimit-limit-requests': '3000', 'x-ratelimit-remaining-requests': '2999', 'x-ratelimit-reset-requests': '20ms', 'x-request-id': '25115737c4fe3e6d4deef4961066ba2e', 'CF-Cache-Status': 'DYNAMIC', 'Server': 'cloudflare', 'CF-RAY': '7d7f5c6ebacfa83e-SYD', 'alt-svc': 'h3=":443"; ma=86400'}.

Killing me, I've sent through a single request (on a paid plan) and am being rate limited on embeddings.

After a bit of digging i found this
How_to_handle_rate_limits.ipynb
Will try implement a fix on limiting the rate of request made per minute (as if the langchain community doesn't already have one)

+1

getting for FAISS.from_documents(data, embeddings):
Traceback (most recent call last):
  File "/app/scheduler/4_generate_embeddings.py", line 52, in <module>
    vectors = FAISS.from_documents(data, embeddings)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/base.py", line 332, in from_documents
    return cls.from_texts(texts, embedding, metadatas=metadatas, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 517, in from_texts
    embeddings = embedding.embed_documents(texts)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/embeddings/openai.py", line 452, in embed_documents
    return self._get_len_safe_embeddings(texts, engine=self.deployment)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/embeddings/openai.py", line 302, in _get_len_safe_embeddings
    response = embed_with_retry(
               ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/embeddings/openai.py", line 97, in embed_with_retry
    return _embed_with_retry(**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/tenacity/__init__.py", line 289, in wrapped_f
    return self(f, *args, **kw)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/tenacity/__init__.py", line 379, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.11/site-packages/tenacity/__init__.py", line 382, in __call__
    result = fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/embeddings/openai.py", line 95, in _embed_with_retry
    return embeddings.client.create(**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/api_resources/embedding.py", line 33, in create
    response = super().create(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/api_resources/abstract/engine_api_resource.py", line 153, in create
    response, _, api_key = requestor.request(
                           ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/api_requestor.py", line 230, in request
    resp, got_stream = self._interpret_response(result, stream)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/api_requestor.py", line 624, in _interpret_response
    self._interpret_response_line(
  File "/usr/local/lib/python3.11/site-packages/openai/api_requestor.py", line 687, in _interpret_response_line
    raise self.handle_error_response(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/api_requestor.py", line 337, in handle_error_response
    raise error.APIError(
openai.error.APIError: Invalid response object from API: '{ "statusCode": 500, "message": "Internal server error", "activityId": "......." }' (HTTP response code was 500)

Getting the same error.

+1000

+1

+1
OpenAI's developer experience is pretty frustrating.

There are two possible solutions:

You can request an increase in quotas, which has been confirmed by MS support.
Starting from July, Azure open AI support embedding with a chunk size of 16. You can find detailed usage information at the following reference: https://m.bilibili.com/video/BV1oP411r7g6
Unfortunately, the video at 1:30 only contains Chinese content.

I also meet this problem. But when I retry later, the bug is disappear.
SOS

I'm having this issue today, but not yesterday.  2023-08-08 14:56:18 INFO     error_code=429 error_message='Requests to the Get a vector representation of a given input that can be easily consumed by machine learning models and algorithms. Operation under Azure OpenAI API version 2023-05-15 have exceeded call rate limit of your current OpenAI S0 pricing tier. Please retry after 2 seconds. Please go here: https://aka.ms/oai/quotaincrease if you would like to further increase the default rate limit.' error_param=None error_type=None message='OpenAI API error received' stream_error=False
2023-08-08 14:56:18 WARNING  Retrying langchain.embeddings.openai.embed_with_retry.._embed_with_retry in 4.0 seconds as it raised RateLimitError: Requests to the Get a vector representation of a given input that can be easily consumed by machine learning models and algorithms. Operation under Azure OpenAI API version 2023-05-15 have exceeded call rate limit of your current OpenAI S0 pricing tier. Please retry after 2 seconds. Please go here: https://aka.ms/oai/quotaincrease if you would like to further increase the default rate limit..

I also meet this problem. But when I retry later, the bug is disappear. SOS

Can you please give me a source code which you used ?

I also meet this problem. But when I retry later, the bug is disappear. SOS

Can you please give me a source code which you used ?

My error report is slightly different from the title. I think it is a network problem caused by the langchain library. I cannot reproduce this problem with the previous code.
error like this:
Retrying langchain.embeddings.openai.embed_with_retry.._embed_with_retry in 4.0 seconds as it raised APIError: Invalid response object from API: '{ "statusCode": 500, "message": "Internal server error", "activityId": "xxxx" }' (HTTP response code was 500).
This bug doesn't happen again and doesn't affect me. Thank you~

Define following values in the code 👍:
openai.api_type = "azure"
os.environ["OPENAI_API_TYPE"] = "azure"
os.environ["OPENAI_API_KEY"] = "your api key"
os.environ["OPENAI_API_BASE"] = "put yours"
os.environ["OPENAI_API_VERSION"] = "2023-03-15-preview"
llm = AzureOpenAI(
api_key="your api key",
api_base="put yours",
api_version="2023-03-15-preview",
deployment_name="name of the deployment")
llm_embeddings = OpenAIEmbeddings(model="text-embedding-ada-002", chunk_size = 1)
this will definatily work with chroma,faisss db

Someone solved the issue?

@elorberb
Define following values in the code 👍:
openai.api_type = "azure"
os.environ["OPENAI_API_TYPE"] = "azure"
os.environ["OPENAI_API_KEY"] = "your api key"
os.environ["OPENAI_API_BASE"] = "put yours"
os.environ["OPENAI_API_VERSION"] = "2023-03-15-preview"
llm = AzureOpenAI(
api_key="your api key",
api_base="put yours",
api_version="2023-03-15-preview",
deployment_name="name of the deployment")
llm_embeddings = OpenAIEmbeddings(model="text-embedding-ada-002", chunk_size = 1)

In order to improve the embedding performance, you can set the chunk_size to 16,  but first need to update the version to "2023-07-01-preview",
os.environ["OPENAI_API_VERSION"] = "2023-07-01-preview"
and deployment name should not be forgotten,
embeddings = OpenAIEmbeddings(
        deployment="your deployment name",
        model="text-embedding-ada-002",
        chunk_size=16
)

What actually 16 does here?

the number of tasks processed in parallel

Ok Thanks

add time.sleep(7)

I got same problem.
Someone solved the issue?


[OTHER] Stake and Claim button

What would you like to share?
The Stake button in the hero component is a link to the Stake tab, and the Claim button displays a modal dialog.

https://pr.to/4K1MQA/

Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I expect this feature to be merged into preview branch and published as preview.stakes.social.

To develop the Claim modal, I think it's efficient to tweak the existing Withdraw component: packages/web/src/components/organisms/Withdraw/index.tsx


get_profile is missing information

Already set _scraper.mbasic_headers, and set base_url and start_url parameters to mbasic, and set cookies to be the same as the cookies contained in the headers. get_profile('LyricaGame', **options) gives
{'Friend_count': None, 'Follower_count': None, 'Following_count': None, 'Name': '陽春白雪・醉月 Lyrica: Drunken Moon'}

Much information is missing from this output.

@UlyssesZh That's a known issue, for certain pages and users. if you can create a PR for it, that would be very useful until i can update the repo

@UlyssesZh this issue should be resolved now, get_page_info can substitute get_profile and the former has the necessary info now

I am using get_page_info now. Looks good.


TooManyRestart: state filter for CrashLoopBackOff

Revert #1164
Address feedback from @damemi

Also as a follow up it might be useful to add a restartThreshold parameter for this specifically to evict pods that have crashlooped X times instead of crashlooping for X seconds

cc: @ingvagabund  @damemi
Please let me know if you prefer the revert in a separate PR

/retest

/retest-required

@damemi it does, but I am wanting to evict only pods in CrashLoopBackOff. For my use-case, if a pod has been restarted 20 times but it's running, I don't see any value in restarting it.

Wrt. https://github.com/kubernetes-sigs/descheduler/pull/1164#issue-1744696897:
  containerStatuses:
  - containerID: containerd://274b89ca9b2d7a815cf6550453af29663c114c51917358bb02330613d39fbb73
    ...
    restartCount: 3
    ...
    state:
      waiting:
        message: back-off 40s restarting failed container=rdescheduler-podlifetime pod=descheduler-podlifetime
        reason: CrashLoopBackOff
  phase: Running

A pod can be restarted many times but the reason for the restart can vary in time. There's currently no way of knowing what cause the previous restarts. We can only assume if a pod gets into CrashLoopBackOff state it is a repetitive event.
Both PodLifeTime and TooManyRestarts strategies have a lot in common. Either the reason for evicting is "too many restarts" or "running for too long". Too many restarts can be in a way converted to "running for too long" (e.g. depending on how the pod probes are configured). So both strategies are suitable for the new state/reason for eviction. So both evict pods in CrashLoopBackOff state for "some time" and "getting restarted too many times" are valid.
What about to merge both plugins into a single one? With the new v1alpha2 configuration one can configure the same strategy multiple times to get benefit of both.

Ok, I can work on that but I feel that these are substantial request for changes with API changes that also impact users.
If we can do this in multiple steps, that'd be ideal.

merge small change
come back refactor
upgrade API later to get rid of redundant plugins.

We can make the change as part of v1alpha3.
/approve

+1 to @ingvagabund's comments, these 2 plugins are converging in what they accomplish... I also think it's easier for people to understand that 1 plugin handles crashing/restarting/failing pods rather than know that a CrashLooping pod is technically Running and not "failed"
this lgtm, we can refactor later. I'd propose opening an issue to track and justify the reasoning
/lgtm


Added a meaningful message

Added a meaningful message

Change in the files:

lib/tabs/screens/tabs_screen.dart

After the firebase login is integrated I can change this to the user name

Hi @Yashs1623,
Thanks for the PR. Changes that are done on lib/tabs/screens/tabs_screen.dart seems fine but your commit also consists of changes in some other files as well. Can you please revert those files?


TIMESTAMP naming convention

Hi everyone,
thank you for all of the work and especially for the Db2 ZOS support! This tool is amazing and we use it now on a daily basis!
As we are currently working on making our tools production ready, we face some "bugs" at the moment and some smaller inconveniences. We found workarounds for it, but I thought it would be very beneficial to also communicate it. :)
The first issue is very simple: The TIMESTAMP column type in our Db2 ZOS Database is named as "TIMESTMP". So the "A" is missing. We are not sure why this happens, but we assume to stick to a maximum of 8 characters. We can fix this for our use-case by adding an entry to the ischema_names dictionary for "TIMESTMP" with the sqlalchemy type DateTime.
ibm_db_sa.base.ischema_names["TIMESTMP"] = DateTime
Is this even a good workaround? Would it be a good idea to add it to the package itself, as it might be a problem other people face when working with rather old Db2 ZOS databases. This might be an improvement as this could be an instant deal breaker for some developers trying this package for the first time.
Best regards,
Fjedor

Hi @FjedorGaede
Thanks a lot for the detailed explanation.
Let me have a look into the request a bit more and I will let you know.
I have to check for the impact on all servers and also the testing suite as how it behaves.
Let me have a more detailed look into this and come back.
Thanks.

As per IBM documentation for datatypes TIMESTAMP is the supported datatype.
https://www.ibm.com/docs/en/db2-for-zos/12?topic=columns-date-time-timestamp-data-types
Any modification to the datatypes or special datatypes has to be handled separately in the application code.
The above example of the code is a good way to handle any other datatypes.
Hence closing on the issue.


Thanks for raising a Swagger2Markup issue. Please provide a brief description of your problem along with the Swagger2Markup version you are using. If possible, please also consider putting together a complete Swagger specification that reproduces the issue. It's better if the Swagger specification is small and isolate the issue.
Swagger2Markup version: master commit c5cfe10fa6bf4af46920e03f31dad90c4295ce5a
Problem description:
I think it will be better to build this project inside docker container. In that way, I no longer need to install jdk, gradle on my machine. So is there any idea on add a Dockerfile in this repo?

Hi,
thx for your GitHub Star.
I created a Swagger2Markup image 2 days ago and published it on DockerHub.
See: https://github.com/Swagger2Markup/swagger2markup-cli/blob/master/Dockerfile
The Dockerfile can be improved and I would be happy to get help.
Just run docker pull swagger2markup/swagger2markup.
You can mount a directory to provide your config file.

Wow, good job.
I searched on DockerHub and found your repo before, but gave up due to no description and usage docs.
You can simply delete that repo, and create a new Automated Build one. ;-)

Its an automated build via Docker Cloud. But I guess the readme is missing, because the projects use AsciiDoc instead of Markdown for documentation.


Visual indication of external links

💥 Proposal
A visual indicator for each links that will open in new window. For an end user, it's a good experience to know that clicking on certain links will open up a new window.
Have you read the Contributing Guidelines on issues?
Yes

Actually this can be done in Docusaurus easily just by overriding your docusaurus custom.css
For example
a{ color : blue }
a:[target=_blank]{ color : green}

You might prefer different color, but some people might not. I personally prefer not having any difference between link that open in a new tab or not. I just prefer it blue.


EVEREST-587: wait for db before restore

CHANGE DESCRIPTION
Problem:
EVEREST-587
We did not wait for DB before initiating a restore.
Cause:
DB was not ready and the restore failed.
Solution:
Wait for DB before restore
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?

Tests

[ ] Is an Integration test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

PG uses a different mechanism, I believe it's not affected by the problem?

Yes, PG seems to handle this differently and is thus not affected.


Code Actions won't apply correctly

I can't tell if this is an issue with HIE or with LSP but I can't seem to get code-actions applying correctly.
HIE correctly suggests code hints like so:

But when I attempt to apply them it causes a new tab to a file called changes to get opened up.

This occurs on version Version <IP_ADDRESS>, Git revision 9e39517408fd2948c60ac49e56267c93051f8878 (1066 commits) x86_64 with LSP v0.4.0
Sublime logs:
2017-11-17 20:10:41.111253 [ThreadId 14] - applyHint:diff=WorkspaceEdit {_changes = Just (fromList [(Uri {getUri = "file:///Users/xavier/Code/xldenis/hake/src/Hake/Run.hs"},List [])]), _documentChanges = Nothing}:
2017-11-17 20:10:41.171287 [ThreadId 14] - applyOneCmd:file="/Users/xavier/Code/xldenis/hake/src/Hake/Run.hs":
2017-11-17 20:10:41.172049 [ThreadId 14] - applyOneCmd:res=Right (WorkspaceEdit {_changes = Just (fromList [(Uri {getUri = "file:///Users/xavier/Code/xldenis/hake/src/Hake/Run.hs"},List [])]), _documentChanges = Nothing}):
LSP: <--  workspace/applyEdit
LSP:      {'edit': {'changes': {'file:///Users/xavier/Code/xldenis/hake/src/Hake/Run.hs': []}}}
Unable to open /Users/xavier/Code/xldenis/hake/src/Hake/changes
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 812, in run_
    return self.run(edit, **args)
  File "plugin.core.edit in /Users/xavier/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package", line 44, in run
  File "plugin.core.edit in /Users/xavier/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package", line 44, in <genexpr>
  File "plugin.core.edit in /Users/xavier/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package", line 68, in create_region
TypeError: string indices must be integers

https://github.com/haskell/haskell-ide-engine/issues/356 cross-referencing

This is an LSP problem I recently introduced, apologies.
Fixed in commit https://github.com/tomv564/LSP/commit/629d10539ffbc7ad65eb9dc619d047405bf7373f

Thanks, I'll update from git and see if this resolves my problem.

Hmm they still don't apply but the logs show that LSP is no longer raising an error. This may just indicate that HIE isn't responding properly?

Can you retry with the log_debug setting set to true in the LSP settings? There is also a log_payloads setting in settings.py (we'll add this to the settings soon) which you can set to true for extra details.
Alternatively, does HIE have logging output?

I've enabled all the logging options I found in HIE and LSP here's what I got
haskell-lsp:Starting up server ...:
2017-11-23 22:08:59.448923 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 1, "method": "initialize", "params": {"capabilities": {"workspace": {"applyEdit": true}, "textDocument": {"completion": {"completionItem": {"snippetSupport": true}}, "synchronization": {"didSave": true}}}, "rootPath": "/Users/xavier/Code/xldenis/ill", "rootUri": "file:///Users/xavier/Code/xldenis/ill", "processId": 79892}}:
2017-11-23 22:08:59.45184 [ThreadId 11] - haskell-lsp:initializeRequestHandler: setting current dir to project root:/Users/xavier/Code/xldenis/ill:
LSP:  --> initialized
LSP: hie client registered for window 5
2017-11-23 22:08:59.452641 [ThreadId 12] - <--2--{"result":{"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"willSave":false,"willSaveWaitUntil":false,"save":{"includeText":false}},"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":["."]},"definitionProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"documentFormattingProvider":true,"documentRangeFormattingProvider":true,"renameProvider":true,"executeCommandProvider":{"commands":["applyrefact:applyOne","hare:demote"]}}},"jsonrpc":"2.0","id":1}:
2017-11-23 22:08:59.453423 [ThreadId 11] - ---> {"jsonrpc": "2.0", "method": "initialized", "params": {}}:
2017-11-23 22:08:59.455698 [ThreadId 15] - ****** reactor: processing Initialized Notification:
2017-11-23 22:08:59.456486 [ThreadId 12] - <--2--{"jsonrpc":"2.0","id":0,"method":"client/registerCapability","params":{"registrations":[{"registerOptions":{"documentSelector":{"language":"haskell"}},"method":"workspace/executeCommand","id":"hare:demote"}]}}:
LSP:  --> textDocument/didOpen
LSP: <--  client/registerCapability
LSP: Unhandled request client/registerCapability
2017-11-23 22:08:59.494693 [ThreadId 11] - ---> {"jsonrpc": "2.0", "method": "textDocument/didOpen", "params": {"textDocument": {"version": 0, "languageId": "haskell", "text": "module Ill.Desugar\n( module Ill.Desugar\n, module X\n) where\n\nimport Ill.Syntax hiding (Expression(..), ty)\nimport Ill.Syntax.Core as C\n\nimport qualified Ill.Syntax as S\n\nimport Ill.Desugar.Trait as X\nimport Ill.Desugar.Cases as X\nimport Ill.Desugar.BinOp as X\n\nimport Control.Monad.State\n\nimport Data.Maybe\nimport Data.List\n\ntype Id = Name\n\n{-\n  Syntax definition for core lambda calculus representation\n\n  At this point all top level bindings should have cases pushed in,\n  traits should have been desugared.\n\n  Data constructors are still kept as implicit bindings\n  to variables with the name of the contrsuctor.\n-}\n\ndeclsToCore :: [Decl TypedAnn] -> CoreModule\ndeclsToCore decls = execState (mapM declToCore' decls) (Mod [] [])\n\ndeclToCore' :: Decl TypedAnn -> State CoreModule ()\ndeclToCore' (a :< Value nm [([], exp)]) = do\n  let bindExp = (toCore exp)\n\n  modify $ \\m -> m { bindings = NonRec binder bindExp : bindings m }\n  where\n  unforall (Forall tVars _) = tVars\n  unforall _                = []\n\n  binder = Id { varName = nm, idTy = fromTyAnn a, usage = Used }\ndeclToCore' (_ :< Data nm args conses) = do\n  let cons' = map (\\cons ->\n        case unwrapProduct cons of\n          (TConstructor consNm : args) -> (consNm, (length args, getConstructorType cons))\n        ) conses\n  modify $ \\m -> m { constructors = cons' ++ constructors m }\n  where\n  getConstructorType ty = let\n    (TConstructor tyCons : tys) = unwrapProduct ty\n    retTy = foldl TAp (TConstructor nm) (map TVar args)\n    in generalize $ foldr tFn retTy tys\ndeclToCore' (_) = pure ()\n\n{-\n  Get the type applications needed for a type annotation\n-}\ngetTypeApps :: TypedAnn -> [CoreExp]\ngetTypeApps t = map (C.Type . snd) subst\n  where\n  subst = case join $ subsume <$> (pure . unForall . polyTy $ S.ty t) <*> ((instTy $ S.ty t)) of\n    Just l -> filter (\\(v, _) -> v `elem` boundVars (polyTy $ S.ty t)) l\n    Nothing -> []\n\n  boundVars (Forall vs _) = vs\n  boundVars _ = []\n\n  unForall (Forall _ t) = t\n  unForall t = t\n\ntoCore :: Expr TypedAnn -> CoreExp\ntoCore var@(a :< S.Var nm) = foldl App (Var nm) (getTypeApps a)\ntoCore cons@(a :< S.Constructor nm) = foldl App (Var nm) (getTypeApps a)\ntoCore (_ :< S.Case scrut alts) = Case (toCore scrut) (toAlts alts)\ntoCore (_ :< S.Assign names exprs) = error \"assignments must be desugared in blocks\"\ntoCore (a :< S.Apply lam args) = foldl App (toCore lam) $ (map toCore args) ++ (getTypeApps a)\ntoCore (_ :< S.BinOp op left right) = error \"binops should have been desugared to assigns\"\ntoCore (_ :< S.If cond left right) = Case (toCore cond)\n  [ ConAlt \"True\" [] (toCore left)\n  , ConAlt \"False\" [] (toCore right)\n  ]\ntoCore (lAnn :< S.Lambda bind exp) = let\n  vars = map toVar bind\n  tyVars = map toTyVar (boundVars $ fromTyAnn lAnn)\n  in foldr Lambda (toCore exp) (tyVars ++ vars)\n  where\n  toVar (a :< S.PVar nm) = Id { varName = nm, idTy = fromTyAnn a, usage = Used }\n  isVarPat (_ :< S.PVar _) = True\n  isVarPat _ = False\n\n  boundVars (Forall vs _) = vs\n  boundVars _ = []\n\n  toTyVar tyvar = TyVar { varName = tyvar, kind = Star }\ntoCore (_ :< S.Body exps) = toCore' exps\n  where\n  toCore' :: [Expr TypedAnn] -> CoreExp\n  toCore' ((_ :< a@(S.Assign _ _ )): []) = error (show a) -- i think? i dont like this :(\n  toCore' ((_ :< S.Assign names exprs) : others) = let\n    binders = map toBinder $ zip names exprs\n    toBinder (nm, expr) = NonRec (Id nm (typeOf expr) Used) (toCore expr)\n    in foldr Let (toCore' others) binders\n  toCore' [e] = toCore e\n  toCore' (e:others) = toCore e `mkSeq` (toCore' others)\n    where\n    mkSeq a b = (App (App (Var \"seq\") a) b)\ntoCore (_ :< S.Literal lit ) = Lit lit\n\ntoAlts = map toAlt\n\ntoAlt (a :< Wildcard, e) = TrivialAlt $ toCore e\ntoAlt (_ :< PLit lit, exp) = LitAlt lit $ toCore exp\ntoAlt (_ :< Destructor n ps, exp) = ConAlt n (map toVar ps) $ toCore exp\n  where\n  toVar (a :< Wildcard) = Id \"\" (fromTyAnn a) NotUsed\n  toVar (a :< PVar nm)  = Id nm (fromTyAnn a) Used\n  toVar a = error (show a)\n", "uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}}}:
2017-11-23 22:08:59.512948 [ThreadId 15] - ****** reactor: processing NotDidOpenTextDocument:
2017-11-23 22:08:59.604717 [ThreadId 14] - dispatcherP: top of loop:
2017-11-23 22:08:59.605089 [ThreadId 14] - got request with id: Nothing:
Using hoogle db at: /Users/xavier/.hoogle/default-haskell-5.0.13.hoo:
2017-11-23 22:08:59.608648 [ThreadId 14] - dispatcherP: top of loop:
2017-11-23 22:08:59.608749 [ThreadId 12] - <--2--{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":4,"message":"Using hoogle db at: /Users/xavier/.hoogle/default-haskell-5.0.13.hoo"}}:
2017-11-23 22:08:59.609029 [ThreadId 14] - got request with id: Nothing:
2017-11-23 22:08:59.757598 [ThreadId 14] - dispatcherP: top of loop:
2017-11-23 22:08:59.758194 [ThreadId 14] - got request with id: Nothing:
2017-11-23 22:08:59.758778 [ThreadId 14] - Processing request as version matches:
2017-11-23 22:08:59.838272 [ThreadId 14] - dispatcherP: top of loop:
2017-11-23 22:08:59.838537 [ThreadId 14] - got request with id: Nothing:
2017-11-23 22:08:59.839375 [ThreadId 14] - Processing request as version matches:
LSP: <--  textDocument/publishDiagnostics
2017-11-23 22:08:59.9826 [ThreadId 12] - <--2--{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs","diagnostics":[{"severity":4,"range":{"start":{"line":35,"character":42},"end":{"line":38,"character":68}},"source":"hlint","message":"Redundant bracket\nFound:\n  do let bindExp = (toCore exp)\n   modify $ \\ m -> m{bindings = NonRec binder bindExp : bindings m}\nWhy not:\n  do let bindExp = toCore exp\n   modify $ \\ m -> m{bindings = NonRec binder bindExp : bindings m}\n"},{"severity":2,"range":{"start":{"line":55,"character":12},"end":{"line":55,"character":15}},"source":"hlint","message":"Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n"},{"severity":4,"range":{"start":{"line":63,"character":74},"end":{"line":63,"character":93}},"source":"hlint","message":"Redundant bracket\nFound:\n  ((instTy $ S.ty t))\nWhy not:\n  (instTy $ S.ty t)\n"},{"severity":4,"range":{"start":{"line":78,"character":58},"end":{"line":78,"character":94}},"source":"hlint","message":"Redundant bracket\nFound:\n  (map toCore args) ++ (getTypeApps a)\nWhy not:\n  (map toCore args) ++ getTypeApps a\n"},{"severity":4,"range":{"start":{"line":78,"character":58},"end":{"line":78,"character":94}},"source":"hlint","message":"Redundant bracket\nFound:\n  (map toCore args) ++ (getTypeApps a)\nWhy not:\n  map toCore args ++ (getTypeApps a)\n"},{"severity":4,"range":{"start":{"line":100,"character":10},"end":{"line":100,"character":40}},"source":"hlint","message":"Use list literal pattern\nFound:\n  ((_ :< a@(S.Assign _ _)) : [])\nWhy not:\n  [(_ :< a@(S.Assign _ _))]\n"},{"severity":4,"range":{"start":{"line":102,"character":14},"end":{"line":102,"character":44}},"source":"hlint","message":"Use zipWith\nFound:\n  map toBinder $ zip names exprs\nWhy not:\n  zipWith (curry toBinder) names exprs\n"},{"severity":4,"range":{"start":{"line":106,"character":23},"end":{"line":106,"character":56}},"source":"hlint","message":"Redundant bracket\nFound:\n  toCore e `mkSeq` (toCore' others)\nWhy not:\n  toCore e `mkSeq` toCore' others\n"},{"severity":4,"range":{"start":{"line":108,"character":16},"end":{"line":108,"character":43}},"source":"hlint","message":"Redundant bracket\nFound:\n  (App (App (Var \"seq\") a) b)\nWhy not:\n  App (App (Var \"seq\") a) b\n"}]}}:
hie: /Users/xavier/.stack/programs/x86_64-osx/ghc-8.2.1/lib/ghc-8.2.1/package.conf.d/package.cache: GHC.PackageDb.readPackageDb: inappropriate type (Not a valid Unicode code point!):
LSP:  --> textDocument/didSave
2017-11-23 22:09:06.273538 [ThreadId 11] - ---> {"jsonrpc": "2.0", "method": "textDocument/didSave", "params": {"textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}}}:
LSP:  --> textDocument/codeAction
2017-11-23 22:09:14.072273 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 2, "method": "textDocument/codeAction", "params": {"context": {"diagnostics": [{"range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}, "source": "hlint", "message": "Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n", "severity": 2}]}, "textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}, "range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}}}:
LSP:  --> textDocument/codeAction
2017-11-23 22:09:14.685736 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 3, "method": "textDocument/codeAction", "params": {"context": {"diagnostics": [{"range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}, "source": "hlint", "message": "Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n", "severity": 2}]}, "textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}, "range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}}}:
LSP:  --> textDocument/codeAction
2017-11-23 22:09:14.902591 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 4, "method": "textDocument/codeAction", "params": {"context": {"diagnostics": [{"range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}, "source": "hlint", "message": "Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n", "severity": 2}]}, "textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}, "range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}}}:
LSP:  --> textDocument/codeAction
2017-11-23 22:09:15.102978 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 5, "method": "textDocument/codeAction", "params": {"context": {"diagnostics": [{"range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}, "source": "hlint", "message": "Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n", "severity": 2}]}, "textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}, "range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}}}:
LSP:  --> textDocument/codeAction
2017-11-23 22:09:15.319656 [ThreadId 11] - ---> {"jsonrpc": "2.0", "id": 6, "method": "textDocument/codeAction", "params": {"context": {"diagnostics": [{"range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}, "source": "hlint", "message": "Redundant bracket\nFound:\n  (_)\nWhy not:\n  _\n", "severity": 2}]}, "textDocument": {"uri": "file:///Users/xavier/Code/xldenis/ill/src/Ill/Desugar.hs"}, "range": {"start": {"line": 55, "character": 12}, "end": {"line": 55, "character": 15}}}}:

The closes thing to an error or lead on the problem I can find is the line
hie: /Users/xavier/.stack/programs/x86_64-osx/ghc-8.2.1/lib/ghc-8.2.1/package.conf.d/package.cache: GHC.PackageDb.readPackageDb: inappropriate type (Not a valid Unicode code point!):

I tried this code action with a simple generated stack LTS 9 project  by duplicating the import Lib in Main.hs:
LSP:  --> textDocument/codeAction
LSP:      [{'command': 'applyrefact:applyOne', 'arguments': [{'start_pos': {'character': 0, 'line': 2}, 'file': 'file:///Users/tomv/Projects/tomv564/hello-world-hs/app/Main.hs'}], 'title': 'Apply hint:Use fewer imports'}]
LSP:  --> workspace/executeCommand
LSP: <--  workspace/applyEdit
LSP:      {'edit': {'changes': {'file:///Users/tomv/Projects/tomv564/hello-world-hs/app/Main.hs': []}}}

While HIE logs:
2017-11-25 15:30:29.580253 [ThreadId 10] - applyHint:ideas=[/private/var/folders/_r/0qgd5krn3s7f6_n6t6kn3v100000gn/T/ghc-mod73563/Main16807282475249.hs:1:1: Ignore: Use module export list:LSP:
Found::
      {}
module Main where:
Why not::
module Main (module Main) where:
Note: An explicit list is usually better:

,/private/var/folders/_r/0qgd5krn3s7f6_n6t6kn3v100000gn/T/ghc-mod73563/Main16807282475249.hs:3:1: Warning: Use fewer imports:
Found::
import Lib:
import Lib:
Why not::
import Lib:
]:
2017-11-25 15:30:29.595122 [ThreadId 10] - applyHint:diff=WorkspaceEdit {_changes = Just (fromList [(Uri {getUri = "file:///Users/tomv/Projects/tomv564/hello-world-hs/app/Main.hs"},List [])]), _documentChanges = Nothing}:
2017-11-25 15:30:29.598587 [ThreadId 10] - applyOneCmd:file="/Users/tomv/Projects/tomv564/hello-world-hs/app/Main.hs":
2017-11-25 15:30:29.599093 [ThreadId 10] - applyOneCmd:res=Right (WorkspaceEdit {_changes = Just (fromList [(Uri {getUri = "file:///Users/tomv/Projects/tomv564/hello-world-hs/app/Main.hs"},List [])]), _documentChanges = Nothing}):

It looks like the handler for the applyrefact:applyOne command (applyHint?) is having difficulty producing edits for the given refactoring title?

Yea, from what I can tel lthe issue lies on the HIE side of things but I'm having a hard time getting an answer / input on that side.

I'm going to close this for now.


Port to BlueBuild

Instructions at: https://blue-build.org/blog/introducing-bluebuild/

Done by 617a103912d82f1f051815aff400e6ca1ca78e80


Issue with imports in TypeScript

I am following some of the demos in docs and I face issues when importing elements as described in the docs. Here's an example:
import Dialog, { DialogActions, DialogContent, DialogTitle } from 'material-ui/Dialog';
To fix, I have to turn this into individual imports, which makes the code very tedious:
import Dialog from 'material-ui/Dialog/Dialog';
import DialogContent from 'material-ui/Dialog/DialogContent';
import DialogTitle from 'material-ui/Dialog/DialogTitle';
import DialogActions from 'material-ui/Dialog/DialogActions';

It seems that TS does not correctly understand the module export format declared in Dialog/index.d.ts. This happens for other modules. Any ideas on how to get this fixed?

@semiadam this works fine for me in<EMAIL_ADDRESS>What version of are you using?

I just upgraded from beta.20 to beta.21, but I still get the same error. I'm on TypeScript 2.6.1, under create-react-app package.
import { DialogActions }  from 'material-ui/Dialog';

 error TS2305: Module ''material-ui/Dialog'' has no exported member 'DialogActions'.

@semiadam what does your tsconfig.json look like?

@semiadam ah, I have a hunch... do you have @types/material-ui installed? Those typings apply to the pre-v1 version of material-ui, whereas with v1 the typings are built in. If you still have @types/material-ui installed you should remove it as it is probably interfering with the built-in types.

{
  "compilerOptions": {
    "outDir": "build/dist",
    "module": "esnext",
    "target": "es5",
    "lib": [
      "es6",
      "dom"
    ],
    "sourceMap": true,
    "allowJs": true,
    "jsx": "react",
    "moduleResolution": "node",
    "experimentalDecorators": true,
    "rootDir": "src",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": false,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": false
  },
  "exclude": [
    "node_modules",
    "build",
    "scripts",
    "acceptance-tests",
    "webpack",
    "jest",
    "src/setupTests.ts"
  ],
  "include": [
    "./src/**/*.ts",
    "./src/**/*.tsx"
  ]
}

@pelotom very smart! Removing @type/material-ui fixed it! Man, this had given me so much headache and type weirdness all this time!


#109 - Completed.

@rultor merge

@rultor merge

@driver733 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@driver733 Done! FYI, the full log is here (took me 2min)

Changes Unknown when pulling 4e7298c361aab1edf16007c31c90fbb13e1ef968 on #109 into ** on master**.


Server crashes after death

Screenshot of the error:

I'm running a server with latest fabric release and these mods

After some searching, I found out that this is a problem with Pehkui 2.0.0

Huh
I tried to run the mod with older versions of Pekhui, but I literally couldn't open my game (It crashed)
Anyone know why?
I had Fabric API, Patchouli, and several origins mods

I've had the same problem. Every time I die It crashes the server I'm on. I even switched pekhui versions and I was smaller but then died and it crashed. (I switched to the latest) I'm playing 1.16.5 so I used that one then used The 1.14.4-1.17. Version and I shrunk but it still crashed when I died I can't find any fixes

After some searching, I found out that this is a problem with Pehkui 2.0.0
Not closing the issue yet, as either a version check should be implemented, or a note on CurseForge should be made.

So is there a specific version needed to make it work (that isn't 2.00) or is there another fix?

@Rustwolfz I used this with Pehkui 1.10.0 and everything worked fine

@AadityaY please, send your crash reports, that would help find the issue

I think this has to do with the new version of pehkui kicking and crashing u when u get to 0 width 0 height

I think preventing it from being zero (changing min and fall back on slime ClampedEntityAttribute of slime size should do it

@Rustwolfz I used this with Pehkui 1.10.0 and everything worked fine

This would work however, Extra Origins, another addon I'm using, requires Pehkui 2.0.0. Is there a work around to this that you know of?

Here, for those of you with this issue, I patched it myself super fast to make it work, it was only a tiny bit of code I needed to change, and might make a pull request shortly with my code changes if the dev wants to pick them up
https://drive.google.com/file/d/1tFouUCXfMmx-1y_d7gvOaZitbi_Yb5sj/view?usp=sharing

@MrLightningBlaze how can i install it onto a server??? aternos btw

@CritzenMC Its the exact same process as the original mod, I mearly updated some code in it to fix the crashing issue

@MrLightningBlaze could you add your changes as a pull request to the repo so that it might be able to be merged?

@MrLightningBlaze could you add your changes as a pull request to the repo so that it might be able to be merged?

#10 incorporates your fixes as a PR - hopefully, it'll get merged soon!

Thank you so much @MrLightningBlaze and @pengolod this has been fixed in v3.0.0


chore: add LICENSE, resolve #15

:tada: This PR is included in version 1.4.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


refactor(react): remove useIsomorphicLayoutEffect in usePreservedCallback

Overview
I understand that using functions like useEffect to update state and values received via props is not recommended because it adds unnecessary processes. Especially since there’s only one prop, I don’t think it’s necessary to use it. Therefore, I have removed that part.
If there’s anything I might be missing, please let me know! Thank you.

And I thought that the dependencies array in useEffect would be meaningless because usePreservedCallback(() => {}) is typically used this way, meaning the callback will always receive a new reference value.

Reference: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.92%. Comparing base (7748f54) to head (2068b48).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
- Coverage   76.96%   76.92%   -0.05%
==========================================
  Files          66       66
  Lines         508      507       -1
  Branches      112      112
==========================================
- Hits          391      390       -1
  Misses        111      111
  Partials        6        6

Components
Coverage Δ

@suspensive/react
100.00% <100.00%> (ø)

@suspensive/react-dom
100.00% <ø> (ø)

@suspensive/react-native
100.00% <ø> (ø)

@suspensive/react-query
73.07% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)

https://github.com/juliencrn/usehooks-ts/blob/master/packages/usehooks-ts/src/useTimeout/useTimeout.ts
Thank you for your question about where the performance can be improved. And I need your help.
We just imitate usehooks-ts's useTimeout. We just use that because usehooks-ts is famous and reliable library. so our code is same with its. Could you investigate why they use useIsomorphicLayoutEffect?

In my opinion, stability is the key consideration. Stability is crucial for libraries, as they need to guarantee consistent results in all scenarios. By using useIsomorphicLayoutEffect in React’s lifecycle process, the intention was likely to ensure the same outcome in every situation.
Without it, unintended behaviors might occur in certain cases (such as abnormal rendering due to specific conditions, asynchronous operations, or interference from parent components). It seems like useIsomorphicLayoutEffect was employed as a stability mechanism to produce consistent results.

In my opinion, stability is the key consideration. Stability is crucial for libraries, as they need to guarantee consistent results in all scenarios. By using useIsomorphicLayoutEffect in React’s lifecycle process, the intention was likely to ensure the same outcome in every situation.
Without it, unintended behaviors might occur in certain cases (such as abnormal rendering due to specific conditions, asynchronous operations, or interference from parent components). It seems like useIsomorphicLayoutEffect was employed as a stability mechanism to produce consistent results.

I have same opinion

@gwansikk But we use our useTimeout only in Delay
Must we use useIsomorphicLayoutEffect? and useEffect? Actually I can't know why we need to useTimeout containing useIsomorpicLayoutEffect. isn't it enough nothing like @dayongkr's implementation?

I think useIsomorphicLayout was used to prevent the ref from changing during the paint process when the callback passed to useTimeout changes. However, Suspensive does not provide useTimeout as a public API, so it can guarantee that the callback passed to useTimeout cannot change.
Then, it would be better to optimize it as implemented by @dayongkr, but I wonder what @gwansikk, @dayongkr thinks. (I think it might take some time. Please reply slowly.)

isn't it enough nothing like @dayongkr's implementation?

Exactly. Currently, we are using usePreservedCallback internally, and we are not exposing useTimeout to users. In that case, I believe following @dayongkr’s approach should be sufficient.
However, could there be a scenario in the future where we use usePreservedCallback directly to create APIs? (While I don’t expect this to happen.) Or, could there be a case where a callback passed to usePreservedCallback is injected as a component prop in a future interface?

However, Suspensive does not provide useTimeout as a public API, so it can guarantee that the callback passed to useTimeout cannot change.

If there’s no chance that it will be exposed externally or directly used in a component and provided as an interface in the future, then I agree with @dayongkr!

I remove unecessary useIsomorphicLayoutEffect too in 3403e8c

I tried to find the commits to understand why they were used, but I couldn’t find any reason. As far as I know, useLayoutEffect is used to delay the invocation of an effect until the commit phase, particularly when using DOM properties. In most cases, it’s hard to observe noticeable benefits from this, and even with a very slow computer(20x slowdown CPU), flickering issues are barely visible.
Anyway, if we are not manipulating the DOM within the effect, I believe there’s no need to delay the invocation until after the commit phase!

I also removed usePreservedCallback too in useTimeout with @dayongkr's implementation in 0f7bdc7
We don't have to maintain it as internal api when we need to do it. Let's make that!

I tried to find the commits to understand why they were used, but I couldn’t find any reason. As far as I know, useLayoutEffect is used to delay the invocation of an effect until the commit phase, particularly when using DOM properties. In most cases, it’s hard to observe noticeable benefits from this, and even with a very slow computer(20x slowdown CPU), flickering issues are barely visible.

Some of the information was incorrect, so I have revised it for future reference: Both useEffect and useLayoutEffect are executed after a commit. However, useLayoutEffect runs synchronously before the browser paints, causing a blocking effect that can result in slower performance.


gratibot does not ignore links

Problem
When Gratibot reviews a message is it tagged in for any x* or *x multipliers for fist bumps, it will consider any string in the message, even if the found multiplier is in a link.
An example:
:fistbump: was used in the same message as the link https://docs.google.com/document/d/1dFNbxDr82Ln3mNx4bS3p
Gratibot saw the x4 in the link and multiplied the fist bump by 4 when that was not the intention of the person handing out the gratitude.

Wow, great catch!
Here's the relevant code for future reference:

multiplierRegex variable
message parsing

Current behavior:

current regex return the first match for /x([0-9]+)/
current regex considers the entire message as a string

I thinks there's probably two routes.
Ignoring any strings with http or expecting a leading space for x*


first load whoami and then load all data

when an anonymous gets some data and logs on later, then he could have castrated data

see also #1460

As a workaround http://www.js-data.io/docs/dsclear can be called when the operator changes. Either be adding a callback to operator.onOperatorChange()
(See https://github.com/OpenSlides/OpenSlides/blob/2307bdc188753c4123db01096e154addda3d6a74/openslides/core/static/js/core/site.js#L37 as example)
or by adding the function at the beginning of loadGlobalData

@ostcar I added DS.clear() to loadGlobalData, see https://github.com/OpenSlides/OpenSlides/compare/master...emanuelschuetze:fix1820?expand=1
But this does not fixed this issue.  Can you test it please!
My test: reload users list for anonymous, log in as admin, go to users data

Again a more detailed instruction how to reproduce the current problem with DS.clear() in my test branch:

open (reload) /users/ as anonymous user -> no users visible in table!
click to elections and back to users -> all x users visible
now, login as admin and go to /users/ -> all x users visible (with internal data, like comments)

So, still open: (1) should show all users (after reload!). DS.clear() seems to be clear to much here?
@ostcar Any hint?

New suggestion pushed with reload page after login/logout. See #2003.
I discussed with @ostcar the problem with DS.clear(). Here the summary:
The callbacks will be called if the response of Group.findAll() is back. In this time the other requests (e.g. motion.findAll()) are called.
There are two solutions (for the record):

send all requests only then if whoami request is finished (very erffortful, maybe impossible!)
create a new view or adapt whoami which gives back the request.user and all groups of request.user. If the group data are available after reload in whoami then OpenSlides does not have to wait on separate group request.

Hm. This is maybe not completely solved, see also #1460.

@emanuelschuetze I don't remember the last status of our discussion. Maybe move milestone.

This issue should be done if #1460 is fixed. Moved to  milestone 2.1.

see #2854


Fix fisheye sampling to valid coordinates

I guess during a bug fix the exported "fisheye crop radius" changed from a 0 to 1 value to a pixel value, and so we no longer need to multiply by half the image size. Using a clamp here to ensure no values go out of bounds as well

I also made this fix last night: #2954. Do you have a preference on which to merge?

You can go for it @brentyi !


[Bug] The interface definition of queryMessage is not clear, and the query result may exceed the maxNum passed.

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
none
RocketMQ version
4.x, 5.x
JDK Version
No response
Describe the Bug
When multiple brokers are involved, the internal implementation of this SDK is to query simultaneously and aggregate the results. In this way, each broker may return up to 64 records. Currently, there is no truncation in place for the final result, so it may exceed the parameter setting.
Steps to Reproduce
review the code
What Did You Expect to See?
return size <=maxNum
What Did You See Instead?
return size > maxNum
Additional Context
No response

There are also some bug with the current local disk Index design, such as filtering when hashing, which results in incorrect number of returned message num.


Docker on MacOS and ha-bridge

I'm using the dockerized version of ha-bridge and am having issues with Alexa discovering the bridge.  I had all of this working prior to trying docker.
Originally I had ha-bridge running on 80/tcp, but in docker, using 80 as a privileged port and trying to get that going proved to be an issue.  So went back to using 8080, forwarded 8080/tcp 1900/udp and 50000/udp to the container and still having issues.  The web interface works fine, just can't get Alexa to discover it.
`2016-10-28 20:03:14,298 [main] INFO  com.bwssystems.HABridge.HABridge - HA Bridge (v3.2.0) starting....
2016-10-28 20:03:14,347 [main] INFO  com.bwssystems.HABridge.BridgeSettings - reading from config file: data/habridge.config
2016-10-28 20:03:14,575 [main] WARN  com.bwssystems.HABridge.BridgeSettings - The upnp config address, <IP_ADDRESS>, does not match any known IP's on this host.
2016-10-28 20:03:14,576 [main] INFO  com.bwssystems.HABridge.HABridge - HA Bridge (v3.2.0) initializing....
2016-10-28 20:03:14,629 [main] INFO  com.bwssystems.HABridge.SystemControl - System control service started....
2016-10-28 20:03:15.064:INFO::Thread-0: Logging initialized @1891ms
2016-10-28 20:03:15,400 [Thread-0] INFO  spark.webserver.JettySparkServer - == Spark has ignited ...
2016-10-28 20:03:15,416 [Thread-0] INFO  spark.webserver.JettySparkServer - >> Listening on <IP_ADDRESS>:8080
2016-10-28 20:03:15.428:INFO:oejs.Server:Thread-0: jetty-9.3.z-SNAPSHOT
2016-10-28 20:03:15.610:INFO:oejs.ServerConnector:Thread-0: Started ServerConnector@5143fdc1{HTTP/1.1,[http/1.1]}{<IP_ADDRESS>:8080}
2016-10-28 20:03:15.612:INFO:oejs.Server:Thread-0: Started @2443ms
2016-10-28 20:03:15,955 [main] INFO  com.bwssystems.harmony.HarmonyServer - setup initiated ....
2016-10-28 20:03:18,934 [main] INFO  com.bwssystems.harmony.HarmonyServer - activity changed: [-1] PowerOff
2016-10-28 20:03:18,970 [main] INFO  com.bwssystems.HABridge.devicemanagmeent.DeviceResource - HABridge device management service started....
2016-10-28 20:03:19,073 [main] INFO  com.bwssystems.HABridge.upnp.UpnpSettingsResource - Hue description service started....
2016-10-28 20:03:19,085 [main] INFO  com.bwssystems.util.UDPDatagramSender - Initializing UDP response Seocket...
2016-10-28 20:03:19,096 [main] INFO  com.bwssystems.util.UDPDatagramSender - UDP response Seocket initialized to: 50000
2016-10-28 20:03:19,380 [main] INFO  com.bwssystems.HABridge.hue.HueMulator - Hue emulator service started....
2016-10-28 20:03:19,415 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - UPNP Discovery Listener starting....
2016-10-28 20:03:19,416 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: eth0 ... has addr /fe80:0:0:0:42:acff:fe11:2%eth0
2016-10-28 20:03:19,417 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: eth0 ... has addr /<IP_ADDRESS>
2016-10-28 20:03:19,417 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: Adding eth0 to our interface set
2016-10-28 20:03:19,417 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: lo ... has addr /0:0:0:0:0:0:0:1%lo
2016-10-28 20:03:19,417 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: lo ... has addr /<IP_ADDRESS>
2016-10-28 20:03:19,418 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: Adding lo to our interface set
2016-10-28 20:03:19,418 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - UPNP Discovery Listener running and ready....
2016-10-28 20:03:20,814 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: isSSDPDiscovery found message to be an M-SEARCH message.
2016-10-28 20:03:20,815 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: isSSDPDiscovery found message to be valid under strict rules - strict: true
2016-10-28 20:03:20,815 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: SSDP packet from <IP_ADDRESS>:46067, body: M-SEARCH * HTTP/1.1
MX: 1
ST: upnp:rootdevice
MAN: "ssdp:discover"
User-Agent: UPnP/1.0 DLNADOC/1.50 Platinum/<IP_ADDRESS>
Host: <IP_ADDRESS>:1900
Connection: close
2016-10-28 20:03:20,818 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate1 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: upnp:rootdevice
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee::upnp:rootdevice

2016-10-28 20:03:20,821 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate2 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: uuid:2f402f80-da50-11e1-9b23-00008800bbee
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee
2016-10-28 20:03:20,822 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate3 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: urn:schemas-upnp-org:device:basic:1
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee
2016-10-28 20:03:20,823 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: isSSDPDiscovery found message to be an M-SEARCH message.
2016-10-28 20:03:20,823 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: isSSDPDiscovery found message to be valid under strict rules - strict: true
2016-10-28 20:03:20,824 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: SSDP packet from <IP_ADDRESS>:46067, body: M-SEARCH * HTTP/1.1
MX: 1
ST: upnp:rootdevice
MAN: "ssdp:discover"
User-Agent: UPnP/1.0 DLNADOC/1.50 Platinum/<IP_ADDRESS>
Host: <IP_ADDRESS>:1900
Connection: close

2016-10-28 20:03:20,825 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate1 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: upnp:rootdevice
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee::upnp:rootdevice

2016-10-28 20:03:20,827 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate2 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: uuid:2f402f80-da50-11e1-9b23-00008800bbee
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee
2016-10-28 20:03:20,830 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Traceupnp: sendUpnpResponse discovery responseTemplate3 is <<<HTTP/1.1 200 OK
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
EXT:
LOCATION: http://<IP_ADDRESS>:8080/description.xml
SERVER: Linux/3.14.0 UPnP/1.0 IpBridge/1.15.0
hue-bridgeid: 000088FFFE00BBEE
ST: urn:schemas-upnp-org:device:basic:1
USN: uuid:2f402f80-da50-11e1-9b23-00008800bbee

`

The container requires to be run in host mode. I have not been able to get it to work with forwarding  specific ports

So, in other words, it won't work on Docker for Mac then since the docker implementation runs on a hypervisor and can't use host mode.

Again, I don't know how it runs on mac, but I ran this container on a VM (kvm) and it worked fine. I used the vm's ip address in the settings,  and not the host machine's

I assuming you were using bridged networking then?  in docker, the ip address the docked app gets isn't routable, so if it presented it to Alexa, Alexa wouldn't know how to route back to it.

No, host mode. I was using the VM's IP, not the docker container's or the host's. Container one isn't accessible from the lan.
I had a host (unraid), a VM running on it (linux), the VM had docker installed and ran this container in host mode. Just like your mac is running docker in a VM. If that VM is getting its own IP from the router,  use that

So, I am assuming this is not an ha-bridge issue and should be closed.

That's right, it is docker specific.
But out of curiosity, what incoming ports does this app use? Docker needs to forward all incoming ports to the container. I got around it by forcing host mode, which forwards all ports, but it may not work in all cases as described above.
I tried to forward 8080 (web gui), 1900 and 50000 as markstubb also tried but it doesn't work. Does this app open random ports to listen on apart from the three listed?
Thanks

The default is now port 80 for the web side. 1900 is still used for multicast udp and 50000 is just used for response, so it does not need to be forwarded. Will Docker forwarding deal with multicast?

hmm, this may perhaps be the issue: https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1327442
It says that when multicast udp is forwarded, it changes the source address to docker's internal IP.
I'll look into it further. At least this gives me a starting point. Thanks.
You can close this issue.


dohoudaniel - Add solution of calculator in JavaScript (NodeJS)

Senior dev Daniel, it is an honour to review your PR.


Unicode error in get_pid_list()

This was mentioned in a Flexx issue (https://github.com/flexxui/flexx/issues/471#issuecomment-420053555) by @zappfinger:
Most examples work good, but the form example gives me:
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/Users/richard/anaconda/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/Users/richard/anaconda/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_common.py", line 107, in <lambda>
    t = threading.Thread(target=lambda: time.sleep(4) or clean_dirs())
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_manage.py", line 221, in clean_dirs
    pids = get_pid_list()
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_manage.py", line 137, in get_pid_list
    out = subprocess.check_output(cmd).decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 46623: invalid continuation byte

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/Users/richard/anaconda/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/Users/richard/anaconda/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_common.py", line 107, in <lambda>
    t = threading.Thread(target=lambda: time.sleep(4) or clean_dirs())
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_manage.py", line 221, in clean_dirs
    pids = get_pid_list()
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/_manage.py", line 137, in get_pid_list
    out = subprocess.check_output(cmd).decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 46375: invalid continuation byte

Traceback (most recent call last):
  File "/Users/richard/PycharmProjects/FlexxTest/flexxTest.py", line 49, in <module>
    m = flx.launch(ThemedForm, 'app')
  File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_funcs.py", line 231, in launch
    return a.launch(runtime, **runtime_kwargs)
  File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_app.py", line 166, in launch
    session._runtime = webruntime.launch(url, runtime=runtime, **runtime_kwargs)
  File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/__init__.py", line 200, in launch
    raise ValueError('Could not detect a suitable backend among %r.' % runtimes)
ValueError: Could not detect a suitable backend among ['firefox-app', 'nw-app'].

Process finished with exit code 1

This should be fixed by #6. Please reopen if it is not.

Well, this version only solves the first part of the problem (about the unicode). But the last part remains:
[I 21:50:37 flexx.app] Asset store collected 2 new modules.
[I 21:50:38 flexx.app] Serving apps at http://localhost:49190/
[I 21:50:38 flexx.app] Asset store collected 23 new modules.
Traceback (most recent call last):
File "/Users/richard/PycharmProjects/FlexxTest/flexxTest.py", line 49, in
m = flx.launch(ThemedForm, 'app')
File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_funcs.py", line 231, in launch
return a.launch(runtime, **runtime_kwargs)
File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_app.py", line 166, in launch
session._runtime = webruntime.launch(url, runtime=runtime, **runtime_kwargs)
File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/init.py", line 200, in launch
raise ValueError('Could not detect a suitable backend among %r.' % runtimes)
ValueError: Could not detect a suitable backend among ['firefox-app', 'nw-app'].
Process finished with exit code 1

Right. with the "app" runtime, you need to have either Firefox or Nw.js installed.

But I have Firefox installed on my Mac...
Op do 13 sep. 2018 om 10:06 schreef Almar Klein<EMAIL_ADDRESS>
Right. with the "app" runtime, you need to have either Firefox or Nw.js
installed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flexxui/webruntime/issues/5#issuecomment-420920481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFkYZ4RR6RUXYr-pnnhaMAzbqVLV_lMSks5uahH9gaJpZM4WiOeH
.

Oh, interesting. It looks like webruntime is unable to find it (the code that searches for it is here). Could you please try a few things?

Setting the runtime to 'firefox-app' and 'firefox-browser' (hoping for a clearer error msg).
What version of OS X are you using?
If possible, can you find it the location of the Firefox Application/executable?

Ok, this sort of works. When I change 'app' to 'firefox', it works, but then it recommends me to use 'firefox-browser'. When I do that, it gives me:
[I 19:43:55 flexx.app] Asset store collected 2 new modules.
[I 19:43:56 flexx.app] Serving apps at http://localhost:49190/
[I 19:43:56 flexx.app] Asset store collected 23 new modules.
70:78: execution error: Firefox got an error: Application isn’t running. (-600)
[I 19:43:56 flexx.app] Starting Flexx event loop.
[I 19:43:59 flexx.app] New session ThemedForm 3E07Rsrtk8eSzLaRZrenR6JZ
When I use 'firefox-app' I get:
Traceback (most recent call last):
File "/Users/richard/PycharmProjects/FlexxTest/flexxTest.py", line 49, in
m = flx.launch(ThemedForm, 'firefox-app')
File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_funcs.py", line 231, in launch
return a.launch(runtime, **runtime_kwargs)
File "/Users/richard/py35env/lib/python3.5/site-packages/flexx/app/_app.py", line 166, in launch
session._runtime = webruntime.launch(url, runtime=runtime, **runtime_kwargs)
File "/Users/richard/py35env/lib/python3.5/site-packages/webruntime/init.py", line 200, in launch
raise ValueError('Could not detect a suitable backend among %r.' % runtimes)
ValueError: Could not detect a suitable backend among ['firefox-app'].

Oh yeah and BTW, Firefox is not my default browser, that is Chrome. Maybe that has something to do with it..

This is interesting. With  'firefox-browser' it gives an error, but does it still work (i.e. the app is opened in the browser)?
I don't think it matters whether ff is the default browser. My feeling is that webruntime finds a firefox executable that is not right, or broken in some way. It's hard for me to look into this, since I cannot reproduce it :)  I can give some directions on where to look, and maybe we will be able to solve it that way.
I am curious what is found by _get_exe() https://github.com/flexxui/webruntime/blob/master/webruntime/_firefox.py#L134, and whether that matches the Firefox on your system. Could you place some breakpoints or print-statements there, to see what path is found?


Test multiline search

Test #13155
Complexity: 3

[ ] Mac @misolori
[ ] Windows @gregvanl
[x] Linux @rebornix

Test that multiline search works and works the same as in the editor. A regex search executes in multiline mode if it has a \n. \s will match a newline only if there is a \n literal somewhere in the regex.
The search view should show the first line, and highlight the correct full range in the editor when clicked.

Test that multiline search works and works the same as in the editor

Searching for LF and CRLF returns different results, is this expected? In the editor we will normalize the line breaks.

There is also https://github.com/Microsoft/vscode/issues/36309#issuecomment-433579519, so besides that, they should be the same


improvements to elements displayed

Tabs bar is hidden if there is no dashboard (click "create dashboard" button)
Custom widget selector's are hidden when there is noDashboardMsg is showing (click "create dashboard" button)
widgets section is hidden when noWidgets or noDashboards message is showing

@cesar-tonnoir not ready for merge yet, may batch more changes into this PR.
** These changes are tested on mnoe & mno.

@xaun Can't merge it because of the currency-selector: I'll pick your changes in a new pull request

changes merged in #95


Silabs EFR32 codelab first draft to publish for openthread.io

Add EFR32 codelab to openthread.io
Please validate the preview on openthread.io and let me know of any issues or errors in rendering.

@Vyrastas Thank you for all the suggestions. I have revised the draft to incorporate them.

@Vyrastas Thank you once again for all the suggestions. I have revised the draft to incorporate them. Also moved the [status] to publish and added a button to download Studio on line 83

Revised to correct the last few errors

@silabs-mithil I'll get this published on openthread.io tomorrow.

@silabs-mithil This has been published:
https://openthread.io/guides#hardware_codelabs
https://openthread.io/codelabs/silabs-openthread-hardware
If anything needs fixing, please do it here in GitHub and we'll import the update to openthread.io.  Thanks for the contribution!

Looks good, thank you @Vyrastas and @jwhui


Rubygems install BROKEN -- node dist download link moved

It looks like:
https://nodejs.org/dist/v16.10.0/node-v16.10.0.tar.gz
has moved to:
https://nodejs.org/download/release/v16.10.0/node-v16.10.0.tar.gz
Users can no longer install libv8-node gem on Ruby gems.

False alarm, strange the download isn't working on Windows.

False alarm, closing. Sorry


[formrecognizer] Skip test assertion due to service regression

Tracking issue: https://github.com/Azure/azure-sdk-for-python/issues/28493
Service regression in the value returned for Amount.

API change check
API changes are not detected in this pull request.


Global searching after Sorting on Eager Loaded tables

I am experiencing a strange fault when global searching eager loaded tables after I sorted eager loaded fields.
I am still investigating into this, but it seems it triggers only if I sort columns before i global search.
That's an example error I get

SQLSTATE[HY000]: General error: 1 no such column: faulttype.name (SQL: select count(*) as aggregate from (select '1' as "row_count" from "faults" where LOWER("faulttype"."name") LIKE %s%) count_row_table)

Where "faulttype.name" is the column name in the datatables column definitions.
columns: [
      {data: 'name',           name: 'name'},
      {data: 'faulttype.name', name: 'faulttype.name'}
    ],

I have two models structured like this:
class Fault extends Model
{
    public function faulttype()
    {
        return $this->belongsTo('App\Faulttype');
    }
}

class Faulttype extends Model
{
    public function faults()
    {
        return $this->hasMany('App\Fault');
    }
}

And in the Controller:
public function datatables()
    {
        $faults = Fault::with('faulttype')
            ->select('*');

        return \Datatables::of($faults)
            ->make(true);
    }

The problem goes away if I cancel the column sorting by, for example, ordering by another column.
Version: yajra/laravel-datatables-oracle (v6.7.2)
EDIT: I see that in the demo pages (http://datatables.yajrabox.com/eloquent/relationships) this does not happen. It might be related to the fact I am using Sqlite on local dev. I'll try tomorrow on staging with MySQL.

It seems it's a duplicate column name problem. I'll watch the code asap to see it it could be fixed

You might be having an issue on ambiguous column name? As stated in the demo, you should use the convention we use when using a join statement. Like you said, I was not able to reproduce the error on demo site.
Let me know what you may find. Thanks!

Yep, I used the convention. The thing is that I have same name fields on both tables.
Faults:
id
name
faulttype_id

Faulttypes:
id
name

I'm working on a solution, if something comes to mind I'll PR

@mauroartizzu try to add the following into your select query:
->addSelect('faults.name as fault_name')->addSelect('fault_types.name as fault_type_name')
then you should avoid the ambiguous column name issue

Using the latest version and following @ikerasLT suggestion should fix the issue. Thanks!


Add pass to remove dead variables at the module level.

There does not seem to be any pass that remove global variables.  I
think we could use one.  This pass will look specifically for global
variables that are not referenced and are not exported.  Any decoration
associated with the variable will also be removed.  However, this could
cause types or constants to become unreferenced.  They will not be
removed.  Another pass will have to be called to remove those.

Waiting for bots to go green.

Will handle @dnovillo request in another pull request.

Rebased, squashed, and pushed into master as 5834719fc17


Wrap tabs as needed

I generate a lot of tabs and end up needing to scroll left right all the time.
This MR allows the notebook to put tabs on multiple lines as needed.

Thanks for your first contribution @leonardgerardatomicmachinescom !
I'm not sure I fully understand what this change does, could you please share some screenshot examples of before and after for me to better understand this? Thanks!


Update to image 0.25

Same reason as in the previous image update PR mentioned https://github.com/alpine-alpaca/asefile/pull/20
All tests are passing
To not break compatibility of other crates using asefile it would be good to update the minor version to v0.4.0

Hey @alpine-alpaca, I saw that you made the changes already yourself. Could you create a new tag/version for the crate please?


Fix crash when trying to import a non-exported type

Fixes #36592
Fixes #36614

👍 updated

@typescript-bot cherry-pick this to release-3.8

I've heard the bot is having trouble because of octokit.

This should probably go in the RC since 2 people just reported errors on it in the VS Code codebase.


Show resolution and stuff in a statusbar instead

This should probably be a option though, because some users (like myself) want the image to be as large as possible

fixed with https://github.com/lambdan/imageviewer5/commit/2afbe12c6ef3ef2182463234b86d91a752358d4d


az functionapp keys set: Fails with CryptographyDeprecationWarning on Microsoft Build Agents (py 3.10.8, cli 2.45.0)

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command
az functionapp keys set
Describe the bug
Attempting to set keys using az functionapp keys set results in a CryptographyDeprecationWarning error:
##[error]/opt/az/lib/python3.10/site-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
Note that this problem is happening on Python 3.10.8 w/ CLI v 2.45.0 (the same configuration as the Microsoft ADO Build Agents)
To Reproduce
Command:
az functionapp keys set -g $(rg) -n 'FunctionAppName' --key-type functionKeys --key-name 'KeyName'--key-value='ValueXYZ' --output none
Expected behavior
Keys should be set without any problems.
Environment summary
Described above.  Python 3.10.8 w/ cli 2.45.0.  Note that the same configuration is on the current Microsoft Build agents
Additional context
Nothing else needed to reproduce

Looks like this is related to #25406

route to CXP team

@runtimeware That is correct! This has been fixed as part of this PR and should be part of the next release.

@PramodValavala-MSFT When can I expect the next release to be available?

@runtimeware @oishii-code This should be part of the next release on 2023-03-07.


⚠ Economy API Endpoint has degraded performance

In 3d2c22e, Economy API Endpoint (https://economy.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 1537 ms

Resolved: Economy API Endpoint performance has improved in 5512da0.


[FIXED] Feat: Make a page for Switzerland #1780

Related Issue
#1780
Fixes:  #1780
Description
When the user clicks on the Switzerland card now on the book now page, the user is now redirected to the page displaying the top hotels in Switzerland.

Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
When user clicks on:

They are redirected to:

New feature:
https://github.com/user-attachments/assets/f09c72d3-a21d-47e2-b4c2-7cc65976e2c5
Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal @samarth-6 Please check this out


custom option is broken for new packages

Triggered (if not introduced) by #253 which made it so that buildFromSdist is applied (alphabetically) before the custom option, and for some reason x: x in Nix is not lazily propagating the argument.
       error: attribute 'hello_rust' missing

         at /nix/store/lz0159maimglzlpd6gmn0f02047mmih0-source/nix/modules/project/settings/all.nix:325:19:

          324|             (x: log.traceDebug "${name}.buildFromSdist ${x.outPath}" x)
          325|           ]) else x: x;
             |                   ^
          326|     };

       error: attribute 'hello_rust' missing

       at /nix/store/lz0159maimglzlpd6gmn0f02047mmih0-source/nix/modules/project/settings/default.nix:75:20:

           74|           in
           75|           lib.pipe super.${name} (
             |                    ^
           76|             # TODO: Do we care about the *order* of overrides?

Repro & Details
https://nixos.zulipchat.com/#narrow/stream/413949-haskell-flake/topic/.60custom.60.20setting.20stopped.20working
Proposed design change
Replace custom with two setting options:

settings.<name>.init : drv: assigns the initial value before settings are applied
settings.<name>.final : drv -> drv: transforms the final drv after the other settings are applied.

Open question: putting these two options in the same namespace as other settings is a bit of hack, because they are semantically different. Main questions: a) Is this the best we can do as proposal? b) if so, where should these options live?
(See Zulip for further proposals/ refinements/ ideas)

It probably doesn’t make sense to add non-haskell pkg dependencies in custom, it should only be used for managing haskell packages, which it is meant for.
It made more sense to move hello_rust to otherOverlays and that did the job: https://github.com/shivaraj-bh/haskell-rust-ffi-template/commit/bb60ff1c510be415d6d24cd4e8bd568a03cf08a1

it should only be used for managing haskell packages, which it is meant for.

If we stick to that, we needn’t worry about the order in which the setting is applied, do we?

People use custom option to add Haskell dependency too. See https://community.flake.parts/haskell-flake/dependency#nixpkgs
Regarding, otherOvelays it won't compose like settings does. So if somebody defines otherOverlays in their own project, and imports your FFI template (which also defines otherOverlays), they will get conflict, because of this:
https://github.com/srid/haskell-flake/blob/5dcb739e9cc4e0edf5267de665fa7a905a543baa/nix/types/haskell-overlay-type.nix#L12

It is breaking again after #286
Reproducer:
nix build github:shivaraj-bh/haskell-rust-ffi-template --override-input haskell-flake github:srid/haskell-flake/51bcbc27194e734a1524ac3d36e1539fba9a3baa

@shivaraj-bh It is breaking, but it is not the same error.
From the issue description:
error: attribute 'hello_rust' missing

What I'm seeing when using master branch:
       error: attribute 'override' missing

       at /nix/store/fjvkr94j3lwca8y66zccn15rjwzqn0rd-source/pkgs/development/haskell-modules/lib/compose.nix:38:28:

           37|    */
           38|   overrideCabal = f: drv: (drv.override (args: args // {
             |                            ^
           39|     mkDerivation = drv: (args.mkDerivation drv).override f;

Could you open a separate bug report?

Could you open a separate bug report?

Actually, wait. Let me figure out what the issue is first.

#292