InteractionData::identifier

Hello, thank you so much for these externs.
Can you please, in a next commit, include the InteractionData::identifier property ? Again, thanks for the great work :)
I've been using this property in pixi v3 for multitouch gameplays, it's really nice it has been included in pixi v4.

Sure. Will do :)

added in v4.3.3


Ensure snapshot record returned by create_snapshot! is valid?

This ensures the returned snapshot record is valid.
SnapshotItem has a uniqueness validation on item_id. This causes the snapshot to be invalid after all SnapshotItems have been saved to the database via upsert_all. All records instantiated with Snapshot#build_snapshot_item are still in their initial unsaved state.

v0.5.0 is now released which contains this fix.


New labels in repo issue view sometimes bumps the separator

See screenshot. Exists in FLEX preview, probably getting bumped + clipped.

Bug from #622, not rounding final result


Use --config build.rustdocflags instead of cargo rustdoc --

For the --scrape-examples feature, it's important that rustdoc flags like --static-root-path be passed to all rustdoc invocations. This way, sources generated for reverse dependencies have the correct root path.
To fix this issue, this PR changes the call to cargo rustdoc to move flags that were previously passed via -- <flags> to RUSTDOCFLAGS=<flags>.

Ohh I understand. @jyn514 does the latest commit look like what you expect then?

Done.

I believe this has resulted in all dependencies receiving the flags specified in package.metadata.docs.rs.rustc-args.
Most notably a commonly used --cfg docsrs does not necessarily will allow a dependency to compile (but the code remains valid enough to document). And cargo rustdoc compiles the dependencies for some reason.

Perhaps the solution is to carve off a whitelist of flags like --static-root-path that are passed in via build.rustdocflags and pass the remaining flags as they were before?

…Actually, nevermind. I missed the distinction between build.rustdocflags and build.rustflags. Builds with build.rustdocflags still work fine!


support IFNULL function

Is your feature request related to a problem or challenge?
https://docs.databend.com/sql/sql-functions/conditional-functions/ifnull
I want implement IFNULL function, As implemented by databend
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context

cc @alamb , Is it necessary to implement this function? if yes I will do it

There's nullif already: https://arrow.apache.org/datafusion/user-guide/sql/scalar_functions.html#nullif
Could add ifnull as an alias if there's need for it I suppose :thinking:

TLDR I think implementing this function (perhaps call it nvl and add an alias to ifnull) would be a good addition. Thank you @guojidan
I thought DataFusion already supported the NVL function but I guess I was remembering the Nan equivalent of nanvl: https://arrow.apache.org/datafusion/user-guide/sql/scalar_functions.html#nanvl
So the steps are something like:

add function
add sqllogictests
add doc entries

Should be a good feature 🏆
Can you please implement it as a ScalarUDF in https://github.com/apache/arrow-datafusion/tree/main/datafusion/functions/src/core (following the model of nullif) rather than adding to BuiltInFunction?


Remove soft fail from gpu HS

This PR removes the soft fail from the GPU Held-Suarez job.

Superseded by #2215


Add tender.status guidance

closes https://github.com/open-contracting/ocds-extensions/issues/113

@jpmckinney the tests are failing due the codelist codes, do you know why?

I fixed the tests :)


haskellPackages.cron incorrectly marked as broken

Hello!
Describe the bug
I think the cron Haskell package in version 0.6.2 is incorrectly marked as broken. I have followed the steps from the Youtube video linked by the Haskell wiki page and the build + tests succeed in branch haskell-updates using the command nix-build --no-out-link -A haskellPackages.cron --arg config '{allowBroken = true;}'
To Reproduce
Steps to reproduce the behavior:

git checkout haskell-updates
git pull
nix-build --no-out-link -A haskellPackages.cron -> fails as the package is flagged as broken
nix-build --no-out-link -A haskellPackages.cron --arg config '{allowBroken = true;}' -> succeeds

Expected behavior
I would expect this package to no longer be flagged as broken
Screenshots
N/A
Additional context
N/A
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.101, NixOS, 19.09.2036.c49da6435f3 (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.2`
 - channels(sir4ur0n): `"nixos-unstable-20.03pre200231.7827d3f4497, home-manager"`
 - channels(root): `"nixos-19.09.2036.c49da6435f3"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: haskellPackages.cron

I hope this is the correct information and I have not overlooked something :/
Thank you!

On the haskell-updates branch as of rev 2586e9169, haskellPackages.cron is no longer marked broken.


[RFC] BaseUI tutorial

Part of https://github.com/mui/material-ui/issues/32979
What's the problem? 🤔

Base does not have a tutorial of similar depth and complexity as the Joy tutorial
We got feedback about the current Tailwind based tutorial being impractical

What are the requirements? ❓

Can be implemented using only Base components or only Base hooks
A more practical/realistic example than a music player
No light/dark mode, it relies on the styling solution and not Base itself
Looks good in both light and dark mode of the docs site

What are our options? 💡
1 - Credit card input
Sandbox: https://deploy-preview-36699--material-ui.netlify.app/base/getting-started/tutorial/#credit-card-input
2 - Steam Deck settings UI
Sandbox: https://deploy-preview-36699--material-ui.netlify.app/base/getting-started/tutorial/#credit-card-input
3 - Login form just like JoyUI
Didn't make a sandbox for this one. Whereas the JoyUI tutorial has a focus on key features specific to Joy (e.g. global variants, color scheme), we could shift the focus on Base's features, e.g. show the login form with 3 different styling solutions, or implement the form using only unstyled components or only hooks
Proposed solution 🟢

I'm leaning more towards #2 even though it was kind of a last minute idea (actually more of a discovery), it makes use of 3 different Base components but overall isn't too complex.
#1 is a little flashier but I realized there's no pure hook equivalent of FormControl, and it requires a bit of extraneous code cluttering up the demo (svgs, some verbose credit card regexes)

Yeah, appreciate you doing this @mj12albert! I agree with y'all that #2 seems like the best but I kinda see a progression in complexity here (#1 → #3 →#2) which makes me think if we couldn't have them all but oriented per levels of difficulty ⎯ e.g. "here's a beginner-level tutorial building something with Base UI"; "here's an intermediate-level..."; etc.


Timesheet - 14/02/2021 - Muhammad Anas Azam Bhatti

Task 1
Worked on creating April 12, 2021 Timesheet payment spreadsheet and the sending out the payments.
Proof of Work
I worked on creating the timesheet payment spreadsheet for April 12, 2021. I added all of the timesheet issues of April 12, 2021, which were "approved" and then added them into the spreadsheet and then sent out the payments to them. The total payment requested was 39868 however there was a slight miscalculation on my end as the total pay needed was 35378, therefore 4490, were given back to the treasury(account number: 23676c35fce177aef2412e3ab12d22bf521ed423c6f55b8922c336500a1a27c5).
Link for spreadsheet:  https://drive.google.com/file/d/1kONAyyQ5Rk4nItm76N5QU9vklCmH7QX9/view?usp=sharing
Time Spent
2.25 hours

Total Time Spent
2.25 hours
Account Number
7180f46c4c8dbcffa0945633b03e1dacebf966069d436cb91cf1dde5f1da9fa7

@ma2b0043 we are using 0.5 hours as the unit. Should we make it 2.5 hours instead of 2.25 hours?

@itsnikhil yeah sorry about this, I actually worked for 2h 15 min...I'll make it 2hours for now.

Approved

Approved


⚠ Thumbnails API Endpoint has degraded performance

In c640bd3, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5658 ms

Resolved: Thumbnails API Endpoint performance has improved in 2bd1d80 after 12 minutes.


Game won't load generated files

Reading and writing of files is working, BUT the SinglePlayer game isn't loading these files correctly. I'm not sure exactly what the problem is because even after deleting both LocalPlayer.arkprofile and LocalPlayer.profilebak, the game still ends up loading an older character. It's like if the game can't find a file or the file isn't valid (and the generated files aren't valid somehow), then the game looks in some hidden cache, the world file, or some other location to pull out a character.

Specifically this is for .arkprofile files and the Singleplayer game/directories. Game properly loads preset files, and I haven't tried generating/editing steamid.arkprofile files on a server.

Looks like when the game is started, the .arkprofile file is copied into the .profilebak file. Then on exit, the .arkprofile is saved, but the .profilebak isn't. Editing the .arkprofile in hex and leaving the .profilebak alone is working.

Part of the problem was removing the .profilebak file and generating an entirely new .arkprofile file. If changes are just made to an existing character it seems to be working. However, when I added experience and levels, the game refused to set the characters experience and level to these new values except the total engram points was now updated to the experience value I set. This leads me to believe the game stores levels and experience elsewhere, but at load-time the game read in the new experience value and updated the engram points before reading the actual experience values elsewhere and reverting the .arkprofile file to those values.

Stats Allocations also seem to be read-only from the .arkprofile. Any changes to them aren't respected by the game and must be stored elsewhere (cache or world file) Going to mark this as closed, and update the file-format specifications/docs with Read-Only flags where applicable.

Apparently it was working all along (apart from a few hiccups). The problem was all the duplicated data stored on the instance of your character in the world file is loaded first. All the data in the .arkprofile files isn't used until you respawn your character. Here's an example of a characters body color set to blue (beyond what you can choose in the character creator window)


.vagrant folder is being generated in several places.

For example, if CC is launched from shortcut in desktop, .vagrant folder will appear in desktop too.

After I created a VM using virtualbox and the vagrant plugin, I checked the directory for the additional folders and files.
Result: Got nothing:

So the issue is fixed on master

Tested in prod


Sigh. We'll have to use a different function that doesn't abbreviate using ....

This has bitten me while trying to debug stuff.  A bit annoying.  But:
print is a built-in function in ‘C source code’.

(print OBJECT &optional PRINTCHARFUN)

Output the printed representation of OBJECT, with newlines around it.
Quoting characters are printed when needed to make output that ‘read’
can handle, whenever this is possible.  For complex objects, the behavior
is controlled by ‘print-level’ and ‘print-length’, which see.

Oh, I bet that if you evaluate a straight-use-package form interactively then eval-expression-print-length causes print-length to be bound to a different value than usual, causing the error. The problem could then be solved by specifically binding both print-length and print-level wherever I call print.

Not tested but it should be fixed.

Minor oops...  :)


making pieces non-static

I was curious about making pieces not static (as requested by the project guidelines). Should we simply be exposing values so they can be controlled (and I assume ultimately animated) by the project organizers? Or should we be including animations in our submissions?
This leads me pretty quickly toward questions about authorship which may become more troublesome with living artists, but it sounds like we have:

original artists, whose work was published years/decades ago
re-coders who are re-creating artwork, possibly editing it to fit easily with current technology and display media, and adding systems for control/animation
curators who are controlling/animating the final result

if you expose parameters that would be ideal -- there's some examples already in the repo of sketches that do so, where there is also corresponding "pseudo" code with those parameters listed so changes get visualized.    It basically involves adding params to a parameter group and editing a pseudo code snippet and using a kind of template style with the name or the param (which will get swapped out for the vale or the param).   Our intent is to record animations using these parameters -- so that you can see a number change in the "psuedo code" and then see the result visually (ala brett victor, etc).
In terms of authorship it's exactly as you describe -- we're going to be very clear in all the presentation of these works that these are studies, and we will also describe a bit about the process / animation....
If you want to program your animation, I think that's generally also ok -- we were just trying to keep it easy for people, just consider that each sketch will be up for about 15-20 seconds (longer if it's more complex) and the best animations we see are ones that go in a certain direction, from order to chaos, from nothing to something -- either linearly or in more of a sin from 0 to PI (curve from 0 to 1 and back to 0...)

Out of curiosity, how are you animating variables? I wonder because I have
an idea for an animation, but don't want to spend hours programming it in
if you have an efficient way for defining and managing animations yourself.

our plan is to use a midi controller (like korg nano) and perform the sketches via slider with a bit of smoothing and then record these paramter changes and replay them so that that sequence can loop....


python312Packages.pyoverkiz: 1.13.12 -> 1.13.13

Diff: https://github.com/iMicknl/python-overkiz-api/compare/refs/tags/v1.13.12...v1.13.13
Changelog: https://github.com/iMicknl/python-overkiz-api/releases/tag/v1.13.13
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 326579 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.overkiz
python311Packages.pyoverkiz
python311Packages.pyoverkiz.dist
python312Packages.pyoverkiz
python312Packages.pyoverkiz.dist


Is there any example to show how to display 3D medical image viewing？

 Your question is much more
likely to be answered if it is
a good question

Description
Questions can often be answered by our documentation. Unable to find an answer
in our docs? We'll try to help. In the meantime, if you answer your own
question, please respond with the answer here so that others may benefit as
well. Better yet, open a PR to expand our docs ^_^
Is there any example to show how to display 3D medical image viewing?　I don't know how to do.

This was marked as Awaiting Clarification, but not has been provided. As it's gone stale, I'm going to close it for now. If you would like to continue our discussion, please don't hesitate to comment below.
FWIW, we intend to add support for more advanced layouts and 3D Volume rendering near future.


[bug] KeyError on choice

Could we automatically fix this? (try to put all the other kwargs into the desired choice attribute)
At the least, it should reask like my schema
This is my schema:
<choice
    name="action"
    on-fail-choice="reask"
>
<case
    name="new_file"
>
<object
    name="new_file"
>
<string
    name="filepath"
    description="Path to the newly created file."
    required="true"
/>
<string
    name="description"
    description="Description of the contents of the new file."
    required="true"
/>

</object>
</case>
<case
    name="edit_file"
>
<object
    name="edit_file"
>
<string
    name="filepath"
    description="Path to the file to be edited."
    required="true"
/>
<string
    name="description"
    description="Description of the changes to be made to the file."
    required="true"
/>
<integer
    name="start_line"
    description="The line number of the first line of the hunk to be edited."
    format="positive"
    required="false"
    on-fail="noop"
/>
<integer
    name="end_line"
    description="The line number of the last line of the hunk to be edited. Keep the hunk as short as possible while fulfilling the description."
    format="positive"
    required="false"
    on-fail="noop"
/>
</object>
</case>
<case
    name="finished"
>
<string
    name="commit_message"
    description="A more appropriate commit message based on the actions taken."
    required="true"
/>
</case>
</choice>

This is the generated schema:
<output>
    <string name="action" choices="new_file,edit_file,finished"/>
    <object name="new_file" description="new_file" if="action==new_file">
        <string name="filepath" description="Path to the newly created file." required="true"/>
        <string name="description" description="Description of the contents of the new file." required="true"/>
    </object>
    <object name="edit_file" description="edit_file" if="action==edit_file">
        <string name="filepath" description="Path to the file to be edited." required="true"/>
        <string name="description" description="Description of the changes to be made to the file." required="true"/>
        <integer name="start_line" description="The line number of the first line of the hunk to be edited." format="positive" required="false" on-fail="noop"/>
        <integer name="end_line" description="The line number of the last line of the hunk to be edited. Keep the hunk as short as possible while fulfilling the description." format="positive" required="false" on-fail="noop"/>
    </object>
    <string name="finished" description="commit_message: A more appropriate commit message based on the actions taken." required="true" if="action==finished"/>
</output>

This is the generated string:
{
  "action": "edit_file",
  "filepath": "autopr/utils/repo.py",
  "description": "Update the function call at line 124 to use the new tiktoken implementation.",
  "start_line": 124,
  "end_line": 124
}

This is the stack trace fragment:
  File "/github/workspace/autopr/services/rail_service.py", line 56, in run_rail_object
    raw_o, dict_o = pr_guard(
  File "/venv/lib/python3.9/site-packages/guardrails/guard.py", line 135, in __call__
    guard_history = runner(prompt_params=prompt_params)
  File "/venv/lib/python3.9/site-packages/guardrails/run.py", line 86, in __call__
    validated_output, reasks = self.step(
  File "/venv/lib/python3.9/site-packages/guardrails/run.py", line 136, in step
    validated_output = self.validate(index, output_as_dict, output_schema)
  File "/venv/lib/python3.9/site-packages/guardrails/run.py", line 237, in validate
    validated_output = output_schema.validate(output_as_dict)
  File "/venv/lib/python3.9/site-packages/guardrails/schema.py", line 328, in validate
    validated_response = self[field].validate(
  File "/venv/lib/python3.9/site-packages/guardrails/datatypes.py", line 344, in validate
    selected_value = schema[selected_key]
KeyError: 'edit_file'

This bug is gone after the new Choice changes.


44bytes wav Safari 13.0.5 userAgent

Hello,  on recent version Safari some of recordings are 44 bytes size with no audio. Aprox. 70percents of the recordings are good, 30percents - no audio. No apparent reason i can think of. Whats the problem?

I think this thread could contain the source of the problem and a few possible solutions
https://github.com/ai/audio-recorder-polyfill/issues/4


Fix flaky TestGetContainersAttachWebsocket

Never reproduced but seems like the correct fix.
Fixes #21513
Signed-off-by: Tonis Tiigi<EMAIL_ADDRESS>

Sure, LGTM :P

LGTM


convenience api for demuxing all frames in one go

could there be convenience api for demuxing all frames in one go ?
i see there is api for getting all packets (getAVPackets, if im correct), would be cool if there was method exposed to get all encoded frames and push them to decoder queue as they are demuxed (ideally both in their workers, if its possible to have demuxer in web worker?), not a big deal though, i havent tested your library yet, i will check it in my project soon (omniclip) and replace mp4boxjs, thanks for working on the library 👍

you could use readAVPacket to get all frames, and demuxer is working in web worker. you can see the readAVPacket example code, which used to play video.
because get all frames in one go maybe cost too much memory when file is large, so i only supported readAVPacket to get packets as a ReadableStream. But if you want get all frames api at once, i could add one.
Btw, omniclip is pretty cool ! 😁

yea im aware its kind of bad on memory to get all frames at once, seems like the bottleneck is that file is being loaded whole at once, i could seek frame by frame if it is not causing memory spikes (if its just loading that only needed chunk of file to get that frame), although it will be probably slower than just demuxing whole file chunk by chunk without seeking to specific frame, because i dont need to seek, its for rendering process of my video editor where it just goes all one by one, anyways, do you think its possible to demux whole file but without loading whole file at once but kind of spread the loading of file in time? or load some small chunk of that file, and after that chunk is done demuxing then load another chunk of that file and demux and so on? Something to offset that big initial spike?

I thought video edit and video export should be different. When editing video, i don't think you need get all frames at once, because you only need to edit the current frame. you can use seek frame to demux and edit the current frame. When exporting video, you can use readAVPacket to demux all frames one by one,  and replace the edited frame，then encode frame into new video file. only process one frame at one time,  will not cause so much memory.
readAVPacket default is to read avpacket one by one, or you can specify the start and end time to read.

I thought video edit and video export should be different. When editing video, i don't think you need get all frames at once, because you only need to edit the current frame. you can use seek frame to demux and edit the current frame. When exporting video, you can use readAVPacket to demux all frames one by one, and replace the edited frame，then encode frame into new video file. only process one frame at one time, will not cost so much memory. readAVPacket default is to read avpacket one by one, or you can specify the start and end time to read.

yep, i meant video export (i call it render process sometimes), could you give an example on how to demux file, without seeking, just getting all the frames, one by one ? seems like readAVPacket returns just one WebAVPacket, maybe you meant to use getAVPackets ?

use readAVPacket to get all packets one by one:
async function getAllPackets(file) {
  await demuxer.load(file)
  return new Promise((resolve) => {
    const videoPackets = []
    const reader = demuxer.readAVPacket().getReader()

    reader.read().then(async function processAVPacket({ done, value }) {
      if (done) {
        resolve(videoPackets) // all packets read finished
        return
      }

      videoPackets.push(value) // get one video packet
      // and you can generate video chunk for video decoder
      // const videoChunk = demuxer.genEncodedVideoChunk(value)

      return reader.read().then(processAVPacket)
    })
  })
}

updated the example

use readAVPacket to get all packets one by one:
async function getAllPackets(file) {
  await demuxer.load(file)
  return new Promise((resolve) => {
    const videoPackets = []
    const reader = demuxer.readAVPacket().getReader()

    reader.read().then(async function processAVPacket({ done, value }) {
      if (done) {
        resolve(videoPackets) // all packets read finished
        return
      }

      videoPackets.push(value) // get one video packet
      // and you can generate video chunk for video decoder
      // const videoChunk = demuxer.genEncodedVideoChunk(value)

      return reader.read().then(processAVPacket)
    })
  })
}

updated the example

thanks, it works ! I think the issue can be closed then, seems like the convenience api is not needed at all


Lycosidae has 2% less block chance than actual item

Well, more to the point, it had the wrong item base (Splintered Tower Shield instead of Rawhide Tower Shield). That'll be fixed in the next update.


Consider implementing web server to allow configuration/user interaction in the analysis

One of the main things I have in mind here is that it would be nice to re-run some of the fuzz-introspector analysis by way of the interface, without having to rerun the whole analysis. The case I have in mind if is if fuzz-introspector by default includes too much information (e.g. files from third party libraries) it would be great to indicate in the web interface to remove that from the analysis.

instead of adding a server we may be able to push some logic into javascript

perhaps related: https://github.com/ossf/fuzz-introspector/issues/111


⚠ Requests has degraded performance

In a670b9e, Requests ($SITES_URL_REQUESTS) experienced degraded performance:

HTTP code: 503
Response time: 1094 ms

Resolved: Requests performance has improved in 3c16fff after 1 hour, 58 minutes.


Clean up serializer tests

Remove an unnecessary fixture
Use @wraps on serializer shims to get the right func name in error messages

Selected Reviewer: @samuelcolvin

please review

Use @wraps on serializer shims to get the right func name in error messages

doesn't look like there are any tests for this, worth adding one?

There’s a test that fails if that’s not there, but I can add a more explicit one

Any idea what overhead is of wraps and another wrapper function? If possibly I'd prefer not to.
I think it would be less work and more performant to just support no info argument in core, and use the vanilla function where possible.

I don’t think it adds a function call. I think it just monkey patches attributes from the original function onto the new function (__name__, __doc__, etc)

It would be more performant to implement this in core but I seriously doubt it matters in anything but micro benchmarks. And the price to pay is more complexity in rust. Where is less debuggable and harder for contributors to follow and understand.


Next/refactor

There is a lot of redundancy between this plugin and react-docgen. This PR relies on react-docgen as much as possible to eliminate this redundancy. For example, we don't need to check the AST visitor types because react-docgen handles the doc generation based on the existing components. This PR also adds support for multiple component docs export from the same file. It also addresses an issue where the generated docs would be stored under an incorrect name (the last component defined in the file) even when they were defined on another component.

@CLL80 thanks so much for this PR and converting over to using the Recast AST walker.
Let me dig through this PR a bit more and run some tests on my Storybook instances.

@binomialstew can you do me a huge favor and rebase your branch? i just rebased and merged my other stuff. thanks!


RUMM-906 Sanitise the custom attributes keys for all the events

What does this PR do?
In this PR we are aligning the logic used for sanitising the keys for all the provided custom attributes (custom timings, custom user extra information, custom attributes) inside our events Serialisers. We are following the previously used rules for sanitising the Log custom attributes and we are applying these for each type of custom attribute.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #427 (00e1c09) into master (c4e1038) will increase coverage by 0.26%.
The diff coverage is 96.77%.

@@             Coverage Diff              @@
##             master     #427      +/-   ##
============================================
+ Coverage     90.10%   90.36%   +0.26%
- Complexity     1228     1236       +8
============================================
  Files           149      150       +1
  Lines          4150     4181      +31
  Branches        467      468       +1
============================================
+ Hits           3739     3778      +39
+ Misses          253      249       -4
+ Partials        158      154       -4

Impacted Files
Coverage Δ
Complexity Δ

...ore/internal/constraints/DatadogDataConstraints.kt
90.16% <92.00%> (ø)
22.00 <12.00> (?)

...droid/core/internal/constraints/DataConstraints.kt
100.00% <100.00%> (ø)
0.00 <0.00> (?)

...tadog/android/log/internal/domain/LogSerializer.kt
93.59% <100.00%> (+3.05%)
28.00 <7.00> (ø)

...id/rum/internal/domain/event/RumEventSerializer.kt
100.00% <100.00%> (ø)
7.00 <1.00> (ø)

.../android/tracing/internal/domain/SpanSerializer.kt
89.16% <100.00%> (+5.61%)
23.00 <0.00> (+2.00)

...oid/rum/tracking/NavigationViewTrackingStrategy.kt
86.27% <0.00%> (-1.96%)
14.00% <0.00%> (-1.00%)

...ernal/instrumentation/gestures/GesturesListener.kt
89.74% <0.00%> (ø)
44.00% <0.00%> (-1.00%)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
82.11% <0.00%> (ø)
29.00% <0.00%> (ø%)

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
90.43% <0.00%> (+1.06%)
24.00% <0.00%> (+1.00%)

... and 3 more


Provide heuristic initial guess to solver when none is provided by user

When the initial guess is empty, the solver algorithm generates a completely random population. This makes it slower to find a decent feasible solution. We should seed the population with a sequence that is determined heuristically according to the crafter's available actions and the recipe's stats.

Heuristic currently places ingenuity at the end of the sequence


[workflow delay] 'tofu init' can't find provider release

Thank you for reporting an issue.
When I run tofu init with configuration containing latest version to my provider (10.3.3), it errors out with:
alexh@alexh-mac terraform-provider-artifactory % tofu init

Initializing the backend...

Initializing provider plugins...
- Finding jfrog/artifactory versions matching "10.3.3"...
- Finding latest version of hashicorp/tls...
- Finding latest version of hashicorp/random...
- Installing hashicorp/random v3.6.0...
- Installed hashicorp/random v3.6.0 (signed, key ID 0C0AF313E5FD9F80)
- Installing hashicorp/tls v4.0.5...
- Installed hashicorp/tls v4.0.5 (signed, key ID 0C0AF313E5FD9F80)

Providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://opentofu.org/docs/cli/plugins/signing/
╷
│ Error: Failed to resolve provider packages
│
│ Could not resolve provider jfrog/artifactory: no available releases match the given constraints 10.3.3
╵

No error was reported when I run terraform init.
The release is at: https://github.com/jfrog/terraform-provider-artifactory/releases/tag/v10.3.3 and OpenTofu registry seems to have reference to it: https://github.com/opentofu/registry/blob/main/providers/j/jfrog/artifactory.json#L4
OpenTofu Version
OpenTofu v1.6.2
on darwin_amd64

OpenTofu Configuration Files
terraform {
  required_providers {
    artifactory = {
      source  = "jfrog/artifactory"
      version = "10.3.3"
    }
  }
}

provider "artifactory" {
  //  supply ARTIFACTORY_ACCESS_TOKEN / JFROG_ACCESS_TOKEN / ARTIFACTORY_API_KEY and ARTIFACTORY_URL / JFROG_URL as env vars
}

@cam72cam Thanks! What's the time scale for the cache to be updated? Related, I think this entire release/sync process should be documented somewhere 😄

Looks like the version file was not changed yet on R2.  Looking closer at the latest generate logs:
https://github.com/opentofu/registry/actions/runs/8330749889/job/22796680991
Checking out the ref
/usr/bin/git log -1 --format='%H'
'511eb55d7c428452a857bf91455d56afef1d6935'

That's the wrong commit.  From the update job:
 INPUT_PUSH_OPTIONS:
To https://github.com/opentofu/registry
   511eb55d..e64e876a  HEAD -> main
branch 'refs/heads/main' set up to track 'origin/main'.

It looks like the generate job probably needs a bit of a delay after the update job.
Though, it could also be that the new commit does not exist when the job starts and therefore checks out the wrong hash?
Either way this will be fixed in the next sync (hourly), but probably exposes a flaw in the process.
Unless

With timestamps:
Mon, 18 Mar 2024 17:22:26 GMT INPUT_PUSH_OPTIONS:
Mon, 18 Mar 2024 17:22:27 GMT To https://github.com/opentofu/registry
Mon, 18 Mar 2024 17:22:27 GMT    511eb55d..e64e876a  HEAD -> main

...

Mon, 18 Mar 2024 17:23:29 GMT Uses: opentofu/registry/.github/workflows/generate-and-deploy.yml@refs/heads/main (511eb55d7c428452a857bf91455d56afef1d6935)

...

Mon, 18 Mar 2024 17:23:29 GMT
Run actions/checkout@v4
Mon, 18 Mar 2024 17:23:29 GMT   with:
Mon, 18 Mar 2024 17:23:29 GMT     repository: opentofu/registry
Mon, 18 Mar 2024 17:23:29 GMT     token: ***
Mon, 18 Mar 2024 17:23:29 GMT     ssh-strict: true
Mon, 18 Mar 2024 17:23:29 GMT     persist-credentials: true
Mon, 18 Mar 2024 17:23:29 GMT     clean: true
Mon, 18 Mar 2024 17:23:29 GMT     sparse-checkout-cone-mode: true
Mon, 18 Mar 2024 17:23:29 GMT     fetch-depth: 1
Mon, 18 Mar 2024 17:23:29 GMT     fetch-tags: false
Mon, 18 Mar 2024 17:23:29 GMT     show-progress: true
Mon, 18 Mar 2024 17:23:29 GMT     lfs: false
Mon, 18 Mar 2024 17:23:29 GMT     submodules: false
Mon, 18 Mar 2024 17:23:29 GMT     set-safe-directory: true
Mon, 18 Mar 2024 17:23:29 GMT Syncing repository: opentofu/registry
Mon, 18 Mar 2024 17:23:29 GMT
Getting Git version info
Mon, 18 Mar 2024 17:23:29 GMT   Working directory is '/home/runner/work/registry/registry'
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git version
Mon, 18 Mar 2024 17:23:29 GMT   git version 2.43.2
Mon, 18 Mar 2024 17:23:29 GMT Temporarily overriding HOME='/home/runner/work/_temp/e92761c5-898f-4506-88e8-643c15b109a6' before making global git config changes
Mon, 18 Mar 2024 17:23:29 GMT Adding repository directory to the temporary git global config as a safe directory
Mon, 18 Mar 2024 17:23:29 GMT /usr/bin/git config --global --add safe.directory /home/runner/work/registry/registry
Mon, 18 Mar 2024 17:23:29 GMT Deleting the contents of '/home/runner/work/registry/registry'
Mon, 18 Mar 2024 17:23:29 GMT
Initializing the repository
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git init /home/runner/work/registry/registry
Mon, 18 Mar 2024 17:23:29 GMT   hint: Using 'master' as the name for the initial branch. This default branch name
Mon, 18 Mar 2024 17:23:29 GMT   hint: is subject to change. To configure the initial branch name to use in all
Mon, 18 Mar 2024 17:23:29 GMT   hint: of your new repositories, which will suppress this warning, call:
Mon, 18 Mar 2024 17:23:29 GMT   hint:
Mon, 18 Mar 2024 17:23:29 GMT   hint: 	git config --global init.defaultBranch <name>
Mon, 18 Mar 2024 17:23:29 GMT   hint:
Mon, 18 Mar 2024 17:23:29 GMT   hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
Mon, 18 Mar 2024 17:23:29 GMT   hint: 'development'. The just-created branch can be renamed via this command:
Mon, 18 Mar 2024 17:23:29 GMT   hint:
Mon, 18 Mar 2024 17:23:29 GMT   hint: 	git branch -m <name>
Mon, 18 Mar 2024 17:23:29 GMT   Initialized empty Git repository in /home/runner/work/registry/registry/.git/
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git remote add origin https://github.com/opentofu/registry
Mon, 18 Mar 2024 17:23:29 GMT
Disabling automatic garbage collection
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git config --local gc.auto 0
Mon, 18 Mar 2024 17:23:29 GMT
Setting up auth
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git config --local --name-only --get-regexp core\.sshCommand
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic ***
Mon, 18 Mar 2024 17:23:29 GMT
Fetching the repository
Mon, 18 Mar 2024 17:23:29 GMT   /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +511eb55d7c428452a857bf91455d56afef1d6935:refs/remotes/origin/main
Mon, 18 Mar 2024 17:23:39 GMT   From https://github.com/opentofu/registry
Mon, 18 Mar 2024 17:23:39 GMT    * [new ref]           511eb55d7c428452a857bf91455d56afef1d6935 -> origin/main

So the ref in the job is implicitly impacting the checkout job somehow.

https://github.com/actions/checkout
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.

@cam72cam The new action finished and get same error. Is it possible this is caused by the binary not changed? I bumped the git tag but not code change, as all I wanted is to sign the binary with new GPG private key.

@cam72cam never mind. tofu init runs successfully now. Probably GitHub cache somewhere.
Closing the issue.

I'm going to re-open if you don't mind as it exposes a bug in our process.

Same occurence on my end. If I understand well, new releases may take up to 1 hour before being available globally? That might be an important drawback when deploying a fix on a large number of instance. No delay on tf side.
Initializing the backend...
Upgrading modules...
╷
│ Error: Unresolvable module version constraint
│
│   on main.tf line 18:
│   18: module "rke2" {
│
│ There is no available version of module "registry.opentofu.org/zifeo/rke2/openstack" (main.tf:18) which matches the given version constraint. The newest available version
│ is 3.2.1.
╵

This is why Hashicorp has you setup a web hook for your repository.  OpenTofu scrapes the full set of providers every hour.  I'm playing with some optimizations that could speed this up a bit.  The current bug that is keeping this issue open is that it's actually 2 hours due to the github workflow configuration.
Would a 30 or 15 minute update window be more palatable?

@cam72cam I think this is more of a problem for modules than providers, we may want to look into speeding those up.

Would a 30 or 15 minute update window be more palatable?
For module, I would expect near immediate releases, for provider I believe this is fine.

This now takes between 6 and 30 minutes, averaging around 10-15 minutes.


Tiny thumbnails on results after page refresh

What
Some results from some searches show teeny tiny thumbnails, not after the initial search but when I refresh the page, e.g.
https://wellcomecollection.org/works?query=quacks
https://wellcomecollection.org/works?query=botany
https://wellcomecollection.org/works?query=optics
I think I've only seen this on Books so far, but it doesn't affect all Books.
Where

From the quacks search
After a page refresh

What it's expected to look like

Tom Crane thinks it's a front end issue rather than an API issue:
"Yeah I noticed that but I think that's a front end issue, the thumb being displayed is still the 200 pixel one, just rendered very small."
source

We haven't included book thumbnails previously and I'm not sure we want to until we revisit the design of the work cards. Can we suppress these new additions until we look at this for real?

So only show thumbnails for Digital Images and Pictures (workTypes, 'q' and 'k') for now?

Aye aye cap'n

@davidpmccormick the fix above doesn't fix this - the examples still stand and seems to be a frontend issue.
To replicate do the search and refresh in chrome.

We should probably remove the last fix as it doesn't solve anything and removes thumbnails from works that would otherwise have them.

Jenn asked that thumbnails be removed from books for now

Just a bit of context to debug this: the new index contains merged information coming from METS files. An example of such information is the URL of thumbnails in DLCS rather than Loris (ie iiif.wellcomecollection.org). Our rules say that wherever we have a thumbnail from DLCS instead of Loris we should choose DLCS.
That is because thumbnails in DLCS are either better quality or rephotographed works whereas what we have in Loris is the old Miro images which tend to be worse quality. Also, as DLCS precomputes thumbnails, the ones from DLCS are faster to retrieve.
Using information from METS means we have thumbnails for more WorkTypes values than before, but even for WorkType 'q' and 'k' some of them might come from DLCS now.
If this problem is in any way related to the new source of thumbnails, then restricting the WorkType values won't fix it.
(One thing to note is that thumbnails from DLCS are in a 200200 box rather than 300300 as the ones from Loris.)

@gestchild has fixed this (although we're not currently displaying the images)


kimadeline away

Can't write directly to main because it's a protected branch 😢

Codecov Report

Merging #14654 (09eb789) into main (e33b4e2) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14654      +/-   ##
==========================================
+ Coverage   64.86%   65.01%   +0.15%
==========================================
  Files         541      543       +2
  Lines       25156    25425     +269
  Branches     3545     3593      +48
==========================================
+ Hits        16318    16531     +213
- Misses       8172     8217      +45
- Partials      666      677      +11

Impacted Files
Coverage Δ

...pythonEnvironments/common/pythonBinariesWatcher.ts
33.33% <0.00%> (-28.21%)
:arrow_down:

...rc/client/pythonEnvironments/common/commonUtils.ts
85.93% <0.00%> (-14.07%)
:arrow_down:

src/client/pythonEnvironments/base/locator.ts
73.33% <0.00%> (-10.00%)
:arrow_down:

...nments/discovery/locators/services/condaLocator.ts
93.93% <0.00%> (-6.07%)
:arrow_down:

...ient/pythonEnvironments/base/info/pythonVersion.ts
76.47% <0.00%> (-3.53%)
:arrow_down:

.../locators/services/virtualEnvironmentIdentifier.ts
91.78% <0.00%> (-2.96%)
:arrow_down:

src/client/common/platform/fileSystemWatcher.ts
22.22% <0.00%> (-2.23%)
:arrow_down:

src/client/activation/languageClientMiddleware.ts
32.46% <0.00%> (ø)

...tascience/languageserver/notebookConcatDocument.ts

...ascience/languageserver/notebookMiddlewareAddon.ts

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33b4e2...09eb789. Read the comment docs.


fix(backup): secret annotations might be nil

Secret annotations might be nil (such kubectl create -f secret.yaml -n longhorn-system) when adding a backup-target annotation to a object. Initialize the annotaion if it is nil before we add a backup-target annotation.
regression testing: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/5186
Ref: longhorn/longhorn#6947

@mergify backport v1.5.x v1.4.x

@mantissahz Please merge this if all ready.

cc @longhorn/qa

This fix is straight forward. Let's merge it first since @mantissahz has done the related tests, and can make @longhorn/qa move forward.


Autoware TensorRT & CUDNN error

Hi.
I'm trying to add my own object detection which uses TensorRT and CUDNN.
Autoware could not link cudnn library itself although my own ROS workspace could.
I compiled my package on Autoware by adding target_link_libraries or removing autoware_build_flags.
But during the running code cuda error occurs.
I wonder why my package on Autoware does not work, although it works on my own ROS workspace.
Thanks in advance.
My CUDA version is 9.2 and CUDNN is 7.4.2 and TensorRT 4

Thanks for using Autoware and for your question. However the issue tracker is for posting confirmed bugs and feature requests.
We ask that you please ask questions on the Autoware Discourse category following our support guidelines: https://github.com/CPFL/Autoware/wiki/Support-guidelines. Please pay particular attention to the information we ask you to provide.


Tenant and application configuration EPs in Node SDK (CRU)

Created by: @bayegan Sep 08 2021 at 20:37 CET
Last updated: Jul 19 2022 at 14:29 CET
ClickUp ID: IK-1468
As a user of the Node SDK, I need to be able to invoke the Configuration Management APIs in the Node SDK.
Acceptance criteria:
Implement the following gRPC/graphQL endpoints in the Node SDK:
Tenant: CRU+list
Application: CRU+list

Commented by: @bayegan Sep 02 2021 at 03:01 CET
@dusan-kovacik-profiq : this might be a task coming up in the next sprint (uranus). FYI.


Bug: column "font_url" does not exist

https://uva-aml.sentry.io/share/issue/1ca68cd05d3d469c9ae3947eaa41a152/

This seems to be fixed.


[bug] Latentscope 0.3.1 web server did not load

In a fresh virtual environment using Python 3.12.1 on Mac OS, this loads content at http://localhost:5001/
pip install latentscope===0.3.0
ls-serve

However this returns an error message at localhost:5001
pip install latentscope===0.3.1
ls-serve

I looked at the diff and couldn't figure out what changed between versions, I'm also not getting much info out of the console. I'll stay pinned to 0.3.0 for now, but update this thread if I find out what happened.

that's really strange. so fresh install in a venv and you get that? I've had an issue where I see that error message if I refresh on a deep URL, but not starting from the home page at localhost:5001
I don't see anything that should have affected that in the diff. I'll try to reproduce with a clean venv too.

I looked into it deeper, somehow my package 0.3.1 was being installed from my local github copy rather than directly from pypi. I'm able to run the site if I visit http://localhost:5174/ while running the ls-serve API at the same time. Thanks for having a look, we can probably close this issue.

I've had an issue where I see that error message if I refresh on a deep URL

I noticed this as well specifically when on the "explore" pages, I think it's a different issue than the one I bumped into.
I think this doesn't happen on the vite server because everything gets managed by the browser router, but in the flask app this affects all the /datasets/<DATASET_NAME>/explore/<SCOPE_NAME> routes.
I think this catchall block might want to redirect to index.html rather than directing to alternate dist files if what's being served looked like a React page rather than an asset like an img/js/css file.

you were right, the catchall block was the problem and fixing it worked!


Backport: Hook IPv4 reassembly in the lwAFTR code

This is a backport of PR #135
See issues #78 and #136

LGTM once Travis CI is done and passed.


Catching JSON exceptions.

In ada, within our tests, when JSON is invalid, we current 'crash'. It is thankfully uncommon because we only parse valid files, but let us catch the exceptions.
The changes look massive but all I do is add try/catch and indent, so it is really a trivial PR.

This will create a conflict with the proposal branch, I think it would be better to update it on that branch

@anonrig
Yeah. We can sit on this PR, and drop it for a similar alternative later. It just something I want us to do at some point.
It is really very trivial....
Basically, just point at where the JSON error is. QOL issue.


Allow admins to track ankle monitors

Original issue, copied here so I can track my work done towards completing it.
Background
When our Friends are monitored electronically with an ankle monitor, we want to track this in the same way that we track Detentions for Friends.
Implementation steps

[x]  Database changes: Create a AnkleMonitor table with columns for 'date_applied' (datetime), 'date_removed' (date_time), bi_smart_link (boolean), 'notes' (text), 'friend_id'

[x] Create AnkleMonitor model

On the admin edit friend detention tab (https://github.com/CZagrobelny/new_sanctuary_asylum/blob/master/app/views/admin/friends/_detention_form_fields.html.erb), add an Ankle Monitor section below 'Detentions'. Use the 'Detentions' functionality on this page as a template to build out the following:

[x]   an admin should be able to view the Friend's ankle monitoring history

[x] an admin can edit an instance of ankle monitoring

[x] an admin can add a new ankle monitoring instance for a Friend

[x] an admin can delete a Friend's ankle monitoring instance


[speculative] minor work on reachingDef

@mpollmeier can you test whether this solves / improves the memory issue?

Testing with the joern-flatgraph branch shows that this change reduces the minimum required Xmx for importing linux4 from 45g down to 30g (maybe even less) 🎉 🎉 🎉


refactor: rename chunkStreamReader to readStreamByChunk

Codecov Report

Merging #119 (bf6a5b3) into master (8c3f7a2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   87.17%   87.24%   +0.06%
==========================================
  Files          24       24
  Lines         195      196       +1
  Branches       35       35
==========================================
+ Hits          170      171       +1
  Misses         22       22
  Partials        3        3

Impacted Files
Coverage Δ

src/helpers/index.ts
100.00% <ø> (ø)

src/helpers/readStreamByChunk.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3f7a2...bf6a5b3. Read the comment docs.


To add working steps for  Biggest Reuleaux Triangle within a Square which is inscribed within a Right angle Triangle

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018


Make initAll log a SupportError

initAll was still returning early silently when GOV.UK Frontend is not supported. This makes it log a SupportError to align the message with components that throw SupportErrors in that situation.

Oh, had completely missed those. I'm not sure we need a checkSupport as the two places do slightly different things:

the base component throws
initAll logs

Don't think there's a point in making the initAll catch a potential error to then log it, simpler to just have it run the shared isSupported and log directly 😊

I'll rebase (when I get a more stable connection 😆) and see if it fixes Percy's failure.

Mainly so stack traces go through the same throwing code, easier to mock etc. Not a blocker!


Web worker support

In order to support web worker rendering I think we would need a way to do only the diffing part in the worker that generates patches (like with Matt-Esch/virtual-dom) that are plain objects. These patches could be sent back to the window side and patched.
Is this something that you'd be interested in supporting? If so I could possibly contribute. How difficult would it be to split patch() into a diff and a patch?
Thanks!

The main issue is that functions can't be passed around so you need a different event handler module. If you have a text-only action then you can already generate the view in the worker. Is there additional benefits to do the patching in the worker? I would have thought generating the view was where the real workload was.

I second this, if you have a complex app with lots of logic, network, database operations etc it's beneficial to offload that to a worker. You'd only want to send the patches to the main thread rather than the whole dom representation, much like this https://github.com/nolanlawson/vdom-serialized-patch.

@matthewp did you end up starting on this or figuring out what to do with events?

I haven't done anything yet, wanted to see what the interest was first.

Generating a new view requires the creation of tons of objects (say 2-5 per element) while the patching is essentially comparisons - much faster. My hunch is that a benchmark would reveal that the patching is not the most expensive part. Splitting patching out would require creating even more objects and is likely to slow things down.

I am using WebWorkers, but the patching is done in the main thread.
I am transmitting vTrees, through postMessage. I am defining them in something i call vDOMSON.
I can get pretty decent performance with this approach.
I stringify messages before i post them, and convert them to arraybuffers that I can pass as transfer objects.

@aronallen Sounds like a good approach, and might be the way forward for this issue. Do you have any code available?

if vDOMSON is

['div', {style : {color : 'red'}}, [['span', null, 'hello']]]

then we can map it to snabbdom like this.
function vDOMSONtoSnabbdom(node) {
  const [tag, options, children] = node;
  if (children.map) {
   return h(tag, options, children.map(child => child.map ? vDOMSONtoSnabbdom(child) : child))
  } else {
   return h(tag, options, children);
  }
}

@oskarer I also found out that the Array Buffer approach is not that performant. For Firefox and Chrome you should stringify, postMessage, and parse. For safari and IE/edge you should just post the JS object (the browser will then do a structured copy between the threads)

Hello @aronallen this seems like a good approach, but what about events?. I am working on that, have you any ideas?

@carloslfu for events I have made my own snabbdom module that attaches and removes events from the DOM.
The vDOMSON defined below should attach a click event listener to the div
['div', {
   events : {
    click : true
  }
}, 'hello']

A more advanced example cold be defined as.
events : {
  click : {
    preventDefault: true,
    stopPropagation: false,
    stopImmediatePropagation: false,
    debounce: 100
  }
}

The custom snabbdom events module will then configure the event listener with the above parameters.
To send the event to the WebWorker you need to serialise the event object, basically you have to extract the information from the Event object that can be represented in pure JSON, and send that to the WebWorker for processing.

Thanks @aronallen

At this time there are two ways, the proposed by @matthewp in which is necessary to separate patching and diffing. An advantage of this approach is that diff objects are lightweight and is more performant to transfer this through postMessage I guess (based on what @oskarer says). A drawback is the possible overhead and slowdown this introduces to library (based on @hville comment).
The second approach is the proposed by @aronallen in which patching is done in the main thread. I have tested it and works well.
In my opinion the first one is best. I want to hear the opinion of @paldepind, @TylorS or @staltz on this topic.

@carloslfu I actually managed to enable DOM.select().events() and DOM.select().elements() from within the webworker, makes things alot cleaner. Basically you need to create an observable and then inform the main thread to make the listener. I can't share any code, but it is possible.

An interesting project related to this topic https://github.com/Gozala/dominion

Seems like this depends on #286.


Possible unhandled promise, after upgrade from 0.2.0 to 0.2.1

May I ask for more detail:

Have you provide cache policy for CacheManagerProvider ( view in example project or you can custom your own)

okay great,
any recommendations to make it work with hls ( cloudinary ) with  : https://github.com/aws/amazon-ivs-react-native-player
player plz?


BUG? - Predict for Multi-Classification - Hard limit to 3 classifications

https://github.com/dmlc/xgboost/blob/master/R-package/R/xgb.Booster.R#L430L432
When a multi-classification predict is run with reshape=TRUE, the output is different than in previous commits.
These lines of code seem to limit the output to just 3 classifications (3 columns), even if n_groups > 3.
Is this intended?

Thanks for raising the issue.  My bad, will fix it.


Improve G2SetupConfig - error to set default config doesn't tell you why it fails

--> ./G2SetupConfig.py

A configuration document already exists in the database.  Do you want to replace it (yes/no)?  y

Installing template configuration to database.  Do you want to continue (yes/no)?  y
Error:  Failed to set config as default.

Great, but why?
I doubt G2Setup has been looked at in a while, I'll give it a going over when correcting the above.

Originally https://github.com/Senzing/g2-python/issues/92

See #36


RFE: wish ontap-nas-economy driver spawn external process at flexvol and qtree creation

Hello Trident Team,
Each time that ontap-nas-economy driver create a new flexvol to host a new qtree, it would be great to be able to trigger an external local command with some parameters relative to the new created flexvol. This allow us to be able to trigger custom operation relative to a new volume creation as register the volume in a CMDB ... The external local command would maybe merely trigger a remote command through SSH, DB connect or REST API.
A weakness of using such local external commands is the need to reinstall them each time that trident is updated (manual install in the trident-main container) but it is better than nothing.
We wish a same mechanism for qtree creation and deletion. So we need 3 backend options to define absolute path of our 3 commands

volumeCreationHook
qtreeCreationHook
qtreeDestroyHook

example: volumeCreationHook: /usr/local/hook/bin/volumeCreation.sh
Below a draft code proposal
in the 'Create' function around line 294 in storage_drivers/ontap/ontap_nas_qtree.go

// Create the qtree
qtreeResponse, err := d.API.QtreeCreate(name, flexvol, unixPermissions, exportPolicy, securityStyle)
if err = api.GetError(qtreeResponse, err); err != nil {
log.Errorf("Qtree creation failed. %v", err)
return createError
}
qtreeCreationHook := utils.GetV(opts, "qtreeCreationHook", d.Config.qtreeCreationHook)
sizeBytesStr := strconv.FormatUint(sizeBytes, 10)
qtreeCreateHookCmd, err := exec.Command(qtreeCreationHook, name, flexvol, unixPermissions, exportPolicy, secirityStyle, sizeBytesStr)
if err != nil {
log.Errorf("Qtree Creation Hook spawn failed. %v", err)
}

in the 'ensureFlexvolForQtree' function around line 521 in storage_drivers/ontap/ontap_nas_qtree.go

// Nothing found, so create a suitable Flexvol
flexvol, err = d.createFlexvolForQtree(aggregate, spaceReserve, snapshotPolicy, enableSnapshotDir, encrypt)
if err != nil {
return "", fmt.Errorf("error creating Flexvol for qtree: %v", err)
}
volumeCreationHook := utils.GetV(opts, "volumeCreationHook", d.Config.volumeCreationHook)
volCreateHookCmd, err := exec.Command(volumeCreationHook, flexvol, aggregate, spaceReserve, snapshotPolicy)
if err != nil {
log.Errorf("Volume Creation Hook spawn failed. %v", err)
}
return flexvol, nil

in the 'Destroy' function around line 377 instorage_drivers/ontap/ontap_nas_qtree.go

destroyResponse, err := d.API.QtreeDestroyAsync(deletedPath, true)
if err = api.GetError(destroyResponse, err); err != nil {
log.Errorf("Qtree async delete failed. %v", err)
defer d.API.QtreeRename(deletedPath, path)
return deleteError
}
qtreeDestroyHook := utils.GetV(opts, "qtreeDestroyHook", d.Config.qtreeDestroyHook)
qtreeDelHookCmd, err := exec.Command(qtreeDestroyHook, name, flexvol)
if err != nil {
log.Errorf("Qtree Destroy Hook spawn failed. %v", err)
}
return nil

Thanks for your open and honest answer. Currently my plan is to implement a post-processing job which check new volume emergence and do the needed actions (add in CMDB, configure a backup, ...) So yes I have a solution, certainly less integrated to Trident but good enough to go forward. Thanks you for mentioning Trident REST API, because I forgot this possibility and this can make the work easier.

Excellent! Let us know how it goes!


tsconfig compiler target should be bumped from ES5 to ES2016

Multiple pieces of code within this library use ES2015 & occasional ES2016 standard syntax (including ES2015 methods like Array.from, Object.keys and the Map object and ES2016 methods like Array.prototype.includes). There are comments in the code about whether such methods should be poly-filled.
I would suggest it is the consuming code's responsibility to polyfill if that is a requirement, but the tsconfig.json compilerOptions.target should reflect the ECMAScript standard being used in the code base, which is ES2016, not ES5.

This description is weird. The point of target is to tell typescript which target ES version to compile the syntax down to. You don't get to polyfill if you load code using higher syntax versions. The normal usage is to use the latest supported ES features and target will downlevel to your target environment (hence the name). If you then use runtime features (like Map, Object.keys, etc.) you would need a polyfill. If you want to avoid doing that, you can set the compiler option lib to include e.g. es2017.
The real problem is there's basically no reason to target anything lower than es2019: every supported version of every environment supports everything up to that (excluding Spectre mitigations and the exact format of Function#toString() on iOS). Not doing so means async functions (an es2017 feature) are downleveled, which breaks error async stacks and worsens bundle size and performance.

Added this to the roadmap for tracking: https://github.com/Hopding/pdf-lib/discussions/998. Changing the compiler target can have big, unintended side effects for consumers so I'll have to think carefully before doing something like this.
@simonbuchan appreciate your notes on the advantages of updating to a newer target 👍.


docs: fix homepage example indentation

Sorry about the microscopic PR but this has been bugging me for days

Added, sorry for the unreasonable delay - things got busy.

I fixed some things up (applying the changes and some other CI volatility fixes from main) and merged. Thanks for your contribution.


Compilation failure with GHC 9.10.1-alpha3: ‘HsAppType’ should have 3 arguments, but has been given 4

Here is the result of compiling PyF with GHC 9.10.1-alpha3
src/PyF/Internal/Meta.hs:165:10: error: [GHC-27346]
    • The data constructor ‘HsAppType’ should have 3 arguments, but has been given 4
    • In the pattern: HsAppType _ e _ HsWC {hswc_body}
      In an equation for ‘toExp’:
          toExp d (HsAppType _ e _ HsWC {hswc_body})
            = TH.AppTypeE (toExp d . unLoc $ e) (toType . unLoc $ hswc_body)
    |
165 | toExp d (Expr.HsAppType _ e _ HsWC{hswc_body}) = TH.AppTypeE (toExp d . unLoc $ e) (toType . unLoc $ hswc_body)
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Hey, thank you for the report.
I indeed had not started to have a look at GHC 9.10 alpha. Let me do that ASAP.

If you don't mind, I'll wait for GHC 9.10 rc to be released, should happen really soon.

Well, maybe ready sooner than expected.
@tchoutri if you want, could you try #138?
Thank you.


hack: Run deployments verify multiple times to ignore ordering issues

What type of PR is this?
/kind flake
What this PR does / why we need it:
When there's more than one CRD coming from a package, controller-gen
might generate them in a random order. This doesn't play well with our
verify target. To address this, we run it multiple times to ignore such
issues.
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Codecov Report

Merging #696 (a9efa7f) into master (f8a5996) will not change coverage.
The diff coverage is n/a.


consider iowait as idle.

https://github.com/apache/pulsar/pull/19110

/pulsarbot run-failure-checks


fix match rule discarded from ingress routes (#897)

cherry-pick bug fix from release-0.1 branch

I think linters got smarter and post some warnings unrelated to your change. Can you also please fix those to make presubmit pass?

Jenkins job pilot/presubmit passed


Getting Product images from Google Cloud Storage

What I'm trying to achieve
I am trying to use my google cloud storage full of pictures in order to feed the images of the products
Describe a proposed solution
Maybe REST wrapper that allows the user to integrate his bearer token in order to have access to the cloud storage
Is there a way to achieve this without having to download all the images?
Thank you!

This PR solves the issue, I can confirm it works locally. I've only tried serving the media files from my google cloud storage bucket using a service account key.json
https://github.com/mirumee/saleor/pull/2626


Support Build & Setup Environment Variables

In my case I have a postCreateCommand that clones another organization repo. This works great under Codespaces but is hanging when using this project. I think what I see is that 🏃 start container will stop here.
Cloning into '/workspaces/mysharedrepo'...
Username for 'https://github.com/':

And never move from that spot. The lifecycle script is doing something like this.
git clone<EMAIL_ADDRESS>/workspaces/mysharedrepo
cd /workspaces/mysharedrepo

Any recommendations to get that working?

Would it make sense to have the env: variables be accessible to both the build and start stages? That might help here.

FWIW, I would be happy if there was ANY environment variable during the build / start process so I could make some runtime decisions?

Hey! This proposal makes sense to me.  @stuartleeks I suspect you'll agree this is OK, but curious if there's any thoughts you have counter?

I was wondering whether there would be any scenarios where we would want to set the build environment variables independently of the runtime ones.
E.g. would we want to have buildEnv and env, or just have env that is passed to both?

You can start with passing env to both. Then if an issue is reported with this behavior, we can split it up.

You can start with passing env to both. Then if an issue is reported with this behavior, we can split it up.

Agreed here too. Thank you.

Hello! Just bumping this issue, is it being tracked/planned?

I've was looking at adding support for this to the action, and was a little confused by the results of my testing for a while so thought I'd drop a comment here.
There's a PR to improve support for this (#211) but depending on how your devcontainer.json is set up, you may be able to make this work already.
To do this, you need to have the remoteEnv in your devcontainer.json referencing a value from localEnv:
	 "remoteEnv": {
		"YOUR_ENV" : "${localEnv:YOUR_ENV}"
	}

This instructs the devcontainer CLI to set the remote env in the container based on the localEnv context.
The localEnv context can be set using the env property at the step level (i.e. not nested under the with block):
      - name: Build and run Dev Container task
        uses<EMAIL_ADDRESS>        env:
          YOUR_ENV_VAR: some_value
        with:
          runCmd: |
            make the-thing

#211 will add update the action so that env vars set in the env under the with block are passed to the container. This will provide a way to set container env vars without needing to have it set in devcontainer.json.
I'll raise an issue to add examples of this to the docs.

I'm trying this out now and still can not figure out how to use an environment variable when the devcontainer is being built. I've read the docs in the PR work @stuartleeks did but still can't figure it out. Is the env only available to runCmd?

@moleary-gsa what a nice idea! thanks!


snap to grid is not behaving correctly

Hi again,
When using snap to grid everything works as expected on the initial zoom level scale of 1. If you zoom in by a fraction (e.g.: scale 1.2) the grid snapping is not working correctly. As soon as you hit scale(2) it starts snapping back to the grid but with a double offset from your mouse position. I believe the reason is that the grid snapping is scaling the snapping based on the current zoom factor which is not required. The node's translation is being scaled by the parent container (the graph) and should not be manually scaled to the zoom factor.
See this loom video for more context: https://www.loom.com/share/e1b71b244f33436c91d29ef156f6c12c

hey @bartvanremortele!
Thanks for the detailed bug report :) Good catch! We just fixed it.


Allow security managers to prevent system property access for Indy

When using the "indy" setting, it tries to read a system property to enable logging.
This change enables a JVM Security Manager to block this setting and therefore simply ignore the setting to use the default: do not log.
From a security manager, you might otherwise catch a SecurityException containing:

access denied ("java.util.PropertyPermission" "groovy.indy.logging" "read")

Not only is this not recoverable, but the IndyInterface class will be inaccessible thereafter due to it being in a static block that fails (the dreaded NoClassDefFoundError).

Sent to incubating apache repo: https://github.com/apache/incubator-groovy/pull/119


README.md :  GitHub Actions "minutes" / month

It's 2000 or 3000 minutes PER MONTH
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#included-storage-and-minutes

Thanks gor clarifying. My favorite kind of PR


Missing Constructor for ResponseTransformerRouteImpl

In version 2.5.1, the 'create()' method of ResposeTransformerRouteImpl was changed to fix a null pointer exception (see https://github.com/perwendel/spark/commit/0e7d1bc350bef17abe29035d1003b33f4fb164960. The problem I'm running into is that the
 protected ResponseTransformerRouteImpl(String path, String acceptType) constructor was removed as part of the fix.
I have a legacy code base that I want to update to avoid the 'directory traversal vulnerability'. Unfortunately, that change to that method signature is going to require a substantial amount of refactoring since I have several classes that extend ResponseTransformerRouteImpl. Would it be possible to have both versions of that constructor, or would having that version without the route parameter still lead to an NPE?

@perwendel ?

Could you create a PR and see if it breaks anything @pbtura ?

I'll see what I can do.

@pbtura ping.

Sorry, I haven't had a chance to work on this yet.


Seccomp filter problem continuous re-occuring  - e.g. breaking sysbox runtime (Docker Desktop for Windows running on WSL)

Windows Version
Microsoft Windows [Version 10.0.22631.3296]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 22.04
Other Software
Docker Desktop for Windows v4.27.2 with WSL runtime and WSL distro integration activated
Repro Steps

Start Docker Desktop for Windows with active business subscription to make sysbox-runc available
Start any container image, either from cmd.exe or from within aforementioned wsl distribution: docker run -it --rm --runtime sysbox-runc  /bin/bash

Expected Behavior
Container is successfully started and bash prompt appears
Actual Behavior
Container start fails in all cases, issuing the following error message:
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: container_linux.go:427: starting container process caused: init_linux.go:632: loading seccomp notification rules caused: error loading seccomp filter into kernel: error loading seccomp filter: device or resource busy: unknown.
Diagnostic Logs
This issue obviously is well known by now:
https://github.com/microsoft/WSL/issues/9548
https://github.com/microsoft/WSL/issues/9993
Confirming seccomp property on the init process as mentioned in the above tickets:

cat /proc/1/status | grep -i seccomp
Seccomp:        2
Seccomp_filters:        1

Thanks a ton for looking into this.

Logs are required for review from WSL team
If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'. Otherwise please attach logs by following the instructions below, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.
How to collect WSL logs
View similar issues
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it!
Closed similar issues:
* [WSL <IP_ADDRESS>: seccomp issue? (#8683)](https://github.com/microsoft/WSL/issues/8683),  similarity score: 0.75

* [All processes have seccomp filters attached to them, breaking CRIU (#9993)](https://github.com/microsoft/WSL/issues/9993),  similarity score: 0.73

* [Inserting seccomp notify filter in WSL kernel <IP_ADDRESS> fails with EBUSY (#9548)](https://github.com/microsoft/WSL/issues/9548),  similarity score: 0.72

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

Understood - moving this to #9548, but cannot re-open this ticket, therefore I initially opened a new one.


Everyone is free to contribute to this repo

contribute, share the repo, use the code for your own purpose Thank you

Contribution is the best way to learn from others.


[bug] Generate sql code

While generating user protocol, I found the serverpod generator does not avoid using reserved sql keywords
Actual behavior: does not avoid using reserved sql keywords while generating tables (Table is not generated )
CREATE TABLE user (
  "id" serial,
  "firstName" text NOT NULL,
  "lastName" text,
  "avatar" text NOT NULL
);

ALTER TABLE ONLY user
  ADD CONSTRAINT user_pkey PRIMARY KEY (id);

Expected behavior: avoid using reserved sql keywords while generating tables, apply double quotes to table name
CREATE TABLE "user" (
  "id" serial,
  "firstName" text NOT NULL,
  "lastName" text,
  "avatar" text NOT NULL
);

ALTER TABLE ONLY "user"
  ADD CONSTRAINT user_pkey PRIMARY KEY (id);

Will fix for the 1.0 release, thanks for catching this!

https://github.com/serverpod/serverpod/pull/384


set eligibility integer on reference ballot

i didn't notice that it wasn't part of the epoch data. integers can't overwrite eligibility count in the same epoch, so it should be specified once

bors merge


SyncMultiGPUTrainer and ProgressBar

I get an error when I use the SyncMultiGPUTrainer.
But in SimpleTrainer(config).train() the progressBar works fine
:
[0627 15:39:01 @concurrency.py:36] Starting EnqueueThread ...                                                             [40/1912]
Traceback (most recent call last):
  File "model_pack.py", line 187, in <module>
    # SyncMultiGPUTrainer(config).train()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/train/base.py", line 104, in train
    self.main_loop()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/train/base.py", line 178, in main_loop
    self._callbacks.before_train()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/callbacks/base.py", line 59, in before_train
    self._before_train()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/callbacks/group.py", line 68, in _before_train
    cb.before_train()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/callbacks/base.py", line 59, in before_train
    self._before_train()
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/callbacks/steps.py", line 104, in _before_train
    self._fetches = get_op_or_tensor_by_name(self._names) or None
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/tfutils/common.py", line 142, in get_op_or_tenso
r_by_name
    return list(map(f, name))
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorpack/tfutils/common.py", line 135, in f
    return G.get_tensor_by_name(n)
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 2563, in get_tens
or_by_name
    return self.as_graph_element(name, allow_tensor=True, allow_operation=False)
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 2411, in as_graph
_element
    return self._as_graph_element_locked(obj, allow_tensor, allow_operation)
  File "/home/yxwang/.pyenv/versions/threed/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 2456, in _as_grap
h_element_locked
    "graph." % (repr(name), repr(op_name)))
KeyError: "The name 'cost:0' refers to a Tensor which does not exist. The operation, 'cost', does not exist in the graph."

Here is my config code:
def get_config():
    logger.auto_set_dir()
    with open('../config.json') as cfg:
        config = json.load(cfg)
    dataset_train, dataset_test = run(config)
    extra_display = ["cost", "accuracy", "train_error"]

    return TrainConfig(
        dataflow=dataset_train.ds,
        callbacks=[
            ModelSaver(keep_checkpoint_every_n_hours=0.2),
            # InferenceRunner(dataset_test.ds,
            #                 [ScalarStats('cost'),
            #                 ClassificationError('wrong-top1', 'val-error-top1')]),
            ScheduledHyperParamSetter('learning_rate',
                                    [(1, 0.1), (82, 0.01), (123, 0.001), (300, 0.0002)])
        ],
        extra_callbacks=[
            MovingAverageSummary(),
            ProgressBar(extra_display),
            MergeAllSummaries(),
            RunUpdateOps(),
        ],
        monitors=[
            tensorpack.callbacks.TFEventWriter(),
            tensorpack.callbacks.JSONWriter(),
            tensorpack.callbacks.ScalarPrinter(enable_step=True),
        ],
        model=Model(1),
        max_epoch=4,
    )

In the multi-Tower setting you need to use
ProgressBar(['tower0/cost']),

Each tower has its own scope. To get the name of the Tensor, I do something like
self.cost = bla bla bla
print(self.cost.name)

This should give the name for the progressbar.
@ppwwyyxx Should I add some logic to look into Tower 0, if no tensor was found?

@kdplus Please try the above suggestion.
@PatWie This is a big problem with the current interface, also brought out by some others earlier. I would want to improve clarity of ModelDesc in different aspects, but haven't got a concrete plan yet.

@PatWie @ppwwyyxx Thx! It works

@ppwwyyxx I still do not get it, why it should be a problem. After all it is an entire computation graph. And the issues comes with Tf itself.
TensorPack can provide a function get_tensor which tries to be smart enough to test whether there is a training tower or not.

About the original question, after latest changes 897d29e to the trainer, using "cost" would be sufficient. "tower0/cost" also works.


Updated README.md with Nostalgify

Fixes #4

Add Fixes #issue number in pr body (click 3 dots on side of panel -> select edit) to attach the issue.

Thanks a lot for your contributions.


shouldComponentUpdate isn't called when wrapping React components with styled-components

I have three files, App.js, InputContainer.js and index.js
App.js
import React, { Component } from 'react';
import InputContainer from './InputContainer';
import styled from 'styled-components';

class App extends Component {
  constructor() {
    super();
    this.state = {
      count: 0
    }
  }
  render() {
    const StyledInputContainer = styled(InputContainer)`
    `
    return (


New feature: use os.symlink for file:// urls

Overview
In our use-case we are working with climate data netcdf files which can be easily a few GBs large. In a chained process we use file urls as input to a process (data is already available on local filesystem). In the current implementation pywps would copy all files to the workdir. We want to avoid that and use symlinks instead.
This patch adds a file_handler to handle complex inputs with file urls and creates symlinks in the workdir to the local file location.
Related Issue / Discussion
Additional Information

This was patched in pywps-3 before.
os.symlink works only on unix. One could skip the file_handler on windows.

Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[ ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Cool stuff, thanks a lot @cehbrecht !


Add Workflow Executor Example

Description
Add workflow executor example using existing react-langgraph strategy.
Issues
RFC: https://github.com/opea-project/docs/pull/77/files
Type of change
List the type of change like below. Please delete options that are not relevant.

[x] New feature (non-breaking change which adds new functionality)

Hi @xuechendi, the CICD validation test can only pass after the addition of custom system prompts and the merge for https://github.com/opea-project/GenAIComps/pull/782

@JoshuaL3000 , codes looks good to me, I was discussing with Minmin on your previous WorkExecutor strategy. Once this example is merged, we can't continue on that strategy

Hi @xuechendi @minmin-intel, the CICD results are passing. Could you help to review those and see if this is ready to be merged? thanks

Result is looking good


border-zero: A value of 0 is not allowed. 0 must be used.

What version of Sass Lint are you using?
1.9.1
Please include any relevant parts of your configuration
border-zero:
    - 1
    - convention: 0

What did you do? Please include the actual source code causing the issue.
.element {
  border: 0;
}

What did you expect to happen?
Not raising a warning, since the actual value is the same as the expected value.
What actually happened? Please include any error messages given to you by Sass Lint.
(Using Atom's plugin)
[sass-lint] [Warning] [border-zero] A value of `0` is not allowed. `0` must be used.

If you're using a IDE plugin have you tried the CLI too?
Same output:
143:22  warning  A value of `0` is not allowed. `0` must be used                   border-zero

I think this problem could be solved by changing this in border-zero.js:
From:
if (node.content === '0' || node.content === 'none') {
  //...
}

To:
if (node.content === 0 || node.content === 'none') {
  //...
}

Configurations with convention: 0 won't generate false warnings this way.

As I can see now, the default is set to the string '0', instead of the int. When using a string, it doesn't produce a warning.
I'll pass in a PR to fix this, so that the int 0 could also be used.

Btw, @thijskramer - your solution doesn't fix it, it just skips the validation. node.content is the value in border: 0; or border: none; which is always a string. Therefore it will not pass your if-statement because node.content is '0' (string), not 0 (int) or 'none'

Allright, well then this issue could be fixed by parsing the yml config file in a different way, because people like me are using a .sass-lint.yml file with the following config:
rules:
  border-zero:
    - 1
    - convention: 0

OR, maybe use just two equal signs to compare (I'm not sure if this would work though):
if (node.content == '0' || node.content === 'none') {
  //...
}

Which solution do you prefer?

The one I've made the PR with :) (convert convention to string)

Yeah i think @richarddewit's solution is the way to go, we've added a few comments there so if you'd like to update it then we can merge it in for you. If not we can take it further ourselves and get it sorted, with proper accreditation to your contribution of course! 🎉

Sorry for the late reaction, but I currently can't find time to implement this. If you could pick this up, that would be nice :)