HBASE-22275 Removed deprecated getRegionInfo in HRegionLocation

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
277
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
272
master passed

+1
compile
190
master passed

+1
checkstyle
189
master passed

+1
shadedjars
276
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
445
master passed

+1
javadoc
128
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
250
the patch passed

+1
compile
184
the patch passed

+1
javac
184
the patch passed

-1
checkstyle
79
hbase-server: The patch generated 8 new + 708 unchanged - 6 fixed = 716 total (was 714)

-1
checkstyle
19
hbase-mapreduce: The patch generated 1 new + 32 unchanged - 1 fixed = 33 total (was 33)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
506
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
533
the patch passed

+1
javadoc
137
the patch passed

_ Other Tests _

+1
unit
198
hbase-client in the patch passed.

-1
unit
15222
hbase-server in the patch failed.

-1
unit
1284
hbase-mapreduce in the patch failed.

+1
unit
339
hbase-thrift in the patch passed.

+1
unit
325
hbase-endpoint in the patch passed.

+1
unit
506
hbase-rest in the patch passed.

+1
asflicense
192
The patch does not generate ASF License warnings.

22119

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux d29ed651484c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 353f9226c3

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/artifact/out/diff-checkstyle-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/testReport/

Max. process+thread count
5013 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
241
master passed

+1
compile
185
master passed

+1
checkstyle
192
master passed

+1
shadedjars
267
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
435
master passed

+1
javadoc
138
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
238
the patch passed

+1
compile
182
the patch passed

+1
javac
182
the patch passed

-1
checkstyle
84
hbase-server: The patch generated 8 new + 707 unchanged - 6 fixed = 715 total (was 713)

-1
checkstyle
18
hbase-mapreduce: The patch generated 1 new + 31 unchanged - 1 fixed = 32 total (was 32)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
271
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
511
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
496
the patch passed

+1
javadoc
129
the patch passed

_ Other Tests _

+1
unit
205
hbase-client in the patch passed.

-1
unit
12502
hbase-server in the patch failed.

+1
unit
1148
hbase-mapreduce in the patch passed.

+1
unit
295
hbase-thrift in the patch passed.

+1
unit
275
hbase-endpoint in the patch passed.

+1
unit
421
hbase-rest in the patch passed.

+1
asflicense
189
The patch does not generate ASF License warnings.

18781

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux e96306a45dd4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / f30d6c958a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/artifact/out/diff-checkstyle-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/testReport/

Max. process+thread count
5114 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
49
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

+1
mvninstall
249
master passed

+1
compile
179
master passed

+1
checkstyle
182
master passed

+1
shadedjars
270
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
467
master passed

+1
javadoc
135
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
245
the patch passed

+1
compile
190
the patch passed

+1
javac
190
the patch passed

+1
checkstyle
36
The patch passed checkstyle in hbase-client

+1
checkstyle
80
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
18
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
32
The patch passed checkstyle in hbase-thrift

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
508
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
520
the patch passed

+1
javadoc
135
the patch passed

_ Other Tests _

+1
unit
200
hbase-client in the patch passed.

-1
unit
14297
hbase-server in the patch failed.

-1
unit
1415
hbase-mapreduce in the patch failed.

+1
unit
326
hbase-thrift in the patch passed.

+1
unit
321
hbase-endpoint in the patch passed.

+1
unit
516
hbase-rest in the patch passed.

+1
asflicense
200
The patch does not generate ASF License warnings.

21068

Reason
Tests

Failed junit tests
hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 3f43f1d60acb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 6e959777fc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/3/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/3/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/3/testReport/

Max. process+thread count
5606 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Go for it @HorizonNet  Thanks for answering my question.

No problem. Currently waiting for a +1 from the build. I think the failing test is not related, but just want to play safe.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
282
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
271
master passed

+1
compile
186
master passed

+1
checkstyle
191
master passed

+1
shadedjars
269
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
482
master passed

+1
javadoc
134
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
246
the patch passed

+1
compile
188
the patch passed

+1
javac
188
the patch passed

+1
checkstyle
35
The patch passed checkstyle in hbase-client

+1
checkstyle
79
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
16
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
32
The patch passed checkstyle in hbase-thrift

+1
checkstyle
12
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
17
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
513
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
518
the patch passed

+1
javadoc
134
the patch passed

_ Other Tests _

+1
unit
199
hbase-client in the patch passed.

-1
unit
16721
hbase-server in the patch failed.

+1
unit
1472
hbase-mapreduce in the patch passed.

+1
unit
368
hbase-thrift in the patch passed.

+1
unit
332
hbase-endpoint in the patch passed.

+1
unit
575
hbase-rest in the patch passed.

+1
asflicense
190
The patch does not generate ASF License warnings.

23931

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide

hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.client.TestSnapshotCloneIndependence

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestAdmin1

hadoop.hbase.quotas.TestSpaceQuotas

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 53b15e38c953 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 184568cadd

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/4/testReport/

Max. process+thread count
5499 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 42 new or modified test files.

_ master Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
259
master passed

+1
compile
181
master passed

+1
checkstyle
199
master passed

+1
shadedjars
257
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
468
master passed

+1
javadoc
133
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
244
the patch passed

+1
compile
206
the patch passed

+1
javac
206
the patch passed

+1
checkstyle
38
The patch passed checkstyle in hbase-client

+1
checkstyle
93
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
36
The patch passed checkstyle in hbase-thrift

+1
checkstyle
14
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
18
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
295
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
633
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
517
the patch passed

+1
javadoc
155
the patch passed

_ Other Tests _

+1
unit
197
hbase-client in the patch passed.

-1
unit
13140
hbase-server in the patch failed.

+1
unit
1214
hbase-mapreduce in the patch passed.

+1
unit
280
hbase-thrift in the patch passed.

+1
unit
294
hbase-endpoint in the patch passed.

+1
unit
424
hbase-rest in the patch passed.

+1
asflicense
175
The patch does not generate ASF License warnings.

19739

Reason
Tests

Failed junit tests
hadoop.hbase.quotas.TestSpaceQuotas

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux bf4d817aa440 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 4477dd5de8

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/5/testReport/

Max. process+thread count
5039 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
55
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 42 new or modified test files.

_ master Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
312
master passed

+1
compile
225
master passed

+1
checkstyle
216
master passed

+1
shadedjars
310
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
526
master passed

+1
javadoc
158
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
322
the patch passed

+1
compile
223
the patch passed

+1
javac
223
the patch passed

+1
checkstyle
39
The patch passed checkstyle in hbase-client

+1
checkstyle
88
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
20
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
35
The patch passed checkstyle in hbase-thrift

+1
checkstyle
14
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
17
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
292
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
601
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
533
the patch passed

+1
javadoc
138
the patch passed

_ Other Tests _

+1
unit
192
hbase-client in the patch passed.

-1
unit
11825
hbase-server in the patch failed.

+1
unit
1147
hbase-mapreduce in the patch passed.

+1
unit
198
hbase-thrift in the patch passed.

+1
unit
247
hbase-endpoint in the patch passed.

+1
unit
296
hbase-rest in the patch passed.

+1
asflicense
162
The patch does not generate ASF License warnings.

18435

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSplitWALProcedure

hadoop.hbase.master.assignment.TestReportRegionStateTransitionRetry

hadoop.hbase.tool.TestSecureLoadIncrementalHFilesSplitRecovery

hadoop.hbase.master.assignment.TestReportOnlineRegionsRace

hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster

hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController

hadoop.hbase.TestRegionLoad

hadoop.hbase.tool.TestSecureLoadIncrementalHFiles

hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureInfiniteLoop

hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting

hadoop.hbase.tool.TestLoadIncrementalHFiles

hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL

hadoop.hbase.io.encoding.TestDataBlockEncoders

hadoop.hbase.master.procedure.TestSCP

hadoop.hbase.procedure.TestProcedureManager

hadoop.hbase.io.hfile.TestCacheOnWrite

hadoop.hbase.tool.TestCanaryTool

hadoop.hbase.io.encoding.TestEncodedSeekers

hadoop.hbase.replication.TestSyncReplicationStandBy

hadoop.hbase.master.assignment.TestModifyTableWhileMerging

hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient

hadoop.hbase.master.assignment.TestSplitTableRegionProcedure

hadoop.hbase.master.assignment.TestMasterAbortWhileMergingTable

hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS

TEST-null

hadoop.hbase.master.assignment.TestAMServerFailedOpen

hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk

hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure

hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder

hadoop.hbase.master.assignment.TestAssignmentManagerUtil

hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry

hadoop.hbase.io.encoding.TestChangingEncoding

hadoop.hbase.TestNamespace

hadoop.hbase.io.hfile.TestCacheConfig

hadoop.hbase.TestPartialResultsFromClientSide

hadoop.hbase.master.assignment.TestTransitRegionStateProcedure

hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd

hadoop.hbase.master.TestMigrateNamespaceTable

hadoop.hbase.replication.TestReplicationProcedureRetry

hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController

hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction

hadoop.hbase.TestIOFencing

hadoop.hbase.procedure.TestFailedProcCleanup

hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL

hadoop.hbase.tool.TestLoadIncrementalHFilesSplitRecovery

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 5d5fe5116e6a 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 3f40df8085

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/6/testReport/

Max. process+thread count
4993 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
264
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 42 new or modified test files.

_ master Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
267
master passed

+1
compile
184
master passed

+1
checkstyle
193
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
467
master passed

+1
javadoc
141
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
245
the patch passed

+1
compile
181
the patch passed

+1
javac
181
the patch passed

+1
checkstyle
34
The patch passed checkstyle in hbase-client

+1
checkstyle
74
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
31
The patch passed checkstyle in hbase-thrift

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
15
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
260
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
507
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
513
the patch passed

+1
javadoc
137
the patch passed

_ Other Tests _

+1
unit
198
hbase-client in the patch passed.

-1
unit
16988
hbase-server in the patch failed.

-1
unit
1471
hbase-mapreduce in the patch failed.

+1
unit
362
hbase-thrift in the patch passed.

+1
unit
317
hbase-endpoint in the patch passed.

+1
unit
548
hbase-rest in the patch passed.

+1
asflicense
181
The patch does not generate ASF License warnings.

24101

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide

hadoop.hbase.client.TestConnectionImplementation

hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.quotas.TestSpaceQuotas

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux c83dcbe2a0a3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 70296a2e78

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/7/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/7/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/7/testReport/

Max. process+thread count
5071 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/7/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Updated the PR to fix the failing shell tests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
20
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
28
Maven dependency ordering for branch

+1
mvninstall
261
master passed

+1
compile
216
master passed

+1
checkstyle
210
master passed

+1
shadedjars
278
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
503
master passed

+1
javadoc
156
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
252
the patch passed

+1
compile
243
the patch passed

+1
javac
243
the patch passed

+1
checkstyle
36
The patch passed checkstyle in hbase-client

+1
checkstyle
84
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
36
The patch passed checkstyle in hbase-thrift

+1
checkstyle
10
The patch passed checkstyle in hbase-shell

+1
checkstyle
14
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
18
The patch passed checkstyle in hbase-rest

-1
rubocop
21
The patch generated 5 new + 816 unchanged - 5 fixed = 821 total (was 821)

+1
ruby-lint
2
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
283
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
526
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
576
the patch passed

+1
javadoc
149
the patch passed

_ Other Tests _

+1
unit
190
hbase-client in the patch passed.

+1
unit
9663
hbase-server in the patch passed.

+1
unit
967
hbase-mapreduce in the patch passed.

+1
unit
226
hbase-thrift in the patch passed.

+1
unit
432
hbase-shell in the patch passed.

+1
unit
198
hbase-endpoint in the patch passed.

+1
unit
241
hbase-rest in the patch passed.

+1
asflicense
185
The patch does not generate ASF License warnings.

16240

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 7b142334796a 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 94122f6a74

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.67.2

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/8/artifact/out/diff-patch-rubocop.txt

ruby-lint
v2.3.1

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/8/testReport/

Max. process+thread count
5096 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/8/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Fixed the Rubocop warnings from the last build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
16
Maven dependency ordering for branch

+1
mvninstall
243
master passed

+1
compile
211
master passed

+1
checkstyle
211
master passed

+1
shadedjars
254
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
481
master passed

+1
javadoc
149
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
234
the patch passed

+1
compile
207
the patch passed

+1
javac
207
the patch passed

+1
checkstyle
35
The patch passed checkstyle in hbase-client

+1
checkstyle
81
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
33
The patch passed checkstyle in hbase-thrift

+1
checkstyle
11
The patch passed checkstyle in hbase-shell

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
17
The patch passed checkstyle in hbase-rest

-1
rubocop
18
The patch generated 4 new + 816 unchanged - 6 fixed = 820 total (was 822)

+1
ruby-lint
4
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
257
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
491
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
488
the patch passed

+1
javadoc
151
the patch passed

_ Other Tests _

+1
unit
198
hbase-client in the patch passed.

-1
unit
15792
hbase-server in the patch failed.

-1
unit
1512
hbase-mapreduce in the patch failed.

+1
unit
339
hbase-thrift in the patch passed.

+1
unit
628
hbase-shell in the patch passed.

+1
unit
298
hbase-endpoint in the patch passed.

+1
unit
521
hbase-rest in the patch passed.

+1
asflicense
230
The patch does not generate ASF License warnings.

23403

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncRegionAdminApi2

hadoop.hbase.quotas.TestSpaceQuotas

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 7028f971968f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c0d59541a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.68.1

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/artifact/out/diff-patch-rubocop.txt

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/testReport/

Max. process+thread count
5212 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/9/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
244
master passed

+1
compile
207
master passed

+1
checkstyle
203
master passed

+1
shadedjars
262
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
427
master passed

+1
javadoc
144
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
248
the patch passed

+1
compile
207
the patch passed

+1
javac
207
the patch passed

+1
checkstyle
37
The patch passed checkstyle in hbase-client

+1
checkstyle
81
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
33
The patch passed checkstyle in hbase-thrift

+1
checkstyle
12
The patch passed checkstyle in hbase-shell

+1
checkstyle
12
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

-1
rubocop
18
The patch generated 1 new + 817 unchanged - 5 fixed = 818 total (was 822)

+1
ruby-lint
3
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
258
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
497
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
536
the patch passed

+1
javadoc
171
the patch passed

_ Other Tests _

+1
unit
213
hbase-client in the patch passed.

-1
unit
16272
hbase-server in the patch failed.

-1
unit
1605
hbase-mapreduce in the patch failed.

+1
unit
328
hbase-thrift in the patch passed.

+1
unit
637
hbase-shell in the patch passed.

+1
unit
304
hbase-endpoint in the patch passed.

+1
unit
589
hbase-rest in the patch passed.

+1
asflicense
176
The patch does not generate ASF License warnings.

23995

Reason
Tests

Failed junit tests
hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput

hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.client.TestAdmin1

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 2c63440e4ff9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c0d59541a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.68.1

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/artifact/out/diff-patch-rubocop.txt

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/testReport/

Max. process+thread count
5282 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/10/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Will wait on this one until HBASE-22358 is in, which should solve the rubocop issue.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
243
master passed

+1
compile
194
master passed

+1
checkstyle
189
master passed

+1
shadedjars
258
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
438
master passed

+1
javadoc
149
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
236
the patch passed

+1
compile
210
the patch passed

+1
javac
210
the patch passed

+1
checkstyle
35
The patch passed checkstyle in hbase-client

+1
checkstyle
84
hbase-server: The patch generated 0 new + 702 unchanged - 11 fixed = 702 total (was 713)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
33
The patch passed checkstyle in hbase-thrift

+1
checkstyle
12
The patch passed checkstyle in hbase-shell

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
rubocop
19
The patch generated 0 new + 577 unchanged - 4 fixed = 577 total (was 581)

+1
ruby-lint
4
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
257
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
489
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
511
the patch passed

+1
javadoc
150
the patch passed

_ Other Tests _

+1
unit
196
hbase-client in the patch passed.

-1
unit
13866
hbase-server in the patch failed.

+1
unit
1205
hbase-mapreduce in the patch passed.

+1
unit
306
hbase-thrift in the patch passed.

+1
unit
602
hbase-shell in the patch passed.

+1
unit
280
hbase-endpoint in the patch passed.

+1
unit
456
hbase-rest in the patch passed.

+1
asflicense
173
The patch does not generate ASF License warnings.

20916

Reason
Tests

Failed junit tests
hadoop.hbase.master.TestMasterOperationsForRegionReplicas

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 8dba5d297d70 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 420fbba6ae

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.68.1

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/13/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/13/testReport/

Max. process+thread count
5306 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/13/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
125
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
250
master passed

+1
compile
201
master passed

+1
checkstyle
208
master passed

+1
shadedjars
267
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
504
master passed

+1
javadoc
167
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
247
the patch passed

+1
compile
210
the patch passed

+1
javac
210
the patch passed

+1
checkstyle
36
The patch passed checkstyle in hbase-client

+1
checkstyle
83
hbase-server: The patch generated 0 new + 645 unchanged - 11 fixed = 645 total (was 656)

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
34
The patch passed checkstyle in hbase-thrift

+1
checkstyle
11
The patch passed checkstyle in hbase-shell

+1
checkstyle
15
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
rubocop
19
The patch generated 0 new + 588 unchanged - 4 fixed = 588 total (was 592)

+1
ruby-lint
3
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
768
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.0.

+1
findbugs
535
the patch passed

+1
javadoc
147
the patch passed

_ Other Tests _

+1
unit
194
hbase-client in the patch passed.

-1
unit
14794
hbase-server in the patch failed.

+1
unit
1319
hbase-mapreduce in the patch passed.

+1
unit
289
hbase-thrift in the patch passed.

+1
unit
667
hbase-shell in the patch passed.

+1
unit
294
hbase-endpoint in the patch passed.

+1
unit
453
hbase-rest in the patch passed.

+1
asflicense
221
The patch does not generate ASF License warnings.

22598

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL

hadoop.hbase.replication.TestReplicationSyncUpTool

hadoop.hbase.master.TestSplitWALManager

hadoop.hbase.master.procedure.TestSCPWithReplicas

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux e2613d5dadf1 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master /<PHONE_NUMBER>

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.69.0

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/14/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/14/testReport/

Max. process+thread count
5227 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/14/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Re-ran checks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 43 new or modified test files.

_ master Compile Tests _

0
mvndep
26
Maven dependency ordering for branch

+1
mvninstall
254
master passed

+1
compile
203
master passed

+1
checkstyle
207
master passed

+1
shadedjars
268
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
457
master passed

+1
javadoc
147
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
243
the patch passed

+1
compile
235
the patch passed

+1
javac
235
the patch passed

+1
checkstyle
39
The patch passed checkstyle in hbase-client

+1
checkstyle
88
hbase-server: The patch generated 0 new + 645 unchanged - 11 fixed = 645 total (was 656)

+1
checkstyle
21
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
36
The patch passed checkstyle in hbase-thrift

+1
checkstyle
11
The patch passed checkstyle in hbase-shell

+1
checkstyle
14
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
17
The patch passed checkstyle in hbase-rest

+1
rubocop
22
The patch generated 0 new + 590 unchanged - 4 fixed = 590 total (was 594)

+1
ruby-lint
5
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
294
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
765
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
545
the patch passed

+1
javadoc
172
the patch passed

_ Other Tests _

+1
unit
201
hbase-client in the patch passed.

+1
unit
15289
hbase-server in the patch passed.

+1
unit
1559
hbase-mapreduce in the patch passed.

+1
unit
447
hbase-thrift in the patch passed.

-1
unit
1209
hbase-shell in the patch failed.

+1
unit
333
hbase-endpoint in the patch passed.

+1
unit
554
hbase-rest in the patch passed.

+1
asflicense
274
The patch does not generate ASF License warnings.

24406

Reason
Tests

Failed junit tests
hadoop.hbase.client.rsgroup.TestShellRSGroups

hadoop.hbase.client.TestShell

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux eb74e77d112c 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 2e9087bfb7

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.71.0

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/15/artifact/out/patch-unit-hbase-shell.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/15/testReport/

Max. process+thread count
4840 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/15/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
171
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 42 new or modified test files.

_ master Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
229
master passed

+1
compile
197
master passed

+1
checkstyle
179
master passed

+1
shadedjars
247
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
445
master passed

+1
javadoc
136
master passed

_ Patch Compile Tests _

0
mvndep
12
Maven dependency ordering for patch

+1
mvninstall
222
the patch passed

+1
compile
195
the patch passed

+1
javac
195
the patch passed

+1
checkstyle
32
The patch passed checkstyle in hbase-client

+1
checkstyle
69
hbase-server: The patch generated 0 new + 610 unchanged - 11 fixed = 610 total (was 621)

+1
checkstyle
15
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
29
The patch passed checkstyle in hbase-thrift

+1
checkstyle
10
The patch passed checkstyle in hbase-shell

+1
checkstyle
11
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
13
The patch passed checkstyle in hbase-rest

+1
rubocop
17
The patch generated 0 new + 590 unchanged - 4 fixed = 590 total (was 594)

+1
ruby-lint
4
There were no new ruby-lint issues.

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedjars
246
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
690
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
488
the patch passed

+1
javadoc
135
the patch passed

_ Other Tests _

+1
unit
191
hbase-client in the patch passed.

-1
unit
15042
hbase-server in the patch failed.

+1
unit
1259
hbase-mapreduce in the patch passed.

+1
unit
276
hbase-thrift in the patch passed.

+1
unit
683
hbase-shell in the patch passed.

+1
unit
238
hbase-endpoint in the patch passed.

+1
unit
420
hbase-rest in the patch passed.

+1
asflicense
181
The patch does not generate ASF License warnings.

22495

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestAsyncRegionAdminApi

hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 43a91ba8e8d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 99ea828d1c

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.71.0

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/16/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/16/testReport/

Max. process+thread count
5685 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/16/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

The test failures seem unrelated. @saintstack Should we bring it in?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
8
https://github.com/apache/hbase/pull/170 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/170

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/17/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Agree the failures seem unrelated. Build is erratic these times though. I just started a new one. Lets see if it any better.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
6
https://github.com/apache/hbase/pull/170 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/170

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/18/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
178
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 40 new or modified test files.

_ master Compile Tests _

0
mvndep
26
Maven dependency ordering for branch

+1
mvninstall
249
master passed

+1
compile
210
master passed

+1
checkstyle
208
master passed

+1
shadedjars
267
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
459
master passed

+1
javadoc
150
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
241
the patch passed

+1
compile
212
the patch passed

+1
javac
212
the patch passed

+1
checkstyle
36
The patch passed checkstyle in hbase-client

+1
checkstyle
80
hbase-server: The patch generated 0 new + 604 unchanged - 11 fixed = 604 total (was 615)

+1
checkstyle
18
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
32
The patch passed checkstyle in hbase-thrift

+1
checkstyle
11
The patch passed checkstyle in hbase-shell

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
rubocop
19
The patch generated 0 new + 590 unchanged - 4 fixed = 590 total (was 594)

+1
ruby-lint
3
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
731
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
506
the patch passed

+1
javadoc
150
the patch passed

_ Other Tests _

+1
unit
208
hbase-client in the patch passed.

-1
unit
16368
hbase-server in the patch failed.

+1
unit
1548
hbase-mapreduce in the patch passed.

+1
unit
368
hbase-thrift in the patch passed.

+1
unit
933
hbase-shell in the patch passed.

+1
unit
284
hbase-endpoint in the patch passed.

+1
unit
508
hbase-rest in the patch passed.

+1
asflicense
188
The patch does not generate ASF License warnings.

24927

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestMobSnapshotCloneIndependence

hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux 95d8f2f183fa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 03436e68bc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.71.0

ruby-lint
v2.3.1

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/19/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/19/testReport/

Max. process+thread count
5403 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/19/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
166
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 40 new or modified test files.

_ master Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
281
master passed

+1
compile
207
master passed

+1
checkstyle
200
master passed

+1
shadedjars
268
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
470
master passed

+1
javadoc
140
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
251
the patch passed

+1
compile
208
the patch passed

+1
javac
208
the patch passed

+1
checkstyle
37
The patch passed checkstyle in hbase-client

+1
checkstyle
84
hbase-server: The patch generated 0 new + 604 unchanged - 11 fixed = 604 total (was 615)

+1
checkstyle
18
hbase-mapreduce: The patch generated 0 new + 29 unchanged - 3 fixed = 29 total (was 32)

+1
checkstyle
33
The patch passed checkstyle in hbase-thrift

+1
checkstyle
12
The patch passed checkstyle in hbase-shell

+1
checkstyle
13
The patch passed checkstyle in hbase-endpoint

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
rubocop
19
The patch generated 0 new + 590 unchanged - 4 fixed = 590 total (was 594)

+1
ruby-lint
3
There were no new ruby-lint issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
270
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
750
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
501
the patch passed

+1
javadoc
152
the patch passed

_ Other Tests _

+1
unit
203
hbase-client in the patch passed.

+1
unit
14162
hbase-server in the patch passed.

+1
unit
1501
hbase-mapreduce in the patch passed.

+1
unit
325
hbase-thrift in the patch passed.

+1
unit
721
hbase-shell in the patch passed.

+1
unit
261
hbase-endpoint in the patch passed.

+1
unit
489
hbase-rest in the patch passed.

+1
asflicense
239
The patch does not generate ASF License warnings.

22451

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/21/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/170

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  rubocop  ruby_lint

uname
Linux affd8582c9bc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 1712d2b568

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

rubocop
v0.71.0

ruby-lint
v2.3.1

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/21/testReport/

Max. process+thread count
5623 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-170/21/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


TCK RestClientSpanTest Span Name Doesn't Follow Semantic Conv

Description

Based on OpenTelemetry Semantic conventions for HTTP spans "Instrumentation MUST NOT default to using URI path as span name, but MAY provide hooks to allow custom logic to override the default span name."
Meanwhile, I found in the TCK use URI path as the span name  Assert.assertEquals(server.getName(), url.getPath() + "span");
As the guideline span name described "an RPC method name, a function name, or the name of a subtask or stage within a larger computation" is a good example

To expand what @arieki is referring to:
Assertions for server span names in the TCK are incorrect, or go beyond specification.
MP Tracing spec says:

These should follow the rules specified in the Semantic Conventions section. https://github.com/eclipse/microprofile-telemetry/blob/main/tracing/spec/src/main/asciidoc/microprofile-telemetry-tracing-spec.asciidoc?plain=1#L87

The word "should" indicate optional requirement. If we take it one step further, Semantic conventions for HTTP spans also use word "should" to describe the requirement.
If the spec would say, that compatible implementation MUST follow recommendations given for http span names set forth by conventions, then checking for those span names would be reasonable.
However, in that case, the span names that are validated now are not the ones set forth by convention:

HTTP server span names SHOULD be {http.method} {http.route} if there is a (low-cardinality) http.route available. HTTP server span names SHOULD be {http.method} if there is no (low-cardinality) http.route available.

Test expect client spans to be called HTTP GET, whereas convention recommends GET.
Server spans should be called HTTP {route} and TCK tests for {route}.

This issue lists several problems that I'd like to address individually:

the span names that are validated now are not the ones set forth by convention [...] HTTP server span names SHOULD be {http.method} {http.route}

This is true for the current version of the OpenTelemetry specification, but MicroProfile Telemetry 1.0 is based on v1.13.0 of OpenTelemetry and this section of the spec has changed since then. The relevant part in 1.13 doesn't suggest including the HTTP method in the name.

[The spec says] "Instrumentation MUST NOT default to using URI path as span name" [...] Meanwhile, I found in the TCK use URI path as the span name Assert.assertEquals(server.getName(), url.getPath() + "span");

The section of the spec talks about using the full URI path vs. using a more concise HTTP route. The example given is /api/users/123 vs. /api/users/{user_id}. The spec does say you must not default to using the full URI path.
However, in the TCK test you quote the URI path has no placeholders, so the URI path and the HTTP route are the same. The TCK is expecting the HTTP route, and in this case it just happens to be the same as the full URI path.
In a later test a URI with a placeholder is used and you can see the test expects the placeholder to be used in the span name, rather than using the full URI path for the request.
Assert.assertEquals(server.getName(), (url.getPath() + "span/{name}"));

The word "should" indicate optional requirement. If we take it one step further, Semantic conventions for HTTP spans also use word "should" to describe the requirement.

I think this part is correct. The spec suggests but doesn't mandate that a particular name is used so the TCK should not test it.
I think the existing asserts for span names should be removed, though we could check to ensure that the name does not include the full URI path for the cases where the HTTP route includes placeholders.

@pdudits will take a look at this.

@pdudits will create a PR to cover this.


PLAT-80381: Lightweight spotlight poc step1

Checklist

[x] I have read and understand the contribution guide

[ ] A CHANGELOG entry is included

[ ] At least one test case is included for this feature or bug fix

[ ] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
The standardization of spatial navigation is progressing for the lightweight spotlight.
(https://drafts.csswg.org/css-nav-1/)
We need to check up the standard is appropriate to implement lightweight spotlight.
In the POC, We aim to apply the latest standard to spotlight and replace the spotlight code to spatial-navigation-polyfill.
As the first step of this POC, In this ticket, the basic arrow key function of spotlight will be replaced by precess model of standard spatial navigation-polyfill.
Resolution
Below features was implemented.

Include spatial-navigation-polyfill to spotlight package.
Remove replaceable APIs in spotlight/target.js
Remove unused APIs in spotlight/utils.js
Replace Spotlight.move APIs in moonston componenets
(Default spatial-navigation processing is recommended than explicit invoke of Spotlight.move api.)
Support container configutation.
(leave-for, reverse, enter-to :[default, last-focused], restrict-self)
Support pause and accelerator.

Additional Considerations
Links
PLAT-80381
//: # (Related issues, references)
Comments

Close as #2369 is created for better log tracking.


WFCORE-1143 Cancel button in JConsole do nothing

If we get a qa_ack on the downstream then we can get rid of the 3.x label.


⚠ ClamAV has degraded performance

In 29cf080, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 91 ms

Resolved: ClamAV performance has improved in 523cde7.


Xtensa_ESP32/port.c:305 (vPortAssertIfInISR)- assert failed!

I think I am quite close already:

I setup AWS IOT, user, etc. and created the "thing" on AWS via SetupAWS.py
I flashed the ESP-32 and it boots

During connecting to WIFI the device rebots :(
I did not find any useful information on how to troubleshoot this issue, please advice
rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:6012
load:0x40078000,len:0
load:0x40078000,len:15784
entry 0x400792e8
I (28) boot: ESP-IDF v3.1-dev-322-gf307f41-dirty 2nd stage bootloader
I (29) boot: compile time 14:18:44
I (30) boot: Enabling RNG early entropy source...
I (35) boot: SPI Speed      : 40MHz
I (39) boot: SPI Mode       : DIO
I (43) boot: SPI Flash Size : 4MB
I (47) boot: Partition Table:
I (51) boot: ## Label            Usage          Type ST Offset   Length
I (58) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (66) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (73) boot:  2 factory          factory app      00 00 00010000 00100000
I (81) boot: End of partition table
I (85) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x11f98 ( 73624) map
I (119) esp_image: segment 1: paddr=0x00021fc0 vaddr=0x3ffb0000 size=0x023ec (  9196) load
I (123) esp_image: segment 2: paddr=0x000243b4 vaddr=0x40080000 size=0x00400 (  1024) load
I (126) esp_image: segment 3: paddr=0x000247bc vaddr=0x40080400 size=0x0b854 ( 47188) load
I (154) esp_image: segment 4: paddr=0x00030018 vaddr=0x400d0018 size=0x6d3c0 (447424) map
I (310) esp_image: segment 5: paddr=0x0009d3e0 vaddr=0x4008bc54 size=0x02574 (  9588) load
I (314) esp_image: segment 6: paddr=0x0009f95c vaddr=0x400c0000 size=0x00000 (     0) load
I (325) boot: Loaded app from partition at offset 0x10000
I (325) boot: Disabling RNG early entropy source...
I (329) cpu_start: Pro cpu up.
I (332) cpu_start: Single core mode
I (337) heap_init: Initializing. RAM available for dynamic allocation:
I (343) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (349) heap_init: At 3FFC04F0 len 0001FB10 (126 KiB): DRAM
I (356) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (362) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (369) heap_init: At 4008E1C8 len 00011E38 (71 KiB): IRAM
I (375) cpu_start: Pro cpu start user code
I (57) cpu_start: Starting scheduler on PRO CPU.
I (64) wifi: wifi firmware version: f79168c
I (64) wifi: config NVS flash: enabled
I (64) wifi: config nano formating: disabled
I (64) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (74) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (94) wifi: Init dynamic tx buffer num: 32
I (94) wifi: Init data frame dynamic rx buffer num: 32
I (94) wifi: Init management frame dynamic rx buffer num: 32
I (104) wifi: wifi driver task: 3ffc7194, prio:23, stack:4096
I (104) wifi: Init static rx buffer num: 10
I (114) wifi: Init dynamic rx buffer num: 32
I (114) wifi: wifi power manager task: 0x3ffcbdd0 prio: 21 stack: 2560
0 6 [main] WiFi module initialized. Connecting to AP HANAMI...

core=0 port_interruptNesting=1

/home/mark/esp/AmazonFreeRTOS/lib/FreeRTOS/portable/ThirdParty/GCC/Xtensa_ESP32/port.c:305 (vPortAssertIfInISR)- assert failed!
abort() was called at PC 0x40088a7f on core 0

Backtrace: 0x4008c23c:0x3ffb0770 0x4008c40b:0x3ffb0790 0x40088a7f:0x3ffb07b0 0x4008a052:0x3ffb07d0 0x400e957f:0x3ffb07f0 0x40081e92:0x3ffb0810 0x40008544:0x00000000

Rebooting...
ets Jun  8 2016 00:22:57
...

Hi Mark,
To help us try to reproduce the issue, can you tell us which commands you are using to build and flash the code? And is the program that you are trying to load one of the demos in the repository?
Thanks

@WRansohoff I just use the normal "make flash" command. The code I try to use is the default demo "mqtt" (no changes).

Okay, thank you for the information. The setup script might have already populated these values, but could you verify that your wifi credentials and MQTT endpoint are both correct in the demos/common/include/aws_clientcredential.h file, and that your test IoT Thing's credentials are correct in the demos/common/include/aws_clientcredential_keys.h file?
And for the sake of completeness, would you mind telling us what type of ESP32 development board you are using? Also, do you notice any long delays or pauses around the time when the ESP32 tries to connect to the access point or resets itself?
Thanks

Hi @markfink
I had a similar issue, and the problem was the power supply, it gave less voltage than indicated. I adjust correctly and the problem was gone.
A good power supply is important!
Hope it helps,
velbn

@WRansohoff thank you for your suggestions, here the info you asked for:
The WIFI config was populated just fine.
/*
 * Wi-Fi network to join.
 */
#define clientcredentialWIFI_SSID       "HANAMI"

/*
 * Password needed to join Wi-Fi network.
 */
#define clientcredentialWIFI_PASSWORD   "my_secret"

/**
 * @brief Security type
 * WPA2 Security, @see WIFISecurity_t
 * Possible values are - eWiFiSecurityOpen, eWiFiSecurityWEP, eWiFiSecurityWPA,
 * eWiFiSecurityWPA2
 */
#define clientcredentialWIFI_SECURITY   eWiFiSecurityWPA2

About the board... it is sold by AZDelivery - unfortunately I can not say much more (I know ESP-8266 but am new to ESP-32) (https://www.amazon.de/gp/product/B071P98VTG/ref=oh_aui_search_detailpage?ie=UTF8&psc=1)
@velbn Thank you very much. I think this is a great suggestion. I try this asap and report back.

WIFI connection works now with a dedicated power supply. Thank you so much!

Great, thank you @velbn ! I'm glad that fixed the issue.
I'll go ahead and close this, but feel free to re-open it if you have any more questions.


V1 refactor

This PR introduces major changes:

to how data is stored and managed
to the base ImportData class
to how data updates are managed
to testing
and on the back end to poetry, etc.

These are doubtless breaking changes.

closes #92.
closes #124


"Orchestrating microservices" tutorial or sample project

As a beginner, right now I am a bit lost how to "glue everything together".
A bigger example project answering the following would be great:

Can I just use now services (Path Alias, Secrets, etc.) to create a complete application based on microservices. Or do I need anything more (see next question)?
What third party tools do you recommend / use? As a beginner I find Nginx, JHipster, Amalgam8, Linker-D, etc. Do I need any of these?
How should two microservices communicate? Just call fetch()?
How to use JWT? How to share a signing secret?
How to use path alias rules? (https://zeit.co/docs/features/path-aliases)
What is the recommended folder structure for a project containing multiple microservices? (e.g. where to put the secrets, build scripts, rules.json)

I'd like some guidance to cluster. There's the micro-cluster package, but I'm not entirely sure if I should just use pm2's clustering... or perhaps not use micro-cluster and just make my micro service use docker, then I can use docker swarm...? (They're probably all valid I guess)

Update: Each micro service is now alone in his own git repo. My "main repo" just uses one "rules.json" and holds the DOCs and a few scripts. If you use now, this is the way to go, but if you don't, you are on your own here...
 It is indeed not a job of micro to show you how to glue two running servers, because that is a specific problem that depends on the deploy platform.

@tmornini @brandondees great discussion on microservice architectures. some questions i've had myself.
@obiwarn #FunFact At minimum fetch is all the "Bus stops" you need. Although many feel the need for added complexity as a security blanket. YMMV.

Now 2.0 solves a lot of the questions you have/had: https://zeit.co/blog/now-2


Include image of files to make Dockerfile type clear

File: get-started/part2.md
This image or a similar image would be helpful in showing that a Dockerfile does not have an extension (like .git files).

Hi @participator Thanks for the feedback! We just updated the whole Get Started guide to align with current best practices. As a bonus, we also removed the steps that you allude to above.
Love to hear your feedback on the updated guide.


Fix wrong behavior of getSymbolsByUDA if one of the symbols having th…

…e UDA is a function
The last change to getSymbolsByUDA introduced a bug, causing it to ignore some symbols

As this is a regression it would be great if you could open an issue for it and reference it in the commit message (git commit --amend).
Also it should be rebased to stable:
git rebase --onto upstream/stable upstream/master

See the message of dlang-bot for details.

See also https://github.com/dlang/phobos/pull/6292 - that's why linking to the PR is a good idea ...

This is my first Pull Request / Issue here so i didn't tough of doing it. I hope i remember doing it next time :)

No worries. Nobody is perfect - especially on the first run.
Thanks a lot for your contribution! This will be part of of 2.079.1 - it will be released ~ 1.4.18


Tag v0.18.0

Looking over tags in the bevy_asset_loader repo, there is no v0.18.0 tag, even thou a v0.18.0 version exists on crates.io.

Thanks, the tag is pushed now.


Updating labels to match EOM names and add EOM indicator

This PR changes the "Cancer Subtype" label to "Histology" and the "Cancer Type" label to "Cancer Diagnosis" and adds a "ⓘ" next to any EOM fields with an accompanying note at the bottom saying they are EOM fields.

Hi Dylan!
Two things:

The ticket OSHRTT-80 also lists Histology and Biomarker Status as EOM data elements, but it looks like these two fields are missing the information icon.
On certain screen sizes (or when the screen doesn't show the bottom the form), it's a little bit confusing to me to see the information icon with no tool tip that appears from hovering. Is there a reason why we don't use perhaps a different icon or have a hovering tooltip? I know you've implemented what the ticket says, but I'm wondering if we should do something differently.

Hi Dylan! Thanks for those changes. Can you just resolve the two workflow issues with the tests?


ViewBar feedback part 1

What changes are proposed in this pull request?
This is almost ready. I would like to add error messages to the JSON editor, and test some things to make sure there are not any major regressions.
Error messages, keyword argument and type annotation placeholders, style and animation tweaks, and some improvements to focusing in and out of parameters and stages.
Enter on an invalid stage or parameter value no longer reverts or deletes stages.
How is this patch tested? If it is not, in a single sentence please explain why.
Human tested.
Release Notes
Is this a user-facing change?

[ ] No. You can skip the rest of this section.
[x] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

Error messages, keyword arguments and type annotation placeholders, and general form filling improvements have been added to the ViewBar.
What areas of FiftyOne does this PR affect?

[x] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Should this PR be mentioned in the release notes? If so, please choose on category:

[ ] breaking-change - The PR will be mentioned in the "Breaking Changes"
section
[x] feature - A new user-facing feature worth mentioning in the release
notes
[ ] bug-fix - A user-facing bug fix worth mentioning in the release notes
[ ] documentation - A user-facing documentation change worth mentioning
in the release notes

This is ready for review. Much of this work will be cleaned up as keyboard shortcuts, and the new focus/commit rules are added.

One minor issue I noticed: selecting "Take", entering a value, then pressing enter in the seed cell when it's blank gets rid of the value (and then the stage, if it loses focus). Once the stage has been finalized, pressing enter in an empty seed cell works.

Thanks for the review. I'll work on these changes.

I pushed some error message tweaks, per your suggestions. It will be easier to resolve the issue you mentioned with "Take" in my second ViewBar PR.
Right now, you have to double click off of a stage error in order to make it disappear. Again, this issue will be easier to resolve in my the next PR.
I hope to have it up today or tomorrow morning, but I can't make any promises.


Fix flappy test

To fix the flappy test detected when we merged #782 to master (see: https://ci.dev.publishing.service.gov.uk/job/govuk_manuals_publisher/722/)

This didn't quite get to the bottom of it as I got a local failure about dates in manual_publication_log_filter_spec.  I think we need to be even more explicit about the dates of the editions in this spec to make sure stuff will be in the right order.  /cc @NeilvB


PR: Add open collective URL

Add open collective urls and links on README
https://opencollective.com/spyder

To see how it looks click this

I'm going to rework this a little bit before merging. I hope to do it tomorrow.

@goanpeca, what do you think about the text I added?
Please also take a look at
https://github.com/spyder-ide/spyder/wiki/Anaconda-stopped-funding-Spyder

@ccordoba12 looks good, feel free to merge :-)

It seems Appveyor is having problems because there are several bulds queued since yesterday, so I'm merging this one without waiting for it.


Express Route / VPN Access to On-Premise

Please provide details on the requirements when utilizing Express Route or VPN to access to on-premise data sources.
Many questions regarding if the on-premise data gateway is still a requirement etc...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c34c249-033f-4156-0abc-8d16cbe355a0
Version Independent ID: 20dc29c2-9cb7-2322-e80b-3f801bc34cfe
Content: Power BI data sources - Power BI
Content Source: powerbi-docs/connect-data/power-bi-data-sources.md
Service: powerbi
Sub-service: pbi-data-sources
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Hi, @djpirra -- thanks for asking! Assigning to the author to look into it.

Thanks for your comment, @djpirra. This looks like a support request rather than documentation feedback, especially for this article. You might find a solution in the Power BI Community, found at https://community.powerbi.com. If not, you can get support by going to https://support.powerbi.com.

Hi David,
Thank you for your comment.
I really believe that this information would be valuable to have on the
technical documentation and available for all of the infrastructure and
networking architects and in order for them to make reliable and timely
decisions.
Obtaining support from the community is great but now always considered by
customers as a trusted source specially regarding networking or security
concerned topics.
Thank you
Regards,
LS
On Wed, 8 Dec 2021 at 1:09 AM David Iseminger @.***>
wrote:

Thanks for your comment, @djpirra https://github.com/djpirra. This
looks like a support request rather than documentation feedback, especially
for this article. You might find a solution in the Power BI Community,
found at https://community.powerbi.com. If not, you can get support by
going to https://support.powerbi.com.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/powerbi-docs/issues/2992#issuecomment-988264852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZ5Q5UYXCVJK3LXZXFZVOTUPZZXDANCNFSM43L3RCIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Melhores Cumprimentos,
Luis Simões


CF Onboarding Week, SF, Oct 8

@ljfranklin
Checklist
Communication

[x] Send out an email to each of the participants. You can find a template in FACILITATING.md.

IaaS Setup

[x] Make sure you have clean GCP projects set up. In SF, we use cf-sf-onboarding-env-1, cf-sf-onboarding-env-2, and cf-sf-onboarding-env-3, which already exist. Otherwise, fill out this form to create new environments.
[x] Add all participants as owners to each of the GCP projects.
[x] For GCP track only: Ensure access to CF-Onboarding-dns project for DNS propagation.

Tracker Setup

[x] Make sure you have Tracker projects prepared. Again, in SF we re-use the same tracker projects for Pair 1, Pair 2, and Pair 3.
[x] Add all participants as members to each of the tracker projects.

Workstation Setup

[ ] Make sure you have a workstation for each pair.
[ ] Re-image each machine. Here are the steps:

[ ] Run Startup Disk.
[ ] Unlock with the workstation password (you may need to ask the previous facilitator for the machine's password).
[ ] Select the network disk and click restart. It will likely be the rightmost start disk, and will definitely include the phrase "Network Disk." If you don't see that, try restarting the machine and try again.
[ ] Select deployment option 2, "macOS Sierra" and click the play button. If you look in between the parens of the option name, you'll see the default password for the image. A terminal will open and you’ll see a lot of output, including a bunch of lines that say installer: PHASE: Running package scripts. Don’t worry, this is fine. The boot script will search for updates -- you’ll see output about OS X, iTunes, and Safari updates, for example -- and the machine will probably restart a few times as it downloads and installs the updates.
[ ] Log into machine with the default password.
[ ] Open the security preferences and change the password to something sane. Write this down so you can give it to the participants later.
[ ] Open a terminal window and runcurl -LOk https://github.com/pivotal-cf-experimental/onboarding-week-construct/archive/master.zip
unzip master.zip
cd onboarding-week-construct
./construct

You'll need to babysit this process, as it will prompt you for the password several times.
Record any issues you have with this process so we can update this checklist.

Scheduling

[x] Schedule a welcome/orientation session for Monday morning. Discuss the goals of the week and prime the participants to consider what they'd like to get out of Onboarding week.
[x] Schedule daily standup.
[x] Schedule afternoon check in.
[x] Schedule retro at the end of the week.
[x] Schedule any sessions that you know the group would be interested in -- for example, BOSH boxes and lines.

Finished workstation setup. Found a couple issues, but they were resolved.

Network disk consistently didn't appear

Solution: Ensuring the ethernet cable was attached to the computer (not monitor) then restarting seemed to resolve this.

Ruby installation failed. Networking in the office has been weird regarding gems.

Solution: Switching to the WIFI for the ./construct script solved this.


Docs class based views examples naming

https://code.djangoproject.com/ticket/32271

Hi @cpina :wave:
I wonder if there are a few more examples of this?
Mixins. For example, should this be PublisherDetailView?
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/topics/class-based-views/mixins.txt#L316
Generic display views. For example, should this be PublisherListView
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/topics/class-based-views/generic-display.txt#L113
I think there is one example in ref/class-based-views/base.txt
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/ref/class-based-views/base.txt#L227
Also, could you rename the commit message to past tense? (Improve -> Improved)

Hi @cpina :wave:
I wonder if there are a few more examples of this?
Mixins. For example, should this be PublisherDetailView?
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/topics/class-based-views/mixins.txt#L316
Generic display views. For example, should this be PublisherListView
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/topics/class-based-views/generic-display.txt#L113
I think there is one example in ref/class-based-views/base.txt
https://github.com/django/django/blob/4794a0e35f12c699ef4af29b355c68ca66f425aa/docs/ref/class-based-views/base.txt#L227
Also, could you rename the commit message to past tense? (Improve -> Improved)

Hey @smithdc1 :wave:
I'll make the suggested changes and revise properly the mixins and form handling sections (https://docs.djangoproject.com/en/3.1/topics/class-based-views/) as well. Thanks!

Hey @smithdc1 :wave:
I'll make the suggested changes and revise properly the mixins and form handling sections (https://docs.djangoproject.com/en/3.1/topics/class-based-views/) as well. Thanks!

I changed all (I think!) the CBV naming that are needed. Some are from the tutorial. Tomorrow I'll follow the tutorial and make sure that I haven't made any mistake there, review, squash and change the status on the ticket.

I changed all (I think!) the CBV naming that are needed. Some are from the tutorial. Tomorrow I'll follow the tutorial and make sure that I haven't made any mistake there, review, squash and change the status on the ticket.

I've pushed the latest changes, I've verified that at least what's changed is consistently changed.
Commits are squashed.
I've followed the "polls" tutorial mechanically and the CBV naming in views, urls, text seems to match all good. I've found an error in the tutorial though but not related to this, it will be in a different PR/ticket.
Thanks for reviewing, not very fun to write or review but it feels better to be a bit more consistent!

I've pushed the latest changes, I've verified that at least what's changed is consistently changed.
Commits are squashed.
I've followed the "polls" tutorial mechanically and the CBV naming in views, urls, text seems to match all good. I've found an error in the tutorial though but not related to this, it will be in a different PR/ticket.
Thanks for reviewing, not very fun to write or review but it feels better to be a bit more consistent!

Thanks @felixxm for your comments - I see what you say, I'll revise other changes with this angle and make adjustments.

Thanks @felixxm for your comments - I see what you say, I'll revise other changes with this angle and make adjustments.

Thanks @felixxm for your comments - I see what you say, I'll revise other changes with this angle and make adjustments.

I'll close this PR - I'll not have enough bandwidth for some time, I'll come back here later.
Meanwhile: if anyone else wants to take it please do so.


Make all non-test modules except for SourceKitLSP build in Swift 6 mode 🚥 swift-package-manager#7553

Depends on https://github.com/apple/swift-package-manager/pull/7553

This would have caught a race condition in background indexing that was caused by accessing CheckedIndex from multiple threads despite it not being thread-safe.

@swift-ci Please test

https://github.com/apple/swift-package-manager/pull/7553
@swift-ci Please test

https://github.com/apple/swift-package-manager/pull/7553
@swift-ci Please test Windows

https://github.com/apple/swift-package-manager/pull/7553
@swift-ci Please test

https://github.com/apple/swift-package-manager/pull/7553
@swift-ci Please test Windows


Cluster metrics

Type of PR

[ ] BUG
[x] FEAT
[ ] MAINT
[ ] DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Related to #1538, #1001, #539
Give a brief description for the solution you have provided

1. New method added to linker for computing cluster metrics.

Wasn't sure of the best location so have put below cluster_pairwise_predictions_at_threshold as closely related.
Once more metrics are added, the idea is to include an option metrics for the user to select which metrics they wish to be computed, e.g. "default", "all", or a custom list ["size", "is_bridge"]

2. New script cluster_metrics.py added to contain functions for generating the sql for computing different metrics
3. Test added for _compute_cluster_metrics

Test passes

Thank you @ADBond and @ThomasHepworth for your help and input
PR Checklist

[ ] Added documentation for changes
[ ] Added feature to example notebooks or tutorial (if appropriate)
[x] Added tests (if appropriate)
[x] Made changes based off the latest version of Splink
[x] Run the linter

I'll defer to @ADBond for useful feedback, but from my point of view this is a good start to making metrics available in order to facilitate the hopefully trivial step of adding chosen metrics to edge/cluster tables on request in order to make them available to cluster studio etc.

Thank you @samnlindsay and @ADBond
@ADBond, have addressed both your comments and method still seems to be working as intended 🤞.
Additional small name change to an arg of the sql generating function to _unique_id_col as I think it's clearer and more in keeping with how things are written in the rest of the codebase


Update Tutorial.md

removing extra quotes discovered by Allison

+1

Coverage remained the same at 82.992% when pulling f84e5bcd7e00f179a693f12fad1917c973a18579 on tutorial-fix into 59b4f384765520f3d44aabd7b690471270f2f68d on develop.


navigator_main: include fix for FLT_EPSILON

inorder to use FLT_EPSILON, float.h file has to be included

Thanks! I fixed this already in parallel, sorry!


Telegram bot as UI

We'd just require a GPU. If we have access to free GPU-hours I guess we could make a twitter/facebook/telegram/... bot

We are using Ayrshare to automate social posting which at least allows to post to telegram automatically.

We are using Ayrshare to automate social posting which at least allows to post to telegram automatically.

So we can also create a telegram channel for it to post all the updates. Maybe we can postpone the inputs from telegram for now until we have the free GPU hours.

https://github.com/pollinations/pollinations/blob/master/app/src/backend/functions/social-post.js

528b5a786ada23148809067ae8fdf1fe30d9202b


Support for IE8

I've been really impressed working through the tutorial of angular-meteor and it solves a lot of headaches I am having with the current mean stack I am using so I'm looking to port my app across.
I need to support IE8 at the moment which means the 1.2 branch of angular, although it's possible that most of my app will work with the latest version?
Is there anyway to drop back to a previous version of angular or will this cause issues with angular-meteor?

Yes, you just need to:
meteor add<EMAIL_ADDRESS>
To you app as a hard dependency.


hac/model.py: Avoid using pop to remove items from similarity matrix

ValueSortedDict could return an error, when pop was called (perhaps due
to the optimization reason).
Instead of calling pop to remove items from a similarity matrix, this
commit creates a new ValueSortedDict, and replaces the old one with the
new one without the old indexes.

Thanks for this workaround but I believe the original error in FaceClustering is due to an outdated version of sortedcontainers or sortedcollections. Can you try with the latest version?

The issue was the versions of sortedcontainers and sortedcollections.
https://github.com/pyannote/pyannote-video/issues/34#issuecomment-418063397


Child state loose concatinated UrlMatcher params

StateBuilder has a bug in params section:
var stateBuilder = {
...
    params: function(state) {
      return state.parent && state.parent.params ? extend(state.parent.params.$$new(), state.ownParams) : new $$UMFP.ParamSet();
    },
...
};

After extend state.ownParams loose its prototype relation to $parent and its throw error on params validation.
Knowing that you are very quickly released, I wrote a fix for yourself and other people, who can not wait:
$stateProvider.decorator('params', function(state, builder) {
    var mergedParams = mergeParams(state.ownParams);

    if (state.parent && state.parent.params) {
        return angular.extend(state.parent.params.$$new(), mergedParams);
    } else {
        return new $urlMatcherFactoryProvider.ParamSet();
    }
});

function mergeParams(params) {
    var chain = [ new $urlMatcherFactoryProvider.ParamSet()],
          parent = params;

    while (parent) {
        chain.push(parent);
        parent = parent.$$parent;
    }

    return angular.extend.apply(null, chain);
}

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


[Build] Pass pkgconfig args when compiling ClangModule

No test case yet

I think we need to find a way to get a test case for this.

@swift-ci please test

@swift-ci please test

CI is down, tested locally


Set upload_max_filesize to 128M to allow larger image uploads.

The default is 2M, which is much too small for many images from museum websites.
Also added feedback when a user attempts to upload an image that is too large.

Hi, Job, sorry for the delay. I'll keep reviewing this, but I'll show you what I'm seeing so far, even though I don't know how to fix it yet.

With the changes to config/php/fpm/standardebooks.*.ini, I can now upload large images. Yay!
When I remove the changes, or set them to something lower like

post_max_size = 10M
upload_max_filesize = 10M

I don't get an error message in the browser. Instead, the submit form silently fails and returns to the blank form. In the error log (/var/log/local/www-error.log), I see:
[Sun Oct 01 03:41:09.358363 2023] [proxy_fcgi:error] [pid 2060823:tid<PHONE_NUMBER>06400] [client
<IP_ADDRESS>:46552] AH01071: Got error 'PHP message: PHP Warning:  POST Content-Length of 14399805
bytes exceeds the limit of 10485760 bytes in Unknown on line 0PHP message: PHP Fatal error:  Uncaught
TypeError: Artwork::Build(): Argument #1 ($artistName) must be of type string, null given, called in
/standardebooks.org/web/www/artworks/post.php on line 24 and defined in
/standardebooks.org/web/lib/Artwork.php:280\nStack trace:\n#0
/standardebooks.org/web/www/artworks/post.php(24): Artwork::Build()\n#1 {main}\n  thrown in
/standardebooks.org/web/lib/Artwork.php on line 280', referer: https://<IP_ADDRESS>/artworks/new

It looks like something is failing before your filesize checking is kicking in. I'll keep trying to make sure I'm not missing something.

Hmm, good catch. I guess I was mostly testing with upload_max_filesize and added post_max_size later. It appears that post_max_size gets checked before upload_max_filesize, and PHP doesn't really provide a way of handling requests that are too large.
I've added feedback for when the request is too large, but I'm not very happy with it. For one thing, we can't restore the form values (because PHP doesn't even store them). A better user experience would be to set a very high post_max_size (or unsetting it with post_max_size = 0), so that we hit the validation around uploaded files instead. I'm not really sure of the implications of allowing very large requests for the entire site though, so I'll probably leave that up to @acabal.

Unfortunately PHP has very weak support for checking for requests that are too large. All we can do is set some reasonable anti-spam upper bound like 64MB, and make the publicly advertised limit much lower, like 32MB.
That way the PHP script will receive any file under 64MB, and we can check the file size using PHP code to ensure its below our advertised limit of 32MB. However files over 64MB will be killed by PHP-FPM before the script is even executed, and we can't do anything about that, that's just how PHP works.

Also note that post_max_size and upload_max_filesize are subtly different: https://stackoverflow.com/questions/23686505/php-post-max-size-vs-upload-max-filesize-what-is-the-difference

+1 to setting the public limit to 32MB.

Thanks for your review; I've updated the PR with the changes you suggested.

LGTM
I tested it, and it works well. Thanks, Job!