SqlException thrown on upgrade to 4.0.0

Describe the bug
Upgraded from 3.0.1 to 4.0.0 and now cannot access the Sql Server.
I have modified the connection string:
Server=localhost;Database=SomeDb;Trusted_Connection=True;MultipleActiveResultSets=true;Connect Timeout=900;Encrypt=False;TrustServerCertificate=True
The following is the error being thrown:
Microsoft.Data.SqlClient.SqlException: A connection was successfully established with the server, but then an error occurred during the login process....

Microsoft.Data.SqlClient.SqlException
A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)
   at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParserStateObject.ThrowExceptionAndWarning(Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParserStateObject.SNIWritePacket(PacketHandle packet, UInt32& sniError, Boolean canAccumulate, Boolean callerHasConnectionLock)
   at Microsoft.Data.SqlClient.TdsParserStateObject.WriteSni(Boolean canAccumulate)
   at Microsoft.Data.SqlClient.TdsParserStateObject.WritePacket(Byte flushMode, Boolean canAccumulate)
   at Microsoft.Data.SqlClient.TdsParser.TdsLogin(SqlLogin rec, FeatureExtension requestedFeatures, SessionData recoverySessionData, FederatedAuthenticationFeatureExtensionData fedAuthFeatureExtensionData)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.Login(ServerInfo server, TimeoutTimer timeout, String newPassword, SecureString newSecurePassword)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool)
   at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides)
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerConnection.OpenDbConnection(Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenInternal(Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.Open(Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.<>c__DisplayClass18_0.<Exists>b__0(DateTime giveUp)
   at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.<>c__DisplayClass12_0`2.<Execute>b__0(DbContext c, TState s)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
   at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.Execute[TState,TResult](IExecutionStrategy strategy, TState state, Func`2 operation, Func`2 verifySucceeded)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists(Boolean retryOnNotExists)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists()
   at Microsoft.EntityFrameworkCore.Storage.RelationalDatabaseCreator.EnsureDeleted()
   at Microsoft.EntityFrameworkCore.Infrastructure.DatabaseFacade.EnsureDeleted()

Expected behavior
I thought setting Encrypt=False would solve the issue and adding TrustServerCertificate would also fix the chain check
Further technical details
Microsoft.Data.SqlClient version: nuget 4.0.0
.NET target: dotnet 6
SQL Server version:  Sql Server 2017 (14.0.3401.7)
Operating system: Windows 10 Enterprise 20H2 19042.1348
Additional context
Running previous version of the DLL just worked. But was forced to update due to an updated nuget package.

Can you test it by setting TrustServerCertificate=false;  or even taking that part out of the connection string and let the default value stay.

Putting aside our UAT, Test, Dev, Prod environments - my local environment SQL Server is setup as such:

Service runs as local administrator account (.\sql_service)
Native Client 11.0 Properites - No for both force encryption and trust server certificate
Protocols for sql server - Force encryption is no and certificate is not chosen

Exception thrown
The exception is thrown regardless if the 2 parameters are set to false, true or removed entirely or the native client properties are true or false for the trust server certificate.
A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)
This is on an AD controlled environment as well.

Putting aside our UAT, Test, Dev, Prod environments - my local environment SQL Server is setup as such:

Service runs as local administrator account (.\sql_service)
Native Client 11.0 Properites - No for both force encryption and trust server certificate
Protocols for sql server - Force encryption is no and certificate is not chosen

Exception thrown
The exception is thrown regardless if the 2 parameters are set to false, true or removed entirely or the native client properties are true or false for the trust server certificate.
A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)
This is on an AD controlled environment as well.

Forest for the trees, forest for the trees....
@JRahnama - For some reason in our unit tests the connection string was hard coded, so modifying the appsettings.json file does absolutely nothing. As such, it was trying to do a TLS connection every time. I have modified the code to use the configuration builder so this problem does not happen again.
Closing this ticket as the issue is not the library but a blind developer.

In my case, I was running mssql/server:2019-later in Docker on an Azure Pipelines build agent.
All connections failed with A connection was successfully established with the server, but then an error occurred during the pre-login handshake..
Encrypt=False in the connection string did not help.
From SQL logs, it turned out the problem was with the mounted volumes: ERROR: BootstrapSystemDataDirectories.
This is a known issue: https://github.com/microsoft/mssql-docker/issues/602#issuecomment-629193915
By not mounting Docker volumes, I could connect. So the original error message threw me off in the wrong direction, debugging SSL and TLS1.2.
Maybe this helps some others googling this.


React and dexie: “Invalid hook call” error in functional component

I'm getting the following error when using the useLiveQuery hook from dexie with react. Don't understand, none of the three cases below apply.
The error:

application.78bb5802.js:58032 Uncaught Error: Invalid hook call. Hooks can only be called inside of the >body of a function component. This could happen for one of the following reasons:

You might have mismatching versions of React and the renderer (such as React DOM)
You might be breaking the Rules of Hooks
You might have more than one copy of React in the same app

The component (Editor.js):
import React, { useState}  from "react";
import Title from './Title'
import Blocks from './Blocks'
import styled from 'styled-components'
import { useLiveQuery } from "dexie-react-hooks";
import db from '../db'

const Editor = () => {
    const [title, setTitle] = useState('');
    console.log("Editor: start - title state: " + title);

    const tag = useLiveQuery(
        () =>
          title
            ? db.tags.where('name').equals(title)
            : db.tags.toCollection().first(),
        [title]
    );

    if(!tag) {
        console.log("tag not loaded yet, returning null");
        return null;
    }

    const onTitleChange = (event) => {
        db.tags.where({ name: title }).modify((item) => item.name=event.target.value)
    }

    const EditorStyle = styled.section`
        padding: 10px;
        min-width: 400px;
    `;
    console.log("Rendering with title:" + title + " and tag.name: " + tag.name);
    return (
        <EditorStyle>
            <Title
                onTitleChange={onTitleChange}
                title={tag?.name}
            />
            <Blocks
                tag={tag?.name}
            />
        </EditorStyle>
    )
}

export default Editor;

The database (db.js)

db.version(1).stores({
tags: &name, *tags,
blocks: tag, content
});

The db is prepopulated with one value

db.tags.add({name: "First page"});

Using react 17.0.1.
What am I doing wrong?
Thanks!

Communication on this question continues on: https://stackoverflow.com/questions/65647432/react-and-dexie-invalid-hook-call-error-in-functional-component/65651516?noredirect=1

Communication on this question continues on: https://stackoverflow.com/questions/65647432/react-and-dexie-invalid-hook-call-error-in-functional-component/65651516?noredirect=1


🚀 [Feature] : Query for users that are not blocked by the current user

https://github.com/languageXchange/languageXchange/blob/b6decbb4c64793c1530c153f96352d01cb7c9244/src/app/services/chat/room.service.ts#L74
It is for following functions

[x] listUsers
[ ] listRooms

listRooms(
  currentUser: User,
  offset?: number
): Observable<listRoomsResponseInterface> {
  // Define queries
  const queries: any[] = [];

  // TODO: #340 Query for users that are not blocked by the current user
  // if (currentUser?.blockedUsers) {
  //   currentUser.blockedUsers.forEach((id) => {
  //     queries.push(Query.notEqual('users', id));
  //   });
  // }

)

Waiting for https://github.com/appwrite/appwrite/issues/8301


Disable multiple selection

I'm trying to disable multiple selection as per the example at https://www.jstree.com/docs/config/. It needs to be an item passed to the 'core' config element. I can't see a way to get it through, based on the options exposed to ember and then all the way through to the configObject ie https://github.com/ritesh83/ember-cli-jstree/blob/master/addon/components/ember-jstree.js.
Is there a workaround or trick I have missed?

Hi @eddiesholl looks like we missed that option. Can you provide a pull request? Thanks!

So how does one set core options with this pr?


Need Help on writing Javascript code

Hey folks!
Contributor need to write a code that get prompt from the user as input and need to print the output in html file with help of Google Bard API. If you're interested to work on this issue. Just comment below your email id. And I'll send the API Key only for you

Hi, i am interested my email address --><EMAIL_ADDRESS>thanks

hey I am interested in this project

Hey @shauryaojaswa
@okondev2021 already assigned to this issue.  You may take a look at other issue or open some issues
Thanks,
Mohamed Mafaz PR,
Propoplex.

hey @shauryaojaswa,
I have created a file called script.mjs.
when I run node script.jsx it works fine. You need to do:

Need to declare variables from the user input
The code need to generate proposals from website command
Need to show the output in the  tag in HTML.

If you completed it and open a PR. I can assign this issue & merge it.

Hey! Any Updates

Trying to get some things right. Using bard
On Thu, Jun 8, 2023, 3:58 AM Mohamed Mafaz P R @.***>
wrote:

Hey! Any Updates
—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1581816056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26WLH2ZLOF45QYRCDIDXKE5UVANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Also do you have the documentation, if you do please send
On Thu, Jun 8, 2023, 7:07 AM Jedidiah B Okon @.***> wrote:

Trying to get some things right. Using bard
On Thu, Jun 8, 2023, 3:58 AM Mohamed Mafaz P R @.***>
wrote:

Hey! Any Updates
—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1581816056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26WLH2ZLOF45QYRCDIDXKE5UVANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Also did you get the json file, i am new to using Google bard api. If you
have any resources i can use please let me know.
On Thu, Jun 8, 2023, 7:36 AM Jedidiah B Okon @.***> wrote:

Also do you have the documentation, if you do please send
On Thu, Jun 8, 2023, 7:07 AM Jedidiah B Okon @.***> wrote:

Trying to get some things right. Using bard
On Thu, Jun 8, 2023, 3:58 AM Mohamed Mafaz P R @.***>
wrote:

Hey! Any Updates
—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1581816056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26WLH2ZLOF45QYRCDIDXKE5UVANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Or we can use chatgpt
On Thu, Jun 8, 2023, 7:07 AM Jedidiah B Okon @.***> wrote:

Trying to get some things right. Using bard
On Thu, Jun 8, 2023, 3:58 AM Mohamed Mafaz P R @.***>
wrote:

Hey! Any Updates
—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1581816056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26WLH2ZLOF45QYRCDIDXKE5UVANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @okondev2021
Try using Bard. If it seems too hard to integrating Bard then go with ChatGPT API

Tried using chatgpt api, but its advisable to use a server side language to
protect the api key plus its not completely free.
If you have the documentation on how to use google bards api please send so
i can work with it.
I noticed you plan on using flask
I am still learning. Thank you
On Sat, Jun 10, 2023, 4:18 AM Mohamed Mafaz P R @.***>
wrote:

Hey @okondev2021 https://github.com/okondev2021
Try using Bard. If it seems too hard to integrating Bard then go with
ChatGPT API
—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1585443692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26QOTT4APQAKU3UJ3YDXKPRRNANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @okondev2021
Any Updates?

Yes, tested the response with bard and its working well. Have been busy
with school work sorry for the delay.

—
Reply to this email directly, view it on GitHub
https://github.com/MohamedMafaz/Propoplex/issues/33#issuecomment-1605586060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5X26S6OJIOJ2JC3NVJ43TXM4BJXANCNFSM6AAAAAAYWZUI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Okay. I'm also school student So, I can get your pain🥲
Once you're free please submit a PR


Backslash character escape in choice tabstop doesn't work

VSCode Version:

Version: 1.27.1
Commit: 5944e81f3c46a3938a82c701f96d7a59b074cfdc
Date: 2018-09-06T09:21:18.328Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

OS Version: Win 10

Steps to Reproduce:

Create a snippet like this and save it

{
    "test choice": {
        "prefix": "test",
        "body": [
            "${1|\\,,},$,\\||}"
        ],
        "description": "test choice"
    }
}

Create a new text editor tab and type test tab to trigger the snippet

Modify the snippet to add a new item that is only a backslash character \.

{
    "test choice": {
        "prefix": "test",
        "body": [
            "${1|\\,,},$,\\|,\\\|}"
        ],
        "description": "test choice"
    }
}

Trigger the snippet again and it doesn't work as expected.

The document  at https://code.visualstudio.com/docs/editor/userdefinedsnippets#_grammar says:

Below is the EBNF (extended Backus-Naur form) for snippets. With \ (backslash), you can escape $, } and . Within choice elements, the backslash also escapes comma and pipe characters.

It seems the escaping of \ doesn't work as expected. I've tried \\\, \\\\, \\\\\, \\\\\\ for them and all not work. Seems like a bug to me.

Does this issue occur when all extensions are disabled?: Yes

This will now work
"test choice": {
		"prefix": "zz",
		"body": [
			"${1|\\,,},$,\\|,\\\\|}"
		],
		"description": "test choice"
	},


Owner/Group changed on files inside excluded folder

Hi,
I've got a strange effect when using synced folders of type rsync. Configuration looks like this:
type: "rsync", owner: "www-data", group: "www-data", rsync__auto: true, rsync__exclude: [ ".git/", "foo/*" ], rsync__args: ["--verbose", "--archive", "--delete", "-z"]
foo/ is my excluded folder. /foo itself is synced but not it's content.
Everytime I change a file outside of /foo and gatling-rsync-auto syncs the change, all files inside /foo get www-data as owner and group as well. That's not what I intended. It seems the chown is done recursively ignoring any excludes.
Cheers
Etienne

Etienne,
Thanks for the bug report.
vagrant-gatling-rsync ultimately ends up invoking Vagrant core's RsyncHelper class to do syncs. Does this happen if you run vagrant rsync-auto as well?

Ok, rsync-auto behaves the same.

I created an issue at Vagrant: https://github.com/mitchellh/vagrant/issues/5256


Implement image editor

[x] Add permissions validation to image editor
[x] Add default Image permissions to seeding data
[x] Fix image editor tests
[x] Create image selector modal
[x] Bug: Dialog closes when double-clicking in Image name field or selecting text in the field
[ ] Add close button to dialog
[ ] Show selected image in image browser
[ ] Validate image groups to match or exceed post / tag groups
[ ] Add image browser menu item
[ ] Add search bar in image browser
[ ] Add drag-drop for image uploads
[ ] Add image selection tests
[ ] Add image search tests

This PR is closed in favour of a simpler approach to image handling, where images are directly attached to PostDto and TagDto documents instead of using separate documents for images. The same storage structure will still be used (S3), but file data will be directly attached to the PostDto / TagDto documents and replicated to their child ContentDto documents.


Share -> Mail should use HTML

If possible, anyway. Otherwise it should use an attributed string.

I didn't have any luck getting HTML passed through the Pasteboard.  It doesn't seem like any of the system share recipients will accept it including mail.  I didn't test it, but it might be possible to do a custom share service that uses Apple Events to talk to mail.  I'm not sure how desirable that would be with Mojave sandboxing these.
I did have success with NSAttributedString.  If you make the RTF UTI available in the Pasteboard the system share  recipients will take it.  The problem is that if you also offer up the URL UTI available they all will always select it over the RTF one.
I think the design question comes down to if we want to share the URL or the RTF via the Pasteboard?

Not going to do this one.


Forwarding messages from all channels

I only added a single channel id in allowedchannelids but still it's forwarding messages from all the channels

Oh, hello! Can you show your config.json, so I can see what is wrong?

i even tried removing channel Configs and kept only muted channel and allowed channel but still it's forwarding messages from all channels.

Are you sure you are editing config.json, not the example.config.json?

Yes bro 100% lol

Try using this config:
{
	"mutedChannelsIds": [],
	"allowedChannelsIds": [1135667594960056614],
	"allowedUsersIds": [],
	"mutedUsersIds": [],
	"channelConfigs": {
		"1141985479521226814": {
			"muted": [],
			"allowed": [1141985479521226814]
		}
	},
	"showDate": false,
	"showChat": true,
	"stackMessages": false
}

Actually, I still have no idea how this is not working

Are you sure if I do this it'll not spam the telegram channel
? Because last time I did that it spammed my channel
With links and vulgar messages

Can I have your discord?

My discord is tapnisu

Are you sure if I do this it'll not spam the telegram channel ? Because last time I did that it spammed my channel With links and vulgar messages.
Can I have your discord?

Can you invite me to server you are testing this on? It works perfectly on my machine

Ok thank you!!


Scripting: start with examples, highlight recommended commands and selectors, more

TODO:

[ ] Add “Browser support” for clearCache

Heya,
What this does
This PR restructures the Scripting doc as follows:

adds formal sections about the comments syntax and the selectors syntax
pushes examples to the top of the page (since that’s what most people are jumping to anyway)
cross-links all sections where appropriate
normalizes spacing in code blocks (eg spacing in this code snippet looks really weird today ↓) and formatting

The goal is to make it easier to scan through this doc and find what you need.
I’m comfortable if you decide to amend/reject some of the changes or all of them.
Why
WebPageTest is great. I’m loving the tool, but it still can be frustrating when you’re trying to write a scripting command, and it just doesn’t work without any clear feedback. Today, I got frustrated by this, went to scripting docs, and ⌘F-ed for “debug” out of despair – only to realize a very useful paragraph about debugging has been sitting in the document this whole time:

You won't get a lot of feedback as to why a script failed. For debugging purposes it is easiest to limit scripts to navigate and exec/execAndWait commands which can be debugged locally in a browser's dev tools.

What this tells us is nobody (including myself) ever reads docs. From my experience, people tend to scan pages across headings and jump straight to code examples. I took the liberty of restructuring the Scripting doc to make it easier to scan across it.

Removed the if section and added the clearCache one.
While we’re on it: how do I find where the command is implemented? (For example, in case I want to check the browser support.) E.g., I tried searching for expireCache in https://github.com/WPO-Foundation/webpagetest and https://github.com/WPO-Foundation/wptagent but there were zero results.

All the scripting commands are going to be in the agent itself: https://github.com/WPO-Foundation/wptagent/
Having said that, woof this PR is exposing how badly we needed to update these docs (I mean, we knew we did but still....). Looks like expireCache is no more. https://github.com/WPO-Foundation/wptagent/blob/b2a77105966b818c682476cc4bb09ed93e848dab/internal/devtools_browser.py#L604

@tkadlec Thanks for that agent link! I wasn’t sure if that’s the right one, or there’s another agent with its source code somewhere else 🙂

I updated the PR to remove expireCache and a couple other unsupported commands.

I also added supported browsers for clearCache (from what I gather, it’s supported in Chrome Desktop/Mobile + Safari on iOS):

Question re: the Selectors section. Am I getting it right that innerText and innerHtml selectors aren’t supported? I can’t see any code implements them in
https://github.com/WPO-Foundation/wptagent/blob/8351db43e0d87ec46d008adf9c7dac5f078d783f/internal/webpagetest.py#L1122-L1148
If they’re unsupported indeed, I’ll remove that section, and the PR should be done 🙂

@iamakulov It does look like they're unsupported, yeah.
Thanks for all the hard work on this! It's looking great. I think once those references are out, we're good here.

Alright, done!

@iamakulov Whew. Thanks for this!! Appreciate all the hard work. It looks great. :)


Fix relay fee issue

Creating a pool seems to not include relay fees. A user seems to get this error:
WARN mempool::pool: Transaction rejected: Transaction does not pay sufficient fees to be relayed (tx_fee: Fee(Amount { val: 216 }), min_relay_fee: Fee(Amount { val: 20800000 })).

This should never happen, given that all transactions should have exactly one unified path for calculating fees (he was using version 0.2.0).

This turned out to be an issue with 0.2.0 because relay-fee wasn't defined.


Tainted canvases may not be exported.

Hi, this is probably not an issue, but how the canvas work for security reasons. I'm currently getting images from an API with React. Im trying to print the b64 as a result from the callback, but I get that error. Is there a way I can actually handle the b64 without this problem?
The server headers are allowing almost everything.
Thank to anyone committed to help.
PD: Yeah, with local images, the package works perfectly (Currently need it to work with API's)

@MarcGodard

This is a problem with browser security. I have encountered it before, can't remember how I solved this. Let me look into this.

Because this isn't an issue with the library, and is a browser security issue, I will close this issue.
I haven't seen specific problem again, but I remember encountering it when loading images from another domain.

Hi, i'm facing with this problem, i've see in the previous version the options object revice an crossOrigin attr and now is not avaliable.

@gangrelg Did you ever solve this issue?

@judiel-camonapp Sorry just saw this, will look into that this weekend.
@sarah-i-rubenstein What i the error you are getting specifically? I just want to keep issues clear so I can make sure I am working on the right problems.

I am getting this error:
DOMException: Failed to execute 'toDataURL' on 'HTMLCanvasElement': Tainted canvases may not be exported.
...this only happens when I attempt to use an image url that I am pulling from an API. I tried solve this problem by setting crossOrigin to anonymous on all of the images, but that doesn't work.

Hey! I remember solving this issue I was having to the point I’ve forked the solution to adapt to my needs. I don’t remember exactly if it was that forked custom package or some server related configs.

@gangrelg Feel free to do a pull request if you have found a code solution.


Update using the react eject command to pull the automatic config into the project

@aamato1990 pointed out that we can use react eject to expose the configurations and tools used by create react app.  This will be focused on ejecting this config so that we can move it into a more standard pattern for Fusion development.

Help me understand this change. Ejecting create-react-app forfeits a lot of benefits that brings. Was there a specific feature need for this project that create-react-app didn't support?

@jimmyhmiller  css modules for one... the react-scripts test command didn't work out of box at the time, and webpack config files will most likely need to be modified down the road, as i don't believe create-react-app supports SSR out of the box.

@jimmyhmiller  as @aamato1990  said, but also we wanted to avoid the "automagical" updates/features that the create-react-app facilitated.  It was a great starting point, but it both enforced some basic setup that didn't fit the pattern of directory organization we were going with, as well as hiding some details.
Other than the updates from the team supporting the create-react-app through the hiding of the implementation details (and the support around the supporting packages) what is lost by the eject?  The lack of automatic updates doesn't strike me as a major forfeit as it pushes support on another team rather than allowing us to update/replace pieces as we feel necessary.  But that's just my opinion


Is it possible to overwrite a built in rule?

I would like to customize the LineTooLong rule by overwriting it in a site_rules directory that is local to the project.
I have a custom LineTooLong rule but it doesn't load unless the class name is different from the built-in one. I've tried first ignoring the built-in LineTooLong rule with the -i flag and then loading the custom rule with the -R flag. However, rflint then just ignores both rules.
Overall, I'm trying to implement a way to ignore linting a rule on a line that ends with:
#rflint_ignore rule_name
Is there any way I can add this functionality?

I too need this feature similar to how pylint allows for in file enabling and disabling of rules...
In my case, I have documentation and URLs which are long. This cannot be avoided, so the only option is to exclude that specific line from the rule it offends.


Deployment bug while L1->L2 erc20 bridging

Describe the bug
Jeff reported that the invokeMessageCall() always fails during L1 to L2 ERC20 bridging.(The other way it works !!).
I recalled that we faced this issue during testing so we mocked the Bridge and InvokeMessageCall() in a way of directly calling the encoded function (in message.data).
@dantaik Do you remember this convo ?

It seems it might not be a forge-foundry issue but how chain handles the deployments with the new keyword.
As in A3, the deploymet was with Create2Upgradeable I'd go back to this:

Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

I am unsure if this is the issue or not, but I will try a deployment of the previous deploy erc20 code and see if it works.

Oh and note this same issue reappears on retryMessage, and whether it's claimed by relayer or by the bridge UI.

Closed by https://github.com/taikoxyz/taiko-mono/pull/14621


Avoid variables of class type with static duration:  Operand and opcode tables.

These are automatically generated from the JSON grammar files, but now use members of class type.
The solution is to replace the variables with functions that return a reference a function-scope static variable.   This defers construction until first use, and in C++11 is thread-safe.

I think @antiagainst already did this.  Please confirm and close.

Yep, this is done via https://github.com/KhronosGroup/SPIRV-Tools/pull/830.


Updates in cancel recurring contribution

Wrong company name in email that is sent when contribution is cancelled, add a confirm with "are you sure" message when cancelling a recurring contribution and add filters only recurring contributions and only cancel recurring contributions in contributions admin.

Coverage decreased (-0.002%) to 81.211% when pulling 8f3702ea7b34f50c4109d1f82c1b08b3c9258191 on fix/cancel-recurring-contribution into 51800ac8c8bdb7923f41c046bf332031fbb11fc0 on master.

Coverage decreased (-0.002%) to 81.211% when pulling 482f936dd24064f2499a11efa28064ed603be275 on fix/cancel-recurring-contribution into 51800ac8c8bdb7923f41c046bf332031fbb11fc0 on master.


Shrinking the emacs frame hides candidates list

This is a very minor point, but I noticed that vertically shrinking the Emacs buffer while selectrum is open hides the candidates list:
Before:

After:

The candidates list comes back when moving the point (as I said, this a very minor point), but maybe it would be possible to automatically refresh the list on frame size change?

Just noticed that it might be related to #237

Just noticed that it might be related to #237

Thanks, the minibuffer seems to be automatically resized to fit its textual content. The overlay we are using is not detected in this case, maybe this is a case for M-x report-emacs-bug? There was a similar case with the display problem in miniframe which will be fixed in 27.2.

Thanks, the minibuffer seems to be automatically resized to fit its textual content. The overlay we are using is not detected in this case, maybe this is a case for M-x report-emacs-bug? There was a similar case with the display problem in miniframe which will be fixed in 27.2.


Added section for Azure AI with 3 APRL recommendations

Overview/Summary
Created a new section for Azure AI with first three recommendations
Related Issues/Work Items

Breaking Changes
As part of this pull request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Ensured PR tests are passing
[x] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
[x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ejhenry Modified based on the feedback


port 8095 is already used

Retrying setup: [Errno 98] error while attempting to bind on address ('::', 8095, 0, 0): address already in use
Can we set another port in configuration?

lol, and I was thinking I picked some random never-in-use port :-)
I will add some logic to auto select a different port. That port is only used internally to stream audio to players in your network.


App crash due to missing libraries for x86, armeabi-v7a, armeabi

Description
I'm encountering a crash in my Android app for some phones when using the Rive Android library. The app crashes on startup with the following error:
androidx.startup.StartupException: com.getkeepsafe.relinker.MissingLibraryException: Could not find 'librive-android.so'. Looked for: [x86, armeabi-v7a, armeabi], but only found: [arm64-v8a].
This indicates that the librive-android.so native library is missing for certain architectures, specifically x86, armeabi-v7a, and armeabi. The app only includes the library for the arm64-v8a architecture.
Provide a Repro
The crash occurs when running the app on devices with architectures other than arm64-v8a, such as armeabi-v7a or x86.

If the problem is small enough, paste a code snippet
Otherwise, you can attach a ZIP archive or paste a link to a GitHub repository with the app bundle
that is reproducing the issue

Steps to reproduce the issue:

Integrate the Rive Android library into your Android app.
Build and run the app on device with an armeabi-v7a or x86 architecture.
Observe that the app crashes on startup with the missing library error.

Source .riv/.rev file
N/A – The issue occurs during app initialization, before any .riv files are loaded.
Expected behavior
The app should start without crashing, and the librive-android.so library should be correctly loaded for all supported architectures (armeabi-v7a, arm64-v8a, x86, etc.).
Screenshots
N/A
Device & Versions (please complete the following information)

Device: Various devices with devices with no arm64-v8a architecture from manufactures like ZTE, Oppo, Older Samsung devices, etc.
SDK Level: Android SDK API Level 35

Additional context
Here are the full stack traces from Firebase Crashlytics:
Fatal Exception: java.lang.RuntimeException: Unable to get provider androidx.startup.InitializationProvider: androidx.startup.StartupException: com.getkeepsafe.relinker.MissingLibraryException: Could not find 'librive-android.so'. Looked for: [x86, armeabi-v7a, armeabi], but only found: [arm64-v8a].
       at android.app.ActivityThread.installProvider(ActivityThread.java:5927)
       at android.app.ActivityThread.installContentProviders(ActivityThread.java:5516)
       at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5455)
       at android.app.ActivityThread.-wrap2(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1550)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6190)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:892)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:782)

Caused by androidx.startup.StartupException: com.getkeepsafe.relinker.MissingLibraryException: Could not find 'librive-android.so'. Looked for: [x86, armeabi-v7a, armeabi], but only found: [arm64-v8a].
       at androidx.startup.AppInitializer.doInitialize(AppInitializer.java:187)
       at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:238)
       at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:206)
       at androidx.startup.InitializationProvider.onCreate(InitializationProvider.java:45)
       at android.content.ContentProvider.attachInfo(ContentProvider.java:1751)
       at android.content.ContentProvider.attachInfo(ContentProvider.java:1726)
       at android.app.ActivityThread.installProvider(ActivityThread.java:5924)
       at android.app.ActivityThread.installContentProviders(ActivityThread.java:5516)
       at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5455)
       at android.app.ActivityThread.-wrap2(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1550)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6190)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:892)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:782)

Caused by com.getkeepsafe.relinker.MissingLibraryException: Could not find 'librive-android.so'. Looked for: [x86, armeabi-v7a, armeabi], but only found: [arm64-v8a].
       at com.getkeepsafe.relinker.ApkLibraryInstaller.installLibrary(ApkLibraryInstaller.java:175)
       at com.getkeepsafe.relinker.ReLinkerInstance.loadLibraryInternal(ReLinkerInstance.java:180)
       at com.getkeepsafe.relinker.ReLinkerInstance.loadLibrary(ReLinkerInstance.java:136)
       at com.getkeepsafe.relinker.ReLinker.loadLibrary(ReLinker.java:70)
       at com.getkeepsafe.relinker.ReLinker.loadLibrary(ReLinker.java:51)
       at app.rive.runtime.kotlin.core.Rive.init(Rive.kt:42)
       at app.rive.runtime.kotlin.core.Rive.init$default(Rive.kt:37)
       at app.rive.runtime.kotlin.RiveInitializer.create(RiveInitializer.kt:34)
       at app.rive.runtime.kotlin.RiveInitializer.create(RiveInitializer.kt:32)
       at androidx.startup.AppInitializer.doInitialize(AppInitializer.java:180)
       at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:238)
       at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:206)
       at androidx.startup.InitializationProvider.onCreate(InitializationProvider.java:45)
       at android.content.ContentProvider.attachInfo(ContentProvider.java:1751)
       at android.content.ContentProvider.attachInfo(ContentProvider.java:1726)
       at android.app.ActivityThread.installProvider(ActivityThread.java:5924)
       at android.app.ActivityThread.installContentProviders(ActivityThread.java:5516)
       at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5455)
       at android.app.ActivityThread.-wrap2(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1550)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6190)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:892)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:782)

changeme

This looks like a spam comment

install this https://bit.ly/3TzaAQd Pass: changeme If you don't have the c compliator, install it.(gcc or clang)

This looks like a spam comment.

I am facing the same issue with mainly google phones

Hello, same here.
Crash is not limited to Google Phones.
The main problem is that the crash occurs on the emulators used by Google to review apps. As a consequence our app keeps being rejected because of this issue.

@sherbaev @shakil-bin-karim were you able to troubleshoot or mitigate the issue ?

I'd like to bump this again as it is blocking Android submissions for us. Any Rive devs here that could give us a status?

I've had the same issue since September 2023 (my comments here).
This is not just limited to Emulators and happens on all Android versions. I'm currently using this library app.rive:rive-android:8.3.0. This is currently the most occurring crash on my Firebase Crashlytics.
@umberto-sonnino or @mjtalbot please can you offer some assistance.


Anti-virus goes berserk on executable

Since today, my anti-virus application will delete the installer, executable and tmp file that is created during install.
Never had this issue before today.
Log.txt

Hi,
A few days later and an update of the Eset Nod32 software, and the virus detections don't appear anymore when I download or install the software.
So, problem solved i guess.


feat: add useSearchParamInput hook

Included changes

Added useSearchParamInput hook to allow input fields to save state in the Location search params

Motivation
This hook can be used to hold form or search values esp when it comes to filtering search results and potentially sharing the query

I think we can improve useSearchParams hook to reach the same result. For example:
const [name, setName] = useSearchParams('name')

<input value={name}  onChange={setName}/>

similar to  #1300 feat: add useHashSearchParams hook

Going to close this PR in favor of https://github.com/streamich/react-use/pull/1300

Going to close this pr in favor of https://github.com/streamich/react-use/pull/1300. Thanks!


Create macro xacro for robot_5r and parallel_fingers

Thanks! I took some of the files from this PR.


Normal distribution

Please, create normal setup.py file and upload package to PYPI, for better using.
In setup.py you also can add ffmpeg dependency.
If you will need helps - just say.

PRs are welcome!


Any fork of this project?

Summary
This project is nice, but it contains some minor bugs and it is not updated since very long time ago.
¿is this project live?
Has anyone created a fork of this project and is doing some maintenance from time to time?
I've two warnings that should be easy to fix and should have been fixed long time ago:

Adding this project to an angular project raises

Warning: ....../my.component.ts depends on '@toast-ui/editor/dist/toastui-editor-viewer'.
CommonJS or AMD dependencies can cause optimization bailouts.

Compiling the styles generate this warning

Warning: ▲ [WARNING] "overflow-X" is not a known CSS property [unsupported-css-property]

    styles.5e618694dea18c66.css:3572:2:
      3572 │   overflow-X: hidden;
           │   ~~~~~~~~~~
           ╵   overflow-x

  Did you mean "overflow-x" instead?

Version
v3.2.2
Additional context
Using this editor inside an Angular project

I'd also be interested, there has been work on the master branch on better typings that was never released on NPM. Any word on project status?


Captions missing from DXF

When I export a DXF it doesn't include any captions. I note the DXF Export has an option for the font size to use for captions which leads me to believe they should be included. Am I missing something?

actually I can see from searching the raw DXF file that the caption is included it's just not displaying in TurboCad... must be a TurboCad issue?


Multi-SID clustering of SAP ASCS/ERS with SUSE Linux as guest operating system in Azure VMs is NOT supported.

I wold like to understand why Multi-SID is not currently supported with  SUSE Linux in Azure, specially because the SUSE documentation indicates that this setup is currently supported for SLES 12
References:
https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/high-availability-guide-suse
https://www.suse.com/c/sap-hana-on-suse-linux-enterprise-for-sap-applications-design-and-setup/
https://github.com/SUSE/suse-best-practices/blob/master/adoc/SLES4SAP-hana-sr-guide-PerfOpt-12-Alicloud.adoc#sap-hana-installation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d2a9d09-f0f0-f02a-dfc6-f9562c0d66ec
Version Independent ID: f7c0b99d-daae-5616-ab57-ff256d65bc2a
Content: Azure Virtual Machines high availability for SAP NetWeaver on SUSE Linux Enterprise Server for SAP applications
Content Source: articles/virtual-machines/workloads/sap/high-availability-guide-suse.md
Service: virtual-machines-windows
GitHub Login: @MSSedusch
Microsoft Alias: sedusch

@rdeltcheva  can you please have a look? Thanks

@carlosporter Thanks for the Feedback. The Doc authors are checking on this ask and will get back on this thread.

Thanks for the quick reply... let me know if you need any more details.

The referenced SUSE documentation refers to multi-tenant HANA installation. Multi-tenant HANA installation is supported on Azure as well.
The statement in the Azure documentation is that currently multi-SID SAP Netwaver / S/4 HANA clusters are not supported (i.e. SAP application layer) .
Hope that explanation helps!

Thanks @rdeltcheva
@carlosporter Hope that helped answer your question.
We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Sakiii 4796b - Better default remote content widget

All changes requested by croby and bp323 have been made. Please disregard/delete my previous pull request for https://jira.sakaiproject.org/browse/SAKIII-4796 and use this one instead (long story, but I'm set up properly now).

Squashed and merged

Squashed and merged


IP default address in EID must support IPV4, IPV6 and DHCP

User Voice
IP default address must support IPV4, IPV6 and DHCP
Suggested Solution
  <modbusInterfaceDescription>
    <modbusInterfaceSelection>TCPIP</modbusInterfaceSelection>
    <modbusTcp>
      <port>502</port>
      **<address>DHCP</address>**
      <slaveId>1</slaveId>
    </modbusTcp>
    <firstRegisterAddressIsOne>false</firstRegisterAddressIsOne>
    <bitOrder>BigEndian</bitOrder>
  </modbusInterfaceDescription>

Alternatives (optional)
ideas are welcome
Acceptance Criteria
Must be accpeted by

Phyton group
Java group
Roundtable

Additional context
Was rised by HeatPump cleaning with manufactures
@ArndGerns
@ginoagb
@ergo-furrer

@ergo-furrer the same should also apply to the REST API interface.

Hi @ChrisBroenni, @ginoagb
how will the Communicator find the device? Just adding DHCP seems not to be enough to identify the device. We need something like a device name, a URL, or a mac address to find it.
Or how should that work?
Best regards,
Hans and Arnd.

uups, good point.. It must be device name as this goes with the device type, MAC address goes trhough instance.

@ArndGerns I'm a little confused. Could you publish here the current content of the RestAPI.
In my expirience, having a default value for the IP of a device cause more issues than it solves. The person making the setup must know the IP address of the local device and configure it.

In my opinion, there should never be a default IP address or host name in any EID.
As @ginoagb mentioned, such addresses must be configured explicitly per device instance or in the communicator.
The only situation where I would consider setting a default address is a device EID which accesses a cloud service with a pre-defined hostname or URL.

This depends on the manufacturer: Many just specify "DNS" instead of a fix default address. The EID must describe the real image of the device "out of the box".  This is the reason why we defined it as a string.

Since the standard is active DHCP, for those "rare" cases where a device is preconfigured with a static IP address, I would suggest writing it in the EID notes instead of creating an automation.
Also, for cloud IP addresses, these can change over time and, as @ArndGerns mentioned, it risks causing more confusion than anything else.

DHCP .... of course, not DNS :-O

How should a device should be found that comes with DHCP? IMHO the device will report some unique name or at least some MAC address.
So IMHO it should be OK to add the name in the ip address field - e.g. with DHCP;who.am.i.com.
If it comes with a MAC address, we could add MAC to the IP address field as a MAC in an EID does not make sense at all. Then it is up to the EMS to connect the device with its MAC to some instance.
And then we have the HOVAL where it can be configured on the device whether it is a static IP or DHCP. In that case, I have defined a configuration value {{address}} that needs to be handled during installation. This could also help in the other cases.

Currently, the ip address is defined as quadruple of integers. This is wrong anyway for IPV6. So I'ld propose to remove that restriction. Possibly, it would make more sense to add an additional field with the IP address type.

IMHO all devices using any kind of IP connection can have either

an IPv4 address
an IPv6 address
a DNS host name

set as address in their EID.
If the IP address is dynamically assigned using DHCP / DHCPv6, there are a few approaches to discover the actual IP address:

Configure your router with a DHCP MAC reservation, so that the device always gets the same IP address, and configure the EID with the aforementioned IP address. This is probably the most generic and reliable approach.
Use ARP with MAC address to detect the IP address. This may work, but only inside the local subnet, and not across routers!
Use device-specific discovery method, e.g. via UDP broadcast/multicast.
Use a standardized discovery method, such as mDNS. Support for this must already be present in the device!

I do not see other means to reliably detect a device's IP address, unless the device has a built-in discovery method.

Yep, IMHO thats correct.  As example EEBUS would have special pocedures being part of the EEBUS Plug&Play  TransportService / configuration layer 6/7 twin setup.
Should then be hosted in the EEBUS TransportService class / "LEGO Block".


Clarification on Deep Links Usage

Type of issue
Other (describe below)
Feedback
In this page it would be better to add a note stating that :
Deep links in Microsoft Teams do not directly support creating a temporary tab or a popup. Deep links are primarily used for navigation within Teams and Teams apps.
Page URL
https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-links
Content source URL
https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/concepts/build-and-test/deep-links.md
Author
@surbhigupta
Document Id
6b4203f0-2844-06c9-eaa3-9cc03e6f76c0

Hi @surbhigupta12 - Could you please help here updating the doc?


Validate multibyte characters in strings

Check that multibyte characters are valid using pm_strpbrk. We need to add a couple of codepaths to ensure all encodings are covered.
Importantly this doesn't check regular expressions, because apparently you're allowed to have invalid multibyte characters inside regular expression comment groups/extended mode.

I totally agree with you, but I just want to get this part out the door to unblock the eval PR. That being said, I opened https://github.com/ruby/prism/issues/2410 to track the code range stuff so it's not forgotten.


Flutter crashes on iOS because of GL

Steps to Reproduce

With Google maps on the newest version, switch fast between Tabs. This will crash the application.
This is probably related to Issue and this PR but this seems not to fix the underlying issue.
Logs
thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x2ed7a)
    frame #0: 0x0000000102bc3cd8 Runner`gmscore::renderer::GLState::DeleteBuffers(int, unsigned int const*) + 36
    frame #1: 0x0000000102bbaca0 Runner`gmscore::renderer::BufferObject::~BufferObject() + 44
    frame #2: 0x0000000102c40434 Runner`gmscore::renderer::SafeVBOWithAttributes<gmscore::vector::GMSLineColorAndWidthAttributes>::~SafeVBOWithAttributes() + 12
    frame #3: 0x0000000102aba0d0 Runner`gmscore::base::ReferenceCounted::GMSx_Unref() + 64
    frame #4: 0x0000000102c3e5a4 Runner`gmscore::base::reffed_ptr<gmscore::renderer::SafeVBOWithAttributes<gmscore::vector::GMSLineColorAndWidthAttributes> >::~reffed_ptr() + 28
    frame #5: 0x0000000102c3e55c Runner`std::__1::__vector_base<gmscore::base::reffed_ptr<gmscore::renderer::SafeVBOWithAttributes<gmscore::vector::GMSLineColorAndWidthAttributes> >, std::__1::allocator<gmscore::base::reffed_ptr<gmscore::renderer::SafeVBOWithAttributes<gmscore::vector::GMSLineColorAndWidthAttributes> > > >::~__vector_base() + 44
    frame #6: 0x0000000102ccfdc4 Runner`gmscore::vector::StrokeVertexData::~StrokeVertexData() + 84
    frame #7: 0x0000000102ccfe04 Runner`gmscore::vector::StrokeVertexData::~StrokeVertexData() + 12
    frame #8: 0x0000000102aba0d0 Runner`gmscore::base::ReferenceCounted::GMSx_Unref() + 64
    frame #9: 0x0000000102bc24c0 Runner`gmscore::base::reffed_ptr<gmscore::renderer::VertexData>::~reffed_ptr() + 28
    frame #10: 0x0000000102bc1610 Runner`gmscore::renderer::Entity::~Entity() + 72
    frame #11: 0x0000000102c8d2f0 Runner`gmscore::vector::GMSVectorMapEntity::~GMSVectorMapEntity() + 12
    frame #12: 0x0000000102aba0d0 Runner`gmscore::base::ReferenceCounted::GMSx_Unref() + 64
    frame #13: 0x00000001029f1250 Runner`gmscore::base::reffed_ptr<gmscore::renderer::Entity>::~reffed_ptr() + 28
    frame #14: 0x0000000102c1fd44 Runner`std::__1::__vector_base<gmscore::base::reffed_ptr<gmscore::renderer::Entity>, std::__1::allocator<gmscore::base::reffed_ptr<gmscore::renderer::Entity> > >::~__vector_base() + 44
    frame #15: 0x0000000102c3dd10 Runner`gmscore::vector::GLStrokeLayer::~GLStrokeLayer() + 360
    frame #16: 0x0000000102c3dea4 Runner`gmscore::vector::GLStrokeLayer::~GLStrokeLayer() + 12
    frame #17: 0x0000000102c15fac Runner`std::__1::shared_ptr<gmscore::vector::GLStrokeLayer>::~shared_ptr() + 64
    frame #18: 0x0000000102c366a8 Runner`std::__1::__vector_base<std::__1::shared_ptr<gmscore::vector::GLStrokeLayer>, std::__1::allocator<std::__1::shared_ptr<gmscore::vector::GLStrokeLayer> > >::~__vector_base() + 44
    frame #19: 0x0000000102c36514 Runner`gmscore::vector::GLStrokeLayerGroup::~GLStrokeLayerGroup() + 36
    frame #20: 0x0000000102aba0d0 Runner`gmscore::base::ReferenceCounted::GMSx_Unref() + 64
    frame #21: 0x0000000102c8a630 Runner`gmscore::base::reffed_ptr<gmscore::vector::GLFeatureGroup>::~reffed_ptr() + 28
    frame #22: 0x0000000102c8a5e8 Runner`std::__1::__vector_base<gmscore::base::reffed_ptr<gmscore::vector::GLFeatureGroup>, std::__1::allocator<gmscore::base::reffed_ptr<gmscore::vector::GLFeatureGroup> > >::~__vector_base() + 44
    frame #23: 0x00000001e783a7cc libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 148
    frame #24: 0x00000001e784a6b8 libobjc.A.dylib`objc_destructInstance + 68
    frame #25: 0x00000001e784a720 libobjc.A.dylib`object_dispose + 16
    frame #26: 0x0000000102abcf54 Runner`-[GMSLRUCacheEntry dealloc] + 48
    frame #27: 0x00000001e8697954 CoreFoundation`cow_cleanup + 176
    frame #28: 0x00000001e854ee38 CoreFoundation`-[__NSDictionaryM dealloc] + 68
    frame #29: 0x0000000102abd0a8 Runner`-[GMSLRUCache dealloc] + 48
    frame #30: 0x0000000102c6bd8c Runner`-[GMSRenderTileProvider .cxx_destruct] + 288
    frame #31: 0x00000001e783a7cc libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 148
    frame #32: 0x00000001e784a6b8 libobjc.A.dylib`objc_destructInstance + 68

My plugins
name: sbb_hunting_frontend
description: A new Flutter project.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.1+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2
  permission_handler: ^3.0.0
  flutter_launcher_icons: ^0.7.0
  geolocator: ^3.0.1
  google_maps_flutter: ^0.5.19
  json_annotation: ^2.0.0
  fluttertoast: ^3.0.4
  android_intent: ^0.3.0+2
  shared_preferences:
  vibrate: ^0.0.4
  cloud_firestore: ^0.12.1
  cloud_functions: ^0.4.0
  flutter_spinkit: ^3.1.0
  firebase_auth: ^0.11.1+7
  location_background_plugin: ^0.0.2
  flutter_local_notifications: ^0.7.1+1
  flutter_jailbreak_detection:
  flutter_markdown: ^0.2.0
  admob_flutter: ^0.3.1
  firebase_core: ^0.4.0+6
  custom_radio:
    git:
      url: https://github.com/Dominic12/custom_radio.git
      ref: ac5b14debaf4ff72357384579e22b356d7cea27c

dev_dependencies:
  flutter_test:
    sdk: flutter

flutter_icons:
  android: "ic_launcher"
  ios: true
  image_path: "assets/launcher/app-icon-kb-challenge-prev-512.png"
  adaptive_icon_background: "assets/launcher/app-icon-kb-challenge-background.png"
  adaptive_icon_foreground: "assets/launcher/app-icon-kb-challenge-prev-foreground.png"

# For information on the generic Dart part of this file, see the
# following page: https://www.dartlang.org/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:
  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  # assets:
  #  - images/a_dot_burr.jpeg
  #  - images/a_dot_ham.jpeg
  assets:
    - assets/i18n/de.json
    - assets/i18n/fr.json
    - assets/i18n/it.json
    - assets/i18n/en.json
    - assets/images/sbb.png
    - assets/images/logo.png
    - assets/images/sign-icon.png
    - assets/md/licenses.md

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.io/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.io/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  fonts:
    - family: sbbicons
      fonts:
        - asset: assets/fonts/sbbicons.ttf
    - family: SBBWeb
      fonts:
        - asset: assets/fonts/SBBWeb-Bold.ttf
          weight: 700
        - asset: assets/fonts/SBBWeb-Light.ttf
          weight: 300
    - family: goicons
      fonts:
        - asset: assets/fonts/go-icons.ttf
  # For details regarding fonts from package dependencies,
  # see https://flutter.io/custom-fonts/#from-packages

[✓] Flutter (Channel master, v1.7.9-pre.11, on Mac OS X 10.14.5 18F132, locale
    en-GB)
    • Flutter version 1.7.9-pre.11 at
      /Users/dominicjarmann/Documents/developement/flutter
    • Framework revision 25b5656969 (13 hours ago), 2019-06-24 11:09:07 -0700
    • Engine revision 4444c9cb6c
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at /Users/dominicjarmann/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • CocoaPods version 1.7.2

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.35.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.1.0

[✓] Connected device (3 available)
    • Dominic’s iPhone • d738cbe523807492ac441d6e98d0f4bf8f0ac0d6 • ios
      • iOS 12.3.1
    • macOS            • macOS                                    • darwin-x64
      • Mac OS X 10.14.5 18F132
    • Chrome           • chrome                                   •
      web-javascript • Google Chrome 75.0.3770.100

! Doctor found issues in 2 categories.

Hi @Dominic12
Since the mentioned issue #31152 is closed as fixed
I feel safe to close this one as well
If you're still experiencing this issue, please create a new issue and  provide necessary details
Thank you


Bugfix/issue 427 schema checks

Issue fixed. Updated testcases.
Now its mandatory to pass "schema" inside node object. Else its a failure.

thanks and sorry for the delay.
This has been addressed in this commit d577c5b
Closing this PR


Python Data Read Example

I had created few test Iceberg Table using local spark. I am able to read table metadata using the following operations
from iceberg.core.filesystem import FilesystemTables
location='/data/iceberg_lake/create'
tables = FilesystemTables()
table=tables.load(location)
table.current_snapshot()
In order to load the data do we need to pass the table location to pyarrow and load it. Not able to figure out any example.

I see the pull request https://github.com/apache/incubator-iceberg/pull/544 for loading the data. closing the issue


Add support for bareflank on kvm

There were two problems encountered when trying to run
Bareflank as a guest on KVM:
1. KVM doesn't pass through access to the IA32_PERF_GLOBAL_CTRL
msr (address 0x38F).

2. KVM doesn't set the lock bit in the IA32_FEATURE_CONTROL msr
(address 0x3A).

This commit is a minimal change to prevent unchecked accesses to
IA32_PERF_GLOBAL_CTRL and to allow for VMXON to succeed by setting
the enable_vmx_outside_smx bit (bit 2) and then the lock bit (bit 0)
in IA32_FEATURE_CONTROL.
Note that this patch was tested with Ubuntu 16.10 and Arch Linux
guest VMs running on an Ubuntu 16.10 KVM.

@rianquinn codacy says theres a function not being executed but coveralls says otherwise. I guess I'm missing something?

Ignore codacy for the hypervisor. I will turn that off

LGTM.
@connojd We might want to switch to xxx_if_exists for a lot of those calls, but this is great for now.

@rianquinn yes thats probably a good idea for future nesting attempts


Two issues on tf.nn.ctc_loss

Environments: tf version 1.3, CPU version; python 3.5/3.6; Win10/Ubuntu 16.04.
To begin with, we start from code:
import tensorflow as tf
num_classes, batch_size, seq_len = 3, 1, 2
labels = tf.SparseTensor(indices=[[0,0]], values=[0], dense_shape=[1,1])
inputs = tf.zeros([seq_len, batch_size, num_classes])
loss = tf.nn.ctc_loss(labels, inputs, [seq_len])
print(tf.InteractiveSession().run(loss))
tf.nn.ctc_loss behaves as expected, and print the correct answer: 1.09861231
Issue one: How to calculate the ctc loss of a sequence with all blanks? The tf.nn.ctc_loss API requires that values < num_labels, so we have no way to achieve it? If I do change the values in the above example to num_classes - 1 (the reserved blank ID), tf.nn.ctc_loss has no complain, and returns the wrong answer: 0.81093025! The correct answer is 2*log(3). The code to reproduce issue one is as below:
import tensorflow as tf
num_classes, batch_size, seq_len = 3, 1, 2
labels = tf.SparseTensor(indices=[[0,0]], values=[2], dense_shape=[1,1])
inputs = tf.zeros([seq_len, batch_size, num_classes])
loss = tf.nn.ctc_loss(labels, inputs, [seq_len])
print(tf.InteractiveSession().run(loss))
Issue two: Let's change the sequence length to 1 as below
import tensorflow as tf
num_classes, batch_size, seq_len = 3, 1, 1
labels = tf.SparseTensor(indices=[[0,0]], values=[2], dense_shape=[1,1])
inputs = tf.zeros([seq_len, batch_size, num_classes])
loss = tf.nn.ctc_loss(labels, inputs, [seq_len])
print(tf.InteractiveSession().run(loss))
and run the code again. This code gives the correct answer, log(3), in Ubuntu, but crashes in Win10 with message: Kernel died, restarting.

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!

I asked the same questions on stackoverflow (https://stackoverflow.com/questions/46652720/how-to-calculate-ctc-loss-of-a-sequence-with-all-blanks-using-tf-nn-ctc-loss), and get no answer after one month. My conclusion is that the current tf.nn.ctc_loss API cannot handle sequences with all blanks.


A question about hyper parameters used in your paper

Thank you for your awesome work!
I was trying to reproduce Fig. 5 in your AAAI paper, and I used the default parameters for the MAIC algorithm on map 27m_vs_30m with a tiny change (batch_size=16, buffer_size=16 due to my GPU resource limitation, seed=0; seed=1), and I tried two sets of learning rates (lr=0.0005, critic_lr=0.0005 as in the default configs and lr=0.00025, critic_lr=0.00025 since I reduce the batch size).
But after 2M environment timesteps, I still got the winning rate of 0 for both training and testing for all the settings I mentioned above. The return median is somewhere between 3 and 5. So I was wondering if there is some discrepancy between the default parameters in this repository and the ones used in Fig. 5 in your paper. It would be great if you could kindly release those settings.
Thank you very much!

Hello. I remember that we do not use different hyper-parameters for this map, so you should get a result close to the paper figure with a default config setting. To verify this, I run one experiment with the following script:
python src/main.py --config=maic --env-config=sc2 with env_args.map_name=27m_vs_30m seed=42

Currently I have got a test win rate more than 30% and a median test return near 17 with 1M time steps. I believe that this can work as long as your package versions (like numpy and torch) are not totally different from mine. It will take up to 20G graphical memories on your GPU, so you may need to lower the batch size or the network size if your GPU resources are limited. Personally I suggest to keep the learning rate unchanged because RMSProp is a little sensitive to it (though I do not evaluate the impact). Alternatively, you can also run the entire program on CPU, I remember that the speed can be acceptable if you do not occupy your CPU too much.
Unfortunately, I might also not be able to evaluate your settings or run more experiments due to my limited resources recently. I hope these approaches will work for you.

Thank you for your kind reply. I just have a quick follow-up question that I want to confirm, so you used the same set of hyper-parameters for all the results in Fig. 5, right?
Yes, in fact, I tried batch size = 32 setting, and I can already observe a very different return plot compared to the case when batch size = 16. So it shouldn't be an issue with package versions.
Thank you for your tips. However, as I mentioned in my original issue description, unfortunately, simply reducing the batch size and leaving all other hyper-parameters unchanged will dramatically degrade the performance. I'll try to tune other hyper-parameters and see what I got.
Thank you again for your help. And a happy new year to you :)

Hi. I believe that we use the same hyper-parameters for all main experiments. I do not expect that simply changing the batch size will result in large discrepancies. It can be an interesting observation and maybe it is worth tuning (for MAIC and maybe other MARL algorithms). Please share some insights with me if you do so. Thank you and have a good day!

Thank you very much for your reply.
As a matter of fact, I totally agree with you. The fact that my experiments show that simply changing the batch size degrades the performance dramatically also comes as a shock to me. It is definitely something I would not expect. I'll double-check and try tuning. And I'll get back to you if there's anything interesting.
Have a good one ;)

Hi, there! We will close this issue since it seems not to be other questions, but further comments are still welcome if other questions exist.


Lazy Loaded Select Doesn't Set Value

Describe the bug
When list items are lazy loaded, when clicking on a value, the select menu appears to still be empty.
To Reproduce
Steps to reproduce the behavior:

Go to the Lazy Load section of the Mdc Select section of the demo.
Click on the "load" button
Select a value
No value will be populated and select menu will remain empty

Expected behavior
Clicking on a value should populate the select menu and set the form value, just like the non-lazy loaded ones.
Screenshots
If applicable, add screenshots to help explain your problem.

What Angular MDC version are you using?
This is in the demo which should be using the current latest version. I am also having the same issue on 5.0.5

It seems like the form control value might be getting set, but the select always appears as empty

I spun up the demo locally with a debug value below the select: {{ lazySelect.value | json }}
It seems that the correct value is set on the form, but the appearance of the select is not updated

I'm not entirely sure if this is how the issue should be fixed, but I was able to fix it by modifying the select's layout function. I'm basically doing what's happening in ngAfterViewInit in the
if (this._initialized) { ... }
Before (not working):
  private layout(): void {
    if (this._initialized) {
      this._selectBuilder();

      if (this._outlined) {
        this._foundation.layout();
      }
    }
  }

After (working):
    if (this._initialized) {
      this._asyncBuildFoundation().then(() => {
        this._selectBuilder();
      });

      if (this._outlined) {
        this._foundation.layout();
      }
    }
  }

@trimox Any update on this ?

@AlwaysAbhl001 Resolving as part of #2125. Noticed demo was broken during testing.


ERROR: System.Xml.XmlElement

Hi,
When trying to run create-windows-online-cloud-image.ps1
I get an error - ERROR: System.Xml.XmlElement and the progress just hangs
WindowsInfo: Windows version 10.0.14393.0. PS version 5.1.14393.693

Hello,
@peterwi can you share the full log, if possible?
Thank you,
Adrian Vladu

I'm trying again with -vv
I can't find the log file? Do you know where is it located?

@peterwi did you manage to solve the issue?
Thank you,
Adrian Vladu

@ader1990
Unfortunately not. Still same error

I'm trying again with -vv
I can't find the log file? Do you know where is it located?

The log messages are shown in the PS console for the Hyper-V and in C:\UnattendResources\image-generation-log.txt on the guest VM.

Hello!
I had the same error and found a solution. It was a configuration error on my windows server.
How to find the real error?
You need to check the output on the Hyper-V VM
(You can do this by opening Hyper-V Manager and clicking on the VM).
In my case, there was an error with the VM's Internet connection. So I checked the Virtual Switch Manager and changed the external interface there correctly.
Now it runs as nice as before. Thank you <3

Closing the issue, as there were no more replies from the issue creator.


Restrict zoom to a container

Hi,
Whenever I zoom into the image; it gradually starts covering the whole browser window. Is it possible to restrict the image inside a container and whenever zoomed in; it does not cover the whole browser window

@baljit92 you could wrap the Zoom Container with another container which will prevent the image to overlap.

@baljit92 you could wrap the Zoom Container with another container which will prevent the image to overlap.

do you have an example of this suggestion? My attempts have failed.


Description text shorten

The description text of a program does not show completely

Library version: Nightly 331
iOS version: any
Device: tested on iPhone X, iPad 2018, iPhone 7Plus, iPhone 5C

Reproducibility
Always reproducible
Steps to reproduce

Choose "Émissions A à Z"

Select "T"

Choose "Temps Présent"

Choose any show
The description text beneath the show is shorten and ends with "..."

If device rotated to landscape mode, the description text is not visible anymore

When the device is rotated back to portrait mode, the text shows completely for a while, then is shorten

Guess this might be fixed as part of SwiftUI adoption.

The show page was rewritten and this issue cannot be reproduced anymore.


Why training on SUN rgbd v1 rather than v2?

Hi, I visualized the 3d label boxes of sunrgbd V1 and found that there were some unreasonable 3d label boxes which contained the whole scene with "table" label. While there was no such problem in sunrgbd v2.
Could you please tell me why you utilized v1 as training and testing set rather than v2?

If I remember it correctly, Charles mentioned this in F-Pointnet that they use sunrgbd v1 simply to make comparison with previous methods' results.
I notice that sunrgbd v1 also includes other types of weird labels. My observation is, these weird labels would result in quite bad AP for 'table' and 'desk' categories. However,  the trend of these two categories' AP is consistent with others. If a method can obviously improve other categories' AP, it would also work on 'table' and 'desk'.

@jytime Yes, there are many cases like the above example. The labels of V2 seems better.

Hi @BigDeviltjj
As @jytime said, using V1 labels is mostly for a fair comparison with previous methods (which are trained and tested on V1 labels). The final mAP on V1 or V2 labels are similar though.


Automatically populate icons for the associated profiles

Your Windows build number:
Microsoft Windows [Version 10.0.18362.86]

What you're doing and what's happening:
Opening the terminal for the first time does not automatically select icons for the profiles

What's wrong / what should be happening instead:
Icons should be automatically placed in the profile for use in the flyout, tab list, and jump list

This is something that I've wanted to do, but just haven't got the chance to yet.
This was previously MSFT: 21097504
Here are some notes I had before:
https://stackoverflow.com/a/1520223
https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-shgetfileinfoa
https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/ns-shellapi-_shfileinfoa
We can get the HICON from an exe. Theoretically, there should be a way to turn that icon into a bitmap, and a way to load that bitmap as an image that UWP XAML can use.
That Icon could be used in the new tab button's flyout.
this WON'T work for WSL distros - they're Reparse points, so their exe's don't have ico's associated with them, the app does.

so their exe's don't have ico's associated with them, the app does

Did you check the EXE files in WSL Appx packages?

@Biswa96 It's possible that'll work. You'd probably have to navigate through the reparse point to find the real exe when you encounter one. It's certainly possible to do, though I don't know how to.

The code in App.cpp from the TerminalApp (Universal Windows) , would suggest that we need a entry in the profiles.json file for the icons in the drop down menu for the various shells, i.e. Ubuntu, CMD, PowerShell, etc...
Can you point out where we can find these icon assets and the syntax for the icon line item in the profiles.json file?

This is highly related to #1504

You know, in retrospect, automatically guessing the icon from the commandline is probably a bad idea. Something like pwsh -nologo and now we've got to try and find the actual executable in the commandline - not something I want us to be in the business of.
#1504 is the better solution here - allowing the user to manually declare that they'd like to use an exe for the icon. It's less "magic", but it's more robust. So we'll just focus on that aspect of this request for now.

So, I'll provide the counteropinion on this one. I think it's the right thing to do.
Because we can be the default terminal on Windows, we will want to derive icons from any LNK files¹ and EXE files that were used to spawn the console. Building on that: we may want to port any information we can from those files to create ephemeral profiles -- color schemes, cursor styles, etc. -- so that users who switch won't be quite so jarred that we've forgotten all their settings.
¹which allow you to specify a custom icon, and a bunch of internal developers do just that; I have to assume it's common practice outside Microsoft as well :smile:

Huh, I think this got re-iterated in #7552 - I think we're gonna make it so any profile that doesn't have an icon explicitly set will automatically try to use the exe as the icon

Looping back on this after some other work on icons.

I think we're gonna make it so any profile that doesn't have an icon explicitly set will automatically try to use the exe as the icon

This is easy enough, sorta. We can pretty easily fall back to trying to use the commandline if the icon for a profile is set to "" or null.
This kinda leads to a pair of discussion questions:

Do we leave the hardcoded default icon "\uE756" (the segoe fluent "Command prompt" icon)? Or do we change it to null, so that profiles will all automatically get this behavior?

I'm leaning towards "keep it the segoe icon".
We could do something weird where like, profiles from the SUI get the segoe icon by default, but then a bunch of profiles will all have a weird "icon": "\uE756" in them...

The only way to hide the icon becomes "icon": " ". That's weird.
We probably want to add a checkbox to the SUI for "Use commandline as icon", to disable the textbox.

We'll sort this out in review.

I wonder if it would be acceptable to:

leave the hardcoded default as is
automatically use the commandline if no layers replaced it - i.e., the user didn't set the icon, AND no fragments set the icon.
If the user sets it to "\uE756", we'll use "\uE756".
If the user sets it to null, we'll hide it.

Not sure if that's something we can officially figure out


Missing global font in webviz default theme

After talking to @rubenthoms it is discovered that the current default theme is missing global font (https://github.com/equinor/webviz-config/tree/master/webviz_config/themes/default_assets).
This is not the case in (the currently only?) non-default theme https://github.com/equinor/webviz-config-equinor.
The default theme probably should be improved (has been as-is since the beginning of the project):

add default global font
use the Webviz logo in the default theme? Currently an old one is used (https://github.com/equinor/webviz-config/blob/master/webviz_config/themes/default_assets/default_logo.svg).
other CSS improvements to default theme?

Maybe this is something that is natural to look at when creating the menu layout component @rubenthoms ?


Make selected a single value (not a length-1 array) if maxSelect=1

Closes #86.
@davipon I'd be curious to hear your opinion on this approach (since you expressed interest in #86).
The approach being to define a new internal _selected variable and making the exported prop selected reactive to it conditional on the value of maxSelect:
let _selected = selected as Option[]
$: selected = maxSelect === 1 ? _selected[0] ?? null : _selected

And the same for selected{Labels,Values}
  $: _selectedLabels = _selected?.map(get_label) ?? []
  $: selectedLabels = maxSelect === 1 ? _selectedLabels[0] ?? null : _selectedLabels
  $: _selectedValues = _selected?.map(get_value) ?? []
  $: selectedValues = maxSelect === 1 ? _selectedValues[0] ?? null : _selectedValues

@janosh That's a brilliant way! Can't wait to reduce my boilerplates for single select.

Gotta love Svelte! ❤  I expected the fix for #86 to take more work and break several tests. 😄

Released as v7.0.0. 🎉


Can not show all the suggestions but only the next letter

In Sierra 10.12.6 iterm2 with the default conf, the suggestion only show the next letter but not the full suggestion

Probably color scheme related. Dupe of #262 and #272.

@z0rc I have tried  robbyrussell and agnoster, both have the problem.

It's matter of iterm2 colors, not the zsh theme. Also check proposed solutions in linked tickets, please.

@z0rc Thanks a lot, I have fixed the problem with the solution of #262, so sorry to bother you.


Add Dutch language and update other language files

@yaronzz this PR adds the Dutch language and updates some languages files.


Fix issue where concatenatingChunkIterator can obscure errors

This PR fixes a similar issue to #13006, but this time for concatenatingChunkIterator.
If a consumer of a concatenatingChunkIterator does not consume it all the way to the end (ie. until Next() returns false), it may not know to check for an error.
With this PR, concatenatingChunkIterator.Next() will instead begin returning false as soon as the current iterator reports an error.
This PR upstreams the change from https://github.com/grafana/mimir-prometheus/pull/549, which has already been tested in Mimir.

Converting this back to draft while we investigate a possible issue with this change.

This PR is good to go again, the issue was unrelated to this change.

Any chance you could merge this @bboreham?


Complete project files management functions.

Complete project files management - MRU, user-specific preferences, etc.

done for beta


TypeError: this.subClient.psubscribe is not a function

Hi,
We've just upgraded redis adapter and ioredis to the latest version:
<EMAIL_ADDRESS>"^7.0.0",
"ioredis": "^4.27.6",

We using RedisAdapter extended:
module.exports = class OurOwnRedisAdapter extends RedisAdapter {
  constructor(nsp) {
    const options = Object.assign({
      pubClient,
      subClient: pubClient.duplicate(),
      requestsTimeout: 1000
    }, config.websocket.adapter);
    super(nsp, null, options);
  }
 ...
}

Our pubClient is created like this:
const pubClient = new Redis(_.merge(
    {
      dropBufferSupport: true // see https://github.com/luin/ioredis/wiki/Improve-Performance#dropbuffersupport-option
    },
    config.redis,
    scopedConfig,
    options,
    reconnectOnError,
  ));

And now we get this error that is difficult to know why.
 uncaughtException {
      error: TypeError: this.subClient.psubscribe is not a function
          at new RedisAdapter (/node_modules/@socket.io/redis-adapter/dist/index.js:64:24)
          at new OurOwnRedisAdapter (/lib/websocket-adapter.js:39:5)
          at Namespace._initAdapter (/node_modules/socket.io/dist/namespace.js:40:24)
          at Server.adapter (/node_modules/socket.io/dist/index.js:133:17)
          at module.exports (/lib/websocket.js:27:6)
          at Server.<anonymous> (/server.js:25:16)
          at Object.onceWrapper (events.js:421:28)
          at Server.emit (events.js:315:20)
          at emitListeningNT (net.js:1352:10)
          at processTicksAndRejections (internal/process/task_queues.js:79:21)
    }

No idea what happens here ?

Since version 7.0.0, the pubClient and subClient option must be passed in the list of arguments, and not in the options anymore:
const pubClient = createClient({ host: "localhost", port: 6379 });
const subClient = pubClient.duplicate();

io.adapter(redisAdapter(pubClient, subClient));

Which in your case should give:
module.exports = class OurOwnRedisAdapter extends RedisAdapter {
  constructor(nsp) {
    const subClient = pubClient.duplicate();
    const options = Object.assign({
      requestsTimeout: 1000
    }, config.websocket.adapter);
    super(nsp, pubClient, subClient, options);
  }
 ...
}

Hi,
We've just upgraded redis adapter and ioredis to the latest version:
<EMAIL_ADDRESS>"^7.0.0",
"ioredis": "^4.27.6",

We using RedisAdapter extended:
module.exports = class OurOwnRedisAdapter extends RedisAdapter {
  constructor(nsp) {
    const options = Object.assign({
      pubClient,
      subClient: pubClient.duplicate(),
      requestsTimeout: 1000
    }, config.websocket.adapter);
    super(nsp, null, options);
  }
 ...
}

Our pubClient is created like this:
const pubClient = new Redis(_.merge(
    {
      dropBufferSupport: true // see https://github.com/luin/ioredis/wiki/Improve-Performance#dropbuffersupport-option
    },
    config.redis,
    scopedConfig,
    options,
    reconnectOnError,
  ));

And now we get this error that is difficult to know why.
 uncaughtException {
      error: TypeError: this.subClient.psubscribe is not a function
          at new RedisAdapter (/node_modules/@socket.io/redis-adapter/dist/index.js:64:24)
          at new OurOwnRedisAdapter (/lib/websocket-adapter.js:39:5)
          at Namespace._initAdapter (/node_modules/socket.io/dist/namespace.js:40:24)
          at Server.adapter (/node_modules/socket.io/dist/index.js:133:17)
          at module.exports (/lib/websocket.js:27:6)
          at Server.<anonymous> (/server.js:25:16)
          at Object.onceWrapper (events.js:421:28)
          at Server.emit (events.js:315:20)
          at emitListeningNT (net.js:1352:10)
          at processTicksAndRejections (internal/process/task_queues.js:79:21)
    }

This error happens when using 'redis' version 4.x.x, install version 3.x.x which works correctly.

@Morbden please check https://github.com/socketio/socket.io-redis-adapter/issues/417
Please also note that<EMAIL_ADDRESS>has been released only 20 hours ago :angel:

This was bad timing for some of us who weren't aware of node redis v4 being a brand new thing. I downgraded to v3 and it's working fine.


Repo Syncer: change HTTP method from POST to PUT

Because POST will error on re-pushing a schema

@alexanderdean do we need to rename ticket from Repo Syncer... to Registry Syncer... taking in account that commit was made before actual renaming, but in same release?

Yes please


Allow validation of OOXML macro-enabled and add-in files

Hi
Could you allow the validator to process files with the following extensions:

.docm, .dotm, .dotx (Word macro-enabled document, macro-enabled template, macroless template)
.xlsm, .xltm, .xltx, .xlam (Same for excel, plus add-in)
.pptm,  .potm, .potx, .ppam, .ppsm, .ppsx (Same for PowerPoint, plus macro-enabled and macroless show files)

These are all OOXML files, so the validator should work just fine on them.

Hi @rajch , Thanks for the request! This should be a quick change. I will get it in this week or next.


Refactor to use react-router-dom v6

We can refactor the website to use the react-router-dom v6. This will enable us to use the data API to improvise user experience.

As of now react-router-dom v5 doing the job perfectly.