Provide a way to restore a subset of keys into a running redis server from a RDB File

Very often, due to application bugs, teams lose or corrupt a subset of data within redis. For example, someone may have accidentally deleted some keys or would have run the wrong command.
There are a few ways to recover data in such cases - a) replaying AOF file after removing the offending command, or b) Restore an older RDB. Replaying the AOF is not always possible, because many cloud providers do not expose the AOF file, and not everyone has AOF enabled. Restoring an older RDB requires developers to spin up a new redis instance and then selectively copy data from the new instance to the existing instance with corrupted data.
This issue proposes another alternative - generating a stream of RESTORE commands. Developers can apply any of the existing filters to select a subset of keys from the RDB file, and then rdbtools will generate appropriate RESTORE commands. We should avoid connecting to redis servers directly. Instead, we should generate a stream of commands, and let the user pipe it to redis server using redis-cli.
Proposed syntax -
rdb --c restore /var/redis/6379/dump.rdb
To restore specific key pattern to a redis server running on localhost
rdb --c restore --key "users:.*" dump.rdb | redis-cli --pipe
By default, we will fail if the key already exists. We can pass the --force flag to replace existing keys. This will pass the REPLACE flag when invoking the restore command.

@oranagra FYI - I'm working on this feature request, should have a pull request in a couple of days

Thanks for such a great tool.
Just sharing that if one want look for an immediate way to restore a subset of keys from an rdb file it can be achieved with this approach.
rdb --c protocol --key "happybits:*" some_dump.rdb | redis-cli --pipe


Stuck on max following distance: 2021 Rav4 Hybrid

Describe the bug
The following distance can not be adjusted, and is stuck on the max following distance. I have not been able to since I got the vehicle. It wasn't an issue with my 2020 Toyota Camry Hybrid, so I'm just making the issue known. Other than that, the unit runs great. It is a 2021 Toyota Rav4 Hybrid (XSE, if it matters).
What hardware does this issue affect?
comma three
Which car does this affect?
Toyota Rav4 Hybrid 2021
Provide a route where the issue occurs
1c05783affe6641f|2022-01-14--19-21-37
openpilot version
0.8.12
Additional info
Openpilot was engaged around 19:23:43 in the clip, if that helps. Although, I know this a car issue. Thank you comma team!

This isn't a bug, its a different experience between the two vehicles due to vehicle specific limitations. Vehicles that openpilot controls longitudinal on (gas/brake functionality), in your case your RAV4, the following distance is not adjustable. On vehicles that openpilot is not in control of longitudinal, such as your Camry where this functionality was left to the factory control, you can change the distance.


use hashed username in cache dir

Addresses permission concerns with filecache (@tmatsuo PTAL)

At the very least, the directory permissions need to be relaxed. As this is currently implemented, if the first user to call this function creates any directory defined in the base path (e.g. the default google-api-php-client directory), all other users would unable to create their cache directories because they wouldn't have read or write permissions to the base directory. The same goes for the hash prefix directories.

@huebs
That's a good point. I have a proposal.

LGTM

@huebs thoughts on this final iteration?

@bshaffer, I see it's already merged but, to answer your question, it looks good to me. Thanks for taking the time to work through this issue (same to @tmatsuo).


Fix test_pack_combiner for Flink and Spark

translations.pack_combiners are enabled for Flink and Spark through PortableRunner, but the corresponding test test_pack_combiners was broken and skipped by Flink and Spark. This fixes test_pack_combiners for Flink and Spark and removes the test skipping in most cases.

Skip test_pack_combiners in FlinkRunnerTestOptimized because stages produced by translations.pack_combiners are fused by translations.greedily_fuse, which prevent the stages from being detecting using counters by the test.
Remove stage name regular expression assertions that check that there are no unpacked stages after test_pack_combiners because these assertions don't work reliably in FlinkRunnerTest. The regular expressions can match other stages names such as InjectDefault that still contain the unpacked combiner names.
Change test_pack_combiners to assert that combiner packing happens only in batch mode and not in streaming mode.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb
cc: @ibzib

Run Python PreCommit

Test failure looks unrelated: FnApiRunnerTestWithGrpc.test_pardo_unfusable_side_inputs

@robertwb PTAL


Make sure that indices are available on all relevant devices

This PR transfers all is-sequence-finished indices to the relevant devices during token generation.

👍
I confirm that this PR fixes my issue with running a BitsAndBytes-configured model on a multi-GPU system.


Feature request Better control of Gantt Segments

So we have the main segment and the BREAK segment we can put our timeline under
Can we add some syntax to allow creation of custom segments?
like the ability for me to say
- [ ] 07:00 WORK | work task here
- [ ] 09:00 SCHOOL | Studying

this way the gantt chart displays the day in various tracks. even cooler would be coupling with #32 to have the different tracks be the different calendars/remidners lists on MacOS

Mermaid is no longer supported.


Temporarily disable XCM for Acala

Due to an incident on Acala, XCM is temporarily disabled
Disable these paths:

[x] Acala -> All other chains
[x] Polkadot -> Acala
[x] Moonbeam -> Acala
[x] Astar -> Acala

Note: Karura's still functioning properly

Version test:
Validation passed


Spurious location change events

When I woke up this morning, I was surprised to find that the garage door was open. It turns out that at 4:12:15 AM my car's device location changed to "home", but it never left the garage. The location change fired off my automation to open the garage door, leaving it open. I got push notifications after 30 minutes (a separate automation), but didn't see them till I got up.
Checking the log book I see that the car was first reported as "not_home" at 12:12:15 AM, then at "home" almost exactly 4 hours later. Also just after the "home" event I see this one:
Lucid AIR Power state  changed to Cloud 2

Just in case I checked for other log events and none of the other doors or windows were opened. Also there were no camera event around these times.
Maybe what happened was a reset of some kind on the Lucid service side that generated the spurious not_home /home events?
I can work around this by making my automation smarter. I'm reporting the issue here in case there's something that could be done at the integration level to deal with Lucid service availability issues.
Note that I can't prove that there was a Lucid service issue. In the log file the only Lucid entry is this unrelated problem:
2024-02-19 14:30:48.211 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.lucidmotors.climate.LucidClimate'>) implements HVACMode(s): off, heat_cool and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/borski/ha-lucidmotors/issues

I can report the climate issue separately, if that helps.

Interesting. Can you add a Map Card to some dashboard, add the car to it, and set "hours to show" high enough that it includes that period? That'll show you a track of where its location was reported. I wonder if it jumped a long way, like to the "default" location at Lucid HQ, or if it just jumped maybe a few feet outside your "home" bubble and back in.
The power state change is just the car periodically waking up (slightly) to ping out. It does this every 4 hours while idle I believe.
And yeah, please do report that climate issue separately, that looks like it should be an easy one to fix.

Thanks for the response!
I added the map card and the results are odd. Thirty seconds before the spurious "home" event the car was located on the street behind our garage. Eyeballing and using Google Maps measure, it looks to be about 285 feet away.
But the "not_home" event started 4 hours earlier. I don't see anything in the map view that shows that event. But it's kind of hard to identify individual events because they form a fuzzy mass near where the car is actually located. I assume that's just GPS fluctuations.
It's almost like the car is nowhere for 4 hours (like not on the map at all), then materialized 285 feet away, then came home. That 4 hour window seems to line up with the sleep time.
Here's the logbook entries (I wish these were easier to export or copy):
Lucid AIR Power state  changed to Sleep
4:17:15 AM - 11 hours ago
Lucid AIR Power state  changed to Cloud 2
4:12:15 AM - 11 hours ago
Lucid AIR  was detected at home
4:12:15 AM - 11 hours ago
Lucid AIR  was detected away
12:12:15 AM - 15 hours ago
Lucid AIR Power state  changed to Sleep
12:10:45 AM - 15 hours ago

Seems like it would not be possible for the car to have any location change events while sleeping. Maybe there's a way to filter out the spurious events.
In the meantime I have a work around in my automation where if an ultrasonic sensor says that the car is in the bay, it won't open the garage when the car "arrives". I might augment that further to not open the garage if the arrival event happens when the car is asleep. I mean, it can't sleep walk (er, sleep drive) ;-)
I'll make a separate card for the climate error.

Just a little more information to add. I looked at the automation trace for the "away" event that happened at 12:12:15 AM. It basically did nothing because my automation ignores the trigger if the garage door is closed. But there's still a record of it.
Looking at the changed variables view for the trace I can see in the to_state that the GPS coordinates match the location that's 285 feet away from the house. So the order of events seem to be:

The car goes to sleep.
The car is detected away (on the street behind us).
The car is detected at home.
The car wakes up.
The car goes back to sleep.

Note that we've had problems before when getting an Uber or Lyft where if we summon from inside the house, sometimes the driver goes to the street behind us. It hasn't happened recently though. Still, there seems to be some confusion with map systems out there in the world. Maybe something similar happened here.
To work around this for now I've augmented both my automations with a template condition so that location change triggers are ignored when the car is asleep. For example, here's the arrival automation:
alias: Garage open on arrival Lucid Air
description: Open the garage door when the Lucid air arrives at home.
trigger:
  - platform: zone
    entity_id: device_tracker.lucid_air
    zone: zone.home
    event: enter
condition:
  - condition: and
    conditions:
      - condition: template
        value_template: "{{ states('sensor.lucid_air_power_state') != 'Sleep' }}"
      - condition: state
        entity_id: cover.garage_door
        state: closed
      - condition: state
        entity_id: binary_sensor.garage_middle_car_present
        state: "off"
action:
  - service: cover.open_cover
    metadata: {}
    data: {}
    target:
      entity_id: cover.garage_door
mode: single

That definitely just sounds like GPS inaccuracy. I think the car reports location changes even while asleep in case it's being towed or on a truck/ferry, that much makes sense. That also means we shouldn't just filter out location changes while it's asleep on our end.
I've had problems with HA automations even using our iPhones as location sources, because they'll appear to jump outside the house just like that. I just enlarged the Home zone to fix that (HA Settings > Areas and zones > Zones > edit). You can also use the Proximity integration for proximity and direction of travel (towards/away from home). I've been meaning to switch some things to that.
I'm going to close this since I don't think there's anything we can really do here, but please do comment if you have a suggestion.


fix(header): Fixing a bug in Authentication URL that it had newlines

Fixing a bug in Authentication URL that it had newlines which Omer reported

Looks good

:+1:


Hiding the Code Line

Wow... v2.0.0 is fantastic ... well done!
There may already be a way that I don't know about, but if not ... It would be great to be able to hide the inline code so printing or pdf output ... could or could not, (user's choice), show the code line.
Is that possible ?
Best Regards
Sergio

Thank you!
Right now it's rendered by default, but It would be a good idea to add a setting to show/hide the inline code as you say.
I'll be adding that soon 👌🏻


misc: update readme to add apollo studio

Linked to: https://github.com/async-graphql/async-graphql/issues/580

Great! 👏


Playground manifest configuration updates to support 10K devices

Commit contain following changes that is required to scale control plan to support 10K devices.

Use pgbouncer for postgres database connection pooling to ensure clients doesn't run out of connections for requests.
Update apiserver, ipam and auth deployment to use pgbouncer rather than directly using postgres db.
Update base auth deployment to explicitly set resource limits, so that overlays can override it.
Add patroni configuration to base database deployment, to configure max_connections and shared_buffer for database server for scale scenario. Base deployment is set to default values, individual overlays can overwrite it.
Configure PGBouncer to specify pool size and reserve pool per database, rather than per database server.
Add envoy files in playground overlay, to update with scale configuration for playground overlay. Playground overlay envoy configuration includes circuit breaker configuration and custom timeout values.
Update limitador config to increase the request rate limits.
Update playground kustomization.yaml to overwrite various limits for scaling playground deployment.

@nerdalert This PR will trigger update for the qa deployment as well, because the pgbouncer is added to the base database deployment (with default values), so pgbouncer will be deployed in qa namespace as well. It should not break anything in qa, as well as in prod deployment (when we promote it.)

Looking into integration job failure.

Restarted e2e


Unable to join servers with custom sound events (Minecraft 1.19)

Minecraft and mod versions:
Minecraft: 1.19
Mod: 2.3.1+1.19
Details:
The game is unable to join servers with custom sound events.
Expected behavior:
You should be able to join servers with custom sound events.
How to reproduce:
Join any servers with custom sound events.
Latest.log:
latest.log

Resolved in v3, might backport the changes to v2 if the new release takes too long.


Feature request - not only resize content but also move it to store a position

More detailed description needed.


Unable to download youtube data, can you provide the corresponding key frames?

Hello, I am very interested in your work. I'm having trouble downloading the data and I'd like your help.
I cannot download "video_url" in metadata.json through the following command.
youtube-dl --write-auto-sub -o 'file\%(title)s.%(ext)s' -f 135 https://youtu.be/JBzHBp6kfMo [youtube] JBzHBp6kfMo: Downloading webpage ERROR: JBzHBp6kfMo: YouTube said: Unable to extract video data
This video is a private video.

Please refer to https://github.com/haoningwu3639/StoryGen/issues/13#issuecomment-2018199255, we recommend you skip the inaccessible URLs, and use other data.
As we mentioned in the LICENSE and Copyright part of the README, considering YouTube's potential copyright issues, we are only able to provide the URLs of the videos we downloaded. But we also provide a complete data processing pipeline. You can re-capture suitable videos on YouTube to download, and use the tools we provide to process them into suitable training data.


[Backport] [1.x] Fixing MacOS 13 assemble workflows (once again) (#15898) (#15899)

Backport of #15898 to 2.x

@peternied please :)


Custom Attribute of cell not coming when undo redo

If I am deleting a vertex, I am updating one attribute in edges.
When I do UNDO I got vertex. But edge attribute not getting in UNDO.
please help on this

Please read https://stackoverflow.com/help/how-to-ask for help of how to ask a good question on development issues. In your case, an MCVE is critical, https://stackoverflow.com/help/mcve.


Yen's K-Shortest Path

Hello
I would be thankful a lot if you could add Yen's KSP to the Graphs algorithms. In general, it uses Dijkstra to find k-shortest paths and is crucial, when you need to get multiple weighted shortest paths contrary to one shortest path.
There are just a few implementations of it:
https://github.com/Pent00/YenKSP in Python
https://code.google.com/p/k-shortest-paths/ in C++/Java/C#
Having this one implemented would be a radical improvement comparing to other algorithm library implementations.
On another hand, I would be very curious to hear about other implementations, like Eppstein or Lawler

Thanks for the suggestion, this is clearly something I could add. I'll need to take a closer look at the algorithm to implement it though.
I'll try to work on it this week


Please invite me to the community

Name
victorpreston
Additional Context
I would like to be part of this reputed community

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


Fixing mssql_test.js example with correct sp_executesql syntax

sp_executesql syntax needs a statement  with @P  parameters, not $1.
Just fixing the example for MS-SQL Server 2022.
This PR fixes issue: #39 .

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thanks for reporting and fixing this! :bow: We missed this difference with MS SQL in #6, since we haven't automated testing against real servers yet.
I just tested manually against a SQL Server 2022 container (https://hub.docker.com/_/microsoft-mssql-server, mcr.microsoft.com/mssql/server:2022-latest), and you're right that the previous $1 syntax fails with:
GoError: mssql: Incorrect syntax near the keyword 'key'.

But I still get the same error after changing it to @p1. :confused: @param1 didn't work either. Can you clarify if the new example worked for you? Or maybe which edition of SQL Server 2022 you're running? The container runs the Developer edition, though basic syntax like this shouldn't change. I'm not familiar with MS SQL, so not sure if we have to use SET somehow to define the variable, but according to the documentation, @param1 should work...

Hi, sorry. I have just realised the mistake I made.  Here is the right query line:
SELECT * FROM keyvalues WHERE [key] = @p1;
I ran the example again with the query above and now it is working fine.   I thought having brackets was optional, but apparently "key" is a reserved word in MS-SQL.
It is all good now. I ran over SQL 2022 developer edition.


Basic Circle CI Support

Description
Circle CI is much better than Travis CI . Bear with me, I don't have a lot of experience to work with Circle CI before. It will take multiple commits to get it fully working.
Type of change
Check all that apply

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, if necessary
[ ] My changes generate no new compiler warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Inspect the bytecode viewer, including reasoning why

LGTM so far! Any issues you're having? Or do you want to have this merged and then we just run it on BOTH until we switch fully

I never have circle ci before. I would like to test it out.

Maybe let's merge then? Unless you wanna add somethign more on this?

I am planning to add more on testing the configuration out in circle ci.

Since this PR is created before the circleci checks, I think it is best to merge it now then add more later.


Bug in bills

[x] under payment mode,add bank option  as set cash in default
[x] give proper message for save without choosing vendor under creation screen
[x] under APPLY BILLS, status is still open. need to change partially paid or paid after apply such credits
[x] under Payment section in creation screen,need to reselect ledger account in every time

issues fixed !


allowing email overrides

This PR allows the user to override the email text in the app.
This prevents issues when email addresses are too long for the button text.

Hey thanks for the contribution!


Squashed commit of the following:

commit 977811f175c30bb97eb9dba14c8b6f5cc98b7b4d
Author: Sondre Lindkjolen<EMAIL_ADDRESS>Date:   Tue Nov 5 22:45:26 2024 +0100
clang-tidy --fix-errors

Having trouble with GitHub?

Having trouble with GitHub?

What do you mean?


Memory Leaks

I suspect there may be some memory leaks somewhere and would appreciate help finding them.

Unbased, will probably re-open if I run into any actual issues with memory.


Auto New Line Between Opening and Closing HTML tags.

Though the auto suggestion for closing tags is helpful, while using some other editors if i press enter between an opening and closing html tag, the cursor is automatically placed in a new line between them with proper indentation- This is really helpful and time saving.
As for now, if i press  enter between an opening and closing html tag the cursor is placed on a new line followed by the closing tag. Then i have to press enter again to push the closing tag below, then press up to come back to the line in between and give proper indentation. It'd be great if this is automated...
Keep up the good work.
Thanks and regards.

@njx  sorry I just start use Brackets. I have Emmet extension but still cant do that. I mean press enter before closing tag,  and cant get a new line. But in sublime text I can get it  with Emmet. Is there something in Brackets that I need to set?  Thank you.

Followed Mr. TomMalbran suggestion and I am not entirely sure what he meant but writing "closeTags": true but I figured out that he meant have both whenOpening and whenClosing to be set to true. And Voila! It works!

i try it set the configuration  both all.still can not work
"closeTags":  {
"whenOpening": false,
"whenClosing": true
}
"closeTags":  {
"whenOpening": true,
"whenClosing": true
}


chore: Confirm close permissions modal

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Confirms close modal when permissions have changed.
https://github.com/Flagsmith/flagsmith/assets/8608314/ff3ac1c5-800d-4d20-a802-dd019d686425
How did you test this code?
As above

I'm confused what this PR is doing as it seems like this works already in production?


Parsing issue: Trailing comma on enums is parsed into whitespace

enum Scope {
    None,
    Compile,
}

Additional parsing issue related to trailing commas in whitespace:
              public class Test {
                  Integer[] integerArray = new Integer[] {
                      1,
                      2,
                      4,
                  };
              }


Enable VM Test and Use Latest Deb URL flag

Please do retest and only merge after https://github.com/istio/istio/pull/3993
also fixes https://github.com/istio/istio/issues/3995

@chxchx: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @sebastienvas @rkpagadala @hklai

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-cluster_wide-auth.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-cluster_wide-auth-default.sh
f302add6e3c651a610e7c9a650e7236baada09e5
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-cluster_wide-auth.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-cluster_wide-auth-default.sh
96ecd93371926390d750544663efaee7e50ac6cc
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The flag --deb_url is not yet included in the release candidate so tests are failing. Will do retest for the releases candidate the next day

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-no_auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-no_auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-cluster_wide-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-no_auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-cluster_wide-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-auth-default.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-no_auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-cluster_wide-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth.sh
dc4b5d2b347507c87da0b2b5e3818a25033ef72d
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-no_auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-cluster_wide-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth

prow/daily-e2e-rbac-no_auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-cluster_wide-auth.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth-default.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-rbac-no_auth-skew.sh
a845ae398d235cbf8a4d920fc5d35a4d23fe42a3
link
/test daily-e2e-rbac-no_auth-skew

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-rbac-no_auth-skew

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-rbac-no_auth-skew

prow/daily-e2e-cluster_wide-auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-cluster_wide-auth-skew

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-rbac-no_auth-skew

prow/daily-e2e-cluster_wide-auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-cluster_wide-auth-skew

prow/daily-e2e-rbac-auth-skew.sh
3340aa848fc900a663ef5f16119c649ab4a6a677
link
/test daily-e2e-rbac-auth-skew

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Logging software versions in acquisition?

Is your feature request related to a problem? Please describe.
This is not related to a problem. Instead an inquiry, see below.
Describe the solution you'd like
It would be beneficial for SPIM systems (probably all of our systems) to record software information about the given acquisition. For example package versions for imported Python libraries, and for any internal libraries that may be undergoing ongoing development, git hashes. Is this something we already have added into aind-data-schema - or do we think this is worth adding/recording?
Describe alternatives you've considered
We currently stores these in the log files for each scan, so it is recorded. This is more of a question about whether we think this is important to push into aind-data-schema.
Additional context
None!

We do have a software class in device.py here that is called for specific devices (eg. camera): https://github.com/AllenNeuralDynamics/aind-data-schema/blob/main/src/aind_data_schema/device.py#L100
Would this work for your purposes or do you need something different?
Do you want to add this to specific devices or for the system as a whole?

@adamkglaser I think this is something we can easily do, but want to get a bit more context of where you'd like us to add software fields. Is it just for the entire system or are there particular devices that are associated with specific software.

Add an optional list of Software in the Acquisition class.


spContext is null

[Enter feedback here]
I edited the code exactly as indicated in this page, but when I run it, the spContext comes out as null.
I debugged it and the Session["SPContext"] returns null because Sessions has zero not elements (count = 0)
Any ideas?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d42afced-99c6-19a0-0eb3-5b8dd8a41997
Version Independent ID: c31e26fb-1751-fb5a-6de0-830eb19fe322
Content: Include a custom button in the provider-hosted add-in
Content Source: docs/sp-add-ins/include-a-custom-button-in-the-provider-hosted-add-in.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Hi, I am unable to reproduce this issue. Are you able to provide your source code to help debug?

Thank you!
Attached is the code. I removed the packages folder.
1_BeforeSharePointUI.zip

Hi, Unfortunately, I am unable to figure out what is wrong with your solution. I personally walked through that tutorial in my dev environment and my session objects are populated with values. Can you confirm when you are launching the app from Visual Studio, you aren't just launching the web project... but the add-in is installing in your developer site and launching the Provider Hosted Add-in, passing in the SPHostUrl parameters?

Yes, I can confirm that.
If I remove the following line from the OrderForm.aspx file, I can use the Web part with no problems:
" />
But I don't have access to the SP context at all... Is there any setting in the SP site (or the browser) that may be causing the problem?

It doesn't appear to be a SharePoint problem. I tried to create other variables server side, and they were inaccessible in your solution... so something is wrong in your solution... I'm just not sure what.
As mentioned, I started fresh from the tutorial using their sample and walked through it and it worked for me. Maybe it would be worth trying again.


Add support for ZLIB_COMPÅT in nmake Makefiles for ARM/AArch64.

This should fix compiling when ZLIB_COMPAT is enabled on nmake command-line.

Could you add a commit that enables gz_fileops by default?
That way this change gets better testing by the CI, and it brings nmake in sync with the rest.


tag fallback for releases

Some projects do not have releases and just use tags
Example: https://github.com/svdo/swift-netutils/releases
The api call for releases is empty
Also need to make sure the greatest semver # is taken from the releases and tags

I don't think I'm going to work on this. Just release your project properly.

I may have to relook at this. Look at tags and hope the tag is a semver? What is the official way they do this?

@twodayslate would this interest you? https://github.com/igor-makarov/RxReactiveObjC/blob/22830b3937ef150357f42de4990753ba69d97f0c/RxReactiveObjC.podspec#L6

@igor-makarov the GitHub API exposes the tags with /tags. Currently only /releases is checked.
Once the latest tag is found (or default branch) I simply fetch the tarball


Forgot to put out the localizations too

The joys of not having a workspace when sending out a change

The lexicon entry is also missing but I will add that


Function object does not implement function interface as indicated by is operator

I assumed that the implementation inside the call function class leads to the fact that this class will implicitly implement the function interface. But as the following example shows, this is not the case and the behavior is a little strange in terms of the type hierarchy. Is this an error with the is operator, or is this by design?
class Example {
  void call() {}
}

void main() {
  var example = Example();

  // No errors, because the class has a function "call".
  Function function = example;

  // false
  if (function is! Function) {
    print('Error: the function is not really a function.');
  } else {
    print('A function is actually a function.');
  }

  // true
  if (Example is! Function) {
    print('Error: example does not implement interface functions.');
  } else {
    print('Example implements Interface Functions.');
  }
}

It's by design.
No class implements the Function interface except Function itself.
It used to be the case, in Dart 1, that a class with a call method implemented the function type of the call method, and thereby Function.
That was incompatible with the sound type system of Dart 2, so callable classes no longer implemented function types.
We could have let them still implement Function, but preferred to not do that either, so that is Function now distinguishes between function objects and class instance objects.
In Dart 2, function objects really are a different kind of object than class instances, and the only kind of objects which has a function type. Being able to distinguish these using is Function was considered useful.
The reason the Example() object is assignable to Function is that an implicit coercion happens at the assignment.
The behavior of Function function = example; is really that of Function function = example.call;, performing an "implicit call tear-off".
So, callable objects are not functions. They can be assignable to function types, and always to Function, but are not subtypes. Being assignable when not being a subtype means that there is an implicit coercion inserted to create a value which is a subtype, before being assigned to a variable expecting that type.
Callable objects can also be called like functions, and again an implicit .call is inserted, to example() really means example.call().


Add server-delete functionality

Add option to delete server with specified Id.

Thanks again @ronakbanka for your contrib!
You can give a little update to the README with your new command and we'll be ok:
hubot openstack-compute server-delete <id> - Deletes a server with the specified id or name.

@willgarcia Updated .


Clarification needed

The presentaion rule will not allow wildcard certificates, while the validation rule will. Since certificates are to be found according to presentation rules before passing the validation, how would one use a wildcard certificate? This page is long and it's difficult to follow and grasp the whole idea without having some kind of simplified image or diagram to refer to while reading the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba0d00b5-2f24-d2f7-b73e-12ce017294e0
Version Independent ID: cceef963-25e0-3d66-0ae4-01fd40b2092f
Content: X.509 Certificate-based Authentication in a Service Fabric Cluster - Azure Service Fabric
Content Source: articles/service-fabric/cluster-security-certificates.md
Service: service-fabric
GitHub Login: @erikadoyle
Microsoft Alias: edoyle

@mcurko
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@erikadoyle
Can you please check and add your comments on this doc update request as applicable.

@mcurko If you declare the configuration as "CN=.example.com" and consider two certs, Cert A with CN=.example.com and Cert B with CN=subdomain.example.com.
The observed behavior will be that when presented with either cert SF will accept it, but SF will never pick up Cert B when choosing a certificate to select. It will only consider Cert A as a valid match for selection.
Generally, I wouldn't recommend using wildcard certs as the cluster certificate. If it seems like they are needed for some scenario, the security boundary between multiple clusters is likely being subtly broken in some way. A case to use them would be for declaring client certificates, where multiple valid client certificates can be tied to a single validation rule in SF, and SF does not use client certs for presentation nor expect them to be provisioned into the cluster.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


tweak!(input): remove remapping of i_ctrl-* keys

BREAKING CHANGE: Ctrl-* keys are back to default meaning in insert mode
Changing the signification of Ctrl-* keys in insert mode seems
unnecessary and ends up confusing because it is not necessarily the same
bindings as in normal mode.
Creating the PR to announce the possible change to @brabalan and ask for input. I'm going to use that for a couple of weeks before committing to a decision

I’m giving it a try, I’ll report if I find anything troubling.

I’m giving it a try, I’ll report if I find anything troubling.


Add support for embedded actions

Hello,
I'm still playing with the Bundle and not having to deal with the container is really enjoyable, although PHPStorm provides auto-completion on services. It's just less coupled, and that's a good thing.
But today, I encounter an issue with something I'm not familiar with: embedding controllers (and, in fine, actions) into templates.
Let's say I have a list of items rendered by AppBundle:ItemListAction.
As a user, I want to be able to delete any item of the list via a delete button, with CSRF protection. Usually, I'm using a GET route for that, to generate a simple link to delete an entity, and this is a bad design: this can lead to cache and security issues.
So, I have created an AppBundle/Action/ItemDeleteAction, invokable with a HTTP DELETE method.
Here's the example action class:
namespace AppBundle\Action;

use AppBundle\Entity\Item;
use Doctrine\Common\Persistence\ManagerRegistry;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\Form\Extension\Core\Type\FormType;
use Symfony\Component\Form\Extension\Core\Type\HiddenType;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\RouterInterface;

/**
 * Class ItemDeleteAction
 * @package AppBundle\Action
 * @Route("/items")
 */
class ItemDeleteAction {

    /**
     * @var FormFactoryInterface
     */
    protected $formFactory;

    /**
     * @var RouterInterface
     */
    protected $router;

    /**
     * @var ManagerRegistry
     */
    protected $managerRegistry;

    /**
     * ItemDeleteAction constructor.
     * @param FormFactoryInterface $formFactory
     * @param RouterInterface $router
     * @param ManagerRegistry $managerRegistry
     */
    public function __construct(FormFactoryInterface $formFactory, RouterInterface $router, ManagerRegistry $managerRegistry) {
        $this->formFactory     = $formFactory;
        $this->router          = $router;
        $this->managerRegistry = $managerRegistry;
    }

    /**
     * @Route("/{id}", name="item_delete", methods={"GET", "DELETE"})
     */
    public function __invoke(Request $request, Item $item) {
        $formBuilder    =   $this->formFactory->createNamedBuilder('', FormType::class, ['id' => $item->getId()]);
        $formBuilder    ->  setMethod('DELETE');
        $formBuilder    ->  add('id', HiddenType::class);
        $formBuilder    ->  add('submit', SubmitType::class, ['label' => 'Delete']);

        $form           =   $formBuilder->getForm();

        if ($request->isMethod($formBuilder->getMethod())) {
            $form->handleRequest($request);

            if ($form->isValid()) {
                $this->managerRegistry->getManagerForClass(Item::class)->remove($item);
                $this->managerRegistry->getManagerForClass(Item::class)->flush($item);
                return new RedirectResponse($this->router->generate('item_list'));
            }
        }

        return $form->createView();
    }
}

So far, I've understood that the only reliable way to provide a delete button within a loop of entities, is to use Twig's render function like this: {{ render(controller('AppBundle:Item:delete', { 'id': item.id })) }} where a legacy AppBundle\Controller\ItemController::deleteAction() would render a form view of the delete button with hidden fields (_method=DELETE and a _token field).
Despite not being in love with calling controllers from templates, it looks like some logic implementations can't be handled in a prettier way. Or maybe I haven't RTFM enough :)
Because of the Symfony short syntax, which is still a little bit obscure to me, it looks like it's not possible to call {{ render(controller('AppBundle:ItemDelete', { 'id': item.id })) }} so as to invoke _AppBundle\Action\ItemDeleteAction::invoke().
Or am I missing something?
Thanks,
Ben

Can you try {{ render(controller('action. AppBundle\Action\ItemDeleteAction', { 'id': item.id })) }}?

It seems to work, but it can't read the associated @FOS\RestBundle\Controller\Annotations\View / @Sensio\Bundle\FrameworkExtraBundle\Configuration\Template annotation. I'll look further to make things work.
Besides, when you don't follow the ADR pattern which recommends one action per class, and you want to call AppBundle\Action\ItemAction::deleteAction, is it possible?
Thanks a lot for your help,
Ben

The fix for SensioFrameworkExtraBundle's @Template is ready: https://github.com/sensiolabs/SensioFrameworkExtraBundle/pull/398
For FOSRest I don't know.
For AppBundle\Action\ItemAction::deleteAction, yes it's possible just use the following notation:
{{ render(controller('action.AppBundle\Action\ItemDeleteAction:deleteAction', { 'id': item.id })) }}

Btw, you can try action.AppBundle\Action\ItemDeleteAction:__invoke with FOSRest but I don't know if they support controller as a service.

The @View annotation of FOSRestBundle is linked to SensioFrameworkBundle so when https://github.com/sensiolabs/SensioFrameworkExtraBundle/pull/398 will be merged @View will be fixed too.

Hello,
I confirm this works :)
Calling {{ render(controller('action.AppBundle\Action\ItemAction:deleteAction')) }} inside the @App/Item/index.html.twig view  is OK when this controller returns a HttpFoundation Response object.
On the other hand, when action.AppBundle\Action\ItemAction:deleteAction returns something else (like an array or a Form object, thus relying on annotations to render the correct view), Symfony should read the associated @View or @Template annotation, and render @App/Item/delete.html.twig for instance, but renders @App/Item/index.html.twig instead, as if it was still reading action.AppBundle\Action\ItemAction:indexAction annotations.
This issue (if it is one) isn't related to your bundle, but it's just to keep you (and the google world) informed of my testings.
I'll try to figure out how to make things work.
Anyway, thanks for your help and your great work.
Have a nice weekend,
Ben

@Template and @View are now supported.


September 2024 Endgame

9/23 Code freeze for the endgame
9/27 Endgame done
10/2 Expected release date (this may change)

Monday

[x] Pin endgame issue on GitHub @bpasero
[x] Run OSS tool @bpasero
[x] Update links in the Endgame notebooks to point to new milestone @bpasero
[x] Code freeze at 5pm PT, PRs should no longer be accepted to ensure a green build
[x] Ensure we have a green build on all platforms at 5pm PT @tyriar
[x] 🔖Ensure all closed feature-requests either have a verification-needed or on-testplan label
[x] Create test plan items following the template here by 6pm PT

[x] Remind the team that TPIs should be written so that anyone can test. If this is not feasible, then TPI authors should assign specific testers @bpasero

[x] Update your availability for testing here - https://tools.code.visualstudio.com/team-manifest team

[x] Update availability of testers in vacation (Check OOF section in the Internal Backlog Plan). Double check N/A testers. @bpasero
[x] Remind team that in the event of sickness or overload with TPIs, to inform the endgame champ ASAP so items can be reassigned

[x] Remind team to go through their fixed issues for the milestone and update repro steps for issues which require more detailed instructions.
[x] Set up the endgame retrospective to discuss process improvement

Schedule an endgame restrospective with endgame champion, endgame buddy, and next endgame champion for late debt week
Create the endgame retrospective tracking issue

Tuesday

[x] Test plan items assigned (using https://tools.code.visualstudio.com/test-plan-items)

Run the tool multiple times to balance load if test items come in later and assignments are already made
Assigned to you

[x] Test build starts at 7am CET
[x] Test plan ready by 8am CET
[x] Remind the team about the priorities

Tuesday should be dedicated exclusively to testing activities. Our goal is to ensure the completion of all Test Plan Items (TPIs) and subsequently proceed with the verification phase. Fixes or commits should be refrained from unless there are exceptional circumstances such as blocked TPIs or build-related issues. On Tuesday Redmond EOD, only blocked TPIs should remain open with a corresponding label blocked and status update comment in the issue.

[x] 🔖Testing
[x] 🔖Verification needed
[x] 🔖Verification (If verification needed is finished)

Wednesday

[x] 🔖Testing

These remaining TPIs should be the ones that are currently blocked. Discuss during the standup and redistribute assignments based on the TPI owner and the test coverage. For instance, if a TPI is owned by a member from Zurich and has not undergone sufficient testing, it will be reassigned to one of the Zurich team members.

[x] Remind team members to triage issues found in testing and assign major issues that they intend to fix to the current milestone. Remind team to move out or close other open issues/PRs on the milestone that they do not intend to fix this milestone.
[x] 🔖Verification needed
[x] Fixing (self-assigned, milestone assigned)
[x] 🔖Verification
[x] Message team members as needed to add steps to verification-steps-needed issues @bpasero

Thursday

[x] Make sure the insider build is green @bpasero
[x] Disable continuous insider builds and announce in #release @bpasero

:loudspeaker: Continuous insider builds are now disabled.

[x] Fixing (self-assigned, milestone assigned)

Increased scrutiny sets in due to testing being completed. Fixes pose a much higher risk
Move open issues/PRs to the next month that can be deferred

[x] Emphasize to the team that we want to verify as many issues as we can before the branching time, and ping team members as needed to remind them to add steps to verification-steps-needed issues  @bpasero
[x] 🔖Verification needed
[x] 🔖Verification
[x] By Friday BOD (Zurich), branch from main and release @bpasero

[x] Disable the continuous release by toggling the continuous release button on the top-right corner of the Builds page
[x] Branch following repositories to release/<x.y>

[x] vscode
[x] vscode-distro
[x] vscode-dev

[x] Localization: Run Update VS Code Branch build with release/* as the VS Code Branch parameter (it's the default so you shouldn't have to change anything)
[x] Announce main is open for business and all issues on the current iteration are candidates and that the candidate release process is to be followed.
[x] Build and manually release Insider from release/<x.y> branch for Code
[x] Build and manually release Insider from release/<x.y> branch for vscode.dev (if there were vscode.dev candidates)
[x] Announce in #release @bpasero

:loudspeaker: Extension authors ensure all release branch changes have been published to users, manually building and releasing if necessary.

[x] Build but don't release a stable build from release/<x.y> branch to ensure stable build is green @bpasero
[x] Bump up the version in package.json on main - @bpasero
[x] Create next milestone on microsoft/vscode repo and ensure that it has a due date. The created milestone and its due date will be automatically synced across our repos. @bpasero

Friday

[x] Only candidate issues are open and assigned to 🔖milestone
[x] All issues 🔖verified
[x] All open PRs on the milestone 🔖merged or deferred
[x] Fix candidate issues (major bugs only)

Discuss and get approval in stand up
Review and merge into release/<x.y>
Queue new auto-published insiders build as candidates are merged @bpasero
Author of candidate PR should find verifier

Satellite modules/npm packages ready, version updated, smoke tested

[x] yo generator @aeschli
[x] js-debug @connor4312
[ ] Debug Adapter Protocol @connor4312
[ ] vscode-debugadapter-node @connor4312
[x] vscode-test-web @aeschli

[x] All release notes updated

release notes are collected in a file named _v<Major>_<Minor>.md_ in this repo directory
Release notes screen recording guidance: https://microsoft-my.sharepoint.com/:p:/p/buhollan/Ecg_j89jzlVGtfqWGy7SQBEB_OsuLPZ65jjKRVlo_OdlgA

[x] Acknowledge third-party pull requests in release notes. @bpasero
[x] Acknowledge issue trackers from the community @chrmarti
When done fixing/verifying and there are changes since last build at the end of day PT

[x] Build and manually release Insider from release/<x.y> for Code @bpasero
[x] Build and manually release Insider from release/<x.y> for vscode.dev (if there were vscode.dev candidates) @bpasero

Monday

[x] Polish release notes @ntrogh
[x] Schedule an endgame restrospective with with endgame champion, endgame buddy, and next endgame champion for this week. Retrospective template
[x] Decide whether a Patch Tuesday release will happen:

Check the internal iteration plan for scheduled security issues (MSRCs) to determine if a Patch Tuesday release is needed.
If no Patch Tuesday release is planned, use the Patch Tuesday E-Mail Template to let the Updates team<EMAIL_ADDRESS>know of that fact. Please cc Monacotools on this email as the client patching team has asked us to do so. @bpasero
Otherwise, if a Patch Tuesday release is necessary, start off a Patch Tuesday Release plan @bpasero

[x] Remind the team: if they are going to be OOF for more than five days during the next iteration, assign someone to look out for critical issues in their feature areas and fix them if necessary. This helps with bug identification and fixing for recovery releases. @bpasero
[x] Run scripts/test-documentation.sh|bat after compiling the vscode repo, and fix any issues regarding new undocumented colors. Changes made to the vscode-docs repository must be merged to the main branch of that repository for the script to acknowledge them. False positives within the color section in vscode-known-variables.json can be moved under the others section of that file. @bpasero

Monday - Wednesday

[x] 🔖milestone issues
[x] 🔖candidate issues
[x] Polish release notes redmond
[x] Fix candidate issues (major bugs only)

Discuss and get approval in stand up
Review and merge into release/<x.y>
Queue new auto-published insiders build as candidates are merged @bpasero
Author of candidate PR should find verifier

[x] Build but don't release stable for all platforms as new candidate issues come in @bpasero
[x] Documentation updated
[x] Coordinate the official release timing with team and more specifically, team extension authors (ex: Jupyter and Copilot rely on VS Code release) @bpasero

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame, though the sanity testing step alone can happen earlier if there are no new candidates. @bpasero

Wednesday/Thursday - Expected release day (this may change)

[x] Build stable for all platforms @bpasero
[ ] Build but don't release an insider build based on main for all platforms @bpasero
[x] Sanity Testing

[x] Windows 64 bit @Tyriar

[x] System Installer
[x] User Installer
[x] Archive
[x] Server
[x] CLI

[x] Windows ARM64 @connor4312

[x] System Installer
[x] User Installer
[x] Archive
[x] Server
[x] CLI

[x] macOS Intel @lramos15

[x] Archive
[x] Universal Archive
[x] Server
[x] CLI

[x] macOS ARM64 @tylerleonhardt

[x] Archive
[x] Universal Archive
[x] Server
[x] CLI

[x] Linux x64

[x] Archive @rebornix
[x] DEB @rebornix
[x] RPM @andreamah
[x] Snap @andreamah

[x] Linux Server @rzhao271 (can be tested from any OS with Docker)

[x] x64
[x] ARM32
[x] ARM64
[x] x64 Alpine
[x] ARM64 Alpine

[x] Linux CLI @rzhao271 (can be tested from any OS with Docker)

[x] x64
[x] ARM32
[x] ARM64
[x] x64 Alpine
[x] ARM64 Alpine

[ ] Publish website @ntrogh @bpasero
[ ] Release stable from builds page no later than 11am PT @bpasero
[ ] Trigger the vscode.dev Deploy pipeline for release/x.y for the prod deployment target. Note that there are four deploy approvals needed - one for overall and one per each of the three service regions @bpasero

[ ] Request approval from another team member at the necessary step to deploy the vscode.dev build. @bpasero

[ ] Create an official release @bpasero

[ ] Create a tag (make sure you pull the release branch first): git tag <x.y.z>
[ ] Push the tag: git push origin <x.y.z>
[ ] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Example

[ ] X announcement @chrisdias
[ ] Create and publish next release notes placeholder @ntrogh
[ ] Enable scheduled insider builds @bpasero
[ ] Release insiders based on main @bpasero
[ ] Publish @types/vscode @bpasero
[ ] Close the milestone on GitHub @bpasero

The plan is to release 1.94.0 today at 11 AM PT latest.

thank you for all your hard work!

It went out already 🚀


[Bug] Cosmos dbt run inside DbtDag/DbtTaskGroup can select multiple nodes

Astronomer Cosmos Version
Other Astronomer Cosmos version (please specify below)
If "Other Astronomer Cosmos version" selected, which one?
1.5.0
dbt-core version
1.8.0
Versions of dbt adapters
dbt-snowflake==1.8.3
LoadMode
DBT_LS_MANIFEST
ExecutionMode
LOCAL
InvocationMode
DBT_RUNNER
airflow version
2.9.2
Operating System
not applicable
If a you think it's an UI issue, what browsers are you seeing the problem on?
No response
Deployment
Astronomer
Deployment details
No response
What happened?
If you have a project structure that looks something like this:
dbt/
| - models/
  | - foo/
  | - a.sql
  | - foo.sql

Then the node selected for foo will run both a and foo.
The solution is most likely to use the fqn to select nodes instead of just the node name to guarantee uniqueness: https://docs.getdbt.com/reference/node-selection/methods#the-fqn-method

Also a note, LoadMode.DBT_MANIFEST is the proper name for the load mode, not DBT_LS_MANIFEST 🤷 This should be fixed in the bug report issue template. Also, the only version you can select of Cosmos is 1.4.1.
Relevant log output
No response
How to reproduce
See above
Anything else :)?
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Contact Details
No response

Thanks for reporting this, @dwreeves !
Do you think the fqn method would also allow us to continue supporting versions? This was the one concern that popped up, thinking about the changes we had in selecting nodes in the past months

Reopening as "dosubot" marked it as stale & closed it prematurely.


[WIP] tests: added "fleetctl --tunnel" tests

adding tests which will cover #565 #1425 #1455
closes #1484
work in progress

Looks like WaitForNActiveUnits doesn't wait for N active units, which are templates. have to fix that.

Yet another test for #565:
$ export REMOTE_HOST=localhost
$ for i in {1..10}; do (ssh-keygen -t rsa -b 4096 -f $HOME/.ssh/id_rsa_$i -N ''; ssh-add $HOME/.ssh/id_rsa_$i)& done; wait; echo "done"
$ fleetctl -strict-host-key-checking=false --tunnel $REMOTE_HOST list-machines
Unable to initialize client: failed initializing SSH client: ssh: handshake failed: ssh: unexpected message type 1 (expected 52)

Trying to find other way to fix this bug. https://github.com/coreos/fleet/pull/1492/commits/ea415adbb229624f9f632f7c69a4829036a1a17d is only workaround which doesn't explain cause of the problem

@jonboulle if you accept this fix, let's merge this PR. and I'll try to find proper solution later within new issue.

Couple of nits but LGTM overall!

@tixxdz any remarks or objections?

@kayrus thank you, please if you could change the name of that variable! then will merge.

@kayrus ok thank you merged, and thanks also for triggering that  "remote: Daily bandwidth rate limit exceeded..." !


ARROW-8993: [Rust] support reading non-seekable sources

A proposal of an implementation to read json.gz files. The idea is to along .json files, support gziped ones.
The implementation of json::ReadBuilder heavily rely on File. My first approach would have been to make another version of the builder that would rely on a BufReader<Box<dyn Read>> and have the original one delegate to this the final build.
I went with another approach, in this case I've added an option to specify if the file is gziped or not. In this case, the original implementation works as defined, however requires a switch of type as per https://github.com/apache/arrow/compare/master...zeapo:feature/json-gzip?expand=1#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR966-R967
I've got no religion on this. Suggestions are welcome, to be honest, I would love that the infer_json_schema be public , which would make all of this code unnecessary as it would delegate the builder process to the users who care about these features.
3 options :)

After sleeping on it, here's the 3rd option (exposing infer schema with BufReader): https://github.com/apache/arrow/compare/master...zeapo:feature/buffer-exposed
The advantage is that it does not need the dependency on gzip and has little impact on the api. It also opens the way to have other formats support.

...I would love that the infer_json_schema be public , which would make all of this code unnecessary as it would delegate the builder process to the users who care about these features.

Hi @zeapo, firstly, thanks for working on this. If exposing the function as public is helpful, please go ahead.

It also opens the way to have other formats support

Do you mean other compression formats?

However, this needs for the user to do manual seek (if the BufRead is on a File) and does not rely on the Builder. Unless a new builder with buffer is added.

I suppose the broader question to ask would be whether we'd like to support reading (and writing) compressed data. There have also been some changes on the arrow::csv side, such as allowing inference of multiple files, which might also be convenient to have in arrow::json.
What's your opinion on the 2 above? We need not implement them as part of this PR, but I suppose some user feedback is helpful :)
I'm still pro returning the reader back to the start, or is there a performance impact in doing so? I wouldn't want to place the burden of seeking on the user, because I'd expect the common inference case to be getting the schema then reading the file.
    // return the reader seek back to the start
    reader.into_inner().seek(SeekFrom::Start(0))?;

Thanks for your feedback.

Do you mean other compression formats?

Yes, but not only. This would allow also to have different filesystems (like S3) where using File is not possible, and would make much more sense to have dyn Read (in rusoto they use ByteStream that implements Read and AsyncRead)

There have also been some changes on the arrow::csv side, such as allowing inference of multiple files, which might also be convenient to have in arrow::json

That would be great. This would help when there are multiple small file that are written without a fixed batch size (small & big files) and data would be scattered across multiple files. If you have a JIRA issue for this I can take a look at it :)

I'm still pro returning the reader back to the start, or is there a performance impact in doing so? I wouldn't want to place the burden of seeking on the user, because I'd expect the common inference case to be getting the schema then reading the file.

I agree that placing the burden on the user is a bad idea. However, there are situations where we just can't seek back to start (s3 is one example). Maybe a specific implementation for Seek + Read, that would do the seek back to start, and one for Read only, that would not. However... this would need the use of specialization, so more nightly dependencies.
Not really sure :/

I've updated the little poc: https://github.com/apache/arrow/compare/master...zeapo:feature/buffer-exposed
The main changes are:
pub fn infer_json_schema_from_seekable<R: Read + Seek>(
   source: &mut R,
   max_read_records: Option<usize>
) -> Result<Arc<Schema>>

and
pub fn infer_json_schema_from_reader<R: Read>(
   reader: &mut BufReader<R>,
   max_read_records: Option<usize>
) -> Result<Arc<Schema>>

And the fact the build requires a Seek too. This makes the builder File agnostic, and relies only on Seek.
Now, if the user (i.e. me? ^_^) wants to use a non-seekable, I'd use the infer on the buffer, handle the memory myself and pass the schema I inferred.

I agree that placing the burden on the user is a bad idea. However, there are situations where we just can't seek back to start (s3 is one example). Maybe a specific implementation for Seek + Read, that would do the seek back to start, and one for Read only, that would not. However... this would need the use of specialization, so more nightly dependencies.

Okay, in that case I could support not seeking back to the start of the input. One downside though is that in the case where no schema is supplied, and the readers (csv and json) infer the schema, we do need to reset the input to its starting position. I've briefly looked at the csv code, so if it's doable, we could find a solution.
Regarding specialization, we are already dependent on it, with low likelihood of this changing soon; so I'd say it's an option.
With regards to dyn Read, please have a look at the arrow::csv::reader code. We already support a BufReader<R: Read>, so I think we can implement the same without boxing the reader in the way that you've done so far. The only/primary reason why we still use File in arrow::json is that nobody's needed to use something else, or at least raised the issue.

One dramatic alternative would be to always require a schema, and leave inference to the user. We could then consume the buffer reader (reader: mut BufReader<R> instead of reader: &mut BufReader<R>), so that we don't leave the user with a file handle that's already partially/fully consumed.

One dramatic alternative would be to always require a schema, and leave inference to the user. We could then consume the buffer reader (reader: mut BufReader instead of reader: &mut BufReader), so that we don't leave the user with a file handle that's already partially/fully consumed.

I like this :+1:

One dramatic alternative would be to always require a schema, and leave inference to the user. We could then consume the buffer reader (reader: mut BufReader instead of reader: &mut BufReader), so that we don't leave the user with a file handle that's already partially/fully consumed.

this is the approach csv reader took as well, so another benefit from doing this would be consistent user experience.

Would it make sense to implement for json reader the same interfaces that are on csv reader, i.e. Read + Seek for infer_file_schema, and a json::Reader::from_buf_reader().
Then in another PR add an interface on Read only? In both json and csv. That would mean creating a new infer_reader_schema that takes a Read (rather than Read + Seek).

Looks like we have to remove Seek constraints in order to support compressed format across the board. If this is the plan here as well, then I recommend just implement Read for json in this PR (with extra Seek helper function if you prefer). Then send a follow up PR to update csv reader.

As per @houqp suggestion, here are the changes:

match csv's infer schema:

CSV: https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L90-L95
JSON: https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR174-R177
Mismatch: notice that the json's one return an Arc<Schema>. I don't know if we should make the csv reader match this or the other way arround. Especially that Reader::new takes Arc<Schema>
new function for seekable: https://github.com/apache/arrow/pull/7309/files?diff=split&w=1#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR159-R168

match csv's Reader::from_buf_reader:

csv: https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L235-L242
json: https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR377-R382

match csv's Reader::new:

csv: https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L198-L214
json: https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR341-R347

As per @houqp suggestion, here are the changes:

Thanks, I'll start reviewing them

Hi @zeapo, can you please rebase to fix the merge conflict? I'll merge this PR after that

I'll fix the build tonight.
Le lun. 15 juin 2020 à 18:21, Wakahisa<EMAIL_ADDRESS>a écrit :

Hi @zeapo https://github.com/zeapo, can you please rebase to fix the
merge conflict? I'll merge this PR after that
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow/pull/7309#issuecomment-644233988, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCABVQEVE6YUM6CTGEEKTRWZC63ANCNFSM4NPKLWTA
.

Hey @nevi-me, it should be done ^_^


Handle unixy paths in RWC tests

Fixes an issue @sandersn was seeing with rooted unix paths outputting in the wrong directory. The issue was that combinePaths drops the LHS operand when the RHS is rooted (which is not what was desired here) - this never happens with windows-captured baselines as the paths are preprocessed to remove the root (by replacing the colon).
Fixes #18561

What I meant is: should combinedPaths drop the left side when it's rooted? When is this desirable?

@sandersn its current behavior seems very intentional, as there's an explicit check for it. We probably rely on this behavior somewhere?

Yeah, probably. I think the current fix is fine. I removed the getRootLength check in combinePaths and it does indeed break tests that exercise module resolution.


Add constants, expression maths, better testing and more

Pull Request Test Coverage Report for Build 27

151 of 160 (94.38%) changed or added relevant lines in 6 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage increased (+8.6%) to 85.119%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

formulate/expression.py
88
97
90.72%

Files with Coverage Reduction
New Missed Lines
%

formulate/parser.py
2
90.4%

formulate/expression.py
7
83.65%

Totals

Change from base Build 22:
8.6%

Covered Lines:
429

Relevant Lines:
504

💛  - Coveralls

Pull Request Test Coverage Report for Build 27

151 of 160 (94.38%) changed or added relevant lines in 6 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage increased (+8.6%) to 85.119%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

formulate/expression.py
88
97
90.72%

Files with Coverage Reduction
New Missed Lines
%

formulate/parser.py
2
90.4%

formulate/expression.py
7
83.65%

Totals

Change from base Build 22:
8.6%

Covered Lines:
429

Relevant Lines:
504

💛  - Coveralls


remove DOM node from __mapped on componenWillUnmount() to prevent possib...

...le memory leaks
Navigating from view to view leaves DOM nodes in __mapped map. This can eventually increase memory consumption.

Yeah, great. Good point! Merged!


Implement namespaces for all functionality

Include namespaces in all operations. Also effects the UI, where namespaces have to be represented, and  - for example - splitting same annotation names over different namespaces where namespaces differ (>1 annotations of the same name cannot have worked before).

Namespaces appear in the grid editor in the column headers and can be changed, added and removed as part of (re-)naming annotations.


Production vs SyntaxSort

Right now, in KORE, we define new sorts by either a Production or a SyntaxSort. SyntaxSort can only introduce a sort, not define a subsort relation.
This is inconsistent as it is an attempt to separate sorts from productions, but at the same time using Production is required to encode sort-only properties like subsorting. The duality ripples into a lot ugly "case"-driven code.
I think we ended up with this situation because subsorting and productions share the same syntax in kore.k.
I propose to either:

Eliminate SyntaxSort all together and use a Production with no production items instead.
Add a "supersort" field to SyntaxSort such that it will encode all subsort relations. We could also enforce that all sorts descend from the some explicit top sort, i.e., syntax Foo becomes syntax Foo ::= Top. Not sure if that top sort should be K or a newly introduced one. Considering K has other implications, we might want to go for Top.

@grosu, @radumereuta, @bmmoore, @dwightguth, what do you think?
It's not a huge deal and I won't argue strongly for it but it struck me when skimming through the code in Module.

Here are a few thoughts:

the kernel of the parser doesn't care if a production is a subsort or a 'regular' production. Everything gets transformed into states for the kernel to interpret. It so happens that the what we call subsort, has only one non-terminal in the entire production. (in the parsing community this is also often called chain production, maybe to differentiate it from other meanings of subsort)

it is only later on when we try to do sort inference we need such information. Because the subsort production doesn't consume characters, I need to include the subsorts into sort inference also.

we have two types of productions: with KLabel and w/o KLabel
Exp ::= Int [klabel(Int2Exp)] and Exp ::= Int. In this case, the front-end considers this a subsort, because my criteria is 'has only one non-terminal`, but the back-end doesn't, because it produces a node in the AST.

we want to allow for a method to have annotations for sorts. I think the SyntaxSort was originally designed for this case: syntax Exp [my, tags, here].

The current role of SyntaxSort is for declaring sort attributes, or sometimes just to introduce sorts without giving them any content yet.
I'm very much against mixing that back together with subsorting declarations. For just one complication, if there was an optional subsort field, would the attributes of the SyntaxSort switch between describing the parent sort or the subsorting relationship based on whether that subsort field is set?
Splitting up Production might be reasonable, I'd have to see a bit more detailed proposal.


fix: Use basePath config option when creating resource listing pages

:tada: This PR is included in version 1.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add test coverage for code path where a specific error is expected (errors.Is)

Is your feature request related to a problem? Please describe.
For each errors.Is usage (e.g., errors.Is(err, sm.ErrExceedMaxSpan)), we should have a test covering this code path to ensure the expected behavior when the expected error is captured.
Describe the solution you'd like
Add test for these errors.Is code path, either unittest or integration test.

I may miss some existing test coverage for these, especially if they're tested via integraion tests. Please feel free to mention if they're tested.

errors.Is
tests

WriteSociIndex
no

buildSociLayer
no

snapshot.Prepare
yes, fuse mount failure test

reader.init
no (may not needed)

sociContext.Init
no

spanManager.GetSpanContent
no

sequentialLayerResolver.Resolve
yes

Additional context
Add any other context or screenshots about the feature request here.

For WriteSociIndex, buildSociLayer and sociContext.init, the errors are returned from the underlying oras-go library. These errors are not returned to the caller, but are used to weed out actual errors from 'Not Found' errors, which is not an error in that context.

Testing reader.init will require refactoring to add mockability to reader.initRootNode(), xid.New(), or one of various type methods in bolt.

I can confirm Rishabh's observation that those three methods are checking errors from oras-go. However, they may still deserve testing, given the general purpose of this issue is to test all places we check for specific error types using errors.Is
Per conversation with @kzys, the retry loop and error check in reader.init should be entirely unnecessary because the id produced by xid.New() includes a monotonically increasing integer field along with wall clock time, and producing 4 billion IDs within 1 second is implausible.
Per conversation with @Kern--, I am reducing priority of this issue.
Scope should increase to include the necessary refactors for the tests, it should probably be re-estimated, and it may need to be split into multiple issues.

#384 contained an unsuccessful attempt to implement one of the tests. Further mocking capability will be required to implement these tests successfully.