Handle invalid json in authorization header

If an app uses HTTP basic auth anywhere in its application (e.g. using Sidekiq web interface with HTTP basic auth protection), the middleware errors out due to the HTTP_AUTHORIZATION header not being valid JSON. This prevents access to these routes, in my case preventing access to the Sidekiq Web UI which we use a great deal.
Added simple error handling, in this case, to prevent the middleware from blocking requests unnecessarily.

This looks good, thanks for tackling it @intothefire!


listassets parameter count doesn't seem to work

I'm trying to figure out asset management via rpc and have found the following.
I'm referring to listassets but most likely it applies to all asset commands

Help for crul command does not exist, in help listassets
The count parameter doesn't seem to work, either I put a string or I put an integer. I have not confirmed whether the start parameter works.
The command pattern, according to the wallet api outline, should have the parameters in an array in the param key, but it has them in line.
Like
curl --user userpass --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "listassets", "verbose": true, "count": "5", "start": 3}' -H 'content-type: text/plain;' http://<IP_ADDRESS>:50001/

I will add documentation on how to use the command. Here is an example of how to use it with curl:
curl --user userpass --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "listassets", "params": [true, 10, 10] }' -H 'content-type: text/plain;' http://<IP_ADDRESS>:50001/

nice!


google.protobuf.message.DecodeError: Error parsing message with type 'sentencepiece.ModelProto'

raise "google.protobuf.message.DecodeError: Error parsing message with type 'sentencepiece.ModelProto'"
protobuf==3.20.0

Could you please give the full error log. Specifically, I need to know which line this error occurs on.

Alright.
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
Traceback (most recent call last):
File "web_demo.py", line 4, in
tokenizer = AutoTokenizer.from_pretrained("THUDM/chatglm-6b", trust_remote_code=True)
File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/models/auto/tokenization_auto.py", line 658, in from_pretrained
return tokenizer_class.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs)
File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/tokenization_utils_base.py", line 1804, in from_pretrained
return cls._from_pretrained(
File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/tokenization_utils_base.py", line 1959, in _from_pretrained
tokenizer = cls(*init_inputs, **init_kwargs)
File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 214, in init
self.sp_tokenizer = SPTokenizer(vocab_file)
File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 35, in init
self.text_tokenizer = self._build_text_tokenizer(encode_special_tokens=False)
File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 67, in _build_text_tokenizer
tokenizer = TextTokenizer(self.vocab_file)
File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/icetk/text_tokenizer.py", line 26, in init
self.proto.ParseFromString(proto_str)
google.protobuf.message.DecodeError: Error parsing message with type 'sentencepiece.ModelProto'

Alright.
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision. Traceback (most recent call last): File "web_demo.py", line 4, in tokenizer = AutoTokenizer.from_pretrained("THUDM/chatglm-6b", trust_remote_code=True) File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/models/auto/tokenization_auto.py", line 658, in from_pretrained return tokenizer_class.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs) File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/tokenization_utils_base.py", line 1804, in from_pretrained return cls._from_pretrained( File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/transformers/tokenization_utils_base.py", line 1959, in _from_pretrained tokenizer = cls(*init_inputs, **init_kwargs) File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 214, in init self.sp_tokenizer = SPTokenizer(vocab_file) File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 35, in init self.text_tokenizer = self._build_text_tokenizer(encode_special_tokens=False) File "/home/users/chenxu.wang/.cache/huggingface/modules/transformers_modules/local/tokenization_chatglm.py", line 67, in _build_text_tokenizer tokenizer = TextTokenizer(self.vocab_file) File "/home/users/chenxu.wang/anaconda3/envs/hdflow/lib/python3.8/site-packages/icetk/text_tokenizer.py", line 26, in init self.proto.ParseFromString(proto_str) google.protobuf.message.DecodeError: Error parsing message with type 'sentencepiece.ModelProto'

Are you sure you correctly downloaded the ice_text.model file? The correct file size should be about 2.7MB.

I have the same error. I have downloaded model files from huggingface, model files as followed

I think it's correct.

I have the same error. I have downloaded model files from huggingface, model files as followed

@jamestch You also need to download the ice_text.model  file.

You need to install git lfs to download large models from hf.

You need to install git lfs to download large models from hf.

I have installed git lfs, model files showed above is downloaded from huggingface by command
git clone https://huggingface.co/THUDM/chatglm-6b

I have the same error. I have downloaded model files from huggingface, model files as followed

@jamestch You also need to download the ice_text.model  file.

I have downloaded the ice_text.model file correctly since the SHA256 is right. But it did not work

I met the same error when loading the pre-trained LLaMA-2-7b model using the function AutoTokenizer.from_pretrained().
After setting use_fast=True, this error was fixed.

Finally, I re-downloaded the tokenizer-relevant files and solved this issue. Take the LLaMA-2-7b-hf as an example, update the files as below:

special_tokens_map.json
tokenizer_config.json
tokenizer.json
tokenizer.model


create purchase order sample is missing here

the first thing is to create a purchase order sample that is missing here.
but if I try to implement it using API documentation I am getting an error :
"Error": [
   {
    "Message": "A business validation error has occurred while processing your request",
    "Detail": "Business Validation Error: Please enter a valid email address.",
    "code": "6000",
    "element": ""
   }
  ],

also I tried to add "EmailStatus" => 0
but it becomes like
[EmailStatus] => QuickBooksOnline\API\Data\IPPEmailStatusEnum Object
        (
            [value] => 0
        )

and in json it passes like:
"EmailStatus": {
    "value": 0
  },

instead of "EmailStatus": 0
not sure how to fix it. I am using v5.3.3

@Er-Kalpesh I can't tell for sure what is causing this error without seeing the payload you are sending through. For API errors, can you please create a support ticket at https://help.developer.intuit.com/s/ ? Can you please also include the intuit_tid of the error response?

@bsivalingam I have created ticket there
https://help.developer.intuit.com/s/question/0D54R00006usaZNSAY/i-am-creating-purchase-order-using-guidelineshttpsdeveloperintuitcomappdeveloperqbodocsapiaccountingallentitiespurchaseordercreateapurchaseorderstill-getting-error-business-validation-error-please-enter-a-valid-email-addres?t=1580811040023
but I am using sdk and its issue in sdk
If i use api in postman its working fine

$poData = [
    **"EmailStatus" => 0,**
    "APAccountRef" => [
        "value" => $accounts->id,
        "name" => $accounts->name
    ],
    "Line" => $line_items,
    "VendorRef" => [
        "value" => $objectData->value,
        "name" => $objectData->nickname
    ],
    "TotalAmt" => empty($total) ? 0 : $total,
    "DocNumber" => $objectData->id,
];
$inputObjData = PurchaseOrder::create($poData);

here is the my code

$poData = [
    "EmailStatus" => 0,            // <<<<<<<------- Here we have to focus
    "APAccountRef" => [
        "value" => $accounts->id,
        "name" => $accounts->name
    ],
    "Line" => $line_items,
    "VendorRef" => [
        "value" => $objectData->value,
        "name" => $objectData->nickname
    ],
    "TotalAmt" => empty($total) ? 0 : $total,
    "DocNumber" => $objectData->id,
];
$inputObjData = PurchaseOrder::create($poData);

here is the my code

It looks like there's 3 valid values for Email status of the purchase order.
Valid values: NotSet, NeedToSend, EmailSent
Reference

@ajkreuer  thanks that works


openrisk: init at 0.0.1

Description of changes
Tool that generates an AI-based risk score
https://github.com/projectdiscovery/openrisk
Related to https://github.com/NixOS/nixpkgs/issues/81418

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219264 run on x86_64-linux 1

1 package built:

openrisk


Reduce number of test cases by correcting over-flattening in eachRecursive

I think this was the intent here; not to iterate over every character of every string, but rather to flatten the test cases down to the level of the leaves.

Know what; best just leave well enough alone.


add handling for extension base without children

When parsing the wsdl, the trace don't recognize the reference in the base attribute of an ExtensionElement without child nodes, when it comes to findChildSchemaObject. It should be handled like the type attribute on ElementElements

Coverage decreased (-0.03%) to 94.883% when pulling 26de3a85ce712a0fd784e65556d54dbdcde62a84 on KnutEdelbert:master into 1c76a878c1180358aeb97c397f9bca0cab44ab03 on vpulim:master.

Coverage decreased (-0.03%) to 94.883% when pulling 26de3a85ce712a0fd784e65556d54dbdcde62a84 on KnutEdelbert:master into 1c76a878c1180358aeb97c397f9bca0cab44ab03 on vpulim:master.

ok, finally, it looks good.
@jsdevel: is there anything else i have to do now?

ok, finally, it looks good.
@jsdevel: is there anything else i have to do now?

@KnutEdelbert please remove the change to package-lock.json

@KnutEdelbert please remove the change to package-lock.json

@jsdevel  as you wish - it's deleted

@jsdevel  as you wish - it's deleted

ok, i think it was better to revert the file instead of deleting it....
@jsdevel Everything ok now?

ok, i think it was better to revert the file instead of deleting it....
@jsdevel Everything ok now?


Remove candidate channel

/cherrypick release-0.4

/lgtm

/retest

OLM on OCP 4.13 is broken:
E1221 12:32:40.410089       1 queueinformer_operator.go:298] sync {"update" "nhc-install/oo-5c6vx"} failed: couldn't ensure registry server - error ensuring pod: : error creating new pod: oo-5c6vx-: pods "oo-5c6vx-lc7h5" is forbidden: violates PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "registry-server" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "registry-server" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "registry-server" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "registry-server" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
doesn't matter for now
/override ci/prow/4.13-openshift-e2e


Fix for Kubernetes manifests

At least on my K8s version 1.28.6 the manifests generated some errors:

"gameTCP" is a non-compliant port name in statefulset and also does not match service manifest
I believe the YAML port lists need different keys, for me always only one port was created instead of TCP + UDP
a service of type "nodePort" cannot expose port numbers below 30000, LoadBalancer is the right one imho

So I changed those things and in addition

separate /config and /config/gamefiles into 1Gi and 20Gi different persistent volumes (like the k8s-at-home chart does)

I am not sure if the service also needs a
loadBalancerIP:
Unfortunately the k8s-at-home helm chart has not been updated yet, so I also hacked my own custom helm chart together with these manifests, I could also add this to your repo.

Thanks for the PR! Appreciate it :)


Spinwick PR Mm 22845 permalink preview

Summary

Ticket Link

Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

Thanks @BenCookie95 @mkraft! Few things:

The system console has two settings with the same name, Propose changing the original link preview setting name to "Enable website link previews"

Similarly, can we change the name of the Disable link previews from these domains > "Disable website link previews from these domains" and move the position after the setting for "Enable website link previews"

Default for the new system console setting should be "true", but I think it might be currently "false" as it was set this way before I changed it and I can't seem to enable it by saving the config

@BenCookie95 or @mkraft can you guys help look into why the config can't be saved to enable the feature? ^

@BenCookie95 or @mkraft can you guys help look into why the config can't be saved to enable the feature? ^

I don't think this is picking up the server changes maybe? I'll check it out

@BenCookie95 looking awesome! Found one UI issue:
https://mattermost-server-pr-17796.test.mattermost.cloud/asgdg-ds/pl/xg1kgt7c1pbofks51i9mamcgja

@michaelgamble can you please give this a priority UX review?

@BenCookie95 UX review here: https://github.com/mattermost/mattermost-server/pull/17796#pullrequestreview-708612315

@BenCookie95 were these changes made? https://github.com/mattermost/mattermost-webapp/pull/8403#issuecomment-880873931
I didn't see them on the latest spinwick on the server PR but maybe it isn't pulling the latest webapp changes? https://github.com/mattermost/mattermost-server/pull/17796#issuecomment-887898631
cc// @mkraft

@BenCookie95 were these changes made? #8403 (comment)
I didn't see them on the latest spinwick on the server PR but maybe it isn't pulling the latest webapp changes? mattermost/mattermost-server#17796 (comment)
cc// @mkraft

I might not have pushed to the spinwick branch, I'll check it out

@BenCookie95 were these changes made? #8403 (comment)
I didn't see them on the latest spinwick on the server PR but maybe it isn't pulling the latest webapp changes? mattermost/mattermost-server#17796 (comment)
cc// @mkraft

@esethna This is fixed now. You can see it here https://mattermost-server-pr-17796.test.mattermost.cloud/

@esethna - We do have a process for this use case. Any team needing an in-product docs link can request one of the Writing team via a JIRA ticket. In-product docs links can be initially set up ahead of a given feature release.
The Writing team then either:

identifies where the new feature details will live in the doc set, or
creates a source file for the new feature docs

The Writing team provides that link to the R&D team implementing the feature, and then the Writing ensures that the feature documentation is available in time for the product release.
If redirects are needed in the future, the process of setting up in-product redirects is documented in the Handbook.

@esethna - Would you be open to creating a docs PR requesting the in-product docs link? In this docs ticket, can you also include details around the additional in-product text changes coming as part of this feature update? It would be ideal to track all necessary changes for this feature together, and the config setting changes will impact both docs and 301 redirects already in place.

Sure @cwarnermm PR here: https://github.com/mattermost/docs/pull/4921


Red-Black Tree implementation

Currently, the Red-Black Tree data structure has incomplete implementation. The upcoming updates should include the full, tested implementation.

The issue has been resolved with the PR #6


Compatibility

So I get it working with backend server.
Can someone confirm that this component does not work with firefox desktop and firefox reality?
On the Oculus Quest it works with the standardbrowser but not with firefox reality. With quest link as simulating a rift, it does not work with firefox.

I have the same problem. I've added details in #24


Shorthand to query all entities

Description
Create a special value ALL that can be used as the first argument in list queries to fetch all entities.
Example
swaps = uniswapV2.Query.swaps(
  orderBy=uniswapV2.Swap.timestamp,
  orderDirection='desc',
  first=ALL
)

Is this to fetch all graphql records in a single query?
For example - default is to query first 100 rows. Would ALL query all existing rows?


splash screen

Splash screen as in?

I want to make an attractive  splash screen ( a screen appears before the real website when the)

Splash screen as in?

I didn't understand what are you trying to say

I want to make an attractive splash screen ( a screen appears before the real website when the)

I think it's a kind of preloader feature right? or something else?

No it's not a preloader
Preloader appears whenever the page refreshed
But the splash screen appears when the website starts

No it's not a preloader
Preloader appears whenever the page refreshed
But the splash screen appears when the website starts

Before making a pull request, do show me what kind of splash screen you have created.

This is called splashscreen
https://user-images.githubusercontent.com/69043944/121470328-ac429e80-c9db-11eb-84ac-db676f7764d6.mp4

No it's not a preloader
Preloader appears whenever the page refreshed
But the splash screen appears when the website starts

Before making a pull request, do show me what kind of splash screen you have created.

Sure

I guess the pre loader is  better than splash screen , for now i am closing this issue . When pre loader added and i found any changes need i will work on that . Thanks


As a system user the latest version of the vAirify UI is deployable to the linux machine so it can be used

Requires the output of this story : #100
Containerise the UI
Acceptance Criteria:

Dockerfile made for the UI
Github action to build new image
Update compose files (local and deployment version)
Update all docs as necessary
Whenever a change is made to the UI and checked into main the CI pipeline automatically deploys this latest version into the linux machine.

Test Analysis

Navigate to http://<IP_ADDRESS>/city/summary and establish that it is deployed ✅


Debugging and stepping through brackets code

How do I step through brackets code ?
I have cloned the repo, but now I want to step through the code and have a look at its behavior. so far, I haven't been able to figure that out..
Any help ?

Go to Debug -> Show Developer Tools. You can step through the code there.

Hmmm, seems like I might be able to get what I want by just loading it into chrome ?

@sprintr , thanks. I want to step through brackets' code itself, not through my app's code.

Debug -> Show Developer Tools open the devtools of Brackets with Brackets code, not yours. Since Brackets shell is essentially a version of chromium, it can use the same developer tools as Chrome.

Debug > Show Developer Tools is only for Brackets' own code. Switch to Sources tab to have a look at the files.

cool, didn't know that.
does it work in Ubuntu, I see nothing when trying it on my Ubuntu box.

I am not sure about its functionality on Ubuntu. You should open up an issue if it doesn't work for you. @TomMalbran Has this been reported earlier?

I don't remember, and I don't know if it works or not.

I don't remember either. Search also didn't help.

Thanks guyz, I've opened an issue regarding this : https://github.com/adobe/brackets/issues/11334

Another question, now that I've been able to open the Debug > Show Developer Tools (in Windows) :
- Every file seems to be minified and starts with :  "eval("/*\r\n * Copyright (c) 2012 Adobe S ..."
How do I 'unminify' them all ? (to faciliate setting breakpoints and stepping through the code ?)

You need to load Brackets using the code from the repo. Here are the instructions:
https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets#setting-up-your-dev-environment

Awesome! I'm all set up and can already step through the code.
Thanks a lot !

This totally works on ubuntu, I use it almost every day


godot 4.2 doesn't have AnimationPlayer.add_animation anymore?

Tested versions
Windows 10 - Godot_v4.2-stable_win64
System information
Windows 10 - Godot_v4.2-stable_win64
Issue description
When I try to use add_animation in AnimationPlayer, it looks like doesn't have it anymore. Is it changed to others?
Steps to reproduce
$AnimationPlayer.add_animation
Minimal reproduction project (MRP)
animation_player.add_animation(anim_name, anim)

You need to use the AnimationLibrary interface, use get_animation_library

You need to use the AnimationLibrary interface, use get_animation_library
Instructions for this should be added to this page, which arguably makes this an issue for the documentation

May I ask how could I use get_animation_library to add new animation frame?
I tried the following code but look like is wrong:
`func setup_animations(data: Dictionary) -> void:
var anim_library = animation_player.get_animation_library("")
for anim_name in data["animations"].keys():
	var anim = Animation.new()
	anim.length = data["animations"][anim_name]["frames"].size() * 0.05
	var track_index = anim.add_track(Animation.TYPE_VALUE)

	for frame in data["animations"][anim_name]["frames"]:
		var frame_number = frame["y"] * sprite.hframes + frame["x"]
		var frame_time = frame_number * 0.05
		anim.track_set_path(track_index, String(sprite.get_path()) + ":frame")
		anim.track_insert_key(track_index, frame_time, frame_number)

	anim_library.add_animation(anim_name, anim)

animation_player.set_animation_library(anim_library)`

You can't set it, you just update it directly, see the documentation
No need to call any set method (there isn't one, you can have multiple libraries)

But while the documentation for migration from 3.x should mention this I'd say that you should ask in the other community channels for support 🙂, this is for reporting bugs

Let's keep this open to handle the documentation, or open one on the documentation page


Plugin removes project dir

Plugin cleanups dir it is bad behavior, as swagger has it's own .swagger-codegen-ignore

The plugin always clean up an output directory because generated files should be ephemeral and not be committed in a Git repository. It keeps simple and prevent human errors.

@int128 thanks for an answer, but as I pointed swagger has it's own .swagger-codegen-ignore

This needs to be removed. The output directory is already marked with @OutputDirectory, so a user should "clean" the directory by running the associated clean command to remove the outputs.
This make it impossible to use the swagger ignore file to handle manually changes to the generated code.

Would you tell me why you need .swagger-codegen-ignore behavior? What use case? I think it is bad practice. It causes generated result may differ depending on the environment, e.g. someone could compile it but others could not compile.
Anyway, I will add the feature to turn off wiping an output directory in the next release. Thank you for the proposal.

It is general idea, one who creates resourse is responsible for cleanup, imho


Address "Get Started" naming confusion

Ref #165846
Right now I see:

Help > Get Started as a menu entry and command name
"Get Started" as the tab name when looking at the welcome page
"Show welcome page on startup" and "Reset welcome page walkthrough progress"
"Getting Started with VS Code" as a walkthrough name

There's a mix of "Welcome" and "Get Started" usage that makes it hard to differentiate between concepts. We could either revert back to "Welcome" for the welcome page itself or rename it to differentiate from the first walkthrough.
Thoughts @digitarald @bhavyaus @esonnino?
Examples

@digitarald for historical context on naming here

Yeap..I believe changing the label in the tab to "Welcome" instead of "Get Started" is a good option -
It should say Welcome here:

When the user navigates away from the welcome page, the tab name should change to the walkthrough's name:
(It should say Learn the Fundamentals)

"Welcome" was the old page and we added "Get Started" as new name during development. "Get Started" did fit better for the walkthrough style, was a more action-style verb and used in many other apps. Not sure if more thoughts went into it, as the mockups that started in https://github.com/microsoft/vscode/issues/106717 were before my time and already used "Get Started".
I haven't many users ever get into Get Started or Welcome as command, so renaming would be low risk.

Is there a user issue mentioning the confusion? Asking to understand if we also need to account for user keyword search behavior in the command pallet when looking for walkthroughs or the Getting Started page after its been closed.
Currently, most walkthroughs use the "Get Started" terminology - Searching for "Get..." in the command palette surfaces the walkthroughs. I wonder if search terms are influenced by the page on which users first saw the walkthroughs and will the naming change have implications on the keywords to find walkthroughs?

No specific issue that I know of, I'm just spotting the issue of the strange overloading myself. @digitarald might know if we have any hard data on people searching for the command. But I'd also assume it's quite unlikely compared to going to the "Help" menu, for example.


Index Out Of Range

Latest Version 1.10.2 breaks with a list index out of range error when playing non steam games

i assume you only have a single steam account added to the script?


service is-active output check for "failed"

Description

small change to check for the right output of the system call

Fixes: #3572
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

manual testing on a nested env so far.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-267

@blueorangutan help

@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'anuragaw', 'shwstppr', 'andrijapanicsb', 'Spaceman1984']

@blueorangutan test 'centos7' 'kvm-centos7'

@DaanHoogland unsupported parameters provided. Supported mgmt server os are: centos6, centos7, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1

@blueorangutan test centos7 kvm-centos7

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan hello

hello @DaanHoogland

@blueorangutan thanks

you're welcome @DaanHoogland

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-268

@blueorangutan test centos7 kvm-centos7

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-345)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3574-t345-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_10_destroy_cpvm
Error
951.72
test_ssvm.py

test_05_rvpc_multi_tiers
Failure
425.99
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
452.47
test_vpc_redundant.py

I'll have a quick look at those logs but I don't think these blueorangutan/Trillian errors are related to this change.
We'll have to decide if this goes on an lts or in master btw. it was created to master before the recent 4.13 release and as it is a bugfix I think it should go in there... ? @PaulAngus @GabrielBrascher @rhtyd @borisstoyanov ?


Whenever i play i hear windows sounds

for some reason i keep hearing some windows sound every key i play.

Hi, this is addressed in the FAQ: https://github.com/ArijanJ/miditoqwerty/wiki/Troubleshooting#why-am-i-hearing-windows-error-sounds


Connection cache

https://github.com/asmodehn/pyros/pull/50 fixes travis build.

Related PR : https://github.com/robotics-in-concert/rocon_tools/pull/117

Maybe...reasonably working after minimal testing on the robot...will require further testing on the robot/concert. But follow up on those issues elsewhere.


elastic search hive table shows date as null

I have a hive table named details with below schema
name STRING,
address STRING,
dob DATE
My dob is stored in yyyy-mm-dd format.like 1988-01-27. In hive I can view this date with proper format.
I am trying to load this elastic search table . So i followed below instruction in HUE.
CREATE EXTERNAL TABLE sampletable (name STRING, address STRING, dob DATE)
ROW FORMAT SERDE 'org.elasticsearch.hadoop.hive.EsSerDe'
STORED BY 'org.elasticsearch.hadoop.hive.EsStorageHandler' TBLPROPERTIES('es.resource' = 'test4/test4','es.nodes' = 'x.x.x.x:9200');
INSERT OVERWRITE TABLE sampletable SELECT * FROM details;
select * from sample table;
But DOB field shows NULL for all coloumn. Whereas I can verify that my original hive table has data in date field.
After some research I was able to find that Elasticsearch expects data field to be in yyyy-mm-ddThh:mm:zz since my data doesn't match that it throws error. And also it mentioned, I can change the format to "strict_date" format, then it will work fine my hive date format. But I am not sure where in hive query i execute I need to metion this.
Can you help me with this?
I have seen multuiple threads where link is provided to mapping of elasticsearch site. But I am newbie  dont understand how to mention the date format in hive query. . Can you please help me here?

@theebanparthi1988 This is a question that is better suited for our discussion forums. We reserve Github for bug and feature tracking.


Learning rate

I would like to ask why there is many number when I print out the learning rate.
I think the learning rate is just a number.

It's weird. I never noticed this. I will figure it out soon.


README still mentions Aether

"OpenFL is powered by Aether, which includes powerful command-line tools to make cross-platform deployment sensible."
Didn't Aether get renamed back to lime-tools? This might lead to some confusion, no?

Thanks, just an oversight. The hazards of having documentation in multiple places :smile:


[JN-843] Rename site image and add delete button to media page

DESCRIPTION
TO TEST:  (simple manual steps for confirming core behavior -- used for pre-release checks)

you'll want to rename the three indexes on the table too
"site_image_pkey" PRIMARY KEY, btree (id)
    "site_image_clean_file_name_version" UNIQUE CONSTRAINT, btree (clean_file_name, version, portal_shortcode)
Foreign-key constraints:
    "fk_site_image_portal_shortcode" FOREIGN KEY (portal_shortcode) REFERENCES portal(shortcode)


Use Model::getKey() instead of id attribute

Because a primary key isn't always named id.
Reference: https://laravel.com/docs/8.x/eloquent#primary-keys

thank you

thank you


Replace structopt with clap

structopt is in maintainance mode and clap is the replacement.

@hawkw Thanks for the review and sorry for the long delay. I implemented your proposals.
I'm not entirely sure if it's worthwhile to have the port numbers as u16s, I trust your decision there.

Whoops, I just need to click the merge button, I must have forgotten that. Sorry!


Fixing bug on InMemoryVariableStorage if the Component was created by…

… code.

Please check if the pull request fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] CHANGELOG.md has been updated to describe this change

To update the documentation on yarnspinner.dev, please visit the documentation repository.

What kind of change does this pull request introduce?

[X] Bug Fix
[ ] Feature
[ ] Something else

What is the current behavior? (You can also link to an open issue here)
https://github.com/YarnSpinnerTool/YarnSpinner-Unity/issues/57

What is the new behavior (if this is a feature change)?
No more NullPointerException in this case.

Does this pull request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

This is no longer valid for v2.0 since "default variables" have been removed from the component in favor of declaring variables in the Yarn Program itself (see v2.0-beta2)
So we should either close this PR, or create a new v1.2 branch (at https://github.com/YarnSpinnerTool/YarnSpinner-Unity/releases/tag/v1.2.7) to retarget the PR for v1.2.x users

This is no longer valid for v2.0 since "default variables" have been removed from the component in favor of declaring variables in the Yarn Program itself (see v2.0-beta2)
So we should either close this PR, or create a new v1.2 branch (at https://github.com/YarnSpinnerTool/YarnSpinner-Unity/releases/tag/v1.2.7) to retarget the PR for v1.2.x users

Thank you for submitting this PR, @arendhil!
As @radiatoryang notes, this PR is no longer applicable to how Yarn Spinner for Unity works with variables, so I'm closing it.
If you'd like to adapt this for the earlier version, Yarn Spinner 1.2, I'd be happy to review it!


Bugfix/allow99 for dates

Minor changes to the date and time parsing code to allow "99" for unknown date or time values.

Thanks for this! There are a few tests failing, but I think I have a solution for those. I am going to merge this into an intermediate branch, address those test failures, and then merge into master.


Adds labels in German for About Page

For readability of the code, I broke up the paragraphs into concatenated strings.  But I'm not sure if this is the best way.

Debating whether to just go ahead and bring this in or to hold off until we've got a solid English version going on. Too tired to think it all out right now.

I think we should get the English version the way we want it first.  I can continue translating the text, but I'll just keep it as a separate text file and hold off on adding it to de.js.

I'm adding this translation in so we at least have it. @ValerieKenyon : Afterwards, adjust the file to match the new en.js format instead.

Thank you @knod !


Update QuickStart notebook: Mention stopping clusters and software environments

While chatting with @ndanielsen  about demoing, we think that the best way to show what coiled can do is by using the quickstart notebook. This PR explains what is happening and will link to parts of our documentation - it also mentions the coiled cluster dashboard a bit to check status.
One question that popped a few times was "how do I stop a cluster", so this is included. It might be worth touching briefly on the subject of software environments. As the last step, we create a simple software environment to show the user the workflow of creating software environments and then start a cluster and run the same computation as the one we did in the previous step.
@coiled/docs

That's a good question @ndanielsen  and yes we can (and probably should) name the cluster so it will be easier to delete and users can just click run without any input/changes to the notebook 👍


feat(textproto): prototype support for indexer plugins

this isn't ready for a full review yet, but any high-level thoughts on the approach, etc would be appreciated

plugins are linked into the indexer binary and referenced by name
during extraction, an optional list of plugins is saved to the compilation unit's arguments under the --kythe_textproto_plugins flag.
at indexing time, if any plugins are specified in the compilation unit, they are initialized at the start
each time a string field value is seen in the input textproto, the plugin's AnalyzeStringField() method is called

the plugin is given the text span of the string value. it can decide to do nothing or emit 1+ anchors covering subsets of the span

a subset of the TextprotoAnalyzer class is exposed through the PluginApi interface, which the plugin can use to add kythe entries and get info about the textproto

Caveats:
This will only support "simple" plugins that don't need to read other textprotos as dependencies. The plugin only has access to the current textproto and any .protos it depends on. The plugin is free to link in whatever data it wants at build time, but can not dynamically load other deps at index time (since they won't be in the compilation unit). This plugin support should work for several proposed/existing textproto-based features/languages in google3, but not all.
TODO:

[ ] use a zero copy reader implementation backed by a string_view for efficiency. I'm currently using one backed by a string, which requires much more string copying than necessary.
[ ] pass the parsed textproto to the plugin constructor
[ ] refactor to share more code between AnalyzeStringValue() and AnalyzeEnumValue()

during extraction, an optional list of plugins is saved to the compilation unit's arguments under the --kythe_textproto_plugins flag.

Do we need to do this or is the top-level protobuf message type sufficient?

during extraction, an optional list of plugins is saved to the compilation unit's arguments under the --kythe_textproto_plugins flag.

Do we need to do this or is the top-level protobuf message type sufficient?

That's a good point - it would probably be sufficient to just go based on top-level protobuf message and avoid propagating a plugin flag through extraction->CU->indexer.

Thanks for the review!


Develop

Codecov Report

Merging #382 into develop will decrease coverage by 4.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #382      +/-   ##
===========================================
- Coverage    69.31%   64.95%   -4.37%
===========================================
  Files          214      214
  Lines        11719    11721       +2
===========================================
- Hits          8123     7613     -510
- Misses        3596     4108     +512

Impacted Files
Coverage Δ

framework/utils/frame_work_log.h
0.00% <ø> (ø)

mediaPlayer/SuperMediaPlayer.h
93.96% <ø> (ø)

framework/data_source/curl/CURLConnection.cpp
52.28% <100.00%> (-12.86%)
:arrow_down:

mediaPlayer/SuperMediaPlayer.cpp
73.94% <100.00%> (-0.07%)
:arrow_down:

framework/tests/dataSource/ipList.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/demuxer/demuxerUnitTest.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

mediaPlayer/SuperMediaPlayerDataSourceListener.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0.00% <0.00%> (-93.85%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0.00% <0.00%> (-93.62%)
:arrow_down:

framework/tests/demuxer/demuxerUtils.cpp
0.00% <0.00%> (-76.00%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb5c1d...bc0b41e. Read the comment docs.


Add API / wrappers for life long learning RL

In discussions with a PhD college, they were explaining that life long learning in RL doesn't have a set of environments, API, wrappers, etc for researchers to use.
Therefore, I would propose that we add support for this as it is related to meta and multi-task RL.
In addition, we could look at transfer learning as an additional type of RL which I don't know the status of.

@pseudo-rnd-thoughts we're going to be adding the wrappers from ContinualWorld soon

Amazing, let me know if you want me to review any code


[WIP] : Implements Widget Tests

Implements Widget testing for History Screen

@nb9960 instead of manually merging master in your local fork, you can fetch upstream. This would reduce unnecessary commit messages. You can refer to this link

@nb9960 instead of manually merging master in your local fork, you can fetch upstream. This would reduce unnecessary commit messages. You can refer to this link


small error at week 5

The song says it's week 5 day 1.

Thank you for finding this!
Fix in https://github.com/Orbiter/C25K-Chiptunes/commit/dc5a959e1143946ca411c2f516bf54c4476d2c82


Couldn't update settings. Please check your connection.

While i am trying to sign in AOG test account this error occurred.
The log is:
login successful<PHONE_NUMBER>
authCode successful  36ipa97hxzw000000000000000
GET /oauth?redirect_uri=https%3A%2F%2Foauth-redirect.googleusercontent.com%2Fr%2Fintelliosmarthome&client_id=ZxjqWpsYj3&response_type=code&state=AB8b_TMBu32CycxEP_15Dc-wBdrQ-cR7a4KwMA1GE6xjTXCtHzMuIu1VCqkjJtTbWSc7oB--ZAqkG1442toCcVF_N6x-bzfP_nlSC_9ztHqeQ--6uj5uNmzjm7t2JYGQeyYkVeKThzQhjGC9ebHRrjQJXCCfzH6rO3R0LRZLsqD7T44BOR_iq3P_lQ5iDeZ1aVntxmCLsDaxEKMj5V0owdWKhu39kqdK4YwMQOUa1BQ8aAoBKK6UByYwXJehsS5v4xogiTKNqi0L4IaMVb8n_2aq69NewpztnRsx9Kk7iaUYRDYgd2aKdYh3mw56doNtg3PAAgk70LtyKGu_w1pyDbI_HyfYdA5FH0vwOuc42JQqhFjiFjedvRgYvYcguTFf9liT1j8GPw-sLP84Lz3UkItmiCIdiyYWgu-NOzF_QKmz7SnkL9SoGvJR3gm4Q-eQM0FNgq3OaYugmcHkcqSq3b6Qyo5vTXVHv3uOsC7F803rOfGCOMR64W9FiCPkca4fvnBFYcpteXsCNJ077Uq_9msxLAx8eLbW_3vhX7npPIc0wGc1fR7PQn9c7BKECvdltLdqE5JHdhqs&user_locale=en-GB 302 1.451 ms - 1434
GET /service-worker.js 304 0.990 ms - -
/token query {}
/token body { grant_type: 'authorization_code',
code: '36ipa97hxzw000000000000000',
redirect_uri: 'https://oauth-redirect.googleusercontent.com/r/intelliosmarthome',
client_id: 'ZxjqWpsYj3',
client_secret: 'hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv' }
getClient ZxjqWpsYj3, hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv
return getClient { clientId: 'ZxjqWpsYj3',
clientSecret: 'hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv' }
client { clientId: 'ZxjqWpsYj3',
clientSecret: 'hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv' }
handleAuthCode {}
getClient ZxjqWpsYj3, hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv
return getClient { clientId: 'ZxjqWpsYj3',
clientSecret: 'hIMH3uWlMVrqa7FAbKLBoNUMCyLCtv' }
getAccessToken =  { uid: 'jEIFDigfqRDxs3g02RmjnQ',
accessToken: '2wdj8wjy2qe000000000000000',
refreshToken: '2wdj8wjy2qe000000000000000' }
return getAccessToken =  { token_type: 'bearer',
access_token: '2wdj8wjy2qe000000000000000',
refresh_token: '2wdj8wjy2qe000000000000000' }
respond success { token_type: 'bearer',
access_token: '2wdj8wjy2qe000000000000000',
refresh_token: '2wdj8wjy2qe000000000000000' }
POST /token 200 1.654 ms - 112
.......................................
Please help me

It's not clear what error is happening.

It's not clear what error is happening.

It's not clear what error is happening.

In google assistant app after signing in it's showing "Couldn't update settings. Please check your connection.". Sync is not happening.

Hi @manikdutta, this repository is for issues related to the Smart Home Node.js sample code. It looks like from your log output that you are having issues with an action project you have already built and published. Can you clarify if you are having this problem running the sample or your own project code?
I would recommend either asking a question on StackOverflow if this is an issue you encountered while developing, or filing and issue in the public tracker if this is something you've experienced after your action was published.


[FluentPersona] Add support for icons

Pull Request
📖 Description
The FluentPersona component only supports displaying images and initials in its circular avatar area.
This pull request adds additional support for icons to be displayed.
Images will always be preferred over icons, which themselves will always be preferred over initials.
This pull request further fixes the RTL margin for the FluentPersona component.
✅ Checklist
General

[ ] I have added tests for my changes.
[x] I have tested my changes.
[x] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[ ] I have added Unit Tests for my new compontent
[x] I have modified an existing component
[ ] I have validate Unit Tests for an existing component

It would be more "logical" to allow an icon (SVG) to be included in the Image property.

Funnily, that's the first thing I tried today, when I needed an icon avatar 😄
So, you say no new properties should be added but instead it should be checked whether Image contains an SVG (i.e. Image.StartsWith("<svg>")? At least, I wouldn't know how else this could be implemented)?

We could convert an Icon to an img src (used in FluentPersona), adding this part of code in Icon.cs file
public virtual string ToDataUri(string? size = null, string? color = null)
{
    var svg = ToMarkup(size, color).Value;

    // Attribute xmlns="http://www.w3.org/2000/svg" is required for SVG data URI.
    svg = svg.Contains("http://www.w3.org/2000/svg") ? svg : svg.Replace("<svg ", "<svg xmlns=\"http://www.w3.org/2000/svg\" ");

    var base64Svg = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(svg));
    return $"data:image/svg+xml;base64,{base64Svg}";
}

So, the usage will be
<FluentPersona Name="Bill Gates"
               Status="PresenceStatus.Available"
               StatusSize="PresenceBadgeSize.Small"
               StatusTitle="He is available"
               Image="@(new Icons.Regular.Size48.Person().ToDataUri(color: "white"))"
               ImageSize="50px">
</FluentPersona>

Can you update your PR? Or I can create a new one if you prefer.

We could convert an Icon to an img src (used in FluentPersona), adding this part of code in Icon.cs file
public virtual string ToDataUri(string? size = null, string? color = null)
{
    var svg = ToMarkup(size, color).Value;

    // Attribute xmlns="http://www.w3.org/2000/svg" is required for SVG data URI.
    svg = svg.Contains("http://www.w3.org/2000/svg") ? svg : svg.Replace("<svg ", "<svg xmlns=\"http://www.w3.org/2000/svg\" ");

    var base64Svg = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(svg));
    return $"data:image/svg+xml;base64,{base64Svg}";
}

So, the usage will be
<FluentPersona Name="Bill Gates"
               Status="PresenceStatus.Available"
               StatusSize="PresenceBadgeSize.Small"
               StatusTitle="He is available"
               Image="@(new Icons.Regular.Size48.Person().ToDataUri(color: "white"))"
               ImageSize="50px">
</FluentPersona>

Can you update your PR? Or I can create a new one if you prefer.

What if, in addition to your suggested changes, a RenderFragment named "ImageContent" (or something similar) is provided. This would allow customization of the image without adding any new parameters (except the RenderFragment) or worrying about explaining the priority of parameters.

With a RenderFragment we can't control and/or check if an actual image is being supplied. I rather add some parameters and be 'in control'.

With a RenderFragment we can't control and/or check if an actual image is being supplied. I rather add some parameters and be 'in control'.

So, how should we proceed with this? I guess this feature would be of great use, but I would like to get it done right (and conforming to your library).

I'd say we go with the solution @dvoituron provided (and make it work)

Yes, I think this solution does not (yet) cover all cases, but it does cover a large proportion. The advantage is that it can also be used for other types of problem. We can always think later about additional options to manage the "system" color.

Alright, I've update the code to use @dvoituron's solution. I also tinkered around with how to support custom sizes for icons. The only problem left is that images smaller than the specified ImageSize do not fill up the full image area. Maybe you can come up with a solution to this problem?

@hksalessio can you check the Unit Tests. Some are failing and because of that the pipline that build the code won't run.

We are merging this as-is and then do some checks ourselves on the dev branch


Trying to want to do edit functionality but it is not working

I want when i creating table in lexical so in every cell i want a icon so if i click on that icon so it give me insert row col and delete row col but its not working for me i am stuck in this from a lot of time so can you give me solution

GitHub issues isn't a support channel for this project, see the community section of the website for links to places that are appropriate for asking questions.


Cannot add collateral with Ledger X

Although Ledger works for send/withdraw, I cannot add collateral. The "Confirm" button is greyed out and the "Connect Ledger" button is disabled.
I would expect the "Connect Ledger" to be greyed or not visible (because I am connected) and the "Confirm" button to be active.
Version: 2.2.2

Yeah it's disabled because HW can't interact with plutus. So adding collateral at this point would be unnecessary, that's why I disabled it for now.

Ok, thanks

Hi. I am facing the same issue. Can i check if it will be switched on eventually? i will need it to utilise Sundaeswap. Otherwise, i would have to leave nami unfortunately. =(

Ledger & Trezor need to update their firmware to support Cardano smart contract.
The feature will be added once supported by hardware wallet.

Any news on when Ledger will update their firmware to support Cardano smart contracts?  And once that happens, how long it will take until Nami supports them, too?  Without this feature, many users will not be able to use Nami with Sundaeswap, especially larger liquidity providers who only operate using HW wallets.  @Simonlam999 is there any other option than Nami to use a HW wallet with Sandaeswap?

@grosu No other option if firmware doesn't support cardano smart contract. our only hope lies in Ledger, who appears to be in no hurry. I guess we got to go without ledger support. Scary!

how long it will take until Nami supports them, too?

We could provide support instantly, it's really just a thing on the ledger/trezor software side, where we have no influence on.

So after Ledger eventually add plutus support. Nami wallet setup can also then add import from connected Ledger HW?
I'm coming from staking my ADA from my ledger wallet for the Meld ISPO, and Meld currently only support Nami for interacting/staking Meld.


[WIP] Apply simplify every compose call in QubitMapper.mode_based_mapping

Summary
This workaround can resolve the issue #545.
But it may get slower for other cases because it applies simplify too many times.
Fixes #545
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 82.658%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
8322

Relevant Lines:
10068

💛  - Coveralls

I also made a PoC of performance improvement of SparsePauliOp.simplify for large number of qubits.
I welcome your feedback. https://github.com/Qiskit/qiskit-terra/pull/7656

In the original referenced issue there was a plot of performance - how does that look now with the above change?

I tried Kevin's parity operator and a random operator as follows.
import random
from timeit import timeit

from qiskit_nature.converters.second_quantization import QubitConverter
from qiskit_nature.mappers.second_quantization import JordanWignerMapper, BravyiKitaevMapper
from qiskit_nature.operators.second_quantization import FermionicOp

def random_op(k, n):
    random.seed(123)
    op = sum(
        (
            FermionicOp("".join(random.choices("+-ENI", k=k)), display_format="dense")
            * random.random()
        )
        for _ in range(n)
    )
    return op

def parity_op(n_modes: int) -> FermionicOp:
    op = FermionicOp.one(n_modes)
    for i in range(n_modes):
        op @= FermionicOp.one(n_modes) - 2 * FermionicOp(f"N_{i}", display_format="dense")
    return op

def bench(op):
    mapper = JordanWignerMapper()
    qubit_conv = QubitConverter(mapper)
    print(f"{timeit(lambda: qubit_conv.convert(op), number=1)} sec")

print("random")
op = random_op(12, 100)
bench(op)

print("\nparity")
op = parity_op(10)
bench(op)

main
random
12.206206522 sec

parity
11.337571101000002 sec

this PR
random
0.4637313729999999 sec

parity
0.983379751 sec

I see you put a comment in #560

The technique #549 can perhaps make the qubit mapping even faster. So, I leave it for discussion.

How do the timings you ran above look with 560 applied as well as this change - you have the timings in 560 for that alone, does including this proposed change too make much of a difference where it is worth considering?

I quickly tried this PR + #560. The combination does not look faster. So, I will close this PR when #560 is merged.
this PR + #560
random
0.3882492110000001 sec

parity
0.602769689 sec

only #560
random
0.27690272000000005 sec

parity
0.514391453 sec

Thanks for checking, indeed it does seem to slow it down after #560 adding this


(MAINTENANCE) switch scanner to EBE

small tweaks were made to the exhibitor list display for TEH. I assume the changes will also be visible for EBE, but I prefer to mention it just in case

yes, its the same code base.... i only edit settings/env


[SPARK-46360][PYTHON] Enhance error message debugging with new getMessage API

What changes were proposed in this pull request?
This PR proposes to introduce getMessage to provide a standardized way for users to obtain a concise and clear error message.
Why are the changes needed?
Previously, extracting a simple and informative error message in PySpark was not straightforward. The internal ErrorClassesReader.get_error_message method was often used, but for JVM-originated errors not defined in error_classes.py, obtaining a succinct error message was challenging.
The new getMessage API harmonizes error message retrieval across PySpark, leveraging existing JVM implementations to ensure consistency and clarity in the messages presented to the users.
Does this PR introduce any user-facing change?
Yes, this PR introduces a getMessage for directly accessing simplified error messages in PySpark.

Before: No official API for simplified error messages; excessive details in the error output:
from pyspark.sql.utils import AnalysisException

try:
    spark.sql("""SELECT a""")
except AnalysisException as e:
    str(e)
# "[UNRESOLVED_COLUMN.WITHOUT_SUGGESTION] A column, variable, or function parameter with name `a` cannot be resolved.  SQLSTATE: 42703; line 1 pos 7;\n'Project ['a]\n+- OneRowRelation\n"

After: The getMessage API provides streamlined, user-friendly error messages:
from pyspark.sql.utils import AnalysisException

try:
    spark.sql("""SELECT a""")
except AnalysisException as e:
    e.getMessage()
# '[UNRESOLVED_COLUMN.WITHOUT_SUGGESTION] A column, variable, or function parameter with name `a` cannot be resolved.  SQLSTATE: 42703'

How was this patch tested?
Added UTs.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @garlandz-db FYI

Merged to master.


added Milkman

milkman is an extensible http client, similar to postman, so i believe, it fits into querying section.

Thanks!


accessType : "offline" doesn't return refreshToken

new GoogleStrategy(
    {
        clientId: consumerKey,
        clientSecret: consumerSecret,
        accessType: "offline",
        skipUserProfile: true,
        scope: [
            'https://www.googleapis.com/auth/analytics.edit'
        ],
        callbackURL: "/auth/google/callback"
    },
    function (accessToken, refreshToken, profile, done) {
        console.log('refreshToken', refreshToken);
    }
);

returns refreshToken as undefined. Am I doing something wrong here?

I found out this is not an error caused by passport-google-auth. Apparently the refreshtoken is only issued the first time: stackoverflow. To re-issue it the command prompt has to be forced: approval_prompt=force

Interesting, good to know.


Singularity Container read-only file system error

Hello tbpore team,
Thank you for uploading the new tbpore 0.2.0 container. The new --db option seems to work without issue, however we're still getting this error upon running it:
  File "/usr/local/bin/tbpore", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/tbpore/tbpore.py", line 506, in main
    main_cli()
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/tbpore/tbpore.py", line 258, in process
    tmp, logdir = setup_dirs(outdir, tmp)
  File "/usr/local/lib/python3.9/site-packages/tbpore/tbpore.py", line 110, in setup_dirs
    cache_dir.mkdir(parents=True, exist_ok=True)
  File "/usr/local/lib/python3.9/pathlib.py", line 1323, in mkdir
    self._accessor.mkdir(self, mode)
OSError: [Errno 30] Read-only file system: '/usr/local/lib/python3.9/site-packages/.cache'

That's not a section of the code we would be able to change ourselves, so could you please help us with it?
The command we're using is as follow:
singularity exec -H path_to/tbpore tbpore_0.2.0.sif tbpore process --db data/decontamination_db/tbpore.remove_contam.fa.gz.map-ont.mmi -o sample_example/tbpore_out --cleanup sample_example/mada_1-7.subsampled.fastq.gz
Thanks again for your time and help!

So sorry again @pedrodcb. Once #44 is merged I'll make another new release that will fix this problem.

Okay, version 0.3.0 has just been added to bioconda. You should see a new container in a few hours I guess

Hello @mbhall88, thank you very much for setting up the new container so quickly. We've tried it out and at first ran into this issue:
Error: Invalid value for '-m' / '--metadata': Path '/usr/local/lib/python3.9/site-packages/data/decontamination_db/remove_contam.tsv.gz' does not exist.
Which we fixed by manually downloading the remove_contam.tsv.gz file into the data/decontamination_db folder within our workspace and adapting the command by adding the -m option as follows:
singularity exec -H path_to/tbpore tbpore_0.3.0.sif tbpore process --db data/decontamination_db/tbpore.remove_contam.fa.gz.map-ont.mmi -m data/decontamination_db/remove_contam.tsv.gz -o sample_example/tbpore_out --cleanup sample_example/mada_1-7.subsampled.fastq.gz
However, we now run into the following error, which like the previous ones, we're unable to fix ourselves:
Error calling /usr/local/bin/python3.9 /usr/local/lib/python3.9/site-packages/external_scripts/filter_contamination.py --verbose --ignore-secondary -o sample_example/tbpore_out/.tbpore/mada_1-7.decontaminated.filter -i sample_example/tbpore_out/.tbpore/mada_1-7.decontaminated.sorted.bam -m data/decontamination_db/remove_contam.tsv.gz (return code 2)
Once again thank you for your time and help with this!

I am so sorry for this @pedrodcb. I will fix this today

Alright, I think this will be sorted in v0.3.1. The external_scripts and data directories were being included in the package distribution, but not when pip installs from those distributions. Being more explicit with the files we want included seemed to fix this problem when I tested it locally.
I'll wait until the bioconda container is built and then test that out though.

Okay, I have tested the v0.3.1 container and I've successfully run the example you were trying to run @pedrodcb. I'm bvery sorry, I should have tested it this way in the previous fixes.
Let me know if you run into any other issues. Thanks for you patience.


Put 3-wide vector types on a ketogenic diet.

@mangupta good catch, missed that one. Should be OK now methinks.


Re-generate schemas

Readiness checklist

[ ] I added/updated tests.
[x] I ensured that the PR title is good enough for the changelog.
[x] I labeled the PR.

The rearranging lets it look more severe in https://github.com/nmshd/runtime/pull/307/files#diff-85c87594e414aa5f153c37403b0dbd816f1a4d9773ba4fbe5cb4e988c6488854 than it actually is.

I never want to see such a PR again 😅 WTB a pipeline that prevent from merging when the schema ist noch up2date?


aeproject node runs forever without error if behind firewall that forbids docker pull

how is this resolved?

Hi @thepiwo
There was an error that was not handled properly, and the process did not stop. Now when error occurs, we terminate the process and show the error message. Tested on Linux, Mac and Windows.

Also, a disclaimer for using firewalls was added to the documentation, so the users should grant some permissions to the docker.


Add documentation about formatters and linters to README.dev.md

Description
Update developer documentation with information to run formatter and linter locally.
Related issues:

#32
Blocked by #59

Instructions to review the pull request

Check that CHANGELOG.md has been updated if necessary
Wait for #59 to be merged
Follow instructions in the documentation and see if they are clear enough.

This branch has been updated, it should be possible to follow the commands now.

Thanks for the review :100:⁰


firefox: 32-bit arm tab crash in test image

Tab crashes immediately after opening using 32-bit arm test images. Seems to happen with both ESR and the latest version, at least Scarthgap and Styhead (possibly Kirkstone and Dunfell also).
Interestingly aarch64 is not affected by this...

Well, I have spent a few hours debugging it... but without an awful lot of luck so far.
It is trying to load the fonts from /usr/share/fonts folder, however the syscalls return weird errors for some reason (like openat returns no-network error, on a local FS? fstat returns EPERM, when the file is clearly rwx for the whole world?) - and this makes FF sad.
But it doesn't seem to be related to the rpi layer - it seems to happen to qemuarm too :S


[#399] Pre/Post Playbook Overview UI + API

fixes #399
refactors #467
Additions include:

add Redux APIs for loading playbook names / ServiceTemplateAnsiblePlaybooks
refactor Migration In Progress Cards - consolidate into common components and show the Pre/post playbook messaging in #467 (Running playbook service %s. This might take a few minutes.).

refactors UI logic to look at most recent tasks for a plan.

refactors UI logic to show the playbook messaging when:
A. a single task has a pre migration playbook actively running
B. all disks are finished migrating and we have a post playbook running

question for @vconzola - do we want to change the messaging on the In Progress card when a pre/post playbook fails? Currently you'd see the same messaging (Running playbook service %s. This might take a few minutes. with the error icon in the top left showing count of failures). The user will be able to drill into Plan Details during Pre/Post migration playbook runs. We can update this to reflect a different message if desired, but I did not see anything about this specifically in the UX.
Note: I am still unable to test this fully (backend is not ready), but this code should be much closer to completion...
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564250

BZ:
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564250

@priley86 Thanks so much for your help here. I'll review your additions shortly, probably tomorrow, this evening if I have time

@AllenBW @michaelkro I am planning on merging this today right after https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/413 and https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/442
@AllenBW Would it be OK if your feedback is addressed in a follow-up PR?

@AparnaKarve goodness yes! lets get this merged asap, I'll start addressing the feedback in another pr, thanks for asking! <3

Thanks @AllenBW

@priley86 There are lots of conflicts backporting this to Gaprindashvili. Can you create a separate PR?
Changes to be committed:

	modified:   app/javascript/components/index.js
	new file:   app/javascript/data/models/playbooks.js
	modified:   app/javascript/react/screens/App/Overview/OverviewConstants.js
	modified:   app/javascript/react/screens/App/Overview/__test__/Overview.test.js
	modified:   app/javascript/react/screens/App/Overview/__test__/__snapshots__/index.test.js.snap
	modified:   app/javascript/react/screens/App/Overview/components/AggregateCards/ActiveTransformationPlans/ActiveTransformationPlans.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressCard.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressWithDetailCard.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/Migrations.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCards.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/helpers/getPlaybookName.js
	modified:   app/javascript/react/screens/App/Overview/overview.fixtures.js

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   app/javascript/data/models/plans.js
	both modified:   app/javascript/react/screens/App/Overview/Overview.js
	both modified:   app/javascript/react/screens/App/Overview/OverviewActions.js
	both modified:   app/javascript/react/screens/App/Overview/OverviewReducer.js
	deleted by us:   app/javascript/react/screens/App/Overview/OverviewValidators.js
	both modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCard.js

@AparnaKarve can you take a look at this?

@simaishi Can you try backporting #413 and #442 first?
Since this PR and the above 2 are related.

I had a chat with @fdupont-redhat this morning regarding https://bugzilla.redhat.com/show_bug.cgi?id=1564250 and those 2 PRs didn't come up...
Are both PRs for the same BZ? I can't tell because PRs don't reference BZs and the BZ doesn't list those PRs either...  and 1 PR even had bugzilla needed label.

@simaishi I have specified the same BZ used here in both those PRs - so yes, this PR + the other 2 for the same BZ.

@AparnaKarve OK. Please add those PRs to the BZ as well.

@AparnaKarve https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/413  and https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/442 are backprted, but there are still conflicts:

Changes to be committed:

	modified:   app/javascript/components/index.js
	new file:   app/javascript/data/models/playbooks.js
	modified:   app/javascript/react/screens/App/Overview/OverviewConstants.js
	modified:   app/javascript/react/screens/App/Overview/__test__/Overview.test.js
	modified:   app/javascript/react/screens/App/Overview/__test__/__snapshots__/index.test.js.snap
	modified:   app/javascript/react/screens/App/Overview/components/AggregateCards/ActiveTransformationPlans/ActiveTransformationPlans.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressCard.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressWithDetailCard.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/Migrations.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCard.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCards.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/helpers/getPlaybookName.js
	modified:   app/javascript/react/screens/App/Overview/overview.fixtures.js

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   app/javascript/data/models/plans.js
	both modified:   app/javascript/react/screens/App/Overview/Overview.js
	both modified:   app/javascript/react/screens/App/Overview/OverviewActions.js
	both modified:   app/javascript/react/screens/App/Overview/OverviewReducer.js
	deleted by us:   app/javascript/react/screens/App/Overview/OverviewValidators.js

A Gaprindashvili-specific PR for this can be created after #401 is backported.

https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/401 is backported and this still conflicts...
Changes to be committed:

	modified:   app/javascript/components/index.js
	new file:   app/javascript/data/models/playbooks.js
	modified:   app/javascript/react/screens/App/Overview/Overview.js
	modified:   app/javascript/react/screens/App/Overview/OverviewActions.js
	modified:   app/javascript/react/screens/App/Overview/OverviewConstants.js
	modified:   app/javascript/react/screens/App/Overview/__test__/Overview.test.js
	modified:   app/javascript/react/screens/App/Overview/__test__/__snapshots__/index.test.js.snap
	modified:   app/javascript/react/screens/App/Overview/components/AggregateCards/ActiveTransformationPlans/ActiveTransformationPlans.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressCard.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/InProgressWithDetailCard.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/Migrations.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCard.js
	modified:   app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCards.js
	new file:   app/javascript/react/screens/App/Overview/components/Migrations/helpers/getPlaybookName.js
	modified:   app/javascript/react/screens/App/Overview/overview.fixtures.js

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   app/javascript/data/models/plans.js
	both modified:   app/javascript/react/screens/App/Overview/OverviewReducer.js
	deleted by us:   app/javascript/react/screens/App/Overview/OverviewValidators.js

Backported to Gaprindashvili via https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/527


Fix the scalapb json marshaller for sealed-oneof messages

When returning a scalapb message of the sealed-oneof flavour (see https://scalapb.github.io/docs/sealed-oneofs) the JSON marshaller does not marshal the wrapping message.
This changeset corrects that by detecting the case where the value passed in is a GeneratedSealedOneof and then marshalls the container message.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@andrew-teirney Gentle ping


Jesse: Watch revaalolabs.com

Jesse requests the watch of the watch_keyword revaalolabs\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

revaalolabs\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


scx-git: init; scx: remove

:fish: What?

Remove scx to prevent conflicts.
Override the scx packages of Nixpkgs to provide a git version here

:fishing_pole_and_fish: Why?
Scx is now available on Nixpkgs (stable version). So it makes sense to replace with the git version here.
:fish_cake: Pending

[x] Override the rust packages
[x] Cook an update script for this, referencing nixpkgs, or modify the existing one.
[ ] Publishing to news' channel.

After this is done, we will need to announce to the users asking to change their packages to scx_git.full. If they want to use the nixpkgs version, they should switch to scx.full.
:whale: Extras
I will recommend merging this after these PR reach unstable.

https://nixpk.gs/pr-tracker.html?pr=352077 - rusty init
https://nixpk.gs/pr-tracker.html?pr=352811 - csheds -> cscheds

❯  nix build .#scx_git.full .#scx_git.rustland .#scx_git.bpfland .#scx_git.cscheds .#scx_git.lavd .#scx_git.layered .#scx_git.rlfifo --print-out-paths

/nix/store/ld2yx48yviiz0lpqac991l7xnsnmfgha-scx_full-unstable-20241101144355-9bba51a
/nix/store/xc9w481g4li7fwkyj317acgr462xfkdq-scx_rustland-unstable-20241101144355-9bba51a
/nix/store/xx68snlgqrspb3j298wc2hsqz3gkwkhx-scx_bpfland-unstable-20241101144355-9bba51a
/nix/store/q4l2qpd1nfyizhds9ax19805s85h2q0r-scx_csheds-unstable-20241101144355-9bba51a
/nix/store/ybs3n39sl9bw7swv7kg5nfp79kfvfg3k-scx_lavd-unstable-20241101144355-9bba51a
/nix/store/0lry6f5kknh16rfjmfbsgrbvdk522fp6-scx_layered-unstable-20241101144355-9bba51a
/nix/store/c1yqi50485ga1lj1in6gv06cy8jvxprm-scx_rlfifo-unstable-20241101144355-9bba51a

Everything above builds at the moment, and technically this is ready for merging. But I would like to wait until some merged PRs on Nixpkgs is available on unstable.

Work is pretty much done ^^ except for the above changes which depend on nixpkgs bump.

If this does not work I am done with fixing the CI.
I have no clue where the problem lies my gosh.

@PedroHLC can we get this reviewed :)

Hello maintainers, just a reminder to inform users about updating their configurations to use scx_git.full instead of the default pkgs.scx. It's also recommended to set a correct default value that aligns with scx_git.full, as the previous default (pkgs.scx) may lead to unexpected issues.

It's also recommended to set a correct default value that aligns with scx_git.full

Yup, PRs welcomed.
We need to change https://github.com/chaotic-cx/nyx/blob/09f0dcfa6a8932850f2291717a271598d3098aad/modules/nixos/scx.nix#L14 to
https://github.com/NixOS/nixpkgs/blob/1f6ff249fe86a678965436f4d3c9c4a7e5601562/nixos/modules/services/scheduling/scx.nix#L23-L36
And we can remove the module entirely from here once the upstream PR is merged.


Update campaigns.types.ts

Fix Incorrect Typings #42

Thanks for contributing @olawalejuwonm 👏

My pleasure. Would be glad to join the team to make further contributions

For open positions keep an eye on https://www.mailerlite.com/jobs

Thank you
On Tue, Feb 6, 2024 at 3:04 AM Mantas Andriukevičius <
@.***> wrote:

For open positions keep an eye on https://www.mailerlite.com/jobs
—
Reply to this email directly, view it on GitHub
https://github.com/mailerlite/mailerlite-nodejs/pull/43#issuecomment-1928648916,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSQ2BC5AMPIJGJ3VQNNKI3YSGFSBAVCNFSM6AAAAABCIV33ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYGY2DQOJRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Preserve service binding order when building routers

Motivation:
Annotated services are lazily bond to VirtualHost to apply AnnotatedServiceExtensions to them. #2316
It causes a change in the order of original service binding defined by the user.
This is critical if a user uses a global fallback service.
In the following example, the user added the fallback service in the last.
However, the fallback will be added first and annotated services will be added later.
sb.annotatedService("/api/v0/", new Object() {
    @Get("regex:/projects/(?<projectName>[^/]+)")
     ...
});
sb.annotatedService("/api/v0/", new Object() {
    @Get("/users/me")
    ...
});
sb.serviceUnder("/", (ctx, req) -> HttpResponse.of("fallback"));

Modifications:

Make ServiceConfigBuilder implement ServiceConfigSetters
Remove unused getters in ServiceConfigBuilder
Merge addAnnotatedServiceBindingBuilder and  addServiceConfigBuilder into addServiceConfigSetters
Remove annotatedServiceBindingBuilders and delegate it to virtualHostTemplate

Result:
Fix regression in service bindings.

Nice Job!!
Sorry for making me confused. 😅

Sorry for making me confused. 😅

Don't worry. We are always welcome your contribution! ♥


[Clarify]Again: what does DefaultSessionKeystore have to do with anything?

          Again: what does DefaultSessionKeystore have to do with anything?

What we should perhaps be asserting is that we are using RawKeySessionKeystore as our keystore....
Originally posted by @bzbarsky-apple in https://github.com/project-chip/connectedhomeip/pull/30863#discussion_r1420876529

Not relevant after the updates to https://github.com/project-chip/connectedhomeip/pull/30863


[Task] Implementation of a "gacha" system

Task Description
This gacha system is global, which means it's not controlled by the server. Ofc servers can create their local items to add, which will only globally affect it. But the idea is that these gacha items contains powerups or rare items. Which means that I pay a flat fee of 10 petals in order to get a chance of getting a 50% boost powerup on petals. And once you get it, it's stored into your inv. The more times you try, the more you increase your luck on getting the legendary item, and then from there, you can either save it or use it. they will expire tho.
You can pay more in order to increase your chances. it's just a counter that builds up

This wont be added for v0. probably during v1 at the very least


add option for not translating

Great idea, i can approve of this. There is only 1 thing to change, the CBLangTo state should be readonly to prevent user from typing into it

Thanks for the help and contribution


get out of memory error

Hi, I have changed batch_size to 1, when I run "python train.py -c config.json", I still got error below.

GPU:

Can you help me or give some advices?

try decreasing the segment length in the config

decrease batch size first 3to 2 or 1

@belevtsoff  it works, thanks


[QUESTION]: esbuild minify standalone build

Hi, I was using vite-plugin-standalone, and you had exposed the esbuild options so that we could pass additional configurations for the server build, in my case it was the minify option.
I know that your reasoning was the minification would make debugging difficult if it was set true by default.
I was wondering if it would be possible to give us the option to pass these configurations for the standalone build?
If not, I understand, thanks!
Great package by the way, in my previous setup I was using vavite and the plugin in order to achieve what this fixes in a single package, really great.

What's your motivation to minify server code?

What's your motivation to minify server code?

In my case it greatly reduces the bundle size for publication. For example, in a small test project we saw it go from 17mb without server minification to 10 mb with minification and this was before zipping. (We use zip to publish with Azure).


Unable to send text in message box

I can select the model (using horde currently, but had same issue with a local model) and type a message, but when I press enter/click the send button for the first time this error outputs in the browser console:
Uncaught (in promise) TypeError: Characters.id[Characters.selectedID] is undefined
    Generate http://<IP_ADDRESS>:8000/script.js:1182
    <anonymous> http://<IP_ADDRESS>:8000/script.js:2348
    jQuery 2
script.js:1182:9
    Generate http://<IP_ADDRESS>:8000/script.js:1910
    <anonymous> http://<IP_ADDRESS>:8000/script.js:2348
    jQuery 2

and nothing is sent

I ran into this, too. Just go to the character menu in the upper right and choose a character on first load before typing anything.

Fixed in https://github.com/TavernAI/TavernAI/commit/78715b03181b22626cbc1bd4fa9a388d2c7d3343


[BUG] sh stop-all.sh,  the master service is not killed

sh stop-all.sh
Check the master service，the master service is not killed

Which version of Dolphin Scheduler:
-[dev]

I think the startup script dolphinscheduler-daemon.sh ,
these two lines :
    nohup $JAVA_HOME/bin/java $exec_command > $log 2>&1 &
    echo $! > $pid

It may be that the pid is not written into the pid file

if you want to submit a PR for this issue, please leave a message, welcome to fix this problem

I will  fix it


making stepper vertical?

Is there any way to make the stepper vertical?  I would like the same design & functionality except as a table
Phase 0.   |. do stuff in phase 0
Phase 1    | do stuff in phase 1
Phase 2 | do stuff in phase 2

You mean something like this

Yes!
Nimble Books LLC
The AI Lab for Book-Lovers http://NimbleBooks.com
On Sun, Nov 14, 2021 at 12:22 AM Mohamed Abdou @.***>
wrote:

You mean something like this
https://mui.com/components/steppers/#vertical-stepper
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Mohamed-512/Extra-Streamlit-Components/issues/14#issuecomment-968209172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI4TSY5VWE24YOREM47WO3UL5BSHANCNFSM5H6IRUQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You can upgrade to 0.1.53 now!
Try it out this way:
st.write("# Stepper Bar")
c1, c2, c3 = st.columns([1, 3, 1])
with c1:
    st.write("Horizontal")
with c2:
    is_vertical = (st.slider("Orientation", min_value=0, max_value=1, value=0) or 0) == 1
with c3:
    st.write("Vertical")

if is_vertical:
    c1, c2 = st.columns([1, 3])
    with c1:
        val = stx.stepper_bar(steps=["Ready", "Get Set", "Go"], is_vertical=is_vertical)
    with c2:
        st.info(f"Phase #{val}")
else:
    val = stx.stepper_bar(steps=["Ready", "Get Set", "Go"], is_vertical=is_vertical)

    st.info(f"Phase #{val}")


Create test.md

Trying to get CI to run just to see what happens

what's going on? :roll_eyes:

Yeah I was wondering the same thing 👀

I looked at this for a bit. Maybe it's travis still blocking this somehow. It is enabled on the organization level. @christianbundy do you have any idea what is going on here?

My only hunch: Maybe node.js.yml isn't a valid workflow name? I'd use node.yml or main.yml or something without the extra suffix. The tests should've run in #65 though.

Testing something, I've tried disabling travis to see if that changes anything. The filename should work, it works in the other repos we have in ssb-ngi-pointer.

Ohhhhhhhhhhhhhh yes :-)

OMG, I thought this was going to be simple ;)

Looks painful :D

And yeah, that master and main thing, ouch

Yeah, almost there but now I'm out of mana

So, turns out there's no node 8.x in GH actions? I guess that's not a big deal as node 8 isn't anymore supported officially.

Closed in favor of #67


uv_barrier_wait does not always drain waiting threads

Rapid calls of uv_barrier_wait with the same barrier can deadlock a process if not all threads have resumed before uv_barrier_wait is called on a just released thread as in becomes non zero.   This does not appear to be an issue with the pthead_barrier_wait based Linux implementation.

Version: 1.44.2
Platform: Darwin ant-6773.local 20.6.0 Darwin Kernel Version 20.6.0: Sun Nov  6 23:16:58 PST 2022; root:xnu-7195.141.46~1/RELEASE_ARM64_T8101 arm64

I'm not 100% sure I follow your explanation. What do you mean by "a just released thread"?
Can you perhaps post sample code that shows the hang?

Call uv_barrier_wait multiple times on the same barrier.  We where doing this is BIND where we where using the same barrier to start and stop the listeners.  The mock code in the unit tests just called uv_barrier_wait fast enough on the error path to trigger deadlock.  The issue shows the unit test deadlocked and the uv_barrier state when this happens.  We have worked around the issue by using multiple barrier structures.  https://gitlab.isc.org/isc-projects/bind9/-/issues/3770
The fix should be easy.  Add a new unsigned integer structure element gen.  Initialise it to any value (0 is a good choice).
capture that value when you enter the lock. Increment the value when you release the lock.  Wait for the value to change before releasing the other threads.
  unsigned int gen;
  ...
  uv_mutex_lock(&b->mutex);

  gen = b->gen;                                                  <<<<

  if (++b->in == b->threshold) {
    b->in = 0;
    b->out = b->threshold;
    b->gen++;                                                      <<<<
    uv_cond_signal(&b->cond);
  } else {
    do
      uv_cond_wait(&b->cond, &b->mutex);
    while (b->gen == gen);                                 <<<<
  }
  ...

uv_barrier_wait(&barrier);
uv_barrier_wait(&barrier);

Okay, after seeing https://gitlab.isc.org/isc-projects/bind9/-/commit/7a677e45d1d074bcb02e7b7b6abaf49058e1e3ec I think I understand what you mean.
Correct me if I'm wrong but you were calling uv_barrier_destroy() when other threads were still blocked on it, right? E.g., something closer to this:
uv_barrier_wait(&b);
// ...
uv_barrier_destroy(&b);

Than this:
if (uv_barrier_wait(&b)) // if last waiter
  uv_barrier_destroy(&b);

If I understand correctly, the question is whether this code runs correctly on multiple threads:
uv_barrier_wait(&b);
if (uv_barrier_wait(&b)) // if last waiter
  uv_barrier_destroy(&b);

I realize the if (uv_barrier_wait(b)) uv_barrier_destroy(b); pattern we recommend in our docs is defective.
POSIX says this:

[..] shall return PTHREAD_BARRIER_SERIAL_THREAD for a single (arbitrary) thread synchronized at the barrier and zero for each of the other threads

Note it doesn't say "last thread". When you run libuv's barrier_serial_thread test (which uses that pattern) on linux+glibc, ThreadSanitizer in fact complains about a data race in pthread_barrier_wait() vis-a-vis pthread_barrier_destroy().
Our fallback code is actually a bit better in that respect because it only returns the magic "you're the last one" value to the final waiter (no tsan complaints); we probably ought to move away from the libc implementation.

Assume all threads are executing that same code block, so it should exit the first barrier

Not sure I follow what you're saying. Let me explain what I mean:
if (pthread_barrier_wait(b)) pthread_barrier_destroy(b); // thread A
if (pthread_barrier_wait(b)) pthread_barrier_destroy(b); // thread B

Thread A can wake up and proceed to call pthread_barrier_destroy() while thread B is still sleeping in pthread_barrier_wait().
As a quality-of-implementation issue both glibc and musl seem to deal with that by blocking in pthread_barrier_destroy() until the other waiters are gone but POSIX doesn't mandate. It's in fact UB:

The results are undefined if pthread_barrier_destroy() is called when any thread is blocked on the barrier

glibc has a real (if seemingly benign) data race caused by an unsynchronized read of the barrier's count field. Our homegrown barrier has none of these issues.
Anyway, that's something of a digression. The original bug report still needs clarification from @marka63.

This is supposed to work, according to POSIX, but OP may be saying it is broken in our implementation (and instead deadlock in the second wait).
barrier_wait(b); barrier_wait(b); // thread A
barrier_wait(b); barrier_wait(b); // thread B

with barrier_init(2)

Configure a barrier to wait for  n threads where n > number of cores available.  This is to make it highly probable that a deadlock will occur with the old implementation.   Run n threads with just the 2 uv_barrier_wait calls being executed in each thread. The process should lock up. If you add sleep(1); between the calls it should succeed as you introduce enough delay for all the threads to have been released before the next round of waits start.
The fixed code should succeed  with or without the sleep.

I can't find anything in POSIX that mandates that behavior. On the other hand, I can't find anything to the contrary either.
We can implement it in libuv's fallback and it'd probably even simplify the implementation a little (don't have to malloc state anymore, can stack-allocate it in uv_barrier_wait()) but if POSIX leaves the behavior open, that means libuv's pthread wrapper isn't portable.

Thoughts anyone? My current thinking is to switch to libuv's own barrier on all platforms so we can make stronger guarantees about what it does and doesn't do. It might be a little slower but I doubt it's going to be very noticeable or that anyone cares.

Seems fine to me to use our own. But does seem to be mandated by posix to me:
https://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_barrier_wait.html

At this point, the barrier shall be reset to the state it had as a result of the most recent pthread_barrier_init() function that referenced it.


Adding support of UTF8 file name processing in mio on windows

Contributing back changes from app.

@mandreyel

Thank you very much!


Passes sums of residential_units (by zone) to other LoadData methods.

Calculates residential_units from mar table.
Records sums in zone_facts table.
Removes zone_housingunits... row from manifest.csv.
Marks cama.py as deprecated.
Removes unused _add_building_permits_rate().

@pfjel7 you're right that the _populate_zone_facts method is a bit confusing, and I see why you separated this out. For some background, this code was originally in the api itself and would calculate summary statistics on the fly based on user input of zone type and desired field. So a lot of this code is not well designed for its current use. Overall it would be good to refactor it to be cleaner considering the current purpose of populating the table.
I actually recommend a slight modification to your approach. I would suggest putting all the code that fills in the residential_units into _populate_zone_facts, but put it above the for field in summarize_obs_fieldloop. You can leave the separate_get_residential_units()function where it is, but call it as the first line of_populate..` rather than passing the residential units as an argument to populate. That way you don't need to force-fit the residential units into the for loop. The for loop is for applying weighting factors and doing normalization, but residential units don't need this since you get everything you need from the _get_residential_units method directly. This also makes sure that the residential units is run before the code that depends on it (building permits).
I'm merging this in now and I think it is fine to leave this as is, especially considering we should really refactor the whole thing to be cleaner - but that should happen after the launch since it's just paying down our tech debt not getting us a better working tool for launch day. If you think it would be easier to do a quick version of the refactor now while it's fresh in your mind, go for it.