GCE Cloud Provider: Ingress support for security policy

Feature Description

One-line feature description (can be used as a release note): Ingress support for security feature (i.e. firewall) from Google Cloud Provider.
Primary contact (assignee): @mrhohn
Responsible SIGs: sig-network
Design proposal link (community repo): TBD
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bowei @nicksardo
Approver (likely from SIG/area to which feature belongs): @thockin
Feature target (which target equals to which milestone):

Alpha release target (1.8)
Beta release target (1.9)
Stable release target (1.10)

/assign
/sig network
cc @mdelio

@MrHohn - any related issues created on the k8s repo ?

@yastij There isn't yet. A relevant discussion is on https://github.com/kubernetes/ingress/issues/243.

@MrHohn @kubernetes/sig-network-feature-requests can you confirm that this feature targets 1.8?
If yes, please, update the features tracking spreadsheet with the feature data, otherwise, let's remove this item from 1.8 milestone.
Thanks

@idvoretskyi This feature doesn't target 1.8 anymore, could you remove it from 1.8 milestone? Thanks.

@MrHohn thanks

@MrHohn @kubernetes/sig-network-feature-requests will this feature target 1.9?

@idvoretskyi Thanks for checking. No, this feature is not targeting 1.9.

@MrHohn @kubernetes/sig-gcp-feature-requests
Any plans for this in 1.11?
If so, can you please ensure the feature is up-to-date with the appropriate:

Description
Milestone
Assignee(s)
Labels:

stage/{alpha,beta,stable}
sig/*
kind/feature

cc @idvoretskyi

This feature issue is somehow obselete. Closing for now.


Bug: generated routes on windows are incorrectly escaped (404)

On windows the routes generated in page functions don't appear to be escaped correctly when compiling:
npx @cloudflare/pages-functions-compiler build functions\

Outputs:
    {
      routePath: "/api\code",
      methods: ["POST"],
      middlewares: [],
      modules: [__api_code_ts_onRequestPost],
    },

which should actually be
/api/code or else it simply results in 404's. This happens for all nested routes.
As a temporary fix, I did this:
node_modules\@cloudflare\pages-function-compiler-bin\plinko.js@5238
Added the line below the others:
routePath = routePath.replace(/\\/g, '/');
and now the routes generate correctly.
I apologize if this is on the wrong repo, there seems to be a lot of wranglers (alpha, beta, wrangler2, but cloudflare blog references only wrangler@beta) and it took so long to fix this bug I find myself a bit lost in it all.

The problem also occurs when using the wrangler pages dev command.

Indeed a string replacement at this point would work. But I think a better solution, across the whole project, is to convert all paths to posix ones (and use the posix path functions from Node.js).


adding a new Groovy file does not make the class's methods available to Nextflow

I tried adding a new Groovy file with a new class here https://github.com/stevekm/nf-niceutils/blob/main/src/main/groovy/com/nextflow/plugin/MyExtension.groovy
However even after getting it to build, the method included reverseString is not include'able inside the actual Nextflow script. I noticed that in the $HOME/.nextflow/plugins dir, I can see the file for MyExtension.class listed under the plugin dir, however none of its methods have class files of their own. Cannot figure out why or how to get newly added Groovy class files to be available from within Nextflow
@jagedn any ideas?

I think you can't have more than 1 ExtensionPoint in your plugin
nextflow.exception.AbortOperationException: Plugin 'nf-niceutils' implements more than one extension point: MyExtension,ExampleFunctions 	at app//nextflow.plugin.extension.PluginExtensionProvider.loadPluginExtensionMethods(PluginExtensionProvider.groovy:118) 	at app//nextflow.script.IncludeDef.loadPlugin0(IncludeDef.groovy:221)

if I want to add a whole bunch of functions, operators, observers, etc., does this mean it all needs to be attached to a single Class?
I am not clear what the relationship is between the .groovy files, the Classes in those files, and the extension points (or where the extension points are defined...)


Volume controll is not working linear

Dear Maintainer,
first of all many thanks for that amazing tool!
I noticed that volume level that is passed from Spotify to Alsa thru spotify-connect-web is somehow converted. Unfortunately that conversion is not linear, but exponential (pic rel).
Is there a chance to have 1:1 conversion? I mean 50% in Spotify is equal 50% in alsa(mixer)?
My environment:
Raspberry Pi 2
OS: OSMC (Debian based)
Spotify-connect-web release 0.0.3

I can confirm this issue. I have got the same problem on my Raspberry Pi 3 with OSMC

Try to start spotify-connect-web.sh with --dbrange 25
this should help

@flori4n is there a systematic way to compute dbrange?

@awiouy Sorry not that I know. I'll try different --dbrange and see witch one suit best for me.

@flori4n many thanks for that hint - now volume control works as I want

See #22, this is a hardware issue unfortunately. It's because devices report a larger volume range than they can actually handle

I'm gonna close this for now, feel free to re-open if you're still having problems

It seems I'm having this issue as well.. Im using a IQaudio DAC, and my volume doesn't scale properly (below 50% i hear nothing, so my range is 50-100%). As I'm not that technical, what should I do to fix this?


[Help] Tony Hawk's Pro Skater 1+2 not working

I already tried with patches: https://github.com/exelix11/dvr-patches but game doesn't work/isn't compatible. If someone would be able to fix the issue. I love this game :/

This is confirmed working for me with FW 15.0.0, Atmosphere 1.5.2, SysDVR 5.5 and this version of patches.
Make sure you're installing the right patches for your firmware and reboot after installing them. Also try running supported games to rule out a problem with SysDVR.

Thank you for the update, this is probably an user issue then

I just checked it after updating to 16.0.0, getting the newest patches and it works! I really, really have no idea why it didn't work before (on 15.0.1), because I did everything right. Anyway, THANK YOU for letting me now, I can play it now wirelessly on a big screen!!!


'image has no src or srcset attribute (line 0)' for categories

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar question on existing issues (including closed ones).
[x] I searched the Internet for related problems, but still couldn't solve it.
[x] My question is based on the latest code of master branch.

Description

I've recently rebased your repo, ran the blog locally, but on GitHub CI/CD I get:
Run bash tools/test.sh
Running ["ScriptCheck", "LinkCheck", "ImageCheck", "HtmlCheck"] on ["_site"] on *.html...

- _site/blog/404.html
Ran on 45 files!
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/blogging/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/dc/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/dmv/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/jekyll/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/life/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/categories/vulnhub/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/dc1-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/dc3-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/dc4-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/dmv1-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/how-to-create-your-own-blog-using-jekyll-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/is-this-blog-dead-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/posts/why-you-should-start-your-own-blog-en/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tabs/about/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tabs/archives/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tabs/categories/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tabs/tags/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/beginner/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/blog/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/cms/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/crontabs/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/free/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/growth/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/hydra/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/jekyll/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/john-the-ripper/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/joomla/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/kernel-exploit/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/nginx/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/plans/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/python-requests/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/reverse-shell/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/sql-injection/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/sudoers/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/tee/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/waf-bypassing/index.html
  *  image has no src or srcset attribute (line 0)
- _site/blog/tags/wfuzz/index.html
  *  image has no src or srcset attribute (line 0)

HTML-Proofer found 39 failures!

Error: Process completed with exit code 1.

I have to add, that I'm setting it as a project site.
I've also had issues with setting up an avatar. I've set attribute
avatar: assets/img/avatar.jpg

Which is where my avatar is placed. Though again, on GitHub actions this image cannot be found.
EDIT: I see that locally the tags are placed in _site/tags directory, when on CI/CD it's  trying to see these tags in _site/blog/tags
But I also see that the problem is still the same even without baseUrl.
 - _site/tags/wfuzz/index.html
  *  image has no src or srcset attribute (line 0)

Maybe you can consider naming a specific issue title: because at first glance, it looks like spam.
This problem is caused by incorrect generation of the avatar url when site.baseurl exists.

Maybe you can consider naming a specific issue title: because at first glance, it looks like spam.
This problem is caused by incorrect generation of the avatar url when site.baseurl exists.

Thank you cotes, it seems you're in good mood as always ;_;
For me, it seems logical to name an issue by an error message, as in the end, this is what a user ends up searching

Thank you cotes, it seems you're in good mood as always ;_;
For me, it seems logical to name an issue by an error message, as in the end, this is what a user ends up searching


Fix build on OS X 10.11 with Ruby 2.3

I tried installing nio4r on OS X 10.11 today and got the following compilation error:
../../../../ext/nio4r/../libev/ev.c:3737:9: error: implicit declaration of function 'rb_thread_call_without_gvl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

The problem seems to be that rb_thread_call_without_gvl is declared in ruby/thread.h, while the patched libev bundled with nio4r only includes ruby.h. This pull request adds the missing include, which allowed me to install nio4r successfully.

I develop nio4r on OS X and do not have this problem. I'm presently running 10.11.6, and Ruby 2.3.1.
I'm not opposed to this change (it looks like it's correct), but I'm confused why it's working for me and not for you. Different CFLAGS?

It seems to be a question of the Ruby used. I saw this problem with Ruby installed with Homebrew, but not on Ruby installed with RVM.


Gem version bump?

I noticed the teaspoon gem version was bumped to 0.8.0... could we also bump this version as explained in readme.md?

I'm not interested in this any more, so I'm closing the issue.


Added new features + fixes

Added new sound object to play sound effects / music (see specific commit for documentation) #13
removed .idea from the .gitignore file
Added Initial Width / length to global.py
fixed full screen (full screen is now actually full screen) where i used the module "screeninfo" (multi platform). Added this module to requirements.txt and setup.py too
Fixed Physics.py, You didnt have the ability to change the radius because of wrong use of arguments.
changed Simulation steps from 3 to 10. The results in some cases where very different (3 being far less realistic) and sometimes objects that needed to fall over didnt. Also tested it and increasing it to 10 didnt make a significant difference in performance (no noticeable drop)

You seem to have broken the physics tests?

In order for your PR to be merged, you first need to update your PR with the base branch


Namespace change

This PR changes the namespace from postgrest_py to postgrest.
Other changes:

Separate constants into their own file
Pass headers/params down the builders, instead of adding them directly to the session
Add more documentation/examples

If we make a release now, I think it should be v0.11.0


Spit long rows

What do you guys think about calling split_long_rows in the test driver (with the local option)? This should make doctests more reproducible and it complements nicely the "whitespace compression" feature.

I didn't know about this.  Sounds like a good idea to me.
Longer term: ideally one could call that with an optional value of chars, overriding the terminal width.  Then we could decide on a value (e.g., 72 chars? some PEP has a suggested width for docstrings) and the test results would no longer depend on the current physical terminal width...  But this would require upstream Octave changes.

I feel that it might be more intuitive to switch off the option completely (in which case the test results will also not depend on the current physical terminal width).
My reasoning is the following: At least in my case, doctests typically arise either from (1) me typing the expected result in the text editor (TDD-style) or (2) from copy & pasting code from the Octave prompt.
In the first case, it's a bit cumbersome if one has to manually imitate the column splitting behavior by hand, while in the second case the width of the physical terminal being used is usually >> 72 and so no wrapping will occur for sane test cases; this would again lead to manual action.
PS: I don't know how to programmatically change the output width in Matlab.

I feel that it might be more intuitive to switch off the option
completely (in which case the test results will also not depend on
the current physical terminal width).

Yes, maybe.  E.g., I've recently had my CI fail on another because
Travis CI ran with a narrower (virtual) terminal.

Yeah, I had the same experience (even between interactive doctest runs from the Octave prompt vs. non-interactive runs from make test).


[oneDNN v3.x]: Added support for batchnorm fwd and bwd for fp32 and bf16

This PR adds support for oneDNN v3.x in batchnorm fwd and bwd for fp32 and bf16.
This PR passes all unit tests related to batchnorm fwd and bwd for fp32/bf16 when oneDNN v3.x is enabled.
This PR does not add or affect Eigen ops and is specific only to oneDNN kernels.
For additional comments related to oneDNN v3.x integration, please refer to this comment.

Hi @penpornk Can you please review this PR ? Thank you!

Hi @penpornk Can you please review this PR ? Thank you!

@penpornk I have addressed your review comments. Please take a look. Thanks.


make alt dimension change possible

due to this ASPEN processing problem (#67), we decided to make gpsalt the alititude dimension in our dataset in order to be able to also use sondes with partial data. This is the functionality to make this possible with the correct entries in the config file.
Edit: also added a documentation entry on how to do that with the config.

Thanks! I think I fixed it. But it should be (sonde_id, gpsalt) not time in interim level 3.


Obsolete use of loosebidict/looseorderedbidict

bidict-0.14.0 (released on 2017-11-20), removed "loosebidict".
From the changelog (https://media.readthedocs.org/pdf/bidict/master/bidict.pdf) :

loosebidict and looseorderedbidict have been removed. Simple recipes to implement them yourself are now given in OverwritingBidict Recipe.

And I cannot actually use onedrived:

$ onedrived
Traceback (most recent call last):
File "/home/debian/.local/bin/onedrived", line 11, in
load_entry_point('onedrived==2.0.0', 'console_scripts', 'onedrived')()
File "/home/debian/.local/lib/python3.5/site-packages/pkg_resources/init.py", line 572, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/debian/.local/lib/python3.5/site-packages/pkg_resources/init.py", line 2749, in load_entry_point
return ep.load()
File "/home/debian/.local/lib/python3.5/site-packages/pkg_resources/init.py", line 2402, in load
return self.resolve()
File "/home/debian/.local/lib/python3.5/site-packages/pkg_resources/init.py", line 2408, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/home/debian/.local/lib/python3.5/site-packages/onedrived/od_main.py", line 22, in
from .od_watcher import LocalRepositoryWatcher
File "/home/debian/.local/lib/python3.5/site-packages/onedrived/od_watcher.py", line 6, in
from bidict import loosebidict
ImportError: cannot import name 'loosebidict'

Are you planning to update your software or should we install an old bidict version?
Thanks

I'm getting the same error by now. Worked flawless before.

Hi, I just installed onedrived on Ubuntu 17.10. All went fine but launching "onedrived start --debug", I got the same error:
$ onedrived start --debug Traceback (most recent call last):   File "/usr/local/bin/onedrived", line 11, in <module>     load_entry_point('onedrived==2.0.0', 'console_scripts', 'onedrived')()   File "/usr/local/lib/python3.6/dist-packages/pkg_resources/__init__.py", line 572, in load_entry_point     return get_distribution(dist).load_entry_point(group, name)   File "/usr/local/lib/python3.6/dist-packages/pkg_resources/__init__.py", line 2752, in load_entry_point     return ep.load()   File "/usr/local/lib/python3.6/dist-packages/pkg_resources/__init__.py", line 2405, in load     return self.resolve()   File "/usr/local/lib/python3.6/dist-packages/pkg_resources/__init__.py", line 2411, in resolve     module = __import__(self.module_name, fromlist=['__name__'], level=0)   File "/usr/local/lib/python3.6/dist-packages/onedrived/od_main.py", line 22, in <module>     from .od_watcher import LocalRepositoryWatcher   File "/usr/local/lib/python3.6/dist-packages/onedrived/od_watcher.py", line 6, in <module>     from bidict import loosebidict ImportError: cannot import name 'loosebidict'

Replace the
from bidict import loosebidict

line in od_watcher.py with something like
import bidict

class loosebidict(bidict.bidict):
    on_dup_val = bidict.OVERWRITE

might work.

its worked, thanks @xybu :)

It woorked perfectly fine.
If it can be useful to seomeone, here is where the file was located on my machine (Ubuntu 17.10):
$ sudo find . -name od_watcher.py
./usr/local/lib/python3.6/dist-packages/onedrived/od_watcher.py

Many thnks for the quick response @xybu !

I tried editing od_watcher.py, but still no luck:
cat /home/v3ritas/.local/lib/python3.5/site-packages/onedrived/od_watcher.py | head -n 20
import logging
import os
import threading

import onedrivesdk.error
# Commenting this because the below doesn't work
# https://github.com/xybu/onedrived-dev/issues/77
# from bidict import loosebidict
class loosebidict(bidict.bidict):
    on_dup_val = bidict.OVERWRITE
from inotify_simple import flags as _inotify_flags, masks as _inotify_masks, INotify as _INotify

from .od_tasks import delete_item, move_item, merge_dir, update_mtime, upload_file
from .od_models.path_filter import PathFilter
from .od_api_helper import item_request_call
from .od_hashutils import hash_match
from .od_repo import ItemRecordType
from .od_stringutils import get_filename_with_incremented_count

I'm running on Linux Mint. Is there any additional info I should provide to determine why it worked for others, but no me?

Hi, are you sure you didn't forget to import indict?
import bidict

I must be doing something wrong. Even after trying the import bidict, I still get the error. Thanks for the suggestion though.

Committed a fix in 4f24e4f3b2344ef5cdd9d167913bf32e6419a39b. Please try the latest version.

@xybu close

Hi from the author of bidict:)
Just wanted to suggest you pin to a known-compatible version in your requirements.txt in case there are any other breaking changes. So instead of:
https://github.com/xybu/onedrived-dev/blob/7189214d311a1f863c68c7fa808ce41d96dae958/requirements.txt#L12
change it to something like
bidict==0.18

I try to minimize breaking changes that are likely to bite users, but occasionally (after soliciting feedback and giving careful consideration), I do exercise the major-version-zero prerogative, when the pros really outweigh the cons.
That said, sorry for the disruption this change caused. If you pin your dependencies as recommended above (which is generally best practice for applications anyway), it should protect you from breaking changes in the future.
Thanks for using bidict, and if you ever have any questions or feedback, please don't hesitate to drop a message in the chat. <333


fix: var expansion in ensureRunc

What type of PR is this?

/kind bug
What this PR does / why we need it:
fixes variable expansion such that correct runc version is installed during VHD builds, and thus installContainerRuntime will behave as expected during CSE time
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.884%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2536

Relevant Lines:
4098

💛  - Coveralls


Responsive is not working when width:100%

I'm having problems setting my sliders as responsive when I set a width of 100%. When i change the width to any other value, it works normally.
Here's a test I've made: http://www.felipegrin.com/test/
Is there any way to fix it? Maybe I'm doing something wrong?

When you use a percentage width or height the slider can't calculate how it should scale down correctly, so you will have to help it a little by using the aspectRatio and the autoScaleReference options.
Cheers.

what shoud i put at autoScaleReference  since my slide is 100%?

The size from which you want the content inside (i.e. layers) to start scaling down. For example, you could add 960.


⚠ Bofrost.de has degraded performance

In 6e6b7ec, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 955 ms

Resolved: Bofrost.de performance has improved in a5e1422 after 26 minutes.


Hotfix retina display

Deprecates / replaces https://github.com/EngoEngine/engo/pull/352.
This is the "correct" fix for the retina displays.

LGTM once fixed. Pasting error below.
./engo_glfw.go:272: GameWidth redeclared in this block
	previous declaration at ./engo.go:197
./engo_glfw.go:276: GameHeight redeclared in this block
	previous declaration at ./engo.go:202

Changes Unknown when pulling 570c94f88bcb06408c86b9754c0c9c97457932a8 on retina into ** on master**.


New version: MedalB.V.Medal version 4.2309.0

Pull request has been created with komac v2.0.3 :rocket:

https://github.com/microsoft/winget-pkgs/pull/137458#pullrequestreview-1856680681

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


Add tethys model with DVL sensor

🎉 New feature
Summary
Adds tethys underwater vehicle that contains various sensors. One of them is a DVL sensor which is a new harmonic feature.
The dvl sensor uses bottom tracking model. It's placed close to the surface of the water because the sea bed is currently quite shallow.
Test it
Requires this sensors system deadlock fix: https://github.com/gazebosim/gz-sim/pull/2141
export GZ_SIM_RESOURCE_PATH=`pwd`/harmonic_demo:$GZ_SIM_RESOURCE_PATH
gz sim -v 4 -r harmonic_demo/harmonic.sdf

# move the vehicle
gz topic -t /model/tethys/joint/propeller_joint/cmd_thrust -m gz.msgs.Double -p 'data: -31'

# echo the dvl velocity topic and make sure that the velocities are changing
gz topic -e -t /tethys/dvl/velocity

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

merging this as the demo was already presented


Bug: Collections with indexes created using sdk does not behave properly

https://github.com/pocketbase/pocketbase/assets/20862517/db9ef546-ee78-4035-8a28-28b9fff1fec4
Reproduced on  v0.22.14
import PocketBase from 'pocketbase'
const pb = new PocketBase('http://localhost:8090')
await<EMAIL_ADDRESS>'1111111111')
pb.autoCancellation(false)

for (let index = 0; index < 10; index++) {
	const name = generateRandomString(10)
	const index = "CREATE UNIQUE INDEX" + " " + "`" + "time_index" + "`" + " " + "ON" + " " + "`" + name + "`" + " " + "(`time`)"
	await pb.collections.create({
		name: name,
		indexes: [index],
		schema: [
			{ name: "time", type: "number" }
		]
	})
}

function generateRandomString(length) {
	let result = '';
	const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
	for (let i = 0; i < length; i++) {
		result += characters.charAt(Math.floor(Math.random() * characters.length));
	}
	return result;
}

As far as I understand from the video the problem seems related to the unique constraint but note that the unique constraint is handled on SQLite level.
In your case the issue seems to be related to the fact that the index is created with the same name for each collection, aka. the last saved collection will most likely delete the previous index. Or in other words - use a unique index name.
I'll consider adding a validator with the refactored Collection model for this use case to prevent duplicated collection index names.


Low Depth Image Quality from D435

Required Info

Camera Model
{ D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10)

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.. }

Language
{opencv/python }

Segment
{others }

Issue Description
I have created a script to take pictures or videos of cows when they walk through an area.
 Below is an example of how data chunks are missing (most aren't this bad but close to). There are consistently black spots on the left side of the cow. This leads me to believe the camera likely needs to be recalibrated, but I would like to know if my code is possibly the cause as well. I should note when I take videos of the cows instead of pictures there are very few videos that have missing data chunks.
Thanks in advance!

  This is because it is a general physics principle (not specific to RealSense) that dark grey or black absorbs light and so makes it more difficult for depth cameras to read depth information from such surfaces.  The darker the color shade, the more light that is absorbed and so the less depth detail that the camera can obtain.
You could try filling in the black areas of the depth image by applying a post-processing filter with hole-filling properties in your Python script.  If the cow is in an indoor location such as a cow shed then you could also install a stronger external light source such as an overhead lamp, as doing so helps to bring out depth information from dark grey / black surfaces.
Having said that, I note that you mention that you mainly experience the black areas on pictures but not videos.  As you are saving a single frameset, this could suggest that you should skip several frames before taking a picture capture if you have auto-exposure enabled.  This is because it can take several frames for the auto-exposure to settle after the pipeline starts, which can result in problems in the depth image for those first handful of frames.
Alternatively, if the lighting level in the camera's location is consistent all of the time that the camera is in use then you could disable auto-exposure and set a manual exposure value.  You will then not need to skip several frames and the first frame captured should be good.

Hi @codeandstuf  Do you require further assistance with this case, please?  Thanks!

I do not. Thank you for your help!

You are very welcone, @codeandstuf - thanks very much for the update!


[fix][test] Disable testMaxPendingChunkMessages to unblock the flaky test first

Fixes #xyz

Master Issue: #xyz
Motivation
Currently, the flaky test testMaxPendingChunkMessages has blocked many PRs. Although I have fixed some problems of this test, there are still other flaky issues. This PR disables this flaky test first. Then I will open a new PR to fix this flaky test.
Modifications

Disable the test testMaxPendingChunkMessages

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #18572 (e33e750) into master (67f9461) will increase coverage by 4.96%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18572      +/-   ##
============================================
+ Coverage     31.98%   36.95%   +4.96%
+ Complexity     6813     1958    -4855
============================================
  Files           698      209     -489
  Lines         68060    14414   -53646
  Branches       7277     1573    -5704
============================================
- Hits          21772     5327   -16445
+ Misses        43238     8509   -34729
+ Partials       3050      578    -2472

Flag
Coverage Δ

unittests
36.95% <ø> (+4.96%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...apache/pulsar/client/impl/AutoClusterFailover.java
73.33% <0.00%> (-2.78%)
:arrow_down:

...va/org/apache/pulsar/client/impl/ProducerBase.java
32.69% <0.00%> (-1.93%)
:arrow_down:

...org/apache/pulsar/broker/loadbalance/LoadData.java

...ar/broker/service/persistent/ShadowReplicator.java

...r/loadbalance/BrokerFilterBadVersionException.java

.../persistent/ReplicatedSubscriptionsController.java

...e/pulsar/proxy/server/BrokerDiscoveryProvider.java

...he/bookkeeper/mledger/OffloadedLedgerMetadata.java

.../apache/pulsar/broker/service/EntryBatchSizes.java

...ar/broker/stats/prometheus/ManagedLedgerStats.java

... and 481 more

@tisonkun Thanks for your comment. I linked this PR to the issue: https://github.com/apache/pulsar/issues/18570


Adding extra people from saveourtool

What's done:

Added Jalil
Added Alexander
Added Daria

@akuleshov7 thanks


KtLint formatting checks do not include full path in report

As of 1.12.0, the formatting checks which wrap KtLint do not include the full path of the file in the reports.
Context
In order to be able to process results from Detekt reports, the full path of each file is needed to unambiguously identify the originating file.
Expected Behavior
With this example configuration (containing one of each a Detekt check and a KtLint check for demonstration purposes):
formatting:
  active: true
  NoUnusedImports:
    active: true
    autoCorrect: true
style:
  active: true
  UnusedImports:
    active: true

An unused import in a sample project outputs the following Checkstyle report when ran with Detekt 1.11.0 and earlier:
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="/Users/damian/Development/sample/app/src/main/java/com/example/sample/MainActivity.kt">
	<error line="10" column="1" severity="warning" message="Unused import" source="detekt.NoUnusedImports" />
	<error line="10" column="1" severity="warning" message="The import 'android.content.Context' is unused." source="detekt.UnusedImports" />
</file>
</checkstyle>

The full path is recorded for both checks.
Observed Behavior
As of Detekt 1.12.0, the following Checkstyle report is generated:
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="MainActivity.kt">
	<error line="10" column="1" severity="warning" message="Unused import" source="detekt.NoUnusedImports" />
</file>
<file name="/Users/damian/Development/sample/app/src/main/java/com/example/sample/MainActivity.kt">
	<error line="10" column="1" severity="warning" message="The import 'android.content.Context' is unused." source="detekt.UnusedImports" />
</file>
</checkstyle>

The full path for the detekt.NoUnusedImports check is not reported - the file is only identified as MainActivity.kt. The path for detekt.UnusedImports is included as expected.
Your Environment

Version of Detekt used: 1.12.0 (I intended to also check 1.13.0 but it seems that this one has not been published yet)

Thanks for reporting this.
Is this expected @arturbosch with the following change https://github.com/detekt/detekt/commit/19ed18ee25a744f399d6aa0a414c24b8d82387d6 ?

Can confirm this is happening to me too.
Considering all other checks have correct path (only the formatting ones are broken), I don't think it is a expected behaviour.


heatmaps not working on nodejs

See https://github.com/CartoDB/Windshaft/issues/271

This requires #132

All required changes in the library were introduced as per https://github.com/CartoDB/torque/releases/tag/2.11.0


Does not work with Brave browser?

An external user was unable to use web3torrent using brave.
Channels didn't seem to connect.

Are we able to reproduce this issue?

I haven't tried to repro this yet. This is the genesis of the issue: https://statechannels.slack.com/archives/CPX2BU1FA/p1591808268270600

I believe we saw the same behavior with Joseph (https://github.com/statechannels/monorepo/issues/2152). I am not sure what browser he was using, but we attributed the behavior to his VPN (without concrete evidence that VPN was to blame). It would be really nice to have repro case and/or good logs.
Maybe we should also log browser details when the application is started up?

Maybe we should also log browser details when the application is started up?

I think that would be a great idea.

Maybe we should also log browser details when the application is started up?

I believe Sentry does this

I believe Sentry does this

That's great! I think it would still be helpful to log the browser type and version for the following reasons:

There are issues that do not create an error. For instance, a stall in application progression would no show up in Sentry.
It would be nice to avoid having to map logs reported by users to sentry errors reported automatically. I don't think we ship a log file to Sentry with errors at the moment.


 Thought I'd bring it up here if this sounds like a logical optimization the runtime could perform.

It's very difficult to implement byte buffer pooling that satisfies all the needs. butebufferpool isn't a silver bullet yet.
It performs better than a dumb sync.Pool when working with variously-sized byte buffers when a small fraction of such buffers has much higher size comparing to the rest (this helps real-world apps based on fasthttp and quicktemplate).
But it still may waste a lot of memory in the case of buffers with wide-range equally distributed sizes. It is advisable to create a separate pool per each use in this case - see Pool docs for details.

@valyala i have the exact situation from your comment, any chance that you can show me some example how to get it done?


[RESTEASY-3492] Upgrade WildFly Arquillian to 5.1.0.Beta2. Migrate te…

…st utilities to new WildFly Arquillian dependencies.
Also sneaked in a minor test commit to ensure @ManagedBean annotated tests work. Note this test may end up going as we upgrade the Jakarta Annotations API. However, we can move the test to WildFly when we do that.
https://issues.redhat.com/browse/RESTEASY-3492

A 6.2 PR is still required, but I wanted to run this through CI first. Note that when back poring we may want to consider keeping some of the deleted utilities. That said, those are not meant to be used outside of RESTEasy so breaking compatibility is not as big of a deal. The common WildFly Arquillian utilities should really be used.


Deploy existing sqlite DB on ios

I have a sqlite database, how can I copy it to ios and how can I operate on that database?

If it doesn't exist in the documents directory, copy it there, then pass the path to the copy to sqlite.net.


[BUG]No module named 'tomllib'

Description
When using python3.10, the error No module named 'tomllib' is reported
Steps to Reproduce

use python3.10
run crewai run

Expected behavior
it can run successfully.
Screenshots/Code snippets
tomllib starts from Python 3.11, but the supported versions written in the usage documentation are >=3.10 <=3.13.
Operating System
macOS Catalina
Python Version
3.10
crewAI Version
0.74.2
crewAI Tools Version
0.13.2
Virtual Environment
Venv
Evidence
.../.venv/lib/python3.10/site-packages/crewai/cli/update_crew.py", line 5, in
import tomllib
ModuleNotFoundError: No module named 'tomllib'
Possible Solution
Either continue to use the parse_toml method in utils for compatibility.
Either update the usage documentation to update the supported versions to start with a Python version that supports tomllib
Additional context
/crewai/cli/utils.py

Hey @flingjie
tomllib — Parse TOML files¶
Added in version 3.11.
We highly suggest starting using Python 3.11
We'll take care of the update of the code/docs

Thanks for the report @flingjie
We fixed this issue with the https://github.com/crewAIInc/crewAI/pull/1506
Let me know if it works now, I'll close this issue for now.


Review the software update process

Problem
The software update process differs slightly than the experience we have for v1 of the application.
Requirements:

We don't want to request users to delete the existing app to install the new one
For existing users that upgrade to v2, the app should pick up the new software version from the OneDrive -> InputFiles folder as that is where admins drop the new update today
The previous tool did not require the yml file to be in the directory along with the the software update artifact - is this required?

Solution
Review the software feature
Alternatives
No response

The InputFiles directory needs to be added to the path to what is found in the credentials.

The yml stores the version numbers for the different artifacts and each artifact for each system.
Use the universal artifact and the version number comes from the file name.
Future, to review the other ways to manage the updates for the tool.

update server for each organization as another potential long terms solution

we should be using .pkgs going forward
no recursive process to search for software artifacts in deeper directories in the tree


Toggle add remove

NEED FEEDBACK:
When calling cases "createObject" and "destroyObject" in event_handler.js initWorker, the program checks globals.task.getEnableAddRemove is true before executing. Is this fine?
Potential improvements:
Call some kind of error (AttributeError?) if using these commands when enableAddRemove is false to trigger error message.
Next changes:
Add checkbox or similar to editor.html so this field can be added to json easily

"When calling cases "createObject" and "destroyObject" in event_handler.js initWorker, the program checks globals.task.getEnableAddRemove is true before executing. Is this fine?"
Seems like a good solution.


sap.m.DatePicker: year picker not properly honoring minDate

OpenUI5 version: Latest
Browser/version (+device/version): Any
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible): https://jsbin.com/kajakol/edit?html,js,output
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Run sample and open the calendar picker
Click on the (2019) year button in calendar header to bring up the year picker
Notice that earliest available year is 2009

What is the expected result? Expected 2008 to be earliest available year since the calendar's minDate is set to January 1, 2008.
What happens instead? The minDate year is omitted from the year picker. Workaround is to select 2009 and then use the regular calendar left arrow button to move through the 2008 months.
Any other information? (attach screenshot if possible) In the YearPicker._checkFirstDate() method, there is a check to see if the date is before the minDate, this check passes which is preventing the YearPicker from updating to show the correct year of 2008 as the first item.

Hello @cmastrandrea ,
Thank you for your ticket!
I am not sure, if I understood you correctly, since I could not find an issue in your sample.
If you go to the year picker, since the selected year is the current 2019 year, you just have to use the left arrow and 2008 will be shown.
The min date of your sample is exactly "Jan 1, 2008"
Could you please check?
Regards,
Niya

Notice in the year picker that the earliest available year is 2009, one year after the 2008 mindate, and the left arrow button is disabled.

Just your sample, without any adjustments. If I open the year picker, the arrow is available, then I use it and 2008 is visible.
Regards,

I just now retried this on Windows 10 in Chrome 72.0.3626.109 (Official Build) (64-bit), Firefox 65.0.1 (64-bit), and Edge 41.16299.820.0, and in all three the left arrow button is disabled as shown in my earlier screen grab. Other colleagues here are seeing the same. Not understanding why this would behave differently for you.

Could you please try to use display format where year is denoted by smaller "y" instead of "Y"?
The point is to check whether your system settings use upper Y which affects how calendar years are taken.
Regards,
Niya

I updated the sample to call setDisplayFormat using lowercase yyyy but am seeing the same behavior:
https://jsbin.com/suqaruvaro/1/edit?html,js,output

When you tap on the year, try up arrow key, and see if 2008 comes into view

It does if I press up arrow key 3 times. It also does if I keep pressing left arrow key until selection moves past 2009. Just appears to be the disabling of the left arrow button in the header.

Dear @cmastrandrea ,
Thank you for sharing this finding.
I investigated your issue in details. The issue is reproducible, but it was hard for me at the beginning, since I found out that it is reproducible only in specific time zones such as yours.
I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Niya


dispatcher broken for old-style event with time.Time

I've just tested https://github.com/textileio/go-threads/pull/439 and got the gob encode error in the dispatcher for old-format event here
gob: type not registered for interface: map[string]interface {}
So looks like an empty time.Time decoded into map[string]interface which is not auto-registred in the gob

Does registering time.Time with gob help?

@sanderpick cbor encodes time.Time as empty map, not a struct, so it works with gob.Register(map[string]interface {}{})
I made the PR: #444


zoom-us: use regular qt5

zoom-us used to be not compatible with the current qt5 version
provided by libsForQt5.callPackage, but it is by now.
To avoid downloading a different qt (or even building it), point it back
to the generic libsForQt5.callPackage.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @grahamc @worldofpeace @NeQuissimus

Thanks, wasn't sure we needed to do this before :+1:


TEAMNADO-5731 - Add release script

Codecov Report
Patch and project coverage have no change.

Comparison is base (5d60c03) 93.89% compared to head (aac5386) 93.89%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   93.89%   93.89%
=======================================
  Files          36       36
  Lines         459      459
  Branches       95       95
=======================================
  Hits          431      431
  Misses         25       25
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


experimental feature: Glicko2 ratings (weapons)

This experimental feature has been rejected because no useful results were obtained.


add logo design 2

new logo design for the cinesmile project #25

Hey @AsithaIndrajith, thank you for creating this pull request! Have a wonderful day...


iPad Unsupported on 3.5.0

Describe the bug
Shows "Unsupported" on iPad Pro 10.5
Device (please complete the following information):

iOS Version: 12.3.1
iOS Device: iPad Pro 2nd Gen 10.5 (J207AP)
unc0ver Version: 3.5.0

update to ios 12.4

mine also unsupported

@ps4gentoo are you certain about updating?

@ps4gentoo are you certain about updating?

i am updating to 12.4, i will update you sir

The exploit does not work on 12.3. Only 12.4 or 12.2. Update to 12.4 and close this

The exploit does not work on 12.3. Only 12.4 or 12.2. Update to 12.4 and close this

yah this is correct. here is the screenshot, after i update

Thanks guys, I will be updating!

Thanks guys, I will be updating!

no problem bro, the problem is there is no appsync available for ios 12.4.
can you guys help me, can you give me a useful cydia repository, maybe 5 repos.. thanks

@ponching27
That is not true. See below.
https://twitter.com/angelXwind/status/1163154299356110850
Don’t pirate. It’s not nice.
Also this GitHub really should only be used for bug reports. If you need help head over to r/jailbreak subreddit and do some searching.

@ponching27
That is not true. See below.
https://twitter.com/angelXwind/status/1163154299356110850
Don’t pirate. It’s not nice.
Also this GitHub really should only be used for bug reports. If you need help head over to r/jailbreak subreddit and do some searching.

hahaha! what are you saying dude? do you even read your comments? pirating? why are you here by the way? is jailbreaking legal? or jailbreaking makes legal thing to you? sharing angelxwind tweets, dont make yourself looks clean dude.. github meant for sharing repos, code for us developers not just for bugs.

@ponching27 this is a section of the github meant for discussing bug reports. Not helping you find new repos.
I was making a general statement about piracy as I usually do when app sync is brought up. Jailbreaking is in fact legal and most things we do with it are legal, except for stealing apps with and installing them with app sync.
You don’t need to be so hostile.


Add onUpdateCallback option to call after every update

Can you add tests for this changes?

👍
I just arrived hoping to open a request for this feature!  Please don’t forget about this.


Un-deprecate Array Append

Array append is a useful function, and so should not be deprecated.
Documentation still includes warning of its linear complexity and suggestions to use a buffer instead.

Drive-by comment: Being useful is not a sufficient condition for supporting a feature, almost every imaginable feature is useful in certain situations, yet most are counter-productive in the grand scheme of things. This one likely is unknowingly misused 95% of the time, no matter what the docs will say.

Maybe we could use the unicode :warning: symbol to silence warnings on identifiers. Only half joking.

Maybe keep append deprecated, but just rename it to concat which imo is a better name for the joining of two arrays (most people won't use it to append a single item).

#630 did this. Closing.


Use java.nio.file.Path in JSEnv API

Unfortunately I don't think we can do this. Mainly because the Path API is not "async enough".

I am re-opening this with the narrower scope of the JSEnv API only. I would like to make a case to not have the JSEnv API cross compile to JS.
When we look at the usages of the JSEnv API, we have:

Running code from a build tool.
Testing via the TestAdapter.

Addressing use case 1: Any JS based build tool will almost certainly already have its own abstractions of how to run JS code (as it is likely to already build and run other JS code). Therefore, this abstraction should be used.
Addressing use case 2: There is no need for the TestAdapter in JS land, as the testing tool can (and should) be called directly. In case there is a JS build tool that wants to isolate testing in a different VM, context, etc. again this tool already has its own abstractions that should be used.
Therefore, I'd like to propose to commit to making the JSEnv API JVM only and hence being able to simplify it and taking full advantage of the JVMs abstractions.
In practice, this means allowing the use of java.nio.Path instead of our own VirtualFile abstraction and not altering the abstraction with respect to stdio/stderr forwarding (it currently uses blocking streams).
@sjrd WDYT?

Note that further this would allow to remove the io artifact as it would be entirely linker only at this point.

Yes, that sounds reasonable, indeed. Let's commit the JSEnv API to be JVM-only.


Wrong tap file is captured in test job

The wrong tap file is captured when running Grinder. The Grinder is running serially.
[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)00:29:32.960  TAP Reports Processing: START
00:29:32.961  Looking for TAP results report in workspace using pattern: **/*.tap
00:29:35.343  Saving reports...
00:29:35.855  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap'
00:29:35.855  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap].
00:29:35.856  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap'
00:29:35.856  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap].
00:29:35.858  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap'
00:29:35.858  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap].
00:29:35.859  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap'
00:29:35.859  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap].
00:29:35.860  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap'
00:29:35.860  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap].
00:29:35.862  Processing '/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap'
00:29:35.862  Parsing TAP test result [/jenkins_data/jenkins_home/jobs/Grinder/builds/22799/tap-master-files/jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap].
00:29:35.863  There are failed test cases. Marking build as UNSTABLE
00:29:35.863  TAP Reports Processing: FINISH
[Pipeline] junit
00:29:35.908  Recording test results
00:29:40.801  [Checks API] No suitable checks publisher found.
[Pipeline] echo
00:29:40.807  Saving aqa-tests/testenv/testenv.properties file on jenkins.
[Pipeline] archiveArtifacts
00:29:40.854  Archiving artifacts
00:29:40.946  Recording fingerprints

[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)[](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/22799/console#)00:30:53.690  Fetching Tap files...
[Pipeline] findFiles
[Pipeline] echo
00:30:55.968  Tap file found: aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap
[Pipeline] readFile
[Pipeline] echo
00:30:56.020  Tap file found: aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap
[Pipeline] readFile
[Pipeline] echo
00:30:56.076  Tap file found: aqa-tests/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap
[Pipeline] readFile
[Pipeline] echo
00:30:56.122  Tap file found: jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0/96/aqa-tests/TKG/output_16499483552264/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_0.tap
[Pipeline] readFile
[Pipeline] echo
00:30:56.173  Tap file found: jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1/96/aqa-tests/TKG/output_16499483517149/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_1.tap
[Pipeline] readFile
[Pipeline] echo
00:30:56.229  Tap file found: jvmtest/TKG/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2/22/aqa-tests/TKG/output_16499483523899/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_testList_2.tap

The above issue suggests that the workspace is not cleaned up properly. We may want to look into it as the workspace should be cleaned up before running any tests.
I think we can resolve this by specifying the job name and number at:
https://github.com/adoptium/aqa-tests/blob/3f77e72793da1732a2f9ed18f8515b041202dd57/buildenv/jenkins/JenkinsfileBase#L686
https://github.com/adoptium/aqa-tests/blob/3f77e72793da1732a2f9ed18f8515b041202dd57/buildenv/jenkins/JenkinsfileBase#L694

I am not sure plugins support variable to be used for testResults. e.g step([$class: "TapPublisher", testResults: "**/${env.TAP_NAME}", outputTapToConsole: false, failIfNoResults: true]) unless junit already added support for ant-pattern to be expanded.
the best thing is to call cleanWs before the test starts. or explicitly rm *.tap

It may not necessarily be a simple clean issue. First, we do cleanWs before and after the tests. Second, in some cases (above), TAP files are not in the workspace.

From the output pasted those tap files are copied artifacts from other jobs, which are not in the current job workspace. It is similar to https://github.com/adoptium/aqa-tests/issues/3672, which copy the artifacts from the job defined by params.UPSTREAM_TEST_JOB_NAME && params.UPSTREAM_TEST_JOB_NUMBER. Should be solved by https://github.com/adoptium/aqa-tests/pull/3673.
And the PR https://github.com/adoptium/aqa-tests/pull/3708/ has added cleanWS before and after jobs for AQA_Test_Pipeline in case the leftovers in workspace.
I think this can be closed. @llxia Did you see the failure recently?

Yes, several improvements have been delivered to the repo. I think we can close this issue. Please reopen if the problem still occurs.


Object editing without quotes on keys

What problem does this feature solve?
When you type in data-field-edit it has to be valid JSON. This confused me and a co-worker since we were trying to insert the object inside an array as regular js object: ( { foo: "bar" } instead of { "foo": "bar" } ). Only after trying to solve this issue I realized that in order to edit or add an object It had to be valid JSON.
What does the proposed API look like?
I found two possible solutions:

https://www.quora.com/How-can-I-parse-unquoted-JSON-with-JavaScript
https://www.npmjs.com/package/jsonic

The first would be to:
 value.replace(/(['"])?([a-zA-Z0-9_] )(['"])?:/g, '"$2": ');

before checking if valid and also before saving
The second involves changing the parser library.
Another possible solution is to detect when an object or collection is being entered without quouted keys and give a warning.
I would like to implement this myself as a first contribution.

There should already be a warning displayed if the input is not valid JSON.

The warning is shown, but the reason for the warning is not clear, it says invalid value, leading to think that objects can not be input


Some HTML elements get inserted twice

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.
[X] The bug happens after clearing extension cache. The "Clear cache" button below can also be found at the bottom of the options page.

Example URLs
https://github.com/fltk/fltk
https://github.com/refined-github/refined-github
Extension version
22.6.25
Browser(s) used
Firefox
Description
On some repos, DOM elements that RG inserts (like the “Bugs” tab) get inserted twice:

There are some console warnings, but all of them come from GitHub itself. The extensions doesn't report anything.
Perhaps this is related to #5733
Include in this issue:

[X] Screenshots/video/gif demonstrating the bug, if it’s visual
[X] Console errors, if any

Assumi9ng because of https://github.com/refined-github/refined-github/issues/5719

Found the reason for this and: turbo:load is fired on the first load too, not just on ajaxed loads 😖

I still see this on main branch, though I triggered it via navigate back and forward (https://github.com/EnixCoda/Gitako/commits/develop)

Just now I saw this issue on load for the first time (Safari, store version), but I can't replicate that duplication issue anywhere


Reverting 'inject into file' should not attempt to change files that do not exist

For example, if append_to_file 'model/thing.rb', 'content' is revoked but the file does not exist anymore, the command will fail with an exception that ends like this:
/home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:98:in `binread': No such file or directory @ rb_sysopen - /home/zwippie/src/testing/app/models/thing.rb (Errno::ENOENT)
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:98:in `replace!'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:73:in `revoke!'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions.rb:92:in `action'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:30:in `insert_into_file'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/actions/file_manipulation.rb:180:in `append_to_file'
	from /home/zwippie/src/trailblazer/lib/generators/rails/trailblazer_controller_generator.rb:20:in `add_crud_dependency_to_model'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /home/zwippie/.rvm/rubies/ruby-2.1.1/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'

In this case, the error is triggered by a Rails generator that adds a line to a generated model. It was called with rails d scaffold Thing -c trailblazer_controller, just to give some context.
If I am not mistaking, there is no check in (or near) InjectIntoFile#revoke! to see if the file in question exists. I can find no clues in the specs or docs that this should happen, so perhaps this is the required behaviour. It can be easily fixed though.
This might be attributed to my misunderstanding of Thor or the context of my case (Rails generators). I'm willing to make the neccesary changes and PR if this should be fixed.

I had the same problem today, @zwippie. I believe my #505 addresses it.

I fixed that problem before I call append_to_file:
  directory = "#{Rails.root}/some/path/#{file_name}"
    if File.directory?(directory)
      append_to_file 'Gemfile' do
        "gem '#{file_name}', path: 'rockets/#{file_name}'\n"
      end
      say "=== #{class_name}'s gem added to Gemfile ===\n", :green
      true
    else
      say "!!! Cannot add #{class_name} gem to Gemfile. Directory doesn't exist !!!\n", :red
      false
    end
  end


CORE-15950 Allow changes to notary keys during reregistration

With this change, it should be possible on the client (member) side and the server (mgm) side to request that a member's notary key list is changed during re-registration. This includes adding, removing and changing notary keys. It should not be possible to change any other notary related properties.
This PR covers the validation aspect only and does not include updating the group parameters.

Multi cluster e2e test passed: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-e2e-tests-multi-cluster-tests/detail/feature%2FCORE-15798%2Fnetwork-level-notary-key-rotation/2/pipeline

Single cluster e2e test passed: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/feature%2FCORE-15798%2Fnetwork-level-notary-key-rotation/14/pipeline/


Make all instances of .command in messages match config

. into config.commandcharacter + '' is an example

It's about time you got past aliases. I trust you've tested this?

Also, please make the pullreq title more descriptive. Changing the commit title to "Make all instances of .command in messages match config" would be more concise as wel

Actually I think I'll just merge this and correct the commit title myself.
Grats on your first merged pullreq here!

Tyvm


Rain Sound

Hi!
I thought the last feature which would make Rain the ABSOLUTE PERFECT MOST BEAUTIFUL WEATHER APP is: Sound Effects!
This sounds (xD) weird at first but hear me out:
It would be so satisfying if some quiet rain drops can be heard depending on whether it is raining or not of course. And some bird sounds when the sun is bright in the sky.
For all people not wanting such sounds, they [sounds] would be turned off by default.
Thinking even further it would be great if these sounds didn't interrupt other media, for example: If a song is being played by Spotify, the rain sound would be an additional layer of sound, not stopping the music played by Spotify.
It's okay, if this suggestion doesn't get implemented because it is already the best weather app out there, but I personally and probably many other people would be very hyped about this new feature...
I'm looking forward to reading the developers opinions on this topic...
Bye!

Please assign labels enhancement and question!

The offer sounds interesting, when we finish the basic functionality and fix all the errors, then we will do it.


deviceManufacturer unavailable?

This morning I found a strange error in the Android tracker. It is raised for almost every event. The error is the following:

{"level":"error","schema":{"loadingURI":"#","pointer":""},
  "instance":{"pointer":""},"domain":"validation","keyword":"required",
  "message":"object has missing required properties ([\"deviceManufacturer\"])",
  "required":["deviceManufacturer","deviceModel","osType","osVersion"],
  "missing":["deviceManufacturer"]
}

I noticed that is was always raised by the same user by checking the idfa related to the events. Any idea of what could cause this?
It is not a critical error as it only concerns one user but it could be interesting to know if it is because of an other apk available on the web of a rooted Android version for example.

There could be a particular device that simply does not have a valid device manufacturer..  Could be that the user has rooted their phone or messed with something.
I could update this field to populate itself as unknown if it cannot be found?  Or to not include the mobile context unless all required fields are included?

Actually we already have a check that it will be either be unknown or the manufacturer name.. Should not be possible for that field to be blank!  Will investigate...

Thanks @jbeemster !

Okay so I initially read this section of code wrong, if we get an "unknown" manufacturer we simply leave this field blank.  Which is no good as it is a required field.
Are we happy to just populate this with unknown if we cannot get a proper manufacturer?

Sounds good to me


feat: align webpack - allow false for optimization.splitChunks on options validation

Summary

rspack disables SplitChunksPlugin when optimization.splitChunks is false which is of same behavior as webpack excepting rspack's options validation prints an error for it.
it is not documented on webpack's doc but allowed by webpack.
schema: https://github.com/webpack/webpack/blob/87660921808566ef3b8796f8df61bd79fc026108/schemas/WebpackOptions.json#L2560
Test Plan

optimization.splitChunks = undefined: configCases/split-chunks-common/default
optimization.splitChunks = false: configCases/split-chunks-common/disable

Require Documentation?

[ ] No
[x] Yes, the corresponding rspack-website PR is web-infra-dev/rspack-website#548

thanks

thanks

thanks @hardfist, would you please review web-infra-dev/rspack-website#548 too


pip install : Unable to determine SOCKS version

i have try all the method, it just not work !

@torfhub If you really have found a problem and expect to have it fixed, what you wrote is not enough.
Start by reading CONTRIBUTING.md
At least post here the command and the output.

Hi @torfhub,
We will need a lot more information in order to help you. Without that information, I'm going to close this, for now. If you leave a comment with information, I'll be happy to reopen this and help you investigate.

@HelioGuilherme66 we appreciate your attempt to help gather some basic information with @torfhub. Please, in the future, try to phrase your comments a bit more gently. @torfhub seems rather new to open source software and gruff and unwelcoming responses are not typically helpful for either them or the maintainers.


Firefox support

Firefox as of now only supports SVG-in-OpenType and COLR color font formats. It would be amazing to be able to use these emojis in FF as well.
Is there any potential to also generate one of those font formats as well? I would guess the SVG-based one would be easiest because SVG assets for the emojis already exist, but COLR would be nice as it would give Safari support as well.
Thanks for taking a look!

I played with this some today after noticing that it looks like a reasonable amount of effort has already gone into trying to build an OpenType SVG font.
After following instructions to setup noto-tools, I ran the following command to generate the SVG font:
python generate_test_html.py NotoColorEmojiSvg.tmpl.ttx svg/emoji_u
(I also had to tweak one call to add_image_glyphs that had an extra argument)
This output a NotoColorEmojiSvg.woff file and test html page (among other things). However, when opening the test HTML page (using a webserver, not file reference), it doesn't seem to work in FF. I debugged a bit and didn't see anything wrong with the test page itself and verified the font was getting loaded via the network tab, so I was wondering if something might be wrong with the font. Maybe my command to build the font was wrong?

I'm very interested in this, as a Firefox user.
Could you check the "Console" tab (F12) for errors? I've tended to see pretty helpful error messages when fonts don't load. Not always, but usually.

Nothing in the console.
I was able to open the font in FontLab. The characters looked a little funny, though. It appeared as if the glyphs were empty, but when opening an individual glyph I could see the content, but it seemed to be outside the visible area of the glyph.
It seems like even if that was the problem FF would just be showing blanks instead of falling back to the default emojis for the platform/browser. It seems more likely there's some problem with the character mapping, such that it's just not finding the glyphs at all for emojis.

The toolchain @ https://github.com/googlefonts/color-fonts may in time be able to build an SVG edition but I do not expect that to become a primary output for Noto Emoji.
The preferred long term solution to this is https://github.com/googlefonts/colr-gradients-spec/blob/master/colr-gradients-spec.md.
Closing because I don't expect further action in this repo.


feat: remove index.d.ts and flow

Summary
PR removing index.d.ts files in favor of taking types straight from lib/typescript. Since it highly changes the flow file generated due to not having one index.d.ts file from which flow would take types, generating flow types has been removed.
Test Plan
Check if the types used inside files work the same as the ones from index.d.ts and fix incompatibility issues.

We should finish this feat, it's a good one

Yeah, it would be a nice change for sure, but I am a bit stuck with other changes that have higher priority. If you have a time window, it would be great to push it forward.

I bet I could, I'll figure out how to progress this

Closing since #1806 has been merged.


ESP32-S3 miscommunication with IP101GRI Ethernet PHY (IDFGH-13383)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hi,
First of all, I am complete beginner to the github. Main purpose of this post is ask for help rather than to report an obvious bug, so if its not the best place for such post, please excuse my inexperience and redirect me to the more appropriate place Thank you in advance.
I am trying to replicate ESP Ethernet DEV kit (at least the ethernet part of if) on my custom PCB that I will be using for Ethernet application. I consistently followed the manufacturer's schematic (in the attachments.)  All the wiring is tested like a 100 times. I absolutely guarantee that everything you see in my schematics is indeed implemented on the PCB (Schematics are in the attachments). The ESP part works flawlessly, it flashes and runs perfectly. However my problems occur in the ESP-PHY communication level. The ESP can not fully initialize the PHY, I get false logs (for example, I sometimes get ,,Ethernet link up" log when there is no ethernet cable attached etc.) The logs related with PHY are completely unpredictable. One exact log example is in the attachments.
I am testing my board with manufacturers provided ESP code (ESP-IDF->examples->ethernet->basic). That code has to send a dynamic IP request to the DHCP server and obtain it, but as you can tell, my ESP is not obtaining the dynamic IP. I am absolutely sure that all the connections are right, and my DHCP server is up and running. If I test the exact same code with the ESP Ethernet Dev kit, it works perfectly.
Hope I explained the problem well enough so far. I tried both running the 50 MHz clock from the PHY CLKO as the reference, but I settled on sourcing the 50 MHz clock from the ESP GPIO0 pin and using an inverter right before the PHY's CLKI pin. In any case, I made sure I get nice and continuous real and the inverted 50 MHz clocks (picture in the attachments.) I also probed the MDIO and MDC lines. I can capture occasional MDIO packets, but the clock line MDC always stays low. That is an obvious problem but I guess that is a consequence of some other mistake, rather than the cause. In any case, I have settled on this problem for a couple of weeks now and I am absolutely out of clue what could be wrong, what else can I try. Any observations about the MDC or any other possible solutions are highly appreciated.
P.S. If I missed some crucial details about this problem, just let me know.

ESP32_Ethernet_schematics.pdf
logs.txt

This exact issue has been already actively discussed on the forum.


Update stable version in repo from 1.2.7 to 1.2.9

Think about update stable version to 1.2.9
Version: stable=1.2.7 (42 days old) => latest=1.2.9 (30 days old)
Installs: stable=102 (47.22%), latest=24 (11.11%), total=216
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 1.2.9 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.2.9 but the current stable version is already 1.2.9.
So this issue should be closed.
@mcm1957 for evidence


Add validations for Azure standard loadbalancer

Add validations for Azure standard load balancer, which include:

loadBalancerSku should be standard
all nodes in different agent pools should be added to the SLB backends
Pod's outbound IPs should be same as that configured in SLB outbound rules

/kind testing
/milestone v1.16

Required changes of https://github.com/Azure/aks-engine/pull/1622, which would included in next aks-release v0.39.0.


valueFilter option  in react-pivottable

Dear Sirs,
I need your help for the valueFilter option.
I your documentations there is the following explanation:
valueFilter: object whose keys are attribute names and values are objects of attribute value-boolean pairs which denote records to include or exclude from computation and rendering; used to prepopulate the filter menus that appear on double-click.
I have the following attribute name:
"Status" with the following attribute values:
Filter Values:
1_Collected
2_Stored
3_Treated
4_Disposed
I insert in my react table the following option:
valueFilter={Object.keys("Status").values([Object.keys("1_Collected").values(false),Object.keys("2_Stored").values(false),Object.keys("3_Treated").values(true),Object.keys("4_Disposed").values(true)])}
and the following options:
valueFilter={Object.keys('Status').values(['1_Collected':false,'2_Stored':false,'3_Treated':true,'4_Disposed':true])}
Both of these don't work.
Please may you help me ?
Best Regards,
Antonio Basiaco

Assuming you want to hide the 2_Stored value, try this:
valueFilter={"Status": {"2_Stored": true}}
As far as I can tell, it doesn't matter if you say {"2_Stored": true} or {"2_Stored": false}. It's the presence of the "2_Stored" attribute in valueFilter that controls the behavior.


Query parameter minimum/maximum validation not generated.

A query parameter of type integer with minimum/maximum constraints added is not generated unless the parameter is also required. E.g. The first testcase does not generate for the [2000..2100] range, while the second one does. This leads to the code generated for the first test case accepting integers outside the minimum/maximum range, for example the parameter /?year=3000.
paths:
  /:
    get:
      parameters:
        - name: year
          in: query
          type: integer
          minimum: 2000
          maximum: 2100

paths:
  /:
    get:
      parameters:
        - name: year
          in: query
          type: integer
          required: true
          minimum: 2000
          maximum: 2100

Fixed by PR41


Division by zero error when rendering two metrics

We are attempting to use the following API call to render a graph:
$ curl -v 'http://grafana.knewton.net:8888/render?target=path.to.metric&target=constantLine(5)&from=-5min

We got the following exception thrown:
Exception on /render [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python2.7/dist-packages/graphite_api/app.py", line 455, in render
    image = doImageRender(request_options['graphClass'], graph_options)
  File "/usr/local/lib/python2.7/dist-packages/graphite_api/app.py", line 568, in doImageRender
    img = graphClass(**graphOptions)
  File "/usr/local/lib/python2.7/dist-packages/graphite_api/render/glyph.py", line 383, in __init__
    self.drawGraph(**params)
  File "/usr/local/lib/python2.7/dist-packages/graphite_api/render/glyph.py", line 871, in drawGraph
    self.consolidateDataPoints()
  File "/usr/local/lib/python2.7/dist-packages/graphite_api/render/glyph.py", line 1250, in consolidateDataPoints
    bestXStep = numberOfPixels / divisor
ZeroDivisionError: float division by zero

It appears like somehow the divisor has ended up being zero. The error appears to be because the time range is somehow being set to zero, so the divisor in this statement ends up being zero.
If we only use one of the metrics it works fine. It's only when we specify two targets that this causes a problem.

I think I've found the problem. The metric we're looking at has a step of 60 seconds so we might end up with a start time of<PHONE_NUMBER> and an end time of<PHONE_NUMBER>. The constant line metric then has a start time of<PHONE_NUMBER> and an end time of<PHONE_NUMBER> with a step of 300.
For whatever reason, the following code is here: https://github.com/brutasse/graphite-api/blob/ab9ad02a58ea7f2b640af284e6b13c6914a07f02/graphite_api/render/glyph.py#L866
self.startTime = min([series.start for series in self.data])
if (
    self.lineMode == 'staircase' or
    set([len(series) for series in self.data]) == set([2])
):
    self.endTime = max([series.end for series in self.data])
else:
    self.endTime = max([
        (series.end - series.step) for series in self.data])
self.timeRange = self.endTime - self.startTime

So it then has a time range that is lower than the largest step. Then integer division happens and it crashes.
Why is the series.end - series.step there? It seems like it would be correct to always use series.end for the end time. I can't think of a reason why you would leave off the last value.

Bisected the issue in graphite-web and found this:
commit a781432bcb48ef2581e9bf9d0cb4894d7e1f9f43
Author: Chris Davis <chrismd@chrismd-glaptop>
Date:   Sat Jan 14 15:44:19 2012 -0800

    Aman and I have changed the rendering behavior to be... less broken.

    Previously the rendering code pre-pended a fake datapoint to make slope mode and staircase mode line up, though
    it had the side effect of making slope/connected mode off by one on the x-axis. The key thing is that slope mode
    draws N-1 lines for N datapoints, and stairmode draws N lines.

    We also forced staircase mode for all requests that have a series with exactly one datapoint. *Whew*.

:040000 040000 6f78f4ca87b2667e5af9865e85d3043ade34a0d5 05e54f941da8547ce19c12437088be7a7585698e M      webapp

I'll file an issue with graphite-web as they may have a better idea of why.

I can't reproduce this. If this happens again, can you reopen and provide some sample data to reproduce the error?


How do I fill unused code memory using linker in esp-idf eclipse? (IDFGH-6234)

Environment

Development Kit:  ESP32-Mini-1

Kit version

Module or chip used: ESP32

IDF version :v4.2.1

Build System:   Make|CMake|idf.py

Compiler version : xtensa-esp32-elf-gcc (crosstool NCG esp-2020r3)8.4.0

Operating System:    Windows

(Windows only) environment type: Command Prompt

Using an IDE?: Yes (Eclipse)

Power Supply:  USB

Problem Description
I am looking for option, on how to fill unused code memory using some specific data like 0xFF using linker script.
I am trying to fill my binary file with 0xFF up to some address manually and looking for automatic option.
My binary file size is up to 0x1000 and after that I am trying to fill 0x1000 to 0x1100.
We tried this [as shown in below snip],but didn't work.

Could you please help with this.
Thanks!!

@dimpalsharm Are you trying to create memory checks aka "heap poisoning"? If yes, there should be an option in somewhere in menuconfig. Heap poisoning is activated in the IDF unit tests per default.

Nope, we are trying for memory check. My requirement is to calculate checksum of binary starting from 0x00 to ox1000.
However, my binary size is 0x890 only. So I wanted to fill remaining part upto  0x100 with 0xFF.

Hi @dimpalsharm ,
Can you give a bit more details on why it did not work? Was the section created? Was the address in the binary incorrect? Was the load address incorrect? Was the size incorrect?
From a linker script point of view, you can create a section that will be filled with bytes that you want. Let's take the ESP32  linker script and add an empty section of size 0x100 after .iram0.data section:
  .iram0.data :
  {
    . = ALIGN(4);
    _iram_data_start = ABSOLUTE(.);

    mapping[iram0_data]

    _iram_data_end = ABSOLUTE(.);
  } > iram0_0_seg

We can add another section right after that will be filled with 0xFF, to do so, here is what to add after .iram0.data:
  .iram0.data :
  {
    . = ALIGN(4);
    _iram_data_start = ABSOLUTE(.);

    mapping[iram0_data]

    _iram_data_end = ABSOLUTE(.);
  } > iram0_0_seg

  .iram0.fill :
  {
    FILL(0xFF);
    _fill_start = .;
    BYTE(0xFF);
    . = . + 0x100 - 1;
  } > iram0_0_seg

We need to subtract 1 to the latest declaration because BYTE already adds a byte to the section. After executing readelf on the generated binary, we get:
  [...]
                                         LoadAddr Offset Size
  [19] .iram0.data       PROGBITS        4008b104 02d010 000000 00   W  0   0  1
  [20] .iram0.fill       PROGBITS        4008b104<PHONE_NUMBER>00 00  WA  0   0  1
  [...]

So this will create a filled section right after an existing one. According to GNU Linker documentation, you can still provide a VMA/LoadAddress to the section and also a hardcoded offset in the ELF file. (Here is the documentation: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_chapter/ld_3.html#SEC21)

Hi @o-marshmallow,
Thank you so much for the response!
I am able to fill the memory up to plus(+)100 from the end of my bin file,
but , what I want to fill is exactly upto a  some specific location (upto 0x17F000...in my case) from the end of he bin file.
Could you suggest any modification for that.

@dimpalsharm Unfortunately, there are no way to control the offset of a section with a linker script file. In fact, we can't retrieve the offset of a section in the ELF. Thus, in the generated binary, we won't have this possibility either.
However, from what you said earlier, what you are trying to do is make your binary file up to a certain size by filling it out, the goal is to perform a checksum on it (on the host, right?). So, I would say that you don't even need a section to do this as you won't really use any of the symbols. In that case, you can use the Linux commands to perform the following operations:

Generate a large amount of 0xFF (0377 in octal)
Append them to your binary
Truncate your binary to the desired size (0x1000)
All of this can be done with:

yes '' | tr "\n" "\377" | head -c 1024 >> your_binary.bin && truncate -s 4096 your_binary.bin

Thus, you can perform this in a script. But keep in mind that this padding is not part of the system image: it does not belong to any segment or section, it is just file padding.

Closing this issue


swap the positions of the prerequisites and dependencies in the prerequisite tree modal

Currently, the prerequisite tree is structured so that it shows the dependencies then the
actual course and then the prerequisites.

However, it would be better for the prerequisites to be on the left side to conform to left-to-right reading conventions.

Goal: figure out a solution in 2 weeks (10/19)


Discourse integration

Still needs enhancement/more testing but bulk of Discourse integration is completed

I'm going to go ahead and merge this for now. We can address bugs etc. in future PRs.


Call async flush method on KinesisProducer with each successful record

Issue #, if available: 307 (from amazon-neptune-tools repository)
Description of changes: Call async flush() method on KinesisProducer with each successful record. Fixes issue in which, in highly concurrent scenarios, records written down to Kinesis would overlap, creating unreadable Kinesis records.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Unicode errors in Kinesis Stream still remain under highly concurrent exports


swap the order of commenting panel and notification panel

Purpose
Swap the order of configure commenting and configure notification. Closes https://github.com/CenterForOpenScience/osf.io/issues/3944.
Changes
Before changes:

After changes:

Review complete - no bugs, and this PR makes no functionality changes. It only reorders a page.
:star:

This will no longer be necessary when https://github.com/CenterForOpenScience/osf.io/pull/3397 is merged.


pipenv doesn't work with locale encoding different than UTF-8 on Linux

Hi,
I wanted to try pipenv, but it doesn't work with the fr_FR locale.
Versions:

pipenv 2018.10.13
Python 3.6.6
Fedora 28

$ python3 -m venv env
$ env/bin/python -m pip install pipenv
$ LANG=fr_FR env/bin/pipenv install
Traceback (most recent call last):
  File "env/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/vstinner/env/lib64/python3.6/site-packages/pipenv/cli/command.py", line 249, in install
    editable_packages=state.installstate.editables,
  File "/home/vstinner/env/lib64/python3.6/site-packages/pipenv/core.py", line 1975, in do_install
    skip_lock=skip_lock,
  File "/home/vstinner/env/lib64/python3.6/site-packages/pipenv/core.py", line 1282, in do_init
    pypi_mirror=pypi_mirror,
  File "/home/vstinner/env/lib64/python3.6/site-packages/pipenv/core.py", line 708, in do_install_dependencies
    bold=True,
  File "/home/vstinner/env/lib/python3.6/site-packages/pipenv/vendor/click/utils.py", line 260, in echo
    file.write(message)
UnicodeEncodeError: 'latin-1' codec can't encode character '\u2026' in position 59: ordinal not in range(256)

It seems like pipenv likes non-ASCII characters for fancy output.

Emojis are not the only cause. Pseudographics used in a progress bar will cause the same kind of errors.

If you want French locale (or any other locale) in 2018 you should be using UTF aware locale like fr_FR.UTF-8. No one should use locale which is not UTF-8 aware. Even when you want C locale you should be using C.UTF-8.

This is unfortunate but you have to talk to Kenneth about it :( We really ought to just ignore them if they can’t be printed, but click also demands utf8 locale settings.
In the interim you can set PIPENV_HIDE_EMOJIS=1 to make things play nicely. Let me know if that helps, and thanks for taking the time to contribute.
I have to admit I’m curious to see what exactly you’re working on :)

If you want French locale (or any other locale) in 2018 you should be using UTF aware locale like fr_FR.UTF-8.

Well, it's just an example of locale. There are other locales which don't use UTF-8, but ASCII, ShiftJIS or anything else.

This is unfortunate but you have to talk to Kenneth about it :( We really ought to just ignore them if they can’t be printed, but click also demands utf8 locale settings.

Oh.

@vstinner I did just rewrite some of our output encoding to use translation maps and native encodings, so I’m wondering how I can solve this most helpfully. You certainly would know more on the subject so if you have any insight I’d be curious. Currently we basically use locale.getpreferredencoding() with some small hacks to avoid setting it on Linux.
To write output we essentially use this approach:
UNICODE_TO_ASCII_TRANSLATION_MAP = {
    8230: u"...",
    8211: u"-"
}

def decode_output(output):
    if not isinstance(output, six.string_types):
        return output
    try:
        output = output.encode(DEFAULT_ENCODING)
    except (AttributeError, UnicodeDecodeError):
        if six.PY2:
            output = unicode.translate(vistir.misc.to_text(output),
                                            UNICODE_TO_ASCII_TRANSLATION_MAP)
        else:
            output = output.translate(UNICODE_TO_ASCII_TRANSLATION_MAP)
    output = output.decode(DEFAULT_ENCODING)
    return output

I’m wondering if I shouldn’t just use an ignore errors re-encoding approach there

If the locale is C, it will be coerced to C.utf-8 by Python.
If the locale is not C and not utf-8 based, something is wrong (at least on Linux) and maybe the user just needs to be told (i.e. do what click does: abort).

@techalchemy looking at your code for fail-safe decoding/encoding of text it reminds me of one converter that I made in the past, which uses python's codecs.register_error. You can look at convert-encoding.py
The only downside with this approach is that you are registering this converter globally and if this technique is used by different modules then there is a chance of name collision if names are not carefully  chosen.

Thank you ;-)


Test: terminal editors should be marked as dirty when the shell has child processes

Refs: https://github.com/microsoft/vscode/issues/127193

[x] macOS @sandy081
[ ] linux @connor4312
[ ] windows @stevencl

Complexity: 2
Authors: @Tyriar, @meganrogge
Create Issue

We want to prevent users from accidentally losing their terminals that have running processes.

I assume that this functionality is available only for terminals in editor.

@sandy081 yes, but you can turn it on elsewhere with the terminal.integrated.confirmOnKill setting. Updating the issue to include that.


Update train_HOG.cpp

Instead of dealing with pos.lst and neg.lst files, now it is possible to give only name of directory as parameter to load_images function (and also vector of matrices).
This way, it will be possible to get absolute paths of each image (which files_in_directory function handles) in the directory and then read them one by one.

Removed trailing whitespaces.

there is a built-in function to get files as std::vector< String >  see cv::glob


add FastCGI protocol to support FastCGI-Client application

Background

just work as the role of FastCGI-Client
see: https://www.workerman.net/q/1806

Test cgi.php with PHP-FPM server

<?php
var_dump($_POST, $_GET, date('Y-m-d H:i:s'));

Simple Usage

<?php
use Workerman\Worker;
use Workerman\Protocols\FastCGI\Request;
use Workerman\Connection\AsyncTcpConnection;

require_once dirname(__FILE__, 1) . '/workerman/Autoloader.php';

$worker = new Worker();
$worker->name = "FastCGI-Client";

$worker->onWorkerStart = function($worker){
    $connection = new AsyncTcpConnection("fcgi://<IP_ADDRESS>:9000");
    $connection->onConnect = function($connection){
        $total_request = 100;
        for($i = 0; $i < $total_request; $i++)
        {
            $request = new Request();
            $request->setScript("/path/to/script/cgi.php")
                ->setRequestMethod('post')
                ->setKeepAlive(true) //default is true
                ->setQueryString(['k1' => 'v1'])
                ->setCustomParams(['k2' => 'v2'])
                ->appendCustomParams(['k3' => 'v3'])
                ->setContent(['number' => $i+1]);
            $connection->send($request);
        }
    };

    $connection->onResponse = function($connection, $response){
    };

    $connection->onMessage = function($connection, $data){
    };

    $connection->onClose = function($connection){
    };

    $connection->connect();
};

Worker::runAll();

About Output

The output from callback onMessage will look like this:
Array
(
    [requestId] => 99
    [status] => 200
    [stderr] =>
    [header] => Array
        (
            [X-Powered-By] => PHP/7.4.16
            [Content-type] => text/html; charset=UTF-8
        )

    [body] => 2022-07-15 13:12:04
array(1) {
  ["number"]=>
  string(2) "99"
}
array(1) {
  ["k1"]=>
  string(2) "v1"
}
string(19) "2022-07-15 21:32:04"
)

Besides,  we can get extra output by hooking the  onResponse callback, then we can read the Response Object as needed:
$connection->onResponse = function($connection, $response){
    var_dump(
        $response->getHeader(),
        $response->getBody(),
        $response->getStdout(),
        $response->getStderr(),
        $response->formatOutput()
    );
};

niubility

Niubility !!!

This prococol is in 4.0 branch but it isn't in latest 4.1 main branch.
I've copyed files from 4.0 to 4.1 and it's work