not an issue but opne pls

hi white rabbit the problem is solved and i cuurently forked this project now im gonna add a builder so far so good everything works and now make it fancy i hope this is okay!

hi white rabbit it is done and works completly i hope you can see it trhough and maybe we can collab ifyou want iam new to so dont expect much check my fork pls thanks!

Hello again, I don't know much about github forks , can we discuss this please in telegram. My telegram: t.me/shamiloneleo Thanks for everything ☺

Please write me in telegram about the project. How to make a collab in github and etc. I agree to the collab, thanks again!

Check the Triton_Rat readme, I added your builder also in my rat's readme file.👍🏻


Missing luaopen_bit32 with lua 5.4

Hello,
I just upgraded fedora to version 33 and got a problem with sol.
Compiler complains about nonexistent luaopen_bit32. From what I see, it's really missing in /usr/include/lualib.h
Version of lua is 5.4.1, version of sol is v3.2.2
Just including <sol/sol.hpp> should reproduce the bug.
I guess the #ifdef macro should be corrected but I don't know how.
My fix was to comment the line about bit32, but it's not a good solution.
BTW: thanks for the work, sol is awesome  and so easy to use :)

Looks like Lua 5.3 moved from the bits lib to just having actual operators (finally).
https://www.lua.org/manual/5.3/readme.html#changes
https://www.lua.org/manual/5.3/manual.html#3.4.2
Most likely this is being triggered by your code/project defining LUA_COMPAT_5_2 somewhere as the other two conditions are unlikely with Lua 5.4.x.
#elif (SOL_LUA_VESION_I_ == 502) || defined(LUA_COMPAT_BITLIB) || defined(LUA_COMPAT_5_2)

SOL_LUA_VESION_I_ should be getting set to SOL_LUA_VERSION which should be set to LUA_VERSION_NUM given that Lua 5.4.x will be 504.
LUA_COMPAT_BITLIB shouldn't exist/be set for 5.4.x as it no longer exists. (Also be sure your code/project isn't setting it manually.)

In fact in /usr/include/luaconf-x86_64.h I see
#define LUA_COMPAT_5_1
#define LUA_COMPAT_5_2

For the rest you are right SOL_LUA_VESION_I_ is 504 and LUA_COMPAT_BITLIB doesn't exist
I don't think I should un-define LUA_COMPAT_5_2 by hand.

That sounds like a possible bug with the package of Lua you are using and being misconfigured. The official 5.4.2 release of Lua does not define either of those in its included luaconf.h. Just one for 5_3 instead. luaconf-x86_64.h is also not a stock file part of Lua's package, so it sounds like a specifically maintained configuration setup for that given package.
luaconf.h is user-editable though from the main release, or can be configured with compiler switches. At the bottom of the file there is a comment/space made for user-specific edits. You can go into that part of the file and add:
#undef LUA_COMPAT_5_1
#undef LUA_COMPAT_5_2

Do you have a link to the exact package of Lua you use? Would be interested to see what they are doing with those compat flags when the official build of 5.4.x does not have them.

Why are they defining that but not providing the compatibility...?
That's pretty silly. But, I'll just.... scope the check down when it's not Lua 5.4. Here's to hoping we don't break anyone...

Sorry for late reply
I just checked where this file luaconf-x86_64.h comes from. It seems to be the official package of Fedora (33).
When I ask the list of files installed dnf repoquery -l lua-devel-5.4.2-1.fc33.x86_64, the file is listed.
Maybe it could be useful to see if people with other linux versions have this problem ?


Implement new sidebar navigation design.

What is the context of this PR?
The navigation bar has been redesigned for accessibility purposes.
This PR is a first stab at updating the styling to match the new design.
How to review
Check to make sure that it looks okay and behaves correctly.

Sections still a bit too tall, compared to the design:

In the design it looks as though page and section items are same height


BIBFRAME in Sinopia issue: WAU:RT:BF2:Classification RT nests inside the bf:Item classification property no matter what.

WAU:RT:BF2:Classification RT nests inside the classification property even if the value is an LCC number in a WAU:RT:BF2:LCC RT.
This was only noticed in one item, namely https://api.sinopia.io/resource/ea3c0026-c109-4e9e-9f2f-8aac27ae4f5b, so it may not be a problem for all items. Other items were not checked.

Is this a problem? This is how I thought things needed to be. If they should be different, how should they look @gerontakos ?

I can't tell re-open this evening. After I search in sinopia.io, I select "View" (the eyeball icon) and I get the following message with a light red background: "A suppressible template must have one property template."
As I remember it, the problem with this is that the value of bf:classification for this bf:Item was typed as bf:ClassificationLcc but in the RT is displays as bf:Classification in the bf:Classification RT. But since I cannot see it tonight I'm not totally sure.

I fixed the issue making it impossible to open stuff, can you see now?

We can call it fixed; however if the fix is easy, let's fix. The problem appears to be the same as we saw for bf:identifiedBy in issue #40.
The value of bf:classification is two nested RTs:
(1) WAU:RT:BF2:Classification. This is of course empty because it is not used here.
(2) WAU:RT:BF2:LCC. This is the correct RT with the correct value.

The empty RT is just part of the Sinopia display because it's an option to add it. Since it is empty, it doesn't cause any problems. You can see when you preview RDF that the data doesn't include the other RT that's possible here. Since we cannot repeat property templates in the same RT in Sinopia, there's no way to avoid the display looking like this.


Add stars to Galsim decoder

Need to investigate bug when training before merging (as this wasn't an issue before)

we found the bug, doing a double interpolation was somehow creating the error, see changes in psf_decoder.py  for resolution (basically dont' do a double interpolation in galsim)


don't constrain cyclic deps to build version

requires #406 to pass checks
fixes https://github.com/teaxyz/cli/issues/412
Basically if a dep requests the target (go.dev requires go.dev: '*'), this will prevent locked loop (build go.dev=1.20.1 trying to install go.dev=1.20.1)

k, so changing this code is dangerous. We better get it right.
Can you highlight what part of the code is failing per your failure spec?

Can you highlight what part of the code is failing per your failure spec?

No patch:
$ ./libexec/deps.ts go.dev~1.20 --build
go.dev must be bootstrapped to build go.dev
curl.se/ca-certs
gnu.org/m4^1
tea.xyz/gx/cc^0.1
openssl.org^1
go.dev~1.20

Patched:
$ ./libexec/deps.ts go.dev~1.20 --build
go.dev must be bootstrapped to build go.dev
curl.se/ca-certs
gnu.org/m4^1
tea.xyz/gx/cc^0.1
openssl.org^1
go.dev

go.dev requires go.dev: '*' to build. But it shouldn't require the explicit version being built (that's madness). Same for llvm.org on linux, iirc. Likely the others that are self-requiring.

I think the actual solution for the this is to hydrate the deps of go rather than go itself.
So this is a regression in brewkit.


List of usernames participating in the import

List here your OSM usernames, for details, read the import guideline

meetar_imports
:hand:

Alan_imports

omaru_imports

schleuss

@jschleuss according to the import guidelines we are supposed to create a separate account for imports... something like schleuss_imports

aaron_imports

palewire --> https://www.openstreetmap.org/user/palewire/

joemfox_imports

kyle_imports

ebenmccue_imports

priya_imports

Elebee_imports

deadlands_imports

https://www.openstreetmap.org/user/aquintero4354

https://www.openstreetmap.org/user/aquintero_imports

My user name is Dugi_Imports

thomas06037_imports

manings_labuildings

emamd_imports

kingrollo_imports

MtnBiker_imports

andrea_imports

(machiko_imports)[http://labuildingsimport.com/user/machiko_import]

ericpritchett_import

schmeltzer_import

kennethlee_import

anthonyjpesce_imports

WalkyTalkyLA_imports

bdon_import

michael_kirk_imports

planemad_imports

chetan_labuildings

jinalfoflia_labuilding

nikhil_labuildings

ruthmaben_labuildings

ramyaragupathy_imports

karitotp_labuildings

Rub21_labuildings

dannykath_labuildings

Luis36995_labuildings

samely_labuilding

RichRico_labuildings

calfarome_labuilding

ediyes_labuilding

mihaig_imports

kmw_import

ecoliteracy_import

Juhyun_import

ridixcr_import

scottgruber_import

ianlopez1115_imports

devolved_imports

maanya_imports

poornima_labuildings

piligab_labuildings

saikabhi_LA_imports

Jothirnadh_labuildings

nammala_labuildings

manoharuss_imports

[yurasi_import] (https://www.openstreetmap.org/user/yurasi_import)

wwtoonlinkfan_imports

upendra_labuilding

Fa7C0N_imports

BharataHS_laimport


Create Interests component

This component

We have decided against storing the users preferences. This feature may be implemented in the future.


Unable to pass Sercom Serial object into SBUS RX

I'm working on a project where I need to use a Sercom Serial port on a Feather M4 to decode and process a SBUS Stream. Passing the created Serial2 object into bfs::SbusRx sbus_rx(&Serial2)  compiles, but does not function. I believe the issue is caused by the library expecting a hardware serial port, but the Sercom port being a different type, but I'm not sure how to approach this, and any help would be appreciated. My full code is below:
sercom.txt
Thanks in advance,

Because every microcontroller handles inverted serial differently, if your microcontroller isn't listed, we start the bus with non-inverted serial. You probably need a serial inverter or some other access to the non-inverted SBUS data. Some receivers have hacks available to pull off the non-inverted data without needing to purchase a serial inverter.


ASAP-370 Fetch Resource and Data Sharing from CMS

Jira ticket: https://asaphub.atlassian.net/browse/ASAP-370
Designs:

User Productivity: CRN / Designs / Other Pages
Team Productivity: CRN / Designs / Other Pages

This first PR just adds the route to get resource and data sharing data, it does not connect to the frontend yet. The integration with the frontend will be addressed in a subsequent PR.

rebase master


refactor(typings): everything

Alright, here is some big improvements on the typings.
This shouldn't be merged before #74 and #75
Overview of the changes:

Moved test/ to test/js
Added new test/ts ported over from test/js
rimraf as a dependency and updated other crucial deps that are needed for building on the latest version of typescript
Build script in package.json to test new changes from now on, properly in typescript
Super charged typings!!!

Main key points:

cast, compose, composeWithFailure, product, range, tagged, taggedUnion, taggedWithInput, union, validate, and withInput are all typed with generics now to properly infer the type when passing them with a string or custom function.

That means no more:
compose(
	(m, s) => s.replace(/\s/g, ''),
	range(union('integer', 'emojint'), 0, 50)
) // -> any, great

compose(
	(m, s) => s.replace(/\s/g, ''),
	range(union('integer', 'emojint'), 0, 50)
) as string; // -> string, yay!!

and rather:
compose(
	(m, s) => s.replace(/\s/g, ''),
	range(union('integer', 'emojint'), 0, 50)
) // -> ArgumentTypeCaster<string>, yay!!

This can also be observed in other calls that involve type casting:
resolver.addType('1-10', (message, phrase) => {
	const num = resolver.type('integer')(message, phrase); // -> any, very sad again
	if (num == null) return null;
	if (num < 1 || num > 10) return null;
	return num;
});

but instead:
resolver.addType('1-10', (message, phrase) => {
	const num = resolver.type('integer')(message, phrase); // -> ArgumentTypeCaster<number>, very happy
	if (num == null) return null;
	if (num < 1 || num > 10) return null;
	return num;
});

Removed almost all possible return values that included any and made them unknown as of typescript convention starting with 3.5

The .get() method on the Providers now accepts a generic or defaults to unknown

This is useful when grabbing things from the built-in providers without having to needlessly typecast them (microsoft uses the same method in some of their APIs)
this.client.settings.get('someKey'); // -> any, I'm sad now :(

this.client.settings.get('someKey') as string; // -> string, yay! (but still a bit sad :()

but instead:
this.client.settings.get<string>('someKey'); // -> string, yay! (actually happy :))

This has a minor drawback though, because of the any ->  unknown change, anyone who does not use the generic method will always get a unknown return type when using typescript. But hey, you should be using that anyway, any returns are dirty!

forgot to make it an array in https://github.com/discord-akairo/discord-akairo/pull/76/files#diff-b739f95ace6bbf2f0fd5e8cf1dab97d8R684 compared to the original in https://github.com/discord-akairo/discord-akairo/pull/76/files#diff-b739f95ace6bbf2f0fd5e8cf1dab97d8L630


Update doc for feature ClusterWideCredentials

@wangcai0124 : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@wangcai0124 These updates should be don in our internal repo, since we're all MSFT employees.  Can you open a new PR in azure-docs-pr?  Thanks.  #please-close


sink.http: set default=10 for parallel

I'd change the commit title by following instead
sink.http: increase parallel pool size
or something like that

I'd change the commit title by following instead
sink.http: increase parallel pool size
or something like that


Consumer hanging after a broker gets down

Trying the library, I set the following situation:
Five brokers in the kafka cluster, one producer and two consumers over one topic.
If I stop one of the brokers, the producer get some warning messages and after some seconds, restarts its normal behavior with no problem. The consumer, on the other side, fails with a Socket Disconnect exception on a different thread, leaving the process alive, but not doing anything.
Using what I saw on the producer code, I modified the consumer to use a similar approach:
https://github.com/appsoma/pykafka/pull/2
However, I'm not sure if there were a reason to the behavior of the consumer, if my code breaks something else or if it doesn't fit the code philosophy that you're following.
Excuse my poor English, please.

I have encoutered this problem too. I think it is a bug of broker connection. When a Socket Disconnect exception happens, it will disconnect the broker connection, and it will never re-connect. I think it should check the connection to broker is still alive. If not, re-connect it.

Current master now immediately raises an exception if a broker goes down, which at least allows the client code to catch the exception and reinstantiate the consumer. A more complete fix will involve smartly retrying fetch requests after updating broker metadata. This effort will be tracked in this ticket.


Bug: Duplicate 'sideEffects' entries on kube-enforcer's webhooks

Mutating and Validating webhook configurations have duplicate entries for sideEffects, introduced in https://github.com/aquasecurity/aqua-helm/commit/0081cbcbfa69b8859244c7b1930804f65c26f497
These duplicate entries cause validation errors when deploying with flux helm-controller
Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
  line 35: mapping key "sideEffects" already defined at line 20

This isn't the first occurrence, similar issues have been reported and fixed before, see:
https://github.com/aquasecurity/aqua-helm/issues/608
https://github.com/aquasecurity/aqua-helm/issues/483
After correcting this issue perhaps another issue should be created to add a strict linter action to prevent this from happening again.
Something that would run helm template, followed by kubeconform  -strict -ignore-missing-schemas which currently produces
MutatingWebhookConfiguration kube-enforcer-me-injection-hook-config failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors:
  line 33: key "sideEffects" already set in map
ValidatingWebhookConfiguration kube-enforcer-admission-hook-config failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors:
  line 48: key "sideEffects" already set in map

Hi. I would like to know what is the expected timeline to release a new Chart version that includes this fix ?


Update tutorial-migrate-physical-virtual-machines.md

Correcting the title. Current title makes it sound as though you can migrate and run servers as physical / baremetal servers in Azure which is incorrect.

@bsiva : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @bsiva - PMs should work in the private repo. Would you make this update in a PR in the private repo? We'll close this PR. Thanks.


Fixed FlowSOM on Docker Image

If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Adds the line to include the original FlowSOM back into the Docker.
How did you implement your changes
Adjusted Dockerfile.
Remaining issues
None.

The first flowsom installs the dependencies that the forked version uses. The PyPI error is fine. There is a v0.4.1 that for uploaded earlier today.

kk sounds good, you can do that from travis right?

kk sounds good, you can do that from travis right?

Yup


[GFX11][tests] New target additional list file changes

target addition list file changes

@muralinr Please prepend [GFX11][tests] to the title of this PR.

@muralinr Please insert
message(STATUS "MIOPEN_TEST_GFX110X ${MIOPEN_TEST_GFX110X}")

just after this:
message(STATUS "MIOPEN_TEST_GFX103X ${MIOPEN_TEST_GFX103X}")

@junliume @muralinr [Important] No custom tests are enabled for the new target right now. Should we enable the same custom tests as for the GFX103X? I can make a PR for this.

@junliume @muralinr [Important] No custom tests are enabled for the new target right now. Should we enable (approximately) the same custom tests as we have for GFX103X? I can make a PR for this.

Yes Artem. Can you please make a PR?

@muralinr #1925 created, this PR can be closed now.
Can you please #1925 it on the appropriate target and make sure it passes our CI? Thanks! In case of any problem please let me know or fix it yourself. In order to make changes in my PR, please accept the invitation to my fork of MIOpen, https://github.com/atamazov/MIOpen (I've sent the invitation several mins ago). Then you'll be able to git remote add atamazov_miopen https://github.com/atamazov/MIOpen, pull branches from there, edit and push them back as usual.
[Informative] If you're curious, I am unable to create branches in this repo due to lack of privileges.


Fix yak optional ouputs

@byoo validated the logic for yak now. Had to do some reverts so that you will have to provide an empty array for parents for singleton cases, but overall should work.
@williamrowell Ready to merge

Merged @byoo

@vsmalladi, the testing failed with the following errors. Thank you.

2022-10-23 16:36:20,073 cromwell-system-akka.dispatchers.engine-dispatcher-95042 INFO  - WorkflowManagerActor: Workflow d30d641a-8596-4a4c-826e-df67d5451172 failed (during ExecutingWorkflowState): java.lang.RuntimeException: Failed to evaluate 'yak_af_output' (reason 1 of 1): Evaluating if defined(yak_af.yak_output) then yak_af.yak_output else [("None", "None")] failed: No coercion defined from wom value(s) '[[]]' of type 'Array[Array[Pair[String, File]?]]' to 'Array[Pair[String, File]]'.
at cromwell.engine.workflow.lifecycle.execution.keys.ExpressionKey.processRunnable(ExpressionKey.scala:29)
...
java.lang.RuntimeException: Failed to evaluate 'yak_uf_output' (reason 1 of 1): Evaluating if defined(yak_uf.yak_output) then yak_af.yak_output else [("None", "None")] failed: No coercion defined from wom value(s) '[[]]' of type 'Array[Array[Pair[String, File]?]]' to 'Array[Pair[String, File]]'.
...


Downloading transcripts for later reading?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
Is it possible to batch download video transcripts in text format for later reading? Want to download some playlists of TedEX lectures transcripts in readable text format. how i can do this? I am only able to download those srt with text with timestamp.

You can download only the subtitles and then convert them to plain text.


Access VM enhancements

There are three access modes currently supported: VNC, SSH, HTTP.
1. VNC console access mode
For VNC console a user must see:
Login: {csui.vm.login|root}
Password: {csui.vm.password|Not Set}
Open VNC console (clickable link)

2. SSH access mode
This mode is the default option for Unix. This access mode is defined by template tags:

csui.vm.auth-mode = SSH
csui.vm.ssh.login = login
csui.vm.ssh.password = password
csui.vm.ssh.port = port

If no csui.vm.auth-mode=SSH then no helper is shown for SSH, otherwise there are two options:

Webshell plugin is not deployed - no webshell launch link (see (2) pic. attached).
Webshell plugin deployed - (1) and webshell launch link displayed.

Show Connection string (IPv6) and IPv6 if supported (see (2) pic. attached). If IPv6 not supported don't show IPv6 strings.
If no SSH key installed, do not show SSH key string
If webshell is deployed, it must open in a new window, not VNC window.
For SSH mode a user must see:
Connection String (IPv4): ssh -p{csui.vm.ssh.port|22} -u{csui.vm.ssh.login|csui.vm.login|root} <vmipv4> (copy)
Connection String (IPv6): ssh -p{csui.vm.ssh.port|22} -u{csui.vm.ssh.login|csui.vm.login|root} <vmipv6> (copy)
IPv4: <vmipv4>
IPv6: <vmipv4>
Port: {csui.vm.ssh.port|22}
Login: {csui.vm.ssh.login|csui.vm.login|root}
Password: {csui.vm.ssh.password|csui.vm.password|Not Set}
SSH Key: name
Open WebShell (clickable link)

3. HTTP access mode.
This mode is useful for templates with ready to use web systems deployed, like Wordpress, etc. It's regulated by next variables:

csui.vm.auth-mode = HTTP
csui.vm.http.protocol = HTTP|HTTPS
csui.vm.http.port =
csui.vm.http.path =
csui.vm.http.login =
csui.vm.http.password =

For HTTP mode a user must see::
Login: {csui.vm.http.login|csui.vm.login|root}
Password: {csui.vm.http.password|csui.vm.password|Not Set}
Open URL: lowercase({csui.vm.http.protocol|http})://<vmip>:{csui.vm.http.port}{csui.vm.http.path|/}

if no csui.vm.http.port, then if csui.vm.http.protocol = HTTPS: 443, if HTTP: 80.
If no csui.vm.http.protocol then HTTP.
4. In certain cases all three access modes can coexist. E.g. for template tags:
csui.vm.auth-mode=HTTP,SSH
csui.vm.http.protocol=HTTP
csui.vm.http.login=Admin
csui.vm.http.password=zabbix
csui.vm.ssh.port=22
csui.vm.ssh.login=appliance
csui.vm.ssh.password=zabbix

All three helpers must coexist (see mockups)
If there is one or two modes not available, disable the tab

csui.vm.auth-mode=HTTP,SSH - support space between HTTP and SSH values -> csui.vm.auth-mode=HTTP, SSH

6. Please, approve mockups with PM before implementation
Connected feature ID: vm_postcreation_ISO, vm_postcreation_SSH, vm_postcreation_HTTP, vm_accessvm
Mockup

Connected to #1226

To test:
vm_postcreation_ISO, vm_postcreation_SSH, vm_postcreation_HTTP, vm_accessvm

Lack:1
1) The SSH key name is displayed separated by a comma if there is a space in the name
If the name of the SSH key consists of several words and there is a space between the words, in the "Access VM" window on the "WebShell" tab a key with a comma between the words will be displayed. It seems that the VM has several keys.
Steps:

Create SSH key with several words in the name (add space between words in the name)
Create new VM with created SSH key
Add tag "csui.vm.auth-mode: SSH" in created VM
Go to "Access VM" window of created VM on "WebShell" tab

Actual result: Field "SSH-key" contains a value with a comma between words (Screenshot)
Expected result: Field "SSH-key" contains a value without a comma between words
Screenshot:

2) The requirement of lowercase to the link "Open URL" in "URL" tab is not met if the values entered in the tags are uppercase
Steps:

Create new VM
Add following tags to VM:

csui.vm.auth-mode: HTTP
csui.vm.http.protocol: HTTP
csui.vm.http.path: PATH

Go to "Access VM" of created VM on "URL" tab

Actual result: Values from tags are uppercase in "Open URL" link (screenshot)
Expected result: All symbols in "Open URL" link are lowercase
Screenshot:

3) The default value is incorrect for HTTP port when HTTP protocol is "HTTP"
The default port for the "HTTP" protocol is 80, for the "HTTPS" protocol is 443
Steps:

Create new VM
Add following tags to VM:

csui.vm.auth-mode: HTTP
csui.vm.http.protocol: HTTP

Go to 'Access VM" of created VM on "URL" tab

Actual result: Default port for the 'HTTP" protocol is 443 (screenshot)
Expected result: Default port for the 'HTTP" protocol is 80
Screenshot:

4) The system is blocked and an error appears in the console if you click on an incorrect "Open URL" link
By blocking the system means that requests to the API are not sent. For example, you cannot stop a VM or grouping VMs in a list.
Steps:

Create new VM
Add following tags to VM:

csui.vm.auth-mode: HTTP
csui.vm.http.port: asdasdasd (invalid value)

Go to 'Access VM" of created VM on "URL" tab
Click to "Open URL" link (screenshot)

Actual result: System is blocked, an error is in the console
Expected result: System is not blocked, an error is in the console
Screenshot:

@ershovaelena
When URL (in URL tab) is invalid an error appears and URL non-clickable


"chroot" scanning

Nice tool :)
It'd be even nicer to be able to restrict dependency lookup to a specific root. It'd be particularly useful for scanning extracted filesystems.
For example:
./binscan scan -R extracted_fs/
would consider a reference to /lib/ld.so as extracted_fs/lib/ld.so

Oh, you're speaking about the --chroot feature, that appears to be undocumented in the readme :-) I'll add a word about it.

@trou can you review  #3 that improves the doc relative to the --chroot flag?

Thx.


Can't work in visual after changing keymap

When I do not add additional configuration, the default gJ and gS work in visual mode well. However After I changing keymap like the following
let g:splitjoin_split_mapping = 'cS'
let g:splitjoin_join_mapping  = 'cJ'

cS and cJ only work in normal mode, and only can work on one line.
environment: neovim 0.8

When I do not add additional configuration, the default gJ and gS work in visual mode well.

There's no particular action that splitjoin takes in visual mode, unless I've forgotten something big. When I test the default mappings locally, gJ just does the default visual mode mapping :help gJ. I don't think gS in visual mode does anything. Could you describe what is happening for you? What does "work well" mean for your setup? Maybe you could share a screencast video or something?

Sorry for my bad expression. It works well mean: when I visualize multiple lines and press gJ, it can join all visualized lines. However when I change the key from gJ to sJ then nothing happen when I do the same thing.
But I may understand it wrong. I find that the gJ in visual mode is the builtin command but not taken by splitjoin. gJ and gS from splitjoin only work in normal mode.
Closed. Thanks for your kind reply.


Add support for hostname validation

As of OpenSSL 1.0.2 there is hostname validation available. It's only 3 imports needed to take advantage of this, and it makes using OpenSSL much nicer for secure TLS!
It'd be nice to bind at least the 3 procedures used in this example.
https://wiki.openssl.org/index.php/Hostname_validation

For reference this how I'm currently exposing this functionality. https://github.com/glguy/irc-core/blob/hookup/hookup/src/Hookup/OpenSSL.hsc

I'm new maintainer of HsOpenSSL. Please reopen this issue in the new repo https://github.com/vshabanov/HsOpenSSL
It would be great if you could provide a pull request with this functionality.


Conflict with others lambda layers

This issue is related to opentelemetry-lamba for NodeJS.
My project is using Sentry to report all unhandled errors. We integrated Sentry into our project by using the official lambda layer. On top of it, we included this opentelemetry-lambda layer and we run into some issues. I was interested in the auto instrumentation opentelemetry provides, more specifically the one that collects traces regarding all http outgoing calls. It was not working and I figured out it was related to https://opentelemetry.io/blog/2022/troubleshooting-nodejs/#enable-before-require.
Afer some investigation, I understand sentry code was required before opentelemetry, mainly because of this https://github.com/open-telemetry/opentelemetry-lambda/blob/main/nodejs/packages/layer/scripts/otel-handler#L3.
Are there is any reasons why we don't define the ordering that way?
export NODE_OPTIONS="--require /opt/wrapper.js ${NODE_OPTIONS}"

It used to be that way, but was changed to allow the wrapper itself to be configured.  Perhaps there's a third way?
export NODE_OPTIONS="${OTEL_WRAPPER_OPTIONS} --require /opt/wrapper.js ${NODE_OPTIONS}"


executor holds on to dll after test run

Description
Unable to build because vstest.executionengine.x86 holds on to dlls after test run completes
Steps to reproduce
Right click on a test class and select "Debug Test" from the right click menu.
Expected behavior
Project rebuilds and debugs test
Actual behavior
Build fails because dlls cannot be copied
Environment
dotnetcore 2.0 project
Visual Studio 2017.3 Preview1

Can you please share csproj, Theoretically vstest.executionengine.x86 should not be involved in dotnetcore 2.0 project. I was unable to repro for net452 framework by following repro steps.


Videos don't load on mobile

As a result of this issue being rooted in an intentional iOS decision, I've opted to remove videos from mobile.

See: https://github.com/danielmaxsiegel/dms-personal-site/pull/15


Codegen ignores not referenced components

go structs are not generated for objects in components.schemas not referenced anywere
(they exists in spec because there is method with multipart/form-data and server code needs these models to decode form fields)

This is expected behaviour
If you have a look for the output-options.skip-prune, this will override this behaviour and generate schemas that aren't directly used


error in run_audio_attack.py

ValueError: Input tensor 'ExpandDims:0' enters the loop with shape (1, 11), but has shape (1, ?) after one iteration. To allow the shape to vary across iterations, use the shape_invariants argument of tf.while_loop to specify a less-specific shape.
When I run  run_audio_attack.py, I got an error list above.How to solve it ?

Hi,
It seems the DeepSpeech repo has been updated since this work was done. Could you try following the suggestion in https://github.com/rtaori/Black-Box-Audio/issues/4 ?

I can pass the make_checkpoint.py, so I don't think the error casued by version.

Right yes, but run_audio_attack.py still makes calls to the DeepSpeech library, so if anything there has changed then it could break the program. Could you try reverting to the commit specified in #4? I have tested it on that version so it should work.

hi @zhangdong1992,
I have updated the installation instructions with much more detail in the README.
Please follow the steps there and open another issue if you still have any problems.


Migrate plonky2_evm -> evm_arithmetization

This is just purely git subtree split + git subtree add + renaming.
I'll add a global workspace Cargo.toml + all the necessary adjustements and relative path for dependencies right after.
I think we should also move the evm specs into the docs folder.

I think we should also move the evm specs into the docs folder.

Agreed

Sorry for the force-pushes, had forgotten to update a few things within the evm_arithmetization crate itself to get CI passing and was lazy to test locally 😆.
@muursh We should probably split the CI workflow, to have each crate tested independently (also easier for bug tracking if we're touching several at once). Once this is done, could you add some branch protection rule on main? Typically required CI jobs + at least 1 reviewer approval I'd say, + anything that you'd like to have.


Fix: delete the secret of the cluster

Signed-off-by: suwanliang_yewu<EMAIL_ADDRESS>Description of your changes

Fixes #5467
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Please handle go/lint and go/ check-diff error

/cc @wonderflow


Consider giving a name to current default transition mode and

What problem does this feature solve?
1. The current default has no name
There is no name for the current default. Logically it should be called something like simultaneous (hard to spell, I know), but currently there seems to be no name for it that could be documented in a quick reference, talked about with other developers and easily remembered.
Now, since this isn't really documented, I don't know how to handle the following scenario: I'm switching between transition modes programmatically, in which case my list of valid transition modes looks like this:
const modes = ['', 'out-in', 'in-out'];

That's really weird. This is how I think it works, but TBH I'm not completely sure. Based on my experience this doesn't happen often, but I could imagine wanting to do this e.g. for certain routes dynamically.
I think it's just generally a good practice to provide a list of valid values for parameters like this, and explicitly point out which one is the default.
2. Better global default for most common use cases
As a little bit of background, I'm a UX designer and a FE dev, and have worked a lot on delivering motion design for devs on multiple platforms. I have been using Vue in tons of projects for a while now, and one of the things I'm most happy with is the transition system. It makes regular work with transition animations very easy, by far the most pleasant experience of all the JS frameworks or native platforms, and it makes implementing a satisfying level of transitions from the get-go very easy by reusing named transitions.
I've noticed that the vast majority of use cases in practical development scenarios are either A) conditionally rendering one element or B) switching between two elements.
In scenario B, out-in is almost always the desired mode, but it needs to be explicitly set every time <transition> is used. out-in does not seem to affect scenario A. It's frustrating to manually have to set out-in each time, and forgetting this easily leads into hard-to-catch mistakes.
Since out-in is not the default, new developers have to learn more of the intricacies of transition modes before they can be effective with scenario B transitions, even though they don't have to care about the mode with scenario A. I think we could cover both scenarios better by having out-in as the default.
Of course the desired mode always depends on the specific art style and specific animations desired. However even as a designer I think out-in is a much better default, since transition specs (generally speaking) are broken into one element's exit transition and the entry transition of the next one. From this perspective it would make sense that by default these animations are played in succession. The dev should add an extra parameter to make them happen simultaneously, since this introduces more considerations for how to handle the state of both elements being in the DOM at the same time.
Other notes
I'm sure this has been considered by the dev team before, and there are also good reasons for the current default. I think the best solution would be to be able to set the default transition mode in the global configuration on a project-to-project basis. I wouldn't mind configuring this with a Vue.configuration.defaultTransitionMode = 'out-in' one-liner, and this would let me as a dev make a conscious choice about this that reflects the design of my current project.
These are two individual requests, but I think they do go together to some extent, and naming the current default would be needed in order to support a configuration parameter for this I guess.
(To clarify, this request is not the same as #4453)
What does the proposed API look like?
Vue.configuration.defaultTransitionMode = 'out-in';

// ...

const modesToToggle = ['simultaneous', 'out-in', 'in-out']

// ...

<transition mode="simultaneous">

Any value that is not out-in or in-out is treated as default, so you can already do what you want.

Oh nvm, yeah we have validations in place. Honestly though, I don't think we will change the current behavior because the value it provides is somewhat subjective while introducing API churn.

Are you saying I can change the default somehow? I don't think I can.
Like I stated above, I do understand the this is somewhat subjective, but for the reasons I mentioned I think we should look at what the most common use cases are and consider changing the default. I opened the issue since I've noticed the same pattern repeat itself in practically all of my Vue projects (which are quite varying). The vast, vast majority of the <transition> elements I write are using out-in with the other modes being rare exceptions.
Would love for others to pitch in, if the issue can be kept open. I didn't really understand the API churn point.

Changing the default is a breaking change. Breaking change for subjective reasons is a no-go.

I was proposing the configuration parameter for setting the default on a project-to-project basis for exactly that reason. I guess I'll provide a set of wrapper components for my guys to easily avoid the common mistakes with this in the future. Gets us around having to actually deal with the mode parameter altogether.

I don't think it's a default worth adding a config option for though. The hoc solution looks nice imo


cicero-cli should support creating an archive, or testing using an archive

Creating an archive has been implemented and testing using an archive is covered by #135


Validate image tag on build

Validates the output tag argument using docker's validation code.
Output:
$ s2i build . openshift/origin-release:golang-1.8 MyImage:Tag
ERROR: Invalid value specified for "tag": repository name must be lowercase
...
[ command help ]

Fixes https://github.com/openshift/source-to-image/issues/826

@openshift/sig-developer-experience ptal

lgtm
[merge]

Fixed broken unit test

Seems like an unrelated error in the merge tests:
I1113 12:55:38.277368    4581 sti.go:681] [INFO] Downloading: https://repo1.maven.org/maven2/org/jboss/spec/jboss-javaee-7.0/1.0.3.Final/jboss-javaee-7.0-1.0.3.Final.pom
I1113 12:55:38.705197    4581 sti.go:681] [ERROR] [ERROR] Some problems were encountered while processing the POMs:
I1113 12:55:38.705224    4581 sti.go:681] [ERROR] Non-resolvable import POM: Could not transfer artifact org.jboss.spec:jboss-javaee-7.0:pom:1.0.3.Final from/to central (https://repo1.maven.org/maven2): hostname in certificate didn't match: <repo1.maven.org> != <repo.maven.apache.org> OR <repo.maven.apache.org> @ line 66, column 25
I1113 12:55:38.705233    4581 sti.go:681] [ERROR] 'dependencies.dependency.version' for javax.enterprise:cdi-api:jar is missing. @ line 79, column 21
I1113 12:55:38.705243    4581 sti.go:681] [ERROR] 'dependencies.dependency.version' for org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar is missing. @ line 87, column 21
I1113 12:55:38.705250    4581 sti.go:681] [ERROR] 'dependencies.dependency.version' for org.jboss.spec.javax.servlet:jboss-servlet-api_3.1_spec:jar is missing. @ line 94, column 21
I1113 12:55:38.705256    4581 sti.go:681] @
I1113 12:55:38.711950    4581 sti.go:681] [ERROR] The build could not read 1 project -> [Help 1]
I1113 12:55:38.711965    4581 sti.go:681] [ERROR]
I1113 12:55:38.711972    4581 sti.go:681] [ERROR]   The project org.wildfly.quickstarts:wildfly-helloworld:10.0.0-SNAPSHOT (/opt/app-root/src/pom.xml) has 4 errors

@bparees do you know whether this is something ephemeral that should be retried or are we broken due to an image change?

@bparees do you know whether this is something ephemeral that should be retried or are we broken due to an image change?

Seems like we're broken due to a certificate change.  The wildfly example or wildfly image might need to be fixed to clean up repository references?

looks like the cert is fixed.
[merge]


alert-rules: add rules for deployment state check

(see MR-88)

If we add these alert rules to this repo, we should probably also open source the check scripts.

as discussed, the scripts will be kept in the other repo for now and published at a later date


change the behavior of paste to prompt user instead of renaming pasted files

Please describe the problem you're trying to solve
I copy/pasted multiples files via y / p  in a folder that contained files with the same filename (actually it was an earlier partial copy/paste).
I was expecting for yazi to override the filenames but instead it renamed the pasted files and suffixed them with _1 if I remember correctly.
I looked if I could achieve that with the current config and I can with https://yazi-rs.github.io/docs/configuration/keymap#manager.paste --force
Having this as a default can be tricky though. You might override a file without realizing it. Same for the current behavior, you might think you overrode the file but instead yazi pasted a renamed file.
Would you be willing to contribute this feature?

[ ] Yes, I'll give it a shot

Describe the solution you'd like
I think a better default would be to prompt the user wether to overwrite existing file (maybe on a per-overwrite basis), akin to paste --conflict=prompt  (--force could become --conflict=prompt)
Additional context
No response

Could be a single prompt "Override all files (y/n)" then ? the current default behavior created lots of file I didn't want to be created and I had then to clean them up manually.

I didn't quite understand what you meant. Are you saying that when encountering the first conflicting file, a confirmation prompt will appear, and if the user confirms, all conflicting items will be overwritten, otherwise they will all be appended with "_"?
If so, there is still a possibility of accidental activation because this confirmation prompt may appear at an unexpected time for the user. It is different from a deletion confirmation, which occurs after the user action and before progress begins, while the copy confirmation can occur at any time after the progress begins, because the entire process is async for the user.

Closing as not in the plan


Email refactor + improvement

I've added in a 'confirmation email' , which gets sent when an order is placed, but not yet paid for. Receipt is sent after payment.
Also added a AdminNotification email. The email notification to the admin sometimes needs to be different.
Refactored OrderProcessor email stuff into its own class.
Updated docs

I like this. Breaking this out into it's own class is a good design decision. My only question would be - is it worth keeping the sendEmail methods in OrderProcessor to maintain backwards compatibility? They could be deprecated and just call out to OrderEmailNotifier to keep things DRY. Either way is fine by me, but if this merges as is I know I'll have to change some code in my current project so I'd expect others might as well.

Yup - I like the deprecation idea. I guess if we're going semantic versioning, then it'll be removed in version 2 of the module...does that sound right to you?

Sounds like a good plan, Jeremy.

@markguinn I've resubmitted with deprecated functions included.

Sorry, @jedateach I just noticed you'd resubmitted this. There's nothing stopping us from merging this is there? It all looks good to me. The only question that came up as I was having another look is whether we should keep the Order_ReceiptEmail etc classes around and mark them as deprecated. If someone were refering to those in their code that would cause a break where it won't hurt anything to leave them around and remove them entirely in 2.0.

@markguinn I've added in the deprecation notices to the doc blocks of the classes.


Clarify the behavior of BIO_gets() a bit more

bss_file.c's implementation provides a nice property that BIO_gets() always fills the buffer with something that is safe to interpret as a (NUL-terminated) C string.  Rather than having people discover this by accident and come to rely on it, make it the official documented behavior, so that any BIO implementations discovered to have other behavior will be declared buggy and fixed.
bf_buff.c also appears to provide this property from cursory inspection, though I did not do a full review.

+1  we'll find bugs :)

+1

pushed thanks!


Hydration issues still exist with NextJS when applying custom themes

Steps to reproduce
Link to live example: (required)
Steps:

Create next app using next 14 and node 18
install mui joy
follow the steps outlined in the docs for creating a theme and preventing hydration issues

Current behavior
inside of apps/layout.tsx:
import type { Metadata } from 'next';
import { Inter } from 'next/font/google';
import './globals.css';

import CONSTANTS from '@/CONSTANTS';
import ThemeRegistry from '@/core/theme/ThemeRegistry';
import { getInitColorSchemeScript } from '@mui/joy';

const inter = Inter({ subsets: ['latin'] })

export const metadata: Metadata = {
  title: CONSTANTS.COMPANY_NAME,
  description: CONSTANTS.COMPANY_DESCRIPTION,
}

export default function RootLayout({
  children,
}: {
  children: React.ReactNode
}) {

  return (

      <ThemeRegistry options={{ key: 'joy' }}>

          {getInitColorSchemeScript()}
          {children}
      </ThemeRegistry>

  )
}

Inside of @/core/theme/ThemeRegistry (straight from the docs), with the exception that I've added my ApolloProvider.
'use client';

import useApollo from '@/core/hooks/useApollo';
import { ApolloProvider } from '@apollo/client';
import createCache from '@emotion/cache';
import { CacheProvider } from '@emotion/react';
import CssBaseline from '@mui/joy/CssBaseline';
import { CssVarsProvider } from '@mui/joy/styles';
import { useServerInsertedHTML } from 'next/navigation';
import { useState } from 'react';
import theme from './theme';

export default function ThemeRegistry(props) {
  const { options, children } = props;
  const apolloClient = useApollo();

  const [{ cache, flush }] = useState(() => {
    const cache = createCache(options);
    cache.compat = true;
    const prevInsert = cache.insert;
    let inserted: string[] = [];
    cache.insert = (...args) => {
      const serialized = args[1];
      if (cache.inserted[serialized.name] === undefined) {
        inserted.push(serialized.name);
      }
      return prevInsert(...args);
    };
    const flush = () => {
      const prevInserted = inserted;
      inserted = [];
      return prevInserted;
    };
    return { cache, flush };
  });

  useServerInsertedHTML(() => {
    const names = flush();
    if (names.length === 0) {
      return null;
    }
    let styles = '';
    for (const name of names) {
      styles += cache.inserted[name];
    }
    return (


Upgrade typedoc

Upgrade typedoc and remove the custom theme. Custom themes no longer work the same in typedoc 0.22 and later and we don't want to be stuck on an old version. We have the option of adding custom styles in the typedoc.css file, for a lightweight styling approach.

A screenshot:

IMO this looks just fine.


Correct handling of IRIs and strings in expressions and CSV export

TODO:
There is now a discrepancy between prefix regexes and "normal" regexes.
Discuss with Hannah what to do about this.

Commit message:
The CSV format now correctly implements the SPARQL standard according to
https://www.w3.org/TR/sparql11-results-csv-tsv/. Most notably, literals are serialized without
language tags and datatypes, and typically without quotation marks (see below). IRIs are serialized without angle brackets. Quotation marks are only used to escape IRIs or literals according to RFC4180, but not to distinguish IRIs from literals. This fixes #911.
Also SPARQL expressions that work on strings now only see the inner content of a literal or IRI (no datatypes, language tags, quotation marks, or angle brackets). For example, the result of a
GROUP_CONCAT that previously was "lit1"@en, "lit2"@fr is now correctly lit1, lit2.
For REGEX expressions, one now has to explicitly use the STR function when also wanting to search IRIs and numeric values. As long as the call to STR is directly inside the regex expression, this is implemented efficiently. See the following two examples:
REGEX(?x, "bla")  matches "blabla"@en, but not
REGEX(STR(?x), "bla") matches both of the above.
BIND (STR(?x) as ?strx)
REGEX(?strx, "bla") matches both, but is inefficient, because the resulting strings of the STR
function are always fully materialized.
The following related issues are still left open:

A similar handling of the STR function should be used in all other functions that work on strings. For example, currently the STRLEN function currently always behaves like STRLEN(STR(...)).
Prefix regexes are currently unable to match numbers and other values that are encoded in the ID, and also are unable to match entries in the local vocabulary.


Update readme.md to fix a typo for the product ColdFusion

[URL to the list here.]
[Explain what this list is all about and why it should be included here.]

[ ] I have read and understood the contribution guidelines and the instructions for creating a list.
[ ] This pull request has a descriptive title. (For example: Add Node.js)
The list I added

[ ] has been around for at least 20 days,
[ ] is not a duplicate,
[ ] only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
[ ] contains the awesome badge on the right side of the list heading,
[ ] has a Table of Contents as the first section,
[ ] has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
[ ] has contribution guidelines,
[ ] has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a dot, and consistent naming),
[ ] has been added at the bottom of the appropriate category.

The F in ColdFusion needs to be capitalized.

Can you please use a descriptive PR title.

Wow.... really? I mean I get the reason but... wow.

Done.

Wow.... really? I mean I get the reason but... wow.

?

Sorry - I was being a bit snippy about you asking me to edit the PR title for such a minor typo fix. ;)

It's a minor typo fix, true, but Update readme.md is totally useless in a git history and will waste people's time down the line.

Fair enough. As it stands - I just took the defaults Git provided me when I hit the edit button.


not support vuex this.$store.dispatch('xxxx') in ios, web is normal

Describe:  i want use vuex in weex project,  store.getter is normal, but i use modify store state this.$store.dispatch('update', {token:'i`m token'})  web is normal, but ios doesn`t happen
Weex_Vuex_Demo

Device: iPhone8
OS: iOS12.2
Build from source yes

i found anwser


The culture problem has been fixed

During the mapping phase, I encountered a problem caused by the local culture. The ToLower and ToUpper methods needed to be changed to ToLowerInvariant and ToUpperInvariant. I fixed this and the unit tests also ran without issue.

@mehmetemineker Thank you very much! :)


Fresh install cannot create Collections

I have a fresh install of Bruno and I cant seem to be able to create any Collections.
My system is
Static hostname: pop-os
Icon name: computer-laptop
Chassis: laptop
Operating System: Pop!_OS 22.04 LTS
Kernel: Linux 6.5.6-76060506-generic
Architecture: x86-64
Hardware Vendor: Lenovo
Hardware Model: ThinkPad P14s Gen 1

I installed bruno from the Pop!_Shop which installed version v1.5.1
When I choose my location I navigate to my Documents folder which is located at:
/home/angus.ross/Documents but when after selecting the string in the Location field is /run/user/1000/doc/bc284510/Documents. Pressing create gets the error
An error occurred while creating the collection

Looks like it might be a permissions issue but I dont see any errors in the devtools console when trying to create a Collection. I was able to open the github example Collection, but I am not able to delete any Requests or Folders. I do get the following error in the console when I try to delete
Uncaught (in promise) Error: Error invoking remote method 'renderer:delete-item': Error: EACCES: permission denied, unlink '/run/user/1000/doc/62eab525/github-rest-api-collection/Repository/Search Repos.bru'

After installing the .deb package it seems like it has the correct permissions to create and delete Collections/Requests.

Being a permission issue, maybe you can solve it using Flatseal?
It's an application to manage Flatpak apps permissions.
Try to enable this permission:

Sorry to jump in on another person's thread, but I have the same issue. I use Windows 10. New user, fresh installation, can't create folder for collection. Tried to make folder manually and just click on it, same notification- "An error occurred while creating the collection".

I also encountered this issue, fix proposed by @rsilvr worked for me.
But this effectively makes the app useless for new users installing through flatpak, there should at least be more discussion on this...

@rsilvr thanks for the hint! I ran into the exact same issue & just opened a PR to add such permission from the beginning: https://github.com/flathub/com.usebruno.Bruno/pull/9

I am closing this issue as it seems to be resolved.


Move LateEs6ToEs3Converter to happen after RewriteBlockScopes

In order to get LateEs6ToEs3Converter to run after NTI, it needs to be able to run after RewriteBlockScopes (which currently needs to go before NTI).
Trying to switch the order has led to several subtle bugs, such as #2685.

Another issue that's come up is the following: converting lets to vars in a for-of loop happens differently from how it's done in for(;;) loops: specifically, in the former case, the "scope object" is reassigned at the end of the loop body, whereas in the latter case, it's reassigned in the loop condition (i.e. before the body runs).  This causes problems with OTI, which thinks that properties could be undefined even when they shouldn't be.
Example:
function g(/** number */ x) {}

for (let k = 1; k < 4; k++) {
//for (const k of [1,2,3]) {

  let x = /** @type {number|undefined} */ (k);
  if (!x) continue;

  const f = function(/** number */ x) {};
  (() => f(x))();
}

This currently works in OTI.  It transpiles the loop object assignment to the top of the for loop.  Switching to the for-of loop breaks it, with the only substantial change being that the loop object is assigned at the bottom.  Unfortunately, it's very brittle, though - changing f to g in the IIFE gives the same error about x being expected to be number but actually being number|undefined.  So it does seem that OTI understands that x could be undefined, but when the requirement of x not being undefined comes from another loop variable, it doesn't report the problem (presumably because that one could also be undefined?  I don't know), except in for-of loops.
Note that there are four interacting components here: (1) rewriting block scoped declarations (2) with loop-scoped variables that escape via a closure inside the loop (which causes the loop object to be made), (3) with a for-of loop (which puts the object update at the end instead of the beginning), (4) being type checked by OTI.  If any of those components is removed, the issue disappears.
I'm not entirely sure what the correct resolution is here - it looks to me like OTI is being too strict, but I can't figure out why it only has a problem when the object update is at the end.  NTI doesn't have any problems.  A possible workaround would be to simply change how for-of loops transpile to put the object update at the beginning.  There should be no difference in performance or code size except in the case that the loop breaks early (provably, to reduce code size), so that doesn't seem like a relevant concern.

Here's an example that's broken even without changing the order:
let /** !Object<number|undefined> */ o = {a: 2, b: undefined};
for (const k in o) {
  let x = o[k];
  if (!x) continue;
  const f = function(/** number */ z) {};
  (() => f(x))();
}

Scratch the earlier option about moving the update to the beginning of the body - the vanilla for-loop case actually does the update in the increment, not the condition.  It turns out that moving it to the front causes POSSIBLY_INEXISTENT_PROPERTY warnings since the properties being copied aren't defined yet.


Add 'open with' to the explorer context menu

Fixes #94347
For #94408
This change primarly adds a new Open with... entry to the explorer context menu. To do this however, I had to make a few other changes:

Add a new explorer context key for available editors
Moved the editor select prompt into a new function called openEditorWith
Use openEditorWith for the new open with explorer command as well as for the existing reopen with command

@mjbvz hi Matt. Thanks for this PR. Code changes look good overall.

Please explain the context key more in the documenation in code. ExplorerResourceAvailableEditorsContext is too generic name and it is not explained anywhere. Please use a more precise and clear name (every explorer resource can be opened in a editor thus just from the name I am pretty puzled when is this true).
When I execute this command I am provided with a quick pick to choose between the two editors to open with

Some feedback regarding this:

Placeholder text should not end with ... and should use capial cases for start of words. Look at other placholder texts for inspiration. I suggest "Select Editor for "NAME""
Text editor should be the last option since users can already open that just by pressing enter
The first item should be preselected
"Marddown Preview" should be the title of that one, not this long label
Why do users care if it is built in or not? I suggest to remove this then the options will be in one line and leaner
If there is only Editor + 1 option consider the following: Open With should just open it automatically using that one. Idealy the name of that command would also change though I know we do not allow that

Thanks for the feedback. I've made most of the suggested changes. Here's some context on some of the other points:
The open with command will only show on files that can be opened by more than one editor, such as images. When you open an image, we use a custom editor by default instead of text editor. A common use case for open with is to switch from a custom editor to our default text editor, which is why I like keeping the text editor first.
The select editor quick pick shows the extension that provides each editor choice. This is important because multiple extensions may provide custom editors with similar names, such as Markdown preview. The string built in is shown for editors that come from one of our built-in extensions.

@mjbvz thanks for addressing some of the feedback. I did a reivew and added comments.
Also there is a merge conflict in fileActions.ts.


getDataValue value doesn't match property value for belongs-to-many association

sequelize: 5.22.2
sequelize-typescript: 1.1.0
typescript: 3.9.6

[x] bug report
[ ] feature request
Actual behavior:
I have a BelongsToMany relationship between Entry and Market. When I get an Entry instance using update using findByPk() or findOne() I get the associated Markets only if I call getDataValue('market'), and not if I inspect the .markets property of the entry.
const entry = await Entry.findByPk(entryId)

entry.getDataValue('markets')
// is...

// []

Expected behavior:
entry.markets should output the list of market objects just like getDataValues('markets') does.

Any thoughts on this?

It was my error. I realised that initialising the association class member to an empty array will override any value returned from getDataValue('markets')
Previously it was:
@BelongsToMany(() => Market, () => Entry2Market)
markets: Market[] = []

But it works when I remove the initialisation of markets:
@BelongsToMany(() => Market, () => Entry2Market)
markets: Market[]


Core of the Ship has the same icon as The Dimensional Ship

Not sure what this is

@SebastianTanoni My bad. "Core of the Ship" and "The Dimensional Ship" are both Draenei quests. They have the same icon, and should have different icons.


Ensure MSI readonly fields are set to '' in ExternalNoReadOnly converters

Which issue this PR addresses:
Fixes no Jira
What this PR does / why we need it:
Ensures our ExternalNoReadOnly converters for the v20240812preview and admin APIs set the managedServiceIdentity's PrincipalID and TenantIDs to ''. This allows us to correctly perform PATCH operations that do not modify this field (e.g. an empty JSON object payload).
Test plan for issue:

[X] Manually performed PATCH operation and saw it work

Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
v20240812preview API is not yet available in production, MIWI fields/functionality are not enabled in production

/azp run ci


docker bug requires arguments in specific order

at least "Docker version 20.10.18, build b40c2f6" (released 2022-09-09) requires argument --abort-on-container-exit BEFORE argument --exit-code-from - otherwise it will complain that the container "--abort-on-container-exit was not found"
it's probably just a docker-compose bug that ideally should be fixed upstream, but in the meantime, lets avoid the bug/issue here.
quote:
root@devad22:/home/hans/projects/easyad/hello-world-cypress/e2e# docker --version
Docker version 20.10.18, build b40c2f6
root@devad22:/home/hans/projects/easyad/hello-world-cypress/e2e# docker-compose up --exit-code-from --abort-on-container-exit cypress;
WARNING: using --exit-code-from implies --abort-on-container-exit
ERROR: No service named "--abort-on-container-exit" was found in your compose file.
ERROR: 2
root@devad22:/home/hans/projects/easyad/hello-world-cypress/e2e# docker-compose up --abort-on-container-exit --exit-code-from cypress;
Starting e2e_sentimentalyzer_1 ... done
Starting e2e_cypress_1         ... done
Attaching to e2e_sentimentalyzer_1, e2e_cypress_1
sentimentalyzer_1  | 2022/09/12 13:41:30 Listening on port 8123
^C

Thanks, @divinity76 !


Creating inference Examples

Contain test examples for inference

Description
An inferenceExample with all inference tests has been added.
Also added readme for using non-embedded mongodb.
Only 3 files have been added in total.
InferenceExamples.java
inferenceExamples_readme.txt (In indexingExample directory)
log4j.properties
Tests
Tests will do inference tests in java with logging.
Links
Checklist

[ ] Code Review

People To Reivew
@pujav65

Can one of the admins verify this patch?

@pujav65
I have removed the readme in the root folder per request. Thank you.


Update to React 0.12.2

As requested in https://github.com/newtriks/generator-react-webpack/issues/36. I'm a designer/developer, so please double-check my work! :smile:
Thanks for the great generator...I use it all the time!

Hi @andrewliebchen thank you for the pull request, I will review and merge asap :+1:

Reach Router's API changed substantially, so app generated with routing does not work entirely
https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md#010x---011x

Hmm, wonder if 0.10.x works with React 0.12.x.

6to5 supports jsx, so no jsx loader needed for es6 mode

As @victor-homyakov , routes didn't work for me. I was getting Uncaught TypeError: Cannot read property '_mockedReactClassConstructor' of undefined. Once I changed this i got it working:
var Router = require('react-router');
var Route = Router.Route;

var routes = (
    <Route handler={FluxTestApp}>
        <Route name="/" handler={FluxTestApp}/>
    </Route>
);

var content = document.getElementById('content');

Router.run(routes, Router.HistoryLocation, function (Handler) {
    React.render(<Handler/>, content);
});

// or default to hash location
Router.run(routes, function (Handler) {
    React.render(<Handler/>, content);
});

This is the first time I play around with React so I'm not sure if this is the correct solution.


Default AL Snippets won't disable

Just installed the VSIX for NAV 2018 CU07 (0.12.25327) and now the default snippets are all enabled and try though I might I can't disable them.   I have turn the values on/off exited/reentered many times and they just won't go away.
Has something changed?

No, this is a valid issue ...
Thing is that Microsoft works with 2 publishers, so I need to take that into account - the snippets end up in 2 different places.  I only handle one place.
Another problem is that there is no official way to disable any snippets, so what I do is I rename the snippet-folder so that the extension from MIcrosoft doesn't find them anymore.
This results into error in the background. The user is not bothered with it .. but it's not really nice.
I'm still trying to find a better way to disable snippets....  therefore this issue:https://github.com/CloudReadySoftware/crs-al-language-extension/issues/32
if you have ideas - I'm all ears ;-).

@GreatScott000 , did this new release fix it?

I am not sure.  The default snippets do not appear but I get a message the a message about the Snippets folder is not found.

@GreatScott000 ,
next version, this should be fixed (let's hope ;-))


Error during Admin UI Add token

Describe the bug
When using the web admin UI and attempting to add a token, a 500 error response is returned from the web app.  I didn't see in the documentation any other way to add a token to the relayer.
To Reproduce
Steps to reproduce the behavior:

Install Docker-compose production environment
Setup admin account via docker exec scripts
Login to Admin UI
click on "token Add+"
Witness 500 error

Expected behavior
I would expect to see form fields with attributes to populate regarding tokens
Additional context
Running against Infura Kovan endpoint.
Docker images. Did recent docker-compose pull

Error Logs from worker...
2020-10-26 14:43:21,391 [ERROR] [MainProcess] Internal Server Error: /admin/tokens/token/add/
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/db/models/options.py", line 575, in get_field
    return self.fields_map[field_name]
KeyError: 'eth_value'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/contrib/admin/utils.py", line 264, in lookup_field
    f = _get_non_gfk_field(opts, name)
  File "/usr/local/lib/python3.8/site-packages/django/contrib/admin/utils.py", line 295, in _get_non_gfk_field
    field = opts.get_field(name)
  File "/usr/local/lib/python3.8/site-packages/django/db/models/options.py", line 577, in get_field
    raise FieldDoesNotExist("%s has no field named '%s'" % (self.object_name, field_name))
django.core.exceptions.FieldDoesNotExist: Token has no field named 'eth_value'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 202, in _get_response
    response = response.render()
  File "/usr/local/lib/python3.8/site-packages/django/template/response.py", line 105, in render
    self.content = self.rendered_content
  File "/usr/local/lib/python3.8/site-packages/django/template/response.py", line 83, in rendered_content
    return template.render(context, self._request)

Thanks for the report, it's fixed now


GH-94: Improve table package

This PR aims to resolve GH-94 by adding wanted improvements to the Table package. Here are the points listed, with my comments:

[x] Fix quote and backslash support
- Works as expected, one backslash escapes the delimiter, two doesn't, three does etc
[x] Arguments for alignment
- There is an alignment argument which you can set to left/center/right or some combination of l/c/r, one character for each column, like ccr which would center the two first columns and right-align the third.
[x] Arguments for borders
- Argument borders can be all/horizontal/vertical/outer/none. The options are self-explanatory. All but none implies outer
[x] Option for first row to be headers
- Argument header can be none which has no special treatment or bold which is th in html and textbf in latex
[x] Strip whitespace
- Argument strip_whitespace (true/false) controls stripping of whitespace

This is a draft PR for now, and these are the things that needs to be fixed before promoting to a "real" PR:

[x] Commenting code
[x] Adding tests
[x] Make sure it works for empty tables (for LaTeX, we insert |l| as the alignment for empty tables since it errors without an alignment. Also, we give an warning)
[x] Possibly functional decomposition, the code doesn't look fantastic right now (I did that somewhat, think it got somewhat better)
[x] General clean-up

Uploading as draft PR for you to be able to preview and play around, enjoy! (Also, please test it out a bit, especially the LaTeX support which I am not so sure is bug-free)

Resolves GH-94
Resolves GH-112

(The reason for the previous test failures weren't the table module itself, rather that Core runs a test loading it and reading the manifest, and since I didn't update that test with the new manifest, it failed)

I think this PR is ready for review now!


Keep original enum order for internal types

What changed?
Keep enum values ordered the same way as thrift analogues. Currently they are ordered alphabetically.

Why?
There are places where zero value is used if explicit value is not specified. This was noticed in #3744 when tests failed after types got converted into internal types. Therefore lets keep the order the same, to match original zero-value.

How did you test it?

Potential risks

Coverage decreased (-0.03%) to 59.706% when pulling 4dbcee01872cb7352c051f4db10d545dd42b14ef on vytautas-karpavicius:internal-type-enum-reorder into 436bb56214a6726948371ff08541a5ee605ab9ab on uber:master.


Can't find decoder for case class.

I have the following tables with foreign key:
CREATE TABLE user (
  id           PRIMARY KEY         NOT NULL,
  name         VARCHAR UNIQUE      NOT NULL,
  contact      INT                 NOT NULL REFERENCES contact(id)
);

CREATE TABLE contact (
  id           PRIMARY KEY         NOT NULL,
  address      VARCHAR UNIQUE      NOT NULL
);

and the following case classes:
case class User(id: Int, name: String, contact: Contact)
case class Contact(id: Int, address: String)

but any query I run with query[User] results in

Error:(503, 96) exception during macro expansion: scala.reflect.macros.TypecheckException: Can't find implicit Decoder[foo.bar.User].

If I change the user class to case class User(id: Int, name: String, contact: Int) everything works fine, but that's not really what I want.

Hello @AnthonyJacob, quill is not ORM, it provides QDSL to express queries in Scala and execute them in a target language. So basically to achieve what you want you need to write a query for that, something like:
case class Contact(id: Int, address: String)
case class UserRow(id: Int, name: String, contact: Int)

case class User(id: Int, name: String, contact: Contact)

query[UserRow]
  .join(query[Contact])
  .on((u, c) => u.contact == c.id)
  .map { case (u, c) => User(u.id, u.name, c) }

Case classes used in query[T] is representing the sql tables, but not business entities


Build Error

Hi,
Having followed the various steps to install go (Following this guide) and Skicka, i'm now presented with the following error whilst trying the go get command:
# google.golang.org/api/gensupport
go/src/google.golang.org/api/gensupport/media.go:340: req.GetBody undefined (type *http.Request has no field or method GetBody)

Any tips on what could be the issue?  I'm running go version go1.7.4 linux/arm
Many Thanks in advance.

I just tried installing skicka from scratch with an empty $GOPATH directory and couldn't reproduce this.
 I'm wondering if some of the dependencies are out of date.


Add an LLVM pass to merge similar functions.

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

It's like LLVM's MergeFunctions pass, except that it can also merge functions which differ by some constants.
The intention is to merge specialized functions which only differ by metadata lookups. But it can also merge other types of functions.
It gives ~7% code size reducation for the stdlib.
There are still some open TODOs, e.g. to share common code with LLVM's MergeFunctions pass (currently much code is just copied).

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test


Progress bars don't seem to finish?

I'm using tracing-indicatif in a stream, using the .instrument() function available on futures.
Something like the following:
            let num_elems = elems.len();
            let results: Vec<_> = futures::stream::iter(elems)
                .map(|elem| {
                    let some_service = some_service.clone();
                    async move {
                        let resp = some_service
                            .get(elem)
                            .await
                            .map(|resp| (elem, resp));

                        // once the .get is done, increment the progress bar.
                        Span::current().pb_inc(1);

                        resp
                    }
                })
                .buffer_unordered(10)
                .try_collect()
                .instrument({
                    let span = tracing::info_span!("doing_work", "indicatif.pb_show" = tracing::field::Empty);
                    span.pb_set_message("Doing work");
                    span.pb_set_length(num_elems);
                    span.pb_set_style(
                        &ProgressStyle::with_template(
                            "{prefix}{wide_msg} {bar:30} [{elapsed_precise}]  {pos:>7}/{len:7}",
                        )
                        .unwrap(),
                    );
                    span.pb_start();
                    span
                })
                .await?;

            do_other_work();

While I get progress bars, and the progress bar updates, it seems the "Doing work" progress never finishes, even after it's dropped (during do_other_work()).
The timer keeps counting up.
A more complete example (and screencast): https://asciinema.org/a/ap9qC60A5IjvI12vQ2IBwEHOM.
As can be seen, the "Checking paths" progress bar keeps running, even though we're already at "Ingesting paths".

I think this was a mistake on my side, and the span was still active.


Set up eslint-plugin-es-x to check the syntax we use

eslint-plugin-es-x validates the use of features brought by specific ES version. This should give us a safety net that we're not including the modern features it can detect in our code.
The setup sets the restrictions to ES3 features, due to our IE8 support. The rules matching the features we polyfills are deactivated to allow us using them.
We'll still need a bit of caution as it only have rules against EcmaScript features not Browser API features.

@romaricpascal Are there alternatives that will catch everything (or more than this)?

@colinrotherham There's eslint-plugin-compat as well, that may be worth exploring. eslint-plugin-es5 seems focused on language features as well, and eslint-plugin-es-x looks sturdier (especially as it's under the eslint-community org). Once we're out of ES3-land, eslint-plugin-ecmascript-compat may be relevant (but it lints only ES2016+ features).
There may be checks that could be done during compilation rather than at linting. For ex. we could try to detect which transformations Babel tries to apply when running on our code. Last I checked, though, I couldn't find anything to see when Babel actually transformed the AST to turn a modern syntax in older code, just which plugins it enabled based on the browserlist. For polyfilling, we may get more information thanks to the shouldInjectPolyfill option, which would let us track what Babel actually tries to inject.
All in all, this PR is more a quick try to unlock the terser PR. Looks like we need more research if we want a tighter safety net on ES and browser features.

Will it have caught this one?

https://github.com/alphagov/govuk-frontend/pull/2868

Yup, the es-x/no-block-scoped-variables rule catches that.

I think syntax-wise, the plugin will do the job fine (it's got all the information in the AST). Judging by the rules, it'll also catch any instanciation of new classes. Where it'll leave a gap is for detecting call to methods as it cannot infer things from types.

Makes sense to me, but should these changes be in src/.eslintrc.js instead?

Yup, had missed that there was a separate config in src. I've tidied that up and also move the rule disabling next to the polyfill imports as @colinrotherham suggested (that should help us catch when we forget to import a polyfill for a feature that eslint-plugin-es-x can detect 😄

@colinrotherham Should be all tidy based on your last comments 😄