Stuck on "waiting for agent connection" while creating a Digital Ocean Host

Rancher Version:v1.0.0
Steps to Reproduce: Create a host on Digital Ocean via the "Add Host" button in the Infrastructure tab
Results: Waiting for agent connection
Expected: Active host
I'm trying to add a new Digital Ocean host in a Cattle environment as well as in a Swarm Environment but in both environments it gets stuck on "Waiting for agent connection". On Digital Ocean I can see the two droplets (one for each environment).

Where is your Rancher server hosted/located?

@deniseschannon Rancher is running on a VM (Debian 8 - with the latest version of Docker) on an on-premise Hyper-V environment that my company put at our disposal for testing purposes.

Do you have some kind of firewall or proxy for internet access?
http://docs.rancher.com/rancher/installing-rancher/installing-server/#launching-rancher-server-behind-a-http-proxy

Not any firewall nor proxy on my road ;-)

The VM that you have set up where Rancher server is running. Is the host routable from the internet?

I don't think so.
Do you think I could find some (verbose) logs somewhere?

There are no logs specific for this use case, but your Rancher server needs to be routable from the internet. After the DO droplet is created, we automatically launch a rancher/agent container onto the host, in this case, the rancher/agent container on the DO host is trying to communicate back to the rancher/server container via the internet and is getting stuck as the VM that you have rancher server on is not routable.
How did you add your hosts/where are your hosts located in your swarm environment that you have had questions about?

Sorry, I've double checked and it seems that all our VMs are routable from internet...
I'm not trying to add a DO droplets in my swarm cluster, I'm trying so in my Cattle env.

Sorry to confuse the issues, but I was curious on how you got your other active hosts in your swarm cluster. Did you run a custom command on a VM that was already up and running?
Adding a DO droplet to the swarm cluster would be the same in your Cattle env. (Unless you're telling me that it works in 1 and not the other, which would be surprising to me).

Ahh ok, no problem. I've added the other hosts with the command provided by
Rancher while adding a host so yes on an existing VM already up and running.
Indeed adding a DO droplet in the swarm cluster doesn't provide better
results... therefore no surprise there ;-)
On Tue, Apr 5, 2016 at 11:22 PM, Denise<EMAIL_ADDRESS>wrote:

Sorry to confuse the issues, but I was curious on how you got your other
active hosts in your swarm cluster. Did you run a custom command on a VM
that was already up and running?
Adding a DO droplet to the swarm cluster would be the same in your Cattle
env. (Unless you're telling me that it works in 1 and not the other, which
would be surprising to me).
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/rancher/rancher/issues/4246#issuecomment-205988124

Okay, it sounds like the hosts in DO cannot communicate back to your VM that is running Rancher server.

What is the IP of your Rancher server?
Can you do a test? Manually create a DO droplet and log into it. Try this command from inside the DO droplet.

#This is my example Rancher server IP, please replace with your Rancher server IP
curl -i 104.197.228.X:8080/v1

Rancher server IP is in my private range thus not reachable from that droplet. Is this what you meant that routed from internet ? How the agent communicates with the server (ssh like or via a public IP only)?

Yes, that is exactly what I was meaning.
Rancher agent communicates with the server through the internet. Without that access, these agents will not be able to be added to Rancher server.

Ok thanks, sorry for the confusion then I will setup my reverse proxy to
make rancher routable FROM internet and then I'll close this issue if it
was indeed the cause.
Thanks again for your help!
On Wed, Apr 6, 2016 at 12:22 AM, Denise<EMAIL_ADDRESS>wrote:

Yes, that is exactly what I was meaning.
Rancher agent communicates with the server through the internet. Without
that access, these agents will not be able to be added to Rancher server.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/rancher/rancher/issues/4246#issuecomment-206008512

Ok ranche is now accessible via a public url and I'm able to get an unauthorized message (since I need to login I guess) using your curl command but I'm still facing a "waiting for agent connection"...

If you setup a reverse proxy in front rancher to make it accessible, you probably have a new IP or domain for it, right? If so, you'd need to update the Host Registration URL under Admin > Settings and then go to the add host page, verify the docker run command has the new IP address, and then run that on the DO hosts.
If you created the DO hosts via our UI, it might be easier to just delete them and create new ones.
Also, that rancher-server requires certain headers be set properly in the reverse proxy and the reverse proxy must support websockets, as much of the communication from agent to server is done via a websocket connection. An example nginx and apache config for a reverse proxy for rancher can be found here: http://docs.rancher.com/rancher/installing-rancher/installing-server/basic-ssl-config/#notes-on-the-settings


log-backup: fixed pessimistic lock in initial scanning

Signed-off-by: Yu Juncen<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #13304
What's Changed:
This PR fixed a bug that caused initial scanning (unexpectedly) tracing the PessimisticLock lock. Which may block the checkpoint from advancing if there are some long-existing pessimistic transactions.
Check List
Tests

Integration test
Manual test (add detailed scripts or steps below)

Release note
Fixed a bug that caused checkpoint not advanced when there are some long pessimistic transactions.

Does the bug affects to CDC?

Does the bug affects to CDC and resolvedts?

I guess no, this PR only changes the internal logic of PiTR.

/merge


Set up Coverity Analysis of the code

Coverity static analysis software is an industry leading tool that is available for free to open source projects. It would help improve the quality of the code if we were to run this analysis on RaSCSI.

I started setting up the project, but didn't get very far...
https://scan.coverity.com/projects/akuker-rascsi?tab=overview

@akuker Any news on this? Not having automated builds of the develop and feature branches (in order to also have automated unit tests) and not having any code analysis, e.g. based on SonarQube, which is free for C++ for non-commercial projects (https://sonarcloud.io/explore/projects) is quite a problem. The more code is added without automated testing, the more likely regressions get.

Agreed. Its all a matter of priority. This isn't an especially "sexy" feature to work on, so its easy to push it down the priority list. I definitely have not forgotten about it.

@akuker Yes, just like documentation tickets like this are not that popular. But the more code we have, the more important this ticket gets.
My experience from previous projects is that having code analysis and working steadily on improving code metrics helps preventing a lot of issues. And it uncovers a lot of issues, which would otherwise have taken a lot of time in debugging the problems they would have caused.

@akuker What did you get stuck on setting up the Coverity project? I can see that you got it to scan a whole bunch of code, so you must have made some progress!

@akuker @rdmark I think I have resolved this ticket, please see https://github.com/akuker/RASCSI/pull/806.

Coverity is very similar to SonarQube in its capabilities, I believe.

Coverity looks like it is similar to SonarQube (from my 30 second google search of SonarQube). Coverity can identify dead code, but that's not its primary function. Its more like lint on steroids.
I'm excited to see gcov being used. As for this ticket, I don't care. We can close it, we can leave it open. Whatever.
There are other priorities... I'll just close it.


set up to be installed by npm

i hope
@incuna/frontend pls

@hippogriffic You can test before this is merged and released:
npm install --save-dev incuna/style-guide.git#6b1f226229ebb61a7b74422227c4cc2bbeb41358

it's appearing in my node_modules so looks good


Button stopped working.

I have a bootstrap switch which replacing the switch content in every five seconds. after replacing the switch content, switch stopped working.

Have you tried re-initialising?

Yeah thanks, I fixed the issue with replacing a new button when to refresh.


jdiff not ble to catch reference key in dict of dicts

Environment

Python version:  3.7
jdiff version:  0.0.2

Expected Behavior
As it stands now, jdiff can catch a reference key only in a list of dictionary. There are case where NAPALM returns dict of dicts. In the example below, we want .local. and .local..0to be the ref key ofis_up`
{
  ".local.": {
    "description": "",
    "is_enabled": true,
    "is_up": true,
    "last_flapped": -1,
    "mac_address": "Unspecified",
    "mtu": 0,
    "speed": -1
  },
  ".local..0": {
    "description": "",
    "is_enabled": true,
    "is_up": true,
    "last_flapped": -1,
    "mac_address": "Unspecified",
    "mtu": 0,
    "speed": -1
  },
}

@pszulczewski FYI

I believe this could be a limitation from JMSPATH. The most similar case I found is this one:https://jmespath.org/tutorial.html#object-projections
As we can see, the our hypothetical reference key is lost using *.  I will drop a message on jmspath channel support but I feel that the user will have to do some post parsing using indexes

Looks like there is keys(@) which catches all dict keys. So in jdiff the path should be something like keys(@).is_up and should work. @pszulczewski FYI

keys(@) produce list of keys, similar to python dict.keys(), they don't have access to values.
Thus keys(@).is_up or $keys(@)$.is_up return None.

At this point we have 3 options:

Let the user use index to create a mapping between key and value got from jdiff - this will not work out of the box with pre defined checks
Make jdiff dynamically discovery the data type and act accordingly - for this case the expression would be something like $*$.is_up
Create some sort of flag

As discussed with @pszulczewski we will support $*$.is_up and interpolate the list of keys with the list of values returned.


update react/lib/Object-assign to Object.assign.

close #89

Going to fix this differently in #92. Thanks though!


Block Explorer database design

I'm thinking of using a key value store for a database (bolt db).
Buckets:
BlockID -> Block{}
TxID -> Transaction{}
Address -> []Txid
SiacoinOutputID -> Txid
SiafundOutputID -> Txid
FileContractID -> Txid
Hash -> Hash Type (an enum or something similar, provides an entry point for a hash with no context)
I'm considering moving the transactions into the block that contains them, and then the siacoin output id's would point to a block and a transaction number.

This mostly looks good to me. I support moving txns into blocks. That way we minimize redundancy; all we store is blocks and references to blocks.
I am a little confused as to the function of the Hash bucket.

I think it's there so you can get some random unknown hash and figure out what type of object it is.

I don't plan on using in many of the internal queries, as we should know what type of hash it is. However, this type of lookup is something that many block explorers implement, and storing an extra bucket at the top shouldn't complicate things too much. For example: http://www.blocktree.io/e/BITB

If we wanted to follow an output around:
outputID -> txid
txid -> txn
txn -> scan inputs and outputs
inputs and outputs -> more txids
looks good to me. That's the biggest use case I'm looking for right now.

A few revisions and additions:
BlockID -> Block{}
Address -> []Txid
FileContractID -> Txid, []Txid, Txid (File Contract, []Revisions, Storage Proof)
TxID -> (Block, TxNum)
SiacoinOutputID -> Txid (output)
SiacoinOutputID -> Txid (input)
Could also do SiacoinOutputID -> Txid, Txid, and leave the latter as 0 until the output is spent
SiafundOutputID -> Txid
SiafundOutputID -> Txid
Should mimic Siacoin outputs
Height -> BlockID
Hash -> Hash Type
The second bucket for each siacoin output is to find where a output is spent. Given my scheme in the OP, that would require searching through the chain.
There will be a fair amount of searching through transactions to do many of the lookups, but ideally a transaction will be small enough to search through quickly. Alternatively, we could store more data (e.g. SiacoinOutputID->(Txid, outputNum)). This would move the complexity from executable code to the data structure given the many different sources of outputs (maybe ID->(Txid, type, Num)?)

Might also be a good idea to include more data about each block, such as the child target and its block height, neither of which are easily obtainable given just the block.

Best to start small, and do more iterations. You learn things each iteration.
What you have now looks good to me.


community[minor]: Fix json._validate_metadata_func()

JSONparse, in _validate_metadata_func(), checks the consistency of the _metadata_func() function. To do this, it invokes it and makes sure it receives a dictionary in response. However, during the call, it does not respect future calls, as shown on line 100. This generates errors if, for example, the function is like this:
        def generate_metadata(json_node:Dict[str,Any],kwargs:Dict[str,Any]) -> Dict[str,Any]:
             return {
                "source": url,
                "row": kwargs['seq_num'],
                "question":json_node.get("question"),
            }
        loader = JSONLoader(
            file_path=file_path,
            content_key="answer",
            jq_schema='.[]',
            metadata_func=generate_metadata,
            text_content=False)

To avoid this, the verification must comply with the specifications. This patch does just that.

the return of metadata_func will be check to be sure if it's a dict.
To that, the code "simulate" a legitimate invocation.
But, If I add a special case, if the kwargs is empty, I just bypass the test.
def generate_metadata(json_node:Dict[str,Any],kwargs:Dict[str,Any]) -> Dict[str,Any]:
             if not kwargs:
                      return {} # Bypass the test
             return 43 # And return an integer

I think it it not correct.

The _validate_metadata_func() function is there to test the consistency of the implementation only once.
It's an optimization. The non-optimized alternative would be:
    def _get_metadata(
        self, sample: Dict[str, Any], **additional_fields: Any
    ) -> Dict[str, Any]:
        """
        Return a metadata dictionary base on the existence of metadata_func
        :param sample: single data payload
        :param additional_fields: key-word arguments to be added as metadata values
        :return:
        """
        if self._metadata_func is not None:
            result= self._metadata_func(sample, additional_fields)
            # CHECK HERE
            if not isinstance(result, dict):
                raise ValueError(
                    f"Expected the metadata_func to return a dict but got \
                        `{type(result)}`"
                )
            return result
        else:
            return additional_fields

Optimization must not change the implementation. We shouldn't write generate_metadata() differently just because there's an optimization.

@baskaryan
With this fix, I demonstrate the incorrect code with a more simple implementation.
If you want to test the invocation of a function, you have to invoke it properly.

Hi @pprados,
I haven't been able to follow the description in the PR summary -- so hard to make a decision regarding whether we should merge the PR or not.
From reading the code, the newer version of the code makes more sense to me, but without digging through the code in detail I can't tell whether this change is backwards compatible or not.

Is this change backwards compatible or is it going to break anyones code?
Could you remove the commented out code from the PR? We don't want to merge commented code.
Are you able to provide a unit test?

Is this change backwards compatible or is it going to break anyones code?
At present, no code can be written correctly, as I try to show in my explanations. The only way to implement this method is to pretend that everything is fine. So code that checks kwargs will continue to work. And above all, it will now be possible to have a real method, without bypassing the test!
Could you remove the commented out code from the PR? We don't want to merge commented code.
Of course you can. I just wanted to explain why the implicit specification requires the presence of source and seq_num.
Are you able to provide a unit test?
Yes.

But, @eyurtsev, do you prefer the last implementation, with a test for each iteration or the first version, with only one test ?

@eyurtsev
is it correct for you ?

@pprados this looks good to me. Is there an existing unit test that covers this functionality in the code base already if not would it be possible to add one?

Hi @pprados just wanted to check in if you were still interested in merging this change? A unit test would be helpful here to verify that things work as expected

Yes, i must find the time for that.

@eyurtsev
There are bugs in the validation of other modules. Community is clean.


Add on_enable and on_disable function hooks

Hi, thanks for the great plugin.
I want to add on_enable and on_disable events to override default behavior.
Instead of needing to add multiple configuration options for things such as conceal levels, scroll, spell, etc, it might be better to create these hooks that allow for the user to customize just the behavior of neovim.
For example, using the obsidian.nvim plugin's ui feature results in not being able to see the actual link
https://github.com/OXY2DEV/markview.nvim/assets/43306454/36750c95-c07e-4567-822d-588fd41989d5
Using hooks, and the function, its possible to change the behavior of neovim based on the rendering mode:
require("markview").setup({
  on_enable = function() vim.o.concealcursor = "" end
})

https://github.com/OXY2DEV/markview.nvim/assets/43306454/894705b6-588b-4cc5-bd6c-f7bdb28677dd

These are actually going to be added as part of keymap control table(along with other options).
You must've seen that the the function that sets these keymaps accepts a config_table value.
That's what this is for. Because some people actually have keymaps like gx set to their own functions. So, there has to be an option to disable specific keymaps and customizing their behavior.
It's going to be added but I am still testing out to see how the configuration table should work.
I won't be merge this at the moment. Since I am currently trying to finish the wiki, make more presets etc. And after all that work on the keymaps part.

After testing for a bit. I realized that there's really no point in adding hooks since you can do the exact same thing with your normal autocmd.
Instead, since the issue came from conceallevel & concealcursor it would be better to provide some options to change them.
You can now use options in the config table to change the value used for these options.
You can check the wiki page to see how to use it.


Valhelsia 5 wont open

When i go to open and then run the mod it just  crashes. This is the crash report
https://docs.google.com/document/d/1ImHtJ0_D7UcZ2P90M2rpPrz6_N_jn_P-WiiQKJFXawk/edit?usp=sharing

Thank you for the report!
It looks like you are using a modified version of Minecraft. The following was detected in your crash report:
--launchTarget forgeclient
--fml.forgeVersion

Please try the following:

Update your graphics drivers, see this Minecraft Help Center article, section "Update your Video Card Drivers";
often Minecraft crashes are caused by outdated graphics drivers
Try disabling the mods you have installed one by one until you find the mod causing the crash, then report the crash to the mod author
If you are using a third-party launcher, try the official launcher instead

If none of the above helped, and you are still experiencing the crash with the official launcher and without any mods installed, please submit this issue over at the Mojang bug tracker. Please search for existing reports first; in case you do not find any, create a new report and let us know about the issue number here (e.g. MC-123456).
The Mojang team will take the first look. If an OpenJDK bug is identified, the Mojang team will contact the Microsoft Build of OpenJDK team to address the issue.


Support React Native

React Native is becoming a major mobile platform.  We need to support it fully.

hi, is there any update regarding React Native support ?

Can I ask if it is done?

Any update?

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Any updates on this? Especially of interest since the AppCenter went live 👍

+1

+1

+1

+1

+1

@adrianhall Can you share any insights as to when we might see a beta? I need to decide whether to wait or use an alternative.

Sorry - I'm not involved in Azure Mobile Apps any more.  I moved over to Amazon and am now involved in AWS Mobile (AWS Amplify and AWS AppSync) - we have React Native support.
Perhaps @elamalani can assist here as she seems to be gathering requirements.

Hi everyone,
Thanks for using Azure Mobile Apps and making it a popular Microsoft offering for mobile backend services. We have been talking to customers to understand their evolving needs for these services. Based on the feedback, we are looking to shape the next version of Azure Mobile Apps. Our product team is not currently investing in any new feature work for Azure Mobile Apps including React Native platform support. But we are committed to fully supporting the existing product, including support for the latest OS release, bug fixes, documentation improvements, and community PR reviews.
Please let me know if you have any questions.
Thanks,
Ela

@elamalani It is disappointing that Azure has zero plans to support React Native.
Mobile App Center has been surprisingly supportive of React Native.
I an researching switching from Real to Azure because Offline Data Sync in Azure Mobile Apps seemed to be easy to add to your Android / iOS app.
Now it appears easier to switch to Amazon AWS.
@adrianhall commented:
Sorry - I'm not involved in Azure Mobile Apps any more. I moved over to Amazon and am now involved in AWS Mobile (AWS Amplify and AWS AppSync) - we have React Native support.

AWS Amplify
AWS AppSync

@esutton Have you tried PouchDb? is great.
Also, it's not to hard to alter source and build yourself something personalized. I did and it works great. On the other side, there are a intrinsic issues with this project, for example, synchronizing lots of tables takes time, specially in js client.
Shameless Plug: in my freetime i started a new project few days ago: https://github.com/andreujuanc/CherryDb
For now it's just a prototype, to test ideas and stuff.  It should bring ton of features from pouchdb plus more from this repo. Main features should include fast sync and easy to implement backend/frontend db store, so it's not tied to any specific database. Feel free to open issues to discuss any requirement you may have.

@esutton I tried to install RN and expo were giving me some issues :( So I can't try to do a PoC azure-mobile-apps-js-client with RN ATM.
For data sync, try pouch, or do something In-House. It's not so hard, and you'll get the benefit of using any DB + any backend + any front end that you might need. My repo might guide you to start, tho I havent implemented almost anything xD


METRON-1445: Update performance tuning guide with more explicit parameter instructions

Contributor Comments
https://issues.apache.org/jira/browse/METRON-1445
The current performance tuning guide can be challenging to follow for those not familiar with the system. This PR updates the guide to provide details about how and where to find tuning parameters along with details as to how the properties are materialized in a running topology.
Additionally, a supplement to the tuning guide has been provided to pull Metron cluster debugging info into a tarball. As pertains to the perf guide, it captures the state of Ambari configuration, flux files, properties files, and zk config. This helps users confirm system state as they make tuning changes.
Pull Request Checklist
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:
n/a
For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

+1 by inspection, this is great detail.

+1 Thanks


Cannot enqueue Query after fatal error

My node-red applications directs MQTT messages to my MySQL database.
When I noticed a lot of data was missing in the database, I checked the logs and found thousands errors like:

[error] [mysql:3a8296e6.89951a] Error: Cannot enqueue Query after fatal error.

When I searched for the error before these errors (the fatal one), I found:

[error] [mysql:3a8296e6.89951a] Error: Connection lost: The server closed the connection.

In a relevant mysqljs error (https://github.com/mysqljs/mysql/issues/832), they notice that the db connection is not released properly. Can this be the case?
I don't know if this has anything to do with it, but I noticed some errors like this too (also before this issue):

[error] [MySQLdatabase:4a1035a.a61eacc] Error: connect ECONNREFUSED

Context:
[info] Node-RED version: v0.14.4
[info] Node.js  version: v0.10.25
[info] Linux 4.4.0-28-generic x64 LE

So your server stopped the connection ? The catch node should be able to report the error into the flow if you want to act on it.
For general questions we prefer the mailing list, or is there some issue with the node ?

Yes... but this sounds like a failure to recover automatically from a server disconnect. If the node fails to reconnect, there isn't much you can do in the flow with a catch node or otherwise.

So there is an issue with the node? Or how can I automatically let it recover, so no data gets lost?

@kenvernaillenvub at this point, we don't know... need to investigate

It does automatically try to reconnect...  But will have to check some more.

Does node-red use one single connection? Or a connection per query (that is also released)? I don't find it in the code. (like noticed here: mysqljs/mysql#832)

One single connection

While redeploying (to fix the issue of 'cannot enqueue query'),  I also found the error:

14 Sep 14:31:48 - [error] [MySQLdatabase:4a1035a.a61eacc] Error: Cannot enqueue Quit after fatal error.

After deploy everything works again.
Since it is a single connection, how can I catch the error and release and reconnect the database connection?

So - I guess the best we can do is to reject any input while "not connected" - rather than get the cannot enqueue error - and let it reconnect before accepting any more input.

sounds good to me.
so the input that is rejected wouldn't be buffered and will be lost?

Yes, none of the other nodes buffer. Buffering , queue management, and error recovery are all topics beyond the scope of a "simple" database node :-)

But we would raise an error, so at least you would know...

Ok thanks

Hi, published to npm as version 0.0.10.
the default retry time is 20 seconds  - this can be overridden in the settings.js file by using
mysqlReconnectTime = 20000,   // time in milliseconds
Now rather than that obscure message it creates an error that can be caught with the catch node - that contains the original inut msg object so you can feed it back round or drop it or whatever you wna to do.
PS - this Issue should really be raised against the node-red-nodes project


Replace Charset.forName("UTF-8") to StandardCharsets.UTF_8

Hi，
Is it necessary to replace Charset.forName("UTF-8") or some codes like new String(encoded, "UTF-8") to the constant variable StandardCharsets.UTF_8 which JDK 7 has provided

Thanks!  (Leftovers from when this library supported java 1.6)


add support for uint32 element index

Description of change

Pre-Merge Checklist

[X] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

#5699

Looks good. Lets see if we can test it somehow...

Test is here: https://www.pixiplayground.com/#/edit/11AT1kMcq69qWKJvX67Wb
We dont have build anywhere so I just took PR changes inside playground itself.


Daemon, IngressNodeFirewallNodeState and other changes

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

/lgtm

will address remaining work items once this PR is merged
/approve


Rendering issue

Some relationships are not rendered. I have identified the following:
•	ConceptParentChild: parent and child
•	ConceptPartWhole: part and whole
•	ContainsTemporalRelation: contains and during
•	EqualTemporalRelation: equalA and equalB
•	FinishesTemporalRelation: finishedBy and finishes
There are also two errors displayed in the graph, which seem to be related:
Error: :50: syntax error near line 50 context: DDI_ConceptParentChild:ConceptParentChildparent -> DDI_Concept [side= >>> arrowhead= <<< none labeldistance=1.9 taillabel="0..n" headlabel="1..1" edgetooltip="parent" fontcolor="black" color="#00000"];
Error: :52: syntax error near line 52 context: DDI_ContainsTemporalRelation:ContainsTemporalRelationcontains -> DDI_ProcessStep [side= >>> arrowhead= <<< none labeldistance=1.9 taillabel="0..1" headlabel="1..1" edgetooltip="contains" fontcolor="black" color="#00000"];

These screenshots show the missing associations in yellow:

URLs:
http://lion.ddialliance.org/package/conceptual
http://lion.ddialliance.org/package/coreprocess

This is also happening on http://lion.ddialliance.org/ddiobjects/agentassociation

This should now be fixed:
could you verify?

You are Sir,  a genius – and we bow down before you ☺
Jon
From: Olof Olsson<EMAIL_ADDRESS>Sent: 14 April 2015 10:23
To: ddialliance/lion
Cc: Jon Johnson
Subject: Re: [lion] Rendering issue (#44)
This should now be fixed:
could you verify?
[https://cloud.githubusercontent.com/assets/794445/7133960/a3fed526-e298-11e4-8aa2-dbeeb574b7be.png]https://cloud.githubusercontent.com/assets/794445/7133960/a3fed526-e298-11e4-8aa2-dbeeb574b7be.png
—
Reply to this email directly or view it on GitHubhttps://github.com/ddialliance/lion/issues/44#issuecomment-92715007.

The UCL Institute of Education: Number 1 worldwide for Education, 2014 QS World University Rankings www.ucl.ac.uk/ioe

It is fixed. Thanks!!
Flavio


refactor mobile push to avoid a type of error CORE-8817

If the user get an audible push notification from an edit (because an @ message of them was edited into it), then we can get a black bar if that notification is clicked. The reason is that the logic for unboxing a message on an audible notification for caching purposes still attempts to compute the local notification text for a silent notification. That fails for an edit, and the user is presented with a black bar on Android.

@joshblum PTAL


Improved Aggregation of Errors

As a developer who is trying to see what distinct errors have recently happened in my application
I can be sure that each error in the Most Frequent panel really represents the same error
So that I don't accidentally ignore occurrences of different errors
See the below screenshot which has 43 "HttpException" errors that are actually mostly different errors under the covers:

When I drill into the error then i can see the recent occurrences are mostly different:

I'm not exactly sure how to solve this, but it's important to me as (I'm very lazy) I want to avoid having to drill through each error.
Yes, I know I should strive to get less errors :P

Are all of these being re thrown from an error handler with a new message? Do they all have the same stack trace? If they all have the same exact stack trace I'm not sure there is much we can do other then provide a custom stacking key?

@niemyjski Good call -- this is probably the case. I'll try to check it out in the next few days/week and come back with more information.

This issue was definitely on my end as I was rethrowing all exceptions and losing the inner exception. :)  Closing!


Spotify oauth redirect test

I have no clue, I saw it somewhere and some person said it is needed.... We'll see..


KAFKA-3182: Fix Transient Test Failure (kafka.network.SocketServerTest.testSocketsCloseOnShutdown)

Fixes https://issues.apache.org/jira/browse/KAFKA-3182 by:

Turning off Nagle on the sending sockets to force the socket to physically acknowledge after the first write in sendRequest
(Still had to do this on Linux though not on Mac) Adding a 10ms delay between writes (my guess would be Slow Start is to blame for this, but with Nagle off 10ms should more than suffice here imo)

Before:

After:

@hachikuji @ijuma FYI :)

@ijuma done made the delay between writes optional :)

@ijuma see my adjustment and comment in the code. Moved the wait inside the test method, this seems to really just be about the slow start. No need to hide the wait inside the send and cause confusion imo :)

ggg


fix broken TLF rekey harassments

fix the protocol to match the server here

i recently broke it with some server reshuffling, and it's just easier to change
the client with this PR then it is to go back and fix the server.

more debugging

Initial PR, let's add in @chrisnojima's fixes

Ok, this is ready for review:

@chrisnojima can you double-check the desktop patches?
@mmaxim can you help me review the Go stuff, and the gregor changes in particular?

Urg, CI failure due to race conditions with my gregor fix.  @mmaxim I think I might need some help here

👍 Gregor stuff looks good to me!

After a @chrisnojima thumb, I'll merge

👍


Update common files in release-1.3

Manually backports https://github.com/istio/cni/pull/163, https://github.com/istio/cni/pull/164, https://github.com/istio/cni/pull/170.
Update common files, define new lint targets, etc. to re-enable builds on release-1.3.
Disable Golang linters that are not yet enabled in master: funlen, bodyclose.
Fixes: https://github.com/istio/test-infra/pull/1790

@rlenglet: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_cni_release-1.3
805bfdc87233d97473936811f94edfa96e4128d0
link
/test lintmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_cni_release-1.3
805bfdc87233d97473936811f94edfa96e4128d0
link
/test lintmodern_cni_release-1.3

buildmodern_cni_release-1.3
805bfdc87233d97473936811f94edfa96e4128d0
link
/test buildmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

buildmodern_cni_release-1.3
805bfdc87233d97473936811f94edfa96e4128d0
link
/test buildmodern_cni_release-1.3

lintmodern_cni_release-1.3
2810544533c0d356f0c94d1342a8abd0ac54daa2
link
/test lintmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_cni_release-1.3
2810544533c0d356f0c94d1342a8abd0ac54daa2
link
/test lintmodern_cni_release-1.3

buildmodern_cni_release-1.3
2810544533c0d356f0c94d1342a8abd0ac54daa2
link
/test buildmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

buildmodern_cni_release-1.3
2810544533c0d356f0c94d1342a8abd0ac54daa2
link
/test buildmodern_cni_release-1.3

lintmodern_cni_release-1.3
3c2307c19282e87b8f975c4131a166e48b37050e
link
/test lintmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_cni_release-1.3
3c2307c19282e87b8f975c4131a166e48b37050e
link
/test lintmodern_cni_release-1.3

buildmodern_cni_release-1.3
3c2307c19282e87b8f975c4131a166e48b37050e
link
/test buildmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

buildmodern_cni_release-1.3
dd4f8d91d8a8c33949f74339866834ef31b0e177
link
/test buildmodern_cni_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lintmodern_cni_release-1.3 passed.

@geeknoid PTAL

The problem is versioning I think.

Update the common files in both master and in release-1.3
Update build jobs in test-infra to use the same container version.

This is not just a problem of versioning. Container-based build was enabled in https://github.com/istio/test-infra/pull/1790 without first backporting the changes to make that work in the release-1.3 branch. This is what this PR does.

@brian-avery @sdake I need your approval for this PR which fixes all builds in istio/cni:release-1.3.


wrap env::set_var in a closure

This is in preparation for https://github.com/rust-lang/rust/pull/124636, where we're making set_var unsafe. On old (pre-2024) editions, the unsafety error is downgraded to a warning so old code largely keeps working -- except when set_var is coerced to a function pointer, as is done by this crate (and by no other crate it seems); then the true type of set_var being an unsafe fn shines through and the build fails.
So to keep this crate building with future versions of rustc, wrap set_var in a closure such that the closure gets coerced to a function pointer, and set_var just gets called the normal way.

Thank you!

Thanks for the quick merge :)


Kata description does not load when not logged into Codewars

When you are not logged into Codewars the kata description for each kata does not load.
Just says -> Loading description.
None of my non-Codewars friends can see what I am solving.

The issue is more nuanced than that.
If someone has never been to Codewars before, following a link to a particular kata will not work and descriptions of the kata and comments are not visible due to a clientId not being null or a number.
However, if you first visit the katas list page, I think the clientId is then set, and you can visit any kata deep link with no issues.


update istio-routing docs

include info about c2c service mesh
update digrams with pretty ones
#167608290

Ping us in the #networking (cf slack) or #pcf-networking (pivotal slack) channels if you have any questions or edits.
cc: @tstannard

Thanks @ameowlia !!


Chart based on multiple chart

Hello, it will be amazing if there was a way to merge multiple charts from different accounts into one. To create like a chart with your friends.

This would be great. But He's not responding anymore too bad. And the Website site is kind of slow too


Search by more than just prefix (extension, wildcard, etc.)

Describe the solution you'd like
First - could be nice if ctrl+f would take you to the search box.
Second - could be very nice to search not only by prefix (maybe add an option to choose the kind of search).
If it is intended - maybe ctrl+f could be used to search like in web - just on the current view.

Hi @ohadbitt, are you trying to search a:

blob container
file share
adls gen2 blob container
something else?

Having the same problem when trying to find a file in a blob container. I don't understand what use prefix search has in any context as the default setting.

Blob files inside a container

totally agree is needs to be expanded on to use wildcard searches

Any update on this? We have thousands of files and some of our developers are not confident using command line azcopy. We need a proper search that has wildcard support. Postfix would be infinitely more useful than prefix.

+1 for this bummer it doesn't exist

a huge bummer, would really need this feature

Any update?

Any update? Being developed? Not being developed? Any reason?

Not being developed at this time, but it is something we (or at least I) try to think about every now and then.
Without API support, implementing this would not be a very good user experience for many of you. We can only list blobs 5000 at a time. So for a container with say a million blobs (not an uncommon number, many people have even more), that would take 200 API calls, that in many situations we cannot easily do in parallel. So if every API call takes 0.5-1 sec, well...you can do the math. And that's just for people with good internet. Imagine those on slower networks.
And then you think "well you could just list everything once when you open the container and cache it", we run into problems like:

Where do we cache it such that it can quickly be accessed and not cause other issues (slow down, too much memory, using too much disk space)
If we do it on disk, then we need to clean up the cache at some point, because there are going to be customers out there who do not want something a list of all the blobs in their containers persisted on their disk, but when do we clean up? if the cache is big enough, it could take some time (esp on Windows, which the majority of installs are) to clean that up. We don't want to make people wait on us to shut down.
How do we communicate to people if the caching is done, or why it is taking so long?
At some point the cache will be dirty and need to be rebuilt, but there's no good way to do that for just a small portion, so you just have to do all of it over again.

 That's going to cause perf issues not only wrt to your network, but depending on how we cache things, either disk or memory issues as well.
So ya, we (the Storage Explorer team) understand how much this would be helpful to y'all, but one thing we've learned over the years is that we can't ship an experience that is only good for some users/we have to be careful about what features we build that aren't supported by the Storage APIs.
I think if I was building on-top of Azure Storage today I would:

name my blobs such that I can take advantage of prefix listing
look into leveraging blob tags: https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-index-how-to?tabs=azure-portal

Of course, obviously it might be too late for you to do that if the thing you work on is already built so, sorry if that's the case. :(
We'll keep passing this feedback along to the service team (we really do!), and as soon as they add support, or as soon as we can figure out a good client side solution to the problem we'll get the work scheduled.
I'm sorry to not have a better answer for you. :(
PS: if you think you have a good idea for how to do this client side, feel free to share. :)

Thank you for the detailed explanation. It helps us at least understand that it is not a simple job.

What about leveraging Azure Purview API for search (if the Purview is used and the Storage account is part of the Purview scan)

PS: if you think you have a good idea for how to do this client side, feel free to share. :) PPS: if you think you have a good idea for how to this client side, and you want to do it on your own/not wait for us/prove us wrong, consider signing up for this preview: #4142 I could see a "search container" extension being a thing.

I have an idea that would be a good workaround.  Why not create a way in the API to export a list of the blob names to a text file?  That way we can import the text file into an editor that does let us perform a search on the string we're looking for.
2nd idea, why not just allow wildcard searches just in the portion that you have currently loaded?  You don't need to do the search on millions of blobs.. narrow it down first using the filter, THEN do a wildcard search on just that portion.  Even that would help us out greatly.

+1 adding my support - prefix search is practically useless - needs to allow full wildcard functionality

I can see that this is closed however can we get an answer why it was closed? We are literally writing our own third party tool to do this as its necessary to find files at times.

I also stumbled across this limitation recently in BlobStorages and was surprised that no wildcard syntax is supported.


No longer works

Today's update completely broke me, the container won't even run to allow me to update the config file.

Hi @LeeThompson can you let us know which tag you are using? We did update the latest tag to our new v3 and have found a few hiccups in there.
You were probably using a version that more closely matches the 2 tag. We'd suggest moving to that tag until you're ready for latest on our new v3 agent. We're about to release some documentation for going through the upgrade.

I'm on alpine

Ah yes. The alpine tag by itself will also track latest. We haven't upgraded in a long time. Apologies for the surprise here.

Working with 2.3.40 alpine now.   The docs on the website seem to all be 2.x oriented too, I had no idea what it was so unhappy with.

Yeah those should be flipping shortly. Tough to coordinate. Thanks for your patience and please let us know if you have any more trouble! We're going to add some docs pointing to the v2->v3 upgrade guide on this README as well.

Be sure to have notes for the docker image in the registry   With maybe a big bold 'be sure to do this before updating!' ;)

Thanks Lee!


Images  inside  are cut-off/hidden/collapsed

Hello, I am trying to make a reusable template with the MJML rendered HTML for our internal staff, and I render the HTML in try-it-live https://mjml.io/try-it-live/i7OgU9y6y. I opted to use  tag inside  instead of  for images because the staff responsible for creating newsletters do not know templating HTML and they would be using the default newsletter CMS' tools to upload/edit images, alt text, etc.
It works great on most clients except for Windows Outlook Desktop app. On Windows Outlook Desktop app, images are hidden/cut-off/collapsed - see screenshots with image spaces selected. I have tried removing height: auto/adding height: 100%, adding empty section, setting width on parent container, removing/setting line-height. Any help would be greatly appreciated. Thanks!
Reproduction Steps:
try it live version - 4.9.3 https://mjml.io/try-it-live/i7OgU9y6y
Expected behavior:
The images should display normally, not cut-off/hidden/collapsed.

Observed behavior:
The images are cut-off/hidden/collapsed when using  inside  for Windows Outlook Desktop app.
Screenshots and GIFs
Windows Outlook Desktop App

MJML version:
try it live version - 4.9.3 https://mjml.io/try-it-live/i7OgU9y6y
Email clients the bug is seen on:
Windows Outlook Desktop app

Reset line height on mj-text to 1 and it should be fineOn 18 Jan 2023, at 18:11, Leah W Chang @.***> wrote:
Hello, I am trying to make a reusable template with the MJML rendered HTML for our internal staff, and I render the HTML in try-it-live https://mjml.io/try-it-live/i7OgU9y6y. I opted to use  tag inside  instead of  for images because the staff responsible for creating newsletters do not know templating HTML and they would be using the default newsletter CMS' tools to upload/edit images, alt text, etc.
It works great on most clients except for Windows Outlook Desktop app. On Windows Outlook Desktop app, images are hidden/cut-off/collapsed - see screenshots with image spaces selected. I have tried removing height: auto/adding height: 100%, adding empty section, setting width on parent container, removing/setting line-height. Any help would be greatly appreciated. Thanks!
Reproduction Steps:
try it live version - 4.9.3 https://mjml.io/try-it-live/i7OgU9y6y
Expected behavior:
The images should display normally, not cut-off/hidden/collapsed.
Observed behavior:
The images are cut-off/hidden/collapsed when using  inside  for Windows Outlook Desktop app.
Screenshots and GIFs
Windows Outlook Desktop App
MJML version:
try it live version - 4.9.3 https://mjml.io/try-it-live/i7OgU9y6y
Email clients the bug is seen on:
Windows Outlook Desktop app
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Emails should be trimmed and lowercased for Gravatar

As per: http://en.gravatar.com/site/implement/hash/ email addresses need to be trimmed at lowercased in order to calculate the proper hash.
It would be nice if this line: https://github.com/HubSpot/facewall/blob/master/app/collections/employees.coffee#L35
could become this:
employee.gravatar = "https://secure.gravatar.com/avatar/#{CryptoJS.MD5(employee.email.trim().toLowerCase())}?d=#{defaultGravatarImage}"

Thanks!
Since the idea is that this data is coming from a server’s JSON response (or inline supplied JSON file), I think it’s reasonable for Facewall to assume that the email addressed are trimmed. However, I definitely agree it makes to lowercase them since the property name is email and not emailLowerCased or the like.


fix(Flows): flows.destory has been replaced by flows.remove

.destory is a legacy naming scheme, we use remove instead (see https://globus.github.io/globus-sdk-javascript/modules/_globus_sdk.html#md:service-method-names)
Adds temporary alias for destory to remove to avoid breaking change.

Are there tests that should be updated to use remove?

I was actually hoping we had tests for destroy that would cover the alias, with #16 handling the update/removal... but we don't have coverage for this specific method (uses serviceRequest).


Support standalone files for rust-analyzer

Language server
rust-analyzer
Requested feature
Rust-analyzer added support for standalone files in https://github.com/rust-lang/rust-analyzer/pull/8955. However, this requires "detachedFiles with the absolute paths to the standalone files passed as a field of the initialization options". Given my limited experience and lack of knowledge on LSP, I couldn't figure out what this means or how to do this. I assume this can be configured, so it'll be great if someone can make this work.
Other clients which have this feature
coc.nvim with coc-rust-analyzer

I would recommend using rust-tools, lspconfig is not going to add support for something specific to rust analyzer, we send NULL for workspaceFolders which should accomplish the same thing.


[Question]: How to enable nested virtualization

Is your question not already answered in the FAQ?

[ ] I made sure the question is not listed in the FAQ.

Is this a general question and not a technical issue?

[x] I am sure my question is not about a technical issue.

Question
Hi,
I'm trying to install vDSM on Portainer which is installed on an Ubuntu server vm on ProxMox.
I checked with: sudo kvm-ok
and it tells me:
INFO: /dev/kvm exists
KVM acceleration can be used.
However, when I am installing vDSM on Portainer it always tells me: "ERROR: KVM acceleration not available (device file missing), this will cause a major loss of performance."
I checked and "nested virtualization " is enabled so i don't know why this happens.....
Thanks in advance!

Did you add /dev/kvm to the container?
I don't know if you are using Docker Compose in Portainer or just created a stand alone container but you have to pass the device /dev/kvm to the container to get kvm work inside the container.
docker-compose
    devices:
      - /dev/kvm

docker-cli
--device=/dev/kvm


the navbar on mobile version doesnt work

as title

Works on my machine. Can you be more specific? What is "doesnt work"?

I've tested this with an iPhone running iOS 17 and Chrome on Android and it works like I expect it should.
Given this issue has been open for a year without more information, I'm going to close it as invalid.
If you are still experiencing this issue, please reply with more information as requested.


[Feature Request]: CLI flag for disabling progress

What happened?
The 'feature request' form seems broken so i have to use this bug report form, sorry.
When using the command in GitLab CI the progress bar produces a mess in the job log:

It would be good if for CI this command had a cli flag, to turn off the output of the progress bar for example --no-progress.
How to reproduce the bug

Push a laravel project to gitlab.com
Add a gitlab-ci job to run the php artisan config:check command in the ci script
Review the job-log

Package Version
1.0.2
PHP Version
8.3.0
Laravel Version
10.43.0
Which operating systems does with happen with?
Linux
Notes
No response

I'm adding this feature.  Thanks for the tip!

This feature has been implemented but is not yet been tagged in a release.


One less step to run

Codecov Report

Merging #33 (cf775f8) into main (5c128b5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   45.03%   45.02%   -0.01%
==========================================
  Files         220      220
  Lines       40002    40002
==========================================
- Hits        18013    18011       -2
- Misses      20022    20024       +2
  Partials     1967     1967

Impacted Files
Coverage Δ

transport/transport.go
77.68% <0.00%> (-1.66%)
:arrow_down:

badgerTrie/smt_merkle_proof.go
60.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c128b5...cf775f8. Read the comment docs.


fix files encoding to UTF 8

These were saved in windows-1252 😓 the characters that had their encoding changes was ‘ and ’

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   21.49%   21.49%
=======================================
  Files         110      110
  Lines        1475     1475
  Branches      105      105
=======================================
  Hits          317      317
  Misses       1099     1099
  Partials       59       59

Impacted Files
Coverage Δ

...els/Projects/Requests/UpdateProjectLabelRequest.cs
0% <ø> (ø)
:arrow_up:

...els/Projects/Requests/CreateProjectLabelRequest.cs
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5c1bc...d70311b. Read the comment docs.


Update openapi-typescript-generator to v0.1.17

This change includes a fix to non-JSON responses.
Non-JSON response are now not modified.

Replaces https://github.com/lune-climate/lune-ts/pull/770.
I'll regenerate the code in another PR.


Network: Adds support for notifying dependent networks when their uplink networks change config

This allows changes to a physical uplink network's dns.nameservers setting to be applied to dependent OVN networks that use it.

Testsuite passed

Testsuite passed

Testsuite passed

Testsuite passed


Fix test_multicast in shared-IP FreeBSD jails

Traditional Jails, aka shared-ip jails, do not have a fully virtualized
network stack.  One result is that attempts to bind <IP_ADDRESS> actually
bind the jail's IP instead.  The test should not assume that localhost's
address is <IP_ADDRESS>.

Thanks. I merged this here: f0cce6f83400c9f228d6c9fe527deab3411c27d2


[stable/openvpn] Add option to remove dhcp-option DOMAIN

What this PR does / why we need it:
The config that is pushed to clients includes dhcp-option DOMAIN <list of domains>, but not all clients support this configuration (e.g. Tunnelblick 3.7.5a) and raise a user-facing error when encountering this config. By making this config optional, we can remove client-facing errors.

/ok-to-test

/lgtm


Change year to one month ahead

@mcarans HNO data for 2025 was published and there was a request to get it into HAPI, so I changed the year calculation to one month ahead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.595%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
323

Relevant Lines:
373

💛  - Coveralls


[Bug fix] VMI with kernel boot stuck on "Terminating" status if more disks are defined

What this PR does / why we need it:
Currently when trying to delete a VMI that is defined with disks + external kernel boot, the VM/VMI is deleted but the virt-launcher pod is stuck on "Terminating" status.
This bug is caused since MountKernelArtifacts() function uses setMountTargetRecord() which overrides the previous mount records. Therefore these mounts aren't being unmounted causing the Pod to stuck. This PR adds a addMountTargetRecord() function which appends records to the existing ones, which is used now when mounting kernel artifacts.
In addition, for better robustness, now the functions to mount/unmount kernel artifacts are unexported ("private") and are used only by the main mount/unmount functions.
A new functional test is introduced to make sure this bug does not repeat itself.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2039976
Release note:

[Bug fix] VMI with kernel boot stuck on "Terminating" status if more disks are defined

/cc @dshchedr @enp0s3

Hi @iholder-redhat, thanks for the PR.
Can you please shorten the subject of the first commit?

Hi @iholder-redhat, thanks for the PR. Can you please shorten the subject of the first commit?

done.

/test pull-kubevirt-unit-test

/retest

/lgtm

/retest

/retest

@iholder-redhat Does make generate ends up without any changes?

@iholder-redhat Does make generate ends up without any changes?

Yup..
I've re-pushed. thanks.

@iholder-redhat Thank you!
/approve

/retest

/retest

/test pull-kubevirt-e2e-kind-1.22-sriov


Clarifies requirement for url encoding

Fixes #108 by adding adding a more explicit exception message when a invalid URL is provided. Also, adds documentation tests to make explicit that special characters must be url-encoded.

Can I request for the None value case, be taken care of here as well?
ATM, trying to .parse(None) results in TypeError: a bytes-like object is required, not 'str'. IMO, we should raise a more explicit exception.


Full logout needed after admin promotion

Description of the problem including expected versus actual behavior:
On account promotion to admin, the user can view the admin page, but there are errors for each of the views. The user must log out of ashirt and log back in to fix.
Steps to reproduce:
and

Log in as non-admin user, and as admin user.
Promote non-admin to admin
Attempt to view admin settings as new admin

Provide logs (if relevant):

This is known and expected behavior. A re-login is required on the backend, as permissions are tied to a user session. We can (and probably should) invalidate sessions when the user status changes. I think we do this when users get disabled, but maybe not when they're promoted, or demoted, from admin. If we do this, the user would still need to login again, but they'd be forced into it, rather than requiring an explicit log out/log in cycle.
I can look for other solutions as well.

So, the logic that logged someone out after a status change (either to admin or disabled) broke somewhere along the way. I'm looking into the best way to fix it now. Once it's done, it'll  behave as I noted earlier: a user will lose their session and be forced to log out. When they attempt to log back in, they'll have their new state (admin, disabled, or reversal to a normal user).


Update the docs copyright year

2016 is way old. It's now 2019 and our docs should reflect a
current year.
Signed-off-by: Eric Brown<EMAIL_ADDRESS>

I was reading up on this and their is a belief that if you update the date, then you're voiding the previous years as being able to claim copyright on former years. There is thread discussing it on stackoverflow here: https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated


How to get older releases of this extension

I have an issue with the new extension crashing when publishing to lambda. Even tried a brand new project. So maybe something with my machine. I was going to roll back to a previous extension, but the marketplace has no extension history. Is there an archive of older versions? I updated from <IP_ADDRESS> to <IP_ADDRESS> and want to go back. Unlike the extensions for vscode, there is no source and no releases.
Vscode: https://github.com/aws/aws-toolkit-vscode/releases
Vs: no source repo, no previous releases

Hi @LilMinmax can you please check your log files within %localappdata%\AWSToolkit\logs\visualstudio for some clues you can share around your issue? It's preferable to continuously stay on newer extension versions for bug fixes and newer functionality.

I figured out the issue, but it set me back a few hours that I needed to not be set back. I shouldn't have upgraded during a time where I'd be stressed if something broke, but that seems to be a lot lately and in this case I wanted to move a lambda to .net5 for reasons, and needed the docker image support. In this case I could have reverted to a previous version and kept working.
Will this end up a project like the VSCode extension with source and release history?
Feel free to close this after your reply. Appreciate it.

Thanks for the update @LilMinmax - was the issue something caused by the Toolkit that we could investigate?

Will this end up a project like the VSCode extension with source and release history?

This is on the roadmap!


feat: adding caching to GetLatestSchemaAsync

adding caching to GetLatestSchemaAsync to improve subsequent calls if a user sets: UseLatestVersion
I see those changes have already been made for Go

Thanks, caching was added in https://github.com/confluentinc/confluent-kafka-dotnet/pull/2226


Add 2.20 pre-release docs

Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

Why?
To be able to point users who want to use the new SD to proper docs, even in the RC phase.


Remove global channels in RPCBus source file, and find another way to implement them

The RPCBus had it's channels implemented as global variables due to simplicity (according to @ggoranov). However, this approach can be quite unsafe, as there is no guarantee that the correct component is reading a request - even if the intent is to only have the channel strictly between two components, this is not mentioned anywhere (as far as I can tell, if I missed it please let me know), and in such a case it would still be better to return it from a function call or something similar, so to not make that particular channel available to the rest of the code since it shouldn't be shared outside of those components in the first place. Anybody not properly familiar with this code could easily make a mistake that way.

+1
It should also be said that these global variables are actually a significant obstacle when trying to test or benchmark the components

Agreed! Go for it!

if the intent is to only have the channel strictly between two components, this is not mentioned anywhere

Nope, the intent was to provide Multi-Consumer support.
For instance, getLastBlock command could be handled by both chain component and database component`.
That said, while the chain component is busy verifying the latest block to be accepted, another component (like database) could also provide getlastblock to any consumer like block explorer without blocking.
But that's more like a hidden feature and it's not important for now.

Speaking about refactoring RPCbus, feel free to suggest more appropriate name for the component as RPCBus (remote procedure call) still sounds a bit misleading whereas RPCBus is for internal request-response communication only

I'm currently debating the idea of removing channels from the RPCBus altogether and basing it purely on callbacks.
Some pros would be:

Marginally more efficient (channels have been proven to be slower than mutexes)
Simplifies the RPCBus slightly, as it removes the need for a Request object altogether. Responders could simply register a function with a uniform signature. Requesters will then receive the return value on calling Call().
Simplifies tests. If the RPCBus works with callbacks there would be no need for setting up listening goroutines which can hang and cause race conditions.

Some cons would be:

Requires locking a few components. The mempool and the transactor come to mind, which currently work (to my knowledge) purely with channels, which allows them to be mutex-free.
Other components which make use of the RPCBus would need to be refactored to instead register a callback to the RPCBus.
No freedom for the caller to time-out the sending of a request, or the receiving of a response. May cause other components to be deadlocked.

I'd stick to the idea of a reactor-pattern for each component.  Both rpcBus and eventBus communicating via channels do support this rule perfectly.

Marginally more efficient (channels have been proven to be slower than mutexes)

If we really need to improve perf, I'd suggest to start with reviewing top10 bottlenecks (from go tool pprof).

Simplifies tests. If the RPCBus works with callbacks there would be no need for setting up listening goroutines which can hang and cause race conditions.

Don't we need already to set up listening routines due to the event-driven communication?
In general, to address this issue 73, I've chosen a different way of registering the methods as per https://github.com/dusk-network/dusk-blockchain/blob/master/pkg/core/transactor/transactor.go#L80.

Don't we need already to set up listening routines due to the event-driven communication?

Not with callbacks, as there is no listening routine involved. I'm talking specifically about instances like the reduction test file, where we need to set up this goroutine for the candidate block verification procedure.

In general, to address this issue 73, I've chosen a different way of registering the methods as per https://github.com/dusk-network/dusk-blockchain/blob/master/pkg/core/transactor/transactor.go#L80.

I don't really see how this gets rid of using global channels.
I will stick to channels for now, I've been in refactoring mode for the past week or so and the idea came to me as we're working to eliminate unnecessary asynchronism in the node to improve performance and simplify some code, but the change for the RPCBus to work purely on callbacks would be quite drastic and outside of the scope of this issue.

I don't really see how this gets rid of using global channels.

The suggestion from above uses package scoped variables (instead of global vars). If needed, these channels could be bundled as an instance variable. This addresses the this approach can be quite unsafe, as there is no guarantee that the correct component is reading a request as the Consumer component is responsible to self-registering.

This still could produce test complications which we are trying to avoid - for instance, if we added tests for the transactor package (which we probably should), and the test was running on any other setting than -p 1, these channels are still shared by the different tests and can cause hard to debug test failures.
Why not just opt for including the channels in the Transactor? Is there a specific advantage of using package scoped variables over just putting them as struct fields?

Why not just opt for including the channels in the Transactor?

Correct. This is what I meant by If needed, these channels could be bundled as an instance variable.

The current issue is actually related to testing, as posted earlier:

It should also be said that these global variables are actually a significant obstacle when trying to test or benchmark the components

This is also what I was talking about in my last comment. If you deem the setup to be a problem then open a seperate issue for it.


Fix issue 16026: std.math.frexp!float() wrong for very small subnormals

This PR fixes Phobos issue #16026: std.math.frexp!float() and std.math.frexp!double() return a wrong significand for subnormal values.
The problem turns out to be a wrong "magic number" 0x8000 which selects which values of the highest 16 bits should be preserved while manually changing the exponent using bitwise operations. The correct value is ~F.EXPMASK, which happens to equal 0x8000 for the 80-bit and 128-bit IEEE formats, but not for 32- or 64-bit.
(Ultimately, I intend to replace the entire frexp() implementation with a clearer and more concise one based on RealRep, but I realize that it may take a while to get such a large change pulled, so I thought I'd submit this quick fix in the mean time.)

Looks fine

@9il Can we pull this? It's just a tiny bug fix.

@klickverbot Thanks.


Multi-line comments broke

Mutli-line comments for C++ seems to be broken. If I disable "auto-comment-blocks.singleLineBlockOnEnter" shift-enter works fine, but if this is enabled, enter does not add a comment on the next line

Hey, thanks for letting me know. I'll look into it this week and get back to you.

I can't get it working on .css files.

Check if in setting you have this config "editor.autoIndent": "none", for me this was the problem


[chore] Binary releases.

This sets up CI/CD for binary releases when we make release tags.
It will not be ready to merge until I have thrashed on it some.
Fixes #53.

Okay, @noahdietz, I have this working now. It is not perfect but it is good enough. You can look at the GitHub Actions log to verify. (I deleted all of the releases I made while thrashing.)
Stuff to review:

Please review the versioning disclaimer in README.md and make sure you think it is reasonable.
Note how I am versioning the binary itself -- basically hot-swapping in cmd/api-linter/version.go. Someone who uses go get and go run will get the file in the repo; someone who downloads the binary will get the version number if they use api-linter --version.
Filenames end up being api-linter-{version}-{os}-{arch}.tar.gz.
The GitHub Workflow itself arguably has a flaw since it creates a release before doing anything else, meaning it will leave cleanup if a subsequent step fails. Given that a human needs to make the tag, I am okay with this for now.

Follow-on steps:

Automatic release notes. Doing this in the workflow is easy but I need to produce the notes. Once we have this, I will make releases not start in draft.


Remove api_key requirement for data library #3506

Refer to https://github.com/CartoDB/data-services/pull/137
@juanignaciosl please review

Frontend tests were OK :+1: (details)

@javisantana quick CR? Nacho seems having trouble with connectivity.

:es:

update de app_config.yml.example please

Sorry for the delay. I'd really avoid the usage of *.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

I've taken your comments into acount plus added the removal of the rollbar debug message in https://github.com/CartoDB/cartodb/commit/c15322d8221ace916356831db86d0450048f1c79

Ok, great. Warn about that message removal in #technology channel when it's deployed so people don't get scared.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Habit Tracker

Describe the project you want to add with tech stack
A front-end web application built using HTML, CSS, and JavaScript that allows users to add and track their habits, mark them as completed, and visualize their progress.
Expected behavior

Users can add habits and view them in the habit list.
Users can mark habits as completed or toggle their completion status.

Additional context (optional )
Please add the tag Gssoc'23.

I am a GSSOC'23 contributor. Please assign me this issue. I would love to work on it.

@pranjay-poddar, @MohitGupta121, and @Saurabh-kumar09 please assign me this issue.


Getting the confidence score of your detections? (darknet yolo (alexeyAB))

somebody know how to call the function that show confidence, i use detector test - etx output just got  x,y,width and height , now i need the confidence

thank you :)


ir: allow parsing boolean true/false as integers.

Sometimes LLVM writes i1s as true/false. This extends the parser to accept these.

bors merge


Implement individual-level line plots (phase 1)

Related ticket: https://github.com/VEuPathDB/web-eda/issues/1440
Phase 1 must haves:

X-axis parameter selector: constrain to time-related variables (date, age, study timepoint)...these could be continuous or discrete (ie, 5 study timepoints). possibly think about defining this parameter on a per-study basis (in the presenter file? or with annotations in the .owl?)
Y-axis parameter selector: constrain to continuous variables (we decided to handle the categorical vars in a separate strip plot viz tool, see https://github.com/VEuPathDB/web-eda/issues/1527)

Phase 1 nice to haves:

Stratification identifier (ie, facet plots by PID vs HHID, etc)
Sorting based on other variable(s) -- through faceting 2.0 (https://github.com/VEuPathDB/web-eda/issues/1501), which we anticipate rolling out BEFORE individual-level line plots

Phase 2:

plot carpets, https://github.com/VEuPathDB/web-eda/issues/1529

Do not start implementing until individual level line plot mockups receive final sign off in EDA UX meeting

Mockups are ready for EDA UX review: https://www.figma.com/file/SZwh2ZJnAG7ffRnR8tXZZs/Individual-Summaries?node-id=256%3A1145&t=VA44mZFtPAlDiKFI-0


slave vulnerable to DNSSEC amplification attack

Our slave does not define any firewall rules that stop DNSSEC amplificationn attacks and leaves that task to the docker host. We should introduce a mitigation that ships with the slave image.

This is currently not possible to do inside a docker container. iptables only works on the host. We should add a note in README.md.


Rename some test cases to be more accurate

Codecov Report
Base: 61.61% // Head: 62.18% // Increases project coverage by +0.57% :tada:

Coverage data is based on head (182fd43) compared to base (4da3872).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
+ Coverage     61.61%   62.18%   +0.57%
- Complexity      612      622      +10
============================================
  Files           109      110       +1
  Lines          2204     2211       +7
  Branches        267      268       +1
============================================
+ Hits           1358     1375      +17
+ Misses          776      766      -10
  Partials         70       70

Impacted Files
Coverage Δ

.../model/team/TeamNameContainsKeywordsPredicate.java
71.42% <0.00%> (ø)

...eedu/address/logic/commands/DeleteTeamCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Windows 10] npm install cash-global -g does not work

npm install cash-global -g

Error:
2.  'ls' is not recognized as an internal or external command, operable program or batch file.
C:\Users\Taslim>node -v
v6.11.2

C:\Users\Taslim>npm -v
3.10.10

Am i doing something incorrect?

Duplicate of #83

Unfortunately, I don't think we ever solved this issue. I'm not very knowledgeable in this area.

Hi this isn't fix but if you you Windows PowerShell LS works but TOUCH doesn't in replacement for touch I use new-item it's the same way to create a file. Just my own work around after my own research until i await a fix.
Little Example Below hope it helps fellow users.
PS C:\Users\Taslim\desktop> mkdir test

    Directory: C:\Users\Taslim\desktop

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/25/2017  10:01 PM                test

PS C:\Users\Taslim\desktop> cd test
PS C:\Users\Taslim\desktop\test> new-item test.js

    Directory: C:\Users\Taslim\desktop\test

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       10/25/2017  10:01 PM              0 test.js

PS C:\Users\Taslim\desktop\test> ls

    Directory: C:\Users\Taslim\desktop\test

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       10/25/2017  10:01 PM              0 test.js

Alternatively i did this just to got all the commands through Unxutils which is just a port which works on windows.
https://www.julienklepatch.com/improve-windows-command-line/#section2
Steps to install
1. Download Unxutils and unzip it to your `C:\`
2. Rename the folder to `unxutils` to have it all lowercase letters.
3. Navigate it to add environment variables. search `edit system environment variables` on win 10
4. A window called System Properties will show up and if you not in the `Advanced Tab` click that tab and at the bottom you'll see `Environment Variables`
 5. Then click `new` and window will pop up asking you to input the variables.
```
Variable name: PATH
Variable Value: C:\unxutils\usr\local\wbin
```
6. Then click ok.
7. Use Windows PowerShell everything will works as it should.
Hope this helps anyone.


SFAS to SIMS Bridge - CSL/BCSL Overawards

User Story
The layout of the bridge file from SFAS to SIMS was updated to match the actual data being sent. This also means correcting the existing data in our environments. Any value we have previously received as BCSL Overaward was actually CSL Overaward and vice versa. This is FT impacting ONLY.
Acceptance Criteria

[ ] Update all current Legacy overawards to swap what we have

[ ]  BCSL to CSLF
[ ]  CSLF to BCSL

[ ] Current production data must also be fixed with this
[ ] ensure that bridge file process is stopped during release process for this ticket

Additional Context
Bridge file document will be updated to reflect this change (the data has always been correct, this is just a swap of the labels)

Technical

[ ] Adjust the current import fields to read the right fixed position for the two fields.
[ ] Create a DB migration to switch the values, ensuring a possible rollback. Suggestion to create columns to allow switch/rollback.

@CarlyCotton Even overawards have not been used yet they are already being imported and they may be potentially already be associated with students in the table sims.disbursement_overawards as origin_type Legacy overaward.
The recommendation would be to have them deleted from the sims.disbursement_overawards without a rollback script expecting that they would be recreated in the execution of the SFAS-SIMS bridge import. Does it make sense?

@andrewsignori-aot would the next bridge import process update ALL overaward records or just for the students on that latest bridge file?


Extension for PR #497 - new $x() and $$x) inside SelenideElement

Addition for https://github.com/codeborne/selenide/pull/497
Now we can use $x and $$x in methods call chains

Changes Unknown when pulling 6d739c052058e5f4c217f7c79c2850696c2c9eb6 on ddemin:xpath into ** on codeborne:master**.

Codecov Report

Merging #503 into master will increase coverage by 0.12%.
The diff coverage is 95.23%.

@@             Coverage Diff              @@
##             master     #503      +/-   ##
============================================
+ Coverage     58.77%   58.89%   +0.12%
- Complexity      690      695       +5
============================================
  Files           131      131
  Lines          2605     2620      +15
  Branches        263      265       +2
============================================
+ Hits           1531     1543      +12
- Misses          969      971       +2
- Partials        105      106       +1

Impacted Files
Coverage Δ
Complexity Δ

...java/com/codeborne/selenide/commands/Commands.java
97.89% <100%> (+0.04%)
17 <0> (ø)
:arrow_down:

.../java/com/codeborne/selenide/commands/FindAll.java
100% <100%> (ø)
3 <3> (+1)
:arrow_up:

...ava/com/codeborne/selenide/impl/ElementFinder.java
82.75% <100%> (ø)
17 <0> (+1)
:arrow_up:

...ain/java/com/codeborne/selenide/commands/Find.java
100% <100%> (ø)
4 <4> (+1)
:arrow_up:

.../com/codeborne/selenide/impl/WebElementSource.java
92.85% <83.33%> (-2.98%)
17 <6> (+3)

...e/selenide/impl/WebDriverThreadLocalContainer.java
77.08% <0%> (-1.39%)
29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9227123...6d739c0. Read the comment docs.

@ddemin As I understand this PR bring possibility to write such code?
$x("//div").$x("//a")

What is the main value?

XPath - not only a // construction...
You can use something like $x(someByOrCssLocator).$x("./somexpath_locator_from_parent_node")

First of all $x() accepts only String parameter, so $x(someByOrCssLocator) is incorrect.
Second why just not use $x("/div/a") ?

It was a typo and it fixed already.
Second - as I know we need point to current context by '.'

Oh man, - I've just implemented the same feature in my fork. My bad not to check already existing pull requests ).
The only thing I want to ask - wouldn't it be better to add 2 dedicated Commandtype classes

com.codeborne.selenide.commands.FindByXpath
com.codeborne.selenide.commands.FindAllByXpath
Instead of adding a parameter to already existing class com.codeborne.selenide.commands.Find?
Having dedicated classes looks more like following the project architecture.
Moreover, in this case, no need to alter any other, already existing classes/methods.
Take a look at this commit for details.

@SergeyPirogov about main value, let me give a code example:
Before:
SelenideElement form = $x("//div[@id='login-form']");
SelenideElement userName = form.$(By.xpath(".//input[@id='email']"));
SelenideElement password = form.$(By.xpath(".//input[@id='password']"));

After
SelenideElement form = $x("//div[@id='login-form']");
SelenideElement userName = form.$x(".//input[@id='email']");
SelenideElement password = form.$x(".//input[@id='password']");

Sure we can use other locators here instead of xpath, but let's assume we can't.

@JustAlexOne I agree, adding 2 new classes FindByXpath/FindAllByXpath would be better.
@ddemin Can you do that?

Closing this PR because another one did the same job: #533
Anyway, thank you @ddemin!


loop quit twice in reactor/s03/test6.cpp

event loop quit() twice here, then wakeup() in EventLoop sometimes fails and prints garbage info on screen.

steps to reproduce?


Sync to live

Docs Build status updates of commit 8b1a66a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/consume-packages/Overview-and-Workflow.md
:white_check_mark:Succeeded
View

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/create-packages/Creating-a-Package.md
:white_check_mark:Succeeded
View

docs/guides/Create-UWP-Packages.md
:white_check_mark:Succeeded
View

docs/guides/media/UWP-BatchBuild.png
:white_check_mark:Succeeded
View

docs/guides/media/UWP-PackageExplorer.png
:white_check_mark:Succeeded
View

docs/install-nuget-client-tools.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-the-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio.md
:white_check_mark:Succeeded
View

docs/quickstart/install-and-use-a-package-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/reference/migrate-packages-config-to-package-reference.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/what-is-nuget.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@karann-msft OK to merge master to live?

Docs Build status updates of commit 7295468:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@zivkan Thanks for your comments! Updating the PR now.

Docs Build status updates of commit 7295468:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/consume-packages/Overview-and-Workflow.md
:white_check_mark:Succeeded
View

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/create-packages/Creating-a-Package.md
:white_check_mark:Succeeded
View

docs/guides/Create-UWP-Packages.md
:white_check_mark:Succeeded
View

docs/guides/media/UWP-BatchBuild.png
:white_check_mark:Succeeded
View

docs/guides/media/UWP-PackageExplorer.png
:white_check_mark:Succeeded
View

docs/install-nuget-client-tools.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-the-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio.md
:white_check_mark:Succeeded
View

docs/quickstart/install-and-use-a-package-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/reference/migrate-packages-config-to-package-reference.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/what-is-nuget.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[SPARK-35841][SQL] Casting string to decimal type doesn't work if the…

… sum of the digits is greater than 38
What changes were proposed in this pull request?
Since Spark 3.1.1, NULL is returned when casting a string with many decimal places to a decimal type. If the sum of the digits before and after the decimal point is less than 39, a value is returned. From 39 digits, however, NULL is returned.
This worked until Spark 3.0.X.
Code to reproduce:
A string with 2 decimal places in front of the decimal point and 37 decimal places after the decimal point returns null
val data = Seq(
      "28.9259999999999983799625624669715762138",
      "28.925999999999998379962562466971576213",
      "2.9259999999999983799625624669715762138"
      )
val df = data.toDF("num")
df.withColumn("numConverted", col("num").cast("decimal(38, 5)")).show()

before this pull request, the result is
+----------------------+---------------+
|                 num          |numConverted|
+----------------------+---------------+
|28.92599999999999...|                  null|
|28.92599999999999...|         28.92600|
|2.925999999999998...|           2.92600|
+----------------------+---------------+
the correct result should be
+----------------------+---------------+
|                 num          |numConverted|
+----------------------+---------------+
|28.92599999999999...|         28.92600|
|28.92599999999999...|         28.92600|
|2.925999999999998...|           2.92600|
+----------------------+---------------+
The problem occur because of  https://issues.apache.org/jira/browse/SPARK-32706 by the fast fail by checking precision length, which should only check the whole number part length of the input value, not the precision lenth
Why are the changes needed?
correctness
Does this PR introduce any user-facing change?
no
How was this patch tested?
test added

Can one of the admins verify this patch?

@cloud-fan @maropu can you review this code, since two of you had review pr #29731

thanks, merging to master/3.1!


Yield the generated input id in block form

This PR contains two changes in one:

Adds tests for the case when validated-input is used with a block
Passes the generated input id as part of the yielded hash

I can certainly split these up if that is desired, but I wanted to have no 1 while I was working on no 2 to make sure I didn't break anything. Reviewing the commits separately is probably a good idea.
Passing the id is useful for using the generated label with a custom input
If you choose to provide a block to validated-input as described in the documentation, you can no longer use the generated label because the for attribute on that label doesn't point to your input. This means the user doesn't have the functionality of clicking the label to focus the input:
{{#validated-form model=person as |f|}}
  {{f.input name="firstName" label="First Name" as |fi|}}

      <input
        type="text"
        name={{fi.name}}
        class="{{fi.class}} {{fi.controlClass}}"
        value={{fi.value}}
        oninput={{action fi.update value="target.value"}}
        onblur={{action fi.setDirty}}
      />
  {{/f.input}}
{{/validated-form}}

First Name

  <input type="text" name="firstName" class="form-control" value="Max" />

With this change, you can now do that by setting the id on the input like this:
 {{#validated-form model=person as |f|}}
   {{f.input name="firstName" label="First Name" as |fi|}}

       <input
         type="text"
+        id={{fi.inputId}}
         name={{fi.name}}
         class="{{fi.class}} {{fi.controlClass}}"
         value={{fi.value}}
         oninput={{action fi.update value="target.value"}}
         onblur={{action fi.setDirty}}
       />
   {{/f.input}}
 {{/validated-form}}

First Name

  <input type="text" id="element52-input-firstName" name="firstName" class="form-control" value="Max"/>

Alternative ways to do this would be to not use {{validated-input}}, or to also provide a custom label component and generate my own ids for them.
Hopefully that's useful!

Thank you for this well-written pull request @kimroen! :100: To me this seems very reasonable, and the additional tests are very welcome! I'll leave the formal review to @anehx though, since I haven't had the chance to work with ember for a while :wink:


Luci 0.12

What is the point of this pull request?
0.12 is older stable branch. Everything that is there, is already in the trunk...

It looks like a mistake to me. @kosjak - was that intentional?


simple git syncing?

[x] check if blitzdb file backend works to sync
[x] git refs should not be in /refs/datmo (make this a config)

We currently have this in the README at the end but it still isn't completely verified. This is still a "BETA" feature

We created a way to do sharing that is not supported in case others want it, but closing this for now.


lib folder not included in npm package

Looks like the lib folder was not published with the package<EMAIL_ADDRESS>This causes the plugin to crash since it imports from lib

Doh!
Thank you - fixed now with v3.0.2 which is ready for download


MAC 0.15 dev, assets are not compiled

Landing page after installation and subsequent reloading of application and server. Assets are not compiled. No way to login?

Thanks for reporting this @ed - I remember seeing this last August.  We will work on this today.


4.x - MiddlewareDispatcherInterface

We will need to introduce a new interface in order to enable users to drop in their own MiddlewareDispatcher
Since we won't be able to rely on the constructor, we need methods to set the following:

add() - Untyped method to add a MiddlewareInterface, a string for deferred callables or a callable
addMiddleware() - Typed method to add only MiddlewareInterface for people who enjoy stricter typed approaches
setKernel() Set the kernel or "tip" of the middleware stack
setCallableResolver() Set a CallableResolver, for resolving all middleware class names / callables. Currently we are injecting ContainerInterface inside of MiddlewareDispatcher and duplicating some of the logic from within CallableResolver. That needs to be changed once we modify CallableResolver to handle all that logic.

Here is the proposed interface:
<?php
declare(strict_types=1);

namespace Slim\Interfaces;

use Psr\Container\ContainerInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

interface MiddlewareDispatcherInterface extends RequestHandlerInterface
{
    /**
     * Add a new middleware to the stack
     *
     * Middleware are organized as a stack. That means middleware
     * that have been added before will be executed after the newly
     * added one (last in, first out).
     *
     * @param MiddlewareInterface|string|callable $middleware
     * @return self
     */
    public function add($middleware): self;

    /**
     * Add a new middleware to the stack
     *
     * Middleware are organized as a stack. That means middleware
     * that have been added before will be executed after the newly
     * added one (last in, first out).
     *
     * @param MiddlewareInterface $middleware
     * @return self
     */
    public function addMiddleware(MiddlewareInterface $middleware): self;

    /**
     * @param RequestHandlerInterface $kernel
     * @return MiddlewareDispatcherInterface
     */
    public function setKernel(RequestHandlerInterface $kernel): self;

    /**
     * @param CallableResolverInterface $callableResolver
     * @return self
     */
    public function setCallableResolver(CallableResolverInterface $callableResolver): self;
}

Why not MiddlewareCollectionInterface with a method createHandler(): RequestHandlerInterface?
$middleware->add(...);
$middleware->add(...);
$handler = $middleware->createHandler();
$response = $handler->handle($request);

I can't help but feel like all of this would be easier with two factories for deferred and callable middleware:
$callableMiddleware = new CallableMiddlewareFactory($callableResolver);
// This creates a CallableMiddleware instance around $callable that will
// be resolved using the $callableResolver when invoked.
$middleware = $callableMiddleware->create($callable);
assert($middleware instanceof MiddlewareInterface);

$containerMiddleware = new ContainerMiddlewareFactory($container);
// This creates a ContainerMiddleware instance around $identifier that will
// be resolved using the $container when invoked.
$middleware = $containerFactory->create($identifier);
assert($middleware instanceof MiddlewareInterface);

I want to give full control over middleware dispatching. That's the whole purpose of this interface. Then nobody can complain anymore 😂

I'd rather leave just addMiddleware() and if someone want's to use string, callable or whatever he should convert it to the MiddlewareInterface with some factory:
$x->addMiddleware($someMiddlewareFactory->create('foo'));
$x->addMiddleware($someMiddlewareFactory->create([$foo, 'bar']));

That would make the interface more SRP/DRY
Also maybe a bit off topic question, maybe not, I've seen that there's try/catch that catches exceptions and calls an error middleware - is there any reason for this? Why the error middleware can't be just added to the stack as all other middlewares? Ignore the question if you feel that it's completely not related to this issue

I'd rather leave just addMiddleware() and if someone want's to use string, callable or whatever he should convert it to the MiddlewareInterface with some factory:

We can't do that. The internals need to be able to add deferred callables (string) / callables.

Can't find now the code i'm talking about, i guess i've seen it somewhere in the issue/pr comment, not in the slim, so all is well

@jacekkarczmarczyk in Slim 3 it was coupled to the core https://github.com/slimphp/Slim/blob/3.x/Slim/App.php#L390-L397 if that's what you're talking about. This has all been extracted to middleware in Slim 4 via ErrorMiddleware

Oh yeah, that was it


Add excelize normal API to group rows and columns

Codecov Report
Attention: Patch coverage is 85.86957% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (3c4c059) to head (4710ef1).

Files
Patch %
Lines

pyfastexcel/core/writer.go
85.86%
9 Missing and 4 partials :warning:

:exclamation:  There is a different number of reports uploaded between BASE (3c4c059) and HEAD (4710ef1). Click for more details.
HEAD has 5 uploads less than BASE

Flag
BASE (3c4c059)
HEAD (4710ef1)

6
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   96.82%   87.36%   -9.46%
==========================================
  Files          15        4      -11
  Lines        1574      467    -1107
==========================================
- Hits         1524      408    -1116
- Misses         39       44       +5
- Partials       11       15       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.