Remove deprecated gateway ports

Removed in favor of eastwest gateway
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
556ad92ec6e88c0ccd64b4a001f815686ff21bc9
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
556ad92ec6e88c0ccd64b4a001f815686ff21bc9
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
556ad92ec6e88c0ccd64b4a001f815686ff21bc9
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Git Webhook error

This issue comes up very randomly where the webook tests fail and receive this message.
~/platform-changelog-go$ make test-github-webhook
curl -X POST -H "X-Github-Event: push" -H "Content-Type: application/json" --data<EMAIL_ADDRESS>http://localhost:8000/api/v1/github-webhook
{"msg": "Not a monitored branch"}

~/platform-changelog-go$ make test-gitlab-webhook
curl -X POST -H "X-Gitlab-Event: Push Hook" -H "Content-Type: application/json" --data<EMAIL_ADDRESS>http://localhost:8000/api/v1/gitlab-webhook
{"msg": "Not a monitored branch"}j

This may be resolved by #24


Improve UX for password validation

There could be 2 additional validations for password strength, because currently only the character length is checked (I think client-side only at the moment), so for example:

add client-side password strength validation: checking at least 1 special character / capitalized letter
add API-level validation in the JSON schema

Both could perhaps use the same regex if possible
This should match exactly the same validation as the one on Auth0 (which can be configured as well)

@robinv85 this is implemented F/E now (https://github.com/FightPandemics/FightPandemics/blob/1ae090dc0a094b979c1cc579aab194e45b9a6f56/client/src/utils/validators.js#L12) but not on API-level validation (although also checked by Auth0).
Should we close this one as resolved and open a low priority one for B/E or are we good?

@joshmorel yeah so I remember adding that more detailed password validation for client-side validation in the forms.
I thought it was also asked by designers to show the validation rules below the text input when signing up, and not only show the error message if it's invalid. (so that is also "improving UX" for the password validation).
There are also mobile apps that should get the same validation but if the backend doesn't have validation in the API schema then there is still Auth0 who has the final call about this so I guess it's rather low priority indeed.
Not sure why it would be better to close this and create a new ticket though.

@robinv85 My rationale was to have a backend specific issue since the F/E seems to be addressed.

@joshmorel fine by me. We could also update thi issues and specify that it's for the backend only.
The other thing that I mentioned, not sure if that is fixed: "show the password validation rules to the user, before they have to enter it", so probably as a green text below the input field.
Since that was mentioned on Slack but might be be clearly shown in the designs or in the requirements.


[WIP] Add AES encryption support to ZipFile

A work-in-progress attempt to add AES encryption support to ZipFile.
Notes:
There is currently no way to tell ZipFile what encryption algorithm to use when adding entries, so the only way to add an AES entry is with the variant of Add() that takes a ZipEntry (and set the AESKeySize property on it). Perhaps needs to be considered together with #380.
I copied the AddExtraDataAES function from the zip stream code, it would be better being shared somewhere. (an extension method on ZipExtraData maybe?)
It tweaks the logic in GetOutputStream() to try to ensure that the crypto streams returned from it are disposed - perhaps could be a separate PR as it might be a sort of existing issue with it not disposing streams when it should?
The Write() overload in ZipAESEncryptionStream takes the same approach as ZipOutputStream and calls the crypto transform TransformBlock() on each write. I'm not sure if that is technically correct, or if it should store the data and transform it in complete blocks? (or perhaps it doesn't matter with the way the transform is implemented)
Doesn't yet add any new unit tests (would likely end up conflicting with other PRs in the same area, could maybe do with a pass over later to see what state the various separate encryption tests are in)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

not sure what happend to the CI build there, it says
Exception calling "UploadFile" with "2" argument(s): "Unable to connect to the remote server"

which sounds like a server side error

With regards to the AddExtraDataAES bit - is there any value in adapting that into the TaggedData machinery (ExtendedUnixData/NTTaggedData etc) rather than having the structure inline at the points where it's read/written?

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/ICSharpCode.SharpZipLib/Encryption/ZipAESEncryptionStream.cs  2

See the complete overview on Codacy

Some things to be decided:

The API to use for enabling AES encryption.
I was working #380 towards adding a common enum for both apis, so possibly a property of type ZipEncryptionMethod would be sufficient?

The logix for when to 'apply' encryption to the entries (does it set the AESKeySize properties on new entries in the Add functions, as soon as the entries are added, or when the updates are commited, when it knows both the current setting and current password)

It also possibly needs checking for how it handles (or not) directory entries that have AESKeySize set - it doesn't do the encryption machinery for folders like ZipOutputStream does, so might need to review things like EncryptionMethodForHeader being used for directories.

Yeah, I think that's ideal

I would presume that setting it when committing the updates is less error-prone. Do you see any down sides to it?

I can't think of any, just need to document that entries are encrypted based on the value of the setting at that point (in case anyone gets the idea that you can add multiple entries with different and/or some/no encryption in one go).
The ZipCrypto case already decides what to do based on if the password is set when the updates are run, so it's consistent with that as well.


Update Find Courses for Non Mobile Courses

Description
LEARNER-95

Codecov Report

Merging #913 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   43.52%   43.52%   +<.01%
==========================================
  Files         385      385
  Lines       26288    26267      -21
==========================================
- Hits        11441    11434       -7
+ Misses      14847    14833      -14

Impacted Files
Coverage Δ

Source/EnrolledCoursesFooterView.swift
87.17% <ø> (+2.86%)
:white_check_mark:

Source/EnrolledCoursesViewController.swift
74.19% <ø> (+8.78%)
:white_check_mark:

Source/OEXStyles+Swift.swift
84.78% <0%> (-3.27%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226e13e...38fdaa3. Read the comment docs.


Type PermissionName for Permission API doesn't contain microphone and camera devices

🔍 Search Terms
microphone, camera, device, permission, state, API, navigator
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
In both files, webworker.generated.d.ts and dom.generated.d.ts in line 9361 and 27992.
The modification would be add two terms in the type PermissionName. 'camera' and 'microphone' to check access in both devices
📃 Motivating Example
  const checkForPermission = (type: PermissionName) => {
    navigator.permissions
      .query({
        name: type,
      })
      .then(permissionStatus => {
        // Will be 'granted', 'denied' or 'prompt':
        console.log(permissionStatus);
        // permissionStatus.state = 'granted'
        // Listen for changes to the permission state
        permissionStatus.onchange = () => {
          console.log(permissionStatus.state);
        };
      });
  };

  checkForPermission('microphone');
  checkForPermission('camera');

Expected behavior:
'microphone' and 'camera' should be valid types for PermissionName type.
Actual behavior:
'microphone' and 'camera' are not valid types for PermissionName type.
Typescript is showing error:
Argument of type '"microphone"' is not assignable to parameter of type 'PermissionName'.
💻 Use Cases

What do you want to use this for?
Check if camera or microphone are enabled/disabled

What shortcomings exist with current approaches?
To type the promise from navigator.permission in typescript, we have to add a inclusion on type PermissionName like: { PermissionName } & { name: 'camera' | 'microphone' }.

What workarounds are you using in the meantime?
I'm using it: { PermissionName } & { name: 'camera' | 'microphone' }

See https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1129

It appears that the name field of the PermissionDescriptor passed to Permissions#query is now simply specced as DOMString.
There is a permissions registry, but the number of entries is pretty limited, with 4 standardized permissions and 3 provisional permissions (as I write this).
So maybe it would be better for PermissionName to just become an alias of string (or preferably something that accepts any string but still autocompletes).


HTML Minification

Is there a way to minify rendered output?

Currently we are not integrate this feature in our package. If you wish to implement this, simply use this code to minify your output:
$html = preg_replace('~>\s+<~', '><', $html);


[Proposal] Add full-screen dialogs elements to Dialog.fullscreen widget  from Material 3 specs

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Show a full-screen dialog that is compatible across all platforms and is up to material 3 specs, this widget will co-exist with the previously added Dialog.fullscreen() and will provide parameters to ensure following  the m3 specs and great dev experience.
Proposal
In order to prevent redundancy and having to re-implement this functionality on each and every app the developer makes or needing a third-party package, this widget will provide an easy way to create Full screen dialogs as per material 3 specs and will be equivalent to the Dialog widget too

Hi @Alex-web0, Dialog.fullscreen already supports material 3. See https://github.com/flutter/flutter/issues/104961.
Is there a missing feature you'd like us to add?

Hey @danagbemava-nc, thanks for responding.
I wanted to create something more like the "Alert Dialog" which matches the specs perfectly and has input fields directly like "title" and "content" which is going to make it easier and more time saving than having to implement the children of the Dialog.fullScreen from scratch.

We can add a headline, divider close and action button from the specs to fullscreen dialog

cc: @HansMuller

We can add a headline, divider, close and action button from the specs to the fullscreen dialog.

That would be great! Thanks!

Is there any intention to optionally show this header/app bar?
While I'd love to see this be implemented officially, I am sure there are cases where you might want to try out a different header or have it hidden completely.

That is a great suggestion, but as this is not common and the goal of the FullScreenDialog is to match the approach and spec s of material 3, I think the best course of action is to implement your own full screen dialog using Dialog.fullScreen()


Object unions

Hey, is it currently possible to have any kind of Reason code that would cause genType to output something like this (in flow):
// @flow
type text = {
  type: 'text',
  value: string,
  fontSize: number,
};
type icon = {
  type: 'icon',
  path: string,
};
type union = text | icon;
// flow can refine the type
const print = (content: union) => {
  if (content.type === 'text') {
    console.log(content.value);
  }
  if (content.type === 'icon') {
    console.log(content.path);
  }
}

I'm aware of the current behavior of converting variants to objects with a tag and value. It's nice if one can control the Js side implementation, but problematic if one cannot.

@TomiS any Reason type that maps to text | icon would require custom case analysis on the Reason side, and the case analysis would not be expressible directly in Reason.
What one could do instead is to keep the type abstract in Reason, and share the responsibilities between Reason and JS, as in e.g.:
<EMAIL_ADDRESS>"./TheJsFile"]
type union;

type text = {
  type_: string,
  value: string,
  fontSize: int,
};

type icon = {
  type_: string,
  path: string,
};

<EMAIL_ADDRESS>"./TheJsFile"]
external getText : union => option(text) = "getText";

<EMAIL_ADDRESS>"./TheJsFile"]
external getIcon : union => option(icon) = "getIcon";

The implementation of getTest and getIcon would then be doen in JS, which knows about the union type.

Thank for help! Closing.


Add support for Ubuntu

Is there a way to run this project in Compute Engine/Ubuntu/Debian. Because currently it only supports App Engine.

Not at this time.  However, we do have long-term plans to migrate to Kubernetes.

Kubernetes is still fine, any successful run from Kubernetes?

We are currently running our proxies from Kubernetes (see the proxy sub-project at https://github.com/google/nomulus/tree/master/proxy).  We haven't even attempted to run the main application from kube yet.


Why the customers with 0 frequency has greater monetary value than others?

Before I create this issue, I should say thank you to the all contributors about this great open source library.
Question below,
Why the customers with 0 frequency(id 3,4,5,8,10 below) have greater monetary value than customer 2,8,9?
print ggf.conditional_expected_average_profit(
        summary_with_money_value['frequency'],
        summary_with_money_value['monetary_value']
    ).head()
"""
customer_id
1     24.658616
2     18.911480
3     35.171003
4     35.171003
5     35.171003
6     71.462851
7     18.911480
8     35.171003
9     27.282408
10    35.171003
dtype: float64
"""

I realized that "how" and "where" this results comes from. But I'm still curious "why" it should be. Is it intended?
def conditional_expected_average_profit(self, frequency=None, monetary_value=None):
     """
     # ...
     individual_weight = p * frequency / (p * frequency + q - 1)
     population_mean = v * p / (q - 1)
     return (1 - individual_weight) * population_mean + individual_weight * monetary_value

@HunjaeJung good question - just for clarity and discussion, can you post the original data for those customers (i.e. the freq, rec, and M values)

Hi @HunjaeJung,
One thing about BTYD models is that they tend to treat customers with frequency=0 as non-informative. That is, if we've only seen one that customer one time, it is difficult to infer their average behaviour since we don't have any repeated data points.
That Gamma-Gamma model of monetary value is similar in that it doesn't claim to know the average purchase amount for frequency=0 customers since we've only seen one data point. So instead, the model assigns all those customers' expected average purchase amounts to be the same as the population mean.
So its not that those customers have a greater monetary value, rather, in this model they're just set to have the mean monetary value. We should expect to see a roughly similar number of customers with monetary values even greater than the frequency=0 customers.
There is a bit of discussion about this in http://www.brucehardie.com/notes/025/ :

We note that this is the weighted average of the population mean, E(Z), and the
observed average transaction value, \bar{z}. As the number of observations (x)
used to compute \bar{z} increases, less weight is placed on the population mean
and more weight is placed on the customer’s observed average.

We can see this in the function conditional_expected_average_profit -- if frequency=0, then it returns population_mean, but for large frequency the individual_weight term dominates and the population_mean is down-weighted. Intuitively, if we have many observations from an individual customer, we will put more weight on that customers average, otherwise default to the population mean.

@CamDavidsonPilon
Thanks for reply, It's just from README.md of this repo :)
@rhydomako
Thanks for clear explanation. "Non-informative" was the reason!


Allow use of variable to set nonce

It will make it possible to use vars to set the nonce value. Like this:
location /download {
    g2o        on;
    g2o_nonce  $token; # consider that var has already been set
    g2o_key    "a_password";
}

Hi @dx7,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

Merged, thanks

Great! You're welcome.
BTW I'm working to allow nginx vars on g2o_data_header and g2o_sign_header too. I'll need that. Can I pull request that change too?

If I understand correctly, you have one nginx server getting requests from multiple Akamai configurations, that have different g2o parameters, and you want to choose the correct one according to the domain.
If that is the case, maybe it makes more sense to refactor the code a bit - instead of supporting vars in all conf params, it would probably be better to define a block for each Akamai config, and choose a block using some var.
For example -
http {
   akamai_g2o domain1 {
      key xyz;
      nonce 987;
      data_header abcd;
      sign_header 1234;
   }

   server {
      location / {
         akamai_g2o domain1;
      }
   }
}

I did such a refactor at some point in nginx-secure-token-module -
https://github.com/kaltura/nginx-secure-token-module/commit/737433e94491f1b8974398138ec87785aa2423bb#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

Great idea! However that refactor will take more time than just supporting vars in header conf params. So I'm supporting vars right now and implementing blocks of config after that.  Make sense? Thanks for that suggestion.

If you need a solution fast, you can patch your server to support vars, but I prefer to merge only the full solution

I need to understand better if blocks of config will really satisfy my project requirements. Maybe isolated directives are more flexible in inheritance from previous levels. I will validate that with my teams yet.
I need a solution fast since we will use nginx getting requests from multiple CDN (Akamai and others) using G2O. Then we cannot keep a fix "AKAMAI" on headers.
The bad thing is I'll need to keep using my fork instead of the official repository for a while. But ok I'll pull request only the full solution when it is ready.


Outdated doctring for SendClient

It seems like the docstring for SendClient is outdated, as I'm able to use uamqp.authentication.JWTTokenAuth, which is not included in this list:
    :param auth: Authentication for the connection. This should be one of the subclasses of
     uamqp.authentication.AMQPAuth. Currently this includes:
        - uamqp.authentication.SASLAnonymous
        - uamqp.authentication.SASLPlain
        - uamqp.authentication.SASTokenAuth

hey @vishnureddy17 , thanks for the feedback. I'll update the docstring!

hey @vishnureddy17 , we have updated the docstring for SendClient (as well as other clients that takes JWTTokenAuth now), thanks for your feedback.


[design] obtain input from ledgers maintainers regarding Cactus v0.3.0

Description
At one of our bi-weekly calls it came up as a suggestion (thank you @brianbehlendorf) that we should solicit feedback from maintainers of ledgers we aim to support rather earlier than later to lower the cost of design decisions that may turn out to be sub-optimal in the future.
More specifically: we don't want to start soliciting feedback post a generally available v1.0 release since by that time it will be too late to change course on certain design aspects that require major (e.g. breaking) changes.
We therefore agreed that a suitable point in time would be anchored to whenever we have had issued our v0.3 release of Cactus.
Purpose/tasks of this GH issue:

Make sure this is not forgotten => adding it as a mandatory item for the GitHub milestone v0.4
Allow everyone to chime in here even before we hit the v0.3 release so that we have a central place to collect everyone's thoughts (I will also post a link to this issue on the chat and the mailing list)
(?) Brainstorm about a discussion framework that we should be using if any. E.g., do we follow a simple approach of shooting an email saying Dear $LEDGER Maintainer, what do you think of Cactus? to everyone and hope for the best or do we make it more structured with a survey containing targeted questions?
Decide on which ledgers to focus on: Do we talk to ledger maintainers whose ledgers are not yet supported at all? (Sawtooth for example) or do we only talk to the ones we already have at least partial support for via connector plugins?

Acceptance Criteria

Feedback was obtained from the ledger maintainers
Feedback was distilled down into design changes and implementation tasks (assuming there will be changes proposed since us getting everything right the first time seems pretty unlikely)

cc: @jonathan-m-hamilton @takeutak @sfuji822 @hartm

It was discussed on the TSC call this morning that the TSC was hoping for more technical content during the calls.  In particular, everyone seemed to want about one technical talk a month.
One idea:  should we ask for a TSC technical talk slot where we can solicit this input from the TSC (and the people that attend the meetings)?  We could present on the Cactus architecture and ask people for feedback with regards to connecting to their particular ledger.  It might be the best way to get the attention of people across a wide variety of projects.
What do you all think?

I agree that's a great way to get visibility, feedback and invite collaboration!  Let's discuss timing in the next maintainers.

+1, @hartm .Looks like a good idea to present the work.

I think the biggest takeaway so far is that the ledger maintainer's most important ask is to not mask/make inaccessible the unique features of the ledgers they maintain (rightfully so I might add).
So, as a next round of meetings we could probably turn it around a bit and ask ledger maintainers what are the features they think are the most widely used (among the features that we don't already support) and then prioritize adding those to the Cactus connectors based on that.
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @RafaelAPB

Several meetings have occurred in the meantime where we've talked to ledger maintainers and things seem to be heading in the right direction because our designs are able to support different flavors and algorithms for cross-ledger transactions that are both atomic and non-atomic, escrowed, hash time locked, etc.


Background service crashing

Description
Service background crashing after changing MACHINE_FQDN in .env.
Steps to reproduce

Set container_name to portus-registry for registry service
Set MACHINE_FQDN=portus-registry.dnstest.com

Expected behavior: Background service start
Actual behavior: But background service exit

background_1  | bin/rails: undefined method `[]' for nil:NilClass (NoMethodError)
portus_background_1 exited with code 1

Deployment information
Deploy with docker-compose up
Configuration:

In a container:

Using the development docker-compose.yml at the repo root

I have a DNS container phensley/docker-dns that point all my container to a DNS entry according his container name. (So portus-registry = portus-registry.dnstest.com)
version: '2'

services:
  portus:
    build: .
    image: opensuse/portus:development
    command: bundle exec rails runner /srv/Portus/examples/development/compose/init.rb
    environment:
      - PORTUS_MACHINE_FQDN_VALUE=${MACHINE_FQDN}
      - PORTUS_PUMA_HOST=<IP_ADDRESS>:3000
      - PORTUS_CHECK_SSL_USAGE_ENABLED=false
      - PORTUS_SECURITY_CLAIR_SERVER=http://clair:6060

      - CCONFIG_PREFIX=PORTUS

      - PORTUS_DB_HOST=db
      - PORTUS_DB_PASSWORD=XXXXX
      - PORTUS_DB_POOL=5

      - RAILS_SERVE_STATIC_FILES=true
    ports:
      - 3000:3000
    dns: dns_ip_server
    depends_on:
      - db
    links:
      - db
    volumes:
      - .:/srv/Portus
    network_mode: bridge

  background:
    image: opensuse/portus:development
    entrypoint: bundle exec rails runner /srv/Portus/bin/background.rb
    depends_on:
      - portus
      - db
    environment:
      - PORTUS_MACHINE_FQDN_VALUE=${MACHINE_FQDN}
      - PORTUS_SECURITY_CLAIR_SERVER=http://clair:6060

      # Theoretically not needed, but cconfig's been buggy on this...
      - CCONFIG_PREFIX=PORTUS

      - PORTUS_DB_HOST=db
      - PORTUS_DB_PASSWORD=XXXX
      - PORTUS_DB_POOL=5
    volumes:
      - .:/srv/Portus
    dns: dns_ip_server
    links:
      - db
    network_mode: bridge

  webpack:
    image: kkarczmarczyk/node-yarn:6.9-slim
    command: bash /srv/Portus/examples/development/compose/bootstrap-webpack
    working_dir: /srv/Portus
    volumes:
      - .:/srv/Portus
    network_mode: bridge

  clair:
    image: quay.io/coreos/clair:v2.0.1
    restart: unless-stopped
    depends_on:
      - postgres
    links:
      - postgres
    ports:
      - "6060-6061:6060-6061"
    volumes:
      - /tmp:/tmp
      - ./examples/development/compose/clair.yml:/clair.yml
    command: [-config, /clair.yml]
    network_mode: bridge

  db:
    image: library/mariadb:10.0.23
    command: mysqld --character-set-server=utf8 --collation-server=utf8_unicode_ci --init-connect='SET NAMES UTF8;' --innodb-flush-log-at-trx-commit=0
    environment:
      MYSQL_ROOT_PASSWORD: XXXX
    network_mode: bridge

  postgres:
    image: library/postgres:10-alpine
    environment:
      POSTGRES_PASSWORD: XXXXX
    network_mode: bridge

  registry:
    image: library/registry:2.3.1
    container_name: portus-registry
    environment:
      REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY: /registry_data
      REGISTRY_STORAGE_DELETE_ENABLED: "true"

      REGISTRY_HTTP_ADDR: <IP_ADDRESS>:5000
      REGISTRY_HTTP_DEBUG_ADDR: <IP_ADDRESS>:5001

      REGISTRY_AUTH_TOKEN_ROOTCERTBUNDLE: /etc/docker/registry/portus.crt

      REGISTRY_AUTH_TOKEN_REALM: http://${MACHINE_FQDN}:3000/v2/token
      REGISTRY_AUTH_TOKEN_SERVICE: ${MACHINE_FQDN}:${REGISTRY_PORT}
      REGISTRY_AUTH_TOKEN_ISSUER: ${MACHINE_FQDN}

      REGISTRY_NOTIFICATIONS_ENDPOINTS: >
        - name: portus
          url: http://${MACHINE_FQDN}:3000/v2/webhooks/events
          timeout: 2000ms
          threshold: 5
          backoff: 1s
    volumes:
      - /registry_data
      - ./examples/development/compose/portus.crt:/etc/docker/registry/portus.crt:ro
    ports:
      - ${REGISTRY_PORT}:5000
      - 5001:5001
    dns: dns_ip_server
    links:
      - portus
    network_mode: bridge

Portus version: 2.3.3 commit edd5b82

Change : I set MACHINE_FQDN=portus_portus_1.dnstest.com instead of portus-registry.dnstest.com

New error output :
background_1  | bin/rails: Something went wrong while fetching the catalog Response: [401] - {"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"registry","Name":"catalog","Action":"*"}]}]} (Portus::RegistryClient::RegistryError)
portus_background_1 exited with code 1

The last output :
background_1  | bin/rails: undefined method `[]' for nil:NilClass (NoMethodError)
portus_background_1 exited with code 1

Doesn't appear.

Ok, I solve it by deleting all containers. I think it's not the better way ^^

Ok, I solve it by deleting all containers. I think it's not the better way ^^

This does not seem to be the case for me... it continues to crash as fa as i can tell all my config is correct...
I just want to use ssl, the frontend seems like it is using it fine the background and registry cannot talk and the background exits


feat: page heading

Not able to test description text. not showing in SB. Is that ok?


Update pycocotools version

CI was failing while installing pycocotools. This PR fixes that

Yep, changing the package version is definitely a much better solution to this problem 😀


Embed encoder.json/vocab.bpe in OpenAI connector assembly

Motivation and Context
This makes these files part of the .dll rather than anyone using the nuget package deplying the separate .json/.bpe files.
(If it was an explicit design choice to have these be loose files, e.g. if the goal was to avoid paying the size increase if they weren't being used, or being able to somehow update them separately, then this can of course be closed.)
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

@dluc Could you please respond to question in PR description and check changes in the code? Thanks!

@stephentoub the motivation, as you suspect, was indeed to avoid incurring the size penalty. Not sure how effectively we're doing that now though. I'm going to put this one on ice (convert to draft) until you're back, and then we can weight the pros and cons. There may also be a possibility of putting this is in its own nuget so that it can be included in the SK metapackage, but if a caller doesn't want it, they can avoid it by grabbing the specific packages indifividually.

I thought it would be nice not having to access the file system and use embedded resources, however, given that we advocate the kernel as a lightweight SDK and say that instantiating the kernel is a very cheap operation, the considerable size of the dictionary/settings files was concerning, so I went for a file based approach + caching. Currently, the files and that payload is not ever considered, unless one invokes the tokenizer. Only during the first use, this data is loaded and cached in memory, paying the cost on the 1st call. Consider that with lambdas and ad hoc processes, every request might be the "1st request". If we embed the resources, the OpenAI connector DLL will grow considerably (though zip compression might help), and I think it would help understanding what the change looks like on lambdas and edge devices.

Thanks for your PR and contribution. For now, we are closing old drafts. Please re-open as appropriate.


patch eslint-lodash-fp toString bug, also lint some unlinted spots [SATURN-1201]

Handled by #1916


Use nested selections for component-scoped styles

Currently, component selectors are added to each css block in a scoped stylesheet. The current regex  replace strategy leads to invalid results for nested selectors. If nested selectors are supported in all browsers, a root component selector could be wrapped around the whole stylesheet:
uix-x {
  div {
    ...
  }
...
}

Alternatively, the @scope selector might be used.

Example:


test: add server start

Adds test for server start with the spec below:
Starts a GraphQL server on port 8000.
Make 100 requests to the server.
Assert the shape of the response received.

Issue Reference(s):
Fixes #687
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

/claim #687

@neo773 this should start actual server.

Hey @neo773 can you please create a new PR that solves the mentioned issue. This one is not doing anything related to the concerned issue.


pip install gdown won't work

Discussed in https://github.com/wkentaro/gdown/discussions/337

Originally posted by CuriousityKilled March 30, 2024
Trying to install PS but every time i try to input
pip install gdown
it comes up with
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.

    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.

    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

    See /usr/share/doc/python3.11/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

am i missing something?

Seems your Python installation environment has some problem.
If you want to install anyway, I recommend using pipx:

Install pipx: https://pipx.pypa.io/stable/installation/
pipx ensurepath
pipx install gdown

Archlinux does not allow direct installation with pip install it needs to be installed either with sudo pacman -S python-XXX or with pipx


Hyperparams for large synthetic sets

Congratulations on this interesting work. It seems that in the code you define the hyperparams only for the dataset sizes that appear in the paper (up to 50 ipc), would it be possible to provide the hyperparams for the results reported in your ICLR comments to reviewers? (with 100, 200, 500, 1000 condensed images per class).
Thank you in advance!

Thank you for being interested in our paper.
As you see, the corresponding hyper-parameters have been given for these results (≤ 50 images/class) presented in the paper. For extra experiments with > 50 images/class, we pick the best one of “outer_loop, inner_loop = 50, 10” and “outer_loop, inner_loop = 20, 25” for different settings. You may find the better combinations if you try more. Besides, we find that initializing synthetic images from random real images will benefit the performance when learning many images. So, we do it when learning many images.

For 100 img/cls learning on CIFAR10, if you try "outer_loop, inner_loop = 100, 2", you may get 66.7% (DSA).


Support for MinIO

Hello!
Does this controller support the MinIO as storage for MLflow?
If yes, what configurations should be passed in order to work?
Thanks,
Florin

@spicoflorin  yes it supports minio
please see the example configmap here https://github.com/rocket9-code/mlflow-deployment-controller/blob/main/tests/mlflow-cm.yaml


Depth limit for Fastify-GQL

This plugin for express-graphql and koa-graphql address the issue of depth limiting graphql queries - https://github.com/stems/graphql-depth-limit to help with the problem of depth limiting
The rationale is explained in the readme - https://github.com/stems/graphql-depth-limit#why
This is probably only really an issue for public APIs but perhaps we could implement a fastify-gql version of this plugin or raise a pr on that one to add support for fastify-gql

I would prefer if this got added to to fastify-gql as a first-class concept.

I've started looking more closely. I propose this as an approach -
On the fastify-gql options object we enable a depthLimit property, the value will represent the limit on recursive queries. There is an issue with this though - what if we want to allow different limits for different queries? Perhaps the value of the depthLimit option could then be something like { queryName: queryDepthLimit, .... }
The plugin https://github.com/stems/graphql-depth-limit uses the validationRules param of an express-graphql query to reject or allow a query based on the query depth. We could use something similar - analyse a query and if it breaks the query depthLimit rule it is rejected.

I see this as a settings that should be applied to the whole graphql  plugin.
I'll add the depth validation logic after this line: https://github.com/mcollina/fastify-gql/blob/bb9eb706648135637e442239bcc71492da46b13d/index.js#L222.

I'll put something together in a branch


Addition of Role field to Account settings

This adds support for customizing the name of the IAM role used for the assumeRole call.
This may be interesting to users who have used CloudFormation to create roles, which results in unique names including the CF stack name, and other data.
Thanks.

What's the difference with #120? Also, isn't this missing the DB part?

@lucab thanks for pointing that out. Missed this when reviewing the pending pr's. Closing this one out.


Cipher support in Android 4.4.4?

Expected behaviour
My IMAP server (dovecot) is requiring TLS 1.2, and only exposes these ciphers: ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA384:DHE-RSA-AES128-SHA256:DHE-RSA-AES256-SHA256.
This is supposed to work on Android 4.4.4, and it works in web browser for instance.
Actual behaviour
It does not work in K9-Mail, but apart from “Connection failed”, it’s not very helpful. On server side I have this:
imap-login: Error: SSL: Stacked error: error:1408A0C1:SSL routines:ssl3_get_client_hello:no shared cipher.
So, no shared cipher, which is strange because a webserver (nginx) with the same configuration does work on this smartphone.
I’m not sure where the issue lies, because it does work on newer version of Android, but this is on a phone I actually can’t upgrade (Geeksphone Revolution).
Environment
K-9 Mail version: 5.010
Android version: 4.4.4
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

Our cipher list is outdated.
In master it's fine

https://github.com/k9mail/k-9/blob/9ebf411d95a9cb1f6918016d982d8ca6467d1a8a/k9mail-library/src/main/java/com/fsck/k9/mail/ssl/DefaultTrustedSocketFactory.java#L35

In the latest release it's not:

https://github.com/k9mail/k-9/blob/5.010/src/com/fsck/k9/net/ssl/TrustedSocketFactory.java#L32

We really ought to add the GCM ciphers to stable at minimum.

OK, so k9mail doesn’t explicitly allow those ciphers, but it works because the system supports them, so they are automatically added. The question is then why on 4.4.4 (or this specific device maybe?) this doesn’t work.
Because yes, my IMAP server use exactly the same cipher list as nginx, it has been copy-pasted from one to the other. I’ve checked that with ssl-scan and https://www.htbridge.com/ssl/, both report the exact same list:
TLS_DHE_RSA_WITH_AES_128_CBC_SHA256
TLS_DHE_RSA_WITH_AES_256_CBC_SHA256
TLS_DHE_RSA_WITH_AES_128_GCM_SHA256
TLS_DHE_RSA_WITH_AES_256_GCM_SHA384
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384

A bit more details from ssllabs:
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (0xc02f)   ECDH secp256r1 (eq. 3072 bits RSA)   FS 	128
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (0xc030)   ECDH secp256r1 (eq. 3072 bits RSA)   FS 	256
TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 (0x9e)   DH 2048 bits   FS 	128
TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 (0x9f)   DH 2048 bits   FS 	256
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 (0xc027)   ECDH secp256r1 (eq. 3072 bits RSA)   FS 	128
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 (0xc028)   ECDH secp256r1 (eq. 3072 bits RSA)   FS 	256
TLS_DHE_RSA_WITH_AES_128_CBC_SHA256 (0x67)   DH 2048 bits   FS 	128
TLS_DHE_RSA_WITH_AES_256_CBC_SHA256 (0x6b)   DH 2048 bits   FS 	256

About Android connexion test:
Android 4.4.2 	RSA 2048 (SHA256)   	TLS 1.2 	TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256   ECDH secp256r1  FS
And a more global view:
https://www.ssllabs.com/ssltest/viewClient.html?name=Android&version=4.4.2
So, it is supported and actually does work, at least in web browser (both default one and Firefox for Android).

Some additional information: the same system seems not to support SNI (in K9-Mail, it does in webbrowser), while it should. Definitively strange.

Ah... If it's a matter of SNI support that might be the problem. We don't support SNI in the latest stable release. It's been merged in and should be available in the beta I think: https://github.com/k9mail/k-9/pull/718

No, it’s not a matter of SNI, this was just a supplementary test I ran. Also, SNI is actually working in K9-Mail 5.010 on my OPO running CM13, or at least it seems. Will double check that tonight.

https://mobile.facebook.com/login/?_e_pi_=7%2CPAGE_ID10%2C4607042877

I can confirm that SNI is working on my OPO. So, we have:

OPO running Android 6.0.1, having no problems with modern ciphers and SNI.
GPR running Android 4.4.4, having troubles with both modern ciphers and SNI, while supposed to support those.

Both using K-9 Mail 5.010.
Could it be that newer Android version somehow automatically add support for those things (at least seems to be the case for ciphers, right?), while older one needs things to be explicitly enabled in order to work?

Without knowing much about Android (or the actual OS running - manufacturers often make changes with the stuff they put in/take out) it's probably possible. If SNI just worked anyway I can't imagine we'd have bothered adding code to turn it on.

OK. I will just wait for a K-9 Mail version with new ciphers and SNI enabled to retest that. ;)

Hi there. I’d like you to reopen this, I’ve been testing with the release of K-9 5.200 and the issue is still present. On server side, I see this:
TLS handshaking: SSL_accept() failed: error:1408A0C1:SSL routines:ssl3_get_client_hello:no shared cipher

On client side, log:
K9-Mail version: 5.200
Device make: geeksphone
Device model: revolution
Android version: 4.4.4

com.fsck.k9.mail.MessagingException: IO Error
	at com.fsck.k9.mail.store.imap.ImapFolder.ioExceptionHandler(ImapFolder.java:1366)
	at com.fsck.k9.mail.store.imap.ImapFolder.internalOpen(ImapFolder.java:163)
	at com.fsck.k9.mail.store.imap.ImapFolder.open(ImapFolder.java:114)
	at com.fsck.k9.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:845)
	at com.fsck.k9.controller.MessagingController$9.run(MessagingController.java:739)
	at com.fsck.k9.controller.MessagingController.runInBackground(MessagingController.java:204)
	at com.fsck.k9.controller.MessagingController.access$000(MessagingController.java:115)
	at com.fsck.k9.controller.MessagingController$1.run(MessagingController.java:173)
	at java.lang.Thread.run(Thread.java:841)
Caused by: javax.net.ssl.SSLHandshakeException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0xa9f14210: Failure in SSL library, usually a protocol error
error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure (external/openssl/ssl/s23_clnt.c:744 0x9391c966:0x00000000)
	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:449)
	at com.android.org.conscrypt.OpenSSLSocketImpl$SSLInputStream.<init>(OpenSSLSocketImpl.java:662)
	at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:633)
	at com.fsck.k9.mail.store.imap.ImapConnection.setUpStreamsAndParserFromSocket(ImapConnection.java:228)
	at com.fsck.k9.mail.store.imap.ImapConnection.startTLS(ImapConnection.java:312)
	at com.fsck.k9.mail.store.imap.ImapConnection.upgradeToTls(ImapConnection.java:300)
	at com.fsck.k9.mail.store.imap.ImapConnection.upgradeToTlsIfNecessary(ImapConnection.java:284)
	at com.fsck.k9.mail.store.imap.ImapConnection.open(ImapConnection.java:119)
	at com.fsck.k9.mail.store.imap.ImapConnection.sendCommand(ImapConnection.java:640)
	at com.fsck.k9.mail.store.imap.ImapConnection.executeSimpleCommand(ImapConnection.java:623)
	at com.fsck.k9.mail.store.imap.ImapConnection.executeSimpleCommand(ImapConnection.java:612)
	at com.fsck.k9.mail.store.imap.ImapFolder.executeSimpleCommand(ImapFolder.java:109)
	at com.fsck.k9.mail.store.imap.ImapFolder.internalOpen(ImapFolder.java:145)
	... 7 more
Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0xa9f14210: Failure in SSL library, usually a protocol error
error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure (external/openssl/ssl/s23_clnt.c:744 0x9391c966:0x00000000)
	at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:406)
	... 19 more

I’ve stumbled upon a similar report here BTW: https://community.qualys.com/thread/14522.

None of these ciphers is supported by Android 4.4 (API 19). See for yourself: https://developer.android.com/reference/javax/net/ssl/SSLSocket.html

Hum, indeed. I wonder why https://www.ssllabs.com/ssltest/viewClient.html?name=Android&version=4.4.2 report them though (will ask that to them). Maybe all Android browser use a custom ssl lib?

So, if anyone come here, the answer is that ssllabs (currently) looks at WebView SSL support, which is different from that of the OS. Reason being that all web apps will use WebView.
Conclusion, there is nothing to be done regarding mail support, and Android 4.4 will be a deprecated platform when TLS1.0 goes off (expected in 2018 AFAIK).

If we have a large Android 4.4 user base we could always do what WebView does and package OpenSSL / BoringSSL/etc - meaning we can use later versions. We'd have to release every time it updated and there's a lot of binding work to do but I know of other apps that do it.

Do you have statistics regarding this usage? Maybe from the PlayStore, since K-9 is distributed there as well (F-Droid user here, so not in stats AFAIK).
I’m not sure that’s (currently) worth it, they are probably way more important things requiring your attention (at least for now, not supporting TLS 1.0 being an issue should only be an edge case).

37% of devices on the Google Play Store use 4.4 or below at time of writing. I'm not sure how that breaks down on K-9 itself (I don't have Play Store access for the K-9 app), although with 24% using 4.4 alone it's likely to be significant.
But given the amount of work involved I agree.

I have no plans of packaging a TLS library unless absolutely necessary. So far I don't see the necessity.

Like I said, it’s not necessary for now, excepted for corner cases which are not worth supporting.
However, once a EOL date for TLS 1.0 & 1.1 will have been decided (it was June 30th, 2016 in PCI-DSS requirements but was moved to same day in 2018 finally, but I’m not sure about things outside of PCI-DSS scope), if they are still a lot of 4.4 and below users, it will become necessary. We might hope it won’t.

The PCI-DSS requirements are not relevant for most users. And those who are affected probably also use newer Android devices.

That’s why I’ve said I’m not sure for things outside of PCI-DSS scope. But once again, there is no rush here: lets wait to see how it goes in one year (both on TLS deprecation side and Android 4.4− usage of K-9) before discussing this. ;)


Remove redundant TaskFn anonymous wrapper functions

How to categorize this PR?

/area quality
/kind cleanup
What this PR does / why we need it:
This PR transforms
func(ctx context.Context) error {
	return botanist..(ctx)
}

into it's equivalent
botanist..(ctx)

Release note:

NONE

/assign @RadaBDimitrova


fix etcher logo

The initial png was exported from a .ico format, which confused safari and resulted in some weird rendering.
Tested this .png and safari handles it fine.
Apologies for the inconvenience

Apologies for the inconvenience

No worries 🚢


Dark Mode

In Chrome i can use DarkReader, but thats hard in electron.
Please add an Integrated Dark Mode

I would also love this. I am more than willing to help build it but I have never done anything with an electron app or much frontend at all as I am backend dev. If anyone can point me to helpful blog posts or anything on this front. I could start looking into themes for this and start with a dark mode

Any traction on this?

I haven't seen many contributions here lately, so I recently released a re-write here that supports GraphiQL 2 and has dark mode support:
https://github.com/nathanchapman/graphiql-desktop

I haven't seen many contributions here lately, so I recently released a re-write here that supports GraphiQL 2 and has dark mode support: https://github.com/nathanchapman/graphiql-desktop

Awesome! I am going to check it out! Is there a good/clean way to submit new themes to this repo? Would be fun to be able to add some variants


JSON dumps don't have split type

Function XGBoosterDumpModel has an option of dumping to JSON. This JSON output has a field split_condition which tells against what to compare the column in field split.
The JSON however doesn't mention how this split_condition is to be applied - for numeric features, it will be a threshold used as split < split_condition, while for categorial features it will use an 'in' condition split in split_condition.
The text and 'dot' dump formats both indicate what the split type is.

Thank you for raising the issue, do you have suggestion on how to modify it?

Thank you for raising the issue, do you have suggestion on how to modify it?

I guess it could have a field 'split_type' or similar, having values like '<' or '='.


DetoxSync: add fishhook as submodule.

Depends on https://github.com/wix/DTXObjectiveCHelpers/pull/2.

As for DTXObjectiveCHelpers' commit - better to use 1f1b380775f604c61ec4eb8584df40f1d8487291 (i.e. the one generated in master following the merge).

Good point, doing it :+1:

@asafkorem seems that the submodule, though named DTXSwizzlingHelper, is in fact wired to DTXObjectiveCHelpers as its remote. Would you consider a rename?

That's true, I thought about this too, but I generally think that we should migrate all these sub-projects into the main project repo.
Anyway, until then, I agree that it would be better to rename it. I'll add this.

I see your point 🆗

Done 🙂


Step defs with parameters

Here's my first attempt at allowing parameters in a step definition...

I've just checked in a couple of additional changes:

Renamed the new scenario as suggested above
Added a unit test to cover the case that _add_steps is called with more than 3 parameters
Updated _add_steps to raise an error if it is called with more than 3 parameters
Updated the README to include examples with variables to match a regexp

Anything else you think is needed for this one?

This looks good to me @jowers. Want to merge it into master with --squash to keep the history nice and clean?

Done (I think) had to resolve conflicts in the README, but seems to have gone through.

Great!
Little bit of GitHub coaching: When you use --squash you have to explicitly close the PR issue (GH does it automatically if you merge the whole PR branch without squashing). You can either do that by hand on the GitHub UI, or by mentioning closes #<PR or issue number> in your commit message for the squashed merge commit.
The alternative to this is to rebase the PR branch until it's neat and tidy (using git rebase -i and git push --force) then you can just merge it in normally.

It's also good practice to delete the PR branch once it's merged in to keep the repo tidy. I normally forget to do this - see how many dead branches there are in cucumber/cucumber, for example.


Error when using getFragment - Nova Apollo-GraphQL

Hi,
I follow the example in the doc section data-layer.htm and my custom custom_fields.js contain below code:
import Posts from "meteor/nova:posts";
import { registerFragment, getFragment } from 'meteor/nova:lib';
import gql from 'graphql-tag';

Posts.addField(
  {
    fieldName: 'ReadFullStoryAt',
    fieldSchema: {
      type: String,
      optional: true, // this field is not required
      insertableBy: ['members'],
      editableBy: ['members'],
      viewableBy: ['guests'],
      publish: true,                                                                                // 112
    },
  }
);

const CustomPostsListFragment = gql`
  fragment CustomPostsList on Post {
    ...PostsList
       ReadFullStoryAt
  }

  ${getFragment('PostsList')}

`;

registerFragment(CustomPostsListFragment, 'PostsList');

When I run my app, I got the following error:
TypeError: getFragment is not a function
W20170201-14:39:07.273(7)? (STDERR)     at meteorInstall.node_modules.meteor.adalidda-site.lib.custom_fields.js (packages/adalidda-site/lib/custom_fields.js:57:5)

Then I search for getFragment and registerFragment under nova-lib folder and I don't found both of them any where !
What is wrong ?
Thank You
Adalidda

It looks like you are on the master branch, aren't you? We didn't merge the getFragment it yet on devel 😳
Please checkout on the devel for the moment:
git checkout devel

Apologies! We are going to do some improvement on this getFragment function. Don't hesitate to come by the Slack chatroom to stay tuned 👍

Oh great. If you work on improvement, I suggest to include it automatically
with addfield (add to fragment) and removefield (remove from fragment).
Once again, thank you so much. Now, we are able to deploy our new Nova
Apollo GraphQL to our test url https://nova.adalidda.com
Thank You so much
Adalidda
On Wed, Feb 1, 2017 at 4:45 PM, Xavier Cazalot<EMAIL_ADDRESS>wrote:

It looks like you are on the master branch, aren't you? We didn't merge
the getFragment it yet on devel 😳
Please checkout on the devel for the moment:
git checkout devel
Apologies! We are going to do some improvement on this getFragment
function. Don't hesitate to come by the Slack chatroom
http://slack.telescopeapp.org to stay tuned 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TelescopeJS/Telescope/issues/1551#issuecomment-276614378,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOoSB83jiVpaxi9t_RfT3F_VZblTVbpgks5rYFQtgaJpZM4Lzk-e
.

Well, I already pong you on the other issue, but putting it here in case of... There is a new API for fragments, here is the docs: http://nova-docs.telescopeapp.org/data-layer.html#Fragments

Thank You Xavier.
Adalidda
On Thu, Feb 2, 2017 at 2:10 PM, Xavier Cazalot<EMAIL_ADDRESS>wrote:

Well, I already pong you on the other issue, but putting it here in case
of... There is a new API for fragments, here is the docs:
http://nova-docs.telescopeapp.org/data-layer.html#Fragments
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TelescopeJS/Telescope/issues/1551#issuecomment-276884505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOoSB2aZbD6e_w0WY6MpDYMc9RQ-d2u6ks5rYYFdgaJpZM4Lzk-e
.


Add missing services for Cell* roles for tripleo

Align included services with the t-h-t's CellController role.

@marios Note: Cell roles are not used in multi-node nor standalone CI, so there is no need for a regression check in testproject

testing for a WIP multi-cell job https://review.rdoproject.org/r/c/testproject/+/53212


Update scalatest to 3.2.16

About this PR
📦 Updates org.scalatest:scalatest from 3.2.11 to 3.2.16
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (3.2.11).
You might want to review and update them manually.
build.sbt

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Codecov Report
Patch and project coverage have no change.

Comparison is base (90e05bb) 41.66% compared to head (06b7ada) 41.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   41.66%   41.66%
=======================================
  Files           1        1
  Lines          36       36
  Branches        1        1
=======================================
  Hits           15       15
  Misses         21       21

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Superseded by #294.


Merge Telerik and PhoneGap's forks

Hi guys,
A year ago the Wildabeast upstream repo was "abandoned" and this fork and Telerik's fork evolved. The PhoneGap fork got a lot of love from Microsoft and the Telerik fork focused on fixing issues on and adding small enhancements to iOS and Android.
Last week Microsoft's @nikhilkh contacted Telerik's @rdlauer and myself about a possible merge of Telerik's fork with PhoneGap's to create the ultimate BarcodeScanner plugin version and join efforts maintaining only one version.
So we agreed to merge our changes to this fork and keep our forks in sync as much as possible so everybody benefits. Note that the Telerik fork won't be removed after this merge since it's used in the Telerik Platform which relies on stable releases we need full control over.
So now there's this big a** merge request which I've tested on iOS and Android. We didn't change much on the Windows platforms so I'm not expecting that to break but a little smoke test on all platforms won't hurt.
I've also added PR #210 to this PR as I liked how it handles Android M permissions better than I did on the Telerik fork :) .. so that one can be closed once this PR is merged.
Please don't take too long to merge it as the slightest commit to this repo will prevent an automatic merge.
Thanks in advance and looking forward to working with you guys on this plugin in the future!
Eddy

@vladimir-kotikov, @sarangan12 to help merge this.@stevengill for FYI. We should do a release of this plugin once this is merged

Wow. This looks great! Vladimir is already an owner on npm and I just added @EddyVerbruggen as a npm owner as well. Let me know if you need my help here.

Thanks for that @stevengill!
FYI - I've added a few more commits because when we initially forked the Wildabeast repo we removed a few files which weren't removed in this fork so this PR would removed them here as well. Which is not what I intend to do.

Did a quick review and some smoke testing on all main platforms - everything seems to be fine except one issue with iOS - when running the basic sample (without any options passed to scan method) i'm getting the following error in Xcode console
2016-05-04 15:49:50.900 HelloCordova[1260:2087813] *** WebKit discarded an uncaught exception in the webView:decidePolicyForNavigationAction:request:frame:decisionListener: delegate: <NSRangeException> *** -[__NSArrayM objectAtIndex:]: index 0 beyond bounds for empty array

Looks like the problem is caused by arguments conversion code in www/barcodescanner.js#L74-L82 - passing an empty object rather than undefined solves the problem for me.
@sarangan12, @EddyVerbruggen, could you please confirm that you see the same issue?

@vladimir-kotikov Thanks for finding that! I've just update the iOS code to cover this case 👍

Thanks, @EddyVerbruggen. @sarangan12, would you like to take a look as well?

I checked with @sarangan12 - Vladimir - you should go ahead and merge this if you're ready.

Thanks. This pull request has been integrated manually.


Add read_function keyword to read_json

[ ] Tests added / passed
[ ] Passes flake8 dask

This PR allows the pandas read_json function to be swapped out for something else (like cudf.read_json)

Can you provide a test for this (perhaps something that doesn't need a gpu)?

Additionally, I recommend that we wait until the cudf.read_json function
exists before we invest a ton of time here.  I think that this should
happen in a few days.
On Thu, May 16, 2019 at 3:34 PM Martin Durant<EMAIL_ADDRESS>wrote:

Can you provide a test for this (perhaps something that doesn't need a
gpu)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/4810?email_source=notifications&email_token=AACKZTHFEUYXJQEVT3AV36TPVXAMJA5CNFSM4HNP35VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVS7QWI#issuecomment-493221977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACKZTDXKKKSSISGTJHKY4DPVXAMJANCNFSM4HNP35VA
.

By "exists", do you mean when it is improved to handle a non-string file object input? read_json does exist in branch-0.8

Yes, that is exactly what I meant to say.

Thanks @rjzamora!


[Bug]: inconsistent evaluation results

What happened?
When evaluating retrieval results using the same collection and evaluation queries, inconsistent evaluation results are obtained. Is this due to the nearest neighbor algorithm? Is there a way to achieve consistent results?
topN: correct/total_num, acc

Versions
chroma-hnswlib                0.7.2
chromadb                      0.4.6
Relevant log output
No response

@jkkl, can you share some additional information about your use case? What has changed between the two test executions that resulted in the screenshots above?

Closing due to inactivity for some time. If you're still experiencing this with Chroma v.0.6.0 or later, feel free to open a new issue!


Browsing folder path results in freeze

Whenever I try to browse to a path in the emulator settings the emulator freezes. This happens on both folder icons for "Screenshot Save Location" and "Use Detected ADB Location".

+1 I initially get a warning when opening that adb cannot be automatically detected. When I go to try and change this the emulator app freezes

This is on macOS BigSur 11.0.1 20B29 and the emulator version 30.3.2-6992164 (Canary update channel).

This looks like a Qt bug where it's trying to JIT a regular expression, but in Big Sur, this isn't allowed.

This should be fixed in release 0.2: https://github.com/741g/android-emulator-m1-preview/releases/tag/0.2

I can confirm that this is now working without issues, therefore closing.

Edit /Applications/Android\ Emulator.app/Contents/MacOS/aosp-master-arm64-v8a/config.
Duplicate of #

$1_$2

good


fix Alpine.js examples link

Description (required)
Alpine.js examples link pointed to latest instead of main. This PR fixes it.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/integrations-guide/alpinejs.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Object Explorer Token Is Expired

Azure Data Studio Version: 1.41.0
OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

Connecting to Azure SQL Managed Instance database
Keep Data Studio open for a couple of days (laptop in sleep mode no full shutdowns or restarts of the applications)
After using Data Studio for a while try to open up SQL view or procedure to see the syntax using the Object Explorer.
You will get an error 'Login failed for user ''. Token is expired'.

Refreshing the connection with the database: does NOT solve it.
Disconnecting and reconnect with the database: does NOT solve it.
Restart the Azure Data Studio application: does SOLVE the issue.

Error message:
Microsoft.SqlServer.Management.Common.ConnectionFailureException: Failed to connect to server *****.
---> Microsoft.Data.SqlClient.SqlException (0x80131904): Login failed for user ''. Token is expired.
at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
at Microsoft.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.CompleteLogin(Boolean enlistOK)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool)
at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(DbConnection owningConnection, DbConnectionPoolGroup poolGroup, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)    at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)
at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides)
at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
at Microsoft.SqlServer.Management.Common.ConnectionManager.InternalConnectImpl()
at Microsoft.SqlServer.Management.Common.ConnectionManager.InternalConnect()
at Microsoft.SqlServer.Management.Common.ConnectionManager.Connect()
ClientConnectionId:4d101833-6cb0-4eb3-9ce4-f0dfbb9e46a4
Error Number:18456,State:233,Class:14
--- End of inner exception stack trace ---
at Microsoft.SqlServer.Management.Common.ConnectionManager.Connect()
at Microsoft.SqlTools.ServiceLayer.Scripting.ScriptAsScriptingOperation.Execute() in D:\a_work\1\s\src\Microsoft.SqlTools.ServiceLayer\Scripting\ScriptAsScriptingOperation.cs:line 84

Does this issue occur when all extensions are disabled?: Yes

Hi @Dvnoten
Can you clarify how many days?
Were you running old version of Azure Data Studio when you experienced the error?
This issue has been recently fixed in 1.41.0, which I believe got installed for you when you restarted ADS (as this version was released on January 25).

Hi @Dvnoten
Can you clarify how many days? Were you running old version of Azure Data Studio when you experienced the error?
This issue has been recently fixed in 1.41.0, which I believe got installed for you when you restarted ADS (as this version was released on January 25).

Hi thank you for your swift reaction.
I thought it was fixed in the latest release as well or that was what I hoped for. It was a long awaited feature/bugfix since, let us be honest here, an application that doesn't support Azure Active Directory authorization/authentication in a stable way for all the different components is... not great. It's also the only thing that is holding us back at the moment to switch to Azure Data Studio completely. The whole Azure Active Directory authorization and authentication issues and token expirations bugs are here for too long already. So please if you need any additional logs or anything let me know so I can help with this?
To answer on your question. I installed the latest version immediately when the release was out in the hope it fixed the issue so on 25 of January the new version was installed and around 2-3 days later this issue was there again.

Thanks,
I would recommend capturing verbose Azure Account and MSSQL logs if you do experience this issue again with MSAL (the new auth library now supported by default) and the latest release.
Please update ADS to the latest Hotfix v1.41.1 released today, and enable verbose loggings, keeping an eye on any related issues if they reoccur.
Will keep this issue under observation closely to see if it reoccurs.

Hi updated to version Hotfix v1.41.1. Issue just arised again like 2 mins ago (31/01/2023 10:43 UTC+01).
Logs here in attachments. Please have a look at this.
20230131T083851.zip
console.log

Thanks for the logs @Dvnoten
I see this error which explains the issue:
[error] Scripting failed. error: An error occurred while scripting the objects. Failed to connect to server ****.****.database.windows.net.
On the Azure side, there're no error, so I believe there're no authentication issue, and updated token is available, but it's not passed to the backend service (ScriptingService) requests.
Likewise, there are multiple paths/services where the backend connection does not get updated with new token due to current design issues (which we're working on changing to bring in a more robust long term design solution). The fix we made was specifically targeted for Object Explorer's Refresh and node expansion requests - so that should work. I will try to reproduce to see for any issues around Object explorer failing to refresh connection tree nodes after ScriptingService fails.

Confirming, this is indeed reproducible, and is also related with #21766, where if you refresh dashboard after access token is expired, the error in screenshot occurs.
Refreshing OE nodes, does not refresh backend connection for Dashboard & Scripting service, possibly because they're identified by different URIs.

@Dvnoten
We've introduced support that improves access token refresh behavior. The feature is now available in ADS insiders (download link) and can be enabled with below setting:
    "mssql.enableSqlAuthenticationProvider": true

It will be available in the ADS March 2023 release and is currently NOT enabled by default. We're evaluating any remaining improvements in this area to be able to enable this feature by default in future releases. Please give it a try and let us know your experience!

Closing this issue as resolved with setting mssql.enableSqlAuthenticationProvider enabled.
Verified locally in latest insiders.


support for windows

I'm trying to use this windows build but encountered the following error:
Generating files to arch "x86" and configuration "release"... ERROR at //build/config/clang/BUILD.gn:126:35: Undefined identifier   if (clang_use_chrome_plugins && clang_unsafe_buffers_paths != "" &&                                   ^------------------------- See //build_overrides/BUILDCONFIG.gn:390:5: which caused the file to be included.     "//build/config/clang:find_bad_constructs",     ^-----------------------------------------
Same for 'x86' and 64

Hi, it is not updated a long time. I will try update to latest version soon.


Reference USE_REDIS_CACHE environment variable

Instead of comparing the literal string "USE_REDIS_CACHE" to "true", reference the environment variable $USE_REDIS_CACHE.

@mhoran Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@mhoran Thank you for signing the Contributor License Agreement!


AMBARI-23369 Livy server fails to start after Ambari upgrade due to m…

…issing argument for nameservice
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
Ran all python unit tests, except one: test_web_server_startup_timeout in TestAmbariServer.py (which fails due to a known issue and not my change)
====================
Ran 235 tests in 9.325s
OK
Total run:1178
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:58 min
[INFO] Finished at: 2018-03-27T19:29:43+05:30
[INFO] Final Memory: 110M/988M
[INFO] ------------------------------------------------------------------------
Please review Ambari Contributing Guide before opening a pull request.

LGTM

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1429/
Test PASSed.


Email preferences are not working

When you enter into the email preferences route, you get the not found page because you don't have the token. I guess as there is no way to reach this route through the app, the email preferences feature is not implemented at all, but I just wanted to let you know.

When a user subscribes to the newsletter, an email will be sent to you.
If the user clicks on the unsubscribe button at the bottom of the email, you will be redirected to the email preferences page.

Ahh, okay. Then I'll just suggest that you enable a way to access it from the app, not just through the newsletter email. By the way, good job—I love your work!


[Question][Jira Plugin] How to handle "429 - Too many requests" issue from atlassian cloud

Question
After add a blueprint for a project from jira, the jira plugin always run failed for: 429 - Too many requests.
For there is no way to set the rate_limit_per_hour in config-ui, i update it in mysql by the command
 update _tool_jira_connections set rate_limit_per_hour = 1800 where id =1;

But we encountered the same issue somtimes.
Any suggestion are welcomed, thanks~
Screenshots
If applicable, add screenshots to help explain.
Additional context
time="2022-09-02 10:13:02" level=warning msg=" [task #16] [jira] retry #1 for http code error[429]:[<!DOCTYPE html><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><title>Oops - an error has occurred</title><link type='text/css' rel='stylesheet' href='/static-assets/metal-all.css' media='all'><meta name="decorator" content="none" />

Something went wrong

Try reloading the page, then check our Statuspage for any current outages. If there are no relevant outages, create a support request so we can help you out.

If you create a request, include the following so we can help you as fast as possible:

Error type: 429 - Too many requests

Log reference: 0d4104e5-ad74-4eca-b624-cc46a73bd1ef

Atlassian

]"
time="2022-09-02 10:13:02" level=info msg=" [task #16] [jira] [collectIssues] end api collection error: %!w(*errors.errorString=&{[http code error[429]:[<!DOCTYPE html><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><title>Oops - an error has occurred</title><link type='text/css' rel='stylesheet' href='/static-assets/metal-all.css' media='all'><meta name="decorator" content="none" />

Something went wrong

Try reloading the page, then check our Statuspage for any current outages. If there are no relevant outages, create a support request so we can help you out.

If you create a request, include the following so we can help you as fast as possible:

Error type: 429 - Too many requests

Log reference: 5d044ad0-1188-45a3-aa21-88af00f82ec0

Atlassian

]]})"

@lshmouse
We have implemented this feature in v0.13.0 version.
https://github.com/apache/incubator-devlake/tree/release-v0.13 , it is in the process of releasing.

@lshmouse We have implemented this feature in v0.13.0 version. https://github.com/apache/incubator-devlake/tree/release-v0.13 , it is in the process of releasing.

Perfect~ When will the 0.13 be release? Maybe I can build docker image using latest code.

@lshmouse yes, now the 0.13 version is release.


Update numba\cuda\cudadrv\enums.py

Feature request

Additional enums, e.g. for device attributes, have been added in recent cuda versions but are not yet represented in numba\cuda\cudadrv\enums.py.

Can you list the attributes you'd like to see supported please?


Declaration of var after return statement does not get detected in hoisting cases.

Unreachable 'var' after 'return'. on the following:
function main() {
  return 'Hello, World!';
  var foo = 'foo';
}

main();

but no error on this:

function main() {
  return 'Hello, World: ' + bar();

  function bar() {
    console.log(foo);
  }

  var foo = 'foo';
}

main();

What about:
function main() {
    return 'Hello, ' + foo;
    var foo = 'World';
}

main();

Since the return statement ends a statement it makes sense in the first case that it doesn't reach the 'var', in the second case it needs to evaluate and get 'foo' before it returns and thus executes after the statement (Though I'm not sure it would work)

Since the return statement ends a statement it makes sense in the first case that it doesn't reach the 'var', in the second case it needs to evaluate and get 'foo' before it returns and thus executes after the statement (Though I'm not sure it would work)

@Acuitas please can you clarify what you mean by first case and second case? I only see one example?
In that example foo will be hoisted, but not set, so it will return Hello, undefined. jshint currently reports it as unreachable 'var' after 'return'

@Acuitas, sorry about the earlier comment, I realised you were referring to the issue.
It doesn't work - bar is a function declaration and it is hoisted in its entirety (its not like foo which is hoisted but undefined). So the function bar() is in unreachable code, but is not warned because it is hoisted above it (its in a poor place IMO but it isn't unreachable code). This process does not effect the var foo = 'foo' statement which is still never executed.

See above commit with a couple of tests.
Fixing this is far from trivial. The existing reachable code relies on just peeking ahead until a particular token appears that it takes to mean "I give up trying to work it out".
To fix this properly probably involves tying into a unreachable manager (or the variable scope manager, though not sure if that over complicates it) then marking the current block scope as being unreachable forward. Then, ignoring sub functions and reporting anything wrong in the current scope.
It could get even more complicated with break labels that jump multiple blocks.
suggestion: switch on latedef, which warns if sub functions aren't at the top of their parent, then the unreachable code becomes more reliable and your code is easier to read.

suggestion: switch on latedef, which warns if sub functions aren't at the top of their parent, then the unreachable code becomes more reliable and your code is easier to read.

I think this is a good advice. However, some project prefers to keep sub functions at the bottom as a way to push the main body of the logic up top (as they contain the main business logic).

This bug was recently reported in different terms, so I'm renaming this issue to make it easier for folks to find.

Oh, wow -- this has been open for 3 years.


Improve loading time for images

Currently, images take a while to load as they're quite large. Can we compress the images when they are committed using a GitHub action to improve loading speeds?

Time improved.


MdDialog beforeClosed() feature

Bug, feature request, or proposal:
Feature request
What is the expected behavior?
If there is an afterClosed() event hook in dialogRef, why isn't there is an beforeClosed() hook?
What is the current behavior?
MdDialog currently supports only afterClosed() hook
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
In my app dialogs has its own router urls. Since i can only detect dialog closing only after animation has been passed, opening a new dialog while the older one is still closing might produce router errors.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4, Angular Material 2.0.0-beta.8
Is there anything else we should know?

@VagrantAI-c, you can encapsulate your dialog calling inside a component to do it (take a look at this stackoverflow.com anwer).
But if you follow the template issue, there's a section where you can show an use case that justify this implementation (I think it would be nice to have this feature).
Not following the issue template can lead the team to close your issue. Modify it as a feature request.

Duplicate of https://github.com/angular/material2/issues/4647

Dupe of #4647


OMERO.web image includes several other apps

The openmicroscopy/omero-web-standalone Docker image includes several bundled web-apps apps. This could potentially lead to conflicts when testing web applications with this repo: https://github.com/openmicroscopy/omero-test-infra/blob/9c607ce52c9cf153b98bd7e55211cfe2aeb352d5/.env#L11

Good point. I definitely didn't consider that when you opened your previous PR. Options I can think of:

split standalone into two images (one with and one without the apps)
have a flag to disable/reset the automated configuration
duplicate standalone's logic here
...


Update Catch2 version to fix compilation error with glibc greater than 2.33

Bump Catch2 version from v2.9.2 to v2.13.5 to fix MINSIGSTKSZ not being used as a constant expression (see #114).

Can confirms this fixes compilation for me too.

LGTM. I had to include this in #117 in order to build.

This was fixed in b74fecd4448a1a5549402d17ddc51e39faa5020c, so the PR can be closed.


Enabling a specific setting in ADF using Azure DevOps

Hi,
Recently I developed one ADF pipeline.
And in this pipeline I created one "WEB ACTIVITY" and enabled the following property in the settings

But when i try to generate ARM TEMPLATES this specific activity alone is not generated there, because of this it is not getting reflected in higher environments also when I do the deployment.
I even tried to enable this manually in the higher environments but when we try to deploy the ADF again it is getting disabled automatically
And I even tried ADF tools and PowerShell tasks to deploy the same and same problem there also
Can you please suggest me something on how to deploy this property to higher environments using Azure Pipelines.

Do you see this option in UI? I can't find it. If it's not there then might be unsupported yet.


Is there a way to see the time taken to run the entire test cases of a test suite from the UI?

Or could it be added via hooks? e.g.
const { logger } = require('../helper/logger');

async function extensionHook(hookName, context) {
  if (hookName === 'beforeAll') {
    context.suite.startTime = new Date();
  } else if (hookName === 'afterAll') {
    const endTime = new Date();
    context.totalTestTime = endTime - context.suite.startTime;

    logger.info(`Total tests: ${context.results.length}`);
    logger.info(`Total test time: ${context.totalTestTime} ms`);
    // Perform any necessary teardown or reporting
  }
}

module.exports = extensionHook;

I don't think we display this anywhere, but in theory we have the timing of every test case so could add it up.  If you want an informal timer I usually just run with time promptfoo eval on the command line.  Doing it with hooks is a clever idea


LivePlot editing causes scans to pause

If editing any plot (active or in-active), then data collection pauses.  Scan data is correct.  Paused time is reflected in data point timestamp.  It is nice to edit the legend to include important information when setting up the beamline or collecting preliminary data, but not actually collecting data that requires offline analysis.
In [70]: RE(dscan(diag6_pid, -50, 50, 30))
Transient Scan ID: 65843
Persistent Unique Scan ID: '0f08caca-06d2-4027-97c8-cf830429ff8b'
+-----------+------------+-------------------+----------------+--------------------+--------------------+-----------------------+------------+------------+------------+------------+------------+------------+---------------+
|   seq_num |       time | diag6_pid_actuate | diag6_pid_done | diag6_pid_readback | diag6_pid_setpoint | diag6_pid_stop_signal |   sclr_ch2 | mono_tempa | mono_tempb |  grt1_temp |  grt2_temp |  ring_curr | diag6_monitor |
+-----------+------------+-------------------+----------------+--------------------+--------------------+-----------------------+------------+------------+------------+------------+------------+------------+---------------+
|         1 | 16:26:50.9 |                 1 |              1 |           1174.000 |           1174.000 |                     1 |        173 |    302.749 |    302.745 |       34.3 |       28.7 |     249.74 |     280292094 |
|         2 | 16:26:52.3 |                 1 |              1 |           1177.333 |           1177.333 |                     1 |        158 |    302.749 |    302.746 |       34.3 |       28.7 |     249.74 |     279837827 |
|         3 | 16:26:53.8 |                 1 |              1 |           1180.667 |           1180.667 |                     1 |        181 |    302.750 |    302.751 |       34.4 |       28.6 |     249.74 |     280887306 |
|         4 | 16:27:32.7 |                 1 |              1 |           1184.000 |           1184.000 |                     1 |        208 |    302.748 |    302.752 |       34.3 |       28.8 |     249.43 |     279112544 |

ENH request:  Change the default for (RE-)Generate automatic legend to be checked to make editing the plot more efficient.  Or will the impact LivePlot in some other way?

The pausing is a feature of upstream mpl, I will look into fixing it there.
The default value of (re)-generate the legend is also an upstream default which is not easily configurable.
Working on a way to make what subscriptions are run by the 'spec' mode scans easier to customize so you can drop in a version of LivePlot that sets the label as you want it to start with.
If you can get a reference to the axes with the lines you want to edit you can look at ax.lines for the line artists and use ax.lines[n].set_label('new label'); ax.legend() to it programmatically.

I'll add that we are close to deploying a feature where plotting can be done in a separate process (or even a remote machine!) so that they can't interfere with the scan under any circumstances.
As Tom stated above, there's nothing we can do in bluesky to avoid this matplotlib/qt issue, so I'm going to close the report. Your only options are to avoid clicking the buttons on the plot and, soon, to adopt this soon-to-be-deployed feature next cycle.


Is there a way to make a new environment from a existing one?

What I mean is there a way to make a new env say testing with the same settings as development environment?  Just wondering

I don't understand the question.

@ap-coder Do you mean have a seperate .env file for testing?
If so, and you are using PHPUnit for your testing, you can create a file called .env.testing and load that in your phpunit.xml file to be used for tests. Just remember not to commit any secrets to your code base!


Bicycle infrastructure

Hi, thanks for this great project!
I maintain a fork of openmaptilers's OSMBright vector tiles style that focusses on bicycle infrastructure: https://github.com/leonardehrenfried/cyclo-bright-gl-style
Example tiles: https://photon-eu.stadtnavi.eu/styles/bicycle/#14.79/55.59635/13.01106
The problem is that openmaptiles doesn't really contain anything about bicycle infrastructure and I invented the schema additions mostly myself.
Is there an interest in getting this into Shortbread?

I would expect that at least some tags won't fit into the "basic, lean, general-purpose vector tile schema". But I'm interested to look into that in detail. I'm currently preparing a talk for SotM Europe about extending Shortbread and your use case is exactly what I had in mind.


fix core test

fix config mismatch for core test

Coverage remained the same at 45.926% when pulling 277d3176783cc591f8bf5e0402971384374cb86f on fix-tests into 81c0c0ef69cdafba2139f52437041cdaf6848423 on master.


Yvette Colomb: Watch weaveinc.org

Yvette Colomb requests the watch of the watch_keyword weaveinc.org. See the Metasmoke search here

!!/approve


permissions: implement proper permission policy for draft vs record files

In records-resources, there is:
self.require_permission(identity, "read_files", record=record)
(and their variations) embedded in many methods.
A way would be to override these methods in drafts-resources, copy the code wholesale and only change the require_permission:
self.require_permission(identity, "read_draft_files", record=record)

replaced by inveniosoftware/invenio-rdm-records#498


feat: switch off BerkeleyDB

The license change and generally instability (anecdotally speaking) with BerkeleyDB makes it a strong candidate for replacement with a different DB backend.

I am open to suggestions for a replacement.

I am open to suggestions for a replacement.

SQLite?

I need a key-value store with strong consistency guarantees. SQLite seems like a bad fit on both dimensions.

I need a key-value store with strong consistency guarantees. SQLite seems like a bad fit on both dimensions.

PostgreSQL? Etcd? TiKV? There is also RocksDB, but that requires a layer for consistency.

I don't see a reason to believe that BDB is less reliable than any of these systems, since I've only seen one apparent problem in 20+ years. But if someone wants to explore alternatives I am happy to look at PRs. It would need to be an option rather than a replacement in any case, for backward compatibility.


Can you get the source code?

Hello, I am very interested in this work, can you get the source code? Thank you

Thank you for your interest in our work. The source code has been released.
We appreciate your patience.


response from Llama2 and Falcon40B are truncated

When tried with Llama2 and Falcon40B are truncated for all questions. Tried several different hyperparameters like
[model_kwargs={"max_new_tokens":1024,"max_length":512,"top_k": 50, "top_p": 0.95,"temperature":0.6,"repetition_penalty":1.2},
but this doesn't seem to be getting fixed. Please check.

Fixed with the latest release


The screenshare only works on local networks

Yes I know about this issue, planning to fix it, but for now it'll stay as a issue. Mainly because it sounds really damn hard to fix.

sorry if this gives you an annoying notification but this seems really cool i might use it the future and if you would like i have some ideas for it


Change to use project folder as default project name.

Fixes #295

[x] npm run test succeeds.
[x] npm run lint succeeds.
[ ] Appropriate changes to README are included in PR.

Thanks!


[feature](array function) add support for array_enumerate_uniq

Proposed changes
Issue Number: #17448
Problem summary
add support for array_enumerate_uniq()
Checklist(Required)

[x] Does it affect the original behavior
[x] Has unit tests been added
[x] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

@eldenmoon

run p0

run p0

run buildall

run p0

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.95 seconds
stream load tsv:          460 seconds loaded<PHONE_NUMBER>9 Bytes, about 155 MB/s
stream load json:         39 seconds loaded<PHONE_NUMBER> Bytes, about 57 MB/s
stream load orc:          74 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230308073754_clickbench_pr_110629.html

I run the regression test locally and it failed at an irrelevant test suit:
2023-03-08 16:04:13.763 INFO [main] (RegressionTest.groovy:277) - Failure suites:
/home/baohan/projects/doris/regression-test/suites/query_p0/sql_functions/array_functions/sql/q03.sql: group=default,p0, name=q03

/doris/regression-test/suites/query_p0/sql_functions/array_functions/sql/q03.sql:
DROP TABLE IF EXISTS array_insert_select_test;
CREATE TABLE IF NOT EXISTS array_insert_select_test (id int, c_array array<int(11)>) ENGINE = Olap DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS 1 PROPERTIES('replication_num' = '1');
insert into array_insert_select_test select k1, collect_list(k3) from test_query_db.test group by k1;
select c_array from array_insert_select_test;

Should I do the rebase?

@bobhan1 you could ignore array_functions/sql/q03.sql while run local, since the query rely on a table from load related regression test case

run p0

run p0

Does the number of checks depend on the cheklist above?

run p1

run p0

run p0

run p0

I wonder why the following checks are not triggered.


Added a link breaking command.

I see no reason for this...?

I think we've been over this in the past. If the link breaks rules and should be unlinked, the user should be at least warned.

What about in the case of private rooms

Mute, I guess.


Creates an Oracle dependency updater

Summary
This PR creates an Oracle dependency updater. It looks at https://www.oracle.com/java/technologies/downloads/ and scrapes out the latest version numbers for the given type and version branch. Valid types are either jdk or graalvm. It will then fetch the download and calculate all the metadata.
Use Cases
This works for downloading Oracle dependencies. Currently, we're using Foojay for Oracle JDK updates, but I couldn't quickly figure out how to get it to pull down GraalVM updates. I did this instead and the bonus is we're getting updates as soon as they are published by Oracle.
Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

We're good to move ahead on this.