Celo Wallet Council Call 2

Celo Wallet Council Call 2

Event Details
When: Wednesday, September 1st, 2021, 12 PM EST/9 AM PST, 60 minutes max
Where: Google Hangout Event
Calendar Event: Add to your calendar TBD
Meeting Notes
Summary
The Celo Celo Wallet Council Call is the "All Hands" call for all Celo Wallet Developers to to come together, discuss ideas that shape our Celo ecosystem, and align on best practices.
Agenda
We would like to continue identity discussions we started last week. Feel free to add other discussion ideas and +1 in the comments of this ticket.

EIP3074 - possibly eliminates the need for Metatransaction Wallets
Phone number verifications - usage, user experience, batch processing, centralization
Token Standards - TBD add reference documentation

Other possible deep dive discussions:
- use-contractkit - modal for wallet integrations
- offchain storage, account profile pictures and names
- transaction parsing
- merchant payment standards (with qr code)
- erc20 lists
- transaction feeds tooling, notifications
- peer discovery (matchmaking)

Add any of these or other topics in comments below and +1 if you'd like it to be prioritized in this or next meeting.

Would be great if we can also discuss current status of WalletConnect and what the major blockers are for proper DApp + Wallet adoption for it. Or if we have a path forward to actually get it to be reliable/usable.
From my view, I still see issues with all of:

Protocol flakiness itself (i.e. walletconnect/client implementation)
Relayer flakiness (i.e. walletconnect.celo.org)
DApp interface flakiness (i.e. use-contractkit and custom implementations that DApps use)
Still some issues within Wallets too (might be related to just bugs in walletconnect/client library though)


signal_encoding_physical_value: Can not handle Floating-point arithmetic

Hello,
I am not able to parse my LDF file that contains signal representation value in floating point format like 1e-005 instead of float value
Ex:
HighCurrent {
physical_value, 0, 1023, 1e-005, 0, "Ohm" ;
}

Could you check the feature/float-scientific-notation branch, whether or not it's working as intended? I did a few tests and it seems to work, keep in mind that internally it will be converted into a floating point number and for example in the exported dictionary the notation might be different.
In the LDF standard the definition of real_or_integer is:

A real or integer number. A real number is always in decimal and has an embedded decimal
point.

Regardless I don't see this interfering with anything, but you might want to check other tools as well, because if those don't support it then you may need to change the LDFs.

This fix seems to work. Now I can parse LDF file without any problem

Feature has been released under 0.11.1.


fix: Fix entityBuilder.fromJson() to accept actual JSON

Related to #931. Transforms JSON to an entity without assuming instances of entity for navigation properties.

@marikaner would you like to fix the merge conflict and merge?


Support for Nullable Tables

Given the following code:
class TomlReadTest : FunSpec({
    test("toml read nullable") {
        @Serializable
        data class Key(val value: Long)
        @Serializable
        data class Config(val key: Key?)

        val mapper = Toml(
            config = KtomlConf(
                ignoreUnknownNames = true,
                emptyValuesAllowed = true
            )
        )
        val toml = mapper.decodeFromString<Config>("""
            [key]
            value = 1
        """.trimIndent())

        assertNotNull(toml)
        assertEquals(1L, toml.key?.value)
    }
})

It is expected to deserialize Config with key = Key(1L), however ktoml fails with:
This kind of node should not be processed in TomlDecoder.decodeValue(): com.akuleshov7.ktoml.parsers.node.TomlTable@6d9c9c74
com.akuleshov7.ktoml.exceptions.InternalDecodingException: This kind of node should not be processed in TomlDecoder.decodeValue(): com.akuleshov7.ktoml.parsers.node.TomlTable@6d9c9c74
	at com.akuleshov7.ktoml.decoders.TomlDecoder.decodeKeyValue(TomlDecoder.kt:96)
	at com.akuleshov7.ktoml.decoders.TomlDecoder.decodeValue(TomlDecoder.kt:25)
	at com.akuleshov7.ktoml.decoders.TomlDecoder.decodeNotNullMark(TomlDecoder.kt:36)
	at kotlinx.serialization.encoding.AbstractDecoder.decodeNullableSerializableElement(AbstractDecoder.kt:79)

Changing to a property with default value does work:
class TomlReadTest : FunSpec({
    test("toml read nullable") {
        @Serializable
        data class Key(val value: Long)
        @Serializable
        data class Config(val key: Key = Key(0L))

        val mapper = Toml(
            config = KtomlConf(
                ignoreUnknownNames = true,
                emptyValuesAllowed = true
            )
        )
        val toml = mapper.decodeFromString<Config>("""
            [key]
            value = 1
        """.trimIndent())

        assertNotNull(toml)
        assertEquals(1L, toml.key.value)
    }
})

All my code base uses Kotlinx Serialization, only the configuration parsing is using Jackson and I would like to remove this.

Hello @JonathanxD! Thank you for this issue! I even did not think that someone will use a default value for the table… I will try to support it in the nearest release.
But it looks that I will need to change the logic significantly


[Backport] Lookup cache bug fixes (#3609)

Backport of #3609

Return better lastVersion from JDBCExtractionNamespaceCacheFactory's cache populator callable

Return the lastVersion if URI lookup last modified date is not later than the last cached, from URIExtractionNamespaceCacheFactory's cache populator callable

Fix a race condition in NamespaceExtractionCacheManager.cancelFuture()

Don't delete cache from NamespaceExtractionCacheManager if the ExtractionNamespaceCacheFactory returned the same version as the last; Better exception treatment in the scheduled cache updater runnable in NamespaceExtractionCacheManager (in particular, don't consume Errors); throw AssertionError in StaticMapExtractionNamespaceCacheFactory if the lastVersion != null)

In NamespaceExtractionCacheManager, put NamespaceImplData.latestVersion update in the same synchronized() block with swapAndClearCache(id, cacheId); Turn getPostRunnable which returns a callback into a simple updateNamespace() method

In StaticMapExtractionNamespaceCacheFactory.getCachePopulator(), check the input directly, not inside a callback

In URIExtractionNamespaceCacheFactory, allow URI last modified time to go backwards

Better logging in NamespaceExtractionCacheManager

Add comment on lastVersion nullability in URIExtractionNamespaceCacheFactory

# Conflicts:
#	extensions-core/lookups-cached-global/src/main/java/io/druid/server/lookup/namespace/URIExtractionNamespaceCacheFactory.java

👍

👍 waiting for travis


enabled backspace functionality in text-assessments

Motivation and Context

It should be possible to refactor ones score in a text submission using backspaces.
Description

removed a setting which prevented refactoring via backspace.
Steps for Testing

In a text submission, when assessing a specific text fragment, it is now possible to remove entered credits through backspace.

Regarding the error: Leaving the credits empty leads to an error, however, removing credits through the Entf key can also leave a empty credits field. Setting the score to 0 after clicking the backspace key does not fix the Entf issue, so I should implement some sort of credit check.

Maybe try to set it to 0 if the value changes to nothing?

Update: Did a check so when a assessment is saved it checks whether credits are null and if, inserts 0.0 instead. This should fix the error of blank credits.

Why not set this client-side?

I've tested the features on the specified test server with both instructor & tutor roles.
When I tried using Backspace to delete a given score, it didn't work. However Ctrl + Backspace does the job.
"Entf" button only deletes the credit if the given credit is already already highlighted. (meaning selected with mouse or ctrl+arrow keys)
I cannot submit an assessment that features a feedback without a score, I have to insert 0 so that it's valid.

@csarpkaya Can you specify what exactly doesnt work when trying to use backspace? I just deployed in again and tested it and backspace works as well as submitting without credits works.

I am also not able to reproduce the problems addressed by @csarpkaya. (I've used chrome and firefox)

"entf"/delete: worked fine for me, deleted the next symbol to the right (if there is no symbol on the right side of the cursor nothing happens, but I think this is the expected behaviour - did this maybe lead to some confusion?)
backspace / control + backspace also worked fine for me
saving an empty score field / entering non numeric values in the score field resulted in 0 points, as expected

@florian-glombik We solved the problem. Can forgot to deploy on the server, so the features where not up to date. After deploying again, he mentioned it works properly.


Update x64-calling-convention.md

Add link to __vectorcall documentation

@TylerMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add CI pipeline for Linux and macOS

Added CI pipeline for Linux and macOS and removed obsolete scripts

please send separate pull request for CI pipeline. the rest needs to be reworked


Receive Euler angle instead of quaternion angle from Vicon bridge package

Hi every body,
I would like to know that what i have to edit inside vicon bridge packet so that I receive the Euler angles ( roll, pitch and yaw) instead of quaternion angles ( x, y,z, w).
Thanks

Why would you do that? Why can't you directly convert a quaternion to euler angles directly in your application, for example by using Eigen?

Hi friend,
In my case I would like to control my drone with angle. Therefore, I prefer to use euler angles instead of quaternion angles. I can use Eigen to convert (TF or TF2 function) but it is not good for the asynchronous problem between different machines.
Thanks

I still don't see why you want to implement the conversion between quaternion and euler angles directly in this repo. You can use the same timestamp and convert the quaternion to euler angles in the callback function of your drone, when you receive ad odometry message from vicon for example ... or am I missing something else?

Hi Marco,
I used to use TF library to convert quaternion angles into Eurler angles for a IMU sensor and I read successfully roll pitch and yaw angles. However, when I used roslaunch for remote machines, a message relative to TF function (Error: TF_OLD_DATA) appeared every 0.1 seconds and made my network overload. Here are some references (http://wiki.ros.org/tf/Errors explained). Therefore, I had to convert directly quaternion angles into eurler angles and it worked quite well for IMU sensor. However, I would like to receive Euler angles directly from Vicon instead of using this code two times.

Like Marco, I don't really understand why you cannot convert to Euler angles after the vicon_bridge. However, you need to modify the process_frames function in vicon_bridge.cpp. The msvcbridge has a function getSegmentEulerXYZ that you could use instead of getSegmentQuaternion.
Hope it helps.

Hi kdhansen,
Yes, I saw the functinon getSegmentEulerXYZ in msvcbridge and i can edit it in process_subjects. My version of ros is Indigo. Can you tell me some places more I have to edit also? Thanks.

Well, just go ahead and advertise another topic with the Euler angles. E.g. use Eigen as Marco pointed out. Here is an example: http://stackoverflow.com/questions/31589901/euler-to-quaternion-quaternion-to-euler-using-eigen
Best of luck

@zer1988 I think the error TF_OLD_DATA can be related to the fact that the two machines are not synchronized in time. Other than the solution pointed out by Karl, I'd suggest you try to use chrony to synchronize your machines ;)
Nevertheless, since converting a quaternion to euler angles is so easy with Eigen, I'd still do it after the vicon_bridge.


Error when trying to export any resource

Hi there, I am trying to export dashboards and SLOs from one tenant.
I am using:

macos 11.2.3
terraform 1.1.5
terraform-provider-dynatrace 1.9.1
token generated with the required scopes: read slo, wrirte slo, read configuration, capture request data

Steps to reproduce:

Create project with provider resource
terraform init
terraform apply
export required env vars.
run terraform-provider- dynatrace_1.9.1 generated locally: .terraform/providers/registry.terraform.io/dynatrace-oss/dynatrace/1.9.1/darwin_amd64/terraform-provider-dynatrace_v1.9.1 export dynatrace_dashboard

Result:
The environment variable DYNATRACE_TARGET_FOLDER has not been set - using folder 'configuration' as default invalid character '<' looking for beginning of value
and an empty folder created: configuration/dashboards
Expected result:
folder configuration populated with all existent dashboards in the tenant.
Notes:

i tried with dashborads and SLOs. no luck
when I run the command it does not seem to reach the tenant because the token wasn't being marked as used in the dynatace access token dashboard.
I tested the token to get dashboards with the REST API and it works.

Any ideas? What am I doing wrong?
Thanks

Nevermind....my problem was that I added a / at the end of the URL....maybe you want to explicitly mention not to put a ending /  in the README

I just experimented around for an hour locally, trying to reproduce it. Finally I remembered that this is an issue that's on my backlog already :)
I'll introduce validation and auto-correct of flawed values for the environment URL with the next release.


Focus for YouTube not working anymore

No more effects on YouTube, anyone else experiencing the same ?

Working for me

I've updated my Mac to the new Ventura OS and it's now also no longer working!


Optional interactive interpreters

Implements issue #210.
This allows the optional use of bpython or IPython as the interactive interpreter. I used the referenced Django code as an example for this implementation.

hey, thanks for the contribution! will try to find time to review as soon as possible

Thanks for your constructive feedback.
I have:

removed the --plain argument and made plain an available shell.
added ShellRunner responsible for starting the interactive shells, so the globals are gone.
added the manual startup script before each of the interactive shells.

cool. had a quick look at drying up the tests and noticed they fail if bpython or ipyhton are installed. added a fix on top (see separate pr)


Accessing the known property in Python extension API is slow

here's the cpu profile
Creating a new issue as others have been closed.
This will hopefully be specific to improve performance of the API.
As you can see below, determineExtensionFromCallStack still takes around 2.7s and readFileSync still takes almost 1s.
I.e. almost 4s can still be reduced from the overall discovery of Jupyter kernels when using the Python API.

latestxx.cpuprofile.txt

Sorry it seems the latest pre-release on Friday did not have the fixes in yet, I've published another one, can you try in about 30 minutes?

Awesome, performance is back to what it was now.
Kernels refresh in  4s (back to what it was)
Thanks


Simplify Makefile consumption for new contributors

conftest installation now works on macos
conftest/opa will be installed if needed by another target

Signed-off-by: arewm<EMAIL_ADDRESS>

Lgtm I think. I like the suggestion of using go run -modfile tools/go.mod  but that could be done in a later PR.


Sending a message with file after uploading the file gives file not found error

Hello,
I upload a file to Slack, and then send a message to a channel referencing that file. However, if I call them immediately after each other, sending message fails saying it could not find the file. If I wait for about 1 sec between these two operations then it works, I can see the image in the sent message in Slack.
Reproducible in:
slack_sdk==3.27.1
Python 3.10.13
ProductName:            macOS
ProductVersion:         14.1.1
BuildVersion:           23B81
Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000

The Slack SDK version
slack_sdk==3.27.1
Python runtime version
Python 3.10.13
OS info
ProductName:            macOS
ProductVersion:         14.1.1
BuildVersion:           23B81
Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000
Steps to reproduce:
from slack_sdk import WebClient
import ssl
import certifi
import datetime

token = ""
channel_id = ""
img_path = ""

ssl_context = ssl.create_default_context(cafile=certifi.where())
client = WebClient(token, ssl=ssl_context)

fd = open(img_path, 'rb')
slack_response = client.files_upload_v2(
    file=fd.read(),
    alt_txt="screenshot"
)
fd.close()

print(slack_response)

message = [
            {
                "type": "section",
                "text": {
                    "type": "mrkdwn",
                    "text": "*Bug Report* :ladybug:"
                }
            },
            {
                "type": "section",
                "fields": [
                    {
                        "type": "mrkdwn",
                        "text": "*Company:*\nCompany"
                    },
                    {
                        "type": "mrkdwn",
                        "text": "*User Name:*\nUser name"
                    },
                    {
                        "type": "mrkdwn",
                        "text": "*Browser Type:*\nBrowser Type"
                    },
                    {
                        "type": "mrkdwn",
                        "text": f"*Timestamp:*\n{datetime.datetime.now().strftime('%d/%m/%Y %H:%M:%S')}"
                    },
                    {
                        "type": "mrkdwn",
                        "text": "*Title:*\nTitle"
                    },
                    {
                        "type": "mrkdwn",
                        "text": "*Description:*\nDescription"
                    },
                    {
                        "type": "mrkdwn",
                        "text": "*Error Message:*\nError Message"
                    }
                ]
            },
           {
                "type": "image",
                "alt_text": "screenshot",
                "slack_file": {
                    "id": slack_response["file"]["id"]
                }
            }
        ]

client.chat_postMessage(
    channel=channel_id,
    blocks= message,
)

The output is
{'ok': True, 'files': [{'id': 'F07AZJY97DE', 'created':<PHONE_NUMBER>, ...}

Traceback (most recent call last):
  File "...", line 73, in <module>
    client.chat_postMessage(
  File "myenv/lib/python3.10/site-packages/slack_sdk/web/client.py", line 2564, in chat_postMessage
    return self.api_call("chat.postMessage", json=kwargs)
  File "myenv/lib/python3.10/site-packages/slack_sdk/web/base_client.py", line 155, in api_call
    return self._sync_send(api_url=api_url, req_args=req_args)
  File "myenv/lib/python3.10/site-packages/slack_sdk/web/base_client.py", line 186, in _sync_send
    return self._urllib_api_call(
  File "myenv/lib/python3.10/site-packages/slack_sdk/web/base_client.py", line 317, in _urllib_api_call
    ).validate()
  File "myenv/lib/python3.10/site-packages/slack_sdk/web/slack_response.py", line 199, in validate
    raise e.SlackApiError(message=msg, response=self)
slack_sdk.errors.SlackApiError: The request to the Slack API failed. (url: https://www.slack.com/api/chat.postMessage)
The server responded with: {'ok': False, 'error': 'invalid_blocks', 'errors': ['invalid slack file [json-pointer:/blocks/2/slack_file.id/slack_file]'], 'response_metadata': {'messages': ['[ERROR] invalid slack file [json-pointer:/blocks/2/slack_file.id/slack_file]']}}

If I add time.sleep(1) just before sending message it works fine. It sends the message with attached file. Sometimes up to 0.5 sec also works.
Expected result:
I expect file upload to be observable with less latency.
Actual result:
SlackApiError("The request to the Slack API failed. (url: https://www.slack.com/api/chat.postMessage)\nThe server responded with: {'ok': False, 'error': 'invalid_blocks', 'errors': ['invalid slack file [json-pointer:/blocks/2/slack_file.id/slack_file]'], 'response_metadata': {'messages': ['[ERROR] invalid slack file [json-pointer:/blocks/2/slack_file.id/slack_file]']}}")

Thanks for submitting this issue, @nursimaaigoritma! 🙌
Looking over it initially, it does appear to be a latency issue as you identified, but is a bit confusing since it does seem that the file upload API call has fully executed, which indicates a file was uploaded successfully.
Before examining that side of this, I did want to see if using the url param instead of id within your slack_file Block made a difference. You could do something like this:
file_url = slack_response.get("file").get("permalink")

...
# within your message block kit, replace the image block using `slack_files` with this:
 {
        "type": "image",
        "alt_text": "screenshot",
        "slack_file": {
                "id": file_url
            }
}
...

Just wanted to see if using the permalink of the file made a difference or not with file retrieval in this case vs. the ID! You can learn more in this guide.

It gives another error (again while sending the message):
The server responded with: {'ok': False, 'error': 'invalid_blocks', 'errors': ['input must match regex pattern: ^[F][A-Z0-9]{8,}$ [json-pointer:/blocks/2/slack_file/id]'], 'response_metadata': {'messages': ['[ERROR] input must match regex pattern: ^[F][A-Z0-9]{8,}$ [json-pointer:/blocks/2/slack_file/id]']}}

Url was like this
https://our-workspace.slack.com/files/xxxxxxxxxxx/xxxxxxxxxxx/uploaded_file

@nursimaaigoritma files.upload v2 has a slight delay in completing the file upload process. Therefore, for this use case, your app needs to poll the files.info API endpoint with the uploaded file IDs until the shares properties are populated (indicating that the files are successfully uploaded and shared). Please refer to https://github.com/slackapi/python-slack-sdk/issues/1329#issuecomment-1430589611 for more details.
If you try to embed the file permalink in a block before the process is completed, displaying the block can result in the error you've encountered. I understand this could be frustrating but I hope this clarifies.

Yes this absolutely clarifies. Thank you for the response. Would you consider adding it to documentation (or I may have missed it)? As I understand, making files_upload_v2 asynchronous was a deliberate choice and only way to ensure file is ready is by polling.

Can I assume file upload is completed if client.files_info(file=file_id) returns "ok": True?
I try this
# uploading file is same
# ...

# check if completed
import polling
polling.poll(
    lambda: client.files_info(file=file_id)["file"] is not None,
    step=0.5,
    timeout=10
)

# At this point, I assume file upload is complete and I can use the id in a message
client.chat_postMessage(
    channel=channel_id,
    blocks= message,
)

But the problem persists. Should I check something else in the "files_info" response?

Should I check something else in the "files_info" response?

Yes, you need to check the updates on the file metadata. Specifically, mime_type, shares, and a few others will be filled once the upload process completes.


chore(bump-abacus): improve commit message format

Improves the commit messages that are generated by the bump_abacus script by using the * symbol instead of the > one, so that proper bullet lists are created.

Coverage remained the same at 91.628% when pulling 8c7fa69293d79a6c8144ee0ddcc5cc9dced4d016 on SAP:bump_abacus_styling into 063440855c5d175632386eb27f3005d529fd9666 on cloudfoundry-incubator:master.


More easy-to-understand name space configration

I hope you are doing well. I am now working on the data reduction programme, and got a little bit inconvenient namespace for the necstdb database.
In the namespace of necst, parameters related to antenna is assigned as necst-OMU1P85M-ctrl-antenna-encoder, where we can understand this is related to telescope control because of the ctrl namespace. The same thing appears in necst-OMU1P85M-data-spectral-board1, where data is a key identifier. However, the parent namespaces of topic names related to weather loggers are f"necst-{config.observatory}-". For example, temperature and humidity has  necst-OMU1P85M-humidity and staff like that namespace. Why don't you change the name space to necst-OMU1P85M-weather-humidity?
If you change the name space like necst-OMU1P85M-weather-humidity, I can subtract the weather condition data by a
simple code below:
prefix = f"necst-{config.observatory}-"
all_observation_results = [
    tablename for tablename in db.list_tables()
    if tablename.startswith(prefix + "-weather")
]

But now, I need to make a list of weather condition parameters before the data loading.

@r-yamada1998
Thank you for the proposal!
The idea will definitely improve the accessibility to topic groups.
But there, I think, is another way to realize the improvement; group the data together into single message:
>>> msg = WeatherMsg(humidity=0.5, temperature=279, pressure=855)

and publish to the topic named /necst/{config.observatory}/weather_ambient or /necst/{config.observatory}/weather/ambient.
In my opinion, this is the right place to use newly defined namespace.
I'd like to hear your idea regarding the above-mentioned solution.


Alt text not appearing using photosrcalt template

I'll try to come back to this myself in a bit, but if anyone has a "quick" fix...
It appears that the https://indieweb.org/Template:photosrcalt template isn't dispalying alt text as one would expect. I've attempted to tweak the #if statement to get the alt text to display, but apparently there are is a bug/issue with "=" appearing within them (this could also be a problem with the src parameter if the URL includes an equal sign as well, as they often can eg: http://example.com/?p=1)
It appears that instead of using anonymous parameters, we ought to use numbered or possibly named (src & alt perhaps?) parameters. Not being a wiki expert, will changing them to numbered or named break all of the current pages using the template, or if unspecified will they use the default order convention within the new numbered/named set up?
I've also tried templating the = or using  on it, neither of which seems to work.
As it stands the current template seems to work, but just won't display the alt text properly.
See also:
https://www.mediawiki.org/wiki/Help:Templates for details on anonymous, numbered, named parameters
https://phabricator.wikimedia.org/T16235 for problem with = appearing in parameters
https://en.wikipedia.org/wiki/Help:Template#Usage_hints_and_workarounds

@chrisaldrich Which page(s) is this not working on? At a glance, it seems to be working on https://indieweb.org/events/2016-06-29-homebrew-website-club

Perhaps it was a cache issue as I was running out of the office this morning? I see it working on my laptop presently. Thanks @gRegorLove for keeping me sane.
I'll mark as closed, though I'll come back to test the other spurious issue in URLs from home.

Re-reading and testing, I did find that without explicit 1= and 2= before the parameters, equal signs cause problems. I updated the documentation so the example uses them and explained why they're recommended.


Implement ProbeMiner annotation within the target step

ProbeMiner is one of our Chemical Probes resources. We currently download and process the ProbeMiner data dump using a R script that generates a .tsv file with three columns for ingestion into the pipeline.
We would like this annotation to happen in the target step as the processing is quite uncomplicated:

Reading of the compressed .txt file located in its respective bucket.
Filter the table with those compounds where target_potency_raw > 5
Group the table by UNIPROT_ACCESSION and create a probes_per_target column with the number of rows per uniprot ID.
So far we were mapping the uniprot IDs to HGNC symbols in such a way that the final table consisted of these three columns:

hgnc_symbol	uniprot_symbol	nr_of_probes
UBA6	        A0AVT1	                5
MACROD2	A1Z1Q3	                1
...

When implementing this step in the pipeline, I don't know exactly at what point this target mapping should be done. My feeling is that we were using the HGNC symbols as an intermediary mapping before doing so to an Ensembl ID because maybe we previously didn't have uniprot references in the target index.
In this case, this processing should only output two columns:
uniprot_symbol	nr_of_probes
A0AVT1	                5
A1Z1Q3	                1
...

Let me know if you come up with any suggestions or questions.

This work is no longer needed as Probe Miner scores are coming from the same chemical probes source (see #1536)


Lift constant inputs to TRAVERSAL, SHORTEST_PATH, and K_SHORTEST_PATH into CalculationNode for Smart Graphs

This PR adds an optimizer rule that lifts constant input start vertices for TRAVERSAL, SHORTEST_PATH and K_SHORTEST_PATHS queries on smart graphs into a CALCULATION.
This is done because for disjoint smart graph queries, the graph queries can be distributed to a DBServer, but for this to happen  the DISTRIBUTE node needs access to the start vertex value.
This is the simplest way to achieve this.
Once DisjointSmartGraphs are merged this optimizer rule could be restricted to disjoint smart graphs, or extended to all graph queries (bearing in mind possible performance implications).
Note also the Enterprise PR which contains the actual optimizer rule.

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9586/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9589/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9591/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9594/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9595/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9599/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9604/

Jenkins finally blue.

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9609/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9613/

Agreed over Slack that the Changes have been implemented as intended.


Jpeg muxed to Motion photo is bugged

Hi there! Thank you for creating this script.
I have just been facing issues trying to batch Mux my photos from my iCloud to my Samsung tablet. Specifically, that the JPEG Motion photos created by this script seem to be unable to display the motion on the Samsung Gallery App and Google Photos App.
To illustrate my issue, here is the JPEG and MOV I will be trying to turn into a motion photo:
JPEG motion photo test.zip
Where after running the script within windows:

I am left with this result:
IMG_3338 result.zip
However, when I try to view this motion photo on Samsung's Gallery App, I am provided the option to "View motion photo", however the video muxed does not show up:
https://github.com/user-attachments/assets/b2bf48f5-46e6-4cf8-8724-86ad3eb4699d
As for viewing on Google photos, the option to view the motion photo is not present:

From my use of the program, this issue does not occur for HEIF/HEIC files.
(To provide further details, I am using the latest update for both Samsung Gallery App & Google Photos app, using v1.3 of MotionPhoto2 and using exiftool-12.99_64)

Hello, I'm currently working on a python implementation of this software, I found the same issue with .jpg

Hi,
Thanks for a very detailed report. I'll leave the issues with Samsung app to issue #5, please follow that one - I hope that once I remux the video to mp4 and copy metadata to be more android style it'll be accepted...
As far as the issues in google photos, I am also able to replicate them - but not in exactly the same way as you. Once the file is uploaded to cloud, it is detected as motion photo... But the playback fails. I'll try to tweak things and hopefully fix it - it seems that there is some issue with parsing of XMP metadata.
In any case, as a hint (that will not work for this particular case, though): If GPhoto fails to show a picture as a live photo, try to upload it to cloud, delete local copy and download it back. The local playback sometimes works and sometimes does not and is dictated by the particular phone's libraries (it may as well only work for motion photos taken by that particular phone model). But once in cloud, GPhotos tries to parse many possible motion photo formats (of which this script creates one) and when downloaded back to the phone/tablet, it converts it to be compatible with that model.

Hello, I'm currently working on a python implementation of this software, I found the same issue with .jpg

Strange thing is, I have a lot of old motion photos in JPG format, but from iPhones incapable of heic (OG iP SE mostly), and these jpegs do work for me...
Anyway, if small fixes fail to work, muxing jpegs using the MotionPhoto v1 format like in https://github.com/mihir-io/MotionPhotoMuxer is the way to go (we just need to fix the footer to be compatible with Samsung app, as it is currently cutting off few necessary bytes from the footer)

Hello, I'm currently working on a python implementation of this software, I found the same issue with .jpg

Also, do ping me here once you have something at least partially usable... I started this to teach myself PowerShell, thinking that at least it'll not require any runtime to run on Windows...  I wouldn't mind switching to python for this myself :-)

Hello, I'm currently working on a python implementation of this software, I found the same issue with .jpg

Strange thing is, I have a lot of old motion photos in JPG format, but from iPhones incapable of heic (OG iP SE mostly), and these jpegs do work for me...
Anyway, if small fixes fail to work, muxing jpegs using the MotionPhoto v1 format like in https://github.com/mihir-io/MotionPhotoMuxer is the way to go (we just need to fix the footer to be compatible with Samsung app, as that implementation is currently cutting off few necessary bytes from the footer)

Edit: I've done another test muxing .jpg works only with vertical image (taken with front-camera), photo with rear-camera in landscape mode cause a playback issue on gphoto

IMG_1497.zip
This archive contains a .HEIC file and .MP4. Both files where takeout from Google Photo, in the past the images was uploaded with "compress method", so the .HEIC file as the signature of .JPG file, my python script automatically change the ext if detect this issue.

Interestingly, google does convert the apple gainmap format to adobe one and not to google one.
In what direction are you changing the extension? By now it is a HDR JPG file, not heic - do not mux it as heic, otherwise mpvd top level box is added and the resulting motion photo is broken.

I've tried a bunch of 200 pictures, the only issue is with the one taken with the iPhone 14 pro max, the ones with the iPhone 11 are motioned without any issue :)

IMG_1497.zip
This archive contains a .HEIC file and .MP4. Both files where takeout from Google Photo, in the past the images was uploaded with "compress method", so the .HEIC file as the signature of .JPG file, my python script automatically change the ext if detect this issue.

Interestingly, google does convert the apple gainmap format to adobe one and not to google one.
In what direction are you changing the extension? By now it is a HDR JPG file, not heic - do not mux it as heic, otherwise mpvd top level box is added and the resulting motion photo is broken.

I've just rename the file .HEIC with .JPG extension (the same can be achieved with exiftool '-FileName<%f.$FileType' -ext HEIC .) - Could you please try mi archive with your powershell script?
As I already said the files .HEIC and .MP4 are originally takeout from Google Photos. Taken and uploaded with "compress mode" with an iPhone 14 Pro Max.

It fails in the same way - motion is detected, but not played back

I've just rename the file .HEIC with .JPG extension (the same can be achieved with exiftool '-FileName<%f.$FileType' -ext HEIC .) - Could you please try mi archive with your powershell script?

It's probably easier to detect this by the header of the file - if first 4 bytes of the file are 0xFFD8FFE0 it is JPG, if bytes 5-8 are "ftyp" it is some derivative of MP4, i.e. heic. You can avoid one exiftool call :-)

I don't understand why with https://github.com/doodspav/motionphoto the mp4 is played on gphotos and not with our implementation - same files 😕

That's because all other implementations actually implement the Google standard, e.g. MotionPhoto ver 1, whereas this one implements the weird Samsung standard "mpv2". You can see that in ver1, the video is actually part of the footer (e.g. you have some magic bytes, then "MotionPhoto_Data", then video and then again magic bytes; and the values in XMP are filled with correct numbers. Whereas in ver2, you have photo + 8-byte separator + video + full trailer at the end. The important pointers are only in the trailer, the values in google XMP header are filled with nonsense.
I'll try to find some time to add the code to mux ver1 this week for JPGs, as it is clearly more compatible...

That's because all other implementations actually implement the Google standard, e.g. MotionPhoto ver 1, whereas this one implements the weird Samsung standard "mpv2". You can see that in ver1, the video is actually part of the footer (e.g. you have some magic bytes, then "MotionPhoto_Data", then video and then again magic bytes; and the values in XMP are filled with correct numbers. Whereas in ver2, you have photo + 8-byte separator + video + full trailer at the end. The important pointers are only in the trailer, the values in google XMP header are filled with nonsense.
I'll try to find some time to add the code to mux ver1 this week for JPGs, as it is clearly more compatible...

Ok but the issue is not about the jpeg, because I've tried other jpeg for example the one taken with iPhone 11 works flawless - only the one with iPhone 14 pro max (attached) doesn't work - we should be able to find the issue and make Live also this picture with the latest motion protocol

The issue is, I do not have any actual MP files in mpv2 format that are JPGs. Yes, they seem to - mostly - work, but all the MP JPGs I could find so far were of the vanilla Google variety. Which is probably good, since it is published Google "standard", whereas my code is reverse engineered by looking at pictures from Samsung phones in binary viewer :-).
I'll first try to update the code to create the pictures more like Galaxy S23, it seems that one is much closer to the vanilla Google implementation (but still does work for HEICs). Hopefully that'll work for JPGs as well :-)

The issue is, I do not have any actual MP files created by camera in mpv2 format that are JPGs. I just extrapolated the HEIF format and it - mostly - worked. But all the MP JPGs I could find so far were of the vanilla Google variety. Which is probably good, since it is published Google "standard", whereas my code is reverse engineered by looking at pictures from Samsung phones in binary viewer :-).
I'll first try to update the code to create the pictures more like Galaxy S23, it seems that one is much closer to the vanilla Google implementation (but still does work for HEICs). Hopefully that'll work for JPGs as well :-)

I actually own a Samsung S20 FE (Non 5G Model) and am willing to go out and take a JPEG Motion photo for you. Additionally it seems like my Samsung Tab S9 has support for Motion Photos 3?
https://www.sammyfans.com/2024/02/24/one-ui-6-1s-improved-motion-photo-feature-coming-for-these-older-samsung-devices/
So I should be able to provide a Jpeg and Heif Motion Photo (V3)
Please let me know if you need me to provide them 😃

Definitely, please :-)
You can push it to my other repository or just upload it here.
In the meantime, I’ve implemented the S23 ver3 format into python code… but it does not help with the iphone 14/15jpgs… The difference was effectively only correct google header and version signature…

Definitely, please :-) You can push it to my other repository or just upload it here. In the meantime, I’ve implemented the S23 ver3 format into python code… but it does not help with the iphone 14/15jpgs… The difference was effectively only correct google header and version signature…

Phew! That took a bit, since I'm very brand new to Github,
But I sent a pull request over https://github.com/PetrVys/MotionPhotoSamples/pulls :)

Thanks, accepted.
Git is very powerful, but a bit intimidating for new users, indeed. Hope you'll find some use for your new superpower :-)

Ok, so the JPG muxing is different from HEIC muxing for the trailer. I'll look into it today...

samsung Galaxy A34 5G, .jpg motion

Thanks, added to the list.
@IamRysing : Can you try the attachment? Hopefully it works like this
IMG_3338.LIVE.ZIP

Thanks, added to the list.
@IamRysing : Can you try the attachment? Hopefully it works like this IMG_3338.LIVE.ZIP

Amazing! It worked on both the Samsung Gallery App and the Google Photos App:
https://github.com/user-attachments/assets/5b4401d9-6e66-4fc0-bb50-8ea4cf69fe0a
https://github.com/user-attachments/assets/6a54a7df-17e3-4dc0-88be-127c5f7e4c5b
I guess all that's left for me is to learn to use the python implementation if you are still intending to abandon the .cmd script 😅
Thank you for the swift fix!
May I ask if this was using MPv2 or MPv3?

closing issue, it seems the new code creates valid JPG motionphotos.


javadocs unavialable

heyy, the javadocs mentioned in the wiki shows 404 error, page not found
can u pls fix it

I think I fixed them all

ok it working now, thank you


How to display NERD Tree fullscreen as opposed to split ?

I have huge directory structure and when NERDTree opens its , the Directory heading is truncated from the left side . Is it possible to show it like /h/p/f/current ? Alternative can I open NERDTree in a new buffer as opposed to having it in a split ?
This looks similar to https://github.com/scrooloose/nerdtree/issues/342

When viewing the NERDTree, pressing A will maximize/minimize the window (experiment to see for yourself). You may also use the standard CTRL-W T to view the tree in a new tab by itself.


CUDA 9 Support

Does the existing codebase work with CUDA 9 as well? On the Titan V GPU we could take advantage of FP16 to further speed up training.

Hi, the CUDA implementation assumes float32 inputs and outputs. Need to re-write the implementation as templates in order to support various float types.

@calclavia
I've been using CUDA 9 (with FP32) and it was fine. Didn't the default pip install work ?
pip install cupy-cuda90

@taolei87 I was trying to use the command given in the README python setup.py install

ah yeah. requirements.txt doesn't include CUDA dependency.
could you try to install CUDA9 and cupy-cuda90 manually?

@taolei87
I performed the following steps:
# 1. Clone the repo
# 2. Change the requirements txt
printf "cupy-cuda91\npynvrtc\n" > requirements.txt
# 3. Install module
python3 setup.py install
``

Then, I open Python interactive terminal and typed `import sru`. Getting this error:

Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/cupy/init.py", line 11, in
from cupy import core  # NOQA
File "/usr/local/lib/python3.5/dist-packages/cupy/core/init.py", line 1, in
from cupy.core import core  # NOQA
ImportError: libcublas.so.9.1: cannot open shared object file: No such file or directory
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.5/dist-packages/sru-0.0.1-py3.5.egg/sru/init.py", line 2, in
from .cuda_functional import *
File "/usr/local/lib/python3.5/dist-packages/sru-0.0.1-py3.5.egg/sru/cuda_functional.py", line 11, in
from cupy.cuda import function
File "/usr/local/lib/python3.5/dist-packages/cupy/init.py", line 32, in
six.reraise(ImportError, ImportError(msg), exc_info[2])
File "/usr/local/lib/python3.5/dist-packages/six.py", line 692, in reraise
raise value.with_traceback(tb)
File "/usr/local/lib/python3.5/dist-packages/cupy/init.py", line 11, in
from cupy import core  # NOQA
File "/usr/local/lib/python3.5/dist-packages/cupy/core/init.py", line 1, in
from cupy.core import core  # NOQA
ImportError: CuPy is not correctly installed.
If you are using wheel distribution (cupy-cudaXX), make sure that the version of CuPy you installed matches with the version of CUDA on your host.
Also, confirm that only one CuPy package is installed:
$ pip freeze
If you are building CuPy from source, please check your environment, uninstall CuPy and reinstall it with:
$ pip install cupy --no-cache-dir -vvvv
Check the Installation Guide for details:
https://docs-cupy.chainer.org/en/latest/install.html
original error: libcublas.so.9.1: cannot open shared object file: No such file or directory

Note that I am able to train regular Pytorch models on CUDA in this environment, so my CUDA installation should be correct.

This seems related to the FAQ (https://docs-cupy.chainer.org/en/stable/install.html)
Does cupy find the CUDA path successfully & correctly ?
libcublas.so.9.1 should lie in a directory of sth like /usr/local/cuda/lib64. Usually there is a symbollink that directs /usr/local/cuda to /usr/local/cuda-9.0

@taolei87 I managed to get it working. Needed to use the runtime image instead of the base image.
Now I'm running into a different error from pynvrtc. "OSError: libnvrtc.so: cannot open shared object file: No such file or directory"
https://github.com/NVIDIA/pynvrtc/issues/3
Seems like pynvrtc does not work with CUDA 9. How did you get it working?

I'm using CUDA 9.0 not 9.1.
The versions I have:
torch.version : 0.3.1
cupy.version : 4.1.0
pynvrtc.version : 8.0

Using cuda 9.1, along with cupy-cuda-91 v4.1.0 , gives still the same
AttributeError: /usr/local/cuda/lib64/libnvrtc.so: undefined symbol: nvrtcAddNameExpression

@taolei87 It's still an issue for CUDA 9.1. It throws a ImportError No module named 'cuda_functional'

I'd like to say that I got a similar error, and hard-coded the source code as follows, and install from source. It works, I hope I am not misleading.
_SRU_PROG = Program(SRU_CODE, 'sru_prog.cu', lib_name='/opt/cuda/10.0/lib64/libnvrtc.so') # for pynvrtc >= 9.0
python setup.py install


Use allocated memory for SHA self tests

Reduce the stack usage of the testing framework by dynamically allocating the memory used for the test.

The reworked version is available in PR #656

This issue has been resolved by pull request #656 which is a revised version of this pull request, so this PR can be closed.


Handle anchorGUID classifications in DE OMAS

This PR includes the following changes:

refactor DE OMAS to use generic PortHandler
update granular endpoints for creating ports/port aliases to use mandatory processQualifiedName
deprecate/delete obsolete client methods - to de discussed at the community call
fixes in generic handler OpenMetadataAPIGenericHandler in order to be able to set the port implementation guid as an anchorGUID for the schema type
fixes in AL OMAS & OLS in order to have lineage when using granular endpoints

@mandy-chessell can you please review changes done in commit cf84ef9df55b90b738be945fda83a2f1e7d936f3 ? It has some fixes in order to be able to set the anchorGUID of a schema type to the port implementation GUID - when using PortHandler.setupPortSchemaType method


added wifi utility for making wifi payload to write into nfc tag

ndef-wifi.js file added
This utility helps to create payload that is makes possible to create payload to write into nfc tag so that the nfc tag becomes wifiporter.
This utility is used just like ndef-text or ndef-uri.
function parameter:
wifiRecord(credentials) gets credentials as parameter. credentials parameter should be object.
credentials: {
    ssid:  String,
    authType: String,
    networkKey: String
}

authType is the type of authentication and can get two types of string parameters: 'WPA' or 'NO'. If the wifi is open then 'NO', if the wifi has networkKey then authKey should be equal to 'WPA'(most common type of network authentication).

To Test this functionality use example/AppNdefWifi.js
TODO:  decoding wifi payload and making readable and processable object so that it can be parsed.
Please feel free to ask any question regarding this functionality.

Hi @deenMuhammad sorry for the late response. This feature is awesome, and I do want to merge them into the library. However the commits in current PR seems to contain several unnecessary changes, can you make another one so it can be merged easier?

I got it!
I will be doing it as soon as possible and make one more PR

This is a great feature. Will the conflicts be resolved soon? Excited to see this become a reality.

Is there any update on adding this feature?

@JGaudette, sorry for late reply. I could not have time to edit the codes and push, but I think you did a great job.
Thank you for making this available!
I appreciate it

Is there any update on when this might be available

Hi @armsteadj1 seems that @JGaudette has created #235, but some modification in ndef-lib/ndef-utils.js still need some check. It's a great feature, I will try to pick it up ASAP.

Thanks @whitedogg13! That would be awesome. Let me know if there is any way i can be useful.

Hi all, I have implemented an draft version for this feature in v2.1.3. Notice currently not all wifi credential fields are supported, only limited to ssid, networkKey and authType (default to WPA2_PSK).
Example looks like this:
import NfcManager, {NfcTech, Ndef} from 'react-native-nfc-manager';
...
let bytes = Ndef.encodeMessage([
  Ndef.wifiSimpleRecord({
    ssid: 'mywifi',
    networkKey: 'Abcdef123',
  }),
]);
await NfcManager.writeNdefMessage(bytes);

I will close this PR for now, thanks @JGaudette and @deenMuhammad for proposing the original version, and welcome for further enhancement!
Thanks!


adding in py 3.5

Codecov Report

Merging #106 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   92.86%   92.85%   -0.02%
==========================================
  Files          16       16
  Lines        1009     1007       -2
  Branches      161      161
==========================================
- Hits          937      935       -2
  Misses         44       44
  Partials       28       28

Flag
Coverage Δ

#unittests
92.85% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

...rd/ml/operator_converters/_tree_implementations.py
97.35% <0.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f0698...1c9bf19. Read the comment docs.

Good catch!

We should do this in pypi as well. It currently shows that one needs Python 3.6+

Yes. Will update this once we push 0.0.2. Setup.py is already correctly showing >= 3.5.

Ah, okay! Didn't realize that. Thanks..


Divide cpu bandwidth limit equally among VM's vCPU threads

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Unable to start Rasa pointing to empty S3 model storage

Rasa version:
1.10.3
Operating system (windows, osx, ...):
Official Docker Image
Issue:
Unable to start Rasa pointing to empty S3 model storage (Minio is used as s3-compatible storage)
Error (including full traceback):
rasa_1      | botocore.exceptions.ClientError: An error occurred (404) when calling the HeadObject operation: Not Found
rasa_1      | Traceback (most recent call last):
rasa_1      |   File "/opt/venv/bin/rasa", line 8, in <module>
rasa_1      |     sys.exit(main())
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/__main__.py", line 108, in main
rasa_1      |     cmdline_arguments.func(cmdline_arguments)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/cli/run.py", line 83, in run
rasa_1      |     rasa.run(**vars(args))
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/run.py", line 56, in run
rasa_1      |     **kwargs,
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/core/run.py", line 216, in serve_application
rasa_1      |     endpoints.lock_store if endpoints else None
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/sanic/app.py", line 1167, in run
rasa_1      |     serve(**server_settings)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 892, in serve
rasa_1      |     trigger_events(before_start, loop)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/sanic/server.py", line 668, in trigger_events
rasa_1      |     loop.run_until_complete(result)
rasa_1      |   File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/core/run.py", line 257, in load_agent_on_start
rasa_1      |     action_endpoint=endpoints.action,
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/core/agent.py", line 259, in load_agent
rasa_1      |     model_server=model_server,
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/core/agent.py", line 916, in load_from_remote_storage
rasa_1      |     persistor.retrieve(model_name, target_path)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/nlu/persistor.py", line 55, in retrieve
rasa_1      |     self._retrieve_tar(tar_name)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/rasa/nlu/persistor.py", line 170, in _retrieve_tar
rasa_1      |     self.bucket.download_fileobj(model_path, f)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/boto3/s3/inject.py", line 720, in bucket_download_fileobj
rasa_1      |     Callback=Callback, Config=Config)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/boto3/s3/inject.py", line 678, in download_fileobj
rasa_1      |     return future.result()
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/s3transfer/futures.py", line 106, in result
rasa_1      |     return self._coordinator.result()
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/s3transfer/futures.py", line 265, in result
rasa_1      |     raise self._exception
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/s3transfer/tasks.py", line 255, in _main
rasa_1      |     self._submit(transfer_future=transfer_future, **kwargs)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/s3transfer/download.py", line 343, in _submit
rasa_1      |     **transfer_future.meta.call_args.extra_args
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/botocore/client.py", line 316, in _api_call
rasa_1      |     return self._make_api_call(operation_name, kwargs)
rasa_1      |   File "/opt/venv/lib/python3.7/site-packages/botocore/client.py", line 635, in _make_api_call
rasa_1      |     raise error_class(parsed_response, operation_name)
rasa_1      | botocore.exceptions.ClientError: An error occurred (404) when calling the HeadObject operation: Not Found

Command or request that led to error:
docker-compose up

Content of docker-compose.yaml file:
version: '3.0'

services:
  rasa:
    image: rasa/rasa:latest-full
    networks: ['rasa-network']
    ports:
    - "5005:5005"
    volumes:
    - "./rasa-app-data/:/app/"
    environment:
    - AWS_SECRET_ACCESS_KEY=minioadmin
    - AWS_ACCESS_KEY_ID=minioadmin
    - AWS_DEFAULT_REGION=us-east-1
    - AWS_ENDPOINT_URL=http://minio:9000
    - BUCKET_NAME=test
    command: ['run','--enable-api', '--remote-storage', 'aws']

  duckling:
    image: rasa/duckling:latest
    networks: ['rasa-network']
    ports:
    - "8000:8000"

  minio:
    image: minio/minio
    networks: ['rasa-network']
    ports:
    - "9000:9000"
    command: ['server', '/data']
    volumes:
    - "./rasa-model-data/:/data/"

networks: {rasa-network: {}}

Thanks for raising this issue, @b-quachtran will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Hi Andrei, Rasa isn't able to run without a model file. Is there a way you can upload a placeholder model file in S3 before deploying the image?

@b-quachtran hey, thank you for the response! Actually, i would expect it to be running the same way as it does while local filesystem is used as model storage.

@avarabyeu Ah yes, this appears to be an exception. Thanks for raising this! Our product team will review when they get a chance.

@avarabyeu What is the placeholder model you are referring to?  I think this is no different from local mode.  You need to train the model before you do the rasa run command.
You would typically have a CI/CD process to train the model and push it to S3 before starting the container.
If you're running in a Kubernetes environment, you can use and init container and with Docker you can use the the multi-stage build.
I don't think this is a Rasa bug.

@rgstephens unfortunately, my use case does not give me a chance to build ci/cd over this. At the moment of container creation i don't have a model to be trained so init container/multi-stage do not work. My rasa instance is supposed to be trained over Rasa HTTP API. So, rasa starts without model provided. It works perfectly fine if i define local storage, but i receive the error above is storage is set to S3.

While testing, I also found a related issues:

If you specify --remote-storage AWS the option is ignored without warning you that AWS is invalid (must be aws).

The -m option is required when using --remote-storage

Assuming there is a model in S3 but nothing locally:
If there is no local models directory, you get the following error:
The path 'models' does not exist. Please make sure to use the default location ('models') or specify it with '--model'.

If you have a model directory with no contents:
No model found. Train a model before running the server using `rasa train`.

is this issue fixed, as i am also facing the same error


Bump Cucumber to version 7.11.1

Upgrade Cucumber Version to 7.11.1

Codecov Report

Merging #145 (3471fde) into main (ab1610e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #145      +/-   ##
============================================
+ Coverage     86.18%   86.22%   +0.03%
  Complexity       35       35
============================================
  Files            32       32
  Lines          2614     2614
  Branches        282      282
============================================
+ Hits           2253     2254       +1
+ Misses          244      243       -1
  Partials        117      117

Impacted Files
Coverage Δ

...java/com/decathlon/tzatziki/steps/ObjectSteps.java
84.84% <100.00%> (ø)

...a/com/decathlon/tzatziki/steps/SpringJPASteps.java
78.41% <0.00%> (-0.72%)
:arrow_down:

...com/decathlon/tzatziki/kafka/KafkaInterceptor.java
89.69% <0.00%> (+1.03%)
:arrow_up:

.../main/java/com/decathlon/tzatziki/utils/Types.java
63.82% <0.00%> (+2.12%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


TES CLI: cancel fails on tasks with "SYSTEM ERROR" status

The current implementation doesn't handle the cancel of task with "SYSTEM ERROR" status in cli/src/main.rs.

Would be good to add more details here (steps to reproduce, error logs etc). In particular, it is not clear whether this is a TES implementation issue or a GA4GH-SDK issue. If the latter, this may be a design issue, because (unless I'm missing something), the SDK should never set the status of a task itself, but rather take it from a call to GET /tasks/{id}.


Fix compare of negative numbers in Numeric type

I didn't invert the comparison when comparing 2 negative numeric.

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/compiler

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3154/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3154/


Adding records to tables with data

I need to create a migration. It adds some columns to tables, no problems with this.
But I also need to add records as seed data to the tables which already contains data. The issue is that I can't add records with a fixed Id, they may be already used.
How to add seed data in such a case?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc418ab9-0592-f610-e751-40cb501220da
Version Independent ID: 822e8923-2647-f573-0c74-66af903776d8
Content: Data Seeding - EF Core
Content Source: entity-framework/core/modeling/data-seeding.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @AndriySvyryd
Microsoft Alias: ansvyryd

@sergtk What type is your id column? If it's int you can use a negative value. Otherwise you'll have to add the data through the context normally and once the id is known add it to the model and then edit the migration to remove the inserts.

I use the following definition for the entity property in C#:
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public long Id { get; set; }

To use negative int-s for id is like a hack, but I am looking for a clean approach. I mean autogenerated value for keys as usual.

once the id is known add it to the model and then edit the migration to remove the inserts.

Ids are never known during development. This is because I test on test db, but in production can be anything else.
Note, this is a quite usual use case, so that is why I ask if there is something suitable in EF Core I missed.
AFAIK you provide me to hardcode ids in migrations?
If so, this is not a solution I am looking for.
Thank you.


Please add this adapter to the repository

It would be really greate to see this adapter on ioBroker. Please add it to the repository. You can see how to do this here: https://github.com/ioBroker/ioBroker.repositories#add-a-new-adapter-to-the-latest-repository
Thanks for it :-)

You're welcome - but it is still an development version.... do you it is worth publishing in latest repo right now?
Good point would be possible help/ideas/testing etc....

I have a wallbox, but I'm still waiting for my PV. You can create a thread for testing here https://forum.iobroker.net/category/91/tester - I think a lot of users would be very happy with such an adapter. Me too, but I mus to wait till my PV is installed :-)

OK... pull request for registering the adapter is filed

pull request cancelled I need to pull another adapter first....
"chargemaster": {
"meta": "https://raw.githubusercontent.com/hombach/ioBroker.chargemaster/master/io-package.json",
"icon": "https://raw.githubusercontent.com/hombach/ioBroker.chargemaster/master/admin/chargemaster.png",
"type": "vehicle"
},

filed new PR

adapter is part of "latest" repo


Updating to Swift 5, adding entitlements file

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much for the contribution!


Adding 'advanced-feature-usage' metric to telemeter configuration

Signed-off-by: Arun Kumar Mohan<EMAIL_ADDRESS>

@aruniiird you might need to run make manifests locally and committing new changes, the change needs to be propagated to our YAML file as well.

I'm not seeing any changes on make manifests. I think there's some additional targets that need to be run here. 🤔
┌[rexagod@nebuchadnezzar] [/dev/pts/0] [a]
└[~/repositories/configuration]> make manifests
>>>>> Running format
/home/rexagod/go/bin//jsonnetfmt-v0.18.0 -n 2 --max-blank-lines 2 --string-style s --comment-style s -i ./configuration/observatorium/metric-federation-rules.libsonnet ./configuration/observatorium/queries.libsonnet ./configuration/observatorium/ruler-remote-write.libsonnet ./configuration/observatorium/tenants.libsonnet ./observability/config.libsonnet ./observability/dashboards/observatorium-api.libsonnet ./observability/dashboards/telemeter-canary.libsonnet ./observability/dashboards/telemeter.libsonnet ./observability/dashboards/observatorium-api-logs.libsonnet ./observability/dashboards/slo.libsonnet ./observability/grafana.jsonnet ./observability/observatorium-logs/loki-tenant-alerts.libsonnet ./observability/observatorium-logs/loki-overview.libsonnet ./observability/grafana-obs-logs.jsonnet ./observability/prometheusrules.jsonnet ./services/components/jaeger-collector.libsonnet ./services/components/loki-caches.libsonnet ./services/dex-template.jsonnet ./services/jaeger-template.jsonnet ./services/metric-federation-rule-template.jsonnet ./services/minio-template.jsonnet ./services/observatorium-traces-subscriptions-template.jsonnet ./services/observatorium-traces-subscriptions.libsonnet ./services/prometheus/remote-write-proxy.libsonnet ./services/sidecars/jaeger-agent.libsonnet ./services/sidecars/oauth-proxy.libsonnet ./services/sidecars/opa-ams.libsonnet ./services/sidecars/thanos-rule-syncer.libsonnet ./services/telemeter-template.jsonnet ./services/telemeter.libsonnet ./services/observatorium-logs-template-overwrites.libsonnet ./services/observatorium-logs-template.jsonnet ./services/observatorium-logs.libsonnet ./services/observatorium-tenants-template.jsonnet ./services/observatorium-traces-template.jsonnet ./services/observatorium-traces.libsonnet ./services/observatorium-metrics-template-overwrites.libsonnet ./services/observatorium-metrics-template.jsonnet ./services/parca-template.jsonnet ./services/observatorium-metrics.libsonnet ./services/observatorium-template.jsonnet ./services/observatorium.libsonnet
make clean
make[1]: Entering directory '/home/rexagod/repositories/configuration'
find resources/services -type f ! -name '*.yaml' -delete
find resources/observability/prometheusrules -type f ! -name '*.yaml' -delete
find resources/observability/grafana/observatorium -type f ! -name '*.yaml' -delete
find resources/observability/grafana/observatorium-logs -type f ! -name '*.yaml' -delete
find resources/services/telemeter-template.yaml -type f ! -name '*.yaml' -delete
make[1]: Leaving directory '/home/rexagod/repositories/configuration'
┌[rexagod@nebuchadnezzar] [/dev/pts/0] [a]
└[~/repositories/configuration]> gss
┌[rexagod@nebuchadnezzar] [/dev/pts/0] [a]
└[~/repositories/configuration]> gd aruniiird/add-advance-feature-metric-to-telemetri-server

Same thing on make clean && make all.

Doing an rm resources/services/telemeter-template.yaml && make manifests && make all seems to work.

@matej-g I've seem this happen quite often, where we have to manually remove the telemeter template and then run make manifest && make all for the diff to be consistent.
Should this be added to the manifest target?

Thanks @matej-g , @rexagod ...
I've ran make manifests target and submitted the changes.
One thing noticed is, all the contents in file : resources/services/metric-federation-rule-template.yaml is now cleaned out and null is added to that file. Let me know if I missed something.

@aruniiird Just curious, did the make manifest command work for you on the first go, or did you have to remove the file first?

About the file metric-federation-rule-template.yaml being null, that was an issue on getting the raw manifest file from cluster-monitoring-operator repo (https://raw.githubusercontent.com/openshift/cluster-monitoring-operator/master/manifests/0000_50_cluster-monitoring-operator_04-config.yaml). Fixed it.

@aruniiird Just curious, did the make manifest command work for you on the first go, or did you have to remove the file first?

@rexagod , I had to remove the file manually and then run the make manifests to get correct result

@matej-g , can you please take a look...

@aruniiird @rexagod Thanks, this looks good now. I tried it now and you're right, this seemed to have been problem previously where we had to remove generated manifests for targets to work properly. I'll take a look. Sorry for the inconvenience!


Picard cpu usage

Picard/java may gobble up more CPUs than allotted. From the picard FAQ (why does picard use so many threads?  http://broadinstitute.github.io/picard/faq.html), it says that java GC is to blame, and furthermore that picard uses -XX:ParallelGCThreads=<num of threads> to limit the number of threads.  This parameter can be passed to picard in the Nextflow script sections as -XX:ParallelGCThreads=${task.cpus}.
This may actually not be the definitive solution, see e.g. https://github.com/broadinstitute/picard/issues/488
My case was a NF process under LSF, allotted 4 CPUS. It was automatically suspended because it used 11 CPUS. This process used markDuplicates. A few picard modes accept a NUM_PROCESSORS option, but not so markDuplicates.

In case you use Docker, one workaround might be to limit the CPU resources of docker using --cpus=<value> (https://docs.docker.com/config/containers/resource_constraints/#cpu)

Apparently its not really effective to change that option: https://github.com/broadinstitute/picard/issues/1223

If that happens again - please re-open, as these changes are not 100% sure to fix the issue.


Add pumped of sing by me

Song Name
pumped of sing
Artist Name
me
Source
Youtube
Youtube Link
Hz9Bx2dVxlcG4TkF
Direct File Link
No response
Song ID
627121
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 48353992

reject
invalid yt link


Refine docker network configuration

The current process for deploying currently requires some complicated steps revolving around setting up networks. Things in docker are more streamlined now compared to when this project started, so some of the more complicated steps can be smoothed out. For example, the following in one of the deployment scripts can be pushed out to the docker-compose file:
    docker_dev_init_swarm_network ${DOCKER_REQUESTS_NET_NAME:=requests-net} \
            ${DOCKER_REQUESTS_NET_SUBNET:?Cannot init ${DOCKER_REQUESTS_NET_NAME} network without configured subnet} \
            ${DOCKER_REQUESTS_NET_GATEWAY:?Cannot init ${DOCKER_REQUESTS_NET_NAME} network without configured gateway} \
            ${DOCKER_REQUESTS_NET_DRIVER:-overlay}

to:
network:
    requests-net:
        attachable: true
        ipam:
            driver: overlay
            config:
                subnet: ${DOCKER_REQUESTS_NET_SUBNET}
                gateway: ${DOCKER_REQUESTS_NET_GATEWAY}

(just an example - the 'real' solution would still need to be worked out)
The subnet and gateway definitions may no longer be needed. This change will cut down on some extra environment variables and scripts, making the project easier to maintain.

I'm afk, so I'll check when I get home, but I'm fairly sure that's only applicable to non-docker swarm containers. There is and has been a divide between docker compose and docker swarm and docker swarm does not work seamlessly with docker compose. I'm fairly certain you need to create the networks via the docker swarm api. Fingers crossed I'm wrong.

Revisiting this, there are several issues as to why this does not work in our context. The main and most important being that the docker compose spec does not provide a way to specify the scope of a given network. See here the struct that a network is marshaled into. Why is this an issue to begin with? For mpi related reasons, we use a macvlan network driver for the mpi-net. @robertbartel can elaborate on this if we need to, I don't know all the details off the top of my head without doing some more digging. To use a macvlan driver in a docker swarm context, you must tell the docker network api that you want the network to be swarm scoped. However, using just docker compose you cant do that. Ive found a few github issues related to this and the general consensus is to just use the overlay network driver which is swarm scoped by default, however as mentioned, we use the macvlan driver for the mpi-net which is not swarm scoped by default.
Another potential issue is network persistence. There is not a straightforward way to just create the networks needed for our deployment and have them live longer than the services themselves. Meaning, you would need to recreate the docker networks each time you redeploy or at least be very careful that you don't destroy the networks when you are doing a service upgrade for example.

Still looking through details, but:

The main and most important being that the docker compose spec does not provide a way to specify the scope of a given network.

I believe overlay networks (which we have to use) are swarm scoped by default, so that saves our asses in this circumstance.
I'm looking through some of the macvlan stuff. Luckily, only one network is set up for that and we're using three or four of them.

Yeah, ideally we could have a separate docker compose file that just creates the networks. Im not sure if that is possible though. I tried to do that with deployx and it did not work. I need to see if I can do the same in a non-docker swarm context just to compare behavior. That should be pretty easy for me to add into deployx.

Moby, the open source go library for docker (once was the official api and still pretty much is before docker went more corporate), has some good documentation on the [macvlan](https://github.com/moby/moby/blob/484480f56aa38053493e100dbd1c25da0c831df6/libnetwork/docs/macvlan.md?plain=1#L2] driver that we might look to. At a quick glance, it seems like macvlan would let you integrate with the underlying network and is likely much faster provided you have a fast network switch and appropriate network topology that the overlay driver.

Thanks for the link - wasn't easy to find.


updating readme to reflect new doc updates

to: @austinbyers
cc: @airbnb/streamalert-maintainers
size: small
Changes

Updating readme to reflect new doc updates
Removing IDE specific git ignores that should be included in user's global gitignore file, not per-project.

Coverage remained the same at 96.961% when pulling 6f14ad681eabae1b116383834756e0331267d15a on ryandeivert-update-readme into f200eaba989d6af2979d03051edd9b8495561088 on master.


Seeing an increased number of 521 error responses

Example request: https://api.trakt.tv/movies/trending?genres=superhero&page=1&limit=200&ratings=61-100
Is this an ongoing performance issue?

Seeing this as well. We should be seeing 429 for rate limiting right?

Yes I can confirm this too

Lately I'm seeing this as well. Cloudflare 521's and 502's are appearing quite often.

Seeing this too :(

More info here:
https://blog.trakt.tv/trakt-performance-upgrades-c82f5db61f52


Update eslint-plugin-react: 7.22.0 → 7.26.0 (minor)

Any reason why this would be important? There is a bunch of dependencies that could use some updating but singling them out into their own merge requests is a highly inefficient way to go about it. Not to mention the renderer module as the only part of BD that uses the plugin has it's own package.json and it's own version of eslint-plugin-react. This means your merge request doesn't actually do anything of value.

well why leave my PR still open? if it's just to say that and do nothing I don't see the interest lmfao

Because that person does not have the ability to close PRs.


client can hang forever

I have stepped on a situation in which a client can hang forever.
my HTTP client, is susceptible to getting blocked-forever, if the 3rd party server has buggy code, such as one written below.
require('http').createServer(
    function (req, rsp)
    {
         console.log("rcvd request from client");
         rsp.writeHead(200, {"Content-Type": "text/plain"});
         rsp.write("Hello World 1");       /* server to send a data chunk */
         // rsp.end("Hello World 2\n");   /* server not to 'end' the response */
    }
).listen(24680);

the fix is trivial, in the Requestify.js
   ...

   httpRequest = http.request(options, function(res) {
          // clearTimeout(timeout);  // Fix-1: move this to Fix-2, while handling 'end' event.
          var response = new Response(res.statusCode, res.headers);

          res.setEncoding(responseEncoding);
          res.on('data', function(chunk) {
              response.setChunk(chunk);
          });

          res.on('end', function() {
              clearTimeout(timeout);  // Fix-2: this is when the timer should be cleared
              if (isSuccessful(response.code)) {
                  storeCache(request.getFullUrl(), response.getCode(), response.getHeaders(), response.body, request.cache);
                  defer.resolve(response);
                  return;
              }

              defer.reject(response);
          });
      });

...

I have placed a pull request for this. Please consider accepting it.


Implement JsonbTypeAdapters for custom json mapping

Blocked until this is fixed by quarkus. See quarkusio/quarkus#1491

This is affecting me too. Any idea on the ETA?


Add matrix access tracking to ControlFlowGraphVisitor

The ControlFlowGraphVisitor currently uses a std::vector<std::string> to store the variable that are accessed (read or written). This, however, is not enough as there might exists multiple variables with the same identifier but declared in different scopes. See #13 that addresses this issue.
In addition to the missing scope support, it would be useful to allow tracking of matrix accesses. As a current and very rudimentary workaround, a string like "Variable(M)[LiteralInt(21)][LiteralInt(3)]" is constructed and used. As we cannot generally assume that indices are always known, it would probably better to store the whole MatrixElementRef element.

I'm assuming this is now dealt with differently in the CFGV since we've introduced the Target class?


tests/pgsql: add checks and test for bug 6092 - v1

Ensure that pgsql metadata flags (for now, just setting whether passwords should be logged or not) are properly processed by Suri and logging functions.
Related to
Bug #6092
Updated existing tests where there could be logged a password message, but we disable that in the configuration. Add two tests specifically to test this when passwords enabled or disabled.
The Suri PR doesn't change the output behavior, just ensures that we pass pgsql config flags as metadata, therefore, these tests should pass with master, too.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6092

Merged in #1771, thanks!


Cannot read property 'some' of undefined

Hi, i follow this instruction for using react-app-rewired and ant design and create-react-app but after i changed script section of package.json and then run the npm start i get this error :

that say cant not read property 'some' of undefined, i check the source and i think it maybe cant load babel plugin so i try to re install the babel-plugin-import but the error still happend.

What version of react scripts are you running?

my react script version in package.json is "react-scripts": "0.9.5"

@MBehtemam it's too old. It still uses Webpack 1. Please update to the latest create-react-app (so react scripts) and then it will work fine.

after updating the create-react-app and react scripts everything work well . thanks.


Chaining custom importers

In npm there are basically now the node-sass-custom-importer and node-sass-import-once.
For example node-sass-import-once comes with extra functionality,
some functionality of both importers intersect or are slightly different.
Wouldn't it make sense to allow chaining custom importers,
where each got its own dedicated purpose?
Like first node-sass-import-once for importing once (and doing that well)
and then node-sass-custom-importer for the custom paths.
With best regards

This has come up before. Unfortunately chaining of importers doesn't make
sense. The fundamental rule of importers is that an import can only match a
single importer. Chaining breaks this model.
The right way to do what you suggest would be for importer authors to write
modules in such a way that the core logic can be required and used by other
importers.
On 16 Nov 2015 10:23 am, "strarsis"<EMAIL_ADDRESS>wrote:

In npm there are basically now the node-sass-custom-importer
https://github.com/danderu/node-sass-custom-importer and
node-sass-import-once https://github.com/at-import/node-sass-import-once
.
For example node-sass-import-once comes with extra functionality, some
functionality of both importers intersect or are slightly different.
Wouldn't it make sense to allow chaining custom importers,
where each got its own dedicated purpose?
Like first node-sass-import-once for importing once (and doing that well)
and then node-sass-custom-importer for the custom paths.
With best regards
—
Reply to this email directly or view it on GitHub
https://github.com/sass/node-sass/issues/1271.


Ignore Mac-specific versions of vendored gems

Assuming that our dev machines are Macs and production ones are Linux

Looks good to me:
$ git pull
...
Fast-forward
 .../cache/libv8-node-<IP_ADDRESS>-x86_64-darwin-18.gem  | Bin 27346944 -> 0 bytes
 .../cache/libv8-node-<IP_ADDRESS>-x86_64-darwin-20.gem  | Bin 27346944 -> 0 bytes
 vendor/cache/nokogiri-1.12.5-x86_64-darwin.gem       | Bin 6883328 -> 0 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 vendor/cache/libv8-node-<IP_ADDRESS>-x86_64-darwin-18.gem
 delete mode 100644 vendor/cache/libv8-node-<IP_ADDRESS>-x86_64-darwin-20.gem
 delete mode 100644 vendor/cache/nokogiri-1.12.5-x86_64-darwin.gem


Remove actions dependencies check

Pull Request Test Coverage Report for Build 872625852

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.794%

Totals

Change from base Build 872620229:
0.0%

Covered Lines:
191

Relevant Lines:
252

💛  - Coveralls


Godot chrashes with FATAL: Index p_index = 1 is out of bounds (size() = 0). when launching editor.

Godot version
v4.0.3.stable.flathub
System information
Rhino linux (Based on ubuntu)
Issue description
The editor chrashes when launching with the following error (Empty project):
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.3.stable.flathub (5222a99f5d38cd5346254cefed8f65315bca4fcb)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
ERROR: FATAL: Index p_index = 1 is out of bounds (size() = 0).
   at: get (./core/templates/cowdata.h:155)

================================================================
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v4.0.3.stable.flathub (5222a99f5d38cd5346254cefed8f65315bca4fcb)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
ERROR: FATAL: Index p_index = 1 is out of bounds (size() = 0).
   at: get (./core/templates/cowdata.h:155)

I expected it to not crash.
I am using the sway windowmanager.
Steps to reproduce

Download the 4.0.3 flatpak version of Godot.
Launch it in swaywm
Choose a game to edit that has graphics higher than the compatibility setting.
Editor crashes

It does not crash with the compatibility graphics.
Minimal reproduction project
N/A

Choose a game to edit that has graphics higher than the compatibility setting.

What graphics card model do you have, and how recent are your graphics drivers?

I currently do not have acces to the device i got thet error on but i know i have a rather old gpu so that is probably the case.

This is a duplicate of https://github.com/godotengine/godot/issues/58927, closing.


style(specialization): increase vertical spacing

talents in specializations are now spaced vertically further apart
this change has been made for all talent-upgrade CSS classes
changes made for both themes

#1054

The linked issue has an image, if you want a preview of the delta.


Ignore whitespace in full names when matching in @-mention autocomplete

query "vaibhavsinghal" should match user with full name "Vaibhav Singhal", even if the above query is not a part of the user's emailid i.e. white space in "Vaibhav Singhal" should be ignored in @-mention autocomplete matching.
This is needed because there is a possibility that more than 5 users have same initial name, hence the desired person's name can be left out of the results which can be annoying.

This would be a big improvement for larger organizations.

We should do the same for #streamName mentions as well.

@timabbott It would be helpful if you could tell me in which file should i look into.

Likely static/js/composebox_typeahead.js

Resolved via https://github.com/zulip/zulip/commit/f14e2de9854d9dbdfb853fa8bbcae1dcbbb25b27.


[Event Request] Table 290 - UpdateLines

I need on table 290 on functions:
procedure UpdateLines
"VAT Calculation Type"::"Sales Tax":
begin
"Amount Including VAT" := CalcLineAmount;
if "Use Tax" then
"VAT Base" := "Amount Including VAT"
else
"VAT Base" :=
Round(
SalesTaxCalculate.ReverseCalculateTax(
TaxAreaCode, "Tax Group Code", TaxLiable, PostingDate,
"Amount Including VAT", Quantity, CurrencyFactor),Currency.
"Amount Rounding Precision");
OnAfterSalesTaxCalculateReverseCalculateTax(TaxAreaCode, TaxLiable, PostingDate, CurrencyFactor, Rec, Currency); // I need the parameters "TaxAreaCode", "TaxLiable", "PostingDate", "CurrencyFactor"
"VAT Amount" := "VAT Difference" + "Amount Including VAT" - "VAT Base";
if "VAT Base" = 0 then
"VAT %" := 0
else
"VAT %" := Round(100 * "VAT Amount" / "VAT Base", 0.00001);
end;
end
[IntegrationEvent(false, false)]
local procedure OnAfterSalesTaxCalculateReverseCalculateTax(TaxAreaCode: Code[20]; TaxLiable: Boolean; PostingDate: Date; CurrencyFactor: Decimal; var VATAmountLine: Record "VAT Amount Line"; Currency: Record Currency)
begin
end;

"VAT Calculation Type"::"Sales Tax":
begin
"VAT Base" := CalcLineAmount;
if "Use Tax" then
"VAT Amount" := 0
else
"VAT Amount" :=
SalesTaxCalculate.CalculateTax(
TaxAreaCode, "Tax Group Code", TaxLiable, PostingDate, "VAT Base",
Quantity, CurrencyFactor);
OnAfterSalesTaxCalculateCalculateTax(TaxAreaCode, TaxLiable, PostingDate, CurrencyFactor, Rec, Currency);// I need the parameters "TaxAreaCode", "TaxLiable", "PostingDate", "CurrencyFactor"
if "VAT Base" = 0 then
"VAT %" := 0
else
"VAT %" := Round(100 * "VAT Amount" / "VAT Base", 0.00001);
"VAT Amount" :=
"VAT Difference" +
Round("VAT Amount", Currency."Amount Rounding Precision",
Currency.VATRoundingDirection);
"Amount Including VAT" := "VAT Base" + "VAT Amount";
end;
end;
[IntegrationEvent(false, false)]
local procedure OnAfterSalesTaxCalculateCalculateTax(TaxAreaCode: Code[20];  TaxLiable: Boolean; PostingDate: Date; CurrencyFactor: Decimal; var VATAmountLine: Record "VAT Amount Line"; Currency: Record Currency)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Change request handling to use split instead of regular expressions.

The regular expression fails with a stack overflow for paths of
more than 135 characters. The split also appears to be much faster.
Failing parse:
>>> import re
>>> _REQUEST_RE = re.compile(r"(\S+)\s+(\S+)\s")
>>> _REQUEST_RE.match("GET /" + ("a" * 135) + " whatev")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: maximum recursion depth exceeded

Co-authored-by: Shae Erisson<EMAIL_ADDRESS>

I don't get the stack overflow error, testing on a random board (nrRF 52840). What board are you testing this on?

I don't get the stack overflow error, testing on a random board (nrRF 52840). What board are you testing this on?

Same thing on a MagTag with CircuitPython 7.2.5
Adafruit CircuitPython 7.2.5 on 2022-04-06; Adafruit MagTag with ESP32S2
>>> import re
>>> _REQUEST_RE = re.compile(r"(\S+)\s+(\S+)\s")
>>> _REQUEST_RE.match("GET /" + ("a" * 135) + " whatev")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: maximum recursion depth exceeded
>>> _REQUEST_RE.match("GET /" + ("a" * 134) + " whatev")
<match num=3>


Create RepositoryBadge

Not sure if these fields are the best option - just an idea

@benediktvaldez, it could be nice to use (icons)[https://fortawesome.github.io/Font-Awesome/icons/] for each fields

We could add an icon in the header to, using github icon and fork icon if the repo is a forked one

I'll add fork count to

Wow, great feedback @plouc - I'll work on these and update this branch


[Bug Report] Crash with EDGE when user select el-select many times

Element UI version
2.4.1
OS/Browsers version
W10 64bit / Microsoft Edge 42.17134.1.0
Vue version
2.5.17-beta.0
Reproduction Link
https://jsfiddle.net/mmx38qxw/2286/
Steps to reproduce

open element release page (http://element.eleme.io/#/en-US/component/select ) with Edge
try to select el-select box many times
As you see the below link, you can see edge was killed
https://drive.google.com/file/d/1rbh_78DAPJBo2eoEqip3H2iERM0xE3nw/view?usp=sharing

What is Expected?
it is working well.
What is actually happening?
Edge was killed
I tried to this issue with chrome, however it does not reproduce.

Couldn't reproduce on my edge

Is this related to the operating system language?

@liuhuaxia 系统版本以及浏览器版本？

@win10，企业版edge浏览器，IE11是正常的官网select频繁点几下就会卡死 @ziyoung

Microsoft Edge 42.17134.1.0 @ziyoung

CSS关闭动画就可以了

I could reproduce this issue

My workaround:
<template>
    <el-select
        @visible-change="visibleChange"
        ...
    >
        /// options
    </el-select>
</template>

<script>
    export default {
        methods: {
            visibleChange(isVisible) {
                const isEdge = window.navigator.userAgent.includes('Edge');
                if (isEdge && !isVisible) {
                    document
                        .querySelectorAll('body > .el-select-dropdown.el-popper')
                        .forEach((it) => it.remove());
                }
            },
        },
    }
</script>

Yeah, this reproduced on my home computer with win10 and latest edge. This seems to be a strange bug that affects some systems/edges and not others.
The above workaround, if it works, is a bit wieldy to implement everywhere. Should be fixed within element.

Any update on this bug.
The issue exists on the element UI documentation page as well.
If you click on the select component a few times the page crashes in Edge.
element-ui-edge-bug.zip

Any update on this bug.
nope.

But thankfully edge will eventually move to chromium under the hood so this will eventually get resolved. Just as planned.

CSS关闭动画可以的，我是这么做的
.el-zoom-in-bottom-enter-active,.el-zoom-in-bottom-leave-active,.el-zoom-in-left-enter-active,.el-zoom-in-left-leave-active,.el-zoom-in-top-enter-active,.el-zoom-in-top-leave-active
{
  transition: none !important;
  -webkit-transition: none !important;
  -moz-transition: none !important;
  -ms-transition: none !important;
  -o-transition: none !important;
}

has this bug fixed？anyone knows？


Plans for supporting Fluent 2?

Describe the solution you'd like
I love how the new Fluent 2 looks and it would be great to see it in action in Flutter as well. Are there any plans on upgrading this to support Fluent 2?
Additional context
Official Fluent2 website

Hello! The link you mentioned links to the "Web React" version of fluent_ui.
The main goal of this project is to replicate Win UI, which is described under the link below:

https://fluent2.microsoft.design/components/windows

I think this is a duplicate of #907


Have responsive variation in template demo page

Feature Request

[x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.

[x] I’ve read and agree to the Code of Conduct.

[x] I’ve searched for any related issues and avoided creating a duplicate issue.

[ ] have tablet, mobile and desktop view

I would like to see this implemented. For MVP however I don't think it is necessary.
It would be great to move the a11y toggles and maybe device widths into a different section ( or above the template ).


Windows 11 support?

Greetings! Much thanks for your project! Is the current version of Scream (3.9) supported by Windows 11? And if not, will you make a version that is supported?

It should work fine, I just didn't update the README yet. If it does not work, report back here and I'll take a look.

It should work fine, I just didn't update the README yet. If it does not work, report back here and I'll take a look.

According to my acquaitance who tried installing Scream on Windows 11, not only it doesn't work, it breaks Windows completely:

All audio devices are vanished
Unable to open any folder in Windows explorer
Unable to launch most apps

And the scariest part is, not even Windows recovery was able to remedy the conequences. She had formatted her disk and did a clean installation of Windows 10.
I asked her to register here so maybe she'll provide more input. But after her experience I'm very hesitant to install it, I also have Windows 11.

I've just installed Scream on Windows 11. It works perfect, except the latency - maybe it is caused by the receiver? I need to figure out...

I've just installed Scream on Windows 11. It works perfect, except the latency - maybe it is caused by the receiver? I need to figure out...

That's great news, at least it works! I'll appreciate if you do look up into that latency issue!

@ElixBerd This is just my guess, the latency is might caused by the poor network connection.
My receiver (Raspberry Pi 3B+) is connected to the network with Wi-Fi, I found there is a huge and unstable (3ms at least and 50ms highest) latency when I ping it from my Windows PC. Use a wired connection may be better (usually the latency of a wired connection should be around 1ms and much stabler). The poor network connection also caused cranky sounds when sample rate or bitrate is high, I think it is because the network adapter cannot handle such a huge data stream.
Also the Bluetooth connection with my receiver and headset (Sony WH-1000XM3) might cause a bigger latency. I use LDAC codec to get the best sound quality, but as articles I found from Google says, the latency of LDAC could be 200~500ms - which met my situation.

@tnqzh123 thank you very much! I'll try installing Scream on Windows 11 myself and with my final feedback will close the issue!


12 - Split 'Showcase' App from Unit Tests Project

 12 - Split 'Showcase' App from Unit Tests Project