Support multiple scala versions

In the pom.xml file,
the dependency to scala-java8-compat is explicitly set to scala-java8-compat_2.11 which makes this library dependent on scala 2.11 even if Spark is set as provided in that same file.
I see 3 options:
Option 1: Do not use scala-java8-compat
What's the alternative then ?
Option 2: set scala version in the dependency name
Replace  <artifactId>scala-java8-compat_2.11</artifactId> by <artifactId>scala-java8-compat_${scala.version.short}</artifactId> and set it as provided, requiring the user to add the dependency to the right (scala) version of scala-java8-compat
I currently recompile your code locally with the pom.xml updated as follows:
<dependency>
      <groupId>org.scala-lang.modules</groupId>
      <artifactId>scala-java8-compat_${scala.version.short}</artifactId>
      <version>1.0.0</version>
      <scope>provided</scope>
</dependency>

Option 3: cross compile this library to multiple scala versions
This would require to upgrade upgrade the build section to something similar to https://davidb.github.io/scala-maven-plugin/example_java.html
My preference goes to Option 2. Let me know if you would accept such a PR.

Hi Hayssam,
Thanks for bringing this up! Option 2 makes sense to me, I created https://github.com/googleapis/java-pubsublite-spark/pull/209 for this.
Thanks,
Michael

https://github.com/googleapis/java-pubsublite-spark/pull/209 is checked in and will be in next release.


fix: handle duplicate constants in shake

Fixes an issue reported on Zulip, due to constants being declared multiple times (which was not previously legal).

If not too hard, a test would be nice.
bors d+

@fpvandoorn We don't have any test harness setup for shake, and I'm not sure how one would do it. I can do some spurious changes here as a test, though.

Test failed successfully

bors merge


Editing and linting examples

Topic
Hello! I propose editing the examples so that they adhere to the Airbnb JavaScript Style Guide. For example, Forces would be clearer with modern syntax.
@limzykenneth @davepagurek what do you think about incorporating the sample linter from the library into the website's build system?

I'm happy to go with the Airbnb style which is somewhat close to what we have already.
The sample linter in the library repo was written to very specifically lint inline documentation's code example, for the website example you can lint the example js files directly so it may not be required. I'll leave the implementation detail up to you and we can review when a PR is filed.

That all sounds good to me!


Installation next to a working wireguard

Hey, how do I use wiregaurd-ui alongside an already working Wireguard setup? I don't want to reinstall wiregaurd. I would like to run wireguard-ui in a container next to an already running wiregaurd server. Is it possible?

It is possible but difficult as you would need to create the "database" with all the existing data by:

running the wireguard-ui and wireguard-server
changing the priv/pub key in the wireguard server settings to the existing one
adding all old clients and entering the existing pub/psk
shutting down the old wg-server
changing the port to the old one
apply the config
hopping you made no mistake and all old clients can connect

the is a guide here that does that
https://linuxiac.com/how-to-set-up-wireguard-vpn-with-docker/#comment-39615
however, after adding the first client it stops working ..

Tagging on to this, there is no way to monitor an external wireguard server with wireguard-ui is there? Running directly on firewall in my case.

Tagging on to this, there is no way to monitor an external wireguard server with wireguard-ui is there? Running directly on firewall in my case.

No not really as you need the config for the server and a way to reach the client devices and maybe more


The response body isn't reported on an failed request when swiftAsyncUrlSessionSupport flag is turned on

Description
When the swiftAsyncUrlSessionSupport feature flag is turned on, NewRelic stops showing the Response on a failed request.

Steps to Reproduce

Turn on swiftAsyncUrlSessionSupport

NewRelic.enableFeatures([
.NRFeatureFlag_SwiftAsyncURLSessionSupport,
.NRFeatureFlag_RequestErrorEvents,
.NRFeatureFlag_HttpResponseBodyCapture
])

Make a failed API request with a response data
Check the log on the HTTP Errors tab for the new tracked request

Expected Behavior
The Response data should show up instead of show this error:

Relevant Logs / Console output
n/a
Your Environment

iOS Version: 18.0
Device: iPhone 12
SDK Version: 7.5.2

Additional context
n/a

Thanks, We've created a JIRA ticket in our JIRA system. We will aim to fix this in a future release.


copr: optimisze json

Reduce allocation and add more test cases.

Could you add some benchmarks ?

@ngaut I will add benchmarks about JSON in next PR, and do some tuning.

LGTM.

@AndreMouche @disksing PTAL


Feature/unit tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f1cd235). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #16   +/-   ##
==========================================
  Coverage           ?   50.52%
==========================================
  Files              ?       14
  Lines              ?      384
  Branches           ?        0
==========================================
  Hits               ?      194
  Misses             ?      190
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cd235...1cda09c. Read the comment docs.


Add missing SystemCommand::Mixin to fix CI

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Should resolve https://github.com/Homebrew/brew/actions/runs/7733313670/job/21085133518

Not sure how this was possible to have broken?

Also:
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-sponsors.rb:64:in `update_sponsors'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-maintainers.rb:57:in `update_maintainers'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'

Also:
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-sponsors.rb:64:in `update_sponsors'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-maintainers.rb:57:in `update_maintainers'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'

Yeah, there might be a long tail of these, as tests are presumably run in random orders. Since commands all live in a single namespace, sorbet can't detect which need to have the mixin, and load order determines what's been mixed in at runtime. Anyway, fix incoming.


add support for additional LLM providers

[ ] xAI's grok
[ ] AWS

[ ] ai21
[ ] ailayer
[ ] aimlapi
[ ] anthropic
[ ] anyscale
[ ] azureai
[ ] baseInterface
[ ] cloudflareai
[ ] cohere
[ ] corcel
[ ] deepinfra
[ ] deepseek
[ ] fireworksai
[ ] forefront
[ ] friendliai
[ ] gemini
[ ] gooseai
[ ] groq
[ ] huggingface
[ ] hyperbeeai
[ ] lamini
[ ] llamacpp
[ ] mistralai
[ ] monsterapi
[ ] neetsai
[ ] novitaai
[ ] nvidia
[ ] octoai
[ ] ollama
[ ] openai
[ ] perplexity
[ ] rekaai
[ ] replicate
[ ] shuttleai
[ ] siliconflow
[ ] thebai
[ ] togetherai
[ ] voyage
[ ] watsonxai
[ ] writer
[ ] zhipuai

assigned ai21 to faizan2700

assigned deepseek to faizan2700

replicate.com is very diverse and will require many subclasses to handle the different parameters

[ ] figgs.ai
[ ] cinematika
[ ] stabilityai
[ ] seco
[ ] LCM
[ ] deepfloyd
[ ] material
[ ] elevenlab
[ ] speechify
[ ] duckduck

[ ] blackbox
[ ] microsoft
[ ] cognitivecomputations

we need to;

create a list of all of the LLM provider options

iterate through that list gathering the documentation for the models supported, pricing, and how to use their API via python.

create a new issue for each chat completion model discovered, detailing the file path of the new component and test file, default model, allowed models, and test case ENV variable key names.

create a new issue for each tool model discovered, detailing the file path of the new component and test file, default model, allowed models, and test case ENV variable key names.


Add in the word and pdf output

Update with three outputs and try to mimic the folder structure similar to Stanford:

There are three folders sitting under the extension folder for each output
Add in a demos folder to generate example document using the defined template
Add in a template.qmd file to be used as the report generator (the name will change accordingly when install the template)

Hi Vinh, can you please add yourself to the author list of this template?

Also, please note that the structure of this should have templates for the individual outputs in the respective docs folder, refer to https://github.com/coatless-quarto/stanford/blob/a35eb826abe9fb97c20dfd27d3699154546b87cd/docs/demos/template-revealjs.qmd

To my understanding, you want three separate folders for each output in the demos folder as well?

@VMT1312, I think I've fixed any of the issues with generating a PDF. We were missing the resource files, e.g., AAGI_logo.pdf, etc.


Lower Window Opacity?

I usually use a transparent terminal. Is something like that possible for hyperterm? I know that CSS allows for lowering opacity, but I'm not sure where I would put that property.

This discussion might be helpful electron/electron#381.

Looks like transparency is working on mac using hex colors with alpha transparency:
#[alpha transparency code][hex color code]
https://gist.github.com/marcbachmann/18df2187b3d1693a43ee60ccbfeab096#file-hyperterm-js-L16

@marcbachmann your config doesn't produce the same results locally on my machine

I've set backgroundColor: '#DD0a1a1f', in my config. When I launch hyperterm on a fresh start, the transparency doesn't work, but if I do a full refresh after opening it, the transparency works.

Anyone manage to get transparent background on Linux?

Works with latest release!

@leo Linux not working   --enable-transparent-visuals --disable-gpu   Ref: Electron Docs

M
Few faffvV x c
fJackson Singleton
D.C. Did

On Oct 7, 2016, at 1:45 PM, Ayhan<EMAIL_ADDRESS>wrote:
@leo Linux not working --enable-transparent-visuals --disable-gpu Ref: Electron Docs
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

rgba colors are working with 0.8.1 on MacOS Sierra:

The transparency works, but there's occasionally ghosting from the last text that was in the terminal. Resizing the window fixes the problem, but I don't know what kind of bug this is.

rgba works fine on El Capitan too for me, but only when I don't use any themes. When I use themes they override the background.

Is there any way to make background transparent along with the theme ? Thanks.

yes unfortunately I am only able to get the transparency to work when not using a theme. I look forward to finding out how this can be done when using a theme.

I was able to hack into my theme's config in .hyper_plugins/node_modules/ to make the background transparent by using rgba.

I was able to get it to work as I stated above but the only thing that sucks is that I lose the transparency when I am using vim

Is there a way to force transparent background no matter what the theme (or vim/nano/whatever) dictates? Something like background-color: #282828; background-transparency: 70% !important;

@alexandernst Yeah I tried that and did not have success when I changed .hyper.js config. I hope someone does come up with a solution for transparency when it comes to using vim in Hyper

Hey guys,
It looks like V1.0.0 has a new vibrancy feature. I actually wasn't able to get it working but I think it's what most of us are looking for.
https://github.com/zeit/hyper/releases

@alexmarmon yeah I was not able to get it working either. I added it and used rgba for opacity on background and no luck.

Sorry, I'm a bit confused, is transparency working on Linux now or not? I'm running Ubuntu 16.04 and it seems to not be working...

@tairabiteru Nope, it's only working on macOS. Electron and transparency isn't working great on either Linux and Windows, and there are several limitations.

@JarnoNijboer but I use macOS Sierra and not work for me

I know you're using zsh as a terminal, but Has anyone made a hyper plugin that shows the side arrow in the screen shot above?

Also experiencing this issue. Latest version (<IP_ADDRESS>8) on macOS Sierra (10.12.4). Transparency only works with backgroundColor without a theme. As soon as I install a theme, it's gone. :(

Same issue on Antergos (4.11.3-1-ARCH), MATE DE. Transparency does not seem to work on latest version, tried both rgba as well as hex for backgroundColor, as well as hyper-transparency. Result: background is still black, no transparency at all.

Same issue on macOS (10.12.5 (16F73))

Using High Sierra I cannot get transparency to work with or without a theme.

I am using High Sierra and its works fine for me. backgroundColor: 'rgba(0,0,0, 0.8)'

macOS High Sierra (10.13.4 (17E199)) and I tried backgroundColor: 'rgba(0,0,0, 0.8)' and it did not work.

KDE, Arch Linux (all latest stable)
Cannot get transparency with backgroundColor: 'rgba(0,0,0,0.8)'

@martmists I believe electron has dropped support for transparency on Linux & windows due to chromium issues..

You can force it to allow transparency by setting WindowSettings.transparent to true.

I don't know about Linux, but on Windows and MacOS, browserWindow.setOpacity is supported.
I made a plugin using it : hyper-opacity

@martmists where is this WindowSettings.transparent option??

Windows users, follow these steps -:
1.) Add "hyper-opacity" to plugins array. (hyper-opacity plugin will be installed)
2.) Add property - "opacity: 0.8" (Editable)

Windows users, follow these steps -:
1.) Add "hyper-opacity" to plugins array. (hyper-opacity plugin will be installed)
2.) Add property - "opacity: 0.8" (Editable)

Where? In the env: {} ? Or in the module exports {} as a javascript object property? Or in the css: ''  as a CSS string?

Sorry, for the necro, but this is, of course, still an issue and there is an external solution for those who use Gnome desktop . You can use the Gnome extension 'transparent-window'. I'm successfully using it on: Ubuntu 20.04.1 LTS

Extension:
https://extensions.gnome.org/extension/1454/transparent-window/


Use godep to make Makefile environment independant

I don't believe we still need this, with vendoring

agreed


$ref in fields replaces all attributes, instead of merge

Scenario 1:
In this example, we use x-nullable as a vendor extension to represent when a field is allowed to have an expressly null value. As it stands now, we have to make address.yaml contain this property for all uses (which is bad, because it's not always nullable).
# item.yaml
shipping_address:
  x-nullable: true  # I will be killed by the following $ref
  $ref: "address.yaml"

# address.yaml
  description: A generic address
  properties:
    # fields here

Once this is deferenced, x-nullable has disappeared. It seems like this should be a merge, to allow for overrides as well.
# item.yaml
shipping_address:
  description: A generic address
  properties:
    # fields here

Scenario 2:
When using generic/common objects, it's nice to provide usage-specific descriptions. Today we have to use one description for all uses, as the description will be stripped by dereferencing.
# item.yaml
shipping_address:
  description: Shipping address for the item  # I will disappear after $ref resolves
  $ref: "address.yaml"

After dereferencing, this will strip off the overriden description:
# item.yaml
shipping_address:
  description: A generic address
  properties:
    # fields here

I agree 100%.  I've run into these same scenarios many times in my own APIs.   I'm currently working on Swagger Parser v3.0.0, and I will make sure this feature is in that version.

I saw the 3.x branch, glad to hear you can try to incorporate this. :heart_eyes_cat:

This feature has now been implemented in the latest alpha.  Please give it a try and let me know what you think.

Cool I was just looking at the npm release for 3.0 alpha last night. I'll give it a spin on this issue when I have a minute. Thank you!

FYI - Swagger 3.0.0 is now officially released, and it includes this fix


Make the GUI information exportable to XLS or CSV

In GitLab by @mcastril on Jan 4, 2024, 16:51
It would be nice to have some of the tables, like performance views, or even the quick view or tree view, exported to files.
Related issue: https://earth.bsc.es/gitlab/digital-twins/de_340/project_management/-/issues/555#note_249025

Apart from the performance section shown in https://earth.bsc.es/gitlab/es/autosubmitreact/-/issues/96#note_265017, the new "Table View" also has these options

mentioned in commit a9cba65c5bcecc7061da8c6804f6f44c170d9c45


Simplfify shims by changing shebang

Due to how shebangs work, its possible to have an executable file with the shebang
#!/usr/bin/env rbenv exec
This will optimize rbenv

I don't understand fully, but no shebang changes are necessary for scripts to work with rbenv. #!/usr/bin/env ruby shebang is just fine and doesn't need "optimization". Thanks for suggesting!


Bug Report: [yoshi engine not open]

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as deleting the YoshiCrafter29 folder from AppData) before submitting an issue.
If you're using an older version of the engine, check if the bug haven't been already fixed
PS : the "everything goes black while changing state in developer mode bug" is not a bug, it's been designed this way to refresh all bitmaps between states to allow easier modding.
Which target are you using?

[X] Windows
[ ] Mac
[ ] Linux

What version of the engine are you using (Bottom left of the screen in main menu) ?
1.3.1
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
no, i just downloaded and opened the engine
Please describe your issue. Provide extensive detail and images if possible.
---I don't know if this problem is in the engine or it's in my pc, the yoshi engine doesn't open in my pc and the first versions opened and repeating I don't know if this problem is in the engine or it's in my pc

It's weird, cause other people are having this issue as well.
Can you tell me which version of Windows you're running on ? Along with the architecture ?
As far as i tried it both works on Windows 8 and 10.
Can you also give me what GPU (or APU) you're using, and the latest version that worked ?

i'm using windows 10 and i don't know what gpu or apu ;-;

Does your username have any ' or & or any other special characters in it ?
If so, try opening Yoshi Engine that way :

Create a text file in the Yoshi Engine folder
Type this in it :
"Yoshi Engine.exe"
Close Notepad
Enable "Show files extensions"
Rename "your text file.txt" to "your text file.bat"
Click yes on the dialog box
Double click the bat file

It worked!


[stable/prometheus] Allow set securityContext for node exporter pods

This PR allow set securityContext for node exporter pods. For example:
securityContext:
      runAsUser: 0

which allow node exporter run as root user (maybe useful for a fix permissions issue, for filesystem stat collector when we mount root fs of a node into pod)

/assign @foxish

/ok-to-test

/lgtm


Python None maps to JS/TS undefined instead of null

Describe the bug
It seems that JSII may be interpreting a Python None value or NoneType object as undefined rather than null.  I am working with Step Functions state machines in the CDK in Python and when I use result_path=JsonPath.DISCARD this gets set to "ResultPath": None in the resulting state machine definition as a Python dictionary.  But then either calling stack.resolve or just during the resolution process during cdk synth the ResultPath property get's removed entirely.  I can see here where resolve removed properties with undefined value.  https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/core/lib/private/resolve.ts#L222.  But when converting from code to JSON, null is a valid value, which Python's None value usually maps to.
Expected Behavior
When creating a Step Function state with result_path=JsonPath.DISCARD I expect the resulting state machine definition to include "ResultPath": null.
Current Behavior
Currently, if I create a state with result_path=JsonPath.DISCARD the resulting state machine definition does not include the ResultPath field at all.
Reproduction Steps
from aws_cdk import Stack
from aws_cdk.aws_stepfunctions import JsonPath, Map, Pass, StateGraph
from constructs import Construct

class CdkMapStack(Stack):
    def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
        super().__init__(scope, construct_id, **kwargs)

        map_state = Map(
            self,
            "Map",
            max_concurrency=1,
            items_path=JsonPath.string_at("$.inputForMap"),
            parameters={"foo": "foo", "bar": JsonPath.string_at("$.bar")},
            result_path=JsonPath.DISCARD,
        )
        map_state.iterator(Pass(self, "Pass State"))

        print(map_state.to_state_json(), file=open("./cdk.out/map-state.json", "w"))

        graph = StateGraph(map_state.start_state, "Test Graph")

        graph_json = graph.to_graph_json()

        print(
            graph_json,
            file=open("./cdk.out/state-graph.json", "w"),
        )

        print(
            self.resolve(graph_json),
            file=open("./cdk.out/state-graph-resolved.json", "w"),
        )

Run cdk synth with the stack above.  Inspect the 3 files created in the cdk.out directory.  The map-state.json and state-graph.json files will show the "ResultPath": null, but the state-graph-resolved.json file will not include the ResultPath field on the Map state at all.
Possible Solution
I'm not entirely sure of a solution as in some contexts it makes sense for Python None values to map to undefined and other times it makes sense for it to map to null.  I don't believe Python has a way to distinguish the 2.  Perhaps the CDK or JSII need an enum or constant to represent null in those contexts where null is valid and then None will always be treated as undefined.
Additional Information/Context
I have noticed this on multiple state types now, but both related to a Map state.  I've found this behavior on both the Map state itself and when I add result_path=JsonPath.DISCARD to a task state within the Map state iterator.  Neither had the ResultPath field in the synthesized/resolved state machine definition.
SDK version used
2.68.0 (build 25fda51)
Environment details (OS name and version, etc.)
Mac OS 13.2.1, Python 3.9.6

Jsii APIs cannot distinguish between null and undefined by design, as most languages don't have a distinction between the two. The fix for this issue lies in the CDK, where a special JsonNull value needs to be used.


GH-335: Fix Class Cast with Batch Filter [1.x.x]

Fixes #335
Failed to check batchListener field when casting listener to apply filter.
Conflicts:
spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java
spring-kafka/src/test/java/org/springframework/kafka/annotation/EnableKafkaIntegrationTests.java
Resolved.
cherry-pick to all 1.x

... and cherry-picked to 1.1.x.
There is no batch support in the 1.0.x, so, nothing to backport.


chore(main): release 9.3.0

:robot: I have created a release beep boop
9.3.0 (2024-11-06)
Features

add language configuration for LLM responses (#410) (e1a39bb)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v9.3.0
:sunflower:


support launch with python multiprocess

e.g.
./examples/multiprocess/tf_multiprocess.py
./examples/multiprocess/torch_multiprocess.py

@ZenoTan

@ZenoTan

Could we add *args to launch_multiprocess?
How do we construct optimizers? import kungfu.torch as kf           optimizer = kf.optimizers.SynchronousSGDOptimizer(               optimizer, named_parameters=model.named_parameters())           kf.broadcast_parameters(model.state_dict())

Could we add *args to launch_multiprocess?
How do we construct optimizers? import kungfu.torch as kf           optimizer = kf.optimizers.SynchronousSGDOptimizer(               optimizer, named_parameters=model.named_parameters())           kf.broadcast_parameters(model.state_dict())

For passing extra args, you can wrap the worker with a functor, e.g.
#!/usr/bin/env python3

import torch
from kungfu.cmd import launch_multiprocess

def worker(rank):
    import kungfu.torch as kf
    from kungfu.python import current_cluster_size, current_rank
    print('rank=%d' % (rank))
    print('kungfu rank: %d, size %d' %
          (current_rank(), current_cluster_size()))
    x = torch.ones([]) * int(current_rank())
    print(x)
    y = kf.ops.collective.all_reduce_fn(x)
    print(y)

class Worker():
    def __init__(self, f, args):
        self._args = args
        self._f = f

    def __call__(self, rank):
        self._f(self._args[rank])

def main():
    np = 4
    args = list(range(np))
    launch_multiprocess(Worker(worker, args), np)

main()

For passing extra args, you can wrap the worker with a functor, e.g.
#!/usr/bin/env python3

import torch
from kungfu.cmd import launch_multiprocess

def worker(rank):
    import kungfu.torch as kf
    from kungfu.python import current_cluster_size, current_rank
    print('rank=%d' % (rank))
    print('kungfu rank: %d, size %d' %
          (current_rank(), current_cluster_size()))
    x = torch.ones([]) * int(current_rank())
    print(x)
    y = kf.ops.collective.all_reduce_fn(x)
    print(y)

class Worker():
    def __init__(self, f, args):
        self._args = args
        self._f = f

    def __call__(self, rank):
        self._f(self._args[rank])

def main():
    np = 4
    args = list(range(np))
    launch_multiprocess(Worker(worker, args), np)

main()

Great. What about the second question: kungfu optimizer can still be used as before, like what we have in quiver?

Great. What about the second question: kungfu optimizer can still be used as before, like what we have in quiver?

I think it should be the same.
They only thing that need to be careful is, don't include other kungfu module before launch_multiprocess, otherwise the main process will be initialized as a kungfu process.

I think it should be the same.
They only thing that need to be careful is, don't include other kungfu module before launch_multiprocess, otherwise the main process will be initialized as a kungfu process.


EXCEPTION: Cannot read property 'src' of null

Using Postscribe in combination with Angular2.
In my current project I'm looking to get a table from an external javascript file that contains a document.write. In the past we've done that in this fashion:
<script src="http://url.to.external.domain.com/file.ashx?sid=<ID>" type="text/javascript"></script>

Angular2 removes script tags from templates, so that is not a solution. I've used postscribe and that worked when Angular2 was still in RCs. At some point I suddenly noticed it stopped working, and can't trace back what package broke it.
I now get this error:

The afterWrite callback still fires and the document.write in the external JS file has been written, but the done callback won't fire anymore. Since I'm working with an Angular2 SPA, the postscribe call won't happen again when opening a similar page, since it produced an error.
I've tried many things, but simply don't know what causes this. Was hoping anyone could help.
Plunkr: http://plnkr.co/edit/FHSVKDL2rv8TAQyTeqE2?p=preview
You can see it's working, but in the console you see the same errors described above.

I ran into the same issue. Downgrading to v2.0.6 worked for me.

@ghost's suggestion to downgrade to v2.0.6 indeed seems to have solved my problem.
Thanks

Do you have any estimation on when this is going to be fixed?
Thanks in advance


[Fix]: only detect functions that return JSX somewhere as components

Registering all functions that return JSX + null as components has bring a lot of false positives for normal functions that just happen to return null somewhere.
In this PR I propose a new approach to detecting components by finding all return statements in a function and only marking the function as a component if one of them returns JSX.
Fixes #2010

In React 16, returning an array, a string, or a number (and I think a boolean) are all valid components.

In React 16, returning an array, a string, or a number (and I think a boolean) are all valid components.

Yeah, but adding those types in my opinion will bring even more false positives that the null case.
By the way the only meaningful thing that this PR those is to remove the null check and collect all return statements from functions. The isReturningJSX algorithm is the same. That is why almost no test was broken.

Closed based in https://github.com/yannickcr/eslint-plugin-react/pull/2707#discussion_r453122044


sendMessage invoked but no messageCallback defined

Hi.
When sending a notification from the server console appcelerator answer me this: [ERROR]: E / ti.goosh.TiGooshModule: sendMessage Invoked messageCallback but not defined
A This message is?
Thank you

Hi @necrocyber
Can you provide the code to how you are registering for push notifications using the module?

Hi.
I am using the same example available.
`TiGoosh.registerForPushNotifications({
// The callback to invoke when a notification arrives.
callback: function(e) {
var data = JSON.parse(e.data || '');
console.log(e);
},
						    // The callback invoked when you have the device token.
						    success: function(e) {

						        // Send the e.deviceToken variable to your PUSH server
						        Ti.API.log('Notifications: device token is ' + e.deviceToken);
								token = e.deviceToken;
						    },

						    // The callback invoked on some errors.
						    error: function(err) {
						        Ti.API.error('Notifications: Retrieve device token failed', err);
						    }
						});`

Do you see 'Notifications: device token is ' + e.deviceToken in the logs?

Hi.
I am using the same example available.

If there has been no problems and showed me the token console

@necrocyber was the app closed, in background or open when you sent the push notification?

When the app is open, console shows me the error mentioned. When the app is running in the background or simply closed, do not run the callBack.

Now ... I realized that when I register the device in GCM shows me the token console, but also throws the following error
[ERROR] :  GooglePlayServicesUtil: The Google Play services resources were not found. Check your project configuration to ensure that the resources are included.

That's normal.
Could you paste your adb logcat | grep Goosh

What is the purpose of delivering that kind of log?

To debug?

This is correct?
<application android:theme="@style/materialTheme">                 <activity                     android:configChanges="keyboardHidden|orientation"                     android:name="org.appcelerator.titanium.TiActivity" android:screenOrientation="portrait"/>                 <activity android:name="android.hardware.Camera" android:screenOrientation="portrait"/>                 <meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version"/>             </application>

I work with version 1.5, api Ti.5.2.2

I do not understand why, but now is working and not run changes in settings


Error handling with unregistered route

Hi. I have some route like this
Route::get('/page/{page}', 'PageController@show');

And while adding inertia error response instead of laravel error page, i noticed that if the route is not registered (for example site.com/pagethatnotinrouter), then the following code from docs example throws an error.
return Inertia::render('Error', ['status' => $response->status()])
            ->toResponse($request)
            ->setStatusCode($response->status());

thrown {"exception":"[object] (Symfony\\Component\\ErrorHandler\\Error\\FatalError(code: 0): Uncaught InvalidArgumentException: View [app] not found. in /.../vendor/laravel/framework/src/Illuminate/View/FileViewFinder.php:137

And the reason is that HandleInertiaRequests as well as all other middleware won't be processed.
The solution i found is to add this code in the end of my web.php file
Route::any('{any}', function () {
    abort(404);
})->where('any', '.*');

I think it's worth adding a note about this in the documentation with a (perhaps better) solution.

Hey there, thanks for reporting this issue.
I'm not able to replicate this locally using the example from the Inertia docs.

Diff from a clean install of Laravel with the Breeze Vue stack
diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
index 56af264..c4c1eb5 100644
--- a/app/Exceptions/Handler.php
+++ b/app/Exceptions/Handler.php
@@ -3,6 +3,7 @@
 namespace App\Exceptions;

 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Inertia\Inertia;
 use Throwable;

 class Handler extends ExceptionHandler
@@ -27,4 +28,26 @@ public function register(): void
             //
         });
     }
+
+    /**
+     * Prepare exception for rendering.
+     *
+     * @return \Throwable
+     */
+    public function render($request, Throwable $e)
+    {
+        $response = parent::render($request, $e);
+
+        if (in_array($response->status(), [500, 503, 404, 403])) {
+            return Inertia::render('Error', ['status' => $response->status()])
+                ->toResponse($request)
+                ->setStatusCode($response->status());
+        } elseif ($response->status() === 419) {
+            return back()->with([
+                'message' => 'The page expired, please try again.',
+            ]);
+        }
+
+        return $response;
+    }
 }
diff --git a/routes/web.php b/routes/web.php
index 9f834ee..a296abe 100644
--- a/routes/web.php
+++ b/routes/web.php
@@ -35,4 +35,8 @@
     Route::delete('/profile', [ProfileController::class, 'destroy'])->name('profile.destroy');
 });

+Route::get('/page/{page}', function ($page) {
+    dd($page);
+});
+
 require __DIR__.'/auth.php';

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?
Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
laravel new bug-report --github="--public"

After you've posted the repository, we'll try to reproduce the issue.
Thanks!

Hey closing this one because we haven't heard back 👍


HDFS-15542. Add identified snapshot corruption tests for ordered snapshot deletion

please see https://issues.apache.org/jira/browse/HDFS-15542.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m  2s
trunk passed

+1 :green_heart:
compile
1m 20s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m 14s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 49s
trunk passed

+1 :green_heart:
mvnsite
1m 25s
trunk passed

+1 :green_heart:
shadedclient
16m 32s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 53s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 24s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
3m  1s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 59s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m  5s
the patch passed

-0 :warning:
checkstyle
0m 39s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

+1 :green_heart:
mvnsite
1m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 38s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m  2s
the patch passed

_ Other Tests _

-1 :x:
unit
96m  2s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

178m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.TestFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2251

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f0018197eeeb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d8aaa8c3380

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/testReport/

Max. process+thread count
4256 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
28m 20s
trunk passed

+1 :green_heart:
compile
1m 17s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m 12s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 48s
trunk passed

+1 :green_heart:
mvnsite
1m 18s
trunk passed

+1 :green_heart:
shadedclient
16m  7s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 24s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 57s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m  2s
the patch passed

-0 :warning:
checkstyle
0m 40s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
mvnsite
1m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 50s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 47s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m  7s
the patch passed

_ Other Tests _

-1 :x:
unit
101m 21s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

184m  2s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.TestGetFileChecksum

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.namenode.ha.TestHAAppend

hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

hadoop.hdfs.server.blockmanagement.TestAvailableSpaceRackFaultTolerantBPP

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.TestReplaceDatanodeFailureReplication

hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2251

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b70fa96d748d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 30b1b1cc047

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/2/testReport/

Max. process+thread count
4338 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @szetszwo for the review.


Documentation update (Readme.md , Code-of-conduct.md , Contributing.md Added)

Issue Number
fixes #15 , #13, #23
Guidede by : @Siddhant-K-code

Edited the Readme.md file with all the required steps and specifications, Added Code-of-conduct.md, Added Contributing.md

React-scripts error for version solved, added react script for npm and yarn users so that they do not face ESOCKETTIMEOUT error.

Test plan
All the links embedded are working and tested.

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Please review the latest changes.

Please review the latest changes.

Thanks @kaiwalyakoparkar for the Pull request, thanks @Siddhant-K-code for the detailed review.


[iOS] Test MDCShadowLayer

On iOS we add elevation by using the Shadow Layer of Material Components. Further testing is required for cases like when the device is rotated, in listview etc.

Fixed in 386543e920d12831653a9cbd87e35901e762c43f


Build 0.3 enclosed ventilator - main enclosure - location MD

Assemble all components to Main Enclosure.
Document any issues/improvements identified during build.
This is 1 of 2 Ventilator Beta Builds

Sister ticket for CA build #784

Sister ticket for CA build #784


docs: add AWS ECR to list of supported registries

Tested ECR successfully on an EC2 box with an IAM role that had permissions to ECR.

Thanks!


Still clean up backups after database has been dropped

Hello Oli
Love your work!!
Could we have a new @ parameter - something like @CleanupNoDatabase where we can put in the name of a database from the command table that does not exist in sys.sysdatabases and your job will clean up the old backups as set by the @CleanupTime parameter?

I would prefer @CleanupNoDatabase to be a boolean and if set to true then all files that match the expected pattern and age will be deleted. This will clean up the backup files for databases that have been dropped.

I'm opposed to any feature like the one @QPES suggested that deletes unknowns in bulk. It adds complexity to make sure we get it right, and the risk of getting it wrong is unconscionable. Consider the case where backups are stored at the root of a mounted volume or file share that's used by other servers; you've just deleted all your other backups forever.
@LonHost's original suggestion is less severe, but calling the procedure with an arbitrary value that doesn't exist as a database, presumably from a scheduled backup job, doesn't fit the name and purpose of the DatabaseBackup procedure; if you're looking to reimplement the cleanup functionality as a standalone feature, split it out into its own script that could be run ad hoc. I am not sure why that would even be written in T-SQL instead of a shell script or similar, but I'd be interested to hear more about that use case.

Orphaned backup files are also an issue if you change the Recovery Model.   If logs were created, they aren’t being deleted after going from Full to Simple.
It would be great if the backup job read the backup history from the CommandLog table or msdb.dbo.backupset to find files for changed/dropped databases.
It could also be added to the CommandLog Cleanup job so any backup files that exist would be deleted when the record of the command was deleted. However, this could conflict with the backup jobs, so I think the first option would be best.


Tracker enhancement

Fixes #46
This change covers: Modifications to the way health/willpower are managed, and Implementation of a migration system for when template.json is updated.
Health/Willpower trackers.

Health/Willpower trackers now store their Current/Max values, rather then "aggravated" and "superficial" wounds. These are stored as an array of strings which contain either "-" for undamaged, "/" for superficial, or "x" for aggravated. The states themselves are ALSO stored in the template.json. So for future trackers that may want to use this code, they can create their own separate list of states and the code SHOULD handle it properly without additional fiddling. (the code looks up what states belong to the tracker it is working on and then grabs the next/previous state from that, rather than having it hard coded in the actor code). Current is simply max - the number of wounds. The boxes are "dumb" IE, you can click them in any order. left clicking moves them forward a step, right clicking cycles them backwards a step. The red/Green Buttons increase/decrease maximum health starting at the RIGHT side of the tracker moving backwards. So any wounds on the last box are deleted as health is reduced.

Additionally worth noting that the Humanity bar continues to use the old code. Humanity should be redone as well, and the code presented here can serve as a solid baseline to implement that change, but some changes will need to be made to make it function correctly.
Migration System:
System will now store a variable for the systemversion that will be compared when a GM logs into foundry. If the current version of the vtm5e system is newer than the previous version, it will go through the migrations. Currently only one migration exists(for the other change in this pull request) I have started it with a check to look for old values that will be removed, so the change will only occur on actors that need to be updated.
It is worth noting/crediting that the core of the migration system code was copied from the dnd5e project written by atropos, with modifications to make it work in this system.
Minor changes:
Some css changes were made to work with the new system. Including using variables for color values in the tracker boxes. Which means theoretically we could implement some future code that would allow tracker boxes to be customized. Probably wont come up, but it is worth noting anyway.
EDIT: There is a minor CSS bug when max health/willpower is put OVER 10. I haven't yet found a way to prevent this. It does not stop any functionality. but it looks bad. I'll keep looking for a solution, but it may be worth looking at before the code is implemented in the next version.

Just an adendum to this. I just realized this change breaks the frenzy roll. I somehow forgot to take that into account. I'm working on a fix for this that I'll push into this pull request soon.

Frenzy roll fixed in last push. Everything should now be working.

conflicts with the dev branch :(

Ah dang. I should have probably used the dev branch as my starting branch. I’ll take a look at it tonight or tomorrow and get things sorted out.

What is rock.jpg for?

I'm sorry for the slow review process :(
It's a big change

What is rock.jpg for?

I've removed it. There was a point where i was trying to use pieces from another code, and added that to test a bug i was seeing. Apparently I removed the code, and missed that i left that in there. My apologies.
Requested changes have been made. :)

Is the review still pending?

There's a merge conflict. :(
I wrote my own logic for adding and subtracting resource boxes so there'll likely have to be a marriage between the different implementations.

I'm confused, wasn't this merged, or at least the functionality implemented a while back? Is this merge even still necessary? Whats missing?

I implemented the + - buttons but didn't implement the way to toggle any box rather than the fixes left to right box counter

Ah, then this should just be closed. I don't think that my method of tracking was necessarily the best way, I just wanted to resolve the max health/redbox issue.


Mobile view responsiveness

🐞[bug]: The home page is not at all responsive in the mobile view**
Description
The issue was of UI aspect. The balance was totally disturbed and specially in the mobile view it was having some unexpected space on the right side. You can compare with the screenshots provided in the issue with these screenshots to spot the issue.
Related Issues
None

Closes  issue# 465

Type of PR

[X] (Fixing responsiveness with respect to mobile specially)

Screenshots / videos (if applicable)

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
Looking forward for this PR to be merged as it is working absolutely fine.

@Anjaliavv51 I have created the pull request, kindly review it.
Let me know If there are any changes required. Waiting for your response.

@Anjaliavv51 let me know if there are any changes to be made.

@Kiran-F resolve merge conflicts

@Kiran-F resolve merge conflicts

Resolving conflict done


group_by: collation-aware grouping

Hi doltfriends! Here's another compatibility fix. This one I'm more confident about: GROUP BY is not collation aware when grouping!
The included test reproduces the issue trivially, but for completeness: when using a GROUP BY statement that includes a textual column, the column's collation needs to be taken into account when creating the aggregation groups.
E.g., for the following schema and query
CREATE TABLE test (id bigint, title varchar(255) collate utf8mb4_0900_ai_ci, PRIMARY KEY(id));
INSERT INTO `test` (title) VALUES ('val1'), ('VAL1'), ('val2'), ('VAL2')
SELECT COUNT(*) FROM test GROUP BY title

We should expect the result of the SELECT to contain two rows, as there are only two groups when grouping by title. Even though we've inserted 4 unique values, the utf8mb4_0900_ai_ci with which the column is collated is case insensitive, so in practice, 'val1' = 'VAL1' and 'val2' = 'VAL2' when grouping. This is not the current behavior.
The fix is straightforward: use a weight string when hashing to generate the grouping key instead of using the expression's literal value. I did a small refactoring in collations.go so that we can write the weight string directly into the grouping key's hasher and continue using the same code for the existing HashUint API.
cc @dbussink

Oh wow! This is another great find. Thank you @vmg!! 🙏

Are you all using this at Planetscale or are these hobby fixes?

We're evaluating using go-mysql-server in the OSS Vitess project to mock MySQL instances in our end-to-end tests (which I guess would become integration tests once we remove live MySQL). It would be a game changer for our CI and allow us to test hundreds more permutations of tables and databases much more efficiently!
Before we get there, we need go-mysql-server to mimic MySQL semantics as accurately as possible. These are some of the incompatibilities I've found so far.
My assumption is that you are also interested on behaving as close as MySQL as possible, is that correct? For things like this specific bug, go-mysql-server was clearly doing the wrong thing, so that's why I've opened this PR, but I've found some other cases where you're returning sensible results that are not 100% the same as MySQL.
I'd like to discuss those with you, and whether you'd like those fixes too. Should I open an issue for MySQL compatibility quirks? What works best for you?

I've mentioned you all a number of times in some of our more consistently popular blogs.

I know! I read those and found them very interesting! :)

(build should be green now; I introduced a typo in my refactoring)

We're evaluating using go-mysql-server in the OSS Vitess project to mock MySQL instances in our end-to-end tests (which I guess would become integration tests once we remove live MySQL). It would be a game changer for our CI and allow us to test hundreds more permutations of tables and databases much more efficiently!

Great use case. We have a number of GMS customers using it this way.

My assumption is that you are also interested on behaving as close as MySQL as possible, is that correct? For things like this specific bug, go-mysql-server was clearly doing the wrong thing, so that's why I've opened this PR, but I've found some other cases where you're returning sensible results that are not 100% the same as MySQL.

We're about 99% certain that we want to mimic MySQL exactly. These should at least be issues that folks can refer to so if you find them, we can start there. If we should fix them, we'll fix them. Otherwise, we'll just leave the issue open with an explanation on why we're leaving the divergent behavior.

Tests are updated!

@vmg It looks like the tests are failing.

@Hydrocharged: I'm afraid this is not related to my PR. Somebody broke main. :)

@JCOR11599 – can you take a look at the CI test failure above and see if it's related to your bindings change for prepared statements? I didn't immediately recognize the error, but happy to dig in and help figure it out if needed.

@vmg T'was me, sorry! Fix for it is here: https://github.com/dolthub/go-mysql-server/pull/1483

Thanks for the quick fix @JCOR11599!
@vmg – once you pull James' latest change from main, it should get your branch fixed up. Thanks again for working with us on this great contribution! 🙏

@Hydrocharged – heads up that the CI checks are all passing now the latest fixes from main have been pulled in. Anything else you wanna see on this PR?

@Hydrocharged – heads up that the CI checks are all passing now the latest fixes from main have been pulled in. Anything else you wanna see on this PR?

Nope, we’ll merge it!

Awesome! 🙌  Thanks again for the great contribution @vmg! 🙏


Compile to webassembly for speed

@axic would asm.js still need to be a fallback? Or can it be completely dropped in favour of warm?

I think it is still needed as a fallback.

Also please note #29 has an attempt at this, but it is not finished. Feel free to pick it up.

How would you feel about using wasm-bindgen? It would eliminate the need to maintain any boilerplate code. The generated wasm artifact can then be converted to an asm.js like representation via wasm2js, seen here.

It should be fine, when this work started wasm-bindgen wasn't around or wasn't mature enough.


Move dynamic filter to a separate package, update CI

Codecov Report
Patch and project coverage have no change.

Comparison is base (99bb6f3) 35.89% compared to head (cc52501) 35.89%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   35.89%   35.89%
=======================================
  Files           2        2
  Lines         156      156
=======================================
  Hits           56       56
  Misses         98       98
  Partials        2        2

Flag
Coverage Δ

unittests
35.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

filter/fllter.go
94.91% <ø> (ø)

main.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prime symbol ' is not good

Reading the docs, I see that both y' and y^{\prime} should be supported.
Unfortunately, using y'+2y = 3x^3+x the prime is not very nice, see it.
Using  y^{\prime}+2y = 3x^3+x the prime is supported like expected, see it.
Please tell me what I have to do to set up things nicely, I think I am missing something elsewhere.

It works fine on the demo page:

So probably something to do with your setup. Are there any console messages? Do you have the correct DOCTYPE header?

Hello, I isolated the problem from a fresh wordpress site.
The issue is still there. See this page.
No console messages.
The page content is only $y'=y$.
Katex is launched from this script:
document.addEventListener("DOMContentLoaded", function() {
	const katex_options_when_dollar_rendering = {
		throwOnError : true,
		strict       : false,
		delimiters: [
			{left: '$', right: '$', display: false},
		],
	};
	renderMathInElement(document.body, katex_options_when_dollar_rendering);
});

I don't know what happens.

Sounds like Wordpress's Smart Quotes are enabled (which they are by default).
This post tells you how to disable them: https://www.ironpaper.com/webintel/articles/fix-wordpress-quotes-by-displaying-straight-quotation-marks

Thanks for your feedback.
Added the corresponding filters in WordPress remove_filter('the_content', 'wptexturize'); and remove_filter('the_title', 'wptexturize'); but that does not change anything.
When using MathJax I don't have this problem. So I still believe this is a KaTeX issue.

More exactly, the prime issue does not appear in pure KaTeX.
Il only appears when using renderMathInElement.

Fixed.
Using renderMathInElement, we can preprocess special WordPress characters to reassign them to the specified chars.
It's quite surprising we don't need to do this in pure KaTeX whereas we have to in renderMathInElement. I'm pretty sure there exist a specific tag to tell WordPress to bypass the automatic treatment of some quotes.

Glad you fixed the problem. You might also check out the second common issue in https://katex.org/docs/issues.html

Very nice.
An issue still persists for double closing quotes which should be replaced with ''.
I defined this:
const ClosedQuotesTwo = String.fromCharCode(160)+"»";
And added in my macros:
ClosedQuotesTwo : "''"
but that does not work.
I don't know exactly how renderMathInElement works with macros, whereas it's fine using a callback in the PreProcess.

Did you try the following macro?
"”": "''"

Thanks for coming back.
I tried, yes, but the non-breaking space character (160 code) is still there before the double quote and there is a space between f and the second derivative symbol.
I tried to copy it/paste it before the double quote. No effet.
So I tried to add it with String.fromCharCode(160) but it's not detected in the macro. Strange.

I tried this, but still no effect.
const ClosedQuotesTwo = String.fromCharCode(160)+String.fromCharCode(187);
	const my_macros = { ClosedQuotesTwo : "''" };
	const katex_options_when_dollar_rendering = {
		throwOnError : true,
		strict       : false,
		delimiters: [
			{left: '$', right: '$', display: false},
		],
		macros : my_macros,
	};
	renderMathInElement(document.body, katex_options_when_dollar_rendering);

Macros only work for single characters (or \commands), so you'd need to define them individually. Of course you can do more work in preprocess.

Ok that's the point why it worked on PreProcess callback but not using macros.
Thanks for that.


linux appIndicator submenu fix

this fix for issue with disabled submenu if in same position in main menu item disabled
https://github.com/electron/electron/issues/9495

@dregenor looks like this is targeting the 1-6-x branch, does it happen in 1.7.x as well? Should it be fixed in both? Thans.

@kevinsawicki  yes this issue reproduced also for 1-7-x
https://chromium.googlesource.com/chromium/src.git/+log/58.0.3029.110/chrome/browser/ui/libgtkui/app_indicator_icon_menu.cc - last changes 4 months ago

Thanks for this @dregenor


feat(FX-3145): User can see filter criteria for each alert in list view

The type of this PR is: Feature

This PR resolves FX-3145
Description

As a user
If I visit the "saved alerts" screen
I see my saved search names
And below each name, I see the filter criteria used for that saved search

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

User can see filter criteria for each alert in list view - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (User can see filter criteria for each alert in list view - dimatretyak)

  Generated by :no_entry_sign: dangerJS against bc7658bf2a899ea0717281e36c055c97855cee07

Waiting for design changes for edit interaction from Lois


fix try/catch case missed in socket_notifier

When JSON content is a List type, the catch syntax with on Exception in _tryOn() won't catch the error.
Deleting on Exception will the bug.
Every PR must update the corresponding documentation in the code, and also the readme in english with the following changes.
Pre-launch Checklist

[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
[x] All existing and new tests are passing.

Hi, Thanks for your contribution


Fix crash while minimizing window with ui camera

Thanks
Unfortunately, GitHub didn't tell me this had been opened, so thanks for commenting on the original issue.


Runs actions, if configured, in branch plans as well as master plans

As part of these changes, I switched to using CachedPlanManager, which is recommended for performance if only immutable versions of plans are required.
Feedback welcomed!

I don't understand the intent here…the plugin already works on branch builds (in fact that's its main use case). Can you elaborate?

It doesn't seem to be triggering branch plans for me. This is supposed to work out of the box?

Yes. You have plan branches enabled?

Yah, I did a bit more research and determined the bug only occurs if the configuration for github-bamboo-status is saved. Here's my full log of how to reproduce it on a clean Bamboo instance (atlas-debug):
Created a linked repository "test" pointing at https://github.com/alindeman/test with a default branch of master:

Set the "test" repository as the default repository for a build plan:

Enabled the repository for sending statuses:

Ran the plan on master. The status is sent successfully:
[INFO] [talledLocalContainer] 2015-11-23 21:20:12,565 INFO [AtlassianEvent::0-BAM::EVENTS:pool-3-thread-6] [AbstractGitHubStatusAction] GitHub status for commit 246943aa430ffb02cb7e35c06c7c30e637c6eb7a (Build) set to SUCCESS.

Created a branch plan for the patch1 branch:

No status is sent :cry:
Note that the master branch plan key is AP-SUCCEED; the branch plan key is AP-SUCCEED0 (Bamboo creates this automatically).
When I debug the run of the branch build (AP-SUCCEED0), the RepositoryDefinition of the main repository in the branch plan is not the same as the RepositoryDefinition from the main plan. It's not the same RepositoryDefinition: it's a different branch, therefore a different RepositoryDefinition ID:

Does this make sense? It appears that when a branch plan is created, a new RepositoryDefinition is created. It'll have a different ID than the RepositoryDefinition on the master plan.
If I do all these steps, but skip the part about navigating to the Miscellaneous tab, checking the test repository, and saving the configuration, statuses for the branches are sent successfully. In that case, configuredRepos will be null and the default ("all GitHubRepository instances") will be used. Again, however, if the Miscellaneous tab is visited and the configuration saved, the list of RepositoryDefinition IDs will only match on the master plan, but not on any branch plans.

Thanks a lot for this detailed report! I've never been confident about how the configuration works. Will have to look into this.


Keeping queries more inexpensive

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

In different parts of app repetitive cross joins are expensive. An intermediate inner join will enhance it :
(10 + 10)where... < (10 * 10)where...
We have similar thing in the ActiveQuery. The child queries could be a sub query for a cleaner join but they are merged into the parent query which means multiplication of the number of rows instead of adding the number of rows.
And actually if we use joinWith , the eager loading won't work properly and it still makes two queries instead of one single join query (tracked up to ActiveQueryTrait::findWith -> ActiveRelationTrait::popuplateRelation ... $this->one() and $this->all() without any condition about joinWith). To check it we can make some passive breakpoints (echo without exit) in the Command::queryInternal to see how much load is on an active query command including information_schema.

The usual way to reduce load of schema queries would be schema caching.

Any benchmarks performed?

@samdark Hi there
My late reply, sorry.
About information_schema I'm agree with Cebe however I'm not so familiar with Yii2 schema underneath cache (Yii1 had described it in the doc about caching table info).
But about benchmark of this style of query (tmp inner join) yes when I was working with Yii1 I had a table with about some thousands of records joining with other tables and a temporary fake inner join had a notable improvement. AFAK up to MySQL 5.5 query optimizer can not understand what clause of our where condition is to filter the left side of our joins based on our defined "constant" conditions (by params) however I think it is possible for optimizer to do it as a declarative programming language (I'm not sure about MySQL 5.7).
But this is only a suggestion about query style (not essentially to approve commit to git master). In ActiveQuery if we have a joinWith it will be placed in the first place of joins in the highest priority against all other joins. We can not change the place of the join or the conditions of the join no way. However MySQL where optimization seems to optimize the sort of columns of a composite index in a where/on clause (index(a,b,c) and where(b,a,c)) however it is not said clearly. But about the sort of joins I think it is a good idea to respect to the sort of joins when we have joins and joinWiths simultaneously. As far as I understood joinWiths are kept separately and will not be converted to $this->joins until the query prepare time then all joinWith will be converted. Thus the sort of joins can not be kept. I copied the ActiveQuery (because of private methods) and ActiveRelationTrait (because it was using the ActiveQuery class type) to make a different way of joinWith that converts the joinWith to join immediately (not at the prepare) and it worked well however by a createCommand I found that whether with the Original Yii2 ActiveQuery(and ActiveRelationTrait) or my customized ActiveQuery(and ActiveRelationTrait) the ActiveRelationTrait::popuplateRelation will make an additional separate simple query to build the relation.

Briefly checked. Everything works with this pull request but I haven't found any performance difference on a real project with schema caching turned off and 20 tables in schema. Not sure if it's newer versions of MySQL optimizing better to if it's the fact that I don't have enough tables to notice the difference...

I've tested the SQLs without cache locally in Mysql with 1000 tables. Did not see any indication of performance gain so lets keep it as it is for now.


removed some param files from doc

@doutriaux1 @durack1  starting to do some clean up

@doutriaux1 I'll leave this purge up to you.. You're more aware than me what options are currently available in the param files and what/isn't included in the demo files..


[ETL-177] Update lambda README and copy relevant info to setup_test_data.py

Once @mattfazza is able to try their hand at invoking the lambda with the test events we can incorporate their feedback into this PR before merging.

I'm asking to be made maintainer of the BridgeDownstream team so that I can add Matt to the team giving them access.

@thomasyu888 Tess is the only maintainer of that team so it looks like you're out of luck. I did grant Matt write access directly which I think is sufficient.

Matt reviewed and tested this ticket.


Collision groups separation

About the PR
Splitting BulletImpassable and Opaque into 3 separate layers each, like how Low- Mid- and HighImpassable already are.
This will make it possible for shots to "travel at different heights" to introduce aiming up-down
Why / Balance
This will allow us to have projectiles/beams (and possibly even explosions) "fly at different levels" so we can do things like aiming up-down, so bullets could be flying over prone mobs (and perhaps the Rat army rushing at you, too). Low cover. Being able to shoot over people to hit a Tall target etc.
Technical details
This will be fully backwards compatible if any references to the old Opaque or B.I. are left in the code, but I am replacing all instances in our own code with FullOpaque and FullBulletImpassable because searching for just "Opaque" and "BulletImpassable" will be much less useful with three variants of each. This causes a lot of touched files
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Re-open if this gets done otherwise It's omega conflict bait.


Integrate with circle-ci

compare with travis-ci

circle-ci docker caching: https://circleci.com/docs/1.0/docker/#caching-docker-layers

Since we already used travis-ci, no need to use circle-ci currently.


Broken on Silverlight (including WP)

This actually isn't your bug and it's pretty obscure, but RxUI has removed Move from reactivelist only on Silverlight, here (https://github.com/reactiveui/ReactiveUI/commit/7224331f2b274c100546ac9b2e1fcf1c69987fa8). Don't ask me why. But this lib relies on it so obviously in many cases... boom.

I will add some conditional compilation

That is freakishly fast. Thanks!

Not so quick this time!


Add calc.signum (or equivalent)

Description
Rust has a f64::signum method^1 (no parameters) which returns 1.0 if the float is positive or +0.0, -1.0 if the float is negative or -0.0, and NaN if the float is NaN. Rust also has a i64::signum method^2 which returns 1 if the integer is positive, 0 if it is zero and -1 if it is negative.
Therefore, I propose we add a calc.signum method with largely the same function: obtain the sign of a number.
We'd still have to hash out the details though, as the above behavior could potentially be viewed by users as inconsistent between floats and integers when we consider the number zero.
For one, the i64 behavior seems to be consistent with the mathematical sign function^3. However, f64's behavior is also technically correct, in a way.
We have the following choices (so far):

Specialize calc.signum to simply do the same as Rust (when given an integer, return -1, 0 or 1; when given a float, return 1.0, -1.0 or NaN).
Prefer consistency with the f64 approach and on the integer case use 1 for zero or positive and -1 for negative.
Prefer consistency with the i64 approach and on the float case use 0.0 for both +0.0 and -0.0.
Same as item 1, but also change the float case to return +1.0 for -0.0, since, in Typst, -0.0 == 0.0 is true.
Same as item 2, but also change the float case to return +1.0 for -0.0, since, in Typst, -0.0 == 0.0 is true.

Not sure which one would be the most appropriate (mathematicians, please reach out!). In principle, 1 or 4 would be the approaches which keep the most consistency with Rust (and also with the function's name, "signum"), while 2, 3 or 5 could be more user-friendly due to greater consistency (however, they could be less consistent with the function's name), but this warrants discussion.
Use Case
Finding the sign of a number is very useful in calculations where you'd like to retain the original sign of a number and later restore it or apply it to some other number (I've had to use this in tablex recently to be able to measure a negative length, for example - I apply abs to it and later multiply by its original sign). This is also the job of a f64::copysign function in Rust, which could theoretically also be added to Typst, but such a discussion would likely come after this one, so I'd consider it slightly off-topic for now.

Another option not mentioned above is working the same as (3), but returning +0.0 for +0.0 and -0.0 for -0.0.
Essentially, sign(x) = if x > 0.0 { type(x)(1) } else if x < -0.0 { type(x)(-1) } else { x }. I do believe this option has the most applicability in the widest range of use cases, as it aligns with the mathematical definition while keeping the flexibility of (2) — you get to differentiate between 0+ and 0- where that's required and elsewhere just use == 0 for a straightforward 0 check.

Another option not mentioned above is working the same as (3), but returning +0.0 for +0.0 and -0.0 for -0.0. Essentially, sign(x) = if x > 0.0 { type(x)(1) } else if x < -0.0 { type(x)(-1) } else { x }. I do believe this option has the most applicability in the widest range of use cases, as it aligns with the mathematical definition while keeping the flexibility of (2) — you get to differentiate between 0+ and 0- where that's required and elsewhere just use == 0 for a straightforward 0 check.

I don't think that's particularly useful, since #(float("+0.0") == float("-0.0")) returns true, so it's easier to just return +0 for both cases.

Since when do we prefer 'easier' approaches? /lh
My point is that for almost all use cases this is indistinguishable from (1), but if someone really needs to differentiate 0+ and 0- they still can.

As said somewhere else, I'd prefer to have calc removed in favor of methods on int and float, so any potential discussion should take this possibility into account.

As said somewhere else, I'd prefer to have calc removed in favor of methods on int and float, so any potential discussion should take this possibility into account.

I think that could definitely be suitable in this case, given that the behavior would differ between integers and floats. We could have int.signum() and float.signum().

I'd say this favors a design where calc.signum returns a number of the type it was given.


Flashing firmware is slow (> 5 minutes)

Web Bluetooth does not support specifying write with response or write without response when writing to a GATT characteristic. For performance, we need to be able to write without response. The LEGO bootloader (on movehub, cityhub, cplushub) has set both PROPERTY_WRITE_NO_RESPONSE and PROPERTY_WRITE which causes Chrome on all platforms except Android to write with response. This results in an extra BLE packet being sent back from the hub to the host for every packet sent which really slows down the firmware flashing process.

Just to say that also with this version of Chrome is required more than five minutes to flash the HUB, on Windows 10, 64 bit
Version 85.0.4174.0 (Official Build) canary (64 bit)

Control+ flashes in less than 2 minutes for me with the same specs (Win10 1909). What else could be different?

I'm using Win 10 Pro 1709 with this USB BLE Adapter:
https://www.amazon.it/gp/product/B082HJFXFS

I updated my desktop PC (Win10 Pro 1909) and still yet required >5 minutes to flash the HUB (about 8-10 minutes)
With my laptop (Win Home 1907) only about 2 minutes to complete the same operation
Same Chrome version

Chrome 85 has been in stable release for several months now, so closing.


Suggestion: https://github.com/hirak/prestissimo

ISSUE TYPE

Feature request

Suggestion: https://github.com/hirak/prestissimo
SUMMARY

speed up the installation process.
Goal

@mozgbrasil is on the way: https://github.com/devilbox/docker-php-fpm/pull/117


National Open University Of Nigeria

University Official website: https://www.nouonline.net/

URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university : https://www.admissions.nouonline.net/zzappl_ug.php

proof showing that the university recognizes the domain you submit as an official email domain for the enrolled students:

@hemhemoh There was similar request already, #14489. We had to reject it.
The problem is a lack of evidence that this domain belongs to the university.
However we made a second detailed review, and I believe that the domain is eligible for the trusted list now.
I merge this pull request. Please note: if the domain will be misused, we'd have to remove it from the trusted list.
Thank you!

@philipto Thank you very much.


Accessible on the host machine as http://localhost:8111/

Hello,
it says in your README-File, that i can connect from my host system by port 8111, but the vagrant config is set to :8000 and in my environment the client is only accessible via port 8000. Did i understand something wrong or is the README just misleading?
Thank you for your great work!

Hi @svschannak - thanks for reporting! I changed the port number in the most recent round of updates a few weeks back (057722f438134890ce55a1001775baa21a0eaa3b) but it looks like I missed updating the readme. Will fix this now...

Fixed in 22b0db582cf07447a1e8821706f580059258b30c


additional ENCODE/chromStates

Now, we process http://hgdownload.cse.ucsc.edu/goldenPath/hg19/encodeDCC/wgEncodeBroadHmm/ into "ENCODE/chromStates/Tier1/Cell/" hierarchy. The data are Tier1 and Tier2 only.
There are other chromatin segmentation data, http://hgdownload.cse.ucsc.edu/goldenPath/hg19/encodeDCC/wgEncodeAwgSegmentation/. It contains 3 types of data, "Chromhmm/Combined/Segway". The data are Tier1 only.
The "BroadHmm/ChromHmm/Combined/Segway" should be split by 4th column, used as "factor". Note that the "Segway" files are much larger that the others, but have good data.
Suggesting combining them. These types may be used instead of tiers. E.g.:
ENCODE
___chromStates
______BroadHmm (use as "source" in the file name)
_________Celltype (Tier 1 and 2, nine cells total)
______ChromHmm (use as "source" in the file name)
_________Celltype (they have Tier 1 only)
______Combined (use as "source" in the file name)
_________Celltype
______Segway (use as "source" in the file name)
_________Celltype

ROADMAP
___chromStates15 (use as "source" in the file name)
_________Group
____________EID (use as "celltype" in the file name)
_______________files


Create an admin section for the site

Including:

List or search users
Audit log including

user.created
user.sign_in
tweak.created
tweak.updated
tweak.forked
star.added
star.removed

Split out the audit log enhancement into its own issue at #456. There already is an admin section of the site since #415, so from here there should be more targeted issues around the admin section.


WIP - Chugga chugga choo choo

WIP - not ready to merge.
Just keeping an open PR so it's easy to follow my progress.

I've been enjoying learning how to use it. Really like it so far!

Ok, I have done a test merge of master into this branch and tested all of the UI, including the proof detail / save URL bits. All is working now

awesome! 🚂🚋🚋🚋

Awesome work @tyleryasaka !!


SSL Proxy with Kubernetes won't work

Describe the bug
Dear Support,
I may not have understood the documentation correctly, it's a bit thin on the ground regarding Kubernetes. But Orbstack's own reverse proxy for SSL does not work with Kubernetes. Neither for domains such as *.k8s.orb.local nor for services
To Reproduce

I have a fresh installation of Orbstack
Install Traefik for Ingress

# Install Helm first: https://helm.sh/docs/intro/install/
helm repo add traefik https://traefik.github.io/charts
helm repo update
helm install traefik traefik/traefik --namespace kube-system --set service.type=LoadBalancer --version 27.0.2

I install the following in kubernetes/orbstack

apiVersion: v1
kind: Pod
metadata:
  name: whoami-pod
  labels:
    app: whoami
spec:
  containers:
  - name: whoami
    image: traefik/whoami
    ports:
    - containerPort: 80
---
apiVersion: v1
kind: Service
metadata:
  name: whoami-service
spec:
  selector:
    app: whoami
  ports:
  - protocol: TCP
    port: 80
    targetPort: 80
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: whoami-ingress
  annotations:
    traefik.ingress.kubernetes.io/router.entrypoints: web
spec:
  rules:
  - host: whoami.k8s.orb.local
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: whoami-service
            port:
              number: 80

Expected behavior
with HTTP it works:
curl -I http://whoami-service.default.svc.cluster.local
HTTP/1.1 200 OK
Date: Tue, 13 Aug 2024 16:30:44 GMT
Content-Length: 253
Content-Type: text/plain; charset=utf-8

curl -I http://whoami.k8s.orb.local
HTTP/1.1 200 OK
Content-Length: 425
Content-Type: text/plain; charset=utf-8
Date: Tue, 13 Aug 2024 16:30:07 GMT

with HTTPS I got certificate errors
curl -I https://whoami.k8s.orb.local
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

The service won't work at all:
curl -I https://whoami-service.default.svc.cluster.local
^C

This happens with different MacOS versions. Do you have any advice or help?
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Fixed in v1.8.x.


Support for hit detection in styles with custom rendering

This fix is for Issue 8136. As per @ahocevar request defined new optional property for ol.style.Style type called hitDetectionRenderer and it is used if specified. If it is not specified logic in CanvasBuilder.drawCustom falls back to passed renderer. This is my first time contributing so I am new to the process.  @ahocevar you did mention in your comments that you wanted use hitDetectionRenderer when no custom renderer is specified. Still researching how to do that. Because that would mean recoupling drawing from hit detection instructions.

@ahocevar OK :) Sorry for the delayed response, had a long labor day weekend. So I will add tests and and example to your samples library. I need to think about what would be a good case to have different renderer for hit detection.

@ahocevar Hi Andreas, I am having trouble starting serve-examples while working on the example.  When I run npm run serve-examples I get an error:
[webpack-cli] Failed to load 'C:\Dev\openlayers_my_fork\examples\webpack\config.mjs' config
[webpack-cli] Error: Not supported

Any suggestion on how to fix this one?

@ahocevar Hi Andrea, added a sample for custom hit renderer, I kind of based it on the existing custom renderer sample for circle and showed that only label is used for hit detection. Let me know what you think. Thanks.

@ahocevar Hi Andreas, no sure why these unit tests are failing on the server.  All unit tests pass on my machine. Could it be that there is a race condition some sort? Thank you.

@ahocevar Hi Andreas, no sure why these unit tests are failing on the server. All unit tests pass on my machine. Could it be that there is a race condition some sort? Thank you.

Now Browser tests ran passed. I interesting.. @MoonE I have addressed all your requested changes.

@ahocevar any update on when this PR will be merged or any other feedback? Thanks.

Hey @ashchurova, sorry this is taking so long. Unfortunately I have been too busy with my day job and FOSS4G preparation. I'll be looking into it as soon as possible.

@MoonE, I think all your comments were properly addressed, but please double-check and approve when you're happy too.

@ahocevar @MoonE Yeay!! When do you plan to publish this change? Thank you.

@ashchurova It is already published on the dev tag. npm install ol@dev will pull that for you. It will of course be in the next release. We just published v6.8, and we publish releases approximately every 2 months.


change electro link to our new project site

Hey I finally setup a git hub project site for our project...  It would be great if you could link to that in you projects using.
I've used jekyll like once before and I think it's cool to edit those files directly?

Yep! Thanks!


[FEATURE] Support jakarta.validation annotations

Is your feature request related to a problem? Please describe.
I want to narrow the possible values for an arg provided by the LLM.
Describe the solution you'd like
Be able to declaratively define the expected format.
Simple form:
@Tool
fun scrambleWord(@Min(5) word: String): Boolean

The schema sent to the LLM specifies this argument has a requirement - min length of 5 characters.
Nested form:
@Tool
fun validatePerson(person: Person): Boolean

data class Person(
 @NotEmpty firstName: String,
 @NotEmpty lastName: String
)

The person schema sent to the LLM specifies Persons have first and last name which are not empty.
Describe alternatives you've considered
Add the instructions to the @Tool annotation manually.

@muliyul which LLM providers support specifying min length?

OpenAI supports a subset of JSON schema.
From these docs I presume this is only the beginning and support for real schemas will be supported eventually.
For reference here's the JSON schema definition of the constraint equivalent to @Min.

I guess we have to wait till some LLM provider implements this feature


Repro steps:
1.) Uncomment the following line in the Playground test app:
BABYLON.SceneLoader.AppendAsync("https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Models/master/2.0/Avocado/glTF/Avocado.gltf")
2.) Run the app
Potentially relevant Traces from the ARCore session
https://app.zenhub.com/files/189081889/a9b2c6a7-8957-480a-9336-e78bab8f01aa/download

I did the test but didn't get any error. Does it happen on a device? Can you check that your emulator opengl settings has opengl es 3+ enabled?

This repros for me on device.  Might be more apparent if you enter XR mode.


Website Revamp

Website revamp:

Full redesign for every page
Still needs accessibility to be added

@wyli, this is the website revamp.  I noticed some additional files in research that I left in the repo. Can you look at the file structure and see if I missed any other files that might be needed?  Otherwise, this should be good to merge in now.
I'll be running through accessibility features here soon and will merge those in whenever they're done.
Thanks!


add Laravel 11 support

@atmonshi I think you need to change testbench and phpunit version too.
@ryangjchandler can we show some love here please?

@mokhosh I'll get to this when I have time. I have seen the PR, but please do not ping or bump.

Sorry Ryan, thought it would be a simple merge. We could help if you have a list of tasks to be done.

@mokhosh It is a fairly simple merge, and I'll get to it when I have time. Sorry!

@ryangjchandler Laravel 11 has been officially released, any chance to get this merged?


[Perf] lower memory usage when loading multi-label datasets.

Hi. I found mmclassification consumed too much RAM. The image below is RAM usages of self-implemented code (top) and mmclassification (bottom) when training on 1M, 500 classes multi-label dataset. This is deadly when training on larger datasets like Open Image.

In this PR, I modified MultiLabelDataset and its child class VOC, and now it consumes less RAM when training on multi-label datasets. The image below shows performance improvement.

The inefficient RAM usage is mainly caused by multiple worker processes of DataLoader. According to document of torch.multiprocessing, tensors in Dataset will be copied to shared memory and shared with all dataloader workers, but numpy arrays are not. So, changing numpy arrays (i.e. labels) to tensors will save quite a lot RAM. But that's not enough, because copying massive tensors will reach limitation of max file handles, so I stack these tensors into a large one and keep an index of label for each sample.

Thx for your contribution!
We will review it recently

Updated multi-label evaluation test in tests/test_dataset.py, because now data_infos is dict instead of list.

Please merge the latest master branch and handle the conflict.

@jshilong Any update on this PR?