Daily Summary Report

Update (1/3/24): Leverage EDC Metrics for reporting and OPS monitoring

Prerequisite: External Cloud Metrics Team configures SWODLR log ingest in Cloud Metrics UAT/Prod venue.
Once the Cloud Metric Team import the CloudWatch logs to ElasticSearch, our team (SWODLR & OPS) can set up the dashboard and tools tailored to our needs.
Previous suggested dynamo DB dump approach requires us to read the entire database, filter the timestamp, etc. every night, which can be improved by leveraging EDC metrics.

9/27/23:
This daily report provides an overview of granules:

ingested       (PIXC/PIXCVec/Raster)
created         (L2_HR_Raster) - the initial request from the user was submitted
published     (L2_HR_Raster) - the product was uploaded to S3 and the user is able to download
downloaded (L2_HR_Raster)

Options:
(1) Use RDS to generate a daily summary report (work with Jackie to get a operation report e.g. db dump)
(2) Develop a dedicated SWODLR dashboard to monitor Cloud Metrics.
Refer to

OPERA visual report for ingestion, creation and publication. (based on Cumulus ingestion)
RDS for backfilling tool

Nightly report with a query for

each collection
query result is exported to a table and put on lapinta
status of user requests (e.g completion and failures)

closed due to duplication of swodlr#108


react-a11y-anchors should accept content when given a child component

react-a11y-anchors passes on the following snippets (assuming each line is a different file as I am focusing this issue on text and not href):
Hello world
<TextWrapper>Hello world</TextWrapper>

However, it fails on the following ones:
<TextWrapper />
<TextWrapper value="Hello world" />

It's not an uncommon situation, for example when rendering translated strings.
I think it would be reasonable to take eslint-plugin-jsx-a11y's approach: accept any React component as valid content, unless it has a aria-hidden prop.
Thoughts?

@astorije According to eslint-plugin-jsx-a11y, it should pass:

I am not sure if we should support this too, it might be out of this issue scope here.


Upgrade packages

I'm ok with updating benchmark or testing projects. But I'm not sure we should bump version for production related.


TS6059: File ../node_modules/ang-jsoneditor/ng-jsoneditor/ng-jsoneditor.module.ts is not under 'rootDir.

Getting below error while trying to use with Angular5, does anybody has idea how to fix this issue?
'rootDir' is expected to contain all source files.
error TS6059: File '../node_modules/ang-jsoneditor/ng-jsoneditor/ng-jsoneditor.module.ts' is not under
'rootDir' 'C:\GitRepos\ppc-admin-module\src'. 'rootDir' is expected to contain all source files.

See if this works for your case https://github.com/mariohmol/ang-jsoneditor


ENH: add method in RootResults of root_scalar and root

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like.
Add an attribute method to the result object of root_scalar and root.
Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
It is already hard to tell which method is chosen as default. It would be nice to have it at least in the return results object.

This seems helpful and not contentious. Will you submit a PR @lorentzenchr ?


Update pg9182's development fields

Hey @pg9182 checking if you're okay with this, i'm updating your development field a little bit to let people understand what Atlas actually means, since that work alone can be quite anything.

Letting @pg9182 merge this as it's his description.


Remove six from dependencies

If we're dropping support for py2.7 (are we?) we can remove the dependency for six.
It's used only to import range in single_image and single_image_psfs.

This is right. Let me do it.

Fixed already with commit fa9baf430b0f77a9b33ca0ec80725773d6ce34fd


Resolving TagHelpers from an assembly that only has runtime TagHelpers creates an error at design time.

If an assembly (Microsoft.AspNetCore.Mvc.Razor) only contains TagHelpers that have editor browsable never then we log an error in our binder syntax tree pass.

I temporarily worked around this issue to unblock tooling folks in this commit. We never used to validate that an assembly had TagHelpers in the old world so my temporary workaround might be an ok fix. However, the error was definitely intentional so it means there was a drive for it. Other fixes could be:

Have a property on descriptors, descriptor.EditorBrowsable, and then filter them out before returning any to the editor.
Leave the error but conditionally add Mvc.Razor tag helper bits based on if design time or not. This would result in the MvcRazorTemplateEngine signature changing to include a design time parameter.

Looking for opinions @rynowak / @pranavkm / @ajaybhargavb

Have a property on descriptors, descriptor.EditorBrowsable, and then filter them out before returning any to the editor.

Will doing this make it so that we create descriptor only for this error check and the ones with EditorBrowable set to false will be pretty useless otherwise?

Will doing this make it so that we create descriptor only for this error check and the ones with EditorBrowable set to false will be pretty useless otherwise?

yar

Close? I like the solution we ended up with.

https://github.com/aspnet/Razor/commit/dd9eab551d64aafbd9127497bd70a42e12300c1f


Python code identified as text/plain

Describe the bug
The attached code was identified as text/plain instead of python code. As it has quite a few typical patterns (import requests, defining a function) I think it may be worth adjusting the file identification.
To Reproduce
Steps to reproduce the behavior:

Upload the file  main.py.zip (pass: zippy)
Look at the file identification.

Expected behavior
File should be identified as code/python
Screenshots
Environment (please complete the following information if pertinent):

Assemblyline Version: <IP_ADDRESS>
Extract service: <IP_ADDRESS> (file was extracted, and the service is in privileged mode)

Additional context

This previous pull request should cover this sample and a few more, but it may not be good enough for the next one. Feel free to open an issue any time you find a file that is missed.
If you have a list of standard library functions that are often used by malicious python malware, I would be very interested. I feel like it may be a cat and mouse game with the current yara rule setup, as it could easily be bypassed by doing an import socket as so, and even flagging on import socket could be bypassed with import math, socket as so.
It may end up being needed, and doable with a regex, but we'd need to be wary of false positive for python identification.
Regarding the function definition, we are flagging it, but we are currently setup to require two strong indicators (or one executor from CybercentreCanada/assemblyline/issues/222).

Thank you for extending rules!
Yeah, I'm aware this is not an easy thing to identify everything. I think the current approach, libmagic + rules, is probably the best we have at the moment. I saw you were looking at Google's magika, what can be an interesting extension, but I do not know any better method, so I share examples when I think it could be important to properly mark :)
The idea of functions most often used by malware is quite interesting. I don't have any at the moment, although I started experimenting with Semgrep rules (what overcomes some troubles caused by the syntax flexibility, but requires knowing the language in advance) - so I may collect one at some point, then I'll share it. One interesting source, but I've already shared it, are rules from the GuardDog repository. But I think the current Yara rules are already quite strong.

Hey, I've run into another (not malicious) file with missed identification:
load_test.py.zip (pass: zippy). But it has a very string Python indicators, so it would be nice to include in the identification rules:

import asyncio
asyncio.run
import httpx
httpx.AsyncClient

httpx is the new requests with HTTP/2 support, so I expect broader usage over time in the malware.

Added a couple httpx and asyncio functions to the previous PR that wasn't merged yet, and merged it. They should all be identified correctly with the next release.
Thank you!


Gamee add cloudflare checkl

Gamee added cloudflare check & bots aint doing tasks anymore atleast for me
Pocketfi not working for me
Blum also off

cant see any error on blum logs it just doesnt clam, same for pocketfi, gamee cause of cloudflare i think

Gamee added cloudflare check & bots aint doing tasks anymore atleast for me Pocketfi not working for me Blum also off

Yes, Cloudflare will stop new account log-ins. For those lucky enough to have signed in before the Cloudflare check, the script will keep on claiming. We have seen a number of games add Cloudflare, and then later remove it (probably when they fall into the $200/month tier!).
Blum will be something to do with the proxy not working correctly, I suspect. It makes certain changes to the header structure to allow the connection to Blum. Unfortunately, it's working fine for me, so I can't recreate the issue.
Do you have yesterday's update to the PocketFi script? They changed some elements of the layout, and we updated the script yesterday to fix it.
Thanks.

Gamee added cloudflare check & bots aint doing tasks anymore atleast for me Pocketfi not working for me Blum also off

Yes, Cloudflare will stop new account log-ins. For those lucky enough to have signed in before the Cloudflare check, the script will keep on claiming. We have seen a number of games add Cloudflare, and then later remove it (probably when they fall into the $200/month tier!).
Blum will be something to do with the proxy not working correctly, I suspect. It makes certain changes to the header structure to allow the connection to Blum. Unfortunately, it's working fine for me, so I can't recreate the issue.
Do you have yesterday's update to the PocketFi script? They changed some elements of the layout, and we updated the script yesterday to fix it.
Thanks.

morning, imo cloudflare shouldnt be hard to bypass?
you right about gamee couldnt add new accounts is just that old accs stop working too other bot im using doesnt get flagged.
about pocketfi tried with update yesterday was forced to swap to another bot cos it doesnt claim, just let the coins burn,
blum for me couldnt claim same as pocketfi you get 0 errors yet nothing is working
Thanks for pushing updates btw <3

If you work out how to overcome Cloudflare, please contribute the solution here too :)

If you work out how to overcome Cloudflare, please contribute the solution here too :)

Why would i , already have other bot working

You said it wasn't hard to bypass, I though you might have an idea how to do it.

You said it wasn't hard to bypass, I though you might have an idea how to do it.

 Why? "

Because it's for the community. If you don't want to share something with the community, don't waste our time.

Yeah, I am pissed off at someone who does nothing but ask for something and doesn't "waste time" .

"If you can't bypass Cloudflare in 2024, quit doing bots and get back to Pokémon."

And you can't do either, so stop blaming people because you don't want to waste your time. I don't want to waste my time talking to kids who think they are gods. You are just muppets.
see ya


test

@itzmashy : Thanks for your contribution! The author, @craigg-msft, has been notified to review your proposed change.


Change relevant methods in World and co to return ResMut

Objective

Fixes #11765

Solution

Changed the current implementations to use ResMut instead of Mut

Changelog

In World: resource_mut, get_resource_mut, get_resource_or_insert_with now return ResMut / Option<ResMut> and resource_scopenow accepts a function parameter of type impl FnOnce(&mut World, ResMut<R>) -> U
In UnsafeWorldCell: get_resource_mut now returns Option<ResMut>
Changed internal uses of these methods to use ResMut aswell.
ResMut<R> now implements From<Mut<R: Resource>>

Migration Guide

For most use cases this should not require any action besides changing Mut<T> to ResMut<T> since they are very similar to each other and  Mut<T> implements From<ResMut<'w, T>> for Mut<'w, T>. But you could just call .into() if any problems arise.

Thank you for the PR, we're likely going to move forward with the direction described in #11825


Use crontabs as opposed to keeping the process open

It would be nice if we could feed app.py an argument, which when set instead of keeping the process open it just checks once then pushes any changes to webhook then quits. This way instead of leaving the process open 24/7 people can just setup a cron and have it set to run at whatever frequency they want which will run the app, push any changes to discord then exit

Are you referring to doing the p4 changes check outside of the process of this script?


Improve test coverage and ensure immutability of FieldDefinitions

Upcoming feature work to create storage versions of resources and other types will be based on creating new structs; to ensure that there are no untoward issues with that, I wanted to improve the test coverage of several foundational types and ensure that the values are immutable - and thus safely shared.
This PR addresses test coverage and immutability of FieldDefinition, fixing a few minor bugs along the way.

Pull Request Test Coverage Report for Build 169649823

-5 of 17 (70.59%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 27.142%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/jsonast/jsonast.go
0
5
0.0%

Totals

Change from base Build 169347269:
1.0%

Covered Lines:
1625

Relevant Lines:
5987

💛  - Coveralls


Add cardinal submodule

Job VTB Documentation on adfc19e wanted to post the following:
View the site here
This comment will be updated on new commits.

@aprilnovak
anything we could do better to get all green on cardinal? What are your thoughts on these two nek inputs from the pbfhr reflector?
What are the current failures from? Logan mentioned some jit issue?
Do you thing we ll be able to get a few time steps in 300s on 16 cores?

Errors like this means that Nek has run out of memory:
relocation truncated to fit: R_X86_64_PC32 against `.bss'

Unfortunately the Nek simulations are pretty big. What approach is VTB taking for the other non-Cardinal Nek models (like the MSR)?

And I can fix the run_openmc test - that input file as-is can't be run outside of the multi-app coupling (its initial temperatures are set by MOOSE, but running just the standalone input file causes those initial temperatures to be set to zero, hence the error). It just needs a minor change.

ok let me try this initialization and giving the other one more cores (so more memory probably? @loganharbour )
then I ll think it ll be enough for this one and we can pursue this in another PR

Well I tried.
Those 3 tests will be fixed in a later PR if possible. 2 of them are stretching our testing infrastructure, one may require more analysis

We could start transitioning some testing to HPC machines if needed

From the docs it seems we only need 48 cores to run them.
Build farm has this, but should VTB get a pass on using that much computing?

Each EPYC machine is 64 procs per machine, split up into 3 clients

any way to book the full machine for VTB tests?

Nope


fix: Make vault shell command work

Apart from making it possible to run a shell at all I made it easier to give a different command with arguments. Instead of
jx secret vault shell -s vault --args kv --args get --args secret/jx/mavenSettings
you can do
jx secret vault shell vault kv  get secret/jx/mavenSettings
Fixes: #340

Hi @msvticket. Thanks for your PR.
I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @jstrachan

I noticed the the tests doesn't go through cleanly on the main branch. With this PR it should be the same errors...

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


When over a moving platform in TPS mode: Camera can move jumpy and avatars can execute walk animations

Does this keep happening?
At least when seeing my own avatar in 3rd person, I no longer see it walking.

We need to validate if other avatars appear walking when they are on moving platforms.

I recycled this issue to just point to the moving platform 3rd camera jittering.

The own avatar walk animations while being on moving platforms issue has been fixed long ago.

The walk/jump animation on other avatars while being on moving-platforms will be tackled in the following issue:


fix: fix mstore not ceiling to next byte when offset

Related to: https://github.com/orgs/sayajin-labs/projects/3/views/6?query=is%3Aopen+sort%3Aupdated-desc
Goal of this ticket is to remove the SKIPPED test about mstore.
Currently when there is an offset we increase the memory with the exact necessary size but normal behaviour should be to expand memory to next byte (see for example evmjs implementation
Current PR add a test and remove the skipping of the current one in mstore
Pull request type
Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Lgtm


 But web VEP does not show option to annotate regulatory feature. This PR enable option for regulatory region consequences in webVEP.
NB: also adding a small update to VEP plugin documentation for CADD.
Test
sandbox: http://wp-np2-11.ebi.ac.uk:7070/Gallus_gallus/Tools/VEP/Results?tl=ztzzZXLJ16krSpEU-40
(plugin doc) http://wp-np2-11.ebi.ac.uk:7070/info/docs/tools/vep/script/vep_plugins.html#cadd

Could you please move to postreleasefix/111, @nakib103?

@jgtate , I could not change the base branch, it was adding more commit. Created a separate commit instead - https://github.com/Ensembl/public-plugins/pull/754


Add options for books on kobo e-reader

Add new arguments for e-reader
--book_from <E-READER> to specify connected e-reader (Only support "kobo" now)
--device_path <PATH> to specify path of mounting point
If these two options are specified, obok.py would check mounting point
of device, and show a list of available epub files in /MOUNTING/POINT/.kobo/kepub
User input the number of book need to be translated, then the decrypted epub
would be save to current directory. And this epub file would be pass to
epub_loader.
Usage would be like:
python make_book.py \                                                                                1
  --model gpt3 \
  --language "Traditional Chinese" \
  --book_from kobo \
  --device_path /run/media/pham/KOBOeReader/

Add obok.py as file selector for kobo device
Source: https://github.com/apprenticeharper/DeDRM_tools/blob/master/Obok_plugin/obok/obok.py
Since scripts in DeDRM_tools has no unified lisence. Directly copy
obok.py maybe a litte tricky. ^1
So I mail to maintainer of DeDRM, asking for the permission.
Now waiting for his/her response.

@Arborym Python ninja huh? Please tell me which syntax checker you are using. (I have few experience about coding in Python)

@typebrook can you fix the conflicts?>

Sure

Thanks!

@Arborym Python ninja huh? Please tell me which syntax checker you are using. (I have few experience about coding in Python)

I just use standard Pylance and Pylint in VS Code 🙂


[bug] MetaMask not installed when Rabby enabled

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.12.9
wagmi Version
0.12.12
Current Behavior
When click MetaMask button, it shows MetaMask not installed(actually both Rabby and MetaMask installed)

Expected Behavior
Open Rabby or MetaMask when I click MetaMask button
Steps To Reproduce

Enable Rabby and MetaMask
Open https://lenstube.xyz/
Click Connect

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://lenstube.xyz/
npm init @rainbow-me/rainbowkit@latest also can reproduce
Anything else?
it works before, looks like can't works after https://github.com/rainbow-me/rainbowkit/pull/1037 merged, I tried to debug but can't find the reason

Rabby is overriding window.ethereum and thus blocking dApps from using MetaMask. We have reached out to their team to adopt a window.ethereum.providers standard that can mitigate this. You'll either want to use Rabby's "default wallet" toggle (and refresh the page) to force Rabby to let dApps connect to MetaMask, or you'll want to disable one of the extensions at a time. An unfortunate industry standards issue. We're working with the community on adopting EIP-5749 or a similar standard.

any doc for how window.ethereum.providers work?

I'm on "@rainbow-me/rainbowkit": "^0.12.9" and "wagmi": "^0.12.12" with only Rabby enabled, Metamask disabled
plus this mode on Rabby

but choosing Metamask would not work with Rabby

Please feel free to try on https://bridge.arbitrum.io/
but it worked with https://www.rainbowkit.com/docs/introduction

Yes, thats why I create https://github.com/rainbow-me/rainbowkit/pull/1187 for temporarily fix before Rabby adapt with eip-5749

@vvvvvv1vvvvvv That is unfortunately not a viable solution.

I guess it caused by Rabby set isMetaMask and isRabby same time, like:

if no isMetaMask found, Rainbowkit will use Browser Wallet
if isMetaMask found, Rainbowkit will use MetaMask
if isMetaMask and isRabby found, Rainbowkit will not use Browser Wallet and MetaMask is not installed since Rabby is installed

That's why I think we should make isMetaMask() return false when isRabby found like other wallets

again, please merge https://github.com/rainbow-me/rainbowkit/pull/1187 to fix this issue, we have received many connection issues from users

Hello, here we are also having the issue @DanielSinclair  testing locally is working but on production is not detecting the wallet

@vvvvvv1vvvvvv @DanielSinclair we make it work Rabby downgrading the next packages

"wagmi": "0.12.1"
"@rainbow-me/rainbowkit": "0.12.7",

Still the issues with the persist on walletconenct and not connecting with coinbase

@nico-limo You can downgrade to Wagmi 0.12.11 for now

The reason is:

Rinbowkit check ready state of connector, and not ready means not installed in https://github.com/rainbow-me/rainbowkit/blob/main/packages/rainbowkit/src/wallets/useWalletConnectors.ts#L88
wagmi will always return false on ready check when window.ethereum.isRabby found in https://github.com/wagmi-dev/references/blob/main/packages/connectors/src/metaMask.ts#L61

So it means Rainbowkit should always use the same wallet list as wagmi for those have isMetaMask but not MetaMask wallets.
I will create a PR for sync the wallet list from wagmi then you can merge it for a quick fix

Any update for a fix on this @DanielSinclair ?

@ConnorSB13 This fix is available as 0.12.13


Obtain path IDs on a branch

I tested skan on one of your test data (see screenshot below). I would like to obtain the node IDs for a given branch. In this case,

branch
end points
path IDs I want

0
(8,13)
(13,10,11,7,5,4,3,2,1,6,8)

1
(8,13)
(8,9,13)

2
(8,14)
(8,12,14)

3
(13,17)
(13,15,16,17)

I checked the attributes of the Skeleton class, but I can't find this information.

Thanks for your interest in skan, @CsatiZoltan! You simply need the path(i) method:
https://jni.github.io/skan/api/skan.csr.html#skan.csr.Skeleton.path
Hope this helps! Please reopen if it is not what you were looking for!

Perfect! Thank you for the quick response. My bad, somehow I didn't notice the path method.


💚 Fix CI build

Make CI great again :D
Pull Request Checklist

[x] I have read the UME contribution document and understand how to contribute, commit the code according to the rules. 我已阅读过 UME 贡献文档，并了解如何进行贡献，按照规则提交了代码
[ ] I have added the necessary comments in code to ensure that other contributors can understand the reason for the change. 我在修改中已经添加了必要的注释，以确保便于其他贡献者理解修改原因
[ ] The code has been formatted by dartfmt before push. 代码在提交前已经经过 dartfmt 进行了格式化
[x] Change does not involve the adjustment of test cases. Or all existing and new tests are passing. 改动不涉及测试用例调整，或 example 工程与单元测试已经完全跑通

Blocked by #72.

#72 has been merged. @AlexV525

Drive test passed locally, we can rerun the 31-drive and see if any further exceptions occurred.

https://github.com/bytedance/flutter_ume/actions/runs/3079873526/jobs/4977401255#step:4:623
@AlexV525 Does it look like there is a problem with the container?

As it turns out it's the emulator exception, API 31 won't work in the action.


"Styled" sample using inaccessible layer

The "styled" example in the gh-pages branch is using a service that throws a "token required" error.
https://github.com/Esri/cluster-layer-js/blob/gh-pages/styled.html#L241
Service URL:
http://services1.arcgis.com/EwZCWiHAzgPcnGng/arcgis/rest/services/Magnitude_7_Earthquakes/FeatureServer/0

bump

All fixed a while back. Thanks guys!


Support for soft navigation

soft navigation replaces just the main content of the pages without actually navigating away from it.
We should track it, by recording a leave checkpoint in the initial url and enter in the new url

@trieloff looking at the RUM instrumentation you did for softnav in helix-website, it seems there is no need for changes in helix-rum-js. With the existing checkpoints is enough

Closing as:
soft navigation can be tracked in RUM calling sampleRUM('leave')  before loading the new content, and:
sampleRUM('enter', { source: 'softnav', target: oldhref });  just after pushing the new state to the window history.
See https://github.com/adobe/helix-website/pull/391/files#diff-fbceb58f32b99b8a5309251f8c49ac8eda82fba58b905c600c92bce1ed2a1c8cR566 for a reference implementation


kURL installation in Amazon linux 2 breaks less command

The following error was observed when executing less command after kURL installation finished.
less: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory

This is to do with missing libraries.
The libtinfo.so.5 library is missing. This is often due to older library version names being referenced and it breaks the app requirements. As AL2 is centos based there might be a newer version of the library.
I've checked my AL2 install (home lab) and it doesn't include the libtinfo.so.5 file, it does however include the libtinfo.so.6 file which is a more recent version. In theory a symbolic link could fix the issue:
sudo ln -s /usr/lib64/libtinfo.so.6 /usr/lib64/libtinfo.so.5

Hi @jdtate101
This is breaking our AM2 instances using the latest AMI provided by AWS
We are paying customers and we need this to be fixed ASAP
Thanks
cc @Joe2daB

Hey @tbenattar thanks for raising this issue. This should be fixed by this PR being release https://github.com/replicatedhq/kURL/pull/2936


Update first_dl.py

test

Given this PR has no description on what problems it tries to solve, and the number of files that needs to be committed is questionable, let's close this PR without merge.


Adaptive quantum computing notebook samples

This change introduces two notebook samples that demonstrate adaptive quantum programs:

Iterative phase estimation.
Repeat until success.

Thanks for getting these updated! I'll review the text soon. There's one detail about the integration tests: they automatically execute notebooks in the folder unless they are on a list of notebooks to skip. Since these includes submission to the service they aren't expected to run e2e in CI and can be added to that skip list.


Dynamic Selectors - Not exists at all pages

I am using the Pjax at the navigation menu and switching some selectors at the page. My issue is that there is a class that exists only at the website homepage and I like Pjax to add it when the user browses to the homepage and remove it when the user browses to another page.
Are there is a way to do it without bypass the Pjax object?

It will be nice to add some fallbacks selectors like on falsandtru/pjax-api (he call the selectors areas) http://falsandtru.github.io/pjax-api/


add load partition

fix #12

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Refactor implementations of TranslatePk

We recently refactored the TranslatePk traits but did not do all the implementations.

Patch 1 trivial cleanup.
Patch 2 does the remaining implementations.
Patch 3 shortens other instances of the translatefpk[h] identifier so as to be uniform.

Thanks for the review, I get a bit trigger happy when I'm learning a new codebase so feel free to be heavier on the NACK's for miniscript refactorings from me in the first few months :) There is a risk of some code churn as I play with the traits and trait bounds but I think its worth it to make the code as simple as we can.

Relatedly, I have a plan for changing all the awkwardly named TranslatePk* methods into a single Trait but got sidetracked. The current TranslatePk<P, Q> instead of operating on two function parameters, would operate on a single trait object. The trait object would have methods for translate_fpk, translate_hash, translate_time etc.
The main idea here is to allow users to specify hash values and time values in generic form. We implement these are additional associated values for MiniscriptKey so that write something like
let htlc = "or(and(pk(A),sha256(H)), and(pk(B),after(expiry))"

Hopefully, I can get it out in a few days for review.


Handle type disambiguation for which_oneof

Closes https://github.com/caikit/caikit/issues/256
Make sure that when inferring the which field from the python type, the  value of bool < int < float is respected

@gabe-l-hart thanks for the pointer. Originally I only looked in test_base.py. Both should be addressed.


Crash after scanning the document

I am using document_scanner: ^0.1.1.
When app scan the document, and when i am using scannedImage.getScannedDocumentAsFile() for getting File, Its getting crash with below message.
java.lang.IllegalArgumentException: Requested path /data/data/com.abc/cache/documents/cc53d53c-1ac2-405f-b1b4-b01cc53c028e.jpg doesn't appear under [/storage/emulated/0]
my flutter doctor -v is
[✓] Flutter (Channel stable, 2.0.4, on macOS 11.2.3 20D91 darwin-x64, locale en-IN)
    • Flutter version 2.0.4 at /Users/ankitpanwar/Library/Flutter/flutter
    • Framework revision b1395592de (3 weeks ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/ankitpanwar/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Connected device (2 available)
    • Redmi Note 8 Pro (mobile) • u8kftw59gio7qkjr • android-arm64  • Android 10 (API 29)
    • Chrome (web)              • chrome           • web-javascript • Google Chrome 90.0.4430.72

• No issues found!

I just tried it in a new project and it worked as expected.
Please share a code snippet of how you're using scannedImage.getScannedDocumentAsFile()
and the value of scannedImage.croppedImage. You can output it using : print(scannedImage.croppedImage);

Hi, thanks for the reply.
here is my code
  Future<void> _onClickScanDocument(context, ScannedImage scannedImage) async {
    print("ScanDocument: ${scannedImage.toJson()}");
    if (scannedImage.croppedImage != null) {
      if (widget.from == VALUE_INTRO) {
        _bloc.fileSink.add(scannedImage.getScannedDocumentAsFile());
      } else {
        Navigator.of(context).pop(scannedImage.getScannedDocumentAsFile());
      }
    }
  }

and here is the scanned image data
I/flutter (22635): ScanDocument: {"croppedImage":"file:///data/user/0/com.possibility.algo/cache/documents/1dd202ad-0653-4dda-9b2a-b30bd646842c.jpg","width":499,"initialImage":"file:///data/user/0/com.possibility.algo/cache/documents/b1e0f7da-54b9-43e5-a2a9-05f91dd9f1e7.jpg","height":888}

Please check version 0.1.2 if the problem is resolved. I can't confirm it, because the problem isn't occurring on my device.

Thanks @eliasteeny for quick support, version 0.1.2 fixed this issue.


Colorscheme "one" not working as expected

I'm having the exact same issue as #263 and #280
#280 doesn't talk about how they fixed it. Other colorschemes seem to work fine for me though.
I just installed the plugin using Vim Plug, I've also tried to run an update (PlugUpdate) but to no avail.
The colours now look like this:

After looking at the code for "one" a bit, it seems to be a problem with the selection of the Light or Dark theme?
It seems to be selecting the light theme, while I expect it to select the dark theme.

Please check the output of :hi Normal and :echo lightline#colorscheme#background().

:echo lightline#colorscheme#background() returns Light
:hi Normal returns Normal    xxx cleared

So :echo &background echos light too, right? Then you are using the light colorscheme and lightline selects the light colors. Please set background=dark if you prefer the dark colorscheme.

So adding set background=dark which worked to switch to the dark timeline. Thanks!
However, it seems that the colours I get is different from the colours in the readme. Is this due to the fact that the screenshot is not correct? Or are the colours I'm getting not correct?

Are you using Vim in a terminal? The screenshots in README.md are captured with GVim so terminal colors are different. But if your Vim supports termguicolors (check :echo has('termguicolors') to be 1), set termguicolors will help.

@itchyny Ahh, that's it then. Thanks for the help and the quick responses. I'll close this now.

So :echo &background echos light too, right? Then you are using the light colorscheme and lightline selects the light colors. Please set background=dark if you prefer the dark colorscheme.

Interesting enough, For both :echo &background and :echo lightline#colorscheme#background() I get light, yet I still don't get a light color theme?

Thanks!

So :echo &background echos light too, right? Then you are using the light colorscheme and lightline selects the light colors. Please set background=dark if you prefer the dark colorscheme.

Interesting enough, For both :echo &background and :echo lightline#colorscheme#background() I get light, yet I still don't get a light color theme?

Thanks!

You seem to use the default colorscheme which does not have the light variant.

You seem to use the default colorscheme which does not have the light variant.

You seem to use the default colorscheme which does not have the light variant.

Ah! Makes sense. Unfortunately, I tried with one and PaperColor. Still the same results 😞

Thanks for your help ☺

You seem to use the default colorscheme which does not have the light variant.

Ah! Makes sense. Unfortunately, I tried with one and PaperColor. Still the same results 😞

Thanks for your help ☺

Move the config before call plug#end() might fix it.

Move the config before call plug#end() might fix it.

Unfortunately, it didn't 😢 I'm using kitty (default TERM=xterm-kitty) as well, not sure if that's relevant. I tried exporting TERM=xterm-256color and setting the colors in .vimrc like you in the README, but no luck.
Perhaps it's something on my end, but can't seem to figure it out. I'll keep on playing with it. Let me know if any solution pops up! Thanks for your time.

Unfortunately, it didn't 😢 I'm using kitty (default TERM=xterm-kitty) as well, not sure if that's relevant. I tried exporting TERM=xterm-256color and setting the colors in .vimrc like you in the README, but no luck.
Perhaps it's something on my end, but can't seem to figure it out. I'll keep on playing with it. Let me know if any solution pops up! Thanks for your time.


Create Paneled Experience in Federation Admin UI

Ref: Figma
Initialize side main panel experience of the admin ui dashboard. Main panel would just contain the elements we presently have prototyped in the admin ui

cc @IgboPharaoh

Great, I'll start working on this.
I'll look through the design and send any possible questions


Backend for Node package.json license field

See here: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#license
We should add a new backend for parsing these files. Should be pretty straight-forward.
Note: We'll need the tar iterator first for this to work as these are inside of tgz files like: https://registry.npmjs.org/node-version/-/node-version-1.0.0.tgz

@hyandell Very helpful, thanks!
Is the DESCRIPTION file one that is part of the node packaging spec at all?
And as for .spec and .spec.in aren't these just the .rpm spec files? (Which we should definitely parse and we could open a new issue about that...)

DESCRIPTION is R. And yes, spec are rpm.
My thinking was that one plugin would be handling this, rather than individual plugins, so I took this entry to be for-all except you'd only listed npm :)

@hyandell I created https://github.com/awslabs/yesiscan/issues/14 for R. TIL about their DESCRIPTION file. Cool! Can you make one for RPM spec files please? Please discuss whether we should actually handle the common templated files like spec.in or not. This would be a new backend. You might also want to discuss whether we want an iterator (different issue) for opening .rpm and .srpm files.
Thanks!

Where are we on this?  can we create a list of action items and check which ones are complete and what not?


feature: improve os detection for inventory page

Hello,
I wanted to use inventory page but it only works with few linux OS. Here is my proposal to support many OS. I have introduced a new parameter named INVENTORY_FACT_TEMPLATES to keep customization. This parameter is used to customize cell display using jinja. Default INVENTORY_FACTS has been changed to use trusted and os facts.
It has been tested with Puppet agent >= 5 to 7:

Windows (Pro, Server 2012/2016/2019)
MacOS
Debian Family (Debian, Ubunut, Linux Mint, etc.)
Redhat Family (RedHat Enterprise, Oracle Linux, CentOS)
Suze Family (SUZE Enterprise)

With puppet agent 4, windows os will display nothing.
It should fix #485.
What do you think about this changes ?

I have pre-released this in v4.1.0rc3. It would be great if we could add a screenshot of the Inventory view showing nodes with various OSes for the final v4.1.0 release that I would like to do in a few days. Can you provide such screenshot, @melck? I don't have nodes with other OS than Linux in my infrastructure...


python37Packages.txtorcon: 18.3.0 -> 19.0.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-txtorcon/versions.
meta.description for python37Packages.txtorcon is: '"Twisted-based Tor controller client, with state-tracking and configuration abstractions"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 19.0.0 with grep in /nix/store/knpxalkdgv9jna1plqk61wcnnqagn1zs-python3.7-txtorcon-19.0.0

directory tree listing: https://gist.github.com/28d9e95bcae2c9e9a6eac584513c0802

du listing: https://gist.github.com/4a47b192dd2f9a6d852dda0f78d8d255

Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)
6 package rebuild(s)
6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
magic-wormhole
python27Packages.magic-wormhole
python27Packages.txtorcon
python37Packages.magic-wormhole
python37Packages.txtorcon
transporter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/knpxalkdgv9jna1plqk61wcnnqagn1zs-python3.7-txtorcon-19.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.txtorcon https://github.com/r-ryantm/nixpkgs/archive/134e95acf1858d3d31b012e847ecc1149bbb6b40.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/knpxalkdgv9jna1plqk61wcnnqagn1zs-python3.7-txtorcon-19.0.0
ls -la /nix/store/knpxalkdgv9jna1plqk61wcnnqagn1zs-python3.7-txtorcon-19.0.0/bin

cc @jluttine for testing.

nix-review looks good.

nix-review looks good.


Include match if statement in complexity

A match statement can have an if guard. At the moment this is not considered, it should increase the complexity.

Resolved in 428f0a893b637e6604038d03563732292d29eaef


AVX2: dgemm on HASWELL leads to invalid results (low accuracy)

After upgrading Scilab OpenBLAS build, we detected a poor precision result impacting dgemm when using AVX2 kernels.
With OpenBLAS 0.3.27:
$ OPENBLAS_CORETYPE=NEHALEM scilab/test_dgemm
[1, 0.666667] * [-6 0 ; 9 0]
        0       0

$ OPENBLAS_CORETYPE=HASWELL scilab/test_dgemm
[1, 0.666667] * [-6 0 ; 9 0]
        -3.33067E-16    0

With refBLAS 3.12.0 :
$ scilab/test_dgemm
[1, 0.666667] * [-6 0 ; 9 0]
        0       0

test code

#include <math.h>
#include <stdio.h>

extern void dgemm_(char *transa, char *transb, int *m, int *n, int *k, double *alpha, double *a, int *lda, double *b, int *ldb, double *beta, double *c, int *ldc);

int main()
{
    int ONE = 1;
    int TWO = 2;
    double dZERO = 0;
    double dONE = 1;

    double A_tab[] = {1., 2. / 3.};
    double* A = A_tab;
    double B_tab[] = {-6., 9., 0., 0.};
    double* B = B_tab;
    double C_tab[] = {NAN, NAN};
    double* C = C_tab;

    dgemm_("n", "n", &ONE, &TWO, &TWO, &dONE, A, &ONE, B, &TWO, &dZERO, C, &ONE);

    printf("[%lG, %lG] * [%lG %lG ; %lG %lG]\n", A[0], A[1], B[0], B[2], B[1], B[3]);
    printf("\t%lG\t%lG\n", C[0], C[1]);

    return 0;
}

We were compiling without DYNAMIC_TARGET thus selecting NEHALEM arch as the minimal supported target. All the opened bugs are due to a more active cross-checking of Windows vs Linux results on our test base after the GCC 8 to GCC 11 Linux migration.
Note: all these corner-case bugs might or might not be valid at some points; eg. in that case, EPSILON might be acceptable in most codebases.

Symbolic result is e-7 off, so both code paths do very well at rounding artifacts


Fix leak of extension-controlplane-shoot-webhooks ManagedResource

How to categorize this PR?

/area ops-productivity
/area usability
/kind bug
What this PR does / why we need it:
This PR eliminates a race condition that led to a leaked managed resource extension-controlplane-shoot-webhooks during shoot deletion (see #8688 for more details).
Unlike before, the said ManagedResource is only updated when all shoot namespaces are reconciled. Creation won't happen anymore in this scope.
Which issue(s) this PR fixes:
Fixes #8688
Special notes for your reviewer:
/cc @Kostov6 @ialidzhikov
Release note:

An issue was fixed that sometimes led to leaked `extension-controlplane-shoot-webhooks` which blocked the shoot deletion.

/assign

@Kostov6 thanks for the feedback!

Just an initial question from my side: isn't it more clearer to use createOnReconcile instead of createOnUpdate

I can rename it 👍
Any additional feedback from your side @rfranzke?


Does not work with Magisk 21.

I have installed latest Magisk stable (v21) installed onAndroid 10, however Energized Protection refuses to run.  Output below:
` # ep -m

Version: 21.0 - not supported.
Exiting...

`
Any hope that a fix for using on Android 10 with Magisk stable will arrive?

The update to v1.3.3 of the module should fix this, re-open if necessary.


Fix resolving bug on changing layout and optimized memory usage

Due to the changes in 46817a38. We have a bug if the layout changes.
This PR fixes this bug and adds a test for it.
Additionally it correctly marks negative percentage values as undefined dim.
It also changes the resolvedDimensions to use a reference instead of the full value in order to minimize the memory requirement of a YGNode and reduces the copying of the YGValue.

Do you think this will fix the issue I'm having in #378

@dshahidehpour I think the problem you encounter is a different one. Did your problem existes before the change in 46817a3 ? If it is then this is not the same.
The problem I fixed here is, if you swap from defined height to undefined height, then it takes the previous definied height.

@woehrl01 ahh, sounds like I still have a YogaKit bug

Could you squash & rebase. The PR failed to import

Will do


Migrate to ReScript syntax

Blocked by https://github.com/rescript-lang/rescript-compiler/issues/5104 (if we want to use bsb -format).
Otherwise we should investigate if we could remove class (I have to admit I never really checked the reason, if they are mandatory or not and if we could rewrite bindings without using them - poke @cem2ran which wrote initial bindings in #20).

They won't be added back into rescript syntax. I guess we could just use convert class type to records and external using @send if necessary.

Hi @cem2ran ! I commented your PR, did you saw it?


Can we combine ActiveHost and OpenPort?

I am thinking that using only one interface will be easier for developers to use our package.
Moreover I think it will be easier to maintain if we will work with one object for hosts.
Can I create pr that will use OpenPort inside ActiveHost and remove the IP from it?.

So in that sense, ActiveHost will have List and PortScanner will also return ActiveHost after the scan is completed. Right?

So in that sense, ActiveHost will have List and PortScanner will also return ActiveHost after the scan is completed. Right?

Exactly.
ActiveHost will have List of ports and get returned from PortScanner.

Yeah we can go ahead with this change.

Thanks
PR got marged so I am closing this issue


FSDP Example for T5 Fine-Tuning and PyTorchJob

Related: https://github.com/kubeflow/training-operator/issues/2040
I added simple FSDP example for T5 fine-tuning and PyTorchJob.
I refactored example from the PyTorch tutorial: https://pytorch.org/tutorials/intermediate/FSDP_adavnced_tutorial.html
/assign @kubeflow/wg-training-leads

cc @kuizhiqing @Syulin7

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
66

Relevant Lines:
66

💛  - Coveralls

Good work!
/lgtm

Thanks for the review!
/approve

@tenzen-y Actually, we disabled it as part of this PR: https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2271.
That will help us to accidentally merge PRs that are not ready to be merged and got /lgtm from GitHub members.
Not all contributors add the /hold label if PR is not ready.

@tenzen-y Actually, we disabled it as part of this PR: https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2271.
That will help us to not accidentally merge PRs that are not ready and got /lgtm from the GitHub members.
We noticed that, not all contributors add the /hold label if PR is not ready.

That makes sense. Thank you for clarifications. That seems the limitations (accidentally merging)  for collaborations between GitHub Actions and Prow :(


Find References feature broken

Whenever I try to issue a find references command, I get this output instead.
[LC] [Info] [Error] Parsing the command failed. Command: {"params":{"identifier":"liftEff","namespace":"value","module":"Control.Monad.Eff.Class"},"command":"usages"} @(main:Command.Ide app/Command/Ide.hs
:187:17)

Using PureScript 0.12.5, latest purescript-language-server.
Client is LanguageClient_NeoVim, and invoked using the built-in function LanguageClient_textDocument_references() which gives references of the identifier under cursor.

This works for me with vscode/purs 0.13.5 - but should be available on 0.12.5 I believe.
I published a new version of the language server last night - was this working prior to that change, or has this never worked for you?

I didn't update in the last two days. Will update and see.

Just updated to 0.12.9, still getting the same message.

I just downloaded purs at version 0.12.5 and when I run it in an empty project:
~\code\zerotwelve> purs ide server --log-level debug
Parsed Options:
ServerOptions {_serverDirectory = Nothing, _serverGlobs = [], _serverOutputPath = "output/", _serverPort = 4242, _serverNoWatch = False, _serverPolling = True, _serverLoglevel = LogDebug, _serverEditorMode = False}
[Debug] Accepted a connection @(main:Command.Ide app\Command\Ide.hs:213:5)
[Debug] Received command: { "params": { "identifier": "liftEff","namespace": "value","module": "Control.Monad.Eff.Class" },"command": "usages" } @(main:Command.Ide app\Command\Ide.hs:223:9)

~\code\zerotwelve> purs ide client
{ "params": { "identifier": "liftEff","namespace": "value","module": "Control.Monad.Eff.Class" },"command": "usages" }
{"result":"Module not found","resultType":"error"}

That means it's able to parse that command just fine. Are you running an even older purs binary by chance?

Sorry my bad. I was in an old project and running purs 0.11.7. Working in 0.12.5. Sorry again.


feat: middleware can call renderNotFound

closes https://github.com/denoland/fresh/issues/1628
I now create the renderNotFound function outside of #handlers. This allows me to pass it to both #handlers and composeMiddlewares, so that it can get added to MiddlewareHandlerContext.
This also makes it trivial to do https://github.com/denoland/fresh/issues/1759. Please reassign that to me, because I can complete it as soon as this is merged.

Hey @marvinhagemeister, I've resolved the conflict resulting from my previous PR you merged last night. Please take a look at this so that I can move on to #1759.
And yes, I see that this is also pushing the handlers closer together. I have my thinking hat on and I'm actively looking at how to consolidate them in order to improve the situation.

Nice, this is great!


Compile-time-if related refactoring

Support not, and, or operators in compile-time if statements. For example, if WINDOWS or MACOS:
Move platform-specific errno stuff from _windows_startup.jou/_macos_startup.jou to errno.jou
Move stdin/stdout/stderr handling from _windows_startup.jou and _macos_startup.jou into a new file _io_init.jou
Delete _windows_startup.jou and _macos_startup.jou

This breaks self-hosted compiler, but only on macos, because global variables are not implemented yet and IO on macos needs them. I think I'll merge this after I add support for global variables.


[Help] Not sure how to get started.

Hi,
I installed tele-aria2 using npm install tele-aria2 -g and got help by tele-aria2 --help without any issue. But when I try to configure it using the given commands, the below error pops up. Please Help me out!
I tried to configure using both:

Terminal by adding tele-aria2 -b 12345:xxxxx -s http://<IP_ADDRESS>:6800 -u 123455
Creating Config file and adding by tele-aria2 --config /home/pi/Tele-aria2/tele.conf

But Both the methods shows the same error below.
/usr/local/lib/node_modules/tele-aria2/dist/Aria2.js:62
        this.logger.warn(error.message);
                    ^

TypeError: Cannot read property 'warn' of undefined
    at WebSocket.Aria2.onWsError (/usr/local/lib/node_modules/tele-aria2/dist/Aria2.js:62:21)
    at WebSocket.emit (events.js:198:13)
    at abortHandshake (/usr/local/lib/node_modules/tele-aria2/node_modules/ws/lib/websocket.js:697:15)
    at ClientRequest.req.on (/usr/local/lib/node_modules/tele-aria2/node_modules/ws/lib/websocket.js:579:7)
    at ClientRequest.emit (events.js:198:13)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:565:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:111:17)
    at Socket.socketOnData (_http_client.js:451:20)
    at Socket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)

As i'm new to this, I am not sure how to get started. I have both telegram bot token and the unique user ID.
It would be great if I receive instruction on how to configure tele-aria2 and how to run it as well.
Thank you.

This is a bug, but you can avoid this bug by changing server address to http://<IP_ADDRESS>:6800/jsonrpc, I'll address this error in the next release.

Fixed in the latest beta release, please have a try npm install<EMAIL_ADDRESS>-g

It is working now! Thanks.
Is there anyway I could start this automatically after bootup?

not yet, you have to configure it on your own, I'm currently working on the docker image support, you can use docker to manage this tool once the image is ready.

Okay! Keep up the great work!


Add Interactive List

Make It Interactive
Add Clear All Completely Functionality.

STATUS: APPROVED  ✔

Hi @oyelakinG9 ,
Your project is complete! Great job for nailing it right on the first attempt 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟
Good Points 👍

Project is set up correctly ✔
No linter errors ✔
Professional documentation ✔
The task object's values for completed is updated upon user actions  ✔
"Clear all completed" button is using the Array.filter() method ✔
The updated array of items is stored in local storage ✔

[ ] OPTIONAL: I would recommend you to update the indexes every time an item was deleted, currently the indexes remain the same.

Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


buffs: add support for char offsets of "payload"

Plus flag for whether it is this span, or things that are not this span, that should be perturbed or not.
These to be set by the calling probe; assume buff does not have access to probe internals. Maybe worth adding a hook for this in probes.base, e.g. _buff_setup()
E.g. paraphrasing: when paraphrasing prompts from probes.encoding, we ought to leave the payload unperturbed
E.g. encoding: when encoding a payload by adding spaces or hex encoding it (cc: @erickgalinkin), we ought only perturb the payload
specify these ranges by character offset

one option for paraphrase buffs:

replace the payload with a fixed short token, e.g. QXQ
only accept paraphrases including a " QXQ "
substitute the payload back in


Move ConfigureSwaggerDocument and ConfigureSwaggerSchema from ConfigureServices to Configure in Setup

Currently ConfigureSwaggerDocument and ConfigureSwaggerSchema must be done in Setup.ConfigureServices of the client web project. At this stage the client knows nothing about the execution environment so it need to hardcode a full path the the documentation XML XmlComments file. Not nice!
It would be better if these can be done later in Setup.Configure where it is possible to use dependency injection to get hold of IApplicationEnvironment which allows for calculating where the XML XmlComments file is located relative to the ApplicationBasePath.

This doesn't really make sense to me as the configuration applies to the SwaggerProvider "service" and not the Swagger middleware. Besides, you can just create a constructor in your Startup class that accepts IApplicationEnvironment and then store it in an instance variable. Then it's accessible from the ConfigureServices method. See https://github.com/domaindrivendev/Ahoy/blob/master/test/WebSites/Basic/Startup.cs for an example that uses this approach.

You can get it even from Configuration
var ContentRootPaths  = Configuration.GetChildren().Where(c => string.Compare(c.Value, env.ContentRootPath) == 0).ToList();

Key = "ASPNETCORE_CONTENTROOT"
Key = "ASPNET_APPLICATIONBASE"

This way Configuration["ASPNETCORE_CONTENTROOT"]


Making quickfind readable in Dark theme

Changed from a very dark blue to the same semi-dark white used everywhere else. This makes the checkboxes on the Quick Find toolbar actually readable when using the VsDark theme.

Thank you so much for the fix. I use quick find so little that I've just never noticed.


uuid4 doesn't works with google uuid.UUID

[+] I have looked at the documentation here first?
[+] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10
Issue, Question or Enhancement:
Got an error: ["3dcf8eb3-4489-4777-af93-2ba289316e77"] is not valid value for uuid.UUID
Code sample, to showcase or reproduce:
type getContactRequest struct {
	ID uuid.UUID `uri:"id" binding:"required,uuid4"`
}

If i pass
type getContactRequest struct {
	ID string `uri:"id" binding:"required,uuid4"`
}
``` - It works

Hey @polRk
The validator works only for string types out of the box.
But you can register a CustomTypeFunc. It would look something like this:
package main

import (
	"fmt"
	"reflect"

	"github.com/go-playground/validator/v10"
	"github.com/google/uuid"
)

type getContactRequest struct {
	ID uuid.UUID `uri:"id" validate:"required,uuid4"`
}

// use a single instance of Validate, it caches struct info
var validate *validator.Validate

func main() {

	validate = validator.New()

	// register all sql.Null* types to use the ValidateValuer CustomTypeFunc
	validate.RegisterCustomTypeFunc(ValidateUUID, uuid.UUID{})

	// build object for validation
	x := getContactRequest{ID: uuid.New()}

	err := validate.Struct(x)

	if err != nil {
		fmt.Printf("Err(s):\n%+v\n", err)
	}
}

// ValidateUUID implements validator.CustomTypeFunc
func ValidateUUID(field reflect.Value) interface{} {
	if valuer, ok := field.Interface().(uuid.UUID); ok {
		return valuer.String()
	}
	return nil
}

See more at : https://github.com/go-playground/validator/blob/master/_examples/custom/main.go
and https://pkg.go.dev/github.com/go-playground/validator/v10#CustomTypeFunc and https://pkg.go.dev/github.com/go-playground/validator/v10#Validate.RegisterCustomTypeFunc

Thank you!

It doesn't work
["cb1cdadb-a93c-487b-be62-4963cef4600b"] is not valid value for uuid.UUID

	if v, ok := binding.Validator.Engine().(*validator.Validate); ok {
		v.RegisterCustomTypeFunc(ValidateUUID, uuid.UUID{})
		v.RegisterCustomTypeFunc(ValidateNullable, uuid.NullUUID{}, nullable.NullString{}, nullable.NullTime{})
	}
	```

I think, problem with ShouldBindUri, because with ShouldBindJSON works good

That error is not with this library, but https://github.com/gin-gonic/gin so you should take the issue there.

As an aside I think that we can enhance the uuid validation to check if the type can be cast to a Stringer and if so call that function. Since most, if not all, UUID types have this function.
type Stringer interface {
    String() string
}

I'd be happy to accept a PR for that. Then no custom functions would be required.

I Faced this problem,
I think that it is a regex problem,
when you check regexes.go file you face with this line:
uUID4RegexString                 = "^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$"
but our third part of uuid have 4 characters, so 4[0-9a-f]{3} is not proper for us, I'm going to create pull request

it works with strings only and it works like a charm!

@deankarn ^ I went ahead and did my attempt at adding this in https://github.com/go-playground/validator/pull/1189


A11y_AzureExtensionsforVSCode_AzureFuction_CreateNewProject__ColorContrast : The color contrast ratio of keyboard focus on several controls such as "Python", "JavaScript", etc. is less than 3:1

GitHub Tags: #A11y_VSCode;#CAITestPass_May2020;#Visual Studio Code;#A11yTCS;#A11yWCAG2.1;#MAC;#FTP;#Benchmark;#ColorContrast;#A11ySev2:#MAS1.4.11;
Environment Details:
Application Name: Azure Extensions for VS Code
Application Version: 1.48.0-insider
Commit: cfbd1999769f4f08dce29629fb92fdc0fac53829
Date: 2020-08-06T05:40:40.871Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.6.0
Operating system: macOS Catalina Version 10.15.6 (19G73)
Screen Reader: VoiceOver
MAS References: MAS1.4.11
Repro Steps:
Open Visual studio code
Click on extension button and search for "Azure Functions"
Click on install and move to the "Azure" button
Click on "Create New Project Button" from the toolbar
Navigate to options from the list box such as "Python", "JavaScript", etc. control using keyboard and verify if the color contrast ratio of keyboard focus is less than 3:1 or not.
Actual:
The several controls such as "Python", "JavaScript", etc. has keyboard focus color contrast ratio of 1.1:1 which is less than the standard color contrast ratio of 3:1 which is not appropriate as the users with low vision will have difficulty in understanding the navigation on the screen.
Expected:
The keyboard focus color contrast ratio of several controls such as "Python", "JavaScript", etc. should be greater than or equal to 3:1.
Attachment link for Reference:

@nirmalsahoo I don't believe you grabbed the correct colors. #F3F3F3 is the background color of the quick pick, the text foreground is #616161 and this should pass:


fix: remove old creation code

Description

Removes unused code from old creation flow
Updates new creation flow to no longer have 'v2' verbiage

Task Item
fixes #7562
additional open questions/comments:

old runtime templates have not been deleted given the assumption that we will need them if we do not go with forced migration and that tentative code removal is already implemented a seperate PR
Verbiage that has persisted

getPublishStatus vs getPublishStatusV2
copyRemoteProjectTemplateTo vs copyRomoteProjectTemplateToV2

Coverage decreased (-0.3%) to 50.02% when pulling 7413da327790c0eef99d930f6b3a84a2797b09bf on pavolum/removeOldCreation into 1f1e2af0cb97ba37f2ba91093f14769a60a02c10 on main.


HV-967 Fixing broken links and pre-resolving some valid but redirecting ...

...links
I wouldn't have spent time on this, but since I had the changeset already around.. do you want it or should I trash it?
(It was part of my previous PR about links)

HV-5-MASTER #678 SUCCESS
This pull request looks good

I rebased and merged it, since it seems the consensus seems to be that this the way to go. Note, that personally I liked 'validator.hibernate.org'.  I think it gives the project more "importance". Also I don't think that in general it is always a good idea to give users a "canonical" url. There are good reasons why redirects exists and make sense. Also the SEO argument does imo not really apply here. Nevertheless, it's merged.

TBH I like the domain more as well. Just applying what had been decided in the past here.. but happy to rethink eventually.


Add non-tracking reasons to up-to-date and cacheability reasons

Fixes https://github.com/gradle/ge/issues/20936
Context
The change allows easier understanding of why a task is not considered up-to-date and why it was not cached
The issue linked above has references to internal discussions about this topic
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation

This PR contains the changes proposed to cacheability message, this can be reverted if we agree differently on the spec

@bot-gradle help

I've triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

I've triggered a build for you.


ZIO 2.0.0 RC6

Updates to ZIO 2.0.0 RC6

Ignored some tests that are failing (on CI only), will fix them separately


Add S2Sv3 to MOM6 test. Add YAML validator

This PR adds an S2Sv3-MOM5 to C12-MOM6 test case to the remapping tests. It also has some fixes from @weiyuan-jiang while debugging other issues I found/created. 😄
It also adds a YAML validator and cleans up the existing YAML files to pass.

Converting this to draft just until @weiyuan-jiang is satisified.


Integrate Tensorflow into Peloton

The workload prediction module of our self-driving component uses machine learning to predict the arrival rate time series of queries. We're going to integrate Tensorflow to train those machine learning models. Furthermore, the feedback control part of the self-driving component also needs it to train statistical models. The C++ version of Tensorflow requires us to build tensorflow by ourselves. That will significantly increase Peloton's build time. So for now we have two other choices:

Use Python version of tensorflow in another process (probably in a Docker in the future). Then we open up a pipe between Peloton's main process and this process to communicate.
Use C version of tensorflow:
https://www.tensorflow.org/install/install_c
It seems that this thing can be directly installed as a library. However, I don't know how compatible this is with C++. Also, the official Tensorflow API documentation provides C++ doc but no C doc:
https://www.tensorflow.org/api_docs/
We may need to look further into this.

@saatviks Are you working on this?

Yep - Have been coordinating with @malin1993ml.
We have finished setting up a helper/entity C++ class to work with the Tensorflow C API which does the following:

Import a tensorflow graph which would generally be written in the tensorflow python API.
Useful methods to setup and call tensorflow ops - these would generally be to train and test models
Examples for vanilla logistic regression and MLP
Next up we are working on reproducing @malin1993ml's python code for workload prediction. Will keep this space updated as we finish adding more features.

@saatviks Thanks for the update. I have assigned you to this issue. Please make sure you mention this issue when you raise a PR.

Sure, thanks.


Changed explicit in TrackSimple from boolean to Boolean

With this fix if we exclude explicit from the list of returned fields it will be null instead false

Merged! Thanks :)


[FR] - executeLocalStateQueryExpr allow tx submission, short-term solution

Internal
Describe the feature you'd like
executeLocalStateQueryExpr currently sets localTxSubmissionClient = Nothing so there is no way to submit transactions over the same connection as the state query monad
the short-term solution i can see, is to just expose the 2 Maybe's for localTxSubmissionClient and localTxMonitoringClient, and just make those into arguments for executeLocalStateQueryExpr
the call-site can then either Nothing Nothing those args to maintain the old behaviour, or they can Just submissionClient to supply a client
the long-term solution i can see, is for the localTxSubmissionClient to also support a monad based interface, like how executeLocalStateQueryExpr adds tolocalStateQueryClient: https://github.com/input-output-hk/cardano-node/issues/4357

Reference conversation @newhoggy
https://input-output-rnd.slack.com/archives/G011N23CEAE/p1660788859942189


Fix documentation. Remove unnecessary setup

Fix documentation. Remove unnecesary setup.
(based on comments)

@sbrunner removed  postfix


Compile warnings

I'm currently getting these warnings with ClippingBezier and PerformanceBezier when integrating via SPM

Can you please fix the warnings?
PS: I'm working on a 0-warning project. 🥹 I cannot find a way to suppress SPM's package warnings.

This can suppress the warnings:

https://stackoverflow.com/a/64842804/24658404

but it doesn't support versioned dependencies:

https://forums.swift.org/t/question-about-contains-unsafe-build-flags-in-spm/47677/4

About the root cause of the warnings:

https://forums.swift.org/t/root-cause-of-umbrella-header-for-module-does-not-include/24063/2

So to fix the warnings, we should either import the headers or remove them totally. It appears that removing them is not so reasonable, because they're being used internally.
@adamwulf can you help to fix the warnings? just by importing them to the module. 🙇


"Current installation is invalid, please run NPM install first" because of bower component

We put bower dependencies in a specific folder, using .bowerrc. We installed Angular as a Bower dependency, and when I run next-update I get:
next-update - Tests if module's dependencies can be updated to latest version
  version: 0.5.1
  author: {"name":"Gleb<EMAIL_ADDRESS>checking if the current state works
ERROR: cannot find folder /home/nchambrier/Projects/LMTM/ooz/bower_components/angular
ERROR testing next working updates
Error: Current installation is invalid, please run NPM install first
    at /home/nchambrier/.nvm/v0.10.32/lib/node_modules/next-update/src/next-update.js:35:26
    at node.js:906:3
From previous event:
    at checkDependenciesInstalled (/home/nchambrier/.nvm/v0.10.32/lib/node_modules/next-update/src/next-update.js:29:19)
    at Object.checkCurrentInstall (/home/nchambrier/.nvm/v0.10.32/lib/node_modules/next-update/src/next-update.js:43:12)
    at Object.<anonymous> (/home/nchambrier/.nvm/v0.10.32/lib/node_modules/next-update/index.js:129:38)

Obviously, if it looks for Angular in ./bower_components it won't be found as there is no such folder.
next-update should either

ignore bower dependencies (I thought it only checked npm dependencies)
read .bowerrc

get the same error

is it okay to handle bower registry with this tool? if new ones will appear in future? It will be hard to maintain, won’t it?

I think it is fine to use this tool for bower dependency, I guess in this case it should really read .bowerrc I will try fixing this over the weekend

Actually, I found very confusing that error suggest only npm i even If I forgot only bower deps. It’s a bit complicated for me to separate forgotten npm deps from case of forgotten bower ones. But it’s pretty easy to add suggestion about bower deps in that error message and it will be good enough, I think. If you are think the same, I created #51 about it. Feel free to ask any question there.


Added package.json

Added a package.json to #7 and published to npm as themoviedb-javascript-library.
I'm happy to transfer the module to you if you want.

Hi, I appreciate your contribution, but i prefer leave the library as standalone (at least here), without additions for a specific framework.
Thanks!


expose: Re-use labels in case none was specified

Forked from #7765
cc: @jlowdermilk @bgrant0607

Is hack/verify-gendocs.sh passing for you? Shippable is still complaining about gendoc differences.

Maybe rebase?

I regenerated the docs and rebased on top of the current master, hope it'll be fine now.

Btw hack/verify-gendocs.sh is not complaining on me.

From shippable:
--- FAIL: TestRunExposeService (0.00 seconds)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x47f520]

Are you able to repro that failure locally with hack/test-go.sh?

I was. Now it's fixed.

LGTM. Shippable is green, so merging.


🍻 Setup all contributors

https://allcontributors.org

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore(Datagrid): add test for  useInlineEdit hook (v11)

Contributes to #1781
Adds the first test for Datagrid useInlineEdit hook functionality. In the test, we check that a cell value can be edited via click and keyboard interactions.
What did you change?
Added new test for useInlineEdit hook
How did you test and verify your work?
Ran datagrid tests

Weill reopen these as needed since these are pretty outdated now.


Blood is fuel

About the PR

ultrakill reference
Why / Balance

Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Blood is fuel!

based

mankind is dead


Untrusted

Not sure if I can trust this DLL, as it had over 33 threats, and in an instant was removed from my PC every time I tried.
Before people come at me Yes, I've used cheats before, but something just seems sketch about this.

If you build Osiris yourself, your compiled DLL will be trusted, it's just a false positive.

osiris from this repo is completly virus free ive just downloaded it

Did you compile it yourself or did you download it somewhere?


Please Add Callback for 'shouldOverrideUrlLoading'

https://github.com/mukeshsolanki/MarkdownView-Android/blob/173f8d9484aa66569da49ad3c2862ef26b1b6381/markdownview/src/main/java/com/mukesh/Markdown.kt#L54
Sometimes, I just want to know which url the user clicked...

Or Maybe support to pass a customed webViewClient...


Add missing auth config to compose file

When running in docker-compose, the order monitor client could not request the orders from the monitor endpoint, as the request from the products service was not correctly authenticated and returned a 401.
This PR adds the AuthN configuration to the products service in docker-compose so that the provided token is correctly accepted.

LGTM


Fix for circular import error on websockets.py

Removing the live module from the websockets init fixes the circular import problem when using the raw websockets modules and allows more flexibility from the end user. The live module is a higher level implementation of websockets BaseStream and really shouldn't be included.
Removed:  from .live import *   from init.py

Closes #177


Update tutorial.rst

Better instructions - the config.json literal filename is not used anywhere else in the examples and is confusing
Proposed changes:

...

Status:

[ ] ready for code review
[ ] there are tests for the functionality
[ ] documentation updated
[ ] changelog updated

Good Stuff :1st_place_medal:


test should cover the same basic aer (without the statevector and unitary)

https://github.com/Qiskit/qiskit-terra/tree/master/test/python/basicaer and the test folder should be names test not test_jku. I would replace them with test taken from basicaer (updated for JKU) @diego-plan9 it would be nice to have these as default simulator ones somehow. Maybe we can make a copy get it passing, set up travis and then make an issue for an automated simulator test set.

The one test there that needs to be check is the tensor order.

Apart from having a default test-suite for all simulators, Gadi will add some additional unit tests for now, and then we can change this into enhancement tag. JKU does produce a statevector, so some statevector tests as well.

@diego-plan9 are you fine with the tests you added or do you want us to add more unit tests before first release?

@diego-plan9 are you fine with the tests you added or do you want us to add more unit tests before first release?

Pinging  @jaygambetta ! The test I added just cover "basic provider and backend functionality" in regards to the needs of being compatible with terra, I did not include any tests covering actual JKU-specific functionality, and mostly relied on the existing tests.

never mind, @gadial just added the statevector unit-test and will probably add more soon, so we'll have also the JKU-specific

After merging both #53  (already done) and #54 I think we can close this.


How does this effect the code execution speed?

Hi,
I guess the code execution should be a bit faster with the bytecode. Would you guys please let me know whether the code execution speed will be faster or slower?

So far I've tried it on my small project. The speed seems to have no big difference before and after encrypted.

It is the same performance or even faster. But the difference is unnoticeable in almost all cases.


fix: Fixed spacing in terraform_wrapper_module_for_each hook

Fixed spacing in terraform_wrapper_module_for_each hook which was a problem when sensitive was true ( https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/76#issuecomment-1500329275 )

This PR is included in version 1.77.2 :tada:


removing warning

ESLint warning is:
	 Error     19,24: Unnecessary escape character: \M. (no-useless-escape)

This change eliminates the warning.

ahh, typo! Thank you very much!

No problem, glad to help.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Dependency Lookup Warnings in aqua.yaml

related: https://github.com/aquaproj/aqua-renovate-config/issues/189
Hi @suzuki-shunsuke , thnak you for develop great tool!
I have imported the recently released version of aqua-renovate-config, but I get a warning about aqua.yaml
https://github.com/ponkio-o/dotfiles/issues/14

Am I missing something?

Thank you for your report.
I'll fix the warning.
https://github.com/aquaproj/aqua-renovate-config/pull/195

Released. https://github.com/aquaproj/aqua-renovate-config/releases/tag/1.2.2

Thank you for your quickly reply and release!! I have confirmed that it has been successfully fixed.
https://github.com/ponkio-o/dotfiles/issues/14


Add an Ord instance for PrivacyAnnotation

This means we can merge many of them using minimum. Useful when we have
to log many things and have to pick a single overall privacy value. We
already have this for severity.

bors r+

commits were not signed, so bors cannot merge them automatically. :man_shrugging:


Preparing 5-Node Kubernetes Cluster

What does this script do?
The first line kubeadm init initializes a Kubernetes control-plane node and execute the below phases:
If also add a CNI plugin called kube-router using kubectl apply -f https://raw.githubusercontent.com/cloudnativelabs/kube-router/master/daemonset/kubeadm-kuberouter.yaml
The above line may be added to give the learner clarity on the same

@ashutoshbhakare Do you want to add the comments to the bootstrap.sh script. Go ahead and raise PR.

Closing this issue as the description is already added.


Fix three problems with undo

Undo sometimes didn't work.
Sometimes it teleported you to a different view.
It enabled an Any% speedrun strat where everyone refreshes their game,
moves once and clicks undo. This would lead to them teleporting to
Hon Sushi, wining the game.

A nice side effect is that undo is now much faster (it's presumably cached). On the other hand the instant undo is a bit jaring, so we'll see if users react positively.

For #74 .

Forgot to mention: the price for fixing these issues is that Hon Sushi isn't the default starting location any more, and there is always an exception thrown at the time of creation of the panorama. I tried avoiding this, but I couldn't get it to work any other way.

@mibpl I leave it up to you if the cost is worth it.

Due to domestic opposition, I've made it so there is no exception thrown.


Use of b method incorrectly includes a space before punctuation

A sentence like S(Pro("I"), VP(V("be")).b(',')) is realized as "It , is." when it should be realized as "It, is". S(Pro("I").a(','), VP(V("be"))) is realized correctly.

I am not sure if this is a bug or a feature...  .b() in front of a VP should not be added at the end to the word before especially if it is not in the same Phrase.
Usually a comma is followed by a space and should be used in the context of a .a().

Maybe I should (roughly) discuss my use case: I have a sentence like S = 'I saw a cat on a mat' and I want to add either the non-restrictive clause C1 = 'where she was sitting peacefully' or restrictive clause C2 = 'with a tasseled boarder' as S.add(C1) or S.add(C2).
The first should be realized as 'I saw a cat on a mat, where she was sitting peacefully' while the second should be realized as 'I saw a cat on a mat with a tasseled boarder'. I would like to be able to add the comma to C1 and not C2, but doing so currently in JSRealB leads to the incorrect realization 'I saw a cat on a mat , where she was sitting peacefully'. Of course, I could realize this sentence as S.a(',').add(C1), but then I would have to treat C1 differently to C2 which is not very ergonomic.
Perhaps is this more of a feature request than a bug, but as far as I can see the current behaviour is unlikely to be useful to anybody (and, if really needed, could be recreated through .a(' ,')), and I behaviour I have suggested here would be useful to me and I suspect others.

Having looked a bit how this case could be "patched", I am a bit reluctant to try to take this into account because it would complicate the "detokenization" process which is now very systematic (separate each token with a space unless the next one starts with a space, dash or apostrophe). I am afraid that trying to take care of this would break other things. To deal with your use case, I suggest that you define a custom function that depending of the type of clause would add .a(",") or not and then .add(Ci) and return the resulting S.

Fair enough, thanks for considering this.


Update interfaces from correct module

Category

[X] Content fix
[ ] New article

What's in this Pull Request?
I updated the correct modules with latest version of SPFx, I already have created a pull request with the example mentioned how to create a custom property pane to match with this changes.

thx @abrahamgr, appreciated.


Jc/dst yaml upgrade

This modification does away with Tmux so that you can run this container using a yaml. This PR would require a rebuild of the image favoring the use of yaml to deploy container enabling support of common container orchestration such as portainer and other docker management tools.

One of the reasons why I choose tmux is dst have 2 processes for master and cave world, and each of them have an interactive cli. If run in shell background that maybe not convenient enough to manage the servers?
I'm not very familiar with docker compose, is there any way to cope with the compose problems while maintaining both cli interactive? I'm also checking the compose part now.

I had a discussion with @taoky . Generally we have 3 plans:
A. Current plan, use tmux/screen to detach/attach to manage master/cave world in a single container. Not orthodox but you can attach to master/cave cli and interact
B. Get away with tmux, use docker compose to run master/cave in different container. But we have duplication of 2 copies of steam cli and DST itself.
C. Your PR. But it's less manageable, you cannot attach to bg process as the shell hangs on wait -n
D. Get away with tmux, use socat and nc to manage master/cave (outside the container), but the context could be lost between nc and I think tmux/screen is better


Delete Instance from UI

Signed-off-by: Ofer Levi<EMAIL_ADDRESS>

Signed-off-by: Ofer Levi<EMAIL_ADDRESS>
The redux part LGTM


fix: type check for error instance when used toThrowError method

Summary

toThrow/toThrowError method does not type checking when expected value is error instance.
current behavior
class ErrorA extends Error { }
class ErrorB extends Error { }

const throwErrorA = () => {
  throw new ErrorA();
};

expect(throwErrorA).toThrowError(ErrorA); // pass
expect(throwErrorA).toThrowError(new ErrorA()); // pass
expect(throwErrorA).not.toThrowError(ErrorB); // pass
expect(throwErrorA).not.toThrowError(new ErrorB()); // fail, but this test should be passed

expect behavior
expect(throwErrorA).not.toThrowError(new ErrorB()); // pass

I added some codes that compare type for this problem.
When comparing, need to check error instance is custom error or not.
Because in some tests like this:
// jest-runtime/src/__test__/runtime_internal_module.test.js >> internalModule
it('loads modules and applies transforms', async () => {
  const runtime = await createRuntime(__filename, {
    transform: {'\\.js$': './test_preprocessor'},
  });
  const modulePath = path.resolve(
    path.dirname(runtime.__mockRootPath),
    'internal-root.js',
  );
  expect(() => {
    runtime.requireModule(modulePath);
  }).toThrow(new Error('preprocessor must not run.'));
});

In this case, both thrown.value and expected are Error instances.
But their constructor is not same.
console.log(thrown.value.constructor); // [Function: Error] { stackTraceLimit: 100 }
console.log(expected.constructor);
/*
[Function: Error] {
    stackTraceLimit: 100,
     prepareStackTrace: [Function: prepareStackTrace]
}
*/

It's no wonder that thrown.value instanceof expected.constructor is false, thus test will fail.
So I checked expected error is custom error or not before comparing type of instance.

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.1


SImulator is running while compiling .hex files.

I am not sure how to repro this?

Pleas reopen it is a valid bug. Change c++ and try again
Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhijith Chatra<EMAIL_ADDRESS>Sent: Thursday, March 28, 2019 4:30:41 PM
To: Microsoft/pxt-arcade
Cc: Peli de Halleux; Author
Subject: Re: [Microsoft/pxt-arcade] SImulator is running while compiling .hex files. (#791)
I am not sure how to repro this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-arcade%2Fissues%2F791%23issuecomment-477808215&data=02|01|jhalleux%40microsoft.com|f7e292a70c464619546808d6b3d5650f|72f988bf86f141af91ab2d7cd011db47|1|0|636894126436095724&sdata=oZzmco0dyA7KspwAy3RLaW7FOSl%2FY%2FrkUiSXK49zLPs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KUG0iTvMgQARKFF8xJXT3rl93oBBks5vbVChgaJpZM4b1toF&data=02|01|jhalleux%40microsoft.com|f7e292a70c464619546808d6b3d5650f|72f988bf86f141af91ab2d7cd011db47|1|0|636894126436095724&sdata=c686W0i7QG5MttGSweeIyJQ4pBtZLRHYwyPhxEeHVAY%3D&reserved=0.

User is not going to change C++ in the browser. I am not sure what it means? How does a user hit this bug? Is this only for extensions?

P4