[Zeppelin-1213] Customize editor configuration

What is this PR for?
Customize editor configuration

Each user can have different editor setting(For example, editor theme, indentation, font size, editor print margin, etc)
Each user can have different editor setting for each interpreter. (E.g %spark -> font size, indent, theme)

What type of PR is it?
Feature
Todos

[x] create editor configuration setting page.
[x] configure theme
[x] configure support language
[x] change font size and indent theme
[x] editor config serialize / deserialize
[x] preview window.
[x] create and delete, and save.
[x] add web socket event for code editor setting.
[x] apply setting for each interpreter tag
[x] if show line number setting already exists in paragraph, paragraph setting has priority over editor setting

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1213
How should this be tested?

click to user name menu in navbar and click to Editor Configuration menu.
set up editor setting. (and using preview pargraph)
click to save button.
move to any paragraph.
check to apply setting.
check to exists conf/code-editor.json in zeppelin directory.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@cloverhearts Really great feature! I can't wait to build and run this.

+1

This PR is way too big to be reviewed properly.
I'm not sure every settings are necessary (especially from the start).
And I also have issues with the fact that every Theme from Ace is included.

Thank you for feedback @corneadoug .
I can possible divide to this pr.
and I have a question.
I also have issues with the fact that every Theme from Ace is included.

Can you give me an explanation why that is a problem?
If you have a problem, I need to clear a part of the theme changes.
a very easy fix.
I thought that people would want to coding in a theme familiar to them.
Once again thank you for your message.

@cloverhearts it would be nice to divide it in multiple PRs and commits.
For the theme, I'm not against them wanting to change it, however in this case crowding the build by importing all the Ace theme inside the build, even though 70% of them will probably not be used.

I removed the feature to change the theme.
It will also split into a new PR.

I agree with @corneadoug that this is a big change to review.
One more thing - @cloverhearts can you please add some tests for this feature?
See AuthenticationIT.java for an example of Integration Test

@cloverhearts Don't hesitate to ping me when you start making the small PRs

@bzz @corneadoug
Okay, Thank you very much

Shall we close this one now?

@cloverhearts ping

@bzz i am sorry to late for response.
The PR was divided.
https://github.com/apache/zeppelin/pull/1256
and jira issue subtask
https://issues.apache.org/jira/browse/ZEPPELIN-1213

That looks great! Thank you @cloverhearts let's close this PR then.

@bzz Okay!

How can I use this feature?
Though I've installed latest build version, I could not find "Editor Configuration menu" anywhere.

@hyonaldo
Sorry,
We can not support this feature on zeppelin.
I do not care for this feature into master.
It also differs from the current source in many ways.
Re-implementation is required.
I have no plans to reimplement this until now.
Perhaps, if you want this feature.
You can create an issue in our jira. (https://issues.apache.org/jira/browse/ZEPPELIN)
Sorry, again.


chore: use endpointId if package.json has it

@ericallam kindly review
/claim #165

Can you add a "patch" changeset to the @trigger.dev/cli package to this PR?
Run this command from the root of the repo:
pnpm run changeset:add

Select the @trigger.dev/cli package only, and then follow the prompts to select a "patch" update and fill in the details of the change. This will create a file that should be pushed to this PR

Cool cool! I'll push the change in a bit🚀

Does this look right?

In case you missed this @ericallam

CleanShot.2023-07-20.at.09.23.14.mp4

Thanks for this! Changeset added.


1.9.2 authenticated-route-mixin - queryParam regression

Starting ember-simple-auth version 1.9.2 ( I think it's very likely related to 84c076d0b6ebb37143498ef54c33f8fe59c702f7 ) ember shows a pretty strange error when using query params and a route is trying to be accessed that applies the authenticated-route-mixin. As it looks it only shows up when the user is not authenticated and the redirect is triggered. Reverting back to 1.9.1 fixes the issue
Assertion Failed: You passed the `application:referral` query parameter during a transition into application, please update to referral
    at assert (index.js:163)
    at Class._hydrateUnsuppliedQueryParams (router.js:974)
    at Class._prepareQueryParams (router.js:801)
    at Class._doTransition (router.js:749)
    at RouterService.transitionTo (router.js:114)
    at Class.triggerAuthentication (authenticated-route-mixin.js:127)
    at authenticated-route-mixin.js:107
    at runIfUnauthenticated (authenticated-route-mixin.js:30)
    at Class.beforeModel (authenticated-route-mixin.js:106)
    at Class.superWrapper [as beforeModel] (utils.js:366)

Likely related:
When debugging authenticated-route-mixin::triggerAuthentication it looks like
this.get('_authRouter') returns the RouterService
whereas:
this.get('_router') returns a different router (probably the internal ember router)
at least: this.get('_router') != this.get('_authRouter')
Probably in the 1.9.1. implementation the _router property defined in the mixing was overridden with the ember router and has therefore been working (but that is getting a little vague now)

To confirm my assumptions, this is using 1.9.1 debugging the triggerAuthentication method:
Ember.getOwner(this).lookup('service:router')
> RouterService {_router: Class, __INIT_WAS_CALLED__ember15644177776861236198101007__: true}

this.get('_router')
> Class {currentURL: null, currentRouteName: null, currentPath: null, currentRoute: null, _qpCache: {…}, …}

So, 1.9.2 is using a different router than 1.9.1. However, I am pretty much at a loss what the intended behaviour is/was and what would be the right way to fix this

I think this is a bug in Ember.js actually where the router service is not 100% compatible with calling e.g. transitionTo in a route direclty, see emberjs/ember.js#16594

@marcoow I think this is correct. I submitted a PR https://github.com/emberjs/ember.js/pull/18244 to fix this, however I think this should be reviewed by someone who is more familiar with the inner workings of the ember routing system.

This is related to https://github.com/emberjs/ember.js/issues/17494 and https://github.com/emberjs/ember.js/issues/14875

@IBue this bug should be fixed in recent ember releases (at least I was never able to reproduce it after my PR was merged). Are you still experiencing the same error with latest versions?

@st-h: With ember-source 3.12.2 + ember-simple-auth 1.9.2/2.1.0 there is still this error when an unauthenticated redirect (AuthenticatedRouteMixin#triggerAuthentication() ) occurs into a route that is either query-parameterized by itself or by its parent.

Would be interesting if you are still seeing this with ember >= 3.14.1. (I don't know if the fix has actually been backported yet) However, I am afraid I can not be of more help here right now. I am just a little surprised that I have never seen this issue reappear after upgrading to 3.14.1


How can i hold status of swipelayout in my ViewHolder?

I want to hold status of swipelayout (open/close) when scrolling the list in recyclerView. So, how can i do it?

Simplest solution: store status into model. Then restore state while drawing.
If you won't tie model with your view then store status in some "storage". For example in Map<ModelId, ViewState>. But it cause memory allocation while drawing and it is not very good for performance.

@IlyaEremin
Thank you, llyaEremin. I tried that way. But it wasn't work, because i couldn't catch a event fired from swipelayout to set boolean attribute into model when i swipe a item of RecyclerView. I tried to use addSwipeListener method but it doesn't work normally as i want.

I'm trying to do the same, have you managed to find a solution @chiennt56?

@chiennt56 Have you found a solution for it? I am also facing the same issue.

@chiennt56 I bet chiennt56 is saying using a wrapper to wrap your current model and the state, and each time bindViewHolder is getting called, just check the boolean


bug: removeNullProperties removes regular arrays too

https://github.com/intuit/QuickBooks-V3-PHP-SDK/pull/420
I've seen others with the same error messages I was seeing yesterday
"CustomerRef is missing" from posting an Invoice object.
Using JSON, the serializer 'removeNullProperties' method was filtering out the "CustomerRef" key/value, because the value itself was not a 'recurrsiveArray' (typo there - wasn't sure if I should change that too?)
Added a test to validate/demonstrate what I need (and assume should be correct behavior).
If there's a better way to fix this, please let me know.
I can't be the only one who's hit this, but... I've also been able to simply create an invoice for a customer for 2 days now, and traced it down to this.

Looking at this more, I'm guessing more people use a 'loose collection' style... ?
Invoice::create([
  'CustomerRef'=>['value'=>58],
  'Lines'=>[],// etc
]);

and perhaps this wasn't/isn't a problem?
I was/am using code more like this...
        $customerRef = new IPPReferenceType();
        $customerRef->value = $qbCustomer->Id;
        $customerRef->name = $qbCustomer->FullyQualifiedName;

        $qbInvoice = new IPPInvoice();
        $qbInvoice->CustomerRef = $customerRef;
...
        $qbInvoice->Lines = []; // multiple IPPLines there
        $quickbooks->Add($qbInvoice);

This is where I kept getting "CustomerRef is missing" errors, because the Add() call something that eventually gets down to a serializer - XML or JSON.  The XML one never worked for me...
Trying to get property 'CustomLogger' of non-object in .../vendor/quickbooks/v3-php-sdk/src/Core/Http/Serialization/XmlObjectSerializer.php

When I discovered you could swap with ->useJson() it seemed to get much farther than that, and I got real 'error messages' back - I tried to dig in to the XmlObjectSerializer.php a bit more but... there's some magic going on there that I couldn't get past.
This was a problem for me on both PHP 7.4.20 and 8.0.6.  The 'fix' I have works in both cases.


False Positive on batik-i18n-1.14.jar

False positive on library  batik-i18n-1.14.jar - reported as cpe:2.3:a:i18n_project:i18n:*:*:*:*:*:asp.net:*:*
        <dependency>
            <groupId>org.apache.xmlgraphics</groupId>
            <artifactId>batik-codec</artifactId>
            <version>1.14</version>
            <exclusions>
                <exclusion>
                    <groupId>xml-apis</groupId>
                    <artifactId>xml-apis</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>commons-logging</groupId>
                    <artifactId>commons-logging</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>commons-io</groupId>
                    <artifactId>commons-io</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

Note that batik-codec includes batik-i18n.
Note that this is the same cpe/behaviour as reported in https://github.com/jeremylong/DependencyCheck/issues/3352

duplicate

As mentioned by @mprins, this was a duplicate. The original issue is https://github.com/jeremylong/DependencyCheck/pull/3369, and that issue has been merged.
Closing this issue.

This was a duplicate of https://github.com/jeremylong/DependencyCheck/pull/3369.


Extend web push support

Hi,
this adds some missing annotations for the recently added BrowserRegistrationDescriptions and registers them with the serializer. Besides that, I added some convenience methods to NotificationHubClient in accordance with the already existing ones.
Things to consider before you submit the PR:

[X] Are tests passing locally?
[X] Are the files formatted correctly?
[ ] Did you add unit tests?
[X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Related PRs or issues
#314
Misc
"CreateBrowserTemplateRegistrationAsync" methods are currently not added it INotificationHubClient.

@microsoft-github-policy-service agree company="Hahn Softwareentwicklung GmbH"

Can someone please review this PR?

lgtm

Hey @lomagdal2 , any chance of a Friday treat? 🍦

😴🥺😩 @lomagdal2

😴🥺😩🧟♂💀 @lomagdal2

@lomagdal2

Numbers say it all....

FFS!!!!
Press the flippin button 🤬

Pleeeeeeease aprove!


problem: Subscribe to the Blob storage

can not select  Events button on blob storage page in the "https://portal.azure.cn/" portal, without this feature in "https://portal.azure.cn/" portal? But I could see it on "Resource groups" page, please help confirm the phenomenon.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b250ca39-0ba3-20dc-179b-c5a0d80fba9f
Version Independent ID: 5f1d000e-c731-4b98-8eb7-55836829ca47
Content: Quickstart: Send Blob storage events to web endpoint - portal
Content Source: articles/event-grid/blob-event-quickstart-portal.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@Johnnytechn Can you try in the incognito window and see if that helps. Also can you share the screenshot of the issue to have better clarity.

Try in the incognito window?No,i still can not see it. My doubt is, is the Events feature not supported for Storage Account in China? The following image is from portal.azure.com's web page. However, Evnets button not exists in portal.azure.cn on Storage Account page, but exists on the Resource Group page.Do you understand my problem now?

If someone with a clear understanding of the problem, please help explain. Thanks.

@Johnnytechn Microsoft Azure operated by 21Vianet (Azure China) is a physically separated instance of cloud services located in China. It's independently operated and transacted by Shanghai Blue Cloud Technology Co., Ltd. ("BlueCloud").
Few Microsoft engineers who have special rights for Azure China can play around this.
Recommendation at this point is better to open a support case to troubleshoot this issue together with a service engineer who has deeper insight to your environment. Does your subscription carry a support plan? If not, just let us know.

@Johnnytechn  For now will proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Envelope encryption doesn't preserve MemoryRecord batches

Describe the bug
Currently the envelope encryption Filter flattens multiple batches within a MemoryRecords like this and then uses the metadata from the first batch when constructing the memory records here.
If a Control Batch is present in the proxied brokers FetchResponse and is not the first batch in the MemoryRecords, it will be filtered out and no control batch will reach the client. These batches are used by consumers to filter out aborted transactional messages., so we need to pass these on.
Expected behavior
Batches in the MemoryRecords are preserved including these semantically important single-message control batches.

Tom has a refactor in the works that may address this, or at least move us towards being batch-oriented. Is that right @tombentley?


Fix reverse invoker

Because it was made for a temporary fix, and because how hacky it is for performance, it started causing problems now.
To fix this, I could probably get it to work by using a stack instead of a flag, which the stack gets pushed on invoke, and on Postfix it will get popped or cleared at invoke point

done in master branch


Missing a space

You're missing a space on this bit:
Unit Price and Line Amount Including/Excluding VAT on Sales Documents
When you choose an item number in the No. field on a sales document, Business Central fills in the Unit Price field. The unit price comes from either the Item card or the item prices allowed for the item and customer. Business Centralcalculates the Line Amount when you enter a quantity for the line.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 575da794-2931-9b96-521c-744677513f36
Version Independent ID: 2739bc61-f1db-4814-1980-8d60e50f5fdd
Content: How to work With VAT on Sales and Purchases - Business Central
Content Source: business-central/finance-work-with-vat.md
Service: dynamics365-business-central
GitHub Login: @bholtorf
Microsoft Alias: bholtorf

Thank you for your feedback! This will be fixed in the next doc update.


fix: Revise PR generation against new helper method

Signed-off-by: Terry Cox<EMAIL_ADDRESS>fix: Push as part of creating pull request
fix: Commit as part of creating pull request
fix: Explicitly include title and body

/assign @jstrachan

/approve


Isar Protected Methods

Hi @leisim ,
Thx for the great updates. Really love the embed property feature and the new inspector!
For the new API of Isar, is this possible to make the name-related and index-related methods not be protected? such as deleteByIndex() and getByIndexSync() in IsarCollection and getCollectionByNameInternal() in Isar.
This will allow us to build a general Isar service to reduce the boilerplate coding. e.g. we can create a general delete method to remove an object by its id(not isar id but id of entity). we can also write a method to automatically load links and delete links (for these methods we need to get the collection by its name). I believe opening these APIs will make Isar more flexible and suite for large project architecture, since reuses logic and reduce duplicate codes. (I have actually done all these features with the previous API and it is quite good. But the new API makes these methods to be protected.)

This is really essential to reduce the boilerplate code and improve the speed of development with clean code

Thanks! I made these methods available and added docs. A new version will be released soon!


State leaking between concurrent sessions when useStore comes after an await on SSR

Reproduction
https://github.com/iPrytz/vue3-pinia-ssr-example
Steps to reproduce the bug

Create a SSR Vue application
Create two stores, exampe userStore and myDataStore

initialize userStore with some user data from session, example a sessionId
in myDataStore get (and log) session data from userStore useUserStore().sessionId
then do a fetch with await
then get (and log) data from userStore useUserStore().sessionId again

When tested (for example with autocannon) with multiple different sessions fetching the SSR app at the same time, data will leak between the sessions. SessionId will be different the second time from useStore.
It is solved if const store = useUserStore() and store.sessionId is used both before and after await, but in more complex cases it can still me a missmatch.
For example, in our store, we fetch specific user data connected to the sessionId, but before we do that we need to fetch and await the users profile settings, then we can fetch the specific user data. From our store we call the API and in the API-handler we then add the sessionId/token from userStore, and now we have a missmatch because we do useUserStore() after the await user profile while we have multipe requests comming in to our node server. So the sessionId/token added to the request is now from another user and we get mixed up data.

I added a repo to reproduce the problem, instructions how to test this is found in the README
Expected behavior
Data from useStore should be consistent in one session/request
Actual behavior
Store data gets mixed up between the sessions/requests and the documentation is not clear about how to solve this issue.
It happens after an await
Additional information
I do understand that it might not be a bug specific to pinia, but i can't remember having this issue with vuex.
It should at least be well documented how to structure the stores and await calls to avoid this happening sonce it is a huge risk of data leaks. We have had this problem in multiple projects and we cant really find any good enough documentation on the issue.
And would also love to get some explanation on what is actually hapening and what is causing this behavior.
Thank you to everyone working on this project, you're awesome!! 💯 🙌

You should indeed call useStore before the await or pass the pinia instance to avoid sharing the state across request. This is already documented. Improvements to docs are welcome though 🙌

I don't agree, at least the documentation is not clear enough in the examples.
I can definetly try to add some more examples to the domentation, but do you have time to have a look at the repo and give some feedback on how to best solve it in this scenario when a store is using another store after an await? How do i pass the pinia instance all the way to the api in the best way? Thank you for you time!


Update attributes to be compliant with OpenTelemetry

Remove messaging.masstransit.message_id and replace it by messaging.message.id.
Rename messaging.message.payload_size_bytes to messaging.message.body.size.
Update messaging.system to comply with the list of well-known values (at the end of https://opentelemetry.io/docs/specs/semconv/attributes-registry/messaging/):

sqs => aws_sqs
service-bus => azure_servicebus
event-hub => azure_eventhubs

cc @Kielek

Also, during a process activity, many attributes are missing, such as the messaging.system which is required according to the specification, messagin.message.id (which is very useful, especially when an end-to-end contains more than one message), addresses as well (less useful perhaps but still interesting).
https://github.com/MassTransit/MassTransit/blob/282728da4ab31119e97f97865151a4d68b2b6317/src/MassTransit/Logging/Diagnostics/LogContextActivityExtensions.cs#L92-L158
Do you think we can add them?

@Kielek thank you for your valuable feedback! I applied your suggestions and will be keeping a close eye on version 1.25 of the semantic conventions.
@phatboyg I reverted changes related to the message ID.
During receive activity, messaging.system is missing. This attribute is required according to the specification.
During a process activity, several attributes are missing, such as:

messaging.system (required according to the specification)
messaging.message.id which is very useful, especially when an end-to-end contains more than one message (only if activity.IsAllDataRequested)
addresses (source and destination), less useful perhaps but still interesting (only if activity.IsAllDataRequested as well).

https://github.com/MassTransit/MassTransit/blob/282728da4ab31119e97f97865151a4d68b2b6317/src/MassTransit/Logging/Diagnostics/LogContextActivityExtensions.cs#L92-L158
Do you think we can add them?

Semantic convention is in the way to be stable. Especially there were few changes after releasing latest 1.24.0 which are not reflected in this PR (see suggestions).

We're planning to declare stability in the first half of 2024. During this process more breaking changes are possible, and we're about to add a warning to the messaging semantic conventions that existing instrumentations should not be updated until stability is declared (to avoid multiple breaking changes).
It's great to see MassTransit catching up with the conventions, and it is extremely valuable for us to see how the changes we make to the conventions impact existing instrumentations. However, I'd recommend to maybe keep this PR open and up-to-date with semantic conventions, but not to make changes available to MT customers until conventions are declared stable.

Also, besides some attributes names, also operation names and their semantics changed. There's now "publish" and "create" for producer operations, "receive" for pull-based consumption and "deliver" for push-based consumption.
However, there currently are discussions about changing "deliver" to a more generic "process" operation, so again I'd wait for stability before applying any changes here.

Thank you @pyohannes for your feedback!
@phatboyg I added some additional attributes (only if activity.IsAllDataRequested) in the receive and process activities to have the same level of information as in the send activity (except messaging.system because I wasn't able to retrieve the information, which from what I've seen is currently only available in the case of a send. We can look at adding it later.)
I can create a separate PR for this part if you want and we can keep this one open regarding the rename of some attributes/values. I'll keep a close eye on the spec until the stable version and update this PR accordingly.

server.address is not set.  It seems peer.address is used instead (not part of otel spec)

Currently peer.address has the following format: message_type/message_namespace:
https://github.com/MassTransit/MassTransit/blob/2d481dbed1263ca32273ce800f609d7fb647da83/src/MassTransit.Abstractions/MessageTypeCache.cs#L303-L318
I don't think server.address is the correct attribute for this value. peer.address either, by the way.

operation name does not match spec (send ->publish, I saw process is used, which is probably good https://github.com/open-telemetry/semantic-conventions/pull/700)

You can probably check this comment to understand why MT uses send for messaging.operation: https://github.com/MassTransit/MassTransit/discussions/3995#discussioncomment-4629048

Regarding the comment on send vs publish, and other things. OTEL is evolving, and some of the pedantic silliness of the original specification needs to be dropped. peer.address was in the original specification, and it was important to understand how it was used by applications that actually consume the tags. Without that consideration, which will probably require vendors to actually document what tags they use and for what purpose, the specification will continue to fragment and be only usable as a medium vs. any sort of content rules.
MassTransit was built with the specification at the time, but it has clearly evolved beyond those original tag values. And yet, it still doesn't have send and thinks source.address should the FQDN of the broker... Sigh.

messaging.destination.name is set on producer  operations, but not  consumer operations

I don't think the destination name is available in the ConsumeContext like it is with SendTransportContext.

error.type is not reported in case of errors

error.type does not appear to be a valid attribute in the case of errors: https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-spans. Only for HTTP spans: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#common-attributes. @lmolkova could you please clarify?

@phatboyg I updated the initial comment of this PR with the changes applied. Test failures seem unrelated, this PR is ready to be reviewed.

I manually adjusted this and merged it.


Switched to our LGTM container

Signed-off-by: Thomas Boerger<EMAIL_ADDRESS>

LGTM (if needed)

Since I have already applied it you can see that the auto labeling works ;)

Great! Is there any way to also get those labels addition events attributed to a "bot" user ?

LGTM

It seems lgtm/need 1 has not been removed.

Maybe a big within the lgtm implementation?

I will review the code.


Circular dependency when using fixtures

It might be that I'm doing something wrong, but here's the thing:
I'm using the fixture dependency feature while unit testing in Yii 2.0.6. I have a situation here whereby one table refers to another table, but that the other table also refers to the former table. Using InnoDB's foreign key definitions, both tables require each other. Therefore I defined the $depends attribute accordingly for both fixtures.
I simplified the case into the following two fixtures:
class UserFixture extends ActiveFixture
{
    public $modelClass = 'common\models\User';
    public $depends = [
        'tests\codeception\common\fixtures\CityFixture',
    ];
}

class CityFixture extends ActiveFixture
{
    public $modelClass = 'common\models\City';
    public $depends = [
        'tests\codeception\common\fixtures\UserFixture',
    ];
}

However, I receive the following error when executing the codeception tests:

yii\base\InvalidConfigException: A circular dependency is detected for fixture 'tests\codeception\common\fixtures\UserFixture'.
#1  /htdocs/app/vendor/yiisoft/yii2/test/FixtureTrait.php:132
#2  /htdocs/app/vendor/yiisoft/yii2/test/FixtureTrait.php:109
#3  /htdocs/app/vendor/yiisoft/yii2-codeception/TestCase.php:85
#4  /htdocs/app/tests/codeception/common/unit/models/UserTest.php:20

Am I doing something wrong, or is the framework not supporting such a relationship for AR fixtures yet?

The message clearly states that a circular dependency is a problem. Dependencies are mostly useful if you have foreign keys that need to match so we can not support circular dependencies. If you need user and city together you may create another fixture that depends on both.

That's indeed an option, but I have many tables with circular relationships. Creating a fixture for every circular dependency is generating a fixture forest here.
I don't see how circular dependency is actually a problem in this case where foreign key integrity checks are turned off. Why not just check if the circulated fixture is already being loaded, and if so, ignore it, and otherwise add it to the load stack? I tested it by just commenting out the error throwing in FixtureTrait, it actually works like a charm... What is the real problem that may occur for fixtures in a testing environment so that an exception is required?


fix: Wrong timeout configuration value

What type of PR is this?
/kind bug

What this PR does / why we need it:
When I watch clueterpeida, the connection is always disconnected around 1 minute. When I watch the api-server of k8s, it will not.
"c.GenericConfig.MinRequestTimeout" should be used instead of "c.GenericConfig.RequestTimeout,"
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

/auto-cc

/lgtm Thanks for fixing it

@OrangeBao DCO action is failed, please fix it https://github.com/clusterpedia-io/clusterpedia/pull/494/checks?check_run_id=11301816895
There is also something wrong with the configuration of the author of the commit that does not recognize you, although it is not necessary, but you will be missing from our contributors

ok, i have fixed it. please review.

@OrangeBao DCO action is failed, please fix it https://github.com/clusterpedia-io/clusterpedia/pull/494/checks?check_run_id=11301816895
There is also something wrong with the configuration of the author of the commit that does not recognize you, although it is not necessary, but you will be missing from our contributors

ok, i have fixed it. please review.

sorry, Wait a moment.

/lgtm


[Feature] Add pagination or loading icon on transactions window.

Feature description
Hi, I have a lot of transactions on transactions window. I see it's a little slow to load transactions. I think this could be solved by adding pagination or a loading icon. See the video:
https://user-images.githubusercontent.com/1178856/224490183-4fae7224-6186-400f-9a30-94175ea29cda.mp4
Describe the solution
I think this could be solved by adding pagination or a loading icon.
Describe alternatives
No response
Additional context
No response
Are you working on this?
No

@lujakob did you experience this as well during develeopment?

@escapedcat I tested loading time by adding 1000 payments to the IndexDB and it was still really quick. A loading spinner wouldn't hurt in any case. You could assign me I could add one.
Regarding pagination/load-more: if there is already a strategy for other pages, I could also add it here. Especially with the Nostr tipping they might increase a lot quicker than I originally expected. We already have pagination somewhere?

I created a PR to add a loading spinner as a first step, as it doesn't hurt in any case.

@escapedcat I noticed the "Websites" page doesn't have a loading spinner as well. Should I create an issue and add it there as well for consistency reasons?

@lujakob yeah, I guess that would make sense, wdyt @reneaaron ?

That would be awesome, thanks @lujakob!

Proposed pagination design here https://github.com/getAlby/lightning-browser-extension/issues/1839#issuecomment-1464137219

Thanks @stackingsaunter
@reneaaron if the pagination component is being used in websites and transactions, I think we should coordinate, otherwise we will implement it twice. What is the state of the issue #1839 Has this already been started? Should I wait or should I go now?


Draft: feat: use alby-js-sdk client (WIP)

is there any blocker in this part of code? as you mentioned TODO. authClient.isAccessTokenexpired() will do the job here right?
  if (this.config.oAuthToken) {
        console.info("Requesting new oAuth token");
        try {
          // TODO: only do this if access token has expired
          console.log(authClient);
          const token = await authClient.refreshAccessToken();
          await this._updateOAuthToken(token.token);
          console.log(authClient);

          return authClient;
        } catch (error) {
          console.error("Failed to request new auth token", error);
        }
      }
     ```

i am always geting such symbol

how the authroize function is handling refresh token expiry?

how the authroize function is handling refresh token expiry?

if requesting a new access token fails we know the refresh token is invalid

i am always geting such symbol

Ah, I see this happens if you have no lightning address. Fixed, it will use "Alby" as the default like you previously had


:sparkles: Add pathToExecutable option to allow for using custom inst…

…allations of woke cli tool
This will allow me to debug my local build of woke cli tool so I can make PRs there more easily or at the very lest let me run my own fork of woke.

Also fixes #53


Manage locales

By using Day.js (see #4), I don't have to worry about locales because it will only build the ones that are asked by the dev.


Pauseable rendering breaks after rendering preview

If the fetch response completes before the paused preview render completes, the visit will attempt to render twice whilst a render is in progress, raising:
https://github.com/hotwired/turbo/blob/49f82135e2a5ec8e3279f78373d69214d06a34fa/src/core/view.ts#L50
A quick fix is to disable previews, but ideally, in the case of animating page transitions, the preview would animate in first, and then be seemlessly replaced by the server response.

cc @kirillplatonov

Checking it


latest doesn't account for wrap around

For example:
Data.RingBuffer Data.Vector> x <- new 2 :: IO (RingBuffer Vector Int)
Data.RingBuffer Data.Vector> append 0 x
Data.RingBuffer Data.Vector> append 1 x
Data.RingBuffer Data.Vector> append 2 x
Data.RingBuffer Data.Vector> latest x 0
Just 1

Looking at the implementation of latest and latest', they don't even mention ringHead at all, which can't be right. This also affects the correctness of toList compared to its documented behavior.

In length' the formula for idx should be ringHead - n - 1.

Oh dear, that is terrible! Thank you for pointing this out. Fix coming.

Fix released as 0.4.


Predict upgrade

For https://github.com/CUNY-CL/yoyodyne/issues/26
Major changes:
-- base encoder now contains predict_step that applies to lstm and transformer models.
--Put wrapper around base_encoder.__get_loss method (explained below)
@Adamits  @kylebgorman  This is a minor fix but want to get y'alls thoughts on best practices: While going through this, it looks like we were using two logics for forward passes. For training, tensors were assumed to be of shape B x vocab x sequence_len while on prediction they were assumed as B x sequence_len x vocab . This isn't ideal and led to a bunch of transpose steps that were somewhat unnecessary. I've tried to unify them under the assumption that alll forward passes predict a tensor of shape B x sequence_len x vocab
Channeling my innner Guido I want to suggest the following:

All forward passes (unless in specialized cases), produce tensors of one unified shape. My preference is for B x seq_len x vocab_size but am open to other arguments.
base_encoder._get_predictions should only be called on decoder outputs. Since this is really only a wrapper for max, I think it's more important to save semantic sanity than using it for condensing code.

Anyway, these are just my thoughts.

@Adamits @kylebgorman This is a minor fix but want to get y'alls thoughts on best practices: While going through this, it looks like we were using two logics for forward passes. For training, tensors were assumed to be of shape B x vocab x sequence_len while on prediction they were assumed as B x sequence_len x vocab . This isn't ideal and led to a bunch of transpose steps that were somewhat unnecessary. I've tried to unify them under the assumption that alll forward passes predict a tensor of shape B x sequence_len x vocab

Oof, is that so? Glad you fixed.

Channeling my innner Guido I want to suggest the following:

All forward passes (unless in specialized cases), produce tensors of one unified shape. My preference is for B x seq_len x vocab_size but am open to other arguments.

No preference so long as it's consistent and batch size is the leading dimension.

All forward passes (unless in specialized cases), produce tensors of one unified shape. My preference is for B x seq_len x vocab_size but am open to other arguments.

No preference so long as it's consistent and batch size is the leading dimension.

Revising my comment after reviewing. If the loss function wants it one way, we should just do it that way everywhere unless there's some other built-in that wants it transposed.

Revising my comment after reviewing. If the loss function wants it one way, we should just do it that way everywhere unless there's some other built-in that wants it transposed.

That can be done, but many of the forward passes have a default of B x seq_len x vocab_size, so doing the other way adds in quite a few transpose operations. It also means base._get_predictions is more limited in when it can be called (to make semantic sense, it would have to operate on a different dimension, so can't be called with some of the lstm outputs until bottom of the forward pass.
transpose is a cheap operation iirc, but I personally find too many of them hard to follow on a code edit. If this is just a me problem I'm fine with the other way.

That can be done, but many of the forward passes have a default of B x seq_len x vocab_size,

Can't we just change this too? If so we should.

transpose is a cheap operation iirc, but I personally find too many of them hard to follow on a code edit. If this is just a me problem I'm fine with the other way.

No you're right, they're awful.

Can't we just change this too? If so we should.

Nah, this is a product of the pytorch operations. Particularly how lstms have a weird output behavior. Adam did a good job and still you have weirdness like tensor.tranpose(0,1).tranpose(1,2)

Ignore changes to unrelated files, my linters are having issues for some reason

Started reviewing and realized that I am pretty sure there is overlap with #46, which I reviewed first. Should I look at all commits here?

#46 is just a superset of this, I believe; it has one more commit than this one (#44).

Adams recs are done in the other PR to avoid commit conflicts.

Adams recs are done in the other PR to avoid commit conflicts.

So does that mean this is ready?


Embed variable in pipeline is broken

Expected Behavior
embed variable in pipeline tasks' params like below:
params:
      - name: IMAGE
        value: "$(tasks.get-branch.results.image)"

tasks.get-branch.results.image actual value is
docker.io/user/web:tagname

Expect values is  docker.io/user/web:tagname
Actual Behavior
In Pipelinerun, the actual value is
|
  docker.io/user/web:tagname

Additional prefix "|
" had been added in the values
Steps to Reproduce the Problem

Additional Info

Kubernetes version: v1.19.4+k3s1
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.1", GitCommit:"c4d752765b3bbac2237bf87cf0b1c2e307844666", GitTreeState:"clean", BuildDate:"2020-12-19T08:38:20Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4+k3s1", GitCommit:"2532c10faad43e2b6e728fdcc01662dc13d37764", GitTreeState:"clean", BuildDate:"2020-11-18T22:11:18Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}

- Tekton Pipeline version: `v0.19.0`

**Output of `tkn version` or `kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'`**

<!-- Any other additional information -->

@gsmlg Could you post your pr definition?

This is the pr definition in tt
apiVersion: triggers.tekton.dev/v1alpha1
kind: TriggerTemplate
metadata:
  name: web-push
  namespace: devops
spec:
  params:
  - name: project_name
    description: Project Name
    default: web
  - name: revision
    description: The git revision
    default: master
  - name: repository_url
    description: The git repository url
    default: git@gitlab.somewhere.dev:group/web.git
  - name: user_name
    description: The gitlab user display name
    default: ''
  - name: user_username
    default: ''
  - name: user_email
    description: The gitlab user email
    default: ''
  - name: ref
    description: The git commit ref
    default: ''
  resourcetemplates:
    - apiVersion: tekton.dev/v1beta1
      kind: PipelineRun
      metadata:
        generateName: web-push-run-
        namespace: devops
      spec:
        serviceAccountName: pipeline-run-service
        pipelineRef:
          name: web-push
        timeout: "2h0m0s"
        workspaces:
          - name: repo
            volumeClaimTemplate:
              spec:
                storageClassName: nfs
                accessModes:
                  - ReadWriteMany
                resources:
                  requests:
                    storage: 1Gi
        params:
          - name: project_name
            value: $(tt.params.project_name)
          - name: repository_url
            value: $(tt.params.repository_url)
          - name: revision
            value: $(tt.params.revision)
          - name: ref
            value: $(tt.params.ref)
          - name: user_name
            value: $(tt.params.user_name)
          - name: user_username
            value: $(tt.params.user_username)
          - name: user_email
            value: $(tt.params.user_email)

And the pipeline definition:
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: web-push
  namespace: devops
spec:
  params:
    - name: project_name
      type: string
      description: project name
      default: group/web
    - name: repository_url
      type: string
      default: git@gitlab.somewhere.dev:group/web.git
    - name: revision
      type: string
      default: master
    - name: ref
      type: string
      default: refs/origin/master
    - name: user_name
      type: string
      description: gitlab user display name
      default: 'bot'
    - name: user_username
      type: string
      description: git username
      default: webbot
    - name: user_email
      type: string
      description: gitlab user email
      default<EMAIL_ADDRESS>  workspaces:
  - name: repo
    description: |
      This workspace will receive the cloned git repo and be passed
      to the next Task for the repo's README.md file to be read.
  tasks:
    - name: clone-repo
      taskRef:
        name: git-clone
      workspaces:
      - name: output
        workspace: repo
      params:
      - name: url
        value: $(params.repository_url)
      - name: revision
        value: $(params.revision)
    - name: get-branch
      params:
        - name: ref
          value: $(params.ref)
      taskRef:
        name: get-branch-from-ref
    - name: build-image
      taskRef:
        name: kaniko
      runAfter:
        - "clone-repo"  # Wait until the clone is done before reading the readme.
        - "get-branch"
      params:
      - name: IMAGE
        value: "$(tasks.get-branch.results.image)"
      workspaces:
      - name: source
        workspace: repo
    - name: ding
      taskRef:
        name: ding-message
      runAfter:
        - "build-image"
      params:
        - name: message
          value: Successful build image docker.io/group/web:$(tasks.get-branch.results.branch)

How does the get-branch-from-ref Task generate the image result?  It looks to me like it might be accidentally introducing some extra characters to the result data written to /tekton/results/image.

How does the get-branch-from-ref Task generate the image result?  It looks to me like it might be accidentally introducing some extra characters to the result data written to /tekton/results/image.

@sbwsg
This is the get-bran ch-from-ref task
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: get-branch-from-ref
  namespace: devops
spec:
  results:
    - name: branch
      description: output branch name
    - name: image
      description: output image address
  params:
    - name: ref
      type: string
  steps:
    - name: run
      image: alpine:3.12
      script: |-
        REF=$(params.ref)
        BRANCH=$(echo ${REF} | sed 's;refs/[a-zA-Z0-9]*/;;g' | sed 's;/;-;g')
        echo ${BRANCH} | tee -a $(results.branch.path)
        echo "docker.zdns.cn/zcloud/web:${BRANCH}" | tee -a $(results.image.path)

I'd tried to emmbed branch in a string value like this "docker.zdns.cn/zcloud/web:$(tasks.get-branch.results.branch)" and it output same result.

@sbwsg
This is the get-bran ch-from-ref task
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: get-branch-from-ref
  namespace: devops
spec:
  results:
    - name: branch
      description: output branch name
    - name: image
      description: output image address
  params:
    - name: ref
      type: string
  steps:
    - name: run
      image: alpine:3.12
      script: |-
        REF=$(params.ref)
        BRANCH=$(echo ${REF} | sed 's;refs/[a-zA-Z0-9]*/;;g' | sed 's;/;-;g')
        echo ${BRANCH} | tee -a $(results.branch.path)
        echo "docker.zdns.cn/zcloud/web:${BRANCH}" | tee -a $(results.image.path)

I'd tried to emmbed branch in a string value like this "docker.zdns.cn/zcloud/web:$(tasks.get-branch.results.branch)" and it output same result.

OK much appreciated, I'll try and reproduce today.

OK much appreciated, I'll try and reproduce today.

echo will append a newline by default.  You have to use the -n flag to suppress this.  This is what a lot of the catalog tasks do.  For example see the use of echo -n in https://github.com/tektoncd/catalog/blob/master/task/git-clone/0.2/git-clone.yaml.  You have multiple echo commands in your task so you may need to inspect carefully what each one is doing with respect to newlines.
Another technique is to use tr -d "\n" to remove newlines.  See https://github.com/tektoncd/catalog/blob/master/task/generate-build-id/0.1/generate-build-id.yaml for an example of that.

echo will append a newline by default.  You have to use the -n flag to suppress this.  This is what a lot of the catalog tasks do.  For example see the use of echo -n in https://github.com/tektoncd/catalog/blob/master/task/git-clone/0.2/git-clone.yaml.  You have multiple echo commands in your task so you may need to inspect carefully what each one is doing with respect to newlines.
Another technique is to use tr -d "\n" to remove newlines.  See https://github.com/tektoncd/catalog/blob/master/task/generate-build-id/0.1/generate-build-id.yaml for an example of that.

Awesome, I see, the "\n" change the value to a multi-line value.

Awesome, I see, the "\n" change the value to a multi-line value.


bump source-map-support

In order to integrate with the a new version of cucumber-js, need source-map-support to be up to date.
cucumber-js listens for uncaughtException, as does source-map-support. With 0.3.2, source-map-support will not exit on uncaughtException, if there are other listeners.

I signed it!

Thanks @charlierudolph for looking into the issue. Merged with https://github.com/angular/protractor/commit/372263f93acf94334eee0547a4ad4152dd8a5842


Update patch75.sql

Does this allow the patch to run ?

yup, tested it and then ran, all good, thank you


Add WebGPU Support

WebGPU is a new API that lets web applications leverage the power of modern hardware for general purpose computation.  After six years of development, it was just released in beta on Chrome for Windows, Mac, and ChromeOS.  All major browsers are currently working on adding support (it can already be enabled in Safari, Firefox, Edge, etc. with a flag), and Android and iOS support are coming as well.  For more, see the beta release announcement here: https://developer.chrome.com/blog/webgpu-release/
WebGPU might enable much faster model run speeds on modern devices.  This might allow models to perform more calculations (such as full 8760-hour electricity dispatch) while still running the model quickly enough to feel interactive.  It would also be useful for optimization and genetic algorithms, where a model may need to be run many times, with the computer varying the settings each time, to home in on an optimal solution defined by a goal function.
A modern GPU can have over 1,000 cores, vastly more than a CPU.  Assuming WebGPU abstracts the process of distributing work among GPU cores, runspeed might increase by orders of magnitude.
WebGPU can be invoked by WebAssembly code generated by Emscripten.  Here's a repo I found where someone built tools to do this: https://github.com/juj/wasm_webgpu .  Therefore, it appears that WebGPU is not a replacement for WebAssembly but rather could be added on for further speed gains.
It would be useful to investigate how easy or difficult it would be to use the WebGPU API and see what sort of runspeed improvement it provides.  If the runspeed improvement is dramatic, it might be worthwhile to plan to migrate to WebGPU as the standard method of running models once the WebGPU API is broadly supported across browsers and operating systems, as it likely will be in a couple years.

This is something that could have a big payoff for large models. Developing a demo with Emscripten could be a quick project. I think it would need to be optional for the code generator until it matures. Jeff's proposal contains two use cases — interactive speedup on a personal computer, which would have a modest number of GPU cores; and a big speedup when running models on a cloud server with ~1000 GPU cores. I don't think anyone has used SDEverywhere the second way, but it is certainly a possibility for either C or WebAssembly code.

Another way to look at it is in floating point operations per second, where GPUs have orders-of-magnitude edge over CPUs.  Here's a chart from Cornell University:

That chart only goes up through 2016 or so.  The current-generation GeForce 4000 series has between 23 and 83 teraflops of computing power depending on the graphics card model (single precision), according to this Wikipedia chart.
Cornell says: "CPUs are typically designed for multitasking and fast serial processing, while GPUs are designed to produce high computational throughput using their massively parallel architectures...  One can ask: given a device that delivers such impressive floating-point performance, is it possible to use it for something besides graphics?"

This chart from SETI (Berkeley) gives Intel CPU GFLOPs as generally being between 20-80 for most computers, which is about 1000 times smaller than the Nvidia 4000-series GPUs, at 20-80 TFLOPs.  But the Cornell graph above suggests something closer to a 10x difference, not a 1000x difference.  I'm not sure how to reconcile the difference between these sources.
We'd probably need to run a test like Todd suggested with the idea of an Emscripten demo to see what sort of performance we see.  Much might depend on how much overhead there is, or if there are bottlenecks we don't encounter today but which would become relevant if the model computation is 10-1000x faster.

Thanks for filing.  I've been interested for some time in making a small prototype of SDE compilation using WebGPU on the backend to see where it can be beneficial, if at all.
I'm hesitant because the highly sequential nature of typical SD model calculations doesn't align well with what GPUs are best at (parallel operations without interdependencies).  It's possible that there are some kinds of SD models that can benefit, for example, a model that has equations operating on dimensions with a large number of subscripts (where vectorization can help).
In a past life my day job was in accelerating imaging and graphics operations on the GPU, and a lot of the development time goes into the tedious parts of putting data into optimal layouts in buffers and keeping overhead low when shuttling those buffers to/from the GPU.
One such task for SDE (that's likely a prerequisite for a WebGPU backend, but also might be helpful for C or JS backends for other reasons) is to allow code gen to use a single buffer for input/intermediate/output values (accessed by named indices) instead of global variables.  I have a few other recommendations for changes in SDE that would be beneficial to implement before embarking on WebGPU support.

That's good to know, Chris.  Thanks.
I do not have the background to get into technical detail about WebGPU or SDE, but I can at least give a sense of where/how the EPS and similar SD models might take advantage of this capability:
The EPS has many non-time subscripts and does a lot of operations in parallel for many subscript elements that don't depend on each other.  For instance, everything that happens in the transportation sector happens in parallel for 12 vehicle types, so if all 12 could be done simultaneously rather than in sequence, that could help.  Similarly, in the Industry sector, there are around 25 industry categories, each of which is calculated independently of the others.  The electricity sector is a more extreme example, where the model may make separate calculations for up to 8,760 hours per annual timestep.  No knowledge of any past hour is used in calculating the next hour.  We moved away from simulating all 8,760 hours because the runspeed impacts were too severe, but with a parallel architecture, maybe it could be fast enough.  But as it is, we still are doing a few hundred hours (per timestep) sequentially, and this accounts for the majority of the total time required to run the EPS.  And each economic sector runs independently of the others, so we could be doing the transportation sector calculations and the electricity sector calculations simultaneously.  Even if we can only accelerate operations by parallelizing calculations for non-interacting subscript elements or non-interacting variables, that would be enough to allow the EPS to run many times faster.
Note that there is usually a SUM function at the end, such as adding up the emissions or energy use from all 12 vehicle types or from all 25 industry categories.  So although the subscripts are calculated independently and could be done in parallel, there are operations at the end that need the results of all the subscripts to be available, usually summing things to make totals that will be displayed on the graph.
There are also cases where the elements of a subscript only interact at one or two points per timestep during the calculation flow.  For example, there is a moment when new electric generating capacity to be constructed is allocated across 20 power plant types, and another moment when electricity demand is met by dispatching a mix of those 20 plant types.  In these two allocation operations, each plant type influences the results for the other plant types.  But apart from these two allocation operations, a lot of computation happens independently for each of the 20 plant types.  So if it's possible to accelerate the portions of the code in between the allocation steps using a GPU, rather than requiring that the subscript elements never interact with each other, that would expand the relevance of WebGPU to cover essentially all non-time subscripts in almost any SD model.
Anyway, I opened this issue just as a suggestion for consideration of a powerful new capability on a roadmap.  It's not something I expected us to work on in the short term.  It sounds like you want to do some other improvements to SDE that would facilitate eventual WebGPU support.  If you do end up making that "small prototype of SDE compilation using WebGPU on the backend," I'd be very curious to learn what you discover.

@jrissman: Thanks for that detailed context, Jeff.  It will be interesting to see what improvement WebGPU can provide for that use case.  If you happen to have a standalone model available (or one that replicates the use case) that would be helpful, otherwise I'll get in touch with you and Todd later down the road (maybe for private access to that EPS variant) if I find time to look into this.

Or if you want a version of the EPS that runs too slowly without WebGPU, you can use this old commit, which is from when we were trying to simulate all 8,760 hours per year, before we moved to representative timeslices as a speed optimization:
https://github.com/EnergyInnovation/eps-us/commit/2e3acf8e8ecb4cb97d515c8d49a8f794d787d5cb


Old Closing Keyboard approach is causing Problems in Login/Sign up screen

Some time ago I implemented the closing Keyboard method and it worked fine in my opinion but today when I went to login screen for testing something I found some bug which was not pretty annoying and I take all fault for that.
Sorry, @sitamadex11 I would like to rectify the problem, and this time I have checked a lot, and please check too.
I will give recordings below.
old:
https://user-images.githubusercontent.com/75211982/136546431-b566dd10-4371-4221-92c8-1a3c9ae2a962.mp4
new:
https://user-images.githubusercontent.com/75211982/136546463-15d5148b-a037-44ac-8382-df359484785b.mp4

I hope you @sitamadex11  give me chance to rectify the problem and again sorry for the implementation. I should have tested one more time :/


yielding for completed-signal does not work with more than one yield inside a coroutine

This probably isn't as much a bug as maybe a design flaw.
Godot version:
3.0.2
OS/device including version:
Windows 10 / in editor
Issue description:
When a function contains the yield keyword it returns a GDFunctionState. That GDFunctionState in turn has a "completed" signal. So you can run coroutines synchronously using
yield(coroutine(), "completed")
Once a coroutine contains more than one yield-command that doesn't work anymore - I am guessing because the outer yield waits for the first GDFunctionState to emit "completed", but that GDFunctionState is discarded and replaced with the one from the second inner yield.
Steps to reproduce:
In this code "ready is over" is printed once the Button is pressed:
extends Node

func _ready():
	yield(test(), "completed")
	print("ready is over")

func test():
	yield($Button, "pressed")

But here it's never printed because the GDFunctionState returned first by test() does never complete:
extends Node

func _ready():
	yield(test(), "completed")
	print("ready is over")

func test():
	yield($Button, "pressed")
	yield($Button2, "pressed")

This third version works, but of course it's not a good solution because you would have to know how many times to resume before yielding for the complete-signal:
extends Node

func _ready():
	var state = test()
	var state2 = state.resume()
	yield(state2, "completed")
	print("ready is over")

func test():
	yield($Button, "pressed")
	yield($Button2, "pressed")

So in case it's not clear: what I am suggesting is that there should be a way to wait for a coroutine to complete. Be it either by changing the behaviour of the yield keyword so the returned GDFunctionState is updated rather than replaced or by introducing a new mechanic similar to C#'s await keyword.

I agree with this. I didn't end up yet in a situation like this in Godot, but I had it many times in other projects, and the few times I experimented with Godot's yield I thought this limitation would occur.
Could GDScript support yield enumerators as in C#? This is where I learned the first time how to use yield, which I use extensively today, but when I started using yield in GDScript, sure it does some job, but I feel it's kind of limited in comparison.

This looks like a regression to me. I'm sure I tested those use cases when I added the "completed" signal to GDFunctionState, since that's the exact purpose I added this signal for. There is even a code snippet in the PR: #8573

Hopefully it is - but in the PR you linked there's only one code snippet that looks like my first example (with only one yield in the coroutine), and that's the case that works. It's when there are two or more yields in the coroutine that the "completed"-signal doesn't work anymore. Or did you refer to a different code snippet that I missed?

@Zylann: please keep in mind that GDscript's yield is targeted at coroutines, so it's more like C#'s async and await keywords than its yield keyword. The yield keyword is only used as a workaround in Unity's C# because they didn't support C# 4.0 or higher for a long time.

Looking at the current implementation it seems like a reasonable solution to store the previous GDScriptFunctionState in every returned GDScriptFunctionState. So when a GDScriptFunctionState determines that it should not signal its "completed" signal in gdscript_function.cpp:1539 it should store a pointer to itself in the new GDScriptFunctionState it just deteced. That way when the coroutine ends and completed is true the "completed" signal can be emitted not only for the current state but also for all previous ones until the first one is reached where the previousState-pointer is empty.

I submitted a PR with the solution I described in the last response.
Feedback welcome, especially since it triggers a warning that I don't quite understand (details in the PR description).

Wasn't this solved by the PR?


Updating to reflect v1.4 target and TypeScript use

Note: The Travis CI build failed, but the only change I made was to README.md.

Landed as e9f1b97ea30a38eb865cbaf34dc8c3692c0b42a1.


Allow to pass proxy configs to axios

(aslo upgrade axios to 0.27.2)
Closes https://github.com/lensapp/lens-platform-sdk/issues/276

I added 'minor' label


Privatize decoding

taking over #3615

Current coverage is 87.36% (diff: 100%)

No coverage report found for master at b7771ef.

Powered by Codecov. Last update b7771ef...6f9d9a5

+1 for merge from me

+1 too.

thanks!


I uploaded the data to use before the fetch and then it updates when the api call is successful.  seems to have worked well.


error generating encrypted key

https://github.com/Hygieia/Hygieia/issues/2219  thiss isue provided me the alternative


Curse/Curseforge?

Any news on uploading Mekanism to Curse/Curseforge?

I'm hoping to get a few more bug fix releases out first.  It'll be out soon :)

Oh nice... Thanks :D

...It's been a month.  Any update on this?

Yea... Still waiting for Mekanism. :/


example/router Link component is not work

Yew: master branch
Browser: Microsoft Edge
OS: MacOS


Add ctu-clang6 compatibility

Clang 6.0 has new parameters to trigger CTU functionality. Also the API was renamed from XTU to CTU. This puts both 5.0 and 6.0 compatible parameters into the clangsa call, so all clang versions will work.

Yes. With this, no remaining XTU references are there in the code.

@gerazo this will work with the current clang5 ctu branch too right?

Yes, it will.

március 29. 16:35:07 CEST, Gyorgy Orban<EMAIL_ADDRESS>írta:

@gerazo this will work with the current clang5 ctu branch too right?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/Ericsson/codechecker/pull/1490#issuecomment-377255164

New formatting is in place.


Missing "resolved" and "integrity" from lock file

Thank you for this cool project! To make elm-watch easier to use on nix based systems, I have been trying to package this project as a nix flake. While doing that, I noticed that a lot of the dependencies listed in the packages value in package-lock.json are missing their resolved and integrity information. For example, yallist and ansi-styles. I have tried adding in these fields but it seems like there are too many missing to be able to do this by hand.
This issue of missing hashes isn't specific to elm-watch - it seems several other npm packages suffer from this issue.
The only way I could add these fields back in was to remove package-lock.json (and my local node_modules directory) and run npm install. While this does fix the missing fields, it also updates every package to the latest one, meaning my nix flake version of elm-watch isn't identical to the one you provide.
What are your thoughts about adding in the missing resolved and integrity fields, either by  regenerating  package-lock.json or another method?

Hi!
I would be fine with regenerating package-lock.json.
But before we do that: Next time I update or change dependencies, how do I verify that I don’t re-introduce this issue? There must be some bug in npm causing it because I never touch package-lock.json by hand.

Good question. I'm not entirely sure of a way that doesn't involve trying to build something with nix. It seems like the issue occurs when trying to install a package that already exists in node_modules or npm's cache (see this issue).
I will see if I can write a script that can "fix" a lock file. I really don't like the solution of having to delete the lock file - it seems to defeat the whole purpose of a lock file!

I have made a python script that adds the missing fields into a package-lock.json. It can be found here. It's not packaged particularly well, but it does build with nix, if you use that. I will improve the python packaging over the weekend when I have a free moment.
This will allow the lock file to be updated without being deleted.
You don't have to integrate this into your workflow if you don't want to. I'm also happy to use this code to generate a patch file for my flake wrapper

Okay, I improved the packaging of the python script. It should be usable with setuptools now.

I'm happy to close this issue, since it isn't really an issue for normal elm-watch usage.


Grep for DROP as well as REJECT

Grepping for DROP is also necessary for some configurations (e.g. my DigitalOcean server with fail2ban) when detecting whether or not to add extra whitelist rules to iptables.

You are right and I can't understand why did I miss this in the first place.
I've pushed a different commit using a better form of grep and adding it to the removal process too.
Thank you!

Thanks! No worries


EXPLORE GAME DOCS AND STRUCTURE

Description
The funniest part of this project 🎉
We need to use all our programming skills here! This is the main part, the attractive one, by clicking in the next links we will be able to see all the games code and documentation. Our objetive consists on investigating this tasks.
Reference:
https://drive.google.com/drive/folders/1686WGqZfeRdeXmGgL5Gjy9oZnMH2_lmo?usp=sharing
Tasks

How does it works?
How can we embed this on our project?
Which methods are useful for getting client's score, level, times played

Info I gathered from the first game (SKEET CHALLENGE):

The game only has 1 level
The level ends when there are no more targets left.
The score can only be saved at the end of the game.
You can't save the score unless you go through all the targets, if you exit the game before going through all the targets the score is lost and there is no way to access it.
The game can only be started from the beginning, there is no way to start from a given target or to set the initial score.
The only parameters that can be modified are the max number of points given by shooting a target, the speed of the targets and the speed/acceleretion of the gun scope.

Info from second game (EASTER MEMORY)

The game has 4 levels, each time a new level starts the start_level and save_score methods are called, meaning the score can be saved after each level.
The game ends after the 4 levels are cleared or after you run out of time in a level. When the game ends the end_level and save_score methods are called.
Like the first game it can only be started from the beginning, there is no way to start from a given level.
If you exit the game before finishing all the levels or running out of time the score from the last level is lost.
The parameters that can be modified are:

The number of cards per level
Time per level
Score per card match
Multiplier assigned to remaining level time
Time window to get score multiplier
Time to show cards before starting the level (can be disabled)

From the third game (CAR RUSH)

The game gets kinda buggy some times, might have a memory overflow.
There are 3 worlds with 3 levels each, and you unlock worlds by completing the levels from the previous worlds.
The progress is stored in the local browser storage in this format and it is easily accessible, so it might be useful to store the progress in the server.
The progress is saved each time a level is finished successfully.
The parameters that can be modified are:

Player max speed and max speed indicator
Centrifugal force of the curves
Points per seconds remaining

The finished game conditional might be having 6 times stored in the times array and a totalscore

From the fourth game (PUZZLE DELUXE)

The game has 3 difficulties and 3 images, no level limit
There is no way to tell which difficulty or image was selected
The score is saved after a puzzle is solved.
The only parameters that can be modified are shuffle speed and number of shuffles per difficulty

The finished game conditional could be having played a set amount of times or reaching a certain score


Add an ability to share stories

There is no ability to share stories.
As the user I want to share stories using the default android sharing mechanism.
The shared link (probably a link to API's webpage) should be opened using the Mrakopedia reader application.

Implemented in https://github.com/pokatomnik/mrakopedia-reader/pull/7


[51] Binary Classifier training on the GPT labelled data

Description
This addresses Issue 51.
Included in this PR:

Moved folders for 01-06 from the openalex/binary_classifier to openalex/openalex_binary_classifier
Added pipeline for the gpt labelled training set pipeline to the models folder in pipeline. (The code is the same for this pipeline, with very minor alterations to use this dataset instead)
Adds functionality to download trained model from S3 to test new datasets with using tar.gz files as it wouldn't save them a pickle files for huggingface models.
05_evaluating_openalex_data.py uses the new model to predict relevance labels for a random sample of relevant/not relevant openalex works. Plus saves the dataset with predictions.

To review this PR:

Have a go at running the notebooks, specifically the 05 one! It will run a lot faster in skypilot, so if you did want to do that, change to the branch in the task.yaml!

Checklist:

[x] I have refactored my code out from notebooks/
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[x] Appropriate information has been added to READMEs

[x] I have explained this PR above
[x] I have requested a code review

Hey Jess, this looks good and seems to work! I got confused by some of the details, eg. if in notebook 04b_train_distilbert_classifier_gpt_labelled.ipynb you are fine-tuning a pre-trained model, or if that model was already fine-tuned (on the last PR) and you're training it some more. I think it's the former ie we're not using a model from the last PR, but wanted to check. In general, in the notebooks, would you be able to add a line at the top of some of the more complicated sections saying what is going on? So that tired brains like me don't get confused!
Note: I have not tried running the pipeline scripts, just running the notebook equivalents

Hey @RFOxbury I have added some extra text and made the edits from both the PR's. I have added some info to the top of each notebook but can add extra text in the new year! I am going to merge now in case you need it before I get back!


added configuration for Deye SUN600G3

I modified the configuration for SUN2000G3 to match the SUN600G3.
It will probably also work for the 800G3, but i don't have a device to test.
will resolve #222

Tested with firmware version: MW3_16U_5406_1.53


.pth errors on first install

I am trying to solve #80 which should be simple enough. I modified the script so that it calls mkdir manually on each subdirectory under $VENVBURRITO, instead of using the curly braces notation.
However, installation fails as follows:
TEST FAILED: /home/cestioco/.venvburrito/lib/python2.7/site-packages does NOT support .pth files
error: bad install directory or PYTHONPATH

You are attempting to install a package to a directory that is not
on PYTHONPATH and which Python does not read ".pth" files from.  The
installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /home/cestioco/.venvburrito/lib/python2.7/site-packages

and your PYTHONPATH environment variable currently contains:

    '/home/cestioco/.venvburrito/lib/python2.7'

Here are some of your options for correcting the problem:

* You can choose a different installation directory, i.e., one that is
  on PYTHONPATH or supports .pth files

* You can add the installation directory to the PYTHONPATH environment
  variable.  (It must then also be on PYTHONPATH whenever you run
  Python and want to use the package(s) you are installing.)

* You can set up the installation directory to support ".pth" files by
  using one of the approaches described here:

  https://setuptools.readthedocs.io/en/latest/easy_install.html#custom-installation-locations

Please make the appropriate changes for your system and try again.
  Downloading pip-19.0.2.tar.gz …
* Upgrading pip …
  Installing pip-19.0.2
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    from setuptools import find_packages, setup
ImportError: No module named setuptools
  Downloading virtualenv-16.4.0.tar.gz …
* Upgrading virtualenv …
  Installing virtualenv-16.4.0
/bin/sh: 1: /home/cestioco/.venvburrito/libexec/pip: not found
  Downloading virtualenvwrapper-4.8.4.tar.gz …
* Upgrading virtualenvwrapper …
  Installing virtualenvwrapper-4.8.4
/bin/sh: 1: /home/cestioco/.venvburrito/libexec/pip: not found

Fin.

Your shell profile could not be detected.
Please contact @brainsik on Twitter or GitHub.

Done with setup!

To start now, run this:
source /home/cestioco/.venvburrito/startup.sh

A few things:

Maybe don't print "Done with setup! To start now..." if an error was encountered during set-up.
I'm looking for a workaround to this but it feels like a bug with virtualenv-burrito (or, at least, a weird behavior of Ubuntu 18.04 that virtualenv-burrito should handle, and maybe #80 is one too). I think it's reasonable to assume that my modification isn't causing this; I basically just unrolled the mkdir command.

Any ideas?

To be clear: when I say "weird behavior virtualenv-burrito should be able to handle" I don't mean it strictly in a technical/programmatic sense. It might not always be feasible so it could be something like a note in the documentation.
I solved it by installing setuptools manually first via the get-pip.py option mentioned here. Afterwards, running virtualenv-burrito.sh went without a hitch.
I would want to solve this myself but I'm not sure if this weird behavior is specific to my machine. After all, for a distro like Ubuntu I would expect a bit more noise were this problem widespread. Anyway, I'm leaving the decision to close this issue to the discretion of maintainers.


Missing mention of max_availability parameter on reactor-developer-docs/api/reference/1.0/extension_packages/list.md

As far as I can tell, using filter[availability] does not work.
Cribbing from the Launch UI, I found that I need to use the query param, 'max_availability' with a value of 'private' (or 'public', or 'development' depending on the desired result).
Without the use of the  'max_availability' param, I am seeing development version returned which has a higher version than the extension package with public availability.

@adobe export issue to Jira project PDCL


change in route name style

I have seen the route style and name. like HomePage gave path = '/home-page' and try developing faster than first finding pages and then finding route it challenging to find route name then the solution is named route give in the main file router.dart then easily defines route and use of route only one class defines all routes, easy naming, and some time for changing route names. Going to every page file and changing route names is also a problem.
Now is like this
appRouter() => nyRoutes((router) {
  router.route(HomePage.path, (context) => HomePage(), initialRoute: true);
  // Add your routes here

  // router.route(NewPage.path, (context) => NewPage(), transition: PageTransitionType.fade);

});

Changing this better code and making it easy to use
class App {
  static const String home = '/home-page';
}

appRouter() => nyRoutes((router) {
      router.route(App.home, (context) => HomePage(), initialRoute: true);
});

Also tell me I have a change in this code given to me and guide me on this project to motivate me to contribute code.

Thanks for the PR but this won't be merged.
In your Nylo project, you can easily create pages using dart run nylo_framework:main make:page profile_page
If you need to navigate to that page, just call routeTo(ProfilePage.path)
There wouldn't be any benefit in having another class handle the route paths.
You can read more on the docs here.
Thanks for the PR though.


Minor Update the concat method

Modified the concat code in _DenseBlcok
I think... it seems more natural than using list and append.

Codecov Report

Merging #1260 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1260   +/-   ##
=======================================
  Coverage   65.59%   65.59%
=======================================
  Files          74       74
  Lines        5784     5784
  Branches      884      884
=======================================
  Hits         3794     3794
  Misses       1725     1725
  Partials      265      265

Impacted Files
Coverage Δ

torchvision/models/densenet.py
86.91% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd7080...2c7e983. Read the comment docs.


Page Example

Could you please add a demo image at ReadMe?
Thxs

I am still developing this plugin, I am having some issues to show the drawings tools
but so far I have the map tiles rendering with no issues any more.

Could you please add a demo image at ReadMe?
Thxs

Update your composer now, at least the drawing tools is visible in the map with the latest update


spike: find a workaround for docs README generation

related: https://github.com/rstudio/helm/pull/485#issuecomment-2030154877
related: https://github.com/rstudio/helm/issues/505
The README templating that we do in CI has caused some docs updates to be lost because it's not obvious to contributors that the README is auto-generated from the templates. Better "how to contribute" documentation may be a short term option to help with this, but longer term we should find a workaround that doesn't require a github action that makes a new commit to the repo.
Having to push/pull constantly while iterating on a PR is also a bit tedious.

cc @colearendt do you have thoughts on this? I'd personally like to see the README generation in CI stop entirely and have the readme be generated as part of a local just docs action or something similar. It should be up to the PR author to update the README to make it easier for reviewers to see what's changing.


Page demo doesn't work

Https expired?
czw., 27 lut 2020, 18:42 użytkownik Raul Amador<EMAIL_ADDRESS>napisał:

[image: image]
https://user-images.githubusercontent.com/21697218/75470352-2ae60a80-5956-11ea-8748-f229a6d6be0e.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MicroPyramid/Django-CRM/issues/366?email_source=notifications&email_token=AEXUABQJLZ47HPWUQCGL4Q3RE73RLA5CNFSM4K47Z5OKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQ3ZD6A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXUABURX3NR3VZIXOI57I3RE73RLANCNFSM4K47Z5OA
.

Yes, we are launching SaaS version and anyone can use it for real instead of demo.

Yes, we are launching SaaS version and anyone can use it for real instead of demo.
Here is the solution: https://www.accordbox.com/blog/how-use-scss-sass-your-django-project-python-way/
You missed to add next setting to release:

COMPRESS_PRECOMPILERS = (
('text/x-scss', 'django_libsass.SassCompiler'),
)

Yes, we are launching SaaS version and anyone can use it for real instead of demo.
Cool.  Do you have SaaS version url?

Here is the demo for you guys:
https://crm.citvy.com/
Credentials:
email<EMAIL_ADDRESS>password: q363602qwE
Feel free to explore user functionality. Admin is not available for you :) Sign in works, no signup though for now. We will add registration for you via https://citvy.com so signup is going to be working in several hours. 🤟

Feel free to explore user functionality. Admin is not available for you :) Sign in works, no signup though for now. We will add registration for you via https://citvy.com so signup is going to be working in several hours. 🤟

This other demo seems also to be down...

No demo. No screenshots. No activity on this issue for months. Though, I do see some recent commits. Doesn't this project care about marketing itself at all?


Fix port schema

Signed-off-by: Matthias Pichler<EMAIL_ADDRESS>
Please specify parts of this PR update:

[ ] Specification
[x] Schema
[ ] Examples
[ ] Extensions
[ ] Use Cases
[ ] Community
[ ] CTK
[ ] Other

Discussion or Issue link:

What this PR does:

the schema for port was using min and max for the range instead of the correct minimum and maximum.
flowDirective also had an extra unevaluatedProperties which is invalid for strings
Additional information:

I guess you meant additionalProperties instead of unevaluatedProperties ;)


issue of flutter quill integration in web but after that can not run web or mobile as well.

flutter version:- 3.14.0-9.0.pre.70
flutter_quill version: 7.4.1
../../../.pub-cache/hosted/pub.dev/flutter_quill-7.4.1/lib/src/widgets/raw_editor.dart:353:7: Error: No named parameter with the name 'onLiveTextInput'.
onLiveTextInput: null,
^^^^^^^^^^^^^^^
../../../development/flutter/packages/flutter/lib/src/widgets/editable_text.dart:1832:38: Context: Found this candidate, but the arguments don't match.
static List getEditableButtonItems({
^^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception
FAILURE: Build failed with an exception.

Where:
Script '/Users/jstechno-mac-mini/development/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 1297

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command '/Users/jstechno-mac-mini/development/flutter/bin/flutter'' finished with non-zero exit value 1

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 51s
Need Help. Please any one have solution for this ?

Facing the same problem, any luck with resolving this issue...?

sdk: '>=3.0.5 <4.0.0'  Facing the same problem. modify pubspec.yaml,  environment: sdk: '>=2.18.5 <3.0.0'

I'm having this issue too. environment:  sdk: ">=3.0.0 <4.0.0"

If you keep facing the same bug you could use my forked version, I fixed the onLiveTextInput and downgraded to match my Flutter SDK (3.10.6) & Dart SDK (3.0.6)

Thank you for the report, the issue has been fixed, feel free to ask us any questions at anytime


Genesis Token

Change join process to use genesis tokens for which a user needs proof its identity.
Currently, user-generated keys are used.

Closed #151


feat(localizations): Updated locals for Danger Section and Delete Page (es-ES)

Description

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Will resolve #2921

Thank you @souvik666  :)


fix(copy): add and revise wallet integration copies

Guess we can use <Form.Field.Footer> outside of <Form.List.Item>

I've tried it. But Form.Field.Footer's padding & margin works differently.


Querying same relationship with different params.

Hello,
I have a service with 2 computed properties where I query the same relation with different params but the request is made only once and both properties have the same data.
E.g in the service I have
firstProperty: Ember.computed({
 get() {
    return model.query('role', {name: 'admin'});
 }
}),

secondProperty: Ember.computed({
 get() {
    return model.query('role', {name: 'moderator'});
 }
}),

But in the template when iterating I have in both properties the same data (from firstProperty).
Looks like the second request never runs.
Is this intended? Is there a way to avoid this?

Only one hasMany query can be active/stored at one time per relationship. This is because the results are stored in the hasMany attribute itself, so running another query will override them. Also, multiple queries cannot run concurrently, because the adapter will attach the second query to the first query's promise.
One way to get around this is to only run one query at a time, and store the results in a separate property. For your example, something like this:
init: function () {
  this._super(...arguments);
  var self = this;
  model.query('role', {name: 'admin'}).then(function(adminResponse) {
    var admin = Ember.A();
    admin.push.apply(admin, adminResponse);
    self.set('firstProperty', admin);
    model.query('role', {name: 'moderator'}).then(function(moderatorResponse) {
      var moderator = Ember.A();
      moderator.push.apply(moderator, moderatorResponse);
      self.set('secondProperty', moderator);
    });
  });
},
firstProperty: Ember.A(),
secondProperty: Ember.A()

Note that doing a model.get('role') will return whatever was last queried.

Thanks for the clarifications, will try to use the workaround by running one query at a time.


Message All from Task

Also have message all for task level (is there for event)

@stevejgordon, looks like there is NotifyVolunteerForEventSignup for single volunteer for an event.
Are you looking for a way to message all volunteers that are currently associated with a Task?
Looks like there is a "Message All" button at the Event level.

Yep I think that's the goal. So we'd have a similar button on the task which would then send out to all volunteers assigned to that task.
Sent from my Windows Phone

From: Michael<EMAIL_ADDRESS>Sent: 23/06/2016 20:18
To<EMAIL_ADDRESS>Cc: Steve<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [HTBox/allReady] Message All from Task (#920)
@stevejgordon, looks like there is NotifyVolunteerForEventSignup for single volunteer for an event.
Are you looking for a way to message all volunteers that are currently associated with a Task?
Looks like there is a "Message All" button at the Event level.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/HTBox/allReady/issues/920#issuecomment-228155827

@tonysurma please assign to me

@tomysurma, do you have a "P" label for his one so I can prioritize?

Sorry did this one from mobile, P3

@stevejgordon, it looks like this already exists in the system. I added a couple volunteers for one of the seeded Tasks:

You can see as soon as there are some volunteers that need to be "approved" by admin, we can see the "Message All" button. When clicking the button:

then MessageTaskVolunteersHandlerAsync handler is invoked.
So I think this task can be closed

@stevejgordon can you verify this Issue can be closed based on my research above? Thanks

@mgmccarthy Sorry Mike, missed this question. Yep, looks like this can be closed. I've just checked and see it passing through a notify handler.
@tonysurma I'll close this down. This is a question in the code comments around what task info should be included in the message, however it might be better to open a fresh issue defining any changes needed after some beta testing?


chore! bump sn_api and blockifier versions (0.13.2)

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

crates/papyrus_rpc/src/v0_4/execution_test.rs line 144 at r1 (raw file):

    pub static ref TEST_ERC20_CONTRACT_ADDRESS: ContractAddress = contract_address!("0x1001");
    pub static ref ACCOUNT_INITIAL_BALANCE: StarkFelt = stark_felt!(2 * MAX_FEE.0);
    // TODO(yair): verify this is the correct fee, got this value by printing the result of the

Are these changes expected?

crates/papyrus_rpc/src/v0_4/execution_test.rs line 144 at r1 (raw file):
Previously, dan-starkware wrote…
Are these changes expected?

Yes


Improve informer-level filtering to reduce resource consumption

Description
This PR is a follow-up of #1102 and introduces additional informer-level filters to reduce the number of events processed by the home cluster (and cached objects) when offloading remote pods. Specifically:

route operator: filter-out pods with no IP assigned yet (this prevents the transient while waiting for the VK to label remote pods).
resource monitor: filter-out non running pods, to simplify the overall logic and prevent the transient while waiting for the VK to label remote pods.
shadowpod operator: filter out pods not created through a shadowpod.

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Unit testing
[x] E2E testing

/test

/test

/rebase test=true

/merge


Add website URL to the repo description

Like the blog site's repo, there should be a link to the live website next to the repo's description so that people can visit the code in action!

It has been done! Good eye!


345 add quiet switch

Checklist

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
[x] Added tests for code changes or test/build only changes
[x] Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
[x] Completed the PR template below:

Description
Add a quiet switch to reduce the output from couchbackup and couchrestore CLI commands.
Fixes #345
Approach
Split the debug instance between the summary messages (the original couchbackup:backup and couchbackup:restore namespaces) and the batch messages (new couchbackup:backup:batch and couchbackup:restore:batch namespaces.
Leave the summary message namespaces always enabled:true (as before).
Make the new namepsaces enabled:true by default to preserve existing behaviour, but make it settable via the quiet parameter.
Schema & API Changes

New -q, --quiet CLI parameter or COUCH_QUIET env var - note this is CLI only, the API does not log these messages (it sends the events instead so it is up to the user to handle/log events as desired).

Security and Privacy

"No change"

Testing

Added new tests for the quiet option:

respects the COUCH_QUIET env variable if the --quiet backup command-line parameter is missing
respects the backup --quiet command-line parameter
respects the COUCH_QUIET env variable if the --quiet restorer command-line parameter is missing
respects the restore --quiet command-line parameter

Added new tests for the resume option which were missing from the set

respects the COUCH_RESUME env variable if the --resume backup command-line parameter is missing
respects the backup --resume command-line parameter

Monitoring and Logging

Default output remains the same, but -q, --quiet or COUCH_QUIET can be used to suppress batch messages for CLI.

have you verified that the new debug options are working locally?

yes 😄
without quiet mode:
./bin/couchbackup.bin.js --url 'https://examples.cloudant.com' --db animaldb > /dev/null
================================================================================
Performing backup on https://examples.cloudant.com/animaldb using configuration:
{
  "bufferSize": 500,
  "log": "/var/folders/w2/j4ccs8ms26j94l9kljk3hmmh0000gn/T/tmp-12566-fdjO3EIAF4hI",
  "mode": "full",
  "parallelism": 5,
  "requestTimeout": 120000,
  "resume": false
}
================================================================================
  couchbackup:backup Fetching all database changes... +0ms
  couchbackup:backup:batch Total batches received: 1 +0ms
  couchbackup:backup:batch Written batch ID: 0 Total document revisions written: 15 Time: 1.289 +519ms
  couchbackup:backup Finished - Total document revisions written: 15 +2s

and with quiet mode:
 ./bin/couchbackup.bin.js --url 'https://examples.cloudant.com' --db animaldb -q > /dev/null
================================================================================
Performing backup on https://examples.cloudant.com/animaldb using configuration:
{
  "bufferSize": 500,
  "log": "/var/folders/w2/j4ccs8ms26j94l9kljk3hmmh0000gn/T/tmp-12572-Ix3pLc0Nrtxw",
  "mode": "full",
  "parallelism": 5,
  "requestTimeout": 120000,
  "resume": false
}
================================================================================
  couchbackup:backup Fetching all database changes... +0ms
  couchbackup:backup Finished - Total document revisions written: 15 +2s

FTR I did check restore as well:
cat backup | ./bin/couchrestore.bin.js --url 'https://***.cloudant.com' --db restoretest
================================================================================
Performing restore on https://***.cloudant.com/restoretest using configuration:
{
  "bufferSize": 500,
  "parallelism": 5,
  "requestTimeout": 120000
}
================================================================================
  couchbackup:restore:batch restored 15 +0ms
  couchbackup:restore finished { total: 15 } +0ms

and with quiet:
cat backup | ./bin/couchrestore.bin.js --url 'https://***.cloudant.com' --db restoretest2 -q
================================================================================
Performing restore on https://***.cloudant.com/restoretest2 using configuration:
{
  "bufferSize": 500,
  "parallelism": 5,
  "requestTimeout": 120000
}
================================================================================
  couchbackup:restore finished { total: 15 } +0ms`


[sql]Item submit stage detection problem

What is your Quests version / build number (do not say "latest")?
# 278
Describe the problem and how to replicate it. Any console errors to post using a pastebin?
for any quest will item submit stage, if a player too a quest, the relogin the server, his stage progress counting is freezed
similar to issue #1753
but this issue much bigger because #1753 only have problem if the item submitted reach 64, but this time, just after relogin, the quests does not detect item submitting to npc on click.
similar to #1792 but that time only have issue to mob killing

use sql
make a quest to submit item with more than 64, make sure name and lore of the item is changed so that the item is non vanilla
take the quest
leave server with out submit anything
join server
you cannot submit the item.

If applicable, can you provide an example quest from quests.yml using a pastebin?
https://paste.gg/p/anonymous/df38c95bc17c4460a894b4e1c5b00c10

I wasn't able to replicate this. Could you please provide an example quest from quests.yml using a pastebin?

I wasn't able to replicate this. Could you please provide an example quest from quests.yml using a pastebin?

here:
https://paste.gg/p/anonymous/df38c95bc17c4460a894b4e1c5b00c10
i also record a video to reproduce the bug
https://youtu.be/DWAolpZhd18
item in video for testing.

test with SQL storage method

@hkkongou https://ci.codemc.io/job/PikaMug/job/Quests/280/

checked, it work, thank you so much