Dart analyzer crashes reliably working with macros.

Commit: https://github.com/polina-c/disposable_macro/commit/becf1a162f46e6f1dca84b9d390b69a536a82aaf
Flutter 3.22.0-18.0.pre.54 • channel [user-branch] • unknown source
Framework • revision 257df5ebfc (9 hours ago) • 2024-04-29 11:26:19 +0300
Engine • revision 752b146df7
Tools • Dart 3.5.0 (build 3.5.0-109.0.dev) • DevTools 2.35.0-dev.16

Add these settings to your user settings of vs_code:
    "dart.analyzerLogFile": "logs/dart.analyzer.log",
    "dart.analyzerInstrumentationLogFile": "logs/dart.analyzerInstrumentation.log",

Steps to repro:

Clone the repo
Run flutter pub get in both folders: disposable_macro and usage_example
Open the repo folder in vs_code
Find analyzer crashing and logs.
Remove logs and select command Developer: Reload Window to see the crash repeated

Archive.zip

@scheglov

Note that for me I wasn't able to reproduce the analyzer crash - I got a different error related to us not currently allowing you to augment constructor bodies if there was one previously (related to https://github.com/dart-lang/language/issues/3554).
I am going to prioritize resolving that issue so that we can allow augmenting constructor bodies without error.

I'd like to know a few more details. Do you have to have both the macro implementation package, and the package where it is used - as directories in IDE? But not open the macro implementation file? Or macro implementation in an external directory, not included in IDE, and open only the package where the macro is used?

In my case, the macro package and package using it were in sibling directories, and I had the shared root directory open.
You can reproduce this by cloning the example repo @polina-c shared above, opening up the entire repo in VsCode (or probably intellij), and then opening up disposable_macro/test/disposable_test.dart.
If you then open up disposable_macro/lib/src/disposable_macro.dart, and restart the analysis server, it will work.

I can reproduce this without using any IDE.
Which is always much better :-)
scheglov@scheglov-macbookpro4:~/dart/2024-04-30/disposable_macro/usage_example (main)$
scheglov@scheglov-macbookpro4:~/dart/2024-04-30/disposable_macro (main)$ dart analyze .
Analyzing ....
Unhandled exception:
Invalid argument(s): Attempted to register a macro executor factory for library package:disposable_macro/src/disposable_macro.dart which already has one assigned.
#0      MultiMacroExecutor.registerExecutorFactory (package:_macros/src/executor/multi_executor.dart:44:9)
#1      new KernelBundleMacroExecutor (package:analyzer/src/summary2/macro.dart:101:46)
#2      KernelMacroSupport.add (package:analyzer/src/summary2/macro.dart:147:26)
#3      LinkedElementFactory.addKernelMacroBundle (package:analyzer/src/summary2/linked_element_factory.dart:89:18)
#4      LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:254:24)
<asynchronous suspension>
#5      LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:154:9)
<asynchronous suspension>
#6      LibraryContext.load.<anonymous closure> (package:analyzer/src/dart/analysis/library_context.dart:264:7)
<asynchronous suspension>
#7      PerformanceLog.runAsync (package:analyzer/src/dart/analysis/performance_logger.dart:50:14)
<asynchronous suspension>
#8      LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:262:5)
<asynchronous suspension>
#9      AnalysisDriver._produceErrors (package:analyzer/src/dart/analysis/driver.dart:1953:5)
<asynchronous suspension>
#10     AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1236:7)
<asynchronous suspension>
#11     AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2433:7)
<asynchronous suspension>
Bad state: The analysis server crashed unexpectedly

The analysis server shut down unexpectedly.
Please report this at dartbug.com.

The issue is that we have single MultiMacroExecutor instance, and every time when we load a summary bundle with macros, we try to register corresponding macros with kernel bytes. Which raises the question - should we have separate MultiMacroExecutor instances? @jakemac53

It does seem to me like each analysis context should have its own MultiMacroExecutor instance? They can have different sources right?

Yes, this seems right to me.
I was checking if you know a reason why this would be wrong, e.g. fixed ports, or any other unique resources.
If no obvious reasons for this to fail, I will continue pushing the implementation :-)

If no obvious reasons for this to fail, I will continue pushing the implementation :-)

SGTM, the downside is that we will run macros multiple times on the same code potentially, but this is no different really than re-analyzing the same sources, which I think we are also doing in this case?

Not so much re-analyzing, because we can reuse summaries and kernels between analysis context via ByteStore, but we have separate copies of LibraryElements for the same URIs. For the reasons that you described - potentially different set of dependencies.
We don't load elements form summaries if we don't have to. Similarly we registerExecutorFactory(), but I think we don't start macro implementation if we don't have to, e.g. if we already have corresponding libraries built.

"All problems in computer science can be solved by another level of indirection"
Instead of a single MacroSupport argument for AnalysisContextCollection we will have MacroSupportFactory that creates MacroSupport instances :-)

/Users/scheglov/dart/2024-04-30/disposable_macro
/Users/scheglov/dart/2024-04-30/disposable_macro/usage_example
[libraries: {package:disposable_macro/src/disposable_macro.dart}]
/Users/scheglov/dart/2024-04-30/disposable_macro/disposable_macro
[libraries: {package:disposable_macro/src/disposable_macro.dart}]
[time: 8819 ms]

scheglov@scheglov-macbookpro4:~/dart/2024-04-30/disposable_macro (main)$ /Users/scheglov/Source/Dart/sdk.git/sdk/xcodebuild/ReleaseARM64/dart-sdk/bin/dart analyze .
Analyzing ....                         2.1s

  error • disposable_macro/test/disposable_test.dart:5:1 • Macro application failed due to a bug in the macro. Try reporting the failure to the macro author. • macro_error
           - Unsupported operation: Augmenting existing constructor bodies is not allowed.
#0      ConstructorDefinitionBuilderImpl.augment (package:_macros/src/executor/builder_impls.dart:421:7)
#1      Disposable.buildDefinitionForClass (package:disposable_macro/src/disposable_macro.dart:21:15)
<asynchronous suspension>
#2      executeDefinitionMacro (package:_macros/src/executor/execute_macro.dart:181:9)
<asynchronous suspension>
#3      MacroExpansionClient._executeDefinitionsPhase (package:_macros/src/executor/client.dart:276:11)
<asynchronous suspension>
#4      MacroExpansionClient._handleMessage.<anonymous closure> (package:_macros/src/executor/client.dart:140:12)
<asynchronous suspension>
#5      MacroExpansionClient._handleMessage (package:_macros/src/executor/client.dart:118:5)
<asynchronous suspension>
 at disposable_macro/test/disposable_test.dart:5:1.
warning • disposable_macro/lib/src/disposable_macro.dart:17:11 • The value of the local variable 'library' isn't used. Try removing the variable or using it. • unused_local_variable
warning • disposable_macro/lib/src/disposable_macro.dart:18:11 • The value of the local variable 'className' isn't used. Try removing the variable or using it. • unused_local_variable
warning • usage_example/test/disposable_test.dart:2:8 • Unused import: 'package:flutter/foundation.dart'. Try removing the import directive. • unused_import
warning • usage_example/test/disposable_test.dart:4:8 • Unused import: 'package:disposable_macro/disposable_macro.dart'. Try removing the import directive. • unused_import

5 issues found.


mark-private-repos broken

Description

How to replicate the issue + URL
https://github.com/search?q=is%3Aprivate&type=repositories
https://github.com/YOUR_USERNAME?tab=repositories&type=private
Extension version
24.7.10
Browser(s) used
Safari

https://github.com/search?q=is%3Aprivate&type=repositories

This needs to be turned into a JS feature because the DOM no longer has any classes for the label

https://github.com/YOUR_USERNAME?tab=repositories&type=private

This still works


Arangodb,How to return an isolated point?

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[✔ ] 3.2
[ ] self-compiled devel branch

Mode:

[✔ ] Cluster
[ ] Single-Server

Storage-Engine:

[ ] mmfiles
[✔ ] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[✔ ] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[✔ ] I'm using graph features
I'm issuing AQL via:

[✔ ] web interface with this browser:     running on this OS:
[ ] arangosh
[ ] this Driver:

The AQL query in question is:
I now have a need, we need to get a single point of data in the data independent, this point no edges, AQL how to write?
this is a web interface-related issue:
I'm using the web interface with this browser:     running on this OS:

[ ] authentication is enabled?
[ ] using the cluster?
[✔ ] _system database?

Hello,
this is a duplicate of https://stackoverflow.com/questions/47769067/how-to-get-isolated-vertices-on-a-graph. Does this answer your question?

Closing this issue as solved. The question is answered on stackoverflow.

ok


Ability to visualize colors

If I run visualize someColor, I get:
UIDeviceRGBColor isn't supported. You can visualize UIImage, CGImageRef, UIView, CALayer or NSData.

Chisel should generate a square or circular image of the color, optionally with some RGB/hex info included in the image, and open the image in Preview.

Reference: when you Quick Look a color in the variables list:

Nice. Can I interest you in trying a pull request :smile:

Definitely interested. I’ll put it on my list for my job’s semi-weekly hack days.

Let me know if you have any questions, happy to answer anything.

@kastiglione would it be a faux pas to expr @import CoreFoundation in my command? I'm trying to have it be able to differentiate between UIColor, CIColor, and CGColor (and maybe NSColor?)

Specifically:
result = frame.EvaluateExpression('(CFTypeID)CFGetTypeID({color}) == (CFTypeID)CGColorGetTypeID()'.format(color=color))

would it be a faux pas to expr @import CoreFoundation in my command?

Nah. In fact I think it would be great to do, UIKit too. Thinking aloud, I wonder if it could be done on the first time any breakpoint is hit. Then by using Chisel, you get these for free.

Not to give you scope creep, feel free to put it in your command only. Someone can look to make it more general later.

I've seen it advised to always import UIKit on an exception breakpoint. I had put a UIKit import in my ~/.lldbinit, but it seemed to slow down Xcode every time I started a debugging session. I'll try again some time.
Current question: here's an error I'm getting in lldb:
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'CGColorRef' (aka 'CGColor *')

From a python line like this:
colorToUse = '[UIColor colorWithCGColor:(CGColorRef){}]'.format(color)

Seen anything like this?

Or, to simplify the question, what is the right way to call this in lldb?
po [UIColor colorWithCGColor:(CGColorRef)[[UIColor redColor] CGColor]]

Cast the color to void *?

Nope:
(lldb) po [UIColor colorWithCGColor:(void *)[[UIColor redColor] CGColor]]
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'void *'
error: 1 errors parsing expression

(assuming that's what you meant?)

I should have been clear:
po [UIColor colorWithCGColor:(void *)[[UIColor redColor] CGColor]]

Yes that's what I meant. Hmm. Maybe one of:
po [UIColor colorWithCGColor:(id)[[UIColor redColor] CGColor]]
po [UIColor colorWithCGColor:(CGColor *)[[UIColor redColor] CGColor]]
po [UIColor colorWithCGColor:(CGColor *)(void *)[[UIColor redColor] CGColor]]

Oh, I'm curious why you're going from UIColor to CGColor to UIColor.

Just a simple test case to reproduce what I’m seeing in the script with a CGColor. I didn’t have a CGColor handy in an app, so I was making one from a UIColor in the debugger. If I can make a CGColor in code and reference it in the script and it works, I guess I will ignore this issue for now as an edge case. I’ll try that, and your suggestions.

None of the suggestions worked, but worse, the actual case I'm trying to use also doesn't work. If I'm on a breakpoint and I have a local variable, cgColor, of type CGColorRef:
(lldb) po cgColor
<CGColor 0x7fdfa0546910> [<CGColorSpace 0x7fdfa0643f70> (kCGColorSpaceDeviceRGB)] ( 0 0.478431 1 1 )

(lldb) po [UIColor colorWithCGColor:cgColor]
error: cannot initialize a parameter of type 'CGColor *' with an lvalue of type 'CGColorRef' (aka 'CGColor *')
error: 1 errors parsing expression
(lldb) po [UIColor colorWithCGColor:(id)cgColor]
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'id'
error: 1 errors parsing expression
(lldb) po [UIColor colorWithCGColor:(CGColorRef)cgColor]
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'CGColorRef' (aka 'CGColor *')
error: 1 errors parsing expression
(lldb) po [UIColor colorWithCGColor:(CGColor *)cgColor]
error: use of undeclared identifier 'CGColor'
error: expected expression
error: 2 errors parsing expression
(lldb) po [UIColor colorWithCGColor:(struct CGColor *)cgColor]
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'struct CGColor *'
error: 1 errors parsing expression
(lldb) expr @import CoreGraphics
(lldb) po [UIColor colorWithCGColor:(struct CGColor *)cgColor]
error: cannot initialize a parameter of type 'CGColor *' with an rvalue of type 'struct CGColor *'
error: 1 errors parsing expression

So I can't use it in my script because it doesn't even work in the real debugger, at least not with the incantations I'm using.

It looks like this is maybe already done in chisel? Does this code work? https://github.com/facebook/chisel/blob/master/commands/FBAutoLayoutCommands.py#L44
lldb.debugger.HandleCommand('expr (void)[%s setBorderColor:(CGColorRef)[(id)[UIColor %sColor] CGColor]]' % (layer, color))

@kastiglione alright, I got a workaround thanks to @jvisenti: http://stackoverflow.com/a/31810890/255489
I believe it's related to the UIColor going out of scope, and -CGColor returning an internal pointer:
@property(nonatomic,readonly) CGColorRef CGColor;
- (CGColorRef)CGColor NS_RETURNS_INNER_POINTER CF_RETURNS_NOT_RETAINED;

PR should be in shortly :)


Make the app responsive

Problem
Primer Prism doesn't work on small viewports. Let's make the app usable for small viewports (or at least show a message prompting people to use a larger viewport)

100% agree. As simple as collapsing that palette menu to the left would make a world of difference.

@curtisbarnard I would like to work on adding responsiveness to the app if no one has already taken it up.
Thanks!


The view event page should have an edit button

That way you can edit quickly if you see something you want to change and don't have to go back to the calendar to click edit

It does now! And redirects with the Router too... :sunglasses:


Gabriel Knight Discord Request

ScummVM.
Using Proton to run the Windows version of DOSBox to run the game (the default experience) is just nasty.
The Steam packages have had zero care put into them; GK1 is the GOG bundle slapped on Steam and GK2 is a fan project with MS Paint title screen.
d10sfan | EndeavourOS — Today at 12:04 PM
Which steam listing is it? And could you describe what you did to make the game work?
CatKiller | Kubuntu — Today at 12:12 PM
It was this one.
https://store.steampowered.com/app/495700/Gabriel_Knight_Sins_of_the_Father/
There's a file called GK1.GOG that I renamed to GK1.iso so that Ark would handle it automagically, which I then extracted to the same location, overwriting anything that already existed. I suspect that getting it from GOG and running it from Windows would probably have done something similar with bat files or something, but didn't investigate.
I've got Luxtorpeda set as the forced compatibility tool (installed via ProtonUp-Qt), which launches ScummVM.
Controls work nicely, since it's just mouse for that game.
Steam
Gabriel Knight: Sins of the Father®
He started out writing a book on voodoo. Now he’s fighting for his very soul.Gabriel Knight is the last in a long line of Shadow Hunters, those fated to fight the dark forces of the supernatural. Haunted by a centuries-old curse, he is tormented by terrifying nightmares.Now he must spend every waking moment scouring the side streets and back all...
Price
$3.59
Recommendations
105
I did also do some shenanigans in the end with GK2. ScummVM pesters you about additional subtitles. It pops up a download button to grab GK2Subtitles.zip from Sierra's website, but you need to unzip that, which gives you GK2Subtitles.exe, and then I used PeaZip (since Ark on the Deck doesn't seem to be able to handle self-extracting files like I'm pretty sure Ark on my desktop can) to grab the SUBPATCH directory that I then splatted into the GK2/PATCHES directory.
Now the FMVs have subtitles.

Closing in favor of https://github.com/luxtorpeda-dev/packages/pull/1171


Azure.Batch 2.0.2

Type: Missing
Summary:
Azure.Batch 2.0.2
Details:
NuGet license field is MIT
GitHub license for this version is Apache-2.0: https://github.com/Azure/azure-sdk-for-net/blob/v<IP_ADDRESS>-Oct2013/LICENSE.txt
Resolution:
Apache-2.0
Affected definitions:

Azure.Batch 2.0.2

@LandOfBliss When I click on the NuGet license link it goes to a Microsoft EULA - https://view.officeapps.live.com/op/view.aspx?src=https%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F8%2F0%2FF%2F80FF838D-B585-4F5F-893C-6DAD6E634C27%2Flicense.docx&wdOrigin=BROWSELINK. I would Declare as OTHER. @capfei do you agree?

@AE49 I agree with OTHER since the license link goes to a EULA.


SQLCODE: 22008 SQLERROR: ERROR:  date/time field value out of range: "0000-00-00 00:00:00"

Is there a way to "transform" those?
Jul 24 13:55:39: [ERROR] - pg_lib.py (510): b'INSERT INTO "cpc"."meta_config" ("id","key","value","created_at","updated_at") VALUES (\'1\',\'payment_overdue_limit\',\'30\',\'0000-00-00 00:00:00\',\'0000-00-00 00:00:00\');'

I understand that it should look like this:
insert into subscriptions_sub(datetime_created) values (NULLIF(your_field_name,'0000-00-00 00:00:00')::timestamp)

to be totally safe...

The row image doesn't carry informations about the data type. Maybe querying the postgres system catalogue when the procedure starts the replay can fix this sort of issues. I'm adding this enhanchement tentatively to the version 1.7 (currently working on the 1.6) as this require time to be correctly addressed.

I've wrongly addressed the issue 22 in the last commit. However the fix for this issue will appear in the upcoming version 1.7


[in_app_purchase] Update to the latest pkg:json_serializable

Remove unneeded class now that enum helpers can be generated without one
Code reorganization
Remove superflous JsonKey values

Help here, @cyanglaz ?

@LHLL – do we need your approval, too?


Cody Gray: Watch kredibankalar.com

Cody Gray requests the watch of the watch_keyword kredibankalar\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

kredibankalar\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


cannot find any tags of netbirdio/relay in dockerhub

Describe the problem
as title, https://hub.docker.com/r/netbirdio/relay is an empty repository
To Reproduce
Steps to reproduce the behavior:

Go to https://hub.docker.com/r/netbirdio/relay
See error

Expected behavior
You can see the “latest” in tags
Are you using NetBird Cloud?
No, just self-hosted.
NetBird version
0.28.9
NetBird status -dA output:
not applicable
Do you face any (non-mobile) client issues?
not applicable
Screenshots

Additional context
not applicable

Hi @TheresaQWQ,
well, the reason for that is simple, there are no images published yet. We are currently developing a new relay service. This should be released within the next days and you should see some images there.

@TheresaQWQ It seems that when you posted, the image hadn't been published yet. Now, you can check that the tags are available, and you should be able to pull the image.


Update polybar-integration (v1.2)

Adds more animations and idle-only mode

Does this include everything from #112?


Running on Linux in docker container

I don't have a Windows server running but a Linux one running docker.
It would be amazing if there was a docker image provided on any registry.
Currently I'm running the tool on my windows desktop but it would be more ideal to have it running on my server because I wouldn't have to worry about the tokens expiring while the tool isn't running because the Linux server is running 24/7 and could renew the tokens whenever it's required.
I've seen you are already working towards something like this but I wanted to explain my wish for a read to run container image for use on a Linux server.

Have you looked at this?
https://github.com/isaacrlevin/PresenceLight/blob/main/src/PresenceLight.Worker/Dockerfile

I haven't done it yet, but I will take a look at it on the weekend. Deployment via a well known container image source would simplify the deployment even further, wouldn't it?

The container is hosted on Microsoft Container Registry.
https://azure.microsoft.com/en-us/services/container-registry/

@Xyolyp any questions here?

@isaacrlevin I have no further questions regarding docker right now. Thank you for bringing this up and guiding me in the right direction.


Create a changelog in which we can see breaking changes

Hi,
this is not a code issue with the library but rather an issue with users updating. 2 months ago, in v4, you pushed updates which modified the response object, changing res.status to res.statusCode. This obviously breaks any application looking directly for the status code and when updating dependencies there is no changelog which lists all the breaking changes snekfetch v4 had (or at least I can't find one) which means that developers have no way of knowing that they have to change their request processing.
The only way to know is by looking through the individual commit diffs (the commit descriptions aren't helping either) which takes time and is error-prone.
Please consider adding a changelog.md or a similar way to document changes which may impact applications using this package such as the one described above.

@wasdennnoch i'll consider putting one together. also just for the record, v4 came out a few days ago, not 2 months ago


Consider what is core for armstrong. Move dialog and burger out of Armstrong?

In the interest of a) minimising breaking changes to Armstrong and b) staying off the path of "trying to be everything to everyone" maybe we should consider making Dialog and Burger menu an optional add-on and removing them from Armstrong core?

Dialog is very useful. I'm not sure why we'd move it outside....
As for burger menu, I'm less bothered. As long as we have a good story for adding it back in later and a good reason for removing it

burger menu is now seperate in a navigation.scss file. Dialog remains


Fixed a bug where configurations did not actually support extends

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

There have been multiple issues reported where configurations do not actually support the extends property:
https://github.com/mochajs/mocha/issues/3916
https://github.com/mochajs/mocha/pull/4057
I did some digging and found the root cause to be the options.parse() method. This method relies on yargs-parser and NOT yargs which does the actual configuration extending.
It was a pretty straightforward fix. I imported the yargs function that extends the configuration objects and then applied it to all the arguments passed to parse().
I added a test to support this case and verified the test fails when this fix is not applied.
Alternate Designs

There was already an existing PR open that modified external methods to do this, so I wanted to avoid that.
Why should this be in core?

It fixes a long standing bug.
Benefits

Configuration files can now be extended properly.
Possible Drawbacks

I dont see any?
Applicable issues

Yeah, I think that test should probably live in test/node-unit/cli/options.spec.js instead.

I'm a little concerned that yargs/lib/apply-extends isn't a public API. If it isn't, maybe we can vendor it (e.g., just copy/paste it into a function in lib/cli/options.js). @bcoe can you comment?

I would be happy to make this a public API, but as this PR stands today, it will be broken by the next major version of yargs,  which moves to using an export map.
I'd be happy  to export this helper though.

@bcoe If you want to add it to the export map, that'd work for us--we can change our code to use it when we upgrade.

@mf-pherlihy Are you interested in doing further work on this? I'd like to merge the PR, but the test should probably move.  If I don't hear back in a couple days, I'll merge this as-is and fix it after.

@boneskull Yeah I can finish this up. Just to confirm:

Move to test/node-unit/cli/options.spec.js
2a. Copy applyExtends from yargs to here with a TODO to swap out once yargs is updated?
2b. Use applyExtends as-is with a TODO to swap out once yargs is updated?

Move the test
AFAICT you are free to use applyExtends as it has been made part of yargs' public API.  But it sounds like when we upgrade yargs we will need to change it?  Unclear, since we're pulling it out of yargs-parser and not yargs itself, right?  @bcoe?

ping @bcoe @mf-pherlihy

AFAICT you are free to use applyExtends

Yes, my intention was that it's a blessed public helper now. The caveat is that we need to fix this.

Just tried upgrading yargs and using the defined helpers. Unfortunately however, the latest version breaks a bunch of other tests.

Just tried upgrading yargs and using the defined helpers. Unfortunately however, the latest version breaks a bunch of other tests.

Coverage increased (+0.01%) to 94.157% when pulling 105d1aa8f4179278625409e7bdec98e4485d0232 on mf-pherlihy:extends-fix into 30d5b667a0b877a62ad33a49edc72807dccd768d on mochajs:master.

Coverage increased (+0.01%) to 94.157% when pulling 105d1aa8f4179278625409e7bdec98e4485d0232 on mf-pherlihy:extends-fix into 30d5b667a0b877a62ad33a49edc72807dccd768d on mochajs:master.

@mf-pherlihy<EMAIL_ADDRESS>introduces ESM, and was a somewhat major shuffling around of code. I'd be interested in making sure we address any issues you're bumping into with tests.

@mf-pherlihy<EMAIL_ADDRESS>introduces ESM, and was a somewhat major shuffling around of code. I'd be interested in making sure we address any issues you're bumping into with tests.

@bcoe I did upgrade yargs and yargs-parser with #4543. There have been changes in yargs' array handling with yargs.config() and combinig array values. I had to remove aliased options from our pre-parsed result (by yargs-parser) in order to prevent double entries.
I do not consider the new behavior as a bug, it seems more consistent now than before.

@bcoe I did upgrade yargs and yargs-parser with #4543. There have been changes in yargs' array handling with yargs.config() and combinig array values. I had to remove aliased options from our pre-parsed result (by yargs-parser) in order to prevent double entries.
I do not consider the new behavior as a bug, it seems more consistent now than before.

I do not consider the new behavior as a bug, it seems more consistent now than before.

@juergba that's good to hear 👍
Sound like we perhaps just need to rebase this and give the helpers another try?

I do not consider the new behavior as a bug, it seems more consistent now than before.

@juergba that's good to hear 👍
Sound like we perhaps just need to rebase this and give the helpers another try?

Sound like we perhaps just need to rebase this and give the helpers another try?

I guess so, but I haven't taken a look at this PR though. But please go ahead @mf-pherlihy.
The browser tests will fail anyway, but that's off topic. Github actions does not have access to GH secrets (login data for SauceLabs) on PR's from forked repos. We haven't solved that, yet.

Sound like we perhaps just need to rebase this and give the helpers another try?

I guess so, but I haven't taken a look at this PR though. But please go ahead @mf-pherlihy.
The browser tests will fail anyway, but that's off topic. Github actions does not have access to GH secrets (login data for SauceLabs) on PR's from forked repos. We haven't solved that, yet.

@mf-pherlihy I rebased and tests are passing using the public helpers.

Priority list:
 * 1. Command-line args
 * 2. RC file (`.mocharc.c?js`, `.mocharc.ya?ml`, `mocharc.json`)
 * 3. `mocha` prop of `package.json`
 * 4. default configuration (`lib/mocharc.json`)

I have to check to which configObects you are applying extend. To RC files only or to package.json mocha field as well.
And when the extend values are applied, wether the priority is respected.
I'm unsure wether this is correct.

@mf-pherlihy I did some testing and have found quite a few issues:

extends does not work for relative paths
array typed options: values are not combined, the configuration of yargs-parser seems to be ignored by applyExtends.
boolean typed option: is buggy, eg no-diff: true gets overwritten by default value: diff: true
package.json  with field mocha: haven't tested yet, but ?

As an alternative without yargs public helper:
we just let options.parse() do the job by passing additional configObjects. The order would be crucial.
configObjects: [{base RC-options}, {extends RC-options}, {base pkg options}, {extends pkg options}]
What do you think?

If we can cover all the issues with yargs-parser and still fix the root issue with extends then im all for it.

@mf-pherlihy if any of this behavior would make sense in yargs/yargs-parser, happy to take patches.

:wave: Where are we at regarding this PR?
Extending configuration is essential to properly manage mono-repositories.
If you need any help to finish it just say the word and I'll happily look into whatever issue remains. :+1:

Note: #4980 also touches this area. We should review them together in case one is a dup.

Marking as semver-major because some projects might accidentally be relying on the current, arguably broken behavior.

👋 ping @mf-pherlihy, do you still have time for this?

Closing out as it's been a while since PR activity. If anybody wants to take this over, please do - and post a co-author attribution if you take code from this PR. Cheers! 🤎


Prevent duplicate account ids in run_multiple

I'm sure not a priority at all, but I accidentally was generating device auths for one account for what I thought was multiple accounts. Fornitepy didn't complain at all and just ran them, which caused... interesting issues, which were not super helpful in the debugging the issue (mostly "unknown party id" bugs).
I absolutely would not expect Fortnitepy to have known any better, but a simple check on fortnitepy.run_multiple() to ensure that no accounts have the same account_id could be potentially helpful in preventing this issue for any future devs.

Seems like a good idea. I'll make sure its added in the next update :)


Shape Issues with Rotation + Scale + Position

I have an AE file that has an animation of a Fish swimming through water doing some turns. I'm using Rotation + Scale + Position, and also making another layer the parent of it (that also has position key frames).
The result is a distorted shape (when using the JSON output) versus what I see very clearly in the AE file.
Tell us about your environment
Mac Sierra 10.12.5

After Effects Version:
AE cc2017.1

Please provide a download link to the After Effects file that demonstrates the problem.
I've included both the JSON output as well as the AE file.
Fish Animation.zip

Hi, I see your animation working fine.
Can you share a link where it fails?

Hi Bodymovin,
Thanks for taking a look!
How are you testing/rendering the JSON?
Apologies, I'm still new to bodymovin but I discovered it through Lottie, and I'm using Lottie to render the JSON. I'm attaching a video of 1. The Result of what it looks like when rendered, 2. Expected, and 3. The exact JSON I'm using again.
Fish BM.zip

if you're using Lottie, can you post it in their github?
https://github.com/airbnb/lottie-android
Also make sure you're using the latest version.

Thanks! Their latest version seems to mess up quite a bit - have posted it there.


Add Unittest for util_func

Unittest for following functions
rotate_180
readString
writeString
Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #1023. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

:octocat: cibot: @lhs8928, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.


[ADD] missing owner_account var for restoring from cross-account shar…

…ed shapshot
Description
The "owner_account" var is needed to be specified when the snapshot is shared from different AWS account.
https://github.com/hashicorp/terraform/pull/12062
https://www.terraform.io/docs/providers/aws/r/redshift_cluster.html

Thanks @dbektas  !
v2.4.0 has been just released.


[dv] Keymgr-kmac agent

Add keymgr-kmac agent and use it in keymgr env

Last push is to fix a dead loop in push_pull_agent and make CI pass

@sriyerg can you take a look at this PR?


Add a guide for using OSC9;9

This covers CMD, powershell, and bash IN WSL.
Others are free to add as needed.

[x] Closes #285

See also:

https://github.com/microsoft/terminal/issues/8166
https://github.com/microsoft/terminal/issues/3158

Docs Build status updates of commit 897edb2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/tutorials/new-tab-same-directory.md
:warning:Warning
View
Details

TerminalDocs/images/duplicate-tab-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/split-pane-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/new-tab-same-directory.md

Line 53, Column 77: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_prompts?view=powershell-7.2' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 55, Column 27: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7.2#the-profile-files' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 111, Column 6: [Warning: file-not-found - See documentation] Invalid file link: 'customize-settings/actions'.
Line 121, Column 6: [Warning: file-not-found - See documentation] Invalid file link: 'customize-settings/actions'.
Line 53, Column 77: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_prompts?view=powershell-7.2' will be broken in isolated environments. Replace with a relative link.
Line 53, Column 77: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_prompts?view=powershell-7.2. Otherwise, remove the view parameter.
Line 55, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7.2#the-profile-files' will be broken in isolated environments. Replace with a relative link.
Line 55, Column 27: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7.2#the-profile-files. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3868366:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/tutorials/new-tab-same-directory.md
:warning:Warning
View
Details

TerminalDocs/images/duplicate-tab-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/split-pane-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/new-tab-same-directory.md

Line 115, Column 6: [Warning: file-not-found - See documentation] Invalid file link: '../customize-settings/actions'.
Line 125, Column 6: [Warning: file-not-found - See documentation] Invalid file link: '../customize-settings/actions'.
Line 53, Column 77: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_prompts' will be broken in isolated environments. Replace with a relative link.
Line 55, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_profiles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6f1047b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/images/duplicate-tab-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/split-pane-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/new-tab-same-directory.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 977ed76:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/images/duplicate-tab-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/split-pane-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/new-tab-same-directory.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Since window restoration uses this same feature, perhaps it would be a good idea to include it somewhere in the description of the guide? That or a link in https://github.com/MicrosoftDocs/terminal/blob/main/TerminalDocs/customize-settings/startup.md to this guide?

Docs Build status updates of commit 44fb11b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/images/duplicate-tab-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/split-pane-same-cwd.gif
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/new-tab-same-directory.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


docs(README): remove defineField util from README

Remove defineField utility from the README as it was deprecated in https://github.com/accesimpot/graphql-gene/pull/68

:tada: This PR is included in version graphql-gene-v1.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Will there be a REPL?

Will there ever be a REPL for Crystal? And if so, how soon?

There is desire, yes, but quoting @asterite from https://github.com/manastech/crystal/issues/681#issuecomment-106538018 "I think it's possible, just hard."
I will close this as duplicate. Feel free to follow the topic on the other issue or in the mailing list.
Regarding when, it is no in the short/mid goals as in https://github.com/manastech/crystal/wiki/Roadmap or https://salt.bountysource.com/teams/crystal-lang


Remove Postgres

Very few images require PostgreSQL so it does not make sense to include it in the base Ubuntu. This will require rebuilding all other Docker images

[ ] Ubuntu
[ ] Tomcat
[ ] OAQA
[ ] Brandeis
[ ] Gigaword
[ ] Vassar

There are now two ubuntu images:

lappsgrid/ubuntu - base Ubuntu image
lappsgrid/ubuntu:postgres - base Ubuntu with PostgreSQL


Cite error with commands in prefix

This is my JSON file:
[
    {
        "id": "Williams1992-Heaven20",
        "type": "article-journal",
        "author": [
            {
                "family": "Williams",
                "given": "Michael"
            }
        ],
        "title": "Of Heaven and History: The Verticalist Eschatology of Geerhardus Vos",
        "title-short": "Heaven and History",
        "volume": "20",
        "issue": "3",
        "container-title": "Pro Rege",
        "page": "9-18",
        "URL": "https://digitalcollections.dordt.edu/pro_rege",
        "issued": {
            "date-parts": [
                [
                    "1992"
                ]
            ]
        },
        "accessed": {
            "date-parts": [
                [
                    "2022",
                    "12",
                    "13"
                ]
            ]
        }
    }
]

The following code produces the right (expected) output:
% !TEX encoding = UTF-8 Unicode
\documentclass[12pt,oneside]{article}
\usepackage{citation-style-language}
\cslsetup{style = chicago-fullnote-bibliography}
\addbibresource{myBib.json}
\begin{document}
test.\cite[prefix = {See the opposite view in },
page = 1]{Williams1992-Heaven20}
\newpage
\printbibliography
\end{document}

The following code (with the command in the prefix) fails to produce a footnote or final reference:
% !TEX encoding = UTF-8 Unicode
\documentclass[12pt,oneside]{article}
\usepackage{citation-style-language}
\cslsetup{style = chicago-fullnote-bibliography}
\addbibresource{myBib.json}
\begin{document}
test.\cite[prefix = {See the \textit{opposite} view in },
page = 1]{Williams1992-Heaven20}
\newpage
\printbibliography
\end{document}

Thanks,
Nick

Thanks for your feedback and I can reproduce the bug.

Previously the citation prefix was assumed to be a plain string and citeproc-lua didn't recognize LaTeX markups. Now the prefix is parsed to rich text format in CSL v1.1 and the issue should be fixed.


FullCheckPoint Listener

Provide a way to register a listener on checkpoint.
Useful for external indexing system like Lucene.

@taburet - just for my curiosity.....do you work for OrientDB?
Scott

@smolinari yes, I do, for about a month.

Cool! Congrats. Glad to see the team growing! That is theoretically a good sign for us "customers". :smile:
Scott

OIndexEngine#flush for each engine is now called on OAbstractPaginatedStorage#synch.


WSIO-397 change content secondary text color

For content component in dark mode, strong text colour was changed. In the requirements, target text type is referenced to as 'secondary', but it is actually simple bold text, so the changes may affect text colouring in unexpected places. For that reason, PR should be considered experimental or temporary, until we come up with a better idea (which may include restructuring/reauthoring the content).
Also, the specific colour requested by the designer ( #03dac6 ) doesn't match any of existing secondary colours in dark-mode/atomic-design-system/00-token/t.color/t.color.scss , so a new variable was introduced.
Description
Reference: Figma
Before:

Required result (from reference):

Motivation and Context
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue) labeled with bug
[ ] New feature (non-breaking change which adds functionality) labeled with enhancement
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code standards of this project.
[ ] My change requires updating the documentation. I have updated the documentation accordingly.

Closed - design changed and we need to update colors and provide class with secondary color


Skip steps who depend on an failed step witch ignores failure

when:
  - event: push
    branch: main

steps:
  failing-step:
    image: alpine
    commands:
      - printenv
      - exit 1
    failure: ignore
  should-not-start:
    image: alpine
    commands:
      - printenv
      - exit 1
    depends_on:
      - failing-step

we should add a new failure mode: skip_dependencies or so ...
so we can make checks and skip things based on that ...
blocked by: #3009

I don't get your request yet. Isn't your pasted config working already?
Are you talking about a "soft" depends_on that is optional if the previous step was skipped:

steps:
  should-even-start-if-prev-was-skipped:
    image: alpine
    commands:
      - printenv
      - exit 1
    depends_on:
      - name: skipped-step
        optional: true

huh ... well yes you solution looks better!
it would be:
when:
  - event: push
    branch: main

steps:
  failing-step:
    image: alpine
    commands:
      - printenv
      - exit 1
    failure: ignore
  should-not-start:
    image: alpine
    commands:
      - printenv
      - exit 1
    depends_on:
      - name: failing-step
        optional: false

where if not set optional would be true by default (to behave backwards comp.)


feat: added estimates for quote handled by bot

Description
Added estimates for quote handled by bot in the Account Balance tab, similar to Issue #303, but for every coin pair handled by the bot currently.
It recycles estimates shown in the frontend cards and simply sums it up in the title.
It supports not only USDT, but all pairs currently analyzed by the bot at the current time.
How Has This Been Tested?
It has been tested on both the dev and production APIs.
Screenshots (if appropriate):

Special thanks to
@sentientmachin3

@ilbuonmarcio
Thanks for your contributions.
It looks great.
How it will show in the mobile view?

Not really a big fan, if you have suggestions :)
Else I'd propose to make another section for stats like that; I was thinking in the near future to add graphs for "best" coins and "worst" coins based on trades, and so on. But that's for another time, maybe we can refactor and move later

That's a screenshot for my fork rebased as v0.0.78, but the app is almost the same

That's a screenshot for my fork rebased as v0.0.78, but the app is almost the same

Yap that is fine.

Not really a big fan, if you have suggestions :)

I think to remove Managed by bot and simply shows the balance [USDT: 115.5440] [BTC: 0.00001] for now.
On a mobile, it better show in two lines to make it easy to read in case you have multiple quote assets.
On a desktop, it can be in a single line.
<button
  type="button"
  class="btn btn-sm btn-link btn-account-balance text-uppercase font-weight-bold w-100 align-left"
  style="text-align: left"
>
  Account Balance

  [USDT: 115.5440] [BTC: 0.00001]
</button>

What do you think?

Tried using br tag before to no avail, those additional style classes should do the trick!
I'll fix it up and add the commit here to this PR and let you know :)

Added the fix for mobile view :)

After I merge, I just realised.
Since this is the balance of purchased coins, it would make more sense to be in the Open trades, not Account balances.
I guess I can move later.

Do you like it more this way?

Yeah, I think that makes more sense since the value does not include other coins. (I guess that is why you added "Managed by bot" text)

Yes, you're right :)
Do I need to open another pull request with refactor tag?

Hmm, looks like it. You cannot re-open merged PR? :shrug:
If you can, please. Otherwise, I can fix up later :smile:

No, It seems like I can't re-open an already merged PR sadly.
I'm just opening another one, dw :)


Using  or other font attributes in section title crashes in javascript

This is caused by line 1684 of application.js
$(tocName)
I don't really understand what is the purpose of this piece of code, nor do I understand why it crashes, but would be good to fix a.s.a.p.
This code is in there since 2017.

@torinfo that's very surprising! Not so much that  causes the crash but also even just making a word in the section title bold or changing it's colour via the mini toolbar. If this has been the case for a long time how come it hasn't cropped up before!?

@ronm123 I suspect it is caused by the different version of jQuery needed because of the changed version of bootstrap. In the end I did not upgrade bootstrap to the version I tried first, but installed the latest patch of the version we were using. So we could look into going back to the same version of jQuery as 3.10.

@ronm123 We're using the same version as in Xot now (1.9.1 which is quite old in it self) for v3.11.
For 3.10 we used 1.8.2. And that version does not crash, but does strange things as well. For example, if you use 'Page 1 as the title, only the 1 ends up in the top menu of a page.
I think the code just tries to strip out html, but I am not entirely sure.

@FayCross  Do you have time to have a look at this code and explain (if you still know how the code works you created in 2017) what you are trying to accomplish with the cleaning up of tocName around line 1684 of application.js?

@torinfo I'll have a look

@torinfo is that better? I think that code's still needed to strip out some changes to text so the section menu doesn't look odd - there might be a better way of doing that but for now that commit stops it crashing

@FayCross I'll have a look. So it's just some chages and not all. I.e. It's not an option to use $(.append(tocName).text()?
That strips out all html

@torinfo the code was trying to just strip out a couple of things rather than every thing - that way things like super/subscripts, font awesome icons etc. will stay. I don't remember adding this so I don't mind if it's changed to be simpler but I can see that people might want some html left in there

@FayCross Ah yes. I can see that. The page titles have the same issue, and the same code (around line 525) so I fixed that in the same way.


Search should be case insensitive

From the "Add Package" UI window, the search for packages should be case insensitive (like the nuget package manager).

Mhm what source did you specify in dependencies file?

Nuget v3 API and a private server.

What server? Our tests against nuget.org v3 are case insensitive

Seems like it's indeed case insensitive for https://api.nuget.org/v3/index.json but not for our private server. But if I use Nuget Package manager, the search is case insensitive for our private server, so I guess it has something to do with the Paket VS Extension and not the private nuget server ?

Yes it probably is possible to fix in paket. That's why I asked which
server you use
https://github.com/fsprojects/Paket/blob/master/integrationtests/Paket.IntegrationTests/AutocompleteSpecs.fs#L29
you might want to modify this test locally to see what's going on.
On Jan 18, 2016 15:13, "dcorriveau-omniscient"<EMAIL_ADDRESS>wrote:

Seems like it's indeed case insensitive for
https://api.nuget.org/v3/index.json but not for our private server. But
if I use Nuget Package manager, the search is case insensitive for our
private server, so I guess it has something to do with the Paket VS
Extension and not the private nuget server ?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/93#issuecomment-172536627
.

Fixed.


Finish Gymkhana when failing crossing the navigation channel

There is an issue with our current combination of navigation and gymkhana scoring plugins. If the navigation scoring plugin decides to terminate (because the WAM-V performs an illegal maneuver such as crossing a gate backwards or out of order), the gymkhana scoring plugin didn't know about it and continued enabling the scoring as if the team has crossed the channel.
This PR fixes this issue by checking the actual score coming from the navigation channel task message. If we detect that the score is the timeout_score, then, the gymkhana task shouldn't continue.
How to test it?

Run any gymkhana task (change the path to the world file):

roslaunch vrx_gazebo vrx.launch world:=/home/caguero/vrx2022_phase2_ws/src/vrx-docker/generated/task_generated/gymkhana/worlds/gymkhana0.world verbose:=true wamv_locked:=true

Run the joystick controller:

 roslaunch vrx_gazebo usv_joydrive.launch

Teleoperate the WAM-V and make two illegal movements. Try crossing an uncrossed gate backwards and skipping a gate. The gymkhana runs should terminate. The score should be MAX.
Additionally, complete the navigation channel correctly and verify that the task continues. The score should drop substantially when crossing the channel from MAX to a few meters (70-100).

I'm seeing that the trial now terminates instantly when there is one illegal movement:
[Msg] Transited the gate in the wrong direction. Gate invalidated!
[Err] [scoring_plugin.cc:502] VRX_EXIT_ON_COMPLETION and <per_plugin_exit_on_completion> both not set, will not shutdown on ScoringPlugin::Exit()
[ERROR] [1649280793.997056573, 46.088000000]: VRX_EXIT_ON_COMPLETION and <per_plugin_exit_on_completion> both not set, will not shutdown on ScoringPlugin::Exit()

The score reported in /vrx/task/info starts at 0 but then jumps to:
score: 1.7976931348623157e+308

as soon as the state becomes onrunning. Is that the max?

I'm looking back at our documentation for this task and I think it might need some clarification. We say that if you don't cross the channel, your score defaults to the "maximum error" but I don't see anywhere where we say what the maximum error is. Hopefully it's not 1.7976931348623157e+308 since that would be tough to recover from :laughing: . I see in the code it looks like we're setting it to 200. That seems reasonable as long as no one can score worse than that (for example by driving away from the buoy), but I do think we should write it down somewhere.
I'm also not sure about limiting teams to two illegal movements. If we have that in the rules somewhere it's no problem but I'm not seeing it. The way the rules are written it seems like it would be a less radical change to go with one of the following guidelines:

You have completed the navigation channel whenever you cross all gates in the correct order, regardless of how many illegal moves you make in between, OR
You are not allowed to make more than one illegal move, and If you do you have to start over from the first gate.

What do you think? Sorry if I'm missing this in the documentation somewhere--please let me know if that's the case.

The navigation channel sub rules are inherited from VRX'19, where teams were not allowed to miss a single gate or crossed incorrectly. The rules for this year are still capturing that essence. The note about getting the maximum error means that your run should terminate with a score of 1.7976931348623157e+308. I feel that we shouldn't change it at this point unless we see a bit problem with it.

I'm looking back at our documentation for this task and I think it might need some clarification. We say that if you don't cross the channel, your score defaults to the "maximum error" but I don't see anywhere where we say what the maximum error is. Hopefully it's not 1.7976931348623157e+308 since that would be tough to recover from laughing . I see in the code it looks like we're setting it to 200. That seems reasonable as long as no one can score worse than that (for example by driving away from the buoy), but I do think we should write it down somewhere.
I'm also not sure about limiting teams to two illegal movements. If we have that in the rules somewhere it's no problem but I'm not seeing it. The way the rules are written it seems like it would be a less radical change to go with one of the following guidelines:

You have completed the navigation channel whenever you cross all gates in the correct order, regardless of how many illegal moves you make in between, OR
You are not allowed to make more than one illegal move, and If you do you have to start over from the first gate.

What do you think? Sorry if I'm missing this in the documentation somewhere--please let me know if that's the case.

The navigation channel rules are inherited from VRX'19, where teams were not allowed to miss a single gate or cross it incorrectly. The rules for this year are still capturing that essence. The note about getting the maximum error means that your run should terminate with a score of 1.7976931348623157e+308. I feel that we shouldn't change it at this point unless we see a bit problem with it.

I'm seeing that the trial now terminates instantly when there is one illegal movement:
[Msg] Transited the gate in the wrong direction. Gate invalidated!
[Err] [scoring_plugin.cc:502] VRX_EXIT_ON_COMPLETION and <per_plugin_exit_on_completion> both not set, will not shutdown on ScoringPlugin::Exit()
[ERROR] [1649280793.997056573, 46.088000000]: VRX_EXIT_ON_COMPLETION and <per_plugin_exit_on_completion> both not set, will not shutdown on ScoringPlugin::Exit()

The score reported in /vrx/task/info starts at 0 but then jumps to:
score: 1.7976931348623157e+308

as soon as the state becomes onrunning. Is that the max?

Yes, it is.

The navigation channel rules are inherited from VRX'19, where teams were not allowed to miss a single gate or cross it incorrectly. The rules for this year are still capturing that essence. The note about getting the maximum error means that your run should terminate with a score of 1.7976931348623157e+308. I feel that we shouldn't change it at this point unless we see a bit problem with it.

I think there must be some confusion here. In 2019, the score for the navigation task was simply the amount of time it took the teams to complete the course. If they did not complete it, the score was set to the maximum run time. We gave a formula to calculate maximum run time, and it was:

The maximum run time (T) for each run is T=D/V, where V is a nominal speed of 0.25 m/s and D is the total piecewise linear distance between gates.

It would be very strange for maximum run time to be set to the largest representable number. Further, since the task score is the mean of all run scores, failure to finish even one channel would be devastating.
In the gymkhana task, the score is measured in a different unit from the navigation channel: it's an error distance in meters rather than a completion time in seconds. To keep with the spirit of the 2019 rules, I think it would make much more sense to set the maximum value equal to the initial distance between the WAMV at its starting position and the pinger.

The score looks good now, but when an illegal move is committed, the task time looks like it switches to nanoseconds before exiting:
name: "gymkhana"
state: "finished"
ready_time:
  secs: 10
  nsecs:         0
running_time:
  secs: 20
  nsecs:         0
elapsed_time:
  secs: 17
  nsecs: 956000000
remaining_time:
  secs: 282
  nsecs:  44000000
timed_out: False
num_collisions: 0
score: 200.0

The score looks good now, but when an illegal move is committed, the task time looks like it switches to nanoseconds before exiting:
name: "gymkhana"
state: "finished"
ready_time:
  secs: 10
  nsecs:         0
running_time:
  secs: 20
  nsecs:         0
elapsed_time:
  secs: 17
  nsecs: 956000000
remaining_time:
  secs: 282
  nsecs:  44000000
timed_out: False
num_collisions: 0
score: 200.0

Looking closely, this also happens when the regular timeout occurs but it is less noticeable when the value is 0. It's strange but seems like an unrelated issue.

Could you please clarify what do you mean by the task time looks like it switches to nanoseconds?

Could you please clarify what do you mean by the task time looks like it switches to nanoseconds?

Looking more closely, maybe it's functioning as intended. I was confused because the nsecs fields are always 0 except when the task terminates do to an illegal move, at which point they are suddenly populated. This is probably because the /vrx/task/info message only updates at a frequency of 1Hz.

Could you please clarify what do you mean by the task time looks like it switches to nanoseconds?

Looking more closely, maybe it's functioning as intended. I was confused because the nsecs fields are always 0 except when the task terminates do to an illegal move, at which point they are suddenly populated. This is probably because the /vrx/task/info message only updates at a frequency of 1Hz.

Exactly, I think this is expected.


issue #52

added get in touch button which opens a form .
added animation on title "JGEC Previous Year Question Paper".
added a button at the bottom scroll to top

Please send the demo website link.

Please send the demo website link.

How to send that do I need to host it

https://123shreyanvi.github.io/jgec-previous-year-question-paper/ here you go

Hey button is not working, kindly check it

Hey button is not working, kindly check it

yes ,I Know  I tried fixing it but couldn't do it
I don't know where it went wrong .

Listen use this type of code :
HTML:

Add some beautiful css in it .
Then add Javascript:
// Get the button
let mybutton = document.getElementById("myBtn");
// When the user scrolls down 20px from the top of the document, show the button
window.onscroll = function () { scrollFunction() };
function scrollFunction() {
if (document.body.scrollTop > 20 || document.documentElement.scrollTop > 20) {
mybutton.style.display = "block";
} else {
mybutton.style.display = "none";
}
}
// When the user clicks on the button, scroll to the top of the document with smooth effect
function topFunction() {
window.scrollTo({
top: 0,
behavior: "smooth"
});
}
You can get some idea from it

Listen use this type of code : HTML: "button" onclick="topFunction()" id="myBtn" title="Go to top"></button
Add some beautiful css in it .
Then add Javascript:
// Get the button let mybutton = document.getElementById("myBtn");
// When the user scrolls down 20px from the top of the document, show the button window.onscroll = function () { scrollFunction() };
function scrollFunction() { if (document.body.scrollTop > 20 || document.documentElement.scrollTop > 20) { mybutton.style.display = "block"; } else { mybutton.style.display = "none"; } }
// When the user clicks on the button, scroll to the top of the document with smooth effect function topFunction() { window.scrollTo({ top: 0, behavior: "smooth" }); }
You can get some idea from it

okay


Figuring out how to schedule cron functions

I love using this so much more than trying to work in javascript instead of Dart, so thanks.  I'm using this to check all the upcoming events and send notifications to the members.  I got almost everything done, and it should be working, but the hard part was creating a function[] for a scheduledTask to check the event start times.  I got it implemented with this cron package https://pub.dartlang.org/packages/cron and it was really easy to use in my main, I can't figure out how to run it as a cloud function.  This was my attempt:
functions['scheduleCheck'] = cron.schedule(new Schedule.parse('*/$minuteInterval * * * *'), () async {
    print('Tick every $minuteInterval minutes');
}

However it wasn't as simple as I thought.  Is there a trick I might be missing?  I'd be so happy to see this cloud function hold together, perfect companion for them Flutter apps.
If I were doing it in the javaScript method, I would create the cron.yaml with the repeating event as in this example: https://github.com/FirebaseExtended/functions-cron but I don't know how that translates in Dart.
To send out the Firestore Cloud Messaging, I'm using this https://pub.dartlang.org/packages/fcm_push which seems to be compatible so far, but haven't pushed tested yet.  I was expecting a FCM method built into this, but was glad to find the solution.
Anyways, thanks for this interop, I'm feeling safe using it..

Update, it actually does work with the cron.schedule command, but not in it's own cloud function task.  When I run the cron function from main(), it's actually running multiple times with each functions[''] = job that I guess runs the whole script for all the independent cloud functions.  Not what I expected, but understanding it better now.  Now I'm trying to figure out how to make a custom Cloud Function task that only runs on init to start the cron job without it getting started on all the function threads.
I'm also facing problems using the Dart fcm_push or the pubsub_push.  I installed the gcloud, googleapis and googleapis_auth dependencies, and set up the ServiceAccountCredentials to get the AuthClient, and everything seems to be done right, however I get this uncaught exception in the log:
ReferenceError: XMLHttpRequest is not defined
at /user_code/build/node/main.dart.js:9351:7
I just can't get past that, no matter what I tried.  Is there a trick I'm missing, or a better way to push notifications to subscribers or user token ids using this interop?  Thanks.

Sorry, I didn't have time to look into this.
Looks like Firebase added support for scheduled functions as described here: https://firebase.google.com/docs/functions/schedule-functions
I will look into adding support for this over the weekend.

See pull request #53

#53 has been merged and published as 1.0.2.
Closing this as resolved. Feel free to open a new issue if you still have any questions.


Fix async issues where items in a ballot paper (including the header) arrive in the wrong order

This will require some research and experience of async

Unfortunately this might end up just being a sleep(0.5) of some sort after the header is sent, but that feels a bit hacky


[folding] Ctrl-Click to Unfold All Nested

This is a feature request.
Ctrl-Click to Unfold All Nested. Similar to Notepad++.
This is the wanted behaviour:
Start state:

Collapse again:

Ctrl-Click the + button:

ctrl+click was also considered to add an additional cursor on Linux but not done because currently ctrl+click opens links in the document (#3091).

It's also valid for folding directories in the sidebar. On a Mac for example it's a native behavior, when you fold or expand something pressing alt (option) + mouse click all nested elements in that folder are folded or expanded respectively.
It would be nice upgrade for VS Code if it could follow the same rule.
Thanks.

Other editors use Alt + Click to fold/unfold all nested elements, I think it's pretty standard.

Added Shift + Click on the folding icon to fold/unfold recursively (in 1.19)


Uncaught Hitrov\Exception\CurlException: curl error occurred: SSL certificate problem: unable to get local issuer certificate, response:  in C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\src\HttpClient.php:31

Hey guys.
Anyone could help me with this error?
PHP Fatal error:  Uncaught Hitrov\Exception\CurlException: curl error occurred: SSL certificate problem: unable to get local issuer certificate, response:  in C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\src\HttpClient.php:31
Stack trace:
#0 C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\src\OciApi.php(257): Hitrov\HttpClient::getResponse()
#1 C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\src\OciApi.php(132): Hitrov\OciApi->call()
#2 C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\index.php(74): Hitrov\OciApi->getInstances()
#3 {main}
  thrown in C:\Users\Palicz\Downloads\setup\oci-arm-host-capacity\src\HttpClient.php on line 31

how did you fix this?


esbuild is not reloading on asset only changes

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
esbuild is not detecting style changes when importing style file inside index.html
This issue does not happen in non esbuild builder
Minimal Reproduction
ng17rc1.zip

unzip above zip file and run npm install
check UI
now go to src\assets\ruf-default.css and update color property of header element to some other color
check if styles are reflecting on UI

Exception or Error
No response
Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 17.0.0-rc.1
Node: 18.18.2
Package Manager: npm 8.19.3
OS: win32 x64

Angular: 17.0.0-rc.1
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0-rc.1
@angular-devkit/build-angular   17.0.0-rc.1
@angular-devkit/core            17.0.0-rc.1
@angular-devkit/schematics      17.0.0-rc.1
@schematics/angular             17.0.0-rc.1
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.0

Anything else relevant?
No response

This is caused by at the moment, the page is not reloaded when only an asset change.

@alan-agius4 Would this affect template-only changes in components? After upgrading to 17, I can't seem to trigger a browser refresh when modifying a component HTML template, but modifying a component .ts file seems to work fine.

@alan-agius4 Would this affect template-only changes in components? After upgrading to 17, I can't seem to trigger a browser refresh when modifying a component HTML template, but modifying a component .ts file seems to work fine.

the problem was something else, I spun up a new angular app to demonstrate the problem and it worked fine. i fixed the problem in my app by copying the new angular.json file into my project.

@alan-agius4 Would this affect template-only changes in components? After upgrading to 17, I can't seem to trigger a browser refresh when modifying a component HTML template, but modifying a component .ts file seems to work fine.

the problem was something else, I spun up a new angular app to demonstrate the problem and it worked fine. i fixed the problem in my app by copying the new angular.json file into my project.

I was running into this also, and having aot: false in the configuration is what was causing the HTML template modifications to be detected.

I am also facing this problem and can confirm that aot:false is a workaround

still an issue on the 17.2.3

Still occuring as of 17.3.11


Graceful exit for background tasks like in tokio

Issue
When using async-std's block_on, the background tasks spawned are neither stopped neither awaited properly. This means that destructors are not called as they should.
I talk about this with @yoshuawuyts and there seems to be a way to do it with task cancellation but I think async-std should actually stop the tasks gracefully.
Current behavior
To help understand the issue I made this repository to demonstrate: https://github.com/cecton/asyncstd-test-drops
In this example a task is ran in background for async-std and then I use block_on on a sleep. The sleep finishes before the task actually completes and we exit the block_on despite things are still running in background.
Right after in the same example I do the exact same thing with tokio and you can see that in tokio the block_on only exit when the task and its objects are dropped properly.
Here is the output of the program if I comment the tokio example and keep only the async-std example. Note that the destructor is never called:
     Running `target/debug/asyncstd-test-drops`
test 1 created
1
2
[Finished running]

The program finished in 2 seconds because the timeout is of 2 seconds. All the blocking tasks in background and objects are just not dropped.
Here is the output of the program if I comment the async-std example and keep only the tokio example. Note that the task is dropped before reaching the marker "2":
     Running `target/debug/asyncstd-test-drops`
test 2 created
1
Dropping 2...
Dropped 2.
2
[Finished running]

The program finished in 7 seconds. This is the addition of the 2 blocking codes (std::thread::sleep). It blocks the thread and prevents tokio to finish.
Now another interesting thing is this: if I keep both examples enabled, this is the output I get:
     Running `target/debug/asyncstd-test-drops`
test 1 created
1
2
test 2 created
1
Dropping 2...
test 1 dropped
Dropping 1...
Dropped 2.
2
[Finished running]

The async-std task was still running in background and it finished while the tokio test was running. Here the Test(1) object created by the async-std task is beginning the drop but it couldn't finish because the tokio drop finished before. I first thought that the background tasks were abruptly killed by async-std but this proves this is not the case. The background tasks are still running, they're just not managed anymore.
Expected behavior
I have worked a lot with asyncio on Python and recently a bit with tokio. I expect that the async runtime will drop things gracefully. You could argue that I could implement a shutdown mechanism (which is true) but that doesn't allow the runtime to simply forget about my objects and not call their destructors.
The best behavior is to wait for the background tasks to get into an awaiting state (waiting for io, waiting for a sleep, etc...) and cancel the task, deleting it and its objects. When everything has been deleted, the block_on should finish and the program can safely exit.

Hi @cecton, thanks for opening this. This issue is not unlike https://github.com/async-rs/async-std/pull/830 which also had questions about the async_std::task spawn model. The resolution for that issue is that we should add the following to our docs:

The join handle will implicitly detach the child task upon being dropped. In this case, the child task may outlive the parent [...]

This behavior has been a deliberate choice in async-std to create parity between std::thread::Thread and async_std::task::Task. As a result of this our tasks can be run to completion by any executor and runtime, which we think is really nice for compatibility between runtimes. If our task::block_on was somehow special we would deviate from the std::thread behavior, and lose these benefits.
I don't think this is a change we can make at this time. Instead I would recommend trying to call Task::join / Task::cancel, or creating a synchronization construct for detached tasks using event-listener or async-channel.

And there is no way to do a graceful shutdown without the joinhandle? Or at least gracefully exit when the process exit?
I think it is weird to allow the program to go into an inconsistent state where destructors are ignored.

I think it is weird to allow the program to go into an inconsistent state where destructors are ignored.

Rust doesn't guarantee for destructors to ever run; on a power outage or process reap there is no way these can be run anyway so it's a case to always account for.

Or at least gracefully exit when the process exit?

Good question: Boats wrote a post on async drop which would allow for "graceful exit on drop". But that wouldn't apply for Tasks since the background behavior is the way it is by design.
Instead we may look in a different direction, and aim to make joining multiple tasks easy. I did some work on this through parallel-stream (though wouldn't recommend using it yet). Another option would be an async version of rayon::scope though nobody has figured out how to make this work for async Rust yet. It's also possible to hand-roll constructs using task::spawn and FuturesUnordered / futures::FuturesExt::for_each_concurrent.

I just tested with the for_each_concurrent approach and it works pretty neat. Thanks a lot! I think I will use that for now.
fn wait_completion()
-> (mpsc::UnboundedSender<Pin<Box<dyn Future<Output = ()> + Send>>>, Pin<Box<dyn Future<Output = ()> + Send>>)
{
    let (tx, rx) = mpsc::unbounded::<Pin<Box<dyn Future<Output = ()> + Send>>>();
    let monitor = rx.for_each_concurrent(None, |x| async move { x.await; } );

    (tx, Box::pin(monitor))
}

...

    let (mut tx, monitor) = wait_completion();
    let completion = async_std::task::spawn(monitor);
    ...
    tx.send(async_std::task::spawn(some_task())).unwrap();
    ...
    // graceful shutdown
    tx.close_channel();
    completion.await;

(This code doesn't include the exit signal handling, only the clean shutdown)


OpenCV.imwrite fails

I have the following code:
using OpenCV;
const cv = OpenCV;
img = cv.imread("../../debug/roi_frame_0.png");
filename = "../../debug/roi_frame_processed_" * string(0) * ".png";
cv.imwrite(filename, img);

and get the following error:
ERROR: MethodError: no method matching var"#imwrite#245"(::CxxWrap.StdLib.StdVectorAllocated{Int32}, ::typeof(OpenCV.imwrite), ::String, ::OpenCV.Mat{UInt8})
Closest candidates are:
  var"#imwrite#245"(::Vector{Int32}, ::typeof(OpenCV.imwrite), ::String, ::Union{OpenCV.CxxMat, AbstractArray{T, 3} where T<:Union{Float32, Float64, Int16, Int32, Int8, UInt16, UInt8}}) at /home/andreasziegler/.julia/artifacts/7f7ecae944127299b78b8a360c8b5a5f94df8b2f/OpenCV/src/cv_cxx_wrap.jl:2345
Stacktrace:
 [1] imwrite(filename::String, img::OpenCV.Mat{UInt8})
   @ OpenCV ~/.julia/artifacts/7f7ecae944127299b78b8a360c8b5a5f94df8b2f/OpenCV/src/cv_cxx_wrap.jl:2345
 [2] top-level scope

I think you're using https://github.com/archit120/OpenCV.jl. It's a bit confusing.

Indeed. Sorry for bothering you.


Extension failing to load

Environment data

VS Code version: 1.57.1
Extension version (available under the Extensions sidebar): v2021.6.944021595
OS and version: Debian 11
Python version (& distribution if applicable, e.g. Anaconda): python 3.8.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): poetry
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: Pylance

Expected behaviour
Python extension loads
Actual behaviour
Python extension appears to hang during loading with no output
Steps to reproduce:
Open any python file, status bar shows  "Python Extension loading..." forever
Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

User belongs to experiment group 'pythonaa'
User belongs to experiment group 'pythonJediLSP'
User belongs to experiment group 'pythonDiscoveryModuleWithoutWatcher'
User belongs to experiment group 'pythonTensorboardExperiment'
User belongs to experiment group 'pythonSurveyNotificationcf'
User belongs to experiment group 'PythonPyTorchProfiler'
User belongs to experiment group 'pythonDeprecatePythonPath'

this appears to have been resolved by disabling all extensions and then enabling all extensions afterwards


[GSSOC'23]Adding hover in the footer

I would like to contribute to this issue under GSSOC'23. Please assign me this issue.

Follow new issue template acc to guidlines


nanoseq: few fast5 reads for testing

Added the direct cDNA fast5 files (less than 50Mb) and updated the readme

Thanks @lwratten ! I think Ive found a way to download all of the files in testdata in order to test the pipeline. Its a bit messy but it works! Ill merge this in now and add in samplesheet etc :+1:


Remove last signs of building SRPMs outside copr

          I think that now as we switched to SRPMs in Copr, `wait_for_srpm` should be always `True`; we should have removed this already, so we can do a follow-up PR to not add more work to you

Originally posted by @lbarcziova in https://github.com/packit/packit-service/pull/1787#discussion_r1087676159

Don't we still need the ability to build SRPMs outside of Copr in order to support building in Koji?

Yes, but my comment was related only to SRPMs for Copr.


Fix support of touchscreens for RPI

The current implementation of the EventThread for the Raspberry Pi doesn't resolve isMouseButtonPressed/Up/Down() neither does it updates the position if using GetTouchPosition(int) if using a touchscreen
This PR attempts to solve this shortcomings by adding some extra logic:
-It checks the absolute pressure in the screen in an absolute event to simulate a touch action or a left mouse click.
-Updates the touch position at index 0 on absolute events.
This fixes #1585

@Jpe230 Thanks! Nice improvement!


New template helpers now, utcnow, distance, closest

This will add 4 new variables/methods available in templates:

now - the current local time
utcnow - the current utc time
distance() - measure the distance in meters between home, entity, coordinates
closest() - find the closest entity

Distance examples
If only 1 location is passed in will measure the distance from home.
Using Lat Lng coordinates: {{ distance(123.45, 123.45) }}

Using State: {{ distance(device_tracker.paulus) }}

These can also be combined in any combination:
{{ distance(123.45, 123.45, device_tracker.paulus) }}
{{ distance(device_tracker.anne_therese, device_tracker.paulus) }}

Closest examples
Find entities closest to the Home Assistant location:
Query all entities: {{ closest(states) }}
Query all entities of a specific domain: {{ closest(states.device_tracker) }}
Query all entities in group.children: {{ closest('group.children') }}
Query all entities in group.children: {{ closest(states.group.children) }}

Find entities closest to a coordinate or another entity. All previous arguments still apply for 2nd argument.
Closest to a coordinate: {{ closest(23.456, 23.456, 'group.children') }}
Closest to an entity: {{ closest('zone.school', 'group.children') }}
Closest to an entity: {{ closest(states.zone.school, 'group.children') }}

Combined
Since closest returns a state, we can combine it with distance too
{{ closest(states).name }} is {{ distance(closest(states)) }} meters away.

Right now when any of the input data is wrong for distance or closest it will log an error and return None.
I am not sure if that is a good approach or that we want to raise an exception.


fix: udeps no longer compiles on nightly

Either udeps or my project is no longer is compiling on nightly. This PR switches to using nightly-2024-02-04 which worked.
Also exposes the actual toolchain version installed for formatting, as well as exposes the udeps toolchain version for modification.
Slack conversation

My CI passes now with this version: https://github.com/WalletConnect/notify-server/actions/runs/7806150004/job/21292368308?pr=351


ANR Events not Symbolicating

Is there an existing issue for this?

[x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[x] I have reviewed the documentation https://docs.sentry.io/
[x] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
5.6.0
Electron Version
32.1.2
What platform are you using?
Windows
Link to Sentry event
https://openai.sentry.io/issues/6020361972/?environment=development&project=4507771614265344&query=is%3Aunresolved issue.priority%3A[high%2C medium]&referrer=issue-stream&sort=date&statsPeriod=30m&stream_index=1
Steps to Reproduce

Build typescript with vite framework and use sentryVitePlugin configured as so:

sentryVitePlugin({
      org: "Redacted",
      project: "Redacted",
      authToken: process.env["SENTRY_AUTH_TOKEN"],
      telemetry: false,
      release: {
        name: pkg.version,
        inject: false,
      },
      sourcemaps: {
        filesToDeleteAfterUpload: [".vite/build/*.map"],
      },
    }),

Upload Native Symbols via a speerate script configured in package.json as:
"symbol-upload": "sentry-cli debug-files upload -o Redacted -p Redacted packages"

Simulate ANR issue in Electron-based application and send event to Sentry

Expected Result
Error's callstack should symbolicate. Debug Symbols mapping to the issue are present in its release, verified built via Source Map Upload Report.
Actual Result
ALL ANRs are unsymbolicated and claims that stack frame doesn't have Debug IDs when expanding the "unminify code" buttons for any stack frame.
Non-ANR events which are symbolicated contain a debug_meta/images key with the debug ids of the sourcemaps needed to symbolicate the event. By contrast, ANRs simply can't reference the images, even though we've verified they're there.

Is this with a hang in the main process or in a renderer?

Is this with a hang in the main process or in a renderer?

@timfish This concerns main process ANRs.

@timfish what follow-up do we have to do here?

The fix has been released through a @sentry/node update. I should add a test in this repo to ensure it still works with the path rewriting!


Bump requirements to PHP ^7.2 and Symfony ^4.4|^5.0

Fixes #1258.
This PR does not remove any dead code, just bumps up requirements and adjusts CI configs.
What to do later?

Remove dead code that brings compatibility for Symfony <4.4
Remove dead code that brings compatibility for PHP <7.2
Setup some coding standard tool in order to maintain a consistent code style (and replace those array() with [])
Merge some cool stuff 🎉

Also fixes some deprecations in existing Travis configuration:


GC: Remove redundant pool searches

This is a reboot of PR 646, but with a slightly different approach.
This PR reduces the worst case times of GC extend and realloc specifically.
It replaces the size and info cache with a single pool cache.

I just tried to enable the cache during marking and it made things slower.
So I'm wondering whether this was really worth the added complexity, given that nobody was yet able to beat the binary search.

I just tried to enable the cache during marking and it made things slower.

Yup, hit rate during marking will be dismal and the cache will thrash.
When moving from separate size and info caches to the centralized pool cache I added the bypass junk to avoid that.

So I'm wondering whether this was really worth the added complexity

I'm in favour of removing the cache. Feel free to pull the plug on it.


Selectable rows

Is there any plan to support selectable rows?..or at least, is there a proper way to do this with current implementation?

Some of this was discussed in #125 - check out @ryanlanciaux's comment.
More or less, there's something available in the repo to do this, but it hasn't made it's way into npm just yet.
Let me know if you have any other questions!


feat: Support for custom headers

I signed the CLA but still not showing. Email on CLA is same as commit email

Thank you @colegottdank  for the suggestion. I have replied to the PR https://github.com/googleapis/nodejs-vertexai/issues/258#issuecomment-2043547010 regarding this feature. I am closing the PR now.


How to use for android

I dont know how to use this library and I dont have much experience with FFmpeg.
I am running out of time because of my deadline.
Can you please prepare some guideliness.
Best regards,
Keep up the good work.

    /**
     * @param in  Input file.
     * @param out Output file.
     * @return false if input file is already fast start.
     * @throws IOException
     */
    public static boolean fastStart(File in, File out) throws IOException, MalformedFileException, UnsupportedFileException {

That's all..!

Note that if it returns false, use in file instead of out.

It is written in pure-java, so no additional dependency or setup is required for Android.

with FFmpeg

If you want to transcode (i.e. create video with smaller size), use android-transcoder and feed its output to this library.

Thanks for ultimately fast reply :)
I did what you said before, but it says 2 out of 3 exceptions alredy catched (without compile).
Here is the code segment;
File f = new File(path);
        try{
            QtFastStart.fastStart(f, f);
        }catch (QtFastStart.QtFastStartException e){
            Log.e("QT", e.toString());
        }catch (QtFastStart.MalformedFileException m){ // catched
            Log.e("QT", m.toString());
        }catch (QtFastStart.UnsupportedFileException q){ // catched
            Log.e("QT", q.toString());
        }catch (IOException i){
            Log.e("QT", i.toString());
        }

path is the recorded video file's path.

It is not library problem.
It is because you catch QtFastStartException at first catch clause.
QtFastStartException is base class of MalformedFileException and UnsupportedFileException, so the catch clause of it should be placed after these two exceptions.
        }catch (QtFastStart.MalformedFileException m){ // catched
            Log.e("QT", m.toString());
        }catch (QtFastStart.UnsupportedFileException q){ // catched
            Log.e("QT", q.toString());
        }catch (QtFastStart.QtFastStartException e){
            Log.e("QT", e.toString());

can't make it work.
debug results are;
ftypAtom: null,
startOffset: 0,
atomSize: 0,
atomType: 0
        printf("last atom in file was not a moov atom");

I did it :))
Thanks for your help. I added you from LinkedIn - Tunahan Bayındır.
I have a few more questions if you can help me I'll really appreciate it.
Have a nice day!


Provide datasource and delegate functions to have more control over Workaholic

datasource:

Set and configure various properties.

delegates:

Know which date/contribution is tapped.
Know when reloads.

Currently, only support a completion block which will tell the date and contribution tapped.


Remove concurrent module ?

In practice, concurrent sq is useful, while concurrent cq is almost useless. we can split the two and provide concurrent sq and non-concurrent cq to avoid some atomic overhead.
And, I hope to implement lock-free squeue.

I have an idea for how to remove the lock in the concurrent sqe. It still involves waiting, but it should be slightly cheaper. We store a second tail atomic, reserved_tail, that stores the ring buffer index up to which there are entries reserved. To push to the sq, threads will:

Increment reserved_tail atomically.
Write their entries to the slots that have been reserved.
While attempting to CAS tail from the old value of reserved_tail to the new value of reserved_tail fails, wait on head's futex.
Wake head's futex.

Would this work?

I have an idea for how to remove the lock in the concurrent sqe. It still involves waiting, but it should be slightly cheaper. We store a second tail atomic, reserved_tail, that stores the ring buffer index up to which there are entries reserved. To push to the sq, threads will:

Increment reserved_tail atomically.
Write their entries to the slots that have been reserved.
While attempting to CAS tail from the old value of reserved_tail to the new value of reserved_tail fails, wait on head's futex.
Wake head's futex.

Would this work?

@Koxiaet  It sounds good, maybe the performance will be better than the lock under light load.
Would you like to try it?

@Koxiaet  It sounds good, maybe the performance will be better than the lock under light load.
Would you like to try it?

@quininer Yes, I'll see if I can implement it.

@quininer Yes, I'll see if I can implement it.


Arcane Blast charges not detectable

Hello,
I can't detect the spell charges of Arcane Blast with that addon. I tried to highlight trinkets when 3 Stacks of Arcane Blast are there but it dosn't get triggered. I tried to detect this as

Buff
Debuff
Spell charge (think this is the right one)
Spell Time Remaining
The Condition never gets satisfied. I'm using the german client, but other spells are working so this seams to be no problem.

kind regards

For some reason, this counts as a deubff on yourself.
So you need to make a condition for Debuff Stacks, with the unit of 'you', and the spell 'Arcane Blast'.
I just tested this.  I guess it's a debuff because it increases the mana cost, despite also increasing damage.


OLS-244: Prompt generator

Description
OLS-244: Prompt generator
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-244

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

/hold

Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 96.55%. Comparing base (0ecfa4a) to head (64726d6).
 Consider uploading reports for the commit 8b6ff22 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   96.96%   96.55%   -0.41%
==========================================
  Files          49       50       +1
  Lines        1580     1598      +18
==========================================
+ Hits         1532     1543      +11
- Misses         48       55       +7

Files
Coverage Δ

ols/src/prompts/prompt_generator.py
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

/unhold

/approve


Update TOTP errors.

There are a couple of changes here.

Update the error message to match the new designs.
Add an error field to the TOTP input as this wasn't there already.
Add the message to contact us to the error div inside template.ftl. We don't want to display this for other login related errors so we're now checking if the error message matches the TOTP one and displaying the contact us message if it is.

It shouldn't break them. We're not checking the 2FA pages at all and it shouldn't show the error messages on any other pages.


Tree Representation

I am wondering if there is any way to print the tree structure in console.

@amitjoy There is a toString() in TreeNode, you can have a try.
see:https://github.com/Scalified/tree/blob/6ba25dc59b6ea3be97c43a9a0de99fc95c410606/tree/src/main/java/com/scalified/tree/TreeNode.java#L753

Thanks @ji-zhou for the quick response


[Bug]

Version
5.4.1
Link to Minimal Reproduction
No response
Steps to Reproduce

I followed this heatmap example - https://echarts.apache.org/examples/en/editor.html?c=heatmap-cartesian to create my heatmap
backend return part of the data, so some grids should show data, and the others are blank.

Current Behavior
Some data are out of grids.
Expected Behavior
The data should all in grids.
Environment
- OS: Ubuntu20.04
- Browser: Chrome
- Framework<EMAIL_ADDRESS>
Any additional comments?
No response

so where is the Minimal Reproduction code ?

The categories of y-axis from backend are wrong, the issue has fixed, thanks for your reply.


Remove Inaccuracy Related to Parent/Subuser Stats

Lines starting at 14 were removed due to inaccuracy of statement claiming that parent statistics will show aggregated numbers of the parent as well as all of the sub users.  At this time, the parent account will only display its own statistics and the sub users have the same.
Description of the change:  See above.
Reason for the change: Inaccuracies in docs information.
Link to original source: https://sendgrid.com/docs/ui/analytics-and-reporting/stats-overview/

Closes #

thanks for letting us know about this @tparkersendgrid!

Hello @tparkersendgrid,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX