Enhancements to Markdown Conversion and Expansion of describe Tool Documentation

Type
Enhancement, Documentation

Description

The convert_to_markdown function in pr_agent/algo/utils.py has been enhanced to handle empty lists in the output_data dictionary. This change improves the markdown conversion process by ensuring that empty lists do not cause issues.
The documentation for the describe tool (docs/DESCRIBE.md) has been significantly expanded and improved. It now includes a detailed table of contents, and new sections on automation and custom labels. The formatting of the document has also been improved for better readability.

Changes walkthrough
Relevant files                                                                                Enhancement

utils.py

        pr_agent/algo/utils.py
The convert_to_markdown function has been updated to handle empty lists in the output_data dictionary. If a value in the dictionary is an empty list, it will be skipped.

 +1/-1

Documentation

DESCRIBE.md

        docs/DESCRIBE.md
The documentation for the describe tool has been significantly expanded. It now includes a table of contents, more detailed explanations, and additional sections on automation and custom labels. Formatting has also been improved for better readability.

 +31/-5

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
To edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

See the describe usage page for a comprehensive guide on how to use this tool.
  Enabling\disabling automation:

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.
 This default settings aim to strike a good balance between automation and control:
If you want more automation, just give the PR a title, and the tool will auto-write a full description; If you want more control, you can add a detailed description, and the tool will add the complementary description below it.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels:
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/a85a328791866d653e79e06c38164a1ace7f9395

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/a85a328791866d653e79e06c38164a1ace7f9395

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc)

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/22b7dd9f2db5d0f0c563936d31baa981522fe0cc


Proposal to reduce boilerplate code

I would like propose to use Lombok to reduce boilerplate code in plugin project.
What do you think about?

@lordofthejars @dev-gaur What do you think about this?

Hi, well I do not like very much Lombok because it relies on the class generation which means that .java files do not contain any getter/setter and then you run one Maven goal and the .class are generated with getters/setters and this is something I do not like because means that when I import the project into IDE I get compilation errors because there is no getter/setters in classes placed at target directory. Also at the very end, it is just getters and setters which are at the bottom of a class and can be autogenerated by IDE.

You are right. It's necessary configure IDE with plugin, but in command line mvn build is transparent.
I believe it's a low cost when compared to the amount of boilerplate code that can reduce.

Should we close this thread? @lordofthejars @rohanKanojia


flannel plugin binary not getting created in kubernetes cluster

I manually deleted the flannel binary from /opt/cni/bin after deleting the kubernetes cluster. On the same VM, I'm trying to setup kubernetes + flannel but flannel binary is not getting created in folder /opt/cni/bin.
Expected Behavior
flannel binary should get created everytime daemonset is deployed
Current Behavior
flannel container starts but kube-dns stays in containercreating mode
Your Environment

Flannel version: 0.9.0
Kubernetes version (if used): 1.7.5
Operating System and version: Redhat 7

@phagunbaya This repo doesn't install the CNI plugin. You'll need to raise an issue with your distro that installs the CNI plugin


The scope 'api://GUID_of_the_server_app_reg/access_graph_on_behalf_of_user' is not registered to the client side app registration in Azure (msal-react-spa | API permissions).

Issue

Please provide us with the following information:

This issue is for the sample

    - [ ] 1-1) Sign-in with Azure AD
    - [ ] 1-2) Sign-in with Azure AD B2C
    - [ ] 2-1) Acquire a Token and call Microsoft Graph
    - [ ] 3-1) Protect and call a web API on Azure AD
    - [ ] 3-2) Protect and call a web API on Azure AD B2C
    - [ ] 4-1) Deploy to Azure Storage and App Service
    - [ ] 4-2) Deploy to Azure Static App Service
    - [ ] 5-1) Call a web API using App Roles
    - [ ] 5-2) Call a web API using Security Groups
    - [ x] 6-1) Call Microsoft Graph using on-behalf-of flow
    - [ ] 6-3) Call a web API using Conditional Access Auth Context
    - [ ] 6-4) Sign-in with Hybrid SPA flow

This issue is for a

    - [ x] bug report -> please search issues before submitting
    - [ ] question
    - [ ] feature request
    - [ ] documentation issue or request

Minimal steps to reproduce

Use the Configure.ps1 script from the AppCreationScripts folder:
e.g. PS C:\Users\jonne\source\repos\ms-identity-javascript-react-tutorial\6-AdvancedScenarios\1-call-api-obo\AppCreationScripts> .\Configure.ps1 -TenantId "your-tenant-id"

The script will succeed but with some errors.

The client app registration is missing the scope of the server's app registration

When the client and the server are started and a user tries to log in, the use sign-in fails. There will be a notification of it in the msal logging messages. The user is not logged in and the application shows a front page that was similar before the failed login attempt.

Any log messages given by the failure

I'm not sure if this is related, but there was one failure after the script was activated:

You are installing the modules from an untrusted repository. If you trust this repository, change its
InstallationPolicy value by running the Set-PSRepository cmdlet. Are you sure you want to install the modules from
'PSGallery'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): A
Connecting to Microsoft Graph
Get-MgUser : Unsupported or invalid query filter clause specified for property 'userPrincipalName' of resource 'User'.
At C:\Users\user\source\repos\ms-identity-javascript-react-tutorial\6-AdvancedScenarios\1-call-api-obo\AppCreationScri
pts\Configure.ps1:251 char:57

... ser = Get-MgUser -Filter "UserPrincipalName eq '$($context.Account)'"

                                                  ~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: ({ ConsistencyLe...ndProperty =  }:<>f__AnonymousType628) [Get-MgUser _List1], RestException1
FullyQualifiedErrorId : Request_UnsupportedQuery,Microsoft.Graph.PowerShell.Cmdlets.GetMgUser_List1

And soon after that another one:
Creating the AAD application (msal-node-api)
Done creating the service application (msal-node-api)
Getting access from 'service' to 'Microsoft Graph'
Added 'Microsoft Graph' to the RRA list.
Granted permissions.
Successfully registered and configured that app registration for 'msal-node-api' at
https://portal.azure.com/#view/Microsoft_AAD_RegisteredApps/ApplicationMenuBlade/~/Overview/appId/22222222-ffff-1111-ZZZZ-XXXXXXXXXXXX/isMSAApp~/false
Creating the AAD application (msal-react-spa)
Done creating the client application (msal-react-spa)
Getting access from 'client' to 'service'
Added 'service' to the RRA list.
Update-MgApplication : Invalid value specified for property 'resourceAppId' of resource 'RequiredResourceAccess'.
At C:\Users\user\source\repos\ms-identity-javascript-react-tutorial\6-AdvancedScenarios\1-call-api-obo\AppCreationScri
pts\Configure.ps1:434 char:5

Update-MgApplication -ApplicationId $currentAppObjectId -Required ...

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: ({ ApplicationId...hApplication1 }:<>f__AnonymousType02) [Update-MgAp plication_UpdateExpanded1], RestException1
FullyQualifiedErrorId : Request_BadRequest,Microsoft.Graph.PowerShell.Cmdlets.UpdateMgApplication_UpdateExpanded
1
Granted permissions.
Successfully registered and configured that app registration for 'msal-react-spa' at

Expected/desired behavior

The client is able to obtain an access token successfully and sign in to the client

Library version

Browser and version

Chrome, Edge, Firefox, Safari? Irrelevant

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Hi @jranxb70 , this bug was discovered in our configuration scripts last week. When Get-MgApplicationOwner fails, the script doesn't query the user information correctly. I will work on updating the scripts as soon as possible. Thanks for the feedback!


Allow offline usage of TestNG

If the user is having network connectivity
issues, today TestNG aborts execution.
For e.g., when there’s no internet connectivity
TestNG fails with “UnknownHostException” and thus
prevents users from using TestNG in offline mode.
Fixed this by falling back to using the embedded DTD
if we fail to read the one on the TestNG website.

@juherr - Fixed and pushed. Please take a look. It actually struck me that I was trying to solve a different problem only today. Current implementation always falls back to loading DTD from jar as long as its URL matches one of the following:

https://beust.com/testng/testng-1.0.dtd
https://testng.org/testng-1.0.dtd

Now incase a user ends up trying to refer to a DTD that is hosted elsewhere and/(or) just wants to use a DTD thats available in their classpath we should be supporting it (by first reading from classpath and then falling back to the URL they specify).
It turns out that I was actually trying to fix this usecase. Got a bit confused in between. Now all is well. Please take another look.


GlobalListeners list get's mutated as we iterate the list.

Overview
Found a bug where the list of global listeners isn't always guaranteed to be executed if that list changes during the execution of that event.
Expected Behavior
Global Listener Events should always be executed.
Actual Behavior
If a GameObject registers or un registers during the ExecuteEvent loop, some objects later in the list will be skipped because the list index has changed.
Mixed Reality Toolkit Release Version
MRTK vNEXT and Legacy HTK

Should be a fairly easy fix. Take a snapshot of the collection and iterate over that.
Interesting factoid: this was a common bug that became easy to find when using foreach loops. You get an exception of the collection changes while iterating over the loop.

In vNEXT I just make Register and Unregister an async void task and just waited until the loop was finished before registering.

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Strider Not Conacting CHP

As shown in https://github.com/ranking-agent/aragorn/issues/266
CHP does have a metakg that shows this edge, which means it should be contacted. When removing the allowlist, the following query plan is generated:
['infores:spoke', 'infores:service-provider-trapi', 'infores:rtx-kg2', 'infores:automat-monarchinitiative', 'infores:automat-robokop', 'infores:automat-hetionet']
This indicates that strider is not correctly interpreting the metakg from CHP, or is unable to assign that edge to CHP. I haven't been able to verify whether or not CHP is actually in the KP registry because the /kps endpoint is currently returning a 500 error.

This has been fixed in dev and CI on CHP side. Their url/server in SmartAPI was causing some sort of redirect to get the actual meta_knowledge_graph, and that was causing the kp registry to skip it. They've fixed their redirect and CHP is being used again.


Json's for injuries and inactives?

Andrew, have you looked to see if you can get jsons from NFL.com/injuries and NFL.com/inactives?  I would love to start grabbing that information other than just trying to scrape NFL's pages. Not sure if there are jsons, but thought you might know.

I haven't looked.

How would I look to see if there are jsons?

Use Chrome or Firefox's development tools to inspect what data is being transferred in the web page.
I don't really know what your experience level is, so I don't know how to give you more targeted advice. For example, if you've never done web development/programming before, then I expect it might be rather difficult to check.

Got it. Thank you.

FYI, it looks like they query injury data on the backend and send it over embedded within the nfl.com/injuries HTML document:
  ...
  <script type="text/javascript">
    ...
    var dataAway = [
        {player: "McCown Joshua ",   position: "QB", injury: "right Shoulder", practiceStatus: "Did Not Participate In Practice", gameStatus: "Out", lastName: "McCown", firstName: "Joshua", esbId: "MCC600777"  },
        {player: "Poyer Jordan ",   position: "S", injury: "Shoulder", practiceStatus: "Did Not Participate In Practice", gameStatus: "Out", lastName: "Poyer", firstName: "Jordan", esbId: "POY177981"  },
    ...


Allow calling centroid on kDOP within space-filling curve

All builds pass (HIP did not run).

(PS this is meant as a suggestion for your description)

You might also want to reference #867


Client/feature/tm-16 change chart type in british columbia employment

This task changes 3 widgets chart types from 'line' to 'bar'
The exception is when the region 'British Columbia' is selected for 'all-years'  (decision made with data and PM)
Test instructions

Go to ANY_REGION/tourism-employment
Select any region other than 'British Columbia' and be sure that the widgets 2, 3 and 4 are grouped bar charts.
Change the region to 'British Columbia' and change the selected years. The widgets should be a line charts ONLY for 'all-years'

Task:
https://vizzuality.atlassian.net/browse/TM-16

@barbara-chaves in https://tota-git-client-featuretm-16-fe-change-chart-59b123-vizzuality1.vercel.app/themes/british-columbia/tourism-employment , the widget 5 is still rendered with vertical bars when all years is enabled, is this expected?

Yes, the widget 5 is not included in the task


"DLsettings" in core/components/handler/handler.go

Due to the definition of DLSettings in package loranwan are changing, so in this handler.go
line:755-757
orignal:
DLSettings: lorawan.DLsettings{
RX1DRoffset: h.Configuration.RX1DROffset,
RX2DataRate: dataRates[h.Configuration.RX2DataRate],
should be changed to:
DLSettings: lorawan.DLSettings{
RX2DataRate: dataRates[h.Configuration.RX2DataRate],
RX1DRoffset: h.Configuration.RX1DROffset,

We are using a vendored revision of the brocaar/lorawan package from before the change, so this is currently not a problem. In the next version of TTN we already use lorawan.DLSettings.


Add functionality to input fields

add functionality to the contact, where, and when input fields. this should add these in a small box containing the party's important information

added functionality to these input fields, they still need to be properly moved to look nice in the image.


Networks for deleted slices don't seem to be cleaned up

On the OpenStack backend there are more networks than active slices.  For example, on the Washington cluster, we have 88 private networks and only 55 slices on the OpenCloud portal.

Fixed.


Consider Adding a Timed Wait Function to the Mutex API (GSFC 22628)

The OSAL does not include a mutex wait with a timeout.  This was originally requested by APL.
See also Trac Ticket #5

Imported from trac issue 46.  Created by sstrege on 2015-05-14T17:52:17, last modified: 2019-08-14T14:11:46

Trac comment by sstrege on 2015-05-14 17:55:34:
This enhancement will be much easier to implement with Trac Ticket #5 updates in place

Trac comment by sstrege on 2015-05-14 17:53:11:
This is used by the APL FSW applications running on the cFE.


Some letters are partially obscured within the padding area of the signup page, and the margin above and below the error is inconsistent.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the "Staging New Expensify" website.
Observe that certain letters are not fully visible due to being within the padding area.
Notice that the margin above and below the error message is not consistent.

Expected Result:
No letters should be hidden within the padding area, and the margin should be consistent.
Actual Result:
Some letters are partially obscured within the padding area, and the margin of the signup page is inconsistent.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.12
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683659309153179
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Some letters are partially obscured within the padding area of the signup page, and the margin above and below the error is inconsistent.
What is the root cause of that problem?

As you can see parent element has max width of 375px and 40px padding, when we subtract padding for child element there is 295px left, but it is set to have max width of 300px. This issue is also present in magic code screen.
There is a margin in wrapper of error message

What changes do you think we should make in order to solve the problem?
We should either set parent to have 380px or child element to be 295px, I think parent should be fixed to match child elements requirements.
Regarding the margin, I think it is intentional as removing margin would also impact button styles, since button and error message have the same wrapper.
https://github.com/Expensify/App/blob/c12f968bccf2d889f0c4431618e03034b81a387c/src/pages/signin/LoginForm.js#L204

One thing we can do about this is that, we can extract error message outside of button and use regular button there, instead of component which contains both error message and button.
Or we can put server message error into input error message

What alternative solutions did you explore? (Optional)

I don't agree that this is unexpected.


Update ADR for topic merging

We have made a few amendments to our roll out plan for the merged
topic system. I've edited the original ADR rather than create a fresh one,
but I've set the status back to proposed pending review.
👉 Rendered ADR
Trello
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Be good to still get @kevindew and @leenagupte  to take a look if they have a chance.

Thanks for the tag @chao-xian. As per the email I just sent Jess I'm still confused as to what we're doing here so I don't really know how to approve at this point.
I've got a few questions I can ask that might help tease information out that'll help me understand.
What actually does merging the mainstream browse and specialist topics mean?
Sub-questions of this are: we currently have mainstream browse pages (e.g https://www.gov.uk/browse/benefits) and topic parent pages (e.g: https://www.gov.uk/topic/benefits-credits). I assume some parent pages become mainstream browse pages what about the others?
As I understand we currently only allow tagging to child topic pages - but currently mainstream browse is based on tagging to a parent. Does that create new rules where you can tag to parent topic pages?
Who can tag to which type of topics and when?
Sub-questions of this: Are there any cases where someone can freely tag to any topic? or will publishers always be having to pick either mainstream browse or the specialist ones?
If say child-benefits is a child of benefits but is a specialist topic, would none of the content show on the mainstream browse?
Be useful to have a list of apps affected and what would change in them
Do they actually need to merge?
It sounds like our main motivation for merging is so that mainstream browse and specialist topics are aware of each other? could it be that there is a semantic link between a specialist topic and a mainstream browse topic that allows us to make the frontend decisions?
It's a bit unclear to me what we've achieved, in terms of frontend user experience changes, by merging. Perhaps it'd be useful to look at what merging is meant to unlock and evaluate if merge is the right way to do that.

Do they actually need to merge?

We are now looking into an MVP to achieve this via mappings for the short-medium term, as the implications of merging is really predicated on what workflow we want to give to users in order to build a coherent IA on the site. We've paused for now actually merging, while the UCD folks think more on what the workflow could like like, and that will help define more precisely what we want the topic tree to look like.

Is there something that explains what you're hoping to achieve from an MVP? What seems unclear is whether what is presented to the user is how the backend needs to look - but I assume your team are very much focused on delivering whta is presented to the user.

Something else I think needs to be clarified, is where is this topic merging going to take place? Are we talking about the tagging interface, the frontend browse pages or both? As this ADR is in collections-publisher, I assumed both.

Thanks for the review and comments Leena and Kevin.
Creating a merged topic tree by importing mainstream browse into specialist topics was a first step in a much longer piece of work, the goals of which are described here

The end game is to have a single navigation system, and a single frontend. But the steps to reaching that point are fluid! I have tried to capture them here
As an overview, stage one was to merge the tree, by creating a new topic for every mainstream browse page. This was the rake task written for that purpose.
Once we had a single tree, there were some decisions to be made around:

Where would tagging to the new tree happen, and by whom. We have liaised with content leadership about this because one idea from the team was to remove tagging from whitehall and only allow tagging in collections publishers. This is great from a content curation pov but bad from a content resource pov.

What would the process be to curate and tidy up the new topic tree? Would we do this programmatically or by a UI in collections publisher.

What actually does merging the mainstream browse and specialist topics mean?

Hopefully the link to the rake task above answers this?

Sub-questions of this are: we currently have mainstream browse pages (e.g https://www.gov.uk/browse/benefits) and topic parent pages (e.g: https://www.gov.uk/topic/benefits-credits). I assume some parent pages become mainstream browse pages what about the others?

There's a level one browse to level one specialist topic mapping in the rake task.

As I understand we currently only allow tagging to child topic pages - but currently mainstream browse is based on tagging to a parent. Does that create new rules where you can tag to parent topic pages?

In the short term after the merge, the plan was that we would not allow any tagging to the new tree, and would make no changes to the tagging workflow for browse and topics. In the longer term, the rules on tagging to the new tree are not decided.

Do they actually need to merge?
It sounds like our main motivation for merging is so that mainstream browse and specialist topics are aware of each other? could it be that there is a semantic link between a specialist topic and a mainstream browse topic that allows us to make the frontend decisions?> It's a bit unclear to me what we've achieved, in terms of frontend user experience changes, by merging. Perhaps it'd be useful to look at what merging is meant to unlock and evaluate if merge is the right way to do that.

Excellent question! One of the main motivations for merging the trees was to surface well maintained specialist topics in browse. We are looking at how we can achieve that without merging the trees ( see topic browse spike) .

I'm setting this ADR as rejected. The problem comes from a lack of clarity at this moment in time around the long term use of the extended specialist topic tree. Specifically who can tag to the tree, in what app, and what happens when it's tagged to.
Navigation-and-presentation is now considering a pivot to archiving specialist topics in their entirety.

Sorry to be a pain - was typing just as you hit merge 😬.
I'm not sure we benefit from merging in a rejected ADR as it doesn't seem a valuable thing to store in the main branch for prosperity. We'll still have access to the work you've done by the presence of this PR.
So my sheepish request would be that we revert it. As an aside the note above looks great that explains the current status 👍

Yeah Leena just pinged me to say the same! I'll need to revert this one, and Kelv's original ADR which has a status of accepted. Will do so presently!

https://github.com/alphagov/collections-publisher/pull/1643


Resulting images are causing 100% cpu on Chrome/Firefox

I just recorded a ~100 kb svg animation with termtosvg.
Showing it in html bumps the Chrome or Firefox CPU usage straight to 100%.
It seems like it's a browser issue but apparently it doesn't always happen either. 😕 Since I know nothing about SVG Animations and browsers I thought posting here might start a discussion –perhaps there's an improvement termtosvg can do (something like reducing draw rate/fps).

Please upload the SVG so that I can take a look at it.

krew_demo.txt
please rename to .svg after downloading. GitHub doesn't allow svg uploads apparently.

Same for me :) 100% CPU on Macos 10.13.1, Chrome version 68.0.3440.106 (Official Build) (64-bit)
migrate-and-upgrade.txt

Can't reproduce on debian/firefox, tested with uploaded animations

tested on macos 10.13.6 with firefox 62.0, can't reproduce with either file.

Good to know, thanks for letting us know.


WIP: Support Streampad, currently sends everything thru to OSC

Thanks for the PR! I'll try to get to it when I have time. Can you tell me more about StreamPad and if it's possible for me to test it locally?


Enable loading of full LAMMPS Chunk Files

This has been completed for a while with the introduction of the multichunk class


Color Picker

Description of the new feature / enhancement
The option to copy the color to RGB produces text that is "rgb(R. G. B)". This is not compatible with the C++ macro in Visual Studio which requires the color to be "RGB(R, G, B)" where the macro name is in capital letters. It would be helpful to be able to choose an output format that is compatible with C++ in Visual Studio.
Scenario when this would be used?
I frequently want to select a colour for a control element based on what is available on my desktop. As Colour Picker is current configured, I am required to change the case of the macro name from "rgb" to "RGB"
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/8305
we are building in custom formats for 0.65 release


ContextualVersionConflict error for pydantic in colab notebook

Dear,
When I go through the colab notebook of "quora questoin answering" in https://github.com/jina-ai/finetuner
I got the version conflict error on the line "import finetuner"
ContextualVersionConflict: (pydantic 2.2.1 (/usr/local/lib/python3.10/dist-packages), Requirement.parse('pydantic~=1.10.11'), {'finetuner-stubs'})
I tried to solve it trying downgrading pydantic to a few older version but did not work.
How can I tackle this?

Hey @malee1382,
Try the following:

Uninstall the current version of the pydantic:
pip uninstall -y pydantic
Install the required version of pydantic:
pip install pydantic==1.10.11

let me know it its work or not :)


Mutator is not fired

I have this in my CRUD controller
$this->crud->addField([
            'name' => 'logo',
            'label' => 'Company Logo',
            'type' => 'upload',
            'upload' => true
        ]);

and this in the model
public function setImageAttribute($value)
    {

        $attribute_name = "image";
        $disk = "uploads";
        $destination_path = "logo";

        $this->uploadFileToDisk($value, $attribute_name, $disk, $destination_path);
    }

When I edit an entry or add one, in the DB, I get something similar to this
/tmp/phppc4Zql
I am not sure the mutator is fired on form submission. Is there possibly anything I am doing wrong?

Hmm... If it places some path in the database it means the mutator is being fired.

Do you have the "upload" disk setup in your config/filesystems.php?

        'uploads' => [
            'driver' => 'local',
            'root' => public_path('uploads'),
        ],

What if you also specify the disk in the field definition, like in the upload field documentation. Does it work then?

[   // Upload
    'name' => 'image',
    'label' => 'Image',
    'type' => 'upload',
    'upload' => true,
    'disk' => 'uploads' // if you store files in the /public folder, please ommit this; if you store them in /storage or S3, please specify it;
],

Your field is called logo not image
Thus
setImageAttribute will not fire, it will be setLogoAttribute

Damn, @OwenMelbz . Twice today my answer was wrong and you came along and stole the show :-) Either you're particularly sharp today or I'm off :-)
Cheers, keep at it! (I still owe you 5 pounds)

i think i have the same issue... i have 5 image fields name as img1, img2, im3 and so on...
i added a mutator setImg5Attribute (i've made tests only on the last image field) with the following data:
$attribute_name = "image";
$disk = "uploads";
$destination_path = "uploads/autoturisme";
but i can't see anything neither in the db neither in the folder /public/uploads/autoturisme

@aureldragut did you include img5 in your fillable property on the model?

That's the first thing i check. There were more mistakes made, one of them being missfilled $attribute_name in the mutator (i left "image" instead of the field name). Now it works smooth, i just have problems with memory (browser crashes when i use bigger images - i may need to reformat my pc, is acting quite strange for a few days)...


Speedment.get should return Optional

There is a risk for confusion with the get()-method in Speedment. It throws an exception if the requested component doesn't exist, which is good, but it should be named getOrThrow() instead. If we are going to have a get()-method, it should return an Optional instead.
This will have to wait until the next big API version.

This is now fixed in develop-modules-branch.


Ctrl + left click(Mouse) is not working.

VSCode Version: 1.5.0
OS Version: Raspbian GNU/Linux 8.0 (jessie)

Steps to Reproduce:
I worte follwoing codes in test.c file
1  #include <stdio.h>
2
3  int test(void) {
4
5    }
6
7    int main (void) {
8     printf("Hello\n");
9     test();
10   int a = 3;
11   return 0;
}

I did  Ctrl + left click(Mouse)  at the 9 line  but the cursor hasn't been moved to the 3 line.
I didn't know why it wasn't moved.
Could you fix this issue?
Thank you.

Do you have the C/C++ extension installed?
Does 'test' change its color and get an underline when you ctrl + hover?

Hi @chrmarti
Thank you for your support.

Do you have the C/C++ extension installed?
Yes, I have. I have installed it.  the version is 0.9.1

Does 'test' change its color and get an underline when you ctrl + hover?
No, the color was not changed when I did ctrl + hover

Thanks

@mong87suk What does the Output panel show in the C/C++ channel?

Hello @chrmarti
Thank you for your supprot.
I didn't know exactly what I have to show you.
I posted the picture which is captured on vs code.

Thank you

You can open the Output panel through the menu View > Output. There used to be a C/C++ channel in its top-right channel switcher, though it doesn't show for me currently, it might have been removed, could you check in your set up?
Another thing to try is to run Go to Definition from the context menu on line 9. Does that position the cursor on line 3?

Hello @chrmarti
Thank you for your support.
I checked the Output panel.  it is as follows.

When I selected C/Cpp Languase Server on OUTPUT,  The error happended.the error message is as follows.
Connection to server is erroring. Shutting down server
I don't know why this error happens.
Dose this error cause that cursor is not moved?
Could you explain it?
I checked the Default Keyboard Shortcuts to find Go to Definition key.
it's F12  so I tried F12 key : 'Go to Definition' but cursor has not been moved.

Thank you

Seems to be a problem with the extension.
@waderyan could you move this issue over to Microsoft/vscode-cpptools (or let me know how to do that myself)?

This issue was moved to Microsoft/vscode-cpptools#320


IbisJavaSender and IbisLocalSender

Describe the issue

[ ] Rename both IbisJavaSender and IbisLocalSender
[ ] Cleanup classes and try to make a common interface
[ ] Describe the difference between the two, in Frank!Doc

Reporter
Core Team

What names for these two?
IbisJavaSender -> JavaServiceSender,
IbisLocalSender -> SubAdapterSender?

As discussed in the Core meeting of 8-7-2024, the new FrankSender will not have an option to call a regular adapter in a separate thread in synchronous mode. If somebody really needs this functionality, we can consider adding this in the future.

I'm thinking:

FrankSender has an option scope with values adapter or JVM. adapter calls another adapter, JVM calls another application in the same JVM. (@nielsm5 you mentioned an option remote but I don't know what that means?).
Calling another application in same JVM uses the DispatcherManager of the current IbisJavaSender. This could happen to be another adapter if that adapter has a JavaListener
Calling another adapter can happen by adapter-name (+configuration-name for adapters in a different configuration). This does not need to go via a JavaListener, I think. The target adapter can be directly invoked (with a new session of course), using method Adapter.processMessageDirect. This would save some overhead, and some confusion regarding the extra session that the JavaListener again creates, and the double layering of returnedSessionKeys that is now both in the JavaListener, and in the caller (IbisJavaSender or IbisLocalSender), and that works slightly differently in each.


Warnings after latest update 0.6.9

After the recent update (0.6.9) i have started getting these warning. My RxJS is at version 5.0.3
WARNING in ./~/rxjs/rx.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:
* /Users/hassan/Code/node_modules/rxjs/Rx.js
    Used by 4 module(s), i. e.
    /Users/hassan/Code/node_modules/@ngtools/webpack/src/index.js!/Users/hassan/Code/src/app/catalog/services/catalog.service.ts
* /Users/hassan/Code/node_modules/rxjs/rx.js
    Used by 1 module(s), i. e.
    /Users/hassan/Code/node_modules/ng2-responsive/config/config.js

Anything i can do to fix it?

jum! Let me see.
Thanks! ; )

Same error for me. I can see require('rxjs/rx') in config.js but I suppose it should be require('rxjs/Rx') ... uppercase... according to the filename you're requiring

BTW - Why dont we import it from rxjs directly rather than rxjs/rs ? I believe rxjs exports are all present in the barrel file.

Bug reported. I fix it this afternoon.
Thanks!!

Fixed on 0.7.1.
Thanks!

Thanks @ManuCutillas ! The warnings went away after the update.


Facing problem installing Java and Tomcat Terraform

Hi,
I am Not able to install Java and Tomcat using terraform code which was explained on 20th september. I was able to create ec2 instance using code but facing the below issue when trying this command Terraform apply. Please help me with this issue.

what is your os?
are you done manual steps before writing terraform file?
share terraform file

Yes i was manually able to install on ec2 instance.
My OS is windows 10.
Please find my terraform files attached
Thank you
On Wed, Sep 25, 2019 at 9:42 PM NareshAbbanapuri<EMAIL_ADDRESS>wrote:

what is your os?
are you done manual steps before writing terraform file?
share terraform file
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/QT-DevOps/DevOpsIssues/issues/611?email_source=notifications&email_token=ANJQRBMDDAU4FQOCPGIPVIDQLQOR7A5CNFSM4I2GYUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UCFYY#issuecomment-535306979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANJQRBOY5PIKMALECEFCW7LQLQOR7ANCNFSM4I2GYUGA
.

Please find my terraform folder attached
openmrs-multiteanant.zip
https://drive.google.com/file/d/1awrFy7oQNhNetoFFoTOHRwWr7JVWWOUE/view?usp=drive_web
On Wed, Sep 25, 2019 at 9:42 PM NareshAbbanapuri<EMAIL_ADDRESS>wrote:

what is your os?
are you done manual steps before writing terraform file?
share terraform file
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/QT-DevOps/DevOpsIssues/issues/611?email_source=notifications&email_token=ANJQRBMDDAU4FQOCPGIPVIDQLQOR7A5CNFSM4I2GYUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UCFYY#issuecomment-535306979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANJQRBOY5PIKMALECEFCW7LQLQOR7ANCNFSM4I2GYUGA
.

I was able to sort out the issue.


Is acs-engine scale available in Azure China Cloud

Is this a request for help?:
Yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
Features Question
What version of acs-engine?:
v0.21.1-Linux

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.9.0
What happened:
acs-engine scale nodes count failed in Azure China.
./acs-engine scale --subscription-id ** \     --resource-group wb-sa-k8s-cluster  --location chinaeast2 \     --deployment-dir _output/wb-kubernetes --new-node-count 3 \     --node-pool agentpool1 --master-FQDN ***.chinaeast2.cloudapp.chinacloudapi.cn \     --azure-env AZURECHINACLOUD
To sign in, use a web browser to open the page https://microsoft.com/deviceloginchina
but
We don't recognize this code, please enter the code again.
What you expected to happen:
login correctly and scale up the nodes
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:
if acs-engine scale is not support in azure china, is there any other way to achieve scaling?

I have successfully solved this.

when early using --auth-method device(by default) i encounter above issue. but when using --auth-method client_secret it works well.
below is my command:
./acs-engine scale --subscription-id 57a67c5e-a***
--azure-env azureChinaCloud
--client-id 54dec1cc-59b2-******************
--client-secret L54wgGowRMttE***********************
--auth-method client_secret
--resource-group wb-sa-k8s-cluster  --location chinaeast2
--deployment-dir _output/wb-kubernetes --new-node-count 3
--node-pool agentpool1 --master-FQDN ******.chinaeast2.cloudapp.chinacloudapi.cn

Close it.


Add go-vendor-tools to sandcastle image

go-vendor-tools is a new tool maintained by the Fedora Go SIG which helps with generating vendor archives and helping vendored Go packages follow the Licensing Guidelines. It is currently only available in Fedora, so we install it with pip.
Relates: https://github.com/packit/packit/discussions/2382

This is a draft until https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6545265745 goes through.

Add go-vendor-tools to the sandcastle container image.

recheck

recheck

Thanks! When do you think the new sandcastle images will show up in prod?

When do you think the new sandcastle images will show up in prod?

Next week on Monday (in the afternoon), but if you want you can already test it on stage: https://packit.dev/docs/configuration#packit_instances


cache ipfs cids

https://github.com/ipfs/ipfs-companion#detect-pages-with-x-ipfs-path-headers
https://docs.ipfs.io/install/ipfs-companion/#toggle-redirects-globally-or-per-site
add to pinning service

added routine to the ipfs link checker


declared variationId bug fix

build

Coverage remained the same at 98.757% when pulling c84d2fab5d661833654717185f94e66130db9152 on crubin/bucketing-fix into fdbb46bd7320e7bc95643da2b8a5c71dd39329da on master.


Number of genes in the ST dataset

Hi, can I run DSTG with only a few dozen genes in my ST dataset? I tried to modify the default number of features in R_utils.R and I could ran convert_data.R, but runnning train.py gave me NA results.

Please first run the demo data. If it works for you, there should be no issues. Also, you can use the output data of demo example to evaluate/compare the output of your own data, maybe some formatting issues.

Thanks for your reply. I have run the demo data and it worked with no issues. I think the problem is that the program uses 2,000 HVGs by default, so there will be some problems when we input fewer than 2,000 genes. I found that in convert_data.R line 17 Convert_Data(synthetic.count,synthetic.label,anova=FALSE) specifies anova=FALSE with the demo data and line 27 Convert_Data(count.list,label.list,anova=TRUE) specifies anova=TRUE for user input data, therefore if we input our own data, it will always run sel.features <- select_feature(st_count[[1]],st_label[[1]]) in line 93 of R_utils.R where the select_feature function has a default number of features as 2,000. Am I making sense? Can we have user input data with <2,000 genes?

default

Yes definitely. You can change the number of selected features by adding argument (nf =2000 or 1000) in line 93.


Muted characters forgotten on logout and login

Issue
Muted characters get forgotten on logout and login.
See discussion on Wolfery Forum:
https://forum.wolfery.com/t/update-muted-characters-forgotten-on-log-out-and-log-in/2534/16

This is a backend bug where playerID was wrongly included in the key-values of the player.mutedChars model.
Closing as it is not a client issue at all..


Sorry but... how do i update yoyo_loader?

with the commits that are coming out for the games to run? or the app is updated automatically when you start it?
Excuse my ignorance... You are a genius, thanks for your work!

It automatically checks for and installs updates each time you start it

Okay. What happens when you start the app, it always stays in the same version. Now I reinstalled and updated! thanks!


bugfix login with client credentials

if I want to use client credentials to login to viya this did not work because the grand_type "password" was hardcoded in the post payload.

Fixed in 0.0.9 with additional customization ability


安装mmcv报错

报错为：
C:\Users\PC\AppData\Local\Temp\pip-install-undsgfsx\mmcv-full_7b94ce8390804870b7adc07a2c6321d9\mmcv\ops\csrc\pytorch\cuda\psamask_cuda.cu(5): fatal error C1083: 无法打开包括文件: “THC/THC.h”: No such file or directory
psamask_cuda.cu
error: command 'C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.3\bin\nvcc.exe' failed with exit code 2
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for mmcv-full
Running setup.py clean for mmcv-full
Failed to build mmcv-full
ERROR: Could not build wheels for mmcv-full, which is required to install pyproject.toml-based projects
环境：
cuda：11.3
torch：1.11.0

请问您的问题解决了吗

You didn't choose a valid torch and cuda version combination, so there are no corresponding prebuilt mmcv wheels. Visit the url in the install command after -f, for example https://download.openmmlab.com/mmcv/dist/cu115/torch1.11.0/index.html, to find out if it's a valid combination. You should see links for prebuilt wheels if it's valid, instead of a NoSuchKey error.


[Bug]: accidental restart and OB2

Version of the software
0.1.21
Operating system
Windows Server 2012
Browser / Native
Firefox Latest.
What happened?
A bug happened!
my rdp server accidentally restarted while OB2 job was running, and now OB2 does not work properly.
here is the error
Relevant LoliCode if needed
Welcome to OpenBullet 2!

----------
DISCLAIMER
----------
Performing attacks on sites you do not own (or you do not have permission to tes
t) is illegal!
The developer will not be held responsible for improper use of this software.

DO NOT CLOSE THIS WINDOW

info: Microsoft.Hosting.Lifetime[0]
      Now listening on: http://<IP_ADDRESS>:15481
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: C:\Users\Administrator\Documents\OpenBullet2
Operations that change non-concurrent collections must have exclusive access. A
concurrent update was performed on this collection and corrupted its state. The
collection's state is no longer correct.

i make new job, after i run it's idle

i'm going to re install OB2,


Make it possible to collapse apps and packages section in the workspace

Feedback received here
The solution design is here.
Description:

50% transparency for the workspaces that are not selected (already presented in the previous designs, but it wasn't implemented)
Collapsable/Expandable sections for apps and packages.

@carinanfonseca @pedro-santos-rodrigues Since new home page experience is being worked on and should be getting merged soon, which will basically display only 1 workspace at a time, do we need to implement the collapsible apps and packages section in workspace now?

No, let's wait to see how it works with the new behavior. We'll get back to this if it is necessary. Thanks for asking, Ankita.

Closing since this doesn't make sense anymore with the new design of the Appsmith home since only one workspace is shown at a time as @ankitakinger had mentioned.


Remote vteps to be populated even when CNIIface is missing

During some recent refactoring, it looks like the code that updates
the remoteVteps is moved under cniIface validation. This PR fixes it.
Signed-Off-by: Sridhar Gaddam<EMAIL_ADDRESS>

Needs manual rebase.

Needs manual rebase.

Done, thanks for reviewing @dfarrell07 @tpantelis


Issue regarding difference between Version 2.5.1 and 2.3.1, version 2.5.1 is not sending stats to elasticsearch with same config

Hi,
I have an elastichsearch server setup in the same network with two different jmeter clients.
One of the clients was using elasticsearch-backend listener-2.3.1 and the other was freshly setup and downloaded 2.5.1 using PluginManager. The 2.3.1 client was running a testplan that was working fine and is able to send sample messages to my elasticsearch server but i've been unable to get it to work with 2.5.1
Is there a fundamental difference or changes in configuration that i may have missed that would result in stats being sent with the older version but not in the new version
Here is how my config looks like and i've been using the same testplan to test this:

I'm basically trying to capture any messages with sample labels that look as follows:
R_/api/test
I've also tried copying the 2.3.1 jar directly to the lib/ext of the jmeter client that was running with 2.5.1 and it suddenly is able to send stats again with the exact same config.
I"m running the docker version 6.5.1 of elasticsearch:
"version": {
"number": "6.5.1",
"build_flavor": "default",
"build_type": "tar",
"build_hash": "8c58350",
"build_date": "2018-11-16T02:22:42.182257Z",
"build_snapshot": false,
"lucene_version": "7.5.0",
"minimum_wire_compatibility_version": "5.6.0",
"minimum_index_compatibility_version": "5.0.0"
}
Thank you for your time

Hi!
I'm currently on vacation but I will get back to you as soon as I can! I find the issue rather strange!
Thanks

Thanks, I can continue to use 2.3.1 for the time being

Still didn't thoroughly looked it up. But I'm curious to see your jmeter console and logs from both clients.
Would that be possible?
Thanks!

Hi,
Here is what i've gathered so far:
I'm using one client and i swapped between the different jars to get the logs, i made sure to delete the elasticsearch index between each try.
For 2.3.1, I can see the index created and messages get populated on my elasticSearch server
2.3.1_INFO.log
2.3.1_DEBUG.log

For 2.5.1, i can see the index created but no messages ever get populated:
2.5.1_INFO.log
2.5.1_DEBUG.log

Hey there,
So I looked at your logs and the one thing that differs from your Jmeter client using 2.5.1 is the following warninrg (which is actually an error):
2018-12-11 11:07:36,685 WARN o.a.j.v.ViewResultsFullVisualizer: Error loading result renderer: org.apache.jmeter.visualizers.RenderInBrowser
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
	at java.lang.Class.forName0(Native Method) ~[?:?]
	at java.lang.Class.forName(Class.java:292) ~[?:?]
	at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.createComboRender(ViewResultsFullVisualizer.java:462) [ApacheJMeter_components.jar:5.0 r1840935]
	at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.createLeftPanel(ViewResultsFullVisualizer.java:430) [ApacheJMeter_components.jar:5.0 r1840935]
	at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init(ViewResultsFullVisualizer.java:342) [ApacheJMeter_components.jar:5.0 r1840935]
	at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.<init>(ViewResultsFullVisualizer.java:147) [ApacheJMeter_components.jar:5.0 r1840935]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:488) ~[?:?]
	at java.lang.Class.newInstance(Class.java:558) [?:?]
	at org.apache.jmeter.gui.GuiPackage.getGuiFromCache(GuiPackage.java:405) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.GuiPackage.getGui(GuiPackage.java:251) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.GuiPackage.getGui(GuiPackage.java:222) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.tree.JMeterTreeModel.addComponent(JMeterTreeModel.java:157) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.tree.JMeterTreeModel.addSubTree(JMeterTreeModel.java:133) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.tree.JMeterTreeModel.addSubTree(JMeterTreeModel.java:125) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.GuiPackage.addSubTree(GuiPackage.java:522) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.action.Load.insertLoadedTree(Load.java:200) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.gui.action.Load.insertLoadedTree(Load.java:236) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.JMeter.startGui(JMeter.java:407) [ApacheJMeter_core.jar:5.0 r1840935]
	at org.apache.jmeter.JMeter.start(JMeter.java:536) [ApacheJMeter_core.jar:5.0 r1840935]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:564) ~[?:?]
	at org.apache.jmeter.NewDriver.main(NewDriver.java:245) [ApacheJMeter.jar:5.0 r1840935]
Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
	at java.net.URLClassLoader.findClass(URLClassLoader.java:466) ~[?:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:563) ~[?:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:496) ~[?:?]
	... 27 more

This doesn't appear in the JMeter client using the 2.3.1 version of the ElasticSearch Backend Listener. That error isn't related to the plugin (first time I actually see it). Therefore, I'm wondering if you have something different in the two JMeter client used (whether it's installed plugin, config change, different versions of your JMX file/test plan).
Thanks,

I saw that error too and I thought it was unrelated to the plugin as well.
But the logs i sent you, I am testing with the same client, all i have done is swapped the jars from jmeter.backendlistener.elasticsearch-2.3.1.jar to jmeter.backendlistener.elasticsearch-2.5.1.jar. They are running the exact same test plan.
This particular client is using jmeter version 5.0 but i've had the same issue with 4.0 as well.
The java version is openjdk version "9.0.4"
OpenJDK Runtime Environment (build 9.0.4+11)
OpenJDK 64-Bit Server VM (build 9.0.4+11, mixed mode)

We had the same issue. It seems the "es.sample.filter" is broken in the newest release. We temporarily fixed it by removing the filter in our jmeter script.

It seems to be an issue with the filter. Try without

Hey everyone!
It's very possible that something changed with the way the functionality works. There has been many code refactoring between the two versions. I most likely introduced some sort of bug by mistake.
I'll take a look at it later tonight.
Thanks for the feedback!

Issue is fixed in version 2.5.2. JAR is downloadable from the release section on this repository. Will soon be available from the JMeter Plugins Manager.
Thanks everyone,


PHI to BTC & PHI to ETH are not available on atomic swap

Suggestion for improvement
PHI to btc and btc to phi and eth to phi and phi to eth on the atomic swap needs to be added

@shendel send me an invoice and let's make these improvements been months no repo se or fixes


Performance issues with Flowbite on Lighthouse

Describe the bug
If you run the website on lighthouse like in our test, where we used the Flowbite website, we really have bad scores.
To Reproduce
Steps to reproduce the behavior:

Go to any pages of flowbite.com
Get the url
Run it on lighthouse from the inspection dev tool of chrome or use google site speed checker
You will see the error in the results

Expected behavior
Those are really simple and small elements that takes a lot of time to load
Screenshots
https://imgur.com/a/1SaNj42
Desktop (please complete the following information):

OS: IOS
Browser: Chrome
Version: 120.0.6099.119 / 12 December 2023

Smartphone (please complete the following information):

Device: iPhone12
OS: iOS17.2.1
Browser: Safari
Version: 17.2

Additional context
We tested directly on the website of Flowbite, and look like performance issues are quite big for elements that are really small, so we don't understand how this is possible.

Hey @aryanshirani,
Thanks for opening up the issue.
I ran a test on Lighthouse: https://pagespeed.web.dev/analysis/https-flowbite-com/rqde219ej7?form_factor=desktop
The Flowbite components and JS are not responsible for the Lighthouse result, our homepage contains a lot of SVG markup and third-party JS plugins (ie. YouTube, Crisp) that block rendering, hence why the pages have a higher loading time.

Of course, we continously try to improve performance for our own website, but currently we're focused on releasing new features and resolving current bugs for the library.
The Lighthouse performance of the homepage doesn't have anything to do with the Flowbite library itself.
Thanks,
Zoltan

Hello,
I'm sorry to see that you did not dig in the screenshot and just ignored the ones I added,
you could see that the test was also runned on basic text pages like this: https://flowbite.com/license/

So there is no other elements than text and in the screenshot we have the details

Hey @aryanshirani,
I've ran the test for this page: https://flowbite.com/license/ (https://pagespeed.web.dev/analysis/https-flowbite-com-license/b3r1ttty12?form_factor=desktop)
I believe that the rendering issue could be to two reasons:

font loading
the antialiased class that is being added for font smoothing

Very strange I really have no clue why we get this issues on google page speed
Aryan Shirani
CEO & Full Stack Designer
at Blurr
+39 377 093 54 29
@.***
www.blurr.it
Via III Novembre 35/1, 38060 Calliano, Trento
On 27 Dec 2023 at 19:06 +0100, Zoltán Szőgyényi @.***>, wrote:

Hey @aryanshirani,
I've ran the test for this page: https://flowbite.com/license/ (https://pagespeed.web.dev/analysis/https-flowbite-com-license/b3r1ttty12?form_factor=desktop)
I believe that the rendering issue could be to two reasons:
• font loading
• the antialiased class that is being added for font smoothing
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Ghosting/banding when Activity's windowBackground is set to @null

I've implemented the AndroidSlidingUpPanel in my activity using the supplied demo code. After closing the panel it leave behind a banding effect. Screenshot attached.
Is this a bug or something I'm doing wrong? Same effect on 2012 Nexus 7 4.3 and Nexus 10 4.4.

@tokudu May I ask which commit/where in the README is this issue mentioned?


Error when you use bindTo method in marker

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[x] Android
[x] iOS

cordova information:  (run $> cordova plugin list)
com.googlemaps.ios 2.5.0 "Google Maps SDK for iOS"
cordova-custom-config 4.0.2 "cordova-custom-config"
cordova-plugin-add-swift-support 1.7.0 "AddSwiftSupport"
cordova-plugin-camera 2.4.1 "Camera"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-device 1.1.7 "Device"
cordova-plugin-file 4.3.3 "File"
cordova-plugin-file-transfer 1.6.3 "File Transfer"
cordova-plugin-fingerprint-aio 1.3.3 "FingerprintAllInOne"
cordova-plugin-geolocation 3.0.0 "Geolocation"
cordova-plugin-globalization 1.0.8 "Globalization"
cordova-plugin-googlemaps 2.2.9 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 1.7.2 "InAppBrowser"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-qrscanner 2.5.0 "QRScanner"
cordova-plugin-splashscreen 4.1.0 "Splashscreen"
cordova-plugin-statusbar 2.3.1-dev "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-sqlite-storage 2.1.2 "Cordova sqlite storage plugin"
ionic-plugin-deeplinks 1.0.15 "Ionic Deeplink Plugin"
ionic-plugin-keyboard 2.2.1 "Keyboard"

Current behavior:
When I try to add a circle to the marker using bindto, following the example of the documentation, I get this error:
ReferenceError: value is not defined
    at Marker.bindTo (BaseClass.js:46)
    at callInstance (plugin.js:212)
    at Marker.<anonymous> (plugin.js:288)
    at Marker.value [as bindTo] (decorators.js:152)
    at MapComponent.<anonymous> (map.ts:473)
    at step (main.js:9575)
    at Object.next (main.js:9556)
    at fulfilled (main.js:9547)
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (core.js:4753)

My code is this:
const marker = await this.map.addMarker({
    position: { lat: position.lat, lng: position.lng },
    disableAutoPan: false,
    zIndex: 100,
    icon: {
        url: value.realTime ? 'assets/img/marker-red.png': 'assets/img/marker.png',
        size: {
            width: 32,
            height: 42
        }
    },
});

const circle = await this.map.addCircle({
    center: marker.getPosition(),
    radius: 10,
    fillColor: "rgba(0, 0, 255, 0.5)",
    strokeColor: "rgba(0, 0, 255, 0.75)",
    strokeWidth: 1
});

marker.bindTo('position', circle, 'center');

Expected behavior:
A circle should appear along with the marker and keep the same position

Make sure the variable marker is not undefined

It is not undefined.
The error is in the bindto method of the BaseClass class:
`
bindTo: function(key, target, targetKey, noNotify) {
targetKey = targetKey || key;
// If `noNotify` is true, prevent `(targetKey)_changed` event occurrs,
// when bind the value for the first time only.
// (Same behaviour as Google Maps JavaScript v3)
target.set(targetKey, value, noNotify);   <---- Value is not defined

this.on(key + '_changed', function(oldValue, value) {
  target.set(targetKey, value);
});

},
`

Please share your project files on GitHub

ping

Hi, here is a repo with that problem. I hope you can reproduce it. Thank you.
https://github.com/sergiomedinavalentin/demoApp

Ok, don´t worry

Ok, what's the problem?

ping

In my case, when I run the application I get this error

Unfortunately I can't reproduce your issue.

I think you use old version of @ionic-native/core and @ionic-native/google-maps.
Please reinstall the latest versions.
Since this is not this plugin's bug, no further support is available.

That's not the problem...
"dependencies": {     "@angular/animations": "5.2.10",     "@angular/common": "5.2.10",     "@angular/compiler": "5.2.10",     "@angular/compiler-cli": "5.2.10",     "@angular/core": "5.2.10",     "@angular/forms": "5.2.10",     "@angular/http": "5.2.10",     "@angular/platform-browser": "5.2.10",     "@angular/platform-browser-dynamic": "5.2.10",     "@ionic-native/core": "^4.7.0",     "@ionic-native/google-maps": "^4.7.0",     "@ionic-native/splash-screen": "4.7.0",     "@ionic-native/status-bar": "4.7.0",     "@ionic/storage": "2.1.3",     "cordova-android": "6.4.0",     "cordova-plugin-device": "^2.0.2",     "cordova-plugin-googlemaps": "^2.2.9",     "cordova-plugin-ionic-keyboard": "^2.0.5",     "cordova-plugin-ionic-webview": "^1.2.0",     "cordova-plugin-splashscreen": "^5.0.2",     "cordova-plugin-whitelist": "^1.3.3",     "ionic-angular": "3.9.2",     "ionicons": "3.0.0",     "rxjs": "5.5.10",     "sw-toolbox": "3.6.0",     "zone.js": "0.8.26"   }
I have installed the latest version and the error continues

Um, try the multiple_maps branch version.
$> cordova plugin rm cordova-plugin-googlemaps

$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps --variable ...

It does not work, it does not even add the marker. I get the error map_0_322601553499 No value for url`

Please share your actual project files on GitHub. Otherwise, no further help you.

I said Please share your **actual project files** on GitHub., not demo app.
Time is money. I don't waste my private time for you. You should contribute me as much as possible.
You don't agree? Please debug the issue by yourself.

In the repo demoApp the same error occurs as in my private project, I do not hide information. I do not pretend that you spend your time on me, just that you help me solve an error that other users may have...

$ cordova plugin list
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-googlemaps 2.3.0-beta-201800508-1411 "cordova-plugin-googlemaps"   <-- need to update
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.0 "cordova-plugin-ionic-webview"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"

cordova plugin list cordova-plugin-device 2.0.2 "Device" cordova-plugin-googlemaps 2.3.0-beta-201800507-1814 "cordova-plugin-googlemaps" cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard" cordova-plugin-ionic-webview 1.2.0 "cordova-plugin-ionic-webview" cordova-plugin-splashscreen 5.0.2 "Splashscreen" cordova-plugin-statusbar 2.4.2 "StatusBar" cordova-plugin-whitelist 1.3.3 "Whitelist"

Sony Xperia Z3 with Android 6.0.1 and Nexus 4 with Android 5.1.1. The same with Android Emulator.
As you can see, the bookmark does not appear. You get the error that I told you, map_0_875287964653 No value for url

Read my response!
cordova-plugin-googlemaps 2.3.0-beta-201800508-1411 "cordova-plugin-googlemaps"   <-- need to update


Update CalmoSoftFifteenPuzzleGame.ring

Please accept it.

Thanks for the update
Keep up the good work!
Note : Instead of using the constant : 1000
You can use : ClocksPerSecond() : http://ring-lang.sourceforge.net/doc1.4.1/dateandtime.html#clockspersecond-function
Because the value maybe changed between systems.

Hello Mahmoud,
Thanks for your kind words.
Greetings,
Gal Zsolt
(~ CalmoSoft ~)

You are welcome :D


Rewrite to bubble tea and charm on the dev branch

[!IMPORTANT]
dev branch contains the rewrite untill it's finished
when the rewrite is tested and finished the changes are going to be pushed into main

main.go migrated

-currency_converter.go done (styling needs a touchup still)


Nesting Component Selectors inside of functions

I have a question about component selector usage.
My styled components are defining some blocks based on a prop passed to the component, like so:
const Label = styled.label`
  // some styles
  ${props => props.disabled && `
    // disabled-specific styles
  `}
`;

I tried to nest a reference to another component inside of this block, using the component selector pattern. However, it seems that the reference to the component is not run within this block:
const Checkbox = styled.input``;

const Label = styled.label`
  // some styles
  ${props => props.disabled && `
    &:hover {
      ${Checkbox} {
        // hover effect for disabled checkbox
      }
    }
  `}
`;

Does it makes sense that the component selector should work inside of a block like this? Or would it be better to restructure my styled component in a different way? I like the idea of having blocks of css that only get included based on checks on props, like in the example. It feels clean, but I'm very open to suggestions.

Yes that should work. One thing about your code sample that jumped out at
me is I use the css`` helper for that kind of dynamic block vs a basic
template literal. Might be needed for special interpolations to work.
On Fri, May 18, 2018 at 6:37 AM Mark E. Carter<EMAIL_ADDRESS>wrote:

I have a question about component selector usage.
My styled components are defining some blocks based on a prop passed to
the component, like so:
const Label = styled.label  // some styles   ${props => props.disabled &&
// disabled-specific styles
} ;
I tried to nest a reference to another component inside of this block,
using the component selector pattern. However, it seems that the reference
to the component is not run within this block:
const Checkbox = styled.input``;
const Label = styled.label  // some styles   ${props => props.disabled &&
&:hover {
${Checkbox} {
// hover effect for disabled checkbox
}
}
} ;
Does it makes sense that the component selector should work inside of a
block like this? Or would it be better to restructure my styled component
in a different way? I like the idea of having blocks of css that only get
included based on checks on props, like in the example. It feels clean,
but I'm very open to suggestions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1743, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiy1pcbMBAMI6rOrm3YMImwX2UmaWq0ks5tzqRfgaJpZM4UEgp8
.

Hey, that worked. Thanks for the help!


Cannot create control of type Microsoft.PowerToys.Setting.UI.Views.ShellPage

Microsoft PowerToys version
0.47.1
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
PowerToysReport_2021-10-22-10-20-27.zip
✔ Expected Behavior
No response
❌ Actual Behavior
PowerToys does not work

.
Other Software
No response

Windows Update KB5007215 or KB5007885 solved the issue.


add 2 new attacks, half fill and skip bottle

Hi,
I was doing some research about ICS security and found your work on a popular french blog (korben.info).
Wanted to see how it works and wrote two attacks to test it.
Skip bottle is used to fill only 1 bottle out of 2 (or more if the parameter is changed)
Half fill calculate the time to fill a bottle and cut it to the half for the next bottles (my time calculation may have some issue)
I hope you will keep developing this project and wish you good luck for 4SICS
Regards,
PokeTheCity

Hi @PokeTheCity, thanks for your contribution.
I'll check out the code soon and get the PR in asap, been a little busy
this week!
Glad to know the project has reached France! Such a nice country
I'll surely keep working on virtuaplant to add new plant scenarios and
improve the code.
Thanks for your kind words and I'll do my best to present a nice talk at
4SICS.
Regards
On Thu, Jun 4, 2015 at 5:59 PM, PokeTheCiTy<EMAIL_ADDRESS>wrote:

Hi,
I was doing some research about ICS security and found your work on a
popular french blog (korben.info).
Wanted to see how it works and wrote two attacks to test it.
Skip bottle is used to fill only 1 bottle out of 2 (or more if the
parameter is changed)
Half fill calculate the time to fill a bottle and cut it to the half for
the next bottles (my time calculation may have some issue)
I hope you will keep developing this project and wish you good luck for
4SICS
Regards,
PokeTheCity
You can view, comment on, or merge this pull request online at:
https://github.com/jseidl/virtuaplant/pull/2
Commit Summary

add 2 new attacks, half fill and skip bottle

File Changes

A plants/bottle-filling/attacks/half_fill.py
https://github.com/jseidl/virtuaplant/pull/2/files#diff-0 (56)
A plants/bottle-filling/attacks/skip_bottle.py
https://github.com/jseidl/virtuaplant/pull/2/files#diff-1 (35)

Patch Links:

https://github.com/jseidl/virtuaplant/pull/2.patch
https://github.com/jseidl/virtuaplant/pull/2.diff

—
Reply to this email directly or view it on GitHub
https://github.com/jseidl/virtuaplant/pull/2.


wip: gRPC server and gRPC outputs service

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
This PR adds a gRPC server to falco in its own thread.
Implementors can use it to create and extend the falco API.
The only implemented call by this PR is the subscribe call that can be used to subscribe to falco output events directly.
The code this PR contains refers to the initial proposal but implements a streaming server rather than a bidirectional client/server paradigm.
Which issue(s) this PR fixes:

Original proposal: #789
Fixes #528
Fixes #791
Refs to #818 (umbrella issue for various related topics)

Special notes for your reviewer:
This PR is still in WIP. Me and @fntlnz are still working on it.
/assign @leodido
/assign @fntlnz
Work we still need to do:

[x] Implement abstract structure to handle various kind of gRPC services
[x] Implement streaming service - ie., subscribe
[x] Get the outputs through handle_event in falco_outputs.cpp
[x] Separate the sending of events from the sending of messages in Lua too
[x] Proto definitions
[x] Mutual TLS authentication
[x] Make it work for k8s_audit
[x] Source is not showed in the outputs, investigate why
[ ] Catch gRPC status and logs (?) (for example when input certificates are wrong it segfaults, handle it)
[x] Make sure all the threads have their cleaning logic (signal handlers etc..)
[x] Make all the parameters configurable

[x] certificates (private key, root cert etc.)
[x] the grpc server

[x] enable
[x] threadiness
[x] bind address + bind port

[x] the grpc output itself

[x] Do some name and file refactoring, right now everything is in grpc_server.cpp and grpc_server.h, we can do better
[x] Go SDK

[x] Write the Go library
[x] Usage examples

Next items for which we need to open issues:

[ ] Unit tests
[ ] Documentation

[ ] Falco gRPC server configuration and usage
[ ] Falco gRPC outputs configuration and usage
[ ] gRPC API documentation
[ ] How to generate the certificates for mutual TLS
[ ] SDK examples

Some notes about this implementation:

We feel like it is not PoC quality even if it's a PoC, needs some refactoring but overall we think the design is solid enough. It's even thread safe thanks to TBB;
When multiple clients Subscribe to the outputs, messages are dispatched in a  Round Robin  fashion. Single queue, multiple consumers - We can have other strategies here, like a queue for every consumer (fanout) or even more sophisticated things. This first approach seems good enough now, all future approaches will be "configurable" so, we are open to different strategies but this is the default one for now

Does this PR introduce a user-facing change?:
Falco gRPC api server implementation, contains a subscribe method to subscribe to outputs from any gRPC capable language

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I've several concerns about that gRPC output :

A simple queue with several consumers (messages are distributed in RRD mod for avoiding duplicates) is great. Even it's this queue is used, we still need a queue which gathers all messages, we talked about idea of falcoctl that can consumes events by gRPC, it needs to get all messages, not 1 over N.
On a k8s cluster, we have several falco instances, and they can come/go with node creations/deletions. How our consumers can be aware of new falcos to be able to connect asap?
We can think about a "sidecard container" (falcosidekick for ex.), running in same POD than falco and make it connecting internally on loopback. It should work, we only need to accept to have several containers more. It's only possible with internal consumers of course.
We could also imagine a mechanism where all falcos are declaring to each others (a kind of cluster). When a consumer is connected to a falco gRPC, it retrieves list of other instances (and updates after).  Broadcast/multicast are often unavailable, we might need a registration somewhere (etcd, consul, etc).

I've several concerns about that gRPC output :

A simple queue with several consumers (messages are distributed in RRD mod for avoiding duplicates) is great. Even it's this queue is used, we still need a queue which gathers all messages, we talked about idea of falcoctl that can consumes events by gRPC, it needs to get all messages, not 1 over N.
On a k8s cluster, we have several falco instances, and they can come/go with node creations/deletions. How our consumers can be aware of new falcos to be able to connect asap?
We can think about a "sidecard container" (falcosidekick for ex.), running in same POD than falco and make it connecting internally on loopback. It should work, we only need to accept to have several containers more. It's only possible with internal consumers of course.
We could also imagine a mechanism where all falcos are declaring to each others (a kind of cluster). When a consumer is connected to a falco gRPC, it retrieves list of other instances (and updates after).  Broadcast/multicast are often unavailable, we might need a registration somewhere (etcd, consul, etc).

I think we want to let this PR through and assign the Go SDK to me? Can we push our existing Go code through a new repo like #811?

@Issif I think all your concerns are all resolved because:

The single queue mechanism is the "Round robin" (shared queue between consumers) mechanism, this feature is still ongoing, as we wrote in the notes, we need an alternative implementation that does Fan-out (one queue per consumer).
That is a client side mechanism that must be implemented in the SDKs, not a concern for this implementation, it's how client server works. See also point 4 of this list, with that mechanism we can avoid that problem by simply not connecting directly to the single falco instance.
That can be done as a different proposal, here we are implementing the server, this conversation must be 100% on that, while I agree with the intent I want to keep this very light and focused on what we are doing, so if you have an idea I would be happy to read it in a proposal and review a PoC of it. Please do it! :grinning:
On an API point of view (not just outputs), we are filling a proposal to do a gRPC server that can aggregate all the Falco instances APIs so that we can call actions on multiple servers using a thing like the falcoctl without connecting to all of them. IMHO Falco instances don't need and don't want (it's a security software) to talk each other, also this is not a primary-secondary architecture. Here is the issue we opened to fill the proposal #824

@fntlnz you made my day (at least my morning 😉 ). A big 👍 for the whole.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

With the commits pushed today we are really near to the completion of a first minimum viable gRPC server for falco outputs.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

11174f5 new(userspace/falco): store context metadata for future usage

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

11174f5 new(userspace/falco): store context metadata for future usage

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

11174f5 new(userspace/falco): store context metadata for future usage

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

11174f5 new(userspace/falco): store context metadata for future usage

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/check-dco

@leodido I'm not sure this fixes #791 - I'm keeping sending SIGTERM and it logs SIGINT. Need to re-check this.

This does not work with k8s_audit yet, making it happen!

This is the script we are using right now to generate the MTLS certificates.
This will need to be included in the documentation and optionally we can make a falcoctl command to generate those.
#!/bin/bash

# Generate valid CA
openssl genrsa -passout pass:1234 -des3 -out ca.key 4096
openssl req -passin pass:1234 -new -x509 -days 365 -key ca.key -out ca.crt -subj  "/C=SP/ST=Italy/L=Ornavasso/O=Test/OU=Test/CN=Root CA"

# Generate valid Server Key/Cert
openssl genrsa -passout pass:1234 -des3 -out server.key 4096
openssl req -passin pass:1234 -new -key server.key -out server.csr -subj  "/C=SP/ST=Italy/L=Ornavasso/O=Test/OU=Server/CN=localhost"
openssl x509 -req -passin pass:1234 -days 365 -in server.csr -CA ca.crt -CAkey ca.key -set_serial 01 -out server.crt

# Remove passphrase from the Server Key
openssl rsa -passin pass:1234 -in server.key -out server.key

# Generate valid Client Key/Cert
openssl genrsa -passout pass:1234 -des3 -out client.key 4096
openssl req -passin pass:1234 -new -key client.key -out client.csr -subj  "/C=SP/ST=Italy/L=Ornavasso/O=Test/OU=Client/CN=localhost"
openssl x509 -passin pass:1234 -req -days 365 -in client.csr -CA ca.crt -CAkey ca.key -set_serial 01 -out client.crt

# Remove passphrase from Client Key
openssl rsa -passin pass:1234 -in client.key -out client.key

Ok this is almost ready, the only blocker we have right now is that falco_formats::resolve_tokens does not work for k8s_audit events when called by lua in mod.grpc. Investigating that.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kris-nova
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kris-nova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b65dd37258861f69dcd7b96211343001035f6663

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ok after today's changes this PR is ready! :tada: I'm opening issues and an umbrella issue for the remaining work we need to do for documentation and tooling

/lgtm

LGTM label has been added.  Git tree hash: 164a044d622252dea4a23e53b692f93c8c99912a

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kris-nova
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kris-nova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kris-nova, mfdii
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kris-nova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@mstemm I agree that this is lacking tests, at the planning meetings we agreed to do them in a subsequent iteration over this code to let everyone start integrating with this as soon as possible while we work. It's in the "Next action items" section in the PR description

LGTM label has been added.  Git tree hash: ab296d4bb2d66cff5c0bc7f4eb4680e06b600c46

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, kris-nova, mfdii
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,kris-nova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix(engines): remove fs-extra usage in cache.ts

Closes: #2597

:tada: This PR is included in version 7.61.2 :tada:
The release is available on:

v7.61.2
GitHub release

Your semantic-release bot :package::rocket:


Feat: description optional

Closes Issue #333
Description
User can now add task without actually providing any description
Applied Changes

Edited index.js to allow empty description
Edited functions in index.js to allow user to make empty description task with description and task with description empty on editing a pre-existing task

Type of change

added new feature under IWOC 2.0 @ 2024

Video Demo
https://github.com/Kritika30032002/To-Do-List-Application/assets/86418216/70c52548-0df9-4dba-be54-f080943a4775

Hi @Kritika30032002 could you kindly assign me this PR, as it seems that my contribution for this PR is not getting reflected on my dashboard as this PR has no assignees.