LastPass: SSO support

Investigate a possibility of adding the SSO login method to LastPass

Sorry for bringing this up so late.
I needed this last year, and being completely unaware of this new repository I forked your lastpass-sharp repository and added it. Because I did it for work, due to some miscommunication I didn't get approval to make my changes public and PR them until January, at which point I was very busy and didn't remember to make the PR until today. And then I discovered you had this repository which supersedes that one. The patch I developed follows below. (let me know if you want a PR for it to the original repo or not.)
The change is extremely simple, it literally just involves accepting 1 additional parameter then passing it to the server. All of the work to get that extra parameter differs based on the SSO provider. For example, I used the SSO fork of the lastpass CLI as a reference, and the developer of that fork had his own repository which had an implementation of Okta SSO. Unfortunately, I needed to login via Microsoft Azure ADFS SSO, so I had to do a little bit of my own reverse engineering to figure out how to generate the password and SSO fragment for that. There's not really a one size fits all solution.
lastpasssharp_sso.txt
My implementation to handle Azure SSO has no company specific logic in it, so I can open source that as we'll, but it won't work for Okta or anything else. I will link the repo if you're interested.
How would you like me to proceed knowing this information? Do you just want to add the additional parameter to this library and I can confirm if it works or not? Should I fork this one and try to make the changes again with a PR when I have time? Or is your intent to try and support all SSO variants, somehow replicating the logic inside the browser plug-in? I believe it only had a few different providers that it supported.

Hi. Thanks for your interest in this project. I understand I should have linked this repo from all the old not supported anymore libraries. Wanted, wanted, but never got to do that.
As far as the SSO support goes, I don't really understand it yet, what it is, what it does and how it works. I got a request from one user of this library and I added this ticket not to forget about it.
The things that I do know, I don't want to add any UI to this library. When I have to launch a browser I outsource it to the app by a way of providing some interface the app can implement. At this moment though, I'm thinking of refactoring the library to provide an async API with async two-way communication between the library and the application. This will allow the users to structure the code and implement the UI on the client side easier and more conveniently. Before I add this, I would like to avoid adding any new user interaction related interfaces.
Summing all of the above, given the fact that I don't really understand SSO yet, I would consider adding the parameter if it enables some new features for this library and if it's realistic for the users to implement the necessary part on their end and add to their app and just pass it down to the library.

I agree that it doesn't make sense for you add a UI to the library. This is why in the patch I linked above the only change involves the "SSO Fragment" variable that the caller would be responsible for passing in. When I used the SSO fragment with lastpass-sharp, I made a separate library for the UI portion of it.
I'll just explain SSO in case it helps.
SSO is an abbreviation for Single Sign On. It allows a user to sign into one account and use that account for other apps or websites that would normally require separate accounts. In the case of Azure Active Directory (Azure AD), this is used by many large companies who have Microsoft servers for user accounts and email. When a Windows machine is set up for corporate domain sign-in, a user logging into their Windows machine automatically gets authenticated on their PC and that user no longer needs to login again with their username & password for apps that support SSO. This is only possible between companies / organizations that have set up support for it behind the scenes - both the product being logged into and the user's organization's servers will do the communication behind the scenes to validate who the user is.
In the case of LastPass, SSO is only available for organizations that have purchased enterprise licenses for their users and the admin for that organization has configured their servers & LastPass to trust each other behind the scenes.
Microsoft ADFS is only one form of SSO. Technically websites with buttons like "Sign in with Facebook" or "Sign in with your Google Account" are also considered SSO since you're using one set of credentials to login, but it's not as nice as being able to log into a Windows machine and not have to enter credentials again to use LastPass.
--
Back to the topic of LastPass again - the way SSO works for employees at a company is as follows:

Employee opens the browser plug-in, and if this is the first time using it they enter their work email into the username field.
LastPass's server looks at the domain name of the email address and if it's a domain for a company with SSO support the browser plug-in makes a call to the user's company's server to authenticate them. There is some communication behind the scenes between LastPass and the Company server as well.
If the employee is authenticated successfully, the company server provides a secret key and the LastPass plug-in is redirected back to LastPass's server which provides an additional secret key and a fragment.
Some math is performed on the secret keys from the company server and the LastPass server and together the two keys are used to calculate a 'password' which will be used as the password for LastPass. That calculated password along with the SSO fragment from the login call is passed to the original LastPass login process and everything works as normal from there on.

In other words, SSO users, even though they are never prompted for a password, LastPass has a secret password calculated for those users behind the scenes. If someone wants to use your library with SSO they will need their own means of getting the password and SSO fragment values because how those values are obtained behind the scenes will be different depending on the login provider used. Many SSO providers also have MFA, so even if the user does not need to enter their password again they might need to approve the login or enter a code.
I hope this made sense.

Yes, I can try to test it.
The patch I provided for the old library worked for me, so I have no reason to doubt the same approach should work here.

Anything ever come from this?  Looking to use the lastpass cli but not able to due to Azure SSO.

@ayprof This has not been worked on.
This is an open source project. Pull requests are welcome.

The stuff I posted earlier in the thread was still working at the time I posted it. But my employer switched away from LastPass after LastPass had multiple security breaches last year, so I can no longer test if someone wanted to try and incorporate those changes.
The information should still be useful though. Good luck if anyone wants to try and use it.


[SALEOR-2992 Click & Collect]

I want to merge this change because...

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

Task linked: SALEOR-2992 Click&Collect


Update evidence accuracy error handling

When the user submitted the evidence/accuracy page without
checking either checkbox, the boxes were highlighted in red,
but no error was shown.

This has added an error message to the view and set the text in the
locale file.

:+1: all good, merge!


Allow reportdirectory to be a path

Fixes issue #3, reported by BBhacKing.

Great work Cameron. Thank you.


Populate auto QC scores in dashboard

populate auto QC scores
allow score filtering over a range instead of just equality
put FILTER in its own line

Hi Spero, I requested you review for awareness only. This work is mostly done. We can merge this to master branch in a week or two. And then we can deploy the master branch from VM. Currently, the VM is running auto-qc-score-2 branch.


Drafting email for participants

Things to bring

utensils, mugs, etc
Computer, power cord, ethernet cable, etc

Things to install

Basic things like Slack, Git, Python, etc
Check with your team leader

Info

Travel, lodging

I have put together a draft for email to send to the participants and team leaders.
I plan to send it out on Saturday (1 week before hackseq), so let me know if there is anything that I have missed before then.

Need to mention

downloading slack on the phone since that's the main mean of communication
workshops (esp since the Git workshop requires some preparation)
Do they need to buy any ticket for the social?

Thanks @santina - I see you have made the changes:-)
I don't think we are selling tickets for the socials anymore. @adrisua @minisciencegirl - is this correct?

We are not selling tickets for the social. But here is the event detail:

October 15, Saturday, 6pm - Join us for a fun evening to meet fellow hackseq participants at the Pit Pub!

October 17, Monday, 5pm - Amazon AWS sponsored community/ hackseq event at the Gallery! Come meet the Vancouver hacking/ tech/ genomics community!

Thanks @minisciencegirl - I have made these changes. I just took out "Vancouver" because there are so many participants from all over the world that will be attending.
If no-one else has any suggestions, I will send out the email tomorrow.

@Brittdrog: Thank you!
@santina: Here is the eventbrite url for Monday's event if you would like to include this in your email to participants!
https://www.eventbrite.ca/e/hackseq-2016-social-tickets-28463797986

I see @Brittdrog included it. Thanks! I think it looks good. If there's no other comment from the rest of the team, we can send it off tomorrow.

@brunogrande - do you have a list of the emails for everyone who is attending hackseq? If you do, could you send out the email to this list?

@Brittdrog: I'm working on this.

@Brittdrog: You refer to an "attached map". What did you have in mind?

@brunogrande - no worries....if you don't have a list already, I can do it.
I have a map that I made showing where the entrance is.
I will send out the email tomorrow

I already compiled a list of emails. The email draft exists in the Hackseq Gmail account, and it already addresses all participants and team leaders. You can simply add the map and send it off! 😊

@brunogrande - awesome! That was super efficient. I have attached the map, but am going to wait until tomorrow to send it out (as Saturday night is probably not the best time to receive emails).

Sent.


Use custom dictionaries

It would be nice if the API provided a way of loading a custom dictionary without resorting to patching the data in the module. In some languages, the lemmatizer coverage can be rather poor, and other languages are not supported at all. If this is welcome and we can agree on what the API should look like, I can implement this and make a PR. My idea would be passing a dict argument to the simplemma.lemmatize, or a global state that stores which extra dicts to use in each language and a few functions to manipulate it.

I prefer working towards releasing a version 1 and see from there, that includes documentating how the sources are compiled, I'm working on it.
The API is not completely stable right now as a few things are still broken after an intensive refactoring. I'd suggest you wait with your PR until things have stabilized a bit. Using the new classes to load external dictionaries seems like a good approach.

@1over137 You can start working on a PR if you want, the API for dictionary lookup strategy is stable. I also added info in the training readme on additional dictionaries.

Hi guys,
Such API is already there.
You just need to implemente the DictionaryFactory protocol and use it to load your custom dictionaries.

@1over137 Did that solve your problem or do we need to work on the documentation?

Closing as this was answered. Feel free to reopen if there are more questions.


[CI] Remove concurrency

Description

Resolves # (issue)
How Has This Been Tested?

Due Dilligence

[ ] Breaking change
[ ] Requires a documentation update


"Run cell" appears to launch Jupyter but hangs on "executing cell" - progress wheel just spins

see next post

Environment data

VS Code version: 1.27.0
Extension version (available under the Extensions sidebar): 2018.10.1
OS and version: debian - stretch
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): debian/crostini on chromebook

> rodhholland@penguin:~$ python3.7 -m jupyter notebook --version
> 5.7.0
> rodhholland@penguin:~$ python3.7 -m jupyter --version
> 4.4.0
> rodhholland@penguin:~$
> >

Actual behavior

status bar reports that jupyter notebook was loaded and the cell is executing but interactive window never opens and executing wheel just spins.  Reported error is "isDirectory not found" - see console output below.

jupyter notebook opens in browser with the following command line
python3.6 -m jupyter notebook --ip=<IP_ADDRESS>

Expected behavior

interactive pane opens and evaluated cell output is injected into pane

Steps to reproduce:

open a simple test program with a cell and click on "run cell".  confirm program runs fine if run outside of jupyter.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

blank

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

workbench.main.js:1402  INFO no standard startup: not the explorer viewlet
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Create file systemwatcher with pattern */python (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Create file systemwatcher with pattern */*/python (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Create file systemwatcher with pattern */python (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Create file systemwatcher with pattern */*/python (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Notify locators are locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Register Intepreter Watcher, Arg 1: {"$mid":1,"fsPath":"/home/rodhholland","external":"file:///home/rodhholland","path":"/home/rodhholland","scheme":"file"}, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Register Intepreter Watcher, Arg 1: undefined, Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Build the workspace interpreter watcher, Arg 1: {"$mid":1,"fsPath":"/home/rodhholland","external":"file:///home/rodhholland","path":"/home/rodhholland","scheme":"file"}, Return Value: UNABLE TO DETERMINE VALUE (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Build the workspace interpreter watcher, Arg 1: undefined, Return Value: UNABLE TO DETERMINE VALUE (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: All locators have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:  (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:3135 Extension Host
workbench.main.js:3135 [1115/161111.451933:ERROR:archive.cc(170)] Failed to parse header size from /usr/share/code-oss/resources/app/extensions/css-language-features/server/test/pathCompletionFixtures/src/data/foo.asar

workbench.main.js:3245 [ms-python.python]Cannot read property 'isDirectory' of undefined
e.$onExtensionRuntimeError @ workbench.main.js:3245
e._doInvokeHandler @ workbench.main.js:3222
e._invokeHandler @ workbench.main.js:3222
e._receiveRequest @ workbench.main.js:3221
e._receiveOneMessage @ workbench.main.js:3221
(anonymous) @ workbench.main.js:3220
(anonymous) @ workbench.main.js:3223
e.fire @ workbench.main.js:175
a @ workbench.main.js:310
n._socketDataListener @ workbench.main.js:310
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594
workbench.main.js:3245 TypeError: Cannot read property 'isDirectory' of undefined
	at /home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/node_modules/file-matcher/lib/filematcher.js:274:23
	at ELECTRON_ASAR.js:159:7
	at _combinedTickCallback (internal/process/next_tick.js:131:7)
	at process._tickCallback (internal/process/next_tick.js:180:9)
e.$onExtensionRuntimeError @ workbench.main.js:3245
e._doInvokeHandler @ workbench.main.js:3222
e._invokeHandler @ workbench.main.js:3222
e._receiveRequest @ workbench.main.js:3221
e._receiveOneMessage @ workbench.main.js:3221
(anonymous) @ workbench.main.js:3220
(anonymous) @ workbench.main.js:3223
e.fire @ workbench.main.js:175
a @ workbench.main.js:310
n._socketDataListener @ workbench.main.js:310
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:15.266 NotebookApp] The port 8888 is already in use, trying another port.
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:15.267 NotebookApp] The port 8889 is already in use, trying another port.
[I 16:11:15.269 NotebookApp] The port 8890 is already in use, trying another port.
[I 16:11:15.270 NotebookApp] The port 8891 is already in use, trying another port.
[I 16:11:15.271 NotebookApp] The port 8892 is already in use, trying another port.
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:15.308 NotebookApp] Serving notebooks from local directory: /tmp
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:15.308 NotebookApp] The Jupyter Notebook is running at:
[I 16:11:15.308 NotebookApp] http://localhost:8797/?token=439854c8146a79b87ec6517f4958d6d2fb40ef639e5bbec9
[I 16:11:15.309 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 16:11:15.310 NotebookApp]

    Copy/paste this URL into your browser when you connect for the first time,
    to login with a token:
        http://localhost:8797/?token=439854c8146a79b87ec6517f4958d6d2fb40ef639e5bbec9
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:16.134 NotebookApp] Kernel started: 876715ed-d3af-4ae6-8c76-71a6609933c0
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Starting WebSocket: ws://localhost:8797/api/kernels/876715ed-d3af-4ae6-8c76-71a6609933c0 (at DefaultKernel._createSocket (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/node_modules/@jupyterlab/services/lib/kernel/default.js:61:21))
workbench.main.js:276 [Extension Host] Python Extension: [I 16:11:18.400 NotebookApp] Adapting to protocol v5.1 for kernel 876715ed-d3af-4ae6-8c76-71a6609933c0
 (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))
workbench.main.js:276 [Extension Host] Kernel: connected (876715ed-d3af-4ae6-8c76-71a6609933c0) (at Object.logKernelStatus (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/node_modules/@jupyterlab/services/lib/kernel/default.js:1430:25))
workbench.main.js:276 [Extension Host] Python Extension: Execute for import pandas as pd
import numpy
%matplotlib inline
import matplotlib.pyplot as plt
from matplotlib import style
style.use('dark_background') silently finished. (at Logger.logInformation (/home/rodhholland/.vscode-oss/extensions/ms-python.python-2018.10.1/out/client/common/logger.js:49:21))

> ```

This issue appears similar to #3332.
The issue is the server does not connect within vscode but it works fine from the command line - also within the vsode terminal.
The simple test is to start the interactive server.  It reports it is connecting but just hangs.
So far I have tried setting the ip address  and custom display url in the jupyter config file. Jupyter works fine from the command line but cannot be called from vscode.

Here is  console output when just trying to start interactive terminal while "starting server" is spinning:

I took out the localhost override in the config file and it shows that in fact the correct ip address is being read.  So it looks like there is a directory reading problem in vscode.  Not sure where to go from here.

As of right now (although we're fixing this), the line that says Copy/paste this URL into your browser has to be matchable by this regex:
/http:\/\/localhost:[0-9]+\/\?token=[a-z0-9]+/

It looks like yours is http://<IP_ADDRESS>.8866

@rholland
With this PR: https://github.com/Microsoft/vscode-python/pull/3386
I've expanded our address handling. It should now be fine with localhost, IP, missing token values, and base_url values.

Thanks Ian.  Any idea when this fix will be released for download?

@rholland It's in our development release (which is always public) currently. However if you want to get it in the main release we're planning on a update either this Wednesday or Thursday.

Got it.  Thanks.
When you say "development release" do you mean I need to assemble a vsix file from the github code? I imagine that just downloading the zip file and renaming does not work.  If that is the case can you simply describe which files/folders need to be included or should I go through the docs to figure it out?  Or do you do nightly vsix builds and if so, where are they?  Maybe this thread will help someone else as well.

@rholland My apologies. I linked to that build on another issue on this topic, but not on this one. It's not super easy to find. Here is the link to the build:
https://github.com/Microsoft/vscode-python/blob/master/CONTRIBUTING.md#development-build. It's updated at each push to master so it's pretty bleeding edge, but it's not too hard to install and swap to it if you want to give it a shot.

great.  thanks.

I just tried the dev release on my chromebook but the behavior has not changed.   Console screenshot below.  "Starting Jupyter Server" wheel just spins and nothing happens.  Maybe the chromebook url handling is just too finicky.

Is the actual output:
Copy/paste this URL into your browser when you connect for the first time,
to login with a token:
http://<IP_ADDRESS>:8892/?token=bfe0f40...
or is the token length longer than that and the console is just shortened because of your screenshot? If the token was not being output that would cause a problem.

On my windows 10 computer I get the failed to launch time out notification after about 30 seconds but the status bar message persists and the wheel continues to spin.   I do not get the message on the chromebook.  Not sure why windows is not working.   No errors in the console.
Regarding your question - the token is truncated in the image but fully there.  I can copy it to the browser and see the tmp file you create.  Also true on windows. The url works but the vscode pane never initialized.

On the windows 10 setup:
I renamed the notebook config file as well as the nbconfig folder.  Behavior is unchanged.

Interactive window opens
Status bar start message
No cell results
Then time out message
Status bar message continues

Will try chromebook next.

Renaming config file did not change behavior.  On the chromebook:

Status bar message (no interactive window)
No cell results.
Status bar message continues (no timeout)

Could you verify what the timeout message text is? Pretty much all the issues of this type have involved custom configuration, so there might be something else going on here. Also, if you run the cell a second time (after the message) does that also fail? It should try to start / connect again.

On windows 10 the dev release works after a reboot.  Will try rebooting the chromebook but I think there is something else going on.

Reboot of chromebook did not change anything.

@rholland Sorry, I had seen your comment that the Windows 10 dev release worked so I missed your second comment regarding the chromebook still not working. Are you still having the issue on the chromebook currently?


Feature request: RSEM outputs - counts matrix for isoforms

Hello,
Would it be possible to add to the RSEM its feature to generate a counts matrix for the isoforms data?
Within the RSEM documentation it states it has the ability to do this using the following command:
rsem-generate-data-matrix sampleA.[genes/isoforms].results sampleB.[genes/isoforms].results ... > output_name.counts.matrix
I was able to do this manually by loading RSEM as a module in biowulf so there is no rush for this, but I thought it would be useful since many downstream tools use count matrices
Thanks!

Hi @TBrownmiller, thanks for your request. rsem-calculate-expression outputs both gene and isoform counts -- the isoform count matrix is DEG_ALL/RSEM.isoforms.expected_count.all_samples.txt. Is this what you're looking for?

Sort of. I think its a difference in formatting of the outputs. One of the R packages I use (EBSeq) that is usually directly compatible with RSEM outputs asks for a matrix file (file extension ".MATRIX") format, but the RENEE generated outputs are either a txt or tsv format which aren't directly compatible.

Gotcha. We'll make this available in the next release of RENEE -- v2.6.

Hello @TBrownmiller ,
Just to follow up on your enquiry, I was wondering what error you receive when you try using the RSEM.isoforms.expected_count.all_samples.txt file in EBSeq?
From the package vignette, it says, The object Data should be a G − by − S matrix containing the expression values for each gene and each sample, where G is the number of genes and S is the number of samples. These values should exhibit
raw counts, without normalization across samples.
And the RSEM.isoforms.expected_count.all_samples.txt output file looks like:
gene_id GeneName        transcript_id   sample1 sample2
ENSG00000277411.1       5S_rRNA ENST00000614916.1       0.0     0.0
ENSG00000273730.1       5_8S_rRNA       ENST00000619779.1       11.88   12.62
...
ENSG00000268895.6       A1BG-AS1        ENST00000595302.1       33.26   12.7
ENSG00000268895.6       A1BG-AS1        ENST00000594950.5       0.0     0.0
ENSG00000268895.6       A1BG-AS1        ENST00000593960.6       21.17   10.29

You can create a new data matrix with just rownames and expression values. Try the following code:
library(dplyr)
library(tibble)
library(EBSeq)

df <- read.table("RSEM.isoforms.expected_count.all_samples.txt", header=T)
gene.matrix <- df %>%
mutate(gene=paste(gene_id,GeneName,transcript_id, sep="_") %>%
select(-c(gene_id,GeneName,transcript_id)) %>%
column_to_rownames("gene") %>%
as.matrix()

The gene.matrix should work with EBSeq.
Let us know if that works.

@samarth8392 thanks for posting the R code to transform the count table into a matrix.
Vishal and I discussed this issue and decided to go ahead and add a rule to create the matrix with rsem -- it runs very quickly and doesn't add much overhead at all. This way our users won't have to transform the other output themselves. See https://github.com/CCBR/RENEE/pull/149


Refactor for no_std and std targets

closes #1108
This PR attempts to make some refactors and fix the no_std and std

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Added entry in .changelog/

@romac  please have a look at this.

Codecov Report

Merging #1109 (8c6e015) into master (84012a7) will decrease coverage by 0.9%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #1109     +/-   ##
========================================
- Coverage    64.7%   63.8%   -1.0%
========================================
  Files         240     241      +1
  Lines       20822   21826   +1004
========================================
+ Hits        13490   13933    +443
- Misses       7332    7893    +561

Impacted Files
Coverage Δ

rpc-abci/src/code.rs
68.8% <ø> (ø)

rpc-abci/src/data.rs
80.4% <ø> (ø)

rpc-abci/src/gas.rs
64.2% <ø> (ø)

rpc-abci/src/info.rs
57.1% <ø> (ø)

rpc-abci/src/log.rs
30.7% <ø> (ø)

rpc-abci/src/path.rs
81.4% <ø> (ø)

rpc-abci/src/responses.rs
50.0% <ø> (ø)

rpc-abci/src/tag.rs
14.8% <ø> (ø)

rpc-abci/src/transaction.rs
5.8% <ø> (ø)

rpc-abci/src/transaction/hash.rs
53.4% <ø> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84012a7...8c6e015. Read the comment docs.

Context for closure: https://github.com/informalsystems/ibc-rs/issues/2015#issuecomment-1080528479


Mouse Without Borders is not working on my PC; the "New Key" and "Connect" buttons do nothing.

Microsoft PowerToys version
0.86.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Mouse Without Borders
Steps to reproduce
I installed PowerToys through the MS Store on both, my work laptop and PC.
Both have version 0.86.0.
On the laptop, I can generate keys and click the connect button; however, on the PC, the "New Key" and "Connect" buttons do nothing.
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

I have the same issue. Machines ping, firewall exceptions are added. I investigated further and it looks like the PowerToys.MWB.Service is set to "Manual" and I can't seem to start it manually.

I have the same issue. Machines ping and ssh over LAN fine, firewall exceptions are added. I investigated further and it looks like the PowerToys.MWB.Service is set to "Manual" and I can't seem to start it manually.
EDIT: Reverted to 0.85 and it's working for now.

Doesn't the service still start, though?  There should be three executables in Task Manager:
"C:\Users\Tyler\AppData\Local\PowerToys\PowerToys.MouseWithoutBorders" "default" C:\Users\Tyler\AppData\Local
"C:\Users\Tyler\AppData\Local\PowerToys\PowerToys.MouseWithoutBorders" "winlogon" C:\Users\Tyler\AppData\Local
"C:\Users\Tyler\AppData\Local\PowerToys\PowerToys.MouseWithoutBordersHelper"
I will see if I can't pull the log file.  Also, I did try mapping the IP address manually, and according to the MWB ViewModel, it loops on Resolving & Handshaking.
Also, I will try to see if I can't find the breaking change from this release.

The only change concerning MWB is that the Logger class replaces the Common class. This is a massive change because it's an entire restructuring of the existing class. @mikeclayton made the change—they would know more about it.
I am largely unfamiliar with the way that releases are done here, but I would assume that it passed all pipeline checks before release.  I'm seeing updated unit tests with corresponding mock data from the helper, so I can see that functionality works as intended.
So.....
My suggestion to anyone having the issue is to:

Unselect "Always run as administrator" in general settings.
Close PowerToys and restart it without administrative privileges.
Generate a new key.
Repeat this process for your other devices.
Connect the devices again.
Restart PowerToys on all devices & restore admin privileges.

Just a wild guess, but I bet the issue is that it passed pipelines because unit tests use predetermined data, it didn't test whether or not keys generated in PowerToys before the update were still functional post-update.  I believe it only tests by creating a brand new key on the fly and testing functionality that way.
But, anyway.  That should fix the problem.  Post in this thread if you are still having issues after following the above steps.

The change in https://github.com/microsoft/PowerToys/pull/35156 was mostly cosmetic - it basically extracts some static methods from Common.Log.cs (which was part of a collection of partial class files that formed a giant global Common utility class) and puts them into a separate Logger.cs class, then updates references to the static methods to e.g. Common.Log(...) -> Logger.Log(...) so the code compiles.
It touched a lot of files because the logging methods are used everywhere, but there were next to no application logic changes - if there were any systematic bugs introduced I would have thought there'd be reports of it before now.
Not saying there's no problems, but I don't think it's my changes that broke it \o/.

I’m experiencing the same issue. After the latest update, the key/connection no longer works. Resetting Mouse without Borders didn’t resolve the problem either. I can generate a key, but it complains that it doesn’t match, even after trying to generate it multiple times

Just re-updated to 0.86 and it seems to be working fine again.


test sonarcloud with this commit

:nut_and_bolt: Description: What code changed, and why?

:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist

[ ] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[ ] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable

This PR is no more needed


Make the iptables module to work using a true whitelist

From @basepi on March 7, 2017 22:55
From @avb76 on August 19, 2016 11:3
"It seems to me that in 99% of cases, people have a few iptables rules which are acceptable, and want to blacklist all others."
Copied from original issue: hubblestack/nova#234
Copied from original issue: hubblestack/hubble-salt#52

From https://github.com/hubblestack/hubble-salt/issues/53, make sure we also audit the default policy.

https://jira.corp.adobe.com/browse/CSTTEAM-44039


[Bug] Error Creating Elasticsearch Index with Date in Name via Terraform Provider Due to Unsupported Special Characters

Description
When trying to create an index with a date in the name via the Terraform Provider for Elastic, the operation fails due to unsupported special characters in the index name. The same command works in Kibana DevTools but not through the Terraform provider.
To Reproduce
Steps to reproduce the behavior:

Terraform (TF) configuration used:resource "elasticstack_elasticsearch_index" "nginx-k8s-prod-logs-vcae" {
  name = " %3Cnginx-k8s-prod-logs-vcae-%7Bnow%2Fs%7Byyyy-MM-dd%7D%7D-00001%3E"
  aliases = {
    "nginx-k8s-prod-logs-vcae" = {
      is_write_index = true
    }
  }
}

Execute the following TF operations to replicate the error:

terraform plan
terraform apply

Observe the following error in the output:╷
│ Error: invalid value for name (must contain lowercase alphanumeric characters and selected punctuation, see: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html#indices-create-api-path-params)
│
│ with elasticstack_elasticsearch_index.nginx-k8s-prod-logs-vcae,
│ on rollover-index_vcae.tf line 2, in resource "elasticstack_elasticsearch_index" "nginx-k8s-prod-logs-vcae":
│ 2: name = "nginx-k8s-prod-logs-vcae-{now/s{yyyy-MM-dd}}-00001"
│

Expected behavior
The index should be created successfully with the specified date in the name, similar to how the command works when executed directly in Kibana DevTools.

This is an interesting issue with the provider. As it's written, supporting this behaviour doesn't really make sense since {now/s{yyyy-MM-dd}} would evaluate to something different if the TF module was applied on different days.
Fixing this issue in isolation will then mean users hit https://github.com/elastic/terraform-provider-elasticstack/issues/94. There's a larger body of work required here to properly support lifecycle policy managed groups of indices within the provider. On the surface there's likely diminishing value in adding that support over say using data streams instead (I may certainly be missing some common cases there though).


Operator API controller: Remove broken thread-safety

Description of the change:
Remove broken thread-safety from the Operator API controller.
Motivation for the change:
The underlying queue will ensure a reconciler never races itself when processing a given resource event.
The thread-safety logic is flawed and can prevent Operator resources from being reconciled when component resources are updated.  It also ensures idempotence when enqueuing a resource for reconciliation; In other words, enqueuing no-ops if the given resource is already in the queue.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky
[ ] Tests that remove the [FLAKE] tag are no longer flaky

I assume the lint job is broken.

Holding so the bot doesn't go crazy. It looks like this branch needs to be fast forwarded as branch protection is complaining.
/hold

/hold cancel
/lgtm

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2015023


[Questions]Control Light buttons with the plugin?

Can I control Light buttons on my harmony companion with the plugin?
Describe the solution you'd like
Being able to send http call, with light button "long and short press" with the remote

High, not really sure to understand what you mean. If you are talking about home controls on harmony remote there is an option to bind them to a switch in home app through the plugin (see readme). No long / short press however , and it won’t make any http call, only send the command to the hub that is linked to that button in harmony configuration .
Sent with GitHawk

Thanks for the reply, need http call for control my stuff...


Win32 Azure CI pipeline (almost) always timeouts

I have noticed when submitting PRs (or updating a PR) that the 32-bit Windows Azure pipeline (nearly always) timeout. It runs until about 99 % of the testsuite is completed and then hangs until it is killed due to exceeding 60 minute runtime limit.

Yeah, that's happening almost all the time.  In https://github.com/scipy/scipy/pull/12404, the tests finished (all passed); the end of the log is
[...]
XFAIL ..\..\stats\tests\test_continuous_basic.py::test_cont_basic[truncnorm-arg95]
  reason: truncnorm
XFAIL ..\..\stats\tests\test_continuous_basic.py::test_cont_basic[truncnorm-arg96]
  reason: truncnorm
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! KeyboardInterrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
<string>:14: KeyboardInterrupt
(to show a full traceback on KeyboardInterrupt use --full-trace)
= 35866 passed, 2492 skipped, 128 xfailed, 8 xpassed, 1 warning in 2530.43s (0:42:10) =
Coverage.py warning: Couldn't use data file 'D:\\a\\1\\s\\build\\test\\.coverage.WIN-PN08AGA7H40.2620.053146': database disk image is malformed
Coverage.py warning: Data file 'D:\\a\\1\\s\\build\\test\\.coverage.WIN-PN08AGA7H40.3428.883381' doesn't seem to be a coverage data file: Couldn't use data file 'D:\\a\\1\\s\\build\\test\\.coverage.WIN-PN08AGA7H40.3428.883381': no such table: coverage_schema
Coverage.py warning: Data file 'D:\\a\\1\\s\\build\\test\\.coverage.WIN-PN08AGA7H40.960.573899' doesn't seem to be a coverage data file: Couldn't use data file 'D:\\a\\1\\s\\build\\test\\.coverage.WIN-PN08AGA7H40.960.573899': no such table: coverage_schema
##[error]The operation was canceled.
Finishing: Run SciPy Test Suite

I think the test runner hit the process with a keyboard interrupt while it was still printing the XFAIL results, so we're right on the edge of the 60 minute limit.
As a quick fix, how about we change the test mode for that test from full to fast?

Normally a good idea to turn verbose mode on to figure out which tests take the longest. How long does the build take?

In https://github.com/scipy/scipy/pull/12410 I changed the mode from full to fast.
I won't have time today for a deeper dive into the issue.

I merged that in, you can see some of my notes on the matter in that PR. In short, we  should probably petition for 32-bit mingw to be added to the base image with the Azure team upstream. That can save us 7-8 minutes and the chance of failure on the download stage too.
Even the 64-bit jobs, which as of recently no longer need to download mingw64, are still sometimes scraping really close to the 1 hour mark. When I run on my fork though they often finish much faster--I don't understand the fluctuations..

Does azure have caching? Can we just save it in a cache so we don't need to download ?

From inspection of one of the timeouts, the installation of mingw32 only takes ~3 minutes. This is only 1 or 2 minutes slower than the 64 bit images that already have mingw installed. The build takes 12.5 minutes, and the test run takes 40 mins.
We might be able to shave a little bit of time of the build if we can use ccache. Is that preinstalled on the images? If it's not preinstalled we wouldn't save much time at all.
 Can these tests be streamlined, their run times are excessive?

test_pascal is very fast locally, I reduced the amount of work done in the test (see https://github.com/scipy/scipy/pull/11765) but didn't search deeper for what causes it to be slow on cloud machines (I think it's slow in both Colab and Azure)

From inspection of one of the timeouts, the installation of mingw32 only takes ~3 minutes

7 minutes, 48 seconds in Warren's PR above... it varies and is a source of issues.

@sethtroisi I ran test_pascal in colab, it took 0.2s.

#12416 caches the mingw package, meaning it won't need to be repeatedly downloaded, but installation of the package will still take a little time.

Looking at a few recent PRs, this appears to fixed?  Most CI Windows builds ~40min

I haven't noticed this for a while, but there is a new one that usually times out.


[WIP] Release v0.19.0

Need: https://github.com/databricks/databricks-sdk-py/pull/539

Make docs useful again (#519).
Show undocumented fields in dataclasses (#520).
Search for both databricks.exe and databricks binaries in windows (#517).
Rename databricks.sdk.errors.mapping to databricks.sdk.errors.platform (#522).
refactor: add Union to content (2nd) parameter in upload function (#493).
Regenerate from the tip of main (#524).
Fix WorkspaceConf.get_status and WorkspaceConf.set_status (#525).
Enable Databricks OAuth also for Azure and GCP (#526).
Construct workspace client from account client (#527).
Skip test_get_workspace_client in Azure and GCP (#531).
Do not terminate listing for token-based pagination resources on empty response (#530).
Use fake clock for faster unit tests (#533).
Generate SDK (#536).

API Changes:

Added cancel_refresh() method for w.lakehouse_monitors workspace-level service.
Added get_refresh() method for w.lakehouse_monitors workspace-level service.
Added list_refreshes() method for w.lakehouse_monitors workspace-level service.
Added run_refresh() method for w.lakehouse_monitors workspace-level service.
Removed name field for databricks.sdk.service.catalog.UpdateConnection.
Removed name field for databricks.sdk.service.catalog.UpdateMetastore.
Removed name field for databricks.sdk.service.catalog.UpdateRegisteredModelRequest.
Removed name field for databricks.sdk.service.catalog.UpdateSchema.
Removed name field for databricks.sdk.service.catalog.UpdateVolumeRequestContent.
Added databricks.sdk.service.catalog.CancelRefreshRequest dataclass.
Added databricks.sdk.service.catalog.GetRefreshRequest dataclass.
Added databricks.sdk.service.catalog.ListRefreshesRequest dataclass.
Added databricks.sdk.service.catalog.MonitorRefreshInfo dataclass.
Added databricks.sdk.service.catalog.MonitorRefreshInfoState dataclass.
Added databricks.sdk.service.catalog.RunRefreshRequest dataclass.
Changed max_workers field for databricks.sdk.service.compute.AutoScale to no longer be required.
Changed min_workers field for databricks.sdk.service.compute.AutoScale to no longer be required.
Changed destination field for databricks.sdk.service.compute.DbfsStorageInfo to be required.
Added use_preemptible_executors field for databricks.sdk.service.compute.GcpAttributes.
Added zone_id field for databricks.sdk.service.compute.GcpAttributes.
Added abfss field for databricks.sdk.service.compute.InitScriptInfo.
Added gcs field for databricks.sdk.service.compute.InitScriptInfo.
Changed destination field for databricks.sdk.service.compute.LocalFileInfo to be required.
Changed destination field for databricks.sdk.service.compute.S3StorageInfo to be required.
Changed destination field for databricks.sdk.service.compute.VolumesStorageInfo to be required.
Changed clients field for databricks.sdk.service.compute.WorkloadType to be required.
Changed destination field for databricks.sdk.service.compute.WorkspaceStorageInfo to be required.
Added databricks.sdk.service.compute.Adlsgen2Info dataclass.
Added databricks.sdk.service.compute.GcsStorageInfo dataclass.
Removed get_status() method for w.files workspace-level service.
Added create_directory() method for w.files workspace-level service.
Added delete_directory() method for w.files workspace-level service.
Added list_directory_contents() method for w.files workspace-level service.
Added databricks.sdk.service.files.CreateDirectoryRequest dataclass.
Added databricks.sdk.service.files.DeleteDirectoryRequest dataclass.
Added databricks.sdk.service.files.DirectoryEntry dataclass.
Added databricks.sdk.service.files.ListDirectoryContentsRequest dataclass.
Added databricks.sdk.service.files.ListDirectoryResponse dataclass.
Added databricks.sdk.service.files.PageToken dataclass.
Added source field for databricks.sdk.service.jobs.DbtTask.
Added for_each_task field for databricks.sdk.service.jobs.RunTask.
Added source field for databricks.sdk.service.jobs.SqlTaskFile.
Added for_each_task field for databricks.sdk.service.jobs.SubmitTask.
Added for_each_task field for databricks.sdk.service.jobs.Task.
Added databricks.sdk.service.jobs.ForEachStats dataclass.
Added databricks.sdk.service.jobs.ForEachTask dataclass.
Added databricks.sdk.service.jobs.ForEachTaskErrorMessageStats dataclass.
Added databricks.sdk.service.jobs.ForEachTaskTaskRunStats dataclass.
Added databricks.sdk.service.jobs.RunForEachTask dataclass.
Removed reset() method for w.pipelines workspace-level service.
Changed autoscale field for databricks.sdk.service.pipelines.PipelineCluster to databricks.sdk.service.pipelines.PipelineClusterAutoscale dataclass.
Removed databricks.sdk.service.pipelines.ResetRequest dataclass.
Added databricks.sdk.service.pipelines.PipelineClusterAutoscale dataclass.
Added databricks.sdk.service.pipelines.PipelineClusterAutoscaleMode dataclass.
Changed delete_personal_compute_setting() method for a.account_settings account-level service with new required argument order.
Removed read_personal_compute_setting() method for a.account_settings account-level service.
Changed update_personal_compute_setting() method for a.account_settings account-level service with new required argument order.
Added get_personal_compute_setting() method for a.account_settings account-level service.
Removed delete_default_workspace_namespace() method for w.settings workspace-level service.
Removed read_default_workspace_namespace() method for w.settings workspace-level service.
Removed update_default_workspace_namespace() method for w.settings workspace-level service.
Added delete_default_namespace_setting() method for w.settings workspace-level service.
Added delete_restrict_workspace_admins_setting() method for w.settings workspace-level service.
Added get_default_namespace_setting() method for w.settings workspace-level service.
Added get_restrict_workspace_admins_setting() method for w.settings workspace-level service.
Added update_default_namespace_setting() method for w.settings workspace-level service.
Added update_restrict_workspace_admins_setting() method for w.settings workspace-level service.
Removed databricks.sdk.service.settings.DeleteDefaultWorkspaceNamespaceRequest dataclass.
Removed databricks.sdk.service.settings.DeleteDefaultWorkspaceNamespaceResponse dataclass.
Changed etag field for databricks.sdk.service.settings.DeletePersonalComputeSettingRequest to no longer be required.
Removed databricks.sdk.service.settings.ReadDefaultWorkspaceNamespaceRequest dataclass.
Removed databricks.sdk.service.settings.ReadPersonalComputeSettingRequest dataclass.
Removed databricks.sdk.service.settings.UpdateDefaultWorkspaceNamespaceRequest dataclass.
Changed allow_missing field for databricks.sdk.service.settings.UpdatePersonalComputeSettingRequest to be required.
Changed setting field for databricks.sdk.service.settings.UpdatePersonalComputeSettingRequest to be required.
Added field_mask field for databricks.sdk.service.settings.UpdatePersonalComputeSettingRequest.
Added databricks.sdk.service.settings.DeleteDefaultNamespaceSettingRequest dataclass.
Added databricks.sdk.service.settings.DeleteDefaultNamespaceSettingResponse dataclass.
Added databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingRequest dataclass.
Added databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingResponse dataclass.
Added databricks.sdk.service.settings.GetDefaultNamespaceSettingRequest dataclass.
Added databricks.sdk.service.settings.GetPersonalComputeSettingRequest dataclass.
Added databricks.sdk.service.settings.GetRestrictWorkspaceAdminsSettingRequest dataclass.
Added databricks.sdk.service.settings.RestrictWorkspaceAdminsMessage dataclass.
Added databricks.sdk.service.settings.RestrictWorkspaceAdminsMessageStatus dataclass.
Added databricks.sdk.service.settings.RestrictWorkspaceAdminsSetting dataclass.
Added databricks.sdk.service.settings.UpdateDefaultNamespaceSettingRequest dataclass.
Added databricks.sdk.service.settings.UpdateRestrictWorkspaceAdminsSettingRequest dataclass.
Removed delta_sync_vector_index_spec field for databricks.sdk.service.vectorsearch.CreateVectorIndexRequest.
Added delta_sync_index_spec field for databricks.sdk.service.vectorsearch.CreateVectorIndexRequest.
Added file_type field for databricks.sdk.service.workspace.ExportResponse.
Added resource_id field for databricks.sdk.service.workspace.ObjectInfo.

OpenAPI SHA: 6b897bc95b23abed8b9f5eff0e6b8ec034046180, Date: 2024-02-08
Changes

Tests

[ ] make test run locally
[ ] make fmt applied
[ ] relevant integration tests applied

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a1055d1) 57.89% compared to head (52170dc) 57.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   57.89%   57.89%
=======================================
  Files          44       44
  Lines       27956    27956
=======================================
  Hits        16185    16185
  Misses      11771    11771

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

when will this be released?


Failed Job check has incorrect output

Even when failed, the test outputs that the job "is success". Needs to use the variable to output the actual job result.

yay merged


Add the possibility of setting up the input id

It can be useful to set up the id html attribute of the date input element.
That allows browser based automated testing tools to select the element or to use something like the Dom module.
This PR enables that by exposing an inputId field on the settings. The field is of type Maybe String, with the default value of Nothing. The input element is only setup if a value is present, since it's recommend to have unique html ids.

Oops, didn't meant to base the PR on my fork's master


Update node info description in node.md

Node Info
General information about the node, for instance ..., "kubernetes
version" ... changed to "kubelete version, kube-Proxy version"

@marekbiskup Could you please review this PR?

@marekbiskup Sorry for the typo. I fixed

LGTM


[NO JIRA] replacing hardcoded node number values with variables

The number of nodes and the machine type used was hardcoded to the cluster.tf file the eks dir.
This PR replaces those values with variables so the user may tune the cluster specs to their needs from the tfvars file. defaults have been set which match our existing hardcoded values.

Can we add custom validation rules to enforce the max_capacity >= desired_capacity >= min_capacity invariant with a good error message?

I tried this but terraform doesn't allow it at this time.
error: The condition for variable "desired_capacity" can only refer to the variable itself "var.desired_capacity"
I can't reference other vars in the condition


feat(optimizer): handle partial anchored regex cases and improve doc

Which issue does this PR close?

Closes #.
Rationale for this change

Regex simplifier requires the pattern is fully anchored, this patch extends the boundary to partial anchored pattern. And also improves document in this mod
What changes are included in this PR?
Makes regex simplifier able to handle partially anchored regex like ^foo or foo$

Are these changes tested?
Yes

Are there any user-facing changes?
More regex match expr can be converted to LIKE expr

Thanks @alamb


Add a note about tail padding to URBP.assumingMemoryBound

Simply dividing the tuple's byte count by the element stride may result in a buffer with one fewer element than expected.
The current docs do not mention strides at all, so this isn't clear.
See https://forums.swift.org/t/zero-sized-types-vs-tuple-memory-layout/58768
Note that TailPadding has a stride of 4, yet a tuple of 2 elements contains 7 bytes. Using integer division (such as this function does) would return a buffer with count 1 from a 2-element tuple.
Anybody who wants a pointer to a tuple's elements should specify the expected count rather than relying on division. For example, https://github.com/karwa/swift-url/pull/165
@glessard @belkadan

@swift-ci please smoke test

Thanks for bringing this up, @karwa. This note would be equally relevant on URBP.withMemoryRebound, and possibly as well on the withUnsafe[Mutable]Bytes free functions.
Additionally:
Is there something particular to be said about zero-sized types here?
Would there be a better place to document this behaviour?
Should a short discussion about this behaviour be added to the SE-0333 proposal?

https://github.com/apple/swift/issues/60780


patch tests fail under (hw)asan

reported internally under hwasan on arm64, but trivially reproducible with asan on x86-64:
~$ cd /tmp
/tmp$ git clone https://github.com/landley/toybox.git
Cloning into 'toybox'...
remote: Enumerating objects: 27862, done.
remote: Counting objects: 100% (591/591), done.
remote: Compressing objects: 100% (297/297), done.
remote: Total 27862 (delta 364), reused 423 (delta 294), pack-reused 27271
Receiving objects: 100% (27862/27862), 11.77 MiB | 9.89 MiB/s, done.
Resolving deltas: 100% (20247/20247), done.
/tmp$ cd toybox/
/tmp/toybox$ export ASAN=1
/tmp/toybox$ make defconfig
cc -o kconfig/conf kconfig/conf.c kconfig/zconf.tab.c -DKBUILD_NO_NLS=1 \
	-DPROJECT_NAME=\"ToyBox\"
scripts/genconfig.sh
kconfig/conf -D /dev/null Config.in > /dev/null
/tmp/toybox$ make
scripts/make.sh
Library probe
generated/{Config.in,newtoys.h,flags.h,globals.h,tags.h,help.h}
Compile toybox
.....................................................................................................................................lib/password.c: In function 'update_password':
lib/password.c:148:21: warning: pointer 'nfp' may be used after 'fclose' [-Wuse-after-free]
  148 |     else if (entry) fprintf(nfp, "%s\n", entry);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/password.c:144:3: note: call to 'fclose' here
  144 |   fclose(nfp);  // automatically unlocks
      |   ^~~~~~~~~~~
.............................................................toys/posix/grep.c: In function 'do_grep':
toys/posix/grep.c:206:24: warning: 'regexec0' accessing 8 bytes in a region of size 4 [-Wstringop-overflow=]
  206 |             shoe->rc = regexec0(&shoe->r, start, ulen-(start-line), 1,
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  207 |                                 &shoe->m, start==line ? 0 : REG_NOTBOL);
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toys/posix/grep.c:206:24: note: referencing argument 5 of type 'regmatch_t[0]'
In file included from ./toys.h:70,
                 from toys/posix/grep.c:65:
./lib/lib.h:263:5: note: in a call to function 'regexec0'
  263 | int regexec0(regex_t *preg, char *string, long len, int nmatch,
      |     ^~~~~~~~
..
/tmp/toybox$ make test_patch
scripts/test.sh patch
patch:Library probe
generated/{Config.in,newtoys.h,flags.h,globals.h,tags.h,help.h}
Compile generated/testdir/patch
...............lib/password.c: In function 'update_password':
lib/password.c:148:21: warning: pointer 'nfp' may be used after 'fclose' [-Wuse-after-free]
  148 |     else if (entry) fprintf(nfp, "%s\n", entry);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/password.c:144:3: note: call to 'fclose' here
  144 |   fclose(nfp);  // automatically unlocks
      |   ^~~~~~~~~~~
..

 1 file changed, 82 insertions(+), 77 deletions(-)
/tmp/toybox$ make test_patch
scripts/test.sh patch
patch:generated/{newtoys.h,flags.h,globals.h,tags.h,help.h}
Compile generated/testdir/patch
....
PASS: patch dry run doesn't create file
PASS: patch create file
PASS: patch insert in middle
PASS: patch append at end
PASS: patch insert at start
PASS: patch delete at end
PASS: patch delete at start
PASS: patch filter timestamps
PASS: patch quoted name
PASS: patch bad quote
PASS: patch dry run doesn't delete file
PASS: patch delete file
PASS: patch fuzz
/tmp/toybox$

the crashing line is
      while (isspace(*++s));

and the allocating line is
      patchline = xstrdup(" ");

so s is already pointing to the '\0' when the ++ happens... i'll leave the fix to you though :-)

Sigh, leftover debris. Try commit 7c30d04e6771

lgtm, thanks!


Create static select identifiers

Elm-select relies on the creation of a SelectIdentifier in order for it to work properly. It uses this identifier to bind DOM queries on various elements.
Through the creation of this identifier elm-select adds some 'cruft' to the user defined String that is passed to the selectIdentifier function.
e.g.
Select.initState (Select.selectIdentifier "CountrySelector") -- "CountrySelector__elm-select"

This is done to try create some extra uniqueness to other id's that might be lurking in the DOM with the same "CountrySelector" id.
Folks however might want to rely on ID's that they themselves don't create but depend on. This specific case could happen when elm-select is used in a framework like djelm. Djelm does make it possible to replace server rendered Django widgets with client hydrated Elm ones.
The django form helpers assign 'auto_id' values on form widgets to ensure labels correspond to the right input. These ids might be used by the consumer for other javascript DOM binding stuff that would break if elm-select was used and mangled the server generated ID.
Proposed Solution
Make it possible to render ID's on elm-select that doesn't mangle the ID String that is passed to selectIdentifier.
Select.initState (Select.selectIdentifier "CountrySelector") -- "CountrySelector"

Released in 10.4.0


Support declare a parameter in struct as required

I define a struct model with go-playground/validator.v8 for validation:

type SigninForm struct {
	Category int    `form:"category" json:"category" binding:"required"`
	Username string `form:"username" json:"username" binding:"required"`
	Password string `form:"password" json:"password" binding:"required"`
}

I want to make required fields declare in docs.go

"forms.SigninForm": {
            "type": "object",
            "required": [ .   // expected
                "category",
                "username",
                "password"
            ],
            "properties": {
                "category": {
                    "type": "integer"
                },
                "password": {
                    "type": "string"
                },
                "username": {
                    "type": "string"
                }
            }
        },

Why is this required?

Is this supported by swagger?

Is this supported by swagger?

Yes, this is supported by swagger. For example in Swagger Editor Line 650
Pet:
    type: "object"
    required:
    - "name"
    - "photoUrls"
    properties:

The required field "name" and "photoUrls" will show a red mark in document of Pet model definition.

How can I define struct field as it is required?
I want like this:
type User struct {
        // binding: required
	Name      string `json:"name"`
}


Kitchen Sink : Virtual Dice Roller

Describe the feature
This app will roll a die for board games or decision-making.
Please assign this to me, I want to participate in hacktoberfest_23 : )
Additional information

[X] Would you be willing to help implement this feature?

@Timonwa @tobySolutions Is this task open for contribution ??
if so please assign it to me :)

Hey, I think @UzairNoman wants to work on it.


New lint rule: Module exports must match in all platform-specific files

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem
If a change is made to an export of one platform-specific file, but not the others, something is likely to break.
Solution
Create a new rule that ensures all platform-specific implementations of a module have the same named exports.
So the following code would break the lint rule:
index.js
export {
    someMethod,
    someOtherMethod,
};

index.native.js
export {
    someFunction,
    someOtherFunction,
};

View all open jobs on GitHub

This would be a pretty valuable lint rule, I'm going to hold onto it for now.

I'm not sure this is really possible using ESLint. Individual rules cannot access the filesystem or be compared to their neighboring files AFAICT.

I think the best / closest we could do would be a custom Node.js script that:

Finds all directories that have multiple index.js, index.native.js, etc...
Parse each such file using an AST parser like acorn
For each file, find the names of all named exports in the AST produced by the parser.
Throw an error if there are named exports found in one of the files but not the other.

And that would work, but it wouldn't be all that developer-friendly or integrate with an IDE at all, because it wouldn't be an ESLint rule.

I think that since we can't use ESLint for this, it's going to be more complex than is worth it. Going to just close this out for now.


"show_change_link = True" not working as expected

show_change_link = True does not seem to be supported.  The icons appear on the inline formset, but it's a dead link.  (Temporary fix: In tabular.html, I changed  to ; it changed the position of the link a bit, but at least it works.)

Fixed in v1.7.2


using own compiled julia:  Error Cache Base and it's submodules.

Just to let you know - I do not install julia but only recompile it: in which case julia/usr/share/julia/base is empty.
running the tests errors
79 facts verified.
Base
     - Cache Base and it's submodules.
Docile: updating package list…
  Error   :: (line:-1) :: Cache Base and it's submodules.
    isempty(Docile.Cache.getparsed(Base)) => true
SystemError: unable to read directory /0_JULIA_COMPILED_0/git_julia/usr/share/julia/base: No such file or directory
 in readdir at ./file.jl:246

You might have broken the symlink then. The directory should just link to /base. Works for me and has been working on the CI. Perhaps you copied the git_julia folder from somewhere else?

While I'm away I will recomplie from scratch and update here later.

recomplie from scratch

:(
Do you have
override OPENBLAS_DYNAMIC_ARCH = 0

in your Make.user file? Cuts down compile times significantly.

you where right: it places the link there
Thanks


Improve ping/pong mechanism

Codecov Report
Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (73b94a6) 90.41% compared to head (35d0ce3) 90.29%.

Files
Patch %
Lines

hahomematic/client/__init__.py
75.60%
10 Missing :warning:

hahomematic/caches/dynamic.py
92.00%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1293      +/-   ##
==========================================
- Coverage   90.41%   90.29%   -0.12%
==========================================
  Files          49       49
  Lines        5863     5926      +63
==========================================
+ Hits         5301     5351      +50
- Misses        562      575      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add normalization of mutual stats to meritrank-service "MUTUAL_SCORES"

Fixing this issue.

We have to use rustfmt because without it commit is awful


[Bug] When you disconnect Wi-Fi, NotificationService posts "No Connection" notification

Solution: Delete "No Connection" notification code and delete useless if statements

Solved


add table create comment to table spec

mysql allows comments on create table statement, both on the table clause itself as well as on the columns. The column spec has this implemented but for the table this is missing.
The parsed AST does contain the comment so it is merely about passing it to the tablespec.
Would it be possible to ask to add this?
As in
CREATE TABLE test(id text) COMMENT="This is a comment about table";

I would assume it should be added here:
https://github.com/dolthub/go-mysql-server/blob/e42adc9dbc2869bab77e0012c6f01f0d96dee0ab/sql/planbuilder/ddl.go#L244-L250
Many thanks
Martin

Hi @Allam76, thanks for contacting us. It makes sense for us to support those comments at the table level, too. Looks like we just need to pull the comment out of the AST, plug it into TableSpec, update the schema serialization to store/load that new field, and also add that into the merge logic so that table comments are merged properly.
Thanks for requesting this one! We'll start looking into the implementation details.


Update macos.md

These instructions didn't work for me as written, but I found https://github.com/cloudflare/cloudflared/issues/327#issuecomment-1087792549 when googling the error message. Seems like something's changed about the syntax?
However, I did follow the instructions in https://blog.cloudflare.com/ridiculously-easy-to-use-tunnels/ (linked from that GH issue) and migrated the config into the Dash. It also gave me the sudo cloudflared service install command to run, too.
Maybe this whole page can be updated given the new Dash stuff? Otherwise the proposed change here might work for some people...
FWIW, I was following this guide: https://developers.cloudflare.com/cloudflare-one/tutorials/ssh/ . I'm guessing a few of those steps can be skipped now?

@abelinkinbio
Shouldn't cloudflared service install work without the token? Do you only need the token for a remotely-managed tunnel?

@abelinkinbio Shouldn't cloudflared service install work without the token? Do you only need the token for a remotely-managed tunnel?

That's correct. For locally managed tunnels, the token is not necessary. This should be resolved. I believe we can decline this PR as this will be better clarified in our refactor.

We are in the process of refactoring the tunnel docs, which will hopefully clarify dashboard vs. CLI workflows.


Anonymous 3rd party requests

When making 3rd party requests, have an option to remove cookies from these requests. This can mitigate some of issue #3

Verified that the 3rd party cookies are disabled by this code


IWA files support

Hey!
Does your library support .iwa (custom framed format) compression?
more about .iwa :  https://github.com/obriensp/iWorkFileFormat/blob/master/Docs/index.md#iwa

@dain


Run self es-self provisioned test on travis

Run make e2e-tests-self-provisioned-es on travis. The motivation is to catch issues early.
For example https://github.com/jaegertracing/jaeger-operator/issues/481 is not related to OCP version but to change in ES operator.
@kevinearls would you be interested in this issue?

Side note. self provisioned ES needs openshift to run. It does not run on plain k8s so we will need OCP on travis. I propose to use oc cluster up (3.9 is the lightest), we have done it here https://github.com/RHsyseng/docker-rhel-elasticsearch/blob/master/tests/prepare.sh to test other ES image.

Perhaps we could add a suite for OpenShift (// +build openshift) and run it as a separate job?


Fix typeguard upper bound

The current package breaks on typeguard>=3 due to the following error:
  File "/.../test2.py", line 13, in <module>
    patch_typeguard()  # use before @typechecked
  File "/.../python3.10/site-packages/torchtyping/typechecker.py", line 271, in patch_typeguard
    class _CallMemo(typeguard._CallMemo):
  File "/.../python3.10/site-packages/typeguard/__init__.py", line 42, in __getattr__
    raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
AttributeError: module 'typeguard' has no attribute '_CallMemo'. Did you mean: 'CallMemo'?

So this just limits the typeguard install to <3 which fixes things. It looks like a few functions need to be rewritten on >=3 so this is a simple band-aid fix.
(I understand this package isn't actively maintained, but until https://github.com/google/jaxtyping/issues/6 is closed, I find this package a bit more useful, even though you mention the patch_typeguard felt a bit hacky 😄)

LGTM, thank you!


Create static folder on first generate

Ensure that static folder exists so go generate doesn't fail.

LGTM :)
/cc @vdemeester

LGTM 🐸 but needs a rebase :sweat:

@vdemeester rebased.


[Suggestion] Buy now with a double click

For you guys, it's possible to integrate a script who buy a player in the search result with a simple double click ?
Thanks, and good job for others scripts !

That's certainly possible. Will consider adding this in the merged version of the scripts. Can't give an ETA yet.

+1

I think this might be fairly error prone. Will keep it into consideration while testing for the FIFA 19 release.
Cleaning up the issue list for the FIFA 19 update.


Use FrameworkContentElement instead of FrameworkElement

In the Wpf library, classes like Series, Axis extend FrameworkElement but they are not displayed in the visual tree.
If FrameworkElement has been choosen for DataContext and DependencyProperty inheritance or for Style capabilities, FrameworkContentElement should be used instead. it can be styled and can inherit data context and dependency properties but is not a visual element.
When using the librairy, I often set the Width property thinking it will affect the graph but it is just here because it is inherited by FrameworkElement

Thanks, this is a design issue, should be fixed in the next, version thanks for the suggestion.


Investigate using Argo Event to as a source

We want to enable more sources of events, and Argo Events already supports things like SNS and MQTT.
How can we plumb Argo Events into Dataflow to achieve this?

@whynowy would you like to investigate this? I think we could do this using a sensor with HTTP trigger connected to a pipeline with a HTTP sensor?
I think we just need to prove it works, and understand if we drop/dupe messages.


Maybe set uv as the default?

Shall we switch to uv as the default now? Related: https://github.com/astral-sh/rye/discussions/1071

Originally posted by @SichangHe in https://github.com/eifinger/setup-rye/issues/202#issuecomment-2106258672
Sorry for the confusing comment. I am not exactly clear what the situation is. I'll try to explain.
Background: So, my CI using setup-rye and PyPy3 failed, and in the discussion linked above we found that pip-tools + PyPy3 does not work, but uv + PyPy3 does.
My guess: setup-rye defaults to using pip-tools, causing the above CI failure. Rye itself defaults to use uv when it could (that was what happened when I installed it locally), so defaulting to pip-tools is a choice by setup-rye.
I don't know why uv is not the default here. Because it was experimental?

Will be fixed when https://github.com/astral-sh/rye/pull/1053 gets released

Also related: https://github.com/astral-sh/rye/issues/1081

When shall I remove the line in the CI which specifies to use uv and test again?

Yes it works. PyPy3 should "just work" now. Thank you both for the good work!


question about some implementation details

I compared your implementations of 'train_svd.py' and 'train.py' and found several interesting points:
https://github.com/alibaba/animate-anything/blob/main/train_svd.py#L441
could you explain the difference between latent_dist.mode() latent_dist.sample()?
https://github.com/alibaba/animate-anything/blob/main/train_svd.py#L433
Why not pass the vae and image_encoder as arguments into this function? Is there any difference btw passing in arguments and sparing from pipeline?

Hi I find your implementation of train_svd.py very helpful.
I don't quite understand this part. Could you give some reference or explanation to this part of implementation? Thank you!
https://github.com/alibaba/animate-anything/blob/main/train_svd.py#L477 to L483

Hi I noticed in your latest implementation,
https://github.com/alibaba/animate-anything/blob/main/train_svd.py#L810
not casting text_encoder to half precision may cause datatype mismatch problem during training.

cause datatype mismatch problem during
I encounter this issue too. Text-encoder should be casted into half precision and move to cuda.


Form Group overrides test IDs

The FormGroup component unexpectedly overrides our test IDs used by QE. If we continue using 'testIds', we should ensure that isn't overridden.
As an example, consider the text inputs for the login screen. For the username input, I expect to see id='username-input' in the rendered HTML. Instead, I see id='Username0', which is the label name given to the FormGroup concatenated with a unique index.
<FormGroup label={t('login.username_label')}>
  <TextInput
    {...getTestProps(testIds.login.username_input)}
    ...
  />
</FormGroup>

After speaking with @boaz1337, this is working as designed. The ID we're providing to the text input is output as data-testid, not the id.


transition-group item with flex parent moves to top-left

Version
2.6.8
Reproduction link
https://codepen.io/andymerskin/pen/eRNvLR
Steps to reproduce

Click in any rectangle except the first one

What is expected?
The rectangle should fade out, but not move
What is actually happening?
The rectagle moves to the left-top corner while fading away

This seems to be caused by the flex parent combined with absolute positioning of the rectangle leaving
Related

https://github.com/vuejs/vue/issues/8973 – The solution suggested in this ticket only works if the rest of the elements are not being animated with move.

it goes to the top because you are using position absolute

That fact was explained in the description of the ticket. If there is no intention of supporting this use case, it would be more interesting to know why.

On 15. Mar 2019, at 17:54, Eduardo San Martin Morote<EMAIL_ADDRESS>wrote:
Closed #9713.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm saying that this is working correctly: absolute makes it go to the top left in the flex container even without top or left (not the case with a regular container) and because it's in a transition group, Vue adds the transform attribute (to move things) making it move to the top left

Same issue for flex and grid
Found this solutions:
<transition-group
    @before-leave="beforeLeave">
    ...
</transition>

methods: {
    beforeLeave(el) {
        const {marginLeft, marginTop, width, height} = window.getComputedStyle(el)

        el.style.left = `${el.offsetLeft - parseFloat(marginLeft, 10)}px`
        el.style.top = `${el.offsetTop - parseFloat(marginTop, 10)}px`
        el.style.width = width
        el.style.height = height
    }
}

thanks to docmars in forum.vuejs.org

The reason position: absolute is added is likely to accomplish this effect: https://vuejs.org/guide/built-ins/transition-group#move-transitions
In the example, this works fine. But when using a flex parent container, the items move to the top of the container the moment they are animated away, which is an undesired side effect.


X-Ray traces don't show related CloudWatch Logs

I'm using ADOT .NET SDK and the ADOT Collector.
I can view traces in X-Ray, however related logs aren't shown.
Logs
All logs for this trace

No data found.
Try adjusting the dashboard time range or log query.

If I tap 'View in CloudWatch Insights' it'll materialize a query which returns no logs:
fields @log, @timestamp, @message
| filter @message like "1-620ca1d6-07f7494e51e410242c9d67f3"
| sort @timestamp, @message desc

however the correct query, fixing the trace ID to remove the leading digit and hyphens, returns related logs:
fields @log, @timestamp, @message
| filter @message like "620ca1d607f7494e51e410242c9d67f3"
| sort @timestamp, @message desc

Is this expected behaviour?
System info

    <PackageVersion Include="OpenTelemetry.Contrib.Extensions.AWSXRay" Version="1.1.0" />
    <PackageVersion Include="OpenTelemetry.Contrib.Instrumentation.AWS" Version="1.0.1" />
    <PackageVersion Include="OpenTelemetry.Exporter.Console" Version="1.1.0" />
    <PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.1.0" />
    <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9" />
    <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9" />

amazon/aws-otel-collector:latest

Hi @NickDarvey,
Unfortunately, the trace <-> Log correlation feature in serviceLens is not yet officially supported. It's great to hear you have a workaround to get to view them. Can you share how you inject the trace ID into each of your log statements to possibly help other users achieve this same workaround? Could you also share the (redacted as necessary) raw trace JSON of an example trace you're viewing?
As a long-term fix, ServiceLens should try to query for trace IDs using both the X-Ray format (with the 1 and hyphens) AND the OTel format, which was the format that worked for you.

Ahh, I just used OpenTelemetry.Contrib.Extensions.AWSXRay and followed the sample application to add:
https://github.com/aws-observability/aws-otel-dotnet/blob/a6c4dcabf67656d852bf258c603415265c432bba/integration-test-app/integration-test-app/Startup.cs#L32
It looks like @lupengamzn did the magic:
open-telemetry/opentelemetry-dotnet-contrib/src/OpenTelemetry.Contrib.Extensions.AWSXRay/AWSXRayIdGenerator.cs

Got it, thanks for the context! I've opened this feature request to search for both formats with the ServiceLens team, and will update this issue if anything comes from it. I think many customers could benefit from both formats being searched by default.

Thank you @NickDarvey for providing a solution, really helped me out.
@willarmiros Is there any update on ServiceLens team?
I just wanted to add a solution to help get the logs to show in service lens without having to do what @NickDarvey suggested.
Requirements:

follow @NickDarvey instruction to setup x-ray open telemetry compatible Id's
Using console logger or any logger that supports Log scopes

First you will need to add a middleware to your application like this
public class XrayScopedLoggingMiddleware
{
    private readonly RequestDelegate next;
    private readonly ILogger<XrayScopedLoggingMiddleware> logger;

    public XrayScopedLoggingMiddleware(RequestDelegate next, ILogger<XrayScopedLoggingMiddleware> logger)
    {
        this.next = next ?? throw new System.ArgumentNullException(nameof(next));
        this.logger = logger ?? throw new ArgumentNullException(nameof(logger));
    }

    public async Task Invoke(HttpContext context)
    {

        var xrayId = ConvertIdToXrayId(Activity.Current?.RootId ?? "");

        var loggerState = new XrayLogScope(new List<KeyValuePair<string, object?>>()
        {
            new("XrayTraceId",xrayId)
        });

        using (logger.BeginScope(loggerState))
        {
            await next(context);
        }
    }

    internal static string ConvertIdToXrayId(string id)
    {
        if (string.IsNullOrWhiteSpace(id)) return id;
        return $"1-{id[..8]}-{id[8..]}";
    }
}

internal class XrayLogScope : ReadOnlyCollection<KeyValuePair<string, object?>>
{
    public override string ToString()
    {
            StringBuilder sb = new StringBuilder();

            sb.Append(this[0].Key);
            sb.Append(':');
            sb.Append(this[0].Value);

            for (int i = 1; i < Count; i++)
            {
                sb.Append(", ");
                sb.Append(this[i].Key);
                sb.Append(':');
                sb.Append(this[i].Value);
            }

            return sb.ToString();
    }

    public XrayLogScope(IList<KeyValuePair<string, object?>> list) : base(list)
    {
    }
}

Then you need to register the middleware before any other.
Program.cs
...
var app = builder.Build();
app.UseMiddleware<XrayScopedLoggingMiddleware>();
// ... other middleware

This will now include the trace id in x-ray format to all logs. Hopefully this is only a short term fix.
Example
info: TestProject.WeatherController
      => SpanId:f6538c55103be793, TraceId:63035fd77b3d83ea68fbcf1e6c59b71c, ParentId:0000000000000000 => ConnectionId:0HMK45HBUND3D => RequestPath:/weather RequestId:0HMK45HBUND3D:00000004 => XrayTraceId:1-63
035fd7-7b3d83ea68fbcf1e6c59b71c => TestProject.WeatherController.Post (TestProject)
      "hello world"

Hope this can help someone else too