Can't use npm package in Typescript and Webpack project

Hi,
I'm trying to use the library in my project, based on Typescript targeting es6 and using commonjs modules. The final output is produced using Webpack and targeting the web platform.
I've installed the dependency with npm:
npm install --save jose-jwe-jws

and try to reference it in my code:
import {Jose} from "jose-jwe-jws";
...
let cryptographer = new Jose.WebCryptographer();
...

Everything compiles good, but when I run the result of webpack in my page, I've got an error:
Uncaught ReferenceError: Jose is not defined

I've got the same error trying to run tests with Mocha... :-(
What I'm missing?
Thank You

Having the same issue while updating from v0.11.1 to v.1.1.3.
Trying to import in a few different ways:
import {Jose} from "jose-jwe-jws";
import * as Jose from "jose-jwe-jws";
import Jose from "jose-jwe-jws";

All turn out with Jose beign an empty object.

v0.11.1 works when I import and use as such:
import * as Jose from 'jose-jwe-jws'
const cryptographer = new Jose.Jose.WebCryptographer()

I need to update to the latest version since snyk.io has found vulnerabilities in<EMAIL_ADDRESS>in  v0.11.1

Seems that the issue lies in the webpack configuration:
  output: {
    filename: 'jose.js',
    library:'Jose',
    libraryTarget: 'var'

using
    libraryTarget: 'umd' | 'commonjs'

Pull #89 does some changes in regards to this. Can this be looked at, right now this configuration doesn't allow using the library as a node module or a ES6 module.
Thanks.

https://github.com/square/js-jose/pull/89 has conflicts. If it builds, I'm happy to merge it.

Let me suggest a PR for this.

Thank you for your feedback. I've already headed to this configuration:

    libraryTarget: 'umd' | 'commonjs'

and also tried:

Pull #89

installing npm package from Mischala/js-jose#exportCjsPackage but neither works.
I'll try to investigate further.
Thanks.

Yeah, my  attempts have proved that we would need to tweak the definition file... And I end up having issues with decryption on that new package. Let me know if you end up with a solution.

I have resorted to use version 0.1.6 where I can use it like this  in my TS project.
import * as Jose from 'jose-jwe-jws'

const cryptographer = new Jose.Jose.WebCryptographer()

We're seeing the same issue here. Just like @wfortin, only 0.1.6. works were as 0.1.7 fails.

@damnhandy @wfortin this should be fixed in 0.2.0

@mbyczkowski care to give an example with 0.2.0?
I still end up with an empty object importing in all these different ways:
import {Jose} from "jose-jwe-jws";
import * as Jose from "jose-jwe-jws";
import Jose from "jose-jwe-jws";

Seems that the definitions are fixed now, but at runtime I get:
import * as Jose from "jose-jwe-jws";

import {Jose} from "jose-jwe-jws";

import Jose from "jose-jwe-jws";

I get the error Module '"jose-jwe-jws"' has no default export.
So it seems the webpack configuration is still incorrect, as the object is defined but the exported methods are not in that object.
The added test in here https://github.com/square/js-jose/commit /60a948c3fe9a735a81bd7bc74dfee492ac164bb6 checks if the object is not empty, which is true, but it doesn't contain the methods/keys like WebCryptographer, Utils, etc.
So I'm still sticking to 0.1.6 as mentionned here

I've added a codesandbox to replicate the issue here:
v0.2.0 (not working as described in my last comment) : https://codesandbox.io/s/hopeful-mirzakhani-2m2bz?fontsize=14
v0.1.6 (working) : https://codesandbox.io/s/jose-jwe-jws020-0w7y9?fontsize=14
Hope this helps!

@wfortin thanks for the repro. I'm going to look into this.

@wfortin I thought I had a fix for this in #116, but after grabbing your repro, I can still see the issue in 0.2.1. I wonder if this is packaging problem now (babel, webpack, parcel etc.).

I've submitted a pull request that allows me to import it in my Angular 8 application, satisfying the Typescript + Webpack problem. UMD library packaging should allow it to continue to be used as a var, but also an importable module.

Anyone else still struggling with this, I was able to workaround the issue by directly importing the non-minified JS files. All the contained paths there were relative, so webpack was able to figure out how to wire this all together ok from that.
E.g., I've made a file called js-jose.ts in my project, with this content:
/// <reference types="jose-jwe-jws" />
(window as any).Jose = require("jose-jwe-jws/lib/jose-core.js");

Once that is done, I simply import that somewhere, and things work!

Indeed it works as expected with this last commit, when do you plan a new release with corresponding npm package as well ? Thx.

I have just released 0.2.2. @mbelge feel free to re-open the issue if you're still seeing the problem with 0.2.2.


Special datetime format required?

I have a table in a Azure SQL database with a datetime column which I want to enable incremental refresh on. The problem is that I keep getting the "query folding" warning, and if I run the incremental refresh anyway it is painfully slow.
The only thing I can think of being the cause of the query being non-foldable is the fact that the DateTime column also contains milliseconds.
Does the DateTime format strictly has to be 'YYYY-MM-DD-HH-MM-SS' for query folding and therefore incremental refresh to work in Power BI? Maybe there is even a preferred T-SQL DateTime format like 120 etc?
If so you should add it to the documentation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fdb026fd-1515-7484-1acd-3d363e143cc8
Version Independent ID: 62650e83-de5c-0323-cacc-31bad6e46361
Content: Incremental refresh in Power BI Premium - Power BI
Content Source: powerbi-docs/service-premium-incremental-refresh.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Hi, @Mholsen -- thanks for the question and suggestion! I've assigned to the author to look into it.

Assigning to @christianwade to see if he can clarify what's expected here, and we can update the docs.


❌ Errors in create_base_entity_graph

I have successfully replicated the result for the official demo from get started.
This happens when I try on new data by extracting the textual info from a company's pdf report and storing textual information in input.txt. I have used UTF-8 encoding and the length of the document is rather short compared to the example.
This error is raised as seen in the log:
raise ValueError("Columns must be same length as key")
ValueError: Columns must be same length as key

Can anyone help me with this issue, please? I am not very familiar with the pipeline as well as the technical details behind this. It's more for me to explore at this time. Thx in advance!

im having this same issue

me too

me too

I did repo into the same directory and I got it working
On Tue, 9 Jul 2024, 14:23 lifelmy, @.***> wrote:

me too
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/graphrag/issues/437#issuecomment-2216275349,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHZFMU7REM73EBXXA3555BLZLNCRHAVCNFSM6AAAAABKQ3CEAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWGI3TKMZUHE
.
You are receiving this because you commented.Message ID:
@.***>

same issue !!!! any solution

did you use gpt 3.5 turbo or same and i tried with 1200 max tokens but still not working

Hi, can you please inspect in any of the cache entries for entity extraction and paste a result? I suspect it is an entity extraction issue.

Result from cache/entity_extraction/chat-d87d9cc79a03b34a16a6895b3d54f53a
{"result": "There is no text provided to analyze. Please provide a text document to proceed with the entity and relationship extraction.\n\n<|COMPLETE|>", "input": "\n-Goal-\nGiven a text document that is potentially relevant to this activity and a list of entity types, identify all entities of those types from the text and all relationships among the identified entities.\n\n-Steps-\n1. Identify all entities. For each identified entity, extract the following information:\n- entity_name: Name of the entity, capitalized\n- entity_type: One of the following types: [organization,person,geo,event]\n- entity_description: Comprehensive description of the entity's attributes and activities\nFormat each entity as (\"entity\"<|><entity_name><|><entity_type><|><entity_description>\n\n2. From the entities identified in step 1, identify all pairs of (source_entity, target_entity) that are *clearly related* to each other.\nFor each pair of related entities, extract the following information:\n- source_entity: name of the source entity, as identified in step 1\n- target_entity: name of the target entity, as identified in step 1\n- relationship_description: explanation as to why you think the source entity and the target entity are related to each other\n- relationship_strength: a numeric score indicating strength of the relationship between the source entity and target entity\n Format each relationship as (\"relationship\"<|><source_entity><|><target_entity><|><relationship_description><|><relationship_strength>)\n\n3. Return output in English as a single list of all the entities and relationships identified in steps 1 and 2. Use **##** as the list delimiter.\n\n4. When finished, output <|COMPLETE|>\n\n######################\n-Examples-\n######################\nExample 1:\n\nEntity_types: [person, technology, mission, organization, location]\nText:\nwhile Alex clenched his jaw, the buzz of frustration dull against the backdrop of Taylor's authoritarian certainty. It was this competitive undercurrent that kept him alert, the sense that his and Jordan's shared commitment to discovery was an unspoken rebellion against Cruz's narrowing vision of control and order.\n\nThen Taylor did something unexpected. They paused beside Jordan and, for a moment, observed the device with something akin to reverence. \u201cIf this tech can be understood...\" Taylor said, their voice quieter, \"It could change the game for us. For all of us.\u201d\n\nThe underlying dismissal earlier seemed to falter, replaced by a glimpse of reluctant respect for the gravity of what lay in their hands. Jordan looked up, and for a fleeting heartbeat, their eyes locked with Taylor's, a wordless clash of wills softening into an uneasy truce.\n\nIt was a small transformation, barely perceptible, but one that Alex noted with an inward nod. They had all been brought here by different paths\n################\nOutput:\n(\"entity\"<|>\"Alex\"<|>\"person\"<|>\"Alex is a character who experiences frustration and is observant of the dynamics among other characters.\")##\n(\"entity\"<|>\"Taylor\"<|>\"person\"<|>\"Taylor is portrayed with authoritarian certainty and shows a moment of reverence towards a device, indicating a change in perspective.\")##\n(\"entity\"<|>\"Jordan\"<|>\"person\"<|>\"Jordan shares a commitment to discovery and has a significant interaction with Taylor regarding a device.\")##\n(\"entity\"<|>\"Cruz\"<|>\"person\"<|>\"Cruz is associated with a vision of control and order, influencing the dynamics among other characters.\")##\n(\"entity\"<|>\"The Device\"<|>\"technology\"<|>\"The Device is central to the story, with potential game-changing implications, and is revered by Taylor.\")##\n(\"relationship\"<|>\"Alex\"<|>\"Taylor\"<|>\"Alex is affected by Taylor's authoritarian certainty and observes changes in Taylor's attitude towards the device.\"<|>7)##\n(\"relationship\"<|>\"Alex\"<|>\"Jordan\"<|>\"Alex and Jordan share a commitment to discovery, which contrasts with Cruz's vision.\"<|>6)##\n(\"relationship\"<|>\"Taylor\"<|>\"Jordan\"<|>\"Taylor and Jordan interact directly regarding the device, leading to a moment of mutual respect and an uneasy truce.\"<|>8)##\n(\"relationship\"<|>\"Jordan\"<|>\"Cruz\"<|>\"Jordan's commitment to discovery is in rebellion against Cruz's vision of control and order.\"<|>5)##\n(\"relationship\"<|>\"Taylor\"<|>\"The Device\"<|>\"Taylor shows reverence towards the device, indicating its importance and potential impact.\"<|>9)<|COMPLETE|>\n#############################\nExample 2:\n\nEntity_types: [person, technology, mission, organization, location]\nText:\nThey were no longer mere operatives; they had become guardians of a threshold, keepers of a message from a realm beyond stars and stripes. This elevation in their mission could not be shackled by regulations and established protocols\u2014it demanded a new perspective, a new resolve.\n\nTension threaded through the dialogue of beeps and static as communications with Washington buzzed in the background. The team stood, a portentous air enveloping them. It was clear that the decisions they made in the ensuing hours could redefine humanity's place in the cosmos or condemn them to ignorance and potential peril.\n\nTheir connection to the stars solidified, the group moved to address the crystallizing warning, shifting from passive recipients to active participants. Mercer's latter instincts gained precedence\u2014 the team's mandate had evolved, no longer solely to observe and report but to interact and prepare. A metamorphosis had begun, and Operation: Dulce hummed with the newfound frequency of their daring, a tone set not by the earthly\n#############\nOutput:\n(\"entity\"<|>\"Washington\"<|>\"location\"<|>\"Washington is a location where communications are being received, indicating its importance in the decision-making process.\")##\n(\"entity\"<|>\"Operation: Dulce\"<|>\"mission\"<|>\"Operation: Dulce is described as a mission that has evolved to interact and prepare, indicating a significant shift in objectives and activities.\")##\n(\"entity\"<|>\"The team\"<|>\"organization\"<|>\"The team is portrayed as a group of individuals who have transitioned from passive observers to active participants in a mission, showing a dynamic change in their role.\")##\n(\"relationship\"<|>\"The team\"<|>\"Washington\"<|>\"The team receives communications from Washington, which influences their decision-making process.\"<|>7)##\n(\"relationship\"<|>\"The team\"<|>\"Operation: Dulce\"<|>\"The team is directly involved in Operation: Dulce, executing its evolved objectives and activities.\"<|>9)<|COMPLETE|>\n#############################\nExample 3:\n\nEntity_types: [person, role, technology, organization, event, location, concept]\nText:\ntheir voice slicing through the buzz of activity. \"Control may be an illusion when facing an intelligence that literally writes its own rules,\" they stated stoically, casting a watchful eye over the flurry of data.\n\n\"It's like it's learning to communicate,\" offered Sam Rivera from a nearby interface, their youthful energy boding a mix of awe and anxiety. \"This gives talking to strangers' a whole new meaning.\"\n\nAlex surveyed his team\u2014each face a study in concentration, determination, and not a small measure of trepidation. \"This might well be our first contact,\" he acknowledged, \"And we need to be ready for whatever answers back.\"\n\nTogether, they stood on the edge of the unknown, forging humanity's response to a message from the heavens. The ensuing silence was palpable\u2014a collective introspection about their role in this grand cosmic play, one that could rewrite human history.\n\nThe encrypted dialogue continued to unfold, its intricate patterns showing an almost uncanny anticipation\n#############\nOutput:\n(\"entity\"<|>\"Sam Rivera\"<|>\"person\"<|>\"Sam Rivera is a member of a team working on communicating with an unknown intelligence, showing a mix of awe and anxiety.\")##\n(\"entity\"<|>\"Alex\"<|>\"person\"<|>\"Alex is the leader of a team attempting first contact with an unknown intelligence, acknowledging the significance of their task.\")##\n(\"entity\"<|>\"Control\"<|>\"concept\"<|>\"Control refers to the ability to manage or govern, which is challenged by an intelligence that writes its own rules.\")##\n(\"entity\"<|>\"Intelligence\"<|>\"concept\"<|>\"Intelligence here refers to an unknown entity capable of writing its own rules and learning to communicate.\")##\n(\"entity\"<|>\"First Contact\"<|>\"event\"<|>\"First Contact is the potential initial communication between humanity and an unknown intelligence.\")##\n(\"entity\"<|>\"Humanity's Response\"<|>\"event\"<|>\"Humanity's Response is the collective action taken by Alex's team in response to a message from an unknown intelligence.\")##\n(\"relationship\"<|>\"Sam Rivera\"<|>\"Intelligence\"<|>\"Sam Rivera is directly involved in the process of learning to communicate with the unknown intelligence.\"<|>9)##\n(\"relationship\"<|>\"Alex\"<|>\"First Contact\"<|>\"Alex leads the team that might be making the First Contact with the unknown intelligence.\"<|>10)##\n(\"relationship\"<|>\"Alex\"<|>\"Humanity's Response\"<|>\"Alex and his team are the key figures in Humanity's Response to the unknown intelligence.\"<|>8)##\n(\"relationship\"<|>\"Control\"<|>\"Intelligence\"<|>\"The concept of Control is challenged by the Intelligence that writes its own rules.\"<|>7)<|COMPLETE|>\n#############################\n-Real Data-\n######################\nEntity_types: organization,person,geo,event\nText: None\n######################\nOutput:", "parameters": {"model": "gpt-4o", "temperature": 0.0, "frequency_penalty": 0.0, "presence_penalty": 0.0, "top_p": 1.0, "max_tokens": 4000, "n": null}}
It says no text provided, but I do have a txt file: root/input/input.txt
Also, regarding the max token length, which one i

Hi, can you please inspect in any of the cache entries for entity extraction and paste a result? I suspect it is an entity extraction issue.

Also, regarding the max token length, which one are you referring to? Is it for llm?

same issue !!!! any solution

Try to modify the max_token . Worked for me (I have set it to 1700 for gpt 3.5)

Hi, can you please inspect in any of the cache entries for entity extraction and paste a result? I suspect it is an entity extraction issue.

Can you provide some examples of your correct file output? thanks

I used Ollama to deploy LLM locally, and then changed the model to qwen2, and the rest remained the same. But it doesn't work with glm4

It is fine when I used qwen2.But turn to other custom model,it doesn't work

Same issue here, failed with both gpt-4o and gpt-4o-mini.
.\cache\entity_extraction is empty.
Pls advice if theres any fix or viable workaround.

Same issue here, failed with both gpt-4o and gpt-4o-mini. .\cache\entity_extraction is empty. Pls advice if theres any fix or viable workaround.
What is your embedding model? pls send me the detail log.

indexing-engine.log
logs.json
可以帮我看看我的问题吗，我用的是xinference的glm4和bge-m3模型

indexing-engine.log logs.json 可以帮我看看我的问题吗，我用的是xinference的glm4和bge-m3模型
这个报错我也一直没找到问题在哪 应该是跟用的模型有关 建议换个模型试试 我之前也碰到过类似的问题 换了模型之后就OK了

你好，具体一点
LuMF @.***>于2024年8月12日 周一16:34写道：

indexing-engine.log
https://github.com/user-attachments/files/16578251/indexing-engine.log
logs.json https://github.com/user-attachments/files/16578253/logs.json
可以帮我看看我的问题吗，我用的是xinference的glm4和bge-m3模型
这个报错我也一直没找到问题在哪 应该是跟用的模型有关 建议换个模型试试 我之前也碰到过类似的问题 换了模型之后就OK了
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/graphrag/issues/437#issuecomment-2283391156,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIAPQF7VCLIE4CEYKVDJSQLZRBXQ3AVCNFSM6AAAAABKQ3CEAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGM4TCMJVGY
.
You are receiving this because you commented.Message ID:
@.***>

我也遇到了相同的问题，求大佬帮助

indexing-engine.log logs.json 可以帮我看看我的问题吗，我用的是xinference的glm4和bge-m3模型 这个报错我也一直没找到问题在哪 应该是跟用的模型有关 建议换个模型试试 我之前也碰到过类似的问题 换了模型之后就OK了

有什么好的推荐呢？我这个情况如果不改提示词的话是可以正常运行的，修改后我不论怎么修改依然会遇到这个问题

indexing-engine.log logs.json 可以帮我看看我的问题吗，我用的是xinference的glm4和bge-m3模型

In your logs it's failing at output_df[[level_to, to]] = pd.DataFrame(graph_level_pairs, index=output_df.index)  but I can't find that line of code in the latest version 0.3.2.
The closest there is output_df[[level_to, to]] = pd.DataFrame(         output_df[to].tolist(), index=output_df.index     )

I have the same issue with ollama and qwen2.
I found that the default num_ctx=2048 is too small to produce the right response.
Then I solved the problem by setting the num_ctx=32000 of qwen2. It works for me.


AB#518 Improvement/change sdds prefix in theme

Describe pull-request

Update prefix from .sdds to sdds
Fix prefix in core packages
Remove c-dropdown css in theme light
Fix compiler import in typography
Add prefix in theme-light

Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123)
Fixes: #73  AB#518
How to test

Run build on theme
Use in storybook / angular
See everything still works
Check scss files prefix all changes

Additional context

Changing prefix in components will be on separate PR

Conflict


Integrate this repo with the integration issue tracker

Would be nice to be able to add labels so that issues here pop up on https://github.com/orgs/DARPA-ASKEM/projects/5

How does that work?

Here are the instructions: https://docs.google.com/document/d/1_RvLMZ3KZChyR02yn-EdeOJWi9QmdrzUPZYgxKp48Y4/edit?usp=sharing

This has now been added.


Node Engine concurrent map write

Short
There is a concurrency issue in the current node engine implementation.
Proposal
Stack Trace:
INFO-2023/12/14 14:48:28 ContainersManagement.go:140: Sending kill signal to mb.test.bench.test.instance.2
fatal error: concurrent map writes

goroutine 1021781 [running]:
go_node_engine/virtualization.(*ContainerRuntime).containerCreationRoutine.func2()
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:238 +0x190
go_node_engine/virtualization.(*ContainerRuntime).containerCreationRoutine(0x1268900, {0xdacca8?, 0xc000498150}, {0xdb2290?, 0xc000290630
}, 0xc000478000, 0xc001e3e180, 0xc001e3e240, 0xc00053a000, 0xce13a8)
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:305 +0x12df
created by go_node_engine/virtualization.(*ContainerRuntime).Deploy
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:115 +0x8a5

goroutine 1 [chan receive, 1378 minutes]:
main.main()
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/NodeEngine.go:54 +0x274

...
...
goroutine 1022184 [select]:
go_node_engine/virtualization.(*ContainerRuntime).containerCreationRoutine(0x1268900, {0xdacca8?, 0xc000498150}, {0xdb2290?, 0xc0004e94a0}, 0xc000478b40, 0xc000194120, 0xc000194180, 0xc0002b0000, 0xce13a8)
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:296 +0x1033
created by go_node_engine/virtualization.(*ContainerRuntime).Deploy
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:115 +0x8a5

goroutine 1022510 [chan receive]:
go_node_engine/virtualization.(*ContainerRuntime).Deploy(0x1268900, 0xc000c84a50, 0xce13a8)
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/virtualization/ContainersManagement.go:126 +0x8c5
go_node_engine/mqtt.deployHandler.func1()
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/mqtt/MqttClient.go:107 +0x8f
created by go_node_engine/mqtt.deployHandler
        /Users/giovannibartolomeo/Documents/Projects/edgeio/go_node_engine/mqtt/MqttClient.go:105 +0x23f

How to reproduce: Try scaling to 20/30 instances of the same application, and this issue will likely happen.
Solution
Investigating
Status
Looking for a solution
Checklist

[ ] Discussed
[ ] Solved
[ ] Tested

This looks likely caused by concurrent interactions with containerd sdk. This can be solved together with #264 .

Not able to replicate this issue anymore


Peek definition doesn't go to proper place

When I command-click on a method name, the peek definition will usually take me to some other object in my game that also overrides that method.
It would be great if the editor could determine the most recent place in that particular object's inheritance tree where the method was defined.
For instance:
class A: Thing
getDropDestination(obj,path) {  //code that's different from Thing// }
;
obj1: A
anotherMethod {  code;
code;
return getDropDestination(var, var); }              // <--if I click on this symbol, peek definition might take me to obj2.
// Should take me to class A's definition
;
//another source file
obj2: Thing
getDropDestination(obj,path) { //code that's different from Thing and Class A }

I agree! This definitely should be fixed!
While on this topic I have a related one:  I trying to decide how to treat modified objects. As it is now, you get a peek of all modifications, instead of just going to the most recent one. I could fix it so you'd go to the most recent one and peeking on that one the next in the chain,  but it's not obvious to me what the best user experience is here and I right now I think I prefer seeing all modifications at once.
Do you perhaps have any input on this as well?

I guess I'm not sure without trying both ways. I think that as long as everything shown is part of the clicked object's direct ancestry, it should be good. It's when "cousin" or "sibling" overrides get shown that make it confusing...


Button text one pixel off,

The text inside the button should be 1 pixel lower

Button text is off by 1px

Red is the desired design

I am moving this to Q2. I think that the only sustainable to do such fixes is if @andwah makes such adjustments directly in the CSS and makes a PR to Underwear.css and Uniform.css.

Issue moved to Starcounter/uniform.css #149 via ZenHub


Update method no longer updates wallet balance

This seems to be an issue with the latest release. After a transaction, calling the wallet's update method updates the transaction history of the wallet but the balance remains the same. It only changes after the app is restarted and/or wallet is rebuilt from keys again.

I've closed out the Fund 5 work, but let's leave this issue open for the Fund 7 refactor. The current API is not production quality, with no paging support, much less merging of data deltas. I'll look at how other frameworks handle this before I redesign the API.


AvatarModifierArea position and excludeIds problem

PROBLEM 1
A creator reported that using the following code, the avatar area ends up only covering a 3x3x3 area from the origin of coordinates:
AvatarModifierArea.createOrReplace(entity, {
            area: Vector3.create(10, 14, 10),
            modifiers: [AvatarModifierType.AMT_HIDE_AVATARS],
            excludeIds: []
        })

PROBLEM 2
Apparently the excludeIds collection is only working for one's own address and/or not for more than 1 excludeID...

Can't reproduce PROBLEM 1

There is a problem.
The exception only works if excludeIds is a constant
However, I already see the message:
"...problem is fixed with &explorer-branch=fix/sdk7-avatar-modifier-area in your local test url"

Colleagues... this is a disaster.
Option 1
Collecting a list of players: let connectedPlayers = await getConnectedPlayers({})
I collect an array from userId
and specify it as excludeIds
Does not work. We see only the first user from the list.
Option 2
I output a list from option 1 to the console, make an array constant ['0x...', '0x...']
Works!

I think I have a hypothesis...
If you do AvatarModifierArea.createOrReplace several times in a row
And at the same time, first there will be only one userId in the excludeIds array, and then two, then this does not work.
But if you immediately execute AvatarModifierArea.createOrReplace with two userids in the excludeIds array, then it works...
Maybe something is not in time?

Yes. If you do AvatarModifierArea.createOrReplace several times in a row, then only one or two of the first ones are executed, and then executing this code HAS NO EFFECT!

Problem finally solved at https://github.com/decentraland/unity-renderer/pull/5791

PR with fix merged. Will reach production in next explorer release.


no_std support

This crate looks potentially very interesting for driving color cycling LEDs in no_std environments.
A cursory review of the code shows it should basically be "no_std ready" by replacing std with core.
Are you interested in supporting no_std?

I would accept a PR for no_std support.
It's not just replacing std with core because we do some floating point math (cosines and stuff) that comes from libm and core doesn't have it.

I would accept a PR for no_std support.

Cool, I might be interested in working on one.

we do some floating point math (cosines and stuff)

Aah yes, I've had some fun times with that in the past (I wrote the micromath crate).
The libm crate works as well, it's just larger/slower. That said, it seems like the libm crate changed its API last I looked... it used to have an F32Ext trait which made it easy to drop-in in libraries that want to use libm in embedded environments or use std when available.
Not sure how you feel about a hard dependency there. micromath could still function as an optional dependency (where it would take precedence over std if you had a std feature and both were enabled)

How about using a low-order polynomial approximation for those functions in the no_std case? We're not launching a rocket here.

@dtolnay if it's just cosine you need, I can copy and paste the approximation micromath uses:
https://github.com/NeoBirth/micromath/blob/develop/src/f32ext/cos.rs

:+1: That works for me.


[1367] Remove user creation feature in the sessions controller

Context
https://trello.com/c/Oq7hCz8U/1367-remove-the-user-creation-in-the-sessions-controller
Changes proposed in this pull request
Deleting the code around creating a user, which has only been used in development, and seems to work pretty well without, since we use personas, which can be populated by using the seed rake task

 Remove the user creation in the sessions controller


change api version

Sort of. So 2.1 is your default moniker right now. So if someone searches for an API, it will show 2.1 by default when they land on the page.
But there's no versionless moniker like https://docs.microsoft.com/dotnet/api/?view=efcore. But I think it's worth bringing up to @dend. I think it's a great idea to have that. We have the same issue in our docs.

But there's no versionless moniker like https://docs.microsoft.com/dotnet/api/?view=efcore. But I think it's worth bringing up to @dend. I think it's a great idea to have that. We have the same issue in our docs.

Cool. @dend @mairaw I am happy to create an issue for this if you tell me where to do it.

They keep changing places so I'll let @dend tell you the best place for this currently,


Add unit tests to util.ToStruct

In two steps:

Moves ObjectSelector to util to prevent import cycle
Add tests to show:

Defaulting behavior
Ability to deserialize complex datatypes as ObjectSelector.

/assign @marseel

/lgtm
/approve


chore: bdd-spring-1575286793 to 0.0.1

chore: Promote bdd-spring-1575286793 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Build Optimizer] Initial load fails with enabled --build-optimizer

🐞 Bug report
Command (mark with an x)

- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
No
Description
Building my SPA with ng build --prod works well. But when I want to load it initially, it crashed. Serving with --source-map delivers the following error:

When I do not use the production flag everything works well. ng build --aot --optimization works, too - I can load the page and everything is ok.
Here is my package.json:

 "dependencies": {
    "@angular/animations": "^7.2.4",
    "@angular/common": "^7.2.4",
    "@angular/compiler": "^7.2.4",
    "@angular/core": "^7.2.4",
    "@angular/forms": "^7.2.4",
    "@angular/http": "^7.2.4",
    "@angular/platform-browser": "^7.2.4",
    "@angular/platform-browser-dynamic": "^7.2.4",
    "@angular/router": "^7.2.4",
    "@ngx-loading-bar/core": "^4.1.1",
    "@ngx-loading-bar/http-client": "^4.1.1",
    "@ngx-translate/core": "^11.0.1",
    "@ngx-translate/http-loader": "^4.0.0",
    "@swimlane/ngx-charts": "^10.0.0",
    "@types/d3": "^4.10.2",
    "@types/lodash": "^4.14.121",
    "@types/uuid": "^3.4.4",
    "angular-2-local-storage": "^3.0.0",
    "angular-gridster2": "^7.1.0",
    "angular2-ladda": "^2.0.0",
    "bootstrap": "^4.2.1",
    "classlist.js": "^1.1.20150312",
    "core-js": "^2.6.5",
    "d3": "^4.10.2",
    "font-awesome": "^4.7.0",
    "lodash": "^4.17.11",
    "moment": "^2.24.0",
    "ngx-bootstrap": "^3.2.0",
    "ngx-color-picker": "^7.3.1",
    "ngx-infinite-scroll": "^7.0.1",
    "ngx-slimscroll": "^7.1.0",
    "ngx-toastr": "^9.1.2",
    "pretty-checkbox": "^3.0.3",
    "rxjs": "^6.4.0",
    "spinkit": "^1.2.5",
    "tslib": "^1.9.3",
    "uuid": "^3.3.2",
    "web-animations-js": "^2.3.1",
    "zone.js": "^0.8.29"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.13.1",
    "@angular/cli": "~7.3.1",
    "@angular/compiler-cli": "^7.2.4",
    "@angular/language-service": "^7.2.4",
    "@compodoc/compodoc": "^1.1.8",
    "@types/jasmine": "~3.3.9",
    "@types/jasminewd2": "~2.0.6",
    "@types/node": "~8.9.5",
    "codelyzer": "~4.5.0",
    "husky": "^0.14.3",
    "jasmine-core": "~3.3.0",
    "jasmine-marbles": "^0.4.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~3.1.4",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.4",
    "karma-jasmine": "~2.0.1",
    "karma-jasmine-html-reporter": "^1.4.0",
    "karma-parallel": "^0.3.1",
    "lint-staged": "^7.2.0",
    "prettier": "^1.16.4",
    "protractor": "~5.4.2",
    "ts-node": "~7.0.1",
    "tslint": "~5.12.1",
    "typescript": "3.2.4"
  }

Would you provide a minimal repo where we can reproduce the problem?

I will try to provide a minimal Repo. But I think it could take a cupple of days.

Error in angular-2-local-storage, remove or use other library to fix problem

@quangquy87 Are you sure? We already use angular-2-local-storage since Angular 5. Everything works fine with Angular 7.2.2. Updating to Angular 7.2.3 lets the application crash at runtime with --prod

@quangquy87 Are you sure? We already use angular-2-local-storage since Angular 5. Everything works fine with Angular 7.2.2. Updating to Angular 7.2.3 lets the application crash at runtime using --prod

I am sure, I have encountered the same error and took several days to find the problem

I am sure, I have encountered the same error and took several days to find the problem

Thanks. You're right, by using angular-2-local-storage in a minimal repro-app I could reproduce the error. Nevertheless the error has only existed since Angular 7.2.3

Here is the minimal Repo that reproduces the error.
Issue #63 of the angular-2-local-storage project discusses the same error. I'm not sure if the error lays on the angular side or on the angular-2-local-storage side.

@quangquy87 I‘ve created a Pull Request to fix the Problem. A new version is already available for angular-2-local-storage.
So, the Issue can be closed.


Liquid - Error parsing the trading_pair rule

Describe the bug
Getting an Error parsing the trading_pair rule upon starting the bot when running a pure market making or avellaneda market making strategy using Liquid. Currently I don't see any impact with the bot's perfomance, creating a ticket for tracking purposes.

2021-07-19 04:49:54,068 - 16965 - hummingbot.connector.exchange.liquid.liquid_exchange - ERROR - Error parsing the trading_pair rule None. Skipping.
Traceback (most recent call last):
  File "hummingbot/connector/exchange/liquid/liquid_exchange.pyx", line 506, in hummingbot.connector.exchange.liquid.liquid_exchange.LiquidExchange._format_trading_rules
    min_order_size = rule.get("minimum_order_quantity")
AttributeError: 'NoneType' object has no attribute 'get'

Steps To Reproduce

Create and run a pure market making or avellaneda market making strategy using Liquid

Release version
v0.41.0
Attachments
Logs and config: liquid.zip
┆Issue is synchronized with this Clickup task by Unito

Connector not supported


feat(select): configurable panel max-height

Add an option to mat-select to configure panel max-height
Fixes #15803
and probably #11780, #15192 too

Add an option to mat-select to configure panel max-height
Fixes #15803

any updates on this?

@crisbeto thanks for the review
I'll try to get some time to work on this. Probably by the end of this week.

I apologize to people who got requested for review. I messed up my rebase and forced pushed before seeing commit hash had changed.
It's fixed now.
@crisbeto I've read your comments and made some modifications.
I also added some basic unit test and a bit of documentation.
Tell me if that looks good to you.

any update ?

Hi @RudolfFrederiksen , I've faced the same issue in my project.
Is there any update about this PR?

Being able to set the max-height is something we really need.
We've forced it via CSS, but that solution creates an UX bug when the  is multiple: if the user selects one of the last options, the scrollbar "jumps" and the user gets confused of what happened.
Here's a GIF with the problem: https://gyazo.com/9af65ceb203ad1ee155cf6988fdba899
So, the mat-select by default shows too litle options, but we're stuck with it.
Is there another solution for this issue?

any update ?

Any updates? Can someone please fix the conflicts and merge? We also need this on the project. Hard coded values cause issues when we try to add a "Select all" functionalty to mat select and keyboard accessiblity also breaks.

@elenachiosa this is unlikely to land, however you can try the new mat-select implementation from @angular/material-experimental/mdc-select. It has the exact same functionality, with the major difference being that we don't have to do fancy positioning with the dropdown panel so the height doesn't have to be hardcoded.
All you have to do to migrate is change the @angular/materia/select imports to @angular/material-experimental/mdc-select.

This change isn't necessary anymore since we no longer have a hardcoded panel height.


HDDS-3095. Intermittent failure in TestFailureHandlingByClient#testDatanodeExclusionWithMajorityCommit

What changes were proposed in this pull request?
Intermittent failure in TestFailureHandlingByClient happens when the datanode just stopped is not excluded during subsequent write operation.
This PR proposes to make MiniOzoneCluster wait for datanode to stop, as it already does during "restart datanode".
https://issues.apache.org/jira/browse/HDDS-3095
How was this patch tested?
Ran TestFailureHandlingByClient 20x successfully:
https://github.com/adoroszlai/hadoop-ozone/runs/497741382
and regular full CI:
https://github.com/adoroszlai/hadoop-ozone/runs/497755796
where only failure is (supposedly) unrelated in Test2WayCommitInRatis.

Thanks @bshashikant for reviewing and merging this.


Button press missed when on-screen keyboard is open while in dialog (tray) on mobile device

🐛 Bug Report
Sorry for confusing title. The reproduction is linked as a CSB example. The issue is, I have a form inside the dialog (tray) with a TextField and a Button. When the input is focused on a mobile device, the on-screen keyboard is opened and the viewport is shrunk. I can see the submit button and and would like to press it before dismissing the keyboard. But the press misses most of the time and I have to press the button again once the keyboard is gone. (It's a timing issue as far as I can see.)
It's a jarring experience as the user doesn't know why the tray is still open and if it's safe to press the button again.
🤔 Expected Behavior
The press shouldn't miss the button.
😯 Current Behavior
The press misses the button sometimes but not always, which makes it extra confusing.

💁 Possible Solution
I'm not sure how to fix it but looks like there is logic to respond to viewport size change to keep the tray where it must be and there seems to be a jump when on-screen keyboard is dismissed, which causes the button to move away. The resizing logic can be delayed just enough so the button receives the press event.
🔦 Context
I want to have a form inside a tray. I feel like this is not an uncommon case and should provide a smooth experience.
💻 Code Sample
https://codesandbox.io/s/sparkling-brook-vzngy
🌍 Your Environment

Software
Version(s)

react-spectrum
3.7.0

Browser
iOS Safari

Operating System
iOS 14.3

🧢 Your Company/Team

🕷 Tracking Issue (optional)

That's interesting, when I follow these steps:

Press Open
focus in the textfield
The keyboard comes up, but obscures the tray completely for me. I feel like that's not what should happen either.

That's interesting, when I follow these steps:

Press Open
focus in the textfield
The keyboard comes up, but obscures the tray completely for me. I feel like that's not what should happen either.

In my case the tray is pushed above by the keyboard but yours sounds even less usable. :/

In my case the tray is pushed above by the keyboard but yours sounds even less usable. :/

So the issue I was facing with codesandbox was that in their iframe mode, they use height: 100vh which is unaffected by the software keyboard. As a result, the tray never moved up. By opening the sandbox in its own window, I do see the behavior you described.
The reason for it is that onPress happens after touch up, but the text input blurs on touch start and hides the keyboard, so you guessed right.
Unfortunately this is a hard thing to fix, we can't prevent the other elements from receiving focus (accessibility no), we can't force the keyboard to stay up and we don't want to make a bunch of blank space on the bottom of the tray.
I think the best thing to do would be to refer back to our usage guidelines https://react-spectrum.adobe.com/react-spectrum/DialogTrigger.html#tray which states "Tray Dialogs are typically used to portray information on mobile devices or smaller screens."
I would read this as, no forms in Trays. Instead, I'd suggest using the fullscreen variant of dialogs.

So the issue I was facing with codesandbox was that in their iframe mode, they use height: 100vh which is unaffected by the software keyboard. As a result, the tray never moved up. By opening the sandbox in its own window, I do see the behavior you described.
The reason for it is that onPress happens after touch up, but the text input blurs on touch start and hides the keyboard, so you guessed right.
Unfortunately this is a hard thing to fix, we can't prevent the other elements from receiving focus (accessibility no), we can't force the keyboard to stay up and we don't want to make a bunch of blank space on the bottom of the tray.
I think the best thing to do would be to refer back to our usage guidelines https://react-spectrum.adobe.com/react-spectrum/DialogTrigger.html#tray which states "Tray Dialogs are typically used to portray information on mobile devices or smaller screens."
I would read this as, no forms in Trays. Instead, I'd suggest using the fullscreen variant of dialogs.


Not a PR: Issue #1007: clustered store invalidation

A few notes:

config for strong/eventual has been added
calling the Montreal Design's invalidation valve hasn't been done yet since the clustered store cannot participate in tiering yet
there are System.out calls all around the mechanism, they'll obviously be replaced with logs but for now it's handy to see the traces end-to-end when running a test
Strong/eventual discrimination (and the entire invalidation mechanism) only makes sense when clients are using the clustered store with tiering, otherwise strong is no different than eventual. Should that config be part of the tiered store instead of the clustered store? And should we add some extra logic that doesn't fire the invalidation when tiering isn't used (i.e.: 'untiered' consistency)?

test this please


duplicate method  - resource_class

Why is this method written twice - SetUserByToken concern & Application Controller
def resource_class(m=nil)
  if m
      mapping = Devise.mappings[m]
  else
    mapping = Devise.mappings[resource_name] || Devise.mappings.values.first
  end

  mapping.to
end

since SetUserByToken is included in application_controller, it automatically gets a copy of the method
and we can remove this method from application_controller

Sounds good to me. Would you like to put together a PR @chirag7jain ?

Yup ... Will do that
On Fri, Nov 6, 2015, 23:58 Brent<EMAIL_ADDRESS>wrote:

Sounds good to me. Would you like to put together a PR @chirag7jain
https://github.com/chirag7jain ?
—
Reply to this email directly or view it on GitHub
https://github.com/lynndylanhurley/devise_token_auth/issues/433#issuecomment-154493468
.

thanks!

pull request https://github.com/lynndylanhurley/devise_token_auth/pull/435

PR was closed a while ago, going to close this issue for now.


[FEATURE] CI yml file

Detailed description
When using a CI/CD (Continuous Integration/Continuous Deployment) tool such as Jenkins, Travis CI, or GitLab CI/CD, the .yml file is used to describe the steps and configurations needed to build, test, and deploy your application.
Context
Readable and easy to understand: YAML files have a simple and human-readable syntax, making it easier for developers and team members to understand the pipeline configuration.
Version control: By storing the pipeline configuration in a .yml file, you can easily track changes to the pipeline over time using version control systems like Git. This allows for better collaboration and ensures that the pipeline configuration can be reviewed and rolled back if needed.
Reusability: YAML files can be reused across different projects or branches, reducing duplication of configuration. You can define common stages, jobs, and steps in a separate YAML file and include or extend it in multiple pipeline configurations.
Possible implementation
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

please assign me under gssoc @Deepu178

@Deepu178 this issue too


Mutation filters not working

When specifying a mutation filter as per the docs, the filter does not appear in the generated schema:
@strawberry.type
class Mutation:
    updateFruits: List[Fruit] = mutations.update(FruitPartialInput, filters=FruitFilter)
    deleteFruits: List[Fruit] = mutations.delete(filters=FruitFilter)

Operating system:
Strawberry version (if applicable): 0.195.2

Hey @jaydensmith ,
I just tested here and it worked correctly.
Do you have a minimal reproduction example for this?

@bellini666 it took a lot of digging around. You must enable the following new MUTATIONS_DEFAULT_HANDLE_ERRORS setting:
STRAWBERRY_DJANGO = {
    'MUTATIONS_DEFAULT_HANDLE_ERRORS': True
}

This causes the return type to be a Union type, not a StrawberryList. So the following returns false.
https://github.com/strawberry-graphql/strawberry-graphql-django/blob/4bc135853cfa7965d286a11e2fc1782d69669894/strawberry_django/fields/base.py#L117-L123

@bellini666 aside from not being able to filter the mutation so it affects all items, it does raise an exception:
Traceback (most recent call last):
  File "/Users/jaydensmith/public_html/test/.virtualenv/lib/python3.10/site-packages/graphql/execution/execute.py", line 527, in await_result
    completed = self.complete_value(
  File "/Users/jaydensmith/public_html/test/.virtualenv/lib/python3.10/site-packages/graphql/execution/execute.py", line 612, in complete_value
    completed = self.complete_value(
  File "/Users/jaydensmith/public_html/test/.virtualenv/lib/python3.10/site-packages/graphql/execution/execute.py", line 644, in complete_value
    return self.complete_abstract_value(
  File "/Users/jaydensmith/public_html/test/.virtualenv/lib/python3.10/site-packages/graphql/execution/execute.py", line 796, in complete_abstract_value
    runtime_type = resolve_type_fn(result, info, return_type)  # type: ignore
  File "/Users/jaydensmith/public_html/test/.virtualenv/lib/python3.10/site-packages/strawberry/union.py", line 188, in _resolve_union_type
    raise WrongReturnTypeForUnion(info.field_name, str(type(root)))
strawberry.exceptions.WrongReturnTypeForUnion: The type "<class 'list'>" cannot be resolved for the field "updateInventoryItems" , are you using a strawberry.field?


Error on shared visualization with password

Steps to Reproduce

Create a map and change the privacy to "password"
Share with another user in the organization
Open the shared visualization from the other user account

Current Result

Expected result
It should open it (and without requesting the password)
@CartoDB/rt-managers

ClubHouse issue: https://app.clubhouse.io/cartoteam/story/83474/error-on-shared-visualization-with-password


Clean up update-locked-requirements and requirements.in files to remove -e hackery.

It looks like https://github.com/jazzband/pip-tools/pull/807 was included in the latest pip-tools release 12 days ago.  I think this may mean we can get rid of our semantically incorrect usage of -e in our requirements files, which in turn may mean we can remove most of the messy code in tools/update-locked-requirements related to hackily removing the -e lines.
See compile_requirements in that file for details.
My guess is that this means if we upgrade pip-tools, we can delete 50% of the code in update-locked-requirements and clean up our requirements.in files to not use -e.
@hackerkid this might be a good project for you.

@zulipbot claim


Switch encrypt bot to use send_reply

Small change to use new send_reply function, simplifying bot code & improving private chat response (with 3+ members).

Automated message from Dropbox CLA bot
@neiljp, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @neiljp!


Native dialogue window blocks remaining tests

What is your Test Scenario?

I'm trying to test our Petition Share functionality; Facebook; Twitter and Email, on different browsers.
What is the Current behavior?

During the test run, I noticed that if pop-ups are blocked (for us, the email pop-up), then TestCafé hangs here and doesn't continue to the next test.
~Now that I know this happens, we should be able to account for it in the test, however I think this is still a behavioural issue with TestCafé~
I'm unable to close this dialog, despite numerous attempts using await t.setNativeDialogHandler
What is the Expected behavior?

I would have assumed TestCafe would reset the browser for each test, thus clearing the Safari native dialogue.
What is your web application and your TestCafe test code?

Your website URL (or attach your complete example):

https://www.change.org

Your complete test code (or attach your test files):

import { t, ClientFunction, Selector } from 'testcafe';
import Chance from 'chance';

const chance = new Chance();

async function signPetitionThenReturnToPetitionShow() {
  const firstNameInput = Selector('[name="firstName"], [name="first_name"]').filterVisible();
  const lastNameInput = Selector('[name="lastName"], [name="last_name"]').filterVisible();
  const emailInput = Selector('.js-email-sign, input[name="email"]').filterVisible();

  await t
    .navigateTo('p/testcafe-for-testcafe-to-investigate-64b3ad13-9a19-4535-8986-fdcf98fee9fc')
    .typeText(firstNameInput, chance.first())
    .typeText(lastNameInput, chance.last())
    .typeText(emailInput, chance.email())
    .click(Selector('button[type="submit"]'))
    .click(Selector('.js-skip'));
}

async function assertCurrentUrlContains(url) {
  const getCurrentUrl = ClientFunction(() => window.location.href);
  await t.expect(getCurrentUrl()).contains(url);
}

fixture('Petition Show Action Panel').page('https://www.change.org/?country_code=NZ&lang=en-AU'')

test('Can share via Email on desktop if already signed', async t => {
  await signPetitionThenReturnToPetitionShow();
  await t.click(Selector('.email-share-button'));
  // Todo: Verify default mail client opens -- will vary between users
});

test('Can share via Twitter on desktop if already signed', async t => {
  await signPetitionThenReturnToPetitionShow();
  await t.click(Selector('.js-twitter-button'));
  await assertCurrentUrlContains('twitter.com');
});

Your complete configuration file (if any):

{
  "browsers": ["chrome", "firefox, safari"],
  "src": "./tests/**/*.js",

  "assertionTimeout": 10000,
  "pageLoadTimeout": 30000,
  "selectorTimeout": 10000,

  "quarantineMode": false,
  "skipJsErrors": true,

  "disablePageCaching": true,

  "reporter": [
    {
      "name": "xunit",
      "output": "artifacts/test-results/results.xml"
    },
    {
      "name": "spec"
    }
  ],

  "screenshots": {
    "fullPage": true,
    "takeOnFails": true,
    "pathPattern": "${TEST_ID}/${RUN_ID}_${FILE_INDEX}.png",
    "path": "artifacts/screenshots"
  },

  "videoOptions": {
    "singleFile": false,
    "failedOnly": true,
    "pathPattern": "${TEST_INDEX}/${RUN_ID}_${FILE_INDEX}.mp4"
  },
  "videoPath": "artifacts/recordings"
}

Your complete test report:

testcafe 'browserstack:chrome','browserstack:safari','browserstack:firefox'
Using locally installed version of TestCafe.
The "browsers" option from the configuration file will be ignored.
 Running tests in:
 - Chrome 80.0.3987.16 / macOS 10.15.0
(https://automate.browserstack.com/builds/25cab270791d3d7d42a3438330dd3d7f81c94f31/sessions/a0a13cde38e4288e6fb74c5ffe3d8ab284aea5eb)
 - Safari 13.0.2 / macOS 10.15
(https://automate.browserstack.com/builds/25cab270791d3d7d42a3438330dd3d7f81c94f31/sessions/69c7ea15a3bd351cb4308e39f06d8b5ce74920d5)
 - Firefox 73.0 / macOS 10.15
(https://automate.browserstack.com/builds/25cab270791d3d7d42a3438330dd3d7f81c94f31/sessions/9e81377dbe7e4d691b77aaf132e41b6c2ca4ee81)

 Petition Show Action Panel
 ✓ Can share petition to Facebook on desktop if already signed
 ✓ Can share via Facebook message on desktop if already signed
 ✓ Can share via Email on desktop if already signed
ERROR The Chrome 80.0.3987.16 / macOS 10.15.0 (https://automate.browserstack.com/builds/25cab270791d3d7d42a3438330dd3d7f81c94f31/sessions/a0a13cde38e4288e6fb74c5ffe3d8ab284aea5eb) browser disconnected. This problem may appear when a browser hangs or is closed, or due to network issues.

Screenshots:

<img width="1500" alt="Screenshot 2020-02-05 at 9 25 10 AM" src="https://user-images.githubusercontent.com/37812673/73869565-6120e600-47ff-11ea-8f83-e90c33b06d35.png">

Steps to Reproduce:

Go to my website ...
Execute this command...
See the error...

Your Environment details:

testcafe version:  1.7.0
node.js version: v10.15.3
command-line arguments: testcafe 'browserstack:chrome','browserstack:safari','browserstack:firefox' or just testcafe safari
browser name and version: Safari 13.0.5 / Chrome 80.0.3987.16
platform and version: macOS 10.15.3
other:

I was not able to reproduce the issue. I did not get any dialog while navigating the site. Could you please make a video of the test when the dialog appears?

I've sent the video recording to your support email address (since I'm unable to upload it here, for some reason).

Rob,
Thank you for providing your screencast. However, it's not clear what steps I should perform in order to see the dialog. Would you please provide a list of steps to reproduce the issue? Should I be registered on the site? Do I need to create a new petition? Should I sign a petition first? I don't see any similar links (Send an Email) in the existing petitions.
Also, please clarify what kind of dialog it is. Is it a native prompt/alert or confirm dialog?
P.S. To attach a screencast to the github thread, you need to zip it first.

Ahh, thanks I forgot about zipping it 🤦♂. Can you try to run the above test code using this link instead, please?
.navigateTo('p/testcafe-for-testcafe-to-investigate-64b3ad13-9a19-4535-8986-fdcf98fee9fc')

After signing the petition, you should be able to see the option to Send an email to friends

Upon clicking that link, it should open a mail client to email the petition link. It looks like the mail client is blocked in Safari (and occasionally other remote browsers) when running in TestCafe, with a native.print() object. I'm happy for this to be tracked with #2331, however the issue of this ticket is that TestCafe cannot continue when it hits this dialog, causing our regression runs to time out.
Is there a way that can reset / restart the browser if a test fails to start after x seconds?

Hello @rob4629,
I used the link but the test now fails on line .click(Selector('.js-skip')) because of the following error: There was an error submitting your signature.

Sorry for the delay on this. I've updated the testcode in the original posting. I've ran this and although a slightly different route (triggers share via email from a different page), it still highlights the issue.
I confirmed the behaviour happens on Safari... you might need to block pop-ups for it to occur in Chrome

Hello @rob4629 ,
We need additional time to research this issue. Please bear with us.

Hello @rob4629 ,
I have not managed to reproduce the issue. The test fails because of the error in a selector. Please see the attached screencast.
Could you please provide a more stable example so that we can reproduce the issue on our side?

I've created a quick app, with basic testcafe tests. This should at least highlight the issue I'm facing.
It is a simple webpage, which will launch the window.print method when a button is clicked.
https://github.com/rob4629/testcafe_issues
I've ran this locally, and testcafe always hangs at the first test (until I manually click cancel on the window print popup). HOWEVER the remaining tests don't hang, despite being duplicates 🤷♂

Thank you for the example. I've reproduced the problematic behavior. We are going to research the problem with the print dialog in the context of this issue.

Closed in favor of the https://github.com/DevExpress/testcafe/issues/2331 issue


Revamp the UI for a Modern, Interactive, and User-Centric Experience

Hi, I’d love to contribute by completely revamping the UI to enhance the overall user experience! The current UI is functional but could be transformed into something visually appealing and highly interactive. Example ideas :

Wow cool!
Create a new page Who Are We and make it there and add its link in the main page top right at the marked place

Make it responsive for all screen sizes

happy contributing!
For any doubts or the content needed to write in the page, feel free to comment here or create a new discussion here

@770navyasharma make sure to follow the theme from the main page, don't use the green theme as seen in the screenshots shared by you

Are you still willing to work on this or shall we close this issue??

Can i pick this up?

@770navyasharma Are you willing to do this or shall I assign @Supratim69  ??

@vansh-codes What's the status of this issue, i want to work on it and i'll submit this the next day after assigning this issue..

@Supratim69 Do you wanna work on this issue as @770navyasharma is not responding

Yes I'll take it up

@Supratim69 go ahead 🚀

can I get the content of this?


[BUG] 2022 menu bugged

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?
When I select 2022 menu on bloxtrap, it brings up the 2015 esc menu instead of the 2022 menu. I made sure that I had 2022 menu selected on fastflags and reinstalled my bloxtrap. The same issue still occurs. Some of my friends also are having this issue.

roblox updated prob

Hopefully it get fixed lol
Because i like the menu on the side

Roblox has removed the V2 menu.

I'll reopen this to keep myself reminded that the option needs to be removed

I'll reopen this to keep myself reminded that the option needs to be removed

Hey Mr.Pizzaboxer, is there any way you could add it back to the options instead of removing it, it was my favourite escape menu and i really got used to it, I’d be glad if you could add it if not is there a way atleast to get it back or not
thank you for your help!

There is a fast flag I found in the dev forum that can fix this problem
https://devforum.roblox.com/t/how-to-get-the-new-roblox-menu/2398925
Just ignore the steps and paste it into the bloxtrap fastflags sections as a JSON and then set your ESC menu to default it worked for me

No kidding, FFlagDisableNewIGMinDUA may have been removed but FStringNewInGameMenuForcedUserIds still works. Wouldn't have caught that, thanks for that.
Though, that means that the user needs to enter their user ID if they want this to work. Maybe.


Enhance Memory Allocator to support allocator for just i/o(data) memory #927

Describe the feature
Currently, the SDK provides the ability to specify a custom memory allocator. The same allocator is used for generic data structure allocations as well as for actual data transfers. This feature request is for adding another allocator which can be used for allocating memory for actual data transfers. For example, let's when using S3, memory for the file transfers uses this new allocator.
Use Case
Data Privacy
Proposed Solution
Add additional allocator support which is used to allocate memory when doing I/O.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Initially created this issue, wasn't sure if that repo is being monitored by anyone.

Responded on the aws-c-common issue. Closing this one


Updated typings and fixed settings/menus.ts

Build is failing because I changed gulp-shenanigans. Will fix.


Failed to create component of type for entity

Environment

OS Version: Ubuntu 22.04

Source or binary build? Binary 7.0.0-1~jammy

Generally, mention all circumstances that might affect rendering capabilities:

[ ] running on a dual GPU machine (integrated GPU + discrete GPU)
[ ] running on a multi-GPU machine (it has multiple discrete GPUs)
[ ] running on real hardware
[ ] running in virtual machine
[X ] running in Docker/Singularity
[ ] running remotely (e.g. via SSH)
[ ] running in a cloud
[ ] using VirtualGL, XVFB, Xdummy, XVNC or other indirect rendering utilities
[ ] GPU is concurrently used for other tasks

[ ] desktop acceleration
[ ] video decoding (i.e. a playing Youtube video)
[ ] video encoding
[ ] CUDA/ROCm computations (Tensorflow, Torch, Caffe running)
[ ] multiple simulators running at the same time

[ ] other...

[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [99696134570833896] for entity [50]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [5279140706653459474] for entity [50]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [8319580315957903596] for entity [51]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [99696134570833896] for entity [51]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [5279140706653459474] for entity [51]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [8319580315957903596] for entity [53]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [99696134570833896] for entity [53]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [5279140706653459474] for entity [53]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [8319580315957903596] for entity [52]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [99696134570833896] for entity [52]. Type has not been properly registered.
[gz-1] [Err] [EntityComponentManager.cc:1052] Failed to create component of type [5279140706653459474] for entity [52]. Type has not been properly registered.
[gz-1] Stack trace (most recent call last) in thread 1590630:
[gz-1] #9    Object "", at 0xffffffffffffffff, in
[gz-1] #8    Source "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S", line 81, in __clone3 [0x7f0654d849ff]
[gz-1] libEGL warning: DRI2: failed to create dri screen
[gz-1] #7    Source "./nptl/pthread_create.c", line 442, in start_thread [0x7f0654cf2b42]
[gz-1] #6    Object "/lib/x86_64-linux-gnu/libstdc++.so.6", at 0x7f0654f822b2, in std::error_code::default_error_condition() const
[gz-1] #5    Object "/lib/x86_64-linux-gnu/libgz-sim7.so.7", at 0x7f0654059675, in std::_Function_handler<bool (gz::msgs::ServerControl const&, gz::msgs::Boolean&), gz::transport::v12::Node::Advertise<gz::sim::v7::ServerPrivate, gz::msgs::ServerControl, gz::msgs::Boolean>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool (gz::sim::v7::ServerPrivate::*)(gz::msgs::ServerControl const&, gz::msgs::Boolean&), gz::sim::v7::ServerPrivate*, gz::transport::v12::AdvertiseServiceOptions const&)::{lambda(gz::msgs::ServerControl const&, gz::msgs::Boolean&)#1}>::_M_manager(std::_Any_data&, std::_Any_data const&, std::_Manager_operation)
[gz-1] #4    Object "/lib/x86_64-linux-gnu/libgz-sim7.so.7", at 0x7f06540669ba, in gz::sim::v7::SimulationRunner::Run(unsigned long)
[gz-1] #3    Object "/lib/x86_64-linux-gnu/libgz-sim7.so.7", at 0x7f0654066090, in gz::sim::v7::SimulationRunner::Step(gz::sim::v7::UpdateInfo const&)
[gz-1] #2    Object "/lib/x86_64-linux-gnu/libgz-sim7.so.7", at 0x7f0654064551, in gz::sim::v7::SimulationRunner::UpdateSystems()
[gz-1] #1    Object "/usr/lib/x86_64-linux-gnu/gz-sim-7/plugins/libgz-sim-joint-trajectory-controller-system.so", at 0x7f055450249e, in gz::sim::v7::systems::JointTrajectoryController::PreUpdate(gz::sim::v7::UpdateInfo const&, gz::sim::v7::EntityComponentManager&)
[gz-1] #0    Object "/usr/lib/x86_64-linux-gnu/gz-sim-7/plugins/libgz-sim-joint-trajectory-controller-system.so", at 0x7f05544fa31b, in ActuatedJoint::Update(gz::sim::v7::EntityComponentManager&, std::chrono::duration<long, std::ratio<1l,<PHONE_NUMBER>l> > const&)
[gz-1] Segmentation fault (Address not mapped to object [0x8])

Description

Expected behavior: Migrating from Ignition to Garden following the migration guide without issue, unless it is covered in the guide.
Actual behavior: Getting segfault and some error messages that aren't clear on what the issue is. The world file doesnt appear to have anything out of the ordinary and it all works with Ignition.

Can you provide a little more detail about the problem you're having, i.e what were you trying to do when you got the error? Is there an example SDFormat file that would reproduce the issue?


Vulkan: Light2d Blend Mode Mix does not behave correctly

Godot version
4.0.dev (fdccc0b)
System information
Windows 10, Vulkan, GTX 1070
Issue description
Setting a Light2d to Mix blend mode does not produce the expected results:
3.2.3:

4.0.dev:

Steps to reproduce

Create a scene with a background and a Light2d (point or directional).
Set the Light2d to Blend Mode "Mix".

Minimal reproduction project
Without explicitly setting it, 4.0 changes the light source back to add mode on import.
Light Mix Test 3.2.3.zip
Light Mix Test 4.0.dev.zip

I think my issue https://github.com/godotengine/godot/issues/53660 is a duplicate of this.  Same exact effect.
GameFromScratch's video showcasing 4.0 and the new lighting system worked good. So somethig must have happened (just saw it has a regression label, that's good!)

GameFromScratch's video showcasing 4.0 and the new lighting system worked good. So somethig must have happened (just saw it has a regression label, that's good!)

Indeed, the 2D lighting system broke in various ways at some point earlier this year (or last year). It would be good if someone could bisect it, although it'll require a lot of build steps (likely 30 or more).

@Calinou To my surprise, after compiling a bunch of different builds starting from March 2021, all the way back to December, 2020 (when GFS made his video). I found   the PointLight2D [issue] (https://i.gyazo.com/b2a37ba99645e79b4a897f448f1eed1c.mp4) was apparent on all. I also noticed on GFS's video he used a CanvasTexture and mapping images.
I'm not sure if Light2D was changed or if this a documentation issue and maybe PointLight2D needs to be setup differently than before. Although we should just be able to select a light texture like before, but with Vulkan and single pass lighting, there might be more the user needs to do

Although we should just be able to select a light texture like before, but with Vulkan and single pass lighting, there might be more the user needs to do

The setup process remains exactly the same, even if Vulkan and single-pass lighting is used behind the scenes.

@Calinou To my surprise, after compiling a bunch of different builds starting from March 2021, all the way back to December, 2020 (when GFS made his video). I found the PointLight2D issue was apparent on all. I also noticed on GFS's video he used a CanvasTexture and mapping images.
I'm not sure if Light2D was changed or if this a documentation issue and maybe PointLight2D needs to be setup differently than before. Although we should just be able to select a light texture like before, but with Vulkan and single pass lighting, there might be more the user needs to do

The build that still had a working 2d light system dates all the way back 28 November 2020 when it was shown in the article about godot 4.0's improvments , so I think thats a good starting point to do what @Calinou suggested

Added on to that I think it would also have the code to fix #55806

actually this didn't break - it was broken since implementation.
it still works in just the same way as when Juan posted that article and GameFromScratch made that video.
the difference is that they are using normal maps.
so this issue is really not about blend mode mix specifically, but about different behavior when omitting normal maps.

Added on to that I think it would also have the code to fix https://github.com/godotengine/godot/issues/55806

this one actually did work initially with vulkan and broke later. I've identified the commit and posted it in that issue.

I tried to fix this, but couldn't get it quite right. While mix and add blend modes look similar to what they looked like in godot 3.x, subtract looks cleary off. If anybody wants to have a look, this is the branch: https://github.com/sakrel/godot/tree/vulkan-fix-2d-light-blending

There are definitely still issues with this. In Godot 3 it looks like this:

While the same-ey setup in Godot 4 looks like this:

perhaps related to https://github.com/godotengine/godot/issues/58688?

from what I remember when creating #58688 it is the same thing

In godot3, add a CanvasModulate node, and then a PointLight2d node. Set the CanvasModulate color to black and the light will illuminate things in range, this doesn't work in godot4. The documentation is also not updated and the 2D lights don't seem to be maintained!

@PoisonousGame this should probably be under a different issue (or multiple if necessary). If there is no specific fitting issue that is already opened with a minimal reproduction project, please feel free to create one. Please don't spam other issues with copy/paste.
Also note that Godot 4 is not production ready and anyone who is leading you to believe that it is; should not be doing so. With regards to documentation, it would be an effort in futility to "update" parts of it that are still subject to change/overhaul before release.

#58688 already exists which is most likely what PoisonousGame is referring to.
it was closed as duplicate of this issue. I'm uncertain if it really is a dupe though. I think once this issue is resolved, #58688 should be reassessed again.

This commit https://github.com/godotengine/godot/commit/f123981a96c8ab7d7cb3e77ecbcf0048cb3b79e6 might contain some hints about what the issue might be.


Erroneous detection of Stack projects

Apologies as usual if this is an outdated issue or the wrong project; I'm encountering this problem via several levels of indirection (vscode haskell plugin, haskell-language-server, ...) and so I do not know exactly the infrastructure or how to detect what relevant versions of things are. I recently upgraded to NixOS 22.11 and have experienced this regression.
I have had to go back to placing this hie.yaml file in all of my repositories:
cradle:
  cabal:

My projects all have a cabal.project file, and none of them has a stack.yaml file. But the IDE has regressed to perpetually trying to use Stack, which I don't even have installed, unless this hie.yaml is present.

This is most likely caused by implicit-hie which is an additional indirection for cradle detection.
hie-bios in HLS performs no auto-detection at all.

My investigation shows that <IP_ADDRESS> was using implicit-hie <IP_ADDRESS> most likely. <IP_ADDRESS> was using <IP_ADDRESS> most likely.
The only code difference seems to be these two:

https://github.com/Avi-D-coder/implicit-hie/commit/4a0da1c2a4d928331d758c5aa91c3097c692c9f3
https://github.com/Avi-D-coder/implicit-hie/commit/25cf51837afad383f0250518b183b2276e334291

@pepeiborra

According to @Avi-D-coder, <IP_ADDRESS> and <IP_ADDRESS> are the same version, so it might be a longer standing issue even.

@chris-martin can you share your exact project or at least the whole file-tree?

Here is one example project:
https://github.com/typeclasses/ascii-char/commit/f6e082f7280795cfb88ec8316880e89d2e45b993

fish> cd (mktemp -d)
fish> git clone https://github.com/typeclasses/ascii-char.git
fish> code ascii-char

Open ascii-char/library/ASCII/Char.hs

VSCode launches and displays a popup that says:

Failed to find executable "stack" in $PATH for this Stack project.

Perhaps haskell-language-server ought to be printing version numbers for more of its dependencies.

Hard agree on that

Is this still relevant or did a subsequent release fix this?

I haven't seen the issue in a while, will reopen if it recurs.


upload form =  a new ui + with flask wtf and fixes ui and added title and description

#54 also fixed


new game doesn't reset roles

fixed in: https://github.com/voldyman/codenames.plus/commit/9c1c93e7be626f920493a70c9104fac20b3da8d3


Fix CI workflows to work with development versions of Python

This started off as part of #648, but it is conceptually an independent change, so I am splitting it off into its own commit.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2410

Relevant Lines:
2410

💛  - Coveralls


GoogleMaps: Module must be loaded as AMD or CommonJS

Hi,
I'm trying to implement the plugin: https://github.com/HeinrichFilter/systemjs-plugin-googlemaps
There was an issue which I'm trying to resolve: https://github.com/HeinrichFilter/systemjs-plugin-googlemaps/issues/6
My setup is the following:
"meta": {
    "https://maps.googleapis.com*": {
      "loader": "systemjs-googlemaps",
      "build": false,
    }
  },
map: {
    "google-maps": "https://maps.googleapis.com/maps/api/js?key=XXX&libraries=places&",
}

import GoogleMaps from "google-maps";

This works fine when running in dev-mode, but when I'm trying to build my bundle it builds a version which outputs this:
(function(factory) {
  if (typeof define == 'function' && define.amd)
    define(["https://maps.googleapis.com/maps/api/js?key=XXX&libraries=places&.js"], factory);
  else if (typeof module == 'object' && module.exports && typeof require == 'function')
    module.exports = factory(require("https://maps.googleapis.com/maps/api/js?key=XXX&libraries=places&.js"));
  else
    throw new Error("Module must be loaded as AMD or CommonJS");
});

This code immediately returns "Module must be loaded as AMD or CommonJS".
I'm wondering if this usecase would be possible with the builder, because I don't think it adds the loader-code to the bundle. And I don't think it should.
But I'm wondering if there is another way that this could still work.

When creating the static bundle, set the globalName and globalDeps options to enable the global case.

(Yes this is a documentation gap pending the builder API documentation update)

Got a small hint where these should be set?
I found this code: https://github.com/systemjs/systemjs/blob/7c2dd14b824eecea7d3252917fbc0918bc739a2c/dist/system.src.js#L3528
Do I have to set them in the plugin or in the config?
I tried this:
"meta": {
    "https://maps.googleapis.com*": {
      "loader": "systemjs-googlemaps",
      "build": false,
      "format": "global",
      "globalName": "google-maps",
      "globalDeps": []
    }
  },

But I don't think that's what you mean.

Oh, so are you using jspm? In that case it is jspm bundle-sfx x --global-name x --global-deps "{'https://maps.googleapis.com/maps/api/js?key=XXX&libraries=places&.js':'google.maps'}" (whatever the google maps global will be in the production environment).

No, I'm using systemjs builder. But it has to go through the systemjs-plugin-googlemaps plugin first before I can load it, because it needs a callback. So I don't think I can load is as just a global dependency.
There are other ways that I can load it in, like you say as a global and include the callback in the url. But the plugin makes it possible to not have to have the callback.

@happylinks theres many ways of looking at this:

Do a normal bundle not an sfx bundle, and use SystemJS and the plugin config in production.
Continue to do an sfx bundle, but load it itself with SystemJS in production with the plugin dependency
Look at ways of supporting this plugin in builds, posting an issue to the plugin. Because it relies on an external API, that would likely be by assuming some kind of API global to work with, but will be tricky to implement due to this async nature.


Fix for cache problem when used as widget

Fix for issue report https://github.com/PrestaShop/PrestaShop/issues/14423

This change is

Hello @iqit-commerce
Thank you for this contribution :)
The price slider is not visible anymore

@sarahdib
It is not related, rang sldier is not visible becouse you put it as widget withoit removing it from left column, so now it is duplicated, If you unhook from left column so you will have only one instance then it will be ok

Ok that was the only problem the PR is ok for me :)
Thank you

Thanks @iqit-commerce


[INLONG-10053][Sort] Support flink-connector-pulsar based on flink 1.18

Fixes #10053
Motivation
Add support of pulsar connectors for flink 1.18
Modifications

create new modules for connectors-v1.18 and connector-pulsar-v1.18
make sure PulsarTableOptions is compatible with PulsarExtractNode

Verifying this change
(Please pick either of the following options)

[x] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (no)

 please add a assemble file for this connector

Thanks for your suggestion.
I planned to add assembling works in a separate pull request, see #10057.
Processing the assembling and GitHub workflow in this pull request makes sense to me also.
Will add soon.

TODO: support audit metrics when receiving messages

I'll bring another pull request  to deal with audit metrics.

@aloyszhang please update the licenses.


Adds support for

Adds the support for parsing and writing Asynchronous Server Call Points as specified in the AUTOSAR 3 and 4 standards.

 Support for ClientServerOperations in ARXML


Bookmark + Sync plugins: Fix bookmarks sort order

Questions

Am I the only one having issues with the sort order of bookmarks getting lost?
Does the solution below seem like a reasonable one?

Aim: Display the bookmarks and folders in Alphabetical order.
Summary
Currently, when using the Bookmarks plugin along with the Sync plugin, and I sync my bookmarks between two devices, the order of the bookmarks (and folders) gets lost, and everything ends up in random order.  I would much rather have the bookmarks (and folders) sorted in alphabetical order.
Detailed Problem Description
I have IITC installed on my laptop and my android tablet, and have the bookmarks and sync pugins installed on both.  When I do the following steps I end up with badly sorted bookmarks:

I add some bookmarks on my laptop
I manually drag them into an order that I like
I sync the bookmarks to my tablet
I add a bookmark on the tablet
I sync the bookmarks back to my laptop
Restart IITC on both

By the end of step 6, my bookmarks on both the laptop and tablet end up being in random order - not alphabetical, and not what I manually dragged them to be.  I find this annoying.
Detailed Solution
I can see a few options on how to fix the ordering of bookmarks.  The obvious solution is store and sync the sort order of bookmarks.  I don't like this solution, because I hate manually sorting things (and it doesn't work on my tablet).  I vastly prefer everything to be alphabetical because it's less effort, and that way it matches the ingress app.
So, I think when displaying the Bookmarks list, the folders and bookmarks should just be sorted alphabetically before they are rendered.

I'm also encountering the same issue.

Can you give specific examples of how the sort order changes?  Preferably limited to 3 or so portals.  You can export the bookmarks to make a backup, then in Ingress, delete portals until you get a small set that demonstrates the problem, export that list and attach it here.  Then use your original backup to restore your list.
Surprisingly, in computer science, sorting is hard.   Settings on the computer could be responsible for different sort orders.
For example:
Original unsorted file
$ cat t.txt
Cake
Apple
CUcumber
banana
a natural sorting based on locales
$ LC_ALL=en_US sort t.txt
Apple
banana
Cake
CUcumber
Old standard sorting based upon byte values of characters
$ LC_ALL=C sort t.txt
Apple
CUcumber
Cake
banana
Start throwing in characters outside the ASCII character set (basically anything outside of a-zA-Z and so on), and you have all sorts of issues.   Different languages, even different countries, have different sorting orders.  And likely by default, your browser probably uses whatever your system default is.  Given two different computers, particularly if they may be of different generations and came up through different upgrade paths, maybe even different operating systems, and you could have different settings, thus different results.

@nexushoratio Yep, from what I can see there is no sorting implemented in the code - it's not a character-set issue.  I'm surprised that I'm the first to find it a problem.
I've made a pull request with the sorting (and made it optional so I don't break anybody's setup).  See https://github.com/jonatkins/ingress-intel-total-conversion/pull/1015.

I'm having this issues as well. I'll sort my bookmarks manually. However, when I refresh my browser, the bookmarks go back to their original (old) order and I lose my manual sort.


[Snyk] Upgrade org.apache.maven.plugin-tools:maven-plugin-annotations from 3.14.0 to 3.15.0

Snyk has created this PR to upgrade org.apache.maven.plugin-tools:maven-plugin-annotations from 3.14.0 to 3.15.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 23 days ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

/ok-to-test


Update and rename lib/domains/info to lib/domains/info/fshnstudent/fshn....

...txt
The email domain for the student at the Faculty of Natural Sciences at University of Tirana is @fshnstudent.info

Adding the email domain of the student at the Faculty of Natural Sciences at University of Tirana

Should be lib/domain/info/fshnstudent.txt.

@elephantsy Flagging as stale.

@pchaigno & @lyzidiamond thank you guys for closing the request and sorry for being inactive.


[Feature]: Authorize and associate a Shopify embed app or extension with a Partner account or organization without having to run shopify app dev or shopify app deploy

What area(s) will this request affect?
App, Extension, Running your code locally
What type of change do you want to see?
New feature
Overview
I want to create an embed application or an extension, and at the same time creating a new app on the Shopify Side (associated with my Partner account or organization) with associating the project with it.
In that case it could be helpful to have additional flags for it.
Motivation
I have a custom code which makes the process of creating and then modifying the apps with Shopify CLI easier. In that case I have to follow these steps:

Create a new embed app with yarn create @shopify/app --template node

Use yarn shopify app dev to run it for the first time, to authorize with browser.
According to Shopify Dev documentation, this command (or yarn shopify app deploy) creates a new app associated with my Partner account or organization and associate my local app with it.

https://shopify.dev/docs/apps/tools/cli/commands#dev
https://shopify.dev/docs/apps/tools/cli/commands#deploy

Then I request the env variables (the Shopify key && the secret key) for the new app using yarn shopify app env pull.

So the questions:
a) Is there any opportunity to log in with Shopify CLI on the first step, when creating the app? In that case we would use the same flags (--api-key, --tunnel-url, --store) as for the yarn shopify app dev command.
b) In the case I am logged in, is there any opportunity to create a new app associated with my Partner account or the organization immediately when creating i.e. embedded app with yarn create @shopify/app --template node? In that case the additional flags could be needed.

Hi @vlad-mb!. First of all, thank you for your proposal.
The create-app operation has been designed to be an unauthenticated command intentionally. The main objetives of that are:

Quick operation to scaffold as quick as possible a new application
Working with the app without having to create a partners account

That's why the cli delay the authentication process to the commands that really need to connect to a remote app. And it's at that point when the user can create a new application to associate to your local app
I hope that this explanation make sense to you. Anyway, please, feel free to add more context to this requirement just in case we are missing something.
Looking forward to hear from you soon.


Useless call to SSL_CTX_check_private_key()  in apps\lib\s_cb.c

Hi,
May I assume that, In apps\lib\s_cb.c, the call to SSL_CTX_check_private_key() inside set_cert_key_stuff() (line 170) is useless because in case of unmatched key, the error will be raised during the previous call of SSL_CTX_use_PrivateKey() (line 161) ?
Or am I missing something ?

OK, thanks for confirmation.