Create MySQLPool.release/register(Prepared)

Is this even possible? MySQLPool doesn't actually hold references to any of the connections. And even if it did, it couldn't use them because they may be owned by another fiber.
And anyway, I'm not certain this is all that important a feature after all.

Clarification: MySQLPool.register is totally implementable and worthwhile. MySQLPool.release is questionable in both ways.


i18n(fr): update reference/configuration.mdx

Description
This PR updates the French version of the reference/configuration.mdx page with the changes of #1620.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
reference/configuration.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


add documentation and ex build.provenance

Added examples/build.provenance
Added example yaml to use it

Closes Issue #2

Thanks!


typechecker should prevent redefinition of type names

Currently it seems like the second definition just gets ignored?

In PR #416


[Feature Request] Add iPhone 8-style fast app switching.

Hi,
Please allow us to reactivate the fast app switching behavior that is present on the iPhone 8 and earlier where you 3D-Touch on the left side of the screen.
Thanks!
Best Regards,
Iskren

This 3D-Touch behavior is not needed with the iPhone X gestures enabled, as you can just swipe on the bottom portion of an app to move throughout the app switcher. A video of this working can be found here, (33 seconds in) : https://www.youtube.com/embed/0-kZrK3RtGA?start=33


Release v0.15.6

[x] Update tzf-rs, with 2024b data.  https://github.com/ringsaturn/tzf-rs/releases/tag/v0.4.9
[ ] Support Python 3.13 Switch to use ABI

https://github.com/ringsaturn/tzfpy/releases/tag/v0.15.6


fix config install dir

Codecov Report

Merging #4387 into master will increase coverage by 0.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
+ Coverage   88.35%   89.32%   +0.96%
==========================================
  Files         781      636     -145
  Lines       98748    87346   -11402
  Branches     1251        0    -1251
==========================================
- Hits        87250    78019    -9231
+ Misses      11262     9327    -1935
+ Partials      236        0     -236

Impacted Files
Coverage Δ

go/arrow/ipc/writer.go

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/ipc/file_reader.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

go/arrow/type_traits_boolean.go

js/src/ipc/node/writer.ts

... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184b8de...bacfdaf. Read the comment docs.

@slug thank you for the fix.  Could you file a JIRA at https://issues.apache.org/jira/secure/Dashboard.jspa and put it in the title of the pull request (more details here.  Essentialy: ARROW-: [C++][CMake] Use cmake header install directory instead of XXX.


Automatically delete attachments when notification is deleted

This is done. I now delete attachments for notifications that have been deleted in the DeleteWorker, which runs every 8 hours.


Illegal bishop, pawn, rook configuration

Sherlock doesn't detect this position as illegal: 4k3/8/8/8/8/4P3/1K1PRP2/4b3 b - -

The bishop, pawn, rook configuration at the bottom is illegal.

Very nice!
I cannot think of a simple general rule to capture this.
Any ideas?

I hard coded some illegal configurations like this one in Retractor (issues 40 through 43), but soon you discover there are endless such configurations.
I developed a more general method of cages, but it is not fully automated. It requires the user to specify the squares containing the illegal configuration of interest, and then the algorithm verifies that the configuration is illegal. Not all illegal configurations can be verified by the algorithm, but many can. Probably there are some heuristics that one could implement to find cages, but I have not worked on that.

I think we can solve all these situations with the same technique I used for https://github.com/miguel-ambrona/D3-Chess.
Namely, it is like the "steady" concept, but instead of "not steady unless proven otherwise" we go for "not mobile unless proven otherwise".
That is, for every piece on the board, we try to see if it can retract to an empty square, or to a square where there is a piece that can retract somewhere else (leaving the square empty). After saturating that logic, we'll end up with pieces that certainly cannot retract. If any of these pieces is not in their original square, the position is illegal.


Final polish of Matplotlib content

With the recent merge of #230 and #230 our Matplotlib content is relatively mature and complete.
I'm noting here that this section could use a final read-through and polish with an eye toward consistency across the three notebooks, as well as the landing page (which still says "under construction" as I noted in #231).

Landing page was fixed in #235
I'll make one last pass through these notebooks to fix up a few inconsistencies.


Notified when device is disconnected?

In my application I would like to get notified if the device gets disconnected.
The underlying python-can package calls a listener's on_error() method when a error occurs on the receive thread. I wonder about adding an on_error() method override to the MessageListener class and allow users of python-can-j1939 to provide an on_error() override.
Thoughts?

When I looked at this class ElectronicControlUnit code from here
        #: Includes at least MessageListener.
        self._listeners = [MessageListener(self)]

I wondered whether someone had intended to someday support add_listener and remove_listener functions for modifying the _listeners collection (similar to how we already have add_timer and remove_timer provided already by this class for modifying the _timer_events collection).  If we did so, it might meet your need too @pmoosman ?
An advantage of allowing new, different listeners to be added is that the MessageListener class itself does certain things that might not in-general be wanted, e.g. it drops any error frames on the floor, in this line.
The python-can package has some nice-looking listeners - it would be great to be able to add one of those stock listeners, or for someone to add their own custom listener, into the _listeners collection under some circumstances.

I have been experimenting some more with adding/removing arbitrary python-can listeners.  Below is an approach that will allow us to very easily add a stock listener - such as a listener that will save a transcription of all of the CAN traffic to a file for later analysis, which would be as easy as add_listener(can.Logger("EverythingThatHappened.asc")) - or a custom listener we might have written. Using similar technique and a custom listener, it should be possible to easily add a listener that responds in some desired way to any CAN errors that occur.
class MultiListenerECU(j1939.ElectronicControlUnit):

  def add_listener(self, listener):
    self._listeners.append(listener)
    if self._notifier is not None:
      self._notifier.add_listener(listener)

  def remove_listener(self, listener):
    self._listeners.remove(listener)
    if self._notifier is not None:
      self._notifier.remove_listener(listener)

But I also think that, better than the above sub-classing workaround, it would be convenient to have these add_listener and remove_listener functions added to the ElectronicControlUnit class itself.  But also unit tests to prove it out, and to demonstrate some typical usage scenarios.  Maybe the subclassing idea might be of some help in the meantime @pmoosman ?


Add Appveyor and Scrutinizer builds

https://scrutinizer-ci.com
https://ci.appveyor.com

Instead of appveyour add new tab with Travis CI stats.


The Japanese text is displayed strangely

The Japanese text is displayed strangely.
code:
window('こんにちは') {
  area {
    text {
      string("こんにちは\n") {
        font family: 'Osaka', size: 20
        color :white
      }
      string("おはようございます。\n") {
        font family: 'ヒラギノ角ゴシック', size: 20
        color :white
      }
      string("おはようございます。\n") {
        font family: 'Arial', size: 20
        color :white
      }
    }
  }
}.show

screenshot:

ruby 3.3.5 on macOS 14.6.1

@kojix2 you have used Glimmer DSL for LibUI in Japanese, so you might know how to handle this issue. If there is an issue to report to the upstream project libui-ng, could you please report it?
BTW, I confirm the issue locally. What is happening is the text in every string (attributed string) is getting split between two parts of text. The first part of the text is showing up normally according to the font and color of the attributed string. The second part of the text is showing up as black (default color) and in a different front (default font). It seems like the attributed string is not getting processed for the full String argument that is passed in for some reason. This might be a bug in libui-ng in Japanese.

I see. I will do that.

Actually, I was talking to @kojix2 because he’s Japanese too. He built the LibUI Ruby binding that is utilized by Glimmer DSL for LibUI. We might run a few tests and verifications first before reporting to libui-ng (the C library utilized by Glimmer DSL for LibUI).
So, you don’t need to do anything for now @junogura

Hello Andy and Ogura,
I tested this issue.
At first, I thought it was a problem specific to macOS, but the same issue happened on Ubuntu.
Then, I considered that the problem might be with Glimmer DSL for LibUI.
However, the same problem occurred with a C language code that does the same thing.
I also found that the issue happens in many non-alphabet languages, not just Japanese.
Is this a serious bug?
I found it might not be. The documentation for ui.h says the following:
// uiAttributedStringSetAttribute() sets an attribute in the byte range [start, end)
// of the string s. Any existing attributes in that byte range of the same type are
// removed. The string s takes ownership of the attribute a; you should not use it after
// uiAttributedStringSetAttribute() returns.
_UI_EXTERN void uiAttributedStringSetAttribute(uiAttributedString *s, uiAttribute *a, size_t start, size_t end);

uiAttributedStringSetAttribute() sets an attribute in the byte range [start, end) of the string s.

That is, this function takes a byte range as an argument, not the index when the string is viewed as an array.
In some languages, the number of characters does not match the byte range because some characters use more than one byte, especially in languages with multi-byte encodings like UTF-8.
I think this could be the reason for the issue.

Fork the repository, then
git clone https://github.com/your_name/glimmer-dsl-libui
ruby -pi -e<EMAIL_ADDRESS>"@string.bytesize")' glimmer-dsl-libui/lib/glimmer/libui/attributed_string.rb
cd glimmer-dsl-libui
git checkout -b bytesize
git commit -m "Use `bytesize` instead of `size` for attribute setting"
git push origin bytesize

Then create a pull request.
Not sure if this is enough :man_shrugging:

I tried  that chage.
It looks good.

But, I couldn't push changes.
I don't have permission to do this.

» git push origin bytesize
ERROR: Permission to AndyObtiva/glimmer-dsl-libui.git denied to junogura.
fatal: Could not read from remote repository.

@junogura
You will need to fork the repository first.

If you are not familiar with GitHub and would like to read the Japanese explanation, the following blog post will be helpful.
【超図解】OSSにPull Requestを出す時の備忘録

I did it.
I have used github only personally untill now.

@junogura Thanks a lot for the fix in PR #68! It makes total sense as to why the bug happened. I will test it and merge the code as soon as I have a chance.

@junogura the fix has been tested and released in glimmer-dsl-libui gem version 0.12.4:
https://rubygems.org/gems/glimmer-dsl-libui/versions/0.12.4
Thank you for the PR.

git commit -m "Use bytesize instead of size for attributed setting"

Maybe the commit message should have been "attribute setting" or "attributed string" instead.
Just demonstrating that it's okay if you're not great at English when contributing to OSS. :sweat_smile:

Maybe the commit message should have been "attribute setting" or "attributed string" instead. My bad.
Just demonstrating that it's okay if you're not great at English when contributing to OSS. 😅

No big deal. I just reworded the commit to attributed string while keeping the original author name on it.
https://github.com/AndyObtiva/glimmer-dsl-libui/commit/06ac9d41ca159fc8e28b2342899990ca20f7fc16


remove middleware component from BotState, rewrite some tests

Pull Request Test Coverage Report for Build 1365

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 69.822%

Totals

Change from base Build 1359:
-0.01%

Covered Lines:
2228

Relevant Lines:
3047

💛  - Coveralls


[BUG][Functional] Fortinet defaulting to DNS over TLS (DoT) which isnt supported

Bug reports which fail to provide the required information will be closed without action.
Required Basic Info

Accelerator Version:  release/v1.5.5
Install Type: upgrade
Upgrade from version: N/A

Describe the bug
The DNS config  needs updating to explicitly set the used protocol to “cleartext” ie. set protocol cleartext
Recent fotigate versions enable DNS over TLS (DoT) as default which is not supported by R53 on the local local EC2 <IP_ADDRESS> endpoint. The confg should be updates to explicitly set non encrypted DNS. This can be achieved via the config
set protocol cleartext

Failure Info

DNS on the Fortigate does not work
Any ping command to any public domain fails to resolve i.e. sudo root execute  ping www.google.com
Fortigate licenses are unable to be verified

Steps To Reproduce

Upgrade fortinets to version 7.0.9 or above and attempt to perform DNS resolution via sudo root execute  ping www.google.com
DNS resolution will fail
Change dns config using

config system dns
set protocol cleartext
end

Reattempt DNS resolution and it will work sudo root execute  ping www.google.com

Expected behavior
DNS resolution should work by default
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
See note from Fortinet 7.0.9 release notes re DoT

If both primary and secondary DNS servers are set to use the default FortiGuard servers prior to upgrading, the FortiGate will update them to the new servers and enable DoT after upgrading. If one or both DNS servers are not using the default FortiGuard server, upgrading will retain the existing DNS servers and DNS protocol configuration.

FYI - for a new deployment, Fortinet 6.x is required and what we were still having customers deploy, Fortinet 7.x has been reported to not auto-bootstrap - root cause yet TBD.


Control Size on Root Drive

Right now it looks like there is no setting to control the size of the root volume.

Multiple users have asked for this. Added to the backlog.

+1 on this. The workaround that I am using right now is that based on the original cfncluster AMI I created a new one with increased root partition that I boot up using the custom_ami option.

+1 here. I'd like to avoid creating custom AMIs if possible since it would no longer follow the cfn-cluster update cycle. I understand that expanding the root AMI size by default for all users would affect larger scale users by increasing costs so having a cluster parameter that expands the volume automatically on initialization would be a nice feature.

This has been released as part of v0.0.22. You can specify master_root_volume_size and compute_root_volume_size as part of the cluster config section.
http://cfncluster.readthedocs.org/en/latest/configuration.html#master-root-volume-size


Fixing typo in filename

While working through the docs I noticed the link to client_secrets.json documentation was giving a 404. The issue was the filename in git is client-secrets.md not client_secrets.md.
Thanks for these docs, I'm finding them really helpful!

@nloadholtes Thanks very much for the patch!


Error creating EKS cluster: "Subnets specified must be in at least two different AZs"

Hi, I'm getting the following error when I run terraform apply:
...
module.eks.aws_eks_cluster.this[0]: Creating...
module.vpc.aws_route.public_internet_gateway[0]: Creation complete after 1s [id=r-rtb-042a10a1739725ed81080289494]
module.eks.aws_security_group_rule.cluster_egress_internet[0]: Creation complete after 2s [id=sgrule-2533592964]
module.vpc.aws_nat_gateway.this[0]: Still creating... [10s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [20s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [30s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [40s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [50s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m0s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m10s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m20s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m30s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m40s elapsed]
module.vpc.aws_nat_gateway.this[0]: Still creating... [1m50s elapsed]
module.vpc.aws_nat_gateway.this[0]: Creation complete after 1m52s [id=nat-000de1c223f41705a]
module.vpc.aws_route.private_nat_gateway[0]: Creating...
module.vpc.aws_route.private_nat_gateway[0]: Creation complete after 2s [id=r-rtb-0ea83ee2af36697aa1080289494]

Error: error creating EKS Cluster (rudder-cluster): InvalidParameterException: Subnets specified must be in at least two different AZs
{
  RespMetadata: {
    StatusCode: 400,
    RequestID: "8bd93564-c25e-4f7b-a647-82a2f7a1150c"
  },
  ClusterName: "rudder-cluster",
  Message_: "Subnets specified must be in at least two different AZs"
}

Not being familiar with Terraform, I was able to work around it by modifying variables.tf to set rudder_num_availability_zones to 2, though this creates two nodes and I really only want one for now.

Hi @kevinavery which variables.tf file did you input this variable? I'm getting  Error: Unsupported argument

@tbernacchi See here https://github.com/rudderlabs/terraform-aws-eks/blob/master/variables.tf#L87


Switch to standalone application

Moved from https://github.com/osiam/resource-server/issues/45 & https://github.com/osiam/auth-server/issues/25:
After switch to Spring Boot fat war has been solved (it is!), we can move on with the plan and finally switch to a standalone, runnable .jar deployment. This does not contain switching to YAML files, which will be done in a separate step.

This won't happen.


Risk detections above do not match the list under riskeventtype from MS Graph

According to the article above there are 18 risk detections, but according to the riskeventtype property under MS graph there are less (see below). Can someone explain the discrepancy?
unlikelyTravel, anonymizedIPAddress, maliciousIPAddress, unfamiliarFeatures, malwareInfectedIPAddress, suspiciousIPAddress, leakedCredentials, investigationsThreatIntelligence, generic,adminConfirmedUserCompromised, mcasImpossibleTravel, mcasSuspiciousInboxManipulationRules, investigationsThreatIntelligenceSigninLinked, maliciousIPAddressValidCredentialsBlockedIP, and unknownFutureValue
https://docs.microsoft.com/en-us/graph/api/resources/riskdetection?view=graph-rest-beta#properties

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81a1385f-b90a-e7b4-8cbd-f25aeb8b3c49
Version Independent ID: d468eb75-88a9-b1aa-7fb3-19ebb4faa179
Content: What is risk? Azure AD Identity Protection
Content Source: articles/active-directory/identity-protection/concept-identity-protection-risks.md
Service: active-directory
Sub-service: identity-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@ivratche Thank you for your inputs. We will investigate and update the thread.

@ivratche This is because beta MS graph API does not exposes some detections. There are certain detections which are deprecated like "Malware linked IP address" and some of them are similar hence you do not see all of them in the list . Ideally we do not recommend to use the beta graph API and they are subject to change and are only recommended for testing . As we go ahead we continue to update the risktypes available through Graph API . You may also see one called unknownFutureValue which may be subject to change.
Thank you .

API doc updated to include UI Detection name https://docs.microsoft.com/graph/api/resources/riskdetection?view=graph-rest-1.0#riskeventtype-values


Missing 2 required positional arguments: 'confidence' and 'raw_value'

Installed latest version:
Ideas ?
[ERROR:2020-04-02 16:25:57,676] rhasspyserver_hermes: on_message Traceback (most recent call last):   File "/usr/lib/rhasspy-voltron/rhasspy-server-hermes/rhasspyserver_hermes/__init__.py", line 910, in on_message     topic, payload, self.subscribed_types   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/client.py", line 259, in parse_mqtt_message     message = message_type.from_dict(json_payload)   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/nlu.py", line 92, in from_dict     message.slots = [Slot.from_dict(s) for s in slot_dicts]   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/nlu.py", line 92, in <listcomp>     message.slots = [Slot.from_dict(s) for s in slot_dicts]   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/intent.py", line 82, in from_dict     slot = Slot(**object_dict) TypeError: __init__() missing 2 required positional arguments: 'confidence' and 'raw_value' [ERROR:2020-04-02 16:25:57,606] rhasspyserver_hermes: on_message Traceback (most recent call last):   File "/usr/lib/rhasspy-voltron/rhasspy-server-hermes/rhasspyserver_hermes/__init__.py", line 910, in on_message     topic, payload, self.subscribed_types   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/client.py", line 259, in parse_mqtt_message     message = message_type.from_dict(json_payload)   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/nlu.py", line 92, in from_dict     message.slots = [Slot.from_dict(s) for s in slot_dicts]   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/nlu.py", line 92, in <listcomp>     message.slots = [Slot.from_dict(s) for s in slot_dicts]   File "/usr/lib/rhasspy-voltron/rhasspy-hermes/rhasspyhermes/intent.py", line 82, in from_dict     slot = Slot(**object_dict) TypeError: __init__() missing 2 required positional arguments: 'confidence' and 'raw_value'

Can you describe your config a bit more? Are you using Docker or virtual environment?
I'm hoping this will be fixed by the end of the day either way.

I am using docker version. At the moment I am running latest stable with Snips environment and testing 2.4 version. This problem related to 2.4, because previous version works ok. Here is my config :
{     "command": {         "system": "hermes"     },     "dialogue": {         "system": "hermes"     },     "intent": {         "fsticuffs": {             "fuzzy": false         },         "system": "fsticuffs"     },     "microphone": {         "system": "hermes"     },     "mqtt": {         "enabled": true,         "host": "<IP_ADDRESS>",         "publish_intents": false,         "site_id": "basement"     },     "sounds": {         "system": "hermes"     },     "speech_to_text": {         "system": "kaldi"     },     "wake": {         "system": "hermes"     },     "rhasspy": {         "listen_on_start": false     } }
Thank you.


missing quote_field_suffix in simple_query_string

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[X] elastic.v6 (for Elasticsearch 6.x)
Please describe the expected behavior
The following code should be valid:
main() {
	ID := "1234"
	q := elastic.NewSimpleQueryStringQuery(`"` + ID + `"`)
	q.Field("items.id")
	q.Field("discounts.id")
	q.QuoteFieldSuffix(".exact")
	//...
}

Please describe the actual behavior
SimpleQueryStringQuery doesn't implement QuoteFieldSuffix()
Any steps to reproduce the behavior?
The code above.
Refer to https://www.elastic.co/guide/en/elasticsearch/reference/master/mixing-exact-search-with-stemming.html for another example of a valid query.

Yep. That makes sense. Thanks for letting me know.


Increase melee range

Problem
Currently the melee range constant is 24, which is 2 * PIECE_RADIUS which means two pieces need to be exactly touching to be in melee range. This itself isn't a problem, but it makes things a bit less flexible and also makes drawing melee attack order arrows pretty janky, as we would have to overlap.
Solution
Bump melee range up to 50, giving pieces some wiggle room to be able to reach the enemy without literally touching them.
Sample screenshot when melee range is 50:

@louiswheeleriv - do my changes make sense? Should be good to go.


[Feature] About supporting the format file of EC when using BrokerLoad to sync data from hdfs to doris

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
hdfs file has used EC police
BrokerLoad Error:
         JobId: 31095590
         Label: xx
         State: CANCELLED
      Progress: ETL:N/A; LOAD:N/A
          Type: BROKER
       EtlInfo: NULL
      TaskInfo: cluster:N/A; timeout(s):14400; max_filter_ratio:0.01
      ErrorMsg: type:LOAD_RUN_FAIL; msg:ParseError : Bad read of hdfs://nsxx
    CreateTime: 2022-07-08 15:19:28
  EtlStartTime: 2022-07-08 15:19:30
 EtlFinishTime: 2022-07-08 15:19:30
 LoadStartTime: 2022-07-08 15:19:30
LoadFinishTime: 2022-07-08 15:20:41
           URL: NULL
    JobDetails: {xx

after:
hdfs ec -getPolicy -path hdfs://ns10xx
then:
RS-6-3-1024k
Use case
RS-6-3-1024k
Related issues
RS-6-3-1024k
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[ ] I agree to follow this project's Code of Conduct

Is it possible to support by using BrokerLoad?


Fix: Double bracketing in reported assertion.

As a side-effect #1, when an assertion fails, it is reported like
tests/main_test.cpp:28: FAILED:
	REQUIRE((1 == 0))

with two sets of brackets. This is because __VA_ARGS__ is passed to CATCH_MINI_TEST with brackets, and the brackets are included in the macro expansion.
This misreporting can be confusing, as the user's expectation is that it reports the exact line of code they've written for that assertion.
The fix is easy - simply don't print our own set of brackets.

Better that way, thanks.


Large shaders difficult to edit because of live recompile interruptions

Godot version:
3.1.1 win64 (Classical)
OS/device including version:
Windows 10 Pro, Intel i7-4790K, integrated GPU only (Intel HD Graphics 4600), driver igdkmd64.sys version <IP_ADDRESS>58
Issue description:
With a GLES2 fragment shader of about 2,000 lines, I find the interruptions due to live recompile (and parsing?) to be annoying.  I would prefer to have an option to turn off this behavior so I can recompile/parse only when desired and otherwise have the editor window behave like a simple text editor.  I looked in the editor and project settings, but could not find a way to do this or at least greatly increase the delay before recompile/parsing to permit longer pauses in typing.
The problem is not only that there the editor window freezes, but that sometimes keystrokes I made after the freeze began, before I noticed the freeze, are not remembered by the editor and are lost, leading to typos if I am not careful.
I realize that most shaders are probably small enough that this is not a problem, but it would be a great "quality of life" improvement for me.  An alternative is to use a separate editor and copy/paste when I want into Godot's editor window, but I'd prefer to do everything in Godot if possible.
Thanks for considering.

With a large shader, even moving around in shader editor (by arrow keys or mouse) gets laggy.

I looked in the editor and project settings, but could not find a way to do this or at least greatly increase the delay before recompile/parsing to permit longer pauses in typing.

You can increase Text Editor → Completion → Idle Parse Delay in the Editor Settings. Note that this affects both the script editor and shader editor, and will cause error reporting to take longer to appear.

I changed Idle Parse Delay before and it had no effect, but it seems that's because I did not restart the editor afterwards!  Thanks very much, problem solved.


Show names in group chats

I work for an organisation that requires all users to have the same display picture. Group chats are hard to use in Yakyak as it only shows display pictures, and no names. is it possible to add this functionality in further builds?

This is a funny one, would showing the display picture with first and last initial suit, or really show the full name?

Initials in the avatar would be a HUGE improvement for sure. Names would be better, but I'm not fussy 😂
Sent from my iPad

On 16 Sep 2017, at 11:23 am, André Veríssimo<EMAIL_ADDRESS>wrote:
This is a funny one, would showing the display picture with first and last initial suit, or really show the full name?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

#770 should fix this, please continue conversation in the pull request :)


Ping-timeouts during registration look strange

Reported by jesopo: pingout during registration on ora sends a :* QUIT
This looks like a bug, or at the least something weird with how we send stuff out. Will investigate, see what us and other servers send clients when they ping timeout, and make us match those other servers.

Oragono:
:* QUIT :Registration timeout: 1m0s
ERROR :Registration timeout: 1m0s

freenode:
ERROR :Closing Link: <IP_ADDRESS> (Connection timed out)

Current behavior seems fine to me --- is the * bad?

Incorrect passwords are somewhat similar:
:irc.example.com 464 * :Password incorrect
:irc.example.com ERROR :Password incorrect
:* QUIT :Connection closed

The QUIT in that case seems a bit superfluous -- I think terminating the connection after an error is reasonable

@slingamn hmm, the :* seems very weird yeah, doesn't match what clients normally expect from the source on incoming messages. Wherever we send that QUIT out, if we could detect the nickmask being just * and specifically not send it out then (or an 'is client registered' check instead, whatever's easier), that'd be awesome. Would be good for us to confirm that \r\n is correctly sent out after the ERROR as well, just to double-check.

If I'm understanding correctly, the issue doesn't just affect QUIT; we should never send a message with a prefix of *. Is that right?

I confirmed that \r\n is always sent correctly, since these lines are built with ircmsg.MakeMessage.
The current code is fairly deliberate about always sending both a QUIT and an ERROR line to the client; I thought we should probably preserve that.
Here's an attempt at consistency:
# normal /quit
quit :my quit message
:asdf!~a@0::1 QUIT :Quit: my quit message
ERROR :Quit: my quit message

# incorrect PASS command
pass wrongpassword
:oragono.test 464 * :Password incorrect
QUIT :Password incorrect
ERROR :Password incorrect

# incorrect OPER command (as a side effect, this will also send the "Password incorrect" quit message to friends)
oper root wrongpassword
:oragono.test 464 asdf :Password incorrect
:asdf!~a@0::1 QUIT :Password incorrect
ERROR :Password incorrect

# pre-registration ping timeout
QUIT :Registration timeout: 1m0s
ERROR :Registration timeout: 1m0s

# post-registration ping timeout
:asdf!~a@0::1 QUIT :Ping timeout: 2m30s
ERROR :Ping timeout: 2m30s

Hmm. While I like the consistency attempt, sending a QUIT message without any source seems like it is really gonna break clients (I don't think my bots would know how to handle a QUIT message with no source either). Given that we're already sending the ERROR, and that indicates some serious issue that means we'll need to kill the connection, I'd rather do exactly as above, but prevent sending the QUIT when there's no source on it (i.e. in wrong PASS, and pre-reg ping timeout).
Thanks for the work on this, much appreciated.


Encountered annoying noise in the configuration file

No matter what you fill in or even if you don't fill in there will be noise, this is very frustrating.

Thanks for the feedback, I work on to disable this noise

Hi,
I update the settings validation to avoid this noise in configuration 😉
PS: I deploy a new version (3.0.0) minutes ago
Have a nice day and be happy


Many-to-many relationship with extra attributes not working

Hello,
This is really impressive work -- I'm very familiar with this structure from Rails, and I like the intuitiveness of the way you've put things together. I also like that there's a good separation of concerns and choice of design patterns.
For this reason, I wanted to check it out for a new side project I'm considering, but I found no tutorials. I am trying to create a many-to-many relationship with a few extra attributes, and I'm not able to figure it out from the documentation alone. Here's what I have.
Say, I'm modelling  an Amazon-like bookseller, Fakazon. There's a catalog of Books, and Users who can buy them. A User can buy many Books and a Book can be bought by many Users. A User can also give a rating and a review for a Book. Fakazon also wants to store the date a User purchased a Book. So it's a many-to-many association, but with extra data on the association. The database model I came up with is this:
User
----
id
name

Book
----
id
title

UserBook
--------
id
user_id
book_id
purchased_on
rating
review

I want to be able to know not only which Books a certain User bought, but also which Users bought a certain Book. That is, I should be able to say book.users as well as user.books, each of which returns a list. For example, user.books returns:
[
  {
    "title": "Genome",
    "rating": 5,
    "review": "A review of human genomics in 23 chapters",
    "purchased_on": "2020-04-02"
    . . .
  }
]

Here's my code;
# user.py

class User(Model):
    __fillable__ = ["name"]

    def __repr__(self):
        return self.name

    @has_many_through("user_books", "book_id")
    def books(self):
        return models.Book

class Book(Model):
    __fillable__ = ["title"]

    def __repr__(self):
        return self.title

    @has_many_through("user_books", "user_id")
    def users(self):
        return models.User

class UserBook(Model):
    __fillable__ = ["purchased_on", "rating", "review"]

    @belongs_to
    def book(self):
        return Book

    @belongs_to
    def user(self):
        return User

The migrations are correct, the database tables are also correct, but when I create my User and Book objects, they are not linked to each other, neither in the database  nor in the code:
user = User.create(name="Rohit")

hp2 = Book.create(title="Harry Potter and the Chamber of Secrets")

user.books.append(hp2) # <-- exception here, no column books.user_book_id, and a HUGE SQL
# statement with multiple repeated columns

for book in user.books:
    print(book)

I want to be able to say, e.g., user.books[0].rating, which will give me the rating the user put on the first book in his collection.

Could you please help resolve this issue?
Thank you!
Rohit

Hi Rohit,
I'm not a contributor to this project, but I came across your question when I was reporting a bug in one of the methods related to many to many relationships. I used Orator in a few projects now and I'm also really enthusiastic about it!
Why are you making a model for the user-book relationship? It seems that the relationship itself is not complex enough that it needs to have its own model. You could use a regular many-to-many relationship and add additional attributes to the pivot table. When following the link, check out the second code block.  The data can be queried by accessing the pivot table.
Also, the example from the docs for the has-many-through relationship uses the following order:
Country (one) - User (many) - User (one) - Post (many)
Notice that Post has only one User (the linking entity). In your case a Book can have many UserBooks.
User(one) - UserBook (many) - UserBook (many) - Book(one)
I haven't worked with the has-many-through relationship of Orator before, but it could be that your use case is not supported by this type of relationship.
So I would suggest to use pivot tables!


format UglifyJs error

Fixing https://github.com/facebookincubator/create-react-app/issues/2641

😮

ready for more review!

LGTM, I trust you that this works.

Hi there! This change is out in<EMAIL_ADDRESS>please give it a go! Thanks.

did you forget to add lodash in the package.json?

Ah, it appears so! Interesting that the CI passed; is this causing you an issue?
Can you submit a PR adding the dependency please?


GORA-622 maven-assemly-plugin complains that group id is too big and fails build on macOS Mojave 10.14.6 (18G87)

This pr addresses https://issues.apache.org/jira/browse/GORA-622

@lewismc Shall we call off RC2 and add this to 0.9 release?


NOJIRA: update GitHub actions versions

In February 2025 v1 and v2 of the actions/cache GitHub actions will no longer work. This needs to be updated to prevent ci breakages.
see: https://github.com/actions/cache?tab=readme-ov-file#-important-changes
Also updated to recent version of node for testing with.

Did the node 16 tests fail originally?


moved the location and export of checkboxTypes to match other enums - ag

I'm real confused on these merge conflicts there don't appear to be any when I'm looking at it locally

Make sure your fork is up-to-date with the headstorm fork, that'll prob be why

Moving this to another PR my branches got real out of sync


.NET Meteor does not load if no Android SDK can be found

My use-case for this extension is to assist running a MAUI app which will run only under WinUI. I have found that the extension fails to load if there is no installed Android SDK.
To work around this, I have made the following changes to the local files for the extension (version 1.71.0):
// resources.js
exports.messageAndroidSdkNotFound = "Android SDK Path not found. Make sure you have installed a supported Android SDK.";

// tasks/build.js
...
constructor() {
  try {
    this.androidSdkDirectory = bridge_2.CommandInterface.androidSdk();
  }
  catch {
    vscode.window.showErrorMessage(res.messageAndroidSdkNotFound);
  }
}
...

This allows the extension to keep loading, displaying a warning to the user instead of dropping an exception into the extension host log.
Logging as an issue, rather than a PR, to enable discussion and in case there is a more elegant way that loading without an installed Android SDK can be achieved.

Hello! Thank you for your issue. I have already fixed this bug and will release an update soon.

Fixed in 62c1ba7a47d79ed34e43af5d9e370cf4d14b87b9


Update links

Purpose
Remove direct csspeechstorage links.
Pull Request Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

/azp run


publish-iis command

Hi @moozzyk, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Please add a test case to make sure this bug in the prior implementation has been fixed: https://github.com/aspnet/dnx/issues/3062

OK

:up::date:

unpinned package versions i project.json
Moved from CommandLineUtils.Sources to CommandLineUtils
Added test to verify that children of httpPlatform element are not removed (aspnet/dnx#3602)

:shipit:


Malformed snapshot JAR

Hey @czyzby,
Sorry to bother you again with that nasty problem, but it seems that the latest published snapshot jar gdx-lml-<IP_ADDRESS>.10-20190822.134652-9.jar is somehow malformed and weights only a few bites. Compare it to some other old ones - https://oss.sonatype.org/content/repositories/snapshots/com/github/czyzby/gdx-lml/<IP_ADDRESS>.10-SNAPSHOT/

All good with maven now, thanks!
Hm, I didn't have the same problem in my fork. When I run :installAll I can see that all the modules get assembled correct.
I remember the project wasn't configured with Gradle wrapper. Do you use system installed Gradle?

No, I used the wrapper. Can you check if zip archive in build/distributions has duplicate entries?

Sorry, I'm not sure where to look for that dir, I don't have it anywhere in the project after clean build.

@metaphore Run ./gradlew build distZip, check build/distributions in the project root folder.

I'm going to close this for now and write a small script to upload the archives separately. I'd appreciate if you checked the distribution archives @metaphore as described in the previous comment.

@czyzby very sorry about a late response, checked it in the first place and completely forgot to leave a message.
And yes, you're right, I can see the duplicated entries in the archive:

Not sure what causes this issue, maybe need to play with Gradle configuration to see when it happens.

It's OK, thanks for the confirmation. The fastest fix would probably be to


Release v0.1.1-alpha.22

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Our CHANGELOG.md has a "Next Release" section. As part of our release process, perhaps we need to move "Next Release" contents to <new release version>.

@OrkoHunter - good catch! will update Changelog


Preallocate inter-node distances

In the updateWeigths! function after getting the best match unit, we compute the distance of the BMU to all other nodes. It seems that these distances could all be preallocated and stored in a lookup table since the positions don't change.
function updateWeights!(som::SOM, x::AbstractVector, step::Int, Nsteps::Int)
    N = size(som.W, 2)
    idx = getBMUidx(som, x)

    for i ∈ 1:size(som.W, 2)
        # compute distance to bmu
        @inbounds d = evaluate(som.neighbor_distance, som.coords[:,i], som.coords[:,idx])
        f = som.neighbor_function(d, som.σ_decay(som.σ², step, Nsteps))
        @inbounds som.W[:,i] += som.η_decay(som.η, step, Nsteps) .* f .* (x .- som.W[:,i])
    end

end

This distance matrix is naturally symmetric so storage would be n(n+1)/2 which is not bad even for very dense SOM grids.


[Bug 1202601] [WIP] Remove playdoh from project dependencies

Here is the patch to remove the Playdoh and implement peep for installing python dependencies.
Install all the default python dependencies with ./peep.sh install -r requirements/default.txt
and all the dev dependencies with ./peep.sh install -r requirements/default-dev.txt
Still some works need to be done!

[x] Remove the vendor and vendor-local directory
[x] Remove funfactory from ./manage.py
[ ] Make appropriate changes in deploy script for deploying
[ ] Update the documentation
[ ] Configure docker
[ ] Maybe changes in the server for the virtualenv

@johngian thoughts about this? :smile:

Hey @safwanrahman
Thanks for your contribution. As you already mention in your PR it's still WIP.
Some comments in current changes:

I don't think that we need to maintain dictconfig.py since we are not using it
It doesn't sound like a good idea to maintain celeryutils.py just to use chunked.
We could move this helper to a common/utils.py file.
./manage.py still uses funfactory and monkeypatches it to import vendor
You need to remove these dependencies from manage.py
At the moment even if travis build passes you haven't removed the real dependencies' code under vendor and vendor-local. This might be misleading, since many import will brake.

@johngian Review the progress?
Have fixed most of the issue you mentioned in the last comment.
regarding dictconfig, we are using dictconfig here https://github.com/mozilla/mozillians/blob/master/log_settings.py#L68

Regarding dictconfig instead of using this legacy dictconfig implementation I suggest we adopt the one [1] from django. Here is a similar usage example [2].
[1] https://github.com/django/django/blob/1.7.10/django/utils/dictconfig.py
[2] https://github.com/mozilla/kitsune/blob/adde3c81e34b85a62ff10776686cbb5589a2b180/kitsune/log_settings.py#L4

This PR is targeting mozilla/mozillians/master" from your master. The usual workflow that we suggest is to work on a branch <#Bug number>`` and then open a PR to master.
Since you have already done a lot of work on that functionality I suggest you get assigned to that bug and open a new PR as described.

Regarding the commits in this PR:

Let's squash everything that removes vendor and vendor-local
On top of that let's add all the copied code from vendor and the rest of the dependencies
Finally add a commit with all the mozillians codebase changes.

It would be much easier to review.


Smart Tag option in metadata component does not work.

Describe the bug
Smart Tag option in metadata component does not work.

AEM Version: AEM 6.3
Asset Share Commons Version: 1.5.2
Author, Publish or both? : Both

To Reproduce
Drag and drop metadata component in a asset share commons details page (or any other page).
And then select smart tag option from the dropdown to show smart tags, if they are available smart tag values should be shown.
Expected behavior
smart tag values should be shown.

@tuhinghosh2610 per https://adobe-marketing-cloud.github.io/asset-share-commons/pages/development/computed-properties/ the tagTitles computer property reads from cq:tags (Ie NOT Smart Tags).
But you bring up an interesting topic ... should Smart Tags and AEM Tags display as mixed? I would generally say no since usually, they serve different, though often conflated, purposes.

AEM Tags are (almost) always a controlled vocabulary, and define taxonomy.
Smart Tags enrich discovery and are not guaranteed (thus you cannot depend on them for taxonomical control).... even w/ Training Smart Tags.

So, in your opinion, should Smart Tags be selectable as a discrete set of metadata to display? And then, what is the "real" value of them as they simply describe the image.  For example, if there is a Smart Tag of "leaf" .. that is useful in searching for assets that have leaves in them ... but once you get the results, what's the value of the smart tags? I'd argue is ~0 ... if your end-user can't look at a picture and tell its got a leaf in it and has to rely on the Smart Tags text of "leaf" to tell it has leaves in it.. then you have a much bigger problem, no?
The only use case i can think of displaying smart tags is to also wire them up so you can click on and search for things w that keyword (almost like a "more like this" option), but thats something totally different.
So, TL;DR .. whats the business value in displaying smart tags? How will it help users?

Hi @davidjgonzalez ,
Thanks for replying back to me. The request to add support for the smart tag came from the client who is keen to display it in the page if present.
The rationale they are giving is, there might be an asset which is tagged with "leaf" by smart tag (not visible) and the user search randomly for the image with "leaf" search term, when the image comes back in result it may not have "leaf" explicitly visible in the image, so the question may come up why the image is relevant for the search.  By presenting the smart tag in the image properties it adds additional transparency for the user regarding the image relevance for the search.
Thus the client is very much keen to display the smart tags. Now since we had to fix this anyhow, Jo suggested why not put it in the product as a PR. I am almost done with the fix, and would be adding a pull request. If you see any value of having the support for smart tag, we could merge it with the ASC code.
Thanks
Tuhin

Hi @davidjgonzalez ,
I have created the PR for you to review (https://github.com/Adobe-Marketing-Cloud/asset-share-commons/pull/209). A shout to Jo (from adobe) for the guidance on this.

I’ll take it a look - but we’ll need to make sure this doesn’t confuse taxonomy w smart tags.
Tho the rationale is unfortunate and points to smart tags doing a poor job - perhaps the confidence score is low if text is required to explain to a user why a term they selected results in a visual asset.

Hi @davidjgonzalez ,
I have updated the code as per your comments, also have refactored it, and looks much more readable now.
If no properties are selected, then use tagTitles (existing default behavior) - Working as expected.
Update dialog to write multiple values to tagPropertyName - Done
For each of those defined properties, do a asset.getProperties().get(..) ... (which has the problem we dont actually know the return types... :() - Doing now, also addressed the problem of the return types by instanceof check.
for each result from each tagPropertyName, check if the value resolves as a tagId (if it does, assume its a real tag) and get the localized title - Doing
If tag == null, then assume its a title, and display that (not sure how to best localize this; i18n?) - Doing apart from the i18n part, does not make much sense to localise smart tags, should be shown as is if required.
dump all the titles them all into 1 list that is maybe sortable (alpha a-z?) - Done, and list is sorted before returning the result.
Kindly let me know about your thoughts.
Thanks and Regards,
Tuhin

Released in v1.6.0


Add unit test and code coverage badges to README

Rather easy to do and helps seeing the project "health" immediately:

add build status badge (https://travis-ci.org/commonsearch/cosr-back)
add code coverage badge (using a service such as coveralls or codecov)
maybe add license badge too

IMHO a lot of people (including myself) look for these badges (e.g. to get a first impression on test quality).
Example project with (IMHO relevant) badges: https://github.com/zalando/connexion

Thanks @hjacobs for the suggestion!
I originally thought about it but felt it was somewhat annoying to have third-party images on the READMEs. However after looking deeper into it, it looks like GitHub actually proxies them, which makes it okay :)
Adding code coverage is also a great idea. I will give coveralls a try!

Coverage is working :) Thanks!


Invalid Handling of MaxHeaderListSize lead to ignore configuration value

Hi,
On vertx 3.4.2
Using the configuration :
HttpServerOptions options = new HttpServerOptions()
            .setInitialSettings(new Http2Settings().setMaxHeaderListSize(Integer.MAX_VALUE))
            .setUseAlpn(true)
            .setSsl(true)
            .setKeyStoreOptions(new JksOptions()
                .setPath(ServerConfig.CONFIG_KEYSTORE)
                .setPassword(ServerConfig.CONFIG_KEYSTORE_PASSWORD))
            .setJdkSslEngineOptions(new JdkSSLEngineOptions())
            .setPort(Integer.parseInt(ServerConfig.getInstance().getPort()));

If headers exceed limit 10240, then vertx fail :
Sep 05, 2017 2:53:53 PM io.vertx.core.net.impl.ConnectionBase
SEVERE: io.netty.handler.codec.http2.Http2Exception: Header size exceeded max allowed size (10240)

After some investigation, it seem to come from io.vertx.core.http.Http2Settings where :
public static final int DEFAULT_MAX_HEADER_LIST_SIZE = Integer.MAX_VALUE;

When this value is read by : io.vertx.core.http.impl.HttpUtils
public static void fromVertxInitialSettings(boolean server, io.vertx.core.http.Http2Settings vertxSettings, Http2Settings nettySettings) {
    if (vertxSettings != null) {
      [...]
      if (vertxSettings.getMaxHeaderListSize() != DEFAULT_MAX_HEADER_LIST_SIZE) {
        nettySettings.maxHeaderListSize(vertxSettings.getMaxHeaderListSize());
      }
      [...]
    }
  }

They do not differ, so it's not updated. But by default, netty use 8192 as seen from io.netty.handler.codec.http2.Http2CodecUtil:
public static final long DEFAULT_HEADER_LIST_SIZE = 8192;

This value is used in io.netty.handler.codec.http2.AbstractHttp2ConnectionHandlerBuilder
Workaround :
HttpServerOptions options = new HttpServerOptions()
            .setInitialSettings(new Http2Settings().setMaxHeaderListSize(Integer.MAX_VALUE-1))

I think the fix should be to change io.vertx.core.http.Http2Settings. DEFAULT_MAX_HEADER_LIST_SIZE value to either 8192 or io.netty.handler.codec.http2.Http2CodecUtil. DEFAULT_HEADER_LIST_SIZE.

can you contribte a test and fix for this ?

I can try.

thanks

Done : https://github.com/eclipse/vert.x/pull/2114
It's seems there is an agreement to sign, and the commit have to be signed.... :(
If you can send me a link on the procedure to follow (if really needed)

reopen with a new PR that fixes it with ECA valid

Hi guys.
Any news on this problem?
@vietj I was not able to find that new PR that you were talking about.
We ran into that issue recently.

this https://github.com/eclipse-vertx/vert.x/pull/2114

I'll have a look myself today

this eclipse-vertx/vert.x#2114

Ok then that's the one I found, I thought there was another one.
Thanks to have a look Julien.

https://github.com/eclipse-vertx/vert.x/pull/4212
https://github.com/eclipse-vertx/vert.x/pull/4213
https://github.com/eclipse-vertx/vert.x/pull/4214


function isn't a type name

When I'm declaring a timer inside main.cpp, everything is fine. Yet, as soon as I try to declare it inside a class, I get the following.
https://i.imgur.com/Kk6i9Uy.png
void blank(){};
Ticker timer1(blank, 1);

Were did you declare the function blank?

I tried declaring it in several places:
main.cpp before loop
main.cpp before ticker include
inside the class (header file) right before the timer object
inside the same header file, but as a class function outside the class itself.

It sounds like a generell problem of nested classes. You should look in the web for it.

Thanks for the suggestion.
For those, who'd encounter the same situation and doesn't need callback functionality, there's a Chrono library, which is working fine in the same conditions.


Investigate errors upon file cleanup in windows bazel build

The windows bazel build passes, but I see some errors in the cleanup code:
Get-ChildItem : The directory name is invalid.
At line:1 char:4
+ & {Get-ChildItem -Recurse -File -Exclude test.xml,sponge_log.xml,buil ...
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ReadError: (T:\src\github\g...thon_wrapper.sh:String) [Get-ChildItem], IOException
    + FullyQualifiedErrorId : DirIOError,Microsoft.PowerShell.Commands.GetChildItemCommand
Get-ChildItem : The directory name is invalid.
At line:1 char:4
+ & {Get-ChildItem -Recurse -File -Exclude test.xml,sponge_log.xml,buil ...
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ReadError: (T:\src\github\g...arty\zlib.BUILD:String) [Get-ChildItem], IOException
    + FullyQualifiedErrorId : DirIOError,Microsoft.PowerShell.Commands.GetChildItemCommand

We could simply remove that code if it does not help.

Have we seen anymore of these errors? If not, maybe we should just close this issue.

These are just harmless. The build scripts try to remove any artifacts created by the build for reasons [1], it just happens that no such artifacts are present in these builds (they are in the C:\b directory).
[1]: We remove the artifacts because Kokoro performs an rsync after the build which is extremely slow on Windows, we are implementing the recommended workaround b/79892746


custommedia extension markup validation failed (W3C)

Hi
I am using the custom media extension with media="--small" a.s.o. like in the examples.
Unfortunatley this markup is no valid html and so highlighted by the W3C-Validator:
"Bad value --small for attribute media on element source: Expected ( or letter at start of a media query part but saw - instead."
"Stray end tag source."
Is this a normal behavior or do I make something wrong? How could this be avoided?
Thanks,
Frank

You make everything right. Custom media queries might be a future feature and therefore the validator does not validate. We basically polyfill this with lazySizes. It doesn't harm your page.
You can avoid this by using the data-media attribute instead:
<source
    srcset="data:,pixel"
    media="(max-width: 1px)"
    srcset="your_srces"
    data-media="--small" />


metadata reader: inspect enum type in attribute arguments

It'd be cool if I could inspect the type of enums in attribute arguments. Currently this type information is discarded and only the raw value is kept:
https://github.com/microsoft/windows-rs/blob/721027379419bc58a9293adc51ea04a55e87e993/crates/libs/metadata/src/reader/mod.rs#L292-L302
My thinking is to create a new Value variant for this. Something like:
pub enum Value {
    ...
    // I suspect that, in practice, all attribute enums are u32 (or at least fit into it).
    // I could be wrong though so it might be better to use a variable type.
    EnumOrFlags(TypeDef, u32),
}

I can submit a PR if this is ok.

I'm busy working on the metadata writer and that might be useful for testing metadata generation more carefully. The precise type should only matter when it comes to reading constant values, so a single variant seems reasonable here.


[question]make Viewrenderable have thickness

Hi guys, i'm using sceneform for developing ar gallery on android.
so i added imageview on my surfaceview and it worked well.
but i want my artwork viewrenderable become more thicker like 3d cube
is there any way to adjust Viewrenderable's thickness programmatically?
(i'm not saying metertopixel ratio.)
thank you for your good product, and sorry for my bad english.

What if you drew a box model behind the ViewRenderable that was scaled to the same size?

i also thought that way, but i didn't try
cause, all the artworks has different (x,y) ratio.
so we need different box model for each artworks

Create the box using the 4 corners of a frame.  Then align them to the corners of your image by offsetting them from the center using rhe known height and widthnof the image.

really thank you, for your answers!
i will try and and update this issue
thank you !

hi guys,
i found a way to make 3d cube programmatically, when i read issue#197
(https://github.com/google-ar/sceneform-android-sdk/issues/197)
he used Shapefactory for rendering 3d cube, and it can scale size by input
i think this way can solve the thickness problem by 2 way

draw box model behind imageview renderable
or make artwork image texture for box renderable

i don't know whick one is better, but when i apply that code the box model appear.
so i think this issue should be closed
really thanks you guys i love you


rebuild shader if texture added later

This patch propagates the dirty bits which indicate a new texture has
been added to the RenderPass and RenderData so the shader can be
recreated in this case. It fixes a bug in the 3D cursor sample with the
animated cursor.
GearVRF DCO signed off by: Nola Donato<EMAIL_ADDRESS>

gvr-controls: some of the textures are missing
gvr-3d-cursorsimple: some of the other textures of the red cube are missing

What textures are wrong in gvr-controls? I have compared it with the maint_v3.x version and it looks the same.

In my tests the sky and the fence were missing - all black. Will git clean -fdx and retest.

Not reproducing anymore after git clean -fdx. Will merge on Friday.


Improvements to Arbitrary / Gen

Added support for char[] based generators
Added support for vararg based generator construction
Add an intersperse method on Arbitrary/Gen to blend two Arbitrary/Gen instances into a new one
Added Arbitrary.forAll() convenience factory method
Added Arbitrary.fixed() convenience factory method
Added Arbitrary.distinct() and distinctBy() methods

Current coverage is 95.47%

Merging #1260 into master will decrease coverage by -0.17% as of 7f43938

@@            master   #1260   diff @@
======================================
  Files           83      83
  Stmts         9560    9576    +16
  Branches      1759    1759
  Methods          0       0
======================================
- Hit           9144    9143     -1
- Partial         99     100     +1
- Missed         317     333    +16

Review entire Coverage Diff as of 7f43938

Powered by Codecov. Updated on successful CI builds.

Awesome! Thx for improving the test-framework :)


Custom tags

Hello! I don't know if someone else wrote about this, but I tried to create my custom tags but I didn't find the option (I just found it's in the experimental tab, but there's no documentation about it). Can someone explain me how to do it? Thank you :)

Hi, this is more fit for the Files discord server: https://discord.gg/files.
Please try asking there.


Add TypeScript type definitions

Fulfilling #269 This PR adds TypeScript type definitions to this project. These definitions build on top of the existing @types/react and @types/quill packages.
I've added definitions for:

Mixin
Component
Toolbar

The dependancy versions of those are set to * so that they'll match whatever version that the user of this project has installed.

Closes #269

Excellent! I'd appreciate if someone with knowledge of Typescript could add a review.

Maybe try adding the Hactoberfest label on this PR. That's how I found the initial issue.

Thanks a lot for the contribution, @Charrondev!
Typescript type definitions are a great addition.

I finally got a chance to sit down and implement your feedback on this.

Removed "Quill" prefixes from all of the exported elements
Made all props optional
Uncommented deprecated props

I've also added some comments on the deprecated properties with the stuff you have in the prop-types validation. In VSCode it looks like this if you try to use one of these deprecated properties:

@zenoamaro any further comments or shall we go ahead and add this?

Looks like these changes went live about an hour ago and now I'm getting some errors
> tsc --project tsconfig.json --pretty --noEmit --noImplicitAny --noImplicitThis --alwaysStrict --strictNullChecks

29     getContents(index?: number, length?: number): DeltaStatic;}
                                                     ~~~~~~~~~~~

node_modules/react-quill/types.d.ts(29,51): error TS2304: Cannot find name 'DeltaStatic'.

100  setEditorReadOnly(editor: Quill.Quill, value: boolean);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-quill/types.d.ts(100,2): error TS7010: 'setEditorReadOnly', which lacks return-type annotation, implicitly has an 'any' return type.

101  setEditorContents(editor: Quill.Quill, value: Quill.Delta | string);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-quill/types.d.ts(101,2): error TS7010: 'setEditorContents', which lacks return-type annotation, implicitly has an 'any' return type.

102  setEditorSelection(editor: Quill.Quill, range: Quill.RangeStatic);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-quill/types.d.ts(102,2): error TS7010: 'setEditorSelection', which lacks return-type annotation, implicitly has an 'any' return type.

Submitted a fix with #296


Running Queries Viewer: Back button doesn't work when drilling into blocked processes

Not sure if this is a feature request, or a bug report.
I read your reply here but not sure if it answers my question.
To recreate the issue:
I am viewing the Performance tab for an individual database.
Clicking on a "Blocking: Database" bubble pops up the "Running Queries Viewer" window.
I then drill into the blocked processes by clicking on either a "Blocked Count" or "Blocked Count Recursive" link, which loads the new set of blocked processes.
Current behavior: Back button is greyed out. In order to go back to the previous list, I have to close the window, re-click on the same bubble (not always easy if it's small and there are a lot) and try to navigate back to that spot.
Expected behavior: As you drill into block process listings, the back button supports going back to the previous list.

Hi, I think the back button was disabled as there is no previous tab but this also means it won't undo the drilldown.  I'll take a look at this at some point.
As a workaround you can click the blocking filter in the menu and clear the blocking filter to show all items captured in the running query snapshot.  Or you can filter for the root blockers by clicking show root blockers - this is the default view when you click the blocking bubble.
If the blocking bubbles are small another option is to go to the Running Queries tab and click on the Blocked Queries column to sort by the number of blocked queries - just another way to access the same information that might be useful
Hope this helps.

This will be included in the next release.  I've also added some additional blocking filters
Blocked Queries
Blocking Queries
Blocked Or Blocking


Packaged path vs dev path

Hi,
Bit of a long-shot, but I'm trying to do something similar to your project - running python scripts inside an electron app. I'm finding that the python path reported by python changes between the dev run (npm start) and the packaged app.
It's pretty impossible to avoid having more than one python version on a mac, as it needs the default 2.7 installed for os-related scripts. When the app compiles/packages, it's reverting to the 2.7 path instead of the anaconda 3.6 path usually available when run in dev mode.
Did you encounter this problem also ?
Thanks
Ian

if you wan to distribute your app, please compile the python app using something like pyinstaller, so that the executable itself contains its python, and doesn't use the system one.


Add data-testid atteibutes

Feature description
I add data-testid attributes to components to enable me to easily test the components using the appropriate test selectors of matchers. It's a standard practice. It would be great to have these already in shadcn.
Affected component/components
No response
Additional Context
This is relevant for both unit and e2e framework's
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Assign ownership of each GDM to one GCEP only

The GCI was initially envisaged as a community curation tool, similar to the VCI. Later it was decided to restrict the GCI to use by GCEPs only.  An additional layer of complication was that the GCI was designed for multiple groups to make their own parallel classifications on each GDM, but now it is required that only one GCEP at a time should be working on a classification for a given GDM.  As such, the GDMs need to be cleaned up so that each GDM only has one GCEP current owner.
https://broadinstitute.atlassian.net/browse/CGSP-452

Signed off by stakeholders... closing


Add support for SSLKEYLOGFILE

Motivation and Context
When attempting to use a packet capture to diagnose issues, it is necessary to use the SSL keys to decrypt the traffic so that the actual requests can be seen. This is usually done by means of an environment variable, SSLKEYLOGFILE. rustls has support for this variable via the key_log parameter, though it is not manipulable via the various config builders.
Description
I slightly refactored the code so that the tls config is created and can be modified separately from the HttpsConnectorBuilder. We then modify the key_log parameter if a new feature is enabled. This may not be necessary, so the feature half of this change can be stripped (or changed to a deafult feature) if people are okay with this being a default behavior.
Testing
Unfortunately, I could not figure out how to use my standard approach to test this crate (have my larger project use my github branch as the source of the crate, rather than the published version) because of the dependency on the generated code. I instead tested it by manually copying the default_tls code and using it to create an http client, and then used it instead of the default client. When the final program was run, SSLKEYLOGFILE was respected, and the contents look correct. This also meant I was unable to test the feature code's conditional compilation. If there is a way to do this "properly", I would be more than happy to run that testing again.
I did run the local tests for rust-runtime and aws/rust-runtime to verify that they pass.
Checklist

[x] For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the contribution. This isn't something we plan to directly support at this time and would recommend just plugging in your own HttpClient implementation to the SDK with whatever TLS configuration required already set.

@aajtodd is there some way to create an HttpClient with the same basic settings as the one generated internally without having to just copy/paste code out of the library? Ideally we would not like to have to keep updating this code to match things like cipher suites, etc, and would just be able to tweak this one parameter. Unfortunately, it seems like nothing that would be useful is visible; default_connector is private, and even if it were public, default_tls is private, HTTPS_NATIVE_ROOTS is pub(crate), and the default_{connector,client} functions don't allow us to inspect the internal implementation since the single members of SharedHttpClient and SharedHttpConnector aren't public.
If there isn't, then asking people to create their own HttpClient to plug in is just asking them to not be able to use your safe and recommended defaults without having to manually sync changes over, which is inevitably going to fall out of date and cause security or connection problems.

Today, no there is not a way and suspect even as we look to hyper-1.x as the default we won't be able to provide that (at least not right away because hyper-util is not 1.x yet either). It is something I've given some passing thought to and generally agree it would be nice to support but there are some backwards compatibility concerns to solve first before we could pursue it.


Getting : Uncaught TypeError: t.resolve is not a function

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ X ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ X ] bug report
[ ] feature request
Current behavior:
When running ionic serve on the browser if I do a right click, I get the following :
polyfills.js:3 Uncaught TypeError: t.resolve is not a function
    at Object.setNativePromise (polyfills.js:3)
    at L.configurable.L.set (polyfills.js:3)
    at new Synchronizetion (index.js:37)
    at handleEvent (index.js:106)
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at e.invokeTask [as invoke] (polyfills.js:3)
    at p (polyfills.js:2)
    at d (polyfills.js:2)

Expected behavior:
It shouldn't throw the error.
Steps to reproduce:
Just do a right click and you'll get the error.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
    @ionic/cli-utils  : 1.18.0
    ionic (Ionic CLI) : 3.18.0

global packages:

    cordova (Cordova CLI) : 7.0.1

local packages:

    @ionic/app-scripts : 3.0.1
    Cordova Platforms  : android 6.2.3 ios 4.4.0
    Ionic Framework    : ionic-angular 3.8.0

System:

    ios-deploy : 1.9.2
    ios-sim    : 6.0.0
    Node       : v8.1.3
    npm        : 5.4.2
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : legacy

incorrect ionic version. it should be ionic 3.x and not 4.x

@KillerCodeMonkey corrected. By the way, is there ionic 4.x ? I have the latest version..

ionic 4 is the next thing. not available, yet ;).
But maybe this is a hint, it will be released in the near future

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
RE: 4.x, that is pretty much an internal thing at this point, but yes, it does indicate that it is being actively worked on. AAMOF, it is the primary focus of the whole team at this point.
Thanks for using Ionic!

@kensodemann HamzaLJ never got back to you, but I actually have the exact same issue with a project of mine. You can find a completely cut-down version of my project here. I've removed all of the typescript code except for the bare minimum required to run into the error in my case.
I'm not sure if the error is in ionic (honestly, I don't think so) but I'd personally appreciate it very much if somebody more experienced with this had a good idea of how to solve the issue properly.
After digging into it a lot, I ended up looking at the es6.promise.js file module in core-js as that was part of the code that was transpiled into the polyfills.js file. Digging into it with the chrome debugger, I noticed that the .Resolve function of the Promise that Object.SetNativePromise was setting, (as the exception text correctly states) has .Resolve set to null. So I assume something goes wrong somewhere when doing polyfilling for Promise.
The way I ended up solving it temporarily for myself, was to comment out line 26 - 36 in es6.promise.js, the following lines:
var USE_NATIVE = !!function () {
  try {
    // correct subclassing with @@species support
    var promise = $Promise.resolve(1);
    var FakePromise = (promise.constructor = {})[require('./_wks')('species')] = function (exec) {
      exec(empty, empty);
    };
    // unhandled rejections tracking support, NodeJS Promise without it fails @@species test
    return (isNode || typeof PromiseRejectionEvent == 'function') && promise.then(empty) instanceof FakePromise;
  } catch (e) { /* empty */ }
}();

which is the function that attempts to check if the Promise object has already been polyfilled by another library and instead, just replaced it with var USE_NATIVE = true;.
This is in no way a viable solution, but I just needed to get it work so I could get on with the test project.
The problem I run into now is the fact that I can't get this to run ionic's build servers, because obviously I run into the same error there because the Ionic build system uses the default implementations of the npm modules, as it should, so I'm once again stuck with this error.
Any good ideas as to how to solve it in a proper fashion?

Hi !
Same error when trying to use hanzi-writer in ionic project 3. Work on angular but got same error on ionic :
console  polyfills.js:3 Uncaught TypeError: t.resolve is not a function
at Object.setNativePromise (polyfills.js:3)
at L.configurable.L.set (polyfills.js:3)
at module.exports.module.exports (hanzi-writer-lib.js:289)
at $export (hanzi-writer-lib.js:97)
at Object. (hanzi-writer-lib.js:14088)
at webpack_require (hanzi-writer-lib.js:21)
at Object. (hanzi-writer-lib.js:11479)
at webpack_require (hanzi-writer-lib.js:21)
at Object. (hanzi-writer-lib.js:11340)
at Object. (hanzi-writer-lib.js:11366)
and in ionic page 👍 TypeError: t.resolve is not a function
at Object.setNativePromise (http://localhost:8100/build/polyfills.js:3:18280)
at L.configurable.L.set (http://localhost:8100/build/polyfills.js:3:23002)
at module.exports.module.exports (http://localhost:8100/build/vendor.js:119482:12)
at $export (http://localhost:8100/build/vendor.js:119290:17)
at Object. (http://localhost:8100/build/vendor.js:133281:1)
at webpack_require (http://localhost:8100/build/vendor.js:119214:30)
at Object. (http://localhost:8100/build/vendor.js:130672:1)
at webpack_require (http://localhost:8100/build/vendor.js:119214:30)
at Object. (http://localhost:8100/build/vendor.js:130533:1)
at Object. (http://localhost:8100/build/vendor.js:130559:30)
I am a noob so unable to figure out whats going on.
Is this a bug in Ionic ? Why can I use this 3rd party library ion angular and not in Ionic ?
Thanks for help.

Same problem here ... any news ?

@Capsup - using your repo, I commented out the CiscoSpark.init code in home.ts and then the error went away. I just did that because it looked like it was the first substantial code that would be run, so dumb luck.
Anyhow, the es6.promise.js stuff is part of core-js, which seems to be being installed with the ciscopark stuff:
~/Projects/Issues/IonicTestProject (master *): npm ls core-js
<EMAIL_ADDRESS>/Users/kensodemann/Projects/Issues/IonicTestProject
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>deduped

I'm not sure if that helps at all.

@kensodemann, unfortunately not, as I had already cut the project down to the very minimum required to encounter the error and just initialising the CiscoSpark SDK does that, since that's obviously the code that calls down into core-js.
Something I haven't tried, which I will do monday, is to just add the CiscoSpark SDK to a non-Ionic project and see if I encounter the same error there. If not, I imagine this has something to do with the combination of Ionic and core-js attempting to polyfill Promises. If the same error still happens, it obviously has to do with core-js.
I just wonder why it isn't possible to find the error message anywhere else but now there's suddenly 4 of us, within the span of a week, that are encountering the same error across multiple modules?

same error

I'm trying to import keras-js into Ionic 4 and getting the same error, anyone?

No, I came back to pure javascript/html/css project to make it work. I love Ionic but can't go through this issue.

so sad, ok thanks @tianxang

I am having the same problem. The problem started when I added the mongodb-stitch into the standard super starter pack. I just import " import { StitchClientFactory } from 'mongodb-stitch';
in a provider.ts and nothing in app module or appcomponent.ts.

Hi
For me, the problem was the typescript version, i was using an older version than the library (Keras-js).
Once i updated my typescript version on package.json, the error disappeared
hope that helps.

I'm getting this error with the MongoDB Stitch service and trying to import their sample code into my Ionic Application.
import { StitchClientFactory } from 'mongodb-stitch';
let appId = 'myappid-from-mongodb';
    const clientPromise = StitchClientFactory.create(appId);
    clientPromise.then(client => {
      const db = client.service('mongodb', 'mongodb-atlas').db('myDBname');
      client.login().then(() =>
        db.collection('Messages').updateOne({owner_id: client.authedId()}, {$set:{number:42}}, {upsert:true})
      ).then(() =>
        db.collection('Messages').find({owner_id: client.authedId()}).limit(100).execute()
      ).then(docs => {
        console.log("Found docs", docs)
        console.log("[MongoDB Stitch] Connected to Stitch")
      }).catch(err => {
        console.error(err)
      });
    });
  }

Error is:

polyfills.js:3 Uncaught TypeError: t.resolve is not a function
at Object.setNativePromise (polyfills.js:3)
at L.configurable.L.set (polyfills.js:3)
at module.exports (bson.js:298)
at $export (bson.js:106)
at Object. (bson.js:11113)
at webpack_require (bson.js:30)
at Object. (bson.js:8511)
at webpack_require (bson.js:30)
at Object. (bson.js:8372)
at Object. (bson.js:8398)

@shriharip - did you have any luck on sorting it out?

@phingers no I was not able to resolve and I moved back to firebase

I have it working in IONIC without the factory by importing
<script src="https://s3.amazonaws.com/stitch-sdks/js/library/stable/stitch.min.js"></script>
into index.html
Then in my TS files, I can do something similar too.

let client = new stitch.StitchClient(appId);

		let db = client.service("mongodb", "mongodb-atlas").db("DBNAMEHERE");
    client.login().then(() =>
        db.collection('Messages').updateOne({owner_id: client.authedId()}, {$set:{number:42}}, {upsert:true})
      ).then(() =>
        db.collection('Messages').find({owner_id: client.authedId()})
      ).then(docs => {
        console.log("Found docs", docs)
        console.log("[MongoDB Stitch] Connected to Stitch")
      }).catch(err => {
        console.error(err)
      });

Hope it helps someone else until it is patched properly.

@phingers Thanks will check it out then

@kensodemann Any update on a reliable fix for this issue?
We tried the workaround provided by @Capsup but now our code no longer builds on Ionic Deploy.

Also having this problem. It happens when I install npm package 'bson'. First, I was trying to import the 'mongodb' package but got a weird error Cannot find module "module" coming from the import statement. Then I tried explicitly installing its dependencies, and once I installed 'bson' and ran ionic serve I got this t.resolve() error. It is worth noting this error goes away if I comment out my import of 'mongodb'.
All the suggested workarounds seem specific to some other package I'm not using. Can anyone help with my case?

@rovashan - The workaround you refer to will not work on Ionic Pro because it will not have the hacked version of the polyfill.
Have you tried the workaround mentioned here: https://github.com/ionic-team/ionic/issues/13459#issuecomment-374850999

same for me trying to add mongodb-stitch, @phingers workaround didn't work for me
I think that npm uses the same sources as the js from aws

had the same problem with mongodb-stitch
played a lot with various settings and workarounds (different versions of angular, typescript, zone.js, custom fixes in zone.js lib)
the result is that I think there is currently no way to use it via npm, the only way was to add the stitch.min.js script BEFORE polyfill.js in html, and after
        const clientPromise = stitch.StitchClientFactory.create(this.appId);         this.stitchClient = await clientPromise;
with declare var stitch; at the top

Same problem here with ciscospark Browser SDK
anyone has solved the problem?
A solution could be to inject the bundle directly in index.html of the ionic project. The bundle is generated through browserify.

@iwasingh Did you find the solution? I've the same problem.


Support join filter for SortMergeJoin

Which issue does this PR close?

Closes #.
Rationale for this change

DataFusion SortMergeJoin doesn't support join filter for now. Any logical join operator with join filter could only be planned as HashJoinExec which supports join filter.
Spark SortMergeJoin supports join filter. Without join filter support, we cannot translate Spark SortMergeJoin operator to DataFusion.
What changes are included in this PR?

This patch adds join filter support to DataFusion SortMergeJoin.
Are these changes tested?

Are there any user-facing changes?

PTAL @metesynnada

Thanks for review. Found this has some issues on OUTER joins, going to revise this and add more tests.

Marking as a draft to make it clear this PR is not waiting on review

Thank you @alamb. I fixed the issue for outer joins and marked this ready for review again.

Thanks @viirya  -- I plan to review this later today

Thanks @alamb @metesynnada for review.


Simplify VideoPlayerActivity

I removed the feature that does not seem to use in VideoPlayerActivity.
If you will use it in future, please close this PR.

👀

Looks good!
Could you put screenshot?

Thx, let me check!

Okay! I was thinking loading from local but agree with delete redundnt code for the time being!

Awesome PR 💪  Thanks!!

@ogapants feel free to tackle!
https://github.com/konifar/droidkaigi2016/issues/380

I'll try it if possible... 💪


analyze a single video

Hello，Where is the  facility to analyze a single video.
How can I use this model to identify a single video?

You can. But this code does not provide this.


Labels do not show up at all

<MultiSlider
      containerStyle={{ height: 40 }}
      values={[value1, value2]}
      isMarkersSeparated
      sliderLength={300}
      enableLabel
      customLabel={() => <Text>Custom Label</Text>}
      min={0}
      max={100}
      enabledOne={false}
      enabledTwo={false}
      customMarkerLeft={marker}
      customMarkerRight={marker}
      selectedStyle={{
        backgroundColor: colors.purpleDark6,
        height: 2,
    }}
      unselectedStyle={{
        backgroundColor: colors.purpleDark5,
        height: 2,
    }}
/>

I see that a new property 'enableLabel' was introduced, but I have played around with it and some other properties and I cannot seem to get the labels to show up. Am I missing something?

Are you using the latest version from github, or the one from 2 years ago through npm?

I will publish the latest version to npm in just a few minutes!
Labels should then be visible, feel free to open up a new issue if it persists

2.2.0 is now released feel free to try it out

My requirement is to show custom label with the different value in every step. Like Range value point .

Hey @Anujmoglix did you find a solution to your problem?


Complete the process of using myFuncName in all log messages

Example:
+               myFuncName := caller.GetFuncName()

                log.Debugf(
-                       "Config file %q exists, attempting to open it",
+                       "%s: Config file %q exists, attempting to open it",
+                       myFuncName,
                        sanitizedFilePath,
                )
                // use direct function call here instead of our variable to comply
                // with gosec linting rules
                fh, err := os.Open(filepath.Clean(config.ConfigFile()))
                if err != nil {
-                       return nil, fmt.Errorf("unable to open config file: %v", err)
+                       return nil, fmt.Errorf(
+                               "%s: unable to open config file: %v",
+                               myFuncName,
+                               err,
+                       )

The exception might be where including the function name adds visual noise for output meant to be directly read/acted upon. That said, our target audience is a sysadmin who should be familiar with (or at least appreciate) the verbose nature of the log/error messages.
I've been making these changes as I've resolved recent linting issues (and likely before that), but spinning this issue off as a reminder to continue the work going forward.

See also GH-119 and f2aafe9fda15f0532801859f5b838449a64727fa specifically.


[Snyk] Upgrade com.google.auto.value:auto-value from 1.7 to 1.7.4

Snyk has created this PR to upgrade com.google.auto.value:auto-value from 1.7 to 1.7.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 4 versions ahead of your current version.
The recommended version was released 8 months ago, on 2020-07-08.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Already merged with #78


First Item Gets Cut off in RTL Mode

When having the timeline in RTL mode, I noticed that the first item gets cut off in the timeline. If you click the button to go left and then back right, it has no issue. It only happens on page load.

It seems to me like the issue is in position in timelinePosition().  I noticed that on page load, the position value is 1599, but if you click left and then back right, the position value is 1572. How do we get, in my case, the position value to be 1572 on page load?

hi, how can I make my vertical timeline started from the earliest value to the eldest one? for example, I need to have 1900 year in the top of TL, 1950 in the middle and 2000 in the bottom


Add motivation section

It wasn't clear to me at first how this library worked.  It took me a minute to figure out that the core idea is: turn the string into a node, so that React has no idea that you're trying to do something potentially insecure.
Hopefully this is clear!

Thanks for your contribution.
I'm afraid I will not merge this, because...

I think the usage is quite clear by description and examples, if a user understand how React works.
It provides such a simple API (actually 1), and it would be better to just see the code quickly.
It's slow as described in cons, and I would say it's not proper for daily React usages. I think Motivation is too much for this kind of toy ;)

I again appreciate your work, and sorry not accepting it.


MF-859 - Channels metadata search

What does this do?
add retrieve channels my metadata criteria
Which issue(s) does this PR fix/relate to?
Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
Resolves #859
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes

Codecov Report

Merging #867 into master will decrease coverage by 0.65%.
The diff coverage is 57.65%.

@@            Coverage Diff            @@
##           master    #867      +/-   ##
=========================================
- Coverage   85.45%   84.8%   -0.66%
=========================================
  Files          72      72
  Lines        4744    4824      +80
=========================================
+ Hits         4054    4091      +37
- Misses        451     488      +37
- Partials      239     245       +6

Impacted Files
Coverage Δ

users/users.go
68.42% <ø> (ø)
:arrow_up:

users/api/http/responses.go
50% <0%> (-50%)
:arrow_down:

users/service.go
71.42% <0%> (-28.58%)
:arrow_down:

users/api/http/requests.go
33.33% <0%> (-66.67%)
:arrow_down:

users/postgres/init.go
85.71% <100%> (+3.1%)
:arrow_up:

things/redis/streams.go
90.47% <100%> (ø)
:arrow_up:

things/api/things/http/endpoint.go
98.23% <100%> (ø)
:arrow_up:

things/service.go
88.02% <100%> (ø)
:arrow_up:

things/postgres/init.go
93.44% <100%> (+0.85%)
:arrow_up:

users/api/http/endpoint.go
68% <11.11%> (-32%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3bb27...9293d49. Read the comment docs.

@drasko 10 seconds is the maximum time which we wait until natsd is started. It's a timeout when we give up.
It is checked if a connection can be made on the port 4222 and if that's not possible, the script sleeps for half a second and tries again. In a case where natsd starts before the timeout is fired(within 10 seconds), the maximum extra time which the user waits is half a second.

@chombium I know, but I think there is no need to wait 10 seconds. If NATS does not start in 3-5 sec - there is probably something wrong beyond repair, better break out.
I can accept this, but never the less I think it is not needed...

@drasko I agree with you. If we are sure that 3-5 seconds are enough than we can lower the timeout

I think yes


Can't Combine Candlestick and Line charts in Blazor-ApexCharts

Hello,
I was trying to combine Candlestick and Line charts, but I got an error:
System.AggregateException: One or more errors occurred. (Chart Type Candlestick connot be mixed)
---> System.Exception: Chart Type Candlestick connot be mixed
at ApexCharts.ApexChart1.GetMixedChartType(ChartType chartType)    at ApexCharts.ApexChart1.SetSeries()
at ApexCharts.ApexChart1.PrepareChart()    at ApexCharts.ApexChart1.RenderChartAsync()
at ApexCharts.ApexChart`1.OnAfterRenderAsync(Boolean firstRender)
--- End of inner exception stack trace ---
And the combo is possible with pure Apex.js
Is there a way I make such combo with Blazor_ApexCharts or it is not currently supported?
Thank you.

Hello,
Looks like I'm to restrictive when checking what can be mixed.
I'll look into it.

Hello,
Looks like I'm to restrictive when checking what can be mixed. I'll look into it.

Alright Joadan.
I will be expecting your prompt feedback.
Regards.

Check sample https://apexcharts.github.io/Blazor-ApexCharts/candlestick-charts#mixed

Fixed in v0.9.3-beta

Thanks for you prompt response and fix, Joakim.
I will update the nugget package and try it out

Hello,
I am still getting the error and I have updated to version 0.9.3-beta.
Below is my .csproj file:

net6.0

..\..\..\..\..\..\Build\V12\IWGIV12_Binaries\IWK.dll

..\..\..\..\..\..\Build\V12\IWGIV12_Binaries\IWNet.dll

Kindly assist.
THanks

Sorry for this, the fix is included in  v0.9.4-beta

@joadan , I will try it out again.
Thanks

I am fine now.
Thanks, @joadan


Replace Framework::bitmap with UIStyleAssets::bitmap in balsamiq_layout_loader

[ ] remove the header
[ ] remove the Framework::bitmap call under "Image"

Related to https://github.com/MarkOates/allegro_flare/issues/28

Closing due to removal of balsamiq_layout_loader (as discussed in https://github.com/MarkOates/allegro_flare/issues/62#issuecomment-230637276)


duplicate CORS headers leads to browser CORS errors

Describe the bug
If you connect a backend api via proxy block and you have CORS options enabled and the api sends also such headers this leads to duplicate cors headers which the browser does not allow.
Current workaround is to add remove_response_headers = ["access-control-allow-origin", "access-control-allow-credentials"] to your backend definition.

The problem may also occur with request:
    endpoint "/foo" {
      request "r" {
        url = "/bar"
        backend = "be"
      }
      response {
        headers = backend_responses.r.headers
      }
    }

The CORS response headers must not be set before
	nextHandler.ServeHTTP(rw, req)

in CORS.ServeNextHTTP(). Instead we could register headers to remove/set/add with the writer.Response and execute the modifications after (? or before?) r.applyModifier().

The desired effect is that the a-c-a-* headers generated by Couper's cors block always win.(we do not want to be "smart" and try to merge the headers).
Ideally, we use the set modifier to make sure that our generated header override any corresponding header coming from the upstream response.
However, we might have the situation where the upstream sends more CORS headers than Couper would generate, e.g. max-age or allow-credentials. In this case we have to actively remove those headers to avoid mixed or unexpected CORS statements.

Does the problem only occur with payload requests? The OPTIONS PFR is handled by Couper without actually executing the endpoint, isn't it?

Does the problem only occur with payload requests? The OPTIONS PFR is handled by Couper without actually executing the endpoint, isn't it?

Yes

Ideally, we use the set modifier to make sure that our generated header override any corresponding header coming from the upstream response.

We already set them. The problem is not to set it (in contrast to add), it's the right point in the process: The response headers must not be set prior to the nextHandler's ServeHTTP() (as they are, currently), because some next handler will add/set the backend's response headers.

However, we might have the situation where the upstream sends more CORS headers than Couper would generate, e.g. max-age or allow-credentials. In this case we have to actively remove those headers to avoid mixed or unexpected CORS statements.

ACK


"private" access control visible in extensions

This should go through the "pitch" phase on swift-evolution.

Hi Chris, thanks for your reply. I've just followed the instructions from "process.md" file, and it is never said anything about "pitch" phase. What does it mean? And how can I (or who is responsible) to put this topic into the "pitch" phase? Thank you! Best regards, Uros.

"socialize the idea" under https://github.com/apple/swift-evolution/blob/master/process.md


feat: handle AND/OR and priority in matches fn

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
The A in AST is for abstract. So does this patch
Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features

Enhanced pattern matching functionality for more efficient and flexible pattern expressions.

Refactor

Restructured AST transformation process for improved code readability and maintainability.

@coderabbitai pause

Looks good to me. I have a question: how can we match string literals that are keywords, such as AND and OR? Is there a way to escape them?

quote them should fine. I'll add a test case for this.


Subscribe to #2625 to find when it is resolved


Implement blocking via declarativeNetRequest API

Parent Issue: https://github.com/ipfs/ipfs-companion/issues/1152
Blocked By: https://github.com/ipfs/ipfs-companion/issues/1155
### Tasks
- [ ] Implement `declarativeNetRequest` to update URL blocking based on populated LFU.
- [ ] Route blocked requests conventionally.

@BigLep this is the issue tracking the user-value benefits of ipfs-companion once mv3 is done

@whizzzkid : what is meant by "Route blocked requests conventionally"?  Is that the end of the done criteria?