generated/help.h:427:29: warning: missing terminating " character

In ALT Linux we have package rebuilds and occasionally it reports build errors for toybox. (It builds with make -j8).
I think this is related to generated/help.h generated incorrectly. I manually didn't catch this so can't see what is there.
Error examples:

https://git.altlinux.org/beehive/logs/Sisyphus/x86_64/archive/2023/1231/error/toybox-0.8.10-alt1

musl-gcc -I/etc/sysconfig/kernel/include -pipe -frecord-gcc-switches -Wall -g -O2 -flto=auto -Wall -Wundef -Werror=implicit-function-declaration -Wno-char-subscripts -Wno-pointer-sign -funsigned-char -I . -Os -ffunction-sections -fdata-sections -fno-asynchronous-unwind-tables -fno-strict-aliasing -c toys/lsb/pidof.c -o generated/obj/pidof.o
In file included from main.c:74:
generated/help.h:427:29: warning: missing terminating " character
  427 | #define HELP_mke2fs_journal "usage: .
      |                             ^
generated/help.h:428:6: error: 'E' undeclared here (not in a function)
  428 | ДЄs [-E stride=###] [-O option[,option]] [-L label] [-M path] [-o string] [-j] [-J size=###,device=XXX]\n\n-E stride= Set RAID stripe size (in blocks)\n-J         Journal options\n-L         Volume label\n-M         Path to mount point\n-O [opts]  Specify fewer ext2 option flags (for old kernels)\n-j         Create journal (ext3)\n-o         Created by\n           size: Number of blocks (1024-102400)\n           device: Specify an external journal\n           All of these are on by default (as appropriate)\n   none         Clear default options (all but journaling)\n   dir_index    Use htree indexes for large directories\n   filetype     Store file type info in directory entry\n   has_journal  Set by -j\n   journal_dev  Set by -J device=XXX\n   sparse_super Don't allocate huge numbers of redundant superblocks"
      |      ^
generated/help.h:428:7: error: expected ']' before 'stride'

https://git.altlinux.org/beehive/logs/Sisyphus/x86_64/archive/2024/0108/error/toybox-0.8.10-alt1

musl-gcc -I/etc/sysconfig/kernel/include -pipe -frecord-gcc-switches -Wall -g -O2 -flto=auto -Wall -Wundef -Werror=implicit-function-declaration -Wno-char-subscripts -Wno-pointer-sign -funsigned-char -I . -Os -ffunction-sections -fdata-sections -fno-asynchronous-unwind-tables -fno-strict-aliasing -c toys/lsb/gzip.c -o generated/obj/gzip.o
In file included from main.c:74:
generated/help.h:427:29: warning: missing terminating " character
  427 | #define HELP_mke2fs_journal "usage:
      |                             ^
generated/help.h:428:1: error: stray '\275' in program
  428 | <bd> <83><94>s [-E stride=###] [-O option[,option]] [-L label] [-M path] [-o string] [-j] [-J size=###,device=XXX]\n\n-E stride= Set RAID stripe size (in blocks)\n-J         Journal options\n-L         Volume label\n-M         Path to mount point\n-O [opts]  Specify fewer ext2 option flags (for old kernels)\n-j         Create journal (ext3)\n-o         Created by\n           size: Number of blocks (1024-102400)\n           device: Specify an external journal\n           All of these are on by default (as appropriate)\n   none         Clear default options (all but journaling)\n   dir_index    Use htree indexes for large directories\n   filetype     Store file type info in directory entry\n   has_journal  Set by -j\n   journal_dev  Set by -J device=XXX\n   sparse_super Don't allocate huge numbers of redundant superblocks"
      | ^~~~
generated/help.h:428:3: error: stray '\203' in program

Sigh, this may be another manifestation of https://github.com/landley/toybox/issues/458 (they couldn't get me the breaking input files either. I think I know what's going wrong but it really seems like it would be an impossible input unless you patched the source...)
I'm trying to redo the help plumbing so it doesn't need config2help anymore, but had an attack of life and I'm 3 months behind getting the October toybox release out. I'll bump this up in priority now that a second user's seen it. (Fixing what's there without a test case would be a bit of stab in the dark, but I can make an attempt if I can't get the proper fix in soonish.)

Well, I can easily reproduce this, since it's just probabilistic, running builds in cycle. Now for the error:
In file included from main.c:74:
generated/help.h:427:29: warning: missing terminating " character
  427 | #define HELP_mke2fs_journal "usage: <F9>
      |                             ^
generated/help.h:428:2: error: stray '\242' in program
  428 | <U+0197><a2>s [-E stride=###] [-O option[,option]] [-L label] [-M path] [-o string] [-j] [-J size=###,device=XXX]\n\n-E stride= Set RAID stripe size (in blocks)\n-J         Journal options\n-L         Volume label\n-M         Path to mount point\n-O [opts]  Specify fewer ext2 option flags (for old kernels)\n-j         Create journal (ext3)\n-o         Created by\n           size: Number of blocks (1024-102400)\n           device: Specify an external journal\n           All of these are on by default (as appropriate)\n   none         Clear default options (all but journaling)\n   dir_index    Use htree indexes for large directories\n   filetype     Store file type info in directory entry\n   has_journal  Set by -j\n   journal_dev  Set by -J device=XXX\n   sparse_super Don't allocate huge numbers of redundant superblocks"
      |         ^~~~
generated/help.h:428:1: error: unknown type name '\U00000197'
  428 | Ɨ<A2>s [-E stride=###] [-O option[,option]] [-L label] [-M path] [-o string] [-j] [-J size=###,device=XXX]\n\n-E stride= Set RAID stripe size (in blocks)\n-J         Journal options\n-L         Volume label\n-M         Path to mount point\n-O [opts]  Specify fewer ext2 option flags (for old kernels)\n-j         Create journal (ext3)\n-o         Created by\n           size: Number of blocks (1024-102400)\n           device: Specify an external journal\n           All of these are on by default (as appropriate)\n   none         Clear default options (all but journaling)\n   dir_index    Use htree indexes for large directories\n   filetype     Store file type info in directory entry\n   has_journal  Set by -j\n   journal_dev  Set by -J device=XXX\n   sparse_super Don't allocate huge numbers of redundant superblocks"
      | ^
generated/help.h:428:7: error: 'E' undeclared here (not in a function)

builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ cat -v -n generated/help.h | grep -w -1 428
   427  #define HELP_mke2fs_journal "usage: M-y^MM-FM-^WM-"s [-E stride=###] [-O option[,option]] [-L label] [-M path] [-o string] [-j] [-J size=###,device=XXX]\n\n-E stride= Set RAID stripe size (in blocks)\n-J         Journal options\n-L         Volume label\n-M         Path to mount point\n-O [opts]  Specify fewer ext2 option flags (for old kernels)\n-j         Create journal (ext3)\n-o         Created by\n           size: Number of blocks (1024-102400)\n           device: Specify an external journal\n           All of these are on by default (as appropriate)\n   none         Clear default options (all but journaling)\n   dir_index    Use htree indexes for large directories\n   filetype     Store file type info in directory entry\n   has_journal  Set by -j\n   journal_dev  Set by -J device=XXX\n   sparse_super Don't allocate huge numbers of redundant superblocks"
   428
   429  #define HELP_mke2fs "usage: mke2fs [-Fnq] [-b ###] [-N|i ###] [-m ###] device\n\nCreate an ext2 filesystem on a block device or filesystem image.\n\n-F         Force to run on a mounted device\n-n         Don't write to device\n-q         Quiet (no output)\n-b size    Block size (1024, 2048, or 4096)\n-N inodes  Allocate this many inodes\n-i bytes   Allocate one inode for every XXX bytes of device\n-m percent Reserve this percent of filesystem space for root user"

Looks like garbage after usage: and before [-E stride, and it's random:
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 5f6a 6f75 726e  ELP_mke2fs_journ
00000020: 616c 2022 7573 6167 653a 20da b88c a254  al "usage: ....T
00000030: 7320 5b2d 4520 7374 7269 6465 3d23 2323  s [-E stride=###
00000040: 5d20 5b2d 4f20 6f70 7469 6f6e 5b2c 6f70  ] [-O option[,op
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 5f6a 6f75 726e  ELP_mke2fs_journ
00000020: 616c 2022 7573 6167 653a 20f0 9fe3 ca39  al "usage: ....9
00000030: 7320 5b2d 4520 7374 7269 6465 3d23 2323  s [-E stride=###
00000040: 5d20 5b2d 4f20 6f70 7469 6f6e 5b2c 6f70  ] [-O option[,op
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 5f6a 6f75 726e  ELP_mke2fs_journ
00000020: 616c 2022 7573 6167 653a 2003 1b34 7a97  al "usage: ..4z.
00000030: 7320 5b2d 4520 7374 7269 6465 3d23 2323  s [-E stride=###
00000040: 5d20 5b2d 4f20 6f70 7469 6f6e 5b2c 6f70  ] [-O option[,op
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 5f6a 6f75 726e  ELP_mke2fs_journ
00000020: 616c 2022 7573 6167 653a 2095 3aa1 57b0  al "usage: .:.W.
00000030: 7320 5b2d 4520 7374 7269 6465 3d23 2323  s [-E stride=###
00000040: 5d20 5b2d 4f20 6f70 7469 6f6e 5b2c 6f70  ] [-O option[,op
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 5f6a 6f75 726e  ELP_mke2fs_journ
00000020: 616c 2022 7573 6167 653a 20bb 4ed8 3a0e  al "usage: .N.:.
00000030: 7320 5b2d 4520 7374 7269 6465 3d23 2323  s [-E stride=###
00000040: 5d20 5b2d 4f20 6f70 7469 6f6e 5b2c 6f70  ] [-O option[,op

Run under valgrind:
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ gcc  -g -O2 scripts/config2help.c -o generated/unstripped/config2help
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ valgrind generated/unstripped/config2help Config.in .config > a
==189753== Memcheck, a memory error detector
==189753== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==189753== Using Valgrind-3.17.0 and LibVEX; rerun with -h for copyright info
==189753== Command: generated/unstripped/config2help Config.in .config
==189753==
--189753-- WARNING: unhandled amd64-linux syscall: 334
--189753-- You may be able to write your own handler.
--189753-- Read the file README_MISSING_SYSCALL_OR_IOCTL.
--189753-- Nevertheless we consider this a bug.  Please report
--189753-- it at http://valgrind.org/support/bug_reports.html.
==189753== Invalid read of size 1
==189753==    at 0x4847229: strnlen (vg_replace_strmem.c:436)
==189753==    by 0x48F74BB: strndup (in /lib64/libc.so.6)
==189753==    by 0x1095DF: main (config2help.c:365)
==189753==  Address 0x4adba8b is 11 bytes inside a block of size 120 free'd
==189753==    at 0x4843F4C: free (vg_replace_malloc.c:755)
==189753==    by 0x1098EB: main (config2help.c:460)
==189753==  Block was alloc'd at
==189753==    at 0x484179B: malloc (vg_replace_malloc.c:380)
==189753==    by 0x48CD35D: getdelim (in /lib64/libc.so.6)
==189753==    by 0x10A78C: parse (config2help.c:241)
==189753==    by 0x10A979: parse (config2help.c:255)
==189753==    by 0x10920F: main (config2help.c:314)
==189753==
==189753== Invalid read of size 1
==189753==    at 0x484BF80: __memcpy_chk (vg_replace_strmem.c:1617)
==189753==    by 0x1095DF: main (config2help.c:365)
==189753==  Address 0x4adba90 is 16 bytes inside a block of size 120 free'd
==189753==    at 0x4843F4C: free (vg_replace_malloc.c:755)
==189753==    by 0x1098EB: main (config2help.c:460)
==189753==  Block was alloc'd at
==189753==    at 0x484179B: malloc (vg_replace_malloc.c:380)
==189753==    by 0x48CD35D: getdelim (in /lib64/libc.so.6)
==189753==    by 0x10A78C: parse (config2help.c:241)
==189753==    by 0x10A979: parse (config2help.c:255)
==189753==    by 0x10920F: main (config2help.c:314)
==189753==
==189753== Invalid read of size 1
==189753==    at 0x484BF8D: __memcpy_chk (vg_replace_strmem.c:1617)
==189753==    by 0x1095DF: main (config2help.c:365)
==189753==  Address 0x4adba8e is 14 bytes inside a block of size 120 free'd
==189753==    at 0x4843F4C: free (vg_replace_malloc.c:755)
==189753==    by 0x1098EB: main (config2help.c:460)
==189753==  Block was alloc'd at
==189753==    at 0x484179B: malloc (vg_replace_malloc.c:380)
==189753==    by 0x48CD35D: getdelim (in /lib64/libc.so.6)
==189753==    by 0x10A78C: parse (config2help.c:241)
==189753==    by 0x10A979: parse (config2help.c:255)
==189753==    by 0x10920F: main (config2help.c:314)
==189753==

(First valgrind run was without -g and not very informative about source line numbers, This output above is regenerated after recompile after I already found problematic line with ASan.) Anyway, it looked like a memory corruption and I tried ASan:
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ gcc -fsanitize=address  -g -O2 scripts/config2help.c -o generated/unstripped/config2help
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config > a
=================================================================
==188909==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c000071a4b at pc 0x7feba45ee44c bp 0x7ffe01e46640 sp 0x7ffe01e45de8
READ of size 6 at 0x60c000071a4b thread T0
    #0 0x7feba45ee44b  (/usr/lib64/libasan.so.8+0x6e44b) (BuildId: a74d5a7d37a69f840ee795974830b5763483896c)
    #1 0x561868e8fdbc in main scripts/config2help.c:365
    #2 0x7feba43c0c8b  (/lib64/libc.so.6+0x27c8b) (BuildId: 8d90d7392295faafc24f1c706c43e4dede4a998b)
    #3 0x7feba43c0d44 in __libc_start_main (/lib64/libc.so.6+0x27d44) (BuildId: 8d90d7392295faafc24f1c706c43e4dede4a998b)
    #4 0x561868e918b0 in _start (/usr/src/RPM/BUILD/toybox-0.8.10/generated/unstripped/config2help+0x48b0) (BuildId: cadd746ba218d161aae375c0fd7843f6e499d997)

0x60c000071a4b is located 11 bytes inside of 120-byte region [0x60c000071a40,0x60c000071ab8)
freed by thread T0 here:
    #0 0x7feba465d090  (/usr/lib64/libasan.so.8+0xdd090) (BuildId: a74d5a7d37a69f840ee795974830b5763483896c)
    #1 0x561868e90c7c in main scripts/config2help.c:460

previously allocated by thread T0 here:
    #0 0x7feba465e54f in __interceptor_malloc (/usr/lib64/libasan.so.8+0xde54f) (BuildId: a74d5a7d37a69f840ee795974830b5763483896c)
    #1 0x7feba441035d in __getdelim (/lib64/libc.so.6+0x7735d) (BuildId: 8d90d7392295faafc24f1c706c43e4dede4a998b)

After it remove that free at config2help.c:460:
        //free(tusage);

Now it does not produce the difference:
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ gcc  -g -O2 scripts/config2help.c -o generated/unstripped/config2help
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 2022 7573 6167  ELP_mke2fs "usag
00000020: 653a 206d 6b65 3266 7320 5b2d 4520 7374  e: mke2fs [-E st
00000030: 7269 6465 3d23 2323 5d20 5b2d 4f20 6f70  ride=###] [-O op
00000040: 7469 6f6e 5b2c 6f70 7469 6f6e 5d5d 205b  tion[,option]] [
builder@x86_64:~/RPM/BUILD/toybox-0.8.10$ generated/unstripped/config2help Config.in .config | cat -n | grep -w 427 | xxd | head -5
00000000: 2020 2034 3237 0923 6465 6669 6e65 2048     427.#define H
00000010: 454c 505f 6d6b 6532 6673 2022 7573 6167  ELP_mke2fs "usag
00000020: 653a 206d 6b65 3266 7320 5b2d 4520 7374  e: mke2fs [-E st
00000030: 7269 6465 3d23 2323 5d20 5b2d 4f20 6f70  ride=###] [-O op
00000040: 7469 6f6e 5b2c 6f70 7469 6f6e 5d5d 205b  tion[,option]] [

Looks not corrupted.

Just to confirm this is not fixed in 0.8.11.
Build log https://git.altlinux.org/beehive/logs/Sisyphus/x86_64/archive/2024/0428/error/toybox-0.8.11-alt1

@vt-alt  Does your fix work?
I'm seeing this failure a lot. Can anyone help?
Thanks!

@vt-alt Does your fix of removing free work?
I'm seeing this failure a lot. Can someone help?
Thanks!


Error while fetching and getting value of key (encrypted deployment)

There're 2 deployments encrypted, so it's expected to appear as failed deployments but this doesn't happen.
It's because the logs are from migration.

Verified on Devnet,
The issue isn't reproducible till now; I will try more and reopen if it happens again.

I got the same error on qanet 2.2.0-rc2

Got the same error on QAnet

verified and cannot reproduce anymore on:

Devnet
version: d87cc99

Reproduced again!

Devnet
version: d87cc99

i got the same error on devnet dashboard

Verified the failed deployment in the pop-up message;
only one concern the error message showd be shown in the pop-up.
will be followed here:
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1214

Devnet
2.3.0-alpha3


Support Swift 4.1

Description

Re-working of #241 to remove some unnecessary changes, and update the LoggerAPI and CCurl dependencies for Swift 4.1 compatibility.
Motivation and Context

Enables Kitura-net and dependents to build on Swift 4.1.
How Has This Been Tested?

I have built and run the tests locally on Linux and OSX.
Checklist:

[x] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

Codecov Report

Merging #242 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   74.65%   74.68%   +0.02%
==========================================
  Files          31       31
  Lines        4167     4171       +4
==========================================
+ Hits         3111     3115       +4
  Misses       1056     1056

Flag
Coverage Δ

#CHTTPParser
57.52% <ø> (ø)
:arrow_up:

#KituraNet
74.68% <100%> (+0.02%)
:arrow_up:

Impacted Files
Coverage Δ

Sources/KituraNet/BufferList.swift
89.58% <100%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0837058...0701172. Read the comment docs.


Add openapi to peer dependency

Fix #4175

cc @chunyu3  as you are working on adopting TypeSpec 0.53


Add u64 module with to_string functions

Description
Add u64 module with to_string functions
fun to_string(value: u64): string::String
fun to_ascii_string(value: u64): ascii::String
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[x] user-visible impact
[ ] breaking change for a client SDKs
[x] breaking change for FNs (FN binary must upgrade)
[x] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
New sui::u64 module with to_string functions

Thanks for contributing @hokage229 !  This change looks reasonable to me. @damirka, do the names of public functions seem reasonable to you?  We won't be able to change those once we merge, and this will have implications for any other type-specific framework modules we introduce, so want to double check that before giving the final stamp.
Also, @hokage229, the license check is currently failing on u64.move, because it's missing the following at the top:
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0

Thanks for the contribution, @hokage229 :)
+1 to all of @tzakian's comments! Except...

What are your thoughts on suffixing the current public functions with _decimal (e.g., to_string_decimal) or similar, since we may wish to support other to_string representations for u64s in the future?

I personally would be fine with decimal being the "default" to string function, as I would assume this is what most folks would expect.


Calling popup menu in fullscreen mode make flickering on the screen (DisplayServer regression)

Godot version:
f1832a6027529332b91fe1786ba58e8e9af43fd7
OS/device including version:
Win10/GTX1060
Issue description:
Clicking(especially frequent) on these buttons which called popup menus
 will cause the whole screen flickering with dark flash.
Steps to reproduce:
Simply run the empty project, toggle fullscreen (Shift+F11), and try to use the buttons showed above.
Single Window Mode should be disabled (of course).
Minimal reproduction project:
It's not recordable with ScreenToGIF unfortunately.

It's not recordable with ScreenToGIF unfortunately.

You could record your screen using your phone :stuck_out_tongue:

It's not recordable with ScreenToGIF unfortunately.

You could record your screen using your phone :stuck_out_tongue:

It's unprofessionally :) but ok - https://drive.google.com/file/d/1RyWLsCaUC53o7dFY3Kt784x45E54iiyB/view?usp=sharing

It's unprofessionally :) but ok - https://drive.google.com/file/d/1RyWLsCaUC53o7dFY3Kt784x45E54iiyB/view?usp=sharing

Pretty sure you can attach videos directly to github posts now.

Pretty sure you can attach videos directly to github posts now.

https://user-images.githubusercontent.com/3036176/103982053-d0cbed80-5193-11eb-9fd3-7d99f0c73969.mp4

https://user-images.githubusercontent.com/3036176/103982053-d0cbed80-5193-11eb-9fd3-7d99f0c73969.mp4

Is that a recent regression?

Is that a recent regression?

At 41e9028868e49669de83c82ba20fd9dcef0d1b8b the pressing these buttons in fullscreen leads to editor window become invisible (which is fixed by 8a2bc6bf58e305a55ae7b54b8eeafa435575c744) so I guess its exist at the point where Juan separated display server (10 months ago). But need to test for sure.

At 41e9028868e49669de83c82ba20fd9dcef0d1b8b the pressing these buttons in fullscreen leads to editor window become invisible (which is fixed by 8a2bc6bf58e305a55ae7b54b8eeafa435575c744) so I guess its exist at the point where Juan separated display server (10 months ago). But need to test for sure.

Also found an interesting article about possible fixing it: https://github.com/glfw/glfw/issues/527

Also found an interesting article about possible fixing it: https://github.com/glfw/glfw/issues/527

After some experimenting I found 2 ways to solve this problem:

Append 1 pixel to the height of the window which enters fullscreen mode. The downside of this - the client rect will be changed and this may alter the content.
Change WS_POPUP to WS_CHILD for borderless windows. The downside of this is child windows behaved differently than WS_POPUP for example their positions and event processing needs to be modified. They don't close automatically if the users changed window focus.

After some experimenting I found 2 ways to solve this problem:

Append 1 pixel to the height of the window which enters fullscreen mode. The downside of this - the client rect will be changed and this may alter the content.
Change WS_POPUP to WS_CHILD for borderless windows. The downside of this is child windows behaved differently than WS_POPUP for example their positions and event processing needs to be modified. They don't close automatically if the users changed window focus.

It's not only the editor problem - games will be affected too (if the Embed subwindows is disabled in the project settings)

It's not only the editor problem - games will be affected too (if the Embed subwindows is disabled in the project settings)

This issue seems fixed at fe7559f751e81b21da2eb8252123f384b8a8622d. This may be caused by either engine or Windows upgrade.

This issue seems fixed by https://github.com/godotengine/godot/pull/54645


remove Proxy use to support ios9

Proxy isn't supported in ios9 and cannot be polyfilled

Ah did not know it wasn't supported. Should have known that it can't be polyfilled though.
Your fix looks solid. Merging. :( I was so happy when I got to use Proxy though...

Released under 0.0.59

👍 perfect! thanks.


Not able to connect Trust wallet

Hello,
I want to connect to Trust wallet, But unfortunately it doesn't connect with it.
I have run the Mobile example app of this demo and tried to scan the QR code from the Trust Wallet, but it gives a prompt msg of "Connecting! please wait"  , Nothing happens after that.

For me, this happens when I try to connect to TrustWallet without a VPN because my country is embargoed, Or I try to make a new connection again without waiting for the connection to be established

I have the same problem with TrustWallet and SafePal

I found problem. TrustWallet and SafePal ,... (except MetaMask) just connect to mainNet. you have to change chainID from 3 (ropsten) to 1 (mainnet). That's it.

@MohsenHaydari found problem. TrustWallet and SafePal ,... (except MetaMask) just connect to mainNet. you have to change chainID from 3 (ropsten) to 1 (mainnet). Then change Web3Client url to a mainNet url for example 'https://rpc.flashbots.net/'. That's it.
//chainID list https://besu.hyperledger.org/en/stable/Concepts/NetworkID-And-ChainID/
//mainNet urls https://chainlist.org/chain/1
//ethereum_transaction_tester.dart
final ethereum = Web3Client('https://rpc.flashbots.net/', Client());
return connector.connect(chainId: 1, onDisplayUri: onDisplayUri);

Just to make it more clear, trust wallet won't accept any testnet, was trying over Polygon mumbai, and It didn't worked until I changed to polygon mainnet


JVM core dump when run couchbase client

I just test the simple Couchbase client on
docker image: eclipse-temurin:11.0.13_8-jdk-alpine
it will crash
Stack: [0x00007f67062c9000,0x00007f67063c9ad8],  sp=0x00007f67063c5d18,  free space=1011k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  0x0000000000003efe
C  [libcom_couchbase_client_core_deps_netty_transport_native_epoll_x86_643497901388108310511.so+0xb487]  netty_jni_util_JNI_OnLoad+0x67
C  [libjava.so+0xfc8a]  Java_java_lang_ClassLoader_00024NativeLibrary_load0+0xba

but the same code could run in
docker image: adoptopenjdk/openjdk11:jdk-11.0.13_8-alpine-slim
reproduce step
docker run -it --rm --mount type=bind,source="$(pwd)"/,target=/src  --entrypoint /bin/sh eclipse-temurin:11.0.13_8-jdk-alpine
 cd src
 ./run.sh
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000000000003efe, pid=26, tid=27
#
# JRE version: OpenJDK Runtime Environment Temurin-11.0.13+8 (11.0.13+8) (build 11.0.13+8)
# Java VM: OpenJDK 64-Bit Server VM Temurin-11.0.13+8 (11.0.13+8, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# C  0x0000000000003efe
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /src/hs_err_pid26.log
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
Aborted

Test code:   https://rak.box.com/s/jqjxz3fkbirpd3zzo4bj3216yjo16e0n

both images using the same JDK version
I check Java
in eclipse-temurin:11.0.13_8-jdk-alpine
/opt/java/openjdk/bin # ldd ./java
    /lib/ld-musl-x86_64.so.1 (0x7fee26ef8000)
    libjli.so => ./../lib/jli/libjli.so (0x7fee26ee1000)
    libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7fee26ef8000)
    libz.so.1 => /lib/libz.so.1 (0x7fee26ec7000)

in adoptopenjdk/openjdk11:jdk-11.0.13_8-alpine-slim
/opt/java/openjdk/bin # ldd ./java
/lib64/ld-linux-x86-64.so.2 (0x7f66f69c6000)
libz.so.1 => /lib/libz.so.1 (0x7f66f67a9000)
libpthread.so.0 => /lib64/ld-linux-x86-64.so.2 (0x7f66f69c6000)
libjli.so => ./../lib/jli/libjli.so (0x7f66f6598000)
libdl.so.2 => /lib64/ld-linux-x86-64.so.2 (0x7f66f69c6000)
libc.so.6 => /lib64/ld-linux-x86-64.so.2 (0x7f66f69c6000)
seem different, not sure related or not.

crash at
https://github.com/netty/netty-jni-util/blob/main/src/main/c/netty_jni_util.c

seem it's netty
https://github.com/netty/netty/issues/6841#issuecomment-307716433

I will work after disabling native netty
https://githubmemory.com/repo/micrometer-metrics/micrometer/issues/2776
-Dcom.couchbase.client.core.deps.io.netty.transport.noNative=true


How to know if an agent is in another's attack range?

Hi there, I would like to know if there is an function to get the bool of if an agent is in another's attack_range, or to get all agents attackable.
If there is not, I know that attack range is set by CircleRange(radius).
Is the radius means  the euclidean distance between two agents?

Hi, there currently is not a function that returns such values. And you are correct about the CircleRange(radius).


Refactor CLI and implement fetch-params

Summary of changes
Changes introduced in this pull request:

Refactors CLI to setup framework for subcommands

Now forest still runs the daemon, but subcommands can be run as forest <cmd> such as here is forest fetch-params ..

fetch-params command implemented which will fetch params based on the options of command and put into the params cache to be used in proof verification

Options are self-documenting by adding the help flag when running the command
Verbose flag will use progress bars for the download progress (doesn't always show up cleanly because async logger and the progress bar std out don't always play nicely

The params fetching is all done in parallel and async
Reference issue to close (if applicable)

Closes #508
Other information and links

LGTM. I hear reqwest is pretty heavy. It is recommended to use Surf. Surf has a lot of overlapping libs with Tide since they're built by the same people. Up to you if you think its worth the change though

Yeah thing was is that it seemed they were still on alpha for using stable futures so didn't seem worth the trial and error, I will play around with it now for a bit though

I made a bunch of changes so just going to assume reviews invalid @AshantiMutinta @ec2 (sorry they were pretty necessary changes)


TypeError: Cannot read property 'children' of undefined

Crash while opening rst files from https://github.com/ansible-community/ansible-lint project.
[2022-03-20 08:45:06.916] [exthost] [error] [trond-snekvik.simple-rst] provider FAILED
[2022-03-20 08:45:06.916] [exthost] [error] TypeError: Cannot read property 'children' of undefined
	at RstSectionProvider.provideDocumentSymbols (/Users/ssbarnea/.vscode/extensions/trond-snekvik.simple-rst-1.5.2/out/extension.js:52:41)
	at f.provideDocumentSymbols (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:91179)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:117502
	at be._withAdapter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:116655)
	at be.$provideDocumentSymbols (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:117480)
	at n._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:89:13812)
	at n._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:89:13496)
	at n._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:89:12107)
	at n._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:89:10836)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:89:8945
	at d.invoke (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
	at w.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1856)
	at c.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:19017)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:34267
	at d.invoke (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
	at w.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1856)
	at c.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:19017)
	at s._receiveMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:23598)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:21132
	at d.invoke (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
	at w.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1856)
	at w.acceptChunk (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:15848)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:14978
	at Socket.P (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:13790)
	at Socket.emit (events.js:315:20)
	at addChunk (internal/streams/readable.js:309:12)
	at readableAddChunk (internal/streams/readable.js:284:9)
	at Socket.Readable.push (internal/streams/readable.js:223:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

Reproduced with v1.5.2

Hi, I think I encountered the same issue. The extension fails if the conditions bellow met at the same time:

There are two or more top level headings
The first heading doesn’t have a child heading

Under the condition, (a) on finding the first heading the extension pushes it into a stack, (b) pops it on finding the second heading, then (c) tries to append the second heading to the children of the “last entry of the stack”… which should be the currently active parent heading. Here, because the stack became empty on step (b), getting the last entry of the stack fails and be evaluated as undefined. Thus, an exception occur by accessing the property children of the undefined.

Fixed by #36.


CLI deploying malformed groups

It seems that groups created by the CLI are malformed as I am receiving this error in the UI when clicking "run all checks" in the group edit page for a CLI-created group.

This seems to be a general issue at the public api. I will take a look

@brampling can you recreate this when you hit checkly-cli deploy with the new version? I deleted stuff in my group settings.yml but can't recreate the error you are getting

@brampling can you share your zipped .checkly directory?


Fix event target issue in shadow dom

Related https://github.com/flatpickr/flatpickr/pull/1568/
This PR is currently in draft state. I will mark it for review later after signing my commits and fixing author email

Let me know if you want me to split these two commits in two separate PRs. Because one commit is addressing main index file while other one is doing changes in plugins (untested).

I'm running into the same issue. @chmln will this be published to npm in a new release soon?


Operator Interface and GeneticAlgorithmEmitter

Description

Added Operator Interface and GeneticAlgorithm Emitter

Internal Operator support for Gaussian and Isoline Operator
External Operator support for Pymoo Gaussian Mutation
GaussianEmitter Refactored for operator support
GeneticAlgorithmEmitter that emits solutions with provided operator

Questions

Status

[x] I have read the guidelines in
CONTRIBUTING.md
[x] I have formatted my code using yapf
[x] I have tested my code by running pytest
[x] I have linted my code with pylint
[x] I have added a one-line description of my change to the changelog in
HISTORY.md
[x] This PR is ready to go

Hi @svott03, thank you for working on this PR. I think it can be split into a couple of PRs as follows:

Add an OperatorBase class for operators
Add a GaussianOperator and IsoLineOperator
Add a GeneticAlgorithmEmitter
Add a PymooGaussianOperator (I'm actually not sure about this; it seems better to have a generic PymooOperator class that can take in any operator from pymoo, but I'd need a closer look at pymoo first) -- this will also be where we figure out dependencies and such

For now, I've left comments on _operator_base.py -- do you mind moving other changes to separate PRs or storing them on another branch while we figure out the OperatorBase? Thank you.

How should I go about moving changes to separate PRs. I know I can rebase or checkout a new branch and cherry pick commits to that branch. However, most of my code came from a single commit, is it possible that code out into multiple commits?

How should I go about moving changes to separate PRs. I know I can rebase or checkout a new branch and cherry pick commits to that branch. However, most of my code came from a single commit, is it possible to move that code out into multiple commits?


Support multi-file demos in demo gallery

Needed for #535 and if we do this, it would be good to have #579  solved, which will make it easy for people to copy these multi-file demos.

This seems to be the easiest way to do it (disclaimer: we currently do so as there doesn't seem another option):
# chat_multimodal.py
import mesop as me

from .base_chat_app import BaseChatApp
from .config import _BOT_USER_DEFAULT

class ChatMultimodal(BaseChatApp):
    def render_input_box(self):
        super().render_input_box()
        with me.box(
            style=me.Style(flex_grow=1, display="flex", flex_direction="column")
        ):
            me.uploader(
                label="Upload File",
                accepted_file_types=["image/jpeg", "image/png", "application/pdf"],
                on_upload=lambda e: self.on_click_upload(e, file=1),
                type="flat",
                color="primary",
                style=me.Style(font_weight="bold", margin=me.Margin(bottom=1)),
            )
            if self.state.file1:
                me.uploader(
                    label="Upload File",
                    accepted_file_types=["image/jpeg", "image/png", "application/pdf"],
                    on_upload=lambda e: self.on_click_upload(e, file=2),
                    type="flat",
                    color="primary",
                    style=me.Style(font_weight="bold", margin=me.Margin(bottom=1)),
                )
            if self.state.file2:
                me.uploader(
                    label="Upload File",
                    accepted_file_types=["image/jpeg", "image/png", "application/pdf"],
                    on_upload=lambda e: self.on_click_upload(e, file=3),
                    type="flat",
                    color="primary",
                    style=me.Style(font_weight="bold", margin=me.Margin(bottom=1)),
                )

def chat_multimodal(transform, *, state, title=None, bot_user=_BOT_USER_DEFAULT):
    app = ChatMultimodal(transform, state, title, bot_user)
    app.render()


Remove chat xss

Remove vulnerability of xss in chat like "".

I Can if you want

ok

you can close because i fix

fixed in https://github.com/michaljaz/web-minecraft/commit/bfb747d385889593eabfa5ab616dd84f75cea02b


Move 5.0 moniker to the top

Internal review URL

@scottaddie  thanks for the review. All I did was move the 5.0 content to the top. I wanted to do that before I worked on the doc so  I got a better diff next time.

@scottaddie  merging now as I need to start on the actual PR. My intention was asking for a review of moving the 5.0 version to the top.


To eject or not eject – That is the question

We're more and more getting problems due to the CRA (Create-React-App) setup.

Currently there is no (clean) way to include a CSS preprocessor like LESS. #65
Updating devdependencies like webpack, jest, react-styleguidist relies to CRA. This is can be sometimes blocking.
It feels like a blackbox.

Just as an example: Currently, we cannot update webpack to version 4 because react-scripts-ts depends on webpack 3 (#489). This also blocks update of styleguidist (#510).

I am not too deep into the CRA topic but the points listed above by @KaiVolland give me the feeling that it would be better to eject. Maybe the eject with a proper and complete documentation won't be that problematic?

Ejecting is simple and just leaves us some config files (webpack, babel, etc.) that can be shrinked afterwards by removing some uneeded configs. Shouldn't be a problem at all and IMHO meanwhile the benefits of the flexibility might outwheigh the comfort of CRA.

I'll giv it a try.

I ejected an ran into some problems when building.
I pushed the current state: https://github.com/KaiVolland/geostyler/tree/eject but as the priority is not THAT high... I'll skip this for know.

Currently, I am moving the demo application into a dedicated repo geostyler-demo to make a clear distinction between the library and the demo application. Through this, we can completely remove CRA from this repo and handle it the same way as we handle react-geo. Thus, we do not have to think about whether to eject or not.
The problems with CRA will then not affect geostyler anymore.

I think this process is finished. Reopen if im wrong.


benchs: repeat=1 for all remote benchmarks

While browsing the benchmark logs I noticed that the add to cache benchmarks ran multiple times, which is something that we don't do for other remotes (because they tend to take a lot of time). So I've added repeat=1 and timeout=12000 to the BaseRemoteBench. If needed the subclasses can override those limits but I think they are fine as defaults.

@isidentical I got review request but it seems that ImportBench did not change, is that intended?


Updated intro.css

Checklist:
This code maintains the same styling as your original code but is organized for better readability and maintainability

[ x] I have read and followed the contribution guidelines.
[ x] I have read and followed the how to open a pull request guide.
[ x] My pull request targets the main branch of freeCodeCamp.
[ x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Hey 👋🏽!
Welcome to contributing to freeCodeCamp.
Thanks for taking the time to create the PR and working on this. We’ve reviewed your pull request and decided not to merge it; However, We would welcome future pull requests from you.
You are welcome to read these guidelines to learn more about contributing to this project.
We recommend starting with issues that are labeled "help wanted"
Happy contributing.


Add libblkid as an explicit dependancy on Linux

Description
If this library is missing, builds fail with:
//lib64/libblkid.so.1: undefined reference to<EMAIL_ADDRESS>NOTE: Some distros have this library installed by default (such as Ubuntu), and some do not (such as Fedora), thus it was not picked up earlier in our testing.
Related Issues
Resolves: https://github.com/flutter/flutter/issues/61329
Tests
Updated _librariesPresentCommands() and _librariesMissingCommands() tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

Excuse me, I have updated Flutter today, but build still have same problem.
[✓] Flutter (Channel master, 1.21.0-8.0.pre.110, on Linux, locale en_US.UTF-8)


[QUESTION] Limit the App usage to only one site

Hello,
Is there a way to limit the usage of the customlearning app ?
We don't want our users to be able to add it to their sites.
Do you think It could work inside a Site Collection App Catalog ? (not the Tenant App Catalog)
Or Do-you see any other option?
Thank you

@flaghub if you are doing a new manual install then yes putting it in a site collection app catalog would be the best way to do this. The other way would be to deploy it in the tenant app catalog and not check the box that says deploy to all site collections. The difference is that in a Site Collection app catalog the web part will only be visible in the Site Collection it is installed in. With the second option users could manually go to Add an App and then add the web parts from there.
I'm sure there is a valid reason for this but one of the benefits of Learning Pathways is that you can provide in-context learning for users and create custom content on those pages. By limiting the use of the webpart you can only use it in the Learning Pathways admin site and so for instance you would not be able to show say content about your expense reporting process on the HR page.
I hope this helps.

@dcashpeterson Thanks for your help.
I'll try the Site-coll app catalog


Hang when try to build with one line (in container)

I am working on building my docker image and I stuck with cmake, I just follow your instructions and use the one line command
make -C docker release_build
I got stuck like below. My device is a NVIDIA A-800

the building process is depend on your specific hardware configuration.
The command python3 scripts/build_wheel.py --clean --trt_root /usr/local/tensorrt tooks about 20+ minutes (Intel(R) Xeon(R) Silver 4314 CPU @ 2.40GHz + NVIDIA H100 80GB HBM3 + nvme ssd)

Close this bug because the issue is resolved. Feel free to ask here if you still have question/issue, we will reopen the issue.


Add tooltip for service account download kubeconfig button

Description
Changes proposed in this pull request:

Add tooltip for service account download kubeconfig button

Related issue(s)

/retest


Plumb the "TEKTON_RESOURCE_NAME" env var into the cluster and PR reso…

…urces.
Changes
As part of TEP-0025 (hermetic builds), we need to know which containers/steps are part
of the "Tekton system" and which ones are part of the Task definition. This PR adds
the TEKTON_RESOURCE_NAME environment variable to the injected copy containers.
This variable is already used by several of the existing resources (git, image).
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ X] Includes tests (if functionality changed/added)
[X] Includes docs (if user facing)
[X] Commit messages follow commit message best practices
[X] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
The TEKTON_RESOURCE_NAME environment variable is now set on the injected PR and cluster resource containers.

/approve
/lgtm


Clean up .vscode/launch.json

System Info
nothing
Details
The configuration in .vscode/launch.json is not universal, thus we need to add it to the .gitignore file.
And I suggest we add a .vscode/launch.example.json file to aid developers in debugging this project.
Reproduce link
No response
Reproduce Steps
nothing

why do we need to add it to .gitignore ? it seems works for every vscode users now?

It's not a universal configuration; it's possible that you want to debug file A, but someone else wants to debug file B, which can be very confusing if it's all logged by git.

oh I get your point, vscode lacks the ability to interactive prompt argument for users like clion

but I am thinking .vscode/launch.example.json maybe not better, since you need to rename file and change debug target too, an out of box debugging would be better

a related issue https://github.com/microsoft/vscode/issues/93823


Muhammad-Diyor/Implemented-FavoriteRepository

Fixed @devdoston 's mistake. Interface had missing members and was giving some error messages. Implemented missing members without logics.

@javlonfattoev Ustoz, bu bizni bo'limga kirmaydi, shunchaki qizil chiqib, kod run bo'lishiga qo'ymayapti, shunga implement qib qo'ygandim.


annovarToMaf Warning

when I translate my file to maf format by
var.annovar.maf = annovarToMaf(annovar = "all_sample.txt",
Center = 'NA',
refBuild = 'hg38',
tsbCol = 'Tumor_Sample_Barcode',
table = 'refGene',
sep = "\t",
sampleAnno = NULL)
I get this Warning message:
In data.table::data.table(Hugo_Symbol = ann$Gene.refGene, Entrez_Gene_Id = NA,  :
Item 18 is of size 4890 but maximum size is 4893 (recycled leaving remainder of 3 items)
What does that mean？My file has 4948 lines, but this function can only read 4893 lines？

I had this same issue and solved it by making the following change to the function annovarToMaf().
Change this:
 tx = unlist(sapply(xaa, function(l) {         l[length(l) - 3]     }))
To this:
tx = unlist(sapply(xaa, function(l) {     if (length(l) > 1) {       l[length(l) - 3]     }       else {         NA       }   }))


Implement support for configservice recorders and rules

Description
Fixes #000.

Demo

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.
[x] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added support for inspecting and nuking configservice recorders and rules
Migration Guide

Thanks for review!


WIP - Improve multicluster update handling

When a remote cluster is updated stop the informers but don't cleanup.  During the subsequent add of the new kube clients perform audits after the sync where needed to clean things up.
Please provide a description of this PR:
Resolves the final check box of: https://github.com/istio/enhancements/pull/107

@john-a-joyce: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

gencheck_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

gencheck_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test gencheck

unit-tests-arm64_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

gencheck_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test gencheck

unit-tests-arm64_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests-arm64

unit-tests_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @stevenctl - I was hoping you guys could take a quick look at the approach I used here and confirm you are Okay with the general flow.   The approach I used is to set a flag on the controller when an update is in play.   If that flag is set then I will do an audit during the SyncAll steps.  The Audit will compare the new info coming from the informer caches vs. the info in the discovery server Env.   In my testing only the services actually needed an audit.  Endpoints would all self correct.   I do have a small doubt about all the other resource types.  AFAICT many aren't track for multicluster, but some might have jeopardy if user makes other config changes while the update is in progress.
If your good with the general approach I can clean out most of the TODOs and fix the test failures for a proper review/merge.

When a remote cluster is updated stop the informers but don't cleanup.

Trying to understand, seems you are not gonna to clean up the cache of the cluster, and when new client established, and new informer could trigger events for any resources istio cares about. Then what does it improve?

@hzxuzhonghu - this PR is to address the concern raised in https://github.com/istio/enhancements/pull/107 - that an update of the multicluster secret (e.g. cert rotation event) could (or maybe would) cause a full push for all the remote cluster endpoints and additionally could trigger a blip in envoy's ability to route to those endpoints.   To address your specific question we need to be clear on which caches we are talking about.  Since we avoid calling Cleanup during the update we avoid pushes that would clear out the XDS cache.  When HasSync occurs after the update the cache built from the informers may not match whats is the XDS cache so we have to audit some things.   There are too many permutations and code paths for me to be convinced that this will avoid the full push requested in https://github.com/istio/enhancements/pull/107 - but it will avoid any blips in envoy's ability to route to remote endpoints.   If you don't think the code matches what I describe here then happy to take suggestions.  Maybe when John rewrite's istiod with his recently controller work this change won't be needed :-)

The concern is primarily endpoints more than services

I fully agree and I started writing an audit method for the endpoints,  but while testing this I saw that the current endpoint logic in  edsCacheUpdate after a sync would essentially take all the new endpoints from the sync event and rewrite here: https://github.com/istio/istio/blob/cff05d9ed3d3778e7c5e2452cb1c588804ad5185/pilot/pkg/xds/eds.go#L174
So an audit for endpoints was not needed,     Services on the other hand required an audit,  because if one was deleted on the remote cluster during the update period,  they would never cleanup.

Not easy to handle this, during the update interval any resource can change

I agree this is a bit of a slippery slope and IMO we probably want to add some operational related documentation along with this change.  The documentation should warn that updates should only be done for essential changes like cert rotation and the clusters should be kept as quiescent as possible during the update period.
Some of the TODO questions in the diff are exactly asking which resources (and how deep) do we want the audit to go.
It is fine with me if the consensus is that we don't try to audit any resources during an update,  but we have to add some documentation warning an update can cause a traffic disruption.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

gencheck_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test gencheck

unit-tests-arm64_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests-arm64

unit-tests_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests

integ-ambient_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

all the new endpoints from the sync event and rewrite here

What's the call path to edsCacheUpdate from SyncAll? AFAIK it's additive. Because there are no delete events, this would leave stale endpoints that were removed when the control plane started watching after the secret update.
We want to fill up a shard and swap it.

What's the call path to edsCacheUpdate from SyncAll? AFAIK it's additive

@stevenctl -  This is the call path I observed in my testing:  SyncAll->syncEndpoints->onEvent->processEndpointEvent->updateEDS->c.opts.XDSUpdater.EDSUpdate->edsCacheUpdate
"Additive" is not really the way to describe this because we are dealing with multiple caches.   In my testing I observed that the when you add a new set of informers you will create a new LRU cache for the informers and its true that part is strictly additive - AFAICT.  Its the XDS cache we really care about and the code in edsCacheUpdate does a full replace AFAICT.   I did some testing to simulate this with a full cluster replace as part of the update and the XDS was correct with this change regardless of whether endpoints were added, deleted or changed.  Adding an audit somewhere in the above path is always an option but it wasn't necessary in my testing.
How to we can we close this?   I think we first need consensus that we do want to preserve the endpoints during an update.   I am not hearing full consensus that the benefit is worth the additional complexity.  If everyone agrees on that we can make sure the code covers all the key cases.

@john-a-joyce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test release-notes

lint_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test lint

gencheck_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test gencheck

unit-tests-arm64_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests-arm64

unit-tests_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test unit-tests

integ-ambient_istio
21c07469fbdb01099c66df077c9f34dca51dcd06
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

AFAICT there is a chance that between creating the new client you miss some delete. Audit is one way to deal with that, but another is
xds generation reads from the OLD set of endpoints, the new set fills in the background
once we hit the "full sync", we swap our new index in

A graceful remote secret update will likely have no issue. Consider one that's performed after the user notices the there was an issue and it has been broken for some time.
Probably safer to restart istiod at that point anyway.. but just an example.


Build ckanext-scheming compatible file uploader

use-ckan-client-js-directly

Feature branch which interacts with ckan-client-js directly to carry out file uploads via a ckanext-scheming compatible react component rather than datapub.
Related PR https://github.com/fjelltopp/adx_develop/pull/49
See video of UI in action

To Do

[x] ckanext-scheming compatible file upload UI
[x] Updated all existing js/css from fanstatic over to webassets
[x] Discuss on how we do webassets (see below comment)
[x] Single hitbox for drag+drop component rather than two boxes
[x] At the moment once you click "link resource" the UI removed the file uploader and theres no back button if you change your mind and vice versa
[x] i18n translations integration
[x] i18n translations language mappings
[ ] Make the component compatible with displaying the view-resource view
[ ] Get someone to confirm our french translation strings - @jonathansberry?
[ ] Manual testing by someone who's more experienced in ckan to make sure I haven't missed anything
[ ] Automated tests!!

Attempting to use webassets
Setup
Updated upload.html script tag with:
{% asset 'external_storage/FileInputComponentScripts' %}

Set the node watch script to:
yarn parcel watch ./components/* --out-dir ../webassets/ --public-url ./```

Add to webassets.yml:
FileInputComponentScripts:
    contents:
        - FileInputComponent.js
    output: external_storage/FileInputComponent.js

FileInputComponentSourceMap:
    contents:
        - FileInputComponent.js.map
    output: external_storage/FileInputComponent.js.map

Problem
As the main js file is imported via
/webassets/webassets-external/5d74e61bf18da188dbf0138e6134a1d4_FileInputComponent.js

It expects the js.map file to be located at:
http://adr/webassets/webassets-external/FileInputComponent.js.map

Which does not include the hash
Solution

For now i've put the JS back into /public/external_storage

❗ Bug: After uploading a file resource, if you try editing it to a link it still thinks there's a file

UI Tests
This is very very early stage, so i've made a gist for now:
https://gist.github.com/Manoj-nathwani/8c826a2a4dbe16af9566d272b1cbb413
cc @tomeksabala

That's a great start. I recommend next steps as implementing the PO model from the selenium docs you've shared https://selenium-python.readthedocs.io/page-objects.html and also using pytest. With pytest fixtures you should be able to centralize webdriver init, setup & teardown and test data creation & removal.


Kube Terminal: Appears to hang if it takes a while to start up

Typically occurs on first load when the container image has to be fetched and thus it takes a while.
The back-end times out reading from the front-end - which obviously hasn't send any key strokes - but the terminal looks okay, but typing does not send anything to the terminal.
Fixes #505

Codecov Report

Merging #506 into master will not change coverage.
The diff coverage is 14.00%.

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   57.83%   57.83%
=======================================
  Files        1063     1063
  Lines       34428    34428
  Branches     4890     4890
=======================================
  Hits        19910    19910
  Misses      14518    14518


Bug fixes

Replaced base of I/O operations with rasterio
Fixed bugs in the masking functionality
Upgraded suggested Python version to 3.11

I changed the version number in the CHANGELOG. Ready to merge?


Fix tests to be deterministic

Right now because some of the tests use aer they are both slow and fail since they are non-deterministic. Can we copy the model of rb and pkl some results to test the fitter? We should still run the circuits through the idea simulator to make sure it doesn't fail.

Informations

Qiskit Ignis version:
Python version:
Operating system:

What is the current behavior?
Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

BTW, why even for a fixed seed we get a non-deterministic behavior of Aer noise module? It seems that there is a difference in how the noise is generated in Aer, that could be system dependent (e.g. Mac vs. Linux).

Yes, according to chris it can be a little different on mac vs linux

Shouldn't this be an issue in Aer?

Depends what was claimed I guess in the Aer documentation


Change Pager reference to Jekyll::Paginate::Pager

As of Jekyll 2.1.0, Pager was moved to jekyll-paginate; therefore references for Pager must be changed to Jekyll::Paginate::Pager

Thanks!


How to compile

Not everybody knows how to compile GO applications so please add instructions to the readme. I managed to get it to work with go get -v -d && make deck

good point. i will add an installation section to the readme

Awesome!


Release Google.Cloud.Container.V1 version 3.19.0

Changes in this release:
New features

Added EnterpriseConfig (commit 1b8f34d)
Add a new cluster field for the cluster tier of GKE clusters (commit 1b8f34d)
Add ResourceManagerTags API to attach tags on the underlying Compute Engine VMs of GKE Nodes which can be used to selectively enforce Cloud Firewall network firewall policies (commit bae6344)
Add CompleteConvertToAutopilot API to commit Autopilot conversion operation (commit bae6344)

Documentation improvements

Updated comments (commit bae6344)

Created release for Google.Cloud.Container.V1-3.19.0


cypress workflow

Breaking the cypress ci flow into its own file specifically to cover the production env.
The workflow as-is is set to run when:

you create a PR/push changes
scheduled to run on master/prod at 2AM, Mon-Fri

Note: The e2e tests run in CI do NOT currently test against PR changes. We will need to add a PR comment command that accepts our staging server urls as a param.
Testing notes:

[x] Cypress defaults to development env locally, tests pass
[x] Cypress tests run and pass against prod in CI flow

@dancingshell yeah I'm looking for a way to trigger a cypress e2e run against a newly spun up staging environment with like a pr comment or something.


feat: added support to pom.xml

Description:
The idea of this PR is to extend the java-version-file to support pom.xml, because for now it only supports the java-version-file created by jEnv
Related issue:
Add link to the related issue.
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

This PR is still pending:
[ ] - Add unit e2e test to cover the other scenarios
[ ] - Add documentation

hi @augustomelo thank you for the PR, we will take a look at it

Hello @panticmilos could you approve the workflow run ? I tested it locally with act and it was fine, just wanted to sure that I didn't break anything

Hey, regarding the failing workflows, I believe there is something strange with them, because for example the code scanning:

GitHub Code Scanning / CodeQL complains in a file that is generated dist/cleanup/index.js

97022: if (util_1.isObject(p1) || (util_1.isString(p1) && (/^\s*</.test(p1) || /^\s*[\{\[]/.test(p1) || /^(\s*|(#.*)|(%.*))*---/.test(p1)))) {
97795: else if (p1 !== null && /^(\s*|(#.*)|(%.*))*---/.test(p1))

I believe this is coming from the  xmlbuilder2 when I create the object from the string (here), should I change the library ? Because I don't think I have any control over it.
The other workflows that failed are:

Basic validation / build (ubuntu-latest)
Basic validation / build (windows-latest)
Basic validation / build (macos-latest)
Licensed / Check licenses
Check dist/ / check-dist

Which are failing during the install dependencies step, it could be because the dependency that I added: xpath which has the same license as the one xmlbuilder2  (MIT).
Not sure how to proceed now, @panticmilos do you have any ideas here ?

Hey @panticmilos  thanks for the reply! Sure thing I will have a look on it once I have the time 😄

Hey @augustomelo, first of all thanks for the PR, if this didn't exist I would have created my own ;)
But I wonder why you chose to parse the version via regex as that approach obviously limited. This project already has xmlbuilder2 as a dependency which can also be used for parsing XML. For example we could do this:
const doc = create(pomContentAsAString);
const mvnVersionNode = doc.find(n => n.node.nodeName === "maven.compiler.source", false, true);
const sourceVersion = mvnVersionNode.first().toString();

This way we can have a more robust implementation and support using the version specified in maven-compiler-plugin.
Are you still willing to work on this @augustomelo? Otherwise I can create a new PR.
@panticmilos has this feature request been discussed? Are you willing to merge something like this?

hey @tim-we, thanks for the review and I much appreciate the suggestion the solution is much better now!
I am not sure why, but when I read the xmlbuilder2 I understood that it was not possible to create the xml object from a string, therefore I used the xpath and then moved to using regex.

Hey @augustomelo, I made a PR to your fork  to add support for versioning via maven-compiler-plugin. Please have a look. There are also some minor things we should address before this gets merged, such as variable names not being accurate anymore after the refactor. If this progresses any further I'd might do another code review.

hey @tim-we  I didn't forgot about this, when I had the time I will apply the changes. I was thinking about also add support to gradle, but I currently don't know how to achieve that besides using RegEx, do you have any ideas ?

hey @tim-we  refactored the code to align with your comments, feel free to resolve the conversation.
Added the support to builld. gradle using regex.
I didn't do the merge, because I am not sure if this PR is going to be merged

hey @tim-we  I had to do some changes on the code since the testes were failing in correctly identifying the java version, now they seem fine, the failure is now not being able to find the version to download
@panticmilos and @IvanZosimov  any new if this is going to be merged? if not I will not bother rebasing it for now


(SC-CEN-6) - There is not a field to set de description

There is not a field to enter/edit an entity description. Also, the name of the entity cannot be changed.

issue #168


RBAC with SQL server 2017 not work

What steps will reproduce the problem?

this problem only in RBAC with DbManager, but in other CRUD its always working fine.
when i create role, assignment, assign route and etc im always get error.

What is the expected result?
please tell me step by step how to solve it.
What do you get instead?
Implicit conversion from data type char to varbinary(max) is not allowed. Use the CONVERT function to run this query.
Additional info

Q
A

Yii version
2.0.13

PHP version
7.1

Operating system
SQL server 2017

could you please post the stack trace of the error? There is a nice little button for that on the page you screenshotted :)

like this
`PDOException: SQLSTATE[42000]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Implicit conversion from data type char to varbinary(max) is not allowed. Use the CONVERT function to run this query. in D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\db\Command.php:994
Stack trace:
#0 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\db\Command.php(994): PDOStatement->execute()
#1 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\rbac\DbManager.php(283): yii\db\Command->execute()
#2 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\rbac\BaseManager.php(130): yii\rbac\DbManager->addItem(Object(yii\rbac\Permission))
#3 D:\XAMPP\htdocs\basic\vendor\mdmsoft\yii2-admin\models\AuthItem.php(173): yii\rbac\BaseManager->add(Object(yii\rbac\Permission))
#4 D:\XAMPP\htdocs\basic\vendor\mdmsoft\yii2-admin\components\ItemController.php(79): mdm\admin\models\AuthItem->save()
#5 [internal function]: mdm\admin\components\ItemController->actionCreate()
#6 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\InlineAction.php(57): call_user_func_array(Array, Array)
#7 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#8 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Module.php(528): yii\base\Controller->runAction('create', Array)
#9 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\web\Application.php(103): yii\base\Module->runAction('auth/permission...', Array)
#10 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Application.php(386): yii\web\Application->handleRequest(Object(yii\web\Request))
#11 D:\XAMPP\htdocs\basic\web\index.php(12): yii\base\Application->run()
#12 {main}
Next yii\db\Exception: SQLSTATE[42000]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Implicit conversion from data type char to varbinary(max) is not allowed. Use the CONVERT function to run this query.
The SQL being executed was: INSERT INTO [auth_item] ([name], [type], [description], [rule_name], [data], [created_at], [updated_at]) VALUES ('book', 2, NULL, NULL, NULL,<PHONE_NUMBER>,<PHONE_NUMBER>) in D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\db\Schema.php:594
Stack trace:
#0 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\db\Command.php(1004): yii\db\Schema->convertException(Object(PDOException), 'INSERT INTO [au...')
#1 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\rbac\DbManager.php(283): yii\db\Command->execute()
#2 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\rbac\BaseManager.php(130): yii\rbac\DbManager->addItem(Object(yii\rbac\Permission))
#3 D:\XAMPP\htdocs\basic\vendor\mdmsoft\yii2-admin\models\AuthItem.php(173): yii\rbac\BaseManager->add(Object(yii\rbac\Permission))
#4 D:\XAMPP\htdocs\basic\vendor\mdmsoft\yii2-admin\components\ItemController.php(79): mdm\admin\models\AuthItem->save()
#5 [internal function]: mdm\admin\components\ItemController->actionCreate()
#6 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\InlineAction.php(57): call_user_func_array(Array, Array)
#7 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#8 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Module.php(528): yii\base\Controller->runAction('create', Array)
#9 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\web\Application.php(103): yii\base\Module->runAction('auth/permission...', Array)
#10 D:\XAMPP\htdocs\basic\vendor\yiisoft\yii2\base\Application.php(386): yii\web\Application->handleRequest(Object(yii\web\Request))
#11 D:\XAMPP\htdocs\basic\web\index.php(12): yii\base\Application->run()
#12 {main}
Additional Information:
Array
(
[0] => 42000
[1] => 257
[2] => [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Implicit conversion from data type char to varbinary(max) is not allowed. Use the CONVERT function to run this query.
)
`

Working on

Thank you for the report.
As I see, it was not broken by 2.0.13, it just never worked as expected and was not tested.
This issue will be fixed, but not as a patch to 2.0.13

will this problem be fixed in the next version (2.0.14) ?
maybe for now I have to use PhpManager. Because the phpmanager rbac works well.

I plan to fix it in 2.0.14.

thank you so much @SilverFire @cebe @sergeymakinen, I'll wait for the release of 2.0.14 :)

we're still in 2.0.12 and converted all columns from VARBINARY to VARCHAR (on DbSession also) to be able to work around this issue on SQL 2017
... looking forward for the fix..

I confirm that with all the versions of SQL server since 2008 the solution is to change varbinary to varchar.
As you are at it, it needs to be specified the NULL option as accepted.
SQL Server default database options set NOT NULL if nothing is specified, this can be changed on the database defaults, but many of us (at least I) use SQL Server as it needs to integrate with other existing applications and changing this could lead to unexpected results.


add ability to have multiple different inmemory journals in one actor system

Thanks for your contribution. Although this PR won't be used and closed, I do appreciate the effort and contribution. In order for the persistence plugin to be more general, PR #59 will be used, which makes it possible for you to implement your own persistence strategy.


Add check updates workflow

Add check updates workflow for grafana-dashboard
Imported existing grafana-dashboard from sunbeam project
Add Makefile targets and scripts

Depends on #16.

@samuelallan72 we are closing as completed because the functionality requirement is mostly (if not all) achieved, but feel free to open follow-up PRs to address issue you found


Tx Error

Hello,
first of all let me say thanks for your work and this bot. It's quite interesting!
But I cannot get it properly to run. Sometimes I am getting a transaction error when the bot tries to make a bet. (Betting on Bear Bet. Bear Betting Tx Started. Bear Betting Tx Error). And sometimes the bot is stuck at "waiting for next round".
I have the private key in the .env file and enough funds in my wallet. Any idea what could cause this error?

okey nevermind, now it runs. didnt do anything. weird...

Hi mate,
Yes this can often happen especially for the first round after running the script. The reason is because the timer initially tries to place the bet as close as possible to the start of each round. If it fails to complete the transaction before the round has started, it will reduce the waiting time for the next round to have a higher chance of successfully placing the bet before the round begins.
Thanks for your interest in the bot! Enjoy mate.

Hi,
I started the bot and got 4 failed transactions. Is there a way to manually adjust waiting time?
Thank you.

Is there a way to increase gwei? Too much failed transactions due to speed.


Incompatibility with expo notifications and get native token is hanging.

Our application has the need to run both expo-notifications and Customerio rich push notifications.
We have been running into an issue over the last few days where when either requesting the device token with getDevicePushTokenAsync or customerio sending an add device token will hang. The promise neither rejects nor resolves.
After some investigation it seems that add this function to app delegate seems to be causing the issue.
//// Explicitly define remote notification delegates to ensure compatibility with some third-party libraries
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{

  return [pnHandlerObj application:application deviceToken:deviceToken];

}

Do you have any suggestions?

+1 also experiencing this - we use expo-notifications to allow us to request push notification permissions as well as retrieve the device token we send to Customer.IO. We also use expo-notifications for non-marketing push notifications.

+1 - it'll be blocking us from using customer.io until there's a fix

Hello everyone
I apologize for the issue you are facing.
Can you all share what workflow you are using? Managed or Bare?

+1 - it'll be blocking us from using customer.io until there's a fix

Managed here

Hello everyone
I apologize for the issue you are facing.
Can you all share what workflow you are using? Managed or Bare?

Managed here

Also managed.

Managed here too

Managed workflow

Thanks for looking into this. Are you able to give an update? We need to decide if we wait for a fix or look for alternative solutions.

Btw I am also on managed workflow.
The issue is that CIO is rewriting the app delegate methods, but does not call super which is required so all other modules keep working OK.
This what the resulting code looks without CIO:
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
  return [super application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}

This is what it looks like with CIO:
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{

  return [pnHandlerObj application:application deviceToken:deviceToken];

}

There is the super call missing. I believe that would fix everything.

One option we're considering is to not utilise Customer.IO's SDKs at all and instead integrate with their API from the app to register device tokens.
Initial testing suggests that we can see all the same functionality (via utilising expo-notifications) except the use of images in iOS push notifications.
I'm hoping that this fix will release before we pull the plug on that approach - but figured it'd be good to share this information for anyone else on this thread who is also somewhat time-pressured on getting a working solution here.

@xtreem88 any update on the progress? :)

The issue has been resolved and the fix is available in the latest release 1.0.0-beta.8. Please let us know if you encounter any further issues.

I just would like to note, that only thing you have actually fixed is the push notification registration, but the other delegate methods remain unchanged. For example if user receives or taps on push notification which is not CustomerIO notification, theres no way for handle those scenarios right now.

The fix seems to working locally, but without adding the capability manually in xcode it will return this error.
Error: Notification registration failed: "Push Notifications" capability hasn't been added to the app in current environment: no valid “aps-environment” entitlement string found for application

Even though expo-notifications add the entitlements file it does seem to register the capability.
In a managed workflow this will still be unusable at this stage.

@zdnk
Thank you for pointing this out. The current release only addresses the issue with receiving the device token, as per the requirements of the ticket. The other delegate methods have not been updated yet. We apologize for any confusion that may have caused. . Please note that the other delegate methods have not been updated yet, and the specific scenario you mentioned has not been tested yet. If you are experiencing any other issues, we suggest opening a new ticket to avoid any confusion. Our team will be happy to investigate further.

@deantes
You'll need to manually add Push Notifications as a capability in Xcode, as mentioned in our documentation. Here's the link to our documentation for reference.
We are working on adding the capability to our plugin to automatically enable push notifications, so that you won't have to perform any manual steps. While we do not have a specific timeline to share at this moment, we will keep you updated on any progress or developments.

I've raised a ticket for the above @deantes. I believe it has wider implications on potentially interacting negatively with other plugins so I'd be wary of utilising it even with manual change suggested above.
https://github.com/customerio/customerio-expo-plugin/issues/72


Use dagger/graphql and codegen arguments in the same order as API

core: switch from graphql-go/graphql and bhoriuchi/graphql-go-tools to our own forks (dagger/graphql dagger/graphql-go-tools), which include

https://github.com/dagger/graphql/pull/1
https://github.com/dagger/graphql-go-tools/pull/1
https://github.com/dagger/graphql-go-tools/pull/2

router: switch to our own handler implementation

Moved a simplified version of graphql-go/handler into router/internal/handler
Removed all playground / graphiql related code (since we're using our own playground anyway)
Misc fixes and linting

router: move playground to router/internal/playground
sdk: go: keep argument ordering from api

Removed forced sorting now that the API returns the correct order from introspection

-func (r *Container) WithMountedCache(cache *CacheVolume, path string, opts ...ContainerWithMountedCacheOpts) *Container {
+func (r *Container) WithMountedCache(path string, cache *CacheVolume, opts ...ContainerWithMountedCacheOpts) *Container {
-func (r *Directory) WithDirectory(directory *Directory, path string, opts ...DirectoryWithDirectoryOpts) *Directory {
+func (r *Directory) WithDirectory(path string, directory *Directory, opts ...DirectoryWithDirectoryOpts) *Directory {


support adhoc scanning with multiple secrets per line

From https://github.com/Yelp/detect-secrets/pull/52, we're able to do:
$ detect-secrets scan --string '012345678a'

but what happens if the string two or more secrets? e.g.
$ detect-secrets scan --string '"0123456789a" and "0123456789b"'

Right now, we're only going to show the scanned results for the first secret. But you can imagine it's kinda weird UX to only show results for the first one (silently ignoring the second).

For posterity, this may be a nice feature, but it's a pretty involved change.
Essentially, what it boils down to is "how do you tell if two secrets are equal?" Currently, we compare three fields, and they were chosen in such a way that the following cases who be flagged as two distinct secrets:

Same secret, different file
Same secret, different plugin that flagged it
Different secrets

This also means that if a secret is moved around through normal development, it's not going to re-alert, and the pre-commit hook won't flag it as a new secret. This also helps with performance when identifying new secrets -- if every secret is treated different, you would go from O(1) unique hash lookup to O(n) to look through your secret collection.
Ultimately, in our use case, we currently don't see developer behavior that recycles the use of a static secret string in different parts of the file (thank goodness). Contributions are welcome, if this case fits your needs more.


Multiple "Chart not available" messages

I get this for all OS charts; #2,#3,#4 of the PROCESS charts and the FILESYSTEM charts. Could it be because the host is FreeBSD?
Thanks.

It can be because Sigar library has not been loaded. IIRC this can happen if you run ES in embedded mode. Is this your case?
If this is not the case, do you think you can share which ES version you are using?

ES version is 1.4.2, Bigdesk 2.5.0

I am archiving this repository now. Thanks for contributions.


HAL Support ?

Will there be support for HAL Drivers ?

So far I didnt seeva need for it. Demo based on LL for stm32 is not enough?

I was just asking if you have it somehow prepared or something. I will make a PR later for you, if you want to have it as a part of Your library. Thanks :+1:

Don't close it so quickly :)
Having HAL makes sense only if we can implement DMA receive especially with high traffic. Latest versions of HAL (H7, G4, L5 + some others) support DMA receive with unknown length on RX side. IF you can implement such thing with HAL and make a pull request to develop branch, I will merge it.

I am sorry about that - closing this "Issue" too soon. I will let you know. Thank you.

That is my current job.  add HAL DMA support.  with stm32xxxxx


Added option to manually set messages encoding for pytest plugin

I had a problem on teamcity agent - automatically detected encoding is cp1252 which is wrong and I got encoding error. So I added option to allow manually setting encoding.

Could you provide steps to reproduce the problem?
I've actually run your example with one modification:
# coding=utf-8
import pytest

def test_cp():
    assert 'Ф'.encode('utf8') != b'\xd0\xa4'

python 3.3 (3.5 also ok) on Windows 10 (russian oem encoding):
sys.stdout.encoding: cp866
============================= test session starts =============================
platform win32 -- Python 3.3.5, pytest-2.9.1, py-1.4.31, pluggy-0.3.1
rootdir: C:\work\teamcity-messages, inifile:
plugins: teamcity-messages-1.17
collected 1 items

encoding_test.py ##teamcity[testStarted timestamp='2016-05-21T15:16:58.413' captureStandardOutput='false' flowId='tests.guinea-pigs.pytest.encoding_test.test_c
p' name='tests.guinea-pigs.pytest.encoding_test.test_cp']
F##teamcity[testFailed timestamp='2016-05-21T15:16:58.425' details='def test_cp():|n>       assert |'Ф|'.encode(|'utf8|') != b|'\xd0\xa4|'|nE       assert b|'\
xd0\xa4|' != b|'\xd0\xa4|'|nE        +  where b|'\xd0\xa4|' = <built-in method encode of str object at 0x00000000032F3C90>(|'utf8|')|nE        +    where <buil
t-in method encode of str object at 0x00000000032F3C90> = |'Ф|'.encode|n|nencoding_test.py:5: AssertionError' flowId='tests.guinea-pigs.pytest.encoding_test.te
st_cp' message='tests\guinea-pigs\pytest\encoding_test.py:3 (test_cp)' name='tests.guinea-pigs.pytest.encoding_test.test_cp']
##teamcity[testFinished timestamp='2016-05-21T15:16:58.427' duration='0' flowId='tests.guinea-pigs.pytest.encoding_test.test_cp' name='tests.guinea-pigs.pytest
.encoding_test.test_cp']

================================== FAILURES ===================================
___________________________________ test_cp ___________________________________

    def test_cp():
>       assert 'Ф'.encode('utf8') != b'\xd0\xa4'
E       assert b'\xd0\xa4' != b'\xd0\xa4'
E        +  where b'\xd0\xa4' = <built-in method encode of str object at 0x00000000032F3C90>('utf8')
E        +    where <built-in method encode of str object at 0x00000000032F3C90> = 'Ф'.encode

encoding_test.py:5: AssertionError
========================== 1 failed in 0.03 seconds ===========================

Unfortunately I can't. The problem with wrong encoding was only on teamcity agent, not my local machine. If I had known what make windows to use cp1252 by default, I would have changed windows setting to solve it.
Tests from ccf6bba commit just to check if new option was applied. I added because thought it would be bad pull request with new option not covered by tests. I am sorry if it broken CI, on my local machine new tests passed.
In both new tests internal pytest test should not passed, so your example if it was for [https://github.com/JetBrains/teamcity-messages/pull/100/commits/ccf6bba7292f3b597875e34c8e8cae2f9222a194#diff-87d3cd8521c2572c31dc48328dfe9448R69]? not for test without manually set encoding failed as expected.
Maybe such kind of integration test with failed internal test is not good. But I still have no idea how one can better test this option.

As far as I know it's about OEM encoding (aka codepage for non unicode programs), try https://superuser.com/questions/497857/how-to-change-language-for-non-unicode-programs-in-windows-8
I'll think about the integration test


fix: test

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Resource rancher2_auth_config_activedirectory is named differently in this provider as just ActiveDirectory compared to the rest

I am trying to setup Rancher using this provider and I have made it to the authentication config. I noticed the rancher2_auth_config_activedirectory resource is just named ActiveDirectory in the generated SDKs instead of the normal AuthConfigActiveDirectory like the others are.
https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/auth_config_activedirectory

Hey @mitchellmaler
I'll get an alias in place and a deprecation on the old resource and a new version of the provider shipped tomorrow
Sorry about that
P.

Awesome, thanks for the quick reply.

Closed via #122


Dev EC2 crashes because it's running out of memory

I have bumped 3-4 times on a memory issue since I added elasticsearch to the stack.
hs_err_pid16017.log:
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 660602880 bytes for committing reserved memory.
# Possible reasons:
#   The system is out of physical RAM or swap space
#   The process is running with CompressedOops enabled, and the Java Heap may be blocking the growth of the native heap
# Possible solutions:
#   Reduce memory load on the system
#   Increase physical memory or swap space
#   Check if swap backing store is full
#   Decrease Java heap size (-Xmx/-Xms)
#   Decrease number of Java threads
#   Decrease Java thread stack sizes (-Xss)
#   Set larger code cache with -XX:ReservedCodeCacheSize=
#   JVM is running with Zero Based Compressed Oops mode in which the Java heap is
#     placed in the first 32GB address space. The Java Heap base address is the
#     maximum limit for the native heap growth. Please use -XX:HeapBaseMinAddress
#     to set the Java Heap base and to place the Java Heap above 32GB virtual address.
# This output file may be truncated or incomplete.
#
#  Out of Memory Error (os_linux.cpp:2787), pid=16017, tid=16025
#
# JRE version: OpenJDK Runtime Environment Temurin-17.0.5+8 (17.0.5+8) (build 17.0.5+8)
# Java VM: OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (17.0.5+8, mixed mode, emulated-client, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Core dump will be written. Default location: /workspaces/sage-monorepo/core.16017
#

The EC2 instance we use is t3a.xlarge, which has 16 GB of RAM. We would need 32 GB to develop comfortably.
First we should provide how much memory different components of the stack take. Then try to limit the memory used by these service to ensure that the EC2 instance does not crash.

While working on the challenge service:
$ docker stats

CONTAINER ID   NAME                                  CPU %     MEM USAGE / LIMIT     MEM %     NET I/O           BLOCK I/O         PIDS
8d8bbf94649f   challenge-registry-elasticsearch      0.35%     8.434GiB / 15.52GiB   54.33%    42B / 0B          169MB / 1.3MB     63
7ff4e47cc0f7   challenge-registry-api-gateway        0.12%     405MiB / 15.52GiB     2.55%     13.5kB / 15.9kB   61MB / 369kB      34
08f35af2304e   challenge-registry-service-registry   1.08%     315.5MiB / 15.52GiB   1.98%     15.9kB / 13.5kB   64.5MB / 369kB    71
4bff9bdeb83a   challenge-registry-rabbitmq           0.20%     141.1MiB / 15.52GiB   0.89%     42B / 0B          53.1MB / 288kB    30
e8fdafc48d1d   challenge-registry-mariadb            0.02%     121.1MiB / 15.52GiB   0.76%     42B / 0B          86.3MB / 9.22kB   7
41d56bb94b19   challenge-registry-keycloak           0.30%     379.6MiB / 15.52GiB   2.39%     42B / 0B          111MB / 12.3kB    43


Option to open dev tools detached

If your app isn't a fullscreen app like the atom editor, but is perhaps a tray app or has a narrow tall window then the attached dev tools are unusably narrow.
It would be great to have an option for the openDevTools method to be able to start it detached from the current window. eg something like:
browserWindow.openDevTools({detached: true})

This would be convenient, but note that once you detached the devtools manually, the next call to openDevTools will show them detached (even after restarting the app). At least on Windows. (Tested with Atom-Shell 0.22.1)

Oh yeah, Frank's right. Dupe of #1135. There's also a hacky work-around.

I'm closing this and reopening #1135.


Fix problems with ODF and eliminate need for scripts

There were some problems with the ODF install.  The operator now
installs and the storagesystem and the storagecluster are properly
setup.  Observability I think is still have trouble writing to noobaa,
but there are statistics and details that show things are closer to
working properly.  While I made those changes I also eliminated the
scripts required by taking Andrew's advice and incorporating the post
scripts as jobs that run in the local-quay and stackrox namespaces
to setup secrets those apps need.
Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

/check-dco