NullReferenceException in Vertical.SpectreLogger.Templates

From #25 reported by @duggaraju
Unhandled exception. System.AggregateException: An error occurred while writing to logger(s). (Object reference not set to an instance of an object.)
---> System.NullReferenceException: Object reference not set to an instance of an object.
at Vertical.SpectreLogger.Templates.TemplateSegment.get_CompositeFormatSpan()
at Vertical.SpectreLogger.Output.WriteBufferExtensions.WriteLogValue[T](IWriteBuffer buffer, LogLevelProfile profile, TemplateSegment templateSegment, T value, Action1 writer) at Vertical.SpectreLogger.Rendering.RendererPipeline.Render(LogEventContext& logEventContext) at Vertical.SpectreLogger.SpectreLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func3 formatter)
at Microsoft.Extensions.Logging.Logger.g__LoggerLog|13_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func3 formatter, List1& exceptions, TState& state)
--- End of inner exception stack trace ---
at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List1 exceptions) at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func3 formatter)
at Microsoft.Extensions.Logging.Logger1.Microsoft.Extensions.Logging.ILogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func3 formatter)
at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, String message, Object[] args)

This was the simplest code I was able to repro the issue.
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Vertical.SpectreLogger;
var collection = new ServiceCollection();
collection.AddLogging(builder => builder.AddSpectreConsole());
var provider = collection.BuildServiceProvider();
var logger = provider.GetRequiredService<ILogger>();
var exception = new NotSupportedException("Some randome exception");
await Task.WhenAll(Enumerable.Range(0, 20).Select(async i => {
await Task.Delay(500);
try
{
throw exception;
}
catch (Exception ex)
{
logger.LogError(ex, "Try log an error message {i}", i);
}
}));
Markup error: Encountered malformed markup tag at position 18.
Markup error: Encountered malformed markup tag at position 18.
[9:27:49 AM Fail] Try log an error message 7
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 19
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 8
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 5
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 9
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 6
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 12
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 11
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 1
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
Tried to write:
[9:27:50 AM Fail] Try log an error message 15
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:50 AM Fail] Try log an error message 2
System.NotSupportedException: Some randome exception
[9:27:50 AM Fail] Try log an error message 13
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[grey85][[[grey85]
[9:27:50 AM Fail] Try log an error message 3
System.NotSupportedException: Some randome exception
[9:27:50 AM Fail] Try log an error message 18
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
Tried to write:
[9:27:50 AM Fail] Try log an error message 0
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[grey85][[[grey85]
[9:27:50 AM Fail] Try log an error message 16
System.NotSupportedException: Some randome exception
[9:27:50 AM Fail] Try log an error message 14
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
[9:27:49 AM Fail] Try log an error message 4
System.NotSupportedException: Some randome exception
at <<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 19
Unhandled exception. System.AggregateException: An error occurred while writing to logger(s). (Object reference not set to an instance of an object.)
---> System.NullReferenceException: Object reference not set to an instance of an object.
at Vertical.SpectreLogger.Templates.TemplateSegment.get_CompositeFormatSpan()
at Vertical.SpectreLogger.Output.WriteBufferExtensions.WriteLogValue[T](IWriteBuffer buffer, LogLevelProfile profile, TemplateSegment templateSegment, T value, Action1 writer)    at Vertical.SpectreLogger.Rendering.DateTimeRenderer.Render(IWriteBuffer buffer, LogEventContext& context)    at Vertical.SpectreLogger.Rendering.RendererPipeline.Render(LogEventContext& logEventContext)    at Vertical.SpectreLogger.SpectreLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func3 formatter)
at Microsoft.Extensions.Logging.Logger.g__LoggerLog|12_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func3 formatter, List1& exceptions, TState& state)
--- End of inner exception stack trace ---
at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List1 exceptions)    at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func3 formatter)
at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
at Microsoft.Extensions.Logging.LoggerExtensions.LogError(ILogger logger, Exception exception, String message, Object[] args)
at Program.<>c__DisplayClass0_0.<<$>b__1>d.MoveNext() in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 23
--- End of stack trace from previous location ---
at Program.$(String[] args) in C:\Users\krishndu\source\repos\ConsoleTest\ConsoleTest\Program.cs:line 15
at Program.(String[] args)
The trick was the Task.Delay() to ensure it would await and run later.
I also see markup errors because of mismatched [ brackets

Doesn't repro every time but easily  1 in 5 I can repro this.  My theory is that RegEx.Match is doing a delayed evaluation and is not thread safe but haven't digged in to the MSDN docs yet.

If I change the TemplateSegment class to do the match expansion in the constructor i don't have the issue.
class TemplateSegment
{
public TemplateSegment(Match? match,...)
{
CompositeFormatSpan = match?.Groups[CompositeFormatSpanGroup].Value;
}
private string? CompositeFormatSpan { get; }
}
From microsoft documentation:
https://learn.microsoft.com/en-us/dotnet/standard/base-types/thread-safety-in-regular-expressions
However, result objects (Match and MatchCollection) returned by Regex should be used on a single thread. Although many of these objects are logically immutable, their implementations could delay computation of some results to improve performance, and as a result, callers must serialize access to them.

This is extremely helpful @duggaraju, thank you! I will get into this tonight.

@duggaraju - a new pre-release package will be up on NuGet shortly. Let me know if the issue still occurs.

I tried 0.10.1-dev.20230711.18 of the package and can still repro the issue.   am I missing something?

Hmm, with the change I made I cannot repro now, but I will begin tweaking the parameters of the repro project and see if I can't get it to misbehave again.

I was able to repro this on the sample bug-repro/MultiThreaded  but changing the delay to Task.Delay(25)
Just calling _match.Groups creates a GroupCollection object but doesn't evaluate anything.  The right thing to be thread safe is to get the values in the constructor instead of getter.

Implementing...

@duggaraju - can you grab latest and experiment with the MultiThreaded console project? I implemented the changes you suggested and wanted some additional verification before I push out another dev build

Thank you very much. This is working great. I have been at it for some time and was unable to repro the issue.

Excellent - will close this and push to NuGet.


init commit

finish the OC version.  But the OC version has a little shortage : at the end of presentation,the shapeLayer can't animate using physical spring. I hope someone can resolve this problem.

Thank you very much for your help! This is really helpful.


SetTx Illegal Status

Hi,
I am facing "SetTx Illegal Status" issue. I am using EBYTE E22-900M30S and I have set the frequency to 915 MHz. I have also increased the timeout to 3000Ms.
Please have a look at my debug print:
I (7407) LoRa126x: WriteCommand: CMD=0x8c
I (7467) LoRa126x: 00 --> d2
I (7487) LoRa126x: 08 --> d2
I (7527) LoRa126x: 00 --> d2
I (7547) LoRa126x: 18 --> d2
I (7577) LoRa126x: 01 --> d2
I (7607) LoRa126x: 00 --> d2
I (7607) LoRa126x: WriteCommand: CMD=0x02
I (7667) LoRa126x: 03 --> d2
I (7687) LoRa126x: ff --> d2
I (8407) LoRa126x: ----- SetTx timeoutInMs=3000
I (8407) LoRa126x: WriteCommand: CMD=0x80
I (8467) LoRa126x: 00 --> d2
I (8467) LoRa126x: SetTxEnable:SX126x_TXEN=-1 SX126x_RXEN=-1
I (8467) LoRa126x: SetTx timeoutInMs=3000 tout=192000000
I (8467) LoRa126x: WriteCommand: CMD=0x83
I (8527) LoRa126x: 71 --> a2
I (8547) LoRa126x: b0 --> a2
I (8587) LoRa126x: 00 --> a2
I (8597) LoRa126x: ReadCommand: CMD=0xc0
I (8657) LoRa126x: DataIn:62
I (8657) LoRa126x: ReadCommand: CMD=0xc0
I (8717) LoRa126x: DataIn:2c
E (8717) LoRa126x: SetTx Illegal Status
Please guide me if I am missing anything.
--
Thanks,
Pravin

I don't have this one.
With this change it may work.
	//float tcxoVoltage = 0.0; // don't use TCXO
	//bool useRegulatorLDO = false; // use only LDO in all modes

	float tcxoVoltage = 3.3; // use TCXO
	bool useRegulatorLDO = true; // use TCXO

Thanks! After "use TCXO" and Pin connection as mentioned in https://github.com/nopnop2002/esp-idf-sx126x/pull/5#issue-1323583221 it starts working...

Pin connection as mentioned in https://github.com/nopnop2002/esp-idf-sx126x/pull/5#issue-1323583221 it starts working

I would like to know more about the wiring you did.

SX126X
ESP32-C3

BUSY
GPIO18

RST
GPIO19

TXEN
-1

RXEN
-1

MISO
GPIO2

SCK
GPIO6

MOSI
GPIO7

NSS
GPIO10

GND
GND

VCC
3.3V

Do we need this?
DIO2 pin on Ebyte module must be connected to TXEN pin on Ebyte module

No, I have not used DIO2 pin or any other pins. I have used only those pins as shown in the above table.
I have tested the sender/receiver code with 433 MHz and 915 MHz. It is working properly.

Thank you.


Made the rearrange clean and robust, also well tested with rearrange einops tests

Combined multiple assert statements into single lines where possible.
Simplified some variable names and expressions.
Removed redundant type hints within the method.
Condensed the ellipsis resolution logic into fewer lines.
Simplified the final operations (unflatten, permute, flatten/unsqueeze) by removing intermediate variable assignments.

please read https://github.com/tinygrad/tinygrad/?tab=readme-ov-file#contributing


Update specification to list previous_hash field in root.json [WIP]

@JustinCappos What do you think of the previous_hash entry?  Does it successfully support hash-chained histories?  Should we also optionally allow all roles to list it in their metadata? (in my edit to tuf-spec.txt, it is only specified for root.json.)

Coverage remained the same at 94.767% when pulling eddd4d32fce78b88300b11277becb04b61a3f63d on vladimir-v-diaz:list_previous_hash into fae81f6be1368bf7f7eb3beb7ce1911663f0d1f3 on theupdateframework:develop.

At a minimum, it must be in timestamp too, because I think the Docker folks
need this for their use case.
If it's optional, what happens if it is missing sometimes?  Can one just
add / remove it as they like?
On Mon, Aug 8, 2016 at 3:59 PM, Vladimir Diaz<EMAIL_ADDRESS>wrote:

@JustinCappos https://github.com/JustinCappos What do you think of the
previous_hash entry? Does it successfully support hash-chained histories?
Should we also optionally allow all roles to list it in their metadata? (in
my edit to tuf-spec.txt, it is only specified for root.json.)
You can view, comment on, or merge this pull request online at:
https://github.com/theupdateframework/tuf/pull/357
Commit Summary

Update specification to list previous_hash field in root.json
Edit PREVIOUS_HASH section

File Changes

M docs/tuf-spec.txt
https://github.com/theupdateframework/tuf/pull/357/files#diff-0 (15)

Patch Links:

https://github.com/theupdateframework/tuf/pull/357.patch
https://github.com/theupdateframework/tuf/pull/357.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/tuf/pull/357, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0XDxtZg4ptK3jwbsbtyUTQp1kUkt_Kks5qd4qGgaJpZM4JfadN
.

Coverage remained the same at 94.767% when pulling 71585d74156c44f07981ac9cf1dc2841e66f710d on vladimir-v-diaz:list_previous_hash into fae81f6be1368bf7f7eb3beb7ce1911663f0d1f3 on theupdateframework:develop.


change the deduplication id for the sns receiver

Change the deduplication id to use groupKey + now from the context. now is generated from https://github.com/prometheus/alertmanager/blob/main/dispatch/dispatch.go#L442 which should be different from each flush.
This change should be fix the following cases:

The users are setting repeat_interval to be less than 5m, the messages are getting deduplicated by the SNS even though users want to receive the message less than 5m interval
The users unable to receive the message from the alerts get resolved in 5m

I suspect that this will break alertmanager HA functionnality, as Now will not be unique accross the cluster.

I suspect that this will break alertmanager HA functionnality, as Now will not be unique accross the cluster.

I'm not sure this would be the case, the dedup stage (where we look at the notification log) happens before the retry stage (where we execute the Notify function) - by the time we get to use now, we've already determined that we need to notify.
https://github.com/prometheus/alertmanager/blob/a38c5b8f1d780ce042a53a217af8c56316ed3071/notify/notify.go#L359-L365
In principle, the change seems safe. WDYT @roidelapluie?
@qinxx108 is there any chance you can provide us with a test account? I feel like to review/approve this change we'd need to test it against SNS.

I've tested this by creating a receiver that has both a webhook and SNS config  with a repeat interval of 1m.
For the webhook, I get new webhooks every minute and for SNS I get new message_id and sequence for each send.  This was not the same when I tried it out without this change.
ts=2022-06-30T16:34:08.710Z caller=sns.go:94 level=debug integration=sns msg="SNS message successfully published" message_id=ea06867b-379c-5469-8c6c-dd4ce55e260a sequencenumber=10000000000000019000
ts=2022-06-30T16:35:38.416Z caller=sns.go:94 level=debug integration=sns msg="SNS message successfully published" message_id=06b00bb4-0eb2-5913-acc2-5083ddae2675 sequencenumber=10000000000000020000


Extensible mapping between ECMA script and GO field/method names

In my project I need to use a custom mapping between go field/names and the property names visible to ECMA script code.
In particular I need to surface go field names with the name defined in the json field tag.
Example:
type MyStruct struct {
    MyField string `json:"myfield"` // <-- field with json tag
}

In ECMA script:
var v = ...;
console.log(v.myfield);  // <-- name defined by json tag

To achieve that I introduced a ReflectNamer interface and a public property Naming.

Please see my latest commit.

👍  your solution is not only nicer but also a lot faster! thx


[camera] Flutter Camera Picture is currently already being captured

Steps to Reproduce

take picture in first open
taking the second photo will be an error

Code:
if (_controller == null ||
          !(_controller?.value.isInitialized ?? false) ||
          (_controller?.value.isTakingPicture ?? false)) {
        return;
      }

      final file = await _controller?.takePicture();
      print(file?.path);

      if (widget.onCapture != null) {
        widget.onCapture?.call(File(file?.path ?? ''));
      }
      setState(() {});
    } on CameraException catch (e) {
      log(e.description ?? '');
      IndicatorsUtils.showErrorSnackBar(context, e.description);
    } catch (e) {
      log(e.toString());
    }

Expected results:
Can take photos at the second time or so.
Actual results:

Logs
Picture is currently already being captured

Analyzing 2 directories...
No issues found! (ran in 215.9s)

[√] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19041.928], locale en-ID)
    • Flutter version 2.0.4 at C:\flutter
    • Framework revision b1395592de (5 weeks ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\wisnu\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.55.2)
    • VS Code at C:\Users\wisnu\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[√] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Windows (desktop)                  • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.928]
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 90.0.4430.93
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 90.0.818.49

! Doctor found issues in 1 category.

Hi @wisnuwiry
Thanks for filing the issue, to be able to reproduce the issue, I have created a minimal runnable code sample based on your code snippet. Using this code sample, I took multiple pics back to back, and Picture is currently already being captured exception is never thrown on a physical Android device

code sample
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:camera/camera.dart';

late List<CameraDescription> cameras;

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();

  cameras = await availableCameras();
  runApp(CameraApp());
}

class CameraApp extends StatefulWidget {
  @override
  _CameraAppState createState() => _CameraAppState();
}

class _CameraAppState extends State<CameraApp> {
  CameraController? controller;

  @override
  void initState() {
    super.initState();
    controller = CameraController(cameras[0], ResolutionPreset.max);
    controller?.initialize().then((_) {
      if (!mounted) {
        return;
      }
      setState(() {});
    });
  }

  @override
  void dispose() {
    controller?.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    if (!controller!.value.isInitialized) {
      return Container();
    }
    return MaterialApp(
      home: Scaffold(
        body: CameraPreview(controller!),
        floatingActionButton: FloatingActionButton(
            child: Icon(Icons.camera),
            onPressed: () async {
              try {
                if (controller == null ||
                    !(controller?.value.isInitialized ?? false) ||
                    (controller?.value.isTakingPicture ?? false)) {
                  return;
                }
                final file = await controller?.takePicture();
                print(file?.path);
                setState(() {});
              } on CameraException catch (e) {
                print(e);
              } catch (e) {
                print(e);
              }
            }),
      ),
    );
  }
}

logs
W/BpBinder(24773): Slow Binder: BpBinder transact took 398 ms, interface=android.hardware.camera2.ICameraDeviceUser, code=1 oneway=false
I/Camera  (24773): [FPS Range Available] is:[4, 15]
I/Camera  (24773): [FPS Range Available] is:[15, 15]
I/Camera  (24773): [FPS Range Available] is:[8, 30]
I/Camera  (24773): [FPS Range Available] is:[30, 30]
I/Camera  (24773): [FPS Range] is:[8, 30]
W/Camera  (24773): The selected imageFormatGroup is not supported by Android. Defaulting to yuv420
W/s.cameraexample(24773): type=1400 audit(0.0:103292): avc: denied { read } for name="u:object_r:persist_camera_prop:s0" dev="tmpfs" ino=28851 scontext=u:r:untrusted_app_27:s0:c3,c257,c512,c768 tcontext=u:object_r:persist_camera_prop:s0 tclass=file permissive=0
E/libc    (24773): Access denied finding property "persist.vendor.camera.privapp.list"
I/flutter (24773): /data/user/0/io.flutter.plugins.cameraexample/cache/CAP893386284851915235.jpg
I/flutter (24773): /data/user/0/io.flutter.plugins.cameraexample/cache/CAP4985981757268562032.jpg

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.6, on Microsoft Windows [Version 10.0.19042.928], locale en-US)
    • Flutter version 2.0.6 at C:\Users\Taha\Code\flutter_stable
    • Framework revision 1d9032c7e1 (6 days ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31205.134
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.0)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • def0ad20 • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.19042.928]
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 90.0.4430.93
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 90.0.818.51

! Doctor found issues in 1 category.

Please try the code sample above, let me know if you can reproduce the issue, if required, feel edit my code sample to make the issue reproducible
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Models not showing on my end only (every version)

Short explanation: When I use any version of the mod, the models dont show on my end and the menu to refresh the skin says an error. I cannot see my custom skin, nor any of my friends' skins.
Long explanation: I tested a bunch of stuff to try to find the source for myself but I dont know how to fix it. I'll say all the stuff I tested and give the limited knowledge conclusions I drew from them.

None of the versions work. Both fabric and forge, any minecraft update, even outdated versions of the mod for updates that worked before.
when I load a local file skin, it shows that on my end (in singleplayer or on servers with the mod installed) It also work in the same situations if I click the "test in game" option in the editor.
If I'm on a server with friends, both with and without the mod uploaded on the server, they can see my skin and their skin, but I cant see my own or theirs.
when in the gestures menu, the error given says something about "unrecognized ssl message" or something like "not available"
When looking in the game output log, it said something about "semver" which, when I looked it up, said something about incompatible versions which doesnt make sense because it's with all versions of the mod and many of them are scenarios that worked correctly together for a long time.
I use the git gist thing for the skin information storage, I dont have a skin that's small enough of a file to test otherwose, but I doubt it due to the fact that other people can see the skin i'm using.

Something in your network or PC is blocking access GitHub gists. Check your antivirus or firewall if its blocking gist.githubusercontent.com. Also try clicking the Raw button on the gist page and see what comes up.


Navigation commands for WebView should be handled by Redux actions vi…

…a state changes observed by Page. r=vp,linclark
Fixes #119.
This removes most of the usage of different components querying the DOM for the webview, and so only the Page object manages its WebView*. There are still other things grabbing the webview with getCurrentWebView but these are for non-navigation components like copy/paste, may need a different solution to clean that up
This feels more Reduxy, and commands are executed as the most recent 'command' (refresh, back, forward, etc) is stored in the Page state, so the Page knows if it needs to fire off a command or not. Is this the right way to do this? Feels nice, having these pretty big deal actions actually reflected in the redux state, though.
Can't assign to @linclark for some reason (?), but would like both of ya @victorporof to take a look at this, because I think this problem will come up again so good to have a pattern for dealing with it

Coverage decreased (-11.04%) to 72.414% when pulling 1a7e4f640c5b3a20f2d7980a0d243af4261e8fa8 on jsantell:loc-nav into 72bac8076803f2bc88fd78ce21d0a897dd2b25ff on mozilla:master.

That coverage diff is awesome.

Coverage increased (+4.1%) to 87.571% when pulling 12702b6c97e276ef74b886f127195c4b08afdf63 on jsantell:loc-nav into 72bac8076803f2bc88fd78ce21d0a897dd2b25ff on mozilla:master.

This is so hot.

Coverage increased (+4.1%) to 85.714% when pulling 0c29f836cccddfb4e9dca2d17d463828bff2f0d2 on jsantell:loc-nav into 3e015282b64a0620a3e6172b7b3fff19035e00aa on mozilla:master.

I think the state might need to be slightly restructured because of React's batching.
What would we want to have happen if multiple state changes to the page were happening in the same batch and each was trying to execute a different command? Would we want each one of the commands to be executed, or just the last one? With the current code, I think just the last one might be executed.
After a component is updated, its componentDidUpdate method is added to a queue (rather than invoked directly). Because of this, I believe there is no guarantee that each one of the states we set will reach componentDidUpdate.
If we restructured the state, I think it would be safer.
// Pages is a map with incremental IDs for keys
pages: {
  15: { ... },
  16: { ... },
  22: { ... },
},
// Commands is a map using the same keys as pages does
commands: {
  15: [
    'back',
    'back',
    'forward'
  ],
  16: []
  22: []
}

In the connect() function for the page, we would get both the page and the corresponding commands array. Then on componentDidUpdate, we could check the length of the commands array against the previous length and run any commands that had been added to the array since the last pass through.

@linclark Ah, good to know about the batching! That certainly affects things here. I'll update the PR to store a command queue per page to see how that will look -- adding it to the root state object might make more sense if/when we add more commands? But at the same time, these commands are specifically to manipulate the webview... we'll see how this updated PR looks

So unless we drain the queue, this command list will keep growing unless the Page also fires a command indicating to clear out command queue (which seems like a wasteful action) -- I think that was the original reason of having the unique ID on the command to ensure the command wasn't already executed. Is there a good way to handle this?

This is an idea. I don't particularly like it, but just to put it out there...
We could store the ID of the last executed command as state on the Page. Then, we could pass that in with future actions and prune anything before it.
I'm thinking it might be premature to optimize that way at this point, though, for two reasons.

I'm thinking webview might become more React friendly once the GitHub teams are working with React more.
Long term, we might want to consider integrating something else (like Relay) which might change the way we handle actions

Coverage increased (+3.09%) to 86.957% when pulling 7ec2858aaf59129eb16b7a2ee75ee1a9c1ce0938 on jsantell:loc-nav into 2acd09c9fc2287fe8389ef7e37c1fd2c67e37e86 on mozilla:master.


Investigate making the stackable k8s client "injectable"

The problem
Currently the stackable k8s client is a hard-coded struct in the operator state. Problems:

Large portions of operator code are not unit testable.
Related maybe #147
Cannot have  a synchronous client if necessary.

Proposed solution
Notes:

Related discussions at kube-rs level:

https://github.com/clux/kube-rs/issues/429
https://github.com/clux/kube-rs/pull/532
https://github.com/clux/kube-rs/issues/539

Not needed anymore I believe


when i used "rasa shell",  get this message "RuntimeError: this event loop is already running. "

Rasa version:  2.0.0a1
Rasa SDK version (if used & relevant): 2.0.0a1
Rasa X version (if used & relevant):
Python version:  3.7.2
Operating system (windows, osx, ...): mac os
Issue:
this is my first time use rasa,  i just followed the tutorial https://rasa.com/docs/rasa/user-guide/rasa-tutorial/ ，when i executed commands like this
“rasa init” 、 “rasa train”、“rasa test” ， everything was ok，    but    “rasa shell” called this error。
so  i wanted figure out what happened，  i found  “questionary.text” this code caused this error，
-> exit_text = INTENT_MESSAGE_PREFIX + "stop"
(Pdb) c
Bot loaded. Type a message and press enter (use '/stop' to exit):
get_user_input None
2020-08-06 22:40:21 ERROR    asyncio  - Task exception was never retrieved
future: <Task finished coro=<configure_app.<locals>.run_cmdline_io() done, defined at /Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/run.py:129> exception=RuntimeError('this event loop is already running.')>
Traceback (most recent call last):
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/run.py", line 135, in run_cmdline_io
    sender_id=conversation_id,
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py", line 158, in record_messages
    exit_text = INTENT_MESSAGE_PREFIX + "stop"
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py", line 102, in get_user_input
    style=Style([("qmark", "#b373d6"), ("", "#b373d6")]),
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/questionary/question.py", line 45, in ask
    return self.unsafe_ask(patch_stdout)
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/questionary/question.py", line 59, in unsafe_ask
    return self.application.run()
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/prompt_toolkit/application/application.py", line 812, in run
    self.run_async(pre_run=pre_run, set_exception_handler=set_exception_handler)
  File "uvloop/loop.pyx", line 1450, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1443, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1351, in uvloop.loop.Loop.run_forever
  File "uvloop/loop.pyx", line 480, in uvloop.loop.Loop._run
RuntimeError: this event loop is already running.

so i  replaced this code with
def get_user_input(previous_response: Optional[Dict[str, Any]]) -> Optional[Text]:

    print("get_user_input", previous_response)
    button_response = None
    if previous_response is not None:
        button_response = print_bot_output(previous_response, is_latest_message=True)
    if button_response is not None:
        response = cli_utils.payload_from_button_question(button_response)
        if response == cli_utils.FREE_TEXT_INPUT_PROMPT:
            # Re-prompt user with a free text input
            response = get_user_input({})
    else:
        # response = questionary.text(
        #     "",
        #     qmark="Your input ->",
        #     style=Style([("qmark", "#b373d6"), ("", "#b373d6")]),
        # ).ask()
        response = "hello"
    return response.strip() if response is not None else None

cmdline
core_model /var/folders/fs/s2xtkzg134544tcgn_jcqsx80000gn/T/tmpwcr8pr9w/core
nlu_model /var/folders/fs/s2xtkzg134544tcgn_jcqsx80000gn/T/tmpwcr8pr9w/nlu
args Namespace(auth_token=None, connector='cmdline', conversation_id='2c5875d79ddb48218933f703d2f2060e', cors=None, credentials=None, enable_api=False, endpoints=None, func=<function shell at 0x115438488>, jwt_method='HS256', jwt_secret=None, log_file=None, loglevel=None, model='models', port=5005, remote_storage=None, response_timeout=3600, ssl_ca_file=None, ssl_certificate=None, ssl_keyfile=None, ssl_password=None, **{'model-as-positional-argument': None})
2020-08-06 22:36:57 INFO     root  - Connecting to channel 'cmdline' which was specified by the '--connector' argument. Any other channels will be ignored. To connect to all given channels, omit the '--connector' argument.
yxp _create_app_without_api
2020-08-06 22:36:57 INFO     root  - Starting Rasa server on http://localhost:5005
Starting Rasa server on http://localhost:5005
2020-08-06 22:37:16 INFO     rasa.nlu.components  - Added 'SpacyNLP' to component cache. Key 'SpacyNLP-en'.
/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/policies/mapping_policy.py:58: FutureWarning: 'MappingPolicy' is deprecated and will be removed in the future. It is recommended to use the 'RulePolicy' instead.
  docs=DOCS_URL_MIGRATION_GUIDE,
/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/policies/form_policy.py:42: FutureWarning: 'FormPolicy' is deprecated and will be removed in in the future. It is recommended to use the 'RulePolicy' instead.
  docs=DOCS_URL_MIGRATION_GUIDE,
2020-08-06 22:37:24 INFO     root  - Rasa server is up and running.
> /Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py(158)record_messages()
-> exit_text = INTENT_MESSAGE_PREFIX + "stop"
(Pdb) c
Bot loaded. Type a message and press enter (use '/stop' to exit):
get_user_input None
handler message <rasa.core.channels.channel.UserMessage object at 0x154603160>
<rasa.core.channels.channel.QueueOutputChannel object at 0x1545a3be0>
get_user_input {'recipient_id': '2c5875d79ddb48218933f703d2f2060e', 'text': 'Hey! How are you?'}
Hey! How are you?
handler message <rasa.core.channels.channel.UserMessage object at 0x154603048>
<rasa.core.channels.channel.QueueOutputChannel object at 0x1545a3dd8>
get_user_input {'recipient_id': '2c5875d79ddb48218933f703d2f2060e', 'text': 'Hey! How are you?'}
Hey! How are you?
handler message <rasa.core.channels.channel.UserMessage object at 0x1546030b8>
<rasa.core.channels.channel.QueueOutputChannel object at 0x1545a3978>
get_user_input {'recipient_id': '2c5875d79ddb48218933f703d2f2060e', 'text': 'Hey! How are you?'}
Hey! How are you?

I would appreciate it if anyone could tell me how to solve this problem
Error (including full traceback):
cmdline
core_model /var/folders/fs/s2xtkzg134544tcgn_jcqsx80000gn/T/tmpr_s7qsg0/core
nlu_model /var/folders/fs/s2xtkzg134544tcgn_jcqsx80000gn/T/tmpr_s7qsg0/nlu
args Namespace(auth_token=None, connector='cmdline', conversation_id='819601b878394908a00b26496a0fb44d', cors=None, credentials=None, enable_api=False, endpoints=None, func=<function shell at 0x11865d488>, jwt_method='HS256', jwt_secret=None, log_file=None, loglevel=None, model='models', port=5005, remote_storage=None, response_timeout=3600, ssl_ca_file=None, ssl_certificate=None, ssl_keyfile=None, ssl_password=None, **{'model-as-positional-argument': None})
2020-08-06 22:38:29 INFO     root  - Connecting to channel 'cmdline' which was specified by the '--connector' argument. Any other channels will be ignored. To connect to all given channels, omit the '--connector' argument.
yxp _create_app_without_api
2020-08-06 22:38:29 INFO     root  - Starting Rasa server on http://localhost:5005
Starting Rasa server on http://localhost:5005
2020-08-06 22:38:49 INFO     rasa.nlu.components  - Added 'SpacyNLP' to component cache. Key 'SpacyNLP-en'.
/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/policies/mapping_policy.py:58: FutureWarning: 'MappingPolicy' is deprecated and will be removed in the future. It is recommended to use the 'RulePolicy' instead.
  docs=DOCS_URL_MIGRATION_GUIDE,
/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/policies/form_policy.py:42: FutureWarning: 'FormPolicy' is deprecated and will be removed in in the future. It is recommended to use the 'RulePolicy' instead.
  docs=DOCS_URL_MIGRATION_GUIDE,
2020-08-06 22:38:57 INFO     root  - Rasa server is up and running.
> /Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py(158)record_messages()
-> exit_text = INTENT_MESSAGE_PREFIX + "stop"
(Pdb) c
Bot loaded. Type a message and press enter (use '/stop' to exit):
get_user_input None
2020-08-06 22:40:21 ERROR    asyncio  - Task exception was never retrieved
future: <Task finished coro=<configure_app.<locals>.run_cmdline_io() done, defined at /Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/run.py:129> exception=RuntimeError('this event loop is already running.')>
Traceback (most recent call last):
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/run.py", line 135, in run_cmdline_io
    sender_id=conversation_id,
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py", line 158, in record_messages
    exit_text = INTENT_MESSAGE_PREFIX + "stop"
  File "/Users/yinxingpan/rasa_learn/rasa-2.0.0a1/rasa/core/channels/console.py", line 102, in get_user_input
    style=Style([("qmark", "#b373d6"), ("", "#b373d6")]),
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/questionary/question.py", line 45, in ask
    return self.unsafe_ask(patch_stdout)
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/questionary/question.py", line 59, in unsafe_ask
    return self.application.run()
  File "/Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/prompt_toolkit/application/application.py", line 812, in run
    self.run_async(pre_run=pre_run, set_exception_handler=set_exception_handler)
  File "uvloop/loop.pyx", line 1450, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1443, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1351, in uvloop.loop.Loop.run_forever
  File "uvloop/loop.pyx", line 480, in uvloop.loop.Loop._run
RuntimeError: this event loop is already running.
Your input ->
2020-08-06 22:43:55 ERROR    asyncio  - Task exception was never retrieved
future: <Task finished coro=<Application.run_async() done, defined at /Users/yinxingpan/rasa_learn/venv/lib/python3.7/site-packages/prompt_toolkit/application/application.py:593> exception=KeyboardInterrupt()>
Traceback (most recent call last):

Command or request that led to error:
rasa shell

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

Thanks for the issue, @Ghostvv will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

hi @laoyin, I just tested this on 2.0.0a1 and rasa shell is working fine for me. can you share exact steps to reproduce this issue?


ALB redirection

I see there is a redirection to Senzing in ALB - Is this intended?
Redirect tohttps://hub.senzing.com:443/aws-cloudformation-ecs-senzing-stack-basic/?#{query}
Status code:HTTP_301

@christianswanepoel Oh, I now see what you are asking.  You can redirect to anything you want if there is no URI match.  In the example, the thinking is that if someone requests an unsupported URI, they need more information on what is supported by the cloudformation stack.  So we point them to the GitHub project  "GitHub Pages".  Feel free to modify the Cloudformation template to point to what is appropriate in your case.
(This discussion is probably better held in https://github.com/Senzing/aws-cloudformation-ecs-senzing-stack-basic)


Allow scheduling image ssa

@jrafanie @simon3z @dclarizio Please review

LGTM :+1: ready for merge cc @chessbyte @blomquisg

@AparnaKarve please review.

@moolitayer When you create a schedule of type Container Image, and load it, the JSON that the angular controller receives has a null filter_type,  due to which the Filter Type dropdown is not populated with the right value.
To resolve this, make sure you also account for "ContainerImage.ext_management_system-name" in this method determine_filter_type_and_value
Thanks.

@moolitayer When you create a schedule of type Container Image, and load it, the JSON that the angular controller receives has a null filter_type, due to which the Filter Type dropdown is not populated with the right value.
To resolve this, make sure you also account for "ContainerImage.ext_management_system-name" in this method determine_filter_type_and_value
Thanks.

@AparnaKarve Thanks! fixed the edit problem.
I tested the three filters: Single image, All Images, All provider images
for: creating, editing, running and deleting and they all work fine now.
@AparnaKarve could you please review again?

Closing/reopening to kick off Travis.

@moolitayer Looks good now! :+1:
/cc @blomquisg


burdoc aborting while trying parsing a PDF file

I have some PDF file from the same Publisher that I want to investigate into using burdoc. Some of these files are parsed elegant, while others are not parsed at all.
I use the cli version of burdoc.
Attached here are one PDF file that are not being parsed and the log file generated.
The.pdf
burdoc log.log

Thanks for highlighting. I'm currently travelling but will try and take a look at this and your other opened issue this weekend!

Dear Dennis.
Thanks for caring.
Is it possible to extract the text without the tables as an option? I use the CLI, so it may very well be with a parameter specifying that option. It should be possible, especially because you wrote: "ML-Powered Table Extraction: Burdoc makes use of the latest machine learning models for identifying tables, alongside a rules-based approach to identify inline tables.". It sounds impressive to me. This could also mean that you have all the tables in your hands, and it should therefore not be a huge problem to not include them in the text if they are not wanted.
By the way, what are "inline tables"?
Have a nice trip and a safe return (I need extracted texts from different PDF files, hopefully without the tables included).
Best regardsFrank NielsenDenmark
Den torsdag den 25. maj 2023 kl. 00.52.41 CEST skrev jennis0<EMAIL_ADDRESS>

Thanks for highlighting. I'm currently travelling but will try and take a look at this and your other opened issue this weekend!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Fixed the crash - should be available in v0.2.2.
On tables - unfortunately it seems like the PDF you posted doesn't seem to get it's tables detected by the extraction algorithm currently in use. I'm hoping a branch I'm currently working on will greatly improve this but it might be a little way off depending on the amount of time I have to commit. In the meantime, you can use the '--no-ml-tables' option in the CLI to get a big speed-boost given it won't find the tables anyway...
It might also be worth mentioning that Burdoc is currently extremely poor at handling maths, it's something I'd like to improve but that will likely be quite a while in the future!
If you don't mind, I'd be quite keen to make use of your file for future testing as it seems like it's hits a few edge cases I'd like to fix.

Thanks for the quick reply.
I will supply you with further problematic PDF files in the near future. Don't worry.
Best regardsFrank
Den fredag den 26. maj 2023 kl. 18.57.17 CEST skrev jennis0 @.***>:
Fixed the crash - should be available in v0.2.2.
On tables - unfortunately it seems like the PDF you posted doesn't seem to get it's tables detected by the extraction algorithm currently in use. I'm hoping a branch I'm currently working on will greatly improve this but it might be a little way off depending on the amount of time I have to commit. In the meantime, you can use the '--no-ml-tables' option in the CLI to get a big speed-boost given it won't find the tables anyway...
It might also be worth mentioning that Burdoc is currently extremely poor at handling maths, it's something I'd like to improve but that will likely be quite a while in the future!
If you don't mind, I'd be quite keen to make use of your file for future testing as it seems like it's hits a few edge cases I'd like to fix.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Jennis.
If you could supply me with the slightly modified and corrected version you made recently, I could make some tests about its ability to find the outlines of academic articles.
I have collected about 20.000 scientific articles over the time I worked as an engineer. I could make a little script calling (the updated) burdoc in a loop up against these files and do some logging of the outcome.
I hope to hear from you.
Best regardsFrank Nielsen
----- Videresendt meddelelse ----- Fra: Frank Nielsen @.>Til: jennis0/burdoc @.>Sendt: fredag den 26. maj 2023 kl. 19.21.04 CESTEmne: Re: [jennis0/burdoc] burdoc aborting while trying parsing a PDF file (Issue #6)
Thanks for the quick reply.
I will supply you with further problematic PDF files in the near future. Don't worry.
Best regardsFrank
Den fredag den 26. maj 2023 kl. 18.57.17 CEST skrev jennis0 @.***>:
Fixed the crash - should be available in v0.2.2.
On tables - unfortunately it seems like the PDF you posted doesn't seem to get it's tables detected by the extraction algorithm currently in use. I'm hoping a branch I'm currently working on will greatly improve this but it might be a little way off depending on the amount of time I have to commit. In the meantime, you can use the '--no-ml-tables' option in the CLI to get a big speed-boost given it won't find the tables anyway...
It might also be worth mentioning that Burdoc is currently extremely poor at handling maths, it's something I'd like to improve but that will likely be quite a while in the future!
If you don't mind, I'd be quite keen to make use of your file for future testing as it seems like it's hits a few edge cases I'd like to fix.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Frank,
The fixed version should be available either by installing directly from the current repo or from pip as v0.2.2 (https://pypi.org/project/burdoc/0.2.2/)
Would be great to hear about the performance you find - I've not done much of an assessment of academic articles and it'd be useful to prioritise any future work (whenever I finally find some time to do some more dev!)
Joe


Add config files to ease contribution

The pipeline isnt complete, this was just an experiment to check if it was possible to override the toolchain file, and I'll happily put in the work if you will actually accept this.

Gonna go ahead and close this as per the last review.


Duco ventilation unit notifications via Niko

Hi there,
Perhaps an odd one, but I have the Niko Hub integrated into Home Assistant, which feeds into Homekit.
My Ducobox Focus ventilation unit is connected officially to my Niko installation, which then feeds these entities into Home Assistant, and thus to HomeKit.
The duco ventilation monitors CO2 levels in my rooms. Every morning the CO2 levels spike for a specific room, which should trigger the Duco to up the air suction for that room to lower it. However, this always generates a CO2 warning push notification via Niko, and thus to HomeKit.
Is there a way to mute this notification in this integration? Does it pass notifcations at all?
I'm not 100% sure where to look.
Thank you.

What do you mean by a "notification"? A push notification in the Niko Home Control app on your phone?
The integration only updates entities. There is nothing in there that sends notifications.

Interesting, the search continues in that case. It's a push notification in HomeKit itself, maybe hassio sets a default CO2 treshold for CO2 sensors. Thanks!

The notification originates with HomeKit.  I encountered the same in my setup (with eCO2 reading coming from an ESP).  The only solution for me was the explicitly remove the sensor from the HomeKit integration in the configuration.yaml, but then of course there is no reading at all.


Adding a bidirectional CKPT converter of TE <-> Pax/T5X

Replaces #425.

@hemildesai @ashors to validate converter

It might be useful to provide some documentation on how to convert BF16 checkpoints to TE FP8 checkpoints, as IIRC the converter only works OOTB for TE BF16. WDYT @mingxu1067?

It might be useful to provide some documentation on how to convert BF16 checkpoints to TE FP8 checkpoints, as IIRC the converter only works OOTB for TE BF16. WDYT @mingxu1067?

Yes, it currently only works OOTB for TE/BF16 only and requires some hacky trick to make the converted CKPT working for TE/FP8. Agree that adding a documentation would be helpful. For longtem support, I am thinking if we could auto-generate FP8 meta for those CKPTs trained on BF16 to further TE/FP8, then things could be much convenient to users.

@mingxu1067 Do you plan to add the documentation in this PR or in a subsequent one?

It would be a subsequent one.

It would be a subsequent one.

In that case, can we add a relnote to the documentation outlining this limitation?

Another suggestion: Pax expects checkpoints to have the following directory structure: ${checkpoint_dir}/checkpoints/checkpoint_${step}. If the checkpoints do not have this structure, restoring from the checkpoint will error. The Pax converter writes the flat checkpoint to $output_path. Perhaps it would be good to instead write the checkpoint to ${output_path}/checkpoints/checkpoint_${step} so users can pass $output_path directly into pax without manually restructuring the directory.

In that case, can we add a relnote to the documentation outlining this limitation?

Sure, where would the proper place to put the note?

Another suggestion: Pax expects checkpoints to have the following directory structure: ${checkpoint_dir}/checkpoints/checkpoint_${step}. If the checkpoints do not have this structure, restoring from the checkpoint will error. The Pax converter writes the flat checkpoint to $output_path. Perhaps it would be good to instead write the checkpoint to ${output_path}/checkpoints/checkpoint_${step} so users can pass $output_path directly into pax without manually restructuring the directory.

Will sync with team to schedule this.

@hemildesai,
We added an argument --skip-ln to support T5 v1.1, please give it a try.
@ashors1,

In that case, can we add a relnote to the documentation outlining this limitation?
We added a description in README.md to guide the steps to run the converted CKPT with TE + FP8. Please help to review.

Another suggestion: Pax expects checkpoints to have the following directory structure: ${checkpoint_dir}/checkpoints/checkpoint_${step}. If the checkpoints do not have this structure, restoring from the checkpoint will error. The Pax converter writes the flat checkpoint to $output_path. Perhaps it would be good to instead write the checkpoint to ${output_path}/checkpoints/checkpoint_${step} so users can pass $output_path directly into pax without manually restructuring the directory.
After thinking, could we set output path with the same structure of Pax as a solution, like --output-path=/your_path_to_output/checkpoints/checkpoint_${step}?

Yeah, that would work. It might be good to document this as well so users do not run into issues trying to pass the flat checkpoint into Pax.

Sure, I think it might be worth to document for both Pax and T5X. I know the CKPT structure for pax is like /your_path_to_output/checkpoints/checkpoint_${step}/state, and what is for T5X?

For T5x it looks like:
/your_path_to_output/checkpoint_${step}/...
Here's an example:
./checkpoint_144000
./checkpoint_144000/flax_mutables.fp8_meta_collection.encoder.layers_10.attention.qkv.fp8_max
./checkpoint_144000/flax_mutables.fp8_meta_collection.decoder.layers_5.self_attention.qkv.fp8_meta_scale
./checkpoint_144000/flax_mutables.fp8_meta_collection.encoder.layers_21.attention.out.fp8_meta_amax
./checkpoint_144000/flax_mutables.fp8_meta_collection.decoder.layers_13.encoder_decoder_attention.out.fp8_max
./checkpoint_144000/flax_mutables.fp8_meta_collection.decoder.layers_2.encoder_decoder_attention.query.fp8_meta_amax
./checkpoint_144000/flax_mutables.fp8_meta_collection.decoder.layers_13.encoder_decoder_attention.kv.fp8_meta_amax
./checkpoint_144000/flax_mutables.fp8_meta_collection.decoder.layers_18.mlp.fp8_meta_amax

Done, kindly review README.md and correct me if there are any santence not proper to publish.

I know the CKPT structure for pax is like /your_path_to_output/checkpoints/checkpoint_${step}/state

I think it should be /your_path_to_output/checkpoints/checkpoint_${step}. If using /your_path_to_output/checkpoints/checkpoint_${step}/state, pax also expects metadata which is not present with this converted checkpoint.


[fix] User token endpoint #303

Verified locally and change user/token to  users/token (Maintain endpoints consistency)

Fixes #303

@Aryamanz29 Please update the readme as well.

Done 👍

Coverage remained the same at 97.771% when pulling 15cb90498aaf5c2f9b1a26b4fd02e136c937db00 on Aryamanz29:issue-303/token-endpoint-diff into 747fb45317a5b97a804b686b3e6ae7e4bc8ff2fd on openwisp:master.


Increase result size

From @andrew-morris :
There's a hidden feature that allows you to include an API key POST param to increase the amount of results you get from 500 to 5,000. I'll add a config file.

Done with 85270fc7c07d72fd1afce59b199171f3fb9aa840


Study Group Directory link broken

Challenge Name

Issue Description

When using this forum post https://forum.freecodecamp.org/t/how-to-create-a-local-study-group/19532 to access the study group directory listing it shows the following error:

I don't see any other link on the website or on the forum to get to the study group directory.
Thanks !
Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

I found it on the beta side going to Community - In your city but nav bars are different between production and beta. Is there a way to update or include this link on the production side? Maybe in the About page?
https://forum.freecodecamp.org/t/freecodecamp-city-based-local-groups/19574

@BerkeleyTrue @texas2010 @systimotic  I confirm the issue. The original study group directory link is broken.
Official link: https://www.freecodecamp.com/study-group-directory/
@mstellaluna Thanks for telling us about it 👍

I am getting the same error message about /study-group-directory/ not being found, but I came across the error whilst completing the challenges section of the website, specifically on https://www.freecodecamp.org/challenges/join-a-freecodecamp-study-group-in-your-city


don't see bamboo plan in build widget

i am using bamboo collector, and it is successful. i create a build widget and list bamboo plans and i choose one plan, and then save it,  all are fine,but i can't see all bamboo plan when i create other build widget in pass one week. api log and bamboo collector logs is not any errors, mongo db also is not any errors. have you any idea.

@baitiandi: I am looking at the BuildController, specifically the search method in the BuildServiceImpl class, and I see that it does use a Start and End Dates to return the build results. Can you please check and share the API call details that your browser is making? You can find this on the developer console, network tab. Please check and share the api url and the parameters on the request. It is possible, for the date range it is only returning what you are seeing. Thanks.

@baitiandi: Did you have any other questions on this, else we can go ahead and close this issue, thanks !


Allow to run in the background

As simple as this command is, this is truly required on any setup that requires testing.
Ideally in my mocha tests, I would write in the global_config.js:
/* eslint-disable */
const dynamodbLocal = require('dynamodb-localhost');

// setup the database
before(async function () {
  await dynamodbLocal.install();
  await dynamodbLocal.start({ port: 8000 });
});

// teardown
after(async function() {
  await dynamodbLocal.stop();
});

// run before each test
beforeEach(() => {});

// run after each test
afterEach(() => {});

Obviously with other test files next to it, who just make a dynamodb connection to the local test database.
This setup, the serverless plugin, or the original dynamodb-local, none of them support the option to run this in the background, as such, these are all useless when attempting to run a CI/CD job on. I can't tell a pipeline to "press ctrl-c" when you're done.

https://www.npmjs.com/package/dynamodb-local allows for running detatched


Added shubham0204/Depth-Anything-Android in README.md

Based on fabio-sim/Depth-Anything-ONNX, this PR adds shubham0204/Depth-Anything-Android which is an Android app performing inference on user-selected images.
The ONNX model is inspired from fabio-sim/Depth-Anything-ONNX which few changes that add pre/post-processing operations to the existing model.
Inference of Depth-Anything on mobile apps could open new frontiers for numerous features, allowing image-understanding in 3D space. The ONNX model included within the app can also be used in iOS apps as ONNX Runtime does support inference on iOS. I believe this Android app will be great addition to the Depth-Anything ecosystem.

Added with thanks!


Possible cause of this.

This bug check is caused when you change the Software Guard Extensions (SGX) mode of the UEFI BIOS from Software Controlled to Enabled.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70fe0f26-49e2-df0d-1864-f325aa4c0cb6
Version Independent ID: b99d000e-7805-5cdd-768f-11249ad48fb8
Content: Bug Check 0x65 MEMORY1_INITIALIZATION_FAILED
Content Source: https://cpubwin.visualstudio.com/_git/drivers?path=%2fwindows-driver-docs-pr%2fdebugger%2fbug-check-0x65--memory1-initialization-failed.md&version=GBlive&_a=contents
Service: unspecified
GitHub Login: @DOMARS
Microsoft Alias: domars

Planning to consolidate the debugging issues and get with the dev team this week.

@kwilliams1987  – Thank you for opening this issue. We use input such as this, along with Windows telemetry and other data, to track trends in stop code behaviors. We add information to the topic if we find the behavior is consistent over time, so we’ve noted your findings and will look into the specific behavior.


Is there a way to save invoice to pdf?

Is there a way to query and save the invoice to pdf?

Hey there,
You can set it up in the provided config file, to auto_save the invoices and which disk should it use.

Hey there,
You can set it up in the provided config file, to auto_save the invoices and which disk should it use.

First of all thanks for the reply!
Yes I see that auto_save is saving when "creating" the invoice, but what if the invoice is already created and I would like the query/save it?

Yeah, that function is not exists yet sadly.
I already thought about it. To be honest I didn't have the free time to implement it, but it is on my to-do list :)
Until that, you can open a Pull Request with that function and I will be happy to check it out :)

Yeah, that function is not exists yet sadly. I already thought about it. To be honest I didn't have the free time to implement it, but it is on my to-do list :)
Until that, you can open a Pull Request with that function and I will be happy to check it out :)

Yes, I'm on the same boat as you I was also glad that this repo exists :)
If I have time in the near future I will create PR
Thanks have a nice day! :)


LED light oscillation

Hello,
how can I prevent LED oscillation? Here is video what I mean http://www.youtube.com/watch?v=CryonJzwedI (best visible sec. 8-16)
It is especially visible when showing bright colors with less brightness.

sorry I was not specific enough.
Instead of using some regular cable between the LED Stripe and the Pi, I use a shielded cable, which was formerly an USB cable. You can also use a shielded Cat5/6 network cable for the connection.
By using such a cable you can eliminate the issues related to flickering (most likely).
What you should do is...

replace the cable to the LED Stripe with a shielded one (USB or cat5 network cable)

use power supply with enough ampere (5 or more)

connect pi and LED to same power supply

use an external usb hub with seperate power supply and add all you connect to PI only over this hub

Hope that helps


Clipboard manager

Description of the new feature / enhancement
Manage several clipboards frequently used.
Choose a shortcut for its determined "control+v".

Scenario when this would be used?
On top on everything, just like a control+V would work.
Supporting information
There are plenty of "side" apps that does that, but they are all over-complicated to use, specially inside a company environment.

I assume you are familiar with the Windows Clipboard History? Can you explain if/why that does not work for you?

I'm not.
Fact that I want to have a few texts saved with a shortcut.
I usually use CTRL + a number, so on #1 I have something frequently used,
and so #2 and #3.
It's faster for me that wants to fill very similar things.
Em ter., 24 de ago. de 2021 10:49, Jay @.***> escreveu:

I assume you are familiar with the Windows Clipboard History? Can you
explain if/why that does not work for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/12858#issuecomment-904659430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APH2QR75BVC5UXJGTXHCLMDT6OPNTANCNFSM5CWZLGBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Then I advise you to search Windows Settings for "Clipboard history", or try pressing Win+V and see what happens.

@afonsopm  is clipboard history inline what you're asking for?


folder_update_prepper: estimate directory size of indirect blocks

Now that dirs can have multiple levels of indirection, it doesn't make sense to always use the plain (encoded, but not encrypted) size of the top block as the DirEntry.Size.  But it's probably too expensive to download all leaf blocks, and encode them, to find out the "correct" value during every folder update.
Instead, use a simple heuristic based on the number of indirect pointers that isn't great, but probably good enough.
Issue: KBFS-3305

Could you explain the heuristic? It seems it makes little difference between if the first pointer is direct vs indirect.

Hopefully with the bug fix you pointed out, and the existing explanation in the comment, the heuristic should be clear now.

Also, would it be better to go through all pointers in the root block and estimate based one each of them being direct vs indirect (still without fetching) instead of only looking at the first one?

I'm pretty sure that the tree should be balanced, because we add new levels at the top of the tree (and then down along the right side), rather than the bottom.  So all the pointers on the first level should have the same type.
Although, now that I write this out, the tree-making algorithm I describe is actually much worse for this heuristic, since when a new level is added, the number of indirect pointers coming out of the root will go from N to 2, and the reported size of the directory will shrink.  Hrmm.
I guess if the first pointer is indirect, I should not max it out at N*len(db.IPtrs), but at N*BlockSplitter.MaxPtrsPerBlock().  Basically, if there are two levels of indirect pointers, we can assume at lease one of those levels was completely full.  I'll change it and update the comment.

Thanks for the explanation. Although I'm still a bit confused. Even with the fix, it still seems the fact the first point is direct vs indirect makes little difference; they both give a size close to when we have first layer full. If we are making estimates based on if the first pointer is indirect, shouldn't we do e.g. MaxBlockSizeBytesDefault * len(db.IPtrs) * BlockSplitter.MaxPtrsPerBlock() when first pointer is indirect (with the assumption that second layer is full)?

Even with the fix, it still seems the fact the first point is direct vs indirect makes little difference; they both give a size close to when we have first layer full.

I don't think that's true.  If the first pointer is direct, and there are only two pointers total, then the total size is just MaxBlockSizeBytesDefault.  If the first pointer is indirect, then it's MaxBlockSizeBytesDefault*BlockSplitter.MaxPtrsPerBlock(), which is a lot more.

If we are making estimates based on if the first pointer is indirect, shouldn't we do e.g. MaxBlockSizeBytesDefault * len(db.IPtrs) * BlockSplitter.MaxPtrsPerBlock() when first pointer is indirect (with the assumption that second layer is full)?

We can't really say whether there are multiple full levels below this, we only know for sure that there is one full level.  For example, when the third level is added to a tree, the root block will have two indirect pointers. The first one points to an indirect block with a full set of pointers, but the second one points to a block with only one pointer.

I see; that makes sense. Thanks for the explanation!


log last series labelset when hitting OOO series labels

We have seen several occurences of out-of-order series added with label set during head compaction. However, the current error message makes it hard for us to debug further because only current series' labels are part of the error message.
This PR updates the error message to also include labels of the last series.

Thanks for the review. @machine424 Is it good to be merged now?


Replacement Cycling with split

Issue
Need to run Replacement Cycling and allow interactivity
Solution
Split the Replacement Cycling demo into its constituent parts. Allow monitoring with zmq.
Still needs
Scenario test
Supersedes
https://github.com/bitcoin-dev-project/warnet/pull/372

@mplsgrant curious how much has the scenario changed since I last looked?

@instagibbs The mechanics have stayed exactly the same. What's changed is splitting the steps apart so we can run them out of order.

could be nice to see if this "just works" with the new commander launcher


Subscriber error handler

Brief rundown:

Add a default ctor for the TinyMessengerHub, which uses an internal DefaultSubscriberErrorHandler that swallows any error in the subscriber code (same as previously)
Add a ctor for TinyMessengerHub that allows injection of an ISubscriberErrorHandler class, so any errors occurring in the subscriber code can be handled how ever we wish
Add a test to confirm behavior

All changes should be non-breaking.  Confirmed all existing tests are still green.

Any chance this PR can be reviewed and merged in? This exception swallowing has bit us a few times.

Done :)

Thanks, @grumpydev!

omg - yes! Thanks, @johnnysbug and @grumpydev

thanks @grumpydev.  Any chance of updating nuget?

It wasn't me that created the nuget, I'm not sure I even have access to it.


GdNavigationServer crash

Godot version
v3.5.beta2.official.7a4f9dfb1
System information
Mac OSX (Intel 2019)
Issue description
Crash when freeing NavMesh just after starting build.
Seems related to this issue: https://github.com/godotengine/godot/issues/46285
~/src/godot-navigation-bug
▶ godot
arguments
0: /Applications/Godot.app/Contents/MacOS/Godot
Current path: /Users/will/src/godot-navigation-bug
Godot Engine v3.5.beta2.official.7a4f9dfb1 - https://godotengine.org
OpenGL ES 2.0 Renderer: Intel(R) Iris(TM) Plus Graphics 655

Registered camera FaceTime HD Camera (Built-in) with id 1 position 0 at index 0
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
   at: get_global_transform (scene/3d/spatial.cpp:385)

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.5.beta2.official (7a4f9dfb15a6817135e753b286cd5b767119d08b)
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] 1   libsystem_platform.dylib            0x00007ff807efde2d _sigtramp + 29
[2] 2   ???                                 0x0000000000000000 0x0 + 0
[3] void process_array_thread<ThreadArrayProcessData<NavMap, RvoAgent**> >(void*)
[4] void process_array_thread<ThreadArrayProcessData<NavMap, RvoAgent**> >(void*)
[5] Object* ClassDB::creator<MobileVRInterface>()
[6] NavigationAgent::get_nav_path_index() const
[7] MutexImpl<std::__1::mutex>::try_lock() const
Adding Navigation
Exiting NavMesh
ERROR: Condition "!is_inside_tree()" is true. Returned: Transform()
   at: get_global_transform (scene/3d/spatial.cpp:385)
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
[8] MutexImpl<std::__1::mutex>::try_lock() const
[9] 9   libsystem_pthread.dylib             0x00007ff807ee84f4 _pthread_start + 125
[10] 10  libsystem_pthread.dylib             0x00007ff807ee400f thread_start + 15
-- END OF BACKTRACE --
================================================================
[1]    25792 abort      /Applications/Godot.app/Contents/MacOS/Godot

Steps to reproduce
Run this project
godot-navigation-bug.zip
Minimal reproduction project
No response

If you wait one second you still get a thread error:
Project with example:
godot-navigation-bug.zip
▶ godot
arguments
0: /Applications/Godot.app/Contents/MacOS/Godot
Current path: /Users/will/src/godot-navigation-bug
Godot Engine v3.5.beta2.official.7a4f9dfb1 - https://godotengine.org
OpenGL ES 2.0 Renderer: Intel(R) Iris(TM) Plus Graphics 655

Registered camera FaceTime HD Camera (Built-in) with id 1 position 0 at index 0
Adding Navigation
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Adding Navigation
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting @NavMesh@2
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting @NavMesh@3
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting NavMesh
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)
Adding Navigation
Exiting @NavMesh@4
WARNING: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
     at: ~Thread (core/os/thread.cpp:123)

If you don't queue_free() you get this error

Updated sample:
godot-navigation-bug.zip

cc @Scony

Confirmed on manjaro linux.
The issue is due to poor thread handling. I've already seen it in another corner case. I'll draft a fix in upcoming weeks.

Fixed by #59849.


Add contributes

Add contributes files to this repo

@all-contributors please add @peterdudfield  for code

@all-contributors please add @jacobbieker for code
@all-contributors please add @JackKelly  for code

@all-contributors please add @jacobbieker for code

@all-contributors please add @JackKelly for code

@all-contributors please add @JackKelly for code

@all-contributors please add @JackKelly for code

Thanks loads for adding us, @peterdudfield!
This little conversation between you and the bot made me smile!


how about adding event delegate

I've been using nodejs for not a short time. In some of my projects, i need events bubbled from inside object. Here is a simple demo:
const EventEmitter = require('events');

class A extends EventEmitter {
  constructor(options) {
    super(options);

    this._b = new B();
    this._b
      .on('ready', () => this.emit('ready'))
      .on('refresh', () => this.emit('refresh'))
      .on('error', err => this.emit('error', err));
  }
}

class B extends EventEmitter {
  constructor() {
    super();
  }

  init() {
    // do init stuff
    this.emit('ready');
  }

  refresh() {
    // do refresh
    this.emit('refresh');
  }
}

const a = new A();
a.on('error', err => {
  // handle error logic
});

I think the event binding code in constructor of A is ugly. Maybe we can use in a more elegant way. How about this:
const delegate = require('delegates');
delegate(a, '_b')
  .event('ready')
  .event('refresh')
  .event('error');

yes it's just adding a .event api. So if it makes sense, i am glad to submit a PR.

I think in your example above you could do:
this._b
  .on('ready', this.emit.bind('ready'))
  .on('refresh', this.emit.bind('refresh'))
  .on('error', this.emit.bind('error'))

which isn't too bad. I'd probably rather keep events out of here since it gets a bit more complicated, if people want to unbind some or all etc

alright, i've got the point.


CLI - convenience methods for building the app from the CLI directly.

One thing I have always liked about Titanium was that it has a CLI that lets you build iOS and android apps directly from the CLI. This is great as you are trying to ensure code works on both platforms. I would like to suggest that React implement this as well.

@mattapperson - check this out: https://github.com/bh5-js/rctapp
@amasad @frantic - is official support for this on the roadmap at all?

@brentvatne si, I actually know Christian the maker of that tool, and plan to contribute... But having it in core would be nice 😊

We will be happy to have it in core, but we don't have enough resources to build one, especially if we are not going to use it. Our internal packaging pipeline is pretty complex and heavily relies on BUCK.

If Facebook isn't actively supporting it I don't think it's a good idea to include it in this project. Build tools are also something that tend to be different across organizations e.g. Facebook uses buck, some people might want to use xctool, others may use shenzhen and fastlane.
The fact is this rctapp tool exists so the CLI use case is already addressed. It seems reasonable to link to it in the docs if it's a good tool.

@ide I agree mostly. I think the issue comes into play more when you become cross platform. Having a CLI tool to interface with for your pipeline gives one interface point vs iOS, Android and whatever else...

I think having a simple high level tool on top of xctool and gradle is
important for initial development experience. Companies and individuals who
know what they are doing can easily use their tool of choice.
On Thu, Jun 25, 2015 at 7:53 PM Matt Apperson<EMAIL_ADDRESS>wrote:

@ide https://github.com/ide I agree mostly. I think the issue comes
into play more when you become cross platform. Having a CLI tool to
interface with for your pipeline gives one interface point vs iOS, Android
and whatever else...
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/1699#issuecomment-115479702
.

@mattapperson @frantic OK. I didn't mean to be dismissive of a CLI tool if it sounded that way. My main concern is that when code is in this core project, often people have the expectation that FB is committed to maintaining it.

Closing due to inactivity


e2e flake: migrate_boot_member_to_self_hosted_cluster

failure: https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator/1719/consoleText
After the etcd-server is ready and is added as a  the cluster size goes up by one and then goes back to zero until the test times out:
self_hosted_test.go:130: failed to create 3 members etcd cluster: still failing after 12 retries
The first member is probably not being migrated correctly.

After digging into the operator logs, this is dup to #https://github.com/coreos/etcd-operator/issues/978.
Let's converge there.


Add grade coloring

i did a thing.

Something is wrong with the grade alignment, check that the width of the grades is always 85px.


Not really an issue

Nice plugins, thanks for sharing!
You should add an installation section to your README, and maybe a command to print the number of words in the current sentence on the vim command line regardless of the cursor position. The name of the command might be SentencerShow or something else..

Ok, cool that you like it!
Do you mean the command should count the words in the sentence under the cursor? Something similar to pressing this in normal mode:
vasg<C-g>


Use labels for WIP and MRG

Instead of prepending [WIP] or [MRG] to PR titles, we could create WIP and MRG labels that let the author indicate the current status of a PR. One benefit of this would be the ability to filter through WIP and MRG much more easily. In addition, titles get shorter and thus easier to read. WDYT?

no strong feeling. It's just my old habits. I also see by doing this the
status in the title of the email notification which I find quite handy

let the author indicate the current status of a PR

AFAIK only people with write permissions on the repo have control over labels, everyone can control their own titles.

You're right, this is something that GitHub could add.

Wow - https://github.blog/2019-02-14-introducing-draft-pull-requests/
Let's use that instead!

Unfortunately I just tried it, and only LGTM and AppVeyor ran, CircleCI and Travis did not. So we might have to wait for the CIs to adjust to this new system

... actually it might have just been very (spuriously) delayed. I'll try on my next relevant PR


Add -idirafter/usr/include to bindgen's clang invocation on GNU/Linux

A workaround/solution to #1389

I'm merging this :)


Velero deployment fails on openshift cluster

What steps did you take and what happened:
I wanted to install velero on openshift cluster is failing and deployment logs says "invalid character '(' after object key:value pair" .
I have the below command to install velero on openshift cluster
#1903 velero install --bucket mybucket-sep --provider gcp --secret-file gcp.credentials
What did you expect to happen:
Velero deployment to complete without any error.
The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)
https://gist.github.com/ashoks27/127d87883dcda872ab122f2caff6828a
Logs are attached above
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
I am trying to restore a backup from GKE cluster  , I have already successfully taken the
backup from GKE cluster using GCP as provider , now trying to restore it in the openshift environment.
Environment:
GKE to openshift

Velero version (use velero version):
Version: v1.0.0
Velero features (use velero client config get features):
Kubernetes version (use kubectl version):
Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Redhat 7.4

Few more logs.

Credential file details
[root@icprhel02 velero]# cat gcp.credentials
{
"type": "service_account",
"project_id": "ardent-bridge-XXXXX",
"private_key_id": "bad67b3849998d9b33dc07332112d8XXXXX",
"private_key": "-----BEGIN PRIVATE KEY-----\nMIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQD6ReezykWnjSEu\nX5+Q/lZA6pFrteF8FkFcYrtwBirWILp6AUb91R48q+Dz5s6YVoShzkBPZVh2PLbn\nwnlSqd3M6/1K2vsS1LDzIH5UZp5jc9/O2dfwLcTHCVPfFNOuxAGIw9eX8yfuhK4W\n6M9YLKuJqu2C6dG95VEgSQuleoaVw2Ub+iGyQ+dmCgGe8EOQavVF9ZQlQvmApGfF\nHgWH8ZYYqgeptw2JdDkNjWtTn4jrE2pr0h4yzGMhalC2uDD5wmnTUGKN5y7EFCPB\nSr4BBXP7MF2Hr2AsWesHi4PowK7dvVgYmaGZ37gpkaDOAEBWd2oTRxDqbN7YxKI6\njzPbseZ1AgMBAAECggEAD4djCn29vNkjKq0zaav6U/H/XsNM5SXoCCXhKEuIVhEh\no5yCLZGkcWfJyrXIHQgwl8NELBj8ou4pUYU4gWz5o/OC8SWCvXxLKXQbRTyOeIXH\nUzP4SSu8gWFpCJcSe7jSOTdLoImYG/LexBxNxz8S+rULd9tvEJ0StPyLTN58IifQ\n7BkORH57T1I9OIlsN41zsLVvToNc9fDDMNMat0sO/RxoWa/HyXkxjf9eocgGCZcH\noM5izy2JKnIwz/HFXY254WM6BaxCHKj0/QlsFRazLFb1xfEmcCNaEXLDvwf6JbY4\nDcz4eC0EVd3oHZKVzudQSmHrHln5g3LvaVbkAMeiGQKBgQD+BWopVsa3xcBj2efj\n9qdHllfPX01A/walCDC14tNS418fBp6nakdICCZ/sxzjZEFcsaazp89JXq6k3Btv\nE7QxJOpjmAHfBSY4MXqne1Zzi3NvEPVxLIfyncAWisA6Xi9s1i1MRmvq5wJdpJIR\nLYozV9b0PZjqQK0RXMulxSJuPQKBgQD8OQQGbLOw37+AZPh2HnZUHhq45NQUDgcj\nembr2ObzF8isdPu21waEMR+jFqPol6wiy7+xhTOLmCns6Lw0a0W8YWtI2XQ8yS5w\newG3Ck0FwO+ZAPK57RQDOPqCpJttg549LuqKWyjv/fiSJ9FTChz1PIjLoVPd7LuM\n935LNtpUmQKBgDZGi+dnTjBoBXKQVbbktdta6Uo6z7Pqic3rURUb8RFN2b40WOPm\nlnJyo183sx13B2w53SeX3HeNzn0VNptmN2Mkwxwil4vCeucY019DwDYR/sklc3wK\nCsYxJKDsZqRSCYoUvTsF9PsM/vlpN3iKJXRQ+XHYU3sB9Li3/h9eXrv1AoGARee3\nieBO3VLmTLuvcW139lBxr5UcgoJw0BB4vh1bxTxuTf4OVdq636CN2DHKNAj1mJ9H\n/fehFauS0yqeHxksNs35YjOC1+YajOpKy2R7fIDA53Mv0wA2b743EEZ3HZ9BGEwM\njVQ+wGVvo3KNvaor5HxmnamVCQk34hYmVspZMOECgYEA+a44PmMTVD55jBA52GoG\n/CfIS9RlpYSEb8R63C7OvFd37z405AN10Yy81w5qmb/0LMrm/c7rEIN1ZR1M3CPq\npvg9iQtUiGp9JlQPeq17lHUUvCNXuq2FSPD/Yjtgsb0nGH+GX11YGyDmJFe4epTU\noG1llP5mBGdG6vsBlKbaMo4=\n-----END PRIVATE KEY-----\n",
"client_email"<EMAIL_ADDRESS>"client_id": "10875561997838555XXXX",
"auth_uri": "https://accounts.google.com/o/oauth2/auth" (https://accounts.google.com/o/oauth2/auth') ,
"token_uri": "https://oauth2.googleapis.com/token" (https://oauth2.googleapis.com/token') ,
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs" (https://www.googleapis.com/oauth2/v1/certs') ,
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/velero%40ardent-bridge-228013.iam.gserviceaccount.com" (https://www.googleapis.com/robot/v1/metadata/x509/velero%40ardent-bridge-XXXX.iam.gserviceaccount.com')
}

velero get backup-location default -o yaml
apiVersion: velero.io/v1
kind: BackupStorageLocation
metadata:
creationTimestamp: 2019-09-25T13:52:57Z
generation: 1
labels:
component: velero
name: default
namespace: velero
resourceVersion: "4586110"
selfLink: /apis/velero.io/v1/namespaces/velero/backupstoragelocations/default
uid: c8001eab-df9b-11e9-b6f2-005056917705
spec:
config: {}
objectStorage:
bucket: mybucket-sep
prefix: ""
provider: gcp
status:
lastSyncedTime: null

Your credentials file looks like invalid JSON -- see for example:
"auth_uri": "https://accounts.google.com/o/oauth2/auth" (https://accounts.google.com/o/oauth2/auth') ,

Not sure why there's the parenthesized text at the end of that line. That occurrs on a couple other lines as well. How did you get that file?

Hi Steve , Thanks for the response..
I have copied this file from GKE cluster and got this command while running the below command. Somehow those ( have occured in the file in openshift cluster . It fixed now. Thanks for your quick update..
#gcloud iam service-accounts keys create credentials-velero
--iam-account $SERVICE_ACCOUNT_EMAIL


Why would -G "Visual Studio 16 2019" fail to find lib, but both -G "Visual Studio 14 2015" and -G "CodeBlocks - NMake Makefiles" succeed?

Was debugging why CMake-gui couldn't generate for Visual Studio 2019, but that it worked fine in CLion. So I drilled down into it, and was able to replicate (used same examples from my first post here https://github.com/microsoft/vcpkg/issues/17053).
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.9.3
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************

gui>rmdir /s /q cmake-build-debug && md cmake-build-debug && cd cmake-build-
debug

gui\cmake-build-debug>cmake .. -DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake -G "CodeBlocks - NMake Makefiles"
-- The CXX compiler identification is MSVC 19.28.29913.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.28.29910/bin/Hostx86/x86/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: cmake-build-debug

gui\cmake-build-debug>cmake --build .
[ 50%] Building CXX object CMakeFiles/pp.dir/src/main.cpp.obj
main.cpp
[100%] Linking CXX executable pp.exe
[100%] Built target pp

gui\cmake-build-debug>cd ..

gui>rmdir /s /q cmake-build-debug && md cmake-build-debug && cd cmake-build-
debug

gui\cmake-build-debug>cmake .. -DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake -G "Visual Studio 16 2019"
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
-- The CXX compiler identification is MSVC 19.28.29913.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.28.29910/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at vcpkg/scripts/buildsystems/vcpkg.cmake:861 (_find_package):
  Could not find a package configuration file provided by "FLTK" with any of
  the following names:

    FLTKConfig.cmake
    fltk-config.cmake

  Add the installation prefix of "FLTK" to CMAKE_PREFIX_PATH or set
  "FLTK_DIR" to a directory containing one of the above files.  If "FLTK"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:7 (find_package)

-- Configuring incomplete, errors occurred!
See also "cmake-build-debug/CMakeFiles/CMakeOutput.log"

CMakeOutput.log
PS: I am installing MSVC 2015 (CE) now in order to test with that
PPS: Is it something to do with not finding the PowerShell binary? (pwsh.exe) - I'm running Windows 10 Pro 20H2 19042.906 BTW.
EDIT: As promised, tried with MSVC 2015 (19.0.24210.0 in 'Developer Command Prompt for VS2015' with -G "Visual Studio 14 2015") and… it worked. No errors, no issues. Only difference to CodeBlocks variant is it placed the binary from --build in a Debug subdirectory. Executable worked perfectly.

@SamuelMarks, do you install fltk:x86-windows or fltk:x64-windows? you need pass  '-DVCPKG_TARGET_TRIPLET=x64-windows' if you installed the port with x64-windows. It built successfully for me.
E:\vcpkg\vcpkgtest\fltk\build>cmake.exe  -DCMAKE_TOOLCHAIN_FILE=E:/vcpkg/clean/vcpkg/scripts/buildsystems/vcpkg.cmake  -DVCPKG_TARGET_TRIPLET=x64-windows -DVCPKG_BUILD_TYPE=debug -G "Visual Studio 16 2019" ..
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
-- The CXX compiler identification is MSVC 19.28.29913.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: E:/vcpkg/vcpkgtest/fltk/build

E:\vcpkg\vcpkgtest\fltk\build>cmake --build .
Microsoft (R) Build Engine version 16.9.0+5e4b48a27 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Checking Build System
  Building Custom Rule E:/vcpkg/vcpkgtest/fltk/CMakeLists.txt
  main.cpp
  pp.vcxproj -> E:\vcpkg\vcpkgtest\fltk\build\Debug\pp.exe
  Building Custom Rule E:/vcpkg/vcpkgtest/fltk/CMakeLists.txt

E:\vcpkg\vcpkgtest\fltk\build>

@SamuelMarks CMake changed the default architecture for VS2019 (everything before VS2019: x86; VS2019: x64). This changes the triplet vcpkg chooses in the toolchain.

@SamuelMarks, does this still be a problem for you?

Please reopen this issue if it still be a problem for you.


Unable to parse Pandas exported csv file.

I have exported a csv file using pandas which is:
;company_url;company_name;industry;description;logo
0;https://example.com/employer/rural-health-and-education-service-trust/;Rural Health and Education Service Trust;NGO / INGO / Development Projects;"

Rural Health and Education Services Trust (RHEST) is a national NGO established in 1992, primarily working to prevent girl trafficking through the provision of education services and safety networks to at-risk girls throughout Nepal. RHEST has two smaller programs; women’s maternal health, and health related publishing.

Since 1997, RHEST has been supported by the INGO the American Himalayan Foundation (AHF). In addition to funds, AHF provides program and organizational guidance to RHEST and assists RHEST in its communications to donors and other international stakeholders.

Since 2011, AHF has received funds for RHEST programs from the Foundation for a Just Society (FJS), a US based philanthropic organization. FJS works to help develop capacity of women-led organizations working in the sphere of gender equity. Through an associated organization, the Foundation for a Just Society International (FJSI), FJS has offered RHEST funding for such capacity development, with an integral part of this development being the appointment of an Associate Executive Director to help RHEST grow to a point where it can independently manage large grants directly from donors such as FJSI.

";https://example.com/media/cache/ba/61/ba61b03e580f3c5ca433df13d20d3591.jpg

It contains one header row and one data row and the company description data is in html format, In pandas I easily can import into dataframe as
import pandas as pd

print(pd.read_csv('export/company.csv', sep=';'))

But I couldn't import with this library, I know the problem is with in description column which contains html content, which is wrap with double-quote and escape characters is also double-quote ". So Is there any way that It can achieve with this library ?
I tried following configuration
// Config 1
DataFrame::fromCSV($this->filePath, ['sep' => ';']);
// Config 2
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'escape' => '""']);
// Config 3
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'escape' => '"']);
// Config 4
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'quote' => '"']);
// Config 5
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'quote' => '"', 'escape' => '"']);
// Config 6
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'quote' => '"', 'escape' => '""']);
// Config 7
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'quote' => '""', 'escape' => '"']);
// Config 8
DataFrame::fromCSV($this->filePath, ['sep' => ';', 'quote' => '""', 'escape' => '""']);

But none of above worked, but same data can read in pandas with above code. Thanks help will appreciated.

Sorry But: This small class solve my problem. https://github.com/htmlburger/carbon-csv

The line breaks in the description column pose a challenge with the current CSV implementation (see: here). The CSV parser treats them like separate rows before str_get_csv has a chance to recognize it as a valid cell.
This is a very strong case for replacing the current implementation with something more robust involving SplFileObject.
Thank you for bringing this to my attention, and I'm glad you were able to find a solution!