can_be_sta_and_ap() regexp fails on Raspi3

Hi,
As reported here in few instances (issues #185 and #187 ), setting-up a passphrase-enabled AP with Raspberry Pi 3 fails if --no-virt is not set. Failure comes with an error message:
Failed to create interface mon.ap0: -95 (Operation not supported)
Indeed, in absence of --no-virt directive, create_ap script is trying to detect virtual interface support for particular wifi interface, and sets NO_VIRT flag accordingly.
This detection fails with rpi3 built-in interface, hence NO_VIRT is incorrect, and execution fails if --no-virt directive is not previously set.
Looking at this discussion about multiple SSID support  and create_ap code, it turns out that can_be_sta_and_ap() may not properly process relevant info on raspi3.
For reference, iw list (or iw phy phy0 info) on raspi3 gives relevant info as:
    valid interface combinations:
          * #{ managed } <= 1, #{ P2P-device } <= 1, #{ P2P-client, P2P-GO } <= 1,
            total <= 3, #channels <= 2
          * #{ managed } <= 1, #{ AP } <= 1, #{ P2P-client } <= 1, #{ P2P-device } <= 1,
            total <= 4, #channels <= 1

which according to the aforementioned article and AP<=1 should indeed return 1 from can_be_sta_and_ap() (NO_VIRT=1), as this wifi chip can not support virtual interface (value of AP section should be at least 2 to support virtual interfaces).
I'm not an expert in regexp, so I won't propose a fix myself, but one may want to look into that.
Now, there might be another logic bug somewhere, as in current state (with regexp issue), setting hotspot with no password works on raspi3, even omitting --no-virt option: no error like in passphrase situation.
It's surprising as that raspi3 chip does not support virtual interface as we saw.
Unless I'm missing something, virtual interface availability is probably independent of the AP security mechanism (passphrase or not).
While this second issue will be hidden if NO_VIRT is properly set with eventual regexp fix, there might be something to look at here too.
Interested in any feedback.

Here is a suggested fix for multiple SSID support detection in can_be_sta_and_ap().
Replace
can_be_sta_and_ap() {
    # iwconfig does not provide this information, assume false
    [[ $USE_IWCONFIG -eq 1 ]] && return 1
    get_adapter_info "$1" | grep -E '{.* managed.* AP.*}' > /dev/null 2>&1 && return 0
    get_adapter_info "$1" | grep -E '{.* AP.* managed.*}' > /dev/null 2>&1 && return 0
    return 1

by
can_be_sta_and_ap() {
    # iwconfig does not provide this information, assume false
    [[ $USE_IWCONFIG -eq 1 ]] && return 1
    get_adapter_info "$1"  | sed -r 's/.*\{.* AP.*\} *<= *([0-9]*).*/\1/g' | sed -r 's/([0-9]*).*/\1/g' | awk '$1 > 1' > /dev/null 2>&1 && return 0
    return 1

Hope this helps.

How would you test this fix? Can you please prepare a PR so we can test it on our own real quick?
I am able to test in on rpi3 with ALARM.

Done.
On raspi3 you should not need to explicitly spell-out --no-virt option anymore, as with the fix, create_ap should set it by itself.
So test without --no-virt in your create_ap invocation, and see if you can create an AP with password, and connect to it with another machine without errors.

I think it still does not work for me. I've just installed create_ap and patched line myself. This is the output i get:
[alarm@alarmpi AUR]$ sudo nano /usr/bin/create_ap
[alarm@alarmpi AUR]$ sudo create_ap wlan0 eth0 MyAccessPoint 12345678
Config dir: /tmp/create_ap.wlan0.conf.QyptAQM3
PID: 18679
Creating a virtual WiFi interface... ap0 created.
Sharing Internet using method: nat
hostapd command-line interface: hostapd_cli -p /tmp/create_ap.wlan0.conf.QyptAQM3/hostapd_ctrl
Configuration file: /tmp/create_ap.wlan0.conf.QyptAQM3/hostapd.conf
Failed to create interface mon.ap0: -95 (Operation not supported)
ap0: Could not connect to kernel driver
Using interface ap0 with hwaddr <removed> and ssid "MyAccessPoint"
ap0: interface state UNINITIALIZED->ENABLED
ap0: AP-ENABLED
^Cap0: interface state ENABLED->DISABLED

Doing cleanup.. ap0: AP-DISABLED
nl80211: deinit ifname=ap0 disabled_11b_rates=0
done
[alarm@alarmpi AUR]$ sudo create_ap wlan0 eth0 MyAccessPoint 12345678
Config dir: /tmp/create_ap.wlan0.conf.swAGw6nY
PID: 19457
Creating a virtual WiFi interface... command failed: Device or resource busy (-16)

ERROR: Maybe your WiFi adapter does not fully support virtual interfaces.
       Try again with --no-virt.

Doing cleanup.. done
[alarm@alarmpi AUR]$

from the command line, can you let me know the output of:
iw phy phy0 info | sed -r 's/.*\{.* AP.*\} *<= *([0-9]*).*/\1/g' | sed -r 's/([0-9]*).*/\1/g' | awk '$1 > 1'
Thanks.

It reports nothing.
[alarm@alarmpi AUR]$ iw phy phy0 info | sed -r 's/.*\{.* AP.*\} *<= *([0-9]*).*/\1/g' | sed -r 's/([0-9]*).*/\1/g' | awk '$1 > 1'
[alarm@alarmpi AUR]$ iw phy phy0 info
Wiphy phy0
	max # scan SSIDs: 10
	max scan IEs length: 2048 bytes
	max # sched scan SSIDs: 16
	max # match sets: 16
	max # scan plans: 1
	max scan plan interval: -1
	max scan plan iterations: 0
	Retry short limit: 7
	Retry long limit: 4
	Coverage class: 0 (up to 0m)
	Device supports T-DLS.
	Supported Ciphers:
		* WEP40 (00-0f-ac:1)
		* WEP104 (00-0f-ac:5)
		* TKIP (00-0f-ac:2)
		* CCMP (00-0f-ac:4)
		* CMAC (00-0f-ac:6)
	Available Antennas: TX 0 RX 0
	Supported interface modes:
		 * IBSS
		 * managed
		 * AP
		 * P2P-client
		 * P2P-GO
		 * P2P-device
	Band 1:
		Capabilities: 0x1020
			HT20
			Static SM Power Save
			RX HT20 SGI
			No RX STBC
			Max AMSDU length: 3839 bytes
			DSSS/CCK HT40
		Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
		Minimum RX AMPDU time spacing: 16 usec (0x07)
		HT TX/RX MCS rate indexes supported: 0-7
		Bitrates (non-HT):
			* 1.0 Mbps
			* 2.0 Mbps (short preamble supported)
			* 5.5 Mbps (short preamble supported)
			* 11.0 Mbps (short preamble supported)
			* 6.0 Mbps
			* 9.0 Mbps
			* 12.0 Mbps
			* 18.0 Mbps
			* 24.0 Mbps
			* 36.0 Mbps
			* 48.0 Mbps
			* 54.0 Mbps
		Frequencies:
			* 2412 MHz [1] (20.0 dBm)
			* 2417 MHz [2] (20.0 dBm)
			* 2422 MHz [3] (20.0 dBm)
			* 2427 MHz [4] (20.0 dBm)
			* 2432 MHz [5] (20.0 dBm)
			* 2437 MHz [6] (20.0 dBm)
			* 2442 MHz [7] (20.0 dBm)
			* 2447 MHz [8] (20.0 dBm)
			* 2452 MHz [9] (20.0 dBm)
			* 2457 MHz [10] (20.0 dBm)
			* 2462 MHz [11] (20.0 dBm)
			* 2467 MHz [12] (disabled)
			* 2472 MHz [13] (disabled)
			* 2484 MHz [14] (disabled)
	Supported commands:
		 * new_interface
		 * set_interface
		 * new_key
		 * start_ap
		 * join_ibss
		 * set_pmksa
		 * del_pmksa
		 * flush_pmksa
		 * remain_on_channel
		 * frame
		 * set_channel
		 * tdls_oper
		 * start_sched_scan
		 * start_p2p_device
		 * crit_protocol_start
		 * crit_protocol_stop
		 * connect
		 * disconnect
	Supported TX frame types:
		 * managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
	Supported RX frame types:
		 * managed: 0x40 0xd0
		 * P2P-client: 0x40 0xd0
		 * P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
		 * P2P-device: 0x40 0xd0
	software interface modes (can always be added):
	valid interface combinations:
		 * #{ managed } <= 1, #{ P2P-device } <= 1, #{ P2P-client, P2P-GO } <= 1,
		   total <= 3, #channels <= 2
		 * #{ managed } <= 1, #{ AP } <= 1, #{ P2P-client } <= 1, #{ P2P-device } <= 1,
		   total <= 4, #channels <= 1
	Device supports scan flush.

empty report is indeed what is expected in that case.
Issue is empty should be translated to false logic number before && return 0 (underlooked awk does not return logical value unlike grep)

properly chained the return code now.
There might probably be more elegant way to do it, but should work: let me know.

Actually, error in your case seems to come-up from nl80211 driver inside hostapd, probably not an issue with capability detection (my bad).
I assume you may be running hostapd v2.3.
You may want to check if you get better chance with a more recent version which fixed a bunch of stuff in that driver (latest 2.6 for instance).

Actually, looking at this, some crafted a setup that works (AP and client on Raspi3).
The caviar seems to make sure both use same channel as  iw phy phy0 info indeed directs to (some people seem to have same hostapd error when using different channels).
Unsure create_ap enforces same channel depending on capability at this stage, however there is a channel option -c which can be set at invocation: let's try by setting channel # to the same as connected client side, and see if error Failed to create interface mon.ap0: -95 (Operation not supported) vanishes...
I do not have Raspi3 handy to test at this point, but seems an interesting track...

Why did you close your PR?
I am running the latest hostapd software as I am on archlinux. I never use outdated software :P

I closed the PR because I think it does not address the issue the proper way. At this time I do not think it is a matter of improper detection of AP & Client capability.
Indeed rpi3 does support simultaneous AP & Client (and some people operated it work without create_ap), so no reason for preventing it (which my PR did).
We now need to find the proper reason why create_ap may not configure hostapd properly: one clue might be the channel limitation.
Any chance you can test calling create_ap -c # wlan0 wlan0 MyAccessPoint MyPassPhrase where # is the channel number on which Raspi is connected as a client to other AP?
Does hostapd still reports Failed to create interface mon.ap0: -95 (Operation not supported) ?

My raspi is currently not connected to any AP, but I've tried the command anyways:
[alarm@alarmpi hyperion-rpi]$ sudo create_ap -c 1 wlan0 wlan0 MyAccessPoint MyPassPhrase
[sudo] password for alarm:
Config dir: /tmp/create_ap.wlan0.conf.9pAVIkvy
PID: 21868
Creating a virtual WiFi interface... ap0 created.
Sharing Internet using method: nat
hostapd command-line interface: hostapd_cli -p /tmp/create_ap.wlan0.conf.9pAVIkvy/hostapd_ctrl
Configuration file: /tmp/create_ap.wlan0.conf.9pAVIkvy/hostapd.conf
Failed to create interface mon.ap0: -95 (Operation not supported)
ap0: Could not connect to kernel driver
Using interface ap0 with hwaddr<removed> and ssid "MyAccessPoint"
ap0: interface state UNINITIALIZED->ENABLED
ap0: AP-ENABLED

I'm getting out of suggestions for now...
You may want to try the DIY method, and confirm whether it works in your case: if it does, then it will confirm something should be worked-out in create_ap, and one could dig into that, comparing the two methods.
If it does not, the issue may lay somewhere else (wifi driver, firmware, etc).

Probably something else is going on with rpi3. My Intel adapter has the following interface combinations and it can have an AP with passphrase while I'm connected to another AP.
        valid interface combinations:
                 * #{ managed } <= 1, #{ AP } <= 1,
                   total <= 2, #channels <= 1, STA/AP BI must match
                 * #{ managed } <= 2,
                   total <= 2, #channels <= 1

Thanks @oblique for your feedback on this.
BTW is create_ap checking (and enforcing) the channel limitation: in your case do you take special care for using same channel for AP & client, or is create_ap doing it by itself?
Back to rpi3, looking at this method, do you see any meaningful setting that may be different from what create_ap is doing (particularly as far as hostapd is concerned)?

Yes, the method of the link is the same. I need to get a new microsd to try it on my PI.
I dig a bit in the kernel and it looks like the cfg80211_check_combinations function is the one who determines if the virtual interface can start the AP.
Back to the PI, can you try the Ruby implementation if it works?
git clone https://github.com/oblique/create_ap
cd create_ap
git checkout ruby
bundle install --path vendor/bundle
vim create_ap.yml # change the interface
sudo ruby -Ilib ./bin/create_ap

PS: Ruby implementation is not finished yet. I may change many things.

Can't look at it currently as I do not have rpi3 with me.
Also noticed wpa_driver_nl80211_status function in driver_nl80211.c from hostapd checking drv->has_capability
BTW that driver_nl80211.c evolved quite a bit across version 2.3 and 2.6 of hostpad.

I got new sdcard and found what is wrong with RPi3. The combinations are correct and adapter supports virtual interfaces.
The problem is in the Broadcom drivers, this is what I found:

Driver can not delete a virtual interface with type AP. This is a problem because create_ap always try to create a new virtual interface and delete it on exit. If someone want virtual interface, then he/she must do the following workaround:

iw dev wlan0 interface add ap0 type __ap
create_ap --no-virt ap0 wlan0 MyAP

With the above command you create AP on channel 1. If wlan0 is connected to another channel then you need to add -c 6 (if wlan0 is connected to channel 6), otherwise clients will not have internet and RPi3 will crash at some point.
When you specify the same channel then everything works expect if you want to stop the AP. As soon as hostapd gets killed by create_ap, RPi3 crashes.

So, as a conclusion the best solution is to never use virtual interface with RPi3. If a user really wants virtual interface with RPi3 he/she must use the above commands and keep in mind that RPi3 will misbehave.

I'm not sure how create_ap should handle this. I'm thinking to blacklist Broadcom on creating virtual interface.
What are your suggestions?

Thanks a lot for this in-depth analysis and workaround suggestions !
Hopefully there might be a driver fix at some point: do you have a way to report this issue to BCM?
As for create_ap, can you blacklist based on driver version and issue a warning/error message referring to this thread for users reference?
Would that change be applied to shell script, or only to ruby one?
Thanks again for your outstanding support.

I can do the change on shell script as well, since I do it with only 2-3 lines and yes I will print a warning with a link to this issue.
We can report this to the author of the driver, but first I prefer to get the crash dump of the kernel panic just to make sure that it crashes within the driver.

Does the fix mean that --no-virt is automatically applied now? Thanks for looking into the issue!
Have you also checked that if an usb adapter is used, you can still use virtual interfaces on a raspi?
If that all works, you should consider to tag (and sign) a new release ;)

New release is ready. Yes you can use another adapter, but it looks like I need to do some iptables changes because both adapters get internet and something goes wrong with NATing.

Ok new release again that fix the NATing issue. Now you just plug an adapter and it will work.

And  yes  --no-virt is applied automatically now.

Sorry, forgot to delete the new iptables rule on cleanup. New release again.

Last thing, is create_ap going to handle the channel limitations (i.e. creating the AP on same wifi channel if already client and capabilities show such limitations), of does user need to take care of that?

In ruby implementation will handle it. In Bash implementation it can only use only one channel.

@oblique

As soon as hostapd gets killed by create_ap, RPi3 crashes.

Why is that? Is there another way to kill it more softly?

No, it's a bug in the driver. It needs to be fixed there.

noted this brcmfmac: Change stop_ap sequence: don't have pi3 with me to test if referenced kernels with updated driver "naturally" fixes this issue, and does not need the automatic --novirt anymore.

"ERROR: Your adapter can not be a station (i.e. be connected) and an AP at the same time" , how can solve it, thansks.

@macmpi I got the new driver running on my rpi3 how should I test it?

pi@raspberrypi:~/create_ap $ sudo ruby -Ilib ./bin/create_ap
06:34:16.753: Using 802.11n
06:34:16.753: Using channel 9
06:34:16.913: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:34:16.930: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:34:16.937: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Configured channel (9) not found from the channel list of current mode (1) IEEE 802.11g
06:34:16.938: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Hardware does not support configured channel
06:34:16.939: hostapd-phy0: Could not select hw_mode and channel. (-3)
06:34:16.939: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:34:16.939: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:16.940: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:34:16.940: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:34:16.941: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:16.941: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:34:16.941: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:34:18.900: WARN: Daemon 'hostapd-phy0' exited. Try to start it again.
06:34:18.922: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:34:18.996: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:34:19.003: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Configured channel (9) not found from the channel list of current mode (1) IEEE 802.11g
06:34:19.006: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Hardware does not support configured channel
06:34:19.008: hostapd-phy0: Could not select hw_mode and channel. (-3)
06:34:19.008: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:34:19.008: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:19.008: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:34:19.009: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:34:19.010: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:19.011: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:34:19.011: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:34:20.910: WARN: Daemon 'hostapd-phy0' exited. Try to start it again.
06:34:20.932: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:34:21.474: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:34:21.482: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Configured channel (9) not found from the channel list of current mode (1) IEEE 802.11g
06:34:21.485: hostapd-phy0: ap-wlan0-1: IEEE 802.11 Hardware does not support configured channel
06:34:21.486: hostapd-phy0: Could not select hw_mode and channel. (-3)
06:34:21.487: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:34:21.487: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:21.488: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:34:21.488: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:34:21.489: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:34:21.489: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:34:21.489: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:34:22.921: ERROR: Daemon 'hostapd-phy0' exited too may times too quickly. Stop retrying.

Nope didn't work either
pi@raspberrypi:~/create_ap $ sudo ruby -Ilib ./bin/create_ap
06:42:31.010: Using 802.11n
06:42:31.010: Using channel 6
06:42:31.143: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:42:31.154: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:42:31.162: hostapd-phy0: Driver does not support configured HT capability [HT40*]
06:42:31.162: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:42:31.163: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:31.163: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:42:31.163: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:42:31.163: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:31.163: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:42:31.163: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:42:33.162: WARN: Daemon 'hostapd-phy0' exited. Try to start it again.
06:42:33.185: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:42:33.194: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:42:33.201: hostapd-phy0: Driver does not support configured HT capability [HT40*]
06:42:33.202: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:42:33.203: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:33.204: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:42:33.204: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:42:33.205: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:33.205: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:42:33.205: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:42:43.311: WARN: Daemon 'hostapd-phy0' exited. Try to start it again.
06:42:43.334: hostapd-phy0: Configuration file: /run/create_ap/hostapd_phy0.conf
06:42:43.343: hostapd-phy0: Failed to create interface mon.ap-wlan0-1: -95 (Operation not supported)
06:42:43.352: hostapd-phy0: Driver does not support configured HT capability [HT40*]
06:42:43.352: hostapd-phy0: ap-wlan0-1: interface state UNINITIALIZED->DISABLED
06:42:43.352: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:43.353: hostapd-phy0: ap-wlan0-1: Unable to setup interface.
06:42:43.354: hostapd-phy0: ap-wlan0-1: interface state DISABLED->DISABLED
06:42:43.354: hostapd-phy0: ap-wlan0-1: AP-DISABLED
06:42:43.355: hostapd-phy0: hostapd_free_hapd_data: Interface ap-wlan0-1 wasn't started
06:42:43.355: hostapd-phy0: nl80211: deinit ifname=ap-wlan0-1 disabled_11b_rates=0
06:42:45.322: ERROR: Daemon 'hostapd-phy0' exited too may times too quickly. Stop retrying.

i can not change the password
so what's the problem?

Actually, looking at this, some crafted a setup that works (AP and client on Raspi3).

I tested the RaspberryPi forums script/configuration and I confirm that it works flawlessly; I am using the same hardware but on a different board, kernel 5.8.16. Always make sure that your FORWARD configuration is correct and you should be able to reproduce the successful wifi repeater setup.


Publish as part of the CDK?

Would you be interested in submitting a PR to publish this as part of the AWS CDK itself?

@eladb Yes I am interested. Is it enough to rename the packages (eg @aws-cdk/pull-request-check) and adapt them to your build / test tools? Or do I have to adapt something else?

Other than needing to manually tweak the website bucket ACL and Bucket policy to I'm using this successfully in my pipeline. Adding this to CDK would be fantastic!


Feature: Copy to clipboard

Would be cool to copy them to your clipboard instead of having it in your menubar

I forget where I left off with this one, but I believe it currently does copy the selected emoji to you clipboard; the button next to the search field does that. Probably should make this button more clear in what it's functionality is.


TAJO-1782: Check ON_ERROR_STOP flag in TSQL when error is occured

Since the bug tsql suicide itself by any error, check the ON_ERROR_STOP. If it is TRUE, TSQL quit itself with exitcode returned.

Looks good to me.
@hyunsik, would you mind reviewing this patch? It looks to be related to your recent patches.

The patch looks good to me. If possible, could you add some unit tests to guarantee the bug fix?


Wait Handle: Authorization Failed

Hi everyone,
I'm struggling to setup OpenShift on OpenStack. I did not find any relevant other issue - Sorry if I just used the wrong search terms.
My Issue: During the heat deployment, an error is raised during creation of hosts (I assume bastion is the first host to be created).
heat event for resource "bastion_host":
AuthorizationFailure: resources.bastion_host.resources.wait_handle: Authorization failed.

What do I do wrong?
Any help or hints is greatly appreciated.
BR, Timo

@TimoL

which openstack version?
do you have a suitable token timeout?

@ioggstream

OpenStack Newton Release
token timeout should be default (according to the admin)

It also doesn't look like a timeout issue, since it always happens at exactly the same step during the deployment.

@TimoL - ran in to this as well, heat_stack_owner was not configured with the correct role and the role for the project didn't exist.
We checked back through the heat install: https://docs.openstack.org/heat/pike/install/ to make sure everything existed.

@TimoL ensure that the configuration is synced between all controllers too.

@greeninja and @ioggstream: Thanks for your help, I'll check with our OpenStack admins.

short update:
due to overlapping vacations we did not make any progress.
We're about to start testing again.

Hint: create a new stack with a single node and a wait handle and try to debug that checking controllers logs.
Are you using the curl_cli attribute to get the address to call?

Hi @ioggstream,
Thank a good idea, I'll try to create a minimal heat template replicating the the issue.
This way our admin can reproduce the issue far better (we're not even in the same country...)

closing old issue


Under Shield section no hull armor ?

We got shield but what about the hull armor ? ( it's do for Hornet ) But not for Karthu-Al ?

Not all ships have armour
Hornet, Aurora, and 300 sites only from memory, and the armour is locked to the ships too.
Will have to wait on CIG for that one
Peter Dolkens

On 26 Mar 2016, at 22:14, Vaalaa<EMAIL_ADDRESS>wrote:
We got shield but what about the hull armor ? ( it's do for Hornet ) But not for Karthu-Al ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

ok


rebuild if a compiler option reads more options from a file and that file changes

Hi. I'm not sure if I'm raising this issue in the right place. I'm using CMake with ninja, and I just experimented with putting my big list of compiler warning flags in a file, and do something along the lines of the following in CMake:
# "option A" (what I tried to do)
target_compile_options(my_target PRIVATE "@${path_to_flags_file}")

# "option B" (what already works as I expect)
target_compile_options(my_target PRIVATE -Wlorem -Wipsum -Wdolor -Wsit -Wamet -Wet-cetera)

the @file compiler option is supported on gcc (and clang by extension), and also MSVC. Clang also has a --config option. This detail isn't too important since compilers have different flags and flag formats. I just wanted to give some information about the feature I'm experimenting with.
The behaviour I expected / wished-for was that if I edit that file in "option A" and then do cmake --build, my_target should be completely rebuilt- just like how everything is rebuilt if I modify the flags in CMake in "option B".
I did try using CMAKE_CONFIGURE_DEPENDS to make CMake reconfigure if the flags file changes, and that worked, but it would only reconfigure, and the build would just say that nothing needed to be rebuilt.

Why did I try doing this? I thought it would be interesting to try extracting parts of my project configuration from the CMake files in a way that would make it easier and have less duplicate code if I were ever to try using something other than CMake (ex. meson or build2). Will I do that? probably not. It was just an exercise. Sorry if this is a duplicate issue ticket. I did a very brief search and didn't find anything like this. Let me know if this is better raised elsewhere.

Hm ... tricky one. Maybe GCC should add the flags file in its deps output?

One possible option would be e.g. in Meson, add those flags to a file and then use cflags_array = fs.read('path/to/flags/file').split(). Then pass those flags back into the target.
In cmake this would be e.g. file(READ CFLAGS_STRING path/to/flags/file).
Not sure how you would get cmake to reconfigure if that file input changes... it happens automatically for Meson.
...
Obviously if GCC handled that in the depfile that would be very interesting and useful.

This should be solvable by marking the flags file that you are using as one of the dependencies for each of your compiler outputs. If that was done then ninja would recognize that a change to the flags file requires things be recompiled.
However, if you're using cmake / meson, I don't believe either of those tools are able to let you tell the ninja file about this as a dependency in the way you would need to.
Most likely you'll need a bug report with cmake and/or meson

It would be easy enough to add, I guess.

@eli-schwartz do you mean to add to ninja? Or to CMake and meson?
@jonesmz I did some digging and found a CMake source-file property called OBJECT_DEPENDS. I did some experimenting and got this working when using Ninja as the CMake generator like so:
# wrap this in a function taking `target` as an argument.
get_target_property(sources ${target} SOURCES)
set_property(SOURCE ${sources}
  # DIRECTORY "${PROJECT_SOURCE_DIR}" "${PROJECT_BINARY_DIR}"
  TARGET_DIRECTORY ${target}
  APPEND PROPERTY OBJECT_DEPENDS "${PROJECT_SOURCE_DIR}/cmake/my_project/gnu_warning_flags.txt"
)

However, the docs say (italics added):

Specifies a semicolon-separated list of full-paths to files on which any object files compiled from this source file depend. On Makefile Generators and the Ninja generator an object file will be recompiled if any of the named files is newer than it. Visual Studio Generators and the Xcode generator cannot implement such compilation dependencies.

So it's close to a solution I'd like, but not 100% there since it doesn't work for all generators :(

Well, I can certainly understand where you're coming from on wanting to see all generators with cmake with the same behavior. At my work I constantly run into this same kind of annoyance.
But would you consider this issue resolved with regards to ninja? It appears that, at least for ninja itself, you found a solution, even though that solution doesn't work properly with, e.g., msbuild.
If so, consider closing this issue to indicate.

yes, I'm okay to close this now. I'll consider opening a discussion with the CMake team to see if there are ways to achieve this for more generators other than just Makefiles and Ninja. Thanks everyone for your time and brainpower :)

Note: This GitHub issue is mentioned in this Stack Overflow Q&A page: How can I add command-line options file to CMake compiler flags?


fix: index error when first message is AIMessage in _parse_chat_history

PR Description
Fixes https://github.com/langchain-ai/langchain-google/issues/392
Type
🐛 Bug Fix

thanks for your contribution! I believe it was fixed here: https://github.com/langchain-ai/langchain-google/pull/496 (in a slightly different manner).
Do you think it solved the problem?


Add parameter ignoreComments to MethodLengthChecker

This PR is for https://github.com/scalastyle/scalastyle/issues/247 and https://github.com/scalastyle/scalastyle/issues/166
Add a parameter ignoreComments to MethodLengthCheker
If this flag is set to true, MethodLengthChecker won't be count comment line.

This PR won't change default behavior of MethodLengthChecke.
ignoreComments is optional and, by default, it is set to false.

Codecov Report

Merging #248 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #248     +/-   ##
=========================================
+ Coverage    87.5%   87.71%   +0.2%
=========================================
  Files          58       58
  Lines        1305     1327     +22
  Branches      118      128     +10
=========================================
+ Hits         1142     1164     +22
  Misses        163      163

Impacted Files
Coverage Δ

...g/scalastyle/scalariform/MethodLengthChecker.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9a03f...14e04fd. Read the comment docs.

Thank you for reviewing. fixed :)

Great. Thanks!


chore: distinguish between device services

We have a DeviceService defined in both @energyweb/origin-backend and @energyweb/origin-device-registry-irec-local-api-client
Getting DeviceService from NestJS's moduleRef would sometimes returns the incorrect DeviceService due to a naming collision.
Solution:

Distinguish the two existing DeviceService using interfaces and symbols

This has been fixed by #1987


Add macOS setup instructions

Just adding a few extra tips for setup on macOS. Probably not complete still, it's just what I needed to do for my particular machine, up to you if you'd like to merge this!

Thanks for the heads-up. I think it would be better to update requirements.txt to reflect the recently added dependencies.


[OTHER] change label names

What would you like to share?
The current toggle label names don’t really express what they are toggling between. To me, global doesn’t convey that I’m searching all of GitHub. I wonder if instead of organisation / global it would be clearer if it stood EddieHub / GitHub. What do you think?

Additional information
No response

Yep, good idea!

Hello @emmalearnscode , I would like to work on this issue, If you can Assign me ?

Hello @emmalearnscode, I have changed the labels and made a pull request, If you find it correct please merge it the main branch


Receive lelantus

Please create lelantus flow for Receive https://app.zeplin.io/project/5ba9be48f029d520c456f395/dashboard?seid=5ee374e914cfd8b6649afa9a

Permanent token https://zpl.io/2pGDrRl

One-time use token https://zpl.io/aMJMkER

All hide view https://zpl.io/ag4Zq1O

Permanent/ One-time use (general) selection https://zpl.io/a8oOkqd

Receive from (advanced) selection https://zpl.io/29xBkdw

Show token https://zpl.io/2pGDrqN

Show QR code https://zpl.io/bAJzk3e

UPD: @DenisDemyanko please follow this instruction

Permanent token - General and receive from view https://zpl.io/2pGDrRl

One-time use token - General (no receive from) view https://zpl.io/aMJMkER

Hidden view https://zpl.io/ag4Zq1O

Show token https://zpl.io/2pGDrqN

Share QR https://zpl.io/bAJzk3e

No need "prefer to receive unlinked funds"

invalid


Better documentation of (CARD4L) ARD processes #228

Fixes for #228:

ard_normalized_radar_backscatter does not mention the bands that are added by default, and their names
ard_surface_reflectance : CARD4L specifies metadata bands to be added, but the process doesn't mention any of this
Minor clarifications and improvements to wording

ToDo: Add options parameter to new processes that back-ends can extend it based on methods. Will likely also add implementation notes...

I've added the options parameters for Optical SR and also started an "implementation guide" for back-ends, which we can fill with details about implementing processes in the next time. @lforesta @jdries

Merged as discussed in the dev telco. We can continue working on improvements in additional PRs, but it seems most additional changes will likely need to be done in the specific process definitions by the back-ends.


Miscellaneous edits

@vanandrew sorry for the unsolicited PR. I was reading through the repo and thought some stylistic changes would make it easier to understand for potential reviewers.
Changes proposed:

Run isort and black on the Python files.
Add omni to the requirements in pyproject.toml. I don't know if there's a specific version you used though.

I also sorted the requirements to make them easier to read.

Add badge for the preprint to the README.
Add text on the scope of the repo to the README. I think this needs to be further expanded.
Remove * imports in medic_analysis.common.__init__. I believe I've fixed any imports that rely on direct imports from medic_analysis.common.
Remove unused imports in Python scripts.
Start adding docstrings to modules and (eventually) functions.

Hey @tsalo. Thanks for doing this!
I'll have to go back and take a look at this codebase again to refresh myself before reviewing your PR, but I'll try to fit in some time to do so.

I created a PR for your PR here: https://github.com/tsalo/medic_analysis/pull/1
It mainly removes a few unnecessary files and adds some additional docs.

I can go ahead and merge this in if there aren't anymore edits.

Thanks! I'll open a separate PR if I see anything else.


Feature for multiple edges

How to use multiple edges. This requires a syntax change

Closed by #88.


Implement read-only transaction manager modes for R3.0 migration

This involves:

Altering both transaction managers to check for a read-only mode at
the start of standard write actions (e.g. delete, put).
Altering both raw layers (entity manager, ofy) to throw exceptions on
write actions as well
Implementing bypass routes for reading / setting / removing the schedule itself
so that we don't get "stuck"

This change is

Sorry if you were in the middle of reviewing it -- I added methods here to bypass the read-only nature, for use only in replay.


WIP: 🌱 Use CAPI's ClusterCacheTracker

This PR intends to use CAPI's ClusterCacheTracker https://github.com/kubernetes-sigs/cluster-api/pull/8744. However, since CAPM3 didn't use CAPI's remote NewClusterClient previously, this has to be done in two steps. Once this PR merges we can remove CAPM3's infra remote code and use CAPI's ClusterCacheTracker consistently.

/test metal3-ubuntu-e2e-integration-test-main  metal3-centos-e2e-integration-test-main

/test metal3-centos-e2e-integration-test-main


how can I contribute to add support for new LEDs? [not a programmer ;)]

Hi!
I've just bought some 16x16 BLE-controlled LED curtain that is managed by idealLED app. unfortunately, it's not recognized by the integration - it asks for device's MAC address, but when I enter this, and LEDs blink to confirm pairing - nothing else happens nor works. LEDs are not responding to on/off, colour or effect change etc.
I am not a programmer but I can follow directions [mostly ;)] so is there any way I could provide some logs or other data to make my curtains compatible with your integration, or it is too complex for a layman like myself?

It's pretty complex I'm afraid.  Often manufacturers will change the Bluetooth protocol from model to model.  Sometimes they share components, like On & Off sometimes they change everything.
The only real option is to decode it command by command as an entirely new protocol and that takes a while.
If you're interested in learning how there are a lot of resources on the web, but I highly recommend getting an nRF52840 dongle and installing the Sniffer software on it.  This will let you use Wireshark to help decode the bytes that are being sent by your phone to the lights.
It's quite an undertaking I'm afraid.

fully understood, thanks!


Push recipe that collapses using server and client side collapsing

Push can collapse messages using tags. We should document how they behave.

Client side collapsing is here: https://serviceworke.rs/push-replace.html.


Use a single command to upgrade nodes

Hi 👋
I propose to switch to a single playbook when upgrading control planes and workers.
Why?
This will allow you to choose how many nodes you want to upgrade without launching the ansible-playbook command multiple times. You will only need to adjust the serial parameter, in case.
For example, now if I want to upgrade 3 nodes node-a, node-b, and node-c I need to do the following (assuming that I don't want the 3 nodes to be offline at the same time):
ansible-playbook 56.upgrade-worker-nodes.yml -l node-a
ansible-playbook 56.upgrade-worker-nodes.yml -l node-b
ansible-playbook 56.upgrade-worker-nodes.yml -l node-c

With the proposed setup I would do this:
ansible-playbook 56.upgrade-worker-nodes.yml -l node-a,node-b,node-c

and the playbook would execute the tasks on the hosts, one by one, without the need for my interactions.

@ralgozino you're right, I've changed the PR title to be clearer 😄
As it is, the serial is hard coded, but can be turned into a variable and a default can be set, like this:
- name: playbook-name
  hosts: all
  serial: "{{ serial_number | default(1) }}"

and then at runtime, you can specify how many hosts you want to affect at the same time:
ansible-playbook 56.upgrade-worker-nodes.yml -e serial_number=3

What do you think?
PS: the upgrade process won't be affected, because the old command still works in the same way.

I think that setting the serial value as a variable and having it default to one is better than hardcoding it.
I'm not sure we will need to change it but, if it is as simple as that, having the possibility to upgrade more than one node in parallel could come handy in the future.
Thank you for checking the furyctl side, it is good to know that we don't need to change anything over there :)
@nutellinoit, what are your thoughts on the serial value variable?
I'm personally OK with both situations, but I'm more inclined on having the option to change it easily in the future if it is a simple change.


Fix visualization python tutorial

Signed-off-by: ahcorde<EMAIL_ADDRESS>🦟 Bug fix
Summary
Python tutorial is broken https://ignitionrobotics.org/api/gazebo/6.7/python_interfaces.html
Test it
Build doc and check this file
build/doxygen/html/python_interfaces.html

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1


NHSR Vision

The vision was originally written from a workshop in 2021 but was very focussed on research, statistics and refers to clinicians rather than analysts and data scientists. It might be that the vision requires rewriting completely to include other languages like Python, tools like Git/GitHub and relationships to other communities like Government Data Science Campus and NHS.pycom.

This is probably better in NHS-R Way


Add kernel module xt_statistic

When a k3s-agent is installed to the recent image and a hazelcast pod is deployed to the iot-2050-node, ip-tables can not be modified by k3s-agent since XT_STATISTIC Kernel module is missing.
This behavior has only been observed jet in the described setup and can be avoided by deleting and recreating the hazelcast pod.

Thanks for change - and sorry for the late reaction. Looks good - except for the from/signed-off-by line in your commit (real email address, please).

Sorry back for my late reply. Should be fixed now @jan-kiszka

Hi @LoeFe ,
Sorry for the late reply. Everything looks good, but could you please improve one thing? Wrap the commit message body to 72 characters or less.
Thanks.


Supports timezone setting in luxonLocalizer

Clear and concise description of the problem
We use Luxon in our React app, and it'd be nice to use the luxonLocalizer as our Localizer. However, given that user can customize their timezone, and each Calendar may have its own timezone, we cannot simply set the global timezone on Luxon to a given timezone like in the example: https://github.com/jquense/react-big-calendar/blob/master/stories/demos/exampleCode/luxon.js
Suggested solution
If LuxonLocalizer accepts {timezone} as a config (similar to the firstDayOfWeek config), it'll allow us to use the luxon localizer instead of writing our own.
Alternative
We'd have to write our own localizer and repeat much of the logic in LuxonLocalizer
Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[ ] I'm willing to open a PR

You can already do timezones with the Luxon Localizer

@cutterbl: The luxonLocalizer doesn't support custom timezone per localizer. That's what I'm requesting here.
In the example code, you'd see that the timezone is set globally for Luxon, but that's not enough for us. We'd like it to be customized per localizer
https://github.com/jquense/react-big-calendar/blob/master/stories/demos/exampleCode/luxon.js#L33

"per localizer"? I'm afraid I do not follow. There is only a single localizer instance per calendar instance. Are you putting more than on Calendar instance on a page?

Yes, by "per localizer" I mean per Calendar. We can have more than one calendar instance on a page, and each may have its own timezone.

Now, I doubt people will have crazy settings with different timezone per calendar like that, but it's possible. At least, the calendar may have different timezone from the rest of the website. We don't want to set the global Luxon timezone to the calendar timezone.

I'm close to replicate the whole localizer on our own repo in order to support timezone lol. LMK if you're interested, I can give it a try to add a timezone params for LuxonLocalizer.

@cutterbl LMK if you'd like it & I can give it a try to add a timezone params for LuxonLocalizer.


[Bug]: Alexa can't connect or add bridge after updating to 2.3.0 (server not commissioned)

What happened?
This could affect more than just Alexa because what I'm seeing in the logs on 2.3.0 is the following:
[Matterbridge]: The commissioning server on port 5540 for Matterbridge is not commissioned. Pair it scanning the QR code:
When reverting to any prior version (using Docker), it shows already commissioned when starting up and Alexa connects instantly
[Matterbridge]: The commissioning server on port 5540 for Matterbridge is already commissioned. Waiting for controllers to connect ...
I've tried deleting the bridge and all devices from Alexa, but when I go to add it in the Alexa app, it recognizes the QR code and starts the process of connecting, but it never completes and eventually times out after ~5 minutes.
Your configuration
{
  "devices": {
    "vendorId": 0,
    "vendorName": "CK-Matter-Bridge"
  },
  "homeAssistant": {
    "url": "http://<IP_ADDRESS>:8123",
    "accessToken": "xxxx",
    "matcher": {
      "includeDomains": [],
      "includePatterns": [
        "cover.garage_door",
        "light.all_lights",
        "light.backyard_lights",
        "light.bedroom_light",
        "light.dining_room_lights_2",
        "light.hall_light",
        "light.kitchen_light",
        "light.living_room_lights_2",
        "light.living_room_ceiling_lights",
        "light.office_lights",
        "lock.front_door_lock",
        "script.all_lights_off",
        "script.goodnight",
        "script.toggle_front_door_lock"
      ],
      "excludeDomains": [],
      "excludePatterns": []
    }
  }
}

Relevant log output
WebSocket - Connecting to WebSocket: ws://<IP_ADDRESS>:8283
WebSocket - Connected to WebSocket: ws://<IP_ADDRESS>:8283
info - [00:38:20.781] [Matterbridge]: WebSocketServer client "::ffff:<IP_ADDRESS>" connected to Matterbridge
WebSocket - Disconnected from WebSocket: ws://<IP_ADDRESS>:8283
WebSocket - Reconnecting (attempt 1 of 10) to WebSocket: ws://<IP_ADDRESS>:8283
WebSocket - Connecting to WebSocket: ws://<IP_ADDRESS>:8283
WebSocket - Connected to WebSocket: ws://<IP_ADDRESS>:8283
info - [00:38:26.051] [Matterbridge]: WebSocketServer client "::ffff:<IP_ADDRESS>" connected to Matterbridge
info - [00:38:26.058] [PluginManager]: Loading plugin matterbridge-home-assistant type
notice - [00:38:26.335] [PluginManager]: Loaded plugin matterbridge-home-assistant type DynamicPlatform (entrypoint /usr/local/lib/node_modules/matterbridge-home-assistant/lib/index.js)
info - [00:38:26.336] [PluginManager]: Starting plugin matterbridge-home-assistant type DynamicPlatform
warn - [00:38:26.365] [HomeAssistantClient]: 943 entities were registered as Matter devices.Please consider that some matter controllers (e.g. Alexa) cannot handle too much entities to be connected via one matter hub.If you intended to use that much entities and your controller seems to work correct, you can ignore this warning.If you are using a controller like Alexa which doesn't support that much entities, please reduce the number of included entities using the configuration.
info - [00:38:26.467] [Matterbridge]: Added and registered bridged device (1/1) Office Lights (MA-extendedcolorlight) for plugin matterbridge-home-assistant
info - [00:38:26.479] [Matterbridge]: Added and registered bridged device (2/2) All Lights (MA-extendedcolorlight) for plugin matterbridge-home-assistant
info - [00:38:26.491] [Matterbridge]: Added and registered bridged device (3/3) Bedroom Light (MA-colortemperaturelight) for plugin matterbridge-home-assistant
info - [00:38:26.503] [Matterbridge]: Added and registered bridged device (4/4) Backyard Lights (MA-onofflight) for plugin matterbridge-home-assistant
info - [00:38:26.513] [Matterbridge]: Added and registered bridged device (5/5) Hall Light (MA-extendedcolorlight) for plugin matterbridge-home-assistant
info - [00:38:26.522] [Matterbridge]: Added and registered bridged device (6/6) All Lights Off (MA-onoffpluginunit) for plugin matterbridge-home-assistant
info - [00:38:26.531] [Matterbridge]: Added and registered bridged device (7/7) Goodnight (MA-onoffpluginunit) for plugin matterbridge-home-assistant
info - [00:38:26.540] [Matterbridge]: Added and registered bridged device (8/8) Toggle Front Door Lock (MA-onoffpluginunit) for plugin matterbridge-home-assistant
info - [00:38:26.548] [Matterbridge]: Added and registered bridged device (9/9) Living Room Ceiling Lights (MA-dimmablelight) for plugin matterbridge-home-assistant
info - [00:38:26.557] [Matterbridge]: Added and registered bridged device (10/10) Kitchen Light (MA-dimmablelight) for plugin matterbridge-home-assistant
info - [00:38:26.565] [Matterbridge]: Added and registered bridged device (11/11) Garage Door (MA-windowcovering) for plugin matterbridge-home-assistant
info - [00:38:26.573] [Matterbridge]: Added and registered bridged device (12/12) Dining Room Lights (MA-extendedcolorlight) for plugin matterbridge-home-assistant
info - [00:38:26.579] [Matterbridge]: Added and registered bridged device (13/13) Living Room Lights (MA-extendedcolorlight) for plugin matterbridge-home-assistant
info - [00:38:26.597] [Matterbridge]: Added and registered bridged device (14/14) Front Door Lock (MA-doorlock) for plugin matterbridge-home-assistant
notice - [00:38:26.597] [PluginManager]: Started plugin matterbridge-home-assistant type DynamicPlatform
info - [00:38:26.598] [Matterbridge]: The plugin matterbridge-home-assistant is up to date. Current version: 2.3.0, Latest version: 2.3.0
notice - [00:38:27.070] [Matterbridge]: Matter server started
info - [00:38:27.071] [Matterbridge]: The commissioning server on port 5540 for Matterbridge is not commissioned. Pair it scanning the QR code:
info - [00:38:27.072] [Matterbridge]: MatterbridgeqrPairingCode: MT:Y.K90IRV01770V6SM00Manual pairing code:<PHONE_NUMBER>9
info - [00:38:57.071] [PluginManager]: Configuring plugin matterbridge-home-assistant type DynamicPlatform
notice - [00:38:57.071] [PluginManager]: Configured plugin matterbridge-home-assistant type DynamicPlatform
info - [00:39:27.073] [Matterbridge]: Setting reachability to true for Matterbridge

Version
2.3.0

Could you try it with 2.3.1?
If it’s still not working, try to not include the cover.
I am not at home for 3 days. I’ll not be able to do another fix until Thursday.

It's working with 2.3.1, thanks so much for such a quick fix.


Fix dead link for contributing.md

What does this PR do?
Fix the broken link for contributing procedures.

/merge

/merge


Add routing support

In order to enable JSONp just for some routes and not for the whole app a routing system must be set in place.

:+1:


Bump to 1.1.1o

I checked it with current version to be sure and it fails too, so I'm disabling it.

I'll have a look at what is included

It happens because of the new wycheproof submodule (which seems to be initialized automatically when updating the openssl submodule), when cloning openssl-src-rs from scratch and non-recursively initializing submodules, I get a size similar to previous releases.

Ah ok that was fixed on main awhile back. Would you be interested in backporting that?

Sure!


Fail to load index from empty folder

This is inverse of #26. Since index check is based on verifying that directory exists, it returns true, if directory already created, but when loading index, fails to look up _table_metadata for Parquet index. It would be better to create _SUCCESS file in root index directory to know whether or not folder is index directory.

Fixed in #33.


Q&A Forum?

Is there a Q&A forum where developers help each other?
This is an awesome resource. I don't think however you want to spend time helping me get up to speed on a couple of things. If you don't mind then may we use this issue as a Q&A thread that always stays open?
I have gone through closed issues to see what I can pick up.

Most folks use TMC. Whenever GitHub opens up Discussions to more repos, I'll turn it on here for sure.


After creating Sharder Cluster with tags cant update document

  def create(fields) do     c = Repo.insert!(Contact.new())     Repo.update(Map.merge(c, fields))   end
I'm updated driver to 1.0.2 and trying to add opts, but catch undefined function error  Repo.update/2 is undefined, but i find in deps in module mongo.repo the 2 arity function
Thanks!

Mmm...maybe try the master branch. It seems, that the options parameter was added in the last commit https://github.com/zookzook/elixir-mongodb-driver/pull/172

First time using link to git and branch name, works great! But i still cant update document in shard cluster,  because for that i need to create tags in document and using them  in filter field for Repo.update.

i am defined new() in collection with putting my attributes, thnks

So the issue is solved? I close the issue for now. Feel free to open a new one if needed.


Activation runs calc twice ?

In GitLab by @nmansard on Feb 14, 2019, 14:05
I noticed we are computing calc when computing calcDiff in all activation models. I think this is useless. Am I missing something?
def calcDiff(model,data,r,recalc=True):
    if recalc: model.calc(data,r)

In GitLab by @nmansard on Feb 14, 2019, 14:05
changed the description

In GitLab by @proyan on Feb 14, 2019, 14:37
recalc is true by default in all the Class models (cost, actuation, DAM, impact, contact...).
I agree, this seems useless.

In GitLab by @cmastalli on Feb 15, 2019, 15:26
This is a extra bit of motivation to work on an abstract API. I really believe we should put more effort on this matter. I am not able to handle each aspect of it.

In GitLab by @nmansard on Feb 28, 2019, 17:23
assigned to @nmansard

In GitLab by @nmansard on Feb 28, 2019, 17:28
mentioned in merge request !117

In GitLab by @nmansard on Feb 28, 2019, 17:29
Solved by !117

In GitLab by @nmansard on Feb 28, 2019, 17:29
closed

In GitLab by @nmansard on Mar 7, 2019, 08:38
mentioned in commit b13eabe804827262597018fdcc8b77cfc46d2337


New version: CodeTools v0.6.5

Registering package: CodeTools
Repository: https://github.com/JunoLab/CodeTools.jl
Created by: @aviatesk
Version: v0.6.5
Commit: c72daed3f53314bb552ba3b9bda17dcd3962906b
Reviewed by: @aviatesk
Reference: https://github.com/JunoLab/CodeTools.jl/commit/c72daed3f53314bb552ba3b9bda17dcd3962906b#commitcomment-36205330

[noblock]

The following dependencies do not have a compat entry that has an upper bound: LNR, Lazy, Tokenize, julia

for supporting old versions of Juno, I would like to allow old versions for those packages and most of them are still in ≤1.0 version, I would appreciate if you merge this as is.

A patch release is not allowed to narrow the supported range of Julia versions

this PR is for made for moving from REQUIER to Project.toml.

The following dependencies do not have a compat entry that has an upper bound: LNR, Lazy, Tokenize, julia

for supporting old versions of Juno, I would like to allow old versions for those packages and most of them are still in ≤1.0 version, I would appreciate if you merge this as is.

I don't see how this is related?

For packages whose versions are under 1.0, ^0.x means [0.x.0, 0.x+1.0) and so we have to list all the compatible 0.x versions and it's dull.
But at the same time I don't want to specifiy them as ^0

@fredrikekre bump.

@fredrikekre @StefanKarpinski bump. The compatibility of this version hasn't changed at all from the previous one with REQUIRE, but only includes a bug fix.

For packages whose versions are under 1.0, ^0.x means [0.x.0, 0.x+1.0) and so we have to list all the compatible 0.x versions and I would like to avoid it.

Why? How many breaking versions can you even be compatible with?


Update README.md

fixed broken link

@sidsarasvati Could you rebase or merge the current master into your branch to trigger a Travis CI build with the fixes @mjarvis applied today?

@sidsarasvati (Just a ping: could you merge master in your branch to trigger CI and then we can merge?)


creating wallet broken

@@@ walletsPath, network, name /zfs-pool/home/rcmorano/Projects/lift-wallet-clean/cardano/wallets testnet ada-and-a-half
get phrase
adding wallet {
name: 'stake1',
mnemonic: 'remain fine razor curious target benefit juice merit corn coffee elbow shaft program ranch teach matter high leader young subject hundred already page come',
passphrase: '1234567890',
network: 'testnet'
}
(node:1933090) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:1933090) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
at validateString (internal/validators.js:112:11)
at Object.resolve (path.js:980:7)
at getAddresses (webpack:///./src/services/wallet.service.js?:246:67)
at IpcMainImpl.eval (webpack:///./src/background.js?:167:107)
at IpcMainImpl.emit (events.js:223:5)
at WebContents. (electron/js2c/browser_init.js:173:8161)
at WebContents.emit (events.js:223:5)
(node:1933090) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5)
@@@ walletsPath, network, name /zfs-pool/home/rcmorano/Projects/lift-wallet-clean/cardano/wallets testnet undefined

is solved


Draft RFC: Treestate management

TODO

[x] decide if we want to merge this RFC as a draft, or make further edits

RFC

Feature Name: treestate
Start Date: 2020-08-31
Design PR: ZcashFoundation/zebra#983
Zebra Issue: ZcashFoundation/zebra#958

Rendered.
Follow up work
Todo's in https://github.com/ZcashFoundation/zebra/issues/958

This RFC has the same number as the state RFC in #902, let's use 0005 for the higher-level RFC ?
Also stolon in #1006 has taken 0006 🤔

I'm marking this 'ready for review' because I want to start getting eyes on the Guide-level section

suddenly I feel so much more prepared to review this rfc, ty @str4d

I would be tempted to merge this as a draft, but I don't want to lose the review comments

I would be tempted to merge this as a draft, but I don't want to lose the review comments

I think I either addressed or added as TODO's in the document all of these! 💃

Approved and merging as a draft RFC


Database service should pass through additional options to the relevant model methods

Example
this.db.query('users', (query) => {
  return query.whereRaw(...);
}, options);


sended -> sent in form.ts

the update is fantastic but yea the spelling

Thanks for your contribution
I know but I can't remember :(


Add explicit signature for Sphinx autodoc when function wrapped by @t…

We use sphinx to auto generate docs.
Some of these files are wrapped in decorator @torch.jit.script.
To adjust for this, for these functions, we explicitly specify the signature in the first line of the docstring.
N.B. Maybe there could be a better way to introspect the wrapper decorator but could not figure out:  https://stackoverflow.com/questions/3687046/python-sphinx-autodoc-and-decorated-members
Tested locally by generating the HTML docs, look good.  Will do a separate PR to check them into the gh-pages branch.

This is related to issue:  https://github.com/pytorch/audio/issues/278

This seems related to https://github.com/pytorch/audio/issues/165 although we are not trying to document a Class method.  @jamarshon  is there a better way to do this?

Do you have an example of where we do this elsewhere in pytorch?

I do not unfortunately.  There are not many standalone methods that are decorated by @torch.jit.script.   I checked out vision, text, and pytorch main.

This is also what's done here.

I'll merge this for now. In the longer term, the solution will be this. Let's wait for the next release to render the documentation


feature: Use cdn for NFT images

Waiting for resize method to be added to the cdn

Latest commit untested (preprod db is down)

Backend in process of updating, may need to change things.

@stackchain Ready to merge from my side

@stackchain Ready to merge from my side

I think on FE is done, still some images are not going through the CDN, holding for a bit while BE figures it out.


Periodic assesment not enabled even if policy is applied

We have enabled policy as suggested in this documentation page. The policy compliance page too shows all the vm list as compliant but when i go to Azure Update Manager, the virtual machines show no periodic assessment enabled. Apart from applying policies for assesment, do we have to take any other step to achieve periodic assessment enabled?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8901200f-bfe0-a305-b65e-77c9dab56784
Version Independent ID: 84dfc838-af4e-622c-0663-22fc78f9480c
Content: Enable Periodic Assessment using policy
Content Source: articles/update-manager/periodic-assessment-at-scale.md
Service: azure-update-manager
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

As an example, here this vm shows compliant to the policy in azure policy for assesment

But when i go to the VM i see periodic assessment is not enabled

@ashishinhaufe
Thank you for bringing this to our attention.
I've delegated this to content author @SnehaSudhirG, who will review it and offer their insightful opinions.

@SnehaSudhirG
Could you please review add comments on this, update as appropriate.

One thing i also want to update here, we are having vm built with custom images. @SnehaSudhirG can you please update if that is supported with these policies.

@SnehaSudhirG any update on this issue. The policy for update manager is still not working as expected. Kindly let me know if the inbuilt policies mentioned in this doc covers custom image (Windows Server 2022 Data Center) or please suggest

We are encountering this issue as well. @ashishinhaufe, we are seeing this with native Azure image VMs and machines migrated to Azure, so I don't expect it's a problem with custom images only.
I've been performing some tests and investigating the results. What I understand is this policy adds the property "assessmentMode": "AutomaticByPlatform" to the VM definition/template (check your VM "JSON View"). Though I'm showing most of my servers are compliant, the reality is their configs are inconsistent. If you're using this Azure policy and a custom a Maintenance Configuration (by changing the Patch orchestration to Customer Managed Schedule), the resource looks like this:
Compliant VM (
"osProfile": {
"computerName": "",
"adminUsername": "",
"windowsConfiguration": {
"provisionVMAgent": true,
"enableAutomaticUpdates": true,
"patchSettings": {
"patchMode": "AutomaticByPlatform",
"assessmentMode": "AutomaticByPlatform"
}
}
Only two of my machines are showing periodic assessment "Yes"; the rest say "No" (including ones reporting complaint). My understanding from reading the docs is that the "AutomaticByPlatform" requires these additional properties to be affective:
"provisionVMAgent": true,
"enableAutomaticUpdates": true,
The inconsistency I'm seeing on my "compliant" machines is that some machines simply have no "osProfile" definition applied, and some have "assessmentMode": "ImageDefault", "provisionVMAgent": "false", and "enableAutomaticUpdates": "false" set. I don't understand the mixed results from the compliance report.
I'll continue investigating and report any new findings.

I've concluded that the Azure policy "Configure periodic checking for missing system updates on azure virtual machines" is not a consistent mechanism for assigning periodic assessment. I think the original definition might need to be updated.
What I found is that the majority of our machines that were listed compliant in the policy but "Periodic assessment: No" were machines we had moved to Azure via Azure Migrate. These are effectively "specialized" images (@ashishinhaufe similar to your custom image scenario). VMs that were built from the Azure gallery were a mix of compliant and non-compliant (the non-compliance was a result of "assessmentMode" never getting updated to "AutomaticByPlatform" (I couldn't figure out why they continued to fail).
This all comes back to values not being updated in the VM's resource definition. For custom machines, such as our Az migrate ones, they simply had no "osProfile" property (see my previous comment), and the policy seems to treat the absence of it as "Compliant". Looks as the though the osProfile property doesn't allow changes directly. I attempted to add via Update-AzVM commands and confirmed this (not sure if the API restricts this).
All of this to say, the workaround is simply to manually toggle each of your machines in Azure Update Manager to "Periodic assessment: Enable" (Manage > Machines > Select machine(s) > Settings at the top > Update settings, or "Enable now" the VM's Operations > Updates page). At a bare minimum, apply the policy to catch new VMs that are built, but you'll have to do some validation. Here's what you might expect your machine to look like after configuring manually via AUM

Hope this helps!

@lampmanistan Thank you so much for the detailed information.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close


[next] Let menu/button/etc. font inherit from body?

Is it possible to let element fonts inherit from body by default? Right now, each element is re-setting the font to Lato, so I can't change it in one place (without a custom build).

If you're changing the default fonts you should probably be using a custom build, otherwise it'll pull Lato from google fonts without being used.

That's true.
I was trying to avoid a custom build, but I also want the GitHub theme as a base, so I guess I need to figure out a way to set up custom builds while still utilizing NPM or JSPM (if that's even possible).

NPM works with custom builds.


Text to speech is not working

Hello guys,
i was really hyped to try azure text-to-speech, but already the sample code isn't working.
This one from the offical page:
https://learn.microsoft.com/en-us/azure/cognitive-services/speech-service/get-started-text-to-speech?tabs=windows%2Cterminal&pivots=programming-language-python
     > import os
     > import azure.cognitiveservices.speech as speechsdk
     >
     > # This example requires environment variables named "SPEECH_KEY" and "SPEECH_REGION"
     > speech_config = speechsdk.SpeechConfig(subscription=key, region=region)
     > audio_config = speechsdk.audio.AudioOutputConfig(use_default_speaker=True)
     >
     > # The language of the voice that speaks.
     > speech_config.speech_synthesis_voice_name='en-US-JennyNeural'
     >
     > speech_synthesizer = speechsdk.SpeechSynthesizer(speech_config=speech_config, audio_config=audio_config)
     >
     > # Get text from the console and synthesize to the default speaker.
     > print("Enter some text that you want to speak >")
     > text = input()
     >
     > speech_synthesis_result = speech_synthesizer.speak_text_async(text).get()
     >
     > if speech_synthesis_result.reason == speechsdk.ResultReason.SynthesizingAudioCompleted:
     >     print("Speech synthesized for text [{}]".format(text))
     > elif speech_synthesis_result.reason == speechsdk.ResultReason.Canceled:
     >     cancellation_details = speech_synthesis_result.cancellation_details
     >     print("Speech synthesis canceled: {}".format(cancellation_details.reason))
     >     if cancellation_details.reason == speechsdk.CancellationReason.Error:
     >         if cancellation_details.error_details:
     >             print("Error details: {}".format(cancellation_details.error_details))
     >             print("Did you set the speech resource key and region values?")

I am using python 3.9 and downloaded Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017, 2019, and 2022. Also i tried it to set the environment variables, but its also not working.
This is my output:
     > Enter some text that you want to speak >
     > hello there
     > Speech synthesis canceled: CancellationReason.Error
     > Error details: USP error: timeout waiting for the first audio chunk
     > Did you set the speech resource key and region values?

if i am executing the same code on: colab.research.google.com, i dont get any errors like before, but also a empty .wav file.
A new api key and a new text-to-speech module i also generated, i dont know what the problem is...
This code dont shows me any error, just creates a empty test.wav file:
     > def synthesize_to_speaker():
     >     # Find your key and resource region under the 'Keys and Endpoint' tab in your Speech resource in Azure Portal
     >     # Remember to delete the brackets <> when pasting your key and region!
     >     speech_config = speechsdk.SpeechConfig(subscription=key, region=region)
     >     # In this sample we are using the default speaker
     >     # Learn how to customize your speaker using SSML in Azure Cognitive Services Speech documentation
     >     # audio_config = AudioOutputConfig(use_default_speaker=True)
     >     audio_config = speechsdk.audio.AudioOutputConfig(filename="file.mp3")
     >     synthesizer = speechsdk.SpeechSynthesizer(speech_config=speech_config, audio_config=audio_config)
     >     synthesizer.speak_text_async("Text Text Text wie geht es dir du fettes bier ich hau mir ne nudel nei")
     >
     >
     > synthesize_to_speaker()

I just tried the speech-to-text module with this code, this is working totally fine.
     def recognize_from_microphone():
         # This example requires environment variables named "SPEECH_KEY" and "SPEECH_REGION"
         speech_config = speechsdk.SpeechConfig(subscription=key, region=region)
         speech_config.speech_recognition_language="en-US"

         audio_config = speechsdk.audio.AudioConfig(use_default_microphone=True)
         speech_recognizer = speechsdk.SpeechRecognizer(speech_config=speech_config, audio_config=audio_config)

         print("Speak into your microphone.")
         speech_recognition_result = speech_recognizer.recognize_once_async().get()

         if speech_recognition_result.reason == speechsdk.ResultReason.RecognizedSpeech:
             print("Recognized: {}".format(speech_recognition_result.text))
         elif speech_recognition_result.reason == speechsdk.ResultReason.NoMatch:
             print("No speech could be recognized: {}".format(speech_recognition_result.no_match_details))
         elif speech_recognition_result.reason == speechsdk.ResultReason.Canceled:
             cancellation_details = speech_recognition_result.cancellation_details
             print("Speech Recognition canceled: {}".format(cancellation_details.reason))
             if cancellation_details.reason == speechsdk.CancellationReason.Error:
                 print("Error details: {}".format(cancellation_details.error_details))
                 print("Did you set the speech resource key and region values?")

     recognize_from_microphone()

@Grace-MacJones-MSFT

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 064d7074-3ea4-21e4-60b4-b09976bbdf7e
Version Independent ID: 1fdefc18-e765-9fe8-0652-ca18122cb0fa
Content: Text-to-speech quickstart - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/get-started-text-to-speech.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @eric-urban
Microsoft Alias: eur

@2fersen
Thanks for your feedback! We will investigate and update as appropriate.

@SaibabaBalapur-MSFT any update? Text to speech suddenly stopped working for unity c# as well.

@YashGohel21 @2fersen -
Are you using Windows 11? There is a known issue introduced by some security updates October 12th that might cause connectivity issues using the TTS endpoints. There is an out of band update available for Windows 11 that fixes these issues. The update may be manually installed by following the instructions here:

Windows 11 21H2: https://support.microsoft.com/topic/october-17-2022-kb5020387-os-build-22000-1100-out-of-band-5e723873-2769-4e3d-8882-5cb044455a92
Windows 11 22H2: https://support.microsoft.com/topic/october-25-2022-kb5018496-os-build-22621-755-preview-64040bea-1e02-4b6d-bad1-b036200c2cb3

For example, you can install via the Microsoft Update Catalog:

This worked for me on Windows 11 22H2.
I hope this helps!

@YashGohel21 @2fersen -
Are you using Windows 11? There is a known issue introduced by some security updates October 12th that might cause connectivity issues using the TTS endpoints. There is an out of band update available for Windows 11 that fixes these issues. The update may be manually installed by following the instructions here:

Windows 11 21H2: https://support.microsoft.com/topic/october-17-2022-kb5020387-os-build-22000-1100-out-of-band-5e723873-2769-4e3d-8882-5cb044455a92
Windows 11 22H2: https://support.microsoft.com/topic/october-25-2022-kb5018496-os-build-22621-755-preview-64040bea-1e02-4b6d-bad1-b036200c2cb3

For example, you can install via the Microsoft Update Catalog:
This worked for me on Windows 11 22H2.
I hope this helps!

I am on MacOS Ventura 13.0 and for me it started around somewhere between 22-28 Oct.

@YashGohel21 @2fersen -
Are you using Windows 11? There is a known issue introduced by some security updates October 12th that might cause connectivity issues using the TTS endpoints. There is an out of band update available for Windows 11 that fixes these issues. The update may be manually installed by following the instructions here:
* Windows 11 21H2: https://support.microsoft.com/topic/october-17-2022-kb5020387-os-build-22000-1100-out-of-band-5e723873-2769-4e3d-8882-5cb044455a92

* Windows 11 22H2: https://support.microsoft.com/topic/october-25-2022-kb5018496-os-build-22621-755-preview-64040bea-1e02-4b6d-bad1-b036200c2cb3

For example, you can install via the Microsoft Update Catalog:
This worked for me on Windows 11 22H2.
I hope this helps!

I am using Windows 10


NIFI-4663 FetchElasticsearch Logging

Remove warn log when document not found by FetchElasticsearch

@mattyb149 you good with this?  The change makes total sense to me

+1 LGTM, nice catch! This should improve performance when attempting to fetch many "missing" documents. Thanks for the improvement!

no performance implication really but will be less confusing to the user that already knew to specify the relationship :)  +1 will merge to master shortly


Request changes true causes error

Hi,
if I enable request changes I get the following error:
gh pr review
  could not determine current branch: failed to run git: not on any branch
  Error: Process completed with exit code 1.

Can you give me any hints? Thank you.

Can you give me any hints? Thank you.

@s-martin, something like this?
name: "Check git status"
on:
  pull_request:

jobs:
  check-git-status:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v4
      with:
        repository: ${{ github.event.pull_request.head.repo.full_name }}
        ref: ${{ github.event.pull_request.head.ref }}
    - uses: actions/setup-go@v5
      with:
        go-version: stable
    - run: go mod tidy
    - uses: CatChen/check-git-status-action@v1
      with:
        fail-if-not-clean: true
        request-changes-if-not-clean: true
        request-changes-comment: |
          Please make sure you've run the following commands from the root directory.

          ```shell
          go mod tidy
          ```

Let me look into this and get back to you later.

@s-martin Are you using the pull_request event as the trigger or other events? The action doesn't work with other events yet, but let me know what your scenario is and I may be able to add support for that event. Thanks.

@s-martin Do you mind sharing your workflow file? Otherwise, how do you set up @actions/checkout before running this action? This action assumes @actions/checkout is run before itself so it can check whether git status returns anything.
It also assumes @actions/checkout checks out a Pull Request branch when request-changes-if-not-clean is true. You can run this action in a context without a Pull Request, but you will need to keep request-changes-if-not-clean false. Let me know if you have a use case that's relevant to Pull Request but doesn't check out the Pull Request branch.


Can't find the library

Hi, I was trying to use your library but after adding it in the gradle file, it gives me an error :
Failed to resolve : com.heinrichreimersoftware:material-intro:1.6

Make sure you include
    repositories {
        maven { url 'https://jitpack.io' }
    }

I've already done it :(

The library is up on JitPack so double- that you included their repo in the allprojects block.
Check their site for more information and copy-paste code: https://jitpack.io/#com.heinrichreimersoftware/material-intro/1.6
If that still won't work out please post the exact error log message from the Gradle console.

I've done it but nothing has improved, probably I choke where to put the code ?
`// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:2.2.2'

    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}
allprojects {
repositories {
jcenter()
maven { url 'https://jitpack.io' }
}

}
task clean(type: Delete) {
delete rootProject.buildDir
}
`

Ok that may be the problem.
The Gradle build system distinguishes between the project level build.gradle and the module's build.gradle.
So if your project/workspace is named ExampleProject and you want to use the dependency in a module called app, you'll find the project level Gradle file at /path/to/ExampleProject/build.gradle and the module level build file at /path/to/ExampleProject/app/build.gradle.

I know that there are 2 different files of Gradle
So where I need to put
allprojects {
repositories {
...
maven { url 'https://jitpack.io' }
}
}
and where
dependencies {
compile 'com.heinrichreimersoftware:material-intro:1.6'
}

No problem :)


Missing documentation / notifications about ENV parameters required for make unit-test

make unit-test requires a couple of ENV variables to be set which don't appear to be documented anywhere.
if these aren't set, the helm plugin install doesn't populate the values required to download the binary for the given platform:
plugin_install.go:73: [debug] loading plugin from /home/kcrawley/.local/share/helm/plugins/helm-unittest
plugin.go:60: [debug] running install hook: /bin/sh -c $HELM_PLUGIN_DIR/install-binary.sh
Downloading https://github.com/rancher/helm-unittest/releases/download/v0.1.6-rancher1/helm-unittest-linux-linux-amd64.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     32      0 --:--:-- --:--:-- --:--:--    32
tar: This does not look like a tar archive

by setting the ENV variables:
$export CATTLE_HELM_UNITTEST_VERSION=v0.1.6-rancher1
$export ARCH=amd64

and running the make unit-test, the install seems to work and the tests are run:
➜  traefik-helm-chart git:(master) make unit-test
== Checking global requirements...
== Checking that plugin helm-unittest is available...
[debug] updating https://github.com/rancher/helm-unittest
[debug] symlinking /home/kcrawley/.cache/helm/plugins/https-github.com-rancher-helm-unittest to /home/kcrawley/.local/share/helm/plugins/helm-unittest
plugin_install.go:73: [debug] loading plugin from /home/kcrawley/.local/share/helm/plugins/helm-unittest
plugin.go:60: [debug] running install hook: /bin/sh -c $HELM_PLUGIN_DIR/install-binary.sh
Downloading https://github.com/rancher/helm-unittest/releases/download/v0.1.6-rancher1/helm-unittest-linux-amd64.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   642  100   642    0     0   1725      0 --:--:-- --:--:-- --:--:--  1725
100 4799k  100 4799k    0     0  4195k      0  0:00:01  0:00:01 --:--:-- 8052k
Preparing to install into /home/kcrawley/.local/share/helm/plugins/helm-unittest
helm-unittest installed into /home/kcrawley/.local/share/helm/plugins/helm-unittest
 ....
Installed plugin: unittest
== plugin helm-unittest is ready
== Unit Testing Chart...

### Chart [ traefik ] ./traefik

 PASS  Pod configuration        traefik/tests/pod-config_test.yaml
 PASS  Traefik configuration    traefik/tests/ports-config_test.yaml
 PASS  RBAC configuration       traefik/tests/rbac-config_test.yaml
 PASS  Service configuration    traefik/tests/service-config_test.yaml
 PASS  Main Container configuration     traefik/tests/container-config_test.yaml
 PASS  default install  traefik/tests/default-install_test.yaml
 PASS  Deployment configuration traefik/tests/deployment-config_test.yaml
 PASS  PodDisruptionBudget configuration        traefik/tests/poddisruptionbudget-config_test.yaml
 PASS  Traefik configuration    traefik/tests/traefik-config_test.yaml

Charts:      1 passed, 1 total
Test Suites: 9 passed, 9 total
Tests:       43 passed, 43 total
Snapshot:    0 passed, 0 total
Time:        67.2957ms

== Unit Tests Finished...

This issue could be addressed by either documenting this requirement, or properly determining the arch and setting those env variables in the Makefile. I'm leaning towards the Makefile


Use Aqua.test_project_extras

[ ] to be merged after #225

Codecov Report

Merging #226 into master will decrease coverage by 4.99%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #226    +/-   ##
========================================
- Coverage   92.43%   87.43%    -5%
========================================
  Files          19       19
  Lines        1282     1202    -80
========================================
- Hits         1185     1051   -134
- Misses         97      151    +54

Impacted Files
Coverage Δ

src/interop/dataframes.jl
0% <0%> (-100%)
:arrow_down:

src/basics.jl
35% <0%> (-50.72%)
:arrow_down:

src/core.jl
72.43% <0%> (-19.03%)
:arrow_down:

src/simd.jl
78.12% <0%> (-18.85%)
:arrow_down:

src/reduce.jl
80.48% <0%> (-12.54%)
:arrow_down:

src/lister.jl
80.48% <0%> (-7.32%)
:arrow_down:

src/unordered.jl
93.02% <0%> (-3.14%)
:arrow_down:

src/comprehensions.jl
81.81% <0%> (-0.54%)
:arrow_down:

src/library.jl
93.75% <0%> (-0.5%)
:arrow_down:

src/show.jl
94.87% <0%> (-0.17%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9020daf...1b527d5. Read the comment docs.


Add cloud testing

Summary
Add cloud testing
Checklist
Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

See my comments on a few tests that are not working against cloud #367


Missing textarea

Hi,
i would like to help implement the missing textarea component wich is in textfield in vanilla. There's many way to achieve this :

add a textarea attribute (and rows and col)
create an mdc-textfield-textarea or mdc-textarea
other
Do you have think about this already ?
regards

That's great. It probably makes sense to create mwc-textarea and make it a subclass of mwc-textfield. It might be necessary to add some additional extension points in mwc-textfield to make this convenient. There's some info about supported textarea rendering here https://github.com/material-components/material-components-web/tree/master/packages/mdc-textfield#textarea.

related PR was outdated and closed

https://material.io/design/components/text-fields.html#input-types has an example of Multi-line text fields grow to accommodate multiple lines of text
I recall polymer paper elements had such functionality for text area. Should autogrow work with textfield or textarea (or both)?


Impossible OTA for NodOn  SIN-4-RS-20

Description of the issue
ZigbeeMQTT finds an updatefor the firmware of my NodOn SIN-4-RS-20 but can't do it.
Addon version
1.32.1-1
Platform
Home Assistant 2023.7.3
Supervisor 2023.07.1
Interface utilisateur : 20230705.1 - latest
Logs of the issue (if applicable)
Zigbee2MQTT:info  31-07-2023 19:17:34: MQTT publish: topic 'zigbee2mqtt/bridge/response/device/ota_update/update', payload '{"data":{"id":"NodOn 1"},"error":"Update of 'NodOn 1' failed (No image available for imageType '265')","status":"error","transaction":"zbgyj-1"}'
Zigbee2MQTT:error 31-07-2023 19:17:34: Update of 'NodOn 1' failed (No image available for imageType '265')
Zigbee2MQTT:debug 31-07-2023 19:17:34: Error: No image available for imageType '265'
at getImageMeta (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/zigbeeOTA.ts:114:15)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at getNewImage (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/common.ts:437:18)
at Object.updateToLatest (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/common.ts:296:19)
at OTAUpdate.onMQTTMessage (/app/lib/extension/otaUpdate.ts:267:41)

This means we don't have an image available for your device, you can try asking NodOn if they can provide the OTA.

It's strange : NodOn Connect (Android Application) tell me my products are up to date.

It's strange : NodOn Connect (Android Application) tell me my products are up to date.

Same problem with several SIN-4-1-20 and SIN-4-2-20

Home Assistant (with zigbee2mqtt add-on) is reporting my Nodon "SIN-4-1-20" update  from version "534" to ¨541".

Trying to trigger update from Home assistant fails.

Trying to trigger update from Zigbee2Mqtt frontend is resulting in "Update of 'PriseTerrassePergola' failed (No image available for imageType '266')¨.
Looks like due to message received from the device:
" Received Zigbee message from 'PriseTerrassePergola', type 'commandQueryNextImageRequest', cluster 'genOta', data '{"fieldControl":1,"fileVersion":65794,"imageType":266,"manufacturerCode":4747}' from endpoint 1 with groupID 0 "

Nodon Android APP to update device is reported that product is up to date.

If this could help, hereis the message of Nodon technical support :
`Bonjour Sébastien,
Nous sommes entrain d'intégrer les mises à jour OTA, c'est pour cela que vous voyez cela apparaitre.
Pour le moment, il n'y a pas de nouvelle mise à jour disponible.
Les dernières versions sont celles publiées sur NodOn Connect.
Bonne journée.
Cordialement,
`

This still seems to be unsolved, right?


synchronous token refresh on app boot

refs https://github.com/TryGhost/Ghost/pull/8065

old access tokens are now deleted when we get a new one using the refresh token so we need to ensure that we don't fire multiple requests in parallel during app boot in case the token refresh is handled by the server first therefore causing the other requests with the old credentials to fail

Coverage increased (+0.01%) to 74.946% when pulling 8e7300d33735724ec2f28f3dd5f45e7eb202b39d on kevinansfield:synchronous-token-refresh-alpha into 90be933bfea999717515b8613f79ba8594729674 on TryGhost:master.

Closing as this is no longer needed. Deleting tokens caused a lot of other issues so we're going with a softer approach that also won't break a background token refresh.


Adoption of new technology

Aspect
Description

Challenges
New technology can alienate current ICES members that have crucial skills within their fields. This applies to technology in the broadest sense, eg. dominant programming language, use of exchange platforms (sharepoint, github), online meeting facilities, machine learning.

Mitigating strategies and controls
Good training opportunitiesDocumentation of new systems and technology

--

legacy entry

Edited the original issue so this one now covers just the challenges of adopting new tech (new issue to cover opportunities [https://github.com/ices-eg/DIG/issues/572]).
I deemed the likelihood as low because the vast majority of ICES members are used to a workplace that is in a constant state of technological renewal.
I deemed the impact as low because new technologies tend to be designed to be more intuitive and user friendly than older ones with less in depth knowledge / skills required to interact with them.  Also as older folk begin to retire or take a step back from direct ICES work, a younger generation is more used to such advancing tech.

Likelihood: Increased to medium as we see there are some challenges with getting some technology introduced into the community i.e. slower uptake of TAF.


Remove VIS data paper repository

Since the data paper has been published and we only need to maintain the metadata of the datasets (in this repository), I think we can remove the data paper repository: https://github.com/LifeWatchINBO/vis-data-paper. There are no open issues.
For archive purposes, I'll transfer the repo to @DimEvil.

Repo transferred.


sig#796: Explore CH runtime activation for CH Compliance Activation During Approval Flow

Ticket under refinement
Description
The previously implemented runtime toggle for the deactivation/activation of the Clearinghouse Compliance flow (CH) enabled the administrators to enable or disable CH validation. Its expected that this toggle works without any disruption for ongoing processes.
As part of this ticket the possible interruption for registrations (companies as well as connectors) need to get validated, best solved and not possible to be solved scenarios need to get documented for the operation of the solution.
Objectives

Seamless Transition:

Develop logic to handle the transition of registrations from a state where CH is disabled to a state where CH is enabled and vice versa.
Ensure that the transition is seamless and does not negatively impact the user experience or the integrity of the approval flow.

Acceptance Criteria

The transition logic must:

Ensure that registrations in the approval flow continue seamlessly when CH is enabled or disabled.
Handle any edge cases that might occur due to the state change to prevent data inconsistencies or user errors.

Notes

Detailed technical documentation is required to guide the implementation and future maintenance of this feature.

Implementation Steps

Analyze and document the current approval flow to identify points of impact when CH is toggled.
Develop transition logic that maintains the integrity of the approval flow during a toggle state change.
Update the system documentation with detailed information on how the toggle works and its impact on the approval flow.

@Phil91  explained that this is currently already implemented.
implicitly implemented already.


Manually adding user does not send verification link

Neither is there an option to automatically verify the newly added user or verify the user afterwards.

Confirmed.


CI nightly libtensorflow stuck

@asimshankar @alextp the nightly libtensorflow build on the CI server seems to have been stuck for a few days now due to the Mac build. Is there a way to resolve this in order to have the binaries built for the recent changes to the eager C API? I'm currently cross-compiling on my machine but that is very expensive and so this would really help! Thanks a lot! :)
http://ci.tensorflow.org/job/nightly-libtensorflow/

I restarted that job, but I believe the nightly jobs are in the process of being migrated away from this Jenkins instance? I could be wrong (there seem to be no online Mac slaves).
@av8ramit @case540 would know better.

Thanks for filing @eaplatanios. I'm working right now to take care of this.

@av8ramit Thanks! It seems it'll all good now! :)
@asimshankar Thanks for helping with this! If indeed you migrate those jobs away, do you plan to provide a way to obtain nightly builds for the dynamic libraries (i.e., libtensorflow.so and libtensorflow_framework.so)?

@eaplatanios yes we will definitely provide a way for access to those in a cleaner way as well.

That's great! Thanks @av8ramit! :)

https://github.com/tensorflow/tensorflow#continuous-build-status


Nancy.Request.Query should contain the valueless names

Currently Nancy.request will handler http://foo/com/?name=value, or duplicates i.e. http://foo/com/?name=value&name=value2 becomes
Request.Query.name == "value,value2"
However, what if I want to do http://foo/com/?name? That's being swallowed by the quer string parser. I think the key should be added to the dictionary with  a value modeled after DbNull called QueryNull.Value. I'd be ok with another representation.
Thoughts? I'll write the patch.

@grumpydev It looks like this issue has been resolved w/ #1537; can we go ahead and close this issue ?

Done :)


How to convert PNG to JPG with an output ICC profile without using flatten?

Question about an existing feature
What are you trying to achieve?
I'm trying to convert a PNG file to a JPEG file in combination with an output (CMYK) ICC profile.
When you searched for similar issues, what did you find that might be related?
I've researched all output options and I'm able to do the conversion to a CMYK JPEG without an output ICC profile. If I'm using an ICC output profile, it triggers an error unless I also apply the flatten operation.  I'm unable to find any issues related to converting from PNG to JPG using an ICC profile.
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
1. Working code, generic CMYK applied
    await sharp('input.png')
      .toColourspace('cmyk')
      .jpeg()
      .toFile('output-cmyk.jpg');

2. Fails with error Error: icc_transform: unable to load or find any compatible input profile
    await sharp('input.png')
      .toColourspace('cmyk')
      .withMetadata({ icc: 'U.S. Web Coated (SWOP) v2.icc' })
      .jpeg()
      .toFile('output-cmyk.jpg');

3. When adding the flatten operation it works and the ICC output profile applied correctly
    await sharp('input.png')
      .flatten({ background: '#fff' })
      .toColourspace('cmyk')
      .withMetadata({ icc: 'U.S. Web Coated (SWOP) v2.icc' })
      .jpeg()
      .toFile('output-cmyk.jpg');

I'd expect 2 not to trigger an error, I'm not sure why adding the flatten operation prevents this from happening.

Does this only occur for 4-channel RGBA PNG images? Does the use of removeAlpha also help?
There will be a few improvements around CMYK profile handling in a forthcoming libvips 8.15 release that might automagically fix this so let's wait until after that release to see if there's anything else we need to do in sharp.
https://github.com/libvips/libvips/issues/3159

Thanks for your feedback @lovell,

removeAlpha solves the error
working with 3 channel PNG (no alpha) solves the error as well.

Here are the files I used for testing:
dices-alpha.png.zip
dices-noalpha.png.zip

@adriaanmeuris Is there anything else you need relating to this or can we close?

Thank you @lovell, working as expected now.


can't create project in vs2022-preview version 17.0.0prview 2.1

dotnet version=6.0.100-preview.6.21355.2

Hi @lwqwag,
Analyzing this issue will get back with an update.
Would like to know more about the way the extension is installed, from VS IDE or from VS Marketplace?
Regards,
Vijay Anand E G

Hi @lwqwag,
Analyzing this issue will get back with an update.
Would like to know more about the way the extension is installed, from VS IDE or from VS Marketplace?
Regards,
Vijay Anand E G

I removed the extension and installed it again,it works nice now .
Thanks for reply anyway.

Hi @lwqwag,
Glad to know it works. Keep exploring.
To know the root cause, would like to know whether you've upgraded from the initial <IP_ADDRESS> version to the latest <IP_ADDRESS> version or started from the latest one.
Regards,
Vijay Anand E G

Yes ,it is latest version <IP_ADDRESS> now.