plyr.js:376 Uncaught TypeError: Cannot read property 'play' of undefined

I'm Using plyr to embed a video from youtube but when I initialize using plyr.setup(); always get the same error, I want the player to show the controls, I already load the svg file as the documentation says, but the error is blocking the controls visibility, how can i fix de error?????

Fixed in the latest build. Thanks for reporting :+1:

I'm still getting this error, but only when I use the source method.
var player = plyr.setup('.js-media-player', {
		controls: [
			'play'
		],
		html: controlsHtml
	})[0];

	player.source({
	  type:       'video',
	  title:      'Example title',
	  sources: [{
	      src:    '143418951',
	      type:   'vimeo'
	  }]
	});

html


File attachment size

I think that info about file sizes here: https://docs.microsoft.com/ru-ru/azure/devops/project/wiki/wiki-file-structure?view=azure-devops#file-naming-conventions is not relevant anymore as I can read here: https://docs.microsoft.com/en-us/azure/devops/release-notes/2019/sprint-156-update#fix-warning-in-large-test-attachments

Сведения о документе
⚠ Не вносите правки в этот раздел. Это необходимо для связывания страницы сайта docs.microsoft.com с вопросом на GitHub.

ID: 361efecd-d973-82ed-1dd8-ca01afe12f5d
Version Independent ID: 629f3af2-8218-e53c-45c3-0e40c03f2273
Content: Wiki repository files, structure, and conventions in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/wiki-file-structure.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @Bafff, The new change is in Test, which isn't related to wiki file attachments. In Wiki, the limit is still what is mentioned in the documentation. Thank you!


Why MessageData does not support multi-dimension arrays?

Describe the feature you would like to see
Why MessageData does not support multi-dimension arrays?

@jeromegamez oh indeed, excuse me then, gonna ask them;)


Include open educational resources into application

Provide explicit definition of a "MOOC" and also other types of courses, maybe in form of a glossary

[x] Discuss and formulate the definitions, also comparing MOOC and Online Courses
[x] write and make available glossary
[ ] Introduce in db: as additional education type
(or as attribute (would require change of datamodel))
[ ] corresponding changes in managing courses (adding the education type)
[ ] Adapt search options on "home page" Choose Education-filter

Thank you @vronk for creating this task. I noticed that we already have a draft document with definitions started by @PixlTracer: https://docs.google.com/document/d/1FMquEoMn7EIOHH6I00K_518cDIVzBsvShUnKCut0FGE/edit?usp=sharing. We will finalise the glossary in that document and notify you when done.

@IvdL22  @PixlTracer :
Would it be possible to provide 2 examples of a MOOC? With 2 links to more detailed information? So that we can use that as reference when working on this topic?

@patrickakk cc @PixlTracer We now have a glossary here where you can check the terms and examples: https://docs.google.com/spreadsheets/d/1rXZQa-TsxTKXvyfZx4zeUxkC1_kqODO4/edit?usp=sharing&ouid=107443344257746111643&rtpof=true&sd=true

@IvdL22  @PixlTracer @vronk Summary from today's meeting:
It's no longer the intention to include MOOC's in the DHCR.
The open educational resources from Dariah Teach should be included. One example provided by Iulliana is:
https://teach.dariah.eu/course/view.php?id=68&section=2
Important information fields are: title, description and link.
The next step would be for Patrick to analyse the structure of the new items and see if and how we can integrate this in the registry.
Is that a correct summary?
Note: since this is additional work, I'll move this task to the mai23 milestone.

Moved to July milestone since the specs are not finished. Maybe we need to move it again, depending on how long this takes.

@PixlTracer  @IvdL22  @vronk
With this comment, I'll try to summarize the meeting from 2023-05-17 as well as propose some solutions:
Characteristics
Open education resources could be used by teachers to include them into other courses. As well they could be used by students.
Question: We used various terms. Which one is correct? Is this: Open Education Resource (OER)?
Currently they can be found on multiple locations:
-DARIAH [ca 16 courses]: https://teach.dariah.eu/course/index.php
-CLARIN [ca 10 courses]: https://www.clarin.eu/content/training-materials
-Upskills [ca 6 courses]: https://upskills.fil.bg.ac.rs/
When adding them to the DHCR, the metadata of all of them will be available at one location, as well as the complete overview can be accessed through the API.
An example for recent updated(public shown), PhD courses though the API can be found at:
https://dhcr.clarin-dariah.eu/api/v2/courses/index?recent&course_type_id=4
The same could be available when a new education type "Open Education Resource" will be created.
It was proposed to enter the courses manually, since this is a small amount of courses and the metadata is not expected to change often. The information could be checked/updated yearly by the administrators (Anna & Iulliana).
The characteristics of the OER's conflict with the current data model. Three options were discussed:

Add one course which "summarizes" the OER's at one place. (Similar to ACDH tool gallery). In this case it might be difficult for a user to find the details.
Create a separate list/database/table/data model for the new characteristics. This is almost the same as creating a separate registry and requires a lot of development hours. As well the items won't be available though the current filter/search options.
Create a new Education Type and define a "set of rules" how we can deal with the differences in structure. This might be the preferred option, depending on how we can change/adapt the current validation rules.

Which characteristics are different? OER's have:
-No physical present institution and department
-No city and country and no location on the map (lat, lon)
-No start date and is not recurring
-No fixed duration [unit and type] (that would depend on the student)
-No lecturer name and email = no problem, since those fields are not required
-No entry requirements? = no problem, since this field is not required
-Are there Tadirah objects which apply?
The goal is that the data model represents the real world. Currently the validation rules apply to all courses, which means there are no exceptions based on education type. For example every course has to be at an existing institution and that has to be on a physically existing location. Another example is that every course needs to have at least one start date. The presence of these data is also important when users are using the filter or sort options.
We could try to implement different validation rules, which behave different, based on the Education Type. In case we choose this solution, I'll have to take a look at this further, to see if the model supports this.
What should the new validation rules do?
Institution and location difference

Create institutions for the OER materials. How many do we need?

Create validation rules which prevent not OER courses from using those institutions.

Create city and country "Remote" for all OER courses

OER courses should be forced to use only the "Remote" location. Otherwise they will "pollute" the filter results when searching for a regular course.

No start date available

Option 1: Allow empty start date for OER's.

Disadvantage: In the registry (list) they will look like courses which are not starting any more.

Option 2: Set a start date for a fixed day in every month as well as check(enable) recurring. For example 1th of Jan, 1th of Feb, etc.
Disadvantage: Based on start date (always very soon) they might get more attention than the currently existing courses
Option 3: Something else?

No fixed duration [unit and type]
We could use the same approach as for the location difference:
Create a new duration unit "Flexible" which is required for OER courses and can not be used by other courses.
Would that be a good solution?
How can this new feature be communicated / be visible for users? How should OER courses be visible / findable for users?

The user can filter on the new education type "Open Education Resource". (Use filter button)

A section could be added in the menu, which contains an explanation of OER's as well as a button which automatically activates the filter and shows all the OER's. An example of clicking on this button, for the course type "PhD", would look like this: https://dhcr.clarin-dariah.eu/?course_type_id=4

A short url could be created, for easy dissemination, for example: https://dhcr.clarin-dariah.eu/open-education-resources
Is this needed? Which short url is preferred?

Is anything else needed?

Is this summary correct? Did I miss anything? Are there suggestions/additions? And finally, what do you think of the proposed solution?

I have to admit, I am somewhat surprised about the turn this task took.
As the analysis also shows, the educational resources are ontologically quite a different animal than courses:
the former are some kind of digital object, the latter an activity.
And! For a catalogue of resources we have alone in DARIAH the DARIAH Campus: https://campus.dariah.eu/resources/page/1
besides many other catalogues and directories. Especially dariahTeach materials are also already included in DARIAH-Campus.
So I am decidedly against extending the functionality to support OER as first-class citizens next to courses.
In my recollection, the original idea was to allow for links/pointers to resources (learning materials) pertaining to existing course,
not a separate index of learning materials.

Removed from milestone as discussed in meeting

As discussed today with Toma Tasovac (see agenda & minutes):
We want to keep a clear distinction between courses
as Activities (event with start and end date and a location) and
as Digital objects (like training materials available online).
And restrict DHCR to register and present the "Activities" and use DARIAH Campus for the "Digital objects".
That means that "online courses" available e.g. in dariahTeach or from the upskills project should not be registered in DHCR, but rather in D-C as external resources.(Indeed courses from dariahTeach already are featured in D-C.)
However, it should be possible to record, if there is training material available accompanying the corresponding activity. This should be in form of a field to be populated ideally with a URL pointing to the online material (ideally hosted in a stable manner). Indeed such material can be made available through DARIAH Campus, in which case the entry in DHCR would point to the corresponding entry in D-C.

@vronk Thanks for the explanation.
@vronk @PixlTracer @IvdL22 Can we close this issue? If yes, please change the label to "Done" or click on Close ;)

Since we agreed to introduce a metadata field, where the course owner/lecturer can leave a link that points to the training/learning material available (see @vronk's comment above), I'd like to leave this issue open, until the metadata field has been implemented;
--> to do @patrickakk:
introduce a (non-mandatory) metadata field in which a link can be set that points to learning material hosted/stored elsewhere

@PixlTracer Thank you for pointing that out.
Can we specify what is needed:

One new text field (as shown on the screenshot above)?
Are we sure there will always be one or no link? This means not more than 1? Does that apply in all cases?
Should there be a simple check if it contains an url? (http)
Should there be a url validation check?
Should that only be done on entry/update or also on regular basis?

(For now I moved it to the November milestone. After the specifications are clear, we could talk about the milestone for the implementation?)

Preview of user interface with dummy data.
Public available info at Course Detail page

New field in login area at Course add or edit

@IvdL22
cc @PixlTracer
Is this the correct summary of what was said in the meeting on the 10th of June?
CLARIN needs to possibility that links (=plural) to datasets used in a course, are added to the course metadata.
DARIAH needs to possibility that links (also plural?) to training material that is (re)used in a course are added to the course metadata.
On the other hand, based on the requirements here:
https://github.com/acdh-oeaw/dhcr-main/issues/48#issuecomment-1755445882

Are we sure there will always be one or no link? This means not more than 1? Does that apply in all cases? we will not know. we could offer a 2nd link field (which might not be used much)...

and

Should there be a url validation check? absolutely!

The current (almost finished) implementation only contained one text field, with place for one link and a link checker that required a valid http status code. So it's not possible to enter more than one link.
The information above almost certainly needs more than one item to be added, which should be implemented in the data-model in a completely different way. (One to many relationship).
Based on the new information above the current implementation does not provide what is needed.
During the meeting it was decided to discuss what is needed during the WG meeting on the 19th June.
I'll revert and not commit the work already done, put the issue on hold and move it to the July milestone. Maybe we can all  agree on what is needed soon?

Hi @patrickakk cc @PixlTracer Thank you.  The way I see this implementation is the following:
Description: If you use a CLARIN or DARIAH resource in your course, be it training material, dataset, tool or service, please add the URL.
Optional field 1: CLARIN resource
Option field 2: DARIAH resource
What do you think? Would this be possible to implement? I could add the text like this to the slide and then discuss with the WG.

@IvdL22 @PixlTracer
I would suggest to go a (few) steps back in the process: Why do we develop this feature?
Is this because CLARIN and DARIAH want to know which resources are used and in which courses or how often they are used? In that case you want to measure something, which makes it an important feature?
And in that case, why do you want to ask during a WG meeting what they need?
What do we do when there is more than one link to add?
In the case of a CLARIN dataset, do you expect they always only used one?
What do you do when they used more than one and can't enter the information? Then your report is unreliable?
Do we need to add attributes to the link? (Source: DARIAH/CLARIN, Type: Dataset, tool, training material, etc.)?
How do you want to see/summarize the data which is entered?
With the requirements/wishes currently available, I would suggest the following steps:
a) Iulliana and Anna provide at least three(3) real world examples of courses and the links that can be added
b) We create a dummy preview of a report for both organizations and check if that contains the information that's needed, in the format/with the attributes needed.
c) Based on point B, we decide which information, attributes and data structure is needed.
d) Dummy user interface preview. Now, this needs to be accepted before proceeding to the next step.
e) Decide if the new fields should be provided by the API as well.
f) Technical implementation
This is probably not a small feature. Since the larger amount of working hours needed for this, I would suggest to have at least 1 dedicated meeting about this, where at the end, everybody commits to a set of requirements to avoid doing the same work over and over again.
And at least involve Matej @vronk as well.
And please think about this: It's easy to make changes to the wishes now, more complicated when the feature is finished and way more complicated when some data has been entered. So what do you need from this feature in 1 year from now?
A small misunderstanding now, can cause a lot of additional working hours later.

The idea is that there can be more than 1 URL reference for datasets/training material (or other resources), no distinction between CLARIN and DARIAH
a separate 1:N table: external_resources
[<“label”,”URL”,”type”, “affiliation”>,..]

“label” is an open text describing the resource (optional)
“type”= Dataset, Training Material, Service, Software, …(optional)
“affiliation” = CLARIN, DARIAH, … (optional)
{label}/{URL}
{affiliation}{type}: {label}
{URL}

CLARIN Dataset: CLARIAH.NL corpus of child speech
https://clariah.nl/…

Link checking upon submission (optionally if little effort)
accept HTTP Status => 200 < 400

@IvdL22, @PixlTracer could you please provide at least three real world examples of such external resources according to the proposed data structure

@vronk @patrickakk @PixlTracer Matej, thanks for the technical solution.
Example
This is a course in the registry:
Puheen analyysin perusteet (Introduction to Speech Analysis)
“label” Introduction to Speech Analysis
“type”=Training Material
“affiliation” = CLARIN
{label}/{URL](https://www.clarin.eu/content/introduction-speech-analysis}
“label” Route to a Wing Corpus
“type”= Dataset
“affiliation” = FIN-CLARIN
{label}/{URL](http://urn.fi/urn:nbn:fi:lb-2020112929}
The same course also uses the CLARIN VLO to show students how to search for other corpora, so I could also add the service.

@IvdL22 @PixlTracer
cc @vronk
Thank you for providing one example. Would it be possible to provide the other two examples as well?
Could you include at least one example which uses DARIAH resources? And in general: include as much exceptions and complicated situations as possible?
@IvdL22
Could you also specify how the VLO should be added to the example you provided?

@patrickakk
cc @vronk @PixlTracer
Regarding the VLO, if a teacher is using a corpus found via the VLO, the labels will be the same:
“label” Nijmegen corpora of casual speech
“type”= Dataset
“affiliation” = CLARIAH-NL
{label}/{URL] https://hdl.handle.net/1839/2581a242-fde3-4349-ab06-4920a964803d
Regarding the DARIAH Campus: if a teacher is using a learning or training resource in the DH programme entered in the registry, the teacher should be able to add the link to the resource:
“label”Formal Ontologies: A Complete Novice's Guide
“type”=Training Material
“affiliation” = DARIAH CAMPUS
{label}/{URL] https://campus.dariah.eu/resource/posts/formal-ontologies-a-complete-novices-guide
Please let me know if some things are not clear. Thank you for your help.

@IvdL22
cc @PixlTracer @vronk
Thank you for the examples. Do you agree, when considering the specifications here:
https://github.com/acdh-oeaw/dhcr-main/issues/48#issuecomment-2167415842
that the affiliation in both last examples should be "CLARIN and "DARIAH" ?
Since according to :

“affiliation” = CLARIN, DARIAH, … (optional)

There are only two options for this value. The idea behind this was that a resource belongs either to CLARIN or to DARIAH (or there is an exception).
Is there a special reason for specifying this more detailed?
This is an important difference, please let me know if you think otherwise or have any questions.

@IvdL22
cc @PixlTracer
Thank you for the explanation and valuable insights. I was aware of the national consortia, but until now it's wasn't clear to me that you wanted to specify on that detail level.
Maybe situations like this are also a good example for everbody, why it is useful to ask for examples and ask such questions in this (early) stage of the development process?

Type of values
You also mentioned "course contributors should be free to fill..." To avoid any misunderstandings about that, I will start with describing that kind of input that was meant and as second step we could discuss the values.

[<“label”,”URL”,”type”, “affiliation”>,..]
“label” is an open text describing the resource (optional)
“type”= Dataset, Training Material, Service, Software, …(optional)
“affiliation” = CLARIN, DARIAH, … (optional)

Label will in the UI look like a text field, where the course contributor can enter a free chosen value. The field is optional.
Url will in the UI look like a text field, where the course contributor can enter a free chosen value. The field is mandatory.
Type will in the UI look like a drop-down menu with a list of pre-defined values. The field is optional.
Affiliation will also be a drop down menu with a pre-defines list of values. How else would you prevent pollution or similar items/duplicates? The field is optional.

Does that clarify a bit?

Kind of affiliation
As far as I understood, the idea was to let them choose from either CLARIN, DARIAH, or none.
Now you mentioned it should be possible to specify the  national consortia.
If we change this how should it be possible to answer for example the following questions, using the dataset:
-Which courses use a DARIAH resource?
-Which courses are in the german language and use a CLARIN resource?

A possible solution could be to define an affiliation parent type. Values for this could be DARIAH or CLARIN?
And define the national consortia as affiliation child types.
Are we sure that every national consortia belongs to only one parent type?
And of course this makes the implementation more complex, which means more working hours are needed.
On the other hand, the example provided by vronk shows something different:

CLARIN Dataset: CLARIAH.NL corpus of child speech
https://clariah.nl/…

affiliation = clarin
type = dataset
label = CLARIAH.NL corpus of child speech
Are we still all on the same page?
Is this understandable or should we discuss this in a (short) meeting?

@patrickakk , if the example by @vronk is clear and you know how to implement it, why do you ask me for more examples? :)
@vronk Matej, could you please help us move forward with this task? I provided examples but I am not able to clarify the specifications. Thank you :)

@IvdL22 To make sure that:
a) What we defined, matches what you need
b) To check if there are any misunderstandings
c) Making sure that we all have the same expectations
d) Avoid wasting valuable development hours, by checking those things before starting the work

have a flat list (modifiable by administrators)
allow multi-value
example:
affiliation: ['CLARIN', 'FIN-CLARIN']


[Bug]: Shopify dev fails for rust functions, CLI versions >3.70.0

Please confirm that you have:

[x] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[x] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Function, Extension
Expected behavior
Running npm run dev should in an app with Rust extensions, for example a Delivery Customization shoul work and deploy the working version in the development environment.
Actual behavior
Instead, an error shows in the console, even after successfully compiling the extension (cargo build, etc...):
Error while updating drafts: failed to compile WebAssembly module
I checked different CLI versions, and it works correctly until version 3.70.0.
Looking at the source code it looks like this is just what the DeveloperPlatformClient.updateExtension graphql mutation returns in userErrors:
https://github.com/Shopify/cli/blob/7d2f856437333f40513fb7de30a736600ab9ab4e/packages/app/src/cli/services/dev/update-extension.ts#L73
Verbose output

Verbose output
2024-12-04T14:01:03.142Z: Sending "Partners" GraphQL request:
mutation ExtensionUpdateDraft($apiKey: String!, $registrationId: ID!, $config: JSON!, $context: String, $handle: String) {
extensionUpdateDraft(
  input: {apiKey: $apiKey, registrationId: $registrationId, config: $config, context: $context, handle: $handle}
) {
  userErrors {
    field
    message
    __typename
  }
  __typename
}
}

With variables:
{
"apiKey": "*****",
"config": "{\"title\":\"pickup-points-generator\",\"module_id\":\"3f6107a7-c55e-478f-9d6d-2417c5bdac19\",\"app_key\":\"c75cba3cb6a52e5639ecd43df5854fdf\",\"api_version\":\"unstable\",\"ui\":{\"app_bridge\":{\"details_path\":\"/\",\"create_path\":\"/\"}},\"enable_creation_ui\":true,\"localization\":{},\"targets\":[{\"handle\":\"purchase.pickup-point-delivery-option-generator.fetch\",\"export\":\"fetch\",\"input_query\":\"query Input {\\n  deliveryAddress {\\n    countryCode\\n    longitude\\n    latitude\\n  }\\n}\\n\"},{\"handle\":\"purchase.pickup-point-delivery-option-generator.run\",\"export\":\"run\",\"input_query\":\"query Input {\\n  fetchResult {\\n    status\\n    body\\n  }\\n}\\n\"}],\"uploaded_files\":{\"dist/index.wasm\":\"QUdGemJRRUFBQUFCOG9HQWdBQWhZQUFBW....
"handle": "pickup-points-generator",
"context": "",
"registrationId": "748079939585"
}

With request headers:
- User-Agent: Shopify CLI; v=3.71.2
- Keep-Alive: timeout=30
- Sec-CH-UA-PLATFORM: darwin
- Content-Type: application/json

to https://partners.shopify.com/api/cli/graphql

Error while updating drafts: failed to compile WebAssembly module

Reproduction steps
Just run any of the documentation samples, for example https://shopify.dev/docs/apps/build/discounts/build-discount-function?extension=rust
Operating System
Mac OS Sonoma
Shopify CLI version (shopify --version)
@shopify/cli/3.71.2 darwin-arm64 node-v22.12.0
Shell
Zsh
Node version (run node -v if you're not sure)
v22.12.0
What language and version are you using in your application?
rustc 1.83.0 but I tried multiple old versions

Ok just 1 hour after opening this issue, the version 3.71.3 was released with a fix. That was fast!
Closing the issue, thanks.


[CODE] Vacuum mode for in memory caches

Periodic Scavenger task to keep ratio of active to tap items above some threshold. After last commit, Scavenger kicks in only when storage usage exceed some threshold. We need to run periodic vacuum cleaner which is independent of regular GC.
May be.

Done long time ago. Closed.


CANVAS-157 - Enable connection pooling for MongoDB

@chern Why does each job script setup its own MongoDB connection? I thought the purpose of a model was so that we can consolidate the code in one place so it can be shared wherever a database connect needs to be created.
Is it possible to use src/server/models/db.js in the job scripts?

@rlorenzo Good point, I should've realized that the code was being duplicated in too many places, instead of using the model


ListItemText with primary, secondary, secondaryTypographyProps does not display correctly

When using a ListItemText component with the fields primary, secondary, and specifically secondaryTypographyProps the text is not displayed properly inside of the ListItemText. The secondary prop once given secondaryTypographyProps is displayed at the end of the primary text instead of on its own row below.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
If a ListItemText component is given secondaryTypographyProps it will join the primary text on the first line.
Expected Behavior 🤔
It seems as you would want the secondary text to be allowed its secondaryTypographyProps and retain its position on the second row as it does without secondaryTypographyProps.
Steps to Reproduce 🕹
Here is a codesandbox of the recreation using the MUI template - but for clarity's sake, here is the snippet:
<List>
  <ListItem>
    <ListItemText
      primary="non working example"
      primaryTypographyProps={{ variant: "overline" }}
      secondary="improper secondary text"
      secondaryTypographyProps={{ variant: "overline" }}
    />
  </ListItem>
  <ListItem>
    <ListItemText
      primary="working example"
      primaryTypographyProps={{ variant: "overline" }}
      secondary="proper secondary text but cannot apply props"
    />
  </ListItem>
</List>

Here is a picture of the above code in action:

Steps:

Add a ListItemText component to a List
Add primary, secondary, and most importantly secondaryTypographyProps to the ListItemText

Not a step to reproduce, but could get the desired effect by applying
display: gird to .MuiListItemText-multiline. Not an expert though so not 100% sure that is the desired solution.
Context 🔦
I need to be able to style the secondary text in the ListItemText to achieve my desired ux.
Your Environment 🌎

Tech
Version

Material-UI
v4.8.0 (code sandbox using 4.9.5)

React
^16.12.0

Browser
Chrome, (reproducible in Edge)

TypeScript
no

This is due to the display changes we made in v4. Seems like a simple fix.
  if (primary != null && primary.type !== Typography && !disableTypography) {
    primary = (
      <Typography
        variant={dense ? 'body2' : 'body1'}
        className={classes.primary}
        component="span"
+       display="block"
        {...primaryTypographyProps}
      >
        {primary}
      </Typography>
    );
  }

if (secondary != null && secondary.type !== Typography && !disableTypography) {
    secondary = (
      <Typography
        variant="body2"
        className={classes.secondary}
        color="textSecondary"
+       display="block"
        {...secondaryTypographyProps}
      >
        {secondary}
      </Typography>
    );
  }

https://github.com/mui-org/material-ui/blob/89c0ed4468b2a703728f2d6279c8252fc2b7ef1b/packages/material-ui/src/ListItemText/ListItemText.js
@protzman Do you want to work on a pull-request?

Can I take this? Would be my first issue.

@psdr03 Sure :)


TASK [Ensure internet-monitoring environment is running.

I m getting this weird  error when trying to run the sensible-playbook main.yml
anf idea ?
TASK [Ensure internet-monitoring environment is running.] *******************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "cmd": "/usr/bin/docker --host unix:///var/run/docker.sock version --format '{{ json . }}'", "msg": "permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.46/version": dial unix /var/run/docker.sock: connect: permission denied", "rc": 1, "stderr": "permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.46/version": dial unix /var/run/docker.sock: connect: permission denied\n", "stderr_lines": ["permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.46/version": dial unix /var/run/docker.sock: connect: permission denied"], "stdout": "{"Client":{"Platform":{"Name":"Docker Engine - Community"},"Version":"27.0.3","ApiVersion":"1.46","DefaultAPIVersion":"1.46","GitCommit":"7d4bcd8","GoVersion":"go1.21.11","Os":"linux","Arch":"arm64","BuildTime":"Sat Jun 29 00:02:44 2024","Context":"default"},"Server":null}\n", "stdout_lines": ["{"Client":{"Platform":{"Name":"Docker Engine - Community"},"Version":"27.0.3","ApiVersion":"1.46","DefaultAPIVersion":"1.46","GitCommit":"7d4bcd8","GoVersion":"go1.21.11","Os":"linux","Arch":"arm64","BuildTime":"Sat Jun 29 00:02:44 2024","Context":"default"},"Server":null}"]}

I'm pretty sure you need to add new docker group and user to run it without root privilege.
take a look at this: https://docs.docker.com/engine/install/linux-postinstall/

I'm pretty sure you need to add new docker group and user to run it without root privilege.
take a look at this: https://docs.docker.com/engine/install/linux-postinstall/

The docker group was created automatically, but I did need to add my user to the group:
sudo usermod -g docker <username>


[WIP] Add SQL Directives

SQL directives for relation on table dependencies.
Need to handle the nested graphQL query results. (SQL Query executes, needs some handling with the GraphQL query)

FYI - Directives can be created for GraphQL type, but using them in SelectionSet in Build SQL   wasn't possible/accessible. So, used directives at the field level.

know I mentioned the description before, unless it is graphql specific let's not do this. Also, I would like to understand little more on directive vs comment, as directives are available everywhere pretty easily not sure that is case with description (maybe it is)

Directives have a lots of problems if you wish to process schema using them. If directive is used only to mark stuff on build annotation will be needed.
Generally in your case db dictates everything so there is no need to have directive or annotation (as we have all info about relations from database). Description can be used to inform users etc. and I think annotations here work better

Directives might have a lots of problems if we wish to process schema using them. If a directive is used only to mark elements on build time, the annotation will be easier

The description or annotation will force you to define a small DSL that will force you to write additional parsers etc. I feel directives are better to extend the metadata as GraphQL schema language allows them. However, I would like to know more about the issues they arise though. I feel they are designed to be used in this kind of situation.

Generally in our case db dictates everything so there is no need to have directive or annotation (as we have all info about relations from database).

Yes, agree DB has the details, however, IMO the schema should be self-reliant about what it is exposing from DB. When we develop a top-down approach these annotations or directives will help define to drive DDL that can be created, keeps both models decoupled. It is a separate issue consider in each scenario when a value is not supplied through directive/annotation what the default behaviour going to be.

Ok. No problem to use directive. We need to define them on top of the schema in order for schema to be valid.

Ok. No problem to use directive. We need to define them on top of the schema in order for schema to be valid.

It would be great if you could elaborate this as a small example.

https://www.graphql-java.com/documentation/v11/sdl-directives/

thanks for that link @wtrocki  From the examples, the one troubling part (which is Ok IMO) is directives are both being used as design-time metadata and also runtime metadata. for example, using sql directive we are planning on using one can change values at runtime too that will end up in error. I have not encountered a scenario where we would need that but it could be useful sometimes to send a hint on query planning.

Basic query execution with directives. Going ahead to merge into master.


feat: add support for one() on HasMany, MorphMany and HasManyThrough

[x] Added or updated tests
[ ] Documented user facing changes

Changes

Adds support for the one() methods on HasMany, MorphMany and HasManyThrough relationships as added to the framework.

Breaking changes
None.

Hi,
Thanks for the PR.
Since we support both Laravel 9.x and 10.x, we'd need a way to separate the stub files for different versions. You can read more about it here.
Also as you can see the tests are failing for 9.x Most probably because one method does not exists there. We need to yield the tests according to the Laravel version. An example can be seen here.

@canvural How is it possible to proceed with this PR?

We've closed the master branch. Please open a new pull request and target the 2.x branch if you wish to re-open this pull request.


Add example regular grid interpolator

Reference issue
Issue https://github.com/scipy/scipy/issues/16492
What does this implement/fix?
Add an example on RegularGridInterpolator  for data where coordinates are not sorted in ascending order
Additional information

I see, I was not aware of this was fixed in 1.9. You are right I dont think this example is needed. I let you cancel the PR?


Change the version of giganto-client from 0.1.0 to 0.2.0

-giganto-client의 PcapFilter 구조체의 변경(#297)에 따라 하위호환성이 깨지게 되어 giganto-client crate의 버전을 올립니다.
-추후 dependency bot을 통한 체크에 문제가 발생할 경우 별개의 repo구성을 고려하면 됩니다.
reference : https://github.com/aicers/hog/pull/355#issuecomment-1466657318

Codecov Report
Patch and project coverage have no change.

Comparison is base (49c6654) 78.00% compared to head (34b34ec) 78.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   78.00%   78.00%
=======================================
  Files          28       28
  Lines        4038     4038
=======================================
  Hits         3150     3150
  Misses        888      888

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

하위호환성이 깨질 때에는 giganto-client를 사용하는 다른 crate에서 참고할 수 있도록 CHANGELOG를 적어주세요.

@msk
CHANGELOG 작성 완료했습니다.


HMR only working for last instance

I currently have some style entry points with one module each. Each module goes through a loader that returns a URL, then goes through style/url to added a , but only the last entry point can accept and swap updates. The others say the page requires a reload. Weird setup, I know. There is also one commons chunk with the webpack runtime.
I can try testing this out in a more isolated environment, but let me know if anything looks wrong in the above that could cause this. Thanks!

You cannot have multiple webpack runtimes on a single page (or you need to provide alternative output.jsonpFunction and output.hotUpdateFunction).
And you cannot hot reload the entry point when having multiple entry points on a page.
Instead of doing entry: { a: "a", b: "b" } do entry: { a: ["a"], b: ["b"] }.

That last one was the problem, thanks so much!


Newly created datasource should be accessible be creator

Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if any
[X] I have reproduced the issue with at least the latest released version of superset
[X] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.22.1
Expected results
When user without all datasource access is creating datasource (using visualize button in SQL Lab) the datasource should be accessible to this user.
Actual results
This endpoint requires the datasource test-hadoop-Untitled Query 2-HJG51B-DUf, database or `all_datasource_access` permission
You do not have permissions to access the datasource(s): test-hadoop-Untitled Query 2-HJG51B-DUf.

Steps to reproduce

Create user with Gamma and sql_lab roles
Run query in SQL Lab
Click Visualize button then Visualize
Watch No Access! page

I don't really know how to fix this bug. I see two options.

Datasources are always accessible by owner (using check_ownership)
But this makes a lot of changes in code
We're creating one special role per user for situations like that.

What do you think ?

see https://github.com/apache/incubator-superset/issues/2798

Thank for pointing that.
I think we have really mess with permission and I don't know how this should work.

I tried replicating this error as I'm currently doing some permissions cleanup but I was unable to run queries despite having sql_lab permissions.
how were you able to run the query?

How to solve it? Help, please.

@timifasubaa you need to have Gamma + SQL Lab + some sort of database, schema, or table permission


[Compat] crash with Automated Crafting

I'm the dev of Automated Crafting which just had this issue opened.
I'm pretty sure it's because automated crafting has a CraftingInventory with an (unused) CraftingScreenHandler with a null player, and Cardinal Components tries to access the null player.
I can't think of a decent solution to this other than adding a null check in cardinal components, but I'm open to suggestions.

This is an issue with Requiem, not CCA.

oh, thanks


cross frame sortables not working with forceFallback option

You can quickly see the problem here:
https://output.jsbin.com/wehafa
The draggable ghost does not appear to be able to enter the sortable within the iframe, basically gets "stuck".
Does not appear to work with the last release (1.4.2) or current dev branch.
Removing "forceFallback" option makes the jsbin work as expected.

Yes it is. It works only with native support for D'n'D.

Any plans for that to change? Is there any limitations preventing it from working elsewhere?
Just curious, I do not need this feature.

Sorry, autocorrect got the last part of the first comment:
Are there any limitations preventing it from working in the future?

No, too many nuances.


Ignore timestamps and file order inside ZIP inputs

We could ignore timestamps and file order for ZIP (and TAR and whatnot) inputs, just like we do for @Classpaths (see https://github.com/gradle/build-cache/issues/440).

This is one of the things we can get from the Maven implementation.


IEvents.ReadPLog should use IAppStorage.Get when 1 log item is requested

Is your feature request related to a problem? Please describe.
ReadPLog always reads with IAppStorage.Read
Describe the solution you'd like
Due to performance reasons, I'd expect ReadPLog reads log with IAppStorage.Get when toReadCount is 1

complette


Column-review. Suggestion for illustrating column metadata

This address two problems:

User experiments show that people find it a bit confusing that column metadata is displayed as rows.
@lwjohnst86 wanted to show preview data (how does the data look after inferred types)

Based on @K-Beicher's work, I have styled two suggestions.
1# Suggestion

When the edit button is clicked for one of the columns, then a dialog opens:

Problems:

We will need to add horizontal scrolling, when several columns are added
It requires more clicks to fill description. We might help the user a bit by adding a button "Next column" in the dialog

2# Suggestion

Problems:

We will need to add horizontal scrolling, when several columns are added

Hmm, I really like that "grid table" style! Instead of scrolling horiztonally, what about having a responsive grid table style, like 4 items per row of a grid? Like in your suggestion #2?

Yes, that is a great idea and I would love to play more with it, but I wanted to make sure that it is the correct path?

@lwjohnst86 #2 is not updated where the columns go to the next line

Which issue are you referring to? #2 is about login and authentication.

I believe #2 here is talking about the second option, not the issue?

Yes, I meant the second suggestion :) But I also found pretty confusing spelling error in my comment which is corrected ('not' should have been 'now'). The second suggestion is now updated, with your proposal.


Use prepacked artifacts for npm publish and finalize

This will prevent the publish and finalize steps from
installing dependencies with secrets access, and ensure that
projects without a package-lock won't end up with different
dependency versions when publishing.
Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>Resolves: https://github.com/product-os/flowzone/issues/190

I just realized that I'm setting the full draft version in package.json during build/test and I'm not updating it to the final version during finalize. I want to avoid unpacking the tarball though...


Unable to Generate IPA file and preview on iphone

Command /bin/sh failed with exit code 1

DEST=/Users/spalagani/Library/Developer/Xcode/DerivedData/topups-dbyhlheboyiseocaqmpsephakjjr/Build/Products/Debug-iphoneos/topups.app
node /Users/spalagani/Documents/reachapp/topups/node_modules/react-native/local-cli/cli.js bundle --entry-file index.ios.js --platform ios --dev true --bundle-output /Users/spalagani/Library/Developer/Xcode/DerivedData/topups-dbyhlheboyiseocaqmpsephakjjr/Build/Products/Debug-iphoneos/topups.app/main.jsbundle --assets-dest /Users/spalagani/Library/Developer/Xcode/DerivedData/topups-dbyhlheboyiseocaqmpsephakjjr/Build/Products/Debug-iphoneos/topups.app
bundle: Created ReactPackager
uncaught error Error: Error: Uncaught error in the transformer worker: /Users/spalagani/Documents/reachapp/topups/node_modules/react-native/packager/transformer.js
at index.js:164:37
at tryCallOne (/Users/spalagani/Documents/reachapp/topups/node_modules/promise/lib/core.js:37:12)
at /Users/spalagani/Documents/reachapp/topups/node_modules/promise/lib/core.js:123:15
at flush (/Users/spalagani/Documents/reachapp/topups/node_modules/asap/raw.js:50:29)
at doNTCallback0 (node.js:407:9)
at process._tickCallback (node.js:336:13)
See logs /var/folders/25/6553ppd52cvbjj_wgzz614mc38yd3s/T/react-packager.log
at SocketClient._handleMessage (SocketClient.js:144:23)
at BunserBuf. (SocketClient.js:53:42)
at emitOne (events.js:77:13)
at BunserBuf.emit (events.js:169:7)
at BunserBuf.process (/Users/spalagani/Documents/reachapp/topups/node_modules/bser/index.js:289:10)
at /Users/spalagani/Documents/reachapp/topups/node_modules/bser/index.js:244:12
at doNTCallback0 (node.js:407:9)
at process._tickCallback (node.js:336:13)
Command /bin/sh failed with exit code 1

@facebook-github-bot stack-overflow


More in-depth testing

As mentioned in the meeting, our unit tests tend to focus on the correctness of the results, but we do not check what the GUI shows for the corresponding CommandResult or error.
When doing testing for a specific command, try to exhaust the equivalence partitions (either based on the existing unit tests, or from your own creativity), and if you happen to find some new cases, do add them to the unit tests.
Ideally we should test every single command, but I have listed here the non-trivial ones that should definitely get tested:

[ ] AddCommand
[ ] DeleteCommand
[ ] EditCommand
[ ] FindCommand
[ ] HelpCommand (somewhat trivial but it accepts params so there is still something to test)
[ ] Saving and loading (try to be an adversarial user and manually edit the data file)

Others that we may want to add issues for are listed below. These are probably trivial enough

[ ] ClearCommand
[ ] ExitCommand
[ ] ListCommand

Possible points for discussion:

Should we test for the value of the CommandResult inside our unit tests?


Remove consultation summary for ldc applications

Story Link
https://trello.com/c/We1OUjeM/2537-consultations-arent-created-for-ldcs-but-we-still-have-consultation-summary

Do we want to remove it? I thought they needed a way to summarise if anyone had written in about the LDC.

Could we add a test that tries to click on that link? Somehow that kept on passing even though it was completely broken

Now that i've properly set up the ldc application without a consultation, the spec will fail without the @consultation&.consultees&.present? change


feat(languageSelector): create component

Create component
What does this PR do?

Resolve #225

Steps to test

Run yarn storybook
Check changes

Now:

CheckList

[X] Follow proper Markdown format
[X] Content is available in all languages
[X] The content is adequate
[X] I Ran a spell check
[X] I included test coverage

Please delete unused imports


New version: JetBrains.GoLand version 2023.3.1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @PckgrBot

Current manifest version 2023.3 has 2 parameters, which is less than this PR's version number 2023.3.1's 3 parameters.

Is this intentional?


Captivate Prime widget not rendering in AEM Cloud

Expected Behaviour
Actual Behaviour
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

Incomplete issue description, hence closing.


Adding annotated test sets for NQ, TriviaQA and WebQ datasets

This is the annotated ODQA dataset for the paper "Challenges in Generalization in Open Domain Question Answering" (https://github.com/likicode/QA-generalize).
I created three directories containing each dataset individually:

datasets/natural_questions_comp_gen
datasets/triviaqa_comp_gen
datasets/webquestion_comp_gen

Unfinished:
There is one example system outputs for explanaboard under datasets/natural_questions_comp_gen. I don't know how to handle the cases where each test example is associated with three labels (overlap / comp_gen / novel_entity). Please help! : )

"I don't know how to handle the cases where each test example is associated with three labels (overlap / comp_gen / novel_entity). Please help! : )"

Hi, thanks for the PR. I will take a look.


ADS: Replace all Button / MaterialButton with our own Component

Task/Issue URL:  https://app.asana.com/0/1174433894299346/1202861107912487
Description
This PR replaces all the Button / Material Buttons in the code with the new Android Components
Steps to test this PR
Usual app smoke test

Thanks @joshliebe!


Unable to run on Python 2.7.11

I installed tldr.py using pip install tldr.py on Python 2.7.11, but the compiled version doesn't appear to work for me.
~
❯ pip2 install tldr.py
Collecting tldr.py
  Using cached tldr.py-0.2.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): click>=5.0 in ./.pyenv/versions/2.7.11/lib/python2.7/site-packages (from tldr.py)
Requirement already satisfied (use --upgrade to upgrade): PyYAML>=3.11 in ./.pyenv/versions/2.7.11/lib/python2.7/site-packages (from tldr.py)
Installing collected packages: tldr.py
Successfully installed tldr.py-0.2.0

# I tried running the uncompiled binary using `pip install -e .` after cloning the repo
~
❯ tldr
Traceback (most recent call last):
  File "/Users/jjwon/.pyenv/versions/2.7.11/bin/tldr", line 9, in <module>
    load_entry_point('tldr.py==0.2.0', 'console_scripts', 'tldr')()
  File "/Users/jjwon/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pkg_resources/__init__.py", line 558, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/Users/jjwon/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2682, in load_entry_point
    return ep.load()
  File "/Users/jjwon/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2355, in load
    return self.resolve()
  File "/Users/jjwon/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2361, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ImportError: No module named cli

It works on my computer with Python 2.7.10, Python 3.4, but not this version.

Hi, I'm also using pyenv with python 2.7.11, works for me here, my environment is Linux Mint 17.1
➜  ~  which tldr
/home/lord63/.pyenv/shims/tldr
➜  ~  python --version
Python 2.7.11
➜  ~  tldr
Usage: tldr [OPTIONS] COMMAND [ARGS]...

  A python client for tldr: simplified and community-driven man pages.

Options:
  -V, --version  Show the version and exit.
  -h, --help     Show this message and exit.

Commands:
  find    Find the command usage.
  init    Init config file.
  update  Update to the latest pages.

So I can't reproduce this problem. Uninstall and install it again works?

Resolved after reinstalling my pyenv environment.  Something must have gotten corrupted, probably pip somehow.  Should have guessed it was a configuration bug since the error seemed pretty suspicious.
Cheers!


Implement statistic pad mode in jax.numpy.pad

Implemented maximum, mean, median, and minimum padding modes.
Related #5010

@jakevdp Thank you for your kind review.
I updated PR. Please take a look :)

Nice tips. Thank you!
I made some improvement. PTAL :)

OK, so there are a number of issues that came up in more comprehensive testing:

passing stat_length=() for mode in (median, min, max) results in ValueError: zero-size array to reduction operation minimum which has no identity. It might be that an error is expected in this case: I'm not sure. But we need to shore-up the tests for this either way.
with dtype=bool, stat_length=2 and mode='mean', there are differences on TPU (possibly because of differences in how 0.5 is converted to boolean, but I'm not certain). I think it would be fine to leave boolean dtypes out of these tests... computing means of booleans is not particularly well defined anyway.

Would you mind taking a look at those? Thanks!

Removed stat_length=() from tests since numpy gave me the same error message.
Removed calculating mean of booleans. I considered leaving whole boolean type out of tests, but computing others might be OK since boolean can act like integer. https://docs.python.org/3/library/stdtypes.html#boolean-values

OK, I'll check the tests again.
Last thing: can you please squash all the commits to a single commit and force-push to this branch? If that's not something you're comfortable doing, I can walk you through it or take care of it for you. Thanks!

Squashed it into single commit. 👍

Thanks! Tests look good – I'll work on getting this merged!

We have some internal test failures that I believe would be remedied by syncing to master and force-pushing to this branch. Are you comfortable doing that?

Syncing to master worked! Thanks.


cannot apply migrations in sql azure

Hi,
I have a a dbcontext with 3 tables in a library project, that is used by an application:in my web app I created without problems the migration (the initial migration), the migration class and the snapshot source files are in the project.
If I try to run the command dnx ef migrations list I have received the messag
No migrations were found,  and if I try to update the db via dnx command I see that the the migration history table is created but the migration is not applied.
running in verbose I see
dnx ef database update -v
Finding DbContext classes...
Using context 'LibraryContext'.
Using database 'xxx' on server 'tcp:yyydatabase.windows.net,1433'.
Done.

If I try to specify the migration name I obtain
The migration ... was not found.
Am I missing something?

This is really messy in RC1 and we've made some improvements to help you get it right in RC2. What you probably need to do is add a call to MigrationsAssembly in OnConfiguring to let EF know where to find the migrations. The issue is that the tooling knows where to drop new migrations (the project you are executing the command on), but it isn't as smart about where to find them when applying migrations.
protected override void OnConfiguring(DbContextOptionsBuilder options)
{
    options.UseSqlServer(...).MigrationsAssembly("<assembly name>");
}

Like I said, this all gets a lot better in RC2, but let me know if this solves the issue for you for the moment.

Feel free to reopen if this doesn't solve your problem.


Include uuid syntax for the subscriber-operation attribute for the service /v1/notify-link-updates

As per the specification , the reserved uuid syntax for the operationName in the subscriber-operation is
<own application abbreviation>-<release-number-of-own-separated-by-hypens>-op-c-is-<application abbreviation>-<release-number-separated-by-hypens>-000 ` for ‘regard-application’

Create a OperationClient if not available. Update the OperationClient configuration if the client is already available.

As per decision made on issue https://github.com/openBackhaul/ApplicationLayerTopology/issues/231, pattern uuid for /v1/notify-link-updates needs an update.
<own application abbreviation>-<release-number-of-own-separated-by-hypens>-op-c-is-<application abbreviation>-<release-number-separated-by-hypens>-002 ` for ‘regard-application’

This issue is closed with changes in pull request https://github.com/openBackhaul/ApplicationLayerTopology/pull/251

The mentioned pull request does not fix the issue. Nor does any other. I can still see the old UUID in the mapping file on develop branch.


Description fields in Projects and Namespaces are not shown

Version: master
UI: v2.0.62
Create a Project or Namespace and click Add a description, Save.
Description is not shown in any listing.

Version - 2.0 master 7/23
Verified fixed


perf(fragment): added multicore support for fragment server

affects: tessellate-fragment
tessellate-fragment does not scale vertically at all.
Many EC2 instances provide multiple CPUs, but we get no benefit from that. Added multicore support using node js cluster library.
ISSUES CLOSED: #70

Coverage decreased (-2.0%) to 77.423% when pulling c36cf646c00acf77522fef5a3543b6b68319aa87 on multicore-support into 68e0a1994c720fe0406f2ab52cc9220eabe6701e on master.

Coverage decreased (-2.0%) to 77.423% when pulling c36cf646c00acf77522fef5a3543b6b68319aa87 on multicore-support into 68e0a1994c720fe0406f2ab52cc9220eabe6701e on master.


VFPT-like Unused Declaration and Symbol graying

The Visual F# Power Tools featured automatic 'graying' of unused open declarations and unused symbols. (Although unused opens wasn't 100% reliable).
I think this would be a great feature to port over to the main extension.

FYI @vasily-kirichenko, there are two issues I've found with the VFPT unused open feature:

Type aliases were not considered, so if you had an open just for a type alias, the open would be marked as unused.
If SomeNamespace cannot be opened due to a missing reference (e.g. a C# type extension exists in SomeNamespace for a type that is defined in an assembly not referenced by the current F# project), then open SomeNamespace.SubNamespace would always be marked as unused.  I'm not too worried about this issue as I've already worked around it by putting the C# type extensions from the referenced project in the same namespace as the types they are extending.

I'm against porting the old VFPT code. It's too inefficient and, in case of graying out opens, is inherently unreliable. We should reimplement it from scratch, on lower level.

@vasily-kirichenko any inkling as to where it would need to be reimplemented?  Perhaps it could surface as a lightbulb codefix?  I'm not sure how tied to ISymbol the Roslyn code is, but perhaps there's some stuff that could be ported over as well.

I'm not talking about the UI part, it's obviously need to be rewritten, but it's the easy part. I meant the actual algorithm. In VFPT I found all private and internal declarations in a file, then called for each one GetUsesOfSymbolInProject, which is not super efficient as we have to iterate all resolution in a project as many times as we have private declarations in a file, see https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/NameResolution.fs#L1372. Maybe that's not a big deal, but quadratic complexity is not a very good thing in general.
What about graying out unused opens, the implementation is hacky and unreliable and I was fixing it many times and I don't like to go this track one more time. Maybe later, when I know the compiler and the service better, I will re-implement it the right way, but not now.

Sounds perfectly reasonable 👍

@vasily-kirichenko just to be clear, are you saying that you don't think greying unused opens is worth it? And that greying unused symbols is worth the effort/is reliable (I've found it to be reliable in 2015 at least)

@saul Yes, graying unused private and internal symbols is reliable and simple, but not very efficient, I'm looking at it now. But unused opens...


Move entries from oeo.omn to oeo-shared #1408

Summary of the discussion
Clean up file oeo.omn
Type of change (CHANGELOG.md)
Move everything that is not needed for oeo.omn itself to oeo-shared.
Workflow checklist
Automation
Closes #1408
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

You also remove stuff from oeo-model, why? And you shift BFO classes from oeo.omn to oeo-shared, although they should be imported from the bfo there directly. Is that intended? Couldn't they just be removed?
Can you please document more detailed and also update the changelog.

You also remove stuff from oeo-model, why?

This was done automatically by Protégé, maybe because it came redundant?

And you shift BFO classes from oeo.omn to oeo-shared, although they should be imported from the bfo there directly. Is that intended? Couldn't they just be removed?

I am not sure if these could be removed entirely. But I will test.

Can you please document more detailed and also update the changelog.

We once decided that changes like this do not come into the changelog as the classes themselves are not affected, only the file where they are stored. But I'll make an entry in the changelog now.

And you shift BFO classes from oeo.omn to oeo-shared, although they should be imported from the bfo there directly. Is that intended? Couldn't they just be removed?

I am not sure if these could be removed entirely. But I will test.

Okay, I removed all except one BFO references, the one remaining has an additional axiom:
Class: <http://purl.obolibrary.org/obo/BFO_0000009>

    SubClassOf:
        OEO_00140002 some OEO_00020143

Which is the axiom 'two-dimensional spatial region' 'has quantity value' some 'area value'. Should I move this axiom to oeo-import-edits.owl?

And you shift BFO classes from oeo.omn to oeo-shared, although they should be imported from the bfo there directly. Is that intended? Couldn't they just be removed?

I am not sure if these could be removed entirely. But I will test.

Okay, I removed all except one BFO references, the one remaining has an additional axiom:
Class: <http://purl.obolibrary.org/obo/BFO_0000009>

    SubClassOf:
        OEO_00140002 some OEO_00020143

Which is the axiom 'two-dimensional spatial region' 'has quantity value' some 'area value'. Should I move this axiom to oeo-import-edits.owl?

I think that is the cleanest way to go.

I moved the axiom 'two-dimensional spatial region' 'has quantity value' some 'area value' to oeo-import-edits.owl.
While doing so, Protégé reincluded all the BFO classes back into oeo-shared. It seems it needs these statements there. See commit 9fb4b3530da6a4464017cb39859707afb5c47bdb.


Make enemy notification more interesting

There could be variation in the " encountered!" message at the beginning of a battle to add flavour to the game.
If there's no objections, I'd like to implement this.

Sure. Keep in mind the encounter message shouldn't be too long since it's only on screen for < 1s.

Closed by #76


add storybook coverage exclude entries

Description
Storybook stories can be considered test, especially with the storybook test plugin for vitest in the works, they are converted into test files.
When enabling coverage in that scenario, it's undesired to have the story files count for measuring coverage.
Therefore is useful for those files to be excluded.
It would be possible for vitest users to configure this, however we think it could be useful to add this to the default set of coverage exclude patterns inside of vitest itself.
More context here:
https://github.com/storybookjs/storybook/issues/29613
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

We are considering removing all non-Vitest related defaults from coverage.exclude, see:

https://github.com/vitest-dev/vitest/issues/6956


GDScript: Limit recursion depth for completion functions

Avoid crashing if the completion gets stuck in infinite recursion while trying to guess the expression type.
Fix #71446
This adds an error message when it happens but perhaps it is a valid way to bail out in corner cases like the one in the linked issue, so we might consider removing the message if it gets triggered too often.

Thanks!

Is this in 4.2.2?
When I crash the project window via recursion like this there's no error to be seen:
var run_size = 3500
var count = 0
func recur():
	count+=1
	print(count)
	if count >= run_size:
		return "x"

	var x = recur()
	return x

# Called when the node enters the scene tree for the first time.
func _ready():
	var x = recur()
	print(x)

I am also wondering what the limit on recursion is? It seems to crash somewhere past 300.

It works fine here on Linux with 4.2.2-stable:

@akien-mga
Can you test it on windows?

@KnightNine I had two users check on rocket.chat and they both seem the same that I see, the debugger is properly catching the recursion and reporting it.
Are you running the project in the editor? Or exported with a release binary? The latter might crash, but a release export should only be made if you've made sure your project runs without errors in the debugger.
By the way, your issue is unrelated to this PR, which fixed a crash in the GDScript completion code.

Here's what I see in Windows 11:

@akien-mga weird. ( yes. I am running it with the editor.) It works now when testing it with the official build. I don't thing I've done something to exclude this update when rebasing my local changes atop 4.2.2 because the crash happens before even the 1024 limit is triggered. 🤔
I'll need to test some things further.

So I gather you're doing a custom build with MSVC? If so that's probably why it doesn't work.
Could you open a dedicated bug report? Again, your issue is not related to this PR, which fixed a specific problem in the code completion, not running a project with recursion. Guards for infinite recursion were added years ago.

@akien-mga do certain things not work properly when compiled with scons on windows? is the official build compiled differently?
My issue isn't really not having guards against infinite recursion when it crashes at around 300-500 iterations of a recursive loop in this custom build... It's not related to this PR directly, I was just confused why my code wasn't even reaching the depth limit.
Maybe I didn't rebase it properly somehow idk, I have to look into it more to narrow down what the exact issue is.

do certain things not work properly when compiled with scons on windows? is the official build compiled differently?

Official builds are made with MinGW-GCC, i.e. using the GNU GCC compiler.
You can also use it on Windows, but if your C++ compilation setup is Visual Studio / MSVC, that's what is used by default on Windows for custom builds.
Different compilers can different behaviors for similar configuration, or in this case they might have different config for the stack size between MSVC and GCC/Clang, which may cause this issue.

Maybe I shouldn't post this here but I was just thinking about how to circumvent the depth limit while still using a recursive function, it seems that depth is not preserved when a signal calls back to a lesser depth. So I made this loop that takes the recursive function and repeats it every 100 iterations while still preserving the parameters of the recursive function in case it's useful to anyone that comes here with a similar issue:
var run_size = 100
var total_run_size = 3500

signal x(local_count)
var last_x = null
var is_awaiting_x = false

#signal result_found()
#var last_result
func non_recur_loop():
	#last_result = "continue"
	var looping = true
	while looping:
		var local_count
		if last_x == null:
			is_awaiting_x = true
			local_count = await x
			is_awaiting_x = false
		else:
			local_count = last_x
		last_x = null

		if looping:

			var last_result = await recur(local_count)
			if last_result != "continue":
				looping = false
				return last_result

func pass_to_non_recur_loop(local_count):
	last_x = local_count
	if is_awaiting_x:
		emit_signal("x",local_count)

func recur(local_count = 0):

	print(local_count)

	if local_count >= total_run_size:
		return "x"
	if local_count >= run_size:
		pass_to_non_recur_loop(local_count+1)
		return "continue"
	else:
		var x = await recur(local_count+1)
		return x

# Called when the node enters the scene tree for the first time.
func _ready():
	print("---")
	pass_to_non_recur_loop(0)
	var x = await non_recur_loop()
	#stop loop:
	print(x)
	OS.alert(x)


Enable to download

Due an error of "relpath is undefined" on JS Console.

Thanks for the PR DOTzX!


Field error not displaying in dynamic form

Description
I believe I've found a bug in the API with forms when the number of form elements changes. Below is a reproduction. When you type one character into the error input, the error doesn't appear at first until you type a second character. It appears that adding the Form.Description element dynamically interferes with the error prop displaying correctly.
Steps To Reproduce

macOS v12.6.6
Raycast v1.53.2

Reproduction
const [error, setError] = useState("");

return (
  <Form>
    {error && <Form.Description title="Summary" text={error} />}
    <Form.TextField
      id="error1"
      title="Error 1"
      value={error}
      onChange={setError}
    />
    <Form.TextField
      id="error2"
      title="Error 2"
      value={error}
      onChange={setError}
      error={error}
    />
  </Form>
);

Current Behaviour
Typing one character in the error box does not show the error next to the "error2" field until you type a second character.
Expected Behaviour
Typing one character in the error box should show the error next to the "error2" field, even though the Form.Description element is added.

Thanks for flagging this, should be fixed in the next release 🙂

I'm still seeing this issue after updating to v1.53.3. Did the bug fix make it into that release?

This seems to work now in v1.54.0. Thanks for the fix!


Remove the authorization check from IdentityResourceDefintion

Identity manipulation could quite likely be against an identity that does not have permission to authenticate yet,

I am not sure this is really required, identity manipulation I would expect to be against a specific realm.


How to most accurately determine blocking_applications for Munki recipes

Right now %NAME%.app is our sole blocking application when creating Munki recipes. However, if we encountered other apps in our travels (specifically while running inspect_pkg()) I think those apps should also be included by default.

I think some data on this would be helpful.


chore: Update Graalvm version in GitHub workflows

Alignment with backend PR https://github.com/KaotoIO/kaoto-backend/pull/731

I have tried workflow here https://github.com/mkralik3/kaoto-ui/actions/runs/5507487256/jobs/10037584661


Adding basic time predictions graph page

Motivation
Show how accurate the MBTA time predictions are over time
Changes

Testing Instructions

I plan to add an information section describing the data, but, in the meantime, the rest is ready for review

Is there a way we could default this to one number?
I was imagining a series of checkboxes below the graph for each bucket. By default, all are selected and we show the aggregate data.
Then if a user wants to see only certain buckets they can select one or more of the buckets. But the graph would always show one line.
What do you think?

@PatrickCleary
https://github.com/transitmatters/t-performance-dash/assets/9310513/5beda044-19e2-4310-826d-f8850d7e76d0
I like it

Okay this is now ready for review again 😄
Would love to get any other feedback needed to get this in


Push Failing After Upgrade

Summary
This morning I created a new Scratch and issued a sfdx force:source:push command to populate with my metadata, it all worked.
This afternoon after VS Updated and I ran SFDX Update it throws errors for the same push into a fresh Scratch.
As it says on my screen - It looks like this is your first time opening an issue in this project and i am getting started.
Steps To Reproduce:
Create a New Scratch org
issues SFDX force:source:push command
Expected result
This morning it would work through the push and push 1035 pieces of metadata in a single pass.
Actual result
It seems to pick the first package directory in sfdx-project.json and try to push that first - 1 component
It then picks the second package directory in sfdx-project.json and try to that - 835 components.
It fails with message Check the order of your dependencies and ensure all metadata is included even though NOTHING has changed except the upgrade.
It appears to be segmenting the push rather than consolidating before push and failing because dependencies are not in order.
Additional information
Feel free to attach a screenshot.
sfdx-cli/7.65.2-0f0403b8cc win32-x64 node-v10.21.0
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.0.1 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.7.10 (core)
@oclif/plugin-update 1.3.10 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-diff 0.0.6
@salesforce/sfdx-trust 3.0.7 (core)
analytics 1.12.0 (core)
generator 1.1.3 (core)
salesforcedx 48.22.1
├─ salesforcedx-templates 48.18.0
├─ @salesforce/sfdx-plugin-lwc-test 0.1.5
├─ custom-metadata 1.0.5
└─ salesforce-alm 48.23.0
sfdx-cli 7.65.2 (core)
Windows 10

https://github.com/forcedotcom/cli/issues/379

Same Issue here.

Same here. I've moved all of the cross-dependent items into my main folder, yet still at least one lib that has no other cross deps failed to deploy in right order.
The use of packageDirectories was really convenient, especially when uploading into packaging org.
Is there better workaround other than moving folders around via bash for uploading into packaging?

@CXCAlfo sounds like you will need to change the order of your packages in your project.json file. We now explicitly support multiple packages defined in the same SFDX project but this requires you to order your package directories in the project.json, please see our documentation https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_ws_mpd.htm?search_text=multiple. Thank you for reaching out.


Respect data template for ItemsControl container generation.

Is your feature request related to a problem? Please describe.
I see many users complain about setting container   styles according to data, for example, setting listboxitem background according to data. This can be achieved by setting ItemContainerTheme with properties bind to datacontext, however this is not intuitive, and not friendly to compiled binding especially when designing new collection controls for displaying complex data.
Describe the solution you'd like
Add a new bool property like "UseItemTemplateForContainer", false by default. If this is set to true, then items will be built with ItemTemplate first, and then go through the process of checking if itself is container, and do the container generation/preparation. In this way, we can use ListBoxItem directly as root of ItemItemplate, without making a listboxitem inside another listboxitem. And it will have no impact on existing code.
Describe alternatives you've considered
Additional context

FWIW, WinUI supports this implicitly. Newer controls like the TabView create the DataTemplate as a TabItem which is then used as a container, which is something I completely forgot about in the discussion around the new items control. Granted they don't have the hierarchy of DataTemplates to search here so I think a property to control it is reasonable.

FWIW, WinUI supports this implicitly. Newer controls like the TabView create the DataTemplate as a TabItem which is then used as a container, which is something I completely forgot about in the discussion around the new items control. Granted they don't have the hierarchy of DataTemplates to search here so I think a property to control it is reasonable.

Something similar to this property in WPF? I think the Menu and StatusBar are the only controls that has a property for this purpose too.


FAIL: test_syr_her (test_blas.TestFBLAS2Simple) on Windows python2.7.9 32 bit scipy0.15.0 numpy0.19.1

remark : zero failure on python3.4.2 32/64bit and python2.7.9 64 bit windows
Running unit tests for scipy
NumPy version 1.9.1
NumPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-2.7.9\lib\site-packages\numpy
SciPy version 0.15.0
SciPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-2.7.9\lib\site-packages\scipy
Python version 2.7.9 (default, Dec 10 2014, 12:24:55) [MSC v.1500 32 bit (Intel)]
nose version 1.3.4
...

======================================================================
FAIL: test_syr_her (test_blas.TestFBLAS2Simple)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-2.7.9\lib\site-packages\scipy\linalg\tests\test_blas.py", line 321, in test_syr_her
    assert_(a is b)
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-2.7.9\lib\site-packages\numpy\testing\utils.py", line 53, in assert_
    raise AssertionError(smsg)
AssertionError

----------------------------------------------------------------------
Ran 17001 tests in 529.021s

FAILED (KNOWNFAIL=96, SKIP=1194, failures=1)

The test appears incorrect --- it's not guaranteed that a is b here.

np.may_share_memory(a, b)?

a and b can be separate arrays, since it's f2py intent(in,out) and not
intent(inout).

It makes me wonder how to force f2py to actually overwrite that array if owning its own data, being aligned and of fortran order isn't enough.  This seems a lot like numpy/numpy#5365.
I've made a pr that removes these a is b asserts.

ah, two FAIL  on python3.3.5 64 bit scipy0.15.0 numpy0.19.1
>>> import scipy;scipy.test()
Running unit tests for scipy
NumPy version 1.9.1
NumPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy
SciPy version 0.15.0
SciPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy
Python version 3.3.5 (v3.3.5:62cf4e77f785, Mar  9 2014, 10:37:12) [MSC v.1600 32 bit (Intel)]
nose version 1.3.4

....
======================================================================
FAIL: test_her2 (test_blas.TestFBLAS2Simple)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy\linalg\tests\test_blas.py", line 440, in test_her2
    assert_(a is b)
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy\testing\utils.py", line 53, in assert_
    raise AssertionError(smsg)
AssertionError

======================================================================
FAIL: test_syr_her (test_blas.TestFBLAS2Simple)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy\linalg\tests\test_blas.py", line 321, in test_syr_her
    assert_(a is b)
  File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy\testing\utils.py", line 53, in assert_
    raise AssertionError(smsg)
AssertionError

----------------------------------------------------------------------
Ran 16842 tests in 612.338s

FAILED (KNOWNFAIL=97, SKIP=1184, failures=2)
<nose.result.TextTestResult run=16842 errors=0 failures=2>

Those lines are also indicate failed overwrites of complex arrays.  Also
captured by the PR in #4413.
On Fri, Jan 16, 2015 at 12:21 PM, stonebig<EMAIL_ADDRESS>wrote:

ah, two FAIL on python3.3.5 64 bit scipy0.15.0 numpy0.19.1

import scipy;scipy.test()
Running unit tests for scipy
NumPy version 1.9.1
NumPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy
SciPy version 0.15.0
SciPy is installed in D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy
Python version 3.3.5 (v3.3.5:62cf4e77f785, Mar  9 2014, 10:37:12) [MSC v.1600 32 bit (Intel)]
nose version 1.3.4

....
======================================================================
FAIL: test_her2 (test_blas.TestFBLAS2Simple)
Traceback (most recent call last):
File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy\linalg\tests\test_blas.py", line 440, in test_her2
assert_(a is b)
File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy\testing\utils.py", line 53, in assert_
raise AssertionError(smsg)
AssertionError
======================================================================
FAIL: test_syr_her (test_blas.TestFBLAS2Simple)
Traceback (most recent call last):
File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\scipy\linalg\tests\test_blas.py", line 321, in test_syr_her
assert_(a is b)
File "D:\result_tests\WinPython-32bit-<IP_ADDRESS>\python-3.3.5\lib\site-packages\numpy\testing\utils.py", line 53, in assert_
raise AssertionError(smsg)
AssertionError

Ran 16842 tests in 612.338s
FAILED (KNOWNFAIL=97, SKIP=1184, failures=2)
<nose.result.TextTestResult run=16842 errors=0 failures=2>
—
Reply to this email directly or view it on GitHub
https://github.com/scipy/scipy/issues/4410#issuecomment-70288379.

thanks !


MimeType incorrectly determined from URL if querystring present

MimeType is incorrectly determined if a querystring exists on the url, eg "switchcam.com/test.mp3?auth=x". Issue is in mejs.HtmlMediaElementShim.getTypeFromFile() which uses
var ext = url.substring(url.lastIndexOf('.') + 1);

So the ext has the querystring attached. Then in getTypeFromExtension() it returns the entire extension, resulting in a failing mimetype of
audio/mp3?auth=x

(NOTE: workaround is to manually specify the "type" parameter during mediaelementplayer initialization)

@chartley Closing this issue since code has changed a lot and that line doesn't exist anymore


KAFKA-16215; KAFKA-16178: Fix member not rejoining after error

This fixes a bug that was causing that members wouldn't rejoin the group after receiving an error in the heartbeat response (ex. fenced, not coordinator, as reported in KAFKA-16215 and KAFKA-16178). The issue was that when receiving a response with error, the response receive time was not being updated, so following heartbeat would be skipped, considering that there was already a previous one inflight.
Tests updated to cover this.

Hey @dajac , this fixes the issue we were discussing about the 2 console consumers fenced but never rejoining. This same bug was surely behind the other issue, of consumer not rejoining after re-discovering a coordinator.

Hey @dajac , I updated this to ensure we record a failed attempt for all errors in HB. That will effectively update the received time and backoff, with the ability to skip backoff (0 backoff) in some specific errors where the next HB depends on other conditions (coordinator discovered, assignment released) and we won't add any extra backoff to that.

Thanks for the feedback @dajac! Comments addressed

Build broken with unrelated scala compilation failures being fixed already. I'll rebase as soon as the fix https://github.com/apache/kafka/pull/15343 goes in.


[BUG] The quantization error is particularly high for the opt-125M model.

Describe the bug
I downloaded the opt-125m weight file from huggingface-cli download facebook/opt-125m on huggingface(which is https://huggingface.co/facebook/opt-125m/).
Then make quantization model using autogptq, as follows:
from transformers import AutoTokenizer, TextGenerationPipeline
from auto_gptq import AutoGPTQForCausalLM, BaseQuantizeConfig
import logging

logging.basicConfig(
    format="%(asctime)s %(levelname)s [%(name)s] %(message)s", level=logging.INFO, datefmt="%Y-%m-%d %H:%M:%S"
)

pretrained_model_dir = '/datas/opt-125m'
quantized_model_dir = '/datas/opt-125m-gptq'

tokenizer = AutoTokenizer.from_pretrained(pretrained_model_dir, use_fast=True)

examples = [
    tokenizer(
        "auto-gptq is an easy-to-use model quantization library with user-friendly apis, based on GPTQ algorithm."
    )
]

quantize_config = BaseQuantizeConfig(
    bits=4,  # quantize model to 4-bit
    group_size=128,  # it is recommended to set the value to 128
    desc_act=False,  # set to False can significantly speed up inference but the perplexity may slightly bad
)

# load un-quantized model, by default, the model will always be loaded into CPU memory
model = AutoGPTQForCausalLM.from_pretrained(pretrained_model_dir, quantize_config)

# quantize model, the examples should be list of dict whose keys can only be "input_ids" and "attention_mask"
model.quantize(examples)

# save quantized model
model.save_quantized(quantized_model_dir)

tokenizer.save_pretrained(quantized_model_dir)

print(f'Model is quantized and saved at "{quantized_model_dir}"')

Then I use:
python examples/benchmark/perplexity.py \
    --model_name /datas/opt-125m-gptq \
    --model_basename gptq_model-4bit-128g \
    --is_quantized

to test on wikitext2, and the PPL was particularly high

Is that normal?

PS: for OPT-1.3B, the PPL of wikitext2 is 4382.3822.

Use http//github.com/modelcloud/gptqmodel and increase calibration set to min 256 rows of data of sufficient length. Your code you ran is sample demo code only.