[#Wave-Control: Add NetSuite]: Top-level Subsidiary selection

Details

Covers the implementation of Top-level subsidiary config page.
This is one of the first FE PRs for NetSuite without the proper auth flow integrated. Hence, to get this working we'll need to have a few pre-requisites:

Collect workspace with accounting enabled.
NetSuite beta enabled for the user.  You can return true in the canUseNetSuiteIntegration method.
Setup the netsuite data linked in the comment here for the given workspace as connections: {netsuite: <linkedjson>}.

One way I did the setup is calling Onyx.merge with useEffect on any FE component.
   useEffect(() => {
       Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}76A10AB364F95DA0`, {"connections":{"netsuite":{"accountID":"TSTDRV1668486", ....})
   }, []);

Fixed Issues

$ https://github.com/Expensify/App/issues/43435
PROPOSAL:
Tests

Open the app with the pre-setup workspace.
Go to Accounting from the LHS
Verify that you're able to see Net Suite in the active connections along with the Oracle NetSuite logo.
Verify that you're able to see the Subsidiary list item below NetSuite title along with the subsidiary listed as  Honeycomb Mfg. (based on the test data imported)
Click on the item, and see that it opens the list of subsidiaries in RHS.
Confirm the title and the description of the screen.
Click on one of the subsidiaries.
It should take you back to the Accounting screen, with subsidiary listed based on the selection in step 7.

[x] Verify that no errors appear in the JS console

Offline tests

Open the app with the pre-setup workspace.

Verify that you're able to see Net Suite in the active connections along with the Oracle NetSuite logo.
Verify that you're able to see the Subsidiary list item below NetSuite title along with the subsidiary listed as  Honeycomb Mfg. (based on the test data imported)
Click on the item, and see that it opens the list of subsidiaries in RHS.
Confirm the title and the description of the screen.
Click on one of the subsidiaries.
It should take you back to the Accounting screen, with subsidiary listed based on the selection in step 8 but in grey disabled color.

QA Steps

Same as Test Steps. Additionally do a sanity on list pages such as Report, Search that the list and scroll behavior is not impacted.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3069065/ad39eca8-242a-4c3b-8032-7c050728ce04

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/ad25cf64-4e4b-4d14-920e-612a18b5f8c2

iOS: Native
https://github.com/Expensify/App/assets/3069065/8d01e600-c922-4180-a998-737873813d9b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/795e2512-8104-4ac4-8c87-91134583f7a6

MacOS: Chrome / Safari
Basic Test
https://github.com/Expensify/App/assets/3069065/d9e539e5-ba39-4397-8cb9-7062caacdc7b
Offline Behavior
https://github.com/Expensify/App/assets/3069065/bde3e1fe-e3cb-480c-b56c-208a261b4987
Web Spanish Translation

Error handling
https://github.com/Expensify/App/assets/3069065/1759ccb2-f42a-4368-987a-c53984e360da

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/cbd6ae31-40ae-403f-b1da-79bf3f64e69d

@shubham1206agra The PR is WIP. I'll ask for the review once it's ready.

@shubham1206agra @yuwenmemon The PR is now ready for review.
@Expensify/design Would love to get your feedback. Especially on the error scenario. I am not sure where should the error message should up. In the Accounting page or Subsidiary. In Subsidiary too if the user has selected an option at the bottom of the page, they won't see the error at the top.

@Expensify/design Would love to get your feedback. Especially on the error scenario. I am not sure where should the error message should up. In the Accounting page or Subsidiary. In Subsidiary too if the user has selected an option at the bottom of the page, they won't see the error at the top.

What's shown in your video seems pretty right to me... @shawnborton @dubielzyk-expensify any other ideas how we'd treat this? I don't really know what to do about the case where there's a long list and the user has one selected down towards the bottom.

Hmm yeah, I agree with Danny - I think what you have works? Any additional thoughts @trjExpensify?
How exactly is this kind of error triggered in the first place?

How exactly is this kind of error triggered in the first place?

API error.

What's the API error for, when it comes to the subsidiary selection?

What's the API error for, when it comes to the subsidiary selection?

Wouldn't be 100% sure, a safe guard. Could be any API failure.

@shubham1206agra @yuwenmemon This is ready for the next pass of the review. Can we close this on priority? It is blocking other PR work.

The console error seems unrelated to changes in this one. I'll first fix the SelectionScreen as I am at the airport. If time permits I'll try to fix the console.error.

Revised screencasts with SelectionScreen.
Web Also contains empty screen screenshot.
https://github.com/Expensify/App/assets/3069065/04812fc7-00f3-48ba-8d83-0f49f48bc899
iOS: Doesn't have the console.error so I removed the SelectionList prop that I added for nested view.
https://github.com/Expensify/App/assets/3069065/2d7dcf1c-53a0-4bac-b34a-ff17eff4af40

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Kotlin DSL documentation for IDE support should be updated with Kotlin 1.4 enhancements

With the IntelliJ Kotlin plugin 1.4, the documentation available at https://docs.gradle.org/nightly/userguide/kotlin_dsl.html#sec:ide_support is now out of date.
See https://kotlinlang.org/docs/reference/whatsnew14.html#improved-gradlekts-support-in-the-ide
Expected Behavior
Documentation matches user experience with the IntelliJ Kotlin plugin 1.4
Current Behavior
Documentation is out of date

Issue is still valid.


Add cwise_op_pow to iOS makefile

This fixes issue #5990.
It has been tested and works.

Can one of the admins verify this patch?

Jenkins, test this please.

Tests tainted by unrelated breakage, but the important ones looks good.


Optimised graphics card recognition and half-precision recognition

The torch itself recognises obsolete graphics drivers, so there is no need to restrict older cards.
Requiring graphics memory greater than or equal to 5.5G (that is, 6G or more, but the actual available memory will be 5.98G, etc., so write 5.5G for insurance) will exclude most old cards.
The config directly determines that the CUDA computing power is less than 7.0 and can identify cards that don't support fp16, no need to whitelist them.

The only problem is as stated in issue #808, it is not recommended to use MPS for training on MacOS.

The only problem is as stated in issue #808, it is not recommended to use MPS for training on MacOS.

Already modified

怎么Merge了个寂寞(),Files Changed 0


Replace deprecated cli-ux with oclif/core

cli-ux library has been deprecated in favour of oclif/core: https://github.com/oclif/core/blob/main/src/cli-ux/README.md
Acceptance criteria: No warning messages running rush rebuild

Actually, the acceptance criteria should be no warnings after npm install in squid-template.
I believe oclif/core itself is problematic, not only cli-ux.

Hey! I'd like to take this. Just a question: should I be making changes in the squid or squid-template repo? The PR is in squid but "the acceptance criteria should be no warnings after npm install in squid-template."


Spike: simplify route declarations for employer form

Context
We have a fairly well established pattern for how our routes/controllers are structured for the employer form. This is probably a good time to refactor the route declarations so they're more condensed and easier to scan.
This also potentially has implications for how we structure the public form work. If we go down the path of entirely separate routes/controllers for the second form, it'll be important to keep the routes.rb manageable.

Changes proposed in this pull request
Use other routing methods to define nearly the same resources.
For each section:

Controller names are unchanged
Path helpers for edit/update change slightly
The URL for the edit page has /edit appended

I've applied this change to a subset of routes to illustrate the idea. If the consensus is 👍🏼 then I'll apply to the remaining ~140 lines worth of referral routes.

Guidance to review

Link to Trello card

Checklist

[ ] Attach to Trello card
[ ] Rebased main
[ ] Cleaned commit history
[ ] Tested by running locally

Agree this is cleaner, good we're retaining the section level directory structure.

Will raise a new PR when this is ready to review


Fixed unused variable warining.

https://github.com/arut/nginx-rtmp-module/commit/c56fd73def3eb407155ecebc28af84ea83dc99e5

Im getting error about unused variable, and cant compile it as standalone module. With this commit it does build.

Thank you for reporting the bug, fixed.


docs: Remove paragraph about getting help finding issues in contributing guide.

Removes a paragraph about posting in the #new members stream to get help finding issues to work on from the first contribution part of the contributing guide.
Also updates the remaining section about posting to #new members as a way to introduce yourself with a link to the community norms and offering positive feedback as well as constructive criticism.
See relevant CZO conversation for more context.

Screenshots and screen captures:

Updated "Picking an issue to work on" section
Current documentation

Updated "Your first codebase contribution" intro
Current documentation

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks good to me!

Yeah, it's been a long time since we had capacity to answer this sort of question.


Modify router tests to work with HyperShift

Fixes: https://github.com/cloud-bulldozer/e2e-benchmarking/issues/487
Signed-off-by: Sai Sindhur Malleni<EMAIL_ADDRESS>Description
This modifies the router tests to work with HyperShift Hosted Clusters since some of the control plane components (openshift-ingress-operator/openshift-cluster-version-operator) do not exist on the hsoted cluster and instead exist on a management cluster.
Fixes

First part works correctly but by the end of the scrip it fails again, it is necessary to check again in this lines: https://github.com/cloud-bulldozer/e2e-benchmarking/pull/495/files#diff-88112b993948b739e6f3469b2cc02d704e1ad5c42932086bfe397b2c3b4a7a55R179-R183

Can you paste what part fails? Not sure I caught that.

@smalleni Just nitbit and optional, an easiest way to switch KUBECONFIG by passing it in the CLI itself will over ride env value, so can avoid updating env variable again and again.
ex:
oc scale --replicas=1 -n "${NAMESPACE}" deploy/cluster-version-operator --kubeconfig ${HYPERSHIFT_MANAGEMENT_KUBECONFIG}

@mukrishn @dry923 can we merge this now?


9/27/2022 Publish

Docs Build status updates of commit 2522a3c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

docs-ref-autogen/azure-iot-provisioning-device/ProvisioningDeviceClient.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/active-directory.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/analysis-services.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/api-for-fhir.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/api-management.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/app-configuration.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/appcontainers.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/application-insights.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/app-platform.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/appservice.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/app-service.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-compute-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-logic-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-netapp-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/authorization.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/azureadexternalidentities.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/azure-confidential-ledger.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/azure-stack.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/batch-ai.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/bot-service.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/changeanalysis.md
:warning:Warning
View (azure-node-latest)
Details

This comment lists only the first 25 files in the pull request.

<EMAIL_ADDRESS>
Line 239, Column 62: [Warning: xref-not-found] Cross reference not found: 'attestationType'.
Line 243, Column 11: [Warning: xref-not-found] Cross reference not found: 'signingKey'.
Line 281, Column 60: [Warning: xref-not-found] Cross reference not found: 'attestationType'.
Line 283, Column 11: [Warning: xref-not-found] Cross reference not found: 'signingKey'.

<EMAIL_ADDRESS>
Line 37, Column 8: [Warning: xref-not-found] Cross reference not found: 'TracingSpanContext'.

<EMAIL_ADDRESS>
Line 39, Column 55: [Warning: xref-not-found] Cross reference not found: 'TracingSpanContext'.

docs-ref-autogen/azure-iot-provisioning-device/ProvisioningDeviceClient.yml

Line 50, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device-http.Http'.
Line 51, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device-amqp.Amqp'.
Line 52, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device-amqp.AmqpWs'.
Line 53, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device-mqtt.Mqtt'.
Line 54, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device-mqtt.MqttWs'.
Line 62, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device:X509SecurityClient'.
Line 63, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device:TpmSecurityClient'.
Line 64, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device:SymmetricKeySecurityClient'.
Line 66, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-security-x509.X509Security'.
Line 67, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-security-tpm.TpmSecurityClient'.
Line 68, Column 26: [Warning: xref-not-found] Cross reference not found: 'azure-iot-security-symmetric-key.SymmetricKeySecurityClient'.
Line 71, Column 47: [Warning: xref-not-found] Cross reference not found: 'azure-iot-provisioning-device:RegistrationClient'.

docs-ref-autogen/toc.yml

Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found<EMAIL_ADDRESS>Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found: 'microsoft-cognitiveservices-speech-sdk.request'.

docs-ref-services/latest/active-directory.md

Line 8, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'activedirectory'.
Line 17, Column 211: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/reference-v2-libraries' will be broken in isolated environments. Replace with a relative link.
Line 17, Column 343: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/graph/overview' will be broken in isolated environments. Replace with a relative link.
Line 20, Column 38: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/sample-v2-code' will be broken in isolated environments. Replace with a relative link.
Line 21, Column 26: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/msal-compare-msal-js-and-adal-js' will be broken in isolated environments. Replace with a relative link.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


babe: Disable unused median calculation

The median calculation that is done to figure out at what time the current slot should start (i.e. offset) is currently not properly implemented. Since it is currently unused I have removed the call from verify to it to avoid any issues. I have also fixed an issue that caused it to panic.
Fixes #3248.

I have also removed annoying forbid/deny clauses.

Reverted removal of forbid/deny clauses to avoid conflicting with #3213.

@DemiMarie-parity https://github.com/paritytech/substrate/pull/3251/commits/a18036507785277a6ab644a0e0bf3cebdca3da3b (see #3248 as well).


Score board  top 3 size

Top 3 div is squished on mobile landscape and clips the bottom items

fixed with overflow-y-scroll


Added init file for sql storage; Update mapping for dnssec

I've added the missing sql file to initialize the mysql database of the sql storage backend and updated the README for sql users. An example configuration for sql storage was added for convenience.
I updated the mapping file to store the dnssec key data information (flag, algorithm id and key data) separately.

Good job, thanks. Tests passed except 1.4.2 Go version. I think it should be increased up to 1.8.X


Update README.md

fixed incorrect (exchanged) matching between pyjet and numpythia descriptions

Well spotted and thanks for making the PR 👍


UAT | Testing with an Actual Case | Witness name is Compulsory

Describe the bug
Witness name need not be compulsory - can substitute with designation. E.g a bank manager may change during the course of proceedings - them being a witness here links to designation
To Reproduce
Steps to reproduce the behavior:

Go to 'File a Case' and in that 'Witness Details'

Expected behavior
Ability to record designation of witness instead of name
Desktop (please complete the following information):

OS: [e.g. Windows]
Browser [Chrome]

Hi @deeshita ,
About this issue either of first name ,middle name, last name  has to be compulsory . This has been implemented as per agreement with @devarajd94 and team.
Thanks.
cc @Ramu-kandimalla

Please refer to #1505

Change the Field name from 'Name' to 'Name/Designation'. Please take this up in next sprint

Hi @devarajd94
attaching below the reference of the screen . We have 3 input field for name and changing  either with text 'Name/Designation' won't be meaningful . Hence unable to pick it up for now
cc:- @anirudh-0 @Ramu-kandimalla

Yes, a witness as an org is a change.

Since its new feature and have huge scope we are not taking issue in this sprint once scope is finalizes PM can create new ticket


Fix typo in argument usage in promptToRenameBuffer

Was seeing an issue where renaming a file and then reloading it would throw a pretty gnarly error. Tracked it down to this typo, which seems to fix it.
Related issue: https://github.com/scrooloose/nerdtree/issues/622

Excellent, thanks :)


MEGSIM is unrealiable

http://cobre.mrn.org/megsim/ keeps breaking our CricleCI. We mock it for the testing in #6453 but our CircleCI in master is completely random due to the fetching.
Could we mirror it?

Briefly, the issue is that MRN thought no one was using it, and it was hosted externally, so they took it down to save on the hosting costs.  Ideally they'll resurrect it at the same address, since the published manuscript also points to that URL.  That said, if you have an easy way to mirror it, that might still be a good idea.
I'm affiliated with MRN, not just randomly butting in. :)

we could put it on osf.io

MRN thought no one was using it

If this is the case, maybe they are right. Perhaps we should just remove the dataset, especially given the progress we have made on making the simulation module more usable.

no strong feeling here. It's true that little people have actually used
these data in the last years

I'll make a PR to remove it. We are early in the release cycle so if it gets reuploaded somewhere we can easily revert the commit


Consider unique constraint on user_id and name

I feel there is a benefit to adding a unique constraint across the columns user_id and name.
Currently users can create multiple tokens with the same name, meaning differentiating between them at a later date would be impossible as the key is only to be shown once.

Duplicate of https://github.com/laravel/airlock/issues/25


Add instructions for how to do a release.

@mjbrender you're the one with the basholabs puppet forge account credentials, so can you test these instructions and see if we can do an initial release?

Great timing @danieldreier

@danieldreier email coming -- I'll let you take it from here on getting it to Forge. My env is a mess.


app crached every time opened

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
the app keep crash when try to open it
Code sample
import flet as ft
def main(page: ft.Page):
def check_item_clicked(e):
e.control.checked = not e.control.checked
page.update()
page.appbar = ft.AppBar(
    leading=ft.Icon(ft.Icons.PALETTE),
    leading_width=40,
    title=ft.Text("AppBar Example"),
    center_title=False,
    bgcolor=ft.Colors.SURFACE_VARIANT,
    actions=[
        ft.IconButton(ft.Icons.WB_SUNNY_OUTLINED),
        ft.IconButton(ft.Icons.FILTER_3),
        ft.PopupMenuButton(
            items=[
                ft.PopupMenuItem(text="Item 1"),
                ft.PopupMenuItem(),  # divider
                ft.PopupMenuItem(
                    text="Checked item", checked=False, on_click=check_item_clicked
                ),
            ]
        ),
    ],
)
page.add(ft.Text("Body!"))

ft.app(main)
To reproduce
run app
Expected behavior
No response
Screenshots / Videos

Captures
[Upload media here]

Operating System
Windows
Operating system details
Windows 10
Flet version
0.25.1
Regression
No, it isn't
Suggestions
No response
Logs
Logs
[Paste your logs here]

Additional details
No response

Please provide details on the type of app. (apk, windows exe, ..)

yes its an apk

A packaged app? If yes, for which platform did you package? Can you share a video capture?

https://github.com/user-attachments/assets/d3032a8a-943c-429c-9733-019e7738c8ee

the logs

the error fixed by add meta data gms.ads.application id but after that app block in spalch screen

What command do you use to build the apk and what requirements do you have in pyproject.toml?

command : flet build apk -v
requirements pyproject.toml :
[project]
name = "tastyfit"
version = "0.1.0"
description = ""
readme = "README.md"
requires-python = ">=3.8"
dependencies = [
"flet==0.25.1",
"bs4",
"requests"
]
#[tool.flet.android.meta_data]
#"com.google.android.gms.ads.APPLICATION_ID" = "ca-app-#pub-3202390806346245~4632644573"
[tool.flet]
org name in reverse domain name notation, e.g. "com.mycompany".
Combined with project.name to build bundle ID for iOS and Android apps
org = "com.tastyfit"
project display name that is used as an app title on Android and iOS home screens,
shown in window titles and about app dialogs on desktop.
product = "tastyfit"
company name to display in about app dialogs
company = "tastyFitCompany"
copyright text to display in about app dialogs
copyright = "Copyright (C) 2024 by Tastyfit"
[tool.flet.flutter.dependencies]
flet_lottie  = "0.25.1"
flet_audio = "0.25.1"
flet_permission_handler = "0.25.1"
#flet_ads = "0.25.1"
[tool.flet.android.permission] # --android-permissions
"android.permission.INTERNET" = true
"android.permission.ACCESS_NETWORK_STATE" = true
[tool.flet.app]
path = "src"

What command do you use to build the apk and what requirements do you have in pyproject.toml?

the app work fin when i remove flet ads and when add it its block yhe app in spalsh screen


Improve setup script

Make it like homebrew does:
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"

Or zsh ;)
https://github.com/robbyrussell/oh-my-zsh#basic-installation
It's better for us because we do not use ruby.

What do you think if will keep shell? I propose to do something like this:
sh -c "$(curl -fsSL https://raw.github.com/robbyrussell/oh-my-zsh/master/tools/install.sh)"

Yeah, right! :+1:

It is the best solution imo


(bug): Clipper errors out on some Internet Archive directory pages

Hey there,
I'm not entirely sure how broadly the clipper should support the web but I noticed some instances where it crashes rather than displaying the expected message that it can't parse the page content.
Specifically some of the Internet Archive's directory pages such as https://archive.org/download/spotify-v-<IP_ADDRESS>2-latest.
Some of them parse fine with others display An error occurred: t.childNodes[a].getAttribute is not a function.
I don't actually have any use case for clipping these pages to be clear, I actually happened to accidentally trigger the extension and thought the error was a little unexpected so you might be interested to know about it.
Thanks!

This should be fixed in 0.4.9

Very nice. Thanks!


tabStyle changing width and padding

I have many tabs in page. So, the title each tab's difference long. So, the wide of tab is similar, I'm not ability to change it.
Although, I'm using tabStyle property, changed (width and padding), but it's not effect it.
How to change the width of tab1 is difference other?

@phatnguyenbg try changing width of both tabStyle and activeTabStyle of <Tab/>.

I'm trying but seem it's not changed :(,
I find out this props:
heading={ Camera}
it solved my above problem, but these props below seem not great :(

now text title none active @@

@phatnguyenbg tabStyle, activeTabStyle, textStyle, activeTextStyle are useful in the normal case where heading is just a string. If you are defining heading using <TabHeading/>, you have to handle the  styles based on selection.

why can't i set padding for tab heading? i set padding to 1  and it was not working. Please help!


Docker daemon crashes during docker load

Im trying to preload some docker images (410MB gzipped tarball) as part of docker host build process  (executed inside KVM VM) - which means that Im running docker daemon in Anaconda installer kickstart post-install chroot stage with limited network setup (no docker networking - just to load images over http).
Docker daemon is run inside chroot with the following options
DOCKER_STORAGE_OPTIONS="-s devicemapper --storage-opt dm.fs=xfs --storage-opt dm.thinpooldev=/dev/mapper/atomicos-docker--pool"
DOCKER_NETWORK_OPTIONS="--ip-forward=false --iptables=false"
docker -d $DOCKER_STORAGE_OPTIONS $DOCKER_NETWORK_OPTIONS &

Images are preloaded like this:
curl -L http://<IP_ADDRESS>:8000/docker-images.tar.gz | gzip -cd | docker load

If loading small tarball - like 5-10MB - it works ok. Problems start with larger tarballs (mine is 410MB).
Docker daemon crashes while trying to load larger images tarball:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0INFO[0030] POST /v1.18/images/load
                                                                                INFO[0030] +job load()
 10  416M   10 45.1M    0     0  12.3M      0  0:00:33  0:00:03  0:00:30 12.3Munexpected fault address 0x651e90
fatal error: fault
[signal 0xb code=0x2 addr=0x651e90 pc=0x651e90]

goroutine 11 [running]:
runtime.gothrow(0xbf0a10, 0x5)
        /usr/lib/golang/src/runtime/panic.go:503 +0x8e fp=0xc2080f7938 sp=0xc2080f7920
runtime.sigpanic()
        /usr/lib/golang/src/runtime/sigpanic_unix.go:29 +0x265 fp=0xc2080f7988 sp=0xc2080f7938
bufio.(*Writer).Write(0xc20807c340, 0xc20807c3c0, 0x6, 0x40, 0x1, 0x1, 0xc2080ce660)
        /usr/lib/golang/src/bufio/bufio.go:556 fp=0xc2080f7990 sp=0xc2080f7988
fmt.Fprintf(0x7f179dea70a8, 0xc20807c340, 0xbd9670, 0x4, 0xc2080f7a50, 0x1, 0x1, 0x46501b, 0x0, 0x0)
        /usr/lib/golang/src/fmt/print.go:189 +0xac fp=0xc2080f79d8 sp=0xc2080f7990
net/http/internal.(*chunkedWriter).Write(0xc2080aa8f0, 0xc2080c2000, 0x8000, 0x8000, 0x8000, 0x0, 0x0)
        /usr/lib/golang/src/net/http/internal/chunked.go:166 +0x16d fp=0xc2080f7a80 sp=0xc2080f79d8
io.Copy(0x7f179dea7228, 0xc2080aa8f0, 0x7f179dea7148, 0xc2080ad680, 0x7538000, 0x0, 0x0)
        /usr/lib/golang/src/io/io.go:364 +0x278 fp=0xc2080f7b38 sp=0xc2080f7a80
net/http.(*transferWriter).WriteBody(0xc208090af0, 0x7f179dea70a8, 0xc20807c340, 0x0, 0x0)
        /usr/lib/golang/src/net/http/transfer.go:207 +0x226 fp=0xc2080f7cc8 sp=0xc2080f7b38
net/http.(*Request).write(0xc208112000, 0x7f179dea70a8, 0xc20807c340, 0x7f179dea7000, 0x0, 0x0, 0x0)
        /usr/lib/golang/src/net/http/request.go:448 +0xada fp=0xc2080f7e70 sp=0xc2080f7cc8
net/http.(*persistConn).writeLoop(0xc2080a7810)
        /usr/lib/golang/src/net/http/transport.go:951 +0x28d fp=0xc2080f7fd8 sp=0xc2080f7e70
runtime.goexit()
        /usr/lib/golang/src/runtime/asm_amd64.s:2232 +0x1 fp=0xc2080f7fe0 sp=0xc2080f7fd8
created by net/http.(*Transport).dialConn
        /usr/lib/golang/src/net/http/transport.go:661 +0xcbc

goroutine 1 [select]:
net/http.(*persistConn).roundTrip(0xc2080a7810, 0xc2080aa800, 0x0, 0x0, 0x0)
        /usr/lib/golang/src/net/http/transport.go:1082 +0x7ad
net/http.(*Transport).RoundTrip(0xc208060360, 0xc208112000, 0xc20810d1a0, 0x0, 0x0)
        /usr/lib/golang/src/net/http/transport.go:235 +0x558
net/http.send(0xc208112000, 0x7f179dea5118, 0xc208060360, 0x2d, 0x0, 0x0)
        /usr/lib/golang/src/net/http/client.go:219 +0x4fc
net/http.(*Client).send(0xc20810d170, 0xc208112000, 0x2d, 0x0, 0x0)
        /usr/lib/golang/src/net/http/client.go:142 +0x15b
net/http.(*Client).doFollowingRedirects(0xc20810d170, 0xc208112000, 0xd8a280, 0x0, 0x0, 0x0)
        /usr/lib/golang/src/net/http/client.go:367 +0xb25
net/http.(*Client).Do(0xc20810d170, 0xc208112000, 0xc208060360, 0x0, 0x0)
        /usr/lib/golang/src/net/http/client.go:177 +0x192
github.com/docker/docker/api/client.(*DockerCli).clientRequest(0xc2080625a0, 0xbe4630, 0x4, 0xc0a330, 0xc, 0x7f179dea4f20, 0xc20802c000, 0x0, 0x0, 0x0, ...)
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/_build/src/github.com/docker/docker/api/client/utils.go:81 +0x7a6
github.com/docker/docker/api/client.(*DockerCli).streamHelper(0xc2080625a0, 0xbe4630, 0x4, 0xc0a330, 0xc, 0x1, 0x7f179dea4f20, 0xc20802c000, 0x7f179dea4ea8, 0xc20802c008, ...)
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/_build/src/github.com/docker/docker/api/client/utils.go:178 +0xa6
github.com/docker/docker/api/client.(*DockerCli).stream(0xc2080625a0, 0xbe4630, 0x4, 0xc0a330, 0xc, 0x7f179dea4f20, 0xc20802c000, 0x7f179dea4ea8, 0xc20802c008, 0x0, ...)
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/_build/src/github.com/docker/docker/api/client/utils.go:174 +0xd1
github.com/docker/docker/api/client.(*DockerCli).CmdLoad(0xc2080625a0, 0xc20800a010, 0x0, 0x0, 0x0, 0x0)
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/_build/src/github.com/docker/docker/api/client/commands.go:2665 +0x417
reflect.callMethod(0xc20810d050, 0xc208151b18)
        /usr/lib/golang/src/reflect/value.go:605 +0x179
reflect.methodValueCall(0xc20800a010, 0x0, 0x0, 0x1, 0xc20810d050, 0xc208062601, 0xc208060360, 0x4, 0x4, 0x7f179de98001, ...)
        /usr/lib/golang/src/reflect/asm_amd64.s:29 +0x36
github.com/docker/docker/api/client.(*DockerCli).Cmd(0xc2080625a0, 0xc20800a010, 0x1, 0x1, 0x0, 0x0)
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/_build/src/github.com/docker/docker/api/client/cli.go:81 +0x37e
main.main()
        /builddir/build/BUILD/docker-ba1f6c3a8973725dcc97298aecb367ad5498955b/docker/docker.go:143 +0xec2

goroutine 5 [syscall]:
os/signal.loop()
        /usr/lib/golang/src/os/signal/signal_unix.go:21 +0x1f
created by os/signal.init·1
        /usr/lib/golang/src/os/signal/signal_unix.go:27 +0x35

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /usr/lib/golang/src/runtime/asm_amd64.s:2232 +0x1

goroutine 10 [IO wait]:
net.(*pollDesc).Wait(0xc208090ae0, 0x72, 0x0, 0x0)
        /usr/lib/golang/src/net/fd_poll_runtime.go:84 +0x47
net.(*pollDesc).WaitRead(0xc208090ae0, 0x0, 0x0)
        /usr/lib/golang/src/net/fd_poll_runtime.go:89 +0x43
net.(*netFD).Read(0xc208090a80, 0xc20800f000, 0x1000, 0x1000, 0x0, 0x7f179dea4f70, 0xc2080aa858)
        /usr/lib/golang/src/net/fd_unix.go:242 +0x40f
net.(*conn).Read(0xc20802c340, 0xc20800f000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
        /usr/lib/golang/src/net/net.go:121 +0xdc
net/http.noteEOFReader.Read(0x7f179dea7030, 0xc20802c340, 0xc2080a7868, 0xc20800f000, 0x1000, 0x1000, 0x7f179de93010, 0x0, 0x0)
        /usr/lib/golang/src/net/http/transport.go:1270 +0x6e
net/http.(*noteEOFReader).Read(0xc2080ad580, 0xc20800f000, 0x1000, 0x1000, 0xc207ffd3cb, 0x0, 0x0)
        <autogenerated>:125 +0xd4
bufio.(*Reader).fill(0xc208030720)
        /usr/lib/golang/src/bufio/bufio.go:97 +0x1ce
bufio.(*Reader).Peek(0xc208030720, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/lib/golang/src/bufio/bufio.go:132 +0xf0
net/http.(*persistConn).readLoop(0xc2080a7810)
        /usr/lib/golang/src/net/http/transport.go:842 +0xa4
created by net/http.(*Transport).dialConn
        /usr/lib/golang/src/net/http/transport.goUntar exit status 1 unexpected EOF
                                                                                :660 +0xc9f
 11  416M   11 47.0M    0     0  11.5M      0  0:00:36  0:00:04  0:00:32 11.5M
curl: (23) Failed writing body (3360 != 16384)
[anaconda root@localhost /]# INFO[0034] -job load() = ERR (1)
                                                                                ERRO[0034] Handler for POST /images/load returned error: Untar exit status 1 unexpected EOF
                                                                                ERRO[0034] HTTP Error: statusCode=500 Untar exit status 1 unexpected EOF

Docker info:
[anaconda root@localhost /]# docker info
INFO[0558] GET /v1.18/info
INFO[0558] +job info()
INFO[0558] +job subscribers_count()
INFO[0558] -job subscribers_count() = OK (0)
INFO[0558] +job registry_config()
INFO[0558] -job registry_config() = OK (0)
INFO[0558] -job info() = OK (0)
Containers: 0
Images: 2
Storage Driver: devicemapper
 Pool Name: atomicos-docker--pool
 Pool Blocksize: 65.54 kB
 Backing Filesystem: xfs
 Data file:
 Metadata file:
 Data Space Used: 24.05 MB
 Data Space Total: 7.181 GB
 Data Space Available: 7.157 GB
 Metadata Space Used: 81.92 kB
 Metadata Space Total: 33.55 MB
 Metadata Space Available: 33.47 MB
 Udev Sync Supported: true
 Library Version: 1.02.93-RHEL7 (2015-01-28)
Execution Driver: native-0.2
Kernel Version: 3.10.0-229.7.2.el7.x86_64
Operating System: CentOS Linux 7 (Core)
CPUs: 2
Total Memory: 1.954 GiB
Name: localhost.localdomain
ID: IPIB:YGHC:UZ5V:JVRC:PB3M:LMIM:PFQC:46G2:RLUT:YRPO:EAD4:7XUX
WARNING: No memory limit support
WARNING: No swap limit support

I have also successful builds using exactly the same kickstart and same approach - difference seems to be in build KVM VM vCPU count. With single virtual CPU it seems to succeed and with 2 vCPUs it seems to crash. Perhaps its some multithreading issue?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

can you also provide the output of docker version?

Sure - here it is:
Docker version 1.6.2, build ba1f6c3/1.6.2

@mainframe are you still able to reproduce this on the current release (1.8.1)?

I forgot to report back that I found a cause and a simple workaround for this issue. After more tests it seemed to be some kind of docker daemon multithreading issue inside KVM VM and anaconda chroot. I was using Fedora Imagefactory tool for OS image building and it launched VMs with vCPUs config hard-coded for 2 cores: https://github.com/projectatomic/rpm-ostree-toolbox/blob/master/src/py/rpmostreecompose/imagefactory.py#L250
It needed to be patched for single vCPU core/thread on Imagefactory build VM.
I can try 1.8.1 - but it takes time.

@mainframe thanks! Do you want to keep this opened?

I think you may close this one.

I'll close, feel free to comment here if you have additional information. Thanks!


JavaScript IntelliSense "Error" class suggestions didn't provide code property

VS Code Version: 1.54.3
OS Version: Windows 10 20H2 Build 19042.572

Steps to Reproduce:
let error = new Error('Error Description!');
error.code = 402;

Does this issue occur when all extensions are disabled?: Yes

Sorry! Wrong issue.


Contributing to gapi

Hi, sorry I was wondering where is the code for this repo? Is this project open source? I would like to extend the functionality for some of the drive apis. Would that be possible?

Hi @jiachen247,
The issue of where is the code is being tracked here:
https://github.com/google/google-api-javascript-client/issues/432
With Javascript, you can simply extend the object to however you like.
I think answers the questions, and so I'll close this issue. If you'd like it open, ping me with more questions here and I'll re-open it.


Local hostnames are not resolved by unbound

I'm not sure if this is a bug/feature or (most likely) my lack of understanding how unbound works:
My setup is as follows:
I have a RPi setup with pi-hole and unbound working together for years - no issues.
I would like to use a domain of mine (viktak.cc) to access my local network using Nginx Proxy Manager. I set it all up, and all the proxy hosts work fine (i.e. when I type https://notes.viktak.cc I get to the service I want).
The problem is that this works ONLY on the PC I set this all up (in this case, it's a Windows 11 box). On the whole home network I get DNS address could not be found in the browser. Also, even on the Windows box, wher it works in the browser, when I try to ping any of the proxy hosts I get: Ping request could not find host notes.viktak.cc. Please check the name and try again.
If I disable unbound on the RPi, and use any public DNS resolver, the problem goes away, i.e. on any computer on the home network I can ping and browse to the proxy hosts successfully.
Any idea what might be the problem?
Here is /etc/unbound/unbound.conf.d/pi-hole.conf:
pi@pihole:~ $ cat /etc/unbound/unbound.conf.d/pi-hole.conf
server:
    # If no logfile is specified, syslog is used
    logfile: "/var/log/unbound/unbound.log"
    verbosity: 0

    interface: <IP_ADDRESS>
    port: 5335
    do-ip4: yes
    do-udp: yes
    do-tcp: yes

    # May be set to yes if you have IPv6 connectivity
    do-ip6: no

    # You want to leave this to no unless you have *native* IPv6. With 6to4 and
    # Terredo tunnels your web browser should favor IPv4 for the same reasons
    prefer-ip6: no

    # Use this only when you downloaded the list of primary root servers!
    # If you use the default dns-root-data package, unbound will find it automatically
    #root-hints: "/var/lib/unbound/root.hints"

    # Trust glue only if it is within the server's authority
    harden-glue: yes

    # Require DNSSEC data for trust-anchored zones, if such data is absent, the zone becomes BOGUS
    harden-dnssec-stripped: yes

    # Don't use Capitalization randomization as it known to cause DNSSEC issues sometimes
    # see https://discourse.pi-hole.net/t/unbound-stubby-or-dnscrypt-proxy/9378 for further details
    use-caps-for-id: no

    # Reduce EDNS reassembly buffer size.
    # IP fragmentation is unreliable on the Internet today, and can cause
    # transmission failures when large DNS messages are sent via UDP. Even
    # when fragmentation does work, it may not be secure; it is theoretically
    # possible to spoof parts of a fragmented DNS message, without easy
    # detection at the receiving end. Recently, there was an excellent study
    # >>> Defragmenting DNS - Determining the optimal maximum UDP response size for DNS <<<
    # by Axel Koolhaas, and Tjeerd Slokker (https://indico.dns-oarc.net/event/36/contributions/776/)
    # in collaboration with NLnet Labs explored DNS using real world data from the
    # the RIPE Atlas probes and the researchers suggested different values for
    # IPv4 and IPv6 and in different scenarios. They advise that servers should
    # be configured to limit DNS messages sent over UDP to a size that will not
    # trigger fragmentation on typical network links. DNS servers can switch
    # from UDP to TCP when a DNS response is too big to fit in this limited
    # buffer size. This value has also been suggested in DNS Flag Day 2020.
    edns-buffer-size: 1232

    # Perform prefetching of close to expired message cache entries
    # This only applies to domains that have been frequently queried
    prefetch: yes

    # One thread should be sufficient, can be increased on beefy machines. In reality for most users running on small networks or on a single machine, it should be unnecessary to seek performance enhancement by increasing num-threads above 1.
    num-threads: 1

    # Ensure kernel buffer is large enough to not lose messages in traffic spikes
    so-rcvbuf: 1m

    # Ensure privacy of local IP ranges
    private-address: <IP_ADDRESS>/16
    private-address: <IP_ADDRESS>/16
    private-address: <IP_ADDRESS>/12
    private-address: <IP_ADDRESS>/8
    private-address: fd00::/8
    private-address: fe80::/10

Finally, this is a log of when I do a ping notes.viktak.cc:
[1687013092] unbound[6170:0] debug: subnet[module 0] operate: extstate:module_state_initial event:module_event_new
[1687013092] unbound[6170:0] info: subnet operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: validator[module 1] operate: extstate:module_state_initial event:module_event_pass
[1687013092] unbound[6170:0] info: validator operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_state_initial event:module_event_pass
[1687013092] unbound[6170:0] info: resolving notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: resolving (init part 2):  notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: resolving (init part 3):  notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: processQueryTargets: notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: sending query: notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: sending to target: <viktak.cc.> <IP_ADDRESS>#53
[1687013092] unbound[6170:0] debug: cache memory msg=211910 rrset=668586 infra=209958 val=97575 subnet=41372
[1687013092] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_wait_reply event:module_event_reply
[1687013092] unbound[6170:0] info: iterator operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: sanitize: removing extraneous answer RRset: viktak.cc. A IN
[1687013092] unbound[6170:0] info: response for notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: reply from <viktak.cc.> <IP_ADDRESS>#53
[1687013092] unbound[6170:0] info: query response was CNAME
[1687013092] unbound[6170:0] info: resolving notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: resolving (init part 2):  notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: resolving (init part 3):  notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: processQueryTargets: notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: sending query: viktak.cc. A IN
[1687013092] unbound[6170:0] debug: sending to target: <viktak.cc.> <IP_ADDRESS>#53
[1687013092] unbound[6170:0] debug: cache memory msg=211910 rrset=668586 infra=209958 val=97575 subnet=41372
[1687013092] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_wait_reply event:module_event_reply
[1687013092] unbound[6170:0] info: iterator operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: iterator operate: chased to viktak.cc. A IN
[1687013092] unbound[6170:0] debug: sanitize: removing public name with private address <viktak.cc.> <IP_ADDRESS>#53
[1687013092] unbound[6170:0] info: response for notes.viktak.cc. A IN
[1687013092] unbound[6170:0] info: reply from <viktak.cc.> <IP_ADDRESS>#53
[1687013092] unbound[6170:0] info: query response was nodata ANSWER
[1687013092] unbound[6170:0] info: finishing processing for notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: validator[module 1] operate: extstate:module_wait_module event:module_event_moddone
[1687013092] unbound[6170:0] info: validator operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: subnet[module 0] operate: extstate:module_wait_module event:module_event_moddone
[1687013092] unbound[6170:0] info: subnet operate: query notes.viktak.cc. A IN
[1687013092] unbound[6170:0] debug: cache memory msg=211910 rrset=668586 infra=209958 val=97575 subnet=41372

Thanks for any pointers in advance!

First of all, thanks for your suggestion.
If you mean to simply add that line to the end of my config, I just tried it, but it still doesn't work. :(  Maybe I misunderstood something?

Did you restart Unbound/pi-hole for the configuration to be picked up? Is this the same setup that produced the output above? If so can you attach the new log?
For other hosts reaching this Unbound you would need to define another interface with the host's address and enable access with something like access-control: <IP_ADDRESS>/16 allow if that is your network's space, by default Unbound only allows localhost connections. But I believe you already contact Unbound through pi-hole so that shouldn't be a problem. Do other hosts in your network get DNS answers (ignoring your domain in question)?

Yes, I restarted Unbound. It is the same setup.
Other hosts behave exactly the same way, i.e. yehy can't find the hosts. My network is <IP_ADDRESS>/24 but I guess, the setting in the conf file <IP_ADDRESS>/16 should be OK.
So far the only way I could get my hosts working is to define the List of local DNS domains in PiHole.

From your log output above:
[1687013092] unbound[6170:0] debug: sanitize: removing public name with private address <viktak.cc.> <IP_ADDRESS>#53

That problem should be solved with private-domain: viktak.cc.
I am not sure what happens with the hosts problem. Testing again with the new configuration and capturing the log could give more insight.
It could also be useful for debugging to have Unbound listen to something like interface: 192.168.123.x and then from a client you could do dig @192.168.123.x -p 5335 notes.viktak.cc. This will bypass pi-hole and we can see what happens with Unbound.

Indeed, the problem with removing public name with private address.. seems to be solved.
dig @<IP_ADDRESS> -p 5335 notes.viktak.cc gives the following result:
pi@pihole:~ $ dig @<IP_ADDRESS> -p 5335 notes.viktak.cc

; <<>> DiG 9.16.37-Raspbian <<>> @<IP_ADDRESS> -p 5335 notes.viktak.cc
; (1 server found)
;; global options: +cmd
;; connection timed out; no servers could be reached

and produces this in the logs:
[1687080464] unbound[6170:0] debug: subnet[module 0] operate: extstate:module_state_initial event:module_event_new
[1687080464] unbound[6170:0] info: subnet operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: validator[module 1] operate: extstate:module_state_initial event:module_event_pass
[1687080464] unbound[6170:0] info: validator operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_state_initial event:module_event_pass
[1687080464] unbound[6170:0] info: resolving notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: resolving (init part 2):  notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: resolving (init part 3):  notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: processQueryTargets: notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: sending query: notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: sending to target: <viktak.cc.> <IP_ADDRESS>#53
[1687080464] unbound[6170:0] debug: cache memory msg=549744 rrset=1449422 infra=546112 val=164017 subnet=41372
[1687080464] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_wait_reply event:module_event_reply
[1687080464] unbound[6170:0] info: iterator operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: sanitize: removing extraneous answer RRset: viktak.cc. A IN
[1687080464] unbound[6170:0] info: response for notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: reply from <viktak.cc.> <IP_ADDRESS>#53
[1687080464] unbound[6170:0] info: query response was CNAME
[1687080464] unbound[6170:0] info: resolving notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: resolving (init part 2):  notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: resolving (init part 3):  notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: processQueryTargets: notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: sending query: viktak.cc. A IN
[1687080464] unbound[6170:0] debug: sending to target: <viktak.cc.> <IP_ADDRESS>#53
[1687080464] unbound[6170:0] debug: cache memory msg=549744 rrset=1449422 infra=546112 val=164017 subnet=41372
[1687080464] unbound[6170:0] debug: iterator[module 2] operate: extstate:module_wait_reply event:module_event_reply
[1687080464] unbound[6170:0] info: iterator operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: iterator operate: chased to viktak.cc. A IN
[1687080464] unbound[6170:0] debug: sanitize: removing public name with private address <viktak.cc.> <IP_ADDRESS>#53
[1687080464] unbound[6170:0] info: response for notes.viktak.cc. A IN
[1687080464] unbound[6170:0] info: reply from <viktak.cc.> <IP_ADDRESS>#53
[1687080464] unbound[6170:0] info: query response was nodata ANSWER
[1687080464] unbound[6170:0] info: finishing processing for notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: validator[module 1] operate: extstate:module_wait_module event:module_event_moddone
[1687080464] unbound[6170:0] info: validator operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: subnet[module 0] operate: extstate:module_wait_module event:module_event_moddone
[1687080464] unbound[6170:0] info: subnet operate: query notes.viktak.cc. A IN
[1687080464] unbound[6170:0] debug: cache memory msg=549744 rrset=1449422 infra=546112 val=164017 subnet=41372
[1687080472] unbound[6170:0] debug: subnet[module 0] operate: extstate:module_state_initial event:module_event_new

The dig output shows that Unbound resolves the domain and gives back the answer now with the correct configuration.
The rest of the issue seems to be pi-hole and local network configuration related; I can't comment further on those.


Update setup.py to work with new version of pip

Pip's module structure has changed significantly since v10.0. This PR fixes setup.py so that the pip import statements and references to req objects work. It also enforces pip v23.0 in the project so that setup.py doesn't need to deal with older versions of pip.

I think it is allready fixed in https://github.com/Schramp/UnifiedLogReader/blob/master/setup.py


[ruby] Type Propagation Pass

An implementation of RubyTypeRecoveryPass needs to be created and tested. There are good examples for this on the deprecated frontend.

Closing as a rough implementation is already implemented


Merge schema/validation systems

Back in May, we introduced a new schema validation system.  It is great, more accurate, more powerful, faster, etc, etc.  But we still have the old schema validation system.  We actually use the old schema system for a whole bunch of stuff, such as generating UI's, generating database tables, generating code, etc.  So this PR is intended to merge them once and for all.

[x] @medplum/core
[x] @medplum/fhir-router
[x] @medplum/mock
[x] @medplum/generator
[x] @medplum/react
[x] @medplum/app
[x] @medplum/server
[x] base-schema.json

Deployed to staging: https://app.staging.medplum.com/

Does this change how we unit test bots as well (no more indexStructureDefinitionBundle?)
https://www.medplum.com/docs/bots/unit-testing-bots

Does this change how we unit test bots as well (no more indexStructureDefinitionBundle?)

We should discuss.
As currently implemented, yes, indexStructureDefinitionBundle should become loadDataTypes.
But we have existing customers and existing code using indexStructureDefinitionBundle, so we may want keep the existing function, either as a rename or an alias.

@mattwiller This is deployed to staging for testing.
https://app.staging.medplum.com/

coverage: 93.852% (-0.2%) from 94.07% when pulling 3c103f544a2d2e6d2d65a700db8fd48e54989f14 on cody-merge-schema-systems into 8c2909429c7cd55310c174b6cc84d12f79acca85 on main.


Keeping track of the components that has been tested

Listing all the components that have not been tested

[X] Footer Component
[X] Header Component
[X] Tags Component https://github.com/nightwatchjs/html-reporter/pull/43
[ ] Alert Banner Component
[ ] ChipWithIcon Component
[ ] Code Block component
[ ] EnvironmentMetadata Component
[ ] Error Fallback
[ ] Error TestStep
[ ] FilePathView Component
[ ] FilterDropDown Component

hello @subhajit20
could you please provide more information about what you are trying to achieve and what should i do to test all these component and complete the task

hello @subhajit20 could you please provide more information about what you are trying to achieve and what should i do to test all these component and complete the task

Please refer to this https://github.com/nightwatchjs/html-reporter/issues/39


[Plugin Hub] Display deprecated fields at the bottom of the schema

Description
As of version 3.7.x, fields in the plugin schema have been flagged with a deprecation key, containing information about the deprecation.
This commit adds the fields marked as deprecated to the list of Deprecated Parameters on the Configuration Reference page. It also renders a deprecation notice, with the information provided in the field.
Note: Fields marked as deprecated are not rendered in the main body of the schema, just in the Deprecated Parameters section.
Testing instructions
datadog - fields marked as deprecated
session - shorthand fields only (these weren't marked as deprecated)
Checklist

[ ] Review label added
[ ] Conditional version tags added, if applicable.

See the changelog for this plugin for new field mapping info.

For shorthand fields, this makes sense. But looks like they're now listing the field mapping info directly in that deprecation notice. Maybe we should rephrase this? Something like: "If the deprecation notice for a parameter doesn't include new field mapping info, see the changelog."
What do you think?


Javascript Notes and Questions Added

PR for Issue #96.

@Swap-nil-2003 You have added javascript interview questions and cheatsheets in Notes folder. Please add it in their respective folder. There is Interview Questions  and Cheatsheets folder present in the repo

@risingstar-bit made the necessary changes


three ad: inconsistently shows

Made a new account and didn't show up on mobile web app and desktop, then appeared after a minutes on mobile. Still missing on desktop, and I can't click anything

Fixed in https://github.com/commaai/connect/commit/5337249ad0ee21c5d7f3dca65163d123b74be6bb

Had to revert this as it broke opening route URLs - added a new test and will look into this again

Did a git bisect, it broke here: https://github.com/commaai/connect/commit/0660b0338f801a059fd3af977af388c486d2cd45

Fixed here https://github.com/commaai/connect/commit/555aebdd13b78ee30e9b0d5c198f57132996153a


Prisma Migrate cannot update table which is used in views

Bug description
Since Prisma doesn't support database views yet, I have decided to manually create migration.sql script which creates views in my SQLite database. However, when I add another migration on top of that, I'm not able to apply it because of the following error:
Error: P3006

Migration `20220102133239_report` failed to apply cleanly to the shadow database.
Error:
error in view print_closure: no such table: main.contracts
   0: sql_migration_connector::flavour::sqlite::sql_schema_from_migration_history
             at migration-engine/connectors/sql-migration-connector/src/flavour/sqlite.rs:127
   1: sql_migration_connector::validate_migrations
             at migration-engine/connectors/sql-migration-connector/src/lib.rs:351
   2: migration_core::api::DevDiagnostic
             at migration-engine/core/src/api.rs:108

This is because in order to replace some columns, Prisma Migrate deletes contracts table which those views depend on.
How to reproduce

Create a schema with a single table
Run prisma migrate dev
Manually add another migration which creates a view
Modify the table on which the view depends
Run prisma migrate dev again

Expected behavior
Prisma needs to be able to handle migrations which modify tables on which something else depends (e.g. views).
I can see two potential solutions:

Either the table column updates need to be handled via ALTER TABLE instead of creating a new table, dropping the old one and then renaming the new one.
Or Prisma needs to add support for database views so it will be aware of them when applying migrations and it will be able to temporarily drop them and then re-created them in order to avoid such errros as the one I have run into.

Prisma information

Original schema:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlite"
  url      = "file:../my.db"
}

model Contract {
  id                 Int            @id @default(autoincrement())
  report             String?

  @@map("contracts")
}

Manually added migration:
CREATE VIEW print_closure AS SELECT id FROM contracts;

Updated schema:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlite"
  url      = "file:../my.db"
}

model Contract {
  id                 Int            @id @default(autoincrement())
  report             Report?        @relation(fields: [reportId], references: [id])
  reportId           Int?           @map("report_id")

  @@map("contracts")
}

model Report {
  id        Int        @id @default(autoincrement())
  name      String     @unique
  contracts Contract[]

  @@map("reports")
}

Environment & setup

OS: Linux 5.10.84-1-MANJARO
Database: SQLite
Node.js version: v17.2.0

Prisma Version
prisma                  : 3.7.0
@prisma/client          : 3.7.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 8746e055198f517658c08a0c426c7eec87f5a85f (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8746e055198f517658c08a0c426c7eec87f5a85f (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 8746e055198f517658c08a0c426c7eec87f5a85f (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 8746e055198f517658c08a0c426c7eec87f5a85f (at<EMAIL_ADDRESS>Default Engines Hash    : 8746e055198f517658c08a0c426c7eec87f5a85f
Studio                  : 0.445.0

What is the SQL of the new migration that is causing the error?

-- CreateTable
CREATE TABLE "reports" (
    "id" INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT,
    "name" TEXT NOT NULL,
);

-- RedefineTables
PRAGMA foreign_keys=OFF;
CREATE TABLE "new_contracts" (
    "id" INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT,
    "report_id" INTEGER,
    CONSTRAINT "contracts_report_id_fkey" FOREIGN KEY ("report_id") REFERENCES "reports" ("id") ON DELETE SET NULL ON UPDATE CASCADE,
);
INSERT INTO "new_contracts" ("id") SELECT "id" FROM "contracts";
DROP TABLE "contracts";
ALTER TABLE "new_contracts" RENAME TO "contracts";
PRAGMA foreign_key_check;
PRAGMA foreign_keys=ON;

-- CreateIndex
CREATE UNIQUE INDEX "reports_name_key" ON "reports"("name");

I realized it would probably be better to create views using seed command. This way, I won't run into the problem described above while developing the app. But I will still run into it when applying migrations in production.
I think it could be solved by introducing two new commands similar to seed. One would be run just before a migration is applied and the other right after it. With this, I would be able to drop views before and re-created them after the migration is applied.

I have the same issue

Can confirm this is still happening, even with the views preview, repro above

I have the same issue


Get Marker parent Cluster for current zoom level

I have a swipe feature that goes to the next Map marker, which might be inside of a cluster in the current zoom level. If the next marker is inside of a cluster, I want to open his cluster. I've implemented this in a couple of different ways but they all look very hacky:
Non-safe code:
    var spiderfyParent = function(marker) {
        var parent = marker.__parent.__parent.__parent.__parent;
        if (parent._zoom >= $scope.map.getZoom()) { // Only care if zoom level is bigger or equal
            parent.spiderfy();
        }
    }

I'm not sure why I have to go 4 parents up but this code always work for me. Another option is: traverse all Map layers that are L.MarkerCluster and compare the '_leaflet_id' but this is not guaranteed to work if I'm panning the map.
Is there a better way to achieve this? Can we have a function like that added to the lib?
Thanks a lot

Use this:
https://github.com/Leaflet/Leaflet.markercluster#getting-the-visible-parent-of-a-marker

There appear to be an issue in this case, if I click on the cluster and then on a marker inside of it and call getVisibleParent it returns the current marker, although it has a cluster visible with ~0.5 opacity in the screen.

Yeah, If the marker is currently spiderfied it'll return the marker as it is visible.
You'll need to check out the code of the method and change it to check for this specific case. Not sure this is how the default behaviour should be.


Order of k8s_yaml commands

My Tiltfile is as following:
k8s_yaml('path/to/yaml/that/creates/namespace')

k8s_yaml('path/to/deployment/that/created/in/namespace/above')

When I'm running tilt up I got the namespace created but error on creating deployment that the namespace doesn't exist.
The second time it runs ok.

Interesting! I would imagine this would be taken care of by this change. Thoughts @landism?

#1515

Having the same problem
`
Kafka Setup
k8s_yaml([
'deploy/kafka/00-namespace/00-namespace.yml',
'deploy/kafka/01-zookeeper/01-zookeeper-service.yml',
'deploy/kafka/01-zookeeper/02-zookeeper-deployment.yml',
'deploy/kafka/02-kafka/kafka-broker1-deployment.yml',
'deploy/kafka/03-yahoo-kafka-manager/kafka-manager-deployment.yml',
'deploy/kafka/03-yahoo-kafka-manager/kafka-manager-service.yml',
])
`


Webpack5 build pipeline

Hi, do you have any updates about it?
cheers .

I honestly cannot find most of the plugins used in this in v5 webpack. This might mean a total re-write and research from beginning

Hi,  got the same issue as https://github.com/prateekbh/babel-esm-plugin/issues/50 when use<EMAIL_ADDRESS>and<EMAIL_ADDRESS>will this be fixed?


[connectivity] Doesn't work well on Android and Airplane mode

I was testing connectivity with Airplane mode and for Android it's buggy.
Sometimes when I turn on Airplane mode it will say 'wifi' and not none, other times it randomly works.  If I turn off wifi it seems better, but I can't say for sure.  It's very random.

Hello @TahaTesser
should we stop accepting this issue because of this issue https://github.com/flutter/flutter/issues/83277?

@Abhishek01039
We will continue to label new issues in the meantime until migration is completed

Closing as connectivity is deprecated in favor of connectivity_plus.


About evaluation of Dart-Math

Thank you for your excellent work and well-structured code repo.
I encountered some issues regarding the evaluation of Dart-Math. I ran the provided evaluation script to evaluate Dart-Math-Llama-3-8b-prof2diff on theoremqa and found that all items are false in the generated .jsonl file. What is the problem?
The resulted file is attached below.
https://hkustconnect-my.sharepoint.com/:u:/g/personal/xxuca_connect_ust_hk/ETFyWNbUrghFpa4H1_L6hpcB4AD8ze3mRoUrshPQcEGR3w?e=lzAEnX

Thanks for your issue! I figured out 2 bugs related to this error:

Commit https://github.com/hkust-nlp/dart-math/commit/a6647ea7e04c1d8c0e6b02a679d116de7c04f43d set ignore_eos=True because Llama-3-8B(-Base) tends to decode EoS immediately sometimes, but this messes up generation of normal (instruct) models. So I made ignore_eos a CLI option, which is False by default, in the latest commit https://github.com/hkust-nlp/dart-math/commit/82377fc66af5c1c76bf3d8e40175cd21772fa660.
I find that the DART-Math-Llama3-8B (Prop2Diff) was wrongly uploaded as the checkpoint from epoch 3, while we stated in the paper that we set # of epochs as 1 for Llama3 models for better performance found by hyperparameter search. I will upload the correct checkpoint asap (and close the issue then as a reminder).

Thanks again for helping us figure out the bugs!

Thank you for getting back to me so quickly! The problem is solved! I appreciate your help!


feat: create a macro for declare tx

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.09%. Comparing base (af655eb) to head (a7aafd8).

Additional details and impacted files
@@                             Coverage Diff                             @@
##           ayelet/mempool/macro-for-deploy-account     #182      +/-   ##
===========================================================================
- Coverage                                    52.20%   52.09%   -0.12%
===========================================================================
  Files                                           22       22
  Lines                                          883      883
  Branches                                       883      883
===========================================================================
- Hits                                           461      460       -1
  Misses                                         398      398
- Partials                                        24       25       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't Sign In

Using Chrome. Clicking "Sign In" has no effect.

@3noch Hi. What Chrome version do you use?
I signed in successfully.

Ha turns out it was an ad blocker keeping the Oauth page from coming up!


[test]update offline test

What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #465 (94a0725) into main (4313bc3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 94a0725 differs from pull request most recent head ae90b1f. Consider uploading reports for the commit ae90b1f to get more accurate results

@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   26.28%   26.28%
=======================================
  Files          19       19
  Lines         974      974
=======================================
  Hits          256      256
  Misses        688      688
  Partials       30       30

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


java.lang.RuntimeException: java.lang.IllegalArgumentException: Internal error: Cannot create interpreter: Didn't find custom op for name 'TFLite_Detection_PostProcess' with version 1

I used tensorflow lite android object detection demo in my android project , but it crashs , I set ndk {
abiFilters 'armeabi-v7a'
}
in build.gradle, it still crashs
Error Log ：
java.lang.RuntimeException: java.lang.IllegalArgumentException: Internal error: Cannot create interpreter: Didn't find custom op for name 'TFLite_Detection_PostProcess' with version 1
Registration failed. at com.tfdetection.tflite.TFLiteObjectDetectionAPIModel.create(TFLiteObjectDetectionAPIModel.java:125)
crash code ：d.tfLite = new Interpreter(loadModelFile(assetManager, modelFilename));

@WestbrookZero  , your error logs indicates that tflite model used here has operation which are not supported. Check for your model file if that is correctly converted to tflite.

@avaish1  my tflite can be used by an empty android project , but can't be used by my android project ,and official pre-training tflite is still this error in my android project .

I solve it in build.gradle :  implementation 'org.tensorflow:tensorflow-lite:2.0.0'


Updating a file in DriveV3 errors: use PUT or POST instead of PATCH?

When calling Google::Apis::DriveV3::DriveService#update_file, I'm getting a Google::Apis::ClientError, whose #status_code is 405, and whose #body is "Bad HTTP method. Please use PUT or POST only."
I looked at the source, at drive_v3/service.rb:872, and it does indeed make either a simple command or an upload command with an HTTP method of :patch (excerpted here, for when the source changes):
        def update_file(file_id, file_object = nil, ...
          if upload_source.nil?
            command =  make_simple_command(:patch, 'files/{fileId}', options)
          else
            command = make_upload_command(:patch, 'files/{fileId}', options)
            command.upload_source = upload_source
            command.upload_content_type = content_type
          end
          ...

I'm comfortable submitting a pull-request for this specific method, but a) I haven't signed a Contributor License Agreement yet, and b) more importantly, I'm not sure how many other methods in this class share this problem.

Oh, interesting! It looks like that whole file was auto-generated on 2015-12-14, in b7c94d83.

Yeah, the service interfaces are generated based on the API description.
This particular issue looks like a regression on the backend. It was supposed to have been fixed back in December.

Anything I can do to help? (I've now signed the Contributor License Agreement.)

I'm hoping they'll fix this quickly. There are a few different versions of the upload protocols, this and the objective-c client use a slightly newer one and are both affected by it. The other upload mechanisms were fixed back in December, just missed this one particular variation.
I can revert back to the older protocols if it doesn't look like it can be fixed anytime soon.

Looks like this will be fixed in ~ 2 weeks. Workaround for the moment is to use DriveV2 (functionally the same, v3 just cleans up a lot of rough edges and is a little simpler.)

Looks like this is fixed on the backend now.


Error - FindRecentlyPushedNewBranches, branch does not exist [repo_id: 64 name: main]

Description
I'm getting a weird issue on several repositories.
The actual error is a 500 error:
FindRecentlyPushedNewBranches, branch does not exist [repo_id: 64 name: main]
How to solve this? Should I modify the branch name directly on DB side? Is there any way to fix this from the Gitea web portal?
Actually, it seems that this new version has broken several repos at once. Until last week everything was good, clean and accessible. Now I'm getting this error on several repositories.
Gitea Version
1.22.0
Workaround
It has been fixed in 1.22-nightly (which will be 1.22.1 soon), please use the 1.22-nighly binary (https://dl.gitea.com/gitea/1.22-nightly/) or docker image.

Please try to run sync branches on admin panel.

Yout mean the "Resynchronize pre-receive, update and post-receive hooks of all repositories."?
I have already tried multiple times it....nothing changed.
I also tried "Reinitialize all missing Git repositories for which records exist" under "Site Administration", nothing even with this.
I wish I will not have to rebuild the gitea instance from scratch.....so, re-import manually over 100 repositories (over 30 GB of data) and then also re-enable manually, by modifying manually each repository on database site the mirroring settings for each repo I have (as Gitea does not still have the way to backup these settings)....

Please try to run sync branches on admin panel.

I do not think FindRecentlyPushedNewBranches logic is right. Anything wrong in that function shouldn't block end users seeing a complete page.

Yout mean the "Resynchronize pre-receive, update and post-receive hooks of all repositories."?
I have already tried multiple times it....nothing changed.
I also tried "Reinitialize all missing Git repositories for which records exist" under "Site Administration", nothing even with this.
I wish I will not have to rebuild the gitea instance from scratch.....so, re-import manually over 100 repositories (over 30 GB of data) and then also re-enable manually, by modifying manually each repository on database side the mirroring settings for each repo I have (as Gitea does not still have the way to backup these settings)....

No. It's Sync missed branches from git data to databases

Even with "Sync missed branches from git data to databases" nothing changed. It starts, but then nothing...

As a quick fix:  Ignore FindRecentlyPushedNewBranches err #31164
If you could build your own instance, you could try to apply it to 1.22 branch.
Or when the backport is done and 1.22-nightly is ready, please try 1.22 nightly.

I am using snapcraft to get updates of Gitea.
May I get the nightly build with snap or do I have just to wait the next build?

As a quick fix it is ok, but I think the root reason is that sync branch has some problems.
The branch name is main, so it is default branch of repo 64?
Then what kind of this repo is? A fork, a mirror or a normal one?
Then why this branch can not be found in DB? During the creation of this repo, the main branch should has been insert into the DB.

Reopen, because the quick fix isn't complete. Need to figure out the root reason.

The root problem is that any branch could be renamed or deleted. Default branch may not exist in many cases.
So when running FindRecentlyPushedNewBranches, any non-existing branch should be ignored, but not reporting an error.

I can only image one case that the last branch (it is also the default branch) was deleted, and there's no branch in the repo, this error would happen.
If the default branch is renamed, repo.DefaultBranch should also be renamed?
If there's two or more branches, then when the default branch was deleted, the other one will be the new default branch?

Jfyi, I have fixed the issue by issuing a simple UPDATE query against the specific repository ID in the repository table, updating the default_branch value from "main" to "master". Just after doing that now I can access the affected repository.
I will have to check all of them one by one, as not all repository are using the "master" branch, some are using "main".
Here a sample query I used:
UPDATE repository SET default_branch = 'master' WHERE id = 100;
Finally, I dunno why this happened, as just before the upgrade to the latest build I was able to use the affected repositories without issues (and they were on master branch, not main, and I checked it in the commit history); after the upgrade several repositories have been "moved" to the main branch without a reason.
Wishing that this will not happen anymore in the next builds.
Regards

Maybe the algorithm of detection defulat branch when syncing branches into database are wrong. So that, all repositories with master as default branch but your default branch in app.ini is main will be wrong.

Probably, for now I have reverted manually, as it was the only way to fix this without disruptions, each repository affected from the wrong default branch to the correct one (master, most of the times).
But now I'm a bit worried about next builds/updates. :D

No, actually there was even another repository that was not on master (still figuring out which was the previous one) but it was put on main also.

Jfyi, I have fixed the issue by issuing a simple UPDATE query against the specific repository ID in the repository table, updating the default_branch value from "main" to "master". Just after doing that now I can access the affected repository.
I will have to check all of them one by one, as not all repository are using the "master" branch, some are using "main".
Here a sample query I used:
UPDATE repository SET default_branch = 'master' WHERE id = 100;
Finally, I dunno why this happened, as just before the upgrade to the latest build I was able to use the affected repositories without issues (and they were on master branch, not main, and I checked it in the commit history); after the upgrade several repositories have been "moved" to the main branch without a reason.
Wishing that this will not happen anymore in the next builds.
Regards

I'm having the same problem, hopefully the next new release fixes this and does it automatically (since my gitea is mainly used for backups, there are too many affected repositories for me to have the time to detect and manually fix them all).

Well, I checked the 180+ repositories I have right now on my Gitea instance and I would say that 1/3 of them have been affected by this issue. Now I have fixed them, but obviously I will monitor after next update if this will happen again.

This is what I faced as well, luckily only one ...

This is what I faced as well, luckily only one ...

Lucky one :D

I wonder if it is all the same issue (from gitea perspective).
Basically gitea was unable to find the default branch (master or main) and hence a 500 page. If you append /issue to the URL you get to the other webUI of gitea and from there you can view branches etc. for me it was not showing master (only the other feature branches )
A git clone works and git remote -r would list the feature branches but I also had what appeared as two origins and git would provide a WARNING (while this was an ERROR for gitea).
If you Google around you will find this can occur with git and it tolerates it but gitea needs to be a bit more deterministic especially with the db sinking
My workaround was to create a new branch from the cli from what git considered master, remove the master branches (local and origin), push to origin, from gitea /issue page then change the default branch to the new branch and everything works. Finally rename this tmp branch to master
Obviously this is a tedious workaround to get the git repo in alignment so the question then is.. what should gitea do and what is causing these shadow branches

I did not know about the /issue URL part. Good to know.
Probably this is just a Gitea-side issue as I checked, in my case, and the git repos were still there untouched, but not visible.
Actually in my case it was much quicker to identify which was the wrong value on DB side and update it directly for all the affected repo IDs.

I also encountered this problem, after upgrading to 1.22.0

I also encountered this problem, after upgrading to 1.22.0

Please try 1.22-nightly , and/or try to "Sync branches" from the admin dashboard panel

Maybe this is caused by auto rename branch name
After the rename, the branch name in DB is not changed

Does this related to #28056 ?
User didn't notice this issue, so branches are not synced since updated to v1.21, and errors occurred after upgrade to v1.22?

Actually in my case it was not due to an auto-renaming of the branches, as I had, suddenly after the auto-upgrade (using snap image) I had 40-50 repositories not usable anymore using Gitea, then I fixed each of them directly in DB and after the value updated on DB side I did just an F5 on the page of the affected repo and it turned back working as expected.

100% agree with OP. Same experience here.

100% agree with OP. Same experience here.

It has been fixed in 1.22-nightly (which will be 1.22.1 soon)

100% agree with OP. Same experience here.

It has been fixed in 1.22-nightly (which will be 1.22.1 soon), please use the 1.22-nighly binary (https://dl.gitea.com/gitea/1.22-nightly/) or docker image.

Ah, I see, I thought it would be backported into the 1.22 branch.
Is this Nightly release production ready or would it be rather advisable to wait for 1.22.1?
Is there a release date for 1.22.1?

Ah, I see, I thought it would be backported into the 1.22 branch.

Yes, it has been backported to 1.22, so 1.22-nightly contains it.

Is this Nightly release production ready or would it be rather advisable to wait for 1.22.1?

Yes, because 1.22-nighty will be 1.22.1 soon. It is exactly for production so no need to wait.

Is there a release date for 1.22.1?

Maybe in a several days.

@wxiaoguang
Which branch ot commit do I need to check out from Git to get exactly the state of 1.22-nightly? I want to build my own Docker image.

release/1.22

(± one day as nightly is probably built only once a day as the name implies)

Nice, seems to work now and the issue is worked around. Thank you!

The issue seems to be fixed.

The root reason is not fixed.

@yp05327 I agree.
I even specifically said

the issue is worked around

because it is not fixed. 😄

I believe the root problem needs a new issue to clarify the problem, but not keeping discussing "FindRecentlyPushedNewBranches" here .....
The FindRecentlyPushedNewBranches is indeed fixed, it sounds like a workaround but the approach is right: to make the system robust. No matter there is the root problem or not, the fix is still right and necessary.

Let's open a new issue.

Let's open a new issue.

Which is it? I don't see a related new issue in the list.
I'll create a new one, then.
Here it is.

It seems in the 1.22.1 version, the 500 error is fixed but I still get the error log ? should I ignore it or not ?

It seems in the 1.22.1 version, the 500 error is fixed but I still get the error log ? should I ignore it or not ?

Please open a new issue and paste your error logs.

@lunny you have asked so above  https://github.com/go-gitea/gitea/issues/31163#issuecomment-2185600813 and there is already one https://github.com/go-gitea/gitea/issues/31163#issuecomment-2185951268 : #31471


Typedocs test

Create type docs markdown files and export them to Markdown files . After you've exported them to markdown files , add them to the Nextra docs project and see the results

https://github.com/typedoc2md/typedoc-plugin-markdown/tree/main/packages/typedoc-plugin-markdown#readme

https://typedoc-plugin-markdown.org/docs


Automatic rush update --full

This is an automatic PR generated weekly with changes from running the command rush update --full

eslint-plugin-azure-sdk compilation failure due to https://github.com/isaacs/minipass/issues/49


Looking railroad tracks causes significant lag

Describe the Bug
When looking at the railroad tracks, the FPS drops considerably (from ~100 FPS to 10 FPS)
Also the more railroad tracks there are, the lower the FPS will be.
Curved rails cause more lag than straight rails
I made a private server, and I didn't notice any lag on its side, so it's probably a rendering problem.
Changing display settings doesn't help much.
Reproduction Steps

Place railroad tracks
Stay near tracks
Lag
...

Expected Result
A large FPS drop
Screenshots and Videos
Near the tracks:

Usual case:

Crash Report or Log
No response
Operating System
Client: Windows 10   --   Server: Debian 11 (bullseye)
Mod Version
0.5.0g
Minecraft Version
1.18.2
Other Mods
Fabric version : 0.14.12-1.18.2
alternate-current-mc1.18-1.2.1
sodium-fabric-mc1.18.2-0.4.1+build.15
sodium-extra-0.4.4+mc1.18.2-build.39
lithium-fabric-mc1.18.2-0.7.10
indium-1.0.3+mc1.18.2
krypton-0.1.9
entityculling-fabric-mc1.18-1.5.1
fabric-api-0.53.4+1.18.2
create-fabric-0.5.0g-792+1.18.2
*also tested with this fps booster modpack (doesn't help more) : https://www.curseforge.com/minecraft/modpacks/boosted-fps/files/3806118
**I tried to remove all the mods (except create), and there is always a lag spike when I am near the railroad track
Additional Context
Hoping you find the bug 🙂

I'm also having this issue. Was hoping to get some nice video of my create contraptions with shaders but I guess that cant happen until this is fixed

Same issue... first i thought it's just the train doors causing fps issues but this also happens with me... and it gets worse when a train reaches a station and all doors open or close. (https://github.com/Fabricators-of-Create/Create/issues/847#issue-1630746037)

same here

curved tracks are rendered as block entities, or with flywheel when enabled.
You were using instancing, which performs worse on AMD. Switching to batching may help.
This will be resolved and batching will be removed with flywheel 1.0.


Output current rather than latest version in up-to-date messages

Latest can actually be older than current, especially when comparing a snapshot against the latest release, and current is what was compared against latest anyway.
While at it, add a test case for similar occurrence with Go versions (they were already showing correct info though).

Summary by CodeRabbit

Bug Fixes

Corrected version display to show the current version instead of the latest version in status messages.

Tests

Added tests to verify the correct display of package and Go versions when they are up-to-date.

@scop
You checked the code very thoroughly. Thank you!!


clean unused extraStatTags

Please provide a description of this PR:
start from 1.17, stats implement in standard way, these lines are useless.
cc @kyessenov

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test unit-tests-arm64

gencheck_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test unit-tests-arm64

gencheck_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test gencheck

unit-tests_istio
031d6c1044be180fca19f3dffca65b815e40b51e
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f57499ba7c216d0d51619e68d331f8c28abdd62b
link
unknown
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests


Add login_with_raw for raw PIN

I have some absolutely broken dongles that have a NUL byte in their PIN. Despite being completely against spec, this is totally accepted by my driver and they will only unlock with the NUL byte version of the PIN.
To make life easier, I've added a login that takes raw bytes in a Vec<CK_BYTE>.  I can see it being useful in cases where the PIN is difficult (or impossible in this case...) to coerce to/from UTF8

interesting... would you mind document the dongles that are behaving that way, so that we know in the future why this is needed? also adding a note that this is the reason why one would want to use the login_with_raw?


{RDBMS} Fix typo in parameter help for postgres replica promotion

Related command

az postgres flexible-server replica promote
Description

Fix typo in help text
Testing Guide

Manual testing
History Notes

{RDBMS} Fix typo in parameter help for postgres replica promotion

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

RDBMS