Add e2e test for User's last login

AB#30874
Describe your changes
Adds test that asserts login time stamps in Users page
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review
[x] I do not need any deviation from our PR guidelines

For the reviewer: PR also includes another test "View users page"


I001 raised on comments in import section

raised on inline / single line comments
not sure if this is intended. do commentaries in imports violate a PEP rule ?

Yeah it’s probably due to comments right now! This will be fixed soon (see #675).

awesome! cheers


Can i use it as a REST api in Python?

Your repository is working for me as a web app. I am able to host it my local machine. But I was unable to use it as a REST api.
I am using the following code for the same.
url = 'http://localhost:8080'
data = {"q":'subject has headache with fever',
       "format":'html'}
headers = {'Content-Type': 'text'}
response = requests.post(url, data = data, headers = heasders)
response.raise_for_status()
response.json()

And it gives the following error:
JSONDecodeError                           Traceback (most recent call last)
 in
7 response = requests.post(url, data = data)
8 response.raise_for_status()
----> 9 response.json()
C:\ProgramData\Anaconda3\lib\site-packages\requests\models.py in json(self, **kwargs)
895                     # used.
896                     pass
--> 897         return complexjson.loads(self.text, **kwargs)
898
899     @property
C:\ProgramData\Anaconda3\lib\json_init_.py in loads(s, encoding, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
346             parse_int is None and parse_float is None and
347             parse_constant is None and object_pairs_hook is None and not kw):
--> 348         return _default_decoder.decode(s)
349     if cls is None:
350         cls = JSONDecoder
C:\ProgramData\Anaconda3\lib\json\decoder.py in decode(self, s, _w)
335
336         """
--> 337         obj, end = self.raw_decode(s, idx=_w(s, 0).end())
338         end = _w(s, end).end()
339         if end != len(s):
C:\ProgramData\Anaconda3\lib\json\decoder.py in raw_decode(self, s, idx)
353             obj, end = self.scan_once(s, idx)
354         except StopIteration as err:
--> 355             raise JSONDecodeError("Expecting value", s, err.value) from None
356         return obj, end
JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Is it that the way that I am calling is incoorect? In that case, what would be right format?

This url is just hosted as a webapp not REST api. Check out this link for REST support - https://github.com/GoTeamEpsilon/ctakes-rest-service


Error. Cannot make tmpdir. Exit

I tried to search my file and I got this msg at the end of my terminal. After awhile, i get the following msg in my browser GUI:
Traceback (most recent call last):
File "/mnt/c/Users/lym16/MhcVizPipe/python/lib/python3.8/site-packages/MhcVizPipe/gui.py", line 1083, in run_analysis
_ = analysis.make_report()
File "/mnt/c/Users/lym16/MhcVizPipe/python/lib/python3.8/site-packages/MhcVizPipe/ReportTemplates/report.py", line 766, in make_report
self.sample_overview_table(className='col-6')
File "/mnt/c/Users/lym16/MhcVizPipe/python/lib/python3.8/site-packages/MhcVizPipe/ReportTemplates/report.py", line 153, in sample_overview_table
within_length = self.peptide_numbers[sample.sample_name]['total']
KeyError: 'de_novo_only_peptides.csv'
I can't seem to fix it.

Hello again. Were you able to resolve this issue?
Thanks,
Kevin

Hi Kevin,
Sorry for the late reply! I manually edited all the script settings and it
finally worked out. Thanks for some useful pointers!
Warmest regards,
Yew Mun
On Wed, May 26, 2021 at 9:26 PM Kevin Kovalchik @.***>
wrote:

Hello again. Were you able to resolve this issue?
Thanks,
Kevin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CaronLab/MhcVizPipe/issues/8#issuecomment-848768685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUA3RJUMFVODI56RP3YGOTLTPTZI7ANCNFSM44UFHOOA
.

Hi Yew Mun,
That's good to hear! Which script files did you need to edit? Was it a problem with the MhcVizPipe distribution? Or did you use seperate installations of netMHCpan and GibbsCluster that needed to be set up? I'm just trying to determine if I need to fix anything in the "standalone" distribution of MhcVizPipe.
Thanks!
Kevin

Hi Kevin,
After reading your suggestions, I went to read more in details of the
installation of gibbscluster, NetMHCI and NetMHCII installation. Initially
if I were to do the easy installation approach, there were no
instructions that requires for checking the general settings of these tools
to the exact directory where it is stored (i.e., the tools folder of
MhcVizPipe). So after reading the manual installation of how to do it, and
changing the location and tmp folder location (i tried to give root/admin
access to the tmp folder but nothing happened) to my desired location, i
was able to get the programme to run. Therefore, the standalone
distribution is okay, just need to tweak the instruction. :)
Thanks and warmest regards,
Yew Mun
On Wed, Jun 9, 2021 at 8:28 PM Kevin Kovalchik @.***>
wrote:

Hi Yew Mun,
That's good to hear! Which script files did you need to edit? Was it a
problem with the MhcVizPipe distribution? Or did you use seperate
installations of netMHCpan and GibbsCluster that needed to be set up? I'm
just trying to determine if I need to fix anything in the "standalone"
distribution of MhcVizPipe.
Thanks!
Kevin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CaronLab/MhcVizPipe/issues/8#issuecomment-857652202,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUA3RJR4AUUOHR2IDKWJKB3TR5NAHANCNFSM44UFHOOA
.

Hi Yew Mun,
Thanks for your feedback! There are supposed to be some scripts in the standalone installation that are already set up to run the tools in the"tools" folder, but I'll have to go have a look at them! Sometimes I think things work on my test systems, but it is only because I have run them so many times that I forget to reset everything before testing... :)
I'll go ahead and close this issue. Let me know if any other problems come up.
Best wishes,
Kevin


Reduce RAM usage of spatial_error_propagation by optimizing subsampling of pairwise distances

It was an easy bug fix: moved the subsampling before computing pairwise distances instead of after, which requires using cdist instead of pdist/squareform.
Added new test with large data input, previous ones checking accuracy still passing.
Resolves #590

FYI @adehecq this is resolved (for a future xdem-demo :wink:)


Add ravif integration with multithreading

Happy to hear others' opinions on this, but I'd consider this low priority for the web site. Chrome already has an AVIF decoder, and Firefox will have one soon. Safari will get one eventually.

Removing help wanted label for now until we land on how we go about it :)

I think @RReverser was looking into this on the promise that ravif was faster than the ref implementation.

Chrome already has an AVIF decoder, and Firefox will have one soon. Safari will get one eventually.

It's an encoder too, not just a decoder.

I think @RReverser was looking into this on the promise that ravif was faster than the ref implementation.

Yeah, this..

Ohhhh, my bad! I didn't realise it was an encoder. Sorry.

No worried. I'm adding the "help wanted" label back then.


Fix/increase nginx timeout

Proposed changes
Problems:

The conformance tests consistently fail during setup because NKG times out waiting for the nginx process to start.
The conformance test makefile command runs the incorrect set of tests and times out before running all tests.

Solutions:

Increase the pid timeout (i.e. the time we wait for nginx to start) to 10s. This is sufficient in my local environment.
Update the list of supported features and exempt features and pass them to the conformance test suite, and increase the go test timeout to 25 minutes to allow the suite to complete. I also added the debug flag to increase the verbosity of the test output.

Testing: Ran the conformance tests locally. Confirmed that they will consistently pass setup and run to completion.
Checklist

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn

Yep, we need to handle this. Do we have a ticket for this yet? If not, I can create one.

we have a related https://github.com/nginxinc/nginx-kubernetes-gateway/issues/664 but nothing about retrying reloads

@kate-osborn

Yep, we need to handle this. Do we have a ticket for this yet? If not, I can create one.

we have a related #664 but nothing about retrying reloads

Updated the ticket to include retries


Update storage-engine.adoc - minor spelling fix in documentation

architecture/storage-engine.adoc
line 247 has spelling mistake "BIT" in-place of "BTI".

Hi! Thanks a log for the catch!
Following the contribution guidelines, could you please attach a Jira ticket to the PR?
Thanks!

jira : https://issues.apache.org/jira/browse/CASSANDRA-20168

Thanks a lot for creating the ticket! The change LGTM.
+1 (nb)

merged with https://github.com/apache/cassandra/commit/227d294986532d460ee6cadd1a237a3a10b67538


Render dropdown menu in a wormhole

By setting renderInPlace=false to prevent clipping issues
Closes #561

@simonihmig Would this be possible to implement for BS3 as well? I have a container with overflow: hidden, and a dropdown inside it that gets clipped by the container. Or has the world moved on from BS3 to BS4 now

@Techn1x would probably be possible. BS3 does not do this, so the default should still be to match BS3, but an opt-in to use the same ember-popper based positioning and "wormholing" should be possible. I won't have the time for this unfortunately, but if someone wants to tackle this, I would be happy!

I have discovered some menus in my app which appear to be broken by this change. Here is a menu in the top right corner of my page:

No options specified
with renderInPlace=false

Is that to be expected? Is there a fix necessary to either this library or ember-basic-dropdown to avoid this issue?

@bgentry are you sure this was caused by this change? The only code change was to enable changing renderInPlace, before it was always true (same as when not specifying it now)...
Also, on https://www.ember-bootstrap.com/#/components/dropdown, when using a narrow screen that would cause the menu to be clipped, the menu is correctly moved to the left to fit in the view:

@simonihmig heh, no, clearly it couldn't have been caused by this specific change 🤦♂ Sorry about that.
Not really sure where else to look for the cause. The dropdowns in question don't have any real customization to them 🤷♂


Active shortcut not working on xorg

For wayland it runs normally, but after the change to xorg something happens, I can't use active shortcut.

journalctl -f -o cat | grep -E 'flypie|'
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288
[xkb] BOGUS LENGTH in SetMap: expected 268 got 1288

Fedora 34
GNOME Shell 40.4
fly-pie: version 8

Thanks for the report! However, I cannot reproduce the issue. I just tested it in a Fedora 34 VM and the menu works fine, both under Wayland X11. I get the same warnings (I also get these on Ubuntu, btw) so I think these are not directly related.
Just to be on the safe side: If you manually press Ctrl+Alt+Arrow, the workspace is switched?
Could you test this with other shortcuts, like print, volume up or Ctrl+Z?

Press manually everything work fine, like Ctrl+Alt+Arrow.
shortcuts ctrl+z, alt+1 in text editor doesn't work, but instead writes z, or 1 in text editor, for print nothing happens.

That's weird. What shortcut are you using to open the menu?

i  use shortcut ctrl+space to open menu

Okay, finally I know this problem. this happens because I didn't use English (US) input sources in keyboard gnome setting.
Try use different input source, I am using Indonesian (latin)

That's a good find! I randomly selected the Bosnian input source on my end... and it does not work anymore! Later today I will look into the code. I am pretty sure that this is something in src/common/InputManipulator.js...

Btw, I see that you are already using the git version! If you have some basic JavaScript knowledge, you can also try to find the issue in parallel. There must be a difference in how these modifiers work between Wayland and X11...
You could start by putting utils.debug("hello world"); anywhere in that file. Then ./scripts/create-release.sh -i, restart GNOME Shell and observe the output with journalctl -f -o cat | grep -E 'flypie|'.

I just revisited this one and it seems to work now.... I am currently on GNOME 42. Have you tried this once more?


Guidelines to join EOSC - creation of the main page

guidelines to join the eosc compute platform
Main source: https://documents.egi.eu/document/3807

Summary

Related issue :

@paolini78 I assume you will add more content soon. As it's not marked as a draft, please let us know when it will be ready for review and merging.


test: use fs-fixture

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update PackageName for Dapr CLI Preview 1.9.0-rc.1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Similar to https://github.com/microsoft/winget-pkgs/pull/84682, the PR updates PackageName for Dapr CLI 1.9.0-rc.1

cc @ItzLevvie2


Checkbox "Do not show in recents"

Which prevents link to be appeared in "Recents"

As stated in #23: there will be no overall table. This makes this feature no longer needed.


Missing info on JSON payload

https://github.com/Azure/Industrial-IoT/blob/master/docs/modules/publisher.md in the telemetry format section explains that "ApplicationUri": "urn:myopcserver" is sent as part of the default payload if no special config file is defined with --tc flag.
This is what I am getting:
[IoTHubMonitor] [11:00:42 AM] Message received from [edgeVM4opcua/OPCPublisher]:
{
 "NodeId": "ns=1;s=freemem",
 "DisplayName": "Available RAM",
 "Value": {
   "Value":<PHONE_NUMBER>,
   "SourceTimestamp": "2019-11-03T10:00:39.5083379Z"
 }
}

Hi @lucarv,
that's correct, the ApplicationUri is set as being sent with default settings. Can you share the command line parameters and the version of the publisher that you are running?
Thanks!
Markus

I am using the default parameters that came with the version in the marketolace
Get Outlook for Androidhttps://aka.ms/ghei36

From: markusstuhler<EMAIL_ADDRESS>Sent: Wednesday, November 6, 2019 10:17:47 AM
To: Azure/Industrial-IoT<EMAIL_ADDRESS>Cc: Tayo Carvalhal<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/Industrial-IoT] Missing info on JSON payload (#144)
Hi @lucarvhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flucarv&data=02|01|Tayo.Carvalhal%40microsoft.com|4433676bec704f6d1e3b08d7629a30d5|72f988bf86f141af91ab2d7cd011db47|1|0|637086286705257748&sdata=gY%2FEum9u8kyvpRtalI5nSBFlADFmwk7ojtxVtoF2dE0%3D&reserved=0,
that's correct, the ApplicationUri is set as being sent with default settings. Can you share the command line parameters and the version of the publisher that you are running?
Thanks!
Markus
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FIndustrial-IoT%2Fissues%2F144%3Femail_source%3Dnotifications%26email_token%3DAE7FSC2YV5DNC5B43GH45JTQSKDTXA5CNFSM4JIKSUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDF26ZI%23issuecomment-550219621&data=02|01|Tayo.Carvalhal%40microsoft.com|4433676bec704f6d1e3b08d7629a30d5|72f988bf86f141af91ab2d7cd011db47|1|0|637086286705257748&sdata=G7RCtD%2FAa6ZfwnWlDcUjwywj2nW8%2Fa8rdn5JdOkzGAI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE7FSC7WBMNA5WV7G4TNS6DQSKDTXANCNFSM4JIKSUUQ&data=02|01|Tayo.Carvalhal%40microsoft.com|4433676bec704f6d1e3b08d7629a30d5|72f988bf86f141af91ab2d7cd011db47|1|0|637086286705267744&sdata=bf9%2FyOafc77mtOrgsDQhilyz8aGLEWi5inart55bLNo%3D&reserved=0.

I couldn't reproduce this on my end. Please try if the issue persists with the latest version and reopen if so.
Thanks!
Markus


Add IgnoreEmptyDirectories to SkipWhenEmpty inputs

Most of those inputs should ignore empty directories as well.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Would it make sense to review all the other tasks that are not marked with @SkipWhenEmpty as well?

Maybe. Though most of the problems come from directories which are checked into version control, and those are mostly sources. So I think we captured most of the tasks here already.


@GraphQLIgnore is not available on field with lombok

@GraphQLIgnore is not available on field with lombok
@GraphQLType
@Getter
@Setter
class A{
  @GraphQLIgnore
  private Long id;
}

field id is still exists in the schema

@whalevii-xujifeng
For your input type you have to annotate field with @Setter(onMethod_= {@GraphQLIgnore}).
For your output/response type you have to annotate field with @Getter(onMethod_= {@GraphQLIgnore})

Also see #160 due yo be released in 0.9.10


Parser seems very broken

NVM, the issue was me blindly copy-pasting the README Parser example, which does not have any break statements in the switch!

Operator error 🙄

Thanks for the PR, merged!


HDDS-4292. Ozone Client not working with Hadoop Version < 3.2

What changes were proposed in this pull request?
The ozone client is not working with Hadoop Version < 3.2.
The issue is due to not properly initialization of the proxy object.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4292
How was this patch tested?
Tested the fix on a cluster with Hadoop version 3.0

+1 LGTM

Thank You @vivekratnavel for the review.


chore: promote my-node-http to version 0.0.1

chore: promote my-node-http to version 0.0.1
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix(browser): fix state updates on unmounted component

keymapChangeDelayer.trigger delays the execution of callback which may cause state updates triggered on unmounted component.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


fix(rpc): reduce websocket message limit to 10MB

Description
Closes: https://github.com/zeta-chain/security/issues/50

to see if it affects them by any chance ?
Very unlikely I think, we were using a very high value, 10MB is the regular limit


Helen/admin validation

all admin dashboard inputs will throw validation errors rendered from server.
FOR QA:

[ ] try triggering any errors you expect to be thrown on validation for questions, range options, and dropdown options.

Please let me know if there's any validation errors you expect to be thrown that aren't, or if any errors occur without the validation message notifying you.

Pending linting fix, this is good to go 🎫 <-- ONE MERGE TICKET, PLEASE USE AS SOON AS POSSIBLE


Rename the package and repo since indented is supported

Rename the repo
Publish under a new name
Deprecate the old package on npm

https://github.com/wkillerud/sassdoc-parser/releases/tag/v3.3.0


Invalid compilation error with decimal constant-reference-expr

Description:
$title, for a constant that uses a type reference type as the type descriptor and an int literal as the expression.
Steps to reproduce:
type Seconds decimal;

const Seconds STALE = 0;

public function main() {
    Seconds _ = STALE;
}

Affected Versions:
slbeta6-SNAPSHOT

type Seconds decimal;

const Seconds STALE = 0.0;

public function main() {
    Seconds _ = STALE;
}

fails with incompatible types: expected 'Seconds', found 'float'.
The following works.
type Seconds decimal;

const Seconds STALE = 0.0d;

public function main() {
    Seconds _ = STALE;
}


Update rake task to automatically fix invalid base paths

Trello: https://trello.com/c/TcubFZOu/20-fix-taxons-with-incorrect-base-paths
There are ~4400 taxons with invalid taxon paths due to the work to bring taxons from topics, policy areas, etc. When importing, the base paths were created to match the tree structure (e.g.. /imported-topic/topic/medicines-medical-devices-blood/medical-devices-regulation-safety). However, this should match the URL structure of /highest-level-taxon-name/taxon-name, rather than /level_1/level_2/level_3/....
There are two cases that we can automatically fix, one is the above, whereby we take the level one prefix (e.g. /health-and-social-care in the example above) and parameterise the title (e.g./medical-devices-regulation-and-safety) to build a valid base path. It's likely that we'll run into errors from the Publishing API from the generated base paths that have already been taken, but that's okay, the aim of this task is to reduce the number of taxons with invalid base paths down from ~4400.
The second case is simpler, where the level one taxon base path has been updated, but the children's prefix has not. An example of this currently is the Employment taxon:
✅ /employment
❌    ├── /work/pensions-and-ageing-society
❌      ├── /work/older-people
❌      ├── /work/public-service-pensions
❌      ├── /pensions/automatic-enrolment-in-workplace-pensions
❌      ├── /pensions/state-pension-simplification

Closing this for now until I produce a better implementation that will result in more unique base paths. After running this in integration, there was still ~1100 taxons that were failing validation.


NullPointer exception in DefinitionsBuilder.ProcessProperties

schema.Required is null

Thanks, new version released with check for null value


Go to Next Problem scope

It would be nice to have also a possibility to have a "Go to Next Problem" scoped only within the currently opened file instead of the whole project.

/duplicate of https://github.com/Microsoft/vscode/issues/47367


What is the $elem in the documentation?

I can't seem to figure out if it stands for the jQuery object itself or the $panzoom instance that follows.
$treeDisplay = $("#tree-display");
$panzoom = $treeDisplay.panzoom();

Would $elem be $treeDisplay or would it be $panzoom?

It would be $treeDisplay or you could simply replace $elem with "$("#tree-display");"


Add AST node type HardwareQubitIdentifier

Before this PR
The ANTLR lexer and ANTLR parser distinguish between two kinds of identifiers with two tokens Identifier and HardwareQubit.
However before this PR, both of these tokens are merged into a single ast node, ast.Identifier, in the openqasm3 module. For example:
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/openqasm/openqasm3/parser.py#L634-L635
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/openqasm/openqasm3/parser.py#L789-L792
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/openqasm/openqasm3/parser.py#L862-L865
Change introduced by PR
This PR instead associates qasm3Parser.HardwareQubit with a new type of node ast.HardwareQubitIdentifer. As before qasm3Parser.Identifier is associated with ast.Identifier.
Why
Before this PR, this semantic distinction must be made immediately by any downstream consumer in order to do anything useful. This is done by checking if the property Identifier.name begins with the character $.
Instead the semantic distinction should be done as early as possible without losing flexibility.

I'm not certain this is the right way to go - I think it could be, but it depends on whether you think about this as being a syntactical distinction or a typing one.  I personally think of the idea of hardware qubits as just being a typing distinction, where the $ introductory sigil is needed because these symbols are implicitly defined, and it supplies the type.
In that view, I'm not certain that making a distinction in the class of the AST node makes sense; more properly (to me), it would be attached as the typing information to the Identifier node itself.  This AST doesn't include typing information for any node right now.  I'm not clear that separating this as a new class makes any difference to consumers; they still have to verify the typing information when consuming the tree, but now we have a split between two different types of identifier classes that need to be made to interact with whatever symbol table setup they have.
For example: we're not suggesting making a "GateOrSubroutineIdentifier" node, even though that those are other identifiers that have specific constraints on where they can be semantically valid.  To push it further, we won't have a VirtualQubitIdentifier either, because that's typing information (which to me is the same thing that's going on with HardwareQubitIdentifier).

The motivation for this PR is that things like supporting physical qubits when converting OC3 to Qiskit (https://github.com/Qiskit/qiskit-qasm3-import/pull/2) would be cleaner and easier if we made some kind of semantic distinction.
Is there a reasonable scenario where you'd want to undo this distinction and merge the two elements again into Identifier? I didn't try hard to come up with an example. If the answer is no, then I think the the distinction should be preserved somehow.
There is good reason to call these elements literals rather than identifiers. If we want to design for the eventuality that OC becomes broadly adopted, I don't think it's a good idea to cater too closely to the needs of the low levels of the hardware stack. But I'd be interested to see the argument for not treating them as literals. I'm not committed to any interpretation at present.
In fact, the qss-qasm parser currently does this
Larger set of allowed identifiers for physical qubits: `'$' (([a-zA-Z_]* [0-9]+) | [a-zA-Z_]+)`

(Here is a list of all difference wrt the spec)
It would be worth looking at how other languages deal with things like this. I can't imagine they don't make the semantic distinction at the level of element type in ASTs or IRs. I think most people would agree that parsing the identifier after it is part of an AST to find out  what it means is not the right approach.

For example: we're not suggesting making a "GateOrSubroutineIdentifier" node

But this is different. All of these other identifiers have the same syntax.

There is good reason to call these elements literals rather than identifiers.

That depends on your perspective - I mentioned that I started off thinking of them as literals like you, but I do very much buy the argument Thomas and his team make in the linked PR about why they make sense as declarable identifiers, and they're one of the few teams who have an actual implementation of OpenQASM 3.  Treating it as an identifier in an AST with complete typing- and declaration-site (or lack thereof) information lets us satisfy the needs of both schools anyway, so I would definitely lean in favour of that.

Is there a reasonable scenario where you'd want to undo this distinction and merge the two elements again into Identifier?

Let me be careful here, because there's two things at play.  For the syntactic difference, yes we should erase it, because that's the difference between a parse tree (what ANTLR generates) and an AST (what the package generates, and what downstream consumers in the compiler stack want). As I understand it (could well be wrong), qss-qasm has this same split - the distinction you mention is during lexing/parsing, but if you look at an AST node (say ASTReset), it's built from an ASTIdentifier which carries type information.
What we're throwing away here is the typing information, which we shouldn't.  It so happens that in this particular case we get the typing information from the parse tree, but for every other Identifier we would read it semantically from the declaration site.  We actually have both pieces of information available and we "throw away" (perhaps better: don't calculate) both in this package.
My argument is that the proper way to do what you want (which is a valid concern) is to expose type information on all Identifier nodes (actually all Expression nodes, and more besides).  This PR is a half measure: it retains some part of the parse tree, because that can technically be used to infer the typing information slightly easier, but isn't extensible to handling the rest of typing information.  My way gets you what you want (type information), and what I want (a more abstract tree).

There is good reason to call these elements literals rather than identifiers.

That depends on your perspective - I mentioned that I started off thinking of them as literals like you, but I do very much buy the argument Thomas and his team make in the linked PR about why they make sense as declarable identifiers, and they're one of the few teams who have an actual implementation of OpenQASM 3. Treating it as an identifier in an AST with complete typing- and declaration-site (or lack thereof) information lets us satisfy the needs of both schools anyway, so I would definitely lean in favour of that.

Is there a reasonable scenario where you'd want to undo this distinction and merge the two elements again into Identifier?

Let me be careful here, because there's two things at play. For the syntactic difference, yes we should erase it, because that's the difference between a parse tree (what ANTLR generates) and an AST (what the package generates, and what downstream consumers in the compiler stack want).

I am fuzzy as to what parse tree means.
qss-qasm does not generate, or emit, any parse trees. In fact, qss-qasm doesn't generate any trees of any kind. LALR(1) parsing is based on stacks, not trees.
qss-qasm emits an AST with an associated semantic analysis. Part of the semantic analysis is done during lexing, another part during parsing, and yet another part after the AST has been generated - during an as-of-yet unimplemented and subsequent semantic analysis pass that I am in the process of writing.

As I understand it (could well be wrong), qss-qasm has this same split - the distinction you mention is during lexing/parsing, but if you look at an AST node (say ASTReset), it's built from an ASTIdentifier which carries type information via the symbol table.

Nope. Not at all.
An Identifier does not denote, record, identify, or describe a Type.
Identifiers are just human-readable (and human-understandable) mnemonic devices invented for the sole purpose of making the programmer's life easier.
The one and only thing that an Identifier represents - in abstract - is an association between a Type and a memory location. An Identifier does not represent a Type, and Types exist independently of Identifiers. Types are defined by the Language Specification. Identifiers are invented by the programmer.
Some specific Identifiers may be promoted to Reserved Keywords. For example, pi. In that case, the Reserved Keyword contains, and describes, its Type information. That semantic information is described and conveyed by the Language Specification (read: convention), not by the Identifier itself.
For example (in C):
typedef struct _giraffeS {
  unsigned height;
  unsigned weight;
  unsigned length_of_neck;
  unsigned number_of_splotches;
} giraffe_t;

// in some other translation unit:

giraffe_t Rosie = { 48, 1000, 18, 53 };
int Binky = 3;

// ...

The Identifier Rosie doesn't tell us anything about its Type (giraffe_t) anymore than Binky does (int). In fact, the following two declarations:
giraffe_t TZAlKC2P0zXaBjbSwdp = { 48, 1000, 18, 53 };
int KlrmMgA1g5XfWGcg9hn = 3;

are functionally equivalent to the previous two.
For all we care, the compiler is free to throw away the Identifier invented by the programmer, and use some other means of representing the association between the Type and the memory location.

ASTReset, is built from an ASTIdentifier which carries type information via the symbol table.

Nope.
ASTResetNode is not built from an ASTIdentifierNode which carries its type information. The Type of ASTResetNode is built from itself, and is contained within, and is determined by, the ASTResetNode itself. Nothing else.
The fact that ASTResetNode contains an ASTTypeEnum that records  its Type is yet another convenient device artifact, invented for two purposes:

making the compiler developers' lives easier.
avoidance of dealing with C++'s typeinfo subsystem, which is much slower than enum (integer) arithmetic (typeinfo involves function calls, and they add up in terms of CPU cost).

The fact that the ASTResetNode's ASTIdentifierNode contains a pointer into its Symbol Table location is, again, another convenient device, again invented solely for making the compiler developer's life easier.
I could have written qss-qasm's AST generation in a completely different way, and without these helpful artifacts. Using a Symbol Table was entirely optional. Using ASTTypeEnums instead of C++ typeinfo was also entirely optional.
For example, I could have just recorded memory addresses and their associated Type information, as provided by typeinfo. Functionally, this hypothetical implementation would be 100% equivalent to the current one. It's just that it would be much more difficult to deal with for downstream consumers of the AST, and much slower.

Thanks for the detailed explanation Stefan.  I think there's some minor terminology differences we've used, but the architecture I'm advocating for is largely the same as qss-qasm - I was using it as an example of what I think this PR should aim for.
When I was saying "type information", I was meaning the information represented by ASTTypeEnum. I recognise that's not the only equivalent way to store that information (since this PR gives another), but I agree it's a very convenient one, and it's the style I was advocating too (albeit coming from much less experience than you).
In the last sentence you flagged, I meant that I thought you could use the ASTIdentifier node to access the type information attached to that memory location using the symbol table. I might not have got the precise details right, but the main point was that in the qss-qasm AST, you have one C++ class for all identifiers, regardless of the type attached to the memory location for each. I'm saying that that's the same architecture I would want here too.
I don't believe I said that qss-qasm generates a parse tree.

two different types of identifier classes that need to be made to interact with whatever symbol table

We have two types of identifiers, represented by different regexes. This is different than two identifiers that satisfy a single regex, but that are assigned different types based on the context they occur in. In the former case, it looks practical to me to preserve the distinction between these different types of identifiers. But I agree that two types of identifier sharing a symbol table makes the design less clean. Having a separate table for hardware qubits might be a good solution.
It looks practical and clean to me to make the distinction in the lexer between identifiers for hardware qubits (or literals, or whatever semantics you attach later) and identifiers for everything else, and then preserve that distinction in all subsequent stages. (I'm eliding that we determine the semantics of some identifiers and they are consumed in going from the ANTLR parse tree to the AST)  If we don't want to do this, then perhaps the next cleanest thing would be to replace this
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/grammar/qasm3Lexer.g4#L138-L139
with
Identifier: (FirstIdCharacter GeneralIdCharacter*) |'$' [0-9]+;

And hardware qubits would be recognized at a later stage with a regex that separates these two rules.
The mixed approach, which is the approach we have now, makes the least sense to me. That is:
Step 1  Make a distinction between identifiers and hardware qubits
here:
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/grammar/qasm3Lexer.g4#L138-L139
https://github.com/openqasm/openqasm/blob/7c98e1b2e88a033be247c1edb1926d048f18ffb9/source/grammar/qasm3Parser.g4#L208-L209
Step 2 Remove the distinction between identifiers and hardware qubits
Shown in the code snippets linked in the first comment in this PR. Both ctx.Identifer and ctx.HardwareQubit are mapped to ast.Identifer. In the AST, hardware qubits are no longer recognized. This is what I meant by "throw away". We deliberately erase information. This would be ok if we didn't need it. But, in the next step we actually recompute it...
Step 3 Make again the distinction between identifiers representing virtual qubits and hardware qubits
This happens when translating the AST to something else, for example Qiskit circuits. We use the same regex that the lexer used in Step 1.
I think a better design would not require using the same regex twice on the same data.

John, I think you've missed the main thrust of my response to you.  I am not arguing to maintain the status quo.
If we wanted HardwareQubit to be a literal value, like FloatLiteral or IntegerLiteral, this PR would be perfect.  However, the discussion in #417 explains why there's good reason to want to treat them like declarable constants instead.  If so, then I think it's easier for consumers if it is treated in the AST like any other declarable thing (e.g. looks like ast.Identifier), provided we also make the inferred type information available for identifier expressions.
What I'm suggesting instead is that we add a type resolver to this package.  For example, in Python land astroid exposes lookup on Name that returns all assignments to that Python name (as defined by the scoping rules) and mypy's Var node in its typed AST has a direct type field that's filled during typing analysis.  In C land, clang's AST uses (e.g.) Expr::getType() to expose the information (though I can't pretend to be anything more than a beginner on LLVM's source).  qiskit-qasm3-import has to do all its type resolution itself, but I never wanted that.  It was just a workaround because this package doesn't do it.  We still want the split in the ANTLR grammars, because that's how this package infers that particular piece of typing information, and can then re-expose it in the more abstract form.

I should highlight that this package uses the term Identifier atypically, which may well be causing confusion.  Here it's an AST node in the Expression tree, more akin to Name in astroid or DeclRefExpr in clang, except it doesn't come with any of the extra information those two ASTs provide.  This package doesn't have anything like clang's IdentifierInfo, though it will likely need to gain something similar.

What I'm suggesting instead is that we add a type resolver to this package.

Got it. I have some questions. But perhaps that belongs in an issue devoted to adding a type resolver.

Closed based on TSC discussion 2023-09-13, in order to leave options open for other directions eg changing the spec to maybe treat hardware/virtual qubitness as convention rather than  language syntax.


Add reconfigureOnUpdate flag to help performance

Also make sure to close open dialogs when component unmounts
Attempts to address issue #10

Hey @bikegriffith sorry its taken so long for me to review, everything looks good thanks for the contribution!


Beanie Query Syntax Not Recognized

The Beanie .find(), .find_many() and .find_one() methods, when used with the Beanie search criteria syntax always return every document, regardless of the search criteria.
Using your test as an example and adjusting slightly, if we create two documents and then make a query that should only return one, we still get both documents returned. Example below:
@pytest.mark.anyio
async def test_beanie():
    client = AsyncMongoMockClient('mongodb://user:pass@host:27017', connectTimeoutMS=250)

    await init_beanie(database=client.beanie_test, document_models=[Product])

    chocolate = Category(name='Chocolate', description='A preparation of roasted and ground cacao seeds.')
    tonybar = Product(name="Tony's", price=5.95, category=chocolate)
    newbar = Product(name="Test", price=5.95, category=chocolate)
    await tonybar.insert()
    await newbar.insert()

    find_many = Product.find_many(Product.name == "Test")
    assert find_many.motor_cursor
    assert await find_many.count() == 1 # This assert fails: 2 != 1

Additionally, you can see this happening in your test as it stands because of a typo. Line 37, there's a typo; "Chocolade" instead of "Chocolate". This query should return no documents, but your asserts on 38 and 39 still pass because the beanie syntax is essentially ignored.
I've found that these methods still work with pymongo syntax. For instance, modifying the search in my example above:
@pytest.mark.anyio
async def test_beanie():
    client = AsyncMongoMockClient('mongodb://user:pass@host:27017', connectTimeoutMS=250)

    await init_beanie(database=client.beanie_test, document_models=[Product])

    chocolate = Category(name='Chocolate', description='A preparation of roasted and ground cacao seeds.')
    tonybar = Product(name="Tony's", price=5.95, category=chocolate)
    newbar = Product(name="Test", price=5.95, category=chocolate)
    await tonybar.insert()
    await newbar.insert()

    find_many = Product.find_many({"name": "Test"}) # using pymongo syntax here
    assert find_many.motor_cursor
    assert await find_many.count() == 1 # This now works with the pymongo syntax.

This test will pass because it uses pymongo syntax.
In short, it seems that the native beanie search syntax is essentially omitted and all documents are always returned in the case of .find() and the first document is always returned in the case of .find_one(). I may try and poke around a bit to see if I can work something out myself. Let me know your thoughts!

I looked into the issue and found out that beanie returns not str in keys, but class inherited by str. Looks like mongo can work with that, but mongomock can't. I've implemented normalization of ExpressionField to str (and updated the test), and now everything works. I'm not 100% sure that's safe, but I don't really see downsides at the moment


Dragonphy

updated the pad frame generator to include dragonphy instance, and make clk connection from dragonphy to core

Let's wait to merge this until the phy is ready

Sound good


What does the  en_US.lang not loaded mean?

I get the following error
[WARNING]: CHAT: en_US.lang not loaded, cannot translate chat messages

when trying to connect to a server. What is it about?

It comes from here and means you have not copied the en_US.lang to your working dir, which is used (if present) for chat message expansion. You probaly don't need it and can just ignore that warning.

@gamingrobot should we make that an INFO-level message?

OK thanks


add jellyfish merkle tree paper

Motivation
Adding a new technical paper
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
We have internal QA

:exclamation: before this PR can be merged please make sure that you enable "Allow edits from maintainers".
This is needed for tooling to be able to update this PR in-place so that Github can properly recognize and mark it as merged once its merged into the upstream branch

:exclamation: before this PR can be merged please make sure that you enable "Allow edits from maintainers".
This is needed for tooling to be able to update this PR in-place so that Github can properly recognize and mark it as merged once its merged into the upstream branch

/land

/land

:exclamation: failed to update PR in-place. When this PR is merged Github will improperly mark it as "Closed" instead of "Merged".
In the future make sure that that "Allow edits from maintainers" is enabled, allowing Bors to update the PR in-place before merging and convince Github to mark the PR as "Merged".

:exclamation: failed to update PR in-place. When this PR is merged Github will improperly mark it as "Closed" instead of "Merged".
In the future make sure that that "Allow edits from maintainers" is enabled, allowing Bors to update the PR in-place before merging and convince Github to mark the PR as "Merged".


209 merge cubes

Reference issue #209
Testing:

[X] Ran tests and they passed OK
[X] Added new tests for the new feature(s)

CLA
N/A

@carolinejjones Could a list of the anticipated follow-on work be constructed, possibly on the issue page (#209)? Or a list of assumptions that have been made? For example, the fact that the build_coordinates functionality from SpotData has been replicated here and modified is technical debt that we'll need to clean up at some point, which is related to #180.

Also, could this ukx_standard_v1 metadata convention be added to the Metadata that we have created page?


fix: fix security issues

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


In stage 2, training loss is rising

This is the logs for stage 2:

Stage 1 training is normal:

I only changed the number of GPUs from 4 to 2.

The 2 stage training is unstable because the sample of a video sequence may be causes diverse difficulties in training. It is normal if you train more than 5 epochs, the average loss will slowly decrease.

OK，I will check the results when training is finished.

If you need my training log, i am reproduce my base_256_got model, i will release that maybe 2 hours later?

That's very kind of you for doing so.


docs(tauri-utils): described behavior of version field when omitted

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

God damn it why are my forks always so annoying to work with >.< I really gotta start using branches properly in my forks to avoid accidentally committing more than I intend


FEATURE Improving the Projects page.

The projects page user experience is not good at all.

This can be improved.
Instead of display this dropdown we can display filters on top
Something like this

And we can show all the projects by default and allow the user to filter the projects by clicking on any of the filter buttons.

@AnirudhPanda I would like to work on this


[QA] Number of training tokens for Internlm2 1.8B, 7B, and 20B?

Describe the question.
Hi,
What is the number of training tokens for Internlm2 1.8B, 7B, and 20B models?
Thanks for the great work!

1.8B about 2.2T
7B\20B about 2.6T

Thank you!


fix doc bug for per_image_standardization (unit norm vs. variance)

The first line of the doc states "Linearly scales image to have zero mean and unit norm."  This is incorrect - "unit norm" is calculated by dividing the vector by its L2 norm, and by definition, when you take the L2 norm of the result, it should evaluate to 1.  The result being calculated here is referred to as "unit variance".  Reference: https://en.wikipedia.org/wiki/Feature_scaling

I signed an individual CLA.

I signed it
From: googlebot<EMAIL_ADDRESS>Sent: Saturday, September 22, 2018 7:14 PM
To: tensorflow/tensorflow<EMAIL_ADDRESS>Cc: Roland Fernandez<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tensorflow/tensorflow] fix doc bug for per_image_standardization (unit norm vs. variance) (#22469)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2F&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=jBj%2Bqsz0yE3XA5n%2F%2FB2f9H2RcSex1TMRlDiRfxYWA00%3D&reserved=0 to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA datahttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2Fclas&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=%2FRR0Mcd3fid21TgA8gQo2Oi4dQP6HZy%2Bg13paz7hSfk%3D&reserved=0 and verify that your email is set on your git commitshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=oTNWFETojMXQp1B0aTec1U%2BuZxe3e7%2FEsMal%2BSOy2ss%3D&reserved=0.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoothttp://go/cla#troubleshoot (Public versionhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopensource.google.com%2Fdocs%2Fcla%2F%23troubleshoot&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=hEjTumljm4JG90d3hysDaUtjG0BlRWDPNYtjhEor4II%3D&reserved=0).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA datahttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2Fclas&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=%2FRR0Mcd3fid21TgA8gQo2Oi4dQP6HZy%2Bg13paz7hSfk%3D&reserved=0 and verify that your email is set on your git commitshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=oTNWFETojMXQp1B0aTec1U%2BuZxe3e7%2FEsMal%2BSOy2ss%3D&reserved=0.
The email used to register you as an authorized contributor must also be attached to your GitHub accounthttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=5QUxdFNK22glAdzvw9LpsgRGYTP3JaTuaF%2F4oc3ZD4Q%3D&reserved=0.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftensorflow%2Ftensorflow%2Fpull%2F22469%23issuecomment-423786277&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=8bxpPtgrfx7jyp5eUDokom%2FBQLZqTP3pHFZZUA6NALI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEGN3oDzYx5JtKxBGIHtDl9SCVqFPaTjks5udu5SgaJpZM4W1hcF&data=02|01|rfernand%40microsoft.com|2d4208e751994b011fb108d620fa2ce0|72f988bf86f141af91ab2d7cd011db47|1|0|636732656201260795&sdata=BztzMbz1n6pU0jTZQ8PM8PiFyg71vj6513IFLp8TuYw%3D&reserved=0.


Help with passing in array of line

Hi,
I just started using ics-parse for my website. I want to use the feature of passing in an array of lines, instead of a file, because I'm pulling the VCALENDAR data out of a sqlite3 database. Each line is a VCALENDAR "blob". When I pass in the array of lines, the event_count is 0 and $ical->events() returns NULL. Obviously, my array of lines is incorrect. What should the format of the array of lines be?
Below is a snippet of my code:
$sqldb = new PDO("sqlite:db/db.sqlite") or die(print_r($sqldb->errorInfo(), true));
$sqldb->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
$statement = $sqldb->prepare("select * from calendarobjects where calendarid = 12");
$statement->execute();
$results = $statement->fetchAll(PDO::FETCH_ASSOC);
if ($results)
{
    foreach($results as $i => $row)
    {
        $icsArray[$i] = $row["calendardata"];
    }
}
$ical = new ICal($icsArray);
echo $ical->event_count;
$ics_dates = $ical->events();
echo $ics_dates;

Any help is greatly appreciated!
Thanks! Mark

Hi Mark,
A few things are incorrect with your code.
Firstly, you can't simply pass an array when instantiating a new ICal object as it is expecting a filename which the parser wants to read in line by line. You would also have to iterate over $icsArray for each of your calendars returned from your database as each would need to be parsed separately. Finally, events() ($ics_dates) returns an array so you can't just echo it out.
foreach($icsArray as $calendar){
    $calendar = explode("\n", $calendar);
    $ical = new ICal($calendar);
    echo $ical->event_count . "<br />\n";
    $ics_dates = $ical->events();
    var_dump($ics_dates);
}

Hi,
Thanks for the feed back. You're absolutely right about not being able to echo out an array - duh! As for the rest of the code, let me play around with it to see if I can understand what you're recommending.
Thanks again for your help,
Mark


inherit PKG_CONFIG_PATH from environment

Allows pkg-config to read files from custom install directories during build.
This addresses issue #4161

Could you use tabs for indentations instead of 4 spaces? I'm also more of a spaces guy in python scripts, but it would be better to stay consistent with the rest of the scons scripts :)

Don't know how I missed that. c835108b96724d9a81ccd74fc5d807aae84a0169 should fix it.

Looks good, I'll merge once the CI test is completed.

The build fails with:
KeyError: 'PKG_CONFIG_PATH':
  File "/home/travis/build/godotengine/godot/SConstruct", line 70:
    'PKG_CONFIG_PATH' : os.environ['PKG_CONFIG_PATH'],
  File "/usr/lib/python2.7/UserDict.py", line 23:
    raise KeyError(key)

I guess it would be safer to use os.getenv('PKG_CONFIG_PATH') as it would return None if no the variable is not set (or a default value passed as a second argument to getenv()). (Maybe also for the PATH while you're at it)


android 13, Unable to disconnect wifi, still it is connected

android 13, Unable to disconnect wifi, still it is connected.  also please let us know how to delete credentials.

Hi @RaguRam1991 I am having the same issue. Any luck?


When will the code be released?

We've been very busy lately，and the code will be released in September.

Hi, if you are too busy to release the code, could you tell me the details of the training and validation on SemEval2010 Task8?

We've been very busy lately，and the code will be released in September.

Hi, if you are too busy to release the code, could you tell me the details of the training and validation on SemEval2010 Task8?

The code has been released in the repo.


Handle invalid curve points

Also replaces some invalid test data.

@mikelodder7 — are you happy with the solution @andrewwhitehead has implemented — banning infinity points?


Add BandWidth and %B to Bollinger Bands indicator

Description

Add new calculations to existing Bollinger Bands indicator

BandWidth = ( (Upper Band - Lower Band) / Middle Band) * 100
%B = (Price - Lower Band)/(Upper Band - Lower Band)

Related Issue
Closes #4108
Motivation and Context

The BandWidth and %B values are not available.
How Has This Been Tested?

Add new unit tests including external data generated via MS Excel
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Cool, thanks @Adalyat :)


View Blob container option is not present in plugin after selecting a particular blob container

Environment: Windows/IntelliJ14
Steps:
Sign in Subscription.
Click Azure.
Click storage.
Expand a Storage Account.
Expand a particular Storage.
Expand Blobs.
Right Click on a blob container, View Blob container option is not present.
PFB the screen shot.

This issue is fixed and functionality is working as expected in the latest build.

In the Story board the option name is "View Blob container".
Is it OK for naming the option as "View container"?

This issue is fixed and functionality is working as expected in the latest build.


Peek and Pop into menu view controller messes up scroll views

We should delete peek + pop as it provides exactly the same functionality as just tapping the cell

Peek + Pop are used to quickly preview. Its definitely not MVP for 2.0 IMHO maybe comment out and add to 2.X?

Peek + Pop are used to quickly preview. Its definitely not MVP for 2.0 IMHO maybe comment out and add to 2.X? also i don't personally see the bug.

So I jumped the gun on this one. The bug is on my branch. Pop and then scroll to the bottom.


stem() not working correctly

When using stem() to plot a sequence of discrete sequence, a warning message is being printed and isn't plotting correctly.
Y = linspace(-2*pi,2*pi,50);
stem(Y)

fig2plotly(gcf, 'offline', false);

The previous code prints the following warning message:
Unrecognized field name "MarkerIndices".
We had trouble parsing the stem object.
This trace might not render properly.

Expected and generated (https://chart-studio.plotly.com/~xarico10/745/#/) plots:

Examples on using stem() can be found on:
https://www.mathworks.com/help/matlab/ref/stem.html

fixed


date parsing in server/.../metric/bean/CFInstance.java fails

Incoming times look like this:
2016-05-25T19:54:45.507700194Z
The date parser specifes this format:
"yyyy-MM-dd HH:mm:ss ZZZZZ"
It should be "yyyy-MM-ddTHH:mm:ss.SSS" and the incoming string gets cut off
three digits to the right of the ".". There's no need for time-zone data as the
incoming times are in UTC. Don't include more digits in the sub-second part
because parseDigit interprets this as milliseconds, and will overflow.  For example,
the time string "2016-05-25T12:34:56.2000" is equivalent to "2016-05-25T12:34:58.000",
as 2000 msec = 1 sec.

closing since we have pr #32


Drop support for Python 3.7

With py37 EOL approaching fast on 2023-06-27, we should plan dropping support for it in the next Ocean release.
Getting rid of py37 support should simplify the code in a few places.

Done in https://github.com/dwavesystems/dwave-ocean-sdk/pull/261.


:gift_heart: Auto-skip push to registry if secrets are not set

Changes

:gift_heart: Auto-skip push to registry, if secrets are not set

Allows to build images, checking the build

/kind enhancement

Builds well: https://github.com/cardil/kn-plugin-event/actions/runs/3639317955/jobs/6142552634
/cc @mgencur
/cc @pierDipi

I would like to have option to run those builds for PRs, and other development branches, so you may know that it should build the images well, before the merge.

In that case, can't we use something like if: github.event_name == 'push'?
it seems like an hack to use secrets presence to infer push or not push

What does it bring ... depending on the secrets? This github action will always run on github, not locally.
It's more understandable to have what @pierDipi suggested. The user knows that pushing will be done only on push, not in pre-submit phase. If you want this for debugging purposes to run this on your repo then pushing the images will fail anyway if you don't have the secrets set, which might be a good signal. In other words, failing the github action if the secrets are not provided is expected.
Depending on the presence of secrets only raises questions like the one from @pierDipi . Using if: github.event_name == 'push' makes it clear immediately.

@mgencur wrote:

What does it bring ... depending on the secrets? This github action will always run on github, not locally.

Sure, it will always run on Github. I thought this may allow testing the build on fork, as the forks doesn't have secrets configured.

It's more understandable to have what @pierDipi suggested. The user knows that pushing will be done only on push, not in pre-submit phase. If you want this for debugging purposes to run this on your repo then pushing the images will fail anyway if you don't have the secrets set, which might be a good signal. In other words, failing the github action if the secrets are not provided is expected. Depending on the presence of secrets only raises questions like the one from @pierDipi . Using if: github.event_name == 'push' makes it clear immediately, it is self-documenting.

I think both of those conditions are valid. I'll add github.event_name == 'push'. That would allow to run this workflow for the pull_request event.


CSS: push footer to bottom of viewport

Awesome, i was missing margin-top. Thanks ❤
Not optimal on my mobile screen for short lists, but good enough.


Updated for Swift 3.

Thanks @guykogus! I need to set aside some time to review this; will most likely be next week.

No worries. We're still a fair way off from the official release of Xcode 8/Swift 3 so, if anything, this should go in its own separate branch anyway.

Awesome! I've merged in the changes via https://github.com/stormpath/stormpath-sdk-ios/tree/swift3
I had some issues running the tests in Xcode 8 / iOS 10 because of http://stackoverflow.com/questions/20344255/secitemadd-and-secitemcopymatching-returns-error-code-34018-errsecmissingentit/22305193#22305193
I'll need to try running this in a sample app to make sure that everything works correctly.
Thanks for your help, @guykogus! Closing #26


Add a favicon to the website

I can add a favicon which will look good on the website under Hacktoberfest.

We do need a favicon. But it should be our logo.

Yes, you can provide me the PNG image you want as a favicon in your website.

You can use the profile pic of devtrack

You can use the profile pic of devtrack

Okay done kindly assign

@Rakesh9100 you are assigned

And one more thing. Pls sync your repo before doing a PR


[Feature Request]: Background sync of models

Problem Description
When I start a new chat often I want to chat a different model than the last one I talked to. At present this is handled via a dropdown with an inscrutible list of names I have to try and mentally translate. Worse I have to remember which one(s) I've already downloaded. This is a huge amount of cognitive load before my morning coffee kicks in.
While that's not so bad, what makes it truly problematic is that at present we don't start downloading a model until it's needed for the first time.
The download process at least on my end seems to not detect when there's been an interruption to the download process.
The end result is if I want to chat a new model I have to sit and stare waiting for it to finish loading and often I have to manually stop and restart the download. Often this occurs because I selected the wrong variant of a model I already downloaded.
Solution Description
A better solution would be to have a configuration option with a list of models available for download, their sizes in GB and a description or at least a link to their HF page. A simple checkbox would do. From there the model(s) would download in the background and it would be lovely if the app could restart failed downloads automatically.
This would replace the current model select in chat, with a list of only the available, already downloaded models. That way I don't start chatting a model I don't actually have and wait ages for it to download.
Alternatives Considered
No response
Additional Context
Great Job so far by the way!

Thanks for the suggestion. This is very similar to something on our roadmap and it also brings some additional valuable points to it. It will be there sometimes in the future :)

Maybe I can pitch in soon. I've been planning to build something like a BitTorrent for AI for awhile now.

parla in italiano


Added command to retrieve the device's platform

Closing to wait for openxc-message format to be updated.


Iraq highway shields

Added a shield definition for Iraq (national) highways. Only highways have been mapped as relations so far; numbered freeways and roads don’t have relations yet. As in Iran (#463), route shields in Iraq bear both writing systems on separate panels, but this style is only showing the Western Arabic numerals that have been tagged in ref.

Are the wide rectangles a deliberate design decision based on OTG signage?

Also, I notice the "5" route in the northeast of the clip above, is that an artifact awaiting a tile update?

Are the wide rectangles a deliberate design decision based on OTG signage?

This was @claysmalley’s suggestion in https://github.com/ZeLonewolf/openstreetmap-americana/pull/557#discussion_r991330355. You can just barely make out the green highway shields on the left side of this photo:

Also, I notice the "5" route in the northeast of the clip above, is that an artifact awaiting a tile update?

That’s Road 5. So far, two roads have been tagged network=IQ-road. Should we add support for this tag even though it uses a hyphen instead of a colon? As far as I know, roads have the same green shield as highways.

In general, I'm not in favor of supporting network values like XX-roads where XX is a country code. I think these network values sprung from a misunderstanding of European road networks (e-road, FR:A-road, etc.) and I think there's a better country-and-colon-prefixed value to use in every case.

We can take care of roads and motorways in separate PRs once the tagging for those catches up to the tagging for highways.


fix(net): Do not punish nodes when Quorum data are missing.

Issue being fixed or feature implemented

Currently, we store internally the nodes that already requested QGETDATA for the same Quorum.
If data for the same Quorum is requested twice from the same proRegTx, then the requester is P2P misbehaved.
What was done?

Some data like VerificationVector and EncryptedContributions are not instantly available.
This PR does not misbehave nodes for requesting data that weren't available when asked.
How Has This Been Tested?

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

makes sense I guess. how about tweaking sendQDATA to make sure we handle request_limit_exceeded correctly in all cases?
diff --git a/src/llmq/quorums.cpp b/src/llmq/quorums.cpp
index dedf7a4263..d64c5f60ae 100644
--- a/src/llmq/quorums.cpp
+++ b/src/llmq/quorums.cpp
@@ -629,13 +629,30 @@ void CQuorumManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
         CQuorumDataRequest request;
         vRecv >> request;

-        auto sendQDATA = [&](CQuorumDataRequest::Errors nError = CQuorumDataRequest::Errors::UNDEFINED,
+        auto sendQDATA = [&](CQuorumDataRequest::Errors nError,
+                             bool request_limit_exceeded,
                              const CDataStream& body = CDataStream(SER_NETWORK, PROTOCOL_VERSION)) {
+            switch (nError) {
+                case (CQuorumDataRequest::Errors::NONE):
+                case (CQuorumDataRequest::Errors::QUORUM_TYPE_INVALID):
+                case (CQuorumDataRequest::Errors::QUORUM_BLOCK_NOT_FOUND):
+                case (CQuorumDataRequest::Errors::QUORUM_NOT_FOUND):
+                case (CQuorumDataRequest::Errors::MASTERNODE_IS_NO_MEMBER):
+                case (CQuorumDataRequest::Errors::UNDEFINED):
+                    if (request_limit_exceeded) errorHandler("Request limit exceeded", 25);
+                    break;
+                case (CQuorumDataRequest::Errors::QUORUM_VERIFICATION_VECTOR_MISSING):
+                case (CQuorumDataRequest::Errors::ENCRYPTED_CONTRIBUTIONS_MISSING):
+                    // Do not punish limit exceed if we don't have the requested data
+                    break;
+            }
+
             request.SetError(nError);
             CDataStream ssResponse(SER_NETWORK, pfrom.GetSendVersion(), request, body);
             connman.PushMessage(&pfrom, CNetMsgMaker(pfrom.GetSendVersion()).Make(NetMsgType::QDATA, ssResponse));

(skipping obvious changes in other places)


MIDI Out Rework

Actually how QLC+ works with midi out is not the best.
QLC+ actually can use only a MIDI out for the entire midi device, but if you use a controller like the Akai APC mini mk2, in which the brightness and the flashing rate of the RGB pads depends by the MIDI channel, you have to choose only one MIDI channel for the entire controller, loosing al the LEDs functionalities.
Some developer have release tool like that https://github.com/revilo196/mk2apc_4light to mitigate this problem, in which the different velocity are mapped on different channel, but if this kind of controllers can work directly with QLC+ is better.
My idea is to add in the custom feedback section of the widget proprieties two SpinBox, one for lower channel and another for higher channel, that will be used together with the two old SpinBox.

THE PULL REQUEST IS NOT FINISHED, il will remove the draft state once the implementation is end.
I have open a pull request just to have a feedback if this kind of feature will be merged, otherwise i will not spend too much time to finalize it, maybe other people likes the current working principle,
The missing parts are:

Implementing them also on Input Profiles
Takes as default value the midi channel used for the input
Check retro-compatibility with previous project and eventually fix it
(If needed) Add it also on QLC+ 5

Finally another parts which i like to modify is the how the values are send in out, actually they are in DMX format [0-255] but before to be sent as MIDI packet they are converted by #define DMX2MIDI(x) (uchar(x >> 1) & 0x7F), and in the case when i have a tables with the velocity related to the pad color by the controller manufacturer like this

It is a nightmare and the users need to calculate the right value to match the color, so i would like to do this conversion only when needed, in a way that the user can enter directly midi values [0-127] if in the current universe the feedback is midi, otherwise for OSC and Loopback [0-255]
But this can broke the compatibility with the previous saved projects.

Thanks for the suggestion! I can't wait to hear @mcallegari's thoughts on this.
On the official Instagram, I get many requests for support using these types of controllers.
I know you said it was a draft but please don't forget to also implement the QML V5 version if you can.
I wonder if doing an overhaul of the way we do midi feedback will one day be necessary. May I be so bold as to request support for selecting the colour in a dropdown menu to fill the values automatically?
In any case, thanks again for contributing to the project.

The problem of this (and many other PRs) is that they focus on a single use case.
QLC+ needs to be and stay generic for any usage case (even future ones). One would say this is a life saver for AKAI devices, some other would say QLC+ is too complicated because it has too many options.
My point of view is to make changes where they actually make sense.
I need to think a bit more about this but a solution is to be found in some dedicated class (eg. a new feedback class) or at input profile level.
Will get back to this later

I think this is a really needed for QLC+, i hope once my code is finished you idea about it will be clear.
But if you think that this feature will be never implemented and my effort are useless, tell me now in a clear way!
For now i'm moving in that direction:
When the input of a vcbutton is a MIDI device, then in the custom feedback section two new SpinBox are visible to change the lower and upper midi channel (as in the previous pictures).
By default these values are the same of the MIDI input values received for that button, but they can be also changed by the user.
While if the button is triggered using a Input different than MIDI, like OSC, everything is as before, so for no MIDI user, this implementation is completely transparent,
Then to have the UI coherent i have implemented the custom midi channel also for profiles, also in this case only on profiles for MIDI devices.
Your idea to implement this feature only on input profile is not a valid option for me, if i have a green button in my virtual console, i should be able to change the color of the controller pad from the button proprieties, and not from the pad settings inside the midi profile.

I get the idea and I too think a solution is needed.
Being also the architect of this project, I have the whole picture (and 12 years of history) of all the usages people make of this software, so if you don't mind, I am the one deciding how a big change like this should be implemented and where in the code.
Yesterday I told you I had to think a bit more about it so I expected you to stop the development until I decided what is the best solution for the project, also not to waste your efforts on it.
For sure I don't want to add complexity to Virtual Console widgets just for the AKAI devices.
Also, please don't draw conclusions in my place.

I get the idea and I too think a solution is needed. Being also the architect of this project, I have the whole picture (and 12 years of history) of all the usages people make of this software, so if you don't mind, I am the one deciding how a big change like this should be implemented and where in the code. Yesterday I told you I had to think a bit more about it so I expected you to stop the development until I decided what is the best solution for the project, also not to waste your efforts on it. For sure I don't want to add complexity to Virtual Console widgets just for the AKAI devices. Also, please don't draw conclusions in my place.

Hey gents I don't think this is a bad step, it seems to be in the right direction.
@mcallegari can we maybe use this as a starting point before a complete ground-up approach is possible? I know there's nothing more permanent than a temporary solution but we will need to remake profiles and this would give us a way to test.

@mcallegari can we maybe use this as a starting point before a complete ground-up approach is possible? I know there's nothing more permanent than a temporary solution but we will need to remake profiles and this would give us a way to test.

Short answer: no.
Long answer:
This would mean:

putting more effort into this PR
me reviewing the code once it's ready
testing the whole thing
starting to modify input profiles
more changes come in maybe in the same area
at some point, revert everything but keeping the latest changes (so conflicts and regressions around the corner)
rewriting the final code
testing the whole thing
rewriting input profiles too

Is this really what you're proposing?

The latest build covers color translation.
Now I'm gonna decide how to do double feedback. It's gonna be quite tricky.
Today I'm gonna pick up an APC Mini MK2 so I can do tests myself with it.

With the last commit, this can be closed.


DEVOPS-593 Slack/Jira slash commands

current list my In Progress issues
createb create a bug param: project_id, summary
createt create a task param: project_id, summary

@rounds/server

I think it'll be easier to remember /jira bug ... and /jira task .. instead of abbreviations like createb and createt

very nice! :+1:
don't forget to pep8 and pep257 it
you can install flake8 and pep257 packages and run them on the file, or embed them straight in vim: https://github.com/oryband/dotvim/blob/master/.vimrc#L413


ftdi-gpio: Use a non-local include for libftdi hdr

@konradybcio could you please rebase this?

ill resubmit from webui to get it signed


artificial intelligence

unit can be controlled by player or by "AI". We must find some concept for it.
perhaps some scripting with Java, Groovy or Rhino. Lua is very common in this way

First I will look at this: https://github.com/libgdx/gdx-ai/wiki


Feature: Added support for Infomaniak kDrive

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #15475

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

kDrive is displayed in Files and copying of files etc. is possible

Note: The Sync Status column is not displayed, but this does not work in Windows File Explorer either. I think kDrive does not set the property “System.FilePlaceholderStatus” correctly, which Files (and probably also Windows File Explorer) uses to find out the status.

@mafra99 does this still work if the user changes the location from kDrive settings?

I have just reinstalled kDrive and now the entry in the registry no longer contains an application name, but only an ID. As a result, kDrive is no longer recognized on my device.

I can think of two other ways to recognize kDrive anyway:

Using the DefaultIcon under Computer\HKEY_CLASSES_ROOT\CLSID<>\DefaultIcon to check whether the path contains kDrive

Via the entry in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\SyncRootManager

To use the entry from SyncRootManager seems safer to me, I have pushed a commit that contains the changes for this.
In the second commit I cleaned up the code a bit and fixed a few warnings.
The method GetDriveType is new and returns the drive type, e.g. iCloudDrive or kDrive. This should make the method DetectGenericCloudDrive a little simpler.
Compared to before, the DriveType is now returned directly as soon as one is detected and the checks for the other DriveTypes are no longer executed.

@mafra99 does this still work if the user changes the location from kDrive settings?

@yaira2 thanks, that actually didn't work. should also be fixed


BrowserUtils: add the possibility to open URLs instead of Strings.

We want to change the GitUrlFactory in the git-plugin to return URLs, but I noticed I still had to provide Strings to the BrowserUtils. This looked like a logical next step to me.
We can possibly deprecate the String method.

I don't mind keeping both options, makes it a tad more usable for some probably.

Thanks for the quick review! Could we perhaps cut a release anytime soon? The current version has an issue with installing plugins (which is solved in the latest snapshot version). See the stackstrace in this PR.
When this is released, I will also update that PR to include the changes introduced in this PR.

@MartinKanters 0.1.4 has just been released and should be available (soon) in Maven Central

You guys are quick! Thanks :)


Use loopDelayS as the primary loop definition

Resolves a TODO in CavaClass.v. The story here is that we initially defined loopDelay, a loop whose body has separate output and feedback results; the body's signature is something like like A * C -> B * C. We later added loopDelayS, which assumes the output and feedback are the same and expects a body with the form A * B -> B. There was a TODO to remove loopDelay from the typeclass and simply define it in terms of loopDelayS, which is what this PR does.
There is a significant proof component here because we had written invariant infrastructure for loopDelay, so I redid these proofs for loopDelayS instead and then used them to re-prove the top-level invariant proofs for loopDelay. Since the existing examples in tests/ do in fact use the same thing for feedback and output, I went ahead and switched them over to loopDelayS.
I also removed the defaultCombType and combType definitions from CombinationalMonad.v because they are exact duplicates of the ones in Signal.v and it's confusing to have both.

No, it unfortunately still doesn't help with #416 because, no matter how we write loops, we will sometimes want to have more than one non-tupled signal in the loop state.

No, it unfortunately still doesn't help with #416 because, no matter how we write loops, we will sometimes want to have more than one non-tupled signal in the loop state.


[FEA] Support AQE’s Dynamically optimizing skew joins feature

I wish we can support AQE’s Dynamically optimizing skew joins feature.
Since we do not support SMJ in GPU mode so this feature is not working.
I did some tests before on this, see http://www.openkb.info/2021/03/spark-tuning-adaptive-query-execution1_18.html for details.

Hi @viadea, I am not sure why we need to "support a GPU version SMJ or be able to convert a GSHJ to GBHJ dynamically".

@sperlingxx I think that sentence is like a how-to-implement so let me remove that sentence to avoid any confusion.
Basically this feature is to support a AQE feature: Dynamically optimizing skew joins.

I don't think this makes sense right now since the spark feature is for SMJ and already stated we convert it to BHJ.  I think we can reopen in the future if needed


Error setting up Labeller, Invalid Token

Getting the following error, what am I screwing up?
Error setting up labeler: XRPCError: InvalidToken > Token is invalid
at XRPC.request (file:///tmp/bunx-1000-@skyware/labeler@latest/node_modules/@atcute/client/dist/rpc.js:82:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async plcSetupLabeler (file:///tmp/bunx-1000-@skyware/labeler@latest/node_modules/@skyware/labeler/dist/scripts/plc.js:55:19)
at async file:///tmp/bunx-1000-@skyware/labeler@latest/node_modules/@skyware/labeler/dist/bin.js:42:31 {
status: 400,
kind: 'InvalidToken',
description: 'Token is invalid',
headers: {
'access-control-allow-origin': '*',
'cache-control': 'private',
'content-length': '53',
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 14 Nov 2024 17:13:54 GMT',
etag: 'W/"35-ejXmOsS85aPypCw7gixnfO0/8dQ"',
'keep-alive': 'timeout=90',
'ratelimit-limit': '3000',
'ratelimit-policy': '3000;w=300',
'ratelimit-remaining': '2998',
'ratelimit-reset': '1731604734',
'strict-transport-security': 'max-age=63072000',
vary: 'Authorization, Accept-Encoding',
'x-powered-by': 'Express'
},
[cause]: undefined
}

I saw this with someone else and this was likely caused by the intermittent scaling issues Bluesky currently has. Closing this for now.


Phonemizers stopped Auto-inputing VCs

Acknowledgement

[X] I have read Getting-Started and FAQ

🐛 Describe the bug
Hello like the title says. OU's Phonemizers stopped automatically input the VCs or even on other banks when they're used as voicecolor. Only if the CVVC VB is stand alone it normally uses it's own VCs multi or monopitch. I remember for example if you bundle and voice color assing
'em, normally it should be:

あ扇風機 a s扇風機 さ扇風機 a k楽 こ楽 i ん扇風機 n ny悲 に悲 i ch楽 ち楽 i w楽 わ楽
and not as:
あ扇風機 a s さ扇風機 a k こ楽 i ん扇風機 n ny に悲 i ch ち楽 i w わ楽.

I notices that when was making a bundle VB for (空音ライ)Sorane Lie using they're other banks made by 三ヶ木ちい(Mikage chii) and color assing each bank.
I wanted to test out they're CVVC append named 贋作 bank, that's the moment I saw for the first time the issue.
Here some screenshots.

Not only it happens with CVVC but with VCVLiteCVVC too (they're rare btw) like Honoka Elie's 女子アナウ(Girl Annoucer)the one with 宣 Suffix. The VCs are needed for the full use.

the next example is about not automaticlly inputing the correct VC when it's fully CVVC supported including appends. it's what I wrote earlier.

not even the EN to JA is safe from the issue.

In short VCV/CVVC VB with any CVVC set as appends/voicecolors VCs will not be inputed or inputed incorrectlly, I don't know if it spreaded even with other Phonemizers, as long there's VCs ver.1.327.0. phonemizers will not auto set the VB even if the notes are in CV format. I mainly use JA Phonemizers I haven't tested with the English ones or the others yet. I dunno they are affected too.
Hope that I fully explained the whole issue, and hope this gets fixed.
P.S. the 3rd and 4th one can be somewhat solved by just using the parameters feature and set at or selecting the desidered color but the 4th one seems to ignore even ending VCs. Please fix it. It might hinder or annoy users. hence why
P.P.S. Sorry for the last bit in the 2nd log I sended I was fooling around with drawn pitch with another bank an' render settings.
P.P.P.S. the third log was about testing the EN to JA Phonemizer.
Explains how to reproduce the bug
To reproduce this bug inshort
1.Update OU from 1.158.0. to version 1.327.0.
2.Select any VB or a VB with a voicecolor assinged CVVC.
3.Select either JA CVVC or Presamp based JA VCV&CVVC Phonemizers.
4.Open any ust,ustx or vsqx or new project, draw some notes.
OS & Version
Windows 11 x64 bit
Logs
log20231204.txt
log20231204.txt
log20231204.txt

If the solution is simply redownload/install OU, let me know.

UPDATE reinstalling did anything unfortunatly.

🐛 Describe the bug
Hello like the title says. OU's Phonemizer stopped automatically input the VCs or even on other banks when they're used as voicecolor. Only if the CVVC VB is stand alone it normally uses it's own VCs multi or monopitch. I remember for example if you bundle and voice color assing'em, normally. It should be:
* あ扇風機 a s扇風機 さ扇風機 a k楽 こ楽 i ん扇風機 n ny悲 に悲 i ch楽 ち楽 i w楽 わ楽
  and not as:

* あ扇風機 a s さ扇風機 a k こ楽 i ん扇風機 n ny に悲 i ch ち楽 i w わ楽.

I notices that when was making a bundle VB for (空音ライ)Sorane Lie using they're other banks made by 三ヶ木ちい(Mikage chii) and color assing each bank. I wanted to test out they're CVVC append named 贋作 bank, that's the moment I saw for the first time the issue. Here some screenshots.  Not only it happens with CVVC but with VCVLiteCVVC too (they're rare btw) like Honoka Elie's 女子アナウ(Girl Annoucer)the one with 宣 Suffix. The VCs are needed for the full use.

Are you using the Japanese Presamp Phonemizer here? It could be an issue with the presamp.ini file.

the next example is about not automaticlly inputing the correct VC when it's fully CVVC supported including appends. it's what I wrote earlier.  not even the EN to JA is safe from the issue.
In short VCV/CVVC VB with any CVVC set as appends/voicecolors VCs will not be inputed or inputed incorrectlly, I don't know if it spreaded even with other Phonemizers, as long there's VCs ver.1.327.0. phonemizers will not auto set the VB even if the notes are in CV format. I mainly use JA Phonemizers I haven't tested with the English ones or the others yet. I dunno they are affected too.

You have to manually change the voice color of the VC separately from the VC note. If you look closely at the image, you'll see that the correct voice colors are not yet selected on the VC notes.

Hope that I fully explained the whole issue, and hope this gets fixed. P.S. the 3rd and 4th one can be somewhat solved by just using the parameters feature and set at or selecting the desidered color but the 4th one seems to ignore even ending VCs. Please fix it. It might hinder or annoy users. hence why

These aren't bugs, but features, so there's nothing to be fixed here.

1.Yes I did set the Japanese Presamp Phonemizer here and I even put a premade presamp.ini in Sorane Lie's root folder but still no VC from the CVVC at the end of the notes like previous version of OU how can I fix this? If I put VCs and CV phonemes will it fix?
2. If it in intended then ok.

Did you perhaps select a voice color before that doesn't have VC transitions, before selecting one that does have them? It's a known bug that VC transitions will disappear in that case. I sadly have yet to find a proper solution for it. The only way right now is to delete the note and re-add it.

 At first I trired on re-assamble them from scratch a well few times changing the suffix alias thinking it was the probleam but no, Ok let me try delete and re-add notes worth a try?

UPDATE: Delete and re-adding notes did nothing :(  welp tried everything. I hope there're possibly a solution.
https://github.com/stakira/OpenUtau/assets/137897357/44fb1f11-bd19-429b-9386-b5fe0ad581ac

Are you sure there are VCs in the oto?

In the main and the others no VCs, only in 贋作. I tried to make some "fake" ones without suffixes in setparam in attempt to make the phonemizer work. Sometimes it works and input the VCs and other times it doesen't.

If the main color does not have VC's, then currently there will be no VC's inserted, no. I'll try to look for a fix for this; it's not really convenient this way.

Bump to keep it active.


feat: add new animation for FancyModal

The type of this PR is: Feature

This PR resolves []
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Add new animation for FancyModal - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Add new animation for FancyModal - dimatretyak)

  Generated by :no_entry_sign: dangerJS against d733ed66dc96fb97613501fc691eadee0a299dd7


crypto/tls: should support TLS_RSA_WITH_RC4_128_MD5 which is the only cipher suite that some websites (e.g. secure.quantserve.com) support

See #10039

RC4 was prohibited in RFC 7465, I think leaving it unimplemented is fine and recommended.

That's legacy, but still in use on the servers.
As an alternative to implement it in the client we could scan the Internet, find all those servers and warn the responsible persons about the RFC prohibition.

@agl for policy. I'm pretty skeptical about dropping all the RC4 suites but I'm also perfectly fine with continuing to not support the combination of RC4+MD5.

Edited title. The original title said that "TLS_RSA_WITH_RC4_128_MD5 is the only cipher suite that some websites (e.g. secure.quantserve.com) support."

secure.quantserve.com does support AES now.
TLS_RSA_WITH_AES_128_CBC_SHA
TLS_RSA_WITH_AES_256_CBC_SHA

Sounds like there's now no reason to do this.


Publish android version to Play Store

Tracking https://github.com/ppy/osu-stream/pull/27#issuecomment-1002511542

It'd be a waste not to push this out to the google play store, so I will aim to do so sometime in 2022.

There might be roadblocks to this happening currently according to https://github.com/ManagedBass/ManagedBass/issues/6, no one has attempted to publish an app using ManagedBass to the play store

I'm not sure why that would even be an issue in the first place.

I'm not sure why that would even be an issue in the first place.

not sure but i've heard people having bad times getting apps approved for menial reasons, and support being very unhelpful

There might be roadblocks to this happening, according to ManagedBass/ManagedBass#6, no one has attempted to publish an app using ManagedBass to the play store

Well, we'll be the first to test that out then. I don't see a problem with that either.

Try this  https://drive.google.com/file/d/1Odsu3W6y_nCc3p-Ifa35OQUy-D7B4k5P/view

Try this https://drive.google.com/file/d/1AFoD78WebW9SHtIkHqn0SmTOF0zayRkJ/view?usp=sharing

Try this https://drive.google.com/file/d/1AFoD78WebW9SHtIkHqn0SmTOF0zayRkJ/view?usp=sharing

I have already compiled it myself, but thanks anyway.

For those who are sharing the apk of the game, please don't and build it by yourself

Has been published today: https://play.google.com/store/apps/details?id=sh.ppy.osustream

It would be good to add it to the readme


Allow user-set devices

I'm running into an issue with my apcupsd add-on where I'm hitting the limits of the current Hass.io system. This is somewhat related to issue #201.
Issue
apcupsd can connect to USB devices directly or to a device or another server over the network. I have to include "devices": ["/dev/usb/hiddev0:/dev/usb/hiddev0:rwm"] for users who directly connect to the UPS, but this causes the add-on not to start for those using the add-on for a network device (i.e. no device connected) because the /dev/usb/hiddev0 doesn't exist.
Using /dev/usb/* or /dev/usb doesn't work because that directory doesn't exist unless an HID device exists and the add-on fails to start.
Using /dev/bus/usb doesn't work either, I think because those devices are raw access and not using the HID driver, but I can't find much information on the subject. I've tried using those device directly, however and they don't work.
Using auto_uart doesn't work because it's not a serial device.
Possible Solutions
I would love for someone to find a simple way to support both configurations, but I don't think it's possible. Here's some ideas I think would work.
HID Device Detection
You could add detection of HID devices like audio and serial devices are detected, then add an option like auto_uart to the add-on API to have those mounted automatically. This would solve the issue for my add-on, but I don't think it would solve the problem overall.
Conditional Devices
You could have the supervisor check if the device exists before passing it to docker. If it doesn't you could just drop the device from the devices passed to docker. I imagine this is possible with pyudev, but it sounds brittle, and some add-on authors may not want that functionality (the add-on might strongly depend on that device being present.)
User Set Devices
Finally, you could add an option to the add-on API whereby an add-on author could specify (a) user-set device(s) (with a default option.) This could work much like the port option where a user can change the listening port(s). Obviously this would require modifying the add-on API and the UI, but I think it's the most portable option.

Would you consider creating two docker images one for USB and one for ethernet?

This can be closed as you kindly created a new image with ethernet support.

I did create a second add-on to get around this issue, but I think it's still an issue.
Maybe there's not that many add-ons that need or would use this functionality, so it's not worth it to spend the time to fix it, but it sure would be nice.