Add better metadata to the download functionality with DataPackage

As of now, the graph data are downloadable as GEXF. In order to make this open data, we need licensing. While we are at it, we add better metadata with OKFN's Data Package standard: http://data.okfn.org/doc/data-package.
Please note that it should be possible to configure Edgesense so that the data are made open and downloadable. I can take the metadata from the GEXF itself, save those on license and source.

Hello @luca , happy<PHONE_NUMBER>1!
That does not solve the problem. Metadata are supposed to be human-readable too, and to help reuse by providing information about what the data actually represent. The two attributes tags in the file itself already do some of that, by providing a title and a type. All is missing is a human-readable description. What do you say if I put in the datapackage.json file the following:
		'schema':{
			'attributes': [{
				'class':'edge',
				'mode': 'static',
				'id': '9',
				'title': 'target',
				'type':'string',
				'description':'Identifies the node that is the end point of the edge.'
				},
                               { ## other attributes to follow...
                               }]
                          }

Also: what do I do with the "effort" edge attribute, which seems to be equal to zero for all edges? And with the "active" node attribute, which seems to be one for all nodes?

happy 2015! :smile:
ok, your proposal looks great, I'd still add a link to the gexf spec (perhaps to http://gexf.net/format ) as that would be the authoritative source of informations on how to handle the format (libraries, programs that can read it, etc.)
since we are using the gexf library that's included within networkx, currently all the properties of the networkx data structure representing the network get exported, even things that have no value for us. I think both the effort and the active attributes are properties that we aren't using.
As I get back to this next week I'll see if there are ways to exclude some attributes, otherwise we could either don't have them in the datapackage or add them and say that they are not used by edgesense

Adding gexf spec would be good. In the examples (http://data.okfn.org/doc/data-package) this is taken care of by the format:
'format':'csv'

Maybe I can add a "Format specifications" field:
'format':'csv',
'format specifications':'http://gexf.net/format'

On second thoughts, I think "active" might encode user accounts that have been suspended or have not been validated yet. Almost all of them will be active, but a few might not be.


Some typescript error

node: v18.12.1
➜  vite-vue2-vuetify-ts-starter git:(master) ✗ yarn
➤ YN0065: Yarn will periodically gather anonymous telemetry: https://yarnpkg.com/advanced/telemetry
➤ YN0065: Run yarn config set --home enableTelemetry 0 to disable

➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0s 208ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ yargs-parser@npm:20.2.9 can't be found in the cache and will be fetched from the remote r
➤ YN0013: │ yargs-parser@npm:21.0.1 can't be found in the cache and will be fetched from the remote r
➤ YN0013: │ yargs@npm:16.2.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yargs@npm:17.5.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yocto-queue@npm:0.1.0 can't be found in the cache and will be fetched from the remote reg
➤ YN0000: └ Completed in 47s 43ms
➤ YN0000: ┌ Link step
➤ YN0007: │ vue-demi@npm:0.13.11 [f2ea7] must be built because it never has been before or the last one failed
➤ YN0007: │ esbuild@npm:0.15.10 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 15s 520ms
➤ YN0000: Done in 1m 3s

Seems like its issue with vetur.

Did you try yarn run clean?
Also, this project recommends Volar, not Vetur.


Avoid undocumented panics and enable clippy::missing-panics-doc

Switches the panic! in LayerEnv::read_from_layer_dir() to unreachable!, since:

it more clearly indicates the intent (unreachable code unless there is a bug)
it means we can globally enable the clippy::missing-panics-doc lint, without having to either:
(a) add an unnecessary # Panic section to the docs (which would only add noise, given the caller needn't be aware of panics for internal bugs)
(b) add an #[allow(...)] annotation to all of read_from_layer_dir, which could mean future new undocumented panics aren't caught by clippy.

Fixes #54.

(Though I still feel that perhaps read_from_layer_dir() / layer_path_specs could do with a types/approach refactor to avoid this unreachable branch in the first place, but not worth it for now)


Use UFO point labels as source for axes

I’m thinking of using labels com.typenetwork.parama-roundup.XXXX where XXXX is the axis name.
We can use these to fill the data on the input sheet, rather than entering it manually.

I’m working on implementing the point labels implementation of parama roundup. So the imagined workflow is this:

Insert measurements as labels in UFOs
Run a script to find glyphs and point indexes and write them to existing Inputs sheet
Run a script to parse measurements from Inputs sheet and write them to Measurements and Widths sheets

The point labels are stored in a custom RoboFont lib entry. They can be written and read by any software, but are not part of the UFO spec or currently implemented in non-Robofont environments AFAIK.
@dberlow Does all of this sound good? Also, how do you want to handle point labels for phantom points?

The origin point should be one index larger than the last point of the last contour of the glyph and the width poont should be two index points larger than the last point of the cliff as per the truetype spec.

On Nov 17, 2019, at 10:00 AM, David Jonathan Ross<EMAIL_ADDRESS>wrote:
dberlow Does all of this sound good? Also, how do you want to handle point labels for phantom points?

Yes, but the question is how do you want to use point labels on points that
don’t exist? 🙃
On Sun, Nov 17, 2019 at 11:35 AM David Berlow<EMAIL_ADDRESS>wrote:

The origin point should be one index larger than the last point of the
last contour of the glyph and the width poont should be two index points
larger than the last point of the cliff as per the truetype spec.

On Nov 17, 2019, at 10:00 AM, David Jonathan Ross <
<EMAIL_ADDRESS>wrote:
dberlow Does all of this sound good? Also, how do you want to handle
point labels for phantom points?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/TypeNetwork/Parama-roundup/issues/11?email_source=notifications&email_token=ABSGFLNFGAZNOUHKDMLGLCTQUFXDZA5CNFSM4JNOSMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIQG3Q#issuecomment-554763118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSGFLM76QVN7Y2K6CHK523QUFXDZANCNFSM4JNOSMVQ
.

The points and goemetry that got you to The phantom point  is the id?

On Nov 17, 2019, at 11:36 AM, David Jonathan Ross<EMAIL_ADDRESS>wrote:
Yes, but the question is how do you want to use point labels on points that
don’t exist? 🙃
On Sun, Nov 17, 2019 at 11:35 AM David Berlow<EMAIL_ADDRESS>wrote:

The origin point should be one index larger than the last point of the
last contour of the glyph and the width poont should be two index points
larger than the last point of the cliff as per the truetype spec.

On Nov 17, 2019, at 10:00 AM, David Jonathan Ross <
<EMAIL_ADDRESS>wrote:
dberlow Does all of this sound good? Also, how do you want to handle
point labels for phantom points?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/TypeNetwork/Parama-roundup/issues/11?email_source=notifications&email_token=ABSGFLNFGAZNOUHKDMLGLCTQUFXDZA5CNFSM4JNOSMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIQG3Q#issuecomment-554763118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSGFLM76QVN7Y2K6CHK523QUFXDZANCNFSM4JNOSMVQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yeah, before we were just typing ID numbers to a spreadsheet so it was easy to just type in slightly-bigger numbers for the phantom points. Now we are looking to label points directly in the UFO, which requires that a point exists in order to be labeled.
Possible options:

Add anchors for phantom points (but then they have to be added to all masters)
Write a script that labels phantom points as a custom lib entry (would not be visible in robofont)
Hard code results with phantom points into the spreadsheet, bypassing labels altogether for those axes

Curious, when RF generates a ttf, does it add the phantom points and then
throw them away when it reads them?
RF, UFO has to store the width (rsb) somewhere?, and technically the
location of the origin (lsb) is known to all points;) which is why
alignments are a single value. . .
so... can't we find values for calculations even without adding them?
On Sun, Nov 17, 2019 at 9:14 PM David Jonathan Ross <
<EMAIL_ADDRESS>wrote:

Yeah, before we were just typing ID numbers to a spreadsheet so it was
easy to just type in slightly-bigger numbers for the phantom points. Now we
are looking to label points directly in the UFO, which requires that a
point exists in order to be labeled.
Possible options:

Add anchors for phantom points (but then they have to be added to
all masters)
Write a script that labels phantom points as a custom lib entry
(would not be visible in robofont)
Hard code results with phantom points into the spreadsheet,
bypassing labels altogether for those axes

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TypeNetwork/Parama-roundup/issues/11?email_source=notifications&email_token=AAO5VDRIXQWGQTKNI55OMQTQUH267A5CNFSM4JNOSMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEI6OMY#issuecomment-554821427,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5VDUBXI237NSCMHZNT23QUH267ANCNFSM4JNOSMVQ
.

Curious, when RF generates a ttf, does it add the phantom points and then
throw them away when it reads them?

AFAIK there are no phantom points actually added into the TTF file...those index are just understood and can be referenced in the hints. The glyph width is stored in the <hmtx> and the y valuesare stored in the <hhea> and <os_2>.

so... can't we find values for calculations even without adding them?

Yes we can calculate, but we can’t label at least in the same sense that we can label points. I’ll try to come up with a workaround.

That is correcter, the scaler creates them from the hmtx table.
Can we label a value in the hmtx table as/if it were a point?
On Mon, Nov 18, 2019 at 4:34 PM David Jonathan Ross <
<EMAIL_ADDRESS>wrote:

Curious, when RF generates a ttf, does it add the phantom points and then
throw them away when it reads them?
AFAIK there are no phantom points actually added into the TTF file...those
index are just understood and can be referenced in the hints. The glyph
width is stored in the  and the y valuesare stored in the
and <os_2>.
so... can't we find values for calculations even without adding them?
Yes we can calculate, but we can’t label at least in the same sense that
we can label points. I’ll try to come up with a workaround.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TypeNetwork/Parama-roundup/issues/11?email_source=notifications&email_token=AAO5VDQQSI45BJRHSFJYF4DQUMC43A5CNFSM4JNOSMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEL7TOI#issuecomment-555219385,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5VDWLYE7UZPZPOEPRJIDQUMC43ANCNFSM4JNOSMVQ
.

Not using the RoboFont interface, unfortunately. And that was kind of the whole benefit of the labels, to make the process more intuitive.

Just forget it then. I tried 10 years ago to get phantom points added to RF so we could hint there, I failed to convince our developer or to get them to convince Frederik to do so. I guess RF is now not up-To-date with the needs of people making TT.
On Nov 18, 2019, at 4:50 PM, David Jonathan Ross<EMAIL_ADDRESS>wrote:
Not using the RoboFont interface, unfortunately. And that was kind of the whole benefit of the labels, to make the process more intuitive.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


JOSS review: Should @ktmeaton be included in the author list?

When reviewing the JOSS review checklist item about authorship, I noticed that @ktmeaton has a nonzero code/doc contribution to snk but isn't in the author list. Should they be included since another person who does not appear to have code/manuscript contributions is listed as a co-author?
Related to https://github.com/openjournals/joss-reviews/issues/7410

Probably! @ktmeaton want to be a coauthor?
The other author was a major contributor of the McCoy project in which Snk was initially conceived and developed.

Congratulations on your paper submission @Wytamma, snk is an awesome tool! I don't think my very small pull request warrants co-author status but thank you for asking 😊 (I actually didn't remember what my code contribution was until I dug through git. Which I think is additional evidence that I haven't made a substantial contribution.)

Thanks @ktmeaton! I'll make sure I update the paper to include an acknowledgement of your contribution. You are a fantastic open-source community member :)


Width settings < 1 for hatch lines appear not to be propery visually applied

See attached image. Note that setting the outline width of the symbol to a value less than 1, does seem to properly work, it is only the hatch lines' widths that fail to be properly set / displayed when a setting < 1 is used (e.g. 0.2). Instead of seeing the width clearly being diminished, the lines stay the same width as line width 1, but are rendered in a lighter grey color, the narrower you make the line going from 1 to e.g. 0.1.

@mboeringa - thanks for pointing this out! Seems to be a bug in the API. We'll look into it.

Yes, please do. Being limited to 1pt line widths minimum is pretty limiting to the cartographic options.

Hi @mboeringa - this issue will be fixed with our November release in a couple weeks. Thank you for your patience!

A fix has been installed with today's update of the CIMSymbolBuilder. Thanks again for reporting this.


Null references not working as intended in Godot 4.3 dev6?

Tested versions
Reproducible in 4.3 dev6
System information
Windows 10, Godot 4.3 dev6, Vulcan dedicated
Issue description
In 4.3 dev6, null references to objects that were freed do not work in the same way they did in 4.2. For example, if a variable contains a reference to an object and the object is freed, the statement:
if object_reference != null
no longer returns false.
Steps to reproduce
Run this project in both 4.2 and 4.3 dev6 and you will see that it behaves differently.
Or just run this code in a blank scene with a Node2D in it:
extends Node2D

var reference : Node2D

func _ready():
	reference = $Node2D
	print(reference)
	reference.queue_free()

func _process(delta):
	if reference != null:
		print(reference)

Minimal reproduction project (MRP)
MRP.zip

This was an intentional change in 4.3, see #73896 and #90513 for details.


[SPARK-28199][SS] Move Trigger implementations to Triggers.scala and avoid exposing these to the end users

What changes were proposed in this pull request?
This patch proposes moving all Trigger implementations to Triggers.scala, to avoid exposing these implementations to the end users and let end users only deal with Trigger.xxx static methods. This fits the intention of deprecation of ProcessingTIme, and we agree to move others without deprecation as this patch will be shipped in major version (Spark 3.0.0).
How was this patch tested?
UTs modified to work with newly introduced class.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #106991 has started for PR 24996 at commit 20059fa.

Test build #106991 has finished for PR 24996 at commit 20059fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ProcessingTimeExecutor(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106991/
Test PASSed.

Why introduce a new abstraction? This is what Trigger.ProcessingTime is meant to be. Just move the implementation to that class, and have the deprecated impl use it, rather than the other way around?

Trigger is just a user side API, and implementation has been placed on Scala side like how ProcessingTime is implemented. Once and Continuous followed the same way.
That said, if we would like to proceed smoother migration with respecting the pattern what Spark has been doing, we need a new class which takes the role instead.
If we think we can remove ProcessingTime, we may not need this smoother but redundant approach. Just change case class and object of ProcessingTime to private[sql], and remove deprecation.

Because ProcessingTime was deprecated in 2.2.0, I actually think it's fine and good to remove it for 3.0. Does this get simpler if you can just remove the old implementation and only use the new one? That's probably what should happen here anyway.

When we decide to discontinue supporting ProcessingTime, looks like we have two choices:

Just change the scope to restrict users' access. Existing queries may fail but it is what we expected.  Least change required, but this way someone may try to hack and continue using it. Not sure we are concerning that hacky approach, though.

Remove the old implementation and only use the new one. Pretty clear to represent we don't support it anymore since no one could try to hack, as I'd rather not think someone applies hack to new class. More change required but simpler than current diff, maybe.

Which option do you feel better?

I personally favor removing the old deprecated implementation. It's probably simpler, and 3.0 is the right time to do it. I don't think this is 'critical' to continue supporting as a deprecated API, compared to many other things we've removed for similar reasons.

Test build #107085 has started for PR 24996 at commit 2acc53a.

Test build #107085 has finished for PR 24996 at commit 2acc53a.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107085/
Test FAILed.

Test build #107087 has started for PR 24996 at commit bc5a3fc.

Test build #107087 has finished for PR 24996 at commit bc5a3fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107087/
Test PASSed.

Looks like everything sorted out. Please take a look again. Thanks!

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12363/
Test PASSed.

Test build #107194 has started for PR 24996 at commit bc5a3fc.

Yeah, I'm also in favor of removing the deprecated implementation.

Test build #107194 has finished for PR 24996 at commit bc5a3fc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107194/
Test FAILed.

Let me explain my thought on the patch.
Actually I assume the reason we deprecated ProcessingTime is that we don't want to expose implementations to user side. That is the only valid reason I can understand why they were deprecated and end users were encouraged to use static methods of Trigger instead. Not 100% sure. If that's the intention, we should hide other trigger implementations as well, so...
I dug the history when it's marked as deprecated, and realize there's no explanation about the reason of deprecation. No description, no review comment on deprecating these methods. So still not sure.
So based on my assumption (and my intention of the patch), it is not just renaming and changing the visibility. It finally ends up looking like that, but in fact it "removes" the deprecated class, and create the other class with applying the intention of deprecation. I will update the title of PR to include introduce new class to replace ProcessTime.
If my assumption is incorrect, we may need to ask to ourselves why we deprecated these methods. Honestly I can't find any other reasons of doing that.

FYI, the PR which marked these methods as deprecated is here: https://github.com/apache/spark/pull/17219

cc. to @tcondie hopefully who might be able to explain the reason.
Also cc. @marmbrus @tdas who reviewed that patch.
We may need to just guess if we couldn't hear any information.

Test build #107210 has started for PR 24996 at commit 12655f0.

Test build #107210 has finished for PR 24996 at commit 12655f0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107210/
Test FAILed.

Thank you for update.
BTW, is the failure due to a flaky test case?
[info] - query without test harness *** FAILED *** (2 seconds, 931 milliseconds)
[info]   scala.Predef.Set.apply[Int](0, 1, 2, 3).map[org.apache.spark.sql.Row, scala.collection.immutable.Set[org.apache.spark.sql.Row]](((x$3: Int) => org.apache.spark.sql.Row.apply(x$3)))(immutable.this.Set.canBuildFrom[org.apache.spark.sql.Row]).subsetOf(scala.Predef.refArrayOps[org.apache.spark.sql.Row](results).toSet[org.apache.spark.sql.Row]) was false (ContinuousSuite.scala:226)

Looks like I could see the failure locally by on other branch (SPARK-27254). It fails intermittently, but even it succeeds it leaves suspicious error log. I'll see what is happening there.

retest this, please

Test build #107219 has started for PR 24996 at commit 12655f0.

Test build #107219 has finished for PR 24996 at commit 12655f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107219/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12417/
Test PASSed.

Test build #107267 has started for PR 24996 at commit 12655f0.

Test build #107267 has finished for PR 24996 at commit 12655f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107267/
Test PASSed.

Test build #107298 has started for PR 24996 at commit 577c61f.

Test build #107298 has finished for PR 24996 at commit 577c61f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107298/
Test FAILed.

Hi, @srowen . Sorry for chiming here. Please review this PR again, @srowen .

Test build #107299 has started for PR 24996 at commit 12655f0.

Let me make clear on this (I also talked with @dongjoon-hyun to clear my intention): I didn't decide to keep this as it is because someone is a PMC member and someone is a committer. I kept as it is because it was approved by some committer/PMC member, and applying new recommendation would break it. So I feel we had some miscommunication, and I guess we addressed it.
I'd kindly ask that reviewers would also be open to discuss among them to have consistent direction of recommendations, as contributors are mostly encouraged to apply recommendations if they got some.
Btw, I just rolled back to the status before we got conflict recommendations, so the shape of PR is pretty close to the thing @srowen approved.

Test build #107299 has finished for PR 24996 at commit 12655f0.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107299/
Test FAILed.

Retest this, please.

Test build #107311 has started for PR 24996 at commit 12655f0.

Test build #107311 has finished for PR 24996 at commit 12655f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107311/
Test PASSed.

Merged build finished. Test PASSed.

Test build #107469 has started for PR 24996 at commit 027e69c.

Just pushed the commit, and adjusted title and content of the PR.

Test build #107469 has finished for PR 24996 at commit 027e69c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107469/
Test PASSed.

Test build #107502 has started for PR 24996 at commit f42e3b5.

Test build #107502 has finished for PR 24996 at commit f42e3b5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107502/
Test FAILed.

retest this, please

Test build #107504 has started for PR 24996 at commit f42e3b5.

Test build #107504 has finished for PR 24996 at commit f42e3b5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107504/
Test FAILed.

retest this, please

Test build #107539 has started for PR 24996 at commit f42e3b5.

Test build #107539 has finished for PR 24996 at commit f42e3b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107539/
Test PASSed.

@srowen @tdas Would you mind doing another round of review? Thanks in advance!

I think this is OK. We need to add releases notes. I don't think there's a streaming migration guide in the docs, so we can use Docs text in the JIRA. Is this accurate @HeartSaVioR ?
"In Spark 3.0, the deprecated class org.apache.spark.sql.streaming.ProcessingTime has been removed. Use org.apache.spark.sql.streaming.Trigger.ProcessingTime instead. Likewise, org.apache.spark.sql.execution.streaming.continuous.ContinuousTrigger has been removed in favor of Trigger.Continuous, and org.apache.spark.sql.execution.streaming.OneTimeTrigger has been hidden in favor of Trigger.Once."

In Spark 3.0, the deprecated class org.apache.spark.sql.streaming.ProcessingTime has been removed. Use org.apache.spark.sql.streaming.Trigger.ProcessingTime instead.

End users are always encouraged to use Trigger.xxx, so this case we need to guide "Use Trigger.ProcessTime"

Oh yes, I mean they should use the method Trigger.ProcessingTime(); that's not new. (The method's name is unfortunate.)

Yes I also confused with new class. you're right.

Merged to master

Thanks all for the detailed review and merging!

shall we have an item in the migration guide for it?

Thanks for reminding. We didn't do as migration guide didn't exist for SS. I'll submit a PR quickly.

There's no harm in a migration guide note, I think, other than potentially overloading it. This is a case I would have thought release notes cover. What would you write in the migration guide? "use the new class"?

I guess same content with release note would be OK for migration guide - that's just a matter of preference of references. Suppose end users upgrade to Spark 3.0.0 and find their application fail to compile, which doc they would find for the first time? Migration guide looks to be the centralized one, so maybe preferred over release note.
I have a commit but yet submitted a PR. Please let me know if it makes sense to add it in migration guide.


Browser back and forward buttons don't work

The html frontend should build a history of visited function calls during a debugging session.

Tested in Chrome and Safari, don't work in either.

It doesn't work deliberately. It also can't work when hosted as a file on the local file system, as the browser methods to do it only work over http. Furthermore, is it really a useful feature? If forward/back do make sense they could be implemented in the HTML itself.

It is a reasonably useful feature imho when navigating the call stack.

I have a better idea for a visualisation for the call stack. Let's use this ticket to improve that visualisation, hopefully after which you will not want forward/back buttons.

Sure, but I am skeptical. No matter how the call stack is rendered, I suspect that navigating it will want for back/forward controls.


Automate tagging the latest GA release of rancher/rancher to also be the latest tag for rancher/rancher

This one might be a bit more complex as we publish a lot of different release lines, but we manually have to update the latest docker image for rancher/rancher to the latest version of Rancher.
This doesn't have to be in drone step but could be based on a GH action or some other tool, but not having to manually run a script.

Related to #273, which adds the semv cmd. Next step after merging #273 is a pull request into rancher/rancher to add a GitHub workflow that promotes the docker latest tag when a release is published or edited.


SW-5350 Refactored module details card out and use also in home screen

#2609  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite


fix: @truffle/hdwallet-provider cannot be a dev dep

What it solves
@truffle/hdwallet-provider cannot be a dev dep

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.296%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3609

Relevant Lines:
9291

💛  - Coveralls


Client not working as expected when data center is set

https://github.com/Netflix/dyno/blob/master/dyno-core/src/main/java/com/netflix/dyno/connectionpool/impl/lb/HostSelectionWithFallback.java#L377
    String dataCenter = cpConfig.getLocalDataCenter();
    if (dataCenter == null) {
        dataCenter = localRack.substring(0, localRack.length() - 1);
    }

    for (HostToken hostToken: uniqueHostTokens) {
    	if (hostToken.getHost().getRack().contains(dataCenter)) {

This code seems a little off to me. If the data center value is provided then the host token will compare this to the rack name?
The end result of this is that if the data center value is set, then the host tokens will never be found and thus causes a connection error.

I am not following your description. The first part says that if no dataCenter is provided and the localRack is for example us-east-1e remove the e and the dataCenter will be us-east-1. If the dataCenter name is provided then you do not need to do that trick.
The second part hostToken.getHost().getRack().contains(dataCenter) says that if the rack name contains as part of the datacenter name then get the host and then the token of that host.
Am I missing something?

I am closing this due to inactivity.


Remove CreateSetupContext from IShellContextFactory

IShellContextFactory shouldn't know about setup, we should describe setup from the calling API. Setup might differ based on individual clients.

Done on recipes branch


Preserve consecutive markdown cells in round trip conversion

Consecutive markdown cells could be exported with two blank lines between them. Conversely, markdown text with paragraphs separated by two blank lines could go to two separate cells.

Solved in version 0.3.0


SerGen creating .bak files as read-only, then crashing because it can't access them

I have to manually clear the read-only flag for each of the .bak files it creates and re-run

Sergen cant create files as readonly. Its probably tfs that makes them readonly. Can't you add this extension to ignore list in tfs?

Oh understood, sergen copies files, as source file is readonly, bak also readonly.

Related, sergen crashes if it can't write to its config file

Try with 2.0.10 please. Set TFSIntegration true in config file.

Fixed in 2.0.11, but needs PR #580 to work correctly if the user does not have TFPath configured


APIv2(ledger_entry) : check error

High Level Overview of Change
Fix issue #4550  on ledger entry

Context of Change
"check" field is verified to be a string. (Check the above Github issue link for more info.) Everything is under API Version 2 as it is a breaking change.

Type of Change

[X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ X] Tests (You added tests for code that already exists, or your new feature included in this PR)

Added own unit test for API Version 2;

@godexsoft @arihantkothari to review new changes

@ximinez Thank you for all the insight! 😄. I pretty much cherry-picked the try-catch and unittest. I agree it's a LOT cleaner this way and prevents future errors to occur.

@godexsoft @arihantkothari - this PR has changed since the time you reviewed it. Could you have a look at the latest?

The diff generated by github for this PR is horrible, very hard to understand what the actual changes are.
My 2c:

It looks like the change does simplify the code a bit - nice
However, relying on exceptions to handle logic is not a very good practice (this is verifying user input)
Although this PR does not introduce this behaviour - it was already there in one way or another.

Since @ximinez is happy with the change I have no objections.

The diff generated by github for this PR is horrible, very hard to understand what the actual changes are.

Click the gear at the top of the diff, and check "Hide whitespace", then click "Apply and reload". Makes a huge difference on diffs like this.

However, relying on exceptions to handle logic is not a very good practice (this is verifying user input)

Sometimes it's a great practice, especially when you're dealing with user input, because you never know what kind of wacky input a user is going to send you, and trying to guess everything a user can do wrong can make the code a lot more complex and hard to read. Compare that to a catch that handles any unexpected behavior...
Besides, like you said, we already have exception handling - that's what returns the "Internal error" in the current version. This change just puts a prettier error on it.

@ximinez Thanks for the nifty trick to make the diff more readable!
In my opinion, user input is not a good place for using exceptions but as i said, they are sometimes a necessary evil, especially if your codebase is already relying on them.
A better solution in my opinion would be a wrapper that hides all the verification and conversions away and returns either values or errors thru std::expected (or ripple::Expected in case of rippled atm.).
I totally understand that one can't simply change the way things are working so I have no objections in this case, just stating my opinion.
My point is - the way to simplify code is thru abstractions that can be tested separately and hide irrelevant details.
Of course i can't disagree with the fact that catching one specific exception is better than "pokemon exception handling" :)

note: updates rippled (with api_version 2) to behave as Clio already does


Add Binary Valentine tool

I'd be happy to add a new tool which I've developed some time ago. It's similar to Microsoft's BinSkim (which is already in the list), but detects more issues. Thank you :)

This looks cool. Thanks for sharing!


Barbarian Assault (Healer) health bar display

Barbarian Assault healer role displays health of other players as 99/99, 87/87, etc.
Please consider changing this to display a health bar (similar to Opponent Information) for an easier time as the Healer role.

Should this be housed in the Opponent Information plugin or the Barbarian Assault plugin?

Teammates wouldn't be considered opponents, and it wouldn't really make sense to work only if the Opponent Info plugin was enabled, so BA plugin

down in the barbarian assault plugin. sorry, I just meant I'd prefer if the health bar looked exactly like it did in the Opponent Information one. it should visually be that health bar in place of the numerical health.

It doesn't need to look exactly the same. (see the Status Bars plugin)

I've been working on this, should have something to submit soon.

I based this on the Status Bars plugin. I'm not sure if it's an issue that it's drawing the overlay on top of the widget.

you have the right idea, this is much easier to read for the healer role.
could it turn from green>yellow>red?


[WIP] Implement Account Recovery with Email (#2887)

Fixes #2887.
This PR is still a work in progress, since I've only implemented the field for the user to enter their email.
However, I have some questions:

How can we make one (any) of the two fields obligatory? Right now it still asks for a username
How can we check that the email is linked to the user? (Maybe a custom validation on the email field?)
Should we have an EmailMixin just like we have for Username? I see the email field defined and used in several forms
Where is the bathroom in this place?
Why do we have an username->user method and an email->userid method but not an email->user method? Should we create one? (using email->userid->user)
Is there an end to this list of questions?
Yes

Any help is appreciated, I'll keep working on trying to figure some of this things out meanwhile. Just wanted to let you know work is being done to implement this feature :)
🐍

@alanbato Instead of having another field for email wouldn't it be better to have just one single field with the place holdeder Username or Email and identify through regex if the entered content is whether username or email and then proceed further?
Please correct me if I'm wrong somewhere.
Thanks

@waseem18 Yes, that is also an option. However, that would mean dropping the use of the UsernameMixin in the form, and I'm not sure if we're making any additional validations there.
But yes, it would make the interface simpler to the user at the cost of more validation and preprocessing steps in the back.
I'm not sure which option is best to be honest, haha.
Thanks for the feedback!

Great questions @alanbato, responses below:

How can we make one (any) of the two fields obligatory? Right now it still asks for a username

I think the right thing to do here is keep this a single field that accepts anything (thus relaxing the validation that the username exits) and modifying the view to look for either:
username_or_email = wtforms.StringField(
         validators=[wtforms.validators.DataRequired()]
)

How can we check that the email is linked to the user? (Maybe a custom validation on the email field?)

We probably don't want to do this validation in the form, as it would reveal whether a given email address is tied to a user account or not. It'd be better for this view to always flash something like "If that username or email address exists, we have sent a reset email" and then in the view, we do:

check if a user exists with a username corresponding to the input, if so send the email;
if not, check if a user exists with an email corresponding to the input, if so send the email;
if not, do nothing

Should we have an EmailMixin just like we have for Username? I see the email field defined and used in several forms

Possibly, but I don't think it's necessary for this PR.

Why do we have an username->user method and an email->userid method but not an email->user method? Should we create one? (using email->userid->user)

It just hasn't been created yet -- this might be a good time to do so.

Hey @alanbato, how's it going? Need any more direction on this PR?

Hi @di, thank you for your help. I've had that much time to implement the rest of it, but I think I now have a pretty good idea of how to do it. :)
I should be pushing an update to this and my other PR by the end of the day.
Thanks again for the feedback! 🐍

Hey @alanbato, how's it going with this PR?
Since #2887 is in our End-User MVP milestone, I may want to help you out a bit here and add a commit or two to get this merged if you don't have bandwidth to work on it sooner than later (which is totally understandable).

Hi @di, thank you for bearing with 😅 My schedule is a little bit constrained on the weekdays and I'm sorry if sometimes I don't reply right back, I feel more comfortable doing the requested changes before replying.
I've implemented the changes requested, and I'm currently figuring out how to use stubs to make the fake token service work correctly in the tests with the new return value 😅

Hey @di, I'm not sure how to modify the test_get() test, since apparently it was counting on getting the form back as a response and I've changed that so it always returns the n_hours parameter to the view. Maybe I need to put the form back in in some way?

Finally, the promised land! The green ✔ !
Thoughts on the PR @di? Are we missing anything? :)

Thanks @alanbato, nice work!

Thanks for all your help and patiance @di! Couldn't have done it without you :) :snake:


Fatal: unable to open config file: Stat: 301 Moved Permanently

Output of restic version
restic 0.14.0 compiled with go1.19 on linux/amd64
How did you run restic exactly?
restic snapshots
What backend/server/service did you use to store the repository?
s3 at Wasabi Storage
Expected behavior
The command should work as expected
Actual behavior
Getting the following error message:
Fatal: unable to open config file: Stat: 301 Moved Permanently
Is there a repository at the following location?
s3:s3.wasabisys.com/<censored>

Steps to reproduce the behavior
Create an account at Wasabi storage.
Try to communicate with your storage via s3 backend.
Do you have any idea what may have caused this?
Related forum entry: https://forum.restic.net/t/restic-0-14-0-with-s3-not-following-301-moved-permanently-anymore/5382
Possible reason:
It might be related to this change in Go 1.19 https://go.dev/doc/go1.19:

The HTTP client will handle a 3xx response without a Location header by returning it to the caller, rather than treating it as an error.

Do you have an idea how to solve the issue?
No, Restic should follow redirects.
Did restic help you today? Did it make you happy in any way?
Yes, I am a happy user since more than 2 years :)

Taking note of the linked advice above,...for us mere mortals (aka total noobs) in Go, who have been happily using Restic/Wasabi/S3 a few years before this issue popped up, is there any trailhead available to easily fix this?  TIA.

Judging from the discussion in the forum, using the wasabi hostname with the proper region, like https://s3.eu-central-1.wasabisys.com/BUCKETNAME should solve the issue.

I'm glad this bug was already posted. I just realized that none of my cloud backups haven't been working since Aug 25. I was able to fix this by adding the region, but I'll have to go around to all the computers.
For reference, here are all the s3 URLs for Wasabi: https://wasabi-support.zendesk.com/hc/en-us/articles/360015106031-What-are-the-service-URLs-for-Wasabi-s-different-regions-
I hope we're able to get 301 redirect following back.
Thanks to all you maintainers. Despite this hiccup, looks like you've been hard at work with this latest release!

still seems an issue. I didn't realize my backup had stopped working due to this. seems like this one could sneak up on people.

Judging from the discussion in the forum, using the wasabi hostname with the proper region, like https://s3.eu-central-1.wasabisys.com/BUCKETNAME should solve the issue.

this appears to be just a temporary workaround and not at all a fix.  there are probably more people who don't realize their backups are failing. Seems like this would be something of priority

this appears to be just a temporary workaround and not at all a fix. there are probably more people who don't realize their backups are failing. Seems like this would be something of priority

In my opinion it is just the other way around. Fixing the redirect issue is just a temporary fix for failing backups, not a permanent solution. Why so? There are several other reasons why a backup may fail (e.g. locked repo, network problems, ...). Thus if the backup automation a) doesn't check that restic finished with exit code 0 and b) that new snapshots are created periodically, then you have no guarantee whatsoever that a backup is created. (And here we're not even close to making sure that it contains all data you need).

This isn't it btw, since the 3xx does return a location header

You're right indeed. the changed behavior seems to be a result of https://github.com/minio/minio-go/pull/1601 . As 301 responses without a location header in Go 1.19 return the actual reply, it might be possible to again support such redirects. Although I'm not sure whether there's interest on the MinIO-side to add support for that again. @harshavardhana

You're right indeed. the changed behavior seems to be a result of minio/minio-go#1601 . As 301 responses without a location header in Go 1.19 return the actual reply, it might be possible to again support such redirects. Although I'm not sure whether there's interest on the MinIO-side to add support for that again. @harshavardhana

Re-direction doesn't work properly for AWS signature requests @MichaelEischer it requires few hacks and they only work under specific conditions.
To add to this trouble AWS S3 doesn't return Location HTTP header upon HTTP 301 - so Go fails, this needs to be manually handled.
Because for the most part, this happens due to the wrong configuration on the client side because if you use the right region endpoint for the bucket there would be no-redirects etc.
minio-go right now is following aws-sdk-go behavior here for HTTP redirects.

Fixing the redirect issue is just a temporary fix for failing backups, not a permanent solution.

I don't think we're here to discuss how robust people's setups are. We're talking about a very specific (and perhaps common) failure.
I'll just throw my two cents in. I think this is in-scope to fix because it's a reasonable expectation that if the server s3.wasabisys.com says a particular repo should actually be found at s3.us-central-1.wasabisys.com, that the software would have a little logic to track down the bucket.

Because for the most part, this happens due to the wrong configuration on the client side because if you use the right region endpoint for the bucket there would be no-redirects etc.

When I created my bucket in Wasabi, I was given the address s3.wasabisys.com and it worked for a year. I had a hard time tracking down the redirection address.
If a generous soul is willing and able, I would greatly appreciate this flexibility :-)

I'd like to add another perspective, the latest and stable docs over at
https://restic.readthedocs.io/ suggests using the upstream provided URL for
the s3 (aws and wasabi) buckets. For the AWS docs it mentions that a region
can be specific if needed.
This leads users down the path of running into this issue.
On Mon, 2 Jan 2023 at 20:19, jroedel @.***> wrote:

Fixing the redirect issue is just a temporary fix for failing backups, not
a permanent solution.
I don't think we're here to discuss how robust people's setups are. We're
talking about a very specific (and perhaps common) failure.
I'll just throw my two cents in. I think this is in-scope to fix because
it's a reasonable expectation that if the server s3.wasabisys.com says a
particular repo should actually be found at s3.us-central-1.wasabisys.com,
that the software would have a little logic to track down the bucket.
Because for the most part, this happens due to the wrong configuration on
the client side because if you use the right region endpoint for the bucket
there would be no-redirects etc.
When I created my bucket in Wasabi, I was given the address
s3.wasabisys.com and it worked for a year. I had a hard time tracking
down the redirection address.
If a generous soul is willing and able, I would greatly appreciate this
flexibility :-)
—
Reply to this email directly, view it on GitHub
https://github.com/restic/restic/issues/3909#issuecomment-1369185694,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFYZJS7RLHINOF3FT52ITWQMZ6DANCNFSM6AAAAAAQAXWJEI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Fixing the redirect issue is just a temporary fix for failing backups, not a permanent solution.

I don't think we're here to discuss how robust people's setups are. We're talking about a very specific (and perhaps common) failure. I'll just throw my two cents in. I think this is in-scope to fix because it's a reasonable expectation that if the server s3.wasabisys.com says a particular repo should actually be found at s3.us-central-1.wasabisys.com, that the software would have a little logic to track down the bucket.

we are saying the same thing. I'm saying changing a URL in the file is a temporary fix, and it should be resolved programmatically in restic. While I appreciate it's a 301 and not a 302, I still believe it can change.


Using Force for Fetch Refspecs

The Namespaces type provides refspecs for the fetching. At the moment, these refspecs do not use + for forcing non-fast-forwards.
On one hand, we would like to use fast-forwards when a peer has force-pushed changes to their reference set, otherwise, these would currently be rejected.
On the other hand, for example, if we wanted Eve's changes and we fetched them from Alice and Bob, where Alice has the most up-to-date state and Bob is behind, then we will end up in a behind state if we fetch from Bob after Alice. Unless... Would we reject the fetch from Bob because the signed refs are not a fast-forward?
So rubberducking as I write this... The invariant is that signed refs always need to be a fast-forward, which we should fetch and verify first, and then all references in that set are force fetched because we know it's safe. In the case above, we reject the fetch from Bob because we know the signed refs are ahead -- we just fetched the latest from Alice.

:bulb: !

In order for this to work correctly we need to split the fetching from a node into two stages:

Fetch the rad references -- these are needed to determine the validity of the identities and the signed refs.
For each remote we are fetching from, fetch the valid signed refs using the forced (+) refspec.

Something to be aware of is that step 1. can fail verification, for example, if a malicious actor is trying to fake signed refs. We don't want to overwrite the existing references so we need to have some kind of staging process. In the prior art, i.e. link-replication, these references were fetched into an in-memory refdb for verification purposes. However, this requires being able to tap into a custom protocol. For our case, it should be enough to fetch into a staging area, e.g. refs/namespaces/staging. If any of those references fail to verify then they can be pruned.
For each staged set of signed refs, we can ensure that they are a fast-forward of our currently seen signed refs, if they are not they can be discarded as they are out of date. If they are a fast-forward we can move forward the real signed refs reference and for each reference in its payload create a forced refspec. We send those refspecs off for fetching, completing phase 2, and the whole fetch process.

Related: #14


Wrong password for a cloud credentials doesn't fail the deployment

This was observed on the Atos connector

Just a bit of info.  CLI does exit with non-zero exit code.
Mar 16, 2015 2:45:36 PM com.sixsq.slipstream.util.ProcessUtils execGetOutputAsArray
SEVERE: Error executing: sh -c /usr/bin/stratuslab-run-instances --username 'sixsquser' --network-type 'Public' --markeptlace-endpoint 'https://marketplace.stratuslab.eu/marketplace/' --flavour 'stratuslab' --image-id 'N-Bu1h1jt3K8ODnCTw4JiyPaH5k' --instance-type 'm1.small' --password 'XXX' --endpoint '<IP_ADDRESS>'  . With exit code = 2 and stdout:
 :::::::::::::::::::::::::
 :: Starting machine(s) ::
 :::::::::::::::::::::::::
 :: Starting 1 machine
 and stderr: <ProtocolError for sixsquser:XXX@<IP_ADDRESS>:2634/pswd/xmlrpc: 401 Unauthorized>


[docs] Relocate Demo as own subnav tab

Demos may deserve their own tab in the Elements' Subnav.

I removed the playground knobs part of the issue title, since that's out of scope for this issue


Error while calling lua chunk: vim/_init_packages.lua:0: module 'vim.uri' not found

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Not a user config issue

[X] Confirm

Neovim version
$ nvim --version NVIM v0.10.0-dev Build type: RelWithDebInfo LuaJIT 2.1.0-beta3 Run "nvim -V1 -v" for more info
Operating system/version
$ uname -a Linux rock-5b 5.10.110-36-rockchip-gba392dc725fa #rockchip SMP Tue Jan 17 07:19:43 UTC 2023 aarch64 GNU/Linux
Terminal name/version
Terminal
$TERM environment variable
xterm-256color
Branch info
main (Default/Latest)
Fetch Preferences
HTTPS (use_ssh = false)
How to reproduce the issue
使用README安装命令第一次启动
Expected behavior
正常启动无报错。
Actual behavior

Additional information
No response

We don't support self-built nvim binary, please download the binary from github release or install it by the system package manager.


[formatting] Format chosen files with Verible

Expand the list of files used by Verible formatter to include chosen
SystemVerilog files that:

new formatting was reviewed and found to be compliant to the lowRISC
style guide
needed up to 100 lines to be reformatted to make review easier

Would you please include no more than a 1000 lines at a time - this is too long to review.

@rkapuscik Please re-request my review once all open issues are addressed. Thanks for working on that!

Closing this PR as we won't merge it as-is. But it served as useful discussion ground for improvements to Verible, and will stay around as such even in closed form.


[CARBONDATA-2540][CARBONDATA-2560][CARBONDATA-2568][MV] Add validations for unsupported MV queries

This PR depends on https://github.com/apache/carbondata/pull/2453
Problem: Validations are missing on the unsupported MV queries while creating MV datamap.
Solution: Added validation for the unsupported MV queries while creating datamap.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6987/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5765/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5748/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7192/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5967/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5854/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5858/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6020/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7289/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6056/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5917/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7430/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6189/

LGTM


Add support to save plots to file for pymoo.util.running_metric.RunningMetric

Trying to do:
running = RunningMetric(
    delta_gen=5,
    n_plots = 3,
    only_if_n_plots=True,
    key_press=False,
    do_show=True,
    do_close=True,
)

i = 0
for algorithm in res.history:
    running.notify(algorithm)
    plt.savefig("running_metric_{num}.png".format(num=i));
    i+=1

does not work. Just saves a bunch of empty images. The plt.show() is happening inside the notify() function in visualization/video/callback_video.py.

First of all, you want to set do_show  and do_close to False if you want to plot or save by yourself after the notify call.
Another reason why some of your plots are empty is not the missing capability for saving the figure but the nature of the running metric.
delta_gen defines in what generations the metric should be plotted. If you set this to 5, then it will not be plotted in each generation. You can set delta_gen=1 which would then plot every generation (starting when the n_plot+1 generation has been reached).
Also, to force plotting you can call the running metric by
running.notify(algorithm, force_plot=True)

which will create a plot every time.
Let me know if this works for you.


A3 toggle should persist between refreshes

E.g., if I click "Show A3 Content", when I reload the page we shouldn't re-hide A3 content. Should be a simple localStorage flag.

Done in https://github.com/vyhd/sanbai-sprinkles/commit/a013e87229a3d35539372d0b09b380e167cedb04, will do a QA pass + close this out as part of the release cycle for 3.0.0


Ignore broken schemas

If a schemas has broken references in it (a reference to an item that doesn't exists) the importer crashes because it expects that object.
@JonathanMontane I can pass you an example JSON that crashes tomorrow…

solved in PR#29


Escaped characters in environment variables are not escaped in requests

Expected Behavior
With the following environment:
{
  "backslash": "\\"
}

And the following request body:
{
  "from variable": "{{ _.backslash }}",
  "from raw text": "\\"
}

The request body that is sent should be:
{
  "from variable": "\\",
  "from raw text": "\\"
}

Actual Behavior
The request body that is actually sent is:
{
  "from variable": "\",
  "from raw text": "\\"
}

Reproduction Steps

Go to https://webhook.site and copy your unique URL to clipboard
Use this URL in a new request in Insomnia
Define this environment:{
  "backslash": "\\"
}

Define this JSON request body:{
  "from variable": "{{ _.backslash }}",
  "from raw text": "\\"
}

Send the request
Go back to https://webhook.site and observe the raw content of the request you just sent

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2021.7.2
What operating system are you using?
Other Linux
Operating System Version
Arch Linux
Installation method
insomnia-bin package from AUR
Last Known Working Insomnia version
No response

Hi @filfreire, you're welcome!
I took some time to dig into the code to see if I was able to fix the bug, but I realized this is not as simple as I thought.
Environments are defined in JSON format, so when we set { "backslash": "\\" } the intrinsic value of the backslash variable is really just \ (because environment is written in JSON so we need to escape the \ we want to "store as a variable").
The thing is that variables are replaced by their value as is (that's why we have to wrap them inside quotes), so it's normal that "test": "{{ _.backslash }}" is replaced by "test": "\".
If we want to have it replaced by "test": "\\" we must set environment to { "backslash": "\\\\" } (intrinsic value \\, the escaped backslash we want to write in our request body).
The problem is that we can't have a variable with a unescaped intrinsic value and use it in a request body where it should be escaped.
In this particular case we want to write JSON so \ should be escaped, but it would not be a problem if we were writing in another format like YAML for example (test: \ is a valid YAML).
On the other hand, having the environment { "colon": ":" } would be a problem in YAML (test: : is not valid) and not in JSON ({"test": ":"} is valid).
Here are some thoughts on how to solve the problem:
1. Do nothing and let the users escape special chars
Pros:

Easy to implement (lol)

Cons:

Users have to know that the intrinsic value of the variable must include escaped chars, and have to know for which format they must escape it
A variable with special chars can't be used in request body of different formats (special chars are not the same for JSON and YAML, so escaping for JSON can produce a different string in YAML and vice versa)

2. Create template tags
Having several template tags for each format could allow users to escape variables for the format they want.
For example there could be a json template tag which could be used like that : {% json(_.variable) %} and that would behave like JSON.stringify.
It can be useful in request body to escape strings (or insert non-scalar values 💪), but also in the address bar to url-encode variables (replace special chars by their percent-encoded variant).
Pros:

Not so hard to implement (I guess)
Easy to use
Users can choose which variable they want to escape
This could also allow the use of non-scalar variables, instead of converting objects to [object Object] and arrays to comma-separated lists

Cons:

Users still need to know that values are not escaped and they have to use template tags
It could be boring to use template tags when there are a lot of variables (maybe a marginal case)

3. Automatically escape every variable depending on the context (the format in which they are used)
Choosing "JSON" as request body format would have the same effect as if all variables used in the request body were wrapped by the json template tag mentioned in point 2.
Also, all variables used in the address bar would be as if they were wrapped by the url template tag.
Pros:

Users have nothing to do and nothing to think about, it just works
Like in point 2, allow the use of non-scalar variables (without nothing more to do or think about than just using the variable)

Cons:

Maybe harder to implement
(⚠ Big one) It would be a breaking change because users would not have to wrap variables into quotes as they do now
All variables are escaped and there is no opt-out, there may be other situations I haven't thought of where it could be a problem

I may have gone too far in my thinking 😅 but I hope it will give you some ideas 😉

For folks coming here trying to escape encoded JSON from environment variables and having issues escaping with quotations, I found that the search replace plugin (https://insomnia.rest/plugins/insomnia-plugin-stringreplace) perfect for replacing single quotes with double quotes.
Given:
{
  "manifestJsonObj": "{'id': '{{ _.manifestId }}', 'files': [{'id': '{{ _.fileId }}', 'name': '{{ _.filename }}', 'filename': '{{ _.fullFilename }}' } ] }"
}

In a request:
{
  "id": "test123-file-dd2a498b11154663a20faf9cf28e6d1bz",
  "manifest": "{% replace 'regexp', '/\'/g', '\\"', '', _.manifestJsonObj %}"
}


⚠ Bofrost.at has degraded performance

In c2f4784, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1661 ms

Resolved: Bofrost.at performance has improved in 014cfba.


Add solution for 74 - Search a 2D Matrix in C

File(s) Modified: c/74-Search-a-2D-Matrix.c
Language(s) Used: C
Submission URL: https://leetcode.com/submissions/detail/790480917/

Thanks, @ritesh-dt!


Update Readme for iOS manual install

Add manual installation instructions for iOS as well as make sure that our react-native link command specifies the project we want to link.

thanks, these comments really helped. i have a couple more suggestions:

make it clear that you can use npm install instead of yarn if you are already using npm
point out that in xcode the .a file won't be found (and is in the Products subdir) so it will be red, but you can still drag it in to be a linked framework
make it clear that if you do the manual steps (we had to) you don't need to do react-native link (i think..)
point out that if you do the manual steps, you need to remove the changes made to your Podfile to avoid conflicts

I think these are the steps we followed, along with a lot of trial and error. Just another (wasted) day in the life of react-native!

@tristandl changes are fine, except for npm (I think most companies are using yarn instead due to performance). Please @markrickert , can you update the Readme? Thanks!

@alvaromb I think this pull request should be merged as is. At the moment the master branch README.md does not contain any installation instructions for iOS. The only way I figured how to get react-native-version-number working on iOS was by finding this pull request.

Some info is better than no info on the readme. yarn vs npm shouldn't be a blocker imho.
This is all made obsolete by react native 0.60 anyways 🤷♂

I think this could be helpful

Could a note about running cd ios && pod install be added to the Readme as well? I linked and ran without installing pods and got all null values for Version Number, until I found clues in the Issues.


[CT-424] Dbt list json output should include the final target name of the model

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
I execute dbt list -m my_model --output-json > some.json, file some.json should ideally contain the fully qualified target name of the model.  In my dbt project I make heavy use of of the generate..x..name() set of schemas to alter the final target name based on the environment.
I depend on the output from dbt list in my CICD processes and recently discovered that it doesn't capture this information in the output - which I feel it should.
Describe alternatives you've considered
I'm working around it right now, by also having to read in the manifiest and parsing that.
Who will this benefit?
Everyone - having the final target (a critical value) as processed by macros would be valuable to a wide audience.
Are you interested in contributing this feature?
Not at this time
Anything else?
No response

Thanks for opening @whisperstream! I remember this being open as an issue some time ago: https://github.com/dbt-labs/dbt-core/issues/2643
Since https://github.com/dbt-labs/dbt-core/pull/2837, we do add the fully qualified relation_name for all "relational" nodes (ones that point to / create database objects)—but only at compile time, after loading the adapter:
https://github.com/dbt-labs/dbt-core/blob/81118d904a876276d8a890eb207e1e2a813c344a/core/dbt/compilation.py#L197-L203
https://github.com/dbt-labs/dbt-core/blob/81118d904a876276d8a890eb207e1e2a813c344a/core/dbt/compilation.py#L380
Why? Because we need to know the adapter's specific rules for creating relation names. Some adapters are schema.table only, some use `` instead of "" as their quote characters, etc.
In order to include this in the output of dbt ls, the information has to be available at the end of parsing, without requiring the additional compilation step (i.e. dbt compile). Is that possible? Someone from the Core - Language team would have to weigh in


Error when trying to train on msmarco-passage.

Hi i'am currentlly trying to train a retrievel using tevatron.driver.train but i'm getting an error and i don't jnown how to solve it. hier is the traceback of the error
Traceback (most recent call last):
  File "/home/mboutchouang/miniconda3/envs/tevatron/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/mboutchouang/miniconda3/envs/tevatron/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/dstore/home/mboutchouang/tevatron/tevatron/src/tevatron/driver/train.py", line 104, in <module>
    main()
  File "/dstore/home/mboutchouang/tevatron/tevatron/src/tevatron/driver/train.py", line 85, in main
    trainer = trainer_cls(
  File "/dstore/home/mboutchouang/tevatron/tevatron/src/tevatron/trainer.py", line 105, in __init__
    scaler=self.scaler
AttributeError: 'GCTrainer' object has no attribute 'scaler'

please do someone have an idea??

Hi @Zaker237, seems it is a bug of training using GCTrainer with fp32.
A quick fix at your end is adding the --fp16 option in the command line.
I create PR to fix it for fp32.

Hi,
It seems that the latest version of HF's trainer will only create a scaler when enabling sharded_ddp https://github.com/huggingface/transformers/blob/fa6107c97edf7cf725305a34735a57875b67d85e/src/transformers/trainer.py#L637
Does this influence the tevatron code? Thanks

I think now HF's trainer uses the accelerate's scaler https://github.com/huggingface/transformers/issues/25021#issuecomment-1647349987


[DSA]:Strings: Valid Anagram :C++ #4711

Description 📜
Given two strings s and t, return true if t is an anagram of s, and false otherwise. in C++ Fixes #4711

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] DS#A

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Hey @ishrutik, this issue already existed so I have to close this PR for now. You may save this documentation and suggest improvements when this topic's PR is merged. Also, please avoid creating repetitive issues, check DSA Label or Milestone beforehand.


Refactor unused var in presto-mongodb

#4188
This PR is a preparation before enable UnusedVariable error prone check.

SAMPLE_WEIGHT_COLUMN_NAME in MongoColumnHandle is also unused. Did you ignore it intentionally?

SAMPLE_WEIGHT_COLUMN_NAME in MongoColumnHandle is also unused. Did you ignore it intentionally?

No, this one should be removed too. I will fix it up later.

SAMPLE_WEIGHT_COLUMN_NAME in MongoColumnHandle is also unused. Did you ignore it intentionally?

From UnusedVariable's description :

This check highlights private fields and parameters which are unused and can be safely removed without considering the impact on other source files.

It seems that public variables won't be checked so I didn't find out and remove SAMPLE_WEIGHT_COLUMN_NAME in this PR.
But we should clean up unused variables as much as possible.

Merged, thanks!


Name properties should also be identity by default

Closing in favor of #4282 since it has a description


Open a new window using Ctrl+Shift

Note: This pull request includes #17; the last commit is the new one. I've filed it separately because I mentioned this feature in #13 but didn't achieve consensus there.

Great work and thanks for contributing :)  - once you make the changes I'll merge your changes and update the extension in the store.

Awesome looks good. The one change I'll make is to get use the tab.incognito flag in case it's being used in an incognito window. I'll get to releasing it by end of week. The opera release process is slightly longer than chrome because they actually have someone manually look at the changes which I think is amazing for keeping extensions and the store secure. Thanks again for the PR!

Thank you too! Not least for porting and maintaining this extension. It's the one I use the most!

@lastorset as an FYI that I haven't forgotten about this - I had tested the changes and some there are some issues so I'll fix those before releasing but you can load the extension through the dev mode in the mean time.
Issues are:

when cursor is on search field and using arrow keys to highlight the selection - you must press shift+enter very fast in order for trigger to take place. Works when cursor isn't in focus.
Some links that are relative aren't parsed correctly.


[WIP] Changelog Euwe GA

Sprint 49 week one back ported to Euwe
[skip ci]

@miq-bot add_label documentation

@miq-bot add_label wip

@chriskacerguis @dclarizio @dmetzger57 @gmcculloug @blomquisg @gtanzillo @roliveri @Fryguy  @chessbyte

@Fryguy @chessbyte should "UI" sections be renamed "Classic UI".  Do you think it's needed?

:+1: Providers section looks good

Looks good to me.

@miq-bot remove_label wip


/image Command fails.

The image generation command fails (/image). But the "Create an image" prompt works.

Use "/imagine" instead of "/image". Its not a bug.

If you want "/image" alias may be added in future versions.


Wireframes: ACTI-004, ACTI-015

Part of BlueBrain/nexus#1247
ACTI-004

As a user,
I can get the instructions to link my work artifact programmatically in the activity
In order to make it available and traceable in the project.

ACTI-015

As a user,
I can get the work artifact programmatically from that activity
In order to make use of it outside the software.

We have added a link to Jupyter Notebook:

We'll add Nexus Forge code snippets to read all artifacts in this activity as well as a code snippet to push artifacts into this activity programmatically from the notebook

I would suggest having a separate work artifacts list with cards, not on canvas to start with.
Each work artifacts or a collection of selected work artifacts can be "exported" to Python code or to a new notebook.
Jupyter Notebook is one of many (albeit an important one) work artifact that can use other work artifacts.


Comparison method violates its general contract!

Error opening a two page pdf. Worked fine on five other very similar documents.
[https://www.cumsar.com.au/docs/multipliers_ready_reckoner_2016.pdf](Link to file)
Error was
Tabula API version: <IP_ADDRESS>21116
Filename: multipliers_ready_reckoner_2016.pdf
Internal Server Error (500)
    Request Method:
    POST

    Request URL:
    http://<IP_ADDRESS>:8080/pdf/e03b7b3fc2e3a5de8d3e724a6565af2ba575a321/data

Comparison method violates its general contract!

Works fine with most recent version of tabula.


Allow overriding event name when syncing vue-gtm with vue-router

Move on extra information to the bottom of dataLayer.push call in order to allow overriding event name and other properties.

I think that was by design, please explain and give a reason why you want to do this.

Sorry, it was my fault.

Sorry, it was my fault.


Add threadid to logfile.

Without this information, it's fairly difficult to debug multithreaded
daemons (especially if multiple threads invoke the same function).

For what it's worth, it would be more useful if we could log the Linux thread ID - but looking around on the web, it involves doing raw syscalls.  Not quite that desperate yet.


Write active checkpoint manifest atomically.

lgtm

rktbot run checkpointer tests

@diegs lets bump the checkpointer image in bootkube then cut a release after this merges -- pretty needed fix

sgtm


Welcome! And Read Me

Greetings,
Thank you for visiting BU's Study Group. This group is designed to bring everyone in the BU community interested in improving their code, enhancing their data analysis abilities, building new skills, and working in a collaborative environment together. We are a community-led group that's open to new ideas and here to work with you.
We are using Github's issue tracker to suggest events and to post discussion items. It is a little bit of a workaround but the functionality is great (and the cost is free : ).
Please add a comment to say hello. If you're interested in learning a new technology or sharing something you know, create a new issue.
Best,
Tom

Would something like this be better off as the README file in the main repo? Perhaps we could work together on updating the current README, which seems to just be a generic one from Mozilla's StudyGroup project.

@ashiklom Excellent idea! Let's work on that. (And you're right it is a the standard Mozilla template).

I'm going to close this issue. We have a new README.md file to introduce our repo and can continue to edit and refine it as need.


[outputs lockfile] make backwards compatible

Summary
This PR enables a devbox.lock updated by a user with the latest Devbox that has written Outputs to continue working for their teammate using a legacy Devbox.
Note two differences:

The legacyDevbox teammate will not benefit from output store-paths
If the legacyDevbox teammate modifies the lockfile in any way, then the Outputs will be lost. Presumably, this is not a huge problem since I anticipate most users rely on source control to track their devbox.lock in their devbox projects (except for maybe the Devbox global, but then those are less likely to be shared).

How was it tested?

Added devbox add curl and devbox add prometheus --outputs cli,out using compiled devbox. This updated devbox.lock file.
rm -rf .devbox
/usr/local/bin/devbox shell using released Devbox. Observe that (1) it works (2) modifies devbox.lock file and drops Outputs.

Current dependencies on/for this PR:

#1866  👈
main

This stack of pull requests is managed by Graphite.

@gcurtis @mikeland73 ping


Allow aliases for the template creation class names.

We have a set of migration template creation classes that are namespaced. Allowing them to be accessed via an alias which is part of our Phinx setup simplifies things for our developers.
One thing I wasn't sure about is making Config::getAlias() part of ConfigInterface.
If I did, any pre-existing class implementing that interface will now require an empty function, assuming they didn't want to use any aliases.
So, hopefully, just where it is is OK.

Is there anything to be done about AppVeyor failing?

Any chance this could be merged please?

Thank you.

:+1:


Nesting Definitions to $ref

How to map swagger YAML to java Map that includes mapping of the $ref value from Definitions?

@lemuel-nabong-cwt-bps sorry I did not get the question, do you have an example? thanks!

yaml mapper generate
definitions:
  Product:
    properties:
      product_id:
        type: string
        description: Unique identifier representing a specific product for a given latitude & longitude. For example, uberX in San Francisco will have a different product_id than uberX in Los Angeles.
  Bag:
    type: array
    items:
      $ref: Product

I want to have the real $ref object nested
definitions:
  Product:
    properties:
      product_id:
        type: string
        description: Unique identifier representing a specific product for a given latitude & longitude. For example, uberX in San Francisco will have a different product_id than uberX in Los Angeles.
  Bag:
    type: array
    items:
      Product:
         properties:
           product_id:
             type: string
             description: Unique identifier representing a specific product for a given latitude & longitude. For example, uberX in San Francisco will have a different product_id than uberX in Los Angeles.

I wonder if there are method for this or suggestion to best map it, Thanks!

what if you put instead of :
Bag:
    type: array
    items:
      $ref: Product

Bag:
type: array
items:
$ref: '#/Definitions/Product'```

yes, I really intend that one, sorry.

oh ok, let me see what can be done. 👍

which part can I contribute?

Seems not working with request body in JSON.
Input example:
"/authentication/token": {       "post": {         "summary": "Authenticate User", 		"requestBody": { 			"$ref": "#/components/requestBodies/reqbody_authentication" 		  },         "responses": {           "200": {...
Even with resolve fully the reference is not updated.

Hi @adrienucp,
Can you please upload the input spec file to reproduce the issue?
Thanks,
Mohammed

Hi team,
I have raised a PR to solve this issue.
Thanks,
Mohammed

Thanks @ymohdriz ,
your fix is working for my case.

Hi, if this issue keeps happening please let us know.

Hi @gracekarina , I'm using the Swagger Parser v3 at the moment and try to resolve the refs in just the components only and if I have a OpenAPI def with no path definitions the refs fail to resolve, so if I use:
String yaml = "openapi: 3.0.0\n" +                 "info:\n" +                 "  version: 0.0.0\n" +                 "  title: Simple API\n" +                 "components:\n" +                 "  schemas:\n" +                 "    Product:\n" +                 "      properties:\n" +                 "        product_id:\n" +                 "          type: string\n" +                 "          description: >-\n" +                 "            Unique identifier representing a specific product for a given\n" +                 "            latitude & longitude. For example, uberX in San Francisco will have\n" +                 "            a different product_id than uberX in Los Angeles.\n" +                 "    Bag:\n" +                 "      type: array\n" +                 "      items:\n" +                 "        $ref: '#/components/schemas/Product'";
The ref to "Product" in "Bag" never resolves, however if the path's definition like in the earlier example is present it does resolve, is this correct behaviour or a bug?

hi @Leo11221 , yes it is the correct behaviour, if you need the ref in components to be resolved, please use ParseOptions resolveFully(true);

@gracekarina thanks for the response, but I have resolveFully set to true already and it doesn't resolve when I just have components and no paths, so I have:
val yaml = "openapi: 3.0.0\n" +
  "info:\n" +
  "  version: 0.0.0\n" +
  "  title: Simple API\n" +
  "components:\n" +
  "  schemas:\n" +
  "    Product:\n" +
  "      properties:\n" +
  "        product_id:\n" +
  "          type: string\n" +
  "          description: >-\n" +
  "            Unique identifier representing a specific product for a given\n" +
  "            latitude & longitude. For example, uberX in San Francisco will have\n" +
  "            a different product_id than uberX in Los Angeles.\n" +
  "    Bag:\n" +
  "      type: array\n" +
  "      items:\n" +
  "        $ref: '#/components/schemas/Product'";

val parser = new OpenAPIV3Parser
val options = new ParseOptions
options.setResolveFully(true)
val openAPI = parser.readContents(yaml, null, options).getOpenAPI
println(openAPI.toString)`

However the ref to product is never resolved, the output of the Bag Schema is:
class ArraySchema {
    class Schema {
    type: array
    format: null
    $ref: null
    description: null
    title: null
    multipleOf: null
    maximum: null
    exclusiveMaximum: null
    minimum: null
    exclusiveMinimum: null
    maxLength: null
    minLength: null
    pattern: null
    maxItems: null
    minItems: null
    uniqueItems: null
    maxProperties: null
    minProperties: null
    required: null
    not: null
    properties: null
    additionalProperties: null
    nullable: null
    readOnly: null
    writeOnly: null
    example: null
    externalDocs: null
    deprecated: null
    discriminator: null
    xml: null
}
items: class Schema {
    type: null
    format: null
    $ref: #/components/schemas/Product
    description: null
    title: null
    multipleOf: null
    maximum: null
    exclusiveMaximum: null
    minimum: null
    exclusiveMinimum: null
    maxLength: null
    minLength: null
    pattern: null
    maxItems: null
    minItems: null
    uniqueItems: null
    maxProperties: null
    minProperties: null
    required: null
    not: null
    properties: null
    additionalProperties: null
    nullable: null
    readOnly: null
    writeOnly: null
    example: null
    externalDocs: null
    deprecated: null
    discriminator: null
    xml: null
}

}
When I do it with the paths like your example it does resolve the references, so when I have:
    val yaml = "openapi: 3.0.0\n" +
"info:\n" +
"  version: 0.0.0\n" +
"  title: Simple API\n" +
"paths:\n" +
"  /:\n" +
"    get:\n" +
"      responses:\n" +
"        '200':\n" +
"          description: OK\n" +
"          content:\n" +
"            '*/*':\n" +
"              schema:\n" +
"                $ref: '#/components/schemas/Bag'\n" +
"components:\n" +
"  schemas:\n" +
"    Product:\n" +
"      properties:\n" +
"        product_id:\n" +
"          type: string\n" +
"          description: >-\n" +
"            Unique identifier representing a specific product for a given\n" +
"            latitude & longitude. For example, uberX in San Francisco will have\n" +
"            a different product_id than uberX in Los Angeles.\n" +
"    Bag:\n" +
"      type: array\n" +
"      items:\n" +
"        $ref: '#/components/schemas/Product'";

The output is:
class ArraySchema {
    class Schema {
    type: array
    format: null
    $ref: null
    description: null
    title: null
    multipleOf: null
    maximum: null
    exclusiveMaximum: null
    minimum: null
    exclusiveMinimum: null
    maxLength: null
    minLength: null
    pattern: null
    maxItems: null
    minItems: null
    uniqueItems: null
    maxProperties: null
    minProperties: null
    required: null
    not: null
    properties: null
    additionalProperties: null
    nullable: null
    readOnly: null
    writeOnly: null
    example: null
    externalDocs: null
    deprecated: null
    discriminator: null
    xml: null
}
items: class Schema {
    type: null
    format: null
    $ref: null
    description: null
    title: null
    multipleOf: null
    maximum: null
    exclusiveMaximum: null
    minimum: null
    exclusiveMinimum: null
    maxLength: null
    minLength: null
    pattern: null
    maxItems: null
    minItems: null
    uniqueItems: null
    maxProperties: null
    minProperties: null
    required: null
    not: null
    properties: {product_id=class StringSchema {
        class Schema {
            type: string
            format: null
            $ref: null
            description: Unique identifier representing a specific product for a given latitude & longitude. For example, uberX in San Francisco will have a different product_id than uberX in Los Angeles.
            title: null
            multipleOf: null
            maximum: null
            exclusiveMaximum: null
            minimum: null
            exclusiveMinimum: null
            maxLength: null
            minLength: null
            pattern: null
            maxItems: null
            minItems: null
            uniqueItems: null
            maxProperties: null
            minProperties: null
            required: null
            not: null
            properties: null
            additionalProperties: null
            nullable: null
            readOnly: null
            writeOnly: null
            example: null
            externalDocs: null
            deprecated: null
            discriminator: null
            xml: null
        }
    }}
    additionalProperties: null
    nullable: null
    readOnly: null
    writeOnly: null
    example: null
    externalDocs: null
    deprecated: null
    discriminator: null
    xml: null
}

}

ok so I would ask please to open a new issue and raise a pr with a failing test. I will look into it

Thanks @gracekarina created https://github.com/swagger-api/swagger-parser/issues/1069 couldn't create a PR with a test as don't have permissions to push to a branch, but attached a unit test to the ticket


Update README.md

pretty much nonexistent atm

I would love to try this with a generated resource, but I definitely need some further instructions.

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
icarusdjr, @agileone, @Gabwz, @yauquenlay, @driamend, @ruanyt, @JonatanSalas, @Jkpanchal, @huangnathan, @caijingsong, @CSWellesSun, @drakmail, @chochinlu, @dontfollowsean, @acheema90, @berkerol, @fabriciosantana, @johnnieskywalker, @0xMeowny, @ccbcqbz


Generic Links

support for generic text based buttons

The easiest was is to add an option for ~3 buttons (like email) that render if an env is passed in.

ah didn't see this, I have raised a PR for the short-term email text issue

An idea:
Having 2 envs LINKS_HREF and LINKS_TEXT with splittable string.
if (LINKS_HREF && LINKS_TEXT) {
    var hrefs = LINKS_HREF.split(',');
    var texts = LINKS_TEXT.split(',');
    if (hrefs.length == texts.length)
    for (let index = 0; index < hrefs.length; index++) {
        //need a generic icon
        var button = document.createElement('' + texts[index] + '
');
        //need to have an empty div with id 'generics' in the template
        document.getElementById('generics').appendChild(button);
    }
}

Unlimited links for unlimited power lol

Would love this to be added, so I can add all my website links. The only thing I'm missing! :D

Soon!  Just need 30 min to crank it out :)   Maybe tonight!

@Choubakawa @kenjibailly @Cur50r  https://github.com/techno-tim/littlelink-server/pull/61   Should be available now!


Migrate the frontend to use the new HIR2

Compiled notes from PR comments:
anon namespace

Rather than using the Anon namespace, we should translate symbol names as described in the Component Translation discussion. The gist is that the WIT package name becomes the LibraryNamespace (specifically the User variant), sans version, items exported from the component use the export name as the first non-namespace path component, and so on (i.e. functions exported from an exported interface are additional components). Future changes to LibraryPath will make the syntax for fully-qualified paths a bit more like WIT identifiers, but for now the main thing we want to do is translate them in a way that retains useful semantics in Miden Assembly. We've largely already discussed this, but I'm just reiterating it here since it is relevant to decisions documented in this PR
Likewise, the way in which module/function names are recovered I believe will need to be changed, but we can do that when merging the new IR into the frontend. This is also described in the Component Translation discussion, but essentially we can recover the original WIT interfaces (and their names/exports) using the component instances exported from the top-level component

from https://github.com/0xPolygonMiden/compiler/pull/353?new_mergebox=true#issuecomment-2547008283 :
Generate synthetic functions for Wasm CM canon lift/lower in the frontend
See https://github.com/0xPolygonMiden/compiler/pull/357 comments for more details.

Here's another comment that you may find useful, that more clearly defines ABI and calling convention terminology, and how I envision us approaching those concepts in the compiler.
Essentially, ABI details are largely implicit, and only relevant during code generation. Calling convention details are defined in terms of the ABI, and are also largely irrelevant until code generation, except in terms of validation (i.e. that function signatures are valid according to their assigned convention), and to the extent that they are used to derive other information (e.g. function calls to a CanonLift function must be performed using call rather than exec). We do not need to explicitly encode ABI details in the IR anywhere.


api can't listen.

I can't get the listen event working.
If I have message posted. it doesn't show the message
It only track once when people see the message.
the Answer info got is about 1000 - 30000. Is it because it's too slow?

I'm sorry, it's hard to tell what problem you're having here.  Can you post an example of some code and what you're expecting it to do and what's happening instead?

I have this problem solved. But the message get speed is pretty slow and will failed after a long time. Is there a solution?

We've had issues with people having long latency times in the past.  @bsansouci could this potentially be a problem with always using 0-edge-chat.facebook.com?

Mmmh totally possible. We should look into hitting the server that FB would want us to hit :p

so use it with 0,1,2,3 :P ?
2016-01-26 2:02 GMT+08:00 Benjamin San Souci<EMAIL_ADDRESS>
Mmmh totally possible. We should look into hitting the server that FB
would want us to hit :p
—
Reply to this email directly or view it on GitHub
https://github.com/Schmavery/facebook-chat-api/issues/158#issuecomment-174604265
.

I'd generally say that generating random numbers out of nowhere is probably not the way to solve this problem :D

Though kidding aside, @txs, if you're able to demonstrate better performance hitting a different server, that would be a big motivator for us to look into it.

IDK  if it will  be better. Maybe it will be a cool experiment
On Jan 28, 2016 3:40 AM, "Avery Morin"<EMAIL_ADDRESS>wrote:

Though kidding aside, @txs https://github.com/txs, if you're able to
demonstrate better performance hitting a different server, that would be a
big motivator for us to look into it.
—
Reply to this email directly or view it on GitHub
https://github.com/Schmavery/facebook-chat-api/issues/158#issuecomment-175786783
.

Thanks for your input. We'll track this issue under #161.


MVP user onboarding documentation

User story

As a user of the query service
need a guide with example queries
so that I can learn how to use the Query Service

Definition of Done

[x] Create a docs subdirectory with resources compiled from existing google docs and new info
[ ] Description of the layout of the data in the Query Service
[x] Publish on readthedocs
[ ] Link from project REAMDE.md and API Documentation

@MDunitz please update here once the user guide is included in docs/ and linked from docs/index.md.


Update versions for Aug 2024 Identity release

API change check
API changes are not detected in this pull request.