Figure out a better way to deprecate old feature names

The current way we're deprecating the various x-column-tables feature spams builds with an unreasonable number of warnings, and causes our crate to fail to compile if we have #![deny(warnings)]. Ideally we show the warning in the actual invocation of table!, but https://github.com/rust-lang/rust/issues/49912 prevents us from just doing the obvious thing there.
We should find a better solution though, that doesn't spam logs, and in particular, generates no warnings from inside Diesel itself when compiled with these features turned on. The solution of "remember to remove #[deny(warnings)] when we release isn't going to work long term.

What is the status of this with https://github.com/rust-lang/rust/pull/62042 fixing https://github.com/rust-lang/rust/issues/49912

@npapapietro Yes those fix would help here. We are happy to receive a PR that fixes this. Based on the linked rustc issues it should be possible to just add a conditional #[deprecated] attribute to the table! macro. This can be done via #[cfg_attr] based on the deprecated feature flags (large-table, huge-table, ...)

I'll try and take this up. As I'm just diving into diesel I'd like some more info as this will be a 1st time pr.
Let me see if if I understand this issue correctly

You have a set of features that you would like to deprecate. Where does this list live? I see with-deprecated feature but it is an empty list at the moment.
If diesel is build with one of these features we should add the #[deprecated] attr to the table! macro. Would this be injected into the $meta macro arg in __diesel_parse_table or at the impl of each feature case? This is where I am slightly confused.

You have a set of features that you would like to deprecate. Where does this list live? I see with-deprecated feature but it is an empty list at the moment.

We would like to deprecate the huge-tables feature in favor of the 64-column-tables feature flag. Also the large-tables feature in favor of the 32-column-tables feature.

If diesel is build with one of these features we should add the #[deprecated] attr to the table! macro. Would this be injected into the $meta macro arg in __diesel_parse_table or at the impl of each feature case? This is where I am slightly confused

Adding the deprecated attribute inside the expanded table! macro does not work, as code in those context does not have access to the corresponding flag. (That's because the expanded code is parsed in the context of a third party crate.)
I propose that we just add the the #[deprecated] attribute on table! itself, so that the user gets the corresponding warning there. The deprecated attribute should be only conditionally enabled via #[cfg_attr].

Closed by #2968


☄ New command line arg: additional-data

Resolves #1573

new command line arg: --additional-data [true|false]  (or -ad [true|false]). Default is true (which is the current status quo).

Here's an example which does NOT add the additional data to any generated models:
--openapi https://petstore.swagger.io/v2/swagger.json --additional-data false --language csharp -o PetshopClient -c ApiClient --log-level information --clean-output true

The only thing missing is the docs. the file using.md is gone (that's where I had my original doc-change) .. so I'll have a look around to find where to update the newer docs...

Done 💪🏻 Ready for another review 👀 plz

Thank you @baywet ❤ 🤗


Fix skill tracing on skill invocation error and other enhancements

Added new SaveAllChanges(label) method to DSM that traces the snapshot, but only if memory has changed.
Changed DialogManager to use tracing SaveAllChanges(label)
Changed SkillDialog to use dsm.SaveAllChanges(label)
Make SendToSkill(dc based) so we can call dsm.SaveAllChanges(label)
Added proper event handling for post back
added proper EndOfConversation handling for post back (It was working only because of bug in BeginSkill.)
Add OnSkillResultAsync() to fix BeginSkill ResultProperty
fixes #3953
Add a bunch of comments, unit tests

Please rebase master against this before merging.

@tomlm, per our review, let's get master merged into this, and then we can merge.

@tomlm, please cleanup the ruleset changes so the comments are not deleted.

This seems to be stale, closing it.


Is it possible to add a custom task to leaderboard?

Thank you for open-source this fantastic project.
I want to evaluate the models for an address retrieval task. Is it possible to add this task to the leaderboard when I finished it?
Thank you!

Thank you for open-source this fantastic project.
I want to evaluate the models for an address retrieval task. Is it possible to add this task to the leaderboard when I finished it?
Thank you!

Yes of course, I am happy to add the task to the leaderboard after we have merged it into this repository if you open a PR 👍

This issue seems to have been answered. Will close it


New Google Cloud Region us-east5 (Columbus)

Today the Compute Engine API has returned machine types in us-east5. The region will be the new location in Columbus. Region and Zone as well as Billing API do not know the region yet. I have therefore removed them manually. When the region is 100% ready it must be removed from instances/clean_up.sql.

https://github.com/Cyclenerd/google-cloud-compute-machine-types/commit/912578130b0864f8078d2ec9fe1cfaaac2c8265f

https://github.com/Cyclenerd/google-cloud-pricing-cost-calculator/issues/22

Done: https://gcloud-compute.com/us-east5.html


Fix #8830 bad autocorrect of Style/StringConcatenation when string includes double quotes.

Style/StringConcatenation autocorrect combines strings into a single string, but currently does not escape double quotes.  The autocorrect creates an invalid string.
Current:
Before:
"He said " + "\"Arrest that man!\"."

Autocorrect: (quotes not escaped)
"He said "Arrest that man!"."
#=> syntax error, unexpected tCONSTANT, expecting end-of-input

Fix:
Before:
"He said " + "\"Arrest that man!\"."

Autocorrect: (quotes escaped)
"He said \"Arrest that man!\"."

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


More link customization options

I'm trying to figure out how to make a link text different from the actual href value, but there doesn't seem to be an option for that. Additionally, I'd like to be able to control the event flow behavior when clicking on a link, so I can perform some an in-application task when it's clicked on (as opposed to opening the link in a new page).
An option to set the actual text value of a link separate from the href, and emitting an event when a link is clicked, would be great. Essentially, being able to control the anchor tag attributes on a link by link basis is what I'm going for.

That's a good addition, will work on that soon

For a little bit more context, I want to be able to add a message that looks like this:


Do something with API errors

For example, assert_no_errors in api.ml should probably not raise.

Github


Integrate local TBB and FindTBB.cmake

My project depends on ParallelSTL which in turn requires TBB. I want to use the local TBB version only of none is available. ParallelSTL expects the target TBB::tbb unfortunatly, TBB's target is tbb. After fixing this with an alias I obtian the error message:
CMake Error in ThirdParty/parallelstl/CMakeLists.txt:
  export called with target "ParallelSTL" which requires target "tbb" that is
  not in the export set.

Probably someone else finds my solution helpful:
# Try to find system TBB
find_package( TBB 2018 )
if(NOT TBB_FOUND)
  add_subdirectory(wjakob-tbb)
  set(TBB_FOUND ON)
  add_library(TBB::tbb ALIAS tbb)
  add_library(TBB::tbbmalloc ALIAS tbbmalloc)
  add_library(TBB::tbbmalloc_proxy ALIAS tbbmalloc_proxy)
  export(TARGETS tbb tbbmalloc tbbmalloc_proxy NAMESPACE TBB:: FILE TBBTargets.cmake)
  export(PACKAGE TBB)
endif()

# add_subdirectory(parallelstl)

A FindTBB.cmake like this one is required.
Anyway the reason for this issue is that it would be nice if your build system could export its targets. Let me know if you are interested in a pull request (since a similar one is pending I wasn't sure about that).

We have a TBB:: namespace now so this should work, this can be closed


ViroFlexView inside ViroARCamera doesn't behave as expected

Hi all,
I have the following problem:
I placed an object in a scene  and also a ViroFlexView inside a ViroARCamera. This is the example code:
            <ViroARCamera>
                <ViroFlexView style={styles.titleContainer}
                              width={0.25} height={0.25}
                              position={[0, 0, -1]} >
                </ViroFlexView>
            </ViroARCamera>

            <Viro3DObject
                source={require("../resources/object_flowers.vrx")}
                resources={[require('../resources/object_flowers_diffuse.png'),]}
                highAccuracyGaze={true}
                position={[0, 0, -4]}
                scale={[2, 2, 2]}
                rotation={[45, 0, 0]}
                type="VRX"
                transformBehaviors={["billboard"]}/>

So normally I would assume, that the ViroFlexView would be positioned in front of the object, because its z value is -1. But no matter how I try to change the value, it's always behind the object.

So am I doing something wrong or is this a bug? When I replace the ViroFlexView with a ViroImage and take the same position, it works.

Hey @AntoniaBe, a ViroCamera is actually not designed to be parented objects - they should have no children. If needed, you can use ViroNode instead as the containers within which you can parent any number of objects.
Could you try the above, but instead not parent the flex view (placing it at the same view hierarchal level with the Viro3Dobject) and see if the issue re-occurs?
Thanks!

Actually scratch the above - you can add components to Cameras in Viro 2.81 - are you using the latest release?

any updates on this one? :/

Hey @AntoniaBe, apologies for the late reply.
This does look like an issue within the renderer. I'll file a bug on our backlog so that we can root cause the problem (most likely an issue with rendering our flex views).
Would this be a ship blocker for you?

Hi @dthian ,
thanks for your reply!
I do actually need the ViroFlexView Component inside the ARCamera. Is it possible to fix this one or is there some workaround?
Thanks!

Hey @AntoniaBe, in the above, the main problem was that we are not correctly calculating the depth of the flex view to be placed in the scene, hence it is rendered incorrectly behind your flowerpot, when it should be in the front.
One possible mitigation is to perform the object placement yourself, manually (without parenting the object under the ViroCamera). With a simple js timer, you can grab the position in front of the timer at each timer tick / callback.
To grab the position in front of the camera, you will need to get the camera's position, and it's forward direction. The idea is then to add the cameraPosition + cameraForwardDirection to get your final position in front of the camera. You can use ViroScene.getCameraOrientationAsync()  like it is done here.
Once you have the position in front of the camera, you can simply set the position on your flexview / node that you want to be "locked" to the camera. I would strongly recommend using setNativeProps for this, so as to avoid state changes that could spam the js thread.
I've moved the bug up so that we can prioritize it for the next release.

Hey @AntoniaBe which version of ViroReact are you using again in the above bug? Much thanks!

Hi @dthian,
I'm using version 2.8.1.
And thank you very much for the advice, I will try it out!

Hey @AntoniaBe, I've root caused the issue and have applied the fix - it should be available in our next release!

A rough estimate would be around August 16th -20th.

A rough estimate would be around August 16th-20th. Also please ignore the mitigation solution given above - the bug was deeper and more complicated that previously thought. Apologies for any inconvenience.

This has been fixed in the latest release. Release notes and upgrade instructions here -> https://docs.viromedia.com/docs/releases
Please reopen the issue if you are still having issues


Emu: SoundBlaster support

Work in progress in feature/sound.
Along with General Midi and MT-32.
Code is from the Aeon emulator.
General state:

Windows only
General Midi works
MT-32 "works" but no music can be heard. Yet, the MT-32 ROMS are loaded and Munt is being used.
Sound Blaster code produces a bug where instead of the game having finished initialization and already producing music at around 50k instructions, instead goes way beyond that (around 256k) with still nothing displayed on the screen because of an infinite loop and eventually issues a non-sensical interrupt vector (7, then 255).

Solution : compare those 50k first instructions behaviors between Aeon and Spice86. Or Spice86 and DOSBox Staging.

SoundBlaster :

In Spice86, Dune sends to the Sound Blaster code the WritePort command with value 549 for the port number.
In Aeon, this does not happen.

SoundBlaster:
Aeon debug log before WritePort to the SoundBlaster with a port value of 548 is issued:

Single-cycle DMA
Sound Blaster IRQ
Sound Blaster 8-bit DMA acknowledged

It is also issued for Spice86, but the above debug log is not produced by the emulator.

SoundBlaster:
The Pic is wrong on the Spice86 side compared to Aeon when the SoundBlaster raises an interrupt request with IRQ 7 for the very first time since the emu started Dune on both side.
The requestRegister is 128 on the Aeon side.
It is 131 on the Spice86 side.

The Pic is fixed, but still Dune goes into FUBAR mode.

Fixed recently by some unidentified change. Now at least it works with Dune !


Upgrade playbooks in from 5.5.1 to 6.0.0

Describe the issue
Following the upgrade documentation, we made an upgrade of the whole platform from 5.5.1 to 6.0.0 and we faced a few minor issues that might be good to fix:

upgrade_zookeeper.yml and upgrade_kafka_broker.yml failed because it tried to backup respectively server.properties and zookeeper.properties, even though I understand that it is useful when the colocating of broker and zookeeper, I think that it should not make the playbook fail.
upgrade_kafka_broker.yml l.144
upgrade_kafka_broker.yml l.204
upgrade_zookeeper.yml l.122
upgrade_zookeeper.yml l.189
We were using a custom repository so it might have an impact but we had to add update_cache: yes on all yum install module tasks (it's done systematically for debian).
There is a typo on upgrade_ksql.yml l.131

To Reproduce
Steps to reproduce the behavior:

Install the platform using cp-ansible 5.5.1
Follow the upgrade guide

Environment (please complete the following information):

OS: RHEL 7.5
CP-Ansible Branch: 6.0.0-post

@nbchn Thanks for the report.  I will investigate this today and see about getting a fix in for the spelling mistake.
Regarding the missing server.properties, I suspect this is due to the custom repo.  Generally when you install our packages, there should always be a server.properties, even if it just contains default values, so the fact it wasn't present is suspicious.
Also note, we are currently re-evaluating our upgrade playbooks and plan writing them in the new year.

Hi @nbchn thanks for the feedback! I just fixed the typo in the upgrade_ksql.yml playbook.
For the other 2 points:

How did backing up those files cause a failure. You are right- backing up both server.properties and zookeeper.properties is redundant on a non colocated host, but it really should not cause a failure because both files should exist even if only one file is getting used (they are shipped with the packages)

You are suggesting we make this change here: https://github.com/confluentinc/cp-ansible/blob/6.0.1-post/upgrade_kafka_broker.yml#L179

    - name: Install the Packages - Red Hat
      yum:
        name: "{{item}}{{confluent_package_redhat_suffix}}"
        state: latest
        update_cache: true
      loop: "{{ kafka_broker_packages }}"
      when: ansible_os_family == "RedHat"
      # Packages will not be found in check mode because repos not changed
      ignore_errors: "{{ ansible_check_mode }}"

That seems fine to be honestly since we are setting the same flag for debian

Observed another issue where yum clean all handler got skipped:
TASK [confluent.common : Add Custom Repo file] **************************************************************************************************************************************************************************************
changed: [ip-172-31-86-77.ec2.internal]
[WARNING]: flush_handlers task does not support when conditional

This handlers does not support when conditional is a known ansible issue: https://github.com/ansible/ansible/issues/41313
Proposed workaround:
- name: Add Confluent Dist Yum Repo
  yum_repository:
    name: Confluent.dist
    file: confluent
    description: "Confluent repository (dist)"
    baseurl: "{{confluent_common_repository_redhat_dist_baseurl}}"
    gpgcheck: "{{confluent_common_repository_redhat_dist_gpgcheck}}"
    gpgkey: "{{confluent_common_repository_redhat_dist_gpgkey}}"
    enabled: "{{confluent_common_repository_redhat_dist_enabled}}"
  register: confluent_dist_repo_result
  when:
    - repository_configuration == 'confluent'
    - installation_method == "package"
- name: Add Confluent Yum Repo
  yum_repository:
    name: Confluent
    file: confluent
    description: "Confluent repository"
    baseurl: "{{confluent_common_repository_redhat_main_baseurl}}"
    gpgcheck: "{{confluent_common_repository_redhat_main_gpgcheck}}"
    gpgkey: "{{confluent_common_repository_redhat_main_gpgkey}}"
    enabled: "{{confluent_common_repository_redhat_main_enabled}}"
  register: confluent_repo_result
  when:
    - repository_configuration == 'confluent'
    - installation_method == "package"
- name: Add Custom Repo file
  copy:
    src: "{{custom_yum_repofile_filepath}}"
    dest: /etc/yum.repos.d/custom-confluent.repo
  when: repository_configuration == 'custom'
  register: custom_repo_result
- name: yum-clean-all
  command: yum clean all
  args:
    warn: false
  when: custom_repo_result.changed|default(False) or confluent_repo_result.changed|default(False) or confluent_dist_repo_result.changed|default(False)

I've added the update_cache: true bit to the yum module, and also replaced the yum clean all handler into more reliable conditional tasks. I did not address your first complaint but I do not think that one is causing any failures, so I will close this.

I've added the update_cache: true bit to the yum module, and also replaced the yum clean all handler into more reliable conditional tasks. I did not address your first complaint but I do not think that one is causing any failures, so I will close this.


Repeating hue error

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.66.0.beta0
Python release (python3 --version):
Python 3.5.3
Component/platform:
Philips Hue
Description of problem:
Log is flooded with this error repeating every 6-7 seconds
Expected:
No error.
Problem-relevant configuration.yaml entries and steps to reproduce:
hue:
  bridges:
    - host: <IP_ADDRESS>
      allow_hue_groups: false
      allow_unreachable: true

Traceback (if applicable):
Mar 24 13:21:18 raspberrypi hass[504]: Traceback (most recent call last):
Mar 24 13:21:18 raspberrypi hass[504]:   File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
Mar 24 13:21:18 raspberrypi hass[504]:     result = coro.send(None)
Mar 24 13:21:18 raspberrypi hass[504]:   File "/usr/local/lib/python3.5/dist-packages/homeassistant/helpers/entity.py", line 222, in async_update_ha_state
Mar 24 13:21:18 raspberrypi hass[504]:     attr = self.state_attributes or {}
Mar 24 13:21:18 raspberrypi hass[504]:   File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/light/__init__.py", line 494, in state_attributes
Mar 24 13:21:18 raspberrypi hass[504]:     value = getattr(self, prop)
Mar 24 13:21:18 raspberrypi hass[504]:   File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/light/hue.py", line 248, in hs_color
Mar 24 13:21:18 raspberrypi hass[504]:     self.light.state.get('hue') / 65535 * 360,
Mar 24 13:21:18 raspberrypi hass[504]: TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'

Additional info:
This is my first issue submission. Hope I got everything right.

I confirm I get the exact same issue since 66.0. I also tried 0.67 dev and the issue is there too.
Thanks

Thanks for reporting this 👍
Seems similar to https://github.com/home-assistant/home-assistant/pull/13349
CC @balloob

@OttoWinter, I agree this seem related.
The issue is present in today's dev snapshot (I understand from the related issue that it was merged.
Thanks

Would be nice if we logged the entity that triggered that 🤔
So it looks like your light bulb is not reporting the hue/sat if the color mode is (I assume) set to xy.

People that are having this issue, what light bulbs and bridge are you using?

I've opened a fix here: https://github.com/home-assistant/home-assistant/pull/13465
Would still like to know the hardware that is causing this.

@balloob Here is the info on my hardware:
Philips hue bridge - BSB002
Light bulbs:
BR30 LCT002
3 x white A19 LWB006
white A19 LWB014
bloom LLC012
2 x lightstrip LST002
4 x color A19 LCT007

tap switch and a few motion sensors (probably irrelevant here)

Please let me know if I can help with anything else.

Gen 2 Bridge and white bulbs also 2 dimmer remotes. I am using @robmarkcole hue-sensor component with the remotes.

I am experiencing the same problem.
It appears that only the WHITE bulbs are causing the problem at least in my case; whether they are reachable or not (with the wall switch off) and only when the individual light(s) are turned on.
Docker HA version 0.66.0.beta0
Hue Bridge 2.0 SW<PHONE_NUMBER>
Colour bulbs GU 10 LCT003 SW <IP_ADDRESS>36
White bulbs B22 LWB010 SW 1.29.0_r21169


SAMZA-1513: Doc updates for persistent windows, joins and serdes.

@jmakes @prateekm @nickpan47 for review.

Address @jmakes's feedback.


Ensure all JDQL syntax works

The Data API defines JDQL for writing out queries in a SQL-like format:
https://github.com/jakartaee/data?tab=readme-ov-file#jakarta-data-query-language-jdql
This has been the case for a while and should be handled by the JNoSQL layer, but we should have test cases for everything we can.

It seems like this doesn't work as it is, but the Data and NoSQL specs, plus JNoSQL are all in flux currently, so it's likely that their implementations don't currently align.


Create pull request template for this repository

Create pull request template for this repository

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-data/pull/41


Language attribute for client requests

This pull request adds the possibility to define a language for Client requests. This is especially useful when fetching game data (e.g. descriptions).
Steam provides these in the requested language (e.g. German) if possible. Otherwise the API defaults to English.
Example via a normal web call:
https://store.steampowered.com/api/appdetails/?appids=107410&format=json&l=german

Hi~
I very agree to define the language by the client, but I think it should not be defined in config
Maybe like this can be better?
public function appDetails($appIds, $cc = 'us', $language = 'english')

···

        $arguments = [
            'appids' => $appIds,
            'cc'     => $cc,
            'l'      => $language,
        ];

Do you think?

So I've made the recommended changes.
There are two things that I'd like a second pair of eyes on, though:

I couldn't find a way to specify a parameter to select the currency. This seems to be based on the GeoIP detection of steam. Unfortunately, the API as also not helpful and trying out random parameter combinations didn't help either.

For now, I've only added the language selection for the appDetails method. There are potentially other areas where this would also be helpful, so I'm open for recommendations where to add it as well.

😂 @syntaxerrors said:

But remember, the steam API is one of the worst documented APIs out there.

About currency/country and language parameter, this document is listed. (But I don't understand why the document for the Steam store API appears on teamfortress.com 🤦♂)
If no country or language parameters are set, I think Steam should return data based on the Accept-Language request header.
The methods that support these parameters are also listed:

api/featured
api/featuredcategories
api/appdetails
api/appuserdetails
api/messages
api/packagedetails
api/salepage

And I think only store.steampowered.com/api supports these parameters.
I recommend updating the appDetails method to support country selection, Then add a packageDetails method based on appDetails.
Maybe I Can send you pull requests?

@2er7 Absolutely! I've added you as a collaborator for the package, so feel free to just directly add your thoughts.
It'd be great if you could ass the packageDetails method based on how you imagine it, since I'm not 100% sure I get in which way you'd like to add it.

@jastend packageDetails method has been added ✌

@2er7 Looks solid :ok_hand:

I updated the travis config file to make testing pass again.  If you merge in that change to yours it should begin passing.

@stygiansabyss Thank you, I will update the documentation in this PR after about 2 hours.
and thanks to @jastend

Thank you @stygiansabyss. I'm glad you like the idea!
I've added the updated Travis file and I'll likely add the country and language option to more methods in the future. Unfortunately, I don't think that I'll have the time this week to properly test where it makes sense, but feel free to mention me if any request comes up in the meantime.
Thank you for your help @2er7!

Thanks :)
Once the docs are updated I will merge in this PR.  That's the only thing thats really needed atm.  Everything else looks good.

I have updated documentation and added example, plaese reveiw 😊

Merged in.  Great work you two!

Pushed version 2.0.12 with this change included.

@Teakowa it seems the "formatPriceObject" method is missing from Containers/Package.php. Tests are broken until it is implemented. Please share what the method was supposed to be.

@nicekiwi I am so sorry for this error. I accidentally included this error while texting another feature.
I will fix this error as soon.


Update pre-commit hook versions

pre-commit autoupdate also wants to update mypy to 0.790, but running that prints a error:
xarray/core/utils.py:466: error: Value of type variable "_LT" of "sorted" cannot be "K"

I'm not sure how to fix that, so I'll leave the upgrade to someone else.

See: https://github.com/python/mypy/issues/9582
Maybe K should be replaced with Hashable or K = TypeVar("K", bound=Hashable) (or maybe it has to be "Comparable" as suggested in the issue).

I am not entirely sure what I say below is correct. So would be good if someone with more experience with python typing could have a look.

I think the solution is to add  # type: ignore to
https://github.com/pydata/xarray/blob/7ce0110f727b37a776d509174365cf0905163234/xarray/core/utils.py#L466

The alternative would be to define:
class HashableSortable(Protocol):
    def __lt__(self, __other: Any) -> bool: ...
    def __hash__(self) -> int: ...

SortableHashableT = TypeVar("SortableHashableT", bound=HashableSortable)

but then we would probably need to replace all instances of "Dict[Hashable, int]" with "Dict[SortableHashable, int]".
Unfortunately we cannot do
class Sortable(Protocol):
    def __lt__(self, __other: Any) -> bool: ...

SortableT = TypeVar("SortableT", bound=HashableSortable, covariant=True)

because covariant type variable cannot be used as a parameter.

let's continue this in #4571


Ambiguous types in AddressInfo

The f type variable in the GetNameInfo class definition in System.Socket.Internal.AddressInfo appears to be ambiguous,
class (Family f) => GetNameInfo f where
  getNameInfo :: SocketAddress f -> NameInfoFlags -> IO (BS.ByteString, BS.ByteString)

I'd imagine the intent here was that the first argument would determine f, but to do so SocketAddress would need to be injective. As far as I know there is no way that GHC would know this. This causes the package to fail to build with GHC 8.0 with,
src/System/Socket/Internal/AddressInfo.hsc:303:3: error:
    • Couldn't match type ‘SocketAddress f0’ with ‘SocketAddress f’
      NB: ‘SocketAddress’ is a type function, and may not be injective
      The type variable ‘f0’ is ambiguous
      Expected type: SocketAddress f
                     -> NameInfoFlags -> IO (BS.ByteString, BS.ByteString)
        Actual type: SocketAddress f0
                     -> NameInfoFlags -> IO (BS.ByteString, BS.ByteString)
    • In the ambiguity check for ‘getNameInfo’
      To defer the ambiguity check to use sites, enable AllowAmbiguousTypes
      When checking the class method:
        getNameInfo :: forall f.
                       GetNameInfo f =>
                       SocketAddress f
                       -> NameInfoFlags -> IO (BS.ByteString, BS.ByteString)
      In the class declaration for ‘GetNameInfo’

Note that GHC 8.0 will include support for injectivity annotations but unless you want to drop support for earlier compilers you will likely want to either find another way to disambiguate this type or make SocketAddress a data family (which are injective).
To see why this code is problematic, consider the following silly example,
{-# LANGUAGE TypeFamilies #-}
class Family f where
    type Address f

data Inet6
data Inet7

data AnAddress = AnAddress

instance Family Inet6 where type Address Inet6 = AnAddress
instance Family Inet7 where type Address Inet7 = AnAddress

class (Family f) => GetNameInfo f where
    getNameInfo :: Address f -> String

instance GetNameInfo Inet6 where getNameInfo AnAddress = "Inet6"
instance GetNameInfo Inet7 where getNameInfo AnAddress = "Inet7"

main = putStrLn (getNameInfo AnAddress)

What should this print? Neither I nor GHC have any idea since both Address Inet6 and Address Inet7 unify with AnAddress. The fact that typeclasses are open means that even if there is only one instance in your library, anyone may later come along and add another Family, potentially introducing ambiguity.

For the record, the a similar program written with injectivity annotations would like this,
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeFamilyDependencies #-}

type family Address f = r | r -> f

data Inet6
data Inet7

data AnAddress = AnAddress

type instance Address Inet6 = AnAddress
--type instance Address Inet7 = AnAddress

class GetNameInfo f where
    getNameInfo :: Address f -> String

instance GetNameInfo Inet6 where getNameInfo AnAddress = "Inet6"
--instance GetNameInfo Inet7 where getNameInfo AnAddress = "Inet7"

main = putStrLn (getNameInfo AnAddress)

Moreover, if you uncomment the Inet7 lines GHC will fail with an error, informing you that you have violated the injectivity requirement of the family.

Hi Ben,
thanks for noting this and writing such an elaborate example. I'll look into this, maybe at the weekend. I need some time to get into this (again).
I was not aware about upcoming injectivity annotations when I wrote this library :-)

I followed your proposal and had a look data families again. Both, injectivity annotation and data families seem to be a viable solution to the issue. At the moment I tend a bit more towards the data families:
Pro data family:

Conceptually, the address type wouldn't need to/couldn't exist without the socket family. This would be correctly modeled by using a data family.
Supported on older compiler versions.

Pro injectivity annotation:

Arbitrary (existing) type may be used as address without additional boxing (probably not desired anyway).

{-# LANGUAGE TypeFamilies #-}
module Experiment where

class Family f where
data family Address f

class (Family f) => GetNameInfo f where
    getNameInfo :: Address f -> String

data Inet
data instance Address Inet = InetAddress
instance Family Inet where
instance GetNameInfo Inet where
  getNameInfo InetAddress = "INET"

data Inet6
--data instance Address Inet6 = Inet6Address
instance Family Inet6 where
instance GetNameInfo Inet6 where
  getNameInfo _ = "INET6"

main :: IO ()
main = do
  print $ getNameInfo InetAddress
  -- This one is surprised me a little... (No data instance!)
  print $ getNameInfo (undefined :: Address Inet6)

I'll continue investigating what the implications of switching to data families are.

Will be fixed in upcoming version <IP_ADDRESS>.


Alexcmonnet/clean up the plantuml 381

Closes #381

Interfaces are no-longer duplicated and positioned before the first component that references them
Changed component arrow reference to '-->' for better rendering flexibility.

New Output:
@startuml System Component Diagram
title System Component Diagram

interface UserRequest
interface DataD

component "System" {
  interface DataB
  component "ServiceOne"
  UserRequest --> ServiceOne : in
  ServiceOne --> DataB : out

  interface DataC

  component "Subsystem" {
    component "ServiceTwo"
    DataB --> ServiceTwo : in
    ServiceTwo --> DataC : out

  }
  DataB --> Subsystem : in
  Subsystem --> DataC : out

  component "ServiceThree"
  DataC --> ServiceThree : in
  ServiceThree --> DataD : out

}
UserRequest --> System : in
System --> DataD : out

@enduml

@startuml Subsystem Component Diagram
title Subsystem Component Diagram

interface DataB
interface DataC

component "Subsystem" {
  component "ServiceTwo"
  DataB --> ServiceTwo : in
  ServiceTwo --> DataC : out

}
DataB --> Subsystem : in
Subsystem --> DataC : out

@enduml

Interfaces are no-longer duplicated and positioned before the first component that references them
Changed component arrow reference to '-->' for better rendering flexibility.


config (re)load failed, config marked stale

Is this a bug report or a feature request?:
bug report
What happened:
Deployment with version 0.6.0 and 0.6.1 does not work. Works with 0.5.0
What you expected to happen:
Working with 0.6.X
How to reproduce it (as minimally and precisely as possible):
We just deployed the default configuration of metallb. RBAC rules are ok, working with 0.5.0.
Anything else we need to know?:
{"caller":"k8s.go:414","configmap":"metallb-system/config","event":"configStale","msg":"config (re)load failed, config marked stale","ts":"2018-04-26T11:41:48.283870738Z"}
{"caller":"reflector.go:341","level":"warn","msg":"go.universe.tf/metallb/internal/k8s/k8s.go:282: watch of *v1.ConfigMap ended with: too old resource version: 12523 (13121)","ts":"2018-04-26T11:59:23.314956Z"}

Environment:

MetalLB version: 0.6.1
Kubernetes version: v1.10.1
BGP router type/version: Cisco
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1688.5.3
VERSION_ID=1688.5.3
BUILD_ID=2018-04-03-0547
PRETTY_NAME="Container Linux by CoreOS 1688.5.3 (Rhyolite)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"

The error that explains why the config load failed will be a little higher in the log. However, if it works on 0.5, it's likely due to the incompatible config changes that happened in the 0.4->0.5 transition. 0.5 still accepted the old configuration to allow for a smooth transition, but 0.6 dropped support for the old field names.
See https://metallb.universe.tf/release-notes/#version-0-6-0 and https://metallb.universe.tf/release-notes/#version-0-5-0 for what changed, and how to fix your config.
If it still doesn't work with that applied, please reopen and paste your config, and I'll help figure out what's wrong. Thanks!

Log:
W0502 12:39:00.971184       1 client_config.go:529] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0502 12:39:01.162016       1 main.go:48] kube-system/kubernetes-dashboard: start update
I0502 12:39:01.162046       1 main.go:57] kube-system/kubernetes-dashboard: skipped, waiting for config
I0502 12:39:01.162051       1 main.go:58] kube-system/kubernetes-dashboard: end update
I0502 12:39:01.162057       1 main.go:48] default/kube-opsview: start update
I0502 12:39:01.162061       1 main.go:57] default/kube-opsview: skipped, waiting for config
I0502 12:39:01.162064       1 main.go:58] default/kube-opsview: end update
I0502 12:39:01.162068       1 main.go:48] default/kubernetes: start update
I0502 12:39:01.162072       1 main.go:57] default/kubernetes: skipped, waiting for config
I0502 12:39:01.162075       1 main.go:58] default/kubernetes: end update
I0502 12:39:01.162079       1 main.go:48] ingress-nginx/default-http-backend: start update
I0502 12:39:01.162082       1 main.go:57] ingress-nginx/default-http-backend: skipped, waiting for config
I0502 12:39:01.162086       1 main.go:58] ingress-nginx/default-http-backend: end update
I0502 12:39:01.162090       1 main.go:48] ingress-nginx/ingress: start update
I0502 12:39:01.162093       1 main.go:57] ingress-nginx/ingress: skipped, waiting for config
I0502 12:39:01.162097       1 main.go:58] ingress-nginx/ingress: end update
I0502 12:39:01.162101       1 main.go:48] ingress-nginx/ingress-2: start update
I0502 12:39:01.162104       1 main.go:57] ingress-nginx/ingress-2: skipped, waiting for config
I0502 12:39:01.162108       1 main.go:58] ingress-nginx/ingress-2: end update
I0502 12:39:01.162111       1 main.go:48] kube-system/heapster: start update
I0502 12:39:01.162125       1 main.go:57] kube-system/heapster: skipped, waiting for config
I0502 12:39:01.162136       1 main.go:58] kube-system/heapster: end update
I0502 12:39:01.162143       1 main.go:48] kube-system/kube-dns: start update
I0502 12:39:01.162148       1 main.go:57] kube-system/kube-dns: skipped, waiting for config
I0502 12:39:01.162151       1 main.go:58] kube-system/kube-dns: end update
I0502 12:39:01.162400       1 main.go:121] Controller synced, can allocate IPs now
I0502 12:39:01.162487       1 event.go:218] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"metallb-system", Name:"config", UID:"0ae5e700-4e03-11e8-91da-00505684169b", APIVersion:"v1", ResourceVersion:"306663", FieldPath:""}): type: 'Warning' reason: 'InvalidConfig' could not parse config: yaml: unmarshal errors:
  line 5: field password not found in struct config.peer

Config:
apiVersion: v1
kind: ConfigMap
metadata:
  namespace: metallb-system
  name: config
data:
  config: |
    peers:
    - peer-address: <IP_ADDRESS>
      peer-asn: 65000
      my-asn: 65300
      password: "blubber"
      hold-time: 9
    address-pools:
    - name: default
      protocol: bgp
      avoid-buggy-ips: true
      auto-assign: false
      addresses:
      - <IP_ADDRESS>/24

Huh, that's bizarre. The password field definitely exists in 0.6, I have the code open on that exact thing.
Can you paste the running manifest (kubectl get deploy -n metallb-system controller) ? The only explanation I can think of right now is that your controller is running a really old version, somehow...

ok sry my fault... forget the last logs, you were right, it did not update from 0.5.0 to 0.6.2... Here's the original problem again after upgrading:
{"branch":"HEAD","caller":"main.go:139","commit":"bd678827","msg":"MetalLB controller starting version 0.6.2 (commit bd678827, branch HEAD)","ts":"2018-05-03T05:33:42.049684518Z","version":"0.6.2"}
{"caller":"k8s.go:414","configmap":"metallb-system/config","event":"configStale","msg":"config (re)load failed, config marked stale","ts":"2018-05-03T05:33:42.445432053Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"kube-system/kube-dns","ts":"2018-05-03T05:33:42.445549569Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"kube-system/kube-dns","ts":"2018-05-03T05:33:42.445583869Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"kube-system/kube-dns","ts":"2018-05-03T05:33:42.445616202Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"default/kube-opsview","ts":"2018-05-03T05:33:42.445647481Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"default/kube-opsview","ts":"2018-05-03T05:33:42.445675808Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"default/kube-opsview","ts":"2018-05-03T05:33:42.44570347Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"ingress-nginx/default-http-backend","ts":"2018-05-03T05:33:42.445833373Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"ingress-nginx/default-http-backend","ts":"2018-05-03T05:33:42.445874572Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"ingress-nginx/default-http-backend","ts":"2018-05-03T05:33:42.446099056Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"ingress-nginx/ingress","ts":"2018-05-03T05:33:42.446142771Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"ingress-nginx/ingress","ts":"2018-05-03T05:33:42.446176246Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"ingress-nginx/ingress","ts":"2018-05-03T05:33:42.446200565Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"ingress-nginx/ingress-2","ts":"2018-05-03T05:33:42.446227553Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"ingress-nginx/ingress-2","ts":"2018-05-03T05:33:42.446252748Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"ingress-nginx/ingress-2","ts":"2018-05-03T05:33:42.446276265Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"kube-system/heapster","ts":"2018-05-03T05:33:42.446304491Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"kube-system/heapster","ts":"2018-05-03T05:33:42.446327826Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"kube-system/heapster","ts":"2018-05-03T05:33:42.446351186Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"default/kubernetes","ts":"2018-05-03T05:33:42.446378169Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"default/kubernetes","ts":"2018-05-03T05:33:42.446400739Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"default/kubernetes","ts":"2018-05-03T05:33:42.446424444Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"kube-system/calico-typha","ts":"2018-05-03T05:33:42.446450995Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"kube-system/calico-typha","ts":"2018-05-03T05:33:42.446508374Z"}
{"caller":"main.go:60","event":"endUpdate","msg":"end of service update","service":"kube-system/calico-typha","ts":"2018-05-03T05:33:42.446550526Z"}
{"caller":"main.go:49","event":"startUpdate","msg":"start of service update","service":"kube-system/kubernetes-dashboard","ts":"2018-05-03T05:33:42.446581003Z"}
{"caller":"main.go:59","event":"noConfig","msg":"not processing, still waiting for config","service":"kube-system/kubernetes-dashboard","ts":"2018-05-03T05:33:42.446604696Z"}

@mmack Ah solved the issue! The problem is that if you're using helm and following the documentation then your config file looks something like:
apiVersion: v1
kind: ConfigMap
metadata:
  namespace: metallb-system
  name: config
data:
  config: X

but if you look at the speaker arguments, they actually expect the name to be "metallb-config"
Args:
--port=7472
--config=metallb-config

Thank you, that was indeed the problem... 👍

I still get the error message config (re)load failed, config marked stale on 0.6.2 (installed via helm) when loading the configmap.
My ConfigMap looks like this:
apiVersion: v1
kind: ConfigMap
metadata:
  namespace: metallb-system
  name: metallb-config
data:
  config:  |
    address-pools:
    - name: test
      protocol: layer2
      - <IP_ADDRESS>/29

+1 with Rancher 2.0, k8s (v1.10.3) installed via catalog apps (v.0.7.0) and this ConfigMap
kind: ConfigMap
metadata:
  namespace: metallb
  name: metallb-config
data:
  config:  |
    address-pools:
    - name: default
      protocol: layer2
      - <IP_ADDRESS>/24
      avoid-buggy-ips: true

Your configurations are both invalid. You're missing addresses: before the list of CIDR prefixes.


Partitioned index doesn't work after upgraded to v2.4.2-9.2

I used partitioned index in my service.
After I upgraded elassandra to v2.4.2-9.2, partitioned index was created but data was not indexed.

Fixed in 2.4.2-10, there is now a unit test to check that.
Thanks for reporting the issue.


Add Firebase Crashlytics API

Is it planned to develop the Firebase Crashlytics API?

No plans yet, but PRs welcome!

Wait, isnt it here: https://github.com/GitLiveApp/firebase-kotlin-sdk/tree/master/firebase-crashlytics ?


ci: unit & ui testing

also:

migrate react-app to vite
remove react-scripts
common prettier config
stub out code for deploying react-app to romcal.js.org

closes #4
closes #7

@emagnier @tukusejssirs if you wouldn't mind approving the workflow run when you have time and reviewing, I think this covers most of our UI testing needs

FYI, you're also an admin on the main romcal repo. I trust you completely, and it'll be easier for you to make progress more efficiently on all the scaffolding and setting up the things for romcal.

@TobiTenno, see my latest comments. I agree with everything you did and thank you for implementing of my suggestions! :pray:


Change point 1 of Planned Enhancements

Changed 1st point of Planned Enhancements in the Appendix.

LGTM shanyl!! thanks


New tagged ROS release that includes newest commits

Hi,
I found the new return code change introduced in #40 useful and our code base is currently using the master branch of this repository. However, it would be helpful if this was released through ROS. Would it be possible for you to create a new tagged version for ROS Kinetic that includes the above commit please?
Thank you very much!

Yes, version 2.0.7. was just released and should be part of the binaries in the next days.


make miri-seed a regular integer, and also set layout-seed in many-seeds

This makes the seed format consistent between -Zlayout-seed and -Zmiri-seed.

@bors r+

:pushpin: Commit c9cbeb46f809ab871b0f40117dc50b8cae478506 has been approved by oli-obk
It is now in the queue for this repository.

:hourglass: Testing commit c9cbeb46f809ab871b0f40117dc50b8cae478506 with merge 373e88523a29d59ec292628cd695b62f532d9014...

I was about to ask. :)

:broken_heart: Test failed - checks-actions

@bors r=oli-obk

:pushpin: Commit e07fe54a8a67b745f4c01e9bbe1fedbd02176970 has been approved by oli-obk
It is now in the queue for this repository.

:hourglass: Testing commit e07fe54a8a67b745f4c01e9bbe1fedbd02176970 with merge e76a95915b5640a560651e534371280d3a3eb2a1...

:sunny: Test successful - checks-actions
Approved by: oli-obk
Pushing e76a95915b5640a560651e534371280d3a3eb2a1 to master...


Reproducing AudioCaps and Clotho resutls.

Hey!
I'm trying to reproduce the results for the HTSAT-RoBERTa setup, with AudioCaps and Clotho as the training sets.
Results are good for Clotho-valid, and similar to the paper, but are much worse for AudioCaps-valid.
T2A R@k of (7, 40, 54) instead of (36, 70, 83).
I'm using HTSAT-tiny, checkpoint downloaded from the  official repo.
I've also tried using the CLAP published checkpoints, and adapting the eval_retrieval_freesound.sh script to run on Audiocaps and Clotho by passing the correct arguments.
The script reported audiocaps valid T2A R@k of (8, 38, 57) instead of the (32, 68, 81) for this checkpoint.
Results for Clotho valid are similar to those in the paper.
I'm not sure what could be the problem, since I'm using the existing checkpoint and the AudioCaps dataset preparation code from the LAION repo.
Thanks in advance!

Hi,
For training from scratch: could you please let us know what script you are using and how you make the dataset? The problem could be in the dataset creation part (e.g. the incorrect audiocaps dataset). Or, it could be the different hyperparameter. Batch size could be one of that.
For evaluating from the published checkpoint: it could be likely the problem of evaluation,
Evaluating Clotho and Audiocaps could be tricky, as they have five texts for each audio. TLDR: you count the best result if you are evaluating A2T, and the average result for T2A.
We adopted the evaluation code in https://github.com/XinhaoMei/audio-text_retrieval/blob/main/tools/utils.py#L74 . Our evaluation code can be found at: https://github.com/LAION-AI/CLAP/blob/main/src/training/train.py#L578 .
I am sorry for the confusion. To mitigate both part, I am planning to upload the webdataset version of the Clotho and Audiocaps, and I am planning to add a detailed description of the evaluation in the paper revision.
Please let me know for further questions.
Best regards,
Yusong

Thank you for the quick answer!
Evaluating existing checkpoints:
I'm using the retrieval evaluation script, except using --datasetnames "audiocaps" "Clotho" and replacing --remotedata with appropriate local values. This script uses your evaluation code, which has special treatment for these datasets.
I've used this script to download and preprocess Clotho and Audiocaps.
Since the problem appears only in one dataset, and happens both in the existing checkpoints, and the model I trained locally, I think it's clear the problem is in the dataset preparation.
Access to the webdataset versions of the data should probably solve it.
As a side note, I've also asked in the discord server about webdataset versions of the datasets mentioned in the paper, but was informed you (LAION) are not redistributing them. This makes reproducing and continuing your work more challenging.
Training from scratch: I'm using the htsat-roberta script.
I've replaced the --remotedata with local values, and otherwise did not change the script.
I've tried both smaller, and larger, batch sizes, compared to the 96 (x8 GPUs) you've specified. Smaller batch sizes did hurt performance, but the difference was small, and larger batch sizes did not close the performance gap described above.
Thanks in advance,
Assaf

Hi @assafmu , we uploaded the webdataset format dataset for Clotho, pleas check: https://github.com/LAION-AI/CLAP/blob/main/README.md#reproducibility

Hi,
Thank you for the response!
I'll try using the Clotho dataset, and the HTSAT checkpoint, and will report results.
However, results on the Clotho dataset were already similar to those reported in the paper. The difference I saw was in the AudioCaps dataset.
I'm no expert on this, but maybe making the AudioCaps dataset (or others) only available on request for other academics could solve the copyright issue?
Thanks in advance,
Assaf

Hi,
Unfortunately, as far as I know, hosting AudioCaps is
extremely complicated. Because the data is from Youtube, in theory, once
one of the videos is removed by the uploader, we need to remove it from the
dataset.  And you could imagine other datasets has their own copyright
restrictions.
Also, if you would like to access the data (or on request for other
academics), you could always try to contact LAION since our internal data
is hosted inside LAION. However, I would doubt that would be a
straightforward process, as we might have copyright issues by spreading the
data.
Best,
Yusong
assafmu @.***> 于2023年1月24日周二 06:53写道：

Hi,
Thank you for the response!
I'll try using the Clotho dataset, and the HTSAT checkpoint, and will
report results.
However, results on the Clotho dataset were already similar to those
reported in the paper. The difference I saw was in the AudioCaps dataset.
I'm no expert on this, but maybe making the AudioCaps dataset (or others)
only available on request for other academics could solve the copyright
issue?
Thanks in advance,
Assaf
—
Reply to this email directly, view it on GitHub
https://github.com/LAION-AI/CLAP/issues/59#issuecomment-1401814772, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGXJZ7ZRTMMCBL2LV3OZ3LLWT67ENANCNFSM6AAAAAATURNWPM
.
You are receiving this because you commented.Message ID:
@.***>

Hey! I'm trying to reproduce the results for the HTSAT-RoBERTa setup, with AudioCaps and Clotho as the training sets. Results are good for Clotho-valid, and similar to the paper, but are much worse for AudioCaps-valid. T2A R@k of (7, 40, 54) instead of (36, 70, 83).
I'm using HTSAT-tiny, checkpoint downloaded from the official repo.
I've also tried using the CLAP published checkpoints, and adapting the eval_retrieval_freesound.sh script to run on Audiocaps and Clotho by passing the correct arguments. The script reported audiocaps valid T2A R@k of (8, 38, 57) instead of the (32, 68, 81) for this checkpoint. Results for Clotho valid are similar to those in the paper.
I'm not sure what could be the problem, since I'm using the existing checkpoint and the AudioCaps dataset preparation code from the LAION repo. Thanks in advance!

hey @assafmu , I wonder if you've found a solution? I also met similar problem when working on AudioCaps, and got similar results as T2A R@k of (8, 38, 57)

I did not find a solution.
AudioCaps is a difficult dataset, and since a processed version is not publicly available (copyright issues), it is very unlikely to reproduce those results, even with the same code.
Trying to recreate the AudioCaps dataset, and reproducing its processing, was also not practical.

@lukewys Would you be able to release the size of the eval/test sets for the version audio caps reported in the paper? It would be helpful to put the retrieval metrics in perspective.


"Poiana Vadului" is listed in the dropdown menu when searched.

Description : When you will type "Poiana Vadului" in the search bar you should see it in the dropdown menu correctly spelled and with locality information.
Precondition : The website is up and running

Step 1
Type "Poiana Vadului" in the search bar.
Expected results:
The dropdown is listing "Poiana Vadului" as the first location in the dropdown menu.

Step 2 : Observe "Poiana Vadului" from the dropdown menu.
Expected result : "Poiana Vadului" should be correctly spelled, it should have locality information and should be selectable from the dropdown menu.


azure-metrics-exporter: add additional labels and annotations to azure-metrics-exporter

What this PR does / why we need it
The azure-metrics-exporter chart does not has the ability to include additional labels and annotations to the servicemonitors, which other charts do have, like the azure-loganalytics-exporter.
Which issue this PR fixes
None
Special notes for your reviewer
Used the same approach/format as azure-loganalytics-exporter chart
Checklist

[ x] Chart Version bumped
[x ] Title of the PR starts with chart name (e.g. [azure-metrics-exporter])

@mblaschke Any change you could review this one? Would really help us using this tool.


Error retry count in diagnostic logs (actionid send-action-request ) when external endpoint request is timedout

Wrong Retry count in the resultMessage of the diagnostic log for action-id send-action-request

How To Reproduce:

Configure an external endpoint which takes more than 1s to give the response.
Configure Pre Issue Access Token action through IS.
Take an access token for an application which enabled jwt token with grant types (authorize_code, password, client_credntials, refresh_token)
Refer the diagnostic logs recorded in the IS terminal.

Related Issues :

https://github.com/wso2/product-is/issues/21210

This fix is deployed in PROD


[FEATURE] Codable conformance

Is your feature request related to a problem? Please describe.
Types that use Clamped properties lose automatic Codable conformance since Clamped itself does not conform to codable.
Describe the solution you'd like.
Clamped conforms to Codable when Value itself is Codable, encoding the wrapped value.
Describe alternatives you've considered.
Manual Codable conformance is still possible for types using Clamped properties, but it is much more work.
Additional context
It could be useful to also do this for other protocols such as Hashable.
I would be willing to give this a shot and might put up a PR for it soon.

Did some investigation. Encodable conformance can be added pretty trivially by just encoding the value, but adding Decodable support doesn't work the same way since range can't be initialized from just the value.


Simplify Event Model for Notification in v0.9.0

I'm not sure to understand why we have Event, EventBase and QosStatusChangedEvent.
IMHO we can define an Event that contains all EventBase properties and a specialized version QosStatusChangedEvent.
See below.
 Event:
      description: The event being notified
      type: object
      required:
        - eventId
        - eventType
        - eventTime
      properties:
        eventId:
          $ref: "#/components/schemas/EventId"
        eventType:
          $ref: "#/components/schemas/EventType"
        eventTime:
          $ref: "#/components/schemas/EventTime"
      discriminator:
        propertyName: eventType
        mapping:
          QOS_STATUS_CHANGED: "#/components/schemas/QosStatusChangedEvent"

QosStatusChangedEvent:
      type: object
      allOf:
          - $ref: "#/components/schemas/Event"
      required:
          - sessionId
          - qosStatus
      properties:
          sessionId:
                $ref: "#/components/schemas/SessionId"
          qosStatus:
                $ref: "#/components/schemas/EventQosStatus"
          statusInfo:
                $ref: "#/components/schemas/StatusInfo"

This way, returning a QosStatusChangedEvent as an event is quite simple because QosStatusChangedEvent is derived from Event. There's also no need to group specific properties into an eventDetail, someone who wants to ignore the detailed information will just have to cast the specialized object to an Event.

Hi @patrice-conil, We already had this discussion while commenting the PR by @akoshunyadi. Indeed this proposal as enhancement is similar to the second option I proposed. I see you commented there that both options worked for you as well. Akos chose the other one, not sure if there was a reason for that preference.
Regarding the use of eventDetail, that is indicated explictly in the guidelines in Commonalities.


Capital letters in const, remove default data in class Car

Capital letters in const, remove default data in class Car

Thanks for your help!


Migrate the project from Android 10 storage to Android 11 storage and above

Starting from Android 11, a new storage structure has been introduced citing privacy concerns. The application uses a legacy storage structure. Only try solving this issue if you have a lot of time on hand.

In this, You want that your app should store all the user files directly in the Internal Storage with a folder named StudyPartner instead of the folder inside Android->data->com.studypartner. This is the thing that we have to implement naa. I just wanted to confirm.

The application currently stores the file in the Internal Storage in a folder names StudyPartner for Android 10 devices and in Android->data->com.studypartner for Android 11 devices.
Starting from Android 11, Google changed the way filesystem access for Android works due to security concerns. The application uses a tag in the Manifest file called android:requestLegacyExternalStorage="true". It allows us to use the application with Android 11 and use the legacy storage structure. The application would stop working on any device having Android 12 and onwards. This is what we want to solve.
You can read about it further on Android Developer's Guide

Ok I got it, that means you want to upgrade your app to use Scoped Storage concept

Yeah. I know it's a difficult task. Would you be up for it?

Currently I am not that much expert in this field. But in future I will let you know.

I want to work on this issue.

How will you go about solving this issue @codeDamon?

We have to use scoped storage to make app's storage model compatible with android 11 and above.
For reference will follow this:
https://developer.android.com/about/versions/11/privacy/storage

Hello, @codeDamon I'm really sorry but this issue can't be worked on right now. I apologize for any inconvenience caused.


experimental: create builder api

See existing work at https://gov.optimism.io/t/optimism-pbs-proof-of-concept/6718

See existing work at https://gov.optimism.io/t/optimism-pbs-proof-of-concept/6718

took a look. thanks! i think the key difference is that ethereum's builder api are much less opinionated about the sequencer and minimize the scope of the changes to the codebase (they were successfully developed for and incorporated into ethereum mainnet). for example, the builder api neither enshrines a relay nor needs the sequencer set to be decentralized, unlike Nethermind's implementation.
what do you think? cc @protolambda

Closing this due to it being stale


Possible new port restrictions added?

Hi,
I have been using this code to successfully connect to an RDS instance in a private subnet. I was working on adding some extra functionality but then started to hit some errors that did not correlate with the changes I had made.
I decided to go back to trying to use the code in this repo which worked originally and found I could have the connection waiting on a port but then when trying to connect I received the following error:
Error: : dialing websocket: websocket: bad handshake

I decided to go even more basic and ran this command  -
aws ec2-instance-connect open-tunnel \
  --private-ip-address <IP-ADDRESS-WAS-HERE> \
  --instance-connect-endpoint-id "<ENDPOINT-ID-WAS-HERE>" \
  --remote-port 5432 \
  --local-port 5432 \
  --region us-west-2

I found I got this output error:
Listening for connections on port 5432.
[1] Accepted new tcp connection, opening websocket tunnel.

awscli.customizations.ec2instanceconnect.websocket - ERROR - {"ErrorCode":"InvalidParameter","Message":"The specified RemotePort is not valid. Specify either 22 or 3389 as the RemotePort and retry your request."}

AWS_ERROR_HTTP_WEBSOCKET_UPGRADE_FAILURE: Failed to upgrade HTTP connection to Websocket.

This error seems to suggest that the RemotePort options has now been restricted to 3389 (RDP) and 22 (SSH)?
Has anyone else experienced this?

Since some hours, I have the same issue. Everything worked before and when I select a database now after using rdsconn proxy command and try to connect to localhost:5432 I get the same error message.

Yep, I'm seeing this too. It seems that the service is now restricted to standard SSH and RDP ports. I assume that RDS would still work if configured to listen on port 3389 (instead of 5432) but I don't think that's a reasonable thing for me to suggest people do. I'll keep this issue open if people want to subscribe to hear about updates in the future (e.g. if AWS removes the restriction)

have you added any security group(s) to EICE when you've been creating it?

Yes and I also tried to allow all traffic but still not working.

what a shame, this is an AWS API limitation now, not a network

Amusingly - this project was included in AWS Week in Review, so at least some people at AWS like the idea of it - even if others have locked it down.

Instead of changing the DB sport is there any simple and cheap AWS service that can be used to switch port traffic before hitting the DB from the EIC?

@yevman I'm not sure it meets the "cheap" criteria, but you could use a Network Load Balancer in TCP mode. It could listen on port 3389 and forward to a target listening on a different port (e.g. your RDS instance listening on port 5432)

I faced the same issue with a different port and used two workarounds, keeping ec2-instance-connect. Both work depending on what is your setup:

aws ec2-instance-connect ssh --instance-id XXXX --local-forwarding 5432:localhost:5432 . The local-forwarding option works for other ports besides 22 and 3389.

Create a double tunnel first with ec2-instance-connect and then with ssh like this:

# You can create a new key or use an existing one
ssh-keygen -t rsa -N "" -f temporary_key
# This will create a tunnel to port 22
aws ec2-instance-connect open-tunnel --local-port 2222 --remote-port 22 --instance-id XXXXX
# This will send our key to the EC2 instance
aws ec2-instance-connect send-ssh-public-key --instance-id XXXX file://temporary_key.pub --instance-os-user YYYYY
# This will create the tunnel with the port you need
ssh -o StrictHostKeyChecking=no -i vault -p 2222 -N -L <IP_ADDRESS>:5432:localhost:5432 YYYYY@localhost

I'm using both options since AWS disabled the option to create the tunnel with other ports and didn't have any issues. The only downside is that aws ec2-instance-connect ssh and ssh will open a shell, so moving them to the background could be necessary.

@yevman I'm not sure it meets the "cheap" criteria, but you could use a Network Load Balancer in TCP mode. It could listen on port 3389 and forward to a target listening on a different port (e.g. your RDS instance listening on port 5432)

Is it possible to achieve?
I have set up the Network Load Balancer to route traffic to RDS instance, but I get the following error when I try to connect to Instance Connect Endpoint:
Encountered error with websocket: (9, 'Bad file descriptor')

@yevman I'm not sure it meets the "cheap" criteria, but you could use a Network Load Balancer in TCP mode. It could listen on port 3389 and forward to a target listening on a different port (e.g. your RDS instance listening on port 5432)

Is it possible to achieve? I tried this approach but it gives me an error
Encountered error with websocket: (9, 'Bad file descriptor')

@MStaniaszek When I got that error it was due to a SG rule. The problem with a NLB is that the target IP addresses for the RDS endpoints are subject to change. I've created a solution with a Lambda that runs every minute to check that the target group IP matches the latest result of dig but that's a pretty hacky solution and if you're using IaC you have to either let the Lambda handle creating the target group or, if using Terraform, add a lifecycle.ignore_changes to the resource so your next run doesn't try to "fix" it.
I was however able to just create a cluster running on port 3389. I wouldn't do that in production though. If they updated the ports without warning who's to say they won't do something to limit the protocol that is allowed to pass through it. It peeves me off that such a breaking change, in however short a time from initial release, wouldn't be predicated on a proper deprecation notice.
In the end I would spend the extra 5 minutes to create a nano bastion host for SSM before trying to hack around the breaking change. It's a pity though. I was excited about the service.

I guess it's back to a bastion host.
Maybe BohdanPetryshyn/basti (temp bastion host + ssm) can be used while we wait for aws to open up port 5432 again via ec2 instance connect?


First pass at Connect Events CLI

This might be my lack of familiarity with the Heroku CLI, but I wonder if heroku connect-events:streams --help should list out what the available commands are? It's unclear, currently.

I don't disagree with all the style changes you requested, but all those instances are straight up copies from the equivalent connect:* commands.

@lambacck Fair point! Don't let this be a blocker. I'm happy with either choice.

@mattrothenber maybe I messed something up about the stream sub command. This works:
heroku connect-events:stream --help
Add a stream

USAGE
  $ heroku connect-events:stream:COMMAND

DESCRIPTION
  Add a stream

COMMANDS
  connect-events:stream:add     Add a stream
  connect-events:stream:delete  Delete an existing stream
  connect-events:stream:state   return a stream state

I think I figured it out. I had streams instead of stream in the topic naming in index.js.


Address the issues with the redis API spec/examples found by new validation

PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[N/A] If applicable, the PR references the bug/issue that it fixes. - no bug for this issue yet
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
[X] The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

(note: pending agreement on whether exposing acessKeys this way is the best approach)

@vishrutshah any further changes required?

@TimLovellSmith Changes looks good to me.
@amarzavery If you have time to skim through, please skim or I can merge it by tomorrow :)

ping @amarzavery @vishrutshah Ready to take this one?

looking at this PR right now

LGTM

 https://github.com/Azure/azure-sdk-for-ruby/pull/693

 https://github.com/Azure/azure-sdk-for-node/pull/2068

 https://github.com/Azure/azure-sdk-for-python/pull/1000


Updating to 1.0.0-beta.18 issue

OS?
MacOS Seirra
I just updated my local angular-cli version from 1.0.0-beta.17 to 1.0.0-beta.18
Now its giving this error on All ng commands:
It seems like you're using a project generated using an old version of the Angular CLI.
The latest CLI now uses webpack and includes a lot of improvements, include a simpler
workflow, a faster build and smaller bundles.

To get more info, including a step-by-step guide to upgrade the CLI, follow this link:
https://github.com/angular/angular-cli/wiki/Upgrading-from-Beta.10-to-Beta.12

Anyone facing similar issues?

Are you sure you had this working with beta 17? Sounds like your project was created using beta 10 (pre-webpack). If so, you need to upgrade using the article linked.
To upgrade between recent versions you can run ng init. This will ask you to overwrite, diff or skip any changes between your project and the latest blueprints.

@grizzm0 yeah, it was working fine with beta 17. I was just waiting for the assets array implementation in beta 18 (you helped me in that thread as well :))
Yeah - my project started when it was pre-webpack versions. When i upgraded with each new update and was on 17.
I cannot run ng init because all ng commands give the error in my first comment :(

my workaround is changing the angular-cli version directly in package json and do npm i, then try ng init again

thats what i do always :) Didn't work this time though

Ok its working now.

I created a new project in another directory using ng new dummy command.
Updated/added some of the packages in the devDependency section.
Updated my angular-cli.json file and matched it with the dummy project's structure.
Copied the src/typings.d.ts file into my project.
Removed node_modules folder
npm i

Now its working as expected :)
P.S: Seems to me either there was something missing in angular-cli.json file or a devDependency such as @types/node was missing.

@hassanasad I just updgraded from beta.17 to beta.18 and I have the same issue: ng init is not working.
angular-cli: 1.0.0-beta.18
node: 6.5.0
os: win32 x64
While I appreciate your work-around from above (I will try it shortly), I don't think this issue should be closed. Quite to the contrary, it should be elevated in priority for actual resolution w/o work-around.
I have consistently been able to upgrade from beta.15 -> beta.16 -> beta.17. Minimal effort, never had an issue  with ng init. Simply loved it.
This is the first time, I encountered a problem, so there probably should be a more 'at the root' solution w/o a need for a work-around.

@tomwanzek I thought there was something wrong with only my install as no one seemed to be facing it. I will reopen it now - Probably someone more experienced can have a better look at this.

Alright, so I went back over it and it worked now (roughly as previously) I will note that, I got a message that the --link-cli option is not supported. No longer I suppose? Will have to test things out by migrating another project, when I have a minute.
So, not sure, why I did not get ng init to work the first time around. Apologies, must have just been a crazy day today...

I had the same problem, though I was able to work around it. I believe I may have caused it by two things:

I had upgraded Angular to 2.1.0.
I have been experimenting with Yarn package manager instead of npm.

My solution was reverting Angular back to 2.0.0, and exclusively using npm per the upgrade steps.
https://github.com/angular/angular-cli#updating-angular-cli

Also having this same problem when going from beta16 to beta18.
angular-cli: 1.0.0-beta.18
node: 6.2.1
os: win32 x64
None of the ng commands work, so the upgrade steps can't be followed.

Fixed by https://github.com/angular/angular-cli/pull/2870


openssl: security update (high severity)

http://openssl.org/news/secadv_20150319.txt
./cert-file.patch needed to be changed due to formatting-only stuff,
and original version was retained to support 1.0.1j.
It's a mass-rebuild, but I guess many may want this directly in master and 14.12.
BTW, Hydra doesn't evaluate, and all except darwin are idling.

Already done in 2fe351c7e31f47400d752a59ab7b1e2e89acf392.

I found it a minute too late :-)

I see your version does keep the cert-file patch for 1.0.1j, however I really don't think we should keep old versions of OpenSSL around (see https://github.com/NixOS/nixpkgs/commit/af3c4a2744bf1b9adc1c2ff56fe7f8266ddb4192).

I was a little surprised to see the vulnerable version in there, but I didn't want to step in to fix bitcoin, so I didn't want to break it at least.
Also, this update has been reclassified as "high-severity", so maybe bundling it with a full stdenv rebuild isn't ideal, but less load on Hydra is good as well.

If I read http://openssl.org/news/secadv_20150319.txt correctly, the fixes relative to 1.0.1l are actually "moderate" and "low" severity.

Ah, I see, correct. The high-severity reclassification was for CVE-2015-0204 which was fixed in 1.0.1k. I originally thought they reclassified the severity of today's fixes (and I thought "k" might be typo, silly me).


Alignment prep still not working

Hi Brad,
I was testing the new alignment prep step, where pre bgzipped fastq's should be skipped. This doesn't seem to work for me yet, grabix still hangs indefinitely during the indexing.
There also seems to be something funky going on with the filenames, example
bcbio-nextgen-debug.log:
[2017-01-27T12:36Z] System YAML configuration: /home/galaxy/bcbio-dev/galaxy/bcbio_system.yaml
[2017-01-27T12:36Z] Resource requests: bwa, sambamba, samtools; memory: 3.00, 3.00, 3.00; cores: 16, 16, 16
[2017-01-27T12:36Z] Configuring 1 jobs to run, using 5 cores each with 15.6g of memory reserved for each job
[2017-01-27T12:36Z] Timing: organize samples
[2017-01-27T12:36Z] multiprocessing: organize_samples
[2017-01-27T12:36Z] Using input YAML configuration: /home/projects/bcbio_annotation/test_runs/bcbio_dev/config/illumina.yaml
[2017-01-27T12:36Z] Checking sample YAML configuration: /home/projects/bcbio_annotation/test_runs/bcbio_dev/config/illumina.yaml
[2017-01-27T12:36Z] Testing minimum versions of installed programs
[2017-01-27T12:36Z] Timing: alignment preparation
[2017-01-27T12:36Z] multiprocessing: prep_align_inputs
[2017-01-27T12:36Z] Resource requests: ; memory: 1.00; cores: 1
[2017-01-27T12:36Z] Configuring 2 jobs to run, using 1 cores each with 1.00g of memory reserved for each job
[2017-01-27T12:36Z] Index input with grabix: GiB_GiB_R1.fastq.gz
[2017-01-27T12:36Z] Index input with grabix: GiB_GiB_R2.fastq.gz

Notice the input file has the sample name prepended twice. Is this expected behavior?
Contents of the align_prep dir:
[pbsqueue] galaxy:work $ ll align_prep                                                                                [13:42:34]
total 2.0K
lrwxrwxrwx 1 galaxy galaxy 55 Jan 27 13:36 GiB_GiB_R1.fastq.gz -> ../../../../../genome_in_a_bottle/HiSeq/GiB_R1.fastq.gz
-rw-rw-r-- 1 galaxy galaxy  2 Jan 27 13:36 GiB_GiB_R1.fastq.gz.gbi.tmp
lrwxrwxrwx 1 galaxy galaxy 55 Jan 27 13:36 GiB_GiB_R2.fastq.gz -> ../../../../../genome_in_a_bottle/HiSeq/GiB_R2.fastq.gz
-rw-rw-r-- 1 galaxy galaxy  2 Jan 27 13:36 GiB_GiB_R2.fastq.gz.gbi.tmp

Again, with the duplicate sample name.
run config:
fc_name: bcbio-dev_run
upload:
  dir: ../final
  #method: irods
  #folder: /tempZone/home/rods/bcbio
  #resource: seqArchive
globals:
  analysis_regions: /home/projects/bcbio_annotation/ref/variant_regions/RefSeq_allexons_20bp.sorted.merged.bed
resources:
  tmp:
    dir: /tmp/bcbio
details:
  - analysis: variant2
    genome_build: hg38
    description: GiB
    algorithm:
      aligner: bwa
      save_diskspace: true
      coverage_interval: regional
      mark_duplicates: true
      recalibrate: false
      realign: false
      variantcaller: gatk-haplotype
      variant_regions: analysis_regions
      effects: vep
      effects_transcripts: canonical
      tools_on:
        - vcf2db_expand
        - vep_splicesite_annotations

Just wanted to give you a heads up. I think this might have something to do with the preparation of the input file. These are fastq files that were using the bcbio_prepare_samples.py script. Could it be that merged fastq's should be handled differently? bcl2fastq outputs fastq's per lane by default, instead of per sample.
Your thoughts?
Thanks
M

related to #1760
Sorry, should've posted this there.
M

Matthias;
Sorry about the problem, there was still one more bug in grabix that we sorted out yesterday and new packages for grabix posted to bioconda about an hour ago. If you re-update tools:
bcbio_nextgen.py upgrade --tools

if should hopefully avoid hanging now. Sorry about the issue and hope it works cleanly for you now.


⚠ Text Filter API Endpoint has degraded performance

In 2cf9e69, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 9430 ms

Resolved: Text Filter API Endpoint performance has improved in 4db02c4.


feat: Adding Chakra-UI as a tailwind alternative

Is your feature request related to a problem? Please describe.
Some people would like to have a more component ready ui framework
Describe the solution you'd like to see
In the cli option it would be greate to have the choice between either tailwind or chakra
Describe alternate solutions
I have created my own template but this makes it difficult to maintain. I would not mind working on a PR for this if there was a bit of guidance on how to structure the templates and how the flow would work.
https://github.com/crimson-med/t3-chakra-template
Additional information
No response

The setup for Chakra in pages dir is an npm install and one provider added to the app. I don't think the additional maintenance cost for us is worth it. If we were to add a "batteries-included components" library, it would probably be shadcn ui.


REFACTOR-#5322: remove python3.7 related code from read_csv_glob

Signed-off-by: Myachev<EMAIL_ADDRESS>
What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #5322
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha could we merge it?


Maintain sorted list of timers

Currently the list of timers is stored as a flat, unsorted object space.
We may improve performance by maintaining an array of timers-to-be-executed, explicitly sorted according to their eventual execution order.
New timers could be inserted using a binary search insertion, turning the current O(1) operation to an O(logn) operation, but turning the execution-time cost from the current O(n)-ish to O(1).

This hasn't seen any activity in more than six months, I am closing it.
Feel free to re-open for further discussion or pull requests


⚠ Turnos 24x7 has degraded performance

In 2289214, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1773 ms

Resolved: Turnos 24x7 performance has improved in 4cac9f7.


added croatian locale, autofocus, returning localized name onTap

Hi, I added an autofocus (virtual keyboard expand) feature that I asked about a few months back. It's just an optional bool parameter.
I also added Croatian language support, and a new field in model named nameLocalized that holds localized name of a country.
There was also a weird bug that was inserted few days ago in country_list_view.dart:172 that removed all whitespaces which doesn't make any sense (??).
I just added whitespace there, so UnitedStatesofAmerica is now United States of America.
I hope you merge this request, we really need it in production. Until then, we will use 2.0.6
Thanks

Released in v2.0.8.


Can't run new instance zrok

Hi, I am trying to run the latest zrog (v0.4.32) using docker instruction
and catch panic not existing sqlite3.db
panic: error opening store: error migrating database '/var/lib/zrok-controller/sqlite3.db': error running migrations: unable to open database file: no such file or directory
I created an empty file, sqlite3.db, but my admin account was not initialized
and got error on login but environment variables passed into controller container
zrok/controller.loginHandler: error finding account<EMAIL_ADDRESS>error selecting account by email: sql: no rows in result set
ENV variables used
ZITI_HOME=/data/ziti
ZROK_DNS_ZONE=<domain>
ZROK_INSECURE_INTERFACE=<IP_ADDRESS>

<EMAIL_ADDRESS>ZROK_USER_PWD=<secret>

ZITI_PWD=<secret>
ZROK_ADMIN_TOKEN=<secret>

ZROK_FRONTEND_PORT=8058

I am investigating sources, but I am glad to get any help to find mistakes.

Restart after the first start helped create db
It was my mistake with an account because I did not know  ZROK_USER_EMAIL and ZROK_USER_PWD were used only for manual creation.


Ng7 App generate fails with "npm ERR! Maximum call stack size exceeded"

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.4
Node: 8.11.1
OS: win32 x64
Repro steps

ng new my-app
The log given by the failure

? Would you like to add Angular routing? Yes
? Which stylesheet format would you like to use?  Maximum call stack size exceeded
Desired functionality

my-app should have been created successfully.
Mention any other details that might be useful

I tried to follow previous bug-fixes by removing .npmrc file and cleaning npm-cache etc.But nothing worked. I keep getting same error every-time I try to generate a new app using the new angular-cli for 7 version.

This seems like a problem with your node/npm and not with Angular CLI.
Please have a look at the fixing npm permissions page, common errors page, npm issue tracker, or open a new issue in that issue tracker if the problem you are experiencing isn't known.

Thanks for your response.  Yes, I tried everything,
Updated the node to node: 10.13.0 --
Angular CLI: 7.0.4
Node: 10.13.0
OS: win32 x64

I deleted npm-cache directory and retried again  --  Got same error.

I changed the NODE_HOME to a different dir and updated "path" and tried again. -- Got same error

-- npm rebuild  is only on a specific project right? Since I don't have the project itself successfully created, I can't go that...
Bottom line - I can't successfully create a new angular 7 project with Node 10 or node 8.  Is there any angular 7 starter/seed project?
I have no clue at this point.  I removed the content of .npmrc, ran the generate command and it worked. After that you can restore the content of your .npmrc if needed.

why is having a .npmrc in your user home causing "Maximum call stack size exceeded" ?

I am also getting the same problem while creating a new app.Can anyone help me here how to resolve the issue

What worked for me was what someone else mentioned above, I cleaned out the contents of my global .npmrc, ran the install, it worked, put back the contents of my .npmrc and everything was normal again. For what is worth, the only things in my .npmrc were proxy settings required for my work place.


The source isn't working anymore "null" is what it says

Source information
Asura scans 1.4.34
Source language
English
Steps to reproduce
1.open the source 2.search for Amy manga 3.read or download any manga you already have in the library (not downloaded)
Expected behavior
1.should open normally and provide results for recent or top manga 2.should provide results of what you're searching for if it is there or say there's no result 3.should open or start downloading normally.
Actual behavior
1.only opens to say "no results found" and this is what happens for the 2nd point as well,
3.gives a message saying "NullPointerException: null" with this same spacing between words.
Mihon/Tachiyomi version
"0.16.5"
Android version
13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

This is literally in trouble shooting and the method of bypassing firecloud doesn't work thus is why I opened the issue,well thank you anyway.


cilium: improve 16bit ifindex probe on old kernels

Previously, HaveFibIfindex probe checked the presence of commit d1c362e1dd68 in the Linux kernel indirectly, by verifying the presence of the redirect helpers (which were merged alongside).
Since d1c362e1dd68 has been backported to older kernels - but not helpers -, this commit improves HaveFibIfindex detection by running a live probe.
Fixes: #27642
On kernels where `d1c362e1dd68` has been backported, don't store `ifindex` in the CT map

RFC
I don't think the unit is enough. I would think adding a check in integration/e2e that checks the flag is correctly detected would be a better approach than a unit (which I am not even sure is actually correct for backports as is). Please advise

You might need a
go get golang.org/x/sys/unix@latest
go mod vendor

I was discussing with Marc a bit on how this might affect downgrades.
Considering the scenario where a 1.16 Cilium would detect HAVE_FIB_IFINDEX on a fixed 5.4 kernel, create new CT entries (without filling the ifindex) ... and then we downgrade into 1.15, which doesn't detect HAVE_FIB_IFINDEX and relies on the non-existent ifindex value. We could solve this by having some compat code in 1.16 that continues to fill the ifindex (without using it in the datapath), to enable the downgrade. And then in 1.17 remove that compat code.
But Marc also made the fair point that we didn't consider this downgrade aspect when merging https://github.com/cilium/cilium/pull/27622. Which also produced such CT states, that were not safe for downgrade.

Based on my earlier work to bump the minimum kernel version we know that at least ubuntu 20.04 lts started on a 5.4 kernel. But the current version in repos is 5.10: https://packages.ubuntu.com/search?suite=focal&searchon=names&keywords=linux-image Probably this would only people that hand roll their kernels / distros and are on an old version?


Slash Command in Rodbot on discord

Setting the Command function from the default value of . to a new value of / causes errors when attempting to post as an alias.
When posting the alias will not allow spaces or capitalization.
If the command is set to \  the issue is not present.
UW LARP: Tempest Grove
Server ID:<PHONE_NUMBER>38586123
Channel ID:<PHONE_NUMBER>40990228
Members: 153
Since
2017-05-07
Escape Char

Ignore Char
none

Functionality in Discord updated. Not a Bot issue


Configure lookup paths for composes/from

I'm still wrapping my head around the standard patterns for how PostCSS plugins consume configuration, but it doesn't look like there's currently a way to pass configuration through to postcss-import to configure the root and search path(s) for composes foo from 'bar' lookups.
Is this something that it would make sense to add, or am I missing something fundamental? I'm also happy to put together a PR if you have a form factor in mind for how you might want to consume such configuration.

Hi, thank you for the feedback. You have to use paths relative to the root path right now, but I'm going to fix that soon.

@hellosmithy, @dfreeman Fixed, the new version is published

I am having s similar issue on version 0.4.0 (latest today on npm):
{ [Error: ENOENT: no such file or directory, open '/Users/tarikansari/Workspace/sane-web/src/components/GenrePicker/theme/elements/button-dark']
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/tarikansari/Workspace/sane-web/src/components/GenrePicker/theme/elements/button-dark' }

It is looking for the file next to the path of the file that includes the composes, instead of using the path option configured on postcss-import. I don't have this issue when using webpack/css-loader?modules as it used the resolves/root option of webpack to look into the correct paths for files.
How are we supposed to pass the include path to postcss-modules?

@tarikihm thank you for the feedback! Could you make a minimal reproduceable example, please?

May not time to write one until a couple days, for now here is more information: this is related to css-modules-loader-core which uses require.resolve() to resolve import
The way other tools handle this: css-loader instead used the context of Webpack (it's a loader), and postcss-import accept a path option, which is probably the approach postcss-modules should take.
A quick hacky workaround for me was to add a symlink named theme pointing to src/theme into node_modules, however that is not all, postcss-modules then fails to resolves composes which omit the .css extension, which are properly resolved by both postcss-import and css-loader.

Thank you @outpunk, you may also want to follow https://github.com/postcss/postcss/issues/240 where adding a path option to PostCSS is being discussed. This would allows you to make the new option invisible once PostCSS introduces this.

I see this is an old issue, but since still open. This plugin solved this problem for me https://www.npmjs.com/package/postcss-modules-resolve-path

Is this issue under the radar?

Need this feature.

Added in #126


Add Hook: Prevent Committing AWS Credentials

@vs4vijay this would work, one thing which we want to avoid is to reimplement something which someother library or tool does better..


Misc refactoring from airport

Refactored the wait we get the pod name and split the uyuniadm uninstall command in two.

Installation and migration have been successfully tested for podman and kubernetes. Uninstall has some annoying behavior to fix

@cbosdo what is the problem with un-install? At least with podman I have tested it and I'm using it and didn't found any issue so far

The problem happens when the install fails and both kubectl and podman are installed on the host: either uninstall picks kubectl as the connection works or it picks nothing if we check for a running container too. I'll probably add a backend parameter as on uyunictl to force the selection on one or the other for that particular case.


Unrecognised relationship name:

Hi
I've just upgraded from 0.12 to 1.0.0-alpha.1 and when attempting to retrieve a relationship
http://localhost:8000/api/v1/posts/1/user

I get the following runtime exception
"Unrecognised relationship name: "
Visiting http://localhost:8000/api/v1/posts/1 and http://localhost:8000/api/v1/posts gives me the correct json output including a list of the relationships available. However, visiting any of their urls just fails with the same exception.
Any ideas?
Here is the first part of the stack trace
CloudCreativity\LaravelJsonApi\Exceptions\RuntimeException: Unrecognised relationship name:  in file /Users/bob/Documents/Projects/my-app/backend/vendor/cloudcreativity/laravel-json-api/src/Adapter/AbstractResourceAdapter.php on line 134
Stack trace:
1. CloudCreativity\LaravelJsonApi\Exceptions\RuntimeException->() /Users/bob/Documents/Projects/my-app/backend/vendor/cloudcreativity/laravel-json-api/src/Adapter/AbstractResourceAdapter.php:134
2. CloudCreativity\LaravelJsonApi\Adapter\AbstractResourceAdapter->related() /Users/bob/Documents/Projects/my-app/backend/vendor/cloudcreativity/laravel-json-api/src/Store/Store.php:144
3. CloudCreativity\LaravelJsonApi\Store\Store->queryRelated() /Users/bob/Documents/Projects/my-app/backend/vendor/cloudcreativity/laravel-json-api/src/Http/Controllers/JsonApiController.php:166
4. CloudCreativity\LaravelJsonApi\Http\Controllers\JsonApiController->readRelatedResource() /Users/bob/Documents/Projects/my-app/backend/vendor/laravel/framework/src/Illuminate/Routing/Controller.php:54
5. call_user_func_array() /Users/bob/Documents/Projects/my-app/backend/vendor/laravel/framework/src/Illuminate/Routing/Controller.php:54

...

Have you implemented a user() method on your adapter as per this:
http://laravel-json-api.readthedocs.io/en/latest/basics/adapters/#relationships

Nope. I have now and it works.
Thanks!


pre/post Hooks have test env context

Aegir supports providing hooks to run before/after a suite of tests to run.
This is really useful for a lot of things, such as spinning up servers that the tests will leverage (like relay servers for browsers IPFS nodes to establish connections), or running a general Database for all the tests.
For certain use cases, these services are only needed when tests are running on a given environment (e.g Browser). This way, it would be nice if we could tweak in .aegir.js what to do according to the environment where the test suite is running.
For instance, a libp2p-rendezvous server uses a Database as a datastore for peer registrations. We currently have a MySQL datastore for running in a Node.js environment and a memory datastore to run in the browser. While a memory datastore should not run in production, it is useful for testing purposes. With the current support of hooks in aegir, it will start and stop a MySQL instance 3 times (Node.js, Browser, WebWorker) and it is only used in the browser. This makes the entire test suite taking a considerable longer time to run unnecessarily. Other examples are when we run relay servers for enabling browser connections but we start and stop them also when running the tests in a Node.js environment.
There are two solutions I thought about:

Inject as a parameter of the hook start/stop the environment context of the test suite { hooks: pre: (env) => {} }
Accept the hooks configured prepended by the environment: { browser: { hooks: { pre: () => {}, post: () => {} } }

@hugomrdias let me know your thoughts on this

we do support theses cases its similar to the second solution you mentioned but reversed hooks.pre.browser or hooks.pre.node. But we should improve this to support more envs and give more flexibility, your first solution seems to be the right approach here.


Error attempting to packFile with script post headless analysis: "Can't save during transaction"

attempting to run the following code in a post headless analysis script results in an error stating "Can't save during transaction
". However, when ran using the GUI it works perfectly. I attempted to release the consumers for "currentProgram" but that lead to the target domain file not being accessible. What am I missing?
public void run() throws Exception {
    	DomainFile target = currentProgram.getDomainFile();
    	File outputFile = new File("testoutput.gzf");
	target.packFile(outputFile,monitor);
    }

The GhidraScript runs in a transaction started behind the scenes so its effects can be undone.  Some API calls don't like being run in a transaction.  Try calling end(true) before you call packFile.

That will do it. Thank you.