Wrong local_rms estimation for forced fitted measurements

When we checked the candidates from the pipeline, we found some sources with exceptional measurement errors.
rms from the pipeline - For a selavy detection, we used image_rms value from the selavy output as the measurement errors; for a forced-fitting, we used the flux error returned by the function.
I assume that the value in the rmsmap (noise map) at that point is the correct rms estimation. I plot the figure to check how many sources are affected. The y axis shows the ratio of local rms (rms from pipeline) to the value in the noise map. For all selavy detections, as is expected, all ratios are around 1.0.
However, for some forced measurements, the ratios are around 2.0.

Then I downloaded forced_phot.py from vast-pipeline repo and run forced-fitting for all measurements using the following parameters.
flux, flux_err, chisq, DOF = FP.measure(
        SkyCoord(row['ra'], row['dec'], unit=u.deg),
        cluster_threshold=3.0,
        allow_nan=False,
        edge_buffer=1.2)

I compared flux_err with rms value from noise map, the ratios are around 2.0.

I also used the same code to test the tile images, and the ratios are around 2.0 too.

As Adam suggested, I tried set cluster_threshold=0, but the ratios are still around 2.0

James Leung has come across this issue is trying to estimate the goodness of fit for his GRB lightcurves. Reading the log it looks like it has been solved, but possibly not deployed? Is it possible to incorporate this update? I'm not sure what the workflow is.

@marxide could probably deploy this.

Sorry, I missed that ping.
Which run did you notice this error in @jameskleung?

@marxide this must have been in the original combined run (epoch 0 to 12) late last year or early this year - I think in the new runs in the dev environment, this issue has since been fixed, but will let you know if I find out otherwise.


Modernize cmake

Following https://github.com/KIT-MRT/arbitration_graphs/pull/68, this cleans up the CMake setup.

I'll approve this already but could also update the README?
* We now have docker stages and services inside a single docker compose file
* We  don't need the `find` command to run all tests but can use cmake and the test target
* The test output also look different but I would just remove that part

Good catch!
See a01337b


Disallowed word list missing sorry and apologize

It is crucial that this program includes sorry or apologize on the disallow word list.  If not it would lead to a catastrophic failure due to null pointer exception and out of bound errors - essentially the script would self-implode .

See a76f078


Custom Prefab

I only see how to create a prefab using models that already exist. Is there a way to create a prefab and load the mesh etc from an obj file? or a way to load in a custom asset bundle so that the prefab already exists?

Yep, you should be able to! You can load a mesh from a .obj file using this helper function, then set it on your prefab by changing it mesh on the mesh renderer component.
There's also functionality in the library for creating a prefab from an object, but it's currently set as internal so you'd have to do a bit of reflection magic to access it. We have some logic in place for the next version, v0.2.0, to make this process easier - this version should be released in around a week at most. But if you want to play around with it ahead of time, you could do something along these lines
// Here Paths.PluginPath is a variable from BepInEx
AssetBundle bundle = AssetBundle.LoadFromFile(Path.Combine(Paths.PluginPath, "TestMod/Assets/jotunnlibtest"));
GameObject testPrefab = (GameObject)bundle.LoadAsset("BundlePrefab");
ReflectionUtils.InvokePrivate(PrefabManager.Instance, "RegisterPrefab", new object[] { testPrefab, "BundlePrefab" });

I am trying to load a custom asset and I am getting this error
[Error  : Unity Log] NotImplementedException: The method or operation is not implemented.
Stack trace:
TestMod.TestMod.registerPrefabs (System.Object sender, System.EventArgs e) (at <293c3898612f4931acb497e71b96fa66>:0)
JotunnLib.Managers.PrefabManager.Load () (at <087b244f75474d8395ede17c672ab29f>:0)
JotunnLib.Patches.ZNetScenePatches+AwakePatch.Postfix () (at <087b244f75474d8395ede17c672ab29f>:0)
(wrapper dynamic-method) ZNetScene.DMDZNetScene::Awake(ZNetScene)
this is the code i am using to do it. which i added in the register prefab section
AssetBundle bundle = AssetBundle.LoadFromFile(Path.Combine(Paths.PluginPath, "test.asset"));
GameObject testPrefab = (GameObject)bundle.LoadAsset("GIRL");
ReflectionUtils.InvokePrivate(PrefabManager.Instance, "RegisterPrefab", new object[] { testPrefab, "GIRL" });
I Added this later on to load it as a createable item
ObjectManager.Instance.RegisterRecipe(new RecipeConfig()
{
// Name of the recipe (defaults to "Recipe_YourItem")
Name = "Recipe_GIRL",
            // Name of the prefab for the crafted item
            Item = "GIRL",

            // Name of the prefab for the crafting station we wish to use
            // Can set this to null or leave out if you want your recipe to be craftable in your inventory
            CraftingStation = null,

            // List of requirements to craft your item
            Requirements = new PieceRequirementConfig[]
{
                new PieceRequirementConfig()
                {
                    // Prefab name of requirement
                    Item = "Wood",

                    // Amount required
                    Amount = 2

When I load a prefab from an asset file i am not getting any errors now but when it goes to create the item I am getting this.
[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
JotunnLib.Entities.RecipeConfig.GetRecipe () (at :0)
JotunnLib.Managers.ObjectManager.RegisterRecipe (JotunnLib.Entities.RecipeConfig recipeConfig) (at :0)
TestMod.TestMod.registerObjects (System.Object sender, System.EventArgs e) (at <40b408b6634640438d3b04c0f11f1da6>:0)
JotunnLib.Managers.ObjectManager.Register () (at :0)
JotunnLib.Patches.ObjectDBPatches+AwakePatch.Postfix () (at :0)
(wrapper dynamic-method) ObjectDB.DMDObjectDB::Awake(ObjectDB)
I am using then newest jotun lib and test mod.
TestMod.zip


Plugin does not build on Atom 1.32 with OSX Mojave 10.14

Hi!
This morning, my TS file were not loading the syntax coloration. It seems like this plugin fails to build. I also got the following error message at some point :
SourceGraph language server for TypeScript unable to start

Syntax highlighting is (supposedly) handled by Atom's bundled language-typescript package. SourceGraph language server is a third-party add-on.
So... I see nothing that would indicate that Atom-TypeScript failed at any point.


remove MuhammedKalkan.OpenLens version 6.1.19

Based on the comment on this PR https://github.com/microsoft/winget-pkgs/pull/90939#issuecomment-1344306196 and bug tracked here https://github.com/microsoft/winget-cli/issues/2503, we need to remove the manifest version that contains the https://github.com/microsoft/winget-cli/issues/2503
related PR to remove 6.0.1 -> https://github.com/microsoft/winget-pkgs/pull/90944

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Trenly I have removed the version based on your comment here https://github.com/microsoft/winget-pkgs/pull/90939#issuecomment-1344306196


KeyError:"Spatial key 'spatial' not found in adata.uns."

hello,
when i use nuclues image and spatial data to deconvolute the data, there appears one error that 'spatial key' 'spatial' not found. However, we don't have this key in our data as we use stereo seq rather than visium to access spatial data. So is there any solution to this problem?

Hi,
Yes, this is a function from the squidpy library which requires the spatial data ('adata_st') to be arranged in some required structure. There are two keys needed in this function: adata_st.obsm['spatial'] and adata_st.uns['spatial']. The adata_st.obsm['spatial'] defines the location of measured spots, which is always required in order to have the features calculated at the right locations of the image.
In the error popped up in your code, it is due to the lacking keys adata_st.uns['spatial']. The function is trying to extract the diameter of the measured spots from this key. Such information is stored at:
adata_st.uns['spatial']['V1_Adult_Mouse_Brain_Coronal_Section_2']['scalefactors']['spot_diameter_fullres']
If you know the diameter of your  measured spot, you can either store this information in your spatial data (make the data structure the same as the one used in tutorial, it should be easier to do compare to changing the source code), or you can also hack into the squidpy package you installed and change the source code to directly input the spot diameter. The code requires this key is at .../squidpy/im/_container.py,  'generate_spot_crops' function at line 713~826, replace those lines with 'Key.uns.library_id' or 'Key.uns.spot_diameter' and you should be able to run the image segmentation code.
Best,
Hejin


Add docu for using the seed authorizer with the remote garden setup

How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:

Adds docu for using the SeedAuthorization feature with the remote garden setup to docs/development/local_setup.md
Adds a script for automating the process on remote garden clusters that are Gardener shoots.

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Due to the way ReversedVPN feature is implemented, shoot cluster IPs are no longer accessible by the kube-apiserver running in the seed cluster if this feature is enabled. This can perhaps be fixed in general (cc @mvladev), but is likely not worth it while the old VPN is still available. I have included a note in the documentation how to disable this feature on particular shoots.
Release note:
NONE

/invite @rfranzke @timebertt @ialidzhikov


Switch to 550 series non-grid NVIDIA driver to resolve torch and cuda issues.

From JS2 admins on torch and cuda issues:
https://discourse.slicer.org/t/pytorch-warning-error-about-torchvision/40476/7?u=muratmaga
We might want to do this with

Actually this turned into a very blocking issue. We can't run any of the deep learning models, not consistenyly at least. it is too late for the workshop, but we should update the drivers and test and if it resolves should deploy quickly.

https://github.com/MorphoCloud/MorphoCloudWorkflow/issues/63

Copied from https://github.com/MorphoCloud/MorphoCloudWorkflow/issues/63

Despite of having the driver nvidia-driver-550-server-open installed, attempting to run TotalSegmentator is not using the GPU:

Ok i will try later tonight with memos. Does torch install the cuda version?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jean-Christophe Fillion-Robin @.>
Sent: Sunday, December 15, 2024 3:55:17 PM
To: MorphoCloud/MorphoCloudWorkflow @.>
Cc: muratmaga @.>; Author @.>
Subject: Re: [MorphoCloud/MorphoCloudWorkflow] Switch to 550 series non-grid NVIDIA driver to resolve torch and cuda issues. (Issue #66)
Despite of having the driver nvidia-driver-550-server-open installed, attempting to run TotalSegmentator is not using the GPU:
image.png (view on web)https://github.com/user-attachments/assets/f44473b7-3840-42f2-b8fe-6cdacb5b14c9
—
Reply to this email directly, view it on GitHubhttps://github.com/MorphoCloud/MorphoCloudWorkflow/issues/66#issuecomment-2544002445, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCMSFDH6NZMIWHDYITK2632FXGBLAVCNFSM6AAAAABS44D5EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBUGAYDENBUGU.
You are receiving this because you authored the thread.Message ID: @.***>

Ok i will try later tonight with memos

Since the change is currently only associated with the test project, make sure to create a request from https://github.com/MorphoCloud/MorphoCloudInstancesTest
Which is now associated with the BIO240357  allocation

Does torch install the cuda version?

I am re-creating a new instance and I will report back.

re: Pytorch

re: nvidia-driver-550-server-open

Attempting to install the package confirm it is already installed ....
$ sudo apt-get install nvidia-driver-550-server-open
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
nvidia-driver-550-server-open is already the newest version (550.127.08-0ubuntu<IP_ADDRESS>).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

After inspecting the code associated with the function PyTorchUtils.nvidiaDriverVersionInformation()^1, it is calling light_the_torch._cb._detect_nvidia_driver_version() which itself calls nvidia-smi. Running the corresponding command directly on the instance allows to gain additional insight:
$ nvidia-smi --query-gpu=driver_version
Failed to initialize NVML: Driver/library version mismatch
NVML library version: 550.127

Following this suggestion^1, I ended up restarting the system. Re-running the command now completes:
$ nvidia-smi --query-gpu=driver_version --format=csv
driver_version
550.127.08

That said, PyTorchUtils reports "cpu":

To address the reboot aspect, we could look into using the reboot module provided by ansible^2. This is consistent with the approach that has been implemented in NVIDIA/ansible-role-nvidia-driver^3

Within "PyTorchUtils", after uninstalling torch, restarting Slicer, re-running the torch installation and restarting, we can see that the GPU version is now installed:

Since attempting to use the ansible reboot module is not possible because the associated playbook is executed from the instance intended to be rebooted, a different approach is being evaluated.
Instead, the reboot is being performed from the "create-instance" workflow.

I have started a brand new instance on the Test site. Pytorch was not isntalled. I have installed as part of memos, and everything worked fine. So it looks good to me.
It is important not to run the SLicer via the launcher (or rather vglrun command), since that breaks the torch is a separate issue. But I think you can merge these now.


No training configuration found in save file: the model was not compiled. Compile it manually.

I am trying to run a sample code that is on the repo's README.md file. I tried to run predict.py, deepforest.py, retinet_keras.py but all of them output nothing.

However, if I try to run this sample code:
import matplotlib.pyplot as plt
from deepforest import deepforest
from deepforest import get_data

test_model = deepforest.deepforest()
test_model.use_release()

#predict image
image_path = get_data("OSBS_029.tif")
image = test_model.predict_image(image_path = image_path)

#Show image, matplotlib expects RGB channel order, but keras-retinanet predicts in BGR
plt.imshow(image[...,::-1])

I get errors saying "No training configuration found in save file: the model was *not* compiled. Compile it manually." or "No model initialized, either train or load an existing retinanet model"

I have cloned my keras-retinanet inside my DeepForest repo, is this file structure correct?

To install, see README, please run
conda env create --file=environment.yml
conda activate DeepForest
python

and paste the results
import deepforest
deepforest.version

You do not need to do anything with retinanet, it should install automatically, I'm guessing you cloned it separately, so there are now two copies? The error you mentioned is not from DeepForest, but from keras-retinanet. It is not a fatal error, just a warning and what appears to be actually happening is that you do not have a function tensorflow version, your memory runs out at the end.

Confirm you have a functioning tensorflow version.

Please run and paste here.
http://keras.io/examples/mnist_cnn/

To install, see README, please run
conda env create --file=environment.yml
conda activate DeepForest
python

and paste the results
import deepforest
deepforest.__version__

You do not need to do anything with retinanet, it should install automatically, I'm guessing you cloned it separately, so there are now two copies? The error you mentioned is not from DeepForest, but from keras-retinanet. It is not a fatal error, just a warning and what appears to be actually happening is that you do not have a function tensorflow version, your memory runs out at the end.
Confirm you have a functioning tensorflow version.
Please run and paste here.
http://keras.io/examples/mnist_cnn/

The deepforest version I'm using is 0.2.3.
When I ran conda env create --file=environment.yml, it didn't install keras-retinanet, tensorflow and fave me a no module found error. That's why I installed keras separately inside the deepforest folder.
Regarding tensorflow and keras, I am using 1.14.0 for tensorflow and 2.3.0 for keras. Here is the output from the link.

Great. Please paste output of conda build.
On Thu, Dec 5, 2019 at 12:19 AM Nabeel Hussain<EMAIL_ADDRESS>wrote:

To install, see README, please run
conda env create --file=environment.yml
conda activate DeepForest
python
and paste the results
import deepforest
deepforest.version
You do not need to do anything with retinanet, it should install
automatically, I'm guessing you cloned it separately, so there are now two
copies? The error you mentioned is not from DeepForest, but from
keras-retinanet. It is not a fatal error, just a warning and what appears
to be actually happening is that you do not have a function tensorflow
version, your memory runs out at the end.
Confirm you have a functioning tensorflow version.
Please run and paste here.
http://keras.io/examples/mnist_cnn/
The deepforest version I'm using is 0.2.3.
When I ran conda env create --file=environment.yml, it didn't install
keras-retinanet, tensorflow and fave me a no module found error. That's why
I installed keras separately inside the deepforest folder.
Regarding tensorflow and keras, I am using 1.14.0 for tensorflow and 2.3.0
for keras. Here is the output from the link.
[image: Screenshot from 2019-12-05 14-14-18]
https://user-images.githubusercontent.com/16258518/70216656-47501d80-1740-11ea-8b54-e8cfab00603d.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/weecology/DeepForest/issues/35?email_source=notifications&email_token=AAJHBLCECAULI4GCBSAIQT3QXC2RDA5CNFSM4JVEU5IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF74LSI#issuecomment-562021833,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJHBLGIEM2YFDRBK5TS4ZLQXC2RDANCNFSM4JVEU5IA
.

--
Ben Weinstein, Ph.D.
Postdoctoral Fellow
University of Florida
http://benweinstein.weebly.com/

Oh and definitely delete and re-clone the repo. See you read me for Shallow
clone.
On Thu, Dec 5, 2019 at 6:33 AM Ben Weinstein<EMAIL_ADDRESS>wrote:

Great. Please paste output of conda build.
On Thu, Dec 5, 2019 at 12:19 AM Nabeel Hussain<EMAIL_ADDRESS>wrote:

To install, see README, please run
conda env create --file=environment.yml
conda activate DeepForest
python
and paste the results
import deepforest
deepforest.version
You do not need to do anything with retinanet, it should install
automatically, I'm guessing you cloned it separately, so there are now
two
copies? The error you mentioned is not from DeepForest, but from
keras-retinanet. It is not a fatal error, just a warning and what appears
to be actually happening is that you do not have a function tensorflow
version, your memory runs out at the end.
Confirm you have a functioning tensorflow version.
Please run and paste here.
http://keras.io/examples/mnist_cnn/
The deepforest version I'm using is 0.2.3.
When I ran conda env create --file=environment.yml, it didn't install
keras-retinanet, tensorflow and fave me a no module found error. That's
why
I installed keras separately inside the deepforest folder.
Regarding tensorflow and keras, I am using 1.14.0 for tensorflow and
2.3.0
for keras. Here is the output from the link.
[image: Screenshot from 2019-12-05 14-14-18]
<
https://user-images.githubusercontent.com/16258518/70216656-47501d80-1740-11ea-8b54-e8cfab00603d.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/weecology/DeepForest/issues/35?email_source=notifications&email_token=AAJHBLCECAULI4GCBSAIQT3QXC2RDA5CNFSM4JVEU5IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF74LSI#issuecomment-562021833
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAJHBLGIEM2YFDRBK5TS4ZLQXC2RDANCNFSM4JVEU5IA
.

--
Ben Weinstein, Ph.D.
Postdoctoral Fellow
University of Florida
http://benweinstein.weebly.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/weecology/DeepForest/issues/35?email_source=notifications&email_token=AAJHBLFJ4SMFJ7DLAVO5WMTQXEGNDA5CNFSM4JVEU5IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGA4ZEI#issuecomment-562154641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJHBLDA6SVNAS4U2RBIDDTQXEGNDANCNFSM4JVEU5IA
.

--
Ben Weinstein, Ph.D.
Postdoctoral Fellow
University of Florida
http://benweinstein.weebly.com/

Hi!
I first trained the model by following this link: https://deepforest.readthedocs.io/en/latest/getting_started.html
Then I ran the predict code for single image but I get "No model initialized, either train or load an existing retinanet model". I successfully trained with Epoch 1 and I have NEON.h5 in data folder. I am using deepforest 0.2.5, TF 1.14 and Keras 2.3.0. I didn't clone keras retinanet separately, just used environments.yml when creating conda env.

Okay, I managed to make it run on my dataset. But I have a question. Why does boxes.head() only generates 4 rows?
I tried to plot it via plt.imshow(). But I got this error. I even have pandas installed (0.25.3)

Couple things.
No model initialized, either train or load an existing retinanet model

isn't an error, its just the message from loading a new, blank, deepforest object. Perhaps I need a better message?
pandas head just shows the first few rows. Sorry, can't help with local installs of other packages, no way for me to know what's wrong. Closing, open a new target issue if there are DeepForest concerns.

So just to be clear, No model initialized, either train or load an existing retinanet model
will always load a new, blank, deepforest object? I have trained the model and the weights are stored in data/ folder (NEON.h5) then why does it show no model initialized?
Can you at least guide me how to plot the image using plt.imshow()? Your help would be highly appreciated.


Tests should not depend on RandomGeneratorImpl() but instead a PRNG variant

For better test failure reproducibility, tests should use a PRNG with known seed, which we log at test startup.
When we run in CI and as part of continuous testing, we will see failures in tests that have random number generation. Some of these failure will be due to the specific random numbers. To be able to repeat, we need to know the exact random sequence that was generated. Hence, having PRNG and a seed that is fed in to the test harness  is the way to go. There should be logged and be able to be supplied via the command-line with --test_arg.
We should be able to just use the gtest seed, https://github.com/google/googletest/issues/331.
There should be a method TestEnvironment::randomGenerator() that returns a RandomGenerator reference with this PRNG.

This may be overkill, we already have MockRandomGenerator.


Instantiate float

Right now we only instantiate vector with ScalarType=double . We should also instantiate ScalarType=float.

The only hardcoded requirement for double is through Arpack right now. Other than that, it should work. But because of Arpack, we'll need to separate value_type in MeshEvaluator in two.


Can't link a Gitlab account

Attempting to link a free Gitlab account produces this error in the console (in Chrome 71):

Access to XMLHttpRequest at 'https://www.gitlab.com/api/v4/user' from origin 'https://stackedit.io' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: Redirect is not allowed for a preflight request.

The solution is to ensure that the "Gitlab URL" points to "https://gitlab.com/", rather than "https://www.gitlab.com/" (when using their regular service.)


possible to only re-download when the download link changes

Is it possible to set up the download task so that if the file will be downloaded only when it doesn't exist locally or when the src url has changed?
I'd like to avoid re-downloading every time I build, but I want to be sure that when the version of the file we need changes, that it will be updated.  overwrite false doesn't seem to behave this way, and neither does onlyIfNewer.

In fact onlyIfNewer is supposed to be the property that should work in your case. It depends, however, on the server returning a correct Last-Modified HTTP header. I don't know if you have access to the HTTP server and can change its behavior?
If the only indication that the file has changed is the src URL then - I'm afraid - you have to implement the logic yourself. This should be quite easy though since Gradle allows arbitrary Groovy code to be combined with the Download task. Have a look at my latest blog post to get an impression how this could work:
http://www.michel-kraemer.com/recipes-for-gradle-download
Let me know if this helps!
Cheers,
Michel

Hi Michel,
If I use onlyIfNewer it seems to decide somewhat randomly random if it should download it or not.  I assume the sever is returning the current time, or something like that, causing it to go wonky.
Thanks for pointing out your blog post. Would you be interested in a pull request to add a onlyIfSrcChanged option?
Thanks for the plugin and the reply!
Louis

Thanks for pointing out your blog post. Would you be interested in a pull request to add a onlyIfSrcChanged option?

Thanks for offering to create a pull request, but I don't see a general use case yet. I have never heard of someone requiring such a feature, but you might prove me wrong :-) Let me know if you think this feature can be of use for anyone else, and if so, how and under what circumstances. Thanks.

Closing this issue due to inactivity.

Sorry to not get back to you!  It didn't sound like there would be general demand for it, and I just ended up working around it locally.


module directories installed/created by action aren't visible to later step

I switched to using py-actions/py-dependency-install@v4 and now a zip command I run in a later step doesn't "see" the modules installed by pip.
EDIT: I see where they're being installed, but it's not ideal if you're then zipping them up to deploy to an AWS Lambda function.

Do you have a suggestion for how to modify the installation to work in your use case?  Can we add a configuration definition to better support you here?

I tried to use this action, but ended up using the official actions/setup-python instead, followed by steps that simply install the prerequisites.
This has worked for me, and also avoids needing hacks otherwise needed for MacOS builds.
good luck!


Can you add support to the Petey application?

Hey,
There is an iOS application that is called petey that handles all the API key for GPT and make it more GUI friendly.
It supports siri shortcuts as well, Can we have a version of chatgpt-siri for Petey?
https://apps.apple.com/us/app/petey-ai-assistant/id6446047813

#109 solves this issue


Activation message sent to subreddit mods

Send some info when the bot is activated in a subreddit

This is more likely to be less than useful since I'll usually talk to the mods before activating the bot.


Fixed content change log regression

The previous state of the for loop for this changelog template looked like this:
   {% for change in changes %}

{{ change.title }}

       {% for point in change.log_to_bullets %}

{{point}}

       {% endfor %}

   {% endfor %}

The HTML and content generated looked like this:

Content Changes

Cras hendrerit sit amet nulla sit amet bland

it. Interdum et malesuada fames ac ante ipsum primis in faucibus. Integer leo quam, lacinia vitae to

rtor in, semper laoreet purus. In vestibulum, nunc quis rutrum scelerisque, massa felis hendrerit

 metus, vitae pulvinar erat metus at massa. Sed auctor vel eros sed rhoncus. Duis mattis nunc augue, sit amet commodo metus laoreet vel. Vestibu

lum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia curae; Morbi eu ex id dolor pharetr

a lobortis. Curabitur sit amet purus quis felis ultrices ultricies et eu lectus. Aenean consectetur sollicitudin diam vel molestie.

Notice the unordered list and each list item?
It parsed like this:

The above is how it should look.
However your Jinja for loop parses the list in paragraph tags, causing only a single bullet point to appear at the top:

This needs to be corrected so that Jinja actually automatically builds an unordered list (like it did before).
This problem (regression) involving content change log output is also present at this location:  https://<IP_ADDRESS>:8000/article/all_content_dump/
To summarize, you need to use Jinja to build the unordered list properly for both places where Django serves the content changelog:

https://<IP_ADDRESS>:8000/article/all_content_dump/
https://<IP_ADDRESS>:8000/article/content_changelog/

I found the official Django doc for builtins which covers the linebreaks keyword you used but there is no similar builtin for generating unordered lists. So we will have to find some other way of building unordered lists as summarized above without using a builtin.


Add support for custom websocket servlet factory

@tipsy #472
I've added the setter as I think you had in mind. Haven't really written Java/Kotlin at all before so let me know if you'd like this done differently.
The .initialize call got quite long with the extra variable, so I multi-lined it. Happy to revert that if you prefer.
As far as the test is concerned, I let me know if you have any suggestions on how it was implemented. I tend to lean on mocking libraries pretty heavily so I'm somewhat lost without them :) I put it in the TestWebsocket file in order to have access to the util types in it.

Looks great @rcornell.
Javadoc should say something like Configure the WebSocketServletFactory of the instance instead of Configure instance to use a custom jetty WebSocket servlet.

Looks great @rcornell.
Javadoc should say something like Configure the WebSocketServletFactory of the instance instead of Configure instance to use a custom jetty WebSocket servlet.

Updated.

Perfect @rcornell. Thank you!

Released as part of 2.7.0 now: https://javalin.io/news/2019/03/02/javalin-2.7.0-released.html


build: Added annotation in CMakeLists.txt @open sesame 03/19 08:19

This commit is trivial. It is to append annotation in the CMakeLists.txt
Signed-by-off: Geunsik Lim<EMAIL_ADDRESS>
[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/484-201903190819300.43793511390686-70e48cd0d5a00c6f13cfdf98b7605b2710188ed7/report/misspelling_result.txt.

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

:octocat: cibot: @nnsuite, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnsuite/TAOS-CI/wiki/.

This commit is to just test the CI facilities.


Add "only change lines" to inspections quick fixes

Add the option for each one individually.
It should have the same mechanism than #34.

WNF

Can this be reconsidered? The inclusions/exclusions is going to help me get by for a while, but ultimately I will have to stop using the plugin altogether without a feature like this. The inspections end up being far too disruptive for my team's code review process.

Sure! I'm reopening.
I'll be honest thought this is a big development and it's not priority since it's very specific (lot's of bugs to correct before that). I'm not seing this done anytime soon without help from a PR.

+1 on the enhancement.. The Eclipse "Save Actions" already supports this.
Below is why this would be a big enhancement for my use case:
I often keep manual formatting to enhance readability and uncluttering (like adding newlines where the auto-formatter wouldn't). Right now, I have to worry about the plugin undoing my uncommitted formatting changes. So, I have to either untick the "Reformat file" option in the plugin or commit my changes to git before continuing. This limits the use of the plugin for me. So, if the plugin could diff with the last saved state of the file (rather than the last git committed version of the file) before formatting, it would be great.
Thanks for the effort, dubreuia.

Hello @aalosious, I'm not sure this plugin fits your use case: you either have a formatter that fits your usage and save-actions applies it automatically, or you don't use auto-something at all and do everything by hand.
For some files you might want to temporarily stop auto-formatting (like: "don't reformat this file on next save") and that development is in #59

Moved to "ideas"


Add support for additional search providers

Augment search feature by allowing support for different search providers, similar to what was done with commenting.

[ ] GitHub Pages compatible search (Lunr.js default)
[ ] Algolia, powered by jekyll-algolia plugin
[ ] Other

Would you also be interested in multiple language support for searching ?

Not sure I follow what you mean by multiple language support @nickgarlis. Could you expand on it some?

@mmistakes I am not sure about Algolia but Lunr does not support any other languages other than English by default. Non English users might be interested in searching in their native language. My solution to this was to use a different .js file for the extra language that I wanted to support where I registered a new stemmer.

Ah ok. Yeah I dunno. If it can be done in a way to not over complicate setup. In my experience it can be tricky handling multiple languages with a theme because Jekyll core isn’t really all that friendly to it.
Last thing I want to do is open a can of worms that can’t be supported well.

@nickgarlis Possible solution would be leverage site.locale set in _config.yml. This could be used to determine what language .js to load. Since locale can be language and locale (eg. en-US) doing something like this would normalize it to just the language.
{% assign lang = site.locale | slice: 0,2 | default: "en" %}

Then you could load the appropriate .js and if one doesn't exist for the given locale default to English.
<script src="{{ '/assets/js/lunr-{{ lang }}.js' | absolute_url }}"></script>

That's exactly how I was thinking of doing it !

For what it's worth, Algolia is language agnostic :)
Is there anything I could do to help you integrate jekyll-algolia?

@pixelastic It's on my todo list. I just need to lay the ground work for it in the theme.

Has a pull-request #1531

First thanks for the great theme @mmistakes, very useful. Should we keep this request open since google CSE is still not supported or should we open a new one to keep track of it? We were also looking to support google CSE and came upon this issue.

@user414 Open a new issue so it can be tracked, if and when I get around to it.


Warning type MIME (“text/plain”)

Hello
The following warning appears when referencing a js file
The script “http://localhost/_minify/js/layouts/events.js” was loaded even though its type MIME (“text/plain”) is not a valid JavaScript MIME type.
Thank you for your support

$mime = preg_match("/.js$/", $file)?"application/javascript": mime_content_type($path);

Thank you for reporting this issue

Fixed on newer version. Please let me know if any issue happens. Thank you.


Can't find the ID needed as a parameter

There is nothing that references the ID {internalDomainFederationId} on this page, where to find it, what is it ?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: eec10160-db1c-855e-2dcb-2f777e3fdd01
Version Independent ID: d6247e49-f233-2455-8c8a-34cc3c597390
Content: Get internalDomainFederation - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/internaldomainfederation-get.md
Product: identity-and-sign-in
Technology: microsoft-graph
GitHub Login: @rahul-nagraj
Microsoft Alias: MSGraphDocsVteam

Thank you @RomainBitard for raising this issue. When you Create federationConfiguration, you get the ID back and that's the one you use for the GET, UPDATE, and DELETE operations. However, I see there's no LIST operation which would have been the easiest way to retrieve the ID of the object you want to manage. @rahul-nagraj - Isn't the LIST operation supported by this API?

Thanks for the reply @FaithOmbongi I wasn't sure if it was the same ID (I was planning to test it though :D).
I posted this issue because I didn't see a list operation too, and no mention of the ID in the documentation !
Thanks again for clarifying !

Hey @RomainBitard ,
Thanks for sharing this. This is correct. A get operation on  /domains/{domainsId}/federationConfiguration/ will get you all the internalDomainFederationIds. We have a work item to update the docs. It will be updated shortly.
Thank you again for bringing this to our notice.
Regards,
Rahul Nagraj

Great. Thanks, @RomainBitard, @rahul-nagraj for confirming that the LIST operation (GET /domains/{domainsId}/federationConfiguration) is supported. We'll close this issue once the doc is live.

To add to this discussion, both I and one of our customers were not able to use the suggested list query to retrieve a list of federation configurations. We received the error message:
{
"error": {
"code": "Request_ResourceNotFound",
"message": "Resource 'federationConfiguration' does not exist or one of its queried reference-property objects are not present.",
"innerError": {
"date": "2023-10-05T18:53:47",
"request-id": "7e657ecc-81a2-4885-8d98-f8984705f4c7",
"client-request-id": "7c6db929-9e82-c4f7-851c-cd2869ab1d38"
}
}
}
{
"error": {
"code": "Request_ResourceNotFound",
"message": "Resource 'federationConfiguration' does not exist or one of its queried reference-property objects are not present.",
"innerError": {
"date": "2023-10-05T17:07:26",
"request-id": "ad436199-8cff-4514-9692-a30ec7b3df59",
"client-request-id": "aab3ff22-dd63-5257-3aaa-a7004593c070"
}
}
}
@rahul-nagraj is the list API to no longer be supported?

@rahul-nagraj - I've repro'd the same behavior. I didn't confirm whether the LIST operation was supported before, but it isn't supported now.

@mbukovich - Unfortunately, this forum is only for documentation-related issues but Microsoft Graph Q&A is the best forum to investigate, resolve, and answer this functionality question. I recommend that you file your question there. Please share the same payloads you've shared as they contain the request ID that will be helpful for investigations.

@FaithOmbongi
Thanks for the feedback! It turns out the Customer was able to use the list query after properly setting up a federationConfiguration. It seems that if there are no federationConfigurations available the query fails, but if there are, then a list will be returned.
The reason I felt it was relevant to discuss in a docs issue is that it is related to whether or not the list query is supported (which will need to be documented).

Thank you for the feedback @mbukovich. As for your comment about the API behavior when no configuration exists:

It seems that if there are no federationConfigurations available the query fails, but if there are, then a list will be returned.

Can you confirm whether the error is a 404 Not Found or was it a 400 Bad Request error?
cc @rahul-nagraj to document the LIST API.

The error code was 404

The error code was 404

Ah, OK. I think 404 Not Found is acceptable if an object is missing. @rahul-nagraj , please advise if this error code might cause confusion for a LIST operation, as opposed to 200 OK with an empty response body?
Regardless, we'll be sure to add this error code in the LIST doc in case the API keeps returning the error code. Thanks @mbukovich.

More than happy to help and contribute where I can, and I enjoy participating in these discussions!
My own personal feedback is that most LIST queries I have worked with in Microsoft Graph will return a 200 OK with an empty response body (or at least empty "value" array). I personally believe that the most consistent and least confusing behavior would be a 200 with empty response body or "value" property.

The LIST internalDomainFederations doc is now live. Closing this issue and marking it as resolved.

Thanks for the update @FaithOmbongi.
And yes I can confirm that 404 Not Found is returned if there is not Federation Configuration on the tenant.


Issue 154: migration to drop provider_locations.eligibility

This PR migrates provider_locations to drop the eligibility column and removes it from server/src/db.ts per #154

Thanks folks, merging now.


Allow comma-separated chans in server userlist JOIN

Hi,
I guess some clients want to send multi-channel JOINs as foo,bar,baz, which I couldn't get the test server to accept. Sorry if I'm wrong and this PR is just nonsense.
Thanks!
P.S. I sent you an email about this last summer (apologies if that was annoying; I wasn't allowed to use GitHub back then).

Hi, no worries. I tend to not reply to emails... sorry :)
Thanks for the patch but notice that the irc3d server is more a POC / testing tools than a real server suitable for production.


Update to RoslynDev 2.6.0-* packages

Packages are available on the release feed, you can merge this PR


Data model related documentation is outdated/incomplete

While trying to obtain more detailed information on some of the most recently added tables in WSO2's IS data model, I couldn't find references to them on our current docs.
Moreover, it looks like all of the sections describing IS's DB schema are outdated. One example of this can be seen on [1], as there is no reference to IDN_AUTH_USER table.
In my opinion, these documents should be integrally checked for inconsistencies against the respective IS schema for each IS product version and corrected accordingly.
The docs of reference are [1], [2], [3], [4] and [5].
[1] - https://is.docs.wso2.com/en/latest/administer/identity-related-tables/#identity-related-tables+
[2] - https://is.docs.wso2.com/en/latest/administer/service-provider-related-tables/
[3] - https://is.docs.wso2.com/en/latest/administer/registry-related-tables/
[4] - https://is.docs.wso2.com/en/latest/administer/user-management-related-tables/
[5] - https://is.docs.wso2.com/en/latest/administer/identity-provider-related-tables/

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Card overlays

Currently cards can't have overlays, which this PR implements, however a few questions remain:

All the children have their own wrapper layout, I'm sure there's a reason for it. This means the overlay method must be called for the first child within the wrapper (the actual child layout), otherwise only the first one will be rendered (eg. Row [ PickList (this only), PickList, PickList ]). This requires either an unwrap or some kind of logic, which is, even if it's just a line, may not be necessary. Could this be a valid reason to remove the wrappers and use the child layouts direcly?
is there a point to have overlays for the header or the footer? In my opinion only allowing the body to have overlays could be sensible, however I do have some use cases from the past where I had to use dropdown menus in the footer

OK that can be in another PR later as its not really super important. this can be the current fix at least.


update syncthingtray to v1.3.1-1

update syncthingtray to v1.3.1-1

Closes #9995

Relates to #XXXX

[x] I have read the Contributing Guide.

The executable file actually not changed, so SHA-256 stay the same (I have verify it). Just update the link.

/verify


How to distinguish the versions?

How do you pull the 1.0 code?
Which branch is version 2.0?

@cicna
We've released version 1.0
You can also check rel-1.0 branch that is published at the moment.
We'll be more careful about tagging and branching.
Closing the issue. Feel free to re-open if you have the same issue, or create a new one if you have other questions.
Thank you.


[Code blocks]: Consolidate issues

This issue consolidates reference to issues and PRs related to code blocks. Issues will be closed, PRs will be left open, if no merge conflicts exist. See #956

Josh, this means that all of these issues are still valid and unresolved, even though they are marked as "closed". Right?

Pretty much. Given the issues span 5+ years I figured this was a good way to put them in one place to maybe put a checklist together to say, "We have tests in the current codebase that demonstrate this is no longer a problem." (I think the community was getting overwhelmed by the sheer number of open issues and maybe not knowing where to begin to contribute back.)
So, if you're looking to contribute, it might be pretty simple. If there's no test to measure the validity - then, it's not resolved - so, it may be as simple as writing a test, verifying it passes, then submitting the PR. If there's a test already - then we can remove it from the reference list.
Hope that makes sense.

@mercmobily: Shorter version. I don't know if they're resolved or not. Kinda hoping the community will help out on that score. One or two people can't do all the heavy lifting...as has been evidenced. So, I'm taking a somewhat different tack with things. :)

I'm not sure if this is helpful (and I'd be happy to delete the comment if not), but here's a base case of how marked differs from most implementations:
https://johnmacfarlane.net/babelmark2/?text=
Test<%2Fh1>
++++++++++++
Should+this+code+be+in+a+pre+block%3F<%2Fp>
This has bit me a couple times and I couldn't find specific settings that would resolve it (and though babelmark is testing against 0.2.6 I'm seeing the same behavior on 0.3.9.)


Full implementation of SDS011 spec

This is large one, but fully implements the SDS011 spec from here: https://cdn.sparkfun.com/assets/parts/1/2/2/7/5/Laser_Dust_Sensor_Control_Protocol_V1.3.pdf
Since we can now sleep/wake the device natively, it removes the dependency on uhubctl.
I think ideally, we'll move this into its own package at some point.  I tried to separate it out into its own module with that intention.
I'm planning on adding tests before I merge this PR, but would be great to get your feedback on it even in this somewhat early state @inactivist.

Ill try to elucidate some of the goals and challenges here.
I wanted to try and do a full implementation of the device spec; prior implementation was a bit hacked together, and one of the nice features of the device is the ability to turn it off and on natively, which can extend the overall life of the device, and generally is nice to avoid the constant, low-volume buzz it would emit otherwise.  Before having this functionality available, I was relying on uhubctl to turn off the entire USB port, which is a bit of a sledgehammer for the use case, and also pulled in an external system dependency that was harder to manage.
The PR here implements the full spec, since after finding it I also discovered some other potential nice-to-haves, and it was relatively short to implement.  Immediately though, this allows us to remove the ugly dependency of uhubctl and instead do everything directly on the device.
In trying to implement the spec, there were a few challenges however.  One particular problem is that it can operate in two reporting modes, either ACTIVE or QUERYING.
In ACTIVE mode, (which is the factory default) the device basically just writes out the diode readings to its buffer semi-continuously, so that no matter what you ask back from the device, it would theoretically give you back air quality readings.  As an example if I did something like:
sensor.get_sleep_state()

In ACTIVE mode, the device would instead report back air quality readings, instead of the sleep state like I asked.  This in itself is actually fine.  I think the intent of ACTIVE mode is that most users don't care to do these more complex things, they just want the darn air quality, without even having to ask for it.
Where ACTIVE mode gets tricky is that it only updates the output semi frequently, which means that if you time it right, calling sensor.get_sleep_state() in ACTIVE mode, might actually return the right thing instead of the air quality reading.  I'm guessing a bit, but I think this is because to get sleep state is actually a request we send to the device.  The order of operations is something like:

client tells device to write sleep state to output buffer
device writes sleep state to output buffer
2.5 device may write air quality readings to the output buffer
client reads the output buffer

So its a bit of a race condition, leading to very inconsistent results when trying to issue commands in active mode.
QUERYING mode is much more predictable.  The device doesn't do anything unless you ask, even write air quality back.  In querying mode you have to do something like:

client tells device to write airt quality to output buffer
device writes air quality readings to output buffer
client reads the air quality readings to the output buffer

Which is much simpler, as you can imagine.
The hard part, which is entirely self-imposed, is that I wanted to try and implement the spec in an unopinionated way, such that others could leverage it, even though for our use case, QUERYING mode is the way to go.  But, designing a sensible, well-typed, API around these two modes is kind of hard, and so for now I've opted to "support" active mode, but often the API will throw exceptions when using it that are up to the user to handle.
My latest thinking is to leave the implementation I have as it is, so that others have this janky, but unopinionated path open to them, but then to also write two classes on top of this that are opinionated about the mode, and handle the complexity of the jankiness of the underlying API.
Long winded essay, but figured I'd share my thoughts.


feat: allow plugin to pass variable to mermaid

This change allows to pass a mermaid configuration through the plugin. I need this change to set darkMode option in mermaid

This is useful, thanks.

v1.0.0 published 🎉


Avoid shell escapes in non-interactive sessions

Fixes #214.

Started getting:

base16-builder/output/shell//base16-default.dark.sh: 47: base16-builder/output/shell//base16-default.dark.sh: [[: not found
After exiting vim. Problem is, from what I understand, that the script is being executed using sh (instead of bash) which does not support [[


WIP: fix(puppet): remove disable-gpu flag

The current flags we have turned on for GPU are disabling gpu and gpu compositing on Macs, Windows and Linux. I think we originally turned the flags on this way to that a docker/machine with no gpu would run the same way as a development machine. The problem is some sites (like https://github.com) with a lot of webgl are incredibly slow when you do that.
I'm proposing (not 100% sure on this) that we should NOT disable gpu by default. NOTE that disable gpu was a workaround for old chromium issues that made gpu not work in headless on win/mac/linux even when there was hardware present (https://crbug.com/737678 and https://crbug.com/729961). Those are resolved at this point, so it's really just about working with no gpu.
There's also a potential issue with Linux headless using acceleration (https://github.com/chromium/chromium/commit/19671359ae25aa1e30bde90f8ff92453eeaac2ba). I am torn on if we should use this setting on linux, or just allow this to be added on by users if needed. You can add flags by running
Chrome83.engine.extraLaunchArgs.push('--use-gl=egl').
NOTE that Puppeteer and Playwright have both removed disable-gpu and use-gl flags at this point.
@calebjclark any thoughts? Should we add a condition to add use-gl=egl to linux? My only concern is it appears to disable using a software solution and force a hardware one, so it potentially creates new issues on machines without gpus.

I do primarily run secret-agent on gpu-less linux cloud instances, so I hope you continue to allow some type of config to let that work.

Looks like the windows tests failed, but linux was fine in the github actions. It looks like chrome was unable to open new tabs on Windows.  I'm guessing there's no gpu on these test boxes..
I need to check "which" version of chrome should have fixed the need for disable-gpu on windows.

I have a TODO: to test out the gpu/disable-gpu flags on a headless/gpu-less amazon box.
One possible way to approach this is to add bootup parameters to core - something like disableGpu as a Core.start param.
Another is we could have more generic chrome args that can be passed into Core.start.

It does NOT appear to be straightforward to checking if a gpu exists in nodejs, but I think we could likely have no disable-gpu by default, and "if" the first page on a browser fails to launch, we could check if Chrome logs an error about not being able to locate the gpu module. If we see that, we could re-launch Chrome with disable-gpu. This, combined with the ability to pass in a parameter to disable-gpu might be the right combo for this.

That sounds like it could work. I'm just starting to play with using this in Docker, so in that case I'd just like to have a way to pass in a parameter when it starts.

I've tested now on all 3 platforms headless, mac headed, and docker. These configurations seem to work well, but in case they don't, we have an SA_DISABLE_GPU flag that can now be enabled to turn off ALL rasterization and gpu work (ie, don't even run the gpu thread).


Implement base HTML Email for govDelivery

AC

[x] Renders correct design after govDelivery transformation
[x] Renders correct VA logo after govDelivery transformation
[x] Renders correct plain text after govDelivery transformation
[x] Renders correct Email HTML after govDelivery transformation
[x] Renders correct Email HTML without webfonts after govDelivery transformation
[ ] Renders correct Email in small screen size (mobile, tablet) after govDelivery transformation
[x] Renders correct Email no images after govDelivery transformation
[x] Renders include alt text for all the images, current design has VA logo

Notes:

In kickoff - we need to discuss webfonts - do we need to have the fonts recommended by VA Design system, or should we be lightweight as this is an email (will be explored in a separate spike)
Testing design and accessibility with clients and browsers. Working on access to a tool that is used at the VA or work with procurement
In kickoff - we must validate the approach for where and how images must be stored for use with VANotify. if a separate story is needed or done as part of this story
We will focus on only 1 Global branding with VA Logo (1. Global branding with VA Logo, 2. Your branding, 3. Global branding on top, your branding in the body)
Design - https://www.sketch.com/s/56d8d633-9bb2-4b88-a28a-3457250320d7#Inspector
Ensure the base template renders correctly - Responsiveness
Alt text for VA Logo is, "U.S. Department of Veterans Affairs"

Qaysar is working on access to a tool that is used at the VA or work with procurement for testing emails across browsers, OS, and clients -> Litmus
Utilize existing tools available for accessibility at the VA
Validation will include email previews. Discuss details during kickoff
Finalize list of clients, browsers that need to be used for testing this story

Assumption:

We can discuss changes to the design based on this outcome of this card

Email Clients -
As a Veteran, I want to view the 526EZ email across multiple email clients, so that I have a seamless experience
AC:
1.
Given I am in an email client
When I view the 526EZ confirmation email
Then the email displays appropriately

Given I am in a specific OS with email client
When I view the 526EZ confirmation email
Then the email displays appropriately

Given I am in a mobile email client
When I view the 526EZ confirmation email
Then the email displays appropriately
Browsers -
As a Veteran, I want to view the 526EZ email across browsers, so that I have a seamless experience
AC:

Given I am in a browser
When I view the 526EZ confirmation email
Then the email displays appropriately

Given I am in a browser on a specific OS
When I view the 526EZ confirmation email
Then the email displays appropriately

Given I am in a mobile browser
When I view the 526EZ confirmation email
Then the email displays appropriately
~*Assistive Technologies - *~
~As a Veteran, I want to view the 526EZ email across multiple assistive technologies, so that I have a seamless experience~
**As per discussion during the Desk-check on 8.17.20 the assistive technologies section of this story will be split into a new card #141 **
~AC:~
~7.~
Given I am using a screen reader
When I view the 526EZ confirmation email
Then the email displays appropriately
~8.~
Given I am using a screen reader on a specific OS
When I hear the 526EZ confirmation email
Then the email reads appropriately
~9.~
Given I am using an assistive technology
When I hear the 526EZ confirmation email
Then the email reads appropriately

Some early feedback to be addressed:

font size: 16px
header font size: 32px
font color
link font color

Blocked waiting for Litmus tool (or something similar).
This tool is necessary to:

test across different email clients
make the decision about preheader (that is to control what is shown in preview)

List of supported browsers for vets-website
Might need to verify if this holds true for testing VA Notify and find list of email clients

Adding UI issues noticed during Litmus testing
Apostrophes are replaces with extra characters (Apple Mail and Outlook Mac) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#appmail13
Logo is too large (Outlook Windows) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#ol2016
Padding between text and header is missing (may be related to logo) (Outlook Windows) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#ol2019
Card with claim details is missing padding (Outlook Windows) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#ol2016
Logo is not vertically centered (All)
Logo is too small (Apple Mail iPhone) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#iphone7
2nd paragraph of text has a purple line to the left of it (Apple mail on many iOS devices) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#iphone7
Details card has a left grey border (Gmail app iOS) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#android10gmailappdark
Details Card missing left padding (Several iOS devices) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#ipad
Logo/alt text not displaying (AOL Explorer Windows) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#aolonline
No bold text (Yahoo Windows Explorer) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#yahoo
Logo not displaying (maybe it just didn’t load?) (Yahoo Windows Explorer) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#yahoo
Blue header changes to an odd color (Outlook 365 Dark Mode Windows) - https://litmus.com/folders/unsorted_emails/emails/1186182/checklist#ol365dark

Does Litmus also show plain text emails?
Was it acceptable?

We should be able to text plain text emails. @QaysarA can you edit the browser checklist to include plain text following this - https://help.litmus.com/article/226-how-do-i-test-a-plain-text-version-of-my-email Litmus won't let me edit the checklist.

Hey @toddstanich I already have the plain text version and it's showing up for me. Its in the Outlook email client and under Desktop clients. Please let me know if you don't find it

A couple thing on the plain text email:

The preview text displaying at the top seems strange. I'd like to understand what options we have here.
Remove the * for the bolding.

Unfortunately this is all done by Granicus - so we have 0 control over it.
On Wed, Jul 29, 2020 at 5:03 PM toddstanich<EMAIL_ADDRESS>wrote:

A couple thing on the plain text email:

The preview text displaying at the top seems strange. I'd like to
understand what options we have here.
Remove the * for the bolding.

[image: plaintext-vertical-allowed-1366.png]
https://camo.githubusercontent.com/dc9b6637cd87cdb2cc2333623d4d29d06cf774dd/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3564613039303237363664653762303030316534643766352f34363937303963642d333830342d346339342d383663362d353134663332633631393533
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/department-of-veterans-affairs/notification-api/issues/92#issuecomment-665926050,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANNLRX4VCFTLH3CGW6UDDCDR6CFA5ANCNFSM4OCFQWYA
.

--
Filip Fafara
Consultant
Email<EMAIL_ADDRESS>Telephone +1<PHONE_NUMBER> <+1+267+262+0689>
[image: ThoughtWorks]
http://www.thoughtworks.com/?utm_campaign=filip-fafara-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator

We are using e28099 utf-8 as apostrophe which we should replace by 27.

As per discussion during the Desk-check on 8.17.20 the assistive technologies section of this story will be split into a new card #141

iOS mail on iphones still seems to have something going on. The logo is at the edge of the blue bar and seems smaller, almost like it is displaying the desktop email and scaling it down to fit the screen. https://litmus.com/folders/unsorted_emails/emails/1296854/checklist#iphone11

Moving back to in progress to look at the above comment.


"No language file was found" (but they are there..)

Dear
I've got the following error. It seems that my language files are not included, but if I include them at the same path, they are.
Error message looks like this:

My files look like this, I tried to put the lang files at different locations

Your example.php page is working fine for me. I first tried my changes over there, and it worked as expected, but it isn't working in my project.
I use the following code

I've also set my session variable to know which lang file to use.
You have an idea what I'm doing wrong?
Thanks in advance!

The variable '$this->langFilePath' gives the correct path, as you can see. I've got no clue at this point.

HOW!

I don't remember, it's been 4 years, sorry.
Since those 4 years have passed, I learned to answer my own questions with the solution, don't worry.


Enable parent field in sorted bwc tests

This enables the optional parent field in BWC tests from 9.10 on. This will need to be forward ported to main branch where the parent field is required to these tests since they add document blocks during tests.

FYI I had not paid attention to the timing but this got merged after I cut the branch for 9.10, so I just bumped the version in this change to 9.11.


Additional Layer of Organization (e.g. Libraries, Rooms, ...)

Describe the feature you'd like
How about adding another organizational layer to the shelves, books etc.?
Like the possibility to add libraries and/or rooms, where the shelves are sorted in.
Maybe even as an option that can be turned on or off.
Organziation would look like: library/(room)/shelve/book/chapter/page
Describe the benefits this would bring to existing BookStack users
One more level to organize stuff, e.g. you aquire a new company and want to differentiate content between them.
Can the goal of this request already be achieved via other means?
Not as i know. Sorry if already requested, could not find any matches.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
Under 3 months
Additional context
No response

Hi @mgmwhite,
Please see #95 for the most extensive past discussion on additional levels.
As an additional workaround, to achieve this via other means, you could instead set up multiple separate BookStack instances.

Hi @ssddanbrown thanks for taking me back to this, great discussion and the workaround, will think of that.
Cheers


frontend improvements

[ ] Improve JS readibility: https://github.com/inveniosoftware/invenio-app-rdm/pull/1260#discussion_r812764953
[ ] Use variable for button colors: https://github.com/inveniosoftware/invenio-app-rdm/pull/1260#discussion_r812767583
[ ] Use generic error cmp: https://github.com/inveniosoftware/invenio-app-rdm/pull/1260#discussion_r812768486 (create it if not yet there)

@jrcastro2 can we close this?

I don't think so, the links are pointing to comments in a PR that still need to be addressed

PRs seem merged, can we close?

PRs seem merged, can we close?

Not yet, the links point to comments, but we can create 2 issues isntead; one for implementing a generic error cmp to display the messages and another to review the usage of the colors.

I would say so, is hard to grasp what this issue means otherwise, I'll make issues out of them you can add content if I miss anything

https://github.com/inveniosoftware/invenio-app-rdm/issues/1616 , https://github.com/inveniosoftware/invenio-app-rdm/issues/1614 and https://github.com/inveniosoftware/invenio-app-rdm/issues/1615


RC Spot Check: Build-A-Molecule 1.0.0-rc.3

@ariel-phet , @arouinfar, build-a-moelcule/1.0.0-rc.3 is ready for RC testing. This is not to be shared with a client as we are approaching publication. Document issues in https://github.com/phetsims/build-a-molecule/issues and link to this
issue.
This is a spot check of some minor cosmetic changes and performance on iPadOS 13.7. This sim just came out of an RC test cycle with only minor code changes, so we are just wrapping up the test cycle by verifying a few issues.
Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book
for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
Try to include version numbers for browsers
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
there is a problem.

Focus and Special Instructions
As noted in https://github.com/phetsims/QA/issues/538#issuecomment-691341921, it was suggested by @ariel-phet to test for crashing behavior on iPadOS 13.7 without any query parameters. An issue should be opened if the sim crashes on iPadOS 13.7 when no query parameters are used. The remaining issues can be verified below.

Issues to Verify

[ ] iPad reset all button overlaps collection box
[ ] Appropriate close button touch area (issue not opened)
[ ] Graphic failure when using LoL harness

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Simulation
iFrame
XHTML
[Test Matrix](broken link)
Legends of Learning Harness

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Devices/Platforms to spot check:

[ ] Win 10 Chrome
[ ] Win 10 Firefox
[ ] Mac 10.15 Safari
[ ] iPadOS 14
[ ] ChromeOS

@Denz1994 is this list alright?

This list looks good to me. I would just make sure to test iPadOS 14 without query parameters as described above.

As noted in #538 (comment), it was suggested by @ariel-phet to test for crashing behavior on iPadOS 13.7 without any query parameters. An issue should be opened if the sim crashes on iPadOS 13.7 when no query parameters are used.

As per request by @ariel-phet, a new spot check should be issued for this sim because of the release of iOS 14. There was a patch that was done in https://github.com/phetsims/build-a-molecule/issues/211 that should be verified. @ariel-phet mentioned he will take a look first and then reassign to QA. Closing this one.


Remote resource should respect sensitive flag

➜  remote_directory_example git:(master) ✗ sudo bundle exec chef-client -z -o remote_directory[2016-06-13T17:35:20-07:00] WARN: No config file found or specified on command line, using command line options.
Starting Chef Client, version 12.12.2
[2016-06-13T17:35:27-07:00] WARN: Run List override has been provided.
[2016-06-13T17:35:27-07:00] WARN: Original Run List: []
[2016-06-13T17:35:27-07:00] WARN: Overridden Run List: [recipe[remote_directory]]
resolving cookbooks for run list: ["remote_directory"]
Synchronizing Cookbooks:
  - remote_directory (0.1.0)
Installing Cookbook Gems:
Compiling Cookbooks...
Converging 1 resources
Recipe: remote_directory::default
  * remote_directory[/var/www/html] action create
    - create new directory /var/www/html
    - change mode from '' to '0755'
  Recipe: <Dynamically Defined Resource>
    * cookbook_file[/var/www/html/foo.html] action create
      - create new file /var/www/html/foo.html
      - update content in file /var/www/html/foo.html from none to 806772
      - suppressed sensitive resource
      - change mode from '' to '0644'
    * cookbook_file[/var/www/html/index.html] action create
      - create new file /var/www/html/index.html
      - update content in file /var/www/html/index.html from none to 64ec88
      - suppressed sensitive resource
      - change mode from '' to '0644'

[2016-06-13T17:35:27-07:00] WARN: Skipping final node save because override_runlist was given

Running handlers:
Running handlers complete
Chef Client finished, 3/3 resources updated in 05 seconds

👍

:+1: and what @coderanger said


Error response from /api/v2/write does not match swagger documentation

When a request to /api/v2/write fails the error response does not match the documented error responses.
steps

curl -X POST 'http://<IP_ADDRESS>:9999/api/v2/write?bucket=foobar&org=influxdata'

expected
Response should contain 4 strings: code, message, op, and err.
actual
No err value, instead a error object containing several strings.
HTTP/1.1 404 Not Found
Content-Length: 131
Content-Type: application/json; charset=utf-8
Date: Tue, 19 Mar 2019 00:29:44 GMT
X-Platform-Error-Code: not found

{
    "code": "not found",
    "error": {
        "code": "not found",
        "message": "bucket not found"
    },
    "message": "bucket not found",
    "op": "http/handleWrite"
}

please ensure the bucket name is provided in the error response. https://github.com/influxdata/telegraf/issues/5600

I suggest against putting the bucket name in the error response, as that allows the client to have some limited control over the response body.  That's not a problem so long as we do everything right but if we mess up it can be a security issue.
@russorat If we want to provide for the issue in Telegraf, we should open a new feature request issue for consideration.


[BACKLOG-16442] Moving and renaming windows script and readme from pe…

…ntaho-ee repository
@pentaho/bb-8

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.

master - https://github.com/pentaho/pentaho-kettle/pull/5308
8.1 - https://github.com/pentaho/pentaho-kettle/pull/5309
<IP_ADDRESS> - https://github.com/pentaho/pentaho-kettle/pull/5310


PermissionError when searching

tried to use your plugin and got error in console and did not get my games in catalog
00:02:31.364 AllMyGames.AllMyGames: [Steam] new libraries format
00:02:31.998 WARNING: AllMyGames.AllMyGames: failed to initialize repo GOG [WinError 2] The system cannot find the file specified
00:02:32.067 AllMyGames.AllMyGames: Games found ['Steam: 94', 'Epic Games Store: 2', 'Windows Store: 23', 'Origin: 0', 'UPlay: 3']
00:02:34.029 ** ERROR: Error from AllMyGames.AllMyGames.on_catalog: <class 'PermissionError'>: [Errno 13] Permission denied: 'C:/Program Files (x86)/Ubisoft/Ubisoft Game Launcher/data/games/'
Traceback (most recent call last):
  File "C:\PortableApps\KeyPirinha\portable\Profile\InstalledPackages\AllMyGames.keypirinha-package\allmygames.py", line 102, in on_catalog
  File "C:\PortableApps\KeyPirinha\portable\Profile\InstalledPackages\AllMyGames.keypirinha-package\allmygames.py", line 102, in <genexpr>
  File "C:\PortableApps\KeyPirinha\portable\Profile\InstalledPackages\AllMyGames.keypirinha-package\allmygames.py", line 112, in make_item
  File "C:\PortableApps\KeyPirinha\portable\Profile\InstalledPackages\AllMyGames.keypirinha-package\allmygames.py", line 151, in get_icon

I think this screenshot explain everything (see DisplayIcon value)

I believe it would be OK if game displays without icon, we need try catch or something..

fixed in v1.5
sorry this took so long


[feature request] change progress percentage label/text

Expected Behavior

If possible, change the label "Completed" in progress bar, percentage = true
Current Behavior

No API yet to edit this
Possible Solution

<Progress
  color="lightGreen"
  value="100"
  percentage={true}
  percentageLabel="Compressed" # suggestion
/>

Your Environment

Version used: 1.0.7
Browser Name and version: chrome
Operating System and version (desktop or mobile): desktop
Link to your project:

HI @shierro, is this is being worked upon? If not, mind if I give it a try? Thanks!!

Haven't worked on it yet and of course you can 😄
On Sun, 10 Oct 2021, 3:23 am Bhavin Ag, @.***> wrote:

HI @shierro https://github.com/shierro, is this is being worked upon?
If not, mind if I give it a try? Thanks!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/creativetimofficial/material-tailwind/issues/67#issuecomment-939349808,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4RKNNAICVQFPV5KGWZCHTUGCJC5ANCNFSM5CZDMHZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi guys,
I've just updated the @material-tailwind/react and fix this issue.
All the best,
Sajad


listPaymentsWithHttpInfo not returning batch_token with V1TransactionsApi

Maxing out the 200 limit, and need to get the batch token, even setting the limit to 1, I'm still not getting any batch token info in the [link] header params.
SquareConnect\Util\CaseInsensitiveArray Object
(
    [lower_dict:SquareConnect\Util\CaseInsensitiveArray:private] => Array
        (
            [0] => HTTP/1.1 200 OK
            [content-type] => application/json
            [link] => ;rel='next'
            [vary] => Origin, Accept-Encoding
            [x-content-type-options] => nosniff
            [x-download-options] => noopen
            [x-frame-options] => SAMEORIGIN
            [x-permitted-cross-domain-policies] => none
            [x-xss-protection] => 1; mode=block
            [date] => Mon, 03 Feb 2020 23:44:34 GMT
            [strict-transport-security] => max-age=631152000; includeSubDomains; preload
            [transfer-encoding] => chunked
        )

    [storage:ArrayObject:private] => Array
        (
            [0] => HTTP/1.1 200 OK
            [Content-Type] => application/json
            [Link] => ;rel='next'
            [Vary] => Origin, Accept-Encoding
            [X-Content-Type-Options] => nosniff
            [X-Download-Options] => noopen
            [X-Frame-Options] => SAMEORIGIN
            [X-Permitted-Cross-Domain-Policies] => none
            [X-Xss-Protection] => 1; mode=block
            [Date] => Mon, 03 Feb 2020 23:44:34 GMT
            [Strict-Transport-Security] => max-age=631152000; includeSubDomains; preload
            [Transfer-Encoding] => chunked
        )

)

SquareConnect\Configuration::getDefaultConfiguration()->setAccessToken(API_KEY_SQUARE);
$api_instance = new \SquareConnect\Api\V1TransactionsApi();
list($result, $status, $headers) = $api_instance->listPaymentsWithHttpInfo($square_location_id, $order, $start, $end, $limit, $batch_token);
$batch_token = \SquareConnect\ApiClient::getV1BatchTokenFromHeaders($headers);

However, in Terminal I'm able run the same command and I get the batch_token: curl -I https://connect.squareup.com/v1/XXXXXXXXXXXX/payments   -X GET   -H 'Content-Type: application/json'   -H 'Square-Version: 2020-01-22'   -H 'Authorization: Bearer XXXXXXXXXX'
I'm also able to get the token via:
 $url = "https://connect.squareup.com/v1/XXXXXXXXXXXXX/payments";
          $headers[] = "Accept: application/json";
          $headers[] = "Content-Type: application/json";
          $headers[] = "Square-Version: 2020-01-22";
          $headers[] = "Authorization: Bearer XXXXXXXXXXXXXXXXX";

          $ch = curl_init();

          curl_setopt($ch, CURLOPT_URL, $url);
          curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
          curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
          curl_setopt($ch, CURLOPT_HEADER, 1);

          $response = curl_exec($ch);

          // Retudn headers seperatly from the Response Body
          $header_size = curl_getinfo($ch, CURLINFO_HEADER_SIZE);
          $headers = substr($response, 0, $header_size);
          $body = substr($response, $header_size);

          curl_close($ch);

In the callApi method of the ApiClient.php file if I add
header('Content-type: text/html; charset=UTF-8');
it seems to display in the print_r

Thanks for reporting. We're looking into the cause behind this, I'm seeing the same as you.

@TravisCornelius great news! A fix has been released for this. Please update to version 2.20200122.1, and it should work :). Let me know if that's not the case.


Doesn't support safari phone browser

As soon as you start enter the cursor moves towards end of field and couldn't able to enter

@vittaljk I just tested the website https://text-mask.github.io/text-mask/ on my iPhone 6 Plus running iOS 10. It works fine. Can you give more specific information about how you tested it and how it broke?


Should equals only compare place and not value?

In https://github.com/atlas-engineer/nyxt/pull/2451 we are manually replacing the existing setter handler.  This is most certainly something that nhooks should do for us by default.
One possible fix is to change equals so that it only compares the place, and not the value.
But then the notion of equality is a bit dubious.
Alternatively, keep equals as it is and just add another check in add-hook to remove existing setter.
@aartaka Thoughts?

Documentation is in the slots, but examples and tests are lacking.  Something more to fix! :)


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-04-05)
Features

API Client: Payments and customers endpoints (5dee30f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wearethefoos/ueberauth_mollie/releases/tag/v1.1.0 :sunflower:


"Trade-offs" section to readme?

The readme for re-frame is top-notch, but it would be a great addition to have a section on "can't do, doesn't cover, doesn't try to do, makes difficult" in the essence of full transparency.
Often a library / framework proclaims loudly all the wondrous things it can accomplish, and marvelous feats of complexity it tackles in a simple way. As potential users of a library, I almost immediately look for the things a library is trying to hide. Does performance suck? Does the mental model break down at scale? Is it impossible to have a large team work in parallel? Does the framework help you pour concrete, and hide that fact, until everything has dried?
If I can't find these tradeoffs relatively quickly, I become very skeptical and am likely to move on.
I personally haven't used reframe for anything but trivial exploration. It would be great to get input from people who have worked on non-trivial applications at scale over extended periods. That is a lot of qualifiers, but too often I see arguments on ghissues or ggroups or reddit claiming "my non-trivial application I spent 3 months developing went swimmingly and there are no issues". A 3 month project is almost by definition trivial.
Personally, I would be interested in areas around these points, but I welcome any and all feedback from others:

modularity/composability/fractability - can you create a completely independent module and have N copies of that module? Can you reuse such a module across applications? Can you have N copies of a module each containing M copies of a nested module, again, without crossing wires? Can you run two independent copies of your app side-by-side in different divs? I can't tell you how many frameworks out there require you to re-write modules in significant ways in order to make them "portable", and some simply disallow it entirely. I'm not entirely sure how re-frame could handle these cases, if at all.
coordination - complex web-apps often have deep-linking (not in the url sense) between states/views/workflows. A particular weakness I find with a lot of event-driven/top-down style architectures is that coordinating decoupled pieces becomes tedious, if not impossible. Imagine a user is browsing a pie chart, and wants to click on a slice. Perhaps this takes you to an entirely different part of the application, which requires 1) swapping the main context from "charts" to "deep analysis" 2) loading up data from the selection into a handful of deeper-analysis views 3) swapping out toolbars / selections in  other components to reflect the deep link. This kind of linking has been a requirement of nearly all applications I have built in the last few years. One potential pain-point I see immediately with re-frame is the 1-to-1 event / handler requirement. If [:pie-slice-clicked] can only be caught by 1 module, how can you coordinate this dance without coupling modules in unseemly ways?
middleware - this isn't a weakness of re-frame, more just a design decision, but I would be interested to hear how people feel about having to attach middleware to each handler independently? I have always thought middleware were orthogonal, app-wide wrappers initialized once and forgotten. I find it strange that re-frame has a per-handler middleware scenario.

Thanks for your time,
~luke

To give some context around the first point (modularity).. there's a whole project dedicated to addressing issues that come up in a redux-style architecture, which closely matches re-frame. The gist is that redux is not designed with modularity in mind, and consequently larger-scale apps start to collapse under complexity arising from the inability to reuse components (and also communication of side-effects between components). Worth a glance.

@aft-luke   I agree with your sentiment and the need.
But I've been put off writing up something because:

my SPAs tend to be a bit unusual - I'm inexperienced in many more common usecases.  I'd hesitate to hold forth with opinions without real experience (of, say deep linking).
such assessments require quite broad knowledge of alternatives technologies.  Everything is relative.

So ... I would encourage others to add their own experiences in here, so we accumulate a picture (good and bad),

After having some fun with re-frame, coming from om(.now, not .next since it would entails me to relearn everything and live again on a dangerous bleeding edge lacking documentation), I guess I could at least give some opinion about @aft-luke question :
• a per handler middleware is for me needed. I have varying data source type, and it's easier to configure each handler for the specificity of those. There's of course some tediousness added if you use some nearly everywhere, but well, nothing stop us to write another middleware to take care of that, so not bothering me a lot.
• as per coupling, I found that most component seem to cascade their coupling. The pie-chart example would trigger one event, that would start a cascade of events. The good thing about this is, for me at least, that it's easy to test a restricted version of this cascade. Having written a lot of traditionnal mvc app, this is clearly very refreshing since I don't have to fight this coupling : it doesn't exist per se, it's only some configuration change.
Anecdote : I have a main component that only handle navigation. In it I load the sub component needed : each will then check in the db if they need to do anything, load more component, and all that individually.
• I would too be curious to see how create "library" component. My next app willuse the re-com library, so I will maybe have a better idea on how @mike-thompson-day8  handle this, but for now it's a bit mysterious. Maybe something that can be improved in the documentation ?
The only real limitation is the react ones from my PoV, like how to properly animate stuff for example.

I'm certainly interested in reading such a considered piece, but as I indicated earlier, I'm not the one to write it.  I'm biased and I don't have broad experience. I'll leave that to the blog posts of others.
I'm in cleanup mode, so I'm going to close this.


Can't overwrite environment variables set in Netlify UI

Thanks for reporting this bug!
If this is related to a typo or the documentation being unclear, please click on
the relevant page's Edit button (pencil icon) and suggest a correction
instead.
Please search other issues to make sure this bug has not already been reported.
Then fill in the sections below.
Describe the bug
With this build plugin enabled, I am no longer able to overwrite environment variables that are set in the netlify UI. We have two variables, one called ENVKEY and another called ENVKEY_DEV. We have been using build contexts and branch names to determine when we might be in a situation to swap one for the other, at which point we do process.env.ENVKEY = process.env.ENVKEY_DEV. With this build plugin enabled, this operation no longer works, and the original value is retained.
Steps to reproduce

Set two secrets in the Netlify UI
Place the following lines somewhere near the beginning of your build command:

process.env.KEY_1 = process.env.KEY_2
console.log( process.env.KEY_1 )

Expected behavior
process.env.KEY_1 should now have the value from process.env.KEY_2, but it does not.
Configuration
We are running gulp build && gatsby build for our build command, ( gulp is for processing our functions ), but I don't think it really matters what command is being run. We are using dotenv in both gulp and gatsby, with this command:
require( `dotenv` ).config({
  path: `.env`,
})

Environment
This only happens when building on Netlify's build system. Locally, it works as expected.
Screenshots
In the screenshot below, the end of the highlighted line should say develop, not production:

Can you submit a pull request?
No.

Hello. Any update on this?

Is this still an issue for you @jdesherlia ?

I just tried this again, and it seems to be resolved now. Closing. Thanks!


Use dynamic gasPrice and gasLimit in claimReward scripts

@Malysh73 could you please verify the functionality of transactions without these modifications? I don't see any clear value in adding these changes.


[HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] [$500] Login - Email address does not remain when refresh Magic Code page and hit Go back button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.80-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Enter e-mail address & click Sign in button
Refresh the page
Hit Go back button

Expected Result:
Once added, e-mail address should remain after refreshing Magic Code page and hit Go back button
Actual Result:
Email address does not remain when refresh Magic Code page and hit Go back button
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] Windows: Chrome
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

https://github.com/Expensify/App/assets/78819774/8a2752c8-4a34-42d6-ad30-c430b453ed5d

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0181306db2b58c51f7
Upwork Job ID:<PHONE_NUMBER>275936256
Last Price Increase: 2023-10-17
Automatic offers:

fedirjh | Reviewer | 27339710
bernhardoj | Contributor | 27339711

Issue OwnerCurrent Issue Owner: @zanyrenney

Reproducible

I'm OOO Oct 16-23. Adding leave buddy
Status: looking for proposals

The root cause of this problem is that the login input value is stored in a simple state using the code provided and when the web app is refreshed, the value stored in this state is cleared.
To solve this issue and retain the login input after a web app refresh, you can use a different approach by saving and retrieving the login data from a more persistent storage location. One possible solution is to store the login input data in a client-side storage like localStorage or a cookie. This way, even if the web app is refreshed, the login data can be retrieved from the client-side storage and populated back into the input field when the user returns to the login form.

Contributor details
My Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~019ec726f12bc9ad91

Proposed Solution
To address this, we can pass the credentials as props to the LoginForm. I've written the necessary code changes and tested them locally, and they appear to resolve the issue.
Next Steps
If this solution aligns with the project's direction, I'm ready to create a pull request for a more thorough review. Please let me know how we should proceed.
Contributor details
My Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e7d8746987c01ca7

Proposed Solution
To address this, we can pass the credentials as props to the LoginForm. I've written the necessary code changes and tested them locally, and they appear to resolve the issue.
Next Steps
If this solution aligns with the project's direction, I'm ready to create a pull request for a more thorough review. Please let me know how we should proceed.
Contributor details
My Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e7d8746987c01ca7

Proposal
Updated

Thanks @fedirjh, the proposal LGTM too, assigning @bernhardoj 🚀

Not sure why I am assigned to this, removing as @sonialiap is the assignee who has done all the work here!

@fedirjh review + bonus = $750 - paid ✔
@bernhardoj fix + bonus = $750 - paid ✔

@fedirjh please complete the checklist https://github.com/Expensify/App/issues/29192#issuecomment-1784624336


[CI] Verify proof solutions for exercises on windows

Signed-off-by: Sven Pfennig<EMAIL_ADDRESS>

LG


What Nox version I should use ?

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
Hello, with the recent lottery event in JP (Christmas Martha), I had found this script (or should I say app ?) useful for other people so I decided to test it.
I got 'Failed to install' message when trying to install on Nox Emulator version 7.0.17, yes I had read the troubleshooting that FGA could not be installed on latest version of Nox Emulator. So the question is, which versions are considered 'old' ?
Thank you.

https://github.com/Fate-Grand-Automata/FGA/issues/748#issuecomment-903131657
Can't tell you which one higher than that works, Nox can't run on Windows 11, it seems.

alright im gonna try it, thank you

I tested it already, I am using Nox Emulator version <IP_ADDRESS> tried 3 ways of installing

Using APK icon at sidebar, the issue is "Failed to install"
Using File manager, the issue is "This package is corrupted" something like that
Download the apk from Nox directly and installed it, the issue is the same as number 2

Any suggestion?

You did create an Android 7 instance, right?

And you could try installing it with adb install FGA.apk, maybe you see more details that way.

Yeah im creating new android instances with Android 7, but still cannot install

What about my adb suggestion?

i dont have adb or android studio package, should i downloaded it ?

See https://www.xda-developers.com/install-adb-windows-macos-linux/

Here i got an error

Did you change the apk in any way?
Can you try downloading it again from https://github.com/Fate-Grand-Automata/FGA/releases/download/canary/com.mathewsachin.fategrandautomata.apk?
Works fine on my machine even on newest Nox.
I just had to disable some Windows security setting to make it work again on Windows 11.

No, i did not change anything regarding the apk
I asked my friend, he used Nox Emulator with <IP_ADDRESS> version and he couldn't. But I tried installing on my laptop using Nox Emulator with <IP_ADDRESS> and succeed.
My os is windows 10.

What I wanted to indicate is that the error above usually pops up if the apk was corrupted in some way.
You could run certutil -hashfile FGA.apk MD5 on the command line. It should be 592e1bf22ab751b100d88de129c2d325 for the latest apk.
Otherwise, the apk is corrupted.

Okay , ill give it a try

I got same md5 hash, but still file is corrupted.
As for now, I need to downgrade my Nox again to version <IP_ADDRESS> for it to run smoothly.


feat: port Geometry.Euclidean.Sphere.Ptolemy

[x] depends on: #5036

This PR/issue depends on:

leanprover-community/mathlib4#5036
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#5036
By Dependent Issues (🤖). Happy coding!


Mqtt support

I'm no python dev but this is working for me.

Looking forward to use mqtt for integration for my homeassistant.
Tested this and found a little bug: --all does not work together with --mqtt. If mqtt is active, it will iterate only over the first depth of dict and tries to send a dict via mqtt which ends as error. It either must iterate the second depth as well or do a json.dumps()

The development continues in #13.


instantiate2_address(...) produces canonical addresses that addr_humanize can't parse

hi guys.. I ran into this one.
in mock-test v20, using 1.2 cosmwasm std feature.
    let canonical: CanonicalAddr = instantiate2_address(&checksum, &creator, &salt)?;
    let new_addr_addr = deps.api.addr_humanize(&canonical)?;

produces an error     0: Generic error: Invalid input: canonical address length not correct
the canonical address getting passed has a length of 32, while the mock expects a length of 90.

thanks.. I'll switch to using v2 of cosmwasm-std in my smart contract codebases


Publish 2.0.7 and live demo update

@xiaokaike could you publish the version 2.0.7 ? I guess you have the permissions to publish.
Is the live demo being updated automatically ? I guess it needs to be updated as well, probably after publishing

done