Use Filter

API says

Search endpoints are controlled by the current user's filter (or the default, if no key is supplied); if you wish to using a custom filter, you can use the "filter_id" parameter.

For example the public filter with the id 118851 (as json) can be used in a search query as following:
https://derpibooru.org/search.json?q=*&filter_id=118851 where q=* search for everything (wildcard)
Trying around showed:

the filter is ignored in normal browser searches (if .json is omitted)
if filter_id is present anywhere, key is ignored.
if the filter is private, key must be present to display the filter metadata derpiboo.ru/filters/118854

but does not prevent you from using it, you can search with private filters without the key. private filter 118854 search

really nice is that the user json of the filter contains a user id instead of the username.

So you can't mistake a Background pony with the Background pony (which I created accidentally today... :sweat:)

I highly approve. Having to use keys has turned out to be quite annoying.

That's correct.
  def load_filter
    if using_api? && params[:filter_id].present?
      @current_filter ||= Filter.for(nil, params[:filter_id])
    else
      @current_filter ||= Filter.for(current_user, session[:filter_id])
    end
  end

What is correct?
Also, what does that code snippet? (and what language is it? looks bit like ruby/rails from what I stumbled across)

That's the code snippet from the derpibooru source code related to API filter usage. Your observations laid out in the first post match what the code does.

@liamwhite So you are a coding team member there? Or is it now open source and I completely missed it? :cold_sweat:

I have had source code access for almost a year now. The code itself is currently not publically available and will remain so for the forseeable future, but I am more than happy to share code that wouldn't impinge on the efforts of the admins to maintain control of the site.

Maybe you can share some insight why I can't get the tag changes to work example 1, example 0

The API for tag and source changes was leaking sensitive user information (user IPs!) and so was stemmed when I discovered this. We have not yet created a fix.

Also, can you share what replacements are done in order to come from a [artist:foo-bar] tag name to the /tags/artist-colon-foo-dash-bar slug?

This discussion is getting off topic.

Tell me where to continue it, please.

byte[] on irc.ponychat.net #derpibooru (I will be afk for some time after responding, please send me a PM with your questions and I'll answer them when I'm back.)

@6 relates to this

I have something working here. I'll see if I can PR tomorrow.

@liamwhite
Is filter_id always a number?

Yes.

I'll add that to #9

So it just needs a Version bump on PyPi.

Is it?


File Not Found error when running Dreambooth cell

In the previous cell I kept path_to_huggingface blank and unchecked v2 (not exactly sure if that is related or not).
That ModelDownload cell ran fine, but then in the DreamBooth cell I got the follwing error, where I kept Session_Link_optional blank. This is my first time running the Colab so I am unsure why it expects to find the file or directory /content/gdrive/MyDrive/Fast-Dreambooth/Sessions/BobbyDreamBooth'

[<ipython-input-10-999458498acd>](https://localhost:8080/#) in <module>
     79 V2=False
     80
---> 81 list=[ckph for ckph in listdir(SESSION_DIR) if os.path.isdir(SESSION_DIR+'/'+ckph)]
     82 diff=[k for k in list if "_step_" in k]
     83

FileNotFoundError: [Errno 2] No such file or directory: '/content/gdrive/MyDrive/Fast-Dreambooth/Sessions/BobbyDreamBooth'

fixed a few minutes ago


Skip goreleaser validation

Testing that we've added leaves a few artifacts around
which mess up the porcelain state goreleaser wants.
For the time being we're just going to remove the
validation.
Signed-off-by: John Schnake<EMAIL_ADDRESS>

Not going to wait on this to test since it is a one line change that wont even be hit since we aren't tagging this commit.


Query: PhantomJS 2.5 beta code for early evaluation.

Hi,
Is it possible to get PhantomJS 2.5 beta code for testing and evaluation on ppc64le platform? I didn't find anything about it in the repository (branch/tag) etc. I would like to check this code on ppc64le for possible improvements related to latest qtwebkit code along with phantomjs code.
Thanks,
Atul.

AFAIK, Qt doesn't support ppc64 anymore. I suggest you to check Qt first for ppc64.

We can't do much here, please bring up your request to the Qt team: https://www.qt.io/.

@ariya Understood. So I checked up about this with the qt team and they advised to upgrade the qtwebkit version. PhantomJS 2.1.1 is using Qt 5.5.1 version. So my question is - which version of Qt is being used by PhantomJS 2.5? I would like to clone the 2.5 code and work on the qt code in that to make it work on ppc64le. With my experience so far, only one fix is required to make Qt work on ppc64le, which is about pagesize value change. I have this fix with me and with this, PhantomJS 2.1.1 (Qt 5.5.1) works okay on ppc64le save the above mentioned issues with CSS parser. So I have high hopes that PhantomJS 2.5 should work on ppc64le as well.
Thanks!

The discussion with Qt community is at https://lists.webkit.org/pipermail/webkit-dev/2017-February/028722.html


New Tenant v1alpha2 version

New features have been implemented in the current version, most of them are available using annotations that are just a workaround (or rather, a Technology Preview) for the said features.
We have to start releasing the new version that will provide real specification keys for the upcoming and planned features.

Assign Priority Classes to tenants
Require tenants to use imagePullPolicy as Always
Add applications to act as tenant owner
Make configurable the Resource Quota enforcement at tenant level

Luckily, we had a discussion on #202 and from the reconciliation PoV it's pretty easy, not the same for webhooks but we can work on that.
@MaxFedotov do you already have some rough ideas on the new API version structure?

And also we should not forgot about:
The following Tenant annotations allow a sort of RBAC on the operations of the nodes:
capsule.clastix.io/enable-node-listing: allows listing of nodes and node retrieval
capsule.clastix.io/enable-node-update: allows the update of the node (cordoning and uncording, node tainting)
capsule.clastix.io/enable-node-deletion: allows deletion of the node

The following Tenant annotations allow a sort of RBAC on the Storage Class operations:
capsule.clastix.io/enable-storageclass-listing: allows listing of Storage Class and Storage Classes retrieval
capsule.clastix.io/enable-storageclass-update: allows the update of the Storage Class
capsule.clastix.io/enable-storageclass-deletion: allows deletion of the Storage Class

The following Tenant annotations allow a sort of RBAC on the Ingress Class operations:
capsule.clastix.io/enable-ingressclass-listing: allows listing of Ingress Class and Ingress Classes retrieval
capsule.clastix.io/enable-ingressclass-update: allows the update of the Ingress Class
capsule.clastix.io/enable-ingressclass-deletion: allows deletion of the Ingress Class

maybe add some new field for capsule-proxy settings?
  proxySettings:
  - kind: nodes
    operations: ["LIST", "UPDATE", "DELETE"] //or allowed?
  - kind: storageclasses
    operations: ["LIST"]
  - kind: ingressclasses
    operations: ["LIST"]

so in the result (not including #50, which needs some discussion) it could be smth like:
package v1alpha2

import (
	corev1 "k8s.io/api/core/v1"
	networkingv1 "k8s.io/api/networking/v1"
	rbacv1 "k8s.io/api/rbac/v1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// TenantSpec defines the desired state of Tenant
type TenantSpec struct {
	Owner []OwnerSpec `json:"owner"` // or should it be Owners?

	//+kubebuilder:validation:Minimum=1
	NamespaceQuota         *int32                           `json:"namespaceQuota,omitempty"`
	NamespacesMetadata     AdditionalMetadata               `json:"namespacesMetadata,omitempty"`
	ServicesMetadata       AdditionalMetadata               `json:"servicesMetadata,omitempty"`
	StorageClasses         *AllowedListSpec                 `json:"storageClasses,omitempty"`
	IngressClasses         *AllowedListSpec                 `json:"ingressClasses,omitempty"`
	IngressHostnames       *AllowedListSpec                 `json:"ingressHostnames,omitempty"`
	ContainerRegistries    *AllowedListSpec                 `json:"containerRegistries,omitempty"`
	NodeSelector           map[string]string                `json:"nodeSelector,omitempty"`
	NetworkPolicies        []networkingv1.NetworkPolicySpec `json:"networkPolicies,omitempty"`
	LimitRanges            []corev1.LimitRangeSpec          `json:"limitRanges,omitempty"`
	ResourceQuota          []corev1.ResourceQuotaSpec       `json:"resourceQuotas,omitempty"`
	AdditionalRoleBindings []AdditionalRoleBindings         `json:"additionalRoleBindings,omitempty"`
	ExternalServiceIPs     *ExternalServiceIPs              `json:"externalServiceIPs,omitempty"`
        ImagePullPolicy        []ImagePullPolicy                `json:"allowedImagePullPolicies,omitempty"`
        PriorityClasses        *AllowedListSpec                 `json:"priorityClasses,omitempty"`
        ProxySettings          []ProxySettings                  `json:"proxySettings,omitempty"`  // or proxyRbac?
}

type AdditionalMetadata struct {
	AdditionalLabels      map[string]string `json:"additionalLabels,omitempty"`
	AdditionalAnnotations map[string]string `json:"additionalAnnotations,omitempty"`
}

// +kubebuilder:validation:Pattern="^([0-9]{1,3}.){3}[0-9]{1,3}(/([0-9]|[1-2][0-9]|3[0-2]))?$"
type AllowedIP string

type ExternalServiceIPs struct {
	Allowed []AllowedIP `json:"allowed"`
}

// +kubebuilder:validation:Enum=Always;Never;IfNotPresent
type ImagePullPolicy string

func (i ImagePullPolicy) String() string {
	return string(i)
}

type AdditionalRoleBindings struct {
	ClusterRoleName string `json:"clusterRoleName"`
	// kubebuilder:validation:Minimum=1
	Subjects []rbacv1.Subject `json:"subjects"`
}

// OwnerSpec defines tenant owner name and kind
type OwnerSpec struct {
	Kind OwnerKind   `json:"kind"`
    *AllowedListSpec
}

// +kubebuilder:validation:Enum=User;Group;ServiceAccount
type OwnerKind string

func (k OwnerKind) String() string {
	return string(k)
}

type ProxySettings struct {
    Kind       ProxyServiceKind `json:"kind"`
    Operations []ProxyOperation `json:"operations"`
}

// +kubebuilder:validation:Enum=List;Update;Delete
type ProxyOperation string

func (p ProxyOperation) String() string {
	return string(k)
}

// +kubebuilder:validation:Enum=Nodes;Storageclasses;Ingressclasses
type ProxyServiceKind string

func (p ProxyServiceKind) String() string {
	return string(k)
}

// TenantStatus defines the observed state of Tenant
type TenantStatus struct {
	Size       uint     `json:"size"`
	Namespaces []string `json:"namespaces,omitempty"`
}

What a stunning job you did, @MaxFedotov! 🚀
Rather than ProxySettings, I was thinking that we could further decorate the OwnerSpec as follows.
// OwnerSpec defines tenant owner name and kind
type OwnerSpec struct {
	Kind OwnerKind   `json:"kind"`
	*AllowedListSpec
        ProxyOperations []ProxySettings
}

With this, we could have additional fine-grained permissions on users.
WDYT?

@prometherion great idea :)

The new version has been updated to v1beta1 since we need this according to the deprecation policy of Kubernetes.
Error: failed to install CRD crds/tenant-crd.yaml: CustomResourceDefinition.apiextensions.k8s.io "tenants.capsule.clastix.io" is invalid: spec.conversion.conversionReviewVersions: Invalid value: []string{"v1alpha1", "v1alpha2"}: must include at least one of v1, v1beta1


support swift storage

tests passed:
https://infrabox.ninja/dashboard/#/project/sap-infrabox/build/1109/1


github.com/docker/docker security vulnerabilities

security vulnerabilities on github.com/docker/docker v24.0.7 will it be addressed on 3.14.4 release?

https://github.com/helm/helm/issues/12911


Implement defragmentation of MemoryMappedList

Description:
For performance reasons, vectors are only marked as removed with a tombstone Guid when they are removed with MemoryMappedList.Remove(vector). The aim is to implement a method that removes all tombstoned Guids from the index as well as the associated data. The method should reorganize the index file and the data file, so that there are no empty blocks between actual records.
Tasks:

Research and implement a method that removes old vectors.
Write unit tests to ensure the correctness and performance of the defragmentation process.

Resources:

MemoryMappedList.Defrag()

Impact:
The memory mapped file will not grow indefinitely any more, as vectors are removed or updated.
How to Contribute:

Fork the repository and create a new branch for your changes.
Implement the defrag method
Ensure all new and existing tests pass.
Submit a pull request with a detailed description of the changes.

Merged branch into master --> feat: Defrag() and DefragBatch(), along with tests.
Defrag() does a whole-file defragmentation.
DefragBatch() performs defragmentation in batches of 100 vectors.
Empty space is not reclaimed because I didn't want to shrink the file when deletions occur. I may need to revisit this after testing on different OSes.


add: mkdir -p  logic for DataAdapter

Steps to reproduce:
https://github.com/obsidianmd/obsidian-api/blob/1b4f6e2e5753c8ac2d538bc5d55c38f228450cb2/obsidian.d.ts#L724

Adapter.mkdir is automatically recursive.


Allow crossOrigin and alt to be controlled

crossOrigin="anonymous" can sometimes break croppers using data-url based images

Cropper already handles crossOrigin itself so default to that attribute not being present

"picture" is not always the best alt, so also allow that to be controlled

thanks


Publish hedgehog-extras on Hackage

Or move relevant parts to hedgehog.

https://hackage.haskell.org/package/hedgehog-extras


Node missed lots of rewards

Describe the bug
Node is online since the of testnet2, was accruing rewards but looks like it stopped accruing for some time, and the Uptime disappeared.
Expected behavior
Expected to continue to accrue rewards given the node remained online and continuously finalized bundles since joining the network.
Screenshots

Additional context
config.log.zip

This has been resolved.


Expose VB/IB created by GeometricPrimitive

The existing GeometricPrimitive implementation hides the code that creates the vertices and indices for the various built-in shapes. Ideally there should be a way to create the verts/indices, modify them, and then create your own VB/IB to render with. This would (a) allow for custom modifications and tricks on existing content, and (b) simplify the DX12 work to come that will need to share the procedural creation code but can't share the same VB/IB creation.

Filed based on this [StackOverflow](http://stackoverflow.com/questions/32853869/directxtk-geometricprimitive-texture-coordinates] question.

In addition to returning the original data as a vector of vertices and a vector of indices, also needs an easy way to create a custom GeometricPrimitive from modified data.

Fixed with 21c8b0c8908b2aa674a1420ebcde72e1deb84bcb


Docker log not working

Information
When I access the log of the docker container it is not showing the console output anymore. Before I could see all the server logs there, but now it only shows the setup. I am running this docker on unRAID.
Server Specs

OS: unRAID 6.8.3
CPU: AMD Ryzen 5 3600
RAM: 32 GB DDR4
SSD: Intel 660p

Screenshot

Can you provide the docker run or equivalent to show how this container is configured?

This is what unRAID does for the run
docker run -d --name='minecraft' --net='bridge' -e TZ="Europe/Berlin" -e HOST_OS="Unraid" -e 'TYPE'='SPIGOT' -e 'VERSION'='1.15.2' -e 'EULA'='True' -p '25565:25565/tcp' -p '8123:8123/tcp' -v '/mnt/user/appdata/minecraft/':'/data':'rw' 'itzg/minecraft-server'
Port 8123 is for the Dynmap

I was able to recreate the same problem; however, it seems to be a bug in Spigot since it seems to be stuck in a CPU busy state. Using the Java 13 image label fixed it though: itzg/minecraft-server:adopt13

I'm also not sure why https://getbukkit.org/ seems to be provided an outdated version of Spigot 1.15.2. Maybe the Java 8 bug will go away once getbukkit updates their copy.

I tried the adpot13 tag. It works, thanks!


OTA Release 2.6.0

Security upgrades
Prepare for Mental Health Playback full rollout
Improve iPad Screen layouts and refactor code.
Fix to Privacy Policy

Let's do this 👍


Could not export onnx.

I tried export.py but could not do it because it didn't get the right input.
2022-10-28 04:02:25,943   INFO  ==> Loading parameters from checkpoint ./pointpillar_7728.pth to CPU
Traceback (most recent call last):
  File "exporter.py", line 150, in <module>
    main()
  File "exporter.py", line 134, in main
    output_names = ['cls_preds', 'box_preds', 'dir_cls_preds'], # the model's output names
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/__init__.py", line 365, in export
    export_modules_as_functions,
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/utils.py", line 178, in export
    export_modules_as_functions=export_modules_as_functions,
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/utils.py", line 1097, in _export
    dynamic_axes=dynamic_axes,
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/utils.py", line 737, in _model_to_graph
    graph, params, torch_out, module = _create_jit_graph(model, args)
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/utils.py", line 611, in _create_jit_graph
    graph, torch_out = _trace_and_get_graph_from_model(model, args)
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/onnx/utils.py", line 527, in _trace_and_get_graph_from_model
    model, args, strict=False, _force_outplace=False, _return_inputs_states=True
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/jit/_trace.py", line 1179, in _get_trace_graph
    outs = ONNXTracedModule(f, strict, _force_outplace, return_inputs, _return_inputs_states)(*args, **kwargs)
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/jit/_trace.py", line 134, in forward
    self._force_outplace,
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/jit/_trace.py", line 120, in wrapper
    outs.append(self.inner(*trace_inputs))
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/rjh1016/anaconda3/envs/openpcdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1118, in _slow_forward
    result = self.forward(*input, **kwargs)
**TypeError: forward() missing 1 required positional argument: 'batch_dict'**

I guess the model architecture is still same with the OpenPCDet. But I don't know what to do first to export onnx from this file.
My torch version is 1.12.1+cu102, cuda version is 11.3 and onnx version is 1.12.0

@Domwis-IR I am working on the same issue. Did you solve it?

@Domwis-IR this was due to using the wrong version of PCDet

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule

Thank you so much, can you share the version of pcdet which is available? Looking forward your reply.

@rjwb1

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule
@rjwb1 I built the image using the dockerfile you provided, and used the container created from the image .

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule
@rjwb1 I built the image using the dockerfile you provided, and used the container created from the image . But the command "python exporter.py --ckpt pointpillar_7728.pth"could not do it.Could you provide some help?

Could you provide more information about the issue? Perhaps the traceback

@rjwb1 Thanks for your replytation! I uesd your dockerfile for builting container and then solved problem.Thanks!

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule
@rjwb1 I built the image using the dockerfile you provided, and used the container created from the image . But the command "python exporter.py --ckpt pointpillar_7728.pth"could not do it.Could you provide some help?

Could you provide more information about the issue? Perhaps the traceback

May I ask what environment your docker is in? x86 or Xavier/Orin？

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule
@rjwb1 I built the image using the dockerfile you provided, and used the container created from the image . But the command "python exporter.py --ckpt pointpillar_7728.pth"could not do it.Could you provide some help?

Could you provide more information about the issue? Perhaps the traceback

the wrong message

This docker file is for x86. Please check the README.md inside the docker directory for usage

@Domwis-IR this was due to using the wrong version of PCDet. To solve this I created a docker container with torch 1.8.1 and PCDet at the HEAD reference by the submodule
@rjwb1 I built the image using the dockerfile you provided, and used the container created from the image . But the command "python exporter.py --ckpt pointpillar_7728.pth"could not do it.Could you provide some help?

Could you provide more information about the issue? Perhaps the traceback

 the wrong message

You can modify the last two lines in your Dockerfile(add "-c"),like this:
ENTRYPOINT ["/bin/bash", "-c"]
CMD ["/bin/bash", "-c"]

I'm still working on this issue. I'd like to keep to the current version of OpenPCDet so that I can use the latest models and features. If anyone has made progress using version 0.6.0+, please let me know.

Do you have any progress?I can not find the difference of v0.5 with v0.6,looking forward your reply! Thank you very much!!

I'm still working on this issue. I'd like to keep to the current version of OpenPCDet so that I can use the latest models and features. If anyone has made progress using version 0.6.0+, please let me know.

Do you have any progress? I can't find the difference that led to the problem between v0.5 and v0.6. I'm looking forward to your reply. Thank you very much!

I can't find the difference that led to the problem between v0.5 and v0.6. I'm looking forward to your reply, too.

Is there any progress about openPCDet v0.6?

Yes,I have solved this problem with openPCDet v0.6.
x @.***> 于2024年8月19日周一 11:06写道：

Is there any progress about openPCDet v0.6?
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA-AI-IOT/CUDA-PointPillars/issues/72#issuecomment-2295579725,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGZ2ABY4V4MZGALDODGCZHDZSFOJTAVCNFSM6AAAAAARQVWSSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGU3TSNZSGU
.
You are receiving this because you commented.Message ID:
@.***>

Is there any progress about openPCDet v0.6?

You can contact me through my WeChat account meng13671.


Show placeholder if no templates registered for resource type

Currently, if you have no registered templates for a resource type and go into the create resource panel for that type, it will just show a blank area.
We should have a placeholder explaining that you need to publish and register templates for them to appear in the create menu, and can also direct users to the appropriate documentation pages for this process.

Or should the new resource button just be hidden? In the case of user resources, might be there are no templates.

That would require doing a fetch of the templates wherever the button is displayed, instead of when it is clicked to open the panel; plus I think its a bit more user friendly to explicitly show that there are no templates registered so they're not wondering if they don't have permission to create new or other reasons why the button isn't appearing

PR for approval #2428


URL to NetCoreHartIpClient = broken

Dear sir/madam,
The URL to the 'NetCoreHartIpClient'-repo is broken, is there any chance this URL could be fixed-/the 'NetCoreHartIpClient' is reuploaded?
Thanks in advance.

FieldComm Group decided against releasing the source code for this client.  The Windows installer for this client is bundled with the HART Test System and the paid HART-IP Developer Kit.


Revert "Add network policy for CPNS access from CSNS"

Reverts IBM/ibm-common-service-operator#802
https://github.ibm.com/IBMPrivateCloud/roadmap/issues/54033#issuecomment-45904423

/approve


Added P4runtime Rules for Service

Signed-off-by: Vishalakshi<EMAIL_ADDRESS>

will come back with roll back mechanism and other enhancements


[Draft] Cosign Signing Integration

This PR integrates cosign for image signing as specified in RFC #694
When an operator attaches a cosign formatted secret (contains at least cosign.key data key) to the service account used for building the image, the image will then attempt to be signed after it has been built and pushed to a repository.
Status: Draft
Currently, we are opening this draft PR to get an early review of our current implementation. There are still features that have not been implemented as listed in the Features checklist below.
Features:

[x] Signing when keys are mounted for buildPod scenario
[x] Signing when keys are mounted for rebasePod scenario
[x] Add static annotations to signature for build number and build timestamp
[x] Support custom annotations to be added to signature
[ ] Support for alternative registry for built image vs cosign signature
[ ] Support for legacy docker media type
[ ] Signing/Verifying builder/clusterBuilder images

We had some questions which are added as comments to help organize discussion.

Asking for assistance and insight:

go.mod: with the introduction of cosign, there are different version of dependencies that were indirectly imported. We currently are using a replace to force them to a version. When we run go mod tidy or anything else, it generally updates the versions in the go.mod. For example, k8s.oi/api is v0.20.7, however the previous command updates it to v0.21.3. Is there a way to prevent or improve this?

Asking for assistance and insight:

pkg/cosigner/image_signer.go: For testing purposes, we used cliSignCmd = cli.SignCmd so that we can override this function during testing to validate parameter input while ignoring its functionality. Is this an appropriate approach or is there another best practice? We didn't see or find any particular mocking/mock generating libraries being included or other examples in the code when we first looked.

Codecov Report

Merging #817 (d8d8b85) into main (8bc10b2) will decrease coverage by 0.03%.
The diff coverage is 84.53%.

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   67.78%   67.74%   -0.04%
==========================================
  Files         112      114       +2
  Lines        4836     4877      +41
==========================================
+ Hits         3278     3304      +26
- Misses       1190     1199       +9
- Partials      368      374       +6

Impacted Files
Coverage Δ

pkg/apis/build/v1alpha2/build_types.go
100.00% <ø> (ø)

pkg/apis/build/v1alpha2/image_types.go
50.00% <ø> (ø)

pkg/cosigner/image_signer.go
74.35% <74.35%> (ø)

pkg/apis/build/v1alpha2/cosign_validation.go
83.33% <83.33%> (ø)

pkg/apis/build/v1alpha2/build_pod.go
96.07% <93.02%> (-0.70%)
:arrow_down:

pkg/apis/build/v1alpha2/image_builds.go
61.24% <100.00%> (+0.30%)
:arrow_up:

pkg/apis/build/v1alpha2/image_validation.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc10b2...d8d8b85. Read the comment docs.

Please dont merge yet

Squashed. Rebased. Thanks a bunch @tomkennedy513 for the help!
Tests Passed. Manually looked over diff and didn't see anything wrong with the squash.
Manually tested building an Image with cosign features and it worked (with a small adjustment to build_pod.go with a nil check and creation of NodeSelector map).
Should be good to merge at this moment :D 🎉

Hmm, small change is required.
If I build an image without cosign, it is trying to look into the cosign secret folder but it doesnt exist because no secrets were mounted there.
Going to make a small adjustment to log there instead of returning an error

Apart from that change, thanks @tomkennedy513 for your help with the squash!
If people are okay with that adjustment I made in the above comment/commit, then this PR is otherwise good to go!


RetryPolicy supports retry_on "no healthy upstream" in LB subsets

RetryPolicy currently supports various retry condition at route level.
Envoy also supports load balancer subsets for a given cluster. However, when the RetryPolicy is NOT triggered when:

fallback_policy: NO_FALLBACK, and
lb_endpoints doesn't have any lb_endpoint that matches the "envoy.lb" filter_metadata, or there is endpoint of the lb_endpoint is not healthy.

Our use case is to select a filter to pick a specific endpoint by setting the "envoy.lb" filter_metadata in the dynamicMetadata in SteramInfo. We also use EDS to update the endpoints information. There can be a race between filter setting the filter_metadata vs EDS update being consumed by Envoy, which results in "no healthy upstream" error.
We assume the EDS will be available "soon". The simple solution to solve the race is to set up a RetryPolicy to retry on "no healthy upstream" error.
Example Envoy config (EDS is not configure, but it shows the idea):
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 9090
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          stat_prefix: ingress_http
          codec_type: AUTO
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains:
                - "*"
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: upstream
                  timeout: 300s
                  retry_policy:
                    retry_on: 5xx,reset,connect-failure,refused-stream
                    num_retries: 1000
                    per_try_timeout: 1s
          http_filters:
          - name: envoy.router

  clusters:
  - name: upstream
    connect_timeout: 5s
    type: STRICT_DNS
    lb_policy: LEAST_REQUEST
    lb_subset_config:
      fallback_policy: NO_FALLBACK
      subset_selectors:
        - keys:
          - target
    load_assignment:
      cluster_name: upstream
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: <IP_ADDRESS>
                port_value: 8080
          metadata:
            filter_metadata:
              envoy.lb:
                target: "target_1"
    health_checks:
      - no_traffic_interval: 1s
        timeout: 1s
        healthy_threshold: 1
        tcp_health_check: {}
        interval: 30s
        unhealthy_interval: 30s
        unhealthy_threshold: 1

cc @zuercher @snowp for comment.

This feature request is relatively low priority for us, coz we planned to use CDS instead.
@htuch

I think it's going to be difficult to do because IIRC the set of hosts known to the load balancer is constant. Membership updates create a new load balancer and that updated load balancer isn't visible in the context of the request that's routing to an empty subset.

I think it would be possible, as retries include a delay before issuing the next request. Since the retries are fired from timers on the dispatcher, it would be possible that a new update has been applied to the TLS cluster that reflects the new subsets between the retry being scheduled and executed.


Allow Ansible to run using Python 3

Some newer distros default to Python 3 by default, not 2, which causes Ansible to trigger these rules.

lgtm

The cause of the test failures was a different sysdig change that was fixed in https://github.com/falcosecurity/falco/pull/635. I'll go ahead and merge these changes.


Update Aruba and fix tests

This will lock all gems to a specific version, updates aruba to the latest version and fixes the tests
Fixes #37
Fixes #38
Fixes #53
TODO
Bump min. Ruby version due to updated dependencies.

Closed in favour of another PR.


SECENGSP-6474: Fix failing enterprise contracts

No need to have all the pipelines built. This is outside compilation (at this moment)


[SPARK-5956][MLLIB] Pipeline components should be copyable.

This PR added copy(extra: ParamMap): Params to Params, which makes a copy of the current instance with a randomly generated uid and some extra param values. With this change, we only need to implement fit and transform without extra param values given the default implementation of fit(dataset, extra):
def fit(dataset: DataFrame, extra: ParamMap): Model = {
  copy(extra).fit(dataset)
}

Inside fit and transform, since only the embedded values are used, I added $ as an alias for getOrDefault to make the code easier to read. For example, in LinearRegression.fit we have:
val effectiveRegParam = $(regParam) / yStd
val effectiveL1RegParam = $(elasticNetParam) * effectiveRegParam
val effectiveL2RegParam = (1.0 - $(elasticNetParam)) * effectiveRegParam

Meta-algorithm like Pipeline implements its own copy(extra). So the fitted pipeline model stored all copied stages (no matter whether it is a transformer or a model).
Other changes:

Params$.inheritValues is moved to Params!.copyValues and returns the target instance.
fittingParamMap was removed because the parent carries this information.
validate was renamed to validateParams to be more precise.

TODOs:

[ ] add tests for newly added methods
[ ] update documentation

@jkbradley

Merged build triggered.

Merged build started.

Test build #31451 has started for   PR 5820 at commit b642872.

Test build #31451 has finished for   PR 5820 at commit b642872.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

abstract class Evaluator extends Params

abstract class PipelineStage extends Params with Logging

class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31451/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #31537 has started for   PR 5820 at commit 819dd2d.

Test build #31537 has finished for   PR 5820 at commit 819dd2d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31537/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #31543 has started for   PR 5820 at commit 282a1a8.

Test build #31543 has finished for   PR 5820 at commit 282a1a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31543/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #31594 has started for   PR 5820 at commit 463ecae.

Merged build triggered.

Merged build started.

Test build #31600 has started for   PR 5820 at commit 93e7924.

Test build #31600 has finished for   PR 5820 at commit 93e7924.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31600/
Test FAILed.

Merged build finished. Test FAILed.

Test build #31594 has finished for   PR 5820 at commit 463ecae.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31594/
Test PASSed.

I like this approach, and it cleaned up and lowed the maintenance burden a lot.

Merged build triggered.

Merged build started.

Test build #31668 has started for   PR 5820 at commit b2927b1.

Test build #31668 has finished for   PR 5820 at commit b2927b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31668/
Test PASSed.

Is this syntax a little cumbersome?
lrModel.parent.extractParamMap()
cvModel.bestModel.parent.extractParamMap()

Should we keep fittingParamMap() as an alias in Model for parent.extractParamMap()?

I just made a quick pass so far, but I like the changes.  I worry about it being hard to select PipelineModel stages, but it's hard to think of a good fix.  Later on, we could re-introduce selecting stages in the old way, where it could return a sequence of stages matching the given PipelineStage.

Merged build triggered.

Merged build started.

Test build #31683 has started for   PR 5820 at commit 05229c3.

Test build #31683 has finished for   PR 5820 at commit 05229c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31683/
Test PASSed.

Merged build finished. Test PASSed.

@jkbradley The problem of fittingParamMap is that it doesn't tell you what the estimator it, while a model could be produced by different estimators. Since this PR blocks all work in the spark.ml package, shall we address this in a separate PR?

Merged build triggered.

Merged build started.

Test build #31734 has started for   PR 5820 at commit 7bef88d.

Test build #31734 has finished for   PR 5820 at commit 7bef88d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31734/
Test PASSed.

LGTM

Merged into master and branch-1.4. I will address comments in a follow-up PR. Thanks for reviewing!

@mengxr  Good point about it being unclear which Estimator produced the Model.  Not including fittingParamMap sounds fine.

LGTM too.  My comments were all small items.

A few more to-do items

CrossValidator should make a copy of its underlying Estimator and Evaluator (same for CrossValidatorModel and its underlying Model).  CV also needs to make sure its estimatorParamMaps are mapped from the old estimator to the copy (with a different UID).

After copying a Params instance, all of the parameters are explicitly set.  (I.e., default values are copied to explicitly set values.)  That's a little odd.


Bluespace anomaly teleports borg positronic brains out the chassis

Description
When a bluespace anomaly pulses near a cyborg with a positronic brain, the positronic brain is teleported separately from the chassis. This does not appear happen to MMIs.
Reproduction
Bluespace anomaly pulse next to a cyborg. Positronic brain is no longer in chassis.
Screenshots
https://github.com/space-wizards/space-station-14/assets/44417085/cd2cdbcb-208c-4b8b-a0e6-063ca22e4670
https://github.com/space-wizards/space-station-14/assets/44417085/9a5b8f18-1897-47d2-a76f-1a2fb2c7ca89
https://github.com/space-wizards/space-station-14/assets/44417085/f3f8e45a-ff97-4851-829a-bf44acba574b

It’s pretty insignificant until bluespace anom caused assault borg’s brain to teleport out of the chasis


#37 react router integration

closes #37

Codecov Report

Merging #39 into master will decrease coverage by 18.63%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master      #39       +/-   ##
===========================================
- Coverage   98.36%   79.73%   -18.64%
===========================================
  Files          15       24        +9
  Lines         184      227       +43
  Branches       43       46        +3
===========================================
  Hits          181      181
- Misses          2       45       +43
  Partials        1        1

Impacted Files
Coverage Δ

.../examples/use-location-state/01-simple/src/App.tsx
100% <ø> (ø)
:arrow_up:

...ation-state/01-simple/src/pages/QueryStateDemo.tsx
100% <ø> (ø)

...outer-use-location-state/src/components/Header.tsx
0% <0%> (ø)

...er-use-location-state/src/pages/QueryStateDemo.tsx
0% <0%> (ø)

...ocation-state/src/components/QueryStateDisplay.tsx
0% <0%> (ø)

...ples/react-router-use-location-state/src/index.tsx
0% <0%> (ø)

...amples/react-router-use-location-state/src/App.tsx
0% <0%> (ø)

...t-router-use-location-state/src/components/Nav.tsx
0% <0%> (ø)

...ter-use-location-state/src/useHistoryQueryState.ts
0% <0%> (ø)

...ation-state/src/react-router-use-location-state.ts
0% <0%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47e19f...8ad9dc3. Read the comment docs.


[Workaround / Idea] Automatically click "Reject All" for Google Search in Private (anonymous) Browsing

Hi @oblador, thanks you for such a great product — hush!
Problem
According to the following issues — it seems there no strait forward way to handle Google's cookie banner as other banners w/o broking website:

https://github.com/oblador/hush/issues/223
https://github.com/oblador/hush/issues/21

Suggested Solution
What if:

Find the "Reject All" button by XPath (IDs, classes might be dynamic, but the following XPath should remain constant):

Click this button with code like:

document.getElementById('{button-id-found-by-xpath}').click();

@oblador, what do you think — might this work?

Hi, this won't work while also being 100% private as this extension aims to be. Any extension that does this could in theory track your browsing and obtain CC details etc, and would also by definition be slower. I know the tradeoffs, but for me personally I this is one of the main selling points, and there are a bunch of other alternatives that do the opposite for those that prioritise differently. Hope you understand! 👍

Hi Joel,
I do understand and appreciate your response with such detail and the
reasoning behind it 🙌
Best regards,
Oleg V.
On Sun, 21 Jan 2024 at 11:06, Joel Arvidsson @.***>
wrote:

Hi, this won't work while also being 100% private as this extension aims
to be. Any extension that does this could in theory track your browsing and
obtain CC details etc, and would also by definition be slower. I know the
tradeoffs, but for me personally I this is one of the main selling points,
and there are a bunch of other alternatives that do the opposite for those
that prioritise differently. Hope you understand! 👍
—
Reply to this email directly, view it on GitHub
https://github.com/oblador/hush/issues/264#issuecomment-1902577169, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMSDSIQ6QOEFNWHVWJQBJLYPTSCTAVCNFSM6AAAAAA6AMXQE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3TOMJWHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Improvements to plots of fitted values

Include prediction intervals using data collected from bootstrapping on the variance of fitted values.
Plotting fitted values can be done with a user-specified number of points to get a smoother curve.

Feedback from Predici on Observed & Fitted curves that include mean and standard deviations of fitted values from bootstrap.
As an added feature, would it be possible to surround this third (optimum) curve with a shaded area, representing (in some sense) the "95% confidence interval" ? This would be a measure most medical doctors and biologists would readily understand, and the results could be easier to publish in more publications, even those less mathematically savy .
Again, this is just a suggestion for the package to be, and maybe useful for a larger group, not a requirement.

What is being requested is a confidence interval around the fitted values. This can be done using a bootstrap approach in which residuals for the simulation for a set of parameters are used to estimate standard deviations. The desired output is a shaded region, not error bars.

Other possible plots can be seen in Chapter 11.6 of Herbert's Pathways Modeling Book.

Implemented band plots to describe confidence regions for fitted values.


adds lint-mode flag to helm template

What this PR does / why we need it:
Adds --lint-mode flag to helm template command. This allows one to execute helm template command successfully when required values are missing.
Special notes for your reviewer:
The lint-mode flag had already been added but it remained internal. This PR will expose the flag to the user.
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Hey @joejulian, Any update on this?

What this PR does / why we need it:
Adds --lint-mode flag to helm template command. This allows one to execute helm template command successfully when required values are missing.

For my understanding, why will this be useful? Certainly, Helm could ignore required values and render the templates. But the results are likely to be ill-formed in this case? (helm lint also renders the templates, but that just shows that gotemplate accepts them. And it discards the results)


Virus alert

Last script 1.2 is clean and no problem at all but 1.3 having issue with virus. It was just a crack method and using registry key and IDMAN.exe to replace official IDMAN.exe. If it is crack, it may not be update or it will show registered with fake serial...... warning. Don't know why 1.3 is difference with 1.2. I feel it is not safe.

The latest version will be updated as soon as possible, and you are right about the method—it's completely safe. Script version 1.2 is backdated now; it will not be able to fulfill your requirements.


More robust handling of exceptions inside share manager ECS task

Right now if an exception is raised inside approve_share of revoke_share job the status of the share will be stuck in "in_progress" state. What do we need to do:

Move share object status update to "finally" job
In case dataset_lock is failed to be released, we need to think about expiry mechanism
Dataset_lock can be a piece of information we may want to show in UI

Hi @SofiaSazonova I am working on the share managers a lot in https://github.com/data-dot-all/dataall/issues/1283. This could be a part X in the list of items to improve the sharing. I have added it to the list of todos

Along with the share manager, please check out this issue to add robust handling in ECS task for share verifier - https://github.com/data-dot-all/dataall/issues/1300


Problem with resource loading etc.

Hello, I am trying to make a "Skyrim - Themed" Modpack with whole Story, Quest,.. etc but there is one problem. I trying to make a Skyrim designed Minecraft menu, but there is a problem with the loading of resources (or with something else, Im not into coding or something). So what exacly happening is that some textures are missing and they were repaced with pink/black cancer or in case of the backround the backround is just black (480x270). By the way I am using CustomMainMenu with Resource Loader.
Paths: 1. ".minecraft\resources\Skyrim\textures\backround"
2. ".minecraft\resources\Skyrim\textures\gui"
3. ".minecraft\resources\Skyrim\textures\logo"
mainmenu.json:
{
"images":
{
"title":
{
"image" : "Skyrim:/textures/backround/image.png",
"posX" : -238,
"posY" : 222,
"width" : 512,
"height" : 512,
"alignment" : "top_center"
}
},
"buttons":
{
    "singleplayer":
    {
        "text" : "Einzelspieler",
        "posX" : 150,
        "posY" : 48,
        "width" : 98,
        "height" : 20,
        "texture" : "Skyrim:textures/gui/buttonspielen.png",
        "action" :
        {
            "type" : "openGui",
            "gui" : "singleplayer"
        }
    },

    "multiplayer":
    {
        "text" : "Mehrspieler",
        "posX" : 150,
        "posY" : 62,
        "width" : 98,
        "height" : 20,
        "texture" : "Skyrim:textures/gui/buttonserver.png",
        "action" :
        {
            "type" : "openGui",
            "gui" : "multiplayer"
        }
    },

    "options":
    {
        "text" : "Optionen",
        "posX" : 150,
        "posY" : 76,
        "width" : 98,
        "height" : 20,
        "texture" : "Skyrim:textures/gui/buttonoption.png",
        "action" :
        {
            "type" : "openGui",
            "gui" : "options"
        }
    },

    "quit":
    {
        "text" : "menu.quit",
        "posX" : 150,
        "posY" : 100,
        "width" : 98,
        "height" : 20,
        "texture" : "Skyrim:textures/gui/buttonbeenden.png",
        "action" :
        {
            "type" : "quit"
        }
    },

    "refresh":
    {
        "text" : "",
        "posX" : -154,
        "posY" : 132,
        "width" : 20,
        "height" : 20,
        "texture" : "custommainmenu:textures/gui/buttons.png",
        "action" :
        {
            "type" : "refresh"
        }
    }
},

"texts":
{

},

"other":
{
    "image":
    {
        "image" : "Skyrim:textures/backround/image.png",
		"mode" : "stretch"
    }
}

}
So what I would to know is if I did something wrong or if there is some bug or something becouse I made the same thing I think one or two jears ago and everything was perfectly working. And is there anything to think of when youre making a new backround like size or something? If you need something like logs just tell me and I going to screenshot it or copy paste it to you.

Do you have resource loader installed?

You misspelled the source address. It should be: "image" : "Skyrim:textures/backround/image.png", if your first folder in the resource folder is: Skyrim. Then you just need to do forward slash until you get to the right .png file.
Oh, there seems to be a bug that you can't have capital letter in either the folder or file names. And the mod that loads the custom resources (Resource Loader) only loads stuff to the game at launch. So if you want to add a new file to your menu, you need to restart the game. Otherwise it will say it doesn't exist. The refresh button only refresh the script, not the resources. Hopefully this will help! :D

I'm having a similar issue, however I'm not using resource loader. I just want to add in a custom menu background for my modpack (1.7.10, TCG's Chill Pack):
"background":         {             "image" : "file:chillpack:textures/gui/background.png",             "mode" : "fill"         }
path to file from within the instance is resources/chillpack/textures/gui/background.png
I've restarted the client multiple times, and @Shazuli's comment is the closest I've been to getting this to work, but I'm still getting this:

In order to have custom stuff in your meny @janagyjr you need to have Resource Loader installed. There is no way around it am I afraid. The RL mod uses a library that handles Input and Output (IO) (hence the error: java.io.FileNotFoundException). The CMM mod is almost useless without RL, the only thing you can use then is files that are already loaded, such as: Mods content, vanilla Minecraft textures, etc. That is also why if you add a new resource to your folder you have to re-start the game in order to put everything back into RAM. That is why it sometimes takes so long for MC with many mods installed to load. It goes through every single file and loads it into the game.
If you still have problem with getting your custom background to work I'll send you a copy of a project I never finished you can use as preference.

Oh my goodness, why even have them as separate mods then?!
Thanks for the help.

Oh my goodness, why even have them as separate mods then?!

Because Resource Loader can be used without CMM? You can use it to load custom stuff for other mods or override resources without a texture pack.

Im having also a similar issue, the button texture does not show. the button json:
"LukasYT":
{
"text" : "",
"posX" : -180,
"posY" : 132,
"width" : 20,
"height" : 20,
"texture" : "modpack:textures/YTButton.png",
"action" :
{
"type" : "openLink",
"link": "https://bit.ly/SubToLukas"
}
},
and the YTButton.png's path from the instance is (CoolMods is name of my instance you can think it as .minecraft) CoolMods/resources/modpack/textures/YTButton.png

oh, it works! i restarted the game and the images appeared

Hello there, I installed Custom Main Menu mod, as well as Resource Loader (1.12.2 with other mods (82 in total) + optifine), followed your steps, and, an image I want to be displayed, appears in black & pink/purple (It's some kind of band on the left with the different buttons displayed above it). Can you help me to figure out what's wrong?
here is the location of the file (it is called 'transparent.png'):

and here's the config, it's located in 'bandeau' section, everythings works except that:
{
"images":
{
"bandeau":
{
"image" : "custommainmenu:textures/gui/transparent.png",
"posX" : -310,
"posY" : 0,
"width" : 224,
"height" : 373,
"alignment" : "top_center"
},
"title":
    {
        "image" : "custommainmenu:textures/gui/minecraft.png",
        "posX" : -298,
        "posY" : 20,
        "width" : 375,
        "height" : 375,
        "alignment" : "top_center"
    },

    "edition":
    {
        "image" : "custommainmenu:textures/gui/edition.png",
        "posX" : -235,
        "posY" : 47,
        "width" : 96,
        "height" : 12,
        "alignment" : "top_center"
    }

},

"buttons":
{
    "singleplayer":
    {
        "text" : "menu.singleplayer",
        "posX" : -298,
        "posY" : 28,
        "width" : 200,
        "height" : 20,
        "action" :
        {
            "type" : "openGui",
            "gui" : "singleplayer"
        }
    },

    "multiplayer":
    {
        "text" : "menu.multiplayer",
        "posX" : -298,
        "posY" : 52,
        "width" : 200,
        "height" : 20,
        "action" :
        {
            "type" : "openGui",
            "gui" : "multiplayer"
        }
    },

    "mods":
    {
        "text" : "fml.menu.mods",
        "posX" : -298,
        "posY" : 76,
        "width" : 74,
        "height" : 20,
        "action" :
        {
            "type" : "openGui",
            "gui" : "mods"
        }
    },

    "options":
    {
        "text" : "menu.options",
        "posX" : -220,
        "posY" : 76,
        "width" : 74,
        "height" : 20,
        "action" :
        {
            "type" : "openGui",
            "gui" : "options"
        }
    },

    "quit":
    {
        "text" : "menu.quit",
        "posX" : -298,
        "posY" : 100,
        "width" : 200,
        "height" : 20,
        "action" :
        {
            "type" : "quit"
        }
    },

    "language":
    {
        "text" : "",
        "posX" : -142,
        "posY" : 76,
        "width" : 20,
        "height" : 20,
        "action" :
        {
            "type" : "openGui",
            "gui" : "languages"
        }
    },

    "refresh":
    {
        "text" : "",
        "posX" : -118,
        "posY" : 76,
        "width" : 20,
        "height" : 20,
        "texture" : "custommainmenu:textures/gui/buttons.png",
        "action" :
        {
            "type" : "refresh"
        }
    }
},

"labels":
{
    "modpack name":
    {
        "text" : "Custom Minecraft 1.12.2 ModPack",
        "hoverText" : "§nCustom Minecraft 1.12.2 ModPack",
        "posX" : -618,
        "posY" : -20,
        "color" : -1,
        "alignment" : "bottom_right",
        "action" :
        {
            "type" : "openGui",
            "gui" : "credits"
        }
    },

    "fml":
    {
        "text" : "",
        "posX" : 23,
        "posY" : -70,
        "color" : -1,
        "alignment" : "bottom_left"
    }
},

"other":
{
    "splash-text":
    {
        "posX" : -98,
        "posY" : 55,
        "color" : -256,
        "alignment" : "top_center",
        "texts" : "file:minecraft:texts/splashes.txt"
    },

    "panorama":
    {
        "images" : "minecraft:textures/gui/title/background/panorama_%c.png",
        "animate" : true,
        "animationSpeed" : 1,
        "blur" : true,
        "gradient" : true
    }
}

}
Thanks in advance (and sorry if there is some few language mistakes, I'm a 16 y/o French boy!)


Individual accounts test failures

Parent: #252
From Hub:
"The individual accounts test failures occur when the default record type is selected to be one of the HEDA types. Although the instructions (https://powerofus.force.com/articles/Resource/Install-and-Configure-the-Higher-Education-Data-Architecture-HEDA) call for selecting "Adminsistrative" as default, this caused test failures. To work around, I created a new record type (non HEDA) and selected that as the default Account record type for the SysAdmin profile. Suggested code fix: set the account record type to a type which is known to have the behavior testing for. Suggested documentation fix: recommend non-HEDA default record type for profile."

Shouldn't happen; the tests set their own default record type. Whatever value is stored in the settings shouldn't affect them. @vegad, if you are interested in digging a bit more into this please let us know. It'd be of great help. Otherwise I can take a look at it.

**lurch: add

Tracking W-010571

Clarification: this is referring to making Administrative the default for the profile, not the default in HEDA Settings.

Two test fail if Administrative is the default for the profile running the tests:
ACCT_IndividualAccounts_TEST.deleteContactNormalAccountAdministrativeAcc

ADDR_Addresses_TES.updateOrgContactToHH

Also, this only happens if Administrative is the default for the profile. All tests will pass with any other Account record type as the default, no matter if it's part of HEDA or not, except with Business Organization. If Business Organization is selected, test AFFL_AccRecordType_TEST.addRecordTypeToAcc will fail, as stated in the comments: https://github.com/SalesforceFoundation/HEDAP/blob/master/src/classes/AFFL_AccRecordType_TEST.cls#L187

This is related to https://github.com/SalesforceFoundation/HEDAP/issues/279.
Maybe we should run these tests under a specific user that we create during the test.

Included in beta release 1.15 (Beta 2)

Included in production release version 1.15


fix: folder regression, services stay in the root

Issue
Closes #210
Intent
Leave the services in root, instead of in subfolder.
Implementation
Changed the code that is creating json file content.
Checks

[x] Code is formatted correctly (npm run lint:fix).
[x] Any new functionality has been unit tested.
[x] All unit tests are passing (npm test).
Someone else must run those, my environment doesn't work.
[ ] All CI checks are green.
[x] JSDoc comments have been added or updated.

failing test ignored as relates to a seperate issue

:tada: This PR is included in version 1.18.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Refactor and fix issues in setup flow

Fixes issues with space creation when controller address doesn't match with the connected wallet (ens owner)
Changes proposed in this pull request:

Cleanup and refactor of setup components
Moved step 1 code into SetupDomain component
Add ENS address to the route on step 2-3, so that the flow can't break on reloading the page
Show message on last step if the controller doesn't match the connected wallet
Add checkbox on controller step to autofill the current account
Show message on gnosis safe when auto fill isn't checked with link to docs

TODO: add docs

@mktcode still need to add the docs. Will do that after you have approved it.


Polished README.

Enhanced README so that it's more concise.
Ready for spelling & grammar revision.

[Current coverage][cc-pull] is 100%

Merging [#48][cc-pull] into [v2][cc-base-branch] will not change coverage

@@            v2   #48   diff @@
================================
  Files        9     9
  Lines      156   156
  Methods      0     0
  Messages     0     0
  Branches     0     0
================================
  Hits       156   156
  Misses       0     0
  Partials     0     0

Powered by Codecov. Last updated by [fd77289...ee1c291][cc-compare]
[cc-base-branch]: https://codecov.io/gh/inaka/Jayme/branch/v2?src=pr
[cc-compare]: https://codecov.io/gh/inaka/Jayme/compare/fd77289ae8b3a8b8c388db506f8c05c81e1d3cb5...ee1c29146475d118cf5dad13197bba97fb71a93b
[cc-pull]: https://codecov.io/gh/inaka/Jayme/pull/48?src=pr


Error in reproducing simple example

I tried reproducing your simple example but received the following error:

TypeError                                 Traceback (most recent call last)
<ipython-input-24-b42a1aad6fb3> in <module>()
----> 1 w = SankeyWidget(links=links, margins=dict(top=0, bottom=0, left=50, right=100))
TypeError: wrap() got an unexpected keyword argument 'links'

Ok, well, the issue was solved by just restarting the notebook server...............
Sorry for the bother!

No worries, thanks for reporting it. I've seen this once but it went away and I don't know what causes it...


ffmpeg.wasm plugin needs upgrading to 0.12+

Description
The API has changed from 0.12+. Examples are also not working as it uses the latest ffmpeg version<EMAIL_ADDRESS>results in Cannot find "/dist/ffmpeg-core.js" in<EMAIL_ADDRESS>.
see: https://ffmpegwasm.netlify.app/docs/migration
Steps to reproduce
https://collab-project.github.io/videojs-record/demo/video-only-ffmpegwasm.html
Error output
ReferenceError: FFmpeg is not defined
Let me know if you'd like a PR.
Thanks for your work on the plugin!

Various demos simply do not work because of using latest unpkg links.

Various demos simply do not work because of using latest unpkg links. Audio specific ones using wavesurfer has the same issue

I'll take a look at it.


Killing the process hangs after a browser request

See https://gist.github.com/BethGriggs/2a6d0227b2747ecb72ff6d5eeb4d7977?permalink_comment_id=4221848#gistcomment-4221848

Solved in node 18.14.0
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.14.0
https://github.com/nodejs/node/issues/41578
:+1:

please don't close, I tested again and this is not 100% working...


Add TradeDirection to Tick class and in GDAX ticks

Some brokerage tick/trade messages (including GDAX) include a direction field (aka side), indicating whether the tick was a Buy or a Sell.

Closing as new feature to be implemented later on, see also: #1277


Reading Polygon with multiple holes from KML only keeps last one

Describe the bug
Reading Polygon with multiple holes from KML only keeps last one
To Reproduce

Read a KML file that contains a polygon with one outer ring and multiple inner rings into a Document
new KML().readFeatures(document);
Check the output that got read

Expected behavior
A polygon with as many holes as there are inner rings in the source KML file
Actual behavior
A polygon with one single hole (always the last one specified in the file)

There is no problem here https://codesandbox.io/s/kml-forked-jzxs7  Italy has holes for both Vatican and San Marino.

Might be dependent on the file then. I'm having issues with this one:
SingleField.zip
It contains 11 inner rings of which only the last one gets read as Feature.

innerBoundaryIs can only have one LinearRing, but you can have multiple innerBoundaryIs.
https://developers.google.com/kml/documentation/kmlreference#innerboundaryis
You also seem to be missing the xsi namespace declaration: xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance".
 Very appreciated.
The aforementioned KML was customer input. Is there any way for us to detect these circumstances? Is there a warning or error that can be passed along?

Currently this is  silently ignored.
For each node type the defined parser is invoked:
https://github.com/openlayers/openlayers/blob/3291733ab38a9f6af642ef9fe5fb0ca237cccdc9/src/ol/xml.js#L413-L424
And For LinearRing it replaces the last value
https://github.com/openlayers/openlayers/blob/3291733ab38a9f6af642ef9fe5fb0ca237cccdc9/src/ol/xml.js#L173-L190
It is initialized to undefined here
https://github.com/openlayers/openlayers/blob/3291733ab38a9f6af642ef9fe5fb0ca237cccdc9/src/ol/format/KML.js#L2216-L2224
The following patch would detect this error:
diff --git a/src/ol/format/KML.js b/src/ol/format/KML.js
index 548c0d679..9f602ad29 100644
--- a/src/ol/format/KML.js
+++ b/src/ol/format/KML.js
@@ -29,6 +29,7 @@ import {
   makeArrayPusher,
   makeChildAppender,
   makeObjectPropertySetter,
+  makeOneTimeSetter,
   makeReplacer,
   makeSequence,
   makeSimpleNodeFactory,
@@ -2206,7 +2207,7 @@ function lodParser(node, objectStack) {
  */
 // @ts-ignore
 const INNER_BOUNDARY_IS_PARSERS = makeStructureNS(NAMESPACE_URIS, {
-  'LinearRing': makeReplacer(readFlatLinearRing),
+  'LinearRing': makeOneTimeSetter(readFlatLinearRing),
 });

 /**
diff --git a/src/ol/xml.js b/src/ol/xml.js
index fe4b6884e..7c1acbffd 100644
--- a/src/ol/xml.js
+++ b/src/ol/xml.js
@@ -189,6 +189,36 @@ export function makeReplacer(valueReader, opt_this) {
   );
 }

+/**
+ * Make an object stack setter function for setting the value at the
+ * top of the stack if it has not already been set.
+ * @param {function(this: T, Node, Array<*>): *} valueReader Value reader.
+ * @param {T} [opt_this] The object to use as `this` in `valueReader`.
+ * @return {Parser} Parser.
+ * @template T
+ */
+export function makeOneTimeSetter(valueReader, opt_this) {
+  return (
+    /**
+     * @param {Node} node Node.
+     * @param {Array<*>} objectStack Object stack.
+     */
+    function (node, objectStack) {
+      const value = valueReader.call(
+        opt_this !== undefined ? opt_this : this,
+        node,
+        objectStack
+      );
+      if (value !== undefined) {
+        if (objectStack[objectStack.length - 1] !== undefined) {
+          throw new Error(`Node ${node.nodeName} already read.`);
+        }
+        objectStack[objectStack.length - 1] = value;
+      }
+    }
+  );
+}
+
 /**
  * Make an object property pusher function for adding a property to the
  * object at the top of the stack.

Although it does not comply strictly with the Google specification multiple LinearRing in a innerBoundaryIs is handled by Google Earth.  If OpenLayers can detect multiple rings it would be better to add them to the geometry instead of throwing an error.

Yeah, this is actually the reason we didn't notice anything being wrong with the KML file, because other software displays it correctly.


feat(boe): complete step 5

Deployed to https://carbon-tutorial-kriolyth.eu-de.mybluemix.net/
Changed
Updated CF manifest to avoid deprecation warning:
Deprecation warning: Use of 'buildpack' attribute in manifest is deprecated in favor of 'buildpacks'. Please see http://docs.cloudfoundry.org/devguide/deploy-apps/manifest.html#deprecated for alternatives and other app manifest deprecations.

@kriolyth Looks spectacular 💯! I've recorded your completion of step 5.

@kriolyth Feel free to stop your running application on IBM Cloud to avoid the possibility of incurring any charges.


epoch table not populated

On shelley-qa using db-sync-extended after a full sync the epoch table is empty:
cexplorer=> SELECT * FROM epoch;
 id | out_sum | tx_count | blk_count | no | start_time | end_time | fees
----+---------+----------+-----------+----+------------+----------+------
(0 rows)

This is aftera  fresh sync on deployed master version.

Ignore, someone changed the globals file to not use extended.

Hello, i've the same problem. How to solve this?

@aleincsharp As per the architecture section of the README, the table will be empty if you run the cardano-db-sync executable. It is only populated if you run the cardano-db-sync-extended executable.


Draft blog post about Botkube executors

Description
Changes proposed in this pull request:

Draft blog post about Botkube executors. This PR is only for having blog preview and getting feedback. It's not going to be merged.

Preview URL: https://blog-post.botkube-docs.pages.dev/blog/custom-executors

PS PTAL at this comment here: https://github.com/kubeshop/botkube-plugins-template/pull/7#discussion_r1087673766
It would be good to update binary name to avoid conflicts with existing gh plugin which will be merged in the template repo 🙂


We are back

This is how I felt like while coding this

closes https://github.com/hawl1/all-limiteds/issues/2

LGTM!


MacOS 10.13.1 Configure Error

I have an error when executing command
CXX=clang++ cmake ../ -DCMAKE_BUILD_TYPE=Release -DICU_ROOT=/usr/local/opt/icu4c

The error message is below.
I have a mac of 10.13.1. I have tried the develop branch and clean the cache, but it still not working. Could you please help me debug this problem? Thanks.
-- The C compiler identification is AppleClang <IP_ADDRESS>00038
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Found ZLIB: /usr/lib/libz.dylib (found version "1.2.11")
-- Looking for lzma_auto_decoder in /usr/lib/liblzma.dylib
-- Looking for lzma_auto_decoder in /usr/lib/liblzma.dylib - found
-- Looking for lzma_easy_encoder in /usr/lib/liblzma.dylib
-- Looking for lzma_easy_encoder in /usr/lib/liblzma.dylib - found
-- Looking for lzma_lzma_preset in /usr/lib/liblzma.dylib
-- Looking for lzma_lzma_preset in /usr/lib/liblzma.dylib - found
-- Could NOT find LibLZMA (missing: LIBLZMA_INCLUDE_DIR)
-- Searching for ICU 58.2
-- Found ICU: /usr/local/opt/icu4c/lib/libicudata.dylib;/usr/local/opt/icu4c/lib/libicui18n.dylib;/usr/local/opt/icu4c/lib/libicuuc.dylib (Required is at least version "58.2")
-- ICU version found is 59.1.0, expected 58.2; attempting to build ICU from scratch...
-- ICU include dirs: /Users/yufan/Documents/workspace/meta/build/deps/icu-58.2/include
-- ICU libraries: icui18n;icuuc;icudata
-- Locating libc++...
-- Located libc++: /usr/lib/libc++.dylib
-- Located libc++ include path: /Library/Developer/CommandLineTools/usr/include/c++/v1/
--     Locating libc++'s abi...
--     Found libc++abi: /usr/lib/libc++abi.dylib
-- Found LIBCXX: /usr/lib/libc++.dylib
-- Using regular malloc; consider installing jemalloc
-- Performing Test META_HAS_ALIGNED_ALLOC
-- Performing Test META_HAS_ALIGNED_ALLOC - Failed
-- Performing Test META_HAS_POSIX_MEMALIGN
-- Performing Test META_HAS_POSIX_MEMALIGN - Failed
CMake Error at deps/meta-cmake/kludges/AlignedAlloc.cmake:54 (message):
  Failed to find a suitable aligned allocation routine
Call Stack (most recent call first):
  deps/meta-cmake/CompilerKludges.cmake:18 (include)
  CMakeLists.txt:124 (CompilerKludges)

-- Configuring incomplete, errors occurred!
See also "/Users/yufan/Documents/workspace/meta/build/CMakeFiles/CMakeOutput.log".
See also "/Users/yufan/Documents/workspace/meta/build/CMakeFiles/CMakeError.log".

It seems to me it's an ICU version problem. Do you have any idea how to resolve this problem? Thanks.

@alphafan Have you solved this?

@Yevgnen No. Not resolved.

The problem is with include path generated by FindLIBCXX.cmake, it doesn't find correct installation directory which is shown in clang++ -v, instead it finds /Library/Developer/CommandLineTools/usr/include and uses it in includes while compiling aligned allocation test code (and other code eventually), you can add original installation path to your clang by adding it as a prefix (not sure why libc++ location /Library/Developer/CommandLineTools/usr/include is not working):
cmake -DCMAKE_SYSTEM_PREFIX_PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include;${CMAKE_SYSTEM_PREFIX_PATH} .. && make -j8

on MacOS 10.12, I faced the same issue. My CMAKE_SYSTEM_PREFIX_PATH points to /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include correctly, i.e.
debug: CMAKE_SYSTEM_PREFIX_PATH = /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include;/usr/local;/usr;/;/usr/local/Cellar/cmake/3.10.0;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local
debug: LIBCXX_LIB_PATH = /usr/lib
but that didn't work. So I went in to check what was going in AlignedAlloc kludges and noticed it was not able to compile ::posix_memalign(&ptr, 64, 128); while my standard AppleClang (v9) could compile and execute this code. So I used AppleClang compiler and bypassed the ENABLE_LIBCXX by setting it to OFF in CMakeLists.txt and built again. VOILA! Successful build and all unit tests passed.
TLDR: if you are getting this error on your mac, modify ENABLE_LIBCXX to be off and that should build it.
@alphafan Can you check if this works for you?

@eklavyamirani Thanks very much. After I change the line that you mentioned. (ON -> OFF), it works for me now.

@alphafan I met the similar problem with u, and I have already set ENABLE_LIBCXX from ON to OFF. It still did not work.


A bunch of code cleanup

This pull request is now out of date with the current repo and will need to have any conflicts resolved then be resubmitted

@devchallengedemo – PTAL


Add Dark Mode

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Description
[Please include a brief description of the changes or features added]
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[ ] I have performed a self-review of my code
[ ] I have read and followed the Contribution Guidelines.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@prasukjain07 add the output images of different views

@prasukjain07 add the output images of different views

Pls Check the attached ss, and review the PR

@prasukjain07 could you add a white padding to the images i think you get it.?

Yes, give me some time

@prasukjain07 could you add a white padding to the images i think you get it.?

Can you please explain a little more


Change README's installation instructions.

Now they point to the projects' github. This should make it easier to use until the next gem release comes out. At that time, the previous installation instructions should work again and replace these.
Should fix #15

@awochna thanks for this PR, we have not yet released this gem. Can you please submit a PR stated that this PR is not ready instead?

By that, do you mean submit a PR that this gem is not ready? Or a PR with instructions for both before and after a gem release?


libc: ctype: Fix operations between signed and unsigned types

MISRA-C says that char type should not be used in arithmetically as the
data doesn't represent numbers.
MISRA-C rules 10.1 and 10.2
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

Codecov Report

Merging #13971 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13971   +/-   ##
=======================================
  Coverage   52.25%   52.25%
=======================================
  Files         307      307
  Lines       45437    45437
  Branches    10508    10508
=======================================
  Hits        23741    23741
  Misses      16904    16904
  Partials     4792     4792

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2d7ca...e307767. Read the comment docs.


unknown nav command type "popToRoot"

unknown nav command {type: "popToRoot"}

Got this when pressing the back arrow from the conversation screen

i'll try this one


impl Radix for RevOrd isn’t helpful since RevOrd isn’t Copy

All the RadixHeapMap operations require K: Radix + Ord + Copy. It seems the intended way to make a min-heap is via the RevOrd wrapper, for which a Radix implementation is defined. But RevOrd can’t actually be used since it doesn’t derive Copy.
Perhaps a Radix impl for std::cmp::Reverse should be added, since Reverse derives Copy at least in 1.26 beta (rust-lang/rust#47379).

Yeah, now that std has a official reverse order wrapper, it would no doubt be best to use that. I have just pushed a bunch of changes to 0.3 to update it to more modern Rust, including Reverse support.


Add settings to project prefs update schema

The settings property should be in the ProjectPreferencesUpdate schema so that PFE can update a user's project preferences.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Eh, not really, but I'll add the settings object to the update params in the controller spec and that should be good.


pnp:NavigationNode - option to open link in new window

When provisioning navigation nodes via the pnp:NavigationNode tag, it would be great to be able to specify whether the "open link in new window" box is checked.

Hi @dgwebb,
Thanks for your feedback. Unfortunately, we don't have this capability at CSOM/REST API level, so we cannot implement this functionality.

@PaoloPia this is no longer the case - the current implementation of the savemenustate method in the REST API seems to support the OpenInNewWindow property, but the PnP provisioning schema has not caught up with that.


feature: persist theme preference on local storage

Hey, friend! :wave:
First of all, congrats for the amazing job on integrating this project with the community!
This is an enhancement on the theme choice. Now the theme is saved on the user's local storage so the chosen theme will be automatically applied on subsequent page visits.

Thanks for contributing.
Awsome job.


No inheritance between standard interfaces

if (document.body instanceof window.Node) {
  // standard
} else {
  // jsdom
}

I could fix it if someone provide me with directions.

Works for me. Which version are you on?

Cannot reproduce: https://tonicdev.com/577c4dec7da47e13004552c8/577c4dec7da47e13004552c9

ahh, sorry... my bad


Avoid renaming handle fields during extraction

Previously, static fields with a name ending in Handle were getting renamed during heap extraction (by appending an s). The renaming was never meant to apply to these roots, but rather to the container nodes for handle roots.

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   24.36%   24.36%
=======================================
  Files         199      199
  Lines      112475   112475
  Branches    11228    11228
=======================================
  Hits        27403    27403
  Misses      85045    85045
  Partials       27       27

Flag
Coverage Δ

#2015
24.36% <ø> (ø)
:arrow_up:

#2017
24.36% <ø> (ø)
:arrow_up:

#Debug
15.81% <ø> (ø)
:arrow_up:

#Release
14.89% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd9b1a...437199f. Read the comment docs.

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   24.36%   24.36%
=======================================
  Files         199      199
  Lines      112475   112475
  Branches    11228    11228
=======================================
  Hits        27403    27403
  Misses      85045    85045
  Partials       27       27

Flag
Coverage Δ

#2015
24.36% <ø> (ø)
:arrow_up:

#2017
24.36% <ø> (ø)
:arrow_up:

#Debug
15.81% <ø> (ø)
:arrow_up:

#Release
14.89% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd9b1a...437199f. Read the comment docs.


Crawler#respectRobotsTxt now also looks for nofollow robots meta tags

What this PR changes
If the default Crawler#discoverResources method finds a  tag, it will return an empty array.
Rationale
See #278

@cgiffard I've updated the 1.0.0 release note draft to include this change. I think we're good to go with the release now :shipit: I'll go ahead and publish tomorrow unless you have any objections?

@fredrikekelund Sounds good! :)

@cgiffard hehe well if you respond that promptly, then I'll go ahead and release straight away!

Aaand done! :beers: :dancer:

@fredrikekelund Awwwwww yeah. :) Thanks!
I've got a free weekend coming up (finally!) so I'm hoping to get the CLI polished up, and maybe start on a github pages thing, where we can also stuff our generated docs. :)

Ah, nice to hear! :) Would be awesome if we could intertwine the API docs with some more descriptive text content (like we have in the README right now).
I've always found Sequelize's docs to be great, and they do just that - auto-generate docs that contain more than just the global classes. I think they use the mkdocs and dox modules. Seems they have a bit of a custom setup to glue everything together, but it's good inspiration in any case

That would be good to look at. I'm thinking we can probably inline usage examples too.

I think we should definitely aim for that! Descriptive text and usage examples in more or less the same place as the raw API documentation. As for Sequelize, https://github.com/sequelize/sequelize is the repo, and http://docs.sequelizejs.com/en/v3/ is the docs site


Issue with book_append_sheet method

When I call book_append_sheet method with 2 arguments : workbook and worksheet and don't provide sheet name it adds Sheet1 as default sheet name. This is fine because no sheet name was given.
But when I add wb.SheetNames = ["mysheet"], it adds mysheet as well as Sheet1.

book_append_sheet does exactly two things: add the worksheet to the wb.Sheets object and add the name of the worksheet (defaulting to Sheet### like Excel) to the wb.SheetNames array.  If you add an extraneous name that doesn't have a corresponding worksheet, the writer generates a blank worksheet.


Bus issues

When using Node 5, which I know isn't officially supported, I get random bus errors while using app metrics.

Support for Node 5 is covered by issue #109.
I'm not sure if we'd expect to see a crash or not. What platform / OS are you running on?

OSX.

I've managed to reproduce the crash with Node 5, on Mac OSX with appmetrics installed from the master branch on github. I enabled core dumps and this is the stack trace:
(lldb) bt
* thread #1: tid = 0x0000, 0x0000000100f0a018 node`default_loop_struct + 584, stop reason = signal SIGSTOP
  * frame #0: 0x0000000100f0a018 node`default_loop_struct + 584
    frame #1: 0x00000001007803ad node`uv__async_event + 198
    frame #2: 0x0000000100780540 node`uv__async_io + 136
    frame #3: 0x000000010078f232 node`uv__io_poll + 1554
    frame #4: 0x00000001007809f3 node`uv_run + 321
    frame #5: 0x000000010065a315 node`node::Start(int, char**) + 594
    frame #6: 0x0000000100001434 node`start + 52

It matches a crash we've been seeing very intermittently on Node 4 on Linux. That's tracked under issue #174 but has been very hard to reproduce. I have a (possible) fix which I’ve now been able to stress test against Node 5 to see if I can validate the fix locally. That seems to show it’s working (I’m getting the crash around 4/10 runs without my change and so haven’t seen it with the fix) so I’ve pushed the branch up.
I’ll raise a pull request but in the meantime you could try my fix by doing:
npm install hhellyer/appmetrics#async_init_fix
if you are able to install from github and see if that resolves the issue for you.
(I am assuming you are currently installing from the Runtimetools/appmetrics master branch on github)

I think this did it. I've had it running for 20ish minutes with no problem. Thank you. :)

Can this be closed now ?

I'd say so.

Closing as fixed.


fix 0-byte file download (#132)

Range HTTP requests fail and return response code 416 if the requested range is not satisfiable - e.g. requesting a range starting from 0-bytes on a 0-byte file.
Fixes #132

Codecov Report

Merging #181 into master will increase coverage by 0.19%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master    #181      +/-   ##
=========================================
+ Coverage   86.01%   86.2%   +0.19%
=========================================
  Files          34      34
  Lines        1330    1334       +4
=========================================
+ Hits         1144    1150       +6
+ Misses        186     184       -2

Impacted Files
Coverage Δ

hca/dss/__init__.py
84.04% <75%> (+0.4%)
:arrow_up:

hca/util/exceptions.py
91.3% <0%> (+8.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f62a0...6862ecb. Read the comment docs.

We could, but I went with this option in case there were inconsistencies between the manifest data and the actual files (i.e. is the manifest data a reliable source of truth?). And yes this writes out an empty (captured in the existing tests).

Thought about it - you're right, going to skip the request if file size is 0

We could, but I went with this option in case there are inconsistencies between the manifest data and the actual files (i.e. is the manifest data a reliable source of truth?). And yes this writes out an empty (captured in the existing tests).

I think the manifest data is a pretty reliable source of truth.


Automated Package Upgrade

:tada: This PR is included in version 7.7.188 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cannot find module '../build/Release/agora_node_ext'

when i import sdk to my project throw this error

You mean using esm import? Which platform do you use? Commonly after you run npm install our sdk will be automatically built by node-gyp and generate your mssing file. Could you give more details?

yes i use esm import,here is my code

import and init

and this project i use electron + vue

Em, I find that you are using methods in our web sdk. However this repo is an electron intergration for our native sdk(for both darwin and win32). So I recommend you to run npm install agora-rtc-sdk instead and have a try.

You can find a simple JS api doc at (here)[https://github.com/AgoraIO-Community/Agora-RTC-SDK-for-Electron/blob/dev/2.2.1/docs/apis.md].
And since this repo is a wrapper for our native sdk, you can also go to (agora document center)[https://docs.agora.io/en/2.3.1] to have a look at windows/Mac api.
And we have a complete demo in E-edu at (ARD-eEducation-with-Electron)[https://github.com/AgoraIO/ARD-eEducation-with-Electron] built with react/webpack/electron.
Apart form these, we are improving our js api doc / comment / test coverage, and will commit a quick start demo recently for this sdk.

We have released a quickstart boilerplate for using this sdk. Go to #8 for more detail.


POST /beacon/validators implementation does not match documentation

https://pegasyseng.github.io/teku/#operation/postBeaconValidators
epoch is an optional key according to the docs, but Teku returns a 500 error if it is omitted in the request.
CC @rolfyone
🙂

The intent is definitely for the epoch to default and return meaningful data. I've made a fix, PR is up, I'll merge ASAP.
Thanks for bringing it to my attention.


Payload generation optimization makes performance worse

Well, I goofed. I flipped the numbers on my benchmark results for the payload generation optimization introduced in #267, and the new approach is actually slower than the old approach. There are two things to do here:

Actually make payload generation faster.
Move to a more robust benchmarking strategy.

For the latter, I'll be looking to add jmh to the project.

Well, this has certainly turned into quite the comedy of errors. Yes, I did flip the results of the previous benchmarks, but it turns out those benchmarks were bogus. Using the microbenchmarks introduced in #288, we can show that the changes introduced in #267 WERE a significant improvement:
0.6.1

Benchmark
Mode
Cnt
Score
Error
Units

testLongAsciiMessageBody
thrpt
80
7.958 ±
0.158
ops/s

testLongChineseMessageBody
thrpt
80
5.192 ±
0.027
ops/s

testShortAsciiMessageBody
thrpt
80
116843.074 ±
1220.330
ops/s

testShortChineseMessageBody
thrpt
80
155858.086 ±
651.504
ops/s

0.7.2

Benchmark
Mode
Cnt
Score
Error
Units

testLongAsciiMessageBody
thrpt
80
1189.459 ±
42.306
ops/s

testLongChineseMessageBody
thrpt
80
3175.659 ±
13.284
ops/s

testShortAsciiMessageBody
thrpt
80
119996.542 ±
888.424
ops/s

testShortChineseMessageBody
thrpt
80
155339.674 ±
852.837
ops/s

So, in short, the new approach is about the same when messages don't have to be trimmed (which makes sense) and three orders of magnitude faster in some cases when they DO need to be trimmed. In the process of building and running the benchmarks, we DID discover (and fix!) a separate issue that could cause payload generation to hang. See #287 for details.
I think this issue is now under control, and will put out a point release to address the hang as soon as possible.