Few Artist's all song download gives an error after some number of songs

Artist page URL : https://www.saavn.com/s/artist/kishore-kumar-albums/yMoPyl3ZzyY_
This happens :
Downloading all Artist songs
Total Songs of the Artist: 12193
Total requests: 1220
Getting Song page: 0
Downloading 1. Bheegi Bheegi Raaton Mein.m4a [*] 4.5 MB / 4.5 MB @ 7.8 MB/s [##################] [100%, 0s left]
..............
Downloading 48. Zindagi Ek Safar.m4a [*] 4.0 MB / 4.0 MB @ 1,013 kB/s [##################] [100%, 0s left]
error() missing 1 required positional argument: 'msg'
No songs found for the artist
DONE
I don't know why, can you give this a look?

It seems the error happened while adding meta data. Will try fixing the add_tags or will probably skip adding meta data to those songs so that the download can continue.

@adimrsingh Now it should continue to download all songs but those not available in 320kbps will not have any meta data. Hope this is a satisfying enough fix. I'll look into it sometime later. But I can't make any guarantees.

Yup, that did fixed the download issue. And It's a fair enough fix. I just added a commit to the download_manager.py , no functionality added just numbered the filename also I sent you a pull request regarding it.

@monuyadav016 I also get the same error as the OP (with the current repo)
Artist Link: https://www.jiosaavn.com/artist/mahendra-kapoor-/mzleuBtK1zU_
Relevant log in my case:
Getting Song page: 25
...
Downloading Shri Ramdev Peer Ra Shay Pasta.m4a
 [*] 68.5 MB / 68.5 MB @ 2.1 MB/s [##################] [100%, 0s left]
 [*] 68.5 MB / 68.5 MB @ 2.6 MB/s [##################] [100%, 0s left]
 [*] 68.5 MB / 68.5 MB @ 1.5 MB/s [##################] [100%, 0s left]
 [*] 68.5 MB / 68.5 MB @ 1.7 MB/s [##################] [100%, 0s left]
error() missing 1 required positional argument: 'msg'
No songs found for the artist
DONE

On running it again, the file above got downloaded successfully. After a couple more files, the error happened again:
Getting Song page: 26
...
Downloading Var Dhagala Lagali Kal (From 'Bot Lavin Tithe Gudgulya').m4a
 [*] 12.6 MB / 12.6 MB @ 853 kB/s [##################] [100%, 0s left]
 [*] 12.6 MB / 12.6 MB @ 783 kB/s [##################] [100%, 0s left]
 [*] 12.6 MB / 12.6 MB @ 1.3 MB/s [##################] [100%, 0s left]
 [*] 12.6 MB / 12.6 MB @ 935 kB/s [##################] [100%, 0s left]
error() missing 1 required positional argument: 'msg'
No songs found for the artist
DONE

@monuyadav016 I also get the same error as the OP (with the current repo)

This error is not the same as OP's. You got an error possibly due to connectivity issues.


set DF bit (confirmed that it works on FreeBSD 12 and ubuntu 2004)

note: cli command does not do ipv6

Before figuring out that "Ubuntu 2004" stands for 20.04, I wondered if Ubuntu existed in 2004, and apparently, it did! 😲 https://en.wikipedia.org/wiki/Ubuntu_version_history#Ubuntu_4.10_(Warty_Warthog)

Thank you for the review!


The method getColor(int) from the type Resources is deprecated

/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/LoginActivity.java
Warning:(109, 46) The method getColor(int) from the type Resources is deprecated

Warning:(92, 59) The method getColor(int) from the type Resources is deprecated```

@teolemon I have fixed this issue. Please review my PR.


Document config.src()

There is a config.src() function used in an example but it is not documented in the README

if you're interested. I decided it's best to remove src. However I've kept the method for backwards compatibility. As of #73 it's best to use root() in order to use  the src functionality. Hopefully this change will reduce human error :)


Can't handler event

I used @dragStart="dragStart" but it seem not working. Please check. Thanks
My menthods :
methods: {
      dragStart(e, index) {
        console.log("dragStart2", e, index)
      }
 }

@hieu-brain  try to change method name.


Files from #include directives are lost when chat presents C++ examples

When C++ code is presented in chat responses, files are missing from #include directives.
For example if I ask "show me an example of critical section in C++", the reply is as follows:
A critical section in C++ is a portion of code that accesses a shared resource (data structure or device) that must not be concurrently accessed by more than one thread of execution. To protect a critical section, you can use synchronization mechanisms like mutexes.
Here is an example using std::mutex from the C++ Standard Library:
#include
#include
#include

std::mutex mtx; // Mutex for critical section
int shared_resource = 0; // Shared resource

void increment()
{
    // Lock the mutex before accessing the shared resource
    std::lock_guard lock(mtx);
    // Critical section starts
    ++shared_resource;
    std::cout << "Shared resource incremented to " << shared_resource << " by thread " << std::this_thread::get_id() << std::endl;
    // Critical section ends
    // Mutex is automatically released when lock goes out of scope
}

int main()
{
    std::thread t1(increment);
    std::thread t2(increment);

    t1.join();
    t2.join();

    std::cout << "Final value of shared resource: " << shared_resource << std::endl;

    return 0;
}

In this example:
A std::mutex named mtx is declared.
The increment function locks the mutex using std::lock_guard before accessing the shared resource shared_resource.
The critical section is the part of the code where shared_resource is incremented.
The mutex is automatically released when the std::lock_guard object goes out of scope.
Two threads (t1 and t2) are created to run the increment function concurrently.
The join method is called on both threads to wait for their completion.
This ensures that the shared resource is accessed by only one thread at a time, preventing race conditions.

Is this the exact response copied from the chat? Can you share the whole conversation, by doing right click > Copy All?
I can't repro it, but if the include was supposed to be one formatted with angle brackets like #include <iostream> the it's possible that some html sanitization code broke down?
But it's also possible that it's just a bad LLM response.

Hello I copied my question + response from "Accessible view". The
conversation was minimalist, just a single prompt and a reply.
Dňa 12. 11. 2024 o 0:16 Rob Lourens napísal(a):

Is this the exact response copied from the chat? Can you share the
whole conversation, by doing right click > Copy All?
I can't repro it, but if the include was supposed to be one formatted
with angle brackets like |#include | the it's possible that
some html sanitization code broke down?
But it's also possible that it's just a bad LLM response. Does this
happen every time? Can you provoke similar angle bracket responses?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-copilot-release/issues/2489#issuecomment-2469266503,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATNYX2RAQ46M4LUEO37VFT2AE3DNAVCNFSM6AAAAABRSENSI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGI3DMNJQGM.
You are receiving this because you authored the thread.Message ID:
@.***>

I see, the <...> patterns get "sanitized" away because they are considered untrusted HTML tags.
@meganrogge it looks like you've fixed some related issues. I don't actually follow why we're using dompurify in renderMarkdownAsPlaintext because it's not running on HTML, it's running on plaintext, so what's to purify?
If we can't get rid of that, we would need to escape html characters, then unescape them on the other side.

@mjbvz would know about markdown sanitization. the work that I've done in that area has just been for accessibility purposes.

Yes we'll need to add some escaping for renderMarkdownAsPlaintext. Will fix this over on vscode


Fix versions of services in osparc-ops and try renovatebot tool to update tools

shouldn't we fix a version and then have a bot that creates a branch, upgrades to latest version each image and run the tests automatically??
We should check tools like https://renovatebot.com/
Originally posted by @pcrespov in https://github.com/ITISFoundation/osparc-ops/pull/33

check if this has some usefule info you might want to follow upon, otherwise please just close. thx

moved to new ops-repo


Pip install method deprecation warning

Sport
Football
Summary
When installing the latest version with pip there is this warning.
DEPRECATION: espn_api is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
Logs/Data
No response

Thanks for reporting this. I will look into fixing this after the holidays


.NET C# example for Calling Check API is not correct

Hi,
Under the 02. Calling Check API  section there is wrong parameter usage in the Check method.
CheckRequest is assigned to the TupleKey type:
var response = await fgaClient.Check{TupleKey = new CheckRequest(new TupleKey() {....
The proper usage of validation API should be:
var response = await _openFgaClient.Check(new CheckRequest
{
      TupleKey = new TupleKey
         {
             User = "user:anne",
             Relation = "reader",
             Object = "document:Z"
         }, AuthorizationModelId = "1uHxCSuTP0VKPYSnkq1pbb1jeZw"
});

Thanks Daniel! If you'd like, feel free to contribute a fix. If not, we'll get to it shortly.
Also heads up that we have a new interface for the SDKs (ready for JS and .NET) but coming soon to our Go and Python SDKs, we'd love your feedback on it!
Release notes: https://github.com/orgs/openfga/discussions/138
Motivation behind it: https://github.com/openfga/js-sdk/pull/8
If you are using the .NET SDK and get to try it out, please let us know whether you consider it an improvement and whether you have any feedback on it.
(Note: We will be updating the docs to that interface once all the SDKs are ready)

Thank you, Raghd!
I created PR.
When it comes to new SDK- I will look into it!


doc: fix double backquotes appearing on demo slide

Thank you for all your awesome library.
I found double backquotes appearing on demo slide.
https://attakei.github.io/sphinx-revealjs/main-ja.html

So I send this pull request😃
But I am not experienced in Sphinx translation, so I may have changed the file improperly.
I noticed that English slide uses single backquote.
https://attakei.github.io/sphinx-revealjs/main-en.html

So maybe it should be as follows (single backquote version)
msgstr "`revealjs-section` や `revealjs-break` を用いてアニメーションの設定が可能です。"

Thank you for feedbak!


Add support for Terraform

Hey,
Is it possible to add support for Terraform, file extensions .tf and .tfvars? I can't open a PR if you want!
Thanks,
MiguelNdeCarvalho

It will be in the next update with everything added along the way.

Thanks @LeonardSSH

A new version will be released soon, after I fix some issues.


Response using the edge-grid -auth .java

Could you please let us know, how do I get the response using this, I have put in all my client access tokens and base URL but no luck. Please help me in this

Hope this will be useful [click on this link!] (https://community.akamai.com/people/B-3-196DS3L/blog/2015/07/18/complete-example-of-accessing-the-open-api-from-java)


findDOMNode is deprecated in StrictMode error

Expected Behavior
No errors in console
Current Behavior
When  I point on
Steps to Reproduce (for bugs)

Use this code (from example)

import MUIDataTable from "mui-datatables";

const columns = ["Name", "Company", "City", "State"];

const data = [
 ["Joe James", "Test Corp", "Yonkers", "NY"],
 ["John Walsh", "Test Corp", "Hartford", "CT"],
 ["Bob Herm", "Test Corp", "Tampa", "FL"],
 ["James Houston", "Test Corp", "Dallas", "TX"],
];

const options = {
  filterType: 'checkbox',
};

<MUIDataTable
  title={"Employee List"}
  data={data}
  columns={columns}
  options={options}
/>

Open in browser
Point on any button (Search, Download CSV, Print, etc) and check console
Error in console:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
    in div (created by Transition)
    in Transition (created by ForwardRef(Grow))
    in ForwardRef(Grow) (created by ForwardRef(Popper))
    in div (created by ForwardRef(Popper))
    in ForwardRef(Portal) (created by ForwardRef(Popper))
    in ForwardRef(Popper) (created by ForwardRef(Tooltip))
    in ForwardRef(Tooltip) (created by WithStyles(ForwardRef(Tooltip)))
    in WithStyles(ForwardRef(Tooltip)) (created by n)
    in div (created by n)
    in div (created by ForwardRef(Toolbar))
    in ForwardRef(Toolbar) (created by WithStyles(ForwardRef(Toolbar)))
    in WithStyles(ForwardRef(Toolbar)) (created by n)
    in n (created by WithStyles(n))
    in WithStyles(n) (created by a)
    in div (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by a)
    in a (created by WithStyles(a))
    in WithStyles(a) (at App.tsx:34)
    in App (at src/index.tsx:9)
    in StrictMode (at src/index.tsx:8) index.js:1

Your Environment

Tech
Version

Material-UI
4.11.0

MUI-datatables
3.5.0

React
16.13.1

browser
Firefox 81.0.1 (x64)

P.S. The strange thing is that the error appears only on the first hover, all other hover errors do not appear

ref : https://github.com/gregnb/mui-datatables/issues/1459#issuecomment-668351229

@wdh2100 So in order to fix this error I must update @material-ui/core to v5 or remove StrictMode? There are no other options?

@patorjk
https://github.com/gregnb/mui-datatables/blob/e75d2fe9a25d166a3472e7d3bb4670e3e539b493/package.json#L94-L95
https://github.com/mui-org/material-ui/issues/13394#issuecomment-546981919
In my opinion, an update is needed.


openpilot v0.3.7

This is the space for public comment before we merge into release.

Tried to run 0.3.7 and after connecting to the car I'm seeing this in tmux:
reconnecting is taking 15 seconds...

Just want to add, this was on a neo board (and not panda).

That board issue should be fixed.

Confirmed working on my neo board now.


Figures are always-on-top and dock aggressively

From okke.formsma on 2009-11-17T09:34:51Z
I'm using Windows 7 and have not checked whether this behaviour is the same
across platforms.
When I create a figure, it stays on top within spyder. This means I have to
close the figure in order to go on programming, and have to replot all
elements in the figure when I want to visualize anything. Can the figures
each get their own window that is not always on top?
Furthermore, if I try to move the figure, it tries to dock immediately.
Usually, I just want to move the window, not dock it. Would it be possible to
have a modifier key to (dis)allow docking when dragging?
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=119

From pierre.raybaut on 2009-12-04T07:12:21Z
There is already an option in the "Interactive console" settings menu:
it's called something like "Dockable figures", and you may disable it if you want to.
It should solve your problem.
Let me know if that's not the case.
Status: Fixed


PDI-14994 - Rowlevel Logging causes NPE in Join rows step. Fixed usin…

…g wrong inputRowMeta(which is null) for a logging data. The correct input row meta for a data in this place is available as data.fileRowMeta[filenr(index of a file the data was taken)].

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/joinrows/JoinRows.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -1.27%:small_red_triangle_down:
Complexity Change: -2.00%:small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1.04%:small_red_triangle_down:
Complexity Change: -1.05%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.joinrows.JoinRows

Instruction Change: -.01%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 3.53%
Complexity Change:  + 4.05%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.Trans

Branch Change:  + .10%
Complexity Change:  + .14%
Instruction Change:  + .09%
Line Change:  + .11%

@mbatchelor , @pamval  Could you take a look please.

@bmorrise, @e-cuellar, @mbatchelor , @pamval Could you take a look please.

@ArtsiomYurhevich  - please provide a test case on this.


pre_fetch_sources: update to download remote-source-file archives

Download remote-source-file archives to build middleware sources
images for middleware binary builds
MMENG-1277
Signed-off-by: Harsh Modi<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[n/a] JSON/YAML configuration changes are updated in the relevant schema
[n/a] Changes to metadata also update the documentation for the metadata
[n/a] Pull request has a link to an osbs-docs PR for user documentation updates
[n/a] New feature can be disabled from a configuration file

release notes updated


Microsoft Store not updating to latest version of PowerShell Preview

It's possible I'm missing something.
How do you update your existing Microsoft Store PowerShell Preview version? I thought that at least the app would have an update button, or it was done automatically.
Current Version installed from the Microsoft Store: PowerShell Preview 7.1.0-preview.6

Expected behavior
Windows 10 to update PowerShell Preview in Microsoft Store.

Actual behavior
No Update was performed.

Environment data

PS C:\Windows\System32> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.6
PSEdition                      Core
GitCommitId                    7.1.0-preview.6
OS                             Microsoft Windows 10.0.19041
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS C:\Windows\System32>

The update is currently available on MS Store - I got my P7 update from MS Store just fine. It looks like it went through not so long ago so perhaps you could check again?

@SteveL-MSFT
So, what's the waiting period for updating the PowerShell Preview version? Is it about 3 days after its release?
:)
Thanks

@MaximoTrinidad as you have the answer, from this comment https://github.com/PowerShell/PowerShell/issues/7730#issuecomment-689732223 I think this can be closed now


Align placeholder text with icon

Hello! Any one can have an idea how to align placeholder text with icon. Check the screenshot as well.

There isn't currently any first party support for this, but we are open to PRs contributing it.

Hey, I played around with SkyFloatingLabelTextFieldWithIcon you can set the variable iconMarginBottom to position the icon. Here is the code SkyFloatingLabelTextFieldWithIcon#L65-L71

iconMarginBottom set icon position from the bottom as u see in above image, but how I can I align label with icon?

I think you have to do it manually atm. SkyFloatingLabelTextFieldWithIcon sets the frame based on the variable. I think aligning the icon and label make sense, I can see what I can do. Please submit a PR if you find a solution :)

I have used iconMarginBottom for now but it would be nice to autoalign this.

Any solution for this already?


[VS Code]

Error:
[Description of error message]
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.540

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.36.1

platformName
Windows

platformVersion
10.0.17763

Hey @worldofone, can you tell me more about what the issue you ran into was? Your logs may also provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.


Investigate maven central deployment

We would gain visibility and ease of use if Gatling was deployed in central.
This requires the following librairies to be deployed in central too :

akka
vtd-xml
aspectwerkz 2.2.3 (will be removed from akka 2)
scopt

https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide
https://docs.sonatype.org/display/Repository/Uploading+3rd-party+Artifacts+to+The+Central+Repository

vtd-xml will never be on central as it's dual licenced GPLv2/commercial but only gatling-vtd is impacted.
aspectwerkz is removed from Gatling 1.1

There's not point in trying to deploy on central as long as the only reporting engine is based on highcharts/highstocks that are definitively NOT open-source.


python310Packages.types-redis: 4.3.2 -> 4.3.3

Description of changes
Update to latest upstream release 4.3.3

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 181208 run on x86_64-linux 1

2 packages built:

python310Packages.types-redis
python39Packages.types-redis

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 181208 run on x86_64-linux 1

2 packages built:

python310Packages.types-redis
python39Packages.types-redis

LGTM


Uplands with BSL has this bold white area in its skybox that flickers somewhat at night

BSL's the only shader that I know of to have this issue. I can't test out many as I don't have a NIVIDIA or AMD GPU.

After some discussion amongst the Fabric dev-team, we've decided to close this under Won't Fix. Since Optifabric is an unofficial mod that makes an already-closed source mod usable on a mod loader that it was never meant for, there are too many variables at work for us to diagnose the issue. We'll add a message to the README/Curseforge warning about the possible seizure warning.


chore: update some of the major dependencies

references https://github.com/dependents/node-detective-postcss/pull/145

CC @XhmikosR - ready to merge. We should probably bump the major version with this. And the NPM token will need to be updated.

@joscha thanks, I gave you admin rights here :)
That being said, don't merge this yet. I'll split this PR so that we can land the non-breaking changes separately. I should be able to do it later today.

Great! Is there a npm group for dependents?

There is but I'd need to dig in to see if I have admin rights there :)

@joscha I split the patches. There is an npm organization (https://www.npmjs.com/org/dependents) but I don't have admin rights, so we need @mrjoelkemp to add you/move the package there too.

@XhmikosR Made you an owner of the npm org. The UI to manage that org is so confusing on npm. Figured it out.

@XhmikosR Made you an owner of the npm org. The UI to manage that org is so confusing on npm. Figured it out.

@XhmikosR are you able to produce an NPM_TOKEN and add it to the secrets in the settings of this project, please: https://github.com/dependents/node-detective-postcss/settings/secrets/actions/NPM_TOKEN ? After that I can create the new 6.0.0 release.

@joscha @mrjoelkemp I have no idea how to move a package to the npm org :/
BTW the token doesn't need to change in theory.

I revoked all tokens after I moved the repo but didn't have admin access anymore. I can't really  leave my token in a shared public org as I can't limit the access, so I'd prefer if you created one for repo if you don't mind.

OK, I think we need @mrjoelkemp to give you admin rights to the detective-postcss repo after it's moved to the npm org so that you can manage it independently

I can give access to the package to an org or user.
On Tue, 15 Mar 2022, 17:24 XhmikosR, @.***> wrote:

OK, I think we need @mrjoelkemp https://github.com/mrjoelkemp to give
you admin rights to the detective-postcss repo after it's moved to the npm
org so that you can manage it independently
—
Reply to this email directly, view it on GitHub
https://github.com/dependents/node-detective-postcss/pull/146#issuecomment-1067608879,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABN5BWCHM7PWF5U7IVQBF3VAAUJ3ANCNFSM5QUPDRQA
.
You are receiving this because you were mentioned.Message ID:
@.***>

BTW v5.1.0 is broken :/
Error: Cannot find module 'C:\Users\xmr\Desktop\detective\node-precinct\node_modules\detective-postcss\dist\index.js'. Please verify that the package.json has a valid "main" entry

We'll need to cut a new 5.1.1 release before 6.0.0.

👍
Wonder if it's worth to add a pack and require check before publishing to
avoid errors like these in the future.
On Tue, 15 Mar 2022, 17:32 XhmikosR, @.***> wrote:

BTW v5.1.0 is broken :/
Error: Cannot find module 'C:\Users\xmr\Desktop\detective\node-precinct\node_modules\detective-postcss\dist\index.js'. Please verify that the package.json has a valid "main" entry
We'll need to cut a new 5.1.1 release before 6.0.0.
—
Reply to this email directly, view it on GitHub
https://github.com/dependents/node-detective-postcss/pull/146#issuecomment-1067615037,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABN5BUZ2MOSFPNXYZDPK2DVAAVGFANCNFSM5QUPDRQA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Definitely worth adding a new action to test this if you have some time later :)


Multiple validation schemes

From @incompletude on January 6, 2018 6:10
I'm not sure I have a issue but I'm not sure how to approach these problems and I hope you guys can point me to the right direction.
The first problem is related to the [Required] and [BindRequired] DataAnnotations. Seems to me a bit hacky to make my Id property nullable so I can use the Required parameter. I tried [BindRequired] parameter instead, and it doesn't make a difference, I get a valid model state no matter what.
    public class Category
    {
        [Required]
        public virtual int? Id { get; set; }
        public virtual string Name { get; set; }
    }

    [HttpPost]
    public IActionResult Post([FromBody]Category category)
    {
    }

    public class ModelStateValidationFilter : ActionFilterAttribute
    {
        public override void OnActionExecuting(ActionExecutingContext context)
        {
            if (context.ModelState.IsValid == false)
            {
                var errors = context.ModelState
                    .SelectMany(x => x.Value.Errors, (y, z) => z.Exception == null ? z.ErrorMessage : z.Exception.Message);
                context.Result = new ObjectResult(new { type = "model", errors }) { StatusCode = 422 };
            }
            base.OnActionExecuting(context);
        }
    }

Currently, I use the following code so I can get different validation schemes for different http verbs. It looks extremely ugly to me. Is there a native more elegant way to achieve this considering I use a catch all errors filter?
    public class Category
    {
        public virtual int? Id { get; set; }
        public virtual string Name { get; set; }
        public virtual Permission Permission { get; set; }
    }

    public class CategoryCreate : Category
    {
        [Required]
        public override string Name { get; set; }
    }

    public class CategoryUserCreate : Category
    {
        [Required]
        public override int? Id { get; set; }
        [Required]
        public override Permission Permission { get; set; }
    }

    [HttpPost]
    public IActionResult Post1([FromBody]CategoryCreate category)
    {
    }

    [HttpPost]
    public IActionResult Post2([FromBody]CategoryUserCreate category)
    {
    }

Nice work, thank you all.
Copied from original issue: dotnet/core#1193

From @Petermarcu on March 18, 2018 16:55
@Eilon

@dougbu, can you please share your thoughts here? Thanks!

Regarding this topic,
I have given up using a catch-all automatic filter.
I adopted using NULLABLEs, but I disagree completely with the pattern.
I'm manipulating the model state individually in each end point.
Not the best solution, could be better, but looks good enough.
    public static class ModelStateExtension
    {
        public static void Validate(this ModelStateDictionary modelState)
        {
            if (!modelState.IsValid)
            {
                var errors = modelState.ToDictionary(
                    kvp => kvp.Key,
                    kvp => kvp.Value.Errors
                        .Select(e => e.Exception == null ? e.ErrorMessage : e.Exception.Message).ToArray())
                        .Where(m => m.Value.Count() > 0)
                            .Select(error => new Error { Key = error.Key, Value = error.Value }).ToList();

                throw new BadRequestException(errors);
            }
        }
    }

        [HttpGet]
        public IActionResult Get()
        {
            ModelState.Remove("id");
            ModelState.Remove("name");
            ModelState.Validate();

            ...
        }

@incompletude I would appreciate your help understanding your exact issue or issues.
For example, when exactly does [BindRequired] not "make a difference"?

If this is within a model type used with [FromBody], note [BindRequired] is an MVC attribute and none of the deserializers (input formatters) understand it. In fact, only the MVC model binding system understands [BindRequired].

And, what about your ModelStateExtension would like us to comment on?

FYI my first thought is that serializing  e.Exception.Message from the ModelState can easily leak internal information about your web application.

The required attribute must work for value types accordingly.

You're correct non-Nullable value types can't fail a [Required] validation.
MVC simply calls [Required] attributes when they are associated with properties the validation system visits. And, [Required] is a .NET Framework ValidationAttribute with well-documented semantics: Properties are invalid if they are null, the empty string, or contain only whitespace.

trying to have a complete automatic catch-all validation filter

Thanks for the focus.
I recommend you stick exclusively with ValidationAttributes and ensure initial values for mandatory properties are invalid. Use [Required] on properties of complex types but something else on value types.
For example,
    public class CategoryUserCreate : Category
    {
        [Range(0, int.MaxValue)]
        public override int Id { get; set; } = -1;
        [Required]
        public override Permission Permission { get; set; }
    }

That is a nice idea.

This is a very good idea. Gonna try that. Thx you so much for your time.

For public Boolean? Active { get; set; }, I suggest defining a tri-state enum containing Invalid, True and False or sticking with bool?.

Thanks @dougbu. @incompletude, do the suggestions provided by @dougbu address your issue?

Not really. But I better understand the limitations. Thx you all for your time.

@incompletude thank-you for your feedback. We're closing this issue as the questions asked here have been answered.


Test suite shellcheck fixes

I noticed the "! -z" oddness, and after fixing it decided to have a go with shellcheck, which resulted in this patch series.
I'm also thinking this would be nice to run as part of the repo's CI, which I notice is marked as failing, and I assume travis is not working either given their recent policy change. If you have no issue with this, I'd probably work tomorrow on switching these to use github actions?

I'm also thinking this would be nice to run as part of the repo's CI, which I notice is marked as failing, and I assume travis is not working either given their recent policy change. If you have no issue with this, I'd probably work tomorrow on switching these to use github actions?

The failing appveyor is annoying to see indeed. But speaking of CI, liburing is some kind of kernel test, which requires us to install the latest kernel. Can GitHub actions do that?

CI does need some love, it's pretty much just disabled. There's probably limited utility in actually running the tests, however building the lib and tests would be useful by itself.


Ruleset 10 Unit Tests

BTC Hodler: The user held Wrapped BTC every day from a specific date

[ ] Create TEE unit test: Ruleset 10 succeeds and generates a VC successfully
[ ] Create TEE unit test: Ruleset 10 should fail successfully when no EVM addresses have been provided
[ ] Create TEE unit test: Ruleset 10 should fail successfully when The Graph doesn’t return an HTTP 200 status code
[ ] Create TEE unit test: Ruleset should fail successfully when The Graph returns FALSE boolean values for all of the EVM addresses provided

Unit test 1: Ruleset 10 succeeds and generates a VC successfully
Generate VC extrinsic within the TEE Enclave should be called

ruleset-id param relating to the set of rules we need to test against
idhub-address param relating to the unique Litentry/IDHub address
param: One or more EVM addresses should be allowed to be defined within the payload of this param

The extrinsic should then carry out an HTTPS request to The Graph provided by the TDF team.
The TEE Enclave should call the Wrapped BTC before a specific date/year endpoint using the hardcoded date value (to be provided by the ID Hub team) and the submitted EVM addresses.
It would check to ensure the URL returns a 200 HTTP status code and check a boolean value is returned for each of the addresses provided to The Graph in the request.
Unit test 2: Ruleset 10 should fail successfully when no EVM addresses have been provided
Generate VC extrinsic within the TEE Enclave should be called

ruleset-id param relating to the set of rules we need to test against
idhub-address param relating to the unique Litentry/IDHub address
param: One or more EVM addresses should be allowed to be defined within the payload of this param

If no EVM addresses have been provided in the param payload then the extrinsic should not attempt to call any 3rd party services and should fail to generate a VC.
Unit test 3: Ruleset 10 should fail successfully when The Graph doesn’t return an HTTP 200 status code
Generate VC extrinsic within the TEE Enclave should be called

ruleset-id param relating to the set of rules we need to test against
idhub-address param relating to the unique Litentry/IDHub address
param: One or more EVM addresses should be allowed to be defined within the payload of this param

The extrinsic should find that at least one EVM address has been provided
However, the test should fail successfully if The Graph endpoint does not return an HTTP 200 status code
**Unit test 4: Ruleset should fail successfully when The Graph returns FALSE boolean values for all of the EVM addresses provided
Generate VC extrinsic within the TEE Enclave should be called

ruleset-id param relating to the set of rules we need to test against
idhub-address param relating to the unique Litentry/IDHub address
param: One or more EVM addresses should be allowed to be defined within the payload of this param

The extrinsic should find that at least one EVM address has been provided
However, the test should fail successfully if none of the EVM addresses provided have held Wrapped BTC every day from a specific date.

one sec, this ruleset needs the support of (linking) a BTC address if I understand it correctly? As we only support evm-based and substrate-based addresses as web3 identities so far


Version Skew GitHub action test

PR adds a new workflow: version skew tests which run on push to master, or manually on a bot command.
1 job in the workflow will deploy the master build version of the control plane with the daprd sidecar set to the previous release version. The e2e tests of the previous release will be run against this deployment. The second job runs the same tests, but with the control plane on the previous release version, daprd on master.
The intention of this workflow is to verify that the current master branch of dapr is compatible to upgrading, according to the upgrade path policy.
The previous release is automatically discovered from the GitHub releases page.
You can find the results to this workflow on my personal fork here.
The bot command /test-version-skew will trigger the workflow on a PR. You can also optionally supply a specific version to test against as an argument to this command, e.g. /test-version-skew 1.10.5. Note that this version needs to be released and its artifacts be publicly available.
Example of this working here.

Another option was to consider running the master e2e tests, however this would result in a bunch of tests being marked to skip running on this workflow & it doesn't make much sense to expect master branch features/tests to be successful on older software versions.. we do expect all previous release tests to pass on master though.

There is also room to extend this job so that the control plane and/or the daprd sidecar is upgraded/downgraded "live", after deployment, before running the e2e tests.
/cc @artursouza

/test-version-skew

@daixiang0 the command won't be available until this is merged to master. You can try it out on my fork though  https://github.com/JoshVanL/dapr/actions/runs/5034252901


[BUG] Cannot set client-output-buffer-limit as argument to the keydb-server

Describe the bug
Cannot set client-output-buffer-limit as argument to the keydb-server:
https://github.com/Enapter/charts/issues/37
To reproduce
docker run --rm -it eqalpha/keydb:x86_64_v6.2.1 keydb-server --client-output-buffer-limit "normal 0 0 0"

*** FATAL CONFIG FILE ERROR (KeyDB 6.2.1) ***
Reading the configuration file, at line 2
>>> 'client-output-buffer-limit "normal 0 0 0"'
Bad directive or wrong number of arguments

Expected behavior
The argument is treated like a config directive.

keydb Reading the configuration file, at line 1588                                                                                │
│ keydb >>> 'client-output-buffer-limit "normal 0 0 0 replica 0 0 0 pubsub 128mb 64mb 60"'                                                                                │
│ keydb Bad directive or wrong number of arguments

Hi @Antiarchitect,
The client-output-buffer-limit parameter takes in 3 arguments, however you seem to be passing in only one (which is the entire string normal 0 0 0). The following command should work, note the lack of quotation marks:
docker run --rm -it eqalpha/keydb:x86_64_v6.2.1 keydb-server --client-output-buffer-limit normal 0 0 0

In addition, when setting different types of client-output-buffer-limit (normal, replica, pubsub), you need to do those one per line instead of all at once. So instead of:
... --client-output-buffer-limit normal 0 0 0 replica 0 0 0 pubsub 128mb 64mb 60

It would be:
... --client-output-buffer-limit normal 0 0 0 --client-output-buffer-limit replica 0 0 0 --client-output-buffer-limit pubsub 128mb 64mb 60

Hope this helps.

@VivekSainiEQ Thank you. Looks horrible but I'll try to do something about that in my helm chart.


[Question] Chromium binary in layer

Is the Chromium binary already decompressed when used as a layer?
I see the check for /tmp/chromium in the code but I don't quite follow the logic around publishing chromium-v116.0.0-layer.zip because when I unzip this file manually I see chromium.br which suggests it would still be compressed in the layer.
Also according to AWS docs a layer is extracted into /opt so I am totally confused as to how this package would pick this up from the layer.

Having done some further tests inside Lambda my conclusion is no... it will still have to deflate even as a layer. Any possibility of changing that? Still not clear what the /tmp check is for.

It's compressed because the layer was too big to be used otherwise. Though I just took a look at lambda's docs and I can't find what the layer size limit is, they may have dropped it? I'll need to look into it.
The /tmp/chromium check is to see if the binary has already been extracted, it will skip if it's already there. If it's not a cold start, it should be there already.

I just tried to upload a zip of the extracted binaries as a layer and I got the error "The selected file is too large. The maximum size is 50.0 MB."
Guess this isn't possible, shame!

@fire015 Upload the layer from s3. It seems that the 50mb limit is only for direct upload zip files


Let's Encrypt

Hey, I'm trying to configure my docker-compose.yml to work with Let's Encrypt.
      jrcs/letsencrypt-nginx-proxy-companion
      jwilder/nginx-proxy

are the images I'm using to handle the process automatically.
typically with this command added to the docker-compose.yml file added in the environment section
- VIRTUAL_HOST=wiki.foo.bar
- LETSENCRYPT_HOST=wiki.foo.bar
-<EMAIL_ADDRESS>
docker-compose.yml
version: '2'
services:

  mysql:
    image: mysql:5.7.12
    environment:
    - MYSQL_ROOT_PASSWORD=secret
    - MYSQL_DATABASE=bookstack
    - MYSQL_USER=bookstack
    - MYSQL_PASSWORD=secret
    volumes:
    - ./mysql:/var/lib/mysql

  bookstack:
    image: solidnerd/bookstack:0.14.3
    depends_on:
    - mysql
    environment:
    - VIRTUAL_HOST=wiki.foo.bar
    - LETSENCRYPT_HOST=wiki.foo.bar
    -<EMAIL_ADDRESS>    - DB_HOST=mysql:3306
    - DB_DATABASE=bookstack
    - DB_USERNAME=bookstack
    - DB_PASSWORD=secret
    volumes:
    - ./uploads:/var/www/BookStack/public/uploads
    - ./storage-uploads:/var/www/BookStack/storage/uploads
    ports:
    - "8080:80"

This isn't working. I've tried to do this with individual containers as well with no luck.
Thanks for any help.

Hi @krenken,
Are you using the nginx proxy containers in your docker compose setup at all? At the moment it looks like you're simply adding a few additional environment variables to the BookStack container.

I am also having difficulties getting HTTPS setup with a Let's Encrypt certificate. Is there a documented or recommended method for securing Bootstack with SSL?

I've had issues with this, what fixed it for me was to have everything in the same network:
docker network create bookstacknet and then have all containers including nginx, nginx-gen, letsencrypt, mysql, and bookstack have the option  --net bookstacknet

Any easier way to do this? My server already has a letsencrypt cert set up on it, I'm just hosting BookStack on a different port using the docker image. How can I get it to play nice?

This issue was closed due to inactivity but should be reopened.  Without https bookstack is not a viable solution.


Panic during Pool Put

panic(0x801440, 0xc4200120d0)
        /usr/local/go/src/runtime/panic.go:500 +0x1a1
gopkg.in/rana/ora%2ev3.(*Ses).Close(0xc421176640, 0x0, 0x0)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/ses.go:150 +0xc8
gopkg.in/rana/ora%2ev3.sesSrvPB.Close(0xc421176640, 0xc420134740, 0x43e7f5, 0xc442ea16d8)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:198 +0x42
gopkg.in/rana/ora%2ev3.(*sesSrvPB).Close(0xc450405820, 0xc420c7ec00, 0x0)
        <autogenerated>:66 +0x5b
gopkg.in/rana/ora%2ev3.(*idlePool).Put.func1(0xc420134750, 0xc3e8e0, 0xc450405820)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:476 +0x124
created by gopkg.in/rana/ora%2ev3.(*idlePool).Put
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:478 +0xa6

I got the above crash during high load in a notification service. I am using the latest release 3.8 along with go 1.7.3 with the default environment settings.
I was using an earlier version where I didn't get this error, but since I've updated it seems I've received this quite a lot when I checked the logs.

That's a strange place to have a panic: ses.srv.openSess.remove(ses)
It means that the ses' srv is already closed...
I've uploaded some patch, hope that helps.
Are you using the Pool directly, or through database/sql? Just've surfaced an idea: databas/sql already pools the sessions, maybe that's an error to use a pool in the driver, too...

I am using it through the database/sql. You might be right, the driver interface already knows about creating, ending and pooling connections, I don't think using another pool is necessary and it might even cause some unexpected issues.
The version I was using before didn't have pooling in the driver, when I updated the driver to fix ses open close deadlock, I started seeing this panic.

I've re-added the idle pool for connections, as go run z_race.go slurped up all available Oracle connections - maybe I'd have to tweak db.SetMaxIdleConns & co, I don't know.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x558fd8]

goroutine 895 [running]:
panic(0x8013e0, 0xc4200120d0)
        /usr/local/go/src/runtime/panic.go:500 +0x1a1
gopkg.in/rana/ora%2ev3.(*Ses).Close(0xc4204bd0e0, 0x0, 0x0)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/ses.go:150 +0xc8
gopkg.in/rana/ora%2ev3.sesSrvPB.Close(0xc4204bd0e0, 0xc4201347c0, 0x43e7f5, 0xc4a8a476d8)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:198 +0x42
gopkg.in/rana/ora%2ev3.(*sesSrvPB).Close(0xc450be4370, 0xc4b531e720, 0x0)
        <autogenerated>:66 +0x5b
gopkg.in/rana/ora%2ev3.(*idlePool).Put.func1(0xc4201347d0, 0xc3e840, 0xc450be4370)
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:476 +0x124
created by gopkg.in/rana/ora%2ev3.(*idlePool).Put
        /home/kokteyl/go/src/gopkg.in/rana/ora.v3/pool.go:478 +0xa6

Unfortunately the same panic still exists in the latest release. The latest commit is the following in my git log:
commit 11ffe9912b05c73a23fcfe122dd9028fdd2cafe7
Author: Tamás Gulácsi<EMAIL_ADDRESS>Date:   Thu Dec 22 13:37:46 2016 +0100

    re-add connection pooling for Con, but per-env and not global (_drv)

The driver using all available connections is related to MaxIdleConnections setting. If you set it you really shouldn't need any extra pooling for idle connections.

Ok, I've removed that pool (v3.8.2).

Ok. Published into production, will let you know.

The issue seems to be resolved, 2 days into production and I didn't see any crashes, closing the issue

Thanks for your patience and constructive attitude!
omerkirk<EMAIL_ADDRESS>ezt írta (időpont: 2016. dec. 28., Sze,
9:07):

The issue seems to be resolved, 2 days into production and I didn't see
any crashes, closing the issue
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rana/ora/issues/141#issuecomment-269441621, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPoSh_3_CrkLtbyU9BqTBGKK-6Sg77vks5rMhiogaJpZM4LTvF7
.

We rely heavily on this driver in many of our products, and you did an incredible job with this driver. Thanks for all the hard work and quick responses.

Thank you for the positive words. Tamas and I have put a lot of effort into
the driver. It's nice to hear someone is getting real value from it
On Wed, Dec 28, 2016, 12:16 AM omerkirk<EMAIL_ADDRESS>wrote:

We rely heavily on this driver in many of our products, and you did an
incredible job with this driver. Thanks for all the hard work and quick
responses.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rana/ora/issues/141#issuecomment-269442555, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMGYwSfowZ0M7uNqJHWyIN53XJs6TKhoks5rMhrYgaJpZM4LTvF7
.


[Feature] Make editor/preview pane resizable horizontally

I'd appreciate the possibility to resize the editor with the mouse, just like in netlify cms:

I think it would greatly enhance the user experience for everybody.

I am also interested because the edition bar is very small.

This is being targeted for the v4.0.0 release.

From my point of view it would be nice if it is possible to hide the editor entirely to provide a better preview.
The following issue is related here: https://github.com/StaticJsCMS/static-cms/issues/768


Make UI tests load all requirements automatically

instead of them being hardcoded

Codecov Report

Merging #744 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   98.52%   98.35%   -0.17%
==========================================
  Files          31       31
  Lines        2647     2800     +153
  Branches      227      405     +178
==========================================
+ Hits         2608     2754     +146
+ Misses         39       33       -6
- Partials        0       13      +13

Impacted Files
Coverage Δ

browser/pages/confirm/controller.js
91.8% <0%> (-2.02%)
:arrow_down:

browser/model/jbosseap.js
96.9% <0%> (-2.01%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/services/componentLoader.js
98.78% <0%> (-1.22%)
:arrow_down:

browser/model/cdk.js
98.14% <0%> (-0.89%)
:arrow_down:

browser/model/jdk-install.js
98.26% <0%> (-0.54%)
:arrow_down:

browser/model/helpers/version.js
100% <0%> (ø)
:arrow_up:

browser/services/data.js
100% <0%> (ø)
:arrow_up:

browser/model/hyperv.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/util.js
100% <0%> (ø)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9e7ef...c79603b. Read the comment docs.


Change the large model

Does your project support the replacement of large language models, such as replacing gpt3.5 in the project with the ChatGlm3 large model? Because our school does not have the conditions to unlock the restrictions of gpt3.5, that is, it does not have a credit card to upgrade the openai account. Thank you.

@zijinoier thank  you

Please refer to this comment in issue #5 : https://github.com/PJLab-ADG/DriveLikeAHuman/issues/5#issuecomment-1693058019


Diagnose/remove combinatorial loop

Verilator reports this loop:
%Warning-UNOPTFLAT: ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_core.sv:129: Signal unoptimizable: Feedback to clock or circular logic: ibex_core.is_decoding
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_core.sv:129:      Example path: ibex_core.is_decoding
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_controller.sv:527:      Example path: ASSIGNW
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_id_stage.sv:158:      Example path: ibex_core.id_stage_i.deassert_we
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_decoder.sv:550:      Example path: ASSIGNW
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_id_stage.sv:174:      Example path: ibex_core.id_stage_i.jump_in_id
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_id_stage.sv:602:      Example path: ALWAYS
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_id_stage.sv:172:      Example path: ibex_core.id_stage_i.jump_set
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_controller.sv:151:      Example path: ALWAYS
                    ../src/lowrisc_ibex_ibex_0.1/rtl/ibex_core.sv:129:      Example path: ibex_core.is_decoding

We need to diagnose this loop in more detail, and hopefully remove it. Otherwise add an explanation and a lint waiver.
(My gut feeling is that we need to apply deassert_we later to signals that need it.)

I had a look, the combinational loop warning goes away, if jump_in_id_o and the various other signals at the bottom of ibex_decoder.sv are changed not to depend on deassert_we_i. To me, it makes little sense to have this kind of control logic inside the decoder. Also, looking at the FSMs I think they don't need to depend on this signal anyway. It seems that for some cases the same is achieved already by the ID-EX/WB FSM in ibex_id_stage.sv.
I will thus move these signals out of the decoder and see how to integrate the functionality in the ID stage to simplify and cleanup the whole thing.

The fix for this issue is part of PR #120 .


Issue 10.dockter.1

Pull request questions
Which issue does this address
ISSUE-10
Why was change needed
Renaming of repository.

Issue number: #10


Support job event callback

Add the ability to receive 'complete' and 'failed' callback from job in
queue.

Coverage decreased (-0.09%) to 99.067% when pulling c4aa95d0cdf5a01e1e72d353f2ecd09f0b4c8753 on harinsa:master into 5a01bc99d4c06073b1f76f9bd47b9fb1a5e2df2a on jitta:master.

Coverage increased (+0.2%) to 99.333% when pulling af03f2833efd3da069d559e40794b438361a726a on harinsa:master into 5a01bc99d4c06073b1f76f9bd47b9fb1a5e2df2a on jitta:master.

Coverage increased (+0.2%) to 99.333% when pulling af03f2833efd3da069d559e40794b438361a726a on harinsa:master into 5a01bc99d4c06073b1f76f9bd47b9fb1a5e2df2a on jitta:master.

Coverage increased (+0.2%) to 99.333% when pulling af03f2833efd3da069d559e40794b438361a726a on harinsa:master into 5a01bc99d4c06073b1f76f9bd47b9fb1a5e2df2a on jitta:master.

+<EMAIL_ADDRESS>published to npm


Enable travic CI build for all identity repos

Noticed that we have not enabled Travis CI for PRs in the following repos,

https://github.com/wso2-extensions/identity-outbound-auth-email-otp
https://github.com/wso2-extensions/identity-outbound-auth-totp

There is a very good chance we have other missed repos as well. It would be nice to have Travis enabled for the repos.

We have enabled build based on github actions and moved away from from travic for PR builds


feat(orchestrator): implement provider registration

Description
Implement https://github.com/openclarity/vmclarity/issues/780

Currently the provider is not an independent service and communication with the backend (apiserver) service is done via the orchestrator, so for now add the backend client to each provider.
When an IAM service is available, a bootstrap token will be given to each provider and it will use it perform registration with the apiserver service from which it will get a authentication token that will be used to communicate with this service. For now, just post the provider to the apiserver service and receive back an UUID which will be used as authentication token.
While persistent storage is not available for most providers, for the docker provider a persistent volume can be easily implemented and the "current registration method" illustrated in the following diagram is implemented here.

Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[x] All code style checks pass
[ ] New code contribution is covered by automated tests
[x] All new and existing tests pass

closing as new approach will be adopted and the first task will be to split the provider from the orchestrator.


Get time seriesclass agregate

Related Issue:

Issue goes here

Proposed Changes
since the methods get_time_series and get_US_time_seriesclass were similar, It would be more organized if they were in the same class.
Addtional Info

any additional information or context

Checklist

[yes ] Tests
[ ] Translations
[ ] Documentation

Screenshots

screenshot 1

Thank you for the PR. This implementation is being reviewed at https://github.com/nat236919/covid19-api/pull/73


Update action name for publication

Codecov Report

Merging #21 (8fd35b7) into main (a9f06f4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           11        11
=========================================
  Hits            11        11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f06f4...8fd35b7. Read the comment docs.


Add onStart functionality to dynamically calculate upload file name

Added onStart functionality to dynamically calculate signingQueryParams based on file selection.

This PR provides almost the same functionality as #72, but that one let's you fully replace the file, which is nice for the "resize image" use case.  In both cases, I'd like this function to be called preprocess instead of onStart or onBeforeUpload, since they both require the callback be called.  If you can change this PR to take in the file in the next method, and rename to preprocess, I'll get this merged.  Thanks!

You got it man! Please let me know if there's something else I need to do here and thanks for the quick response.
Cheers!

One thing, then will merge and release.  Thanks 👍

Totally my bad dude. Thanks for spotting my mistake.

Released v3.3.0, thanks!


How to generate pages-manifest.json

@jeromehan
You do not generate it, you need to manually write it.
All other parts are derived from it (such as the chunk names and preloded assets).


llrt_modules/url module depends on llrt_core/http module

When only the url module is imported, an error will be reported because there is no url module
If there are module dependencies but they are not added in order when used, can an error be reported during compilation? Otherwise, it is difficult to find the problem without checking the source code.
    fn evaluate<'js>(ctx: &Ctx<'js>, exports: &Exports<'js>) -> Result<()> {
        let globals = ctx.globals();
        let url: Constructor = globals.get(stringify!(URL))?;
        let url_search_params: Constructor = globals.get(stringify!(URLSearchParams))?;

What is the difference between stringify!(URL) and "URL"
url_crate  url = ["url_crate"]  seems to be a invalid feature

If you are not getting the expected behavior with respect to the name “url”, then the fix you implemented in #560 may be missing.　I will check back later in the week.
Incidentally, for No. 2, in order to distinguish between the url to be obtained from crates.io and the url as a feature name, a different name is given as follows.
url_crate = { version = “2.5”, package = “url”, optional = true }

https://github.com/ahaoboy/rquickjs-llrt-demo/blob/main/src/main.rs
Here is a minimal reproducible demo. The problem is that the url module depends on http, but there is no prompt at compile time, and an error will be reported at runtime, which is very unfriendly to developers who are not familiar with llrt.

Thank you for presenting the reproduction procedure. I think I understand the problem.
I think it is because the URL class is not defined in the URL Module, the class definition itself is done on the http side, and the URL Module is defined to refer to the global object defined by http.
Please give me some time to think about it. :)

Hi @ahaoboy , As a result of PR #584, it appears that URL/URLSearchParams can be independent of the http module.

Can we close this now @ahaoboy ?

Can we close this now @ahaoboy ?

Still need to import the url module first, but there is no other choice in the short time
https://github.com/ahaoboy/rquickjs-llrt-demo


[BUG] environment_<gpu/cpu>.yml reference path is incorrect in tensorflow_experiments.py

Description
inside the inv file, the reference to 'dependencies_file' should be:
dependencies_file="TensorFlow_experiment/environment_gpu.yml" instead of dependencies_file="Tensorflow/environment_gpu.yml"
This applies for all four template functions inside the tensorflow_experiments.py inv file.
Other Comments

Fixed in #12


chore: upgrade go to 1.15

Some packages are using go 1.16 and another usine 1.15.
This PR will update all go 1.15 to go 1.16.

I don't think there's a need for this, it's alright if different packages within franz-go use different Go versions. I think the current deps pinned by franz-go are all 1.15. That said, compress recently upgraded to require 1.17, so I may bump to that at some point...


kata_agent: Add virtio-scsi support

This patch allows to plug block devices to Kata Containers agent,
using virtio-scsi driver. Those devices can be both rootfs or
simple block device passthrough.
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

Related to https://github.com/kata-containers/agent/pull/163


Calling zen.evaluate inside a function fails

I'm on a free trial of cloud on gorules.io
I have a function that calls zen.evaluate() on another decision that is published and get the following error

Please feel free to close

Also, running await zend.evaluate() in
.map(async function(o) {
  // params left out for brevity
  await zen.evaluate(...)
})

doesn't work.
What works is running it inside a regular for loop like so:
for (const [k, bike] of Object.entries(bikes)) {
  let result = await zen.evaluate('ererer/insurables/bike.json', bike, { trace: true });
  console.log({ result });
}

Hi Bjorn, we will take a look at it why it isn't working in map. Can you try:
await Promise.all(somelist.map(async () => {
return await zen.evaluate();
}));

Works like a charm, and right after you commented I remembered I had some code lying around doing just that.
  let evaluated = await Promise.all(
    bikes.map(async function (insurable) {
      let r = await decision.evaluate(insurable, { trace: false });
      return { ...r.result, insurable };
    }),
  );

Closing as the thread has been resolved.


Add README section on advanced usage via classes

As discussed in https://github.com/adbar/simplemma/issues/110#issuecomment-1673306133, this PR adds a section to the top level README with examples of advanced usage via the Simplemma classes. I used the cache limiting use case I had in mind for the example, but I tried to explains it as a pattern that can be applied also for other customization requirements. Any comments are welcome, I'm happy to adjust as necessary.
While working on this, I discovered some problems that I reported as separate issues #111 and #112.

One aspect of the class API I'm wondering about is the difference between Lemmatizer and LanguageDetector in that Lemmatizer is language-agnostic (the same instance can be used with many languages/combinations, just passing a different lang argument to the lemmatize() method) while LanguageDetector is given a language (or tuple of languages) when it's constructed, so the same instance cannot be reused if you happen to need a different set of languages.
Neither way is wrong, but it seems like these could perhaps be harmonized - either by making Lemmatizer language-specific, or by making LanguageDetector language-agnostic. Maybe @juanjoDiaz has an explanation for the current situation and whether it makes sense to keep it as it is or to try to unify these.

Thanks for the added docs and good point above, you could actually open an issue regarding the harmonization of Lemmatizer  and LanguageDetector. It's not the priority now though, so we can add a corresponding sentence in the docs if you feel users might fail to understand the current difference.


[minor ui bug] Project folder icon incorrect for git worktree

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Normal project folder icon is a plain folder, while git-ed project folder icon is a book.
However, a git-worktree project folder display as a plain folder, while it should be a book by its nature.

Actual behavior: Project folder another looks like a non-git-ed project.
Reproduces how often: 100%
Versions
Atom    : 1.25.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.25.0
python 3.6.4
git 2.16.2.windows.1
visual studio

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      16299  0

Additional Information
This should be a minor and non-urgent bug which only involves UI consistency.

Make sure that the .git folder is in the top-level directory or try to restart atom after initializing the repo.

In addition to the icon being wrong, I also find that the line diffs and tree view coloring don't work for worktree repositories either. However, the git pane and branch switcher work fine.

@leonschoorl I just saw your patch to resolve this issue. Do you intend to submit it as a pull-request or is it still a work in progress?

I'm running 1.37 and this is still and issue.

I also find that the line diffs and tree view coloring don't work for worktree repositories either.

I see the same behavior.
@leonschoorl any updates on that patch ?


Escape navigation broken

Keypress on esc keyboard touch not working.

Error from e.preventDefault : event was no given as paramer. Fixed with a new custom event triggered when the esc touch is pressed, instead of close() execution directly into the switch instruction.


Expunge the concept of well-known symbols from the checker

Interestingly, there is some fallout here in some odd places:

First of all, some small changes needed to occur to replicate old behavior. Right now, a computed name of type any produces a number index signature. With this change, we make a string index signature instead (it's more broad and closer to correct).
Additionally, late-bound members weren't issuing duplicate declaration errors. With this change, they should.
There's also a fourslash test changes due to the lib in fourslash not-actually-having-symbols (I looked into fixing it to use the built lib, it requires changing a bunch of tests, don't wanna do that here), so the test relied on the old behavior of well-known symbols always "resolving" uniquely, regardless of weather or not they were actually defined.
Lastly, some emit changes - specifically, where previously we'd elide Symbol.iterator when it appeared as a property name (and assume that the expression had no sideffects), now we retain and emit it (and potentially cache it), as we generally do not assume property access expressions are safe to elide or copy.

Fixes #24622
An important implementation note: As we discussed in person, Inside the checker, if we see members of the global SymbolConstructor of type symbol, we also assume you meant to say unique symbol. In this way, we retain compataibility with older libs or definition files (even as they update), which is how this can build (at all), given node is shimming Symbol.iterator as a symbol.

Huh. These changes seem pretty innocuous, but the build of run.js (the tests) runs out of memory on node6 (and only on node6). During sourcemap emit no less, so very late in the process. @rbuckton can you think of anything offhand we'd be doing where the memory consumption of ndoe6 vs node8 would differ enough to crash the process?

@weswigham Ron's sourcemap rewrite should be going in soon so that will hopefully fix the OOM issues you're getting here

Also fixes #31253

This needs some serious rebasing.

This will also fix https://github.com/microsoft/TypeScript/issues/36468

any update on this?

@rbuckton do we have an appetite for looking into this again? It looks like a number of things are getting dupe'd to it. IIRC we held off on it long ago so lib references could be a thing in node, to potentially remove the need for the global SymbolConstructor-symbol-as-unique symbol workaround.

FWIW, this PR would also probably fix https://github.com/immerjs/immer/issues/710.

I'd like to bring this back to our focus. I recently spoke to @benlesh about RxJS and how the library leans on Symbol.observable existing.
So just to start, imagine an augmentation like
interface SymbolConstructor {
    observable: symbol;
}

This is inspired by the existing declarations; however, the symbol-observable library re-exports Symbol.observable. If the declaration file contains code like
const symbolObservable: typeof Symbol.observable;
export default symbolObservable;

that appears to any other code as just symbol.
Trying to switch over to a unique symbol like so
interface SymbolConstructor {
    observable: unique symbol;
//              ^^^^^^
}

won't necessarily work because other libraries have also defined it as symbol
interface SymbolConstructor {
    observable: symbol;
}

interface SymbolConstructor {
    observable: unique symbol;
//  ~~~~~~~~~~
// Subsequent property declarations must have the same type.  Property 'observable' must be of type 'unique symbol', but here has type 'symbol'.
}

I'd like to bring this back to our focus. I recently spoke to @benlesh about RxJS and how the library leans on Symbol.observable existing.
So just to start, imagine an augmentation like
interface SymbolConstructor {
    observable: symbol;
}

This is inspired by the existing declarations; however, the symbol-observable library re-exports Symbol.observable. If the declaration file contains code like
const symbolObservable: typeof Symbol.observable;
export default symbolObservable;

that appears to any other code as just symbol.
Trying to switch over to a unique symbol like so
interface SymbolConstructor {
    observable: unique symbol;
//              ^^^^^^
}

won't necessarily work because other libraries have also defined it as symbol
interface SymbolConstructor {
    observable: symbol;
}

interface SymbolConstructor {
    observable: unique symbol;
//  ~~~~~~~~~~
// Subsequent property declarations must have the same type.  Property 'observable' must be of type 'unique symbol', but here has type 'symbol'.
}

I would like to note that:

I'm sorry. haha
I inherited symbol-observable which was always written this way, while it was in wide use.
This stuff is hard.

I would like to note that:

I'm sorry. haha
I inherited symbol-observable which was always written this way, while it was in wide use.
This stuff is hard.

https://github.com/microsoft/TypeScript/pull/42543 Now supersedes this as an updated version for 2021 - large parts are the same (and the result certainly is), but some of the implementation is different.

https://github.com/microsoft/TypeScript/pull/42543 Now supersedes this as an updated version for 2021 - large parts are the same (and the result certainly is), but some of the implementation is different.


feat: Add couple of shortcuts for content "under point"

(copilot-chat-explain-defun) ask copilot to explain current function under point.
(copilot-chat-custom-prompt-function) ask copilot to apply a custom prompt to the function body under point. Eg. instruct on how to refactor the function.
(copilot-chat-review-whole-buffer) ask copilot to review the current whole buffer. It can be used to review the full class, or, review the magit diff for my change, or other people's change.
(copilot-chat-switch-to-buffer) switch to Copilot Chat buffer, side by side with the current code editing buffer.

Thanks a lot !


data loading

Hello! This is a very nice work!
I am looking into your codes and did not figure out why only the first training file ([0]) was loaded in line 146 of translation.py
examples_train = torch.load(data_paths[0])
Thanks!

IIRC, it splits data, and loads one at a time because of memory limitation. The code is just loading the first chunk, and the iterator will pick the next one after completing each one.
It's my old memory, so I could be wrong :)


[ja] Delete rewrite-target annotation in ingress example

en PR https://github.com/kubernetes/website/pull/46761/files

/approve


Create a policy-collection repository

Community of resources to help you adopt the policy framework and create:

sample and best practices policies and policy sets
generator projects of policies and policy sets
learning resources
deployment resources

Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

/hold

/cc @qiujian16

could we consider to put the policy in https://github.com/open-cluster-management-io/governance-policy-nucleus repo as an alternative? We were trying to avoid maintaining many repos. overnance-policy-nucleus is the repo that policy addon will define APIs and libraries. Putting a set of collections of policies in it sounds reasonable to me.

I think if we start a community around policy controllers then the governance-policy-nucleus repository may be a good fit.  The policy collection community should be separate from that and we are really looking to move our existing repository and fork it back to the current location.

Is the plan to transfer the repo or create a new repo and copy the files?
If it is a transfer, I think there are some openshift specific policies whic you may want to put in the openshift folder so user can understand what can be used with/without openshift. we have to update the readme to avoid mentioning product. We could have a sub folder indicating it is ACM specific policies and can only be used in ACM or openshift.
if it is latter option, since you would lose all PRs history anyway, I feel having it in the governance-policy-nucleus is fine? So that there are API definition in it, together with the real policies.
I am also fine if we have a policy-collection dir in OCM repo. Any thought @mikeshng ?
Another question about https://github.com/stolostron/policy-collection/tree/main/policygenerator. Does it also rely on app addon?

Is the plan to transfer the repo or create a new repo and copy the files?

Transfer the repo is the plan.

If it is a transfer, I think there are some openshift specific policies whic you may want to put in the openshift folder so user can understand what can be used with/without openshift. we have to update the readme to avoid mentioning product. We could have a sub folder indicating it is ACM specific policies and can only be used in ACM or openshift.

Yes, we can update the readmes to make it not ACM specific but for ocm.

if it is latter option, since you would lose all PRs history anyway, I feel having it in the governance-policy-nucleus is fine? So that there are API definition in it, together with the real policies.
I am also fine if we have a policy-collection dir in OCM repo. Any thought @mikeshng ?
Another question about https://github.com/stolostron/policy-collection/tree/main/policygenerator. Does it also rely on app addon?

The policy generator works with just the kustomize command.  It is also integrated with the app addon, but that is not a requirement for taking advantage of the policy generator.
Thanks!

@qiujian16 Are you ok with the transfer of policy-collection as long as we make updates for open-cluster-management and not keep it ACM specific?

yes, I think we need to clarify in the doc it is a transfer rather than create. I would also suggest we update the repo before the transfer, e.g. reorganize the directory, update readme.
I am a bit concerned about no validation tests. I think a minimum API validation test is necessary per PR, otherwise we do not even known if a the API format is correct.

@qiujian16 @mprahl I have updated the PR to add the suggestions that were made.  Take another look when you get a chance and thanks for the reviews!

thanks, it looks fine to me

/unhold


Meta: Use case documentation

As discussed in the 20161024 SIG meeting, we should finalize the use cases for the v1 milestone of service catalog.
Use cases articulated during the meeting:

Adding service brokers into catalog
Catalog curation: which broker-provided services are globally visible?
Catalog curation: which namespaces can see which catalog services?
As a consumer of a service, how do I indicate that I want to consume a particular service?
As a consumer of a service, how do I indicate that I want to bind to an instance of a service?
What is the unit of consumption of a service?  Namespace?  Pod? Something else? (brian to comment)
What is the versioning and update story for a service: example: what happens when a broker changes the services it provides?
When a user binds to an instance of a service, what does that look like?  Which resources are created in their namespace?
What is the update story for bindings to a service instance?
How does the catalog support multiple consumers in different Kubernetes namespaces of the same instance of a service?
How do I control the number and identity of consumers allowed to bind to my instance?
Curation: how do I control who can see a service instance that I have provisioned?
Curation: how do I control the number of consumers of my service instance?

As an addendum to 1. Is there an auth story for adding service brokers? Presumably yes since we want to support private catalogs.

Arguably most important, as @bgrant0607 pointed out in his post to the mailing list, what does consuming a service look like to a user?

A few others:

Does my catalog list not only my service types but also my instances? E.g., I have a dev cluster running on my local machine and I want to connect my application with a database that exists in a test cluster. How do I find that database instance?

Importing a list of brokers: If I have a remote cluster with a service controller that has n brokers registered, how can I import those into my local cluster? Related to the above, can I export a list of service brokers and types from my service controller?

Would it be helpful to group these use cases? Something like:
Catalog Publishing/Curation/Discovery

(1) Adding service brokers into catalog
(2) Catalog curation: which broker-provided services are globally visible?
(3) Catalog curation: which namespaces can see which catalog services?
How are services identified: name, service name/id, plan name/id?

Requesting Services (Consumer)

(4) As a consumer of a service, how do I indicate that I want to consume a particular service?
(5) As a consumer of a service, how do I indicate that I want to bind to an instance of a service?
(10) How does the catalog support multiple consumers in different Kubernetes namespaces of the same instance of a service?

Provisioning/Deprovisioning

(13) Curation: how do I control the number of consumers of my service instance?

Binding/Unbinding

(8) When a user binds to an instance of a service, what does that look like? Which resources are created in their namespace?
(11) How do I control the number and identity of consumers allowed to bind to my instance?
(12) Curation: how do I control who can see a service instance that I have provisioned?

Using the Service (Consumption)

(6) What is the unit of consumption of a service? Namespace? Pod? Something else? (brian to comment)

Lifecycle of Service

(9) What is the update story for bindings to a service instance?
(7) What is the versioning and update story for a service: example: what happens when a broker changes the services it provides?

+1, this is great.

Comments on this issue have been folded into #23.

Reopening, because I think there is another set of use-cases we haven't talked through: use-cases for producing services (ie, how do I run my own service broker)

@pmorie Aren't we just focusing on consumption of blackbox services at this point?

Someone needs to take a pass back through this stuff and make sure it's done.  I believe it is, but I don't have time to check at the moment.  I'm going to move this to MVP 2 because it really needs to be done before Kubecon, not at MVP 1.

I have designated this a meta issue and removed it from a milestone

/remove-lifecycle rotten
/lifecycle frozen

This project is being archived, closing open issues and PRs.
Please see this PR for more information: https://github.com/kubernetes/community/pull/6632
/close


:sparkles: Add more test helpers

Added test helper for getting a valid token
Documented factory boy recipe for setting up a TOTP device

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Failed to instantiate. Error related to multihash lib.

Using orbit-db v0.20.0.rc2 with IPFS v.0.34.4
Environment: browser (Chrome v73.0.3683.86) + Metamask add-on
As soon as I call:
const orbitdb = await OrbitDB.createInstance(this.ipfsNode);
There's an error in the console related to the multihashes library, The function call webCrypto.digest() fails. For reference, this is in the file
crypto-sha1-2-browser.js

The error in the console:
VM53 0.chunk.js:226163 Uncaught (in promise) TypeError: Failed to execute 'digest' on 'SubtleCrypto': The provided value is not of type '(ArrayBuffer or ArrayBufferView)'
    at VM53 0.chunk.js:226163
    at sha2256 (VM53 0.chunk.js:226191)
    at Function.push../node_modules/multihashing-async/src/index.js.Multihashing.digest (VM53 0.chunk.js:226359)
    at Object.hashAndSign (VM53 0.chunk.js:146122)
    at Secp256k1PrivateKey.sign (VM53 0.chunk.js:146285)
    at VM53 0.chunk.js:272930
    at new Promise (<anonymous>)
    at Keystore._callee7$ (VM53 0.chunk.js:272929)
    at tryCatch (VM53 0.chunk.js:335094)
    at Generator.invoke [as _invoke] (VM53 0.chunk.js:335313)
    at Generator.prototype.(/anonymous function) [as next] (https://04b0af17.ngrok.io/static/js/0.chunk.js:335147:21)
    at asyncGeneratorStep (VM53 0.chunk.js:12608)
    at _next (VM53 0.chunk.js:12630)
    at VM53 0.chunk.js:12637
    at new Promise (<anonymous>)
    at Keystore.<anonymous> (VM53 0.chunk.js:12626)
    at Keystore.sign (VM53 0.chunk.js:272948)
    at Identities._callee4$ (VM53 0.chunk.js:262719)
    at tryCatch (VM53 0.chunk.js:335094)
    at Generator.invoke [as _invoke] (VM53 0.chunk.js:335313)
    at Generator.prototype.(/anonymous function) [as next] (https://04b0af17.ngrok.io/static/js/0.chunk.js:335147:21)
    at asyncGeneratorStep (VM53 0.chunk.js:12608)
    at _next (VM53 0.chunk.js:12630)

Any help is greatly appreciated. Thanks :)

@gil-air-may thanks for opening an issue! This appears to be a orbit-db-keystore version problem, can you confirm if you are getting this error with orbit-db@rc3?

@shamb0t, @huhsame, I'm not getting the error on orbit-db@rc3. Thank you so much :smiley:

Awesome! Thanks for using Orbit.


Fix test_subgroups - test as core feature.

Fixes #46

Shouldn't we test both the core and extension entrypoints when both are supported?

Maybe additional test should be added in test_api for this purpose with minimal version checking OpenCL 2.1 ?

I'm not sure I understand how duplicating code into the api suite addresses my comment :).
If these subgroup tests run quickly enough, why wouldn't we modify them to run twice using the core feature and the extension?
My concern is that your patch removes all coverage for the extension on 2.1+ implementations.

If extension is reported on 2.1+ ten test will go the path as today works (KHR in api calls and IFP obligatory).

Yes, I meant the opposite: this doesn't add coverage for the core feature when the extension is present.

@bashbaug How do you think. Does the test should cover situation when extension is present and device is 2.1+ as Kevin writes (verify old and new API calls)? For me presenting extension means use previous API. And this is written in specification https://www.khronos.org/registry/OpenCL/specs/2.2/html/OpenCL_Ext.html#cl_khr_subgroups
No extension and device 2.1+ use new API

I've committed change that removes PRAGMA definitions in case of core subgroups

@bashbaug How do you think. Does the test should cover situation when extension is present and device is 2.1+ as Kevin writes (verify old and new API calls)? For me presenting extension means use previous API.

I think @kpet is right that the extension codepath and the core subgroup codepaths could be slightly different, at least through the frontend compiler.  So, if these tests don't take too long to execute, it seems reasonable to test both codepaths if the implementation advertises support for both the subgroup extension and core subgroups.
If the tests take too long to execute we still may want to consider something like a subgroup "wimpy mode" to at least get some coverage going through both paths.  I just ran the subgroup test on my laptop though and it ran in a couple of minutes, so hopefully this isn't necessary.

I've added changes to test both path - core and extensions.

Summing up latest changes.

split tests cases to test core and extension code path

core path

do not use KHR functions
do not use pragma
IFP optionally

extension path

use KHR functions
use pragma
IFP obligatory

Recent changes include:

do not use global variables
make IFP as separate tests
use stringstream data type
use special class to load function pointer for specific API

Thanks for the changes. The names you picked for the core/ext function/enum unification have really made this a lot less readable but I suggest we don't address this here. I think we're both tired of iterating on this PR :).
Just needs fixing the use of TEST_SKIP. This will fail the test instead of skipping it. See https://github.com/KhronosGroup/OpenCL-CTS/blob/master/test_common/harness/testHarness.cpp#L729

Hi
I am ready to fix if you propose better names. At least test cases names. Regarding  _ext _core postfix -  maybe I should be compatible with previous version and old name should be core, and new test cases should contain "_ext" in name. Additionally I could change names from work_group_functions to subgroup_functions. What do you think ?

These are fine IMHO. I was really thinking of f_ptr and subgroupsApiSet.get_enum_max_size().The core and KHR enums have the same value so there's no need for such a long-winded abstraction. We could just use the core enums (potentially with a static assert to guarantee that they have the same value as the KHR enums but even that is maybe superfluous).
f_ptr could contain the name of the function to make things more readable.

Yes I see this they are the same. Two doubts here:

what if somebody would compile tests against OpenCL 2.0  where only one set of enums are defined
then it looks only IFP test make sens prepare in doubled version. Others could be single , testing core API ?

what if somebody would compile tests against OpenCL 2.0 where only one set of enums are defined

We've agreed in the working group that having the CTS depend on the latest headers was fine.

then it looks only IFP test make sens prepare in doubled version. Others could be single , testing core API ?

Well, we still want to test both sets of API calls. I agree that the difference of coverage is small compared to having to duplicate everything but I think we don't really have a choice. TBH, these tests are quick enough to run that I'm not overly worried.

Hope this time will be better :)


[Feature] - Use Github Actions to create issues for exported reports

🚀  Is your feature request related to a problem? Please describe.
Related:

#37

Using the metrics report exported through the executor, we can use Github Actions workflows to create automated issues containing the reports.
💡  Describe the solution you'd like
Create issues with the exported report as the content using Github Actions.

I think we may use this https://github.com/actions-cool/issues-helper/blob/main/README.en-US.md


Remove asterisk after adding required field (reference)

Once a curator has added a reference to that required field, for clarity, the asterisk should go away so the curator knows the information has been entered correctly.

If evidence is added and the reference goes to grey, that's okay, but if you accidentally start entering information and remove it, then the evidence and/or reference goes to red even if the field is blank.  Curators can still save, but it's confusing to have the red text.


fixed append patch's test case

The  test case is failed on go version go1.9.2 darwin/amd64
Test output is following:
--- FAIL: TestAppend (0.00s)
	operation_test.go:305:
			Error Trace:	operation_test.go:305
			Error:      	Not equal:
			            	expected: []interface {}{1, 2, 3, 4}
			            	actual  : []interface {}{1, 2, 3, 4}

			            	Diff:
			            	--- Expected
			            	+++ Actual
			            	@@ -1,4 +1,4 @@
			            	 ([]interface {}) (len=4) {
			            	- (int) 1,
			            	- (int) 2,
			            	+ (float64) 1,
			            	+ (float64) 2,
			            	  (int) 3,
			Test:       	TestAppend
FAIL
exit status 1
FAIL	github.com/cameront/go-jsonpatch	0.011s

The [1, 2] JSON is parsed as float64, but actual value is defined as int. so these are mis-matched.
In this test case, it is not necessity that foo array's value is number.
So this patch changes the type from number to string.

thanks!

Thanks a lot!
And I’m happy you look and merge #10


Error when upgrading to latest version

I just upgraded my gogs installation to 0.6.9 from 0.6.3, and now I'm getting this error when starting gogs:
2015/09/10 20:21:03 [T] Custom path: /usr/share/gogs/custom
2015/09/10 20:21:03 [T] Log path: /usr/share/gogs/log
2015/09/10 20:21:03 [I] Gogs: Go Git Service <IP_ADDRESS>3 Beta
2015/09/10 20:21:03 [I] Log Mode: File(Trace)
2015/09/10 20:21:03 [I] Redis Supported
2015/09/10 20:21:03 [I] Memcache Supported
2015/09/10 20:21:03 [I] Cache Service Enabled
2015/09/10 20:21:03 [I] Session Service Enabled
2015/09/10 20:21:03 [I] SQLite3 Supported
2015/09/10 20:21:03 [I] Run Mode: Production
2015/09/10 20:21:03 [T] Doing: CheckRepoStats
panic: template: base/head_old:16: function "CdnMode" not defined

goroutine 1 [running]:
html/template.Must(0x0, 0x7fafd0535028, 0xc820355ab0, 0x0)
	/usr/local/go/src/html/template/template.go:330 +0x4b
github.com/Unknwon/macaron.compile(0xc82000b5e0, 0x19, 0x0, 0x0, 0xc82000b600, 0x2, 0x2, 0xc82037e248, 0x1, 0x1, ...)
	/home/wuwen/go/src/github.com/Unknwon/macaron/render.go:276 +0x98e
github.com/Unknwon/macaron.(*templateSet).Set(0xc8204cb500, 0xf49708, 0x7, 0xc8201ca700, 0x0)
	/home/wuwen/go/src/github.com/Unknwon/macaron/render.go:301 +0x4a
github.com/Unknwon/macaron.renderHandler(0xc82000b5e0, 0x19, 0x0, 0x0, 0xc82000b600, 0x2, 0x2, 0xc82037e248, 0x1, 0x1, ...)
	/home/wuwen/go/src/github.com/Unknwon/macaron/render.go:368 +0x211
github.com/Unknwon/macaron.Renderer(0xc8201bcec8, 0x1, 0x1, 0x0, 0x0)
	/home/wuwen/go/src/github.com/Unknwon/macaron/render.go:405 +0x1ee
github.com/gogits/gogs/cmd.newMacaron(0xc8201781e0)
	/home/wuwen/go/src/github.com/gogits/gogs/cmd/web.go:129 +0x768
github.com/gogits/gogs/cmd.runWeb(0xc8201781e0)
	/home/wuwen/go/src/github.com/gogits/gogs/cmd/web.go:188 +0xc2
github.com/codegangsta/cli.Command.Run(0xf55310, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0xfddf20, 0x15, 0x1096100, ...)
	/home/wuwen/go/src/github.com/codegangsta/cli/command.go:127 +0x1052
github.com/codegangsta/cli.(*App).Run(0xc8201fb700, 0xc82000a160, 0x2, 0x2, 0x0, 0x0)
	/home/wuwen/go/src/github.com/codegangsta/cli/app.go:159 +0xc2f
main.main()
	/home/wuwen/go/src/github.com/gogits/gogs/gogs.go:40 +0x35c

Downgrading to 0.6.3 does not help...

Thanks your feedback!
Based on the documentation: http://gogs.io/docs/installation/install_from_binary.html#how-to-upgrade-from-binary%3F
You would have to remove old templates directory first before moving in new template files.

I got the issue fixed. But now the init.d script doesn't work anymore. When I launch ./gogs web manually it does work. But service gogs start doesn't do anything.

I got the issue fixed.

Great!

But now the init.d script doesn't work anymore. When I launch ./gogs web manually it does work. But service gogs start doesn't do anything.

I can't help with this limited information, at least should have error info.

Thing is that I could not really see any errors. I changed my init.d file to the one on master and set /bin/bash as shell for the git user, and now it seems to work.

Thing is that I could not really see any errors. I changed my init.d file to the one on master and set /bin/bash as shell for the git user, and now it seems to work.

Check path/to/gogs binary/log/gogs.log may find something helpful.

Thought I had it fixed but it isn't. Might need to switch to supervisord.

Sounds better to me. :mask:

Supervisord gave this error:
[.../models/publickey.go:60 homeDir()] [E] Fail to get home directory: Cannot specify home directory because it's empty

Was it not needed before?

Was it not needed before?

It is required since v0.2 :joy:

Also, the style/theme seems to change for a couple of pages. Sometimes I get the one with the blue header, and other times I get a white version. Is this related to the upgrade, or is this a known issue?

Please see https://github.com/gogits/gogs/issues/650

Any updates on this?

Close for now but open continuing discussion.


test: sort image list before check

Signed-off-by: Wei Fu<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Since the image mgr return the images list in random order, in testing
we should sort before check and match.
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Describe how you did it
NONE
Ⅳ. Describe how to verify it
NONE
Ⅴ. Special notes for reviews

Codecov Report

Merging #1413 into master will increase coverage by 22.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1413       +/-   ##
===========================================
+ Coverage   16.23%   38.39%   +22.15%
===========================================
  Files         200      248       +48
  Lines       13583    16806     +3223
===========================================
+ Hits         2205     6452     +4247
+ Misses      11224     9529     -1695
- Partials      154      825      +671

Impacted Files
Coverage Δ

daemon/logger/jsonfile/utils.go
70% <0%> (ø)
:arrow_up:

cli/main.go
0% <0%> (ø)
:arrow_up:

cli/tag.go

client/image_tag.go

storage/volume/error/errors.go
28.57% <0%> (ø)

cri/criservice.go
12.5% <0%> (ø)

pkg/system/machine.go
75% <0%> (ø)

storage/volume/core.go
37.13% <0%> (ø)

cri/stream/errors.go
0% <0%> (ø)

storage/quota/quota.go
12.61% <0%> (ø)

... and 115 more

LGTM


using some best attributes and tags

Issue Type:

[ ] Bug Report
[x] Feature Request
[ ] Documentaion

Describe the bug

A clear and concise description of what the bug is.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

heyy@arpit please  assign me.

Issue Type:

[ ]  Bug Report
[ ]  Feature Request
[ ]  Documentaion

Describe the bug

A clear and concise description of what the bug is.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

@Khushbu-kumari-87090 please fill this template properly.

can i add the some fresh nature image with  motivational quotes

can i add the some fresh nature image with motivational quotes

yes

thanks but if are assigned to me this project  so  i  feel so comfotable . so please assign me.

Fill the template first

I will assign it you after that