perf(logging): strip debug log messages at compile-time

close: #2847
Logging debug messages can lead to significant memory allocations, especially when outputting variable values. In Go, even if log_level is not set to debug, these allocations can still occur because the program evaluates the debug statements regardless of the log level.
To prevent unnecessary memory usage, you can strip out all debug-level code from the binary at compile time using build flags. This approach improves the performance of CometBFT by excluding debug messages entirely, even when log_level is set to debug. This technique is ideal for production environments that prioritize performance optimization over debug logging.

Note: Compiling CometBFT with this method will completely disable all debug messages. If you require debug output, avoid compiling the binary with these settings.

In order to build a binary stripping all debug log messages (e.g. log.Debug()) from the binary, use the nodebug tag:
COMETBFT_BUILD_OPTIONS=nodebug make install

once it's installed you can run a kvstore example with log_level = "debug" set in the config.toml and you will see that no debug messages are shown in the log.
cc: @ValarDragon
PR checklist

[ ] Tests written/updated
[X] Changelog entry added in .changelog (we use unclog to manage our changelog)
[X] Updated relevant documentation (docs/ or spec/) and code comments

We're still incurring the cost of calculating arguments (if they are not Lazy), correct? Have you done any benchmarks? Curious about the results 🦊

Is doing this at compile time best? feels hard to get operators to re-compile, vs having a global variable being set off of the config reading

We're still incurring the cost of calculating arguments (if they are not Lazy), correct? Have you done any benchmarks? Curious about the results 🦊

I will add more insights about this today before merging.

To clarify the solution, it leverages a Go feature that removes dead code at compile time. Essentially, this strips out any Debug instructions from the final binary, ensuring zero allocations since these instructions don’t exist in the compiled output.
For example, here's the Debug func in the tm_logger.go file.

Note that it is on line 63. If we compile a binary that includes the debug messages (e.g. don't compile with the nodebug tag), you can see from the objdump that these instructions are part of the binary
(cometbft) > go tool objdump ./build/cometbft | grep tm_logger.go:63
  tm_logger.go:63                       0x100278570             f9400b90                MOVD 16(R28), R16
  tm_logger.go:63                       0x100278574             d10083f1                SUB $32, RSP, R17
  tm_logger.go:63                       0x100278578             eb10023f                CMP R16, R17
  tm_logger.go:63                       0x10027857c             54001209                BLS 144(PC)
  tm_logger.go:63                       0x100278580             f8160ffe                MOVD.W R30, -160(RSP)
  tm_logger.go:63                       0x100278584             f81f83fd                MOVD R29, -8(RSP)
  tm_logger.go:63                       0x100278588             d10023fd                SUB $8, RSP, R29
  tm_logger.go:63                       0x1002787bc             f90007e0                MOVD R0, 8(RSP)
  tm_logger.go:63                       0x1002787c0             f9000be1                MOVD R1, 16(RSP)
  tm_logger.go:63                       0x1002787c4             f9000fe2                MOVD R2, 24(RSP)
  tm_logger.go:63                       0x1002787c8             f90013e3                MOVD R3, 32(RSP)
  tm_logger.go:63                       0x1002787cc             f90017e4                MOVD R4, 40(RSP)
  tm_logger.go:63                       0x1002787d0             f9001be5                MOVD R5, 48(RSP)
  tm_logger.go:63                       0x1002787d4             aa1e03e3                MOVD R30, R3
  tm_logger.go:63                       0x1002787d8             97f8157a                CALL -518790(PC)
  tm_logger.go:63                       0x1002787dc             f94007e0                MOVD 8(RSP), R0
  tm_logger.go:63                       0x1002787e0             f9400be1                MOVD 16(RSP), R1
  tm_logger.go:63                       0x1002787e4             f9400fe2                MOVD 24(RSP), R2
  tm_logger.go:63                       0x1002787e8             f94013e3                MOVD 32(RSP), R3
  tm_logger.go:63                       0x1002787ec             f94017e4                MOVD 40(RSP), R4
  tm_logger.go:63                       0x1002787f0             f9401be5                MOVD 48(RSP), R5
  tm_logger.go:63                       0x1002787f4             17ffff5f                JMP -161(PC)
  tm_logger.go:63                       0x1002787f8             00000000                ?
  tm_logger.go:63                       0x1002787fc             00000000                ?

If you compile a binary with the nodebug tag, it will strip out all the instructions for Debug:
(cometbft) > COMETBFT_BUILD_OPTIONS=nodebug make build
CGO_ENABLED=1 go build -mod=readonly -ldflags "-X github.com/cometbft/cometbft/version.CMTGitCommitHash=980d8a315  -s -w" -trimpath -tags 'cometbft nodebug' -o /Users/andynogueira/Development/Go/src/github.com/cometbft/cometbft/build/cometbft ./cmd/cometbft/
(cometbft) > go tool objdump ./build/cometbft | grep tm_logger.go:63
(cometbft) >

I recognize that, from an operator's perspective, re-compiling a binary may not initially seem ideal. However, this approach is the safest and most effective way to eliminate any risk of extra allocations from debug messages, ultimately boosting performance for operators. Given these benefits, I believe re-compilation will be a reasonable step for them.
Alternatively, we could explore a solution based on conditional statements (if checks), though this would involve a significant refactor and still might not fully eliminate allocations. If needed, I can add additional tests to validate these outcomes and ensure reliability

compile time is the way 👍

The question for me now is whether the official binaries should have debug level enabled or not.
I agree with @ValarDragon that changing the executed binary when we want to debug something is not really the best way to go.
At the same time, this is another (apparently very efficient) option to reduce the cost of debug log calls, when debugging is disabled.

We agreed this is a good use case for operators looking for optimal performance. However, there might be alternatives that would require more refactoring but would allow a granular and configurable approach to the problem. I will merge this and say it partially closes the issue. In the future, I can submit another PR that implements the other approach, too, so this way, we will cater to multiple operators.


cargo build --release error cargo:warning=cc1: fatal error: ggml/src/ggml.c: No such file or directory

Found an issue when try to cargo build --release
error message
Compiling ggml-sys v0.1.1 (/home/rob/llm/crates/ggml/sys)
The following warnings were emitted during compilation:
warning: cc1: fatal error: ggml/src/ggml.c: No such file or directory
warning: compilation terminated.
error: failed to run custom build command for ggml-sys v0.1.1 (/home/rob/llm/crates/ggml/sys)
Caused by:
process didn't exit successfully: /home/rob/llm/target/release/build/ggml-sys-e7677f9beb0f9605/build-script-build (exit status: 1)
--- stdout
cargo:rerun-if-changed=ggml
OPT_LEVEL = Some("3")
TARGET = Some("x86_64-unknown-linux-gnu")
HOST = Some("x86_64-unknown-linux-gnu")
cargo:rerun-if-env-changed=CC_x86_64-unknown-linux-gnu
CC_x86_64-unknown-linux-gnu = None
cargo:rerun-if-env-changed=CC_x86_64_unknown_linux_gnu
CC_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=HOST_CC
HOST_CC = None
cargo:rerun-if-env-changed=CC
CC = None
cargo:rerun-if-env-changed=CFLAGS_x86_64-unknown-linux-gnu
CFLAGS_x86_64-unknown-linux-gnu = None
cargo:rerun-if-env-changed=CFLAGS_x86_64_unknown_linux_gnu
CFLAGS_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=HOST_CFLAGS
HOST_CFLAGS = None
cargo:rerun-if-env-changed=CFLAGS
CFLAGS = None
cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "ggml/include/ggml" "-I" "legacy" "-pthread" "-mavx" "-mf16c" "-msse3" "-DNDEBUG" "-o" "/home/rob/llm/target/release/build/ggml-sys-2a7930b36525a1be/out/ggml/src/ggml.o" "-c" "ggml/src/ggml.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "ggml/include/ggml" "-I" "legacy" "-pthread" "-mavx" "-mf16c" "-msse3" "-DNDEBUG" "-o" "/home/rob/llm/target/release/build/ggml-sys-2a7930b36525a1be/out/legacy/qnt0.o" "-c" "legacy/qnt0.c"
cargo:warning=cc1: fatal error: ggml/src/ggml.c: No such file or directory
cargo:warning=compilation terminated.
exit status: 1
exit status: 0
--- stderr
error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "ggml/include/ggml" "-I" "legacy" "-pthread" "-mavx" "-mf16c" "-msse3" "-DNDEBUG" "-o" "/home/rob/llm/target/release/build/ggml-sys-2a7930b36525a1be/out/ggml/src/ggml.o" "-c" "ggml/src/ggml.c" with args "cc" did not execute successfully (status code exit status: 1).

I think you've yet to pull in submodules, so try running git submodule init && git submodule update

T

Thanks for your help , it works now,


vscode like minimap for mini graph

Is your feature request related to a problem? Please describe.
Currently, mini graph is a dock. It show and un-shows when main view is in graph view. Most time, its hard to figure out where to put mini graph. Most of the time, I put it on left side along with cross-ref and symbols which takes more space. Also it can be kinda buggy with reflection view.
Describe the solution you'd like
It would be nice if mini graph is part of graph view pane kind of like minimap  in vscode. Kinda like vscode minimap but for mini graph.

Describe alternatives you've considered
Currently, I just put it on place where I have space for. I know that binary ninja UI change is coming. Maybe it might be good to have tab for mini graph?? Or somewhere in tab menu on new Binja GUI coming up.

So the primary downside to just having it be off to the right is that ideally the minimap would have a similar aspect ratio to the main graph view.
As part of the UI refactor we're considering having something along the lines of a hotkey that renders the overview in the existing graph viewport (think along the lines of a diablo 2 style automap), as that way it isn't competing for space normally but gets a sufficiently large viewport to be useful when needed.


"Resource not found" error when uploading file and database is not running

Quasar advanced was running, but mongo was not started. In console output was like this
Using metastore: jdbc:h2:file:/Users/safareli/Library/Application Support/quasar/quasar-metastore.db
Warning: Failed to mount '/test/' because 'Connection failed: java.util.concurrent.TimeoutException: Timed out attempting to connect to: [localhost:27017]'.
Server started listening on port 8080

But server was still working.
Then I tried to upload some file, but got error Resource not found:

I guess we can say why we can't upload file rather than showing such general error.

I think 404 is the correct status here - the resource is unfindable when the database isn't present.
Either way, I don't think this repo is the right place for this issue - it's either an enhancement to quasar to give us more info when this fails (although, did you check to see exactly what the 404 response contained?), or it's an issue for SlamData to display the error message differently.

response contains this:
{ "error": { "status": "Path not found.", "detail": { "path": "/tmp" } } }


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 15:39:29 on 2023.04.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 16132
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=16132

Problem has been resolved in 3m 0s at 15:42:29 on 2023.04.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 16132


Control via keyboard on Safari

Hello, that's a lil fix to control playback via keyboard on Safari (macOS Sonoma).

It seems that the element naming is changed.
Neither .player-controls-content .YtmProgressBarProgressBar or .player-controls-pb .ytm-progress-bar works.


Should this be possible?
Should HList's maintain literal-types?

Because github had issues earlier today I could not see this issue was really added so I already posted the question to StackOverflow too: https://stackoverflow.com/questions/52923708/shapeless-hlist-literal-types-erased?noredirect=1#comment92763221_52923708

Stack Overflow or the shapeless gitter channel are the right places for this sort of question.


Add ability to set hostname via DHCPv4 client

Problem:
We need to provide the option of allowing system hostnames to be set via DHCP.
Solution:
This adds a boolean config option, os.dhclient_set_hostname, which maps to DHCLIENT_SET_HOSTNAME in /etc/sysconfig/network/dhcp.
When running the installer interactively, there's a new "Set via DHCP" drop down field on the hostname page.  The default is "no".

If the user selects "yes", this will later be shown on the confirmation screen as "hostname: XXXX (will be set via DHCP)", to indicate that the provided hostname will be overridden by DHCP:

For automated installs, either set os.dhclient_set_hostname: true in the config yaml, or pass harvester.os.dhclient_set_hostname=true as a kernel command line argument.
In order for this setting to take effect, your DHCP server needs to be configured to send the host name option to the client.  For more information see man dhcpd.conf (look for "option host-name" and "use-host-decl-names on").
Note that even if os.dhclient_set_hostname is set to true, we still require the user to provide a hostname during installation, because that will be written to /etc/hostname and be used by the system briefly early in the boot process, before DHCP does its thing.
Related Issue:
https://github.com/harvester/harvester/issues/1444
Test plan:

Configure a DHCP server to set the host name option (TBD: add more details here, possibly including tweaks to ipxe-examples)
Boot the installer, but leave "Set via DHCP" set to "no"
Verify that whatever hostname the DHCP server wants to set, doesn't get set.
Repeat the above, but set "Set via DHCP" to "yes"
Verify that whatever hostname the DHCP server wants to set, does get set, both during installation (after network config is applied), and then subsequently once the system comes up for real.

What will happen if the dhcp server doesn't set the hostname for the IP?
Will it fallback to manual hostname setting and give a warning or simply bypass?

It just falls back to the manual hostname setting. AFAICT there's no warnings anywhere if the DHCP server doesn't send a hostname. That would be up to wickedd and/or wickedd-dhcp4 to do, but from looking at the wicked code and experimenting with extra debugging information turned on, wicked doesn't seem to really care whether or not the DHCP server sends a hostname or not. If the server does send a hostname and DHCLIENT_SET_HOSTNAME is set to "yes", it will be used, but it won't complain at all if either of those things aren't true.

Closing in favour of #726


allow admins to perform activity check for people

https://github.com/redditdota2league/server/commit/13120e7059e9e4f51cdfc149c9b2867eca45b392


Replace XCTests with Swift Testing

There was trouble in running the tests, something with the schemes on my end. Only could run on scheme ignite-package, though they'd crash.

Also PublishingContext required changes because of missing from: argument, plus extra root argument

Hello! Thank you for this contribution. Why are we moving to Swift Testing?

A Swift Testing move isn't the wrong idea. A couple tests in this repo were some of my earliest testing attempts using XCTest. Learning Swift Testing has been more intuitive than working with XCTest. Plus, providing functional examples. For me, functional examples are the primer for understanding or reference new practices better. Given that this repo is still in development phases, implementing Swift Testing as its standard isn't a heavy lift. Hopefully this clarifies this, even if somewhat opinionated.

I understand you might find it easier to learn Swift Testing, but there are much better ways to learn it than adopting it in a public project, and it would also cut us off from the many thousands of people who already use XCTest. While I could understand moving to Swift Testing once it has gained more traction, right now it has a really tiny percentage share of usage in the Swift world, so I'd rather stay away from it here for the time being.

Here's a split testing commit, let me know if you'd like that changed.

Unless I'm reading it wrong, this still seems to be bringing Swift Testing into the project, which again is not something I would support at this time.

I'm keen to either move ahead with this, or close it; I don't want to leave it lingering.

Thank you for your patience regarding this.

Two Testing Targets are present and both run when called

Swift Testing -> IgniteTesting
XCTests -> IgniteTests

All tests work but not all test may be helpful

NavigationBar Test needs some work as does the Element itself as previous test weren't building
Text Test had some inaccuracies. Need confirmation that test change reflects accurate use specifically test_customFont() Note: Swift Testing will allow this test to be rewritten using arguments at some point

Are you happy for this to be merged? It would mean pushing ahead with Swift Testing at a fairly fast pace.

Yessir. There's not much complexity within the test just yet, we still have XCTests as comparisons, and after some more familiarizing I'm confident and comfortable these test will continue to prove useful.

Okay, then let's give it a whirl!


Stash LoadBalancingPolicy on ClusterConfig

Currently the ILoadBalancePolicy is get from a dictionary on each request in LoadBalancingMiddleware.
https://github.com/microsoft/reverse-proxy/blob/5cfbc328dec97048d751e2e3b396ec26993c7bd1/src/ReverseProxy/Middleware/LoadBalancingMiddleware.cs#L54
Can we stash a ILoadBalancePolicy on ClusterConfig when building a cluster to improve the performance?

That's an interesting idea. @MihaZupan @alnikola has the load balancing policy lookup shown up in the CPU profiles at all?

The same thing also could be done for IPassiveHealthCheckPolicy.
https://github.com/microsoft/reverse-proxy/blob/5cfbc328dec97048d751e2e3b396ec26993c7bd1/src/ReverseProxy/Middleware/PassiveHealthCheckMiddleware.cs#L40-L42

Triage: We should first prove it shows up on profiles to justify the complexity.
Per @MihaZupan dictionary lookups are cheaper in .NET 5 as well and it didn't show up in @alnikola profiles so far ...

A few Dictionary improvements I had in mind (looks like they all made it in 5.0):
https://github.com/dotnet/coreclr/pull/27195
https://github.com/dotnet/coreclr/pull/27299
https://github.com/dotnet/runtime/pull/36252

Triage: Closing - the work in #734 did not bring the expected gains. Not worth it.


Feature request: Allow for creating a remote folder

We have a small chain for generating and uploading some documentation where we tried this tool for the upload step. But when uploading into a folder on the remote that does not exists I get the following error:
"... ERROR - Error while opening remote folder. Are you sure it does exist?"
Would it make sense to allow the creation of a remote target folder if it does not already exist?
If so how would be a good way to go about it, and should we try to open a pull request - if we manage to come up with a working change?

Yes, I think that it would definitely make sense, as your use case shows.
A pull request would be awesome and a good starting point is probably here, i.e. at the line that is creating the error.
One way to proceed could be as follows:

On error, try creating the remote folder.
Log its creation to the user to keep her informed.
(Maybe) Add a command line flag to enable this behaviour.

I'm here if you need any help :)

Great will give it a try.


Fix Haxe spelling

"HaXe" is an old spelling that was changed a while ago:
https://groups.google.com/d/msg/haxelang/O7PB-ZrX4i4/uL69CT44C-IJ

Coverage remained the same at 99.668% when pulling 87f8bde7624e6fa1a4f9ed2b25381bb13901eace on Gama11:patch-1 into 2d3864a10b207d1ec78714375f4f2216f974daee on wakatime:master.

Thanks!


Add diagnostics test

Added diagnostic tests to the test suite. Works the same as the tree tests.
This includes the .diag files for the current state of the parser.
Additionally I fixed a bug in the DiagnosticsProvider when a use declaration with an empty use clause list is checked.

Thanks, this is awesome! I think the test failures are just what was fixed by the other PR, right?

Yes, I see you just merged the other PR so I can rebase this branch on the new master. Just a moment :)

Ok, checks do pass now!
Please note that I have only added checks for the ParserGrammar tests, the lexer and validation tests do not do diagnostic checking. But I think this covers plenty of cases for now.


Unable to forget season release from series database

Sorry @liiight, I didn't even think to test this the other day.
Expected behaviour:
flexget series forget ShowName S01

forgets S01 from ShowName.
Actual behaviour:
Unknown identifier S01 for series ShowName
Steps to reproduce:

Step 1: Add season pack to series database.
Step 2: Try to forget it.


[Feature Request] TokenLocker

Feature Request
Describe the Feature Request
Implement a token locker to lock the given token for a period of time.

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

work


Add missing chat channels

Just adds the few channels that were missing.

I wish I knew where those came from. Sorry for not noticing before,

Whoops, forgot about this.  Thank you!!


Plot.fn()

Also, accidental discovery: methods on Squiggle objects are easy to implement, won't even need a parser change.
We can have arr.length and dist.inv(0.5) and so on. (see the refactoring from $_atIndex_$ to get method on Value objects).
TODO:

[ ] disable minX/maxX fields in UI settings for function plots, or make them override the defaults
[x] fix tests

Codecov Report

Merging #1610 (4c8c510) into develop (14e7d44) will increase coverage by 0.79%.
The diff coverage is n/a.

:exclamation: Current head 4c8c510 differs from pull request most recent head 2b56465. Consider uploading reports for the commit 2b56465 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop    #1610      +/-   ##
===========================================
+ Coverage    73.12%   73.91%   +0.79%
===========================================
  Files           93       93
  Lines         5030     5080      +50
  Branches       846      856      +10
===========================================
+ Hits          3678     3755      +77
+ Misses        1327     1300      -27
  Partials        25       25

see 20 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Now that I think about it, one issue is that this is called Plot.fn, but it works for 1-float functions. This is probably an okay default, but I'm sure we'll soon want other options for other cases - like functions of 2 variables, for example.

I added support for rendering Function.declare as well:
https://squiggle-website-git-custom-plots-quantified-uncertainty.vercel.app/playground#code=eNo1yb0OwiAUBtBX%2BXInNejSuNzV6As42g6k0EhSLoZCxFDe3Z%2FE9ZxKyz08r9l7HV%2FEKWarfnQ2LoX4F2Mnned0CsYS0yXLmFyQg7HjrKPd1F6ASRgVa1lRdgVNfc3JI6eFcavw7vP7TsHrwjiiDb20LbU34kAseQ%3D%3D
Also fixed settings:


Support techzone CE pattern

Adds scripts for creating two tenant environment from TechZone reservation (prefixed with tz-):

script to update config files for global and tenants from values from reservation
remove buildah from pre-req check
use first (tenant A) code engine project as build environment for container images
scripts tested in Cloud Shell
do not create appid, postgres as these are created in techzone reservation

These were the checks:


What are the key features of Ethereum 2.0?

Proof of Stake, sharding, and reduced energy consumption.


Wildcard certificates support request.

Issue description
When the wildcard certificates support will be provided?
Steps to reproduce

Run the "letsencrypt.exe"
Select 'N' - Create new certificate
Select '4' - Manually input host names
Input: *.domain.com

Actual result:
[EROR] No (valid) host names provided, wildcard certificates are not supported yet.
[EROR] Plugin Manual was unable to generate a target
Expected:
Program allows to generate wildcard certs.
Client version: : v<IP_ADDRESS>
Windows version: Windows Server 2016 10.0.14393

I'm also adding to the requests. This utility is actually so useful! But I'm in need of a wildcard certificate and it's a pity that I can't handle it with it :(

Also need of a wildcard certificates

Thanks for the feedback! This is the central issue to track ACMEv2/wildcard support, please refer there for future updates: https://github.com/PKISharp/win-acme/issues/464


Version ambiguity

When I issue "gvm install 1.8" does it install 1.8.0 or the latest 1.8.something?

It will install go1.8.0.


GCM registration failures due to unsafe header error

See https://github.com/Azure/azure-mobile-services/issues/711.
This may changes on in the server SDKs or perhaps with the platform level CORS functionality, but tracking here since it impacts Cordova customers.

'Location' header is part of Registration APIs, the newer Installation APIs we consume from NH no longer requiring accessing this header.

I have the same error and i am in version 1.2.8. I am trying to connect a Cordova/Ionic app. So I which version is this solver?
And in order to use version 2 do I have to migrate from Mobile Services to App Service? I am confused with this. Thanks

you need to configure CORS on your server to always return the 'Location' as an allowed header.  If using a .Net Service that is pretty easy, if using Node it gets more complicated (as Node echoes what you ask for, so you must actually make the client ask to be able to access Location first)


Modernize Python 2 code to prepare for Python 3

$ futurize --stage1 -w .
I do not understand how to deliver 100% test coverage while adhering to the Python porting best practice use feature detection instead of version detection.

See the original commit message?  How do we get to 100% test coverage (or lower that threshold)?

See the original commit message... How do we get to 100% test coverage (or lower that threshold)?

Yeah, there's be no way to get both python2 and python3 happy with that block so disabling coverage makes sense:
# TODO: remove when Python 2.x is no longer supported
try:  # pragma: no cover
    cmp
except NameError:  # pragma: no cover
    def cmp(x, y):
        return (x > y) - (x < y)

On Python 3:
Ran 90 tests in 0.943s
FAILED (errors=32, failures=11)
The command "./script/cibuild" exited with 1.

allow_failures has its place.  I encourage you to merge this PR as is and then we can work on the 32 + 11 in other PRs.

Pushed up some passes at moving this further along over in https://github.com/github/octodns/pull/384. It's still not complete, but a lot closer. Main hiccup is dependent libraries that aren't python3 compat, the one I'm sure about is incf.countryutils. Azure may be happier with newer versions, but I haven't had a chance to dig into that yet.
Anyway opened https://github.com/github/octodns/pull/384 rather than push substantial changes here so it probably make sense to consider ^ as a continuation of this PR. Going to close this one and follow up discussion can happen there. Feel free to open PRs against that PR if you end up having further commits.


[DO NOT MERGE] Update to remove .button class

This PR is part of the work to remove govuk_frontend_toolkit from static, specifically to remove the .button class. Work has previously been done in govspeak to change it to use the govuk_publishing_components gem to render buttons (removing the reliance on the .button class there) and a new version of the components gem produced to account for this change in the govspeak component.
This PR updates whitehall to have both of these changes. It also fixes a test that expected the old class. While whitehall does make use of the .button class, it appears to be relying on its own styles for this, not the styles from static.
Trello card: https://trello.com/c/d8D7JTJE/203-remove-design-patterns-buttons-from-static

https://github.com/alphagov/govspeak/pull/176


GH-38887: [C++][Parquet] Move EstimatedBufferedValueBytes from TypedColumnWriter to ColumnWriter

Rationale for this change

Trying to put EstimatedBufferedValueBytes from TypedColumnWriter to ColumnWriter.
What changes are included in this PR?

put EstimatedBufferedValueBytes from TypedColumnWriter to ColumnWriter.
Are these changes tested?
No, just interface change

Are there any user-facing changes?
Yes, interface changed

Closes: #38887

But this introduces a minor breaking change.

Though TypedColumnWriter is not PARQUET_EXPORT, some user might rely on it. We can keep this and let user fixing the compiling, or just add a wrapper for it.

IMO, this is really a minor breaking change and it is very easy for users to fix. So I don't think we need to add a wrapper or something.

Merged, cc @Hattonuri


Azure Core - Poller  - Block / Block Until [State Checks missing]

Block - check if the poller has not already competed before blocking.
Block Until - check poller is not already in the target status and is not already completed.
in azure-core/util/polling/Poller.java

Related https://github.com/Azure/azure-sdk-for-java/issues/5809 and https://github.com/Azure/azure-sdk-for-java/issues/5805

@anuchandy could you please coordinate with @g2vinay on the related Poller reliability issues #5805 #5809 #5923

@joshfree - I'm reviewing the current implementation of poller, left some observations here - https://github.com/Azure/azure-sdk-for-java/pull/5932#pullrequestreview-304279959, still looking into the code.

We're working updating Poller implementation, this issue is related to multi-casting and not applicable in the new design.


feat(ipc): allow receiving arbitrary text on IPC socket

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other: Replace this with a description of the type of this PR

Description
Instead of just allowing hook numbers to be executed, the user can
send arbitrary text and the IPC module will put it in the bar. The IPC
payload format is extended to accept an arbitrary string if the first
character after the module name is ':'.
polybar-msg hook test :'%{F#4444ff}hello%{F-}'

I did not make a new module as requested by @patrick96 as the modifications to the IPC module are minimal and the actions are reused as is. Tell me what you think.
Related Issues & Documents
Fix #2455
Documentation (check all applicable)

[ ] This PR requires changes to the Wiki documentation (describe the changes)
[x] This PR requires changes to the documentation inside the git repo (please add them to the PR).
[ ] Does not require documentation changes

Just to show an example, here is a piece of code to display Network Manager state: https://github.com/vincentbernat/i3wm-configuration/blob/7df5011824cc55ffa9d3ac8b32bb680d63ac083d/bin/i3-companion#L454.
[module/network]
type = custom/ipc
hook-0 = cat $XDG_RUNTIME_DIR/i3/network.txt
initial = 1


Create a simulation utilizing Unity for comparison

Look for optimizations of this scene based on own knowledge and input from others.

I'm going to close this out. The scene has been created unity-rigidbody-example. There may or may not be a bunch of optimizations that could be made but there is no reason to keep the issue open for now.


Refactor Tree.export's on_node

On top of #1794

Refactors on_node

Addresses part of https://github.com/mirage/irmin/pull/1794#discussion_r830016058 by making sure that all the tree nodes exported go through Node.export.

Identifies 3 new edge cases which now result in exceptions. This led to modifications in test/irmin/test_tree.ml | test_fold_force.

I just verified that this fixes the failing test in irmin-server

I added a test that exposes the bug without relying on https://github.com/mirage/irmin/pull/1794, so the two PRs can be merged independently.


Entry not found in cache ... step 5of6 in "Exercise - Create an Azure Static Web App"

Does this occur consistently?
Repro steps:

Action: staticWebApps.createStaticWebApp
Error type: Error
Error Message: Entry not found in cache.
Version: 0.4.0
OS: win32
OS Release: 10.0.19041
Product: Visual Studio Code
Product Version: 1.48.2
Language: en

Call Stack
s.createError extension.js:16:58035
b.<anonymous> extension.js:393:42004
extension.js:393:36599extension.js:393:36599
extension.js:243:74686extension.js:243:74686
extension.js:243:72667extension.js:243:72667
extension.js:243:72287extension.js:243:72287
i.find extension.js:243:106819
extension.js:243:53526extension.js:243:53526
processTicksAndRejections task_queues.js:85:5

1. following "Exercise - Create an Azure Static Web App" on the link:
    https://docs.microsoft.com/en-us/learn/modules/publish-app-service-static-web-app-api/4-exercise-static-web-apps?pivots=react
2. everything up to and including step 4of6 was done and ok
3. failing on step 5of6 :( ... displays "Entry not found in cache" (regardless on action: typing build/Enter/Cancel), see enclosed screenshots
![Entry not found in cache](https://user-images.githubusercontent.com/6133609/96407249-35cc0480-119e-11eb-8e2e-21f237e9a372.PNG)
![Create Static Web App (5of6)](https://user-images.githubusercontent.com/6133609/96407278-42e8f380-119e-11eb-9ee5-5f3939e8d47b.PNG)

sorry ... jumped the gun :)
actually the issue happened to be witchy midnight ...
my sandbox (1st of 10) expired, needed new sandbox (2nd of 10)
after created it, and repeated the whole process, it worked !!!

closing the issue ... that's what happened when exercise spanned over sometime (overflows into new day)


Incorrect error report for missing --rpc-url in forge script

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (1044042 2023-08-10T13:09:55.662307000Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
When running forge script with a missing --rpc-url value, the error output is: error: a value is required for '--fork-url <URL>' but none was supplied. Instead, the error output should be: error: a value is required for '--rpc-url <URL>' but none was supplied.

Right, this is because rpc-url is an alias to fork-url—this message is constructed automatically by the CLI lib we use. While it's definitely not the exact value used, it's not necessarily a big deal (this could probably be filed on clap though)


Fully translate project to kotlin

Some of project files were written in Java. This pull request translates them into Kotlin.
The project compiles, but has not been tested.

@systemallica
Thank you for great work.

Some of project files were written in Java. This pull request translates them into Kotlin.

I don't think to have to convert java file to kotlin. because PyCahrm is going to provide APIs (extension points).
I would rather keep it than convert java to kotlin. It will be easy to change code when the APIs will be provided.
How do you think about it?

The project compiles, but has not been tested.

SDK tests are very difficult for me.
PyCharm almost doesn't have a test for SDK.
Also, a lot of code will be replaced APIs, It means the code will be removed in the future.

Well if you think the code will be replaced in the future, indeed, there's no need for translating it :)
Up to you!

@systemallica
Sorry, I close the issue.
We should re-check it when we have finished supported all APIs.
Thank you for your understanding.


Add justified block to Ethereum JSON-RPC

Adds justifiedBlockHash as additional parameter to the ForkchoiceStateV1 data structure in Engine API
Adds justified tag to block tags available in JSON-RPC

Depends on https://github.com/ethereum/execution-apis/pull/200
TODO

[x] corresponding change to consensus specs

https://github.com/ethereum/consensus-specs/pull/2859

Closing this PR for the reason outlined in https://github.com/ethereum/consensus-specs/pull/2859


PowerShell terminal is displaying dark colors as bright colors

Even though I set the minimum contrast ratio to "1", PowerShell terminal is displaying dark colors as bright colors:

VS Code/OS Version:
Version: 1.82.0 (user setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Datum: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
Betriebssystem: Windows_NT x64 10.0.19045

Steps to Reproduce:

TypeWrite-Host -ForegroundColor Yellow 'Test'

TypeWrite-Host -ForegroundColor DarkYellow 'Test'

This is working as designed because it's up to the theme to control these colors:

@daviddossett a slight differentiation of these colors would be nice in the new modern themes

Thank you.
This is particularly necessary to test and verify the output of a PowerShell script that's supposed to be published.
Without these dimmed colors, it is impossible to highlight portions of a text, and the setting terminal.integrated.drawBoldTextInBrightColors doesn't make sense.

@SetTrend VS Code supports it fine, just the default themes don't. So in the meantime you should change your theme to one that has different colors for the bright colors, or set them manually via the workbench.colorCustomizations setting


Mac Build issues

In all build scripts you find:
WD=$(readlink -f "`dirname $0`/..")
which does not work on Mac.
WD=`pwd`
works fine.

Hi @tmanthey, I knew the behaviour difference between BSD readlink and GNU readlink, but you could get the later one by brew install coreutils. However, pwd is not the equivalence.
Thanks.


Display of large scanned PDFs on IOS devices

This fix is linked to the following issue: https://github.com/mozilla/pdf.js/issues/9474
For the RGB images, the idea is to resize the image by reducing each scale * scale box of pixels to one pixel. We are parsing the image with a square box of scale * scale and for each iteration we are calculating an average of the pixels color inside the box and create one pixel with the average value. The algorithm works perfect for images that have the height and width multiple of scale. To address images that do not fit in that category we have applied the algorithm separate to the main area of the image (the area that is divisible by scale) and to the side areas, the right side, the bottom side and the bottom right.
For the B&W images the idea is to resize the image by increasing the image depth. From a B& W image we are going to create a Gray-scale image.
In a B&W image each bit represent a pixel. We have created an algorithm to scale by 2 and another one to scale by 4.
To scale the image by 2 we've grouped each 2 consecutive bits from the current line and the next line (line + 1) in a square of 4 bits. Then we've created a new byte (pixel) by multiplying the number of bits set to 1 (white) with 256 (white value on a gray-scale image) and divided the result by 4 (because we have considered 4 pixels).
To scale the image by 4 we've grouped each 4 consecutive bits from the current line with 4 consecutive bits from the next 3 lines below in a square of 16 bits. Then we've created a new byte (pixel) by multiplying the number of bits set to 1 with 256 and divided the result by 16 (because we've considered 16 pixels).
The problem for the B&W scaling algorithms is when the image width is not divisible by 8 and/or image height is not divisible by scale. For those cases we've created a separate scaling algorithm which we will call for each side areas (right side, bottom side and bottom right).
While an RGB image can be scaled by any factor, the B&W images can only be scaled by 2 or by 4. However a scale by 2 means the new image size will be 4 times smaller, and a scale by 4 will create a new image with a size of 16 times smaller. We chose to do the B&W scaling only by 2 and 4 because of performance.
Below are the PDFJS files that I've changed:
•	src/core/image.js
•	src/display/canvas.js
•	src/shared/util.js

Can someone please take a look at the Travis CI build fail ? I am not sure why is that failing.
Thank you,
Ioan

The unit tests running in the node environment are failing. Looks like some of your code assumes it's always running in a browser.  run gulp unittestcli to reproduce

I see the error but it doesn't tell me much to know where it's coming from
events.js:160
throw er; // Unhandled 'error' event
^
Error: spawn node_modules/.bin/jasmine ENOENT
at exports._errnoException (util.js:1020:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:197:32)
at onErrorNT (internal/child_process.js:376:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
I've only changed 3 files, image.js and util.js don't have browser context, and in canvas.js I can't find any place in my changes where I would assume I run in a browser.
Can you please suggest anything that can give me more details on the error ?
Thank you,
Ioan

https://travis-ci.org/mozilla/pdf.js/builds/364151853#L587

Looks like you fixed the unitest, now just some lint errors. Were you able to run it locally? Seems to be working fine here.

You were right about the browser assumption. I was using the code below to detect if we are running on a mobile device: return (/Mobi/.test(navigator.userAgent));
I have fixed it and will submit all the changes soon.
Thank you,
Ioan

Hi,
Did anyone got a chance to review the code ?
Thank you,
Ioan

Related solution is https://github.com/mozilla/pdf.js/pull/9255 . We don't want to use navigator.userAgent as a solution. Please derive scaling factor from canvas dpi.

Hi,
I have moved all the scaling code in a separate file and moved the entry point to canvas.js. Please take a look and let me know what you think.
The condition for scaling now is only if a canvas of the image size can't be rendered. This is device agnostic and will scale both image (B&W and RGB) and masks in case they can't be displayed by WebGL.
Thank you,
Ioan

I've took the latest version of the pdfjs and the issue is not fix, neither for images, nor for masks.
Please revisit this, and let me know if you need me to merge the current version in this ticket.
Thank you,
Ioan

I would love for this to get merged, we've been trying to maintain a fork with this implementation trying to keep current.

Are these changes merged in somewhere?  I'd love a fix for this!  I see #10888 but I don't see much progress there.

@kevinswartz  They have not been. I have been just maintaining this PR's implementation on our private repo everytime a new pdfjs version is released. It's still strange to me that they chose #9255 over this PR.

Thanks @kinztechcom.  Bummer it's not merged yet.  I'm unable to display scanned pdfs on ios with the latest.

@yurydelendik  can we re-evaluate the selected patch? The chosen one (#10967 ) does not work but this fix does when we apply it. We are using this for Musopen.org for tens of thousands of PDFs which are not viewable without this patch (#9645 ).  Thanks!

@timvandermeij Can we get another look at this pull request? I know at this point the implementation is most likely outdated and would need to be re-done. I've been manually adding this solution into current releases for almost 2 years. It's pretty annoying to have to consistently do that.
Or perhaps have I missed an accepted pull request and this issue has been correctly resolved elsewhere?


proposal: consolidating quoting on devtools projects

Executive summary
In order to avoid confusions across our projects I would like to propose declaring double quotes as preferred for most file formats, unless that would require extra escaping.
Details
The proposed rule is bit nuanced as avoiding escapes takes precedence. It means that if you have a string with double quotes inside, the prefered way is to enclose it with single quotes. I do think that prettier rationale for string quoting does describe it very well and happens to also match black behavior.
Please note that we do not want to add any linters to our projects that would tell user to fix quotes. If we can have an auto-fixer that can correct them we can enforce them but if we fail to find one, we will likely prefer not to enforce it. The reasoning for this is to minimize annoying contributors.
File formats targeted so far python, javascript, typescript, yaml. We will have to decide for others once we encounter them.
Reasoning

Black defaults to prefer double quotes and we already have multiple projects where we do enforce these, molecule and its plugins, ansible-compat and ansible-navigator.
Prettier seems to also prefer double quotes by default.
Microsoft own guidelines recommend double quotes for contributions to TypeScript itself since 2015. That is also backed by another comment explaining the reasoning:

All those languages either require double quotes for strings (e.g. C#, C++, F#) or at least allow double quotes for strings (e.g. Python, Ruby). It's easier not to ask people to shift their muscle memory when switching back and forth between languages.

Identified impact

We will have to remove prettier custom config that prefers single quotes from vscode-ansible and ansible-language-server projects.  I checked with @tomaciazek and he will lieky support this change as he said that the only reason why he did it was because Microsoft examples were using single quotes and he only wanted consistency inside the code base.
Eventually remove the skip-string-normalization from black config on ansible-lint. I added it while adopting black in order to make transition easier more than an year ago.

I must say that it is weird to see double quotes in anything from the JS land. Historically, the convention was that the double quotes are used in HTML attributes and single quotes are used for scripting, minimizing collision. I don't see a strong case not to follow this guidance. Except when there is a need to avoid escaping.
Besides, MS is known to replace standards for its own convenience so I wouldn't blindly rely on them (/me recalls the existence of JScript and ActiveX).
Black is an even more terrible example. We never accepted it and it's currently legacy that needs to stop harassing people and preventing code readability in its current state.
FWIW single quotes are easier to work with.
P.S. It may be a bad idea in general to try applying standards for one ecosystem to another. The contributors coming from one ecosystem would be rather surprised by some decisions.

To summarize (subjective):
+0: For JavaScript/TypeScript use of either is allowed with no strong recommendation in either direction.
+0: We're doing application-side programming, with no HTML involved so we do not need to worry about collisions.
+1: Most languages that do resemble JavaScript, enforce use of double quotes, so it is easier for most programmers to read such code and rely on already trained muscle memory.

P.S. It may be a bad idea in general to try applying standards for one ecosystem to another. The contributors coming from one ecosystem would be rather surprised by some decisions.

Well, since use of either is allowed and adopted as a standard widely, I don't see a problem.
+1: It is default in Prettier and ESLint. Default means that most projects don't change it, more wide-spread use of double quotes, more programmers used to them.
-1: It will require changing current code to adapt to that standard.
-0.5: Yes, it does require shift to type in a double quote ;)
To me double quotes win by a slight margin.

+0: We're doing application-side programming, with no HTML involved so we do not need to worry about collisions.

I think in the VS Code extension there may be some.

By the way, here's what the most popular style guides in TS/JS use: https://airbnb.io/javascript/#strings--quotes & https://airbnb.io/javascript/react/#quotes.
So I would rather go for using https://npmjs.com/eslint-config-airbnb-base preset.

By the way, here's what the most popular style guides in TS/JS use: https://airbnb.io/javascript/#strings--quotes & https://airbnb.io/javascript/react/#quotes.
So I would rather go for using https://npmjs.com/eslint-config-airbnb-base preset.

Numbers speak for themselves :)
eslint-config-airbnb-base:

eslint-config-prettier:


Updated the version of yup

Updated and tested the latest version of yup.
All the tests pass.

Thanks @applicity


traffic_ctl status is broken

# /opt/ats/bin/traffic_ctl config status
traffic_ctl: [11] Invalid parameters passed into function call.

[jpeach@sk1 trafficserver]$ /opt/ats/bin/traffic_ctl config status
Apache Traffic Server - traffic_server - 7.2.0 - (build # 022120 on Feb 21 2017 at 20:56:37)
Started at Tue Feb 21 21:18:56 2017
Last reconfiguration at Tue Feb 21 21:18:55 2017
Configuration is current

Must have been PBKAC.


Maya: vray multichannel exr image output prefix

Running version
3.14.2
Describe the bug
when using multichannel exr output in vray (6.00.02) wrong image ouptut prefix is applied to deadline job

Expected behavior
with multichannel exr we should not use _<aov> image prefix
there is this check in renderproduct.py, but for whatever reason it is not working
[cuID:2yfmdng]

@m-u-r-p-h-y this is fixed by https://github.com/pypeclub/OpenPype/pull/3954

It's odd that this happens with Multichannel EXR however - which makes me assume there's still another bug present.
I feel both Redshift and V-Ray should not return ` appended from the render product if it's set to render as multilayer / merged AOVs to begin with. I feel like the logic might actually be wrong there.

there is the logic, but I'm not able to tell why it is not working
        if image_format_str == "exr (multichannel)":
            # AOVs are merged in m-channel file, only main layer is rendered
            self.multipart = True
            return products

I feel like the bug is here since it doesn't take into account whether it's multipart/multilayer or not. The same for Redshift actually.

I feel like the bug is here since it doesn't take into account whether it's multipart/multilayer or not. The same for Redshift actually.

That's the problem there, wondering why it emerged suddenly. But it should be easy to fix.

I suspect that with the refactor to new Deadline submitter we've started relying more on the lib_renderproducts implementation as the "ground truth" than before to avoid scattered around duplicated logic but that the lib_renderproducts actually was never implemented correctly for some of the cases like these.


Incorrect error handling when zenoh router node is terminated

Killing the router node (Crtl+C) started by ros2 run rmw_zenoh_cpp init_rmw_zenoh_router will return this error
^CFailed to run zenoh router: zenohd -c ../ws_rmw/install/rmw_zenoh_cpp/share/rmw_zenoh_cpp/config/DEFAULT_RMW_ZENOH_ROUTER_CONFIG.json5

We should try to handle sigint and sigterm cases in this return https://github.com/ros2/rmw_zenoh/blob/beb9fd880227375c1f81b9ca8be06978a826fe04/rmw_zenoh_cpp/apps/init_rmw_zenoh_router.cpp#L36

#99 somewhat addresses this, so closing.


Avoid short-circuiting valid? in Staged models

In the classes where we have overridden valid? to also validate a child object (the HasCreatorSignature mixin and Sponsors model) we were doing:
def valid?
  super && some_other_method_that_calls_valid_on_a_child_object
end

The problem here is that if super returned false we short-circuit the expression and don't run the other method and so don't validate the child object.  Instead we use validate to call the other method as part of the standard validation process.
In practice it wasn't a problem as I neither of the affected classes had any validations on the "parent" so super would never fail.  However it's not a good pattern to leave lying around.

Thanks to @otlaitil for spotting this on #55.

:+1: !

Cool, good to know!

:+1:


Remove redundant files

Remove /site_assets_old, /templates & /templates_old from /public
Templates based in root folder. No need to keep an entire copy of the site assets.

Merged as the dev branch


autocomplete setup m build

New PR without the previous unintentionall changes to AOK_VARS :)
Purpose is to run /AOK/aok_setup_fs automatically on first boot of FS built with -m param

Thank you!


redirect to home after login react - redux

I'm new working with react v4 and I try to redirect to another page, something like a home page after the user authenticate in but I'm getting problems with nested routes, I've tried this solution and this other one in documentation but doesn't work the way that I need.
I have a basic code for the login in this github repository
Thanks in advance for your help.

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!


Solved Issue #150

Added popup method for google calendar api before 30 minutes of the start of the competition

Have you tried this ? Because I am not getting any desktop notifications after adding this. Please send a screenshot.

Hey! @raj454raj sorry about all the commits mess, I'm kinda learning git and github :sweat_smile:, Please close this PR and I'll send a new one with the bug solved. Also please elaborate on how should I check whether the changes I have made are valid because the reminder is only visible before the competition right?

I'm kinda learning git and github

That's okay.

Please close this PR and I'll send a new one with the bug solved.

I didn't have any problem with this PR, but after your recent commits, the final PR aims only at solving Issue 147 and not 150 - So I will be closing this PR. Please send a seperate PR for 147 first and then 150.

Also please elaborate on how should I check whether the changes I have made are valid because the
reminder is only visible before the competition right?

Change the remind time to something else instead of 30 minutes ;) ! Also please investigate where is this popup supposed to pop up - We can add it if it is something useful. But for desktop notifications please search a bit on Google. I got these - 1 and 2.

For chrome notifications, don't we need to store the user's reminders in the database and then 30 mins before the competition starts show the desktop notification using JS?
If we are using popups by google calendar api, the reminder will automatically show as a popup in google calendar before the competition

For chrome notifications, don't we need to store the user's reminders in the database and then 30 mins > before the competition starts show the desktop notification using JS?

I am not sure about that. You will have read up about it.

If we are using popups by google calendar api, the reminder will automatically show as a popup in
google calendar before the competition

If it indeed creates a desktop notification I would be fine with that too. It didn't work for me on localhost. If it works for you, please send a screenshot.
PS: I am not exactly sure where is the popup generated.


[Feature Request] Select dropdown (popover) customization

Existing Component
Yes
Component Name
Select
Description
Have any possibilities for customizing popover for select. Like an increase min-width

If you're trying to customize its style, please write your own CSS to override it.

@Leopoldthecoder just have the problem with the scroll in dropdown. We can't manipulate with it. When we customize height we have some problem.


Support ColDP archive output format

The Catalogue of Life has developed a new data format, the Catalogue of Life Data Package (ColDP) which is an evolution from Darwin Core Archives, also using primarily CSV or TSV data files, but is more relational and avoids the star schema traps especially for literature references.
ColDP is the recommended format for publishing taxonomic and nomenclatural data and is expected to replace DwC-A in many cases. Currently ColDP archives are mostly generated by custom scripts. It would be great to be able to use the IPT in the taxonomic community.

@mdoering
To help in our planning, is this a speculative request or do COL have IPT users that need this now please?

COL has a bottleneck by manually packing up ColDP with custom scripts for most sources. @gdower is doing most of this work, maybe he wants to comment. Many things can be accomplished with DwC-A already, but ColDP offers more and e.g. ZooBank would be easily available as ColDP if its IPT could (auto) publish it. It is not blocking COL, but it would definitely accelerate it considerably. ColDP version1 is now also close to be released as a stable version to work against (it has seen only minor changes since last autumn)

For authoritative checklist like VASCAN would a ColDP output format in addition to the DwC-A output format help CoL in harvesting such sources?

All the core information can be passed via DwC-A, so it is not essential to use ColDP.
Here is a comparison: https://github.com/CatalogueOfLife/coldp#format-comparison
ColDP especially improves handling of bibliographic references (they are normalised and structured). In addition it allows to share extras like species estimates, name relations, species interactions and provides a more citation oriented and COL targeted metadata model.
The blocker for using VASCAN or any other regional list right now is that the COL assembly code requires global coverage of taxonomic groups. This will be the focus of our next milestone after summer.


Upgrade to support .NET 4.5 and .NET Core

Bumps framework version to 4.5.
Upgrades to use newer, more compatible, reflection APIs.
Bump to version 0.3.0.
Added new resource generation tool that is compatible with .NET Core.
This automatically generates Resources.Designer.cs.
To use it, right-click on Properties/Resources.tt  -> "Run Custom Tool"

Closing as upgrades to dotnet make these changes obsolete.


Supplies Model

Supply model needs to be made.

disregard my pull request, need to make a few more changes first

This issue can be closed

Nicely done.


Fix null pointer dereference in cms_RecipientInfo_kari_init

It is possible for cms_RecipientInfo_kari_init to dereference a null pointer.
The call to M_ASN1_new_of can return a null pointer at https://github.com/openssl/openssl/blob/5dc40a83c74be579575a512b30d9c1e0364e6a7b/crypto/cms/cms_kari.c#L301
Then rek is dereferenced without a null check at https://github.com/openssl/openssl/blob/5dc40a83c74be579575a512b30d9c1e0364e6a7b/crypto/cms/cms_kari.c#L308
The intervening call to sk_CMS_RecipientEncryptedKey_push does not ensure that rek is not null.

Added CLA: trivial and changed to rek == NULL instead of !rek
Thanks for the review!

I wonder if the coment above "Initialise a ktri based on passed certificate and key"
is a typo, and should say instead "Initialise a kari ..." ?

...is a typo, and should say instead "Initialise a kari ..." ?

I believe so.

@defreez feel free to correct the typo.

Ping @openssl/omc , this PR still needs an approval from OMC

I assume label 3.0.0 and master are actually the same thing, right?

Yes - 3.0.0 and master are the same thing (until such time as 3.0.0 is released).

Understood


Add additional error handling to unary RPCs

Maybe the commit message should also note the switch away from the root logger?

Maybe the commit message should also note the switch away from the root logger?

Eh, too minor to call out.


Added DisablePanGesture

Swipe Gesture BUG #48
Needed a solution to the issue by having this PanGesture.
Simple boolean to allow the application to determine when the gesture
is to be disabled (i.e. in the case that you want to use other
PanGestures as in a UITableViewController)

This could also be helpful for #21

This has been on my list of things to do. Thanks for the PR!


[shaderwriter] Update to version 2.3.0.

Describe the pull request

What does your PR fix?
Fixes #25131

Which triplets are supported/not supported? Have you updated the CI baseline?
All.
No.

Does your PR follow the maintainer guide?
Hopefully yes.

Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

I found two thing in the genreated file list:
1.
shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig-debug.cmake
shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig-release.cmake
shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig.cmake

These cmake files should be installed into share/SdwCompilers.

shaderwriter:x64-windows:/bin/sdwCompilerGlsl.dll
shaderwriter:x64-windows:/bin/sdwCompilerHlsl.dll
shaderwriter:x64-windows:/bin/sdwCompilerSpirV.dll
shaderwriter:x64-windows:/bin/sdwShaderAST.dll
shaderwriter:x64-windows:/bin/sdwShaderWriter.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerGlsld.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerHlsld.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerSpirVd.dll
shaderwriter:x64-windows:/debug/bin/sdwShaderASTd.dll
shaderwriter:x64-windows:/debug/bin/sdwShaderWriterd.dll

There is no pdbs, please add vcpkg_copy_pdbs() after vcpkg_cmake_configure.

Thanks for the update!


encoding.json Marshallers for some of the well known types

Right now, the only way to support transformation of the well known types between proto and json is jsonpb and unfortunately, some well known types such as Struct and Values are not yet supported for transforming from json to proto. (Also, while I haven't investigated this, others have reported here that jsonpb is ~6x slower.)
It will be useful to have some marshallers and unmarshalers for some of the simpler, more commonly used well known types so that one can use these with encoding.json.
If the proposal sounds good, I can create changelists for a few of these well known types.

Arguably all generated message types ought to implement json.Marshaler and json.Unmarshaler (calling jsonpb under the hood).  But that's a separate issue; I don't think adding a special-case for WKTs is appropriate.

Support for WKT have been implemented in 18c9bb3261723cd5401db4d0c9fbc5c3b6c70fe8

Sorry, I missed out the subtle wording here for referring to encoding/json.Marshaler.  I closed this bug as 18c9bb3261723cd5401db4d0c9fbc5c3b6c70fe8 added support for WKT in jsonpb.
bcmills@ did file related issue #256 for supporting the general case of using encoding/json.


Possible Data Issues

The following items in this list appear to have values that do not match their components. The source data from 10646hk.net JPTableFull.pdf also includes these values, but as a non-native speaker I am unable to ascertain their correctness.
䇉	U+41C9	baak3 sing1
粌	U+7C8C	baak3 mai5
籿	U+7C7F	fan1 mai5

Expanding on this, some of these may be bad handwriting that was propagated or bad transcriptions.
It is easy to imagine how 竡	U+7AE1	baak3 sing1 and 䇉	U+41C9	baak3 sing1 could have been mistakenly read, written, transcribed, or entered. Looking at the characters in this multi-syllable set:
籿	U+7C7F	fan1 mai5
粀	U+7C80	sap6 mai5
粁	U+7C81	cin1 mai5
粌	U+7C8C	baak3 mai5
粍	U+7C8D	hou4 mai5
粨	U+7CA8	baak3 mai5
糎	U+7CCE	lei4 mai5

䇆	U+41C6	sap6 sing1
䇉	U+41C9	baak3 sing1
竍	U+7ACD	sap6 sing1
竏	U+7ACF	cin1 sing1
竓	U+7AD3	hou4 sing1
竕	U+7AD5	fan1 sing1
竡	U+7AE1	baak3 sing1
竰	U+7AF0	lei4 sing1
𥪕	U+ED41	cin1 sing1

兙	U+5159	sap6 hak1
兛	U+515B	cin1 hak1
兝	U+515D	fan1 hak1
兞	U+515E	hou4 hak1
兡	U+5161	baak3 hak1
兣	U+5163	lei4 hak1

瓧	U+74E7	sap6 ngaa5
瓩	U+74E9	cin1 ngaa5
瓰	U+74F0	fan1 ngaa5
瓱	U+74F1	hou4 ngaa5
瓸	U+74F8	baak3 ngaa5
甅	U+7505	lei4 ngaa5

These are the odd ones that I feel like should get further scrutiny to identify their source:
粌	U+7C8C	baak3 mai5
䇆	U+41C6	sap6 sing1
䇉	U+41C9	baak3 sing1
𥪕	U+ED41	cin1 sing1

Expanding on this, some of these may be bad handwriting that was propagated or bad transcriptions.
It is easy to imagine how 竡	U+7AE1	baak3 sing1 and 䇉	U+41C9	baak3 sing1 could have been mistakenly read, written, transcribed, or entered. Looking at the characters in this multi-syllable set:
籿	U+7C7F	fan1 mai5
粀	U+7C80	sap6 mai5
粁	U+7C81	cin1 mai5
粌	U+7C8C	baak3 mai5
粍	U+7C8D	hou4 mai5
粨	U+7CA8	baak3 mai5
糎	U+7CCE	lei4 mai5

䇆	U+41C6	sap6 sing1
䇉	U+41C9	baak3 sing1
竍	U+7ACD	sap6 sing1
竏	U+7ACF	cin1 sing1
竓	U+7AD3	hou4 sing1
竕	U+7AD5	fan1 sing1
竡	U+7AE1	baak3 sing1
竰	U+7AF0	lei4 sing1
𥪕	U+ED41	cin1 sing1

兙	U+5159	sap6 hak1
兛	U+515B	cin1 hak1
兝	U+515D	fan1 hak1
兞	U+515E	hou4 hak1
兡	U+5161	baak3 hak1
兣	U+5163	lei4 hak1

瓧	U+74E7	sap6 ngaa5
瓩	U+74E9	cin1 ngaa5
瓰	U+74F0	fan1 ngaa5
瓱	U+74F1	hou4 ngaa5
瓸	U+74F8	baak3 ngaa5
甅	U+7505	lei4 ngaa5

These are the odd ones that I feel like should get further scrutiny to identify their source:
粌	U+7C8C	baak3 mai5
䇆	U+41C6	sap6 sing1
䇉	U+41C9	baak3 sing1
𥪕	U+ED41	cin1 sing1

籿	U+7C7F	fan1 mai5
粌	U+7C8C	baak3 mai5
䇆	U+41C6	sap6 sing1
䇉	U+41C9	baak3 sing1
𥪕	U+ED41	cin1 sing1

In fact I asked the exactly same question when I first worked on this list. These characters are quite counter-intuitive even to native users of 漢字.
The right components of these five characters come from 公寸、公引、公斗、公石、公秉 respectively. For instance 分米 (fan1 mai5, decimeter) is the "new standard for the unit 寸", and the 米 radical is used to indicate that it is a length measurement.
See this wikipedia page for more information: https://zh.wikipedia.org/wiki/計量用漢字

Thank you for the additional information! I realized at some point that these looked like complete "sets," excepting those cases I set aside in my last comment (which I now have additional color for).
Now I'm off to very slowly read a Wikipedia page...

Aside: words.hk is absolutely invaluable. 我是中文大學雅禮中國語文研習所的學生。每天都會用words.hk。如果你們需要識做IT人，話畀我知！And yes, I'm aware that I've mixed formal and informal writing in that (and probably have grammar errors), but I'll get better, promise.


Override HashMap.default in Seq.occCounts instead of using Map.withDefaultValue

Reverting a small change I made here. It was not needed for the purpose of that PR (turns out the anonymous class is only used internally) and can slightly increase the running time of diff and intersect. This is likely caused by the fact that Map.withDefaultValue wraps the default value in a function causing an additional dispatch every time a key is missing.

Your benchmark seems to show that performance was slightly better before the PR, no?

sorry @julienrf ,
Red line is before #444
Blue line is after #444 (which is what this PR aims to revert)

Ah, thanks for the clarification!


implement ACL policy grants

thank you for your contribution.. the team will look into it asap.. ;) looks very good on first sight 👍

A few missing things:

Document the new variable grants
Add the new variable to the unit tests
Make sure README.md is generated from README.tfdoc.hcl using terradoc.

the only errors in https://github.com/mineiros-io/terraform-aws-s3-bucket/actions/runs/3198717372/jobs/5336038710 seem to be around "dead" links, which aren't actually dead


Update Compose dependencies using BOM for versioning all libs

Why
After Google released BOM for the compose libraries, it helps us to manage the latest versions of libraries we are using. Therefore, we don't need to handle it independently. However, if we want to fix version to some libraries, we can do it by overriding the library version.

Who Benefits?
Android devs

@lydiasama Applying BOM for dependencies versioning management, we must be aware of new versions released from Google 🤔 It might cause unexpected issues, and we are always forced to update to adapt with new releases 🐛 How do you think we could keep the specific version for some core of libraries instead of all libraries? 😄

@hoangnguyen92dn To use BOM != @latest. You can see here, each BOM version specifies the libraries version. So there is no concern about keeping up to date with every lib. Furthermore, if there are some libraries you don't want to use the same version as BOM suggests, you can override it as I explain in the PR description.

@lydiasama I see the idea, but once you update the BOM version, all the dependencies in the library group will be updated as well and we have to verify to make sure functionalities work fine after upgrading.
Seems we could rely on this explanation from Google, we could give it a try

The BOM itself has links to the stable versions of the different Compose libraries, in such a way that they work well together.

https://developer.android.com/jetpack/compose/setup#using-the-bom

@hoangnguyen92dn From my experience, when we update the libraries, we usually update all relevant libraries together, no? 🤔  I know your concern but I think BOM is practical and can be used. What do you think?

@hoangnguyen92dn Again, when updating a library, if you don't want them to be affected all, you can override it one by one first and then use the next version of BOM later. it's cleaner than handling one-by-one version and creating a lot of version variables, IMHO.

@lydiasama

when we update the libraries, we usually update all relevant libraries together, no?

Not usually until we have the build issue 😄
We could give it and see if there is any issue with dependencies version, we would keep the working version.

@hoangnguyen92dn So it's quite not often to update the library version, am I right? I think we can just use BOM first and override only the build issue. Does it make sense for you?

@lydiasama Yeah. As I said, we could give it a try. No more concern from me 😄

@lydiasama @Tuubz This issue is not clear enough for voting IMO. Can we have an RFC with an example in detail to see the benefits & code changes? or maybe make a draft/POC PR first? ✊

Purpose: Synchronize compose dependencies automatically
Benefits: Convenience and shorter code
Code changes:

dependencies {
    implementation platform('androidx.compose:compose-bom:2022.12.00') // Set BOM version: https://developer.android.com/jetpack/compose/setup#bom-version-mapping
    implementation 'androidx.compose.foundation:foundation' // No need to specify version ourselves, in this case it will use 1.3.1
    implementation 'androidx.compose.material3:material3:1.1.0-alpha01' // Override version, if necessary
}

@luongvo Please let me know if you think a POC is still necessary 🙏

Note: The current compose version is 1.2.1

That looks good, we should upgrade the Compose core version in this ticket too 👍

@hoangnguyen92dn @luongvo Could I get your vote on this one? 😁

@Tuubz Voted

@Tuubz Done ✅


Fix for key-vault secret naming limitation

Fix for key-vault secret, naming limitation

Can be closed as resolved part of
PR : https://github.com/Microsoft/containers-rest-cosmos-appservice-java/pull/92


Unit tests fail with raven/raven 0.13.0

$ ./vendor/bin/phpunit tests/Monolog/Handler/RavenHandlerTest.php
PHPUnit 4.6.6 by Sebastian Bergmann and contributors.

Configuration read from /Users/bd808/projects/3rd-party/monolog/phpunit.xml.dist

.....F....

Time: 169 ms, Memory: 5.25Mb

There was 1 failure:

1) Monolog\Handler\RavenHandlerTest::testUserContext
null does not match expected type "array".

/Users/bd808/projects/3rd-party/monolog/tests/Monolog/Handler/RavenHandlerTest.php:120

FAILURES!
Tests: 10, Assertions: 14, Failures: 1.

$ composer show --installed
aws/aws-sdk-php                   2.8.5              AWS SDK for PHP - Use ...
doctrine/annotations              v1.2.4             Docblock Annotations P...
doctrine/cache                    v1.4.1             Caching library offeri...
doctrine/collections              v1.3.0             Collections Abstractio...
doctrine/common                   v2.5.0             Common Library for Doc...
doctrine/couchdb                  dev-master 9f92d8e CouchDB Client
doctrine/inflector                v1.0.1             Common String Manipula...
doctrine/instantiator             1.0.4              A small, lightweight u...
doctrine/lexer                    v1.0.1             Base library for a lex...
graylog2/gelf-php                 1.2.3              A php implementation t...
guzzle/guzzle                     v3.9.3             PHP HTTP client. This ...
jakub-onderka/php-parallel-lint   v0.9               This tool check syntax...
php-console/php-console           3.1.3              Server side PHP librar...
phpdocumentor/reflection-docblock 2.0.4
phpspec/prophecy                  v1.4.1             Highly opinionated moc...
phpunit/php-code-coverage         2.0.16             Library that provides ...
phpunit/php-file-iterator         1.4.0              FilterIterator impleme...
phpunit/php-text-template         1.2.0              Simple template engine.
phpunit/php-timer                 1.0.5              Utility class for timing
phpunit/php-token-stream          1.4.1              Wrapper around PHP's t...
phpunit/phpunit                   4.6.6              The PHP Unit Testing f...
phpunit/phpunit-mock-objects      2.3.0              Mock Object library fo...
psr/log                           1.0.0              Common interface for l...
raven/raven                       0.13.0             A PHP client for Sentr...
ruflin/elastica                   v<IP_ADDRESS>         Elasticsearch Client
sebastian/comparator              1.1.1              Provides the functiona...
sebastian/diff                    1.3.0              Diff implementation
sebastian/environment             1.2.2              Provides functionality...
sebastian/exporter                1.2.0              Provides the functiona...
sebastian/global-state            1.0.0              Snapshotting of global...
sebastian/recursion-context       1.0.0              Provides functionality...
sebastian/version                 1.0.5              Library that helps wit...
swiftmailer/swiftmailer           v5.4.0             Swiftmailer, free feat...
symfony/event-dispatcher          v2.6.7             Symfony EventDispatche...
symfony/yaml                      v2.6.7             Symfony Yaml Component
videlalvaro/php-amqplib           v2.5.0             This library is a pure...

$ composer update raven/raven --prefer-lowest
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing raven/raven (0.13.0)
  - Installing raven/raven (0.11.0)
    Loading from cache

Writing lock file
Generating autoload files

$ ./vendor/bin/phpunit tests/Monolog/Handler/RavenHandlerTest.php
PHPUnit 4.6.6 by Sebastian Bergmann and contributors.

Configuration read from /Users/bd808/projects/3rd-party/monolog/phpunit.xml.dist

..........

Time: 93 ms, Memory: 5.00Mb

OK (10 tests, 18 assertions)

Looks to have been caused by changes introduced in https://github.com/getsentry/raven-php/commit/ab6fb93e34a9de8c53caf9efde4f357c98b1e3d2

Fixed by 5405308eb1c7dc1fdc0bd408f80eca2ee8ed9a92 - sorry I just forgot to push it :)


What is our reconnect mechanism like?

Hi, I have some questions. I initialized a global connection using the once_cell crate, and I used it in two ways.
My test order is as follows:

Start the Redis service.
Run the test.
View the console log.
Stop the Redis service.
View the console log.
Start Redis.
View the console log.

One way is like this (reconnect success):
#[cfg(test)]
mod test {
    use once_cell::sync::OnceCell;
    use redis_async::client::PairedConnection;
    use redis_async::error::Error;
    use redis_async::resp_array;
    use std::thread;
    use std::time::Duration;
    use tokio::join;

    static GLOBAL_CONNECTION: OnceCell<PairedConnection> = OnceCell::new();

    #[tokio::test]
    async fn test_redis() {
        let connection = redis_async::client::paired_connect("<IP_ADDRESS>", 6379)
            .await
            .unwrap();
        GLOBAL_CONNECTION.set(connection).unwrap();

        loop {
            thread::sleep(Duration::from_secs(1));
            let handle = tokio::spawn(async {
                let res: Result<String, Error> = GLOBAL_CONNECTION
                    .get()
                    .unwrap()
                    .send(resp_array!["SET", "test", "1"])
                    .await;
                if let Ok(_) = res {
                    println!("ok");
                } else {
                    println!("error");
                }
            });
            let _ = join!(handle);
        }
    }
}

One way is like this (reconnect fail):

#[cfg(test)]
mod test {
    use std::thread;
    use std::time::Duration;

    use once_cell::sync::OnceCell;
    use redis_async::client::PairedConnection;
    use redis_async::error::Error;
    use redis_async::resp_array;

    static GLOBAL_CONNECTION: OnceCell<PairedConnection> = OnceCell::new();

    #[tokio::test]
    async fn test_redis() {
        let connection = redis_async::client::paired_connect("<IP_ADDRESS>", 6379)
            .await
            .unwrap();
        GLOBAL_CONNECTION.set(connection).unwrap();

        loop {
            thread::sleep(Duration::from_secs(1));
            let res: Result<String, Error> = GLOBAL_CONNECTION
                .get()
                .unwrap()
                .send(resp_array!["SET", "test", "1"])
                .await;
            if let Ok(_) = res {
                println!("ok");
            } else {
                println!("error");
            }
        }
    }
}

I roughly understand that it's probably caused by multithreading. I'm new to Rust and I'm not sure if it's due to once_cell or redis_async. Can you provide some guidance? I'd also like to make some small contributions to redis_async.

Sorry, i accidentally submitted it twice.


[Bug] Multiple Method instances in Graph

Multiple Method instances in Graph
When working with v8, multiple methods are generated for each function. In the below example, it is 3. The filename=<name>.h and filename=<name>.cc instances are expected, but I am not sure where the last instance comes from. This causes issues for workflows such as traversing callers.
Assuming methods A -> B -> C, using C.caller gives me B-1, but then using B-1.caller does not give me A, because only B-2.caller is linked to A.
To Reproduce
git clone https://github.com/v8/v8
joern-parse ./v8/src --output v8_db
joern v8_db

cpg.method.name("MarkLiveObjects").caller.caller.l

Expected behavior
The method should return the .caller.caller of the "MarkLiveObjects" method, instead it returns nothing. Doing cpg.method.name("MarkLiveObjects").caller.l to find the caller name and then using that to once again do cpg.method.name(<name>).caller.l showcases that the .caller.caller method does however exist.
Screenshots
joern> cpg.method.name("MarkLiveObjects").l
res7: List[Method] = List(
  Method(
    id = 271660L,
    astParentFullName = "v8.internal.MarkCompactCollector",
    astParentType = "TYPE_DECL",
    code = "void MarkLiveObjects ()",
    columnNumber = Some(value = 8),
    columnNumberEnd = Some(value = 24),
    filename = "src/heap/mark-compact.h",
    fullName = "v8.internal.MarkCompactCollector.MarkLiveObjects",
    hash = None,
    isExternal = false,
    lineNumber = Some(value = 580),
    lineNumberEnd = Some(value = 580),
    name = "MarkLiveObjects",
    order = 90,
    signature = "void v8.internal.MarkCompactCollector.MarkLiveObjects ()"
  ),
  Method(
    id = 2149603L,
    astParentFullName = "src/heap/mark-compact.cc:<global>",
    astParentType = "TYPE_DECL",
    code = "void MarkLiveObjects ()",
    columnNumber = Some(value = 1),
    columnNumberEnd = Some(value = 1),
    filename = "src/heap/mark-compact.cc",
    fullName = "v8.internal.MarkCompactCollector.MarkLiveObjects",
    hash = None,
    isExternal = false,
    lineNumber = Some(value = 2042),
    lineNumberEnd = Some(value = 2130),
    name = "MarkLiveObjects",
    order = 75,
    signature = "void v8.internal.MarkCompactCollector.MarkLiveObjects ()"
  ),
  Method(
    id = 3835758L,
    astParentFullName = "<global>",
    astParentType = "NAMESPACE_BLOCK",
    code = "<empty>",
    columnNumber = None,
    columnNumberEnd = None,
    filename = "<empty>",
    fullName = "MarkLiveObjects",
    hash = None,
    isExternal = true,
    lineNumber = None,
    lineNumberEnd = None,
    name = "MarkLiveObjects",
    order = 0,
    signature = ""
  )
)

Desktop (please complete the following information):

Ubuntu
Joern Version: 1.1.1603
Java version: openjdk 19.0.2 2023-01-17

The last one is generated as a stub for a call to MarkLiveObjects where c2cpg was unable to determine the actual corresponding method fullname. This happens quite a lot here and is currently a known drawback when analyzing C/C++ code.
Maybe someone knows a good workaround for queries like yours.

Yeah, fair enough. It seems like a potentially hard problem. I ended up getting a decent workaround with a recursive solution, so it wasn't a huge issue. Just figured it might be good to create an issue just in case.


fix: set cri-o version to 1.21

Which issue(s) this PR addresses: https://github.com/redhat-et/microshift/issues/466

Yes but microshift is so far based on okd, which is based on openshift 4.8
, so cri-o 1.21
El El dom, 28 nov 2021 a las 12:47, Miguel Andrade @.***>
escribió:

@.**** commented on this pull request.
In install.sh
https://github.com/redhat-et/microshift/pull/467#discussion_r757884531:

@@ -143,23 +143,23 @@ establish_firewall () {

Install CRI-O depending on the distro
install_crio() {

CRIOVERSION=1.22

Openshift 4.9 uses crio 1.22 ... suggest we keep up ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-et/microshift/pull/467#discussion_r757884531,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI7G4VWUSIOGBJGUXZCIJTUOIJDXANCNFSM5ILX22CQ
.

--
irc: ajo / mangelajo
Miguel Angel Ajo Pelayo
+34 636 52 25 69
skype: ajoajoajo

Going to kick off testing based on the change to 1.21

/ok-to-test

/LGTM

Merging based on directions in getting started https://microshift.io/docs/getting-started/


Price and the volume overlap

I'm looking the way to solve this:

If you see in the begin of the chart in the left price and volumen overlap. The best solution for us is essentially that price and volumen be in different chart but sharing same x axis.
Something like this:

(Source: MarketSmith)
Anybody know how to do it?
PD: Zoom is important for us too. I say this because if I draw it in different charts and after we want to move across the chart, volume and price will not move together.

Any solution?


Comprehensive updates to the multisurface/macro config approach.

This PR adds widespread updates to the multisurface/macro config approach. Modifications mainly affect the modules multisurface_oe.py and template_construction.py, as well as the config file multisurface_oe_template.json.
However, I also slightly modified both the empirical and the analytical line functions in order to make them running for the multisurface approach. These changes shouldn't have any impacts on running apply_oe.py, and testing with EMIT and AVNG data ran without errors so far, but I'll nonetheless mark this PR as draft until we're absolutely sure about merging it in.
Furthermore, the separation of surface indices is likewise already included, so we should at least wait with merging until PR #319 is merged.

As discussed today, I think we're almost there with this!  To-Do's from today's isofit tagup:

add a apply_oe deprecation notice warning at the top of apply_oe, note that we won't purge until after 3.2
update the cube example to use multisurface_oe.py

For the future (not for this PR):

consider removing the isofit_dir argument to both empirical_line and analytical_line, and make the new config_file optional argument required.
update hardcoded sub-directory paths in analytical_line to reference the template utility

@pgbrodrick Commits 7eb7364 and aaad888 add both the deprecation warning to apply_oe.py and the updated cube example that is now run with the multi surface approach.

In agreement with @pgbrodrick, this PR has successfully been reviewed. So, I'll go ahead and merge!


Unable to mange tableview section height

I want to reduce table view header height

Looks like this feature has not gained enough requests to be added to the library. The default works for most people, I guess. If you still want this, please fork the library and make adjustments which I think shouldn't be more than two lines of code or so. Will be closing this for now.


Update Avatar and Avatar Group RTL checks

Platforms Impacted

[X] iOS
[ ] macOS

Description of changes
I was having trouble figuring out why RTL wasn't working for me when it was working for others. Turns out, they were using Arabic as their language, while I was using the Right-to-Left pseudolanguage. Upon further investigation, I found that the check we were using for if the view was RTL was only checking the direction of the characters, so it didn't work for the RTL pseudolanguage.
There's still an issue with the padding on the Avatar Group being flipped for border vs. no border, but I'll address that in a separate PR.
Verification

Before
After

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[x] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

@mischreiber
Github doesn't seem to want to let me quote reply, but we should handle the IndeterminateProgressBar in a different PR. I tried to convert it for a little while, but the usage of isRightToLeftLayoutDirection() being in the private Constants struct complicated things.

@mischreiber Github doesn't seem to want to let me quote reply, but we should handle the IndeterminateProgressBar in a different PR. I tried to convert it for a little while, but the usage of isRightToLeftLayoutDirection() being in the private Constants struct complicated things.

I think you can create a struct inside the constants struct that takes a boolean param for "isRTL" and return the coordinate points based on that flag.
    private struct Constants {
        static let animationDuration: Double = 1.75

        struct Coordinates {
            var isRTLLanguage: Bool
            var initialStartPoint: UnitPoint { isRTLLanguage ? UnitPoint(x: 1, y: 0.5) : UnitPoint(x: -1, y: 0.5) }
            var initialEndPoint: UnitPoint { isRTLLanguage ? UnitPoint(x: 2, y: 0.5) : UnitPoint(x: 0, y: 0.5) }
            var finalStartPoint: UnitPoint { isRTLLanguage ? UnitPoint(x: -1, y: 0.5) : UnitPoint(x: 1, y: 0.5) }
            var finalEndPoint: UnitPoint { isRTLLanguage ? UnitPoint(x: 0, y: 0.5) : UnitPoint(x: 2, y: 0.5) }

            init(_ isRTLLanguage: Bool = false) {
                self.isRTLLanguage = isRTLLanguage
            }
        }
    }

Then just replace that throughout the SwiftUI implementation.
    @State var startPoint: UnitPoint = .zero
    @State var endPoint: UnitPoint = .zero
    var isRTLLanguage: Bool {
        return layoutDirection == .rightToLeft
    }

    /// Creates the Indeterminate Progress Bar.
    public init() {
        let state = MSFIndeterminateProgressBarStateImpl()
        self.state = state
        self.tokens = state.tokens
        startPoint = Constants.Coordinates(isRTLLanguage).initialStartPoint
        endPoint = Constants.Coordinates(isRTLLanguage).initialEndPoint
    }

...

    private func startAnimation() {
        stopAnimation()

        withAnimation(Animation.linear(duration: Constants.animationDuration)
                                .repeatForever(autoreverses: false)) {
            startPoint = Constants.Coordinates(isRTLLanguage).finalStartPoint
            endPoint = Constants.Coordinates(isRTLLanguage).finalEndPoint
        }
    }

    private func stopAnimation() {
        withAnimation(Animation.linear(duration: 0)) {
            startPoint = Constants.Coordinates(isRTLLanguage).initialStartPoint
            endPoint = Constants.Coordinates(isRTLLanguage).initialEndPoint
        }
    }


fix: Added near-api-js as peer dependency to NearFi wallet

Description
Added near-api-js as peer dependency to NearFi wallet.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Type of change.

[x] FIX - a PR of this type patches a bug.
[ ] FEATURE - a PR of this type introduces a new feature.
[ ] BUILD - a PR of this type introduces build changes.
[ ] CI - a PR of this type introduces CI changes.
[ ] DOCS - a PR of this type introduces DOCS improvement.
[ ] STYLE - a PR of this type introduces style changes.
[ ] REFACTOR - a PR of this type introduces refactoring.
[ ] PERFORMANCE - a PR of this type introduces performance changes.
[ ] TEST - a PR of this type adds more tests.
[ ] CHORE - a PR introduces other changes than the specified above.

Hey, this looks nice 👍
Can you also add an explanation in the readme file here:
https://github.com/near/wallet-selector/tree/dev/packages/nearfi#installation-and-usage
It can be the same way it is for other wallets for example my-near-wallet:
https://github.com/near/wallet-selector/tree/dev/packages/my-near-wallet#installation-and-usage


Auto restart setting. [ENHANCEMENT]

Hello!
So the auto restart feature would be awesome if it were to be made!
Its because now and then my servers get too big.
Thank you!

I think I have a better idea to prevent players getting big. Calculate mass that the map can fit, then divide the server total mass by the map mass to get a fraction of map fill. Then, substract that fraction from 1 and divide the decay by it. I'll make a PR if @Megabyte918 decides that this is a good solution.

Auto restart? You mean like restarting the process? or just killing all the players. I made an auto restart that closes the process, and pm2 auto opens it.

lol razor

Death on Cell size limit will be more honestly.

How about something like this:
@echo off cls :start node ../src/index.js @echo. @echo Restarting server... @echo. goto start

When the server crashes it restarts it

So, All we need is a function to crash the server

Or stop the process

Just crashing the server doesn't necessarily mean that the node process will exit. The intended way to do this is:
process.exit(1);

add this to the index.js
setTimeout(function(){process.exit(1);}, 10*60*1000

Ok

That will restart the server in 10 minutes, but what if you want to restart it in a different amount of time? Use gameserver.js and read the restart time value from config.

I did on my fork

Now I test

another way is https://github.com/remy/nodemon#delaying-restarting

@G047 setTimeout(function(){process.exit(1);}, 10601000
That line, that doesnt restart the server.....

What i would like is a setting in the server files.
Which Restarts the server. Then ill add a countdown timer to my client so people can see it restarts.

I made a pull request

based on config

Thanks Tyler
PS isnt a pull request a thing where u merge or just add a feature?
i dont know lol

Well, you make a fork and a pull request is to request the owner to accept your commits on your fork

https://help.github.com/articles/about-pull-requests/

ok ok ok ok, and does your commit thingy have a autorestart thing?? xD

Yup

If you want it, download this

https://github.com/Tyler3D/MultiOgar-Edited

PLS ! Love u if u do, no homo.

XD

https://github.com/Tyler3D/MultiOgar-Edited

Lol i hopes he accepts, it would be a useful feature!

 This shoudn't be done. The root of server problem have to be found.

@Gimmo right

I added a playerMaxScore config so that you can have control over how big your server gets, I don't an auto-restart system needs to be implemented since there are node modules such as pm2 that can do it for you.


Update license copyright

Coverage remained the same at 95.76% when pulling a08027c83e6f7bc84ff12e0bacf8489d5d75ce35 on license-bot into 3f033cd571b0811a4aa50f5d81bb8c3800fad9fb on master.


Feature: HL1 Camera Rigs

Description
My team has started MR development with the HoloLens 1, now these devices are mostly lying around unused as the HL2 with its superior interactivity has taken over. For this reason I scribbled a version of a HL1 support for camera rigs in #203 (now a different account for internal compliance). I have cleaned and retested this approach and also got a correct spatial alignment working.
Unfortunately I could not compare the precision against a HoloLens 2, as I can't secure it properly to the camera at the moment (3D prints and matching screws are hard to come by rn).
Summary of changes

An ArUcoMarkerDetector was added to the HeadsetCalibration object and a condition whether to use QRCode or ArUco
ArUcoMarkerDetector returns the static marker size in the TryGetMarkerSize which is contradictory to the docs ("was determined through detection"), but this function is afaik only used for calibration where it worked fine
 ArUcoThreeMarkerSpatialLocalizer was enabled for the WSA platform.

Calibration and Localization
The calibration was very finicky to get even somewhat working with the stationary marker detection strategy. Using the moving strategy and taking more pictures instead got plausible results for me (~30 usable datasets). For the test I moved the camera in a rough half circle around the calibration board. This I created by just stitching together all 18 ArUco codes from the original calibration board.
As far as I understood this method of calibration works because for the pose estimation the actual QR code positions are ignored and only the presumed ArUco code positions which are transferred by the HL2 in an original scenario are regarded in the calculation.
For the localization I found that the ArUco marker detection alone gives very unpredictable and inaccurate results. Using the three ArUco method instead to ignore the detected orientation and only rely on the detected positions gave a convincing result in the calibration test (the cube being half inside the marker is correct behaviour). For the situation in the picture below I had to put the rig very near to the marker board, presumably because I printed the markers too small (0.036m).
I had to switch the top and bottom marker IDs, I guess because in the usual use case the camera image is flipped?

This is great! :)

                markerPair.arucoMarkerCorners = CalculateMarkerCorners(arucoTopLeftPosition, arucoRotation, size);

Do we know whether the qr code is used for calibration/Should we avoid creating marker corners for the qr code when they are unavailable?

Refers to: src/SpectatorView.Unity/Assets/SpectatorView/Scripts/Calibration/HeadsetCalibration.cs:177 in 41229ba. [](commit_id = 41229ba48a384cf16481510668bbbfa1d5ecf838, deletion_comment = False)

I'd be more than happy to accept this change. I have made some comments around things that I think we should rename with this new support. If you can help address the comments great! If you would like help on our end let us know. :)
And thanks again for this submission!

@hermann-noll do you feel comfortable with us merging this into master?

Yes this PR should be good to go.


[SUGGESTION] Add reason as an optional parameter to i!make

Hello!
First of all, thanks a lot for making this bot! Since invitelogger classic was retired for public use, i was searching for an alternative and find this little great gem! I really appreciate this bot!
I just want to make a suggestion: a reason field to store things like a name or alias of each invite. For example, let's say i have a public server and i want to make different invites for different social networks; in InviteLogger Classic i would do !createinvite name #channel, so i think the reason field described by this discord.py topic would serve for this purpose.
BTW this bot is already amazing and i'm really thankful for your work!

Suure, I guess that's a reasonable addition. Will try to make it work:)

I've added names in this commit https://github.com/Nevalicjus/invitebot/commit/232af21de36f30a0b977c091ebbd3da8c0733a4d, and now i!make takes in #channel (name) (@role) (uses) (age). Name, as you proposed, can be trated as an alias for invites - they're shown in pretty much all places they can, including the most important i!list command