[ISSUE #982] Explicit usage of byte encoding

Fixes #982.
Modifications
Explicitly set the encoding charset for string-char or char-string conversions.
Documentation

Does this pull request introduce a new feature? no

@HeZean Great job, could you please make this into several small pr?

@HeZean Great job, could you please make this into several small pr?

With pleasure, does that mean submitting one PR for each module? Could you please further point it out

@HeZean Great job, could you please make this into several small pr?

With pleasure, does that mean submitting one PR for each module or so? Could you please further point it out

yes, that would be better to review, thx.

Hi @qqeasonchen, I just remembered that most changes are related to Constants.DEFAULT_CHARSET, which was changed from string "UTF-8" to charset StandardCharset.UTF_8, splitting this PR may be not that feasible since it would break some code (e.g. some code was Charset.forName(Constants.DEFAULT_CHARSET) should be changed to Constants.DEFAULT_CHARSET)

Maybe could you just review the changes thoroughly? they are all trivial modifications.

Maybe could you just review the changes thoroughly? they are all trivial modifications.

Got it, but smaller prs would be easy to review if you wish, thx.

@HeZean please take care of the CI check fails

okay, i'll fix it soon in a commit

The license checker failed, I've opened #1188 and will fix it in another pr.


Tweak/docs onboarding

Feature or Problem
This PR:

updates the "Get Started Today" button to the "Getting Started" page
formats the Installation page and adds one note about editing PATH
reformats, updates images, and streamlines the "Getting Started" page. The biggest change is the removal of references to wash call, since this is likely to be confusing to new users. I also consolidated some terminology

The goal is to make a new user's experience with the onboarding docs a little more straightforward

I would like to see the install instructions on the home page.


System.NotImplementedException: byref delegate

Prerequisites

[x] Are you running the latest version?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search?

Description
Running the following script via IronPython fails with the error System.NotImplementedException: byref delegate:
from functools import partial

def set_generated_rules(hk_world, hk_set_rule):
    player = hk_world.player
    fn = partial(hk_set_rule, hk_world)
    fn("Can_Replenish_Geo", lambda state: state.count('Tutorial_01', player) or TRUE)

Full exception
System.NotImplementedException: byref delegate
  at System.Linq.Expressions.Interpreter.LightLambda.CreateCustomDelegate (System.Type delegateType) [0x001cf] in <55b3683038794c198a24e8a1362bfc61>:0
  at System.Linq.Expressions.Interpreter.LightLambda.MakeDelegate (System.Type delegateType) [0x00012] in <55b3683038794c198a24e8a1362bfc61>:0
  at System.Linq.Expressions.Interpreter.LightDelegateCreator.CreateDelegate (System.Runtime.CompilerServices.IStrongBox[] closure) [0x00012] in <55b3683038794c198a24e8a1362bfc61>:0
  at System.Linq.Expressions.Interpreter.LightDelegateCreator.CreateDelegate () [0x00000] in <55b3683038794c198a24e8a1362bfc61>:0
  at System.Linq.Expressions.Expression`1[TDelegate].Compile (System.Boolean preferInterpretation) [0x0000b] in <55b3683038794c198a24e8a1362bfc61>:0
  at System.Linq.Expressions.Expression`1[TDelegate].Compile () [0x00000] in <55b3683038794c198a24e8a1362bfc61>:0
  at IronPython.Runtime.Binding.PythonGetMemberBinder+TieredJitPropertyGet`1[TSelfType].TryGetByJitRequiringCast (System.Reflection.MethodInfo method) [0x0013f] in <a86611c6793c4c3fa4eb7b40df26a1fa>:0
  at IronPython.Runtime.Binding.PythonGetMemberBinder+TieredJitPropertyGet`1[TSelfType].TryGetByJit (System.Reflection.MethodInfo method) [0x00017] in <a86611c6793c4c3fa4eb7b40df26a1fa>:0
  at IronPython.Runtime.Binding.PythonGetMemberBinder+TieredJitPropertyGet`1[TSelfType].GetProperty (System.Runtime.CompilerServices.CallSite site, TSelfType target, IronPython.Runtime.CodeContext context) [0x00016] in <a86611c6793c4c3fa4eb7b40df26a1fa>:0
  at IronPython.Compiler.Ast.DynamicGetMemberExpression+GetMemberInstruction.Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x0003d] in <a86611c6793c4c3fa4eb7b40df26a1fa>:0
  at Microsoft.Scripting.Interpreter.Interpreter.Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x0004f] in <cb667cab4c194a8ba9e2465e80d77714>:0
  at Microsoft.Scripting.Interpreter.LightLambda.Run4[T0,T1,T2,T3,TRet] (T0 arg0, T1 arg1, T2 arg2, T3 arg3) [0x0006d] in <cb667cab4c194a8ba9e2465e80d77714>:0
  at (wrapper delegate-invoke) <Module>.invoke_callvirt_object_Func`5<PythonFunction, object, object, object, object>_PythonFunction_object_object_object(System.Func`5<IronPython.Runtime.PythonFunction, object, object, object, object>,IronPython.Runtime.PythonFunction,object,object,object)
  at Microsoft.Scripting.Interpreter.FuncCallInstruction`6[T0,T1,T2,T3,T4,TRet].Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x00000] in <cb667cab4c194a8ba9e2465e80d77714>:0
  at Microsoft.Scripting.Interpreter.Interpreter.Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x0004f] in <cb667cab4c194a8ba9e2465e80d77714>:0
  at Microsoft.Scripting.Interpreter.LightLambda.Run5[T0,T1,T2,T3,T4,TRet] (T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4) [0x0007e] in <cb667cab4c194a8ba9e2465e80d77714>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <9577ac7a62ef43179789031239ba8798>:0

I have installed v3.4.1 of both IronPython and IronPython.StdLib via NuGet, and am calling the script via the helper class shown here:
internal class ScriptInstance
{
    private readonly ScriptEngine engine;
    private readonly ScriptScope scope;
    private readonly ScriptSource source;
    private readonly CompiledCode compiled;

    public ScriptInstance(string resource)
    {
        // 1. Create the engine.
        engine = Python.CreateEngine();

        // 2. Add the stdlib to the search paths.
        var assembly = Assembly.GetExecutingAssembly();
        string assemblyPath = Path.GetDirectoryName(assembly.Location);
        string libPath = Path.GetFullPath(Path.Combine(assemblyPath, @"lib"));
        var paths = engine.GetSearchPaths();
        paths.Add(libPath);
        engine.SetSearchPaths(paths);

        // 3. Load the script resource.
        using var stream = assembly.GetManifestResourceStream(resource);
        if (stream == null)
            throw new Exception("Error creating ScriptInstance - resource stream is null");
        using var sr = new StreamReader(stream);
        var script = sr.ReadToEnd();

        // 4. Compile the script.
        source = engine.CreateScriptSourceFromString(script, SourceCodeKind.File);
        compiled = source.Compile();

        // 5. Execute the script.
        scope = engine.CreateScope();
        compiled.Execute(scope);
    }
}

Versions
IronPython: v3.4.1
IronPython.StdLib: v3.4.1

Cannot reproduce, the Python sample is incomplete. What are arguments to set_generated_rules? Which version of .NET are you using?

Cannot reproduce, the Python sample is incomplete.

I'm not sure what you mean. That's the exact script I've been running that has the issue for me.

What are arguments to set_generated_rules?

I'm not actually calling set_generated_rules at any point yet, that's the next step. I'm just calling compiled.Execute() so I can attach the script to the scope so I can then get the function out to call it later (if there's an easier way to do that let me know, but I couldn't find one).

Which version of .NET are you using?

I'm using .NET 4.7.2.

OK, it wasn't clear to me at which place you were getting the exception. As I understand it now, it is compiled.Execute(scope); and not when calling set_generated_rules. Still, I cannot reproduce your issue. I tried .NET Framework 4.8 and .NET 6.0 — the script, as it is, executes just fine.
On a side note, your script uses TRUE rather than True? This variable will be undefined unless you define it explicitly before calling set_generated_rules if you get that far (though it should not have any consequence on the problem you are facing now).

I'm using .NET 4.7.2.

Not using Mono? Strange that I see System.Reflection.MonoMethod.Invoke in the stack trace.

OK, it wasn't clear to me at which place you were getting the exception. As I understand it now, it is compiled.Execute(scope); and not when calling set_generated_rules.

Correct.

Still, I cannot reproduce your issue. I tried .NET Framework 4.8 and .NET 6.0 — the script, as it is, executes just fine.

Huh. Weird. I'll do some more digging to try to find a better MRE.

On a side note, your script uses TRUE rather than True? This variable will be undefined unless you define it explicitly before calling set_generated_rules if you get that far (though it should not have any consequence on the problem you are facing now).

Good to know. I don't know python. That being said I'm sourcing the final script from elsewhere, so I'm not too concerned if my test script doesn't work 100%.

Not using Mono? Strange that I see System.Reflection.MonoMethod.Invoke in the stack trace.

I'll be honest, I have no idea. I'm not a C# dev, I'm just trying to make a mod for a Unity game. All I know is my .csproj says <TargetFramework>net472</TargetFramework>.

Ah, Unity… Just to make sure: are you running your mod on Unity on a desktop platform? If so, which one? Windows, macOS, UWP, Linux?
The "TargetFramework" moniker in .csproj specifies the .NET API, not necessarily the .NET platform. net472 means it is either .NET Framework or Mono. If you run on something else than Windows, then for sure it's Mono. Unfortunately, Mono does not implement the complete .NET API. Sometimes workarounds are possible.

I'm developing the mod on Windows, but the game itself (Hollow Knight) is cross platform. Also, after doing some more digging through the project setup I see references to Mono.Cecil, so I'm pretty sure it's Mono.
That being said, I don't understand why Mono would be a problem here. The error being thrown looks like a missing/bugged IronPython language feature error to me (but one I can't find where it's thrown from), not a .NET vs Mono error. Though admittedly I know almost no C#, so it's possible I'm overlooking something.

It does look like a something in Mono not being fully implemented in the version of Mono you are using. I have found a similar report in mono/mono#21534. This issue is still open, however I was able to run your example without problems with Mono v6.12 on Linux, so maybe it got implemented anyway and you are simply using an old Mono version.
I haven't worked on any Unity mod before, so I don't know anything about Unity toolset, but if it is possible, I'd recommend to migrate your mod project to .NET 6.0 or later. If you point me to some resources on Unity mod development in C#, I might be able to look into it (I have Unity on Windows installed).

Ah, I see. Well that's a shame. Unfortunately I don't think I have a way to adjust the Mono version used. I'm merely creating a dll that is then loaded by a Unity game outside of my control. I'll keep poking around though, see if there's some other solution I can find.

@thislooksfun Does your code fail with v3.4.0? You're hitting a code path that was recently modified for performance (https://github.com/IronLanguages/ironpython3/pull/1706) so if v3.4.0 works it might be possible to change some stuff to make it work again...

It does! Thank you!
However I now have a new problem in that now calling scope.GetVariable() is throwing System.TypeLoadException: Failure has occurred while loading a type., but that feels like a problem with my code rather than the library.

If you don't mind I'll re-open the issue since this is technically a regression. I'm thinking a try/catch of NotImplementedException would do the trick (although not sure how I'd go about testing it)...
private TryGetProperty TryGetByJit(MethodInfo method) {
    try {
        return method.DeclaringType!.IsAssignableFrom(typeof(TSelfType))
            ? TryGetByJitWithoutCast(method)
            : TryGetByJitRequiringCast(method);
    } catch (NotImplementedException) { // Mono can throw this...
        return TryGetByReflection;
    }
}

not sure how I'd go about testing it

.NET is being tested by several test runs on all supported versions, maybe something similar for Mono: one test run on the latest Mono version and one on the oldest that we support (though I don't know which one that is).

Well in theory the ".NET Framework" tests on Linux/macOS are Mono. Not sure which version, but I'm assuming they're on 6.12.something as that's the latest? As for the oldest that we should support probably depends on whats bundled with Unity as that appears to popular among users.


Add validation to contact email and phone number

Description
When adding a new contact, the phone number field validates that the entered text is a number, but not that it has the correct number of digits. There's also no validation on the email field to check for @ or . characters.
Acceptance Criteria:
Given I am a user
When I am on the Contacts page and I enter a phone number with the incorrect number of digits
Then I am given a user-friendly error message when I try to submit the form
Given I am a user
When I am on the Contacts page and I enter an incorrectly formatted email (missing the @ and/or .)
Then I am given a user-friendly error message when I try to submit the form
Development Checklist:

[ ] email regex<EMAIL_ADDRESS>[ ] north-american phone number regex
[ ] json-schema documentation: https://json-schema.org/understanding-json-schema/reference/regular_expressions.html
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[x] User story is included
[x] User role and type are identified
[x] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[x] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[x] Can be demoed in Sprint Review
[x] Bugs or future work cards are identified and created
[x] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @BCerki @Sepehr-Sobhani @gurjmatharu

Thank you @mikevespi! Tested in dev. Received expected error message when pone number or email address were incorrectly entered into the system.


Support and continue past research

Hi, I want the research to be a living project that can grow and be amended over time. And I would like to handpick a few resources to provide the model which can be difficult to get just by scraping, how can i do that?
My question is essentially two part:

How can I continue past research instead of starting over
How can i support the research with handpicked content, or helping it download paywalled content.

You know what mate, you ask me this while I am a little hammered on whiskey (I spent like 3 months making this program from scratch so I may have earned it idk) I have a final exam tomorrow for my math quiz, but this is an excellent question, due to the math exam tomorrow I may take a day, or four (I have another final exam 2 days after the math one last one for the trimester finally!)  I will try and update this to address your concerns, that is an interesting idea!
switching the LLM from the research phase to the summary phase, does sound at least intriguing, and I have meant to add an ability to continue past research for a while now so I WILL LOOK INTO IT BROTHER!!!
if I remember anyways if note reopen this!

Great contribution bro, just dont stress too much about it, take care!


Add MIP-B06

So it seems like this is also causing the tests for the previous MIP-b05 to fail because I updated the addresses in Addresses.sol for the new JRMs in this proposal. Unsure how we should resolve this, would appreciate your thoughts here!

Newly deployed contracts for this proposal:

Stablecoin JRM https://basescan.org/address/0x492dcEF1fc5253413fC5576B9522840a1A774DCe
WETH JRM https://basescan.org/address/0x142DCAEC322aAA25141B2597bf348487aDBd596d

calldata verified!


Add Predicted kills

To know if he did wannted or accidently

i dont think this would be necesary

Tutorial isn't necesary and that is in the plugin

players who play in a new map need a tutorial to know more about map

Pretty poor sportsmanship by that player who logged off, I suppose.

This is a scrimmage plugin. If someone logs off, make it an automatic win.

@dentmaged That is a horrible idea. What if someone's internet dies or their client crashes?  However, that is a valid point.

If is an TDM match and the player do log out or his conecction drop, the other team should have the kill


impr(webapp)-add-whitepaper

Related Case: https://github.com/bitcashorg/smartsale/issues/91

Summary by CodeRabbit

Chores

Updated the .gitignore file to exclude additional environment-specific files from version control.

see https://github.com/bitcashorg/smartsale/pull/110


Session closed dialogue should only be shown when a session runs out ( 5 minutes expired ), not when changing or starting project.

Currently this is very confusing and makes it seem like a bug. Because every time the session is changed, the old one is closed.
Only call this information message when the session actually expires, not when changing the project.

When changing project, do we then show the session closed message or not?  Like this or do I need to delete the session closed message?


Is DataType.BYTES control in aggregate() aggregateGroupBySV() aggregateGroupByMV() needed?

Hello, in different aggregators like the following:

https://github.com/apache/incubator-pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AvgAggregationFunction.java#L100

https://github.com/apache/incubator-pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinMaxRangeAggregationFunction.java#L104

I see a "pseudo duplication" of the code because of the column DataType. But, is this really needed?
I think that serialization/deserialization is done in aggregationResultHolder object only, no?

@Jackie-Jiang @mayankshriv what do you think about this? Its not clear from the code why we are handling BYTES in AVG and MinMax

We allow serialized pre-aggregated BYTES for these aggregation functions so that users can pre-aggregate the records, or enable star-tree on these functions:

AVG
MINMAXRANGE
DISTINCTCOUNTHLL
PERCENTILEEST
PERCENTILETDIGEST

so, this is not a must for other functions right?

It is required if these conditions are met:

The intermediate result type is Object instead of Number or String
User might want to pre-aggregate for the aggregation function

E.g. for DistinctCountAggregationFunction, even though the intermediate result type is IntOpenHashSet, we don't want user to pre-aggregate because the size of the pre-aggregated result is unbounded. In such case, we don't support BYTES type.

Not an issue


Install tileserver-gl-light

Mapbox gives this error when we try to put all codes in the same mbtile:

We should use tileserver-gl or tileserver-gl-light to serve the tiles ourselves. Local tests did not give the same error as Mapbox.

Installed on webadbtest01


Compalitible with Windows? Steps for installation in Windows

Is Joern compatible with Windows 10? If yes, what are the steps to be followed? I couldnt find the steps for Windows in the documentation or not sure if I am missing something.

All frontends and the joern cli are compatible, yes.
Just git clone the repo and run sbt stage there. You will find executables, e.g.,:

for joern cli: path\to\joern\joern-cli\target\universal\stage\bin\ammonite-bridge
for c2cpg: path\to\joern\joern-cli\frontends\c2cpg\target\universal\stage\bin

Thank you for the steps. I tried this steps but getting this error (shown below).

$ sbt stage
Picked up _JAVA_OPTIONS: -Xmx512M
copying runtime jar...
mkdir: cannot create directory ‘’: No such file or directory
Picked up _JAVA_OPTIONS: -Xmx512M
Error occurred during initialization of VM
Initial heap size set to a larger value than the maximum heap size
Picked up _JAVA_OPTIONS: -Xmx512M
Error occurred during initialization of VM
Initial heap size set to a larger value than the maximum heap size

I am not sure if this is because of the available amount of memory.
If I have to configure JVM to avoid this error, what would be the recommended memory size?

looks like you should clear or redefine some of your environment variables...

Try to set -Xmx to something larger, 4G or 8G should do it depending on your system.


color picker handle

It is impossible to change size of Color Picker Handle, that small circle.

Currently it is a handleSize: CGSize get-only property which is calculated relative to the parent view (ChromaColorPickerView).

yes I know that, but it's very bad(

The project is currently being rewritten (90% complete) under the develop branch. The new UI and design allows for changing the handleSize. Stay tuned for the update, otherwise, feel free to make a PR in the meantime


Api Key generation Error

When i triying to generate APi Key for new users:
php artisan api-key:generate --user-id=X

But the terminal print the following error:
[ErrorException]
  Non-static method Chrisbjr\ApiGuard\Repositories\ApiKeyRepository::generateKey() should not be called statically
```
Previously i generate 3 keys, but now i can't create new ones.

Thanks

I'm also getting this error when using dev-master

Confirmed bug. Will fix this ASAP


JSG Completion: add interim jsg::Lock::v8Set and jsg::Lock::v8Get

Help to eliminate v8 specific boilerplate when getting/setting values on v8::Object instances. This should be considered transitional. It helps to eliminate a number of direct uses of v8::Isolate and other v8 specific APIs but does not completely hide the v8 semantics.
For example,
  jsg::check(bound->Set(js.v8Context(), jsg::v8StrIntern(js.v8Isolate, "foo"_kj), handler.wrap(js, JSG_THIS)));

  // becomes

  js.v8Set(bound, "asyncResource"_kj, handler.wrap(js, JSG_THIS));

Is the idea that eventually we'll have a wrapper for v8::Local<v8::Object> that has get() and set() methods?
I guess v8Set() and v8Get() have the funny-looking v8 prefix because they operate on v8::Local rather than a JSG wrapper type?

Is the idea that eventually we'll have a wrapper for v8::Local<v8::Object> ...

I think so but still thinking through it.

I guess v8Set() and v8Get() have the funny-looking v8 prefix ...

Yep, that's exactly it.

Something is up with one of the changes here... I'll investigate in a bit and move back to ready status once Ive updated


Added L9 to composer.json

Hi @ArlonAntonius @luceos
I just tried to add the new v2 to my L9 project and it still said it was locked to L7 and L8 so have updated the composer pacakge

Actually i think all the individual packages need updated to 2.x. I'll leave this here as a reminder

You are right, here is the right PR: https://github.com/tenancy/tenancy/pull/254
Thanks, we missed this 🙈


RDKDEV-654 RDKCOM-3562 Key protection for DIAL system sleep request

RDKDEV-654 RDKCOM-3562 Key protection for DIAL system sleep request
Custom key can be used to protect
'system?action=sleep'
requests (as specified in Dial 2.2, system sleep request) The key value can be passed via SYSTEM_SLEEP_REQUEST_KEY env var; if not defined - will not be validated
Signed-off-by: tomasz-karczewski-red<EMAIL_ADDRESS>(cherry picked from commit 4cea95aec9af1d4ed8963166b3512dce8887134e) (cherry picked from commit 19ee7a7b39c33c489e41227f83c48cc5832b53cc)

https://jenkins.code.rdkcentral.com/job/github-triggered/28396/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/20288/ started

https://jenkins.code.rdkcentral.com/job/build-component/64842/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/32776/ started.

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/139678/

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/139677/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/139756/

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/32811/ started.

Smoke tests for ['build-brcm-va'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/139798/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/139797/

https://jenkins.code.rdkcentral.com/job/github-triggered/29289/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/21030/ started

https://jenkins.code.rdkcentral.com/job/build-component/65753/ started.

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/141591/

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/141590/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/141592/


PDI-13500 -- MongoDB Input "GetDBs" option fails to fetch database

information when Authentication is used in MongoDB
What was done:

resolved double authentication issue with 2.13 driver
resolved db selection issue. Empty DB is no longer allowed for
authentication, so default admin db is used

@m-a-hall , Mark , could you please review


missing buffer auto command for buffer number 1

Buffer auto commands are missing for the first file I open after starting neovim.
I've setup some buffer auto commands as follows:
local file_icon = subscribe.buf_autocmd(
  "el_file_icon",
  "BufEnter",
  function(win, buf)
    local icon = extensions.file_icon(win, buf)
    return icon and icon .. ' ' or ''
  end
)

local git_branch = subscribe.buf_autocmd(
  "el_git_branch",
  "BufEnter",
  function(win, buf)
    local branch = extensions.git_branch(win, buf)
    if branch then
      return ' ' .. extensions.git_icon() .. ' ' .. branch
    end
  end
)

Now I start neovim without opening any file,  this means I've opened a "no name" buffer with buffer number 1.
We can see the buffer auto commands are correctly set up for this buffer in the following screenshot:

and the status line is showing the correct git branch info and file icon:

Now if I open a file, the git branch name and file icon are missing in status line in the following screenshot:

I list the buffers with the :buffers command,  I can see this new buffer has buffer number 1, but there's no buffer auto commands setup for it.
This problem only happens for the first file I open, which has buffer number 1. If I open a second file, it will have a different buffer number and all the git branch info, file icon are correctly shown in the status line.
This issue has happened to others too, in https://github.com/tjdevries/express_line.nvim/issues/31

I think I've found the reason why this happens.
When I open the first file, neovim re-uses the buffer number 1 because I didn't touch the "No Name" buffer,
When neovim wipes out the "No Name" buffer, it deletes all the buffer auto commands associated with it.
When I enter the new buffer, express_line believes it has already setup buffer auto commands for the new buffer, because  it has the same buffer number. This is how you end up with a buffer without the buffer auto commands to show the git branch and file icon.

The solution is to reset buffer auto command subscription for a buffer when we notice something is wrong, so that new buffer auto commands will be setup again by  require('el.sections').buf_autocmd next time it's called.
I'll open a pr later.


Add more unit tests for the PT common lib

Some tests have been added, but we need more.
Some code refactoring may be required in order to simplify writing the tests.

First batch of unit tests for the Settings functions has been merged https://github.com/microsoft/PowerToys/pull/921
Next step is to also produce code coverage and from there identify other areas to test.

what is the status here.  vague next steps

Let's close this one and open a new one for code coverage.


Add a simple way to override the default inside padding

@vHanda: Thanks for your contribution. We will review ASAP. But one change require for now. Please update this change in CHANGELOG.md file

Done. I'll update #112 once this is merged. As we would otherwise get merge conflicts.

Hi @ShwetaChauhan18, could a new release please be made?


Add TravisCI to project

See e.g. https://github.com/sul-dlss/libsys-webforms/pull/2/files

Closed by #13


Dark Mode HTML tag Attribute is incorrect in the DOCUMENTATION and elsewhere on the web for Bootstrap 5.3.0+

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
The <html lang="en" data-bs-theme="dark"> is incorrect per the Javascript Source Code which uses <html lang="en" data-bs-theme-value="dark"> to set the DEFAULT page them to the Dark Mode.  I've tested it and it works!  I also checked the TOGGLE Javascript code which worked when changing the default Theme from Light to Dark and Back.  So I went and searched through that code to find the CORRECT attribute:  data-bs-theme-value.  The DOCUMENTATION is WRONG!
Reduced test cases
<html lang="en" data-bs-theme-value="dark">  To default the theme to "Dark" on the webpage.
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.3.0

Hello @k-kycia
Thanks for reporting an issue here.

The DOCUMENTATION is WRONG!

It's not. Maybe there's a misunderstanding about how it works.

data-bs-theme-value is only used by our color-modes.js to handle the rendering of the buttons, not to handle the color modes (dark mode)
data-bs-theme is the one to use. You can see in our own documentation that this is the one used near the <html> tag. More info at https://getbootstrap.com/docs/5.3/customize/color-modes/#enable-dark-mode.


[WAITING ON Finance] Content: Adding Bankruptcy/Default question to part-time application

Adding question 18/19 from the current part-time application to SIMS.
Acceptance Criteria
To the personal information page add the following questions:

[ ] "Are you currently in default of a Canada Student Loan (full-time or part-time?"

[ ] Add radio buttons "Yes" and "No"

[ ] This question is purely informational and should have no impact on the application or assessment

[ ] "Have you ever declared bankruptcy that included student financial assistance?"

[ ] Add radio buttons "Yes" and "No"

[ ]  If student answers "No" then no action

[ ]  If student answers "Yes" this will be an exception path question and will trigger an exception

Checking with policy about need for these questions

Closing - no functional use for it in the application.


Tom/1625 - ECMAScript 6 support

There is a checkbox for ES6 support in language manager. It defaults to true.

cool.  but please use radio buttons instead of a checkbox,
name the group "JavaScript Version" with two options:
"Browser Native" and "ECMAScript 2015"

This PR includes the #3588 PR for fixing checkbox display in default theme.


Extending Monterey beyond being "app generator" - proposal 2

This is the lightweight cousin of the Extending Monterey beyond being "app generator" - proposal 1 article.

In order to respond quickly to Rob's issue listed in Addressing first Monterey evaluation issues, section Expanding current functionality, I am proposing the following additions to Monterey

All this, except the mentioend articles, is what we have right now. So what is the proposal here?


Characters don't show up in http://www.tryfsharp.org/Create

I hardly think this is the right spot for this, please redirect:
On OS X 10.10.2 (14C109), when using Safari Version 8.0.3 (10600.3.18) at tryfsharp.org/Create, no text that I type in the 'script window' actually appears when I type. However, after typing, and then pressing 'run', what I typed appears in the 'output window'
Thanks, Brody

Hi @brodyberg - Yes, not the right spot.  I think use TryFSharp AT microsoft.com.


Ping between mediator and room to keep connection live

Mediator should be able to send WebSocket ping requests, rather than updating WebSocket protocol.
(a protocol ping message was sent to the browser to allow the browser to decide when to suspend the user's session, e.g.)

Resolved by #81


Gardener fails to create shoots with > ~80 worker pools

How to categorize this issue?

/area scalability
/kind bug
What happened:
When attempting to create a shoot with over approximately 80 nodepools, the shoot becomes stuck in the Create Processing state. The shoot generates an error message stating: Flow "Shoot cluster reconciliation" encountered task errors: [task "Configuring shoot worker pools" failed: retry failed with context deadline exceeded, last error: etcdserver: request is too large] Operation will be retried.
Upon investigation, it was discovered that the Worker resource, which is created for the shoot, becomes excessively large due to each WorkerPool containing userData necessary for machine bootstrap. This exceeds the etcd's max-request-bytes limit of 1.5MiB for the worker resource.
What you expected to happen:
The shoot should be successfully created.
How to reproduce it (as minimally and precisely as possible):
Create shoots with a large number (80-90+) of nodepools.
Proposed Solution:
Suggest replacing the userData field in the WorkerPool type with a secretReference. This approach aligns with the OperatingSystemConfig resource, which already stores its cloud_config in a secret. Refer to the OperatingSystemConfig documentation for more details.
Tasks:

[x] https://github.com/gardener/gardener/pull/9722
Adapt Worker extensions (after v1.95 has been released)

[ ] provider-alicloud: https://github.com/gardener/gardener-extension-provider-alicloud/pull/727
[x] provider-aws: https://github.com/gardener/gardener-extension-provider-aws/pull/961
[x] provider-azure: https://github.com/gardener/gardener-extension-provider-azure/pull/868
[x] provider-gcp: https://github.com/gardener/gardener-extension-provider-gcp/pull/767
[ ] provider-openstack: https://github.com/gardener/gardener-extension-provider-openstack/pull/776
[x] provider-equinix-metal: https://github.com/gardener/gardener-extension-provider-equinix-metal/pull/314

[ ] After<EMAIL_ADDRESS>has been released: Drop deprecated UserData field from extensions.gardener.cloud/v1alpha1.Worker resource

Environment:

Gardener version: v1.82.3
Kubernetes version (use kubectl version): v1.26.14
Cloud provider or hardware configuration:

openstack-provider v1.39.2
coreos extension v1.21

Others:

etcd-druid v0.20.0

We checked a Worker with > 80 pools and saw that we could reduce the size by ~90% when we referenced the userData instead of putting it inline.

/assign

For now, all related PRs have been opened. Still, we have to wait until<EMAIL_ADDRESS>has been released (end of July 2024) before we can finally cleanup the inlined, now deprecated .spec.userData field from the extensions.gardener.cloud/v1alpha1.Worker API. This is to give extensions enough time to adapt to the API change.
Before this is done, the issue cannot be closed.

All tasks have been completed.
/close

/reopen
The PR linked above (#10220) was confusing - it was supposed to close this issue, but due we have reverted the needed API cleanup with https://github.com/gardener/gardener/pull/10285, so we have to wait a bit longer. I'll update above issue description accordingly.


cache-bypass-on-cookie: The set-cookie header is not propagated from server when bypassing cache

The set-cookie header is not propagated from server when bypassing cache in cache-bypass-on-cookie.

I have a CF worker based on this code and just tested for this. I am seeing the same behavior of the set-cookie header not making it through.
Just looking at the code, I can't see what the problem might be. The Response object has no special property for cookies, it's just the headers as a whole that get populated in the constructor.
https://developers.cloudflare.com/workers/runtime-apis/response
Seems strange that all the other headers get populated but not set-cookie.

I was trying to fix this by setting Cache Level: Bypass Page Rule on cf_cache_bust urls as you can see in these commits:
https://github.com/PetrDlouhy/cf-workers/commit/8aca0a6cc490250369d01d3e38c57e0ca5712ca7
https://github.com/PetrDlouhy/cf-workers/commit/28a93b0fdf5b17d560adc6aef747fd8d5142c4bc
But I was not able to make it working properly with real requests, although it worked in the debug console.
I ended up with reversing the behaviour - setting force_cache=true query parameter and caching only those urls. So far it seems, that this works. My not-yet-finished code is:

 /**
 * Main worker entry point.
 */
addEventListener("fetch", event => {
  //event.passThroughOnException();
  const request = event.request;
  if (!bypassCache(request)) {
    event.respondWith(handleRequest(request));
  }
});

/**
 * Do all of the work to bypass the cache
 * @param {Request} request - Original request
 */
async function handleRequest(request) {
    // Clone the request so we can add a no-cache, no-store Cache-Control request header.
    let init = {
      method: request.method,
      headers: [...request.headers],
      redirect: "manual",
      body: request.body,
      cf: { cacheTtl: 86400 }
    };

    // Use a unique URL (query params) to make SURE the cache is busted for this request
    let uniqueUrl = await generateUniqueUrl(request);
    let newRequest = new Request(uniqueUrl, init);
    newRequest.headers.set('cache-control', 'max-age=86400');
    // newRequest.headers.set('Cache-Control', request.headers.get('Cache-Control'));
    // newRequest.headers.set('Date', request.headers.get('Date'));

    // For debugging, clone the response and add some debug headers
    let response = await fetch(newRequest);
    let newResponse = new Response(response.body, response);
    newResponse.headers.set('X-Bypass-Cache', 'Forced');

    return newResponse;
}

/**
 * Determine if the given request needs to bypass the cache.
 * @param {Request} request - inbound request.
 * @returns {bool} true if the cache should be bypassed
 */
function bypassCache(request) {
  let needsBypass = false;

  // Bypass the cache for all requests to a URL that matches any of the URL path bypass patterns
  const url = new URL(request.url);
  const path = url.pathname + url.search;

  if (NO_BYPASS_URL_PATTERNS.length) {
    for (let pattern of NO_BYPASS_URL_PATTERNS) {
      if (path.match(pattern)) {
        return true;
      }
    }
  }
  if (BYPASS_URL_PATTERNS.length) {
    for (let pattern of BYPASS_URL_PATTERNS) {
      if (path.match(pattern)) {
        needsBypass = true;
        break;
      }
    }
  }

  // Bypass the cache if the request contains a cookie that starts with one of the pre-configured prefixes
  if (!needsBypass) {
    const cookieHeader = request.headers.get('cookie');
    if (cookieHeader && cookieHeader.length && BYPASS_COOKIE_PREFIXES.length) {
      const cookies = cookieHeader.split(';');
      for (let cookie of cookies) {

        // If cache-cookie is set, drive cache explicitly
        if(cookie.trim() == 'cache-cookie=no-cache'){
          return true;
        };
        if(cookie.trim() == 'cache-cookie=cache'){
          return false;
        };

        // See if the cookie starts with any of the logged-in user prefixes
        for (let prefix of BYPASS_COOKIE_PREFIXES) {
          if (cookie.trim().startsWith(prefix)) {
            needsBypass = true;
            break;
          }
        }
        if (needsBypass) {
          break;
        }
      }
    }
  }

  return needsBypass;
}

/**
 * Generate a unique URL so it will never match in the cache.
 * This is a bit of a hack since there is no way to explicitly bypass the Cloudflare cache (yet)
 * and requires that the origin will ignore unknown query parameters.
 * @param {Request} request - Original request
 */
async function generateUniqueUrl(request) {
  let url = request.url;
  if (url.indexOf('?') >= 0) {
    url += '&';
  } else {
    url += '?';
  }
  url += 'force_cache=true';
  return url;
}

The response handling looks the same. Do you see the set-cookie header coming through with this code?
Your code looks similar to mine, in that I didn't go for the unique URL approach to forcing cache bypass. By coincidence I noticed a problem today with redirects not working because of the cache bypass query string being appended, so I made a change to work around that today (the 404 part).
`/*
This script is based on
https://github.com/pmeenan/cf-workers/blob/master/cache-bypass-on-cookie/cache-bypass-on-cookie.js
*/
// Cookie prefixes that cause a request to bypass the cache when present.
const BYPASS_COOKIE_PREFIXES = [
"wordpress_logged_in_"
];
// URL paths to bypass the cache (each pattern is a regex)
const BYPASS_URL_PATTERNS = [
/^/reviews/[^/]+/$/,
/^/b/[^/]+/$/
];
/**

Main worker entry point.
*/
addEventListener("fetch", event => {
const request = event.request;
if (bypassCache(request)) {
event.respondWith(handleRequest(request));
}
});

/**

Do all of the work to bypass the cache

@param {Request} request - Original request
*/
async function handleRequest(request) {
// Clone the request so we can add a no-cache, no-store Cache-Control request header.
let init = {
method: request.method,
headers: [...request.headers],
redirect: "manual",
body: request.body,
cf: { cacheTtl: 0 }
};
// Use a new URL to tell CF not to use the cache
let newUrl = await generateNewUrl(request);
let newRequest = new Request(newUrl, init);
newRequest.headers.set('Cache-Control', 'no-cache, no-store');
// Clone the response and add a response header
let response = await fetch(newRequest);
if(response.status == 404) {
// Try again without ?bypasscache=1 parameter
// The parameter means that Yoast redirect rules don't match so Yoast redirects will never work for logged in users
newRequest = new Request(request.url, init);
newRequest.headers.set('Cache-Control', 'no-cache, no-store');
response = await fetch(newRequest);
}
let newResponse = new Response(response.body, response);
newResponse.headers.set('X-Cookie-Bypass', 'Logged In');
return newResponse;
}

/**

Determine if the given request needs to bypass the cache.
@param {Request} request - inbound request.
@returns {bool} true if the cache should be bypassed
*/
function bypassCache(request) {
let needsBypass = false;

// Only bypass for requests to URLs that match one of the URL path patterns
const url = new URL(request.url);
const path = url.pathname; // + url.search
let urlBypass = false;
if (BYPASS_URL_PATTERNS.length) {
for (let pattern of BYPASS_URL_PATTERNS) {
if (path.match(pattern)) {
urlBypass = true;
break;
}
}
}
// Only bypass if the request contains a cookie that starts with one of the pre-configured prefixes
let cookieBypass = false;
if (urlBypass) {
const cookieHeader = request.headers.get('cookie');
if (cookieHeader && cookieHeader.length && BYPASS_COOKIE_PREFIXES.length) {
const cookies = cookieHeader.split(';');
for (let cookie of cookies) {
// See if the cookie starts with any of the logged-in user prefixes
for (let prefix of BYPASS_COOKIE_PREFIXES) {
if (cookie.trim().startsWith(prefix)) {
cookieBypass = true;
break;
}
}
if (cookieBypass) {
break;
}
}
}
}
needsBypass = urlBypass && cookieBypass;
return needsBypass;
}
/**

Generate new URL
@param {Request} request - Original request
*/
async function generateNewUrl(request) {
let url = request.url;
if (url.indexOf('?') >= 0) {
url += '&';
} else {
url += '?';
}
url += 'bypasscache=1';
return url;
}`

@Salubritas With the reversed behaviour the set-cookie header gets delivered just fine. The requequest will come with cf-cache-status: DYNAMIC unless it is cached.
With the approach I tried at first (those commits) I did see the original set-cookie header only in the debug console. With real requests it ended up with cf-cache-status: MISS and set-cookie header from the CF caching engine. It was strange, but I was not able to get over that.


Reduce preferred vector size

This makes it ~.5s faster on my 12 core machine
Check List:

[X] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[X] All formatting changes by the build are committed
[X] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[X] Output matches that of calculate_average_baseline.sh
[X] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)

Execution time: 4.5s
Execution time of reference implementation: 3m25s

00:05.180 now.


Support snapshotting of non-project libraries

Guild's sourcecode support applies to project-specific code. What about libraries that a script depends on? While these may be captured sufficiently by pip freeze (available for Python runs - view using guild cat -p .guild/attrs/pip_freeze), this information does not capture Python libraries that are not installed as packages and not strictly versioned. E.g. if you rely on shared in-house code that resides outside the project (extremely reasonable!) and make that code available via PYTHONPATH, you'll lose source code or versioning information for the run.
One approach here might be to extend sourcecode to include a list of modules or packages (Python support obviously, but this is a language-agnostic topic).
op:
  sourcecode:
    - include:
        package: [foo, bar]

In this case, Guild would copy the sourcecode for the specified packages. As Guild lists the op sourcecode path ahead of others in PYTHONPATH for an operation, these copied files would correctly take precedence over the library sources. This further insulates a run from potential upstream changes in the library code (an increasingly likely possibility if the upstream code is an actively maintained shared code base).

Issue resolution doc: https://github.com/guildai/issue-resolution/tree/master/195-support-snapshotting-of-non-project-libraries


RfC : Allow showing a warning when an arbitrary ingredient is present

Problem

People keep asking for showing a warning when an arbitrary ingredient is present
We can't flag anything beyond allergens

Proposed solution

Allow adding several arbitrary ingredients to a warn list
Mention that the feature is experimental and risky
Allow showing a warning when an arbitrary ingredient is present

At this point this is a request for comment. What would you expect from the server?

Something like synonyms or hierarchy:

if I don't want "cow cheese" or "blue cheese" in general in my pizzas, I know I won't find that as an ingredient, but I would find actual cheese names (e.g. "gorgonzola"). Let alone mozzarellas that is not supposed to be a cow cheese, but that's another story.
if I don't want "raisins secs" - suppose I have a good raisin for that ;) - I guess "raisins de Corinthe" or "raisins de Smyrne" should be kept away too


hey guy

it have error   65
i like you  cbot   cheer up to next develop

You have cTrader 3.3(as you can see on top of your platform) this bot is only working with 3.5 and up.

No intention to make code work with 3.3 or earlier.


Render pdf chart labels in html

Who is this PR for?
All users
What problem does this PR fix?
Since highcharts 8.1.0, wkhtmltopdf produces a segfault when trying to render our charts with data labels. See, eg., https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4233 and https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4233
What does this PR do?
Sets the datalabels to render as html. The practical upshot is that the label numbers are just plain black now.
Screenshot (if adding a client-side feature)
Before:

After:

Checklists
Which features or pages does this PR touch?

[x] Student Report PDF

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

[x] Manual testing made more sense here

Tested a variety of pdf options. This should be low impact at allows us to keep highcharts up to date, so shipping.


Implement channel banners.

Summary
I'm unable to test as I can't access a server that has them enabled.

General Info

[ ] If code changes were made then they have been tested.

[ ] This PR fixes an issue (please put issue # in summary).
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Commit #a2935af94ef935dc7f7ac37d2c2663ddc6312205, what are channel banners? I've never heard of them before.

It's an experiment that adds a banner above the member list for every channel.

Very cool, I'd like to request though, for commits like 332e4086580d50a05a21d0c418bd1064098dd201 where there are a variety of small changes (updating stage privacy and removing people from threads), it would be appreciated if you could explain the changes in the description instead of solely the commit message, which isn't informative at all.


Fixes #5

I had some trouble with the dev tooling so I couldn't test it but I think this is right.

I tried it out and everything looks great--thanks!


Landing fires onTakeOff event

Issue description
I noticed in the documentation that there was no onLand method described, and went digging in the source code. Inspecting TardisRefinedCompat.java shows that the TardisRefined compatibility does detect the landing event, but fires onTakeOff rather than an onLand event. Furthermore, inspecting TardisPeripheralTile.java reveals that the tile entity has no functionality to produce an onLand event yet.
https://github.com/leafreynolds/Handles/blob/8ad005b1f26caafccdda8e5beb361134e3c54f95/common/src/main/java/leaf/handles/compat/TardisRefinedCompat.java#L12
https://github.com/leafreynolds/Handles/blob/8ad005b1f26caafccdda8e5beb361134e3c54f95/common/src/main/java/leaf/handles/blockEntities/TardisPeripheralTile.java#L105-L219
Could an onLand event be added, please?
Steps to reproduce
No response
Minecraft version
1.19.2 (Latest)
Forge version
N/A
Handles version
Source
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response

You were correct. I somehow missed the onLand function when hooking up tardis events, hooking the event into onTakeOff instead. I'll be fixing and making new builds today :)

Hi there, this should now be fixed in version <IP_ADDRESS> for both forge and fabric :) ty for reporting the issue


Revert "code refactoring"

Reverts fjia30/MarkovSoccerGame#2

Hi nbro
After testing it I feel that it becomes less straightforward for the
primary users which are students from the class to utilize the tool.
The primary goal it to serve the class not to make it into a package for
broad access. I hope you can agree. I do thank you for the effort.
Best
Fan
On Tue, Aug 22, 2023 at 6:30 PM nbro @.***> wrote:

Why did you do this? It makes no sense to me, given that my changes
improved the code.
—
Reply to this email directly, view it on GitHub
https://github.com/fjia30/MarkovSoccerGame/pull/4#issuecomment-1689092305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANC7IJV7P2DJMKPSG6OBHPDXWVFLRANCNFSM6AAAAAAUKCM5DM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


More unit tests

Unit testing is very possible albeit a bit bottlenecked on being able to load a wasm module quickly. The default fastly setup generates an artifact that takes two to three seconds to load. That happening in every test would be a super slow feedback cycle.
Look for current options for loading the module once and sharing between tests. This should be possible as modules are cheaply and safely cloneable

A path is now available to make this easy


Fix URL Parameters in Theodul Player

This patch fixes the bug where parameters appended to a Theodul player
URL are ignored.
This fixes #1320
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch (features can only go into develop)
[x] include migration scripts and documentation, if appropriate
[ ] pass automated testing
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits
[x] have appropriate tags applied

Hi @lkiesow, I've just applied and tested this patch on my test setup and I can confirm it resolves the issue: URL parameters are working again. Thanks for the fix!

@majosch, thanks for testing this. This will then be part of 8.1.


Multi-tenant Merge to Develop

Merging the long-lived sdp-multi-tenant branch back into develop.

stellar-disbursement-platform-frontend-preview is available here:http://sdp-frontend-pr81.previews.kube001.services.stellar-ops.com/

stellar-disbursement-platform-frontend-preview is available here:http://sdp-frontend-pr81.previews.kube001.services.stellar-ops.com/


React Native - App Resume Bug [Duplicate Activity on top]

Hi,
I started using my react native app. Gone to background and resumed after sometime (Open app from appdrawer).
Environment
Android
Environment:
OS: macOS Sierra 10.12.6
Node: 8.8.1
Yarn: 1.2.1
npm: 5.4.2
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B46
Android Studio: 3.1 AI-173.4697961
Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.2
react-native: ^0.54.2 => 0.54.2
Expected Behavior
App should work normally
Actual Behaviour [Some times]
A new activity / duplicate activity above the existing activity . You can see another status bar and a padding at the top . Pressing hardware back button dismisses the activity and show the original activity. I am seeing this behaviour couple of times.. (I don't have any steps to reproduce this .. happens when app is resumes)
Reproduce issue
Open your app .. and go to background.
wait for sometime and open app from app drawer again
Any workaround for this issue or fixes??
any thing to do with launchMode in Android?

@react-native-bot Updated

have same issue

@poberwong I added   android:launchMode="singleTask" to MainActivity in Android Manifest
Seems like issue was resolved .. not sure though

Hi,
I was having the same problem and it's an Android thing. If you start the react native app with react-native run-android, it will launch the activity with a different intent than if it was launched via tapping the app icon on home screen. So, the default behavior on Android is to just add another activity when the intent launching it is different than the previous one. Just close the app on recents view and launch again and it will be fine.


Refactor replay in preparation for adding compilation option of replays.

This pull request contains no function changes.  Only the implementation of the replay tool has been simplified somewhat in preparation for implementation of new capabilities to compile replay text files for quicker playback of large replays.

@davidbeckingsale, would you take a look at this?  Ideally, I would like to merge this into trunk before I start adding the compile functionality.


Avatar dis-accumulation

If avatars are accumulated in one area - and thus overlapping each other, mouse-overing on such group should scatter them.

This issue is duplicated of #75

Ah, my bad. :D Sorry. :) Closing then!


[e2e]: container-based schedule main registry-username-secret

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/10731723223
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.registry-username-secret.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.registry-username-secret.yml
Trigger: schedule
Branch: main
Date: Fri Sep  6 03:07:18 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/10748120461
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.registry-username-secret.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.registry-username-secret.yml
Trigger: schedule
Branch: main
Date: Sat Sep  7 03:08:30 UTC 2024
Tests are passing now. Closing this issue.


Add support for MCDM/DXCore devices.

We need DXCore to enumerate VPU device, so should we replace IDXGIAdapter with IDCoreAdapter? wdyt? @bjjones @bbernhar @junwei

In my brief research it looks like IDXCoreAdapter and IDXGIAdapter are not directly interchangeable. This would require us to use slightly different functions internally for residency management.
Any comments @bbernhar? Is VPU support in the scope of GPGMM? I'm not sure if there's another reason someone would use DXCore over DXGI.

I'm supportive and I think it fits with the overall architecture and direction of the project (DXCore backend). @bjjones Can I assign you to dig into this?

Thanks for support, I think DXGI still is our focus to integrate into Chromium for GPU device, VPU is a longer term plan to support as you changed the title of issue.

Thanks for support, I think DXGI still is our focus to integrate into Chromium for GPU device, VPU is a longer term plan to support as you changed the title of issue.

Yes, agree. Just propose this here, we should consider supporting DXCore in the near future, maybe both support DXGI/DXCore currently by flag to select (for example, ENABLE_DXCORE= false by default) as onnx-runtime.


Devtools show all components twice

Version
v1.4.2
Reproduction link
https://github.com/johnRivs/nuxt-bug
Steps to reproduce
nuxt.config.js and layouts/default.vue are empty. No transitions used.
Versions used: Vue 2.5.17 and Nuxt 1.4.2, can be reproduced in nuxt-edge as well.
Might be an issue with the current vue-devtools version/beta :thinking:

cc @johnRivs
What is expected ?
Displaying components only once (not under "transition" mode)
What is actually happening?
Duplicates

This bug report is available on Nuxt community (#c7747)

Can't reproduce with latest Vue devtools stable version, so it's a vue-devtools issue. See https://github.com/vuejs/vue-devtools/issues/769 for further info/updates


Remove unnecessary code

Coverage increased (+2.4%) to 97.143% when pulling dcac99de05c24d0904c277ad087f2db913107647 on remove_bad_code into 9ba100fb45e907f224fccd2f4bc18e18a24ee0b2 on master.

Coverage increased (+2.4%) to 97.143% when pulling dcac99de05c24d0904c277ad087f2db913107647 on remove_bad_code into 9ba100fb45e907f224fccd2f4bc18e18a24ee0b2 on master.


feat: sync previous Part Instances

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature / bug fix (sort of)

What is the current behavior? (You can also link to an open issue here)

If there is a single Part A, and then the user adLibs PartInstances B and C, B and C can receive all of their timing through a displayTimingGroup. If Current Part Instance is B, an update to the expectedDuration of A will not be synced, because at this stage it's a "past" Part Instance and not considered for syncing Part Instances. As a result, it's impossible to change the countdown to the end of B and C.

What is the new behavior (if this is a feature change)?

If the current PartInstance is orphaned: adlib-part, the most "previous" Part/PartInstance in the current Segment is found and offered to the Blueprints for syncing.

Other information:

Status

[x] Code documentation for the relevant parts in the code have been added/updated by the PR author
[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

@jstarpl Is there a blueprints side to this, to sync just the duration? It doesnt feel like we should be syncing any piece changes in something that has completed playback

@jstarpl Is there a blueprints side to this, to sync just the duration? It doesnt feel like we should be syncing any piece changes in something that has completed playback

Yes, there is, and for some reason I forgot to create a PR for it.


Better key stats

It's hard to see the kWh totals for a selected range. Right now you can only see this data in the pie chart view, faintly. Add a totals section to the key stats tab, for the full dataset and the selected range.
Add a potential self sufficiency stat, to complement the actual as with variable FIT it's good to know

Fixed in V1.42


Regression: interface implementations are also queried in graphql backend.

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. The issue provides a reproduction available on
Github,
Stackblitz
or
CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
When requesting an interface:
query RequestInterface {
  products(filter: {}) {
    items {
      ... on ProductInterface {
        name
      }
    }
  }
}

It it is actually querying all implementations separately:
query RequestInterface($_v0_filter: ProductAttributeFilterInput, $_v1_pageSize: Int, $_v2_currentPage: Int) {
  __typename
  products(
    filter: $_v0_filter
    pageSize: $_v1_pageSize
    currentPage: $_v2_currentPage
  ) {
    items {
      ... on VirtualProduct {
        name
      }
      ... on SimpleProduct {
        name
      }
      ... on DownloadableProduct {
        name
      }
      ... on BundleProduct {
        name
      }
      ... on GroupedProduct {
        name
      }
      ... on ConfigurableProduct {
        name
      }
      ... on ProductInterface {
        name
        __typename
      }
      __typename
    }
  }
}

To Reproduce Steps to reproduce the behavior:
I had a hard time getting a proper sandbox to work, but if you deem this important I will give it another shot. But it seems to be happening with any Interface.

Expected behavior
I would expect the ProductInterface to be communicated and not the types.

Environment:

OS: any
@graphql-mesh/...: latest
NodeJS: 20

Additional context
We are using our GraphQL backend in combination with useGETForQueries: true and we noticed this issue because the backend reported that URL's were getting too long.

Narrowed it down to here: https://github.com/ardatan/graphql-tools/blob/master/packages/delegate/src/prepareGatewayDocument.ts#L54
This seems to be the commit that is causing the issue: https://github.com/ardatan/graphql-tools/commit/0134f7ffe5383603961d69337bfa5bceefb3ed74
In this case the interface is completely shared and the union isn't shared between the different interfaces
As a workaround for now we've opted to use an older version of @graphql-tools/delegate
  "resolutions": {
    "@graphql-tools/delegate": "10.0.10"
  }

This seems to be fixed, if I run into anything I'll create a new issue. Thanks a lot @ardatan! :)


CLOUD-50855 upscale cluster w/ blueprint request

@akanto or @bbihari

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1961/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1963/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1964/


(node:4412) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'map' of null (node:4412) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It just popped up when i was trying to run:
member = await msg.mentions.members.first();
if(!member){return msg.reply("You need to mention someone you plant!");}
myRole = msg.member.highestRole.position;
memberRole = member.highestRole.position;
botRole = msg.guild.member(bot.user).highestRole.position;
if(myRole <= memberRole){return msg.reply("Unable to ban as the mentioned user has a higher/equal role to you!");}
if(myRole <= botRole){return msg.reply("Unable to ban as the mentioned user has a higher/equal role to me!");}
member.ban();
msg.reply(I banned ${member.user.tag} from ${guild.name} with no problems!);
Can someone here solve this? Is a error on the code or on commando?
Extra pd: i copied this from a github with permissions.

Update to either the master or 11.2 branches, or set an owner.


[ServiceBus] enable beta-trimmed api-extractor dts rollup

in public-trimmed dts rollup, @beta APIs are removed. Because we only ship
public-trimmed version it prevents us from gathering feedback for @beta APIs.
This PR enable generation of beta-trimmed dts rollup.
We still need the piece in the publishing process to use the proper version
depending on whether we are releasing a beta/dev version or not.

@praveenkuttappan I am thinking that we could overwrite service-bus.d.ts with the beta version when publishing beta/dev versions. Something like below before pack
if (!GA) {
  read the two paths from api-extractor.json
  if ($betaTrimmedFilePath) {
    copy $betaTrimmedFilePath $publicTrimmedFilePath
  }
}

Is this possible? Or anyone has other suggestions?

@praveenkuttappan I am thinking that we could overwrite service-bus.d.ts with the beta version when publishing beta/dev versions. Something like below before pack
if (!GA) {
  read the two paths from api-extractor.json
  if ($betaTrimmedFilePath) {
    copy $betaTrimmedFilePath $publicTrimmedFilePath
  }
}

Is this possible? Or anyone has other suggestions?

This is interesting. I know Office (and rush itself) publishes special "plusbeta" versions of their packages that contain the beta surface area. Maybe after you collect feedback from EngSys and folks on the team we can schedule an arch board? I'd be curious for feedback from the architects on this one.
also /cc @bterlson

API change check for @azure/service-bus
API changes are not detected in this pull request for @azure/service-bus

I know Office (and rush itself) publishes special "plusbeta" versions of their packages that contain the beta surface area.

Yeah, I forgot to add the link to the doc https://api-extractor.com/pages/setup/configure_rollup/.  It's recommended either updating typing field (causing package.json code churn), or overwriting

This is interesting and I like it overall! There are other teams like Cosmos which need Beta api management and I think we can come up with general guidance using this approach.
Is our current structure alpha, beta and stable sufficient or do we need another class like Jeff mentioned?
I think there are some customers that are interested in trying out some Beta features but the rest of the library needs to be stable, here's where a new class of relases will be useful plusBeta (mostly new apis the rest mirros GA). While beta may contain changes that could make the library less stable.

Is our current structure alpha, beta and stable sufficient or do we need another class like Jeff mentioned?

Current we use alpha package versions for daily builds.  Nothing is related to API status. We use beta version numbers for preview.  We are not really using @beta doc tag currently.  The GA versions are stable releases.
If we are adding another class of preview version:

-beta for previewing features/APIs that are closed to GA (we could still make API changes)
-plusbeta for previewing a handful of APIs that are subject to change?

I am not sure whether we need the distinctions right now.
Another question is that the @beta APIs can still be used in JavaScript, even it's not exposed in the typing.  Do we consider them as public API surface or not?

I am thinking that we could overwrite service-bus.d.ts with the beta version when publishing beta/dev versions.

Thinking a bit more, now I feel that we should have the source code to be consistent (as much as we can) with the published package so updating package.json sounds better to me.

-plusbeta for previewing a handful of APIs that are subject to change?

-plusbeta is more for previewing service features that may be in Beta for a very long time.  Most api surface is stable, but a few APIs will be in beta status.

So for beta releases we want to use the beta-trimmed version.  For GA releases, if we want to surface @beta APIs, we would also need to use the beta-trimmed version.

API change check
API changes are not detected in this pull request.

I was talking to @KarishmaGhiya about this - I think one potential solution is to augment our release pipeline to do something like:

Create a GA package as normal
Update package version to include -beta (e.g. 2.3.1 becomes 2.3.1-beta), update typings to point to the beta trimmed version, then pack this as a second artifact
Publish both artifacts, making sure to publish the non-beta version first (so semver won't resolve to the beta version)

Does this sound workable?
/cc @mpodwysocki @bterlson

3. Publish both artifacts, making sure to publish the non-beta version first (so semver won't resolve to the beta version)

Will this address Cosmos team's desire of using beta api in GA packages?  I thought they wanted to ship the whole library as GA with some Beta features included.

Will this address Cosmos team's desire of using beta api in GA packages? I thought they wanted to ship the whole library as GA with some Beta features included.

Cosmos specifically might decide to not exclude beta from their GA packages rather than publishing a separate version, but I think that will be an exception for them rather than what we'd recommend as best practice.

I am merging this PR so we can release a package.  We should continue the discussion either here or in a new issue.


Bug: Update Steam Load and Gross Load labels

Actual Results
The field mappings labels needs to be fixed for steam load and gross load so that the data populates in the data preview on the custom data download and on a csv file downlaod.
In the Dev environment data is not populating for gross load and steam load

In the test environment data populates for gross load and steam load

FYI @tlageman-epa - the issue with gross load and steam load was accepted into this sprint.

https://epacamd.testquality.com defect D63.


Release flipt-client-python-v0.13.1

Release flipt-client-python-v0.13.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.57%. Comparing base (0054db6) to head (0713706).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   85.57%   85.57%
=======================================
  Files           7        7
  Lines        3911     3911
=======================================
  Hits         3347     3347
  Misses        564      564

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support listing devfile components in odo

/kind user-story
/area devfile
User Story
As a user, I want to be able to list the running devfile components on my system (Either Kube cluster or Docker) and see which devfile they belong to, using odo list.
Acceptance Criteria

[ ] odo list should be able to list all of the running devfile components in a given namespace
[ ] odo list should specify which devfile each component is part of (e.g. openLiberty, java-springboot, etc)
[ ] If running on an OpenShift cluster with both s2i and devfile components, it needs to support listing both

/kind user-story

[ ]  odo list should be able to list all of the running devfile components in a given namespace

Currently odo list filters the component based on the application (using app or app.kubernetes.io/part-of label).  Would we want to do the same?
Each component belongs to the application, and if you do odo list it lists components in the current application.

As for the possible state of the component, please refer https://github.com/openshift/odo/issues/2773#issuecomment-610922457.

IMO, for devfiles odo list should list components from cluster only in the current namespace, odo describe should describe component in the current context folder from cluster/local config both. Keeping odo list to list down components from cluster would keep it simple and easy to understand.

/priority high

Do we need to implement the —all flag and —path flag to support compatibility for vscode?
That would definitely increase the complexity and we need to consider a situation where there are components in path which are deployed on kube using devfile and s2i on openshift.

Not sure about the --path flag but the flag --all-apps  lists  List all components from all applications for the current set project.
The first question is do we want to have app concept for devfiles?

we dont have the app concept for devfiles, that is one thing we need to address as part of this PR as well. might be a good idea to add that as part of the AC.

we would be able to fetch all the components by going over all the deployments ( maybe using a label selector ) searching for component label https://github.com/openshift/odo/blob/master/pkg/devfile/adapters/kubernetes/component/adapter.go#L199, might also be a good idea to have managed-by label in place like we used to have for openshift components.
change the odo list output to have cluster type as an extra field which could for now have openshift, kubernetes and docker/local value? or have a different table to each of these types like we have for operator services and catalog services.

we would be able to fetch all the components by going over all the deployments ( maybe using a label selector ) searching for component label https://github.com/openshift/odo/blob/master/pkg/devfile/adapters/kubernetes/component/adapter.go#L199, might also be a good idea to have managed-by label in place like we used to have for openshift components.
change the odo list output to have cluster type as an extra field which could for now have openshift, kubernetes and docker/local value? or have a different table to each of these types like we have for operator services and catalog services.

IIUC from a single odo session, i guess it would be difficult to list down from different clusters, if you are thinking to list down locally then an additional field needs to be added locally.

so I hit an interesting road block on this issue. I realised that we would need to add the appName as a metadata on the devfile as this information is not environment specific and needs to be available to someone downloading the component from a repository.
But currently I cannot find a scenario where we are adding things to devfile.yaml locally. so just want to confirm that do we need to start doing that now @kadel @elsony .

so not to make this huge and to maintain compatibility to a certain degree. I will add the app in local env info instead of devfile.

Not having app name is something I'm hitting with operator hub integration as well. In the experimental mode, I can start a service from service catalog because we assume the default value for --app flag to be app if user doesn't provide any.
But if we want to list the services started from service catalog (in experimental mode), we can't do it from a devfile component directory because it doesn't have app value. And #3050 is not implemented yet.
I have similar question as @adisky - do we want to have app concept?
I see that there's an open issue #3050 about adding managed-by label. Does using that for app make sense even for devfile components? That's how we segregate resources of a particular app on the cluster right now, IIUC. That would make it cluster specific and we'll again have to resort to assuming default if user doesn't provide any - assuming because unlike .odo/config.yaml, a devfile doesn't store info about app. So, I go back to the same question - does app provide enough value to continue supporting it?

The biggest problem with removing —app concept will be breaking backward compatibility and to a certain degree asking vscode adapter team to rewrite many modules.

The biggest problem with removing —app concept will be breaking backward compatibility and to a certain degree asking vscode adapter team to rewrite many modules.

I agree with your point. But moving from s2i to devfile is going to introduce few changes that cause trouble to Adapters, no? Would it be helpful to at least have a discussion about this with them to understand how useful it is for end-users?

Removing application would require some changes but simplify many things on Adapters side. What we really need is odo supporting devfile component in: odo list, odo describe so we can show them in OpenShift Application Veiw and detect that workspace folder is odo component.
Currently adapters cannot work with devfile components because:

devfile components are not part of odo catalog list components -o json output (see https://github.com/openshift/odo/issues/3247) so user cannot pick it as a component type
devfile components are not reported in odo list
There is no way to detect that workspace folder has devfile component in it (odo list --path /location and odo describe does not work)

The 3rd point could be resolved by checking for an existence of devfile.yaml?

@girishramnani I don't want to relay on the insider knowledge, that would fail for example if you decide to support docker components and configuration is going to be in DOCKERFILE. The best way for IDEs to relay on odo command for component detection, this way we are stay away from implementation details.
I was thinking that odo describe would work but it does not.
So we kind of stuck right now. We can enable Experimental mode, but then Devfile components does not behave the same way as S2I ones. IMO both kinds of component fits perfectly to odo approach they should just be supported throughout all odo commands.

understood, I am nearly done with this, just need to write tests and we are good to go.


Support Replies Information Box

Possible to change the background as the text is hard to read and it doesn't fit in with the rest of the theme? Thanks
https://gyazo.com/8724e5fd1ad2f2c6b34f44099946d0a3
Or at least tell me how to do it myself.
Other then that, the best theme for free out there!

Is this a Commerce application?

Yes it is

I see. You can change this background by add this code into custom.css.
.cNexusSupportMessage_m .cNexusSupportMessage_author, .cNexusSupportMessage_a .cNexusSupportMessage_author {
    background: rgb( var(--theme-area_background) );
}


feat: add contributors section, Donate route and mobile menu

I've added some new features that were already created:

The donation form route has been added.
The contributors section has been added to the main page.
I made some alterations to the responsiveness, and it's not ideal yet, but much more fluid now.
A mobile header menu has been added.

That's all for now. Thank you!

@ramonbs would u like to be a collaborator in this repo for reactdev?
Let me know I will send u a invite link to this repo

@akshitagupta15june Yes, I would like, please!  Thank you so much!!

Ok I have added you as a collaborator please check your email


Add forward traffic to another HTTP proxy for the server (only for LocalProtocol::Tcp)

That help #324
Add this arguments to server CLI:
-p, --http-proxy <USER:PASS@HOST:PORT>
          If set, will use this http proxy to connect to the server [env: HTTP_PROXY=]
      --http-proxy-login <LOGIN>
          If set, will use this login to connect to the http proxy. Override the one from --http-proxy [env: WSTUNNEL_HTTP_PROXY_LOGIN=]
      --http-proxy-password <PASSWORD>
          If set, will use this password to connect to the http proxy. Override the one from --http-proxy [env: WSTUNNEL_HTTP_PROXY_PASSWORD=]

@erebe

Almost, just a few stuff to remove, but looks ok overall.

I have a question as I am not really sure of the answer.
What should be for you the behavior of the server if a proxy is configured but the requested traffic cannot use the proxy. (i.e: udp). Should it forward the traffic or return an error that it can't honor the proxy set ?

I have a question as I am not really sure of the answer.
What should be for you the behavior of the server if a proxy is configured but the requested traffic cannot use the proxy. (i.e: udp). Should it forward the traffic or return an error that it can't honor the proxy set ?

Should be an error, As for me when I use a proxy I want to use it to bypass something or act as I live in another country,  if anything happens to the proxy(can't handle the request for any reason) I want to lose the connection instead of expose my real IP

Alright, thank you for the PR :)
I am planning to make a release in the following weeks, I have some refactoring work I want to do before the next one. And also do some testing to make sure everything is right !

Alright, thank you for the PR :)
I am planning to make a release in the following weeks, I have some refactoring work I want to do before the next one. And also do some testing to make sure everything is right !

BTW new project file struct are much better, keep good work <3


[BUG] Incorrect info on account page

When switching from one account to another, the transaction list doesn't update.
Steps to reproduce

Open https://explorer.nearprotocol.com/accounts/near
Click on @corey to switch to that page
Observe that the top panel changed, but not the list of transactions

@ilblackdragon  It is not a bug but you should wait for several seconds for that change. I can add a loading icon for that. But it is still okay for now.

It is definitely a UX bug, so we should add a loader there


Docker and Quay improvements

#New quay repository
Docker updated structure and contents of containers: base and screw
Ref issue #14

Sounds good -- I like the idea of keeping the data images separate. I'm currently in the process of downloading the Farlik 2016 data, and it's enough of a headache that I'd rather
Can one use multiple Docker containers in one cwltool invocation, or do we need to combine them ourselves? (I guess it'd be OK to distribute, eg, a Farlik2016 + Screw container, along with an example workflow to use the Farlik data).


Logup trace generation

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#712
#711  👈
#710
#708
#707
#706
#705
#704
#702
#701
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 98.83721% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (890ee4c) to head (68f340e).

Files
Patch %
Lines

crates/prover/src/builder/logup.rs
98.76%
1 Missing :warning:

Additional details and impacted files
@@                            Coverage Diff                             @@
##           spapini/07-07-is_first_constant_column     #711      +/-   ##
==========================================================================
+ Coverage                                   89.46%   89.57%   +0.10%
==========================================================================
  Files                                          81       82       +1
  Lines                                       10151    10231      +80
  Branches                                    10151    10231      +80
==========================================================================
+ Hits                                         9082     9164      +82
+ Misses                                        990      988       -2
  Partials                                       79       79

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Apply Clang formatting

This changelist applies Clang formatting to source files in the MaterialX codebase, and includes no functional changes.

Do you know about .git-blame-ignore-revs?

@lgritz I'd heard about this feature, but I hadn't yet deeply considered its usage on MaterialX.  Perhaps it would make our changes more straightforward to track, by removing pure coding style changes from consideration?
For tracking down the history of individual lines in a codebase, I've found the native GitHub feature to be really good, and it allows you to trace the history backwards on a per-line basis:
https://github.com/AcademySoftwareFoundation/MaterialX/blame/main/source/MaterialXCore/Definition.cpp


Fixed TypeError in TcpHandle and sign_pythonrsa

See #86
In Python3, using str as the type of _buf causes TypeError: Can't convert 'bytes' object to str implicitly in the newest commit 0b15f4fc69c8b9ed87a82964fd6d2eed8d637f21 with python-rsa.
  File ".\adb.zip\__main__.py", line 210, in <module>
  File ".\adb.zip\__main__.py", line 206, in main
  File ".\adb.zip\adb\common_cli.py", line 149, in StartCli
  File ".\adb.zip\adb\adb_commands.py", line 138, in ConnectDevice
  File ".\adb.zip\adb\adb_commands.py", line 169, in _Connect
  File ".\adb.zip\adb\adb_protocol.py", line 320, in Connect
  File ".\adb.zip\adb\sign_pythonrsa.py", line 69, in Sign
  File "E:\Python\Python3\lib\site-packages\rsa\pkcs1.py", line 272, in sign
    hash = _hash(message, hash)
  File "E:\Python\Python3\lib\site-packages\rsa\pkcs1.py", line 346, in _hash
    hasher.update(message)
  File ".\adb.zip\adb\sign_pythonrsa.py", line 29, in update
TypeError: Can't convert 'bytes' object to str implicitly

And it can be fixed below:
   # hashing algo for this.
   class _Accum(object):
     def __init__(self):
 -     self._buf = ''
 +     self._buf = b''
     def update(self, msg):
       self._buf += msg
     def digest(self):
       return self._buf

And thanks to @Myonium, the TypeError in TcpHandle can also be resolved.
@fahhem I don't know why this PR cannot be accepted. If you guys don't want to merge this branch, just close it.

Coverage remained the same at 42.691% when pulling 9a0a928cf532314ce7a6766def946db4c2d7d0d1 on YSunLIN:master into 0b15f4fc69c8b9ed87a82964fd6d2eed8d637f21 on google:master.

Coverage remained the same at 42.691% when pulling 9a0a928cf532314ce7a6766def946db4c2d7d0d1 on YSunLIN:master into 0b15f4fc69c8b9ed87a82964fd6d2eed8d637f21 on google:master.

Hmm, this seems to cause problems with the USB handle. It seems the TCPHandle needs to convert to bytes in the right place, because the signing libraries should only see binary data, not unicode.

@fahhem I opened the issue #86 and then made a pull request #89 to fix the problem.
I also merged the @Myonium's TcpHandle solution with which you agreed.
However, you merged #97 and ignored this PR until now.
I don't know if it is discrimination or not.

Thanks for your prompt reply. And I will continue to contribute to this repo.

Thanks!


[camera] Update iOS platform target

Description
Since the camera package uses the AVCaptureDeviceDiscoverySession class, the minimum iOS SDK must be 10.0 (https://developer.apple.com/documentation/avfoundation/avcapturedevicediscoverysession)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide). Not relevant
[x] All existing and new tests are passing.  Not relevant
[x] I updated/added relevant documentation (doc comments with ///).  Not relevant
[x] The analyzer (flutter analyze) does not report any problems on my PR.  Not relevant
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

What's wrong with the checks?

@devtronic It looks like the iOS tests are failing because the camera example app is supporting versions 8.0+ and this changes the minimum version to 10.0.
I don't think we want to go with this change because there could be a scenario where someone wants to compile for iOS 8.0+, but provides the camera feature only for devices that are 10.0+.
We may want to go with another solution like updating the README of the 10.0+ requirements.

Closing in favour of #3335


Typescript: Import suggestions in same line when index.ts is present

VSCode Version: 1.18.1
OS Version: Windows 10

Steps to Reproduce:

Create project directory (e.g. models)
Create some classes in that folder
Create index.ts that exports those classes
Try to import those classes from other class by starting typing name of that type and then hit suggested name in the intellisense menu and hit enter

Expected result:
import { MyClass } from 'app/models';
Actual result:
import { MyClass } from 'app/models/myclass.ts';
This is really annoying when you have multiple classes in same folder and exported using index.ts
instead of having added them to single import (e.g import { MyClassFirstm MyClassSecond } from 'app/models';)  and imports each in separate line:
import { MyClassFirst } from 'app/models/myclass-first.ts';
import { MyClassSecond } from 'app/models/myclass-second.ts';
structure of index.ts
export { MyClassFirst  } from './myclass-first.ts';
export { MyClassSecond} from './myclass-second.ts';

Reproduces without extensions: Yes

I believe this is a duplicate of https://github.com/Microsoft/TypeScript/issues/19694
Please try using typescript@next by following these instructions


Getting Error: Uncaught Error: fetch-mock: No fallback response defined for GET for localhost call

We make calls to get test deep zoom image data from localhost.  When we do we get the error " Uncaught Error: fetch-mock: No fallback response defined for GET". We don't want to set fallbackToNetwork to true.  fetchMock should not throw this error if the request is for local assets.
code example:
fetch('/test/image.dzi', { credentials: 'include' })         .then(handleResponse(data));

I'm sorry, you'll need to provide more details as this code sample doesn't give a full enough picture of what your code does. Please read the issue template

Closing due to inactivity

Hi,
I have got the same issue,
when i tried to mock the fetch api call, I have got an error
fetch-mock: No fallback response defined for GET to api call
my code is given below
it("should dispatch correct actions when exporting reports", () => {
	const middlewares = [thunk];
	const mockStore = configureMockStore(middlewares);

	fetchMock.get(
		"/todos",
		{ hello: "world" },
		{
			delay: 1000, // fake a slow network
			headers: {
				user: "me" // only match requests with certain headers
			}
		}
	);

	const expectedActions = [{ type: ANALYSIS.EXPORT_SUMMARY_REPORT }];
	const store = mockStore({ todos: [] });

	return store
		.dispatch(exportSummaryReport("d5d09628-ab8f-44fb-95c6-fce734b29fe8", "08d7561e-a6b6-388f-3796-6aaccc4026b3"))
		.then(() => {
			// return of async actions
			expect(store.getActions()).toEqual(expectedActions);
		});
});

What extra details do you need to look at this issue?


Install failed - corrupted package.json in dependency

Probably nothing but...
apm tried to install es6-symbols but the 2.0 versions package.json was corrupt (the first 16 bytes were wrong) so it failed. I assume downloads happen over TCP/IP and should therefore be immune to corruption in transit and, after deleting /home/user/.atom/.apm/es6-symbol/2.0.1 I reinstalled it and it worked fine so I assume the corruption must have happened my side. No idea if it's atom code, some 3rd party code or my os/hardware at fault - hopefully it's just a one-off - but I thought I'd mention just in case other people are seeing the same error.
Error message below...
$ apm install symbol-gen
Installing symbol-gen to /home/user/.atom/packages ✗
npm ERR! Linux 4.4.0-22-generic
npm ERR! argv "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/user/.atom/.apm/.apmrc" "--userconfig" "/home/user/.atom/.apmrc" "install" "/tmp/d-116420-18658-7pfgk2/package.tgz" "--target=0.36.8" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! file /home/user/.atom/.apm/es6-symbol/2.0.1/package/package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! Unexpected token '\u0000' at 1:1
npm ERR! bol","version":"2.0.1","description":"ECMAScript6 Symbol polyfi
npm ERR! ^
npm ERR! File: /home/user/.atom/.apm/es6-symbol/2.0.1/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.

BTW: just looked and the first 16 bytes of the corrupt file were all zero

Odd.  Must be a fluke b/c I'm able to run apm install symbol-gen without issue.


Feature Request: Housing is shown as a difference in the city banner

Can the housing number be a difference between the used and the available housing. Like 3 / 4 is shown as -1 (in Green) and 5 / 3 (in Red) is shown as  +2. We do the math anyways in our heads, and the number we really care for is whether the housing is at its limit or not.

I plan on looking into this once #280 is pulled (or rejected). Is this the correct limits?:

Anything over limit
** Color: Red
** Number: -1, -2 etc
On limit
** Color: Orange
** Number: 0
Approaching limit (Is it always 1 from max?)
** Color: Yellow
** Number: +1
Under limit
** Color: Green
** Number: +2, +3 etc

I believe this is how it works:
0 growth
Color: Red
Number: <= -5
-75% growth
Color: Orange
Number: -4 >= and >= 0
-50% growth
Color: Yellow
Number: == +1
Full growth
Color: Green
Number: >= +2

@Nutzzz This seems like it would be correct. Will use this if no one else have other information about it.

As for me I don't like to see the result of this issue. When I see +2 for example I can't see if it's 1/3 or 2/4. The difference between 1/3 and 2/4 that when we have 2/4 we can start creating one more district so I think it's important to see it faster. And I don't think that someone really does the math when he sees housing as 2/4 or 2/11. What the difference? The main thing is to know if the city can grow up or not. So for me it would be more useful to see it like it was before :) And four types of colores as it's already done solve this issue enough I think.


[Bug]: DropDown / Select goes outside the view

Environment
Developement/Production OS: Windows 10 19043.1110
Node version: 16.0.0
Package manager<EMAIL_ADDRESS>Radix Vue version: 1.0.0
Shadcn Vue version: 1.0.0
Vue version: 3.0.0
Nuxt version: 3.0.0
Nuxt mode: universal
Nuxt target: server
CSS framework<EMAIL_ADDRESS>Client OS: Windows 10 19043.1110
Browser: Chrome 90.0.4430.212

Link to minimal reproduction
none
Steps to reproduce
When the list is too long, the list goes outside the view, and it's not possible to scroll
Describe the bug

Expected behavior
The view should stop at the border of the screen (either top, if the items are shown above the Dropdown / Select, or bottom if shown below) and it should be scrollable
Conext & Screenshots (if applicable)
No response

@zernonia if you have some tips on how I could do a small patch to fix it for now until you have time to make a clean edit I'd love to see it (I'm trying to use this for something in prod haha)

I think you can add max-height to DropdownMenuContent.vue as see? 😁

yes but I'm not sure that's sufficient: if the screen is small and the dropdown goes "outside the view" but the max-height is bigger than the available space, it is still not going to scroll... not sure if javascript is needed?

Like doing something with this value? https://github.com/radix-vue/radix-vue/blob/main/packages/radix-vue/src/Select/SelectItemAlignedPosition.vue#L108

I think that this is successfully closed in #264 🙂