Prepares Jedis redis checkpoint store for release

Description

Bumps jedis to latest version 4.3.1
Adds javadoc and samples
Adds tests
Updates README
Adds CHANGELOG

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-messaging-eventhubs-checkpointstore-jedis

/azp run java - eventhubs - ci

@saragluna Hey, I was wondering if I could merge this in? Or if I need to do something because it'll break you.

Hi @conniey, I looked at the release notes of Jedis 4.0.0, and I think if we are not using any new API defined in 4.x then we are okay.
Spring Boot 2.7.7 ships with Jedis version 3.8.0, and Spring Boot 3.0.1 ships with Jedis version 4.3.1. So if we can test that this Redis checkpoint store is compatible with Spring Boot 2.7.7 or Jedis 3.8.0 then I think we are ok to go. Otherwise we should mention it in the doc.

We don't use any of the new/removed classes/features from 4.x.x... so I don't think this will be a problem.

Thanks for getting this merged @conniey!


hardcoded to create war in production mode. Grails offers command line params for different environments. Would be nice to have user specified opt for instances used as test/staging

Problem is in compile:
COMPILECMD="grails -Divy.default.ivy.user.dir=$CACHE_DIR compile --non-interactive"
echo "-----> Executing $COMPILECMD"
eval "$COMPILECMD" | sed -u 's/^/       /'
check_build_status
BUILDCMD="grails $BUILDCMD_OPT -Divy.default.ivy.user.dir=$CACHE_DIR war --non-interactive"
echo "-----> Executing $BUILDCMD"
eval "$BUILDCMD" | sed -u 's/^/       /'
check_build_status
Documentation on grails war is here http://grails.org/doc/latest/guide/conf.html#environments
Ideally $BUILDCMD_OPT could take on more values than --plain-output. This would require the build pack to either be able to take in parameters or work with the grails community (perhaps with Bert Beckwith's heroku plugin) to determine a convention based location where such parameters could be stored in the application source itself, that the script could read from.

fixed by #39


Refactor logic task

Purpose of the pull request
Background
DolphinScheduler is composed by APIServer/Master/Worker/AlertServer. Master is used to bootstrap a workflow, and worker is used to execute task.
Right now, we have two kinds of task in DS:

WorkerTask: Shell, Spark, Sql......
LogicTask: Condition, Switch, Dependent......

The logic task will be executed in Master, this is due to the logic task will dependent DS's metadata database, and we don't want the worker rely on db, so these logic task will be executed at Master.
The current problem is the logic task's trigger process is different with worker task, this led below issue:

The workflow's execution process is very complex, these cause a lot of bug, mainly in logic task.
It's hard to add a new logic task plugin, since we need to consider how to trigger the logic and how to finished it.
The logic task SPI is different with worker task.
Task instance log is hard to maintain.
The logic task execute process will affect other workflow instance, since it use workflow's thread pool.
......

So, we need to unify these two kinds task's execution process.
This PR will refactor the logic task execution in master.
Detail
WofkflowExecuteRunnable VS TaskExecuteRunnable
WorkflowExecuteRunnable is represent a running workflow instance, it will contain TaskExecuteRunnable, one TaskExecuteRunnable represent a running task instance.
All task in the WorkflowExecuteRunnable is as TaskExecuteRunnable, workflow instance only need to maintain the TaskExecuteRunnable, and call TaskExecuteRunnable's api to control task instance.

TaskExecuteRunnabel contain some TaskOperator, TaskOperator is use to operate task instance. Each task operation is corresponding to a TaskOperator, e.g TaskDispatchOperator is used dispatch task instance. TaskKillOperator is used to kill task instance....

TaskOperator
TaskOperator will do actual operation.

For example, TaskDispatchOperator is used to dispatch task instance, it will send the task instance to a TaskDispatchWaitingQueue, and a looper thread will loop this queue and dispatch the task instance.
If the task instance need to execute at worker, dispatcher will select a worker host to dispatch, if the task instance is a logic task, dispatcher will dispatch these task to itself.
LogicTaskExecuteThreadPool
The LogicTask will use a isolated threadpool to execute the task.
And when master receive a LogicTask dispatch request, the process is same with worker, it will create a MasterTaskExecuteRunnable to represent the physical task, and submit it to MasterTaskExecuteRunnableThreadPool.

After the LogicTask execute finished, it will send the result to the master like worker task.
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13948 (3428da0) into dev (53bcf11) will decrease coverage by 1.02%.
The diff coverage is 1.96%.

:exclamation: Current head 3428da0 differs from pull request most recent head 0bebe07. Consider uploading reports for the commit 0bebe07 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13948      +/-   ##
============================================
- Coverage     38.92%   37.91%   -1.02%
+ Complexity     4471     4401      -70
============================================
  Files          1164     1222      +58
  Lines         42444    42814     +370
  Branches       4761     4719      -42
============================================
- Hits          16520    16231     -289
- Misses        24104    24785     +681
+ Partials       1820     1798      -22

Impacted Files
Coverage Δ

...r/api/service/impl/WorkFlowLineageServiceImpl.java
29.28% <0.00%> (-0.22%)
:arrow_down:

...e/dolphinscheduler/common/constants/Constants.java
75.00% <ø> (ø)

...pache/dolphinscheduler/common/utils/DateUtils.java
66.84% <0.00%> (-2.01%)
:arrow_down:

.../dao/repository/impl/ProcessDefinitionDaoImpl.java
3.12% <0.00%> (-0.33%)
:arrow_down:

...er/dao/repository/impl/ProcessInstanceDaoImpl.java
6.25% <0.00%> (-1.75%)
:arrow_down:

...ler/dao/repository/impl/TaskDefinitionDaoImpl.java
8.00% <0.00%> (-1.10%)
:arrow_down:

...duler/dao/repository/impl/TaskInstanceDaoImpl.java
3.03% <0.00%> (+0.13%)
:arrow_up:

...e/dolphinscheduler/server/master/MasterServer.java
0.00% <ø> (ø)

...inscheduler/server/master/config/MasterConfig.java
1.88% <ø> (ø)

...ler/server/master/dispatch/ExecutorDispatcher.java
0.00% <0.00%> (ø)

... and 119 more

... and 26 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I merged this pr, and add UT, e2e case in next pr.


Project command updated and ProjectService Added

Hey,
Made some changes to the Project Command and added a ProjectService
First commit:
?project  without any query now returns any random project.
?project #react, tags with # infront now also work as query.
Second Commit
Extracted all Project code to a ProjectService so the project command only has to take care of making it look nice and so it fits better with the rest of the codebase.
ProjectService has 3 methods:

formatTags
getProjectByTags
getDifficulty

Todo:

Figure out how to mock the projects json file so I can write more tests for the ProjectService

Closing due to inactivity.


TypeError: Object # has no method 'uncork'

We're currently seeing this error in a production server:
TypeError: Object #<Socket> has no method 'uncork'
    at Multi.exec_transaction (/opt/oae/node_modules/redis/index.js:1105:25)
    ...

The invocation that leads to this enters the Redis module here.
Our RedisClient initialization logic happens here.
Node 0.10.17
node_redis: 2.2.5
Please let me know if there's more I can do to help!

Using Node 0.12.x would solve the issue for now. I'll have a closer look at it later on why the fallback mode does not work properly in your case. I guess I already know why it's not working for you and if that's the case I'll release 2.2.6 later on today.

Thanks @BridgeAR , much appreciated!

@mrvisser I'm sorry I did not find the time to fix it today.

@BridgeAR no worries. If you like, I can diagnose and try and get a PR in. If you could share what your hunch is on the issue then that might help. Let me know.

@mrvisser I had another look at it and I can't reproduce the issue on 0.10.27 but I guess the stream module might somehow got altered by something else. Nevertheless I changed and improved the way how the fallback mode works and that should also fix your issue.
I got the fix local and I'm going to push that and some other things later on today. It would be great if you could test the fix before releasing a new version :)

Thanks, I'll try and reproduce today with a unit test as part of our issue that references this one and verify it resolves it.
Cheers!

@mrvisser would you be so kind and give my fix a try?

@BridgeAR today I've tried to write a unit test in my application that reproduces this issue, however I can't seem to trigger it. I've tried restricting bandwidth and increasing the size of the multi commands to produce back-pressure, but it doesn't seem to trigger the issue.
I think I'll just have to upgrade the client version and deploy it, which would have to be a bit later this week. I'll get back when we've done this.

@mrvisser the issue occurs after a connection loss. It is indeed a bug and I fixed it in #901

@BridgeAR I've pulled your "stuff" branch into my local instance and run the unit tests and can confirm there aren't any regressions in that branch. If released to npm, we'd be happy to give a 2.2.6 a try.

A release for this would be great. We're seeing a lot of these errors too.


ACM-4386 Security Vulnerabilities

This PR is for suppressing the false positive hard-coded credentials issue.
Addresses:

https://issues.redhat.com/browse/ACM-4386

/cc @xiangjingli

/lgtm


[18.09] Steam update

Motivation for this change
Backported steam fix for 18.09
cc @Infinisil
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

(backport of https://github.com/NixOS/nixpkgs/pull/49095)


Update kafka to 1.17.1

Updates org.testcontainers:kafka from 1.16.3 to 1.17.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.testcontainers", artifactId = "kafka" } ]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Closed in favor of https://github.com/aiven/guardian-for-apache-kafka/pull/205


Importing model face triangulation error

Here is the error description taken from the SDK.

Errors occured during face triangulation: Unable to find two closest vertices while triangulating face in mesh: TemporalMesh [name=Default, vertices.size()=201]Please apply triangulation modifier in blender as a workaround and load again!. The face will be triangulated with the most direct algorithm, but the results might not be identical to blender.
The texture Kd has linear color space, but the material parameter DiffuseMap specifies no color space requirement, this may lead to unexpected behavior.
Check if the image was not set to another material parameter with a linear color space, or that you did not set the ColorSpace to Linear using texture.getImage.setColorSpace().

I used the same models in JME 3.0 with no problems.  I even loaded them into blender 2.76 then tried importing with the same result.

@jmekaelthas  is this fixed by jMonkeyEngine/jmonkeyengine@48b3f1a ?
If not it would be nice if you could upload said model @jojoofu
Also this usually rather fits into the main repository.

Okay here is the file. Feel free to move this thread as I'm not to sure where to place them.
mesh_oldhut.zip

This issue seems to be resolved by using 3.1 alpha 4.

Well I'm waiting for Kaelthas' Reply and then Close the Issue.
I don't know if there was a triangulation change between ~alpha2-alpha4 but when it works now, we're all happy :)

Hi,
I have loaded the model and it looked OK. But I have seen some triangulation problems in the log. Fortunately such errors during triangulation are caught and then the most simple triangulation algorithm is applied. Thanks to this most of the models will look fine even if there are some problems.
Because I am working on a new feature for blender importer at the moment, which forced me to improve triangulation algorithm, I think we can close this issue:)
I will check the model while I am done and I hope even the warnings will vanish.

I'm seeing a similar issue in 3.1beta2 (with a different Blender model). Log messages like so:
Loading animations that will be later applied to scene features.
Loading model's textures.
Loading model's textures.
Errors occured during face triangulation: Unable to find two closest vertices while triangulating face in mesh: TemporalMesh [name=arcade, vertices.size()=32]Please apply triangulation modifier in blender as a workaround and load again!. The face will be triangulated with the most direct algorithm, but the results might not be identical to blender.
Did the improved triangulation algorithm ever get implemented? Should I just ignore these warnings?

Not sure, but what happens if you actually do the triangulation in blender? does the error persist anyway then?

Good question. After I used Blender to triangulate all the mesh faces, the warning disappeared. So I guess there's a workaround for now.


Sleeping Minecraft server shows as offline to players.

Bug Report
System Information

Operating System: Ubuntu 20.04
AMP version and build date AMP Release "Europa" - v<IP_ADDRESS>, built 03/09/2020 11:37
Which AMP release stream you're using: Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
A minecraft server that is asleep will show as offline to a client attempting to connect
I expect it to show as available, but it just shows a red X
Reproduction

create new instance
create minecraft vanilla server using v1.16.2 (or any older release, tested back to 1.12)
start the server (accept eula)
from the console, click sleep
in the MC client, add the new server by IP, save the server, refresh the view.
server will show red X
try to connect to the server, will get message "server starting please reconnect"
wait a few seconds and refresh, server will show online.

This has been addressed in the latest update.

I've got this working again, the catch is that AMP has to omit the favicon data. So the client may display the 'default' image rather than your servers usual favicon.


PropertyState can be created for parameterized types without casting

Provider properties should be usable with parameterized types.
One simple example that comes to mind are collections.
Expected Behavior
PropertyState<List<String>> listState = project.property(new TypeOf<List<String>>() {})

Or some nicer way to declare generic type info by enhancing TypeOf with e.g. factory methods.
Current Behavior
One can create PropertyState<List<String>> but has to rely on casting:
PropertyState<List<String>> listState = (PropertyState<List<String>>) (Object) project.property(List.class)

Do you need this for something other than collections? There are factory methods to create properties with List<T> and Set<T> values.

The collection cases were solved by ListProperty and SetProperty. However any other generic type (mainly custom types) require a cast as the ObjectFactory property doesn't account for generic type. A solution is needed.


[mdns] replace the source of mDNSResponder

Fetch mDNSResponder's source code from https://github.com/apple-oss-distributions/mDNSResponder.
Fixes https://github.com/openthread/ot-br-posix/issues/1591.

I was just going to complain that an additional mDNSResponder- is part of the unpacked name. I see you have addressed this, I'll test this on my end.


🚀 Announcements: Tracking or stats of announcements

Plugin Name
announcements
🔖 Feature description
Possibility of being able to view how many times the announcement was viewed
If possible, able to see a percentage of active users who haven't/have read the announcement, as it is easy to click the X to close the banner vs clicking on the announcement to view the details
🎤 Context
Originally posted here: https://github.com/procore-oss/backstage-plugin-announcements/issues/418 (has a possible solution commented as well)
We have started using this feature to broadcast when we have released updates and when we will be in maintenance mode. We would like to see if the news is being viewed as we now have a way of stating to the user that we have communicated this on the platform alongside our other forms of communications
Good stat to keep track of how valuable the data is being presented to the user. Able to point out how news is received within the deployed environment
Able to keep track of how often announcements are read, leading to users being kept aware of changes/releases within the environment
✌ Possible Implementation
If using a database, maybe adding a view count table or column for each announcement.
If able to, similar to how Backstage Insights keeps track of how often a template was run, could use a similar method to keep track
Unsure if this would result in duplicate views if 1 users repeatedly views 1 announcement
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

@skeletonz28 - thinking through this some more. Should this be handled by some telemetry layer rather than a column in the database?


can you or anyone upload all the dependence (folly, thpp fbthrift fblualib)zip file ?

can you or anyone upload all the dependence (folly, thpp fbthrift fblualib)zip file ?
There are lots of version of the above package which may conflict with each others?
So anyone who has complied successfully, can upload the zip file ?

anyone ??

I have found, you should't use ubuntu16, but ubuntu14 can compile.
Or use ubuntu16 with docker(install ubuntu14 env)

thank u

Oh. May I ask can i install ubuntu14 env on a serve running 16.04?


Pageextension trigger OnAfterGetCurrRecord not fired

Describe the bug
It seems that the OnAfterGetCurrRecord trigger in a pageextension only fires when there is code in C/AL. However, when you set a breakpoint on the code in this trigger, then the debugger stops at the breakpoint. After that, the trigger works like expected, until you publish the extension again or the server is restarted.
A similar issue was reported earlier: https://github.com/Microsoft/AL/issues/1383
To Reproduce
Steps and to reproduce the behavior:
Create a pageextension for a page that has no code in the OnAfterGetCurrRecord trigger, e.g. for Page 15 Location List.
Add a trigger OnAfterGetCurrRecord to the pageextension and add some code to it, a message will do the job.
Publish and run the extension, the code will not be executed.
Set a breakpoint on the code and publish again. The debugger will now stop at the code. Stop the debugger and the code will now continue to run.
AL Code to reproduce the issue
pageextension 50101 LocationListExt extends "Location List"
{
    trigger OnAfterGetCurrRecord()
    begin
        Message('Hello from OnAfterGetCurrRecord');
    end;
}

Expected behavior
The OnAfterGetCurrRecord trigger in a pageextension should always execute, regardless of C/AL code in the base object.
Versions:

AL Language: 3.0.118998
Business Central: Platform 14.0.31606.0 + Application 31632 (W1 14.1)

Any update on this? This is blocking some functionalities at the moment

Hi @Frederig I forwarded the issue to the right team, no updates yet.

Will this be in CU2 of the April 2019 release? It is not working in CU1

Still not working on 14.1.33107.0... When can we expect this?

Can you provide any deadline when this issue will be fixed?


How can i setup notifications for my mail and slack using this package.

Hi Sarfaraz,
I have used this package for my application. and it works like charm. Now I want to include notifications for mail and slack. How can I achieve that?
Regards
Rameez Makhdoomi

Added ability to get notified via email. You should update package and then use these config options:
    'mail' => [
        /*
         * Define mail subject and who should receive mails when backup is taken/restored.
         * Leave "mail_receivers" empty [] to not send any mail.
         */
        'mail_subject' => 'BackupManager Alert',
        'mail_receivers' =><EMAIL_ADDRESS>    ],


[staging/production] Input placeholders don't work in IE9

Steps

Go to http://osf.io in IE9 while not logged in

Expected

Registration form includes placeholders

Actual

Registration form doesn't have placeholders, making it pretty hard to register

This is happening because IE <=9 doesn't support html5 input placeholders. To fix, we could conditionally show input labels in old browsers, or use a placeholder shim like https://github.com/mathiasbynens/jquery-placeholder.

@jmcarp is showing input labels a really quick fix?

We do have users on IE9 -- so this should be fixed .... @jmcarp @GaryKriebel make it a HotFix post 0.23.0 release?

If it is a really quick fix, I would even consider pushing it into 0.23.

@GaryKriebel adding labels (just in IE9) would be quick. The page would look different in IE( compared to modern browsers, but that seems tolerable.

I would think it would be tolerable as well.

@sloria @Ghalko has the fix gone live and thus closing this issue?


Error in offset/style example

Hi @sharonlo101, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sharon Lo). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@sharonlo101 : Thanks for your contribution to the Azure documentation! The author, @sharonlo101, has been notified to review your proposed change.

@sharonlo101 : Thanks for your contribution to the Azure documentation! The author, @sharonlo101, has been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It�s easy to access the private repo version of your articles in GitHub. Just add �pr to the URL, as follows:
Public repo URL: https://github.com/Azure/azure-content/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Azure/azure-content-pr/blob/master/articles/azure-portal-overview.md
We've closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions.

#sign-off


fix!: remove 'Http' from W3C propagator names

Which problem is this PR solving?
Fixes #2428
Short description of the changes
Renames:

HttpTraceContextPropagator to W3CTraceContextPropagator
HttpBaggagePropagator to W3CBaggagePropagator

This is a breaking change
Fix in the contrib repo: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/644. I didn't find any places that need updating in opentelemetrry-js-api or opentelemetry.io repos.

@vmarchaud thanks, I updated the README


feature-request product config - don't export default settings

om product-config and director-config options export every single option.
It would be better to have an extra param with the om tool to not export the setting if it is already a default setting.
Default settings shouldn't need to be set.  It would just make the configs that platform-automation uses so much smaller.

@drduker  what problem are you trying to solve with this feature request? We've found with interactions with customers that they do want to have all values set in their foundations when they pull down the configs.
We also don't have a way of telling if a value is a default value from the Ops Manager API. We can see that a value is set, but in a tile, Ops Manager treats the "default" like any normal value.

Apologies for the minor hijack, just wanted to comment w/ some thoughts:

it reduces the clutter in the amount of configuration code that needs to be stored off; if, you're only storing off the deltas from how you diverge from defaults, it reduces noise / cognitive overhead when making changes in your yml config.
it allows for a tile maintainer to publish a new version of their product with new reasonable defaults, and the stored configuration wouldn't be out of date. It allows for "floating" config values.

of course if opsmgr doesn't have a way of indicating a default value it's not possible, though I could definitely see the value in only exporting config deltas. Again my bad for hijack @drduker just voicing some thoughts

@drduker @aegershman
Thinking back on this issue, can you help us out by proposing an interface on what this would look like for staged-config and staged-director-config? If you could give us a concrete example of what a desired config would look like? We are limited by what the Ops Manager API returns, and from a cursory glance, it doesn't appear that the endpoints used by staged-config and staged-director-config have any knowledge of what is a default and what is required but not defaulted.
Let's talk through the problem space, and see if we can develop a solution based on the resources available.

@drduker @aegershman
Can you give us a little more information on this issue? We'd love to address it, but need a couple questions answered first.

/cc @kcboyle
Hm right it appears you'd need to need some way to do a diff against what's supplied as default in a tile & what's "overridden" (configured) by a user. The only way to get those defaults is to look at the *.pivotal tile itself... I wonder if this is something which could be done in the tile-config-generator?
But ehhh, bleh, meh, honestly I think we can just close this, it's not a priority to me at the moment 👍  unless drduker has any commentary or concerns, otherwise my vote is close this 😉

Great call on tile-config-generator @aegershman!
We actually just released a change to config-template (experimental) that is a limited feature set from tile-config-generator. The biggest change from TCG is that it will pull down the config from Pivnet every time (though not from an existing Ops Manager). The Pivotal Platform Automation team is also writing documentation for using/setting up this command, but it is currently unreleased, and not yet publicly available (Link is there for future benefit).
config-template will actually separate out the default vars from your standard config template (all values are ((parameterized)) in the base template. To find the params that are missing, you can take the base.yml, give the produced vars that config template just gives you, and you will be able to see what's left using om interpolate
Does this sound like something that could fit your use case @drduker

@kcboyle - That sounds promising.  As long as we have a way to easily separate the values and make the configs as simple as they can be then I'm satisfied.  Not actually working pcf pipelines atm though.  You can close as far as I'm concerned.


Prompt to Download Immediately After Key Generation

Adds a prompt to download the key with a disclaimer that cancelling it is at the user's own risk.
The prompt means that a user is given an opportunity to back up at the point of creation and then is forced to backup at the point of deletion (although they can close the file explorer as described in the PR for that work).

Asset
Signer v1.4.5

I think there's an argument to be made to not allow account creation without saving the secret key. Currently pressing "Cancel" does nothing.
Also, while we're refactoring this, should we have the post-account-creation download be limited to JUST the secret key? The 3 files are confusing people.

"If you choose not to, it is at your own risk and you may loose access to your funds in the future" - to make it as explicit as possible

updated UI:

@mssteuer I've changed it so that they have to download the key to finish creating the account. With a small caveat that if the user closes the Signer before responding, the key will be stored in the Signer without it being backed up. Keys that haven't been backed up must be downloaded before they can be deleted.
I've also changed it so that downloading key~s~ only saves the secret_key

updated UI:
@mssteuer I've changed it so that they have to download the key to finish creating the account. With a small caveat that if the user closes the Signer before responding, the key will be stored in the Signer without it being backed up. Keys that haven't been backed up must be downloaded before they can be deleted.
I've also changed it so that downloading key~s~ only saves the secret_key

@George-cl awesome! I think that's a huge improvement! Final thoughts on the dialog text, which I think is still too "tech-y". My suggestion would be:
Caption: Download your key
Body: Before proceeding, download and securely save your secret key. Without it, you will not be able to recover access to your account.
I'm somewhat on the fence on the utility of the "Cancel" button, but I suppose it's best practice to have one, even though in this case it cancels you out of multiple steps (the previous screen being the "Create Account" screen presumably). Perhaps instead of "Cancel" and taking you home, should it be "Back" and take you to the "Create Account" screen? I could be convinced either way ;)

downloading key and re-importing the key gives as in screenshot with hardstop, this happens with a new and existing signe

r


Update team communication page re: IM

See https://trello.com/c/RoSbF1W0/450-document-gitter-irc-slack
This updates https://www.openmicroscopy.org/site/support/contributing-staging/team-communication.html to replace Jabber with Slack for everyday team communication and also mention that we don't provide support via IM (IRC or Gitter) although some team members do use IRC.
(N.B. I took the IRC info from the Slack bridge, if someone who uses it wants to clarify re: used channels, please comment)

Better now @joshmoore ?

Better now @joshmoore ?

Yes, thanks. (but is Openmicroscopy a new spelling? :smile:)

Got around the whole casing and URL vs name issue by just correcting to OME - okay to merge now @joshmoore ?

:+1:


update actions versions

Codecov Report
Base: 30.04% // Head: 30.04% // No change to project coverage :thumbsup:

Coverage data is based on head (2ccb176) compared to base (82dd540).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   30.04%   30.04%
=======================================
  Files           5        5
  Lines         213      213
=======================================
  Hits           64       64
  Misses        149      149

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Header for Desktop Device

Description:
The desktop version of the header should include the company logo, a navigation menu, and a list of links to the company’s social media profiles.
Requirements:

Logo:

Place the company logo in the header, positioned on the left side.

Navigation Menu:

Implement the navigation menu to the right of the logo, displaying the main sections of the website (e.g., "Home," "About," "Best
pumpkins").
Ensure the navigation menu is fully responsive and accessible on larger screens.

Social Media Links:

The social media links should be implemented as a list (<ul>) where each item contains an <a> tag.
Each link should open the corresponding social media platform in a new tab.
Use SVG format for the social media icons, ensuring they are visually appealing and consistent in size and style.
Position the social media icons on the middles of the header, aligned with the navigation menu.

Additional Considerations:

Ensure the header is fixed at the top of the page on scroll (sticky header).
The design should be clean, with sufficient spacing between the logo, navigation menu, and social media links for an uncluttered
look.
Test the header across multiple desktop resolutions to ensure proper responsiveness and layout.

Social Links:

GitHub: https://github.com/OpenCodeChicago
YouTube: https://www.youtube.com/@AlexSmaginDev
LinkedIn: https://www.linkedin.com/company/open-code-chicago
X - Twitter: https://x.com/alexsmagin29
Facebook: https://www.facebook.com/profile.php?id=61565627819350

@Alexandrbig1 Can you assign this work to me and label it as 'Hacktoberfest Accepted

Hi, yeah, after today's meeting(at 12pm CST) i'll manage it

@tanvi4248 this is your new task 🚀

@Alexandrbig1
Here is the final result of the website design. The layout is complete, except for the missing company logo. If you have any suggestions or want to make any changes, feel free to let me know!"
Let me know if you need further adjustments!

@shubhamsharma9199 you probably don't understand how to contribute to our project. Please, read carefully documentation, as well you can watch video on YouTube, to understand what each of developer should do. Thank you, if you'll still have any question, please ask me in our open Discussions for this project. Thank you

I'm doing this task or not ?

@tanvi4248 yes, you assigned, read my comment before ☺

@tanvi4248 how is your progress? there still minor issues need to fix in header for desktop device.

Can you mention issues so I can fix it.

@tanvi4248 you can open design and our website, and see the difference. At least what I'm see right away, even without checking it, that the color for links, they all read. also the social icons is not in right place...also hover for social icons is not with transition...etc, Please test it as it's your task to be sure that is looks and works well.Thank you

hello @Alexandrbig1  somebody changed my desktop header css. there is some css which is i didnt change

https://github.com/OpenCodeChicago/Midwest-Pumpkins/pull/119/files#diff-1785483a33076832eb40cc3dc29b03cca0592cd69e9e03f6da7c36ba5e308a2e  Here is the link somebody changed header css for desktop

@tanvi4248 great work Tanvi!


⚠ ClamAV has degraded performance

In 064530e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 696 ms

Resolved: ClamAV performance has improved in b18e7fb.


Add warnings when duplicate keybinds are detected

Also should not crash without any errors. We need to reproduce and see where it crashes.
Ctrl+D was in Find Items and Price Check.


Increase commissioning session establishment timeout

Signed-off-by: Doru Gucea<EMAIL_ADDRESS>Problem
Second admin commissioning was failing on K32W platform due to timeout - see the logs
second_admin_logs.txt
device_logs.txt
Change overview
Increase the commissioning timeout. This is just a temporary solution until optimizations are being applied.
Testing
Manual testing

@pan-apple ?
40 seconds seems huge. We bumped it up from 10 secons to 30 yesterday I believe ... now 40. Do we actually believe that we are this slow?

Given occasional darwin failures, I actually wonder if we are somehow dealing with packet loss rather than just slowness.

Is this really a timeout issue? If you look in the logs, right at the bottom, it looks like the timeout is going much earlier than 40 seconds
controller sends sigma one at<PHONE_NUMBER>.403011. Timeout isn't timestamped, but it happens before the sigma2 is received back at<PHONE_NUMBER>.113697. To me, that looks like about 4 seconds, which corresponds to what the device says (3430 ms).
controller:
[1636034575.402768][16181:16188] CHIP:IN: Sending msg on generic transport
[1636034575.403011][16181:16188] CHIP:SC: Sent SigmaR1 msg
[1636034578.274423][16181:16188] CHIP:CTL: SyncSetKeyValue on StartKeyID
Failed to establish secure session to device: 50
CHIP Error 0x00000032: Timeout
chip-device-ctrl > [1636034579.113697][16181:16188] CHIP:EM: Received message of type 0x31 with vendorId 0x0000 and protocolId 0x0000 on exchange 45886i

device sending back sigma 2:
[162266][P][IN]Build plaintext message 0x400c1d0 to 0x0000000000000000 of type 49 and protocolId 0 on exchange 45886i with MessageCounter<PHONE_NUMBER>.
[162280][P][IN]Sending plaintext msg 0x400c1d0 to 0x0000000000000000 at utc time: ld msec
[162288][P][IN]Sending msg on generic transport
[162294][D][DL]Thread packet SENT: UDP, len 751
[162298][D][DL]    src  FD11:22::902D:60D4:BBE0:DFED, port 5540
[162304][D][DL]    dest 2A02:2F0F:D00E:2600:DEA6:32FF:FEA5:D8D9, port 39741
[162312][D][SC]Sent SigmaR2 msg
[162315][E][DL]Long dispatch time: 3430 ms, for event type 4

@pan-apple ?


Crash when starting dedicated server

When I include the mod to my dedicated server and start it, it seems to fail and the server stops.
crash-2024-06-30_17.11.03-fml.txt

Fixed in 03961e3f43f875b3f193b5f077440feb98491ea6
the file is waiting for approval on CurseForge


chore: add lints to papyrus_common

Lior banned as repo-wide, unless absolutely necessary.
Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coersions).
Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints.

This change is


Feature Requested: Option for changing video quality for youtube videos

This work is really awesome and saved my days of hard work , Thank you for that .
the only thing i need is the ability to changing video quality for youtube videos.

Unfortunately it looks like this hasn't been possible for a while now:

The documentation has been updated to reflect the fact that the API no longer supports functions for setting or retrieving playback quality. As explained in this YouTube Help Center article, to give you the best viewing experience, YouTube adjusts the quality of your video stream based on your viewing conditions.
The changes explained below have been in effect for more than one year.

https://developers.google.com/youtube/iframe_api_reference#release_notes_10_24_2019


Using route::controller and resource at the same time

Hi,
I made my controller via make:controller --resource. Then index page is data table. Other pages are static page.
When i use like this,
Route::resource('backend/haber', 'HaberController');
Route::controller('backend/haber', 'HaberController', [
        'getData'   => 'backend.haber.data',
    ]);

all pages are worked correctly expect datatable. (index)
if i change the location of route::controller
Route::controller('backend/haber', 'HaberController', [
        'getData'   => 'backend.haber.data',
    ]);
Route::resource('backend/haber', 'HaberController');

data table works fine, other pages not working.
if I use only the route::controller there is many route parameters added my route.
like,
backend/haber/data/{one?}/{two?}/{three?}/{four?}/{five?}
I want to use "RESTful Resource Controllers" (route::resource). How i can use like this ?

Operating System : Windows 9.1 Pro (XAAMP)
PHP Version : 5.6
Laravel Version : 5.3
Laravel-Datatables Version : Lastest

@mcsaygili You can use the approach like on this demo. What I usually do now is that the index() method of my resource controller handles all the operation for DT. And I do not recommend controller route since it's deprecated and will not work on Laravel 5.3

Woow! You are really fast.  Thanks alot.
I got this error when i changed.
Undefined property: App\Http\Controllers\Backend\HaberController::$dataTable
Now my controller,
`public function index(Request $request){
if ($request->ajax()) {
$query = Haber::with('onePost')->select('haber.*');
        return $this->dataTable
            ->eloquent($query)
            ->addColumn('baslik', function (Haber $haber) {
                return $haber->onePost ? str_limit($haber->onePost->baslik, 30, '...') : '';
            })
            ->make(true);
    }

    return view('backend.haber.index', [
        'title' => 'Has One Demo',
        'controller' => 'Haber Controller',
    ]);
}`

I injected dataTable in the constructor. You can use the facade Datatable instead of $this->dataTable.
Sent from Outlook using iPhone
On Sun, Aug 28, 2016 at 2:35 PM +0800, "mcsaygili"<EMAIL_ADDRESS>wrote:
Woow! You are really fast.  Thanks alot.
I got this error when i changed.
Undefined property: App\Http\Controllers\Backend\HaberController::$dataTable
Now my controller,
`public function index(Request $request){
    if ($request->ajax()) {

        $query = Haber::with('onePost')->select('haber.*');

    return $this->dataTable
        ->eloquent($query)
        ->addColumn('baslik', function (Haber $haber) {
            return $haber->onePost ? str_limit($haber->onePost->baslik, 30, '...') : '';
        })
        ->make(true);
}

return view('backend.haber.index', [
    'title' => 'Has One Demo',
    'controller' => 'Haber Controller',
]);

}`
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, perfect. Thanks alot.
BTW "DataTables as a Service Implementation" is my second solution.


Update to protoco 2.1.0 (echo_update)

Add comments around the update protocol
Unconditionally send echo_update on front_end change
Update protocol version

@SylvainCorlay  @martinRenou @maartenbreddels @jasongrout this is a PR to add the "echo_update" feature to XWidgets.
If you have a moment, would you mind checking that it looks correct?
This is still missing the mechanism to deactivate "echo_update" on specific properties but that might require some bigger changes on the way we handle properties.


DOC: Fix a few minor issues in OSSL_ENCODER / OSSL_DECODER docs

Partially fixes #13949

This pull request is ready to merge

This pull request is ready to merge


Incorrect keyword highlight in nested functions

This also happens with let and var.
Ubuntu + vim/neovim

You need es.next.syntax.vim.
async is not part of ES6, so not in yajs now.

This happens with regular ES6 too.

@mnylen Please provide code snippets for reproduce the issue.
And I think you can open a new one :)
Thanks~


Improve parser error message when ... is method's body

This task is automatically imported from the old Task Issue Board and it was originally created by Pavel Marek.
Original issue is here.

When trying to run a file that contains just func = ..., parsing fails with:
Execution finished with an error: org.enso.compiler.exception.UnhandledEntity: Fatal: Unhandled entity in translateExpression = AutoScope[" ", "...", AutoScope["", "...", ]]

which seems confusing. Instead, I would expect something like:
Compiler encountered errors:
tmp.enso[1:8-1:11]: Unexpected expression

Returns a syntax error.


georgettica/login to owner cluster

feat(ocm-login-owner): login to owner cluster

Can you be more descriptive what this is doing? I think I get it reading the code, but login to owner cluster isn't real clear, and I want to make sure I understand.
Regarding the mixed bash and python - I'm not going to say it's enough to downvote the PR, but would this be better to just use python for the whole thing rather than dragging it in at the end?
The code itself looks good, though!

Fixing your comment now @T0MASD

@T0MASD can you look again?
I can add README aswell

@T0MASD this PR is mostly to set the groundwork for backplane, I added to ocm-login as this is the easiest way to show how this works
The tool will be added to the downstream once merged

thanks
/lgtm


remove jqueryUI?

I'm doing a project using a custom interface (messing around with bootstrap for the first time) and am running into conflicts with jqueryUI.
We only use this to drag around the attributes window - i'm thinking it's fine to get rid of that.  any objections?

Nick liked the draggable attributes so we'll leave it in for now.


Add Booz Allen Hamilton to adopters list

I added Booz Allen Hamilton's use case to the adopters list.  I also suggest this list be alphabetized, but don't want to overstep by doing so without asking.
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Hey, happy to see you in the list! Two things are red.
First the style check - the columns are misaligned on the table which makes prettier go cranky. You could run yarn prettier --write ADOPTERS.md if you have this locally on a dev machine, or I can help out if you like.
Secondly, DCO asks for a signature. The check link has some more info, or you could manually add a line on the following form to your actual commit message:
Signed-off-by: Your Name<EMAIL_ADDRESS>Sorry for the noise. Again, let me know if I can help out.

Hey, happy to see you in the list! Two things are red.
First the style check - the columns are misaligned on the table which makes prettier go cranky. You could run yarn prettier --write ADOPTERS.md if you have this locally on a dev machine, or I can help out if you like.
Secondly, DCO asks for a signature. The check link has some more info, or you could manually add a line on the following form to your actual commit message:
Signed-off-by: Your Name<EMAIL_ADDRESS>Sorry for the noise. Again, let me know if I can help out.

Sorry, I'm editing this directly on GitHub—this isn't a dev machine and I can't run prettier.  I submitted a new commit to both try to satisfy prettier (which probably failed) and to add a signature... which I then had to re-do because I pasted the signature template without editing it.  Derp.
No worries about the noise on my end; I'm sorry for causing noise for you.

I very rudely did a force push with the layout changes to this pull request - but now DCO disagrees with the signature.
The error message says
Expected "JasonMiller-BAH<EMAIL_ADDRESS>but got "Jason Miller<EMAIL_ADDRESS>
Bah.
To make it possible to sign with the corporate address, I'm afraid you'd probably have to be configuring a local git to use that email identity. However I think that this is just unnecessary complication and frustration for something that doesn't even touch the code - so I will for now just appease it by choosing the email you committed as (the<EMAIL_ADDRESS>automatically generated identity) and call it a day.

I didn’t realize it wanted my GitHub username, not my actual name; that’s on me, sorry.  Thank you for taking care of this!
--
Jason Miller
Lead Technologist | Sr. Scrum Master
Strategic Innovation Group
M:<PHONE_NUMBER> | O:<PHONE_NUMBER>
<EMAIL_ADDRESS>Charleston, SC
Booz | Allen | Hamilton
BoozAllen.comhttp://www.boozallen.com/
From: Fredrik Adelöw @.>
Sent: Wednesday, May 19, 2021 1:24 PM
To: backstage/backstage @.>
Cc: Miller, Jason [USA] @.>; Author @.>
Subject: [External] Re: [backstage/backstage] Add Booz Allen Hamilton to adopters list (#5728)
I very rudely did a force push with the layout changes to this pull request - but now DCO disagrees with the signature.
The error message says
Expected "JasonMiller-BAH<EMAIL_ADDRESS>but got "Jason Miller<EMAIL_ADDRESS>Bah.
To make it possible to sign with the corporate address, I'm afraid you'd probably have to be configuring a local git to use that email identity. However I think that this is just unnecessary complication and frustration for something that doesn't even touch the code - so I will for now just appease it by choosing the email you committed as (the<EMAIL_ADDRESS>automatically generated identity) and call it a day.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/backstage/backstage/pull/5728*issuecomment-844311673__;Iw!!May37g!c297zV8Wwy8GQ6OKDTy6YmDuqbxi-2DkpyU8EDufvOk7XVBZt9t3iLIpsA8v5r2y$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ARQXMP2ZDIO5LFVKMWGD3F3TOPX4DANCNFSM45E3WJKA__;!!May37g!c297zV8Wwy8GQ6OKDTy6YmDuqbxi-2DkpyU8EDufvOk7XVBZt9t3iLIpsLZcmXQu$.


A bunch of changes

Ugh... this was a bit chaotic.
@kvark , please have a look at the performance example. There's a major refactoring there, as I was trying to have as little code duplication as possible.

Probably should've made that last one a fork...

@eugene2k thank you!
I think you did great with the performance example. There is a number of points I'd like to be addressed before merging. Also, @csherratt may want to have a look, since he is the original author of this example.

Thanks!
@homu r+

:pushpin: Commit 955e778 has been approved by kvark

:zap: Test exempted - status


⚠ ClamAV has degraded performance

In 42161bb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 443 ms

Resolved: ClamAV performance has improved in 45865c9 after 5 minutes.


Basic implementation of contestation logic

This PR sets the stage for implementing the contestation logic both off- and on-chain. It's far from being complete and it's not even secure but at least it scaffolds the basic workflow: If a node observes a OnCloseTx that's too old, it autoamtically issues a CloseTx.

I would like to hold off on merging this until after a release of 0.5.0


[RND-210] Proof of concept - implement POST and GET by Id on MongoDB without reference validation

This is a PoC of POST and GET by Id on MongoDB using some of the RND-210 design elements.
I implemented a simple MongoEntityRepository with the same functions as in DynamoEntityRepository. Only createEntity and getEntityById are implemented, and there's no reference validation. Worked pretty well though:

The spike is helpful. I want to keep this branch without merging, so I'll close the PR. Going to rename the branch to mongo-poc so that it is easy to find without having to remember the ticket number.


[Forge] - Bug/Issue

Describe the bug
I am using Forge 1.16.4.Trident when held appears too small and misplaced.
To Reproduce
Run forge 1.16.4 with mod instaled(pack with create,hwyla,doubleslabs,immersive-portals,jei,journey map and optifine. Ran it without other mods and the same thing happened)
Expected behavior
trident should look as large as normal trident and be alligned with hand
Screenshots

this is an optifine issue and im not going to spend time trying to fix it


Question Not Bug

Hi all,
Im using like that. I wanna try native html validator. But if i write: "53_-____"
minlenth is 9 but there is too much char return from the .value property. so its not works. Is there anyway for work it ?
                               <input minlength="9" pattern=".{9,}"  title="Cannot be empty" required  type="tel" class="form-control" id="Phone" name="Phone" data-inputmask="'mask': '999-9999999' " />
I guess only way is only number with regex. no mask ?

You have the default placeholder set to underscore character which fills the string so it satisfies the minlength requirement. To disable this, set the placeholder option to an empty string '' like this:
<input minlength="9" pattern=".{9,}"  title="Cannot be empty" required  type="tel" class="form-control" id="Phone" name="Phone" data-inputmask="'mask': '999-9999999', 'placeholder': ''" />
Remember than the native HTML validation will just set Element.validity.valid to either true or false which is not so useful.

thank you! its works


Appstudio update test-component-pac-roda

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-roda-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
24 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
35 seconds
label-check

✅ Succeeded
35 seconds
optional-label-check

✅ Succeeded
4 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/test-component-pac-roda-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
16 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
29 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
19 seconds
inspect-image

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
12 seconds
optional-label-check

✅ Succeeded
12 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


⚠ ClamAV has degraded performance

In 827ef2c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in b6c120f.


Add a security policy guidelines

While the security risk is limited with our project we could add one, the same way godump project did

https://github.com/yassinebenaid/godump/pull/43

Unless (until) we add specific scripts to install or generate reports from Vale, I don't think this is necessary.

OK, so it's interesting, but when we will provide something like a GitHub action


Failed to fetch https://packages.microsoft.com/ubuntu/18.04/prod/pool/main/u/unixodbc/libodbc1_2.3.7_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 443]

Description
Failed to fetch  https://packages.microsoft.com/ubuntu/18.04/prod/pool/main/u/unixodbc/libodbc1_2.3.7_amd64.deb
Occurs after installing this package and running apt-get update.
https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
Started getting this error when building a docker file in the last 24hours.
The command '/bin/sh -c apt-get update &&     apt-get install -y curl &&     curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - &&     curl https://packages.microsoft.com/config/ubuntu/18.04/prod.list > /etc/apt/sources.list.d/mssql-release.list &&     apt-get update &&     ACCEPT_EULA=Y apt-get install -y msodbcsql17' returned a non-zero code: 100

Dupe of #6381

This issue is being tracked with #6381. It should be fixed now, but some are still seeing slowdowns since everyone is trying to download it. Closing this issue.


Forge Documentation?

I'd love to use this lib for VFX, but I don't know how to register the asset in Forge. Please help

Put the effeks in your mod's assets//effeks folder, similar to the example particles.
Then the particle will be loaded

The documentation is wrong.
You don't need to register client listeners. Doing so may break this mod entirely on Forge platform.


BUG: Buy Products page is not responsive in mobile-view

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Buy Products page is not responsive in mobile-view.
There is some CSS style issue with this page.
I can fix this issue using CSS Media Queries.

https://github.com/user-attachments/assets/0f8a2d23-d85b-4de9-b4fc-8f51326bf0aa
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo Please assign this issue to me under GSSoC'24


Bug/marxan 1152 change unique project role

Fix for users roles in project-acl

Fix unique owner being able of changing their role and effectively locking out the project.
Fix project_contributor and project_viewer roles not seeing their projects in the general view.
Add test to check that the unique owner cannot change their role and locking out the project.

Insta-merge </3 see also https://github.com/Vizzuality/marxan-cloud/pull/716/files#r775549716


virtio-blk: set slot number to vpd

Since virtio disks' vpds are same in pre-win10 os, different virtio disks have same
unique id. It affects some apps' behavior.
Signed-off-by: Zhou Wenjian<EMAIL_ADDRESS>

merged into master
Thank you.
Vadim.


Dynamic namespace problem

This is a weird one that I'm having trouble debugging. If I do this:
namespace ':color' do
  resource :toys do
    desc "Get a list of toys, scoped by color"
    get '' do
      @toys = Toy.where(color: params[:color])
      @toys
    end
  end
end

The intent is to have endpoints like /red/toys.json and /blue/toys.json
These work perfectly.
... but apparently Swagger/Grape-Swagger cannot document that endpoint.
GET /swagger_doc/orders.json returns []
If I put any other endpoints inside that same ':color' dynamic namespace, it won't document any of those either, unless I remove the GET '' endpoint, in which case it will document the others fine. If I change it to GET 'list' it will document that fine, too, but I'd rather have it as '/' because adding 'list' is redundant.
Am I doing something wrong, or is this a problem in Grape-Swagger?

is it still an issue with the actual version?


e2e: improve logging

It would be nice to know which vulns were found in this case so we can get a better idea of what Scanner found.
This is added due to Scanner intermittently not finding CVE-2021-26291 for jenkins-2-plugins

/retest


Autocompleter

Hello,
the autocompleter does not show if @ is typed in the Damage Formula for weapons or any other type of item i tried out.
Also there isn't a floating @ button showing up as in the module discription mentioned/shown.
I created a new world for this module to exclude any problems with other modules.
Current Version:
FoundryVTT: 9.269
DnD5e: 1.6.1

Thanks for the report, I'll take a look as soon as possible

@malon1994 OK, so the issue is that for the dnd5e integration in the item sheets, AIP uses the roll data of the item (getRollData()). However, unowned items simply return null for getRollData(). This actually has been the case for over a year already (see https://gitlab.com/foundrynet/dnd5e/-/blame/master/module/item/entity.js#L1487). In particular, that means AIP cannot properly work for unowned items in dnd5e, unless there is a sensible fallback to use for this case. I personally don't use dnd5e, so I don't know if a sensible default is possible. Maybe something like using the roll data of a dummy actor? Would that make sense? I checked, and and the roll data of the actor at least makes up the bulk of the roll data of items, so I guess this could be a solution.
I have verified that things work correctly for owned items.

First at all, i am very sorry for reporting an already known status.
Sadly, my personal programming skills aren't good enought to find and implement a solution for this. I just created this account to report it here.
I appreciate your quick reply and thank you for your explanation.
Sorry for bothering you with my inexperience.


Doubts in settings plugin

In the plugin Settings you have

but in Visual Studio 2013 using Xamarin Plugin I have

Can you clarify it, please? I am trying to use it in a demo about Notification Hubs.

This is a good question, I have never had an issue in VS. It should be fine, but I am asking the team why that box is never enabled.


feat: Espresso design system + Storybook

Breaking changes
Button.vue
appearance prop removed in favor of more flexible props for appearance: variant and theme

Before
After

<Button appearance="primary">
<Button variant="solid">

<Button appearance="danger">
<Button variant="solid" theme="red">

<Button appearance="minimal">
<Button variant="ghost">

<Button appearance="white">
<Button variant="outline">

Dialog.vue

Before
After

<Dialog :options="{ actions: [label: 'Save', handler: fn ] }">
<Dialog :options="{ actions: [label: 'Save', onClick: fn ] }">

Deploy preview is broken btw:


pam/swaylock installed to the wrong location (at least for Fedora)

No idea which distributions this affects, but as there’s no general outcry about it I’m going to assume it’s not everyone.
During the install process, this happens:
Installing /path/to/swaylock-effects/pam/swaylock to /usr/local/etc/pam.d

On Fedora, this is not read by the system. The file has to be in /etc/pam.d (or potentially optionally in a different location, but not this one ↑). The result is swaylock not being able to check the password, and unhelpfully just stating “wrong” even for the correct password.
Copying the file to /etc/pam.d/swaylock solves the issue.

Forgot to add: see https://github.com/mortie/swaylock-effects/issues/66

This depends on the prefix option passed to meson (see https://mesonbuild.com/Builtin-options.html). If you specify -Dprefix=/usr, it’s installed into /etc/pam.d. You can also override just the sysconfdir. That’s the Meson thing, it’s not specific to this project.


Lightning Gallery - engineering review [lit-doccano component]

Thanks for submitting your component to Lightning Gallary. @tshu-w
That's a powerful component. There are a few points that will be nice to address before the component is added to the gallery.
1- I couldn't install the component on fresh env, seems doccano==1.8.0 conflicts with lightning
aiobotocore 2.1.2 requires botocore<1.23.25,>=1.23.24, but you have botocore 1.27.49 which is incompatible.

2- Also the dependencies should be added in the setup.py so they get installed when installing the component.
3- In the component I noticed that the username and password are hardcoded, can we improve that? maybe as inputs or using environment variables.
4- Could you add an e2e test for your example app as part of the CI ? You can get some inspiration from here: https://github.com/Lightning-AI/lightning/tree/master/tests/tests_app_examples
This is important to ensure the stability of the component :)
5- will be great to add some comments in the example app showing that this component starts a UI and how to configure the component.
If you have any questions, please reach out! we will be happy to assist you to land your component in the Lightning gallery.
cc: @zippeurfou

@manskx Hi, sorry for the rushed entry into the Storm Chaser Challenge Series.
I will try to fix this point but not particularly fast. I will let you know when finished.

@tshu-w Looks like we have two problems with this component.
Issue 1:
Update the requirements with the following. This is because of the following issue
cat requirements.txt
Django==4.0.4
doccano==1.8.0

Issue 2:
iframe cross-origin issue can be seen in chrome console.

This is currently an issue with embedding iframe in lightning. Please see the related issue https://github.com/Lightning-AI/lightning/issues/13520

Thanks @krishnakalyan3, I've been busy with experiments recently, I'll take a look when I have time.

@tshu-w a solution to X-Frame-Options is to remove that using nginx or Caddy.  https://github.com/robert-s-lee/lit_label_studio/blob/nginx/lit_label_studio/component.py has sample code used to remove the X-Frame-Options in Label Studio.
Django requires the following env var:
'USE_ENFORCE_CSRF_CHECKS':'false',
Nginx conf as follows:
https://github.com/robert-s-lee/lit_label_studio/blob/nginx/lit_label_studio/nginx-8080.conf

Hi @manskx, after @robert-s-lee excellent PR, we have solved 1 2 3 that you mentioned. But since the current solution requires nginx and a separate venv for doccano, I'm not sure it's appropriate. So 4 and 5 are not done.


Added Windows-style mouse double-click to the textbox

the word under cursor is selected with double-click now
tested in both editable and read-only modes

This addresses #226.

Or should this go into origin/develop?

Thanks for your PR, this improvement doesn't impact on the hotfix, it is OK for both 'develop' and 'hotfix'.

OK, I've removed the second (selection-related) commit.

Thanks a lot for the contribution!


Add time filter to Top queries by cpu time

In TopQueries we have request for the last hour, while in Top queries by cpu time table we have requests without time filter. Add some filter to display only recent queries

Will be fixed in https://github.com/ydb-platform/ydb-embedded-ui/issues/1038


README.md is not updated

README.md file is not updated as per the standard.

Fixed in https://github.com/wso2-extensions/siddhi-io-mqtt/pull/6


   <EditText
        android:id="@+id/sbt_txt"

       <requestFocus />
    </EditText>

   <Button

 </LinearLayout>

Try to make your title a short description of the problem and leave the code/errors to the description


Slicers - Missing theme setting for search box background

I'm not sure if this is a missing setting or missing configurability on the Power BI product side.
Currently, the background color for a slicer search box is always "white" (#ffffff) and the search box text color appears to be pulled from the top-level theme "foreground" setting - which for a dark mode is likely also "white". The result is a white-on-white search box that isn't readable - and worse, if typed in by the user creates an invisible filter against the slicer's context.
The only workaround I have found is to completely disable search boxes in slicers and then hope the user does not re-enable them. This is especially painful for "dark mode" themes (my use case) but it may be affecting others as well.
Any assist or workaround would be greatly appreciated. Thanks!

Related: https://ideas.powerbi.com/forums/265200-power-bi-ideas/suggestions/38574625-enable-setting-the-background-of-search-box-in-sli

Temporary workaround is to use a non-white color (blue in the below example) for the "label" text class.
Example:
{
 "name": "sample theme snippet",
  "textClasses": {
    "header": {
      "fontSize": 12,
      "fontFace": "Segoe UI",
      "color": "#c2d8fe"
    }
}

Update: When setting the "label" text class, this also overrides the default text box color. It would therefor be helpful to know if there's also a way to override the default font color for text boxes. (The repo here shows a sample to override the background color but not the default text color for text boxes.)


Namespace the css

Your css has a reset which isnt namespaced.   is that avoidable when using tailwind?

Hi! Can you maybe better point out which reset you mean? Where do you see it? We only include some base styling from tailwind, all the rest we do by setting utility classes on each element.

it is setting styles on h1 for eg in the tailwind reset.   you maybe are not noticing because the rest of your site is tailwind? all the css  code from the module should be namespaced right?

this is in
 _resources/vendor/wedevelopnl/silverstripe-admintoolbar/client/dist/main.css?m=1704286185

We see. This is now scheduled to be fixe in the next week. Thanks for reporting, Will!

Hi @asecondwill. We disabled the preflight, it's on the ss-5-wip branch. Can you let us know whether this is what you're looking for?


API readiness app associated PR link is disabled

I need to update the PR for Health Insights as the initial PR has been closed.  The new PR is https://github.com/Azure/azure-rest-api-specs/pull/22990.  The API Readiness app is showing all of the buttons as disabled. I cannot update associated a new PR.

@ladonnaq Fixed! you can do it now:


Content Security Policy blocks script because of JSON.parse() or localStorage.getItem()

Firefox Content Security Policy gives this error:
SecurityError: The operation is insecure.
It gives reference to this line:
https://github.com/Fugiman/deckmaster/blob/da99f7ceae6e8a7bb54eefba4f8b2704e4c0a32e/overlay/src/store.js#L32
which is
globalHide: JSON.parse(localStorage.getItem(globalHideKey)) || false,

I wondered why I couldn't get this working in Firefox 62 in a stream I was watching.

FYI, I got it working in Firefox 63 by allowing all 3rd-party cookies.  Not sure if that security warning still applies now.


fix: Use constructor injection instead of field injection in Java code

Fixes #1392
Components where field injection has been converted to constructor injection:

[x] Challenge service
[x] Organization service
[x] API Gateway
[x] Config server

The updates will support the transition to consistent implementation of unit and integration in the future.

@mdsage1 This PR has not been updated in a while. Can you please provide a short update?

Hi @mdsage1, this PR kind of fell behind and so I propose to close it and reopen a fresh one when you are back on the project.

That works for me. @tschaffter


[build] add initial clang support

Primary change is checking for Clang compiler ID.
DML_SECURITY_OPTIONS needed to be broken up into link and compile options as clang raises warnings for unused linker flags when compiling with the -c flag. Gtest uses -Werror, which creates errors preventing tests from being built.
Several small bugs also needed to be fixed to compile the core library as well as the examples (mostly clang template deduction). I was unable to get benchmarks to compile due to some quite complex template issues in benchmarks/include/utility.hpp
The contributing.md is a little bit sparse on instructions :). I added myself to the copyright on the files I modified, but happy to do whatever, including signing a CLA, to add clang support. I am working on a clang-only project, and would quite like to use this library.

Hi @Shamazo,
thank you for your contribution!
Could you please let me know why the PR is called "initial"? Do you plan to extend it in the future?

"partial" is perhaps a better word. I am unable to get the benchmarks running and currently not very inclined to with my limited time (debugging existing templates is not my strength, but I will add a gist with the build error in case it is obvious to someone else). I am also reluctant to call it full clang support without running benchmarks to compare clang and GCC and validate that clang is not a major perf regression.
I will change up the CMake flags such that tests can be built without benchmarks and then report back on the full test suite probably tomorrow. I am currently unable to validate the hardware mode as I do not yet have access to a sapphire rapids machine. I will test with clang-14 + a skylake machine.
Is there any plan to add CI to the repo? I know adding CI for projects with hardware dependencies is a pain, but it would be nice :). I would volunteer to add basic CI, but cannot offer the hardware resources to do it. (Does Intel have an internal CI for this project or is the default to ask contributors to run tests themselves and confirm that they work?)

"partial" is perhaps a better word. I am unable to get the benchmarks running and currently not very inclined to with my limited time (debugging existing templates is not my strength, but I will add a gist with the build error in case it is obvious to someone else). I am also reluctant to call it full clang support without running benchmarks to compare clang and GCC and validate that clang is not a major perf regression.
I will change up the CMake flags such that tests can be built without benchmarks and then report back on the full test suite probably tomorrow. I am currently unable to validate the hardware mode as I do not yet have access to a sapphire rapids machine. I will test with clang-14 + a skylake machine.
Is there any plan to add CI to the repo? I know adding CI for projects with hardware dependencies is a pain, but it would be nice :). I would volunteer to add basic CI, but cannot offer the hardware resources to do it. (Does Intel have an internal CI for this project or is the default to ask contributors to run tests themselves and confirm that they work?)

Yes, there is a plan on adding public CI, but it would be a light-weight scan with partial coverage only.
We do have a much broader internal CI, and I (or other engineer) would take your changes and validate it internally for sure, I was just asking about what basic checks were done in order to understand the scope of work for the reviewers.
Testing only host code path is OK for the start, I'll wait on your results before proceeding with reviewing the PR.
Thanks!

Hi @mzhukova
All software/auto mode tests pass for me. I added one commit so tests and benchmarks each have their own cmake flag
Here is the build error I get when I try to build the benchmarks with clang 14.

Hi @mzhukova
All software/auto mode tests pass for me. I added one commit so tests and benchmarks each have their own cmake flag
Here is the build error I get when I try to build the benchmarks with clang 14.
(Force pushes are me fixing up typos)

Thanks for the update @Shamazo!
I'll look into the benchmarks issue a bit later (merging this PR won't be blocked by this).
As for PR review and validation, since we have a full internal CI support and no public CI support yet, I will take your changes/test it out fully internally and update here with the results.
Again, thanks for the contribution!

closing this as it changes were implemented as part of d3b19d9010facef70c1f95dfc0d6043d3f96fd01

@Shamazo we were able to test out your changes internally and even fixed the benchmarks!
Please, let us know if this resolves all your issues with clang build.
PR was closed since we committed combined changes (yours and project core team) from our side.

Thank you for merging and figuring out the benchmarks :). If I run into further issues (e.g. on different clang versions) I will open an issue / PR.


test-branch/execute-job/comment-from-wrong-user-on-pr/a9865100-a6e3-4aae-b8af-e1d704d497b4

PR for testing 8f3a61392fee55cb0de5bfc16f42b53276965186

/canonical/self-hosted-runners/run-workflows 8f3a61392fee55cb0de5bfc16f42b53276965186


Multiple calls to userManager result in Disposed error

I have this code that's called from Startup.Configure:
`public async void Initialize()
{
appDbContext.Database.EnsureCreated();
        var adminGroupName = "Administrator";

        if (appDbContext.Roles.All(i => i.Name != adminGroupName))
        {
            await roleManager.CreateAsync(new IdentityRole(adminGroupName));
        };
        var role = appDbContext.Roles.First(i => i.Name == adminGroupName);

        if (appDbContext.Users.All(i => i.UserName != adminSettings.Username))
        {
            await userManager.CreateAsync(new ApplicationUser { UserName = adminSettings.Username,
                                                                Email = adminSettings.Username,
                                                                FirstName = adminSettings.FirstName,
                                                                LastName = adminSettings.LastName,
                                                                EmailConfirmed = true }, adminSettings.Password);
        }
        var adminUser = appDbContext.Users.First(i => i.UserName == adminSettings.Username);

        if (!appDbContext.UserRoles.Any(i => i.RoleId == role.Id && i.UserId == adminUser.Id))
        {
            await userManager.AddToRoleAsync(adminUser, role.Name);
        }
    }`

At random, I get the Accessing Disposed Exception from userManager.CreateAsync or userManager.AddToRoleAsync
The class where Initialize is declared is registered with AddScoped in Startup.ConfiguredServices and is passed as an argument to Startup.Configure.
What am I doing wrong that I am getting the Disposed exceptions?
Thank you.

Can we see your complete startup.Configure? Where is your user manager coming from? Is this called on every request? UserManager et al are request scoped.
Are you trying to seed data here?

DbInitializer.Initialized is called from Startup.Configure. I hope it's called only once, not on every request. Yes, I am trying to seed the admin account for the site. Normally, I seed using MERGE SQL statements, but in this case of creating an account, it seemed that using UserManager from .NET core code is better.
Here is my Startup.cs
`        public void ConfigureServices(IServiceCollection services)
{
services.AddDbContext(options =>
options.UseSqlServer(Configuration.GetConnectionString("MyGroupDbConnection")));
        services.AddDbContext<ApplicationDbContext>(options =>
            options.UseSqlServer(Configuration.GetConnectionString("MyGroupDbConnection")));

        services.Configure<AdminSettings>(Configuration.GetSection("settings").GetSection("admin"));

        services.AddIdentity<ApplicationUser, IdentityRole>()
            .AddEntityFrameworkStores<ApplicationDbContext>()
            .AddDefaultTokenProviders();

        services.AddMvc();

        services.AddScoped<IDbInitializer, DbInitializer>();
    }

    // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
    public void Configure(IApplicationBuilder app, IHostingEnvironment env, IDbInitializer dbInitializer)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
            app.UseBrowserLink();
            app.UseDatabaseErrorPage();
        }
        else
        {
            app.UseExceptionHandler("/Home/Error");
        }

        app.UseStaticFiles();

        app.UseAuthentication();

        dbInitializer.Initialize();

        app.UseMvc(routes =>
        {
            routes.MapRoute(
                name: "default",
                template: "{controller=Home}/{action=Index}/{id?}");
        });
    }
}`

User manager is injected into DbInitializer:
`    public class DbInitializer : IDbInitializer
{
private readonly UserManager userManager;
private readonly RoleManager roleManager;
private readonly AdminSettings adminSettings;
private readonly ApplicationDbContext appDbContext;
    public DbInitializer(
        UserManager<ApplicationUser> userManager,
        RoleManager<IdentityRole> roleManager,
        IOptions<AdminSettings> optionsAccessor,
        ApplicationDbContext appDbContext)
    {
        this.appDbContext = appDbContext;
        this.userManager = userManager;
        this.roleManager = roleManager;
        adminSettings = optionsAccessor.Value;
    }`

Thanks

Something along those lines....scope the objects inside the configure.
var roleManager = app.ApplicationServices.GetService<RoleManager<IdentityRole>>();
foreach (var role in Roles.All) {
     if (!roleManager.RoleExistsAsync(role.ToUpper()).Result)
     {
      roleManager.CreateAsync(new IdentityRole { Name = role });
    }
}

Also async void is not a good pattern. Return a Task and wait if needed.

@popsovy Looks like this is happening because the DbContext, which is registered as scoped, is being accessed from the root scope. However, these is not enough code to be sure--if this isn't the case, then please post a runnable project/solution of complete code listing that demonstrates the issue.


Showing PrivotUI() output like Pivot()

Hey, thanks for making this awesome plugin. I need a help in showing my data in pivotUI style.
The data is just look like this:
[
  {
    "nama_kecamatan": "Gerokgak",
    "nama_kelurahan": "Sumber Klampok",
    "jenis": "hindu_pria",
    "jumlah": 23
  },
  {
    "nama_kecamatan": "Gerokgak",
    "nama_kelurahan": "Sumber Klampok",
    "jenis": "hindu_wanita",
    "jumlah": 24
  },
  {
    "nama_kecamatan": "Gerokgak",
    "nama_kelurahan": "Sumber Klampok",
    "jenis": "islam_pria",
    "jumlah": 25
  },
  ....
]

When I showing this data, it looks well when I using privot() on calling it. The output is like this:

And calling it using this code:
$("#output").pivot(data,
	{
        rows: ["nama_kelurahan"],
        cols: ["jenis"],
        aggregator: sum(intFormat)(["jumlah"])
    }
);

It just looks like what I want.
But the problem is, when I call it via privotUI(), the result is become like this:

The value in each cell is not like what return when using privot() function. Is there any custom option to make my data just look like privot() function output when I call it using privotUI()?
I need to show it just look like privot() but wanted your drag and drop feature like privotUI
Thanks in advance...

Thanks, my bad. Just realize it already yesterday. Did you know any option to make it default at the first load?

Yes, you can control this with aggregatorName and vals... check out the pivotUI() docs here: https://github.com/nicolaskruchten/pivottable/wiki/Parameters

It just like what I want now by using this code
$("#output").pivotUI(mps,
                    {
                        renderers: renderers,
                        aggregatorName : "Integer Sum",
                        vals : ["Jumlah"],
                        rows : ["Nama Kecamatan", "Nama Kelurahan"],
                        cols : ["Kategori"]
                    }, true
                );

And this is the result

Thanks for your help @nicolaskruchten


mongoose model for a branch

Created both the typescript schema and the mongoose schema

Looks great, thanks for the work!


Sync issues

Fixes #845, fixes #846

Codecov Report

Merging #848 (de8f032) into master (e8f94f7) will increase coverage by 0.08%.
The diff coverage is 82.00%.

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   48.74%   48.82%   +0.08%
==========================================
  Files         142      142
  Lines        7004     7025      +21
==========================================
+ Hits         3414     3430      +16
- Misses       2984     2987       +3
- Partials      606      608       +2

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/core/loop/consensus.go
76.47% <0.00%> (-2.95%)
:arrow_down:

pkg/core/chain/synchronizer.go
65.85% <75.00%> (+3.16%)
:arrow_up:

pkg/core/consensus/agreement/step.go
56.00% <81.81%> (+4.52%)
:arrow_up:

pkg/core/chain/sequencer.go
100.00% <100.00%> (+33.33%)
:arrow_up:

pkg/core/mempool/mempool.go
43.02% <100.00%> (ø)

pkg/p2p/peer/factory.go
100.00% <100.00%> (ø)

pkg/p2p/peer/peer.go
36.45% <100.00%> (-0.62%)
:arrow_down:

pkg/gql/notifications/broker.go
72.58% <0.00%> (-3.23%)
:arrow_down:

pkg/p2p/kadcast/testing.go
69.79% <0.00%> (-3.13%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9a2b1...de8f032. Read the comment docs.

Codecov Report

Merging #848 (de8f032) into master (e8f94f7) will increase coverage by 0.08%.
The diff coverage is 82.00%.

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   48.74%   48.82%   +0.08%
==========================================
  Files         142      142
  Lines        7004     7025      +21
==========================================
+ Hits         3414     3430      +16
- Misses       2984     2987       +3
- Partials      606      608       +2

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/core/loop/consensus.go
76.47% <0.00%> (-2.95%)
:arrow_down:

pkg/core/chain/synchronizer.go
65.85% <75.00%> (+3.16%)
:arrow_up:

pkg/core/consensus/agreement/step.go
56.00% <81.81%> (+4.52%)
:arrow_up:

pkg/core/chain/sequencer.go
100.00% <100.00%> (+33.33%)
:arrow_up:

pkg/core/mempool/mempool.go
43.02% <100.00%> (ø)

pkg/p2p/peer/factory.go
100.00% <100.00%> (ø)

pkg/p2p/peer/peer.go
36.45% <100.00%> (-0.62%)
:arrow_down:

pkg/gql/notifications/broker.go
72.58% <0.00%> (-3.23%)
:arrow_down:

pkg/p2p/kadcast/testing.go
69.79% <0.00%> (-3.13%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9a2b1...de8f032. Read the comment docs.

Noted. I'll address the comments with another PR.

Noted. I'll address the comments with another PR.


Sharing context

Description
When I launch an application using RenderDoc, the wglShareLists function seems to malfunction
Steps to reproduce

Environment

RenderDoc version: 1.29
Operating System: window 11
Graphics API: OpenGL

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


Broken LSP tests

1) VSCode Intellisense Notebook Diagnostics @lsp
       Add cells and make sure errors show up:

      Error: No diagnostics found for vscode-notebook-cell:/tmp/emptyPythonb54b6b0b-c35c-4ec0-b1d9-1d94a5a02ac1..ipynb#W1sZmlsZQ%3D%3D
      + expected - actual

      at Timeout.<anonymous> (src/test/common.ts:66:20)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

  2) VSCode Intellisense Notebook Hover @lsp
       Insert cell and get hover text:

      Error: No hovers found for vscode-notebook-cell:/tmp/emptyPython535824fb-a443-440a-a00e-fb17e3aa8959..ipynb#W1sZmlsZQ%3D%3D
      + expected - actual

      at Timeout.<anonymous> (src/test/common.ts:66:20)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

  3) VSCode semantic token tests @lsp
       Open a notebook and add a bunch of cells:

      TypeError: Cannot read properties of undefined (reading 'startOffset')
      + expected - actual

Closing, as these will be removed.


add option for developers to have a tiled menu

Implements #166

Closed in favor of https://github.com/smartdevicelink/rpc_spec/pull/193


Proof of concept: of attributes as yaml

Following on from data as  Ruby constants in models this lets you source YAML files from data and iterate over them.
Which would mean you don't need to add the id manually, but can generate it from the attribute name.

      build-path

        Path to where the builds will run from.

Default: (depends on platform)

Environment variable: BUILDKITE_BUILD_PATH

which by itself isn't worth making the change.
But you could also change the html formatting at low effort. And include single attribute data in other places.
This PR just reproduces the same output format using data from the YAML file.

Urgh, I'd forgotten about the vale and erb inside html thing.
BlockIgnores = (?s) *(
.*?
)

and marking the tables as containing erb works. Or just wrapping in ignore comments.

@ticky do you have any thoughts on this being a terrible idea generally? From a rails point of view? Anything I'm doing wrong?

Seems like a reasonable thing to do, yeah. I'd just double check this still works with the data extractor gear. 👍🏼

You can do some simple yaml validation using https://www.npmjs.com/package/yaml-schema-validator#command-usage
npx schema validate -f data/agent_attributes.yaml -s data/agent_attributes.schema.yaml

@StarfallProjects I don't know why it isn't running in the build, but npm run validate-yaml should work locally.

Currently updating the YAML and saw that the current docs have recently started using an "introduced in" field. Is it worth adding that to the schema @plaindocs ?

I'll need to tweak the YAML validator here.

I fixed some of the linting stuff, but the long list of render markdown errors are I think that all render_markdown need to be render_markdown partial

@lachlanhardy ok mate, I've cleaned up the merge conflict and the errors introduced by the update from main due to a change in the partial syntax.
Let's replace the two tables in https://buildkite.com/docs/agent/v3/configuration#configuration-settings (Required and Optional) with a single table, with visual indication of the required state. And remove the test table obv.
Looks like we didn't convert the deprecated settings to YAML, so we can ignore those for now.
Then, first week of January we can merge this thing it and start iterating on the details. Of how to make it sortable, visually more useful, and include better meta data from the structured data.

First take on the table pushed. You can see it here: https://docs-review-pr-1002.herokuapp.com/docs/agent/v3/configuration#configuration-settings

New version of the table: https://docs-review-pr-1002.herokuapp.com/docs/agent/v3/configuration#configuration-settings

I really like this! A few things that spring to mind:

I'd like the required tag to stand out more than the optional one. Or put a different way, I'd like that to be an obvious distinction not just a label.
I think we also need to label the environment variables,

Let's fix these and merge this.
@karensawrey We're going to need to double check the quotes on some of these default values, which might have happened on the conversion to YAML.

I really like this!

Same! Love it, amazing work, @lachlanhardy! I only have one small concern - while the required/optional tags look nice, green, and prominent in the screenshot above, they barely look like they are colored differently on a 4K screen in Chrome under Windows for me (tested on 2 different 4K screens).

@karensawrey We're going to need to double check the quotes on some of these default values, which might have happened on the conversion to YAML.
Please clarify.

@karensawrey is that a font width thing do you think?

@karensawrey is that a font width thing do you think?

Could be, but I'm running all defaults, no customization. I also sent @lachlanhardy a photo of the screen where it all looks more or less black, but that's for info only if it renders fine on most machines.

I've revamped again. Viewable directly here: https://docs-review-pr-1002.herokuapp.com/docs/agent/v3/configuration#configuration-settings

@karensawrey I made that text larger, has that made a difference for you?
@plaindocs I've broken required and optional out into separate sections (but still the same table so we keep the widths). Also labelled the env vars and adjusted some wrapping. What do you reckon?

Looks great! If we tweak the template code to make up the experimental stuff, it should just work right?

Works just fine

Awesome!  You should just be able to stick anything inside the table cells and have them work.
Potentially, some elements might require margin adjustments to look right, but we can fix that easily if you see it.
Let me know if you want anything else on this, otherwise we can merge whenever. Tomorrow is the last day I can do anything for a bit because flights etc

On 17 Jan 2022, at 11:53, Plaindocs @.***> wrote:

Works just fine
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

@karensawrey Awesome. Thanks to your feedback, I bumped up the size of that text a bit which is hopefully what made it more readable.
@plaindocs I think this is good to merge then. I'd prefer sooner than later in case we missed something, but I'll hold off until I hear confirmation from you.

@plaindocs Ah, I've seen your internal post now. Yeah, happy to let it settle a bit. After six months, a few more days won't hurt. Hit me up via email if you need!

@karensawrey That's good feedback, though, thank you! I am not much of a visual designer so I always want to hear if I've gone too far with something.

🙌🏼


Fix for breaking changes in zig nightly

IterableDir is now just Dir with the iterate flag
Changed var to const where no mutation occurs

Can you change the PR target to a branch zig-master?

I think you'll have to create a zig-master branch for that first @MasterQ32


Uncaught Parse error in .ftpconfig JSON : SyntaxError: Unexpected token /

[Enter steps to reproduce below:]

First i created a proyect
Then i created a .ftpconfig file to connect via ftp with the ftp package

Atom Version: 0.182.0
System: Mac OS X 10.10.1
Thrown From: Atom Core
Stack Trace
Uncaught Parse error in .ftpconfig JSON : SyntaxError: Unexpected token /
At /Users/israelortiztop/.atom/packages/Remote-FTP/lib/client.js:78

undefined

Commands
     -1:17.8 remote-ftp:create-ftp-config (atom-pane.pane.active)
  2x -0:38.1 core:paste (atom-text-editor.editor.is-focused)
  3x -0:07.1 core:save (atom-text-editor.editor.is-focused)
     -0:01.4 remote-ftp:connect (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "editor": {
    "fontSize": 16
  }
}

Installed Packages
# User
Remote-FTP, v0.6.0
linter, v0.11.1

# Dev
No dev packages

I think that this issue belongs on the repo for the remote-FTP package: https://github.com/mgrenier/remote-ftp

@thedaniel Looking at the number of issues you guys have to route to package repositories, I think You guys should create a bot that checks the first line of the newly opened exception issues and matches /packages/.*/ in the trace and then forwards that issue to that package's repo.
It'll make the moderation a lot easier for you guys.

@steelbrain in most cases it does. It checks the stack trace for the package. This one doesnt have a stack trace, and the line isnt parsed for package quite yet: https://github.com/atom/notifications/blob/master/lib/main.coffee#L38
In most other cases it's from another package that we're not catching, the package is failing on some async method (like file operations) and providing no stack.
I plan to check the commands and the line for 3rd party packages in the future, but havent gotten around to it yet.

Post your .ftpconfig file. I was having the same bug until I noticed the line: "secure": false, was missing: false, which created an error when parsing the JSON file.


fm compile issue

Will not compile if FM radio enabled

make clean
make -B

git reset --hard

send me your Makefile here

Everythings works fine with your file....
You musk edit something to happend that...


[Macros] Add notion of owning module and supplemental modules for macros

Macros are associated with a module, which is the module in which they would be defined if the macro could be defined within the language itself. We call this the owning module. It will need to be imported in any Swift source file that wants to use the macro. Introduce an "owningModule" requirement to the Macro protocol to describe this.
The signatures of macros can make use of types in the owning module, but might also require other modules (e.g., that the owning module depends on). Introduce a "supplementalSignatureModules" requirement to the Macro protocol, with a default implementation of [] since this is unlikely to be used often.
Both the owning and supplemental modules will be imported when processing the macro signature.

@swift-ci please test


Incorrect precision in default Converter.ToStr() depending on type

Description:
Inserting a column of double data results in precision loss due to the Converter.ToStr() implementation using ostringstream.
I believe ostringstream has a default precision of 6 so numeric values may not be preserved depending on the type.
While I recognize I could write a new converter, in my very humble opinion, I think the default behavior of the converter should represent the precision of the data in full assuming the values will be used later in computation or may be copied into another doc or something like that.
How to reproduce it:
I noticed this problem when inserting a column of double data into a new rapidcsv::Document from another rapidcsv::Document. When comparing the values between documents, I only got about 6 digits of precision in the new columns.
Environment:

Version: 22.04
OS / distro: Ubuntu

Hi @tylerHanf - I think you're bringing up a good point. Ideally floating point numbers should be intact through a round-trip through rapidcsv. I will look into fixing this in rapidcsv.
For my own reference: Stack Overflow answer with suggested iomanip properties for shortest round-trippable float and double respectively.

Hi again, this should be fixed in the above commit. Please let me know if you still see any related issue. Thanks!


Gate traces behind log level 2

What type of PR is this?
/kind bug
What this PR does / why we need it:
Traces are now only dumped in logs if klog verbosity level is >= 2. Prior to this change, they were outputted to logs even when the verbosity level was set to 0 although this level should only be dedicated to critical information. Level 2 is better suited for information about requests.
Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes/kubernetes/issues/115993
Special notes for your reviewer:
Release note:
Traces are now outputted to logs only if the verbosity level is >= 2

/cc @sttts

/lgtm
/approve