Can not load extensions market and extension can not install

Issue Type: Bug
Installed vs code_1.25.1 in Ubuntu 16.04 but it failed to load the extensions market. Then error occurred, showing "an unknown error occurred. Please consult the log for more details".
VS Code version: Code 1.24.1 (24f62626b222e9a8313213fb64b10d741a326288, 2018-06-13T17:47:35.732Z)
OS version: Linux x64 4.15.0-29-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3700)

GPU Status
2d_canvas: unavailable_softwareflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: unavailable_offnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarevpx_decode: unavailable_softwarewebgl: unavailable_offwebgl2: unavailable_off

Load (avg)
2, 2, 2

Memory (System)
15.61GB (6.06GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions: none

@forestriveral Can you please open your dev tools from the command palette choosing Developer: Toggle Developer Tools or from the Help menu and provide us the logs?
Pls also have a look at #53516 for a similar case. Thanks!

/needsMoreInfo


Fix test scripts

[x] init_db properly sets up bulbs database role
[x] scripts/test passes arguments through to py.test

@benghaziboy @MichaelButkovic

👍

It's ok. I'm into public humiliation

👍


Clear diagnostics when they are no longer relevant.

If you give no diagnostics, it will interpret it as no change instead of as no errors.
See here
https://hackage.haskell.org/package/lsp-<IP_ADDRESS>/docs/Language-LSP-Diagnostics.html

Hi @anka-213 ! I'm not an expert and have never worked on lsp before but someone else was facing a similar issue:
Their solution was "...Map.singleton (Just defaultDiagnosticSource) (Data.SortedList.toSortedList []) instead of an empty map"
What would you have me do ?

Thanks for doing the research! This info definitely makes it easier!


Add filter resources by cluster functionality in Topology plugin

Story: https://github.com/janus-idp/backstage-plugins/issues/121
Description:
This PR adds a toolbar in topology view consisting of a filter by cluster dropdown which lists all the available clusters and the user can select the cluster they want to see the resources for. It also shows any errors while fetching the resources in the topology view.
https://user-images.githubusercontent.com/20724543/220645623-fca21fdc-30f4-47dd-b730-57dfd6880b51.mov
With error:
https://user-images.githubusercontent.com/20724543/222163610-4b79d0fd-b5b9-484f-94a1-06d42f57b0ee.mov
Test Setup:
Install and configure kubernetes plugin by following these guides:
https://backstage.io/docs/features/kubernetes/installation
https://backstage.io/docs/features/kubernetes/configuration
Kubernetes plugin is properly configured and able to connect to the cluster via a ServiceAccount
Following ClusterRole must be granted to ServiceAccount accessing the cluster:
(k8s plugin by default tries to fetch the following resources and if access is not provided an error is shown)
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: backstage-read-only
rules:
  - apiGroups:
      - '*'
    resources:
      - pods
      - configmaps
      - services
      - deployments
      - replicasets
      - horizontalpodautoscalers
      - ingresses
      - statefulsets
      - limitranges
      - daemonsets
    verbs:
      - get
      - list
      - watch
  - apiGroups:
      - batch
    resources:
      - jobs
      - cronjobs
    verbs:
      - get
      - list
      - watch
  - apiGroups:
      - metrics.k8s.io
    resources:
      - pods
    verbs:
      - get
      - list

Create a service component entity - https://github.com/temp-demo-organisation/nationalparks-py/blob/master/catalog-info2.yaml
To get the resources from a k8s cluster do the following:
K8s plugin identifies if the provided entity has k8s resources and if yes from which namespace it should get the resources based on the following annotations added to the entity's catalog-info.yaml
annotations:
 backstage.io/kubernetes-id: nationalparks-py
 backstage.io/kubernetes-namespace: div

For k8s plugin to get the desired entity's k8s resources the following label should be added to the resources 'backstage.io/kubernetes-id': nationalparks-py
A custom label selector can also be added which will then be used by Backstage to find the resources. The label selector takes precedence over the id annotation.
'backstage.io/kubernetes-label-selector': 'app=my-app,component=front-end
In order to use k8s plugin to get the resources for Topology view, the above annotations/labels should be in place.
Enable additional tab on the entity view page
// packages/app/src/components/catalog/EntityPage.tsx
import { TopologyPage } from '@janus-idp/backstage-plugin-topology';

const serviceEntityPage = (
  <EntityPageLayout>
    // ...
    <EntityLayout.Route path="/topology" title="Topology">
     <TopologyPage />
    </EntityLayout.Route>
  </EntityPageLayout>
);

To Do:

[x] Add a dropdown cluster filter in the toolbar
[x] On selecting a cluster from the filter only the resources of that cluster should be shown
[x] Add a toolbar in topology view
[x] Show error (if any while fetching clusters/resources) similar to k8s plugin

cc: @invincibleJai

Please change the commit messages (not the PR title, that doesn't work) according to: https://github.com/janus-idp/backstage-plugins#requirements
Otherwise the release process won't be able to generate a proper changelog and release.

Thanks @divyanshiGupta, lint and tests need to be fixed PR jobs are failing

Thanks @divyanshiGupta, lint and tests need to be fixed PR jobs are failing

Yes, working on to fix those :)

@divyanshiGupta UI breaks for me in TopologyViewWorkloadComponent.tsx
k8sClusters is an empty list as below and we are trying to access currentK8sCluster (0) index
clusters: []
errors : []

const currentClusterErrors = [
    ...k8sClusters.errors[currentK8sCluster],
    ...(k8sResponseError ? [{ message: k8sResponseError }] : []),
  ];

@divyanshiGupta it flicker as well at regular interval

@divyanshiGupta it flicker as well at regular interval

It'll look good if we remove the padding below the filter bar

in the dark theme empty state doesn't look as expected and will be good to use backstage warning panel over pf here to show error https://backstage.io/docs/reference/core-components.warningpanel/

@invincibleJai Have fixed the above issues except for the dark theme not being applied to the empty state.
https://user-images.githubusercontent.com/20724543/224060781-ff15da99-5358-45c5-a3d0-10ee9e6d65f2.mov

/lgtm


Edited Display to show Payment field.

Pull Request Test Coverage Report for Build 188

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.042%

Totals

Change from base Build 187:
0.0%

Covered Lines:
1157

Relevant Lines:
1927

💛  - Coveralls


[Accessibility]A11y_VSCode_KeyboardShortcuts_ColorContrast:Color contrast ratio is less than 4.5:1 for the placeholder and commands when the focus is over it.

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
MAS Violated : MAS 1.4.3
Tools Used : Color Contrast Analyzer
Repro Steps:
1.Launch VS Code.
2.Navigate to Settings icon in Activity Bar->Press Enter->Select "Keyboard Shortcuts" from dropdown
3. Open Color Contrast Analyzer.
Actual
Color contrast ratio is less than 4.5:1 for the placeholder and of the shortcut commands when focus is over it in Quiet Light, Kimbie Dark and Monokai theme.
Expected:
Color contrast ratio should be more  than 4.5:1 for the placeholder and all the contents that are visible on the screen.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
The low vison users will not be able to view the content properly.
MAS Reference:
MAS 1.4.3 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}
Attachment for Reference:

Does this issue occur when all extensions are disabled?: Yes

Dup of https://github.com/Microsoft/vscode/issues/52593


Remove the 'state_change_requires_restart' flag for the TA

Description
Remove the 'state_change_requires_restart' flag in app.conf for the TA
Motivation and Context
This flag is marked as true which is forcing a restart at the install time, this blocks for the TA to be SSAI compatible.
How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

Hi @btorresgil, I noticed state_change_requires_restart flag explicitly set to true. And this is a reason blocking the TA to be SSAI compatible as it is forcing a restart at the time of installation.
If this flag exists intentionally, please feel free to decline this PR.

Hi @sjukanti-splunk , thanks. I'm not sure the consequences of changing this, so will have to do some research and testing. Please let us know if you have any insight as well.
Thank you!

Thanks @btorresgil
Some more relevant information -
This setting forces Splunk to restart when this app updates which isn't necessary as Splunk is already able to make this determination. In addition this setting causes rolling restarts on indexer cluster topology causing unnecessary downtime.

Hi @btorresgil, Any updates on this one?

Hi @btorresgil, gentle reminder on this PR.


RaspiBlitz Tor WebUI: Opening Mempool.space does not work (redirects to local IP?)

Hi everyone,
when accesing the Raspiblitz WebUI of version 1.8.0.c via Tor and then heading to
-> Apps -> Mempool.space -> "Open"
It opens a "about:blank" page.
I think it maybe tries to open the local Mempool.space IP instead of the Tor hidden service address?
Could the Raspiblitz Web UI, when accessed over Tor, automatically recognize that it is accessed over Tor and redirect to the hidden service of Mempool.space instead of the (allegedly) local one?

Marked for v1.10 to check all WebUI services with Tor again

Added a detection if the url ends with ".onion"
If it does, the "Open" buttons opens the TOR url, otherwise the local ip

This should work with 1.9.0
Closing this for now, if it doesn't work, please re-open.


Updated the rain gauge and moved temp/hum/temp+hum from Weatherwidget to TemperatureWidget

Rain gauge
Updated the rain gauge. It rained so I could work on it :-)

show correct values from MQTT
show 1 decimal
changed icon

Temperature
Moved temp, hum and temp + hum from WeatherWidget to TemperatureWidget.
This uses the GenericWidget and adds icons.
Barometer is still in WeatherWidget due to its own icons.

This widget is now showing the correct values.
I noticed a strange thing however.
My virtual rain gauge from Weather Under shows a "normal" value for the rain, 2.0mm in the example in Domoticz and also 2.0 in the MQTT svalue2.
The MQTT stype is WWW.
My rain gauge hardware device (https://www.weerstationkopen.nl/accessoires-weerstations/homewizard/homewizard-regenmeter-ts906) however shows 2.8mm in Domoticz, but 1528.8mm in the MQTT svalue2.
The value in Domoticz is the the new value (1528.8) minues the previous value (1526).
The MQTT stype is TFA.
I think the only way to solve this is by changing the MQTT message.

The rain icon (opacity) is used for the rain gauge.

Thanks, nice work!
Regarding TFA stype, I think you're right, unless this 1536 value is a constant (like a calibration offset) that we could get from the JSON once and for all. If it really is just "previous" then I think all we can do is requesting a change in Domoticz.

Just saw that the humidity only device is not working as it should (it now shows as a temp icon).
Let me have a look at this so I can update the code before you accept this pull request.

Ok thanks for updating this, nice work!

Oh by the way, in the future please use the original name of the icons from material.io, this makes it easier to figure out what they look like when reading the code, and whether an icon is already used when adding new ones :)

Will do :)

A suggestion - the temperature icon is now a Sun - that's how I interpret it ;) is it an idea to change it to a thermometer like icon - something like in Domoticz default theme? Now it is confusing, a bit, to see the cloud icon for the Weather Widget next to the sun icon of the Temperature Widget

Nice find @Sneeuwtijger! The license seems OK and they have extra stuff on top of the Google icons, like this thermometer icon. Given that it's also provided as npm package, I might consider swicthing over to just using this with the provided css. It would make Reacticz build much larger though (the eof font file is 262Kb, the svg file is 2Mb). I'll give it some thought.


Fix: Incorrect context

The context provides a contradictory explanation for the compilation error in the Trait quiz as it is mentioned in the chapter that default implementation is supported.

Hi, thanks for noticing. Default trait impls are actually possible since recently, thus I think this quiz (and the section) deserve a deeper refactor


stdbuf: make build more reliable and allow installation using Cargo

Now instead of trying to finagle Cargo into giving us a shared library that we then have to find and inject into anything called by stdbuf, we just generate the library on the fly by embedding it into stdbuf.  This allows us to install stdbuf using Cargo, so now everything can be built using just Cargo (yay).
I think this is enough that we can close #1104.

Also note that this means we can now go on crates.io.

that's great, sadly building on windows with current rust is still being a bit messed up

How are you building?  I just built it on Windows.

rustc 1.22.1 (05e2e1c41 2017-11-22)
building fine currently
maybe I had problem before because I've used to run cargo update or something and new win32 crate has serious changes

Ah okay.  I was having issues earlier because I forgot unix was a default feature.

Hi!
Cloning the repo and installing using cargo install now works fine. Good work!
Any ideas why
cargo install  --git https://github.com/uutils/coreutils uutils

might fail?
Backtrace
It is hard for me to parse, but I think it reports an issue in the build.rs of stdbuf.

Which version of the compiler are you using?  If it’s repeatable something may have changed in Cargo.

@bugabinga sorry it has taken so long to respond.  Interestingly, this issue only seems to happen when installing like cargo --git https://github.com/uutils/coreutils uutils.  If you clone the repository and run cargo install from there, it seems to work just fine.

@bugabinga from looking at Cargo bugs, it may be related to something like this.

@bugabinga sorry it has taken so long to respond. Interestingly, this issue only seems to happen when installing like cargo --git https://github.com/uutils/coreutils uutils. If you clone the repository and run cargo install from there, it seems to work just fine.

Yes, I was aware. Sorry for not mentioning that.
The bug you linked gives some clues , so I will test some more later and report back.


ActivityInsightOaFile Importer

The importer will import an ActivityInsightOaFile if there is a 'POST_FILE' with a 'DOC' (location) for a publication in Activity Insight.  It will not import a file if a publication is already open access in RMD.  This PR also removes the checksum field for ActivityInsightOaFile since it isn't needed.
I added the tests for this importer to the end of spec/component/importers/activity_insight_importer_spec.rb.  This file is getting so large, it's hard to know where to put things.  It may be due for a refactoring (along with the importer).  I think it covers everything it needs to, though.
closes #635

I totally agree that this stuff is very much due for refactoring, though I'm not even quite sure how I'd approach that. I like having this amount of end-to-end test coverage for the import processes since their behavior is complicated, and it's really important to verify that it's absolutely correct. I'd be a little nervous if we didn't have something like that.
Maybe a more manageable way to approach these tests would be to have a single, huge, annotated XML fixture that covers all of the different permutations of data and then just have one simple test scenario that just says, "when I import this huge fixture, all of the correct data should end up in the database." Managing such a fixture file might be easier than managing the test code with so many nested contexts. If the importer was less monolithic, then maybe I'd feel better about trading off some of the integration test coverage for unit test coverage.
As for refactoring the importer itself - it clearly has a lot of different responsibilities, and we're going to be piling on more. Attempting a little bit of refactoring as we go might be a good idea. That said, I don't know any particular patterns for refactoring something like this. We could move most or all of the data mapping stuff into the ActiveRecord models, I suppose  - i.e., a lot of Publication.create_or_update_from_ai_publication kinds of methods. Maybe extract an Activity Insight API client? Maybe add some business logic layer in between the layers that handle the mechanics of retrieving data from AI and the mechanics of persisting it to the database? The logic that will be involved in kicking off this new workflow should probably be invoked from this importer, but we might want to wrap it up in its own service object or something like that.
Those are just the best vague suggestions that I can think of - things to possibly keep in mind if you see a good opportunity to experiment with implementing any of them.
I think what you did here looks fine for getting started though.


RC Spot-Check Test: Circuit Construction Kit: DC 1.3.0-rc.3

RC Spot-Check Test
Mentions: @KatieWoe @Nancy-Salpepi @kathy-phet @arouinfar @matthew-blackman
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index
link to phet-io zip file

Test Matrices
General Test:

[X] Tester = NS, Platform = macOS 13.2.1 + safari 16.3, some Win10 + chrome/FF, Time = 2hrs
[ ] Tester = , Platform = , Time =

PhET-iO Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Additional Features Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Features included

[x] PhET-iO
[x] Alternative Input (just deleting a selected element)

[ ] UI Sound
[ ] Sonification
[ ] Description
[ ] Voicing

Focus and Special Instructions

This is a minor spot check for issues reported in https://github.com/phetsims/qa/issues/908. This is the second RC test after https://github.com/phetsims/qa/issues/908 (RC.2 was skipped since it was autogenerated in another task).
Issues to Verify
These issues should have the "status:ready-for-review" label. Please close any issue that is no longer a problem in RC.3

[x] https://github.com/phetsims/circuit-construction-kit-common/issues/971
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/979
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/980
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/981
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/982
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/983
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/984
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/985
[x] https://github.com/phetsims/circuit-construction-kit-common/issues/986
[x] https://github.com/phetsims/studio/issues/295

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test some query parameters. (See QA Book for a list of query parameters.)
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.
As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

QA is done.
(I added all my time to one section)

Excellent, thanks! It looks like we only got one studio cherry-pick, so I'll work on RC.4 with a fix for https://github.com/phetsims/circuit-construction-kit-common/issues/986.  Glad you discovered it, thanks!


Make code window title bigger / more colorful / with icons

Usually, I have 10 VS code windows running -- one per repo (some-server, some-ui) and k8s context (sandbox, production) --  each window runs on its own Desktop (Mac). When re-arranging the windows -- or flicking back and forth between them, it'd be nice if the window title was bigger -- or if I could add a unique color or icon for quick differentiation.

please checkout the Peacock Extension

Amazing, thank you!


FlutterForegroundPlugin is  private, can't be create by Generated file.

FlutterForegroundPlugin is private,  but flutter will  generated  registrant  file. here can't be created .

Same issue here.  Could this plugin be updated?

Use this one until the version is updated
flutter_foreground_plugin:
git:
url: https://github.com/jja08111/flutter_foreground_service_plugin.git
ref: 8a09c7b0aeb9d31204147fe6ee126c8a52471e3a


Use isInToday() as opposed to isToday()

Date objects represent a moment in time. They do not represent "a day" or "a date" as shoul dbe handled as such to prevent misconceptions. In the comparison functions for days, a moment should be in that day and not equal to it.
Proposal:
func isToday() --> func isInToday()
func isYesterday() --> func isInYesterday()
func isTomorrow() --> func isInTomorrow()
func inSameDayAsDate() --> func isInSameDayAsDate
This also aligns with the Cocoa functions for NSCalendar.

Todo: include in upgrade docs & maintain backward compatibility.

Fixed in v3.0.0


BUG: Cepstrum not computed correctly in vocalpy.spectral.sat

Describe the bug
vocalpy.spectral.sat is a translation to Python of the SAT code.
SAT uses the matlab function rceps to compute the cepstrum. As indicated in the pseudocode in the Matlab docs, this is done by computing the inverse FFT of the log of the magnitude of the spectrum. This is basically the matlab version of the algorithm described in the book they cite:

The SAT code specifically uses one of the two sets of spectra computed for a multi-taper spectrogram.
from line 116 of SAT_sound.m
                    window1=window.*tapers(:,1);
                    window2=window.*tapers(:,2);
                    % compute the cepstrum:
                    if any(window1)
                        tmp=rceps(window1);
                    else
                        tmp=zeros(length(window1),1);
                    end

We correctly use the fft of window1; in our code it becomes spectra1.
But what we do not do is take the absolute value of spectra1.
https://github.com/vocalpy/vocalpy/blob/8b85eed0dee76e3aa47599dd99f3fb7f6fc3ccbe/src/vocalpy/spectral/sat.py#L113
    log_spectra = np.log(spectra1, where=spectra1 > 0)
    cepstrogram = np.fft.ifft(log_spectra, n=n_fft).real

And this actually leads to pretty big differences in values.
From an interactive session:
>>> cepstrum = np.fft.ifft(np.log(spectra1))
>>> cepstrum_abs = np.fft.ifft(np.log(np.abs(spectra1))
>>> cepstrum[0, :10]
array([-5.88668039,  0.03902181,  0.25015098,  0.14409216,  0.22280241,
        0.10110034,  0.14784462,  0.14013646, -0.01752208,  0.01025931])
>>> cepstrum_abs[0, :10]
array([-5.88668039,  0.21275828,  0.25227263,  0.20196257,  0.13223225,
        0.10026057,  0.16990165,  0.08894541, -0.00986346,  0.07404688])

I think this is because np.log behaves differently for complex values

For complex-valued input, log is a complex analytical function that has a branch cut [-inf, 0] and is continuous from above on it.

Since we don't use np.abs to get the magnitude, we're getting the behavior of np.log for the complex-valued FFT that we compute.
So what we should do to correctly replicate rceps is to take the absolute value of that first set of spectra.
As further confirmation, python-acoustics does just that:
https://github.com/python-acoustics/python-acoustics/blob/99d79206159b822ea2f4e9d27c8b2fbfeb704d38/acoustics/cepstrum.py#L146
    spectrum = np.fft.fft(x, n=n)
    ceps = np.fft.ifft(np.log(np.abs(spectrum))).real

@ralphpeterson just a heads up that this might affect you if you are using SAT features, namely goodness of pitch. I will go ahead and make this quick fix and then release a new version

Nice catch, thanks for the quick fix!
Have we compared vocalpy.spectral.sat outputs to SAT outputs using the same dataset?

We haven't, I have definitely thought about it.
https://github.com/PaulEcoffet/birdsonganalysis/issues/1#issuecomment-376214452
https://github.com/vocalpy/sappy/issues/4
https://github.com/vocalpy/vocalpy/issues/81#issue-2013437680
If I were to do it now, I would use the "zebra-finch-wav" data in the "source" data we use for testing, here: https://osf.io/45brw/, which is taken from https://github.com/PaulEcoffet/birdsonganalysis/tree/master/songs.
I think the subset of songs that I put in the source data were originally on the SAP site.
We'd need:

[ ] a Matlab script that runs SAT on all those songs and then saves the extracted features specifically, e.g. to .mat files we can load with scipy.io.loadmat
[ ] a Python script that runs vocalpy.feature.sat on the same data and saves the features. Easiest way here might be to run vocalpy.feature.sat.similarity_features then dump the returned xarray.Dataset to zarr
[ ] unit tests in tests/test_feature/test_sat that at least test whether the output of vocalpy.feature.sat.similarity_features has changed, i.e. a kind of regression test

I'm in the middle of renaming/rewriting the Audio class as a Sound class that can properly handle multi-channel audio (see #90). But once that is merged in this would be do-able.


Update license for Safe Ecosystem Foundation

Coverage remained the same at 88.131% when pulling ec07bfcc10347e919d5ec4927be6b1e5bf1ca703 on update-license into ca5fb5c7c0d22df6a99fab604b116880ec4ee29a on master.


Watch backend task

When setting up the template with +handler, no task is created to run/watch the ring server. Is this intentional?
At the moment, I add the lein-ring plugin to solve it.

Happy to accept a PR for this.

Closing as we will no longer support +handler. We're focusing on this being a purely client-side only template.


Unavailable MUGEN checkpoints

Hi, the dropout link for the MUGEN checkpoint seems to be unavailable now. Could you please share another link? Thanks!

Hey Justin, thanks for pointing that out! Please find the updated links below!

VQGAN: https://drive.google.com/file/d/1H-l80_zOYtIj2g7IonjRej00B9LeleRi/view?usp=sharing
Transformer: https://drive.google.com/file/d/1uZICD3DgbRlto__mEEY6i0i9n20eRLcV/view?usp=sharing

Let me know if they work for you!

Hi Songwei, thanks for your reply! The updated links are working now! They really help me a lot :)


Short-hand name for containerized-data-importer

Code change to rename containerized-data-importer to cdi.  This has been done because of the two main reasons.  First, the "image" name in the scripts to golden container generation does not take hyphen '-'.  Second, the names of docker files to generate containers are plain juxtaposition of the form "Docker-".  The existing RPMS have long names, such as containerized-data-importer-api, containerized-data-importer-uploadserver, etc.  Therefore, the docker file names become really long and look clumsy.
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

The PR renames containerized-data-importer to cdi for compatibility with golden container scripts.
Change Log

Rename containerized-data-importer to cdi in the Spec file
Update the signature in corresponding file

Does this affect the toolchain?

NO
Test Methodology

Local build

@PawelWMS and @jslobodzian - I guess my ID does not appear in the list of approved engineers having "write access" to this repository.  So, may I request one of you to please merge the PR?


When I use particle system, the particle image is always displayed

when I use the particle system in my project like this

the wind2.png will always display  in the current scene（The red arrow is the wind2.png）

I don't know how to fix this problem

Use the forum if you want help on how to use Cesium.
Github should be used only for bug report or feature request...
Anyway, you have multiple way to hide your particles, and you would have found out if you read the Documentation
you can remove your particle system from the entity list
var particleSystem = scene.primitives.add(new Cesium.ParticleSystem({
//...options
}));

 scene.primitives.remove(particleSystem);

you can just hide the particles using :
particleSystem.show = false

I Think you are talking about this ?

如果您需要有关如何使用铯的帮助，请使用论坛。
Github应该仅用于错误报告或功能请求...
无论如何，您有多种方法可以隐藏粒子，具体取决于要实现的目标。文献资料
您可以从实体列表中删除粒子系统
var particleSystem = scene.primitives.add(new Cesium.ParticleSystem({
//...options
}));

 scene.primitives.remove(particleSystem);

您可以使用以下方法隐藏粒子：
particleSystem.show = false

I Think you are talking about this ?
#7511
It is a bug, and it has not been fix yet from what I see as it also appear in the Sandcastle when zoom out

我认为您在谈论这个吗？
＃7511
这是一个错误，根据我的观察，它尚未得到修复，因为缩小时它也出现在沙堡中

yes！I am referring to the problem #7511，

I Think you are talking about this ?
#7511
It is a bug, and it has not been fix yet from what I see as it also appear in the Sandcastle when zoom out

I Think you are talking about this ?
#7511
It is a bug, and it has not been fix yet from what I see as it also appear in the Sandcastle when zoom out

yes！I am referring to the problem #7511，

Thanks for finding the relevant issue @Crocsx ! And thank you for confirming @Jonny0601. I'm going to close this as a duplicate and move the discussion into the above linked issue.


During handling of the above exception, another exception occurred:

While running the code the i get the following error in the Terminal

Fix in PR resolved this for me

Fix in PR resolved this for me

can you explain what id PR means ?

See line 164 here https://github.com/graiz/cbot/pull/1/files. This change fixed issue for me.

Fixed with recent change.


Bugfix/corbett/some leaks

@corbett5 could you address Marty's comments? The additions would be: tests for offsets, and update to changelog regarding the fix.

Is there a reason the Travis build seems stalled?

@corbett5 Todd is looking into this. For some reason we're not getting the number of concurrent builds that we've paid for.  All LLNL projects are experiencing the log jam.


Account Setup Rework

This is a rebase of @daquexian 's GSoC Account Setup work. See #2530

Mozilla ISPDB autoconfigure
SRV based autoconfigure
Microsoft Autodiscover
Google OAuth 2.0
Outlook OAuth 2.0
Material design for Account Setup activities

While manually testing I've noticed that the manual setup has lost some IMAP settings so I probably need to look at that.
It would be good to get this into an beta sooner rather than later though.

@philipwhiuk, has there been any progress on getting this split up and integrated?

Could I perhaps take a look at this ?

I'm happy for anyone to take over this.

We'll probably end up rewriting all of the account setup code.

We'll probably end up rewriting all of the account setup code.


added Jacob-Morris.text

Put link to git hub in text file and the review questions and answers.

forgot to ad reviwer


sm64pc does not save savegame

I've compiles sm64pc with this command:
gmake OSX_BUILD=1

Then made the app bundle:
cd ~
~/go/bin/appify -name "SuperMario64" -icon ~/Downloads/mario64.png ~/sm64pc/build/us_pc/sm64.us.f3dex2e

The problem is, savegame is stored in file sm64_save_file.bin next to executable. Also sm64config.txt is created for input key mapping. But for some reason writing to folder ~/SuperMario64.app/Contents/MacOS/ is not possible. How could I fix this?
Also, don't know how to debug or view the terminal messages which would be shown if I just run the command sm64.us.f3dex2e directly.

This is only an issue with the Master branch. In the Nightly branch, the savegame & config file location were changed to ~\Application Support\sm64pc. If you're still using the Master branch, you can get around the issue with the savegame & config files failing to create inside the app bundle by creating a shell script with the following contents, then point the CFBundleExecutable key in the Info.plist file at it instead of the binary:
#!/bin/bash
cd "${0%/*}"
./sm64.us.f3dex2e

Fixed on sm64pc repo.


[master] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

Cron. -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow

Codecov Report

Merging #154 (13d79db) into master (7495072) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   78.05%   78.05%
=======================================
  Files          18       18
  Lines         565      565
=======================================
  Hits          441      441
  Misses        121      121
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495072...13d79db. Read the comment docs.


setup build failed on ubuntu 18.04 server

python setup.py build
running build
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   filesystem
--   thread
--   system
--   date_time
--   chrono
--   regex
--   iostreams
--   atomic
CMake Deprecation Warning at cmake_modules/CreateLaunchers.cmake:48 (cmake_policy):
The OLD behavior for policy CMP0026 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances.  Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
src/vizdoom/CMakeLists.txt:13 (include)
-- Could NOT find GME (missing: GME_INCLUDE_DIR)
-- Using system zlib
-- Using system jpeg library
-- Using system bzip2 library
-- Using internal gme library
-- /usr/include
-- /usr/include
-- /home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/vizdoom/lzma/C
-- Could not find FMOD include files
-- Selected assembler: /usr/bin/as
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   thread
--   system
--   date_time
--   chrono
--   atomic
-- Fluid synth libs: /usr/lib/x86_64-linux-gnu/libfluidsynth.so
-- Found PythonInterp: /home/bhaskartrivedi/anaconda3/envs/worldmodel/bin/python (found suitable version "3.5.4", minimum required is "2.7")
-- Found PythonInterp: /home/bhaskartrivedi/anaconda3/envs/worldmodel/bin/python (found suitable version "3.5.4", minimum required is "3")
-- Using python library: /home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/libpython3.5m.so
-- Using python include: /home/bhaskartrivedi/anaconda3/envs/worldmodel/include/python3.5m
CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1628 (message):
No header defined for python-py354; skipping header check
Call Stack (most recent call first):
CMakeLists.txt:126 (find_package)
-- Could NOT find Boost
CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1628 (message):
No header defined for python-py35; skipping header check
Call Stack (most recent call first):
CMakeLists.txt:135 (find_package)
-- Could NOT find Boost
-- Boost library python-py35:
-- Could NOT find Boost
-- Boost library python35:
CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1628 (message):
No header defined for python-py3; skipping header check
Call Stack (most recent call first):
CMakeLists.txt:135 (find_package)
-- Could NOT find Boost
-- Boost library python-py3:
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   python3
-- Boost library python3: /usr/lib/x86_64-linux-gnu/libboost_python3.so
-- Found components for NumPy
-- NUMPY_ROOT_DIR    = /usr/local
-- NUMPY_INCLUDES    = /home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/site-packages/numpy/core/include
-- NUMPY_LIBRARIES   = /home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/site-packages/numpy/core/lib/libnpymath.a
-- NUMPY_API_VERSION = 1.15.4
-- Configuring done
-- Generating done
-- Build files have been written to: /home/bhaskartrivedi/WorldModel/doom-py-master/doom_py
[  0%] Built target lemon
[  0%] Built target arithchk
[  0%] Built target freedoom2
[  0%] Built target updaterevision
[  1%] Building CXX object CMakeFiles/libvizdoom_shared.dir/src/lib/ViZDoomGame.cpp.o
[  2%] Built target re2c
[  5%] Built target lzma
[  5%] Building CXX object CMakeFiles/libvizdoom_static.dir/src/lib/ViZDoomGame.cpp.o
[ 21%] Built target dumb
[ 30%] Built target gme
[ 31%] Built target qnan
[ 32%] Built target zipdir
[ 33%] Built target gdtoa
[ 97%] Built target vizdoom
[ 97%] Generating ../../../bin/vizdoom.pk3
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/vizdoom/../../bin/vizdoom.pk3 contains 583 files (updated 0)
[ 97%] Built target pk3
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp: In member function ‘bool vizdoom::DoomGame::loadConfig(std::cxx11::string)’:
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:743:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax erorr in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:743:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax erorr in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:757:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty key in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:757:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty key in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:784:30: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_buttons[i]<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:784:30: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_buttons[i]<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:789:26: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:789:26: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:815:30: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_variables[i]<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:815:30: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_variables[i]<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:820:26: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:820:26: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:837:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". "+=" is not supported for non-list properties. Line #"<<line_number<<" ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:837:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". "+=" is not supported for non-list properties. Line #"<<line_number<<" ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:846:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty value in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:846:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty value in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:871:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsigned int value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:871:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsigned int value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:888:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Float value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:888:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Float value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:953:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Boolean value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:953:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Boolean value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:983:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". (ASYNC)SPECTATOR || PLAYER expected instead of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:983:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". (ASYNC)SPECTATOR || PLAYER expected instead of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1012:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1012:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1017:18: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported key: "<<key<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1017:18: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported key: "<<key<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp: In member function ‘bool vizdoom::DoomGame::loadConfig(std::cxx11::string)’:
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:743:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax erorr in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:743:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax erorr in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:757:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty key in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:757:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty key in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:784:30: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_buttons[i]<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:784:30: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_buttons[i]<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:789:26: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:789:26: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:815:30: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_variables[i]<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:815:30: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value in lines "<<start_line<<"-"<<line_number<<": "<<str_variables[i]<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:820:26: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:820:26: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Syntax error in lines "<<start_line<<"-"<<line_number<<". Lines ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:837:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". "+=" is not supported for non-list properties. Line #"<<line_number<<" ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:837:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". "+=" is not supported for non-list properties. Line #"<<line_number<<" ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:846:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty value in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:846:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Empty value in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:871:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsigned int value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:871:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsigned int value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:888:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Float value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:888:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Float value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:953:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Boolean value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:953:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Boolean value expected insted of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:983:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". (ASYNC)SPECTATOR || PLAYER expected instead of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:983:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". (ASYNC)SPECTATOR || PLAYER expected instead of: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1012:22: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1012:22: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported value: "<<raw_val<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1017:18: error: ‘cerr’ is not a member of ‘std’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported key: "<<key<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
/home/bhaskartrivedi/WorldModel/doom-py-master/doom_py/src/lib/ViZDoomGame.cpp:1017:18: note: suggested alternative: ‘erf’
std::cerr<<"WARNING! Loading config from: ""<<filename<<"". Unsupported key: "<<key<<" in line #"<<line_number<<". Line ignored.\n";
^~~~
erf
CMakeFiles/libvizdoom_shared.dir/build.make:110: recipe for target 'CMakeFiles/libvizdoom_shared.dir/src/lib/ViZDoomGame.cpp.o' failed
make[2]: *** [CMakeFiles/libvizdoom_shared.dir/src/lib/ViZDoomGame.cpp.o] Error 1
CMakeFiles/Makefile2:178: recipe for target 'CMakeFiles/libvizdoom_shared.dir/all' failed
make[1]: *** [CMakeFiles/libvizdoom_shared.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
CMakeFiles/libvizdoom_static.dir/build.make:110: recipe for target 'CMakeFiles/libvizdoom_static.dir/src/lib/ViZDoomGame.cpp.o' failed
make[2]: *** [CMakeFiles/libvizdoom_static.dir/src/lib/ViZDoomGame.cpp.o] Error 1
CMakeFiles/Makefile2:141: recipe for target 'CMakeFiles/libvizdoom_static.dir/all' failed
make[1]: *** [CMakeFiles/libvizdoom_static.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
Could not build doom-py: Command '['make', '-j', '35']' returned non-zero exit status 2. (HINT: are you sure cmake is installed? You might also be missing a library. Try running 'apt-get install -y python-numpy cmake zlib1g-dev libjpeg-dev libboost-all-dev gcc libsdl2-dev wget unzip'
Traceback (most recent call last):
File "setup.py", line 88, in
include_package_data=True,
File "/home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/site-packages/setuptools/init.py", line 143, in setup
return distutils.core.setup(**attrs)
File "/home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/distutils/core.py", line 148, in setup
dist.run_commands()
File "/home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/distutils/dist.py", line 955, in run_commands
self.run_command(cmd)
File "/home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "setup.py", line 63, in run
build_func()
File "setup.py", line 41, in build_linux
build_common('so')
File "setup.py", line 29, in build_common
subprocess.check_call(['make', '-j', str(cores_to_use)], cwd='doom_py')
File "/home/bhaskartrivedi/anaconda3/envs/worldmodel/lib/python3.5/subprocess.py", line 271, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-j', '35']' returned non-zero exit status 2

Same issue for me... any progress?

Same issue for me... any progress?

Nope i switched to other work..

It appears other libraries are updating around doom-py with changes and now doom-py won't build. This error above is caused by the inclusion order of

If you add
#include <iostream>
at the top of ../doom_py/src/lib/VizDoomGame.cpp  it will get further in the build.
This is just the first problem. It will then fail because boost library has updated as of 1.65+ and no longer has boost::python::numeric module it has been replaced by boost::python::numpy.  The contents of these modules has changed so its not a simple replacement. This looks like a rabbit hole!
Current error is
/ViZDoomGamePython.cpp:29:26: **error**: ‘boost::python::numeric’ has not been declared

If you are using boost v1.65+ take a look at the code changes here. Worked for me.
https://github.com/robin7g/doom-py/pull/1/files

If you are using boost v1.65+ take a look at the code changes here. Worked for me.
https://github.com/robin7g/doom-py/pull/1/files
@robin7g Thanks. This worked for me too. But when I import doom_py, I get the following error:

from doom_py.vizdoom import *
ImportError: /home/x/package/doom-py/doom_py/vizdoom.so: undefined symbol: _ZN5boost6python6detail11init_moduleEPKcPFvvE


Performance issue when using scenario viz elements

Description
Using many scenario viz elements, like scenario selectors, will slow down the page's rendering. In real cases, this loading on my local machine took some seconds.
This could stop the adoption of scenario viz elements for the community.
We should aim to make loading times faster and improve the performance when using scenario viz elements.
Here is a small example that tries to showcase this behavior. That might not work on your local machine.
# Import necessary libraries
import pandas as pd
import taipy as tp
from taipy import Config, Scope, Frequency

import datetime as dt

# Function to run a Dataiku scenario
def run_something(**kwargs):
    datetime = dt.datetime.now()
    date = dt.date(2018, 1, 1)
    int_var = 10
    string_var = "String"
    return kwargs

data = {"toto": [i for i in range(10_000)],
        "titi": [2*i for i in range(10_000)],
        "tata": [4*i for i in range(10_000)]}

def create_dn(id):
    return Config.configure_data_node(id=id, default_data=data)

# Scenario and task configuration in Taipy
scenario_task_cfg = Config.configure_task(
    id="scenario_task",
    function=run_something,
    input=[create_dn(f"input_datanode_{i}") for i in range(10)],
    output=[create_dn(f"output_datanode_{i}") for i in range(10)]
)

scenario_cfg = Config.configure_scenario(
    id="scenario",
    task_configs=[scenario_task_cfg],
    frequency=Frequency.MONTHLY)

scenario_1 = None
scenario_2 = None

data_node = None

# GUI Markdown content
scenario_md = """
<|navbar|>

# Compare scenarios
<|1 1|layout|
<|{scenario_1}|scenario_selector|>

<|{scenario_2}|scenario_selector|>

<|{scenario_1}|scenario|>

<|{scenario_2}|scenario|>
|>

# Data Nodes

<|1 1|layout|
<|{data_node}|data_node_selector|>

<|{data_node}|data_node|>
|>

"""

pages = {"home":"<|navbar|> Nothing here",
         "vizelements":scenario_md}

# Main execution block with GUI setup
if __name__ == "__main__":
    tp.Core().run()
    [tp.create_scenario(scenario_cfg,
                        name=f"scenario_{i}",
                        creation_date=dt.datetime(2024, i, 7))
                    for i in range(1, 11)]

    tp.Gui(pages=pages).run(title="Bug replication", port=3248)

Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
[ ] Ensure any change is well documented.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

I've improved a bit by removing the calculation of default value of the lov of selectors but it doesn't gain much (nothing really visible on my  PC.
https://github.com/user-attachments/assets/d7158a0a-6d47-4a47-ac9a-c972d16684d6


Can multiple empty directories be supported to be displayed separately, such as showing mount points?

ephemeral_storage_pod_usage
Can multiple empty directories be supported to be displayed separately, such as showing mount points?
Like ephemeral_storage_container_volume_limit_percentage.

Yes, to see this in action, see https://github.com/jmcgrath207/k8s-ephemeral-storage-metrics/issues/85#issuecomment-2075131046


pause operation does not work

Interesting feature to add, but doing this on server... 🙊

pause operation is actually one of the moves that the bot can make to bring its speed to zero, for hiding under virus.


Provide ExpiresIn from RefreshTokenHandler.TokenRefreshed event

If I want to use this event to update my ClaimsPrincipal I don't have expires in to save it.

PR?


All examples should be easy to run

Probably a script npm run backend-services which runs the Docker instances & runs the db migrations & then a npm run dev for running the js dev server.

I know this has been closed but just to feed in:
We've lost so much time to local dev/cli tooling with docker.  I would really strongly steer on the side of just use the standard tools yourself vs us putting magic in npm commands.


Sync CborTag with IANA

Describe the feature you'd like
Created a code generator found in https://github.com/mofosyne/iana-headers/tree/main/cbor which would generate https://github.com/mofosyne/iana-headers/blob/main/cbor/c/cbor-constants.h
Considering if we can add this capability to this project as well. Code generator would of course need to be adapted to TypeScript.
https://github.com/input-output-hk/cardano-js-sdk/blob/88248ef21f11b3f38564b6cddd642c1c91aec66b/packages/core/src/Serialization/CBOR/CborTag.ts#L4-L14
Noticed that constant macros is not in all caps. Is this typical for typescript projects?
Describe alternatives you've considered
No response
Would you be willing to implement it?

[ ] Yes, I will implement it.

Thoughts on this @AngelCastilloB ?

Closing this due to inactivity. Feel free to open a discussion if you feel this needs further attention @mofosyne


Is it possible to setup a Python Interpreter

I was wondering if it's possible to setup a python interpreter on RancherOS.
I have several RancherOS installation on my customers, I use then to deploy a simple app and also as a bastion host for remote access. I want Python to be able to put my RancherOS on ansible inventory and ping then as well.
RancherOS Version: (ros os version)
Latest
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
AWS, VMware, Baremetal

This can be done two ways:

Switch to a different console and install it with a package manager.
Run whatever requires Python in a container.

In most cases, number two will be the better solution. Can you describe your use case a little more?

Hello @joshwget , thanks for your response.
I need Rancher to communicate with Ansible, and Python is required for that.

@joshwget , I've switched to CentOS console and it's working fine. I'll close this issue.
Thanks

I'm trying to achieve this but something it's not quite working for me in order to be able to install python to be able to use ansible on RancherOS 0.7.1 I do:
#cloud-config
rancher:
  console: ubuntu

Which works fine then I ssh into the instance and install python and run my Ansible scripts however when I try to automate this last bit and install python from the cloud-conf.yml file it doesn't like it and it didn't even activate the ``ubuntu console for me, this is how my final cloud-config.yml looks like:
#cloud-config
rancher:
  console: ubuntu
runcmd:
  - apt-get update ; apt-get install python

How did you @bernardoVale manage to activate CoreOS console and at the same time install python? Do I have something wrong on my cloud-config script @joshwget?
Thanks,

I think I'm using the wrong version of RancherOS and it's not 0.7.1 as I thought looks like the readme file for the tag version 0.7.1 https://github.com/rancher/os/blob/v0.7.1/README.md#user-content-amazon it's wrong and point to 0.6.1 ami-934837e0 instead.
Going to double check and try with the 0.7.1 version ami-c62170b5

@zot24 The problem is with your runcmd. Check out #1284.

I see, I though strings where supported on 0.7.1 but it's on 0.8.0-rc1 👍
I have change it to and try:
#cloud-config
rancher:
  console: ubuntu
runcmd:
  - [ sudo apt-get update ]
  - [ sudo apt-get install python ]

The parts are comma separated for lists. This should do the trick.
runcmd:
  - [ apt-get, update ]
  - [ apt-get, install, python ]

Thanks that fix it just mention I needed to add the -y option to force the installation of python
#cloud-config
rancher:
  console: ubuntu
runcmd:
  - [ apt-get, update ]
  - [ apt-get, install, -y, python ]

you really should make your own console Dockerfile, and a custom service file - but I need to write some docs on this, and then we need to work towards making that process simpler.


CORS

I am trying to use the api, and tabulate the list for easy representation of availablity.
I am facing cors issue can we connect and fix the same.
link to repo
Let me know if we can work together thanks.

@pxthxk


Build FPsim-Nigeria

Build out with Nigeria DHS and PMA (possibly only Kano and Lagos).
Document hours of coding time for future use
Test new autocalibration
Create context-calibration tutorial (full description in separate issue #201 )

Closing out as we will have a full-fledged v2.0 calibration workflow in 2025.


NIFI-7539: When capturing diagnostics information, capture a thread d…

…ump once and then provide this information to ProcessorNode when capturing active threads. Previously, each processor captured a thread dump itself. When this is done thousands of times it can result in a very long delay.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

+1 Looks good

Thanks for reviewing @bbende! Merged to master.


Impl socket htonl

For #1176
Add socket method htonl.

Hi @SeungUkLee this change looks good! I had one question about using a library for the htonl function.


[otbn/dif] Add Software Checklist

This documents the stability and progress of the OTBN DIF.

I assume we'll then update the status for all fields once we've completed everything necessary for S1?

Yeah, that's been the approach of software so far - that we tick everything off in the review meeting together.


a 0.75XCH Lesson, setting the xch_target_address

Describe the request
It would be nice if the machinaris gui warned that the xch_target_address in the config is not recognized. Or provided a separate section in the /pools summary, a sample mockup below.
Additional comments
I won 2 blocks while pooling and was notified about the win. Checking the wallet I tried to find the transactions, which I could not. I then checked the config.yaml xch_target_address as described in
https://blog.pool.space/how-to-find-your-0-25xch-after-winning-a-block-in-the-pool-fc61d0bee5c5
this address was not one I recognised, and I believe that the first time I installed chia on my virtual machine, it created a default wallet, which I must have deleted, when I imported the mnemonics of my laptop wallet that I had been using before getting my vm up and running, then when I moved over to machinaris and used that config.yaml the xch_target_address was moved across.
https://www.chiaexplorer.com/blockchain/address/xch1tlxkr0ex50atzuphd729pkrxqj476gkkfq5uz8f7092fy92zqmrqdtsasf
guess that is a .75 lesson, my pool only knew about the last two, and notified me that I had won those blocks. So when I had a look and investigated, thats when I realised that those wins were not showing in the wallet.

Hi, sorry to hear that you had such a misconfiguration.  Good suggestion for a warning.
FYI, your screenshot with two 'Chia' tabs at the top indicates a further misconfiguration with your Machinaris installation.  Please reset the Machinaris databases.  If the duplicated 'Chia' tabs re-appear after 15 minutes, then the misconfiguration persists.

Warning has now been added to the "Settings | Farming" page if the config.yaml file contains a *_target_address value which is not found in the configured hot/cold wallet addresses.  Thanks for the suggestion.

Machinaris version 0.8.0 has now been released with support for Chia 1.4.0.  Thanks!


Warning componentWillMount has been renamed

using V1.2.0 I have this warning with React V16.9.0.
Is it possible guys to fix that ?
Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

Move code with side effects to componentDidMount, and set initial state in the constructor.
Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: ThroughAgent, ThroughAgent.breadcrumbs

alredy done will be released soon

How soon is soon? : ) Awaiting release eagerly. 👍

Already released. I will post future updates on my twitter/facebook page.


It is possible cache the bloom filter to NVMe? (support filters larger than 2^38 bytes)

libfilter is very fast.
I have about 2^36 items to add in bf, it is possible cache the bloom filter to NVMe?

You could use mmap in the C interface to allocate a libfilter_region's block pointer, I suppose. If you just accessed the NVMe space needed on each read or write, I suppose the OS might cache it anyway.
Thoughts?

You could use mmap in the C interface to allocate a libfilter_region's block pointer, I suppose. If you just accessed the NVMe space needed on each read or write, I suppose the OS might cache it anyway.
Thoughts?

I will have a try.
Thank you!

Looking more carefully at the code, I don't think it supports filters larger than 2^32 bytes. I'll take this as a feature request.

I found libfilter auto cache if the bloom filter is larger than available memory? However the speed turn very slow.

Hi jbapple,
I upgraded my pc, and now I have 128GB memery.
However I hash about 2^34 items(fpp=0.0001, calcualte need about 5x GB memory), and it just used about 3xxxMB memory and the speed turn very slow.
It is limit the max items?
tahnks.

When I run the following, the correct amount of memory is allocated on my machine:
BlockFilter::CreateWithNdvFpp(1ul << 34, 0.0001)
How much memory is allocated on your machine if you just call this factory method and then return from main? What tool are you using to measure the amount of memory allocated?

When I run the following, the correct amount of memory is allocated on my machine:
BlockFilter::CreateWithNdvFpp(1ul << 34, 0.0001)
How much memory is allocated on your machine if you just call this factory method and then return from main? What tool are you using to measure the amount of memory allocated?

Sorry it is my program's bug. needbytes forgot to change unsigned to uint64_t 😂
thank you!

Hi jbapple,
Sorry trouble you again.
I use 1 thread libfilter_block_find_hash(), In my pc about 180M hash/s.
But when I use 4 threads, the speed drop down to about 90-100M hash/s.
Do you have some suggestion?
Thanks.


[mpir] Add instructions for adding MPIR in CMAKE project

Is your feature request related to a problem? Please describe.
For most of the packages after the installation a brief instructions for package usage appear, e.g.:
> vcpkg install tiff:x64-windows
.
.
.
tiff is compatible with built-in CMake targets:

    find_package(TIFF REQUIRED)
    target_link_libraries(main PRIVATE TIFF::TIFF)

tiff provides pkg-config modules:

    #  Tag Image File Format (TIFF) library.
    libtiff-4

However, for mpir:x64-windows it is not the case, it simply says the elapsed time and stops the installation.
So it is very unclear how to include this package in a CMake project.
I spent a lot of time and found the following suggestion:

When running cmake, always add the following option: -DCMAKE_TOOLCHAIN_FILE:FILEPATH="...\scripts\buildsystems\vcpkg.cmake" where ... is the vcpkg directory.
Add the following lines to the CMake file:

find_package(PkgConfig REQUIRED)
pkg_check_modules(gmpxx REQUIRED IMPORTED_TARGET gmpxx)
target_link_libraries(main PkgConfig::gmpxx)

So I have three questions.

Should these two things be enough for everything working correctly?
If so, could these lines be added somehow into the installation process, so that they popped up after vcpkg install mpir:x64-windows running and the used could read them and have an idea how to include MPIR into their project?
If the answer to the first question is yes, why it does not work for me? I am constanly getting an error, and it seems to be caused by pkgconf being not found by cmake (I described this issue in https://github.com/microsoft/vcpkg/issues/36075). Maybe there is a way to include MPIR in a CMake project without the complications induced by PkgConfig usage?

Proposed solution
Make the following lines appear each time someone installs mpir for Windows:
find_package(PkgConfig REQUIRED)
pkg_check_modules(gmpxx REQUIRED IMPORTED_TARGET gmpxx)
target_link_libraries(main PkgConfig::gmpxx)

In principle, it would be extremely nice if for every package there existed some minimum working CMakeFile somewhere in an accessible place.
Describe alternatives you've considered
No response
Additional context
No response

After I was able to get PkgConfig working, I still cannot import gmpxx.
Steps to reproduce (I am currently on Windows 10 Home):

Create a file C:\test\a.cpp with contents:

#include <iostream>
#include "gmpxx.h"
using namespace std;
int main() {
	mpz_class z("122345673432785234865278546");
	cout << z * z;
}

Create a file C:\test\CMakeLists.txt with contents:

cmake_minimum_required(VERSION 3.27)
project(aaa)
set(CMAKE_CXX_STANDARD 20)
find_package(PkgConfig REQUIRED)
pkg_check_modules(gmpxx REQUIRED IMPORTED_TARGET gmpxx)
target_link_libraries(main PkgConfig::gmpxx)
add_executable(main a.cpp)

Run C:\misc\vcpkg\vcpkg.exe install mpir, it runs successfully.
Run the command:

"C:\misc\vcpkg\downloads\tools\cmake-3.27.1-windows\cmake-3.27.1-windows-i386\bin\cmake.exe" C:\test\ -DCMAKE_TOOLCHAIN_FILE=C:\misc\vcpkg\scripts\buildsystems\vcpkg.cmake

It prints:
-- Building for: Visual Studio 16 2019
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.19045.
-- The C compiler identification is MSVC 19.29.30153.0
-- The CXX compiler identification is MSVC 19.29.30153.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: C:/misc/vcpkg/installed/x64-windows/tools/pkgconf/pkgconf.exe (found version "2.1.0")
-- Checking for module 'gmpxx'
--   Package 'gmpxx', required by 'virtual:world', not found
CMake Error at C:/misc/vcpkg/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPkgConfig.cmake:607 (message):
A required package was not found
Call Stack (most recent call first):
C:/misc/vcpkg/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
CMakeLists.txt:5 (pkg_check_modules)

-- Configuring incomplete, errors occurred!

Strangely enough, pkgconf.exe seems to be unaware of any packages:
C:\Users\user>C:/misc/vcpkg/installed/x64-windows/tools/pkgconf/pkgconf.exe --list-all

C:\Users\user>C:/misc/vcpkg/installed/x64-windows/tools/pkgconf/pkgconf.exe --list-package-names

Both these commands printed nothing.

pkgconf depends on environment variables or options to locate available modules. CMake handles that based iff you ask for modern CMake, by having cmake_minimum_required(VERSION 3.1) before project(...). Cf. https://cmake.org/cmake/help/latest/module/FindPkgConfig.html#command:pkg_check_modules.
vcpkg CI only tests gmp, and mpir is nearly unmaintained AFAIU.

Should vcpkg install gmp work on Windows?

Should vcpkg install gmp work on Windows?

Yes.

But still, mpir works if, instead of CMake project, I create an ordinary C++ project in Visual Studio 2019. How is it possible that there is no existing minimum working example of mpir working in a CMake project?


Fix IP reshuffling when add/remove duplicated hostname

Please provide a description of this PR:
Fix for https://github.com/istio/istio/issues/49809

Hi @krutsko. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@krutsko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
40a9d2cfd6c3ba6b325a2b591a35154342dd9ccb
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krutsko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3d627b2a34085f0d88600231a31ea851a9fb31ec
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krutsko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fb3730efbcb6986b1eb3383dd97591ce0d572cd1
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient

we need backport

hey all, 2 questions:
1.) Any idea what Istio release this will make its way into? We definitely want to get this fix deployed out asap, we've run into this a few times now in production.
2.) Is this a separate, ad-hoc fix than the DNS Autoallocate @howardjohn  is talking about in this comment? https://github.com/istio/istio/pull/45330#issuecomment-2143031350
If so, sounds like this will likely make its way into Istio sooner, so I won't have to wait for the revamp to get this fix. Is that accurate?

This is fixing a corner case, not that like https://github.com/istio/istio/pull/45330#issuecomment-2143031350 proposed. The ideal solution should be discusssed there


fixReducedOffersV1 still not covering all cases and book blocking (Version: 2.1.0)

Issue Description
Amendment fixReducedOffersV1 https://xrpl.org/resources/known-amendments#fixreducedoffersv1 is still not fixing all case where the order book is blocked
two cases have now been identified on mainnet.
Supporting Files

@lathanbritz, I'm disappointed but not surprised that I didn't fix all the ways that order books can be blocked.  I have something else I'm working on right now, but this issue is next on my list after that's done.
It would help a lot if you can identify a specific historic transaction that failed because of this blockage.  Of course you can only point at transactions that fail with a tec code.  So there may not be any such transactions on the network.  But being able to replay such a transaction might help me see the reason behind the blockage.  If you know of a transaction like that please mention it here.  Thanks.

@scottschurr rLtdxMMXPs21PYnnSiwm85EabdHDH4oVhi has blocked the USD book (its the one with the partially filled order), it does not have too  many tx

@lathanbritz that helps, thanks.  That's current?  Like that's the state of the book for, say, ledger 86325875?  Is there a way you can get the ledger index of the blocking offer (from rLtdxMMXPs21PYnnSiwm85EabdHDH4oVhi).  That would be a big help.  Then I can look back at that offer's history.

@scottschurr we have another instance today
ledger index 86,858,489 its present
account https://xrpscan.com/account/rJTyFN9PYy9uWJ3ixsSBfvhZGgvvjNt8MV

@lathanbritz, thanks for the information on that recent blockage.
I have a unit test that is able to reproduce the last blockage that you reported (by rLtdxMMXPs21PYnnSiwm85EabdHDH4oVhi).  I'm currently looking into how to prevent the source of that particular blockage.
When I get an opening I'll research this more recent blockage, since it may not have the same source as the older one that I'm currently looking at.

@shortthefomo, first the good news: I found the source of the problem for the USD/Bitstamp:XRP blockage that you reported earlier.  I have a proposed fix (not yet a pull request), but that will of course need to go through code review.
Regarding the reported order book blockage in ledger 86,858,489 I have less good news.  I analyzed the top-most 150 offers in the...
"TakerGets": "CSC"/"rCSCManTZ8ME9EoLrSHHYKW8PPwWMgkwr",
"TakerPays": "XRP"

order book in that ledger.  That included the one you identified with TakerPays: "4" (that was offer 49).  I don't see how any of those 150 offers could be blockers.  I'm not saying you didn't see something funny with that order book.  But I don't understand the nature of the symptom you were seeing.
All-in-all, however, it is forward progress to identify an additional source of order book blockage and find a fix for it.  Thanks for the help.

Great news!
The symptoms that I see that makes it simple to spot is simply taking the first offers off ASK/BID books and then checking for a negative spread. If it's negative those books (ASK and BID) had an order that is "stuck".
That's how ive been identifying them, not sure if that information helps here.
Thank you for all the effort on this @scottschurr

this is expected to be fixed by fixReducedOffersV2, introduced in 2.3.0-b1
feel free to re-open this issue if more needs to be done


My first branch

Add my first file.

I have created a new branch, created a file, and made a commit!


Dependency conflict with flutter_test

Because every version of flutter_test from sdk depends on petitparser 2.4.0 and intl_translation >=0.17.10 depends on petitparser ^3.0.0, flutter_test from sdk is incompatible with intl_translation >=0.17.10

I think this error is fixed on flutter stable and dev channel.

still got the same error after upgrading to beta channel

@boskokg May I know which version are you on?

@lzhuor I removed it from the project. I when to simpler approach...

@boskokg Got it. I found that using intl_translation: ^0.17.8 works fine. (one patch lower)

@boskokg May I ask if simple approach support interoperation (args) out-of-the-box?

@boskokg May I know which version are you on?

Flutter Channel beta, v1.17.0-3.2.pre

I am able to use intl_translation: ^0.17.9, however I am unable to upgrade to 0.17.10 because:

Because intl_translation >=0.17.10 depends on petitparser ^3.0.0 and every version of flutter_test from sdk depends on petitparser 2.4.0, intl_translation >=0.17.10 is incompatible with flutter_test from sdk.

Note that I still have this problem after upgrading to Flutter 1.17.0.

It looks like flutter_test removed petitparser as a dependency on April 9, 2020.  However, that did not make it into the Flutter 1.17.0 release.  It looks like we may need to wait until Flutter 1.18.0.

@awhitford  that... sucks

@davidmorgan when can we expect this fix or next version of the package ?
as much as I am reading, the latest version of flutter_test is not depended on petitparser...
stuck with below error:
Because every version of flutter_test from sdk depends on petitparser 2.4.0 and intl_translation >=0.17.10 depends on petitparser ^3.0.0, flutter_test from sdk is incompatible with intl_translation >=0.17.10.
So, because app depends on both intl_translation ^0.17.10 and flutter_test any from sdk, version solving failed.

pub get failed (1; So, because app depends on both intl_translation ^0.17.10 and flutter_test any from sdk, version solving failed.)
exit code 1

That needs fixing with a release of flutter_test, not here.

@boskokg Got it. I found that using intl_translation: ^0.17.8 works fine. (one patch lower)

thanks this worked on the latest stable channel  v1.17.5

@maheshmnj
really?

@yourshinsuke  yes ofcourse it did work for me

@maheshmnj
Thank you.
OK.
I removed test: ^1.14.5 in pubspec.yaml and it can pub get.

Flutter 1.20.0 was released today.  You will then be able to use version 0.17.10.

I had a similar problem with flutter_test and test. I solved it by downgrading test version to ^ 0.14.4 :)
`The current Dart SDK version is 2.8.4.
Because test >=1.16.0-nullsafety requires SDK version >=2.10.0-0 <2.10.0 and test >=1.14.5 <1.15.0 depends on test_api 0.2.16, test >=1.14.5 <1.15.0-∞ or >=1.16.0-nullsafety requires test_api 0.2.16.
And because test >=1.15.0 <1.15.3 depends on test_api 0.2.17, test >=1.14.5 <1.15.3-∞ or >=1.16.0-nullsafety requires test_api 0.2.16 or 0.2.17.
And because test >=1.15.3 <1.16.0-nullsafety depends on test_api 0.2.18 and every version of flutter_test from sdk depends on test_api 0.2.15, flutter_test from sdk is incompatible with test >=1.14.5.
So, because flutter_tests_app depends on both flutter_test any from sdk and test ^1.14.5, version solving failed.
pub get failed (1; So, because flutter_tests_app depends on both flutter_test any from sdk and test ^1.14.5, version solving failed.)
Process finished with exit code 1`

Fixed, as the dependency is removed.


FromJSON / ToJSON missing for IPv6

Like subject says, missing JSON functions for IPv6.

...also missing for Net.Types.IP, but maybe that's intentional?

Yeah, these should be there, but I never got around to it since I haven't actually ended up using these types as much in applications I work on. I would say that I'd take a PR, but I'm in the middle of refactoring some of the modules, so if anyone does want to PR this, wait a couple of hours before I push everything I've changed into master.

I'd be happy to contribute that, but I'm very new to Haskell so I'm mostly scratching my head wondering how to do that.
When looking at the FromJSON for IPv4, it looks like there's some duplication via decodeIPv4TextEither compared to what is found in IPv4.hs. Why is that? Couldn't FromJSON just dispatch that to the same parser? ...and the IPv6 version could do a similar thing.

The module structure deserves some explanation. Basically, there are several options for how to structure modules in a library. Let's consider two such options.

Each exported module contains a type and all of its related functions
All type declarations go in a Types modules, and modules named after each type contain only functions related to the type.

Both options have their advantages. For this library, I chose the second one, because when using ip, I often want all of the types in scope unqualified, but I want always use the functions for working with them qualified. For example, the way I typically use ip looks something like this:
import Net.Types (IPv4,IPv4Range,Mac)
import qualified Net.IPv4 as I
import qualified Net.IPv4 as R
import qualified Net.Mac as M

If I had gone with option (1) for the module structure, I would need to do this instead:
import Net.IPv4 (IPv4)
import Net.IPv4 (IPv4Range)
import Net.Mac (Mac)
import qualified Net.IPv4 as I
import qualified Net.IPv4 as R
import qualified Net.Mac as M

Again, whether or not the structure I decided on is better depends very much on how the end user actually uses the library and what their preferences regarding qualified imports are.
Now, to get to your question: Why is does decodeIPv4TextEither even exist? The problem is that the FromJSON instance needs to live in the same module as IPv4 (to avoid orphan instances), but that instance needs to call the decode function, which lives in Net.IPv4. If we naively try to do this, we will create a cyclic import (since Net.IPv4 definitely has to import Net.Types), which GHC complains about. So, we have to break up the cycle like this:
  +----------------------------------+
  |                                  v
+----------+     +-----------+     +--------------+
| Net.IPv4 | --> | Net.Types | --> | Net.Internal |
+----------+     +-----------+     +--------------+

Both modules import Net.Internal, which has the meat of the ip decoding logic. It's a nasty module with a ton of top-level functions inside, but it works. Crucially, it doesn't actually use the IPv4 type. The ip functions there works on Word32s, and since IPv4 is just a newtype wrapper around Word32, we can use trivially use them in Net.IPv4 and Net.Types.
So, the cause of this is that I cannot stand orphan instances, and I'm willing to move logic to around to avoid them. Notice that we only have to move things to Net.Internal when they are both (1) something needed by a typeclass instance and (2) something needed by a non-typeclass function we want to offer to end users.

I've added the IPv6 instances with 4150ff7cb9a687a1ebdf7146e762a704b7a3c2fb

This has been released to hackage. Also, it's worth noting that I actually decided to change the structure of the data type definitions described in my earlier comment. Now, all of the data type definitions live in the module named after them (IPv4 is defined in Net.IPv4, etc.), and Net.Types simply re-exports all of these. It avoids the need for a Net.Internal module.