KAFKA-9487: Follow-up PR of Kafka-9445

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Left few comments..

Thanks @guozhangwang and @vinothchandar . Addressed a few comments and have replied to some left.

Hey, thanks for the update @brary .
IIUC, the main motivation for this PR was some follow-up comments from @mjsax . It would be good to get a +1 from him before merging. Maybe after the other comments are addressed.

Thanks @vvcephei for the comments. I have made the changes suggested by you as well.
@mjsax  I guess everyone else has reviewed and their comments have been incorporated. It would be great if you can give one last look and if it's okay merge it.

@vinothchandar @vvcephei I would still propose to rename the new class to StoreQueryParameters -- it's not a big deal to rename even after feature freeze IHMO.
Thoughts?

StoreQueryParameters does sound better to me. but leave it you all. :)

@mjsax  I have changed the class to StoreQueryParameters and the comment you gave in earlier PR. There were few checkstyles which were failing in ValueAndTimestampSerializerTest unrelated to this PR. I have fixed those as well.

Thanks @mjsax . I'll take care of it tomorrow.
I don't see any test results, so I'll ask Jenkins to re-run it:
Retest this, please.

Unrelated test failures:
kafka.admin.DeleteConsumerGroupsTest.testDeleteCmdAllGroups
kafka.admin.DeleteConsumerGroupsTest.testDeleteCmdWithMixOfSuccessAndError
Proceeding to merge.

Cherry-picked onto 2.5 as 3e77458cfb0f7a7586f17777f0e775d91e4744e1


Angular2-meteor doesn't work inside a ionic2-rc project.

Hi,
I'm trying to use angular2-meteor inside an ionic2-rc project, the package bundler they prefer is rollup but I get lots of error just when I try to
import {METEOR_PROVIDERS} from 'angular2-meteor';
My try was to do like the whatsapp2 toturial but I ran into lots of errors like those :
 [22:25:31]  transpile update started ...
[22:25:33]  typescript: node_modules/angular2-meteor/dist/index.d.ts, line: 1
            File '/Users/marwanmazloum/Desktop/Developpement/TF1/tf1-app/node_modules/angular2-meteor/typings/index.d.ts'
            not found.

       L1:  export * from './zone_utils';
       L2:  export * from './mongo_cursor_observer';

[22:25:33]  typescript: node_modules/angular2-meteor/dist/meteor_reactive.d.ts, line: 23
            Cannot find namespace 'Tracker'.

      L23:  autorun(func: (c: Tracker.Computation) => any, autoBind?: Boolean): Tracker.Computat

[22:25:33]  typescript: node_modules/angular2-meteor/dist/meteor_reactive.d.ts, line: 23
            Cannot find namespace 'Tracker'.

      L23:  autorun(func: (c: Tracker.Computation) => any, autoBind?: Boolean): Tracker.Computation;

[22:25:33]  typescript: node_modules/angular2-meteor/dist/meteor_reactive.d.ts, line: 29
            Cannot find namespace 'Meteor'.

[22:25:33]  typescript: node_modules/angular2-meteor/dist/mongo_cursor_differ.d.ts, line: 33
[22:25:33]  typescript: node_modules/angular2-meteor/dist/mongo_cursor_observer.d.ts, line: 35
      L29:  subscribe(name: string, ...args: any[]): Meteor.SubscriptionHandle;
      L30:  call(name: string, ...args: any[]): any;

            Cannot find namespace 'Mongo'.

      L32:  forEachOperation(fn: Function): void;
      L33:  diff(cursor: Mongo.Cursor<any>): this;
      L34:  onDestroy(): void;

            Cannot find namespace 'Mongo'.

      L34:  static isCursor(cursor: any): boolean;
      L35:  constructor(cursor: Mongo.Cursor<any>, _debounceMs?: number);
      L36:  subscribe(events: any): any;

[22:25:33]  typescript: node_modules/angular2-meteor/dist/zone_utils.d.ts, line: 16
            Cannot find name 'Zone'.

[22:25:33]  typescript: node_modules/angular2-meteor/dist/zone_utils.d.ts, line: 18
[22:25:33]  typescript: node_modules/angular2-meteor/dist/zone_utils.d.ts, line: 19
[22:25:33]  typescript: node_modules/angular2-meteor/dist/zone_utils.d.ts, line: 20
[22:25:33]  typescript: node_modules/angular2-meteor/dist/zone_utils.d.ts,

yes we are aware of this issue, this is why only the 2.0 WhatsApp tutorial with the Meteor CLI is working and the Ionic CLI is not updated yet. (https://www.angular-meteor.com/tutorials/whatsapp2/)
We are not the only ones with this problem so Ionic is working on a new version to fix this and then we will update the tutorial and make it work

Cool I'll try form the socially-ionic example then.
however the whatsapp2 and angular2 socialy projects enable me to do lots of cool things ;-)
thanks a lot for your work.

Is this related to Webpack? As they published a beta that's include it again: https://forum.ionicframework.com/t/help-us-test-webpack-support-in-ionic-2-app-scripts/67507

Thanks for the hint i'll try and give feedback here, did you try already ? I'll also need to try by adding ionic2 to a meteor angular2 project since I find the Meteor-Angular2 structure very interesting to.
The thing Is that I use a separate meteor server that I connect through DDP to my app, so my Mongo collections are declared differently and I use the DDP object.

Maybe @Urigo can have a look on this beta, perhaps an update of meteor and the tutorial is already possible. :+1:

+1 waiting for update

it looks like it can work now but I must say, all those breaking changes are too much for us right now (and also not fair for the community).
We will wait for a few more RC releases and then update the tutorial.
If someone wants to try in the meantime, we will help and support you (you can contact me directly on my Github profile)

You can use Ionic 2 rc1, with Webpack and custom build, more info here: https://github.com/idanwe/meteor-client-side/issues/31#issuecomment-258114398
Closing it since it's now possible to use both together, soon the tutorial will be deployed (at the moment, it's updated code is available in https://github.com/DAB0mB/ionic2-meteor-messenger/tree/step-by-step-new)

Can we get notified here when the tutorial is updated?
Thanks for the code @dotansimha, I'll have a look into it tomorrow!

The tutorial is ready and in PR: https://github.com/Urigo/angular-meteor-docs/pull/284
@Urigo will soon merge and deploy to angular-meteor.com :)

merged and deployed!
amazing work @dotansimha !

Hey @dotansimha. Thank you again.
I started with the tutorial and I'm at the end of Step 2 (https://www.angular-meteor.com/tutorials/whatsapp2/ionic/chats-page)
Unfortunately I'm getting an error in the console saying Cannot find module "../pages/chats/chats"
When I try ionic run I'm getting the error  Cannot find name 'Chat'. Seems like there is an error with including those models with the alias api.
Are those steps in Step 1 - Initial setup are really necessary? I thought that the newest version of ionic2 is already using webpack in addition? I'm asking because I also tried to adapt my existing project to the tutorial, but it's not compiling my changes anymore but also not showing an error at the moment .. Only in ionic run, as with the tutorial.

@sosnet, can you share you repo so I can take a look at the error?
Also, the Step 1 is really critical because Ionic 2 uses Rollup (with es2016 modules), and in this step we replace Rollup with Webpack and CommonJS modules.

Ok, looks like there was another update of the tutorial for Step 1. Anyway, now Step 1 and 2 are working for me, so great!
But when I start the app after Step 3, the app shows only white screen and in the browser-terminal I get this error:
webpack:///./api/collections/whatsapp-collections.ts?:1 Uncaught Error: Module build failed: TypeError: Cannot read property 'content' of undefined(…)
@dotansimha, the repo is https://github.com/sosnet/ionic2-meteor
Thank you so much for helping!

I'm trapped in the same situation as sosnet. And what the correct  "webpack.config.js" like?

@sosnet It's not angular-meteor specific. Here is a line that causes an error. The thing is, it's not working with aliases.
You can just disable it to make it works but you will skip the features of typescript-sourcemap-loader-memory.

Hey @kamilkisiela, thank you very much for helping. I'm new to Angular2/Ionic2 and Meteor.. So, would you be so kind and tell me how to disable it? Or what are those features I would lose? Are they important?
Or should I remove those aliases? Or are they needed later?
Sorry for all those noob questions..

@sosnet It's basically for the source maps. Here's the actual file.
I think you can skip it and use just devtool: 'source-map'.
Here's how the webpack.config.js would look like:
var path = require('path');
var webpack = require('webpack');

var ionicWebpackFactoryPath = path.join(process.env.IONIC_APP_SCRIPTS_DIR, 'dist', 'webpack', 'ionic-webpack-factory.js');
var ionicWebpackFactory = require(ionicWebpackFactoryPath);

function getEntryPoint() {
  if (process.env.IONIC_ENV === 'prod') {
    return '{{TMP}}/app/main.prod.js';
  }
  return '{{SRC}}/app/main.dev.ts';
}

/*
function getPlugins() {
  if (process.env.IONIC_ENV === 'prod') {
    return [
      // This helps ensure the builds are consistent if source hasn't changed:
      new webpack.optimize.OccurrenceOrderPlugin(),

      // Try to dedupe duplicated modules, if any:
      // Add this back in when Angular fixes the issue: https://github.com/angular/angular-cli/issues/1587
      //new DedupePlugin()
    ];
  }

  // for dev builds, use our custom environment
  return [
    ionicWebpackFactory.getIonicEnvironmentPlugin()
  ];
}
*/

function getPlugins() {
  var plugins = [
    // Try to dedupe duplicated modules, if any:
    // Add this back in when Angular fixes the issue: https://github.com/angular/angular-cli/issues/1587
    //new DedupePlugin()
    new webpack.ProvidePlugin({
      __extends: 'typescript-extends'
    })
  ];

  if (process.env.IONIC_ENV === 'prod') {
    // This helps ensure the builds are consistent if source hasn't changed:
    plugins.push(new webpack.optimize.OccurrenceOrderPlugin())
  }

  return plugins;
}

function getDevtool() {
  return process.env.IONIC_SOURCE_MAP;
}

module.exports = {
  entry: getEntryPoint(),
  output: {
    path: '{{BUILD}}',
    filename: 'main.js'
  },
  devtool: getDevtool(),

  resolve: {
    extensions: ['.js', '.json', '.ts'],
    alias: {
      'api': path.resolve(__dirname, '../api')
    }
  },

  module: {
    loaders: [
      {
        test: /\.json$/,
        loader: 'json'
      },
      {
        test: /\.ts$/,
        exclude: /(node_modules)/,
        loaders: ['awesome-typescript-loader']
      }
    ]
  },

  plugins: getPlugins(),

  // Some libraries import Node modules but don't use them in the browser.
  // Tell Webpack to provide empty mocks for them so importing them works.
  node: {
    fs: 'empty',
    net: 'empty',
    tls: 'empty',
  __dirname: true
  }
};

Thx for your effort @kamilkisiela, but unluckily I'm getting this error
http://localhost:8100/tabs.html Failed to load resource: the server responded with a status of 404 (Not Found)

Please take a look at https://github.com/Urigo/Ionic2CLI-Meteor-WhatsApp and compare package.json, config/webpack.config.js. Maybe there are some differences? It's Ionic who is in charge of parsing your templates into strings.

Ok, back to the roots.
I started now with git clone https://github.com/Urigo/Ionic2CLI-Meteor-WhatsApp. The biggest differences  are the config/webpack.config.js and some downgrades of packages in package.json. I think the webpack.config should be included to the tutorial, otherwise it's useless.
But, the app is starting now, but I get those errors in the browser console:
Failed to load resource: the server responded with a status of 404 (Not Found): http://localhost:8100/sockjs/info?cb=sg98u3njre

When I open the url and change the port to 3000 I get something back. But how to tell the ionic app which port and url it should use for the meteor-server?
Thanks a lot, @kamilkisiela, I'm a step closer again.

Ok, I solved this problem by adding these lines to the index.html of my ionic project:
<script>
      __meteor_runtime_config__ = {
        DDP_DEFAULT_CONNECTION_URL: 'http://localhost:3000'
      };
</script>

Why it's not using it's default settings? Why I have to set them and why the settings in node_modules/meteor-client-side/meteor-runtime-config.js are ignored?
However, I will continue now with the tutorial where I stopped before. Thanks everyone who helped me out. Maybe someone can use those problems and solutions to fix something.

Looks like my previous config isn't working anymore. The app just ignores whatever I set in the index.html. What's the right place to put the config to? Thanks


fix: add support for login via username

This PR adds support for username and email to be used to login to app.

User can login using username
User can login using email

@mumer92 It's not giving an error for an empty username.

@volodymyr-chekyrta waiting for your review on this.


Invalid application of virus arithmetic.New()

Output shows, that the virus arithmetic.New() has been applied to a string concatenation, which causes a build failure.
internal/service/routing.go:168:9: invalid operation: operator - not defined on "/" (constant of type string)

This was the code:
func HealthPath() string {
	return "/" + path.Join(BasePathInternalCases(), "health")
}

I am assuming this is not intended behaviour.

Good catch! Indeed… not the intended behavior.


Input: Add autocapitalize, autocorrect, enterkeyhint, and spellcheck properties

Description
Add autocapitalize, autocorrect, enterkeyhint, and spellcheck properties to input
References #2347
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
Added unit tests
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@coliff done.

autocapitalize is appearing twice
spellcheck is missing
changing the values of the autocapitalize, autocorrect and enterkeyhint does not change the input at all. See screenshot:

We expect the input with id="mwc_id_0_text_input" here to have enterkeyhint="done" autocapitalize="sentences" autocorrect="off"

Oops.  Fixed.

thanks for work on this so far - still a few more things:

autocapitalize by default should not be set at all. autocapitalize attribute should not be set on the mwc_id_9_text_input in the canvas example. (autocapitalize is the default on mobile devices usually anyway). So the dropdown in the Controls as standard should be 'Choose option...'
autocorrect by default should not be set at all. autocorrect attribute should not be set on the mwc_id_9_text_input in the canvas example. (autocorrect is the default on mobile devices usually anyway). So the dropdown in the Controls as standard should be 'Choose option...'
enterkeyhint should not have an option pre-selected - so have a ('Choose option...') selected.
spellcheck should be a dropdown with true or false options - but by default nothing selected ('Choose option...').

I made the changes (except for spellcheck, as that is an attribute that is true if it's included, much like disabled).

@austinoneil Why make autocorrect: boolean | 'off' | 'on';
Why not stick to just an enumeration or just a boolean?

@kuhnboy  When I as a developer see autocorrect as an attribute, my instinct tells me that it is a boolean input; however, the autocorrect attribute on input takes "on" and "off" as values.  I included both because doing so makes the library easier to use without creating any obvious problems.

@kuhnboy That said, it does look like this was causing issues with autocapitalize in react (see #2412), so if needed, we can just use "on" and "off" (or just boolean)


feat: add 'worker_index' to WorkerRunner

Master will provide on ACK an ordinal identifier for each connected worker; these are deterministic (same id for same client_id).
This implementation is backward-compatible for older master nodes that do not provide the index in message payload for ACKs.
Fixes #1601
Note: LocalRunner does not have an implementation for worker_index, I did not think there was an easy way to add it.
I have attempted to change the documentation to automatically cover this field, please advise if there are better ways.
Thanks!

Any idea why the KeyError is happening in the CI check?

I think the test is bad (fragile) because it assumes a msg with .data is not an ack

Looks like a good start! Two questions:
Is the lock really needed? There are no io calls so I dont see how another greenlet could start to run?
Do we really need the old id:s or could this replace it? A number of places would be nicer if we used ordinal IDs instead of uuid:s (specifically logs)

This needs some unit tests.

I think the test is bad (fragile) because it assumes a msg with .data is not an ack

Ok, will try to fix it.

Is the lock really needed? There are no io calls so I dont see how another greenlet could start to run?

I assumed so; but since recv_from_client() only happens serially then I will remove it.

Do we still need the old id:s or could this replace it? A number of places would be nicer if we used ordinal IDs instead of uuid:s (e.g. the logs)

You mean the self.client_id (which is an UUID)? I guess it could be replaced but better in a separate PR? Also, some people downstream might rely on the hostname being there.

This needs some unit tests.

Any suggestion? If we have one for ACKs then I would modify that one; and perhaps add another one for old masters (I already verified manually that new workers can connect to old masters, but a test would be best).

You mean the self.client_id (which is an UUID)? I guess it could be replaced but better in a separate PR? Also, some people downstream might rely on the hostname being there.

Yes. We could do it later on but I kind of would like to do it now (rather than having two potentially breaking changes)

This needs some unit tests.

Any suggestion? If we have one for ACKs then I would modify that one; and perhaps add another one for old masters (I already verified manually that new workers can connect to old masters, but a test would be best).

no suggestions off hand (I’m on mobile atm). No need to validate backwards/forward compatibility, it looks reasonable. Just validate that the ID is available and incremented correctly. Check the existing tests for inspiration.

Yes. We could do it later on but I kind of would like to do it now (rather than having two potentially breaking changes).

The changes introduced in this PR are not breaking though.
I can make more changes so that client_id is completely replaced and becomes the ordinal int; it will become a bigger PR though.

no suggestions off hand (I’m on mobile atm). No need to validate backwards/forward compatibility, it looks reasonable. Just validate that the ID is available and incremented correctly. Check the existing tests for inspiration.

Ok, I have added one; thanks!

Yes. We could do it later on but I kind of would like to do it now (rather than having two potentially breaking changes).
The changes introduced in this PR are not breaking though.

Sorry, I was unclear: what I meant was that the second PR would be a breaking one, as it would remove the ordinal_id added here (as it would no longer be needed).
I’d like to see it investigated at least. Doing it as a separate PR is fine if it becomes too complicated.

I am going to fix the tests and then add another commit which "promotes" the ordinal ID as the client_uid; note however that I think it is beneficial that clients have an UUID, so that when they connect back the same ordinal will be assigned to them (at least until master is restarted).
I will try to find the best approach to preserve this functionality.

I have been thinking through it; I think removing the UUIDs is a bad idea because right now these are used for a sort of "weak" handshake: clients report their UUIDs and the messaging/events is based on that.
I will make a commit that renames client_id into client_uuid so that client_id can be used for this new ordinal (which is like an index).

I have been thinking through it; I think removing the UUIDs is a bad idea because right now these are used for a sort of "weak" handshake: clients report their UUIDs and the messaging/events is based on that.
I will make a commit that renames client_id into client_uuid (removing the socket hostname from it), and also introduce the new field as worker_index.

I see! Given that, I have changed my mind. I think it is preferable to keep client_id exactly as it is (including hostname), to promote backwards compatibility.
Can you also add an "integration test" (maybe in test_main.py) that checks that is correct on that side? (maybe by printing self.runner.worker_index from inside a task).
For convenience, how about adding worker_index to LocalRunner and just making it zero?

MasterRunner.client_ordinals should probably be renamed worker_indexes instead (just to keep it consistent)

For convenience, how about adding worker_index to LocalRunner and just making it zero?

If there can never be more than 1 LocalRunner, then it is fine; I have changed it.
I have applied the other changes as well.

It looks really good now. Can you adjust test_worker_indexes so that it actually launches two workers?

@cyberw I have added another worker, but there was no other test using 2 workers so now I am incurring into some weird issue. Any idea why the master is returning a non-zero exit code?

No particular ideas, but do a
self.assertIn("Shutting down (exit code 0)", stdout)
first, and you might get a clearer message

I think I fixed the test. Will merge once build clears...

Meh. Build doesnt appear to care about my commit. I'll merge and fix it here (upstream) if necessary.

I didn't have time today, I see you found the mistake. Thank you!

I have do this in my project.and it is some different
1,index is in class WorkerNode
2,Master have a index cache and if the workernode has leave ,the index is in cache to wait for next workernode
def get_index(self):
if len(self.index_cache) == 0:
ret = self.index_sequence
self.index_sequence += 1
else:
self.index_cache.sort(reverse=True)
ret = self.index_cache.pop()
return ret
def release_index(self, index):
    if index not in self.index_cache:
        self.index_cache.append(index)


Nxdomain

I'm trying to send information using the example, and I get this message:

could not send messages due to :nxdomain

Does your machine have network connection to your zabbix trapper? Please verify that your host and port settings are valid. This error means that your machin is not able to resolve the host address.

Hi, I got confused. Does this is the workflow?
Telemetry -> TelemetryMetricsZabbix -> Zabbix Server

Now I am getting this warning:
[warn] Elixir.TelemetryMetricsZabbix: server could not process 1 out of 1 messages. Message keys was: ["http.request.latency["me"]"]
However I don't see any logs on my zabbix server

The data flow is
Telemetry -> TelemetryMetricsZabbix -> Zabbix Server

[warn] Elixir.TelemetryMetricsZabbix: server could not process 1 out of 1 messages. Message keys was: ["http.request.latency["me"]"]

This means that you communication is now working but your zabbix server is rejecting your measurement.
You need to create a zabbix trapper that consumes measurements with key: http.request.latency["me"].
Unfortunately zabbix needs a trapper for every key you are going to send. It's best to use zabbix LLD macros for that.

Hi I configured the trapper as this:

However it keeps showing the same error. Is there a way to show in Elixir log what is the data present in http.request?

Using the log, I'm able to see the parameters
summary("http.request.latency", unit: {:native, :millisecond}, tags: [:endpoint])
However, I think the issue is with the zabbix trapper, can you help me?

The trapper key looks good. For simplicity I use the same name as key. Is the trapper item on the correct zabbix host? IIRC you have to set the same hostname in telemetry_metrics_zabbix config. Try changing Type of information to numeric (I didn't try it with text). I also don't have anything selected in Applications.
Note also that in my experience there is about 2 minute delay before zabbix picks up the new config after an update.

Is there a way to show in Elixir log what is the data present in http.request?

Zabbix doesn't use http requests but a custom binary TCP based zabbix sender protocol https://zabbix.org/wiki/Docs/protocols/zabbix_sender/4.0
If you need to debug protocol messages it's best to fork this or my other library https://github.com/lukaszsamson/elixir_zabbix_sender (telemetry_metrics_zabbix uses it to comunicate with zabbix server)

Got it working :smile:
The issue was that I was issue PSK encryption (as I usually use for Zabbix Agents). Is there a way to configure the psk value in the
 config :telemetry_metrics_zabbix, :config,
host: "myzabbixserver.com",
port: 10051,
hostname: "MyServer",
batch_window_size: 1000,
timestamping: true
`

Got it working 😄

I'm glad to hear that

Is there a way to configure the psk value in the configuration?

It's not supported ATM. Please send a PR


Allow a scene's palette to be absent.

The palette key is not marked as required in the Hue v2 API documentation, so we should be able to handle its absence here.
Resolves #259.

Should have looked more closely! Now done.

Can you look at the CI test that failed ? Looks like a simple one with import order.

Any idea when this might get merged/released? It's leaving me without any Hue scenes in Home Assistant, which is a bit annoying.

Sorry for the delay - thanks again for the PR!
I'll bump the lib as well so the issue in core gets unblocked.


Travis build fails more often than it doesn't

I'm not sure who's responsible for it or whether it's progressing, but if it's not being actively developed/improved, can we just disable it?

Maybe Travis should be given a more lightweight task, like running nixpkgs lint and checking for evaluation errors.

I agree, travis.ci is really not the right tool, i think this should be implemented in hydra.

Except Hydra isn't running any tests anymore as far as I can see. I might be wrong, but I think this coincides with Travis not checking successfully anymore.

The number of false-positives generated by those travis-ci jobs is so high that a "failure" outcome is next to meaningless, really. I would like to see those builds disabled, because their presence confuses contributors who spent their time worrying about bugs in their submission because those builds fail, when in fact it's just the build that's broken, not their PR.

I benefit from travis, I merged many PR just by looking at the outcome of travis.

Ping @madjar.

As I suggested in my original question, I'm not necessarily opposed to leaving it in place if it's actively developed and there's a plan to improve it soon. But currently it generates so many false failures that I pretty much just ignore it, which means all its really doing is adding noise. Sure, a pass might be a good sign, but if they're rare and the system otherwise confuses new contributors, that doesn't seem good.

On Mar 4, 2015, at 08:22, lethalman<EMAIL_ADDRESS>wrote:
I benefit from travis, I merged many PR just by looking at the outcome of travis.
—
Reply to this email directly or view it on GitHub.

Hello there
The travis job check that the tarball still build (nix-build pkgs/top-level/release.nix -A tarball), but this has been broken for a month. Also, on my local machine, this requires 2Go of RAM, so it fails on travis which is much more limited.
As a quick fix, I'll disable that check, but I think those two problems should also be fixed.

Ah, if it's a legitimate failure then whoever broke it should probably fix
it! My main issue is that I don't know when it's legitimate so I mostly
ignore it, and I expect that whoever broke it in the first place probably
did the same.
On Wednesday, March 4, 2015, Georges Dubus<EMAIL_ADDRESS>wrote:

Hello there
The travis job check that the tarball still build (nix-build
pkgs/top-level/release.nix -A tarball), but this has been broken for a
month. Also, on my local machine, this requires 2Go of RAM, so it fails on
travis which is much more limited.
As a quick fix, I'll disable that check, but I think those two problems
should also be fixed.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/6652#issuecomment-77164743.

I think a small part of the problem is that the travis results shown on github are not consistent with what you see on travis.
On travis you can see 3 different results: pass (green), fail (red) and error (grey).
But when you see travis results on github both fail (red) and error (grey) are shown as fail (red).
If I understand correctly, error (grey) is used when something unrelated to the test fails, such as too much memory used, no output within a certain time frame, too much output etc.
If github also showed fail and error as separate colors/icons you would get a better overview what PRs actually failed due to tests or unrelated issues.

Well, here's the two results I get from travis, both equally unhelpful and false positives from the same commmit: https://github.com/NixOS/nixpkgs/pull/10755
One is failing if I base my branch on nixos-unstable and PR against master: https://travis-ci.org/NixOS/nixpkgs/builds/88525959
The other is based on upstream/master and simply generates a log that's over 4MB, so it also fails (mostly because qt build logs are huge): https://travis-ci.org/NixOS/nixpkgs/builds/88522075
I really didn't expect contributing to become more difficult since the last time I worked with nixpkgs, which is maybe a year ago when tests were still based on hydra.

travis-ci is just a helper, not something we are strict about.

Lately it even seems to cause more harm than good. New people don't (immediately) realize what's going on and they spend time analyzing errors that have nothing to do with the PR. I just learned not to look at the errors at all, as I lately saw no added value in reading them.

IMHO, a test hook that generates about 10% false-positives is useless. I'd be perfectly happy if we'd just disable the travis-ci builds for Nipkgs.

Every CI tool we use will have false positives until we provide a heuristic what changes we should build and what changes we want to skip because they're too "big".
There are still improvements that can be made to travis.

use nixos-channels as a base instead of nixpkgs repository
estimate build times using hydra information

Regarding log size we can hardly do anything otherwise we'd lose all debugging output.

use nixos-channels as a base instead of nixpkgs repository

Maybe I don't understand you – do you mean it should (somehow) automatically rebase the PRs? (Currently it depends on the submitter where (s)he bases the PR on, I believe.)

Yeah, it already re-bases on top of master.

I think we should collect statistics when travis-ci fails and under what conditions and then decide what can be solved or not.

Personally, I'd prefer to address this particular problem by holding to the agreement that master should not get any mass-rebuild changes (before binaries are available).

Agreed.

I see a number of things that can be improved, I'll open a PR with more details.

By looking at first two pages of PRs, I've noticed following issues with travis-ci:

8 builds ran out of memory (example https://travis-ci.org/NixOS/nixpkgs/builds/88628057)
2 builds stopped because of no output (example https://travis-ci.org/NixOS/nixpkgs/builds/88626974)
4 builds failed on merge conflict (example https://travis-ci.org/NixOS/nixpkgs/builds/88626701)
4 builds failed due to too long log 4MB (example https://travis-ci.org/NixOS/nixpkgs/builds/88621524)
6 builds successfully caught an error
1 build failed because PR had no title (example https://travis-ci.org/NixOS/nixpkgs/builds/87937406)

The rest of the builds passed. Now, I'd say we can address of all these.

Fixed in 11b123662717ad20c3bb3100503786b35adfb158
This one is the hardest to solve. More memory will help, but we should limit travis when changes are too big. I'd consider this one an positive, meaning it's mass-rebuild.
I haven't dig into merge conflict, but merge buttons seems to be green.
We could slience curl, implement http://docs.travis-ci.com/user/uploading-artifacts/  or my most favourite, fix https://github.com/NixOS/nix/issues/443
YAY
Should be fixed in nox

nice :-)
that's not the cause of failure, at least not in the example that you link – it failed due to OOM, and it doesn't display the full log due to being too long (you can view it raw https://s3.amazonaws.com/archive.travis-ci.org/jobs/88621525/log.txt).

Yeah, bad example, see https://s3.amazonaws.com/archive.travis-ci.org/jobs/88522076/log.txt

I wonder if they provide an option to keep a tail of the log. 4 MB is way too much to keep for these purposes anyway.

Actually, why not simply pipe the output through tail -c 100k or similar? Would anyone read a longer part of the log?

And for completeness there is also https://github.com/madjar/nox/issues/22, but we just need a better way to detect changes even if recurseIntoAttrset is not used.

I did another round of testing. Here are the results for latest 50 PRs:

2 fail due to merge conflicts (still needs investigation)
2 fail due to EOF using curl to download binaries (do we need a feature in Nix to retry?)
1 fail due to hydra saying 410 Gone (do we need to fix Nix to support that?)
2 fail due to job timeout (not much we can do here)
5 actual errors in code (yay, that's 10% of failures caught)
9 fail due to max log size reached (see #13006)

This is getting worse and worse. I wonder if we should really just disable travis and work on Hydra that tests PRs.

For the PR's I've been looking at Travis appears to be working quite well now. The problem is that currently on master and I think also 16.09 the tarball cannot be build (https://github.com/NixOS/nixpkgs/issues/18209#issuecomment-244576612). A problem I did find is that Travis often reports a fail of the first test job for no apparent reason.

On https://github.com/NixOS/nixpkgs/pull/18376, we resolved not to disable Travis for now. Seems like it's not pressing/can wait until we can use Hydra. Can we close this for now?

I'm not convinced someone really is working actively on that Hydra support, but I'm hopeful.

Okay, some notes on Travis issues from (https://travis-ci.org/NixOS/nixpkgs/pull_requests):

Nox-review shouldn't bite off more than it can chew (https://travis-ci.org/NixOS/nixpkgs/jobs/183271042)

perhaps just don't build more than ~20 dependencies? (could cause false positives)

Changes to the stdenv is probably always going to cause headaches
When Hydra binary cache gets behind, Travis tries to build them

maybe rebase on last fully built evaluation? (could break some PRs)

Travis sets hard limit of 4MB log size that we frequently go over.

see NixOS/nix#443 for ideas
nox-review could try to build with "-Q"

Travis sets hard limit of 4MB log size that we frequently go over.

Filtering the output through tail might be a nice way.

Update on this: Travis has been failing a lot lately on MacOS because of travis-ci/travis-ci#7628. I've opened travis-ci/travis-build#1104 to hopefully fix it.

Now, that we have pr bots, can we disable travis? It confuses new people.


Feature request: left-handed mode

Option to put the brightness slider on the opposite side.
Useful for wider phones where it can be difficult to reach the other side.

Thanks for the idea.
Sounds doable, but I have to find a performant solution (and to prevent moving elements on every app startup).

On Tue, Feb 6, 2024 at 10:59 AM Niko Diamadis @.***>
wrote:

Thanks for the idea.
Sounds doable, but I have to find a performant solution (and to prevent
moving elements on every app startup).
—
Reply to this email directly, view it on GitHub
https://github.com/cyb3rko/flashdim/issues/55#issuecomment-1930113873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDVUYFCDMH5RGUBSSCU7ADYSJHNVAVCNFSM6AAAAABCSUL4HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGEYTGOBXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Just a quick heads-up: I'm currently in the process of rewriting the app to Jetpack Compose, which would simplify that feature.
I will implement this as soon as the current app features are working fine.


[Discussion] Tabs and Scene tabs

The purpose of this thread is to discuss the ideas and wishes around the Scene tabs of Godot editor. Multiple subjects have to be considered here and I ask every participant to quote precisely which one they relate (eg. S1 or G2).
Feel free to propose new entries for the following lists.
Considering tabs (in General) :

G1/ Close button : already PR-ed ( #2380 )
G2/ Find a way to scroll horizontally over a big number of tabs

Considering scene tabs in the editor :

S1/ Left align the scene tabs instead of centering them.

G2 : Here is the way Firefox deals with this

S1 :
Rotes Buch (aka solo on IRC) asked for left-alignment like this :

Left-alignment is already possible for tabs. Scene tabs are setup to be Centered. Here is what left-align displays :

A left margin is wished by multiple users in order to align the scene tabs with 2D/3D main panel. However, in the case where there is no left panel in the editor, I think this margin should not be present. This would look like this :

@StraToN: G2/ Find a way to scroll horizontally over a big number of tabs:
I suggest blender style... middle mouse button then drag to a direction... if that's possible...

@mamarilmanson How does it work for users who don't have a middle mouse buttons such as macbook users using only touchpad ?

ALT+LMB? :)

Blender also does this... MMB emulation...

@mamarilmanson Oh, right, I forgot. Fine then. I like the idea a lot. I already worked on middle mouse button management for tabs, for closing a tab quickier. Dragging should be possible but I need to verify if moving tabs out of their positions is possible or not

I'd suggest implementing both, the arrows and the middle mouse button method. Some mice actually still lack this(surprisingly, but some people just do not have one, and I do not see a settings menu where one can change this button....).

Actually, there is currently no way to change key shortcuts for Godot Editor. AFAIK, they are hard-coded in the source code (which we all agree to say it is ugly), but this is an enhancement that will be needed in short to mid-term.

Yeah, but these arrows won't do any harm, at least if it isn't too much work to implement obviously. Because the goal after all is to allow for multiple methods to get to Rome.
I'd say that loading the key shortcuts from some configuration file is already a start. Most of us could edit it by hand, no need to instantly add an editor for that on top. Possibly some food for thought.

@WatIsDeze True. This is a different topic from this one here. The need will grow, and then a new topic will rise, no doubt about that.
Considering G2/ Find a way to scroll horizontally over a big number of tabs:
I think the easiest way consists in adding the two left and right nav buttons. The middle click drag should be added later. Remember : these additions will be available for users in GDScript. We do not want an exhaustive list of functionalities, and existing ones have to be enabled or disabled on demand. That is the case for the Close Button, for example.

The middle mouse button is already used for navigation into the viewport editor. And I like how it is.
Unintentional clicks or scrolling, because too much functions are connected to the mouse, are so annoying...

^ same as blender…

I vote for closing tabs with a mid-button click, it'd be really convenient, specially since there are no right-click context menus.

Closing tabs with mid-button click is already developed (#2371), you can try it already, but I have no idea if it will be accepted.

Yay ! Great job @reduz 😁

Yay ! Great job @reduz 😁


Consider adding a warning for CORS / Script errors

Right now we filter out "Script error", but for users who are just setting up Raven / Sentry and are serving their application files from a different origin, they may not know they need to configure CORS, and all their errors end up getting suppressed.
We should consider at least putting out a warning (once) when we detect "Script error", and possibly link to some docs on how to resolve this.
Downsides: other 3rd-party scripts can trigger "Script error", and this warning will likely fire in cases when it's not your code that is responsible. This could lead to a noisy console.

+1

I believe this should be done in the dashboard? @getsentry/javascript

Yeah. We should close this here and do this in UI/processing.

Yeah. We should close this here and do this in UI/processing.

Why? Users will get "Script error" basically forever because of extensions. I'd rather surface it in developer tools console, because it is likely not to be extensions if it is the developer's own browser.

@benvinegar i thought script errors are still sent to sentry just that they have basically no info?

No, they're suppressed client-side by default.

I wonder if it would make sense to have an API where you can send configure failures to sentry so they can surface in your UI (like we already do with symbol processing errors). Because I don't think anyone is going to notice them in the developer console.

There's discussion going on about similar issue here as well – https://github.com/getsentry/raven-js/pull/927

Because I don't think anyone is going to notice them in the developer console.

Based on feedback, support issues, etc., I believe many folks have their console open when they're first setting up Sentry. For example, I've spoken to people who've attempted to (erroneously) trigger errors from the console – unaware that Chrome will purposely suppress those from reaching onerror, so they're never picked up by Raven.

unaware that Chrome will purposely suppress those from reaching onerror, so they're never picked up by Raven.

I didn't know that! : O

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!


NPM package 0.9.7 is not working. But 0.9.1 does

http://imgur.com/7CZskO1

Closing as I can't replicate this.
Webpack demo uses 0.9.7


Ratelimit errors when editing of less than 5 seconds

I have a bot that edits submissions at a very high rate. At peak usage times, it could edit a submission every three seconds for minutes straight. Since the bot is a moderator in the subreddit, I've never had commenting rate limit issues. But recently I've started getting "looks like you've been doing that a lot" errors when editing submissions. Always 1-3 seconds.
I went to turn on the ratelimit_seconds config so praw would handle these automatically, but realized it has a default of 5 seconds. I did some digging, but can't see any reason why praw wouldn't already be waiting here.
The bot was on praw 7.1.0, and I've updated to 7.2.0 just now, but I didn't see any changes in the related code between those versions.
2021-03-11 03:57:03,554 - WARNING: m1zn26: Traceback (most recent call last):
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/reddit.py", line 665, in post
    return self._objectify_request(
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/reddit.py", line 577, in _objectify_request
    return self._objector.objectify(
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/objector.py", line 178, in objectify
    raise RedditAPIException(errors)
praw.exceptions.RedditAPIException: RATELIMIT: "Looks like you've been doing that a lot. Take a break for 1 seconds before trying again." on field 'ratelimit'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "src/main.py", line 110, in <module>
    messages.processMessage(message)
  File "/home/watchful1/CFBRef/src/messages.py", line 806, in processMessage
    utils.updateGameThread(game)
  File "/home/watchful1/CFBRef/src/utils.py", line 197, in updateGameThread
    reddit.editThread(game.thread, threadText)
  File "/home/watchful1/CFBRef/src/reddit.py", line 110, in editThread
    submission.edit(text)
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/models/reddit/mixins/editable.py", line 47, in edit
    updated = self._reddit.post(API_PATH["edit"], data=data)[0]
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/reddit.py", line 680, in post
    return self._objectify_request(
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/reddit.py", line 577, in _objectify_request
    return self._objector.objectify(
  File "/home/watchful1/.local/share/virtualenvs/CFBRef-ajpGuYz5/lib/python3.8/site-packages/praw/objector.py", line 178, in objectify
    raise RedditAPIException(errors)
praw.exceptions.RedditAPIException: RATELIMIT: "Looks like you've been doing that a lot. Take a break for 3 seconds before trying again." on field 'ratelimit'

That error comes directly from Reddit, so you'll just have to wait the indicated amount of time before trying again.

I thought that's what the ratelimit_seconds config did? Automatically catch those exceptions, wait that amount of time and retry.

So what's happening here is it is sleeping for 1 second (the first exception), but then on the subsequent request it's asking it to sleep again which shouldn't happen.
Are you running more than one bot by any chance?

Not with this account.

Are you running more than one bot (regardless of account) on the same IP? Perhaps Reddit changed how overall rate limiting his happening.

Yes, I run a dozen or so bots all from the same server. But this is the only one that edits a large amount of posts and the only one that's having rate limit errors.

Fascinating. I suggest trying to replicate the logic to handle the exception yourself, and see if one extra round solves the issue. This does sound like a Reddit bug, perhaps worth posting to r/bugs.

This should be fixed now

u/kemitche

Source: https://old.reddit.com/r/redditdev/comments/mg077m/not_even_close_to_hitting_the_rate_limitbut_still/gstm1a9/
@Watchful1 can you monitor and report back if you still have issues please? If they are gone, will you please close? Thanks!

I'll go ahead and close. The errors were very intermittent anyway, so I don't anticipate being able to reproduce.


Use reviewdog for reviewing kotlin file changes

Reviewdog seems to show nicer content.

Converted to draft: without inputs specified, this seems to hang.

Let’s see if there are general review improvements we can try here. We tried reviewdog a while ago, and the flow wasn’t great, but we should try to revisit this more globally, not just for Kotlin.


Will you be working on Go implementation of this module too?

Hi,
Just curious, is the eks module going to stay in JS or are you planning to roll out implementation in other languages too?
Thanks,

That's good to know. We will stick to Node for now then :) Are you going to transpile from node to other languages?

Are you going to transpile from node to other languages?

Yes - we are looking into a few different paths we may go for enabling cross-language access to libraries like this one without maintaining independent ports in each language.

That's a good question.
As of now, we expect that we will do the translation by hand. We are not currently aware of a technology to do Node -> * transpilation in a satisfactory fashion.

Thanks for the quick replies. I will close this issue for now. Looking forward to the Go version :)


Provide an MdxProvider

I need an MdxProvider (https://mdxjs.com/docs/using-mdx/#mdx-provider) like in the react or vue version.

It is basically a necessity for use with solid-start pages and custom components

solid-jsx is a jsxImportSource, didn't have the intention to make it an mdx-provider also. I understand the use case, though, and may think about it.

Added the MDXProvider implementation in 7c387af19c751a61aed6e164eb299c54100d823f.


Quy tac ung xu

Abc

Type

Context

Parts of the app affected / Test plan

probably wrong project?


4 implementar forma de saber el ganador de un juego terminado

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

110 of 146 (75.34%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-20.0%) to 80.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/Board.class.st
63
67
94.03%

repository/IngSoft2-Model/DiceCup.class.st
0
16
0.0%

repository/IngSoft2-Model/GameInstance.class.st
22
38
57.89%

Totals

Change from base Build<PHONE_NUMBER>:
-20.0%

Covered Lines:
144

Relevant Lines:
180

💛  - Coveralls


[Proof of Concept] Fix login issue "Unable to connect to server"

Related issues:
Snkrs-Bot#68
Snkrs-Bot#21
I tried using the cookies from the original Google Chrome user data directory to avoid logging in from the Selenium browser which currently is facing issues due to Nike implementing a new Akamai bot detection service.
We could strip this script down to the basics and just use a quick link that auto-redirects to the checkout page. I am positive about the speed results.
Here is an example of a quick link : https://www.nike.com/in/launch/t/air-max-tailwind-v-skepta-bloody-chrome?size=7&productId=79f8d3ae-0364-582a-a8d9-efc2fdb3a968
PS. The productId is found by inspect element the shoe page and finding the term. The size is of the shoe.
I do not hope to see this exact PR getting merged as I just want to start a discussion and we could find a better solution to the issue from this start.

It's been so long since I've seen activity. Glad to see someone showing interest. Maybe I'll finally finish my PR


PreTag Centaur0 not Present  -  For which use case and system this Test case is written for ?

Code Snippet :
Centaur0 not Present
${uri} =    Set Variable    /org/openbmc/inventory/system/chassis/motherboard/membuf0
${x} =      Get Inventory Sensor Number   ${uri}
Run IPMI command  0x04 0x30 ${x} 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
Read The Attribute   ${uri}    present
Response Should Be Equal    False

From the Test Log:
${ret} = RequestsLibrary.RequestsKeywords . Get Request openbmc, ${base_uri}, &{kwargs}
Documentation: 	Send a GET request on the session object found using the
Start / End / Elapsed: 	20160530 23:33:51.833 / 20160530 23:33:52.291 / 00:00:00.458
23:33:52.290 	INFO 	Get Request using : alias=openbmc, uri=/org/openbmc/inventory/system/chassis/motherboard/membuf0/attr/present, headers=None
23:33:52.291 	INFO 	${ret} = <Response [200]>
Documentation: 	Convert a string to a JSON object
Start / End / Elapsed: 	20160530 23:33:52.300 / 20160530 23:33:52.301 / 00:00:00.001
23:33:52.301 	INFO 	To JSON using : content={
"data": "True",
"message": "200 OK",
"status": "ok"
}
23:33:52.301 	INFO 	To JSON using : pretty_print=False
23:33:52.301 	INFO 	${content} = {u'status': u'ok', u'message': u'200 OK', u'data': u'True'}
23:33:52.302 	INFO 	${output} = True
From the test , it is expecting not present but it returns present , so it failed.. From Test Expectation point of view this is working as expected... but is there a use case for this and when this will be PASSED ?
On Palmetto:
openbmc-automation$ curl -c cjar -b cjar -k -H "Content-Type: application/json" -X GET https://<IP_ADDRESS>/org/openbmc/inventory/system/chassis/motherboard/membuf0/attr/present
{
"data": "False",
"message": "200 OK",
"status": "ok"
}
On Barrelleye:
openbmc-automation$ curl -c cjar -b cjar -k -H "Content-Type: application/json" -X GET https://<IP_ADDRESS>//org/openbmc/inventory/system/chassis/motherboard/membuf0/attr/present
{
"data": "False",
"message": "200 OK",
"status": "ok"
}rango@ubuntu:~/FTC_OPENBMC_TEST/openbmc-automation$
In both cases it seems to be present..
Trying to understand.. what this test is intended for... For a system where Centaur0 is not present this would be a pass.. thinking what it adds value in breaking the test as failure when they are present.

I had a discussion with the development folks.. As per the test case flow..
Centaur0 Present
Run IPMI command  0x04 0x30 ${x} 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
Centaur0 not Present
Run IPMI command  0x04 0x30 ${x} 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
It set and checks if its enabled.. then it disables and verify if its disabled..
It looks like this is a code issues..
Will close this and open new Open BMC ticket..

https://github.com/openbmc/openbmc/issues/311


Node Js cluster: process fork is not working

Describe the bug
I'm trying to use the cluster module of node js. I tried running my code using node it's working perfectly but when I'm trying to run the same code using npx vite-node ./file-path it works for primary cluster but when it comes to worker threads it says No files specified.
import cluster from 'cluster';
import os from 'os';

if(cluster.isPrimary) {
  console.log('invoked primary thread')

  for(let i =0; i< os.cpus().length; i+= 1) {
    const worker = cluster.fork();
    worker.send(i);
  }

} else if(cluster.isWorker) {
  process.on('message', (msg)=> {
    console.log('On Worker - ', msg);
  })
}

Output:
invoked primary thread
- No files specified.
vite-node/1.3.1

Usage:
  $ vite-node [...files]

Commands:
  [...files]

For more info, run any command with the `--help` flag:
  $ vite-node --help

Options:
  -r, --root <path>    Use specified root directory
  -c, --config <path>  Use specified config file
  -m, --mode <mode>    Set env mode
  -w, --watch          Restart on file changes, similar to "nodemon"
  --script             Use vite-node as a script runner
  --options <options>  Use specified Vite server options
  -v, --version        Output the version number
  -h, --help           Display help for command
  -v, --version        Display version number
  ... so on

Expected Output:
invoked primary thread
On Worker -  0
On Worker -  1
On Worker -  2
On Worker -  3
On Worker -  4
On Worker -  5
On Worker -  6
On Worker -  7
On Worker -  8
On Worker -  9
On Worker -  11
On Worker -  10
On Worker -  12
On Worker -  13
On Worker -  14
On Worker -  15

Reproduction
To reproduce bug,

run yarn init -y
create index.ts
paste the following code in index.ts

import cluster from 'cluster';
import os from 'os';

if(cluster.isPrimary) {
  console.log('invoked primary thread')

  for(let i =0; i< os.cpus().length; i+= 1) {
    const worker = cluster.fork();
    worker.send(i);
  }

} else if(cluster.isWorker) {
  process.on('message', (msg)=> {
    console.log('On Worker - ', msg);
  })
}

run npx vite-node ./index.ts

System Info
Host Name:                 DESKTOP-NOCCTH7
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.19045 N/A Build 19045
Node Js Version:           v20.10.0
yarn version:              1.22.19
npm version:               9.8.1

### Used Package Manager

yarn

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitest-dev/vitest/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitest-dev/vitest/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitest.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/vitest-dev/vitest/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitest-dev/vitest/discussions) or join our [Discord Chat Server](https://chat.vitest.dev).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

Interesting. I'm not sure what's happening yet, but at least ts-node supports this somehow, so maybe it's possible for vite-node too.
https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vitest-5323-vite-node-cluster?file=index.ts
$ npx ts-node index.ts
[isPrimary] {
  args: [],
  exec: '/home/projects/rlmixvjzk.github/index.ts',
  execArgv: [
    '/home/projects/rlmixvjzk.github/node_modules/ts-node/dist/bin.js'
  ],
  silent: false
}
[isWorker]
[isWorker.msg] 0

$ npx vite-node index.ts
[isPrimary] {
  args: [],
  exec: '/home/projects/rlmixvjzk.github/node_modules/.bin/vite-node',
  execArgv: [],
  silent: false
}
No files specified.
vite-node/1.3.1

Usage:
  $ vite-node [...files]
...

It looks like ts-node mutates process.execArgv https://github.com/TypeStrong/ts-node/blob/ddb05ef23be92a90c3ecac5a0220435c65ebbd2a/src/bin.ts#L586-L587
Currently vite-node mutates process.argv, which is already somewhat complicated due to https://github.com/vitest-dev/vitest/pull/3574 and https://github.com/vitest-dev/vitest/pull/2793), so probably it requires more thinking if we want to get all scenarios right.
For the time being, I think you can use cluster.setupPrimary to manually fix up fork arguments. For example, this seems to work for your example:
https://stackblitz.com/edit/github-kfifdx?file=index-fix.ts
cluster.setupPrimary({
  args: [import.meta.filename],
})

it started working but I'm not able to send messages from parent to child
import cluster from 'cluster';

if (cluster.isPrimary) {
  cluster.setupPrimary({
    args: [import.meta.filename],
  });
  console.log('[isPrimary] settings', cluster.settings);
  const worker = cluster.fork();
  worker.send('hello from primary')
  worker.on('message', (message) => {
    console.log('[isPrimary] received :', { message });
  });
} else if (cluster.isWorker) {
  const message = 'hello from worker!';
  console.log('[isWorker] sending :', { message });
  process.on('message', (msg)=> {
    console.log('child ', msg)
  })
  process.send(message);
}

Yeah, I noticed that in your example, but I assumed that's simply because of a race condition and you probably need to wait until worker side process.on is set up. For example, you could wait worker.send in this way:
https://stackblitz.com/edit/github-kfifdx-3xmjq2?file=index-fix.ts

@hi-ogawa Thanks! I tested the same code on ts-node it's working there. maybe you need to fix this later cuz in this case, we're adding lots of code to make this happen but in ts-node we don't have to be.

I tested the same code on ts-node it's working there

Yeah, I understand and also plain Node works with this. But, the reason why they works might be just a lucky since there's not guarantee how long it takes from parent's worker.fork to child's process.on.
For example, if your PC and CPU is loaded with other heavy tasks, then it's possible that this race condition would manifest even for ts-node and plain Node.
I think usual practice is to put some retry mechanism to ensure initial hand-shake to counter against such race condition. Or actually waiting for a message from a child to a parent seems better since this direction is probably guaranteed to be race condition free (cf. https://stackoverflow.com/a/66190604)
Btw, keeping this issue open is fine since the workaround cluster.setupPrimary({ args: [import.meta.filename] }) looks shaky.


feat: Added step function for script runner

The script runner now supports stepping through it. This branch includes the changes for the arrows so I'll raise the PR to that branch for now so you can see the diff easily. Once the arrows PR is merged this PR base branch should be changed to the chap9-lesson-component branch on Tuedons fork.

I think onChange of any input field stops at the first step
https://github.com/user-attachments/assets/029ca4ef-39b1-4c8e-8b33-a197f1ea81f3


Forbid using array annotations with non-array types

see #86

It's perfectly okay. All the items in the schema are optional, nothing is required and nothing is forbidden. They're just ignored. We're on the same boat as JSON Schema, relaxed schema.


Link models just Insert into DB without performing behaviors of related models

When linking models are not performed the behaviors of the model for the associated relation.
What steps will reproduce the problem?
For example:
Model Provider, Model Game, Model ProviderGame.
Provider relation  hasMany "games" via table ProviderGame.
After successful validation I saved Game model and then link Game to Provider through relation "games".
What is the expected result?
Behavior for the ProviderGame model will be performed , eg. TimestampBehavior, rules etc.
What do you get instead?
Instead of working with the model happens insert record into DB by commandBuilder
https://github.com/yiisoft/yii2/blob/master/framework/db/BaseActiveRecord.php#L1232
/* @var $viaTable string */
static::getDb()->createCommand()
    ->insert($viaTable, $columns)->execute();

Additional info

Q
A

Yii version
2.0.7

PHP version
5.6

Operating system
Linux Mint Rosa / Cinnamon (64-bit)

This is expected behavior. You should not use link() method in case you need to run validation on junction model - in this case model should be populated and validation manually.


Adding Docker Generation Files

This Adds a Dockerfile for container image generation and a Makefile to operate the image. make help provides help for the Makefile targets.
Please feel free to change the docker registry namespace. I was using my personal namespace (maneta) for  to test the deployment.
The requirements to run this are:

GNU Make
Docker

Thanks!  I'll give this a try tomorrow.

Yes! let me know if something does not make sense for you... This is just the first step, I think the main go would be to use s2i , configure some pipeline integration with travis and create openshift templates for it. Something like we have here:

https://github.com/3scale/apicast

Great, thanks!


Jobs have an array of init containers

Closes https://github.com/redkubes/unassigned-issues/issues/230.
Please also close the API PR:

BTW if you want a quick test: otomi template -l group=jobs.


New UI enters infinite loop when trying to Redeploy

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have removed any sensitive information from my code snippets and submission.

Amplify Hosting feature
Deployments
Is your feature request related to a problem? Please describe:

Go to deployments screen
Select an old deployment
Hover over Redeploy button

Browser will not let you redeploy. The button enters an infinite loop getting mounted/unmounted from the DOM and requesting the /jobs endpoint
https://github.com/aws-amplify/amplify-hosting/assets/22029976/d5890e83-1679-48bc-aa41-6a6a61d1c523
Describe how you'd like this feature to work
Redeploys should work

Hi @samstash 👋 , we have deployed a fix for this issue. Can you please verify and confirm whether you are able to now select the Redeploy button from the console? Thanks!

Closing this thread since a fix has been deployed.


xquartz: add new versions + mark latest

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

I got rid of X11 locally about a year ago but I pulled these numbers from the .pkg. Figured they might as well be updated.

Thanks again @DomT4!

I got rid of X11 locally about a year ago

Thanks Mike! I'm certainly not complaining any time soon about no longer lugging around an X11 installation 😸.


Investigate mutual exclusivity of small radios and conditionally revealing content

This combination was reported as broken in the Design System by @rjlynch in https://github.com/DFE-Digital/govuk_elements_form_builder/pull/29
If this is the case and the two classes aren't meant to be used in conjunction, it's probably worth at least showing a warning, or maybe blowing up with an error.

[x] Test the various combinations of small radios and checkboxes with revealing content and see if it works
[ ] Respond accordingly with a warning or error 💥

This doesn't actually to be a problem.


502 Bad Gateway

Links in the description and on the website don't work.
Is there any documentation available at other places, where could I find more information about setting up an instance, etc. in order to develop it further?

Like demo site is down:(

Bump.
Is this project active?

A little bit of talk about migrating Mamute to Spring but I haven't see any work going on. If you are okay with Scala https://github.com/JamesSullivan/manmosu has been updated more recently.

The docs link to questions that have been posted on Mamute Meta. This site is down. When will it be back up?

cc @Turini could you see  what is wrong  with website?

the meta.mamute.org never back again?


Unused imports backport

Backport of https://github.com/spcl/dace/pull/1803 to v1/maintenance.
/cc @phschaad as discussed

#1816 takes care of this


Execute on OPA Server fails

From the documentation
Execute on OPA Server
One of the major strengths of OPADotNet is that it runs all the policies embedded in the application which provides better performance. But it is possible to have all policy checks to be done on a remote OPA server instead.

This is done by setting the following configuration:

services.AddOpa(opt =>
  opt.UseOpaServer("https://pathtoopa")
);
When using a remote OPA server, the other configurations such as syncs, discovery etc will not work since they require the embedded OPA.

When following this configuration, starting the application fails, throwing an exception.
System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=OPADotNet.AspNetCore
  StackTrace:
   at OPADotNet.AspNetCore.Builder.OpaBuilder.Build()

@Ulimo something to look into


Pulling token signing keys from environment

Session token signing keys should still be cycled regularly but to better support Fly.io deployments, the daemon should optionally take in a token signing key from the environment.

Fixed by 8940955 and confirmed just now.


Firewall Ports, Services, and IP addresses for allowing a web application to authenticate users using AAD B2C

It would be helpful to have details here for what rules, destination URLs/IP Addresses, Ports need to be allowed from a DMZ hosted web application server that is leveraging the AAD B2C user authentication within the application on that server.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df26c5f6-63b9-d281-5724-c0731546b087
Version Independent ID: 239bf87c-fcf0-b35e-744d-fecbb55501e4
Content: Tutorial - Grant access to an ASP.NET web API from a web app using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-tutorials-web-api.md
Service: active-directory
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@liitimellison
Thanks for your feedback! We will investigate and update as appropriate.

@liitimellison I appreciate the feedback and am going to relay your request to the engineering team to possibly assist me in putting this type of information in a conceptual article. For example the B2C overview or FAQ. But we don't want to add that type of conceptual content to the tutorials themselves. Thanks again.
#please-close


VMR-lite fails to build

Since source-build is building online with prebuilts from dotnet/installer main as of https://github.com/dotnet/installer/commit/4e3f7ef1087e0e083c65960c58f3d13170a633e0, the VMR-lite should also be able to build.
As of https://github.com/dotnet/dotnet/commit/e5d77bf568729b29ee6c5a3f19c33d88ee9d592a, It is failing in runtime-portable with the following error:
    System.Private.CoreLib.Generators -> /data/vmr/try1/src/runtime/artifacts/source-build/self/src/artifacts/bin/System.Private.CoreLib.Generators/Release/netstandard2.0/System.Private.CoreLib.Generators.dll
    Microsoft.Interop.SourceGeneration -> /data/vmr/try1/src/runtime/artifacts/source-build/self/src/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll
    LibraryImportGenerator -> /data/vmr/try1/src/runtime/artifacts/source-build/self/src/artifacts/bin/LibraryImportGenerator/Release/netstandard2.0/Microsoft.Interop.LibraryImportGenerator.dll
    System.Private.CoreLib -> /data/vmr/try1/src/runtime/artifacts/source-build/self/src/artifacts/bin/System.Private.CoreLib/ref/Release/net7.0/System.Private.CoreLib.dll
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018: The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly. [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '/data/vmr/try1/src/runtime/artifacts/source-build/self/src/artifacts/bin/microsoft.netcore.app.ref/ref/net7.0/'. [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at System.IO.FileSystem.GetAttributes(String fullPath) [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompatibility.AssemblySymbolLoader.AddReferenceSearchDirectories(IEnumerable`1 paths) in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompatibility/AssemblySymbolLoader.cs:line 52 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompatibility.Runner.ApiCompatRunner.GetAssemblySymbolFromStream(Stream assemblyStream, MetadataInformation assemblyInformation, ApiCompatRunnerOptions options, Boolean& resolvedReferences) in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompatibility/Runner/ApiCompatRunner.cs:line 165 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompatibility.Runner.ApiCompatRunner.ExecuteWorkItems() in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompatibility/Runner/ApiCompatRunner.cs:line 56 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompat.ValidateAssemblies.Run(Func`2 logFactory, Boolean generateSuppressionFile, String suppressionFile, String noWarn, String[] leftAssemblies, String[] rightAssemblies, Boolean enableStrictMode, String[][] leftAssembliesReferences, String[][] rightAssembliesReferences, Boolean createWorkItemPerAssembly, ValueTuple`2[] leftAssembliesTransformationPatterns, ValueTuple`2[] rightAssembliesTransformationPatterns) in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ValidateAssemblies.cs:line 106 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask.ExecuteCore() in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompat.Task/ValidateAssembliesTask.cs:line 107 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /tarball/src/sdk/artifacts/source-build/self/src/src/Tasks/Common/TaskBase.cs:line 40 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask.Execute() in /tarball/src/sdk/artifacts/source-build/self/src/src/ApiCompat/Microsoft.DotNet.ApiCompat.Task/ValidateAssembliesTask.cs:line 96 [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
  /data/vmr/try1/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/7.0.100-rc.1.22429.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(15,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/data/vmr/try1/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

  Build FAILED.

Steps to reproduce

clone https://github.com/dotnet/dotnet
run ./prep.sh && ./build.sh --online inside a Fedora 36 container: mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-36

cc @premun. I'm unsure if you have another place you want to track this work but figured I would file this issue since I was testing the VMR and observed this.

One reason I see for this is that only the src content is being sync'd.  The PR I made to get source-build working included changes to the tarball's content files.  Those only went into installer.  The process we need to follow now while we are still producing the tarball and up to the point where we declare the VMR stable and won't recreate it need to be documented/automated.

Depending on when/if we need to regenerate the VMR, could that be resolved by submitting a PR to the VMR directly to edit its non-src content? Otherwise it seems like we'd need to regenerate it for every update to tarball's content in installer. That could also be a problem if we decide to delete the tarball infrastructure in the future.

We will be regenerating the VMR this week for sure. Possibly next Monday too.
For files in tarball/content, we do indeed to have some process. Let's talk about it on Thursday?

[Triage] @premun, Can you close this once the VMR content is re-synced with installer?  TIA.

Will do, ETA tomorrow

Pre-requisite to this is automated synchronization of the tarball/content with VMR's root: https://github.com/dotnet/arcade/issues/11500

I have merged some fixes and updates for the tooling and once https://github.com/dotnet/installer/pull/14893 merges, I can rebuild the VMR again. Won't make that today but on Monday.
I couldn't do it earlier because I had a very weird "chicken & egg & something third" situation between the initialization, the initial bootstrap of the content and the README not being ready yet as it's in a PR.
I expect to re-build the VMR again next week after the README PR and Matt's UB docs PR are in to double check all links between the README and the docs.

The VMR should now be automatically synchronized and should have the same contents as the tarball.
Non-src/ content PRs can be made in installer.
Validation for installer PRs is the next step.
This is the pipeline that runs internally on top of installer's main and synchronizes the VMR:
https://dev.azure.com/dnceng/internal/_build?definitionId=1189&_a=summary&branchFilter=152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838%2C152838

I will compare the contents with the tarball once more and close this if it matches

I am comparing the contents and I noticed that the tarball also copied the eng/common folder over. We're missing that now.
We're also missing some text-only packages that are not being regenerated automatically (just on bootstrap as they need MSBuild).

PR for supporting copying the content around more flexibly:
https://github.com/dotnet/arcade-services/pull/2102

Diff after the latest feature changes:

🚫 - is in tarball, missing in VMR
✅ - is in VMR, is not in tarball

🚫./src/aspnetcore/src/Security/samples/ClaimsTransformation/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/ClaimsTransformation/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/ClaimsTransformation/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/aspnetcore/src/Security/samples/Cookies/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/Cookies/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/Cookies/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/aspnetcore/src/Security/samples/DynamicSchemes/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/DynamicSchemes/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/DynamicSchemes/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/aspnetcore/src/Security/samples/Identity.ExternalClaims/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/Identity.ExternalClaims/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/Identity.ExternalClaims/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/aspnetcore/src/Security/samples/PathSchemeSelection/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/PathSchemeSelection/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/PathSchemeSelection/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/aspnetcore/src/Security/samples/StaticFilesAuth/wwwroot/lib/jquery-validation-unobtrusive/.bower.json
🚫./src/aspnetcore/src/Security/samples/StaticFilesAuth/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
🚫./src/aspnetcore/src/Security/samples/StaticFilesAuth/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V1/MTTestLib1.Dll
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V1/MTTestLib2.Dll
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V2/MTTestLib1.Dll
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V2/MTTestLib3.Dll
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V3/MTTestLib1.Dll
🚫./src/roslyn/src/Compilers/Test/Resources/Core/SymbolsTests/V3/MTTestLib4.Dll
✅./src/source-manifest.json
✅./src/source-mappings.json

I think we can close this. The VMR now builds fine.


[Autocomplete] add infinite scroll for tags

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
Do mui support an infinite scroll on a div/paper/semething?

Examples 🌈
I have to render more than 4000 tags, so I want that on scroll, more tags will appear (not all tags will be on the dom, but only some), otherwise it will be very slow
is there a solution for me?

Motivation 🔦

You can find a duplicate thread about it in the history.

ok, thanks
Can you write down the number of his duplicate, please?
It will really help

Your own issue #20782

use condition on the renderTags to make it scrollable onFocus. Here is an Example
renderTags={(value, getTagProps) => {
if (this.state.showOwnersScroll) {
return (

{value.map((option, index) => (
 10
? option.title.substring(0, 7) +
"..."
: option.title
}
size="small"
{...getTagProps({ index })}
/>
))}
);
} else {
return value.map((option, index) => (
 10
? option.title.substring(0, 7) + "..."
: option.title
}
size="small"
{...getTagProps({ index })}
/>
));
}
}}
onFocus={() =>
this.setState({ showOwnersScroll: true })
}
onBlur={() =>
this.setState({ showOwnersScroll: false })
}


Draft for release version : next-.21 to the master branch

This is just a draft.
This is where some of the features which are in the Alpha branch might not be added to the main branch.
This is a draft of the features which can be added to the main branch.
Main reason for draft : To unify and organize all components of FalconXOS and add features which make it easy to use FalconXOS
The draft covers the following features :
-A special library for making FalconXOS better and organized
-A fully functioning inputstream
-A .md-reader type of thing where you can read the .md files and output it.
-Draft is not complete and will be added.
-See the changes in this pull request for the full draft
-Draft is subject to change and the features above might not be added
Draft number : .21.=PreDev-MainWindows
Draft version : when released - .23.9
Draft introduced by : DaVikingMan, Author of FalconXOS
Draft Signed by : DaVikingMan
Draft Start Date : 17 October 2021
Draft Signed-off by : DaVikingMan
Signed-off by : DaVikingMan(Since I am the only developer which is currently developing FalconXOS, all of the signs are of mine)

Draft edited


Fix bootstrap generator setUpClass errors logs not being framed

Same as #38, but for BootstrapGeneratorBaseTest.
ref b/326800953

[ ] grpc/java/v1.62.x/branch/xds_k8s_lb


Does this work with the github profile README.md?

Does this work with the github special profile README.md?

If it does then it does not work for me

Why dont you try it? No one has been around here for a long time, so YMMV with this old project. Let us know.

I did try, and it did not work, that's why I'm asking if it works with it.
On Wed, Jun 16, 2021 at 12:52 PM the-j0k3r @.***> wrote:

Why dont you try it? No one has been around here for a long time, so YMMV
with this old project. Let us know.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StylishThemes/GitHub-Custom-Emojis/issues/5#issuecomment-862668558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2PGQVSFJ6SMESG5TNFIG3TTD6IXANCNFSM462CFP4A
.

If you tried and didnt work then its only meant for comments. Which means short answer to your Q is no.

ok, that's all you had to say
On Thu, Jun 17, 2021 at 5:10 AM the-j0k3r @.***> wrote:

If you tried and didnt work then its only meant for comments. Which means
short answer to your Q is no.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StylishThemes/GitHub-Custom-Emojis/issues/5#issuecomment-863185310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2PGQWIMY4PLKC3N5WFEXTTTHQ3JANCNFSM462CFP4A
.

Ive not used this in a long long time, hence I asked. thx for confirming it.

:_alot_of_work:


Redesign lifecycle_manager_kyma_status metrics

One of the challenges of monitoring and alerting systems is to deal with high cardinality of metrics, which means having a large number of possible combinations of labels and values for each metric. High cardinality can lead to performance issues, increased storage costs, and reduced query efficiency. Therefore, the amount of labels should be carefully considered when designing metrics.
At the moment, for this lifecycle_manager_kyma_status metric, we have 4 labels:
prometheus.Labels{
	kymaNameLabel:   kymaName,
	stateLabel:      string(newState),
	shootLabel:      shoot,
	instanceIDLabel: instanceID,
})

Assuming that there are N Kyma instances on N SKR clusters, and that each instance can have one of three possible states (ready, processing, or error), the total number of time series identifiers generated by this metric will be N^3 * 3.
It may not be necessary to have three labels that represent the same thing: the SKR cluster. In fact, normally the shoot, kyma, and instance should represent the same SKR cluster, so we don't need to distinguish them by different labels.
AC

[ ] Clarify the meaning of those labels with SRE, find a solution if we can reduce to only one label representing all instances.
[ ] Redesign the  lifecycle_manager_kyma_status metric to reflect the new decision.
[ ] Create or adjust the existing Grafana dashboard panel for this metric.

Since there will be 1:1 relationships between shoot, instanceID and kyma name the cardinality will not be high. There will be four unique metrics for each Kyma due to state labels. Verified with SRE and closing this.


Responsive slider

Hello,
Thank you for making this cool directive! I have a problem making the slider responsive. I've had a look at the previous issues, and took this as an example, but it did not seem to work.
This is my code:
<ks-swiper-container                                 override-parameters="{ 'breakpoints': { '320': { 'slidesPerView': '1' }, '640': { 'slidesPerView': '2' }, '768': { 'slidesPerView': '2' }, '1024': { 'slidesPerView': '3' } }}"                                 initial-slide="0" loop="false" show-nav-buttons="true" slides-per-view="3"                                 space-between="50" pagination-hide="true" grab-cursor="true"                         >
I'm hoping you can help me with a solution.

I also experienced the same problem, maybe you need to upgrade swiper.js to the latest version.


New parameters are added for INVOICEADD,INVOICEEDIT,SESSIONTOKEN,POSTAUTH actions. New currency is added for UKRAINE PROCESSING CENTER.

New parameters are added for INVOICEADD,INVOICEEDIT,SESSIONTOKEN,POSTAUTH actions. New currency is added for UKRAINE PROCESSING CENTER.

Thanks Sercan!


Docker restart causes pods to lose connectivity

Looks like Felix doesn't handle the renaming of the host side veth nicely.  See https://github.com/projectcalico/calico/issues/1075
We could work around this by deleting / re-creating the endpoint rather than updating it.
@tomdee are you OK with this as a workaround?  We need to handle this case for the v1.4 release.

You'd really need to delete and re-add with a different ID to force Felix to do the right thing in all cases.  Given this is causing real problems, I'm inclined to fix Felix (but the workaround might still give a quicker fix).

@tomdee and I were just discussing this, and we think that we should be looking to fix this in Felix.  The workarounds required in the CNI plugin would muddle the clarity / meaning of the WorkloadID and/or endpointID fields.
@fasaxc Is this something you (or @matthewdupre) have bandwidth to tackle, and how long would it take?  @robbrockbank is planning on a new calico/node release this week and we'd like to get a fix for this in.

@caseydavenport Will this just work now that felix is fixed?

@tomdee Yes.  Requires re-testing with calico/node:v0.21.0.

OK - tested and working with v0.21.0


qmake translation tag typo's

lrelease error: Unexpected tag <translatio> at /home/neo/Downloads/deeponion/src/qt/locale/bitcoin_sc.ts:824:20
lrelease error: Unexpected tag <translatio> at /home/neo/Downloads/deeponion/src/qt/locale/bitcoin_sc.ts:1013:20
lrelease error: Parse error at /home/neo/Downloads/deeponion/src/qt/locale/bitcoin_sc.ts:2593:14: Opening and ending tag mismatch.
lrelease error: Parse error at /home/neo/Downloads/deeponion/src/qt/locale/bitcoin_sc.ts:2873:55: Expected ';', but got '<'.
lrelease error: Parse error at /home/neo/Downloads/deeponion/src/qt/locale/bitcoin_sc.ts:3210:47: Expected ';', but got ' '.
Fixes to get it to build attached.
bitcoin_sc.ts.txt

same here. Using ubuntu 16.04. any fix for this?

See the file I attached, you'll have to fix it your self until the dev team pull in the change. I think someone has added a pull request.

Closed accidentally!

I just made a pull request: #18

This should really be addressed. It's such a simple pull request, why is nobody actively developing on this repository?


Added known validity duration issue to README

Signed-off-by: Brady Siegel<EMAIL_ADDRESS>

/assign @anbaig

/approve


Dockerfile for ubuntu desktop

It would be nice to include an example Dockerfile of a full Ubuntu desktop (with dbus ) environment that allows easy installation of any software.

I agree, there will definitely be an "empty" desktop image that will be available sooner rather than later. My only gripe with that is that it should be a starting point for anyone to make their own image with the software that they want instead of being the place where you install packages at runtime..
The main issue with that approach is that, given the nature of Docker, everything you'll install will be wiped on a restart. If instead you make your own image that will be always ready no matter what.

2db016dc64f287fa541c97b922d20f493fedf403

2db016dc64f287fa541c97b922d20f493fedf403


Documentation does not cover all of mod functonality

While the API covers functions to check values and to create fake players, inventories, etc... there are many more functions that remain to be documented. For example, the Dynamic Get/Set functions in player.lua are completely undocumented.
One of the strengths of this mod and a great selling point for adaptation is the fact that it comes with these functions, which fake player code in other mods often lack. Documenting them will help advertise this strength, and help ensure they are used by mod authors.
Also, an example for setting metadata would be beneficial for coders new to Minetest / Lua.

Those functions are not documented because they are designed to exactly replicate the real player functions, which are all documented in the engine documentation: https://github.com/minetest/minetest/blob/master/doc/lua_api.md#objectref


fqdn template: allow adding classes per host

Allow to declare classes/steps per host. Yay !

Thaank you Mr of the internet.


How can we prevent VS for Mac downloading the MS-Dist OpenJDK?

I think there's must some guys like me who has already install an OpenJDK (such as Amazon Coretto) on their mac, install MS-Dist OpenJDK seems useless to us, how can we prevent VS for Mac downloading and installing the OpenJDK automatically?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97e1cd96-e7a2-ec22-8d79-ac949e890ccb
Version Independent ID: 922a3fdf-7bab-7d9d-5518-904db9e75ee3
Content: Microsoft's Mobile OpenJDK Distribution - Xamarin
Content Source: docs/android/get-started/installation/openjdk.md
Product: xamarin
GitHub Login: @vyedin
Microsoft Alias: vyedin

Hi Chino, unfortunately we don't test or officially support other JDK distributions, and because we really want to make sure people have a working setup ootb, we install the JDK we support.


Updates for Russian translation

Fix and update Russian translation.
Fix typo in docs/guide/concept-di-container.md.

https://github.com/yiisoft/yii2/commit/f3fddb2993890cc6b30e6636277a74cb8719513c Thanks!


I am getting an error like this when using sliver appbar, what do i do

Failed assertion: line 5822 pos 12: 'child == _child': is not true

I solved the problem by doing flutter clean ..thanks

Closing as resolved.


error: module compiled with Swift 4.2 cannot be imported in Swift 4.1.2:

i had installed Sourcery via building with XCode 10 from sources (last release 0.15.0)
so everything is fine with .stencil templates, but with .swifttemplate (AutoCodable) i get this error
$ Sourcery.app/Contents/MacOS/Sourcery --sources <sourcesPath> --templates <AutoCodable.swifttemplate> --output <outputPath>
No config file provided or it does not exist. Using command line arguments.
Scanning sources...
Found 77 types.
Loading templates...
Loaded 1 templates.
Generating code...
error: /var/folders/j3/19jmj93j46n7yj3lyy53b0280000gn/T/SwiftTemplate.build/main.swift:2:8: error: module compiled with Swift 4.2 cannot be imported in Swift 4.1.2: /var/folders/j3/19jmj93j46n7yj3lyy53b0280000gn/T/SourceryRuntime.framework/Modules/SourceryRuntime.swiftmodule/x86_64.swiftmodule
import SourceryRuntime
       ^

so there is some problem with Swift 4.2 and .swifttemplate templates
same error happens with prebuilt binary and cocoapods
this error not happens on previous version 0.14.0

same things happens with prebuilt binary

That means that the template is built using swift 4.1.2
What is the output of swift --version ?

I downloaded archive attached to the 0.15.0 release, and run ./bin/Sourcery.app/Contents/MacOS/Sourcery --sources Test.swift --templates Templates/AutoCodable.swifttemplate --output ./Generated --disableCache --verbose
This successfully generated expected output.
swift --version returns
Apple Swift version 4.2 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin17.7.0

I have only Xcode 10 installed.
Please ensure that swift --version returns expected output, it might be that you have several versions of swift environment or Xcode installed, in this case you might need to run Xcode-select

If you don't need AutoCodable templates to be run - remove them from templates folder

oh, i see, its trully was a swift 4.1.2. I have updated Command Line Tools to the latest and now its swift 4.2.
in first time after update i got same issue as here https://github.com/krzysztofzablocki/Sourcery/issues/678, but --disableCache attribute completely fix this problem for me.
thank you.


See context around search

Often when I do a search, e.g. I search for a specific request, I want to be able to see context around that search, e.g. the request that happened before or after - Would it be possible to somehow add the possibility to show x lines before / after each search result? Not sure what the best approach here would be, I could either imagine "dynamically", so that each search result has a link/button to shore more context arond it, or simply a static config "show x lines before/after each serach result.
What do you think?

@Globegitter Thanks for the suggestion. Need to check if this facility is available in elasticsearch query.

That is a good point @sivasamyk - I had a quick look into it and could find these things: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-range-query.html, https://discuss.elastic.co/t/get-previous-and-next-document-ids-with-a-filtered-query/31877, https://stackoverflow.com/questions/30487320/get-previous-and-next-document-by-date-in-elasticsearch
The last two links are a bit older now, but there mugger not be a really elegant solution.

Kibana uses this when clicking to see surrounding documents:
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-search-after.html
It makes same query twice using order asc and desc to get the documents before and after.

Any progress on this? Would be a very helpful addition

context would be great!