cannot build inkscape on osx

Issue description
nix-env -i inkscape-0.91 failed on osx 10.9.5
Steps to reproduce
$ nix-env -i inkscape-0.91
...
In file included from context_surface_quartz.cc:21:
In file included from ../cairomm/quartz_surface.h:25:
/nix/store/v0l98kv189gk6c6d714rm0zc1gxgfhrm-cairo-1.14.6-dev/include/cairo/cairo-quartz.h:43:10: fatal error: 'ApplicationServices/ApplicationServices.h' file not found
#include <ApplicationServices/ApplicationServices.h>
         ^
1 error generated.
Makefile:561: recipe for target 'context_surface_quartz.lo' failed
make[2]: *** [context_surface_quartz.lo] Error 1
make[2]: Leaving directory '/private/var/folders/cy/4988f14n4r35fp39wrt1pfq80000gn/T/nix-build-cairomm-1.12.0.drv-0/cairomm-1.12.0/cairomm'
Makefile:622: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/private/var/folders/cy/4988f14n4r35fp39wrt1pfq80000gn/T/nix-build-cairomm-1.12.0.drv-0/cairomm-1.12.0'
Makefile:472: recipe for target 'all' failed
make: *** [all] Error 2
builder for ‘/nix/store/qc7v83m39siikalwwhip8z8s0yca6r2w-cairomm-1.12.0.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/w23jjgbqa3f5nnik8m8322v5r575828y-gtkmm-2.24.4.drv’: 1 dependencies couldn't be built
building path(s) ‘/nix/store/gvcg3brsj9zxda6fjwnvdxzxjdaqjlrm-python-2.7.11-bootstrapped-pip-8.1.2’
killing process 71136
cannot build derivation ‘/nix/store/5zb2z0hgy71jvybbvadqx5rqcj4jbg17-inkscape-0.91.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/5zb2z0hgy71jvybbvadqx5rqcj4jbg17-inkscape-0.91.drv’ failed
$

Technical details

System: Darwin Kernel Version 13.4.0: Mon Jan 11 18:17:34 PST 2016; root:xnu-2422.115.15~1/RELEASE_X86_64 x86_64
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: "16.09pre83147.df89584"

That seems like cairo should propagate some of those dependencies. Perhaps this?
diff --git a/pkgs/development/libraries/cairo/default.nix b/pkgs/development/libraries/cairo/default.nix
index f6f0a0d..978e6aa 100644
--- a/pkgs/development/libraries/cairo/default.nix
+++ b/pkgs/development/libraries/cairo/default.nix
@@ -25,17 +25,19 @@ stdenv.mkDerivation rec {
   nativeBuildInputs = [
     pkgconfig
     libiconv
-  ] ++ libintlOrEmpty ++ optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [
-    CoreGraphics
-    ApplicationServices
-    Carbon
-  ]);
+  ] ++ libintlOrEmpty;

   propagatedBuildInputs =
     with xorg; [ libXext fontconfig expat freetype pixman zlib libpng libXrender ]
     ++ optionals xcbSupport [ libxcb xcbutil ]
     ++ optional gobjectSupport glib
     ++ optional glSupport mesa_noglu
+    ++ optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [
+        CoreGraphics
+        ApplicationServices
+        Carbon
+      ])
+
     ; # TODO: maybe liblzo but what would it be for here?

   configureFlags = if stdenv.isDarwin then [

How do I test this patch?
Patch /nix/store/phqb57liyaqm9jxlawk47y3d97whq2bv-nixpkgs-16.09pre83147.df89584/nixpkgs/pkgs/development/libraries/cairo/default.nix and then retry install?
Or Fork and modify NixPkgs per https://nixos.org/wiki/Nix_Modifying_Packages?

I can confirm this gets inkscape farther with this patch and it looks like a good change. Still issues building inkscape though.

Progress, but libman.la won't link.
  CCLD     libman.la
Undefined symbols for architecture x86_64:
  "_program_name", referenced from:
      _error in libgnu.a(error.o)
      _error_at_line in libgnu.a(error.o)
ld: symbol(s) not found for architecture x86_64
clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:1526: recipe for target 'libman.la' failed
make[2]: *** [libman.la] Error 1
make[2]: Leaving directory '/private/var/folders/cy/4988f14n4r35fp39wrt1pfq80000gn/T/nix-build-man-db-2.7.5.drv-0/man-db-2.7.5/lib'
Makefile:1521: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/private/var/folders/cy/4988f14n4r35fp39wrt1pfq80000gn/T/nix-build-man-db-2.7.5.drv-0/man-db-2.7.5'
Makefile:1449: recipe for target 'all' failed
make: *** [all] Error 2
builder for ‘/nix/store/i5xrpqpvc71w5cj1nazi20clv78wv5qr-man-db-2.7.5.drv’ failed with exit code 2
building path(s) ‘/nix/store/8mk7wpiis4y9dicxdcgd0dcl1iihj7ma-openexr-2.2.0’, ‘/nix/store/plnhv7n1qv10qc49nyn3j5kf6caxhp05-openexr-2.2.0-doc’
cannot build derivation ‘/nix/store/4zf5amwgg7ajplicbihmsr89s99hblip-w3m-0.5.3-2015-12-20.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/bipny8ii8i8yd8qap5013nzj406mf579-xmlto-0.0.26.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/9q0922rh6w2l8s86af5przsy9mpwd2w3-giflib-5.1.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/5krnvl1ksrn17ccv6vq0kzg8ma657dz3-libwebp-0.4.3.drv’: 1 dependencies couldn't be built
killing process 82305
cannot build derivation ‘/nix/store/7yaih8szq9j7ylm3ngj6nc4dbdhsfksf-imagemagick-6.9.3-9.drv’: 1 dependencies couldn't be built
building path(s) ‘/nix/store/lqr1gpmr31gq52nrd0f89f7d8h3aciwz-openjpeg-2.1.0-dev’, ‘/nix/store/xkqqp8sp3s8pa5xm291jka6sjb0bda5h-openjpeg-2.1.0’
killing process 82307
cannot build derivation ‘/nix/store/4gffvfamx95rdb1cn001rx4ry75ksplr-inkscape-0.91.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/4gffvfamx95rdb1cn001rx4ry75ksplr-inkscape-0.91.drv’ failed

Looking at Hydra man-db never compiled on darwin: http://hydra.nixos.org/job/nixpkgs/trunk/man-db.x86_64-darwin/all
cc @copumpkin (this is blocking channel update)

We could switch back to man-old as the default on Darwin. BTW, the build-time dependency chain here is rather bloated...

And it used to build before an update not too long ago: http://hydra.nixos.org/build/21587832

Does anyone know why this is here:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/browsers/w3m/default.nix#L31
?
I can't figure out what's using it.

The comment documents the intention, I assume.

But, is it actually still used? I can take out that line without having any issues, I think.

I've got no idea about that. It's common that such settings persist longer than needed. We can drop it, if you're confident it's not needed.

@mbucc see #15849

@copumpkin so this is fixed?  (I am new to nix and still learning.)
I tried:
$ nix-channel --update
...
$ nix-env -u
...
$ nix-env -i inkscape
...

and still get the same error.

@mbucc: the channels lag behind master.

Even with the latest patches there's some unrelated Inkscape build issue.

$ nix-env -i --show-trace inkscape
installing ‘inkscape-0.91’
error: while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘inkscape-0.91’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/applications/graphics/inkscape/default.nix:20:3:
while evaluating the attribute ‘propagatedNativeBuildInputs’ of the derivation ‘gtkmm-2.24.4’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/development/libraries/gtkmm/2.x.nix:4:3:
while evaluating ‘callPackageWith’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/lib/customisation.nix:93:35, called from /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/top-level/all-packages.nix:7570:13:
while evaluating ‘makeOverridable’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/lib/customisation.nix:54:24, called from /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/lib/customisation.nix:97:8:
while evaluating anonymous function at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/development/libraries/cairomm/default.nix:1:1, called from /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/lib/customisation.nix:56:12:
while evaluating ‘mkDerivation’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/stdenv/generic/default.nix:95:5, called from /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/development/libraries/cairomm/default.nix:6:1:
while evaluating ‘throwEvalHelp’ at /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/stdenv/generic/default.nix:120:23, called from /nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/stdenv/generic/default.nix:169:21:
Package ‘cairomm-1.12.0’ in ‘/nix/store/qkzk4iy15jhms2w2ln9gqiff0bgafbmv-nixpkgs-16.09pre88706.b8e215f/nixpkgs/pkgs/development/libraries/cairomm/default.nix:21’ is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build` or any other Nix command you can add
  { allowBroken = true; }
to ~/.nixpkgs/config.nix.

OS X El Capitan

Same on Mavericks.

@2426021684: inkscape doesn't build so it's better to fail during evaluation time already with a hint of being broken.

@2426021684 @mbucc to be clear, the message you're both reporting is saying "hey, the package you requested isn't known to work on your platform, so we're not going to bother trying to build it. If you'd like to try anyway, follow the instructions".
So basically, we left it as "this is known to be broken and an enterprising user who needs it can submit a fix if they know how to fix it".


Let x11docker set the best resolution for the container.

See the following screenshot, I want to know if x11docker will pick the best resolution of the container automatically:

Regards,
HZ

Will this option set a fixed size, as shown below:
$ x11docker|grep -- --size
     --size=WxH        Screen size of new X server (e.g. 800x600).

Just set one one that fits your needs.
The best size is a question of personal preference.
The Xephyr window will be resizeable, not fixed.

Is it possible to use a resolution larger than the display?  For example, if I want to test a game at 4k but only have a 1080p monitor?

I've answered here: https://github.com/mviereck/x11docker/issues/502


Radio option selection issue on IOS - 10.2

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
bug
What is the current behavior?
After selecting an option from the available radio buttons, the binding variable in the form is not updated in the template.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
http://plnkr.co/edit/lteYqVlbVaBqAoDo6vd0?p=preview
This won't reproduce the bug. But you get the idea of how we have implemented the code. After watching the video and screenshot you'll get to know the issue we are facing.
What is the expected behavior?
Selecting a radio option should update the binding variable in form.
What is the motivation / use case for changing the behavior?
Due to this issue user won't be able to submit the form successfully and will have to change the selection and reselect the correct option again.
Which versions of AngularJS, and which browser / OS are affected by this issue? Did this work in previous versions of AngularJS? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
Angular version - 1.3.13
OS - IOS 10.2 on Iphone 5/6s
Haven't tested on any previous versions
Other information (e.g. stacktraces, related issues, suggestions how to fix)
Screenshot of the issue: https://drive.google.com/open?id=0BywABUsLPa4AMkRoYlpzNTFuZ0E
Video depicting the issue: https://drive.google.com/open?id=0B8zXVeTfYECYY3JjbHdEVHBZTnc

@varun-bansal Maybe it's a great idea to drop by the official support channels to get support regarding your problem instead of reporting a bug which is not reproducable (or atleast, you didn't get to reproduce it).
Please ask support questions on gitter (https://gitter.im/angular/angular.js) or reach out to anyone @ IRC.

Three things:

Why does the plnkr not reproduce the bug? Are you maybe using 3rd party code that is actually responsible for the problem? Without a repro, we cannot do anything about this,
1.3.13 is not supported anymore, please check if the issue persists with 1.6.1 and the latest master snapshot
Your video and screenshot are not public

Plnkr will not reproduce the bug as it is specific to ios 10.2. We are using ionic and cordova, but even it run the app in safari on ios 10.2 the bug is still reproducable, so there is no problem with the third party application.
Currently, we cannot update our system to 1.6 as that will include a lot changes to be done in our and we have planned that for some time in future.
Video and Screenshot link update

Upon further investigation, we found that the listener attached to the radio input was not fired sometimes when the radio input is selected, causing the model to not reflect the changes.
For now, we have implemented a workaround by surrounding the input tag in a label tag and adding ng-click handler in the parent label tag. When clicking on the parent tag that is same as clicking on the radio option we set the model value manually. Here's how
Template
`

`
Controller
$scope.sampleInput = function(option, question) {          $scope.quizFormData[question.$key] = option.id; };
Also, event if we would update our angular version to 1.6, can you assure that the bug would have been fixed?
You help is much appreciated! Thanks.

No, I can't guarantee that the problem goes away with 1.6.1. But if  you can re-create the bug with the plunkr in ios 10.2, then you should also be able to test it with 1.6.1 instead of your app's version. Can you do that and report back?
It does sound like an ios problem, though.

Sure, will try with 1.6.1 on plunkr and get back.

I'm going to close this issue because we haven't got any feedback. Feel free to reopen this issue if you can provide new feedback.


Knowledge - Ingestion fails with -  failed to clean website content: failed to LLM-clean markdown: error

Encountered the following ingestion error for 1 of the files when trying to ingest all files from https://intel.com:
failed to clean website content: failed to LLM-clean markdown: error sending request(s): retry limit exceeded or request failed with non-retryable error: #5/5: failed to send request: Post "http://localhost:8080/api/llm-proxy/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Agent that showed this ingestion error - https://test.acornlabs.com/api/agents/a1w2ptl/knowledge-sources/ks1flx8h/knowledge-files
    {
      "id": "d7be5b1959b241a4132fc2e068c5fee9b9b1da6fb6ab3472bac9717a2b7c0ac1",
      "created": "2024-12-19T23:39:01Z",
      "revision": "1577485",
      "type": "knowledgefile",
      "fileName": "www.intel.com/content/www/us/en/developer/topic-technology/artificial-intelligence/get-started.html.html",
      "state": "error",
      "error": "failed to clean website content: failed to LLM-clean markdown: error sending request(s): retry limit exceeded or request failed with non-retryable error: #5/5: failed to send request: Post \"http://localhost:8080/api/llm-proxy/chat/completions\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)",
      "agentID": "a1w2ptl",
      "knowledgeSetID": "kst1-a1w2ptl",
      "knowledgeSourceID": "ks1flx8h",
      "approved": true,
      "url": "https://www.intel.com/content/www/us/en/developer/topic-technology/artificial-intelligence/get-started.html",
      "updatedAt": "W/\"52e05-629a803034cd9-gzip\"",
      "checksum": "44a94f9fe419e3781c49b3c681f41260721f05b1517d29705c8ae2eaa8c79d0a",
      "lastIngestionStartTime": "2024-12-20T00:44:05Z",
      "lastIngestionEndTime": "2024-12-20T00:52:34Z",
      "lastRunIDs": [
        "r1wc84l"
      ],
      "sizeInBytes": 328647
    },

Run detail - https://test.acornlabs.com/api/runs/r1wc84l
{
  "id": "r1wc84l",
  "created": "2024-12-20T00:44:05Z",
  "threadID": "t1-ks1flx8h",
  "input": "{\"input\":\"www.intel.com/content/www/us/en/developer/topic-technology/artificial-intelligence/get-started.html.html\",\"output\":\".conversion/www.intel.com/content/www/us/en/developer/topic-technology/artificial-intelligence/get-started.html.html.md.md\"}",
  "state": "pending"
}

@iwilltry42 any thoughts/ideas on this one?


Philips Hue Lightstrip Outdoor 2m - White and Color Ambiance

Hi,
Is it possible to add this device?
https://www2.meethue.com/nl-nl/p/hue-white-and-color-ambiance-lightstrip-outdoor--2-meter/8718699709839
Producent ID: Philips
Product ID: LCL002
Device ID: 269
Profile ID: 260
Kind regards,
Aaron

Hi  @acaenepeel.
Absolutely,  I'm putting it on the todo list.

Added to upcoming SDK3 version of the app.


Preservation of OS images when re-runnning 'epicli apply'

Added option for preservation of OS images when re-runnning 'epicli apply' for existing cluster.
Azure will ask if images need to be preserved as it might be ok, at risk of user
AWS will just preserve images showing a warning as we cannot change images without errors on autoscaling groups.

/azp run

/azp run

Unit tests fail:
=================================== FAILURES ===================================
_____________ test_get_public_ip_should_set_proper_values_to_model _____________

    def test_get_public_ip_should_set_proper_values_to_model():
        cluster_model = get_cluster_model(cluster_name='TestCluster')
        builder = InfrastructureBuilder([cluster_model])

        component_value = dict_to_objdict({
            'machine': 'kubernetes-master-machine'
        })
>       vm_config = builder.get_virtual_machine(component_value, cluster_model, [], [], False)
E       TypeError: get_virtual_machine() takes 2 positional arguments but 6 were given

tests/engine/providers/azure/test_AzureConfigBuilder.py:71: TypeError
_________ test_get_network_interface_should_set_proper_values_to_model _________

    def test_get_network_interface_should_set_proper_values_to_model():
        cluster_model = get_cluster_model(cluster_name='TestCluster')
        builder = InfrastructureBuilder([cluster_model])
        component_value = dict_to_objdict({
            'machine': 'kubernetes-master-machine'
        })
>       vm_config = builder.get_virtual_machine(component_value, cluster_model, [], [], False)
E       TypeError: get_virtual_machine() takes 2 positional arguments but 6 were given

tests/engine/providers/azure/test_AzureConfigBuilder.py:87: TypeError
- generated xml file: /azp/agent/_work/6/s/core/src/epicli/tests/results/result.xml -
=========================== short test summary info ============================
FAILED tests/engine/providers/azure/test_AzureConfigBuilder.py::test_get_public_ip_should_set_proper_values_to_model
FAILED tests/engine/providers/azure/test_AzureConfigBuilder.py::test_get_network_interface_should_set_proper_values_to_model
=================== 2 failed, 61 passed, 2 skipped in 0.52s ====================

/azp run

Shouldn't we update automated tests to ensure that os version didn't change in apply -> upgrade -> apply scenario? @przemyslavic can you help here? Do we have any automated tests for this? Where should we update?

Unit tests are updated, as the automated tests, that is probably more a pipeline thing which  I think @przemyslavic  was already setting up?

As for the pipeline, I'll update the existing ones to conditionally re-run apply after upgrading from v0.7/v0.8/v0.9 to v1.0/develop instead of creating another one just for that purpose. Apart from unit tests, we do not have any image checks. After a successful build we can always run az vm get-instance-view command to compare actual vm image version with that in the manifest file.

As discussed during the standup, unit testing should be sufficient here. A pipeline for testing the LTS version has already been created.

/azp run


Firebase backend

*Added environment variables for the firebase configuration properties
*Created config folder under MENTANA-backend/src for the Firebase-config.js file
*implemented the firebase configuration and initialized it
*Created middleware folder under MENTANA-backend/src
*Created the class Middleware with its decodeToken function
*under MENTANA-backend/src/interfaces/http/server.js instantiated the middleware class and applied the decodetoken function as a middleware to access to the information which for now if succeed will show the message "Hello World"
Middleware tested with a valid token from the frontEnd, works as expected.

the check and is failing in the github action is due to the env variables for the firebase configuration is not added to the github actions variables


Not working with Angular router…

See example:
http://plnkr.co/edit/fLS2xAoGtQXopKsserk7
I've placed a data-sr outside and inside de loaded angular view but is not working.
I've copied as much as I could from the original example on the doc…

Here's a fork of the docs plnkr with the content moved to an angular route view:
http://plnkr.co/edit/6YRSM3OKZbpffg41oDgC?p=preview
As you can see… it doesn't work when inside an angular router view.

Not working with angular 1.4.x?

any updates on getting reveal to work in ng-view?


Fix AuthMe implementation

It appears you check the player permission to send the message, but not the permission to receive it ;)

#12

@James137137


when connector and kafka both down, solace messages may be losted

solace publish message.
shutdown kafka broker.
shutdown connector.
restart kafka broker.
restart connector.

The message of 1 does not be transfered to kafka topic, but it has already consumed from solace queue.  I found in the poll method it manually call the commit method by self, should let kafka connector call it automatically?
https://github.com/SolaceLabs/pubsubplus-connector-kafka-source/blob/master/src/main/java/com/solace/source/connector/SolaceSourceTask.java#L179-L182

Hello,
I have the same problem with.
when this fix can pass ?

There is work underway to update the connectors, which will include addressing this issue - ETA is April.


refactor: remove policyrule crd

Codecov Report

Merging #295 (fb640c5) into main (b02ee56) will decrease coverage by 0.05%.
The diff coverage is 87.03%.

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   63.26%   63.21%   -0.06%
==========================================
  Files          42       41       -1
  Lines        6914     6831      -83
==========================================
- Hits         4374     4318      -56
+ Misses       2177     2148      -29
- Partials      363      365       +2

Impacted Files
Coverage Δ

pkg/controller/group/group_controller.go
70.36% <9.09%> (-2.42%)
:arrow_down:

pkg/controller/policy/group_generator.go
86.84% <75.00%> (-1.75%)
:arrow_down:

...gent/controller/policy/global_policy_controller.go
73.80% <88.00%> (-0.91%)
:arrow_down:

pkg/agent/controller/policy/cache/rule.go
97.98% <100.00%> (-0.12%)
:arrow_down:

pkg/agent/controller/policy/policy_controller.go
74.86% <100.00%> (+3.57%)
:arrow_up:

...gent/controller/policy/policy_controller_helper.go
91.75% <100.00%> (+4.07%)
:arrow_up:

pkg/agent/controller/policy/cache/group.go
75.91% <0.00%> (-2.19%)
:arrow_down:

... and 1 more


fix: remove now-unusable "legacy" notarization

Updated API to reflect deprecated exports.
Updated documentation to match.
Removed code that will no longer work.

note: I took pains to make this backwards-compatible. If you’d rather I remove the obsolete types outright, I could do that instead.

Really appreciate this @rotu!
Had some comments about the docs, someone else has to look at the code bits. I'll leave it to that person whether the error message about legacy should also point to notarytool instead.

@MarshallOfSound How do I get code review on this?


Fix behavior of on open and close

Lint files opened before the extension is loaded.
Don't clear diagnostics of other files.
Kill running rubocop process on close.
Run single process at a time (to avoid accidential process bomb) (using queue).

This is caused by vscode's project-wide replace (opens all matched file at once).

@ypresto This looks very nice, thanks for the contribution!
Two questions:

It looks like you've removed some of the code that depends on ChildProcesses—could you verify if there are any remaining references to ChildProcess? If not, we should probably remove that as a dependency in this PR as well. :)
Task and TaskQueue are nice additions—any chance we could get some test coverage for them? In particular, I'd love to see some tests documenting and verifying the TaskQueue implementation. I'm happy to assist if you need a hand with the tests.

Thanks again!

Oh, I didn't realized that RubocopAutocorrect is extends Rubocop class. I want remove RubocopAutocorrect and add parameter to Rubocop constructor to pass --auto-correct.

Added test..!

vscode sometimes passes document with git:// uri and /path/to/file.git fileName to open and close event (maybe bug...). So I added check for url scheme.

I'm in doubt that TaskQueue should be replaced with more generic and reusable solution.
What I implemented is exactly same as the thing suggested in below URL.
https://github.com/caolan/async/issues/703

This has improved a lot since I last saw this PR! Great work @ypresto!
This code look a pretty solid to me, so you have my :+1:. @misogi, can you check this out when you have some time? I think this work resolves a number of open bugs/feature requests around auto-correction and edit history.

Thanks for your great contribution!
I check behavior with replacing words in multiple files. Extension has been more solid.
It's exactly as you said, I want to there are solutions solve queuing by other libraries too.
Until then we find a solution. we will use taskQueue because stability is increased.
Let me know about alternative external library if you find them.
@damien Thanks for your helping on many discussion!
We have to solve an auto-correct issue. Surely this PR decrease unnecessary overwrite files !
It seems ChildProcess is still needed.


aws_request_signing: Signature within query parameters

Commit Message: aws_request_signing: Signature within query parameters
Additional Description: Per design in https://github.com/envoyproxy/envoy/issues/32388
Risk Level: Low
Testing: Unit
Docs Changes: Docs updated
Release Notes: Updated
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] 32388
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
@suniltheta

/retest

/assign suniltheta

/assign-from @envoyproxy/senior-maintainers

LGTM can you merge main?
/wait


[Bug] Inconsistent state of Mempool entries

During whirlpooling a utxo stuck in the mempool leads to a inconsistent state between the transactions and utxos tab, see 0 sats vs. the correct amount in the mempool X sats:
Sparrow GUI v1.8.1

Okay maybe this isn't a bug, just the thing again that there's no transfer of value in or out of the wallet during a remix.
There's still a transaction in the mempool though I guess?! I at least was a bit lost on why they differ...

The amount on the Transactions tab shows the value difference created by transactions in the wallet (value in - value out). The UTXOs tab simply shows the sum of the UTXO values.


add components  (angular 1.5 ) option to bardjs

Like many others I am starting to work on and test angular 1.5.  The component option is very nice, but right now the only way to test it is with angular mocks.  Please add this option when you have a chance.

+1

+1

Wouldn't you inject mock as normal and add the services and bindings into the $componentController?


Coverage of uuid is now 100%

Helps in the tying up of loose ends around https://github.com/m-lab/dev-tracker/issues/195

This change is

Pull Request Test Coverage Report for Build 307

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-22.8%) to 71.634%

Totals

Change from base Build 304:
-22.8%

Covered Lines:
399

Relevant Lines:
557

💛  - Coveralls


Support INT16 and INT32 as primary key

As we add INT16 and INT32 data types, we should also support them as primary keys.

Should we also support uint and int8 type as primary key?

Should we also support uint and int8 type as primary key?

We should support all int types. Updated the title and description now.

Done in #2728.


Got several issues while testing newly released ENet-Label-Torch.

Thanks for the awesome work!
I am trying to test the new ENet model, and the following are the issues I've met.

an error occurred in testLane.lua:124 while run test.sh script
https://github.com/cardwing/Codes-for-Lane-Detection/blob/fce40451813150d986d994cfb55be2c1bc36b651/ENet-Label-Torch/testLane.lua#L124
The debug info indicated the exist[b][i] is [torch.FloatTensor of size 4]. So I changed this line into if exist[i] > 0.5 then, and the default testing script will work.

another issue occurred while testing my own data (1280x720 image), and the modified test.sh will throw the error as blow:

//torch/install/share/lua/5.1/threads/threads.lua:183: [thread 2 callback] /home///torch/install/share/lua/5.1/image/init.lua:569: image.crop: crop goes outside bounds of src
stack traceback:
[C]: in function 'cropNoScale'
/home///torch/install/share/lua/5.1/image/init.lua:569: in function 'crop'
./datasets/transforms.lua:57: in function 'transform'
./datasets/transforms.lua:19: in function 'preprocess'
./dataloader.lua:99: in function <./dataloader.lua:92>
[C]: in function 'xpcall'
...//torch/install/share/lua/5.1/threads/threads.lua:234: in function 'callback'
...//torch/install/share/lua/5.1/threads/queue.lua:65: in function <...//torch/install/share/lua/5.1/threads/queue.lua:41>
[C]: in function 'pcall'
...//torch/install/share/lua/5.1/threads/queue.lua:40: in function 'dojob'
[string "  local Queue = require 'threads.queue'..."]:15: in main chunk
stack traceback:
[C]: in function 'error'
...//torch/install/share/lua/5.1/threads/threads.lua:183: in function 'dojob'
./dataloader.lua:157: in function '(for generator)'
testLane.lua:66: in main chunk
[C]: in function 'dofile'
.../**/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
[C]: at 0x00406670

It seems to be the input image size I used is not compatible with the new model.  I had to resize my test images to 1640x590 to make it work. However, as for the original SCNN torch repo, the test.sh script works fine for the 1280x720 images. Any suggestion?
Thanks in advance.

@zoeveryday I crop the original images of the CULane images (1640 x 590) and remove the part which only contains background. And the image after cropping is 1640 x 350. And that's why the second problem occurs (the new image is 1280 x 720). You can just remove 'input = image.crop(input, 0, 230, 1640, 590)' in transforms.lua and the testing script should work.

@cardwing actually, I can get better results if I resize the 1280x720 images into 1640x590 ones.
Another question, I noticed that the prob map size now is 208x976 (which used to be 288x800). So if I want to overlap the prob map to the test images, shall I resize it back to 1640x350 first, and then pad 1640x240 to the top? (if I don't change anything within the transforms.lua)

@zoeveryday If you just use the main.m to obtain the coordinates of lane points, nothing should be changed and the current scripts can already achieve that.

@cardwing thanks for the reply, I'll close the issue now.


Feature/issue 524

After covered panic still return error to repl
Transfer the unexpected panic into error

We already have error detection function in current master branch for following code
When the error with panic will still crash parser, so I assign return value in defer function to prevent parser crash.
# multiple value assign not array format cause error
a = 2, 3

This closes #524

yes finished!

@shes50103 remember to remove [WIP] flag next time plz~


Gitea sends webhooks to jenkins thought there are none of them

Gitea version (or commit ref):
1.13.0+dev-683-gb725c4ee5
Git version:
2.26.2
Operating system:
Alpine Linux
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[X] Not relevant

Log gist:

Description
I use gitea plugin in jenkins. Webhook was enabled in the project to send events to jenkins. I removed webhook, however gitea still sends webhooks to jenkins.
...
Screenshots

Have you checked the organization webhooks as well (if it's an org)? AFAIK the Jenkins plugin adds webhooks to both organization and repository if configured to "manage hooks" from inside Jenkins. This will happen on repository and organization scans. So it might be that your webhooks were re-enabled by Jenkins.


Hello, I came across your project and I'm interested to know if it has the capability to run in real-time and drive images to speak?

Hello, I came across your project and I'm interested to know if it has the capability to run in real-time and drive images to speak?

Thanks for interest. Currently XTalker is able to drive image to speak with about 10x speed compared to SadTalker. I have not integrated it into any real-time streaming system. However, I've roughly make some tests and it shows that it can produce 20 seconds video in about 30 seconds, even faster. Basically as I explained in README, this is based on the low precision inference by IPEX together with the parallel inference implementation by me. Also, the results varies between hardwares. Back to the real-time problem, I am not an expert in ffmpeg for pushing real-time videos, and I may have a look on that. I think you can firstly try to test it in your own system.


Solang pragma

In your documentation it is stated that pragmas in general are ignored, especially the "version pragma" (pragma solidity ^0.8.0;).
I was wondering if it would make sense for you to introduce a solang-pragma (pragma solang ^0.1;) so that if someone tries to compile a solang-targeted contract with solidity, it would be clearly visible what the issue is.

I'm hesitant towards the version pragma. No programming language I've ever seen of allows you to specify the compiler and even the compiler version in the source code itself. This is a property of the environment (e.g. build environment).
Some language like C allow you to check the compiler version so you can do conditional code in the preprocessor. I don't think we should be adding a preprocessor, but some sort of conditional compilation based on the compiler and/or target chain would be a very welcome thing. For example, ecrecover() is only available on chains that use secp256k1 for the address type; public key recovery does not exist for ec25519 signatures.
We could have env.compiler, env.arch, and env.chain  builtins.
    if (env.chain == 'ethereum') {
       ecrecover()
    } else {
       signatureVerify(address, message, signature);
    }

If the if condition can be evaluated at resolve time then the only the matching then or else block would be resolved.


Add option to flip position components on prepareCanvas

This is a very useful override of the prepareCanvas method that I've been using:
  // TODO pull up to flame! this is **very** useful
  @override
  void prepareCanvas(Canvas canvas) {
    canvas.translate(x, y);
    canvas.translate(width/2, height/2);
    canvas.scale(inverted ? 1.0 : -1.0, 1.0);
    canvas.translate(-width/2, -height/2);
  }

This flips horizontally. PositionComponent should have a field to control that and allow for easy flipping of sprites, both horizontally and vertically (or both).
It would be a really good to have feature.

Fixed on #166

Thanks @kurtome


[Nana] Freetype linker failure

/usr/sbin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/8.1.1/../../../../lib/libXft.so: undefined reference to symbol 'FT_Done_Face'
/usr/lib/libfreetype.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/nana-test.dir/build.make:98: nana-test] Error 1
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/nana-test.dir/all] Error 2
make: *** [Makefile:117: all] Error 2
It looks to be finding the system version rather than the one installed by vcpkg.

from which follows https://packages.debian.org/stretch/libxft2 the libxft2 package is assembled without anything where there is no FT_Done_Face

@Adobe-Android, please try to install Nana with VCPKG latest revision, and please open a new issue if this is still a problem for you.
Nana installed successfully on Ubuntu 16.04
linux001@linuxtest01:~/vcpkg$ ./vcpkg install nana
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete our survey by running: vcpkg contact --survey
The following packages will be built and installed:

dirent[core]:x64-linux
fontconfig[core]:x64-linux
nana[core]:x64-linux
Additional packages (*) will be modified to complete this operation.
Starting package 1/3: dirent:x64-linux
Building package dirent[core]:x64-linux...
-- Performing post-build validation
-- Performing post-build validation done
Building package dirent[core]:x64-linux... done
Installing package dirent[core]:x64-linux...
Installing package dirent[core]:x64-linux... done
Elapsed time for package dirent:x64-linux: 25.24 ms
Starting package 2/3: fontconfig:x64-linux
Building package fontconfig[core]:x64-linux...
-- Downloading https://www.freedesktop.org/software/fontconfig/release/fontconfig-2.12.4.tar.gz...
-- Extracting source /home/linux001/vcpkg/downloads/fontconfig-2.12.4.tar.gz
-- Applying patch fcobjtypehash.patch
-- Using source at /home/linux001/vcpkg/buildtrees/fontconfig/src/2.12.4-3074630478
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Performing CMake integration test
-- Performing post-build validation
-- Performing post-build validation done
Building package fontconfig[core]:x64-linux... done
Installing package fontconfig[core]:x64-linux...
Installing package fontconfig[core]:x64-linux... done
Elapsed time for package fontconfig:x64-linux: 5.16 s
Starting package 3/3: nana:x64-linux
Building package nana[core]:x64-linux...
CMake Warning at ports/nana/portfile.cmake:7 (message):
You will need to install Xorg dependencies to use nana:

apt install libx11-dev libxft-dev
Call Stack (most recent call first):
scripts/ports.cmake:71 (include)
-- Downloading https://github.com/cnjinhao/nana/archive/v1.6.2.tar.gz...
-- Extracting source /home/linux001/vcpkg/downloads/cnjinhao-nana-v1.6.2.tar.gz
-- Using source at /home/linux001/vcpkg/buildtrees/nana/src/v1.6.2-51b575c248
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Performing post-build validation
-- Performing post-build validation done
Building package nana[core]:x64-linux... done
Installing package nana[core]:x64-linux...
Installing package nana[core]:x64-linux... done
Elapsed time for package nana:x64-linux: 49.87 s
Total elapsed time: 55.06 s
The package nana:x64-linux provides CMake targets:
find_package(unofficial-nana CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::nana::nana)

Thanks @PhoebeHui. I'll give it a try.

Just tried it on Ubuntu 18.04 and I got the following issue.
vm@vm-VM:~/vcpkg$ ./vcpkg install nana
The following packages will be built and installed:

bzip2[core]:x64-linux
expat[core]:x64-linux
fontconfig[core]:x64-linux
freetype[core]:x64-linux
libjpeg-turbo[core]:x64-linux
libpng[core]:x64-linux
nana[core]:x64-linux
zlib[core]:x64-linux
Additional packages (*) will be modified to complete this operation.
Starting package 1/8: zlib:x64-linux
Building package zlib[core]:x64-linux...
-- Using cached /home/vm/vcpkg/downloads/zlib1211.tar.gz
-- Using source at /home/vm/vcpkg/buildtrees/zlib/src/1.2.11-f690224aeb
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /home/vm/vcpkg/packages/zlib_x64-linux/share/zlib/copyright
-- Performing CMake integration test
CMake Error at scripts/cmake/vcpkg_test_cmake.cmake:56 (message):
CMake integration test failed; unable to find_package(ZLIB MODULE REQUIRED)
Call Stack (most recent call first):
ports/zlib/portfile.cmake:50 (vcpkg_test_cmake)
scripts/ports.cmake:71 (include)

Error: Building package zlib:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: zlib:x64-linux
Vcpkg version: 2018.11.23-unknownhash
Additionally, attach any relevant sections from the log files above.

I'll just add that this error appears to be the fault of #4817


Plugin Registry in CVAT

Hi.
I have started  working with CVAT about 4 weeks ago. I explored in the code and I was struggling to understand what exactly the PluginRegistry does in the project and how exactly the pattern works and how is the logic is distributed in the project's modules. So if you give me an explanation about this pattern in detail I'll be grateful.
Thanks

PluginRegistry allows to decorate almost each method of cvat-core module (adding logic before/after original method implementation and even preventing call of original implementation).
One example is SAM: https://github.com/opencv/cvat/blob/develop/cvat-ui/plugins/sam/src/ts/index.tsx
For more details, please refer to the code.

Actually I am looking for the place the  plugins get registered.

So where do they get registered?

Please, see the file I've shared. You will find registration there.


issue208 Add test that nested participants with Forget methods are no…

…tified when the parent LRA is closed
resolves #208
Signed-off-by: xstefank<EMAIL_ADDRESS>

@rdebusscher thank you, wait calls added.


[Impeller] Text rendering is incorrect on Tab bars

Steps to Reproduce

Create a flutter project. Enable impeller
Add Bebas Neue font files to your app. Reference the imports into pubspec.yaml file.
Create a tab bar with the code sample provided below

Expected results:
The text weights and sizes should be uniform
Actual results:

Code sample

TabBar(
    unselectedLabelColor: Palette.gray3,
    labelColor: Colors.white,
    indicatorWeight: 1.0,
    indicatorColor: Palette.primary,
    tabs: [
      Tab(
        icon: Text(
          "Posts",
          style: TextStyle(
            fontSize: 20,
            fontFamily: 'Bebas Neue',
            fontWeight: FontWeight.w500,
            height: 1.0,
          ),
        ),
      ),
      Tab(
        icon: Text(
          "Replies",
          style: TextStyle(
            fontSize: 20,
            fontFamily: 'Bebas Neue',
            fontWeight: FontWeight.w500,
            height: 1.0,
          ),
        ),
      ),
    ],
  ),

pubspec.yaml fonts reference
fonts:
    - family: Inter
      fonts:
        - asset: assets/fonts/Inter-Light.ttf
          weight: 300
        - asset: assets/fonts/Inter-Regular.ttf
          weight: 400
        - asset: assets/fonts/Inter-Medium.ttf
          weight: 500
        - asset: assets/fonts/Inter-SemiBold.ttf
          weight: 600
        - asset: assets/fonts/Inter-Bold.ttf
          weight: 700
        - asset: assets/fonts/Inter-ExtraBold.ttf
          weight: 800
        - asset: assets/fonts/Inter-Black.ttf
          weight: 900
    - family: Bebas Neue
      fonts:
        - asset: assets/fonts/BebasNeue-Regular.ttf
          weight: 400

Flutter doctor output

[✓] Flutter (Channel stable, 3.7.0, on macOS 13.0.1 22A400 darwin-x64, locale en-KE)
    • Flutter version 3.7.0 on channel stable at /Users/brian/Documents/Dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (6 days ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/brian/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (4 available)
    • iPhone (mobile)        • 00008020-001144861108002E            • ios            • iOS 16.2 20C65
    • iPhone 14 Pro (mobile) • C0BC6585-0FC9-472A-B059-9F08B98BB902 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.124

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Thanks for the report @briankariuki
Couple of similar issues related to fonts have been fixed recently:
https://github.com/flutter/flutter/issues/118615
https://github.com/flutter/flutter/issues/118613
The fixes should be available on master if not in stable version you are on, so please try your use case by switching to latest master (enable impeller) and see if you still see same behavior or not.
flutter channel master
flutter upgrade --force

Same issue in Chinese, some text's size is incorrect:

The doctor result:
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.7.0-31.0.pre, on macOS 12.0.1 21A559 darwin-arm64, locale
    zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] Connected device (3 available)

Thanks for the report @briankariuki Couple of similar issues related to fonts have been fixed recently:
#118615 #118613
The fixes should be available on master if not in stable version you are on, so please try your use case by switching to latest master (enable impeller) and see if you still see same behavior or not.
flutter channel master flutter upgrade --force

I am having the same issue mentioned here. Tested with hotfix 3.7.1 and with master branch.

flutter doctor -v
[✓] Flutter (Channel stable, 3.7.1, on macOS 13.0.1 22A400 darwin-arm64, locale en-EE)
    • Flutter version 3.7.1 on channel stable at /Users/eduardo.cunha/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7048ed95a5 (20 hours ago), 2023-02-01 09:07:31 -0800
    • Engine revision 800594f1f4
    • Dart version 2.19.1
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/eduardo.cunha/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/eduardo.cunha/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/eduardo.cunha/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (3 available)
    • iPhone SE (3rd generation) (mobile) • B1355D90-2B3D-484F-98CF-F462899578BD • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)                     • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

I'm having trouble reproducing these issues on master or 3.7.1. If you have examples where the font weight looks incorrect it would be very useful if you could share the font you are using + a sample that includes the text that looks incorrect. Thank you!

I opened this issue which is similar to this one and happens to arabic text. it also has examples where the issue is happening and a video showing exactly when it happens

Thank you @michaelsoliman1

@jonahwilliams It was a little hard to reproduce the bug, but it is possible to reproduce it by following the steps below:

Use any custom font
Use it on the Material Theme
Load multiple widgets  with different fontWeight within a scrollable widget

HotReload usually intensifies the issue and makes it easier to happen.
I created a simple example that reproduces this bug: https://github.com/vital-edu/impeller_text_render_bug
https://user-images.githubusercontent.com/5282301/216464581-56cbdafd-4c12-4501-893e-eac1ee8a2b73.mp4


Native font stack does not match documentation

The documentation for version 4.0.0-alpha4 states that the "Ubuntu" font family is part of the default native font stack (http://v4-alpha.getbootstrap.com/content/reboot/#native-font-stack). I tested the "Hello, world!" example from the Getting Started page by viewing the file with Firefox version 48.0 on Ubuntu 16.04, but the computed font-family for body seems to be
-apple-system,
BlinkMacSystemFont,
"Segoe UI",
Roboto,
"Helvetica Neue",Arial,sans-serif

The documentation suggests that this should be
-apple-system,
BlinkMacSystemFont,
"Segoe UI",
"Roboto",
"Oxygen",
"Ubuntu",
"Cantarell",
"Fira Sans",
"Droid Sans",
"Helvetica Neue", Arial, sans-serif !default;

Specifically, the documentation includes the following families that the actual code does not have:
"Oxygen",
"Ubuntu",
"Cantarell",
"Fira Sans",
"Droid Sans",

Maybe this is a documentation/code mismatch?

Thanks for updating the documentation. This means Reboot will not attempt to provide native fonts for Linux systems?

Thanks for updating the documentation. This means Reboot will not attempt to provide native fonts for (non-Android) Linux systems?

Basically, yes :(. The rendering—even with Roboto in there—is super inconsistent.  We're still getting feedback on that actually. Hopefully we can deliver something better in the future, but at the very least, most distros seem able to swap from Helvetica to decent sans-serif options.


Generated constants should be UPPER_SNAKE_CASE

Describe the Bug
Generated constants are not upper snake case and this triggers warnings from the rust-analyzer.
Steps to Reproduce
Save this code to a .rs file:
#[wasm_bindgen]
extern "C" {
    pub type Something;
}

Import the required mods and run the rust-analyzer.
Expected Behavior
No warnings should appear.
Actual Behavior
The following error appears:
Diagnostic { code: DiagnosticCode("incorrect-ident-case"), message: "Constant `__wbg_generated_const_Something` should have UPPER_SNAKE_CASE name, e.g. `__WBG_GENERATED_CONST_SOMETHING`", range: 732..747, severity: WeakWarning, unused: false, experimental: false, fixes: Some([Assist { id: AssistId("change_case", QuickFix), label: "Rename to __WBG_GENERATED_CONST_SOMETHING", group: None, target: 732..747, source_change: None }]) }

Additional Context
I've tried to disable the warning by using #[allow(non_snake_case,non_upper_case_globals)] but it does not do the trick. I've also tried to tweak the rust-analyzer to ignore this but I also failed.

If you use #![allow(non_snake_case,non_upper_case_globals)] in the root of the crate, it silences the errors, although that turns it off in general. I believe that the #[automatically_derived] attribute doesn't work for clippy. Wasm-bindgen shoudl consider adding #[allow(non_snake_case, non_upper_case_globals)] to this generated function.

Seeing the same thing.
Similar to: https://github.com/rustwasm/wasm-bindgen/issues/2774
Would be great to see a general fix for the clippy issues.

I'm seeing the same issue. Can someone (a previous contributor) point me in the right direction to make a PR here?

Can someone (a previous contributor) point me in the right direction to make a PR here?

The macro's code generation is all defined in https://github.com/rustwasm/wasm-bindgen/blob/main/crates/backend/src/codegen.rs, so you'd have to find and fix all the instances where non-upper-snake-case names are generated in that file.

I made a PR. Can someone take a look?


PowerPC floating point efscmp* and efstst* instructions set wrong bit in condition register

The following PowerPC FP instructions do not set the correct bit in the condition register:

efscmpeq
efscmplt
efscmpgt
efststeq
efststlt
efststgt

I found the correct bit to set is bit 3 (0 indexed) based on:
https://www.nxp.com/docs/en/reference-manual/SPEPEM.pdf

Is anything else required to get this merged?

time for someone at NSA to read through and approve it.  covid/holidays/end of year/PTO/December in Maryland/their actual priorities/pick one...
Is this supposed to change every bit in the CR or just bit index 2?  I would suggest using the setCrBit macro instead if its set or clear a single bit setCrBit(CRFD, 2, <expr>)

Is this supposed to change every bit in the CR or just bit index 2? I would suggest using the setCrBit macro instead if its set or clear a single bit setCrBit(CRFD, 2, <expr>)

The manual says the values of all other bits are undefined which means:
An undefined value. The value may vary between implementations and between different executions on the
same implementation.

so I took this to mean the other bits could be any value, and I am clearing them to prevent any confusion around whether you should expect them to carry over from previous instructions

so I took this to mean the other bits could be any value, and I am clearing them to prevent any confusion around whether you should expect them to carry over from previous instructions

My concern about this is that it might mess up the decompilation if it's zeroing out other bits that the program cares about (or previously cared about I should say - a good compiler would not do that).

The docs say the the other bits hold undefined values (could be any value and the same call can result in different values) so if it is non-deterministic you can't depend on them carrying over, correct?

The docs say the the other bits hold undefined values (could be any value and the same call can result in different values) so if it is non-deterministic you can't depend on them carrying over, correct?

Yes, that's correct. However, we're attempting to represent the processor state, not document good programming practices. By changing bits that the instruction does not care about, we may introduce inadvertent decompilation artifacts. I'll look into it and see if there's a potential issue with it or not.

If the processor randomly flips the other bits, isn't the only way to accurately represent the processor state to somehow mark them undefined? Perhaps there exists a way to flag the bits as such?

@GhidorahRex let me know if you need anything else to get this merged.  Thanks!


Improving JSON BitmapText implementation

Fixes for issues described by @MaksJS in #1837

The linting errors were introduced before I branched off. I could fix them, but it doesn't feel within scope for this PR.

Lovely, thanks.


Add world creation menu for Forge

This replaces the world creation menu with a custom world creation menu. Actually it also adds a menu and makes changes to the vanilla world selection menu so I guess this file's name isn't entirely accurate but what the heck. Rename it and put it anywhere you like. To hook this up add this to TCPlugin:
MinecraftForge.EVENT_BUS.register(new WorldCreationMenuHandler());

Thanks!
Unfortunately, the code won't work (or even compile) on Minecraft 1.9. I tried to fix it, but there are just way too many required changes. So I won't merge this for now.

Oi, bummer! The UI/menu's do seem to change a bit across MC versions. I'll see if I can make a 1.9 version a.s.a.p.


[FLINK-1907] Scala shell

implementation of Scala Shell, for Scala versions 2.10 and 2.11.
Also includes change to "eager" print()

Amazing! I'm super excited to see this finally implemented.
I'll soon review the changes.

The change looks good, I had some easy to resolve comments.
Sadly, it seems that most of the changes are caused by the semantics change of print() ... the scalashell code doesn't seem to be so much.
We certainly need to update the documentation as well. A lot of code examples are doing print() and execute() together.
The docs should explain what print() is doing.

thanks for the comments Robert, I'll fix the stuff tomorrow!
Indeed, the Scala shell itself is not so much code, most of the changes are caused by the change of  print().

Fixed according to comments and linux terminal issue, should now pass all tests.

I am wondering whether it would be better to put this into flink-client instead of flink-staging.
Its not a huge component, should be easy to maintain, and would better fit into the core system, IMO.

Hey Fabian. The problem with putting it in the flink-client is that the shell only works with Scala-2.10 and is not included for the Scala-2.11 build.
As far as I've seen its not that easy to exclude certain classes from within a module with maven according to profiles..

Whats the status of this pull request?
It seems that the changes to print() have been merged independently. I would like to merge this soon (depending on the status ;) )

Should work. Yes print() was merged independently. I'll look at it and clean up the commits tomorrow. I too would like to see it being merged ;)

Do we want to have this in now? I can cherry pick it on top of the latest master and merge it.

I've rebased and cleaned up the commits. So this should be ready now.

Ok, I'm running the last Travis tests and then I'm merging :smile:


update catalog link; add mouse event type

Overview

Updating "Course Catalog" text for the catalog header item to shortened "Catalog"
PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: EGG-773
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-labs@9.2.10-alpha.86d709.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60246d8de7d119680c5eeb74--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@9.3.1-alpha.c96f5f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://602470bdee9f6d6c654972b9--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@9.3.1-alpha.a0de7a.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60247f015db2b175d94b2ecb--gamut-preview.netlify.appDeploy Logs


chore: reenable new scene lifecycle

This reverts commit ea6565c5934b4a3dcc2aec1ca466a91713d913ab.

The client is sending the wrong "parcel id".
Before, it sent the base coordinates as the parcel id (e.g. the Floating World scene's base coords are "20,20"), but now it is sending the last scene's parcel coords as the scene id (now the Floating World sends "23,27").
From what I could debug in the parcelSceneManager.ts in getParcelById(), the id is already wrong at that point in time when that function is called.

Updated!

@pravusjif
I modified the name of that function but I think I need some help on how are you using that "id".
I am now exposing these two functions:
getSceneWorkerByCID
getSceneWorkerByBaseCoordinates
I'm not sure which is the one you need from the unity interface. Please verify it!

(this is the key change: https://github.com/decentraland/explorer/pull/174/files#diff-0370cbd3df4c427a40a107cc4ea4195a)


.jbuilder as a Ruby extension

This pull request adds .jbuilder as Ruby extension as discussed in #2194.

:+1:

It'll be another couple of weeks before this change is live on GitHub


cabal-dev ghci won't start

I'm having trouble starting an interactive session with cabal-dev ghci. Here's a minimal way to reproduce:
$ mkdir bug
$ cd bug
$ echo 'name:                bug
version:             <IP_ADDRESS>
build-type:          Simple
cabal-version:       >=1.8

library
  exposed-modules:   Bug
  build-depends:     base >= 4' > bug.cabal
$ echo 'module Bug where' > Bug.hs
$ cabal-dev configure
$ cabal-dev ghci
cabal-dev: user error (Warning: The 'license-file' field refers to the file 'LICENSE' which does not
exist.
Warning: cannot determine version of /u/afoltzer/.cabal/bin/fake-ghc-cabal-dev
:
"== GHC Arguments: Start ==\n--numeric-version\n== GHC Arguments: End ==\n"
/usr/bin/ar: dist/build/Bug.o: No such file or directory
)

Here are the relevant versions:
$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 7.4.1
$ cabal --version
cabal-install version 0.13.3
using version 1.14.0 of the Cabal library
$ cabal-dev --version
cabal-dev 0.9.1
built with Cabal 1.14.0

This seems to have the unfortunate requirement that one must first have a project that successfully installs. I'm in the middle of trying to fix a buggy commit, and so the best I can do is a cabal-dev install --only-dependencies, which works out like so:
$ cabal-dev install --only-dependencies
Resolving dependencies...
No packages to be installed. All the requested packages are already installed.
If you want to reinstall anyway then use the --reinstall flag.
$ cabal-dev ghci
cabal-dev: user error (cabal: Run the 'configure' command first.
)

So I have to try with cabal-dev install, and if I put the following into Bug.hs:
bad :: Int
bad = True

Then I'm back around the block again:
$ cabal-dev install
Resolving dependencies...
Configuring bug-<IP_ADDRESS>...
Building bug-<IP_ADDRESS>...
Preprocessing library bug-<IP_ADDRESS>...
[1 of 1] Compiling Bug              ( Bug.hs, dist/build/Bug.o )

Bug.hs:4:7:
    Couldn't match expected type `Int' with actual type `Bool'
    In the expression: True
    In an equation for `bad': bad = True
cabal: Error: some packages failed to install:
bug-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1
$ cabal-dev ghci
cabal-dev: user error (Warning: cannot determine version of /u/afoltzer/.cabal/bin/fake-ghc-cabal-dev
:
"== GHC Arguments: Start ==\n--numeric-version\n== GHC Arguments: End ==\n"
/usr/bin/ar: dist/build/Bug.o: No such file or directory
)

If cabal-dev configure is slated to be improved, it might not be worth too much effort to figure out this edge case. After all, I can in the meantime just make sure to initialize the sandbox only with clean commits. Hopefully this information will come in handy, though.


Step 1: Refactor findString() method to readCommand()

Simplified usage, commands are auto-copied from PROGMEM
No global buffer usage, using stack-based buffers instead
Method signature using default values for arguments

Nice work!


[DOCS] Refine settings page with correction in grammar and spelling mistakes of config descriptions

Why are the changes needed?

As Kyuubi graduated as top level project, the setting page will be more often requested and should be increasingly reliable and readable with less grammar and spelling mistakes.
This PR is to

correct mistakes in grammar, spelling, abbreviation and terminology
with no config name or essential meanings changed

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

thanks, merged to master


Fix IpythonMagic for IPython >= 7.11

In IPython 7.11.0, a number of function in the py3compat have been removed.
Fixes https://github.com/ipython/ipython/issues/12068
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-84ee719fa1da> in <module>
----> 1 get_ipython().run_cell_magic('cython', '', '\ndef tmp():\n    return 0\n')

X:\Python37\lib\site-packages\IPython\core\interactiveshell.py in run_cell_magic(self, magic_name, line, cell)
   2350             with self.builtin_trap:
   2351                 args = (magic_arg_s, cell)
-> 2352                 result = fn(*args, **kwargs)
   2353             return result
   2354

<X:\Python37\lib\site-packages\decorator.py:decorator-gen-159> in cython(self, line, cell)

X:\Python37\lib\site-packages\IPython\core\magic.py in <lambda>(f, *a, **k)
    185     # but it's overkill for just that one bit of state.
    186     def magic_deco(arg):
--> 187         call = lambda f, *a, **k: f(*a, **k)
    188
    189         if callable(arg):

X:\Python37\lib\site-packages\Cython\Build\IpythonMagic.py in cython(self, line, cell)
    322         extension = None
    323         if need_cythonize:
--> 324             extensions = self._cythonize(module_name, code, lib_dir, args, quiet=args.quiet)
    325             if extensions is None:
    326                 # Compilation failed and printed error message

X:\Python37\lib\site-packages\Cython\Build\IpythonMagic.py in _cythonize(self, module_name, code, lib_dir, args, quiet)
    407     def _cythonize(self, module_name, code, lib_dir, args, quiet=True):
    408         pyx_file = os.path.join(lib_dir, module_name + '.pyx')
--> 409         pyx_file = py3compat.cast_bytes_py2(pyx_file, encoding=sys.getfilesystemencoding())
    410
    411         c_include_dirs = args.include

AttributeError: module 'IPython.utils.py3compat' has no attribute 'cast_bytes_py2'

I'll reintroduce them in a 7.11.1 as I know Cython release is not fast.
What I can also suggest is to be explicit as to when you use ... = no_code and when  not;
like use the if (sys.version_info < 3). This will make it way easier to cleanup the code later.
If you have try... except then in a few year you will have to hunt down which versions of Python/IPython have the import and it will take you hours.

See ipython/ipython#12069

I'm not going to release a 7.11.1 for now to let you test this PR. Once your happy with that let me know on ipython/ipython#12069 and I can merge and do a release.

Thanks. Apparently, str_to_unicode() is also missing now, which is used in TestIpythonMagic.py.
@Carreau, is py3compat considered an internal module? My guess is that it might have been used in the implementation because "it was there". Should we get rid of the usage all-together, and only have a couple of dedicated fallbacks for the Py2 case then?

My guess is that it might have been used in the implementation because "it was there". Should we get rid of the usage all-together, and only have a couple of dedicated fallbacks for the Py2 case then?

It was probably used because the Cython magic was originally in IPython and was transplanted in Cython. It is kinda internal, as it would be better to rely on six for both Py2 and Py3 compact, but out utils predates six.
Yes I would suggest to be explicit about the Py2/Py3 when possible, especially since you only have a couple of usage and that both of the one I see are no-op functions in Python 3.

Superseded by #3297.


Self update beszel-agent

To update a beszel-agent I currently login to the client system and issue
/opt/beszel-agent/beszel-agent update
systemctl restart beszel-agent

Is it possible to update the agent from the beszel dashboard?

Not currently. This would be difficult to implement because people are running it on different operating systems, with different configurations, different permissions, etc.
I'd recommend using a cron job or systemd timer to check for updates and restart the service if needed. I may add this functionality to the binary install script in the future.
Option 1: Cron Job
Create a cron job to check for updates daily and only restart beszel-agent if the update output contains "Successfully updated".
Open the crontab editor:
crontab -e

Add the following cron job:
0 2 * * * /opt/beszel-agent/beszel-agent update | grep -q "Successfully updated" && systemctl restart beszel-agent

Option 2: Systemd Timer and Service
Compared to cron, systemd provides more control and makes it easier to monitor update attempts via systemd logs.
Create a systemd service unit file for the update process.
Create the file /etc/systemd/system/beszel-agent-update.service with the following content:
[Unit]
Description=Update beszel-agent if needed
Wants=beszel-agent.service

[Service]
Type=oneshot
ExecStart=/bin/bash -c '/opt/beszel-agent/beszel-agent update | grep -q "Successfully updated" && systemctl restart beszel-agent'

Create a systemd timer unit file to run the update daily.
Create the file /etc/systemd/system/beszel-agent-update.timer with the following content:
[Unit]
Description=Run beszel-agent update daily

[Timer]
OnCalendar=daily
Persistent=true

[Install]
WantedBy=timers.target

Enable and start the timer:
sudo systemctl enable beszel-agent-update.timer
sudo systemctl start beszel-agent-update.timer

Verify that the timer is active:
systemctl list-timers beszel-agent-update.timer

Thank you very much for the detailed answer. I was expecting something like this.
All my systems are loaded with ansible and are very similar. So I will update them with an ansible script.
I like beszel very much 👍 Keep up the good work!

No worries, glad you find it useful. I'll convert this to a discussion in case anyone else is wondering about this.
In the next release I'll update the install script to ask the user if they want to enable automatic daily updates.


second pass through resetFunctions with RC functions in project fails

See attached for reproducible example: resetFun.txt
Basically in project$resetFunctions, if one has already called compileNimble with resetFunctions=TRUE before, then a second call to resetFunctions tries to do
assign('nimbleProject', NULL, envir = RCfunInfos[[i]]$nfMethodRCobj)
but RCfunInfos[[i]]$nfMethodRCobj is NULL, so it fails.
Looking a bit deeper, in the example, the second call to compileNimble is the first one with resetFunctions=TRUE.  That wipes out the components of RCfunInfos. However in that call to compileNimble, after the resetFunctions call, the RCfunInfos components are not recreated. I guess there is an issue with the project recognizing that it contains RC functions (in this case the user-defined distribution d and r functions). Haven't dived any deeper into this issue.
So they don't get recreated and are not there for resetFunctions to operate on in the third call to compileNimble (second call to resetFunctions).

I think I have this fixed.  Running tests on my machine.

I believe this is fixed now


No effect on AWS Rekognition?

I just downloaded two images, original and cloaked, from your website and uploaded them to AWS Rekognition. The results are 100% "similarity".
Did you upload the wrong images (I checked all of them, including Obama - that have different sizes)?

I see the same effect with my photos.

Ok, I processed this myself, and this test was run with --mode=high. The alterations are visible enough that you can see them.  AWS Rekognition thinks they are the same person.

So I considered it wasn't a realistic test to compare a before and after.  I was thinking what we need to test are two different images of the same person that have been run through fawkes.  Well I did that, and the results are not good.  Basically we get 99.9, 99.5, and 99.3% similarity for low, mid, and high.  I imagine these facial recognition tools saw all the publicity for fawkes and started training their networks to recognize cloaked images.  Maybe generative adversarial networks would be a good next step, but I am not an expert on this.  I imagine we would need those scripts for automating the testing.

https://www.theregister.com/2022/03/15/research_finds_data_poisoning_cant/
This issue suggests that big players already trained their models to resist data poisoning.
Fawkes is about done for.


[FEATURE REQUEST] Add isolate pools (thread pools)

Is your feature request related to a problem? Please describe.
Currently integral_isolates only supports creating isolates manually, one at the time. If a developer was to increase the workload, by wanting to run more smaller jobs in parallell, or run different types of jobs from the same isolate, the back pressure strategy will not understand which jobs are connected to which intention. The work will also be quite slow, as they all share the same isolate.
Describe the solution you'd like
I'd like to investigate if we could implement an isolate pool to be able to spread the workload out.
Additional context
We will need to investigate and explore a few things:

How do we decide how many isolates should be available in the pool?

Should the user/developer decide how many should be available?

Is there a global preference to set this?
Should the pool be local to just one instance of StatefulIsolate?

Should we automatically create threads when needed?

What is the upper limit of threads?

Maybe we peek at the CPU and create threads for best performance depending on physical threads?

Should responses await each other to always return in the same order as the jobs that are added or should we let responses be out of order?

Maybe we could use tags as a way to set order?

How to handle back pressure? Could we somehow piggyback on the queue, to decide when to run the BackPressureStrategy?

Moving to discussion for now, until we have answers to the most important questions.


v0.1.4 - Fixed typo in class template. loop.last changed to for.last

Codecov Report

Merging #29 (9d54c2c) into main (7a7df8a) will increase coverage by 1.12%.
The diff coverage is 100.00%.

:exclamation: Current head 9d54c2c differs from pull request most recent head 9f25a87. Consider uploading reports for the commit 9f25a87 to get more accurate results

@@             Coverage Diff             @@
##             main       #29      +/-   ##
===========================================
+ Coverage   98.87%   100.00%   +1.12%
===========================================
  Files          30        41      +11
  Lines         266       471     +205
===========================================
+ Hits          263       471     +208
+ Misses          3         0       -3

Impacted Files
Coverage Δ

...ntler.Commons.CodeGen.Core/Base/CompilationBase.cs
100.00% <ø> (ø)

...vantler.Commons.CodeGen.Core/FileTemplateLoader.cs
100.00% <ø> (ø)

...er.Commons.StringHelpers/CasingStringExtensions.cs
100.00% <ø> (ø)

....AutoFixture.DataAttributes/AutoNSubstituteData.cs
100.00% <100.00%> (ø)

...tler.Commons.CodeGen.CSharp/CSharpCodeGenerator.cs
100.00% <100.00%> (ø)

...ler.Commons.CodeGen.CSharp/CSharpTemplateLoader.cs
100.00% <100.00%> (ø)

...ntler.Commons.CodeGen.CSharp/Models/CSharpClass.cs
100.00% <100.00%> (ø)

...Commons.CodeGen.CSharp/Models/CSharpCompilation.cs
100.00% <100.00%> (ø)

...Commons.CodeGen.CSharp/Models/CSharpConstructor.cs
100.00% <100.00%> (ø)

...er.Commons.CodeGen.CSharp/Models/CSharpDocBlock.cs
100.00% <100.00%> (ø)

... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


State description

Description of the Change
Fix capital in the state description

Lol! 😂

Only flagging as invalid for #hacktoberfest


Bugfix/session client side validation

Fixes #104

Hello @jfougere
Thanks for your contribution. Looks good to me.
The only thing is that we tend to release @voucherify/react-widget whenever ClientSide SDK changes since @voucherify/react-widget is internally using ClientSide SDK. Could you add patch bump to @voucherify/react-widget in your changeset?

@darekg11 done

@jfougere Thanks again, new version 2.0.1 has just been published to NPM


Syntax Highlighting not working properly.

The following piece of code don't get the proper syntax highlights:
    static int CalculateBalancingLotSize
    (
        decimal currAvgPrice,
        int currStockQty,
        decimal currStockPrice,
        decimal intendedAvgPrice
    )
    {
        var lotSize = currStockQty * ((currAvgPrice - intendedAvgPrice) /
                                  (intendedAvgPrice - currStockPrice));
        return (int)(lotSize);
    }

I understand that the way the formal parameters of the above method are laid-out is in a non-orthodox way, but it is valid syntax. After the first parameter, the type names are not highlighted, and, inside the method body, the 'var' and 'return' keywords are not highlighted also.

C# Extension Version: 1.23.15
VS Code Version: 1.60.2

Yep, this solved the problem for me. I am not closing the issue myself because I don't want to interfere in how you guys at this project reason about what solves an issue, but, for the record, the workaround you pointed out brought the correct highlights back. Thanks for that! \o

Closing as the C# extension now ships with semantic highlighting and an improve textmate grammar.


Invalid clause ID

Getting an invalid clause ID when trying to use the execution url

Hi @danny-ibm, thanks for raising an issue.
Please try making a change to your clause and clicking save before trying again. This is known issue that we plan to address shortly.
Our apologies for any inconvenience.


[React 18] ButtonClose type declarations are invalid

Description
When loading the PRC type declarations in a React 18 environment, there is a type error in the<EMAIL_ADDRESS>file:
error TS2344: Type '"theme" | "key" | "sx" | keyof ButtonHTMLAttributes<HTMLButtonElement>' does not satisfy the constraint '"children" | "name" | "ref" | "type" | "hidden" | "theme" | "form" | "slot" | "style" | "title" | "key" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | ... 254 more ... | "formTarget"'.
  Type '"nonce"' is not assignable to type '"children" | "name" | "ref" | "type" | "hidden" | "theme" | "form" | "slot" | "style" | "title" | "key" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | ... 254 more ... | "formTarget"'.

276 }, "theme" | "key" | "sx" | keyof React.ButtonHTMLAttributes<HTMLButtonElement>> & React.RefAttributes<HTMLButtonElement>>;

Looking at this button compared to the other button types (which don't have issues), I think the main difference is that this one is set up to handle forward refs. Not positive what the fix is here, but I can work around it for now with skipLibChecks
Relates to #2536
Steps to reproduce

Run tsc in a project using PRC + React 18 types
See type error coming from ButtonClose types

Version
v35.14.2
Browser
No response

@joshblack let's add this into #2536, what do you say?


Feature: warning for too large pies

What about including warnings for pies with too many slices? A pie menu is faster than usual linear docks only if the pies are wide enough. Once the degrees of the angle of each slice is less than a certain amount (to define), clicking on the right slice is more difficult. I think it could be useful to warn the user about that, in order to make sure everyone have the best experience possible.
A tip somewhere in the app could suggest to split too large pies, or to define sub-pies.

This is a good idea, I'll include such a hint in the new tip-slide-show!


Fix crash on VpnPermissionRequesterActivity

Task/Issue URL: https://app.asana.com/0/0/1202994567277582/f
Description
Fixes a crash with an uninitialized property in VpnPermissionRequesterActivity
Steps to test this PR

Fresh install of the app
Swipe down on the system status bar (possibly twice depending on OEM) to reveal quick tiles
If App Tracking Protection not visible, choose to edit the tiles and make it visible
Click on the tile
Choose to grant VPN permissions  ← crash happens here
Crash happens because vpnFeaturesRegistry is uninitialized

Current dependencies on/for this PR:

develop

PR #2287   👈

This comment was auto-generated by Graphite.


Solve failing test because PyMC 5.13 release

Closes https://github.com/pymc-labs/pymc-marketing/issues/620

📚 Documentation preview 📚: https://pymc-marketing--623.org.readthedocs.build/en/623/


Passport tab bar's buttons are not working properly

Now it's impossible to block players or to see their's collectibles. Passports' buttons close it instead of showing each section info.

this has been already fixed in https://github.com/decentraland/explorer/pull/1291


Wither has 15 stacks max now

In the current version I can choose between 1, 5, 10, 20 Wither stacks. But it has 15 max since 3.1.

Fixed in the next update, courtesy of @DragoonZ.


Convert SilkTouch from a Source generator to something more IDE friendly

SilkTouch increases build times by > 50s in large projects. Right now IDEs don't call into SilkTouch, but once they do, on every keypress, opening the Silk.NET solution will probably be almost impossible.
@Perksey any thoughts?

Looking at https://github.com/aarnott/CodeGeneration.Roslyn

I hear Uno.CodeGeneration is good

Deemed moot in a meeting.


mount dask-etc configmap in prefect pods

@aktech, Currently we are having to maintain and add the /etc/dask/gateway.yaml into the prefect image.  I think it would probably be better if this pod mounted the dask-etc configmap instead.

Agreed. Putting this into our issue backlog


Feature: Haptic Feedback Toggle in Settings

Description
I propose the addition of a Haptic Feedback Toggle in the Settings page. This feature aims to enhance the user experience by providing tactile feedback upon interacting with buttons (IconButton, TextButton, FloatingActionButton, etc.). The default setting will have Haptic Feedback enabled, ensuring a responsive feel for users. However, through the Settings page, users will have the flexibility to disable this feature according to their preferences, offering a customizable experience. The implementation involves integrating a Haptic Feedback service and a toggle switch in the Settings page, contributing to the overall usability and accessibility of the application.
Benefits

Improved User Experience: Haptic feedback enhances the overall user experience, providing a tactile response that makes interactions more intuitive and engaging.
Customization: Users can tailor their experience by enabling or disabling Haptic Feedback based on their preferences.

Hello @savitore Could you assign this issue to me
Thank you

assigned @andoriyaprashant

Hello sir @savitore , I was working on this issue, and I created a separate file for haptic feedback (haptic_feedback.dart).
Here is the code

and I also added a switch for it in the settings

However, whenever I use haptic feedback on any button by executing the command in the code

it is being shown in the terminal, but it is not vibrating physically.


feature: split kubestellar release into 'core' and 'plugins' to support helm and brew initiative

Feature Description
Our release has all ks core plugins and ks kubectl plugins in the same tar archive.  These should be split out to allow for helm install of core components on kind, kubernetes, openshift, and plugins to install the complimentary plugins from the matching kubestellar release for kubectl using brew.
Proposed Solution

split kubestellar release (from make file) into 2 parts.  core and plugins

Want to contribute?

[x] I would like to work on this issue.

Additional Context
No response

I think that we have been using the term "plugins" as a bit of a short-hand for something that is a little different. I think what is important is who/what needs to use which of the executables.
FYI, currently the unified build puts the following in bin/.
bash-3.2$ ls -1 bin
kubectl-kubestellar-deploy
kubectl-kubestellar-ensure-location
kubectl-kubestellar-ensure-wmw
kubectl-kubestellar-get_external_kubeconfig
kubectl-kubestellar-get_internal_kubeconfig
kubectl-kubestellar-get_log
kubectl-kubestellar-prep_for_cluster
kubectl-kubestellar-prep_for_syncer
kubectl-kubestellar-remove-location
kubectl-kubestellar-remove-wmw
kubectl-kubestellar-syncer_gen
kubectl-workspace-ensure
kubestellar
kubestellar-ensure-ca
kubestellar-ensure-kcp-server-creds
kubestellar-make-kcp-server-cert
kubestellar-version
kubestellar-where-resolver
mailbox-controller
placement-translator
remove-kubestellar
switch-domain
syncer
wait-and-switch-domain

If we focus on the case of deploying the core as kube workload (rather than bare processes) then those executables can be categorized as follows.
Part of the core (used in the hosting cluster)

kubestellar
kubestellar-ensure-ca
kubestellar-ensure-kcp-server-creds
kubestellar-make-kcp-server-cert
kubestellar-where-resolver
mailbox-controller
placement-translator
switch-domain
wait-and-switch-domain

Used by a user to deploy the core

kubectl-kubestellar-deploy

Users by users of a deployed core

kubectl-kubestellar-ensure-location
kubectl-kubestellar-ensure-wmw
kubectl-kubestellar-get_external_kubeconfig
kubectl-kubestellar-get_internal_kubeconfig
kubectl-kubestellar-prep_for_cluster
kubectl-kubestellar-prep_for_syncer
kubectl-kubestellar-remove-location
kubectl-kubestellar-remove-wmw
kubectl-kubestellar-syncer_gen
kubectl-workspace-ensure

Used by users of a deployed core AND useful to include in the core

kubestellar-version

Deployed in the WECs

syncer

Not used (only applicable for bare-process deployment)

remove-kubestellar

In the case of deploying the core as bare processes, the categories "Part of the core" and "Used by a user to deploy the core" merge together and adopt the one executable from "Not used".

I could see lumping the categories above into two big baskets.
executables needed in the core, consisting of the categories

Part of the core
Used by users of a deployed core AND useful to include in the core

executables needed outside the core, consisting of the categories

Used by a user to deploy the core
Users by users of a deployed core
Used by users of a deployed core AND useful to include in the core
Only used with bare-process deployment

The next question is what does building look like and what gets built.  I can think of a few possibilities.

Both baskets go in bin/ and there is a make target for each basket.
Each basket goes in a distinct binary directory (maybe corebin/ and bin/ ?) and make build covers both.
Each basket goes in a distinct binary directory and has its own make target.
Each basket goes in a distinct binary directory and has its own make target (make corebuild, make userbuild) and also make build invokes both of those.

This also raises questions of what happens to the quickstart and the bootstrap script.

There is some advantage in leaving the quickstart unchanged, and thus the usage of the bootstrap script unchanged.
This is not to deny a separate idea: give the bootstrap script the option to NOT defer to deployments already found on the $PATH. That makes sense orthogonally to this issue.

I think we need to make a deliberate choice about what happens with the quickstart.  I can think of a few possibilities.
(A) Keep the quickstart exactly the same. This means that both baskets of executables are delivered in one bin/ for the user to add to their $PATH. I think the simplest way to get this done is to have release platform archives that have one bin/ with both baskets of executables. To also support the brew thingy that installs just the executables needed outside the core, this means that for a release we create two archives per platform: one holding both baskets in one bin/, and one holding only the executables needed outside the core in bin/. I think the most direct way to do that is with two make targets: each puts the executables in bin/, and one builds only the executables needed outside the core and one that builds both baskets.
(B) Is like (A) but the two archives per (release, platform) correspond to the two baskets, and we modify the bootstrap script to fetch both and unpack the second one in a way that adds to the result of unpacking the first (which is normal for tar, right?).
(C) is like (B) except that the executables needed in the core go into corebin/ while the executables needed outside the core still go into bin/. This means that the bootstrap script tells the user to add two KubeStellar directories to their $PATH rather than just one.
Approach (C) is the clearest in terms of making the distinction, but requires the most change to the quickstart and bootstrap script.

I think (A) might be least surprising to users.  Absent any other feedback, that is what I will do.

Since we are taking the approach of building an outside-only archive plus a full archive, the baskets that matter are the outside-only and the full. The difference is only the category of "Part of the core (used in the hosting cluster)", which is excluded from the outside-only basket.

@francostellari can you give this a review please?

oops, I approved the PR before I saw the request for more review.

More work could be done on this issue. Currently both flavors of release archive bundle config/ and core-helm-chart/ as well as bin/. The user flavor does not need config/.

I personally do no like the idea of having some many different scripts. A lot of them could be assembled in higher level scripts, especially the plugins. Additionally all these changes may have breaking implications.
I think we need to focus on understanding on what needs to go into the future space manager based KS.


Locked accounts

Hello !
On the SearchTimeline GraphQL i regularly get errors 401/403 lead to account locked with Arkose Challenge.
I'm the only one or it's normal ?

Normal. X wants to sell API subscriptions.

For sure :D
i try to understand what led to this account ban, i've not found so far. Anybody else works on this problem ?

Yes very common, large numbers of gql mutations (most Account methods) may trigger these locks/bans. If you are just scraping, bans are unlikely, even when hitting rate limits consistently.

I trip Arkose challenges regularly when using Search/Scraper methods well within rate limits, with a consistent IP address.


push & run aligned apk to device

A few suggestion:

Currently, the Makefile installs and runs makecapk.apk, wouldn't it be better to replace that with aligned.apk?

In my modified version of the Makefile I also added APK_NAME ?= $(APPNAME).apk variable to automatically name the final (aligned) .apk output.

Wouldn't it also be cleaner to delete temp.apk and makecapk.apk (or at least the former) after a successful build? I think it would avoid confusion.

I would also replace echo with @echo to make the output a slight bit easier to parse by eye.

Hmm... This is attractive.  Do you mind taking the current setup and doing a diff on the Makefile for just this?  I would probably accept it.

This was also resolved in the recent PR.


gzip: make reproducible when SOURCE_DATE_EPOCH is set

automatically makes gzip usages in our builds reproducible
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Not sure this is the best way to do this. Perhaps a bash alias might be more appropriate? OTOH This also applies to non-bash use-cases.

Not sure this is the best way to do this. Perhaps a bash alias in stdenv might be more appropriate? OTOH This also applies to non-bash use-cases.

aliases won't be enough. see https://github.com/NixOS/nixpkgs/issues/86348
this is just converting the setup hook which uses a deprecated value to a more resilient wrapper

Alright.
I think I'd prefer regular gzip to still be fully unwrapped though.

Why? i don't see why a nix build should output a timestamped .gz

A Nix build certainly won't but it violates the principle of least surprise for users. I wouldn't expect my gzip to be wrapped in my PATH; it should be a dead simple program.

But why does it matter to users,  people do not edit binaries.

People use gzip to compress tarballs. Its behaviour should not be different to any other distro's gzip.
Generally, I don't think we should propagate reproducibility patches to end user utilities.

Note that the behaviour is only changed when that env variable is set, generally meaning that people already want a reproducible build in their current environment.

Note that the behaviour is only changed when that env variable is set, generally meaning that people already want a reproducible build in their current environment.

Well unfortunately nix-shell also sets SOURCE_DATE_EPOCH, and people use that currently. This will no longer be an issue once / when / if in the far future the new nix cli is marked stable, and be can everybody to just use that, but currently, well..

now it's only set in nix builds which use genericBuild (no nix-shell)

TBH I think it is also useful for end-users to have more reproducible archives by default (and have them opt-out by unsetting source_date_epoch), but I can live with this for now. Too bad we have to expand the stdenv setup script even further for this though...

rg --files-with-matches 'gzip -n'

gives me quite a few places in nixpkgs where we explicitly call gzip -n which can be removed now, but that can be left for a separate pr.

Anyway the gzip in a nix-shell comes from stdenv (meaning pkgs/stdenv/generic/common-path.nix), unless you explicity pull it in I guess). It would be wrapped either way. So if we implement your suggestion, the gzip exposed in top level pkgs would be different from the one in a nix-shell, which might be surprising. But maybe we can live with that?

common-path is in all stdenv usage including nix-shell so this isn't possible

Turning gzip into a wrapper from binary seems to have broken out bootstrap tool building and preparation:
$ nix build --no-link -f pkgs/stdenv/linux/make-bootstrap-tools.nix bootstrapTools
error: builder for '/nix/store/xc1k9q7abdnb94aq4f00z9nkp4davgpb-bootstrap-tools.drv' failed with exit code 1;
       last 10 log lines:
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/cpp
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/diff
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/diff3
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/find
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/g++
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/gawk
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/gcc
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/grep
       > patching /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/gzip
       > patchelf: not an ELF executable
       For full logs, run 'nix log /nix/store/xc1k9q7abdnb94aq4f00z9nkp4davgpb-bootstrap-tools.drv'.

$ cat /nix/store/148vp7d5msdns595mb8jdklbnh44pgnk-bootstrap-tools/bin/gzip
#! /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bash-5.2-p15/bin/bash -e
exec -a "$0" "/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gzip-1.12/bin/.gzip-wrapped"  ${GZIP_NO_TIMESTAMPS:+-n} "$@"

Can you have a look? Perhaps best would be to use binary gzip as is in bootstrapTools.

https://github.com/NixOS/nixpkgs/pull/211948