[SPARK-7794] [MLLIB] update RegexTokenizer default settings

The previous default is {gaps: false, pattern: "\\p{L}+|[^\\p{L}\\s]+"}. The default pattern is hard to understand. This PR changes the default to {gaps: true, pattern: "\\s+"}. @jkbradley

Merged build triggered.

Merged build started.

Test build #33281 has started for   PR 6330 at commit 5ee7cde.

Test build #33281 has finished for   PR 6330 at commit 5ee7cde.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33281/
Test PASSed.

LGTM
My only comment is that I'd prefer to have the Python doc (including doc embedded in Param) match the Scala doc, rather than being a short version of it.  I also like having the embedded doc match the Scala/Python generated doc so that explainParam prints out more info.

Agree. Right now it has huge overhead of keeping the docs in sync. It would be nice if this could be done automatically, e.g., geting the Scala Param.doc via Py4J. I merged this into master and branch-1.4.


override seed column types when inferred to be of type agate_helper.ISODateTime

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
this issue came up with dbt-firebolt because the JDBC driver doesn't like non-string bindings for prepared statements. My goal is to cast them all to strings.
the issue came up when using dbt-adapter-tests's base.csv. IIRC, this issue did not happen in dbt-core 0.20.0
line 49 of agate_helper.build_type_tester() (snippet below) results in an agate_table where some_date to be of type : ISODateTime. commenting out line 49 fixes this problem, as it allows the values in agate table to be overridden.
https://github.com/dbt-labs/dbt-core/blob/d833c8e45a5486dcd07f3417926a88c6edb6fd43/core/dbt/clients/agate_helper.py#L43-L54
it is insufficient to  modify adapter.convert_datetime_type because that will only change the column's type, not the actual values. though, in my head, I thought that this would work.
@classmethod
def convert_datetime_type(cls, agate_table: agate.Table, col_idx: int) -> str:
    # there's an issue with timestamp currently
    return 'TEXT'

logging/diagnosis
logging set up
here's the log statements I added to seed.sql
{% macro firebolt__reset_csv_table(model,
                                   full_refresh,
                                   old_relation,
                                   agate_table) %}
    {{ log('agate_table col types: ' ~ agate_table.column_types, info=True) }}
    {{ log('agate_table schema: ' ~ agate_table.print_structure(), info=True) }}
    {{ log('agate_table vals: ' ~ agate_table.print_table(), info=True) }}
....
{% macro firebolt__load_csv_rows(model, agate_table) %}

  {% set batch_size = get_batch_size() %}

  {% set cols_sql = get_seed_column_quoted_csv(model, agate_table.column_names) %}
  {% set bindings = [] %}

  {% set statements = [] %}

  {% for chunk in agate_table.rows | batch(batch_size) %}
      {% set bindings = [] %}

      {% for row in chunk %}
            {{ log('row: ' ~ row, info=True) }}
          {% do bindings.extend(row) %}
      {% endfor %}

logging output
col_name: some_date
inferred_type: TEXT
type: TEXT
row: <agate.Row: (Decimal('1'), 'Easton', datetime.datetime(1981, 5, 20, 6, 46, 51))>

however, if I comment out line 49 from above, then not only is the column type changed to be of type TEXT but also the parameters in the INSERT INTO ... VALUES statement also become strings.
Expected Behavior
I expect that adapter.convert_datetime_type() would allow any seed column that's datetime-like to be overrided to the returned type. However, this does not work if the column type is inferred to be agate_helper.ISODateTime.
Environment
- OS: macOS `11.6.1`
- Python: `3.9.5`
- dbt: `0.21.1rc1`

What database are you using dbt with?
firebolt==0.20.2

@swanderz Thanks for opening!
The code for ISODateTime dates back to https://github.com/dbt-labs/dbt-core/pull/1920, which attacked some of the gnarliest earliest issues around agate type inheritance. I'm really hesitant to merge potentially breaking changes after we've released v1.0.0rc1.
dbt is very used to the idea that different adapters may have a different data type name corresponding to each agate/python data type. This is implemented via the convert_x_type adapter methods, which all feed into the convert_type adapter method. That then gets used in create_csv_table, to populate the empty table with the right inferred database types, based on the actual content that's about to be loaded. It can also be used to adjust the SQL in load_csv_rows, so that w explicitly cast each value, as it's being inserted, to match its specified/inferred type. dbt-spark has to do this, now that Spark 3 strictly enforces table schemas.
What's new and tricky about this issue is that the client/driver requires all binding parameters to be string type. That's much harder to work around, and the agate convert_x_type won't do much for us. My question is, wouldn't you see this issue for numeric types as well?
I do think there may be an entirely adapter-side workaround for this, which requires some clever materialization code:
{% macro firebolt__load_csv_rows(model, agate_table) %}
    ...
    {% for row in chunk %}
          {% set all_text_row = [] %}
          {% for value in row.values() %}
              {% do all_text_row.append(value | string) %}
          {% endfor %}
          {% do bindings.extend(all_text_row) %}

          {# here for debugging purposes only #}
          {{ log('row: ' ~ row, info=True) }}
          {{ log('all_text_row: ' ~ all_text_row, info=True) }}

      {% endfor %}
      ...

Then, here's what I see:
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('1'), 'Easton', datetime.datetime(1981, 5, 20, 6, 46, 51))>
13:15:37 | [ info  ] | all_text_row: ['1', 'Easton', '1981-05-20 06:46:51']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('2'), 'Lillian', datetime.datetime(1978, 9, 3, 18, 10, 33))>
13:15:37 | [ info  ] | all_text_row: ['2', 'Lillian', '1978-09-03 18:10:33']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('3'), 'Jeremiah', datetime.datetime(1982, 3, 11, 3, 59, 51))>
13:15:37 | [ info  ] | all_text_row: ['3', 'Jeremiah', '1982-03-11 03:59:51']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('4'), 'Nolan', datetime.datetime(1976, 5, 6, 20, 21, 35))>
13:15:37 | [ info  ] | all_text_row: ['4', 'Nolan', '1976-05-06 20:21:35']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('5'), 'Hannah', datetime.datetime(1982, 6, 23, 5, 41, 26))>
13:15:37 | [ info  ] | all_text_row: ['5', 'Hannah', '1982-06-23 05:41:26']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('6'), 'Eleanor', datetime.datetime(1991, 8, 10, 23, 12, 21))>
13:15:37 | [ info  ] | all_text_row: ['6', 'Eleanor', '1991-08-10 23:12:21']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('7'), 'Lily', datetime.datetime(1971, 3, 29, 14, 58, 2))>
13:15:37 | [ info  ] | all_text_row: ['7', 'Lily', '1971-03-29 14:58:02']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('8'), 'Jonathan', datetime.datetime(1988, 2, 26, 2, 55, 24))>
13:15:37 | [ info  ] | all_text_row: ['8', 'Jonathan', '1988-02-26 02:55:24']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('9'), 'Adrian', datetime.datetime(1994, 2, 9, 13, 14, 23))>
13:15:37 | [ info  ] | all_text_row: ['9', 'Adrian', '1994-02-09 13:14:23']
13:15:37 | [ info  ] | row: <agate.Row: (Decimal('10'), 'Nora', datetime.datetime(1976, 3, 1, 16, 51, 39))>
13:15:37 | [ info  ] | all_text_row: ['10', 'Nora', '1976-03-01 16:51:39']

By feeding the text-only values into bindings, instead of the typed python objects, I'm hopeful that will make the JDBC driver. Could you give it a try, and let me know if it gets you what you need?

IIRC, this issue did not happen in dbt-core 0.20.0

It's possible that the changes to prevent agate from type-coercing query results played a role here. I'd be surprised, though; we didn't touch agate's type inference for seeds at all.


feature/styles: [TASK-2024-00297] - sidebar filter

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

excellent, except small ui-bug with check mark icon;
to reproduce select "Me" in the "Assigned to" filter

@romansyd I`ve fixed a bit styles for this icon and for drop-down. Moreover I've changed color for saved items in filter.


[stable/traefik] Enable HTTP authentication for the dashboard

Also allow configuration of the dashboard's service address and whether the Ingress should be generated.

I signed it!

cc @krancour

This is a duplicate of #414. This may have been submitted first, but #414 has been more thoroughly reviewed, requested changes already applied, etc.

@krancour Agreed, I could strip the http auth part from this PR and leave that to #414. Then only the address and public parameters would be handled here.

@tolbrino ya... let's take the basic auth stuff out of this PR and consider what remains on its own merit. tbh, I haven't looked to closely at those others changes yet.

@tolbrino @krancour What would you like me to do with this?

@lachie83 I forgot to adapt the PR so far. Will do so in the coming days, then you can review it again.

@tolbrino can you please provide a status update?

Closing due to inactvitiy. @tolbrino feel free to re-open.


@conda-forge-admin,please add bot automerge

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/asn1-feedstock#4.


Add split train/test step in preprocessing

Description
Add split_data.py script that splits into train/test. Use it also in preprocess commands.
Resolves #115
Checklist

[x] Linked to Notion or GitHub issue
[x] Added tests
[x] Updated README
[x] DVC up to date

@nsorros still need to add tests, but check out if it's in line with what we talked

This is on a good path, just need to fix tests

Don't forget to link to the issue https://github.com/wellcometrust/grants_tagger/issues/115 to close it automatically when this merges
Also you can remove the release checklist in PR where this does not apply

@nsorros resolved comments, good to merge?

@nsorros resolved the last small thing, good to go?


Windows support

Hi
Can i run my app on android in windows like the ionic frameworks does?

with the new Meteor <IP_ADDRESS> you can!


Add a DOCKER_TAG_SEMVER variable

When manually running DOCKER_TAGS="<tag a> <tag b>" make docker-push I sometimes want to be able to set a build parameter with a SemVer-compatible transformation of <tag a>. This would function similar to GIT_HEAD_SEMVER, and I suppose might require similar env vars to all of the GIT_HEAD_SEMVER_<part> variables too. I think the first tag in the list makes the most sense to transform in this way.
This would be useful for testing update processes/systems, where I want to be able to build 2 distinct Docker tags of an otherwise identical Git version, so that you can more easily tell which version you currently have installed.

Closing, will re-open with better ideas.


add pyconvert(x)

For convenience, it would be nice to expose
pyconvert(x) = pyconvert(Any, x)

Perhaps, but you generally shouldn't be using pyconvert(Any, x), you should use a more specific type. The only good reasons I can see for pyconvert(Any, x) are:

Interactive use, where you already know the conversion will do what you want.
Generic programming, where you don't actually know anything about x.

Those 2 usage examples seem pretty common. Moreover, I would find it very useful to have a pyconvert(Any, x) with a recursive behavior, something like what I poorly implemented https://github.com/CarloLucibello/HuggingFaceDatasets.jl

I've previously had discussions about adding a function pyconvertnative(x) which converts x (recursively) to a 'native' Julia object if possible (list to Vector, dict to Dict etc.).

I just added my two cents to the pyconvertnative() discussion, see #128
Maybe we could continue the discussion here?


Typos in Chapter 2

Section 2.3.1 (page 45)
In the second the last paragraph of Section 2.3.1, "3350=865+2475" should be "3350=875+2475".

Figure 2.15 (page 59)
In the legend of Figure 2.15, there are missing spaces between Student and (dof 1).

fixed thanks


Tooltip for 'time' primary axis not showing time correctly

A random number less than 1 is appearing where a date should appear.

function StatsChart(props: JosekiStatsModalProperties) {
    const stats_data = React.useMemo(() => (
        [
            {
                label: 'Total Page Visits',
                data: props.daily_page_visits.map(day => ({x: new Date(day.date), y: day.pageVisits}))
            },
            {
                label: 'Explore Page Visits',
                data: props.daily_page_visits.map(day => [new Date(day.date), day.explorePageVisits])
            },
            {
                label: 'Play Mode Visits',
                data: props.daily_page_visits.map(day => [new Date(day.date), day.playPageVisits])
            },
            {
                label: 'Guest Visits',
                data: props.daily_page_visits.map(day => [new Date(day.date), day.guestPageVisits])
            }
        ]), [props]);

    const axes =
        [
            { primary: true, type: 'time', position: 'bottom' },
            { type: 'linear', position: 'left' }
        ];

    const series = {
          showPoints: false
        };

    return (
        <Chart
            data={stats_data} axes={axes} series={series} tooltip
        />
    );
}

export class JosekiStatsModal extends Modal<Events, JosekiStatsModalProperties, any> {

    render() {
        //console.log(this.props.daily_page_visits);
        return (

{_("Joseki Explorer Stats - Daily Position Loads")}

                    <StatsChart daily_page_visits={this.props.daily_page_visits}/>

        );
    }
}

You must round off your dates to the time unit you want to display. Eg. if you want hourly, you must ensure that your dates do not have arbitrary minutes, seconds and microseconds. I would suggest utilizing a date rounding library or d3's time utilities to make this a bit easier.

Having looked at this, I'm not sure what is driving me to select a limited precision for dates here.
I was expecting the tooltip header to render the exact date that was supplied as the X value for those points.

Rounding off hours and all below did deliver the visual result I was looking for, thanks :)
data: props.daily_page_visits.map(day => ({x: new Date(day.date).setHours(0, 0, 0, 0), y: day.pageVisits}))

I know, months was a bad example. Most of this is because of D3’s auto formatting which is based on specificity of time stamps.  Since your time has a non zero specificity of milliseconds, it’s showing you The x value of how many seconds (.92) have elapsed at that point. If you zeroed out the milliseconds, it would likely show a time like 12:45

Could this be why the the first point is starting further along the x-axis than it should? I have start using the library and have found that my first point doesn t align with the y-axis and starts further in

There is a way to "clamp" the axis bounds actually. But it's obviously undocumented like a majority of this library lol. Let me find the source...

Try setting min or hardMin and max or hardMax options on the axis to the values of your start/end range. I believe that will clamp the axis.

I checked the source code and it looks like it needs to be a number but Im using the time scale?

Ignore me I got it working by converting the date object to a number and it worked


User List

This is an UI only PR.

Part of #55

This is an UI only PR.

I added the tooltips and hid the overflow.
However:

Your suggested change has no effect
I will keep the icons as they are right now, because the focus of these icons is to call or join the user. The icons form the mockup shift the focus to the conference in my opinion.

btw.: I know, that the component structure is somewhat crazy right now. Refactoring will definitely happen.


inuit/css questions

when scrolling down the images of the profiles stay over the header
I have added font-size: 24px to the form and now the button and the formfield are correctly aligned
changed the color of the button for a try
added font-awesome for icons http://fortawesome.github.io/Font-Awesome/ https://github.com/bokmann/font-awesome-rails
fixed all the tests (one test is failing now and then, just reload on the Travis webpage and its all green again) \o/
for the contact form in the profile show view we need to add the correct javascript, I delete now all the bootstrap javascript as well and used jquery for tooltip
check responsiveness

Let us make sure, that all the test are green in the inuit branch from now on

since @tyranja removed bootstrap - conacting a speaker isn't possible anymore

rebuild with jquery? or other possibilty

it's possible to use bootstrap in admin interface and inuit in the other parts

I think, that makes no sense, then we would have to load all the bootstrap things again. But I am nearly done!

I think I finished refactoring all the views with inuit. Just the issues with the profiles and the contact form on the profile show view are still there. I kept them for you ;)
I added a better limitation for the length of the maintopics and I added the functionality to edit the position of the medialinks for the admins.

@sabrina-ulbrich @bioshrimp here are the CSS-Todos @tyranja left us.
I add the following things:
*buttons > please adjust them to the current design in production (speakerinnen.org), means shadow and round corners
*grid of selected profiles on homepage (has to be adjusted properly)
*some elements (eg. profile pictures on the homepage and tag boxes in profile/edit) don't disappear when scrolling over the header

@zaziemo regarding grid of selected profiles: not the full solution but maybe one step: define in the class 'photo--grey': width: 100% (but the left picture is wider than the others)

@sabrina-ulbrich cool :) Will you try to fix it?

@zaziemo I did the thing with the contact form. I hope its ok with you, I just wanted to do sth productive ;)

@tyranja yeah :+1:  everything is fine with me. I think there are some more issues left to be solved by me !

current bugs on staging CSS:
*search box in english locale is cut because of shorter links

Now all the CSS problems should be solved. Yay :) I pushed the current status of branch inuit-css-refactoring-rails4 to staging. It would be great if all of us @sabrina-ulbrich @bioshrimp and @tyranja (if possible) test it and add comments if something is strange. Next week, Regine will be at Rubymonstas and could help solving remaining problems.

*profiles edit: input fields could be longer, there is enough space  - right now urls and longer names are cutted

cool. I could do that with the profile edit fields
Is it already responsive?

@tyranja great :+1: We didn't yet test for responsiveness but we kept that in mind all the time. But you are right we have to keep an eye on reponsiveness while testing.

on the index page the boxes of the speakers are a bit moved to the right, compared to the border line in top of them ...

@tyranja that's right. We didn't manage to build the grid perfectly. That is one thing we hope to solve with Regines help. If it doesn't work we will leave it like this. Pragmatism rules ;)

I have another thing ;)
In march this year a lot of the inuit code on github changed. If you compare our trumps.width.scss (https://github.com/rubymonsters/speakerinnen_liste/blob/inuit-css-refactoring-rails4/app/assets/stylesheets/inuit/_trumps.widths.scss)  with the current file on github: https://github.com/inuitcss/trumps.widths/blob/master/_trumps.widths.scss you can see it.
When we want to use the responsive width file, its not working (you get an error message) because of the changes in the whole inuit project. I guess we have to update all our inuit files. :(  Maybe you could ask Regine.

@tyranja Regine says we could use the resposive file of the same version we are using right now and update everything another time.

For the smartphone version?

@tyranja you mean if we like the header design?
Me: yes.

Well, that was a suggestion, how we could do it. It's just a jpeg right now and not implemented ...

Didn't we plan to remove the jpeg on smaller screens and to show only Home instead?

yes, but I kind of like to have the logo still on top.

Or, we remove the logo and have in the menü also home as a link?

jep, great. Do you have time to implement it? Or a hint how we can implement it this evening with @sabrina-ulbrich and @bioshrimp?

I would like to start. But I willl send you the link anyway and tell you later how far I got.

@tyranja cool!

done with the help of all @bioshrimp @sabrina-ulbrich but mostly by @tyranja! You rock :)


feat: allow for different flag rendering (e.g. to add an icon).

In order to support adding an icon to visually indicate that the flag is tappable (e.g. in image below), support a backwards compatible renderFlag method.

Could you add example of usage in the README file?

@zizzle6717 I've added an example to the readme, and added mention of the flagStyle overrides which are preferable for most everyday use-cases.

Thanks @cjpete Published at v1.3.0


question of .vcxproj

can i set a search order of VcpkgTriplet like this
<VcpkgTriplet Condition="'$(Platform)'=='Win32'">x86-windows</VcpkgTriplet>
<VcpkgTriplet Condition="'$(Platform)'=='x64'">x64-windows,x64-windows-static</VcpkgTriplet>

or i can set some lib  that compiled with  x64-windows-static  and another is x64-windows

@xspeed1989
You can't set the search order of VcpkgTriplet, <VcpkgTriplet Condition="'$(Platform)'=='x64'">x64-windows,x64-windows-static</VcpkgTriplet> is incorrect, this will make all of x64-windows and x64-windows-static include and lib are not available. With the set of VcpkgTriplet, x64-static and x64-dynamic can only exist one at a time.

@xspeed1989, please reopen this if it still be an problem for you.


Add support for nested objects and arrays

Unscheduled

This can be closed. Nested objects are supported and nested arrays are useless for Redshift, but can be easily implemented for other DDLs.


[Bugfix] Fix IllegalArgumentException thrown when creating a PIT

Description
Fixes java.lang.IllegalArgumentException: No enum constant org.opensearch.action.search.SearchPhaseName.CREATE_PIT which is thrown when creating a PIT.
The exception comes from SearchRequestStats. It doesn't track PIT stats as this is handled elsewhere. So, when it got search phases with the name "create_pit", it couldn't find a matching enum value and threw the error. Adds a try-catch block on search phase start/end/failure so that if no matching enum value is found, nothing happens.
Adds UTs. Also, manually tested that after making the change, the following commands no longer caused the exception:
curl -XPOST "http://localhost:9200/test-index/_doc/1?op_type=index" -H "Content-Type: application/json" -d '{ "field1": "value1", "field2": "value2", "field3": 123 }'
curl -XPOST "http://localhost:9200/test-index/_search/point_in_time?keep_alive=1h"
And confirmed the new catch-all doesn't show up in the output of curl -XGET "localhost:9200/_nodes/stats/indices/search".
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/16750
Check List

[x] Functionality includes testing.
[x] API changes companion pull request created, if applicable.
[x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Flaky test: https://github.com/opensearch-project/OpenSearch/issues/14293

Flaky tests: https://github.com/opensearch-project/OpenSearch/issues/15829, https://github.com/opensearch-project/OpenSearch/issues/16015, https://github.com/opensearch-project/OpenSearch/issues/14311

Flaky test: https://github.com/opensearch-project/OpenSearch/issues/16576

Flaky test: https://github.com/opensearch-project/OpenSearch/issues/14296


🦺[Tech Debt]  Remove Cruft: Bcash

Describe the work to be done
Remove any references to the original fork (Breadwallet) where Bcash was used.  This was because Breadwallet was a BTC wallet and the BRD team were going to allow use of Bcash.
For us it causes confusion and problems maintaining the codebase.  It must be removed safely
Definition of Done

[ ] Open a working branch and let @kcw-grunt know
[ ] Identify S,M,L refactors
[ ] Branch off the working branch and write issues for the refactors.
[ ] Test with older and newer iOS devices and simulators

Think you are ready to submit? It can me in stages @JasperHeist

Please see my question in #57


fix: Add tsconfig on each template for eslint

On each template, actions were added into the exclude array of the tsconfig. This makes eslint to not know where the action folder is.
In order to fix this issue, we can simply add excludes on each tsconfig.eslint.json to override the base one.
How to test this? :mag:
The easiest way is to simply grab a project that is currently having the issue and then copy-paste the exclude given in this PR. After that, reload vscode and the error should be gone.

Please remove the ticket number from the branch name.


Image source not readable when uploaded through Media Manager (with AWS S3)

Version information

Laravel: v5.7
Voyager: v1.3.1
PHP: 7.0
Database: MySQL 5.7

Description
A clear and concise description of what the bug is:
My images are not showing on media manager when i upload them, I'm using AWS S3 and filesystem is pointing to to the correct storage).
After researching and going back and forth testing, i realized that my issue is related to the "media manager" not hashing the content that is being uploaded, because unlike BREAD, contents uploaded through BREAD are hashed (not sure if there are other attributes added to the files when they're uploaded) and hence they're accessible and read successfully (as seen below):

So since my issue is with the media manager, any advice on where i can enforce hashing? (assuming it could solve the problem) I'm not sure if this is a bug or does it need to be enabled/disabled.
I've been searching around half a days without any avail.
-Note: on my localhost, media uploaded (to S3) can be accessible, but when on production, contents uploaded are having 'access denied' (again, when i upload content through bread to S3, it is  accessible and can be read -name are hashed- as image above).. but i cannot do the same on media manager.
Steps To Reproduce
Added S3 requirements to filesystem, once success, deploy the site to production

in Production go to Media Manager and upload.
Once you upload it will show blank and wont be accessible (you can see the error):

Reminder, the images you that you can see are actually uploaded through BREAD.
I also tested uploading in root directory:

Clicking on the "Public URL" give me this:

Expected behavior
I expect that Media Manager to upload and view images just like BREAD.
Screenshots
Done.
Additional context
Reminder, on localhost this does not happen and i confirm that APP_URL is directed to the site i am hosting on..file system is set to s3 from env.
My Technical environment:
Windows 10 Pro
Wamp 3.1.8 64bit
Php 7.0
Thanks.

realized that my issue is related to the "media manager" not hashing the content that is being uploaded

Are you talking about random name generation?

Make sure filenames are all lowercase and don't contain spaces, that's the first thing I would check.


Support Webpack, don't use require.resolve()

Is your feature request related to a problem? Please describe.
Because of the use of the function require.resolve() in this code: https://github.com/opengovsg/pdf2md/blob/master/lib/util/pdf.js#L19 the use of pdf2md in my project results in errors in production builds at runtime. The project uses WebPack to bundle the code and that particular function cannot be used.
An explanation of the problem can be found in this Webpack issue: https://github.com/webpack/webpack/issues/13931
(It's basically because once a project has been bundled, asking a module for it's filename just doesn't make sense anymore)
Describe the solution you'd like
I'd like the code to either not use that method by using an alternative or provide some kind of option/flag that avoids its use.
Also, given the fact that this project is about converting a PDF file to Markdown, which is text-only, is providing font directories even useful? Would it perhaps be possible to do without?
Describe alternatives you've considered
The work-around mentioned in the Webpack issue fortunately works. It's a completely incidental fix that reduces runtime code efficiency, so I'd prefer not to use it.

If you are using Next.js, another workaround suggested in https://github.com/opengovsg/pdf2md/issues/69#issuecomment-1884786365 also works: in brief, specify @opendocsg/pdf2md and pdfjs-dist under experimental. serverComponentsExternalPackages in your Next config.

is providing font directories even useful? Would it perhaps be possible to do without?

I might be wrong, but pdfjs may be using the fonts to better recognise text within the PDF documents. I would be happy for you (or someone else) to see if removing the font directory would have any impact on the conversion process! If it doesn't, I'll gladly accept a PR.

If you are using Next.js, another workaround suggested in #69 (comment) also works: in brief, specify @opendocsg/pdf2md and pdfjs-dist under experimental.serverComponentsExternalPackages in your Next config.

Can confirm that this solution seems to work as well.

Please try this with v0.2.0 of this package, which removes the dependency on node-specific libs, including path.

@LoneRifle I haven't been able to take a good look at it, but this is the error I get by simply updating to the latest version and removing the work-around:
Failed to compile.

./node_modules/unpdf/dist/index.cjs
Module not found: Package path ./pdfjs is not exported from package C:\Projects\test\node_modules\unpdf (see exports field in C:\Projects\test\node_modules\unpdf\package.json)

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS>...

> Build failed because of webpack errors

If I re-add the work-around (the one where you add serverComponentsExternalPackages to the next.config.js file) it at least compiles. I haven't had time yet to test if it still works.

@LoneRifle Here is my test platform.
Desktop (please complete the following information):

OS: Window
Run browser: VSCode
Version: 1.96.0

Test pdf2md Version

"@opendocsg/pdf2md": "^0.2.1"

The result is that webpack successfully generates chunk files, and both test and deploy environments are all fixed now. But there is still a warning from the dependence unpdf that might have issues in another application:
WARNING in ./node_modules/unpdf/dist/pdfjs.mjs 1:1602511-1602533
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/unpdf/dist/index.cjs 40:35-56
<EMAIL_ADDRESS>1:47-63
<EMAIL_ADDRESS>1:18-39
 @ ./src/utils/fileOperations/readFile.ts 3:0-39 11:34-40
 @ ./src/utils/fileOperations/fileOperationsProvider.ts 6:0-38 51:15-23
 @ ./src/utils/fileOperations/index.ts 1:0-41 1:0-41
 @ ./src/utils/index.ts 1:0-33 1:0-33
 @ ./src/api/historyManager.ts 18:0-50 268:37-68
 @ ./src/api/index.ts 2:0-33 2:0-33
 @ ./src/extension.ts 3:0-172 11:28-55 12:31-45 24:18-31 32:8-22 34:9-31 35:9-31 36:4-28 36:51-65 37:4-16 38:4-23

1 warning has detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

Addition Context

line 40
I hope the information can help you out! Also, thank you a lot for your update on webpack!


GCE Support

We'd like to logically group related resources such as virtual networks, load balancers, dns zones, and virtual machines (VMs) to deploy, manage, and maintain them as a single group.
On Azure we used resource gorups
It look would be useful to spin up a GCP project per branch / commit.
See https://cloud.google.com/resource-manager/
Centrally Track & Manage Projects:

Programmatically create, manage, and delete projects that belong to your organization. You can also undelete or recover projects that you didn’t mean to delete. Access to Cloud Resource Manager project creation is currently invite-only. For an invitation, contact our sales team.

Reached out to GCE sales team to see if they can enable.


Infer type for int/float literals in binary expressions

Purpose

Infer the correct type for float/int literals in binary expressions

Fixes #13904
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Binary expressions support following
float f = 2.0 + 2;
decimal d = 2.0 + 2
float a = 3 + 5;

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@rpjayasekara, as discussed, let's create a new issue for what we are fixing here and link that in the PR.

@rpjayasekara can you please reword commit messages to be within 50 characters


Noticeably slow type inference, especially when using createTestClient and .extend

Describe the bug
I am creating a test client with both public and wallet actions and what I expect is type inference to be relatively fast. What actually is happening is that on my M2 Ultra Max it takes 2s or more to load the client's properties and function arguments. I'd like to clarify that this isn't just using createTestClient().extend(), there are noticeably slow types in other places such as the wallet client itself but it's bearable.
Originally a discussion but after creating a reproduction and seeing that it can take over 5s (in some cases 10s), I figured it's worth an issue.
Link to Minimal Reproducible Example
https://www.typescriptlang.org/play/?#code/JYWwDg9gTgLgBAbzgYygUwIYzQFTQZxgGEAbYNAOxgBo4ALGGMWsAVwCMzkBBZGYCBXy0A7hhIk0MXv0H44AXzgAzKBBBwA5ADdyITQG4AUKEixEKiKwoATKAE9FKtRp16A9MjoZgQw0aNkOXhkMkp4AF4UdCxcAmIwqgAKBCM4FG9fAC5Lazt7ajS4EAgbNBzNDApdEk1C9JgoKvwzGByGJiSASkKFLqKAOjQAD2xbJLZOYB4+ASF+9KHRyhsksQkpGTn8LuMjd3c4AGUYDHMYezBfAHM4AANQ8ioBu7gB97gqmzhGx1Z8G6fCiOZTWWaCOAiYAwOifKDXfADIxAA
Steps To Reproduce
Stackblitz reproduction (10s slow types): https://stackblitz.com/edit/stackblitz-starters-bdo9jm?file=index.ts
Package Version
^2.12.5
TypeScript Version
^5.4.5
Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?
No response

Unfortunately didn't realize this was the abitype repo, sorry moving to viem.


use let rather than var for es6 module grammar when target es6 and the module is commonjs

eg:
import * as url from "url";
let a = url.resolve("http://example.com/", "a");

Now the generated js is:
var url = require("url");
let a = url.resolve("http://example.com/", "a");

I think it is better:
let url = require("url");
let a = url.resolve("http://example.com/", "a");

Actually, the block scoping of let and the temporal dead zone effects would likely cause issues if that were used.  According to the ES6 spec imports actually behave more like this:
(function (url) {
    let a = url.resolve("http://example.com/", "a");
})(url);

I think technically rules against redeclaration do not apply, but considering the spec for the module loader is still churning away, my opinion is that changing semantics now would be premature.
What there a particular reason you felt it was better?

For ES6 js code, basically all variables are declared by let or const, eg a(above), but the url(above) is a var(is it a variable?), so use let or var may be a good idea.
So it's just a reason that it looks good.

thanks @plantain-00!


WinGet Configuration cannot install packages on ARM64

Brief description of your issue
I can use a configuration to install a package on ARM64
Steps to reproduce
Attempt to use Microsoft.WinGet.DSC to install a package in a WinGet configuration
Expected behavior
The package would be installed
Actual behavior
Loading the module for the configuration unit failed
Environment
WinGet 1.8-preview

We've released an updated version of the module with support for ARM64.


Allow navigation straight to Sign Up hosted UI page

Description of changes:
I added a method to go straight to the signup/create an account screen using the CognitoAuth object.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This would be a really helpful feature for my project!


Exit Error Code on any error or warning.

Please implement a feature that would throw an error code on exit if ANY error/warning happens.
At the moment at least the "can't parse line" error/warning doesn't affect exit code.
If it's out of the question to make this a default behavior, then please implement this some other way. For example, a new option called --strict?
It would be nice to have this for detecting any errors with scripts (e.g. with [[ "$?" != "0" ]]).
Thank you!
(I wish that Linux Mint repo would pick up new RHash versions faster.. I'm new to linux and still learning how to get updated software)

For now I reject the feature in the form "throw an error code on exit if ANY error/warning", because it will take a lot of time to check all cases, and there are tasks with much higher priority. Please report errors/warnings with zero exit code, other than "can't parse line", to handle them separately. Note, that all i/o errors already cause a non-zero exit code.
According to the "can't parse line" case, I agree, that this behavior should be changed to return a non-zero exit code. I think also some additional warning "Some lines could not be parsed" must be displayed at the end of a hash verification log. If the log file is very big or error is scrolled away, then the user should have an easy way to find the reason of the fail.
To simplify translators work and since broken hash files are pretty rare, the current error-reporting line "Errors Occurred: Errors:%-3u Miss:%-3u Success:%-3u Total:%-3u" should be left unchanged. So the additional warning on an unparsed lines should be displayed on a separate line.

For now I reject the feature in the form "throw an error code on exit if ANY error/warning", because it will take a lot of time to check all cases, and there are tasks with much higher priority. Please report errors/warnings with zero exit code, other than "can't parse line", to handle them separately. Note, that all i/o errors already cause a non-zero exit code.
According to the "can't parse line" case, I agree, that this behavior should be changed to return a non-zero exit code. I think also some additional warning "Some lines could not be parsed" must be displayed at the end of a hash verification log. If the log file is very big or error is scrolled away, then the user should have an easy way to find the reason of the fail.
To simplify translators work and since broken hash files are pretty rare, the current error-reporting line "Errors Occurred: Errors:%-3u Miss:%-3u Success:%-3u Total:%-3u" should be left unchanged. So the additional warning on an unparsed lines should be displayed on a separate line.

After some thought, I've end up with more simple solution. Now parsing errors are counted in statistics as "Errors", and thus affect the program exit code.
echo "abcd" | rhash -c -

--( Verifying (stdin) )---------------------------------------------------------
(stdin):1: can't parse line "abcd"
--------------------------------------------------------------------------------
Errors Occurred: Errors:1   Miss:0   Success:0   Total:1

IMO, adding a separate warning on unparsed lines could complicate parsing of RHash output by scripts or other software.
The feature is implemented as part of the 9105d546ea636b994337b71c976e1606306b1989 commit.


Cannot create azure service principal and assign permissions

Related command
az ad sp create-for-rbac -n test --role owner --scopes /subscription/<sub id>

Describe the bug
This same command worked a month or so ago, but it doesn't anymore, and nothing has changed about my permissions. In fact I've tried this same command in several subscriptions and tenants where I'm owner & global admin.
To Reproduce
Paste command into azure CLI and replace w/ own sub info
Expected behavior
Create an azure service principal with owner permissions to the subscription
Environment summary
Azure portal built-in CLI
Additional context
Error info:
Creating 'owner' role assignment under scope '/subscription/<sub id>
  Role assignment creation failed.

  role assignment response headers: {'Cache-Control': 'no-cache', 'Pragma': 'no-cache', 'Content-Type': 'application/json; charset=utf-8', 'Expires': '-1', 'x-ms-failure-cause': 'gateway', 'x-ms-request-id': 'xxxx2af47', 'x-ms-correlation-request-id': 'xxxx22af47', 'x-ms-routing-request-id': 'EASTUS:20230104T175742Z:xxxx22af47', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains', 'X-Content-Type-Options': 'nosniff', 'Date': 'Wed, 04 Jan 2023 17:57:41 GMT', 'Content-Length': '135'}

The request did not have a subscription or a valid tenant level resource provider.

I confirm that it creates the service principal and secret, but it does not add the role to the subscription (and I can't seem to add it manually either).

@jiasli for awareness

Wait, I can repro with your command. It seems you misspelled --scope as /subscription/<sub id>. Instead, there should be an s following subscription - /subscriptions/<sub id>.

That's how I initially had it written, and it was failing with that too. But, it is working today. Probably user error on my part. Thanks!


moving missed SMTP file to the SMTP section

I missed this file in the original SMTP docs reorg

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


move mypy.ini and pytest.ini to setup.cfg

Reduces the number of files in the root of the repo.

I have not been following the development of this part of the packaging that closely but are things not supposed to mov to pyproject.toml eventually?

latest i know (been questing this qute recently) is that setup.cfg should be used only for super simple/trivial declarations. everything is indeed moving to toml, pytest since version 6 supports is completely. mypy still doesn't support toml properly so with that we should wait (or merge it into setup.cfg for now).

on the other hand, if this just works, then it's fine. at later point we'll just migrate from single file setup.cfg to pyproject.toml and that's it


Update nf-winuser-get_rawinput_code_wparam.md

This macro returns RIM_INPUT/RIM_INPUTSINK not receiving.

@DJm00n : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Redirect users with 0 balance to Profile page

@kcole16 @vgrichina
It's working as described in the issue, so if an account was found but adding key fails due to not enough balance, the user will be redirected to /profile page.
If there will be multiple accounts for seed phrase and at least one account will successfully add a key, the user will be logged in to that account. If all accounts fail, the user will be redirected to the profile.
I think that if a few multiple accounts are found we should show some kind of summary page, where all accounts will be listed with success or error information, and the user should be able to:

see what went wrong with which account
choose on which account he wants to be logged in.

At this moment it will be confusing to the user if anything but success happens, and even on the success he still might be logged into a different account than would like to use.
I think it would be a nice upgrade but for sure nothing urgent.

@kcole16 @vgrichina
Accounts and phrases for tests:
light local edit glory basic chuckle like beauty science guard force system
 - marcinh20.testnet - `LackBalanceForState` error
 - marcinh21.testnet - success
 - marcinh22.testnet - success

fade brother canvas sugar tone key sight enjoy soccer foot soda betray
 - marcinh30.testnet - `LackBalanceForState` error
 - marcinh31.testnet - `LackBalanceForState` error


chore: Remove unused fields from Event class

Describe the chore
Currently, a lot of fields are unused in the Event class. This is undesirable for multiple reasons:

The unused fields still occupy space in the database which slows down SQLite and increases the amount of storage used.
Each Event object has a bigger size. Performing multiple operations on a list of these Events wastes memory.
The extra fields make the Event class difficult to analyze. The class is currently too big.

Removing unused fields will not break anything but will make the code-base more pleasant to work with.
Would you like to work on the issue?

[x] Yes
[ ] No

@iamareebjamal @liveHarshit what do you think about this issue? I want to take your opinion.

No they shouldn't be removed since they may be used in future. We don't want to create frequent migrations in db for adding fields

App is in heavy development and this topic will be part of the usual dev process. Therefore closing it.


File explorer

It will directly work on s3 backend

[X] mock
[X] Folders bar
[x] Icons by file type
[x] Fill container

Ready for MVP


1.21.0 having install_bsd_arm is causing errors with install_bsd_arm: command not found

Previous go-build files such as https://github.com/go-nv/goenv/blob/master/plugins/go-build/share/go-build/1.20.7 do not have links for install_bsd_arm so my build hasn't run into this build error before.
But since https://github.com/go-nv/goenv/blob/master/plugins/go-build/share/go-build/1.21.0, these lines:
install_bsd_arm "Go Freebsd arm 1.21.0" "go1.21.0.freebsd-arm64.tar.gz#bca5be1a9934fc522cb1a2e4849bb9f12ee6b480b48949e36a4dfb8e755a4b25"
install_bsd_arm "Go Freebsd arm 1.21.0" "go1.21.0.freebsd-arm.tar.gz#f4c9c91fa9c37d6d6b7644f3f6b67167b2a44bd48c0cba1d2a5ff5fd50ceb364"

... are causing my build to fail with this error:
[Container] 2023/08/09 15:53:30 Running command echo $PATH
40 | /root/.goenv/shims:/root/.goenv/bin:/go/bin:/go/bin:/usr/local/go/bin:/usr/local/bin/sbt/bin:/root/.phpenv/shims:/root/.phpenv/bin:/root/.pyenv/shims:/root/.pyenv/bin:/root/.rbenv/shims:/usr/local/rbenv/bin:/usr/local/rbenv/shims:/root/.dotnet/:/root/.dotnet/tools/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/codebuild/user/bin

[Container] 2023/08/09 15:53:31 Running command goenv install -s ${TARGET_GOENV_VERSION}
46 | /root/.goenv/plugins/go-build/share/go-build/1.21.0: line 9: install_bsd_arm: command not found
47 |
48 | BUILD FAILED (Amazon Linux 2023 using go-build 2.1.3)

I included the $PATH in case it may help with debugging. Would anyone have an idea what's going on?

Resolved in #339

@nguyengg @ugol please verify

Can confirm that fixed it for me!
[Container] 2023/08/09 17:16:40 Running command goenv install -l \| grep ${TARGET_GOENV_VERSION} \|\| cp ${CODEBUILD_SRC_DIR}/.goenv/${TARGET_GOENV_VERSION} ${HOME}/.goenv/plugins/go-build/share/go-build/${TARGET_GOENV_VERSION}
40 | 1.21.0
41 |
42 | [Container] 2023/08/09 17:16:41 Running command goenv install -s ${TARGET_GOENV_VERSION}
43 | Downloading go1.21.0.linux-arm64.tar.gz...
44 | -> go1.21.0.linux-arm64.tar.gz

Thanks for the quick turnaround!

Can confirm that fixed it for me!
[Container] 2023/08/09 17:16:40 Running command goenv install -l \| grep ${TARGET_GOENV_VERSION} \|\| cp ${CODEBUILD_SRC_DIR}/.goenv/${TARGET_GOENV_VERSION} ${HOME}/.goenv/plugins/go-build/share/go-build/${TARGET_GOENV_VERSION}
40 | 1.21.0
41 |
42 | [Container] 2023/08/09 17:16:41 Running command goenv install -s ${TARGET_GOENV_VERSION}
43 | Downloading go1.21.0.linux-arm64.tar.gz...
44 | -> go1.21.0.linux-arm64.tar.gz

Thanks for the quick turnaround!

No problem. Glad I could help

Sidenote: if you're using AWS CodeBuild images (or any images) that cache goenv repo, you may still run into that problem until the image is updated. I was using an aarch64 image for which I had to manually check out goenv so the latest commit is always pulled.

Sidenote: if you're using AWS CodeBuild images (or any images) that cache goenv repo, you may still run into that problem until the image is updated. I was using an aarch64 image for which I had to manually check out goenv so the latest commit is always pulled.

See https://github.com/go-nv/goenv#aws-codebuild. I documented buildspec steps so you can pull the latest goenv in your prebuild phase.

I had something similar with:
      # AWS CodeBuild Docker image for aarch64 doesn't install goenv so we must install it.
      # Additionally, image for amd64 may hav outdated goenv as well so we should update it.
      - |
        if [[ ! -d "$HOME/.goenv" ]] ; then
          git clone --depth 1 https://github.com/syndbg/goenv.git $HOME/.goenv
          PATH="/root/.goenv/shims:/root/.goenv/bin:/go/bin:$PATH"
          GOENV_DISABLE_GOPATH=1
        else
          git -C "$HOME/.goenv" pull --rebase
        fi

Just wanted to leave a note in case others found this issue and thought it still unresolved because of outdated goenv.


Mnist assets

Implementation of an example on MNIST based on the titanic example

@bowni & @chrisalexandrepena you might be interested in this implementation!


fix(region): translation errors

What this PR does / why we need it:

[x] Smoke testing completed
[ ] Unit test written

If yes, write the release branches name in the below format and submit the related cherry-pick PR:

release/3.7

/area region
/cc @zexi

Codecov Report

Merging #11228 (314d664) into master (39e5d51) will increase coverage by 5.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #11228       +/-   ##
===========================================
+ Coverage    5.80%   11.15%    +5.35%
===========================================
  Files         901      147      -754
  Lines      139239    16972   -122267
===========================================
- Hits         8088     1894     -6194
+ Misses     130444    14885   -115559
+ Partials      707      193      -514

Flag
Coverage Δ

aFlag
11.15% <ø> (+5.35%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/util/nopanic/nopanic.go

pkg/multicloud/ecloud/monitor.go

pkg/compute/models/loadbalancerclusterresource.go

pkg/multicloud/ucloud/project.go

pkg/multicloud/aws/iam_policy.go

pkg/mcclient/options/networkaddress.go

pkg/apigateway/clientman/totp.go

pkg/util/seclib2/passwd.go

pkg/compute/models/loadbalancerlistenerresource.go

pkg/baremetal/manager.go

... and 744 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e5d51...314d664. Read the comment docs.


Does anyone want Query Pretty Printing?

Does anyone want a compile-time option -Dquill.prettyprint in order to format the queries that come out of the compile time-generation. It's pretty easy to do?
Alternatively Query.translate could have an option to pretty print. Is anyone interested in that?
@getquill/maintainers

we recently encountered some extremely poorly performing queries. turned out that quill was generating horrible sql, we ended up having to burn a day figuring that out and then tweaking the quill code until it generated a query with a much more reasonable execution plan.
it is absolutely critical that the sql that quill generates (at compile-time) can be printed (at compile-time) (or better yet, written to files) so that we can track changes in Git and submit the generated SQL to code review.
At this point the entire firm is considering dropping quill based on this feature alone.
What an unwieldy code-generation tool this is, so arrogant that it doesn't think it should have to expose its output to its users (other than noisy IDE warnings)!

You can enable logging into a local file by passing -Dquill.log.file=queries.txt to your SBT settings via the command-line or via a .sbtopts file. When using intellij you add it to preferences -> sbt -> VM Parameters:
https://youtu.be/L-P5Cx3DduE?t=4310
We've had this feature for a while, I'm sorry for not documenting it. Will do ASAP.
Also, I am sorry that you are experiencing frustration in your project because of Quill. It is certainly not my intention that people experience frustration and angst on my behalf. If you feel that Quill does not meet your needs you are welcome to drop it in favor of something else. As is the case with most open source libraries, Quill is maintained by volunteers and what can be done in a person's spare-time is inherently limited.

Note, this capability was introduced here:
https://github.com/zio/zio-quill/pull/2292

hmm so it seems like I clearly mispoke 😅  thanks for taking the time to answer though
is it possible to have this file be generated to a location outside of /target? I would probably want to commit it to the repo and pass it through a formatter before committing it


No errors ouptutted in the node API when there are type errors, compilation doesn't fail

I'm trying to use this plugin with thread-loader as described in this example, but running it from node instead of the cli, it appears to totally ignore the type checking errors.
Here is how I'm using it, I'm using webpack4:
const compiler = webpack(config)
compiler.hooks.done.tap('done', stats => {
  console.log(stats.hasErrors()) // --> false
})

const devServer = new WebpackDevServer(compiler, devServerConfig)

these are the type errors printed by the fork-ts-checker-webpack-plugin plugin:

There are no errors in the browser and the code is transpiled normally.

Maybe look at this example for reference? https://github.com/TypeStrong/ts-loader/tree/master/examples/thread-loader

Yes that's the example I pointed out, forgot to link it sorry 😄

So you're good now?

Nope, if running that example using webpack's node api, there are no errors in dev mode

Have you tried using the async: false option? The plugin normally bypasses webpack for speed of reporting. This option makes it use webpack

Happy to help! If you think you can improve the docs then have a go. Every little helps!


Disabling timestamps in MS Teams attendance report

[Enter feedback here]
Hi to all,
Is there a way to enable attendance report but without timestamps (When someone joined or left the session)?
For above-mentioned reason in our company workers council don't want to allow this feature to be enabled because it can be used for people benchmarking and they say this is against GDPR and German data privacy laws.
THXiA
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a8b1087-ae40-6813-16bc-a69c90e50d19
Version Independent ID: b808e843-80d8-4a96-c6ed-e8175968eb73
Content: Microsoft Teams meeting attendance report - Microsoft Teams
Content Source: Teams/teams-analytics-and-reports/meeting-attendance-report.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

@Dacha77 Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Upgraded dependencies for groupId com.google.firebase

Dependencies upgrades
com.google.firebase:firebase-admin

Version: 7.0.1 -> 7.1.0
Size: 959.33 KB
Releases notes | Documentation | Issue tracker

This pull request was automatically generated by Releases Hub Gradle Plugin v1.6.1

com.google.firebase:firebase-admin

Version: 7.1.0 -> 7.1.1
Size: 959.32 KB
Release Date: Mar 10 2021
Releases notes | Documentation | Issue tracker

com.google.firebase:firebase-admin

Version: 7.1.1 -> 7.2.0
Size: 963.2 KB
Release Date: Apr 28 2021
Releases notes | Documentation | Issue tracker

com.google.firebase:firebase-admin

Version: 7.2.0 -> 7.3.0
Size: 964.32 KB
Release Date: May 12 2021
Releases notes | Documentation | Issue tracker

com.google.firebase:firebase-admin

Version: 7.3.0 -> 8.0.0
Size: 967.09 KB
Release Date: Jun 30 2021
Releases notes | Documentation | Issue tracker

com.google.firebase:firebase-admin

Version: 8.0.0 -> 8.0.1
Size: 967.2 KB
Release Date: Aug 13 2021
Releases notes | Documentation | Issue tracker


Icons({ autoInstall: true }) not Working in Nuxt 3 Layer

Describe the bug
I'm encountering an issue with unplugin-icons in my Nuxt 3 project. When I set Icons({ autoInstall: true }), it doesn't work as expected. Instead, I receive the following error:
Failed to resolve component: Fa6RegularCircleStop
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

import AutoImport from 'unplugin-auto-import/vite'
import Components from 'unplugin-vue-components/vite'
import Icons from 'unplugin-icons/vite'
import { NaiveUiResolver } from 'unplugin-vue-components/resolvers'
import IconsResolver from 'unplugin-icons/resolver'
import { localPath } from './utils'

export default defineNuxtConfig({
  build: {
    transpile: [
      '@juggle/resize-observer',
      ...(process.env.NODE_ENV === 'production' ? [
        'naive-ui',
        'vueuc',
        '@css-render/vue3-ssr',
        '@hapi',
        '@sideway'
      ] : [])
    ]
  },
  devtools: { enabled: true },
  modules: ['@nuxtjs/tailwindcss', 'nuxtjs-naive-ui', 'unplugin-icons/nuxt'],
  vite: {
    optimizeDeps: {
      include: process.env.NODE_ENV === 'development' ? [
        localPath('./node_modules/naive-ui'),
        localPath('./node_modules/vueuc')
      ] : [],
    },
    ssr: {
      noExternal: ['naive-ui']
    },
    plugins: [
      AutoImport({ imports: [{ 'naive-ui': ['useDialog', 'useMessage', 'useNotification', 'useLoadingBar'] }] }),
      Components({ resolvers: [NaiveUiResolver(), IconsResolver()] }),
      Icons({ autoInstall: true })
    ]
  },
  tailwindcss: {
    cssPath: ['./assets/tailwind.css', { injectPosition: 'first' }],
    exposeConfig: { level: 4, alias: '#tw' }
  },
})

Reproduction
https://github.com/NisuSan/base-nuxt-layer
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (8) x64 Intel(R) Core(TM) i3-10100 CPU @ 3.60GHz
    Memory: 5.88 GB / 15.90 GB
  Binaries:
    Node: 22.3.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.9.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.7.0 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Chromium (130.0.2849.46)
    Internet Explorer: 11.0.22621.3527

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Prefix the component: <IFa6RegularCircleStop/>

@userquin it's worked, thanks! I think it should be mention in docs, so I can start a PR with docs update


Using SolidJS ref for custom component

I created a TextInput component based on the Playground's TextInput.
My TextInput component needs to reference an internal input tag it is composed of using  SolidJS's ref attribute.  I see <Field passes props to my custom component including a 'ref' property which I in-turn pass to my internal input tag.  How do I avoid my component overriding the <Field prop's  'ref'?
Should my TextInput component use the internal input tag's id attribute to access it instead of using SolidJS's ref?
Note that it does seem to work even though Typescript is giving me the warning.  Is it just Typescript complaining for nothing?
I get the warning:
"Type 'null' is not assignable to type 'HTMLInputElement | ((el: HTMLInputElement) => void) | undefined'"
or
"'ref' is specified more than once, so this usage will be overwritten."
depending on if I place the ref attribute before or after the {...props}

UPDATE: I fixed this by using this type
ref?:(element: HTMLInputElement) => void;

More details:
It appears that using a native  element inside of a <Field does not work either so my custom element is unrelated to my issue.
Modularforms uses ref as a callback function to run before elements are attached to the DOM, and I need to use ref to access the element after it has been attached to the DOM.  Does solidJS have a way to use ref as both a reference to the element and a callback before render?

Can you send me the code of your component?

I used the TextInput from the playground, and then just a plain <input inside the <Field element so no custom component at all.  Typescript shows a warning on <input ref={myRef} since Modularform is passing ref as '(element: HTMLInputElement) => void'  Those 2 types are not compatible.

You can pass a custom function to ref:
<input ref={(element) => {
   // Your signal
  setRef(element);
  // Our ref function
  props.ref(element);
}} />

Ok great, that solves it.


Fix duplicate split created on edit pay (JB-200)

Fixes JB-200 (https://linear.app/peel/issue/JB-200/duplicate-field-when-adding-new-token-beneficiary-in-create-flow)

@wraeth-eth lmk what you think of this. Would be great to give a good test if possible to make sure I haven't broken anything else 🙏


Error around the DECIMAL type in Presto

No numeric types to aggregate
Traceback (most recent call last):
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/viz.py", line 277, in get_payload
    data = self.get_data(df)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/viz.py", line 1035, in get_data
    df = self.process_data(df)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/viz.py", line 971, in process_data
    values=fd.get('metrics'))
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/reshape/pivot.py", line 136, in pivot_table
    agged = grouped.agg(aggfunc)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/groupby.py", line 4036, in aggregate
    return super(DataFrameGroupBy, self).aggregate(arg, *args, **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/groupby.py", line 3468, in aggregate
    result, how = self._aggregate(arg, _level=_level, *args, **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/base.py", line 435, in _aggregate
    **kwargs), None
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/base.py", line 391, in _try_aggregate_string_function
    return f(*args, **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/groupby.py", line 1037, in mean
    return self._cython_agg_general('mean', **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/groupby.py", line 3354, in _cython_agg_general
    how, alt=alt, numeric_only=numeric_only)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/pandas/core/groupby.py", line 3425, in _cython_agg_blocks
    raise DataError('No numeric types to aggregate')
pandas.core.base.DataError: No numeric types to aggregate

When you filed this issue, do you know/remember if pandas was reading your raw data in as VARCHAR? I ran into this issue again, though I worked around it by casting my desired metric to INTEGER/DOUBLE.
Does it make sense to try to cast on the pandas side (in addition to the underlying query)?

Pretty sure this has been tackled by now. Closing. Let's reopen with more details if this message comes back up.


Update gcloud-java version in samples

/cc @shun-fan
Also I was looking for some docs on how to run the managed_vms/datastore sample; do you think that should have a readme on how to run it?

Coverage remained the same at 21.157% when pulling 824022d4d0ec77e581ad0adab444b7e71bba2871 on update-gcloud-version into c4439f61b23b9e46596b212028cad6340b593d65 on master.

Thanks! This fixes https://github.com/GoogleCloudPlatform/java-docs-samples/issues/150.


Extra Stage, OMES

 Issue by RhythmLunatic
Tuesday Feb 05, 2019 at 17:05 GMT
Originally opened as https://github.com/raveitoutofficial/raveitout/issues/18

It is done!


Init bearer token based authentication

This suggests to integrate the keycloak-js adapter for (bearer token based) authentication.
Due to this change the client is now capable to authenticate with a bearer token against the resource server (SHOGun, GeoServer and Print), this requires PR 531 to be merged.
In addition the UserMenu is added containing the ApplicationInfo, logout and user account management entries.
Please review @terrestris/devs.

Very nice and the switch to tokens looks really useful!
Did you add the Mapfish-Print serializers because direct authentication is now possible? At the first glance, these changes looked unrelated to authentication.


got shibe API to fetch one link and log it into console

Conflicting issues with js file, might need to git pull the current repo before submitting your pull request


[Suggestion]: Support for other mod's soul blocks

Mod Loader (Optional)
Forge
Minecraft Version(s) (Optional)
1.20.1
Mod Version(s) (Optional)
v8.1.5
Suggestion (Required)
here's a list of cosmetic soul fire blocks i've encountered in my personal modpack that would make sense as blue air providers:
decorative_blocks:soul_chandelier
decorative_blocks:soul_brazier
supplementaries:sconce_soul
forbidden_arcanus:deorum_soul_lantern

i'm not sure if this is something the mod should handle or their mods should handle or that i can do with a data pack, but would it be possible to add support for these?

maybe include the is_pignin_repellent tag which already includes all sound based fire blocks such as those


Clean up code, remove unused functionality

No significant changes, just getting the repo into a better state before continuing development.

Remove all mirroring functionality
Change references to mirroring to verifier
Move client functions, add tests
Clean up Makefile
Update golangci-lint
Update sigstore version

Fixes #45

Summary

Release Note

Documentation

Updated to Go 1.20, thanks!

@haydentherapper need rebase

Done @cpanato


plugin should sugar out array syntax

It appears this plugin breaks when styled components is used exploded to provide dynamic styles decorators to a component:
const Comp = styled.div`${func1}${func2}`; // This gets desugared (but cannot be dynamic)

const funcs = [func1, func2]
const Comp = styled.div([], ...funcs); // This does not get de-sugared

This means that some libs break as they have to provide dynamic decorator functions to sc.
Can this be fixed or can you suggest a work around that libs such as https://github.com/jxnblk/styled-system/tree/master/system-components can do to fix this?

const Comp = styled.div([...funcs.map(_ => ""), ""], funcs)
On Tue, Mar 20, 2018, 3:23 AM Rudi Yardley<EMAIL_ADDRESS>wrote:

It appears this plugin breaks when styled components is used exploded to
provide dynamic styles decorators to a component:
const Comp = styled.div${func1}${func2}; // This gets desugared (but cannot be dynamic)
const funcs = [func1, func2]const Comp = styled.div([], ...funcs); // This does not get de-sugared
This means that libs like system-components within styled-system break as
they have to provide dynamic decorator functions to sc.
Can this be fixed or can you suggest a work around that libs such as
https://github.com/jxnblk/styled-system/tree/master/system-components can
do to fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/babel-plugin-styled-components/issues/133,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlhVePlVlJWh8cNGyO7EBEfM6YsCuks5tgGgagaJpZM4SxMfc
.

@ryardley I'm not sure where you're going with this as this seems to be a problem with your transpilation setup possibly?
We do have some basic transpilation of our tagged template literals, but if you're seeing the above, you might not have the plugin perform its tasks before your other babel presets / plugins https://github.com/styled-components/babel-plugin-styled-components/blob/master/src/visitors/templateLiterals/transpile.js

@wmertens tried that and it isn’t picked up. The issue is that all calls to styled.div should be transpiled to include the configuration but they are not.

@kitten have a look at this repository i used to post the same bug to styled-system. They may be able to work out a way to mitigate it by providing the configuration themselves however the real problem is with this plugin: https://github.com/ryardley/isomorphic-bug-in-system-components


omni_turtlesim: 2.0.0-1 in 'dashing/distribution.yaml' [bloom]

Increasing version of package(s) in repository omni_turtlesim to 2.0.0-1:

upstream repository: https://github.com/Tiryoh/omni_turtlesim_ros2.git
release repository: https://github.com/Tiryoh/omni_turtlesim_ros2-release.git
distro file: dashing/distribution.yaml
bloom version: 0.9.7
previous version for package: null

omni_turtlesim
* docs: Update CI badge
* chore: Specify the license
* feat: Update package description
* docs: Add usage in README
* fix: Rename package name in launch
* ci: Limit target branch
* docs: Update status badge
* ci: Add industrial_ci test settings (#2 <https://github.com/Tiryoh/omni_turtlesim_ros2/issues/2>)
* docs: Add README (#1 <https://github.com/Tiryoh/omni_turtlesim_ros2/issues/1>)
* feat: Add omni control
* feat: Rename package
* Contributors: Daisuke Sato, Tiryoh

Holding until the pending dashing sync.Holding until the pending dashing sync.

@nuclearsandwich Thank you for your responding.
Closing this PR, due to discussion in https://github.com/ros/rosdistro/pull/25854.
I'll open a PR in ros/ros_tutorials.


tensor2tensor install: what is the suitable tensorflow-gpu version for tensor2tensor 1.15.4?

Description
i want to install tensor2tensor using
pip install tensor2tensor[tensorflow_gpu]

but got :
WARNING: tensor2tensor 1.15.4 does not provide the extra 'tensorflow_gpu'

is there a suitable tensorflow-gpu version for tensor2tensor 1.15.4?

I'm using tensorflow-gpu:1.15.0 and it works.

@jh-hello this setting works,  thank you for your reply !


S3 custom endpoint is DNS based and is not resolvable

When using custom endpoint for S3, etcd-backup-operator is accessing the buckets with DNS based URL. For example:
If endpoint = http://s3-minio:9000/  and bucket = test then the resulting URL for accessing the bucket is formed as http://test.s3-minio:9000.
DNS resolution fails for this URL as it does not exist.
EtcdBackup spec I used:
apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdBackup"
metadata:
  name: example-etcd-cluster-backup
spec:
  etcdEndpoints: ["http://test-etcd-cluster-client:2379"]
  storageType: S3
  s3:
    path: test/backup
    awsSecret: minio
    endpoint: http://s3-minio:9000/

I went through the issues and pull requests related to S3 custom endpoint and couldn't find a way to configure etcd-backup-operator to use path based S3 bucket URL like http://s3-minio:9000/test.
Is there a way to force etcd-backup-operator to use path-based URL?

Seems like this is an issue in the current version 0.9.2. In version 0.8.3 there is no error.

Seems like this is an issue in the current version 0.9.2. In version 0.8.3 there is no error.

Running into this using vault-operator 0.1.1 with etcd-operator 0.8.0

I think that https://github.com/coreos/etcd-operator/pull/1935 effectively upgraded the aws api from v1.10.9 to v1.13.8

@domcar I've put up a PR that fixes this and have some time to address comments but repo owners appear to be busy elsewhere.

@domcar I've put up a PR that fixes this and have some time to address comments but repo owners appear to be busy elsewhere.

Please see https://github.com/coreos/etcd-operator/issues/2007
/cc @domcar @fdlk

@hexfusion @domcar @fdlk
If this is an option for you, with Minio it is possible to support DNS-style naming as well as path-based.  I implemented this on a host filestore.example.org using a Let's Encrypt wildcard certificate (*.filestore.example.org), a wildcard DNS entry (*.filestore.example.org) and defined MINIO_DOMAIN=filestore.example.org in the runtime environment.

Fixed in #1774

@hexfusion @domcar @fdlk
If this is an option for you, with Minio it is possible to support DNS-style naming as well as path-based. I implemented this on a host filestore.example.org using a Let's Encrypt wildcard certificate (.filestore.example.org), a wildcard DNS entry (.filestore.example.org) and defined MINIO_DOMAIN=filestore.example.org in the runtime environment.

  [default]   region=us-east-1   s3=     addressing_style = path
It is an option of AWS client in config file.
So yes this should honor this option and it seems to not to do it.


The sfc files packaged by rollup only work above 3.2.0

Version
3.2.6
Reproduction link
https://github.com/ckpack/v-ui-template#use-in-page
Steps to reproduce
<!DOCTYPE html>

  <title>VUI</title>

What is expected?
The  sfc files packaged by rollup can work above 3.0.0
What is actually happening?
The  sfc files packaged by rollup only work above 3.2.0

This is expected and has been discussed already: SFC compiled with 3.2.x are compatible with ^3.2x (3.2, 3.3, 3.4, etc). Use peerdependencies to make the minimum required version to be ^3.2.0
It would be otherwise impossible to bring improvements to templates (and sometimes even some bug fixes)


Add notebook example with H2 database for JDBC-integration functionality

Closed and moved for a while in an external repository


Java ME SDK

Hi! I'm working a project that connect to aws iot over Embedded Java J2ME. Did you a plan for release SDK for Java Me?

Hi @bsayiner ,
Unfortunately we do not support Embedded Java J2ME right now and I cannot share the details about future plans for SDK releases. We are always collecting inputs from customers and trying to make the device SDKs better. Please stay tuned.
Thanks,
Liusu


More complete stop words (from Veronis)

See http://clu.uni.no/corpora/1999-1/0042.html and http://voyant-tools.org/tool/Cirrus/ for the reference to Veronis source of stop words.
I'm not entirely sure about how StopWords.java will treat the apostrophes in the words, or if I should have forked the vcl-xx source to make the change there.

Most of those do not look like stop words to me. Numbers?

Some are numbers (spelled out), some are common abbreviations, some are (subjunctive, passé simple) tenses of helping verbs, some are conjunctions, some are common units, etc. The list comes from a linguistics professor in France, so I'm willing to give it the benefit of the doubt. http://clu.uni.no/corpora/1999-1/0042.html
I realize there are some words with underscores, which will not match (based on the code I saw in java), so maybe they should be skipped. I think the goal there was something like if you had the expression "matter of fact" appearing in English, the whole thing would be removed as a "stop phrase" (something that's commonly written or said, but that shouldn't be parsed for a word cloud.

Only individual words are considered during stop-word removal. Underscores will never match.

It's two lines which already have individual entries:
plus_d'un
plus_d'une
Do you want to reject and I re-patch, removing those two? (sorry, I'm not so smooth with the PR process on GitHub).


Discovery monitor form improvements

Closes PROD-2198
Description Of Changes
Tweaks behavior of discovery monitor form:

Adds "not scheduled" option to frequency field
Disables execution start date field if frequency is not selected
Switches order of frequency and start date fields

Code Changes

[ ] Changes to form behavior
[ ] Remove deprecated ConfigureIntegrationForm component

Steps to Confirm

[ ] Configure an integration with valid credentials from the new integrations menu
[ ] Add a discovery monitor to that integration, then save changes
[ ] Edit that monitor, then save changes

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
[ ] Issue Requirements are Met
[ ] Update CHANGELOG.md

Found a minor issue on my local testing. Steps to repro:

Configure an integration with valid credentials from the new integrations menu. I used BigQuery
Add a discovery monitor to that integration, specifically setting weekly frequency. Note the Automatic execution start time field is populated with a date / time.
Save changes
Edit that monitor, see that the Automatic execution start time field is NOT populated with a date / time.

Is this expected?

@eastandwestwind Thanks for catching that-- got it fixed and added a check in the editing monitor test to verify.


Link to deployment guide in README is incorrect

Thank you for reporting this. We have implemented a fix for this issue.


Added ability to embed Vimeo videos

Added ability to embed Vimeo videos
Code changes

Renamed YoutubeVideo[xxx] files, classes and comments to Video[xxx]
Added tests for vimeo urls
Added a new REGEX_VIDEO_URL that checks either youtube or vimeo url formats.
Added a condition to VideoHelper.GetVideoId to get youtube ids separately to vimeo.
Added GetVideoEmbedFormat to VideoHelper and replaced the explicit mention of youtube's embed url in the VideoWidget View.

Motivation
This is adding the ability for the Video widget to render Vimeo videos rather than just Youtube videos.
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[ ] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
Add a youtube video to the sandbox project, then add a vimeo video to the project. Both should render.

Hi @OndraM-Kentico, anything else needed here or are you happy to merge?

I've just been waiting for approval of the Product owner and in the meantime I've done little refactoring and pushed it into your repo. We can merge it altogether in one PR.


Remove leaderboards (Issue #163)

Hello!
This commit remove leaderboards as described in #163.
As far as I see, Point (related repository, calculator etc.) is used only for leaderboards. Should this functionality be deleted as well?

hey! thanks for pr. We need to remove point model to, yes :)

Done :)


NIFI-8041: Refactored API for stateless nifi so that calling Stateles…

…sDataflow.trigger() returns an object that allows the caller to wait for the result, cancel the result, etc. and then optionally acknowledge the completion. This allows the caller to block the completion of ProcessSession.commit() until it has handled the output of the dataflow execution.
NIFI-8038: Fixed deadlock that can occur when updating Parameter Context
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Re-ran same test flows from previous testing of stateless and everything looks good, new API makes sense, going to merge, thanks!


Crash when opening infuser GUI

https://paste.dimdev.org/dusegazumu.mccrash

https://paste.dimdev.org/xutulakizu.mccrash

Should be fixed now.


Documentation out of date / confusing

Going through docs, I ran into the following:

http://router5.github.io/docs/configuring-routes.html
"Adding routes to your router" uses createRouter as example. I guess it should be new Router5(...)?
Or should specifically say

import createRouter from 'router5';
const myRouter = createRouter(...)

- http://router5.github.io/docs/plugins.html
   All plugin examples links except `Logger` lead to 404s

Will add more if/when I find more gotchas

This part has missed an update. Thanks for bringing my attention to it, it has been updated (new Router5() is the router5@<4 syntax)

wooho!


Backport "assumed valid blocks" feature from Bitcoin 0.13

This PR backports the "assumed valid blocks" feature from Bitcoin 0.13+ as already discussed in https://www.dash.org/forum/threads/backporting-bitcoin-0-13-performance-improvements.15612/
The PR includes multiple backported commits and 1 custom commit.
EDIT: As requested, I added original commit IDs to the description. Also, I added a few more commits as I realized that I should not have selected commits on naive commit level but on PR level. I reordered the commits based on PRs and marked the new commits with NEW
From original PR https://github.com/bitcoin/bitcoin/pull/9053

"IBD check uses minimumchain work instead of checkpoints" (original commit: fd46136dfaf68a7046cf7b8693824d73ac6b1caf)
This one introduced the nMinimumChainWork chainparam which is needed by the assumed valid blocks feature.
I updated the nMinimumChainWork param for both the Dash mainnet and the testnet.
NEW "Remove GetTotalBlocksEstimate and checkpoint tests that test nothing." (original commit: 2082b5574cec783f4ff99941492d92e05680b293)
NEW "IsInitialBlockDownload no longer uses header-only timestamps." (original commit: e141beb6a9816b7e1e680fb0a8bae16d42a3e557)

From original PR https://github.com/bitcoin/bitcoin/pull/10345

"Delay parallel block download until chain has sufficient work" (original commit: e2652002b6011f793185d473f87f1730c625593b)
As written in the forum post, I noticed that block headers and blocks are downloaded at the same time. When the node tries to figure out if an incoming block is an ancestor of the assumed valid block, it needs all the headers up until the assumed valid block. This means, it will always trigger full validation until the required headers are downloaded. As headers and blocks are downloaded at the same time, the headers download is slowed down quite a bit, so it's better to use full bandwidth for headers before we start the actual block download. This commits delays the block download.
NEW Add timeout for headers sync (original commit: 76f74811c44b5119d5c19364b0594d423248ac0e)

Custom commits:

"Add consensusParams to FindNextBlocksToDownload"
I had to add the consensusParams argument as it is not there yet due to other missing backports. This may result in minor conflicts later when other stuff is backported.

From original PR https://github.com/bitcoin/bitcoin/pull/9484

"Introduce assumevalid setting to skip presumed valid scripts." (original commit: e440ac7ef3b6f3ad1cd8fc7027cece40413202d9)
This is the actual feature being backported. It introduces the "-assumevalid" cli argument and the defaultAssumeValid chainparam. I've updated defaultAssumeValid for both the Dash mainnet and testnet.

EDIT: The above commits miss a new testcase being added in the original PR. I'm gonna handle this while fixing the other failing tests.
I would like to ask a few reviewers to verify the values used for nMinimumChainWork and defaultAssumeValid, to make sure I chose correct values. This can be done with your own full node and the debug console. I used block 721000 on mainnet and 251000 on testnet. To check if I used correct values, you could for example use the command "getblockhash 721000" and then "getblock XXX" with the result of getblockhash. getblock will also tell you the chainwork of that block.
Currently, it's hard to see the progress of the synchronization with this PR applied, as headers synching is not shown yet. It looks like nothing is happening for some time, until the actual block download starts. To see progress, it's needed to enter the debug console and use "getblockchaininfo", which will tell you how many headers are downloaded.
The current Bitcoin code already fixes this with some enhancements to the Qt wallet. The next step would be to backport some of these changes to enhance the user experience.

I see at least one test case is failing, gonna dig through it tomorrow.

ACK min work/block hashes for e10e3bd/8ec2c93
Would be nice to have references to original commits (hashes) in description.

I've updated the PR description with original commit IDs. I also added 3 new commits which I missed by looking at commit level instead of PR level.
I've also just noticed a problem with the initial headers sync which was probably unnoticed until now (due to headers and blocks being synced at the same time). I see something around 10 times as much data downloaded as the expected total headers size. This is most likely due to https://github.com/bitcoin/bitcoin/issues/6755, which doesn't have a working fix in Bitcoin right now. I'll try to dig deeper to figure out if I can somehow make a fix for this.

Thanks!
re-ack for block hashes in 8242661

NEW [P2P] Timeout for headers sync (original commit: 76f7481)

I don't see backport for this one in commit list

Sorry about the missing commit. Also, I copy&pasted the wrong commit title into the description, it's actually "Add timeout for headers sync". I added that commit and pushed.

Checkpoints seem to be in the process of being removed in Bitcoin. I didn't check the progress of that however, just seen a hint in one of the commit descriptions.


Transition.transitionservice.onBefore called only once

I'm having trouble trying to show a loader when state changes.
Currently I have  a Loader component and a controller that looks like this:
class LoaderController {

  constructor($transitions, $timeout) {
    this.$transitions = $transitions;
    this.$timeout = $timeout;
    this.loading = true;
  }

  $onInit() {
    this.$transitions.onBefore({to: '*'}, () => {
      console.log('tr');
    });
  }

}

LoaderController.$inject = ['$transitions', '$timeout'];

export default LoaderController;

But the callback for onBefore gets executed only for the default state (that matches the / URL), each time it is called, but never for other states of the application.
What am I missing here? I'm not sure I'm using it correctly, though.

I'll point out three things:

'*' is a glob pattern which matches any state at the root level, but it doesn't match child states.  Use double star '**' to match child states too.  The ui-router glob documentation is scattered and not very good, sorry.

Better yet, the default to: criteria already matches any state, so use onBefore({}, ...).
This is documented here

All properties are optional. If any property is omitted, it is replaced with the value true, and always matches.

If you create a hook in a component, you should deregister that hook when the component is destroyed.

var deregisterFn = $transitions.onBefore(...)

$onDestroy() {
  deregisterFn()
}

If a transition is in progress before your component is initialized (and before your onBefore hook registers), the initial transition won't be captured.  You can get the in-progress transition promise from $state.transition && $state.transition.promise

Thanks for your help Chris. I will not be able to test that before next
week but your explanations sound clear to me.
Le 19 août 2016 19:50, "Chris Thielen"<EMAIL_ADDRESS>a écrit :

I'll point out three things:

'*' is a glob pattern which matches any state at the root level, but
it doesn't match child states. Use double star '**' to match child states
too. The ui-router glob documentation is scattered and not very good, sorry.

Better yet, the default to: criteria already matches any state, so use onBefore({},
...).
This is documented here
https://ui-router.github.io/docs/latest/interfaces/transition.hookmatchcriteria.html
All properties are optional. If any property is omitted, it is replaced
with the value true, and always matches.

If you create a hook in a component, you should deregister that hook
when the component is destroyed.

var deregisterFn = $transitions.onBefore(...)
$onDestroy() {
deregisterFn()
}

If a transition is in progress before your component is initialized
(and before your onBefore hook registers), the initial transition won't
be captured. You can get the in-progress transition promise from $state.transition
&& $state.transition.promise

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular-ui/ui-router/issues/2930#issuecomment-241087223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFV5lzqzoNFuyPPg06l9wGQfAIpO1Lmbks5qhez5gaJpZM4JoX1_
.

closing for housekeeping.  feel free to ask to reopen if you still consider this  a bug


Drop "Install latest yarn version" step on CI

It's now part of official node docker image

Perfect!


fix(gpio): Support GPIO registers > 31 on BCM2711

BCM2711 supports an address space of 61 GPIO-related registers. Trying to access GPIOs >=32 currently results in an out-of-bounds access into the locks array, which this patch fixes.

Thanks for the PR. According to the datasheet, the BCM2711 only has 58 GPIO registers (GPIO0 - GPIO57). If this is incorrect, please provide a source for the additional registers and I'll reopen this PR.
I do however see there's an underlying issue with accessing GPIOs > 54 on the BCM2711 caused by pin::MAX not being updated for that SoC. The pull-up/pull-down code needs to be looked over as well, since it may not be handling locks properly. I'll open an issue and get that fixed asap. I appreciate you calling attention to this problem.

Thanks for the explanation @benkard. It has been a while since I've gone through that code, and I confused it with the number of GPIOs. I'll merge your PR and look into fixing the additional issues.


Documentation slightly confusing regarding AND'ing and OR'ing of MachineMetadata

While reading the documentation on https://github.com/coreos/fleet/blob/master/Documentation/unit-files-and-scheduling.md#schedule-unit-to-machine-with-specific-metadata I erroneously interpreted metadata restriction as OR'ing everything from different lines and AND'ing everything on the same line as suggested by the first few examples.
However, looking at the code, there is no difference between separating them with space in the same line or having them on separate lines. The following modified test illustrates this:
https://github.com/coreos/fleet/blob/master/job/job_test.go#L323
...
func TestJobRequiredMetadata(t *testing.T) {
	testCases := []struct {
		unit string
		out  map[string]pkg.Set
	}{
		// multiple different key-value pairs in a single line
		{
			`[X-Fleet]
MachineMetadata="foo=bar" "duck=quack"
MachineMetadata="foo=car"`,
			map[string]pkg.Set{
				"foo":  pkg.NewUnsafeSet("bar", "car"),
				"duck": pkg.NewUnsafeSet("quack"),
			},
		},
		{
			`[X-Fleet]
MachineMetadata=foo=bar
MachineMetadata=foo=car
MachineMetadata="duck=quack"`,
			map[string]pkg.Set{
				"foo":  pkg.NewUnsafeSet("bar", "car"),
				"duck": pkg.NewUnsafeSet("quack"),
			},
		},
	}
	for i, tt := range testCases {
		j := NewJob("echo.service", *newUnit(t, tt.unit))
		md := j.RequiredTargetMetadata()
		if !reflect.DeepEqual(md, tt.out) {
			t.Errorf("case %d: metadata differs", i)
			t.Logf("got: %#v", md)
			t.Logf("want: %#v", tt.out)
		}
	}
...

Hence, in the documentation, there should be another example illustrating this logic.
[X-Fleet]
MachineMetadata="region=us-east-1" "job=foo"
MachineMetadata="region=us-west-1" "job=bar"

Would correspond to
(job=foo OR job=bar) AND (region=us-east-1 OR region=us-west-1)

as it is very easy to confuse it as
(job=foo AND region=us-east-1) OR (job=bar AND region=us-west-1)

Or better still, emphasize that separating requirements with spaces or specifying them on separate lines make no difference (if that is indeed the intention).

@daniellowtw there is no difference whether you put space or not and documentation doesn't tell about that. "OR" statement takes place only when you define the key several times:
A single key may also be defined multiple times, in which case only one of the conditions needs to be met
It doesn't matter how exactly do you define these statements:
[X-Fleet]
MachineMetadata="region=us-east-1" "diskType=SSD"
MachineMetadata=region=us-west-1

will make the same result as:
[X-Fleet]
MachineMetadata="region=us-east-1" "diskType=SSD" "region=us-west-1"

@joshix @robszumski can you suggest better explanation for this logic?


SW-4329 Add facility numbers to existing identifiers

Update the human-readable identifiers of accessions and batches to use the new
numbering scheme that includes the facility number.
Accessions with custom numbers from CSV uploads aren't updated, just ones whose
accession numbers match the old format.
DEPLOYMENT NOTE:
This should be deployed only after the code change to start generating new-style
identifiers has been deployed, so as to avoid any old identifiers slipping through
the cracks during deployment.

Current dependencies on/for this PR:

main

PR #1426

PR #1427   👈

This comment was auto-generated by Graphite.

On your deployment note, does that mean that we need to deploy 07380cf to production separately, before this commit, or can they both be part of the same release to prod (tag)?

They should be deployed separately. Otherwise there's the possibility that during deployment, one of the server instances will still be running the old code and will create an identifier with the old format after this migration has already run on another instance, and that identifier will never be converted.

Merge activity

Oct 25, 4:33 PM: @sgrimm started a stack merge that includes this pull request via Graphite.