restyled time traveling sidebar and added commit overview

To enhance the browsing ux, I made the following changes to the time traveling sidebar:

rearranged and restyled its elements to enhance the compositional flow
added a navigable commit overview
removed the editor avatar (missing or rather redundant data in this context)
changed the merge date into a more human-readable format
changed the EXIT link into a close symbol

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: arminbw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


redditApiSlice - created hooks to fetch subreddit & author icons / Post.jsx - used those hooks to render subreddit & author icons as other props to render the posts subreddit display name, author display name, post  body & image

As the title says in redditApiSlice I created new endpoint queries to fetch icon_img data from the /about.json endpoints for subreddit & author. I then created hooks from these which I imported into Post. I then destructured variables from the hooks to use in the src props of the img tag.

Also in Post I used JSX expressions within tags to render subreddit name, author name with their icons. Then in the post body I used the selftest property to display the text body of the post.

I used post.url to render the image posted.

But as you can see, a number of the icons are just not rendering for some reason. We need to keep looking into this.

Also, this is good to show you the general layout that I am after but Post is in desperate need of css.

As the title says in redditApiSlice I created new endpoint queries to fetch icon_img data from the /about.json endpoints for subreddit & author. I then created hooks from these which I imported into Post. I then destructured variables from the hooks to use in the src props of the img tag.

Also in Post I used JSX expressions within tags to render subreddit name, author name with their icons. Then in the post body I used the selftest property to display the text body of the post.

I used post.url to render the image posted.

But as you can see, a number of the icons are just not rendering for some reason. We need to keep looking into this.

Also, this is good to show you the general layout that I am after but Post is in desperate need of css.

This all looks good. For the icons/and images that do not load, we should add in fallback images/icons. I can approve after that.

Okay. Thanks Joy. I'll have a look at that tomorrow. Do you have any ideas or resources?

This link has some icons for reddit https://www.flaticon.com/free-icons/reddit. One of those should be fine as fallback for user icon.
For the subreddit fallback icon, this svg from one of the chats on subreddits should be fine
()

Yes, it's this svg file. Thanks for pointing out that it didn't attach.

We can add the svg file to the project, then import it into Post component, and set it as fallback in the img element using onError attribute.
 import subreddit from '../../subreddit.svg'
then in img element
 onError={(e) => {e.target.src = logo}}
width='50px' height='50px'
The inline width and height is temporary, just so the img doesn't take over the whole page. We can remove that when adding css.

Yes, it's this svg file. Thanks for pointing out that it didn't attach. <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" fill="currentColor"><path d="M10 0a10 10 0 1 0 10 10A10.011 10.011 0 0 0 10 0ZM8.016 8.633a1.616 1.616 0 0 0-.2.806V13.5H5.931V6.172h1.8v.9h.039a3.009 3.009 0 0 1 1.018-.732 3.45 3.45 0 0 1 1.449-.284c.246-.003.491.02.7<IP_ADDRESS>.309.08.444.164l-.759 1.832a2.09 2.09 0 0 0-1.093-.26c-.33-.01-.658.062-.954.208a1.422 1.422 0 0 0-.591.565Zm2.9 6.918H9.355L14.7 2.633c.426.272.828.58 1.2.922l-4.984 11.996Z"></path></svg>
We can add the svg file to the project as an image, then import it into Post component, and set it as fallback in the img element using onError attribute.
 import subreddit from '../../subreddit.svg'
then in img element
 onError={(e) => {e.target.src = subreddit}} width='50px' height='50px'
The inline width and height is temporary, just so the img doesn't take over the whole page. We can remove that when adding css.

Was the svg from what wilaxx posted before? I used chatGPT to make something. It's a placeholder for now as it's not the same as the r/ but it would be great if we could match the style. Do you know anything about making svgs?

I've added fallback images & used json?sr_detail=1 to reduce the queries for fetching subreddit data. The author icon is still being fetched from /about.json so we may need to look for an alternative there circling back to Avatar.jsx. But let me know what you think, if this achieves what I set out for Post.jsx for now.

Was the svg from what wilaxx posted before? I used chatGPT to make something. It's a placeholder for now as it's not the same as the r/ but it would be great if we could match the style. Do you know anything about making svgs?

Yes, it was. I remembered it was suggested for the subreddit avatar. So until we get something better, I felt it was okay. About the fallback author img matching that style, I actually prefer it to be much different. I was thinking something closer to icons like below from reddit. Some sites(one example- https://icons8.com/icons/set/reddit) already have svgs of those type of icons. So I only use them, haven't had to make any myself. It's nice that you made this one easily with chatGTP.

Ok that's cool. I like my userLogo. I was able to make it better than what chatGPT initially suggested. I'd want both to be aligned. That's why I like what I've set atm. Unless you can find something similar ish for subreddits.


Changing s command Temperature and Time fields description

Hi!
I changed the description of s command according to my findings during implementing this command.
Costin

Thank you for you participation!


Feature request: Add "Profit in points when TS should kick in"

Add "Profit in points when TS should kick in" like in https://github.com/EarnForex/Trailing-Stop-on-Profit

Should be added in 1.03.


Removing project that you are pointing to takes you to Hosts Page

v0.13.1
Steps:

Add a couple of projects
Switch to project A
Go back to Manage Projects and Delete Project A

Results:
You get moved back to Hosts page and pointing to Default
Expected:
You should switch to Default, but you should stay on Manage Projects page

v0.17.0
Verified fixed


where is the .cs file?

where is the .cs file?
Originally posted by @securigy in https://github.com/Azure-Samples/cognitive-services-speech-sdk/pull/1904#issuecomment-1501316426

Hi @TonyHCIR
Could you elaborate you query. So, it can be helpful to redirect to particular service area and we can help you.


Re schedule of workshop?

Hello, I am interested to know if you are going to re-schedule the workshop that was postponed due to Covid-19. If not, maybe the material can be shared either way? Thank you!

Hi @sofiakarb - thank you very much for your interest! We are slowly reviving this, and I hope we'll be able to deliver the course (probably online) in Q3 2021.
In the meantime, you can have a look at this material that ELIXIR and the Carpentries are putting together.

Dear @fpsom, thank you very much for your answer! I hope everything go as expected and be able to deliver the course! Thank you also for providing the material. Best Sofia.


[ja] Translate content/en/docs/tasks/configure-pod-container/configure-pod-initialization.md into Japanese

This is a Feature Request

What would you like to be added

Translate content/en/docs/tasks/configure-pod-container/configure-pod-initialization.md into Japanese
Why is this needed
it has not been translated into Japanese
Comments

/language ja
/assign
/area localization

/triage accepted


immediate response / async processing

Usually on replicate I get an immediate response containing a get url that I can poll for prediction status, which allows me to return fast without worrying about users navving away etc.
Is something like that possible with a comfyui workflow? I was surprised to see that the replicate nodejs client waits around for the workflow to fully complete, and afaict there's no simple way for me to persist something (like a prediction ID) that I could retrieve and check later if the client went away.
Here's the code for my dummy nextjs api route, based on the example
import Replicate from "replicate";

import { NextApiRequest, NextApiResponse } from "next";

export default async function handler(
  req: NextApiRequest,
  res: NextApiResponse
) {
  const replicate = new Replicate({
    auth: process.env.REPLICATE_API_TOKEN,
  });

  const workflow = {
    "3": {
      "inputs": {
        "seed":<PHONE_NUMBER>00286,
        "steps": 20,
        "cfg": 8,
        "sampler_name": "euler",
        "scheduler": "normal",
        "denoise": 1,
        "model": [
          "4",
          0
        ],
        "positive": [
          "6",
          0
        ],
        "negative": [
          "7",
          0
        ],
        "latent_image": [
          "5",
          0
        ]
      },
      "class_type": "KSampler",
      "_meta": {
        "title": "KSampler"
      }
    },
    "4": {
      "inputs": {
        "ckpt_name": "dreamshaperXL_alpha2Xl10.safetensors"
      },
      "class_type": "CheckpointLoaderSimple",
      "_meta": {
        "title": "Load Checkpoint"
      }
    },
    "5": {
      "inputs": {
        "width": 1024,
        "height": 1024,
        "batch_size": 4
      },
      "class_type": "EmptyLatentImage",
      "_meta": {
        "title": "Empty Latent Image"
      }
    },
    "6": {
      "inputs": {
        "text": "beautiful scenery nature glass bottle landscape, purple galaxy bottle,",
        "clip": [
          "4",
          1
        ]
      },
      "class_type": "CLIPTextEncode",
      "_meta": {
        "title": "CLIP Text Encode (Prompt)"
      }
    },
    "7": {
      "inputs": {
        "text": "text, watermark",
        "clip": [
          "4",
          1
        ]
      },
      "class_type": "CLIPTextEncode",
      "_meta": {
        "title": "CLIP Text Encode (Prompt)"
      }
    },
    "8": {
      "inputs": {
        "samples": [
          "3",
          0
        ],
        "vae": [
          "4",
          2
        ]
      },
      "class_type": "VAEDecode",
      "_meta": {
        "title": "VAE Decode"
      }
    },
    "9": {
      "inputs": {
        "filename_prefix": "ComfyUI",
        "images": [
          "8",
          0
        ]
      },
      "class_type": "SaveImage",
      "_meta": {
        "title": "Save Image"
      }
    }
  }

  const output = await replicate.run(
    "fofr/any-comfyui-workflow:f8bbe354839d762488971160872eac54dc1c9e61462e91743d360d1d640020c6",
    {
      input: {
        workflow_json: JSON.stringify(workflow, null, 2),
        randomise_seeds: true,
        return_temp_files: false,
      },
    }
  );
  console.log(output);
  res.json({ output: JSON.stringify(output) });
}

@tomryanx I recommend using prediction.create rather than prediction.run.
This will immediately return with a prediction ID. You can then use this ID to check status of the prediction and get results when they're ready.
More here:
https://github.com/replicate/replicate-javascript?tab=readme-ov-file#replicatepredictionscreate

Oh amazing. My bad. Only just switched to use the replicate client instead of calling the APIs with axios. Thanks for the cluebat!


.Net 4 is missing

I assume there is some reason that is obvious to regular users, but there is an explanation for .NET 7.x, 6.x, 5.x, and 3.x, but skips 4.x .
In the text:
C# 11 is supported only on .NET 7 and newer versions. C# 10 is supported only on .NET 6 and newer versions. C# 9 is supported only on .NET 5 and newer versions. C# 8.0 is supported only on .NET Core 3.x and newer versions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5694e62b-c756-1f62-4014-2ceafa54c011
Version Independent ID: 3f01c378-22e4-197c-a862-ab4a924506c7
Content: C# language versioning - C# Guide
Content Source: docs/csharp/language-reference/configure-language-version.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Very short version of the history of .NET.
It started as .NET, which evolved up to .NET 4.
Then started .NET Core, evolved up to .NET Core 3.1. After .NET Core 3.1 there was a desire to drop "Core" for moving on the future solely as .NET.
As there was already a .NET 4 this version couldn't be used again, so there was a jump forward to .NET 5.
For more infos please see .NET Core is the Future of .NET and the linked posts.

I see. I'm not sure how to fix the phrasing, but I think the confusing part is core  vs framework.

The heading says framework, and when I am building my project i need to set .net framework, so its hard to find information on this framework targeting pack because these links (referenced in the issue) keep showing up.

ping @richlander
Do you have good wording to disambiguate between "target framework" and ".NET Framework"?

We don't. However, in that table, the column header could be simplified to just "Target" or "Target platform". Target frameworks always include a version, so the column technically isn't a target framework, but something more abstract. There is a name for that concept, too, but that's adding more complexity.


brew install concorde no longer works

mac:Downloads me$ brew install concorde
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> Updated Formulae
exim                                     grib-api

Error: No available formula with the name "concorde"
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow

Error: No previously deleted formula found.
==> Searching for similarly named formulae...
==> Searching local taps...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.
ajays-mbp:Downloads ajay$ brew info concorde
Error: No available formula with the name "concorde"
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow

Error: No previously deleted formula found.

Ah, that's a bummer. I'm thinking of packaging Concorde with pytsp (and releasing a wheel on PyPI), but in the meantime, are you OK with building Concorde from scratch yourself?

That's cool. And yeah, I was able to build Concorde from scratch using your instructions.

@Carpetfizz Thanks for bringing this up. This (and many other useful recipes) used to be in the now-deprecated homebrew/science repo, and it's a pity that this is not around anymore. In the meantime, I've updated the tools/build_concorde.sh script in the repository so that it works on mac OS as well. I've updated the README to reflect the new usage instructions.

Thanks for being proactive about fixing this issue. You definitely helped my friends and I complete our class project in time!


Generate

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Is this a client library issue or a product issue? We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit the Support page to reach the most relevant engineers.
If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details

Programming language:
OS:
Language runtime version:
Package version:

Steps to reproduce

?
?

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

Apologies this was created erroneously.


Node and edge notes and names

Hello, is it possible to display a name on each node and edge? Or a note, something. I couldn't possibly find anything in the documentation. Thank you!

I think you're talking about labels.  See http://js.cytoscape.org/#style/labels for details on how to set your styles up for label properties on nodes and edges.


[Feature Request] :: Width and Height of the video must be setup

I'm submitting a ...
[ x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
With new versions the size of the video must be set up when you write the file on disk.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Hi developingtoday,
Thanks for reaching out. As per your request, added support for video frame width and height. Also provided the
option to support the aspect ratio for the video.
Have a look at the documentation.
https://prasanaworld.github.io/puppeteer-screen-recorder/globals.html#videooptions
Latest NMP Version
npmjs.com/package/puppeteer-screen-recorder/v/1.1.9


Cannot renew/generate certificates (acme: error presenting token)

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I am using traefik with docker-compose.
Noticed that my certs were not renewing as they were in the past.
Found the logs below:
What did you see instead?
time="2022-08-05T12:09:05Z" level=error msg="Error renewing certificate from LE: {irc.arul.io []}, error: one or more domains had a problem:\n[irc.arul.io] [irc.arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n" providerName=http.acme ACME CA="https://acme-v02.api.letsencrypt.org/directory"
time="2022-08-05T12:09:07Z" level=error msg="Error renewing certificate from LE: {arul.io [*.arul.io]}, error: one or more domains had a problem:\n[*.arul.io] [*.arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n[arul.io] [arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n" ACME CA="https://acme-v02.api.letsencrypt.org/directory" providerName=http.acme
time="2022-08-05T12:09:09Z" level=error msg="Error renewing certificate from LE: {*.update.arul.io []}, error: one or more domains had a problem:\n[*.arul.io] [*.arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n[*.update.arul.io] [*.update.arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n[arul.io] [arul.io] acme: error presenting token: njalla: failed to add record: failed to unmarshal response result: json: cannot unmarshal string into Go struct field Record.id of type int\n" providerName=http.acme ACME CA="https://acme-v02.api.letsencrypt.org/directory"

What version of Traefik are you using?
Version:      2.8.1
Codename:     vacherin
Go version:   go1.17.11
Built:        2022-07-11T14:06:57Z
OS/Arch:      linux/amd64
What is your environment & configuration?
#experimental:
#  http3: true

#log:
  #  level: DEBUG

ping: {}
api:
  dashboard: true
  debug: false

entryPoints:
  http:
    address: ":80"
    http:
      redirections:
        entryPoint:
          to: https
  https:
    #http3: {}
    address: ":443"
    http:
      middlewares:
        - default-headers@file
      tls:
        certResolver: http
        domains:
          - main: "arul.io"
            sans:
              - "*.arul.io"
              - "*.update.arul.io"
  tcps:
    address: ":7000"

providers:
  providersThrottleDuration: 100
  docker:
    endpoint: "tcp://dockerproxy:2375"
    exposedByDefault: false
    network: web
    defaultRule: Host(`{{ index .Labels "com.docker.compose.service" }}.arul.io`)
  file:
    filename: /config.yml

certificatesResolvers:
  http:
    acme:
      email<EMAIL_ADDRESS>      storage: acme.json
      dnsChallenge:
        provider: njalla
        delayBeforeCheck: 1200
        resolvers:
          - "<IP_ADDRESS>:53"
          - "<IP_ADDRESS>:53"

I tried with and without delayBeforeCheck and providersThrottleDuration (I found these on other issues)
Add more configuration information here.
config.yml:
http:
  middlewares:
    https-redirect:
      redirectScheme:
        scheme: https

    default-headers:
      headers:
        sslRedirect: true
        browserXssFilter: true
        contentTypeNosniff: true
        forceSTSHeader: true
        stsIncludeSubdomains: true
        stsPreload: true
        stsSeconds: 31536000
        contentSecurityPolicy: "upgrade-insecure-requests"
        referrerPolicy: "strict-origin-when-cross-origin"
        customResponseHeaders:
          Permissions-Policy: "geolocation=(), camera=(), fullscreen=*, interest-cohort=(), browsing-topics=()"
          X-Frame-Options: "SAMEORIGIN"
          Server: ""

    default-whitelist:
      ipWhiteList:
        sourceRange:
          - "<IP_ADDRESS>/24"
          - "<IP_ADDRESS>/16"
          - "<IP_ADDRESS>/8"

    comp:
      compress: {}

    secured:
      chain:
        middlewares:
          - default-whitelist
          - default-headers
          - comp

tls:
  options:
    default:
      minVersion: VersionTLS12
      sniStrict: true
      curvePreferences:
        - CurveP521
        - CurveP384
      cipherSuites:
        - TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
        - TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
        - TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
        - TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
        - TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305
        - TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305

docker-compose.yml:
version: '3.4'

services:
  dockerproxy:
    restart: unless-stopped
    image: tecnativa/docker-socket-proxy
    networks:
      - docker_proxy
    environment:
      - CONTAINERS=1
      - SERVICES=1
      - NETWORKS=1
      - TASKS=1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    expose:
      - 2375

  traefik:
    image: traefik:vacherin
    restart: unless-stopped
    security_opt:
      - no-new-privileges:true
    ports:
      - 80:80
      - 443:443
        #  - 443:443/udp
      - 7000:7000
    volumes:
      - ./data/traefik.yml:/traefik.yml:ro
      - ./data/config.yml:/config.yml:ro
      - ./data/acme.json:/acme.json
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.traefik.entrypoints=https"
      - "traefik.http.routers.traefik.rule=Host(`traefik.arul.io`)"
      - "traefik.http.routers.traefik.middlewares=authentik@docker"
      - "traefik.http.routers.traefik.service=api@internal"
    environment:
      NJALLA_TOKEN: ${NJALLA_TOKEN}
    healthcheck:
      test: wget -q --spider http://localhost:8080/ping
      interval: 1m
      timeout: 10s
      retries: 5
      start_period: 20s
    networks:
      - web
      - docker_proxy

networks:
  web:
    external: true
  docker_proxy:
    external: false

If applicable, please paste the log output in DEBUG level
No response

Hello,
the problem is already fixed in lego https://github.com/go-acme/lego/issues/1685

Apologies @ldez , what do I need to do on my end? Wait for a traefik release with a new lego version?

Wait for a traefik release with a new lego version?

exactly


Memory and storage copying

What was wrong?
closes #152

we didn't have operations for copying storage -> storage or memory -> memory
the existing naming scheme for these operations was a bit confusing (e.g. scopy for storage -> memory copying)
copy operations were going byte-by-byte, which is extremely inefficient

How was it fixed?

implemented said copying operations and used them in the relevant places (assignments and expression moves)
updated the existing operations with a cleaner naming scheme
copying now happens word-by-word

To-Do

[ ] OPTIONAL: Update Spec if applicable
[x] Clean up commit history

Codecov Report

Merging #155 (0033117) into master (220185f) will decrease coverage by 0.81%.
The diff coverage is 36.88%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   81.29%   80.48%   -0.82%
==========================================
  Files          44       44
  Lines        3144     3202      +58
==========================================
+ Hits         2556     2577      +21
- Misses        588      625      +37

Impacted Files
Coverage Δ

compiler/src/yul/mappers/assignments.rs
97.82% <ø> (ø)

compiler/src/yul/runtime/functions.rs
0.00% <0.00%> (ø)

semantics/src/errors.rs
5.00% <0.00%> (-0.27%)
:arrow_down:

semantics/src/namespace/types.rs
56.85% <ø> (ø)

semantics/src/traversal/assignments.rs
96.87% <ø> (ø)

semantics/src/traversal/functions.rs
45.28% <0.00%> (ø)

compiler/src/yul/operations.rs
80.95% <30.00%> (-8.53%)
:arrow_down:

compiler/src/yul/abi/functions.rs
53.84% <33.33%> (-0.53%)
:arrow_down:

semantics/src/traversal/expressions.rs
71.84% <36.92%> (-4.14%)
:arrow_down:

semantics/src/lib.rs
77.89% <57.69%> (-4.61%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220185f...0033117. Read the comment docs.


no such group or event: TextChangedI

Hi, I got these errors every time I open a java file.
I'm on mac, vim version 7.3, jdk 1.8.0_45.
I cloned the repository in my bundle folder and added autocmd FileType java set omnifunc=javacomplete#Complete to my .vimrc

Please, can you try with last commit.

great, it works, thanks


Add benchmarks for triggered product updated webhook

I want to merge this change because...I want to add benchmarks for triggered products and variants webhooks, like

PRODUCT_UPDATED
PRODUCT_DELETED
PRODUCT_CREATED
PRODUCT_VARIANT_CREATED
PRODUCT_VARIANT_UPDATED

Also updated invalid code error in CollectionBulkDelete

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Added label in progress because we need to update collection error type in dashboard before merging this PR.


Card status shows [none] on keys

I've previously had my Yubikey working for about six months. My MacBook randomly crashed today and now I can't sign git commits anymore. Looking at the card status:
❯ gpg --card-status
Reader ...........: Yubico YubiKey OTP FIDO CCID
Application ID ...: <appid>
Application type .: OpenPGP
Version ..........: 1.0
Manufacturer .....: ?
Serial number ....: <serial>
Name of cardholder: [not set]
Language prefs ...: [not set]
Salutation .......:
URL of public key : [not set]
Login data .......: [not set]
Signature PIN ....: not forced
Max. PIN lengths .: 3 -2 0
PIN retry counter : 0 0 0
Signature counter : 0
Signature key ....: [none]
Encryption key....: [none]
Authentication key: [none]
General key info..: [none]

It basically looks like the card is brand new. No keys, cardholder, etc. If I plug it into the Raspberry Pi that I used to configure it, the card status looks fine (I can see the keys, cardholder name, etc.). So the problem is somewhere on the Mac side of things. Any idea what would cause this?

Found the culprit:
❯ gpg --version
gpg (GnuPG) 2.3.7

Version 2.3.7 introduces a bug that seems to break card reading. Reverting back to 2.3.6 resolved the issue.


check duplication on obj_id

Discussed in https://github.com/monodera/pfs_target_uploader/discussions/158

Originally posted by monodera November 16, 2023
In the datamodel, (catId, objId) must be unique while (ob_code, proposal_id) must be unique for targetdb and queuedb. In the current plan, catId is unique for each proposal, while objId can be duplicated. Shall we check whether all obj_id are different in a target list?
Currently, input_catalog_id is assigned per-target list basis, so just checking duplication within the target list should be fine.

It seems that there is a demand of requesting, e.g., 3 sets of 900s exposure, not 1x2700s exposure. I'd like to know more about the exact requirement for the validation item for duplication.

It seems that it's required. I'll work on it and it shouldn't be difficult.

addressed in issue/184-checkduplication-on-obj_id branch.

I added resolution as additional constraint. Currently, two duplication checks are independently carried out and the target list must pass two of them.

#193 #194 #195


Changing filters for vulnerability view

We will need to add A LOT of filters on this page, but now we should at least refactor and split filters for it
What's done:

updating filters
polishing vuln. collection view

We need to have a possibility to filter criticality: https://mdbootstrap.com/docs/b4/jquery/plugins/multi-range/


Add support for terminal profile selection based on glob patterns

The glob pattern support for the "files.associations" setting in VS Code has proven incredibly useful.
I wonder if something similar could be implemented for users who tend to use multiple integrated terminal profiles (depending on workspace / project) where the default terminal could easily be defined for a directory organized as follows:
projects/
│
├── cpp/
│   ├── <cpp project 1>
│   └── <cpp project 2>
│
├── csharp/
│   ├── <c# project 1>
│   └── <c# project 2>
│
├── bash/
│   ├── <sh project 1>
│   └── <sh project 2>
│
└── and so on...

by simply using glob patterns to define associations like so: [^1]
"integrated.terminal.associations": {
  "**/cpp/**": "msys2",
  "**/csharp/**": "cmd",
  "**/bash/**": "GitBash",

[^1]: Just an illustration - identifiers may not be accurate

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

You can sort of do this already by opening multiple folders instead and then having profiles set at the folder level.

Yes, thanks for pointing that out. I've been out of the loop for a while on new features.  The whole folder-level settings is a muuuch better solution than my idea.

@Tyriar  I'm looking through the per-folder settings currently and I do not see any option to see a default terminal there. Am I overlooking it?

Actually I was wrong, you can't actually set profiles in multi-root workspaces currently, only when a single folder is opened. I looked into doing this and it's unfortunately a much bigger change than I anticipated, so keeping this closed as out of scope.

Ahh ok. So is the workaround just having separate workspaces for each terminal profile then?

Yep


Timeline: 'Loading...' is shown in empty timeline if 'Infinite Scroll' is enabled.

Show [Loading complete] when there is nothing to load.


Console.log doesn't work on classes in the server directory when building with docker

...should they?
I also tried using the Logger class, those also don't show up in the terminal window when running the docker command, is this expected?

figured this out, reason i had the issue is i the color coding of logs all were the same, need to update mine so that each log type has a different color in my iterm


Error finding timezone

I get this error on startup. The integration works anyway but time is off 1 hour.

The file does exist:

Probably a permission issue

I assume you're looking at the host file system, it's looking inside the container.
I went back through my build logs and saw an issue with the armv7 image related to the required timezone package.
Is this the architecture you are running on (hopefully :)) ?

No, I'm not running it in an container. I am running it on a Raspberry Pi.
Home Assistant 2022.11.5
Supervisor 2022.11.2
Operating System 9.3
Frontend-versie: 20221108.0 - latest

I see you already released an update in the mean time. I can confirm the issue is now gone. Thank you!


Sort results is different between realm sort and Swift sort

i am using realmSwift, to cater the requirement, i will sort this result for display,  when i sort  it using sorted(by:) in realm and sorted() in swift,  found that the results is different. The sort keyword is a property of the object type String.
func sortInventories(inventories: Results, by preference: SortingPreference)  {
var sortDescriptors = RealmSwift.SortDescriptor
sortDescriptors.append(.init(keyPath: \Inventory.brandName))
var arr = Array(inventories).sorted { s, ss in
return s.brandName < ss.brandName
}
var xx = inventories.sorted(by: sortDescriptors)
}

There are a number of reasons those sorts will be different and I don't believe this line of code is valid as-is
var sortDescriptors = RealmSwift.SortDescriptor
But... there's no need to leverage high level Swift functions - and doing that defeats the purpose of the memory friendly lazy-loading feature of Realm.
Why not just use a one liner?
let sortedInventory = realm.objects(Inventory.self).sorted(by: \.brandName)


feat: support *args and **kwargs

*args is fully supported.
**kwargs are ignored, as there is no easy way for a Click command to accept arbitrary options without having to individually call click.option for each one (which is impossible as this information is not known at compile time).

Pull Request Test Coverage Report for Build b4329f66-90c2-43e9-aaf0-c88066cdf8af

31 of 31 (100.0%)  changed or added relevant lines in 3 files are covered.
15 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.6%) to 96.987%

Files with Coverage Reduction
New Missed Lines
%

core/command.py
2
87.95%

_internal/_decorators.py
4
90.24%

feud/core/command.py
9
92.62%

Totals

Change from base Build 725116c6-f18c-4b53-ba63-37961f826ea3:
-0.6%

Covered Lines:
1738

Relevant Lines:
1792

💛  - Coveralls


Allow shading language to use switch statement with uints

Considering the following shader code:
	uint x = 1u;
	switch(x) {
		case 1:
			ALBEDO = vec3(1.0, 0.0, 0.0);
			break;
		case 2:
			ALBEDO = vec3(0.0, 1.0, 0.0);
			break;
	}

Godot's shader parser fails at the switch saying Expected an integer expression. But this should be valid.

Is this also an issue in 3.x?

Thanks!


openssl 3.0.0 beta1+quic

Going to try this a slightly different way than previous rebases (i.e. a bit more public).
This is the rebase of openssl-3.0.0-alpha17+quic onto the openssl-3.0.0-beta1+quic branch (which is at the openssl-3.0.0-beta1 tag).
The rebase was fairly clean, only the usual suspects (CHANGES.md. utils/libcrypto.num, VERSION.dat, etc)

Upstream's release script failed to run make update as part of producing the beta, but the checks that require assigning numbers to exported symbols activated with the beta, so the CI complained and you added the make update change.  I don't think we should be running make update ourself to allocate numbers for upstream symbols, though -- given that https://github.com/openssl/openssl/issues/15806 is still open, I think we might have to tolerate the CI issue for now rather than introduce a change that is in some sense speculative and might diverge from upstream.
Other than that, the changes are a clean rebase and look fine.

I don't think the numbers will change... but I can remove commit cb3a786.

Got rid of both the make update and make doc-nits commits, as they didn't really fix what they needed. Apparently there is now an md-nits target that I didn't know about, so that check was still failing. We can always update that as a separate PR. So, those two commits have been removed from the tip of this PR.

Check docs, check update, and fuzz are failing. As expected.

Check docs, check update, and fuzz are failing. As expected.

Yup, all looks as expected.  Thanks!


Option to change from highlighting pairs to underlining, etc

Love the simplicity of this plugin! I would like, however, to be able to configure how matched characters are identified.

Hello.
You are new to vim/neovim?

You are new to vim/neovim?

I've been using it for awhile, but am newly configuring it :)
Is this already available?

Yes it is already available, with hl_group option. By default it is uses highlight group called MatchParen. You can check how it looks and its arguments with :hi MatchParen.  If you use some colorscheme that you installed as plugin (and my assumption you are, or else you would know how to change highlights), but you don't like how it's MatchParen highlight group looks you can check all the higlight groups with :hi command and find some underlined xxx and provide it's name to hl_group option:
require('matchparen').setup({
  hl_group = 'SomeHighlightName',
})

You can try `'Underlined'` first. If you didn't find any that met your requirements, you can change existing highlight group without changing colorscheme itself. But you should have at least basic scripting knowledge:

```lua
vim.api.nvim_create_autocmd({ 'VimEnter', 'ColorScheme' }, {
  callback = function() vim.api.nvim_set_hl(0, 'MatchParen', { underline = 1 }) end
})

I close this. If you still have questions about how neovim highlightings work ask them on appropriate resources, like reddit etc.

By underlining do you mean instead of (foobar) highlight _ in _foobar_? Or what?
This is not possible and out of the scope of this plugin.
There is an option in neovim that this plugin uses internally :h 'matchpairs', but as it is stated open and closing pair should be different characters.


chip8_word_eq

It is currently misspelt as chip8_eq_word in chip8.cats.

All should be good now. I cleaned up the Makefiles, removed some unused code, and added a runner script. It runs on both my Mac and Arch Linux machines currently.


#18798 escape wild cards during primary and imported keys loading

Please check

[ ] primary keys loading (CE) for Snowflake for a table with "_"
[ ] primary keys loading (CE) for Snowflake for a schema with "_"
[ ] foreign keys loading for Snowflake for a table with "_"
[ ] foreign keys loading for Snowflake for a schema with "_"
[ ] primary keys loading (CE) for any other generic driver (Teradata/Netezza CE/HSQL/SQlite)  for a table with "_"
[ ] primary keys loading (CE) any other generic driver (Teradata/Netezza CE/HSQL) for a schema with "_"
[ ] foreign keys loading for any other generic driver (Teradata/Netezza CE/HSQL/SQlite) for a table with "_"
[ ] foreign keys loading for any other generic driver (Teradata/Netezza CE/HSQL) for a schema with "_"

Keys are not shown for a table with "_"

Yeah, because they added support of wildcards to the primary keys reading method only in May
https://github.com/snowflakedb/snowflake-jdbc/commit/10f576afafec3eb488e66051870f4df5f4aade1b
driver version ~ 3.13.19
I am thinking about our options

Verified


Disable tab's context menu option when unavailable.

Description

When focused tab is the trailing one, "close tabs to the right" option in context menu should be disabled.

Related Issue

#572
(Consideration 3)

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

Screenshots
https://user-images.githubusercontent.com/36816148/166505723-f5bbcc45-9aaa-4abb-aeb5-58dba396bf35.mp4

@austincondiff : I think when we are building editor-splitting behavior, we are going to assign each split a WorkspaceDocument. This "disabled" only affect on the trailing tab of current WorkspaceDocument and it should also apply to every existing WorkspaceDocument when we have multiple (under splitting). So it should be fine.


fix: perf: Telepathy V2.0

fixed data races
no more allocations
improved server stability under heavy load(!)
added lots of tests & fixed flaky tests

localhost benchmark with 10k monsters: https://gyazo.com/d0e50082f2c2e3464d4564d1c6e517b7
waiting for jesus ccu test.

Surface level issues:

lock(this) is bad practice because anyone could lock that object and cause problems (eg error prone). I think generally you want a private object and lock on that instead, this goes over some details https://stackoverflow.com/a/251668/8479976

using a single sized buffer for all message increasing memory usage a lot and set a very low limit for max connection (I assume this is why libuv dies at high CCU). it would be better to have multiple buffer sizes, for example if  a message is 10bytes it doesn't need to take up 16kb in memory, it could use the smallest buffer size for example 100 bytes (or even lower)

buffers arn't shared this means that more memory is needed for buffers, if all connections shared a pool then the overall number of buffers needed will be lower


This is not an error but i need help. When trying to connect my htc desire 601 phone it says nothing pops up

[X] I have read the FAQ.
[X] I have searched in existing issues.

Environment

OS: Windows
scrcpy version: [e.g. 1.12.1]
installation method: Windows download
device model: Htc desire 601
Android version: No idea

Describe the bug
I was going threw my drawer when i saw my old htc phone. When trying to unlock it i remebered that some of the screen is broken so unlocking it does not work. I am ust trying to get OTG mode so i can use the device and get old photos. I am not at all a tech guy and when ever i open up the cmd center it just says
"scrcpy 1.25 https://github.com/Genymobile/scrcpy
INFO: Killing adb daemon (if any)...
ERROR: Could not find any USB device"
My phone is connected and windows is showing that its connected. Any help?

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#hidotg-issues-on-windows

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#hidotg-issues-on-windows

I tried some of those things and it not working. Still showing as not found. The problem is i cant go into the phone so i cant see if usb debugging is on

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#hidotg-issues-on-windows

Well my problem is that it nots even seeing my phone as a usb device so it wont show me anything

it nots even seeing my phone as a usb device

Yes, that's the driver issue on Windows this FAQ entry is about. Check the comments linked in that FAQ.


Validate downloaded filename

In the old code there was a bug where go would throw a runtime error for "index out of range" if the filename provided did not contain the "_wc_" string. This caused the strings.Split(filename, "_wc_") to return a list containing only the filename, which causes an index out of range error at the part where the code tried to get the original filename back.
This PR forces the filename argument to have the right length, so that this bug doesn't happen again.
Another solution would be to add the filename to the encrypted file contents (the MIME type is already stored there), so that the file name doesn't even need to be in the link. (would be a cool feature to add regardless)
Edit: forgot that underscores are special in markdown

Hello!
Thank you for your PR and alternative suggestion. Instead of just the fix, I implemented the metadata approach (https://github.com/Northernside/WiredCloud/compare/c0e8127...ef84737).

Alright, the metadata approach you used is defenitely better than my simple length check.
The metadata approach defenitely preferred form a security standpoint, since the filename can't accidentally show up in access logs when someone tries to download a file.


Trouble with using gettext in slime

Hello!
I have a strange trouble with using gettext in slime templates. I tried to do something like this:
span title=gettext("Text")

and this works fine, but when I try to do the same but with whitespaces in gettext:
span title=gettext("Text with whitespaces")

I got an error:
missing terminator: " (for string starting at line 1)

bump

Certainly sounds like a bug, do you have an example application someone can look at?  I'm not personally using Slime + Gettext at this time.

@doomspork Yep, please, look at this https://github.com/TakteS/slime_gettext
You just should clone it and try to compile and you'll get an error.

Thanks @TakteS, I'll take a peek today

Now I found that this is not only gettext trouble. The error occurs when some text with white spaces is enclosed in parentheses:
# Ok
div title=("Text")

# Error will occurs
div title=("Some text")

This is likely an issue with the underlying Slime library's parser.

fixed


MSBuild searches property in the wrong path

I'm trying to use MSBuild with .vcxproj file.
I made sample project in my own directory, but MSBuild searches Microsoft.Cpp.Default.props always in C: instead of the sample project's path.
Attempted behavior:
In the project folder, type MSBuild <project name>.vcxrpoj on command prompt.
The error message:
error MSB4019: The import project "C:\Microsoft.Cpp.Default.props" was not found.
I attached my .vcxproj file.
VisuAlgoProject.zip
Environment data
msbuild /version output: 4.7.3056.0
OS info: Windows 10

To expand a bit: you're using MSBuild 4.7.3056.0 -- that's a very old version that shipped in the .NET Framework. The vcxproj includes ToolsVersion="15.0", so you need to use a new version of MSBuild to understand the project (and know where to find the C++ tooling).
Launching a Developer Command Prompt for VS 2017 window should set up %PATH% and some other variables appropriately so you get the right MSBuild.
I'm going to close this, because I have pretty high confidence that this is the problem. If you try these suggestions and think otherwise please comment and we can reopen this issue.


chore: slf4j 2.0.12

replaced by: https://github.com/operator-framework/java-operator-sdk/pull/2406


openblas: trouble with  DYANAMIC_ARCH feature and bug in AVX512 code

Issue description
The AVX512 kernel on SKYLAKE-X CPUs seems to have a bug that produces wrong numbers (see https://github.com/xianyi/OpenBLAS/pull/2061). I ran into the bug when I tried to use CP2K (external derivation https://github.com/markuskowa/NixOS-QChem/tree/master/cp2k).
Seems also to affect julia (https://github.com/xianyi/OpenBLAS/issues/1955).
Unfortunately there is no simple solution available:

https://github.com/xianyi/OpenBLAS/pull/2061 turns off the problematic kernel but then even the unit tests in CP2K fail (which passed before) leaving openblas in a even more broken state
Alternatively the problem could be solved by turning off DYANAMIC_ARCH but then compilation fails with TARGET="ATHLON". TARGET="NEHALEM" or  TARGET="HASWELL" seems to work but this might break openblas on older system (> ~8-10 years old).
Waiting for openblas 0.3.6 might be the best option (?)

Using the DYANAMIC_ARCH feature has another unwanted side effect on some SKYLAKE CPUs. Heavy utilization of  AVX512 instructions can lead to a drastic reduction in CPU clock frequency. On models like the Xeon Scalable Silver which have only one AVX512 unit per core (e.g. 2.2 GHz -> 1.4 GHz), this can lead to significantly slower code. For example a 20 core linpack benchmark (HPL) on a dual CPU Xeon Silver 4114 system yields 400 GFlops with AVX512 turned on and 570 GFlops with AVX512 disabled (use AVX2 instead). Note that MKL has a similar problem (https://software.intel.com/en-us/forums/intel-math-kernel-library/topic/776894).
Steps to reproduce

Use dgemm function on a Skylake series CPUs (?)

Technical details

openblas 0.3.5
affects NixOS 19.03 and nixpkgs-unstable

CC @costrouc @dtzWill @ttuegel @vcunat

* `TARGET="NEHALEM"` or  `TARGET="HASWELL"` seems to work but this might break `openblas` on older system (> ~8-10 years old).

Would this break AMD systems?

I am not sure if Nehalem and Haswell would still work on all AMD systems. A choice of a fixed target would require a careful investigation, which CPUs are compatible. It is unfortunate that the Athlon target does not to work anymore (that was to be a conservative but safe choice).

I'm currently using Ryzen a lot, so if you write what to try, I can do that.

@vcunat Thanks for the help. I use a an override such as this locally to fix the problem (a full version of it can be found here https://github.com/markuskowa/NixOS-QChem/blob/master/default.nix):
    openblasCompat = let
      obMkfCleaner = makeFlags:
        map (x: if (x == "DYNAMIC_ARCH=1") then "DYNAMIC_ARCH=0" else
          if (x == "TARGET=ATHLON") then "TARGET=NEHALEM" else x
       ) makeFlags;

      in super.openblasCompat.overrideDerivation ( oa : {
         makeFlags = obMkfCleaner oa.makeFlags;
    })

It would be great if you could test the following on Ryzen:

See if the modified openblasCompat builds and passes its test suite.
Build a dependency such as scalapack and see if the testsuite passes.

Both derivations have check phases that do some basic numerical test. If there are incompatible instructions in the binaries it should show in the check phase. That would be a good first test.
I will try to come up with some nix expression that could be used as a more careful test. Given that we had trouble with openblas in the past it would make sense to have some form of extended test suite that could be used  for future updates also (and tested by several people on different CPU models).

Both passed successfully, including some test suites.  (I just used the expression above as overlay for current master.)

@vcunat Thansk a lot. That sounds like a good start.
I also went through the sources of openblas and found that there is a NO_AVX512 compile time flag. I will see if that solves the problem for now.

openblas is built with the NO_AVX512 option, which by passes the problem.


Typo fix

This is a fix for typo present in many places in Azure Web Bot sample files.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: spookiecookie sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Catch small bin_size parameters

This part of the visualization https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/blob/163f0199a89339711ba09ce28420b554f6bf024d/visualize.py#L19 breaks if the bin_size is not at least 3. Maybe catch small bin sizes with an assert?

Hi!
Sorry, I've just noticed the issue.
Yes, it looks like a bug but it should be caught by a try ... catch block.


[AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

Sometimes when you run tasks from command line you get exit code = 1 due
to race condition (job runner tries to get process group from the
process that has already been terminated in the meantime)
Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-3263
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Sometimes when you run tasks from command line you get exit code = 1 due
to race condition (job runner tries to get process group from the
process that has already been terminated in the meantime)

Tests

[x] My PR  does not need testing for this extremely good reason:
It's rather difficult to simulate such race. It's not really worth It to build test for it with such simple change.

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
No new functionality

Code Quality

[x] Passes flake8

Codecov Report

Merging #4108 into master will decrease coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #4108      +/-   ##
==========================================
- Coverage   76.67%   76.66%   -0.02%
==========================================
  Files         199      199
  Lines       16186    16192       +6
==========================================
+ Hits        12411    12413       +2
- Misses       3775     3779       +4

Impacted Files
Coverage Δ

airflow/utils/helpers.py
82.08% <42.85%> (-2.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc182e...7f2a497. Read the comment docs.

Do we need to (can we?) reap child processes to avoid zombie processes?


parse error with per hour task

My contab config is */60 8-21 * * * which should run per 60 min.
version: v0.1.6
OS version: Debian GNU/Linux 9 (stretch)
debug info :
DEBU[2018-12-12T14:19:58+08:00] try parse(7): */60 8-21 * * * /bin/bash -l -c 'my_cmd >> /opt/log/cron.log 2>&1'[0:28] = */60 8-21 * * * /bin/bash -l
DEBU[2018-12-12T14:19:58+08:00] try parse(6): */60 8-21 * * * /bin/bash -l -c 'my_cmd >> /opt/log/cron.log 2>&1'[0:25] = */60 8-21 * * * /bin/bash
DEBU[2018-12-12T14:19:58+08:00] try parse(5): */60 8-21 * * * /bin/bash -l -c 'my_cmd >> /opt/log/cron.log 2>&1'[0:15] = */60 8-21 * * *
DEBU[2018-12-12T14:19:58+08:00] try parse(1): */60 8-21 * * * /bin/bash -l -c 'my_cmd >> /opt/log/cron.log 2>&1'[0:4] = */60
FATA[2018-12-12T14:19:58+08:00] bad crontab line: */60 8-21 * * * /bin/bash -l -c 'my_cmd >> /opt/log/cron.log 2>&1'

The */60* represents "at minute 0 in an hour, the every 60 minutes thereafter", but considering the cron expression breaks down minutes and hours into separate intervals, it's not valid, because 60 minutes after the first minute, you're no longer in the same hour.
What you're looking for is:
0 8-21 * * *

OK, thanks 😄

OK, thanks 😄

You're welcome :smile:


[vm/ffi] arm64 --use-slow-path crash

/==============================================================\
| ffi/function_test/2 is new and failed (Crash, expected Pass) |
\==============================================================/

--- Command "vm" (took 04.000988s):
DART_CONFIGURATION=ReleaseXARM64 out/ReleaseXARM64/dart --use-slow-path --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/ffi/function_test.dart

exit code:
-6

stdout:
SumPlus42(3, 4)
returning 49

stderr:
===== CRASH =====
si_signo=Segmentation fault(11), si_code=1, si_addr=0xaaaad199d10000
version=2.3.2-edge.e1a7ef52afbbf4d8978508aa9bec554e88866a21 (Thu Jun 6 15:12:02 2019 +0000) on "linux_arm64"
thread=23402, isolate=main(0xaaaaffbb4100)
  pc 0x00aaaad199d10000 fp 0x0000ffff8207e148 Unknown symbol
  pc 0x0000ffff8237cab4 fp 0x0000ffff8207e180 Unknown symbol
  pc 0x0000ffff8237a6ac fp 0x0000ffff8207e1d0 Unknown symbol
  pc 0x0000ffff82379730 fp 0x0000ffff8207e200 Unknown symbol
  pc 0x0000ffff8237951c fp 0x0000ffff8207e238 Unknown symbol
  pc 0x0000ffff82379374 fp 0x0000ffff8207e268 Unknown symbol
  pc 0x0000ffff82378328 fp 0x0000ffff8207e2a8 Unknown symbol
  pc 0x0000ffff8234ce3c fp 0x0000ffff8207e2e0 Unknown symbol
  pc 0x0000ffff82377f1c fp 0x0000ffff8207e318 Unknown symbol
  pc 0x0000ffff833c1cb0 fp 0x0000ffff8207e3e8 Unknown symbol
  pc 0x0000aaaad13f7438 fp 0x0000ffff8207e490 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long)
  pc 0x0000aaaad13fab38 fp 0x0000ffff8207e500 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&)
  pc 0x0000aaaad143018c fp 0x0000ffff8207e710 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >)
  pc 0x0000aaaad14611fc fp 0x0000ffff8207e790 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)
  pc 0x0000aaaad1461a28 fp 0x0000ffff8207e800 dart::MessageHandler::TaskCallback()
  pc 0x0000aaaad159d554 fp 0x0000ffff8207e840 dart::ThreadPool::Worker::Loop()
  pc 0x0000aaaad159d384 fp 0x0000ffff8207e880 dart::ThreadPool::Worker::Main(unsigned long)
  pc 0x0000aaaad15050f4 fp 0x0000ffff8207e930 out/ReleaseXARM64/dart+0x16cb0f4
  pc 0x0000ffff83a09fc4 fp 0x0000ffff8207e940 /lib/aarch64-linux-gnu/libpthread.so.0+0x6fc4
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-linux-release-arm64 ffi/function_test/2

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8911388157230639968/+/steps/test_results/0/logs/tests_that_began_failing__logs_/0

cause: https://github.com/dart-lang/sdk/commit/e1a7ef52afbbf4d8978508aa9bec554e88866a21
It's during slow the safepoint exit that the crash happens, commenting out the use slow path flag stops the crash.
  // if (!FLAG_use_slow_path) {
  movz(addr, Immediate(compiler::target::Thread::safepoint_state_offset()), 0);
  add(addr, THR, Operand(addr));
  Bind(&retry);
  ldxr(state, addr);
  cmp(state, Operand(Thread::safepoint_state_acquired()));
  b(&slow_path, NE);

  movz(state, Immediate(Thread::safepoint_state_unacquired()), 0);
  stxr(TMP, state, addr);
  cbz(&done, TMP);  // 0 means stxr was successful.
  b(&retry);
  // }

Using the slow path for entering safepoint is fine. What is different between entering and exiting safepoint?

Hm, this slow path should have never worked before.
  Bind(&slow_path);
  ldr(addr,
      Address(THR, compiler::target::Thread::exit_safepoint_stub_offset()));
  ldr(addr, FieldAddress(TMP, compiler::target::Code::entry_point_offset()));
  blr(addr);

TMP should have been addr.
  Bind(&slow_path);
  ldr(addr,
      Address(THR, compiler::target::Thread::exit_safepoint_stub_offset()));
  ldr(addr, FieldAddress(addr, compiler::target::Code::entry_point_offset()));
  blr(addr);

But fixing that still hits a seg fault.

Flutter has a script for running GDB on the phone:
https://github.com/flutter/engine/blob/master/sky/tools/flutter_gdb

There's a bug in GenerateEnterSafepointStub and GenerateExitSafepointStub: they don't save the (volatile) Dart stack pointer before calling into C, but expect it to be set correctly afterward.
In addition, GenerateExitSafepointStub assumes the Dart stack pointer is set on entry, which it's not (only the C stack pointer is set).

@dcharkes I'll take this one since it doesn't look related to #37241


Can't open hexdump in 'open editors'

This is a known issue, VSCode do not allow to add commands to the 'Open Editors' section yet (see issue #1)

Closing it for now. Until VSCode fix the issue, please use the 'Show Hexdump' icon

But I can't find that icon, at the top-right corner of editor. How to display it? @stef-levesque

Please make use you are using VSCode 1.7.1 and vscode-hexdump 1.1.3

Got it. Thank you!


chore: added recoomeded changes

added notfound page and loading page
updated navlink
updated registration form

@ayussh-2

correct the spelling of referral

undertaking link in the form is not working

undertaking link in the form is not working

Not provided by them


Check for kernel lockdown only in mlx plugin

We need to check for the kernel lockdown only in
the mlx plugin.
if the firmware in the mlx card is already configured as needed we can allocate virtual functions even if the system is in lockdown

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 38.324%

Files with Coverage Reduction
New Missed Lines
%

pkg/host/mock/mock_host.go
10
31.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4794

Relevant Lines:
12509

💛  - Coveralls

@e0ne @ykulazhenkov please take a look this can be a way to make the sriov-operator work with mlx cards in secure mode.
in general the idea is

the user configure the max number of vfs he wants in the firmware as part of the installation process (not secure boot)
switch the system to secure boot
install the operator with disablePlugin option for mlx
create the sriovNetworkNodePolicy as always


feat: delete orphan nodes by traversing trees

Don't need the orphan bookkeepings.
Consequences
Positives

don't need to store and maintain the orphan records.

smaller db size
faster set/delete operations

Negatives

The pruning operation should be slower than current approach, especially pruning by range, the theoretical complexity should be the same, O(N) where N is the size of orphaned nodes, but the constant factor is heavier, the new approach need to load the nodes, while the old approach just iterate orphan records and delete nodes by hashes.

Alternative
If it's considered too controversial to downgrade performance of online pruning, an alternative is to just provide an option to not storing the orphan records for archive nodes, who can always do pruning offline using the algorithm described here.

@yihuang , this PR looks like it conflicted with my work. And your approach is not working on the current iavl structure. I think it is possible under the assumption of keeping always the range versions, right?

for example, we are keeping the versions of 3, 5, 7, 9.
In that case, you can remove version 5?

for example, we are keeping the versions of 3, 5, 7, 9. In that case, you can remove version 5?

yes, by diff 5 and 7, delete orphaned nodes whose version > 3.

I think it doesn't work properly, for example we have version 2 node in version 5, this node is removed in version 7, so it become orphaned, when will remove this node (version 2)?

for example, we are keeping the versions of 3, 5, 7, 9. In that case, you can remove version 5?

yes, by diff 5 and 7, delete orphaned nodes whose version > 3.

I think it doesn't work properly, for example we have version 2 node in version 5, this node is removed in version 7, so it become orphaned, when will remove this node (version 2)?

yeah, you have a point.

yeah, you have a point.

This is why the current orphans keep fromVersion and toVersion fields, To remove orphans completely, we should assume keeping only the range of versions (for example 1000 - 1100, 1100 is the latest version, 1000 is the oldest available version)

please refer https://github.com/cosmos/cosmos-sdk/issues/12989

yeah, you have a point.

This is why the current orphans keep fromVersion and toVersion fields, To remove orphans completely, we should assume keeping only the range of versions (for example 1000 - 1100, 1100 is the latest version, 1000 is the oldest available version)

What do you think if we delete the orphaned nodes whose version is removed, maybe not so bad if the versions are cached in memory.

What do you think if we delete the orphaned nodes whose version is removed, maybe not so bad if the versions are cached in memory.

not sure for me, we already had same issues when load all versions in the archive node, so I am suggesting keep only the first and last version instead of versions map, for pruning it will provide only delete the first version one by one

tbh, the lazy mode is unclear to me. When will trigger the lazy load or function?

tbh, the lazy mode is unclear to me. When will trigger the lazy load or function?

Whenever you need the root information of a particular version, get from cache or load from db?

@yihuang , this PR looks like it conflicted with my work.

I don't know about that, do you think this approach make sense, what's difference with your plan?

Sorry, I don't know about that, I thought you are working for solutions for the new node key format.
Do you think this approach make sense, what's the difference with your plan?

Never mind, I'd like to refactor the diff algorithm.
// Traverse the subtree with a given node as the root.
func (ndb *nodeDB) traverseTree(hash []byte, fn func(node *Node) (bool, error)) error {
	if len(hash) == 0 {
		return nil
	}

	node, err := ndb.GetNode(hash)
	if err != nil {
		return err
	}

	stop, err := fn(node)
	if err != nil || stop {
		return err
	}

	if node.leftHash != nil {
		if err := ndb.traverseTree(node.leftHash, fn); err != nil {
			return err
		}
	}
	if node.rightHash != nil {
		if err := ndb.traverseTree(node.rightHash, fn); err != nil {
			return err
		}
	}

	return nil
}

func (ndb *nodeDB) deleteOrphans(version int64) ([][]byte, error) {
	nRoot, err := ndb.getRoot(version + 1)
	if err != nil {
		return nil, err
	}

	originalNodes := make([]*Node, 0)
	if err := ndb.traverseTree(nRoot, func(node *Node) (bool, error) {
		if node.version > version {
			return false, nil
		}
		originalNodes = append(originalNodes, node)
		return true, nil
	}); err != nil {
		return nil, err
	}

	cRoot, err := ndb.getRoot(version)
	if err != nil {
		return nil, err
	}

	index := 0
	if err := ndb.traverseTree(cRoot, func(node *Node) (bool, error) {
		if index < len(originalNodes) && bytes.Equal(node.hash, originalNodes[index].hash) {
			index++
			return true, nil
		}
		if err = ndb.batch.Delete(ndb.nodeKey(node.hash)); err != nil {
			return true, err
		}
		return false, nil
	}); err != nil {
		return nil, err
	}
	return orphans, err
}

Loading all orphans in memory is so expensive, and also your implementation looks complicated.

FYI, removing orphans will impact node key refactoring, this is why I am interested in your PR.

Loading all orphans in memory is so expensive, and also your implementation looks complicated.

My algorithm is mainly try to skip the common subtrees early on, so we only need to traverse the branches contains actual differences.

To help understanding the algorithm, i created some visualizations:
The example iavl tree, with versions 4 and 5, the nodes are labaled as $VERSION: $KEY\nheight: $HEIGHT:
example-tree.pdf
The pruning graph, it contains all the nodes visited by the algorithm, the deleted nodes have dotted lines, you can notice there are two nodes coming from version 2 and 3 which are not deleted:
pruning-graph.pdf

curious to hear if there is a performance improvement with this over what exists?

curious to hear if there is a performance improvement with this over what exists?

The pruning operation is definitely slower than current one, which just iterate the maintained orphan records, the new methods need to load some nodes to partially traverse the tree.
The main advantages are:

db size reduction, don't need to store the orphan records.
main operations faster, don't need to calculate and insert the orphan records.

curious to hear if there is a performance improvement with this over what exists?

The pruning operation is definitely slower than current one, which just iterate the maintained orphan records, the new methods need to load some nodes to partially traverse the tree. The main advantages are:

db size reduction, don't need to store the orphan records (24% reduction in my test on our testnet rocksdb node).
main operations faster, don't need to calculate and insert the orphan records.

can you provide benchmarks on the slow down. I think there is some margin of slow down for a trade off that could be accepted and with fast node system it shouldn't make a difference

curious to hear if there is a performance improvement with this over what exists?

The pruning operation is definitely slower than current one, which just iterate the maintained orphan records, the new methods need to load some nodes to partially traverse the tree. The main advantages are:

db size reduction, don't need to store the orphan records (24% reduction in my test on our testnet rocksdb node).
main operations faster, don't need to calculate and insert the orphan records.

can you provide benchmarks on the slow down. I think there is some margin of slow down for a trade off that could be accepted and with fast node system it shouldn't make a difference

sure, I'll do them next week, the basic intuition is it depends by a lot on the node cache, if we are pruning a recent version whose orphaned nodes are still hot in the node cache, then it'll be pretty fast.

@tac0turtle @cool-develope I'm closing this PR for following reasons:

@cool-develope 's diff algorithm in #646 is simpler, I've tried it in python-iavl, both algorithm visits the same number of nodes, but #646 is simpler to implement. Although I think there's some issues with tree visit order which I've left comments in the PR.
We can already start deleting orphan records now for archive nodes even without this PR, when needed we can already create separate offline tools to do the pruning.
we can focus the discussion in #646, about the best long term solution.


CI/CD: Format Python Code

Context?
GitHub workflows can be used to automate some tasks which would generally take time doing manually and are better automated.
What to do?
Create workflows for some common scenarios like:

Checking whether code builds successfully in pull requests and when PRs are merged in master branch. See - #4
Running tools like Black and Pylint in PRs to keep clean code. See - #5

Resources:

A guide on GitHub actions and workflows - https://docs.github.com/en/actions
GitHub workflows syntax guide - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions
Python formatting tools - Black Pylint

NOTE
Try picking any one of the scenario and comment on the respective issues to show your interest. We'll assign it to you.

Hey @elle-Bee, I would like to work on this issue.

Hey @harshau007 are you contributing through KWOC?

Hey @harshau007 are you contributing through KWOC?

Yes

Cool, I'll assign it to you once the coding period officially starts. :)

Okk 👍


Power BI report server version numbers don't match each other or the changelog versions

In the changelog for the January release(s) of the report server component we have these versions/builds:
Version 1.4.6969.7395 (Build 15.0.1102.235), Released: January 30, 2019
Version 1.4.6960.38798 (Build 15.0.1102.222), Released: January 22, 2019
Neither of those are shown in my Report server configuration manager having applied the first Jan release.  Report Server configuration manager show Product Version: <IP_ADDRESS>0
Furthermore when navigating to the web portal Help/About we see a much earlier build version:
Version 1.3.6801.38816 (August 2018)  [this is for the Jan release]
Please can these be aligned properly as it makes roll out/troubleshooting unnecessarily difficult.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef9c2df3-28df-34d8-bd4e-4209996f7f8d
Version Independent ID: e5dc42c8-b17a-4e0e-09c5-76124b0ad924
Content: Changelog for Power BI Report Server - Power BI
Content Source: powerbi-docs/report-server/changelog.md
Service: powerbi
GitHub Login: @jtarquino
Microsoft Alias: jtarquino

Hi, @robrien6 -- thanks for asking. I've assigned your question to the author, who will reply soon. Thanks!

Thanks, this have been updated for the latest release of PBIRS May

Thanks, @jtarquino. Closing this issue now.


Smart contracts health badges

Badges is a representation of smart contracts security health status.
Badges library: https://github.com/jongracecox/anybadge
TODO:

[ ] Place status text to rectangle: Mythril-Scanner: passed|minors issues|critical issues
[ ] Change color regarding badge status (badge status described bellow)

Badge statuses:

Green  - no issues
Yellow - there are minor issues
Red - there are critical issues

Badges API:
method: GET
endpoint: `/badge/github/<repo_owner>/<repo_name>`

Badges usage
[Mythril Scanner Badge](http://methrylscan.com/badge/github/<repo_owner>/<repo_name>)

Basic badges: success and fail added.
Should consider a way to store badges:

Pre-generate all possible badges
Generate badge via PIL on badge requests (not prefered way)

Found badge generator package: https://github.com/jongracecox/anybadge

@Big-Bo99 looks cool, lets use it : )

Badges was added.


Add commit hash to local builds

Contributor Comments
Add commit hash to local builds.  This reduces local build confusion between versioned docker images that have been released, and locally built docker images.
Pull Request Checklist
Thank you for submitting a contribution to easy_infra!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

[X] Rebase your branch against the latest commit of the target branch
[X] If you are adding a dependency, please explain how it was chosen
[X] If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
[X] If there is an issue associated with your Pull Request, align your PR
title with this documentation

After running pipenv install --dev  I still had to install gitpython.

@callmestu 🤔 it is specified in the Pipfile and Pipfile.lock

I would also like to know why I'm hitting this. Looking into it this morning, pipenv shell was activating an environment for another project/repo: IaC Scanning, where I was last working. After deleting easy_infra repo, cloning a new copy and running pipenv install --dev, things look good in pipenv graph where I can see both GitPython==3.1.24 and syft 0.6.0.
Seems better, but not sure why that happened.


Ignore git conflict markers when parsing formatting hints from any existing cabal files

(related to #252)
e.g. if we see
foo
<<<<<<< 4a1ca1694ed77195a080688df9bef53c23045211
bar2
=======
bar1
>>>>>>> update foo on branch foo
baz

we want to treat it as
foo
bar2
baz

to minimize the diff against the branch we rebase on.

Going one step further, we could even remove the conflict markers before doing the hash check.  That way a user can run hpack without -f to regenerate when there is a conflict in .cabal on git rebase.
I think this is what I want!  Despite all the merits of the hash check, it really really annoys me on git rebase.  With this approach we can have both, the hash check and seamless rebasing.


amazonec2: Could not create a docker cluster with docker 1.12.0-rc3

I tried to create a docker cluster using swarm mode of docker 1.12.0.
docker-machine create --engine-install-url https://experimental.docker.com --driver amazonec2 --amazonec2-region ap-northeast-2 --amazonec2-instance-type t2.nano aws-manager1
docker-machine create --engine-install-url https://experimental.docker.com --driver amazonec2 --amazonec2-region ap-northeast-2 --amazonec2-instance-type t2.nano aws-manager2
docker-machine ssh aws-manager1 sudo docker swarm init
docker-machine ssh aws-manager2 sudo docker swarm join --listen-addr `docker-machine ip aws-manager2`:2377 `docker-machine ip aws-manager1`:2377

Then I got this error:
Error response from daemon: Timeout was reached before node was joined. Attempt to join the cluster will continue in the background. Use "docker info" command to see the current Swarm status of your node.

The machines seem to be healthy:
NAME           ACTIVE   DRIVER       STATE     URL                         SWARM   DOCKER        ERRORS
aws-manager1   *        amazonec2    Running   tcp://<IP_ADDRESS>:2376              v1.12.0-rc3
aws-manager2   -        amazonec2    Running   tcp://<IP_ADDRESS>:2376             v1.12.0-rc3

It works after I open some ports as the docker document says:

Open ports between the hosts
TCP port 2377 for cluster management communications
TCP and UDP port 7946 for communication among nodes
TCP and UDP port 4789 for overlay network traffic
-- https://docs.docker.com/engine/swarm/swarm-tutorial/#open-ports-between-the-hosts

Thanks @npcode -- please try again w/ official release

I, too, had to manually go into aws to open ports for this to work.
$ docker version
Client:
 Version:      1.12.6
 API version:  1.24
 Go version:   go1.7.4
 Git commit:   78d18021ec
 Built:        Thu Jan 12 11:41:27 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.6
 API version:  1.24
 Go version:   go1.6.4
 Git commit:   78d1802
 Built:        Tue Jan 10 20:38:45 2017
 OS/Arch:      linux/amd64

$ docker-machine version
docker-machine version 0.9.0-rc2, build 7b19591


Model saving timeout

Hi, thanks for this library !
I have an issue when trying to save a big model (vocab size of 10 millions), I'm hitting the 5 minutes timeout of this line of code :
val savedFuture = matrix.save(path, sc.hadoopConfiguration)
Await.ready(savedFuture, 5 minutes)

Is it an issue on my side or should the 5 minutes be configurable ?

Hi,
a vocab size of 10 million should probably not be the problem. The evaluation I did (https://github.com/MGabr/evaluate-glint-word2vec/blob/master/project_report.pdf) was with a vocab size of a vocab size of 8.7 million.
Which number of executors and executor cores are you using?
Did you start the parameter servers as separate Spark application?
Best regards,
Markus

I followed your setup in this report, which is a parameter server launch in a separate Spark application with 5 executors of 16 cores and 20g of RAM. Then I launched another app with 20 executors of 16 cores and 20g of RAM.
I used 5 parameter servers and a vector size of 100.
Just to be sure in order to use the separate parameter server i just need to pass the IP address of the driver from the spark app containing the parameter server to the model as a string ? Or do you I need to add a port ?
val word2vec = new ServerSideGlintWord2Vec()
.setParameterServerHost("GLINT.DRIVER.IP.ADDRESS")
.setNumParameters(5)

Ok, your settings seem to be fine. The IP address is also set correctly and if there was an issue with it there would be an error earlier on before save.
I had an issue in another project using the parameter servers (not Word2Vec) where save timed out but other requests to the parameter servers still worked. I haven't been able to fix this. I'm not sure if this is related though.
In any case, parameter server errors are not passed on, so the timeout may also be caused by the servers failing to save to the given HDFS path. Does saving a model with a small vocab size to the same path work for you?

Yeah when I setup a higher mincount to reduce my vocabulary (2 million), my model was perfectly saved to hdfs (the matrix and the vocab). With my complete vocab, only the vocab is stored in the hdfs when saving the model.
Thanks for helping me ! I'm gonna try again this weekend.

Yeah, then I fear this is the same problem as in my other project. If a vocab size of 10 million and a dimension of 100 is all you need you can still call model.toLocal to pull all the word vectors from the parameter servers and create a common Spark Word2Vec model with them. This would even be a cleaner approach since you then don't need parameter servers at transformation time, but this only works for word vector matrices of size up to 8GB due to Spark's broadcast limit and you need enough memory on the executors.
For larger matrices I might this weekend add an experimental model which pulls the word vectors into an RDD and joins this RDD at transformation time. I wouldn't be able to check the performance of this join approach at the moment though.

I'm gonna try that. Thanks for the help ! Nice library !
Indeed having a RDD instead of a broadcasted model will be slower but at least it's gonna scale to bigger model.


[Fix] Handle non-SVG chain icons correctly in opengraph-image component

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
The focus of this PR is to handle SVG icons in opengraph images.
Detailed summary

Added check for SVG icons in opengraph-image.tsx
Updated logic to download chain icon based on format
Adjusted rendering condition for chain icon in the component

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3799  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite


Move light 2D rotation to vertex shader

I now realized I was doing the light transformation in the fragment shader. I moved it to the vertex shader to improve performance. Sorry for the PR spam :)

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


[#1908] Fix: In HadoopCatalogOperations.java field entity is not used

What changes were proposed in this pull request?
Removed the unused entity variable in the alterSchema method of HadoopCatalogOperations.java. The refactored code now directly updates the schema and retrieves the updated schema entity for returning.
Why are the changes needed?
The entity variable was assigned but never used, which was flagged as a possible bug.
Removing this unused variable makes the code cleaner and easier to maintain.
Fix: #1908
Does this PR introduce any user-facing change?
No, this PR does not introduce any user-facing changes.
How was this patch tested?

Ensured all existing tests related to schema operations pass successfully.
Manually verified the functionality of schema updates to confirm no regressions were introduced.

@poojatalele
Please resolve the code format problem, more detail can be seen in the output of CI.

@poojatalele Please resolve the code format problem, more detail can be seen in the output of CI.

Can you please help me with this?

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

Pls check now once

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

Pls check now once @justinmclean

Any update?


Various github action fixes

actions: twister: apply a new strategy from smaller test plans
actions: twister: run tests on all platforms when changed
actions: twister: load modules from cache
actions: twister: upload testplan as an artifact
actions: twister: do not schedule on non main branches
actions: twister: limit daily job to 60 builders

actions: twister: run tests on all platforms when changed is a hotfix, without it, we are skipping lots of tests and merging broken tests.


System.ArgumentException: An item with the same key has already been added

The fix is to remove the name Firebird from the json schema file (in one spot):

Originally posted by @R4ND3LL in https://github.com/R4ND3LL/EntityFrameworkRuler/issues/20#issuecomment-1472123339
ok, I removed Firebird from schema and now I get an System.ArgumentException:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.ArgumentException: An item with the same key has already been added. Key: FOO
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
 at EntityFrameworkRuler.Design.Services.Models.DbContextRuleNode.Map(EntityTypeBuilder entityTypeBuilder, EntityRuleNode entityRule)
   at EntityFrameworkRuler.Design.Services.Models.EntityRuleNode.MapTo(EntityTypeBuilder builder, DatabaseTableNode databaseTable)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.ApplyEntityRules(ModelBuilder modelBuilder, EntityTypeBuilder entityTypeBuilder, DatabaseTable table, EntityRuleNode entityRuleNode)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.VisitTable(ModelBuilder modelBuilder, DatabaseTable table, Func`1 baseCall)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Castle.DynamicProxy.IInterceptor.Intercept(IInvocation invocation)
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.VisitTable(ModelBuilder modelBuilder, DatabaseTable table)
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.InvokeVisitTable(ModelBuilder modelBuilder, DatabaseTable table)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.<VisitTables>g__DoInvokeVisitTable|34_0(DatabaseTableNode table, EntityRuleNode entityRule, <>c__DisplayClass34_0& )
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.VisitTables(ModelBuilder modelBuilder, ICollection`1 tables)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Castle.DynamicProxy.IInterceptor.Intercept(IInvocation invocation)
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.VisitTables(ModelBuilder modelBuilder, ICollection`1 tables)
   at Microsoft.EntityFrameworkCore.Scaffolding.Internal.RelationalScaffoldingModelFactory.VisitDatabaseModel(ModelBuilder modelBuilder, DatabaseModel databaseModel)
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.VisitDatabaseModel_callback(ModelBuilder modelBuilder, DatabaseModel databaseModel)
   at Castle.Proxies.Invocations.RelationalScaffoldingModelFactory_VisitDatabaseModel.InvokeMethodOnTarget()
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.<>c__DisplayClass57_0.<Castle.DynamicProxy.IInterceptor.Intercept>g__BaseCall|2()
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.VisitDatabaseModel(ModelBuilder modelBuilder, DatabaseModel databaseModel, Func`1 baseCall)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Castle.DynamicProxy.IInterceptor.Intercept(IInvocation invocation)
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.VisitDatabaseModel(ModelBuilder modelBuilder, DatabaseModel databaseModel)
   at Microsoft.EntityFrameworkCore.Scaffolding.Internal.RelationalScaffoldingModelFactory.Create(DatabaseModel databaseModel, ModelReverseEngineerOptions options)
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.Create_callback(DatabaseModel databaseModel, ModelReverseEngineerOptions options)
   at Castle.Proxies.Invocations.RelationalScaffoldingModelFactory_Create.InvokeMethodOnTarget()
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.<>c__DisplayClass57_0.<Castle.DynamicProxy.IInterceptor.Intercept>g__BaseCall|7(DatabaseModel databaseModel, ModelReverseEngineerOptions options2)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Create(DatabaseModel databaseModel, ModelReverseEngineerOptions ops, Func`3 baseCall)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Castle.DynamicProxy.IInterceptor.Intercept(IInvocation invocation)
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Castle.Proxies.RelationalScaffoldingModelFactoryProxy.Create(DatabaseModel databaseModel, ModelReverseEngineerOptions options)
   at EntityFrameworkRuler.Design.Services.RuledRelationalScaffoldingModelFactory.Create(DatabaseModel databaseModel, ModelReverseEngineerOptions ops)
   at Microsoft.EntityFrameworkCore.Scaffolding.Internal.ReverseEngineerScaffolder.ScaffoldModel(String connectionString, DatabaseModelFactoryOptions databaseOptions, ModelReverseEngineerOptions modelOptions, ModelCodeGenerationOptions codeOptions)
   at EntityFrameworkRuler.Design.Services.RuledReverseEngineerScaffolder.ScaffoldModel(String connectionString, DatabaseModelFactoryOptions databaseOptions, ModelReverseEngineerOptions modelOptions, ModelCodeGenerationOptions codeOptions)
   at Microsoft.EntityFrameworkCore.Design.Internal.DatabaseOperations.ScaffoldContext(String provider, String connectionString, String outputDir, String outputContextDir, String dbContextClassName, IEnumerable`1 schemas, IEnumerable`1 tables, String modelNamespace, String contextNamespace, Boolean useDataAnnotations, Boolean overwriteFiles, Boolean useDatabaseNames, Boolean suppressOnConfiguring, Boolean noPluralize)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.ScaffoldContextImpl(String provider, String connectionString, String outputDir, String outputDbContextDir, String dbContextClassName, IEnumerable`1 schemaFilters, IEnumerable`1 tableFilters, String modelNamespace, String contextNamespace, Boolean useDataAnnotations, Boolean overwriteFiles, Boolean useDatabaseNames, Boolean suppressOnConfiguring, Boolean noPluarlize)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.ScaffoldContext.<>c__DisplayClass0_0.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)

I can't really share this EDMX from a real software, not the employee sample db (european data protection).

ok, it also happens with the employee db:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.ArgumentException: An item with the same key has already been added. Key: COUNTRY
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)

Candidate Naming Service resolved DB Context Rules for Entities with 2 schemas

I suspect your json file now has 2 schemas with the Name "".
When you run the scaffolding, EFR will update the json and populate the file with found entities. Meaning even if you start with a blank json, it will populate it fully with all entities so that you can modify later as necessary.
So either regenerate the json from EDMX (and rename the schema again), or nuke the second schema.

By the way, if you try the Visual Studio extension then the UI editor would have caught this duplicating naming issue and prevented the change.

Candidate Naming Service resolved DB Context Rules for Entities with 2 schemas

I suspect your json file now has 2 schemas with the Name "".

yes, because of the table not found issue, I added the option to include unknown schemas, this generated 2 schemas and if I rename firebird to empty I get 2 schemas with empty name which triggers the error.
Thanks for the help and your tool.


WIP: Keyword parameters

#20

@bryanrite this seems to be working quite well, and incidentally supports mixed parameters (though I would not recommend anyone doing that).

@bryanrite this might be GTG, please take a look.


[BEAM-2431] Add GRPC to Compilation of the Runner API

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Generates the JobService GRPC classes.

R: @sb2nov

LGTM if tests pass.

retest this please

retest this please

AMQPIOTest seems to be timing out; I don't believe the two are related, but I'm going to give it one more go before investigating further.

Coverage decreased (-0.2%) to 69.975% when pulling 006db74b0b14f36a833840a16fdf68d37e79bb89 on tgroh:job_submission_api_java into f731de0b357bc5eccee565271ade96e1946bf0bd on apache:master.


no-resource-limits-pods rule uses limit instead of limits

Describe the bug
The no-resource-limits-pods rule uses container.resources.limit instead of container.resources.limits
To Reproduce
Steps to reproduce the behavior:

Go to 'Rule Editor'
Click on 'no-resource-limits-pods' rule
Go to 'Rule script' tab
See error

Environment Details:

Kubernetes Distribution/Version [e.g. GKE v1.13.12-gke.25, OpenShift 4.3] AKS v1.19.3
Browser [e.g. chrome, safari] Chrome
Version [e.g. v0.3] 0.8.15

@mleneveut, what kind of error are you seeing? Is it a red expandable error bar on the top? It would be great to see the error bar expanded as a screenshot, or just text copy. Also, please check for errors for kubevious-backend pod.

@mleneveut, fixed in version 0.9.9. Unfortunately since that is just a default, upgrade over existing deployments wouldn't fix the rule. Any new deployments would have the correct rule. Thanks for submitting the issue.
helm upgrade --atomic -i kubevious kubevious/kubevious --version 0.9.9 -n kubevious


Time always shows one hour early

Hi the time always seems to show 1 hour early. Im here in the Uk. I am already using a custom layout
`  public class MetroLogLayout : Layout
{
  public override string GetFormattedString(LogWriteContext context, LogEventInfo info)
  {
      return $"{info.TimeStamp:G} - {info.Level}: {info.Message}";
  }

}
Any ideas?`

Time is UTC