doc: Documentation issue in 'boards/espressif/esp32_devkitc_wroom/doc/index'

Describe the bug
(.venv) C:\Users\KALYAN\zephyrproject\zephyr>west espressif monitor
Serial port COM9
Connecting...
COM9 failed to connect: Write timeout
Serial port COM6
Connecting...............
Detecting chip type... Unsupported detection protocol, switching and trying again...
Connecting.....
Detecting chip type... ESP32
Traceback (most recent call last):
File "C:\Users\KALYAN\zephyrproject\zephyr..\modules\hal\espressif\tools\idf_monitor.py", line 34, in
import serial
ModuleNotFoundError: No module named 'serial'
Traceback (most recent call last):
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 505, in run_command
self.run_extension(args.command, argv)
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 654, in run_extension
self.cmd.run(args, unknown, self.topdir, manifest=self.manifest,
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\commands.py", line 194, in run
self.do_run(args, unknown)
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 165, in do_run
self.monitor(module_path, args)
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 184, in monitor
cmd_exec(("python.exe", monitor_path, "-p", esp_port,
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 40, in cmd_exec
return subprocess.check_call(cmd, cwd=cwd, shell=shell)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python311\Lib\subprocess.py", line 413, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '('python.exe', WindowsPath('C:/Users/KALYAN/zephyrproject/zephyr/../modules/hal/espressif/tools/idf_monitor.py'), '-p', 'COM6', '-b', '115200', WindowsPath('C:/Users/KALYAN/zephyrproject/zephyr/build/zephyr/zephyr.elf'), '--eol', 'CRLF')' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\KALYAN\zephyrproject.venv\Scripts\west.exe_main.py", line 7, in
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 1085, in main
app.run(argv or sys.argv[1:])
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 244, in run
self.run_command(argv, early_args)
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 543, in run_command
f'{quote_sh_list(cpe.cmd)}', fatal=True)
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\util.py", line 42, in quote_sh_list
return ' '.join(shlex.quote(s) for s in cmd)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\util.py", line 42, in
return ' '.join(shlex.quote(s) for s in cmd)
^^^^^^^^^^^^^^
File "C:\Python311\Lib\shlex.py", line 329, in quote
if _find_unsafe(s) is None:
^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'WindowsPath'
Environment

Page: boards/espressif/esp32_devkitc_wroom/doc/index
Version: main
SHA-1: c0866030ebc9c0588eb349de34eb96af5317161e

I am facing this issue trying to serial monitor the hello_world code,facing no issue on flashing but monitor doesn't works,
can anyone suggest me resolve this issue.

Did you follow the setup instructions as per https://docs.zephyrproject.org/latest/develop/getting_started/index.html#get-zephyr-and-install-python-dependencies ?

C:\Windows\system32>cd %HOMEPATH%
C:\Users\KALYAN>python -m venv zephyrproject.venv
C:\Users\KALYAN>zephyrproject.venv\Scripts\activate.bat
(.venv) C:\Users\KALYAN>pip install west
Requirement already satisfied: west in c:\users\kalyan\zephyrproject.venv\lib\site-packages (1.2.0)
Requirement already satisfied: colorama in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west) (0.4.6)
Requirement already satisfied: PyYAML>=5.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west) (6.0.1)
Requirement already satisfied: pykwalify in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west) (1.8.0)
Requirement already satisfied: setuptools in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west) (65.5.0)
Requirement already satisfied: packaging in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west) (24.0)
Requirement already satisfied: docopt>=0.6.2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->west) (0.6.2)
Requirement already satisfied: python-dateutil>=2.8.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->west) (2.9.0.post0)
Requirement already satisfied: ruamel.yaml>=0.16.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->west) (0.18.6)
Requirement already satisfied: six>=1.5 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from python-dateutil>=2.8.0->pykwalify->west) (1.16.0)
Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from ruamel.yaml>=0.16.0->pykwalify->west) (0.2.8)
(.venv) C:\Users\KALYAN>west init zephyrproject
FATAL ERROR: already initialized in C:\Users\KALYAN, aborting.
Hint: if you do not want a workspace there,
remove this directory and re-run this command:
C:\Users\KALYAN.west
(.venv) C:\Users\KALYAN>cd zephyrproject
(.venv) C:\Users\KALYAN\zephyrproject>west update
=== updating acpica (modules/lib/acpica):
HEAD is now at da5f2721e Merge pull request #905 from najumon1980/acpi_timer
=== updating cmsis (modules/hal/cmsis):
HEAD is now at 4b96cbb doc: Update documentations for CMSIS 5.9.0
=== updating cmsis-dsp (modules/lib/cmsis-dsp):
HEAD is now at 6489e771 do not generate warnings when scalar functions are used with MVE
=== updating cmsis-nn (modules/lib/cmsis-nn):
HEAD is now at 0c8669d Merge pull request #1 from XenuIsWatching/zephyr
=== updating edtt (tools/edtt):
HEAD is now at 64e5105 edttt_bsim: Avoid infinite exception loop
=== updating fatfs (modules/fs/fatfs):
HEAD is now at 427159b zephyr: fix ffconf.h override use of STRINGIZE
=== updating hal_altera (modules/hal/altera):
HEAD is now at 0d225dd zephyr: update include paths to use <zephyr/...>
=== updating hal_ambiq (modules/hal/ambiq):
HEAD is now at ff4ca35 Stimer: remove disabling stmer's COMPARE interrupts in delta_set() api
=== updating hal_atmel (modules/hal/atmel):
HEAD is now at d6221e7 asf: CMakeLists.txt: Use new family prefix
=== updating hal_espressif (modules/hal/espressif):
HEAD is now at e705cc16c4 uart: add call to retrieve port_num by its register address
=== updating hal_ethos_u (modules/hal/ethos_u):
HEAD is now at 90ada2e Clarify README regarding CPU choice
=== updating hal_gigadevice (modules/hal/gigadevice):
HEAD is now at 2994b7d README.md: add pllmf and pack exception for gd32a50x
=== updating hal_infineon (modules/hal/infineon):
HEAD is now at b1a4723 hal: infineon: Update for hwmv2
=== updating hal_intel (modules/hal/intel):
HEAD is now at 7b4c256 iut: add -Werror to make all warnings into errors
=== updating hal_microchip (modules/hal/microchip):
HEAD is now at 68575aa CMakeLists: use MEC15XX for the series option
=== updating hal_nordic (modules/hal/nordic):
HEAD is now at 13ac55b nrfx: Update to version 3.4.0
=== updating hal_nuvoton (modules/hal/nuvoton):
HEAD is now at cf24f9e hal: nuvoton: support external dts or *.h of hal-M2L31X
=== updating hal_nxp (modules/hal/nxp):
HEAD is now at 3c4f74b4 devices: MCXN947: Update system file to remove SDK sepecific defines
=== updating hal_openisa (modules/hal/openisa):
HEAD is now at eabd530 fix-double-promotion in fsl_xcvr_trim
=== updating hal_quicklogic (modules/hal/quicklogic):
HEAD is now at b3a66fe Remove references to FPGA IP core drivers
=== updating hal_renesas (modules/hal/renesas):
HEAD is now at 991e060 hal: renesas: Update for hwmv2
=== updating hal_rpi_pico (modules/hal/rpi_pico):
HEAD is now at fba7162 Merge pull request #5 from soburi/zephyr_timer_modification
=== updating hal_silabs (modules/hal/silabs):
HEAD is now at 442d0fb gecko/cmake: replace 'SOC_GECKO_SERIESx' with 'SOC_FAMILY_SILABS_Sx'
=== updating hal_st (modules/hal/st):
HEAD is now at 0643d20 zephyr/module.yml: enable use of kconfig-ext
=== updating hal_stm32 (modules/hal/stm32):
HEAD is now at 60c9634f dts: New batch of pinctrl.dtsi files including SWJ signals
=== updating hal_telink (modules/hal/telink):
HEAD is now at 38573af B91 ADC driver support
=== updating hal_ti (modules/hal/ti):
HEAD is now at b85f86e simplelink: slnetsock: fix sys/time.h include when sockets are enabled
=== updating hal_wurthelektronik (modules/hal/wurthelektronik):
HEAD is now at e5bcb2e Update WE sensors SDK to version 2.5.0
=== updating hal_xtensa (modules/hal/xtensa):
HEAD is now at a2d6585 zephyr: rename SoC overlay for NXP i.MX8ULP
=== updating hostap (modules/lib/hostap):
HEAD is now at 9ad92f524 [toup] zephyr: Waiting semaphore was reset too late
=== updating libmetal (modules/hal/libmetal):
HEAD is now at 243eed5 lib: update libmetal to SHA f55c02a7b582
=== updating liblc3 (modules/lib/liblc3):
HEAD is now at 1a5938e meson: Bump to version 1.0.4
=== updating littlefs (modules/fs/littlefs):
HEAD is now at 408c16a Merge pull request #14 from de-nordic/update-to-v2.8.1
=== updating loramac-node (modules/lib/loramac-node):
HEAD is now at 1bf2120c mac: region: RegionCommon: fix implicit double promotion
=== updating lvgl (modules/lib/gui/lvgl):
HEAD is now at 2b76c641 release v8.3.11
=== updating mbedtls (modules/crypto/mbedtls):
HEAD is now at 6ec4abdcd Merge pull request #52 from ceolin/mbedtls-352
=== updating mcuboot (bootloader/mcuboot):
HEAD is now at 9fb7ce5d boot: zephyr: Fix estimated size calculation
=== updating mipi-sys-t (modules/debug/mipi-sys-t):
HEAD is now at a819419 library: allow building without wchar support
=== updating net-tools (tools/net-tools):
HEAD is now at 3a677d3 docker: Use fixed milestone release for Leshan
=== updating nrf_hw_models (modules/bsim_hw_models/nrf_hw_models):
HEAD is now at df94612 GPIO: Add test API to be notified on output changes
=== updating open-amp (modules/lib/open-amp):
HEAD is now at da78aea lib: update open-amp lib to release v2023.10.0
=== updating openthread (modules/lib/openthread):
HEAD is now at 49c59ec51 [mbedtls] make debug logging independent from builtin (#9848)
=== updating percepio (modules/debug/percepio):
HEAD is now at 7f6fb3f Merge branch 'main' into zephyr
=== updating picolibc (modules/lib/picolibc):
HEAD is now at 764ef4e40 Version 1.8.6
=== updating segger (modules/debug/segger):
HEAD is now at 9d01912 segger: config: RTT spinlock implementation
=== updating tinycrypt (modules/crypto/tinycrypt):
HEAD is now at 1012a3e Fix warnings reported by UBSAN
=== updating trusted-firmware-m (modules/tee/tf-m/trusted-firmware-m):
HEAD is now at 0b898c9b7 Platform: nxp: Add initialization flag to the CMSIS USART driver.
=== updating trusted-firmware-a (modules/tee/tf-a/trusted-firmware-a):
HEAD is now at 421dc0502 Merge pull request #3 from SgrrZhf/topics/huizha01/2.9.0-updates
=== updating uoscore-uedhoc (modules/lib/uoscore-uedhoc):
HEAD is now at 150f4eb [zephyr fromlist] Adapt to changes in name generation in zcbor 0.8.0
=== updating zcbor (modules/lib/zcbor):
HEAD is now at 75d0880 tests: Update mps2 board name
(.venv) C:\Users\KALYAN\zephyrproject>west zephyr-export
Zephyr (C:/Users/KALYAN/zephyrproject/zephyr/share/zephyr-package/cmake)
has been added to the user package registry in:
HKEY_CURRENT_USER\Software\Kitware\CMake\Packages\Zephyr
ZephyrUnittest (C:/Users/KALYAN/zephyrproject/zephyr/share/zephyrunittest-package/cmake)
has been added to the user package registry in:
HKEY_CURRENT_USER\Software\Kitware\CMake\Packages\ZephyrUnittest
(.venv) C:\Users\KALYAN\zephyrproject>pip install -r %HOMEPATH%\zephyrproject\zephyr\scripts\requirements.txt
Requirement already satisfied: pyelftools>=0.27 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 7)) (0.31)
Requirement already satisfied: PyYAML>=5.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 11)) (6.0.1)
Requirement already satisfied: pykwalify in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 14)) (1.8.0)
Requirement already satisfied: canopen in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 17)) (2.2.0)
Requirement already satisfied: packaging in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 18)) (24.0)
Requirement already satisfied: progress in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 19)) (1.6)
Requirement already satisfied: psutil in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 20)) (5.9.8)
Requirement already satisfied: pylink-square in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 21)) (1.2.0)
Requirement already satisfied: pyserial in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 22)) (3.5)
Requirement already satisfied: requests in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 23)) (2.31.0)
Requirement already satisfied: anytree in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 26)) (2.12.1)
Requirement already satisfied: intelhex in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 29)) (2.3.0)
Requirement already satisfied: west>=0.14.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 33)) (1.2.0)
Requirement already satisfied: windows-curses in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 37)) (2.3.2)
Requirement already satisfied: colorama in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 7)) (0.4.6)
Requirement already satisfied: ply>=3.10 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 10)) (3.11)
Requirement already satisfied: gcovr>=6.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 13)) (7.2)
Requirement already satisfied: coverage in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 14)) (7.4.4)
Requirement already satisfied: pytest in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 17)) (8.1.1)
Requirement already satisfied: mypy in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 18)) (1.9.0)
Requirement already satisfied: mock>=4.0.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 21)) (5.1.0)
Requirement already satisfied: pyocd>=0.35.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (0.36.0)
Requirement already satisfied: tabulate in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 9)) (0.9.0)
Requirement already satisfied: natsort in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 10)) (8.4.0)
Requirement already satisfied: cbor>=1.0.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 13)) (1.0.0)
Requirement already satisfied: bz in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 19)) (1.0)
Requirement already satisfied: gitlint in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 7)) (0.19.1)
Requirement already satisfied: junit2html in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 10)) (30.1.6)
Requirement already satisfied: clang-format>=15.0.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 13)) (18.1.1)
Requirement already satisfied: lpc_checksum in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 16)) (3.0.0)
Requirement already satisfied: Pillow>=10.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 19)) (10.2.0)
Requirement already satisfied: imgtool>=2.0.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 22)) (2.0.0)
Requirement already satisfied: grpcio-tools>=1.47.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 25)) (1.62.1)
Requirement already satisfied: protobuf>=3.20.3 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 26)) (4.25.3)
Requirement already satisfied: PyGithub in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 29)) (2.2.0)
Requirement already satisfied: graphviz in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 32)) (0.20.2)
Requirement already satisfied: zcbor>=0.8.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 35)) (0.8.1)
Requirement already satisfied: python-magic in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 4)) (0.4.27)
Requirement already satisfied: python-magic-bin in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 5)) (0.4.14)
Requirement already satisfied: lxml in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 6)) (5.1.0)
Requirement already satisfied: junitparser>=2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 7)) (3.1.2)
Requirement already satisfied: pylint in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (3.1.0)
Requirement already satisfied: yamllint in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from -r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 9)) (1.35.1)
Requirement already satisfied: docopt>=0.6.2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 14)) (0.6.2)
Requirement already satisfied: python-dateutil>=2.8.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 14)) (2.9.0.post0)
Requirement already satisfied: ruamel.yaml>=0.16.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pykwalify->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 14)) (0.18.6)
Requirement already satisfied: python-can>=3.0.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from canopen->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 17)) (4.3.1)
Requirement already satisfied: six in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylink-square->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 21)) (1.16.0)
Requirement already satisfied: charset-normalizer<4,>=2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from requests->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 23)) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from requests->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 23)) (3.6)
Requirement already satisfied: urllib3<3,>=1.21.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from requests->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 23)) (2.2.1)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from requests->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 23)) (2024.2.2)
Requirement already satisfied: setuptools in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from west>=0.14.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 33)) (65.5.0)
Requirement already satisfied: jinja2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gcovr>=6.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 13)) (3.1.3)
Requirement already satisfied: colorlog in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gcovr>=6.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 13)) (6.8.2)
Requirement already satisfied: pygments>=2.13.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gcovr>=6.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 13)) (2.17.2)
Requirement already satisfied: iniconfig in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pytest->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 17)) (2.0.0)
Requirement already satisfied: pluggy<2.0,>=1.4 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pytest->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 17)) (1.4.0)
Requirement already satisfied: typing-extensions>=4.1.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from mypy->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 18)) (4.10.0)
Requirement already satisfied: mypy-extensions>=1.0.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from mypy->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 18)) (1.0.0)
Requirement already satisfied: capstone<5.0,>=4.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (4.0.2)
Requirement already satisfied: cmsis-pack-manager<1.0,>=0.5.2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (0.5.3)
Requirement already satisfied: importlib-metadata>=3.6 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (7.0.2)
Requirement already satisfied: importlib-resources in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (6.3.2)
Requirement already satisfied: intervaltree<4.0,>=3.0.2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (3.1.0)
Requirement already satisfied: lark<2.0,>=1.1.5 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (1.1.9)
Requirement already satisfied: libusb-package<2.0,>=1.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (<IP_ADDRESS>)
Requirement already satisfied: prettytable<4.0,>=2.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (3.10.0)
Requirement already satisfied: pyusb<2.0,>=1.2.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (1.2.1)
Requirement already satisfied: hidapi<1.0,>=0.10.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (0.14.0)
Requirement already satisfied: gitlint-core==0.19.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gitlint-core[trusted-deps]==0.19.1->gitlint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 7)) (0.19.1)
Requirement already satisfied: arrow>=1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gitlint-core==0.19.1->gitlint-core[trusted-deps]==0.19.1->gitlint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 7)) (1.2.3)
Requirement already satisfied: click>=8 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from gitlint-core==0.19.1->gitlint-core[trusted-deps]==0.19.1->gitlint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 7)) (8.1.3)
Requirement already satisfied: cbor2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from imgtool>=2.0.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 22)) (5.6.2)
Requirement already satisfied: cryptography>=2.4.2 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from imgtool>=2.0.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 22)) (42.0.5)
Requirement already satisfied: grpcio>=1.62.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from grpcio-tools>=1.47.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 25)) (1.62.1)
Requirement already satisfied: pynacl>=1.4.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from PyGithub->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 29)) (1.5.0)
Requirement already satisfied: pyjwt>=2.4.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pyjwt[crypto]>=2.4.0->PyGithub->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 29)) (2.8.0)
Requirement already satisfied: Deprecated in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from PyGithub->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 29)) (1.2.14)
Requirement already satisfied: regex>=2022.3.15 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from zcbor>=0.8.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-extras.txt (line 35)) (2023.12.25)
Requirement already satisfied: platformdirs>=2.2.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (4.2.0)
Requirement already satisfied: astroid<=3.2.0-dev0,>=3.1.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (3.1.0)
Requirement already satisfied: isort!=5.13.0,<6,>=4.2.5 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (5.13.2)
Requirement already satisfied: mccabe<0.8,>=0.6 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (0.7.0)
Requirement already satisfied: tomlkit>=0.10.1 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (0.12.4)
Requirement already satisfied: dill>=0.3.6 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from pylint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 8)) (0.3.8)
Requirement already satisfied: pathspec>=0.5.3 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from yamllint->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-compliance.txt (line 9)) (0.12.1)
Requirement already satisfied: appdirs<2.0,>=1.4 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from cmsis-pack-manager<1.0,>=0.5.2->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (1.4.4)
Requirement already satisfied: cffi in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from cmsis-pack-manager<1.0,>=0.5.2->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (1.16.0)
Requirement already satisfied: zipp>=0.5 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from importlib-metadata>=3.6->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (3.18.1)
Requirement already satisfied: sortedcontainers<3.0,>=2.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from intervaltree<4.0,>=3.0.2->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (2.4.0)
Requirement already satisfied: MarkupSafe>=2.0 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from jinja2->gcovr>=6.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-build-test.txt (line 13)) (2.1.5)
Requirement already satisfied: wcwidth in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from prettytable<4.0,>=2.0->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (0.2.13)
Requirement already satisfied: wrapt~=1.10 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from python-can>=3.0.0->canopen->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 17)) (1.16.0)
Requirement already satisfied: pywin32>=305 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from python-can>=3.0.0->canopen->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 17)) (306)
Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from ruamel.yaml>=0.16.0->pykwalify->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-base.txt (line 14)) (0.2.8)
Requirement already satisfied: pycparser in c:\users\kalyan\zephyrproject.venv\lib\site-packages (from cffi->cmsis-pack-manager<1.0,>=0.5.2->pyocd>=0.35.0->-r \Users\KALYAN\zephyrproject\zephyr\scripts\requirements-run-test.txt (line 6)) (2.21)
followed setup instructions .All Requirements are satisfied but still facing an issue,you can see it above..

(.venv) C:\Users\KALYAN\zephyrproject\zephyr>west flash
-- west flash: rebuilding
[1/1] C:\Windows\system32\cmd.exe /C "cd /D C:\Users\KALYA...Users/KALYAN/zephyrproject/zephyr/build/zephyr/zephyr.elf"
-- west flash: using runner esp32
-- runners.esp32: reset after flashing requested
-- runners.esp32: Flashing esp32 chip on None (921600bps)
esptool.py v4.5
Found 5 serial ports
Serial port COM9
Connecting...
COM9 failed to connect: Write timeout
Serial port COM6
Connecting....
Detecting chip type... Unsupported detection protocol, switching and trying again...
Connecting....
Detecting chip type... ESP32
Chip is ESP32-D0WDQ6 (revision v1.0)
Features: WiFi, BT, Dual Core, 240MHz, VRef calibration in efuse, Coding Scheme None
Crystal is 40MHz
MAC: 58:bf:25:33:07:58
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 921600
Changed.
Configuring flash size...
Auto-detected Flash size: 4MB
Flash will be erased from 0x00001000 to 0x00007fff...
Flash will be erased from 0x00008000 to 0x00008fff...
Flash will be erased from 0x00010000 to 0x00033fff...
Flash params set to 0x0220
Wrote 32768 bytes at 0x00001000 in 0.7 seconds (383.4 kbit/s)...
Hash of data verified.
Wrote 16384 bytes at 0x00008000 in 0.3 seconds (489.4 kbit/s)...
Hash of data verified.
Wrote 147456 bytes at 0x00010000 in 2.1 seconds (571.0 kbit/s)...
Hash of data verified.
Leaving...
Hard resetting via RTS pin...
(.venv) C:\Users\KALYAN\zephyrproject\zephyr>west espressif monitor
Serial port COM9
Connecting...
COM9 failed to connect: Write timeout
Serial port COM6
Connecting............
Detecting chip type... Unsupported detection protocol, switching and trying again...
Connecting.....
Detecting chip type... ESP32
Traceback (most recent call last):
File "C:\Users\KALYAN\zephyrproject\zephyr..\modules\hal\espressif\tools\idf_monitor.py", line 34, in
import serial
ModuleNotFoundError: No module named 'serial'
Traceback (most recent call last):
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 505, in run_command
self.run_extension(args.command, argv)
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 654, in run_extension
self.cmd.run(args, unknown, self.topdir, manifest=self.manifest,
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\commands.py", line 194, in run
self.do_run(args, unknown)
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 165, in do_run
self.monitor(module_path, args)
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 184, in monitor
cmd_exec(("python.exe", monitor_path, "-p", esp_port,
File "C:\Users\KALYAN\zephyrproject\modules\hal\espressif\west\tools.py", line 40, in cmd_exec
return subprocess.check_call(cmd, cwd=cwd, shell=shell)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python311\Lib\subprocess.py", line 413, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '('python.exe', WindowsPath('C:/Users/KALYAN/zephyrproject/zephyr/../modules/hal/espressif/tools/idf_monitor.py'), '-p', 'COM6', '-b', '115200', WindowsPath('C:/Users/KALYAN/zephyrproject/zephyr/build/zephyr/zephyr.elf'), '--eol', 'CRLF')' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\KALYAN\zephyrproject.venv\Scripts\west.exe_main.py", line 7, in
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 1085, in main
app.run(argv or sys.argv[1:])
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 244, in run
self.run_command(argv, early_args)
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\app\main.py", line 543, in run_command
f'{quote_sh_list(cpe.cmd)}', fatal=True)
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\util.py", line 42, in quote_sh_list
return ' '.join(shlex.quote(s) for s in cmd)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KALYAN\zephyrproject.venv\Lib\site-packages\west\util.py", line 42, in
return ' '.join(shlex.quote(s) for s in cmd)
^^^^^^^^^^^^^^
File "C:\Python311\Lib\shlex.py", line 329, in quote
if _find_unsafe(s) is None:
^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'WindowsPath'
Thank you @nordicjm for your reply,Tried again after following the setup instructions but still facing the problem.

The error doesn't really make sense because serial is pyserial.

@kalyanboddula, can you try applying this change in your environment? The error might be Windows related: https://github.com/zephyrproject-rtos/hal_espressif/pull/277

@sylvioalves i tried applying the changes you have suggested in my environment and changed by window path to string by doing changes in my
west/tools.py
These are the changes I have done
def cmd_exec(cmd, cwd=None, shell=True):
    return subprocess.check_call(str(cmd), cwd=str(cwd), shell=shell)

By changing these windowpath to string i am still getting this error,I am not understanding the issue of it showing the error like this:
(.venv) C:\Users\KALYAN\zephyrproject\zephyr>west espressif monitor
Serial port COM9
Connecting...
COM9 failed to connect: Write timeout
Serial port COM6
Connecting..........
Detecting chip type... Unsupported detection protocol, switching and trying again...
Connecting....
Detecting chip type... ESP32
'-p' was unexpected at this time.
 Is that correct?

Re-tested and confirmed it is working. Open again if there is new issue.


Nested foreign key mutations do not work

See this stackoverflow post
The code should produce two different object but did not.

Describe the Bug
When you create a object with a foreign key object using one mutation there is a error
 "message": "Field 'id' expected a number but got PersonInput(id=<strawberry.unset._Unset object at 0x00000194FB945C90>, addressname='jkkihh', description=<strawberry.unset._Unset object at 0x00000194FB945C90>, notes=<strawberry.unset._Unset object at 0x00000194FB945C90>)."
This makes it not possible to create new objects with foreign keys that are nested because it does not create an id.

System Information

Operating system: Windows 10
Strawberry version (if applicable): 0.31
Django 4.03

Additional Context

Hey @ccsv , thanks for the report.
Yeah, I don't think we are currently dealing with nested objects creation in strawberry-graphql-django.
I saw that in the issue you mentioned the guy answered that you could use strawberry-django-plus. As the maintainer of that project, I can confirm to you that nested creation works there (if you want to use it, feel free to contact me on discord and I can help you if you have any issues/doubts)
Also, since you mentioned that on stack overflow: Yes, it is my intention to merge most of what is in strawberry-django-plus into strawberry-graphql-django. I am unfortunately lacking time to actually do that, but I hope I can do that soon.


2.2.0- beta release

@raunakkumar @Shanbhag, PAVAN Subbayya Please review

Are there no changes to any other hpe sidecars like mutator, volumegroup/snapshotgroup snapshotter in this release?

We have not modified any code for mutator, volumegroup/snapshotgroup ,snapshotter, in this release


Problem getting vulnerability report in Harbor 2.4

We recently updated Harbor to 2.4.2 and with that the Backstage Harbor Plugin broke. We're getting Cannot read properties of undefined (reading 'severity')
We investigated a bit and it seems we get a report back with a new vulnKey. The default X-Accept-Vulnerabilites is application/vnd.security.vulnerability.report; version=1.1, application/vnd.scanner.adapter.vuln.report.harbor+json; version=1.0. The resulting json contains the key application/vnd.security.vulnerability.report; version=1.1
Specifying only X-Accept-Vulnerabilites: application/vnd.scanner.adapter.vuln.report.harbor+json; version=1.0 returns an empty json result
Here's two related issues in Harbor: https://github.com/goharbor/harbor/issues/16085 & https://github.com/goharbor/harbor/issues/16295
I'm not quite convinced yet that our solution, changing vulnKey to application/vnd.security.vulnerability.report; version=1.1, is correct but might be.
What do you think?

As we are no longer using Harbor, we will now archive this repo.
We would love to donate the project to someone else, so if anyone wanna take over the project they can contact us on<EMAIL_ADDRESS>

Hi! Is backstage-plugin-harbor-* now maintained by the container-registry organization? Thats great news! I would like to reopen this issue, it's still a problem.  What do you think?

  We now try to revive that plugin and build it up so one day in can be merge upstream to harbor.


Add double click protection to submit buttons

What is the context of this PR?
Adds the submitType: timer field to a number of our submit buttons to protect against double clicks.
How to review
Check the templates updated match those on the Trello card.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Add multiple click protection to all submit buttons


[BUG] Schedule trigger extra kwargs not populated properly

Mage version
0.9.64
Describe the bug
As per the documentation (https://docs.mage.ai/orchestration/triggers/schedule-pipelines#extra-runtime-variables-from-pipeline-run)
"If your pipeline run belongs to a trigger that is scheduled, then the following extra variables are available in your Python block’s keyword arguments (e.g. kwargs)"
The following extra variables are defined:
interval_start_datetime	The datetime when the pipeline run is scheduled for.	datetime.datetime(2023, 7, 23, 7, 0, 0, 0)
interval_end_datetime	The datetime when the next pipeline run is scheduled for.	datetime.datetime(2023, 7, 24, 7, 0, 0, 0)
interval_seconds	The number of seconds between the current pipeline run and the next pipeline run.	86400
interval_start_datetime_previous	The datetime when the previous pipeline run was scheduled for.	datetime.datetime(2023, 7, 22, 7, 0, 0, 0)
Problem:
Most of the defined extra variables are set to None when running on a schedule as such it is not possible to see when a pipeline was last ran.
To reproduce

Create a new Pipeline
Create a custom schedule trigger to run every minute (* * * *) for the pipeline
Create a custom python block and include the following code:

    logger.info("Last interval_start_datetime_previous: {}".format(kwargs["interval_start_datetime_previous"]))
    logger.info("Last interval_start_datetime: {}".format(kwargs["interval_start_datetime"]))
    logger.info("Last interval_end_datetime: {}".format(kwargs["interval_end_datetime"]))
    logger.info("Last interval_seconds: {}".format(kwargs["interval_seconds"]))
    logger.info(', '.join(['{}={!r}'.format(k, v) for k, v in kwargs.items()]))

Enable the trigger and wait for 2 consecutive runs
Analyze Logs

Output:
Some out put is redacted and enclosed in square brackets
This is the output from a test run because I could not create a screenshot of the log for the actual run (local restrictions) but nevertheless the logs as part of a scheduled run look the same.
INFO:[block_title]:Last interval_start_datetime_previous: None
INFO:[block_title]:Last interval_start_datetime: 2024-02-20 12:04:31.680103
INFO:[block_title]:Last interval_end_datetime: 2024-02-21 12:04:31.680103
INFO:[block_title]:Last interval_seconds: None
INFO:[block_title]:env='dev', execution_date=datetime.datetime(2024, 2, 20, 12, 4, 31, 680103), interval_end_datetime=datetime.datetime(2024, 2, 21, 12, 4, 31, 680103), interval_seconds=None, interval_start_datetime=datetime.datetime(2024, 2, 20, 12, 4, 31, 680103), interval_start_datetime_previous=None, event={}, logger=<Logger [block_title] (INFO)>, configuration={}, context={}, pipeline_uuid='[pipeline_title]', block_uuid='[block_title]'

Expected behavior
The extra variables associated with running a scheduled task should be return appropriate datetime objects
Screenshots
No response
Operating system
Ubuntu 22.04
Additional context
Trying to create a pipeline that processes items provided by an API.
The API provides a way to query for items based on time.
I want to process these items incrementally on a daily basis as such I need to know what is the last run time of the pipeline so I can query the api to only provide results starting with the time of the last run.
I could use a local file data exporter and import that at on next run as well as keep track of processed items as part of this file and cross-reference but i am opening this as i believe there's a bug concerning the extra variables.

Hey @dgioga, thanks for opening this issue. For cron expressions, it is possible for them to be on an irregular interval, so interval_seconds may not make sense to calculate. However, we should be able to calculate the other variables, so I will make that change


chore(test): fix meta backup test

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously this test relied on risectl's exit code. But after #15158 risectl always returns code 0 even on error.
This PR fixes the test by verifying ristctl's output.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@mikechesterwang @BugenZhao
RW Cloud also relies on risectl's exit code to decide whether op succeeds. Should we add the exit code back?

But after #15158 risectl always returns code 0 even on error.

Oops. This is unexpected. I'll fix that.

Hi. #15325 was merged. Do we still need this workaround?


Multiplexing with nginx causes model observation to fail silently

Describe the bug
This is a really bizarre issue, and I don't really know where to start with it. I don't have a minimally reproducible example, but can try to create one later.
Basically, I'm trying to mutliplex my django service and another service serving the frontend behind the same domain (app.example.com) via the X-Server-Select header (as per following https://sites.psu.edu/jasonheffner/2015/06/19/nginx-use-different-backend-based-on-http-header/) to prevent having to preflight http requests.
The problem is, when http requests are being made to the backend via app. (routed via X-Server-Select) while websocket is routed via api. (no X-Server-Select), it appears that specifically model observation breaks. Consumers written with AsyncAPIConsumer work flawlessly, and so does the initial handshake @action-s for model observation (connection & authentication work correctly and we see responses from the backend over ws). However model changes triggered both by ssh-ing into a live server and running updates on the model via django shell, or via http requests to backend, do not work.
And it works flawlessly if we don't have the X-Server-Select routing! The changes are entirely in nginx configuration.
I'm wondering if there is any hostname config or likewise assumption that this broke? Or if anyone has any suggestions as to where to look for solutions.

# vim: ft=nginx

server { # backend
    listen 80;
    listen [::]:80;
    server_name api.example.com;
    set $upstreamhttp http://api:8000;
    set $upstreamws http://api:5000;

    location /ws/ {
        proxy_pass $upstreamws;
        proxy_http_version  1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "Upgrade";
        proxy_set_header Host $http_host;
    }
    location / {
        proxy_pass  $upstreamhttp;
        proxy_set_header    Host                $http_host;
        proxy_set_header    X-Real-IP           $remote_addr;
        proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;
        proxy_set_header    X-Forwarded-Proto   $http_x_forwarded_proto;
     }
}

map $http_x_server_select $ {
    default http://frontend:80;
    "api" http://api:8000;
}

server { # frontend
    listen 80;
    listen [::]:80;
    server_name app.example.com;

    location / {
        proxy_pass $frontendupstreamhttp;
        proxy_set_header    Host                $http_host;
        proxy_set_header    X-Real-IP           $remote_addr;
        proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;
        proxy_set_header    X-Forwarded-Proto   $http_x_forwarded_proto;
    }
}

I've also tried  putting ws under app. as well, but to the same issue.
server { # frontend
    listen 80;
    listen [::]:80;
    server_name app.example.com;

    set $upstreamws http://web:5000;
    location /ws/ {
        proxy_pass $upstreamws;
        proxy_http_version  1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "Upgrade";
        proxy_set_header Host $http_host;
    }

    location / {
        proxy_pass $frontendupstreamhttp;
        proxy_set_header    Host                $http_host;
        proxy_set_header    X-Real-IP           $remote_addr;
        proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;
        proxy_set_header    X-Forwarded-Proto   $http_x_forwarded_proto;
    }
}

with logging i notice that the model observer never gets invoked, nor does the groups_for_signal. Which is really odd, since all the auth and setup functions work fine. And if i run frontend pointing to api. for requests, then the ws events works perfectly fine. Also when pointing to app. for http requests i have verified that the requests are going through and models are being correctly updated.

OS: Debian
Version: bullseye

(running in python:11.5:bullseye container)
Running asgi via daphne and wsgi via gunicorn
any ideas or help would be greatly appreciated. Thanks!

Update: on further testing sending requests via api.example.com does trigger the model observer properly, but sending requests via app.example.com do not, while the ws is connected via the app.example.com. Why would a different host prevent djagno signals from working as intended?

Hi @ihasdapie
What channel layer are you using?
So that the Django signals get registered you need to ensure you import the consumers, even for the WSGI server and your ssh session.
The observation uses Django signals hooks so it needs to evaluate the files (import them) so that these hooks are registered on every instances not just the web-socket instance.

Hey, thanks for the reply!
I'm using the redis channel layer. I've imported all the consumers in the app config, should this be suffice to get it registered for both wsgi and asgi? This doesn't appear to work :/
For reference, i'm running wsgi via gunicorn and asgi via a gunicorn uvicorn worker
	gunicorn project.asgi:application --workers 4 --threads 8 --log-level info --bind <IP_ADDRESS>:5000 -c ./gunicorn_asgi.config.py &
	gunicorn project.wsgi --bind <IP_ADDRESS>:8000 --timeout 6000 --workers=2 --threads=4 --worker-class gevent -c ./gunicorn_wsgi.config.py &

Switching to only using the asgi worker seemed to have resolved this problem. However, i'd still like to use the wsgi worker for handling everything but websocket. Not sure if it is out of scope, but is it possible to configure this? It appears that even if the consumers are loaded into wsgi, those events do not make it to django-channels.

I should be possible to configure this.
To confirm the consumers are imported within gunicorn_wsgi.config.py not just gunicorn_asgi.config.py and when using WSGI your configuring the channel layer the same?
Are you able to connect to your redis dashboard to check if messages are being sent to redis?

I am configuring the channels layer the same way for both asgi and wsgi. No messages appear to be sent to redis, however.
In the meantime ive worked around it by using the uvicorn worker to serve everything


[变量名不合法]Variable name is illegal

Before you submit the issue, please provide us following information:

Your operating system
How did you install Goby
Goby version
The value of $GOBY_ROOT
Error messages

If you have trouble building Goby on your machine, please check $GOPATH and $GOROOT
123a = 10 => result 10
123   = 10 => result 10
[]=10 => result 10
我人都懵了，我猜parser没做好检查

最终BUG来自于Lexer.go 227行
isDigit

Thank you for pointing this out!
This should be like the following in Ruby:
» []=10
SyntaxError: unexpected '=', expecting end-of-input

Thank you for pointing this out!
This should be like the following in Ruby:
» []=10
SyntaxError: unexpected '=', expecting end-of-input

i can fix

Oh, thank you!😂 We look forward to the PR if you're OK.
cc @st0012

@ChinaHDJ sorry for late reply. Thanks for the report, looking forward to see your PR 😄

Partially fixed by https://github.com/goby-lang/goby/pull/786


Move grid row color styles to color-extra.scss and rename

This will reduce the size of the basic color CSS and make the naming more consistent with additional grid row styles.

Completed.


Ensure command line flags are passed through

After https://github.com/istio/istio/pull/2960 went in, I tried to enable VM test but the flag --test_vm still was not passed in based on the Prow log on smoke test https://github.com/istio/istio/pull/2444. It turns out --auth_enable flag was not passed in either.

/lgtm
apparently I only unit tested

@chxchx: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
33dec9692a126b43293faeaed90a0cae3af85ff2
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chxchx: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
33dec9692a126b43293faeaed90a0cae3af85ff2
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
33dec9692a126b43293faeaed90a0cae3af85ff2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


jest.mock -> Cannot find module

My test looks like this:
import 'react-native';
import React from 'react';
jest.mock('react-native-linear-gradient', () => 'LinearGradient');
import { LoginScene } from '../LoginScene.js';

// Note: test renderer must be required after react-native.
import renderer from 'react-test-renderer';

describe('LoginScene', () => {
	it('should render correctly', () => {
		const tree = renderer.create(
			<LoginScene />
		).toJSON();
		expect(tree).toMatchSnapshot();
	});
});

and in LoginScene file I have a line import LinearGradient from 'react-native-linear-gradient';
Problem with it is that whenever I run this test, i get an error:
Cannot find module 'react-native-linear-gradient' from 'LoginScene.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:144:17)
      at Object.<anonymous> (login/__tests__/LoginScene.js:3:6)

Getting it to work with proper mocks is even worse, then I get error that it has to be a proper react class something.
Current documentation is very vague and doesn't give a good explanation how things should look.

I added
jest.mock('react-native-linear-gradient', () => 'LinearGradient');

to https://github.com/cpojer/jest/blob/master/examples/react-native/tests/Intro-test.js#L8
and
import LinearGradient from 'react-native-linear-gradient';

to http://github.com/cpojer/jest/blob/master/examples/react-native/Intro.js#L14
and rendered it as <LinearGradient /> and it worked properly. Seems like you did something wrong outside of the content in the issue you described.

Upgrading to react-native 0.36, jest@test and jest-react-native@test helped.


docs: reduce abstraction and make it easier to read

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Ref #48359

More incoming changes in #48477


Add service unavailable banner

Add a notification banner for services no longer available to buy.
https://www.pivotaltracker.com/story/show/110062348

Note: this is a re-vamped version of https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/210

I've removed the @import from the comments and rewrote them to be clearer (in aa44859)

LGTM now, excellent perseverance :+1:


sanitycheck: a fix and an enhancement to hw.yml validation

A legitimate optional key was not included, breaking some hardware yaml files.
The change to validation removed the ability to annotate devices; add a key to restore this functionality.

A legitimate optional key was not included, breaking some hardware yaml files.

where was this added and what key are you referring to?

A legitimate optional key was not included, breaking some hardware yaml files.

where was this added and what key are you referring to?

da7384846e74d86568db14a9950d779e85f87119 and probe_id.

da73848 and probe_id.

ok, and what is "notes"?
Btw, can document probe_id while at it.

The role of notes is described in the commit message.
I don't see documentation on any of the fields in the hardware map except fixtures.  Do you want a section each for probe-id and notes?  Or something more encompassing?

I don't see documentation on any of the fields in the hardware map except fixtures.

well, I thought those are self-explanatory :), probe_id however has some special handling as it overrides. Anyways, I will update the docs with more details, you can add notes and probe_id now, basically the content of the commit message here and what you had in da7384846e74d86568db14a9950d779e85f87119.
Thanks.


[BrokenLinksH2] Fix path in link

Fixing image path

Docs Build status updates of commit 793fd70:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/reference-makes-api-test-page.md
:warning:Warning
View (>=makes-1.0)
Details

academic-services/knowledge-exploration-service/reference-makes-api-test-page.md

Line 9, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'MAKES REST API test page'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@DarrinEide - This PR includes only link fixes and does not change other content. I'd very much appreciate your timely review and feedback on the link changes I've suggested. Thanks!

Hi @DarrinEide, just a friendly reminder if you will be able to review and merge this PR. Thanks!


[FEATURE REQ] Support for DefaultAzureCredential in ImageAnalysisClient

Library name
Azure.AI.Vision.ImageAnalysis
Please describe the feature.
Would really like to have support for DefaultAzureCredential (or TokenCredential as in other libraries, for example TextAnalyticsClient and TextTranslationClient).
In Azure Portal this is even recommended since getting the following in Security Recommendations:
Azure AI Services resources should have key access disabled (disable local authentication)

PR #44509


Relocating CONTRIBUTING.md to root directory

Moved CONTRIBUTING.md to the root directory as suggested in this comment

Thanks again @zaaakher ⭐!

@davidjerleke You're welcome brother 👍

I thought these tabs were based on the .md files in the root directory but it turns out to be pre-determined for the following files only:

README.md
CODE_OF_CONDUCT.md
LICENSE
SECURITY.md

It's not a problem anyway 😁

I thought these tabs were based on the .md files in the root directory but it turns out to be pre-determined for the following files only:

README.md
CODE_OF_CONDUCT.md
LICENSE
SECURITY.md

It's not a problem anyway 😁

@zaaakher no problem at all! It seems to be convention to have the CONTRIBUTING.md in the project root anyway so thanks 🙂.


[ci] release

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#2081 f0181d2 Thanks @andrii-bodnar! - Updates the Ukrainian UI translations

size-limit report 📦

Path
Size

/index.html
5.81 KB (0%)

/_astro/*.js
21.95 KB (0%)

/_astro/*.css
13.66 KB (0%)


fix max heap insert function

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #43138

Before changes --
insert function not working according to max heap properties
After changes --
insert function works according to max heap  properties

I've edited your post so that the PR is linked to the issue. That is done using one of the keywords, "closes" is one of those

I've edited your post so that the PR is linked to the issue. That is done using one of the keywords, "closes" is one of those

Thanks Mate.

Thanks for the PR @anshul2807. There's few details that might need changing. Could you take a look at the notes below?
Notes:

Implementation moves also the initial first element in the heap (null), I don't think that should happening. Because of this behavior this version also wouldn't pass the previous challenge with heap (which also should be changed).
It's a bit verbose. That's not necessarily a disadvantage on it own, but when code is just a part of the starting code for challenge, there's no need to add anything more than what's absolutely required. This includes comments as well, as generally only those from https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/dictionaries/english/comments.json file should be used in the seed code.
Could you use two spaces as an indentation per level? That's suggested indentation the per formatting guidelines.

Sure, I will do that.

Thanks for the PR @anshul2807. There's few details that might need changing. Could you take a look at the notes below?
Notes:

Implementation moves also the initial first element in the heap (null), I don't think that should happening. Because of this behavior this version also wouldn't pass the previous challenge with heap (which also should be changed).
It's a bit verbose. That's not necessarily a disadvantage on it own, but when code is just a part of the starting code for challenge, there's no need to add anything more than what's absolutely required. This includes comments as well, as generally only those from https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/dictionaries/english/comments.json file should be used in the seed code.
Could you use two spaces as an indentation per level? That's suggested indentation the per formatting guidelines.

Done.

It's still a bit long for a starter code... scrolling is needed to see the whole, including the comments where put new method.

print method won't work properly without the null being at the start of heap array.

I fix the print method.
It was sill typo... I forget to add , this.
And for the new method , I can insert the comment at the top?

@gikf

Commit in this Push --:

[x] remove extra functions
[x] Fix Print function
[x] Reduce the size of the code


Fix invalid byte sequence on EncodedString#split

From:

https://github.com/rspec/rspec-core/pull/1760
via https://github.com/rspec/rspec-support/pull/134

So this makes me a little uncomfortable given you are assuming that the bad bytes can be scrubbed by converting to UTF-8 and back, if this is an incompatible encoding with UTF-8 then won't this destroy the original encoding?
Also can you remove the whitespace changes from the PR

So, the whitespace changes look sorta terrible in the unified diff, but if you split it or look at it alone, you'll see I'm actually fixing inconsistent whitespace (and some spelling, but that's unrelated to your comment).
I'm going to push a better fix on top of this momentarily.

Weird, that passed in https://travis-ci.org/rspec/rspec-support/builds/49911552

If this looks good I"ll rebase down to one commit.

Ok, I think this is it.

I'm not sure what to do about the JRuby failure, if it's expected behavior.  It is introduced in this PR.

I mean, it's not totally a failure, just a different behavior. The é\x80 results in \xC3\xA9\x80 Where \xCE\xA9 is equivalent to the é.  If I remove the egrave, then the failure really is just that JRuby is leaving the \x80 / 128.chr alone for some reason. Still, probably a bug.

LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 \
   rvm ruby-1.9.2-p330,ruby-1.9.3-p551,ruby-2.0.0-p598,ruby-2.1.5,ruby-2.2.0,jruby-1.7.18,rbx-2.2.2 do \
   ruby -e 'p [RUBY_VERSION, RUBY_ENGINE, Encoding.default_external, __ENCODING__] << "\x80".force_encoding("US-ASCII").chars.map{|char| char.valid_encoding? ? char : "?" }.join.encode("UTF-8")'

 for version in 1.9 2.0; do \
   export JRUBY_OPTS="-Xcompat.version=${version}" ; \
   LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 \
   rvm jruby-1.7.18 do \
   ruby -e 'p [RUBY_VERSION, RUBY_ENGINE, Encoding.default_external, __ENCODING__] << "\x80".force_encoding("US-ASCII").chars.map{|char| char.valid_encoding? ? char : "?" }.join.encode("UTF-8")';
 done

["1.9.2", "ruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["1.9.3", "ruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["2.0.0", "ruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["2.1.5", "ruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["2.2.0", "ruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["1.9.3", "jruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "\x80"]
["2.1.0", "rbx", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "?"]
["1.9.3", "jruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "\x80"]
["2.0.0", "jruby", #<Encoding:UTF-8>, #<Encoding:UTF-8>, "\x80"]

@JonRowe @myronmarston Are y'all ok with this?

So the test does nothing on JRuby? I think it should be pending if thats the case, that way we can have one spec, use the :pending metadata and we'll be alerted when JRuby fixes the issue.

Sorry nitpicking over the whitespace again because it should either be all fixed or none :P

@JonRowe Not at all.  re: the JRuby spec, you think I should remove the 'JRUBY' commit and add  :pending => RSpec::Support::Ruby.jruby? with a comment link to the bug?

you think I should remove the 'JRUBY' commit and add :pending => RSpec::Support::Ruby.jruby? with a comment link to the bug?

Yes.

Ok, I think I fixed the whitespace and it should be good. At some point though, I start expecting to find I missed something and I'm past that point :)

Picked to 3-2-maintenance

great!  back to rspec-core now


[Backport 2.x] Adding concurrent search versions of query count and time metrics (#9622)

Description
Backport for #9622
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Will use this PR to backport #9670 as well.

Hey @reta now that https://github.com/opensearch-project/OpenSearch/pull/9670 is merged I updated this PR to do the backport for both concurrent segment search metrics PRs.
As requested, I also opened https://github.com/opensearch-project/OpenSearch/pull/9722 as well to apply these bwc changes on main at the same time. Could you please help review & merge both? Thanks!


Orthodoxize our concordance

Factor uses an unnecessarily idiosyncratic set of terms derived from Forth tradition—functions are "words", modules are "vocabularies", etc. It would make Factor less insular and more accessible to new programmers if we stopped robpikeing our own names for everything and used mainstream terms when appropriate.

Revisit


S3df

I only made changes from L240-246, not sure where that other stuff came from

When will this show up in OnDemand?


View Revision Schedule

Split schedule scenario from #354 out
Definitions

Now - The current date and time
Live - Publicly available in the API and the live database the API draws from
Sunrise - The date, time, and timezone content is scheduled to go live
Sunset - The date, time, and timezone content is schedule to stop being live
Approved- Content that has gone through all steps in its workflow

Feature: Approve Content
  As a content approver
  I want to understand how the content I'm reviewing is going to be affected by sunrise/sunset
  So that I can make an informed decision about whether or not I should approve or reject the revision being reviewed

  Scenario: View Revision Schedule
    Given that a piece of content can have multiple revisions scheduled to sunrise at once
      And a piece of content may be scheduled to sunset
      And a piece of content my have a live revision
     When I want to understand how a piece of content may change over time
      And I can see what revision is current live, if any
     Then I can see a listing of approved revisions for a piece of content
      And I can see the revision ID, date created, date approved, identifier, have a link to view the complete revision, and have a link to create a new revision off of the current one, for each revision
      And if the revision has not yet passed its sunrise, its sunrise date and time until sunrise
      And revisions should be sorted by when they will become live
      And the current live revision should be separated from all other revisions
      And the sunset date for the content should be visible
      And if there are revisions scheduled to become live after the sunset date, they should be separated from revisions scheduled to become live before the sunset date.
      And I should be able to access this view from the approval page
      And I should be able to access this view from the revision listing page
      And I should be able to access this from the content listing page

Approve Content

[ ] View Revision Schedule

Work begun on https://github.com/Snugug/punchcard/tree/feature/schedule-view


Create php.yml

Question
Answer

Pull request type

License
MIT

What's in this PR?

Checklist

[x] I tested these changes.
[ ] I have linked the related issues.

What is this workflow for? We already have a workflow to run the tests...

Rejected, no feedback and doesn't provide anything to the package!


document Git workflow and releasing

document and/or further automate T2 build, release, deployment

T2 is discontinued


Publish<EMAIL_ADDRESS>

Release: https://github.com/realm/SwiftLint/releases/tag/0.54.0

/usr/bin/sudo /usr/bin/xcode-select --switch /Applications/Xcode14.2.app

The CI job failed because this version of SwiftLint requires Xcode 15.0 or later. Is there a way to specify this requirement in presubmit.yml or do the CI machines need to be updated?

cc @meteorcloudy @fweikert

Unfortunately not yet, I filed https://github.com/bazelbuild/continuous-integration/issues/1780 to track this.

Thanks for filing that @meteorcloudy.
Would it be reasonable to comment out the macOS parts of the presubmit configuration for this release considering the Linux one is passing?
It would be nice to not have to block the availability of this SwiftLint release on the installation of Xcode 15 on CI.

OK, make senses. I assumed you have tested this locally? I'll ping this PR when Xcode 15 is installed and we can re-enable the test on macOS in the presubmit.yml later.


groovy support?

I just started working on a kotlin project that uses groovy and maven for testing
I can't seem to find a way to make vim-test work for groovy files: Is my only solution to write a custom runner for groovy, or is there a way for me to leverage the maven runner that comes stock?
Sorry for the simplistic question, but I must admit I'm feeling at a loss here...

I had created a similar ticket for #371 for this. I am happy to help implement a solution based on your needs. Could you either create a PR with some spec examples of what you're trying to achieve or add the details to the ticket and we can go from there.

Thanks for the answer @codeinabox !
I can try, but it won't be right away unfortunately, as I am a bit overwhelmed with work at the moment: I'll try to do it asap thought!

Okay, so:
The project I'm working on is in kotlin, but uses groovy for the tests, with spock as a test framework.
The tests look like something like:
class FoobarSpec extends spock.lang.Specification {

    def "increment a number"() {
        given: "A number"
        def number = 42

        when: "We add one to this number"
        number++

        then: "It should be equal to the original number plus one"
        number == 43
    }
}

So I suppose :TestNearest should fetch the closest def and the next closest class to pass it to either maven or gradle (both seem to have similar command line arguments to run one single test case).
Same logic would apply for :TestSuite
As I'm writing this (and slowly learning about how java/kotlin environments work, it's my first time ever using these technologies), I realize the logic implemented in the java runner seems to apply, except maybe for the position building functions
I wonder if it would be possible/clean to refactor those so that java#mavenTest runner (and the java#gradleTest too I suppose) would be able to run tests in groovy files as well
@codeinabox please tell me if I'm not being clear (I must admit that my thought process is a bit foggy even for me, I really am a newbie with jdk environments, my apologies)

What CLI commands would you expect it to generate for test file, nearest etc for the example you have given?
Currently the Maven runner will generate commands like mvn test -Dtest=org.vimtest.math.TestMath\* and my Kotlin branch generates things like gradle test --tests AppTest

For this example, I would run it like so:

:TestNearest: $> mvn -Dtest=FoobarSpec#"increment a number" test
:TestSuite : $> mvn -Dtest=FoobarSpec test
:TestFile : I actually m not too sure, never had the use for this command tbh

So basically the same way as the java#mavenTest runner, the only specific would be finding the

@marene I believe this code may interest you. Unfortunately, I haven't had the time to polish it up in order to deem it worthy of a PR here, with automated tests and so on, but it does work (for me anyway).

Thanks a bunch, I'll give it a try over the weekend!

It could be nice to have support for the Spock Specification files. It is one of the best test frameworks out there.


First draft of seismic imaging tutorial

Nothing really "hands-on" about this, but hey it's deadline day, so let's merge.

Clean merge, going in next...


Expose ResourceImporterScene

Godot Master
Issue description:
Expose ResourceImporterScene
https://github.com/godotengine/godot/blob/master/editor/import/resource_importer_scene.cpp
Steps to reproduce:
Try to write a gdnative plugin for the fbx format by converting fbx to gltf2 but unable to reuse code from EditorSceneImporterGLTF since ResourceImporterScene is not exposed.
My approach is to convert the fbx to gltf (this is almost working) and then as a gltf2 reuse the code from gltf2 to a scene.
The plugin already expands the external materials.
https://github.com/fire/com-chibifire-fbx-plugin/blob/master/sample/addons/SimpleClass/src/SimpleClass.cpp#L115

Was exposed but opening a bug for the bugs.


Command execute by console once the player have reached a certain job level

I think it would be pretty useful that if we can set console to execute a command when a player have reached a certain job level.
Let say we have a reward system, for every 25 level the player have reached, we will give a small reward, in this case a diamond. Once the player have reached lv25, lv50, lv75, lv100, the server will automatically execute the give command to the player, rewarding them for archiving it.
I know daily quest can do that but it would be meaningless if the level reward can be obtain over and over again. I see a command on join and leave config but not command on level, so I really hope that this could be included in a future update. Much thanks on maintaining the plugin.

https://github.com/Zrips/Jobs/blob/master/src/main/resources/jobs/_EXAMPLE.yml#L546-L567

>
>
>  commands:
>     # command name, just to have better idea what this do
>     weapon:
>       # Command its self, this will be executed from console, so all commands should work
>       # Possible variables are: [player] [jobname] [oldlevel] [newlevel]
>       command: minecraft:give [player] minecraft:netherite_axe{AttributeModifiers:[{AttributeName:"generic.attack_damage",Amount:15,Operation:0,UUID:[I;-121125,34908,94915,-69816],Slot:mainhand,Name:"generic.attack_damage"},{AttributeName:"generic.attack_speed",Amount:1,Operation:0,UUID:[I;-121125,35008,94915,-70016],Slot:mainhand,Name:"generic.attack_speed"}]} 1
>
>       # When to execute this command first time
>       levelFrom: 100
>
>       # Until when to do this command
>       # This can be set to same level as levelFrom, so this command will be executed only once
>       levelUntil: 100

Am i making any mistakes here?


ILEmit serializers like protobuf-net does

A performance gain can be provided not only by reducing allocations or providing a better wire format but also by optimizing the serializer methods themselves. It has been applied in protobuf-net (they have their own il emit context) as in JIL which uses Sigil. Is this kind of optimizations considered for the future releases of the wire? What's your opinion on this kind of optimizations ?

I'm not sure I follow, we already do code generation using linq.Expressions CompileToDelegate.
Which is doing il emit behind for you.

I'm sorry. I should have been more specific. What I meant was the protobuf ability to actually inline the serializers as well, as they provide this two specific methods: https://github.com/mgravell/protobuf-net/blob/master/protobuf-net/Serializers/IProtoSerializer.cs#L49-L67 . I can see in the default compiler that the object serializer itself is emitted, but still boxing for its value type properties occur as the WriteObject method uses a serializer and an object. My question was about going one lvl deeper and emitting away the serializer methods. This would allow us to do not box at all in a protobuf-inspired manner :)

Ah yes, I will dig into this and see if there is any fairly easy way to adapt the current coded to do this.
That being said, the getters and setters of values are fairly insignificant compared to touching the input/output stream, and looking up types/object identitiers or translating to and from strings/UTF8.

I have made some good progress on this one.
It doesn't eliminate boxing yet, but at least all the code is generated in a single chunk instead of having layers upon layers of delegates.
This had some dramatic effect on the performance. its now about 20% faster.

Closing this, we have #56 which is in progress already


Update another scenario proxyAddress is removed

There is another scenario that guest users' proxyAddress is removed by conflicting contact object. This behavior is confirmed as by design in IcM 362139840 with Ricardo Antunes.

@csmulligan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


iBug: Blacklist fixingblog.com

iBug requests the blacklist of the website fixingblog.com. See the Metasmoke search here and the Stack Exchange search here.

fixingblog.com has been seen in 3 true positives, 0 false positives, and 0 NAAs.

!!/approve

Coverage remained the same at 65.608% when pulling 47cb2ec0d0d26c9bf11d7cc036e80bd33a6e9738 on auto-blacklist-1513232574.798141 into<PHONE_NUMBER>3fd1db3872a7d8c0c8ec1c9624fc14 on master.


when I run model3v2, there is an error.

The error is InvalidArgumentError (see above for traceback): Inputs to operation gradients_1/AddN_973 of type AddN must have the same size and shape.  Input 0: [2,7,1,100] != input 1: [2,1,1,100]. Do you know what this error is? Thanks!

Try using python3


Does A9G pudding board contain the battery charger module?

It is not clear to me if the A9G pudding dev board has the battery charger.
In some product details it is specified:

There are lithium battery charge management, microphone, speaker interface, USB communication interface, etc...

So, can I expect to charge the battery if I connect the USB power?
Thanks.

Yes! A9G contains ic for charge the battery. It is SY8089 dc-dc converter.

No, the SY8089 is not a battery charger. It only converts 5V USB down to
4.2V for the A9G module. Connecting USB and a battery at the same time will
allow an uncontrolled amount of current to flow into the battery, possibly
damaging the battery and converter.
I find that a lot of these Chinese GSM modules (not the dev/carrier board)
say stuff about having battery charging and management, but then never give
any info on how to use it :/
On Wed, 26 Feb 2020, 09:41 Alexey Vlasov<EMAIL_ADDRESS>wrote:

Yes! A9G contains ic for charge the battery. It is SY8089 dc-dc converter.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Ai-Thinker-Open/GPRS_C_SDK/issues/406?email_source=notifications&email_token=AAXXNWBG7E523DOLXEGQNSLREY2L5A5CNFSM4KXL64L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM7QNYA#issuecomment-591333088,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXXNWFXOY7MAHUTPW4HWQDREY2L5ANCNFSM4KXL64LQ
.

Ok, so there is not a battery charger, it's correct?
But in this official page is declared this feature for chipset A9 and A9G:

Power Management Unit: Lithium battery charge management, integrated DC-DC and LDOs, variable IO voltage

There's no charging support, That page also says it has a USB 1.1 interface, but there's nothing about how to use it. Basically, they're listing the features of the main processor (RDA8955L), but some of them might need extra software or hardware support that is missing from the rest of the A9G module and SDK.

Zak, you are right! Pudding's supply subsystem isn't properly designed.
A few words about "charging support". I found one interesting cause of power on: POWER_ON_CAUSE_CHARGE. Can it be the way to handle the ending of charge?

What is the simplest li-ion battery charger solution that we can add to this this board?
I think we need a battery charger with load sharing, can the MCP73831 be useful for this purpose?

There's no charging support, That page also says it has a USB 1.1 interface, but there's nothing about how to use it. Basically, they're listing the features of the main processor (RDA8955L), but some of them might need extra software or hardware support that is missing from the rest of the A9G module and SDK.

Hi Zak, I read your excellent article about lipo charger with load sharing, very informative thank you.
I would like to try to integrate the MCP73831 to the pudding board, I have some doubts on where to connect the VCC output to the pudding board to consume as little as possible.
Can you give me some advice?

Hi Zak, ok I will do so, thank you.
Meanwhile, I found an old board of mine that uses the MCP73831, but it doesn't seem to be in load sharing configuration.

These are what I misured in VABT e +5V pins:

USB only

VBAT = 4.14V
5V = 4.94V

Battery only

VBAT = 4.04V (real battery voltage I suppose)
5V = 5.00V

USB with Battery

VBAT = 4.14V
5V = 4.54V (seems to increase as the battery charges)

Do you think I can use the power part of this board to poweron the pudding board with load sharing?
In case, wich pins should I connect to pudding board? I think VBAT is a great candidate to use directly in VBAT pins of pudding board.
Thank you.

I'm not sure if you really need Q4 on PROG and EN -
PROG: The charger IC will already stop charging when 5V is removed.
EN: If the regulator output is higher than what it is supposed to be then it will stop boosting. The quiescent current is probably low enough not to interfere with battery charging.
But otherwise, what you have there is basically the boost regulator replacing Q1 MOSFET from the load sharer, with a diode (D12) blocking reverse current. You still need to connect the output to VUSB/5V since it will be exceeding 4.2V.
You'll be fine with connecting a charger without load sharing to the battery then the battery to VBAT on the pudding board, the only problem with this is that it will never completely finish charging.
Or did you mean VBAT to pudding VBAT and 5V to pudding VUSB/5V at the same time? Not sure which part you mean by 'power part' either >.<

Hi Zak, I will try to connect VBAT directly to pudding board VBAT, thank you.

It is not clear to me if the A9G pudding dev board has the battery charger.
In some product details it is specified:

There are lithium battery charge management, microphone, speaker interface, USB communication interface, etc...

So, can I expect to charge the battery if I connect the USB power?
Thanks.

I think the A9g Pudding board does support battery charging.
I have a 3.7v lithium battery connected to the board ( (+) -> VBAT, (-) -> GND) and i can charge it through the micro USB port.
Moreover, the board can manage the charging process.
typedef enum{
    PM_CHARGER_STATE_DISCONNECTED      = 0,
    PM_CHARGER_STATE_CONNECTED         = 1,
    PM_CHARGER_STATE_CHARGING           = 2,
    PM_CHARGER_STATE_FINISHED          = 3,
    PM_CHARGER_STATE_ERROR_TEMPERATURE = 4,
    PM_CHARGER_STATE_ERROR_VOLTAGE     = 5,
    PM_CHARGER_STATE_ERROR_UNKNOWN     = 9,
    PM_CHARGER_STATE_MAX
}PM_Charger_State_t;

typedef enum{
    PM_BATTERY_STATE_NORMAL     = 0,
    PM_BATTERY_STATE_LOW        = 1,
    PM_BATTERY_STATE_CRITICAL   = 2,
    PM_BATTERY_STATE_SHUTDOWN   = 3,
    PM_BATTERY_STATE_UNKNOWN    = 4,
    PM_BATTERY_STATE_MAX
}PM_Battery_State_t;

I found it in the api_inc_pm.h library and it works fine!

The pudding board does not have any charge management. This schematic shows VBAT connected directly to the 5V -> 4.2V buck regulator output. http://wiki.ai-thinker.com/_media/gprs/a9g/a9g-dev_v1.2.pdf

Connecting USB and a battery at the same time will allow an uncontrolled amount of current to flow into the battery, possibly damaging the battery and converter.

The pudding board does not have any charge management. This schematic shows VBAT connected directly to the 5V -> 4.2V buck regulator output. http://wiki.ai-thinker.com/_media/gprs/a9g/a9g-dev_v1.2.pdf

Connecting USB and a battery at the same time will allow an uncontrolled amount of current to flow into the battery, possibly damaging the battery and converter.

hello, I agree with zkemble. I have another problem, when I connect the A9G module with a USB power source, the module starts automatically, but when I use the VBAT pin with a li-ion battery, nothing happens ( i have to turn it on with the board bottom). Do you know why it happens? I checked the schematic and I don't know why.

@barokemind Connect PWR_KEY to GND with a piece of wire. What happens is if it detects 5V (USB) at the VUSB_DET pin it will automatically turn on, otherwise if USB is not connected then it will wait for PWR_KEY to go LOW.

yes, i can confirm that sy8089 cannot charge the v_bat, only regulates 5v input to v_bat (4.2 - ish) to be used in a9g. SO in conclusion 19g dev board cannot charge battery from usb

So what are you using for compact / integrated charging solutions?

So what are you using for compact / integrated charging solutions?

I found that a9g dev board uses more than 20mA in power off mode !!!
Any hint to save battery from flat discharge ?

External p-ch mosfet with power management uC like attiny13a

In case it has not been sufficiently clear to anyone:
Do NOT connect a battery and another power source to the board at the same time! It will not charge the battery, but rather destroy the board and maybe even the battery!
(While fiddling around for a while, at one point I forgot to disconnect the battery and a broken board was the result. Luckily I have another A9G pudding board and the battery seems to be working still.)

I'm using this circuit for my project, a lipo charged with shared load capability. Some parts taken from internet, other from a9g dev board schametics, I have tested it in lab and seems to work fine.

Hi everyone, so the vusb-det pin (17) should be left floating in this way? Is my power supply part correct? Thank you in advance...

Yes, VUSB (17) not connected. About your power supply I have no experience with SY8089, I'm using TPS54308 for downconverting power. I see some mistakes in your design, for example the ufl connector (gps/gprs) is incorrectly connected, the pin 1 is signal, not gnd. Also I guess about ADC0, whats is for? is sensing power supply 3.7v?, also I recommend feed de A9G module with 4v~4.2v, not 3.7v, with 3.7v you're very close to the under limit of Vin and when modul is doing GPRS there are at least 1A of peaks that can drop your 3.7v to lower values reseting the decive. USP_P/USB_N not documented in AI SDK, never used it, I can't imagine how to use it, there isn't documentation. Regards.

Thank you man. I fixed but i would like to feed the A9G processor with 3.8 v so i can use a simple 3.8v lithium battery ... Do you think it will be ok? I have seen the 2 resistors connected in this way with the ADC0 in the A9G dev. official schematic of AiThinker so i do so, even if i didn't understand what they are for. Do you think there are any others potential issues in this part of my schematic? Thank you in advance. Regards.

I suggest you to use a lipo charger and a shared load circuit to switch between your external supply and battery when there is no external source present. Take a look at my previus post with a lipo charger and shared load circuit control, I have a new version running on production now with some modifications to improve time of conmutation and fix some worng resistors values, but the idea in the picture is the same.

So the lipo charger shared load circuit is to recharge a lipo battery right? (Sorry but im still an inexpert)

The two mosfets block is for conmuting between battery and external power supply. The charger is the TP4056 IC.


Fix window.zoomLevel going out of bounds even if zoom doesn't change

Fixes #48357

@bpasero Can I get a comment on this? I'd love this to be merged (or get a review comments to fix)

@gioragutt instead of hardcoding this value wouldn't a better approach be to try to set the new zoom level and then check if it was applied and only then update the setting?

@bpasero I'll research that, but if there's like any guidance you can provide that'd be welcomed.
I too of course dislike the hardcoded values, although they work. Will update the PR later today.
Thanks!

@gioragutt yeah just search for calls to webFrame.getZoomLevel(), which I would assume at one point does not return a changed value (this is my guess).

@bpasero Actually the webFrame.getZoomLevel() returns a valid value, which just keeps on growing. I'm currently opening an issue in electron to query those mix/max zoom values, which are currently not exported. I've not found a way to query it via electron itself, or something internal in vscode.
Even the .cc don't export query methods for those values.

@bpasero As far as I can tell, getting the actual bounds from the underlying chromium code might be quite a serious hassle.
I suggest that this PR would be merged, and in the future, another PR would update the usage of those hard-coded constants (that seem to be working nicely, as I've seen) to values obtained by the API.

@bpasero ping

@bpasero hay, it's been almost a month. Can I get some feedback here?

Sorry for the late reply but I decided to go with a solution that puts the limits closer to the electron-browser action because I think these limits are dependent on the container (via https://github.com/microsoft/vscode/commit/af8b26c93993cdf858eeee162e31bbc586240cb4).


timestamp: add fuzzer

Adds a simple fuzzer for FuzzParseSignedToken.
Once merged, I will instruct OSS-Fuzz to run this fuzzer continuously.
Signed-off-by: AdamKorcz<EMAIL_ADDRESS>

Codecov Report

Merging #101 (690d721) into main (cd56ef6) will decrease coverage by 0.02%.
The diff coverage is 78.50%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   78.76%   78.73%   -0.03%
==========================================
  Files          28       28
  Lines        2067     2140      +73
==========================================
+ Hits         1628     1685      +57
- Misses        336      346      +10
- Partials      103      109       +6

Impacted Files
Coverage Δ

signature/internal/base/envelope.go
97.72% <ø> (ø)

signature/types.go
0.00% <ø> (ø)

signature/cose/envelope.go
93.24% <78.30%> (-2.99%)
:arrow_down:

signature/envelope.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The timestamp package has been cleaned up by #102

Closing since the target code has been removed.


datatables language not working

hi,
i put this cose on my javascript:
$('#table-log').DataTable({
"language": {
"url": "//cdn.datatables.net/plug-ins/1.10.18/i18n/Italian.json"
},
});
but chrome show this error:
Failed to load http://cdn.datatables.net/plug-ins/1.10.18/i18n/Italian.json: Request header field X-CSRF-TOKEN is not allowed by Access-Control-Allow-Headers in preflight response.
br
Max

Just upload the file to you own public folder and use this:
                language: {
                    url: '/localisation/Dutch.json'
                },

#I think you need to use array on the language param like:
public function html()
    {
        return $this->builder()
            ->columns([
                'id',
                'name',
                'actions',
            ])
            ->parameters([
                'dom' => 'Bfrtip',
                'order' => [ [0, 'desc'] ],
                'buttons' => ['csv', 'excel'],
                'language' => ['url => '//cdn.datatables.net/plug-ins/9dcbecd42ad/i18n/Italian.json']
            ]);
    }

'language' => ['url' => '//cdn.datatables.net/plug-ins/9dcbecd42ad/i18n/Spanish.json']


blender package

Current Behavior
Problem importing the file into blender

Expected Behavior
No
Steps To Reproduce
no
Environment
- OS: W11
- Blender: 4.0
- glTF-Blender-IO-MSFS: last

Anything else?
No response

Does not work with 3.6 or higher.  per the read me.  need to use 3.3


Add release.sh to master-with-services

Coverage remained the same at 100.0% when pulling 2d257045a89fcebaba26f615305a7cb063d99f5b on master into 2fb5a55564a647b3e140633aed7d1445ca135b85 on master-with-services.


Weather module

Add a simple weather module using browser location features (BETA)

A lot of people are having this bug. I found a way to fix it. Force-pushing later

Will test right now.


Add null check to document.activeElement

document.activeElement can be null. When it is and key is pressed, an exception is thrown.
https://developer.mozilla.org/en-US/docs/Web/API/Document/activeElement
I propose to do a null check before the .closest() call.

@axonify-mdeblois Thanks a lot for contributing to mediaelementjs, I've merged your pull request.


SILGen: Skip function bodies with errors in lazy typechecking mode

The SILGen pipeline expects function bodies to have been succesfully type checked and will usually crash if it attempts to emit SIL for a function that has errors. To avoid crashing, cause function body typechecking to happen earlier in lazy typechecking mode and then skip functions whenever any errors have been encountered.
Resolves rdar://130777647.

@swift-ci please smoke test

@swift-ci please smoke test