support for swift-3.0?

+1

I will add support for Swift 3.0 when Moya releases a Swift 3.0 version, which should be soon https://github.com/Moya/Moya/pull/608

I needed this earlier, so I have a version that works with Swift 3.0 for RxSwift. I don't have time to double check everything, but if you create another branch @ivanbruel I'll submit a PR and you guys can help. https://github.com/legoless/Moya-ObjectMapper

add support at least on another branch, Moya have done it

+1 @Legoless I've been looking for Moya Mapper supporting Swift 3.0. Thanks for your working and hope that will be merged to this repository :)

I wasn't able to use Legoless branch.
Am I doing anything wrong?
pod 'Moya-ObjectMapper'', :git => 'https://github.com/legoless/Moya-ObjectMapper',  :branch => 'master'

I use it the same way, even without specifying master branch. It has likely to do with other pods, there might be version conflicts, or you are using ReactiveCocoa?

No. I use RxSwift / RxCocoa... I'll try again this weekend... it might be just something I missed cuz I was lazy xD. Thanks for the quick response tho. 👍

No problem, if you still get problems, give us more information, entire pod file and the errors you get.

@Legoless please open a PR into the master branch, thanks!

Ok, so I installed the pod and got 264 errors all from Alamofire. The test app is just a blank app btw.

Pre-downloading: Moya-ObjectMapperfromhttps://github.com/legoless/Moya-ObjectMapper`
Downloading dependencies
Installing Alamofire (3.5.0)
Using Bolts (1.8.4)
Using FBSDKCoreKit (4.15.1)
Using FBSDKLoginKit (4.15.1)
Using FSCalendar (2.3.3)
Using Material (2.0.0)
Installing Moya (7.0.2)
Installing Moya-ObjectMapper (1.4)
Using NSStringMask (1.2)
Installing ObjectMapper (2.0.0)
Installing Result (2.1.3)
Using RxCocoa (3.0.0-beta.1)
Using RxSwift (3.0.0-beta.1)
Using TPKeyboardAvoiding (1.3)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 8 dependencies from the Podfile and 14 total pods installed.`
These are the pods I'm using.
pod 'RxSwift',    '~> 3.0.0-beta.1'
pod 'RxCocoa',    '~> 3.0.0-beta.1'
pod 'Material', :git => 'https://github.com/CosmicMind/Material', :branch => 'development'
pod 'FSCalendar', '~> 2.3'
pod 'NSStringMask', '~> 1.2'
pod 'FBSDKLoginKit', '~> 4.15'
pod 'TPKeyboardAvoiding', '~> 1.3'
pod 'Moya-ObjectMapper', :git => 'https://github.com/legoless/Moya-ObjectMapper'

Working on it, will get back to you guys, merged #22 in the meantime.

I released a Swift 3.0 version, seems to be working properly on the Demo project. I'll keep this open until all dependencies officially release their Swift 3.0 versions on CocoaPods.


Use shared_mutex in VulkanStateTable

Reduce mutex/lock overhead by switching from mutex to shared_mutex. Use a unique_lock when modifying the table and a shared_lock when reading from the table.

CI gfxreconstruct build queued with queue ID 1795.

CI gfxreconstruct build # 2706 running.

CI gfxreconstruct build # 2706 passed.

CI gfxreconstruct build queued with queue ID 4194.

CI gfxreconstruct build # 2725 running.

CI gfxreconstruct build # 2725 passed.

do we get a measurable performance bump on any captures with this?

Yes. In one case FPS of the application doubled during capture. Some other cases also showed big improvements and some didn't change much. This is on Windows. I didn't test other platforms, but I wouldn't necessarily expect the same kind of performance difference there depending on those platforms's implementation of mutex and shared_mutex.


Exception: [Tactical - Invisible for players] Impossible to find item

Not certain if this is an issue with UB, I'm finding it difficult to tell where the issue originates from based on the logs so apologies if posting here is incorrect.
I'm playing the Island of Domination mod. Whenever I load the  game it warns that there's an instability error, logs attached. The missing item or whatever does seem to be referencing values in the IoD JSON.
Player.log
Player.log

Thanks for the report. I need your save to confirm if the fix works...

That item is indeed missing from campaign. Please report to author.

Great thanks for looking at this!


Version up to 0.7.6

Be ready for release v0.7.6
Updates:

package version
protocol version file

Thanks for the fast review! merging now :)


Validate v1 and v2 charts for RHEL 8.2

Validate v1 and v2 charts for RHEL 8.2

Verified v1 and v2 chart on RHEL 8.2, 4.18.0-193.el8.x86_64 and Rancher v2.5.5

Verified v1 and v2 chart on RHEL 8.2, 4.18.0-193.el8.x86_64 and Rancher v2.5.5


nyc does not include all files

Link to bug demonstration repository.
repository: https://github.com/Semibold/Project-Starter
nyc config: https://github.com/Semibold/Project-Starter/blob/master/package.json#L45
reproduce:

clone above repository and cd to workspace
run npx nyc mocha -r ts-node/register test/noop.spec.ts (Using this command to collect source uncoverage map)
logs

----------------|----------|----------|----------|----------|-------------------|
File            |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------------|----------|----------|----------|----------|-------------------|
All files       |        0 |        0 |        0 |        0 |                   |
 src            |        0 |      100 |      100 |        0 |                   |
  index.ts      |        0 |        0 |        0 |        0 |                   |
  polyfills.ts  |        0 |        0 |        0 |        0 |                   |
  react-app.tsx |        0 |      100 |      100 |        0 |                 5 |
 src/scripts    |        0 |        0 |        0 |        0 |                   |
  add.ts        |        0 |      100 |        0 |        0 |                 5 |
  clause.tsx    |        0 |        0 |        0 |        0 |         6,8,10,11 |
----------------|----------|----------|----------|----------|-------------------|

Expected Behavior
src/metadata.ts should be included in coverage report.
Observed Behavior
see above logs
Forensic Information
Operating System: Windows 10.1809.
Environment Information: Node v10.10.0, npm 6.4.1, https://gist.github.com/Aqours/09f73b77207814a47ac6e1f818039e2d
This workflow has been used in my other project, and many files will be ignored when runing same command.

dup #679


ERROR for site owner: Invalid key type -RECAPTCHA

SoS

Please provide more information

bro
my site is ikcollection.herokuapp.com

Please pin django-recaptcha = "<=1.5.0" in your Pipfile and lock again since Saleor doesn't support 2.x as https://github.com/mirumee/saleor/issues/3625

http://haideraf.pythonanywhere.com/music/create_album/ bug

BUG FIXED thnx 1.5

Use can use Google Recaptcha V2 or this solution for Invalid key type: RECAPTCHA will surely help you.


feat(module:image): add nz-image component

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@hsuanxyz please mark as draft, thanks~

@hsuanxyz pls help me review this, thx~

I submitted a new Pull Request, this will be closed.


Content: confirm civic deck content matches spreadsheet in keystone on prod + QA

There may be discrepancies in deck content. need to go through each role + deck content to make sure it matches spreadsheet. This way we know if layout problems appear it is not because of the copy.

ALL Deck content, in qa and production, including both decks, should meet the character limits in the spreadsheet. this includes deck name, deck description, questions, role title, role bio, and agenda items. This should shore up some layout problems with text breaking out of the specified design limits.


CI/CD: Sometimes release specific workflows are triggering on the main branches

Description
Have a look at release workflow runs in cmd repos, for example:
https://github.com/networkservicemesh/cmd-nsc/actions/workflows/release.yml
https://github.com/networkservicemesh/cmd-nse-vl3-vpp/actions/workflows/release.yml
Release workflows are skipped for the main branches, and that's fine, but they also can be just ignored by CI. by release prefix as it is done in the deployments.-k8s repo: https://github.com/networkservicemesh/deployments-k8s/actions/workflows/release.yaml (note: release workflow is running only on release branches)

integration testing repositories also have this problem

Seems like done. We'll reopen the ticket if face any problems on CI.


IISWebAppDeploy: override parameters must not contain spaces between name and value

Hi,
I started using the IIS Web app deployment task. As I keep the Web Deploy parameters in the release definition, I don't have a parameters file, so I used the override parameters feature.
It's very handy, but it should be more explicit that there must be absolutely no space between the comma after the name token and the value token.
Meaning, it cannot be name="<parameterName>", value="<parameterValue>", but instead must be name="<parameterName>",value="<parameterValue>". Note the space between the comma and the value token.
It doesn't help that in the help text, the second example - the one supposed to be on the second line - includes such a space.
The error I got was System.Exception: Error: Unrecognized argument 'value="<value of the parameter of the line that contained a space>"'. All arguments must begin with "-"..
After removing the spaces, it's all good!
Thanks for the hard work. I'll send a PR related to this issue to fix the help text.
Feel free to contribute to the PR branch to add anything you think might be worth it.

@mderriey Thanks for pointing out the issue. We will fix the issue and handle the space.

Closing as the associated issue was closed. See https://github.com/Microsoft/vsts-rm-extensions/pull/204#issuecomment-287677410
It was fixed in #205.


SCA quality issue on generated code

I have a client who is using Kogito and their SCA tool returns some issues with the generated source code (e.g. unreleased resources, where the code didn't close the input stream properly, the recommended solution from the SCA tool is to put in finally block).
What is the right way to modify it so that the generated source code will be fixed? I imagine modifying the generated source code is a bad idea as I will need to keep doing it every time I compile it.

Hi @wengkee
Could you please provide a reproducer/model that lead to the creation of the affected code ?

Answering the initial question, we need the details of the issue to be able to fix it in the code generator. In that case, add the missing finally block once we know where to add it.

kogito.zip
Hi, thanks for replying. Here is the source code sample.

Regarding the issue from the SCA tool, it detects unreleased resource at 2 places. Below are the snippet from the report, which indicates that the issue are of high severty.

THanks @wengkee, looking...


Feature/add cbs data to s3

Closing this one, solved conflicts in https://github.com/hasadna/anyway/pull/1793


gds can not parse to Webgl succeessfully

thanks alot!!!
i follow the docs and run command as follow, the gds is built by  GDSPY https://github.com/heitzmann/gdspy
python .\gds2webgl.py -i .\spinQ_2qubit_initial_version.gds -o file.html
python .\gds2webgl.py -i .\spinQ_2qubit_initial_version.gds -o data.js

but gds parse a cell into html, which cell 's  points_str is 'AQ==' and triangles_str is 'AA=='
saddly ,nothing is in canvas.
it is different from the demo , i guess something lost after parsing
How can I make it work? Please help me, or please give my some advise.
MYSOURCE:
link:
https://static-cdn.spinq.cn/static/spinQ_2qubit_initial_version.gds
file.html and data.js
https://static-cdn.spinq.cn/parsedhtml/data.js
https://static-cdn.spinq.cn/parsedhtml/file.html
GDSPY OUTPUT JPG

HTML OUTPUT FROM GDS2WEBGL

after changging the layer index i find it can draw something . but still imprecise
need your help! thanks alot!

hi, could you give me some suggestion to implement this function?
or i think this problem is kind of triangle error, image mistake every time i draw some angle . could you explain how to understand this,so that i can do something.
pentagon in gds viewer

pentagon in gds2webgl

code  could not understand


New sem_Extract operator

New Sem_Extract Operator that schemas a list of documents and creates a DataFrame and provides the option to get quotes from context.

I don't love the name sem_schema -- I think sem_to_schema or just to_schema would be better

in the examples, extract.py requires a datasets -- we should either add it to our requirements, or just copy the three rows of the dataset we're using to a file in the examples folder and load it from the file

Let's not add it in the requirements.txt since its just for the example and not part of the core library. We could copy 3 rows if its not too big.


no more Luis

I cant create Luis, and what should i do?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c55e6920-2987-2b78-66b7-3dee92ab8689
Version Independent ID: 5d9f5e75-ee25-cc5d-bdd5-594712badf63
Content: Tutorial: Improve intent recognition in Bot Framework Composer with Language Understanding
Content Source: composer-docs/tutorial-improve-intent-recognition-language-understanding.md
Service: bot-composer
GitHub Login: @JonathanFingold
Microsoft Alias: iawilt

You should go with CLU.

And how do you configure CLU in Composer? Because everything I've tried hasn't worked for me

No clue to be honest. I've dropped the project

I'm going to give Microsoft bots a chance until next week. If by then I have not been able to advance I will look for other alternatives


Hooks partly don't work after gitea update

Gitea version (or commit ref):
1.14.0+dev-707-g66a148e39
Git version:
2.30.1
Operating system:
docker Alpine Linux v3.13
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No

Log gist:

Description
After gitea update pipelines for multiple branches/commits don't work at all (hooks are being sent though): commit doent't start new pipeline, new branches do not appear in jenkins automatically.
For some branches hooks still work.
Looks like gitea has limits for branches, for which hooks work.
We downgraded gitea to version 1.14.0+dev-514-gd2ee1221c and hooks work well again.
...
Screenshots

We need logs to be able to help you, what do the webhook logs say, what do the standard logs say?

Actually there is nothing interesting in gitea logs, though trace log level is being used.
In project settings i can see that hook was successfully sent and 200 code was returned.
No pipeline started though when i push new branch. But when i create new pull request from this branch, jenkins job starts successfully.
I know it looks like its not a gitea bug but with previous gitea version everything worked well: both branch and pull request hooks started a new job. And we didn't update anything else except gitea. In jenkins logs there are also no errors.

I recommend opening up a ticket with the jenkins plugin then. As such I will close this ticket.

I recommend opening up a ticket with the jenkins plugin then. As such I will close this ticket.

Do you know how to do it? It's not possible to create an issue without logging in and its not possible to sign up there cause i always get an error))

I'm afraid I've never filed a ticket with them, perhaps there is a public email address you can email?


Regenerate track 1 crates

Update codegen branch URL, versions
Update authored branch URLs, versions
Bump crate versions and ignore problematic api-version
Regenerate mgmt, svc crates

FWIW, the new PRs reference the legacy branch, which has not yet been created. I'm assuming that isn't going to be a problem.
From: Heath Stewart @.>
Sent: Friday, October 4, 2024 9:45 AM
To: Azure/azure-sdk-for-rust @.>
Cc: Larry Osterman @.>; Mention @.>
Subject: Re: [Azure/azure-sdk-for-rust] Regenerate track 1 crates (PR #1835)
@RickWinterhttps://github.com/RickWinter, @LarryOstermanhttps://github.com/LarryOsterman, @demorayhttps://github.com/demoray, @cataggarhttps://github.com/cataggar for your reviewing ease, I broke the commits apart such that the first three are the cruft of the change while the 4th (and probably not last as I fix up style, test issues) is the regeneration:

   Update codegen branch URLs, versions<https://github.com/Azure/azure-sdk-for-rust/pull/1835/commits/d749f2e5f7d7ff1219475529be2c3494e342aebe>

   Update authored branch URLs, versions<https://github.com/Azure/azure-sdk-for-rust/pull/1835/commits/5f9e92464a6cdd7fc8d3ad25b81992058cd6bcf5>

   Bump crate versions and ignore problematic api-versions<https://github.com/Azure/azure-sdk-for-rust/pull/1835/commits/51945611e866b0e6abd21b361cd3372ca3c06862>

   Regenerate mgmt, svc crates<https://github.com/Azure/azure-sdk-for-rust/pull/1835/commits/2910998ce76858cfe108cbf28428ac605615f23d>

These focus on the individual commits within the PR, so you can still make PR comments as appropriate, click on different commits to add more comments as appropriate, and finally commit. GitHub will remember (uses browser local storage).

Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-rust/pull/1835#issuecomment-2394095783, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB6W4DHDQGG4EQN4BK5B6MLZZ3AYTAVCNFSM6AAAAABPMHFSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGA4TKNZYGM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

If @LarryOsterman isn't good enough, I don't know who is. Overriding policy...


Add segments element

WIP to implement segments as described here: https://semantic-ui.com/elements/segment.html#segments
Haven't added docs or examples yet.

Hi @philngo, is this still WIP?

I've realized that for my own needs, dropping to plain css () is perfectly sufficient. I'm no longer working on this actively, so if this is a priority for anyone else, I don't want to block future work by sitting on it and doing nothing - sorry about that.

No problem!


Country Guide App

Describe the project
I want to add a project made using HTML,CSS and JAVASCRIPT that allows the user to search for a particular country and then displays the information related to that country.
Please assign me this under SSOC'23
Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[x] New Project

Additional context
Add any other context or screenshots about the project here.
Screenshots

If applicable, add screenshots to help explain your problem.

@TusharKesarwani, @zugzwang03 sir please assign me this issue under SSOC 2.0

@zugzwang03 @TusharKesarwani sir, please assign this project to me to work under SSoC 2.0 program


Ensure 'hidden flow' count doesn't include subflows

Fixes #3707

Coverage decreased (-0.03%) to 68.269% when pulling 7af3acde9ee0edf836422857aeea627c4f6073e0 on fix-hide-flows-count into dd0d1e700e8b8e9cfdaadf6ca39160fcdf8ecadb on master.


Support for BOOST_ASIO_NO_TS_EXECUTORS

Hi,
First of all thanks for the great work!
I'm using this library as part of a bigger project that already includes boost and defines BOOST_ASIO_NO_TS_EXECUTORS.
This macro limits boost asio from using the existing Networking TS-style executors.
Thus only the Proposed Standard Executors can be used with boost asio.
The main problem is the strand / null_strand in this case.
I'll submit a PR for the required changes.
Thanks,
Dino

Closed as PR #830 has been merged.


One-liner in bandit config to skip B101 assert_used in files matching a filter

Currently you can exclude a directory and you can skip certain tests across all scanned files. It would be very handy to be able to exclude test_* pytest files from the B101 assert test with a simple one liner in the .bandit config file.
This is a feature request for something like:
In .bandit
[bandit]
pytest_filter: test_* #excludes B101 in files matching test_*

Excluding all B101 is not a good solution, because I want to know about B101 in non-test modules.
Also, I'd like to be able to exclude on file filter like test_* rather than directory test/ because that filter works better across projects I have seen where test directory might not be named consistently, but all the pytests are generally named a special way e.g. test_*
This will allow a more general (across projects) config file to be set up.

Does #450 satisfy this feature request?

@ericwb can you elaborate on how you would use #450 to exclude the use of asserts just in the test files?

@ericwb I'd also be curious to know how #450 can be used to address this?

Does this not work anymore?

Based on this comment,

when using --recursive the whole path is fnmatched against the
glob_list, therefore an --exclude_dir expression test_*.py doesn't
matches and excludes (py)test files in subdirectories, for that
*/test_*.py is needed.

The following configuration should solve your problem:
assert_used:
  skips: ["*/test_*.py", "*/test_*.py"]


Use Auto-completion Outside String

Is it possible to have auto-completion for paths outside of strings? I have to type ", use the auto-completion and then remove the " afterwards.

I'm not sure how good that would work out considering it will get triggered when you do math expressions
2 / 3.
What type of files are you working on ? Maybe we can limit it for a specific scope.

I'd like to use this for various different purposes, and I have disabled the automatic triggering for completion anyway. I understand your urge to limit the scope as it can get quite annoying.
What do you think about adding a config setting for this. False by default, and if set to true, path auto-completion can be used within every context.
A different approach would be to have a dedicated shortcut for triggering path auto-completion, similar to VIM's ctrl-x ctrl-f. This would then trigger auto-completion wherever the cursor is located only showing paths. Yet I do not know whether this fine grained control is possible in VSCode.

Any updates?

I looked at this a bit and limiting the scope is not the only problem here. The most tricky part is extracting the path that was already inserted by the user.
If we have something like import aa from '/aa/bb/' we know that the base path is /aa/bb/ because of quotes.
However if we extend it to work in any situation we could end up with a scenario like open ~/settings/. All the characters on that line are valid identifiers in a path. Because of this ambiguity we would end up with incorrect results most of the times.
Currently the best we can get is that workaround with the quotes.

I see your point. I think it would be sufficient to extract the already inserted path by just matching the previous WORD (delimited by whitespace). Not only is this also the way it is implemented in Vim, but should also work in most cases as spaces are discourage anyway.
Yet I understand if you'd rather not implement a feature which only works in 9 of 10 use-cases. Although I'd appreciate adding it anyway and having to manually bind a shortcut to use it.


Scenario: Add support for panes

This is the megathread for tracking all the work related to Panes in the Windows Terminal.
1.0 Features

1.0 Features

[x] Original issue: #532 -> added in #825
[x] #991 Panes should be resizable with the keyboard. (fixed PR #1207)
[x] #995 The user should be able to navigate the focus of panes with the keyboard, instead of requiring the mouse. (PR #1910)
[x] #993 There's no keyboard shortcut for "ClosePane"
[x] #998 Open panes with a specific profile
[x] #994 There should be some sort of UI to indicate that a particular pane is focused, more than just the blinking cursor. tmux accomplishes this by colorizing the separators adjacent to the active pane. Another idea is displaying a small outline around the focused pane (like when tabbing through controls on a webpage). (PR:#3060)
[x] #999 If you click on the separator's between panes, then no panes will be focused (PR #3540)
[x] #3045 Moving focus between panes doesn't always work (PR #3958)
[x] #3544 Add a default keybinding for panes, to enable them by default. (PR #3585)
[x] #2834 Snap to character grid when resizing window (PR #3181)
[x] #3960 Automatic splits similar to tiling window managers

1.x features / bugs

[x] #1756 The user should be able to configure what profile is used for splitting a pane. Currently, the default profile is used, but it's possible a user might want to create a new pane with the parent pane's profile.
[ ] #992 Panes should be resizable with the mouse. The user should be able to drag the separator for a pair of panes, and have the content between them resize as the separator moves.
[ ] #4692 Pane focus movement doesn't remember where it came from

2.0 Features / Bugs

[ ] #2398 Move focus to the visually adjacent pane, not just the first pane on the other side of the separator.

[ ] Also: #4692 Pane focus movement doesn't remember where it came from

[x] #3062 Add a configuration object for focused vs unfocused state
[x] #996 The user should be able to zoom a pane, to make the pane take the entire size of the terminal window temporarily.
[ ] #5803 moveFocus to pane using number (See also #5464)
[ ] #3917 Panel split background ignores requestedTheme, follows system app mode
[x] Add a percent parameter to SplitPane #3997
[ ] wt split-pane (multiple copies) seems to have occasional focus issues #6586
[x] #2871 Add nextPane and prevPane keybindings (in PR #8183)
[x] #1001 Panes should have an optional motion effect on entrance
[x] Panes should have an animation when they're closed, too #7366

Panes Titlebar Follow-ups - See #4998

[ ] Add title to split window #4717
[ ] #7075 Allow moving panes to other tabs
[ ] Panes should have editable titles #7290

Backlog items

[ ] The user should be able to tear-off tabs and dock them as a split (See this comment)

[ ] #4587 Drag & Drop Tabs to create a Pane
[ ] Related, but different: Drag entries from the new tab menu to create panes #9229

[ ] #997 A pane doesn't necessarily need to host a terminal. It could potentially host another UIElement. One could imagine enabling a user to quickly open up a Browser pane to search for a particular string without needing to leave the terminal. (spec #1080)
[ ] #3656 Add support for tmux Control Mode
[ ] #2634 Support broadcast input (Spec #9365)
[ ] #4259 Open a new pane with the environment vars of the parent
[ ] #4340 Choose Direction to Split Pane
[ ] A switch panes option? Like a switchLeft, switchRight, switchUp, switchDown, to allow the user to rearrange the panes layout (https://github.com/microsoft/terminal/issues/1000#issuecomment-578665067)
[ ] #4922 Swap panes
[ ] #4941 Please add support closePaneRight/Left/Up/Down
[ ] #5025 Open panes without keybindings
[ ] #6002 Split panes equally in size
[ ] #6219 Pass through moveFocus keys when the user has no panes
[x] #6459 Pane focus follows mouse (PR: #8965)
[ ] Moving focus with a zoomed pane should just zoom the adjacent pane #7215
[ ] Add a fluent animation for pane zooming #7216
[ ] Pane opening animation should not flash the default pane backdrop #7365
[ ] Use a Clip rect for Pane animations instead of the Width/Height #7436
[ ] Golden Ratio mode #8562
[ ] #3586 Open a new pane by prompting the user for which profile to use

Theming items

[ ] #3061 Add a setting to manually set the Pane highlight color  (PR #3752)

[ ] Add configurable Pane border hover color #8564

[ ] #3063 Add a setting to manually set the Pane border width
[ ] #3708 Add option for more subtle pane focus border

We didn't even commit the keybinding constants with which people could opt in. ☹

I noticed that @zadjii-msft added the keybindings for panes back. I'm assuming it made it into 0.1.1621.0?
If I add this block:
                "command" : "splitHorizontal",
                "keys" :
                [
                    "ctrl+shift+-"
                ]
            },
            {
                "command" : "splitVertical",
                "keys" :
                [
                    "ctrl+shift+|"
                ]
            },

Only Horizontal works. I noticed that if I close Windows Terminal it deletes the splitVertical keybinding from profiles.json.

@decriptor I believe that's because '|' isn't actually a key we support in the keybindings quite yet - see #1212

@zadjii-msft I believe you are right. I used ctrl+1 as a test and it didn't remove it.

I know you really want it, @zadjii-msft but you have #998 on your list twice ;-)

@jaykul good catch, those are supposed to be separate issues.

@zadjii-msft and @Jaykul - just let me know where to send the care packages (hoppy beverages / candy / beef jerky / etc) 😆
Cannot wait for panes to be implemented!

Any chance of getting "focus follows mouse" like in iterm2 and other terminals? So if this setting is turned on, the active pane would be the pane you have your mouse pointer over, without having to click it first.

I know you guys are hard at work on this, literally the only thing keeping it from being a full-time tool for me.
My request is that you look at this product for inspiration for split panes:
https://gnunn1.github.io/tilix-web/
After trying so many terminals, I feel like this is the one software that truly gets panes done the right way.
I am presently running this under Xming as a work around for the lack of decent split pane terminals under Windows.

https://gnunn1.github.io/tilix-web/
After trying so many terminals, I feel like this is the one software that truly gets panes done the right way.

What's the difference with Terminator? This paned-terminal worked the best for everything I did; usually in a 4 pane setup! Awesome when developing!

@phalox the keybindings in Tilix are pretty awesome and it's a very polished GTK 3 app. If you like Terminator there's a chance you'll love Tilix ;-)

What's the difference with Terminator? This paned-terminal worked the best for everything I did; >usually in a 4 pane setup! Awesome when developing!

I actually loved Terminator for the longest time and found Tilix during the Unity -> Gnome transition with Ubuntu.   Terminator isn't seeing a lot of development these days and a number of bugs haven't been fixed.   Like @LukeCarrier said, Tilix is just way more polished and has some neat features like the easy of keybindings and of multi-tab input and more advanced tab grouping.
I think both Tilix and Terminator are suitable for this project to use as a basis for how panes should work.

Last RN states that there are two new keybindings resizePane{Up,Down,Left,Right} & moveFocus{Up,Down,Left,Right} is there any sample how this configuration should look like? I cannot write any valid json to handle that.

@ksawerykarwacki this is the blob I use for my pane settings typically:

            { "keys": ["alt+shift+-"], "command": "splitHorizontal" },
            { "keys": ["alt+shift+plus"], "command": "splitVertical" },

            { "keys": ["alt+shift+left"], "command": "resizePaneLeft" },
            { "keys": ["alt+shift+right"], "command": "resizePaneRight" },
            { "keys": ["alt+shift+up"], "command": "resizePaneUp" },
            { "keys": ["alt+shift+down"], "command": "resizePaneDown" },

            { "keys": ["alt+left"], "command": "moveFocusLeft" },
            { "keys": ["alt+right"], "command": "moveFocusRight" },
            { "keys": ["alt+up"], "command": "moveFocusUp" },
            { "keys": ["alt+down"], "command": "moveFocusDown" },

            { "keys": ["ctrl+shift+w"], "command": "closePane" },

What about the feature of dynamically resizing a pane to displayed contents when double clicking it's right separator?

FWIW, I think #756 is pretty important to calling pane support "done". I've been using ConEmu up until now, and it's nice how it opens up with my console panes pre-split and sized the way I like, and with the correct profiles loaded.

I completely agree that this is not the main feature, since soon it will not need to be implemented inside the Windows Terminal at all, as modern tmuxes will perform this functionality, and this will be cross-platform.
https://youtu.be/5h1fJ-es8kQ

I think that this is not the main feature, since soon it will not need to be implemented inside the ...

Very much disagree because tmux isn't a user friendly, modern UI experience.  Tmux and similar tools (like Byobu) are great for remote panes/tabs but it's not a great mouse/desktop experience.  The best Linux terminals and terminals competing for usage on Windows are implementing split panes.
Also, I am testing split panes now with the latest Windows store build and it's working amazingly well.   Keybinds are splitVertical and splitHorizontal for those looking to test as well.

I agree that a class of applications like "tmux / Byobu" is absolutely not convenient, but I had in view of terminal multipliers in the general sense, which are able to flexibly handle mouse input and interact with the user at the highest level, but at the same time remain within the text mode.
It seems to me that it has now become possible to do this, among other things, thanks to the modern Unicode standard, with which you can display user interface elements in text mode.

These problems cannot be solved with the  splits:

about a hundred (e.g., ssh) connections;
text input multicursor;
output screen size limited to terminal window size;

Standalone terminal multiplexer solves these problems and, in addition, can be nested in order to form an interprocess chain for logically grouping (e.g., ssh) of connections.

This is awesome!! didn't know it worked. works flawlessly
What I need is a way to open a bunch of scripts into panes from an external shortcut (4 webpacks in a single terminal with 4 panes automatically). Is there a way to do that?

Thanks @zadjii-msft ! you deserver the AwesomeDudePrize :)

First of all, thanks for all of your work about panes.
I don't have a feature request but it took a while for me to find this issue, so there should be some information on PowerShell docs about these features, or at least some links here with the command tags. Maybe adding to the first entry here something like "Add docs"?

@mucahityilmaz thanks for the request! Panes are intentionally underdocumented because they’re not yet finished.

(And I believe docs will come in with “enable a key binding for them by default”) :smile:

In #532, from @zadjii-msft:

I did not know that Tmux Control Mode even existed. That sounds really awesome, I'm totally on board with trying to make that work somehow.

Was there any further thought put into this? I love tmux control mode - it's literally the only thing keeping me tethered to MacOS at work. If it were implemented, I'd trash my Mac and request a Windows laptop immediately.
I'd love to see it listed as a post-1.0 milestone :)

@matt-kempster You're right, we should have a tmux control mode task. Thanks for keeping me honest :)

I am sure this is on the radar, but the panes aren't mouse/keyboard re-sizable right now (unless there's a hidden tmux like keybinding I just don't know about).   I'd like to be able to drag on the splitters like Terminator or Tilix.

@jwhipp

[x] #991 Panes should be resizable with the keyboard. (fixed PR #1207)
[ ] #992 Panes should be resizable with the mouse. The user should be able to drag the separator for a pair of panes, and have the content between them resize as the separator moves.

Just a question, there's no way to open/close a pane with a mouse action?
For example, as in iTerm2, a right-click that opens a context menu where a user could select "Split pane Vertically" or "Split pane Horizzontaly".
Don't know if this was already tracked or discussed since it wasn't clear from the todo list so forgive me if this is a duplicate question : )

@gabrieledarrigo I believe you're correct, we don't really have a issue tracking specifically that request currently. It's definitely something we'd like, but probably as a part of #3337/#1912. Those are the issues tracking adding a context menu to various parts of the UI, and I think that adding splits to that menu will certainly be part of that design.

Can I have a profile that opens as a split pane? Something like:
{
    "name": "Profile3",
    "commandline": "wt -p \"Profile1\" ; split-pane -H -p \"Profile2\""
}

(Which currently opens a new instance of Windows Terminal)

Regarding the visual indication of which pane is active, I'd love to see the inactive pane(s) dimmed the way it's done in iTerm2.

@stweedie, is this what you are looking for?
#2398

that is what I was looking for, thanks

I wrote a startup script which chains multiple split-pane commands, but it always splits one of the results of the last split:

Can I convice wt somehow to also split the left or top right pane? As you can see the resulting segmentation is neither ideal, nor what all users want.
If not, is there a feature request for that?

@Trolldemorted as is mentioned in the OP:

#4340 Choose Direction to Split Pane

#4340 would allow me to specify whether I want to split the right or left pane, but not to split both, right?

Ah yes. What about #3759?

Depending how they solve it it might partially cover that, but it won't cover the "commit a batch script in your repository which starts wt in a grid layout" use case, correct? Every user would have to create a profile manually, or we'd have to touch the users' profiles in our batch script.

So, #4340 "Choose Direction to Split Pane" might be helpful yes, but then you'll still get stuck splitting panes down just one branch of the tree.
What you really want is probably #6580, which will let you move-focus in the commandline, so you'll be able to navigate to other panes and split those.
Also maybe helpful in the future:

#5803 moveFocus to pane using number (See also #5464)

again, only useful once there's a move-focus command
#2871 Add nextPane and prevPane keybindings
Same deal, you'd need nextPane & prevPane to be exposed as subcommands, not just actions

Thanks @zadjii-msft ! Let's hope #6580 will make it to the roadmap soon.
Can I specify an initial command for the shells somehow? Right now I am using -d . powershell.exe -NoExit -Command someshellcommand, but I am unable to rerun that command with arrow up + enter (it doesn't show up, only old commands from old shells are showing). Tried to do it with add-history, but without success.

"#6459 Pane focus follows mouse" can be checked off the list, a fix for it has been merged a while back.

Hi,
There are option to move panes like tmux ?


Update free-programming-books-pt_BR.md

"Performance Web" não está funcionando
What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)
How do we know it's really free?
For book lists, is it a book?
Checklist:

[x] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Thanks, and welcome to Free Programming Books!


pub doesn't check whether path dependencies' pubspecs were updated

When ensuring that the lockfile is up to date, pub only looks at the entrypoint package's lockfile. It should also check the lockfiles of any (transitive) path dependencies, since they may also have changed at some point.

This issue has been moved to dart-lang/pub#1091.


Since update 1.12.1098: unable to find font 'Cascadia Code'

Windows Terminal version
1.12.10982.0
Windows build number
10.0.19044.1586
Other Software
No response
Steps to reproduce
Start the application
Error message appears on startup
Expected Behavior
no errors
Actual Behavior
Error:

I suspect this might be the same bug as #12420, for which there is a pending fix (PR #12904).

Yea I'd be almost sure of it. I coulda swore we had already cherry-picked that one, but seems I was mistaken. Casual reminder for @DHowett to do the cherry-pick this morning when he wakes up.
/dup #12420

Thanks for your feedback.
As suggested in the root issue (following th duplicates) #11648 (following th duplicates), I could get rid of the warning by 'repairing' the app:

Try "Repairing" the Terminal app, by going to "Settings > Apps > {whatever Terminal Install you have} > Advanced Options > Repair". This shouldn't delete your settings. (But "Reset" will, so be careful!)


New version with fix

After landing 6a2e7545feae37fab052dfe8d5d086827c0d70ab, a new version should be created to allow the usage of the latest features without compilation error

Working on it now.   Waiting for pipelines to finish out.

7.4.1 has been released.

Thanks @CraZySacX!


Compiler internal error within iterator_factory.hpp

Error summary
There is a problem on summit with the following function:
operator element() const { return element{dominant(), secondary()}; }

Here is the error
In file included from ginkgo-github/reference/matrix/csr_kernels.cpp:51:0:
ginkgo-github/core/base/iterator_factory.hpp: In member function 'gko::detail::IteratorFactory<ToSortType, SecondaryType>::Reference::operator gko::detail::IteratorFactory<ToSortType, SecondaryType>::element() const [with ToSortType = long int; SecondaryType = std::complex<float>]':
ginkgo-github/core/base/iterator_factory.hpp:149:74: internal compiler error: in emit_move_insn, at expr.c:3547
         operator element() const { return element{dominant(), secondary()}; }
                                                                         ^

Ugly fix
The following makes it go away:
operator element() const
{
    return element{parent_.dominant_values_[arr_index_],
                   parent_.secondary_values_[arr_index_]};
}

Environment details
$ gcc --version
gcc (GCC) 6.4.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ module li

Currently Loaded Modules:
  1) hsi/5.0.2.p5   3) lsf-tools/2.0           5) DefApps     7) cuda/9.2.148   9) spectrum-mpi/<IP_ADDRESS>-20190419
  2) xalt/1.1.3     4) darshan-runtime/3.1.7   6) gcc/6.4.0   8) cmake/3.14.2

Important CMake variables
# This is the CMakeCache file.
# For build in directory: build-ginkgo-spmv
# It was generated by CMake: /autofs/nccs-svm1_sw/summit/.swci/0-core/opt/spack/20180914/linux-rhel7-ppc64le/gcc-4.8.5/cmake-3.14.2-3zkrrk4chuq6wfhvxpmen2gzdpaoiorw/bin/cmake
# You can edit this file to change values found and used by cmake.
# If you do not want to change any of the values, simply exit the editor.
# If you do want to change a value, simply edit, save, and exit the editor.
# The syntax for the file is as follows:
# KEY:TYPE=VALUE
# KEY is the name of a variable in the cache.
# TYPE is a hint to GUIs for the type of VALUE, DO NOT EDIT TYPE!.
# VALUE is the current value for the KEY.

########################
# EXTERNAL cache entries
########################

//Build shared (.so, .dylib, .dll) libraries
BUILD_SHARED_LIBS:BOOL=ON

//Build the testing tree.
BUILD_TESTING:BOOL=ON

//Path to a program.
BZRCOMMAND:FILEPATH=BZRCOMMAND-NOTFOUND

//clang-format executable
CLANG_FORMAT_EXECUTABLE:FILEPATH=CLANG_FORMAT_EXECUTABLE-NOTFOUND

//Path to a program.
CMAKE_AR:FILEPATH=/usr/bin/ar

//Choose the type of build.
CMAKE_BUILD_TYPE:STRING=Debug

//Enable/Disable color output during build.
CMAKE_COLOR_MAKEFILE:BOOL=ON

//CUDA compiler
CMAKE_CUDA_COMPILER:FILEPATH=/sw/summit/cuda/9.2.148/bin/nvcc

//Flags used by the CUDA compiler during all build types.
CMAKE_CUDA_FLAGS:STRING=

//Flags used by the CUDA compiler during DEBUG builds.
CMAKE_CUDA_FLAGS_DEBUG:STRING=-g

//Flags used by the CUDA compiler during MINSIZEREL builds.
CMAKE_CUDA_FLAGS_MINSIZEREL:STRING=-O1 -DNDEBUG

//Flags used by the CUDA compiler during RELEASE builds.
CMAKE_CUDA_FLAGS_RELEASE:STRING=-O3 -DNDEBUG

//Flags used by the CUDA compiler during RELWITHDEBINFO builds.
CMAKE_CUDA_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG

//CXX compiler
CMAKE_CXX_COMPILER:FILEPATH=/sw/summit/gcc/6.4.0/bin/g++

//Build Ginkgo's benchmarks
GINKGO_BUILD_BENCHMARKS:BOOL=ON

//Compile kernels for NVIDIA GPUs
GINKGO_BUILD_CUDA:BOOL=on

//Generate documentation
GINKGO_BUILD_DOC:BOOL=OFF

//Build Ginkgo's examples
GINKGO_BUILD_EXAMPLES:BOOL=ON

//Build the external-lib-interfacing with deal.II, you need to
// link the deal.II library.
GINKGO_BUILD_EXTLIB_EXAMPLE:BOOL=OFF

//Compile OpenMP kernels for CPU
GINKGO_BUILD_OMP:BOOL=on

//Compile reference CPU kernels
GINKGO_BUILD_REFERENCE:BOOL=ON

//Generate build files for unit tests
GINKGO_BUILD_TESTS:BOOL=ON

//Set the required CXX compiler flags, mainly used for warnings.
// Current default is `-Wpedantic`
GINKGO_COMPILER_FLAGS:STRING=-Wpedantic

//A list of target NVIDIA GPU achitectures. See README.md for more
// detail.
GINKGO_CUDA_ARCHITECTURES:STRING=Auto

//Set the required NVCC compiler flags, mainly used for warnings.
// Current default is an empty string
GINKGO_CUDA_COMPILER_FLAGS:STRING=

//Add development tools to the build system
GINKGO_DEVEL_TOOLS:BOOL=ON

//Make Ginkgo export its build directory to the CMake package registry.
GINKGO_EXPORT_BUILD_DIR:BOOL=OFF

//Use all the optimizations for the CUDA Jacobi algorithm
GINKGO_JACOBI_FULL_OPTIMIZATIONS:BOOL=OFF

//Do not update dependencies each time the project is rebuilt
GINKGO_SKIP_DEPENDENCY_UPDATE:BOOL=ON

//Verbosity level. Put 0 to turn off. 1 activates a few important
// messages.
GINKGO_VERBOSE_LEVEL:STRING=1

//Make Ginkgo call `clang-tidy` to find programming issues.
GINKGO_WITH_CLANG_TIDY:BOOL=OFF

//Make Ginkgo call `iwyu` (Include What You Use) to find include
// issues.
GINKGO_WITH_IWYU:BOOL=OFF

For some reason, I think this only happens with -DCMAKE_BUILD_TYPE=DEBUG.

Was the ABI warning gone after your fix?
That was actually my first implementation of that cast, then, I decided that the functions make it a lot easier.
Currently, I cannot tell why this is happening, I will try do do some reading on that.

Which warning? What I reported is an error internal compiler error:

I was talking about the note:
note: the ABI of passing structure with complex float member has changed in GCC 4.4

What compiler is summit actually using?


[Docs]: fix broken reference

Related Issues

N/A
Short Description and Why It's Useful

Updated the broken badge reference to point to the master branch.
Screenshots of Visual Changes before/after (if There Are Any)

N/A
Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[x] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

Thanks!


Add pagination to api endpoints

Proposed solution
Allow pagination of queries based on some preset page size (5,10,20 maybe?). See more: https://www.codementor.io/@arpitbhayani/fast-and-efficient-pagination-in-mongodb-9095flbqr#approach-1-using-cursorskip-and-cursorlimit
DoD (Definition of Done)
Responses are paginated
Testing
Unit / integration

Pagination should be reported for queries in following way:
{
"page": {
"page": 0,
"size": 0,
"totalPages": 0,
"totalObjects": 0
},
see http://editor.swagger.io/?url=https://raw.githubusercontent.com/CSCfi/metadata-submitter/develop/docs/specification.yml


[10.0.0-alpha.5] _cameraRef?.current?.setCamera causing markerpoint get detached from maps-base

<MapLibreGL.MapView
    ref={_mapRef}
    style={mapStyle}
    styleURL={mapStyleUrl}
    zoomEnabled={true}
    logoEnabled={false}
    compassEnabled={false}
    attributionEnabled={true}
    attributionPosition={{ bottom: getSize.m(8), left: getSize.m(8) }}
    pitchEnabled
    rotateEnabled
    compassViewPosition={2}
    onDidFinishLoadingMap={handleMapLoaded}>
    <MapLibreGL.Camera
        ref={_cameraRef}
        defaultSettings={{
            bounds: boundingBox,
        }}
        followUserLocation={showMyLocation}
        followUserMode={'normal'}
        followZoomLevel={13}
    />
    <MapLibreGL.UserLocation
        renderMode={Platform.OS === 'ios' ? 'normal' : 'native'}
        showsUserHeadingIndicator={true}
        visible={showMyLocation}
    />

    {renderMarkerPoint}
    {renderUnSelectedMarkerPoint}
    {renderSelectedMarkerPoint}
</MapLibreGL.MapView>

context:
{renderMarkerPoint}
{renderUnSelectedMarkerPoint}
{renderSelectedMarkerPoint}
are using
MapLibreGL.PointAnnotation
MapLibreGL.ShapeSource
MapLibreGL.LineLayer
tap on any of them, would trigger this function to move camera (which triggered by onSelected prop)
    const onChangeViewCamera = React.useCallback(({ lon, lat }) => {
        console.log('Moving camera to: ', lon, lat);
        _cameraRef?.current?.setCamera({
            centerCoordinate: [lon, lat],
            animationDuration: 800,
            animationMode: 'flyTo',
            zoomLevel: 14,
            padding: handlePadding(getSize.m(30)),
        });
    }, []);

Expected Behavior
Everything works well on v8 or v9 as normal, just move camera only when tapping markers
Actual Behavior
On pre-release version v10
all of markers, and camera view get detached from map base, please take a look on this video:
https://github.com/maplibre/maplibre-react-native/assets/77522114/340d9615-b5a2-428d-8c51-599b01846e1f
Version(s) affected

Platform: [Android, iOS]
maplibre-react-native Version [10.0.0-alpha.5]
React Native Version [0.72.10]

Did you fix the issue? @ngdbao

Did you fix the issue? @ngdbao

sadly, not yet :)

can you share the code used for adding the markers or the vector layer

can you share the code used for adding the markers or the vector layer

it's simply a PointAnnotation with prop draggable false, wrapping a raw react native component children

@ngdbao Could you show more code? Maybe some small example which will help us reproduce error? Especially code related to adding your markers.

Hi, I renderred the markerpoint by Pointannotation geo coordinate and anchor like this:
    const renderMarkerPoint = useMemo(
        () =>
            dataCheckpointWithKeyid?.map((mark, index) => {
                return viewMapLoaded ? (
                    <MarkerPoint
                        key={`${(index || -1) + 1}`}
                        index={index}
                        item={mark}
                        onPressChangePoint={onPressChangePoint}
                        // onChangeViewCamera={onChangeViewCamera}
                        isLastItem={index === dataCheckpointWithKeyid.length - 1}
                        isFirstItem={index === 0}
                    />
                ) : null;
            }),
        [dataCheckpointWithKeyid, viewMapLoaded],
    );

const MarkerPoint = ({
    item,
    index,
    onPressChangePoint,
    isLastItem,
    isFirstItem,
}) => {
    const [imageLoaded, setImageLoaded] = useState(false);
    const markerRef = useRef<any>(null);

    const id = String(index);
    const handleOnLoad = useCallback(() => {
        Platform.OS === 'android' ? setImageLoaded(true) : null;
    }, []);

    useEffect(() => {
        if (imageLoaded) {
            markerRef?.current?.refresh();
            console.log(`====Image ${index} refresh====`);
        }
    }, [imageLoaded]);

    const handleSelected = useCallback(() => {
        onPressChangePoint?.(index);
    }, [index, onPressChangePoint]);

    const anchor = useMemo(() => {
        return isLastItem ? { x: 0.5, y: 0.4 } : isFirstItem ? { x: 0.5, y: 1 } : { x: 0.46, y: 0.21 };
    }, [isFirstItem, isLastItem]);

    const MapCheckPoint = (
        <MapLibreGL.PointAnnotation
            key={id}
            ref={markerRef}
            id={id}
            anchor={anchor}
            coordinate={[item?.geo?.lon || 0, item?.geo?.lat || 0]}
            draggable={false}
            onSelected={handleSelected}>
            <View style={stylesCallout.checkpointContainer}>
                <View style={stylesCallout.container}>
                    <View style={stylesCallout.content}>
                        <AppImage
                            disabled={true}
                            url={item?.images}
                            defaultSource={CHECKPOINT_ICON}
                            style={stylesCallout.startImage}
                            onLoad={handleOnLoad}
                            shouldLoading
                            resizeMode="cover"
                        />
                        <AppText style={stylesCallout.textStart}>{MapDefaultText.START || ''}</AppText>
                        <AppText numberOfLines={1} style={stylesCallout.locationStart}>
                            {truncateText(item?.location, 25) || ''}
                        </AppText>
                    </View>
                </View>
            </View>
        </MapLibreGL.PointAnnotation>
    );

    return MapCheckPoint;
};

MarkerPoint.propTypes = {
    item: PropTypes.any,
    index: PropTypes.number,
    onPressChangePoint: PropTypes.func,
    isLastItem: PropTypes.bool,
    isFirstItem: PropTypes.bool,
    onChangeViewCamera: PropTypes.func,
    viewMapLoaded: PropTypes.bool,
};

export default React.memo(MarkerPoint);

only PointAnnotation, but ShapeSource or LineLayer works fine

I'm having a similar issue with PointAnnotation being detached from the basemap coordinates, but only on iOS. On Android, my PointAnnotations work wonderfully. On iOS, they are all stuck at the top-left (0,0) view coordinates of the MapView.
I've determined that the coordinate properties of the PointAnnotations are correctly being set with valid geographic coordinates.
I'm exploring the idea of migrating from PointAnnotation to ShapeSource and SymbolLayer... But this is quite painful. As far as I can tell, PointAnnotation simply does not work on iOS.
I'm on the bleeding edge, with 10.0.0-alpha.10 and I've customized the iOS Podfile to work with the latest MapLibre Native 6.5.4.
If anyone can point me to maplibre-react-native versions where PointAnnotation is definitely working on iOS, I would appreciate it.

Is anyone still seeing such problems with 10.0.0-alpha.25?

Is anyone still seeing such problems with 10.0.0-alpha.25? I'm using MapLibreGL.PointAnnotation successfully, even with drag and drop. When setCamera is called, it stays put where it should be.

In my testing with 10.0.0-alpha.25, PointAnnotation is now actually being positioned properly at geographic coordinates on iOS! That's progress!
Unfortunately, dragging is only working for me with PointAnnotation on Android.
On iOS:

PointAnnotation.draggable property doesn't work to enable dragging.
PointAnnotation.onDrag(), onDragStart() etc. do not fire.

Will need a reproduction. It's working in our app:
https://github.com/user-attachments/assets/95aa7237-4bbe-40cb-bab0-8ef0fe3d201d

Hello, I can confirm this issue has gone in alpha26 ✅

Closing this, as the initial report is fixed.
@brentforder if you are experiencing problems with drag and drop, feel free to open another issue with a reproduction.


Fix Jest Tests

All the jest tests are broken. We need to fix it.
Current Tests:

[ ] tests/pages/index.test.tsx
[ ]  tests/components/search/Total.test.tsx
[ ]  tests/components/search/List.test.tsx
[ ]  tests/components/search/Item.test.tsx
[ ]  tests/components/search/Form.test.tsx

The WordPress API to use is v2 and here are the formats.
Posts: ${URL}/wp-json/wp/v2/posts
Posts Slug: ${URL}/wp/v2/posts?slug=tweet-from-usdatagov-1654

FIXED. @abhishekgahlot says this is all done - see https://github.com/datopian/portal.js/commit/0c80f8479419fc79b6d8d44e125b614d36c84148


feat: Add Increment API

Add proto definitions for rpc, request, and response for Increment.
Increment takes a key, an integer by which to increment by (can be negative to decrement), and a ttl. If the key does not already exist, it initializes it at 0.
The Increment operation maybe may fail if the stored value (which is stored as a string) does not parse to a number. Currently this error will surface as an Unavailable error; in my opinion in order for this API to be usable we will want to make sure we surface the full error.

Currently this error will surface as an Unavailable error; in my opinion in order for this API to be usable we will want to make sure we surface the full error.

For dictionary increment, we return the grpc error code FAILED_PRECONDITION when this happens


整理大量带中文标点的文本时，意外中断（重启解决了，可能是版本冲突）

已解决

@running-frog It looks like maybe you were using an older version of the client, but it was resolved? I'll close the issue. LMK if it's still a problem.


WIP: COCO Reader KeyPoints & HRNet training support

*added support to read coco keypoint meta data
*added support to generate JointsData (meta data) required for HRNet Pose estimation

We will create a separate PR for below comments since the changes needed are generic :

Return a reference to map
2. Vector of img_size to img_size
command line option for each reader type instead of relying on #defines in rali_unittests.cpp

@rrawther i have done the code clean up and removed unwanted spaces. The changes can be merged now

@paveltc : make sure the tests are passing for rocAL

@kiritigowda : Can this be merged?

@rrawther & @paveltc can you approve this PR?


Cleanup Oncalls and add Tests

Added a unique id to the oncall container which ensures list works
with the Collection implemented pagination logic (requires an id).
Removed the overridden show() method which is inconsistent with how
show works on other objects (the oncalls endpoint does not support
getting a single oncall, as there is no PagerDuty id for them).
Also tested that filtering with oncalls.list() works (for example oncalls.list(schedule_ids=['<id>']).
I also added some tests for the extensions and oncalls objects. I don't think the extensions tests are exhaustive yet, but it's a start. Likely needs more work to ensure create/updating extensions works.

Hey @balajijegan could you check and see if this change works for your usecase? I tested that this works locally:
p.oncalls.list(schedule_ids=['<id>'])

Hey @balajijegan could you check and see if this change works for your usecase? I tested that this works locally:
p.oncalls.list(schedule_ids=['<id>'])

This returns a generator, but when you parse it, it is empty.

Hey @balajijegan could you check and see if this change works for your usecase? I tested that this works locally:
p.oncalls.list(schedule_ids=['<id>'])

This returns a generator, but when you parse it, it is empty.

Even if you iterate over it? I tested like this:
    for o in pager.oncalls.list(schedule_ids=['XXXXXX']):
        print o.schedule

and did get the expected result.

Unfortunately, it is not getting the result for me. This one works though:
balaji:~/code/pygerduty (master)  $ git diff
diff --git a/pygerduty/v2.py b/pygerduty/v2.py
index f25c154..5b555bf 100755
--- a/pygerduty/v2.py
+++ b/pygerduty/v2.py
@@ -186,11 +186,8 @@ class Collection(object):
                 for item in this_paginated_result:
                     # add items to seen_items only if id is present in response
                     # oncalls does not have a id in response
-                    if not hasattr(item, 'id'):
-                        continue
-                    if item.id in seen_items:
-                        continue
-                    seen_items.add(item.id)
+                    if hasattr(item, 'id') and item.id not in seen_items:
+                        seen_items.add(item.id)
                     yield item

Hmm interesting. Just to check, you're testing against this diff right? The Oncalls object should have an overridden __init__ setting an id on itself.
Are you running python 2 or 3? I realized I've been testing against 2, but perhaps this is py3 specific.

I just realized what is going on. I did not see your changes in this commit - https://github.com/dropbox/pygerduty/pull/72/commits/8a5610141f7af082d2fa50e4eee501816b6f8af5. I rebased my master with your changes and things are working as expected.
The only additional change that might be useful is to do a not implemented for calls other than list
Thanks for the fix

Hmm interesting. Just to check, you're testing against this diff right? The Oncalls object should have an overridden __init__ setting an id on itself.

I missed this comment but I just saw the additional commit on the PR. I did not get a notification other than your comments and I missed on of your comment earlier. All is well now.

@cugini-dbx  What are the next steps here?

thanks @cugini-dbx


Add non-working info buttons to the UI

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Update tool-bar package provider service

The Tool Bar package is going to release a new version after a complete overhaul of it's underlying code. The new version requires that the Tool Bar consumed service semver is updated too. This PR addresses that issue.
There are some changes to the API, but it looks like your plugin isn't affected. Of course it's recommended to test these changes.
Ref suda/tool-bar#141

Hi @jerone
Thanks for contributing!


[BUG] add margin to navigation links

Issue:
There is space between the NavBar links. So add margin to navigation links.

Hey @RakeshSangem, I would like to help with this issue. :)

Hey @RakeshSangem, I would like to help with this issue. :)

Sure! I assigned to you:)


[Event Change] Report 7390 OnBeforeWhseJnlLineInsert

Hi AL team,
we have to insert additional lines for a separate criteria. Therefore we need an additional paramter "NextLineNo" as VAR in the OnBeforeWhseJnlLineInsert:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


fix: checkbox Icon was uncentered because missing justify content and align items in parent container

What was was changed?
Added justify-content: center and align-items: center to the parent container named CheckboxIndicator located in
packages\design-system\src\components\Checkbox\Checkbox.tsx
Why is it needed?
Checkbox Icon was not centered within parent container
How to test it?
You can test this feature by running the application and attempting the checkbox module.
Related issue(s)/PR(s)
Related Issue:  https://github.com/strapi/design-system/issues/1819
fixes #1819

hey @PlanckConst thanks for the contribution! We'll take a look soon 🙏

Hey @PlanckConst! Thanks, it looks much better :)
I just added @remidej for the code review.

Glad I could help! My first open source contribution~

@PlanckConst congrats! 😄

Do i have to do anything to resolve the chromatic pull request?

Do i have to resolve the chromatic test?

No need to worry about the chromatic test that was failing, for some reason I couldn't merge the PR last night but I'll get it merged at some point today. Thanks for the contribution.


Added DefaultIfEmpty for alternative enumeration

In case we want to check if our enumeration is empty and in that case fallback to some default enumeration, this method could help.

This repository is read-only as mentioned in the readme.
You could file an issue for your API addition on https://github.com/dotnet/corefx instead.


[FluidRelay]Generate fluid-relay with codegen v2

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

closes #22938
az fluid-relay server create
az fluid-relay server update
az fluid-relay server list
az fluid-relay server list-key
az fluid-relay server regenerate-key
az fluid-relay server show
az fluid-relay server delete
az fluid-relay container show
az fluid-relay container list
az fluid-relay container delete
General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

FluidRelay


complete ScalaCheck 1.15 upgrade

scala-steward missed a spot
it would be convenient for me in the Scala community build if this were merged

yay, CI likes it.


appfairy_config.js not working

When trying to use a custom config, it won't read the config from the project root. Also, when triggered via the CLI, it says it can't find a path. Any thoughts?

 How did you run the command exactly

There was a typo in the config name in README.md

Should be af_config.js


Couple of issues

Im running messenger <IP_ADDRESS>1443794 on OS X 10.11.2 El Capitan.

Notifications that are read are not removed from notification centre. It just stays there.

When opening the app for the first time, there will be a settings icon that is at the same position as the 3 dots. To remove it, I have to go to messenger > preferences. However, once I close the app and reopen, the same issue occurs.

It will also be nice if the messenger app has a sound control to overwrite the sound settings in System Preferences > Notifications "Play sound for notifications"

Notification banner does not show if my window is focused on someone while another person sends me a message. Occurs occasionally.

When gif is sent, battery usage increases significantly and remains high until the gif is out of view in the conversation.

When messages are read on another device (eg. phone), the app does not update in the background and the badge app icon is not updated (to not show red circle).

I'm seeing the same button-gear overlap:

Thanks for the list, but it's impossible to track as "a grab bag of stuff" — could you please file as separate issues (and please please, search for existing issues, closed and open, before filing)


Update ecr, kms, s3, ses, sfn, sns, sqs to 2.24.9 in scala-steward-dependencies

About this PR
📦 Updates

software.amazon.awssdk:ecr
software.amazon.awssdk:kms
software.amazon.awssdk:s3
software.amazon.awssdk:ses
software.amazon.awssdk:sfn
software.amazon.awssdk:sns
software.amazon.awssdk:sqs

from 2.24.5 to 2.24.9
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Closing as newer version available


181 responsive UI

@TODO: fix desktop functionality in relation to Operations ( window resize, drag and drop, mobile only icons )


Websockets

Hi! Not sure what's going on, but it seems that gorilla websockets (and native ones by the looks of it) aren't compatible with writers supplied by Chi.
	hijacker, ok := w.(http.Hijacker)
	if !ok {
		return nil, nil, errors.New("the ResponseWriter doesn't support the Hijacker interface")
	}
	return hijacker.Hijack()

Hijack method here returns http: Hijack is incompatible with use of CloseNotifier error (https://golang.org/src/net/http/server.go#L154)

Nevermind, forgot I was using CloseNotify middleware somewhere else.


support the option grammar

the optional grammar is below for current:
-ovalue or -o=value
can it support -o value?

It is impossible to support that syntax.
-o arg1 arg2 arg3

arg1 is an argument (not an option).


Port sunSunSafePoint to C++

Tickets addressed: bsk-758
Review: By commit
Merge strategy: Merge (no squash)

Description
This PR creates a C++ version of the sunSafePoint fsw module. The module functionality is not changed.
Verification
The old unit test script is kept and the new module passes the test.
Documentation
N/A
Future work
N/A

@patkenneally I just made a bunch of changes to this branch to reflect your comments on the mrpProportionalDerivative PR. This PR is now ready for your review!


Compatibility with Zend Framework 3

Hi there,
Are there any plans to update this module for compatibility with Zend Framework 3 at all ? The Zend_Captcha module references this and when you try to pull it down via composer it fails due to version requirements.
Thanks

Hi,
I created a pull request to fix this a few days ago.
Joe

Fixed with #11


Inspect for very large numbers

Daru::Vector.new([10**10, 20**20, 40**40])
# =>
# #<Daru::Vector:73093280 @name = nil @metadata = {} @size = 3 >
#                                      nil
#                   0<PHONE_NUMBER>0
#                   1<PHONE_NUMBER>0000000000
#                   2<PHONE_NUMBER>6146291747

Definitely feels wrong.

Is it possible to show it as 40**40 instead of the large number?

I'm not sure, but maybe scientific notation will play?..

Yep that would also be fine. Something like 10E5 for  1000000.0.


feat: check if dir is empty

screenshots were added in previous pr so not adding again.

Have you tested it?

yes, the same as earlier

Cool thank you again!


Failed to instantiate the chaincode. Error: 2 UNKNOWN: access denied: channel [mychannel] creator org [Org3MSP]

I followed below steps of Hyperledger Fabric Balance Transfer Application (1.4.3 version):
I have made a copy of balance transfer application and created a new project.
Did required changes in below files
artifacts/channel/crytogen.yaml
artifacts/channel/configtx.yaml
artifacts/channel/docker-compose.yaml
artifacts/network-config.yaml
artifacts/org3.yaml
config.js
app/instantiate-chaincode.js
Started the network. But while instantiating chaincode, I am getting this error.
Error: 2 UNKNOWN: access denied: channel [mychannel] creator org [Org3MSP]
[2019-10-10 12:12:14.895] [INFO] instantiate-chaincode - instantiate proposal was good
[2019-10-10 12:12:14.895] [INFO] instantiate-chaincode - instantiate proposal was good
[2019-10-10 12:12:14.895] [ERROR] instantiate-chaincode - instantiate proposal resulted in an ### error :: Error: 2 UNKNOWN: access denied: channel [mychannel] creator org [Org3MSP]
[2019-10-10 12:12:14.896] [ERROR] instantiate-chaincode - Failed to instantiate the chaincode. cause:instantiate proposal resulted in an error :: Error: 2 UNKNOWN: access denied: channel [mychannel] creator org [Org3MSP]

@rameshb444 Is this a Caliper log? The structure seems strange.
Anyway, check the orderer or peer logs to get a more detailed error message. But it seems that the identity, who submitted the CC instantiate proposal, doesn't have the necessary access/write rights on the channel. So check your channel policies and the identity you use to deploy the CC.


[BUG]  Security plugin APIs error out within the BWC test suite with 400 no handler found for uri

What is the bug?
When working on https://github.com/opensearch-project/security/pull/2802 I'm running into the following issue while creating a test role within BWC suite -
2> org.opensearch.client.ResponseException: method [PUT], host [http://<IP_ADDRESS>:34017/], URI [_plugins/_security/api/roles/test-dls-fls-role], status line [HTTP/1.1 400 Bad Request]
{"error":"no handler found for uri [_opendistro/_security/api/roles/test-dls-fls-role] and method [PUT]"}
The role is being created as part of a separate test in the same suite. Further, it looks like none of the security plugin APIs are accessible and error out with no handler found for uri. Bulk and Search APIs are working.
How am I running the test suite ?
current=<IP_ADDRESS>
previous=<IP_ADDRESS>
./gradlew bwcTestSuite -Dtests.security.manager=false -Dbwc.version.previous=$previous -Dbwc.version.next=$current -i
Log file -
security-bwc (1).log
Here's the code on my working branch. It's in an intermediate state with pending changes -
https://github.com/parasjain1/opensearch-security/blob/parasjaz-custom-serialization-bwc/bwc-test/src/test/java/org/opensearch/security/bwc/SecurityBackwardsCompatibilityIT.java#L97
Need help to understand what could be causing it? Have also tried the _opendistro prefix and without the prefix _security/_api/, which also results in the same error.

PR to let BWC tests run in Github actions -
https://github.com/opensearch-project/security/pull/3054

When BWC tests fail they put log output into the console, I'm seeing the following line that seems troublesome, this would imply that the security plugin features won't be available, doing more digging

» WARN ][o.o.s.OpenSearchSecurityPlugin] [securityBwcCluster1-0] OpenSearch Security plugin installed but disabled. This can expose your configuration (including passwords) to the public.

After looking at the configuration settings, (Thanks for paired debugging with me @parasjain1) these test don't actually start up the security plugin at all, the following configuration line needs to be switched from false -> true.
https://github.com/opensearch-project/security/blob/8063e1b64f880afb7dc54311f3110b162b913038/bwc-test/build.gradle#L128
However, after attempting to startup the node, copying configuration from SecureRestClientBuilder.java, there are still many errors coming in from the cluster:

» ERROR][o.o.s.s.h.n.SecuritySSLNettyHttpServerTransport] [securityBwcCluster1-0] Exception during establishing a SSL connection: io.netty.handler.ssl.NotSslRecordException: not an SSL/TLS record: 4...0a
»  io.netty.handler.ssl.NotSslRecordException: not an SSL/TLS record: 4..a
»  	at io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1225) ~[netty-handler-4.1.94.Final.jar:4.1.94.Final]

These errors are happening because the cluster startup check is hardcoded to http, need to make this parameterized

WaitForHttpResource wait = new WaitForHttpResource("http", getFirstNode().getHttpSocketURI(), nodes.size());
[Source]

I've uploaded the stopping point I have on unblocking these scenarios -  https://github.com/opensearch-project/security/compare/main...peternied:security:bwc-ssl @scrawfor99 This might be a good starting point.

I've created an issue that track the fundamental problem #3056 and resolution.  Once that has been addressed we will circle back on this issue to make sure nothing else is coming up.

[Triage] This is the same topic as #3056, going to close this issue in favor of the actionable item breakdown.


cmd: set default of tools-mode to auto

Set default of tools-mode to auto
Now that we solved the issue with CO-RE based tools (#230), the default value can be set back to "auto".

Does biotop (#303) work with both modes?

It doesn't. There's not a libbpf-based implementation for biotop -> https://github.com/iovisor/bcc/tree/master/libbpf-tools.
By the way, there was a small issue with its path -> https://github.com/kinvolk/inspektor-gadget/pull/335.

Does it mean mountsnoop (#169) should not be merged until it supports both modes?

We can merge it and use only the Python-based implementation for now. It's only needed to use /usr/share/bcc/tools/ as the executable path in bcck8s.go.

I'm not sure. I think it could create some confusion. But it's also true that it's the only solution we have if we want to enable btfhub automatically. I'd like to get other opinions on it. ping @alban

What about removing the flag --tools-mode from kubectl-gadget deploy and adding it in kubectl-gadget opensnoop|execsnoop|... instead? So that users would not have to uninstall/reinstall Inspektor Gadget just to try one version or another.

I like this idea. In the end, both binaries are already available in the container.

I think it is better if the logic is in the gadget pod rather than the kubectl-gadget CLI tool anyway.

I agree.
@alban if the user does not specify the --tool-mode, when should we try to use the CO-RE tools instead of the standard ones? We still need to make this decision.
In any case, I think your idea could be implemented even if we decide to keep using the standard gadgets by default.

After having open https://github.com/kinvolk/inspektor-gadget/issues/397, this PR can be closed.


IMS

Hi @Rune-Christensen,
I already added DB2 MOCK Functionality, I will be doing the same with IMS DB in the coming weeks FYI.
cheers

Hi @samdion1994
That sounds great.
If you have the code for DB2 mocking ready, please do a PR for it.
It is easier to review, test and verify if we get features added one at a time, instead of a lot at once.
Cheers :-)

Hi @Rune-Christensen,
Can you make me collab so I can do a pull request :)?
Thanks

Hi @samdion1994
I have removed sam94dion, and added this profile instead :-)
Cheers

Hi @Rune-Christensen,
Still can't do a pull request or am I missing something :O ?
Thanks :)

Hi @samdion1994
You need to accept the invitation I have sent you :-)
Cheers


Add release notes for april 2024 release

All changed packages have been documented.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/579/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/579/


add the ability to turn off stopPropagation and preventDefault

Using this with UI-Bootstrap breaks the dropdown menus due to stopPropagation on the click event. This adds options to turn that and preventDefault.

+1
This feature will be very helpful for me too, i have the same problem with ui-bootstrap dropdown menu.

+1
du-smooth-scroll sucking these events up prevents $routeProvider reloadOnSearch: false from doing its magic.


improvements fall2017

the most recent commit resolves #6

What is the rendercache script for?

What is the rendercache script for?

the rendermup script is pretty slow right now. And it is run at least once for each subtree rendered in the report. The rendercache script wraps rendermup in a hash-based cache. Speeds up the iterative report generation.

this is all in #18 now


Battery temperature reads incorrectly above 12.7C

I have noticed that the conversion from hex to decimal for the battery temperature is not working correctly when the temperature rises above 12.7*C. This is due to the way the conversion is implemented for negative temperatures.
I don't have the knowledge to fix it currently and also lack the time to learn right now. If you have a solution, please feel free to let me know and I'll implement it.

Fixed using ChatGPT. Man, that thing is awesome.


Pull Request: train-stream.js and neural-network.js

What is wrong?
The stream could not be ended. Its ending should be signalled with stream.end() instead of stream.write(null). Even then, the code in the library files seem to be buggy.
Where does it happen?
train-stream.js: 157, 175
neural-network.js: 175
How do we replicate the issue?
Just try out stream-example.js in the newest version of node.js.
How important is this (1-5)?
5
Expected behavior (i.e. solution)
train-stream.js:157...................formatData --> _formatData
train-stream.js:175...................initialize --> _initialize
neural-network.js: 175...........
value: function _initialize() {
-->
value: function _initialize(s=null) {
this.sizes = s;
Other Comments
I wanted to do a pull request but I don't know how.  I hope the above will fix everything.

Sounds great contribution. Please fork this project, change the code where required (nothing else) and create a pull request. This way you will be listed as contributor to this project. 👍
If you are not comfortable with that, let us know we will integrate it ourself.

Actually there are more issues than what I showed above. I managed to solve them for my own use but the changes may not be compatible for other users.

Can you please create a pull request, we will be happy to take a look. There must be something that is helpful to this library. :)

Can you share what you changed?  We can try and cover use cases with them if they aren't too complex.

Tracked here: https://github.com/BrainJS/brain.js/pull/243


optSupport MethodOneString to optimize hash join with a single string key

Proposed changes
mysql [test]>SELECT count() from hits_10m WHERE SearchPhrase IN (SELECT SearchPhrase from hits_10m);
+----------+
| count(*) |
+----------+
| 10000000 |
+----------+
1 row in set (1.15 sec)

now
mysql [test]>SELECT count() from hits_10m WHERE SearchPhrase IN (SELECT SearchPhrase from hits_10m);
+----------+
| count(*) |
+----------+
|  9999936 |
+----------+
1 row in set (0.67 sec)

run buildall

run buildall

run buildall

run buildall


Visible parameter for luigi.Parameters

Description

Visible parameter for luigi.Parameter class which is needed to show/hide some parameters from WEB page such as passwords to database
Motivation and Context

Well, in my case this change is crucial because of some of my tasks connect to database and contain passwords for it which i don't want to show it from web page to all.
In code it will look like this:
class MyTask(luigi.Task):
    secret = luigi.Parameter(visible=False)    # default value for visible - True
    public = luigi.Parameter()

Have you tested this? If so, how?

I tested it on my tasks and it works fine. It just removes this parameters from node represents current task, so it shouldn't break any compatibility
Before:

After:

Maybe, it will be helpful for others too in similar case

Thank you for your approval @dlstadther !
Yes, I can mention other reviewers, but I don't know many of them
@Tarrasch , @prncc
Sorry, If I mentioned someone incorrectly

@Tarrasch , If this is the only problem at this moment i will add needed tests and docs as soon as possible =)

@Tarrasch , i've added docs and tests for visible param.
In tests i tried to show that visible param doesn't affect on core process of resolving params and that it also works independently of significant.

Looks good so far. Hmm... I didn't imagine it would be "this simple" solving this so long overdue issue. Maybe let this PR be open for a week or so and let people chime in?
Great job so far. :)

Thank you!

Maybe let this PR be open for a week or so and let people chime in?

Ok =)

I'm thinking out aloud here: I think we should consider adding multiple levels of privacy.
I can think of quite a few use cases from different discussions in this repo.

significant vs non-significant: This effects the Task identity and everyone understands this well.
Visible Vs Invisible: For this I'm thinking purely in display terms. Oftentimes I have so many parameters(mostly with default values), that clutter up my dashboard that I wish to hide them from dashboard.
Private vs Public: These are the security related concerns like usernames, passwords, API Tokens etc. that we don't want to leak beyond the workers. Esp considering scheduler does not have any auth-auth built in.

It's easy to generalise one category into another. Ex. At first glance one would think invisible params are always insignificant. But I have one use case in our codebase which isn't so. Similarly any attempt to generalise the categories might result in long arguments. But one generalisation that does make sense(To me; Correct me if I'm wrong) is private params being invisible since they are not even available to the scheduler to display or hide. Consequently, it might be a good Idea to add a third state to visible.

Visible Vs Invisible: For this I'm thinking purely in display terms. Oftentimes I have so many parameters(mostly with default values), that clutter up my dashboard that I wish to hide them from dashboard.

But do we need to store invisible params into history and\or allow to access them from remote scheduler?

Private vs Public: These are the security related concerns like usernames, passwords, API Tokens etc. that we don't want to leak beyond the workers. Esp considering scheduler does not have any auth-auth built in.

private params being invisible since they are not even available to the scheduler to display or hide

At this moment, params with visible=False are like private params as they are not accessible from within remote scheduler. If visible=True (by default), then params will act like public params in your example.

Consequently, it might be a good Idea to add a third state to visible

I can imagine these states or similar to them:
public  - accessible for anyone from anywhere
protected  - accessible for remote scheduler but not visible from web view
private - accessible only within worker

But do we need to store invisible params into history and\or allow to access them from remote scheduler?
Yes. We do have some such params in our tasks where machine cares about the params but humans don't. One example is a param called number_of_chunks which is used  to split a task into smaller chunks in map -> reduce scenario. The param is redundant because it's visible from the DAG anyway. Another example has to do with proxying params. There is an intermediary step that doesn't use the params itself but proxies them from downstream to upsteam. Again, we don't need to see most of those params on the task but they are crucial for proper functioning.

I can imagine these states or similar to them:
public - accessible for anyone from anywhere
protected - accessible for remote scheduler but not visible from web view
private - accessible only within worker

Exactly what I had in mind. However I would rename protected as hidden to reflect the intent better.

Well, i've added some fixes for hidden params functionality.
It's only a sketch by now.
I didn't resolve the problem with tuple like (param_value, visibility_type).
Also i want to add something like enum (or class Event now) for these visibility types:
class VisibilityModifier(object):
    public = ...
    private = ...
    hidden = ...

For now, it works like described above:

public - accessible for anyone from anywhere
hidden - accessible for remote scheduler but not visible from web view
private - accessible only within worker

And also, hidden params are recorded into task_history_params.
Later, i'll add unit tests for it

@TMaYaD , @Gr1f0n6x, Thank you two so much for thinking this through! I really like that you have this discussion and I like the direction it's going!

Finally, i came up with the solution.
The general idea is to send to the central scheduler not pure parameter values, but with their visible modifiers. Because of that i've created additional method to_str_params_with_visibility which returns dictionary with tuples (value, modifier).
This method is used only in one place: Worker._add(...).
Also, to reduce overhead on filtering public parameters, i've added two fields in Task class in scheduler.py: public_params and hidden_params. Probably, hidden_params in this case is unnecessary, but maybe for some cases can be useful.
I tried to not modify old code to not break the compatibility with existing code.
I've tested this in two ways:

The common unit tests in visible_parameters_tests.py

I ran some tasks:

import luigi
from luigi.contrib import postgres
import time

class Dep(luigi.Task):
    param1 = luigi.Parameter(default='public_dep')
    param2 = luigi.Parameter(default='private_dep', visible=2)
    param3 = luigi.Parameter(default='hidden_dep', visible=1)
    param4 = luigi.Parameter(default='private_dep', visible=2)
    param5 = luigi.Parameter(default='hidden_dep', visible=1)
    time = luigi.Parameter(default="{}".format(time.time()))

    def output(self):
        return postgres.PostgresTarget(host="localhost", password="", database="postgres",
                                       user="postgres", table="dep",
                                       update_id="dep_{}")

    def requires(self):
        return []

    def run(self):
        print("Run dep")
        self.output().touch()

class Dep2(luigi.Task):
    param1 = luigi.Parameter(default='public_dep2')
    param2 = luigi.Parameter(default='private_dep2', visible=2)
    param3 = luigi.Parameter(default='hidden_dep2', visible=1)
    param4 = luigi.Parameter(default='private_dep2', visible=2)
    param5 = luigi.Parameter(default='public_dep2')

    def output(self):
        return postgres.PostgresTarget(host="localhost", password="", database="postgres",
                                       user="postgres", table="dep2",
                                       update_id="dep2_{}")

    def requires(self):
        return []

    def run(self):
        print("Run dep 2")
        self.output().touch()

class Test(luigi.Task):
    public = luigi.Parameter(default='public')
    hidden = luigi.Parameter(default='hidden', visible=1)
    private = luigi.Parameter(default='private', visible=2)

    def output(self):
        return postgres.PostgresTarget(host="localhost", password="", database="postgres",
                                       user="postgres", table="test",
                                       update_id="test_{}".format(time.time()))

    def requires(self):
        return [Dep()]

    def run(self):
        yield Dep2()
        print("Test task")
        self.output().touch()

if __name__ == '__main__':
    luigi.interface.run(main_task_cls=Test)

Result:

In my database:

Yes. I think using an enum is a sound abstraction for this. :)

Hi, @Gr1f0n6x I would be interested in having something like such work due to how we're using Luigi it would be beneficial for us to hide some parameters from the admin interface for convenience.
Did you happen to make any progress on this outside of this repo? Is this still something that is on your mind? What are the things that would left in order to consider this feature complete?
Thanks!

Hi @cabouffard ,

What are the things that would left in order to consider this feature complete?

The main problem now is to add 3rd state (hidden, in this case) for parameters visibility, because some of my solutions change core logic and it break some tests.
If you want just fully hide some parameters and show others  - you can use first commit for it (we still use this solution in prod).
Also, i have a vacation now, so, i can continue to work on it and i believe, that i'll finish soon this feature =)

@Gr1f0n6x Thanks for the feedback! We're eager to use that feature on our pipeline! :)

Still want to say I'm still looking forward to this being implemented. :)

I fixed parameter visibility logic. Now it does not break core tests (which i ran locally) and works as mentioned ^_^
P.S. i had some problem in rebasing my branch on master, so i tried to merge master into it and in result i got too many "files changed". Maybe, it would be better if i open new PR and refer it to this? Or maybe there is some way to fix it?

This is a bit hard to review as is since there's some git/branching problems.

@Tarrasch i fixed conflicts and updated docs & tests.
At least, travis doesn't find errors, so, i believe, that i didn't break core logic and compatibility with old code.

Thank you for review, i'll add additional tests and update pr considering your comments! =)

Look like some tests failed. I'll try to figure out why.
But the most mysterious thing for me is failed doc's tests

Let me know when you've figured out the test failure.

@Tarrasch i've fixed one of the failed tests. The problem was in IntEnum serialization.
But i have no idea why doctest always fails. I'm not sure, but i think that it is concerned with IntEnum class, because first time this test failed when i replace simple enum-like class by IntEnum (maybe it's just coincidence).
I will try to reproduce it locally and fix it

@Gr1f0n6x Docs are failing for you due to your import enum. I've ran into issues before with tests where a downstream import caused such an error.
Basically enum is Python 3 only
I mention it here when it happened for another PR.

@dlstadther , @Tarrasch would it be ok if i replace enum by simple enum-like class to solve this issue? Or there is another way to solve it?

You can use the enum class that's built into python. (there's a 2.7 backport we're already using)

Just looked through this PR history and found @Tarrasch mentioned we're using a backport for enum.
I wonder then why this error is occurring...

Looks like we reference it in tox.ini

Maybe we need to add it to [testenv:docs] dep list

This isn't the beautiful way to do it, but maybe it's still the best so users still can just "download and run" luigi still on python 2.7. You can add a TODO in case we ever stop supporting 2.7 without various backported packages.

I agree with that, especially about python 2.7. supporting (we use luigi in prod using python 2.7 ^_^), but, at this moment, i don't see any options.
I tried to reproduce it locally using py 2.7 (with and without enum34 package) and py3.6 and everything goes well. Probably, i did something wrong as i can't reproduce the same result, but anyway the behaviour is strange.
Maybe, if we add enum package as dependency in [testenv:docs] dep list, as suggested @dlstadther it will help

My recommendation fixes tests. But Python 2.7 users would still have to install enum34 from Pypi to not have import enum throw errors

As a Python 2.7 user, I realize that 2020 is coming quicker than I'd like. So i'm personally ok with adding enum34.
Do we know if 3.4+ can install enum34 and still use enum appropriately? If so, why not just add enum34 as a luigi core dependency with a ticking timer for deprecation on 2020-01-01?

@Tarrasch , @dlstadther i've added enum34 as deps in tox.ini [testenv:docs] and also add this package as dependency in setup.py for python < 3.4.
I did a little research about this:

Do we know if 3.4+ can install enum34 and still use enum appropriately?

And found that it can cause problems in some cases. So, to avoid this, i think, that we could decide to install or not enum34 dynamically

@Tarrasch , yes, i think that it is ready for review

Aaaaaaawesome!!! We've wanted this for many years already! So nice to see it finally completed!

i can still see parameter with PRIVATE visibility in luigi exection summary.
--->
import luigi
from luigi import LocalTarget
from luigi.parameter import ParameterVisibility
class PTest(luigi.Task):
a_var = luigi.Parameter(significant=False, visibility=ParameterVisibility.PRIVATE)
def requires(self):
    return PtestExternal(p=self.a_var)

def output(self):
    return LocalTarget("hello.txt")

class PtestExternal(luigi.ExternalTask):
p = luigi.Parameter(significant=False, visibility=ParameterVisibility.PRIVATE)
def output(self):
    return LocalTarget(path=self.p)

log.txt

I can still see parameter with visibility set to PRIVATE in luigi execution summary
Sample Flow
import luigi
from luigi import LocalTarget
from luigi.parameter import ParameterVisibility
class PTest(luigi.Task):
a_var = luigi.Parameter(significant=False, visibility=ParameterVisibility.PRIVATE)
def requires(self):
    return PtestExternal(p=self.a_var)

def output(self):
    return LocalTarget("hello.txt")

class PtestExternal(luigi.ExternalTask):
p = luigi.Parameter(significant=False, visibility=ParameterVisibility.PRIVATE)
def output(self):
    return LocalTarget(path=self.p)

log.txt

@cabhi ,the goal was to hide parameters only in WEB part and in database.
You will see all parameters in execution summary, including private and hidden. For me, if you can run code using it sources, than there is no point to hide any parameters, because you can see it anyway.
But if there is needance in hiding parameers also in execution summary, then it can be also done


Add license header to the files

Done: https://github.com/conductor-sdk/conductor-go/releases/tag/v1.2.3


The fun 'double' in the com.intellij.remoterobot.utils.Keyboard could not be invoked from Java code

'double' is a reserved word in Java, so the fun 'double' cannot be invoked from Java code
possible solution is to rename the function or add @JvmName("....") annotation

Fixed in remote-fixtures:<IP_ADDRESS>. Keyboard#double was renamed to Keyboard#doubleKeyPress


span icon position

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
span icon is not  at good position ,span icon is overlap with the text written ,and i want to change the colour also.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

i want to work on this issue #1421 .please assign me.

I would like to work on the issue #1421 .