Implement parser and command support for displaying venue

Closes #148
Displaying venue in the command result box allows users to copy URLs easily.

Codecov Report

Merging #166 into master will increase coverage by 0.14%.
The diff coverage is 95.91%.

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     81.93%   82.07%   +0.14%
- Complexity      980      994      +14
============================================
  Files           144      146       +2
  Lines          2922     2957      +35
  Branches        343      349       +6
============================================
+ Hits           2394     2427      +33
  Misses          443      443
- Partials         85       87       +2

Impacted Files
Coverage Δ
Complexity Δ

...orspet/logic/parser/DisplayVenueCommandParser.java
92.30% <92.30%> (ø)
3.00 <3.00> (?)

.../tutorspet/logic/commands/DisplayVenueCommand.java
95.00% <95.00%> (ø)
9.00 <9.00> (?)

...utorspet/logic/commands/FindAttendanceCommand.java
91.42% <100.00%> (ø)
13.00 <0.00> (ø)

...spet/logic/parser/FindAttendanceCommandParser.java
93.75% <100.00%> (ø)
3.00 <0.00> (ø)

...n/java/tutorspet/logic/parser/TutorsPetParser.java
100.00% <100.00%> (ø)
33.00 <0.00> (+1.00)

src/main/java/tutorspet/model/lesson/Lesson.java
96.55% <100.00%> (+0.06%)
29.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba5f6d...e777677. Read the comment docs.


[Snyk] Security upgrade python from 3.7-slim to 3.13.0a6-slim

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

terraform/resources/Dockerfile

We recommend upgrading to python:3.13.0a6-slim, as this image has only 50 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

829
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Mature

829
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Mature

614
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210088
No Known Exploit

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210098
Proof of Concept

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210098
Proof of Concept

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Checkmarx One – Scan Summary & Details – 52492550-2331-4435-9dca-f448337400cd
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Missing User Instruction
/Dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Healthcheck Instruction Missing
/Dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

IAM Access Analyzer Not Enabled
/eks.tf: 12
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/kms.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ec2.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/iam.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/s3.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ecr.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/es.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/lambda.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

Fixed Issues

Severity
Issue
Source File / Package

Missing User Instruction
/Dockerfile: 1

Healthcheck Instruction Missing
/Dockerfile: 1


Track expense - Expense details briefly disappear when opening it after categorization

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Navigate to https://staging.new.expensify.com/

Log in with a new expensifail account

Create a workspace

Tap on FAB - Track expense

Track an expense

Select "Categorize it" from the whisper message

Select any workspace

Select any category

Quickly open the tracked expense

Expected Result:
Details should remain visible.
Actual Result:
Expense details briefly disappear when quickly opening it after categorization.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/43996225/b4bd9883-d45b-4427-859d-3096a30720b2

View all open jobs on GitHub

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

No, I can't repro this. Nothing disappears and it functions as expected:

I did the whole flow but its too long

Closing as not reproducible. Working as expected.


App continually crashes

Within the past month, when updating an entry, Shukofukurou suddenly crashed on me. Whenever I try to open it now, it closes before I can do anything.
I tried deleting the app and reinstalling, but it seems like it retains my login information and the issue persists.

Which service are you using normally. Is this the Mac or iOS version?
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 9:36 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

Within the past month, when updating an entry, Shukofukurou suddenly crashed on me. Whenever I try to open it now, it closes before I can do anything.
I tried deleting the app and reinstalling, but it seems like it retains my login information and the issue persists.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Which service are you using normally. Is this the Mac or iOS version?
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 9:36 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

Within the past month, when updating an entry, Shukofukurou suddenly crashed on me. Whenever I try to open it now, it closes before I can do anything.
I tried deleting the app and reinstalling, but it seems like it retains my login information and the issue persists.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

It’s the MacOS version.

On Jan 17, 2021, at 6:51 PM, James Moy<EMAIL_ADDRESS>wrote:
Which service are you using normally. Is this the Mac or iOS version?
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 9:36 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

Within the past month, when updating an entry, Shukofukurou suddenly crashed on me. Whenever I try to open it now, it closes before I can do anything.
I tried deleting the app and reinstalling, but it seems like it retains my login information and the issue persists.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761945620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6PQ6OCMJXVR6KZOUMDS2OO3ZANCNFSM4WGTXVAA.

It’s the MacOS version.

On Jan 17, 2021, at 6:51 PM, James Moy<EMAIL_ADDRESS>wrote:
Which service are you using normally. Is this the Mac or iOS version?
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 9:36 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

Within the past month, when updating an entry, Shukofukurou suddenly crashed on me. Whenever I try to open it now, it closes before I can do anything.
I tried deleting the app and reinstalling, but it seems like it retains my login information and the issue persists.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761945620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6PQ6OCMJXVR6KZOUMDS2OO3ZANCNFSM4WGTXVAA.

I see the crashes for the 3.4.1. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2

I see the crashes for the 3.4.1. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2

Thanks! It seems like the 3.5 beta fixes the issues I was having.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

Thanks! It seems like the 3.5 beta fixes the issues I was having.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

After doing a little troubleshooting,  I think the issue was with MyAnimeList. Trying to access my MAL account on Shukofukurou Next caused it to crash immediately again, but I managed to get it to stop by switching to my AniList account quickly and logging out of my MAL account.
However, when I tried to reauthorize my MAL account, the page opened showed a 404 error.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

After doing a little troubleshooting,  I think the issue was with MyAnimeList. Trying to access my MAL account on Shukofukurou Next caused it to crash immediately again, but I managed to get it to stop by switching to my AniList account quickly and logging out of my MAL account.
However, when I tried to reauthorize my MAL account, the page opened showed a 404 error.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

I will take a look at it tomorrow. AppCenter crash reports should provide some clues
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 10:26 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

After doing a little troubleshooting, I think the issue was with MyAnimeList. Trying to access my MAL account on Shukofukurou Next caused it to crash immediately again, but I managed to get it to stop by switching to my AniList account quickly and logging out of my MAL account.
However, when I tried to reauthorize my MAL account, the page opened showed a 404 error.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I will take a look at it tomorrow. AppCenter crash reports should provide some clues
Sent from my iPhone 11 Pro
(Shijou Takane - 四条貴音)

On Jan 17, 2021, at 10:26 PM, cirrusbottle<EMAIL_ADDRESS>wrote:

After doing a little troubleshooting, I think the issue was with MyAnimeList. Trying to access my MAL account on Shukofukurou Next caused it to crash immediately again, but I managed to get it to stop by switching to my AniList account quickly and logging out of my MAL account.
However, when I tried to reauthorize my MAL account, the page opened showed a 404 error.

On Jan 17, 2021, at 6:57 PM, James Moy<EMAIL_ADDRESS>wrote:
I see the crashes for the 3.4.1 in AppCenter. I apparently forgot to release 3.4.3, which probably fixes the issue, but since I forgot to release that version and worked on 3.5, I will be releasing that instead.
See if the 3.5 Beta 2 resolve the issue (The app store app should unlock the paid features). I will be releasing the 3.5 to the App Store soon after I fix some bugs:
https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2 https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-761947536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6MQ2QO6U733ZPUYKM3S2OPTDANCNFSM4WGTXVAA.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Finally pinpointed the error. It's one of the fields being set as null in the manga list entries, but I do not know what field since it doesn't crash with mine, so I created a method that checks all the fields and set them as blank if there is any nil values so it won't crash.
If you provide your username, I can probably load the list into the MAL API directly to see exactly what fields are causing it to not populate properly.

Finally pinpointed the error. It's one of the fields being set as null in the manga list entries, but I do not know what field since it doesn't crash with mine, so I created a method that checks all the fields and set them as blank if there is any nil values so it won't crash.
If you provide your username, I can probably load the list into the MAL API directly to see exactly what fields are causing it to not populate properly.

Shukofukurou Next.dmg.zip
See if this build fixes your issue.

Shukofukurou Next.dmg.zip
See if this build fixes your issue.

I was able to log into my MAL account again, but the crashes continue. My MAL username is thejesster101, so I hope that helps.

On Jan 18, 2021, at 10:23 AM, James Moy<EMAIL_ADDRESS>wrote:
Shukofukurou Next.dmg.zip https://github.com/Atelier-Shiori/Shukofukurou/files/5831907/Shukofukurou.Next.dmg.zip
See if this build fixes your issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-762407974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6ILTR5KVYPNUYFVBWTS2R4CTANCNFSM4WGTXVAA.

I was able to log into my MAL account again, but the crashes continue. My MAL username is thejesster101, so I hope that helps.

On Jan 18, 2021, at 10:23 AM, James Moy<EMAIL_ADDRESS>wrote:
Shukofukurou Next.dmg.zip https://github.com/Atelier-Shiori/Shukofukurou/files/5831907/Shukofukurou.Next.dmg.zip
See if this build fixes your issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-762407974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6ILTR5KVYPNUYFVBWTS2R4CTANCNFSM4WGTXVAA.

I found the culprit. Apparently, one of your manga entries, "Pochapocha Suiei-bu" does not have a reading status set. I know this is probably a glitch as it's impossible to set no read/watch status for an entry, but it apparently exists. If you set a read status, it will resolve the crashing issue. I made a fix so that the app won't crash if these entries exist.

I found the culprit. Apparently, one of your manga entries, "Pochapocha Suiei-bu" does not have a reading status set. I know this is probably a glitch as it's impossible to set no read/watch status for an entry, but it apparently exists. If you set a read status, it will resolve the crashing issue. I made a fix so that the app won't crash if these entries exist.

https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta3

https://github.com/Atelier-Shiori/Shukofukurou/releases/tag/3.5-beta3

Does this solve your issue? Please respond.

Does this solve your issue? Please respond.

It does indeed fix the issues! Thanks for your help.

On Jan 22, 2021, at 4:09 PM, James Moy<EMAIL_ADDRESS>wrote:
Does this solve your issue? Please respond.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-765793698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6PY5OT5UOSCPZGIVZLS3IHVJANCNFSM4WGTXVAA.

It does indeed fix the issues! Thanks for your help.

On Jan 22, 2021, at 4:09 PM, James Moy<EMAIL_ADDRESS>wrote:
Does this solve your issue? Please respond.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Atelier-Shiori/Shukofukurou/issues/37#issuecomment-765793698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO66M6PY5OT5UOSCPZGIVZLS3IHVJANCNFSM4WGTXVAA.


First commit test

Hi, I am just testing the waters with this very simple change!
I hope to contribute more.
If there is a do's and dont's guide, please reach out at<EMAIL_ADDRESS>thank you

@byorn Yes it is in review. Let me get back on it.

@byorn your PR is not sufficient for a merge. You need to add or modify features in the code.


Revert "Add DownloadBuildArtifacts task. (#5264)"

This reverts commit 5a54c1881b047b8554fce5eca76244944fe72f76.

@omeshp,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Broken link to SAP HANA Native Application from BAS home page

Issue description

The link to SAP HANA Native Application is broken on the home page of https://help.sap.com/docs/bas
Feedback Type (Optional)
linking
Page Title on SAP Help Portal (prefilled)
SAP Business Application Studio
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/bas

I have fixed the link and republished. Thank you!


Requesting Alias Commands for /Buy

I can not use Alias commands for /buy?
I use the "commands.yml" to make more options for /buy like /support and other common names.
Can you please add this ability back to buycraft or create a way to make more than one command for /buy.
I see this a a good thing for servers who want to have non-english commands and common /donate style commands.
Even if you have to Config the Alias in the Buycraft config I can see this helping owners a lot.
Thanks for your time.

Sorry however we are not looking into implementing this. You can change the /buy command in the config file if you ever need to.

I dont want to change /buy I was I want to translate it into other languages to allow people to use there own language to /buy. I was told you have someone trying to use your commands or something an thats your reason to negate the alias but for some this was not just a alias but a way for other players from around the world to have more easy of use. So if you would please at least talk about adding something similar back. It does not have to be the .commands file but some way for us owners to make the plugin easy to use for them via names/words that they know.
I kinda assumed since this would help more than me that you all might consider it.
Would this help if I get a petition of others who would want this as a option or is this just going to remain a oneway rd with Buycraft.
Sorry for sounding rude, Its not the intention. I just lost a feature Ive had for years with the buycraft with the update though.
Thanks again for your time a Effort with the plugin. Used you all for 4 years now.

I've discussed this with our developer and we will be releasing this feature in the next version. Thanks for the in depth reasoning.

Whoa, tbh I did not expect this response but Im true to the reason for the feature.
I also understand it was not a real part of buycraft but still allowed through the .command in spigot.
So again, Thank you so very much for your time and effort with this project.


Alternative Search Engine / Manticore

Currently Papermerge DMS supports only one search engine backend  - elasticsearch.
It would be great to support multiple search engines.
Consider manticoresearch.
Consider Apache Solr.
Consider Typesense.
Consider PostgreSQL FTS
Any other option ?

The removed legacy database search engine for low resource hardware like raspberry pi?

That's actually a good point. I really enjoyed PostgreSQL full text search :).
The disadvantage of that approach is that it is specifically bound one database type - PostgreSQL, but on the other hand
it is easier to use as there is no need for an extra service.
PostgreSQL FTS will be added back.

These week I experimented with Django Haystack. I was pleasantly surprised - although packages looks like out f date - it is very well written and works surprisingly well.
When used it adds support to four backends: elasticsearch, solr, xapian and whoosh.
Solr and elasticsearch are well known and resource intensive.
Whoosh it python only search engine. First impression - it works rather well for small set of data.
I was completely amazed by Xapian. I never heard of it (until couple of days ago) - but it works surprisingly well, is well documented and has great python bindings.
And best of all - are you ready? - it is written in C++ and has very small memory footprint.
Long story short - Xapian search is now included by default. No configuration required.


Percolator updates

@vforgione I made a couple updates to the percolator code. Can you give it a once-over when you get a chance?

I found a bug where when you saved a percolator the second time, you got a 409 "Object Already Exists", since we were using es.create, instead of es.index.
In order to fulfill our requirements around the priority os sponsored sections, it would be nice to have a way to be able to check if a special coverage section is sponsored, just using the percolator response, so I added some of that metadata to the percolator payload. This should save us some db queries.

@kand If you check out SpecialCoverageQueryTests, you can see an example of how to build a query from scratch, instead of using BaseCustomSearchFilterTests. This might help with those issues we were talking about earlier?

Changes Unknown when pulling da7fbff59f79fcbe9344807b86fc636bf5b4aff0 on percolator-updates into ** on master**.

Sorry, I just got around to checking this now. Everything looks splendid! :+1:


Limit macOS $INODE64 symbol names to x86 and x86_64

The new ARM-based platform doesn't need these as there's no legacy
constraints.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

r=me once the style issue that CI reported is fixed.

style issue

Addressed!


added built in menus and activated google comments

I added support for the built in menu manager,  I'm not the best at this so it may need cleaning a bit

you can see a demo at https://digitalmisfit.wtf

Thanks, @MayanMisfit! I'll review this for inclusion in master.


Design patterns for DDD

Hello!
I started to use SQLHydra but had to move away from it because I couldn't find a simple and elegant way to use Domain Driven Design. But today I realized that I could have have tried to ask the question here.
The main item i struggled with was upserting Root Aggregates. A root aggregate is a top-level entity responsible for managing the internal consistency of multiple records. In practice, this means that reading and writing a root aggregates most of the time means reading and writing from and to multiple tables. The recommended practice therefore is to realize these operations atomically.
I struggled to come up with an elegant and scalable pattern to upsert a root aggregate, and to a lesser extent to load it from the DB. I felt that it was a bit hacky and that I was spending a lot of time writing boilerplate code. Between managing transactions manually and the verbose syntax to write join, I found my implementation ugly and painful in terms of development experience.
Since the application I am developing is a large scale enterprise application, I need to ensure that things will be elegant and easy to develop even as complexity grows.  But just writing read and upsert code for a single root aggregate was quite heavy on boilerplate code, while I got this stuff for free when I was using EF in C#.
I am very much interested in coming back to SQL instead of relying of ORMs, I see value in it. I was enjoying SQLHydra's API a lot before coming accross this challenge. But I need to remain pragmatic and ensure that I do not multiply development time by 3 due to the needs to write may more boilerplate. Therefore, my specific question is: what would be the recommended pattern to serialize/deserialize a root aggregate using SQLHydra?
If there was a way to use stored procedure for every database operations I'd be happy to do so, but i couldn't find a convenient pattern to pass an F# record to a store procedure (for upserts), and when it comes to reads, building a strongly-typed model without relying on magic strings felt painful as well.
But I suspect that it was probably because I was not familiar enough with the capabilities of SQL Hydra. This is the reason I'd appreciate if someone could illustrate how they'd approach this problem with basic pseudo-code samples.

Your post has made me realize that it would be very helpful for the community if I created a comparison of the various data access libraries for F#, either as a blog post or as a simple "Should I Use SqlHydra?" section in the readme.
You are right that SqlHydra is definitely not an ORM like EF. I think of it very much as a "strongly typed SQL" DSL.
While I agree that ORM features can be incredibly convenient and useful, I generally prefer to write SQL manually, do my own joins, and handle my own updates. It is more manual work, but I'm generally fine with that because it's less magic behind the scenes as I control everything with SQL.
As you pointed out, the "ORM" features of EF that are missing from SqlHydra are:

A little bit easier to query related records without manually writing a join based on FK relationships
Ability to analyze mutated properties to generate updates to multiple tables in the graph
Ability to analyze which items were added/removed from a related table

I think SqlHydra is a solid enough base now that I am willing to consider scaffolding some light ORM style helpers that could take advantage of code generation to assist in these tasks.
For 1, I can imagine returning related FK information with the generated types that could be used in the Query CE to provide a joinOnFk style operation.
For 2 and 3, I am open to any ideas on helpers, generated or otherwise, to reduce the burden of these kinds of manual updates, as long as it's not fully going down the path of tracking state, etc.
Alternatively, the SQLProvider library already has some of these ORM style features:

Related tables exist on the generated types as a method
Entities are classes (not records) and have mutable properties, just like EF. Mutating these properties tracks state so you an just commit the changes.

The funny thing is that I just finished converting a very large enterprise app from SQLProvider to SqlHydra, and in many cases, the SqlHydra was the same or less. The only pain point for upserts on object graphs where SqlHydra resulted in a little bit more code. For my projects, I almost always map the generated DB entities into DTOs, and so I had to map back from DTO to generated entity regardless, which eliminated much of the benefit of the ORM features around mutable property changes being mapped.

I forgot to ask, are you using SQL Server or something else?

@JordanMarr I am using PostgreSQL

The reason I ask is that you can at least use the PostgreSQL onConflictDoUpdate to perform an upsert with your child records:
    /// Inserts an address or updates it if it already exists.
    let upsertAddress address =
        insertTask (Create openContext) {
            for a in Person.Address do
            entity address
            onConflictDoUpdate a.AddressID (
                a.AddressLine1,
                a.AddressLine2,
                a.City,
                a.StateProvince,
                a.CountryRegion,
                a.PostalCode,
                a.ModifiedDate
            )
        }

Rather than deleting all and re-inserting, I usually do the following instead to find changes:

Pull a list of existing records for that aggregate from DB.

Deletes:

Create a Set of PK values from incoming records
Use this to filter the existing records where PK value is not contained in the Set of incoming data (because it was deleted)
Create a delete query with the resulting Ids

Upserts

Put the existing records into a Map with the PK as the key
Loop through incoming records

For each incoming record, lookup up the existing record from the map
Check for changes (either comparing the entire record for equality or just check individual columns)
If changes are detected, do an upsert

Or, if you don't care to check for changes:

Loop through incoming records and upsert each one and let PostgreSQL do the diffing for you.

This pattern works for me, but it is a bit of work.
I will ponder this to see if there are any patterns we could use to eliminate boiler plate code.

I started to brainstorm today on some helpers to reduce the boilerplate involved with diffing a collection of rows to be saved.
For starters, I came up with a DiffService helper that will partition your rows for you:
https://github.com/JordanMarr/SqlHydra/discussions/83#discussioncomment-8509988
That might be a good start.


New tag request

Any chance of a new tag soon?


Feature request: Add support for emojis

In the textSync function the emojis do not get printed.
figlet.textSync('🖌 Figlet')

I have a suggestion to add support for emojis in textSync.

You will need to create ASCII art for every emoji for every font. Sounds unrealistic IMHO. Unless you want to contribute.


Documentation and Specification Updates

Updated project README and OVERVIEW pages.
Reorganized RFC folder (rfcs) contents, added several new RFCs with placeholders for specification of components that have already been implemented, standardized header sections, added unique RFC numbers in each page, created or updated several pages.

This PR will fix the issue that causes the 2 failing tests, after merge and release of a new version of the Fabric Interoperation Chaincode.


Handle inline classes in API docs redesign

https://github.com/Qiskit/documentation/issues/521 came up with a great design for API docs when we have dedicated function and class pages, where the page solely exists to document the class or the function. There, everything on the page is in support of that class / function. For example, all methods and attributes describe the same class.
However, we sometimes have inline classes in our API docs (https://github.com/Qiskit/documentation/issues/199), meaning that the class definition is only one part of the rest of the page. When that's the case, we need to somehow distinguish what is the class itself. It's tricky that we also still want to distinguish what the underlying methods and attributes belonging to that class are.
For example, maybe we have a left colored bar that extends across the entire class. Then we have smaller bars for each method and attribute next to it, so certain parts of the doc have two colored bars.
PDF of current (lack of) styling
PDF of Sphinx styling

Designs have been finalized and can be found here


Can I use your plugin on Redmine with Windows? How to configure? Thanks

RM 4.04 Win10, Ruby 4 Windows with DevKit

We do not offer support for Redmine on Windows.

We do not offer support for Redmine on Windows.


Regression suites don't specify a series correctly. For each logicall…

…y independent series specify a series name. In the future we'll need to graph multiple series together anyways.

Thanks!


Implement PageViewTiming event instrumentation

This should be a new package in the auto-instrumentation-poc branch. It should use only the Events API as a dependency for generating the event.
Semantic conventions are drafted here.

Please assign this to me


Add a nutrition facts label to the custom food dialog

There is probably a better way to do this so I'll leave that one as a draft.

Sorry, I wasn't super clear but I would like your feedback on that one if you've got time to review the code.

I think I've done pretty much all the features I wanted for that PR (can't speak for the quality of the code, I'm still a React noob)
Options:

Button in the custom food datagrid:

Added a toolbar in the food log for the edit button + the nutrition popover:

If you hold CTRL or ALT, it will show the values for the default serving size instead

I put a little warning to say that the data is limited for public food

I've done pretty much all the features I wanted to do for this PR (can't speak for the quality of the code, I'm still a React noob)
Options:

Added a button to the data grid of custom foods to show the nutrition facts popover:

Added a toolbar in the food log to regroup the actions (edit + nutrition facts popover):

If you hold CTRL or ALT when clicking, it will show the values for the default serving size:

I added a little warning sign for public foods to explain the nutrition data is limited:

It seems to work OK on mobile as well.

Thanks for taking the time to review my code. I'll have a look later.

Updated popper


update readme for json payloads

Move docs to https://oxrs.io/docs/firmware/state-controller-esp32.html and updated README to point there.


GCP instructions give incompatible zone and instance type

https://course.fast.ai/start_gcp.html#step-3-create-an-instance
Currently instructs us-west1-b for zone and n2d-highmem-8 for instance type.
However, enter gcloud compute machine-types list --filter n2d-highmem-8 and you won't see us-west1-b on the list of zones:

Note that I tried changing the zone to us-central1-a but got the following error:
ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - The resource 'projects/fastai-20200406/zones/us-central1-a/acceleratorTypes/nvidia-tesla-p100' was not found

Hey, I had the same issue when I was trying to recreate the instance.
When I first created the instance, I followed the exact steps described in the link Start GCP Instance. I did a describe on this created instance by executing:
gcloud compute instances describe my-fastai-instance --zone us-west1-b
and my metadata dumped out reveals this:

So, it looks like the command to create the instance in the fastai link never created a n2d-highmem-8 machine type at all! It had created a n1-highmem-8!
So, I recommend that try a filter on machine type n1-highmem-8 and then use those zones which have the required GPU. I am currently executing this.

I executed using n1-highmem-8 and I can confirm that this works 100%


added mac support to command-not-found module

I will add this after it is merged into Homebrew, see https://github.com/bfontaine/homebrew-command-not-found/issues/3. Ask me to reopen after it is merged into Homebrew.


Mocking findRecord with buildList

Hey Daniel :)
Is it possible to mock findRecords for items from buildList?
I'm working with scenarios in mock environment and Im trying to mock findAll and findRecord for each built object. It is possible?
So right now I have sth like this, but it doesn't work correctly :/
    let users = this.buildList('user', 3);

    let list = [users.get(0), users.get(1), users.get(2)];
    list.forEach((attrs) => this.mockFindRecord('user').returns({ json: this.build('user', attrs) }));

another small issue I found is; this.attributesFor is not accessible in scenarios ;)

Right, gotta fix that about attributesFor Maciej.
Ok .. well .. I would suggest 1 possibility.  Use => FactoryGuy.cacheOnlyMode()
That way you can build models ( like users ) and for store.find or store.findAll they will be used automatically. There is nothing to mock anymore. But that just makes is too easy .. I know, so sorry about that.  We need something with more suffering.
You could otherwise probably better off without the list style.
    let user1 = this.build('user');

    let list = [users.get(0), users.get(1), users.get(2)];
    list.forEach((attrs) => this.mockFindRecord('user').returns({ json: this.build('user', attrs) }));

:D Yeah, we need more suffering xD
is this FactoryGuy.cacheOnlyMode(); set globally? I mean it will be working in all scenarios?
There is one problem with it :/ I don't have the delay on requests anymore which is very crucial for me as my app relies on loading states I need to see what is happening.
How can mock also in the second example findAll which those created users?

cacheOnlyMode is kinda global so that is good point.
also, about the waiting. I usually don't care, but if you do, then you do which is important.
So, here is what you would do.  Once again, it is far too easy.  😄
   let users = this.makeList('user');
   let [user1, user2] = users;

   this.mockFindRecord(user1);
   this.mockFindRecord(user2);
   this.mockFindAll('user').returns({models: users});

You know how to set up ajax waiting time in Scenarios ? I guess you do, since you need that feature.

hi @Exelord , did this work for you? need anything else? can i close this?

I would be grateful for leaving it for now. I'm on the holidays, I will get back to it in the next week.

So... There is one more problem with the proposed solution :/ It pushes the records to the store before they have been requested. That's why I wanted to achieve this with buildList

Ok Maciej, fair enough.  If you want to use buildList then his will work:
let json = buildList('user', 2);
mockFindAll('user').returns({json});
json.get().forEach(item=> {
  mockFindRecord('user').returns({id: item.id})
})

Look cool, but after a test, it doesn't work :/ I says that /users/1 endpoint is not defined but it is.

can you post your entire test here?   and also show me the route (model hooks )  want to make sure that I know the order in which the users are fetched .. gotta be something I am not seeing

Im doing this in scenarios :/ Ive pasted your example, and in the ember app cant fetch it.

might have to sceen share then? if you don't mind that i stare at the code for a few minutes

can you make an ember-twiddle to show your scenario?
https://ember-twiddle.com/421f16ecc55b5d35783c243b8d99f2be?openFiles=tests.unit.model.user-test.js%2C
i have ideas of how to fix . but i want to see your usage exactly

Hi @Exelord .. I am going to close this cause I have not heard back in many months, and you may have already solved it?  If not, please reopen, cause I am willing to help solve it, I just need more information and guidance from you if it still an issue


Module state is not propagated correctly to Kyma CR

Description
After the changes done here, if the user attempts to delete the Telemetry module while some custom resources related to Telemetry still exist in the cluster, the module deletion is blocked and the state of the Telemetry module will change to Warning . However, the Kyma CR shows that the Telemetry module is in Deleting state instead of the actual Warning state.
Also, the Processing state was removed here and initially the Telemetry module state is empty. However, the Kyma CR shows that the Telemetry module is in Processing state.

Expected result
When Telemetry module is in Warning state, it is expected that the Telemetry state in Kyma CR is also Warning
  modules:
  - channel: fast
    fqdn: kyma-project.io/module/telemetry
    manifest:
      apiVersion: operator.kyma-project.io/v1beta2
      kind: Manifest
      metadata:
        generation: 1
        name: default-kyma-telemetry-812080235
        namespace: kyma-system
    name: telemetry
    resource:
      apiVersion: operator.kyma-project.io/v1alpha1
      kind: Telemetry
      metadata:
        name: default
        namespace: kyma-system
    state: Warning

When the state of the Telemetry module is empty, it is expected that the Telemetry state in Kyma CR is also empty
  modules:
  - channel: fast
    fqdn: kyma-project.io/module/telemetry
    manifest:
      apiVersion: operator.kyma-project.io/v1beta2
      kind: Manifest
      metadata:
        generation: 1
        name: default-kyma-telemetry-812080235
        namespace: kyma-system
    name: telemetry
    resource:
      apiVersion: operator.kyma-project.io/v1alpha1
      kind: Telemetry
      metadata:
        name: default
        namespace: kyma-system
    state: ""

Actual result
When Telemetry module is in Warning state, the Telemetry state in Kyma CR is incorrectly set as Deleting
kubectl get telemetry -n kyma-system
NAME      GENERATION   AGE   STATE
default   3            47m   Warning

  modules:
  - channel: fast
    fqdn: kyma-project.io/module/telemetry
    manifest:
      apiVersion: operator.kyma-project.io/v1beta2
      kind: Manifest
      metadata:
        generation: 1
        name: default-kyma-telemetry-812080235
        namespace: kyma-system
    name: telemetry
    resource:
      apiVersion: operator.kyma-project.io/v1alpha1
      kind: Telemetry
      metadata:
        name: default
        namespace: kyma-system
    state: Deleting

When the state of the Telemetry module is empty, the Telemetry state in Kyma CR is incorrectly set as Processing
kubectl get telemetry -n kyma-system default
NAME      GENERATION   AGE   STATE
default   1            16s

  modules:
  - channel: fast
    fqdn: kyma-project.io/module/telemetry
    manifest:
      apiVersion: operator.kyma-project.io/v1beta2
      kind: Manifest
      metadata:
        generation: 1
        name: default-kyma-telemetry-812080235
        namespace: kyma-system
    name: telemetry
    resource:
      apiVersion: operator.kyma-project.io/v1alpha1
      kind: Telemetry
      metadata:
        name: default
        namespace: kyma-system
    state: Processing

Steps to reproduce
For reproducing that the Warning state of Telemetry module is not propagated to Kyma CR:

kyma provision k3d
kyma alpha deploy
kubectl apply -f moduletemplate.yaml
kyma alpha enable module telemetry -c fast
Create a sample LogPipeline: kubectl apply -f https://raw.githubusercontent.com/kyma-project/telemetry-manager/main/config/samples/telemetry_v1alpha1_logpipeline.yaml
kyma alpha disable module telemetry
Check Telemetry state in Telemetry CR (it will be Warning):  kubectl get telemetry -n kyma-system
Check Telemetry state in Kyma CR (it will be Deleting): kubectl get kyma -n kyma-system default-kyma -o yaml

For reproducing that the empty state of Telemetry module is not propagated to Kyma CR:

kyma provision k3d
kyma alpha deploy
kubectl apply -f moduletemplate.yaml
kyma alpha enable module telemetry -c fast
Initially before the module is ready, you will observe that Telemetry state in Telemetry CR is empty while Telemetry state in Kyma CR is Processing

NOTE: The changes here are not released yet. So, you can use the below moduletemplate.yaml for debugging:
apiVersion: operator.kyma-project.io/v1beta2
kind: ModuleTemplate
metadata:
  name: telemetry-fast
  namespace: kcp-system
  labels:
    "operator.kyma-project.io/module-name": "telemetry"
  annotations:
    "operator.kyma-project.io/doc-url": "https://kyma-project.io/#/telemetry-manager/user/README"
    "operator.kyma-project.io/is-cluster-scoped": "false"
spec:
  channel: fast
  data:
    apiVersion: operator.kyma-project.io/v1alpha1
    kind: Telemetry
    metadata:
      labels:
        app.kubernetes.io/name: telemetry
        app.kubernetes.io/instance: default
        app.kubernetes.io/part-of: telemetry-operator
        app.kubernetes.io/managed-by: kustomize
        app.kubernetes.io/created-by: telemetry-operator
      name: default
  descriptor:
    component:
      componentReferences: []
      labels:
      - name: security.kyma-project.io/scan
        value: enabled
        version: v1
      name: kyma-project.io/module/telemetry
      provider: internal
      repositoryContexts:
      - baseUrl: europe-west3-docker.pkg.dev/sap-kyma-huskies-dev/telemetry-module
        componentNameMapping: urlPath
        type: ociRegistry
      resources:
      - access:
          digest: sha256:226f793665a6c87a30099119bb170694370df21baca4c51f3b44f02a12e5b235
          type: localOciBlob
        name: raw-manifest
        relation: local
        type: yaml
        version: 1.0.0
      - access:
          imageReference: europe-docker.pkg.dev/kyma-project/prod/telemetry-manager:v20230911-69866791
          type: ociRegistry
        labels:
        - name: scan.security.kyma-project.io/type
          value: third-party-image
          version: v1
        name: telemetry-manager
        relation: external
        type: ociImage
        version: v20230911-69866791
      - access:
          imageReference: europe-docker.pkg.dev/kyma-project/prod/tpi/otel-collector:0.83.0-da21e9f9
          type: ociRegistry
        labels:
        - name: scan.security.kyma-project.io/type
          value: third-party-image
          version: v1
        name: otel-collector
        relation: external
        type: ociImage
        version: 0.83.0-da21e9f9
      - access:
          imageReference: europe-docker.pkg.dev/kyma-project/prod/tpi/fluent-bit:2.1.8-da21e9f9
          type: ociRegistry
        labels:
        - name: scan.security.kyma-project.io/type
          value: third-party-image
          version: v1
        name: fluent-bit
        relation: external
        type: ociImage
        version: 2.1.8-da21e9f9
      - access:
          imageReference: europe-docker.pkg.dev/kyma-project/prod/directory-size-exporter:v20230824-2d68935f
          type: ociRegistry
        labels:
        - name: scan.security.kyma-project.io/type
          value: third-party-image
          version: v1
        name: directory-size-exporter
        relation: external
        type: ociImage
        version: v20230824-2d68935f
      sources:
      - access:
          commit: 74293a3c9d884095fe9b4e09ab2d7045712463ed
          repoUrl: https://github.com/kyma-project/telemetry-manager
          type: gitHub
        labels:
        - name: git.kyma-project.io/ref
          value: refs/heads/main
          version: v1
        - name: scan.security.kyma-project.io/language
          value: golang-mod
          version: v1
        - name: scan.security.kyma-project.io/subprojects
          value: "false"
          version: v1
        - name: scan.security.kyma-project.io/exclude
          value: '**/test/**,**/*_test.go'
          version: v1
        name: module-sources
        type: git
        version: 1.0.0
      version: 1.0.0
    meta:
      schemaVersion: v2

@kyma-project/jellyfish @janmedrek Please take a look

ACs

[ ] Clarify with @janmedrek regarding if module gets disabled/deleted, if we should respect the actual ModuleCR state or just the ManifestCR Deletion-Timestamp (current implementation)
[ ] Contact telemetry-operator team to clarify open points:

ModuleCR should not provide empty state, always should provide some state
If use custom states, please use mapping of states in module template
Double check how telemetry-operator behaves, why Warning state under deletion, when will it be set?

@jeremyharisch there is a scenario where some resources block deletion of the module. The example can be ServiceInstances and BTP Manager module - if there are ServiceInstances present in the cluster the BTP Manager will go into the Warning state indicating, that the user should remove ServiceInstances first.
Thus we have a case where a module can go into the Warning state (which means that the user needs to do some manual action) even under deletion. This state should be propagated into the Kyma CR, perhaps we can think about introducing additional status conditions for those cases (or even extending the status field in future API versions).
I guess this translates to respecting the actual ModuleCR state, as you've mentioned.
Anyways, the status should be consistent between the Module and the Kyma CR. Which translates to:

If a module is in the Warning state it should also be listed as Warning in Kyma CR (same for other states)
If there is a module which is under deletion but its state is Warning then the overall Kyma CR state should be set as Warning, not Processing (to indicate that the manual action is needed).

Regarding an empty state - it should not be the case, a module should have a state present at any given time. @shorim, you may need to adjust, until your module is Ready it should be either in the Processing or in the Warning state.

A potential solution would be to align the Manifest CR state with the Module state, then it will be automatically reflected in the Kyma CR as Warning.

@jeremyharisch there is a scenario where some resources block deletion of the module. The example can be ServiceInstances and BTP Manager module - if there are ServiceInstances present in the cluster the BTP Manager will go into the Warning state indicating, that the user should remove ServiceInstances first.
Thus we have a case where a module can go into the Warning state (which means that the user needs to do some manual action) even under deletion. This state should be propagated into the Kyma CR, perhaps we can think about introducing additional status conditions for those cases (or even extending the status field in future API versions).
I guess this translates to respecting the actual ModuleCR state, as you've mentioned.
Anyways, the status should be consistent between the Module and the Kyma CR. Which translates to:

If a module is in the Warning state it should also be listed as Warning in Kyma CR (same for other states)
If there is a module which is under deletion but its state is Warning then the overall Kyma CR state should be set as Warning, not Processing (to indicate that the manual action is needed).

Regarding an empty state - it should not be the case, a module should have a state present at any given time. @shorim, you may need to adjust, until your module is Ready it should be either in the Processing or in the Warning state.

@janmedrek @jeremyharisch Thank you for the quick reaction!
We will resolve the issue of having an empty state in the Telemetry module. In general, the objective of this issue is to make sure that the actual state of a module is reflected in the Kyma CR and not have contradictions.
Thank you again 😄


Update tests in CI

The two main changes are:

Updates Python/numpy versions in testing matrix
Adds more stringent np.loadtxt compatibility tests

This PR also reorganizes the test suite so that macos and windows jobs can be added easily, though #3 and #4 should be fixed before these jobs are added.
Re: point 2 - Previously, the CI ran the np.loadtxt test suite in a job that was allowed to fail because there are some tests that fail (8 at current count) that npreadtext._loadtxt is not yet fuly compatible with np.loadtxt. The problem with this is that if other compat tests that had previously been passing failed because of new changes, it would be difficult to catch this in CI.
I've refactored the compatibility tests so that there are two separate jobs running. The first includes all the compatibility tests that are expected to pass. If any of these fail, the CI will fail as that would indicate a regression. The second job is the same as before - run the full compatibility suite and pass no matter what. Note that individual tests from numpy.lib.test_io that are currently failing are excluded by name --- as PRs are submitted to fix these compat issues, the corresponding tests should be removed from the compat-test-ignore parameter in CI.
Note - when merging it would be nice to preserve both commits, so please don't squash :)

Self-merging so new PRs will be running with the updated CI


API800 template with "Server Profile template" resource support.

Added template for API 800 support and tested by adding server profile template support.
Check List

[x] New functionality includes testing.

[x] All tests pass ($ rake test).

[x] New functionality has been documented in the README if applicable.

[x] New functionality has been thoroughly documented in the examples (please include helpful comments).

[x] New endpoints supported are updated in the endpoints-support.md file.
[x] Changes are documented in the CHANGELOG.

LGTM. 👍 Not approving it as we don't have to merge it with the Master branch as of now.


ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE

@wy96f, can you rebase and push -f to trigger a rebuild of the PR by Travis? An issue was recently fixed that was preventing the PR build from completing properly. Thanks!

@jbertram will re-work this based on comments. After that will rebase and push :)

pushed to handle "page-size-bytes" the same way as "journal-file-size"


Placeholders don't worrk

I have the last two versions of plugins, my serveur runing on 1.12.2 (last spigot 1.12.2 version)
So, the placeholders replacement does'nt works with your plugin (I using many plugin needed Placeholers)
Please fix, if you need for infos tell me
N4TH4NOT

You have to install PlaceholderAPI expansions depending on what placeholders do you want to use


Does not render correctly with flex

      <View style={{ flexDirection: 'row' }}>
        <View style={{ flex: 0.5 }}>
          <SegmentedControl
            containerMargin={16}
            segments={['Label 1', 'Label 2']}
            onChange={(index) => setTabIndex(index)}
            currentIndex={tabIndex}
            badgeValues={[2, null, 1]}
          />
        </View>
        <View style={{ flex: 0.5, backgroundColor: 'red' }} />
      </View>

The calculation of the width seems to based on the device, not the the layout.

I am also facing the same issue. Testing OS: Android


Celo:  зависла транзакция

Describe your issue here.
Environment

Elixir Version: 1.9.0

Erlang Version: 22

BlockScout Version: 15930333a72e5bd70c177715681f827057106d68

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36

Steps to reproduce
Tell us how to reproduce this issue. If possible, push up a branch to your fork with a regression test we can run to reproduce locally.
Expected Behaviour
Tell us what should happen.
Actual Behaviour
Tell us what happens instead.

зависла транзакция


[connector/forward] Add forward connector support

Adds support for the upstream forward connector

Can you please also add a new section to https://github.com/signalfx/splunk-otel-collector/blob/main/docs/components.md ?

Looks good! Were you able to run any basic demo locally to make sure the connector works in our distro?
@crobert-1 yes, got a test build running in lab

Can you please also add a new section to https://github.com/signalfx/splunk-otel-collector/blob/main/docs/components.md ?
@dmitryax I have a new table in docs/components.go or are you referring to something else?

@dmitryax I have a new table in docs/components.go or are you referring to something else?

I see it now. Sorry, I must have missed it.
Can you please rebase to make sure the PR contains only your changes?


Feature/vmuid connectid rebrand

Marketing decided in a change of branding from Verizon Media Unified ID to Verizon Media Connect ID - this change (and the documentation change) reflects that. Please note that the AOL Bid adapter is the only bidder integrated so the change in the userId key name will not break other adapters (the AOL adapter gets userId values via the bid Object's userIdAsEids array, so it did not require a change).
Code change PR is here: https://github.com/prebid/Prebid.js/pull/6045

Hey @jeanstemp  - The code changes were already merged in Prebid JS: https://github.com/prebid/Prebid.js/pull/6045
Can this be merged soon as the docs are out-of-date.


Invalid dot in Latvian longDateFormat

In file 'lv.js':
L : 'DD.MM.YYYY.',
should be without the dot in the end:
L : 'DD.MM.YYYY',

What do you think, @skakri?

We have a validation with this and it's not optimal in front of the customer ;)
This is a bug.
https://en.wikipedia.org/wiki/Date_format_by_country

@rayokao - please see https://github.com/moment/moment/pull/4137#issuecomment-353659978

@icambron I agree with @JanisE

Closing this per https://github.com/moment/moment/pull/4137#issuecomment-353659978

Perhaps someone can make a request to update CLDR, instead.

@marwahaha , do you mean information that is displayed here: https://www.unicode.org/cldr/charts/32/verify/dates/lv.html ? They seem to have the dots all right there. Only the "year monthn day" example has the order incorrect. Do you know where the rules themselves or examples get defined? When I click on "View", I get "Survey Tool is offline.", so maybe I should try later.
BTW, regarding the dot in moment.js. If the format is used for displaying the format correctly, then the dot should be there all right. However, if it is used for validating user's input, it would probably be better to accept also dates without the last dot, like an alternative format for input. Because people really do not know the rules quite often, and it's nice that the software can help them and correct the mistake by itself automatically, not aborting the request and asking the user to realise their mistake and fix it.


BlockRefs

I wonder if it is possible to support Logseq's implementation of BlockRefs in Obsidian?

This would be incredible. It seems Obsidian blockrefs will cause an issue in LogSeq, given that [[^]] will create a page. Might need doubled-sided interoperability somehow, a Janus-faced interface.


AmazonLinux Support

Can we please add support for Amazon Linux. I know it comes pre-installed with AWS Cli. but for version management and etc it might be helpful.

It should just work since we support RedHat. Have you tried with Amazon Linux?

Yes i have tried on AmazonLinux specifically and it ran into an error. So i had to add an if statement for AmazonLinux.

Okay. Do you have an example of what changes you had to make in order for it to work on Amazon LInux? Would you like to submit a PR?

I wrote up a quick example on getting this to work on Amazon Linux in a9431e7.


No common encryption algorithm

Hi,
I'm having trouble with a cURL request... The error that I get is "cURL error 35: Cannot communicate securely with peer: no common encryption algorithm(s)."
Also, this issue only happens on some servers... I mean depending on the server that calls the script that executes the PHP script that error is generated or not.
Any ideas?
Thanks!

Hi. I believe this error means that curl couldn't find an encryption that both client and server support. For the sites where this happens, you may try entering the domain on https://www.ssllabs.com/ssltest/analyze.html to see what encryption algorithms are supported.

Thanks for your response!


Add Atari VCS Modern Controller

This config allows the Atari VCS Modern Controller to be detected and automatically configured in SDL2.
FWIW, I used https://gitlab.com/ryochan7/sdl2-gamepad-mapper to get the mapping. I did so on an Ubuntu 20.04 system using the AppImage released about a year ago: https://gitlab.com/ryochan7/sdl2-gamepad-mapper/-/releases

Thank you!


Add plugin compatibility info in the docs?

This plugin modifies the global keys of the files metadata object.
I'm wondering if a plugin compatibility section should be added to the README notifying other plugin authors of this key modification.
This is in relation to my conversation on this issue https://github.com/metalsmith/metalsmith/issues/58 as suggested by @woodyrew.

FYI, metalsmith-markdown doesn't "modify the global keys of the metadata object". The the files object is completely separate from the global metadata object, which metalsmith-markdown doesn't touch. metalsmith-markdown does modify the keys of the files object, but that's really just an unnecessarily complex way of saying "it renames the converted files from .md to .html".
I do agree though the README could probably be updated to be more clear about the finer details of how the plugin works.

I called it the global keys being that plugins access them all the way down after their altered. At first I was like "what the hell", but then after some thought I understood why it works that way.
I don't even really know what the global metadata object is for.

I called it the global keys being that plugins access them all the way down after their altered

What do you mean by that? :confused:  metalsmith-markdown changes the files object from (for example):
{
  "path/to/file.md": {
    contents: new Buffer("Some markdown content"),
    other_custom_property: "asdf"
  }
}

to
{
  "path/to/file.html": {
    contents: new Buffer("Some html content")
    other_custom_property: "asdf"
  }
}

It doesn't affect any other properties. It just renames the files and changes their contents from Markdown to HTML.

I don't really mean anything more than that. Maybe it's the wrong choice of words on my part. I don't know.
The plugin I'm working on also modifies all the file contents through, and through so it's neither here, nor there.

I don't think this is an issue, the plugin says it will rename files from .md to .html. Frontmatter keys are not changed.
Please reopen or create a new issue if this plugin causes errors or unexpected behaviour.


Validate emails by simply checking for @.

This closes https://github.com/charlesthk/python-mailchimp/issues/116, although I have discovered that Mailchimp itself doesn't support unicode in the prefix of emails (http://kb.mailchimp.com/accounts/management/international-characters-in-mailchimp).

Please update the regex itself so that we perform barebones validation and ensure that not only the @ symbol exists, but that the local and domain parts are also non-empty. Additionally, please update the docstring to remove the reference to the original email validation regex

As per Mailchimp's documentation :

Although MailChimp can process UTF-8 characters in most parts of our application, we cannot process UTF-8 characters in your subscribers' email address prefixes. We do accept Internationalized Domain Name (IDN) servers, so it’s alright to have UTF-8 characters in the domain name.
For example, we’ll block<EMAIL_ADDRESS>because the international characters are in the prefix, but we'll allow an address like<EMAIL_ADDRESS>where the characters are in the domain.

A simple Regex to check for a valid email and for Mailchimp's policy can be :
<EMAIL_ADDRESS>

@stephenross @charlesthk I've pushed the regex matching the Mailchimp docs and updated the docstring accordingly.

Thanks @Fizzadar, I will upload a new release to PyPi asap.

Thanks @charlesthk!

I've found that this change still doesn't fix #116.
Wikipedia has a simple summary of what characters are allowed in the local part of an email address: https://en.wikipedia.org/wiki/Email_address#Local-part As you can see this regex doesn't even cover half of them.
Django has a pretty comprehensive regex that could be copied or it's probably better to literally only do something like<EMAIL_ADDRESS>and leave the rest to the Mailchimp API.

Hello @kylemacfarlane,
Is the issue that you are seeing per #116 invalidated by what was posted about the MailChimp documentation above by @charlesthk? Specific bit from the Mailchimp's documentation listed below.

Although MailChimp can process UTF-8 characters in most parts of our application, we cannot process UTF-8 characters in your subscribers' email address prefixes. We do accept Internationalized Domain Name (IDN) servers, so it’s alright to have UTF-8 characters in the domain name.

@stephenross No. Something as simple as<EMAIL_ADDRESS>is a valid email but is blocked by the regex used.
The Wikipedia link has a nice rundown (assuming it's accurate) without having to delve into the RFCs.


Rename ext/HistoricaStdlibGenerator to ext/HistoricalStdlibGenerator

This typo always bugged me, but I never got around to fixing it.

Ha, I didn't notice. thanks


While using calico network on EKS cluster not able to reach Kubernetes default service

While using calico network on EKS cluster not able to reach Kubernetes default service
Expected Behavior
Kubernetes default service should be reachable from pod
Current Behavior
curl -kv https://kubernetes.default.svc.cluster.local

Could not resolve host: kubernetes.default.svc.cluster.local
Closing connection 0
curl: (6) Could not resolve host: kubernetes.default.svc.cluster.local
bash-4.4$

Possible Solution
Steps to Reproduce (for bugs)

Installed Calico network plugin
Spin up the pod and we have observed IP has been assigned from calico network
Login to the pod shell and executed the below statement to check whether kubernetes default service is reachable or not
curl -kv https://kubernetes.default.svc.cluster.local
Then we have got the below error and its not reaching to the Kubernetes default service
Error : * Could not resolve host: kubernetes.default.svc.cluster.local

Closing connection 0
curl: (6) Could not resolve host: kubernetes.default.svc.cluster.local

Also tried nslookup, please find below the output
/ # nslookup https://kubernetes.default.svc.cluster.local
;; connection timed out; no servers could be reached

Context
Cluster has been created with AWS EKS console.
Has all required traffic allowed in cluster and node security group

Calico version
v3.23.1

Orchestrator version (e.g. kubernetes, mesos, rkt):
Eks -1.21

Please help us to resolve the issue.

Error : * Could not resolve host: kubernetes.default.svc.cluster.local

Sounds like your pod is unable to reach core DNS, or there is another DNS issue in the cluster.
First thing would be to share how your cluster is configured - are you using Calico for networking or the AWS VPC CNI plugin w/ Calico for policy-only?
If you're using Calico networking, are you using IPIP or VXLAN, and have you followed the requirements here: https://projectcalico.docs.tigera.io/getting-started/kubernetes/requirements#network-requirements
For diagnosing, you should try to figure out what packet paths work:

Can pods talk to pods on their own node?
Can pods talk to other nodes?
Can nodes talk to each other? Can they talk to pods on remote nodes?
Is kube-proxy healthy on the cluster? Can you reach pod IPs directly (rather than via DNS)

You can also try using tcpdump / traceroute / etc to see how far your pod traffic is getting before it is dropped.

Hi there thanks for the quick response.
Please find my comment below :
As per my understanding it is DNS issue.
First thing would be to share how your cluster is configured - are you using Calico for networking or the AWS VPC CNI plugin w/ Calico for policy-only?
We are using VXLAN
Can pods talk to pods on their own node?   Yes (using IP)
Can pods talk to other nodes?   Yes (Using IP)
Can nodes talk to each other? Can they talk to pods on remote nodes? Yes (Using IP)
Is kube-proxy healthy on the cluster?  -- Yes
Can you reach pod IPs directly (rather than via DNS)   -Yes
Regards,
Surajit

Sounds like all of those are checking out, so you'll probably want to look into tracing the packets being sent by Calico to see where they are getting dropped, or debugging core DNS since it could possible by a DNS misconfiguration on the cluster rather than a packet routing issue.

Can you please guide me where & what to check in DNS to solve this issue ?

Hi Josh,
We can see the timeout issue from Core-DNS saying plugin/error. Please find below
[devadmin@ip-10-85-132-6 cluster.conf]$ kubectl logs -f coredns-844bb8ddf7-4zbn2
[WARNING] plugin/kubernetes: starting server with unsynced Kubernetes API
.:53
[INFO] plugin/reload: Running configuration MD5 = 47d57903c0f0ba4ee0626a17181e5d94
CoreDNS-1.8.4
linux/amd64, go1.13.15, 053c4d5c
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:40322-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:51913-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:57329-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:37878-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:39336-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:56759-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:53499-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:34043-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:55091-><IP_ADDRESS>:53: i/o timeout

[ERROR] plugin/errors: 2<PHONE_NUMBER>334832447.5001855525620343658. HINFO: read udp <IP_ADDRESS>:40322-><IP_ADDRESS>:53: i/o timeout

Seems to suggest CoreDNS might be having trouble communicating with an upstream DNS server?

Can you please tell/guide me how to solve this issue ?

I can't really resolve this without more investigation on your side - you should figure out why this connection is failing.

udp <IP_ADDRESS>:55091-><IP_ADDRESS>:53

Do you have NAToutgoing enabled on your IP pools?
Can your nodes access <IP_ADDRESS>:53?
Can your pods access <IP_ADDRESS>:53? If not, where are the packets lost?

@SurRepo did you manage to solve this? I seems to be having a similar issue.


[Python] Array fails gracefully on non-cpu devices

Describe the enhancement requested
Common Array APIs should not segfault or abort when called on non-cpu devices.
Component(s)
Python

Issue resolved by pull request 42113
https://github.com/apache/arrow/pull/42113


Check if we can return a t-expr from a function

Check if we can return a t-expr from a function. This would permit to define high-level functions from lower-level blocks:
def sma(rowcount, col):
    return (div, (sum, col), rowcount)

Is this a desirable feature?

This is confirmed to work on v0.2.2:
from fin.seq import serie, column, fc

s = serie.Serie.create(
        column.Column.from_sequence(range(5), name="T"),
        column.Column.from_sequence(range(5), name="X"),
        column.Column.from_sequence(range(5), name="Y"),
        )

def fct(serie, x, y):
    return (fc.add, x, y)

print(
    s.select(
        "T",
        (fct, "X", "Y"),
    )
)


Add ability to specify lines to check

I'm using rubocop to check styles in the pre-commit hook. And I am interesting in violations only in changed lines. Right now I'm using wrapper which patches rubocop runner. Is such feature is worth adding to the core?
What do you think?

Look at #2182. I'm closing this issue for the reasons that @bbatsov expressed there.


Negative values on y-axis

Hello,
When i have negative values for Y, there is no graph plotted. Just the title appears.
Thanks

It seems to occur when all the values of Y are negative.

Some more for the author, added a dummy (0,0) point in the beginning and it renders.


Log One Off

I often find that a player's action is moved to the beginning of the next player's turn instead of the end of this own, and this continues one.
I.E. : https://s3-us-west-2.amazonaws.com/hearthstats/prem-logs/124356/3902748

Yep, I noticed ... it's because the game log is like that. It follows the screen actions, this happens when you do stuff which is still animated when you click the end turn. I don't have an easy way to fix that atm.

Some mail from @gtch which could be a track to follow
I'm going to disgress for a moment to explain to +Michel Daviot how we can improve the end of turn detection — you may not all care about the details, just understand that we don't allocate cards to exact turns just yet, but we should be able to improve turn detection so that cards can be correctly allocated to turns...
I actually have been hoping to improve that one the refactoring of HearthStats Companion is complete, because it will be easier to do once we have a cleaner event model.
Typically the Companion notices the end of turn two or three seconds after the card draw appears in the logs: There are several reasons for the delay:

We wait for three consistent screenshots in a row (I think three) so that we're not tricked by a card flying over the screen — otherwise certain cards get mistaken for a new turn when they are picked up and fly over the turn button.
We only check a few times a second — this could be improved to many times a second if we switch from screenshots to just checking a dozen pixels or so, but I'm waiting on the refactoring for that.
The card pickup appears in the logs before the turn changes on the screen — I've confirmed this visually by watching the log and Hearthstone at the same time. So Hearthstone knows the card before it's started showing the new turn animation.

For that last reason I'm hoping to take advantage of the refactoring to have a class that consumes events from both the log and the screen, and then pushes out new events with more context. So, for example:

Log detects a card pickup
Two seconds later, screen detect a turn change
The time is within a certain threshold, so we push out a new event showing that the card pickup was for this turn, not the last — if the time isn't within a certain threshold, we would push out an event showing the card pickup for was the last turn.


api_client initialized without scope

In current library (v1.9), in the fetch_access_token method initializes the api_client and fetches the access_token.
api_client is initialized using either of the two ways-
1. If code is given (an authorization_code grant type is used) - the client is initialized using initialize_auth_api_client method which passes scope to the client init.
2. If code is not given (the client_credentials grant type is used based on the client_id and client_secret) - the client is initialized without scope which is causing errors in making calls that require scope.
This needs to be fixed.

Hi - @saurabh-jtg
I apologize for such a delayed response to this issue.    I'll check this out with the latest Python client code to see if we've fixed this up along the way.    It's true that many of the API endpoints just need a token obtained via the client_credentials flow with no scope(s) required.   I suspect that's how this initially slipped in at one point.


Update to_hit_processing.py

Fixed logbook entry for misses
Fixed crit confirmation rolls

Thanks! Funny how that went unnoticed for so long...


chore: pre-releases setup

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


#23 explained main goal of the library in details

part of #23

👍

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   92.85%   92.85%
=======================================
  Files          12       12
  Lines         140      140
  Branches        5        5
=======================================
  Hits          130      130
  Misses         10       10

Impacted Files
Coverage Δ

...org/zalando/zhewbacca/AlwaysPassAuthProvider.scala
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca0d50...7572de8. Read the comment docs.

👍


The dropdown won't display fully for me

What could be causing that?

Closing this issue, as I never got enough info to track this down. If you are having this issue, please let me know what browser and jQuery version you are using, and if the issue occurs in the demo.html page, or only on your own page. If it's only on your own page, the issue might be CSS conflicts on your page. You might also try enabling the responsiveDropdown option, which may resolve issues with the display size.


Excluding folders in flake8 is not respected

Type: Bug

Behaviour
Expected vs. Actual
Expected: Python extension should respect excluding folders in setup.cfg
Actual: The extension does not respect these settings, but in CLI it works, also other settings are respected in setup.cfg.
Steps to reproduce:

Install Python extension
Add settings.json these lines:

{
"python.linting.enabled": true,
  "python.linting.flake8Enabled": true,
  "python.linting.flake8Path": "/correct/path/of/flake8",
  "python.linting.flake8CategorySeverity.F": "Error",
  "python.linting.flake8CategorySeverity.E": "Error",
  "python.linting.flake8Args": ["--config", "setup.cfg"],
}

See your per-file-ignores are respected and correctly linted.
See your exclude folders are not respected and not correctly linted.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.8.16
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Poetry
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Telemetry level is off
Experiments are disabled, only manually opted experiments are active.
LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
Python interpreter path: ./.venv/bin/python
Starting Pylance language server.
Extension search path: /Users/validate/.vscode/extensions
> conda info --json
> poetry env list --full-path
cwd: .
> ./.venv/bin/python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/linter.py -p flake8 ./.venv/bin/flake8 --config setup.cfg ./<redacted>/cli.py
cwd: .
> . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/printEnvVariables.py
> . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/printEnvVariables.py
> . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/printEnvVariables.py
> ~/.pyenv/versions/3.8.16/bin/python -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
> ./.venv/bin/python -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
> ~/.pyenv/versions/3.8.16/envs/<redacted-env-1>/bin/python -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
> ~/.pyenv/versions/3.8.16/envs/<redacted-env-2>/bin/python -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
> /usr/bin/python3 -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
##########Linting Output - flake8##########
<redacted>
Extension search path: /Users/validate/.vscode/extensions
> ./.venv/bin/python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/linter.py -p flake8 ./.venv/bin/flake8 --config setup.cfg ./<redacted>/<redacted>.py
cwd: .
##########Linting Output - flake8##########
<redacted>
...

User Settings

languageServer: "Pylance"

linting
• flake8Args: "<placeholder>"
• flake8Enabled: true
• flake8Path: "<placeholder>"

formatting
• provider: "black"

Extension version: 2023.4.1
VS Code version: Code 1.76.2 (Universal) (ee2b180d582a7f601fa6ecfdad8d9fd269ab1884, 2023-03-14T17:54:09.061Z)
OS version: Darwin arm64 22.4.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
3, 2, 2

Memory (System)
16.00GB (0.08GB free)

Process Argv

Screen Reader
no

VM
0%

@validatedev we don't run flake8 --config setup.cfg . from the extension we run it on the specific file that you have opened flake8 --config setup.cfg <file>. Looks like exclude is ignored if you run with a specific file path.  . means run on the current directory, it can select or ignore files as described by the patterns. but when you say flake8 --config setup.cfg <file> it is running on a particular file. There is no selection of files, so it might be that flake8 is ignoring the exclude in that case.
The extension itself does not do anything special here. So in any case this should be filed on flake8.
what happens when you run flake8 --config setup.cfg .venv/<some python file> from the terminal?

@karthiknadig Yes, if I run flake8 in folder like flake8 --config setup.cfg /path/to/folder it recognizes the parameter exclude but if I run on specific python file like flake8 --config setup.cfg /path/to/python/file.py, flake8 finds problems which are excluded as I said. Thanks for the clarification.
Actually, I want to exclude a whole folder recursively to prevent flake8 linting from running in there. How can I achieve such a behavior?

Workaround is using the python.linting.ignorePatterns.
But this should be filed on flake8 that it should honor the excludes list even when using the full file path.

python.linting.ignorePatterns is not supported in the https://marketplace.visualstudio.com/items?itemName=ms-python.flake8 yet but this is a good case for adding support for it. But it should work in the python extension.

Thanks for the help! Feel free to close the issue or keep it open until python.linting.ignorePatterns is implemented.

Closing this against https://github.com/microsoft/vscode-flake8/issues/147


IN-676 Run test jobs

Adds an automated comment to the PR to either:

Say no testing will be performed if none or multiple config files are updated in the PR
Say automated testing will be performed if 1 config was updated in the PR and provide a link to the GitHub Action (GA) running

Creates a folder in the 004 test project which has been created or found, named with the GA run ID
Two new GA repository variables are set:

TEST_JOBS: '{"TWE": "job-GpfQ2fQ4fj3XG67xkbPFXKZg","CEN": "job-Gpbq1q847X23zF1568K3x3q8"}'

JSON string provides job IDs for previous dias_batch jobs for CEN and TWE to re-run with original inputs but the new updated config file depending on which config has been updated
Script will check that the Dias single version run in the original 002 project where the job was run is the same version as the current eggd_dias_single_workflow GitHub release, and warn if not (it won't error because that's actually the current situation because of sex check updates)

TEST_SAMPLE_LIMIT: 2

How many samples to run testing for

These are used to set off an eggd_dias_batch job in DNAnexus in the 004 project which has been found/created. Currently these are run with -itesting=true to automatically terminate downstream jobs, but functionality will be added later for them to run and check they complete successfully

Example batch job which was set off automatically: https://platform.dnanexus.com/panx/projects/Gpb3k6Q4PZYxVz9pzXvK82Xy/monitor/job/Gpk3xGj4PZYb7x5xGPqFB2YF (new job should be set off by this PR)

This change is

Hello @rklocke! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file get_or_create_testing_project.py:

Line 111:28: W605 invalid escape sequence '\d'
Line 111:35: W605 invalid escape sequence '\d'
Line 111:42: W605 invalid escape sequence '\d'
Line 130:13: E128 continuation line under-indented for visual indent

In the file run_testing_jobs.py:

Line 317:1: E302 expected 2 blank lines, found 1


notDeepLoosEqual to set .notExpected property instead of .expected

Unlike t.notEqual and t.notDeepEqual, t.notDeepLooseEqual sets the reference value in the .expected property instead of the .notExpected property.

This would be a breaking change, and it has no tests.
If this change isn't causing any tests to fail, tests will need to be added - otherwise, they'd need to be modified.

The PR passes all of the current tests and is consistent with all other methods.
Creating a new test for this would invlove also creating new tests for deepEqual, notDeepEqual, deepLooseEqual and notDeepLooseEqual since the .expected and .notExpected properties are not validated in any of the current tests. This would be a seperate PR with a much wider scope.

It's not solely up to me, but I'd rather refuse to merge a PR that doesn't come with at least a regression test. Even a single test case, that breaks without your change, would be a start. If tests are passing without your change - and your change is necessary - then the lack of a failing test is part of the same bug.

Ok. Let me think about it because I don't really know what to test apart from the property itself. (I'm using these properties to pretty-format the output from the native result object instead of the text output)

lgtm.

Check the TAP spec and node's assert to compare and devise relevant tests and found that node's assert only uses the .expected property for all assertion types instead of .expected and .notExpected. For consistency I would be better to change tape's properties accordingly (the opposite of the fix proposed in this PR) which could be a breaking change. I'm now using assert directly instead of jugling arround with tape's stream so this PR can be dropped and closed.


Feature request: RTSP stream toggle

Hi @bropat!
Many, many thanks for your much appreciated work on this.
I was wondering if the adapter can turn on/off the RTSP stream. There is an option in the iOS app to do that (please see attached screenshot).

Thank you for looking into this.

You, Sir, are a magician!Thanks for the RTSP toggle! A couple of coffees went your way to support your work ;)


support workloads already on target

Can WA support workloads that are already installed on the target?  (e.g. no need for binaries to be copied from host to target?)
If not, is the right way to do this to write a new target plugin?

Sure. This is up to the workload implementation. E.g. rt-app will use pre-installed binary if it finds one (or unless it's explicitly configured to always installed -- see https://github.com/ARM-software/workload-automation/blob/master/wa/workloads/rt_app/init.py#L223).


[Snyk] Security upgrade storybook from 7.6.11 to 8.0.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Denial of Service (DoS) SNYK-JS-WS-7266574
  170

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Closed by https://github.com/equinor/videx-map/pull/104


Use regular links instead of click handlers

Instead of click handlers, regular links may be used. This would have many benefits:

Cleaner, more natural integration.
Able to left-click (open in current tab) or middle-click (open in new tab).
See target in status bar.

Implementation suggestion:

Use elm.closest('a'). If a link is found, edit its href attribute do nothing, keep the existing link.
If no link is found, encapsulate the element in a link:

const link = document.createElement('a');
link.href = googleMapsLink;
mapBox.after(link);
link.append(mapBox);

I corrected the 1st point in my above implementation suggestion:
If the "map image" happens to already have a link (for instance if you live in a place where there is no stupid law that forbids it), that existing link is certainly fine, and should be more adequate than the link we are otherwise building (which is just copying the q URL parameter).


[DPE-3882] Simple speedup bootstrap

Issue
The PostgreSQL charm takes 9-10 minutes to start (be in an Active state).
Solution

Avoid the legacy upgrade code execution during the start process (because it's not needed while Patroni is still offline).
Set the primary status message earlier.
Add some debug logs of the time spent since the charm started until it reaches the Active state.
Enabled and fixed a hidden unit test (test_set_primary_status_message). It was not being executed because of indentation in the test function.

Debug logs when using this PR charm (4 minutes and 28 seconds from the beginning of the install hook until the workload is ready):
unit-postgresql-0: 20:28:18 DEBUG unit.postgresql/0.juju-log Install start time: 2024-06-24 20:28:18.945034
...
unit-postgresql-0: 20:32:46 DEBUG unit.postgresql/0.juju-log Active workload time: 2024-06-24 20:32:46.024307

Closed as duplicate of already merged https://github.com/canonical/postgresql-operator/pull/413
CC: @marceloneppel


fix: update README.md

:tada: This PR is included in version 0.1.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create "Latest Posts" link & thread

At some point, it would be interesting to discuss adding a 'latest' element to the homepage somehow. I feel like that would be helpful.

I got the urge to try this today... so here we are: https://infrastructure.sparcopen.org/latest. The homepage has an element for it now too.
It could be better designed, but this was quick and easy.
I think we should keep the homepage just manually updatable for this element.

Time estimate: 0.5 days (to finish the last few tasks / clean up the page)

[ ]  We might want a separate element, as this isn't really a 'topic', that makes this more obvious to folks who're looking for it. Also, presumable, at some point we'll really want to highlight something new and make sure people see it. This won't fix that.

I think this is something that should be solved in how we present new content in the homepage. People shouldn’t have to click twice to get the latest post -- it should be displayed as soon as they land on the site.

I'm moving this out of this milestone. I'd prefer we spent time on the homepage, and many of the above issues are solved by a better homepage.
Also, given the relatively evergreen nature of our content, at some point 'latest' is not all that interesting and since we already have 100's of ways to explore the content polishing a low priority one is not key.
That said, having it available for an occasional link, or for us behind the scenes is not bad thing, so no reason to retire it completely.


Can't connect to HA cluster after reboot

#357
reproduce:

create HA cluster with ctlptl

kind: Cluster
apiVersion: ctlptl.dev/v1alpha1
product: kind
registry: ctlptl-registry
kindV1Alpha4Cluster:
  nodes:
  - role: control-plane
  - role: control-plane
  - role: control-plane
  - role: worker

Reboot computer
start haproxy container
tilt up

Cluster status error: Tilt encountered an error connecting to your Kubernetes cluster:
	client rate limiter Wait returned an error: context deadline exceeded - error from a previous attempt: EOF
You will need to restart Tilt after resolving the issue.

There is no error when creating an HA cluster directly with the 'kind create' command.


feat(sandpack-context): add file method

  Open in CodeSandbox Web Editor | VS Code

Closes #506

@peterbartels, let me know if it looks good to you