XGBoost and MacOS incompatibility

This issue has been reported by multiple users when they attempted to install and use JAHS-Bench-201 on MacOS. To the best of my knowledge, this boils down to an incompatibility between XGBoost and MacOS, but it needs to be investigated further and should be addressed somehow at the earliest convenience in order to enable Mac users to also use the benchmark.
The following is an error log that was sent to me in response to the installation instructions in our ReadMe:
WARNING: /Users/runner/work/xgboost/xgboost/src/gbm/gbtree.cc:386: Loading from a raw memory buffer on CPU only machine.  Changing tree_method to hist.
Traceback (most recent call last):
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/jahs_bench_examples/minimal.py", line 13, in <module>
    run()
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/jahs_bench_examples/minimal.py", line 5, in run
    benchmark = jahs_bench.Benchmark(task="cifar10", kind="surrogate", download=True)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/jahs_bench/api.py", line 96, in __init__
    loaders[kind]()
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/jahs_bench/api.py", line 106, in _load_surrogate
    self._surrogates[o] = XGBSurrogate.load(model_path / str(o))
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/jahs_bench/surrogate/model.py", line 462, in load
    model = joblib.load(outdir / cls.__model_filename)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 587, in load
    obj = _unpickle(fobj, filename, mmap_mode)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 506, in _unpickle
    obj = unpickler.load()
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/pickle.py", line 1088, in load
    dispatch[key[0]](self)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 331, in load_build
    Unpickler.load_build(self)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/pickle.py", line 1552, in load_build
    setstate(state)
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/xgboost/core.py", line 1452, in __setstate__
    _LIB.XGBoosterUnserializeFromBuffer(handle, ptr, length))
  File "/usr/local/Caskroom/miniconda/base/envs/meta_neps_02/lib/python3.7/site-packages/xgboost/core.py", line 218, in _check_call
    raise XGBoostError(py_str(_LIB.XGBGetLastError()))
xgboost.core.XGBoostError: [10:43:09] /Users/runner/work/xgboost/xgboost/src/tree/tree_updater.cc:20: Unknown tree updater grow_gpu_hist
Stack trace:
  [bt] (0) 1   libxgboost.dylib                    0x00000001230ce4a4 dmlc::LogMessageFatal::~LogMessageFatal() + 116
  [bt] (1) 2   libxgboost.dylib                    0x0000000123217f39 xgboost::TreeUpdater::Create(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, xgboost::GenericParameter const*) + 729
  [bt] (2) 3   libxgboost.dylib                    0x0000000123159d8a xgboost::gbm::GBTree::LoadConfig(xgboost::Json const&) + 2634
  [bt] (3) 4   libxgboost.dylib                    0x0000000123178246 xgboost::LearnerConfiguration::LoadConfig(xgboost::Json const&) + 742
  [bt] (4) 5   libxgboost.dylib                    0x0000000123179827 xgboost::LearnerIO::Load(dmlc::Stream*) + 743
  [bt] (5) 6   libxgboost.dylib                    0x00000001230c9101 XGBoosterUnserializeFromBuffer + 145
  [bt] (6) 7   libffi.6.dylib                      0x000000010196a934 ffi_call_unix64 + 76
  [bt] (7) 8   ???                                 0x00007ff7beb9eb80 0x0 +<PHONE_NUMBER>05152

+1. I also was unable to install on MacOS

Same issue on my machine with MacOS. Here a few details:
Machine:
MacBook Pro 15" 2018
MacOS 13.0 (Ventura) but happened on MacOS 12.* (Monterey) as well
I created a new conda environment (conda 4.13.0) with Python 3.7.15 (but same error with Python 3.10.) and installed jahsbench with pip install jahs-bench. Running python -m jahs_bench_examples.minimal leads to the following error:
[20:03:24] WARNING: /Users/runner/work/xgboost/xgboost/src/gbm/gbtree.cc:386: Loading from a raw memory buffer on CPU only machine.  Changing tree_method to hist. Traceback (most recent call last):   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/jahs_bench_examples/minimal.py", line 13, in <module>     run()   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/jahs_bench_examples/minimal.py", line 5, in run     benchmark = jahs_bench.Benchmark(task="cifar10", kind="surrogate", download=True)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/jahs_bench/api.py", line 135, in __init__     loaders[kind]()   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/jahs_bench/api.py", line 148, in _load_surrogate     self._surrogates[o] = XGBSurrogate.load(pth) if not self._lazy else \   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/jahs_bench/surrogate/model.py", line 462, in load     model = joblib.load(outdir / cls.__model_filename)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 587, in load     obj = _unpickle(fobj, filename, mmap_mode)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 506, in _unpickle     obj = unpickler.load()   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/pickle.py", line 1088, in load     dispatch[key[0]](self)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 331, in load_build     Unpickler.load_build(self)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/pickle.py", line 1552, in load_build     setstate(state)   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/xgboost/core.py", line 1452, in __setstate__     _LIB.XGBoosterUnserializeFromBuffer(handle, ptr, length))   File "/usr/local/Caskroom/miniconda/base/envs/jahs_bench_test/lib/python3.7/site-packages/xgboost/core.py", line 218, in _check_call     raise XGBoostError(py_str(_LIB.XGBGetLastError())) xgboost.core.XGBoostError: [20:03:24] /Users/runner/work/xgboost/xgboost/src/tree/tree_updater.cc:20: Unknown tree updater grow_gpu_hist Stack trace:   [bt] (0) 1   libxgboost.dylib                    0x000000012a9fa4a4 dmlc::LogMessageFatal::~LogMessageFatal() + 116   [bt] (1) 2   libxgboost.dylib                    0x000000012ab43f39 xgboost::TreeUpdater::Create(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, xgboost::GenericParameter const*) + 729   [bt] (2) 3   libxgboost.dylib                    0x000000012aa85d8a xgboost::gbm::GBTree::LoadConfig(xgboost::Json const&) + 2634   [bt] (3) 4   libxgboost.dylib                    0x000000012aaa4246 xgboost::LearnerConfiguration::LoadConfig(xgboost::Json const&) + 742   [bt] (4) 5   libxgboost.dylib                    0x000000012aaa5827 xgboost::LearnerIO::Load(dmlc::Stream*) + 743   [bt] (5) 6   libxgboost.dylib                    0x000000012a9f5101 XGBoosterUnserializeFromBuffer + 145   [bt] (6) 7   libffi.8.dylib                      0x00000001075cda22 ffi_call_unix64 + 82   [bt] (7) 8   ???                                 0x00007ff7b8e931e0 0x0 +<PHONE_NUMBER>40064

As per the response of the authors of XGBoost, the correct way to handle this issue on our end will require a very significant change to the way surrogate models are saved and loaded, possibly requiring a complete rewrite of the interface between jahs_bench.surrogate.model.XGBSurrogate and sklearn.pipeline.Pipeline. Thus, I will defer this to a future update to the repo.


Create: 2101-detonate-the-maximum-bombs.py

File(s) Modified: 2101-detonate-the-maximum-bombs.py
Language(s) Used: python
Submission URL: _https://leetcode.com/problems/detonate-the-maximum-bombs/submissions/1430567358_

@SaiTeja-002 Thanks for your contribution 👍


Version bump for improved network setup on EL.

google_compute_engine: 2.2.4
google_compute_engine_init: 2.1.1
google_config: 2.1.0

Current coverage is 98.32% (diff: 100%)

Merging #343 into development will not change coverage

@@           development       #343   diff @@
=============================================
  Files               38         38
  Lines             2925       2925
  Methods              0          0
  Messages             0          0
  Branches           145        145
=============================================
  Hits              2876       2876
  Misses              43         43
  Partials             6          6

Powered by Codecov. Last update 6e06293...07d4811


Incorrect platform selected for CLI for some tools

Running terraform tests in a module on MacOS including the resource-group module. The following appears in the clis-debug.log:
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (all) Input: {"bin_dir":"/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/bin2","clis":"yq,jq,igc","uuid":"pbgueilcrauqgcpb"}
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (all) Detected os type: macos
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (all) Detected architecture: amd64
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (jq) CLI already available in PATH. Creating symlink in
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (jq) CLI already available in PATH. Creating symlink in bin_dir
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (igc) CLI already available in PATH. Creating symlink in
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (igc) CLI already available in PATH. Creating symlink in bin_dir
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (yq3) Downloading cli: https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64
/Users/timro/Public/ISV/terraform-vsi-zerotier-edge/test/stages/.terraform/modules/resource_group.clis/scripts: (yq3) Installing the cli in bin_dir

Type is determined as macos yet the linux binary for yq3 is downloaded.

Looks like the typo is only affecting the yq3 script. Tests on MacOS now working with fix.


Bug: tsswitch ignores --primary after 1st event

Hi,
Testing the following scenario:
mkfifo a b;
tsswitch -v --debug --infinite  -p 1  -I file a -I file b -O ip <IP_ADDRESS>:1234

Then steps to show the problem:

Start endless signal on FIFO a;
Start a 10s TS on FIFO b;   < === Switch happens;
After ending, start again a 10s TS on FIFO b; <== Doesn't switch anymore.

Using --infinite implies (in my understanding) that -p 1 (2nd entry) should always come up when it becomes available, right?

Also, I just noticed:
When the switch happens, the 1st FIFO is actually closed:
* Debug: file[1]: input thread started
* Debug: file[1]: waiting for input session
* Debug: file[1]: starting input plugin
* Debug: file[0]: input plugin started, status: true
* Debug: setting event: WAIT_STARTED, 0, true
* Debug: setting event: WAIT_INPUT, 0, false
========= <==========  Starts 2nd input

* Debug: file[1]: input plugin started, status: true
* Debug: setting event: WAIT_STARTED, 1, true
* Debug: setting event: WAIT_INPUT, 1, false
* Debug: enqueue action SUSPEND_TIMEOUT, 0, false
* Debug: enqueue action NOTIF_CURRENT, 0, false
* Debug: enqueue action SET_CURRENT, 1, false
* Debug: enqueue action NOTIF_CURRENT, 1, true
* Debug: enqueue action RESTART_TIMEOUT, 0, false
* Debug: enqueue action ABORT_INPUT, 0, true
* Debug: enqueue action STOP, 0, false
* Debug: enqueue action WAIT_STOPPED, 0, false
* Debug: executing action SUSPEND_TIMEOUT, 0, false
* Debug: executing action NOTIF_CURRENT, 0, false
* Debug: executing action SET_CURRENT, 1, false
* Debug: executing action NOTIF_CURRENT, 1, true
* Debug: executing action RESTART_TIMEOUT, 0, false
* Debug: executing action ABORT_INPUT, 0, true
* Debug: executing action STOP, 0, false
* Debug: file[0]: received stop request
* Debug: executing action WAIT_STOPPED, 0, false
* Debug: not ready, waiting: WAIT_STOPPED, 0, false
* Debug: executing action WAIT_STOPPED, 0, false
* Debug: not ready, waiting: WAIT_STOPPED, 0, false
* Debug: file[0]: stopping input plugin
* Debug: input 0 completed, success: true
* Debug: setting event: WAIT_STOPPED, 0, false
* Debug: executing action WAIT_STOPPED, 0, false
* Debug: clearing event: WAIT_STOPPED, 0, false
* Debug: file[0]: waiting for input session

This causes the following input entry to close:
tsp -I ip <IP_ADDRESS>:1020 -P pcrbitrate -P regulate -O file ./a
Which I think is also not right. Could you confirm?

This is a side effect of Unix named pipes. This type of device does not behave just like a permanently established pipe between applications. Each time a writer exits, the readers get an end-of-file.
Named pipes are not always appropriate for all usages. Depending on what you want to do, the input plugin fork could be a better - and portable - alternative.


cve: check user_can_edit_issue before attempting to merge a CVE

add_cve requires reporter permissions, but does not perform any further checks when attempting to merge with an existing CVE. This allows reporters a limited amount of control over CVEs for which advisories were already created, which should be denied by using user_can_edit_issue like edit_cve does.

applied with signatures via
49de1f4defe00949348aa93b4d5d9831e652b13b
31f6543e428ec8e3a4df1d1700fb19b492304ef6
plus a test case via b22b132e6509e41cb88ef36f2ca6cf95877b6e58


[BUG]: Redis is weirdly slow when using .all_pks()

Description of the bug
Not sure why this is the case, but whenever the redis server is hosted at a different place (us east vs us west) there's this significant slow. Especially when using .all_pks()
This behavior is kind of buggy since it's losing the purpose of using redis if such a delay exist
Steps To Reproduce

config a server that's not in CMU (ideally somewhere us west)
python examples/minimalist_demo.py

Additional Information
No response

This is not a function managed by the sotopia package.
Can you report it to the redis_om package?

Right, just curious whether we can fix this internally
On Fri, Jul 26, 2024 at 6:34 PM Hao Zhu @.***> wrote:

This is not a function managed by the sotopia package.
Can you report it to the redis_om package?
—
Reply to this email directly, view it on GitHub
https://github.com/sotopia-lab/sotopia/issues/158#issuecomment-2253697013,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE35IXPMHLLA624M47UIW3TZOL2JHAVCNFSM6AAAAABLRJ3TOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJTGY4TOMBRGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

all_pks uses scan_iter, which is memory efficient, but not time efficient:
As discussed in
https://github.com/redis/redis-py/issues/1102

I would suggest always set up redis close to you. It doesn't make sense to set up redis on the different end of continent across 3 time zones.
If you have to do all_pks across continent very often, you can use keys which is more memory intensive but cpu efficient. But there is a reason why redis om uses scan_iter instead of keys...

I thought one big advantage of redis is people can collaborate in a central
place
On Fri, Jul 26, 2024 at 6:54 PM Hao Zhu @.***> wrote:

I would suggest always set up redis close to you. It doesn't make sense to
set up redis on the different end of continent across 3 time zones.
If you have to do all_pks across continent very often, you can use keys
which is more memory intensive but cpu efficient. But there is a reason why
redis om uses scan_iter instead of keys...
—
Reply to this email directly, view it on GitHub
https://github.com/sotopia-lab/sotopia/issues/158#issuecomment-2253705141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE35IXKUAVHH4JQADIQZ5U3ZOL4V5AVCNFSM6AAAAABLRJ3TOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJTG4YDKMJUGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't see any performance bug in this right now, and the methods are doing what they claim to do.
The latency of the network is limited by its physical property, so I don't see any way to avoid this.

Is there any usage where you have to do all_pks() a lot of times? I think it is mainly an one-off thing, and you should avoid use it in a loop. You should use find() to avoid downloading data that you may not need.

Raising #159 to eliminate all all_pks from sotopia core library. Closing this since this is not a bug. I would still advice against deploying redis in a remote region.


Return the close code in WebSocketCommonProtocol.wait_closed

I would find it useful to get the close code as the WebSocketCommonProtocol.wait_closed future's result.
Currently, I'm wrapping .wait_closed in my use case to be able to return the close code. This could also include the reason. Instead of returning a tuple for these, we could just return the ConnectionClosed instance.

So we're talking of replacing:
yield from ws.wait_closed()
do_stuff(ws.close_code)

with:
close_code = yield from ws.wait_closed()
do_stuff(close_code)

I like the simplicity of the current wait_closed() API — no arguments, no return value, no exceptions. I'm trying to keep websockets API very straightforward and unsurprising.
Perhaps you can share an actual code example where the advantages of this change are more obvious than in my made-up example?

I wouldn't want to remove the close_code attribute. Just additionally return the close code in wait_closed(). It would be merely slightly more convenient, so I wouldn't mind if it's not being added.

I'm still in the "there should be one way to do it" camp. I haven't seen enough upside to add a second way. Sorry!


Oracle Lineage

Hi,
as I know from Sandeep Shah, Azure Purview should support lineage for Oracle's Stored Procedures now. Can you please document it?
Thank you,
Erik

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e8c9bc27-7e6f-e2a7-01af-f00171b5d63a
Version Independent ID: 155f732b-ea15-af80-c033-e8e4f53b645d
Content: Data Catalog lineage user guide (preview) - Azure Purview
Content Source: articles/purview/catalog-lineage-user-guide.md
Service: purview
Sub-service: purview-data-catalog
GitHub Login: @chanuengg
Microsoft Alias: csugunan

@eerik47 Thank you for feedback. We are  actively validating it. We will get back to you soon

@eerik47 This is documented to an extent here. https://docs.microsoft.com/en-us/azure/purview/purview-connector-overview

#closed

#please-close


Migrate Azure.SignIn rules to Azure.Audit

Background
Due to classification issues, we are merging the Azure.Audit and Azure.SignIn schemas into one (the former: Azure.Audit).
We need to migtea
Relates to https://app.asana.com/0/1205441909782364/1205232760343992/f
Changes

Move the old rules to new files with Enabled: false and deprecated notices
Duplicate the rules into the new schema and add a new guard is_signin_event in the rule function

Testing
CLI tests:

what are the implication for existing content in panther-analysis?

yeah also in terms of co-ordination with getting a new panther-analysis release out. cc: @thomduran,@nhakmiller

not 100% clear on what the migration process looks like. Will users still be able to access the old Schema for a given period of time? or will we only have the new schema available?

The process is outlined in the linked asana task.
We improved the Azure.Audit by loosening up its classification requirements. All Azure events will be classified into that from here on now. (PR_ already merged). The other schema (Azure.SignIn) is still there for now. We will remove it in the future after we get confirmation that all customers (and their detections and whatnot) have been migrated.

@darwayne Updated the data_models/azure_signin_data_model.yml and packs/azure_signin.yml files too. Let me know what you think.

ahh I see got it.

My concern was more so around if we are removing the old Schema (that will cause problems until we get customers to migrate off of them .. and of course our internal content is updated to reflect the new schema as well)


FM is starting even if job is not present in the CL node

FM starts even the related job is not present in the CL node. What should the behavior be?
At least we might need an easy way to delete subscriptions(both to CL node + the blockchain), without having to manually do it through db? Maybe something like clear/reset of all subscriptions at least?

@boxhock any thoguhts on this?

If a job is deleted on the CL node it should automatically get deleted on the EI. Do you have any logs where this isn't the case?
I've talked to Sam about this potentially being an issue, and the conclusion we made was that the node op should just manually call the DELETE endpoint on the EI to get rid of stale jobs, if that ever were to happen.

Yes, it is deleted, except for the case that EI is down when deleting.

True. Thanks.


 not displaying correctly on a card

I have a form inside a card and my <select> element is getting overlayed at the end of the card.
I have an 4th option not being displayed. I've tested on v0.95 and it is working correctly. The problem came in the version 0.96. Any suggestion to get it working?

Remove overflow:hidden from the card, this has been fixed for the next release also


Cmake not found files

three day i have a problem ,when i cmake install the erros :
CMake Error at contrib/civetweb/src/cmake_install.cmake:50 (file):
file INSTALL cannot find
"/home/sihuaiwei/桌面/git/s2client-api/build/bin/civetweb".
Call Stack (most recent call first):
contrib/civetweb/cmake_install.cmake:37 (include)
cmake_install.cmake:37 (include)

Did you get the contrib libraries in your clone?
From the root of the repo can you run: git submodule update --init --recursive
And try again?

In linux, I according the  https://github.com/Blizzard/s2client-api/blob/master/docs/building.md clone the code ,when i make install the erros is coming ;

Oh leave out install, there is no install target.
just run "make" or "make bot_simple" for instance.

How much of a pain would it be to provide an install target and find package cmake file?  Is there a reason there isn't one provided?

ok,thank you very much ,but when i run the example the error :
fatal error: sc2api/sc2_api.h:not found ,how run a example ,i am very confused .........  hope help

In your screenshot you've appeared to build all the targets without error. Can you screenshot the error you are currently having?

@kuzi117 I don't think we have a good reason other than we haven't had the time to get around to it. It's definitely something worth looking into for us though. Thank you.

@AnthonyBrunasso when i used example : #include <sc2api/sc2_api.h>
#include
using namespace sc2;
..............................................

the chinese means there is no file or directory
how use the example


Android error: No OpKernel was registered to support Op 'DecodeJpeg' with these attrs

hi! there is a mistake when i try to use my model on Android to classify pictures.
tensorflow_jni.cc:304 Error during inference: Invalid argument: No OpKernel was registered to support Op 'DecodeJpeg' with these attrs
[[Node: DecodeJpeg = DecodeJpegacceptable_fraction=1, channels=3, fancy_upscaling=true, ratio=1, try_recover_truncated=false]]
Environment info
my tensorflow version is 0.10 and i train pictures by tensorflow/examples/image_retraining/retain.py on ubuntu 16.04 with GPU
how can i solve it? thanks!

Sorry you're hitting problems! You can follow the instructions here to help prepare your model for mobile inference (since DecodeJpeg isn't supported there): https://petewarden.com/2016/09/27/tensorflow-for-mobile-poets/


Cosmos DB: Support for parametrized queries

Adds support for parametrized queries: https://docs.microsoft.com/azure/cosmos-db/sql/sql-query-parameterized-queries
opt := &azcosmos.QueryOptions{
		QueryParameters: []azcosmos.QueryParameter{
			{"@value", "2"},
		},
	}

pk := azcosmos.NewPartitionKeyString("newPartitionKey")

queryPager := container.NewQueryItemsPager("select * from docs c where c.value = @value", pk, opt)

API View
https://apiview.dev/Assemblies/Review/de637b8db22d4a19ab683fb3104df509/d69766f1fd2e469aa35d8af532c5d67e?diffRevisionId=6fa3698b49974793ac147e714bc5a4e0&doc=False&diffOnly=True
Documentation
doc.go and examples_test.go have been updated to cover the support of parametrized queries.
Closes https://github.com/Azure/azure-sdk-for-go/issues/18332

Thanks a lot @ealsur for the very quick turnaround on this!


Invalid Video Id : Error code 1

[BUG] Invalid Video id when press full screen "Invalid Video Id : Error code 1"
Steps to reproduce the behavior:
press full-screen option

This should fix with v7.0.0 . Feel free to reopen if the issue persists.


Empty Playlist error

The link works in Chrome:
D:\youtube-dl>youtube-dl.exe --verbose "http://video.scholastic.com/services/player/bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI
3eFS6eT&bclid=0&bctid=3695093189001"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://video.scholastic.com/services/player/bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhR
AI3eFS6eT&bclid=0&bctid=3695093189001']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.8 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Requesting header
WARNING: Falling back on generic information extractor.
[generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Downloading webpage
[generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Extracting information
[generic] Brightcove video detected.
[download] Downloading playlist: Book Fairs Single Video
[generic] playlist Book Fairs Single Video: Collected 1 video ids (downloading 1 of them)
[download] Downloading video #1 of 1
[Brightcove] AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT: Downloading playlist information
ERROR: Empty playlist; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete
 output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.pyo", line 524, in extract_info
  File "youtube_dl\extractor\common.pyo", line 193, in extract
  File "youtube_dl\extractor\brightcove.pyo", line 195, in _real_extract
  File "youtube_dl\extractor\brightcove.pyo", line 233, in _get_playlist_info
ExtractorError: Empty playlist; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its
 complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

I get the same error message with a Brightcove type video for this test URL:
http://www.tg4.tv/play.php?pid=4268526703001&title=Olive the Ostrich&series=Olive the Ostrich

Also getting the same error.
youtube-dl --verbose 'http://video.scholastic.com/services/player/bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001' [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'--verbose', u'http://video.scholastic.com/services/player/bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2016.03.18 [debug] Python version 2.7.9 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.3 [debug] exe versions: ffmpeg 2.6.8, ffprobe 2.6.8, rtmpdump 2.4 [debug] Proxy map: {} [generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Requesting header WARNING: Falling back on generic information extractor. [generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Downloading webpage [generic] bcpid75580074001?bckey=AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT&bclid=0&bctid=3695093189001: Extracting information [generic] Brightcove video detected. [download] Downloading playlist: Book Fairs Single Video [generic] playlist Book Fairs Single Video: Collected 1 video ids (downloading 1 of them) [download] Downloading video 1 of 1 [brightcove:legacy] AQ~~,AAAAAFv844g~,BASb5BU03X_l9AdwGvsCRhRAI3eFS6eT: Downloading playlist information ERROR: Empty playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last):   File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 668, in extract_info     ie_result = ie.extract(url)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 320, in extract     return self._real_extract(url)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 244, in _real_extract     return self._get_playlist_info(player_key[0])   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 281, in _get_playlist_info     raise ExtractorError('Empty playlist') ExtractorError: Empty playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

can be downloaded using:
youtube-dl http://link.brightcove.com/services/player/bcpid75580074001?bctid=3695093189001
[brightcove:legacy]<PHONE_NUMBER>001: Downloading webpage
[brightcove:legacy]<PHONE_NUMBER>001: Extracting information
[download] Destination: PRE FAIR Commercial-3695093189001.mp4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8926k  100 8926k    0     0   591k      0  0:00:15  0:00:15 --:--:--  535k
[curl] Downloaded 9140662 bytes
[download] 100% of 8.72MiB in 00:15


rnpm doesn't seem to install anything for iOS

I only get 2 messages that android dependencies were installed:
rnpm-link info Linking react-native-linear-gradient android dependency
rnpm-link info Android module react-native-linear-gradient is already linked

and then see no linked binaries in Xcode.

@Kureev - any idea? I didn't set this up for this project so I'm not sure what is wrong

I think @grabbou knows more about iOS part

It's likely an issue with @faceyspacey project, not linear-gradient itself (I am using it happily). What's your xcodeproj name @faceyspacey ? Does linking of other projects work? Anyway - if you could close this issue and move it to #rnpm repository, it'd be cool!

Just tested rnpm link on the fresh test project with latest rnpm, linking both Android and iOS works fine for me. It appers that this was rnpm problem and it's already fixed, so I'm closing this issue.


Create CODE_OF_CONDUCT.md

code of conduct is missing in this repo which is always there in good repo which has large community
Changes proposed ✍
What
Added a code_of_conduct.md file to the repository to establish community standards and guidelines for contributors.
Why
To provide clear expectations and guidelines for the community, fostering a respectful and inclusive environment for all contributors.
How
The code_of_conduct.md file outlines the expected behavior and standards for all participants in the project community.
Checklist ✅

[x] Label appropriately with Documentation.
[ ] Add screenshots to the PR description for relevant FE changes
[ ] New backend functionality has been unit-tested.
[ ] API documentation has been updated (if necessary) (see docs on API documentation).
[ ] Quality standards are met.

@joanagmaia      merge this pull request, or reply any changes i am happy to hear that

@jobenjada  merge this pull request or tell me the email which i should add this bot is requesting me to add


saving of theorems (as csv), states

At present the whole run history is pickled and saved. Loading this, generating theorems, and saving this as csv takes far too long.
Instead, one should in parallel:

save the full run
save final state (just use write.over)
map to theorems and save them: asynchronously.

Indeed the save function should have these as boolean options.

A problem is that we have to append to columns, not rows. So we need to read theorems so far, and rewrite the whole thing.

Will instead use mongodb


Excalidraw Collaboration Websocket connection failed

I am trying to generate a collaborative whiteboard. I have done the following steps:

Install colab server on the same machine.
Set up both servers, in ports 3000 and 3002
Install a NGINX server and configuring a proxy_pass

server {
        # SSL configuration
        listen 443 ssl;
        listen [::]:443 ssl;

        # TLS certificate
        ssl_certificate /etc/nginx/ssl/certificate.crt;
        ssl_certificate_key /etc/nginx/ssl/certificate.key;
        ssl_trusted_certificate /etc/nginx/ssl/certificate.ca.crt;

        root /var/www/html;

        # Add index.php to the list if you are using PHP
        index index.html index.htm index.nginx-debian.html;

        server_name _;

        location / {
                proxy_pass http://localhost:3000;
        }

        location /sockjs-node {
                proxy_pass http://localhost:3000;
                proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection upgrade;
                proxy_set_header Host $host;
        }
}

When I start a collaborative room, I get an error on line 120 of websocketr.js:
WebSocket connection to 'ws://localhost:3002/socket.io/?EIO=3&transport=websocket' failed:

Is your nginx serving on localhost:3002?

 Thank you so much.

closing this as its resolved!


Sentry config is not picking up "release"

Sentry errors are getting an empty "release"

compilerExplorerOptions.release = ""

Looks like we lost it in February :) 6a9f4754e0a9a3caeb20b9e10b64a2baf7be871f - shows how often we check Sentry :grinning:


translation.json isn't loading properly on staging.

Environment

create-react-app
react-app-rewired
i18next + react-i18next

Configuration
import i18n from 'i18next';
import Backend from 'i18next-xhr-backend';
import { reactI18nextModule } from 'react-i18next';

i18n
  .use(Backend)
  .use(reactI18nextModule)
  .init({
  		interpolation: {
  			// React already does escaping
  			escapeValue: false
  		},
  		lng: 'en',
      fallbackLng: 'en',
      debug: true,
      react: {
        wait: true
      }
  });

export default i18n;

Everything works perfectly on localhost:3000 however react-router-dom is redirecting my ./locales/en/translation.json file to my index. I verified that when the code is compiled my locales directory is copied over to my build directory.
Any help you could give would be greatly appreciated!

https://github.com/i18next/react-i18next/issues/431


ISPN-13271 Add REST endpoint to shutdown containers only

https://issues.redhat.com/browse/ISPN-13271
Required for https://github.com/infinispan/infinispan-operator/issues/1154

It's just the cache-container. I didn't call it that though, as it contains other resources (counters etc) and my understanding was we were moving towards the more generic name. There is /v2/container which might be a better home for the endpoint. My only doubt was that it's a cluster wide operation, but looking at ContainerResource I see that it already has global operations.


Solution in python for Concatenation of Array

What change does this PR introduce?
This PR provides a solution (code & screenshot) in the Python programming language for the Leetcode problem Concatenation of Array
Fixes #85

a pull request is already here for this, read the contribution.md on how to contribute

My apologies, I did not notice the other PR. I have went through the contribution.md and found that I did not name my branch name properly. Should I fix and try again?

can you solve this in another language?

Yes, would you like me to try using Java?

that would be great, cause some one solved it in python already

Okay I am on it! Thanks!


Add additional diagrams and content to architecture docs

Readable Version
Rendered Version
Is there a related GitHub Issue?
No, but adding some additional "deeper dives" into specific areas is something folks in the community have asked for.
What is this change about?

Added new sections for routing, services, core Korifi, logs/metrics, etc.
Added additional diagrams and update existing ones

Does this PR introduce a breaking change?
No
Acceptance Steps
None
Tag your pair, your PM, and/or team
TBD
Misc

Diagrams available here: https://miro.com/app/board/uXjVOhxvHB8=/?share_link_id=665497294647

Can be used to get higher resolution versions of them.

I think it would be useful to have a section targeted towards kubectl users so that we make it clear that CF API is not the only way to interract with Korifi. Maybe a list of custom resources one needs to apply to simulate pushing an app would be a nice one.
Otherwise, looks good.

I think it would be useful to have a section targeted towards kubectl users so that we make it clear that CF API is not the only way to interact with Korifi. Maybe a list of custom resources one needs to apply to simulate pushing an app would be a nice one.
Otherwise, looks good.

That's a good suggestion 👍. I'll add a bit to explain some of that and give some examples. The full list of things you need to do and watch for to push an app using only custom resources might be out of scope for this -- could be a decent blog post or tutorial though -- kind of like a Korifi version of https://www.cloudfoundry.org/blog/build-cf-push-learn-procfiles/.


multiple data-contracts

Is it possible to generate more than one data-contracts.ts file?
One per each module?

@kulbon I had the same question and after digging through the source it seems the answer is no, or at least not easily. Check out createMultipleFileInfos() in https://github.com/acacode/swagger-typescript-api/blob/master/src/code-gen-process.js . You can override the template it uses to render data-contracts.ts, but there doesn't seem to be a way to split the generated code apart. I'm guessing you could use the templating to mark the start and end of a given interface and use that to split the output apart with another command, but as the file is just interfaces I'm not sure it's worth the effort.


audit graphql changelog

manually audit https://docs.github.com/en/graphql/overview/changelog#schema-changes-for-2022-11-15-1 to make sure our schema is up to date, and new fields we can use are added
programmatically monitor it if possible and notify us when fields we use are mentioned, and when new fields are added.

You can introspect the schema and feed it into GraphQL Hive or GraphQL Inspector to see for any changes

@Urigo thanks, that's helpful! Any chance you'd be interested in PRing in a cron workflow that files an issue for any changes?


[TPS-04] Change to transferTalentWallet logic

Before we could transfer our ownership to any other address, without their consent.
With this change the user needs to allow the transfer to their address

The ownership transfer is well implemented, but I don't know if it is a problem that does not consider that there may be more accounts with the ROLE_TALENT role.
https://github.com/talentprotocol/contracts/blob/171ba04bc047d7b1ade268e9b5abb8b9a718cd24/contracts/TalentToken.sol#L100
As in line 100 the administration of the ROLE_TALENT to talent is granted, so he can give the role to third-party accounts before making the transfer and they will be able to claim it in the future even if the talent has changed.

In this case we give the ROLE_TALENT to the owner when initializing the contract. I'm not seeing any other way of giving this role besides the new claimTalentOwnership method, which revokes that role to the existing owner and gives it to the new proposed talent. Is there a way to give the role before making the transfer?

Yes, let's imagine the following scenario;

User A has a TalentToken, which during its initialization has been granted the role management ROLE_TALENT via _setRoleAdmin.
User A grants the role of ROLE_TALENT to User B via the public function grantRole.
User A initiates the transfer of ownership (talent) to User C, and User C completes it.
Now, User B who has the role of ROLE_TALENT initiates the transfer of talent to User A again.
User C has lost ownership of the TalentToken.

I see two options;

talent no longer needs role management ROLE_TALENT (line 100) because the transfer now calls _grantRole instead of grantRole, so we can delete _setRoleAdmin if is not needed anymore.
Override the grantRole public method to deny its use.

I think the first option is cleaner.

Yes, let's imagine the following scenario;

User A has a TalentToken, which during its initialization has been granted the role management ROLE_TALENT via _setRoleAdmin.
User A grants the role of ROLE_TALENT to User B via the public function grantRole.
User A initiates the transfer of ownership (talent) to User C, and User C completes it.
Now, User B who has the role of ROLE_TALENT initiates the transfer of talent to User A again.
User C has lost ownership of the TalentToken.

I see two options;

talent no longer needs role management ROLE_TALENT (line 100) because the transfer now calls _grantRole instead of grantRole, so we can delete _setRoleAdmin if is not needed anymore.
Override the grantRole public method to deny its use.

I think the first option is cleaner.

That makes sense, thanks for the explanation!


spanning:none behavior

spanning:none can mean 2 things:

the browser window is not spanning, period.
in that case we match: desktops, smartphones, tablets, as well as dual-screen & foldable devices when the browser is not spanned across the 2 display region.

the browser window is not spanning, but the device can span
in this case we should only match a dual-screen or foldable-device where the browser can span, but it's not spanned at the moment.

today we it matches option 1, but I think it should match option 2.
use case
a web game with a specific layout that is optimized for dual-screen experience, where the controller needs to be visible at the bottom screen and game play on the top, might want to be able to ask the user to span or rotate their device.

I think I'm leaning towards option two as well. Typically in the @media (spanning: none)  you typically do two things:

Reset the state to a single segment when you leave the spanning mode.
Invite the user (banner or other mean) to span the window because you provide a better experience when spanning.

I think it's weird that the code in that block would get parsed and resolved in desktop/mobile/tablet etc where clearly, it's not applicable.


Cannot login PWA (iOS) with e-mail or Nostr

Description
I'm not able to login with the PWA installed on my iOS device. I've linked my Nostr and email as auth methods.

E-mail does not work, because the login link will not open the PWA and I'm not able to past the login URL in the PWA.
Login with Nostr is displaying the error message no nostr extension is found.

Environment:
If you only experience the issue on certain devices or browsers, provide that info.

Device: iPhone 12 Mini
OS: iOS
Browser: PWA (Safari)

Using Github Auth works for logging in (my least preferable way of loggin in).
The Lightning auth method also doesn't work on my side. When I copy-paste the lnurld url in my Thunderhub client I get a success message but SN is returning Auth failed. Try again or choose a different method.

Thanks for creating an issue! Both the email (an ios only problem) and nostr requiring an extension are known to us but we haven't put them here to track yet afaik.
Lightning Auth should work. When it fails to link, it's usually because that lightning auth has been linked to another account.

@huumn I tried to login with Lightning in the past, but is was not connected to my account so I disconnected it.
So yes, it could be linked to another SN account now (which I'm not using). How could I restore this?

Both the email (an ios only problem)

I wonder if we could and should fix that by not only having a magic link as provided by Next-Auth but also a login code which iOS users can copy and manually paste into the PWA.

I wonder if we could and should fix that by not only having a magic link as provided by Next-Auth but also a login code which iOS users can copy and manually paste into the PWA.

We can and we should yes. :)

Not sure if this is fixable by us on mobile.

We can do this by sending a DM with a magic link!

We can do this by sending a DM with a magic link!

Oof, DMs on nostr, don't get me started haha. But yes, I think this could indeed be a very nice way to login without compromising too much on security.

Too bad that a Safari extension (Nostore above in the screenshot) is not working in a PWA for that

I'm curious, is the Nostr auth part of the next-auth package?

We hacked it in as a credential provider.


Fix #1737 - Detect non default VirtualBox Installation Path

Signed-off-by: Jean-Laurent de Morlhon<EMAIL_ADDRESS>This aims to fix #1737

I like that.
@nathanleclaire @dgageot wdyt?

Looks pretty OK. I would prefer very strongly to have this code with some accompanying unit tests.  Are you verifying all of these cases on an actual Windows machine @jeanlaurent ?

@nathanleclaire Most of them, by hand for now. :sob:
I'll try to mock the golang.org/x/sys/windows/registry, even if my recent attempt in mocking external code in go, was a bit frustrating.
The other option is to write per-OS unit testing. but it sounds like completely overkill for this.

LGTM

I wrote #2237 to discuss this per-os unit test.
I suggest we move forward with this PR now.

LGTM


Footer - BBB Logo

Expected behavior
When the BBB logo is clicked I would expect this to open in a new tab instead of taking them away from the current Tastefully Simple page.
Actual behavior
When the BBB logo is clicked you are taken away from the Tastefully Simple page.
Steps to reproduce behavior
Go to https://tastefully-simple-sandbox-2.mybigcommerce.com/store scroll all the way to the bottom and click on the BBB logo.

Opened in new tab

Closing bug


Fatal Error with Laravel 11.23.4

Hi
It seems something broke with Laravel v11.23.4 release. I'm coming across this error after I ran composer update to pull in updated Laravel & laravel-postgresql-enhanced packages.

@tpetry FYI

Are you on the newest version? The whereLike issue has been fixed with the new v1 stable release.

Are you on the newest version? The whereLike issue has been fixed with the new v1 stable release.

Ah. composer update pulled in the last minor version from the 0.4.x branch. I did the composer require tpetry/laravel-postgresql-enhanced again to pull in the 1.x branch & now all seems to be working. Thanks.


polymer: need docs for 0.10.x

I'm wondering if we should just a copy of
https://github.com/dart-lang/dartlang.org/blob/master/src/site/polymer-dart/index.markdown
in pkg/polymer, that we test & update with every breaking change, then submit a pull request when we're ready to release to stable?

This issue has been moved to dart-lang/polymer-dart#165.


Add TextType property

Fixes https://github.com/microsoft/azuredatastudio/issues/15776
Light

Dark

HC

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 6 (50.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 42.48%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/resource-deployment/src/ui/radioGroupLoadingComponentBuilder.ts
0
1
0.0%

src/sql/workbench/api/common/extHostModelView.ts
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
26761

Relevant Lines:
57070

💛  - Coveralls

@Charles-Gagnon  the issue still repro in Version 1.38.0 insiders
the bug can be closed only by tt tester once it has been verified, requesting you to open this bug

I don't believe that is the case:

Can you try to repro this again?


feat: use more efficient field merger code

Description
Problem*
Resolves
Summary*
This PR replaces the value merger code reverted in #6673 but solely for fields.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

I think we should wait for #6817 before pushing this further due to negligible changes within the test suite.


remove is_federated

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

retest this please

retest this please

closing in favor of https://github.com/hydroshare/hydroshare/pull/5526


Add team_id to SlackUser model

Added team_id to SlackUser model to support a unique_together constraint on slacker/team_id. This will allow this project to support Slack OAuth's from a single User to multiple Teams.

What do you think will happen if user of this library will try to get access_token for current user user.slack_user.access_token ?

If the User has NOT OAuth'ed to Slack yet and I call user.slack_user.access_code I get an exception. I do something like this to work with the team_id:
Try:
    slack_team=user.slack_user.extras['team_name']
    [do something with team]
Except:
   [handle when user has not OAuth'ed]

(I realize this may not be a best practice but I'm kind of new to programming.)

What happens when one user has 2 or more teams and calls user.slack_user, which slack_user  will be returned ?

Yeah, I see your point.
The OneToOne field isn't going to cut it. Let me take another crack at it.
On Tue, Aug 2, 2016 at 5:32 PM, Sergey Keller<EMAIL_ADDRESS>wrote:

What happens when one user has 2 or more teams and calls user.slack_user,
which slack_user will be returned ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/izdi/django-slack-oauth/pull/12#issuecomment-237051423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApB-O1LZaaQRaIdaoCUOvqapdCOpaUeks5qb7eCgaJpZM4JSNjt
.

--
David Miller
<EMAIL_ADDRESS>(704) 560-6733  mobile

Wondering what was the outcome of this discussion - is this issue still open?

I believe so.

Yes. I took at stab at it but Sergey quickly realized what I did was
incomplete. I haven't been comfortable making further changes but I will
revisit this shortly.
On Wed, Oct 12, 2016 at 5:16 PM, samudranb<EMAIL_ADDRESS>wrote:

Wondering what was the outcome of this discussion - is this issue still
open?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/izdi/django-slack-oauth/pull/12#issuecomment-253341792,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApB-O3txjf1mERzn6Ppqc1T7yplqZQFks5qzU4ggaJpZM4JSNjt
.

--
David Miller
<EMAIL_ADDRESS>(704) 560-6733  mobile


reduce executable size

$ ls -lh
total 344M
...
-rwxr-xr-x  1 oxarbitrage oxarbitrage 342M Jul 30 09:04 gwallet
...

By adding some flags to cmake and executing the following command(Linux) after the building:
strip --strip-all gwallet
The resulting binary is reduced currently to 19M, acceptable for now:
$ ls -lh
total 344M
...
-rwxr-xr-x  1 oxarbitrage oxarbitrage  19M Jul 30 10:29 gwallet
...

https://github.com/bitshares/gwallet/commit/15a6edb1e258a3da61a43f3f931bc6b2a0b4010a
A few more untested techniques to go lower can be found at:
https://wiki.wxwidgets.org/Reducing_Executable_Size


Prometheus metrics

We're currently scaling consumers based on the number of messages. Our scaling works as follows:
Example:

Each task takes 500ms to process.
The service level objective (SLO) is to process a task within 30sec.
Based on above 1 worker can process a maximum of 60 (= 30s / 0.5s) messages to stay within the SLO.
Given minReplicas the targetValue for the HPA should be set to minReplicas * 60 or below to account for some slower workers.

This assumes the processing time averages around 500ms which may deviate depending on possible code changes or other external dependencies.
In order to monitor processing times I would like to introduce metrics.
Metrics:

rabbitmq_cli_consumer_processsing_seconds_bucket{le="+Inf|..."}
rabbitmq_cli_consumer_errors_total

Are there any other metrics that would be useful?

Adding metrics is something I wanted to do for quite some time. So yes, I am all for it.

Are there any other metrics that would be useful?

There certainly are but let's go agile here. Step one would be to add the foundation to collect and expose metrics. After that, metrics can be added one after the other (preferably with issues on their own to keep them small).

rabbitmq_cli_consumer_errors_total

@estahn Would it be of interest to track exit codes instead of just a general error (I assume none zero exit codes counts as errors)?

@corvus-ch I have the following 2 metrics so far:
	ProcessCounter = prometheus.NewCounterVec(
		prometheus.CounterOpts{
			Namespace: namespace,
			Name:      "process",
			Help:      "Number of messages processed by exit code.",
		},
		[]string{"exit_code"},
	)

	ProcessDuration = prometheus.NewHistogram(
		prometheus.HistogramOpts{
			Namespace: namespace,
			Name:      "process_duration_seconds",
			Help:      "",
		},
	)

This results in the following:
# HELP rabbitmq_cli_consumer_process Number of jobs processed by the workers
# TYPE rabbitmq_cli_consumer_process counter
rabbitmq_cli_consumer_process{exit_code="0"} 82
# HELP rabbitmq_cli_consumer_process_duration_seconds
# TYPE rabbitmq_cli_consumer_process_duration_seconds histogram
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.005"} 0
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.01"} 0
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.025"} 0
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.05"} 37
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.1"} 76
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.25"} 80
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="0.5"} 80
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="1"} 80
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="2.5"} 82
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="5"} 82
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="10"} 82
rabbitmq_cli_consumer_process_duration_seconds_bucket{le="+Inf"} 82
rabbitmq_cli_consumer_process_duration_seconds_sum 6.731983744
rabbitmq_cli_consumer_process_duration_seconds_count 82

I'm happy to rename metrics if other names make more sense.

@corvus-ch Please see #64 as MVP. I feel the default buckets for the histogram might be quite restrictive/small, at least for rabbitmq_cli_consumer_message_duration_seconds, e.g. our service level objective allows for the message to stay for up to 29.5s in the queue. The largest bucket is currently 10s.
The buckets should be configurable IMO but I left it for the next iteration.

There is a new version available containing the changes made in #64: https://github.com/corvus-ch/rabbitmq-cli-consumer/releases/tag/2.3.3.
Thanks to @estahn for the contribution. Adding additional metrics shall be handled in issues of their own.


Default avatar for private users on repo show page

Resolves #683
This adds a default avatar image for private users that are subscribed to a repo. I used this icon from Google's material design iconset, because it's free to use (under Apache license version 2.0) and looks nice in my opinion. I think this is what was being asked for in the issue description, but the wording was a little confusing.
I didn't add any tests, because I'm not sure if tests are normally added for this sort of thing. If anyone thinks there should be a test, I can add one.

@goronfreeman definitely 👍 to tests IMO
@schneems does this fix the issue in #683?

@oniofchaos Just noticed this PR as well. I just took a look at the existing tests, and I'm exactly sure where a test for this would fit in. There aren't any Capybara tests that I could find for checking that the default avatar is on the page, so not sure if I should be the one to add the first test. Let me know what you think.

I don't see a problem with adding a test if there isn't one - leave things better than you found them :)

Thanks!


Inspect database after training

It's suggestion for enhancement.
It will be good if after network is trained we can apply it to train or val data to see what samples are the hardest and maybe remove them from DB if they are noise\outliers\mistakes.

Hello, for classification networks you can provide the train.txt or val.txt files from your dataset job directory in Test a list of images. Then you get a confusion matrix like there and you can review all individual predictions to find out which ones are incorrect.

Ok, I understand.
But there is no option to sort predictions by confidence and visually inspect images it will be a good option for data cleaning or understanding weak sides of classifier.


autocomplete via  doesn't work anymore after updating

It was already a couple months ago since i updated my vimrc files.
So yesterday i tried on both the iMac and macbook, but now the autocompletion via
snipmate on different filetypes doesn't work anymore.
I get a message:      -- Omni completion (^0^N^P) Pattern not found
I removed all the files and did a fresh install -> same issue
Can you please help me out, as always used your setup...
Kind regards,
lars

THANK YOU fredrike!!!

same issue

this has been resolved in the latest branch.


It seems that a problem occurs when building after installing the USD package on URP.

First of all, please understand that this was written through a translator.
I am using version 2022.3.10f, and I have noticed an issue where the following build error continues to occur when installing the USD package when creating a project with URP.
error CS0234: The type or namespace name 'BaseShaderGUI' does not exist in the namespace 'UnityEditor'(are you missing an assembly reference?)
It seemed that a problem related to UnityEditor continued to occur in UrpShaderImporter.cs, the script that caused the error, so I added the following code to the bottom and was able to solve the problem.
// Remove compile errors when URP package not installed
#if URP_AVAILABLE
#if UNITY_EDITOR   //What I added
            UnityEditor.BaseShaderGUI.SetupMaterialBlendMode(mat);
#endif
#endif

I don't know if this can be a fundamental solution. The version used was 3.0.0-exp.5, but the same problem continued to occur starting with 3.0.0-exp.4.

Hello!
I am facing the same issue, I also tried to add '#if UNITY_EDITOR' similarly to what @KimHyunBeom  has done, but whenever unity recompiles, the script returns as it was before compilation and I can not build.
Basically I think that the issue happens because this script is contained in a "Runtime" folder, but it is referencing 'UnityEditor' namespace, do you have a workaround for this issue?
Keep up the good work guys ✌

Hi
We recommend trying out our new USD packages released earlier this week (announcement).
The build error should no longer occur when using those packages.


Nano items + FM not consumed when changing Nano powers

When tuning a nano, the required amount of fusion matter and power items are not taken from the player.

Fixed by #139


Switch to golang/dep

The agent currently uses Godeps for package vendorization. Unfortunately, the project is out of date and has usability issues that cannot be addressed, like "Package not found".
From a quick survey, Govendor seems to be a popular vendorization tool. I'd like to switch to it as well as increase contributor documentation about how to use it.

@lukesteensen Thanks for the tip. I'll try that instead


Missing header file 'esp_wifi_internal.h' when compiling demo.ino

Hi, I tried your 'demo.ino', but encountered a compile issue in Arduino IDE 1.8.19 (Debian/Linux). Is this header file from the software development environment for the hardware based on the ESP32 chip by Espressif? Thus, do I need to set up Espressif IoT Development Framework?
Arduino: 1.8.19 (Linux), Board: "UM TinyPICO, Default, 921600, QIO, 80MHz, Enabled, None, Disabled"
/tmp/arduino_build_332910/sketch/demo.ino.cpp -o /dev/null
Alternatives for esp_wifi_internal.h: []
ResolveLibrary(esp_wifi_internal.h)
-> candidates: []
Multiple libraries were found for "WiFi.h"
Used: /home/bekr/.arduino15/packages/esp32/hardware/esp32/2.0.5/libraries/WiFi
Not used: /home/bekr/Arduino/libraries/WiFiEspAT
Not used: /opt/arduino-1.8.19/libraries/WiFi
In file included from /home/bekr/Arduino/SCRATCH-OTA-ESP32/228-Wireless-Over-the-Air-OTA-ESP32-updates/OTA_Include/demo/demo.ino:17:
Identification.h:10:10: fatal error: esp_wifi_internal.h: No such file or directory
#include <esp_wifi_internal.h>
^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
exit status 1
esp_wifi_internal.h: No such file or directory

@berrak
That library is used by Espressif themselves for displaying Wi-Fi-related logging/issues. You can comment that line out (and any others that depend on it) as it's only used for debugging purposes.

Hi Ralph,
Thanks for the quick reply.
I did that, and I'm underway to do the OTA thing.
Cheers.

It works great; I will use it in my projects. Thanks for all your work. It's much appreciated. :-)

I'm standing on the shoulders of giants, but still glad you're having success. Yes, I use all the time now too!
I'll close the issue as you have resolved your problem.


remove --enable-pulseaudio-shared=no from ci manylinux build

This doesn't change the audio issues so...


Add Steve Schveighoffer's slides

It looks like you need to add yourself to the TO_COPY list in the Makefile, s.t. the slides are copied:
See also:
https://deploy-preview-254--dconf.netlify.com/2018/talks/schveighoffer.html

You can also merge https://github.com/dlang/dconf.org/pull/255 which will add an wildcard which will allow to get rid of the problem.


Using composer, still getting 2.2

I have
    "require": {
        "drewm/mailchimp-api": "2.*"
    }

in my composer file, but when I open Mailchimp.php, I see v2.2.
I notice on the GH releases page, 2.2 is marked as the latest release, is that the issue?

It could be. I'm not entirely sure how that functionality works. Looks like tagging a release is not enough.

Oh, I just noticed that in Mailchimp.php the version is marked as 2.2, that's why I thought I'm getting that version.
I bet I am getting the current version!
Closing this ticket (though maybe update that version number in the source to help w/ the confusion?).


Unhandled browser crash event

When the chrome is killed or crash, the context will continue create newpage and throw exception:
2023-01-31 19:29:51 [scrapy.core.scraper] ERROR: Error downloading <GET https://www.baidu.com>
Traceback (most recent call last):
  File "/home/test/source/test/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 1656, in _inlineCallbacks
    result = current_context.run(
  File "/home/test/source/test/venv/lib/python3.10/site-packages/twisted/python/failure.py", line 489, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/home/test/source/test/venv/lib/python3.10/site-packages/scrapy/core/downloader/middleware.py", line 44, in process_request
    return (yield download_func(request=request, spider=spider))
  File "/home/test/source/test/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 1030, in adapt
    extracted = result.result()
  File "/home/test/source/test/venv/lib/python3.10/site-packages/scrapy_playwright/handler.py", line 261, in _download_request
    page = await self._create_page(request)
  File "/home/test/source/test/venv/lib/python3.10/site-packages/scrapy_playwright/handler.py", line 187, in _create_page
    context = await self._create_browser_context(
  File "/home/test/source/test/venv/lib/python3.10/site-packages/scrapy_playwright/handler.py", line 163, in _create_browser_context
    context = await self.browser.new_context(**context_kwargs)
  File "/home/test/source/test/venv/lib/python3.10/site-packages/playwright/async_api/_generated.py", line 13847, in new_context
    await self._impl_obj.new_context(
  File "/home/test/source/test/venv/lib/python3.10/site-packages/playwright/_impl/_browser.py", line 127, in new_context
    channel = await self._channel.send("newContext", params)
  File "/home/test/source/test/venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 44, in send
    return await self._connection.wrap_api_call(
  File "/home/test/source/test/venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 419, in wrap_api_call
    return await cb()
  File "/home/test/source/test/venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 79, in inner_send
    result = next(iter(done)).result()
playwright._impl._api_types.Error: Target page, context or browser has been closed

I use this code:
from time import sleep
import scrapy
import psutil
import os
from signal import SIGKILL

class Debug1Spider(scrapy.Spider):
    name = 'debug1'
    allowed_domains = []
    custom_settings = {
        "PLAYWRIGHT_CONTEXTS": {
            "default": {
                "ignore_https_errors": True,
            }
        }
    }

    def start_requests(self):
        yield scrapy.Request('https://www.httpbin.org/get', meta={"playwright": True, "playwright_include_page": False}, callback=self.debug_redirect)
        yield scrapy.Request('https://www.httpbin.org/', meta={"playwright": True, "playwright_include_page": False}, callback=self.debug_redirect)
        for proc in psutil.process_iter(['pid', 'name']):
            if proc.info["name"] == "chrome":
                os.kill(proc.info["pid"], SIGKILL)

    async def parse(self, response):
        print("request:{}".format(response.request.url))

Seems that it need to deal with the browser closed event.

Looks like a good start, however it might be necessary to also close the contexts like in https://github.com/scrapy-plugins/scrapy-playwright/blob/v0.0.26/scrapy_playwright/handler.py#L260-L261. This needs some research, I guess contexts might be implicitly closed because of the browser crash; in any case I'd like to make sure all related contexts are closed and removed from the context_wrappers dict (another detail to consider is that persistent contexts are not tied to the browser instance, and there doesn't seem to be a way to listen to the disconnected event on the context level).
This all assumes we would like the crawl to continue if the browser crashes: deleting the browser attribute would cause any subsequent request to try to launch a new one. I'm actually more inclined to closing the engine and stopping everything if the browser crashes, but I'm willing to be proven wrong.

Is this patch ok?

Yes, node and playwright.sh may crash and then the PlaywrightContextManager also need to restart. Due to the memory leak in browser context, it's better for now to close the engine and stop everything if the browser crashes.

There is another problem, when the driver crash, it may not trigger crash event and the page.goto is blocking which will not be timeout forever.
/usr/local/lib/python3.10/site-packages/playwright/driver/package/lib/server/chromium/crPage.js:378
      this._firstNonInitialNavigationCommittedReject(new Error('Page closed'));
                                                     ^

Error: Page closed
    at CRSession.<anonymous> (/usr/local/lib/python3.10/site-packages/playwright/driver/package/lib/server/chromium/crPage.js:378:54)
    at Object.onceWrapper (node:events:627:28)
    at CRSession.emit (node:events:525:35)
    at /usr/local/lib/python3.10/site-packages/playwright/driver/package/lib/server/chromium/crConnection.js:211:39


Optinal separate duk_internal.h  from duktape.c

Hi Sami,
Been having the pleasure over the past few weeks to finally integrate duktape into my framework. I was updating my debugger to v1.5.0 and now I wanted to bring in the patch I had written a while back to allow me to grab closure-scoped keys from a stackframe.
I was hoping to move it into an AppRequest, instead of a custom one, in order to be able to use vanilla 1.5. However, I needed access to duk_internal.h for this. So I'd had to copy over the separate headers from the dist into the my project instead of just the duktape.h & duktape.c. In order to keep it like so, I figured I'd just patch the source in a separate branch again and use the single file dist like I did before.
So I was wondering if you would consider adding an option to generate a separate duk_internal.h for the single file solution? This way, making the distributables with said option would yield:

duk_config.h
duk_internal.h
duktape.c <-- would include duk_internal.h in this case, instead of embedding it
duktape.h

This would allow for anyone wanting to add routines or mess with internals --without actually having to modify the source-- to have access to it and still having the simple single-file duktape.c object.
Eager to hear your thoughts are on this. Or if you have a better solution.
Thanks

Good to see someone else find a use case for my AppRequest feature. :)

@harold-b I'm doing a related change later on in master, where duktape.h contains all the internal structure definitions. This allows the public API to directly access internals, e.g. value pushers can directly interact with the value stack. This would also allow access to internal functions (with the caveat that every commit may break the calling code and there's no warranty ;). However, this may not always work when linking against a prebuilt library because those symbols might not be present in the symbol table.
In any case, this would be equivalent to having a separate duk_internal.h but it'd be rolled into duktape.h.

@svaarala Would it be possible to gate the internal stuff behind a compiler option so that application code can't see it by default and must opt-in?  I often use Intellisense to explore unfamiliar APIs (since this gets me up to speed faster than poring over formal documentation), and that's how I ended up using the undocumented duk_error_raw() function in minisphere. ;)

That's a little bit tricky: if a public API macro accesses a function which is not part of the public API, it must be visible for compilation.

In any case, this would be equivalent to having a separate duk_internal.h but it'd be rolled into duktape.h.
@svaarala Awesome, well that should do it.

For the time being I just patched it as I did before :).


is an Aaron Marcus translation appropriate

I was going to translate http://recodeproject.com/artwork/v3n2untitled-3-marcus for this project. Should I comb through the 5 "approved" artist to find something else instead?

made it


Re-implement Makefile and update several make rules

I have been using this Makefile format in other projects for a while and really like it. If there are no objections, I'd like to use it for cookiecutter too.
Please note that I have also updated several rules. For instance release does not run python setup.py upload any longer. It is recommended to use twine over this.
Please let me know your thoughts!
$ make
clean-build      Remove build artifacts
clean-pyc        Remove Python file artifacts
clean-tox        Remove tox testing artifacts
clean            Remove all file artifacts
contributing     Generate CONTRIBUTING.rst
coverage         Check code coverage quickly with the default Python
docs             Generate Sphinx HTML documentation, including API docs
lint             Check code style with flake8
release          Package and upload release
sdist            Build sdist distribution
servedocs        Rebuild docs automatically
submodules       Pull and update git submodules recursively
test-all         Run tests on every Python version with tox
test             Run tests quickly with the default Python
wheel            Build bdist_wheel distribution

Codecov Report

Merging #930 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #930   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          17     17
  Lines         684    684
=====================================
  Hits          684    684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3f4b2...2402fa1. Read the comment docs.

Hey @michaeljoseph @audreyr @pydanny any thoughts on this?

Thanks man! 🍨 🍪 🍨


Collapse Chevron - Native Notebooks Editor

Users during Python Extension Native Notebooks QP (5/8) failed usability test on collapse cells.
Potential solution is to make the chevron marker larger or more bold.

During the QP studies we had the chevrons always hidden except on hover, which I believe made them really hard to discover. After the studies I did change this behavior (via https://github.com/microsoft/vscode/commit/3bd820b15c79eebf0d5a86e53d8ca189b7a98c6b) to always be visible. Let's see how this improves the discoverability.


Initial batch support

Fixes #10
https://googleapis.dev/python/storage/latest/batch.html
https://cloud.google.com/storage/docs/json_api/v1/how-tos/batch

Codecov Report

Merging #12 (47a9761) into main (33dc70d) will increase coverage by 0.61%.
The diff coverage is 96.38%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   91.39%   92.00%   +0.61%
==========================================
  Files           7        7
  Lines         639      713      +74
==========================================
+ Hits          584      656      +72
- Misses         55       57       +2

Flag
Coverage Δ

unittests
92.00% <96.38%> (+0.61%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

gcp_storage_emulator/handlers/objects.py
92.45% <94.64%> (+0.98%)
:arrow_up:

gcp_storage_emulator/server.py
92.70% <100.00%> (+0.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dc70d...47a9761. Read the comment docs.


margo.sh links in warning for go1.11 do not work (subject to internet block provider filter)

This is a note rather than an issue that you need to deal with.
I'm running a go devel version, so I see the migration warning on start up. This gives a link to https://margo.sh/b/migrate/?_r=gs.
Secure Connection Failed

The connection to the server was reset while the page was loading.

    The page you are trying to view cannot be shown because the authenticity of the received data could not be verified.
    Please contact the website owners to inform them of this problem.

Falling back to http on the basis that that might work I get an $EMPLOYER site blacklist warning.
The web page requested was:

http://margo.sh/b/migrate/?_r=gs

The web page was categorised under:

adult

If you believe that the page is incorrectly categorised, and should be freely accessible, click the Recategorisation button.

I've checked access and content via my mobile ISP and don't get the https fault or see anything that would justify the block.
I have filed a recategorisation request. So hopefully this will be rectified. (Note that $EMPLOYER uses a third party filter provider, https://www.paloaltonetworks.com/, so this may affect others).

PA networks have reclassified this and now both links work without failure.

Thanks for sorting that out.
I assume you can access https://kuroku.io / https://git.kuroku.io just fine?
I can only imagine that it's the name margo or .sh that caused it. The servers do share their spare resources with the Tor network, but user requests go through Cloudflare  so that  shouldn't be a problem (I hope).
I've arranged to have https://margo.sh mirrored at https://margo.kuroku.io at least until I can investigate more.


plausible: fixup, uses older npm, requires npm bin command

Description of changes
Fixes https://github.com/NixOS/nixpkgs/issues/220178
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg  test plausible

Is there something blocking this PR?

Is there something blocking this PR?

nothing that I am aware of

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1997

Test is timing out

nixos test fails locally
here are the only useful bits i could find from the logs
machine # [   24.324826] plausible-start[894]: Crash dump is being written to: erl_crash.dump...done
machine # [   24.338008] systemd[1]: plausible.service: Main process exited, code=exited, status=1/FAILURE
machine # [   24.338719] systemd[1]: plausible.service: Failed with result 'exit-code'.

i just checked on nixos-22.05 where plausible still builds and nix-build -A nixosTests.plausible fails as well

Someone should fix that test.
@ofborg build plausible

For darwin to work, we need to set HOME to a temporary directory

npm ERR! code EROFS
npm ERR! syscall mkdir
npm ERR! path /homeless-shelter
npm ERR! errno -30
npm ERR! rofs EROFS: read-only file system, mkdir '/homeless-shelter'
npm ERR! rofs Often virtualized file systems, or other file systems
npm ERR! rofs that don't support symlinks, give this error.
npm ERR! Log files were not written due to an error writing to the directory: /homeless-shelter/.npm/_logs
npm ERR! You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

actually nixosTest is correct, the plausible service doesn't start for me, going to mark this PR as draft to further investigate this

I figured out an other issue that was preventing plausible from starting, its related to https://github.com/NixOS/nixpkgs/pull/191237
nixosTest.plausible passes now


fix: clicking title of url preview don't open site

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/21190
PROPOSAL: https://github.com/Expensify/App/issues/21190#issuecomment-1600676518
Tests

Go to a chat and add a comment google.com
Wait for the URL preview to load
Click the blue title of URL preview and verify that it opens google.com

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps
Same as test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/117511920/e4dc2d8f-71fd-476f-ac53-e22b1b4e009a

Mobile Web - Chrome

mobile-chrome.webm

Mobile Web - Safari

https://github.com/Expensify/App/assets/117511920/4a96bc25-5040-4cef-9efd-4155c8448bac

Desktop

https://github.com/Expensify/App/assets/117511920/0cb87e78-39ec-405e-bfbf-022714256498

iOS

https://github.com/Expensify/App/assets/117511920/2ab203ed-c0a6-4b54-8043-a6ff626758c8

Android

android.webm

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fix: Consistently indent with 2 spaces

This PR

[x] consistently indents .travis.yml with 2 spaces

Related to #482.

Thank you, @bighappyface and @erayd!


[CI] Fix failing workflow for bitnami

Version mismatch causing workflow failure: https://github.com/Samagra-Development/WarpSQL/actions/runs/5133893971/jobs/9237125480#step:3:5382.

updated PostGIS version for Bitnami image

Hi @PiyushRaj927 , The CI is passing in this commit 5faa6fcc26e7d6d2325c096f47ffeb145a2e2b65 . You are updating the PostGIS version from 3.2 to 3.3 which is well and good. Just want to check in with what pgdg110 corresponds to, because if its corresponds to pg11, this version 3.3.3+dfsg-1~exp1.pgdg110+1 is not accepted as of now because we are specifically running the smoketests for pg15.

If we can't rely on PostGIS apt repo, I think its best we can get Postgis official source tarball releases here http://postgis.net/source/ and install it manually.

Agreed. Can we merge this as a temporary fix until we implement the suggested approach mentioned earlier

@ChakshuGautam , we are installing PostGIS from apt repo now, which can be considered as a temporary fix for GHA. Later if we encounter a similar issue with PostGIS, we need to definitely consider installing PostGIS from sources / official PostGIS repo.
+1 Merge it as a temporary fix


Add custom auth-token header for Session for the webview

Ensure the webview Session is always sending a custom header, configured at build-time, probably
using: https://www.electronjs.org/docs/latest/api/web-request#webrequestonbeforesendheadersfilter-listener

Supported via NPLD_PLAYER_AUTH_TOKEN_NAME and NPLD_PLAYER_AUTH_TOKEN_VALUE env config settings.


TYPO in docs

https://docs.microsoft.com/ru-ru/visualstudio/releases/2022/system-requirements
section "Requirements"

from 850 GB to 210 GB must be 850mb to 210 GB
fix please

Adding @khoiph1 who manages the localization process.
The English version is correct.

@BillWagner yes. But russian not

CEINTL work item 806197 filed to the LOC team on this issue.


feat(heartbeat): add heartbeat check construct [sc-16788]

I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components

[x] CLI
[ ] Create CLI
[x] Test
[ ] Docs
[x] Examples
[ ] Other

Notes for the Reviewer

Adds the new Heartbeat check type.
This PR requires this BE branch.

Looks good!
Could you please add the heartbeat check to e2e tests for checkly test and checkly deploy too? It should work to add heartbeat checks to some of the fixtures we have. The e2e tests are here.
How will checkly test work when there are heartbeat checks? Are they already skipped , or do we need to add some code for filtering for them?

This PR should be tested with this BE branch for the tests to pass.

Looks good!
Could you please add the heartbeat check to e2e tests for checkly test and checkly deploy too? It should work to add heartbeat checks to some of the fixtures we have. The e2e tests are here.
How will checkly test work when there are heartbeat checks? Are they already skipped , or do we need to add some code for filtering for them?

@clample Heartbeat checks are excluded from trigger and test commands, so the rest of the API and Browser checks should run as expected.


When we trigger a full dump in the alma sandbox(test environment), records from lib-sftp dont transfer in the bibdata-alma-staging box

When we manually trigger a full dump in the alma sandbox the event gets created in bibdata but the records are not transferred from lib-sftp into the bibdata-alma-staging box. last time we manually triggered a full dump and we had records it was Nov 4th 2021 with an end date Nov 8th 2021.

@mzelesky deactivated again (for some reason it was active) the webhook-staging in the alma prod environment.

We were seeing the events in bibdata-staging because they were created from this webhook-staging in the alma prod - none of the staging events has files.
On Friday before deploying the ruby update in aws, I triggered an incremental publishing job in the alma-test (sandbox) environment. The files were transfered to lib-sftp through the webhook but the event failed to be created in bibdata-staging due to a ruby version error in the aws-webhook-listener.
On Friday evening I updated the webhook-listener on aws by doing a bundle install of all the gems in the webhook/src directory using ruby 2.7.5
Sunday night I triggered a new incremental publishing job in the alma-sandbox.
Monday 01-24-202, check if there is still a ruby version error in aws ; If there is no ruby version error in aws webhook-staging listener   then check if the event was created in https://bibdata-staging.princeton.edu/events and has files.

Monday 01-24-2022: the job I triggered last night created an event in bibdata but there were no files because there were no changes in the alma sandbox. @mzelesky submitted a job to alter 600 records. I triggered. This job finished. I triggered a new incremental publishing job. Will monitor if the files come in bibdata-staging and if they get indexed.

With ruby 2.5 in the webhook I can see on staging webhook the same datadog error https://console.aws.amazon.com/cloudwatch/home?region=us-east-1#logsV2:log-groups/log-group/$252Faws$252Flambda$252Falma-webhook-monitor-staging-WebhookReceiver-za2o0tUQ0XNM/log-events/2022$252F01$252F24$252F$255B$2524LATEST$255D94d3b3af61294794a3ff4aea6211761a
remaining to check if the records were indexed.


RBSheet Close when typing anything on the TextInput

HI
I am creating a Review Content in the RBSheet, when I try to type anything in the text field, it close the RBSheet automatically and first letter of what ever entered is added to the Text Input when we re open the RBSheet, the Any Idea why ?
const [reviewContent, setReviewContent] = React.useState("");

<RBSheet
	ref={refRBSheet}
	keyboardAvoidingViewEnabled={true}
	closeOnDragDown={true}
	height={430}
	customStyles={{
		wrapper: {
			backgroundColor: "transparent",
		},
		draggableIcon: {
			backgroundColor: "#000",
		},
	}}
>
	<View style={{ flex: 1, alignItems: "center", marginTop: 20 }}>
		<Text
			style={{
				color: "black",
				fontFamily: "lato-bold",
				fontSize: 20,

				padding: 8,
				textAlign: "center",
			}}
		>
			How was your overall experience with
		</Text>

		<TextInput
			multiline={true}
			underlineColorAndroid="transparent"
			onChangeText={setReviewContent}
			value={reviewContent}
			style={{
				borderWidth: 1,
				borderColor: "#e0e0e0",
				height: 150,
				width: "60%",
				textAlignVertical: "top",
			}}
		/>
		<TouchableOpacity>
			<Text
				style={[
					styles.text,
					{
						textAlign: "left",
						color: "black",
						fontFamily: "lato-regular",
						marginTop: 5,
						borderWidth: 1,
						borderColor: "blue",
						padding: 10,
						borderRadius: 25,
					},
				]}
			>
				Write A Review
			</Text>
		</TouchableOpacity>
	</View>
</RBSheet>;

Keep the RBSheet inside the same View that your onPress handler is.

I am having the same problem on android. On Ios its works fine

Facing the same issue

Keep the RBSheet inside the same View that your onPress handler is.

Moving it inside the Main Screen component solved my issue.

I've done something like this, and whatever children I have inside the RBSheet, it seems to work fine
return (     <View style={{}}>       <TouchableOpacity         style={styles.TouchableOpacity}         onPress={() => refRBSheet.current.open()}>         <Icon name={iconName} size={26} color={theme.Colors.blue} />       </TouchableOpacity>       <RBSheet         closeOnPressBack={closeOnPressBack}         ref={refRBSheet}         closeOnDragDown={true}         closeOnPressMask={true}         height={height}         animationType="fade"         customStyles={{           wrapper: {             // backgroundColor: 'rgba(0,0,0,0)',             backgroundColor: 'rgba(0,0,0,0.5)',           },           draggableIcon: {             backgroundColor: '#ccc',           },           container: {             padding: 20,             paddingTop: 10,             borderTopRightRadius: theme.ScreenDimensions.width * 0.08,             borderTopLeftRadius: theme.ScreenDimensions.width * 0.08,           },         }}>         {children}       </RBSheet>     </View>   );

i am still facing the same issue and I'm also wrap my RBSheet component inside the main component.

If you are opening RBSheet inside the render function of flatlist . Then it is a bug related to flatlist. It has nothing to do with RBSheet and TextInput. A bit strange but I figured out after carefully going through the documentation of Flatlist props in official documentation. Set the prop removeClippedSubviews={false} since it is true by default on android. According to documentation it may increase performance but can cause bugs. In this case, closes the bottom sheet when textinput is focused. That behavior is also random.


Fine tuning LLAVA for object detection

How do we finetune llava for object detection tasks, or predicting a trajectory of actions. How would that work? Then I need some regression based loss like MSE right ? And instead of outputting text we would want to output a set of coordinates. From other repos it seems like fine tuning for regression tasks doesn’t seem to work well.

Hey! I would said multi_token/llava are best suited for taking the features from an image model and embedding them in a chat-able large language model.
If you want to do object detection (rather than chat-with-this-image type tasks), you are best off just using an existing object detection specialized architecture: https://huggingface.co/docs/transformers/en/tasks/object_detection. If you wanted to then do something chat/text based on already detected objects, you could pass the outputs of that object detection model to the LLM.