Azure Portal generated passwords with special characters not accepted by az login service principal

Describe the bug
When trying to use a Service Principal password that contains special characters, you get errors (see screenshot attachment)
To Reproduce
See screenshot attachment
Expected behavior
I am able to login via az login if the correct credentials are supplied
Environment summary
latest version of azure-cli, just installed it (2.0.52) and running the commands via Windows Powershell
Additional context
The passwords are being generated in the Azure Portal when I create a secret, so I have no control over how the password gets generated.  Would be nice to have an option to specify if special characters are placed in the password or not ie passwordgenerator.net.
See attached to view all the different combinations I have tried with no success.  As you can see in the last attempt, I put the wrong password in ("test"), which has no special characters and authentication failed, which tells me it is the password format that is the issue.
Also, I generated about 10 different secrets and all have special characters and would not work.

Similar issue with the & character:
When running this from PowerShell:
az login -u<EMAIL_ADDRESS>--allow-no-subscriptions -p "Pass_&_AY"
Error:
'_AY' is not recognized as an internal or external command,
Escaping & with a backtick does not help.

Found a workaround that works in PowerShell:
$o365Admin = Get-Credential -Message "Enter Global Office 365 Admin Credentials"
az login -u $o365Admin.UserName --allow-no-subscriptions -p "`"$($o365Admin.GetNetworkCredential().password)`""

@tjprescott I think @Zerg00s workaround (which also works for me) is evidence that you've misdiagnosed the issue.  The shell-specific interpolation is of course out of your control, but if that were the only problem with the OP's examples, wrapping the password in single quotes should have succeeded.
What @Zerg00s did to get it to work was double-wrap the password in quotes (escaping the inside set of quotes).  So the value ends up being ""$password"" (this is exactly how I passed in the value).  This shows that the az cli is doing extra interpolation after receiving the string, which it shouldn't be doing.

Hi @tjprescott, I don't think this issue should be closed.  See my comment above.  Could you please re-open it?

I'm no longer on the CLI team, so I can't re-open. @MyronFanQiu can you take a look and re-open if appropriate?

@

Similar to https://github.com/Azure/azure-cli/issues/11003#issuecomment-569213105
@joshschmitter, please check the solution and let us know if you can get unblocked.

Yeah, #11003 seems like the same root cause.  And according to the docs referenced, this is happening because the az cli is a batch script and powershell has to pass the command to the Command Prompt.  Using the stop-parsing symbol --% is inconvenient since variables like $password won't be interpolated, but it doesn't look like another solution is possible.
I think I'll keep escaping another set of quotes.

Windows PowerShell is aware of this issue and is working on a fix.
Currently if you need to use $password, special characters needs to be escaped according to CMD syntax to prevent it from being parsed again by CMD. Thanks for your understanding.

FWIW in bash using --pasword=<nasty password with ugly chars>
worked for me (i.e. using =)


Pre-built binaries on a remote

Is it worth documenting how to deploy pre-built binaries for each system architecture? Right now the package.json points to a remote location but as far as I can tell there's nothing to build and deploy to this location.
cc @springmeyer @jakepruitt @GretaCB

Since this will come up for any cpp project, I think it's probably worth adding a commit-based script for publishing binaries via travis, something similar to Node Mapnik: https://github.com/mapnik/node-mapnik/blob/master/scripts/publish.sh

Sooooo the issue here is that pre-built binaries on an s3 bucket will require a specific set of secret tokens, etc. Those can't be shared across projects (in the sense that we are sharing code with node-cpp-skel), but we can document how to set it up. The access to https://mapbox-node-binary.s3.amazonaws.com is Mapbox user specific, so maybe we should make a note in the README about pre-built binary releasing that discusses what a user needs to do to get things set up.

Okay, I've been working on getting this set up with vtinfo and think we can point to the node-pre-gyp docs about setting up secure access keys for travis: https://github.com/mapbox/node-pre-gyp#travis-automation
Probably best to link to the "how to generate the proper IAM roles" as well, so people can learn more about that.

think we can point to the node-pre-gyp docs about setting up secure access keys for travis: https://github.com/mapbox/node-pre-gyp#travis-automation

Correct.

Probably best to link to the "how to generate the proper IAM roles" as well, so people can learn more about that.

👍  What is critical is that the role is scoped to the specific bucket + module such that npm unpublish or npm publish cannot overwrite any binaries inside the bucket not related to the specific module.

Going to confirm publishing binaries works as expected, then we can update the readme, then close this!

Also look at this commit - confirm it works: https://github.com/mapbox/node-cpp-skel/commit/dcd6e49faff2a851164c1357a7af2cc6f3ddea78

Publishing now works for linux. Going to wait for the OSX build to finish 🍏  before merging.

OSX is passing! Now waiting for binaries to publish for it ... then we're off to the races. 🏇

Binaries exist after https://github.com/mapbox/node-cpp-skel/pull/26 merged


[OpenVINO] Enable GPU support for OpenVINO vLLM backend

These changes add GPU device support for OpenVINO vLLM backend

Added VLLM_OPENVINO_DEVICE environment variable for OpenVINO device selection
Updated GPU-related components in OpenVINO backend (KV cache shapes, swap capability, model profiling run etc)
Updated OpenVINO version to 2024.4 RC1 in dependencies
Updated installation instructions

Some performance measurements obtained for Intel ARC A770 (16GB) for 1000 prompts from ShareGPT_V3_unfiltered_cleaned_split dataset:

Hi
I tried the PR, but new error occurred. I use openvino-gpu to run qwen2-0.5b. It turns out:
Traceback (most recent call last):
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 302, in determine_num_available_blocks
    kv_cache_size = self.profile_run()
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 549, in profile_run
    model_profile_run()
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 538, in model_profile_run
    self.model_runner.execute_model(seqs,
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/workspace/vllm/vllm/worker/openvino_model_runner.py", line 340, in execute_model
    hidden_states = model_executable(**execute_model_kwargs)
  File "/usr/local/lib/python3.10/dist-packages/nncf/torch/dynamic_graph/wrappers.py", line 146, in wrapped
    return module_call(self, *args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/workspace/vllm/vllm/model_executor/model_loader/openvino.py", line 164, in forward
    self.ov_request.wait()
RuntimeError: Exception from src/inference/src/cpp/infer_request.cpp:245:
Exception from src/bindings/python/src/pyopenvino/core/infer_request.hpp:54:
Caught exception: Check '!exceed_allocatable_mem_size' failed at src/plugins/intel_gpu/src/runtime/ocl/ocl_engine.cpp:139:
[GPU] Exceeded max size of memory object allocation: requested<PHONE_NUMBER>2 bytes, but max alloc size supported by device is<PHONE_NUMBER> bytes.Please try to reduce batch size or use lower precision.

19914555392 bytes equals 18.5GB. That's strange. I tried some solutions, but they didn't solve my problem.
Any solution or hint?
FYI: I use gpu-version vllm to run qwen2-1.5b, which uses ~8GB by showing nvidia-smi.

Hi I tried the PR, but new error occurred. I use openvino-gpu to run qwen2-0.5b. It turns out:
Traceback (most recent call last):
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 302, in determine_num_available_blocks
    kv_cache_size = self.profile_run()
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 549, in profile_run
    model_profile_run()
  File "/workspace/vllm/vllm/worker/openvino_worker.py", line 538, in model_profile_run
    self.model_runner.execute_model(seqs,
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/workspace/vllm/vllm/worker/openvino_model_runner.py", line 340, in execute_model
    hidden_states = model_executable(**execute_model_kwargs)
  File "/usr/local/lib/python3.10/dist-packages/nncf/torch/dynamic_graph/wrappers.py", line 146, in wrapped
    return module_call(self, *args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/workspace/vllm/vllm/model_executor/model_loader/openvino.py", line 164, in forward
    self.ov_request.wait()
RuntimeError: Exception from src/inference/src/cpp/infer_request.cpp:245:
Exception from src/bindings/python/src/pyopenvino/core/infer_request.hpp:54:
Caught exception: Check '!exceed_allocatable_mem_size' failed at src/plugins/intel_gpu/src/runtime/ocl/ocl_engine.cpp:139:
[GPU] Exceeded max size of memory object allocation: requested<PHONE_NUMBER>2 bytes, but max alloc size supported by device is<PHONE_NUMBER> bytes.Please try to reduce batch size or use lower precision.

19914555392 bytes equals 18.5GB. That's strange. I tried some solutions, but they didn't solve my problem. Any solution or hint?
FYI: I use gpu-version vllm to run qwen2-1.5b, which uses ~8GB by showing nvidia-smi.

change memory here to 4gb solver my problem.

Hi @WoosukKwon, could you please take a look at these changes?

@mgoin, thank you for your comments! I applied them and rebased the branch on top of the recent main, please take a look

Thanks for the quick feedback. I am enabling the full CI to run - you may want to merge with latest main to get the CI green since there have been failures before today

@mgoin , @WoosukKwon could you activate automerge?


Omit the PHP tag

Is that possible create a PHP file and not use the <?php tag?

This looks like a duplicate of https://github.com/atom/language-php/issues/101 – feel free to leave a comment there!


Translate rolling-back-a-deployment.md into Japanese

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

lgtm 👍
/approve


Extension: pgvector

Support pgvector extension

How does extension support work pglite? I think this is one of the most exciting aspects of pglite and would love to understand what it might look like as I have loved setting up postgres with custom extensions myself before and it would be cool to be able to figure that out for pglite as well.
Does the extension need to be included in the wasm bundle or can it be provided as a separate wasm artifact? Would plugins written with pgrx be easier to port?
Thanks for this exciting project!

Related: loading dynamic extensions compiled as WASM https://github.com/asg017/sqlite-loadable-rs/issues/5

pgvector is supported in the current alpha/@next release, expected to go final in about a week.


[api] Adds Image.duplicate() back

Change-Id: Ic45f668591f4677708e40090f3ea9487a098e3fb
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1355 (c96c8ce) into master (bb5073f) will decrease coverage by 0.38%.
The diff coverage is 61.77%.

@@             Coverage Diff              @@
##             master    #1355      +/-   ##
============================================
- Coverage     72.08%   71.69%   -0.39%
- Complexity     5126     5183      +57
============================================
  Files           473      480       +7
  Lines         21970    22473     +503
  Branches       2351     2413      +62
============================================
+ Hits          15838    16113     +275
- Misses         4925     5133     +208
- Partials       1207     1227      +20

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.69% <0.00%> (ø)

...odality/cv/translator/YoloV5TranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...modality/nlp/embedding/TrainableWordEmbedding.java
45.00% <0.00%> (-3.34%)
:arrow_down:

...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java
54.54% <0.00%> (-12.13%)
:arrow_down:

...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java
15.23% <0.00%> (-0.83%)
:arrow_down:

... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce3525...c96c8ce. Read the comment docs.


Search feature

Some way to search the menus for a specific mod becausefinding a mod you don't want anymore and removing it entirely is quite difficult.
Thanks!

It's not at all discoverable, but this already exists if you start typing into the window. A search box will appear and highlight matching mods.


use ssh tty

select tty When /dev/tty is unavailable

Thanks this looks great. Can we elaborate on when we might need to use the -d flag? E.g. how would I go about testing it?

Thanks this looks great. Can we elaborate on when we might need to use the -d flag? E.g. how would I go about testing it?

When I SSH into my server and use Neovim to edit content, I want the content I copy in Neovim to be synchronized with the local system clipboard. I found that using "/dev/tty" doesn't achieve this, so I added the usage of "$SSH_TTY". If I'm not SSHed into the server, using "/dev/tty" works without any issues. I also want to be able to use other TTY devices with the "-d" parameter.


Application customizer fails to load sporadically

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version : Chrome 100 & Edge 100
SPFx version: v1.13
Node.js version: 14
etc

Describe the bug / error
We are having a Header component in SPO using Application Customizer. The component loads fine for the first time and then for following refreshes fails with the below error.
Refused to execute script from 'https://contoso.sharepoint.com/sites/Appcatalog/ClientSideAssets/adc45aee-4225-4dbb-9d6a-c42904c8bd65/SPOHeaderApplicationCustomizerStrings_en-us_09d7816cec5d664c5791eb382892222b.js' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

Could not load spo-online-header-application-customizer in require. Trying in system.js. Error: Script error for: fd7e3581-8ccf-4780-b3d1-67a0e4cd17c7_0.0.1/spoHeaderApplicationCustomizerStrings
http://requirejs.org/docs/errors.html#scripterror
    at B (eval at e (sp-pages-assembly_en-us_5e35b6d337d496dfb5f856b9e0c438e0.js:70:848251), <anonymous>:8:252)
    at HTMLScriptElement.onScriptError (eval at e (sp-pages-assembly_en-us_5e35b6d337d496dfb5f856b9e0c438e0.js:70:848251), <anonymous>:30:244)

This is happening only in Chrome but not in Edge browser. If I clear cache in Chrome it works but successive refreshes will not load the component and the above errors will be present in the Chrome browser console.
Steps to reproduce
Sporadic and happening only in Chrome
Expected behavior
N/A

@wizneeraj - could you please try adding ?sw=bypass on a successive refreshes and see if it's still failing?
Thanks!

Yes, adding ?sw=bypass and then refreshing page loads the Application Customizer's Header component fine

@AJIXuMuK - Based on further investigation found that the js files were loading from chrome's cache which were few days old. On deleting the SPOHeaderApplicationCustomizerStrings_en-us_09d7816cec5d664c5791eb382892222b.js file from the chrome cache is fixing the issue. But, I cannot use this solution for all the other users on the tenant who are facing this issue sporadically.
Is there a way to fix this issue, so that other users do not face this issue? Also, I am sure I will be facing the issue as well after few days.

Hi @wizneeraj - is this a new customizer or an existing customizer that stopped working? Would it be possible for you to share a trace (Fiddler/har file) of a failure loading the customizer? That would be useful for my investigation.
Also, from the trace that you shared, since the URL in that trace points to "contoso.sharepoint.com", I just wanted to confirm; you manually replace the actual URL with this example URL?
It also seems from that trace that the cache entry for the script file was unexpectedly in HTML format. I am wondering if possibly, the original request that cached the strings file got throttled and returned a HTML throttle page.
BTW, it is not a requirement but in general, hosting the customizer on a CDN may present better performance of the customizer. If the original issue was related to throttling, then it would also resolve that issue.

@demyren - It was an existing customizer that stopped working for random users in Chrome. I went into cache storage where the content type of SPOHeaderApplicationCustomizerStrings_en-us_09d7816cec5d664c5791eb382892222b.js was saved as text/html. I removed the file and refreshed the page and ever since then the customizer started working fine. I am not sure how the content type was saved with a wrong value, may be it happened due to throttling, which I am not sure. Is there any way to fix it from my end or is it a chrome issue? Anyways to handle it better in the customizer's code?
Yes, I replaced the URL with contoso.sharepoint.com for privacy reason instead of the original URL.

@wizneeraj I see, thank you for the information. We haven't had any impacting changes here as of late. That said, I am suspecting that the original request to SharePoint to load the file indeed resulted in a throttling error and incorrectly caused the service worker to continue serving the cached HTML result.
We will address this problem with a change that ensures that whenever we cache your script files into cache storage, we ensure that the resulting response is not a throttling error.
For optimal performance and delivery to clients, you may consider moving your customizer to CDN.
That said, we certainly hope to land the change this week that will prevent these bad, throttled responses from getting cached. I will update the thread again with information on rollout of that change once we have completed it.
Thank you for reporting the issue and allowing us make the product better!

@demyren - Thanks, looking forward to the fix.

@demyren - Has the fix been deployed ?

@wizneeraj, the change will start deploying on 10/24 and will finish by 10/28. I will post back when the deployment has completed! I apologize for the delay.

Thanks for the update @demyren

Hello @demyren,
Not sure how it is related to this issue, but we have similar issue with WebParts: sometimes, some of them failed to load with "strange" errors (HTTPS certificate issue for a file hosted in the Azure CDN, unable to load empty component).
When this happens, we also note that the loaded script files are from different versions of our package:

Can you confirm the fix you mentioned will work for this case (or should I open another issue)?

@mgrosperrin I'm afraid that does not sound related - and frankly not something I think I have seen before. Do you typically see it occurring as you deploy a new version of your web part? Do you use any authentication on your CDN or are the script files anonymous requests? If you are able to collect a Fiddler or HAR trace, you can send this to me (demyren@microsoft.com).

@demyren I create a new issue with an HAR from a test environment #8519

@wizneeraj, the change will start deploying on 10/24 and will finish by 10/28. I will post back when the deployment has completed! I apologize for the delay.

@demyren - Has the fix been rolled out to all tenants ?

@wizneeraj The change was delayed by another week but is starting to deploy to Prod tomorrow 1/11. My apologies for this additional delay.

@demyren - Is the fix rolling out from Nov 1st?

@wizneeraj, yes, the fix started deploying to Prod this week. The deployment should complete fully by 11/7. I will post back when it is completed.

@demyren - Please let me if the fix has been rolled out completely.

@wizneeraj The build has finished deploying to Prod. Note, you may need to return to SharePoint and wait a few seconds for the new service worker to install and activate. Followingly, the reported problem has been addressed and will prevent throttling responses from getting inserted into the cache.
Thank you for reporting the issue, and for your patience when the fix got delayed! I hope you see things working smoothly from now on. Should there be further problems, do not hesitate to reach back out to me.

@demyren - Thanks for the update. Will check from my end and let you know. Meanwhile, when you say "return to SharePoint", is there any specific you are referring to, or accessing any site will make the new service worker to install and activate?

@wizneeraj, thank you. I hope it will work out well for you. Yes - returning to any site will do, and should install the latest service worker.

@demyren - We are seeing this issue again in our tenant where the js file is getting tagged with a wrong content type in the browser cache. Its getting tagged with text/html type instead of application/javascript. Was there any rollbacks to the solution deployed ?

Hi @wizneeraj - I'm sorry to hear you are running into this problem again.
We have not made any changes since we deployed this code fix. The fix ensures that if a file is served from SharePoint,
we validate the content type of the response (Content-Type header) to match the acceptable content types as specified in the Accept request header.
If you open the Site- cache storage, can you see your file in there? What is the content of this file, is it again the throttling HTML response instead of the expected JavaScript?
If it is, it would be great if you could first copy it or screenshot it, then delete that file from the cache and retry.
Does that re-cache the file correctly? If you can send this to<EMAIL_ADDRESS>I can review the request and response of the incorrectly cached file and see if I can understand why we ended up caching this file even if SharePoint returned a throttling error.
Thank you.

@demyren - Commenting into the thread as we have faced a similar issue where system.js issue happening for app customizer and webpart. On hard refresh it works fine. Adding ?sw=bypass is working fine as well as mentioned above. However, we can't force all end users to add ?sw=bypass. Only happening in Chrome.
We have an example of site getting throttled as well. Chrome cache is showing content-type as "text/html" as well.

Almost all of the above discussions are pretty much matching with our case. It seems that Chrome is caching throttle response as well. I saw you have deployed the latest build in production during November. However, we are using Chrome v105 which was released in August. Latest Chrome version is v108. Do you feel it might be due to Chrome version as well ?
Just out of curiosity @wizneeraj - Is it fixed for you or you are still seeing throttle response cached in Chrome?

@demyren - We are still seeing the issue as the old cached value is not getting removed from the user's browser. There was a wrong cached content type on 12th Oct which is not yet removed and causing the issue. Manually removing the cache is fixing the issue. However, we have a very large user base and manually fixing it for everyone is not the solution. Doesn't the Cache storage get rebuilt on a periodic basis?
@msoumit - We are not facing the issue for any new users. We are seeing it only for the user's who have the old cached content.

@wizneeraj - sorry for the delay. Are you still experiencing the issue?
@demyren - could you please keep in touch?

@msoumit, are you experiencing this issue still?

@AJIXuMuK - We had to repackage the solution with a new version number. Then remove the existing solution completely from the App Catalog and the recycle bin. Then we deployed the solution with new version number, post that we did not see the issue.

@demyren We were facing same issue with both our app customizer and webpart. We have only one app customizer and a webpart in our application. Usually, it was user specific. At random interval, random users used to face this problem. Initially for a couple of weeks, sw=bypass was working fine but later that stopped as well.
Our webpart gets modified every sprint and a new version gets deployed every two weeks removing the older one. But the issue was still there.
Our app customizer didn't have any enhancement for a long time. So, the version stayed same. However, in our latest sprint, we have decommissioned our app customizer fully. But we will keep on monitoring in case the webpart is still giving the same issue of caching the throttle page.

Hello, just wanted to briefly chime in and mention that myself and other seemingly random users are experiencing the same issue with our application customizers. Unfortunately, when it occurs it causes major issues with our custom applications. Should I start working on a new application customizer limited to loading JS in hopes that this issue is resolved, try updating our applications to TS / PNPJS, or continue promoting the sw=bypass workaround? (Although, I'm not sure how much longer I can get away with using that.) Thanks in advance for all of your hard work and suggestions!!

Thank you for your prompt response. I apologize for the delay in mine. Here is the information that your requested.

Deployment Details
(PS: I only have Site Collection Admin to our two Site Collections. I also have no control over or input on our current nested legacy subsite based structure  or anything Tenant scoped.... )

Not Tenant Wide
Site Collection Scoped App Catalog ( connected to 1 of 2 site collections)
On a Co-Tenancy  (we only have two site collections on the tenant)
Located on GCC

-SW=Bypass Does resolve the issue

Only occurs on almost every page on the site collection where the application customizer is deployed
No CDN
Only occurs in edge which is the browser that I was using when our site was throttled. Does not occur in chrome which is a shame because I actually do prefer edge.

THIS IS REALLY TELLING:  Through dev tools I can see that  ..../ClientSideAssets/e4cd6dee-9f89-4876-8f1a-b0a827be738f/spfx-add-js-css-ref-referenceinjectorapplicationcustomizerstrings_en-us_3336c32f1c81977fda2fc3129e0454f2.js  is being returning the below...... (Also have to mention that since the original incident that occurred over a month ago, we have not been throttled.)
`

`
However, if I browse to the file in the clientsideassets folder within SharePoint and download the file to view it, everything looks perfect. So this issue is definitely another instance of  Issue#8474.  And from the above comments it sounds like it was just bad luck that throttling occurred as the manifest was caching.
Any suggestions, solutions, or guidance would be greatly appreciated!
Thanks!

@AJIXuMuK @Get-SPadmin While throttled responses are no longer cached, it seems we don't reevaluate the validation of the content type matching the requested content type before serving the file, for cases where a throttle response was cached before our recent changes were introduced.
We only handled Cache-Control: max-age and treating the absence of Cache-Control as not cacheable instead of indefinitely cacheable - we might still be missing a change to reevaluate the content type of the request matching the content type of the response.
We will work on a change to address this scenario, and will update this thread shortly.

@demyren @AJIXuMuK any updates on the above issue?

Hi @demyren,
Thanks for your update. I am afraid we are still experiencing the same throttling-related issue in some of our Office 365 tenants as described above. I am not sure if the change has been rolled out to all tenants etc.
We have opened a support ticket with Microsoft to investigate this.

@ejazhussain I see, I'm sorry that you are still experiencing issues. Does this seem to be an issue that only reproduces with the service worker enabled? Are you able to find one of the affected request URLs in any of the cache storages (F12->Application->Cache Storage) named "Site-[id]"? There, is it cached as HTML still, and what is the time stamp of that cache entry? We have addressed the issue so I'm trying to understand what might be going wrong at this time.
All your clients should have the required changes already. The only case where they may not have them, is if they are returning to SharePoint for the first time in a long time (since some time before the change was introduced) - then, they may need to install the new worker version before the changes take effect. That seems unlikely, though.
I hope we can determine the root cause of your reported issues asap, so that you can deliver your application customizer to your customers reliably.

@demyren as this issue is happening sporadically and is hard to replicate. We are trying to capture the affected use case to investigate further. I will update you as soon as I get some more information about the issue.

hi @ejazhussain @demyren we have a field customizer built with 1.13 that is sporadically failing to render in list views (both views and list view web parts). The F12 console shows an info message for splistwebpack.js  - "Fail to load customizer for column". Navigating away from the site/page and back sometimes fixes the issue, so we know the customizer basically works . Any advice?

@wizneeraj - is this still an issue on your side?


Doesn't work in the latest version of electron (v.26)

Description
Menu bar icon is not displayed at all.
Steps to Reproduce the Problem
Repo with reproduction: https://github.com/eden-lane/my-electron-app
Expected Behaviour
Actual Behaviour
Specifications

Menubar version: 9.3.0
Platform: Mac M2
Electron version: 26.0.0

Sorry, my mac notch hid the icon......................


Added composer.json and .gitignore files to the repo

@alexanderdean, can anyone do this merge? :)

Bumping - this is a trivial PR to approve, and needed for virtually any modern use of this repo.
It's been two years, can someone merge?

Included this PR in our fork: https://github.com/procurios/php-referer-parser


Deploy with Azure option fails because 201-vm-win-vnet-sql-tools template does not exist any longer

The Deploy with Azure feature in the article connect-vm-instance-configure does not work because the template 201-vm-win-vnet-sql-tools does not exist in the https://github.com/Azure/azure-quickstart-templates repo.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d737a38a-5097-b886-05a7-ec614118d97a
Version Independent ID: 3124d90b-6f96-4856-447f-97c421d969f5
Content: Configure Azure VM connectivity - Azure SQL Managed Instance
Content Source: articles/azure-sql/managed-instance/connect-vm-instance-configure.md
Service: sql-managed-instance
Sub-service: operations
GitHub Login: @jovanpop-msft
Microsoft Alias: jovanpop

@jeramyRR Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@srdan-bozovic-msft could you take a look at this?

@srdan-bozovic-msft could you take a look at this?


tiering feature for iput

hi @trel ,
I tried different way to use the tiering plugin.
but I found that the function only work with "iget" (to trigger the rule working)
If I want it to work with "iput" when I want to overwrite the same file in some kind of slow tier.
What can I do? or what should I configure?
Thank you

step1:
iget my_test_file
then in other terminal I can see the queue show that my test file is moving to the tier0
670188 {"delay_conditions":"<INST_NAME>irods_rule_engine_plugin-unified_storage_tiering-instance</INST_NAME>irods::storage_tiering::maximum_delay_time_in_seconds24s
","destination-resource":"st_ufs0","group-name":"example_group","md5":"dadd4831ede77bd66ffacbc01cea3609","object-path":"/QCTZone/home/chao/tiering.r","preserve-rep
licas":false,"rule-engine-instance-name":"irods_rule_engine_plugin-unified_storage_tiering-instance","rule-engine-operation":"irods_policy_data_movement","source-replica-nu
mber":"14","source-resource":"st_ufs2","user-name":"chao","verification-type":"catalog"}

step2 :
after I wait the test file move to the tier2 by tiering plugin
iput -f my_test_file my_test_file
but nothing show in the queue.
Every 3.0s: iqstat                                                                                irods01.openlab: Wed Apr 12 12:09:32 2023
No delayed rules pending for user chao
after the two steps , I tried to check the metadata of the test file.
"iget" didn't change the access_time, but "iput" did.
Thank you

Hi @trel ,
Is there any way that we can trigger the "tiering" with "iput"?
Thank you.

Is there any way that we can trigger the "tiering" with "iput"?

Hmmm.... Not really.
Tiering 'out' happens due to the 'violating query' finding things to enqueue for movement. This query runs regularly in the background under normal configurations.
Restaging happens due to the 'get' request.

so if I want to make "iput" do the same thing (like overwrite) what can I config?
Thank you

I believe an iput -f will select a replica (based on voting) and overwrite it.   That should happen regardless of how tiering is configured.   You could specify the particular replica you want to overwrite with an additional -R option.
I'm still not quite sure what you want/expect to happen.  Restaging on an iput doesn't yet make sense to me.

I just expect that when I "iput" with no flags, it will write to the tier 0 ( I mean during the overwrite)
Thank you.

Oh, I see.
No - from the client, you are writing to the 'logical data object' rather than targeting a particular physical device.
So if it happens to be an overwrite of an existing logical data object, the system will need to overwrite a particular physical instantiation of that object, known as a replica - which could be on any storage resource (in a tier or otherwise).
There may be a way to get the behavior you seek, perhaps with a pre-PEP, but it may be too heavyweight/slow to meet your expectations as it would have to do more bookkeeping in the catalog (and/or data movement) to keep things consistent.

I see, em......

Hi @trel
another problem is, is there any other attribute, that we can use as the condition, not just "irods::access_time".
And why "using iput to overwite a data" isn''t a "accessing data". ( due to the access time didn''t change)
Thank you.


Original game textures not loading when launching GD

I disabled all texture packs, but when I launch the game I still have to go to the TextureLdr menu and click "Apply" so the game loads the original textures.

Actually it only happens the first time, maybe it's some cache thing. Gonna close since it's not really a bug


bug fix: only support enabled key value

Coverage increased (+0.05%) to 55.933% when pulling 3e66a855b8dad93fc0cf8cae7dbbf7433d826b3a on tianxiaoliang:master into 49af0581102f1e6c9d4c61c13a136f68bbf5f78b on go-chassis:master.


Add something like type and hack properties to PostCSS warnings

Re: https://github.com/stylelint/stylelint/pull/795/files#r53577881. To consume this module in stylelint I'd like to know for each warning the type of hack it is and the string of the hack itself. Right now (in the linked PR), I'm doing that by parsing the warning's text. Ideally I would be able to find that information in the PostCSS warning, as additional properties.
Does this seem like a reasonable idea to you?

Like this for example?
{
  message: 'Bad property: _color',
  type: 'property',
  hack: '_color'
}

That's all I would need.

Is the only other information that could be added extra info about the hack, like which browsers it applies to? And I guess you could include the browsers that were specified. But that seems like it might be overkill.

We could expose this data; https://github.com/ben-eb/stylehacks/blob/master/src/plugins/bodyEmpty.js#L7
Any other data that isn't in the files already would have to be sourced from elsewhere, I don't really have the time to add this but pull requests for this (and missing hacks) are welcome. :smiley:


Fix broken link to test suite in README

Sorry for the delay in seeing this PR;

No worries, my experience as a maintainer is that 3 days is a rather decent response time. ;)


Is it possible to call a function whenever the SheetState is changed?

Is there any way or plan to integrate the possibility of calling a function whenever the sheet state is changed?
onSheetBottom, onSheetTop, onSheetDocked
Ex)
<ion-bottom-sheet
[(state)]="sheetState"
[onSheetBottom]="someFunction($event)"

Yes of course. Use sheetState Event as:
<ion-bottom-sheet (sheetState)="myFunction()">

Yes of course. Use stateChange Event.
For example:
<ion-bottom-sheet
(stateChange)="onStateChange($state)"

Event is fired only in children component


webview [nfc]: Remove contentious comment; isolate its subject

Having this comment block in place has already cost us more time and
effort than it could ever reasonably save. It is a fractal can of
worms. Remove all attempts at explanation from it.
Since it's been firmly established to be useless for all other
purposes, move the value to its use-site, instead of placing it near
the top of the file where it's more likely to distract people.

Hi @ray-kraesig! Coming back to this PR now after a while, because Chris mentioned the contemporaneous #3686 over at https://github.com/zulip/zulip-mobile/pull/3866#issuecomment-582316854 .
I agree that we spent a lot of time investigating the subject matter this comment is about, more time than the value the information has for us. But: at this point we have spent that time, and I think the information does have real value. So I'd like to keep our results from that investigation around for handy reference, even though ex ante the best use of time would have been to do less.
(Specifically, I think the right strategy would have been to take only the information we'd already learned in order to write this code, and serialize that into a less-detailed comment that stopped there and just clearly marked the boundary of what we knew.)
For that reason, I'm going to close this PR and merge #3686, which writes up what we learned in the last phase of our research into this area. That'll be a return here to our normal practice for docs and comments of editing them more wiki-style than we edit code, pushing changes before review. If you find there's something in the resulting version that you don't think is right (and it isn't something with an obvious fix, like a typo), then I agree I want to handle that without doing additional investigation -- but we can mark the uncertainty rather than deleting the information.

move the value to its use-site, instead of placing it near
the top of the file where it's more likely to distract people.

Yeah, I agree this belongs next to its use-site. But I think actually that use-site itself is somewhat distracting in its current location -- in the last week or two when reading PRs in this file MessageList.js, I realized that the whole chunk of logic with baseUrl and onShouldStartLoadWithRequest (which contains a lot of detail) is pretty much independent of the other work that MessageList is doing, and had the thought that it'd be helpful if those were pulled out to their own spot outside that React component's definition. Maybe I'll try making that rearrangement.


updating go version in ado to 1.22

What type of PR is this?
Task, updating go version.
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
https://issues.redhat.com/browse/MTSRE-1923?filter=-1
Special notes for your reviewer:
passed test-integration-local testing
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Ran make go-test command locally to run all the unit tests and mock tests locally.
[ ] Included documentation changes with PR

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.44%. Comparing base (349bcff) to head (606a734).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   59.44%   59.44%
=======================================
  Files          62       62
  Lines        4098     4098
=======================================
  Hits         2436     2436
  Misses       1514     1514
  Partials      148      148

@ashishmax31 Please review.

/lgtm


Produce strongly typed struct as sync result

Prior to this, the rather predictable data was returned as a JSON object, which made programmatic extraction uncertain to succeed and runtime and largely undocumented. With this, a caller gets a struct with predictable fields.

What is this format check that's failing? It shows diffs, but it doesn't call out what's wrong.


Contact Info - Optional Phone Prop

Issue #: /bcgov/entity#10687
Description of changes:

Prop to allow optional phone number rules & label as per evolving requirements.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Do you have a new story or test case for this new option?
Also, I wonder if there's a way in GH to delete all previous versions of a file? I'm thinking we don't need to keep any of the Storybook files before the current one.

For sure, will add another story.
Being that it's a prop, it can also be toggled in any of the existing stories as well, a nice feature :)

Also, I wonder if there's a way in GH to delete all previous versions of a file? I'm thinking we don't need to keep any of the Storybook files before the current one.

I found this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-files-from-a-repositorys-history and this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-a-file-that-was-added-in-an-earlier-commit
Next time one of us is working in this repo, we should remove all the old versions of the docs folder.

I didn't even notice this before, thanks!


Enhance cleos to enable new RPC send_transaction

Change Description

With regard to issue #7536, enhance cleos so as to enable send_transaction, an RPC newly introduced in  EOSIO v1.8.
Changes are made to programs/cleos/main.cpp and programs/cleos/httpc.hpp.
Background

For versions v1.8 or after, both RPC send_transaction and push_transaction are supported.
For versions before v1.8, only RPC push_transaction is supported.
RPC send_transaction and push_transaction are almost the same, except the traces they return, which can be viewed in JSON format by adding a -j option in the command calling them.

Flow Control

Users can enforce always using old RPC push_transaction by adding a flag --use-old-rpc.
Otherwise, which RPC will be called depends on the current nodeos version:

If the nodeos version is between v1.0 and v1.7, call old RPC push_transaction;
Otherwise, call new RPC send_transaction.

Test
Have tested behavior such as create account, issue and transfer for nodeos version v1.8.0 and version v1.7.4.
Sidenote
In programs/cleos/main.cpp there is a void send_transaction(...) function, which, according to @arhag in issue #7536, is simply unrelated to this topic. Just ignore it.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

I have modified the code adopting @arhag 's suggestion. Now the new flow is
Flow

Users can enforce using old RPC push_transaction by adding a flag --use-old-rpc.
Otherwise, without such a flag, cleos will always call the new RPC send_transaction.

If it happens that the call to send_transaction fails, an error message will be printed out, saying that the new RPC may not be supported, and suggesting the user add the flag --use-old-rpc to call push_transaction instead.


Information about how to use Azure Hybrid Benefit is out of date

Information provided in this documentation about how to use Azure Hybrid Benefit appears to be out of date. I could not see any option on Basics tab to save money or something like that.
I then create a sample DB and went to Settings -> Configure and other options in Settings tab, but there is no way to use AHB.
I think this documentation needs a correction.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00f3b642-1d0d-363b-ed6e-a52dd93090e6
Version Independent ID: 5f3d7946-3455-650e-d21b-c2601495e876
Content: Azure Hybrid Benefit - Azure SQL Database & SQL Managed Instance
Content Source: articles/azure-sql/azure-hybrid-benefit.md
Service: sql-db-mi
Sub-service: features
GitHub Login: @stevestein
Microsoft Alias: sstein

@amneshgoel7 Thanks for the feedback. AHB is applicable only on vCore-based purchasing model and not on DTU based. Hence we don't see the Save Money option on Basic, Standard and Premium for DTU based purchasing model.
However, as rightly pointed out by you, documents has to be updated where in instead of Basic tab, appropriate tab should come.
This is being assigned to the content author to evaluate and update as appropriate.

@amneshgoel7 - thanks for the feedback.
In the first sentence of the article it says: In the provisioned compute tier of the vCore-based purchasing model...
During creation there is a Basics tab as shown below:
For new databases, during creation, select Configure database on the Basics tab and select the option to save money.

While I understand this might be easy to confuse with a Basic database, the article is correct.
Thanks
#please-close


SchemaObject should allow boolean for additionalProperties

Shouldn't additionalProperties be allowed to be boolean.
https://github.com/IBM/openapi-to-graphql/blob/17a5b2dd9f5b9c90703216fa8c18bb82c4f09372/packages/openapi-to-graphql/src/types/oas3.ts#L29
Specification states:

additionalProperties - Value can be boolean or object. Inline or referenced schema MUST be of a Schema Object and not a standard JSON Schema. Consistent with JSON Schema, additionalProperties defaults to true.
https://swagger.io/specification/#schema-object

@FallingSnow Thank you so much for reporting this! I was able to fix this issue in 50aeb89d709f8ef97de3b213430f13c93e164875. I think for the future, we should consider using a module that can provide the typings for us (see #348).


Cannot find module puppeteer

Hi @harlan-zw 👋
As you can see in the image unlighthouse never picks puppeteer, even though it is installed globally. I'm using nvm and the path would be /Users/tragio/.nvm/versions/node/v14.19.1/lib/node_modules/ and not file:///Users/tragio, file:///Users/tragio/node_modules as stated in the error message 🤔 I wonder if the error is related to that.

Thank you for your amazing work 🙏

Same here

Hey @Tragio, @zuramai, sorry you had issues with the package.
I've made a binary that depends on puppeteer to try to get around this issue. Could someone try the below:
Using pnpm
pnpm dlx unlighthouse --site <your-site>
# or if that doesn't work try:
# pnpm dlx unlighthouse-puppeteer --site example.com

Using npx
npx unlighthouse --site <your-site>
# or if that doesn't work try:
# npx unlighthouse-puppeteer --site example.com

@harlan-zw I tried to use but still had the same error Failed to find a chrome / chromium binary to run. Add the puppeteer dependency to your project to resolve. Error: Cannot find module puppeteer imported from file:///Users/tragio, file:///Users/tragio/node_modules

Hi,
I'm getting the very same error even after trying these alternatives

@harlan-zw does this help?

This might be caused by a different channel of Chrome being installed, so puppeteer cannot find it.
In my case, I have Chrome Dev installed.
I fixed the issue by defining the path to the Chrome executable in the unlighthouse config (your Chrome path may be different to this):
export default {
	puppeteerOptions: {
		executablePath: "C:\\Program Files (x86)\\Google\\Chrome Dev\\Application\\chrome.exe"
	}
}

I've run into this problem on similar projects, so I've opened a PR on the chrome-launcher library to add detection for Beta and Dev channels.

Make sure that you have Chrome installed and then in the same path you trigger the npx unlighthouse, do what @LachlanArthur has done.
It has worked for me


Slack application?

Hey there,
great job with Carbon -- I love it.
Are there any ideas about building a Slack app/extension?
I was thinking about something like: /carbon <code> <lang [optional]> <theme [optional]> to create images on the fly and post it into the conversation. (Similar to the giphy app.)
Is the Carbon API free to use? I didn't find anything in the docs.
If you guys are interested, I would totally like to contribute.
Thanks and have a great day,
Ronald

Issues marked "Integrations" are being closed and theirs discussions moved to https://github.com/dawnlabs/carbon/issues/358. With many requests for new features, this allows the Carbon team to prioritize which to support first 👍

We currently do not have a public Carbon API, and therefore unfortunately do not have docs for it.

Hi,
I created a slackbot which enables you to use carbon in slack!
here's the source: https://github.com/faisalsayed10/carbon-slack/
you can self-host it by adding your own slackbot credentials!

Neat! @faisalsayed10 Feel free to submit a PR to add this bot to the "Community" section of our README

While I'm here, just for clarity: if you paste a saved Carbon snippet in Slack, the Carbon image will automatically unfurl inline with a link back to your snippet. Just in case people come here in the future looking for this Slack feature.


Unable to create release from CircleCI

CircleCI is not able to push a release to GitHub as part of the semantic-release process. The GITHUB_TOKEN variable for ohif-bot seems to be invalid since this project was last published in November.
https://app.circleci.com/pipelines/github/cornerstonejs/cornerstone-nifti-image-loader/70/workflows/7fbb10d3-a2aa-4455-b3c2-449de28d07f6/jobs/60
@dannyrb can we get a new token set in https://app.circleci.com/settings/project/github/cornerstonejs/cornerstone-nifti-image-loader/environment-variables, if that is indeed the issue?

Sorry for the issue, it's my fault. I nuked the token due to the CircleCI
breach this morning:
https://circleci.com/blog/january-4-2023-security-alert/
@sedghi can update it I think
On Thu., Jan. 5, 2023, 16:43 Jody Zeitler, @.***> wrote:

CircleCI is not able to push a release to GitHub as part of the
semantic-release process. The GITHUB_TOKEN variable for ohif-bot seems to
be invalid since this project was last published in November.
https://app.circleci.com/pipelines/github/cornerstonejs/cornerstone-nifti-image-loader/70/workflows/7fbb10d3-a2aa-4455-b3c2-449de28d07f6/jobs/60
@dannyrb https://github.com/dannyrb can we get a new token set in
https://app.circleci.com/settings/project/github/cornerstonejs/cornerstone-nifti-image-loader/environment-variables,
if that is indeed the issue?
—
Reply to this email directly, view it on GitHub
https://github.com/cornerstonejs/cornerstone-nifti-image-loader/issues/59,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEUMMIPPSCEDFBD7SOWHW3WQ3TYZANCNFSM6AAAAAATSC4724
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I guess you are good now

Thanks!


Allow usage of internal docker subnet IP

The context for this proposed change is, that I want to be able to use internal docker IP addresses instead of the public ones. I am running the jupyterhub server (as docker container) and the user containers on the same docker engine which is enough for smaller scenarios without a swarm. If I use the code as it is the public ip/port  of the spawned user container is used (localhost and random unprivileged port). These changes add the possibility to use the internal IP instead and (since it is not required in that case) do not expose a port to the outside.

+1 from me. @ssanderson, @jhamrick?

I realised one little issue with my code. It only works if the docker containers are in the default network (which is called bridge), otherwise NetworkSettings.IPAddress is not set. This happens if you add a new network with docker network create and add network_mode=<network_name> to extra_start_kwargs. I would propose fixing that in a second pull request after this one is merged (assuming it will be merged).
I think the cleanest way of dealing with that is adding another config option specifying the network the internal ip address should be taken from (defaulting to bridge). Then the NetworkSettings.Networks.<name>.IPAddress property can be used.
Let me know if you prefer pushing the necessary changes here or in another pull request.

:+1: from me (though I haven't tested this manually).
It sounds fine for the other changes regarding the network to go in a separate pull request. Thanks!

Hi just wanted to follow up on this. As mentioned in my earlier comment, Docker can reassign internal IPs which is why the IP address should be loaded on every spawn. Using a dynamically populated traitlet could cause errors. Is there anything else to be done on this pull request?

Nope, I think we are good. Thanks, @andreaslang!


bug反馈测试

Version of js-screen-shot
1.0.0
Operating system and its version
MacOS
Browser and its version
No response
Sandbox to reproduce
No response
What happened?
反馈测试
报错信息
No response

Hello @MagicalProgrammer. Your feedback has been received, and you will be notified in the issue area when the problem is resolved.
你好 @MagicalProgrammer，已收到你反馈的问题，问题解决后将在issue区域通知你。


XCODE 8 - SWIFT 3

The project dont work when using xcode 8. Xcode wants the project in swift 3 after convert it dont build and complains about many things...

Did you resolve it?

Hi shogo4405! :-)

Sadly no... :( still does not work... it will also be better without pods. Pods always have problems in them... please consider it.

CocoaPods is difficult X( My solution is here.
Migration XCode7 to XCode8

Created a new project by Xcode7 (Swift 2.3)
Podfile is

platform :ios, ‘8.0’

target 'Test' do
 use_frameworks!
 pod 'lf', '~> 0.5.0'
end

installer.pods_project.targets.each do |target|
 target.build_configurations.each do |config|
    config.build_settings['SWIFT_VERSION'] = '3.0'
  end
end

pod update
Open the project by XCode8
Migration Swift 2.3 to 3.0

New Project

Create a new project by Xcode8.
Podfile is

platform :ios, ‘8.0’

target 'Test' do
 use_frameworks!

 pod 'lf', '~> 0.5.0'

end

pod update

How about your case?

frameworks supports Carthage :)
Please consider to use Carthage.


Fix description for LivePeriod property in InlineQueryResultLocation class

https://github.com/TelegramBots/Telegram.Bot/blob/16facadc1c27eaf23ffe8edcdb80382ea037648e/src/Telegram.Bot/Types/InlineQueryResults/InlineQueryResultLocation.cs#L32-L36
Summary for LivePeriod should be
        /// <summary>
        /// Period in seconds for which the location can be updated, should be between 60 and 86400.
        /// </summary>

@karb0f0s Make a PR instead please


Anchor not working on props tabs

Description
When I click on

On props tab, nothing happen except that the hash is added to the route. We don't change to go to usage

Expected behavior : fallback to usage tab with right anchor and scroll to it.

Related to: https://github.com/chakra-ui/chakra-ui-docs/issues/817

This issue will be resolved with the docs rework we are currently working on.

Since this is related to #817, I will close this issue and it will be resolved under 817, thank you for reporting the issue! 💖


Add 404 responses to the valid responses where you look up by task id or step id

Is your feature request related to a problem? Please describe.
The spec is incomplete on the defined behavior of what occurs when you request a task ID that doesn't exist. This is problematic as when not defined its indistinguishable from a 500 error which should have different behavior client side.
Describe the solution you'd like
I'd like 404 messages to be added as a documented response code for this case.
Describe alternatives you've considered
We can also not document it, but going forward you could expect people to use 500 in this case which shouldn't be used as there should be no errors that occur when this happens
Additional context
Add any other context or screenshots about the feature request here.

Hi @ntindle, thanks for your input. It makes sense! I'll address this one soon. I'll tag you in the PR

Added in https://github.com/e2b-dev/agent-protocol/pull/31

Added in https://github.com/e2b-dev/agent-protocol/pull/31


Layout V2

A new pitch for a layout.
The new version differentiates between different controls. You can now use the layout for e.g. sap.m.Table or sap.ui.Table or build additional controls.  The layout is initialized with the method init_layout. In order to be able to save layouts as flexibly as possible for your needs, there are 4 freely definable trades for which the layout can be saved.  E.g. Handle01 - class name of the current class
Handle02 table name
Handle03 warehouse number
...
The layout functions can simply be hooked into the XML via the render_layout_function method and all user commands can be handled via the on_event_layout method.
Check out sample 200 :)

thank you!


RadioListTile Theme Property for selected

When using RadioListTile it uses a radio Button. But activeColor property doc for this widget says uses the Theme accentColor property by default. Which I think is true.
But if you use controlAffinity property of RadioListTile to put radio button to right side, then the color of the selected item in the list follows the RadioButton activeColor property which defaults to the theme toggleableActiveColor property.
Expected behaviour, both widgets RadioListTile and RadioButton to use the same consistent theme property when no color is provided.

Hello @workerbee22 !
Thank you for posting an issue.
Can you please also provide the flutter doctor -v output?

flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G103, locale en-AU)
    • Flutter version 1.9.1+hotfix.4 at /Users/gamma/Documents/flutter
    • Framework revision cc949a8e8b (2 weeks ago), 2019-09-27 15:04:59 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/gamma/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/gamma/Library/Android/sdk
    • Java binary at: /Applications/Android Studio 3.5 Preview.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio 3.5 Preview.app/Contents
    • Flutter plugin version 40.1.2
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.39.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.5.1

[✓] Connected device (2 available)
    • Nexus 6P                  • CVH7N15A17000241 • android-arm64 • Android 8.1.0 (API 27)
    • Android SDK built for x86 • emulator-5554    • android-x86   • Android 10 (API 29) (emulator)

• No issues found!
gamma (master *) flutterio_2018 $

When using RadioListTile it uses a radio Button. But activeColor property doc for this widget says uses the Theme accentColor property by default. Which I think is true.

The doc surely mentions that the activeColor defaults to Theme.accentColor  which is not true, since only ListTileTheme.selectedColor is defaulted to the Theme.accentColor but activeColor for the Radio is never defaulted to Theme.accentColor.
https://github.com/flutter/flutter/blob/b041144f833e05cf463b8887fa12efdec9493488/packages/flutter/lib/src/material/radio_list_tile.dart#L436
https://github.com/flutter/flutter/blob/b041144f833e05cf463b8887fa12efdec9493488/packages/flutter/lib/src/material/radio_list_tile.dart#L419

But if you use controlAffinity property of RadioListTile to put radio button to right side, then the color of the selected item in the list follows the RadioButton activeColor property which defaults to the theme toggleableActiveColor property.

Going through the source code, the controlAffinity won't matter here to change the activeColor, since the ListTileTheme.selectedColor doesn't apply on Radio.
The issue has reproducibile steps here.
SS

@shihaohong I would like to work on this issue, can we make the activeColor default to Theme.accentColor when creatingn a Radio since the doc mentions, activeColor defaults to accent color of the current Theme ?

Based on the name of the properties, I would imagine that toggleableActiveColor would make the most sense as the default. Also, it sounds like this will likely be a breaking change, so it might be worth familiarizing yourself with the policy.
@HansMuller might know more about the history of the different color parameters and which one we should really default to or if we should just keep it as-is and update the API docs.

@shihaohong Sure, till then I'll go through the breaking change policy.

@shihaohong should I create a design document for proposing the change, or wait for the take from @HansMuller on the solution?

Sorry about the delay, I'll review this today!

I'm going to assign Hans for now just so that there is a reminder for him to provide some feedback when his week starts

@shihaohong OK, that worked :-).
This issue depends on the theme's accent color, which is becoming obsolete: https://docs.google.com/document/d/1kzIOQN4QYfVsc5lMZgy_A-FWGXBAJBMySGqZqsJytcE/edit#heading=h.2hl3s1i2nq6o
RadioButton and RadioListTile currently do not conform to the patterns described in the "Theme System Updates" document - flutter.dev/go/material-theme-system-updates. Migrating them will require breaking changes, as Shi Hao pointed out, and will likely require us to update test repo and internal applications. So although this fixing this issue might seem straightforward on the surface, it's likely to be difficult.

From Hans' outline, it seems like it will be a multi-step breaking change that would also require a Googler to fix issues that surface in internal applications. That being said, I see two options:

Go through the breaking change process and update RadioListTile to properly use toggleableActiveColor over accentColor, which would reduce some strain on the bigger breaking change. This would require a Googler to be involved since internal repos would need to be fixed to conform to the breaking change.
Make this fix as part of the wider theme updates mentioned in flutter.dev/go/material-theme-system-updates, which would be a larger-scale breaking change.

I know since this won't priority but if the team decides to go with the first option in the future, I'll be more than happy to contribute if any external contribution required :)

Hi @workerbee22
There are changes in the usage of theme colors for accentColor and toggleableActiveColor:

https://github.com/flutter/flutter/blob/e6300da2c39ff230d943eeccb80ba3ccfa1e3759/packages/flutter/lib/src/material/theme_data.dart#L372-L378

https://github.com/flutter/flutter/blob/e6300da2c39ff230d943eeccb80ba3ccfa1e3759/packages/flutter/lib/src/material/theme_data.dart#L420-L426

Also, when using controlAffinity, RadioListTile keeps using color that is defined in ThemeData, please see in demo and sample code below:

Demo

Sample code
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Application';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      theme: ThemeData(
        accentColor: Colors.red,
        toggleableActiveColor: Colors.green,
        colorScheme: const ColorScheme.light(secondary: Colors.yellow),
      ),
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const MyStatefulWidget(),
      ),
    );
  }
}

/// stateful widget that the main application instantiates
class MyStatefulWidget extends StatefulWidget {
  const MyStatefulWidget({Key? key}) : super(key: key);

  @override
  State<MyStatefulWidget> createState() => _MyStatefulWidgetState();
}

enum Fruit { apple, banana }

/// private State class that goes with MyStatefulWidget
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  Fruit? _fruit = Fruit.apple;

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        children: <Widget>[
          RadioListTile<Fruit>(
            // activeColor: Colors.red,
            controlAffinity: ListTileControlAffinity.trailing,
            title: const Text('Apple'),
            value: Fruit.apple,
            groupValue: _fruit,
            onChanged: (Fruit? value) {
              setState(() {
                _fruit = value;
              });
            },
          ),
          RadioListTile<Fruit>(
            // activeColor: Colors.red,
            title: const Text('Banana'),
            value: Fruit.banana,
            groupValue: _fruit,
            onChanged: (Fruit? value) {
              setState(() {
                _fruit = value;
              });
            },
          ),
        ],
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.7, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e99c9c7cd9 (27 hours ago), 2022-11-01 16:59:00 -0700
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.5.0-12.0.pre.93, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.5.0-12.0.pre.93 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 92a66683a1 (6 hours ago), 2022-11-02 16:50:38 -0400
    • Engine revision 840a7b3462
    • Dart version 2.19.0 (build 2.19.0-364.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Please retry and confirm again. Thanks!


HHH-15134 Version attribute not loaded even if not marked as lazy

Issue: HHH-15134

Thnak @BlackTazz89 for the PR, I'm closing this in favour of https://github.com/hibernate/hibernate-orm/pull/5019 where I just made few changes to the test


Scaffold Application Server

We'll need to scaffold out an initial application server. Let's list/discuss the MVP specs here.
Routes
Frontend Static assets

GET /
Serves the assets (JS, HTML, CSS, etc) to run the frontend application

REST endpoints [TODO]

Routes: [GET, POST, PUT, DELETE] /api/:apiVersion/:resource
Any necessary CRUD operations

Creating a new Jam Session
TODO more resources

Websocket services

GET ws://[appRoot]/ws

Jam Session MIDI communication

GET /ws/jam/:sessionId
This endpoint is used for transmitting MIDI and other Jam Session-specific messages between musicians

WebRTC Signalling Service

GET /ws/signal/:sessionId
This service handles signaling to initialize WebRTC connections between peers in a specific Jam Session

looking at the scaffold branch, there is quite a lot of things going on, do we have a place that explains the decisions made and some of the files used? Just so its easier on people that are new or less experience with such tech

@adoublef those files are just some boilerplate code for the server. No worries I'll add some comments to describe the process better. It doesn't have anything to do with the main goal of the project.
And also don't mind the files inside ent folder. It's just a user database schema with some info about the user. Like email username and role.
It'll be used for authentication process and user sign up.

As well documenting how the schema was generated. The ent directory seem to be all auto-gen files so knowing where those started from makes it clearer as to why that package was chosen

For v0.0.1 I would propose to keep it extremely minimalistic:

no sessions (just one big session)
no database or users
a /-route that serves as a kind of admin-page (showing all current connections and latencies) and with a JOIN-button that points to /jscli, hence this is also some kind of client but more focused on the overview
a /jscli-route that serves a minimal browser-client where users can do something musical
a /ws-route for our own rapidmidiex-ws-protocol

Thus only a websocket-based protocol v0.0.1 which can be upgraded later.
I wouldn't spend too much time on MIDI-compatibility for v0.0.1. Just a simple noteOn/noteOff in a json-websocket-text-message and some ping/pong (or similar) for latency-measurement. So a very minimal rapidmidiex-ws-protocol v0.0.1.
And maybe a few more different v0.0.1-clients as well.
┌─────────────────────┐
│                     │
│ rapidmidiex-tuicli  │
│       v0.0.1        │───────┐
│                     │       │
└─────────────────────┘       │
┌─────────────────────┐       │
│                     │       │
│ rapidmidiex-testcli │       │
│       v0.0.1        ├───────┤
│                     │       │
└─────────────────────┘       │        ┌──────────────────────────┐          ┌───────────────────┐
┌─────────────────────┐       │        │                          │          │                   │
│                     │       ├───────▶│ rapidmidiex-ws-protocol  │─────────▶│  rapidmidiex-srv  │
│  rapidmidiex-jscli  │       │        │          v0.0.1          │          │      v0.0.1       │
│       v0.0.1        │───────┤        │                          │          │                   │
│                     │       │        └──────────────────────────┘          └───────────────────┘
└─────────────────────┘       │
┌─────────────────────┐       │
│                     │       │
│ rapidmidiex-elmcli  │       │
│       v0.0.1        │───────┘
│                     │
└─────────────────────┘

I presume admin page is only for us right?

For v0.0.1 I wouldn't bother with a real admin-page (that can kick clients or whatever functionality that is supposed to have?). Just a general free-for-all-overview-start-page with some buttons for the different clients than can be used. And it would be nice to see who already connected with what client and what latency.

ah that makes sense, could you explain what tui and elm are for? I presume terminal and Elm respectively right?

For v0.0.1 I would propose to add as many client's as people want to work on. If a client is not ready, it can be moved to the next release?


:ambulance: corrected work with pricelist in pos_product_available

There was an error in https://github.com/odoo/odoo/blame/12.0/addons/point_of_sale/static/src/js/models.js#L1282.
So, with pos_product_available it doesnt work correctly, cause
item.product_tmpl_id || item.product_tmpl_id[0] === self.product_tmpl_id in this string are comparing integer with an array. By the way, here's comparing products ids.
Signed-off-by: Vildan Safin<EMAIL_ADDRESS>

solved https://github.com/itpp-labs/pos-addons/issues/1244 & https://github.com/itpp-labs/pos-addons/issues/1245

@Enigma228322 пришлешь исправления по замечаниям?
https://github.com/itpp-labs/pos-addons/pull/1253#pullrequestreview-418024260

И это https://github.com/itpp-labs/pos-addons/pull/1253#discussion_r430209780

I approve to merge

I approve to merge it now


ListDatabases

Test Plan

[ ] acceptance tests

[ ] …

References

Codecov Report

Merging #205 into master will decrease coverage by 0.02%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   65.99%   65.96%   -0.03%
==========================================
  Files          50       50
  Lines        3664     3676      +12
==========================================
+ Hits         2418     2425       +7
- Misses        922      925       +3
- Partials      324      326       +2

Impacted Files
Coverage Δ

pkg/snowflake/database.go
72.72% <58.33%> (-8.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb850c...f4d50cc. Read the comment docs.


[QA] Scenes disappear when approached

Explorer Alpha build versions:

v0.14.0

Issue Description:
In DCLWW, several scenes are not rendering correctly. These scenes are visible from a distance but disappear as the player approaches them. Some of the affected scenes include:

Scene at coordinates (53, -55)
Scene at coordinates (53, -70)
Scene at coordinates (53, 56)

STR:

Launch the explorer.
Navigate to coordinates (53, -55).
Observe the scene from a distance.
Approach the scene and observe the rendering behavior.
Navigate to coordinates (53, -70).
Observe the scene from a distance.
Approach the scene and observe the rendering behavior.
Navigate to coordinates (53, 56).
Observe the scene from a distance.
Approach the scene and observe the rendering behavior.

Expected behavior:
https://github.com/user-attachments/assets/c62e1533-7620-423e-9045-d390200ba4b5
https://github.com/user-attachments/assets/595ab0bf-cfea-4e72-a423-6fbda9f9731d
Current behavior:
https://github.com/user-attachments/assets/587a4cd0-b76e-4432-9cf7-565a1ef4ce5a
https://github.com/user-attachments/assets/59ed8cb8-86d8-42ba-a70a-3b83124ef2ad
Additional Notes:
Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX

We need to do a few things here @sandrade-dcl

We need to verify if its an SDK7 and SDK6 scene, I would be keen to find a way to easily determine this.
We need to verify if it has asset bundles built for the scene.
We need to verify if it has LOD's built for the scene.

If we can know each of the above easily then it would be easier to diagnose these issues. Using some combination of the tools @dalkia has been working on.

I've investigated with @dalkia yesterday when he was explaining some flows of the AB converter and this is the results:

Scene at coordinates (53, -55), we suspect the creator is doing something wrong with the scene position as it is correctly rendered when you are close but it's offset to a strange position, the assets are there and fine if we move the scene to the correct position, Juani said it is not the first time he encounters something like this

Scene at coordinates (53, -70) build was re-run and now works fine

Scene at coordinates (53, 56) build was re-run and now works fine


Uninstalling doesn't delete module data

After installing npm install -g termgram and signed in to my telegram account, I tried uninstalling npm uninstall -g termgram.
After I installed Termgram agian, it had the previous data and asked for username/password instead of prompting for phone number and verification code (as it does the first time I installed it).
Thanks

Imho it is a matter of taste if the configuration data should be deleted of not. However, there should be a clear documentation of what is stored where and how to remove it.

@derhuerst Thank you for your comment, do you know where the data is stored / how can I remove it?

Looking quickly into the code, it seems as if it's ~/.termgramm.
You could submit a PR that adds this information to the readme.

Windows, it's in username/.termgram


Add resuming from specific checkpoint

Is your feature request related to a problem? Please describe.
In current version, there is no way to resume training from a specific checkpoint (not the last checkpoint).
Sometimes (very often in my case), one needs experiment training with different hyperparameters (e.g. dropout rate, augmentation) from a specific checkpoint.
Describe the solution you'd like
Add resume_from_checkpointargument to Trainer class.
Describe alternatives you've considered
I tried to use restore from Trainer class, but was not successful because it is meant to be used only when .fit() is called.
Additional context
FYI, I made a PR to demonstrate my idea: https://github.com/williamFalcon/pytorch-lightning/pull/516

I have been trying to figure out what's the right API to use to resume from checkpoint for half a day, and it's not in any of the example. The current method of resuming is not very well documented and not simple enough to use imo.

@stevenguh sorry, we just migrated docs.
https://pytorch-lightning.readthedocs.io/en/latest/lightning-module.html
load_from_checkpoint

Thank you for replying. I am still confused by differences between load_from_checkpoint  in LightningModule and  resume_from_checkpoint parameter in Trainer. It would be nice if there is a working example of resume. Also, the project advertises auto restore, but I have no idea how to activate it.


Msi package

Creating MsiPackage resource as a high quality resource

This change is

Codecov Report

Merging #338 into dev will increase coverage by 1%.
The diff coverage is 79%.

@@         Coverage Diff          @@
##            dev   #338    +/-   ##
====================================
+ Coverage    66%    67%    +1%
====================================
  Files        26     27     +1
  Lines      3686   3923   +237
  Branches      4      4
====================================
+ Hits       2444   2643   +199
- Misses     1238   1276    +38
  Partials      4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62e022...2b2ba31. Read the comment docs.

@kwirkykat - I reset this branch to the head of the new branch I had created so that you can continue the review more easily. This branch now has all the changes that the new branch does.

Closing this as duplicate


corrupted data files

I have been processing some of the basic fields (ua, va, ta, wap, zg) for the group-SNAPSI effort. In doing so, I've run into a couple of corrupted netcdf files that give HDF errors when trying to read them:
Meteo-France/CNRM-CM61/nudged/s20191001/r7i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r7i1p1f1_gr_20191001-20191114.nc
Meteo-France/CNRM-CM61/nudged/s20191001/r8i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r8i1p1f1_gr_20191001-20191114.nc
UKMO/GloSea6/control-full/s20180125/r10i1p1f1/6hrPt/wap/gn/v20230403/wap_6hrPt_GloSea6_control-full_s20180125-r10i1p1f1_gn_201801250600-201803260000.nc
When/if I encounter more, I will post them here.

Thank you for reporting this, please could you share the errors you get?
I am able to view these files ok with the ncdump command

All three files give the same errors when I try to read them in python with xarray, using both the standard netcdf4 and h5netcdf engines. These are the only files I've encountered that give me these errors.
In [1]: import xarray as xr

In [2]: ds = xr.open_dataset("/badc/snap/data/post-cmip6/SNAPSI/Meteo-France/CNRM-CM61/nudged/s20191001/r7i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r7i1p
   ...: 1f1_gr_20191001-20191114.nc").load()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[2], line 1
----> 1 ds = xr.open_dataset("/badc/snap/data/post-cmip6/SNAPSI/Meteo-France/CNRM-CM61/nudged/s20191001/r7i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r7i1p1f1_gr_20191001-20191114.nc").load()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/dataset.py:800, in Dataset.load(self, **kwargs)
    798 for k, v in self.variables.items():
    799     if k not in lazy_data:
--> 800         v.load()
    802 return self

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/variable.py:546, in Variable.load(self, **kwargs)
    544     self._data = as_compatible_data(loaded_data)
    545 elif isinstance(self._data, indexing.ExplicitlyIndexed):
--> 546     self._data = self._data.get_duck_array()
    547 elif not is_duck_array(self._data):
    548     self._data = np.asarray(self._data)

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:696, in MemoryCachedArray.get_duck_array(self)
    695 def get_duck_array(self):
--> 696     self._ensure_cached()
    697     return self.array.get_duck_array()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:690, in MemoryCachedArray._ensure_cached(self)
    554     # and self.key is BasicIndexer((slice(None, None, None),))
    552 # self.array[self.key] is now a numpy array when
    553 # self.array is a BackendArray subclass
    554 # and self.key is BasicIndexer((slice(None, None, None),))
    555 # so we need the explicit check for ExplicitlyIndexed
    556 if isinstance(array, ExplicitlyIndexed):
--> 557     array = array.get_duck_array()
    558 return _wrap_numpy_scalars(array)

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/coding/variables.py:74, in _ElementwiseFunctionArray.get_duck_array(self)
     73 def get_duck_array(self):
---> 74     return self.func(self.array.get_duck_array())

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:551, in LazilyIndexedArray.get_duck_array(self)
    550 def get_duck_array(self):
--> 551     array = self.array[self.key]
    552     # self.array[self.key] is now a numpy array when
    553     # self.array is a BackendArray subclass
    554     # and self.key is BasicIndexer((slice(None, None, None),))
    555     # so we need the explicit check for ExplicitlyIndexed
    556     if isinstance(array, ExplicitlyIndexed):

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/backends/netCDF4_.py:100, in NetCDF4ArrayWrapper.__getitem__(self, key)
     99 def __getitem__(self, key):
--> 100     return indexing.explicit_indexing_adapter(
    101         key, self.shape, indexing.IndexingSupport.OUTER, self._getitem
    102     )

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:858, in explicit_indexing_adapter(key, shape, indexing_support, raw_indexing_method)
    836 """Support explicit indexing by delegating to a raw indexing method.
    837
    838 Outer and/or vectorized indexers are supported by indexing a second time
   (...)
    855 Indexing result, in the form of a duck numpy-array.
    856 """
    857 raw_key, numpy_indices = decompose_indexer(key, shape, indexing_support)
--> 858 result = raw_indexing_method(raw_key.tuple)
    859 if numpy_indices.tuple:
    860     # index the loaded np.ndarray
    861     result = NumpyIndexingAdapter(result)[numpy_indices]

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/backends/netCDF4_.py:113, in NetCDF4ArrayWrapper._getitem(self, key)
    111     with self.datastore.lock:
    112         original_array = self.get_array(needs_lock=False)
--> 113         array = getitem(original_array, key)
    114 except IndexError:
    115     # Catch IndexError in netCDF4 and return a more informative
    116     # error message.  This is most often called when an unsorted
    117     # indexer is used before the data is loaded from disk.
    118     msg = (
    119         "The indexing operation you are attempting to perform "
    120         "is not valid on netCDF4.Variable object. Try loading "
    121         "your data into memory first by calling .load()."
    122     )

File src/netCDF4/_netCDF4.pyx:4958, in netCDF4._netCDF4.Variable.__getitem__()

File src/netCDF4/_netCDF4.pyx:5916, in netCDF4._netCDF4.Variable._get()

File src/netCDF4/_netCDF4.pyx:2029, in netCDF4._netCDF4._ensure_nc_success()

RuntimeError: NetCDF: HDF error

In [3]: ds = xr.open_dataset("/badc/snap/data/post-cmip6/SNAPSI/Meteo-France/CNRM-CM61/nudged/s20191001/r7i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r7i1p1f1_gr_20191001-20191114.nc", engine="h5netcdf").load()
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
Cell In[3], line 1
----> 1 ds = xr.open_dataset("/badc/snap/data/post-cmip6/SNAPSI/Meteo-France/CNRM-CM61/nudged/s20191001/r7i1p1f1/6hrPt/ta/gr/v20230215/ta_6hrPt_CNRM-CM61_nudged_s20191001-r7i1p1f1_gr_20191001-20191114.nc", engine="h5netcdf").load()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/dataset.py:800, in Dataset.load(self, **kwargs)
    798 for k, v in self.variables.items():
    799     if k not in lazy_data:
--> 800         v.load()
    802 return self

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/variable.py:546, in Variable.load(self, **kwargs)
    544     self._data = as_compatible_data(loaded_data)
    545 elif isinstance(self._data, indexing.ExplicitlyIndexed):
--> 546     self._data = self._data.get_duck_array()
    547 elif not is_duck_array(self._data):
    548     self._data = np.asarray(self._data)

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:696, in MemoryCachedArray.get_duck_array(self)
    695 def get_duck_array(self):
--> 696     self._ensure_cached()
    697     return self.array.get_duck_array()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:690, in MemoryCachedArray._ensure_cached(self)
    689 def _ensure_cached(self):
--> 690     self.array = as_indexable(self.array.get_duck_array())

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:664, in CopyOnWriteArray.get_duck_array(self)
    663 def get_duck_array(self):
--> 664     return self.array.get_duck_array()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:557, in LazilyIndexedArray.get_duck_array(self)
    552 # self.array[self.key] is now a numpy array when

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/coding/variables.py:74, in _ElementwiseFunctionArray.get_duck_array(self)
     73 def get_duck_array(self):
---> 74     return self.func(self.array.get_duck_array())

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:551, in LazilyIndexedArray.get_duck_array(self)
    550 def get_duck_array(self):
--> 551     array = self.array[self.key]
    552     # self.array[self.key] is now a numpy array when
    553     # self.array is a BackendArray subclass
    554     # and self.key is BasicIndexer((slice(None, None, None),))
    555     # so we need the explicit check for ExplicitlyIndexed
    556     if isinstance(array, ExplicitlyIndexed):

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/backends/h5netcdf_.py:51, in H5NetCDFArrayWrapper.__getitem__(self, key)
     50 def __getitem__(self, key):
---> 51     return indexing.explicit_indexing_adapter(
     52         key, self.shape, indexing.IndexingSupport.OUTER_1VECTOR, self._getitem
     53     )

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/core/indexing.py:858, in explicit_indexing_adapter(key, shape, indexing_support, raw_indexing_method)
    836 """Support explicit indexing by delegating to a raw indexing method.
    837
    838 Outer and/or vectorized indexers are supported by indexing a second time
   (...)
    855 Indexing result, in the form of a duck numpy-array.
    856 """
    857 raw_key, numpy_indices = decompose_indexer(key, shape, indexing_support)
--> 858 result = raw_indexing_method(raw_key.tuple)
    859 if numpy_indices.tuple:
    860     # index the loaded np.ndarray
    861     result = NumpyIndexingAdapter(result)[numpy_indices]

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/xarray/backends/h5netcdf_.py:58, in H5NetCDFArrayWrapper._getitem(self, key)
     56 with self.datastore.lock:
     57     array = self.get_array(needs_lock=False)
---> 58     return array[key]

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/h5netcdf/core.py:347, in BaseVariable.__getitem__(self, key)
    339     fv = self.dtype.type(self._h5ds.fillvalue)
    340     return np.pad(
    341         self._h5ds,
    342         pad_width=padding,
    343         mode="constant",
    344         constant_values=fv,
    345     )[key]
--> 347 return self._h5ds[key]

File h5py/_objects.pyx:54, in h5py._objects.with_phil.wrapper()

File h5py/_objects.pyx:55, in h5py._objects.with_phil.wrapper()

File ~/mambaforge/envs/py311/lib/python3.11/site-packages/h5py/_hl/dataset.py:758, in Dataset.__getitem__(self, args, new_dtype)
    756 if self._fast_read_ok and (new_dtype is None):
    757     try:
--> 758         return self._fast_reader.read(args)
    759     except TypeError:
    760         pass  # Fall back to Python read pathway below

File h5py/_selector.pyx:376, in h5py._selector.Reader.read()

OSError: Can't synchronously read data (wrong B-tree signature)

Thank you for raising these errors, the 3 corrupt files have been replaced in the archive and should open ok now.

Thank you @mollymacrae - I can confirm that I am able to read the files and that the jobs that were failing before now complete without issue.


Option to create a new task

Hi! Thanks for the add-on, it's really helpful.
But it would be nice if the add-on could not just attack comments to existing tasks, but instead create new tasks in ClickUp (adding comment like it does currently afterwards).
This requires adding some extra UI elements like task name (should default to mail subject), start/end date and optionally/later other task fields, but it will speed up the work significantly.
Thanks in advance. If possible, tell if you plan to develop this add-on further or not. If not - maybe I'll try to fork the project and implement this myself.

thanks.
new version of add-on has been released:
https://github.com/Ruvin/Conscious-ClickUp-Thunderbird-Plugin/releases/tag/v2.0.0


Refactor atoms_characters.hpp

There is no change in behavior, it produces bit-for-bit identical binaries with gcc for all tests. I didn't test with other compilers.

oh, I forget it was there intentionally, for better readability of generated code, will rollback, sorry

thank you for diving into CTRE code anyway

Is the problem that the type alias isn't a separate type? Because it can be done using inheritance instead, like:
struct digit_chars : char_range<'0', '9'> { };

I have this on my other "refactor_atom_characters" branch.
I did this because it's much more convenient for my partial_ordering implementation (although admittedly not needed). I need to have a compare_char for all these types.

The inheritance variant would be much better. The problem is that the type-alias is not shown when debugging.

Please send new push request with inheritance.