getters for reachableTargetStates and possible trigger Events

Thank you for this PR. However, I don't think these calculations should be implemented in the state machine itself (note that what you suggest is a breaking change BTW). If we add a method like getReachableStates, one would ask why we don't add a method like getUnreachableStates as well and may be other methods.. That's why I prefer keeping those calculations outside of the state machine since it already gives the necessary information to do that:
Set<State> reachableStates = stateMachine.getTransitions().stream()
        .filter(it -> it.getSourceState().equals(stateMachine.getCurrentState()))
        .map(Transition::getTargetState)
        .collect(Collectors.toSet());

// similar thing for unreachableStates if needed

Set<? extends Class<? extends Event>> triggerEvents = stateMachine.getTransitions().stream()
        .filter(it -> it.getSourceState().equals(stateMachine.getCurrentState()))
        .map(Transition::getEventType)
        .collect(Collectors.toSet());

// similar thing for non-trigger events

// etc

Do you agree?

Imho a matter of taste whether this kind of calculations should be part of FiniteStateMachine (GRASP information expert principle) or whether the  FiniteStateMachine should be kept to a pure "minimum".

Keeping things to a pure minimum is the philosophy behind all j-easy projects: no feature creep (here is one of my favourite quotes on the matter). That said, I have no objections against adding a necessary feature or modifying the library/framework if something is missing in the API. But it is not the case here, the API already provides all infos required to do these calculations. So I prefer to keep them outside the FSM.

Also fine by me to do the calculations outside of FiniteStateMachine, was just a suggestion.

Thank you for your suggestion anyway!


A issue about changing pre-trained model to SDv2.1

Hi, I want to change the pre-trained model to stable diffusion 2.1 in main branch, but I ran into some difficulties when load UNet.
To change the pre-trained model, I I made the change to the code:

Create config file ./config/model/SDv2.1mv_rawbow.yaml, the main different with ./config/model/SDv1.5mv_rawbow.yaml is:

change "pretrained_model_name_or_path"
change "controlnet.camera_out_dim" from 768 to 1024
change "controlnet.bbox_embedder_param.class_token_dim" from 768 to 1024
change "controlnet.bbox_embedder_param.proj_dims" from [768, 512, 512, 768] to [1024, 512, 512, 1024]

After that, I run accelerate launch --mixed_precision fp16 --gpu_ids all --num_processes 1 tools/train.py +exp=224x400 runner=1gpus
And the terminal show:
...
[2024-12-17 03:34:14,024][root][INFO] - [UNet2DConditionModelMultiview] load pretrained with missing_keys: [down_blocks.0.attentions.0.transformer_blocks.0.norm4.weight, down_blocks.0.attentions.0.transformer_blocks.0.norm4.bias', ..., 'mid_block.attentions.0.transformer_blocks.0.connector.weight', 'mid_block.attentions.0.transformer_blocks.0.connector.bias']; unexpected_keys: []
...

The INFO was reported in magicdrive.networks.unet_2d_condition_multiview.UNET2DConditionModelMultiview.from_unet_2d_condition. So I thought maybe I should:

Change  __init__ in magicdrive.networks.unet_2d_condition_multiview.UNET2DConditionModelMultiview

by compared SDv2.1's unet.config, I change:
1. corss_attention_dim: 1280 -> 1024
2. attention_head_dim: 8 -> (5, 10, 20, 20)
3. use_linear_projection: False -> True
4. upcast_attention: False -> True

But it still not work, could you give me some hints? Thank you so much!

Please be notified with #128. It is normal to see missing keys as we are adding modules to SD and partially loading the pre-trained model. They are not errors but helper INFO for you to double-check whether the parameters are loaded as expected.
The following parts seem fine to me.

To change the pre-trained model, I I made the change to the code:

Create config file ./config/model/SDv2.1mv_rawbow.yaml, the main different with ./config/model/SDv1.5mv_rawbow.yaml is:

change "pretrained_model_name_or_path"
change "controlnet.camera_out_dim" from 768 to 1024
change "controlnet.bbox_embedder_param.class_token_dim" from 768 to 1024
change "controlnet.bbox_embedder_param.proj_dims" from [768, 512, 512, 768] to [1024, 512, 512, 1024]

However, I do not think changing the default parameters helps, because we initialize the model with
https://github.com/cure-lab/MagicDrive/blob/d2fad7dd5056110afed07da821325eab84f967e8/magicdrive/runner/multiview_runner.py#L109
it will load the parameters from ${YOUR_PRETRAINED_MODEL}/unet/config.json and override the detaults.
This is also reflected by the following lines, where you may need to take a closer look into it:
https://github.com/cure-lab/MagicDrive/blob/d2fad7dd5056110afed07da821325eab84f967e8/magicdrive/networks/unet_addon_rawbox.py#L431-L473
I took a quick look at SD2.0 and found that it keeps the same module for the UNet. Therefore, I do not think you need to change any __init__ functions if in case that no errors were reported. However, please be reminded to also change the text encoder & tokenizer & vae for SD2.0.

Oh, I understand. At first I saw so many missing keywords that I thought the model wasn't loading properly（＃－.－）
Thank you for your reply!


Use envvars for configuration instead of a file

Close #941, close #180, fix #1090

Env vars are easy to change between deploys without changing any code; unlike config files, there is little chance of them being checked into the code repo accidentally; and unlike custom config files, or other config mechanisms such as Java System Properties, they are a language- and OS-agnostic standard.
https://12factor.net/config

Also,

Once we add a working setup.py, multiple users will be able to start their own customized instance from the same installed codebase (#941)
The ability to set the configuration interactively doesn't scale well as we continue to add options

This seems to improve the time it takes to start tools (and this should be reflected on Travis test time too):
before:
$ time ./tools/inference.py --help
real	0m0.821s

After:
$ time ./tools/inference.py --help
real	0m0.438s

Can we document the full list of environment variables?

I added a doc at docs/Configuration.md.

Thanks for the review Greg! I'm going to merge this now, to enable #1093 (which enables #927).

Oops, I meant to squash before merging. Sorry.


ops: deploy to Vercel

Will be deployed, when all PoC issues will be closed

Currently, project deployed already, without history page. All necessary info regarding deployment will be updated in README.md


TAJO-1510: Change a function name from getFileCunks to getFileChunks

Trivial changes.

+1
Thanks for your contribution.
I'll ship it soon.


IVYPORTAL-17731 Create accessibility documentation: update document

I changed everything and incorporated Peters requested changes and commited the changes to the branch

Hi @phochstr ,
Alex made some updates. Could you help us to review it again?
Thank you!

Hi @phochstr ,
Is this PR OK to merge?

No. It is in the exact same state as I reviewed it first time. Has there been a Commit by Alex?

I try to get @AlexSchaIvy to tell me what he intended to change as I see no single change here.

[like]  Peter Hochstrasser reacted to your message:

From: Le Ngoc Danh @.>
Sent: Tuesday, October 22, 2024 4:21:48 AM
To: axonivy-market/portal @.>
Cc: Peter Hochstrasser @.>; Mention @.>
Subject: Re: [axonivy-market/portal] IVYPORTAL-17731 Create accessibility documentation: update document (PR #1120)
Hi @phochstrhttps://github.com/phochstr ,
Is this PR OK to merge?
—
Reply to this email directly, view it on GitHubhttps://github.com/axonivy-market/portal/pull/1120#issuecomment-2428199341, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAVIIPYETTFANJ3IE54DF6DZ4XHFZAVCNFSM6AAAAABPUGHKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGE4TSMZUGE.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @phochstr ,
I pushed some changes following your feedback.
Please help us review it again.
Thank you

Hi @phochstr ,
Alex just made some updates. Please help us to check it.
Thank you.


DLA_Ranker_CASP15 results differs from DLA_Ranker

Hello Yasser,
I have used this version of the program, and it is much more easy to use but I still have some questions:
It seems that DLA-Ranker and DLA-Ranker_CASP don’t score the same way, I got different results using the same crystallographic complex 6WEQ (one scored 0.21 and one scored around 0.4 for DLA and DLA_Casp respectively). Also in DLA_Ranker, the crystallographic structure was scored the highest (when compared with haddock generated models) and in DLA_CASP it was not (but still one of the highest scores (top 10%)). Do you know if this is normal, or maybe my use of the program DLA_Ranker was wrong ?
Many thanks
J.

Hi Jacqueries,
Thank you for using this version. The overall procedure of both pipelines is the same however the models can be different. If you followed the default parameters in the test.py codes, I believe you used different models for each experiment. The model that we used for CASP pipeline is trained on all the 450k conformations on the 142 dimers of BM5. Also, I believe in your initial experiment with DLA-Ranker pipeline (for which you got 0.4) you reduced the dimensions to 4. Also please make sure the averaging scheme is the same in both cases.


add readme.java.md and modify readme files

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@qiaozha,
Do you know how to fix this issue?

@qiaozha
Is there any update?

/azp run

@ruowan Can you take a look at the credscan failure ? Thanks

@msyyc  the SDK breaking change tracing seems failing and it complains about some Python SDK track2 breaking changes but I don't see a label of it. Can you help take a look at it ? Thanks

@qiaozha
Could you approve the PR?


Latest version of Fluent doesn't work, last functioning commit is d524445fda21aa5ae45040e2dc73520a0b80cb0b

Django versions tried:

1.9.[10,11,12]
1.10

Error we get:
django.core.exceptions.FieldError: Local field '_fluent_cache' in class 'BusinessProcess' clashes with field of similar name from base class 'BaseSlugModel
Last valid commit we could make it work again:
d524445fda21aa5ae45040e2dc73520a0b80cb0b

It appears to be due to having an abstract model class which has it's own TranslatableCharField set. Any child classes that extend from this abstract model then throw the warning.
Moving the field to the descending models and removing it from the base class stops the errors.


question about package.json of that project

The main property in package.json points to src/index.js and not to /dist/vue-good-table.min.js
is it a mistake?
and if not - why is it so?

@iliran11 hey! that is not a mistake.... /dist/vue-good-table.min.js is meant to be used as a standalone (in case you want to use it on codepen or jsfiddle). For regular vue projects, the plugin to include is src/index.js so that your local build etc can be debugged properly and your build process can take care of minification etc for prod.
closing. please re-open if you have further questions/concerns.


Trait name/descriptor label from GRIN scrape

We would love to have included in the output a column including the descriptor name.  Perhaps between 'descriptor id'	'descriptor definition'.
Example: https://npgsweb.ars-grin.gov/gringlobal/descriptordetail.aspx?id=68104
Returns
descriptor ID = 68104
descriptor definition = In-vitro dry matter disappearance (ivdmd) expressed as a percent of the cultivar venal. Higher than 100% suggests low digestibility & higher by-pass protein.
but lacks the actual descriptor name: By pass protein (PROTBYPASS)
Again, if this is not clear, let me know.
Thanks!

now, the descriptor name is included in the resulting tsv file.
The lines below were extracted after implementing the feature. Please observe the value Core subset (CORE) in the lines: the name of the descriptor used.
taxon id	taxon name	descriptor id	descriptor name	descriptor definition	method id	method name	observed value	accession id	accession number	accession name
300359	Medicago sativa L. subsp. sativa	68104	Core subset (CORE)	In-vitro dry matter disappearance (ivdmd) expressed as a percent of the cultivar venal.  Higher than 100% suggests low digestibility & higher by-pass protein.	391002	ALFALFA.PROTBYPASS.93.VOLENEC	140	1140225	PI 162787	'PAMPA'
300359	Medicago sativa L. subsp. sativa	68102	Core subset (CORE)	Crude protein in the leaf.	490600	ALFALFA.1989.BARNES	29.4	1140225	PI 162787	'PAMPA'


Add currentTaskId method to TaskContext

This enabled task utilities to give the user useful information about the task being evaluated. The method is intended to be used from the functions passed to any of the processWithContext(...) builders.

@nevillelyh

[Current coverage][cc-pull] is 97.98%

Merging [#16][cc-pull] into [master][cc-base-branch] will increase coverage by 0.34%

File .../rouz/task/Task.java (not in diff) was modified. more

Misses -1
Partials 0
Hits +1

@@             master        #16   diff @@
==========================================
  Files            10         11     +1
  Lines           379        396    +17
  Methods           0          0
  Messages          0          0
  Branches         17         17
==========================================
+ Hits            370        388    +18
+ Misses            7          6     -1
  Partials          2          2

Powered by Codecov. Last updated by [7582a3b...c351b86][cc-compare]
[cc-base-branch]: https://codecov.io/gh/rouzwawi/flo/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/rouzwawi/flo/compare/7582a3b9121faaace089cfe274adbc4b6470fc34...c351b86de36f107ee1b75eb78f3f13648fa4d6eb
[cc-pull]: https://codecov.io/gh/rouzwawi/flo/pull/16?src=pr


error: failed to run custom build command for rsoundio v0.1.6

I'm trying to use this on an RPi4, and I am getting this failure on the custom build.rs:
Compiling rsoundio v0.1.6
error: failed to run custom build command for `rsoundio v0.1.6`

Caused by:
  process didn't exit successfully: `/home/pi/audio-client/target/debug/build/rsoundio-542f1068037eef90/build-script-build` (exit code: 101)
  --- stdout
  cargo:rerun-if-env-changed=SOUNDIO_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=SOUNDIO_STATIC
  cargo:rerun-if-env-changed=SOUNDIO_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_armv7-unknown-linux-gnueabihf
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_armv7_unknown_linux_gnueabihf
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_armv7-unknown-linux-gnueabihf
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_armv7_unknown_linux_gnueabihf
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_armv7-unknown-linux-gnueabihf
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_armv7_unknown_linux_gnueabihf
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/pi/.cargo/registry/src/github.com-1285ae84e5963aae/rsoundio-0.1.6/build.rs:29:78

Is there something I have to do to install libsoundio first?  I did not see anything in the readme

... install libsoundio first?

If I remember correct then this part of build.rs should take care of making libsoundio available.
But, in your case build.rs:29 fails which is a call to ldconfig that checks availability of libsoundio.  Is ldconfig in your PATH?

Please note that rsoundio is kind of abandonware, I will keep reviewing merge requests but will not fix any bugs because of a lack of time and interest in Rust.

Thanks - it was the problem with ldconfig not being in path.
Now I'm seeing an underflow - I'm copying the code directly from the sine example.  Do you know what potentially causes an underflow to happen?  I'm not sure if this could be because it's running on 32-bit Arm?  (Raspberry Pi 4)

Which backend do you use, PulseAudio?  If possible try to use jack, for me the PulseAudio backend never worked reliably.  Bytheway, sorry for your inconvenience with using rsondio.

No need to apologize - thanks for releasing your code!
I'm using the ASLA back-end, but I can try jack


Fix 'pytest.register_assert_rewrite("tests.common")' warning

See https://github.com/home-assistant/home-assistant/pull/29791/files/fea243c035f117275fda1895720d30e7f977aa9c#r355533273
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

See the comment by balloob in the OP...

(linked in the OP)


Added the first benchmarks

This PR adds the first benchmarks for ServiceManager. I created a first round of benchmarking fetching the following services:

factories;
invokables;
alias;
services;
abstract services;

These the results of the execution on a CPU Intel i5-2500 at 3.30GHz, 8 GB RAM, Ubuntu 14.04, PHP 5.5.9:
ZendBench\ServiceManager\FetchServices
    Method Name                   Iterations   Average Time      Ops/second
    ---------------------------- ------------ ----------------- ---------------
    fetchFactoryService        : [     1,000] [0.0000220508575] [45,349.71023 ]
    fetchInvokableService      : [     1,000] [0.0000179929733] [55,577.25129 ]
    fetchService               : [     1,000] [0.0000026111603] [382,971.51205]
    fetchAliasService          : [     1,000] [0.0000124194622] [80,518.78443 ]
    fetchAbstractFactoryService: [     1,000] [0.0000263185501] [37,996.01406 ]

@Ocramius I removed the sprintf and the substraction in the fetch of the services. The overhead was between 1% and 4% before the previous benchmark.

@ezimuel thanks!

I'm closing this PR in favor of #38. I included all the feedbacks of @Ocramius. Thanks!


BIGTOP-3330: avoid duplicate jars between oozie and oozie-client

Add a workaround to the install_oozie.sh script to avoid duplicate
jars between oozie and oozie-client. This issue leads to override
errors when installing the oozie package on Debian (oozie-client
is among its dependencies).
Credis to Olaf Flebbe for the solution.
Tested the packages on a Debian system and it seems working fine.

Thanks, merged into master

Merged to branch-1.4 as well

And thanks!

thanks!


Checking for existing resources multiple times

e.g. for the user, we check in the service, as well as into the data source

https://github.com/fastlane/ci/blob/master/app/services/user_service.rb#L43-L46
https://github.com/fastlane/ci/blob/master/app/services/data_sources/json_user_data_source.rb#L170-L178

It seems like we probably don't want to check from inside the json_user_data_source.rb, as we might have multiple implementations of the data source in the future, right?
Having the duplicate detection is an issue, as we have inconsistent ways of handling exceptions, and dead code that can never be reached (even though it might be reached in tests, if a class is tested directly)
Thoughts? 🚔

Agreed 👍

Alright, solving this for environment variables for now 👍

This is basically solved if we implement https://github.com/fastlane/ci/issues/761

Moving this to 1.0 so we can check back later if this is solved already 👍 Seems more like a small detail, than a crucial thing to change


form-select[multiple] should not display any indicator/icon

Under Bootstrap 4 (4.6.0), custom-select[multiple] does not display the select indicator and the is-valid/invalid icon:
<select class="custom-select is-valid" multiple></select>

Under Bootstrap 5 (5.0.0-beta3), the new form-select[multiple] does display the select indicator and the is-valid/invalid icon:
<select class="form-select is-valid" multiple></select>

This is a regression.

Probably fixed by #33411

IMHO the PR is wrong/not enough, see my comment here: https://github.com/twbs/bootstrap/pull/33411#issuecomment-816675388


Notifications

closes #489
If your server has not been wiped since this server commit 11e54111b2041e7716e7a212a771dd6c253d62f5, you will want to wipe your data, otherwise your old notifications will not have the proper data the client is expecting.

I'm not hearing a sound when a notification comes in.
@rmisio has this been wired in yet?

I'm not hearing a sound when a notification comes in.

I forgot about that. I'll wire that in.
@morebrownies @jjeffryes What was the reasoning in v1 we used a custom sound instead of letting the OS use it's designated notification sound?

Typically a custom sound is used to make your app stand out from the bunch.
Slack for example doesn't use the native sound and when I'm across the room I know what type of notification I'm getting just by the type of sound.

We should make sure to wire up the sound to trigger for inbound chat messages too.
I believe in V1 we only triggered the sound when the window is inactive, right?

We should make sure to wire up the sound to trigger for inbound chat messages too.

There's a separate issue for that. I'll circle back to that after this PR.

I believe in V1 we only triggered the sound when the window is inactive, right?

Actually, looking at the code, we fired the sound irrespective of whether the window is active. Also, we fired the native notification no matter what as well. So, if we're going to match v1, then I'll tweak it so the sound and the native notifications come all the time.

There's a separate issue for that. I'll circle back to that after this PR.
👍

Actually, looking at the code, we fired the sound irrespective of whether the window is active. Also, we fired the native notification no matter what as well. So, if we're going to match v1, then I'll tweak it so the sound and the native notifications come all the time.

👍

A few more things I found:

The notification tray seems kind of tight (vertically) Could we increase js-tabContainer tabContainer scrollBox to min-height 320px?

The font size within notifications feels a bit large and could be bumped down one notch .listBox .listItem to font size 1.3rem?`

Links within notifications would probably be better set to green, they'll stand out a bit more.

The vertical line underneath the tab bar goes away when you scroll. It should stay fixed. See screenshot below:

No notifications found displays in Orders tab when notifications exist

The link to OpenBazaar Shirt within the purchase notifications goes to
ob://QmcTMuGwpwzkc8hVqHe72AA2CDcuGYzvzZJWu98pf7tuot/store/openbazaar-shirt
instead of
ob://QmcFgSGtiNB1h4ycLWvPuYnvRrTJZcNLeuJdnynNC8vBW8/store/openbazaar-shirt

@jjeffryes @morebrownies This should be ready for re-review. Thanks for finding those things.

Ok great thank you. I'll circle back to this when I can.

Looks great to me @rmisio. Thanks for getting those fixes in 👍


problem yes or no ?

Is the problem was to update the laravel 5.2.31 to 5.2.40  with "composer update" ????

I've updated from 5.2.30 to 5.2.41 without any issues. Just a quick note, if you do run composer update all the other dependencies you have in composer.json will get updated as well.

If you're having a trouble updating you should post the command line output here. Most likely something in your app is causing composer to fail when it does the php artisan optimize at the end of the process.

This isn't really the place to look for support with general issues, this is a place for filing issues with the framework itself. I'd suggest either the Laravel Slack channel, IRC or StackOverflow

Yes, please do ask on the forums, and I'm sure someone can help you there.


error Attachment does not exist when using image:: from an asciidoc included page

Hello,
I have the following setup:
topic.adoc
= Topic 1

include::topic1/_included.adoc[]

And topic1/_included.adoc:
== Included

image::../../images/sample.png[]

I get this error when I execute the maven plugin :
[ERROR] Failed to execute goal org.sahli.asciidoc.confluence.publisher:asciidoc-
confluence-publisher-maven-plugin:0.22.0:publish (publish-documentation) on proj
ect asciidoc-confluence: Publishing to Confluence failed: Attachment 'sample.png
' does not exist -> [Help 1]
[ERROR]

I'm using asciidoc-confluence-publisher-maven-plugin, version 0.22.0
You can find a sample project here https://github.com/gonzalad/asciidoc-confluence/tree/issue-431
You'll have to run  mvn generate-resources on this project to reproduce the error.
Thanks,

Same here, using publish script in docker image (0.22.0) with result:
Exception in thread "main" java.lang.RuntimeException: Attachment 'workspace_management_0040.png' does not exist 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.ensureAttachmentExists(AsciidocConfluenceConverter.java:233) 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.lambda$ensureAttachmentsExist$6(AsciidocConfluenceConverter.java:226) 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.ensureAttachmentsExist(AsciidocConfluenceConverter.java:226) 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.lambda$buildPageTree$0(AsciidocConfluenceConverter.java:100) 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.buildPageTree(AsciidocConfluenceConverter.java:91) 	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.convert(AsciidocConfluenceConverter.java:78) 	at org.sahli.asciidoc.confluence.publisher.cli.AsciidocConfluencePublisherCommandLineClient.main(AsciidocConfluencePublisherCommandLineClient.java:100)
File workspace_management_0040.png exists, conversions to multipage html and pdf book are fine.
Problem with confluence-publisher appeared unexpected while documents size and complexity growth. So I can't provide more info what may cause it.

Same here, using  docker image (0.24.0) in GitHub Actions with result:
Status: Downloaded newer image for confluencepublisher/confluence-publisher:0.0.0-SNAPSHOT
Exception in thread "main" java.lang.RuntimeException: Attachment 'network-areas.jpg' does not exist
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.ensureAttachmentExists(AsciidocConfluenceConverter.java:233)
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.lambda$ensureAttachmentsExist$6(AsciidocConfluenceConverter.java:226)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:15[41](https://github.com/Super-Pharm/architecture/actions/runs/11194722464/job/31121557488#step:4:42))
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.ensureAttachmentsExist(AsciidocConfluenceConverter.java:226)
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.lambda$buildPageTree$0(AsciidocConfluenceConverter.java:100)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.buildPageTree(AsciidocConfluenceConverter.java:91)
	at org.sahli.asciidoc.confluence.publisher.converter.AsciidocConfluenceConverter.convert(AsciidocConfluenceConverter.java:78)
	at org.sahli.asciidoc.confluence.publisher.cli.AsciidocConfluencePublisherCommandLineClient.main(AsciidocConfluencePublisherCommandLineClient.java:100)

Hi @gonzalad, thank you for reporting this issue and sorry for the delay.
Currently, the Confluence Publisher converts AsciiDoc file by file (excluding included files, since they are included from somewhere already) and sets the context for each AsciiDoc file to the base folder of that file. Therefore, all relativ urls (also for images) are resolved against that base folder. That's why the image path used in the included file is not matching (since the base folder is set to main not topic1).
If you put image::../images/sample.png[] as the image path, it works. If you also want to convert to PDF or HTML, you would need to put :imagesdir: ../ inside the include file to compensate. I agree that this is somewhat quirky ...


x/crypto: crypto/ssh still uses insecure SHA1 by default, OpenSSH ending support soon

The code in crypto/ssh/keys.go still uses insecure SHA1 signatures for RSA keys by default (unless the SignWithAlgorithm is called, but many codepaths such as SignCert will eventually call Sign which passes "" to SignWithAlgorithm. OpenSSH is going to disable this signature scheme by default in the next release as noted here.
Since OpenSSH 8.2 ssh-rsa signatures have been disabled for certificate signatures and ssh-keygen has used rsa-sha2-512 as the default for signing certificates.
I could submit a PR changing the signature function for RSA keys to be crypto.SHA512.
I also think that it's probably worth updating the verification to disallow use of SHA1 verification by default.

Duplicate of #37278


fix: unawaited promise when writing content frame

👍 This will probably fix intermittent frame errors on content frames I've been receiving. Thanks, can't wait to try it out.


Invocation problems about asynchronous and non-asynchronous calls

Here is my confusion:
Server side
I have a class :ConcreteService which is  of a concrete implementation of an interface: HelloService which is annotated by @ThriftService.
public class ConcreteService implements HelloService {

    @Override
    public String hello(String from) {
        return String.format("Hello %s, greeting from RPC server!", from);
    }

    @Override
    public ListenableFuture<String> helloAsync(String from) {
        return MoreExecutors.newDirectExecutorService().submit(() -> {
            try {
                // Going to mock a time consuming operation
                Thread.sleep(10 * 1000);
            } catch (InterruptedException ignore) {
            }
            return String.format("Hello %s, greeting from RPC server asynchronous call !",
                    from);
        });
    }

}

Client side
I create a HelloService with DriftClientFactory without any special configuration.

public class ClientTest {

    public static void main(String[] args) {
        HelloService service = new DriftClientFactory(...).create(HelloService.class).get();

        // Make an async call
        ListenableFuture<String> asyncResult = service.helloAsync("derrick");
        asyncResult.addListener(() -> {
            try {
                String result = asyncResult.get();
            } catch (Exception ignore) {
            }
        }, executor);

        // Make a non-async call
        String result = helloService.hello("derrick");
    }
}

Seems like the non-async method invocation will not be executed at the server side until the completion of the async invocation.
It looks like the server side takes the request sequentially, one by one, no matter the request is async or non-async.
My questions

Is it a misusage or a deliberate implementation of drift?

If it does a misusage, how can I fix it properly?

This is not expected. The protocol is multiplexed, so even for a single client with a single connection, there can be multiple requests in flight at once. A couple observations about your test code:

The annotated interface does not need to be shared between client and server. It's fine to have an async server with synchronous client or vice versa.
The async server method is actually synchronous due to the newDirectExecutorService(). The code is equivalent to

public ListenableFuture<String> helloAsync(String from) {
    Thread.sleep(10 * 1000);
    return Futures.immediateFuture("some result");
}

I'll write a test case for this later to confirm (thought we had one but couldn't find it).

@electrum Cool, I have already modified the code according to your reply and everything just goes smoothly.
I think the devil is all about using the MoreExecutors.newDirectExecutorService() improperly where I should use MoreExecutors.listeningDecorator(ExecutorService) to make tasks go asynchronously.
Thx pal.


sqlparser 0.21 upgrade

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Tracking for work needed to upgrade to sqlparser 0.21

[ ] https://github.com/apache/arrow-datafusion/pull/3193
[ ] https://github.com/apache/arrow-datafusion/pull/3194
[ ] https://github.com/apache/arrow-datafusion/pull/3122
[ ] TRIM
[ ] Fix regression with LIKE and reinstate test
[ ] IS NOT TRUE / IS NOT FALSE / IS [NOT] UNKNOWN

Describe the solution you'd like
Describe alternatives you've considered
Additional context

Mailing list thread: https://lists.apache.org/thread/3h9gh68gw32xnzp2728r0wz485lrgbf9
I also think https://github.com/apache/arrow-datafusion/pull/3122 will be needed
@andygrove  is there a branch somewhere that you are using to do this integration?

@andygrove is there a branch somewhere that you are using to do this integration?

Yes, there is a sqlparser-0.21 branch and some PRs already targeting it


pow function is not parsing correctly

The version I use: AngouriMath
Unexpected behaviour or bug:
When using Entity expr = "pow(2,3)"  it gives an UnhandledParseException:
AngouriMath.Core.Exceptions.UnhandledParseException: 'line 1:11 no viable alternative at input '*(2''
this is not limited to this particular input, but generalizes to any input in pow function
When using Entity expr = "pow(a,b)"  it gives an UnhandledParseException:
AngouriMath.Core.Exceptions.UnhandledParseException: 'line 1:11 no viable alternative at input '*(a''

Use ^ for power

I am using ^ for the time being and replacing all the Pow() instances from the user Input. I have also tested all the other functions, but they were working fine without issue


Use exporter for backing up user's database and metadata

Closes #2058

🔴 The files are upload to S3 under a randomly generated directory name, which makes them hard to find. They should be stored under a common directory (preferably, users_dbs but can be a different one).

🔴 tests

Working as intended ✨

Do not merge until https://github.com/CartoDB/cartodb-platform/pull/3908 is deployed


Feature Request: Pull based deployment method (GitOps style)

Describe the solution you'd like.
The ability to use a pull based approach to deploying workloads into a container app environment. An example of pull based deployment method is GitOps.
In other words, to have a "client" running in the environment, which periodically monitors a git repository and automatically pulls and applies any changes made to a specific branch in that repo (for instance when a PR is merged into the main branch).
The Git repository will be the single source of truth, and will contain the descriptions of the desired state of the running application(s), and there is an automated process to make the environment match the described state in the repository.
In the case of Kubernetes, the client would apply any changes to a yaml-manifest (or helm chart). For a container app environment, a bicep file or ARM Template (or a collection of those) should be applied instead.
Some requirements:

The time interval between synchronizations towards the repo should be configurable.
It should also be possible to trigger a synchronization with an event.
The client that runs in the environment needs to have permission to apply changes, which means that it needs to have an identity in Azure AD.
Should support both open and closed git repositories.
Git credentials should be stored in a secure manner (e.g. keyvault).

Example Scenario: Easily deploy to private environment.
When an environment is fully private, it becomes a challenge to deploy using tools like Github actions and Azure DevOps, since connectivity to the control plane is needed. This can be solved by opening up for (huge) ip ranges of the hosted agents used by Azure DevOps or Github, but this is rarely an acceptable solution. Another alternative is to use self hosted agents, in a VNET with access to the control plane, but this introduces operational cost and cost of ownership, as well as adding complexity.
A cleaner solution is to use a pull based deployment, from inside the container app environment. This removes the need to whitelist ip addresses, and/or the need to host virtual machines for self hosted agents.
Flux and ArgoCD are examples of GitOps tools, which are used for GitOps in Kubernetes.
Describe alternatives you've considered.
The other alternative already exists, with CD pipelines. Compared to a typical CD pipeline, this method has the advantage that it operates in an "inside out" manner.
Additional context.
Gitops is quickly becoming a popular solution for deploying applications and infrastructure to Kubernetes. There is reason to believe that this method of deployment will be requested for container apps as well.

+1 This would really improve the productivity for using multiple container apps.

@pelithne we are looking into building something like this until there's official support. My thought is that we will have a reconciler running as a background task in a managed environment and then have a separate RG where all other apps are created. We will have to create our own definition of an app etc that can be stored in a readable way in git.
I'll ping you when (if) we have something to try out.

@pelithne ACR Tasks can handle some of these requirements. They can listen for repo changes and automatically build images and push them into a network restricted registry. In my setup I am triggering the ACR tasks manually from azure pipelines, and then once the ACR task has executed I use CLI to update the container app to the new image.

Hi!
I've released an initial MVP of a GitOps engine for Azure Container Apps: https://github.com/XenitAB/azcagit
Feel free to test it out. :+1:

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

Wouldn't I have to install the fluxcd operator in the ACA environment for that to work? Is that even possible?

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

Wouldn't I have to install the fluxcd operator in the ACA environment for that to work? Is that even possible?

No. You would deploy fluxcd, install tf-controller and workload identity, create terraform ACA deployment in git, create tf-controller with workload ident creds with ref to aca git repo, a bit more complex but allows a lot more.

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

Wouldn't I have to install the fluxcd operator in the ACA environment for that to work? Is that even possible?

No. You would deploy fluxcd, install tf-controller and workload identity, create terraform ACA deployment in git, create tf-controller with workload ident creds with ref to aca git repo, a bit more complex but allows a lot more.

Or just use azcagit 😊🤷♂

Hi,
@denniszielke @dariagrigoriu could you please add this RFE in the ACA Roadmap ?
Would it be possible to leverage the AKS underlying Flux Add-on ?
Other use case related to the Flux ecosystem:

a CI/CD Runner deployed as a self-hosted agent in AKS could be combined with Flagger to automatically upgrade the Runner container image.
What about ACA ? Is there a way today to to automatically upgrade the Runner container image deployed in ACA ?

Thank you,
Steve ex GBB ;)

Anything new related to pull based GitOps for ACA?
Agree on the comments that something related to Flux would be ideal.
azcagit look great (thanks @simongottschlag) and for a small hobby project i would not hesitate to use it but for a long term commitment it does not feel ideal.

Any idea when this will be out or at least if MS can share Roadmap for future releases?

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

Wouldn't I have to install the fluxcd operator in the ACA environment for that to work? Is that even possible?

No. You would deploy fluxcd, install tf-controller and workload identity, create terraform ACA deployment in git, create tf-controller with workload ident creds with ref to aca git repo, a bit more complex but allows a lot more.

I don't fully understand. Would fluxcd with the tf-controllerthis all run in ACA as we know it today or would this require any evolution?

@simongottschlag this is quite awesome! We're a little late in noticing, thank you very much for sharing. How do people feel about getting something like this implemented into ACA? Can you share (comment or thumbs up) if you:

deployed @simongottschlag project into your environment
implemented something similar on your own
would love to have something like this

yes, it took me 5 times to get this "just right"

@simonjj something like that implemented into ACA would absolutely have me look at ACA as an alternative to AKS in more scenarios.

Have implemented a simple yaml -> container app GitOps tool using Pulumi, but would welcome something built in or a simple way to use a popular tool like Flux.

Any idea when this will be out or at least if MS can share Roadmap for future releases?

This seems to be the roadmap - https://github.com/orgs/microsoft/projects/540

This could also be modeled using tf-controller in fluxcd and terraform, although I don't really know the pros and cons to using tf-controller vs azcagit @simongottschlag?

Wouldn't I have to install the fluxcd operator in the ACA environment for that to work? Is that even possible?

No. You would deploy fluxcd, install tf-controller and workload identity, create terraform ACA deployment in git, create tf-controller with workload ident creds with ref to aca git repo, a bit more complex but allows a lot more.

I don't fully understand. Would fluxcd with tf-controller already run in ACA as we know it today or would this require any evolution?

I don't see how this can be achieved without the Microsoft effort. They already integrated flux for Azure Acr and Azure Kubernetes Service (https://learn.microsoft.com/en-gb/azure/azure-arc/kubernetes/conceptual-gitops-flux2) so let's hope they can embed it here also ...

@fritzfs I do not see GiOps for ACA still on MS Azure Roadmap! Help me rectify if I am wrong.

How do I contribute to ACA? I want to start developing a GitOps Operator for ACA. We live in a world of modern software engineering, and it isn't very pleasant not to have GitOps in ACA.

Hi, any updates about this? We cannot choose this product without any GitOps support.


About comment in output file

This library currently licensed under MIT license. But, default comment in output file says LGPL. Is there some kind of meaning to that?
https://github.com/haplokuon/netDxf/blob/e1b64e9f19f9e0fc7f72ed7b7b746f2682849561/netDxf/DxfDocument.cs#L164

I have changed the license a few months ago and I forgot to change that. Don't worry about it, you can easily edit, delete, and add your own comments.

Thank you. I sent pull request.

Thank you for your pull request, it won't be necessary, I already did the changes in my working copy. More programs should make use of the comments at least to identify its origin, even though they are not used in binary DXF files.

I see. My question was solved.


Release when?

Hi,
Are you planning a new release anytime soon?
Would be nice to at least update the dependencies without the need to build from git-HEAD.
Regards

Actually 0.1.1 is done and will be released within a week

Great, looking forward to it.


Matomo analytics not working

Our analytics service is not functional and has been down for some months. @rehrar mentioned @danrmiller is working on it. Would be great to have it up as soon as possible, so that we can use it to make more aimed changes and updates.

I'll talk to @rehrar and we'll set this up.

@danrmiller please see #1085


Release Checksums Don't Seem to Match .YML Files

Apologies if I am missing something, but was comparing the the Mac Beta 14 .dmg sha 512 checksum to the provided latest-mac.yml and the checksums are not matching up. I tried downloading multiple times and also looked at the Beta 13 .dmg file and also say a discrepancy. Just wanted to check if this was expected (and if I was doing something incorrectly) or if this was a concern. Thank you!

Hey, thanks for reaching out. Frankly i never checked the checksums but i think it is wrong because of the way how it is being build. So it is indeed expected to be wrong and will take a look in the future to fix this discrepancy


Adding tortoise-svn

In order for the installer to run properly the reduced UI mode flag /qr is necessary

Suggesting this in scoop-extras because though SVN is still used, Git is more popular

Firstly, congrats on finding a way to make that work. Unfortunately I assume it will require admin elevation to run the MSI. It also has unknown side effects (e.g. registry changes) and doesn't copy files to the user's directory.
There is old code in Scoop to do MSI installs (see here), which was deprecated because these kind of installs are at odds with Scoop's objectives.
I guess the problem is that there's no way to get Explorer integration for TortoiseSVN without making registry changes. And that requires admin elevation and is hard to reverse when it's uninstalled.
I can see you've put in some effort to get this working. If you could use adjust the installer.args to include TARGETDIR and INSTALLDIR (see here) so it at least ends up in the user's directory then I would accept this.

Thanks. I added a C: drive to post_install in case people are running from a different drive.


Remove "erasing" print from Directory.remove (Windows)

Fixes #39106
Haven't contributed in a while, nice simple bug to fix :)

why don't replace it with print_verbose() ??

Changed it to print verbose. Apologies for deleting the branch, I used underscores accidentally but it shouldn't matter.

Thanks!

Cherry-picked for 3.2.2.


Add RemoveEmptyTableAttributeRector

ref #156

@TomasVotruba @samsonasik I need help here.. I don't know how to remove the AttributeGroup 😕

You should remove from the node, eg: Class_ node, not from the AttributeGroup, so loop the data:
        foreach ($node->attrGroups as $attrGroup) {
            foreach ($attrGroup->attrs as $attr) {
                foreach ($attr->args as $arg) {
                     // check empty...
                }
            }
        }

Very helpful, thank you @samsonasik ! Didn't know attribute groups of a class were accessible from the Class_ node :)

@samsonasik running vendor/bin/rector add changes not related to this PR, should I really add them here?
The CI issue doesn't seem to be related to CS: https://github.com/rectorphp/rector-doctrine/actions/runs/4591564833/jobs/8107924067?pr=158#step:7:33

You can check previous check https://github.com/rectorphp/rector-doctrine/actions/runs/4591564833/jobs/8107924067?pr=158#step:6:1

Added a commit to apply CS fixes on unrelated code

Thank you @samsonasik for your guidance and your patience!

Thank you :clap:


Admin access not possible once a user has signed in normal user mode

The admin and claAuthor flags are not set if a user logs into the application and then decides to perform administrative tasks. This results in access denied when accessing resources protected by admin/CLA author roles.

This is somewhat by design. The reason is we need to request an OAuth access token scopes and there are lot more scopes for administrative users (we don't want to request the additional scopes for non admin users).
When the access denied exception happens, it should be handled by attempting to re-authenticate as an administrative user and obtain an access token with the additional scopes required. Is this not happening? It works for me.

NOTE: We could change the updated scopes of the access token logic to be distinct from being an admin user. I believe this would be a large improvement. However, this would be quite a bit of work.

Turns out I used /manage/ as URL instead of the correct /admin/ URL. Somewhat fooled myself because I received a basic auth prompt.

@mp911de Thanks for the response. You are right that the /manage/ URL could be configured better (i.e. use the same Security configuration as the rest of the application). That would be another nice improvement.

Could it maybe also be made configurable what the admin email domain must be?
That's what I bumped into :sweat_smile:
Also, the GitHub team id is also hard coded (for the CLA_AUTHOR permission.

@Shredder121 Yes that could be made configurable. If you would like to send a PR, please do (just please make the defaults what we are using now).

That's what I've seen as well but I didn't want to dig into other tickets atm. Sounds like a good addition for something like OrganizationProperties providing some defaults


fileSuccess response is string?

http://stackoverflow.com/questions/28724395/flow-js-filesuccess-response-is-string

Yes, string is for compatibility reasons  and it makes library a bit smaller and a bit more flexible. However JSON is used everywhere and should be supported, so feel free to open a pull request for JSON parsing. I think it should be enabled through config.

Feel free to add this in next improvement or in new version.


Add a useful error message when you try to save a non-Ecto struct with ExMachina.Ecto

Just had one comment/suggestion. Looks good though!


Add additional printer columns

This commit adds additional printer columns. Certificate validity data such as NotBefore, NotAfter and Issuer is now printed by default on oc get command.
Signed-off-by: Tejas Parikh<EMAIL_ADDRESS>

/lgtm


Resource change tracking

We already added tracking to Archetypes and Resources are backed by archetypes. We should create a ChangedRes query/pointer.

Would that ChangedRes be and Option to check on at the start of the system, being None if the resource has not been added or mutated ? Or should it fit in a Query as an Iterator ?

Closed by #388


arm64/qemu: fix build error.

Summary
Fix build error.
LD: nuttx
aarch64-none-elf-ld: /home/cuiziwei/vela/happy/nuttx/staging/libarch.a(arm64_initialize.o): in function up_initialize': /home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208: undefined reference to arm64_netinitialize'
/home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208:(.text.up_initialize+0x18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `arm64_netinitialize'
make[1]: *** [Makefile:166: nuttx] Error 1
make: *** [tools/Unix.mk:520: nuttx] Error 2
make: Leaving directory '/home/cuiziwei/vela/happy/nuttx'
Error: ############# build /home/cuiziwei/vela/happy/vendor/qemu/boards/vela/configs/armv8a fail ##############
Impact
Testing

Maybe just add
#if defined(CONFIG_NET) && !defined(CONFIG_NETDEV_LATEINIT)
void arm64_netinitialize(void)
{
  /* TODO: Support net initialize */
}
#endif

to arch/arm64/src/qemu/qemu_boot.c like other arch's under arm64? We can go with a separate file, but let's add !defined(CONFIG_NETDEV_LATEINIT) guard

Don't need since DRIVERS_VIRTIO_NET select NETDEV_LATEINIT automatically, let's close it.


chore: Fix typo in aztec sandbox

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[x] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Can someone merge it, please? Thanks in advance :)


Remove dependency of deploy-kubernetes-alerting-rules towards the rest

This job doesn't require the build to succeed or anything of the sort. As such, we should always run it even if the other stages fail.
Documentation: https://docs.gitlab.com/ee/ci/yaml/#needs

I did it more properly in https://github.com/paritytech/substrate/pull/7887

I did it more properly in https://github.com/paritytech/substrate/pull/7887


Update appointment test to avoid hanging

Purpose

Awaitality is removed and a ballerina loop with sleep is used to wait until the count is over 4.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19360 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19360   +/-   ##
=======================================
  Coverage   15.71%   15.71%
=======================================
  Files          47       47
  Lines        1266     1266
  Branches      197      197
=======================================
  Hits          199      199
  Misses       1054     1054
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8cf8c...87a95b5. Read the comment docs.

Closing since this is tracked by #19426


Improve swift caching tests

Improve caching related tests to make them faster and test the situation
closer to what actually happens during explicit module build. Most
noticable changes are:
* Avoid swift stdlib dependency during the tests to save time
* Use dependency scanner output to construct test cases
* Update old test cases that try to simulate caching from file system
inputs to using only CAS inputs.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

Verified that none of the CAS test show up in the slowest tests anymore (that is longer than 50s).

ping


Add Odysseus Planet Pack for Kopernicus from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of Thomas988, to add Odysseus Planet Pack for Kopernicus to CKAN.
Please direct questions about this pull request to Thomas988.

I don't think this gonna work like this :wink:

#rebuild

#rebuild

Kopernicus itself is in pre-alpha state on github with to real releases.
With multiple-repo support, we could set up a prerelease index for Kopernicus and move the .netkan later to the main repository.

o.k., forget the comment above, Kopernicus has not even binary releases yet, so setting up a prerelease index would not make sense.


feat: support custom default plugins for techdocs

Hey, I just made a Pull Request!

We use a custom image for techdocs, which contains additional mkdocs plugins. Best case for sure would be, that techdocs-core would contain all required plugins, but there will always be a diff with custom images. For sure, those plugins can be added manually to the list of plugins in the mkdocs.yaml, but that's not really user friendly. Instead it would be nice to add custom default plugins to all mkdocs.yaml files.
With this change it is now possible to define custom default plugins which are supported within the custom image:
techdocs:
  generator:
    mkdocs:
      defaultPlugins:
        - section-index

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for this contribution @dschwank, I don't have time right now to review but will take a look later this week
@andrewthauer, if you have time could you look at this one as well?

@awanlin Thanks for the review - I just extended the docs and added a --defaultPlugin argument to the techdocs-cli.

Hi @dschwank, I've reviewed and approved this as it looks good to me but another PR has been submitted that adds support for providing a default MkDocs.yml file which would potentially supersede this change. I've tagged you and one of the TechDocs Owner so we can align on a final solution

@awanlin could you re-open the PR? Thanks a lot!

Thanks @agentbellnorm & @awanlin - I just updated the CLI docs. Let me know what you think!

@agentbellnorm what's next to get this merged in? Do we need @Rugvip to approve as well? Or? This seems like a good feature to get into the next releases so we can get early adopters using it

@agentbellnorm anything else? Or is it ready for merged now? 🚀

@dschwank, Awesome - appreciate your patience! 💯

@ScottGuymer I don't think it will, as defaultPlugins is a string[]. The issue below suggests there is another implementation planned to support what we're after (I have the same need to configure Kroki's FencePrefix consistently for GitHub behaviour parity), although I can't find a reference to an active issue anywhere:
https://github.com/backstage/backstage/pull/18830#issuecomment-1693323755

Hi @asos-robbell, can you please log an issue for this? You've done the ground work to confirm there's no issue yet and will allow us to be able to sort out a potential solution for someone to submit a PR to implement. Thanks in advance!

Hi @awanlin — I've created issue https://github.com/backstage/backstage/issues/20610 for this.


Why disable Skew join optimisation?

[Enter feedback here]
How disabling skew join can be a solution here? the advantage of AQE is to improve performance on join's and other scenario's. What is the point of disabling this feature?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31a75ecd-5ede-8a89-a65c-5c754393866d
Version Independent ID: 944de949-bf77-0177-dd5d-5f8ba1e3448e
Content: Intermittent NullPointerException when AQE is enabled - Azure Databricks
Content Source: databricks/kb/scala/intermittent-nullpointerexception-aqe-enabled.md
Service: azure-databricks
GitHub Login: @mathan1
Microsoft Alias: saperla

Thanks for reaching out! We have assigned the issue to the content author to further review this and provide an update as appropriate.
@mssaperla - Could you please have a look at this request and share your inputs? - Thank you

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The scope of our feedback channel here on GitHub covers specific documentation fixes and this issue is related to the KB. We recommend that you visit the Databricks Knowledge Base to submit your feedback. Because this issue does not relate to documentation, we are closing this issue.
#please-close

#please-close


More footer options like positioning etc

https://www.google.com/chrome/browser/desktop/index.html
For Future Version
The footer on that website has options where you can have bits of the right bits on the left whereas with semantic its a bit more restricted where you can have it centered, left, right but not in different parts at the same time but let me know if I'm wrong and you can do this thanks

Hi @jackttcoms, you can use the grid to position elements.


example request

Can you make an example of how to render shapes i.e squares or circles using dx11 with your crate?

Hmm, I don't think I will add such examples into this repo, and here's the reason: technically, this crate is not something that one can draw shapes, UI elements or any other things with. This crate is neither a graphics library nor a UI library, and will never be one. Instead, this crate egui-directx11, as its name suggests, is a glue between a (relatively) low-level graphics API set, namely Direct3D 11 (informally called DirectX 11), and a high-level UI rendering library, namely egui. If you are not familiar with either of them, this crate is definitely not what you are looking for.
If you just want a crate that takes care of things about rendering 2D shapes or UI elements, you may start from the 2D Rendering or 3D Rendering part on Are we game yet?. If you are creating a game or a graphics application, that may help as well.
If you are using egui and you would like to do some custom drawing, you may check the documentation as well as examples of egui and epaint. The latter is a part of the egui project and handles 2D rendering for egui. You may also check the egui online demo and its source code at egui_demo_lib. Some of the examples in the demo, for example paint_bezier.rs, demonstrate how to do custom 2D drawing using egui and epaint.
If you would like to do rendering stuff directly on the graphics pipeline, you may have to be quite familiar with one of the graphics APIs: OpenGL, Direct3D, Metal or WebGPU. It is not a easy thing to explain how to draw a triangle using one of them without tens of pages talking about programmable pipeline stuff.

alright, i was hoping to be able to draw outside of the egui menu on the winit tab for a small game im making that is just 2d


Segmentation Fault using local variables..

Hi,
I tried using local variables for creating parameter in a2l and while running it gave segmentation fault.
So I want to ask, can we use local variables for creating parameters, or only global variables are valid for using in create parameter.
I am very new to this xcp stuff.  Any help will be appreciated.

Hello,
Sorry, XCPlite does not support automatic local variables yet.
Automatic variables are located on the stackframe of the current block and do not have a constant memory address.
XCPlite only supports dynamic memory addressing for class instances.
Static variables with local scope can be handled by newer CANape versions.
But this is very unusual programing style.


lxc image export : permission denied

# Required information

Distribution:  Ubuntu Core 16 (GNU/Linux 4.4.0-2002-caracalla x86_64)
Distribution version:
The output of "lxc info":
root@GW3000:~# lxc info
config:
core.https_address: '[::]:8443'
api_extensions:

storage_zfs_remove_snapshots

container_host_shutdown_timeout

container_syscall_filtering

auth_pki

container_last_used_at

etag

patch

usb_devices

https_allowed_credentials

image_compression_algorithm

directory_manipulation

container_cpu_time

storage_zfs_use_refquota

storage_lvm_mount_options

network

profile_usedby

container_push

container_exec_recording

certificate_update

container_exec_signal_handling

gpu_devices

container_image_properties

migration_progress

id_map

network_firewall_filtering

network_routes

storage

file_delete

file_append

network_dhcp_expiry

storage_lvm_vg_rename

storage_lvm_thinpool_rename

network_vlan

image_create_aliases

container_stateless_copy

container_only_migration

storage_zfs_clone_copy

unix_device_rename

storage_lvm_use_thinpool

storage_rsync_bwlimit

network_vxlan_interface

storage_btrfs_mount_options

entity_description

image_force_refresh

storage_lvm_lv_resizing
api_status: stable
api_version: "1.0"
auth: trusted
public: false
environment:
addresses:

<IP_ADDRESS>:8443
<IP_ADDRESS>:8443
'[fd42:5443:d291:9bc9::1]:8443'
architectures:
x86_64
i686
certificate: |
-----BEGIN CERTIFICATE-----
MIIFQzCCAyugAwIBAgIQKFfU7M8sUmzgcO5o5zU4NzANBgkqhkiG9w0BAQsFADA1
MRwwGgYDVQQKExNsaW51eGNvbnRhaW5lcnMub3JnMRUwEwYDVQQDDAxyb290QDlU
VExCMDIwHhcNMTcwNjE0MjIwNzM5WhcNMjcwNjEyMjIwNzM5WjA1MRwwGgYDVQQK
ExNsaW51eGNvbnRhaW5lcnMub3JnMRUwEwYDVQQDDAxyb290QDlUVExCMDIwggIi
MA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQD1u8nhMJrn6O83n8AXlb6s6lUD
sz1HD8XIf4Rg8GM2inxG6ZSwqU5OUTLC2G8uf96RQkUeW6gJQiMwQ1wOr1e8Rd3h
Tdya95U4ZGUYGxXEznxRV0bycnU4ap0QInl/Oe1CqgExy/FLGCpZ3BSS6JncDdBe
QYnyH2dE6aq0p27VoQa1wsYmq0wLOXEvAGBwMRmdMsjarsdzbiSBxOgZj4Bb8b4U
1GSBbkyIUsL7xEbjc9V2G8E+1X1LZeNGyX74Ru+Rzd7YZXFCrD7pxWgRY2kicvdx
Kr8WIrSlap4zlet9dxgvex3ITrBrF7H9soNMSXEcHqq51WtmLtLWwcrSHH167mPE
1H95IDBMsJDujuHnWl9CokhFXsorIfiTGcGigM4WHfSwWa3lOd2IHGSMpH7lnTUM
0bKV+txUqaH91WiLMhdJVBdXAmCJcL7uUFSugfyTUIJgT6LjNXbGcNFE+r8Xpemk
sc1uK+b+H2dSEQaiFLOK14XAuCrcIfkRtWzZGNOc2QyfmUA9F5svQBC/GGuJT6NL
09pd1LXRX6o+bGFjmZPv7AKSB6CezWlDN6v+D9EjrbBwnPRnYk4kFZSuNuiO5HWm
ngI8IzP/j5UGeB7J2vutBzlPt2LtvMjTMe7d2h/JgFBjaX6se+LyErV7SfkKwZ5I
OPIcLbEqx2bi1JWqvQIDAQABo08wTTAOBgNVHQ8BAf8EBAMCBaAwEwYDVR0lBAww
CgYIKwYBBQUHAwEwDAYDVR0TAQH/BAIwADAYBgNVHREEETAPggc5VFRMQjAyhwQK
13DIMA0GCSqGSIb3DQEBCwUAA4ICAQAs1r8owQkkCqrmBulyMJ4RNYT0f3/YyH7/
51KGB0sHPSbw/2NhoqXf1oo0yrV5cOUDkQgnEdEGgOM0iwrANiV1r5PSB2ZlCfaO
iZsBY4d2BAPmg33zbRi0X7BlQMLdSat9aeYH8QpPzU7t/nc1fftDePKjmCogkyYO
7L/xSHK8/5PEvzrxJZznIjTjIQlYfgD4wVYUQZUo0Tfe0AVIgw9/MRuhwdvdQeR5
ym4/hfcH872FPQXwm5lWMY7+TVT2VLD6sFkrxN/XCMpJEazX7aMCizZMtdg5dAi/
k9V4Zp1T8nWMOLAHmkjob4uYTpiccufUKyCFFlrKOp5buP2cJSm57lrKZFv3PPm6
m/qAB3ZSzOyvZY5+I9/C5/QKaxWuIkpOTQuGiiu5Xb7g88hHppJYm8hfDWg4JQ4Y
rebTtnV6mXByQi4lum5ilC1ckdMioGZj7ONTeIzcgU6jpMTZulEQfxjQuA2c6UZC
RMR0Bg+GjuBZEX6vDmfqCnu32hI1cLPxeLshaQDkPuxuq9Om5rLpGk0ju8cTWmSA
NmUubn3cBDwKtLA/0Nlp350hifw+HVGyUd6amk9SY/cEVZ5ZtuabVqqjrhHoQ25p
TRNfSdorqs94ttujbdsJWU+/N25VHiCfpXB+SVeKRMN6T55uaHE2T+1cBbhUR1qw
GeiMAbro8w==
-----END CERTIFICATE-----
certificate_fingerprint: afff5250f37365cc9ed2ca278b8added137ec4642ec64e36a8ec0104c606c256
driver: lxc
driver_version: 2.0.8
kernel: Linux
kernel_architecture: x86_64
kernel_version: 4.4.0-2002-caracalla
server: lxd
server_pid: 1605
server_version: "2.15"
storage: dir
storage_version: "1"

Kernel version:
LXC version:
LXD version:
Storage backend in use:

# Issue description
I can pretty much manage every thing with containers and images in my lxd environment, but whenever I want to export image I get "permission denied".  I am pretty much new to the lxd environment.  This is also installed within a Ubuntu Core 16 environment.  So there is no /var/lib/lxd directory as I have seen in other forums.
# Steps to reproduce

root@GW3000:~# lxc image list
+--------+--------------+--------+---------------------------------------------+-----
| ALIAS  | FINGERPRINT  | PUBLIC | DESCRIPTION  |  ARCH  |   SIZE   | UPLOAD DATE  |
+--------+--------------+--------+---------------------------------------------+-----
| vaatC2 | 4afdf7b83ae3 | yes    |    | x86_64 | 655.33MB | Jul 24, 2017 at 4:48pm (UTC) |
+--------+--------------+--------+---------------------------------------------+--------
|              | 8a3b6cc4b594 | no     | ubuntu 14.04 LTS amd64 (release) (20170718) | x86_64 | 120.00MB | Jul 19, 2017 at 5:55pm (UTC) |
+--------+--------------+--------+---------------------------------------------+--------

root@GW3000:~# lxc image export vaatC2
error: open 4afdf7b83ae329e523d1cf4cf632a8286c075dfd0271faa0eeaaceeb12ec5837: permission denied

root@GW3000:~# sudo groupadd lxd
groupadd: cannot lock /etc/group; try again later.

root@GW3000:~# newgrp lxd
newgrp: group 'lxd' does not exist

Information to attach

[ ] any relevant kernel output (dmesg)
[ ] container log (lxc info NAME --show-log)
[ ] main daemon log (cat /var/log/lxd/lxd.log)
[ ] output of the client with --debug
[ ] output of the daemon with --debug

So I think what's going on here is that the snap is prevented to write to /root by apparmor.
That'd be a snapd permission issue. The "home" interface that's used to write to one's home directory doesn't apply to the root user...
You can either use another system to talk to LXD over the network which should work fine.
Or if you need to do it locally, you'll need to create the "lxd" group (use the --extra-users flag), then put an unprivileged user into that group, restart LXD and then run the "lxc image export" command again as that unprivileged user.

Hi @stgraber,
Copying over to another LXD host was exactly what I needed to do and it worked perfectly.  Thanks a lot for your help.   The instructions on your web-site were very clear and worked perfectly.
https://stgraber.org/2016/04/12/lxd-2-0-remote-hosts-and-container-migration-612/

Cool. Closing this issue since it's really an issue with snapd/ubuntu-core file permission handling which LXD can't do a lot about. I did file a bug report about this a few months ago, so there's hope the home interface will eventually cover /root too.


Parameters that should be controlable either by configuration file or by command-line arguments

We have already discussed that we should not just add command-line arguments because we might end up with a very large list, however we must find a way of doing this (command-line arguments included) Here is a list of parameter that may be useful to be able to modify from a user's point of view.

Background subtraction separation from the edge of target extraction region.
Target extraction with as a function of target's fwhm.
Maximum number of targets to be extracted.
DCR timeout

See Issue #102

This issue have become irrelevant. There are improvements to make but keeping this issue open might just be distraction


Create abstraction around conversion facilities

These changes create a thin layer wrapper for conversions between basic types (e.g. std::string, int), allowing to encapsulate all uses of boost::lexical_cast.

Codecov Report
Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (0c7aac9) 80.17% compared to head (07b347e) 80.14%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    80.17%   80.14%   -0.03%
===========================================
  Files          575      577       +2
  Lines        57874    57855      -19
===========================================
- Hits         46399    46367      -32
- Misses       11475    11488      +13

Files
Coverage Δ

ACore/src/Converter.hpp
100.00% <100.00%> (ø)

ACore/src/EcfPortLock.hpp
78.26% <ø> (-0.91%)
:arrow_down:

ACore/src/Extract.cpp
100.00% <100.00%> (ø)

ACore/src/Str.cpp
95.78% <100.00%> (-0.02%)
:arrow_down:

ACore/src/Str.hpp
100.00% <ø> (ø)

ACore/src/TimeSlot.cpp
84.37% <100.00%> (ø)

ACore/src/perf_timer.hpp
100.00% <ø> (ø)

ACore/test/TestCalendar.cpp
90.08% <ø> (-0.05%)
:arrow_down:

ACore/test/TestClassDataMemberInit.cpp
100.00% <ø> (ø)

ACore/test/TestCommandLine.cpp
100.00% <100.00%> (ø)

... and 78 more

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Trying to convert the latest 20H2 Security Baseline

Hey, when I try to convert the latest Security Baseline for 20H2 with the latest BaselineManagement Version 3.1.1 I get the following output:
The GptTmpl.inf file contains an entry 'MACHINE\System\CurrentControlSet\Services\NTDS\Parameters\LdapEnforceChannelBinding' in the Registry section that is an unknown value in the module file
Helpers\SecurityOptionData.psd1.
At C:\Program Files\WindowsPowerShell\Modules\BaselineManagement\3.1.1\Parsers\GPO\Registry.ps1:389 char:9
throw "The GptTmpl.inf file contains an entry '$Key' in the R ...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo          : OperationStopped: (The GptTmpl.inf...ptionData.psd1.:String) [], RuntimeException
FullyQualifiedErrorId : The GptTmpl.inf file contains an entry 'MACHINE\System\CurrentControlSet\Services\NTDS\Parameters\LdapEnforceChannelBinding' in the Registry section that is an unknow
n value in the module file Helpers\SecurityOptionData.psd1.
Maybe this can be added pretty easily.
You can download the Baseline following this link Security Baseline

got the same issue @bjornson09 .. did you find a resolution / workaround?

FYI .. if I remove these two settings from '{GUID}\DomainSysvol\GPO\Machine\microsoft\windows nt\SecEdit\GptTmpl.inf' I am able to compile.
MACHINE\System\CurrentControlSet\Control\SAM\RelaxMinimumPasswordLengthLimits=4,1
MACHINE\Software\Microsoft\Windows\CurrentVersion\Policies\System\Kerberos\Parameters\SupportedEncryptionTypes=4,2147483640

This file is copied from SecurityPolicyDsc so I am opening issues over there to get them implemented.
https://github.com/dsccommunity/SecurityPolicyDsc/issues/167
@closedstack what is the name of the setting that maps to registry key RelaxMinimum...?


INT-2431 Improve 'Dispatcher Has No Subscribers'

Add channel name to MessageDeliveryException
'Dispatcher has no subscribers'.
In a large integration flow, it can be difficult to track
down which subscribable channel has no subscribers.
This commit adds to the message text in the form
[channel:someChannelName]

to the exception message. For example:
"Dispatcher has no subscribers. [channel:myChannel]"

Also
[amqp-channel:someAmqpChannelName]
[jms-channel:someJMSChannelName]

This does not apply to redis-backed channels because
they use a BroadcastingDispatcher, which does not throw
'Dispatcher has no subscribers' exceptions.
@olegz @dturanski

Looks good

BTW, one issue remains - the Redis channel uses a BroadcastingDispatcher and therefore no exception is thrown and the channel silently "eats" the message.
Clearly this an unintentional side-effect of using a BD for that channel.
Unfortunately, there is no getHandlerCount() on the MessageDispatcher.
We could add a constructor that takes a boolean...
public BroadcastingDispatcher(boolean requireSubscribers) {...}

(we'd need two because there's a variant that takes an executor).
wdyt?
Aside from Redis, it is likely an error in 99% of the cases if a BD has zero subscribers but changing that behavior would be a breaking change.
Maybe this could be another candidate for global settings? (pub-sub must have at least 1 subs), as well as adding an attribute on a pub-sub channel directly.
wdyt?

You can't get an NPE in string concatenation, you get "null" concatenated.
However, it's not user friendly, so I have added code to protect against null.

Amazing how much code needed to be touched just to improve a log message. Anyway, LGTM


Right click is not working on linux and Mac OS

I'm trying to edit my event by right click , It's working on windows perfectly but not working on mac or linux.(I have to hold right click and then left click on edit link.) . how can i solve?

Hi, I have the same problem and in mac with the magic mouse or the trackpad i can´t do left click when holding right click.
I try removing preventDefault and now i have to right click, press ESC and then select the option on context menu
It is not a solution but the users can use it.
Do you solve it?

no :(

I solve it with this:
on line 716 (bootstrap-year-calendar.js ) change
$(window).one('mouseup', function() {
to
$(window).click(function() {

Thanks sfaraujo! u save my day!


[samples] (Range) Adding more reference samples

Most of these samples are for the Range interface, though there are couple others that came up.
Range is the most visited ref doc page, so that's why the samples are targeted there. I plan to add more as a future batch.

Docs Build status updates of commit c8018da:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel/excelscript/excelscript.autofilltype.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.range.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.worksheet.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/sample-scripts/excel-scripts.yaml
:white_check_mark:Succeeded

generate-docs/json/excel/snippets.yaml
:white_check_mark:Succeeded

generate-docs/tools/API Coverage Report.csv
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


refactor: optimise s3 driver Stat method costs

Stat makes S3 List calls which are added to the S3 costs.
S3 does not charge for HEAD calls so why not optimise the Stat call with the HEAD call instead of using the List.

Another impact of our "treat it like a filesystem" approach I guess :)
This will make statting a directory into 2 calls instead of 1. Do we know what the proportion of dir vs file stat we do?

Yeah it's a cost optimisation. Maybe we can make this somehow optional🤷♂
I'm aso not forcing this to go in. Just thought of that whilst working on the GCS refactoring which made me look into how things work in the s3 driver.

s3 calls are cheap, I'd say leave it until we rewrite.
One optimization we could make is a hint to stat to say if a file is expected - often stat is called knowing "I need dir info" or "I need file info". But I still think its building on a tower of compromises because we're treating it like a filesystem when it isn't.

s3 calls are cheap, I'd say leave it until we rewrite.

I "know of a privoder" 😉 whose scale certainly don't make "S3 calls cheap" 😄
I'll mark this as a draft in case someone from the community is interested.

I've done no testing on this, but did find it interesting how many places we should really have an IsDir() check and don't.
https://github.com/Jamstah/distribution/commit/d75abdd267d025bd53574f0c3673d68b3ef4afee

I'm going to close this. We can always revisit in the future.


CI: Add macOS and Windows in test

Changes proposed in this PR:

CI now also tested on Windows and macOS
Updated OS in issue templates

@mtshiba

Thank you!

Thank you!


recreation of the connection is not needed anymore?

Hi!
There used to be a step regarding recreatation of the connection in order to negotiate the modified prefixes in local network gateway in a Site 2 Site.
Is this not needed any more?
Br
Patric

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ae745d8-584a-47f6-043a-e761032c6b90
Version Independent ID: 2b604854-feb4-9812-833f-7dd2e2728596
Content: Modify gateway IP address settings: Azure portal - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-modify-local-network-gateway-portal.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thanks for the feedback! We are currently investigating and will update you shortly.

@PatricSten Do you mean recreation of the S2S VPN on Azure side? When you made the change, did you see if this step was required or did the VPN come up?

@PatricSten Any update?

Yes, no need to recreate the connection. When updating the prefix the connection “resets”.
BR
Patric
From: SaiKishor-MSFT @.>
Sent: Saturday, 13 November 2021 09:06
To: MicrosoftDocs/azure-docs @.>
Cc: Patric @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] recreation of the connection is not needed anymore? (Issue #83342)
@PatricStenhttps://github.com/PatricSten Any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/83342#issuecomment-967801985, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJLRL7H5E2R2QAJRUXCMUTLULYL5NANCNFSM5HJI3SIA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@PatricSten Thanks for letting us know. Since this is not required anymore, I will go ahead and close this issue. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Billing: List on AccountsClient returns a JSON String, not an AccountsListPage Object

As in title, List does not return an iterable as documented.
https://github.com/Azure/azure-rest-api-specs/blob/14313ea8bb4807f71b970334262b4e199797a4a1/specification/billing/resource-manager/Microsoft.Billing/stable/2020-05-01/billing.json#L56
Example:

Response
[DEBUG] AzureRM Response for https://management.azure.com/providers/Microsoft.Billing/billingAccounts?api-version=2020-05-01:
HTTP/2.0 200 OK
Api-Supported-Versions: 2018-11-01-preview, 2019-10-01-preview, 2020-05-01, 2020-11-01-privatepreview, 2020-11-01
Cache-Control: no-cache
Content-Type: application/json; charset=utf-8
Date: Fri, 15 Jan 2021 09:52:25 GMT
Expires: -1
Pragma: no-cache
Strict-Transport-Security: max-age=31536000; includeSubDomains
Vary: Accept-Encoding,Accept-Encoding
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
X-Ms-Correlation-Request-Id: cfa569fd-d10b-ca4a-0aec-e94af2517591
X-Ms-Ratelimit-Remaining-Tenant-Reads: 11999
X-Ms-Request-Id: 4fc49343-1144-4445-8a53-3296bdf9f8ef
X-Ms-Routing-Request-Id: UKWEST:20210115T095226Z:4fc49343-1144-4445-8a53-3296bdf9f8ef
X-Ms-Service-Version: 10.6.1474.66

{"value":[{"id":"/providers/Microsoft.Billing/billingAccounts/[REDACTED],”name":"[REDACTED]","properties":{"accountStatus":"Unknown","accountType":"Enterprise","agreementType":"EnterpriseAgreement","billingProfiles":{"hasMoreResults":false},"departments":[{"id":"/providers/Microsoft.Billing/billingAccounts/[REDACTED]/departments/[REDACTED]","name":"[REDACTED]","type":"Microsoft.Billing/departments","properties":{"costCenter":"Engineering","departmentName":"[REDACTED]"}}],"displayName":"[REDACTED]","hasReadAccess":false,"soldTo":{"companyName":"[REDACTED],"country":"US "}},"type":"Microsoft.Billing/billingAccounts"}]}

Hi Jack,
As per standards set by Azure REST API team, this is a valid List response. The iteratable list is enclosed in the "value" object.
{
    "value": [
        {
            "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]",
            "name": "[REDACTED]",
            "properties": {
                "accountStatus": "Unknown",
                "accountType": "Enterprise",
                "agreementType": "EnterpriseAgreement",
                "billingProfiles": {
                    "hasMoreResults": false
                },
                "departments": [
                    {
                        "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]/departments/[REDACTED]",
                        "name": "[REDACTED]",
                        "type": "Microsoft.Billing/departments",
                        "properties": {
                            "costCenter": "Engineering",
                            "departmentName": "[REDACTED]"
                        }
                    }
                ],
                "displayName": "[REDACTED]",
                "hasReadAccess": false,
                "soldTo": {
                    "companyName": "[REDACTED]",
                    "country": "US"
                }
            },
            "type": "Microsoft.Billing/billingAccounts"
        }
    ]
}

A List response of the API would look like
{
    "value": [
        {
            "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]",
            "name": "[REDACTED]",
            "properties": {
                "accountStatus": "Unknown",
                "accountType": "Enterprise",
                "agreementType": "EnterpriseAgreement",
                "billingProfiles": {
                    "hasMoreResults": false
                },
                "departments": [
                    {
                        "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]/departments/[REDACTED]",
                        "name": "[REDACTED]",
                        "type": "Microsoft.Billing/departments",
                        "properties": {
                            "costCenter": "Engineering",
                            "departmentName": "[REDACTED]"
                        }
                    }
                ],
                "displayName": "[REDACTED]",
                "hasReadAccess": false,
                "soldTo": {
                    "companyName": "[REDACTED]",
                    "country": "US"
                }
            },
            "type": "Microsoft.Billing/billingAccounts"
        },
        {
            "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]",
            "name": "[REDACTED]",
            "properties": {
                "accountStatus": "Unknown",
                "accountType": "Enterprise",
                "agreementType": "EnterpriseAgreement",
                "billingProfiles": {
                    "hasMoreResults": false
                },
                "departments": [
                    {
                        "id": "/providers/Microsoft.Billing/billingAccounts/[REDACTED]/departments/[REDACTED]",
                        "name": "[REDACTED]",
                        "type": "Microsoft.Billing/departments",
                        "properties": {
                            "costCenter": "Engineering",
                            "departmentName": "[REDACTED]"
                        }
                    }
                ],
                "displayName": "[REDACTED]",
                "hasReadAccess": false,
                "soldTo": {
                    "companyName": "[REDACTED]",
                    "country": "US"
                }
            },
            "type": "Microsoft.Billing/billingAccounts"
        }
    ]
}


[PE-D][Tester G] Inaccurate error message for add deadline command

Error message here should be that the student id given does not exist, but instead it's invalid date.

Labels: severity.Low type.FunctionalityBug
original: nqt230/ped#2

Fixed by #219.


WARNING:ragas.metrics._faithfulness:No statements were generated from the answer.

The official example to calculate faithfulness on a single sample straight from the website doc doesn't work:
from ragas.llms import LangchainLLMWrapper
from ragas.embeddings import LangchainEmbeddingsWrapper
from langchain_openai import ChatOpenAI
from langchain_openai import OpenAIEmbeddings

evaluator_llm = LangchainLLMWrapper(ChatOpenAI())
evaluator_embeddings = LangchainEmbeddingsWrapper(OpenAIEmbeddings())

# create a Single Turn Sample
from ragas import SingleTurnSample

sample = SingleTurnSample(
        user_input="When was the first super bowl?",
        response="The first superbowl was held on Jan 15, 1967",
        retrieved_contexts=[
            "The First AFL–NFL World Championship Game was an American football game played on January 15, 1967, at the Los Angeles Memorial Coliseum in Los Angeles."
        ]
    )

# Init the metric
from ragas.metrics import Faithfulness
faithfulness_metric = Faithfulness(llm=evaluator_llm)
score = await faithfulness_metric.single_turn_ascore(sample=sample)
print(score)

This results into this warning and nan score:
WARNING:ragas.metrics._faithfulness:No statements were generated from the answer.

What am I missing or doing wrong?

i came across the same bug recently. RAGAS seperates the sentences in the response basis the logic here i.e. if sentence.strip().endswith((".", "。", "!", "！"))
since your response string doesn't contain any of these, an empty response (" ") is being sent to check faithfulness.
try adding one of these sentence splitters (".") to the response to verify.

This sentence splitting logic is actually a bit inconsistent across different metrics. For example:

AnswerCorrectness: if sentence.strip().endswith(".")
Faithfulness: if sentence.strip().endswith((".", "。", "!", "！"))
FactualCorrectness: Does not filter at all.

For me, it is not clear why you need to filter the sentences in the first place, because the sentence_splitter is already doing a good job.
In my use-case, I do not control the generation of the datasets and some ground answers may not contain any identifiers (e.g., ".") at the end of the sentence.
An example that comes to mind is:

Question: "How long do I need to wait?"
Ground Truth Answer: "1 hour"

Thus, I created custom subclass of the metrics and changed the _create_statements() method such that the sentences are no longer filtered (i.e., I removed the if sentence.strip().endswith(".")).
Question: Is there any unexpected behavior which might occur due to this?


Update version: PowerShell <IP_ADDRESS> Use original installer files for <IP_ADDRESS>

Uses files created in #117714

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@stephengillie

Why remove the release notes and AppsAndFeaturesEntries?

We don't normally include the DisplayName and Upgrade Code. Those changes were merged in by a community member, so we're reverting it.

@anamnavi,
Thanks for your help in fixing my error.


Quick Search Polish April 2024

This issue tracks the polish items for Quick Search this iteration.

Remove experimental flag https://github.com/microsoft/vscode/issues/209976
Promote quick search in quick access list https://github.com/microsoft/vscode/issues/209974
Switch link-external to go-to-search codicon https://github.com/microsoft/vscode/issues/209978

hi, did we just miss mention this issue https://github.com/microsoft/vscode/issues/206032 , since it's already merged into main

hi, did we just miss mention this issue #206032 , since it's already merged into main

This can get tracked in the issue that you linked. This is for quick search, which is a different feature than the search panel.


How to configure and install jspm-git in bitbucket repository?

I am new in jspm and jspm-git. I followed the below steps to install the jspm package using jspm-git from bitbucket repository.

I already installed jspm and jspm-git globally in my machine.

I configured the below jspm options in my bitbucket repository's package.json.

"jspm": {
    "registry": "jspm",
    "name": "my-package",
    "registries": {
      "bitbucket": {
        "baseurl"<EMAIL_ADDRESS>        "handler": "jspm-git"
      }
    }
  }

I run the below command to install the above private bitbucket repository in a new application.

jspm install bitbucket:my-accountname/my-reponame.git
After running the above command I got the below error.
err  Repo bitbucket:my-accountname/my-reponame.git not found!
Can you please let me know how to configure and install a private bitbucket repository using jspm-git?

Hi @gokull11, as jspm-git uses Git to clone your repository you could try if the following works for you
git clone<EMAIL_ADDRESS>If that works for you usually jspm-git should also work in case you've some valid semver tagged commit e.g. v1.2.3.
Otherwise you could try to configure jspm-git globally. Honestly I've never tried to store the registry configuration directly in the package.json.
jspm registry create but bucket jspm-git

Thanks for the update subesokun.
Where can I store the config settings in my project, config.js?
I have another doubt. If I have a dependency project which is also a private bitbucket repository of mine, then how to setup this to my current cloned project.
I am very new to this repositories and package management, so I couldn't understand the jspm doc.

Thanks @subesokun. I figured it out about how to configure.


Unresponsive news letter banner

Describe the bug
The news letter banner in the home screen is unresponsive on smaller devices
To Reproduce
Go to home page
Screenshots

Hey @MAVRICK-1 I would like to work on this issue under SSOC

@iSubhamMani duplicate issue #11


Ability to teardown driver by name

https://github.com/qmetry/qaf/blob/3cf1ad13c594eb6dd8f753056fb7bfca5c9bd281/src/com/qmetry/qaf/automation/core/QAFTestBase.java#L171
It is useful to have functionality to teardown driver by name for use cases with more than one driver.

Teardown driver by name
Set driver name blank if it is current driver
need to return  which driver will be used when driver name is blank and getBrowser() called

This commit has broken the driver teardown when we are using multiple devices in a single scenario.
https://github.com/Project-Quantum/Quantum/issues/49
The driver teardown was working fine in the 2.1.12 version. It is failing as the following line of code is returning null:
if(getBaseUrl().equalsIgnoreCase(driverName)){
On analyzing this issue I found that the BaseURL and the other two parameters in stb are set to Null when we use setDriver(String driverName) method to switch drivers.
This is causing the NullPointer on driver quitting.

Thanks for adding this fix immediately.
Is there any tentative date when the next release will be released?