ENH: stats: Studentized Range Distribution

What does this implement/fix?
This adds the Studentized Range distribution, which is commonly used to calculate significance in Tukey's HSD test.
Additional information

• This distribution uses relatively complex double integrals, so the integrands for the CDF, PDF, and moment functions are implemented in Cython to be used as LowLevelCallables.
• The CDF has a simple (single integral) asymptotic approximation that is switched to at large degrees of freedom.
• To mitigate overflow errors, and to avoid using asymptotic approximations for as long as possible, any term that can be logarithmized without causing errors has been.
• Methods that remain as default (_entropy, _ppf) do so for a reason. For example, _entropy fails to integrate as a triple integral and the default _ppf can't (as far as I know) be calculated analytically.
• This distribution has been tested pretty extensively against other implementation, such as those found in R and Statsmodels. Comparison graphs can be found at https://github.com/DominicChm/Studentized-Range-Data
• numpy ufuncs are used for vectorization instead of the decorator @np.vectorize, because - in testing - it roughly halves execution time.
• A script has been included to generate precise data to compare the CDF to. It can be expanded to test other aspects too if it seems reasonable. The data is precomputed and stored as JSON.
TODO:
• Figure out which default tests need to skip studentized_range for slow/warning reasons.

good to get a good implementation of this.
should the cdf go into scipy.special ?

Do the fit tests fail because they don't give good fits or just because of the warning?
In any case, they'll need to be skipped because they're too slow.

With the addition of the _fitstart method:
FAILED scipy/stats/tests/test_fit.py::test_cont_fit[MLE-studentized_range-arg91] - scipy.integrate.quadpack.IntegrationWarning: The maximum number of subdivisions (50) has been achieved.

and without
FAILED scipy/stats/tests/test_fit.py::test_cont_fit[MLE-studentized_range-arg91] - scipy.integrate.quadpack.IntegrationWarning: The occurrence of roundoff error is detected, which prevents

It's still not able to find a fit. I will add it to the failing/unreliable distribution list for test_fit.py.
I've updated the number of distributions again - Another distribution was added in the meantime the negated the update we previously made.

Getting closer! Thoughts on the 32-bit linux issue?
I'm not sure what's going on with the "No module named spicy" errors on the windows builds. I feel like something is not quite right about the way the Cython is set up because when I run a script containing:
from scipy.stats import studentized_range
studentized_range.cdf(2, 2, 2)

twice from Spyder, the second time I get an error:
runfile('/Users/matthaberland/Dropbox/Scipy/studentized_range/table_test.py', wdir='/Users/matthaberland/Dropbox/Scipy/studentized_range')
Traceback (most recent call last):

  File "/Users/matthaberland/Dropbox/Scipy/studentized_range/table_test.py", line 13, in <module>
    studentized_range.cdf(2,2,2)

  File "/Users/matthaberland/Desktop/scipy/scipy/stats/_distn_infrastructure.py", line 1963, in cdf
    place(output, cond, self._cdf(*goodargs))

  File "/Users/matthaberland/Desktop/scipy/scipy/stats/_continuous_distns.py", line 9243, in _cdf
    return ufunc(x, k, df).astype("float64")

  File "/Users/matthaberland/Desktop/scipy/scipy/stats/_continuous_distns.py", line 9226, in _single_cdf
    return integrate.nquad(llc, ranges=ranges, opts=opts)[0]

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 825, in nquad
    return _NQuad(func, ranges, opts, full_output).integrate(*args)

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 879, in integrate
    quad_r = quad(f, low, high, args=args, full_output=self.full_output,

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 351, in quad
    retval = _quad(func, a, b, args, full_output, epsabs, epsrel, limit,

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 465, in _quad
    return _quadpack._qagie(func,bound,infbounds,args,full_output,epsabs,epsrel,limit)

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 879, in integrate
    quad_r = quad(f, low, high, args=args, full_output=self.full_output,

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 351, in quad
    retval = _quad(func, a, b, args, full_output, epsabs, epsrel, limit,

  File "/Users/matthaberland/Desktop/scipy/scipy/integrate/quadpack.py", line 465, in _quad
    return _quadpack._qagie(func,bound,infbounds,args,full_output,epsabs,epsrel,limit)

ValueError: invalid callable given

I know this is fixed by deselecting the "Enable UMR" option in Spyder preferences, but I feel like it shouldn't happen.

> Thoughts on the 32-bit linux issue?
It's a bit bizarre -- the failure essentially says that
np.log(pdf(x...)) != logpdf(x...)

But _logpdf has not been overridden, it is the standard inherited
    def _logpdf(self, x, *args):
        return log(self._pdf(x, *args))

from _distn_infrastructure. It's testing at the endpoints, ppf([0, 1]...), and ends up only evaluating the left tail since the right tail is infinite.
So while the left tail should be 0:
distfn.ppf(0, *args)
Out[78]: 0.0

the test has evaluated it to [-3.31557989e-18]. No leads on this yet, I don't see it happening locally.
> I feel like something is not quite right about the way the Cython is set up because when I run a script containing:

from scipy.stats import studentized_range
studentized_range.cdf(2, 2, 2)

@mdhaber is this on WSL or windows? Trying to recreate and I don't see it on linux or mac (with or without UMR).

@mdhaber is this on WSL or windows? Trying to recreate and I don't see it on linux or mac (with or without UMR).

Windows.

geninvgauss.cdf also uses a cython llc

Hmm, well I also have the same problem with geninvgauss, so perhaps the Windows failures are unrelated. I seem to remember this "No module named scipy" issue before from somewhere else, though... I'll let you know if I think of where it was.

I see it here: https://github.com/scipy/scipy/pull/13727

Yeah I just found that, too. I'll ask.

My suggestion for debugging the doc build is to see if you can find any other failing build_docs with similar output and compare the two. Usually, successful build_docs output is quite different, so I don't think it would be helpful to compare against that.
Another possibility is to temporarily remove all the doc changes and see if the error goes away. It's a shame to use CI resources like that, but I think it is justified because I am completely mystified by this one - and I've debugged a lot of tricky doc issues before. We should make it easier to debug docs locally by:

Ensuring that docs build without errors locally (I have never been able to build docs on Windows, and I always get errors on Mac.)
Making all the doc build artifacts accessible (for example, I think RST files are generated from docstrings, but those RST files are not uploaded as artifacts, so the line numbers sometimes reported in the failure messages are not very useful.)
Making it possible to interact with the CI platform.

so perhaps the Windows CI failures are unrelated. I seem to remember this "No module named scipy" issue before from somewhere else

They are not unrelated, the build failure is caused by this PR:
  building 'scipy.stats._stats' extension
  compiling C sources
  creating build\temp.win-amd64-3.7\Release\scipy\stats
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -Ic:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\numpy\core\include -Ic:\hostedtoolcache\windows\python\3.7.9\x64\include -Ic:\hostedtoolcache\windows\python\3.7.9\x64\include -IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\ATLMFC\include -IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include -IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt -IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE -IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt -IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt /Tcscipy\stats\_stats.c /Fobuild\temp.win-amd64-3.7\Release\scipy\stats\_stats.obj
  Running from SciPy source directory.
  c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\numpy\distutils\system_info.py:838: UserWarning: Specified path c:\hostedtoolcache\windows\python\3.7.9\x64\include\include is invalid.
    return self.get_paths(self.section, key)
  _stats.c
  c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\numpy\core\include\numpy\npy_1_7_deprecated_api.h(14) : Warning Msg: Using deprecated NumPy API, disable it with #define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION
  scipy\stats\_stats.c(4713): warning C4244: 'function': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(5457): warning C4244: '=': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(5884): warning C4244: '=': conversion from 'long' to 'char', possible loss of data
  scipy\stats\_stats.c(6497): warning C4244: 'function': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(8709): warning C4244: 'function': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(10921): warning C4244: 'function': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(13133): warning C4244: 'function': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(16667): warning C4244: '=': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(16679): warning C4244: '=': conversion from '__pyx_t_5numpy_intp_t' to 'long', possible loss of data
  scipy\stats\_stats.c(18901): error C2065: 'M_SQRT1_2': undeclared identifier
  scipy\stats\_stats.c(20305): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
  scipy\stats\_stats.c(20483): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
  error: Command "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -Ic:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\numpy\core\include -Ic:\hostedtoolcache\windows\python\3.7.9\x64\include -Ic:\hostedtoolcache\windows\python\3.7.9\x64\include -IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\ATLMFC\include -IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include -IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt -IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE -IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt -IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um -IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt /Tcscipy\stats\_stats.c /Fobuild\temp.win-amd64-3.7\Release\scipy\stats\_stats.obj" failed with exit status 2
  Building wheel for scipy (PEP 517): finished with status 'error'
  ERROR: Failed building wheel for scipy

See https://github.com/scipy/scipy/issues/13464#issuecomment-808007208 for why the CI logs are confusing.

Thank you @rgommers!

@DominicChm Do you think that this doc build failure is related?
...
reading sources... [100%] tutorial/ndimage .. tutorial/stats/discrete_zipfian

waiting for workers...
/home/circleci/repo/doc/source/tutorial/special.rst:37: WARNING: Exception occurred in plotting special-1
 from /home/circleci/repo/doc/source/tutorial/special.rst:
Traceback (most recent call last):
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/sphinxext/plot_directive.py", line 483, in run_code
    exec(code, ns)
  File "<string>", line 15, in <module>
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/mpl_toolkits/mplot3d/axes3d.py", line 147, in __init__
    "3.4", removal="3.6", message="Axes3D(fig) adding itself "
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/_api/deprecation.py", line 118, in warn_deprecated
    warn_external(warning, category=MatplotlibDeprecationWarning)
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/_api/__init__.py", line 213, in warn_external
    warnings.warn(message, category, stacklevel)
matplotlib._api.deprecation.MatplotlibDeprecationWarning: Axes3D(fig) adding itself to the figure is deprecated since 3.4. Pass the keyword argument auto_add_to_figure=False and use fig.add_axes(ax) to suppress this warning. The default value of auto_add_to_figure will change to False in mpl3.5 and True values will no longer work in 3.6.  This is consistent with other Axes classes.
looking for now-outdated files... none found
pickling environment... done
...

Doc failures look unrelated.

@swallan it's in master. See gh-13755.

The failures are unrelated:
ERROR collecting build/testenv/lib/python3.8/site-packages/scipy/linalg/tests/test_decomp.py _
ImportError while importing test module '/home/vsts/work/1/s/build/testenv/lib/python3.8/site-packages/scipy/linalg/tests/test_decomp.py'.
Hint: make sure your test modules/packages have valid Python names.

Same error is on https://github.com/scipy/scipy/pull/13768

@DominicChm Do you think that this doc build failure is related? This same one has occurred twice now, but I haven't changed anything since it built successfully in b87f239.
...
reading sources... [100%] tutorial/ndimage .. tutorial/stats/discrete_zipfian

waiting for workers...
/home/circleci/repo/doc/source/tutorial/special.rst:37: WARNING: Exception occurred in plotting special-1
 from /home/circleci/repo/doc/source/tutorial/special.rst:
Traceback (most recent call last):
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/sphinxext/plot_directive.py", line 483, in run_code
    exec(code, ns)
  File "<string>", line 15, in <module>
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/mpl_toolkits/mplot3d/axes3d.py", line 147, in __init__
    "3.4", removal="3.6", message="Axes3D(fig) adding itself "
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/_api/deprecation.py", line 118, in warn_deprecated
    warn_external(warning, category=MatplotlibDeprecationWarning)
  File "/home/circleci/repo/venv/lib/python3.7/site-packages/matplotlib/_api/__init__.py", line 213, in warn_external
    warnings.warn(message, category, stacklevel)
matplotlib._api.deprecation.MatplotlibDeprecationWarning: Axes3D(fig) adding itself to the figure is deprecated since 3.4. Pass the keyword argument auto_add_to_figure=False and use fig.add_axes(ax) to suppress this warning. The default value of auto_add_to_figure will change to False in mpl3.5 and True values will no longer work in 3.6.  This is consistent with other Axes classes.
looking for now-outdated files... none found
pickling environment... done
...

I haven't come across that error at all. I think it's related to the examples because exec is present in the trace. It seems to stem from special.rst, which we didn't touch. Looks like an API change in matplotlib is causing it. Is it possible that for some reason sometimes a different (later) version of matplotlib is being used that's incompatible with Scipy? Probably (...?) not related to this PR.

@DominicChm That error was resolved in master -- though now there appears to a be a newer, different, error.

@DominicChm @swallan what is the status on the test failure? I think you mentioned it during our last meeting, and I see it will be challenging to debug, but if worst comes to worst (and you can't replicate locally or on a cloud resource) you can write temporary tests specifically for the purpose of tracking this down. To minimize the use of CI resources, you could even create another (draft!) PR with other tests eliminated, marking it clearly (e.g. like gh-13955) as not to be merged. You can also use the CI skip flags (e.g. see gh-13954, here, and here) in your commit messages to run only the required CI.

@mdhaber  Still working on it. @DominicChm we actually already came across this error: https://github.com/scipy/scipy/pull/13732#issuecomment-807696277
and the fix I think was some variable in the cython that wasn't defined on the system. I don't see that same message happening in the build of the linux test in question that is failing now, though.

I remember that. This looks different, because one of the arrays is empty, but it's worth trying.

@mdhaber I looked into this right after the meeting and came to the conclusion that pdf = distfn.pdf(vals, *args) evaluates to -5.08033623e-18 instead of 0 like it should. As a result, it doesn't get removed as invalid because it's not 0 or infinite and - since a negative number is invalid for log - the error occurs.
At the time, I didn't know what could cause it but it seems @swallan found it's problem with cs.ndtr().

Edit: #13976 I think the phi change fixes things. @DominicChm if you made this change, is it ok to go back?

Yep, let's do it. No idea why ndtr is inaccurate on 32bit only (doubles aren't a different size or anything, are they?) but it seems like the easiest solution is to revert to the custom implementation.

@DominicChm How did it go?

@mdhaber Pretty good! Precomputing the constant reduces runtime by about 30% across the board with negligible changes to accuracy. Here are the results of a couple of test runs I did ("Prev" is results before constant precomputation, "After" is after it's added)
===============CDF=============== (1, 3, 10)
Prev:  0.23510918942128084, 10.6 ms
After: 0.23510918942128084, 7.38 ms

===============PDF=============== (2, 3, 10)
Prev:  0.33257249825231694, 13.3 ms
After: 0.3325724982523168, 8.47 ms

===============MOMENT=============== (3, 3, 10)
Prev:  14.41215689, 4.37 s
After: 14.41215689, 3.1 s

===============PPF=============== (.99, 3, 10)
Prev:  5.270161537068719, 123 ms
After: 5.2701615370687165, 82.9 ms

Awesome!

Should scipy/stats/tests/gen_studentized_range_mpmath_ref.py be renamed to studentized_range_mpmath_ref.py?

We'll just squash merge.

We'll just squash merge, making sure to clean up the single commit message, e.g.:
ENH: stats: add studentized range distribution
Implements pdf, cdf, and moments of the studentized range distribution from their definitions. For speed, integrands are implemented as LowLevelCallables in Cython, and integration is performed using scipy.integrate.nquad. Integrands are logarithmized to avoid over/underflow. Accuracy is checked against tabulated values, R's ptukey, and a straightforward mpmath implementation.

Ok perfect (just don't forget the co-author thingy).

@WarrenWeckesser I'd prefer that you merge this, but if not, I plan to merge tomorrow (given that there are +2 other core developer approvals besides mine).

Ok, sounds like this has a good chance to get merged before branching then, good.

@DominicChm in your follow-up that uses the asymptotic approximation for high df, please use np.clip to keep the CDF on the interval [0, 1]. Warren found a few cases where the integrator goes a tiny bit over.


fix: toggle theme button , hide scrollbar

The toggle button now works fine, also added smooth transition on button hover in header, and hide the scroll bar.

Hi @sandeshkolte I checked the PR and it looks like I got errors:

Although it did hide the scrollbar which is a good thing
Please check

I will check and solve it asap


Restore data in open5gs/mongodb problem using chart open5gs

Hey so i find another problem with restoring data from a persistence volume, first i created a persistence volume, then i change the deployment of open5gs/mongodb storage to /mnt/bitnami/mongodb and finally i tested database with open5gs web ui. When i delete the mongodb pod it should restore the data from the persistence volume and that doesn't happen.

Hi. We currently test the deployments using dynamic persistent volume provisioning .
We install OpenEBS in our kubernetes cluster and set the default storageclass to openebs-hostpath.
However, I don't think it should be different providing an static PV.

Inside mongodb logs it says:
mongodb 16:44:24.52 INFO ==> ** Starting MongoDB setup **
7/2/2022 16:44:24 | mongodb 16:44:24.53 INFO ==> Validating settings in MONGODB_* env vars...
7/2/2022 16:44:24 | mongodb 16:44:24.53 WARN ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
7/2/2022 16:44:24 | mkdir: cannot create directory '/bitnami/mongodb/data': Permission denied

Thanks i used openebs for this


docs: improve Vault plugin catalog entry language

👋 This seeks to fine-tune the language associated with the Vault plugin at https://backstage.io/plugins by...

correcting the grammar in the plugin description
clarifying that the plugin deals with HashiCorp Vault (and not another Vault, such as Ansible Vault)

[X] Added or updated documentation
[X] All your commits have a Signed-off-by line in the message. (more info)

Thanks :tada:


Using on termux

Hello, thanks for this amazing tool.
But how can I use it on termux?
When I tried it on termux, it was requesting that I should connect wifi card. Is this possible on a mobile phone?
Thank you.

Root divise


[BUG] EventGridEvent requires optional Data property

Library name and version
Azure.Messaging.EventGrid 4.22.0
Describe the bug
According to the documentation at https://learn.microsoft.com/en-us/azure/event-grid/event-schema#event-properties, the "Data" property for EventGridEvent is not required. However, when receiving and deserializing EventGridEvent JSON from a webhook without this property, the deserialization process will crash.
Expected behavior
It should be capable of parsing the data even without this optional property.
Actual behavior

Reproduction Steps
        var data = BinaryData.FromString("""
            [
              {
                "id": "123e4567-e89b-12d3-a456-426614174000",
                "eventType": "Generic.Event.Type.Example",
                "subject": "category/123e4567-e89b-12d3-a456-426614174000",
                "dataVersion": "1.0",
                "metadataVersion": "1",
                "eventTime": "2024-02-15T14:30:00+00:00",
                "topic": "/subscriptions/123e4567-e89b-12d3-a456-426614174000/resourceGroups/example-rg/providers/Microsoft.EventGrid/domains/example-domain/topics/example-topic"
              }
            ]
            """);

        var events = EventGridEvent.ParseMany(data);

Environment
No response

Hi @cbotos.  Thank you for reaching out and we regret that you're experiencing difficulties.  The behavior of EventGridEvent is correct; the data element is defined as a required field by the Event Grid REST API specification.
As this appears to be an error in the docs, I've opened #120505 in the MS Learn repository for the doc owners to correct the content.


Improve process heaps counters

RtlQueryProcessDebugInformation doesn't return information about
allocated bytes on segment heap.
Also it doesn't return proper values (allocated/committed) if big (virtual) allocations are
present on standard NT heap.
We are enumerating all heap entries already, so we can count these
statistics on our own.
This way we should show more accurate information for both NT and
segment heaps.

I have tested this only on Win10 (21H2), though I think it should work also on older systems.

it doesn't return proper values (allocated/committed) if big (virtual) allocations are present on standard NT heap.

I could be wrong but very large allocations via HeapAlloc bypass the heap entirely as a performance optimization.

I think it would make much more sense to report just number actual user allocations as that is probably what people may be usually interested in.

It should report all types of blocks because they indicate different types of issues.


Louisl/feature/movie support, closes #243

Followup PR to #243

@louisl could you please work to add small documentation to the README file?

OK, working on the README.

@louisl could you please work to add small documentation to the README file?

Updated in #245

All green now 👍
Thank you @louisl !

@sadok-f Hi I think you merged #244 before merging #245 so the README didn't get updated or are you working on that?


crash on 1.5.3

After fighting bandits (really they surrendered) and capturing them all, when I close the party screen to move on to the "loot" screen, I get this crash shown by BetterExceptionsWindow:

Reasons
Source: EquipBestItem

Method not found: 'Int32 TaleWorlds.Core.ItemModifier.ModifyHorseCharge(Int32)'.

Inner exception
Source: No module

No inner exception was thrown

Callstacks

Protip: Use a debugger like dnSpy or Visual studio to trace the source of error, by stepping the program line by line.
Inner exception callstack:
No inner exception was thrown
Outer exception callstack:
at EquipBestItem.MainViewModel.ItemIndexCalculation(EquipmentElement sourceItem, EquipmentIndex slot)
at EquipBestItem.MainViewModel.GetBetterItemFromSide(MBBindingList`1 itemListVM, EquipmentElement equipmentElement, EquipmentIndex slot, Boolean isCivilian, CharacterObject character)
at EquipBestItem.MainViewModel.RefreshValues()
at EquipBestItem.MainLayer.OnLateUpdate(Single dt)
at TaleWorlds.Engine.Screens.ScreenManager.LateUpdate(Single dt)
at TaleWorlds.Engine.Screens.ScreenManager.Tick_Patch1(Single dt)

Fixed in a patch.


Vulnerability roundup 63: flex-2.6.4: 1 advisory

search, files

[ ] CVE-2019-6293 (nixos-19.03)

Scanned versions: nixos-19.03: 5847485e3ec. May contain false positives.

See also #55386

Closing as nixos 19.03 is no longer supported.

Closing as Nixos 19.03 is no longer supported.


CodeAnalyzer suggestion: Application subclasses must provide activation constructor

Android application type
Classic Xamarin.Android (MonoAndroid12.0, etc.), .NET Android (net7.0-android, etc.)
Affected platform version
All
Description
When subclassing Android.App.Application, the "Activation Constructor" (IntPtr handle, JniHandleOwnership transfer) must also be provided.  Failure to do so will result in runtime errors:
https://github.com/xamarin/xamarin-android/issues/8399
Steps to Reproduce

dotnet new android

Add an Application subclass
[Application]
public class MyApp : Application {
}

run

This will crash, with adb logcat containing:
F mono-rt : [ERROR] FATAL UNHANDLED EXCEPTION: System.NotSupportedException: Unable to activate instance of type MyApp from native handle 0x7ff1f3b468 (key_handle 0x466b26f).

See also the Java Activation documentation:

There are two scenarios in which the (IntPtr, JniHandleOwnership) constructor must be manually provided on a Managed Callable Wrapper subclass:

Android.App.Application is subclassed. Application is special; the default Application constructor will never be invoked, and the (IntPtr, JniHandleOwnership) constructor must instead be provided.

Did you find any workaround?
No response
Relevant log output
No response

PR in progress https://github.com/dotnet/android/pull/9447


Build broken (Gradle version and JAVA updates)

It appears that merging #349 broke our CI builds.
After pushing the new branch "ruleatom_nostring" (based on current master), the CI build immediately fails, see:
https://github.com/alpha-asp/Alpha/actions/runs/3822262718
The error message is:
Could not compile initialization script '/home/runner/.gradle/init.d/build-result-capture.init.gradle'.
> startup failed:
  General error during conversion: Unsupported class file major version 63

According to https://docs.gradle.org/current/userguide/compatibility.html Java 19 is only supported after Gradle version 7.6 while we currently run at 7.3.2 for the CI builds.
Interestingly, the build job for #349 apparently succeeded with the Java 19 run throwing some exceptions but still succeeding:
https://github.com/alpha-asp/Alpha/actions/runs/3668635491/jobs/6201900714
It appears that the currently failing branch tried to start with Java 19 and failed while the CI run for #349 used Gradle caching to obtain the already compiled Gradle build system. Could this have something to do with Gradle's caching?

From the top of my head, I'd say the best and easiest fix for this is to bump the gradle version to 7.6.
I'll take care of that tonight.

Sorry about that. Super weird that #349 did build green.


Images, media Issu

Laravel Version: 5.4.
Voyager Version: ^1.1
PHP Version: 5.6
Database Driver & Version:
MySql

Description:
After launching the app from local to the server all images are not visible. The url of the image is
src="http://mysite.com/storage/users/May2018/Tq4bqKXAHMVGtMt6WNWV.jpg". In my root directory which is /public I do have the /storage directory but it has only .gitignore file.  I've tried APP_URL=http://<IP_ADDRESS>:8000   Doesn't help
APP_URL=http://ubb.st.php-academy.org  Doesn't help
Please help! Thank you!

Steps To Reproduce:

APP_URL needs to be the URL to your site, including port.  Also, your site can't live in a subdirectory (e.g. http://domain.com/path/to/laravel) What's the URL to your site?

The Url to my site is http://ubb.st.php-academy.org.  I've tried http://ubb.st.php-academy.org:8000 also.

I've found out where the files that I have uploaded had been stored. It is storage/app/public/

I've found out where the files that I have uploaded had been stored. It is storage/app/public/

I've found out where the files that I have uploaded had been stored. It is storage/app/public/

Your APP_URL needs to change to the domain (use the commented-out one in your screenshot).  While we're on the topic, .env does NOT use HTML-style comments, so please get rid of that.
By default, Voyager uses Laravel's default public filesystem (config/filesystems.php).  This can be changed, but you might as well understand how it works first.
In short, Laravel will generate links to files at the path of /storage/path/to/file.ext.  Through your web browser's configuration, this will equate to the file at /path/to/laravel/public/storage/path/to/file.ext, where storage is a symlink to /path/to/laravel/storage/app/public.  Please make sure this is the case (if it's not, your Voyager dashboard will have a banner informing you of this.
Laravel knows how to generate links like this because of the "disk" configuration in config/filesystems.php (ref).  This config has a root key which says where to write files to, and a url key which says how to generate URLs.
You're free to change this configuration however you'd like, but check the Laravel docs since Voyager doesn't do anything specific in this regard.

Thank you for your help! This is what I have in filesystems.php
 . But I didn't get the point what needs to be changed in order to make the
the links to the images work. The URL that is generated for the user avatar is http://ubb.st.php-academy.org/storage/users/May2018/ZYnEvsUSwt3WLEfmkMJ6.jpg.
 . I still don't have an idea what am I doing wrong. I appreciate your help!

Laravel Version: 5.4.
Voyager Version: ^1.1
PHP Version: 5.6
Database Driver & Version: MySql
@fletch3555 thank you for your detailed answer,i have same issue at show avatar ,i  try change my config/filesystems.php file
'public' => [
            'driver' => 'local',
            'root' => storage_path('app/public'),
            'url' => env('APP_URL').'/storage/app/public',
            'visibility' => 'public',
        ],

i have chagned the disk -> public -> url  value   env('APP_URL').'/storage' to  env('APP_URL').'/storage/app/public',it works for me


Unexpected position of popper (placement: 'auto').

If free space above or under reference element is not enough, it is expected that popper will be placed to the right or left of the element, but this does not happen.
Example: https://codepen.io/imkremen/pen/YVGxeB

I tried to set "flip.behavior: 'clockwise'" but it does't help. https://codepen.io/imkremen/pen/VbKMrL

So, the problem with the auto placement is derived by the fact that auto will use scrollParent as boundariesElement no matter what you define in the preventOverflow modifier.
I'm going to make it use the boundariesElement of the flip modifier to fix the problem.

@FezVrasta Now I have some misunderstanding about having two "boundariesElement" in different modifiers at the same time.
What I need to expect in this case https://codepen.io/imkremen/pen/PmGBwJ ?

So, there are two boundarisElement because you can decide how each modifier should behave.
You can have the popper to flip when it hits the boundaries of the viewport but have it stay between the boundaries of the scrollParent, or any possible mix you may think of.
Usually the default values are the ones you'd expect.
In your case, you are defining placement: 'top', there isn't enough space on the top, so it flips on the bottom. If you reduce the viewport height until there's no space in both the dimensions, the preventOverflow modifier will move the popper to keep it between the viewport.

@FezVrasta you're example is so helpful, thank you so much 🚀


When non-essential icons are not properly hidden from screen reader users, they can be announced as unrecognized characters.

Is it an issue related to Adaptive Cards?
No.
What is the PWD impact?
No response
What browsers and screen readers do this issue affect?
No response
Are there any code-based customization done to Web Chat?
No, I am using Web Chat without any customizations except "styleOptions".
What version of Web Chat are you using?
Latest production
Which area does this issue affect?
Live region, Transcript navigation
What is the public URL for the website?
https://edfinancial.com
How to reproduce the issue?
This is feedback from the accessibility company Allyant who has been testing our website and has people who use screenreaders and other assistive technologies as a part of their testing team.

What do you expect?
Emoji's are considered non-essential icons and should be hidden from screenreaders.
Hide non-essential icons by moving them into their own , or other inline tag, then giving the  an aria-hidden="true" attribute.
If a non-essential icon is already independently wrapped by an element, instead give this element an aria-hidden="true" attribute. Ensure that no other content is contained within the element wrapping the icon, as doing so may inadvertently or improperly hide the additional content from screen reader users.
What actually happened?
Emoji's are not hidden from screenreaders.
Do you have any screenshots or recordings to repro the issue?
No response
Did you find any DOM elements that might have caused the issue?
No response
MAS reference
No response
WCAG reference
https://www.w3.org/WAI/WCAG22/Understanding/non-text-content
WAI-ARIA reference
No response
Adaptive Card JSON
No response
Additional context
No response

The bot author is using emoji in the suggested actions. Thus, screen reader will read the emoji. This is expected.
Bot author should consider using images in the suggested actions. For details, please refer to https://github.com/Microsoft/botframework-sdk/blob/main/specs/botframework-activity/botframework-activity.md#image. Note, suggested action is a type of card action.


Set gunicorn to track log files

it maybe unnecessary to explicitly use django models to track request object. Need to replace django dev server with production gunicorn and turn on logging.

best in both nginx for frontend and backend


node: Add eventing system to handler

Context: https://radicle.zulipchat.com/#narrow/stream/369277-heartwood/topic/Emitting.20events.20from.20.60node.60

Am I missing something or there's currently no way for the service to emit events that can be subscribed to?

A description in the commit and pull request would be helpful to explain the why and some of the how of the PR.
It would be helpful to others to keep in sync about what's happening even though there may have been discussion out of band.

Search function is your friend. https://radicle.zulipchat.com/#narrow/stream/369277-heartwood/topic/Emitting.20events.20from.20.60node.60

Search function is your friend. https://radicle.zulipchat.com/#narrow/stream/369277-heartwood/topic/Emitting.20events.20from.20.60node.60

That's not good enough though. It helps to have the context where the review is taking place.

also I skipped adding something like wait as that seems more appropriate for a Handle usage vs. in a test.

Can you revert all unnecessary import changes? Then ping me so I can review.

Can you revert all unnecessary import changes? Then ping me so I can review.

Reverted. I briefly discussed this with you, and I've explained why I made the re-formats in this other PR https://github.com/radicle-dev/heartwood/pull/441 . You can close that if you don't find it useful, but personally I find it much easier on the eyes.


Video Player Bug

Whenever I go to watch a video, the autoplay button still appears which makes it look out of place.

Duplicate. Right now replacing the watch metadata HTML is top priority, but this should either come soon after that.


revert: fix(fss): correct config arn and add deployment id

Reverts #1273
Issue #, if available:
Description of changes:
Manually reverts #1273 to use the ARN as the deployment ID for shadow deployments. git revert caused too many conflicts to undo due to all the recent error code changes.
Why is this change necessary:
This revert is necessary because the previous PR changed the format of FSS updates in an incompatible way. The GetDeployment cloud API always returned "in progress" instead of "completed" for completed shadow deployments.
How was this change tested:

[ ] Updated or added new unit tests.
[ ] Updated or added new integration tests.
[ ] Updated or added new end-to-end tests.
[ ] If my code makes a remote network call, it was tested with a proxy.

Any additional information or context required to review the change:
Documentation Checklist:

[ ] Updated the README if applicable.

Compatibility Checklist:

[ ] I confirm that the change is backwards compatible.
[ ] Any modification or deletion of public interfaces does not impact other plugin components.
[ ] For external library version updates, I have reviewed its change logs and Nucleus does not consume
any deprecated method or type.

Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.


Typescript changes

strongly recommend to extend hops-typescript's tsconfig.json
check, that the compilerOptions target- and moduleResolution-properties aren't overwritten by the user
speed up incremental builds by setting transpileOnly and compilerOptions.isolatedModules to true for the dev-server

I'm overall not happy with how the checks are done in the diagnosis()-hook & don't lead to an error. Does anyone have a good idea to improve that?
Also the transpileOnly-feature doesn't lead to compilerOptions.isolatedModules being set to true anymore since this PR, that apparently fixed this issue. Maybe we don't want to enable it either, but I'm not able to decide this now. 😑

To be honest I'm not sure on how isolatedModules behaves in ts-loader. I've used it without webpack only.
But I'm really sure that for example parcel is integrating with typescript that way. But it may have some special side effects with webpack.

I would say, lets try it out. If it does work as we hope/expect it to work, then we are a lot faster than without isolated modules.


Some issues deploying to centos72 VM

A placeholder for now, but I have a reproduction:

I had to download compat resource
I had to remove the yum requirement from iptables

Will post more later

B8N9WpHJ#SSsmoixb> bash <(curl -s https://raw.githubusercontent.com/IshentRas/cookbook-openshift3/master/scripts/origin_deploy.sh)

############################################################
# This installer is suitable for a standalone installation #
# "All in the box" (Master and Node in a server)           #
############################################################

Please enter the FQDN of the server: localhost.localdomain
Please enter the IP of the server (Auto Detect): <IP_ADDRESS>
Please enter the deployment type ([r]pm or [c]ontainer):r

Updating system, please wait...
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
warning: /var/cache/yum/x86_64/7/updates/packages/NetworkManager-team-1.0.6-31.el7_2.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID f4a80eb5: NOKEY
Public key for NetworkManager-team-1.0.6-31.el7_2.x86_64.rpm is not installed
Importing GPG key 0xF4A80EB5:
 Userid     : "CentOS-7 Key (CentOS 7 Official Signing Key<EMAIL_ADDRESS> Fingerprint: 6341 ab27 53d7 8a78 a7c2 7bb1 24c6 a8a7 f4a8 0eb5
 Package    : centos-release-7-2.1511.el7.centos.2.10.x86_64 (@anaconda)
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
Created symlink from /etc/systemd/system/sysinit.target.wants/lvm2-lvmpolld.socket to /usr/lib/systemd/system/lvm2-lvmpolld.socket.

Installing prerequisite packages, please wait...
Thank you for installing Chef!
Starting Chef Client, version 12.13.37
[2016-09-26T18:17:20+00:00] WARN: Run List override has been provided.
[2016-09-26T18:17:20+00:00] WARN: Original Run List: []
[2016-09-26T18:17:20+00:00] WARN: Overridden Run List: [recipe[cookbook-openshift3], recipe[cookbook-openshift3::master], recipe[cookbook-openshift3::node]]
resolving cookbooks for run list: ["cookbook-openshift3", "cookbook-openshift3::master", "cookbook-openshift3::node"]

================================================================================
Error Resolving Cookbooks for Run List:
================================================================================

Missing Cookbooks:
------------------
No such cookbook: compat_resource

Expanded Run List:
------------------
* cookbook-openshift3
* cookbook-openshift3::master
* cookbook-openshift3::node

Platform:
---------
x86_64-linux

Running handlers:
[2016-09-26T18:17:21+00:00] ERROR: Running exception handlers
Running handlers complete
[2016-09-26T18:17:21+00:00] ERROR: Exception handlers complete
Chef Client failed. 0 resources updated in 01 seconds
[2016-09-26T18:17:21+00:00] FATAL: Stacktrace dumped to /root/chef-solo-example/cache/chef-stacktrace.out
[2016-09-26T18:17:21+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2016-09-26T18:17:21+00:00] ERROR: 412 "Precondition Failed"
[2016-09-26T18:17:23+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
/dev/fd/63: line 135: oadm: command not found
/dev/fd/63: line 139: htpasswd: command not found

##### Installation DONE ######
#####                   ######
Your installation of Origin is completed.

A demo user has been created for you.
Password is : 1234

Access the console here : https://console.<IP_ADDRESS>.nip.io:8443/console

You can also login via CLI : oc login -u demo

Next steps for you (To be performed as system:admin --> oc login -u system:admin):

1) Deploy registry -> oadm registry --service-account=registry --credentials=/etc/origin/master/openshift-registry.kubeconfig --config=/etc/origin/master/admin.kubeconfig
2) Deploy router -> oadm router --service-account=router --credentials=/etc/origin/master/openshift-router.kubeconfig
3) Read the documentation : https://docs.openshift.org/latest/welcome/index.html

You should disconnect and reconnect so as to get the benefit of bash-completion on commands

B8N9WpHJ#SSsmoixb> cat /etc/redhat-release
CentOS Linux release 7.2.1511 (Core)

No longer an issue.

I have not fixed that one, I shall have a look very soon :-)

Check this one :https://github.com/IshentRas/cookbook-openshift3/tree/release/1.10.27

@ianmiell Is this still relevant? If not can we close?

I'm not sure I care anymore :)
I will close.


SAN ensemble

Thanks for your great work! Is there any code implementation about "SAN ensemble"(mentioned in Table 2 of the paper) ?

Sorry that I have not prepared a clean code to do that. But you may look at https://gist.github.com/MendelXu/105c7b91ba4b59b75acd488f6304b50f for a reference.
Note that the input is path of a file which contains the command args of different models, like:
--config-file a.yaml MODEL.WEIGHTS ./output/a/model
--config-file b.yaml MODEL.WEIGHTS ./output/b/model

Oh, Thanks!


Azure Notification Hubs SDK v4

Things to consider before you submit the PR:

[ ] Are tests passing locally?
[ ] Are the files formatted correctly?
[ ] Did you add unit tests?
[ ] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description
A few sentences describing the overall goals of the pull request.
Related PRs or issues
List related PRs and other issues.
Misc
Add what's missing, notes on what you tested, additional thoughts or questions.

@marstr this is a huge PR. I don't think there are plans for introduce a new major version at this time. You can keep the branch around, but I recommend closing this PR for now to reduce some noise.


Add use-page config option

The option allows to use a different page for the section page instead
of the first child.

Just saw you comment after my last push, I'm on it :)

I addressed your comments, but I have the feeling that previous_page is now wrong if index_page does not pick the first child. I'll add a test case to be sure.

Oh wow that's a lot of logic now :(
Do you think anyone will actually need the ability to pick index pages from the middle?
The option could just require it to be index.md. Doesn't that completely cover your use case?

Oh wow that's a lot of logic now :(
Do you think anyone will actually need the ability to pick index pages from the middle?
The option could just require it to be index.md. Doesn't that completely cover your use case?

Actually index.md would be more than enough for me. So I'm fine with restricting it to that, but the logic is basically "fix a doubly linked list".
I'd even argue that if there is no index.md the first page should not become the section page by default since it then depends on alphabetical order but there might be use cases for that.

Just thougth about the case where a previous plugin might have reordered items such that index.md is no longer first. This could lead to unexpected results if we just check if the first child is index.md with that option. But we could omit a warning in such a case, but actually moving these element in a doubly linked list seems rather clean to me. But it's on you of course, just my final thoughts on this.
By the way if a plugin reorders children after this plugin results are most likely wrong. We could also omit a warning maybe if popular plugins which could do that are behind this plugin.

The warning is there
https://github.com/oprypin/mkdocs-section-index/blob/7a8b4ac7c87716c2d6a10b672de21d1f5c299bb0/mkdocs_section_index/plugin.py#L53-L56
Though it doesn't detect subtle reorderings. But I think it's not unreasonable to expect the plugins to coexist anyway. Currently all mav reordering plugins I know  rewrite the whole nav.

What's the status on this? Because it fixes #6, which is a very annoying issue for me.

Hmm the status is that I'm a bad human. I didn't follow up on this.
The feature is needed, but I wasn't sure how exactly it should look like.


angulartics-segment exception handling

I understand that that repo isn't being maintained by anyone at the moment, so that is why I'm posting in here.
I added an issue + PR to address the exception handling.
I'm not sure I want to be a maintainer, per se, but I could if need be.
Check out the issue and PR.
Thanks!

Thanks for the merge!


Implement handlers in Fake Broker Server

Right now the update service instance, bind, and unbind handlers in the fake broker server (pkg/brokerapi/openservicebroker/util/fake_broker_server.go) are unimplemented. We need to implement them to sufficiently test the broker client.

@vaikas-google I think this is a necessary follow-up after #415 to ensure that the correct parameters got through to the broker api.

This was addressed by #494 and #500


Pass arguments into runTask

I think it should be possible to pass arguments to runTask
// this.runTask(callbackOrName, timeout, ...args)
this.runTask('myTask', 500, 'foo', 'bar');

I think the idea here was to keep it simple. If you need this functionality, you can use () => {}...

Works for me 😄


Support for Symfony 4

#SymfonyConHackday2017

See #249

hi, you can use my fork until an official merge:
    "require-dev": {
        "knplabs/friendly-contexts": "@dev"
    },
    "repositories": [
      {
        "type": "vcs",
        "url": "https://github.com/aitboudad/FriendlyContexts.git"
      }
    ]

It would be great to figure this out. I didn't know this PR existed so i created a ticket #250.
@aitboudad, could you create a PR and maybe your solution can be merged in?


RevEng: UpdateAction for ForeignKey in SqlServer

At present we read update action for foreign key but we do nothing with it. Perhaps because EF metadata has update & delete as same action and cannot do different things. We should warn users if the values of update & delete actions are different

We currently don't know anything for updates because all keys are immutable. If we make some keys mutable in the future (e.g. alternate keys) we will need this.


Spinner has issues with Fabric v2.0.1 release

Looks like the Fabric v2.0.1 release has negative impacts on the spinner directive. When I ran it, it filled up the entire screen.
I think we should hold off on updating to v2.0.1 until this is resolved.

I'll have a look


Your app is using an unsafe implementation of HostnameVerifier.

We received a security warning "Your app is using an unsafe implementation of HostnameVerifier" from Google Play after submitting a build yesterday. The error seems to be originating in the Braintree Android SDK used by this package.
There is an open issue on the braintree android sdk repo relating to this warning. The maintainer suggested that the latest braintree android sdk v3.14.0 be used.
The current react-native-paypal release v2.2.0 is targeting braintree v2.17.0. At this point it is unclear if updating to v3.14.0 will fix the security issue but the braintree android sdk version in this package ought to be updated anyhow.
When will this package be updated to use the latest braintree android sdk? This is a critical issue for us.
Thanks in advance.

Updating to braintree android sdk v3.14.0 does fix the security issue. When can we expect a new release of this package with the updated sdk?

@shea12 I'm sorry for the horribly slow reply.  Just bumped version to latest master


Wrap review related jobs in ApplicationJob

Why:

ApplicationJob has logic to retry then give up
Avoid re-scheduling jobs infinitely

@gylaz I don't think this is going to work since the services rely on the class name being serialized in Redis. If this change is made I believe the ActiveJob job wrapper class will be used.
https://github.com/thoughtbot/hound-scss/blob/master/lib/jobs/scss_review_job.rb

@salbertson @thorncp You were correct, the services can't handle ActiveJob jobs. What are your thoughts about removing ActiveJob? We are ties to Resque now via the services, so I don't see any wins using ActiveJob.

Closing this for now. Going to look into reverting to just using Resque, or at least retrying Resque jobs properly.


fix donot use int32_t for index id to avoid overflow

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Red Squiggle Line in courses / [...courseId] / page.tsx

@hkirat

I don't see implicit any type on p?

Hey! I've managed to find out the output of the await call


Unable to make authenticated request from asyncData

Steps to reproduce
If I navigate from the login route to the index route - all is good.
If I refresh pages on index route - I get
(node:39141) UnhandledPromiseRejectionWarning: NotAuthenticated: Not authenticated
    at new NotAuthenticated (/Users/sites/feathers/node_modules/@feathersjs/errors/lib/index.js:93:17)

Cookie is stored in feathers-jwt with value eyJhbGciOiJIUzI1NiIsInR5cCI6ImFjY2VzcyJ9.eyJpYXQiOjE1NzM1NDAwNjksImV4cCI6MTU3MzYyNjQ2OSwiYXVkIjoiaHR0cHM6Ly95b3VyZG9tYWluLmNvbSIsImlzcyI6ImZlYXRoZXJzIiwic3ViIjoiMSIsImp0aSI6ImQ2NTVhZGY2LWExOWUtNGM4ZC1hNzZlLWU4NmIzNDYzMzQ2YyJ9.QbB71CG0XGrU_KlUEq-vPgiNdO9om9ASmfesnidZuW4
Not too sure if i'm missing something or if this is not possible in my current setup, if you could point me to an article/docs on how to achieve this. Thanks!
store/index.js
import Vuex from 'vuex'
import Vue from 'vue'
import feathersClient, {BaseModel, makeServicePlugin} from '../feathers-client'
import feathersVuex, { initAuth } from 'feathers-vuex'
const { makeAuthPlugin, FeathersVuex } = feathersVuex(feathersClient);

class User extends BaseModel {
  // required
  constructor (data, options) {
    super(data, options)
  }
  // required
  static modelName = 'User'
}

const usersPlugin = makeServicePlugin({
  Model: User,
  service: feathersClient.service('users')
})

const createStore = () => {
  return new Vuex.Store({
    state: {},
    mutations: {
      increment (state) {
        state.counter++
      }
    },
    actions: {
      nuxtServerInit ({ commit, dispatch, state }, { req }) {
       initAuth({
         req,
         commit,
         module: 'auth'
       }).then(result => {})
      }
    },
    plugins: [
      usersPlugin,
      makeAuthPlugin({
        state: {
          publicPages: [
            'login',
            'signup'
          ]
        }
      })
    ]
  })
};

export default createStore

feathers-client.js
import feathers from '@feathersjs/feathers'
import socketio from '@feathersjs/socketio-client'
import auth from '@feathersjs/authentication-client'

import io from 'socket.io-client'
// import feathersVuex from 'feathers-vuex'
import { CookieStorage } from 'cookie-storage'
import feathersVuex from "feathers-vuex";

const storage = new CookieStorage();
const socket = io('http://localhost:3000', {transports: ['websocket']})

const feathersClient = feathers()
  .configure(socketio(socket))
  .configure(auth({ storage }));

export default feathersClient

// // Setting up feathers-vuex
const { makeAuthPlugin, makeServicePlugin, models, BaseModel} = feathersVuex(
  feathersClient,
  {
    serverAlias: 'api', // optional for working with multiple APIs (this is the default value)
    idField: 'id', // Must match the id field in your database table/collection
    whitelist: ['$regex', '$options']
  }
)

export { makeAuthPlugin, makeServicePlugin, models, BaseModel }

index.vue
<script>
    import {models} from "../feathers-client";

    export default {
        middleware: ['auth'],
        async asyncData() {
            const {data} = await models.api.User.find();
            return {
                users: data
            }
        },
        methods: {
            handleSelect(key, keyPath) {
            }
        },
        data() {
            return {
            }
        }
    }
</script>

Expected behavior
I'd expect when loading on index route to retrieve users data
Actual behavior
(node:39141) UnhandledPromiseRejectionWarning: NotAuthenticated: Not authenticated
    at new NotAuthenticated (/Users/calvinmuller/iStreet/Sites/pacs/node_modules/@feathersjs/errors/lib/index.js:93:17)
    at Object.convert (/Users/calvinmuller/iStreet/Sites/pacs/node_modules/@feathersjs/errors/lib/index.js:239:7)
    at Socket.<anonymous> (/Users/calvinmuller/iStreet/Sites/pacs/node_modules/@feathersjs/transport-commons/lib/client.js:67:34)
    at Socket.module.exports../node_modules/socket.io-client/lib/socket.js.Socket.onack (node_modules/socket.io-client/lib/socket.js:319:0)
    at Socket.module.exports../node_modules/socket.io-client/lib/socket.js.Socket.onpacket (node_modules/socket.io-client/lib/socket.js:244:0)
    at Manager.<anonymous> (/Users/calvinmuller/iStreet/Sites/pacs/node_modules/component-bind/index.js:21:15)
    at Manager.Emitter.emit (/Users/calvinmuller/iStreet/Sites/pacs/node_modules/component-emitter/index.js:133:20)

System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
{
    "@feathersjs/adapter-commons": "^4.3.11",
    "@feathersjs/authentication": "^4.3.11",
    "@feathersjs/authentication-client": "^4.3.11",
    "@feathersjs/authentication-local": "^4.3.11",
    "@feathersjs/authentication-oauth": "^4.3.11",
    "@feathersjs/configuration": "^4.3.11",
    "@feathersjs/errors": "^4.3.11",
    "@feathersjs/express": "^4.3.11",
    "@feathersjs/feathers": "^4.3.11",
    "@feathersjs/rest-client": "^4.3.11",
    "@feathersjs/socketio": "^4.3.11",
    "@feathersjs/socketio-client": "^4.3.11",
    "@feathersjs/transport-commons": "^4.3.11",
    "@nuxtjs/auth": "^4.8.4",
    "@nuxtjs/axios": "^5.8.0",
    "compression": "^1.7.4",
    "cookie-storage": "^5.0.3",
    "cors": "^2.8.5",
    "cross-env": "^5.2.0",
    "element-ui": "^2.4.11",
    "feathers-hooks-common": "^4.20.7",
    "feathers-sequelize": "^6.1.0",
    "feathers-vuex": "^2.2.4",
    "helmet": "^3.21.2",
    "mysql2": "^2.0.0",
    "nuxt": "^2.0.0",
    "sequelize": "^5.21.2",
    "serve-favicon": "^2.5.0",
    "socket.io-client": "^2.3.0",
    "winston": "^3.2.1"
  }

Hi,
why are you using cookie-storage?
Could you try with localStorage?
It seems that the feathers-client doesn't send the jwt in the request.

Hey there, unfortunately localStorage is not something that exists on SSR. I would think it would strip the access token out of the request cookies and push it through to feathers client.

Ok, so look at the network tabs in your developer tools to see if the  jwt is sent in the "Authorization" header.
If it's not you could add it manually in the before hooks of the local auth service.

CookieStorage is recommended for SSR setups where you want to deliver "authenticated data" to the client on page load.  @calvinmuller, you probably need to be sure to call feathersClient.authenticate before you make any server requests.

@calvinmuller - exact same issue I was facing yesterday. I documented a solution for making authenticated requests in SSR setups in this case: #351.

I'm closing this now that we have a full Nuxt example in the docs.  Thanks!


Fix broken documentation links closes #5993

Summary
Fixes broken documentation links closes #5993
Ticket Link
https://github.com/mattermost/docs/issues/5993

Hello @zafar-hussain,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hi @cwarnermm ,
Please check and advice on my PR, related to issue #5993, "Help Wanted: Fix broken documentation links"
If there is any more work to be done, please let me know.
thanks

Hi @cwarnermm,
All the "https://docs.mattermost.com" that were updated by me have been removed.
cheers


DNN-9835: added includeAllTypes=true to ItemListService/GetPages api …

…call

Changes looks good and merged.


Is it possible to have static values in the crawler output?

Example Use:
I am composing a JSON feed as output of the crawler. I want to insert a few values in the output that are just static text. How can this be achieved?
Current Code:
    var stream = x('https://dribbble.com', 'li.group', [{
        title: '.dribbble-img strong',
        link: '.dribbble-link@href',
        image: '.dribbble-img [data-src]@data-src | trim',
    }])
    .paginate('.next_page@href')
    .limit(3)
    .stream();
    stream.pipe(res);

I would like to add a static source value to the feed.
Something like:
source: 'Dribbble',
This part i just want to be static, and not part of the crawler.

+1

Possible workaround:
`var x = Xray({
filters: {
static: function (value, svalue) {
return svalue || value;
}
}
});
var stream = x('https://dribbble.com', 'li.group', [{
source: 'title | static:"Dribbble"',
title: '.dribbble-img strong',
link: '.dribbble-link@href',
image: '.dribbble-img [data-src]@data-src | trim',
}])
.paginate('.next_page@href')
.limit(3)
.stream();
stream.pipe(res);
`

@aamcatamney How to pass a value stored in a variable?
e.g
var x="test";
var stream = x('url', 'selector',[{
              res:x,
             img:'.img-selector'
        }])

@techyrajeev this is untested, but you could try something like this:
var x = Xray({     filters: {         static: function (value, svalue) {             return svalue || value;         }     } }); var staticVal = "test"; var stream = x('https://dribbble.com', 'li.group', [{         source: 'title | static:"' + staticVal +'"',         title: '.dribbble-img strong',         link: '.dribbble-link@href',         image: '.dribbble-img [data-src]@data-src | trim',     }])     .paginate('.next_page@href')     .limit(3)     .stream();     stream.pipe(res);


SyntaxError: Unexpected token ( when using function composition in the REPL

This only affects the REPL, in evaluation mode, using LiveScript 1.2.0 (and master's HEAD).
The problem is mostly related to the following lines: https://github.com/gkz/LiveScript/blob/master/src/command.ls#L267-L269, when running the REPL in evaluation mode (rather than with the --compile flag). It's also more of a JavaScript interoperability problem than a LiveScript problem per-se (the code is complied correctly).
When you type the following code in an evaluation REPL:
f . g

The REPL will compile with LiveScript.compile code, { \eval, +bare }, giving you the following JavaScript, which is then executed in a new VM context:
function() {
  return f(g.apply(this, arguments));
};

Since the above code is executed in a statement context, rather than an expression, the JavaScript grammar expects the function to have a name identifier, and since the above is an invalid FunctionDeclaration, it throws an the aforementioned syntax error (SyntaxError: Unexpected token ( — v8 is really great at error messages).
Interestingly enough, the following piece of code:
(a) -> a

Is compiled, with the same options, to:
(function(a) {
  return a;
});

Avoiding this problem. I'm not sure what the behaviour of the compilation should be here, but this inconsistency in the REPL is fairly odd.

Newer versions seem to compile this to compose$(f, g) so this isn't an issue anymore.


add structurally identical binary trees check

C++ Implementation to find whether 2 binary trees are structurally identical or not.
Hacktoberfest 2021.

@all-contributors please add @sanjitcodes  for his code


cephfs: how to control different ceph users can only access certain directories?

Describe the feature you'd like to have
I found that the dynamically created volume uses the admin credentials(create or mount). If so, how to control different ceph users can only access certain directories? Can we only perform access management on pre-created volumes?
Thank you for your help.

You could create static PVs and refer to a Secret that contains the particular Ceph user/key. See https://github.com/ceph/ceph-csi/blob/devel/docs/static-pvc.md#cephfs-static-pvc for examples. Different PVs can have different Secrets (in different Namespaces if you like).


Remove songs in a room history from suggestion

To deter users listening to the same song all over again, the song-selection algorithm should remove all songs that are in the room history. See #76.

This problem was mostly related to the fact that I accidentally changed the fetch query from 25 results to 5 results to make it respond quicker to newly classified songs. This however caused songs to repeat very often, because the query would just return the same results every time. This was then fixed quickly afterwards (https://github.com/MoodCat/MoodCat.me-Core/commit/c0bf4ca29602347f0f2379cb7d2af435da8702c1). I think we should instead improve on the randomness of our algorithm, and use the room exclusions / vote downs as a mechanism to correct wrong suggestions.

Also keep in mind that there are only 100 songs classified over about 10 moods. There simply isnt so much choice yet.


Throw exception when disable read thread pool and enable late materialization

What problem does this PR solve?
Issue Number: close #7486
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @windtalker @JinheLin @hongyunyan @flowbehappy

/merge


Prepending json version of csv resources causing unexpected behaviour in the frontend

As I understood we're prepending json version of each csv resource in a data package. However, in views property of a descriptor we reference resources using initial indexes. So now our 0 resource is not expected csv file but json version of it.
Questions:

Can we append these json versions in the end of resources? So this way it would work as expected.
What if resource's format is json (or geojson, topojson etc.)?

Re your questions:

I switched the order of resources.
geojson is not a tabular data format as far as I know, and we should probably treat them as binary files (i.e. copy as is from source to package) and not treat them as tabular sources (which are converted to csv and regular json).

@rufuspollock - perhaps we need a third category here, for files that we want to keep both in original form and also extract the data out - although I'm not sure what exactly that process would look like for geojson.

This order switch solves the problem with the first resource only. Indexes for other resources are now i*2, e.g., resource with original index 1 now equals to 2 etc. The solution would be to have all json versions in the end:
// Original:
resources: [csv1, csv2]

// Transformed:
resources: [csv1, csv2, json1, json2]

On the other hand, we could require publishers to always use resource name (now it is either name or index) to reference a resource.

@akariv we should not be adding the JSON version of resources to the resource list IMO. The derived files should:

EITHER: be kept separate from the datapackage.json
OR: be added in a separate section

This is something that probably needs a bit of thought and my inclination would be first option (not included) and we just use a convention to locate them for now. (Amongst other things these are not separate resources taht should should have a separate rendering in the frontend but just a conversion of a given resource to a different format).
Aside: I think we may want _datahub as path rather than .datahub as directory name. What do people think.

@rufuspollock I don't really follow.
Why would we want to use something else than the datapackage, and resort to a convention to locate files instead of using the standard?
Why wouldn't we want to provide these extra files (different formats, validation results etc) as part of the package?

@akariv because the derived stuff is derived. From the presentation PoV these are not "real" resources - but simply different formatting of the original resource. There are different ways to look at this

As a Publisher I want my consumers to get the data in my original data package by default (not all the derived data) so that they can work with it without lots of extraneous info (and in standard way)
As a User I want to clearly distinguish the data package from derived resources so that I can choose what I get and in particular get the original data package easily

As a User viewing a data package I want to see the actual resources in a data package (perhaps along with there derived versions) but without all the other "derived" data files so that I have a clear view on the data in this package

NB: it is important that i can associate a specific derived file with its underlying resource (e.g. so that I can present the JSON version option next to the CSV version in the interface)

As an Admin I want to know the amount of space being used by a given package so that I can report this to the user (and bill based on this)

There are lots of way we could think about implementing this - probably worth a quick chat.

WONTFIX / INVALID. This is now no longer relevant since we switched to "extended" datapackage.json in the pkgstore.


Support for sticky headers

Whenever I'm trying to use KeyboardAwareScrollView with stickyHeaderIndices or KeyboardAwareSectionList with stickySectionHeadersEnabled, I get the following error:
couldn't find key offset in dynamic object

getDouble (ReadableNativeMap.java)

init (ValueAnimatedNode.java:31)

createAnimatedNode (NativeAnimatedNodesManager.java:91)

execute (NativeAnimatedModule.java:204)

...

Everything works as expected with React Native's SectionList and ScrollView. Am I missing something or is it currently not possible to use sticky headers with this library?

+1

Update. This happens on Android only

+1

Same issue

I had the same issue. As I read in the documentation of react-native-keyboard-aware-scroll-view:

First, Android natively has this feature, you can easily enable it by setting windowSoftInputMode in AndroidManifest.xml. Check here.

Since I did not use features such as extraHeight, I used KeyboardAwareSectionList on iOS only and simply imported SectionList on Android.

+1

+1

+1

Silently failing on iOS for me - trying to get a header/footer that remains on top of the keyboard despite the scroll, while maintaining "scroll to input" ability.

+1

give up

give up

Can confirm this solution worked for me

+1

Here is the solution
You need to determine your sticky header and pass it as a prop inside
For example I'm using my custom Container component with sticky header view:
 <KeyboardAwareScrollView
          bounces={false}
          enableOnAndroid
          nestedScrollEnabled={true}
          removeClippedSubviews={false}
          scrollEnabled={scrollEnabled}
          keyboardShouldPersistTaps={keyboardShouldPersistTaps}
          enableResetScrollToCoords={enableResetScrollToCoords}
          showsVerticalScrollIndicator={showsVerticalScrollIndicator}
          stickyHeaderIndices={StickyHeaderComponent ? [0] : undefined}> // here I'm telling that if I'll have some component - display it
          {StickyHeaderComponent ? StickyHeaderComponent : null} // and before all children's will be displayed - I just displaying my sticky header. And as it's the first children - it would be selected as this header.

Inside my place of use:
  <Container
      withSafeArea
      StickyHeaderComponent={<RenderHeader />}>

Hi everyone, my solution like that
<View style={[{position:'absolute',top:positionTop,zIndex:100,right:0,left:0,height:50},Common.backgroundLight]}>
useEffect(() => {
Keyboard.addListener('keyboardDidShow',()=>{
console.log('quillFocus',quillFocus);
if(Platform.OS === "android"){
if(quillFocus){
     setPositionTop(hp(40))
    }
  }
})
if(!quillFocus){
  if(positionTop === hp(40)){
    LayoutAnimation.configureNext({
      duration: 100,
      create: { type: "linear", property: "opacity" },
      update: { type: "linear", property: "opacity" },
      delete: { type: "linear", property: "opacity" }
    });
    setPositionTop(0)
   }
}

return () => {
  // Keyboard.removeAllListeners()
}

}, [quillFocus])

Hi everyone, my solution like that
<View style={[{position:'absolute',top:positionTop,zIndex:100,right:0,left:0,height:50},Common.backgroundLight]}> // wrap header view
useEffect(() => { Keyboard.addListener('keyboardDidShow',()=>{ console.log('quillFocus',quillFocus); if(Platform.OS === "android"){ if(quillFocus){ setPositionTop(hp(40)) } } }) if(!quillFocus){ if(positionTop === hp(40)){ LayoutAnimation.configureNext({ duration: 100, create: { type: "linear", property: "opacity" }, update: { type: "linear", property: "opacity" }, delete: { type: "linear", property: "opacity" } }); setPositionTop(0) } }
return () => {
  // Keyboard.removeAllListeners()
}

}, [quillFocus])

is not clear how to use your useEffect, what is hp? positionTop? quillFocus?


[Site] Responsive Issues in CN Section

Description

The Cloud Native section is not responsive for smaller screens.

Expected Behavior

Fix the responsiveness of the CN section.

Screenshots

Environment:

OS: [Ubuntu]
Browser: [Chrome]

Note

I would love to work on this issue.

Great @NikhilSharma03 🎉

hey @NikhilSharma03 my recent PR fixes this issue.

hey @NikhilSharma03 my recent PR fixes this issue.

Awesome. I will close this issue then.


Update ClusterFuzzLite github->action

Pull Request
Description

Update github->action
Add first test fuzzer file

Type of change

[x] CI system update
[x] Test Coverage update

Testing
Every time there is a push to the main branch, fuzzing analysis will be launched
Test Configuration:

Java: v11
LPVS Release: v1.x.x

Checklist:

[x] My code follows the style guidelines of this project
[ ] My code meets the required code coverage for lines (90% and above)
[ ] My code meets the required code coverage for branches (80% and above)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ce2f7ae) 91.34% compared to head (47a40c9) 91.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #356   +/-   ##
=========================================
  Coverage     91.34%   91.34%
  Complexity      475      475
=========================================
  Files            48       48
  Lines          1606     1606
  Branches        194      194
=========================================
  Hits           1467     1467
  Misses           82       82
  Partials         57       57

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The sampling rate of data is not changing

I'm facing an issue where the sampling rate of the Accelerometer , Gyroscope and the imu data subscription is always set to 13Hz whatever the value i set in the URI
For instance using the Example app which uses 104Hz Mds.createSubscriptionUri(_serial!, "/Meas/Acc/104")
results in readings with Time Stamps where the difference is always approximately 80ms which is 1000/12.5=80
I'm using :
- mdsFlutter : 2.0.0
- mdslib : 3.15.0

Each notification can contain multiple samples to save BLE and processing resources. 13Hz: 1 sample, 26: 2, 52: 4 & >=104Hz: 8
The timestamp meaning is defined in the API definition: https://bitbucket.org/movesense/movesense-device-lib/src/984a71234e37bc66cc312b5aba3100ae9a801d97/MovesenseCoreLib/resources/movesense-api/meas/acc.yaml#lines-116


Rglenn branch

Fixed a few bugs and merged with my pervious branch.

TF code was moved to a new repo

Hi Adrian,
What repo was the TF code moved to? We have a paper that we are working on
publishing and Dr. Fuentes would like me to make sure the code is
available.
Rachel
On Fri, Feb 16, 2024 at 8:40 PM Adrian Celaya @.***>
wrote:

TF code was moved to a new repo
—
Reply to this email directly, view it on GitHub
https://github.com/aecelaya/MIST/pull/8#issuecomment-1949614348, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAGMICSFSYB3IVMZ4MQ6JLYUAKCXAVCNFSM6AAAAAA5DH5NEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGYYTIMZUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


ROS version?

hello, can you tell me the version of ROS? when I catkin_make in ROS melodic, something is wrong...

The simulation branch is tested by Ubuntu16.04 and Ubuntu18.04. And there is only one change between the two versions.
The real-hardware branch is tested by Ubuntu 20.04. Hope this information can help you. Or you can paste your build error.

Thank you so much!
------------------ Original ------------------
From: Mingshan-Beal @.>
Date: Tue,Feb 15,2022 1:25 PM
To: MingshanHe/Admittance-and-Application @.>
Cc: zhengboom @.>, State change @.>
Subject: Re: [MingshanHe/Admittance-and-Application] ROS version? (Issue #3)
The simulation branch is tested by Ubuntu16.04 and Ubuntu18.04. And there is only one change between the two versions.
The real-hardware branch is tested by Ubuntu 20.04. Hope this information can help you. Or you can paste your build error.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you modified the open/close state.Message ID: @.***>


fix: blog

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design
/kind user-interface
/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Minor fixes of blog section
Which issue(s) this PR fixes:
#824

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alexakvelon
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

layouts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 15b8c95bc200d59055afc7ed2dd71d6f662734e8

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexakvelon, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

layouts/OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update CHANGES.txt for 1.33.0

Should we preserve the 1.32.1 entries as well? If I was reading the changelog, I'd expect to see them there even if they were also included in 1.33.0.

Put it this way. the 1.33.0 changes are changes from 1.32.0 not from 1.32.1...

ship it

Add 1.32.2 changes back in...
$ git range-diff ad88294...807d49b
1:  ad88294 ! 1:  807d49b Update CHANGES.txt for 1.33.0
    @@ Commit message
      ## source/CHANGES.txt ##
     @@

    --Changes with Unit 1.32.1                                         26 Mar 2024
     +Changes with Unit 1.33.0                                         17 Sep 2024
    -
    --    *) Bugfix: NJS variables in templates may have incorrect values due to
    --       improper caching.
    ++
     +    *) Feature: make the number of router threads configurable.
    -
    --    *) Bugfix: Wasm application process hangs after receiving restart signal
    --       from the control.
    ++
     +    *) Feature: make the listen(2) backlog configurable.
     +
     +    *) Feature: add Python application factory support.
    @@ source/CHANGES.txt
     +
     +    *) Bugfix: don't create the $runstatedir directory which triggered an
     +       Alpine packaging error.
    ++
    ++
    + Changes with Unit 1.32.1                                         26 Mar 2024

    -
    - Changes with Unit 1.32.0                                         27 Feb 2024
    +     *) Bugfix: NJS variables in templates may have incorrect values due to
     @@ source/CHANGES.txt: Changes with Unit 1.32.0                                         27 Feb 2024

          *) Feature: conditional access logging.


dynamic port

Is it possible to use one port for negotiation and another dynamic (switching within a port range set on server) port for data?

It's logically feasible, but I think that should be unnecessary.one port listening has worked finely for mixed control tunnel and data tunnel communications.What do you think the necessity of the dynamic ports serving?

And I have working at merging the control tunnel into data tunnel, then could reduce one connection between c/s. Another feature fast-open was also in progress, will make the many small request send to server immediately without confirming, will be aware of the fast responding.

As an alternative choice to avoid bandwidth throttling. GFW throttles my traffic (I guess) to proxy server and changing the port helps.
PS: What caused this? error(WSASend tcp <IP_ADDRESS>:1080: An established connection was aborted by the software in your host machine.).

Popularly the bandwidth throttling that was not caused by some special ports or some special  protocols, may be the international link is very busy or your ISP enabled QOS, that will give rise to increasing packet lost rate, then will be aware of the throughput is slow down. But, we could adjust kernel/tcp congestion control algorithm and configuration to make up the lost packets resend as soon as possible, perhaps you will find out a few accelerating solutions in the tcp transmission scheme.
Don't worry about Write edge error that is a normally warning, such as the local connection was closed suddenly but the peer is sending data to the local connection, then will caused that warning.


Black Map With No Pins

I have just done a first time install of the module(v 0.3.3) and of Pin Fixer(v 1.2.2). I followed the instructions and uploaded a .map and its respective .png file. It worked as it seemed it should however I didnt see any pins however I had also noticed that i had the labels visible on the png file and so deleted it as a scene and went back through the settings to import a new one.  Thought i had missed something so i redid it and same thing. Reset foundry, same thing. ReSaved and imported the .map, same thing. Uninstalled and reinstalled both this module and Pin Fixer and saved and exported the map again, still showing nothing but black. Did i break something deeper into the files? All of the rest of my scenes still work fine to not much supprise.

Try ensuring that the scale you set on the map is not above what your GPU can handle. If you're setting the scale to 1 and you still encounter this problem, be sure to let me know. This is a limitation of WebGL where you can only render textures of a certain size, and it's very difficult to render an image of size 20480x11440, for example.


Keyboard Shortcut Help/Reference Page

It would be great if a keyboard shortcut reference page to see all the keyboard shortcuts at once. Gmail currently has "Shift + ?" as that binding and it would be intuitive to use that as well. This will be especially useful if #36 is implemented.

Hitting Shift+? brings up an empty popup.  Guess what else brings up an empty popup? Playlist creation
And guess what browser the keyboard shortcut popup doesn't work on ? Yep, you guessed it, Safari.
So in short, as with #477, this looks to be another shining example of Google's dedication to cross browser compatibility :confused:

@jacobwgillespie Yeah I saw a quick flash but couldn't take a reliable screenshot
@chrismou Google music itself doesn't work on Safari as far as I've experienced. I didn't realize that Radiant Player has similar compatibility as Safari.

@krisdestruction Radiant players web interface is basically safari

@MarshallOfSound Ah good to know...Regardless it'd be great if radiant player had it's own shortcuts page. Might as well override a broken keyboard shortcut page.


I have loose MetaMask accounts I'd like to use with this package, but unable

Because loose accounts aren't generated by your MetaMask mnemonic, I'm not able to use loose accounts imported into MetaMask. Any suggestions as to how to get around this?

You can use this tool:
https://coinomi.com/recovery-phrase-tool.html
Choose Ethereum as your coin, 12 words, use a BIP32 Derivation Path and set it to: m/44'/60'/0'/0
Use the 12 words that are generated with your HDWalletProvider and import the same account into MeteaMask using the private key fro the first generated account in the list at the bottom of the page.


Test lunr changes

https://jira.rax.io/browse/CBS-220

Bug tracker issue check failed: No existing tracker issues found in any commit message
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/process_github_pr_lunr/10/consoleFull

Triggering unit tests...

Running tests with './.unittests'...
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/16/consoleFull
{{{test:started:16}}}

Test suite passed!
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/16/consoleFull
{{{test:complete}}}

Bug tracker issue check failed: No existing tracker issues found in any commit message
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/process_github_pr_lunr/11/consoleFull

Triggering unit tests...

Running tests with './.unittests'...
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/17/consoleFull
{{{test:started:17}}}

Test suite passed!
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/17/consoleFull
{{{test:complete}}}

Bug tracker issue check failed: No existing tracker issues found in any commit message
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/process_github_pr_lunr/12/consoleFull

Triggering unit tests...

Running tests with './.unittests'...
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/18/consoleFull
{{{test:started:18}}}

Test suite passed!
For more details, see: http://<IP_ADDRESS>:8080/jenkins/job/test-lunr-change/18/consoleFull
{{{test:complete}}}


Add myself to project reviewers

Based on https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1:
The following apply to the part of codebase for which one would be a reviewer in an OWNERS file (for repos using the bot).

member for at least 3 months

For a couple of years now

Primary reviewer for at least 5 PRs to the codebase

https://github.com/kubernetes-sigs/descheduler/pull/285
https://github.com/kubernetes-sigs/descheduler/pull/275
https://github.com/kubernetes-sigs/descheduler/pull/267
https://github.com/kubernetes-sigs/descheduler/pull/254
https://github.com/kubernetes-sigs/descheduler/pull/181

Reviewed or merged at least 20 substantial PRs to the codebase

https://github.com/kubernetes-sigs/descheduler/pulls?q=is%3Apr+is%3Aclosed+assignee%3Aingvagabund

Knowledgeable about the codebase

yes

Sponsored by a subproject approver
With no objections from other approvers
Done through PR to update the OWNERS file

this PR

May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

self-nominating

/assign @damemi @aveshagarwal

/approve


getDocValues should provide a MultiReader DocValues abstraction [LUCENE-1789]

When scoring a ValueSourceQuery, the scoring code calls ValueSource.getValues(reader) on each leaf level subreader – so DocValue instances are backed by the individual FieldCache entries of the subreaders – but if Client code were to inadvertently  called getValues() on a MultiReader (or DirectoryReader) they would wind up using the "outer" FieldCache.
Since getValues(IndexReader) returns DocValues, we have an advantage here that we don't have with FieldCache API (which is required to provide direct array access). getValues(IndexReader) could be implimented so that IF some a caller inadvertently passes in a reader with non-null subReaders, getValues could generate a DocValues instance for each of the subReaders, and then wrap them in a composite "MultiDocValues".

Migrated from LUCENE-1789 by Chris M. Hostetter (@hossman), resolved Aug 13 2009
Attachments: LUCENE-1789.patch

This is a duplicate issue to #2864. Please do not update this.


Website Context needs some illustrations

What would you like to be added:
When currently looking at https://ocm.software/docs/context/, the reader is presented with a large amount of text, but no graphics or illustrations. Readability and Comprehensibility would greatly be improved if some graphics, depicting the explanations of the text, were added here and there in the text.
Why is this needed:
Improve readability and comprehensibility.

Done


An example of grafana dashoard  of  usage metrics from ochttp/ocgrpc

Hi !
Opencensus expose metrics like *_bucket with count for each delay bucket and others metrics. And I tried build grafana dash from datasource prometheus on that metrics and not everything went smoothly.
Please give some example dashboard where I will look rate ops/sec  and it will correctly and by pathTagKey too.
Better way if we will starting create one dashboard on exposed metrics for ochttp/ocgrpc

Hello there @antonikonovalov! Thank you filing this issue and welcome to OpenCensus. Firstly sorry for the radio silence, we've been quite swamped.
Great question. So would you mind articulating on what you mean by

Opencensus expose metrics like *_bucket with count for each delay bucket and others metrics. And I tried build grafana dash from datasource prometheus on that metrics and not everything went smoothly.

I just saw this issue and hacked up an end-to-end runnable server using ochttp{Client, Server} like this
main.go
package main

import (
	"io/ioutil"
	"log"
	"math/rand"
	"net/http"
	"net/http/httptest"
	"strings"
	"time"

	"go.opencensus.io/exporter/prometheus"
	"go.opencensus.io/plugin/ochttp"
	"go.opencensus.io/stats/view"
	"go.opencensus.io/trace"
)

func main() {
	trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})

	if err := view.Register(ochttp.DefaultServerViews...); err != nil {
		log.Fatalf("Failed to register ochttp Server views: %v", err)
	}
	if err := view.Register(ochttp.DefaultClientViews...); err != nil {
		log.Fatalf("Failed to register ochttp Client views: %v", err)
	}
        view.SetReportingPeriod(300 * time.Millisecond)

	cst := httptest.NewServer(&ochttp.Handler{
		Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			_, _ = ioutil.ReadAll(r.Body)
			_ = r.Body.Close()
			w.Write([]byte("Pong"))
		}),
	})
	defer cst.Close()

	pe, err := prometheus.NewExporter(prometheus.Options{
		Namespace: "tutorial",
	})
	if err != nil {
		log.Fatalf("Failed to create Prometheus exporter: %v", err)
	}
        view.RegisterExporter(pe)

	go func() {
		mux := http.NewServeMux()
		mux.Handle("/metrics", pe)
		if err := http.ListenAndServe(":8888", mux); err != nil {
			log.Fatalf("Failed to serve Prometheus handler: %v", err)
		}
	}()

	client := &http.Client{Transport: new(ochttp.Transport)}
	for {
		req, _ := http.NewRequest("POST", cst.URL, strings.NewReader("Ping"))
		res, err := client.Do(req)
		if err != nil {
			log.Fatalf("Failed to make http request: %v", err)
		}
		_, _ = ioutil.ReadAll(res.Body)
		_ = res.Body.Close()

		ir := rand.Intn(1000)
		<-time.After(time.Millisecond * time.Duration(ir))
	}
}

prometheus.yaml
global:
  scrape_interval: 5s

  external_labels:
    monitor: 'demo'

scrape_configs:
  - job_name: 'demo'

    scrape_interval: 5s

    static_configs:
      - targets: ['localhost:8888']

Running it
In one terminal, run the main.go code
$ go run main.go

In another terminal start Prometheus
$ prometheus --config.file prometheus.yaml

Start Grafana
brew services start grafana

Walk through

Hope this helps, but really Grafana dashboards are tertiary tools that work with Prometheus, I am not sure if we can include such samples in the Go repository, perhaps the website?

Hello @odeke-em, thank you for the answer and example.

Hope this helps, but really Grafana dashboards are tertiary tools that work with Prometheus, I am not sure if we can include such samples in the Go repository, perhaps the website?

agree with you  - dashboards are tertiary tools
maybe we can collect them here - https://github.com/census-ecosystem

Great question. So would you mind articulating on what you mean by

Excellent! You have all the illustrative examples in the screenshots.
Sorry for simply question, but  what can you understand on the current diagram in the panel?
What benefit can be derived from this metrics?
for me the use of these metrics does not look transparent. Maybe I missed something...
of course, I can find more information for customization and use metrics on an internet.
And maybe we should know why needed a buckets aggregation on that metric and which cases it can be helpful for show critical moments or some tends.
Sorry, maybe that issue sounds like quibbling.
I just want metrics to be more usable out of the box and I should know how  and for what used them.
On that  illustration, I can understand what happened.

There is ongoing work to do this for Graphite here: https://github.com/census-ecosystem/opencensus-go-exporter-graphite/pull/12
I agree that we need it for Prometheus too - I hope it will be similar.


Dependency localization

Implement a way for lib crates to export Fluent files.
The scrapper must find these files, the name must be unique

Basic idea:

Lib crates bundle Fluent files in crate-dir/l10n

Using cargo zng l10n foo/src/**.rs foo/l10n or a new helper.
Support custom path? Not for this release, future can add metadata in Cargo.toml, maybe.
Files automatically included by cargo package/publish.

Bin crates use a new cargo zng l10n --deps/something that uses cargo metadata to get "packages.manifest_path" of each dependency, and from there copy the localization files.

Questions:

File names need to be unique across all dependencies, enforce crate name prefix?

No, "translation crates" that only provide a language for another crate could be a reason to allow any name.
Have cargo zng l10n error for missing file names?
Auto search deps/{crate-name}/ resolving localization files?

Propably this one, also fixes issue of bin crate l10n file name conflict with dependency crate name.

Support l10n!("dir/file/id.atrr")?

Potential conflict with "deps" or whatever we call it (libs?)

Final API:

cargo zng l10n --package=foo OR --manifest-path=foo/Cargo.toml scraps foo/src/**/*.rs to foo/l10n.
--deps copies dependencies to foo/l10n/{lang}?/deps/{dep.name}/{dep.version}/.

cargo zng l10n generated deps dirs have a .gitignore.
Deps dirs in dependencies are merged, {dep}/l10n/deps/ are copied to foo/l10n/deps, copies after all dependencies copied, does not override files, alphabetic order.

l10n! embeds CARGO_PKG_NAME and CARGO_PKG_VERSION, resolver uses it to search for deps dir for nearest version.
Pseudos are an utility, generated from other locales using cargo zng l10n --pseudo*.


Add interleaved iterators to utils

InterleavedIterators wrap n input iterators and returns another iterator that iterates over the elements of each of the input iterators in an interleaved fashion. E.g., if there are two input iterators i and j that iterate over the following vectors:
i: {1,54,3,76,12,65 };
j: {243, 2, 76 };

then an interleaved iterator iterates over the following virtual vector: {1, 243, 54, 2, 3, 76, 76, 12, 65 };

Capturing TODOs from issue #233 :

[ ] finish rename from ChainedIterator to InterleavedIterator
[ ] The ChainedIterator currently implements += and -= as a loop-over ++ and --. The implicit contract for += is that it can skip forward multiple places in O(1) time, otherwise it's like std::forward instead
[ ] Relatedly, the iterator category of the chained iterator / interleaved iterator should be a forward iterator or a bi-directional iterator -- even if it derives exclusively from random access iterators. The reason is item no. 6 directly above this point. (See e.g. also the filteredIterator, which also discards any random access property of the sub-iterator for similar reasons.)
[ ] Alternatively, the implementation of InterleavedIterator could rely on mod and div operations to have it support true (O(1)) random access iteration. However, this only applies for the case where all input iterators it employs are also random access-- otherwise again necessarily the composed iterator cannot be random access.


Dependency questions

I have a few questions.
Which dependencies are needed for:
Building? Excluding linting, testing, minifying
Testing?

Hey there, this issue tracker isn't meant to work as a support forum. These questions tend to be better suited for other venues or can be searched up seperately. Thanks!