.container not scoped ?

Started using this and it is Great!
Only problem I am having is that .container is not getting scoped?
If this a known thing or am I missing something?
 plugins: [
    scopedPreflightStyles({
      isolationStrategy: isolateInsideOfContainer(".my-form"),
    }),
...
]

Hi @yabdab ! I believe isolateForComponents strategy is the one you're looking for. Just import it instead of isolateInsideOfContainer.
See https://github.com/Roman86/tailwindcss-scoped-preflight?tab=readme-ov-file#strategies-overview describing how strategies differ.

No, I still want to isolate inside my specified class.
The problem is, since .container is not protected, the styling from tailwindcss effects the styling of .container from Foundation.
I only want tailwind to style  .container  if it is inside .my-form
Hope that makes sense?

Since I do not use taillwind's .container I decided to just not include that plugin using my config.
module.exports = {
  corePlugins: {
    container: false,
  },
...
}

Although it would have been nice to have .container:where(.my-form,.my-form *) instead.
Otherwise, BIG THANKS to @Roman86 for making this , it works great except for my fringe issue.

it has nothing to do with container option. Maybe don't completely understand. Just try the strategy I mentioned (isolateForComponents) - it isolates Tailwind styles for every element that has specified css selector (your button or common class).

actually if you use isolateInsideOfContainer(".my-form") - then .container outside of .my-form can't be affected by the preflight styles (which is this plugin about), see the picture. BUT - your container is affected by the container plugin, which is unrelated to the preflight styles, but I feel like you (and other users) expect this issue to be addressed as well. I'm thinking about a good way to cover this

Since I do not use taillwind's .container I decided to just not include that plugin using my config.
module.exports = {
  corePlugins: {
    container: false,
  },
...
}

Seems like what you did is the best. That .container selector is hardcoded in the Tailwind's codebase, not configurable. Trying to deal with this particular issue may open a can of worms as more plugins may exist that affect global styles, probably they should be addressed to dedicated tools or postcss plugins


"1.month" does not work correctly

Due to the incorrect subtraction here the expression "1.month" returns a duration of 0 months. As a consequence, this obviously incorrect test passes: assertEquals(Dates.today, 1.month.ago)

Ah sorry it's my fault...thx for your bug report.

Fixed the bug in 0.9.0. Thx!

Hi, it doesn't seem to be fixed. There is still this - 1 in month property in IntExtensions file


incubator/mongodump a chart to backup mongodb 0.0.1

What this PR does / why we need it:
Add a mongodump chart to backup mongodb.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @unguiculus


Add aplication logic

Currently the application does not do anything, please add logic.

Issue complete in #5


Add curl to the base swarm image

Allows running swarm commands using curl from within the container. Makes for a very useful way to test the service status. Adds 2MB to the final image.
Very useful when running Health Checks from Marathon using mesos.
Signed-off-by: Guillermo Rodriguez<EMAIL_ADDRESS>

Note, this is the separation of one of the changes proposed in the PR:
https://github.com/docker/swarm/pull/2067
THis is done so they can be reviewed and merged independently.

need a example to familiar the scene.

@xiaods
Presented the case here:
https://github.com/docker/swarm/issues/1862

LGTM


Compatibility Shopware <IP_ADDRESS>

Hi,
thanks for this great plugin. Sadly it stopped working with <IP_ADDRESS>, or we did something wrong.
Any possibility for an update?
Thanks for your time.

Thanks for your fast response.
I'm trying to investigate in this topic (with my limited knowledge.) I succeeded in importing data with your plugin, but only if the products already exist in shopware.
If i use a csv with entries that don't exist in shopware the following error is reported from the import modul for this item:
Expected command for "Shopware\Core\Content\Product\ProductDefinition" to be "Shopware\Core\Framework\DataAbstractionLayer\Write\Command\UpdateCommand". (Got: Shopware\Core\Framework\DataAbstractionLayer\Write\Command\InsertCommand)
In Shopware <IP_ADDRESS> you can choose in the profile to only "update the data" instead of creating new products for unknown entries in the csv to be imported. I guess it's a new switch, some things in the shopware import/export-behaviour did change during the last updates. Don't know if this is relevant.
Trying my best to find more information... :)

Okay, so which option are you using for the import?

I do use the following options in the profile for import/exports:
Object-Type: product
Use: Import and Export
The switch for "creating new procucts" is off
The switch for "update existing products" is on
Hope this helps.

Okay thanks, for the details, we will try to reproduce and fix.
As the module is free I cannot guarantee a solution time.
If you need it urgently we could plan to tackle this next week for a fee.

Shopware <IP_ADDRESS> includes the same functionality which this module provides, please have a look. This plugin will be discontinued.


url parameter for resize jpeg snapshot

Thanks! Have been reworked a little bit.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.7.0


Format ks output as yaml/json

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

/kind feature
What happened:
There is no CLI option to enable ks to format output as yaml/json.
What you expected to happen:
I'd like to have a CLI option that enables ks to format the output as yaml/json.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

ksonnet version (use ks version):
ksonnet version: 0.12.0
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4
Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:13:03Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.6", GitCommit:"9f8ebd171479bec0ada837d7ee641dec2f8c6dd1", GitTreeState:"clean", BuildDate:"2018-03-21T15:13:31Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Seems not actual. There is '-o' option in ksonnet version 0.12.


Fix possible memory leak in MachOFormat::symtabCommand() method.

The symtabCommand method was exited without releasing the 'symbolTable' pointer.

Nice catch, thanks!


Show keyboard overwrite console history

Hi.
When the console log reach the end of screen (Image 1) and the keyboard being show, the console cursor moves to the center of the screen (Image 2) and stay here even when the keyboard is hidden. If a new command is executed the history  being rewritted (Image 3 and 4).
The expected behavior is for the console history to scroll up, along with the keyboard.
Image 1:

Image 2:

Image 3:

Image 4:

Hi.
Currently I'm having the same problem, but I may also have a solution for this...
When using standard views(I haven't ever tested with custom ones), Linear Layout takes exactly as much space as is available, and the keyboard is included in this space, to constrast with Relative Layout, which isn't influenced by the virtual keyboard's occupied space.
So you could try to put this complete RelativeLayout into a LinearLayout with weight 1, maybe it helps!
Good luck!

In the version 1.9.2 this not occurs. The log scrolls when the keyboard is displayed.


Fix autest for OpenSSL 3.0

Fix forward-non-http autest for OpenSSL 3.0
Fix tls-verify-override autest for OpenSSL 3.0
Fix tls_client_versions autest with OpenSSL 3.0

@midchildan : I resolved conflicts for tests/gold_tests/tls/test-nc-s_client.sh. Can you please verify that they look correct?
Thank you for addressing these OpenSSL 3.0 issues.

[approve ci cmake]


Fix scroll bug in OnyxNavBar mobile mode when you have too many NavItems

[x] When we have too many nav buttons in mobile mode of the nav bar and the screen is not high enough a scrollbar should appear.
[x] add 2rem to max width of mobile nav items
[x] Adjust mobile context menu to be able to scroll

[x] app version changes: same optics as nav items (just not clickable).
[x] Fix duplicate border in mobile context menu
[x] Screenshot test is missing -> https://github.com/SchwarzIT/onyx/pull/1540
[x] create UX "adjust" ticket for the mobile app version

#1552

[x] fix mobile nav parent highlighting

[x] parent is hidden if parent is not clickable -> add storybook example
[x] in the drilled-down level, the parent should not be highlighted if a child is active

For review, show

overflowing menu content

open menu: it now scrolls with many nav buttons
open "Item 2": it scrolls with many nav items/children
open context menu: it scrolls + the app version is not sticky anymore

updated Storybook example

Item 2 is not highlighted when opened, only its active child is highlighted
Item 3 is hidden when opened


Refactor AD MPCC

Related issues

Closes #

Checklist

[ ] I am following the contributing guidelines

[ ] Tests are passing

[ ] Lint workflow is passing

[ ] Docs were updated and workflow is passing

This is mainly taking care of the sparse Hessian, and refactor


Update to use jll artifact

uses jll build by https://github.com/JuliaPackaging/Yggdrasil/tree/master/L/LibSpatialIndex

requires Julia v1.3
artifact is located at https://github.com/JuliaBinaryWrappers/LibSpatialIndex_jll.jl

https://github.com/JuliaGeo/LibSpatialIndexBuilder not used anymore

This is great, thanks!
@visr I am fine with archiving the other repo.


Classical Producer Consumer Problem

This is the classical Producer Consumer problem in Operating System implemented using Semaphores and Multithreading in Java.

@Parshwa52 please provide proper indentation.

I have performed all the changes given.
@dubesar


Alewis/test routes toml

Sorry this is a lot, but the high level overview is that this PR adds an enum, DeployTarget, and a function deploy_target to Manifest that extracts the relevant deploy information from the manifest in preparation for publishing.
This PR covers adding unit tests for pulling deploy targets from the top level of a wrangler toml. There are helper methods added here, also, for things like getting the worker name from the manifest, and lots and lots of test suite helpers.

closing to consolidate with other related PRs. stay tuned.


Package dependency Azure.Identity with high vulnerability

Describe the bug
Hi,
as per the description in the object, when the package is installed, it brings as a dependency version 1.7.0 of Azure.Identity which has a strong vulnerability up to version 1.10.2 , as also reported in the link:
https://github.com/advisories/GHSA-5mfx-4wcx-rv27
and also on nuget.org:
https://www.nuget.org/packages/Azure.Identity/1.7.0

If you update the Azure.Identity library to the latest version, are there any breaking changes?

@pampua84 What have you tried? In addition, this will be fixed in 5.2 preview 4

Hi @ErikEJ,
I was actually running a vulnerability test for packages installed on a project via the command:

dotnet list package --vulnerable --include-transitive

I see that Microsoft.Data.SqlClient 5.1.1 supports any version later than >= 1.7.0, of Azure.Identity, so updating it shouldn't cause any problems. Right?

Correct

Closing as a duplicate of #2181.


[9.x] Add tests for custom phpunit assertions

There are some custom phpunit assertion that have no tests for themselves apart from being used and working, this PR adds some tests to explicitly test that the assertions behave correctly.

I think it's OK.


Nodejs 12.0 support

I'm no C++ pro hope this works, all tests passed

Thanks @Smoozilla
If you can give me a bit of time, I will rather upgrade to N-API directly. Then we can drop the NAN dependency entirely.

Yes that sounds much better, thanks for all your contributions!

Thanks @Smoozilla you too.

@jorangreef I'm considering attempting this, figured I'd give you a heads up in case you already were working on it

@jorangreef I'm considering attempting this, figured I'd give you a heads up in case you already were working on it

I instead improved the rust port from your examples and have it running via wasm. Thank you for everything!


Tags for user provided services

What Need Does It Address?
Tracker Story
In this PR we are adding support for setting tags on user provided service instances. The support for this functionality at the API level has already been merged in Cloud Controller (See PR).
Why Should This Be In Core?
This makes user provided service instances consistent with managed service instances.
Description of the Change
The create-user-provided-service and update-user-provided-service now have a -t flag that allows the user to pass in tags as paramaters to the request that will be sent from the CLI to the API.
Service API (SAPI)
@ablease  & @lurraca

We saw this is failing in Travis, we are investigating!


Query: Enumerable.Contains() with byte arrays

We found while working on caching of FromSql() queries that we are special casing byte arrays so we skip structural comparisons for byte arrays (and also strings and object arrays) when comparing query cache entries. This probably because normally we treat byte arrays as a primitive type throughout our stack but for the case of using a byte array with Enumerable.Contains() each element in the byte array will become a literal in the SQL so we should consider it a different cache entry.
We should also understand if this can be a scenario for strings and object arrays.
A potential fix would be to swap to an approach that special cases Enumerable.Contains() so that we account for the fact that its first argument will not be parameterized.
cc @mikary @anpete

@anpete @mikary could you please check what is the impact of the bug? I wonder if subsequent queries will just reuse the SQL from the first query, returning incorrect results or if it is something more benign.

Attempted to produce a false positive on the caching and it appears we client eval contains with byte arrays
            using (var context = CreateContext())
            {
                var x = new byte[] { 1, 2, 3 };

                var first = context.Orders.Where(o => x.Contains<byte>((byte)o.OrderID)).ToList();

                x = new byte[] { 4, 5, 6 };

                first = context.Orders.Where(o => x.Contains<byte>((byte)o.OrderID)).ToList();
            }

SELECT [o].[OrderID], [o].[CustomerID], [o].[EmployeeID], [o].[OrderDate]
FROM [Orders] AS [o]

SELECT [o].[OrderID], [o].[CustomerID], [o].[EmployeeID], [o].[OrderDate]
FROM [Orders] AS [o]

The same operation with an int array produces two different cache entries:
            using (var context = CreateContext())
            {
                var x = new int[] { 1, 2, 3 };

                var first = context.Orders.Where(o => x.Contains<int>((int)o.OrderID)).ToList();

                x = new int[] { 4, 5, 6 };

                first = context.Orders.Where(o => x.Contains<int>((int)o.OrderID)).ToList();
            }

SELECT [o].[OrderID], [o].[CustomerID], [o].[EmployeeID], [o].[OrderDate]
FROM [Orders] AS [o]
WHERE [o].[OrderID] IN (1, 2, 3)

SELECT [o].[OrderID], [o].[CustomerID], [o].[EmployeeID], [o].[OrderDate]
FROM [Orders] AS [o]
WHERE [o].[OrderID] IN (4, 5, 6)

Opened #4605 to track caching and cache pollution aspect of this issue.
Updating this issue to address byte array client evaluation.


You can bypass info requirements?

On the download page for cset it asks for a few pieces of information such as organization type or NAICS Code. The download button at the bottom cannot be interacted with until this information is provided.
HOWEVER if you simply go into inspect element and locate the portion of code for the button, you can just change the word "disabled" to "enabled."
This lets you download it without giving any of the required information.

This issue has been fixed. Also, the CISA download site is no longer in use.


🐛 [Mealie] Mealie pulling Nightly, not the latest release version

Description
The latest Mealie update has pulled the Nightly rather than V1.12.0
https://github.com/alexbelgium/hassio-addons/commit/a63794a23b268464a187b83eb543f58ec07f98ea
This addon has been doing nightlies for a while, but the latest nightly is the V2 beta which has major breaking changes, is not fully tested.  The official Mealie integration for HA has not yet been updated to support this so will break, along with existing rest based implementations.
I'm not sure if this can be reverted as there are DB changes but can the build for this be fixed to pick up the latest prod release rather than the nightly to avoid this scenario in future?
Reproduction steps
Install latest add-on
Look at the version within the Mealie web UI which says Nightly, not V1.12.0

Addon Logs
No errors in logs.

Architecture
amd64
OS
HAos

Thanks, I'll revert to latest tag but then likely all installations will break down

Thanks for quickly changing this, yes it's not ideal for those that have updated already but at least it will stop the majority having issues.

Thanks for having raised it, I've added a comment in the changelog hopefully it will help

Hi, looks like database is stored in a separate container and not mealie's. This means that people likely won't have backups. I fear that now that people's database have moved to v2 we will be stuck with it...

Mealie has its own backup system for its data, which you have to download and store it somewhere, but unless you have a working Mealie instance you won't be able to get back in to restore it.
The nightly builds could break things at any time so latest is the way to go forwards but if we revert to nightly now then approx 1500 users of the Mealie integration will have that breaking until at least the next HA release.

Indeed this is quite inconvenient, as the users of the addon will likely have anyway to reset their databases if they don't have performed such a backup. I will describe a manual way to restore the backup but it is something needing to go into the system files and could be complex for this number of users
There was 1030 unique downloads since last update so this should reflect at +/-20% the amount of users impacted

@alexbelgium Does that mean that I can not fix it if I have no backup from weeks ago? Or is it enough to create a mealie backup now (from the 2.0 version in 1.12.0) and restore it in the old version (1.2 in 1.12.0-2).

Hi @andrew-codechimp, it is still a bit the chaos with the whole mealie downgrade situation as I understand that the latest 1.2.0-2 addon was pushed using a nightly 1.2.0 database version that is not the same as the current latest image.
I then propose to migrate back to the nightlies tag, so it would work for all users : people on 1.2.0-* would upgrade, and people that had already updated would have a working version.
What do you think ?

Hi Alex, the 2024.9 release of Home Assistant added support for 2.0 DB version as well as 1.2 so you can go ahead and update the container to use the nightlies.
Can I suggest that once 2.x of Mealie is fully released you change back to the Latest tag to avoid this happening in future, should a major breaking change enters the nightly releases, that way we will get a chance to make the changes with the integration (hopefully not that often!)

Thanks for the feedback. Do you know if a 2.0 backup can be restored to a 1.2 version? To see if it is worth duplicating the add-on with a latest tag for people who want to stay in 1.2

No it's not possible to restore a 2.0 db to 1.2
The 2.0 nightly seems pretty stable and the new feature doesn't get in the way if you don't need it so I'd say most people wouldn't care about updating to the nightly now the integration works with it.

Thanks, then 2.0 it is

Hi @alexbelgium version 2.0 has now been released and this is what you get when you pull the :latest image, which is the same as the nightly was as far as breaking changes.
Can you now change your docker to pull :latest so that if a future nightly is released with breaking changes we have time to fix the integration.
I have a specific non-addon instance I run from nightly for testing the integration so I'll see future changes coming before it reaches a latest release.

Thanks very much! I've adapted it and it should start pulling latest as soon as tomorrow


Building Docker Alpine:3.7

Hi all,
I'm trying to build the project using Docker with an image based in Alpine3.7.
here is the Dockerfile
FROM alpine:3.7 as builder
LABEL Name=td-builer Version=0.0.1

RUN apk update
RUN apk add --update alpine-sdk
RUN apk add --update openssl-dev
RUN apk add --update cmake
RUN apk add --update gperf
RUN apk add --update zlib-dev

WORKDIR /
COPY ./td /td

WORKDIR /td
RUN mkdir build
WORKDIR build
RUN cmake ..
RUN cmake --build .
RUN cmake --build . --target install

I get the following error
[  5%] Building CXX object tdutils/CMakeFiles/tdutils.dir/td/utils/port/Stat.cpp.o
/td/tdutils/td/utils/port/Stat.cpp: In function 'td::Stat td::detail::from_native_stat(const stat&)':
/td/tdutils/td/utils/port/Stat.cpp:54:55: error: 'const struct stat' has no member named 'st_mtimensec'; did you mean 'st_mtim'?
   res.mtime_nsec_ = buf.st_mtime *<PHONE_NUMBER>ll + buf.st_mtimensec;
                                                       ^~~~~~~~~~~~
/td/tdutils/td/utils/port/Stat.cpp:55:55: error: 'const struct stat' has no member named 'st_atimensec'; did you mean 'st_atim'?
   res.atime_nsec_ = buf.st_atime *<PHONE_NUMBER>ll + buf.st_atimensec;
                                                       ^~~~~~~~~~~~
make[2]: *** [tdutils/CMakeFiles/tdutils.dir/build.make:255: tdutils/CMakeFiles/tdutils.dir/td/utils/port/Stat.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:556: tdutils/CMakeFiles/tdutils.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

I've found related issues in other projects
httpuv/issues/63
but I can't figure out how to apply it to this one.
Thank you!

I think that this issue can be closed.

You can reopen this report :) @levlam Not yet fixed
https://github.com/isopen/docker/issues/2

The issue should be fixed in TDLib 1.2.0.


(#11767) updated youtube video for 23ai and few screens replaced

Update to ws1 Install Oracle Database 23ai on OCI Compute
Added Juan Loaiza's video on 23ai to the intro lab
Modified screenshots to replace 23c with 23ai; correct path for Oracle home
Updated contributors
~mg

Thanks for quick merge!


Update Dockerfile to force Yarn 1.22.19

Yarn behaviour had changed at some point in the subsequent releases, so we have to force a global version of 1.22.19 (the last working version) to avoid braking our builds. Further investigation should be made as Yarn continues to upgrade its global version (as of typing, 1.22.21 https://github.com/yarnpkg/yarn/releases )

Good find!


Reorganize the contribution guidelines

This commit tries to remove as much redundancy from the text as possible.
General implementation requirements, Nim specifics and PR requirements are now separated.
Order within sections follows point importance or the required code structure within modules.
Added the Table Of Contents.
Added links to external documentation.
Almost everything is in a list now. Lists use identical styling.

Git diff for prose is not very good (it sucks). Most deletions are in fact text movements, but many deletions were made where I found repetition.

GitHub supports footnotes and it rendered this one fine. Do we care to be pure-markdown-compliant?
https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/

I am totally ok. I thought it did not render, but the truth is that I used the markdown renderer from VS Code.
Please revert it! There were two grammar/style suggestions that I wanted to make yesterday, but the suggestion tool was buggy yesterday.
The document is very well structured and pleasant to read.

I've integrated all the suggestion.
Sorry for a bit of a mess with git.

Thanks, I could not merged it with this last commit. Thanks!


Misc changes.

Adjust portal jvm memory size
Retry if client get empty response from meta server
Fix potential npe issues

Coverage decreased (-0.03%) to 44.31% when pulling 90c85d3e143a888c59ed76fcffb8a5a6ed28fb8d on nobodyiam:misc-change-merge into a0308f8dd369f8701bc3326aa960f5395877903d on ctripcorp:master.


Update Composer dependencies (2022-08-29-00-04)

Visual regression test passed!
View the visual regression test report


laravel-echo-server: command not found

I have installed laravel-echo-server globally using
$   npm install -g laravel-echo-server
but, it gives error laravel-echo-server: command not found in laravel project
when run $   laravel-echo-server init

what happens if you try to install it localy?
Do you find it local folder? ./node_modules/.bin/laravel-echo-server

I have also installed locally, not any issue at installation time and I find it in ./node_modules/.bin/laravel-echo-server

what happens if you try to install it localy?
Do you find it local folder? ./node_modules/.bin/laravel-echo-server

I have also installed locally, not any issue at installation time and I find it in ./node_modules/.bin/laravel-echo-server

Try:
npx laravel-echo-server init

Other command
 npx laravel-echo-server start
And so on

@Landish exactly what I was looking for. Thanks

wow thank you so much. i love human


changefeedccl: limit outstanding export request concurrency

PR: https://github.com/cockroachdb/cockroach/pull/27612
From release notes:

CHANGEFEEDs no longer hold all data for each poll in memory at once, increasing scalability. [#27612][#27612] {% comment %}doc{% endcomment %}

No CDC updated needed.


Default to $HOME/go if original GOPATH is empty

Fixes #35

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   57.57%   57.57%
=======================================
  Files          27       27
  Lines         719      719
=======================================
  Hits          414      414
  Misses        200      200
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fda430...d24c3e1. Read the comment docs.


Is the vue ui easily extracted from this project?

What problem does this feature solve?
Extending other cli's with a feature rich gui, with just a few config files.
What does the proposed API look like?
Not sure yet, but I'd like to start a discussion!

Well, now there's https://github.com/Akryum/guijs, please check it out.


⚠ Carbubu has degraded performance

In 231cc76, Carbubu (https://carbubu.fr) experienced degraded performance:

HTTP code: 200
Response time: 11157 ms

Resolved: Carbubu performance has improved in 337b7b9.


Document task_group and include in Public API

Add header file task_group.hpp to the Public API page
Add documentation for task_group

bors merge


[bigtable] add support for bulk mutations

Current coverage is 19.69% (diff: 0.00%)

Merging #81 into master will decrease coverage by 0.44%

@@             master        #81   diff @@
==========================================
  Files           592        593     +1
  Lines         15820      16211   +391
  Methods           0          0
  Messages          0          0
  Branches       1658       1722    +64
==========================================
+ Hits           3185       3192     +7
- Misses        12348      12731   +383
- Partials        287        288     +1

Powered by Codecov. Last update f576768...e031af2


Add a button to clear the query cache

Clicking the button has to result in:

the Comunica HTTP cache being cleared
the currently displayed  query result being updated

Note: this button will not solve HTTP caching in the path between Comunica and a source.

While solving bullet 2 in above comment, I have to call refresh() after some delay to avoid next unexpected 401's:


React native 0.16.0 packager hangs when you require redux

The packager transform gets stuck at 97% forever.  This may be because the es6 environment on react native 0.16.0 has changed.
To replicate,  create a fresh 0.16.0 project and require redux in index.android.js

Why do you file this in Redux?
Nothing changed on our side.
Must be a packager issue?

If this is caused by .babelrc that used to be in the NPM package I can release a patch release that removes it. The build we have always been shipping is ES5. Would this help?

Errr... Sorry.  Was only happening with redux and no other libraries and I really don't understand how the packager works.  Reported to the official repo.
https://productpains.com/post/react-native/packager-hangs-indefinitely-on-requireredux-in-v0160/
https://github.com/facebook/react-native/issues/4674

@anshul I'm getting this error too. It doesn't get stuck only for redux but for other packages as well. This problem only started after i upgraded it to react-native v0.16. I also tried a fresh install of v0.16.
Any progress?
http://stackoverflow.com/questions/34169461/react-native-v0-16-stuck-at-transforming-when-using-external-packages


Merge pull request #1 from apache/master

Updating from original

@bprakg is this a mistake? can you close it?

Sorry Daan, it was a mistake, closing it.

np, human!


Custom "fixed" fees?

I'm looking for a way to pay with a fixed amount of fee per transaction, should this work?
wallet.pay({'1NcXPMRaanz43b1kokpPuYDdk6GGDvxT2T': '1000000' }, null, false, true, 1000,
    function(err, result) {});

just tagged v3.0.1 with a fix for this, the syntax is:
wallet.pay({'1NcXPMRaanz43b1kokpPuYDdk6GGDvxT2T': '1000000'}, null, false, true, blocktrail.Wallet.FEE_STRATEGY_FORCE_FEE, null, {
                forcefee: forceFee
            }, function(err, txHash) {});

really need to rework the method params at some point to make it a bit easier to use ...

Thank you I'm going to try this. I can also suggest a review of the doc (https://www.blocktrail.com/api/docs/lang/nodejs#sending_transactions) that doesn't explain in any way what the params are. (I had to look at the source code, and  I think there is also an error in the comment params.)

This line is dup https://github.com/blocktrail/blocktrail-sdk-nodejs/blob/69d85ea8987178f5c0dde4b85776cfbc22fe943a/lib/wallet.js#L758

@rubensayshi that syntax doesn't work. (Assuming I'm right and the variable forceFee you're passing into the options object should be the Satoshi value of the fee you're trying to fix).
This is the error I get
Error: An internal error was encountered
    at Function.Request.handleFailure (/Users/[redacted]/node_modules/blocktrail-sdk/lib/request.js:210:17)
    at /Users/[redacted]/node_modules/blocktrail-sdk/lib/request.js:184:29
    at Request.callback (/Users/[redacted]/node_modules/superagent/lib/node/index.js:746:30)
    at Request.<anonymous> (/Users/[redacted]/node_modules/superagent/lib/node/index.js:135:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at IncomingMessage.<anonymous> (/Users/[redacted]/node_modules/superagent/lib/node/index.js:938:12)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9) code: 500, statusCode: 500

Other fee strategies work fine.
Notes: I'm using testnet.

hey @timigod
I made an example here that works: https://github.com/blocktrail/blocktrail-sdk-nodejs/blob/master/examples/wallet_force_fee.js
    wallet.pay(pay, null, false, true, blocktrail.Wallet.FEE_STRATEGY_FORCE_FEE, null, options, function(err, result) {
            if (err) {
                return console.log("pay ERR", err);
            }

            console.log('transaction', result);
        });

options.forcefee should indeed by satoshis.
if it ain't working maybe you can paste the wallet.pay call here so I can try it out?
sorry about the wallet.pay method being a bit of a hassle to use, we're planning to redo it with a fluent method API soon, probably coinciding with changing the package name from blocktrail-sdk to BTC.com in the near future,

Hey @rubensayshi thanks a lot. And there's no need to apologize about the wallet.pay method. It's not that much of a hassle, you have removed so much more stress with this SDK and I thank you for that.
The reason it hasn't been working is that I used options.forceFee instead of options.forcefee, now it works.
Thanks again!


[DRAFT} Suspend-sleep-resume tests for USBDEV

This draft PR introduces a test framework and a set of top-level USBDEV tests to exercise all suspend/sleep states and transition stimuli from those states:

Suspended - Resume Signaling on the USB causes exit from Suspended.
Normal Sleep - Resume Signaling, Bus Reset or VBUS Disconnection cause exit from Normal Sleep.
Deep Sleep - Resume Signaling, Bus Reset or VBUS Disconnection cause exit from Deep Sleep.

This code is intended to operate on CW310/340 FPGAs, in simulation with Verilator/DVsim (excluded from this PR for simplicity), and ES/Prod silicon (SiVal). Since this is based on the ES Sival branch, it is presently configured by a number of #defines for building and running on the ES Silicon.
In its earlier incarnation as draft PR #18564 (still open because of the simulation-related work that it contains, particularly the extensive changes to the USBDPI model), it exposed some issues with the USBDEV RTL and that has led to changes in the RTL for Prod. To run this test with the Prod RTL the #defines at the top of lib/testing/usb_testutils.h and lib/dif/dif_usbdev.h must be modified.
Test command for running the full test sequence:
bazel test --nocache_test_results --test_output=streamed --//signing:token=//signing/tokens:cloud_kms_sival //sw/device/tests:usbdev_suspend_full_test_silicon_owner_sival_rom_ext

The PR is presently a draft because it is felt that further tidying and testing is required before the 'usbdev_suspend_full_test' should be integrated into CI/SiVal automated testing, shielding both the host- and the device-side components from the variable timing of the other party.

I would suggest the following to generate the bazel test, which I think is clearer:
# List of usbdev suspend/resume tests. Tuples of:
# (test_name, init-phase, fin-phase, src)
_SUSPEND_TEST = [
    ('suspend_resume', 'suspend', 'suspend', 'usbdev_suspend_resume_test.c'),
    ('sleep_resume', 'sleep-resume', 'sleep-resume', 'usbdev_sleep_resume_test.c'),
    ('sleep_reset', 'sleep-resume', 'sleep-reset', 'usbdev_sleep_reset_test.c'),
    ('usbdev_sleep_disconnect_test', 'sleep-disconnect', 'deep-resume', 'usbdev_sleep_disconnect_test.c'),
    ('deep_resume', 'deep-resume', 'deep-resume', 'usbdev_deep_resume_test.c'),
    ('deep_reset', 'deep-resume', 'deep-reset', 'usbdev_deep_reset_test.c'),
    ('deep_disconnect', 'deep-disconnect', 'shutdown', 'usbdev_deep_disconnect_test.c'),
    ('suspend_full', 'suspend', 'shutdown', 'usbdev_suspend_full_test.c')
]

[
    opentitan_test(
        name = "usbdev_{}_test".format(test_name),
        srcs = [
            test_src,
        ],
        cw310 = cw310_params(
            timeout = "eternal",
            tags = ["manual"],
            test_cmd = """
                --bootstrap="{{firmware}}"
                --init-phase={}
                --fin-phase={}
            """.format(init_phase, fin_phase),
            test_harness = "//sw/host/tests/chip/usb:usbdev_suspend",
        ),
        exec_env = dicts.add(
            EARLGREY_TEST_ENVS,
            EARLGREY_SILICON_OWNER_ROM_EXT_ENVS,
            {
                "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": None,
                "//hw/top_earlgrey:fpga_cw310_test_rom": None,
                "//hw/top_earlgrey:sim_dv": None,
            },
        ),
        silicon = silicon_params(
            test_cmd = """
                --bootstrap="{{firmware}}"
                --init-phase={}
                --fin-phase={}
                --vbus-sense-en=VBUS_SENSE_EN
                --vbus-sense=VBUS_SENSE
            """.format(init_phase, fin_phase),
            test_harness = "//sw/host/tests/chip/usb:usbdev_suspend",
        ),
        verilator = verilator_params(timeout = "long"),
        deps = [
            "//sw/device/lib/testing/test_framework:ottf_main",
            "//sw/device/tests:usbdev_suspend",
        ],
    )
    for (test_name, init_phase, fin_phase, test_src) in _SUSPEND_TEST
]


Test phpcs

Hi,
Testing using the command composer phpcs returned the error code 3.
Everything else executed OK, the problem has only with PHP Code Standards.
Why is this? Any Ideia?
Cheers!

This will be fixed adding the dealerdirect/phpcodesniffer-composer-installer development dependency.


systemd: patch runtime dlopen calls

Motivation for this change
See commit messages.
Things done

[X] NixOS small release set built for x86_64-linux
[X] NixOS big/regular release set built for x86_64-linux (https://hydra.h4ck.space/eval/1817#tabs-new)

Your good explanation from the commit message should really be a comment in the code, so that people can immediately see what and why.

Good point. I've added the commit message (in slightly changed form) to the code as comment.

Your good explanation from the commit message should really be a comment in the code, so that people can immediately see what and why.

Good point. I've added the commit message (in slightly changed form) to the code as comment.

All of the nits should have been addressed.
On 16:18 02.01.21, Florian Klink wrote:

@flokli commented on this pull request.
LGTM in general. Some spelling nitpicks, and minor remarks.

@@ -160,6 +160,88 @@ stdenv.mkDerivation {
--replace
"find_program('objcopy'"
"find_program('${stdenv.cc.bintools.targetPrefix}objcopy'"

'' + (let

The folllowing dlopen patches ensures that all the features that are

    # The folllowing dlopen patches ensure that all the features that are

 { name = "libpwquality.so.1"; pkg = null; }

 # Only include cryptsetup if it is enabled. We might not be able to

 # provide it during "bootstrap" in e.g. the minimal systemd build as

 # cryptsetup has udev (aka systemd) in it's dependencies.

 { name = "libcryptsetup.so.12"; pkg = if withCryptsetup then cryptsetup else null; }

 # We are using libidn2 so we only provide that and ignore the others.

 # Systemd does this decision during configure time and uses ifdef's to

 # enable specific branches. We can safely ignore (nuke) the libidn "v1"

 # libraries.

 { name = "libidn2.so.0"; pkg = libidn2; }

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

      # journalctl --grep requires libpcre2 so let's provide it

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

 { name = "libpcre2-8.so.0"; pkg = pcre2; }

];

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

      if ! [ -e ${lib.makeLibraryPath [dl.pkg]}/${dl.name} ]; then

this will automatically call getLib and append the lib suffix.

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

   echo 'The shared library `${lib.getLib dl.pkg}/lib/${dl.name}` does not exist but was given as subtitute for `${dl.name}`'

   exit 1

 fi

 # make the path to the dependency explicit

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

        echo "patching dlopen(\"${dl.name}\", …) in $file to ${lib.makeLibraryPath [dl.pkg]}/${dl.name}…"

shouldn't hurt to show where we pick the .so from.

Yeah, I've added that to both cases:
patching dlopen("libxkbcommon.so.0", …) in src/locale/localed.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libxkbcommon.so.0)…
patching dlopen("libqrencode.so.4", …) in src/shared/qrcode-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libqrencode.so.4)…
patching dlopen("libpwquality.so.1", …) in src/shared/pwquality-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libpwquality.so.1)…
patching dlopen("libcryptsetup.so.12", …) in src/shared/cryptsetup-util.c to /nix/store/mk4vvqdflib9pgh7ljvxa1w9g29gf1yh-cryptsetup-2.3.4/lib/libcryptsetup.so.12…
patching dlopen("libidn2.so.0", …) in src/shared/idn-util.c to /nix/store/0cbzck6xac05rpg8wnz943vmikl1ws1d-libidn2-2.3.0/lib/libidn2.so.0…
patching dlopen("libidn.so.12", …) in src/shared/idn-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libidn.so.12)…
patching dlopen("libidn.so.11", …) in src/shared/idn-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libidn.so.11)…
patching dlopen("libpcre2-8.so.0", …) in src/journal/pcre2-dlopen.c to /nix/store/wz02m7d46hznxzv3wlgppz1syzs9wsmc-pcre2-10.36/lib/libpcre2-8.so.0…

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

   echo 'The shared library `${lib.getLib dl.pkg}/lib/${dl.name}` does not exist but was given as subtitute for `${dl.name}`'

   exit 1

 fi

 # make the path to the dependency explicit

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("${lib.getLib dl.pkg}/lib/${dl.name}"'

        substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("${lib.makeLibraryPath [dl.pkg]}/${dl.name}"'

And now we use it again - maybe create a variable once and interpolate it in all three places?

 # We are using libidn2 so we only provide that and ignore the others.

 # Systemd does this decision during configure time and uses ifdef's to

 # enable specific branches. We can safely ignore (nuke) the libidn "v1"

 # libraries.

 { name = "libidn2.so.0"; pkg = libidn2; }

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

 { name = "libpcre2-8.so.0"; pkg = pcre2; }

];

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

I think the grep approach is fine for now, we can switch this to a coccinelle script as a followup.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/108032#pullrequestreview-560661271

All of the nits should have been addressed.
On 16:18 02.01.21, Florian Klink wrote:

@flokli commented on this pull request.
LGTM in general. Some spelling nitpicks, and minor remarks.

@@ -160,6 +160,88 @@ stdenv.mkDerivation {
--replace
"find_program('objcopy'"
"find_program('${stdenv.cc.bintools.targetPrefix}objcopy'"

'' + (let

The folllowing dlopen patches ensures that all the features that are

    # The folllowing dlopen patches ensure that all the features that are

 { name = "libpwquality.so.1"; pkg = null; }

 # Only include cryptsetup if it is enabled. We might not be able to

 # provide it during "bootstrap" in e.g. the minimal systemd build as

 # cryptsetup has udev (aka systemd) in it's dependencies.

 { name = "libcryptsetup.so.12"; pkg = if withCryptsetup then cryptsetup else null; }

 # We are using libidn2 so we only provide that and ignore the others.

 # Systemd does this decision during configure time and uses ifdef's to

 # enable specific branches. We can safely ignore (nuke) the libidn "v1"

 # libraries.

 { name = "libidn2.so.0"; pkg = libidn2; }

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

      # journalctl --grep requires libpcre2 so let's provide it

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

 { name = "libpcre2-8.so.0"; pkg = pcre2; }

];

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

      if ! [ -e ${lib.makeLibraryPath [dl.pkg]}/${dl.name} ]; then

this will automatically call getLib and append the lib suffix.

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

   echo 'The shared library `${lib.getLib dl.pkg}/lib/${dl.name}` does not exist but was given as subtitute for `${dl.name}`'

   exit 1

 fi

 # make the path to the dependency explicit

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

        echo "patching dlopen(\"${dl.name}\", …) in $file to ${lib.makeLibraryPath [dl.pkg]}/${dl.name}…"

shouldn't hurt to show where we pick the .so from.

Yeah, I've added that to both cases:
patching dlopen("libxkbcommon.so.0", …) in src/locale/localed.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libxkbcommon.so.0)…
patching dlopen("libqrencode.so.4", …) in src/shared/qrcode-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libqrencode.so.4)…
patching dlopen("libpwquality.so.1", …) in src/shared/pwquality-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libpwquality.so.1)…
patching dlopen("libcryptsetup.so.12", …) in src/shared/cryptsetup-util.c to /nix/store/mk4vvqdflib9pgh7ljvxa1w9g29gf1yh-cryptsetup-2.3.4/lib/libcryptsetup.so.12…
patching dlopen("libidn2.so.0", …) in src/shared/idn-util.c to /nix/store/0cbzck6xac05rpg8wnz943vmikl1ws1d-libidn2-2.3.0/lib/libidn2.so.0…
patching dlopen("libidn.so.12", …) in src/shared/idn-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libidn.so.12)…
patching dlopen("libidn.so.11", …) in src/shared/idn-util.c to an invalid store path (/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/libidn.so.11)…
patching dlopen("libpcre2-8.so.0", …) in src/journal/pcre2-dlopen.c to /nix/store/wz02m7d46hznxzv3wlgppz1syzs9wsmc-pcre2-10.36/lib/libpcre2-8.so.0…

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-not-implemented/${dl.name}"'

 done

'' else ''

 # ensure that the library we provide actually exists

 if ! [ -e ${lib.getLib dl.pkg}/lib/${dl.name} ]; then

   echo 'The shared library `${lib.getLib dl.pkg}/lib/${dl.name}` does not exist but was given as subtitute for `${dl.name}`'

   exit 1

 fi

 # make the path to the dependency explicit

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

   echo "patching dlopen(\"${dl.name}\", …) in $file"

   substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("${lib.getLib dl.pkg}/lib/${dl.name}"'

        substituteInPlace "$file" --replace 'dlopen("${dl.name}"' 'dlopen("${lib.makeLibraryPath [dl.pkg]}/${dl.name}"'

And now we use it again - maybe create a variable once and interpolate it in all three places?

 # We are using libidn2 so we only provide that and ignore the others.

 # Systemd does this decision during configure time and uses ifdef's to

 # enable specific branches. We can safely ignore (nuke) the libidn "v1"

 # libraries.

 { name = "libidn2.so.0"; pkg = libidn2; }

 { name = "libidn.so.12"; pkg = null; }

 { name = "libidn.so.11"; pkg = null; }

 # journalctl --grep require libpcre so lets provide it

 { name = "libpcre2-8.so.0"; pkg = pcre2; }

];

patchDlOpen = dl: if dl.pkg == null then ''

 # remove the dependency on the library by replacing it with an invalid path

 for file in $(grep -lr 'dlopen("${dl.name}"' src); do

I think the grep approach is fine for now, we can switch this to a coccinelle script as a followup.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/108032#pullrequestreview-560661271

Doesn't this remove the ability to enable certain dependencies dynamically at runtime, which is (I assume) the whole point of systemd's use of dlopen?
Also, all this grep magic seems hard to maintain. Wouldn't it be simpler to use a regular patch?

Doesn't this remove the ability to enable certain dependencies dynamically at runtime, which is (I assume) the whole point of systemd's use of dlopen?
Also, all this grep magic seems hard to maintain. Wouldn't it be simpler to use a regular patch?

For instance, the libxkbcommon dependency sounds like something we might want to enable on a X11 system.

For instance, the libxkbcommon dependency sounds like something we might want to enable on a X11 system.

Doesn't this remove the ability to enable certain dependencies dynamically at runtime, which is (I assume) the whole point of systemd's use of dlopen?

We can't really "discover" them at runtime with NixOS anyways, cause there's common path the linker looks in.
We also don't know which compilation unit dlopen call ends up in, and patching RUNPATHs with a once-determined list will break as soon as upstream moves things around, or uses functionality in more places.

Also, all this grep magic seems hard to maintain. Wouldn't it be simpler to use a regular patch?

We could switch to coccinelle in a follow-up to do the patching as proposed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550741933, to make the patching part a bit less messy, but we need the grep magic to notice new dlopen calls that have been introduced (like libfido2 recently).
The nixpkgs code now explicitly fails if we didn't yet decide what to do with a new dlopen dependency, which is a good thing - there's no sudden breakages if upstream decides to make another (previously mandatory) dependency optional (like it happened with libpcre2).

For instance, the libxkbcommon dependency sounds like something we might want to enable on a X11 system.

Making this overridable was discussed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550501341, but left out for now. We could expose this somehow, and graphical systems could possibly pass in another systemd.package.

Doesn't this remove the ability to enable certain dependencies dynamically at runtime, which is (I assume) the whole point of systemd's use of dlopen?

We can't really "discover" them at runtime with NixOS anyways, cause there's common path the linker looks in.
We also don't know which compilation unit dlopen call ends up in, and patching RUNPATHs with a once-determined list will break as soon as upstream moves things around, or uses functionality in more places.

Also, all this grep magic seems hard to maintain. Wouldn't it be simpler to use a regular patch?

We could switch to coccinelle in a follow-up to do the patching as proposed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550741933, to make the patching part a bit less messy, but we need the grep magic to notice new dlopen calls that have been introduced (like libfido2 recently).
The nixpkgs code now explicitly fails if we didn't yet decide what to do with a new dlopen dependency, which is a good thing - there's no sudden breakages if upstream decides to make another (previously mandatory) dependency optional (like it happened with libpcre2).

For instance, the libxkbcommon dependency sounds like something we might want to enable on a X11 system.

Making this overridable was discussed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550501341, but left out for now. We could expose this somehow, and graphical systems could possibly pass in another systemd.package.

On 05:11 04.01.21, Florian Klink wrote:

Making this overridable was discussed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550501341, but left out for now. We could expose this somehow, and graphical systems could possibly pass in another systemd.package.

We might even allow for runtime detection explicitly in some case. I
could imagine some of the features to be runtime discoverable by
pointing them at /run/current-system/systemd/extra-libs (or something
like that). This would still make the location explicit and NixOS would
still have full control over the used shared libraries.
I could really see this happening and I wouldn't mind it being that way.
As long as we are not relying on LD_LIBRARY_PATH etc.. during runtime.
The daemon might be executed in a different environment than your
systemctl or journalctl invocations thus having a well defined
location for those sounds sane.
I would probably not want this in a systemctl that is shipped for
users of just nixpkgs on e.g. Debian. There you probably want the
explict dependency (as introduced in this PR) to not accidentially mix
it with system libs or being required to create "weird"
/run/current-system/… directories.

On 05:11 04.01.21, Florian Klink wrote:

Making this overridable was discussed in https://github.com/NixOS/nixpkgs/pull/108032#discussion_r550501341, but left out for now. We could expose this somehow, and graphical systems could possibly pass in another systemd.package.

We might even allow for runtime detection explicitly in some case. I
could imagine some of the features to be runtime discoverable by
pointing them at /run/current-system/systemd/extra-libs (or something
like that). This would still make the location explicit and NixOS would
still have full control over the used shared libraries.
I could really see this happening and I wouldn't mind it being that way.
As long as we are not relying on LD_LIBRARY_PATH etc.. during runtime.
The daemon might be executed in a different environment than your
systemctl or journalctl invocations thus having a well defined
location for those sounds sane.
I would probably not want this in a systemctl that is shipped for
users of just nixpkgs on e.g. Debian. There you probably want the
explict dependency (as introduced in this PR) to not accidentially mix
it with system libs or being required to create "weird"
/run/current-system/… directories.

Some of the stuff might also simply end up in libsystemd and friends, which would be used on Non-NixOS as well where we cannot rely on special directories to be set up. And environment variables will most easily lead to crashes for people that try to mix different glibc versions i.e. by having unstable executables on stable.

Some of the stuff might also simply end up in libsystemd and friends, which would be used on Non-NixOS as well where we cannot rely on special directories to be set up. And environment variables will most easily lead to crashes for people that try to mix different glibc versions i.e. by having unstable executables on stable.


Reporting NAN when training CG_water model

Hi, I am recently trying to reproduce your results by running the CG_water.ipynb notebook, and it raised the NAN error during the trainging as following:
Step 0 in 90.34 sec Loss =  0.20526731
Step 1 in 854.44 sec Loss =  0.19676176
Step 2 in 854.85 sec Loss =  0.18241243
Step 3 in 858.79 sec Loss =  0.12344666
Step 4 in 856.21 sec Loss =  0.09613695
Step 5 in 880.87 sec Loss =  nan
Do you ever have this issue and could you give some advices to solve this problem?
Thanks a lot!

Hi, thanks for your interest in DiffTRe. I did not experience NaNs with the hyperparameters provided in the notebook. Usually, the main source of NaN values comes from simulations that sample in unphysical regions, mostly when 2 atoms overlap. You can check this by computing pairwise distances for each frame in the trajectory that becomes NaN. If atoms start to overlap, you could increase the strength of the prior potential to stop this from happening. This is the first thing I would try.
Another standard thing to try is to reduce the learning rate. I've increased it as much as I could to converge with the least amount of updates to save compute. Taking a smaller LR is usually a bit safer. The reweighting also introduces some amount of numerical noise, performing it in float64 is often a good measure.


Add under covered functions filter

Codecov Report

Merging #7 (c7c3264) into master (e0a5e60) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   60.12%   60.10%   -0.02%
==========================================
  Files           8        8
  Lines         326      366      +40
==========================================
+ Hits          196      220      +24
- Misses        102      112      +10
- Partials       28       34       +6

Flag
Coverage Δ

unittests
60.10% <60.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

gocovdiff.go
61.70% <33.33%> (-1.94%)
:arrow_down:

cover_func.go
77.21% <69.69%> (-6.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a5e60...c7c3264. Read the comment docs.


ENH: allow _dir for other EPI (func, dwi) sequences

Closes #47
This commit also demonstrates ability to reference other sections within the
document (when referencing fmap Case 4 where _dir described in greater detail
ATM

Pinging @bids-standard/bep_leads for comments.

func already has a few ways of disambiguating (run, task, etc.,.). as such my preference would be to start nudging people to get metadata from the sidecar instead of encoding in filename. perhaps we could go the other way and remove dir from dwi and leave it in the json sidecar.
it almost seems like we just want a disambiguation mnemonic. but i feel that naming things in filenames should be as restrictive as possible.
alternatively, we can adopt more generally what we discussed in derivatives meeting that any key and value can be added to the filename in pairs, but in general only a disambiguation mnemonic suffices.

While doing it I thought that may be detailed descriptions for all those key/pairs shared by different modalities could be brought into a single location, where it would be easy to reference them. Eg as subsections of src/99-appendices/04-entity-table.md ?

hm, ... wise words @satra ;-)
Indeed I do not generally envision people to perform identical task twice (thus kinda demanding the same task and run) just for the sake of having both field encoding directions.  I am (re)thinking...

@yarikoptic what's the status after @satra comments? Would you be ok closing this PR?

I thought / looked at it a bit more and was provided some counter examples, e.g. HCP dataset where the same task would have LR and RL "runs".  Sure thing it could be encoded within _run but again that would loose the specificity/semantic which _dir carries.
Other "examples" include some studies where they could have changed direction within the study/across sessions (ppl do crazy stuff out there in the wild ;-)).  Without reflecting it in the name, it would become not obvious (not caught by the bids-validator as well?) that such variability is present.
So I still feel that _dir, if desired, should be allowed for since it provides a clear semantic on how otherwise possibly identical (within or across subjects/sessions) files differ.  Stuffing that information into run (if applicable at all) or acq would retain the same filename length while loosing clear semantic association.
Please let me know what you think @chrisfilo and @satra

I still don't think it's necessary and acq is the right place to put it (not run since it's restricted to numbers), but I don't feel strongly enough about the topic to block this change. It also been three weeks and with no further feedback from the community - this does not seem like a breaking change.

Thank you @ericearl . Taking it with @kaczmarj 's comment at https://github.com/bids-standard/bids-specification/issues/47#issuecomment-432284191  I think there is enough community support/interest to see it implemented.  I will refurbish this PR for merge

Thanks!


Is it possible that you provide the pretrained teacher model IB-BERT for MobileBERT?

Hi, thanks for this wonderful project. Are there any pretrained weights for IB-BERT(large) available for download, or planned to be?

That would be very helpful !
@saberkun @ziyeqinghan @thaink

I am looking forward to it.


Setup env-test binaries for coverage

For the coverage target to work independent of other targets, include
the env-test framework setup step from the test target.
Signed-off-by: Pranshu Srivastava<EMAIL_ADDRESS>

This patch make use of the same test target to generate the coverage.out file.

Context: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/27907/rehearse-27907-pull-ci-red-hat-storage-mcg-osd-deployer-main-test-coverage/1522183333159636992#1:build-log.txt%3A308


ignore comment change while diff

e.g: in c
- var a = READ(0x4000_0100); // reg timer_0
+ var a = READ(0x4000_0100); // reg timer_1

add support to ignore the change of comment like above

Related: https://github.com/microsoft/vscode/issues/87944

The related issue already passed the number of votes,
It seems like the process duplicated and maybe the feature dropped by mistake.
I'm just a vscode user, who needs this feature.
Thanks in advance.


ActionSheet Docs: Create a table for all the options

Create a table on the actionsheet docs for all the properties, descriptions and defaults, that can be added to the actionsheet options.
Options:
title?: string,
subTitle?: string,
message?: string,
enableBackdropDismiss?: boolean,
cssClass?: string,
buttons?: Array
Button Options:
text
icon
handler
cssClass
role

And it is done.


Add gdrive to the scopes for service accounts

Duplicate of: https://github.com/grafana/google-bigquery-datasource/pull/189
Which has been held up getting the CLA signed off.
This will allow querying google drive backed tables.
Fixes: https://github.com/grafana/google-bigquery-datasource/issues/154

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @zoltanbedi,
Just wondering, on average, how long does it take to get a branch like this merged?
Kind regards,
Hazel

Thanks for your contribution @hazel-sindall-oxb! LGTM

No problem, what is the release schedule like for this repo?
google-bigquery-datasource/releases
Will I need to do something like this PR myself?

Sorry it took so long I wanted to test it myself.

no need to thanks, I'll take care of that. I'd like to have this PR also in #212 and then we will do a release.

Hello,
Looks like you got #212 done, shall I just watch the releases page for a new release now?

1.4.0 is out. Thanks for your contribution and patience @hazel-sindall-oxb.


WIP: test/e2e/storage/sanity.go: add check for leftover volumes

If a tester creates volumes that are not deleted properly,
we will have leftover device volumes (not CSI volumes)
after testing. Let's try to detect those using device
volume list commands.
Resolves #286

This covers some possible after-test space.
More to be added.
It is expected to fail because we have test active that leaves a volume, as described in #428
This testing condition will go away after #447 gets merged.

confirmed, fails in CI as expected

developed idea further, now we store volumes/namespaces list in Before handler and compare to After state. If we assume non-parallel testing, one global variable storing the list should be enough. This code worked in my local testing, I also tried with previously existing volumes in LV mode, which were tracked correctly.

previous state showed OK in CI tests.
Now I added artificial leak as separate commit, to check how do we catch a leak

The combined string comparison that I use is powerful in sense that it does not need lot of code, but it leads to state where it's not easy to see on which node the leak is.
So I was thinking, we could insert headings/tags into buffer marking the output from nodes, something like:
== volumes on node 1 ==
== volumes on node 2 ==
== volumes on node 3 ==

force pushed with changes: moved var declrs to Describe() block, added descriptive text, added Node %d headers in output.

Log output is meant to be for debug-stage only and removed in final version, I was hoping that the Equal() check shows the strings making problem visible. But seems it considers string too long or too multi-line, or some decision it does to truncate. BTW, I recall seen much longer texts printed in test comparison (pod, volume lists?). Is there some other check form more suitable?
But you are right, we should make the result display easier for person reading the test output.

Is there some other check form more suitable?

I would try comparing two lists of lines. But I am not sure how well that will be handled, so you'll have to experiment a bit.

Log output is meant to be for debug-stage only and removed in final version, I was hoping that the Equal() check shows the strings making problem visible.

I'm aware that the log output will be gone. I was just pointing out the information contained in them (the node number) is indeed useful and thus needs to be part of the assertion output when the comparison fails.

There are flags and limits in gomega format pkg to control truncate operation for long strings, but as you pointed out, the result will be better if we create structured output from start, so lets try now with slice instead of single string. At least with one leaked volume this looks nice in my local test.
Gomega shows elems of slice as single line even if those contain newline chars, so the risk here is that output of one node may get wide with multiple elements. To avoid that, we may consider split at newlines and create deeper structure, per volumes.

To avoid that, we may consider split at newlines and create deeper structure, per volumes.

[string][]string (node name to list of volumes hash) might work best.

I changed to map type you suggested and it seems to work, and it looks good in LVM mode.
Direct mode failure is not easy to get in CI as job stops after first failure which is LVM (if we want to see in CI we could change Jenkinsfile temporarily to start with Direct mode)
I tried a local run in Direct mode and this shows interesting result.
(ndctl namespace is shown as block of text, so I use some tr-commands to make it one-liner)
And testing shows one additional failure in reboot test, as it seems device gets different device name
for same namespace after reboot: all fields match expect device name blockdev.
For this change, I could work around  this by excluding "blockdev" line when composing volumes list.
But another question arises: is our state-saving safe against block device name change in reboot?
Here is the failure using current state of code:
can mount again after reboot
    same volumes before and after the test
    Expected
        <map[string][]string | len:3>: {
            "Namespaces on Node 1": [
                "dev:namespace0.0,mode:fsdax,map:dev,size:1073741824,uuid:f0edfa6b-0084-11ea-bddc-0242ac110003,blockdev:pmem0,name:6a2130accf186ac16f0d4f336bd488c9a512513f",
                "",
            ],
            "Namespaces on Node 2": [""],
            "Namespaces on Node 3": [""],
        }
    to equal
        <map[string][]string | len:3>: {
            "Namespaces on Node 1": [
                "dev:namespace0.3,mode:fsdax,map:dev,size:1073741824,uuid:f0edfa6b-0084-11ea-bddc-0242ac110003,blockdev:pmem0.3,name:6a2130accf186ac16f0d4f336bd488c9a512513f",
                "",
            ],
            "Namespaces on Node 2": [""],
            "Namespaces on Node 3": [""],
        }

work around this by excluding "blockdev" line

Actually, as can be seen in output, dev changes as well, so it needs to get excluded also.

Hm, the Jenkinsfile change that I tried, has effect that pipeline does not advance after LVM test (my plan was to get it ti continue into Direct mode test), but status in GH does not change to failure.
Perhaps easier is just to switch blocks order in Jenkinsfile instead of wanting both.
The LVM mode failure output looks reasonable.

no, it actually worked as I wanted, just the pipeline GUI did not indicate clearly after LVM stage that Direct stage was running (I waited for multiple minutes). After Direct stage, it shows both stages with logs so the end result is what is needed. Pushing new state where dev: and blockdev: lines are filtered out from namespace entry.

I expanded test to e2e side in csi_volumes.go, re/using the functions already implemented. But these new calls now (quick trial) use hard-coded num of nodes, as I don't see easy way in  that file to access num of tester nodes. Any ideas?
Could the code on sanity side store num of workers in some variable which is alive for both scopes? The sanity side seems to run before e2e side.

Force-pushed new version that relies on presence of ssh.N scripts to determine where to run host commands.

If we are satisfied about the detected leaked entries display now, and also places where checking is added,
I will remove debug-related parts, i.e. reversion of csi-test that triggers leak, and some debug logging.

If we are satisfied about the detected leaked entries display now, and also places where checking is added, I will remove debug-related parts, i.e. reversion of csi-test that triggers leak, and some debug logging.

Yes, please. One of the open questions for me is to @avalluri (https://github.com/intel/pmem-csi/pull/449#pullrequestreview-312388432), but that can also become an issue once we merge this PR.

Removed debug-related commits and log messages, force-pushed

CI ok, removing WIP


Add new paportal download params

Add overwrite and excludeEntites parameters to paportal download command

Ameya is OOF on vacation this week, I promised him to take over his branch and see his changes through


Services: first build: abs added

{package} {version} {:snowflake:}
Destination channel: {Snowflake | defaults}
Links

{ticket_number}
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:

...

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_4dmn66lcro/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:42: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:50: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:41: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:45: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:48: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:43: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:39: patch_must_be_in_build: patch must be in build when source/patches is set.
clone/recipe/meta.yaml:58: cbc_dep_in_run_missing_from_host: Run dependencies listed in the cbc should also be present in the host section.
clone/recipe/meta.yaml:79: http_url: http://git.ghostscript.com/?p=mupdf.git;a=summary is not https
clone/recipe/meta.yaml:56: cbc_dep_in_run_missing_from_host: Run dependencies listed in the cbc should also be present in the host section.
clone/recipe/meta.yaml:54: cbc_dep_in_run_missing_from_host: Run dependencies listed in the cbc should also be present in the host section.
===== Final Report: =====
5 Errors and 6 Warnings were found


Improve UCUM code validation

Is your feature request related to a problem? Please describe.
While checking #694 I noticed that our syntax-based validation considers almost any ascii string to be valid.
This is not what I had in mind when I opened this issue and I think it would be much more useful if we could use https://github.com/FHIR/Ucum-java to verify that the code is truly valid and not just syntactically-valid.
Describe the solution you'd like
Leverage https://github.com/FHIR/Ucum-java or at least the ucum-essence file it wraps in order to perform more stringent validation of the UCUM codes.
Describe alternatives you've considered
N/A
Additional context
There are potential legal issues with adopting ucum-essence and so this issue is blocked by #1418 until we can get a more clear understanding of what we need to do to include this.

Moved to Sprint 20 as it depends on UCUM license finalization.

As described in issue #1418, here are the licensing requirements:
Use of the ucum-essence.xml file was approved by Noah Sharkan in IP law on 10/07/2020, given the following conditions are met:

I reviewed the terms (https://ucum.org/trac/wiki/TermsOfUse) in view of your described use. While you are incorporating UCUM content into a software program, the software will include the UCUM code, definition value and unit fields in their entirety, right? (This is a requirement of section 7). Assuming this is the case, then I don't see an issue with using the xml file as proposed and including it in the OSS project, so long as you comply with the requirements discussed below and you don't think you have an issue complying with any other terms of the UCUM license.
Per Section 6 of the UCUM license, you'll need to include a copy of the Copyright Notice and License (you can download a plaintext copy at the link above, bottom of the page) within the same folder of the OSS project that includes the xml file. Including the copy in the same folder as the xml file is done so that the copy is accessible "on the same Internet page from which the [UCUM xml file] is available for download".
Per Section 7, you'll need to include the exact notice specified in section 7 on the OSS project page such that the notice is "accessible on the same Internet page from which the product is available for download".


Validate file names when saving.

Java doesn't validate file names by default when using JFileChooser to save files, and so we'll have to implement that ourselves. Some invalid file names include:

Anything with these characters: \ / * ? " < > | :
Unicode symbols
Some combinations of periods, such as . or ..
com[1-9]
lpt[1-9]
con
aux
nul
prn
Whitespace (except spaces?)
Any other file names that I might not know about.

We should just catch exceptions rather than trying to test all of these

Yeah that's what I said but then you said that you wanted to make them untypable/savable.


Add Visual Studio 2015 compatibility

There are some compilation issues with Visual Studio 2015.

Fixed in devel with d52210af1a1093fb8ce2f28d16b893dd0459ccc0


Please add transitionBetweenRoutes and hero Tag to CupertinoNavigationBarData

Please add transitionBetweenRoutes and heroTag to CupertinoNavigationBarData.
Without these attributes there will be errors on iOS and multiple CupertinoNavigationBars.

Added Pullrequest #10


Inconsistent behavior of sap.m.Page#scrollTo on mobile/cordova vs. browser

Hi all,
I am currently writing a chat app and I am using the following call to Page#scrollTo in order to scroll to the bottom of the page when a new message arrives:
this.getChatPage().scrollTo(Number.MAX_VALUE)

In Chrome 40.0.2214.91 m this works flawlessly, in the Android embedded browser, however, it does not. Instead, the page jumps back to the top.
Best,
Michael

We are looking into it.
Internal reference:<PHONE_NUMBER>

Hi Michael,
Number.MAX_VALUE is a very large number, and while this should not make a difference, it just does. Just use some plain HTML and test it:
http://jsbin.com/losafagege/1/edit?html,output
(this page only works with touch events)
Chrome works fine, but the stock Android browser (at least in Android 4.1.2 after an upgrade) fails. So this behavior is not caused by UI5. Please use a large number like 50000 instead to work around this browser bug.
Regards
Andreas

Hi Andreas,
Thank you for looking into my issue. I will definitely give your suggestion a shot. Would it not actually make sense to add some sort of scrollToBottom and scrollToTop method to the List API? I think this is a reasonable and useful addition to a list interface.
Best,
Michael


Preview Tab

Is your feature request related to a problem? Please describe.
Since posts cannot be edited, a Preview tab would be a nice addition.
Describe the solution you'd like
A preview would be great to catch typos, odd formatting, or dead links before posting.
Additional context
Additionally, this would be a useful Accessibility option: a 'Require preview before posting' toggle, if you will.

I'm not sure what the benefit of this would be given that in Bluesky, you're writing plain text whereas in something like GitHub where you can attach inline images and videos, and code snippets

You can attach images to Bluesky posts.  Video support is coming at a later date, afaik.

Yeah, but they're not inline like GitHub, you can see images without the need for a separate preview tab


Can't recreate environment with conda

Hello! I was trying to recreate the environment using conda and the file provided. Unfortunately, it didn't work. Maybe there are specific channels for the packages that are missing from the documentation?
Output is here:

Log
(base)  alex@xxx ~/bnn_covariate_shift> conda create -n izmailov --file requirements.txt
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

  - pyasn1==0.4.8=pypi_0
  - markdown==3.3.4=pypi_0
  - dm-tree==0.1.6=pypi_0
  - tensorboard-data-server==0.6.0=pypi_0
  - requests==2.25.1=pypi_0
  - opt-einsum==3.3.0=pypi_0
  - importlib-resources==5.1.2=pypi_0
  - keras-preprocessing==1.1.2=pypi_0
  - chardet==4.0.0=pypi_0
  - cachetools==4.2.2=pypi_0
  - chex==0.0.6=pypi_0
  - toolz==0.11.1=pypi_0
  - pyasn1-modules==0.2.8=pypi_0
  - jaxlib==0.1.65+cuda112=pypi_0
  - wrapt==1.12.1=pypi_0
  - requests-oauthlib==1.3.0=pypi_0
  - tabulate==0.8.9=pypi_0
  - protobuf==3.15.8=pypi_0
  - tensorflow-estimator==2.4.0=pypi_0
  - tqdm==4.60.0=pypi_0
  - absl-py==0.12.0=pypi_0
  - grpcio==1.32.0=pypi_0
  - jmp==0.0.2=pypi_0
  - six==1.15.0=pypi_0
  - promise==2.3=pypi_0
  - dm-haiku==0.0.5.dev0=pypi_0
  - tensorboard==2.5.0=pypi_0
  - flatbuffers==1.12=pypi_0
  - oauthlib==3.1.0=pypi_0
  - dill==0.3.3=pypi_0
  - tensorflow-datasets==4.2.0=pypi_0
  - google-pasta==0.2.0=pypi_0
  - gast==0.3.3=pypi_0
  - jax==0.2.12=pypi_0
  - astunparse==1.6.3=pypi_0
  - google-auth-oauthlib==0.4.4=pypi_0
  - h5py==2.10.0=pypi_0
  - scipy==1.6.3=pypi_0
  - urllib3==1.26.4=pypi_0
  - future==0.18.2=pypi_0
  - tensorflow-metadata==0.30.0=pypi_0
  - idna==2.10=pypi_0
  - termcolor==1.1.0=pypi_0
  - typing-extensions==<IP_ADDRESS>=pypi_0
  - rsa==4.7.2=pypi_0
  - numpy==1.19.5=pypi_0
  - tensorboard-plugin-wit==1.8.0=pypi_0
  - optax==0.0.6=pypi_0
  - attrs==20.3.0=pypi_0
  - googleapis-common-protos==1.53.0=pypi_0
  - pip==21.1=pypi_0
  - google-auth==1.30.0=pypi_0
  - werkzeug==1.0.1=pypi_0
  - tensorflow==2.4.1=pypi_0

Current channels:

  - https://repo.anaconda.com/pkgs/main/linux-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/linux-64
  - https://repo.anaconda.com/pkgs/r/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.

Hi @jetsnguns sorry about that! I exported this file on google cloud machine, so I guess some of these packages might be specific to google cloud. Could you try to set up the environment using the pip install instructions?

Thanks for the reply, @izmailovpavel ! Yes, pip installation works; I'll stick with it then.


Amazon Australia Marketplace

Amazon added Australia as Seller accessible marketplace. Could you please add AU marketplace (A39IBJ37TRP1C6) to the list of endpoints.

At the moment shows not ready
https://www.ctrl.blog/entry/amazon-affiliate-australia

@tinohager Seems llike Amazon Australia started to work. But I'm not sure about affilate program.

affiliate program is up


Add ref store size threshold property to initiate purge of old streams

When a ref store reaches stroom.pipeline.referenceData.lmdb.maxStoreSize loads will fail.  It would be good if there was an additional threshold % property (e.g. 90%) such that prior to a load, if the store size (as a % of the maxStoreSize) is greater than this threshold, then it will purge old streams until below the threshold.

Raised for @p-kimberley

For context, there are two issues here:

Disk pressure caused by multiple ref DBs (one per feed), each growing at their own rate up to maxStoreSize. Once a volume fills up, ref data writes will fail. Therefore it would be useful to be able to cap ref usage on a per-node basis as well as per-feed/DB.
A single DB reaching maxStoreSize and subsequently failing to load until entries expire and are purged.

Firstly, I suggest maxStoreSize be renamed to maxDbSize. When ref stores were combined (not split into feeds), this property made sense as a combined limit. Now there can be multiple DBs, there should be a separate property governing the size of individual DBs.
I propose two additional settings be created, both of which will cause streams to be purged until the DB(s) are within limits:

stroom.pipeline.referenceData.lmdb.maxStoreSize. Maximum size of the ref store, encompassing all ref DBs. This will enable a global cap to prevent disk pressure from affecting node health if ref data grows in an uncontrolled manner. If this limit is reached, Stroom should start purging from the largest ref DBs until the aggregate DB size falls below. Maybe purge iteratively in batches, each time from the largest DB.
stroom.pipeline.referenceData.lmdb.dbHighWaterMarkPercent. Once an individual ref DB reaches this percentage of dbMaxSize, purge streams until its size falls below.


⚠ Diverse AirCon & Mechanical has degraded performance

In f278eca, Diverse AirCon & Mechanical (https://diverseaircon.com.au) experienced degraded performance:

HTTP code: 200
Response time: 12017 ms

Resolved: Diverse AirCon & Mechanical performance has improved in a0e4fe9.


Where does this page fit in the site's navigation?

This page is probably meant to be part of the "AL reference guide"?
(https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-al-reference-guide)
But it is no referenced from that page in a clear way. Also I cannot find this page through the site menu on the left.
After finding the page, the breadcrumb at the top does not tell me that I am in a page that belongs to the "AL reference guide", so possible my assumption was wrong. I don't know where I am. It is a useful page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff8af30e-3d81-30c3-44c8-fc4cb631d001
Version Independent ID: 315c1531-77aa-c602-6c0b-41d160d791e2
Content: AL Simple Statements - Business Central
Content Source: dev-itpro/developer/devenv-al-simple-statements.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for the feedback. You are right, this page is not listed in the table of contents, and it should be. It will be fixed with the next refresh of the docs. Thanks.


Bug: slack attachments are not presented in list files

Example conversation: https://dust.tt/w/0ec9852c2f/assistant/21WstzG1Uh
First run: https://dust.tt/w/78bda07b39/spaces/vlt_rICtlrSEpWqX/apps/0e9889c787/runs/2c27e0691b14e151dc51ec36c2d4fc896769d1119eff266c8fc3616fe842cb93
Original slack thread: https://dust4ai.slack.com/archives/C050SM8NSPK/p1732725667352009
Context: https://dust4ai.slack.com/archives/C050SM8NSPK/p1732789521915019

But is here: https://github.com/dust-tt/dust/blob/main/front/lib/api/assistant/jit_actions.ts#L133 vs the fact that slack is not in that list because of https://github.com/dust-tt/dust/blob/main/types/src/front/content_fragment.ts#L23

And... that didn't fix it reopening

Will upload a content attachment manually locally with the right content type to emulate slack

The approach worked but required fileUpload which requires a user. Need to fix that first before moving forward.
Conversation operations should be doable without user. Main impact that require users today:

file creation
data source creation


circle's area & circumference calculator

Description
I want to make calculator that calculates area and  circumference of circle
Input
r : radius of circle
Output
C: circumference of circle
A: Area of circle
Formula
C=2 pi r
A=pi*r^2
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@dfghjkbd please open one issue at a time.

@Rakesh9100 I would like to build a new calculator that will support determining circle's area & circumference . This tool will be really helpful for students and math enthusiasts.
Kindly assign me this issue.
Thank you!

@Rakesh9100  please assign me this issue .

@dfghjkbd you will not be assigned more than one issue at a time. You must only open one issue at a time and please don't ask Rakesh to assign you an issue I explicitly did not tell him to assign.

@jessicachawla

This tool is designed to calculate the area and circumference of a circle based on user input. Additionally, it includes functionality for displaying and managing a history of calculations.

@jessicachawla

In this  also way, I can make this calculator

@Rakesh9100 I would like to build a new calculator that will support determining circle's area & circumference . This tool will be really helpful for students and math enthusiasts.
Kindly assign me this issue.
Thank you!

No need to create a separate calculator, you can add the Circumference calculation in the existing 2D Shapes Calculator when we select shapes as Circle, let me know @dfghjkbd

@Rakesh9100 yes I am ready to add   circumference and area  calculation feature for circles to the existing 2D Shapes Calculator.

It is already calculating Area and Perimeter, and I think circumference is same as perimeter right @dfghjkbd


The kinect2_bridge depth processing time to long?

When i have the roslaunch kinect2_bridge kinect2_bridge.launch and rosrun kinect2_viewer kinect2_viewer kinect2 sd image I can get the image view, but the depth and rgb process time is too long to make the kinect2 applicating. I was used in the TX1.
[Info] [TurboJpegRgbPacketProcessor] avg. time: 45.6985ms -> ~21.8826Hz
[ INFO] [1472604278.047575423]: [Kinect2Bridge::main] depth processing: ~97.1099ms (~10.2976Hz) publishing rate: ~14.3159Hz
[ INFO] [1472604278.047706828]: [Kinect2Bridge::main] color processing: ~30.1297ms (~33.1898Hz) publishing rate: ~10.9866Hz
[Info] [DepthPacketStreamParser] 14 packets were lost
[Info] [DepthPacketStreamParser] 16 packets were lost
[Info] [CudaDepthPacketProcessor] avg. time: 5.45824ms -> ~183.209Hz
[ INFO] [1472604281.054030994]: [Kinect2Bridge::main] depth processing: ~92.5956ms (~10.7997Hz) publishing rate: ~14.6353Hz
[ INFO] [1472604281.054230055]: [Kinect2Bridge::main] color processing: ~31.247ms (~32.003Hz) publishing rate: ~11.6417Hz
You can see the depth processing freq is only 10 hz.
and when i run  the ./Protonect i can see the four images, the debug as following:
[Info] [OpenGLDepthPacketProcessor] avg. time: 13.5973ms -> ~73.5438Hz
[Debug] [RgbPacketStreamParser] skipping rgb packet!
[Debug] [RgbPacketStreamParser] skipping rgb packet!
[Debug] [RgbPacketStreamParser] skipping rgb packet!
[Debug] [RgbPacketStreamParser] skipping rgb packet!
[Info] [TurboJpegRgbPacketProcessor] avg. time: 40.4644ms -> ~24.7131Hz
i make the kinect2 connected with the TX1's usb3.0  port.

I guess the reason is that the CPU is under full load. Processing the SD RGB image is using much CPU. The image has to be registered, than it has to be flipped and at the end the color format has to be converted. The depth image has to be undistorted, flipped and converted too. This is probably to much for the TX1.

@wiedemeyer
Yes, i think you are right. As i used a PCI-E to connect the kinect2 usb, i can't get the image, and crashed! I think with the increase of the bandwidth the CPU load increasing! Is it?
Can i use the package 'kinect2_registraction' to registered?
Can i use the package 'kinect2_calibration' to left and right flipped?
and i wonder what do "color format has to be converted" mean?

If you are having problems with the USB controller, than it is probably a driver issue and not related to iai_kinect2.
There are READMEs in each package folder. You can read those to understand what they are for.
Color format conversion: RGBA to BGR.

@wiedemeyer
sorry i mislead you, it's not the USB controller's problem, the problem is my CPU load are around 90%, and the frame rates is around 7 hz. as followed:
[ INFO] [1473146239.715266524]: [Kinect2Bridge::main] depth processing: ~204.89ms (~4.88067Hz) publishing rate: ~14.977Hz [ INFO] [1473146239.715418450]: [Kinect2Bridge::main] color processing: ~154.081ms (~6.49008Hz) publishing rate: ~5.65796Hz [Info] [TegraJpegRgbPacketProcessor] avg. time: 4.99351ms -> ~200.26Hz [Info] [CudaDepthPacketProcessor] avg. time: 5.99157ms -> ~166.901Hz [ INFO] [1473146242.723445639]: [Kinect2Bridge::main] depth processing: ~226.668ms (~4.41174Hz) publishing rate: ~13.9619Hz [ INFO] [1473146242.723579493]: [Kinect2Bridge::main] color processing: ~184.339ms (~5.42477Hz) publishing rate: ~4.65398Hz [Info] [TegraJpegRgbPacketProcessor] avg. time: 4.87558ms -> ~205.104Hz [Info] [DepthPacketStreamParser] 1 packets were lost [Info] [CudaDepthPacketProcessor] avg. time: 5.88336ms -> ~169.971Hz
As i know in recent days, is the opencl in registration can't support the jetson, results in the cpu as the registration method, so the cpu are overload.
you suggested me to "The image has to be registered, than it has to be flipped and at the end the color format has to be converted. The depth image has to be undistorted, flipped and converted too. This is probably to much for the TX1."
I wonder the image didn't registered? why i need registered? i remember there is a reg_method=cpu | opencl to get registration. what do you mean registered?
and in the installLibfreenect2 i had the color format conversion.
So, i'm confused. what should i do to decrease the cpu's load and increase the frame rate, otherwise, i can't do my work further.

if you are subscribing to the SD color image, than is needs to get registered to the depth image. This is done using the registration code provided by libfreenect2, there is no OpenCL/CUDA implementation for it. The kinect2_registration package and the reg_method parameter are only used for the HD/QHD depth to color registration, not for the color to depth registration used for the SD images.
The images need to be flipped because in the images from libfreenect2 left and right are flipped.
iai_kinect2 is not optimized to the lowest CPU load. It tries to reduce the work needed on the receiving nodes and to minimize the needed bandwidth, so that it can transfer up to 30 FPS of HD images over gigabit network.
If the frame rate is so important, simply use stronger hardware, or optimize the code to your needs.

Thank for your petiently answer and your opensource code! i will have a try.


Unable to process nested ${} expressions

Hi! First of all, thanks for this great project.
I'm using it to generate Kotlin code and faced some problems since ${} in Kotlin also means expression interpolation and therefore nesting is common. Take the following code as example:
Data.kt
data class Data(val now: LocalDateTime, val datePattern: String)

Template.kte
@import java.time.format.DateTimeFormatter
@import sample.Data
@param data: Data

println("Today is ${data.now.format(DateTimeFormatter.ofPattern("${data.datePattern} HH:mm")}")

JTE generates this:
class JteIssueGenerated {
companion object {
	@JvmField val JTE_NAME = "Issue.kte"
	@JvmField val JTE_LINE_INFO = intArrayOf(0,0,1,3,3,3,3,5,5,5,6)
	@JvmStatic fun render(jteOutput:gg.jte.TemplateOutput, jteHtmlInterceptor:gg.jte.html.HtmlInterceptor?, data:Data) {
		jteOutput.writeContent("\nprintln(\"")
		jteOutput.writeUserContent(data.now.format(DateTimeFormatter.ofPattern("${data.datePattern)
		jteOutput.writeContent(" HH:mm\"))}\")\n")
	}
	@JvmStatic fun renderMap(jteOutput:gg.jte.TemplateOutput, jteHtmlInterceptor:gg.jte.html.HtmlInterceptor?, params:Map<String, Any?>) {
		val data = params["data"] as Data
		render(jteOutput, jteHtmlInterceptor, data);
	}
}
}

Workaround is to use variable instead of expression interpolation, so the previous example would look like this:
@import java.time.format.DateTimeFormatter
@import sample.Data
@param data: Data

!{val datePattern = data.datePattern}
println("Today is ${data.now.format(DateTimeFormatter.ofPattern("$datePattern HH:mm")}")

Maybe for .kte templates a different syntax for interpolation (e.g. #{} like in Ruby's ERB) would be nice to avoid confusion with Kotlin's interpolation syntax.

Hi @edrd-f! Thank you for the heads up and for using jte.
I just pushed a bugfix so that the parser isn't confused by nested strings. This should fix the compilation issue you experienced.
The IntelliJ plugin already handles this correctly when it parses the AST:

I think the difference between the two is significant for the reader when using the plugin.
jte tries to keep the syntax as minimal as possible, so I'd rather avoid adding alternative syntax for ${}.
How urgent is this fix? I could certainly release a bugfix release to maven central today.

Wow, that was quick!
The new syntax highlighting on the plugin will help a lot too.
About your question on urgency, it's not urgent at all, since there's the !{} workaround.
Thanks a lot for your assistance.

You're very welcome :-)
I just published version 1.11.3 to maven central, which contains this fix.
Thank you for reporting the issue!


Create SanskritTranslator.md

📝 Description
Add a brief description.
💣 Is this a breaking change (Yes/No):

[x] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

Any updates?

Any updates @AruSeito ?


[Regression] OG and Twitter description uses wrong order

1 - manifest.json (For Push Notifications) not loading gives HTTP/1.1 422 Unprocessable Entity and In Error page, it has shown 422 Validation (isSlug) failed for slug Me add the Header tag via Code Injection  <link rel="manifest" href="/manifest.json">
2 - Casper theme Related post and Next and Previous Post is not Working in APIv2
3 - Meta OG description fetch the description from the post content previously I add the description on SEO Meta Boxes it fetches the same one for OG description too
How to Get the Public API Key for v2?
I Rollback to the Previous version everything working fine
Technical details:

Ghost Version: 2.11.0
Node Version: v6.16.0

I was able to reproduce and understand the issue that is described here, due to the latest forum post here
This is indeed a regression bug, due to the excerpt property which messes the conditional up that determines the og and twitter description here. post.excerpt was not populated by default before, so that conditional made sense. It's now always populated (when v2 is used) and makes the next conditional redundant:
https://github.com/tryghost/ghost/blob/30a0b1794a565263d0de9399c300b3fcde23b0b7/core/server/data/meta/index.js#L92-L93
To visualise:

☝ v.2.13.0

☝ v2.5.0