[BUG] CLI check preflight glosses over absence of NFS installation.

Describe the bug
Longhorn CLI "check preflight" is not clear about the fact that nfs-common is not installed.
To Reproduce
Here is the result of environment_check.sh on my new ubuntu 24.04 cluster.  I have run the prerequisite longhorn-iscsi-installer.yaml, but not the nfs installer.   The environment_check script shows that:
./environment_check.sh
[INFO]  Required dependencies 'kubectl jq mktemp sort printf' are installed.
[INFO]  All nodes have unique hostnames.
[INFO]  Waiting for longhorn-environment-check pods to become ready (0/3)...
[INFO]  All longhorn-environment-check pods are ready (3/3).
[INFO]  MountPropagation is enabled
[INFO]  Checking kernel release...
[INFO]  Checking iscsid...
[INFO]  Checking multipathd...
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-4ts4r known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-4jz2x known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-w94pq known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[INFO]  Checking packages...
[ERROR] nfs-common is not found in jbm-u24-pool2-738eb9fd-4ts4r.
[ERROR] nfs-common is not found in jbm-u24-pool2-738eb9fd-4jz2x.
[ERROR] nfs-common is not found in jbm-u24-pool2-738eb9fd-w94pq.
[INFO]  Checking nfs client...
[INFO]  Cleaning up longhorn-environment-check pods...
[INFO]  Cleanup completed.

But CLI checker does not:
./longhornctl-linux-amd64 check preflight
INFO[2024-09-19T15:21:14-06:00] Initializing preflight checker
INFO[2024-09-19T15:21:14-06:00] Cleaning up preflight checker
INFO[2024-09-19T15:21:14-06:00] Running preflight checker
INFO[2024-09-19T15:21:19-06:00] Retrieved preflight checker result:
jbm-u24-pool2-738eb9fd-4jz2x:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
jbm-u24-pool2-738eb9fd-4ts4r:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
jbm-u24-pool2-738eb9fd-w94pq:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
 Use 'longhornctl check preflight' to check the result.

./longhornctl-linux-amd64 check preflight gives the same result, but environment_check.sh now shows we're fine.
./environment_check.sh
[INFO]  Required dependencies 'kubectl jq mktemp sort printf' are installed.
[INFO]  All nodes have unique hostnames.
[INFO]  Waiting for longhorn-environment-check pods to become ready (0/3)...
[INFO]  All longhorn-environment-check pods are ready (3/3).
[INFO]  MountPropagation is enabled
[INFO]  Checking kernel release...
[INFO]  Checking iscsid...
[INFO]  Checking multipathd...
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-w94pq known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-4jz2x known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-u24-pool2-738eb9fd-4ts4r known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[INFO]  Checking packages...
[INFO]  Checking nfs client...
[INFO]  Cleaning up longhorn-environment-check pods...
[INFO]  Cleanup completed.

It seems like the CLI preflight check is missing something in the NFS check.
(As an aside, it also does not have a kernel version check?  On a cluster running Ubuntu 20.04,
./environment_check.sh
[INFO]  Required dependencies 'kubectl jq mktemp sort printf' are installed.
[INFO]  All nodes have unique hostnames.
[INFO]  Waiting for longhorn-environment-check pods to become ready (0/3)...
[INFO]  All longhorn-environment-check pods are ready (3/3).
[INFO]  MountPropagation is enabled
[INFO]  Checking kernel release...
[WARN]  Node jbm-trial-pool2-254cd2ae-w7rd5 has outdated kernel release: 5.4.0-192-generic. Recommending kernel release >= 5.8
[WARN]  Node jbm-trial-pool2-254cd2ae-bx48j has outdated kernel release: 5.4.0-193-generic. Recommending kernel release >= 5.8
[WARN]  Node jbm-trial-pool2-254cd2ae-vsblf has outdated kernel release: 5.4.0-193-generic. Recommending kernel release >= 5.8
[INFO]  Checking iscsid...
[INFO]  Checking multipathd...
[WARN]  multipathd is running on jbm-trial-pool2-254cd2ae-w7rd5 known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-trial-pool2-254cd2ae-bx48j known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[WARN]  multipathd is running on jbm-trial-pool2-254cd2ae-vsblf known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-volume-with-multipath
[INFO]  Checking packages...
[INFO]  Checking nfs client...
[INFO]  Cleaning up longhorn-environment-check pods...
[INFO]  Cleanup completed.

But
./longhornctl-linux-amd64 check preflight
INFO[2024-09-19T15:40:22-06:00] Initializing preflight checker
INFO[2024-09-19T15:40:22-06:00] Cleaning up preflight checker
INFO[2024-09-19T15:40:22-06:00] Running preflight checker
INFO[2024-09-19T15:40:28-06:00] Retrieved preflight checker result:
jbm-trial-pool2-254cd2ae-bx48j:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
jbm-trial-pool2-254cd2ae-vsblf:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
jbm-trial-pool2-254cd2ae-w7rd5:
  info:
  - Service iscsid is running
  - NFS4 is supported
  - Package nfs-common is installed
  - Package open-iscsi is installed
  - Package cryptsetup is installed
  warn:
  - multipathd.service is running. Please refer to https://longhorn.io/kb/troubleshooting-volume-with-multipath/ for more information.
INFO[2024-09-19T15:40:28-06:00] Cleaning up preflight checker
INFO[2024-09-19T15:40:29-06:00] Completed preflight checker

Expected behavior
longhornctl check preflight should note that NFS is not installed.  Nevertheless, longhornctl install preflight does the job.
Support bundle for troubleshooting

Environment

Longhorn version: 1.7.1
Impacted volume (PV):
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):  Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:  1.26 RKE2

Number of control plane nodes in the cluster:3
Number of worker nodes in the cluster:1

Node config

OS type and version: Ubuntu 24.04
Kernel version: 6.8.0-36-generic
CPU per node:
Memory per node:
Disk type (e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes (Gbps):

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context

Workaround and Mitigation

In CLI's check preflight, the APT package checker checks the package status by the exit code of dpkg-query -l $package_name . However, for nfs-common, the package present in dpkg database, which means the exit code is 0, but in not-installed status:
root@a20a6b5ebb3d:/# dpkg-query -l nfs-common
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
un  nfs-common     <none>       <none>       (no description available)

After installed, the package status flags will turn from un (unknown-not-installed) to ii (install-installed)
root@466d2a4c7d63:/# dpkg-query -l nfs-common
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version          Architecture Description
+++-==============-================-============-=============================================
ii  nfs-common     1:2.6.4-4ubuntu1 amd64        NFS support files common to client and server

In the other hand, environment_check.sh lists all installed (ii) packages, then grep the package form the list. (dpkg -l | grep -w $package_name)
To CLI checker, we may need to parse the output status flag instead of simply check the dpkg-query exit code.
@c3y1huang any input is welcome.

PR: longhorn/cli#132

Test Steps

Step 1. a new Ubuntu/Debian host and longhornctl installed
Step 2. execute longhornctl check preflight, it should indicate that multiple package have not installed, include nfs-common
Step 3. install nfs-common (sudo apt install nfs-common)
Step 4. execute longhornctl check preflight, it should indicate that nfs-common is installed.
Step 5. uninstall nfs-common (sudo apt remove nfs-common)
Step 6. execute longhornctl check preflight, it should indicate that nfs-common is not installed.


chore: release main

:robot: I have created a release beep boop
@dotcom-reliability-kit/crash-handler: 3.0.2
Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^3.0.1 to ^3.1.0

fetch-error-handler: 0.1.1
0.1.1 (2023-09-19)
Features

handle common errors thrown by fetch (5828192)

Bug Fixes

correct a typo in the tests (050bf7c)

Documentation Changes

fix a typo (3e1d185)

log-error: 3.1.0
3.1.0 (2023-09-19)
Features

add processType property to error logger (dee3f6c)

Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/logger bumped from ^2.2.8 to ^2.2.9

logger: 2.2.9
2.2.9 (2023-09-19)
Bug Fixes

bump pino from 8.15.0 to 8.15.1 (2f3bfcb)

Documentation Changes

add a note on testing with Jest (5a2d24c)

@dotcom-reliability-kit/middleware-log-errors: 3.0.2
Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^3.0.1 to ^3.1.0

@dotcom-reliability-kit/middleware-render-error-info: 3.0.2
Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^3.0.1 to ^3.1.0

This PR was generated with Release Please. See documentation.

This is just a documentation change so not worth approving the release and creating a lot of noise yet. Let's wait for another change to land

:robot: Release is at https://github.com/Financial-Times/dotcom-reliability-kit/releases/tag/fetch-error-handler-v0.1.1 :sunflower:

:robot: Release is at https://github.com/Financial-Times/dotcom-reliability-kit/releases/tag/log-error-v3.1.0 :sunflower:

:robot: Release is at https://github.com/Financial-Times/dotcom-reliability-kit/releases/tag/middleware-log-errors-v3.0.2 :sunflower:

:robot: Release is at https://github.com/Financial-Times/dotcom-reliability-kit/releases/tag/middleware-render-error-info-v3.0.2 :sunflower:


Added PR template, Security Policy and CODEOWNERS

This PR adds the following features:

A Pull Request template which requires users to certify that they have completed a set number of tasks
A Security Policy should any security vulnerabilities be discovered, as well as a scope of vulnerabilities
A Codeowners file - this currently defaults to all files being owned by Troy

The PR template looks like this (there are <!-- --> comments explaining to users what to describe where necessary):
Description

Checklist:

[ ] I confirm that my submission adheres to the Code of Conduct.
[ ] I have performed a self-review of all of my code
[ ] I have ensured all of my code has <summary> tags for all methods and public variables, and has comments to understand program execution flow where it is hard to understand, as well as updating any <summary> tags in functions where functionality has changed.
[ ] I have tested that the code works with sample data running the code either locally or in my own deployed Azure Function.
[ ] I have verified that any tests that I have supplied with this Pull Request work and I have fixed any code which caused pre-existing tests to fail.
[ ] I have updated the README with any changes in dependencies/configuration values.
[ ] I have linted my code to ensure that it is formatted correctly.

A person submitting a new PR would fill it in like so:
Description

This adds a new Pull Request Template like this one which users fill out to a description of the changes as well as ensuring that a few basic tasks have been filled - such as ensuring their code doesn't break any tests, their code is properly commented etc. This also adds a Security Policy which gives users a point of contact, a policy to follow until the vulnerability is fixed, as well as a scope. Finally, a CODEOWNERS file has been added, with all files currently owned by Troy.
Checklist:

[x] I confirm that my submission adheres to the Code of Conduct.
[x] I have performed a self-review of all of my code
[x] I have ensured all of my code has <summary> tags for all methods and public variables, and has comments to understand program execution flow where it is hard to understand, as well as updating any <summary> tags in functions where functionality has changed.
[x] I have tested that the code works with sample data running the code either locally or in my own deployed Azure Function.
[x] I have verified that any tests that I have supplied with this Pull Request work and I have fixed any code which caused pre-existing tests to fail.
[x] I have updated the README with any changes in dependencies/configuration values.
[x] I have linted my code to ensure that it is formatted correctly.

I'd suggest making the code documentation optional, especially for private/internal methods. In my experience the code docs really only make sense for a public API or library referenced in other projects and often just convolute the code files with boilerplate text when it is perfectly understandable without them.

I'd suggest making the code documentation optional, especially for private/internal methods. In my experience the code docs really only make sense for a public API or library referenced in other projects and often just convolute the code files with boilerplate text when it is perfectly understandable without them.

I've removed the item entirely from the checklist

Any updates or changes for this PR?

Any updates or changes for this PR?

I'll delegate the acceptance of this PR to @troyhunt since he's better suited to evaluate the contents of the security policy and the code ownership.


[CH-264] support more json functions

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Support more json functions
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
test by CH[[264]]

backend update https://github.com/Kyligence/ClickHouse/pull/264


#371 'posix fallback bug' - added fallback in case of UnsupportedOperationException

Added additional exception type to fallback catch clause, as Windows env throws UnsupportedOperationException when trying to get not-existing file attribute

updated changelog

@glebsts Thanks! 👍


April 2023 JDK8 Triage

Release Summary Report for release-openjdk8-pipeline
Report generated at: Wed, 19 Apr 2023 12:19:56 GMT
TRSS Build and TRSS Grid View
Jenkins Build URL https://ci.adoptium.net/job/build-scripts/job/release-openjdk8-pipeline/15/
Started by user Andrew Leonard at 4/19/2023, 4:54:20 AM

Platforms
Details
Status

jdk8u-release-alpine-linux-x64-temurin ❌ FAILURE ❌
Run manually

jdk8u-release-linux-aarch64-temurin ❌ FAILURE ❌
link

jdk8u-release-linux-ppc64le-temurin ⚠ UNSTABLE ⚠
link

jdk8u-release-linux-x64-temurin ⚠ UNSTABLE ⚠
link

jdk8u-release-mac-x64-temurin ⚠ UNSTABLE ⚠
link
✔

jdk8u-release-solaris-sparcv9-temurin ❌ FAILURE ❌

jdk8u-release-solaris-x64-temurin ❌ FAILURE ❌

jdk8u-release-windows-x64-temurin ⚠ UNSTABLE ⚠
link

jdk8u-release-windows-x86-32-temurin ⚠ UNSTABLE ⚠
link

x86-64_windows
Test_openjdk8_hs_extended.openjdk_x86-64_windows ⚠ UNSTABLE ⚠
Test_openjdk8_hs_extended.openjdk_x86-64_windows_testList_2 ⚠ UNSTABLE ⚠
jdk_management_0 => deep history 3/7 passed | possible issues

x86-64_mac

x86-64_linux

aarch64_linux

ppc64le_linux
Test_openjdk8_hs_extended.openjdk_ppc64le_linux ❌ FAILURE ❌
Test_openjdk8_hs_extended.openjdk_ppc64le_linux_testList_2 ❌ FAILURE ❌
hotspot_jre_0 => deep history 3/7 passed | possible issues
Post Test => deep history 6/7 passed | possible issues
hotspot_jre_1 => deep history 3/7 passed | possible issues

sparcv9_solaris
Test_openjdk8_hs_extended.openjdk_sparcv9_solaris ❌ ABORTED ❌
Test_openjdk8_hs_extended.openjdk_sparcv9_solaris_testList_0 ❌ ABORTED ❌
Test_openjdk8_hs_extended.openjdk_sparcv9_solaris_testList_1 ❌ ABORTED ❌
hotspot_jre_0 => deep history 0/5 passed | possible issues
Test_openjdk8_hs_extended.system_sparcv9_solaris ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07)
OpenJDK 64-Bit Server VM (Temurin)(build 25.372-b07, mixed mode)

OAuthTest_0 => deep history 0/15 passed | possible issues
Test_openjdk8_hs_extended.functional_sparcv9_solaris ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07)
OpenJDK 64-Bit Server VM (Temurin)(build 25.372-b07, mixed mode)

CryptoTests_0 => deep history 0/15 passed | possible issues
https://ci.adoptium.net/job/Test_openjdk8_hs_extended.openjdk_sparcv9_solaris/83/ was aborted and needs rerun.

x86-64_solaris
Test_openjdk8_hs_extended.functional_x86-64_solaris ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07)
OpenJDK 64-Bit Server VM (Temurin)(build 25.372-b07, mixed mode)

CryptoTests_0 => deep history 0/15 passed | possible issues
Test_openjdk8_hs_extended.openjdk_x86-64_solaris ⚠ UNSTABLE ⚠
Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0 ⚠ UNSTABLE ⚠
jdk_security3_0 => deep history 1/5 passed | possible issues

ppc64_aix
Test_openjdk8_hs_extended.openjdk_ppc64_aix ⚠ UNSTABLE ⚠
Test_openjdk8_hs_extended.openjdk_ppc64_aix_testList_0 ⚠ UNSTABLE ⚠
hotspot_jre_1 => deep history 0/2 passed | possible issues
hotspot_jre_0 => deep history 0/1 passed | possible issues

Note: https://github.com/adoptium/aqa-tests/issues/4518#issuecomment-1521669374
The archive includes former release tap files, need to take a look.

arm_linux
Test_openjdk8_hs_extended.openjdk_arm_linux ⚠ UNSTABLE ⚠
Test_openjdk8_hs_extended.openjdk_arm_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_2 => deep history 0/5 passed | possible issues
Test_openjdk8_hs_extended.openjdk_arm_linux_testList_1 ⚠ UNSTABLE ⚠
hotspot_jre_2 => deep history 0/6 passed | possible issues
jdk_jfr_2 => deep history 0/6 passed | possible issues
Test_openjdk8_hs_extended.openjdk_arm_linux_testList_2 ⚠ UNSTABLE ⚠
jdk_other_2 => deep history 2/5 passed | possible issues
jdk_security3_2 => deep history 0/5 passed | possible issues
jdk_instrument_2 => deep history 4/5 passed | possible issues
Test_openjdk8_hs_sanity.openjdk_arm_linux ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07)
OpenJDK Client VM (Temurin)(build 25.372-b07, mixed mode)

jdk_util_2 => deep history 0/19 passed | possible issues
Test_openjdk8_hs_sanity.system_arm_linux ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07)
OpenJDK Client VM (Temurin)(build 25.372-b07, mixed mode)

TestJlmRemoteThreadAuth_2 => deep history 6/18 passed | possible issues

Continuing arm_linux https://github.com/adoptium/aqa-tests/issues/4518#issuecomment-1524221925
Grinder/7252 (jdk_other_2, jdk_security3_2 failures)
sun/security/ssl/GenSSLConfigs/main.java.main still fails
%% Server accepted from 1bfd2a038c8d:46450
%% Server accepted from 1bfd2a038c8d:46466
%% Client-45
javax.net.ssl.SSLHandshakeException: No negotiable cipher suite
	at sun.security.ssl.ClientHello$ClientHelloKickstartProducer.produce(ClientHello.java:538)
	at sun.security.ssl.SSLHandshake.kickstart(SSLHandshake.java:510)
	at sun.security.ssl.ClientHandshakeContext.kickstart(ClientHandshakeContext.java:112)

jdk_instrument_2 and jdk_net_2 need rerunning

Double checked all action needed has been taken except for arm.


Can't set a location (Error: Radius not valid)

Checklist

[x] I have read the FAQ
[x] I have checked if this issue already exists (both open and closed issues)
[x] I am using the most recent version of pogom from the master branch
[ ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[ ] I'm posting the complete log
[x] I'm using a descriptive title for this issue

My Issue
Somehow I'm not able to set a location marker on the map. It doesn't matter what numbers I put in, after clicking "add new location" I always get the error "Radius not valid. Please note that the radius' unit is in meters and must be a whole number. It also should be >100m."
Tried "10", "10m", "10 m" etc....what am I doing wrong/what am I missing?

I'm on OSX 10.10.5.
Thanks for everything and keep up the great work everyone!

Enter a plain number that is bigger than 100.

Alright, thank you very much!


continuous integration for summary statistics and readme data

At the moment the summary stats and readme files need to be generated manually.

[ ] Based on our discussion, let's move this to a CI step so that users can more easily contribute datasets/dataset metadata without having to rerun those scripts.
[ ] Use the CI to issue some basic checks on their metadata.yaml file to make sure it's the proper format.

some basic metadata checks:

[ ] all elements of schema are present
[ ] dataset hash ids should be unique
[ ] legal values for things like feature type

I added CI into PMLB2.0 branch with 2 unit tests for checking metadata of a example (discussed in #22). The 1st CI build was failed due to due to a error in installation step and [https://travis-ci.org/github/EpistasisLab/penn-ml-benchmarks/builds/683862813) passed without error.

since this is now handled by pandas profiling in CI, i'm closing this issue.

Scenario 1 dataset.tsv.gz changed/updated without metadata.yaml

auto-generate metadata.yaml, readme and summary_stats.csv, pandas_profiling

Scenario 2 dataset.tsv.gz changed/updated with metadata.yaml

auto-generate  readme and summary_stats.csv, pandas_profiling

auto-generate metadata.yaml, readme and summary_stats.csv, pandas_profiling

Scenario 3 only update metadata.yaml

do nothing?

I think we should separate get_updated_datasets() and get_updated_metadatas().

Contributor adds a new dataset. When the PR is submitted:

get_updated_datasets() picks up this new dataset. CI autogenerates metadata.yaml, readme.md, summary_stats.tsv, pandas profiling, and updates dataset_names (and classification_dataset_names and regression_dataset_names, if we keep these variables).
A reviewer asks the contributor to manually update the metadata.yaml.
CI adds the dataset name to dataset_with_metadata.
Merge.

Contributor comes in and contributes to a metadata.yaml file. Let's assume that the inferred "task" is incorrect and contributor fixes this.

get_updated_metadatas() picks up this new dataset. CI regenerates summary_stats.tsv, updates classification_dataset_names and regression_dataset_names, and adds the dataset name to dataset_with_metadata.

Closed by #110 and #111.


[stable/odoo] Update PostgreSQL as deps

Update Odoo dependencies to include the new PostgreSQL version
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

/lgtm


checking array with view index

From<EMAIL_ADDRESS>on November 27, 2012 00:13:18
What steps will reproduce the problem? 1. call clearEditText() with the EditText id What is the expected output? What do you see instead? There is an IndexOutOfBoundsException thrown in Waiter->waitForAndGetView() function What version of the product are you using? On what operating system? Robotium 3.6 on Android 2.3.6 Please provide any additional information below. In waitForAndGetView() function, the line view = views.get(index); is not correct. It should iterate through all the views in the array, and check it's corresponding id against index
Original issue: http://code.google.com/p/robotium/issues/detail?id=360

From<EMAIL_ADDRESS>on November 27, 2012 08:16:26
Index and ID is not the same thing. Index is used for blackbox reasons. What you want to do is:
EditText myEditText = solo.getView(R.id);
solo.clearEditText(myEditText)
Status: Invalid
Owner<EMAIL_ADDRESS>

From<EMAIL_ADDRESS>on November 28, 2012 22:21:10
In any case, the code:
view = views.get(index);
is not correct.
It should be:
for (T v : views) {
if (v.getId() == index) {
view = (T) v;
break;
}
}

From<EMAIL_ADDRESS>on November 28, 2012 22:23:12
Index and ID is not the same thing.

From<EMAIL_ADDRESS>on November 28, 2012 22:28:11
OK. Finally understood. Sorry about that.


Fix test cases

This has become quite a large commit. I started from #74 to see if I could fix all the test cases. So basically this commit introduces a few things:

mix format the codebase (was not really needed, but makes it easier for contributions in the future)
Fix various existing test cases by sometimes adding longer timeouts, restarting the :swarm application inbetween tests, clearing the registry, adjusting the node blacklist, etc.
Some test cases still randomly failed (most notably quorum_test.exs; after tracing it down to the usage of the Clock CRDT, I merged #85 into this branch, which fixed the remaining tests.
Clean up the test output; added SWARM_DEBUG=true environment variable to see all verbose messages (documented in the README).
Remove use of  --seed 0 argument, to ensure tests can be executed independently of each other.

I can imagine this is a big PR to review but I did not touch any logic code except for merging in the #85 branch. (well, except e793c7889271f8aa77d5d3651b5bb538e504d98d, but those changes were overwritten by the #85 merge anyway)
Eventually, a lot of (clustering) boilerplate could be lifted out of the test code but I noticed you're already working on that ;-)

Any movement on this @bitwalker?

Looks like this conflicts with #85 - is this intended to replace that PR? I can undo the merge and merge this instead if it supercedes it - otherwise please rebase :)

Seems most conflicts are related to formatting.

@arjan I did the merge for you, can you verify when you get a chance? I'm pretty sure it was all formatting related, but there were larger changes in one of the test files, and I chose to just favor the changes in this PR rather than try to parse through what all of the changes were, since formatting was mixed in there.
Speaking of which, please don't make formatting changes as part of PRs like this, I'm totally fine with those being made in their own PR, or alongside small changes, because they can basically be merged straight away, but it makes large changes harder to review when mixed together, and in cases like this, can result in somewhat painful merges. No worries this time though :)

Thanks so much!


Error generating multiple build architectures

if universalApk false and there's a list with
"armeabi-v7a", "x86", "arm64-v8a", "x86_64" we want to generate, then
a single apk file is generated instead of 4, without a specific architecture in it's name.

Hi,
we are currently unable to reproduce this issue because non of our app projects uses the NDK or ABI specific code. Maybe we find time to test this on an older project. But not ETA.
Thanks for reporting this.


data button response

Hi Josh,
Is is possible to record the data of all button presses when using the button-response plugin?
My stimulus is a video and participants have to respond several times throughout the video using 2 buttons. I thus need the data of every button that was pressed during the trial.
Is there any way to accomplish this?

You would need to modify the plugin file to do this. Right now it is set up to be a single button response.
The key line is L68 of the button response plugin. That line causes the trial to end when a button is pressed. You could modify the logic inside the after_response function to record the button press and the timing.
Then you could end the trial when the video file ends, borrowing the technique from the video plugin:
document.getElementById('jspsych-video-player').onended = function(){
  end_trial();
}

If you are comfortable modifying the video plugin to include this as an option, it would be a great addition to the plugin and I would be eager to add it to the library.

In the button-response plugin, I've set response_ends_trial to false, and i've set timing_response to the end of the video (manually). I've tried to use an event handler to record the button press but this didn't work. Any idea's on how I could record each button press in L68 of the plugin?

I would suggest modifying the after_response function. Perhaps create an array to hold the responses, and then push each response onto the array. When the trial ends, you can record the JSON encoding of that array as data for the trial.
Sorry that's a bit vague, but hopefully it gets you pointed in the right direction.

I'm closing this issue, but feel free to continue to use the thread if you have further questions.

With help we were able to change the button-response plugin to record every button press and rt.
I've attached the plugin. Maybe it'll be useful to someone else.
jspsych-button-response kopie.js.zip

Hi Josh,
I found this four year old thread when searching for a way to record measures of beats per minute (BPM), i.e. several button presses within the same 15 sec audio trial (later I will need video trials as well). I am fairly confident that I will be able to use the modified plugin above (thanks for posting this, jwitvoet) to convince the current audio-button-response plugin to do the trick. I have more confidence than experience, though, and it will take me a while, so before I do so, I would like to ask if you know of anything created more recently that can be used to measure tapping data?
Thanks!
Cecilie

Hi Cecilie,
I don't think there are any more recent developments that will support this. I know @davidjohnbaker1 was doing some work with music and jsPsych. @davidjohnbaker1 do you know of anything that fits this task?
Josh

Thanks Josh,
this was actually easier than I thought. I've essentially copied the relevant lines from the script above and merged them into the audio-button-response plugin and it works fine. I am going to see if I can make it log the button presses instead of releases (for precision) and then I can post the plugin here, or would you like med to try to make a proper pull request?
/Cecilie


raml plugin cannot find source for class in dependent library

I just started to use this plugin for a project.  It works well enough for code contained in the system and  3rd parties.
However, I have a class in one of my dependent libraries that I include and the plugin complains that it cannot find the source.
I generated a master java doc directory of all the dependent libraries that I use and included it in my usage of the plugin to generate the raml specification.
here is how I define the raml plugin

generate-raml

com.phoenixnap.oss
springmvc-raml-plugin
${raml.plugin.version}

/Users/larrymitchell/phiupdate/nfvusvcssupport/apidocs
${raml.spec.path}
/
${project.version}
false
false
${project.name}

generate-springmvc-api-docs
compile

generate-springmvc-api-docs

The java doc path points to the javadoc directory
I ran maven with the -X option to see what the issue was
[WARNING] *** WARNING: Missing Source for: ExampleController. JavaDoc Unavailable.
[INFO] Added call: /v1/example/testecho GET from method: testEcho
[DEBUG] Getting Javadoc for: PhiGeneralResponse
[DEBUG] /Users/larrymitchell/phiupdate/nfvusvcssupport/apidocs
... remainder cut for brevity ...
[DEBUG] /Users/larrymitchell/phiupdate/nfvusvcssupport/apidocs/com/cisco/phisphere/foundations/common
Note that foundations common is where the class is described via javadoc
note that if we ls this directory
LARMITCH-M-L2BE:ramlservice larrymitchell$ ls -l /Users/larrymitchell/phiupdate/nfvusvcssupport/apidocs/com/cisco/phisphere/foundations/common
total 152
-rw-r--r--   1 larrymitchell  staff  41901  1 Mar 09:53 PhiGeneralResponse.html
drwxr-xr-x   3 larrymitchell  staff    102  1 Mar 09:51 class-use
drwxr-xr-x  13 larrymitchell  staff    442  1 Mar 09:51 exceptions
drwxr-xr-x   8 larrymitchell  staff    272  1 Mar 09:51 json
drwxr-xr-x  10 larrymitchell  staff    340  1 Mar 09:51 metrics
-rw-r--r--   1 larrymitchell  staff   1045  1 Mar 09:53 package-frame.html
-rw-r--r--   1 larrymitchell  staff   5555  1 Mar 09:53 package-summary.html
-rw-r--r--   1 larrymitchell  staff   5590  1 Mar 09:53 package-tree.html
-rw-r--r--   1 larrymitchell  staff  10673  1 Mar 09:53 package-use.html
drwxr-xr-x   9 larrymitchell  staff    306  1 Mar 09:51 stream
I see that it scans through the whole javadoc collection and fails to find the  PhiGeneralResponse class that needs referencing.
....  the end of the scan ....
[DEBUG] /Users/larrymitchell/phiupdate/nfvusvcssupport/apidocs/com/cisco/phisphere/swagger/controller/class-use
[WARNING] *** WARNING: Missing Source for: PhiGeneralResponse. JavaDoc Unavailable.
[INFO] Parsing resource: ExampleController
Is there something else that needs to be done to get this to work?

One of the slowest parts of the generation process was the searching of files on disk. As such we added a number of heuristics to allow the search algorithm to remove large parts of search space to improve the speed.
If you take a look at https://github.com/phoenixnap/springmvc-raml-plugin/commit/40649fb1a8f7126cee5258f940b73b39bfce7674 you will see that the plugin expects source code to follow the Maven/Gradle folder structure (src/main/java) and will skip other folders.
You can either try change the folder you are using to accomodate this heuristic, alternatively we will welcome a PR that allows these to be switched on/off via configuration

Thanks for getting back to me.
I was assuming that it would search the generated javadoc code for the specific external element, which in my case is PhiGeneralResponse.html in that folder.
Ok, I suppose I can restructure the generated javadoc to accommodate that structure.
My projects do follow the maven structure.  src/main/java

no problem, keep in mind that it parses the actual source code (.java) files, not the generated html javadoc files

ok, so then I misunderstood.
The missing class PhiGeneralResponse.java is in another project.  So from your comments, I would be pointing at that other source directory.  Which configuration directive is used for that?

currently we support 1 folder which you can configure using this maven config: D:/
Since only one path is supported you would need to give it a folder that is the root of all your projects i'm afraid. If this doesnt work for you it can be extended quite easily to support an array of folders (however we currently do not have the resources for this since we are focusing on RAML 1.0 support)

I tried putting my projects under one folder and it worked by generating the raml.
It was my misunderstanding of what  was for.
I will take a look at the multiple folder issue.  I have a few things ahead of it so it might a take a week before I can get to it.


fix(yaml-example): inconsistent args

change yaml example to be consistent with its configuration
fix #707, #708

@homu r+

:pushpin: Commit 847f719 has been approved by kbknapp

:zap: Test exempted - status


moved-/.regal to policies/wasm/policies/.regal

Notes for Reviewers
Moved  .regal/  to  policies/wasm/policies/.regal
This PR fixes #12139
Signed commits

[x ] Yes, I signed my commits.

@moiz2405
Thank you for your contributions! Let's discuss this during the Meshery Development call today at 7:30 PM IST (9:00 AM CT). Adding it as an agenda item to the meeting minutes || meeting link.

@moiz2405 Thank you for your contributions! Let's discuss this during the Meshery Development call today at 7:30 PM IST (9:00 AM CT). Adding it as an agenda item to the meeting minutes || meeting link.

Hi @vishalvivekm, I'm looking forward to the meeting and hoping to get some insights on proper workflow and recommended practices.

@moiz2405 are you no longer working on this? Please indicate if the related issue should be reassigned.


Implement Flit - [merged]

In GitLab by @arisilon on May 22, 2023, 18:47
Merges feature/flit -> master

In GitLab by @arisilon on May 22, 2023, 18:50
mentioned in commit b78a02dae1bf6276e2fad0ca1156e19f27c1192c

In GitLab by @arisilon on May 22, 2023, 18:47
enabled an automatic merge when the pipeline for 948d7983b13620cde13a4eb5009ae46dccc22c85 succeeds


OnCommandResultListener.onCommandResult() is called prematurely

I'm using AndroidShell for an rsync app, and almost immediately after invoking rsync, the OnCommandResultListener that I pass to Shell.Builder.open() has its onCommandResult() called. The command can continue running for several minutes thereafter. I see the same behavior if I run "top" instead of "rsync" so it doesn't appear to be tied to any specific long-running command.

Some further experimentation shows that an OnCommandResultListener passed to addCommand() doesn't return until the shell command completes, which is what I expected. I don't know if this is by design or not, but it's at the very least a workaround.

Please see the updated library


fix: update broken visualization in the style guide, clean up headings to match other languages

Remove broken visual with  by removing alert
Fix headings to match other languages should be 3 "#" not 4.
Clear up some confusing language.
Broken Visual for the Explanation

@grayside can you take a look?


add libdrm-amdgpu-dev for focal image with empty hipDeviceGetName()

https://github.com/ROCm/frameworks-internal/issues/6949
This patch also needs go to

[x]  develop-upstream-QA-rocm61 https://github.com/ROCm/tensorflow-upstream/pull/2392
[x]  r2.15-rocm-enhanced https://github.com/ROCm/tensorflow-upstream/pull/2393
[x] r2.14-rocm-enhanced https://github.com/ROCm/tensorflow-upstream/pull/2394
[x] r2.13-rocm-enhanced https://github.com/ROCm/tensorflow-upstream/pull/2395

retest Ubuntu-CPU please

You need to add the repo here as well:
https://github.com/ROCm/tensorflow-upstream/blob/develop-upstream/tensorflow/tools/tf_sig_build_dockerfiles/setup.rocm.sh

@jayfurmanek the change is done. PTAL

retest Ubuntu-CPU please

retest Ubuntu-CPU please


How to update an existing install ?

Hi,
I am happy with my fresh install of Koel but I am wondering : how to update it ?
After git pull, do I need to run npm install and/or composer install ?

The instruction is right in the README.

Thank you, I have read carefully the wiki,not the README...


New approach to deploy Python requirement file in spark pool

Problem Statement

Currently, in this repo, we use script to deploy python packages after spark pool created. We could simply use bicep to do so.

Proposed Solution

Use bicep to create spark pool first and then update the pool using python packages

Alternative Proposals

Additional Context

Next Steps

[ ] Team consensus to proceed
[ ] Complete Design Review Template (if applicable)
[ ] Schedule Design Session

Hello @04diiguyi, maybe you can help me with this issue. I don't see the possibility to deploy the Spark pool within the bicep specification: https://learn.microsoft.com/en-us/azure/templates/microsoft.databricks/workspaces?pivots=deployment-language-bicep. Could you please point me to any documentation were you've seen that is possible? Thanks in advance!

@04diiguyi, could you please reply until 29th of November, so we decide if it is feasible to work on the issue or shall we abandon it? Thanks.

I'm closing this issue as I didn't get more information. Please feel free to re-open later if you have the clarifications we asked. Thank you!


[BUG] merge plugin doesn't seem to work too well with files

Bug description:
Section 5.2.23 of the manual gives an example of merging live transport streams.
Could an example be given of an equivalent scenario using captured transport stream files?
How to reproduce:
Capture a main stream, say a.ts - ensure it has lots of stuffing available.
a.ts is CBR stream with valid PCRs
"zap" a SPTS from another stream, resulting in b.ts
b.ts may be a VBR stream.
Object is to insert the service from b.ts into a.ts and merge SI, resulting in c.ts
$ tsp -I file a.ts -P merge "tsp -I file b.ts" -O file c.ts
Expected behavior:
c.ts should include all the services from a.ts as well as the single service from b.ts
Errors and logs:
b.ts is inserted into a.ts using all available stuffing at the bitrate of a.ts - it is as though the insertion is not respecting the bitrate (by PCRs) of b.ts (this is clearly visible in a tool like DVBInspector)
c.ts is unplayable in respect of the service from b.ts.  Services from a.ts seem ok.

[be sure to surround verbatim log lines with "~~~" lines]

Environment:
MacOS: 3.30-2690 (homebrew)
Debian: 3.29-2640 (built from source)
Additional information:
I apologies in advance if the problem is more my lack of understanding.

Hi @bstanden
The merge plugin inserts TS packets as they arrive over time. They are not placed according to the PCR from the merged stream. On the contrary, PCR from the merged stream are updated according to their placement in the final stream (unless --no-pcr-restamp is used).
It typically works fine when streams are played at rendering speed. When inputs are files, the input TS are read at full disk speed and the merge is completely different, probably completely irrelevant.
So, the merge process won't work at file speed. You need to recreate the rendering speed using a regulate plugin. In both tsp commands in your case. The drawback is that the processing is slower (rendering speed instead of file speed).

Hi @lelegard
Thank you for the detailed response - this is understood.  I'll close the issue as it appears that what happens is 'by design' and as you suggest, the "merging" of files in this way is probably not a relevant process.
I've had some success using the 'regulate' plugin in the way you suggest - of course, this means merge processes take time, particularly if multiple services are to be merged.
I'll raise a feature request instead :)
Bob


Allow to add PVCs in order to retain data or provide some room to sidecars

As a more advanced users feature and to be CassKop compatible, I'm proposing to add this feature which would provide the ability to add PVCs to :

provide more space to retain logs (let's imagine cdc is enabled and it needs more room)
provide other types of PVCs for certain types of files
...

In CassKop the same parameter is used but it hosts PVCs that can then be referred to in sidecarConfigs. The controller then create those PVCs.
I'd like to propose the same here and then those PVCs can be used in podTemplateSpec. If we go down that road we should probably use a different name to specify those PVCs in order to be backward compatible for existing users.

Can't you just add other PVCs through the PodTemplateSpec property?
With the medusa integration in k8ssandra, we are not adding any PVC, but we are adding additional volumes.

@jsanda no you can't, see https://godoc.org/k8s.io/api/core/v1#PodSpec. You need to create those PVCs somehow and get them defined. That's what storageConfig is used for in both our repos. when the controller parses it it creates the corresponding PVCs.

yes that's right @cscetbon - in other words podTemplateSpec doesn't give the ability to edit the statefulSet's volumeClaimTemplates

@jimdickinson @jsanda What about adding a parameter called volumeClaimTemplates then ? It would be really similar to podTemplateSpec but for PVCs that could then be mounted in sidecars ? We could have something like
  volumeClaimTemplates:
    - mountPath: "/var/lib/cassandra/log"
      name: "gc-logs"
      pvcSpec:
        accessModes:
          - ReadWriteOnce
        storageClassName: local-path
        resources:
          requests:
            storage: 200Mi
    - mountPath: "/var/log/cassandra"
      name: "cassandra-logs"
      pvcSpec:
        accessModes:
          - ReadWriteOnce
        storageClassName: local-path
        resources:
          requests:
            storage: 200Mi

We could also make cassandra required or not in that parameter and deprecate storageConfigs. wdyt ?

I'm +1 for adding that in the existing StorageConfig struct
https://github.com/datastax/cass-operator/blob/e68babc3dfcf2be88a945ec3860f4feafc8ffbf3/operator/pkg/apis/cassandra/v1beta1/cassandradatacenter_types.go#L211

I like it!
On Sun, Dec 6, 2020 at 2:35 PM Jim Dickinson<EMAIL_ADDRESS>wrote:

I'm +1 for adding that in the existing StorageConfig struct
https://github.com/datastax/cass-operator/blob/e68babc3dfcf2be88a945ec3860f4feafc8ffbf3/operator/pkg/apis/cassandra/v1beta1/cassandradatacenter_types.go#L211
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datastax/cass-operator/issues/327#issuecomment-739551698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABJBOP5EM7ISHUNATJJKXDSTPMIZANCNFSM4UJ7OIEQ
.

--

John

volumeClaimTemplates is an existing statefulset field of type PersistentVolumeClaim. So I'm using AdditionalVolumes instead. Let me know if you have a better idea
StorageConfig:
    cassandraDataVolumeClaimSpec:
      storageClassName: server-storage
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi:
  AdditionalVolumes:
      - mountPath: /var/lib/cassandra/log
        name: gc-logs
        pvcSpec:
          accessModes:
            - ReadWriteOnce
          storageClassName: local-path
          resources:
            requests:
              storage: 200Mi
      - mountPath: /var/log/cassandra
        name: cassandra-logs
        pvcSpec:
          accessModes:
            - ReadWriteOnce
          storageClassName: local-path
          resources:
            requests:
              storage: 200Mi


Update telemetry-disable-remarks.md

Thanks Andrew.
Applied this by other means. Will respond in email.


Add tests for xid, multixid and oid wraparound

Branch nonrel_wal_test_xid_wraparound contains a test, that illustrates the problem with xid wraparound.
It fails on main too (with different symptoms), but I suggest concentrating our efforts on nonrel_wal.
In a current shape, the test is too hacky to propose as PR. I'll try to straighten it up.
If you have any ideas on how to make it better, I'm all ears.
See also a discussion in hackers about similar testing scenario:
https://www.postgresql.org/message-id/flat/CAP4vRV5gEHFLB7NwOE6_dyHAeVfkvqF8Z_g5GaCQZNgBAE0Frw%40mail.gmail.com#e10861372aec22119b66756ecbac581c

I doesn't understand what this test is demonstrated.  First of all there is no any xid wraparound. You need to execute 2^31 transactions to cause XID wraparound.
This test is failed in the following assertion:
        # ensure that oldest_xid advanced
>       assert int(oldest_xid) < int(oldest_xid1)
E       AssertionError: assert 727 < 727
E        +  where 727 = int('727')
E        +  and   727 = int('727')

But 50000 transactions performed by pgbench in this test seems to be not enough to advance oldestXid in checkpoint, taken in account that autovacuum_freeze_max_age=100000 (twice more).
If we perform 500000 transactions (ten times more), then this check passed.
The next failure is:
        # ensure that we restored fields correctly
        assert int(xid1) <= int(xid2)
>       assert int(oldest_xid1) == int(oldest_xid2)
E       AssertionError: assert 403881 == 727
E        +  where 403881 = int('403881')
E        +  and   727 = int('727')

We update checkpoint.oldestXid on CLOG_TRUNCATE records, but it was not performed.

With commit c564272 this test is passed at nonrel_wal branch with number of pgbench transactions increased till 500000.
But it takes about half an hour time to compete.

With commit c564272 this test is passed at nonrel_wal branch with number of pgbench transactions increased till 500000.
But it takes about half an hour time to compete.

Ah yeah, consuming enough transactions to trigger XID wraparound can take a while... What I've done in the past is to write a C function specifically for testing that advances ShmemVariableCache->nextXid directly. the ExtendCLOG(), ExtendCommitTs() and ExtendSUBTRANS() expect to be called for every XID, because they need to extend the slru files whenever you cross a page boundary, so one safe way to do that is to skip over XIDs that are "not interesting" to those Extend*() functions, and call GetNewTransactionId() as usual for others. Something like this:
#define BORING_XID_INTERVAL 1024
    LWLockAcquire(XidGenLock, LW_EXCLUSIVE);
    nextXid = ShmemVariableCache->nextXid;
    remainder = nextXid % BORING_XID_INTERVAL;
    if (remainder >= FirstNormalTransactionId &&
        remainder < BORING_XID_INTERVAL - 1 &&
        !TransactionIdFollowsOrEquals(nextXid, ShmemVariableCache->xidVacLimit))
    {
        /* bump nextXid to just before the next non-boring XID */
        nextXid += BORING_XID_INTERVAL - remainder - 1;
        LWLockRelease(XidGenLock);
    }
    else
    {
        LWLockRelease(XidGenLock);
        /* call GetNewTransactionId() or something to get a new XID the usual way */
    }

Andres Freund and @lubennikovaav had some discussion on psql-hackers on adding a standard way to test XID wraparound to upstream: https://www.postgresql.org/message-id/CAP4vRV5gEHFLB7NwOE6_dyHAeVfkvqF8Z_g5GaCQZNgBAE0Frw%40mail.gmail.com. That would be very handy. We had a function like that in GPDB as well (https://github.com/greenplum-db/gpdb/blob/master/src/test/regress/regress_gp.c#L1955), but it would be good to get it into upstream, Postgres could use some tests around XID wraparound too.

https://github.com/zenithdb/zenith/pull/351 comments out the code to handle CLOG and multixid offsets wraparound. Just by looking at the code, those looked wrong to me.

the test is not part of any CI ATM because it takes a lot of time to run this test

the next step is to commit this :)


modulate_by methods

Wherever you have a map_by method, we should also have a modulate_by method.

Thought about it and realized this isn't really needed at all. If you've got a reference to the led, you can already get all of that information.


ERROR : No access to github copilot found

Hey,
I am having this error while creating my portfolio site on github codespace for my technical onboarding. And there I am recieving this error? What should I do?
Anyone kindly guide me?

Hi @Tehreemfatima489  the error indicates that you don't have access to github copilot, follow this step by step guide on how to redeem your GitHUb copilot for students

@AnthonyByansi Is it necessary for technical onboarding? because I have done everything from instructions. and now my website is waiting for deployment and my commit is queued for 10 hours. Is it because of I do not have Github Copilot?

GitHub Copilot isn't a necessity for you to complete your technical onboarding.
The instructions provide all you need to accomplish your technical onboarding. Please make sure you have your changes pushed to the main branch If you run into further issues, please DM me on teams so I can help

@AnthonyByansi Thank you. I have solved the issue and completed my technical onboarding


Issue tracker is hard to find

I found it eventually via https://admin.toolforge.org/tool/zonestamp (which, for some reason, has two info entries...) but a link from https://zonestamp.toolforge.org/ itself would be nice.

Apparently there is also https://github.com/hartman/zonestamp, with a second set of issues, so yeah, I think it’s fair to say that it’s not exactly easy to find “the” issue tracker…
(For the record, I also found this one via tooladmin.)

Haha, I also arrived here after diligently searching (I arrived here via Toolhub). It would be good to display a canonical link for anyone using Zonestamp itself.


tests: General improvements to operator script

This PR gives general improvements to the operator script that is being used in tests. This PR includes changes like better variable definition and the use of a variable that has been already defined.

changes applied

@stevenhorsman @wainersm the license check failed, do you have any experience with that? (this change should not have affected that)

@stevenhorsman @wainersm the license check failed, do you have any experience with that? (this change should not have affected that)

I think we can ignore it as no-one in development has access to the report to check the issue. There seems to have been some sort of org setting that has triggered this check running on all PRs as we have the same issue in the CAA repo.

Well based on https://app.fossa.com/projects/git%2Bgithub.com%2Fconfidential-containers%2Foperator/refs/branch/main/abe928347a0ff9c3ecbeafceb0c761cc33cd4af1/browse/licenses I'd say it complains about go.mongodb.org/mongo-driver dependency, but that one is not new. Anyway I don't have access to the full report and also think it should be merged.

The license check has been failing for a while. Unfortunately it's really hard to get details on why. Nobody has an account with FOSSA, but sometimes you can stumble onto the issue on the FOSSA page. Last I checked it was actually complaining about Kata, but I'm not sure what is happening this time. I wouldn't let it block this PR.

Thanks for the confirmation, let me merge this awesome numbered PR :-)


ImportError: cannot import name 'interactive'

Rasa version:rasa core-0.14.4 (updated from 0.8.2), rasa nlu-0.15.0
Python version: 3.6.6
Operating system (windows, osx, ...): windows 10, core i7 processor
Issue:running python train_interactive.py gives this error:
C:\Python36\lib\site-packages\h5py_init_.py:34: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "train_interactive.py", line 12, in
from rasa_core.train import interactive
ImportError: cannot import name 'interactive'
Content of configuration file (config.yml):
{
  "pipeline":"spacy_sklearn",
  "path":"./models/nlu",
  "data":"./data/data.json"
}

Content of domain file (domain.yml) (if used & relevant):
slots:
  location:
    type: text

intents:
 - greet
 - goodbye
 - inform

entities:
 - location

templates:
  utter_greet:
    - 'Hello! How can I help?'
  utter_goodbye:
    - 'Talk to you later.'
    - 'Bye bye :('
  utter_ask_location:
    - 'In what location?'

actions:
 - utter_greet
 - utter_goodbye
 - utter_ask_location
 - action_weather

After I updated rasa_core, my nlu_model is not compiling as well.

You're going to have to update a lot of your code and also configuration, given you're using a very old rasa_core version. Please take a look at the migration guide here: https://rasa.com/docs/core/migrations/

Hi @akelad , I updated the rest of configurations. It's working fine now, thank you so much.

Hi @akelad , I updated the rest of configurations. It's working fine now, thank you so much.

hi @meghnasmhs , Can you specify how to fix it?

@phanphuc240797 ,Update your requirements.txt file with the latest version of every library/software along with rasa core and rasa nlu.

@meghnasmhs  thanks you.

@meghnasmhs, can you please post the code from your working Weatherbot tutorial? Getting the same error as you, and my dialogue_management_model.py file causes the bot to only use greetings.

You're going to have to update a lot of your code and also configuration, given you're using a very old rasa_core version. Please take a look at the migration guide here: https://rasa.com/docs/core/migrations/

Hi- I've seen you reply with this link on several pages, but it simply brings me to the rasa docs main page. Is the Migration guide the page you intend to be linking?

You're going to have to update a lot of your code and also configuration, given you're using a very old rasa_core version. Please take a look at the migration guide here: https://rasa.com/docs/core/migrations/

Hi- I've seen you reply with this link on several pages, but it simply brings me to the rasa docs main page. Is the Migration guide the page you intend to be linking? @akelad

lets uninstall version existing and install new version for rasa_core or rasa_nlu

@arjunsr1 What code are you looking for?


Flyout / Slideout / Blade / Drawer

What is being submitted?
Similar to a modal, an expansion panel slides in from the side of the screen and overlays all or a portion of a page.
Why are you submitting?

What evidence do you have that it’s needed by multiple services across government?
What evidence do you have that it meets the needs of the users of those services?
Have you checked that it doesn’t already exist in the DIO Design System?

Examples, links, and research
Questions to consider

How does an expansion panel differ from a modal?

Do we need to document when to use one or another?

How does an expansion panel differ from the Side Navigation?

Refer to:

Should an overlay display when a panel is expanded?
What does the button to open a panel look like?
Is it possible to have multiple panels open at the same time?
How do you handle multiple panels on the same page?
Any recommendations for panel states persisting as you navigate between pages?

Anything else

Add any other context or screenshots about the feature request here.

Oh, hai! This is my thing that I'm doing


Add support for tiling an array to the specification

This PR

resolves https://github.com/data-apis/array-api/issues/655 by adding an API for creating a new array by tiling an input array a specified number of repetitions.
requires that the second positional argument (repetitions) be a tuple of ints. NumPy et al support providing an integer; however, PyTorch and TensorFlow do not. PyTorch requires a tuple. TensorFlow requires an array. This PR seeks to find common ground by requiring repetitions to be a tuple.
supports prepend behavior, as supported by NumPy et al and PyTorch. I.e., if len(repetitions) is less than the rank of x, then ones are prepended to repetitions. If the rank of x is less than len(repetitions), singleton dimensions are prepended to x. TensorFlow does not support this behavior, requiring that repetitions.shape[0] equal the rank of x.

As this PR has been discussed during Consortium meetings and no objections have been raised either here or in the original RFC (https://github.com/data-apis/array-api/issues/655), will merge. Any further changes can be addressed in follow-up PRs...


Exception: Call to Node module failed with error: To use prerendering, you must install the 'aspnet-prerendering' NPM package.

Tried a fresh install from the yeoman generator today, and even after running npm i (the node_modules folder isn't empty, everything is definitely installed) and dotnet restore, when loading up localhost:5000 it shows an internal server error right away. Windows 7 PC. (I have no issues on a separate MAC)
Also, strangely Visual Studio thinks that the dependencies weren't installed:

When running with F5 through Visual Studio it breaks here, and throws a similar error: Call to Node module failed with error: To use webpack dev middleware, you must install the 'aspnet-webpack' NPM package

A known issue in VS 2015 Update 2 (and all prior versions) is that it can't correctly restore NPM packages such as the Angular 2 ones due to path length limitations on Windows, and the fact that it uses NPM 2.x instead of NPM 3.x which solves the problem. If VS has been involved in trying to restore your NPM packages, then it's likely that your node_modules is in a bad state, and that will probably explain why aspnet-prerendering was not installed. BTW you can check whether it was installed by looking in the node_modules\aspnet-prerendering folder, which I'm guessing won't existing in your project, or if it does, may contain an incomplete set of files.
If you're using Angular 2 and VS, your options are:

Don't use VS to restore NPM packages. Always do it exclusively from the command line, and if VS has interfered, be sure to delete node_modules completely before running npm install on the command line again.
Or, reconfigure your copy of VS to use NPM 3.x (see the earlier discussion at https://github.com/aspnet/JavaScriptServices/issues/119)

The VS team is aware of the need to upgrade to NPM 3.x by default, and I believe has a fix coming not too long from now.
Also, I just checked on a Windows machine that the latest generator-aspnetcore-spa templates for Angular 2 does work OK, including when you launch it from VS, assuming the NPM modules were restored correctly. So I'll close this, but please reopen if you still think there's a bug (beside the VS limitation).

Thanks for your response Steve! So I'm running the latest Node 6x NPM 3x, and the issue still happens even when I closed down Visual Studio, rimraf node_modules then npm i then dotnet run.
The module is definitely there as well, very bizarre.

If there files are definitely in the right place on disk, I'd have to guess that Node is looking for them in the wrong place. There are various ways of configuring where Node finds modules. Or, it might even be possible to launch your app in such a way that the current working directory is something other than the project root, and then the Node instance would look for node_modules relative to the wrong dir.
I'd need to be able to repro this to investigate. So if you have a minimal project that causes the issue, and can post it online somewhere, please let me know. Or if you're able to debug and track down the fault, also please reopen the issue and post details so we can try to be more resilient against whatever condition your app is in.

I am having this exact same issue. I am using the Angular Yeoman Template. All NPM Packages have installed correctly and when I use dot net run I get -

Call to Node module failed with error: To use prerendering, you must install the 'aspnet-prerendering' NPM package.

When I open up in VS2015 and run from there I get

Call to Node module failed with error: To use webpack dev middleware, you must install the 'aspnet-webpack' NPM package

Unfortunately I cannot load this to Github for you to view from work but I will try it out at home to see if it is an environmental issue tonight. If I get the same problem I will save the repro.

OK so have tested this on my home PC and everything works as expected.  (Win 10, Latest Node and NPM)
So this issue is specific to my enviroment at work (Win 7 behind corporate firewall).  Not sure where to start in resolving this. Any tips ?
I have tried uninstalling/reinstalling Node,  setting the node enviroment path and reinstalling all the various components without any luck.

I think I am edging towards a resolution. By editing the source code for SPAServices and adding __dirName to the prerendering error message I was able to establish that Node is running in the User\AppData\Local\Temp Directory when running this app.
So I figured this was why node could not require the npm package. If I copy my Node Modules to that folder I get further, the prerender is found and instead get some errors with vendor.js and main.js.  However I suspect that this is more due to my configuration issues than a problem with the code itself. Here is the error detail -

Exception: Call to Node module failed with error: ReferenceError: vendor_99144b2b8400b60c2dc0 is not defined
at Object. (:1:1718)
at webpack_require (:1:339)
at Object.module.exports (:1:1651)
at webpack_require (:1:339)
at Object. (:1:1156)
at webpack_require (:1:339)
at config.directives (:1:559)
at Object. (:1:582)
at Module._compile (module.js:541:32)
at requireFromString (C:\Users\xxx\AppData\Local\Temp\node_modules\require-from-string\index.js:27:4)

I have been looking around for ways to fix my Node configuration but am not having much luck. I have uninstalled and reinstalled several times, removed NODE_PATH etc. without any joy.
I'm guessing there must be a setting somewhere that is causing node to behave strangely.  I will keep you posted.

I got that exact error message when I installed aspnet-prerendering and aspnet-webpack globally ... That was before I did all uninstall.  Let me know if you determine the root issue with your environment.  My solution didn't explain the root issue for me.

Ok So it is working now.  I had one more stab at reinstalling Node.
This time I -

Cleared all npm and node related temp files from User\AppData\Local\Temp,
Also removed NPM and NPM Cache from Roaming (Which I had done before)
Removed NODE PATH from Environment Variables
Uninstalled Node
Rebooted
Installed node
Installed webpack globally - That is it no other pakages
Then ran the project (not Expecting it to run) using dotnet run from the command line . And it worked!

Hope this helps someone.

nicely done Joff :)

i just removed webpack using npm uninstall -g webpack
and used aspnet-webpack insted npm install -g aspnet-webpack
and Now everything is working fine !

One of my Win7 (64bit) PCs was also having this issue, but I was using nvm (node version manager for windows), I ended up uninstalling that, uninstalling Node (clearing appdata cache for node/npm etc) Re-installing 6.3 normally, and strangely enough the issue is still there. But the project is able to run on that machine. At this point I have no idea what's causing it :)

The project successfully runs so that's good enough!
Just putting this info out there incase anyone else runs into these issues.

I have tried every single suggestion here and no matter what I do or how I try running this app, I get "Exception: Call to Node module failed with error: To use prerendering, you must install the 'aspnet-prerendering' NPM package." every single time.
I have the absolute newest, cleanest install of node and npm. I have never used Visual Studio to run npm install or even run the app. I followed all the directions down to the single letter. aspnet-webpack is clearly installed and has all of its files.

I'm on Windows 10 if that matters.

@SyntonicStudios Are you using node version manager or anything? Suspected that might of been my problem. I removed node completely and deleted all those folders, installed from scratch, semi works on one machine, fine on the other. Strange.

Strange indeed. I'm running win 10 and using nvm and have had no issues with aspnet-prerending.
@SyntonicStudios have you checked that aspnet-prerending exists in the node_modules folder? What project are you running up, one of the templates?

I have never used the node version manager and I did indeed verify that the aspnet-prerendering was populated in the node_modules folder.
I just tried this on my work machine and am getting a completely different error running from VS2015:
System.ComponentModel.Win32Exception
The system cannot find the file specified
at Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance.LaunchNodeProcess(string entryPointFilename, string projectPath, string commandLineArguments)
at Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance..ctor(string entryPointScript, string projectPath, String[] watchFileExtensions, string commandLineArguments)
At work running it from dotnet run seems to work, but the hot reloading doesn't seem to be working properly. It just gives me a flash of the updated content and then quickly reverts to the old stuff. Weird.
I'm afraid this entire setup is just too brittle to be used for me. This is a shame because getting Angular 2 with TypeScript working properly in the same project as ASP.NET Core is bizarrely difficult right now.

Have you tried globally installing webpack and also aspnet-webpack?
What version of Node, Typescript do you have?
Have you done an npm cache clean complete node_modules folder wipe, and reinstall / restore packages? @SyntonicStudios
Brittle indeed, it'll get better soon!

My project was working fine, and now I'm facing this issue. Can't remember any change I made that would've triggered this!
I'm using node v6.3.1.

@tinchou did you install nvm or anything and have multiple nodes running / anything like that?
It is strange it keeps cropping up even after RTM was released. I need to look into what the real issue is that's causing this, but looks like everyone has different reasons.
Try completely deleting node_modules and Restore Packages among other things.
A complete wipe of Node and all related AppData cache node and npm files, and removing Node from path etc, reinstalling worked on 1 PC I had it on.
@SteveSandersonMS What can we log this issue to in terms of aspnet? Seems to be around post rc2 (even with Npm3+)

It's working now.
I had chakracore, node 6 and node 4. I followed all instructions here except for uninstalling the ones I wasn't using (it wasn't on the path, so it shouldn't affect, right?).
That didn't work, so I uninstalled, cleaned again, rebooted, and it worked.

And this just happened again when I switched from Node 5.X to Node 6.5.0 in Azure through the application settings configuration.
I went into Kudu and cleaned the environment with these commands:
cd D:\home\site\repository
git clean -xdf
cd ${env:APPDATA}
rm -r npm-cache
rm -r npm

Then I deployed my app again without success. Any ideas how to better clean my App Service environment?

I'm not sure what effect this "cleaning" process would have, but if you have access to a command-line interface on your server, can you check that the webpack and aspnet-prerendering packages are really there?
cd yourapproot
dir node_modules    [see if 'webpack' and 'aspnet-prerendering' are in the output]

... and perhaps more importantly:
node -e "require('aspnet-webpack')"

This may return useful error information if there's some problem loading the aspnet-webpack module. Please let us know what you find.

And can you just confirm that it's definitely complaining about the absence of aspnet-prerendering, and not about aspnet-webpack?

I'm using Azure App Service, and it's a managed service. I get an online console through Kudu at https://{{project}}.scm.azurewebsites.net/DebugConsole/?shell=powershell, but I don't have admin access.
Anyway,

All packages are there
Requiring both aspnet-prerendering and aspnet-webpack from the console as you suggested works fine
The error that I'm getting in my logger (Application Insights) is: Call to Node module failed with error: To use prerendering, you must install the 'aspnet-prerendering' NPM package.
Here is the call stack in case you find it useful: https://gist.github.com/tinchou/48e77c5ab73c2f2e12a3a7a6df3e65ec

Thanks!

I've published updated versions of Microsoft.AspNetCore.SpaServices, aspnet-webpack, and aspnet-prerendering that return more debugging information in these cases. They will now tell you the underlying error that came back from Node, plus the current directory your app is running in, so you can verify that the packages are in thatdirectory/node_modules.
Can you update to the latest versions of all of these and see if the extra info it gives will help you identify the cause?

This is good and sucks at the same time: after upgrading these packages, it's working. So I can't give you debug information, but hopefully the next person will :).

Hey I'm new to angular2 and facing the same problem, I finally have  removed "asp-prerender-module " attribute from my  tags to make my 3rd party tool primeNg work.
I could not figure out the reason behind the error "Event not found" same happened with another 3rd party node module too.
Something wrong with pre-rendering module I guess?
has it been fixed ?
and unfortunately it takes 5 minutes to render my UI in development. is it this slow?

Remove contents of folder "C:\Users<your user>\ node_modules/ "

@sohaibjaved44 this is primarily related to primeng's use of "Event", which does not exist on the server.  I use PrimeNG with this template for an internal tool - without any server-side rendering - and it the application is definitely not slow. The initial view is displayed within a few seconds.


Added a reportEvent to seeeval

Just updated seeeval to support debugging by allowing us to identify events that do not need to be traced.

LGTM.


Symfony/PropertyAccessor constructor deprecation

We upgraded to symfony/property-access version 5.3 from 4.4 and get a deprecation message, coming from this bundle:
 User Deprecated: Since symfony/property-access 5.2: Passing a boolean as the first argument to "Symfony\Component\PropertyAccess\PropertyAccessor::__construct()" is deprecated. Pass a combination of bitwise flags instead (i.e an integer).

Here is the related upgrade entry (providing just the above information):
https://github.com/symfony/symfony/blob/5.4/UPGRADE-5.2.md#propertyaccess

Hi @simonberger, thanks for your feedback.
This issue has been fixed in #85.
Last release https://github.com/BedrockStreaming/StatsdBundle/releases/tag/v4.1.0 fix this issue.


How to do removeClass on a Input at runtime

Hi
I am trying to switch from Bootstrap4 to Metro 4
In BS I could do
$("#usernameinput").removeClass("alert");
("#usernameinput").addClass("success");
(To change the border from red to green)
However, in Metro, this has no effect?
For  I found the trick of using .data() but can't find how to do it for Inputs?

In Metro 4, if you use role for input <input type="text" data-role="input">, Metro create wrapper for input element. And all classes must be added to input wrapper.
https://codepen.io/olton/pen/xzYmRa

(: Sorted!!   Thanks sooo much!


pymavlink==2.2.2

Closed in favor of https://github.com/dronekit/dronekit-python/pull/673

@cclauss @sanderux I've changed the requirements.txt away from a strict requirement of 2.0.6 to >= 2.0.6
I'm not sure why the requirement was so strict in the first place.  Some rather evil things had to be done because of that strict requirement when upstream removed 2.0.6....
@cclauss Why are you bumping the other package versions in this PR?

just double checked, I installed today and i got 2.2.0 we should be fine

Thanks @mrpollo for your confirmation.  On the other two:

future aligns with upstream leveraging the good work that team is doing to iron out issues with running 2 and 3 together.
monotonic brings us timing support for AIX which is an important platform for my organization.

for px4 support, could we get pymavlink >= 2.2.2 ?

Any reason not to >= for the monotonic support?
double-take on the AIX support.

@sanderux I'm a bit concerned about pypi and versions getting installed.  So... why did @mrpollo get 2.2.0 instead of 2.2.2, for example?  Would not pay to break Ramon's laptop.
I think we should definitely move the requirement forward soon (PX4 being being a supported autopilot and all...), but I'd like to hear people naturally getting the requirement before we make that change.
If someone on MacOSX could pip search pymavlink, and someone on Windows pip search pymavlink and confirm that LATEST is 2.2.2, I think we could then move forward.

I think tridge might have released 2.2.0 as he mentioned to me he did. Perhaps 2.2.2 followed soon after.
Having the 2.2 requirement seems logical when people update dronekit. We could maybe ask tridge what the status is?

Looking at the commit messages, it appears that the bump of version numbers is the only difference between 2.2.0, 2.2.1, and 2.2.2.  And I quote "darn pypi server isn't taking the uploads. 3rd try".
I am fine with making the change to >= for monotonic support

I've squished all these together and pushed them in - thanks!
@cclauss You have a fair point on those versions, but it still bothers me that some people aren't seeing recent versions of pymavlink.  If we start absolutely requiring those we may break things unnecessarily (new installs should work with PX4).


firebase_ml_vision streaming crashes when using Med/High ResolutionPreset

Steps to Reproduce

Using the example from https://github.com/bparrishMines/mlkit_demo
Then setting the camera ResolutionPreset to medium or high on iOS and high on Android
When trying to byte stream images to the firebase_ml_vision for barcode reading. It cannot process fast enough and crashes with no error on iOS and and OOM on Android.

Logs

For Android it doesn't always crash with OOM, and when it doesn't it just runs slow posting this over and over.
[        ] Connected to _flutterView/0x104029e18.
[   +2 ms] 🔥  To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
[        ] An Observatory debugger and profiler on Daniel’s iPhone is available at: http://<IP_ADDRESS>:1030/PpGz07914_Q=/
[        ] For a more detailed help message, press "h". To detach, press "d"; to quit, press "q".
[+38274 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +2 ms] DevFS: Deleting filesystem on the device (file:///private/var/mobile/Containers/Data/Application/C191611A-84A2-4B4B-9353-5B31673aASDFA/tmp/AppNameLgIknR/AppName/)
[        ] Sending to VM service: _deleteDevFS({fsName: AppName})
[ +255 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +2 ms] "flutter run" took 106,751ms.
[        ] "flutter run" took 106,751ms.

Flutter analyze is clean.

Here is the flutter doctor output
[✓] Flutter (Channel beta, v1.5.4-hotfix.2, on Mac OS X 10.14.4 18E226, locale en-US)
    • Flutter version 1.5.4-hotfix.2 at /Users/computer/dev/flutter
    • Framework revision 7a4c33425d (2 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/computer/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/computer/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] Connected device (1 available)
    • Daniel’s iPhone • 00008020-00165D420128002E • ios • iOS 12.2

• No issues found!

Notes
From my own investigation. It seems to be an issue with how large each frame of the images is are, and how flutter runs its background processes.
When you scan but you disconnect the preview it still crashes all the same, so that isn't related. And if you start the byte streaming, but don't do any processing it also is fine.
Which means it is something to do with the speed in which Dart can handle processing these images. I feel like if the images didn't go through dart before going back to native, this would be a lot faster.

@dwach414 was it fixed with https://github.com/flutter/plugins/pull/1615 or you still experience it?

Hi ...
for what I can see the issue is related to a FlutterFire plugin,
please open the issue in the dedicated github.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
thank you


[9.4.x] ISPN-13669 update spring boot starter docs

https://issues.redhat.com/browse/ISPN-13669

merged! thanks @oraNod !


Issue943 strategy dates

Closes #943 => added new function that allows to provide a csv file indicating the first and last date for the study protocol. This works on top of the strategy, and therefore can be combined with any of the current strategies in GGIR.
Additionally:

Argument strategy renamed as data_masking_strategy (both options work for now).
New function check_log() to avoid duplication of code when checking ID and date formats in activity log and study dates file. This could also be applied to sleeplog, but I didn't do it because we don't have a sleeplog_dateformat argument (and maybe it's not needed), so this function would have nothing to do in that case.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[x] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #948 (1b6d3b3) into master (db25c5c) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 86.70%.

:exclamation: Current head 1b6d3b3 differs from pull request most recent head d50c45a. Consider uploading reports for the commit d50c45a to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
- Coverage   78.15%   78.12%   -0.03%
==========================================
  Files          93       94       +1
  Lines       12364    12441      +77
==========================================
+ Hits         9663     9720      +57
- Misses       2701     2721      +20

Files
Coverage Δ

R/check_params.R
95.12% <100.00%> (+0.04%)
:arrow_up:

R/createConfigFile.R
89.15% <100.00%> (ø)

R/g.analyse.perfile.R
84.23% <100.00%> (ø)

R/g.conv.actlog.R
83.33% <100.00%> (+10.60%)
:arrow_up:

R/g.part2.R
62.44% <100.00%> (+0.05%)
:arrow_up:

R/load_params.R
99.14% <100.00%> (+0.01%)
:arrow_up:

R/g.analyse.R
73.91% <83.33%> (-0.30%)
:arrow_down:

R/g.impute.R
83.20% <88.88%> (+5.54%)
:arrow_up:

R/check_log.R
71.05% <71.05%> (ø)

... and 5 files with indirect coverage changes


[Fix] RGB data corrupt

The new kinect 2 server is sending data using bgra format. The client is however not updated, causing the problem of corrupted rgb data. The pull request fix this issue.

Ah, this is because we were using a non-master version of the client when testing. Good catch.


Ability to use patterns for model_locations

Example: app/Services/*/Models

Thanks, can you describe your use-case a bit?

@mfn case: process models from all services/modules by one rule.
config/ide-helper.php
    'model_locations' => array(
        'app/Services/*/Models',
    ),
`

```bash
tree app/Services/ -d -L 1

app/Services/
|-- AAAService
|-- ApplicationServices
|-- BBBService
|-- CCCService
|-- ConfirmationService
|-- DDDService
|-- EEEService
|-- FFFService
|-- GeoReferenceService
|-- GlobalPatchService
|-- HelperService
|-- KeycloakServices
|-- OOOService
|-- PPPService
|-- QQQService
|-- RRRService
|-- ShortlinkService
`-- TradingPlatformService

18 directories

are not supported

#fail 🤦♂
Of course I meant "are now supported" 😄

Thanks!

@mfn If you tell me, then I don’t understand what it is and where it is.

@4n70w4 nevermind, already made a PR myself => https://github.com/barryvdh/laravel-ide-helper/pull/925


Support for .npmignore file?

UPDATE: still investigating, the bower.json approach now also starts throwing the update warning, any idea how to overcome this warning?
ORIGINAL DESCRIPTION:
The documentation states that NPM package.json files do not have an ignore section, which is correct. However, they do offer a .npmignore file. Is this supported by the Composer Asset Plugin?
Rationale
The reason why I am asking: when using a package.json to include assets like stylesheets which are developed in a separate project, I (apparently) have to specifically indicate which files have to be deleted in my own composer.json:
"extra": {
	"asset-ignore-files": {
		"npm-asset/project-web-themes": [
			"!dist/*",
		]
}

Only each update now results in a warning from composer, which halts the update process and requires the user to provide some input:
- Updating npm-asset/project-web-themes (v0.0.3 => v0.0.4)
    The package has modified files:
    D .gitignore
    D .npmignore
    D Gruntfile.js
    D README.md
    D XYZ.ext
-10 more files modified, choose "v" to view the full list
    Discard changes [y,n,v,d,?]?

When using a bower.json file with similar content as the NPM package.json and an additional  ignore section, this warning does NOT occur and seems therefore the preferred approach. Only this now leaves me with:

an additional bower.json in the assets project
a maintenance effort in the projects composer.json to make sure all unneeded asset files are deleted after installation

Not a big issue, but support for the .npmignore file would be nice, or am I misunderstanding the way this file should be interpreted?

No, it's not supported by this plugin.
But for your problem, you can use the flag --prefer-dist. A zip archive will be downloaded instead of using GIT (remove your vendor directory before).

Well, tried the --prefer-dist flag, but still the warning appears when upgrading a version of a bower-asset
For now the only solution seems to instruct Composer to discard the changes:
http://stackoverflow.com/questions/13613619/how-to-avoid-composer-discard-changes-message?lq=1
This only works when using the --no-interaction flag:
composer update -vvv --no-interaction
Context
Note that this specific bower-asset is hosted at a private BitBucket repository. The bower.json file contains a section to indicate everything except 'dist' folder should be ignored:
  "ignore": [
    "*",
    "**/.*",
    "!/dist/**",
    "!/CHANGELOG.*",
    "!/LICENSE.*",
    "!/README.*"
  ]

You state "a zip archive will be downloaded", but will this also work for BitBucket? It seems to have a different pattern for locating the ZIP archives than GitHub uses. Just to be clear, the dist folder should not contain a .zip archive, right?
It seems currently complete repo is being cloned.

You must remove the package folder before. Otherwise, Composer will use always the GIT format.
And yes, a zip will be downloaded, see https://github.com/composer/composer/blob/master/src/Composer/Repository/Vcs/GitBitbucketDriver.php#L77.

Sorry for misunderstanding, but what do you mean with "You must remove the package folder before."? From where? See below, I use a complete clean install...
I try to understand it because it seems to be the source of the problem: "Composer will use always the GIT format", this seems to occur.
Instead of "downloading", composer keeps cloning / checking out the GIT repository, when performing a clean installation:
rm composer.lock && rm -rf public && rm -rf vendor
> composer install --prefer-dist

Loading composer repositories with package information
Installing dependencies (including require-dev)
  - Installing bower-asset/project-name-themes (v0.1.4)
    Cloning 3d990509af133d15a505bfae438b966cdSHA-sum

While installing other Bower assets clearly indicates it downloads instead of clones:
 - Installing bower-asset/bootstrap-css (2.3.2)
    Downloading: 100%

  - Installing bower-asset/chartist (v0.9.4)
    Downloading: 100%

  - Installing bower-asset/jquery (2.1.4)
    Downloading: 100%

  - Installing bower-asset/chosen (v1.4.2)
    Downloading: 100%

  - Installing bower-asset/clipboard (v1.4.2)
    Downloading: 100%

  - Installing bower-asset/datatables (1.10.9)
    Downloading: 100%

Note that manually downloading the ZIP using the tag name works:
https://bitbucket.org/organizationName/project-name-themes/get/v0.1.4.zip
BitBucket also properly recognizes the tagged versions, which use semantic versioning

Ok, spent some more time on this and I really think this is an issue with BitBucket-support. I created two repositories with equal content on both GitHub and BitBucket (GitHub has a 0.1.1 tag because of a mistake when creating the repo, but that should not matter for this test). Results below.
Test repository on GitHub
composer update -vv --prefer-dist
Adding VCS repository git@github.com:holtkamp/composer-asset-plugin-test.git
Loading composer repositories with package information
Updating dependencies (including require-dev)
Reading bower.json of bower-asset/composer-asset-plugin-test (v0.1.1)
Importing tag v0.1.1 (<IP_ADDRESS>)
Reading bower.json of bower-asset/composer-asset-plugin-test (v0.1.0)
Importing tag v0.1.0 (<IP_ADDRESS>)
Analyzed 71 packages to resolve dependencies
Analyzed 71 rules to resolve dependencies
  - Installing bower-asset/composer-asset-plugin-test (v0.1.1)
    Downloading: 100%
    Extracting archive

    REASON: Required by root: Install command rule (install bower-asset/composer-asset-plugin-test v0.1.1|install bower-asset/composer-asset-plugin-test v0.1.0)

Writing lock file
Generating autoload files

Test repository on BitBucket
composer update -vv --prefer-dist
Adding VCS repository git@bitbucket.org:holtkamp/composer-asset-plugin-test.git
Loading composer repositories with package information
Updating dependencies (including require-dev)
Reading bower.json of bower-asset/composer-asset-plugin-test (v0.1.0)
Importing tag v0.1.0 (<IP_ADDRESS>)
Analyzed 70 packages to resolve dependencies
Analyzed 70 rules to resolve dependencies
  - Installing bower-asset/composer-asset-plugin-test (v0.1.0)
    Cloning 735ed903d8d27b4c2dee0091e6704d8cbc1b1571

    REASON: Required by root: Install command rule (install bower-asset/composer-asset-plugin-test v0.1.0)

Writing lock file
Generating autoload files

One can see that with GitHub the files are installed and with BitBucket the repository is cloned. The clone causes a GIT repository to appear in the installed assets folder. On the next update this will cause composer to generate the The package has modified files warning. I hope this clarifies my previous comments a bit...

ping ? See my last comment and examples, can somebody confirm this might be a bug with BitBucket repos?


Very low quality and intermittent images

After downloading and compiling all the code for Lepton 3.5 thermal camera, I ran raspberrypi_video, it was able to output the video, but the resolution of video was very bad, and intermittent. Any idea what cause the problem? And how to fix it.
PS: I am new to raspberry pi.

After downloading and compiling all the code for Lepton 3.5 thermal camera, I ran raspberrypi_video, it was able to output the video, but the resolution of video was very bad, and intermittent. Any idea what cause the problem? And how to fix it.
PS: I am new to raspberry pi.

Did you figure this out?

Same issue. The image appears "interlaced" (see attached).

This is on a Raspberry Pi 4, with Flit Lepton 3.5, using the standard breakout board by GetLab.
I see that in main.cpp the resolution is set to 320x240, and the Lepton is outputting 160x120 (link below). Can the issue be linked to that?
https://github.com/groupgets/LeptonModule/blob/1bc9aa08622e9b686c2ec90b95fa3dedd09d9166/software/raspberrypi_video/main.cpp#L26

This code is not compatible with the Lepton 3. That is why the image looks like this, it's actually 80x60 frames.


docs(readme): add clippy linting service

Thanks for the pull request!
I'm not sure I want to be running all of clippy against hyper. Some of the links are quite useful, but quite a few others I don't fully agree with.


Made swift exectutable

Made swift exectutable
chmod +x ./.github/main.swift

          1 Warning

:warning:
Found 3 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

3963
Error
https://github.com/jingweno/hacker-menu  Failed to open TCP connection to github.com:443 (Operation timed out - connect(2) for "github.com" port 443)

4205
503
https://www.qownnotes.org/

7764
404
https://raw.githubusercontent.com/AlexPerathoner/SlimHUD/master/IconFull.png

  Generated by :no_entry_sign: Danger

@skywinder There is no sense in this change as it is running on Travis CI and this permission change is only for your local environment.