Waymo dataset:  module 'tensorflow' has no attribute 'enable_eager_execution'

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I am replicating the waymo dataset tutorial code for understanding and learning
Using Notebook of Google COLAB (as New user to Google Colab)
TensorFlow installed from (source or
binary): - TensorFlow version (use command below):  2.1.0 (as installed by default in Google Colab)

This is the line of code: (sharing since it is available for public view as well by google in it's tutorial)
!pip3 install waymo-open-dataset
import os
import tensorflow as tf
import math
import numpy as np
import itertools
tf.enable_eager_execution()
from waymo_open_dataset.utils import range_image_utils
from waymo_open_dataset.utils import transform_utils
from waymo_open_dataset.utils import frame_utils
from waymo_open_dataset import dataset_pb2 as open_dataset
Describe the current behavior
Error I get upon executing the above lines of code
AttributeError                            Traceback (most recent call last)
 in ()
6 import itertools
7
----> 8 tf.enable_eager_execution()
9
10 from waymo_open_dataset.utils import range_image_utils
AttributeError: module 'tensorflow' has no attribute 'enable_eager_execution'

@Viki250893,
The line tf.enable_eager_execution() is used only in TensorFlow 1.x to enable eager execution.
From TensorFlow 2.x eager mode is enabled by default so you can comment of that line. Thanks!

Thank you, but upon commenting the line.
!pip3 install waymo-open-dataset
import os
import tensorflow as tf
import math
import numpy as np
import itertools
#tf.enable_eager_execution()
from waymo_open_dataset.utils import range_image_utils
from waymo_open_dataset.utils import transform_utils
from waymo_open_dataset.utils import frame_utils
from waymo_open_dataset import dataset_pb2 as open_dataset
I get the following error
AttributeError                            Traceback (most recent call last)
 in ()
8 #tf.enable_eager_execution()
9
---> 10 from waymo_open_dataset.utils import range_image_utils
11 from waymo_open_dataset.utils import transform_utils
12 from waymo_open_dataset.utils import frame_utils
/usr/local/lib/python3.6/dist-packages/waymo_open_dataset/utils/range_image_utils.py in ()
57                           value,
58                           shape,
---> 59                           pool_method=tf.unsorted_segment_max):
60   """Similar as tf.scatter_nd but allows custom pool method.
61
AttributeError: module 'tensorflow' has no attribute 'unsorted_segment_max'

@Viki250893,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here.
Also, please add ``` (i.e. three backticks) before and after your code to preserve the indentation and formatting. Thanks!

You can also provide the link to the tutorial you are following.

https://colab.research.google.com/drive/1DMt8gRU19fT5uPWBOdfRi5RsuXyRqeMO#scrollTo=Ipl_UEDWgLrB

@Viki250893,
I am unable to open the link you have provided as I do not have access to it.
Please go to File -> Save a copy as a GitHub Gist and share the link of the new gist created with us. Thanks!

https://colab.research.google.com/gist/Viki250893/40008cf236a25736d1cdefc7e0e403ea/untitled1.ipynb

@amahendrakar Can you please reply with possible solution. Thank you.

No update from the team. So closing the issue and reporting again.

@Viki250893,
Could you please check if the tutorial you are following is intended to use with TF 1.x?
I was able to reproduce the issue with TF 2.x, however I'm able to run the code without any issues with TF 1.15.2. Please find the gist here. Thanks!

Thank you for the reply.  I have  a check and update you.

WAYMO/Author whoever it is, has updated the tutorial script with
Updated script has tensorflow.compat version1.
import tensorflow.compat.v1 as tf

but, when I reported it, (Previously it was )
import tensorflow as tf

https://colab.research.google.com/gist/Viki250893/40008cf236a25736d1cdefc7e0e403ea/untitled1.ipynb#scrollTo=3etKdSB4gIeR
I'm not sure what's happening.
I would like to understand the difference of it being compatible with updated "compat.v1". This is on importing the library, not the eager enabler.
Right now, it's working fine.
Maybe you can share some clarity and may close the issue.
Thank you

@Viki250893,
For information regarding compatibility modules please check this TensorFlow guide. This guide to migrate TF 1.x code to TF 2.x would also be helpful.
Please feel free to close the issue if resolved. Thanks!

Thank you very much!!! @amahendrakar


Feature Request: Specifying multiple metrics for file

Usually people care about CEAFe, MUC, PW and B3 for general coreference problems.
Currently, if I do not specify anything,
../neleval/nel evaluate -g gold/gold.file -f tab pred.file

I get a lot of output, which I really do not care about. On the other hand, I can specify,
../neleval/nel evaluate -g gold/gold.file -f tab pred.file -m muc

which gives me only one. Maybe there should be a way to specify multiple metrics
-m muc,b_cubed,pairwise

Or have a flag for printing the common metrics?

There is. From nel evaluate --help:   -m NAME, --measure NAME Which measures to use: specify a name (or group name) from the list-measures command. This flag may be repeated.
../neleval/nel evaluate -g gold/gold.file -f tab pred.file -m muc -m b_cubed -m pairwise

Please let me know if there's some better way of documenting this than the current.


Panic with embedded broker

With the broker embedded into my app I get the following panic during testing, both when publishing directly (server.Publish) or using the paho client.
The i.ks list gets filled with *InflightMessage (inflight_map.go:34) but after reading tries to cast to uint16 (inflight_map.go:32)
panic: interface conversion: interface {} is *clients.InflightMessage, not uint16

goroutine 50 [running]:
github.com/wind-c/comqtt/server/internal/clients.(*InflightMap).Set(0xc0007ca060, 0x21c, 0xc0006b1ce0)
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/internal/clients/inflight_map.go:32 +0x2fe
github.com/wind-c/comqtt/server.(*Server).publishToSubscribers(_, {{0x2b4, 0x3, 0x1, 0x0, 0x0}, {0x0, 0x0, 0x0}, {0x0, ...}, ...})
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/server.go:654 +0x498
github.com/wind-c/comqtt/server.(*Server).processPublish(_, _, {{0x2b4, 0x3, 0x1, 0x0, 0x0}, {0x0, 0x0, 0x0}, ...})
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/process.go:149 +0x678
github.com/wind-c/comqtt/server.(*Server).processPacket(_, _, {{0x2b4, 0x3, 0x1, 0x0, 0x0}, {0x0, 0x0, 0x0}, ...})
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/process.go:28 +0x138
github.com/wind-c/comqtt/server/internal/clients.(*Client).Read(0xc0007cc000, 0xc0007f7940)
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/internal/clients/clients.go:401 +0x19d
github.com/wind-c/comqtt/server.(*Server).EstablishConnection(0xc000140370, {0xa1d4a4, 0x4}, {0xae60f8, 0xc00033e008}, {0xae2260?, 0xe8b340?})
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/server.go:362 +0x10f2
github.com/wind-c/comqtt/server/listeners.(*TCP).Serve.func1()
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/listeners/tcp.go:113 +0x3d
created by github.com/wind-c/comqtt/server/listeners.(*TCP).Serve
	/home/james/projects/web-mon/server/vendor/github.com/wind-c/comqtt/server/listeners/tcp.go:112 +0xea

The broker is started with
func startMqttBroker() *mqtt.Server {
	server := mqtt.NewServer(nil)
	tcp := listeners.NewTCP("tcp1", ":1883")
	err := server.AddListener(tcp, nil)
	if err != nil {
		log.Fatal(err)
	}
	go func() {
		err := server.Serve()
		if err != nil {
			log.Fatal(err)
		}
	}()
	return server
}

The type of PacketID is uint16.

It has been fixed in the 2.0 release.


Feat: Improve the UI

Describe the feature
I would like to improve the UI of the website
This looks like the basic ui I will enhance the UI by using the best animations library like framermotion,Locomotive JS and GSAP animations and give the best user experience.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@suraj-9849 firstly check the design work on other expect then move to animations.


Bound install time

utils: Drop unnecessary lint allow
This function doesn't use unsafe anymore.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
boundimage: Use high level deployment_fd helper
This keeps things even simpler, it's the same thing we're doing
in kargs.rs.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
boundimage: More struct definition to top
I think it's generally best to have type definitions come before
the code that references them.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
boundimage: Drop const parameter
We were always passing this single constant value to the
function; let's just reference it inside the function
and simplify callers.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
boundimage: Rename helper function
I think this name is a bit clearer.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
boundimage: Make helpers pub(crate)
Prep for using them in the install path.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
install: Pull bound images by default
Unless overridden by a CLI option, in which case they will
likely be pulled on firstboot.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>

OK, this works for me to pull bound images at install time by default.
However:

I'm not happy with the /var situation (xref https://gitlab.com/fedora/bootc/base-images/-/issues/18 too); this also argues somewhat that bound images should be owned in the "bootc storage" as an additional store (also xref https://github.com/containers/bootc/issues/128#issuecomment-2229072527 )
I think what we're very likely to need in the future is to support a model where we also look for bound images in /var/lib/containers in the installation environment, and pull from there if they exist. This would dramatically simplify both local development and support hermetic-style builds better
Needs tests (but so does bound images in general)

OK, rebased :surfer: on git main and lifting draft. I also added a hide = true to the install option as bound images are still classified as experimental.


rshim-user-space: 2.0.20 -> 2.0.31

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/rshim-user-space/versions.
meta.description for rshim-user-space is: user-space rshim driver for the BlueField SoC
meta.homepage for rshim-user-space is: https://github.com/Mellanox/rshim-user-space
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.31 with grep in /nix/store/3ylbs01l58z0bkkl6p1xd3jfc9vfzs6x-rshim-user-space-2.0.31
found 2.0.31 in filename of file in /nix/store/3ylbs01l58z0bkkl6p1xd3jfc9vfzs6x-rshim-user-space-2.0.31

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

rshim-user-space

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3ylbs01l58z0bkkl6p1xd3jfc9vfzs6x-rshim-user-space-2.0.31 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rshim-user-space https://github.com/r-ryantm/nixpkgs/archive/da31740e99adbe0e22847637d7d17354a52ff32f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/da31740e99adbe0e22847637d7d17354a52ff32f#rshim-user-space

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3ylbs01l58z0bkkl6p1xd3jfc9vfzs6x-rshim-user-space-2.0.31
ls -la /nix/store/3ylbs01l58z0bkkl6p1xd3jfc9vfzs6x-rshim-user-space-2.0.31/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

rshim-user-space

Maintainer pings
cc @nikstur for testing.

Cc @thillux for testing

@nikstur in a short smoke test, bfb-install was not working. I'll look into this tomorrow.

Closed in favor of: https://github.com/NixOS/nixpkgs/pull/318746


any plans to support vision models?

I am looking for libraries that support fine tuning vision models like Llama 2.3 Vision or Phi-3-vision. Do you have any plans to support these multimodal models in future? if not , any recommendations?

Working on it!!

@danielhanchen thank you

@reza8iucs @aeltorio @Nazzaroth2 @Any-Winter-4079
Hey guys apologies for the delays. Vision models are now supported in Unsloth! Please update Unsloth :)
Read our blogpost: https://unsloth.ai/blog/vision
Tweet: https://x.com/UnslothAI/status/1859667930075758793
GitHub post: https://github.com/unslothai/unsloth/releases/tag/November-2024
Model uploads: https://huggingface.co/collections/unsloth/vision-multimodal-models-673eb9908fc2cb3deebd2fa3


Alexa says "started playing station" but no music plays

hi.. Ive got it all set up, but when asked to play a sonos favorite, Alexa says "stated playing station Jazzanova" but no music plays.
Help please.  Thanks

In Terminal, the error is 'Invalid Music service'


Feat: Use Android Palette to show Event Detail Panel in Nav header

added bindNavHeader binding adapter method to generate a palette for the event detail palette
modified nav header layout for the changes

fixes #455

@iamareebjamal please review.

@iamareebjamal please test on a device first. I could not test it on a device.

It's great @mejariamol Please fx the build

@iamareebjamal please review.

@iamareebjamal build is fixed. please review.


[To rel/1.2][IOTDB-6127] Pipe: buffered events in processor stage can not be consumed by connector (#10962)

(cherry picked from commit 1ae952ce14c400dfdea984b299ee57abf723f274)

coverage: 47.738% (-0.001%) from 47.739% when pulling 4877a47d8ab93aa3cb8f13e40542d2be366b0edf on IOTDB-6127-1.2 into 025305a1549a3d62d982c3067250c61995748b6f on rel/1.2.


Not Working on Linux ?

works correctly on Windows but fails to run on the Linux  (on my vps).
Error : can't bypass age restriction: login required to confirm your age

your linux vps ip address is banned by google, i met with the same problem recently

your linux vps ip address is banned by google, i met with the same problem recently

for vecel too ?

https://github.com/iv-org/invidious/pull/4650
it would be nice to implement this fix

it would be nice to implement this fix

still not working :/


Curtain module - _TZ3000_vd43bbfq / TS130F

Hi Johan,
I see quikly your code and I already find this device on your list but with comment "not tested".
I get this device and it doesn't work with fail "invalid_device_by_id".
Thx for your fix, and ask me if you need more information ;)
"ids": {
"modelId": "TS130F",
"manufacturerName": "_TZ3000_vd43bbfq"
},
"endpoints": {
"endpointDescriptors": [
{
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 514,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
0,
4,
5,
258
],
"outputClusters": [
25,
10
]
}
],
"endpoints": {
"1": {
"clusters": {
"basic": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "zclVersion",
"value": 3
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "appVersion",
"value": 64
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "stackVersion",
"value": 0
},
{
"acl": [
"readable",
"reportable"
],
"id": 3,
"name": "hwVersion",
"value": 1
},
{
"acl": [
"readable",
"reportable"
],
"id": 4,
"name": "manufacturerName",
"value": "_TZ3000_vd43bbfq"
},
{
"acl": [
"readable",
"reportable"
],
"id": 5,
"name": "modelId",
"value": "TS130F"
},
{
"acl": [
"readable",
"reportable"
],
"id": 6,
"name": "dateCode",
"value": ""
},
{
"acl": [
"readable",
"reportable"
],
"id": 7,
"name": "powerSource",
"value": "mains"
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 65502
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
},
{
"acl": [
"readable",
"reportable"
],
"id": 65534,
"name": "attributeReportingStatus",
"value": "PENDING"
},
{
"acl": [
"readable",
"reportable"
],
"id": 65504
},
{
"acl": [
"readable",
"reportable"
],
"id": 65505
},
{
"acl": [
"readable",
"reportable"
],
"id": 65506
},
{
"acl": [
"readable",
"reportable"
],
"id": 65507
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"groups": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "nameSupport",
"value": {
"type": "Buffer",
"data": [
0
]
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"scenes": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0
},
{
"acl": [
"readable",
"reportable"
],
"id": 1
},
{
"acl": [
"readable",
"reportable"
],
"id": 2
},
{
"acl": [
"readable",
"reportable"
],
"id": 3
},
{
"acl": [
"readable",
"reportable"
],
"id": 4
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"windowCovering": {
"attributes": [
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 8,
"name": "currentPositionLiftPercentage",
"value": 0
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 61440
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 61441
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 61442
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 61443
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
},
"bindings": {
"ota": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"time": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
}
}
}
}

I think I found the issue for the "Invalid_device_by_id" error.
I'm able to control my device by changing the line below. (Have not tried it with actual load but I can hear the relays clicking and no error message.)
In device.js on line 4
Original: const { debug, CLUSTER } = require('zigbee-clusters');
New: const { Cluster, debug, CLUSTER } = require('zigbee-clusters');
[log] 2021-06-26 15:18:13 [ManagerDrivers] [Driver:curtain_module] [Device:1f12416e-7e17-45da-aeab-f97be7e4b00c] set windowcoverings_set → 0.35 (cluster: windowCovering, endpoint: 1) 2021-06-26T15:18:13.205Z zigbee-clusters:cluster ep: 1, cl: windowCovering (258) send frame ZCLStandardHeader {   frameControl: [ 'clusterSpecific' ],   data: windowCovering.goToLiftPercentage { percentageLiftValue: 65 },   cmdId: 5,   trxSequenceNumber: 12 } 2021-06-26T15:18:13.367Z zigbee-clusters:cluster ep: 1, cl: windowCovering (258) received frame defaultResponse windowCovering.defaultResponse { cmdId: 5, status: 'SUCCESS' }

Hi @PhAnt0mFS, thanks for finding my mistake! I have been waiting to fix this until I got an item myself and had it delivered just the other day. I will test with my device now and if it works I'll post an update asap.

No problem! The smallest issues are the hardest to find, especially when you don't have the device itself. I hope I saved you some time troubleshooting.
(Also time for Homey to provide PO-boxes to Developers so people can send in unsupported devices. (As a gift or course))

Hi @PhAnt0mFS, thanks for finding my mistake! I have been waiting to fix this until I got an item myself and had it delivered just the other day. I will test with my device now and if it works I'll post an update asap.

Hallo Johan,
Fijne app, bedankt daar voor. Ben je al in staat om het probleem met de curtain module op te lossen? Ik kijk er erg naar uit. Alvast bedankt.
Groeten
Fred

hi I have 3 curtain tuya zigbee and I receive "Invalid_device_by_id" how can I solve the problem?

hi i am a new homey user. i have 14 modules. please update so i can use my homey more.
thank you.

Added to next release of the app.


Test dynamic estimates with Socket API

Background
Socket estimates time to receive funds based on last 60 minutes combination of bridge+origin+destination
We should test out using their API vs building our own
we have an API endpoint here:
curl -X 'GET'
'https://api.socket.tech/v2/supported/bridges'
-H 'accept: application/json'

Definition Of Done
We can test this in a sandbox version of the UI for fast path transfers

The API endpoint doesn't support passing any parameter. So, the responses for the Connext object are usually 240s for every chain pair, symbol, amount, and other option. Endpoint doc: https://docs.socket.tech/socket-api/v2/supported/bridges


Problems on example codes

Hello!
Thank you for sharing your code.
I am trying to reproduce your result on Mega-NeRF building dataset.
I am using one RTX A6000 GPU.
During generating chunks, I have an error.
Traceback (most recent call last):
  File "/home/user/anaconda3/envs/nerf/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/user/anaconda3/envs/nerf/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/user/switchnerf/Switch-NeRF/switch_nerf/train.py", line 28, in <module>
    main(_get_train_opts())
  File "/home/user/anaconda3/envs/nerf/lib/python3.8/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 345, in wrapper
    return f(*args, **kwargs)
  File "/home/user/switchnerf/Switch-NeRF/switch_nerf/train.py", line 24, in main
    Runner(hparams).train()
  File "/home/user/switchnerf/Switch-NeRF/switch_nerf/runner.py", line 532, in train
    dataset = FilesystemDataset(self.train_items, self.near, self.far, self.ray_altitude_range,
  File "/home/user/switchnerf/Switch-NeRF/switch_nerf/datasets/filesystem_dataset.py", line 55, in __init__
    append_arrays = self._check_existing_paths(chunk_paths, center_pixels, scale_factor,
  File "/home/user/switchnerf/Switch-NeRF/switch_nerf/datasets/filesystem_dataset.py", line 296, in _check_existing_paths
    assert (chunk_path / 'metadata.pt').exists(), \
AssertionError: Could not find metadata file (did previous writing to this directory not complete successfully?)

where can I generate metadata.pt?
I thought that the example script generates the data chunk, but somehow it requires me to give it metadata of the data chunk.
I am trying to run Mega-NeRF too, but it is hard to find.
Please let me know if you have any solution.
Also, in the bungee-nerf training code,
CUDA_VISIBLE_DEVICES=0 python -m torch.distributed.launch --use_env --master_port=12345 --nproc_per_node=1 -m mega_nerf.train_nerf_moe --config=switch_nerf/configs/switch_nerf/bungee.yaml

So there comes "mega_nerf.train_nerf_moe FAILED" error.
I guess it should be changed to "switch_nerf.train_nerf_moe" ! and it works well.
Thank you!

Hi, sorry for the late response. Before training the models, we need to generate data chunks. The file 'metadata.pt' is created after all the chunks are successfully generated. When you rerun the code, it automatically checks whether the chunk_paths exist. If it exists, it will reuse the chunks in the path without re-generating them. So if in previous runs, the chunks were not successfully generated, the code will try to re-use the chunks but find no necessary files. So it will crash. To solve this, you can just delete the unsuccessful chunk_paths and re-generate the data chunks by the command line provided here in the readme file.

Hi! When I delete the directories for exp and chunks, the code creates them automatically and runs successfully


rootDir gets ignored when using tsconfig.json

Does gulp-typescript ignore rootDir settings when using tsconfig.json??
when compiling with this plugin the result of the module name is as following:
System.register("source/ts/main"....
but when I use tsc, I get this:
System.register("main" ...
which is what I wanted...
tsconfig.json
{
"compilerOptions": {
"target": "es5",
"module": "system",
"moduleResolution": "node",
"emitDecoratorMetadata": false,
"experimentalDecorators": false,
"removeComments": true,
"noUnusedLocals": false,
"noUnusedParameters": false,
"noImplicitAny": false,
"noImplicitUseStrict": false,
"declaration": true,
"pretty": true,
"rootDir": "source/ts",
"outFile": "built/js/example.js"
},
"exclude": [
"built",
"node_modules"
],
"typingOptions": {
"enableAutoDiscovery": true
},
"enableAutoDiscoveryDefinition": true
}

Can you share your gulpfile?

Hi @ivogabe,
I just upgraded a few projects to 3.0.2 and I'm getting this error as well. You can find a few broken builds as examples at:

https://travis-ci.org/inversify/inversify-restify-utils/jobs/164438521
https://travis-ci.org/inversify/inversify-express-utils/jobs/164437307
https://travis-ci.org/inversify/inversify-logger-middleware/jobs/164437200

Thanks!

Hi Remo, I think that this is not really related to this issue. This behaviour has changed in version 3, and it was an intentional change. The new rule is that if the rootDir option is not set, it will be set to the base path of the input files. Basically, that's the part where the glob starts in gulp.src. In the failing build of inversify-restify-utils, that would be test. The problem is then that the compiler finds source files outside of the rootDir, namely inside the src folder. You can fix this by explicitly setting the rootDir option to ./. See also http://dev.ivogabe.com/gulp-typescript-3/, seventh point.

Hi, had to clean it up a bit:
var pathFS = require('path');
/** base files (framework) */
var tsFiles = {
typings: [
'Typings/Framework.d.ts',
'Typings/globals/es6-promise/index.d.ts'
],
framework: [
'Framework/Globals.ts',
'Framework/Polyfills.ts',
'Framework/Core/Events.ts',
'Framework/Core/Tuple.ts',
'Framework/Build.ts',
'Framework/Platform.ts',
'Framework/Debug.ts',
'Framework/IO/StorageProvider.ts',
'Framework/IO/Notifier.ts',
'Framework/IO/LoadingManager.ts',
'Framework/IO/ModelLoader.ts',
'Framework/IO/ImageLoader.ts',
'Framework/AssetManager.ts',
'Framework/Shaders.ts',
'Framework/MaterialLibrary.ts',
'Framework/Render.ts',
'Framework/Localization.ts',
'Framework/Model.ts',
'Framework/Input.ts',
'Framework/World.ts',
'Framework/Component.ts',
'Framework/Components/MeshComponent.ts',
'Framework/Components/HemisphereLightComponent.ts',
'Framework/Components/PointLightComponent.ts',
'Framework/Components/DirectionalLightComponent.ts',
'Framework/App.ts',
'Framework/CameraControl.ts',
    'Framework/Shaders/Unlit.ts',
    'Framework/Shaders/Basic.ts',
    'Framework/Shaders/Standard.ts',
    'Framework/Shaders/CustomDepth.ts',

    'Framework/Anim/PathAnimation.ts',
    'Framework/Anim/ValueAnimation.ts',

    'Framework/Framework.ts'
]

};
/** base pathes */
var tsPaths = {
source: 'source/',
deploy: 'dist',
}
var paths = tsPaths
var files = tsFiles;
var bundleFile = "test";
var tscConfig = "tsconfig.json";
var customProps = {
typescript: plugins.tsc,
};
if(bundleFile) {
// custom bundle file output
customProps.outFile = bundleFile;
}
var tsProject = null;
// own tscconfig file...
tsProject = plugins.typescript.createProject(tscConfig, customProps);
var fileStream = new plugins.streamqueue({ objectMode: true });
for(var entry in files) {
fileStream = fileStream.queue(gulp.src(files[entry], {cwd: pathFS.resolve(paths.source), base: paths.source}));
}
var isDev = true;
var writeSourceMaps = true;
fileStream.done();
var tscStream = plugins.typescript(tsProject, undefined, plugins.typescript.reporter.fullReporter())
return plugins.mergeStream(fileStream
.pipe(plugins.ifElse(writeSourceMaps, () => plugins.sourcemaps.init({loadMaps: true, debug:true})))
.pipe(tscStream).js
.pipe(plugins.ifElse(writeSourceMaps, () => plugins.sourcemaps.write({ includeContent: true })))
.pipe(gulp.dest(paths.deploy))
,
//dts stream
fileStream.pipe(tscStream).dts
.pipe(gulp.dest(paths.deploy))
);
}
this is the pre 3.0 gulp file, for 3.0 I only changed the api changes, but nothing on gulp.src or the stream queue.

Hmm there seems to be a general issue with setting the rootDir as it simply doesn't work when providing multiple values via a fileGlobs array.
explanation
i have a /src and a /test folder which are provided as gulp.src(["src/**/*.ts", "test/**/*.ts"]). Now i would assume that gulp-typescript will implicitly set the rootDir to "./" putting my files in respective subfolders, but it doesn't. It just merges the output into the gulp.dest() folder.
Overriding the value by setting it "./" by hand has no effect. I even tried using my full system path without success.
What actually does work though (and that was discovered by accident), is setting a rootDir which is wrong and just addresses the first array value. In my case setting it to "/wrong" will actually do what i want it to do (probably by accidentally breaking something :P). There are errors popping up for all files in /test, but he's compiling all of them anyway (including sourcemaps/declarations) and putting them into their own respective folders.
repo
I created a tiny repo to highlight the issue.

git clone https://github.com/wmathes/gulp-ts-rootdir-issue
npm install
npm run compile

In the /build folder both original directories are merged loosing their /src and /test directories. You can break-fix this in the above described way. Toggle gulpfile.js:13&14 to see the effect.
Is this intended? Maybe i just misunderstand the concept of rootDir. ^^
Should i open up a separate issue for this?

That's how gulp works. This is related to the base path that gulp calculates, not the value of rootDir. When you write gulp.src(["src/**/*.ts", "test/**/*.ts"]), gulp will set the base path of those files to src or test. gulp.dest will write those files to the disk, based on their relative paths, relative to the base path. For instance, if you have some file src/a/b.ts, its base path is src, so its relative path is a/b.ts.
By default, the base path is the position where the glob starts. But, you can also specify if yourself, like gulp.src(["src/**/*.ts", "test/**/*.ts"], { base: "./" }). That should solve your issue.


Wrong Image Tag: latest refers to 2017instead of 2022

Since today's update the Docker Image mcr.microsoft.com/mssql/server:latest seems to refer to mcr.microsoft.com/mssql/server:2017-latest. I expected mcr.microsoft.com/mssql/server:2022-latest as it was before. This leads to breking CI pipelines and is rather important/critical.
Steps to reproduce:
docker images
...
REPOSITORY                                                TAG                      IMAGE ID       CREATED         SIZE
mcr.microsoft.com/mssql/server                            2017-latest              fa4c9a7ae374   2 weeks ago     1.33GB
mcr.microsoft.com/mssql/server                            latest                   fa4c9a7ae374   2 weeks ago     1.33GB
mcr.microsoft.com/mssql/server                            2022-latest              001b5387b97c   2 weeks ago     1.6GB

The IMAGE ID of latest and 2017-latestis the same.
OR
docker run mcr.microsoft.com/mssql/server:latest

This shows an error message of the 2017 version:
SQL Server 2017 will run as non-root by default.

When I specify the version, I get the expected 2022 error message:
docker run mcr.microsoft.com/mssql/server:2022-latest
...
SQL Server 2022 will run as non-root by default.

Thanks for your support and the continous updates. Please fix this issue soon. Thanks

Thank you @johannesheinz for reporting this issue. We are working to correct the tags on the MCR.
Not that this is your particular use case, the Red Hat based image does have the correct redirect for latest to SQL Server 2022, however the Ubuntu based image will be corrected.

Thanks for your support and the suggestion! I used the opportunity to switch to a hard-coded CU version of the mssql Ubuntu image instead which works fine.


replace libdpase in assert without msg visitor

problematic code:
void main()
{
	import std.exception;
	assert(0); // warning, assert should have a message
	enforce(0); // // warning, assert should have a message
}

enforce must be imported(from std.exception), otherwise it could be a user-defined function and no warning shall be issued.
Also in this pr I added the possibility to skip unittests. The implementation is really small so I thought I could include that part in this pr

I think we should just ditch the enforce check. It's phobos specific and any implementation of it will be brittle. Just ignore it and add a changelog entry so that we make sure we don't forget about it.


upgraded to 4.1.3, now only cra devserver shows up in port 9001

Describe the bug
I had a working installation of storybook 4.0.7 with cra.
I upgraded to 4.1.3 and now when i start storybook, it builds ok, but in browser localhost:9001 just shows the same output as if i was in localhost:3000. I don't see anything storybook related (apart from the favicon).
If i stop the webpack devserver of my app, then in localhost:9001 in browser i just see:
Error occured while trying to proxy to: localhost:9001/.
I don't know what is going on.
System:

OS: Windows10
Framework: react
Version: 4.1.3

@d3bgger What version of CRA are you running? Do you have a sample repo?

cra v2. I'll see if i can reproduce this in simple test project.
thanks

That was responsible...
`const proxy = require('http-proxy-middleware');
module.exports = function expressMiddleware(router) {
router.use(
'/',
proxy({
target: 'http://localhost:3000',
changeOrigin: true
})
);
};`
This was working in previous versions (proxy was not affecting the initial document request of storybook) but now doesn't like it. I changed it to be more specific about the paths i want to proxy to cra devserver.
I guess this can be closed?
thanks


Getting the following error

Hi  Team,
I am getting the following error when approving from okta
Okta Verify push sent...
Traceback (most recent call last):
File "gimme-aws-creds.py", line 17, in
GimmeAWSCreds().run()
File "c:\MyProgs\myvenv\lib\site-packages\gimme_aws_creds\main.py", line 432, in run
scopes=['openid']
File "c:\MyProgs\myvenv\lib\site-packages\gimme_aws_creds\okta.py", line 220, in auth_oauth
url_parse_results = urlparse(response.headers['Location'])
File "c:\MyProgs\myvenv\lib\site-packages\requests\structures.py", line 52, in getitem
return self._store[key.lower()][1]
KeyError: 'location'

What should i configure for client id and oAuth server?
(myvenv) c:\MyProgs\myvenv\Scripts>py gimme-aws-creds
No OAuth Client ID in configuration.  Try running --config again.
No OAuth Authorization server in configuration.  Try running --config again.

Those configuration parameters are only used with the gimme-creds lambda service.  If you're not using that, you should save your Okta API key in the OKTA_API_KEY environment variable and set the gimme_creds_server configuration value to 'internal' to call the Okta APIs directly.

thanks please close it . I used appurl and its working fine 👍

I used 'appurl' when it asked for gimme_creds_server

Thanks for following up


Poor detection when trained on custom dataset

I trained from scratch a new set of weights. I used a set of data that I have used to train Yolo3 which worked well. Creating a new set of weights with train.py results in very low detection rate which does not seem to make sense.

@robisen1 How did you generate annotations for your dataset?.

I used Colabler but switched to VoTT which is, in general, easier to use and faster workflow.

@robisen1 Do you able to convert yolo-custom model (which you got after training your dataset) to keras model?.

yes, the detection becomes inconsistent in my case.

@robisen1 Do you able to convert yolo-custom model (which you got after training your dataset) to Keras model?.

sorry, i did not reply. I have not sure your question but I did indeed save the whole model and later turned it into a .pb. unfortunately, the model produced did not perform as well as some other code bases so I stopped researching this codebase/

@vihari1729 why do we need to convert our custom trained model to Keras as the trained model is already in .h5 keras. In my case, the trained model gave a high detection rate. But I didn't actually follow the author suggestion to convert darknet to pytorch and then to keras. I simply converted the darknet to keras and then trained my custom dataset on it.

@prateek09101996 how to train custom datadet using keras? Do you have the repo for it? Because if using darknet we only get .weights file not .h5. Thanks in advance.

@farhantandia. I think you can use any yolov3 conversion in any yolov3 repo. It totally converts either yolov3 or yolov4 to Keras .h5 model. I used TrainYourOwnYolo repo. Basically, it did work for other repos as well.
Can anyone help me to apply this trained model for detection from the video?

@vihari1729 why do we need to convert our custom trained model to Keras as the trained model is already in .h5 keras. In my case, the trained model gave a high detection rate. But I didn't actually follow the author suggestion to convert darknet to pytorch and then to keras. I simply converted the darknet to keras and then trained my custom dataset on it.

@prateek09101996 I actually used darknet repository where i got a model named yolov4.weights as output. I need to convert it to yolo.h5 to use as it said in this repository. When I am converting I got some error. So I switched to convert it into yolo.tf from other repository TheAIguy and it worked for me. I am actually doing for tracking, Not only for detection.

@farhantandia. I think you can use any yolov3 conversion in any yolov3 repo. It totally converts either yolov3 or yolov4 to Keras .h5 model. I used TrainYourOwnYolo repo. Basically, it did work for other repos as well.
Can anyone help me to apply this trained model for detection from the video?

I also used TrainYourOwnYolo repo and it worked good for detection. But for tracking it is not working. I think they left some architecture weights from yolov3 and did training. The raining also completed in 3 hours in my laptop. But while using darknet, for 3 classes it took almost a day for me using colaboratory

yes, the detection becomes inconsistent in my case.

yes, Using trainyourownyolo repository the detection is inconsistent. But using darknet repository for training and converting to yolov4.tf model from this [repository](https://github.com/theAIGuysCode/yolov3_deepsort), it worked quiet well and also tracking ran smoothly. In case if you want only detection, you can keep "tracking=false" as they said from the repository

@vihari1729 thanks, so we can use .tf instead of .h5 as refers to AIguy repo to do such tracking right? deepsort id?

@farhantandia yes both are similar. But I preferred converting to .tf model because it has github repository with instructions to convert.

@vihari1729 - I originally converted darknet weights to Keras and then trained using the instruction in this repo. While training in one class, it did take me 2 days to train on GPU but the map was quite high and detection for images is good too.
Thanks for your brief review, I would too like to convert it to .tf and check for tracking if it helps.

@vihari1729 - did you use TrainYourOwnYolo for training as well? I suggest using that repo just for converting yolov4.weights to yolov4.h5 and then proceed to train for this repo. The training takes lot of time even on multiple GPUs.

@vihari1729 - In that repo only can be used for yolov3, I got an error reshaped while converting the yolov4-tiny.weights, so which part that did you modified?

@vihari1729 -btw theAIGuy repo just updated a new repo for yolov4-deep sort yesterday, so it can run now. thanks.

@vihari1729 - did you use TrainYourOwnYolo for training as well? I suggest using that repo just for converting yolov4.weights to yolov4.h5 and then proceed to train for this repo. The training takes lot of time even on multiple GPUs.

@prateek09101996 yes i have used. But it is only working for detection. so I shifted to THeAIGuy repository

@vihari1729 - In that repo only can be used for yolov3, I got an error reshaped while converting the yolov4-tiny.weights, so which part that did you modified?

@farhantandia I modified it on my own by doing some changes.luckily you are telling that they opened for yolov4-deepsort. So use that repository.


🚧Create issue template for performing releases

I have done the items below . . .

[X] I have updated the title by replacing the '<title>' section.

Description
Create an issue template for performing releases.
Each release will have this release issue created.  It will be used to perform todo items for the release such as running unit tests to making sure release announcements are performed.
Acceptance Criteria
This issue is finished when:

[x] Create release todo issue template
[x] Issue template file name will be release-todo-issue-template.yml

ToDo Items

[X] Draft pull request created and linked to this issue
[X] Priority label added to issue (low priority, medium priority, or high priority)
[X] Issue linked to the proper project
[X] Issue linked to proper milestone

Issue Dependencies
No response
Related Work
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

PR Approved and ready for release v1.0.0-preview.9


Add TMPCGC to COLLECTION_LIST

subproject_name: TMPCGC
metaproject: TMPCGC
names:
- TOPMed PCGC
- Common/ Complex Disease TOPMed PCGC
- PCGC
- PCGC (Seidman CHD 90X)
notes:

dictionary mapping:
"TMPCGC": "PCGC"

Will be fixed in #35.


Customize editor and questions - putting angular content inside custom question

Are you requesting a feature, reporting a bug or ask a question?
Hi,
I followed this link editor-customization branch example and create a custom question control.
I ran in to a requirement of showing angular content inside the htmlTemplate section shown below,
Just wanted to know whether this is supported, or I have to simple deal with HTML and JS
Thanks !
Ranga
What is the current behavior?
What is the expected behavior?
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
import * as Survey from "survey-angular";
import * as SurveyAngular from "survey-angular";

export let peopleWidget: any = {
  name: "people",
  isFit: function (question: Survey.QuestionBase): boolean {
    return question["renderAs"] === "people";
  },
  htmlTemplate:
  `<div class=".people-container" style="width: 500px; height: 200px;">
    This is people picker
    <input type="button" (click)="alert('test');" />
    <button mat-button>Click me!</button>
  </div>`,
  afterRender: (question: Survey.QuestionBase, el: HTMLElement): void => {
    console.log(question);
    console.log(el); // here el is the 'htmlTemplate' supplied above
  }
};

SurveyAngular.JsonObject.metaData.addProperty("text", { name: "renderAs", default: "standard", choices: ["standard", "non-standard"] });
SurveyAngular.CustomWidgetCollection.Instance.addCustomWidget(peopleWidget);

Specify your

browser:
browser version:
surveyjs platform (angular or react or jquery or knockout or vue):
surveyjs version:

SurveyJS custom widgets have framework-independent code. Content of the htmlTemplate property is rendered into DOM as is. After that you can process it any available way in the afterRender function.
That's why Angular bindings will not work for the markup inside the htmlTemplate property.
You can see custom widgets examples in the https://github.com/surveyjs/widgets repository. Sample usage of the custom widgets is demonstrated in this repo - https://github.com/surveyjs/surveyjs_angular_cli


Feature proposal: Shutdown / restart gameros via steam buddy

Maybe I'm the only one with this use case (from time to time):
I play as well remotely with my gameros machine. Once I'm finished I want to shutdown gameros which is located in the roof floor  of my house.
I can do it via ssh or steam link as well, but I think it would be also fine to have it in steam buddywhich is more convenient.

It was suggested we also support suspend.

This should be easy to implement as we are using a logind session.

@alkazar this one is implemented and merged. Should be closed?


added 5517/udp to logstash listen ports to support internal logging

affects the compose files used by RPM/DEB packaging.  Testing will be performed in the lab.

Current coverage is 68.58%

Merging #420 into master will not affect coverage as of de784e1

@@            master    #420   diff @@
======================================
  Files           63      63
  Stmts         2779    2779
  Branches         0       0
  Methods          0       0
======================================
  Hit           1906    1906
  Partial          0       0
  Missed         873     873

Review entire Coverage Diff as of de784e1

Uncovered Suggestions

+0.61% via goldstone/views.py#30...46
+0.58% via ...stone/drfes/views.py#134...149
+0.40% via ...tone/drfes/models.py#165...175
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Page-loader doc

When navigating to Page loader extension, the loader is shown quickly.
need a display none or something like this ?

In fact, it's because the loader is being hidden :)
The loader have some CSS transition and that's the cause of this "visual bug".
I'm not sure how to fix it.

In fact, it's because the loader is being hidden :)
The loader have some CSS transition and that's the cause of this "visual bug".
I'm not sure how to fix it.
One solution could be to move the if condition to the loader level

One solution could be to move the if condition to the loader container level.
But it's feels wrong/odd to do that :)
https://github.com/MangelMaxime/Fulma/blob/master/docs/src/FulmaExtensions/PageLoader/View.fs#L18-L20

You may be able to fix it by not displaying the element at all until it's initialized. For that you have to add a IsInitialized property or similar to the model (the code below means you have to use yield for other children as well, but you could do it differently):
if model.IsInitialized then
    yield PageLoader.pageLoader
        [ yield PageLoader.Types.Color model.Color
          if model.IsLoading
              yield PageLoader.isActive ]

@alfonsogarciacaro I was thinking like you, and I tried your solution but this doesn't work because, I never reset the models in the docs site. Their are initialized at the launch of the app and after, their are only updated. (I don't call init again).
I tried to set the condition on the container level but, this make the loader appear/disappear in one block instead of the animation. (when it go from top to bottom and vice versa).
Finally, if I force React to redraw the "part of DOM" with the page loader we don't have the visual bug. If we don't force react to redraw, then it only patch the DOM which trigger the animation.

@evilz This should be ok now.

Nice hack :)


state of the art performance?

Nice work! I have a question regarding the result:
In the paper "Exploring the limits of language modeling", it reports test ppl of 54.1 using LSTM-512-512. Does it mean two 2 layers are used in the paper, while your result is obtained from 4 layers ? If so, what makes the difference?

Sorry for the slow reply! I've been busy fine-tuning the hyperparameters, fixing small bugs, and reproducing the results. The latest model reports test ppl of 46.47 using LSTM 2048-256 - a single-layer lstm with 256 projection layer. You can run the model on a single gpu - (1080 Ti or higher) to reproduce the results.


New interaction icons

Closes #154

Flower
Nest

@kklamberty Oh, I see what you're saying :)
I don't think I'm worried with the ambiguity there—after all, if people look at the button and think "flower!", they're still more or less getting the right message! :stuck_out_tongue:


Add placeholders for Gatsby's API extension points

I think this should make it easier for people to get started with Gatsby. But if this isn't the appropriate way to document how to use these files then feel free to close this PR.

This is a great idea!


fileElem.bind is not a function

This isues arise even before using in agular, If add file shows this error.
angular.js:12520 TypeError: fileElem.bind is not a function
at linkFileSelect (http://emi.local/javascripts/angular/ng-file-upload.js?v=0.2:851:14)
at link (http://emi.local/javascripts/angular/ng-file-upload.js?v=0.2:920:7)
at ea (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:73:293)
at D (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:62:190)
at g (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:55:105)
at D (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:62:134)
at http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:69:223
at http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:119:129
at r.$eval (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:133:313)
at r.$digest (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.8/angular.min.js?v=0.1:130:412)
var app     = angular.module("app", ['ngFileUpload']);

app.controller("DocUploadController", ['$scope','uploadListService', function ($scope,uploadListService) {
       $scope.filelist = doclist;
       $scope.logcode = logcode;
       $scope.unuploaded_section = false;
       $scope.applicatnts_type = ['Main Applicant','Co Applicant -1 ','Co Applicant -2',];
       $scope.current_applicant= $scope.applicatnts_type[0];

       $scope.applicantchaged = function() {
            //$scope.filelist = null;
            //Promise code : not updating
            uploadListService.getFileList($scope.current_applicant)
            .then(
                function (result) {
                    $scope.filelist = result;
                    //$scope.$apply();
                },
                function (error) {
                    alert(error.statusText);
                    console.log(error.statusText);
                }
            );
        }

    }]);

app.directive("fileUploader", function() {
        return {
            replace: true,
            restrict: 'E', // Element directive
            controller: ['$scope','Upload', function ($scope,Upload) {
                $scope.upload = function (file) {
                     console.log('Start: ' + $scope.logcode );
                    Upload.upload({
                        url: 'https://angular-file-upload-cors-srv.appspot.com/upload',
                        data: {file: file, file_name:$scope.fileinfo.name, logcode:logcode}
                    }).then(function (resp) {
                        console.log('Success ' + resp.config.data.file.name + 'uploaded. Response: ' + resp.data);
                        $scope.fileinfo.status      = 'Uploaded';
                        $scope.fileinfo.file_url    = 'http://www.bennadel.com/images/header/photos/ryan_stewart.jpg';
                    }, function (resp) {
                        console.log('Error status: ' + resp.status);
                    }, function (evt) {
                        var progressPercentage = parseInt(100.0 * evt.loaded / evt.total);
                        //console.log('progress: ' + progressPercentage + '% ' + evt.config.data.file.name);
                    });
                };
                $scope.div_visibility = function(parent_status,my_status,name){
                    if(!parent_status&&my_status!='Uploaded'){
                        console.log('++++++++++ : ' + my_status +name );
                        return 'Set This div visible';
                    }
                };
            }],
            scope: { fileinfo: '=fileInfo',unuploaded_section:'=' },
            templateUrl: '/javascripts/angular/html/fileUploader.html'
        };
    });

Can you create a jsfiddle? Demo and samples are working fine.

Thank you and appreciate for your consideration.
https://jsfiddle.net/abelkbil/k5a34exr/4/

The link doesn't work for me. I get injection error. You probably have not injected the module properly.

var app = angular.module("app", ['ngFileUpload']);
Above is module declaration, Actually I use it in directive template having a controller.
app.directive("fileUploader", function() {
		return {
	        replace: true,
	        restrict: 'E', // Element directive
		    controller: ['$scope','Upload', function ($scope,Upload) {
		    	$scope.upload = function (file) {
			    	 console.log('Start: ' + $scope.logcode );
			        Upload.upload({
			            url: 'upload.php',
			            data: {file: file, file_name:$scope.fileinfo.name, logcode:logcode}
			        }).then(function (resp) {
			            console.log('Success ' + resp.config.data.file.name + 'uploaded. Response: ' + resp.data);
			            $scope.fileinfo.status 		= 'Uploaded';
			            $scope.fileinfo.file_url 	= 'http://www.bennadel.com/images/header/photos/ryan_stewart.jpg';
			        }, function (resp) {
			            console.log('Error status: ' + resp.status);
			        }, function (evt) {
			            var progressPercentage = parseInt(100.0 * evt.loaded / evt.total);
			            //console.log('progress: ' + progressPercentage + '% ' + evt.config.data.file.name);
			        });
			    };
		    	$scope.div_visibility = function(parent_status,my_status,name){
			    	if(!parent_status&&my_status!='Uploaded'){
			    		console.log('++++++++++ : ' + my_status +name );
			    		return 'Set This div visible';
			    	}
			    };
		    }],
	        scope: { fileinfo: '=fileInfo',unuploaded_section:'=' },
	        templateUrl: 'http://eemi.in/javascripts/angular/html/fileUploader.html'
	    };
	});

Is there any issue/mismatch in this.
I will update a working jsfiddle soon.
Thank you.

Well once you get rid of the injection error that shows up in the jsfiddle I will have a look. The injection issue is a general angular issue not related to this plugin. You can follow the jsfiddle sample in the docs to get you started.

This working jsfiddle . http://jsfiddle.net/abelkbil/9qw6fpsq/12/
Thanks for your support @danialfarid .
The issue was related to jquery v3 included. Changed jquery to 2.4 solved the issue.
Thank you again.
Abel J

Alright, so I assume the issue is resolved right?

I am still getting this error, does this mean that I cannot use jQuery v3?


Update docs

What does this PR do?
Fixes #8.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @Borda! Thanks for updating this PR.

In the file pytorch_lightning_bolts/__init__.py:

Line 25:1: W293 blank line contains whitespace
Line 27:1: W293 blank line contains whitespace


Add copier question to fail tests on log WARNING

Currently, tests pass even if there are WARNING in the Odoo log.
Previously we had a notice of that, via runbot, although it never prevented merging.
Since runbot will be shutdown, we are going to lack this notice, unless people look at the test logs.
Since many repos have WARNING, this check must be enabled per-repo (and maybe made mandatory on newer branches: 15, 16...).
Blocked on https://github.com/OCA/oca-ci/issues/10

It would be nice to have it before we open the 18.0 branches.


Bloxstrap cannot connect to the internet upon launch.

System.Net.Http.HttpRequestException:` An error occurred while sending the request.

===== Inner Exception =====
System.IO.IOException: The read operation failed, see inner exception.

This happened overnight. I dont know what troubleshooting steps to take to provide more information. I can connect to the roblox website just fine.

Here is some basic system info, along with all the bloxstrap logs
System Info https://pixeldrain.com/u/KNXxk9bh
Logs https://pixeldrain.com/u/KNXxk9bh

Bloxstrap throws that error if it's unable to connect to https://detectportal.firefox.com. If you want to check, go to that URL in your browser, it should prompt for a file download.
The error message doesn't seem to be showing properly (oops), so try out this version (just run Bloxstrap.exe) and show me the error message from that.
https://github.com/pizzaboxer/bloxstrap/suites/14755064807/artifacts/838830777

installing the latest version fixed it. odd that it didnt auto update. thank you very much for your help!

out of curiosity, i tried installing v2.5.0 release, and it gave the same error when i tried the installer. whatever secret sauce you used in the version you gave me should probably be merged to main.

out of curiosity, i tried installing v2.5.0 release, and it gave the same error when i tried the installer. whatever secret sauce you used in the version you gave me should probably be merged to main.

Yeah, give it about a week.

:3


Remove use of blacklist/whitelist terminology in code

Description

Replace the use of the term "BlackList" with the term "BlockList"
Replace the use of the term "WhiteList" with the term "AllowedList"

Motivation and Context

Removes the use of terms with negative racial connotations and replaces them with neutral terms.
How Has This Been Tested?

Changes are limited to comments and property names.
No impact was verified by rebuilding the code and ensuring no unit tests have been broken.
Screenshots (if appropriate):

n/a

+1

May I suggest instead "GreenList" and "RedList"

May I suggest instead "GreenList" and "RedList"

I've never seen these terms used anywhere else. Is there a precedent for their use elsewhere?
Using colors like this also relies on some assumptions about what the colors mean. You're relying on someone knowing that (presumably) green means good, allowed, or ok, and red means bad or blocked. Other cultural associations can risk color based terms being confusing for some.

Red in Asian cultures is more positive and means good luck.

I think an issue with "GreenList" and "RedList" is that those are not common terms and could create ambiguity, e.g. those could also be used to refer a list of shades of green/red.

+1 to "block" and "allow".

Looking at https://english.stackexchange.com/questions/51088/alternative-term-to-blacklist-and-whitelist it seems "Safelist" is a good suggestion to go along with "Blocklist".

I think in this particular case it might be worth considering a more explicit name for those properties like "invalidPropertyNames" or "forbittenPropertyNames" or something along these lines instead of "PropertyNamesBlockList", especially since they are not even an actual list.
I would rather eliminate the bad convention of using the terms "Black/White list" instead of replace them with a new one.

Looking at https://english.stackexchange.com/questions/51088/alternative-term-to-blacklist-and-whitelist it seems "Safelist" is a good suggestion to go along with "Blocklist".

"Safelist" could be a bit of a loaded term, depending on the context.  Block and Allow seems more generic, and applicable in multiple situations and contexts.

I would rather eliminate the bad convention of using the terms "Black/White list" instead of replace them with a new one.

Yes i think that's a good idea.
Having those lists be named "AllowedPropertyNamesList" and "ForbiddenPropertyNamesList" or "BlockedPropertyNamesList" are better than plainly replacing it with a different name for those two words.

@mdtauk

"Safelist" could be a bit of a loaded term, depending on the context.

Out of interest, please elaborate (perhaps native (UK) English speakers have a specific view on this term compared to non-native speakers.)

/azp run

@mdtauk

"Safelist" could be a bit of a loaded term, depending on the context.

Out of interest, please elaborate (perhaps native (UK) English speakers have a specific view on this term compared to non-native speakers.)

Well if we have an allowed list of APIs, it implies that if it is not on the "Safelist" then it is unsafe to use, rather than just not allowed.

@mrlacey for consistency, shouldn't it be BlockedList?

@mrlacey for consistency, shouldn't it be BlockedList?

or AllowList + BlockList

Naming really is inconsistent, as already pointed out, and now violates API design principles . The terminology itself is wonky and should be something like AllowedPropertyNames/ BlockedPropertyNames if we keep standard rules. Note that 'List' shouldn't be included on these types of properties. The term ordering also should be such that it sounds correct in English (Naming for sort ordering isn't the convention)
Best:
AllowedPropertyNames
BlockedPropertyNames
In any case at least align the tenses:
Alternate 1:
PropertyNameAllowedList
PropertyNameBlockedList
Alternate 2:
PropertyNameAllowList
PropertyNameBlockList
I wouldn't have merged this without some additional fixes.

Apologize if I merged a bit early. The names should not affect any public APIs. Please feel free to create a new PR with updates.


[BUG] Sentinels quest return to the fold not completing because feathermoon quest objective not completing

This is a duplicate of #3154, but I'll close that one because this is clearer.
To replicate:

As Sentinels, complete the quest "Shores of Feathermoon"
Observe the "Object reference not set to an instance of an object" error that pops up

The issue is exactly what it says. This is the code for the quest's OnComplete:
    /// <inheritdoc />
    protected override void OnComplete(Faction completingFaction)
    {
      completingFaction.Player?
        .RescueGroup(_rescueUnits);
    }

_rescueUnits is never populated, so this doesn't work. In fact there are no units in Feathermoon Stronghold, so the method should just be removed and the tooltip for the quest updated accordingly.

Closed by #3177


X11 icon and other minor changes

I've gotten the X11 icon added to Font Mfizz for the purpose of using it with this package. I added extensions for all the .x config files on my personal machine, as well as a couple of extensions for ZSH and Vim files on my local machine that the style didn't include.

*winces* This isn't gonna be fun to explain...
TL;DR:
Reasons.
Reasons:
I'll start with the easily-digestible:

The package already has a dedicated icon font for custom icon additions.The process of adding a new icon is documented in the contribution notes very cleanly. This font exists so we're not left with several ad-hoc icon-fonts floating around. Which used to be the case.

Now for the main course:
2. We're not upgrading Mfizz.This is why:
Look at the codepoints of the icons across the top, and imagine what upgrading the font will do for every user who's using one of its icons in their stylesheet.
That's right, for reasons that fall outside the scope of my comprehension, the Mfizz team decided to completely reindex the font at some point in time, introducing a breaking change that we can't simply integrate without knocking over a few vases. Or several.
Another gripe with Mfizz is the inconsistent size and alignment of each icon:

Devicons is slightly less schizophrenic, but its icons are still uneven and padded with margins:

These discrepancies are the reason for nearly every alignment-related issue that's been reported, and the solution has always been to clobber certain icons with ad-hoc CSS tweaks. Result: 80% satisfaction at the expense of one really messy stylesheet.
3. "Enough whining, what's the reason you're not upgrading?Because both Mfizz and Devicons are due to be replaced with patched versions in File-Icons v2.0.0.
In acts of questionable sanity, I took it upon myself to manually scale each icon of both fonts and fit them all snugly to ensure consistent sizing. However, most of my time went toward cleaning up excessive geometry to produce sharper details and better filesizes. This actually reduced Devicon's WOFF2 by an insane 17 KBs... and when you consider WOFF2's state-of-the-art compression, 17 KBs is an absurd improvement to be made from simply culling unneeded control points in Adobe Illustrator.

"So what's stopping you from adding these fonts now?"When v2 ships, it'll force users to update customisations in their stylesheets. Since there's a good chance they might've tweaked Devicons and Mfizz's icons themselves, they'll probably need to update such adjustments in their stylesheets as well. We can kill two birds with one stone by only requiring users to update customisations once... simply by delaying the addition of these patched fonts until the next major release.

The new problem:
The package's custom icons font has passed 300 icons, and I'm trying to be conservative with what's added. That is to say, if an icon already exists in a bundled font, it won't be added to the custom icons-font (exceptions were made here to maintain compatibility).
Since Mfixx and DevOpicons will both be updated whenever the originals are updated, I'll naturally have to add the X11 icon to Mfixx and hope to God you'll understand why it'll have to wait until v2 to be added.

So, to bottom-line it for you: you'll have to revert the changes to Mfizz and remove the x11 icon addition, leaving only the "other minor changes". I'll add your x11 icon to MFixx, since it's now part of the font it's derived from.

Okay, all of the X11 stuff is reverted for this PR.

*winces* This isn't gonna be fun to explain...

That's an odd reaction.

The process of adding a new icon is documented in the contribution notes very cleanly.

I agree. The first sentence of the contrib notes:

If a desired icon isn't included in one of the existing icon-font packages

I felt like the X11 logo would be a good fit for an icon font that gets used in multiple places. Since it has been accepted to be part of Mfizz, it's included in one of the existing icon-font packages. The contribution notes didn't give me any reason to think that that might be a problem.

That's right, for reasons that fall outside the scope of my comprehension, the Mfizz team decided to completely reindex the font at some point in time, introducing a breaking change that we can't simply integrate without knocking over a few vases.

From what I've seen, the font gets reindexed whenever a new icon gets added. Mine just happened to be last in the alphabet. Mfizz builds with a CSS file so that people only have to use the human-readable names in their own code.

and hope to God you'll understand why it'll have to wait until v2 to be added.

So dramatic. I would have accepted a flat "no", too. I made what I needed for myself.

So dramatic. I would have accepted a flat "no", too. I made what I needed for myself.

My exasperation isn't directed at you, so don't misconstrue the tone of my reply as blaming you for an inconvenience. The catalyst of my frustration is mainly helplessness. V2 can't be released until several important PRs are merged upstream, and they've been waiting review for over a month. When you've been itching to shoot two very problematic icons in the head for well over a year, time drags to a crawl.

From what I've seen, the font gets reindexed whenever a new icon gets added. Mine just happened to be last in the alphabet. Mfizz builds with a CSS file so that people only have to use the human-readable names in their own code.

Personally, I feel that's a really myopic approach. What if users prefer to use the font directly, or already have icon classes defined in existing CSS? In any case, Font Awesome gets it right. Icons stay locked into the same codepoint to which they were first assigned, and they don't rely on the assumption users will be using the font in the same way.

That's an odd reaction.

Is it? I'm probably unable to think straight due to not having slept the night before, so I might simply be on-edge or something.

I felt like the X11 logo would be a good fit for an icon font that gets used in multiple places.

That may be true, yes. But the trouble is, most of what gets added to the package's font is probably a similarly good fit:

@DamnedScholar Could you please enlighten me as to what language these .x files are written in, and their frequency? I don't think I've happened across them before.
Also, again, I genuinely apologise for my tone, but having to explain this brought up every frustrating hard-to-explain subject I wasn't looking forward to elaborating on.

I understand. It felt like you expected me to be uncooperative with whatever your decision was, and thus had to preemptively explain everything. That was probably the lack of sleep talking. :)
X11 is the most common windowing system on Unix-like operating systems. Linux users tend to have a bunch of .x<whatever> files in their home folders, which hold the personal configuration files for X and related utilities. The frequency is basically only Linux users (and maybe a few OS X users), but virtually every Linux user.

Do these files use a generic INI-like configuration for their syntax, or something domain-specific?
Reason I'm asking is because v2 will introduce the ability to set icons based on manually-assigned grammars, so I'm wondering if I need to take that into consideration as well.
Incidentally, you can find more information on that topic along with the reason for my sleep-deprivation here. My entire night was spent furiously bikeshedding with myself over how best to structure a config file that risks being verbose, inflexible, or unintuitive to new contributors.
Speaking of which, if you've a moment, perhaps give the property descriptions a read and let me know if they make sense.

The config files in question use generic syntax, different ones use different formats, and they don't have anything cohesive to tie them together (like shebangs or mode lines). So no, don't even consider it. :)
After reading the property descriptions in that file, I feel entirely confident that I could add my own without issue. It reads very well.

Alright, good. Just thought I'd check: the bulk of my research was drawn from GitHub's language database, but it's by no means a comprehensive encyclopaedia of every language devised by man.

I feel entirely confident that I could add my own without issue. It reads very well.

SWEET RELIEF. I must've rewritten that six times. Thanks for the feedback! :D


⚠ Blutopia has degraded performance

In e503aa1, Blutopia ($BLU) experienced degraded performance:

HTTP code: 200
Response time: 13484 ms

Resolved: Blutopia performance has improved in b079572 after 9 minutes.


Update camera_process_subnode.cc

rosbag play -l   onetimes skip frame   .

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Merge pull request #1 from IdentityServer/dev

Update

Hi @wondertrap, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;


Cap incoming connections

The gateway should stop accepting new peers at a reasonable number (Bitcoin uses 128).

Fixed by #475


ENV for Git not complete

projects should clone repo down on :init

also:
needs to have TYPE specific build extras:
e.g.
ln -s ./app/web/ ./app/www
composer install
grab settings.local.php and other config files from build function


Style: spaces in simple one line statements.

Also converted style guide to markdown.

did you forget to add the changed doc?  I only see deletions here

Fixed.


Note that only user@domain is supported for vSphere master and worker

Story for context: https://www.pivotaltracker.com/story/show/158904932
[#158904932]

Thanks @chinangela!


request_from_group - one field or two

I'm using the validate plugin via the Web Experience Toolkit (http://github.com/wet-boew/wet-boew).  All the regular validation works but I have a situation where there are multiple fields on a page like below:
<input type=text id=last_name>
<input type=text id=first_name>

<input type=text id=address>

In this case, I need either the address or the last_name field to be completed.  But, if the last_name field is completed, the first_name field should also be done.
How could I go about coding that while taking advantage of the validate plugin?

Sorry for the lack of a response. I still don't have a good answer. You're probably going to have more luck on the forum or StackOverflow, if this is still an issue.

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


bug(main-cron): pulsar source check: gRPC request to meta service failed: Unknown error

Describe the bug
https://buildkite.com/risingwavelabs/main-cron/builds/2574#018fe921-e00e-4500-a96b-e376672a9538
Error message/log
Traceback (most recent call last):
  File "/risingwave/e2e_test/source/pulsar/astra-streaming.py", line 44, in <module>
    do_test(config)
  File "/risingwave/e2e_test/source/pulsar/astra-streaming.py", line 20, in do_test
    cur.execute(f'''CREATE TABLE t (v1 int, v2 varchar)
psycopg2.errors.InternalError_: Failed to run the query
Caused by these errors (recent errors listed first):
  1: gRPC request to meta service failed: Unknown error
  2: transport error
  3: connection error
  4: connection reset

Meta service's logs were not collected in the CI pipeline.
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

https://github.com/risingwavelabs/risingwave/pull/17152 may help. Will trigger another test for verification

@tabVersion Does https://github.com/risingwavelabs/risingwave/pull/17152 resolve this?

https://github.com/risingwavelabs/risingwave/pull/17185 I opened another one for this. Seems a misalign in credentials. Will fix asap


Why is approve returning bool?

The approve function can only return true, why does it return anything?
   function approve(address _spender, uint256 _value)
        public
        returns (bool)
    {
        allowed[msg.sender][_spender] = _value;
        Approval(msg.sender, _spender, _value);
        return true;
    }

I would propose to change it to:
   function approve(address _spender, uint256 _value)
        public
    {
        allowed[msg.sender][_spender] = _value;
        Approval(msg.sender, _spender, _value);
    }

approve() in ERC20 requires returning a bool.
In this implementation, it's just always true.

Yes, ERC20 is just an interface.
There could be an ERC20 token that for example, forbids approval for certain addresses, such as the 0 address.

Ok, thanks for explaining. Closing this :)


Support mixed case basedn.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536663
This PR addresses an issue where the miqldap_to_sssd conversion tool did not
properly generate the basedn domain name from a mixed case basedn
Steps for Testing/QA [Optional]

Configure MIQLDAP for LDAP, specifying the basedn in mixed case, e.g.: "CN=Users,DC=Example,DC=COM"
Test that user can log in and shows up in users table.
Take snapshot of VM per docs.
In ssh shell run miqldap_to_sssd with no parameters.

@djberg96 Thank you for the feedback. Personally I feel it's more readable the way it is. Let's see what others say.

Gaprindashvili backport details:
$ git log -1
commit 6e876750b83ed2def41c6f203d3762db89eaabbf
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Fri Feb 2 13:59:18 2018 -0500

    Merge pull request #16925 from jvlcek/bz1536663_miqldap_to_sssd_ad

    Support mixed case basedn.
    (cherry picked from commit 83a24ce8d3e06f868c7eee39c7295d44bc87d526)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552776


[AIRFLOW-1036] Randomize exponential backoff

This prevents the thundering herd problem. Using a combination of
dag_run, task_id, and execution_date makes this random with respect to
task instances, while still being deterministic across machines. The
retry delay is within a range that doubles in size.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1036

Description

[x] Here are some details about my PR, including screenshots of any UI changes: See message above

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: I modify existing tests.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

to: @bolkedebruin @aoen

SHA1 intentionally, doesn't need to be super secure, don't want it to be slow on machines that don't have hardware support for SHA2

This changes existing functionality (potentially breaking some use cases), it should be a new option (randomized_delay), and the config options should be parameterized (e.g. min delay, max delay...)

Codecov Report

Merging #2262 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
- Coverage   68.88%   68.85%   -0.03%
==========================================
  Files         142      142
  Lines       10966    10969       +3
==========================================
- Hits         7554     7553       -1
- Misses       3412     3416       +4

Impacted Files
Coverage Δ

airflow/models.py
86.98% <100%> (+0.01%)
:arrow_up:

airflow/jobs.py
74% <0%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e79b83...9854671. Read the comment docs.

There's already max_retry_delay. I don't think this is really used considering the implementation was broken before. I can't really see what use case this would break.

Ok I agree, but I still think randomized delay should be user configurable (base delay, delay multiplier, exponent)

Base delay is taken from the retry_delay field which is configurable. Not sure what multiplier is, but I don't think configuring the exponent is really something ever wanted, and just blows up the code with more unnecessary configuration options.

I'm not sure that it's unnecessary, these configuration values are very use-case specific,


[BUG] Reading parquet dataset on GPU throws "cudf engine doesn't support the following keyword arguments: ['strings_to_categorical']" error

Describe the bug
Reading parquet dataset on GPU throws an "cudf engine doesn't support the following keyword arguments: ['strings_to_categorical']" error. Reading the data on CPU runs successfully:
distributed.worker - WARNING - Compute Failed
Key:       _sample_row_group-1d48e09b-5b56-4e62-92ec-860ff2f9dd40
Function:  execute_task
args:      ((<function apply at 0x7f6b6e47f010>, <function _sample_row_group at 0x7f692006f130>, ['path/to/parquet_files/000000000000.parquet', <gcsfs.core.GCSFileSystem object at 0x7f6ae65ec6d0>], (<class 'dict'>, [['cpu', False], ['memory_usage', True]])))
kwargs:    {}
Exception: 'ValueError("cudf engine doesn\'t support the following keyword arguments: [\'strings_to_categorical\']")'

Steps/Code to reproduce bug
dataset = 'path/to/parquet_files/*.parquet'
dataset_nvt = nvt.Dataset(dataset, engine='parquet', cpu=False)
# Fails with ValueError: cudf engine doesn't support the following keyword arguments: ['strings_to_categorical']

dataset_nvt = nvt.Dataset(dataset, engine='parquet', cpu=True)
# Runs successfully

Expected behavior
The dataset should be read from file under both cpu=True/False
Environment details (please complete the following information):

Environment location: GCP vertex ai notebook (GPU: NVIDIA V100 x 1)
Method of NVTabular install: conda

nvtabular == 23.8.00
cudf == 23.10.02 (above error was also present under 23.12.01)
dask == 2023.9.2
@niraj06

The following workaround works in loading the data:
dataset = 'path/to/parquet_files/*.parquet'
dataset_nvt = nvt.Dataset(
    dask_cudf.read_parquet(dataset), engine='parquet', cpu=False
)
# <merlin.io.dataset.Dataset at 0x7f99bc042230>

However, applying workflow transform fails:
workflow = nvt.Workflow.load(f"path/to/workflow")
workflow.transform(dataset_nvt)
# Exception: "TypeError('String Arrays is not yet implemented in cudf')"

full error:
Key:       ('transform-bdc9b5878b9eff9e4e8eb287f652e68a', 63)
Function:  subgraph_callable-6a50eb3e-1830-40d8-bff7-0a6db4e7
args:      ([<Node SelectionOp>], 'read-parquet-070e46c56ae3f13e04d07d8cae7b3f14', {'piece': ('path/to/parquet_files/000000000000.parquet', None, None)})
kwargs:    {}
Exception: "TypeError('String Arrays is not yet implemented in cudf')"

The workflow includes nvt.ops.Categorify and nvt.ops.Groupby operations to create a string array of sequential events per grouped entity.

Sorry for this ridiculously late response @orlev2 - Just coming across this now.
As far as I can tell, the rapids/dask pinning in Merlin has been far too loose. NVTabular 23.8 was definitely not tested with cudf>=23.08 or dask>=2023.8.
The merlin 23.08 containers use cudf-23.04 (which uses dask-2023.1.1), so using that is your best bet.
NOTE: The lack of upper pinning in NVTabular is indeed a "bug" of sorts - I apologize about that.


Mssql server connection

Please make domain name in sql server connection optional not required

I think it is optional (at least with latest version)
Here I tested it with the same mssql server we use for testing -
to start it, cd server && docker-compose up -d mssql
And then I configures sqlpad as shown below,
The password is SuperP4ssw0rd!

you can see the domain is empty but the connection seems OK.


Add myst and sphinx config

IMPORTANT
Merge https://github.com/plone/volto/pull/3035 before merging this PR!

I am now able to do make docs-html or make docs-livehtml to build the docs using Sphinx and MyST. w00t!
This is the first step toward rapid development of the docs.
The intent here is to allow parallel development of Volto documentation. Whenever a change is made on the main branch in docs, it should be backported to plone6-docs (not merged) with a separate PR for peer review.
We also need to ask @ericof to set up automatic CI/CD for plone6-docs under plone.org. Please suggest a good hostname.

This PR is now ready for review. Any takers?

After this PR is merged, we could set up previews in Netlify or automatic deployment. I found the Netlify preview to be f00kin amazeballs for trying out the new search feature with breadcrumbs in the results.
https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/search.html?q=MyST&doc_section=contributing

@stevepiercy Should we remove files that are common in Volto and Plone docs? For instance, cheatsheet.md is already serving its purpose on Plone docs.

@nileshgulia1 I do not know. That should be discussed amongst the Volto team because y'all might want to keep it for the stand-alone build or move parts of it. Please revert the commit and create a new issue, so that I can merge this issue.
This PR's only purpose is to add Sphinx and MyST build ability, and from another PR fixes that caused warnings and errors.

ok, I reverted my commit, sorry for the confusion. This is something that we can discuss in subsequent PRs. The rest LGTM.

@nileshgulia1 thank you! I created a new issue as a placeholder for that discussion.


[stable/airflow] Add log persistence for workers

What this PR does / why we need it:
Currently there is not an option to mount logs persistence for worker pods, so unless you are using s3, gcs, etc, you cannot store logs via a  PVC store and use something like EFS to write logs. This results in loss of logs between deployments of worker pods and being unable to see logs in webui.
Signed-off-by: Brian Nutt<EMAIL_ADDRESS>Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @maver1ck

@bnutt
Could you show me sample usage ? Do you plan to create volume separately ?

@bnutt
Could you show me sample usage ? Do you plan to create volume separately ?

I plan to use EFS for this, so my logsPersistence would look something like this:

Storage configuration for logs
logsPersistence:

enable persistance storage
enabled: true

Existing claim to use
existingClaim: nil

Persistent Volume Storage Class
If defined, storageClassName:
If set to "-", storageClassName: "", which disables dynamic provisioning
If undefined (the default) or set to null, no storageClassName spec is
set, choosing the default provisioner.  (gp2 on AWS, standard on
GKE, AWS & OpenStack)

A configuration for shared log storage requires a storageClass that
supports the ReadWriteMany accessMode, such as NFS or AWS EFS.
storageClass: efs
accessMode: ReadWriteMany

Persistant storage size request
size: 4Gi
Optionally, I could use an existing claim, but here I am using efs-provisioner to create the pvc for me, this should allow for the logs to be on all worker pods even if they have been replaced.

And why you can't do this with existing:

extraConfigmapMounts
extraVolumes

And why you can't do this with existing:

extraConfigmapMounts
extraVolumes

I could do this with extraVolumes as well, but it was an attempt to make it consistent since other airflow services have ability to use logs persistence. More than happy to just use extraVolumes/extraVolumeMounts to do the same

i think we can go to extraVolumes/extraVolumeMounts

SGTM, I will close this for now then.

Maybe we can add a tips in the README on how to use extraVolumes to keep logs


Created box plot and scatter plot

Done #395 #498

Coverage decreased (-33.3%) to 55.312% when pulling 1d4cdf98b0ebe35c3834599bca3fe16517741af1 on develop into 9c25a4152f4856b4b0d6c7316f328959c7a30d9d on master.

Done #379

Done #492

Can you check why this PR lowered that much the coveralls score?


screen_name:  Case Sensitive Resulting in Duplicate Records

I was trying to deal with with the issue of :since_id maximum(:tweet_id) when there isn't a record available so I'm not sure if this is a bug, my code, or just something I wasn't aware of behind the scenes. Regardless, I've found that case sensitivity can matter and duplicate records are a result.  If anything perhaps this will save some headaches for others who might run into a similar issue.
#prepare
  def Chirp.prepare
    self.fetch_peeps
    self.twitter
    self.fetch_tweets(@peeps, @twitter_client)
  end

#fetch_tweets
  def Chirp.fetch_tweets(peeps, twitter_client)
    peeps.each do |user_name|
      if self.find_by(name: user_name.name).nil?
        twitter_client.user_timeline(user_name.name).take(1).collect do |tweet|
          self.save_tweet tweet
        end
      else
        twitter_client.user_timeline(user_name.name, since_id: maximum(:tweet_id)).each do |tweet|
          unless exists?(tweet_id: tweet.id)
            self.save_tweet tweet
          end
        end
      end
    end
  end

This code results in this:
irb(main):092:0> Chirp.all
  Chirp Load (0.4ms)  SELECT "chirps".* FROM "chirps"
=> #<ActiveRecord::Relation []>
irb(main):093:0> Peep.all
  Peep Load (0.3ms)  SELECT "peeps".* FROM "peeps"
=> #<ActiveRecord::Relation []>
irb(main):094:0> Peep.create(name: 'GoRails')
   (0.1ms)  BEGIN
  Peep Exists (0.2ms)  SELECT  1 AS one FROM "peeps" WHERE "peeps"."name" = 'GoRails' LIMIT 1
  SQL (0.2ms)  INSERT INTO "peeps" ("name", "created_at", "updated_at") VALUES ($1, $2, $3) RETURNING "id"  [["name", "GoRails"], ["created_at", "2016-04-13 18:41:50.743057"], ["updated_at", "2016-04-13 18:41:50.743057"]]
   (1.0ms)  COMMIT
=> #<Peep id: 6, name: "GoRails", created_at: "2016-04-13 18:41:50", updated_at: "2016-04-13 18:41:50">
irb(main):095:0> Chirp.prepare
  Peep Load (0.3ms)  SELECT "peeps".* FROM "peeps"
  Chirp Load (0.1ms)  SELECT  "chirps".* FROM "chirps" WHERE "chirps"."name" = $1 LIMIT 1  [["name", "GoRails"]]
   (0.1ms)  BEGIN
  SQL (0.2ms)  INSERT INTO "chirps" ("tweet_id", "name", "text", "created_on", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"  [["tweet_id",<PHONE_NUMBER>51307008], ["name", "GoRails"], ["text", "RT @glpunk: @aoozdemir Use vagrant (https://t.co/5WbrH7RaeZ). Here is a excellent guide to setup the VM with ubuntu https://t.co/9xgUvbSize"], ["created_on", "2016-04-12 20:09:29.000000"], ["created_at", "2016-04-13 18:41:59.406899"], ["updated_at", "2016-04-13 18:41:59.406899"]]
   (0.9ms)  COMMIT
=> [#<Peep id: 6, name: "GoRails", created_at: "2016-04-13 18:41:50", updated_at: "2016-04-13 18:41:50">]
irb(main):096:0> Chirp.count
   (0.4ms)  SELECT COUNT(*) FROM "chirps"
=> 1
irb(main):097:0> Chirp.prepare
  Peep Load (0.4ms)  SELECT "peeps".* FROM "peeps"
  Chirp Load (0.2ms)  SELECT  "chirps".*  FROM "peeps"  ORDER BY "peeps"."id" ASC LIMIT 1
=> #<Peep id: 6, name: "GoRails", created_at: "2016-04-13 18:41:50", updated_at: "2016-04-13 18:41:50">
irb(main):100:0> p.name = 'gorails'
=> "gorails"
irb(main):101:0> p.save
   (0.2ms)  BEGIN
  Peep Exists (0.4ms)  SELECT  1 AS one FROM "peeps" WHERE ("peeps"."name" = 'gorails' AND "peeps"."id" != 6) LIMIT 1
  SQL (0.2ms)  UPDATE "peeps" SET "name" = $1, "updated_at" = $2 WHERE "peeps"."id" = $3  [["name", "gorails"], ["updated_at", "2016-04-13 18:42:26.896143"], ["id", 6]]
   (1.0ms)  COMMIT
=> true
irb(main):102:0> Chirp.prepare
  Peep Load (0.3ms)  SELECT "peeps".* FROM "peeps"
  Chirp Load (0.1ms)  SELECT  "chirps".* FROM "chirps" WHERE "chirps"."name" = $1 LIMIT 1  [["name", "gorails"]]
   (0.1ms)  BEGIN
  SQL (0.2ms)  INSERT INTO "chirps" ("tweet_id", "name", "text", "created_on", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"  [["tweet_id",<PHONE_NUMBER>51307008], ["name", "GoRails"], ["text", "RT @glpunk: @aoozdemir Use vagrant (https://t.co/5WbrH7RaeZ). Here is a excellent guide to setup the VM with ubuntu https://t.co/9xgUvbSize"], ["created_on", "2016-04-12 20:09:29.000000"], ["created_at", "2016-04-13 18:42:45.116040"], ["updated_at", "2016-04-13 18:42:45.116040"]]
   (1.0ms)  COMMIT
=> [#<Peep id: 6, name: "gorails", created_at: "2016-04-13 18:41:50", updated_at: "2016-04-13 18:42:26">]
irb(main):103:0> Chirp.count
   (0.3ms)  SELECT COUNT(*) FROM "chirps"
=> 2
irb(main):104:0> Chirp.prepare
  Peep Load (0.4ms)  SELECT "peeps".* FROM "peeps"
  Chirp Load (0.1ms)  SELECT  "chirps".* FROM "chirps" WHERE "chirps"."name" = $1 LIMIT 1  [["name", "gorails"]]
   (0.1ms)  BEGIN
  SQL (0.1ms)  INSERT INTO "chirps" ("tweet_id", "name", "text", "created_on", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"  [["tweet_id",<PHONE_NUMBER>51307008], ["name", "GoRails"], ["text", "RT @glpunk: @aoozdemir Use vagrant (https://t.co/5WbrH7RaeZ). Here is a excellent guide to setup the VM with ubuntu https://t.co/9xgUvbSize"], ["created_on", "2016-04-12 20:09:29.000000"], ["created_at", "2016-04-13 18:42:57.258343"], ["updated_at", "2016-04-13 18:42:57.258343"]]
   (1.0ms)  COMMIT
=> [#<Peep id: 6, name: "gorails", created_at: "2016-04-13 18:41:50", updated_at: "2016-04-13 18:42:26">]
irb(main):105:0> Chirp.count
   (0.3ms)  SELECT COUNT(*) FROM "chirps"
=> 3
irb(main):106:0> Chirp.all
  Chirp Load (0.3ms)  SELECT "chirps".*   I guess the simplest solution is simply to downcase in this situation to avoid this problem.


Drop Python 3.3 and 3.4 support

Description

Drop Python 3.3 and 3.4 support. Also allows more recent tornado version (>=6,<7).
Motivation and Context

Python 3.3 and 3.4 have reached end of life quite a while ago. This PR also addresses #2949.
Have you tested this? If so, how?

I installed Luigi under Python 2.7 and 3.6 and that worked as expected.

FYI @stonebig @maresb

@honnix
I would suggest dropping support in tox.ini and in luigi/setup_logging.py as well
btw, isn't ImportError handling with collections and collections.abc related to the issue?

@drowoseque Good catch. I thought we have no 33/34 in tox because readme says 36/36 tested. :D
This PR intended to just officially drop the support declaration, but not clean up code base (which we can do in a follow-up PR). But yes this is good point. Thanks.

OK. I see we don't run those as part of Travis CI. I now remember the change. :)


Function on struct can't find global function with same name

We had this error a while ago:
A.slang
    float f(int a, int b);

B.slang
    import A;
    struct S {
        int a, b;
        float f(bool b = true) { return f(a,b); }
    };

I get an error 39999: too many arguments to call (got 2, expected 1). It seems it can't find the g
global function f.
Is it a bug or expected to work?

I think this counts as a bug insofar as there needs to be a way to make it work, whether or not that exact syntax should work in this case.
My intention for name lookup in cases like that has been that as soon as one function is found during lookup, then all functions of the same name that are visible become candidates for overloading, but that doesn’t seem to be what the compiler implements today.

Fixed we think.


Teamwork desk v2

:star2: What does this PR do?
Add a button for the new Teamwork Desk design
:memo: Links to relevant issues or information
If the update is successful it should handle the following issues:
https://github.com/toggl/toggl-button/issues/1479
https://github.com/toggl/toggl-button/issues/1451

Added a bit of margin.
Can you accept the pull request from here?

Thank you @mikkelaastrup! We'll include this in our next release. Should happen early next week.