Adding info on disabling audio output during behave tests

Hey Hugh this is an excellent addition. We'll also look into making this the default behaviour when running tests.
Another quick option for applying this config change is to use the config manager eg:
mycroft-config set tts.module "dummy"
mycroft-config set tts.module "mimic2"

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any contributions to our repositories. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.
You will also be added to our list of excellent human beings!
Please visit https://mycroft.ai/cla to initiate this one-time signing.
Thank you!

I've added a reference to the mycroft-config option and started the CLA process.

I've signed off the CLA

Thanks Hugh, I made another little edit, but this tip is going to save a lot of people a lot of time in testing :)


Strange with extract-text-webpack-plugin^4.0.0-beta.0

Bug report

What is the current behavior?
I use  "webpack": "^4.8.3"  and  "extract-text-webpack-plugin": "^4.0.0-beta.0", there are something strange. My code repository: https://github.com/h476564406/webpack4.8.3/tree/isBug.
In  my config webpack.prod.js,
The entry: index.js

The output:

Use  optimization  like follow picture.

However,  if  run  'npm run build', I found

Why produce manifest.css and  vendors.css? I did not use css in these file.
Why index use  chunkFilename rather than filename?   I think the index is entry chunk which use filename.
If I config allChunks:false, it report error.
 new ExtractTextPlugin({           filename: '[name].css',           allChunks: false,       }),
The code logic is if I click the button, will import('./A.js')  and in 'A.js',  import styles from './a.css'.
The error:

If the current behavior is a bug, please provide the steps to reproduce.
There is my code repository: https://github.com/h476564406/webpack4.8.3/tree/isBug
The step to reproduce error:

pull branch
npm install
npm run build
node server.js
Go to http://localhost:3001/ , click button and console will show error.

What is the expected behavior?
In my view, it will use 'style-loader' to process the style in 'a.css'. If I click button, I think it will add style in the html.

Other relevant information:
webpack version:   "^4.8.3",
Node.js version:  "v8.9.1",
Operating System:  "MacOS",
Additional tools:

Don't use extract-text-webpack-plugin for extract css use instead https://github.com/webpack-contrib/mini-css-extract-plugin


No connection between Pc Client and GO

Hello and thanks for your solution.
It's not functional on my GO. My specs : PC Win 10 on ethernet + Go on Wifi 5Ghz. the pc client does not find my GO and still remains in "finding the client" while the app Go is launched and displays me "press connect button on alvr server". I launched the client PC (it shows me "server is alive"). so that does not work ...
For info : Vridge is ok on my GO. It's not a network problem
I've test Wifi <-> Wifi. same result ...

awesome work!
I'm having the same problem.
my spec : PC Win 10 on ethernet + Oculus Go on Wifi 5Ghz.
I hope that client side also works on Ethanet.

Hi, kameka22 and Tomozow.
Thanks for the report!
Can you paste the result of following adb command?
adb shell ping -c 5 (IP Address of PC)
And please check the firewall settings.
ALVR server uses udp 9944 port (incoming).
If you can get work, a device is appeared like following screenshot.

thank you for reply!
My results here.
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=128 time=1001 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=128 time=921 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=128 time=7.42 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=128 time=7.55 ms
64 bytes from <IP_ADDRESS>: icmp_seq=5 ttl=128 time=292 ms
--- <IP_ADDRESS> ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4007ms
rtt min/avg/max/mdev = 7.420/446.323/1001.988/434.445 ms
I set up a firewall, but It did not work well.

This is ok for me. It's a problem with the firewall of Windows. After disable the firewall. The pc client find my Go. The quality is just OUAaaaah ... terrible !!!!! Thanks @polygraphene ! You are a boss !

not the opposite, the performances are really great. Much better than Vridge (but it is not officially supported). It's really very good job!

Oh! It was a great news!
I misunderstood 😉
Thank you for report!
Enjoy the good VR life! 👍

I'm sorry @polygraphene !
I seem to have not installed the driver.
Now it's working perfectly !
Thank you for your support and very good work.

Congrats!
Installation of driver is a little bit confusing.
I will introduce auto driver installation on future release.
Thanks!


GS-Form multiple updates

When making two changes in a GS-Form in quick succession, then an error occurs on the second change. Make it so that the GS-Form queues updates.

If two updates are made in quick succession, the second one fails. This is not just with the GS-Form, instead it should be all four requests: SELECT INSERT UPDATE DELETE. Create a Queue for these types of requests and update all of the widgets.


Add stderr printing of values that could not be found when interpolating

[#168515882]
Signed-off-by: Jeremy Alvis<EMAIL_ADDRESS>Usage:
Give a config.yml with the contents:
name: ((name))
password: ((password))

And credhub has the value for name as bob.
When you run the CLI invocation below you'll get the following output.
credhub interpolate -f config.yml --skip-missing > interpolated.yml
Could not find values for:

config.yml:2 ((password))

This allows a user to double check the interpolation since it may be missing values rather than finding out downstream when they try to use the interpolated file.

@iplay88keys thank you for this PR! See a0589223ffa93c548d80547ffca93c82029fbe1b for when this commit was applied.


Please include Windows 2022 as supported Windows OS

Accelerated Networking is also supported in Windows 2022

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbfe1f3b-01da-a475-8dee-15f628bd7e17
Version Independent ID: 4315f677-aa2b-b82c-8491-634dfb3fc11e
Content: Accelerated Networking overview
Content Source: articles/virtual-network/accelerated-networking-overview.md
Service: virtual-network
GitHub Login: @steveesp
Microsoft Alias: steveesp

@aralvar , thank you for your feedback. We'll review this and get back to you shortly!

@aralvar , I checked with the Product Group team and they confirmed that they are still working on this and Accelerated Networking will be officially supported in Windows 2022 soon but we don't have an ETA yet. We'll update this doc once we officially start supporting Accelerated Networking on Windows 2022.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Add ability to show only diff images in the html-report

Show all images (by default):

Show only diffs:

Coverage remained the same at 81.653% when pulling 8b9d1dfa788affee957ca535ee85d254edd6c2bb on sipayrt.showOnlyDiff into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.

/ok

/ok


Week 4 improvements

Task 1.1:
Clarify that we are attempting to forge different ciphertext which decrypts successfully with original key/nonce.
Task 1.3:
How about AES specific instructions in hardware level, how they change execution time? I believe here is issue, that there are differences among different machines if hardware supports this - PyCryptodome automatically uses hardware instructions if available and this brings variety among the results.
Add note that very little data size makes results highly affected by system noise.
Task 2:
For reporting, both original message/different messages and their hashes should be reported for easier grading.

Should be updated already.


change logo to show OpenD when doing --version

I think to make it more clear version should print OpenD

what is the most preferred? OpenD or openD


[Feature] Text widget: Need more font styles and font sizes for Text widget.

Summary
If possible can we take the font size via a numerical input ?
Can we change font size apart from the given options?
Also can we change font styles?

@areyabhishek @jsartisan we were just talking about this. I am now thinking with the new sizes decided should we also give a custom option or from the design POV  dosent make sense


How to create table relashionships?

I couldn't find in the documentation how to create relationships between tables... one-to-many nor many-to-many...

Thank you for interest. The documentation is still in progress, soon I will add more example.
I put an example below on how you can do one to one, one to many. It wasn't tested, it's just to give you a hint on how it can be done, but it should work (wink wink)
For more information, please check out the SQLAlchemy documentation:
https://docs.sqlalchemy.org/en/13/orm/basic_relationships.html
# __models__.py

from assembly import db, models

class Category(db.Model):
    """ Contains all the category for books """
    label = db.Column(db.String(255))
    #... mode columns

class BookAuthor(db.Model):
    """ Book authors  """
    name = db.Column(db.String(255))
    #... mode columns

class Book(db.Model):
    """ Contains book description """
    author_id = db.Column(db.Integer, db.ForeignKey(BookAuthor.id, ondelete='CASCADE'))
    title = db.Column(db.String(255))
    author = db.relationship(BookAuthor, backref="books")
    #... mode columns

class BookCategory(db.Model):
    """ Contains books category map """
    book_id = db.Column(db.Integer, db.ForeignKey(Book.id, ondelete='CASCADE'))
    category_id = db.Column(db.Integer, db.ForeignKey(Category.id, ondelete='CASCADE'))
    book = db.relationship(Book, backref="categories")
    category = db.relationship(Category)
    #... mode columns

# from 1 book id: 123
# one to one
book = models.Book.get(123)
print(book.title)
print(book.author.name)
for cat in book.categories:
  print(cat.category.label)

# from author, list all books
# one to many
author = models.BookAuthor.get(123)
for book in authors.books:
  print(book.title)


Platform docs on Program still reference Html.app

In description of Program type reference is made to Html.app. Should be plain Html since 0.18

I can't find the line you are talking about. If you can give a link, open a new issue with that in the original comment.


Each transaction is market as an error on New Relic

I do not know what is the initial idea when this code is written, but with this else condition here each transaction will be marked as an error.
https://github.com/Seldaek/monolog/blob/6bb347c040bb29f42c2c249714aac8c0e36c2454/src/Monolog/Handler/NewRelicHandler.php#L94

To be honest I do not have experience with New Relic too. My suggestion is only what I found during implementation it in my project, but probably it is the absolutely wrong way. As you say, maybe a different way of thinking and implementation is the solution.

Looking at the comment https://github.com/Seldaek/monolog/pull/1217#issuecomment-436212898 I think there is a misunderstood of the usage of new NewRelicHandler (or more generally a misunderstood of NewRelic)
NewRelic is not made for tracking logs (like logmatic or Sentry, ...), it only contains API to trac errors and response time.
The purpose of this handler is to send application's dis-function logs to NewRelic. In order to NOT send debug, notice or informational logs, you shouldn't configure a log level too low (IMHO error is enougth)
        newrelic:
            type: newrelic
            level: error

@jderusse I'd tend to agree there. Do you have any opinion on https://github.com/Seldaek/monolog/pull/1217#issuecomment-436189051 ? Is that the correct interpretation? Relating to https://github.com/Seldaek/monolog/blob/master/src/Monolog/ResettableInterface.php#L15

@Seldaek I answered in the PR (see https://github.com/Seldaek/monolog/pull/1217#issuecomment-446104846).
TL;DR: this is not the responsibility of Monolog to start or end a NewRelic transaction

NewRelic is not made for tracking logs

This is no longer true, NewRelic does now track logs. The NewRelic PHP Agent captures application errors—I would expect this logging package's "NewRelicHandler" to solely ship logs to NR.

Ok so what I'm hearing is we maybe should just deprecate this handler? Or is there still value in the error collection?

It seems that New Relic's PHP Agent presently does not log meta data which has been appended to log entries—only the log message is sent (whereas the Java Agent does do this). Perhaps once that feature is available deprecation of this handler would be logical.


cannot find symbol variable common_google_play_services_install_text

Hi,
I have my own library, which I want to embed inside a third party library.
When using fat-aar, they get the following error:
error: cannot find symbol variable common_google_play_services_install_text
Gradle version used:  2.14.1
It think that it has to do with the fact that both libraries use Google Play Services, but different components of it.
In my library I have the following dependency:
compile 'com.google.android.gms:play-services-location:+'
And in the destination library, they have the following dependency:
compile 'com.google.android.gms:play-services-ads:9.0.2'
Their build file looks like this:
apply from: 'https://raw.githubusercontent.com/adwiv/android-fat-aar/master/fat-aar.gradle'
and
embedded project(':tingzlibrary-1.5a')
tingzlibrary is the name of my library.

The project which uses your embedded library should have
compile com.google.android.gms:play-services-base:10.0.1

There is anything new regarding this issue? I'm having the same problem with the resources:
Error:(52, 63) error: cannot find symbol variable colorScheme.
The variables declaration on the embedded library R can't be recognized for the project do be built.


Shadows for tabs and the navigation bar are only visible on the default theme

If you apply a custom theme, the shadows around the tabs and the navigation bar disappear
Default theme

Custom theme

It is not possible to use shadows on AMO themes for technical reasons.

Okay, I got it! Thanks for the answer!


Missing oracle timestamp datatypes

I'm noticing that when generating objects for an oracle table that includes timestamp columns, i'm not seeing the timestamp fields getting generated.  Looking closer, i can see that fields' datatypes are e.g. TIMESTAMP(3) instead of TIMESTAMP, which is what the supportedTypeMappings in OracleDataTypes.fs would expect
Looking at the link included below, and grabbing samples out of the a default EBS oracle database (version 19c), it looks like:
TIMESTAMP
TIMESTAMP WITH LOCAL TIME ZONE
TIMESTAMP WITH TIME ZONE
INTERVAL DAY TO SECOND
will be identified as having types
TIMESTAMP(x)  .. where x can be a value between 0 and 9
TIMESTAMP(x) WITH LOCAL TIME ZONE  .. where x can be a value between 0 and 9
TIMESTAMP(x) WITH TIME ZONE  .. where x can be a value between 0 and 9
INTERVAL DAY(x) TO SECOND(y) .. where x and y can each be a value between 0 and 9 (not necessarily the same)
You can read more about it here:  https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements001.htm#i54330
CLOB and NCLOB are also some string fields that are omitted in the supported types map.  i suppose there may be some others, but these are some i'm running across while working on a poc at the moment.

So the issue is that you have a TIMESTAMP(3) column that Is not added to the generated properties?

yea, that's one particular example I ran into.  depending on the table definition, it could have been TIMESTAMP(0), or TIMESTAMP(1), and so on up through TIMESTAMP(9).  also, I had edited the last comment to also call out CLOB and NCLOB types as well.

Types have been added in SqlHydra.Cli v2.1.1.

thanks for the quick turnaround! i'll give it a spin after release

It is released here:
https://www.nuget.org/packages/SqlHydra.Cli/2.1.1


HTTP/SOCKS5 proxy support

Description of the new feature/enhancement
For now, I am trying to use winget inside China mainland, as the well-known reason, I found I cannot make a simple winget install graphviz work... It might be OK after this tool formally released with local repositories installed in China. But I think there will be many windows users who need to use winget behind an enterprise firewall or something like that. So my private guess is: winget need to have a feature to support HTTP(s)/SOCKS5 proxies.

Proposed technical implementation details (optional)
It can be designed to use an extra command line parameter, or to follow the UNIX tools routines of environment variables (like http_proxy, https_proxy, ALL_PROXY, etc.)

Oh... another proposal is:
Can we have configuration file to configure mirrors or customized repositories?
I am not sure how much Microsoft want to handle the tool and the repository. If the policy is OK for customized repositories, I think a configuration file (like .gitconfig, etc.) might be a good thing. If not, I strongly recommend to deploy more repository servers in China...

Hey @yystju, thanks for taking the time to report this. Both features have been requested already and could've been found by searching the issues first before creating your own.
For proxy support subscribe to:

#190

For mirror support subscribe to:

#316

Duplicate of #190


[release/1.7 backport] ci: remove libseccomp-dev installation for nightly

since libseccomp is required only for building runc and we are only building containerd binaries in nightly, the libseccomp-dev dependency is removed. Foreign arch repositories are now removed since crossbuild-essential-* packages are {arm64, ppc64el,..} cross compiler packages for amd64 and arch specific repositories are not required.
clean cherry-pick of #8768
(cherry picked from commit a9cb6090e2a2abe2b8625c60e4dee499e9291fb3)

/cc @thaJeztah

/ok-to-test


Aggregate grade bug (not sure what max calculates here)

Bernice has a midterm score of 84%, Alex has final score of 90%, 84% is outputted.
Suggestion: max and min should take into account only the overall score (with weightage taken into account too)

Expected behaviour


FoundryVTT v12 support

It's probably worth beginning the changes needed to support Foundry v12. Maybe we'll even be able to do a quick turnaround if this begins soon enough!

Oh man, I thought this would be fast, since we had addressed all visible deprecations for v12. It will not be. Many of them were "addressed" by using the to-be-removed functionality explicitly, rather than addressing the underlying changes. As a result, this will need to fix async die rolls (which is mostly done, I think) as well as the migration of text enrichers over to async calls only. The latter will cause cascading problems of needing to move more and more functions over to async. Additionally, the data. shim has been removed, so anywhere we submitted data.x no longer performs updates (despite it not generating warnings previously...)

Remaining items are really just that force powers and signature abilities don't render dice in the previews

I think I've tested everything. I'll hand this off to the community and keep the issue open until v12 actually drops.


ARTEMIS-793 Improvement to OSGi integration

@graben could you please squash you please rebase on top of master vs using the merge commit.

@mtaylor that merge script we always use will fix it. I already tried it

@clebertsuconic great.  It looks like @graben has addressed your comments.  If you're happy I'll merge this?

There is one change that is wrong here. You are using the ProtocolTrackerCallback to admin DataSources. Can you separate this into a separate class? DataSourceTrackerCallback?
And instead of returning a true or false, can you return the name of the datasources?
Also: I coudln't comment on the change here given the merge mess you have on this branch now. Can  you execute these commands please?
git pull --rebase upstream master
git push origin -f your-branch-name

@graben  ^^^ (<<< just to send you a notification)

Well, I think it must be the same callback to avoid the protocol tracker to start the broker if the datasource is not bounded yet. It's just another "mandatory" dependency. I might rename the class to more general name, but separating would end up in a mass.

@graben can you rebase against master... and push -f at least?

let me think about the class name...

Rebase is done :)

A bit more this way? IMO I did not see why to change the method to addDataSource. It could be only one and this one is a dependency which is mandatory for broker startup.

@graben I understand it works now. I was just trying to be more generic on the implementation and support future needs.

Have to fix a bug introduced by refactoring. I think inner classes are looking better than an anonymous one. It might be better to add components to ProtocolTrackerCallBackImpl too make it a static class!?

sounds good

I love checkstyle. :) I thought about the actual implementation and did some small refactorings. Now I think it fits best. But we may think about synchronizing in callback as they are called in separate threads.

@graben I thought ProtocolTracker was part of the API. it's for internal use only.
We could have renamed it as much as we wanted. Since I'm the one who messed up I will fix this one :)

@graben I actually just asked this on the dev-list

@clebertsuconic That's fine with me

@graben  I have merged, after I reverted some of the bad code I made you do. Can you check please?
And sorry about that.. I really thought the ProtocolTracker was externally used.

Looks good. I give it a try this evening when back home.


The $PATH and $PYTHONPATH seem to reset to original value every time the Mininet reboot.

Mininet uses GitHub issues for bug reports and feature requests only.
These issues can be viewed at bugs.mininet.org
If you have a question that is not a bug report or a feature request,
please use the documentation at docs.mininet.org, the FAQ
at faq.mininet.org, and the mininet-discuss mailing list.
For bug reports, please fill in the following information in detail,
and also feel free to include additional information such as debug
output from mn -v debug, etc.
--- Cut Here ---
Expected/Desired Behavior:
save the value of $PATH and $PYTHONPATH every time after editing.
Actual Behavior:
The $PATH and $PYTHONPATH seem to return to empty every time the Mininet reboot.
Detailed Steps to Reproduce the Behavior:
run "export PYTHONPATH=$HOME/path/to/your/module", and shut down Mininet and open it again. The "echo $PYTHONPATH" returns nothing.
Additional Information:
It happens to $PATH too

This is pretty standard across (i guess) all linux distributions.
If you want to persist changes like this, you will have to add the export PYTHONPATH=$HOME/path/to/your/module in the last line of the .bashrc file in your home directory, i.e. echo 'export PYTHONPATH=$HOME/path/to/your/module' >> ~/.bashrc


build: Do not build "raw" binary by default

Build "raw" binary zephyr.bin only if needed. This also "fixes" building with llvm 64-bit targets which are failing when building "raw" binary file.

Erm, no. This is not an acceptable change.

I think most of the boards do not need this "raw" binary, why do we need to create it?

mcuboot upgrades are output as signed binary files, ST's DAPLINK programmer (alongside other DAPLINK) programmers use binary files for programming devices.

mcuboot upgrades are output as signed binary files, ST's DAPLINK programmer (alongside other DAPLINK) programmers use binary files for programming devices.

So what is a problem of enabling this for selected boards?

So what is a problem of enabling this for selected boards?

From what I can see in zephyr, there's 398 boards, not 4.


Link broken for ws-rtsp-repo-1.2.deb / getting 404 not found

The link for downloading ws-rtsp-repo-1.2.deb seems to be broken...
wget http://repo.tom.ru/deb/debian/non-free/all/ws-rtsp-repo-1.2.deb
--2016-08-06 22:16:18--  http://repo.tom.ru/deb/debian/non-free/all/ws-rtsp-repo-1.2.deb
Resolving repo.tom.ru (repo.tom.ru)... <IP_ADDRESS>
Connecting to repo.tom.ru (repo.tom.ru)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2016-08-06 22:16:19 ERROR 404: Not Found.

It's happening again today. Yesterday I was able to download it. Does not seem to be working today though


A+ Test suite inclusion

Will it be good to have A+ test suite (https://github.com/promises-aplus/promises-tests) along with the existing one.

They are included

Sorry.. My ignorance.. :P


Update gemma to use tanh approximation

          also not in `gemma_pytorch`... so strange. clearly the keras and pytorch folks were different teams entirely lol

Originally posted by @carmocca in https://github.com/Lightning-AI/lit-gpt/pull/941#discussion_r1498434236
The reference implementation was recently updated: https://github.com/google/gemma_pytorch/commit/324cb185aa3fe60f43dad4b7ce5096ffdd513cb1

@Andrei-Aksionov would you like to do this change?

Interesting.
Sure, I'll do it.


force:apex:execute hangs for 60s and returns status 0 when it fails

Summary
When you run force:apex:execute and enter the Apex code in STDIN, the CLI hangs for 60 seconds even though the request is already completed and the result is present in STDOUT
And if the entered Apex code does not compile or throws an Exception, the CLI returns status 0
Steps To Reproduce:
Valid Apex code (hangs for 60s):
sfdx force:apex:execute -u dev22483 <<< "System.debug('hello forcedotcom/cli!');"

Invalid Apex code (hangs for 60s and returns 0):
sfdx force:apex:execute -u dev22483 <<< "invalid apex code"

Apex code that throws exception (hangs for 60s and returns 0):
sfdx force:apex:execute -u dev22483 <<< "throw new IllegalArgumentException();"

It even returns 0 if a governor limit is reached:
sfdx force:apex:execute -u dev22483 <<< "for (Integer i = 0; i < 101; i++) Object queryResult = [SELECT Id FROM Product2 LIMIT 1];"

Expected result

The CLI should return the result as soon as the anonymous apex code block is executed
The CLI should not return status 0 if the anonymous apex code block does not compile
The CLI should not return status 0 if the anonymous apex code block throws an exception
The CLI should not return status 0 if the anonymous apex code block throws an uncatchable exception (governor limit reached)

Actual result
The CLI is always hanging for 60s even though the execution was completed and is always returning status 0 for compile errors and exceptions.
Additional information
Extra:
If using the --json flag, although the command still hangs for 60s and returns 0, I can see that the json result contains the success and compiled fields, so with jq we can override the CLI behavior and return non-zero until this is resolved:

SFDX CLI Version:
sfdx-cli/7.89.2 darwin-x64 node-v15.5.1

SFDX plugin Versions:
@oclif/plugin-autocomplete 0.3.0 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.2.2 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.10.0 (core)
@oclif/plugin-update 1.4.0-2 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-diff 0.0.6
@salesforce/sfdx-trust 3.6.0 (core)
alias 1.1.7 (core)
auth 1.4.10
config 1.2.5 (core)
evergreen 0.34.0
└─ evergreen-build 0.20.2
generator 1.1.5 (core)
salesforcedx 51.1.1 (core)
├─ limits 1.0.4 (core)
├─ user 1.1.2 (core)
├─ custom-metadata 1.0.11 (core)
├─ schema 1.0.4 (core)
├─ templates 51.3.0 (core)
├─ apex 0.1.4 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
└─ salesforce-alm 51.1.1 (core)
sfdmu 3.10.0
sfdx-cli 7.89.2 (core)
telemetry 1.1.1 (core)

OS and version: macOS Catalina 10.15.7

@mshanemc just to clarify: is this really an apex issue? 🤔 Pardon my ignorance because I also don't know if the CLI code is owned by multiple teams or not, but from what I could see from this issue the code already compiled, executed and the result was returned and presented in stdout, but the CLI is still hanged after that.
The problem apparently relies in the CLI itself and not in Apex or an API, The CLI always hangs for exactly 60 seconds, even though the API request was processed and the result returned.


Tizen SDK 2.4 Support

Support for Older versions of Tizen (this excludes Orsay)
Current Support:
Tizen 5: YES
Tizen 4: YES
Tizen 3.0: YES
Tizen 2.4: NO
Tizen 2.3: NO
Tizen Legacy (Orsay): NO

@pavjacko  Why we don't have support for Tizen 2.3 and 2.4? What things doesn't work properly on those platforms? Is it react-native-web the problem ?


Implemented hash_receiver method on mpsc

This method allows the sender to obtain the hash of the receiver
(actually Option<pointer to shared structure>). This is useful if one
wants to put the senders into HashSet or HashMap, using a newtype
pattern.
Closes #1177

Hmm, GitHub tells me that the branch is out-of-date, should I rebase?

The tests failed due to CI bug. :(

This seems fine to me, thanks!

Thank you too for merging! :)
Do you have any estimate when a new version containing the change could be released? Possibly even some way to subscribe to its publication?

@Kixunil you can watch releases on the repo under the watch button in the top right.

Thanks!


Detect IP changes

Can I check whether the IP has changed?

this library does not provide a way to give a callback to do something when an IP has changed.  I would recommend setting a timeout and check for an IP change manually.


error code E0080 is no longer printed with MIRI error message

Thanks to help from @bjorn3, @RalfJung, and @oli-obk on issue #1035 , I fixed the miri code so that error code E0080 is no longer printed out for MIRI evaluation errors. I tested my code in my Linux machine as below.

Remaining concern is whether the variable name new_tcx which I used is misleading or not.
Fixes https://github.com/rust-lang/miri/issues/1035

Thanks!
@bors r+

:pushpin: Commit e5675ab0fc03d6f2960b0ec1a8b18bdc1d42b283 has been approved by RalfJung

:hourglass: Testing commit e5675ab0fc03d6f2960b0ec1a8b18bdc1d42b283 with merge 0740a2040f1767aece15dec17f895c4fd0b613ab...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 0740a2040f1767aece15dec17f895c4fd0b613ab to master...


Madge CLI unavailable

I ran "npm -g install madge" and then tried to run madge in a project folder. But the command line responded that there were no such a command.
I also tried installing madge into the project. As far as the doc page can be understood, the CLI should work right off. But it didn't either.
What did I miss?

I ran "npm -g install madge" and then tried to run madge in a project folder. But the command line responded that there were no such a command. I also tried installing madge into the project. As far as the doc page can be understood, the CLI should work right off. But it didn't either.
What did I miss?

Is npx added to the head of the command line?
npx madge...


Display flickers when using PWM

Everything works as it should in all plugins that only use full brightness, but for every dimmed pixel added more "flickering" noise is introduced. This noise consists of random low brightness pixels and can be all over the screen.
I've had it working before and I have no clue what is causing it. Has anyone else had the same problem?

It seems to be an issue with my local hardware


Endless loop when saving changes to table edited in "Designer" mode on the web application

Describe the bug
This bug happens on the browser version of Surrealist. When i am in designer mode and press "save changes" on my tables, the "engine" goes into a endless loop. The endless loop can be seen in the Console, as the application keeps console.log(...)'ing.
To Reproduce
Steps to reproduce the behavior:

Go to The Surrealist Web App
Open the Console on the Inspect page.
Create and make changes to a table.
Press "Save Changes".
You will now see an endless console.log'ing.

Environment (you can view the current version under Settings):

Operating System: Windows
Surrealist Version: 1.11.0

Same problem on Linux, version 1.11.0

This should be fixed in Surrealist 2.0, however if you still encounter this issue feel free to re-open or create a new issue.


Credits remarks

[ ] Withdraw request popup - add the following info for Message field - Payment instructions and other notes
[ ] Withdraw request email - display message from vendor in email (now it isn't displayed anywhere) and add link to page where admin can confirm withdrawal
[ ] Confirm withdrawal popup - profiles autosuggest isn't working correctly (it maybe in Grant popup too) - looks like z-index isn't correct for profiles list

Re 2: Withdraw request email template (bx_credits_withdraw_requested) already has the message:
{email_header}

{profile_name} requested to withdraw {amount} credits from his/her balance.

{message}

Current withdraw conversion rate is {rate}

{email_footer}

Re 3: Sometimes ago z-index of Modal Popup was increased. So, similar problem should be actual for all popups with auto-suggestion field.


replace libflate with flate2

Initially rs-tiled used flate2 but switched to libflate because flate2 didn't support wasm https://github.com/mapeditor/rs-tiled/issues/47 , but flate2 has been supporting wasm via miniz_oxide for a while now https://github.com/rust-lang/flate2-rs/issues/161.
This reduces dependency duplicated by other crates and has performance benefits.

Could you please update CHANGELOG.md as well?

I updated the changelog and version.


Minor code cleanups (3)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-identity-cpp

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-identity-cpp azure-security-attestation-cpp azure-data-tables-cpp azure-messaging-eventhubs-cpp azure-security-keyvault-keys-cpp

It looks like there are some false positives detected when it comes to "API changes" that are considered breaking here.
At least in the case of marking a method param that was previously passed in by-value to const&, which isn't a breaking change. That seemed to be the only highlighted change for azure-identity-cpp.
Larry, is it possible to exclude that in the detection, to improve signal-to-noise ratio, or do we see value in keeping that diff highlighted in APIView?

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-identity-cpp azure-security-attestation-cpp azure-data-tables-cpp azure-messaging-eventhubs-cpp azure-security-keyvault-keys-cpp

It looks like there are some false positives detected when it comes to "API changes" that are considered breaking here (around const-ness). At least in the case of marking a method param that was previously passed in by-value to const&, which isn't a breaking change. That seemed to be the only highlighted change for azure-identity-cpp.
Larry, is it possible to exclude that in the detection, to improve signal-to-noise ratio, or do we see value in keeping that diff highlighted in APIView?

Api changes are not intended to detect breaking changes. They are intended to detect changes in the shape of the API.
That change is a change in the API surface, so it is correctly detected.
Having said that, there ARE changes that are false positives - for instance, when we switched from clang-15 to clang-18, the code which emits type names went from emitting the fully qualified name of the type to an unqualified type name - that is flagged as an API surface change even though it's a consequence of a tooling change.


update for yarn & package-lock.json

@InquisitiveDevelopment @joeblau What's the reason for this change? The lock files are designed to be put under version control and therefore should not be added to .gitignore.
From https://docs.npmjs.com/files/package-locks:

It is highly recommended you commit the generated package lock to source control: this will allow anyone else on your team, your deployments, your CI/continuous integration, and anyone else who runs npm install in your package source to get the exact same dependency tree that you were developing on. Additionally, the diffs from these changes are human-readable and will inform you of any changes npm has made to your node_modules, so you can notice if any transitive dependencies were updated, hoisted, etc.

@pascalberger thanks for pointing that out.  @InquisitiveDevelopment I'm going to pull this diff out.


Add guides for zbench to zig-autodoc

Currently, the documentation generated by zig build docs for the zBench project lacks guides. These guides are essential for users to understand the library beyond the auto-generated API references. They provide context, examples, and deeper explanations of the library's use and capabilities.
Detailed Description
The autogenerated API section is helpful for users already familiar with zBench, but for new users or those looking to understand advanced usage patterns, guides are indispensable. The absence of these guides represents a significant gap in our documentation.
Proposed Solution
We need to create and integrate handwritten guides into our zig-autodoc output. This can be done by specifying markdown files to include in the top-level doc comment of our root file (zbench.zig). Here's an example of how to reference these guides:
//!zig-autodoc-guide: intro.md
//!zig-autodoc-guide: quickstart.md
//!zig-autodoc-guide: advanced-docs/advanced-stuff.md

Action Items

Write comprehensive guides covering the following topics:

Introduction to zBench
Quickstart guide with basic usage examples
Technical documentation for in-depth understanding
Guides for advanced usage patterns

Place these guides in the appropriate directory structure (e.g., a docs/ folder at the root of the project).
Reference these guides in zbench.zig as shown above.
Generate the documentation using zig build docs to verify the inclusion of the guides.

added basic intro and usage guides, but adv. guides are missing. Created a follow-up issue https://github.com/hendriknielaender/zBench/issues/28


Client IP Address not sent to ingress-nginx with weave 2.7.0

What you expected to happen?
I should receive the original Client IP Address from the Weave container
What happened?
I am receiving the Weave container (kubernetes network) IP Address
How to reproduce it?
I've been working for a week on this and need some help. No matter what I try I cannot seem to get the client IP address to my back-end service. The nginx ingress controller pod always log the client IP address ($remote_addr) as the cluster IP address of the weave container (verified with ip addr command on container). According to https://github.com/weaveworks/weave/releases/tag/v2.7.0 the NO_MASQ_LOCAL=1 is now on by default which is supposed to preserve client IP Address with externalTrafficPolicy = "Local"
But I still always get the cluster IP address from Weave.
Any help would be appreciated. Below is all the relevant information I could think of.
Bare Metal (VMs)
----- kubernetes version -----
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-08T17:30:47Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
---- kube-system namespace
kube-proxy:v1.18.1
weave-kube:2.7.0
weave-npc:2.7.0
--- Helm Chart -----
name: ingress-nginx
version: "3.11.0"
repository: "https://kubernetes.github.io/ingress-nginx"
----- override chart default values -----
defaultBackend:
enabled: true
controller:
replicaCount: 4
service:
externalTrafficPolicy: "Local"
externalIPs:
- <IP_ADDRESS> # VIP
- <IP_ADDRESS>
- <IP_ADDRESS>
- <IP_ADDRESS>
- <IP_ADDRESS>
nodeSelector:
dmz: "true"
tolerations:
- key: "dmz"
operator: "Exists"
effect: "NoSchedule"
extraArgs:
default-ssl-certificate: default/tls-ingress-controller
config:
proxy-read-timeout: "300"
proxy-send-timeout: "300"
enable-real-ip: "true"
use-forwarded-headers: "true"

I am using 2.8.0. It doesn't preserve the ip with externalTrafficPolicy = "Local"

I am using 2.8.0. It doesn't preserve the ip with externalTrafficPolicy = "Local"

This is now working for me.  The only thing that I believe changed is the Kubernetes version from 1.18.1 to 1.19.4
----- kubernetes version -----
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-11T13:09:17Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
---- kube-system namespace
kube-proxy:v1.18.1
weave-kube:2.7.0
weave-npc:2.7.0
--- Helm Chart -----
name: ingress-nginx
version: "3.11.0"
repository: "https://kubernetes.github.io/ingress-nginx"

This is now working for me.  The only thing that I believe changed is the Kubernetes version from 1.18.1 to 1.19.4
----- kubernetes version -----
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-11T13:09:17Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
---- kube-system namespace
kube-proxy:v1.18.1
weave-kube:2.7.0
weave-npc:2.7.0
--- Helm Chart -----
name: ingress-nginx
version: "3.11.0"
repository: "https://kubernetes.github.io/ingress-nginx"

well, I am on 1.19.4 with Weave 2.8.1

well, I am on 1.19.4 with Weave 2.8.1


OkHttp (used by UrlConnection) might start a new Thread when reading response

I'm the maintainer for ACRA (Android Crash Reporter) and as part of the migration to using UrlConnection instead of the Apache Http library we are running foul of OkHttp potentially starting a new Thread during runtime shutdown when we attempt to read a HTTP response..
See https://github.com/ACRA/acra/issues/313
Is there any way of ensuring that OkHttp doesn't start a new Thread?
D/ACRA﹕ Connect to https://testapps.cloudant.com/acra-testapp/_design/acra-storage/_update/report
 09-28 22:35:09.235 16507-16536/? E/ACRA﹕ ACRA caught a InternalError for com.blogspot.test.testapp
 java.lang.InternalError: Thread starting during runtime shutdown
 at java.lang.Thread.nativeCreate(Native Method)
 at java.lang.Thread.start(Thread.java:1063)
 at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:921)
 at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1337)
 at com.android.okhttp.ConnectionPool.addConnection(ConnectionPool.java:208)
 at com.android.okhttp.ConnectionPool.recycle(ConnectionPool.java:198)
 at com.android.okhttp.OkHttpClient$1.recycle(OkHttpClient.java:111)
 at com.android.okhttp.internal.http.HttpConnection$AbstractSource.endOfInput(HttpConnection.java:377)
 at com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.read(HttpConnection.java:426)
 at com.android.okhttp.okio.RealBufferedSource$1.read(RealBufferedSource.java:349)
 at java.io.InputStream.read(InputStream.java:162)
 at com.a.a.a.a.a(SourceFile:238)
 at com.a.a.a.a.a(SourceFile:123)
 at com.a.a.k.run(SourceFile:112)

No, there's no such mechanism. When does Android shutdown the runtime?!

I suspect Android is marking it as shutdown as soon as an unchecked Exception or Error is not handled by the app.
ACRA installs an UncaughtExceptionHandler in Application#onCreate. We send the HttpRequest from the UncaughtExceptionHandler. I can only presume that the Android framework is intercepting in some fashion to mark the VM as shutdown.

So it's sounding like ACRA won't be able to UrlConnection to send Http requests since UrlConnection is using OkHttp under the covers. Does that sound correct?

You're probably better off writing the crash information to disk somewhere, and picking it up when the app relaunches. The crash might be an OutOfMemoryError, for example, and you're also going to need to allocate a bunch of memory to make an HTTP request.

(No action for us here.)

We do write the crash info to disk as a fall back.
But sending requires the app to relaunch which doesn't automatically occur for all Android versions.
One action for OkHttp could be to allow a minimum nr of threads in the pool instead of always collapsing to zero.

This is a dupe of a really, really old issue. I'd have to search to find it.
On Wed, Oct 7, 2015, 10:06 PM William Ferguson<EMAIL_ADDRESS>wrote:

We do write the crash info to disk as a fall back.
But sending requires the app to relaunch which doesn't automatically occur
for all Android versions.
One action for OkHttp could be to allow a minimum nr of threads in the
pool instead of always collapsing to zero.
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/issues/1907#issuecomment-146393303.

https://github.com/square/okhttp/issues/1153

Thanks for the reference Jake.


[shttp] Feature Request: Support full SCION address in http.Request.Host field

The standard Golang http client resolves IP addresses in the request's host field (with the form host:port), it would be nice if shttp could support this as well. E.g. it should be possible to make a request to https://17-ffaa:0:1102,[<IP_ADDRESS>]:33333/foo/bar.
Then it would be possible resolve http requests without using domain names but just the SCION address, partially solving #10 before RAINS is introduced and simplifying the implementation of 2SMS, where domain names are not used.

See also #16; not a fix complete for this as far as I understand, but relevant anyway.

Yes, this is currently not supported. Mainly because we use the standard net/http client which doesn't know how to parse SCION addresses. We would need to have our own shttp client implementation to do that.

I see, thanks for the explanation.

closed by https://github.com/netsec-ethz/scion-apps/pull/59


Extra comma (,) in package.json

Installed the module today, it wont load, error log
SyntaxError: Error parsing /home/micke/MagicMirror/modules/MMM-EnergyMonitor/package.json: Expected double-quoted property name in JSON at position 716
Checked package.json:
package.json
 #1 Unexpected ','.
    "homepage": "https://github.com/deg0nz/MMM-EnergyMonitor#readme", // Line 29, Pos 67

Removed the extra comma, module loaded OK (but did not show up on screen, will look into that later

I can confirm that error.

Thanks for the hint. Fixed with https://github.com/deg0nz/MMM-EnergyMonitor/commit/a6b7a4357d5cfaf00eec537b3c75e698ec7cc22a


SAKIII-4755 - Remove shortenString method

Jira: https://jira.sakaiproject.org/browse/SAKIII-4755

@christianv : Can you create a JIRA ticket for this and update the pull request?
Also, it looks like there is a merge conflict for this patch.

@nicolaasmatthijs

Create Jira ticket ✔
Update pull request ✔
Fix merge conflict ✔ (did this by cherry-pick and a force push)

Squashed and merged


Trouble using parser with initial dictionary

Hey guys, I'm trying to use this parser along with OneSignal (push notifications) and I'm having a little trouble. It doesn't help that I'm completely new to C++ but I was wondering if you could give me a little point in the right direction. The data I'm trying to parse looks like this:
{
"coinsAdded": "10",
"sound": "default",
"title": "test"
}
and it's in a const char* called additionalData.
Any help you guys could give would be awesome.
Thanks, and great work!

I forgot to mention I'm using xCode 7.3.1

Hi @calkinssean,
I am not sure whether I understand you correctly. But it seems to me that this is what you want:
#include <json.hpp>

using nlohmann::json;

int main()
{
	// your data as const char*
	const char* additionalData = "{\"coinsAdded\": \"10\", \"sound\": \"default\", \"title\": \"test\"}";

	// create a JSON object
	json j = json::parse(additionalData);

	// pretty-print
	std::cout << j.dump(4) << std::endl;
}

That did it, sorry for the simplicity of my question, C++ just isn't my field at all. But you guys have done some great work here and the library works beautifully.


Bump dev container to 0.1.7

Signed-off-by: Pravin Pushkar<EMAIL_ADDRESS>Description
Bump dev container to 0.1.7
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: Endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Synced with @ItalyPaleAle . There will be few more changes in this PR after https://github.com/dapr/dapr/pull/4499 is merged.


An assembly specified in the application dependencies manifest (ErpNet.FP.Server.deps.json) was not found

I am getting the following error when trying to run the project (the linux 64 build) on a Debian VM:
Error:
  An assembly specified in the application dependencies manifest (ErpNet.FP.Server.deps.json) was not found:
    package: 'runtimepack.Microsoft.NETCore.App.Runtime.linux-x64', version: '3.0.0'
    path: 'createdump'

I have installed both .NET Core 3.0 SDK and .NET Core 3.0 Runtime on the machine.
When I run dotnet --info on the machine - this is what I get:
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100
 Commit:    04339c3a26

Runtime Environment:
 OS Name:     debian
 OS Version:  9
 OS Platform: Linux
 RID:         debian.9-x64
 Base Path:   /usr/share/dotnet/sdk/3.0.100/

Host (useful for support):
  Version: 3.0.0
  Commit:  95a0a61858

.NET Core SDKs installed:
  3.0.100 [/usr/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

https://go.microsoft.com/fwlink/?linkid=798306

It is not related to the ErpNet.FP library, It is related to. net core framework, so I will close thos issue.


Compiler bug

Just encountered this error:
The build step failed for canister 'renrk-eyaaa-aaaaa-aaada-cai' with an embedded error: The command '"/home/markr/.cache/dfinity/versions/0.7.1/moc" "/home/markr/work/dfinity/main.mo" "-o" "/home/markr/work/dfinity/.dfx/local/canisters/exchange/exchange.did" "--idl" "--actor-idl" "/home/markr/work/dfinity/.dfx/local/canisters/idl/" "--actor-alias" "exchange" "renrk-eyaaa-aaaaa-aaada-cai" "--actor-alias" "token" "rkp4c-7iaaa-aaaaa-aaaca-cai" "--actor-alias" "token_assets" "rno2w-sqaaa-aaaaa-aaacq-cai" "--package" "base" "/home/markr/.cache/dfinity/versions/0.7.1/base"' failed with exit status 'exit code: 2'.
Stdout:

Stderr:
OOPS! You've triggered a compiler bug.
Please report this Motoko issue at forum.dfinity.org with the following details:

Motoko (revision 742az5xm-apvj2nq2-i96m0rlr-n1npyb43)

Fatal error: exception "Assert_failure mo_idl/idl_to_mo.ml:106:9"
Raised at file "mo_idl/idl_to_mo.ml", line 106, characters 9-21
Called from file "pipeline/pipeline.ml", line 345, characters 14-61
Called from file "lang_utils/diag.ml", line 32, characters 27-30
Called from file "lang_utils/diag.ml", line 48, characters 20-25
Called from file "lang_utils/diag.ml", line 32, characters 27-30
Called from file "pipeline/pipeline.ml" (inlined), line 356, characters 20-42
Called from file "pipeline/pipeline.ml", line 358, characters 47-63
Called from file "pipeline/pipeline.ml", line 366, characters 21-52
Called from file "lang_utils/diag.ml", line 32, characters 27-30
Called from file "lang_utils/diag.ml", line 32, characters 27-30
Called from file "pipeline/pipeline.ml", line 446, characters 27-71
Called from file "exes/moc.ml", line 136, characters 24-53
Called from file "exes/moc.ml", line 205, characters 4-23

This is with dfx 0.7.1

Thanks for the report! It is actually a duplicate of https://github.com/dfinity/motoko/issues/2319, but your contribution is appreciated. I hope can push a fix soon.

duplicate of #2319


Don't define which helper on Chef 16+ to avoid conflicts

We have our own which helper in the DSL now, which takes 2 args. This
helper is getting injected over it, which works most of the time (not as
well), but doesn't work when someone passes additional args. This breaks
gem_package and probably some other things in the ecosystem. We need to
continue to support chef-sugar being installed on a modern chef-client
release since that's necessary for client upgrades, but we should not
allow the injection of a legacy helper over the built-in.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

This is what I get for fixing specs in the middle of a meeting.


[QA] Minigames | Red Exclamation Mark Hidden Behind Daily Quest UI

Explorer Alpha build versions:

v0.34.0

Issue Description:
The UI for the Daily Quest (shaped like a rocket, located next to the minimap) displays a red exclamation mark, indicating available quests. However, the exclamation mark is partially hidden behind the rocket UI, making it difficult to notice. The exclamation mark should appear in front of the rocket icon for better visibility.
STR:

Launch the Explorer with Daily Quests enabled.
Look at the rocket-shaped Daily Quest UI next to the minimap.
Observe the red exclamation mark partially hidden behind the rocket UI.
Click in the rocket to open the modal.
Observe the exclamation mark partially hidden and won't dissapear.

❌ Actual Result
The red exclamation mark is hidden behind the rocket-shaped UI.
✅ Expected Result
The red exclamation mark should appear in front of the rocket-shaped UI for proper visibility.
Evidence:

Saw the issue the same day of this post, today with the launch of the 0.35 I can't replicate the issue any more


Migrate to sbt

I went ahead and removed the compiler plugins (which we don't use here) and added code coverage and MiMa (although neither will fail the build).

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6cd8b24). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             master   #32   +/-   ##
======================================
  Coverage          ?    0%
======================================
  Files             ?    24
  Lines             ?   218
  Branches          ?     2
======================================
  Hits              ?     0
  Misses            ?   218
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd8b24...88ed275. Read the comment docs.

@bastewart I think so! I'm happy to try it once #33 is ready.


fix statusBarTranslucent height

Issue: https://github.com/react-native-modal/react-native-modal/issues/571

Thanks for the PR! This will probably require some testing before being merged to ensure it works on different use cases:

iPhone with and without notch
Android devices with and without the bottom bar enabled

I can confirm this fixes my problem on Android as well.


Puzzle difficult

Is there a way to make a 3 x 4 puzzle?

@Azis202017 yes you can do this by giving puzzleRowColumn parameter in the EasyPuzzleGameApp.
await const EasyPuzzleGameApp(
      title: 'Puzzle',
    /// this is the puzzle full image
      puzzleFullImg:
          'https://github.com/mhanzla80/easy_puzzle_game/raw/master/puzzle.png',
    /// this is the puzzle block images, you have to pass the folder path in which images are present.
    /// if rows and columns are 3 the 3x3=9
    /// if rows and columns are 4 the 4x4=9
      puzzleBlockFolderPath:
          'https://github.com/mhanzla80/easy_puzzle_game/raw/master/blocks',
    /// this is the number of puzzle rows and columns.
      puzzleRowColumn: 4,
    );
);

Yes I do that, sorry if my question is not clear, I mean can we custom row and column for the puzzle difficult? because I just have 6 images, the error show  I have to insert 7 and 8 images.

No, The puzzle must have square matrix.


fix: Update SelfReferenceRule to show entity's other property completion

Description
Update the selfReference autocomplete rule to show completion for the entity's other property when writing JS in one of its property.
Fixes https://github.com/appsmithorg/appsmith/issues/34684
Automation
/test js
:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9780079455
Commit: 03eb92fdda61a917829be20fb6f5d99562f162f3
Cypress dashboard.
Tags: @tag.JS

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

Bug Fixes

Improved accuracy of autocomplete suggestions by refining self-reference detection logic.

Tests

Added new test cases to verify proper blocking of self-referencing completions.
Updated existing tests to include propertyPath in entity sorting validation.

/build-deploy-preview skip-test=true


change development workflow to PRs

currently commits are being pushed to master directly
would help a lot to follow your work on this package to create PRs even if you are the top lead or maintainer, this is how it is done in FOSS. I respect your decision if you ignore this request though it would be a great deal of help to get PR notifications and help review contributing.
Thank you

I'm not promising I'll do it right away but I'll try for futur contribution

yeah and thanks again for your work man :+1:


Incomplete Apache 2.0 license text returned from Engine.get_license_info()

Tested versions
Reproducible in:

v3.5.3.stable.official [6c814135b]
v4.2.1.stable.arch_linux
v4.3.dev5.official [c9c17d6ca]

System information
Godot v4.3.dev5 - EndeavourOS #1 SMP PREEMPT_DYNAMIC Fri, 08 Mar 2024 01:59:01 +0000 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (nvidia; 550.54.14) - Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 Threads)
Issue description
Engine.get_license_info() returns incomplete version of Apache 2.0 license. See https://github.com/godotengine/godot/blob/c9c17d6ca/COPYRIGHT.txt#L567-L578 for the actual text being returned. Apache 2.0 is the only license not included in full, the others seem complete.
Example of a full Apache 2.0 license: https://github.com/godotengine/godot/blob/c9c17d6ca/thirdparty/astcenc/LICENSE.txt
I am not a lawyer.
Steps to reproduce
Run the reproduction project to see the license
Or just run:
printerr(Engine.get_license_info()["Apache-2.0"])

Minimal reproduction project (MRP)
apache-2.0-license-viewer.zip

This appears to be how they recommend citing it (see here https://www.apache.org/licenses/LICENSE-2.0). Is there any reason to think that is insufficient?

I found a related discussion on this topic here: https://github.com/licensee/licensee/issues/82#issue-132772719
and https://github.com/licensee/licensee/issues/103
To me it seems that Godot is using boilerplate version intended mainly for source file headers where long text is not practical.
Whether using this version for Engine.get_license_info() is sufficient or not would probably depend on use cases of this function.
My use case was to display license information to the end user to read in a game menu UI.
I am not sure if displaying boilerplate version of the license there is sufficient or not (not being a lawyer) but for the sake of consistency it might be better to have all licenses returned from Engine.get_license_info() be in full.
Note that Engine.get_license_info() already contains CC-BY-4.0 license which is even longer (309 lines) compared to full Apache-2.0 (173 lines).


bash prompt for install in README

Coverage remained the same at 100.0% when pulling d4adf8dc153ee7fe088b16818171a9e6fa95462a on arcondello:readmebashprompt into d667db95fd827b0e8c3d534327ab66f0efaf52c1 on dwavesystems:dev.


Backend and frontend integration for image/org update

Codecov Report

Merging #114 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   14.27%   14.21%   -0.06%
==========================================
  Files          61       61
  Lines        2207     2216       +9
  Branches      386      386
==========================================
  Hits          315      315
- Misses       1719     1728       +9
  Partials      173      173

Impacted Files
Coverage Δ

components/portal/src/components/org/index.js
2.94% <0%> (-0.14%)
:arrow_down:

...nents/portal/src/components/image/version/index.js
1.94% <0%> (-0.06%)
:arrow_down:

...rc/components/image/version/VersionUpdateDialog.js
6.25% <0%> (ø)
:arrow_up:

...s/portal/src/components/image/ImageUpdateDialog.js
4.65% <0%> (ø)
:arrow_up:

...nents/portal/src/components/org/OrgUpdateDialog.js
5.88% <0%> (ø)
:arrow_up:

components/portal/src/components/image/index.js
2.17% <0%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0442914...95806ad. Read the comment docs.


Authentication Provider API

Problem
There are currently some extensions that attempt to provide authentication abilities that can be reused by other extensions. (An example being the Azure Account extension). Now that we've begun working on login for settings sync, it's worth revisiting if authentication should be a first-class concept in VS Code. By exposing an API to contribute an authentication flow

the core of VSCode can potentially leverage authentication
other extensions can leverage authentication
UI for account management could be centralized

Proposal
I propose introducing a concept of an "AuthenticationProvider". Such a provider implements methods for logging in and logging out of a specified account, and exposes a list of accounts that are currently available with an event listener for changes to these. This abstracts away refreshing tokens from consumers - the AuthenticationProvider extension can manage refreshing in the background and fire an event when the accessToken has been changed.
export interface Account {
	readonly id: string;
	readonly accessToken: string;
	readonly displayName: string;
}

export interface AuthenticationProvider {
	readonly id: string; // perhaps "type"? Would be something like "GitHub", "MSA", etc.
	readonly displayName: string;

	accounts: ReadonlyArray<Account>;
	onDidChangeAccounts: Event<ReadonlyArray<Account>>;

	login(): Promise<Account>;
	logout(accountId: string): Promise<void>;
}

export namespace authentication {
	export function registerAuthenticationProvider(provider: AuthenticationProvider): Disposable;
	export const authenticationProviders: ReadonlyArray<AuthenticationProvider>;
}

Consumers would need to know the id of the provider they're looking for. For example, the settings sync code would look for an "MSA" provider since this is what the setting sync backend currently needs.
Since the authentication provider extension would be activated in each VS Code window, the extension would be responsible for synchronizing state across instances. By default, such extensions would have ["ui", "workspace"] extensionKind, so that they can store and read credentials on the local machine in both the desktop and web case.

Sounds very interesting. I have use case this would come handy.
Right now it's just custom development tools implementation, a bit hacky though. Process is to get access token written down to a temporary file in the project's directory for running integration tests against system requiring OAuth login through browser (and MFA) and there's no way adding more permanent application authentication. It's done by running a console script activating OAuth process, then giving url for user to visit in browser and copy the url back to the script waiting for input in console. Then the access token is written to a json file which can be then consumed by other scripts. Was considering even to have headless chrome to avoid the browser step.
Now if the VSCode first class standard OAuth provider (would cover many login cases) could be configured per project basis (.vscode/extensions.json, .vscode/authentication.json?) to write the returned/refreshed access token to a specified file in active project, and have easy way to select specific OAuth target account to login manually...

The Docker extension would get a lot of mileage out of some standardization of OAuth flows: https://github.com/microsoft/vscode-docker/issues/869.

This is missing the authentication label.

So would all extensions loading into VScode be able to read all accessTokens for all of my logged-in authentication providers?  The proposed API surface implies so.  That feels like a potential security hole.  For example, I install an extension to do something but it turns out that it reads my github accessToken and sends that to some server or does something else nefarious with my account without ever having to prompt me for permission.

So would all extensions loading into VScode be able to read all accessTokens for all of my logged-in authentication providers? The proposed API surface implies so. That feels like a potential security hole. For example, I install an extension to do something but it turns out that it reads my github accessToken and sends that to some server or does something else nefarious with my account without ever having to prompt me for permission.

@OkGoDoIt There is a feature called "Manage Trusted Extensions" that should address that. There's a brief description in #93811. Regarding the API, check https://github.com/microsoft/vscode/blob/9be0faf246ce291ca08c0a9f0fe88d2b15bf0832/src/vs/vscode.proposed.d.ts#L111-L119
which indicates that a user must consent to sharing authentication information with an extension in order for it to be able to retrieve the session.

When the GitHub Pull Request & Issues extension switched to using this new Authentication API it lost the support for enterprise GitHub deployments. I assume that's because the above API is missing something fundamental for that specific style of access (API key based instead of username/password based?)
What are the plans for updating the API to add in what was missing for GitHub enterprise auth? I assume other extensions will need similar capabilities as well.

When the GitHub Pull Request & Issues extension switched to using this new Authentication API it lost the support for enterprise GitHub deployments. I assume that's because the above API is missing something fundamental for that specific style of access (API key based instead of username/password based?)
What are the plans for updating the API to add in what was missing for GitHub enterprise auth? I assume other extensions will need similar capabilities as well.

Issue in question:
https://github.com/microsoft/vscode-pull-request-github/issues/1793
This has broken GithubPullRequests for everyone using enterprise

Hello,
this looks interesting.
My use case: I have extension that would like to use an resource API that requires OpenID Connect authentication for access. The users of my extension would provide required information (issuer url, client id), after user authenticated the extension would receive access token which would then be used to access the resource API.
So without this Authentication Provider API it seems I would have to code it in the extension.
❓ Would this API help in my use case? I've tried using it, and the workflow seems appropriate. Currently there are only Microsoft and Github selection choices. Would I have to write my own Authentication Provider? Or would there be some generic provider / some extension I could use?

On another note, I tried using it logged into Microsoft account. I noticed it listed my account as "signed in" even after restarting all vscode instances. I also found no way to log out. Is there such way?
I also got following error when I tried to log in again:

In the original post it is mentioned that the Authentication Provider API should abstract away also the refreshing of the accessTokens. I am a little bit puzzled by the fact that a refreshToken is nowhere mentioned.
Is this feature still in scope?

The authentication provider can store whatever data it needs to internally, so for example in the built in Microsoft Authentication Provider, it writes the refresh token to the OS credential manager. Consumers of the API don't need to care about this token, since the auth provider is responsible for always providing a valid token when asked for one. Consumers should call each time they need a token, the provider checks if the current access token is past expiry and does the refresh

The logout function did not make it into the final version. Any way to logout at all?
I also asked on SO.

@Domiii I can see some login and logout related code in the proposed API
https://github.com/microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L99
https://github.com/microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L145

Somewhat a tangential question: how can the github pull request extension use this proposed authentication API in regular VS Code, while https://code.visualstudio.com/api/advanced-topics/using-proposed-api states:

Proposed API is a set of unstable API that are implemented in VS Code but not exposed to the public as stable API does. They are subject to change, only available in Insiders distribution and cannot be used in published extensions.

Do Microsoft-published extensions get a pass on the above statement?

Do Microsoft-published extensions get a pass on the above statement?

Not completely, we have a very small list of extensions that are opted into being able to use the proposed API. This helps us iterate on and test API, but is also a source of occasional pain as we've sometimes unintentionally broken these extensions.

@Domiii I can see some login and logout related code in the proposed API
https://github.com/microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L99
https://github.com/microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L145

Yes, it was proposed, and (iirc, also implemented) in the experimental version. But as I said, it did not make it into the final version of the API, for some reason.

 But with this proposal can there be "SshAuthenticationProvider" which will store my ssh username + password and provide it to vscode-remote-ssh plugin?
(I know ssh keys is the way to go about that but I am dealing with stubborn cluster admins).

When trying to get token for Microsoft I get following error -
An error occurred while signing in:
AADSTS65002: Consent between first party application 'aebc6443-996d-45c2-90f0-388ff96faa56' and first party resource '00000003-0000-0000-c000-000000000000' must be configured via preauthorization - applications owned and operated by Microsoft must get approval from the API owner before requesting tokens for that API. Trace ID: 1c686e2e-9c9d-4e2e-a8bb-f821f439ae00 Correlation ID: a6b11720-bb61-455a-8904-34598e458e83 Timestamp: 2020-12-17 05:04:34Z

What do I need to do? Is there any way to change the applicationid?

I am facing the same issue as @ankitbko
To be honest, information about this functionality in documentation is poor - for example, there are no links to topics with microsoft/github scopes descriptions.

Will it be possible to contribute several auth provider for the same id? For instance my extension has an access to a generic oauth provider which can handle GitHub as well.

@RMacfarlane When trying to get token for Microsoft I get following error -
An error occurred while signing in:
AADSTS65002: Consent between first party application 'aebc6443-996d-45c2-90f0-388ff96faa56' and first party resource '00000003-0000-0000-c000-000000000000' must be configured via preauthorization - applications owned and operated by Microsoft must get approval from the API owner before requesting tokens for that API. Trace ID: 1c686e2e-9c9d-4e2e-a8bb-f821f439ae00 Correlation ID: a6b11720-bb61-455a-8904-34598e458e83 Timestamp: 2020-12-17 05:04:34Z

What do I need to do? Is there any way to change the applicationid?

What scopes/API are you using here?

I am using vso.code_write, vso.threads_full and vso.work_write

@TylerLeonhardt I am also hitting the same issue when trying to hit ADO apis with specific scopes. Is this solution recommended for auth against ADO?
+1 to the question about logout, is there any other way to log out since its still in proposed-api?

@Domiii in case you were still stuck on this, looks like the accounts (person icon) on the activity bar has a way to log out. It will show you a list of accounts used to log in and what extensions are using it.

Will it be possible to contribute several auth provider for the same id?

No, each auth provider needs a unique id.
I'm finalizing the provider portion of the API which will allow others to create authentication providers:
	/**
	 * Options for creating an [AuthenticationProvider](#AuthentcationProvider).
	 */
	export interface AuthenticationProviderOptions {
		/**
		 * Whether it is possible to be signed into multiple accounts at once with this provider.
		 * If not specified, will default to false.
		*/
		readonly supportsMultipleAccounts?: boolean;
	}

	/**
* An [event](#Event) which fires when an [AuthenticationSession](#AuthenticationSession) is added, removed, or changed.
*/
	export interface AuthenticationProviderAuthenticationSessionsChangeEvent {
		/**
		 * The [AuthenticationSession](#AuthenticationSession)s of the [AuthenticationProvider](#AuthentiationProvider) that have been added.
		*/
		readonly added: ReadonlyArray<AuthenticationSession>;

		/**
		 * The [AuthenticationSession](#AuthenticationSession)s of the [AuthenticationProvider](#AuthentiationProvider) that have been removed.
		 */
		readonly removed: ReadonlyArray<AuthenticationSession>;

		/**
		 * The [AuthenticationSession](#AuthenticationSession)s of the [AuthenticationProvider](#AuthentiationProvider) that have been changed.
		 */
		readonly changed: ReadonlyArray<AuthenticationSession>;
	}

	/**
	 * A provider for performing authentication to a service.
	 */
	export interface AuthenticationProvider {
		/**
		 * An [event](#Event) which fires when the array of sessions has changed, or data
		 * within a session has changed.
		 */
		readonly onDidChangeSessions: Event<AuthenticationProviderAuthenticationSessionsChangeEvent>;

		/**
		 * Get a list of sessions.
		 * @param scopes An optional list of scopes. If provided, the sessions returned should match
		 * these permissions, otherwise all sessions should be returned.
		 * @returns A promise that resolves to an array of authentication sessions.
		 */
		// eslint-disable-next-line vscode-dts-provider-naming
		getSessions(scopes?: string[]): Thenable<ReadonlyArray<AuthenticationSession>>;

		/**
		 * Prompts a user to login.
		 * @param scopes A list of scopes, permissions, that the new session should be created with.
		 * @returns A promise that resolves to an authentication session.
		 */
		// eslint-disable-next-line vscode-dts-provider-naming
		createSession(scopes: string[]): Thenable<AuthenticationSession>;

		/**
		 * Removes the session corresponding to session id.
		 * @param sessionId The id of the session to remove.
		 */
		// eslint-disable-next-line vscode-dts-provider-naming
		removeSession(sessionId: string): Thenable<void>;
	}

	/**
	 * Namespace for authentication.
	 */
	export namespace authentication {
		...

		/**
		 * Register an authentication provider.
		 *
		 * There can only be one provider per id and an error is being thrown when an id
		 * has already been used by another provider. Ids are case-sensitive.
		 *
		 * @param id The unique identifier of the provider.
		 * @param label The human-readable name of the provider.
		 * @param provider The authentication provider provider.
		 * @params options Additional options for the provider.
		 * @return A [disposable](#Disposable) that unregisters this provider when being disposed.
		 */
		export function registerAuthenticationProvider(id: string, label: string, provider: AuthenticationProvider, options?: AuthenticationProviderOptions): Disposable;
	}

So what scopes does the API supports for now? Will AZDO and Graph APIs be supported?

This issue is just tracking the API, the implementation of the Microsoft provider is unchanged. Right now the provider supports getting an ARM token with "https://management.core.windows.net/.default" and "offline_access". This issue tracks opening up the provider to more scopes by allowing different client ids to be passed

Does this API allow to create an extension that is able to fetch access tokens from AAD B2C with user delegation?

@Domiii in case you were still stuck...

@monil-patel thank you for the info! I have not revisited the issue yet, but will very soon; so, your help is much appreciated :)


Rename to Serverless Operator #2

Description
Rename Controller Manager to serverless operator part 2
Related issue(s)
https://github.com/kyma-project/serverless-manager/issues/116

/retest

This is the output from the kustomize build spell:
/Users/pprecel/go/src/github.com/kyma-project/serverless-manager/bin/kustomize build config/default | kubectl apply -f -
customresourcedefinition.apiextensions.k8s.io/serverlesses.operator.kyma-project.io created
serviceaccount/serverless-serverless-operator created
role.rbac.authorization.k8s.io/serverless-leader-election-role created
clusterrole.rbac.authorization.k8s.io/serverless-operator-role created
rolebinding.rbac.authorization.k8s.io/serverless-leader-election-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/serverless-operator-rolebinding created
configmap/serverless-serverlesses.operator.kyma-project.io created
deployment.apps/serverless-operator created

I would suggest renaming the following resources and adding the operator word to them (to avoid bugs like this described here):

serviceaccount/serverless-serverless-operator
role.rbac.authorization.k8s.io/serverless-leader-election-role
rolebinding.rbac.authorization.k8s.io/serverless-leader-election-rolebinding


npm version not in sync

Hi,
the version of bigfile on npm  has line 81 of bigfile.js
RED.nodes.registerType("bigfile reader",BigFileInNode);
rather than
RED.nodes.registerType("bigfile",BigFileInNode);
Can you update to be in sync ? - thanks

Hello
Sorry for that. I'll do that tonight CEST
Regards

Le 15 déc. 2016 à 11:23, Dave Conway-Jones<EMAIL_ADDRESS>a écrit :
Hi,
the version of bigfile on npm has line 81 of bigfile.js
RED.nodes.registerType("bigfile reader",BigFileInNode);
rather than
RED.nodes.registerType("bigfile",BigFileInNode);
Can you update to be in sync ? - thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

which tonight ?

Done. I've made the change back to "bigfile reader" for compatibility
I've made a slight change to documentation to make the example fully working

Thanks !


Redirect players on server crash

Is it possible to redirect players to other server if a server crash/disconnect is detected? Obviously this wouldn't work if both servers were down if there are hardware/netwerk issues.

Sounds awesome to me

There's no way to detect it afaik, so this is not gonna be possible


Incorrect URL for account login

Issue in ./help/tools/site-wide-analysis-tool/installation.md

Under the Commerce Services Connector heading:

Log into accounts.magento.com - the URL should be account.magento.com (without the S)

I also suggest adding a hint about what you should do if you are unable to log into the account:
Unable to log in to Adobe Commerce support or cloud account

Published update to address this issue. Update is available in Experience Leagure: Sitewide Analysis Tool - Installation - Commerce Services Connector.


crypto: add initial bls support

Code copied from tezos/kernel.
There will be a follow-up MR to integration it better with the rest of the tezedge crates.

superseded by !18


Firmware halt should be followed by an automatic reset

When folks start deploying the BattOr in infrastructure, they will not want to unplug it every time there is an error.

Fixed.


Consider moving away from unmaintained gojay

Gojay has not seen any activity in a long time, and one of it's dependencies isn't available at the given source path anymore, causing build failures:
https://github.com/francoispqt/gojay/issues/128
https://github.com/syncthing/syncthing/issues/8256
Looking at a recent comparison (https://medium.com/geekculture/my-golang-json-evaluation-20a9ca6ef79c) it looks like the standard encoding/json library is pretty decent for encoding (and there's only encoding in the usecase here, right?). Otherwise https://github.com/goccy/go-json or https://github.com/json-iterator/go look like good candidates.

@marten-seemann can you update accordingly?
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /x86_64/host/usr/share/go-path/pkg/mod/cache/vcs/f6f367fb9d5656665ab3c2c1c3b2a44c2ffc79f6b70612f5864d7ceedcc7b9ea: exit status 128:
	fatal: repository 'https://git.apache.org/thrift.git/' not found

What is there to update? We're already using the most recent gojay version.
Wasn't the Go module proxy intended to prevent this from happening?

I don't think there's anything to update. And I don't understand under what circumstances that build issue is happening (doesn't for me). Maybe there's some build modes where said proxy isn't used? Anyway my request is more about dropping an unmaintained library (gojay), that also adds unnecessary dependencies - which as a nice side-effect will also fix this build error.

@marten-seemann the thrift source site is outdated

@imsodin, sorry, I was only replying to @dmanlfc yesterday.

Looking at a recent comparison (https://medium.com/geekculture/my-golang-json-evaluation-20a9ca6ef79c) it looks like the standard encoding/json library is pretty decent for encoding (and there's only encoding in the usecase here, right?).

You're right, the only thing we care about is decoding JSON. It's used for qlog, where we're logging (when enabled) every single frame in every single packet received (plus a bunch of other internal events). It's super valuable for debugging QUIC transfers, especially when combined with the awesome qvis.
That's a massive amount of data we're encoding, especially during high-bandwidth transfers. That's the reason why we picked gojay: it's really, really fast. Especially allocation-wise, and we're in a regime where GC pressure matters a lot.
I'd be very happy to move to encoding/json, but last time I benchmarked it, it was really slow (unfortunately, I don't have that benchmark lying around any more). Unfortunately, I don't currently have the time to tackle this transition.
@imsodin, would you be willing to help us out here? Encoding a packet_received event with a small number of frames (STREAM and ACK) would probably be the most interesting benchmark to look at.

To add more details why encoding/json is out of the question: It would cause extra allocations (and GC pressure) for every single frame.
The frames passed to qlog are defined in the logging package: https://github.com/lucas-clemente/quic-go/blob/master/logging/frame.go. Most of them are just aliases for the internal frame types used by quic-go. qlog then serializes these frames without any allocations, for example here: https://github.com/lucas-clemente/quic-go/blob/332473668a992ce372c54c353b2bdc24344cf46e/qlog/frame.go#L133-L136
Now one might argue that one could define the JSON serialization of frames in the wire package (it would be a slight layer violation, but we could probably live with that, as qlog is being standardized by the IETF). However, this fails due to the insufficiencies of encoding/json. As you can see from the example above, the token needs to wrapped in its on JSON object.

Could perhaps use something more like:
https://github.com/bytedance/sonic
If performance is a concern.

Could perhaps use something more like:
https://github.com/bytedance/sonic
If performance is a concern.

Also doesn't allow serialization without allocations. Really, moving away from gojay is only an option if we can preserve the performance properties. If not, I don't see any problem staying with gojay, even if it's unmaintained (it outputs correct JSON really fast, and that's the main thing that matters).

gojay has a dependency on Apache Thrift. Apache's git repo is now on GH, so the url for the dependency is out of date and won't build.

Can’t reproduce. Builds on my machine, and builds on CI.

https://github.com/mailru/easyjson might be an alternative. It works with code generation (and generates quite a lot of LOC), but it is fast!
Here's a benchmark:
❯ go test -run afdsasd -bench . -benchmem
goos: darwin
goarch: arm64
pkg: github.com/quic-go/quic-go/qlog
BenchmarkPacketHeaderGoJay-10       	 5663672	       203.7 ns/op	      80 B/op	       1 allocs/op
BenchmarkPacketHeaderEasyJSON-10    	15633277	        78.40 ns/op	     107 B/op	       0 allocs/op

Code:
var h = packetHeader{
	PacketType:   getPacketTypeFromEncryptionLevel(protocol.EncryptionHandshake),
	PacketNumber: 1337,
	Version:      protocol.Version1,
}

func BenchmarkPacketHeaderGoJay(b *testing.B) {
	buf := bytes.NewBuffer(make([]byte, 0, 1000))
	enc := gojay.NewEncoder(buf)
	for i := 0; i < b.N; i++ {
		if err := enc.Encode(h); err != nil {
			b.Fatal(err)
		}
		buf.Reset()
	}
}

func BenchmarkPacketHeaderEasyJSON(b *testing.B) {
	buf := buffer.Buffer{Buf: make([]byte, 0, 1000)}
	w := &jwriter.Writer{Buffer: buf}
	for i := 0; i < b.N; i++ {
		h.MarshalEasyJSON(w)
	}
}

One thing we'd need to figure out is how to rewrite custom marshaling logic such that the encoding output doesn't change. For example, we can't use "omitempty" for the ConnectionID type, as that's a struct. One option would be to use pointers, but that comes with a performance cost as well (which is probably way smaller than an additional alloc though).

One more option we could look into: https://github.com/bytedance/sonic


Allow custom TLDs in DNS

Describe the solution you'd like
While implementing Netbird for a client we have found that they use a custom TLD of the type .company for their internal domains. In the DNS section it only allows to add domains and we cannot add that TLD.
For this case we have modified directly in the sqlite the domain field to include only the custom TLD and everything has worked correctly.
It would be interesting to allow or have a space to add custom TLDs apart from the domains or to allow them as well as the domains.

@soymgomez this was a change made for the Nameserver configuration or for the peer domain?

This would be of use to us as well, could you provide a quick example on how you performed this change?

@michelangelo136 this was a change made for the Nameserver configuration or for the peer domain?

@soymgomez this was a change made for the Nameserver configuration or for the peer domain?

For "Match domains" in Nameservers configuration:

When editing the nameserver now it appears as invalid because the change was made directly in the database.

This would be of use to us as well, could you provide a quick example on how you performed this change?

We made the change directly in the database, in this case in the sqlite file:
sqlite3 /var/lib/docker/volumes/artifacts_netbird-mgmt/_data/store.db
sqlite> UPDATE name_server_groups SET `domains` = '["company"]';

@soymgomez, thanks. Have you tested the API?
@heisbrot, we can probably use a custom parser for the match domain input.

@soymgomez, thanks. Have you tested the API?

I hadn't tried it, I'll set up a test environment now and see if it will let me add it like this.


retry travis-ci commands which depend on remote resources

Fixes #144
Specifically, this is necessary given the seeming prevalance of
docker push failing for many people.

@salimane : can you please review this when you have a chance?

@erikdw LGTM 👍

@salimane : thanks!


[macOS] editor.autoClosingBrackets not working with "U.S. International - PC"

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:12:42.401Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.3.1

pgsql
dou
0.0.8

toggle-excluded-files
eam
1.6.0

prettier-vscode
esb
0.23.1

auto-close-tag
for
0.5.0

auto-rename-tag
for
0.0.14

(1 theme extensions excluded)

Steps to Reproduce:

Switch the keyboard layout to "U.S. International - PC" on the Mac. System Preferences > Keyboard > Input Sources > Add they layout and enable it (e.g. via US Flag in the task bar, next to the clock).
In Visual Studio Code, make sure the setting "editor.autoClosingBrackets" is set to true.
Try to use auto completion with single or double quotes => it's not working, only 1 character appears.
Switch the keyboard layout to "U.S.". Add again a double or single quote => VS Code auto-completes the input with a second character.

See also video: https://imgur.com/a/Wpm7w
Note:

The different color of the single quote for U.S. International. That's to create special chars, e.g. é or ë for double quotes. To just write the double or single quote character, hit space afterwards.
Braces always work.

Reproduces without extensions: Yes

This also was working and appears to be broken by our electron upgrade.

My mistake. This never worked, as for US intl we prevent the auto closing characters especially for the case of creating accented characters.

A related problem is that when I select a word and add quotes, it removes the word whereas I would expect the word to be wrapped with quotes

@nicgirault I agree, this seems to be a related bug as wrapping-selection-with-quotes works with standard US layout.

It's the same bug as https://github.com/Microsoft/vscode/issues/26820, isn't?
That one is tagged with "needs more info". Do you really need more information about the issue from us users?

What is the status on this PR?
This affects all users who use keyboards(languages) which uses accents

@lucasfeliciano The issue still exists in the current version (1.24.1). My workaround is to switch layouts with Control+Space. US for programming, US International for everything else.
This works, and is not really a problem once gotten used to it. A fix would of course still be nice.

+1

+1

+1

It's the same bug as #26820 and it was fixed, but the problem has changed and the comments ware blocked in the referred issue.

Something I'm used to doing in Windows and Ubuntu when using US International with Dead Keys is this sequence that works perfect:
quote key, space, (2 quotes will be inserted and cursor is positioned between them), write string, quote key, space, (no new quote is added; cursor is positioned after second original quote). result: 'test'| (| is position of cursor)
On OSX, using ABC input source (no dead keys) the behavior is exactly the same (without the spaces). With U.S. International - PC (dead keys) the behavior is this:
quote key, space, (2 quotes will be inserted and cursor is positioned between them), write string, quote key, space, (this time a new quote is added; cursor is positioned after this new quote and before the original second quote). result: 'text'|'
Hopefully this is clear.

This is especially annoying since, as someone else mentioned, you can set ABC and US International as input source options, but for some reason the default will always be ABC for every new window. It would need to be the other way around for it to be a good workaround.

There's actually an editor.autoClosingQuotes setting that I set to never and this works fine for me while using U.S. International - PC. This is a good workaround.

Actually, my solution sucks, because when you write the first quote the rest of your code is now a string until you close it. This really needs to be looked at!

another issue maybe related to autoClosingBrackets is #73828

Another horrible thing connected to the quote dead key: when I press the quote key + the. The left arrow, an invisible unicode control character is inserted. It took me hours to debug because I inserted such a character in a className string wich caused the class not matching and the css style not being applied.

this affect quotes in multicolumn selection too.

Apparently issue #73828 is fixed on:
Version: 1.38.0-insider
Commit: ada79d72be36ecbfed6f88bb16edcc5cc3f5c2a8
Will test more in the next days.

Indeed, this got fixed via 37981d8fd5d4ba1619f69dc8a0f4670543d39650

The easiest way to verify is to use the US Intl Keyboard layout on mac and press double quote / single quote +  to insert it...

@ccarstens This has been fixed and the fix has been shipped with VS Code 1.38. Please open a new issue with precise steps if this doesn't work for you as expected.


Publish build artifacts

We should be publishing our build artifacts (jars, etc) so people don't need to build locally and link against those.
We should do this for non demo libraries and applications. Libraries are good for those that want to build on top of the code we've written (e.g. new metadata crawler that emits MCEs; a separate GMS; etc). Applications are good for those that want to customize their deployments without needing to build source code.
From https://github.com/linkedin/datahub/issues/1743#issuecomment-673011663

Need to be careful about what got published has real value. Once it's published we'll need to support it forever.

There should be some kind of EoL process for these. Plus we're still not on 1.0 yet...

I understand the concerns around EoL process for it.
My justification for request to publish metadata-models jar is that the bindings and avsc files there define the input contracts(MetadataChangeEvent) for the datahub. These contracts can be used by any external service for programmatic extension, rather than relying on internal tools which are build locally.
Happy to discuss more.

@shakti-garg-saxo completely agree with the reason. We're in the process of decoupling dependency on models from codes so that the models jar can be loaded almost like a plugin. It may still take a bit more work but we're not too far from that ideal state.

So just to be clear on our plans and order of operations here:

We want to split out GMA in its own repository. We'll publish jars for this so DataHub can use them (anyone can, but point is we need to for DataHub :p ). This, for now, will include the DAOs, and maybe some testing utilities. Ideally in the future it would include the MCE/MAE jobs, but they are unfortunately coupled to the existing models.

Splitting this into a separate repository has some advantages. It helps make it a little more distinct from DataHub (you can use it without DataHub). It also helps us clarify its roadmap separately. GMA can probably hit 1.0 separately from DataHub.
Allows us to make some breaking changes without immediately needing to refactor DataHub. We don't want to make breaking changes often, but we'll probably have some set of breaking changes we want to get into 1.0.0. Breaking changes are going to be even more infrequent and carefully staged after 1.0.0.
Should be done before the end of September.

Look into publishing library jars in DataHub (models, builders, other utilities).
Look into publishing application jars in DataHub (frontend, gms, jobs).
Look into decoupling more things, i.e. jobs from models, maybe make GMSes actually microservices as we suggest, see if we can even decouple the frontend... these are long term things and probably shouldn't block us from publishing our jars, imo. These would either be new projects/jars or new major version bumps :p

SGTM

Great. It looks like a very good plan.
Thanks.

As an fyi, we moved the backend (GMA / Generalized Metadata Architecture) to its own repo, and it publishes artifacts to bintray.
https://github.com/linkedin/datahub-gma

Thanks John! Saw the changes in (https://github.com/linkedin/datahub/pull/1955).
Am i correct in understanding that datahub-gma will have separate release lifecycle than datahub?

Yes. Ideally we'll set up a continuous release for it soon, so ever push to master will publish a new version. But the versioning scheme will also be independent.

@jplaisted Hi John. I know we've gotten through the splitting of GMA out (bullet one). Is there a plan for the following work? That is, publishing jars for metadata models, builders, etc. as part of the release cycle?

I think this stalled a bit due to questions around model federation and the state of the DataHub repo. I'll let the community guide this discussion from here; should we publish artifacts today or wait for some potential larger refactor that may or may not happen?

We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.
We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!


提示The accountId entered is incorrect.

用的是账号id后面的数字

麻烦您发下报错的截图，帮您看下

麻烦您发下报错的截图，帮您看下

已经找到原因啦，是阿里云没开通函数计算导致的

@tanhe123 我也遇到这个问题，和楼主在同一个地方复制的 ID ，但是我很早就开通了函数计算的，上面还有函数在运行着的。
The accountId entered is incorrect. We speculate that you used the subuser uid, login name, login name prefix, display name or thers
please enter the correct accountId, which is the account ID under your primary account. You can reset your account ID by executing fun config
For the method of taking the primary account ID, please refer to https://account.console.aliyun.com/#/secure


Update Sample link

The original link redirects users to the new link.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@whoiskevinrich : Thanks for your contribution to the Azure documentation! The author, @sethmanheim, has been notified to review your proposed change.

@whoiskevinrich Thank you for the contribution! #sign-off