Middleware causes server.js to hang

Describe the bug
I have a custom server, and added the server.use(nextI18NextMiddleware(nextI18next)); middleware, as instructed. But this just causes the server to hang; apparently it never gets to server.listen.
Occurs in next-i18next version
1.2.1
Steps to reproduce
Here are the relevant portions of my server.js file:
const nextI18NextMiddleware = require("next-i18next/middleware").default;
const nextI18next = require("./utils/i18");

...
app.prepare().then(() => {
  const server = express();
  const { Sentry } = require("./utils/sentry")(app.buildId);

  server.use(Sentry.Handlers.requestHandler());
  server.use(cookieParser());
  server.use(sessionCookie);

  server.use(nextI18NextMiddleware(nextI18next));

  server.get(...

Expected behaviour
Expected the middleware to process normally.
OS (please complete the following information)

Device: MacBook Pro
Browser: N/A

Additional context
I'm using babel/register to transpile my server.js file, if that makes any difference.
I tried changing the position of the middleware in the file, but it made no difference.

Hi there. We have end to end tests which perform assertions against the example directory whilst it's running.
Therefore, by definition, the code you see in examples/simple is functional.
If you believe you've found a bug, you will need to provide an actual bug report.

@isaachinman, thanks for your response.
Most likely I am doing something wrong, or my setup is atypical in some way. I'm looking for some some guidance on how to troubleshoot this issue. Any advice would be greatly appreciated.
Thanks!

Best to post on StackOverflow or similar. Good luck!


Avatar and name missing for first messages on default workspace rooms created offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign into an account
Go offline
Create a workspace. If you don't have any workspaces, click the green plus, New workspace. Otherwise, open settings by clicking the avatar in the header, click on a workspace, click the 3 dots in the header, New workspace.
Close the settings
Click the search bar in the header
Type announce in the search bar
Click on the #announce room for the workspace you just created
Send a message

Expected Result:
A message appears with your avatar and name
Actual Result:
A message appears with only its text
Workaround:
Deal with it, or wait until another user sends a message
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.1.99-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/26260477/189765868-9ec96188-cf5f-4035-b5df-8f67186da35d.mov
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation:
View all open jobs on GitHub

I will be fixing this with the CreatePolicyRoom refactor. See this comment where I explain what is happening https://github.com/Expensify/Expensify/issues/215186#issuecomment-1244411032.


Add touch on-screen controller to be able to play demo on mobile

Describe the content you'd like
That would be nice to add one of existing on-screen controllers into the example to be able to play it on mobile.

It's a great idea! Furthermore, it'll be implemented soon, i.e. it will be based on the mobile controls of the FPS shooter.


tweak line wrappings in concepts/storage/

Tweaked long lines in 3 files, without any other text change:
content/en/docs/concepts/storage/volume-health-monitoring.md
content/en/docs/concepts/storage/volume-pvc-datasource.md
content/en/docs/concepts/storage/volume-snapshot-classes.md

/approve


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.211

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.211


Legacy arguments object pattern causing problem when code is compressed.

SerialPort Version: 5.0.0-beta8
NodeJS Version: 6.10.3
Operating System and Hardware Platform: Tessel 2

Summary of Problem
When t2-cli compresses JS code with uglify-es to bundle and deploy on Tessel 2, the code is compressed using the ecma: 6 compress option as well as the ecma: 6 output option. Thankfully, this results in very aggressive es6-centric compression, but unfortunately it also reveals "gotchas" of using es6 era features with legacy patterns. There is a problem pattern in lib/util.js, that when compressed, produces this:
(I've obviously run the code through jsbeautifier for readability)
"use strict";
module.exports = {
  promisify: o => {
    if ("function" != typeof o) throw Error('"func" must be a function');
    return () => new Promise((r, t) => {
      const e = Array.prototype.slice.apply(arguments);
      console.log(e[0]), e.push((o, e) => {
        if (o) return t(o);
        r(e)
      }), o.apply(null, e)
    })
  }
};

It may not be obvious at first, but the problem is that there is actually no arguments object in arrow functions:

But uglify-es isn't going to change your original arrow function in the Promise instantiation:
'use strict';

function promisify(func) {
  if (typeof func !== 'function') {
    throw new Error('"func" must be a function');
  }
  return function() {
    return new Promise((resolve, reject) => {
      const args = Array.prototype.slice.apply(arguments);
      args.push((err, data) => {
        if (err) {
          return reject(err);
        }
        resolve(data);
      });
      func.apply(null, args);
    });
  };
}

module.exports = {
  promisify
};

Because it's totally valid to access the arguments object of a function that an arrow function is nested inside of. The great news is that this requires only a minor change to fix! All that needs to be done is for the arguments object to move out of the nested arrow function and into the actual function from which it originated, then uglify-es will know to do the right thing and preserve that function's FunctionExpression syntax.
Patch to follow!

Sorry, I forgot to show the source change and corresponding compressed code:
'use strict';

function promisify(func) {
  if (typeof func !== 'function') {
    throw new Error('"func" must be a function');
  }
  return function() {
    const args = Array.from(arguments);
    return new Promise((resolve, reject) => {
      args.push((err, data) => {
        if (err) {
          return reject(err);
        }
        resolve(data);
      });
      func.apply(null, args);
    });
  };
}

module.exports = {
  promisify
};

Results in:
"use strict";
module.exports = {
  promisify: r => {
    if ("function" != typeof r) throw Error('"func" must be a function');
    return function() {
      const n = Array.from(arguments);
      return new Promise((t, o) => {
        n.push((r, n) => {
          if (r) return o(r);
          t(n)
        }), r.apply(null, n)
      })
    }
  }
};

Also, that's the only place in the code that this occurs

😆 🤣

Fixed!

Alright guys, time to packet in

Just curious (side note at best)... why does it produce this:
module.exports = {
  promisify: o => {
...

instead of:
module.exports = {
  promisify(o) {
...


Fixed allow_migrate() signature in documentation

Update tests/check_framework/test_multi_db.py:    def allow_migrate(self, db, app_label, model=None, **hints): too?

Thanks Tim for pointing that out. In fact there are more changes to it required.

Okay, I guess I'd backport at least the docs change to 1.8/1.9.

Merged in 228427ab1ab6aaafed4eacfb532f7ddb6cc1ed6c and 18afd50a2beae2e72cfc4841a6b80f253fe52a1b
and backported to 765f6d80414648e64c201f5e05bfd188326abc6a (1.9) and 3af5643d82735a2831a828609397af1a271a814a (1.8)


Add kornia

Wow! So fast!
Fyi they have a read webcam example that could be useful: https://github.com/kornia/kornia-rs/tree/main/examples/webcam

Wow! So fast!
Fyi they have a read webcam example that could be useful: https://github.com/kornia/kornia-rs/tree/main/examples/webcam

Thanks! I find Kornia really good looking

@Hennzau the latest published is 0.1.5 -- however, there's a massive refactor (as a highlight removing ndarray to leverage arrow::Buffer for tensor/image). The code is under the 0.1.6-rc2 tag to be stable and released by the end of the month. You can give it a try or just use the latest 0.1.5 and i can update myself later.

@Hennzau the latest published is 0.1.5 -- however, there's a massive refactor (as a highlight removing ndarray to leverage arrow::Buffer for tensor/image). The code is under the 0.1.6-rc2 tag to be stable and released by the end of the month. You can give it a try or just use the latest 0.1.5 and i can update myself later.

all right! I think i'll go for the release contest! Maybe I'll ask questions on discord in the coming days :)


Unable to switch perspectives when Crawl is held

1.21, haven't tested other versions
DOES switch perspectives if crawl is togglable

Not sure if i understood you correctly.
Switching perspectives while holding Crawl button works for me.
https://github.com/user-attachments/assets/e2d0ca9d-88be-4013-9dd1-28e43ff44086


error: unable to read module map contents from 'Target Support Files/SDWebImage/SDWebImage.modulemap': Error Domain=NSCocoaErrorDomain Code=260 "The file “SDWebImage.modulemap” couldn’t be opened because there is no such file."

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
e.g. ios

Platform Version
e.g. 10.0

SDWebImage Version
e.g. 3.7.6

Integration Method
e.g. cocoapods

Xcode Version
e.g. Xcode 8.3.3

Repro rate
e.g. all the time (100%) / sometimes x% / only once

Repro with our demo prj
e.g. does it happen with our demo project?

Demo project link
e.g. link to a demo project that highlights the issue

Issue Description and Steps
Hello I have a constant issue with this error. This error has a mind of it's own. It will either occur or not occur. As soon as I open and run/build the project determines if I come across the error.
I have done the following, to no success, in order to get rid of this error:
Delete/re-installed my cocoapods
Deleted the "Build" folder
I have done the following:
Open a terminal app
cd ~/Library/Developer/Xcode/DerivedData
rm -rf Build/* see below if you have a customized build location
rm -rf ModuleCache/*
Also done:
Clean Build Folder
Done everything I have been advised to do, yet cannot seem to fix this issue. I even went as far as creating a Target Support Files folder in the directory of where all my.swift/cocoatouch classes are however. I am still unsuccessful.
I have no more idea on what to do.
Could someone please help?
The only way in which I am combating this problem without fixing it is closing the project and reopening it, hoping for the error not to appear.
I think this also has an affect on my app, as it'll work fine for a few days then all of a sudden I'll open the app and it will constantly crash.
What could possibly be the issue?

This is a CocoaPods installation issue, you should look for similar issues in their own repo.

I'm having this issue while my teammate is creating a pod and my pod will be installing a using his pod.  If it is on the side of the person making the pod to be consumed by the other pod. What can that person do about this?


Token Refresh needed?

Line 34 of app.py configures the sqlalchemy connection string with a token from DefaultAzureCredential. Will this token refresh automatically (such as to re-connect to the database) once it expires? This seems to hardcode the token into the connection string. How should this be handled?

An engineer discussed that in this video:
https://learn.microsoft.com/en-us/events/cituscon-an-event-for-postgres-2023/azure-ad-authentication-with-postgresql-flexible-servers-citus-con-an-event-for-postgres-2023
He says that the token-based session will keep working as long as the session is alive, with no token refresh needed. Check timestamp 9:20.


Colorpicker Toway Binding doesn't work

Bug type
Component
Component name
MudColorPicker
What happened?
If an Initialvalue is present - the Colorpicker always shows the same Color
Expected behavior
Colorpicker should show the color with which it was initialized
Reproduction link
https://try.mudblazor.com/snippet/QuwPllwXnGKpEJhU
Reproduction steps

hit play
open the color picker -> the initial value is not shown

Relevant log output
No response
Version (bug)
5.1.5
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is not a bug, you using the wrong Parameter.
Here is a working example using the correct binding:
https://try.mudblazor.com/snippet/QYmbFlQXAuHiKGRC

To be more detailed about what your problem is:
The one you originally used is just for display in the input field:

But for the actual color picker value you should use:

API-Documentation:
https://mudblazor.com/api/colorpicker#properties


Feature create new Job

This will fix #67
For review only at the moment. Need to merge #73 first.
This adds a POST api /api/createjob/ to create a new Job.
Accepted Parameters
{
	"person_id": "93b524bf-b810-487f-ac11-9440fa26f002",
	"title": "We are looking for an iOS Developer",
	"description": "Test ... test",
	"city": "Singapore"
}

Sample SUCCESS response:
{
    "id": "bd275c3f-c6c0-425a-b622-d3ee9f0799d5",
    "title": "We are looking for an iOS Developer",
    "description": "Test ... test",
    "city": "Singapore",
    "created_at": "2020-05-08T13:04:11.814698Z",
    "created_by": {
        "id": "93b524bf-b810-487f-ac11-9440fa26f002",
        "first_name": "Subhransu",
        "last_name": "Behera",
        "avatar_url": "https://avatars0.githubusercontent.com/u/1495621",
        "job_title": "Software Engineer",
        "company": "SPDigital",
        "profiles": {
            "linkedin": "https://sg.linkedin.com/in/subhransubehera"
        },
        "hunting_mode": "Active"
    }
}

@kajalsinha this is good to be reviewed now.


plan: return types in lowercase in SHOW CREATE TABLE

Fixes https://github.com/src-d/gitbase/issues/962
It solves a compatibility issue with SQLAlchemy, as it did not return
the types the same way MySQL does.

Seems like nodejs integration tests are failing.

Ignoring node integration tests for now and merging.


train speaker id info

What role does the speaker play on train or model interence ? how can i get speak info

Now RVC only supports one model one speaker. May extend later.

Now only supports one speaker.
Use "speaker id" to change it.


Wiki: Now include complete API documentation for v2.6.0

Wiki have been updated to:

Include API documentation for Version 2.6.0
Help page for Mutually Exclusive Options with online demo.

The indentations are all messed up though...
https://github.com/commandlineparser/commandline/wiki/Getting-Started:

https://github.com/commandlineparser/commandline/wiki/Mutually-Exclusive-Options:

https://github.com/commandlineparser/commandline/wiki/How-To:

Seems like we can't edit and submit PRs for wiki though... If not I can help.

Thanks @garyng  for reviewing wiki and your suggestions.
The indentations are done.


Create Docker-compose

Environment

Python version: Several
Nautobot version: 1.0.0b2

Proposed Functionality
Provide a docker-compose deployment for installing the necessary components of Nautobot, and that can be run on a single node environment for production purposes.

Use Case
Docker-compose to stand up Nautobot

Database Changes
None

External Dependencies
Docker

Assign to myself (@jvanderaa)

Blocked by #195

Closed with the release https://github.com/nautobot/nautobot-docker-compose


Refactor app tests so they log out progress

What this PR does

Refactors the app test so that it can log out the progress as it waits for the eventual desired state.

I removed the custom report formatter as the log output should give the same level of information but without waiting for it to fail. I also haven't seen these formatters used for any other tests so seemed a bit odd just having them in place for this one. If you feel its still worth having it included let me know and I'll be happy to add it back.
Checklist

[x] Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites

Just force-pushed a slight update to how the log output is done.
/run cluster-test-suites


Added endpoint for updating a resource

Added code for a new endpoint that is designed to update a resource based on the id passed in and any optional JSON form data parameters given in a PUT request. Uses helper function to update resource with parameters from the request. Closes #34.

@aaron-suarez In my latest commit, in which I addressed the concerns of your review, the build seems to be failing due to some "invalid syntax" error that seems to be on a line of the code that does not exist. Do you know why this error may be coming up? Please let me know.

Have you tried from app import db?

Thanks for the advice! Everything seems to be working now, with the build passing. Feel free to let me know if I should make any more changes to routes.py or any other files.

I think that unlike JavaScript, Python objects must use dot syntax for attributes
resource = Resource()

# this works
resource.name = "name"

# this doesn't work
resource['name'] = "name"

I think that you're going to have to rethink how you're looping through the array of param names. Probably easier to just list them out and assign them one by one rather than in a for loop. Maybe there's a way to do it using your loop, but I'm not sure.

I actually did not try it out, since I do not have the proper testing environment set up to do so and assumed that I could use the code in cli.py as a guide. Should I just forget about using default values for the resource parameters and just use request.args? Or should I switch from using dict notation (i.e. resource['category']) to dot notation (i.e. resource.category) to assign resource parameters?

We used dot notation in cli.py, so I believe that would work.
Also, yeah, I was kind of confused from the beginning why you would need any defaults for updating a resource. For creating a resource, you'll need default values for that stuff (but I think the model actually creates some of those defaults for you. e.g., paid defaults to False).
But for updating a resource, you really just want to have nothing change except for the specific value(s) passed in by the user.
For example, if someone is updating the notes, you don't want languages to be reset to an empty list, do you? In that situation, the notes is the only thing that should change, nothing else should.

Thanks for sharing your thoughts! Going off of your concerns, I have completely refactored the code used to implement the updating of resources. Please let me know if other changes should be made.

@michizhou After running it and playing with it, I realized that I led you in the wrong direction before. Sorry about that.
request.args is for query parameters that are sent as part of the query string. I didn't intend for it to be query params, I intended for it to be JSON form data. In order to get at the JSON, you need to use the method request.get_json().
return set_resource(id, request.get_json(), db)

And then to actually set them
def set_resource(id, json, db):
...

            if json.get('name'):
                resource.name = json.get('name')
            if json.get('url'):
                resource.url = json.get('url')
            if json.get('paid'):
                resource.paid = json.get('paid')
            if json.get('notes'):
                resource.notes = json.get('notes')

The category and languages are a bit trickier because they require you to get the Category and Languages if they exist and to create new ones if they do not exist. If you need help with the particular syntax for that (since you can't try it out yourself) I can do that tomorrow. I need to get going for the night.
If you're itching to get this merged, we can go ahead and just support updating the name, url, paid, and notes for now and open up a separate issue for updating the category and languages. This has been a bit of a long process, and I don't want to delay it any longer than we have to, I want to get your changes in.

@michizhou No worries! Mistakes like this happen. In any case, I am willing to wait until tomorrow so that you can help me with the syntax for updating category and languages. However, I also would like to get my changes merged, so if updating category and languages will take considerable time (i.e. at least half a day), I'd suggest opening a separate issue for updating those two fields.

@aaron-suarez I just pushed some changes I made to have JSON form data passed into set_resource in place of the query parameters mistakenly used before. I would appreciate it if you could help with the syntax for updating category and languages if you are available now.

@aaron-suarez That sounds great! I just added the lines for passing in category and languages to the scripts set_resource method. Also, do you happen to know why the build is failing now? I think it might have something to do with using request.get_json() or something.

Ugh... Ok, so this works when creating a new language or category, but it fails when trying to change it to an existing language or category. We need to pull in existing languages/categories from the DB to get those objects and only create a new one if it doesn't already exist. Code sample incoming

    try:
        resource = Resource.query.get(id)
        languages_list = Language.query.all()
        categories_list = Category.query.all()

        language_dict = {l.key(): l for l in languages_list}
        category_dict = {c.key(): c for c in categories_list}

    except MultipleResultsFound as e:
        print_tb(e.__traceback__)
        print(e)

    except NoResultFound as e:
        print_tb(e.__traceback__)
        print(e)

    finally:
        if resource:
            if json.get('languages'):
                langs = []
                for lang in json.get('languages') or []:
                    language = language_dict.get(lang)
                    if not language:
                        language = Language(name=lang)
                    langs.append(language)
                resource.languages = langs
            if json.get('category'):
                resource.category = category_dict.get(json.get('category'), Category(name=json.get('category')))
            if json.get('name'):
                resource.name = json.get('name')
            if json.get('url'):
                resource.url = json.get('url')
            if json.get('paid'):
                resource.paid = json.get('paid')
            if json.get('notes'):
                resource.notes = json.get('notes')

We eventually need to do some error checking, this kind of just fails silently right now. But we'll handle that in a different PR. For now, this works, and that's good enough for me

How is the fix for the dependency management issue coming along? Is it close to b in merged with this PR?

I was trying to get the code working for this PR, now I'm working on reviewing #47. I have to go to dinner shortly, so I might be able to merge that in first, but I want to make sure it works properly before I just merge it in. If not tonight, it will be tomorrow morning

@aaron-suarez I just managed to incorporate the modified implementation for updating category and languages in a resource. Besides the dependency management issue, is this PR ready to merge?

@michizhou #51 fixes the travis failure. Please rebase to master.

Thanks for all your work on this, @michizhou!


Span details fixes

Description
I got an error when visiting span details when a span has multiple events at the same time. Also, the span and details headers on links and backlinks sections were disabled.
This PR:

Adds internal id to span events and uses it as the item key in the UI
Uses normal headers for span and details headers

After:

Checklist

Is this feature complete?

[x] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[x] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[x] No

Microsoft Reviewers: Open in CodeFlow

/azp run


Remove hardcoded container registry

Container registry for images should be defined in installations,
either by defaulting or with an override per installation.

Closing this. I'm not sure if the change could be merged, but I know it doesn't matter anymore once the configuration is moved to config.


Remove all links to the SimAuto functions page

PowerWorld is going to remove the page that lists all the SimAuto functions, so we should stop linking to it. Here's the link:
https://www.powerworld.com/WebHelp/#MainDocumentation_HTML/Simulator_Automation_Server_Functions.htm%3FTocPath%3DAutomation%2520Server%2520Add-On%2520(SimAuto)|Automation%2520Server%2520Functions|_____3

I could only find one occurrence. Closing.


[Feature Request] Home Manager support

It would be nice if this could also export a HM module to pull the config and switch to it.

Yes, i think it could be a good idea.
We however have to ensure this would not add too much complexity to comin...
I think we should consider adding configuration to allow comin running a Home Manager switch to configuration instead of NixOS switch to configuration. This implies a comin instance would not be able to support both NixOS and Home manager simultaneously.
We should however hit some issues with the model since a Generation is currently, for instance, getting the machine-id during the evaluation phase. This part should not be executed for a Home Manager deployment.
It would be nice to have an idea of the comin NixOS module interface also, because we would have to modify it i think.

I'm not super familiar with the activation process on NixOS, I just read a little bit the comin codebase and I saw that you use some nixos-rebuild internal script called switch-to-configuration instead of just using the nixos-rebuild switch command. What's the difference between that and call the generation activate script?
Home Manager on the other hand seems to just do a nix build followed by a $generation/activate.

I saw that you use some nixos-rebuild internal script called switch-to-configuration instead of just using the nixos-rebuild switch command.

I think nixos-rebuild is basically a wrapper around nix build and the switch-to-configuration script.
The NixOS deployment and Home Manager deployment should be pretty similar:

building a flake attribute to generate an activation script
running this activation script

However, regarding NixOS, comin is switching but it also does some other small tasks such as:

comparing some machine id to ensure the deployment is expected
restarting comin if required
rebooting if required (not implemented yet but planned)

I think these tasks should not be executed if the Home Manager context.
How would you plan to run comin to support deploy Home Manager?

As user or root?
As a Home Manager module?

How would you plan to run comin to support deploy Home Manager?

As user or root?
As a Home Manager module?

Ideally the Nix interface should be mostly the same, meaning it should be a HM module that you call a as a service that creates a systemctl --user service with your comin bin. That should run as a user. And this is important as most HM rely on not necessarily having root access.

However, regarding NixOS, comin is switching but it also does some other small tasks such as:

comparing some machine id to ensure the deployment is expected
restarting comin if required
rebooting if required (not implemented yet but planned)

I think these tasks should not be executed if the Home Manager context.

Maybe there is a case (env vars) that may need a re-login tho.


8k sample rate model

Can we reduce the sample rate to 8k to get a smaller model, and how to modify the code?

I've tried to do this before and wasn't successful. There seems to be some lower limit in the VITS model related to the "segment size".


flavors: Introduce Virtualmachineflavorspec

What this PR does / why we need it:
This change introduces a new shared spec type for the VirtualMachineFlavor CRDs. This drastically simplifies the code required to find and apply these CRDs to a given VM.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A
Special notes for your reviewer:
As this API is still in alpha I'm not including a releasenote or docs. Further changes on top of this will however do so when things have stabilised.
Release note:

NONE

/retest

/retest

/cc @akrejcir

/hold actually I'm going to rework this some more, it seems the recent rebase has made this more messy than it should be.

/unhold okay I've cleaned this up, hopefully more acceptable now. I'll rebase the complete series on this once I get some positive reviews.

/retest
/hold cancel

/retest

/lgtm

/lgtm

/lgtm

/retest

/retest

Looks great!
/approve

/retest

/retest

/retest

/retest

/retest

/hold until the sig-{network,preformance} jobs are fixed

/hold until the sig-{network,preformance} jobs are fixed

https://github.com/kubevirt/project-infra/pull/2059 might help here, the sig-network issue looks intermittent.

/hold cancel
/retest

/retest

sig-performance is now hitting https://github.com/kubevirt/kubevirt/issues/7658 FWIW.

/retest

/retest

/retest


Client config to play nice with Context Router

Summary
Tried the new client config v2 with a multi context setup, and I'd like to put key field in client config, as the UI is much nicer than the standard MODX context one.
Steps to reproduce
Add in site_url, http_host, base_url and site_start into client config from a current working multi context setup.
Observed behavior
Nothing works :(
Expected behavior
Everything should work!
Environment
ClientConfig V2 pre-release, MODX 2.5.7

Ah, that's what you're trying to do!
There's one rather tricky problem with putting the actual context configuration into ClientConfig, which is that CC needs to know what context is loaded for it to apply its settings. While they're called context settings, they aren't really context settings, it just fetches the right values when MODX is being initiated.
Or put another way. ContextRouter needs to run before ClientConfig can apply its settings.
Might need some out-of-the-box thinking to address this one...

Ah, I did wonder about that, I tried changing the plugin firing order for the event between the two, and it didnt' work either :(

Would this be the same for XRouting? I can't get the multi context settings to work!

Yes, the same problem would apply to XRouting.
It's a chicken and egg problem. ClientConfig bases its context-specific "settings" on the current context. Those "settings" are then dynamically loaded in a way that it overrides what's configured elsewhere.
XRouting, ContextRouter etc, look at actual context settings (note: ClientConfig does not store its values as actual context settings, it uses its own tables) to determine what context to set. So context routing plugins need to run before ClientConfig for ClientConfig to set the right values, thus ClientConfig values can't be used for context routing.

Short of rewriting ClientConfig to update actual context and system settings, instead of its own tables and dynamically overriding the MODX stuff, I'm not sure how this would be solvable.

No problems @Mark-H.
Perhaps a snippet might work to retrieve CB settings in environments that use XRouting/ContentRouter ?

xRouting/ContextRouter/whatever router just need to be updated to run sooner. #140

Related to the opening request (adding site_url and such into ClientConfig) - that's going to be near impossible to solve. Also I don't think such settings should be editable by clients - but that's a different discussion.
For any other custom (non-routing related) context settings, it's easy to fix. Depending on the router, either adjust their plugin to use OnMODXInit, or adjust the ClientConfig plugin to use OnHandleRequest. https://github.com/modmore/ClientConfig/issues/140#issuecomment-367294057

Closing as CC will now run on both OnHandleRequest and OnMODXInit events, which should resolve any issues with a router running after CC.

This fixed it for me as far as any other settings. But I keep the xrouting settings in context settings.
https://docs.modx.com/current/en/building-sites/contexts/gateway-plugin


Bug (?) report.

... Videos>youtube-dl https://www.youtube.com/watch?v=gGHUAOuL2YY  --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=gGHUAOuL2YY', '--verbose']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.8.3 (CPython) - Windows-10-10.0.22621-SP0
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] gGHUAOuL2YY: Downloading webpage
[youtube] gGHUAOuL2YY: Downloading MPD manifest
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "d:\programs\python38\lib\site-packages\youtube_dl\YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "d:\programs\python38\lib\site-packages\youtube_dl\YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "d:\programs\python38\lib\site-packages\youtube_dl\extractor\common.py", line 534, in extract
ie_result = self._real_extract(url)
File "d:\programs\python38\lib\site-packages\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
File "d:\programs\python38\lib\site-packages\youtube_dl\extractor\common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

2021.12.17 seems quite old - let me try upgrading.

...


Migration from Ubuntu 17.04 / Django 1.11 to Ubuntu 20.04 / Django 3.1

Hello,
Thanks for providing this wonderful package.
This pull request contains the modification I had to make to upgrade my server from Ubuntu 17.04 / Django 1.11 to Ubuntu 20.04 / Django 3.1.
These changes are not backwards compatible, so they probably can't be incorporated into master, but maybe they can still be useful.
Also, I would be willing to test for different versions of Django. Do you have automated tests or something similar available?
Regards,
René

Can you limit your pull to the rel_to and smart_str stuff.  I've made most of these changes except the rel_to.  Thats new to me.

Sure, but I have no idea how... Any suggestions?

Sure, but I have no idea how... Any suggestions?


【建议】第三方账号信息应该冲User表中拆除，不利于后期扩展

The associated plug-in information should be split into a new table as the account table
https://github.com/casdoor/casdoor/blob/865a65d399a88ef0423dc6305e6911533abc8b43/object/user.go#L74
If the product goes in the direction of OAuth, more and more OAuth plug-ins will be accumulated, and the single table is certainly not applicable.

@hanrea plz change to English

@hanrea plz change to English

Translation complete!TKS!

@hanrea multiple tables are too complicated. Single table is enough to use for now. Won't fix.


Use static linking when compiling for ARM

When cross-compiling VSCode for ARM, the sqlite binding fails with relocation R_ARM_THM_MOVW_ABS_NC against '_LIB_VERSION' can not be used when making a shared object.
Code that uses this instruction must be compiled as a static library/archive. This PR updates the gyp config to do that when targeting ARM architectures.
The same addition was previously necessary in Atom's keytar bindings around a year ago:
https://github.com/atom/node-keytar/blob/master/binding.gyp#L51

Also, let me know if you'd like me to submit this upstream, or if you're planning on doing that (or if you're planning on this fork diverging)

@stevedesmond-ca sounds good, but can we keep changes that diverge in the vscode branch? Also your change seems to contain some whitespace changes.

Closing in favor of #5


No way to disable drawer in an activity if I put this code in my BaseActivity

I put the drawer in my Base Activity and I only want to enable it in certain activities. Can we make this possible?

If you use DrawerFrameLayout as root view you can then lock the drawer with this code:
mDrawerLayout.setDrawerLockMode(DrawerLayout.LOCK_MODE_LOCKED_CLOSED);

See this stackoverflow question for more information:  http://stackoverflow.com/q/17051104


Fix flaky tests

Describe your changes
test_on_demand_download is flaky because not waiting until created image layer is transferred to S3.
test_tenants_with_remote_storage just leaves garbage at the end of overwritten file.
Right solution for test_on_demand_download is to add some API call to wait completion of synchronization with S3 (not just based on last record LSN). But right now it is solved using sleep.
Issue ticket number and link
#3209
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Approval doesn't reset unless I request changes, see my earlier question about what is fixed by the sleep.

Done.
Is it ok now?


Inference VRAM requirements?

Could you share requirements for inference in terms of VRAM?

For fp16 24GB for fp32 34GB would be sufficient.

Interesting! Do you think there is room for optimization in order to bring that number further down below?
Anyway, keep up with your great work!


chore(master): release 2.8.1

:robot: I have created a release beep boop
2.8.1 (2024-12-10)
Dependencies

deps: update ansible/ansible-lint action to v24.12.0 (#69) (b5fd420)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.8.1
:sunflower:


Download certs from security repo

Description
Download certs from security repo instead of having a local copy in this repo.
Testing out this same pattern that the sql plugin uses to reduce copies of the demo certs across plugin repos.
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

It doesn't look like the CI check is working as expected:

1s
0s
Run plugin=opensearch-asynchronous-search-<IP_ADDRESS>-SNAPSHOT.zip
plugin version plugin_version qualifier docker_version
(opensearch-asynchronous-search-<IP_ADDRESS>-SNAPSHOT.zip) (search) (search) (-3) (search-3)
/home/runner/work/asynchronous-search/asynchronous-search
-rw-r--r-- 1 runner docker 986033 Nov  4 19:53 ./opensearch-asynchronous-search-<IP_ADDRESS>-SNAPSHOT.zip
Error response from daemon: manifest for opensearchstaging/opensearch:search-3 not found: manifest unknown: manifest unknown

https://github.com/opensearch-project/asynchronous-search/actions/runs/11671545303/job/32498455303?pr=650

@finnegancarroll @mch2 This is ready for review.


Unicode BOM is not discarded by Utf8Codec.decode()

Please see https://api.dartlang.org/stable/1.22.0/dart-convert/Utf8Codec/decode.html

String decode(
List codeUnits, {
bool allowMalformed
})
Decodes the UTF-8 codeUnits (a list of unsigned 8-bit integers) to the corresponding string.
If the codeUnits start with a leading UNICODE_BOM_CHARACTER_RUNE this character is discarded.

In fact, if the codeUnits start with a leading UNICODE_BOM_CHARACTER_RUNE it is not discarded
  Utf8Codec codec = new Utf8Codec();
  List<int> toDecode = codec.encode("1 Some string");
  toDecode[0] = UNICODE_BOM_CHARACTER_RUNE;
  print(codec.decode(toDecode, allowMalformed: true)); // � Some string
  codec.decode(toDecode, allowMalformed: false); // FormatException: Bad UTF-8 encoding 0xff (at offset 0)

In both cases above BOM is not discarded

I updated (or will update) the description (https://codereview.chromium.org/2707893002/)
The UNICODE_BOM_CHARACTER_RUNE is a rune, and thus not encoded as utf8. In fact, its value is 0xFEFF. Encoded, this rune is represented as [239, 187, 191]. If you add these three bytes in front of a UTF8 string, then they will be discarded.
To make your example work you would need to change it as follows:
import 'dart:convert';

main() {
  Utf8Codec codec = new Utf8Codec();
  List<int> toDecode = codec.encode("1 Some string").toList();
  toDecode.insertAll(0, codec.encode(new String.fromCharCodes([UNICODE_BOM_CHARACTER_RUNE])));
  print(codec.decode(toDecode, allowMalformed: false));
  codec.decode(toDecode, allowMalformed: false); // FormatException: Bad UTF-8 encoding 0xff (at offset 0)
}

Note that you don't need to specify the allowMalformed anymore, since a BOM character isn't malformed.

@floitschG  you've updated Utf8Decoder.convert() documentation. Please, update Utf8Codec.decode() as well

Done. and thanks.


kiali blocked by netpol?

Describe the bug: (a clear and concise description of what the bug is)
output from kiali pod:
ERR Error fetching initial namespaces for populating the Kiali Cache. Details: Get "https://<IP_ADDRESS>:443/api/v1/namespaces": dial tcp <IP_ADDRESS>:443: connect: connection refused

I do not think that it is caused by network policies, as they do only restrict traffic to team namespaces.
If that was Azure with SLA then kube-api could be unavailable for movement thus connection refused.

alright...closing

Strange that this consistently plays up though. Every time the kiali pod starts this is now happening.


Getting Error during installation

Hello Team
I keep getting an error whenever I've copied and pasted the installation

Hello! It is not yet functional for Windows. It will be, but there is an extra effort that I need to make. But no worries, it will be soon enough.

I am also facing an issue during installation, and I try on linux. Any usggestions? I tried to install manually some modules, some applications more precisely, but with no luck.

Hi there, thanks for mentioning. From the error, it looks like GOPATH is not exported as environment variable. Could you please add that and see if this fixed the problem?


Virtualization

I fear it will be a somewhat common scenario
On Jan 27, 2021, 15:19 -0300, Todd Burnside<EMAIL_ADDRESS>wrote:

@toddburnside commented on this pull request.
In facade/src/main/scala/reactST/reactTable/TableMaker.scala:

@@ -316,14 +436,38 @@ object TableMaker {
val ascDesc = if (col.isSortedDesc.getOrElse(false)) "\u2191" else "\u2193"
<.span(s" $index$ascDesc")
} else TagMod.empty

 <.th(props2Attrs(col.getHeaderProps()),

      props2Attrs(col.getSortByToggleProps()),

      cellClass,

      col.render("Header"),

      <.span(sortIndicator(col))

 val headerProps = col.getHeaderProps()

 val toggleProps = col.getSortByToggleProps()

 // If both props have a "styles", only the last one gets used. Apparently, scalajs.react doesn't

 // merge them. So, we have to combine them manually.

 val styles = if (headerProps.hasOwnProperty("style") && toggleProps.hasOwnProperty("style")) {

That's a good idea, but I'm not sure we could make it lawful in the case of duplicate keys.
In any case, I should probably move this to a helper function of some sort.
In facade/src/main/scala/reactST/reactTable/TableMaker.scala:

Virtualized tables are not built from html table elements such as

, , etc. The virtualization requires they be made from

 elements and styled as a table. This method adds a class to

each div that corresponds to it's role, such as "table", "thead",

"tr", etc.

This means that headerCellFn must also return a  instead

of a , and should probably also have a class of "td". The basic

header functions in TableMaker take a boolean flag to handle this.

The rowIdfn is applied to both the the table options and the react-window

virtualization. So, you don't need to apply it to the options beforehand.

*/
def makeVirtualizedTable(
options:           TableOptsD,
data:              js.Array[D],
rowIdFn:           D => String,
rowHeight:         Double,
You can use a function (index: number) => number if you use a VariableSizeList from ReactWindow instead of a FixedSizeList which is what we use here.
The two options I see to support this are:

always use VariableSizeList and just have a function that ignores the index for tables where the height is always the same.
have a separate method for creating tables with variably sized rows.
I don't know if there are performance issues with the variable sizes, but I wouldn't think so. It seems like it would just be a function call per row. If we think this will be a common scenario, we should probably go with option 1 for simplicity of use.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

I fear it will be a somewhat common scenario
On Jan 27, 2021, 15:19 -0300, Todd Burnside<EMAIL_ADDRESS>wrote:

@toddburnside commented on this pull request.
In facade/src/main/scala/reactST/reactTable/TableMaker.scala:

@@ -316,14 +436,38 @@ object TableMaker {
val ascDesc = if (col.isSortedDesc.getOrElse(false)) "\u2191" else "\u2193"
<.span(s" $index$ascDesc")
} else TagMod.empty

 <.th(props2Attrs(col.getHeaderProps()),

      props2Attrs(col.getSortByToggleProps()),

      cellClass,

      col.render("Header"),

      <.span(sortIndicator(col))

 val headerProps = col.getHeaderProps()

 val toggleProps = col.getSortByToggleProps()

 // If both props have a "styles", only the last one gets used. Apparently, scalajs.react doesn't

 // merge them. So, we have to combine them manually.

 val styles = if (headerProps.hasOwnProperty("style") && toggleProps.hasOwnProperty("style")) {

That's a good idea, but I'm not sure we could make it lawful in the case of duplicate keys.
In any case, I should probably move this to a helper function of some sort.
In facade/src/main/scala/reactST/reactTable/TableMaker.scala:

Virtualized tables are not built from html table elements such as

, , etc. The virtualization requires they be made from

 elements and styled as a table. This method adds a class to

each div that corresponds to it's role, such as "table", "thead",

"tr", etc.

This means that headerCellFn must also return a  instead

of a , and should probably also have a class of "td". The basic

header functions in TableMaker take a boolean flag to handle this.

The rowIdfn is applied to both the the table options and the react-window

virtualization. So, you don't need to apply it to the options beforehand.

*/
def makeVirtualizedTable(
options:           TableOptsD,
data:              js.Array[D],
rowIdFn:           D => String,
rowHeight:         Double,
You can use a function (index: number) => number if you use a VariableSizeList from ReactWindow instead of a FixedSizeList which is what we use here.
The two options I see to support this are:

always use VariableSizeList and just have a function that ignores the index for tables where the height is always the same.
have a separate method for creating tables with variably sized rows.
I don't know if there are performance issues with the variable sizes, but I wouldn't think so. It seems like it would just be a function call per row. If we think this will be a common scenario, we should probably go with option 1 for simplicity of use.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

This seems to be in response to the variable height rows. So, I'll update react-window to make VariableSizeList easier to use, then update makeVirtualizedTable() to use the VariableSizeList.

I fear it will be a somewhat common scenario

This seems to be in response to the variable height rows. So, I'll update react-window to make VariableSizeList easier to use, then update makeVirtualizedTable() to use the VariableSizeList.

I fear it will be a somewhat common scenario

This seems to be in response to the variable height rows. So, I'll update react-window to make VariableSizeList easier to use, then update makeVirtualizedTable() to use the VariableSizeList.

I fear it will be a somewhat common scenario

The VariableSizeLIst in react-table was not suitable for our purposes. So, I switched to react-virtuoso, which dynamically sizes the elements.


Wrong set of reviewers getting assigned to a PR

Sample PR: https://github.com/RedHatQE/cnv-tests/pull/1029
Owners file: https://github.com/RedHatQE/cnv-tests/blob/main/OWNERS

Another one https://github.com/RedHatQE/cnv-tests/pull/1133

@dbasunag
Is this issue still valid?

closing since no response from the reposter.


Fix BF Arguments Optional Links

Swapped out link to Function Objects for link to Closures
Closes #3606

Is this change approved by the @FreeCodeCamp/owners?

LGTM


pyinfer issue in bare metal compilation

After following the instruction and compiled the code, the onnx version works fine, but the pyinfer gives issue as it says "no frames to decode" at the beginning of the session

I had the same issue, while I was not able to make the cmdInfer run using the Python file, you can go to cmdinfer.cc and implement whatever you needed to implement in the Python file there. If your use case does not particularly require some functionality explicitly from Python, this should help (and I imagine this might be more performant as well).


[enhancement] Add missing bower.json.

Hey, maintainer(s) of viadeo/tetra-ui!
We at VersionEye are working hard to keep up the quality of the bower's registry.
We just finished our initial analysis of the quality of the Bower.io registry:
7530 - registered packages, 224 of them doesnt exists anymore;
We analysed 7306  existing packages and  1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).
Sadly, your library viadeo/tetra-ui is one of them.
Can you spare 15 minutes to help us to make Bower better?
Just add a new file bower.json and  change attributes.
{
  "name": "viadeo/tetra-ui",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.
NB! Please validate your bower.json with jsonlint before commiting your updates.
Thank you!
Timo,
twitter: @versioneye
email<EMAIL_ADDRESS>VersionEye - no more legacy software!

We will handle it soon.
Sorry for the long delay of the response.


Preserve order in BigQuery JSON

See #2342. Can be done using json.loads(..., object_pairs_hook=OrderedDict) h/t to @c0b

It's unclear if any methods "need" this behavior.
It's nice that we don't support Python 2.6 any more because collections.OrderedDict was introduced in 2.7
If this "feature" is actually worth it, we should determine which subset of payloads need this behavior

Here are all the call sites where JSON is parsed from a string to a Python dictionary:
$ git grep -n 'json.loads(' -- google/cloud/bigquery/
google/cloud/bigquery/table.py:961:        return client.job_from_resource(json.loads(response_content))
$
$ git grep -n 'api_request' -- google/cloud/bigquery/
google/cloud/bigquery/client.py:105:        resp = self.connection.api_request(method='GET', path=path,
google/cloud/bigquery/client.py:148:        resp = self.connection.api_request(method='GET', path=path,
google/cloud/bigquery/client.py:239:        resp = self.connection.api_request(method='GET', path=path,
google/cloud/bigquery/dataset.py:424:        api_response = client.connection.api_request(
google/cloud/bigquery/dataset.py:445:            client.connection.api_request(method='GET', path=self.path,
google/cloud/bigquery/dataset.py:465:        api_response = client.connection.api_request(
google/cloud/bigquery/dataset.py:504:        api_response = client.connection.api_request(
google/cloud/bigquery/dataset.py:520:        api_response = client.connection.api_request(
google/cloud/bigquery/dataset.py:536:        client.connection.api_request(method='DELETE', path=self.path)
google/cloud/bigquery/dataset.py:569:        resp = connection.api_request(method='GET', path=path,
google/cloud/bigquery/job.py:318:        api_response = client.connection.api_request(
google/cloud/bigquery/job.py:339:            client.connection.api_request(method='GET', path=self.path,
google/cloud/bigquery/job.py:359:        api_response = client.connection.api_request(
google/cloud/bigquery/job.py:376:        api_response = client.connection.api_request(
google/cloud/bigquery/query.py:335:        api_response = client.connection.api_request(
google/cloud/bigquery/query.py:392:        response = client.connection.api_request(method='GET',
google/cloud/bigquery/table.py:28:from google.cloud.streaming.http_wrapper import make_api_request
google/cloud/bigquery/table.py:490:        api_response = client.connection.api_request(
google/cloud/bigquery/table.py:511:            client.connection.api_request(method='GET', path=self.path,
google/cloud/bigquery/table.py:531:        api_response = client.connection.api_request(
google/cloud/bigquery/table.py:605:        api_response = client.connection.api_request(
google/cloud/bigquery/table.py:621:        api_response = client.connection.api_request(
google/cloud/bigquery/table.py:637:        client.connection.api_request(method='DELETE', path=self.path)
google/cloud/bigquery/table.py:681:        response = client.connection.api_request(method='GET',
google/cloud/bigquery/table.py:767:        response = client.connection.api_request(
google/cloud/bigquery/table.py:955:            http_response = make_api_request(connection.http, request,
$
$ # current hash
$ git log -1 --pretty=%H
d3e28ce8ae5bee1a637a11d11227d294cfa8302c

https://github.com/GoogleCloudPlatform/google-cloud-python/issues/2342#issuecomment-248163435
please fix your internal bq tool in the google cloud SDK. or I would say anyone here want that prettyjson format would like the keys in preserved order

The maintainers of this repo don't have any pull with the maintainers of gcloud SDK (I don't even know who they are). So we can't get them fixed there.
Is it OK if we close this out @c0b? You can file an issue with them at https://code.google.com/p/google-cloud-sdk/issues/list

or I would say anyone here want that prettyjson format would like the keys in preserved order

users of this library would like to see a preserved keys order option; this is still a valid enhancement request

Which users?

users of this library

What I mean to say is that we haven't heard the request from anyone but you and from your previous comments it doesn't seem like you use this library?

I am a potential one, if the library is made really good to use; right now #2354 is a blocker to me, because I have been using Standard SQL nested fields a lot; that is a must fix; but this one is a feature nice to have:
can I request API design like this?
>>> query = client.run_query('SELECT ...', use_legacy_sql=False, use_ordered_dict=True)
>>> query.run()
>>> for row in query.rows:
             ...

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!


el.contenteditable check that we use in isFocusable and in focus() need a revamp

We do use el.contenteditable to check if we can focus an element and when we issue focus action. The issue with that is, that contenteditable always has a value, and this value is inherit (https://www.w3.org/TR/html5/editing.html#sequential-focus-navigation-and-the-tabindex-attribute). But for the real element to be focused, it should have contenteditable === true.
And as a separate thing, it's not enough just to fix that contenteditable === true, we should also add a check for the existence of tabindex.

I actually found the same thing thanks to the conversion to typescript, but since that is going to take a while we should fix it before.

I'll hope to look into that next week, as it's currently not a big issue, but for this repo to perform 1-to-1 as browser, we have to make it right :)

can it be closed?


Set the max-height of the adopted drain list

Rather than a static height to avoid empty space
Adjustment to #237
Fixes #234

Coverage remained the same at 98.491% when pulling e527df3a43ab9708c13d9816549ac0c7c75322b3 on adjust-item-scrolling into 0cf4ec314b6f703d1530b2ffa4876a5502a83265 on production.

Merging this in to adjust the UI from #237, but please feel free to leave feedback @jafowler49

thanks @jszwedko, that makes more sense


Add symbols for arrows with tilde

Implements #3433

There are at least four codepoints with the tilde above (mirrored and not mirrored):

⥲ (U+2972)
⭇ (U+2B47)
⭉ (U+2B49)
⭁ (U+2B41)

And then there are also some with tilde below. Naming those is somewhat tricky.
Do you have any sources that this symbol is used for isomorphisms and how common it is?

I think one source is this Wikipedia list, which mentions U+2972: https://en.wikipedia.org/wiki/List_of_mathematical_symbols_by_subject#Morphisms

I've looked over several standard texts in algebraic geometry and algebraic number theory. Some variation of an arrow with a tilde is commonly used to denote an isomorphism. I can give you references with pages if you want.
In LaTeX, the typical method is to use \xrightarrow{\sim} rather than the Unicode character, likely due to limited adoption of fontspec/unicode-math and awareness of the character ⥲.
I think we only need ⥲ (U+2972) and ⭉ (U+2B49). I haven't encountered an arrow with a tilde below, and reversing the tilde wouldn't align with handwriting.

Okay, thanks for the details. I was a bit confused by the fact that they look different/unmatching by default, but that's probably just unfortunate font fallback. In New Computer Modern Math they look matching. Thanks!


启动报错

Traceback (most recent call last):
  File "main.py", line 64, in <module>
    main()
  File "main.py", line 20, in main
    Query.check_before_run()
  File "/home/ubuntu/git/py12306/py12306/query/query.py", line 59, in check_before_run
    self = cls()
  File "/home/ubuntu/git/py12306/py12306/helpers/func.py", line 30, in singleton_new
    it.__init_original__(*args, **kw)
  File "/home/ubuntu/git/py12306/py12306/query/query.py", line 35, in __init__
    self.get_query_api_type()
  File "/home/ubuntu/git/py12306/py12306/query/query.py", line 154, in get_query_api_type
    self.api_type = res.group(1)
AttributeError: 'NoneType' object has no attribute 'group'

已修复


HOSTEDCP-1984: Refactor capi logic out from NodePool controller

This moves the CAPI related logic into their own file and add test coverage particularly for the reconcile function. Additional refactor of the business logic itself is left out intentionally for now to contain the scope of the refactor and avoid backward compatibility issues.
➜  hypershift git:(nodepool-refactor-capi) ✗ go tool cover -func=coverage.out | grep capi
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:45:			newCAPI						100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:60:			Reconcile					65.2%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:175:			cleanupMachineTemplates				78.1%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:235:			deleteMachineDeployment				30.8%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:256:			pauseMachineDeployment				70.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:274:			deleteMachineSet				30.8%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:295:			Pause						60.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:309:			pauseMachineSet					70.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:329:			deleteMachineHealthCheck			30.8%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:350:			reconcileMachineDeployment			72.2%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:571:			taintsToJSON					75.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:580:			reconcileMachineHealthCheck			96.4%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:662:			setMachineDeploymentReplicas			100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:695:			machineTemplateBuilders				26.3%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:852:			generateMachineTemplateName			100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:859:			reconcileMachineSet				0.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1112:			machineSetInPlaceRolloutIsComplete		0.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1118:			setMachineSetReplicas				78.6%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1148:			getInPlaceMaxUnavailable			90.9%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1166:			machineDeployment				100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1175:			machineSet					100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1184:			machineHealthCheck				100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1195:			generateName					100.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1204:			getName						66.7%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1230:			max						0.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1238:			min						0.0%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1245:			listMachineTemplates				59.3%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1306:			ensureMachineDeletion				66.7%
github.com/openshift/hypershift/hypershift-operator/controllers/nodepool/capi.go:1321:			getMachinesForNodePool				90.0%

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

TODO should link to a Jira ticket

Fleshing out all the follow ups for these series of refactors is a task on its own not to be done in this PR yet. The TODOs are the placeholders for that task.

/retest

/lgtm

/jira refresh


some assemblies break the CLR

some assemblies break the CLR after (successfull) execution like seatbelt.exe

fixed


Windnet running in Docker

Pull Request
This PR fixes issue with hanging during prediction using Windnet
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

This ready to go? Keen to try and get it deployed?

This ready to go? Keen to try and get it deployed?

Ready to review


Issue #111

Objective
Reduce the code footprint of the utility module, so it is more understandable to new readers while finding a balance between minimizing legacy complexity in the future and not over-generalizing the existing code.
Origin Document
PR73 (First iteration of a PostgreSQL based Persistence Schema) underwent several iterations in order to make the persistence module implementation have the optionality to remain verbose on a per-actor basis but also avoid code duplication and redundancy.
The first iteration of the utility module did not undergo the same iterations and therefore has some low-hanging fruit to simplify the codebase before further functionality is added.
Goals / Deliverables

[x] Extract common actor functionality into general interfaces
[x] Reduce the code complexity and code footprint so it is more approachable and maintainable
[ ] Identify and document/cleanup parts of the code that are unclear to new readers
[x] Generalize both unit tests and functionality where possible
[x] Maintain verbose entry points for each actor
General:
[x] Update the CHANGELOG
[x] Update the README
[ ] Update the global documentation & references
[ ] Document small issues / TODOs along the way

Testing Methodology

Utility tests: make test_utility_*
All tests: make test_all
LocalNet: works following the instructions in docs/development

Non-goals

Adding any new functionality

Changes Made

Removed transaction fees from the transaction structure as fees will be enforced at the state level
Removed actor specific messages (besides DoubleSign) and added actorType field to the struct
Removed pause messages and functionality as it is out of scope for the current POS iteration
Removed session and test-scoring as it's out of scope for the current POS iteration
Consolidated unit test functionality for actors
Modified pre-persistence to match persistence for Update(actor), 'amountToAdd' is now just 'amount'

Future work

There's more documentation that is needed for this to be complete. In a separate issue, I'd like to tackle connecting Utility with Persistence.

Co-authored-by: Daniel Olshansky<EMAIL_ADDRESS>Co-authored-by: Andrew Nguyen<EMAIL_ADDRESS>Co-authored-by: Andrew Nguyen<EMAIL_ADDRESS>Co-authored-by: Daniel Olshansky<EMAIL_ADDRESS>

Discussed offline in a DM but also posting here for transparency for others.
@andrewnguyen22 Looking at the Makefile, it seems like we need to either merge/rebase (whichever is easier in this scenario) on top of main to view the changes.

Merged into main, should be good to go

@andrewnguyen22 Per an offline discussion, it is likely you have mostly completed this work, but I wanted to share what my personal approach is to replacing lots of code using regexes.
Disclaimer: There's probably always a better way to do it so this is just knowledge sharing.
I use case sensitive regex find & replace all in vscode* and create a few pattern (see two examples below) where I use the matches from the find (i.e. (.*)) in the replace (i.e. $1, $2, $3). It's a fun way to practice regex and helps alleviate my allergy of doing repetitive copy-pasta work though I realize it may be fun/meditative to some.
* I'd be surprised if Goland or other IDEs don't have this feature
Example1

Example2

Didn't mean to request a review yet

Didn't mean to request a re-review yet

Good to go

I'm still in the process of making some changes that I plan to push up by EOD. Please hold off on merging for now

@andrewnguyen22 We'll definitely have another iteration on this at some point, but for now I think this is a major step forward and improvement.
I made additional changes, merged with main, ran the unit tests, tested local cloud and updated the description.
Feel free to squash & merge if it looks good to you.


Unable to publish to stream without calling stream.State()

Hello,
I am running a strange issue concerning either jsm.go, either my Go code.
I a trying to publish some messages into a stream. It does work very well when i call stream.State() at the end of my little piece of code.
However, if i remove this stream.State(), it does not work anymore. conn.Publish(...) is not throwing any errors whereas i don't see any messages incoming into the stream (i am doing a nats str info mystream on the server and the Messages property stays at 0.
Thanks for your support.
Versions:

JetStream server => synadia/jsm:0.0.12
Golang => go1.14.1 windows/amd64
github.com/nats-io/jsm.go v0.0.0-20200304134846-c02f52026763
github.com/nats-io/nats.go v1.9.1

package main

import (
	"flag"
	"log"
	"math/rand"

	"github.com/nats-io/jsm.go"
)

const (
	streamName  = "mystream"
	subjectName = "mysubject"
)

func main() {
	nMsgs := flag.Int("n", 1, "number of messages")
	flag.Parse()

	jsm.Connect("localhost:4222")
	conn := jsm.Connection()

	stream, err := jsm.LoadOrNewStream(streamName, jsm.FileStorage(), jsm.Subjects(subjectName))
	if err != nil {
		log.Fatal("error loading or creating stream: ", err)
	}

	msg := make([]byte, 64)
	rand.Read(msg)
	for i := 0; i < *nMsgs; i++ {
		err = conn.Publish(stream.Subjects()[0], msg)
		if err != nil {
			log.Fatalf("error publishing into %s stream: %v", streamName, err)
		}
	}

        // If this is not called, the publish does not work and throw no error
	stream.State()
}

NATS client has a little internal buffer of messages so if you exit - or as here reach the end of your code - immediately after publishing the buffer might be lost.
call conn.Flush() and I bet it will work too instead of stream.State(), and if that works then this is why. You can do like:
err := jsm.Connect("localhost")
if err != nil { panic(err) }
conn := jsm.Connection()
defer conn.Close()

// rest of your code

this should also avoid the problem I think. jsm.Connect is a bit grim and should probably just return the nc as a parameter too

Ok that was the problem because defering conn.Close() works as well.
I should care much about closing/flushing connections and buffers :)
Thank you for your blazing fast response.
Closing this. Keep up the good work


Relay task/container logs to UDP Syslog

This PR adds support for relaying container logs to a configurable UDP syslog endpoint. Currently this is built around the behavior of the Sumo Logic collector, or similar software that accepts any data on the socket. It purposely doesn't implement real Syslog protocol so that the result in Sumo Logic is better. If someone wants to change the output from raw UDP to real syslog, or anything else supported by Logrus Hooks, that would be an easy task.
In order to implement this PR, and given the age of some of the dependencies of this project, I had to do a big update on the dependencies. This project was still using the old logrus URL for example.
Includes documentation update for new logging options.j
The result, is that this is a pretty big PR. It has been tested on Mesos with some limited scope. The binaries are about 50% bigger after the dependency update and built on Go 1.11. Totally memory
with syslog enabled seems around 17MB - 18MB per executor process. This may expand slightly
under load, but the fact that logs are sent over UDP should prevent any real backpressure.

@mihaitodor @sbz @felixgborrego @mosche This is an attempt to deal with logging in a completely different way. I seem to have lost privs on this repo so I can't add you as reviewers.


Use ports in desired app cc message for docker app

This PR is to allow docker recipe builder to use ports specified in desire app message from cc. If no ports are specified in desire app message from cc then it continues to extract ports from execution metadata.
This is done because we need to return the ports opened for docker app as part of GET /v2/apps/:guid call in CC. Since CC already has execution_metadata, it can parse it and determine the ports to be opened for docker app. Letting CC figuring out ports for app will allow us to control the limit on number of ports in one place for both buildpack apps as well as docker apps.
Link to pivotal tracker story: https://www.pivotaltracker.com/story/show/108391924
Regards,
@atulkc and @jeffpak93
(CF Routing team and CAPI team)

Thanks, @atulkc and @jeffpak93! Prioritized in the Diego backlog for evaluation.
Best,
Eric

Thanks for promptly merging this one!


etics does not build

complains about no rule to make libetics.a

Please let us know if this is still an issue.

@ipelupessy and I think it may have been related to an outdated CUDA version.


 causes OOM

https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=57501.
@iskakaushik is assigned to the upstream bug; so assigning here.

Presently being investigated by a member of the Fuchsia team no action needed from Flutter at present.

There's not yet enough information on the upstream issue(s) for @iskakaushik to take a look at this one, so I will remove his assignment.

Triage: This needs more investigation on the application side. The update on the internal bug two days ago suggests this is unlikely to be a Flutter issue.

Critical issue triage update: upstream team looking at logs for additional information about the issue. Still nothing actionable for the Flutter team.

Upstream issue closed as "working as intended". Closing this issue.


Adding proposal to remove associated type inference

Note that I just started the pre-proposal discussion thread, so you may or may not wish to merge this immediately.

Thanks, I'll kick this off shortly, unless you'd like to wait.  What do you prefer @austinzheng ?

i suspect in going to be asking for some revisions. Will review tonight.

Ok, lemme know when you're ready.  Probably best to email me directly for prompt response :-)

I'll be standing by tonight for whatever revisions you want to make. Once
they're in, I'll let Chris know and he can kick it off whenever he wants.
On Tue, Jun 28, 2016 at 9:21 PM, Chris Lattner<EMAIL_ADDRESS>wrote:

Ok, lemme know when you're ready. Probably best to email me directly for
prompt response :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apple/swift-evolution/pull/380#issuecomment-229252650,
or mute the thread
https://github.com/notifications/unsubscribe/ADhCjht1VBb0Vopz5GRbJ7MsBlPwHaa-ks5qQfLGgaJpZM4I-Rri
.

Oh, it's already in. In that case it's probably best for the two of you to just make whatever revisions need to be made directly. Let me know if I can help in any way.

You can create pull requests to update proposals that are already in. Will send comments via the mailing list soon.


Feat : Modifying the Website Logo

Describe the feature
Modifying the Website Logo According to the DevOps.
I have Modified the existing logo by adding DevOps logo to the existing logo.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@mdazfar2 My Pleasure.