Experiment with one canvas, rather than separate tiles ?

Just an idea, if it could be possible to draw just on one canvas in layers, rather than per tile (and have a tile just as a data store). Maybe this strays a bit from tile layers, but fits in somewhat with other layers like polygons etc (in fact could vector tile code even use existing flutter_map polyline/polygon layers ?)

Currently ongoing with single_canvas branch


[WIP] storage: Contextify storage interfaces.

This is based on https://github.com/prometheus/prometheus/pull/1997.
This adds contexts to the relevant Storage methods and already passes
PromQL's new per-query context into the storage's query methods.
The immediate motivation supporting multi-tenancy in Frankenstein, but
this could also be used by Prometheus's normal local storage to support
cancellations and timeouts at some point.

I think per-query context makes a lot of sense even outside of of the multi-tenancy scope. I'd love a way to somehow log slow queries including the expression and number of chunks read from memory/disk. Maybe we could use the context for that as well.

@fabxc Ok, made the requested changes as separate commits:

Rename query context to generic context everywhere
Remove context from Append() again
Fix import grouping in rules/manager.go
Move web.New() parameters into options struct

Changes look good.

@fabxc Thanks! GitHub still says "fabxc requested changes", "1 review requesting changes.". Is there anything I need to do, or do you just need to approve somewhere now?

Nothing other than squashing the amendments back in.

Aye, done. Merging.


[Pager] Pacge change triggered twice in fragments

Description
When used in a Fragment, PagerState triggers two times a page change when implemented as the doc says here  : https://google.github.io/accompanist/pager/#reacting-to-page-changes
val pagerState = rememberPagerState()

LaunchedEffect(pagerState) {
    // Collect from the pager state a snapshotFlow reading the currentPage
    snapshotFlow { pagerState.currentPage }.collect { page ->
        AnalyticsService.sendPageSelectedEvent(page)
    }
}

VerticalPager(
    count = 10,
    state = pagerState,
) { page ->
    Text(text = "Page: $page")
}

Steps to reproduce
This is my implementation in a newly created project. I inflate a Compose view in onCreateView :
@OptIn(ExperimentalPagerApi::class)
override fun onCreateView(
    inflater: LayoutInflater,
    container: ViewGroup?,
    savedInstanceState: Bundle?
): View {
    return ComposeView(requireContext()).apply {
        setContent {
            val pagerState = rememberPagerState(3)
            pagerState.let { pagerState ->
                LaunchedEffect(pagerState) {
                    snapshotFlow { pagerState.currentPage }.collect() { page ->
                        Log.d("PagerTest", "Page $page")
                    }
                }
                HorizontalPager(
                    count = 4,
                    state = pagerState,
                    itemSpacing = 0.dp,
                ) { page ->
                    Text("Page $page", color = Color(0xFF000000), fontSize = 28.sp)
                }
            }
        }
    }
}

This outoutes in the console : (see Log.d("PagerTest", "Page $page") in the SideEffect) :
> PagerTest Page 3
> PagerTest Page 0
Expected behavior
Expected output is
> PagerTest Page 3
Expected output is obtained if used in a full compose app. but unfortunately this project still has fragments in the codebase.
Additional infos
Same behavior is observed when using .distinctUntilChanged()

To be honest it is not clear to my why the page will change to 0 when used in the Fragment. Maybe it depends on how your Fragment is used? I am not sure I can reproduce it without having the whole project.
But the issue is not that observation doesn't work, but because the current page is really reset to 0

You don't need the whole project. I tested the code snippet I posted in a new project freshly created from Android Studio.
In a project that doesn't use fragments => No problem.
In a project that uses fragments, the bug is present.
I created a "Bottom Navigation Activity" project from Android studio.

Hey. I just tried to create "Bottom Navigation Activity" project and put your code inside DashboardFragment and run it on emulator and only see  Page 3 being printed.
Could you please try to first update the latest versions of compose and accompanist and share the whole project which you use to reproduce and on what device you are running it

Hey I'm really sorry for this I was 100% sure I used the latest accompanist version but it turns out I was using 0.19.0.
I felt I double checked it before creating the issue and posting the snippet.
It works well with the latest version.
Sorry again for this.
I'm closing the issue.


[gotosocial] Add support for arbitary initContainers

Is your feature request related to a problem ?
I'd like to be able to configure some networking stuff in my gotosocial container via an initContainer before the main container starts.
Describe the solution you'd like.
I'd like an additional value/set of values in the values.yaml that gets translated into the gotosocial deployment's initContainers field
Describe alternatives you've considered.
Forking the chart seems to be the only alternative for what I want to do with this, as network policies don't support blocking cidrs.
Additional context.
No response

@AmandaCameron, added the possibility, can you recheck if this matches the requirements?
initContainers:
  - name: init-myservice
    image: busybox:1.28
    command: ['sh', '-c', "until nslookup myservice.$(cat /var/run/secrets

Doesn't work. I think the {{- toYaml . | nindent 8 }} needs to be  {{- toYaml .Values.initContainers | nindent 8 }} Otherwise it's including a bunch of invalid stuff in the initContainers value, turning it into an object not an array of v1.Container

Sorry for the delay but somehow I always have a lot on my mind at the moment, I hope you were able to help yourself first, now everything should work as desired.


d455 in ubuntu. Alignment of images acquired by infrared and color cameras, color image acquisition by infrared cameras, rough acceleration of gravity

Required Info

Camera Model
{ D455 }

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 20

Kernel Version (Linux Only)
5.15.0-75-generic

Platform
i7-12700

SDK Version
2.54.1

Language
labview

Segment
{others }

Issue Description
Question 1: When the viewer is set as shown in Figure 1, the rqt_bag interface in Figure 2 shows that the color image and the infrared image are not completely aligned, and there is a time interval of about 0.0585s between them (this time interval is a random value, it are different across multiple records). May I ask whether the interval can be completely aligned, and if so, how should it be set in the viewer.

Question 2: I want to get the color image from the left IR camera and image in any format (infrared or color) from the right IR camera at the same time. However, as shown in Figure 3, such a setting in the Viewer will cause errors. Can this configuration be realized?

Question 3: According to the table shared on the Internet, the typical acceleration of gravity at the location of the device is 9.7947m/s2. But Figure 4 shows that the gravitational acceleration measured by the IMU in a static state is 9.62-9.63. Is this normal? If not, how to calibrate it with low-cost measures.

Hi @KOBOSP  The RGB and Infrared images are not aligned because the different types of sensors on the front of the camera are in different physical positions, horizontally offset from each other.  The RGB sensor is next to the left infrared sensor and so while they have a similar field of view, they are not viewing the scene from exactly the same position because of this offset.
The RealSense Viewer does not provide an alignment function in its 2D mode (shown in your images above).  Its 3D pointcloud mode can map together depth and RGB or depth and infrared, but not RGB and infrared.
RGB8 color is only supported from the left infrared sensor and the right infrared sensor only provides Y8 infrared, so it is not possible unfortunately to stream RGB8 color from both the left and right infrared sensors as doing so will cause the pop-up error that you hghlighted.  You can stream infrared RGB and the RGB sensor at the same time, but they will not have exactly the same viewpoint, and the RGB from left infrared also looks different in its coloring to the RGB stream.
At https://github.com/IntelRealSense/librealsense/issues/1548#issuecomment-389070550 a RealSense team member advises that when two separate sensors are being streamed, they are not perfectly aligned but the RealSense SDK tries to find the best match between the timings.  I note that you have the RGB option Auto Exposure Priority disabled, so the SDK should be trying to enforce a constant FPS speed for all streams.

Supplement to question 2: Can the left infrared sensor output RGB8 and the right infrared sensor output Y8 simultaneously on the d455?

No, if the left sensor is streaming RGB8 color then the right sensor cannot stream Y8 at the same time.

thanks for your clarification


unmount chroot help needed

I often get the error Not unmounting /mnt/stateful_partition/crouton/chroots/mychroot as another instance is using it when I somehow leave something running in the background.  I need to unmount because I have an app that will sometimes refuse to start until I unmount and remount.
When I do umount /mnt/stateful_partition/crouton/chroots/mychroot i get the message umount: /mnt/stateful_partition/crouton/chroots/mychroot: not mounted.  The two errors are contradictory.  One says it is mounted and the other says it isn't.  Could the path in the first message be wrong?
Can someone tell the right way to unmount a chroot?
Edit: I just realized that a good way to solve this is to find what process is causing the problem and killing it.  Any hints on how to do this?

@mark-hahn you want to use unmount-chroot, umount is for unmounting standard linux /dev devices, see this thread:
https://github.com/dnschneid/crouton/issues/117

Thanks ...


Merge to version release 0.4.1

Release of version 0.4.1

Major changes:

Fix bug when counting number of solutions (.size()); should ignore the last check where there is no solution.
New infrastructure for better iterator to return the bindings Map<String,Terms> from QuerySolution

Ouch! this is wrong, it was meant to be on the forked version!! :-( Did it work?


Fix encodings and scripts to use UTF-8.

I have reformatted the files to use UTF-8 encoding; and have adjusted the scripts to use codepage 65001. Unless github screws it up; the file should hopefully be the proper end-of-line mode. The progress window also works now. I started adding an option for ffmpeg debug output; but I need to look in to the documentation regarding it's environment variable requirements.
-Jay

I tried it but now this happens to me... This is a bit confusing because it is a system language font difference issue
Also, when converted to UTF-8, some special characters were recognized as commands, which made the menu screen a bit messy.
I'll review it further


Fixed ActiveDirectoryInteractive authentication timeout issue

Use 10 * loginTimeout timeout value which is consistent with SqlClient behaviour

Was just reading the files, and noticed this alot in project. So the convention for null checks is "null == someVar"? And not the other way around? eg. "someVar == null" or "someVar != null"

/azp run CI-MacOS

/azp run CI-MacOS

/azp run CI-MacOS


Bump itk version

ITK 4.12.1 has been released today.

Unfortunately ITK 4.12.1 still have the last fix we submitted: "COMP: Fixed <nifti1_io.h> leak into user code",  http://review.source.kitware.com/#/c/22461/
Compare 4.12.1:
https://github.com/Kitware/ITK/blob/v4.12.1/Modules/IO/NIFTI/include/itkNiftiImageIO.h
To the master:
https://github.com/Kitware/ITK/blob/master/Modules/IO/NIFTI/include/itkNiftiImageIO.h

For the record, our fix ("Fixed <nifti1_io.h> leak into user code"), will be included with the next release:  http://public.kitware.com/pipermail/community/2017-August/013541.html

Good news: a new ITK release is expected within a week! Including our fix ("Fixed <nifti1_io.h> leak into user code"): "[ITK-dev] Patches for 4.12.2 release", https://public.kitware.com/pipermail/insight-developers/2017-September/025262.html

Apparently our "niftilib-name-mangling" fix (which added "itk_nifti_mangle.h" to Modules/ThirdParty/NIFTI/src/nifti/niftilib) was not yet released. Hope it can still be added to ITK  4.12.2: https://public.kitware.com/pipermail/insight-developers/2017-September/025263.html

Update: Matt McCormick has taken care of including both of our Nifti patches (fixing the <nifti1_io.h> leak and doing the name mangling) with the upcoming ITK release (4.12.2).

Nice job Niels! I'll bump itk to 4.12.2 as soon as the tag is available in their github repo.

And yessss!!!! Finally both of our Nifti ITK fixed are officially included with ITK! ITK 4.12.2 is out! Tag: https://github.com/Kitware/ITK/tree/v4.12.2  Including:
  COMP: add symbol name mangling for niftilib in ITK
  COMP: Fixed <nifti1_io.h> leak into user code

See "[ITK-dev] [ANN] ITK 4.12.2 has been released!", posted by Matt McCormick: https://public.kitware.com/pipermail/insight-developers/2017-September/025274.html

To my surprise, even with ITK 4.12.2, the niftilib header files are still being installed in the "prefix" directory (<\ITK-prefix\include\ITK-4.12). See "[ITK] How to avoid NIFTI header files from being installed?", https://public.kitware.com/pipermail/community/2017-September/013625.html

Update: I just submitted a patch to prevent those niftilib header files from being installed in the "prefix" directory:  http://review.source.kitware.com/#/c/2246

Update: I just submitted a patch to prevent those niftilib header files from being installed in the "prefix" directory: http://review.source.kitware.com/#/c/22461/

Update: I just submitted a patch to prevent those niftilib header files from being installed in the "prefix" directory, and the correct link is: http://review.source.kitware.com/#/c/22646/


Added support for user-defined keycodes

Hi,
Here's a PR for your consideration, which allows users to specify additional keycodes which trigger adding a tag based on the current input value. Currently, this only happens with the user presses Enter (13), but this change allows users to specify an optional array of additionalKeycodes which can result in a tag being added e.g. comma, space, tab etc.
I have updated example/index.tsx accordingly to illustrate how this would work. The new property is optional and so has no impact on the current functionality if it is not provided.
const initialSettings: ReactTagInputProps = {
  tags: [],
  onChange: (tags) => {},
  placeholder: "Type and press enter, tab, space or comma",
  maxTags: 10,
  editable: true,
  readOnly: false,
  removeOnBackspace: true,
  validator: undefined,
  additionalKeycodes: [9, 32, 188]  // tab, space, comma
};

Thanks,
J

Ah, I've just spotted there is another PR open which provides similar functionality. Please consider merging that. I'll close this one now. Thanks.

Ah, I've just spotted there is another PR open which provides similar functionality. Please consider merging that. I'll close this one now. Thanks.


Replace Magma with Koe

Koe is a smaller and perhaps more maintainable alternative to Magma.
Koe also relies on JDA-NAS natives for native audio sending.

^ green circle lights up when joining a channel without playing a song.

@Dramex I haven't encountered that. Can you provide a log?

@Frederikam https://pastebin.com/raw/NdHhX9YU

@Dramex you're not playing anything.
Though it is odd that there is a green circle. Maybe that's because this version of Koe does not send silent frames.

I'm working on it, Koe's handling of speaking is currently broken.

@Frederikam https://github.com/KyokoBot/koe/releases/tag/1.0.0-beta1

Finally got around to fixing the breaking changes.
I haven't found the time to test it. Feedback is appreciated.

I am now using this in production. This is probably safe to use.


Fix: JSON tag case

JSON unmarshal is case insensitive in Golang

Codecov Report

Merging #1212 (9194d67) into master (8f429c3) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
- Coverage   44.80%   44.64%   -0.17%
==========================================
  Files         485      476       -9
  Lines       29507    29406     -101
==========================================
- Hits        13221    13127      -94
+ Misses      14886    14874      -12
- Partials     1400     1405       +5

Impacted Files
Coverage Δ

infra/conf/transport_internet.go
35.94% <ø> (+0.23%)
:arrow_up:

app/proxyman/outbound/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

common/task/task.go
88.88% <0.00%> (-7.41%)
:arrow_down:

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

app/proxyman/outbound/handler.go
38.05% <0.00%> (-4.48%)
:arrow_down:

transport/internet/udp/hub.go
73.61% <0.00%> (-4.17%)
:arrow_down:

transport/internet/system_listener.go
50.00% <0.00%> (-4.00%)
:arrow_down:

transport/internet/kcp/dialer.go
80.39% <0.00%> (-3.93%)
:arrow_down:

testing/scenarios/common.go
70.68% <0.00%> (-3.45%)
:arrow_down:

transport/internet/system_dialer.go
46.83% <0.00%> (-2.54%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f429c3...9194d67. Read the comment docs.


Joel Smith: Onboarding to PST

[x] Add/remove from https://github.com/kubernetes/community/blob/master/sigs.yaml#L2602
[x] Add/remove from OpsGenie rotation
[x] https://groups.google.com/a/kubernetes.io/forum/#!forum/security owner
[x] https://groups.google.com/a/kubernetes.io/forum/#!forum/security owner
[x] https://groups.google.com/forum/#!forum/kubernetes-security-discuss owner
[x] https://groups.google.com/forum/#!forum/kubernetes-security-announce owner
[x] https://groups.google.com/a/kubernetes.io/forum/#!forum/distributors-announce owner
[x] https://github.com/kubernetes-security/security-disclosures/issues access
[ ] ???

After doing this write an onboarding doc.

Do I need to be added to either of these?
https://github.com/kubernetes/community/blob/master/sigs.yaml#L2596
https://github.com/kubernetes/org/blob/master/config/kubernetes/org.yaml#L1851
(I'm not sure if one is generated from the other)

@joelsmith yes, PR is up https://github.com/kubernetes/community/pull/3459

/assign philips

/remove-lifecycle stale
On Tue, Jun 18, 2019 at 10:19 AM fejta-bot<EMAIL_ADDRESS>wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/security/issues/11?email_source=notifications&email_token=AAAIGCA7FC2MKGQLOJAV263P3EKJHA5CNFSM4G636WD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7K43Y#issuecomment-503230063,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAIGCFVVGXNC3HTXRKSU2DP3EKJHANCNFSM4G636WDQ
.

/assign @joelsmith
I think this is done?


Add heroku-22 stack

I've tested in an internal project and everything was looking good ✨

Thanks!

@jontewks Hi! Thank you for merging this. Would you mind releasing it to the buildpack registry too? Currently any users using the jontewks/puppeteer buildpack alias (which uses the version from the buildpack registry) will get the Heroku-22 not supported error still.

@edmorley actually just ignore the above. After having waited this long it appeared much more likely it was something wrong with my setup. I removed my github integration from my regular heroku account and readded it, and now can access the repos through the partner portal. Not sure what I messed up previously.


[Bug] Profile number mismatch Logitech G502 X

Information

ratbagd version (ratbagd --version): 0.17 and master (I built from source today (reports version 0.18) just to check)
Distribution: Debian 12 KDE Plasma Wayland
Kernel version (ex. uname -srmo): Linux 6.1.0-27-amd64 x86_64 GNU/Linux

Device info (if applicable):

$ ratbagctl <device> info
screaming-acouchy - Logitech G502 X LIGHTSPEED
             Model: usb:046d:c098:0
       Device Type: Mouse
 Number of Buttons: 11
    Number of Leds: 0
Number of Profiles: 5
Profile 0:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 100dpi
    1: 1000dpi (active) (default)
    2: 100dpi (disabled)
    3: 100dpi (disabled)
    4: 100dpi (disabled)
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'resolution-alternate'
  Button: 5 is mapped to 'button 5'
  Button: 6 is mapped to 'wheel-left'
  Button: 7 is mapped to 'wheel-right'
  Button: 8 is mapped to 'profile-cycle-up'
  Button: 9 is mapped to 'resolution-up'
  Button: 10 is mapped to 'resolution-down'
Profile 1:
  Name: n/a
  Report Rate: 125Hz
  Resolutions:
    0: 100dpi
    1: 1000dpi (active) (default)
    2: 100dpi (disabled)
    3: 100dpi (disabled)
    4: 100dpi (disabled)
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'resolution-alternate'
  Button: 5 is mapped to 'button 5'
  Button: 6 is mapped to 'wheel-left'
  Button: 7 is mapped to 'wheel-right'
  Button: 8 is mapped to 'profile-cycle-up'
  Button: 9 is mapped to macro '↕KEY_1'
  Button: 10 is mapped to macro '↕KEY_2'
Profile 2: (disabled) (active)
Profile 3: (disabled)
Profile 4: (disabled)

Describe the bug
I set up 2 onboard profiles on Windows using GHUB, I had them as the first and second profiles. In GHUB it shows the Profiles numbered 1-5.
I understand that computers count starting from 0 but I think something went wrong with libratbag or maybe just ratbagctl because the output shows Profile 2 as disabled but active and my mouse acts like it is on Profile 1. If I switch profiles with my mouse button, and then restart ratbagd it shows Profile 1 is active but the mouse acts like Profile 0 is active.
To Reproduce
Steps to reproduce the behavior:

Observe the profiles are mismatched (at least with G502 X) when running ratbagctl <device> info or ratbagctl <device> profile active get (and maybe other commands too).


VEVOR 7in1 Weather Station supported?

I bought a VEVOR Profi WLAN-Wetterstation 7-in-1 and I am pretty unhappy that I can't receive my data locally (and integrate them to Home Assistant).
I was able to sniff the traffic with my fritzbox:

so I know the data is available in my network in clear text, but at this point, I don't know how to read them. :-(
/v01/set/wid/****/key/**********/bar/10131/temp/47/hum/94/wdir/230/wspd/28/dew/38/chill/20/heat/47/rainrate/0/rain/0/uvi/0/solarrad/147 HTTP/1.1

Unless your sensor uses one of the Bresser protocol variants, it is out of this project's scope. Maybe a project like https://github.com/raphv/bresser-home-assistant is closer to what you are looking for.


Add option ZeroAsNull (Fixes: #30)

Since EmptyAsNull got introduced in v1.1 with its framework, adding this feature was quite straightforward.
The slight performance toll of using reflect should only happen when actually opting in ZeroAsNull and I think there will be no better way of doing it without knowing the types beforehand.
Definition of omitempty:

Struct values encode as JSON objects. Each exported struct field becomes a member of the object, using the field name as the object key, unless the field is omitted for one of the reasons given below.
The encoding of each struct field can be customized by the format string stored under the "json" key in the struct field's tag. The format string gives the name of the field, possibly followed by a comma-separated list of options. The name may be empty in order to specify options without overriding the default field name.
The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string.

Difference of reflect.Value.IsValid and reflect.Value.IsZero to prevent confusion:

The documentation for reflect.Value.IsValid says "It returns false if v is the zero Value". Note the uppercase Value, it's referring to the reflect.Value, an abstract representation of any Go value.
The documentation for reflect.Value.IsZero says "IsZero reports whether v is the zero value for its type". Note the lowercase value, it's referring the underlying Go value that the reflect.Value is representing.

So we can safely say that reflect.Value.IsZero is matching exactly the case of omitempty, if the user decides to opt in to this behaviour using ZeroAsNull.
There is strange behavior in tests! Even though I added the yaml testcase as last document in yamlA and yamlB all existing results (resultOfNoOptions, resultOfWithEmpty and the new resultOfWithZero) strangely expect the diff inbetween. You might want to look into that.
Edits to my branch are allowed if you want to extend the PR.

:+1: Thanks for your contribution!

@dionysius
Sorry for the late. Thanks for your contribution! :+1:

Thanks! Do you have a minute to comment on my notes here? I'd like to understand the internals a bit better :)

@dionysius

I don't quite understand why diffcount is 0 in all those new test cases e.g. here. Shouldn't those be 1? EmptyAsNull cases have those e.g. here

Because, that diffCount:5 test has nil here. And diffCound is calculated from len([]rune(fmt.Sprint(rawA))) starts here. In you wrote diffCount:0 test case, it has  empty string here. That len([]rune(fmt.Sprint(rawA))) returns 0.
https://go.dev/play/p/4IM_sloD2VV

I expected ZeroAsNull to implicitly also behave like EmptyAsNull due to reflect.Value.IsValid and reflect.Value.IsZero, since an empty property should be some form of zero, no? Compare the line from resultOfWithEmpty with resultOfWithZero

I think this has to do with reflect.ValueOf(nil).IsValid() would return false, maybe my lines should be (or maybe this is just fine the current way):

Yes, that's correct. Because nil is nil, it cannot be decides any interface or primitive values. ValueOf returns zeroValue. https://pkg.go.dev/reflect#ValueOf
But maybe wrapped nil can be used to...? e.g. https://go.dev/play/p/f-Z4SD0gcUT


[Android] [Fixed] Fix the IllegalViewOperationException when updateLayout in NativeViewHierarchyManager

[Android] [Fixed] Fix the IllegalViewOperationException when updateLayout in NativeViewHierarchyManager.
TestPlan
No plan.
ChangeLog
Remove the code of throwing IllegalViewOperationException, print the log and return instead.

This doesn't really seem like a fix to me as you are just commenting out an exception that is thrown for probably a good reason. I'm gonna close this pull request proactively but I'm happy to reopen it if you update your code, summary or test plan to verify that this change is actually something we want to merge. Thank you.

This doesn't really seem like a fix to me as you are just commenting out an exception that is thrown for probably a good reason. I'm gonna close this pull request proactively but I'm happy to reopen it if you update your code, summary or test plan to verify that this change is actually something we want to merge. Thank you.

But at least, the exception message used a wrong tag.
        ViewManager parentViewManager = mTagsToViewManagers.get(parentTag);
        ViewGroupManager parentViewGroupManager;
        if (parentViewManager instanceof ViewGroupManager) {
          parentViewGroupManager = (ViewGroupManager) parentViewManager;
        } else {
          throw new IllegalViewOperationException(
              "Trying to use view with tag " + tag + " as a parent, but its Manager doesn't extends ViewGroupManager");
        }

The tag of the exception message should be the parentTag.


Document how to test that you're instrumenting traces correctly

Something I've seen come up a few times is: "How do I unit test that I'm adding the right attributes to a span?"
You can't test this with the tracing API because it doesn't give you access to this data. But you can depend on the "SDK trace API" in a language to get access to a read/write span.
This should probably be documented with an example in all the languages with stable tracing:

[ ] JS
[ ] Java
[ ] Go
[ ] .NET
[ ] Python
[x] Elixir
[ ] Ruby
[ ] C++

Some specific things that would be covered:

How to establish a test harness with an in-memory exporter
Which packages to pull in to do this testing
Example of a simple bit of code that does a thing with otel tracing
Example of a test that tests that function that does the tracing

@cartermp and I have been discussing this on the pollinators slack - I'm happy to write up some docs for Go if someone would be kind enough to point me to where they should live :)

Put it in a subpage of https://opentelemetry.io/docs/instrumentation/go/, we can then still decide to move it somewhere else.

I wrote a rough draft of I think what this issue is asking for in https://temporaryhack.com/blog/opentelemetry-testing, for elixir.
Happy to take some feedback on it, polish it, and submit it -- if it's what y'all are looking for.

I wrote a rough draft of I think what this issue is asking for in https://temporaryhack.com/blog/opentelemetry-testing, for elixir.
Happy to take some feedback on it, polish it, and submit it -- if it's what y'all are looking for.

Can you put it as a (draft) PR here? makes the review easier for us.

I wrote a rough draft of I think what this issue is asking for in https://temporaryhack.com/blog/opentelemetry-testing, for elixir.
Happy to take some feedback on it, polish it, and submit it -- if it's what y'all are looking for.

Can you put it as a (draft) PR here? makes the review easier for us.

Done, submitted rough draft here

Thanks @akasprzok - your doc is live!

@cartermp: can we copy some of the content from elixir/erlang over to the other languages or is it too specific?

The content can probably be copied over easily and tweaked as needed, but the code samples will be different since setting up a test harness can vary so wildly from language to language.

Thank you all for making my first contribution such a fantastic experience!

@cartermp is this still something you want to see in the docs?


typo

Which Warhol?
Any Warhol!

Haha good catch!! That was a test......... hehe

:rocket: PR was released in v1.13.0 :rocket:


work on 3.68?

im sorry

are u tho

the suspend issue might return in 3.68

Working good so far the issue i confront either stuck in splash screen (senran kagura ev mod) but that can be fixed by deleting any file except tpk folder, now there are problem I'm not sure how to fix, sometimes the games will stuck on loading screen (sk sv, sk ev, Gundam breaker 3(decrypted dlc)) , im sorry for posting my problem here
Btw  by fw is 3.68

Not working for me on 3.68. followed everything i can find on the internet related to installing rePatch. Will not translated to games i have tried so far (pso2 nova and pso2).
Does seem to access rePatch folder correctly, if i patch eboot with vitashell, it will load vitashell instead of game.
Game loads but with no patch from rePatch folder applied.
Pulling my hair out currently! Please help. Thanks!

I can confirm that the suspend issue is present on 3.67 and 3.68, while on 3.65 it does not (I have 3 Vitas).
The patch for Phantasy Star Nova works, and I can play as much as I want without crashes until I go to Livearea, or suspend my Vita. I noticed this first when going to Livearea, as I don't usually suspend it.
I can also confirm that on both 3.67 and 3.68 the reAddcont folder works with DLC (same game), so this is probably just the same issue as the one before rePatch Redux, but for the newest firmwares.


AssistedFactory_Factory not regenerated after the files it references are deleted

I set up a barebones repo to investigate issues similar to what I've encountered in Cash, and which I thought were related to AssitedInject and incremental AP. However this specific issue can be reproduced with kapt.incremental.apt set to both true and false.
The repro steps are described in the linked project's README, but in a nutshell, here's the project's layout:
:app
  - View1.kt - uses InflationInject, injects Presenter1.Factory
:presenters
  - Presenter1.kt - uses AssistedInject
:viewmodels
  - ViewModel1.kt and ViewEvent1.kt

The project can be built successfully. The files are being migrated into the following layout:
:app
  - Uses View1 in an XML layout
:blockers
  :views
    - View1.kt - uses InflationInject, injects Presenter1.Factory
  :presenters
    - Presenter1.kt - uses AssistedInject
  :viewmodels
    - ViewModel1.kt and ViewEvent1.kt

After the migration the project can still be built just fine. However, after running a script to revert the migration (which in real life would be somewhat similar to commiting the changes and switching to a different branch), building the project would fail:
Build failures
> Task :blockers:views:compileDebugJavaWithJavac FAILED
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:4: error: cannot find symbol
import com.squareup.aiik.blockers.presenters.Presenter1;
                                            ^
  symbol:   class Presenter1
  location: package com.squareup.aiik.blockers.presenters
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:12: error: cannot find symbol
public final class View1_AssistedFactory_Factory implements Factory<View1_AssistedFactory> {
                                                                    ^
  symbol: class View1_AssistedFactory
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:13: error: package Presenter1 does not exist
  private final Provider<Presenter1.Factory> factoryProvider;
                                   ^
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:15: error: package Presenter1 does not exist
  public View1_AssistedFactory_Factory(Provider<Presenter1.Factory> factoryProvider) {
                                                          ^
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:20: error: cannot find symbol
  public View1_AssistedFactory get() {
         ^
  symbol:   class View1_AssistedFactory
  location: class View1_AssistedFactory_Factory
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:24: error: package Presenter1 does not exist
  public static View1_AssistedFactory_Factory create(Provider<Presenter1.Factory> factoryProvider) {
                                                                        ^
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:28: error: package Presenter1 does not exist
  public static View1_AssistedFactory newInstance(Provider<Presenter1.Factory> factory) {
                                                                     ^
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:28: error: cannot find symbol
  public static View1_AssistedFactory newInstance(Provider<Presenter1.Factory> factory) {
                ^
  symbol:   class View1_AssistedFactory
  location: class View1_AssistedFactory_Factory
/Users/egor/Development/bugs-workspace/AssistedInjectIncrementalKapt/blockers/views/build/generated/source/kapt/debug/com/squareup/aiik/views/View1_AssistedFactory_Factory.java:29: error: cannot find symbol
    return new View1_AssistedFactory(factory);
               ^
  symbol:   class View1_AssistedFactory
  location: class View1_AssistedFactory_Factory
9 errors

Rebuilding the project with --rerun-tasks fixes the issue.
It seems that the annotation processor fails to realize that files have moved around and the code has to be re-generated.

As discussed, we think this is a kapt bug and need to file it on http://kotl.in/issue and track changes there.

Reported to JB (https://youtrack.jetbrains.com/issue/KT-43155), closing this issue.


[ART-3383] Add check-bugs job + scheduled job

Look for potential blocker bugs and regressions of a given OCP version and communicate findings to ARTists on Slack.
Depends on https://github.com/openshift/elliott/pull/244 for check-regressions stage.
NOTE: requires real tests on buildvm. Since these jobs don't affect our release flow, I'd suggest we merge it rather sooner, and follow up on any issues that show up

yeah, let's follow up in subsequent PRs. merging this one now.


Import statement correction

@poojadas07 can you please try to make a separate new branch, that will help you to manage your commits and it will also a good open-source practice it will keep repo commit history clean. And having a separate branch will help you to go through your code changes in the future.
It is just a suggestion 😃. if you need any help in order to make a new branch feel free to ask.
you can also go through readme if you want to implement it.
Steps are mentioned in the readme as well.

Okay....next time I will do ....maybe I forget to change the branch.


SonarCloud code analysis configuration

Can we reevaluate/confirm the settings we apply for this? I notice "duplicated lines" failures for code under __tests__ directory and also "nested ternary" warnings. Do we want to keep both of these settings enabled?
I think we can overcome the code duplication for the tests by utilizing the wrapper config and creating more helper functions to abstract away the shared logic. Does it seem worth it? I don't want to over-abstract what should be simple test cases for sake of satisfying SonarCloud unless those decisions were made intentionally, in which case.. I'm happy to :D
Also, we use nested ternary pattern in multiple places in the codebase, doesn't seem that bad but again we can refactor those out or just drop that rule. Just wanted to bring it up for discussion, as you can see in the screenshot below SonarCloud can be quite picky about the checkstyle ;) .
It's not a problem, but if we're to continue enforcing these rules, maybe a good work item to capture would be to comb through the existing codebase for these issues and solve them in isolation so it doesn't unduly become part of other work items.

closing as new development is moving to:
https://github.com/kubev2v/forklift-console-plugin


Extracted archive storage integration test from ES and generalized to all storage backends

Which problem is this PR solving?

Resolves #5203

Description of the changes

Extracted archive storage Implementation from EasticSearch and move to common share suite and provide support to all storage backends

How was this change tested?

 make test

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

@yurishkuro  It's ready for review


server, client: allow using odd interleaved IDs

Fixes https://github.com/bluenviron/mediamtx/issues/1762

Codecov Report

Merging #304 (1b2d7c0) into main (6cdee49) will decrease coverage by 0.08%.
The diff coverage is 81.13%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   84.65%   84.57%   -0.08%
==========================================
  Files          99       99
  Lines       10164    10112      -52
==========================================
- Hits         8604     8552      -52
- Misses       1231     1232       +1
+ Partials      329      328       -1

Impacted Files
Coverage Δ

server.go
58.27% <ø> (-0.29%)
:arrow_down:

server_session.go
77.23% <61.53%> (-0.01%)
:arrow_down:

client.go
73.02% <82.35%> (+0.14%)
:arrow_up:

client_media.go
87.86% <83.33%> (-0.30%)
:arrow_down:

server_session_media.go
93.40% <86.66%> (-0.29%)
:arrow_down:

client_reader.go
94.87% <100.00%> (+4.30%)
:arrow_up:

client_udp_listener.go
75.89% <100.00%> (-3.62%)
:arrow_down:

server_conn_reader.go
97.46% <100.00%> (-0.26%)
:arrow_down:

server_stream.go
83.87% <100.00%> (ø)

server_udp_listener.go
76.51% <100.00%> (-1.76%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Convert repository to a monorepo

This package currently ships single package which is a Next.js template. On top of the Next.js template we want to serve a library that is added as a dependency in the Next.js template, so that we can ship updates in the future.
Proposed solution

Convert repository to a monorepo that contains two packages; next-acms and next-acms-basic-starter.
Publish both packages in npm.
Update commands in the README to match the new process.

What are examples of updates we might want to ship? This seems counter to what we initially set out to provide: a starter kit. While a starter kit is a starting point that you customize from, shipping a library makes projects dependent on it, its bugs, limitations and security flaws. This was why we wanted just a starter kit.

What are examples of updates we might want to ship?

An example of this might be if we need to provide Acquia specific developer tooling. For example, we moved the manual revalidation logic to next-acms so that it's possible to make it compatible with acquia_purge in future. Other examples could be tooling to integrate with Acquia Search.
I believe that the focus should be on the starter kit, even if we provide a package that provides some tooling to improve the developer experience.

Closing this since the repository has been converted into a monorepo. Feel free to open follow-up issues if there's any additional discussion that should take place. 👍


don't do Number on key when object=true

Following example:
unflatten(flat({
    'jazda': {
        '0000001': {'q': 1}
    }
}), {
    object: true
});

Outputs this:
{ jazda: { '1': { q: 1 } } }
But is expected to outputs this:
{ jazda: { '0000001': { q: 1 } } }
My patch makes flat works as expected in above example.
What do you think? Can it get merged?
Thanks.

That looks sensible. Can you add a test?

@kuebk bump

Closed in the pull request: #57


reduce ci cpus

8cores only reduced the build time by 3 minutes (from 11 to 8) so the default, single core will suffice

https://github.com/solo-io/squash/pull/124


Alt+W Close Prompt System Error

Description
Alt+W Closing the window will prompt Exception Processing Message 0xc000000 5- Unexpected
Parameters
Steps To Reproduce

Run Files
Alt+W

Requirements

e.g. Fix crash that occurs when...
Alt+W

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3086
Log File
2023-07-20 17:18:36.5970|Information|App launched. Launch args type: LaunchActivatedEventArgs
2023-07-20 17:18:36.9381|Information|Adding cloud provider "OneDrive" mapped to D:\LiShaoJun\OneDrive
2023-07-20 17:18:37.4571|Information|Drive added: A:, Network
2023-07-20 17:18:37.8626|Information|Drive added: C:, Fixed
2023-07-20 17:18:38.0237|Information|Drive added: D:, Fixed
2023-07-20 17:18:38.0551|Information|Drive added: E:, Fixed
2023-07-20 17:18:39.6626|Information|STORE: Checking for updates...
2023-07-20 17:18:40.2857|Information|Running on ARM: False

Thanks for the report, can you see if this is an issue in the preview version. https://files.community/download

I have found that I have the same problem. I am using the latest preview version and when I press ctrl + W to close a tab when only one tab is open, it will close the tab and open an error message even though nothing has gone wrong. Here's a screenshot of the error:

@JEAMLEAN Can you see if this is an issue in <IP_ADDRESS>

@JEAMLEAN Can you see if this is an issue in <IP_ADDRESS>

I personally still have the issue in this version.

@JEAMLEAN @SirEthanator I can't repro this in the latest preview, can you confirm if the issue is resolved in the latest preview build?

The issue no longer occurs for me.


test(CI): GEMC and gcard versioning

do not merge
this PR is for testing recent CI updates.

success


Please remove wrong warming

As we discussed https://github.com/MicrosoftDocs/azure-docs/issues/73748, AKS cluster supports the Azure Defender and Log analytics agent.

Can the customer use the Azure Defender and Log analytics agent? Yes.

Could you please remove wrong important warning as below? It cause confusion. Thank you.

Important
We don't currently support installation of the Log Analytics agent on Azure Kubernetes Service clusters that are running on virtual machine scale sets.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad7c05f1-f69c-c033-0409-39f5c8f03674
Version Independent ID: ebcceb7b-0d9c-618c-9576-b3b1713fe1ef
Content: Container security with Azure Security Center and Azure Defender
Content Source: articles/security-center/container-security.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@jyama4ta Thank you for pointing this out. We will investigate and update the thread.

@shashishailaj Is there any update? The statement is a security statement and is very sensitive. I hope it will be corrected quickly so that it is a consistent and accurate statement.

@jyama4ta My apologies for the delay on this. I have assigned this to the author for review and further action.

Hi @jyama4ta, thanks for the feedback and for taking the time to help us improve the docs.
We'll review this feedback and update this page according to what is decided.
I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
#please-close


[FEATURE] Support remote guardrails model

Is your feature request related to a problem?
Improve guardrails performance.
What solution would you like?
Call remote guardrails model to check user input and model output.
What alternatives have you considered?
We already have an alternative using stop words and regex to validate input/output.
Do you have any additional context?
None.

Do we have any design for that? For example, we will call it parallel when we using agent execute API? Can we design it as a function/method so I can reuse it in PPL Tool in skills repo?

Hi @xinyual , we plan to only add a new type for the current guardrail implementation. I believe you can reuse it for PPL tool, as it works on model level, runs in model prediction process. So it doesn't matter with agent execute API.


Add swagger for operations APIs

Add swagger for Microsoft.Resources, Microsoft.Solutions and Microsoft.Features operations APIs.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-libraries-for-java
Encountered a Subprocess error: (azure-libraries-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmppyl6q42i/rest/specification/resources/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmppyl6q42i/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:
AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4255)
   Loading AutoRest extension<EMAIL_ADDRESS>(~2.1.32->2.1.49)
   Loading AutoRest extension<EMAIL_ADDRESS>(2.3.38->2.3.38)
Processing batch task - {"tag":"package-features-2015-12"} .
FATAL: openapi-document/openapi-document-converter - FAILED
FATAL: Error: Could not resolve reference #/definitions/OperationDispaly
Process() cancelled due to exception : Could not resolve reference #/definitions/OperationDispaly
Failure during batch task - {"tag":"package-features-2015-12"} -- Error: Could not resolve reference #/definitions/OperationDispaly.
  Error: Could not resolve reference #/definitions/OperationDispaly

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

@zjpjack is this PR still valid? if so please address the comments. If you are planning to send different PR at later point please close this.

@zjpjack any update? if this PR is still valid please address the comments, If you are planning to send a different PR then we can close this.

@zjpjack closing this due to lack of response (~3 months). Feel free to open a new PR when you are ready to update the spec. thanks!

Automation for azure-sdk-for-ruby


Default to bonus city for refining

Adds a couple utils for determining production bonuses, and defaults to production bonus city when refining. I was a little confused by the logic in profit-tree so I didn't give it the same default treatment, I've left a comment on the bit I found confusing.
It looks like the linter also created some whitespace changes so I'd recommend hiding those when reviewing

Meanwhile, PR looks good, I'll take a better look after the New Year


Video section improve

Problem Statetement
The video section is now very simple and unorganized
Solution
I want to make the video section like a youtube clone type
Other alternatives can be considered
Any other original idea for this page can also be considerd
Directory
/Wezion/Travel/videos.html

would you like the design of the youtube homepage video collection and you want to implement that design on your populer video section ?

would you like the design of the youtube homepage video collection and you want to implement that design on your populer video section ?

Yes, I am assigning you these works

i would like to try that

i would like to try that

best of luck


PESQ Evaluation

Hi!
Thanks for your nice work! It helps me a lot. I have 2 questions:

How do you test the PESQ? I found that there are some differences between 'pypesq' and 'pseq' libs.

Do you have plan to open source the pre-trained model?

Thanks again for your time, looking forward to your reply.
Best regards

Hi Authors,
Thanks for nice work! Same question as @chrisole, can you open source the pre-trained model?
Best

HI @chrisole @YUCHEN005,
Thank you for your interest in CDiffuSE! Here are the CDiffuSE pre-trained models.
The large model is the same as described in the paper. The base model was trained without the mel-spectrum pre-training phase, which is a little better than the ones on the paper.
For PESQ, we use Matlab here to calculate the scores: PESQ and other objective measures for evaluating quality of speech processed by noise suppression algorithms. This calculates the wide-band PESQ, you can also try other python PESQ toolkits. Please let me know if you have any other questions!
Best regards

Thanks!


Use sphere to render sky background for performance

This PR drastically changes the way we render our background sky.
The original implementation implements this as a screen effect, i.e. a large square is rendered and we un-project screen coordinates to feed into our sky logic. This works great but has two drawbacks:

On stereoscopic rendering this introduces a rather expensive un-project step in the fragment shader
On mobile this prevents the ability to pre-fetch from textures when rendering a panoramic image

This PR changes the approach by using a sphere mesh to render the background with a number of values pre-calculated.
This allows for less expensive calculations that are all part of the vertex shader and a greatly simplified fragment shader.
This also results in panoramic sky being able to pre-fetch textures on mobile hardware.
Questions:

Should this be optional, where we let the user decide between the two options?
Should we change our logic when presenting a quad or half buffer and render that with a quad?
Should we add the ability for the user to also add logic to the vertex shader in case they want to output their own UVs?
Should we add quality settings for the sphere mesh, especially on high resolutions you may want a more detailed sphere, while on mobile devices we may want to decrease the polycount. Though due to the nature of this it's unlikely to have a lot of performance impact.

Todos:

Do benchmarking to see if this approach has the desired performance benefits, especially on mobile VR hardware where sky was underperforming greatly
Port to Gles3.

One other thing that we may need to think about whether we're happy with the change or want to revert, is that I moved more stuff into the UBO and out of the push constant.
This because we were pushing the same data over and over again for all the different stages of rendering the sky, I figured we were already sending the UBO through, this way we just store the data once. But I don't know if there is a performance penalty reading this data. Seeing its static I'm assuming the compiler is smart enough to cache this properly.
On that subject, we are using a single UBO, if we're rendering multiple viewports, could this cause issues with the UBO being overwritten? I remember Meta using that neat fact for spacewarp, where after building all the command buffers they sneakily last minute overwrite the scene UBO with new camera data right before submitting them.
I'm not sure what the impact here is but it would likely already have been a problem even before these changes.
@clayjohn @reduz any feedback at this point would be very welcome

With the headset configured for 72Hz, Godot got frame-rates of around 60FPS for both Vulkan and Compatibility.
Setting the headset for 90FPS dropped the Godot frame-rate to 45FPS for both Vulkan and Compatibility.
I did notice that when "Verbose stdout" is enabled, I get a stream of:
Vulkan: Early out of date swapchain, recreating.
Vulkan queue submit: Swapchain is suboptimal.
Vulkan queue submit: Swapchain is suboptimal.

This was actually firing under the Compatibility renderer.

This was actually firing under the Compatibility renderer.

Is there any chance that your rendering_method.mobile project settings is still set to mobile? It sounds like you may still be running the mobile renderer even though you selected gl_compatibility

This was actually firing under the Compatibility renderer.

Is there any chance that your rendering_method.mobile project settings is still set to mobile? It sounds like you may still be running the mobile renderer even though you selected gl_compatibility

Yeah that was what was happening, I was helping Malcolm over discord to try and figure some things out.
That said, the swapchain issues are Vulkan and are a worry. The problem we're having on Quest is that we create swapchains through OpenXR which are presented to the XR compositor, and then displayed on screen.
And Godot is still creating it's swapchains for the normal, now unused, rendering pipeline. It may very well be that which is causing these errors. @rbessems was commenting on that a little while ago and I'm about to push in a draft PR that has part of the solution for this.

Note also that i haven't ported anything to OpenGL around the sky logic yet.

Should we add quality settings for the sphere mesh, especially on high resolutions you may want a more detailed sphere, while on mobile devices we may want to decrease the polycount. Though due to the nature of this it's unlikely to have a lot of performance impact.

This could be computed automatically based on the the 3D render buffer size.

@Calinou cool tests! Yeah I would mainly expect an improvement on mobile, I don't think desktop, especially a 40 series Nvidia card, will bat an eyelid at this change. This would mostly be an improvement on mobile as your testing indicates, I think the biggest boost will be on Android based XR hardware.
Strange the orientation changed, I'll have to have a look at why. I did notice the original code here was a bit weird.

Note also that there is an argument here that the logic should be removed all together. The Sky rotate only makes sense for the panoramic sky and really should be embedded in the shader logic here.

In any case, custom FOV for sky still needs to be supported as orthographic mode relies on it to get a correct-looking sky (especially when the camera rotates).

In any case, custom FOV for sky rendering still needs to be supported as orthographic cameras rely on this property to get a correct-looking sky (especially when the camera rotates). See #9186.

I was wondering what the use case for that was, cool!


Update readme and changelog files for Dec release

I'll take this now so these files are up to date in the morning.  We can take additional changes if needed tomorrow.


Fix import order to accommodate pocoo style

Fix some import order

Thank you, but we don't accept style PRs.

Some imports follow PEP 8 style , but some are not.I think there should be a coherent import style,PEP 8 style or Pocoo Styleguide style.

https://github.com/pallets/flask/pull/1702#issuecomment-294037694

got it


Set up the project wiki

The wiki should contain the template of the datamanagement plan

Leo, thanks for your effort! Will be back in the office thursday. Shall we meet friday 18oohrs again?

Leo, thanks for your effort! Will be back in the office thursday. Shall we meet friday 18oohrs again?

Leo, thanks for your effort! Will be back in the office thursday. Shall we meet friday 18oohrs again?

No problem. I'm working late shift on Friday, so for me 5p.m. would be better because I have to do direct microscopies at 6. @Carmen-Haubold how are you scheduled on Friday?
Do we want to participate in the group discussion on Google Meet and if so, when is it?

Leo, thanks for your effort! Will be back in the office thursday. Shall we meet friday 18oohrs again?

No problem. I'm working late shift on Friday, so for me 5p.m. would be better because I have to do direct microscopies at 6. @Carmen-Haubold how are you scheduled on Friday?
Do we want to participate in the group discussion on Google Meet and if so, when is it?

Hi Leo,
am Freitag, um 17:00 Uhr, kann ich auch teilnehmen (keine Termine).
Gruß Carmen
Am Mi., 13. Jan. 2021 um 15:55 Uhr schrieb lknegendorf <
<EMAIL_ADDRESS>
Leo, thanks for your effort! Will be back in the office thursday. Shall we
meet friday 18oohrs again?
No problem. I'm working late shift on Friday, so for me 5p.m. would be
better because I have to do direct microscopies at 6. @Carmen-Haubold
https://github.com/Carmen-Haubold how are you scheduled on Friday?
Do we want to participate in the group discussion on Google Meet and if
so, when is it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fuenfgeld/ATeamDatenmanagementUndArchivierung/issues/5#issuecomment-759500786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASLT3LSKHRKH5NFUQZMIYT3SZWX4VANCNFSM4V7BNGIA
.

Hi Leo,
am Freitag, um 17:00 Uhr, kann ich auch teilnehmen (keine Termine).
Gruß Carmen
Am Mi., 13. Jan. 2021 um 15:55 Uhr schrieb lknegendorf <
<EMAIL_ADDRESS>
Leo, thanks for your effort! Will be back in the office thursday. Shall we
meet friday 18oohrs again?
No problem. I'm working late shift on Friday, so for me 5p.m. would be
better because I have to do direct microscopies at 6. @Carmen-Haubold
https://github.com/Carmen-Haubold how are you scheduled on Friday?
Do we want to participate in the group discussion on Google Meet and if
so, when is it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fuenfgeld/ATeamDatenmanagementUndArchivierung/issues/5#issuecomment-759500786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASLT3LSKHRKH5NFUQZMIYT3SZWX4VANCNFSM4V7BNGIA
.

wiki heute übersetzt 99% und Links genreriert. @lknegendorf close?

wiki heute übersetzt 99% und Links genreriert. @lknegendorf close?


fix: servicemonitor labels

fixes #626
fixes #820

Not an interesting PR to review imo, but important to release soon as half of otomi workloads are now not tracked!


decode payloads for multi point and example foreground background points

This adds prompting options for handling for multiple input points per one object (foreground only) and multiple points with one point per each object.
It also updates tests that show the expected return shapes and expected payloads for each type of prompt that is supported, see conftest.py
@Rub21 thanks a bunch for picking this back up! I moved much of the functionality to sam_serve/decode.py and updated the handlers accordingly. Can you give this a look and see if the new structure looks good?
still TODO

[ ]  support georeferencing multi point/multi object.

hey @Rub21, is it ok if I factor your multi point work here into the python module in #32 after #32 is merged? I can start a new smaller PR to complete that work.
I think it will be a cleaner way to handle the logic and allow this to be more easily tested locally.

hey @rbavery ,Sure , you can refactor the code 🚀 !!

Good to merge this PR!!


Not able to approve pending transaction

I run localhost:1234 on 2 browser clients in same machine. On one I create a user id, in other I try to login with the user id created in the first browser. I get pending authentication notification in the first browser - but I am not able to accept authentication. Attached is the browser console log

We can't reproduce. I propose following procedure:
Clean and do a full rebuild
./scripts/clean.sh
yarn
./scripts/travis.sh

Try running again (make sure you use new runner):
cd universal-login-example
yarn dev:start

And let us know if it worked.

It has been over a week with no response by issuer, I will close for now


Support for mapping created_at field to Hubspot

@kpthatsme @yakkomajuri  - Can you please take a look at this quick PR? This would address my issues

Looks good, just one minor suggestion

Great, thank you very much merging. Would it be deployed immediately for cloud PostHog version?

@oneshot-engineering I've just updated it on Cloud for everyone!


Not able to play song from document directory

Configuration
Run react-native info in your project and share the content.
What react-native-track-player version are you using?
I am using version 1.1.8
Issue
I have song on path "file:///data/user/0/com.cavary/files/144Maranamunundipranamunu.mp3"
but its not playing or not throwing any error
Code
componentDidMount()  {
RNFS.readDir(RNFS.DocumentDirectoryPath,'utf8').then((obj) => {
if(obj.length > 0){
this.setState({songs:obj})
}
})
}
var file_uri = "file://" + item.path;
TrackPlayer.setupPlayer().then(() => {
let track = { id:'try', url:file_uri,title:"try artist",artist:"artist"}
TrackPlayer.add([track]).then(function() {
console.log("Track Added Created")
TrackPlayer.play()
});
})

having the same issue here would like to see if there are any workaround or resolve to this issue

Which platform(s) are you testing on?

@astha-shah005
I think I may have a resolution to this issue
the track object url instead of passing a string, you should try to pass an object
 await PlayerManager.getInstance().addSong({
           id: uuid.v4(),
           url: {uri:"file://"+RNFS.DocumentDirectoryPath+"/songs/test.mp3"},
          })
 PlayerManager.getInstance().playSong()

the PlayerManager is just a wrapping to the track player library which is still in progress for my use, below is my current version of PlayerManager, still got lots of things to improve but at least it worked
import TrackPlayer from 'react-native-track-player'
import uuid from 'react-native-uuid'

export default class PlayerManager {
    static instance = null
    static getInstance() {
        if (PlayerManager.instance == null) {
            PlayerManager.instance = new PlayerManager()
        }
        return PlayerManager.instance
    }

    constructor() {
        this.ready = false
        TrackPlayer.setupPlayer().then(
            () => {
                this.ready = true
            }
        )
    }
    isReady() {
        return this.ready
    }

    //queueManagement

    async addSong(songs) {
        /*{
            id: 'trackId',
            url: require('track.mp3'),
            title: 'Track Title',
            artist: 'Track Artist',
            artwork: require('track.png')
        }*/
        console.log(songs)
        await TrackPlayer.add({
            id: songs.trackId?songs.trackId:uuid.v4(),
            url: songs.url,
            title: songs.title?songs.title:'unnamed',
            artist: songs.artist?songs.artist:'noname',
            //artwork: songs.artwork?require(songs.artwork):null
        })
    }
    getQueue(){
        return new Promise(async (resolve,reject)=>{
            var queue=await TrackPlayer.getQueue()
            resolve(queue)
        })
    }

    //PlayManagement
    playSong(){
        TrackPlayer.play()
    }
    pauseSong(){
        TrackPlayer.pause()
    }

}

at least this works for me
@curiousdustin  thank you of your quick reply and btw this is a very nice library
I am using
RN 0.62.2
react native track player 2.0.0-rc13
IOS 13.1
Xcode 11.3.1
MacOS Mojave 10.14.6

I know it's not the same version either of you have reported using.
However, on iOS, RNTP 1.2.2, I just tested the 3 ways of defining url's listed in the docs:
url: 'http://example.com/avaritia.mp3', // Load media from the network
url: require('./avaritia.ogg'), // Load media from the app bundle
url: 'file:///storage/sdcard0/Music/avaritia.wav' // Load media from the file system

All of these work for me in both debug and release builds.


Boolean field true to false in UI doesn't trigger save

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
I have a Boolean field and its default false. If I change to true (or checked or "on") the save button is blue and I can save the markdown file.
If I switch it back to false, there is no save - it remains disabled. I have to add a space character in another field to trigger the ability to save.
Reproduction
npx create-tina-app@latest
Steps to reproduce
My config field entry:
      {
        type: "boolean",
        name: "chooseimages",
        label: "Dont use folder - use this list below instead",
      },

System Info
System:
    OS: Windows 10 10.0.19045
    CPU: --
    Memory: 16.92 GB / 31.93 GB
  Binaries:
    Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.9.0 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Spartan (44.19041.3570.0), Chromium (118.0.2088.76)
    Internet Explorer: 11.0.19041.3570
  npmPackages:
    @tinacms/cli: ^1.5.31 => 1.5.31
    tinacms: ^1.5.22 => 1.5.22

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

@Kainkainkain I was not able to reproduce this issue.
See this video for more info: https://www.loom.com/share/e3205fcbe04d4ce2869b338e9d59492a


Add new processes to kill_remaining whitelist

While testing the deployment ansible script for disco, I discovered that service slicectrl stop was killing the python-ansible process running the command.
Added a TODO to really reconsider this function, since it is caused nothing but headaches.

This change is

LGTM


Question about how many points would be returned in offline map match

Hi, I want to know about that why does there exist some cases, which the number of input points is not equal to number of response points in offline matcher server. Are they not one-on-one relations?
Could you explain this situation for me?
Thank you!

In short, it's often necessary to clean the data because some samples simply don't make "sense" (to the map matching algorithm). For details, please check this comment: https://github.com/bmwcarit/barefoot/issues/92#issuecomment-371743778 Does it answer your question? If it's still unclear, please do not hesitate to ping me again. I will leave the issue open for that purpose. Feel free to close it once you feel that the question is answered.

Ok, I can understand it, thank you~
But I found another strange thing, just as following, a returned point (not the first point) lost its route attribute, what's wrong with it?
...
{"route":"LINESTRING<PHONE_NUMBER>0734922 30.70592250329085,<PHONE_NUMBER> 30.7058862,<PHONE_NUMBER>0476181 30.705830543062604)",
"road":5310,"heading":"forward",
"frac":0.013217474897863223},
{"road":17840,
"heading":"forward",
"frac":0.7255559289754527},
...

Can you please provide the respective input data? Also, which output format do you use?

Of course, the output format is slimjson.
The input data file as follows:
1.txt
Its corresponding output file as follows:
1.json.res.txt
You can find the lost attribute case above in this output file, it's the 81st element.

Thanks, that looks like an "HMM break", which means that the matcher couldn't find any route/transition for two consecutive samples as in your input data for the 80th and 81st sample. To confirm my assumption, please check the console output of the matcher, if it mentions an HMM break for exactly this trace. If that is the case, there is not that much that we can do except for fixing the map data or the road type configuration (which can be quite difficult and depends on country specifics and map data quality).


how to put page limit up to 3 pages?

I have issue that i want to give limit of 3 page. So, that user can only see 3 pages from whole document. And yes, also it could not download it or save it like,saved as have to be disabled.

There are plenty of way you can introduce these limits, but that's out of scope of this project. See e.g. src/display/api.js or modify the viewer files. Closing as answered.


Open AI Workspace Service

As per https://github.com/microsoft/AzureTRE/issues/3810 WIP for testing.
TODO:

[x] https://github.com/microsoft/terraform-azurerm-environment-configuration/issues/13
[ ] move dns zone to core array
[ ] add parameters for model being deployed
expose externally
[ ] store keys in keyvault,
[ ] ensure keys can be accessed from VM

Superseded by #3810


perhaps you could open a dialogue with Nomadic labs to establish some devops relationship to disambiguate the user experience ?

Hi! I think 10.3.1 you're referring to is actually v10.3-1, i.e. 'the first version of releases based on the upstream v10.3'. I hope that will help you disambiguate which release you need better!
However, Serokell does not have a role in managing the tezos-dev slack. Moreover, we handle Octez releases as they come out, and can't say how long a release is likely to persist as the most current one. As such, I'm closing this issue.
If you'd like to report another issue, please do so at the main repository, as this one is just a mirror and so isn't monitored closely.


Not working on Firefox : runtime is not defined

Type:

[x] bug
[ ] feature
[ ] enhancement
[ ] question

Environment:

OS: Ubuntu
Browser: Firefox 91.0.2
Library Version: 1.1.8

I'm going to open a PR:

[ ] yes
[x] no

Description:
I was using webpack 4 and the webpack-extension-reloader package and it was working well on Firefox. I decided to migrate to webpack 5 and to use this library instead of webpack-extension-reloader, but this library is not working on Firefox. The following error is reported by the browser console (Ctrl+Maj+J):
TypeError: runtime is undefined inject.js:1320:18
Thanks for your support.

Hey, apologize for the radio silence here. We are looking to push out a new update with all of these fixes. Would you have an example of where you are getting these issues?
It seems like we are no longer getting these errors in our workflows as of Firefox 94.0.1.

Hello, I can confirm that I still face the same issue in Firefox 94.0.1 with my extension (https://github.com/lmichelin/open-github-links-in-ide)
Steps to reproduce the issue:

Clone the repository https://github.com/lmichelin/open-github-links-in-ide
Run yarn to install the dependencies
Run yarn dev to start the development server
Launch Firefox
Open about:debugging#/runtime/this-firefox
Click on Load Temporary Add-on
Select the dist/firefox/manifest.json file
Open the browser console (Ctrl+Maj+J)
Open https://github.com/lmichelin/open-github-links-in-ide/pull/5
The following error is logged in the browser console TypeError: runtime is undefined inject.js:1320:18
The extension is not working (No IDE icons are injected when hovering on file numbers in comments)

Thanks for your support.

Sorry for the late response on this, happy to report that this has been fixed and will be shipped in the next version: v1.1.9.

I can confirm that it works, thanks for your support! 🎉


Select options in order.

How can I view the values of the selected options in order properly?
I used the the changed.bs.select function to do this. Please help me.
For example:
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>

My selection sequence is 2, 3, 1.
I want to get the val() of ["2", "3", "1"] but it gives me ["1", "2", "3"].
$('#myselect').on('changed.bs.select', function () {
    alert($(this).val());
});

I saw in this [link] (https://github.com/silviomoreto/bootstrap-select/issues/603) that this is possible.
This issue was archived but I don't know how to do it. Thank you in advance.

changed.bs.select passes through event, clickedIndex, newValue, oldValue. true if selected and false if not selected
$('#myselect').on('changed.bs.select', function (event, clickedIndex) {
    alert(clickedIndex);
});

You can use that to determine the order of selected options. val() is a jQuery function and is not affected by bootstrap-select.


Dont restore backup

System information:

Operating system (distribution) and version, Linux mint 19.1 mate 64 bits
DBeaver version,  6.3.2
Additional extensions

Connection specification:

Database name and version , PostgreSql 9.3
Driver name. PostgreSQL JDBC Driver
Do you use tunnels or proxies (SSH, SOCKS, etc)? use ssh tunnel

Describe the problem you're observing:
At restore backup do not take  database restore path
Steps to reproduce, if exist:
1-  Generate backup to de local database
2 - Restore backup to remote database
Include any warning/errors/backtraces from the logs

Data transfer failed
Razón:
Error executing process

I downgrade to 6.2.2 version

I believe we already fixed this in some other ticket.
Could you test it Early Access version? (https://dbeaver.io/files/ea)


Prevent worker wrapper exception when Project.project_details was already NULL

When using update_fields and there are no modified rows, django will throw an error.

Task linked: QF-2491 Prevent update_fields exception if the Project.project_details is already null.


How to publish on topic and comunicate with clients from broker?

How to publish on topic and comunicate with clients from broker?
I use the latest MQTTNet version.

Please check sample "Publish_Message_From_Broker" in "Samples" directory. Please keep in mind that client still must subscribe to the respective topic first. A direct communication is not possible in MQTT (as @MD-V already explained).

is it possible to detect when the message publish was not delivered to the client/had any faults ? a look at the source suggest no such exception will be thrown after a call to InjectApplicationMessage
https://github.com/dotnet/MQTTnet/blob/e33495010e185de7e77c95b12db50c554c25f425/Source/MQTTnet/Server/Internal/MqttClientSessionsManager.cs#L132
will ApplicationMessageNotConsumedAsync event suitable for detect a faulty delivery ? is this event triggered after a delivery was unsuccessful?
many thanks

Please check sample "Publish_Message_From_Broker" in "Samples" directory. Please keep in mind that client still must subscribe to the respective topic first. A direct communication is not possible in MQTT (as @MD-V already explained).

That sample doesn't seem to be there anymore. Any other examples for doing this?

Please check sample "Publish_Message_From_Broker" in "Samples" directory. Please keep in mind that client still must subscribe to the respective topic first. A direct communication is not possible in MQTT (as @MD-V already explained).

That sample doesn't seem to be there anymore. Any other examples for doing this?

It's here: https://github.com/dotnet/MQTTnet/blob/41d5b703441b9f2f1adf3887f22e51faafc4c58e/Samples/Server/Server_Simple_Samples.cs#L39


output: detach buffer from renderer before commit

Right now we rely entirely on implicit sync for synchronizing
access to GPU buffers. Implicit sync works by setting
synchronization points on the buffer in writers, and letting
readers wait on these sync points before accessing the buffer.
With OpenGL, sync points are created using functions such as
eglSwapBuffers or glFlush. If none of these special functions
are called, no sync point will be created and readers will
potentially access a buffer that hasn't finished rendering yet.
In the context of wlroots, OpenGL is the writer and the backend
(KMS or parent Wayland/X11 session) is the reader. After we're
done rendering a frame, and before passing that frame to the
backend, we need to call glFlush.
glFlush is called when the buffer is detached from the renderer.
This is a task done by output_clear_back_buffer. So let's call
this function before invoking the impl->commit hook, instead of
calling it after.
All of this is maybe a little tricky to get right with the
current renderer_bind_buffer API. The new
wlr_renderer_begin_with_buffer API is much better, because glFlush
is called on wlr_renderer_end, so it's more intuitive.
Closes: https://github.com/swaywm/wlroots/issues/3020

Thanks for your work!

LGTM thanks!


Getting 'NotFound' error

Hope your issue is resolved. If not, please share the link to the document and i will direct it to the right team.


Preserve non-null comparison column values during segment commit

This PR completes the bug fix introduced with https://github.com/apache/pinot/pull/10704
With the fix introduced previously, although we merge the comparison column values, we still mark the original columns as null in the bitmap so that it can help during restart.
However, during the segment build, we simply filter out all the columns which have null set in the bitmap and thus we lose all these values.
Reproducing the bug

create a partital upsert table with two comparison columns mtime and mtime_2

publish the following two records to the table

{ "rsvp_count": 23, "venue_name": "Venue A", "event_id": "E12345", "event_time":<PHONE_NUMBER>422, "group_city": "San Francisco", "group_country": "USA", "group_id":<PHONE_NUMBER>, "group_name": "OpenAI enthusiasts", "group_lat": 37.7749, "group_lon": -122.4194, "mtime_2":<PHONE_NUMBER>322 }

{ "rsvp_count": 23, "venue_name": "Venue A", "event_id": "E12345", "event_time":<PHONE_NUMBER>422, "group_city": "San Francisco", "group_country": "USA", "group_id":<PHONE_NUMBER>, "group_name": "OpenAI enthusiasts", "group_lat": 37.7749, "group_lon": -122.4194, "mtime":<PHONE_NUMBER>100 }

verify the records are showing up correctly in the table. Then do either reload or force commit.

You will see that no records show up in the table now. If you use skipUpsert(true) though, you will be able to see everything

Codecov Report

Merging #11027 (8a5299f) into master (0821e3b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #11027     +/-   ##
=========================================
  Coverage    0.11%    0.11%
=========================================
  Files        2197     2145     -52
  Lines      118596   116241   -2355
  Branches    17980    17715    -265
=========================================
  Hits          137      137
+ Misses     118439   116084   -2355
  Partials       20       20

Flag
Coverage Δ

integration1temurin11
?

integration1temurin17
?

integration1temurin20
?

integration2temurin11
?

integration2temurin17
?

integration2temurin20
?

unittests1temurin11
?

unittests1temurin17
?

unittests1temurin20
?

unittests2temurin11
0.11% <0.00%> (-0.01%)
:arrow_down:

unittests2temurin17
?

unittests2temurin20
0.11% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...local/indexsegment/mutable/MutableSegmentImpl.java
0.00% <0.00%> (ø)

...ocal/segment/readers/PinotSegmentRecordReader.java
0.00% <0.00%> (ø)

...ava/org/apache/pinot/segment/spi/IndexSegment.java
0.00% <0.00%> (ø)

... and 59 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I don't follow the special handling of comparison column (still treating them as null value) in #10704, and I feel we should just remove that special handling. Handling it in record reader is a very hacky solution.
cc @egalpin for more context on that special handling

The motivation behind wanting to keep nullness encoded is being able to easily discern between a defaultValue representation of null Vs. an actual null so that comparing 2 defaultValues would not result in a comparison result of 0 therefore triggering upsert.
I don't feel that this is a required "guard" anymore though; it may have been needed at one point but the various algorithms for multiple comparison column upsert have changed a lot throughout implementation.  We guard against any newly ingested record having all null comparison columns[1], so by the time we reach compareTo the values being compared would "at worst" be <defaultValue> of the previously ingested record and the non-null value (i.e. non-defaultValue) of the newly ingested record. Such a comparison would have the same result as the current implementation (current implementation checks if the previous record's value for the same comparison index is null and if so accepts the new record as a valid upsert).
All that said though, if we don't encode nullness then we lose the ability to perform valuable queries like "show me all records that have null comparisonColumnX" (i.e. "show me all records which have never had data written by a producer that uses comparisonColumnX).
[1] https://github.com/egalpin/pinot/blob/68fdfa4a12926c7ce45dadc6a86d973ce5ff3669/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java#L597 ( -> this method has move, I think as of https://github.com/apache/pinot/pull/10703)

Picked the solution in #11044


Ignore fields added in the new SDK version

Issue #, if available:
Description of changes:
https://github.com/aws-controllers-k8s/elasticache-controller/pull/137 added support for the CacheCluster resource but left ignoring newly added fields for later. This changelist adds unsupported fields to the list of fields to ignore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test

/retest

@cPu1 looks like the controller isn't compiling, can you PTAL?

@cPu1 looks like the controller isn't compiling, can you PTAL?

Sure, please give me some time. I am juggling between a few tasks at the moment.

/retest

/retest

/retest

/lgtm

/lgtm cancel

@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking  the 0.38.0 runtime patch

@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch

@a-hilaly, sure, I'll look into it. That failing test should be unaffected by the changes introduced in this PR, but I'll see how best to resolve it.

/retest


Add limit for trakt_list

Motivation for changes:
Currently lists popular and trending produce TONS of items, and you need to do additional magic to get just TOP10 or so.
Detailed changes:

added limit configuration parameter into trakt_list

@gazpachoking sorry for poking you, can you please take a look at this one?

Thanks for this. A couple things I noticed:

I don't think it will break out of the pagination loop when we hit our entry limit as-is. It will keep looping through the extra pages doing nothing.
I'm wondering if we should have a limit by default for the popular/trending lists... My only hesitation there is that it might be confusing that those get limited by default but other lists don't. I'm also not sure what a reasonable default number would be.

You're absolutely right — it will not break the pagination loop, but it's kind-a fine in current implementation, because processing of gathered data is done in another loop, and there is a chance that not all items would be converted to flexget's entries (see https://github.com/Flexget/Flexget/blob/develop/flexget/components/trakt/trakt_list.py#L264 and https://github.com/Flexget/Flexget/blob/develop/flexget/components/trakt/trakt_list.py#L324).

I think the proper way for now is not to set any default limits, but just amend wiki page for trakt_list, to add a note that popular/trending lists are huge, and it's reasonable to set a limit when using them.

How many entries do the popular/trending lists normally have?

Right now it's 778 movies for each popular and trending. But when I've started my changes — there were something like 1300 items in each of them.

Cool, I'm good with this as is then. We should definitely update the wiki page with the limit option and mention it's probably wanted in any situation using popular/trending lists. If we end up deciding there should be a default limit later we can always add it. Pagination optimization probably isn't worth it given that we request 1000 items per page.

Thanks! I've updated the trakt_list wiki.

There is currently 160,121 items in the popular movies list, with the 2 second limit, that's over 5 minutes to fetch the list. Would be really nice if it broke out of the pagination loop. Should I put in a separate issue?
2019-05-08 14:34 VERBOSE  trakt_list    Auto-Movies     Retrieving `movies` list `popular`
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, u'timeout': 30}
2019-05-08 14:34 DEBUG    trakt_list    Auto-Movies     Response is paginated. Number of items: 160121, number of pages: 161.0
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.91 seconds until next request to trakt.tv
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, 'params': {u'limit': 1000, u'page': 1}, u'timeout': 30}
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.95 seconds until next request to trakt.tv
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, 'params': {u'limit': 1000, u'page': 2}, u'timeout': 30}
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.96 seconds until next request to trakt.tv
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, 'params': {u'limit': 1000, u'page': 3}, u'timeout': 30}
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.94 seconds until next request to trakt.tv
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, 'params': {u'limit': 1000, u'page': 4}, u'timeout': 30}
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.96 seconds until next request to trakt.tv
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     GETing URL https://api.trakt.tv/movies/popular with args () and kwargs {'allow_redirects': True, 'params': {u'limit': 1000, u'page': 5}, u'timeout': 30}
2019-05-08 14:34 DEBUG    utils.requests Auto-Movies     Waiting 1.96 seconds until next request to trakt.tv

160k!  Please, create another issue, I'll be able to take a look at this in a few weeks. Probably it'll require some refactoring.

Ohhh. Yeah, let's make a separate issue since this is merged. If there are that many in the list, I reverse my stance on both of those points above. I think we should both stop the pagination loop early, as well as institute a default limit when either of these big lists are specified.


[Bug]:No module named 'agentscope.web.studio.studio'

AgentScope is an open-source project. To involve a broader community, we recommend asking your questions in English.
Describe the bug
Traceback (most recent call last):
File "D:\anaconda3\envs\agentscope\lib\runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "D:\anaconda3\envs\agentscope\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "D:\anaconda3\envs\agentscope\Scripts\as_studio.exe_main.py", line 4, in
from agentscope.web.studio.studio import run_app
ModuleNotFoundError: No module named 'agentscope.web.studio.studio'

The agentscope.web.studio module is already removed in the newest version, please reinstall AgentScope using pip install -e .

Thanks for the answer.


Extend IndexRange

I recently made an object to represent a range of index values
public readonly struct IndexRange(int index1, int index2)
{
    public int Index1 { get; } = index1;
    public int Index2 { get; } = index2;
    public int MinIndex => Math.Min(Index1, Index2);
    public int MaxIndex => Math.Max(Index1, Index2);
    public IndexRange Rectified => new(MinIndex, MaxIndex);
}

...and I noticed ScottPlot already has some really similar primitives, IndexRange and Range
It may be a good time to take a closer look at those and make sure they're working as intended and expressive, as well as adding tests to document and lock-in the behavior.

I proposed an addition to IndexRange in my PR : #4270  where the Length property is set to 0;
/// <summary>
/// The IndexRange that represents an empty collection
/// </summary>
public static readonly IndexRange None = new(-1, -1);

My PR also introduced this utility method to a DataSourceUtilities class:
public static IndexRange GetRenderIndexRange(this IDataSource dataSource)
{
    if (dataSource is null || dataSource.Length == 0) return IndexRange.None;
    int min = Math.Min(dataSource.Length - 1, dataSource.MinRenderIndex);
    int max = Math.Min(dataSource.Length - 1, dataSource.MaxRenderIndex);
    if (min > max || min < 0 || max < 0) return IndexRange.None;
    return new IndexRange(min, max);
}

While writing that PR, I also realized that the Min/Max index properties do not validate typically. Meanings Max may be less than Min, but also either one may be negative, which would result in an ArgumentOutOfRangeException Further, a negative Min would be additive to the specified Max when calculating the length.
Due to how record structs initialize when they have a primary constructor, my thoughts were to either remove the primary constructor in favor of a normal one, and perform validation (and length calculation) within that, or do some workaround like this:
public int Length { get; } = Validate(Min, Max);

/// <summary>
/// <see langword="true"/> if the Min & Max represent valid indexes, otherwise <see langword="false"/>
/// </summary>
public bool IsValid => Min >= 0;
private static int Validate(int Min, int Max)
{
    if (Min == Max && Min == -1) return 0; // special case

    if (Min < 0) throw new ArgumentException($"{nameof(IndexRange.Min)} must be at least 0", nameof(IndexRange.Min));
    if (Max < Min) throw new ArgumentException($"{nameof(IndexRange.Max)} cannot be less than {nameof(IndexRange.Min)}", nameof(IndexRange.Max));
    return Max - Min + 1;
}

After further testing and the other work (the PRs merged today) I think the new IsValid check suffices here instead of complicating the construction of the object. (Especially since SignalXY could produce an exception give my above example code, when there actually is no issue with code that follows since IsValid =false in that scenario.)


[#17] Upgrade gravitino version 0.3.1

Gravitino 0.3.1 is released. We upgrade the version of playground. This version fixed many issues. You can see the release note. https://github.com/datastrato/gravitino/releases/tag/v0.3.1

LGTM.


updating quickstart to make commands more obvious

As I was reading through the Quickstart, I was confused about how the second node was connecting.  It took a while for me to spot where the other command to run it was.
I just put an empty line between each command to make it clearer to those reading what the expected commands and results are.

Thanks!


Text doubles up like so: IllinIllinois

It's supposed to say Illinois when I press my keys. Now every shortcut I have doubles up like this. Please fix this. I use this daily and now it's worthless.

I see the dev doesn't care.  You'd think as a dev fixing bugs that make your script completely useless for people would be something you'd care about. Guess not.

I'm not sure if this is the same issue, but I did just see something similar.
This is one of my shortcuts:
/COMMENT  ➜  /*-----  -----*/
What I typed was something like this:
/COMMEM  ➜  [delete]  ➜  NT
To my surprise, the shortcut triggered, but produced this:
/COMME/*-----  -----*/


[Question] How to deploy a L1 Script referenced by Type?

As per title, I'm wondering: how to deploy with Lumos a L1 script that will be referenced by Type?
As usual I'm asking here since GitHub issues are SEO friendly and very likely in the future there will be other L1 developers wondering the same :wink:
Phroi

@phroi Hi, we've created an example https://github.com/ckb-js/lumos/pull/639/ to show how to use the generateDeployWithTypeIdTx API

Now I even remember finding this method a few months ago and being confused on how to use it :sweat:
With your example, it makes much more sense!! Now that I took a look at the deploy implementation, I notice that you may want to export the interfaces, otherwise in the docs options type is not clickable and not documented in any way.
Thanks again for taking your time to reply!! :pray:

Hi, @phroi, I noticed that the Fixes #x mark in the PR description closed this issue automatically, please feel free to reopen this issue when you have any question about deploying scripts with TypeID.


Pre-trained model performance.

Is the model uploaded here for text detection the best model that was trained or does the demo site ->https://demo.ocr.clova.ai/, have a better model trained on a larger data-set

asked the same question in #7


ddcci-driver: Module ddcci not found

Describe the bug
After installing linuxPackages.ddcci-driver, the ddcci module cannot be loaded.
Steps To Reproduce
Steps to reproduce the behavior:

Install linuxPackages.ddcci-driver
Run modprobe ddcci with appropriate privileges
Output:

modprobe: FATAL: Module ddcci not found in directory /run/current-system/kernel-modules/lib/modules/5.10.60

Expected behavior
Module should be loadable.
Additional context
After installing, I have these paths:
/nix/store/ni54gw7vhlz56jqzjjhpj8j79a9vp7by-ddcci-driver-5.10.60-0.3.3
├── include
│   └── linux
│       └── ddcci.h
└── lib
    └── modules
        └── 5.10.60
            └── extra
                ├── ddcci-backlight.ko
                └── ddcci.ko

Both of those .ko files appear to end up at /run/current-system/sw/lib/modules/5.10.60/extra/. This seems to be the wrong place though; my other modules seem to be in /run/current-system/kernel-modules/lib/modules/5.10.60/kernel/, which has modules in subdirectories, like arch/x86/crypto/des3_ede-x86_64.ko.xz and drivers/vdpa/vdpa.ko.xz. They're all xz-compressed like that.
As an aside, this package appears to be out of date; upstream released 0.4.1 a couple weeks ago.
Notify maintainers
@bricewge
Metadata
[arob@icarus:/run/current-system]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.60, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - channels(root): `"nixos-21.11pre311431.88226ea038e, nixos-hardware"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

kernel module packages should be put in extraModulePackages
boot.extraModulePackages = with config.boot.kernelPackages; [ ddcci-driver ];

Oh, you're right. I had no idea that kernel module packages needed to be installed differently, so I didn't even search for that.
Thanks