Regex not taken into account

Expected Behavior
Hi everyone,
I wanted to simplify my commands on Annyang using regex but I have some issues. on my first version I wrote every commands (sorry it's in French but it doesn't matter is this issue):
'jarvis news de France': newsapijson,
'jarvis nouvelles de France': newsapijson,
'jarvis actualité de France': newsapijson,
'jarvis *search': searchapi
=> It worked fine
But when I simplify using regex :
'jarvis news de France': {'regexp': /^(?:news|nouvelles|actualité) (\w*)$/, 'callback': newsapijson},
'jarvis *search': searchapi
It doesn't match with regex commands. I tried without accent but it still not working.
Did I miss something ?
Your Environment

Version used: annyang.min.js version 2.6.1
Browser Name and version: Chrome and Chrome Android
Operating System and version (desktop or mobile): Windows 10 / Android

The problem seems to be that the regex you created doesn't capture the sentences you say. That has nothing to do with annyang.
Try running /^(?:news|nouvelles|actualité) (\w*)$/.test('jarvis news de France') in your console and you'll see that it returns false (no match).
Try this instead:
/^jarvis (?:news|nouvelles|actualité) ([\w\s]*)$/.exec('jarvis nouvelles de France')


Remove whisper imports from carbon (partial revert of #576)

FYI @obfuscurity.  Partial revert of #576.
The whisper is config handling is found here https://github.com/graphite-project/carbon/blob/a8435b0e68ddfd8181113f18cb44c9c1adcce914/lib/carbon/database.py#L67-L96
Let's see how long until another whisper import creeps back into carbon (other than in carbon.database :-)

Gah, thanks for that @iain-buclaw-sociomantic. Not sure how I missed those, I'm certain I did a git grep looking for those settings.

@iksaif - I'm all ears on that.  So far the abstraction seems sufficient enough.


Pagination offset is 1 instead of being configurable

I just configured my tap to use offset_paginator style:
  next_page_token_path: $
  pagination_request_style: offset_paginator
  pagination_response_style: style1
  pagination_page_size: 100
  pagination_total_limit_param: totalCount
  store_raw_json_message: false
  backoff_type: header
  backoff_param: ratelimit-reset

But i discovered that the first item was never returned.
After asking for help on slack, I was informed that the 1 value (first offset) seems to be hardcoded here:
https://github.com/Widen/tap-rest-api-msdk/blob/4f87c1adae00446388ebbe418c70b87c231856dc/tap_rest_api_msdk/streams.py#L306
Could you fix it by making this value configurable? (I tested it locally by changing the value to 0 and it worked.)

It worked as expected after setting the variable pagination_initial_offset to 0.


devcam hook: broken with git commit --amend

$ git commit --amend internal/geocode/geocode.go server/perkeepd/perkeepd.go
fatal: There is nothing to exclude from by :(exclude) patterns.
Perhaps you forgot to add either ':/' or '.' ?
Trailing whitespace detected, you need to clean it up manually.
Bug most likely introduced at https://perkeep-review.googlesource.com/c/perkeep/+/17146

@euank Please let me know if you want to look into fixing it. Otherwise I'll just revert it, and fix it properly later.

What version of git are you using, @mpl? git commit --amend works fine for me with using those hooks on master.

@euank yeah, I'm on git version 1.9.1

@euank no harm done (I just reverted the change locally so I could keep on working yesterday), so no worries.


Setup mongo replication

Changes:

Update to Rocket.Chat version 1.0.3
Enable replication by default

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 38 committers have signed the CLA.:white_check_mark: LuluGO:x: shawnzhu:x: hulkish:x: jaypatrickhoward:x: asandnes:x: jbialy:x: torstenwalter:x: k1-hedayati:x: skang0601:x: out-of-band:x: ServerlessP:x: solongordon:x: bitnami-bot:x: nicholascapo:x: swade1987:x: ChristianMoesl:x: lee0c:x: naseemkullah:x: runningman84:x: nbkrause:x: darkgerm:x: mehstg:x: hbagdi:x: kflynn:x: yuchaoran2011:x: christianhuening:x: Janesee3:x: juan131:x: schnatterer:x: paulobezerr:x: dansible:x: guessi:x: codepitbull:x: mdonkers:x: nrb:x: HNicolas:x: max-rocket-internet:x: kel00sYou have signed the CLA already but the status is still pending? Let us recheck it.


Add pagination tests + fix pagination

Why do you name the variables algolia... in your tests, like algoliaNumberPagesBehavior? I understand this is a list for our tests with the parameters and the expected return. No need to mention algolia, right?

Okey! Since it was the behavior of Algolia I thought why not name it like that but I understand your point.

bors merge


Create mappings to lua functions directly

One thing that i'm really missing is a way to map stuff to lua functions directly, rather than going through luaeval.
Specifically, as i'm using fennel (transpile to lua), this is a big missing feature.
From what I've seen, the best way to implement this would be to store the functions that are provided in some table by ID, and then generate mappings that call that table ID.
This would be a big improvement to config and usability here ^^

Great idea!

Implemented 😄

Nice! Thanks!


Allow reading Avro enums as strings

We have many datasets in our org which have Avro enum types. Although Iceberg does not support enums directly, can we allow reading existing Avro enums as strings in Iceberg?

@rdblue Thoughts on this?

Sounds reasonable to me. Want to work on a PR?


Feature demand: export PDF with watermark

Hi, I wonder if it's planed to have feature that export PDF with watermark?
Sometimes I wanna export some of my notes to other, and I want to add some watermark such as the author name(my name), created time, etc.
I'd appreciated it if you want to impl this feature, or anyone who can do it.
If this feature is not planed to impl, I think I may try my best to do it myself, then could anyone give me some guidance or suggestion that how can I do to do so?
I've tried to use the sample plugin from Obsidian to do this, but I got stuck at exporting PDF :(
Is there a simplest way to export PDF ?  maybe there're some API from Obsidian that I can call ?
I asked for help on Discord, but got no reply
sorry if I bother you

You can achieve a watermark-like effect by adding HTML snippets in the document and supplementing them with custom CSS snippets.
your-note.md:

Your Watermark Text

## Title 1
main content

css snippets watermark.css:
.watermark {
  display: none;
}

@media print {
  .watermark {
    page-break-after: always;
    display: block;
    position: fixed;
    top: 50%;
    left: 50%;
    transform: translate(-50%, -50%);
    font-size: 24px;
    color: rgba(0, 0, 0, 0.1);
    pointer-events: none;
    page-break-after: always;
  }
}

If you only want to add author, time, and similar information, you can use the pdf metadata feature.

If you want to implement this feature from scratch to allow for more customization options, regarding PDF export, my general idea is to render the Markdown content myself. At the HTML level, I can handle some logic, then copy the content into a webview tag and call the webview.printToPDF function. Finally, I can make some modifications to the PDF file.

Oh, I really appreciate that. Thank you very much for your hospitality
I'll try my best to do so


Warning in Environment API docs is outdated

Documentation is

[ ] Missing
[X] Outdated
[ ] Confusing
[ ] Not sure?

Explain in Detail
Warning in Environment API docs is outdated. Vite@6 is already released.
Your Suggestion for Changes
Make warning message updated.
Reproduction
No response
Steps to reproduce
No response

Please hand it over to me


Refactor

Continuation of this: https://github.com/yegor256/apex2www/pull/39
All CI checks passed on my end. https://github.com/DIY0R/apex2www/pull/2/checks

@yegor256 Please review the PR when you have a moment. Thank you!

@DIY0R thanks for the contribution! The build is not green. Can you please fix it before the review?

@yegor256 It seems the problem is on your side, everything is fine on mine(https://github.com/DIY0R/apex2www/pull/2)


No horizontal scrolling for selected 'PTT User Accounts' in Create Modify Contact List.(Company Panel)

Describe the bug
No horizontal scrolling for selected 'PTT User Accounts' in Create Modify Contact List.(see the attached screenshots)
To Reproduce
Steps to reproduce the behavior:
1.Enter in the address bar-pulseptt.com
2.Login With Id and Password.
UserName-tata
Password-12345678
3.Click On 'Modify Contact List' .
Expected behavior
horizontal scrolling for selected 'PTT User Accounts' in Modify Contact List must be present.
Desktop (please complete the following information):
OS: Windows 10
Browser: Version 100.0.4896.60 (Official Build) (64-bit)
Version: [<IP_ADDRESS>]

clicking on 'Select Contact-List' or 'PTT User Accounts' page turns into Blank.


Errors with Hg Bidirectional Flux Simulations

Description
CMAQ simulations for mercury with the CTM_HGBIDI option set to T will fail due to two issues in the current CMAQ code except for when using the STAGE dry deposition option for a single day simulation.  The first issue affects only the M3Dry dry deposition option and causes a model crash if CTM_HGBIDI is set to T but CTM_ABFLUX (bidirectional flux option for NH3) is set to F. The second issue affects both the M3Dry and STAGE dry deposition options and leads to a model crash on the second day of the simulation when using a MEDIA_CONC restart file.
Scope and Impact
The current CMAQ code with not complete successfully for mercury simulations with the CTM_HGBIDI option set to T for multi-day simulations for both the M3Dry and STAGE dry deposition options. For M3Dry, the code will not complete successfully even on the first day of the simulation unless the CTM_ABFLUX is also set to T.
Solution
The first issue is caused by the land use fraction array needed by the Hg bidirectional calculations not being allocated and assigned a value in the M3Dry version of ASX_DATA_MOD.F. To fix this issue, change these statements on lines 557 and 638 from
   If ( ABFLUX) Then

To
   If ( ABFLUX .or. HGBIDI ) Then

The second issue is caused by subroutine INIT_BIDI in BIDI_MOD.F being called twice in both M3Dry and STAGE, leading to a duplicate allocation error. To fix this issue, the beginning of that subroutine should be modified as follows:
Current code (lines 75 – 80 in the M3Dry version of BIDI_MOD.F):
     Integer         :: STATUS

    C--------------------------------------------------------------------------
     ! Set Mercury BiDi Processing Flag equal to false if there is
     ! no mercury gas-phase species.
     If ( INDEX1( 'HG', N_GC_DDEP, GC_DDEP ) .EQ. 0 ) HGBIDI = .FALSE.

Updated code:
     Integer         :: STATUS
     Logical, SAVE   :: INITIALIZED = .FALSE.

     C--------------------------------------------------------------------------
     C Prevent initilializing the code twice
     If ( INITIALIZED ) Return

     INITIALIZED = .TRUE.

     ! Set Mercury BiDi Processing Flag equal to false if there is
     ! no mercury gas-phase species.
     If ( INDEX1( 'HG', N_GC_DDEP, GC_DDEP ) .EQ. 0 ) HGBIDI = .FALSE.

For STAGE, corresponding changes would have to be made in lines 73 – 76 of the STAGE version of BIDI_MOD.F
Additional context
These issues will be fixed in the next release of CMAQ.

This issue is resolved with the release of CMAQv5.4.


PureRef out of date

Latest PureRef version is 1.11.1 (released in 2020)
The scoop version is 1.9.2 (released in 2017)

PureRef requires you to pay before downloading it.
Version 1.9.2 is the last version that you can download for free.
For details, check: https://www.pureref.com/download.php

You don't have to pay, you can just type 0 in the custom amount

You don't have to pay, you can just type 0 in the custom amount

Ok. Thanks for the info.


[DRAFT] DDS Custom Streams

posting this up as a draft to get feedback from Ben before finishing the tests

@CoderDake is this still being worked on ?

This is done thank you for pointing out this was left open


Remove dead Casks

Using the very handy brew cask _stanza command, a simple bash script, the brew cask fetch command and then investigating each problem Cask individually, I have determined the following 17 Casks are dead.

Ping @caskroom/maintainers


Add metric/alarm on max file size

Intellij won't analyze any files >2.56MB by default—currently this is a problem for ec2/src/client.rs. We should:

[ ] track the max file size
[ ] send ourselves a soft-alert if it ever goes above this limit
[x] split the fluent builders out of client.rs to reduce that specific issue

now that we can easily create submodules in their own files, this should be pretty easy to fix

I think this is unlikely to be an issue again since codegen was refactored to put everything in its own module. However, it wouldn't hurt to have a file size check.


Is activeTab permission necessary?

I've seen the documentation at https://developer.chrome.com/extensions/activeTab, but I can't figure out why this permission would be necessary.

From https://github.com/harshjv/github-repo-size/pull/17#issuecomment-279042619 :

Actually, I was experimenting with tabs.executeScript but I ended up using prompt in background script and removed tabs.executeScript, but forgot to remove activeTab permission.

It's not necessary.


Taking so much time when we Added new shard to running Clickhouse installation

my configuration is
shard count: 2
replica count: 2
working fine all shards are running
Added one  more shard  to running installation
shard count: 3
replica count: 2
why already running pods or shards  are going into pending state?
Taking too much time it is showing in progress.
Currently i have five Nodes in place.
I also have the required PV's in place.
Requirement:

Can i increase shard count in running clickhouse installation.
Is there any podDistribution which can distribute shards to all different nodes

Should be fine with 0.14.0 and above.


Closed windows are not removed from the tree on macOS 15 Sequoia

I'm using Aerospace v0.14.2-Beta on the latest macOS 15 beta (24A5331b). When I close a window, it remains in the tree hierarchy and still takes up part of the screen. This issue does not occur on my macOS 14 installation.
Steps to Reproduce

Go to an empty workspace
Open Finder
Open a second Finder window
Close the second Finder window

Expected Result
The first Finder window should fill the entire display.
Actual Result
The first Finder window does not expand to fill the entire display.
Additional Notes
This issue also occurs with other applications.
Here is the output of aerospace list-windows --workspace visible after closing the second Finder window:
1034 | Finder |
1028 | Finder | Desktop

Console output of aerospace debug-windows: debug-windows.txt

Checklist

[x] I've searched for duplicates. My search queries were (please don't forget to search in closed issues too):

macos 15
macos sequoia

[x] I've read the documentation https://nikitabobko.github.io/AeroSpace/guide & https://nikitabobko.github.io/AeroSpace/commands
[x] I've searched in the documentation. My search queries were:

close
tree

aerospace CLI client version: 0.14.2-Beta 0cb8dbdfc5ee73b8cbc200f175f467ebead55201
AeroSpace.app server version: 0.14.2-Beta 0cb8dbdfc5ee73b8cbc200f175f467ebead55201

Can't reporduce in 15.1 Beta (24B5035e). The problem is somewhere on your side

@nikitabobko Thank you for testing! I upgraded to macOS 15.1 beta 3 and reinstalled AeroSpace, but the issue continued. I then quit all running apps and background processes, and I found that the Contexts app was causing the problem. If anyone else has this issue, quit Contexts and restart AeroSpace to fix it.

Same issue here. I'm on macOS 15.0 RC (24A335) & AeroSpace v0.14.2-Beta 0cb8dbdfc5ee73b8cbc200f175f467ebead55201. If you repeatedly close and open a finder window, it gets a smaller tile each time, which means windows that are closed aren't getting removed from the tree. I have no other active applications that could cause this. Would appreciate any help to troubleshoot.

Thanks Felix! I forgot to consider my menu bar apps. After debugging, it was Amazon Q that's causing the issue in my case. But it's worth noting that prior to the OS update, both apps were working in harmony. I noticed that is the case for your app as well. So what could be causing such a conflict? Because not using some app is more of a workaround than a fix. What our apps have in common is that they both install an overlay, which somehow interferes with how Aerospace detects active windows?

To my knowledge, Aerospace utilizes Apple's accessibility API to detect and manage windows. Sequoia has implemented several changes to this API, which has caused problems for window managers like Amethyst. Unfortunately, I am not familiar enough with this API to identify the exact issue. It might be possible to reproduce the problem using a demo app in Xcode by comparing the list of windows reported by the accessibility API before and after closing a window. This could then be reported to the developers of the affected apps. The Contexts app hasn't been updated for several years, so I have now switched to an alternative.

The yabai window manager experienced the same issue when using Contexts or Amazon Q (Issue 2324, Issue 2431). A potential fix has been implemented (Commit). Perhaps this workaround could also be applied to AeroSpace, @nikitabobko?

Running into this issue as well - I use both Contexts and Amazon Q.
Binding a key to the 'close' command (ie alt-x = 'close') works as expected, but cmd+w leaves a phantom window:

the same issue for me(

Beta 15.1

The yabai window manager experienced the same issue when using Contexts or Amazon Q (https://github.com/koekeishiya/yabai/issues/2324#issuecomment-2376590474, https://github.com/koekeishiya/yabai/issues/2431#issuecomment-2376560387). A potential fix has been implemented (Commit). Perhaps this workaround could also be applied to AeroSpace, @nikitabobko?

yabai uses private APIs in their commit. I think that it's possible to circumvent this Sequoia bug using public APIs. My solution is described in #445

To my knowledge, Aerospace utilizes Apple's accessibility API to detect and manage windows. Sequoia has implemented several changes to this API, which has caused problems for window managers like Amethyst. Unfortunately, I am not familiar enough with this API to identify the exact issue. It might be possible to reproduce the problem using a demo app in Xcode by comparing the list of windows reported by the accessibility API before and after closing a window. This could then be reported to the developers of the affected apps. The Contexts app hasn't been updated for several years, so I have now switched to an alternative.

Hey @FelixLisczyk , I also use currently use Contexts app for MacOS, but it's buggy with AeroSpace. What alternative have you switched to?

@jsonMartin I'm using AeroSpace and the Raycast window switcher to organize my windows. This issue is currently being worked on in #445, so it may work better with the Contexts app in the future.

@jsonMartin I'm using AeroSpace and the Raycast window switcher to organize my windows. This issue is currently being worked on in #445, so it may work better with the Contexts app in the future.

Thanks! Funny you mention that, I also use Raycast and found the Switch Windows command. I migrated over from Contexts, and it works just about as well for application switching. Happy to remove one piece of redundant software from my stack; and it also works much better with AeroSpace.
I combined the above with AltTab for thumbnails and am happy with the result!


Parse css for links matching url(*)in tags @import and @font-face

Basic support for extracting styles, fonts and imagens inside css files.

Your patch is nice. Please fix the code style and add some tests to CssParseData and I will accept.


Can at some point Wire become 'go wire' ?

Hi,
Crazy proposal.
Any plans to consider proposing Wire to be part of go toolchain (https://github.com/golang/tools)
I would really like the command. :)
'go wire'

Hello! We have no such plans. The barrier to entering the standard toolchain/library is pretty high, and it doesn't give Wire any benefits over what it can already do with the source analysis packages in golang.org/x/tools, the repository you mention.
If you think Wire would make a good addition to the standard toolchain, the right place to start would be Go proposal process.


withParams processed even when task/step Skipped

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
It seems withParam is still processed even if the when condition of a task or step is evaluated as false. This causes the task or step to show its Phase as Error. Since there is no need to expand the task/step if the when condition evaluates false I would expect the end result to be Type: Skipped and  Phase: Omitted.
Type: Pod Phase: Succeeded
argo submit gh-issue.yaml --watch -p filter=data

Type: Skipped Phase: Error
argo submit gh-issue.yaml --watch -p filter=none

Version
v3.4.1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
---
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: withparams-issue
  namespace:  argo-events
spec:
  entrypoint: withParams-issue
  arguments:
    parameters:
      - name: filter
  templates:
  - name: withParams-issue
    dag:
      tasks:
        - name: generate
          template: generate

        - name: filter
          arguments:
            parameters:
              - name: filter
                value: >-
                  {{ workflow.parameters.filter }}
              - name: result
                value: >-
                    {{ tasks.generate.outputs.result }}
          template: filter
          depends: "generate.Succeeded"

        - name: print
          arguments:
            parameters:
              - name: result
                value: >-
                    {{ item }}
          template: print
          depends: "filter.Succeeded"
          withParam: >-
            {{ tasks.filter.outputs.result }}
          when: >-
            {{ tasks.filter.outputs.result }} != 'skip'

  - name: generate
    script:
      image: python:3.9
      command:
        - /usr/bin/python3
      source: |
        from json import dumps
        print(dumps({
          'data': [{
            '1': True,
            '2': 'string',
            '3': 3
          }]
        }))

  - name: filter
    inputs:
      parameters:
        - name: result
        - name: filter
    script:
      image: python:3.9
      command:
        - /usr/bin/python3
      source: |
        from json import dumps, loads
        result = loads('{{ inputs.parameters.result }}')
        filter = '{{ inputs.parameters.filter }}'
        if result.get(filter):
          print(dumps(result.get(filter)))
        else:
          print('skip')

  - name: print
    inputs:
      parameters:
        - name: result
    script:
      image: python:3.9
      command:
        - /usr/bin/python3
      source: |
        print('{{ inputs.parameters.result }}')

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

Bump

bump

@elauqsap and @robkinyon - can y'all give this issue a thumbs up in addition to commenting? It helps us sort prioritization
Given that people have commented on this, I'm going to move to a P2. @isubasinghe - could you take a look at it this week or next?

@JPZ13 will take a look into this next week.


Instructions to add specific public key to an account (NEAR CLI JS)

Let's say I want to create docs.mike.testnet and have a specific public key in mind for that account.
I'm unsure of the best flow for this given the new NEAR CLI commands.
Right now the create-account method will automatically generate a keypair and place it in ~/.near-credentials/testnet/new-account.mike.testnet.json

Right now I'm just making this ifyouknowabetterway.json file so I can save the new key pair somewhere, and then grab the pubkey and add it as a full access key to my new account. Then I think I'd manually change ~/.near-credentials/testnet/new-account.mike.testnet.json, replacing the private and public keys with what's in ~/.near-credentials/testnet/ifyouknowabetterway.json
It's quite possible I'm doing this a silly way.
This ticket is created not to fix NEAR CLI, but to give BD partners and NEAR builders some basic instructions so they don't have to feel the burden of figuring out the use case.

you can create the account passing a specific publicKey:

near create-account <new-account-id.testnet> --publicKey ed25519:...

you can then add the credentials

near add-credentials <new-account-id.testnet> --privateKey ed25519:...
will see to add this to the docs


Improving error/warning messages in Json response to report submission

When posting a report that has unexpected column headers or invalid/unexpected data, the messages provided in the Json response use internal field names that are confusing to the client posting the report. On missing fields, the message shows the CSV header but not the external/internal combination. After discussion on issue #1066 this format was decided:
'<external field(s)>' ('<internal field>')
Changes

added a custom getter to create the desired field mapping
replaced the internal field name in all the messaging to the field mapping from the custom getter
added a findElementByCsvName to the Schema class to find the Element and access the custom getter for missing fields

Checklist

[ ] review the errors and warnings by submitting bad data and confirm that they contain the desired information

Testing

[x] Tested locally?
[x] Ran quickTest all?
[x] Ran ./prime test against local Docker ReportStream container?
*** Tests FAILED:  garbage *** (known issue)
[ ] Downloaded a file from http://localhost:7071/api/download?
[ ] Added tests?

Security

[x] Did you check for sensitive data, and remove any?
[ ] Does logging contain sensitive data?
[ ] Are additional approvals needed for this change?
[ ] Are there potential vulnerabilities or licensing issues with any new dependencies introduced?

Process

[x] Includes a summary of what a code reviewer should verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Security
List potential security threats and mitigations in the PR
Fixes
List GitHub issues this PR fixes

#1066

To Be Done
Create GitHub issues to track the work remaining, if any

I'll address the unit test in issue #1113


Add news site next with app router

This pr adds a copy of the news-site-next, but with app router.
Changes:

Removed pages directory
Added app directory
Added a root layout in which takes on _app & _document from pages router
updated Navigation Links to use the appropriate Link component for App Router
Marked context provider as "use client" to ensure nothing breaks for now
reading url search params from useSearchParams to avoid window access
using useLayoutEffect for document updates
Page component also using "use client" since we're doing stuff with document.

@kara

merging, to be able to continue with stuff.
happy to address any concerns in a follow up pr


Engine: GameState.fen() has issues with castling rights

Castling rights seem to be ignored and always -.

For the time being, we are using - in the test_chess_engine.py, change that once we get the rights to be properly displayed.


Improve the performance of extraction

Out of memory reported by people at MSR Cambridge. More details to follow.
Need to profile the extraction with OCaml Spacetime.

This has to be done on Linux as I haven't been able to build a mingw64 OCaml with Spacetime enabled.
Furthermore, libunwind is required to debug the zarith allocations

Overhead for Spacetime makes extraction of even such simple examples as aesgcm crash and get out of memory (16Gb does not seem to be enough.)
Switching to Jacques-Henri Jourdan's statistical memory profiler, which is available only for OCaml 4.03.0
More info: https://github.com/jhjourdan/ocaml/tree/memprof

this was improved a lot at the end of December. The main fix was a better check to determine the stratum of a term during extraction.


WIP Test tip on travis

We need to sort out our tests, they currently fail.

@Contextualist do you mind taking a look? The only thing failing now on go1.10 is completiion:
--- FAIL: TestServer (11.77s)
    --- FAIL: TestServer/go_vendored_dep (0.61s)
        langserver_test.go:1265: $ go install -v ...
                test/pkg/vendor/github.com/v/vendored
                test/pkg
        --- FAIL: TestServer/go_vendored_dep/completion-a.go:1:34 (0.00s)
                langserver_test.go:1422: got "", want "1:20-1:34 github.com/v/vendored module "
        --- FAIL: TestServer/go_vendored_dep/completion-a.go:1:61 (0.00s)
                langserver_test.go:1422: got "", want "1:61-1:61 V function func()"

@keegancsmith Ah! Thanks for fixing the vendor issue. I just found that .a files for vendor packages are missing, never had thought that it is the problem due to go 1.10 package caching.

@Contextualist yeah sorry I should of mentioned I decided to look into it.

@keegancsmith That's totally fine. 😄 Appreciate your efficiency!
Nonetheless, we have to wait for gocode to fix the issue, otherwise go1.10 users have to either install vendor package manually or disable package caching.


Added blocklist functionality to scrapoxy

As discussed in https://github.com/fabienvauchelles/scrapoxy/issues/106
In configuration blocklist allows list of URLs (or fragments of URLs) to be specified, which Master will check against before continuing.
Block any url containing google/facebook
[
'google',
'facebook'
]

Block .co.uk URLs:
[
'.co.uk',
]

Block specific URL:
[
'https://www.example.com/sample-page',
]

@fabienvauchelles here you are =)

@fabienvauchelles could this be merged and put into npm? =)

merge in another PR


Check includes are valid

If you have an include {% include "web/somethin %} no test catches that this is invalid. And while this renders on WebFundamentals, it errors on DevSite.
This test adds a much softer check for includes that only looks for the starting and ending {% include %} and compares the count to the valid includes. If the count doesn't match it throws an error.

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/modules/workbox-cli.md - No wf_blink_components attribute found. Add if appropriate.


Different metrics lifetime and garbage collection (forgetting outdated telemetry)

Hi, in my case I have many spawned tokio tasks that need to be measured.
Measurements for these spawned tasks unique by labels, and once solved I have to remove these measurements from the metrics registry to prevent memory leaks.
At the same time I need to keep metric COUNT_OF_ACTIVE_TASKS available while my program works.
At now I can't find any way for solving that problem using current API.
builder.idle_timeout looks good, but I have no guarantees about the interval for spawning new tasks, hence COUNT_OF_ACTIVE_TASKS could be deleted at any time and its state forgotten.
Can anyone tell me how to solve this problem without writing an absolute value to COUNT_OF_ACTIVE_TASKS on timeout in an infinite loop? 😂

I was thinking about collecting metrics from TCP connections - we have no guarantees about the intervals between packets in general.
For example, if we collect the number of bits sent, but there are no ping messages in the protocol between the client and server, we run the risk of forgetting the state of the metrics if the client and server are silent for a long time.
So, I think we really need to extend api. For example add ::mark_as_outdated() method to counter/histogram/gauge, or may be extend recorder api to add ::remove_<metric kind>(), or give direct access to registry.

Yeah, in general, there's no good ergonomic way to let callers (the parts of the code actually emitting the metrics) control when those metrics go away.
This will likely need to be solved through whatever we do to fix #314, since fixing that allows for a better separation between "this metric is no longer live at all" and "this metric hasn't been updated in a while and I want to stop showing it".

"this metric hasn't been updated in a while and I want to stop showing it".

Do we really need this feature?
I think that if we remove some measurements, Prometheus can't collect them, and Grafana will actually render the gaps in those time slots while the measurements are suppressed for rendering in our app.
My be we can do it more simple if just delegate the responsibility of deleting metrics to users?
At least in other programming languages I have been happy with such an api so far.

We're not going to be changing the core Recorder API to allow for arbitrarily marking a metric as done/outdated/expired.
As far as wanting to stop showing idle metrics: it's absolutely a thing people want/request. It's very useful to avoid removing a metric as soon as it's no longer used, but instead only after a long enough period of inactivity, in order to avoid sparse reporting.


FileIO deprecation warning

Running tests that read data from shapefiles brings up the following deprecation warning from core python:
pysal/pysal/core/util/shapefile.py:623: DeprecationWarning: fromstring() is deprecated. Use frombytes() instead.
  _unpackDict2(record, contentStruct, dat)

Not sure if the fix is as easy as the deprecation warning suggests, with the differences in python2 string and python3 bytestring processing.

Similarly, the following warning appears as well:
/Users/dani/anaconda/envs/py3k/lib/python3.4/unittest/suite.py:84: ResourceWarning: unclosed file <_io.BufferedReader name='/Users/dani/Desktop/pysal23/pysal/examples/columbus.dbf'>
  return self.run(*args, **kwds)


May a future both wake a Waker and return Pool::Ready?

I can't tell from the documentation whether it is permitted for a polled future to both:

wake the Waker from the Context passed to poll, and
return Poll::Ready.
I think the Future::poll documentation ought to be clearer on this question.

I'll be happy to write a pull request once I understand the answer.

It is always possible and allowed to call Waker::wake() - even in situations where the task has already finished.
However you should not do it the relevant Future already gets completed in the same turn. Calling wake() in the same moment will cause the executor to call poll() on the task again in the case the task didn't already complete. That would be an unnecessary wakeup. Also if no higher level Future already remembers that this particular Future already finished and refrains from polling it again then this will cause an infinite loop of the Future waking up the executor and the executor polling the Future again.

A future that does so sounds like a good thing to have in futures-test as a way to stress-test executors (along with one that spawns a thread to call wake after the executor has been dropped, hmm, this is making me wonder how much Juliex has been stressed with logically buggy futures).

Closing-- @Nemo157 if you want to follow up with a futures-test addition, SGTM.

Yes, closing is fine, sorry. I'll put together a PR for the doc change.


How to uninstall?

I have nothing against haskell-vim-now, but it's just not for me. I was wondering what I'd need to do  to get back to just a stock vim installation?

No problem, it's easy to uninstall.
ls -alh ~/.config/haskell-vim-now/backup

You'll see timestamped .vim and .vimrc files. Your old configuration will be one of those (there will probably be only one in your case).
# remove the symlinks which point to haskell-vim-now stuff
rm ~/.vim ~/.vimrc
# now restore the backup
mkdir -p ~/.vim
cp -R ~/.config/haskell-vim-now/backup/.vim.2016xxxx_yyyyyy ~/.vim
cp ~/.config/haskell-vim-now/backup/.vimrc.2016xxxx_yyyyyy ~

Thanks a lot!


Default of allow_main only

So I have been using this module.  Thanks to all the devs and Philips for making it available.  I have used it mostly with a GH env config and in that config it allows different branches.  Which we had come to expect.  I am now using it only for uploading artifacts so I hadn't planned to used environments.  However I do want to support different branches.  Besides "allow all" it isn't obvious how to get that behavior.  Seems like I could using the config that shows up in AWS:
            "StringLike": {
                "token.actions.githubusercontent.com:sub": "repo:myrepo:ref:refs/heads/main"
            }

  conditions                  = [{     test = "StringLike"     variable = "token.actions.githubusercontent.com:sub"     values = ["repo:myrepo:ref:refs/heads/*"]   }]
But it really isn't clear if that would work.  Clearly messing around in here requires some expertise but the docs really don't express how I might do this.  And the reason I am using your excellent module was to avoid getting down in the weeds too much.  This could be a doc update.  I think I will just use allow all as that is probably appropriate for this security scope.

Even a point in the docs to how that conditions logic will be applied and where that is documented elsewhere would be better.  I assume it is just passed through to another module underneath.


Combine Informations

Hi,
I'm working also on a driver, which is only supporting TLS (using OpenSSL). But I've done most of the high level stuff (low level is in rough shape). Maybe we can combine it? I would be willing to change the license from LPGL to a more freely one.

I'm going to upload this lib to Nuget soon so you will be able to use it (no need to change the license, since HarpoS7 is using MIT). I can help you with integrating it into your driver later on.

May I chime in as well? I'm the maintainer of S7NetPlus and creator of Sally7, I'm very interested in at least getting Sally7 to a more modern protocol version. Both libraries are MIT licensed.

I've got a running version, but it does only support TLS supporting CPUs:
https://github.com/thomas-v2/S7CommPlusDriver
Even if you want to connect to a password protected CPU with TLS, you'd need parts of the authentication used in this HarpoS7 library. CPU password authentication uses a different string to build another derivative key, as far as I know.

@thomas-v2 I didn't look into the password auth yet, but during my reverse-engineering sessions I did see a different derive function in the disassembly - I will take a look at it when I have some free time later.
@mycroes Sure! I do know S7NetPlus - I've contributed some code myself. I'm working on releasing an actual public key store so that anyone can download the lib from nuget and use it as is, without dumping anything.

@bonk-dev Yeah I recognized your name and profile pic. I think I've also been in (short) contact with Thomas in 2019, but back then he didn't feel much for supporting work on a C# implementation 😉. Anyway, I still have a lot of catching up to do on all this, I currently have no clue how different S7ComPlus is from the legacy S7 protocol, but it's something I'd very much like to support.

@thomas-v2 I finally found some time to look into password auth. I was planning on making a doc on how it works but I'm drained for now. I pushed my changes to main and uploaded the new version to nuget.

Closed due to no response


I'm the 7001 star.. oh,my god.

I'm the 7001 star.. oh,my god.

is this really an issue?

Best issue i ever saw! It describes most important bug in github: 'Time stealers'. We need to fix it 🏭


Vector Tiles data source will soon disappear

Hi,
In approximately two months, @iandees and I will be turning off the experimental Vector Tiles service hosted at https://openstreetmap.us/~migurski/vector-datasource/. Going through our referer logs, we’ve found these openlayers.org pages using the service:

http://openlayers.org/en/latest/examples/osm-vector-tiles.html?q=vectortile
http://openlayers.org/en/v3.15.1/examples/osm-vector-tiles.html?q=vector
http://openlayers.org/en/v3.0.0/examples/tile-vector.html
http://openlayers.org/en/v3.1.0/examples/tile-vector.html
http://openlayers.org/en/v3.5.0/examples/tile-vector.html
http://openlayers.org/en/master/examples/osm-vector-tiles.html
http://openlayers.org/en/v3.2.1/examples/tile-vector.html
http://openlayers.org/en/v3.15.1/examples/osm-vector-tiles.html
http://openlayers.org/en/latest/examples/osm-vector-tiles.html

My recommendation is to switch these pages to using Mapzen’s equivalent, supported service: https://mapzen.com/projects/vector-tiles/. We may provide HTTP 301 redirects for individual tiles after August, which may work seamlessly.

Thanks for telling us!


Use a safe technique to implement .get2_mut()

Fixes #41
Uses the same technique that slab uses (as mentioned in https://github.com/LPGhatguy/thunderdome/issues/41#issuecomment-1487614744) with some slight tweaks to handle the generations right

Thanks for all the cleanup! It looks a lot cleaner now :)


[ServiceUtils] Option to include policy checks

Problem solved
Add option and types for policy checks
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

/release-pr


SqliteError errors preventing load

I am receiving the following errors when attempting to run the app:
⠹ Compiling Renderer Code(node:35366) UnhandledPromiseRejectionWarning: SqliteError: no such column: was_aligned
at Database.prepare (/home/waldo/voicesmith/.webpack/main/index.js:652:21)
at createTables (/home/waldo/voicesmith/.webpack/main/index.js:7648:8)
at Object.getInstance (/home/waldo/voicesmith/.webpack/main/index.js:7678:17)
at Object.getPath (/home/waldo/voicesmith/.webpack/main/index.js:8177:42)
at /home/waldo/voicesmith/.webpack/main/index.js:8196:52
at /home/waldo/voicesmith/.webpack/main/index.js:5378:40
at step (/home/waldo/voicesmith/.webpack/main/index.js:5302:23)
at Object.next (/home/waldo/voicesmith/.webpack/main/index.js:5283:53)
at /home/waldo/voicesmith/.webpack/main/index.js:5277:71
at new Promise ()
AND
Error occurred in handler for 'fetch-needs-install': SqliteError: no such table: settings
at Database.prepare (/home/waldo/voicesmith/.webpack/main/index.js:652:21)
at Object.getPath (/home/waldo/voicesmith/.webpack/main/index.js:8178:22)
at /home/waldo/voicesmith/.webpack/main/index.js:8196:52
at /home/waldo/voicesmith/.webpack/main/index.js:6545:93
at step (/home/waldo/voicesmith/.webpack/main/index.js:6518:23)
at Object.next (/home/waldo/voicesmith/.webpack/main/index.js:6499:53)
at /home/waldo/voicesmith/.webpack/main/index.js:6493:71
at new Promise ()
at webpack_modules../src/electron/handles/install.ts.__awaiter (/home/waldo/voicesmith/.webpack/main/index.js:6489:12)
at /home/waldo/voicesmith/.webpack/main/index.js:6542:91 {
code: 'SQLITE_ERROR'

Hi, is that version 2.0 downloaded from the releases page?

Thank you for the information. I will give this a try. I am just exploring to see how Voice Smith works.

Unfortunately even after installing docker as suggested and restarting, I can load docker in the CLI, but the Voice Smith app is still giving m the "No installation of Docker" message.

@dunky11  same issue here, any other recommendations? would love to try this out...

@scott-vector
did you got it working?

I quickly looked at the code and saw that it runs the docker info command and sees if there is an error which happens if docker is not configured for non-root users, either you can try to run voice-smith as root with no sandbox but that doesn't seem to work on all distributions, you can then configure to accept non-root commands: https://docs.docker.com/engine/install/linux-postinstall/

@Snowad14
I loged in to the provided container an saw no sqlight db for voicesmith user running.
one important thing though is i am running the project on windows. it would be easier if that electron app runs as a website ap.


Initializing group shared variables fails GLSL output

Take the slang code...
groupshared uint someValue2 = 0 ;

When emitted to GLSL it appears as something like
uint someValue2_init()
{
    return 0U;
}

shared uint someValue2 = someValue2_init();

Which fails to compile on GLSLANG with the error
glslang:  (249): error :  'shared' : initializer can only be a null initializer ('{}')

We should move any initialization to the entry point and insert a call to memoryBarrierShared

We think this might also show up in the direct to spirv backend. So flagging as important to fix in context of spirv backend

@expipiplus1  are you actively driving this or should we unassign so others can take it?

@expipiplus1 can you let us know if you still plan to work on this?

@csyonghe @natduca  I'll do this this week, should just be more or less a matter of selectively applying the existing global raising pass

Looks like this was fixed anyway, I added a test.


skip vuln test for dependabot

Skip vulnerability  test in case of the actor is dependabot

@Rchanger can you rebase?


unicorn dll files

Richard,
Unicorn is installed on Foundation.Serialization. Also one feature has a reference to Unicorn.Roles.
I can see that main project has references to all foundations, features and projects and when I build the project, Foundation.Serialization.dll is being deployed but the problem is that Unicorn dlls are not being deployed. Hence, I need to manually copy Unicorn DLLs.
Am I missing any configurations or something has wrongly setup ?

Thanks Richard 👍 We're using HPP 1.0
As there is a open ticket for config transformations. I need to ask one more thing,
We've used a mapper for Sitecore view renderings. So there should be a View\web.config with a reference to that mapper assembly. However, It seems HPP intentionally ignores _views/web.config .

Views\web.config is not copied on build

Can you upgrade to 1.4.2 and see if that resolves the problem?

Make that 1.4.3, actually.
1.4.2 was published in error.

I think you'll need to wait for #32 for that


Fix media contents error in arrow format

Summary

Fixed to initialize Image media from bytes not a decoded numpy array
Fixed not to save PointCloud when save_media=False

How to test

Checklist

[x] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[x] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho<EMAIL_ADDRESS>

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (fbce79b) 78.71% compared to head (347203b) 78.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #986      +/-   ##
===========================================
- Coverage    78.71%   78.67%   -0.05%
===========================================
  Files          231      231
  Lines        26452    26448       -4
  Branches      5260     5263       +3
===========================================
- Hits         20823    20809      -14
- Misses        4404     4412       +8
- Partials      1225     1227       +2

Flag
Coverage Δ

macos-11_Python-3.8
?

ubuntu-20.04_Python-3.8
78.67% <100.00%> (-0.02%)
:arrow_down:

windows-2019_Python-3.8
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...atumaro/plugins/data_formats/arrow/mapper/media.py
73.93% <100.00%> (-2.11%)
:arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Guess the number game

I created guess the number game in python

congratulations make sure to star the repo

Hey Tammy your repo get excluded so it will not count isn't it?
On Sun, Oct 1, 2023, 23:40 Alok Tamrakar @.***> wrote:

congratulations make sure to star the repo
—
Reply to this email directly, view it on GitHub
https://github.com/TammyAlok2/Hactoberfest2023_ADSC2/pull/21#issuecomment-1742156788,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BC5NVKYE7B5QQ7GNAMVZYGTX5GW2NANCNFSM6AAAAAA5OOGC3M
.
You are receiving this because you authored the thread.Message ID:
@.***>


Make favorites removable

Will require converting favoriteAsset to Asset and conforming to Codeable and Hashable.
On rendering favorites, if a given asset is in the favorites store, make it removable!

 Make favorites removable


Make databaseURL optional and inject it using the information in xata/config.json during code generation

Now that we have a xata/config.json file (we didn't have it a few months ago), we can read the workspace id and the database name during code generation and inject it in the code.
Users should still be able to overwrite its value for a few reasons:

So the URL is configured with mechanisms like env variables. Useful for example if for security reasons somebody wants to run a codebase in a different workspace/database, or because it's a forked open source project and they don't want to change the generated code every time just to change the workspace/database, etc.
For us, to test our generated code against localhost or staging.

If we add default strategies to guess and set the branch, we can do the same approach for databaseURL

If we add default strategies to guess and set the branch, we can do the same approach for databaseURL

Yeah, I was thinking on something like that. However I think the workspace and database almost never changes. So I prefer the default to be injected in the code, and we can do that during code generation.
In the (not common) case you want to overwrite that value, you still can.
For deciding the branch name I can think of many different strategies (git, untracked file, env variable), but for workspace/database I can't think of other useful strategies other than allowing it to overwrite it completely.

Similarly we can attempt to read the apiKey from ~/.config/xata/key.

That's interesting. However this needs to be done in runtime (unlike workspace/database), and there we need to deal with different file system APIs for different environments.

However I think the workspace and database almost never changes. So I prefer the default to be injected in the code, and we can do that during code generation.

Makes sense, what about we do have strategies but the codegen injects it (overwriting). That way we consistently make all the SDK parameters optional but still the codegen prints values to the code.

what about we do have strategies but the codegen injects it (overwriting)

The thing is that I can only think about one strategy: using an env variable. And that's a sync operation. So I don't see the need to allow an async function or array of async functions, etc. I'm open to adding strategies definitely if we find other use cases.
To me branches are a very particular case, becuase you may want to configure that very dynamically depending on the environment (local, ci, preview, production,...) and I can see many different strategies there.

This is blocking my example apps. Any objection if I take it?

@TejasQ no objections. Go for it! 👍
The change in XataClientOptions would be:
  export type XataClientOptions = {
    fetch?: unknown;
-   databaseURL: string;
+   databaseURL?: string;
    branch: BranchStrategyOption;
    apiKey: string;
    repositoryFactory?: RepositoryFactory;
  };

and the codegen would inject a default databaseURL value inferred from xata/config.json.

Right, should we also infer the branch the same way as main and have it be a reasonable default since all databases are created with main?

To avoid conflicts, it would be awesome if we can merge
#38 so that the generate function works with the folder already, and
#34 so I can be more confident I don't break other codegen parts
before I start on this 🙌

Right, should we also infer the branch the same way as main and have it be a reasonable default since all databases are created with main?

For branches we have strategies. And even though all databases start with a main branch, that doesn't mean that that's the default branch or could be renamed. Besides, it could be problematic that you deploy to an environment that is misconfigured and by mistake starts using the production branch. So I prefer to not have any default.

Great, sounds good.

My only concern with making branch explicitly required when instantiating this class is friction. Everyone we talk to on customer calls doesn't even know about branches and using them is usually something that comes later, after they start iterating on a main schema.
So to ask a user to supply branch: "main" even when they're not fully using Xata in a big way seems like unnecessary friction because my assumption is that they would start using the SDK before getting overly familiar with the branching flow.

Everyone we talk to on customer calls doesn't even know about branches

I'd like to learn more about that. Are they familiar with git branches?

Well, it's a relief they know about git branches. I thought you were saying they didn't know about branches in general.
Anyway, this is a security measure. I think we can't have default because it may cause a lot of harm in some circumstances. Maybe in the future, depending how we do API keys scoped to branches or environments we can add a default safely.


Backwards compatibility tests for async search

Description
Description of changes:
Added Async search backwards compatibility tests for mixed cluster, rolling upgrade and full restart scenarios
Updates DEVELOPER_GUIDE to add instructions for running bwc tests

Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3e2e50c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage        ?   83.38%
  Complexity      ?      554
=======================================
  Files           ?       61
  Lines           ?     2058
  Branches        ?      146
=======================================
  Hits            ?     1716
  Misses          ?      236
  Partials        ?      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2e50c...ab0bdb1. Read the comment docs.

@dblock @ohltyler can any of you please review this PR ?


adjust to JuliaLang/julia#46966

Codecov Report
Base: 88.72% // Head: 87.34% // Decreases project coverage by -1.38% :warning:

Coverage data is based on head (a355c9e) compared to base (0cbae1a).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   88.72%   87.34%   -1.39%
==========================================
  Files          11       11
  Lines        2626     2607      -19
==========================================
- Hits         2330     2277      -53
- Misses        296      330      +34

Impacted Files
Coverage Δ

src/JET.jl
71.33% <ø> (-0.81%)
:arrow_down:

src/analyzers/jetanalyzer.jl
91.68% <85.71%> (-2.50%)
:arrow_down:

src/abstractinterpret/abstractanalyzer.jl
84.37% <100.00%> (ø)

src/abstractinterpret/typeinfer.jl
89.23% <100.00%> (-4.39%)
:arrow_down:

src/ui/print.jl
91.09% <0.00%> (-0.69%)
:arrow_down:

src/abstractinterpret/inferenceerrorreport.jl
92.90% <0.00%> (-0.03%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix audio example being too complex

The previous audio example contained animation and movement.

Maybe it would be beneficial to have both examples?

Perhaps it should also show that audio can be "background audio", and "not background audio"?
The reason it allowed for scrolling, is because the more you zoom out, the less you hear the weird man, but the bird stay the same.

@EtienneBruines Ah. I see your point. I'll add those back in, but not the animation or movement.

:+1:

+1 on complexity. Such combo things we could demo in an example game but those small demos should help in writing tutorials.

@EtienneBruines I think we should keep this example as it is. But have a second example with what you previously mentioned.
I'll do this in a separate PR.
Merge when ready.


Failed to download some container images

The kube-apiserver container image can't be saved by nerdctl.
Pulling is succeeded, but "nerctl image save" fails with docker engine.

Fixed.


Wilmington, DE email - city vs. county officials issue

I sent the drafted template to the email list provided for Delaware and received the following feedback regarding the message reaching the wrong people:
Their message is confusing on two fronts:
they are having the action emails sent to BOTH City (Wilmington) and New Castle County council members.  You can tell by their email addresses which is which.
then the message itself seems to focus on the CITY budget - well then WHY are the message being sent also to COUNTY members??
If they want it to go to BOTH City and County, they should devise two separate messages, one to each and ask for CITY council members to change the CITY budget, and ask the COUNTY members to change the COUNTY budget.  As it is now, it confuses the two, and so it is being dismissed by my colleagues.
Your message below seems to have been edited from some of the ones I am getting, and focuses solely on the City (which is good) - but you aren't a City resident so your message to City Council will be less powerful.  Most of the messages I am receiving have references to both City and COunty together...
Hope this makes sense.  Their message would be taken more seriously of this was corrected.
I think the resource you've created is extremely valuable, I just figured you should know that this instance is not able to be as effective due to this confusion and figured I would let you know
Thank you!

Thanks for letting us know!

Couple notes on this one -- as far as I can tell no City Council members are included at all despite the city language... the Mayor, the Social Media Manager (mgjopson) and the entire County Council are all here. This could possibly be split into two letters with email addresses corrected for the city and more specific budget figures for the county.


When on tags tab, there is blank extra space beneath.

Only occurs when on the tags tab, "processes" and "charts" tabs are okay.

I know what the problem is, so I'll submit a PR that includes this fix soon.

Fixed in #19


Add gimbal support

Add gimbal support to SetPitchAndYaw.

You forgot to fix style (which is why the CI is failing), but other than that, it looks good to me :+1:.

Cool, thx!


CUDA error of self.embed_positions

❓ Questions and Help
Before asking:

search the issues.
search the docs.

What is your question?
Code

What have you tried?
What's your environment?

fairseq Version (e.g., 1.0 or main):
PyTorch Version (e.g., 1.0)
OS (e.g., Linux):
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:
I am running a Chinese BART LARGE on GEC task. I am using BertTokenizer to tokenize the raw Chinese text and use the checkpoint from huggingface to initialize the BART model.

I have finished working on it. Since my training sentences were too long, extending the length of the max position embeddings led to a CUDA index error. However, after setting the truncate dataset parameters, I was able to solve the problem.


Flyout: link to change version drops page name

Noticed here:
https://docs.astropy.org/en/stable/coordinates/inplace.html
The versions should all link to /en/{version}/coordinates/inplace.html. They link to /en/{version}/ instead.

[ ] Page name is dropped from version switch links
[ ] Page name is dropped from locale switch links (in theory?)
[ ] Latest version is used instead of current version for locale links

Actually, to expand on this, I've noticed a couple issues with both of our flyout menus, so I'll note them all and we can work forward here.
Our old flyout also doesn't handle the locale links correctly after switching versions. That is:

A project with versions 1.0 and 2.0, set up on both locales en and es.
Go to /en/2.0, flyout links to alternate locales are /en/2.0 and /es/2.0.
Go to /en/1.0, flyout links to alternate locales are still /en/2.0 and /es/2.0. Links should instead be /en/1.0 and /es/1.0.

I'm also going to guess that the page name is dropped from the locale switcher links too.

The versions should all link to /en/{version}/coordinates/inplace.html. They link to /en/{version}/ instead.

I made this decision on purpose mainly because we can't guarantee that the page will exist in the other version (or language) and when clicking on these links the user will see a 404. So, it makes more sense to switch to the "homepage of the version/language"
There is more context in https://github.com/readthedocs/readthedocs.org/issues/10102
I think both approaches have pros and cons and I decided to go with the simplest use case for now until we can have a better UX for users. If we want to implement "See this page in " #130 (or "See the version  of this page" --which is essentially the same issue) we should somehow guarantee the page exists or don't show the link otherwise.

I made this decision on purpose mainly because we can't guarantee that the page will exist in the other version (or language) and when clicking on these links the user will see a 404. So, it makes more sense to switch to the "homepage of the version/language"

It seems that Material for MkDocs has arrived to the same conclusion: https://github.com/squidfunk/mkdocs-material/issues/4835
The behavior described seems to be:
"Stay on the same page only if that same page exists. Otherwise, go to the homepage."
I'd like to see how the implemented UX is, because it could be pretty confusing as well if there is no indication that there is no translation/version for the page.
I think this opens the door to improve the UX on the front-end side without backend intervention maybe. The front-end could listen to the click even on those links and make a HEAD request to know if the page exists or not and decide what to do with that information:

redirect to homepage
go to the version/language of the current page
show a message saying there is no version/translation for that page and let the user decide what to do
etc

I'm not sure what's the best UX here yet, but I think this is probably a good direction to discuss more.

I made this decision on purpose mainly because we can't guarantee that the page will exist in the other version

Yeah, I figured that was the reason behind this. I think losing the page entirely is rather confusing UX, and users would encounter losing the page URL more commonly than hitting a missing page when switching versions. I think we optimize for the more common case here instead.

"Stay on the same page only if that same page exists. Otherwise, go to the homepage."

Yeah, this would be ideal UX.
I think we can easily do this from the backend. Proxito can redirect to the relative root if a missing page is encountered -- that is, we might link to /es/4.1/some/page.html?redirect-missing and proxito would know to automatically redirect instead of serving a 404.
Doing it from the front end is probably okay too, but I might be worried about edge cases like potential cross domain requests or handling existing redirects. I still think we should lean towards writing backend code when we can too.

If we want to implement "See this page in " https://github.com/readthedocs/addons/issues/130 (or "See the version  of this page" --which is essentially the same issue) we should somehow guarantee the page exists or don't show the link otherwise.

I think if we implemented anything like that, the UX should match the flyout. I'd focus on the UX at the flyout first before making any features that might conflict though. I'm not yet convinced we even need to implement a secondary form of language/version switching. The user/theme can always implement something like if needed.
An overlap here might be a user feature that warns when the page name doesn't match the referring page name -- "The page you requested does not exist so we're showing you the home page instead". Something to give the user explicit information about what just happened.

Also, note #223 points out the same issue as here. I feel this is going to be a pretty expected UX.

I would also prefer it to keep the page structure when changing versions.
For example, that's what the custom switcher currently used by https://docs.python.org. Here's some transitions when changing version and language:

https://docs.python.org/3/tutorial/index.html
https://docs.python.org/es/3/tutorial/index.html
https://docs.python.org/es/3.10/tutorial/index.html
https://docs.python.org/ko/3.10/tutorial/index.html
https://docs.python.org/ko/3.12/tutorial/index.html
https://docs.python.org/3.12/tutorial/index.html

If a page isn't found in the destination version, it shows the homepage:

https://docs.python.org/3.13/howto/timerfd.html
choose 3.12
https://docs.python.org/3.12/

It seems like the decision we need to make here is just which pattern we should use:

Proxito based redirect to the correct page if none exists
Javascript HEAD request check before following link/redirecting to the homepage

I lean towards a Proxito solution because I think we can be more precise about the redirect with application logic. The application can tell where to redirect the request to directly, where a JavaScript solution would need to do a series of guesses to come to the same conclusion. And we avoid any browser blocking and CORS side headaches.
@humitos do you have more opinions here?

I lean towards a Proxito solution because I think we can be more precise about the redirect with application logic. The application can tell where to redirect the request to directly, where a JavaScript solution would need to do a series of guesses to come to the same conclusion

Yeah, Proxito solution seems to be the most accurate, easier to maintain and gives us more control over time.

@humitos do you have more opinions here?

One problem that I see with this implementation is that we will loose the per-project cached flyout response and it will become per-page instead, degrading the performance of addons a lot. This is because the resolver will need to act over the filename of the current page instead: https://github.com/readthedocs/readthedocs.org/blob/3cfc29be8add5a0cf37d795e1c189d8aaa22a069/readthedocs/proxito/views/hosting.py#L350-L374
We may need a way to "resolve" the URL in the front-end, or communicate this to the backend somehow. Maybe we need to change the approach here and the URLs from the flyout need to be different:

https://docs.readthedocs.io/en/stable/intro/import-guide.html?readthedocs-language=es[^1] to tell Read the Docs that we want that particular page in Spanish. El Proxito will redirect it to:

same page name in Spanish (https://docs.readthedocs.io/es/stable/intro/import-guide.html) if it's not 404
home page in Spanish (https://docs.readthedocs.io/es/stable/), otherwise

https://docs.readthedocs.io/en/stable/intro/import-guide.html?readthedocs-version=latest to tell Read the Docs that we want that particular page in its latest version

same page name in latest version (https://docs.readthedocs.io/es/latest/intro/import-guide.html) if it's not 404
home page in latest version (https://docs.readthedocs.io/es/latest/), otherwise

Would this approach solve this issue without affecting our per-project cached flyout responses?
[^1]: if we don't want to interfere with real URLs here mixing "Read the Docs query attributes on user-based URLs" we can create an API endpoint for this: /api/v3/resolver/?url=https://docs.readthedocs.io/en/stable/intro/import-guide.html?language=es and /api/v3/resolver/?url=https://docs.readthedocs.io/en/stable/intro/import-guide.html?version=latest. This will probably be more clear for everybody and also without contaminating El Proxito code. Besides, this API endpoint could be re-used in other places where the front-end needs to resolve a URL in the same way the backend does.

One problem that I see with this implementation is that we will loose the per-project cached flyout response

If we resolve the URL in the flyout API, I see this being a problem as well. I don't think we want to do this due to the cost of the resolver logic, even with caching.

Would this approach solve this issue without affecting our per-project cached flyout responses?

I think you're describing the pattern I was here. I was thinking we don't do anything different with the flyout response but would wait for the reader to click a link instead. That is, the flyout version/translation URLs would be naive and just simple text concatenation instead of using the resolver in the initial API response.
To avoid magic at Proxito we probably should have a dedicated endpoint, or should include some query parameter like what you're describing or simply https://docs.example.com/es/stable/maybe-this-404s.html?redirect=auto to force the Proxito view to find the most suitable URL.

If we following the query arguments pattern on documentation URLs, I'd use ?readthedocs-*= explicit names.

Yeah, prepending readthedocs is fine. I was only illustrating that a single query parameter could be used on the actual URL we are intending.
That is, the link URLs in the flyout would be:

https://docs.example.com/es/stable/some/page.html?readthedocs-redirect=auto
https://docs.example.com/en/1.2/some/page.html?readthedocs-redirect=auto

Instead of using the current version/language as the URL:

https://docs.example.com/en/stable/some/page.html?readthedocs-lang=es
https://docs.example.com/en/stable/some/page.html?readthedocs-version=1.2

Using the actual URL seems less confusing than URLs with multiple languages/versions -- once in the URL and once in the query params. The URL on hover would (almost all of the time) match the URL the user will end at after clicking the link.

IMO, the most technically accurate solution is a the API endpoint

I'm not so sure on this yet. If we aren't using the response from this request, then it feels like a mismatch for our API maybe.
We have needed in places to work around the resolver response time, usually relying on URLs returned from established API endpoints. Instead of using application code from the templates to resolve a URL to a version/page, UI elements capture point-in-time use of these links (on hover/click) and instead hit an API to get the resolver response. This is basically what you are describing with the second option.
However, I can't think of any place we still need generic access to a resolver API though. But it's worth noting, as if we did need this still, there would be multiple uses for a generic API like this.

That is, the link URLs in the flyout would be:
* https://docs.example.com/es/stable/some/page.html?readthedocs-redirect=auto
* https://docs.example.com/en/1.2/some/page.html?readthedocs-redirect=auto

OK, I think you convinced me about this 😄 . I will add this issue to the roadmap and the next sprint.

@agjohnson what do you think about the following issues? Can you comment there? I think we can tackle the three of them at the same time:

https://github.com/readthedocs/addons/issues/131
https://github.com/readthedocs/addons/issues/130

The anchor in #131 would be a new feature of both flyouts, but would be nice to have eventually. I see it not being a huge feature on top of parsing and building link URLs though, so it might be worth giving a quick try at. I'd say use your judgement there, bail out if it feels like too much work.
#130 seems like what I noticed above too, and would be a good issue to address at the same time.

OK, I think you convinced me about this 😄

I will say that my suggestion is still just a guess, and I don't dislike the other solutions we've discussed here so far. I might not being considering the API response as deeply as I should either.
I'm assuming we won't have trouble building URLs in JS with data from the API response. Thinking a little more, I could see generating version/language specific URLs in the response might require a per-version/language cached API response instead of per-project -- but at least that is far better than per-page.

Ideas for implementation here:

Pass the filename data into HTML via the Cloudflare worker via HTTP header from proxito, and use that data in the addons JS via the HTML.
Return a string in the Addons API endpoint that we can use to get the filename from the current document URL (eg. document.url.replace('/en/latest/'))

This change is deployed. Now, switching between versions/languages from the flyout addons will keep the page the user is looking at on the version/language destination.

Tested it and it works 🙏 Thank you folks!


Got stale element reference error when use checkElement function

Environment (please complete the following information):

Node.js version: 14.17.3
NPM version: 6.14.13
Browser name and version: 93.0.4577.63 (arm64)
Platform name and version: MAC OS 11.5 (APPLE M1)
WebdriverIO version: 7.9.1
wdio-image-comparison-service version: 7.2.0

Describe the bug
await browser.url('http://www.baidu.com')
await browser.checkElement($('#kw'), 'baidu', { /* some options */ })

Got error in checkElement function
To Reproduce
For more detail, please refer to project below:
https://github.com/Curt900701/issues_image-camparison
And run with command npm run test
Log
> @ test /Users/dongyang/Project/github/issues_image-camparison
> npx wdio run wdio.conf.js

Execution of 1 workers started at 2021-09-17T13:36:02.950Z

2021-09-17T13:36:06.829Z INFO @wdio/cli:launcher: Run onPrepare hook
2021-09-17T13:36:06.833Z INFO @wdio/cli:launcher: Run onWorkerStart hook
2021-09-17T13:36:06.835Z INFO @wdio/local-runner: Start worker 0-0 with arg: run,wdio.conf.js
[0-0] 2021-09-17T13:36:07.223Z INFO @wdio/local-runner: Run worker command: run
[0-0] RUNNING in chrome - /cases/test.js
[0-0] 2021-09-17T13:36:07.447Z INFO devtools:puppeteer: Initiate new session using the DevTools protocol
[0-0] 2021-09-17T13:36:07.449Z INFO devtools: Launch Google Chrome with flags: --enable-automation --disable-popup-blocking --disable-extensions --disable-background-networking --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-sync --metrics-recording-only --disable-default-apps --mute-audio --no-first-run --no-default-browser-check --disable-hang-monitor --disable-prompt-on-repost --disable-client-side-phishing-detection --password-store=basic --use-mock-keychain --disable-component-extensions-with-background-pages --disable-breakpad --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-renderer-backgrounding --force-fieldtrials=*BackgroundTracing/default/ --enable-features=NetworkService,NetworkServiceInProcess --disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees --window-position=0,0 --window-size=1200,900 --window-size=1920,1080
[0-0] 2021-09-17T13:36:09.554Z INFO devtools: Connect Puppeteer with browser on port 51554
[0-0] 2021-09-17T13:36:10.534Z INFO wdio-image-comparison-service: Adding commands to global browser
[0-0] 2021-09-17T13:36:10.553Z INFO devtools: COMMAND navigateTo("http://www.baidu.com/")
[0-0] 2021-09-17T13:36:11.968Z INFO devtools: RESULT null
[0-0] 2021-09-17T13:36:11.969Z INFO webdriver: COMMAND checkElement(<object>, "baidu", <object>)
[0-0] 2021-09-17T13:36:12.043Z INFO devtools: COMMAND findElement("css selector", "#kw")
[0-0] 2021-09-17T13:36:12.044Z INFO devtools: COMMAND executeScript(<fn>, <object>)
[0-0] 2021-09-17T13:36:12.086Z INFO devtools: RESULT { 'element-6066-11e4-a52e-4f735466cecf': 'ELEMENT-1' }
[0-0] 2021-09-17T13:36:12.127Z INFO devtools: COMMAND executeScript(<fn>, <object>)
[0-0] 2021-09-17T13:36:12.140Z INFO devtools: RESULT {
[0-0]   dimensions: {
[0-0]     body: { scrollHeight: 688, offsetHeight: 688 },
[0-0]     html: {
[0-0]       clientHeight: 688,
[0-0]       clientWidth: 1440,
[0-0]       scrollHeight: 688,
[0-0]       scrollWidth: 1440,
[0-0]       offsetHeight: 688
[0-0]     },
[0-0]     window: {
[0-0]       innerWidth: 1440,
[0-0]       innerHeight: 688,
[0-0]       outerHeight: 811,
[0-0]       outerWidth: 1440,
[0-0]       devicePixelRatio: 2,
[0-0]       screenWidth: 1440,
[0-0]       screenHeight: 900
[0-0]     }
[0-0]   }
[0-0] }
[0-0] 2021-09-17T13:36:12.143Z INFO devtools: COMMAND takeScreenshot()
[0-0] 2021-09-17T13:36:12.451Z INFO devtools: RESULT iVBORw0KGgoAAAANSUhEUgAAC0AAAAVcCAYAAACvZBvdAAABKmlDQ1BTa2lhA...
[0-0] 2021-09-17T13:36:12.454Z INFO devtools: COMMAND executeScript(<fn>, <object>)
[0-0] stale element reference in "tests should be OK"
stale element reference: The element with reference (...args) => target.then(async (elem) => {
                    if (!elem) {
                        let errMsg = 'Element could not be found';
                        const prevElem = await promise;
                        if (Array.isArray(prevElem) && prevInnerArgs && prevInnerArgs.prop === 'get') {
                            errMsg = `Index out of bounds! $$(${prevInnerArgs.args[0]}) returned only ${prevElem.length} elements.`;
                        }
                        throw new Error(errMsg);
                    }
                    return elem[prop](...args);
                }) is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
stale element reference: stale element reference: The element with reference (...args) => target.then(async (elem) => {
                    if (!elem) {
                        let errMsg = 'Element could not be found';
                        const prevElem = await promise;
                        if (Array.isArray(prevElem) && prevInnerArgs && prevInnerArgs.prop === 'get') {
                            errMsg = `Index out of bounds! $$(${prevInnerArgs.args[0]}) returned only ${prevElem.length} elements.`;
                        }
                        throw new Error(errMsg);
                    }
                    return elem[prop](...args);
                }) is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
    at getStaleElementError (/Users/dongyang/Project/github/issues_image-camparison/node_modules/devtools/build/utils.js:183:19)
    at /Users/dongyang/Project/github/issues_image-camparison/node_modules/devtools/build/utils.js:156:23
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Promise.all (index 0)
[0-0] 2021-09-17T13:36:12.464Z INFO devtools: COMMAND deleteSession()
[0-0] 2021-09-17T13:36:12.465Z INFO devtools: RESULT null
[0-0] FAILED in chrome - /cases/test.js
2021-09-17T13:36:12.601Z INFO @wdio/cli:launcher: Run onComplete hook

 "spec" Reporter:
------------------------------------------------------------------
[Chrome 93.0.4577.82 darwin #0-0] Running: Chrome (v93.0.4577.82) on darwin
[Chrome 93.0.4577.82 darwin #0-0] Session ID: 450a2f5a-6554-49ed-9aa9-84a14477c17c
[Chrome 93.0.4577.82 darwin #0-0]
[Chrome 93.0.4577.82 darwin #0-0] » /cases/test.js
[Chrome 93.0.4577.82 darwin #0-0] tests
[Chrome 93.0.4577.82 darwin #0-0]    ✖ should be OK
[Chrome 93.0.4577.82 darwin #0-0]
[Chrome 93.0.4577.82 darwin #0-0] 1 failing (1.9s)
[Chrome 93.0.4577.82 darwin #0-0]
[Chrome 93.0.4577.82 darwin #0-0] 1) tests should be OK
[Chrome 93.0.4577.82 darwin #0-0] stale element reference: The element with reference (...args) => target.then(async (elem) => {
                    if (!elem) {
                        let errMsg = 'Element could not be found';
                        const prevElem = await promise;
                        if (Array.isArray(prevElem) && prevInnerArgs && prevInnerArgs.prop === 'get') {
                            errMsg = `Index out of bounds! $$(${prevInnerArgs.args[0]}) returned only ${prevElem.length} elements.`;
                        }
                        throw new Error(errMsg);
                    }
                    return elem[prop](...args);
                }) is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
[Chrome 93.0.4577.82 darwin #0-0] stale element reference: The element with reference (...args) => target.then(async (elem) => {
[Chrome 93.0.4577.82 darwin #0-0]                     if (!elem) {
[Chrome 93.0.4577.82 darwin #0-0]                         let errMsg = 'Element could not be found';
[Chrome 93.0.4577.82 darwin #0-0]                         const prevElem = await promise;
[Chrome 93.0.4577.82 darwin #0-0]                         if (Array.isArray(prevElem) && prevInnerArgs && prevInnerArgs.prop === 'get') {
[Chrome 93.0.4577.82 darwin #0-0]                             errMsg = `Index out of bounds! $$(${prevInnerArgs.args[0]}) returned only ${prevElem.length} elements.`;
[Chrome 93.0.4577.82 darwin #0-0]                         }
[Chrome 93.0.4577.82 darwin #0-0]                         throw new Error(errMsg);
[Chrome 93.0.4577.82 darwin #0-0]                     }
[Chrome 93.0.4577.82 darwin #0-0]                     return elem[prop](...args);
[Chrome 93.0.4577.82 darwin #0-0]                 }) is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
[Chrome 93.0.4577.82 darwin #0-0] stale element reference: stale element reference: The element with reference (...args) => target.then(async (elem) => {
[Chrome 93.0.4577.82 darwin #0-0]                     if (!elem) {
[Chrome 93.0.4577.82 darwin #0-0]                         let errMsg = 'Element could not be found';
[Chrome 93.0.4577.82 darwin #0-0]                         const prevElem = await promise;
[Chrome 93.0.4577.82 darwin #0-0]                         if (Array.isArray(prevElem) && prevInnerArgs && prevInnerArgs.prop === 'get') {
[Chrome 93.0.4577.82 darwin #0-0]                             errMsg = `Index out of bounds! $$(${prevInnerArgs.args[0]}) returned only ${prevElem.length} elements.`;
[Chrome 93.0.4577.82 darwin #0-0]                         }
[Chrome 93.0.4577.82 darwin #0-0]                         throw new Error(errMsg);
[Chrome 93.0.4577.82 darwin #0-0]                     }
[Chrome 93.0.4577.82 darwin #0-0]                     return elem[prop](...args);
[Chrome 93.0.4577.82 darwin #0-0]                 }) is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
[Chrome 93.0.4577.82 darwin #0-0]     at getStaleElementError (/Users/dongyang/Project/github/issues_image-camparison/node_modules/devtools/build/utils.js:183:19)
[Chrome 93.0.4577.82 darwin #0-0]     at /Users/dongyang/Project/github/issues_image-camparison/node_modules/devtools/build/utils.js:156:23
[Chrome 93.0.4577.82 darwin #0-0]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[Chrome 93.0.4577.82 darwin #0-0]     at async Promise.all (index 0)

Spec Files:      0 passed, 1 failed, 1 total (100% completed) in 00:00:09

2021-09-17T13:36:12.602Z INFO @wdio/local-runner: Shutting down spawned worker
2021-09-17T13:36:12.856Z INFO @wdio/local-runner: Waiting for 0 to shut down gracefully
2021-09-17T13:36:12.857Z INFO @wdio/local-runner: shutting down
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ test: `npx wdio run wdio.conf.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@wswebcreation Could you kindly help to confirm?

Hi @Curt900701 ,
if you use async mode you have to give an await to variables.
Try:
await browser.checkElement(await $('#kw'), 'baidu', { /* some options */ })
Does this help?
BR
Fabian Schmider

@opensourcesensor
Yes, that works now.
Thank you for the confirmation.
Please let me close the issue.

Thanks @opensourcesensor for helping out with this


[FluxCD Addon]Cannot see Resource Graph in Kustomization

I have a Deployment resource and a Service resource in my Kustomization App But VelaUX didn't show these resource.

Expect
show all the resources like HelmRelease in the Resource Graph like below:

The reason is there is a built-in topology-rule of helmRelease and it's sub-resources. Are you interested in contributing to solve this issue  by adding a topology-rule for kutomize. Here are some related docs: https://kubevela.net/docs/platform-engineers/addon/addon-cue#auxiliary-resources , https://kubevela.net/docs/reference/topology-rule.

Thanks. I'd like to tackle this one.
/assign

I see. The HelmRelease type resource are built-in velaql .
I'd better put the kustomize rule in configmap and let vela merge it.

Hi guys. I found this can only be implemented by built-in velaql way like HelmRelease.
velaql can list all the resource the HelmRelease has because of the helmRelease2AnyListOption func but we cannot pass function or pass dynamic relevant labels through configmap. And a Deployment doesn't have OwnerReferences with its Kustomization so it also cannot be listed through GetOwnerReferences when the ListOption func is missed.


[Request] /add command to add Accounts

Why is there no /add command to add Accounts within Telegram?

Never bothered to add one. I haven't used the project for a long time. Feel free to fork and send a PR.


sync en-zh zh/docs/setup/production-environment/tools/kubeadm/troubleshooting-kubeadm.md

refer https://github.com/kubernetes/website/pull/19293
Git line breaks changed to unix mode on Windows, causing this problem.

/cc @tengqm
/cc @xichengliudui

/lgtm
/approve


Add restoration of page hash

This allows Spook to stay on the same slide when refreshing reveal.js slideshows.

Very useful, thanks!

Thanks again, included in the just-release v0.1.1.


Can't resume uploads!

I am developing a website using Laravel, and I am using tus-js-client to upload files directly to Vimeo without going through my server. The uploading works perfect.
But, lets say the uploading reached 44%, and then the user refreshed the browser... as I understand It should continue uploading from 44% when the user start uploading the same file again.. but that doesn't happen!
  // Create a new tus upload
  var self = this;
  // Send request to server to get uploadUrl endpoint from Vimeo api
  var uploadEndPoint = self.getUploadEndPoint();
  // Start uploading
  self.uploader = new tus.Upload(file, {
    uploadUrl: uploadEndPoint,
    retryDelays: [0, 1000, 3000, 5000],
    metadata: {
      filename: file.name,
      filetype: file.type
    },
    resume: true,
    uploadSize: file.size,
    onError: function(error) {
      console.log("Failed because: " + error);
    },
    onProgress: function(bytesUploaded, bytesTotal) {
      var percentage = (bytesUploaded / bytesTotal * 100).toFixed(2);
      console.log(bytesUploaded, bytesTotal, percentage + "%");
    },
    onSuccess: function() {
      console.log(
        "Download %s from %s",
        self.uploader.file.name,
        self.uploader.url
      );
    }
  });

But, lets say the uploading reached 44%, and then the user refreshed the browser... as I understand It should continue uploading from 44% when the user start uploading the same file again.. but that doesn't happen!

That's how it should behave, you are right. What is happening instead?

I think this is happening because when I send an API request to Vimeo to get an uploadUrl endpoint It will give me a new uploadUrl endpoint when the user refresh the page..

I think this is happening because when I send an API request to Vimeo to get an uploadUrl endpoint It will give me a new uploadUrl endpoint when the user refresh the page..

That seems to be the likely cause as far as I can tell.

but isn't this the "resume = true" job? as I understand:
User was uploading a file then when it reached 44%, the user refreshed the page, then the user re-upload the same file again:
1 - check if the file object is stored in the storage (using fingerprint unique string).
2 - if the file is there (fingerprint) get the uploadUrl to resume the upload for the same file to the previous uploadUrl endpoint.
Is this right?

but isn't this the "resume = true" job?

Not in this case. If you supply a uploadUrl, tus-js-client will resume using this URL even if the file has been uploaded to some other URL before. This fact is also stated in the documentation:

uploadUrl = null: a URL which will be used to directly attempt a resume without generating the fingerprint and looking it up before.

However, if no uploadUrl is given, you would be correct.

Is there a way to check if the (fingerprint) for the file exist?

No, there is currently no way to do so.

Thank you for your help, I have solved the issue using server-side cache.

Hi @Acconut, pretty same issue I am facing for couple of days. In my case, when I click on resume for a paused upload, it begins from the start. I checked the solution that 'ghost' resolved by. I am using file based cache in server-side where I have .cache/ folder having 'tus_php.server.cache' file. A sample entry looks like when I click pause:
"tus:server:41b5c307-a9c5-406a-8a3a-a2335732ecf4":{"name":"IMG_0045.JPG","size":2078503,"offset":0,"checksum":"","location":"http://example.com/files/41b5c307-a9c5-406a-8a3a-a2335732ecf4","file_path":"/var/www/vhosts/example.com/uppy/uploads/IMG_0045.JPG","created_at":"Sun, 21 Apr 2019 05:53:01 GMT","expires_at":"Mon, 22 Apr 2019 05:53:01 GMT","upload_type":"normal"}}
Once it is uploaded without any pause, the cache file looks like:
"tus:server:41b5c307-a9c5-406a-8a3a-a2335732ecf4":{"offset":2078503,"name":"IMG_0045.JPG","size":2078503,"checksum":"","location":"http://example.com/files/41b5c307-a9c5-406a-8a3a-a2335732ecf4","file_path":"/var/www/vhosts/example.com/uppy/uploads/IMG_0045.JPG","created_at":"Sun, 21 Apr 2019 05:53:01 GMT","expires_at":"Mon, 22 Apr 2019 05:53:01 GMT","upload_type":"normal"}}
Only the offset has been changed. If I am missing anything on the server side cache settings. I am using tus-js-client at client side. Here is the Tus config at client:
     .use(Tus, { 		  endpoint: '/files/', // use your tus endpoint here 		  resume: true, 		  autoRetry: true, 		  retryDelays: [0, 1000, 3000, 5000] 		})
Thanks in advance.

@mahmudul I don't see an inherent problem with your configuration but it might be caused by tus_php, which I have never used personally. Does the problem persist if you use https://master.tus.io/files/ (notice the trailing slash) as the endpoint? If the problem vanishes we know that is likely caused by the server and not by tus-js-client. Also what environment are you in? I would assume the browser, right?

Hi @Acconut, thanks for your reply. Yes I am using browser and https://master.tus.io/files/ is working fine as Tus endpoint. It also works well in my local pc environment using file cache. So, it should be server side issue. I can see that the file opcache is disabled in the server and suspecting that could be the cause. Though it's not a tus-js-client issue, may I ask you whether enabling opcache could resolve the issue? I am hopeful but not sure 100%.

So, it should be server side issue.

Yes, I agree with that.

I can see that the file opcache is disabled in the server and suspecting that could be the cause. Though it's not a tus-js-client issue, may I ask you whether enabling opcache could resolve the issue?

Frankly, I don't know. I have never used tus_php and my PHP knowledge does not include opcache. So I can't help you there and would recommend that you just give it a try.

Thanks @Acconut for your time on this. I'll have a try. I have opened an issue at tus-php that I am using as tus server. May be the owner could  provide some insights.
Cheers.

Hi can we upload file direct to GCS using presigned url using this library?


#240: Update the library up to the version 1.92.0 of the API

@rultor merge

@rultor merge

@proshin-roman OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@proshin-roman Done! FYI, the full log is here (took me 2min)


[Client][Reader API] Bypass broker when reading a segment in BookKeeper

When we are using the reader API, one of the optimizations we could achieve is bypass broker when the segment exists in BookKeeper. Therefore, the preferred workflow should be:

check the startingPosition to see if it is pointing to a finished ledger on the bookies, if so, read it from bookies directly.
for the in-progress ledger in a broker, read procedure should be identical to the current implementation.

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


flex: Add PV name to delete

PV name is required even when deleting as much as provisioning.
I added the PV Name to the Delete function in the same way as the provision.go source.
This is the tested output.
2018-07-31 07:29:33 flex[37]: delete() called: {"kubernetes.io/pvOrVolumeName":"pvc-6e9b3727-9493-11e8-afe6-525400d87180"}
2018-07-31 07:29:33 flex[37]: log() called: {"status": "Success"}

/lgtm


Missing button to "Create New Incident"

Hi,
I'm experiencing some odd things with this app.  I got it successfully deployed on Tuesday and it worked briefly before having some authentication issues.  The issues resolved themselves yesterday, but now I no longer get the button to "Create New Incident" in the top of the app.  I am experiencing this with site Members and Site Owners.  Please see screenshots of the button appearing correctly previously and not appearing anymore.  Any guidance would be appreciated!

@MetalTark , Thank you for reporting this.
Please open teams in browser, then open the app and share console logs and network traces which will help us to troubleshoot the issue.
Also request you to share the manifest files with us.

Hi, here is what I'm seeing in the console when loading the app in the Teams web client.
teams.microsoft.com-1710257723503.log

Here's the manifest file.  I'm unable to get the network traces at the moment, please let me know if that is imperative.
manifest.json

Also, I updated to 3.0 but I'm still having the same issue being able to create a new incident.

@MetalTark , Thank you for sharing the details.
If you've enabled Roles, then you need to assign users who can create new incident.

To Verify whether roles are enabled or not, you can go to TEOC Site and Open TEOC-Config List check value of Enable Roles.

We enabled mapping and roles, and this posting was very helpful.  Thank you.

Hi @v-ajaysahu, thanks much for responding.  I verified Roles are enabled (value is set to True) but I don't see a hyperlink to Assign Roles like you do.  Where do I assign roles?  Thank you!

@MetalTark ,
Once you enable the Roles you need to Click on Save.

Once your configuration is saved then only Assign Roles link will appear.
If you are still facing the issue, then kindly share the Console Logs and Network traces.

My TEOC List looks and functions much differently than yours.  See screenshot.  Mine is just free text values, not a Y/N field.

OK, I think I figured it out.  I found a "TEOCUserRoles" list here and added my email address to this and the Create New Incident button appeared.  Should I do anything to upgrade/fix my lists?
/Lists/TEOCUserRoles


Added doubleclick select word behavior, fixing issue #2230

Added doubleclick select word behavior, fixing issue #2230

Triple click selects the whole line it seems :) and it's a true triple click, not double clicking already highlighted text or whatever. Not sure how that works, and that can be a separate issue

Thanks!


perf(NumberTheory): speed up some slow declarations

discovered while investigating slowdowns in #16975, see Zulip

!bench

bors merge