MismatchedInputException: Cannot construct instance of ee.nx01.tonclient.CreateContextResponse

When using android + proguard, Im getting:
Caused by: com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of ee.nx01.tonclient.CreateContextResponse (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator) at [Source: (String)"{"result":1}"; line: 1, column: 2]
Versions I use:
1 - com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS>
2 - com.fasterxml.jackson.module:jackson-module-kotlin:2.13.2
Any idea how to solve?

Please try update to latest version library (0.0.55) and update jackson to 2.14.0 version

@mdorofeev hi. I updated to suggested versions - the same issue.
It only reproducible using proguard on android. without proguard - all good.


Refactor: remove FastWriter and rename NormalWriter

Remove FastWriter

Rename NormalWriter to StreamWriter

Remove INDEX_SUPPORT attributes. All Workbook and Writer can use index assignment not.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.88%. Comparing base (a12adb2) to head (568b268).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   97.76%   91.88%   -5.89%
==========================================
  Files          10        4       -6
  Lines        1119      271     -848
==========================================
- Hits         1094      249     -845
+ Misses         16       13       -3
  Partials        9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[FSSDK-0000] chore: rollback to 4.0.0

Summary

Rollback to 4.0.0

The "why", or other context.
Test plan
Issues

"FSSDK-0000"

It looks like reverting 4.0.2 only, not 4.0.1.

Oh, I thought only forwarding exception part should be updated.
So, we need to remove ClientForODPOnly class also, right?


Integrate AnimationLoop with AppComponent

add Component.onLoopUpdate = Component.method || Component.update
add Component.onLoopDraw = Component.method || Component.render

checks in ApplicationDomComponent for instances with this methods and executes them, when Loop is in a specific state

Can be mixed with ApplicationDomComponent or every other object


Auto-play Video

How can I decrease the autoplay delay from youtube video example?

The YouTube player version of the template is using YTPlayer plugin, you can find more info on the plugin here: https://github.com/pupunzi/jquery.mb.YTPlayer/wiki.
You need to specifically look at is this part:
startAt: 20 (number) Set the seconds the video should start at.
stopAt: 20 (number) Set the seconds the video should stop at. If 0 is ignored.


Create main.whiley

Thanks, I will try out the code on my machine and merge it. Feel free to add more commits to this branch until then.

Closing in favor of #5


invalid token size received

I receive tokens that are of size 9 which cause the exception to be thrown. Any ideas why?
 protected int readListSize(int token)
        {
            int size = 0;
            if (token == 0)
            {
                size = 0;
            }
            else if (token == 0xf8)
            {
                size = this.readInt8();
            }
            else if (token == 0xf9)
            {
                size = this.readInt16();
            }
            else
            {
                throw new Exception("BinTreeNodeReader->readListSize: Invalid token " + token);
            }
            return size;
        }

it seems that the invalid token size exception above occurs after the following debug messages:
tx
A first chance exception of type 'System.Exception' occurred in WhatsAppApi.dll
DEBUG: System.Exception: MAC mismatch on index 0! 99 != 145
at WhatsAppApi.Helper.KeyStream.DecodeMessage(Byte[] buffer, Int32 macOffset, Int32 offset, Int32 length) in c:\Work\VMShared\TECO_WA_API\NEW CODE

Yes, ill update it this weekend. If you want port it from Chat API

will do. just please direct me to the function that needs to be ported by commenting on this issue with a link. Thanks @mgp25

Post full code and debug log and i will fix it in a couple hours
Regards

Try last commit, send me feedback, send me your code and debug log so i can improve the code
Regards

hi @mgp25 I tried the last commit and at random events. I noticed when I send the sync contact to check if users are WA users I get the problem I mentioned before.
I looked the event viewer where my app is supposed to be running all the time and I find out that my app gets terminated. the below is registered in the event log.
Application: TECO_WA.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Exception
Stack:
at WhatsAppApi.Helper.BinTreeNodeReader.readListSize(Int32)
at WhatsAppApi.Helper.BinTreeNodeReader.nextTreeInternal()
at WhatsAppApi.Helper.BinTreeNodeReader.nextTree(Byte[], Boolean)
at WhatsAppApi.WhatsSendBase.processInboundData(Byte[], Boolean)
at WhatsAppApi.WhatsSendBase.pollMessage(Boolean)
at WhatsAppApi.WhatsSendBase.PollMessages(Boolean)
at TECO_WA.Form1.b__19(System.Object)
at System.Threading.ThreadHelper.ThreadStart_Context(System.Object)
at System.Threading.ExecutionContext.Run
Any ideas on why this is happening? Thanks.

@alijundi post code and request. Please quote output and code

@mgp25 I appreciate your assistance but I do not have an output. The App terminates and all the debug is lost! how should I proceed?

@alijundi change debug to true, run it in terminal

@mgp25 I understand what you are saying. But what I am trying to say is that I see the debug and all is fine for 3-5 hours and then all of a sudden the app terminates and the all the debug is lost with it. now if I run it in the debugger I get the exception (throw new Exception("BinTreeNodeReader->readListSize: Invalid token " + token); thrown!
I think I will run it tomorrow on the debugger and when I get this exception I will copy and paste the log and post it here. please be patient.

@mgp25  Below is the debug information that leads to invalid token received. Is it useful?
rx stream:error
rx
rx </stream:error>
Connection LOST
DEBUG:
tx stream:features
tx
tx   <groups_v2></groups_v2>
tx
tx
tx </stream:features>
DEBUG:
tx n?6?|?2A?zc?!p??3?DEBUG:
rx <s.whatsapp.net></s.whatsapp.net>
DEBUG:
tx
DEBUG:
tx
DEBUG:
tx stream:features
tx
tx   <groups_v2></groups_v2>
tx
tx
tx </stream:features>
DEBUG:
tx ?w?A|?2A?zc?!p??3?DEBUG:
rx <s.whatsapp.net></s.whatsapp.net>
DEBUG:
tx
Error Connecting
DEBUG:
tx stream:features
tx
tx   <groups_v2></groups_v2>
tx
tx
tx </stream:features>
DEBUG:
tx ?1I|?2A?zc?!p??3?DEBUG:
rx <s.whatsapp.net></s.whatsapp.net>
tx
DEBUG:
tx stream:features
tx
tx   <groups_v2></groups_v2>
tx
tx
tx </stream:features>
DEBUG:
tx ??3?|?2A?zc?!p??3?DEBUG:
rx <s.whatsapp.net></s.whatsapp.net>
DEBUG:
tx
Sending Active......


Feature/orchestration signing

In this branch I am working on adding support for for unattend probe orchestration via signing of JWT tokens.

I think that for the purpose of having an MVP this is ready.
I will write down here a list of notes on how to actually use this. I am going to assume you have a yubikey 4 token. It's designed to maybe work with other HSM too, but it has not been tested at all.
Building ooni-orchestrate
ooni-orchestrate is the CLI tool that is used by probe operators to sign the experiment requests. You should, therefore first build this CLI tool to get everything up and running by doing:
make build-orchestrate

You will then have a orchestrate binary built in bin/ooni-orchestrate.
Requirements
The requirements for running this are:

golang obviously
yubico-piv-tool (on macOS `brew install yubico-piv-tool)
yubikey piv manager

Config file for ooni-orchestrate
It's useful, especially while testing, to fill out the ooni-orchestrate.toml config file for testing. You should create a file called private/ooni-orchestrate.toml (the private dir is gitignored), that contains the following:
[core]
environment = "development"
log-level = "debug"
gorush-url = "http://localhost:8081"
notify-topic-ios = "org.openobservatory.NetProbe"
notify-click-action-android = "org.openobservatory.ooniprobe.OPEN_BROWSER"

[auth]
jwt-secret = "TESTING"
#gorush-basic-auth-user = ""
#gorush-basic-auth-password = ""

[api]
port = 8082
address = "<IP_ADDRESS>"
default-inputs-to-return = 10

[database]
url = "postgres://ooni:password@localhost:32770/proteus?sslmode=disable"

[operator]
private-key = "private/ooni-orchestrate.priv"
public-key = "private/ooni-orchestrate.pub"
pkcs11-lib-path = "/usr/local/lib/libykcs11.dylib"
token-serial = "1234"
user-pin = "81239213"
so-pin = "fccccdeadbeef"
key-id = 11

The values you will want to change in this config file are:
user-pin, which should be set to the user pin of your yubikey. I recommend using the YubiKey PIV manager for setting up the user pin (see: https://developers.yubico.com/yubikey-piv-manager/), but it can also be done using the yubikey CLI tools.
so-pin, which should be set to what the YubiKey PIV manager calls the "Management Key".
pkcs11-lib-path, if you are on macos and installed yubico-piv-tool using homebrew this should be ok. Otherwise change it to the path to the dynamic library for  libykcs11.xx.
In theory by changing this it should work with any other HSM that implements PKCS#11, though the code does include some hacks that are yubikey specific, so it may break and you should be prepared to fix it yourself 😸 .
What you may want to change (but it has not been tested extensively) is:
key-id, this is an ID used to reference the key on the yubikey 4. It may be useful to change this to something else if you plan on using the yubikey for something other than OONI Probe orchestration, though it's not recommended.
What you should not change (unless you want to experiment with other HSMs):
token-serial, this is a magic number that yubikey 4 uses to identify the key using it's pkcs11 implementation. You may have to change this when using other HSMs.
Creating keys
You should create your shiny new key by running:
./bin/ooni-orchestrate --config private/ooni-orchestrate.toml keygen

If you have configured the ooni-orchestrate.toml file properly, you should not be prompted to enter any SO pin (or you will if you omitted that value in the config) and you should soon have a key fresh new key loaded into your yubikey.
The keyid is currently generated in a bit of ghetto way (due to the lack of a standard key serialisation scheme). See: https://github.com/ooni/orchestra/blob/feature/orchestration-signing/orchestrate/orchestrate/sched/experiment.go#L46
Basically you can just do:
shasum -a 256 private/ooni-orchestrate.pub

To get your public key fingerprint.
If you want to test the full workflow, be sure to replace the keyPEM (https://github.com/ooni/orchestra/blob/feature/orchestration-signing/orchestrate/orchestrate/sched/experiment.go#L46) with your own public key.
Signing tokens
To sign tokens you should copy paste the command on the web UI into your terminal, but be sure to add a path to your config file (since it's passed via stdin you need to have your pins in the config file).
Example:
echo "SOMEBLOB" | \
  ./bin/ooni-orchestrate --config private/ooni-orchestrate.toml sign

You will then be prompted to tap the yubikey 4 button and you will get back a signed token. Copy paste that token in the web UI and you are good to go.
Notes: I still need to improve the validation of these fields, so you mess something up you may get a messed up signed_experiment scheduled.
Adding users
There is now a feature to add new users to the database. To add a user you need to have:

a username
a password
a keyid

You can add a user by doing:
./bin/ooni-orchestrate --config private/ooni-orchestrate.toml adduser -u jon -p mypassword -k KEYID

Be sure to have a valid database string (for example a database setup on localhost) that you have run one of the backend on at least once (so the DB tables have been created).

I made some hotfixes to this branch, some of which I cherry picked into master and rebased this branch on top of it.

To make it more clear that ooni-orchestrate is different from the local ooni-operator workflow and moved all that functionality into a separate CLI tool.
I have added what was previously in a comment above, to the Readme.md.

Most of the changes above are related to getting better integration testing.
So far I have tests for:
• Registering and updating probe metadata
• Creating an admin user & scheduling a signed experiment

We should decide what we want to about the code in here which has at this point rotted.
cc @bassosimone @FedericoCeratto


Add a cache for resource_find

Before:
resource_find dominates render time, causing noticable lag in rendering.

Caching in user code, always passing an absolute path, the large amount of abspath calls still take significant time, but don't dominate.

After this PR, no file calls to be found and rendering is smooth.

Maintainer merge checklist

[ ] Title is descriptive/clear for inclusion in release notes.
[ ] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[ ] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[x] Properly documented, including versionadded, versionchanged as needed.

Alright, will let you figure out where and when to merge it, let me know if you need anything from me.
For anyone else having this issue in the mean time, I found that using texture=cached_texture(path) instead of source=path on canvas instructions eliminates this problem completely.
# direct cache to texture, bypassing resource_find
def cached_texture(path,_cache={}):
    tex = _cache.get(path)
    if not tex:
        tex = _cache[path] = Image(resource_find(path)).texture
    return tex


Streamlining of Scaled Dot-Product Attention

WIP PR for trying ideas and bug fixes for streamlining the scaled dot-product attention operator. Related to issue/discussion #878

[x] Refactor MoveScalarMulPastMatMul for two-input join-node matmuls
[x] Fix Absorb1BitMulIntoMatMul and Absorb1BitMulIntoConv test for the presence of weight initializers
[x] Debug InferShapes fails after FoldTransposeIntoQuantInit
[x] Circumvent MoveScalarAddPastMatMul by preferring AbsorbSignBiasIntoMultiThreshold
[ ] Validate that these changes do not break something or change the behavior in subtle ways

The "InferShapes fails after FoldTransposeIntoQuantInit" problem probably needs to be fixed within QONNX, see PR https://github.com/fastmachinelearning/qonnx/pull/78.

In addition to the unit tests included here, I have now rebuilt all finn-examples up to the convert_to_hls step (or rather until the step_create_dataflow_partition which is required for some of the expected outputs). I have also completely rebuilt the bnn-pynq example for the Pynq-Z1 target, as well as the kws example which seems to be the only one including verification steps. I did not see any errors and the verification steps reported SUCCESS, is there anything else I could or should do?

Reverted this to a draft as we have found more issues while streamlining more realistic dummy models. I will add the issues to the list in #878 and start working on fixes soon.

Might depend on this PR at QONNX https://github.com/fastmachinelearning/qonnx/pull/85, introducing a new cleanup transformation ensuring input order assumptions.

The RemoveIdentityOps handling fork-node producer (currently failing when the graph contains packed input projections) will be fixed by this PR at QONNX: https://github.com/fastmachinelearning/qonnx/pull/87

We need this one as well: https://github.com/fastmachinelearning/qonnx/pull/89

We might want to have this one included as well to support python-mode execution of the graph at any step for verification purposes: https://github.com/fastmachinelearning/qonnx/pull/92

This one is relevant as well to properly streamline attention head splitting/merging: https://github.com/fastmachinelearning/qonnx/pull/107


concepts are there, not execution

Not ready for pull yet, just to let yall see it

lots of changes since this was made


[SALEOR-3677] Add ability to capture all active payments

I want to merge this change because
I need that OrderConfirm mutation trigger capture action on all active payments
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3677 OrderConfirm mutation should triggers capture action on all active payments

@IKarbowiak @korycins pinging you as I can't edit the original PR. The changes from the original are now:

I used a dataclass instead of dicts in order to transmit information amount payment + amount (actually, I think it's already called a Transaction and that's how it usually gets created 🤔 )
Capture is called universally when an order is being confirmed
Tests are improved to check the order of triggered events
The same logic is used in the OrderCapture mutation
There are some more changes coming that are related to handling multiple payments, eg. in refund https://github.com/SaleorIntegrations/saleor/pull/27/files - I'm happy to push it for review as well, but I didn't want to make this PR extra large. This subsequent PR also makes some code style improvements to the functions used in this PR (e.g. clean_payment(payments)). It also restores a logic where order mutations throw payment errors instead of silent failing


Multi region support in same cluster

Description
What problem are you trying to solve?
We are running custom Karpenter implementation with k3s
We would like to extend to have one Karpenter handling multi region support in a single Kubernetes cluster. I can see subnetSelector assumes the current region.
Would we need to deploy multiple Karpenters to handle this scenario?
It is an option to have two separate clusters but for the use case we're OK with geo extended.

We don't currently have multi-region support. The biggest reason for this is the expected communication latency between the worker nodes and the control-plane, which I'm assuming has to be a single region, even in k3s due to etcd leader being tied to a single region.
Is there a way that you overcome that latency?

For our use case it's not an issue. 140ms is totally fine for where these worker nodes are going to be doing.
Is it possible to run multiple Karpenters in the same cluster with AWS_REGION set and monitoring different provisioners / node templates? Or will they trip over each other?

We don't currently have multi-region support. The biggest reason for this is the expected communication latency between the worker nodes and the control-plane, which I'm assuming has to be a single region, even in k3s due to etcd leader being tied to a single region.
Is there a way that you overcome that latency?

@jonathan-innis For our use case it's not an issue. 140ms is totally fine for where these worker nodes are going to be doing.
Is it possible to run multiple Karpenters in the same cluster with AWS_REGION set differently and monitoring different provisioners / node templates? Or will they trip over each other?

Or will they trip over each other

Yeah, they'd definitely trip over each other. There's potentially a possibility that sometime deep in the future we might support the ability to run two at one time in the same cluster with some kind of global lock/lease hand-off mechanism, but right now, they are running with the assumption that they are a singleton in the cluster.

Thank you. Appreciate the engagement.

Appreciate the discussion and engagement

No problem 👍 Definitely think that this could be a neat feature down-the-line, whether we support multi-region Karpenter natively or whether we allow multiple Karpenters to run in the same cluster

Jumping in here with the same request. Our use case involves running large batch inference jobs where AWS can run out of GPUs in a single region. We want to have our single cluster be able to provision nodes from multiple regions.


running setup.py install > RuntimeError: Python version >= 3.5 required

Dear *,
I just tried to install gemini in an ubuntu 19.04 docker container.
I first installed the dependencies, I found:
apt-get update && apt-get install -y wget python gcc zlib1g-dev tabix build-essential grabix bedtools git python-pip
pip install pybedtools
I then pulled either the GIT repo or used the release v0.30.1
and ran :
python setup.py install
This lead to the error below, demanding a python3.5 or greater.
Someone has any ideas? I would be very thankful for help.
Best regards,
Daniel
Downloading https://files.pythonhosted.org/packages/cb/97/361c8c6ceb3eb765371a702ea873ff2fe112fa40073e7d2b8199db8eb56e/scipy-1.3.0.tar.gz#sha256=c3bb4bd2aca82fb498247deeac12265921fe231502a6bc6edea3ee7fe6c40a7a
Best match: scipy 1.3.0
Processing scipy-1.3.0.tar.gz
Writing /tmp/easy_install-TRZjRk/scipy-1.3.0/setup.cfg
Running scipy-1.3.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-TRZjRk/scipy-1.3.0/egg-dist-tmp-rSOxHw
Traceback (most recent call last):
  File "setup.py", line 46, in <module>
    'Topic :: Scientific/Engineering :: Bio-Informatics']
  File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/lib/python2.7/dist-packages/setuptools/command/install.py", line 67, in run
    self.do_egg_install()
  File "/usr/lib/python2.7/dist-packages/setuptools/command/install.py", line 117, in do_egg_install
    cmd.run()
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 443, in run
    self.easy_install(spec, not self.no_deps)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 685, in easy_install
    return self.install_item(None, spec, tmpdir, deps, True)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 732, in install_item
    self.process_distribution(spec, dist, deps)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 777, in process_distribution
    [requirement], self.local_index, self.easy_install
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 782, in resolve
    replace_conflicting=replace_conflicting
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1065, in best_match
    return self.obtain(req, installer)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1077, in obtain
    return installer(requirement)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 704, in easy_install
    return self.install_item(spec, dist.location, tmpdir, deps)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 730, in install_item
    dists = self.install_eggs(spec, download, tmpdir)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 915, in install_eggs
    return self.build_and_install(setup_script, setup_base)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 1183, in build_and_install
    self.run_setup(setup_script, setup_base, args)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 1169, in run_setup
    run_setup(setup_script, args)
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 253, in run_setup
    raise
  File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 195, in setup_context
    yield
  File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 166, in save_modules
    saved_exc.resume()
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 141, in resume
    six.reraise(type, exc, self._tb)
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 154, in save_modules
    yield saved
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 195, in setup_context
    yield
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 250, in run_setup
    _execfile(setup_script, ns)
  File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 45, in _execfile
    exec(code, globals, locals)
  File "/tmp/easy_install-TRZjRk/scipy-1.3.0/setup.py", line 31, in <module>
    'static/third_party/bootstrap/css/*',
RuntimeError: Python version >= 3.5 required.```

Can you try running python gemini_install.py instead? That is the only reliable way to install.

Hi, thank you very much. I'll give it a try :)

Hi again.
the installer script seems to work :)
I, of course, had to add sqlite3 to the installed packages.
This appeared when running the master-test.sh.

glad to hear it. thanks for following up.

I'm also installing GEMINI into a ubuntu:18.04 docker image, and get the same error (see below). I'm following the instructions in the Manual installation part of the installation guide. Is it no longer recommended to perform the manual installation?


Overwriting the least used tokens vs creating new ones

Dear OpenVLA authors! I have a question regarding the action tokenization process. As with RT-2, you use the 256 least used tokens for actions. Have you by any chance experimented with adding new tokens for actions (and then calling resize_token_embeddings() to resize embeddings)? Are there any obvious disadvantages to this approach?

We have not tried this, but it makes sense. It's just slightly less convenient since you need to carry around a new tokenizer vs just using the LLaMA tokenizer. I would expect this to work roughly equally well -- in my experience the exact choice of tokens you overwrite has very little influence on the training dynamics, but it would still be a cool thing to try!


Added a few devices

eQ-3: HmIP-WTH-2
a few Zigbee devices with deCONZ: Develco (AQSZB-110), eWeLink (TH01), IKEA (Tradfri ON/OFF, SYMFONISK, RODRET), LUMI/Aqara (Opple switch, temperature, water leak, illuminance, cube, magnet)

Thanks

what device is  eWeLink (TH01) ?

Agreed, also the Develco uses AA not AAA, both fixed in latest commit
https://github.com/andrew-codechimp/HA-Battery-Notes/commit/10e2c18b321a513f56095737d8e2d8f8f6e2a998

what device is eWeLink (TH01) ?

Sorry, got confused, they use CR2450. I think it's a SNZB-02, but deCONZ reports it as eWeLink TH01.


Improve configuration of include/exclude types for better discoverability

Currently include and exclude options in config are of type string[]. But these are already validated by zod to conform to issueTypeSchema, e.g. files, dependencies etc.
This PR improves types of include and exclude so that allowed values could be type-checked and also improves config discoverability without the need to refer to the docs.

:rocket: This pull request is included in v5.0.3. See Release 5.0.3 for release notes.

Thanks Raman!


UP008 edge-case with slotted dataclasses

When using dataclasses with slots=True, calling a no-arg super() raises a TypeError, the workaround of using the two-arg variant triggers a UP008 rule error. Would be great if the rule took this edge-case into consideration.
From the docs:

Calling no-arg super() in dataclasses using slots=True will result in the following exception being raised: TypeError: super(type, obj): obj must be an instance or subtype of type. The two-arg super() is a valid workaround.

How to reproduce:
@dataclass(slots=True)
class Foo:
    bar: str

    def __post_init__(self) -> None:
        self.bar = "foo"

@dataclass(slots=True)
class Baz(Foo):
    def __post_init__(self) -> None:
        super(Baz, self).__post_init__()  # UP008 Use `super()` instead of `super(__class__, self)`
        self.bar = "baz"

Wow, never seen that! Thanks, we’ll fix it.


Remove associated volumes, too

Docker's default is to leave the volumes in place when a container is removed. Hoosegow containers are ephemeral, and any persistent data should be in a mounted volume.
With docker 1.9, mounting a directory ro from a different filesystem copies all of the files into the docker storage dir. The volume isn't removed when the container is removed, so we end up with tons of copies of these files that aren't going to get used anymore.
cc @parkr @mastahyeti

Seems good. :+1:

Nice catch. :+1:


Match on extension in router

It would be nice if we could match on a file extension in the router, something like this:
[
  Dream.get "/foo/:bar" @@ html_handler;
  Dream.get "/foo/:bar.html" @@ html_handler;
  Dream.get "/foo/:bar.json" @@ json_handler;
]

The current behaviour is that :bar.html will be parsed as the parameter name.

Would it be possible with the same syntax? I.e. /foo/:bar.:ext

I think it would be best to be able to delimit the variable names somehow, so {bar} or :{bar}, etc. Ending a variable name with . seems too implicit, and too specific to extensions in particular. There might be other reasons why someone wants to have a variable for part of a component.


result is nan

Run the Conformer model, python -u train.py --data ECL, the output result is all nan, and the loss is also nan, what is the reason?

have you got this problem solved?


Persist Security Info=false isn't respected

With Microsoft.Data.SqlClient on netcoreapp3.1, the password is present in SqlConnection.ConnectionString after Open has been called. As per the docs, once Open is called, all security info is supposed to be stripped from the user-exposed connection string. System.Data.SqlClient behaves correctly. This can be seen with MS.Data.SqlClient versions 1.1.1 and 2.0.0-preview1.20021.1.
using System;
//using System.Data.SqlClient;
using Microsoft.Data.SqlClient;

namespace Test
{
    class Program
    {
        static void Main(string[] args)
        {
            var conn = new SqlConnection(@"Server=localhost;Database=test;User=SA;Password=Abcd5678;Persist Security Info=false");
            conn.Open();
            Console.WriteLine("Connection string: " + conn.ConnectionString);
            // With Microsoft.Data.SqlClient, outputs Server=localhost;Database=test;User=SA;Password=Abcd5678;Persist Security Info=false
            // With System.Data.SqlClient, outputs Server=localhost;Database=test;User=SA;Persist Security Info=false
        }
    }
}

I confirm issue is reproducible in .NET Core with Microsoft.Data.SqlClient, while .NET Framework seems to be fine.


Retroarch n64 crashes when launching from ES

Hi guys,
I've tried for weeks to get ES working with n64 without any luck, and have spend hours searching for a fix :/
Everything lauches perfektly from ES except n64.
When launching any n64 game, ES closes down as it should, the cmd pops up, but then the Retroarch window crashes.
"Retroarch.exe has stopped working".
However.... Launching n64 games directly from Retroarch works perfectly without any crashing...
I've tried playing around with forcing fullscreen on and forcing windowed_fullscreen off (some ppl had luck with that), but it still crashes here. my mupen64plus_libretro.dll is up to date.
my es_systems.cfg looks like the following, which is identical to all the rest of the emulators.
<system>
<name>n64</name>
<fullname>Nintendo 64</fullname>
<path>~/.emulationstation/roms/n64</path>
<extension>.v64 .z64 .n64 .V64 .Z64 .N64</extension>
<command>%HOMEPATH%\.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%\.emulationstation\systems\retroarch\cores\mupen64plus_libretro.dll "%ROM_RAW%"</command>
<platform>n64</platform>
<theme>n64</theme>
</system>
to comparison my nes (which works fine) looks like this:
<system>
<name>nes</name>
<fullname>Nintendo Entertainment System</fullname>
<path>~/.emulationstation/roms/nes</path>
<extension>.nes .NES</extension>
<command>%HOMEPATH%\.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%\.emulationstation\systems\retroarch\cores\fceumm_libretro.dll "%ROM_RAW%"</command>
<platform>nes</platform>
<theme>nes</theme>
</system>
Do you guys have ny idea of why ES makes Retroarch crash? or better yet... any idea of how to fix it?

Have you tried running the command in es_log that it issues? Often times Retroarch will give you better details to why it fails.

I'm afraid i dont have any idea how to run the command like that :/
This is what the es_log says when i try to launch a game. The first one is a working gbc game (all good here). The second is any n64 game:
GBC working fine:
lvl2: 	 req sound [detailed.launch]
lvl2: 	   (missing)
lvl2: 	Attempting to launch game...
lvl2: 	 getting volume as 21 ( from float 0.21)
lvl2: 		%HOMEPATH%.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%.emulationstation\systems\retroarch\cores\gambatte_libretro.dll "C:\Users\Wormwood.emulationstation\roms\gbc\Carmageddon (UE) (M4) [C][!].gbc"
lvl2: 	Creating surface...
lvl2: 	Created window successfully.
N64, Retroarch crashes:
lvl2: 	 req sound [detailed.launch]
lvl2: 	   (missing)
lvl2: 	Attempting to launch game...
lvl2: 		%HOMEPATH%.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%.emulationstation\systems\retroarch\cores\mupen64plus_libretro.dll "C:\Users\Wormwood.emulationstation\roms\n64\007 - The World is Not Enough (U) [!].z64"
lvl1: 	...launch terminated with nonzero exit code -1073741819!
lvl2: 	Creating surface...
lvl2: 	Created window successfully.
looked up that exit code "-1073741819", a fix told me to set the windows 10 sounds to Windows Default or No Sound. Tried both, didnt fix it D:

just open a cmd window and run:
%HOMEPATH%.emulationstation\systems\retroarch\retroarch.exe` -L %HOMEPATH%.emulationstation\systems\retroarch\cores\mupen64plus_libretro.dll "C:\Users\Wormwood.emulationstation\roms\n64\007 - The World is Not Enough (U) [!].z64"

So i ran that string
%HOMEPATH%.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%.emulationstation\systems\retroarch\cores\mupen64plus_libretro.dll "C:\Users\Wormwood.emulationstation\roms\n64\007 - The World is Not Enough (U) [!].z64"
Just gives me the same error as before. A Windows window popping up saying "Retroarch.exe has stopped working".
Tried with with C:\Users\Wormwood\ instead of %HOMEPATH%, no luck here either.
Does a Retroarch dumpfile exist? something similar to es_log ?

use --verbose at the end. eg
%HOMEPATH%.emulationstation\systems\retroarch\retroarch.exe -L %HOMEPATH%.emulationstation\systems\retroarch\cores\mupen64plus_libretro.dll "C:\Users\Wormwood.emulationstation\roms\n64\007 - The World is Not Enough (U) [!].z64" --verbose

although you've at least proven this is not an emulationstation issue; you now have a core/retroarch issue. you should close this one.

The --verbose doesn't change/write anything as far as i can see :/ nothing new to see in the cmd at least.
See, when i launch the game via retroarch (select Load Content and Detect Core -> find rom -> choose mupen64plus), the game launches perfectly. So Retroarch should be working fine... right?
but you're probably right, that this isnt directly related to emulationstation. Any final ideas/tips of how i continue from here, before i close this?

ES effectively runs the command line command, so if that's not working in isolation from ES then the problem is with retroarch, or the construction of the command. Try only one dash maybe? -verbose?
have a look at http://libretro.com/forums/showthread.php?t=3647 - see the last post for an alternative. not sure where the retroarch log file is stored in windows but should be in the directory i guess.

Oh this is so stupid.... well i am...
Fixed the problem by downloading the latest Retroarch for windows (1.3.2) and copy/paste (and replace) the whole thing into my .emulationstation/systems/retroarch.
Ty for your help tho :)
/thread


Recommended ordinal values throws an error

In the documentation about ordinal values: https://unovis.dev/docs/guides/tips-and-tricks/#displaying-ordinal-values
It is recommended to use a NumericAccessor with a StringAcessor in the tickFormat to get an ordinal scale.
However the documentation show that the following code snippet should work:
const categories = ['A', 'B', 'C', 'D', 'E']
const tickFormat = (tick: number) => categories[tick]

A problem with that snippet is, the tick can be a float and thus the code will throw an error as it cannot index the array with a float.
The fix I implemented is using Number.isInteger as so:
const categories = ['A', 'B', 'C', 'D', 'E']
const tickFormat = (tick: number) => {
  if (Number.isInteger(tick))
   return categories[tick]
  return ''
}

Versions:
"@unovis/ts": "^1.4.1"
"@unovis/vue": "^1.4.1"

Thanks for pointing this out @samuelhafsteinsson! The problem can be solved by providing a tickValues array to the Axis component explicitly: https://unovis.dev/docs/auxiliary/Axis#set-ticks-explicitly. We'll need to update the docs to mention it.
cc @reb-dev @lee00678


Do a visual language study for the site

Create a lightweight style guide

Now that you have the splash page design, it might be worthwhile to work out a style tile or guide with @susanjrobertson

I'm going to close this issue since we have the splash page direction locked down.


Annoying highlighting which ruins visibility

Windows Version
Microsoft Windows [Version 10.0.19044.3448]
WSL Version
Invalid command line option: --version
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps
Go to a folder which has a subfolders, Run cd+TAB and you will see stupid folder highlighting:

Expected Behavior
No highlight, just different color like in ls after fix:

Actual Behavior
Highlighting that makes folders' names impossible to read:

I have already managed to remove this thing for ls but it appears even with cd and no resources online mention the fix. I consider this a bug because it makes folders' names impossible to read with most popular terminal themes such as Nord, Gruvbox, Catpuccin, material, etc.
Diagnostic Logs
No response

@dehlong Ubuntu has ls aliased to ls --color=auto. In a shell run type ls and you'll get ls is aliased to 'ls --color=auto' most likely.  You get the same directory highlight when running  ls in a powershell session. Use ls --color=never to hide them when running ls.

Indeed these directory are highlighted that way by design. To work around it I'd recommend switching your color theme or looking into overriding colors.
Closing since this is by design.


Sub groups or sublayers

Let's say I have the following tree:
src
  |-- Domain
  |-- Application
  |   \-- Handler
  \ Infrastructure
      |-- Action
      \-- Responder

There's the following layers & ruleset:
layers:
  layers:
  - name: Application
    collectors:
      - type: className
        regex: .*\\Application\\.*

  - name: Domain
    collectors:
      - type: className
        regex: .*\\Domain\\.*

  - name: Infrastructure
    collectors:
      - type: className
        regex: .*\\Infrastructure\\.*

ruleset:
  Application:
    - Domain

  Domain: ~

  Infrastructure:
    - Application
    - Domain

This gives me the following schema:

Now I would like to go a step further and specify more advanced rules.
For example, I can break down Application in two:

The global rules defined by the first graph are not changing, but inside Application, I'm would like to specify that no Handlers shouldn't depend on `Handlers:

But that doesn't affect the rules defined to the parent Application, hence the global view would be:

Another cases slightly more complex: I'm breaking down Infrastructure as following:

We hence have not 3 sublayers but 6:

Actions
Responders
no Actions & no Responders
no Actions = no Actions & no Responders U Responders
no Responders = no Actions & no Responders U Actions
Actions & Responders`

*: U is union
In Infrastructure, with those sublayers, I would like to define the following rules:

Actions can depend on no Actions
Responders can depend on no Actions & no Responders

Which gives the following graph:

As before, this shouldn't affect the rules defined on the parent layer Infrastructure.
While this is partly doable right now, there is a lot of cons:

Very error prone and repetitive: as you cannot defined a layer based on other layers, you wouldn't be able to define no Handlers or no Actions without being repetitive; repetition which may lead to: 1. an error in the regex, hence you get the layer wrongs, 2. missing a sublayer, hence you could think of having Application devided in Handlers and no Handlers but due to a little mistake you have Handlers U no Handlers ≠ Application.
Inadequate view: as of now each layer is considered as separate, so instead of having something similar to:

You would actually get something like:

Maybe a duplicate of #39 though

thanks for writing this down, i'll take a closer look soon.
did you consider using multiple depfiles to track different concerns?

@slde-flash I did (although after writing this done). It works nice but ultimately is still a workaround.
To continue on the example above, when I'm breaking down Application in two sublayers, I'm actually breaking by explicitly defining the two sub-layers:
layers:
  - name: 'Application Handlers'
    collectors:
      - type: className
        regex: .*\\Application\\Handler\\.*

  - name: 'Application without Handlers'
    collectors:
      - type: className
        regex: .*\\Application\\(?!Handler).*

The issue is by doing that a little error in the regex, or if I breakdown Application in more sublayers, it's easy to find yourself without Application Handlers U Application without Handlers ≠ Application.
So it would be nice to be able to do something like:
layers:
  - name: Application
    collectors:
      - type: className
        regex: App\\Application\\.*

sub_layers:
  - name: 'Application Handlers'
    parent: Application
    collectors:
      - type: className
        # (only look for mathing className in classNames included in
        # "Application", i.e. "App\\Infrastructure\\Handler" would be included
        # for example
        regex: .*\\Handler\\.*

  - name: 'Application without Handlers'
    parent: Application
    collectors:
      - type: layer
        # I'm using the "∪" character for "union" and "∩" for "intersection"
        # And "A\B" for saying "all the members of A except the ones in B" (set difference)
        # refering to the set theory: https://en.wikipedia.org/wiki/Set_theory
        # "Domain" would be the generic name for the parent layer; for example
        # here "Domain" is "Application"
        expression: Domain\'Application Handlers'

And even with that there I then wish I could import the layers of my other files, in this case Application which I already defined in another depfile.

ex of import statement?
import:
  - resource: top_layers.yml
    layers:
      - Application

this is a huge and complex topic.

Very error prone and repetitive: as you cannot defined a layer based on other layers, you wouldn't be able to define no Handlers or no Actions without being repetitive; repetition which may lead to: 1. an error in the regex, hence you get the layer wrongs, 2. missing a sublayer, hence you could think of having Application devided in Handlers and no Handlers but due to a little mistake you have Handlers U no Handlers ≠ Application.

the current configuration style is repetitive, i am already thinking about how to solve this. i promise this will become much more hackable/flexible soon. for now don't try to avoid repeating yourself in the depfile.
here a some small hints:

right now it is possible that one class is in multiple layers.
in this simple scenario it would be possible to define 5 Layers.

Infrastructure
Application (Collectors from Handlers and no Handlers)
Handlers
no Handlers
Domain

now it would be possible to define such a ruleset:
Infrastructure:
   - Application
Application:
   - Domain
Handlers:

instead of
layers:
  - name: 'Application Handlers'
    collectors:
      - type: className
        regex: .*\\Application\\Handler\\.*

  - name: 'Application without Handlers'
    collectors:
      - type: className
        regex: .*\\Application\\(?!Handler).*

i would prefer:
layers:
  - name: 'Application Handlers'
    collectors:
      - type: className
        regex: .*\\Application\\Handler\\.*
  - name: 'Application without Handlers'
    collectors:
      - type: bool
        must:
           - type: className
             regex: .*\\Application\\
        must_not:
           - type: className
             regex: .*\\Application\\Handler\\.*

repeating yourself here is (for now) a good idea.

ex of import statement?

yep, but more hackable than your example.

layers:
  - name: Application
    // ...
sub_layers:
  - name: 'Application Handlers'
    parent: Application

i've to play with different solutions, for now i believe i'll try to avoid something like sub_layers. from my point of view it's too limited. i prefere the idea of grouping arbitrary layers.
i am going to close this issue, and open one for the configuration and one for grouping layers. if i miss something, feel free to open new issues :)

i've to play with different solutions, for now i believe i'll try to avoid something like sub_layers. from my point of view it's too limited. i prefere the idea of grouping arbitrary layers.

sub_layers maybe not be ideal indeed, but rather introduce the possibility to combine layers based on other layers, using some elements from the Set theory like given above. But then "layer" is maybe not the right term as, at least to me, layers illustrate something pilling on each other. If we have the possibility to group things like that, it would rather be "groups" as some "layer" could be part of two other layers.


-fix-percentage-issue

See  -

And i think the reason , is because we are not calculating stats again while doing this .. we just fetching and setting in the cache.

not able to produce this issue on local because of cms local provider check , but i might be wrong ,
@hkirat  , i might be wrong .. but please check from your side one
fixes: #268

@hkirat  check this issue , no percentage completed in the 0-100

yeah we'll be getting rid of caches soon
I'm assuming this resolves after the cache clears (1 day)
Closing for the same reason


Update typedoc and typedoc-plugin-markdown to latest versions

Part of https://github.com/tablelandnetwork/js-tableland/issues/73
I wasn't able to run npm install locally because of a version conflict related to these packages. This should fix that!

[x] Tests pass
[x] Appropriate changes to README are included in PR

@datadanne Thanks for this!
I'm installing locally and I don't see any conflicts.  What are you seeing?

Sorry that I dropped the ball here! When I run this locally I get
$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/typedoc
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/typedoc-plugin-markdown
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/typedoc
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/typedoc-plugin-markdown
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
...

I am using
$ npm --version
8.14.0
$ node --version
v14.18.1

looks like typedoc 0.22->0.23dropped support for TypeScript before 4.6, and this is currently^4.2.3`. Should probably change that too.

Good point! Typescript is already resolved to the latest release (4.7.4) on main so I'll push another commit that changes the project to depend on  typescript: ^4.7.4

With this update, if this runs, are we good to go with this one @joewagner ?

With this update, if this runs, are we good to go with this one @joewagner ?

Looks great!

I think this looks just about ready to merge @joewagner. @datadanne this repo requires all commits to be signed before we are able to merge. Do you mind amending your commits and force pushing your updates: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

I think this looks just about ready to merge @joewagner. @datadanne this repo requires all commits to be signed before we are able to merge. Do you mind amending your commits and force pushing your updates: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Done! I noticed that there is a conflict with main now though and that typedoc and typedoc-markdown released new minor versions, want me to upgrade to those and resolve the conflicts?

want me to update to use those when I resolve the conflict?

Oh yes please, good call.

Oh yes please, good call.

Done!


get rid of vendor-specific package directories

Use packages directly from general/package/

I would go further and made BR2_EXT_PACKAGES_PATH including the /package bit. It would save some code. But at the same time I am not a fan of the idea of adding more variables than really necessary. I wonder if buildroot already has its own variable for that.
Besides, my building aproach is to separate git sources and buildroot, and spit outputs per board, and when i did it for the first time BR2_EXTERNAL stopped working for me so I had to use vendor specific external directory as an anchor for futher traversing. @viktorxda, you might want to check Makefile in my repo if you are curios. Maybe you could have an idea how to amend it further.

@viktorxda makes a better PR. We better use his.


Local issue in category edit section at Description.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
v2.0.0
Issue Description
When we try to edit category and change the local after that changes in Description field saved into english local always.__
Preconditions
Create a new category in english local.
Steps to reproduce

Go to 'Admin->Catalog->Categories'
Click on 'edit button(pen symbol) for new created category'
Change Local to 'Arabic'
Scroll down to 'Description'
Edit Description
Save Category
Again Click on 'edit button(pen symbol) of same category'
Change Local to 'English'
Scroll down to 'Description'
See Description
See error
Change Local to 'Arabic'
Scroll down to 'Description'
See Description
See error

Expected Result
The Description should save for different local not for english only.
Actual Result
The Description save for for english only.
Screenshots

Additional context
No response

@kartikeywebkul9260
As per the reported issue, we could not replicate the problem in our stable branch version 2.2.
Please refer to the video for more details: Reference Video.


Android: Add F_SEAL_FUTURE_WRITE constant.

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 3fabad8295e4d27be9958492f09125c140982156 has been approved by Amanieu

:hourglass: Testing commit 3fabad8295e4d27be9958492f09125c140982156 with merge a1286b96b65e3ff4b87d17411fc26994329a91eb...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing a1286b96b65e3ff4b87d17411fc26994329a91eb to master...


Changed USING to FROM

This PR addresses GitHub issue: #439  .
Briefly describe the changes proposed in this PR:

Use "FROM" and "FROM NAMED" instead of "USING"

I assume this is the only changed that is needed, since the (old) ticket mentions it is a "good first issue", so I guess this is the only trivial change that was required ?

@rdf4j-bot run tests

@barthanssens there are a number of failing tests in the JsonLdParser - I don't see how that could be caused by this PR though.

Ah, in fact the master branch is currently unstable. Looks like this was caused by the jsonld version bump. See https://ci.eclipse.org/rdf4j/job/rdf4j-client-master-verify/86/

My bad, I’ll take a look at it…
From: Jeen Broekstra<EMAIL_ADDRESS>Sent: donderdag 6 juni 2019 11:20
To: eclipse/rdf4j<EMAIL_ADDRESS>Cc: Bart Hanssens (BOSA<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [eclipse/rdf4j] Changed USING to FROM (#1436)
Ah, in fact the master branch is currently unstable. Looks like this was caused by the jsonld version bump. See https://ci.eclipse.org/rdf4j/job/rdf4j-client-master-verify/86/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/eclipse/rdf4j/pull/1436?email_source=notifications&email_token=AAOHUPMIWOGXZ3EWQELHJV3PZDJCXA5CNFSM4HQSZTX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCID6I#issuecomment-499417593, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOHUPIMPGJAVVYABGD2I6LPZDJCXANCNFSM4HQSZTXQ.

@rdf4j-bot run tests


Several errors when using RTCMultiConnection

Hey @muaz-khan,
today I've opened the console while getting connected to users, here are some common errors that occur:
1d0ccde….js?meteor_js_resource=true:387 Uncaught (in promise) DOMException: Failed to set local answer sdp: Session error code: ERROR_CONTENT. Session error description: Failed to set local audio description recv parameters..

1d0ccde….js?meteor_js_resource=true:387 Uncaught (in promise) DOMException: Failed to set remote offer sdp: Called with SDP without ice-ufrag and ice-pwd.

On some of this connections, onStream is fired but the stream never plays. We are using our own STUN + TURN servers (coturn).

Closing issue - we've called con.renegotiate() after the local stream of the user was received, to test if it fixes the issue with the empty stream. It didn't fix it but caused the error above.

connection.renegotiate should be used only in a live-session. There must be at least two users in the room.


[Refactor] Update all React Toolkit slices to use mutating syntax

Use:
state.x = true

Instead of:
{
  ...state,
  x: true,
}

Note that additional "mutation" could be done here.  For example, in slices/notes.ts, there's a number of cases like this:
    toggleFavoriteNotes: (state, { payload }: PayloadAction<string>) => {
      state.notes = state.selectedNotesIds.includes(payload)
        ? state.notes.map((note) =>
            state.selectedNotesIds.includes(note.id) ? { ...note, favorite: !note.favorite } : note
          )
        : state.notes.map((note) =>
            note.id === payload ? { ...note, favorite: !note.favorite } : note
          )
    },

That could potentially be rewritten along these lines:
    toggleFavoriteNotes: (state, { payload }: PayloadAction<string>) => {
      const toggleSelected = state.selectedNotesIds.includes(payload);

      // Can use a `forEach` loop instead of a `map()` - no need to create a new array manually
      state.notes.forEach(note => {
        const shouldToggle = toggleSelected ? state.selectedNotesIds.includes(note.id) : note.id === payload
        if (shouldToggle) {
          // Can directly "mutate" a given note entry
          note.favorite = !note.favorite
        }
      })
    },

@markerikson Thanks for the tip! I went through and only updated the "top level" mutations, but I definitely left a lot of map and filter where it could be refactored to forEach. That looks way cleaner.

Yeah. One of the great things about Immer is that you can grab out nested values, "mutate" those nested values seemingly by themselves, and Immer does all the work of tracking the parents that need to get copied too.  Like, in this case, note.favorite = !note.favorite triggers copies of notes and state automatically.


Generic CreateAggregateFunction()

Hey there,
This PR implements a generic CreateAggregateFunction(), the user can provide all function pointers following the internal API for aggregate functions.

Looks good, thanks! Could you just pull and merge with the master branch? We had a big type rename and all the types are now called LogicalType:: instead of SQLType::. Those need to be changed again :)
After that I think it's ready to merge.

Merge done ;)

Thanks for the merge, all good now :)


Support for CockroachDB serverless

Problem
As it stands Prisma ignores the options parameter that is in CockroachDB's connection string for their serverless/cloud plans this value indicates which cluster to connect to. Without this value you'll recieve a connection error.
Valid values for the options paramter for cockroach is:
options=--cluster=%3Dmy-cluster-name
or:
options=-c%3Dmy-cluster-name

This is documented here: https://www.cockroachlabs.com/docs/stable/connection-parameters.html#supported-options-parameters
A connection string will look similar to this:
postgresql://{{USER}}:{{PASS}}@{{HOST}}:{{PORT}}/defaultdb?options=--cluster%3D{{CLUSTER_NAME}}

Suggested solution
Support the options parameter in the postgres connection string.
Additional context
I receive the following error:
Database connection error:

undefined: Database error
Error querying the database: db error: FATAL: codeParamsRoutingFailed: missing cluster name in connection string

All that being said, the cluster name in the connection string can be worked around:

To construct a suitable connection string, open the cluster in the CockroachCloud, click the Connect button on the rop right to open the Connection info modal. There go to the Connection parameters tab and construct a connection string with these values.

https://github.com/prisma/e2e-tests/pull/1597/files#diff-3ff81f6c96e193d32a22f6cea59f0e08e0f4609c685d3e0c8f2bd0346e8abd49R7
That way should be able to connect to the database. Let me know if that works @ashsmith

@ashsmith @otan Can you please confirm that using the individual Connection parameters allows you to proceed further? Thanks.

@janpio No. I can confirm that the issue @otan reported remains. I still got the following error message
Error: db error: ERROR: unknown function: pg_get_functiondef()
   0: migration_core::api::SchemaPush
             at migration-engine/core/src/api.rs:184

@alvis You just confirmed that you could actually connect to the server using the Connection Parameters from the Cockroach UI (vs. the Error querying the database: db error: FATAL: codeParamsRoutingFailed: missing cluster name in connection string error message that @ashsmith initially got), and that you are now getting the expected error message when using db push (or another Migrate command) which is an overall problem with CockroachDB and Prisma. We will work on that via https://github.com/prisma/prisma/issues/4702
(Maybe post your current error message and the command you are trying to run in that issue so the current state is reflected there. Thanks!)

@janpio Thanks for your quick feedback. Yes. You're right that I got the error from prisma db push. The error does indicate that prisma can connect to the database, but it hits a problem that cockroachdb lacks pg_get_functiondef for getting info about user-defined functions.

"Yes", but it is quite an effort: You can use db push (or any other Prisma Migrate command) with a Postgres database, then download the SQL to create the database manually (or take it from the generated migration files) and use it on your CockroachDB server - the end result should be the same. The problem is just in Introspection and internal assumption of Migrations that do not work on CockroachDB.

For posterity, I've put an issue up on our side detailing what needs to change in either prisma and/or Cockroach to get migrate working: https://github.com/cockroachdb/cockroach/issues/73137
We'll make it work together one day :)!

Follow up issue: https://github.com/prisma/prisma/issues/10494

Update: In recent dev versions of Prisma CLI the connection string com CockroachDB Cloud Serverless can just be copy pasted into Prisma and works. No additional work is need any more. This will be released with 3.8.0.


in gets converted to ∈

If I type in it gets automatically converted to ∈.
How can I escape it?

Maybe you want "in" ?

@amoshyc Yep that's it!


modelbuilder_base: Refactor the signature of resolve_mtype*

Only modelize_mclass require support for partial context. Furthermore, in
a future PR, it may need to resolve types just before modeling the class
definition (in a place where the MClass is available and must be used).
Also include various related cleanups.
Signed-off-by: Jean-Christophe Beaupré<EMAIL_ADDRESS>

♻

[x] Fix modelize_mclass: don’t specify mclass while resolving bounds.
[x] Remove an unecessary cast in metrics/detect_covariance

Thank you. And thank you for taking time to review such a refactoring mess. 😉


AAD graph deprecation

Hello,
Azure AD graph will be deprecated end of june 2023 (https://learn.microsoft.com/en-us/graph/migrate-azure-ad-graph-overview)
The code in level0 uses it.
azuread_api_permissions = {
  level0 = {
    microsoft_graph = {
      resource_app_id = "00000003-0000-0000-c000-000000000000"
      resource_access = {
        AppRoleAssignment_ReadWrite_All = {
          id   = "06b708a9-e830-4db3-a914-8e69da51d44f"
          type = "Role"
        }
        DelegatedPermissionGrant_ReadWrite_All = {
          id   = "8e8e4742-1d95-4f68-9d56-6ee75648c72a"
          type = "Role"
        }
        Application_ReadWrite_OwnedBy = {
          id   = "18a4783c-866b-4cc7-a460-3d5e5662c884"
          type = "Role"
        }
      }
    }
  }

I have tried this but it doesnt work
  identity = {
    microsoft_graph = {
      resource_app_id = "00000003-0000-0000-c000-000000000000"
      resource_access = {
        AppRoleAssignment_ReadWrite_All = {
          id   = "06b708a9-e830-4db3-a914-8e69da51d44f"
          type = "Role"
        }
        DelegatedPermissionGrant_ReadWrite_All = {
          id   = "8e8e4742-1d95-4f68-9d56-6ee75648c72a"
          type = "Role"
        }
        GroupReadWriteAll = {
          id   = "62a82d76-70ea-41e2-9197-370581804d09"
          type = "Role"
        }
        RoleManagement_ReadWrite_Directory = {
          id   = "9e3f62cf-ca93-4989-b6ce-bf83c28f9fe8"
          type = "Role"
        }
        Application_ReadWrite_OwnedBy = {
          id   = "18a4783c-866b-4cc7-a460-3d5e5662c884"
          type = "Role"
        }
        Directory_ReadWrite_All_Delegated = {
          id   = "c5366453-9fb0-48a5-a156-24f0c49a4b84"
          type = "Role"
        }
        Directory_ReadWrite_All_Applicaion = {
          id   = "19dbc75e-c2e2-444c-a770-ec69d8559fc7"
          type = "Role"
        }
      }
    }
#    active_directory_graph = {
#      resource_app_id = "00000002-0000-0000-c000-000000000000"
#      resource_access = {
#        Application_ReadWrite_OwnedBy = {
#          id   = "824c81eb-e3f8-4ee6-8f6d-de7f50d565b7"
#          type = "Role"
#        }
#        Directory_ReadWrite_All = {
#          id   = "78c8a3c8-a07e-4b9e-af1b-b5ccab50a175"
#          type = "Role"
#        }
#      }
#    }
  }
}

Regards

Ok I looked at the ids in MS graph and replaced them

ok replaced by MS Graph ids


Fix small plot bug in spatial.py

Fix bug when number of dimensions was larger than 1, as it entered a loop that it shouldn't

Fixes #112


Key manager: 2 keys mapped and pressed together make one of them or both being stuck

Microsoft PowerToys version
0.43.0
Running as admin

[X] Yes

Area(s) with issue?
Keyboard Manager
Steps to reproduce
Some keys of my keyboard are not works. So I map:
"right shift" to "up"
"num pad 0" to "right"
I open text file in notepad. Then I press and hold "right shift" and then I hit "numpad 0" and got bug.
PowerToysReport_2021-08-20-17-19-23.zip

✔ Expected Behavior
Cursor moves Up and then moves Right.
❌ Actual Behavior
"Right shift" stops work as "up" but work as "shift" and "shift" stuck.
To fix this I have to: turn off Keyboard manager, hit "right shift", hit "numpad 0", Turn on Keyboard manager again.
Other Software
notepad (windows 10, 64bit)

Can confirm, it sometimes even locks mousewheel

Can reproduce it

Long time not fixed?

Reproduceable on 0.47 still

I updated to new version 0.51.0 and this bug still exists.

Still not fixed 🙁

Updated to version 0.51.1
I have same binding.
I open text file in notepad. Then I press and hold "right shift" and then I hit "numpad 0" and got bug.
Now in this version Right Shift keeps work as Up. But actual shift stucks and notepad also selects lines as i navigate with cursor.

I found more information about this issue.
It also happens if I rebind "right shift" , hold "right shift" and press one of some exact non rebinded keys: (
"numpad 0" to "numpad 9",
"numpad Dot"
)
So this leads to Shift being stuck as normal Shift.
With other combinations seems all fine!

In version 0.55.1 still not fixed.

does this issue still happen with v0.73.0? /needinfo

does this issue still happen with v0.73.0? /needinfo
A: I do not know
Sorry for not respond so long

I did uninstalled powertoys app
Since i used other software just to remap keys
It is (MapKeyboard.2.1)
So current issue not happens for me atm.

I will close this issue for now, but if you have this issue again please open another issue.


none-ls.nvim doesn't integrate so seamlessly with mason-null-ls.nvim anymore

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no issues with the same problem.

Neovim Version
v0.9.5
Dev Version?

[X] I am using a stable Neovim release version, or if I am using a dev version of Neovim I have confirmed that my issue is reproducible on a stable version.

Operating System
arch
Minimal Config
x

Steps to Reproduce
x
Reproducibility Check

[ ] I confirm that my minimal config is based on the minimal_init.lua template and that my issue is reproducible by running nvim --clean -u minimal_init.lua and following the steps above.

Expected Behavior
x
Actual Behavior
x
Debug Log
x
Help
No
Implementation Help
Loading external builtins in the new way
require("null-ls").register(shellcheck_code_actions)

Suffices for end users, but it's not a good solution for distro maintainers.
Example

I ship my distro with shellcheck.
The final user decides to open mason and change his linter to a different one.

Result
Both shellcheck and the new installed linter are going to appear as loaded in :LspInfo, as shellcheck is now hardcoded in the config (which was not previously necessary).
Requirements

[X] I have read and followed the instructions above and understand that my issue will be closed if I did not provide the required information.

There is no problem in requiring a dependency, but it shouldn't be necessary to hardcode loading clients in the config. It beats the point of none-ls.

I think showing in :LspInfo clients that can't be loaded (because they are not installed, they are just registered in the config) is a bug and it should probably not happen.

Also
local nls = require("null-ls")
local luacheck = require("none-ls-luacheck.diagnostics.luacheck")
nls.register(luacheck)

Behaves in a weird way. If I remove the line:
nls.register(luacheck)

Linting still works, but it is not displayed on :LspInfo.
But if I have
nls.register(luacheck)

And I remove luacheck from mason, then :LspInfo will show it as loaded even if that's not true.

In the end we just migrated from luacheck to selene, and from beautysh to shfmt. While it's true these projects were stable and powerful, they are probably abandoned forever.
Feel free to close this issue if you consider it.

@jay-babu do you have time to take a look at this?

Do you have any update on this one? It is happening to me for 4 libraries:

In my case I cannot migrate to shfmt since it is incompatible with some of our standards.
Here is my configuration (using lazy.vim):
return {
	{
		"jay-babu/mason-null-ls.nvim",
		event = { "BufReadPre", "BufNewFile" },
		config = function()
			require("mason-null-ls").setup({
				-- Each of one of these needs to be added in the configuration for none-ls.nvim
				ensure_installed = {
					-- Diagnostics
					"beautysh",
					"eslint_d",
					"hadolint",
					"markdownlint", -- This is both, formatter and diagnostics

					-- Formatters
					"black",
					"isort",
					"jq",
					"prettier",
					"shellcheck",
					"stylua",
				},
			})
		end,
		lazy = true,
	},
	{
		"nvimtools/none-ls.nvim",
		dependencies = {
			"jay-babu/mason-null-ls.nvim",
		},
		event = { "BufReadPre", "BufNewFile" },
		lazy = true,
		opts = function(_, opts)
			local nls = require("null-ls")
			opts.sources = vim.list_extend(opts.sources or {}, {
				-- These come from the configuration for mason-null-ls.nvim

				-- Diagnostics
				nls.builtins.diagnostics.beautysh,
				nls.builtins.diagnostics.eslint_d,
				nls.builtins.diagnostics.hadolint,
				nls.builtins.diagnostics.markdownlint,

				-- Formatter
				nls.builtins.formatting.black,
				nls.builtins.formatting.isort,
				nls.builtins.formatting.jq,
				nls.builtins.formatting.markdownlint,
				nls.builtins.formatting.prettier,
				nls.builtins.formatting.shellcheck,
				nls.builtins.formatting.stylua,
			})

			opts.on_attach = function(current_client, bufnr)
				if current_client.supports_method("textDocument/formatting") then
					vim.api.nvim_clear_autocmds({ buffer = bufnr })
					vim.api.nvim_create_autocmd("BufWritePre", {
						buffer = bufnr,
						callback = function()
							vim.lsp.buf.format({
								filter = function(client)
									-- only use null-ls for formatting instead of lsp server
									return client.name == "null-ls"
								end,
								bufnr = bufnr,
							})
						end,
					})
				end
			end
		end,
	},
}

See also: https://github.com/nvimtools/none-ls.nvim/issues/122#issuecomment-2104930403

I was thinking a possible solution would be not attaching the source if the command is not available on the terminal. I'm gonna see if I can pull it off during the weekend.

I already got a local solution working:
  --  none-ls [lsp code formatting]
  --  https://github.com/nvimtools/none-ls.nvim
  {
    "nvimtools/none-ls.nvim",
    dependencies = {
      "jay-babu/mason-null-ls.nvim",
      "nvimtools/none-ls-extras.nvim",
    },
    event = "VeryLazy",
    opts = function()

      -- fix: Register the extra builtin reformat_gherkin only if the command is available.
      local reformat_gherkin = require("none-ls.formatting.reformat_gherkin")
      local cmd = reformat_gherkin._opts.command
      if vim.fn.executable(cmd) == 1 then
        require("null-ls.sources").register(reformat_gherkin)
      end

      return {} -- opts are not necessary for this example
    end
  },

This code will only try to load the extra builtin if its command is executable.
I don't know if I can implement this login into none-ls itself so the user doesn't have to use hacks such as this. I'm gonna try.

Issue located in null-ls-mason not having added support for external sources yet. Closing and moving the issue to https://github.com/nvimtools/none-ls.nvim/issues/125


Color alpha values are not preserved even when named xxx-alpha

Color alpha values are not preserved even when named xxx-alpha. Have to edit scene evry time, which is tedious...

Some more context about what you're doing would be useful.  What color value are you editing?  Is it not importing the color's alpha correctly when you (re)import a scene?

@slapin Ping.

This issue still persists with current master
On Tue, Nov 10, 2015 at 7:08 PM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

@slapin https://github.com/slapin Ping.
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/2268#issuecomment-155467060.

This issue still persists with current master

Well my ping was about answering the question that @romulox-x asked, I guess I should have been more direct, sorry.

Never seen a fix for this one
On Sat, Jan 2, 2016 at 6:06 PM, Juan Linietsky<EMAIL_ADDRESS>wrote:

Closed #2268 https://github.com/godotengine/godot/issues/2268.
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/2268#event-503978977.


macoS: Opening a new tab is detected by yabai as opening a new window

I use yabai for managing windows, and when I open a new tab, yabai reacts as though I've opened a new window, and halves the space that ghostty takes up (the other half being dedicated to the new invisible 'window').
I haven't encountered this problem with other applications that have native tabs (e.g. iTerm2) so I believe it is an issue with how ghostty presents opening a tab to macOS (I'm unfamiliar with the codebase and window management system so may not be using the appropriate terminology here, I apologise.)
Reproduction steps: Install yabai (don't think SIP disabling is necessary as this appears to just be a single-space window arrangement feature) and ghostty, and open a new tab in a ghostty instance.
See below where I open tabs to create new 'windows' (forcing the resize), then close them and destroy those 'windows'.

Dupe search for it please, this is well covered. I'll add it to the common issues of the website too.
This is a macOS bug or feature. In any case we can't do anything about it.


Adding Partner Center Referrals connector.

Added Partner Center Referrals connector and associated files under connectors folder
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: didalal sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[ACR-8] Uses secrets in the steps

As part of the setup it recommended to store the AZURE_OPENAI_API_KEY in the secrets. In the README the variable is accessed using vars

great catch @josearmandojacq!

@vivianintech @josearmandojacq actually the secret should use as an env for the action. Our README and jobs implemented use the env value from secret.

To make a secret available to an action, you must set the secret as an input or environment variable in the workflow file. Review the action's README file to learn about which inputs and environment variables the action expects.

https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#accessing-your-secrets

ahh that's true!! Awesome, thanks a @sanglt for catching this 🙏
I'll revert this change

@sanglt to see if I understood. After declaring it as a secret, you can access it from envs.
🤔
I did like in my PR and it works 🤷🏽♂

@vivianintech @sanglt That is interesting. I created a project secret and this is why my change works. It is intended to store it differently?


Consistent terminology

The section "How long it takes for retention policies to take effect" has a diagram that uses the term "synced" The text underneath talks about "distributed". Are they the same thing?
Also, the actual portal shows the status as "Enabled (Success)", while the diagram in the doco shows a status of "Success (ON)". Are they the same thing?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: fd61abe1-251f-1409-d386-145d93c8f18f
Version Independent ID: b340c591-d6bf-ae5f-e9b1-b32be18d6bee
Content: Verify eligibility for Microsoft 365 Education subscriptions
Content Source: microsoft-365/commerce/subscriptions/verify-academic-eligibility.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@ma261065 Thank you for your feedback. I do not see the section "How long it takes for retention policies to take effect" in this document. Could you please provide the URL of the document you are referring to ?
Thanks
Sri

Sorry, this is the document - https://docs.microsoft.com/en-us/microsoft-365/compliance/create-retention-policies?view=o365-worldwide#how-long-it-takes-for-retention-policies-to-take-effect

@msbemba

@ma261065 Thank you for your feedback. I will fix the document shortly.

@ma261065 Thank you for your feedback. We have fixed the diagram to match the portal. This can be tracked via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8429
Once the author approves, the changes will be live.
Thanks
Sri

Closing us per Author's input. Thanks


Add option to control whether to gray out history of messages

I think this should do it for #3545.
This is what the setting looks like in the General Page:

And this is the setting in action:

FWIW you have the wrong screenshot posted for

And this is the setting in action:

And this is the setting in action:

Wrong screenshot aside, having just compiled this myself, there are 2 things I dislike about how it works at the moment.
Screenshot for reference:

The message is too big when used in smaller spits. I would personally just remove the extra space inside of the square brackets, doesnt really look that great in bigger chats either.
Duplicate timestamps: No reason to have a timestamp in the message itself, if its just a normal system message that displays a timestamp anyways. While I feel like this is another one of those situations where the message would probably look better without the entire timestamp element (can't find the issue or PR where that discussion happened, but it was regarding automod messages and how they basically introduce a second timestamp in addition to the one from the actual message), I am not sure if there is a way to do that "correctly" right now, so might be OOS for this PR. But either way, if you ask me, one of the timestamps has to go.

I think adding extra message as separator is unnecessary noise. Simple permanent line (maybe a bit thicker than the one used for new messages now) would imo look better for this.

To prevent more code changes to the current implementation I'll include these:

I just want to mention that this was already a setting. It got implemented in various forms (#822 and #933) and then later. I think it was removed because the red stripes introduced in #933 felt disruptive.
Pajlada's comment/suggestion https://github.com/Chatterino/chatterino2/pull/822#issuecomment-432973880seems seems still valid and very relevant to me and seems a very good way to make it more/less/non-faded according to the user's needs.

More options: Add special badge to historic messages, do something with the timestamp, maybe add a small icon next to the timestamp?
The one thing I'm sure about is that we should not add another setting for this.

Ideas that came up: https://www.viragegroup.com/wp-content/uploads/2021/11/reporting-en-direct.svg

I think the icon should be fairly discrete, and have a tooltip with some more information

Thank you for your time! I'll look into this tomorrow!

Tested out some badges, and it looks pretty bad.
What I've been experimenting with instead now is making the fade for historic messages a lot lighter, and disabling the "double fade" that would occurr when a historic message was disabled (e.g. due to being timed out)
diff --git a/src/BaseTheme.cpp b/src/BaseTheme.cpp
index 4c58ccba..0a7a4aa0 100644
--- a/src/BaseTheme.cpp
+++ b/src/BaseTheme.cpp
@@ -165,6 +165,7 @@ void AB_THEME_CLASS::actuallyUpdate(double hue, double multiplier)
     // this->messages.backgrounds.resub
     // this->messages.backgrounds.whisper
     this->messages.disabled = getColor(0, sat, 1, 0.6);
+    this->messages.historic = getColor(0, sat, 1, 0.35);
     // this->messages.seperator =
     // this->messages.seperatorInner =

diff --git a/src/BaseTheme.hpp b/src/BaseTheme.hpp
index 2d6ee5cd..61b8bb2b 100644
--- a/src/BaseTheme.hpp
+++ b/src/BaseTheme.hpp
@@ -71,6 +71,7 @@ public:
         } backgrounds;

         QColor disabled;
+        QColor historic;
         //        QColor seperator;
         //        QColor seperatorInner;
         QColor selection;
diff --git a/src/messages/layouts/MessageLayout.cpp b/src/messages/layouts/MessageLayout.cpp
index 1135556e..f8bfef91 100644
--- a/src/messages/layouts/MessageLayout.cpp
+++ b/src/messages/layouts/MessageLayout.cpp
@@ -212,11 +212,10 @@ void MessageLayout::paint(QPainter &painter, int width, int y, int messageIndex,
         //        painter.fillRect(0, y, pixmap->width(), pixmap->height(),
         //                         QBrush(QColor(64, 64, 64, 64)));
     }
-
-    if (this->message_->flags.has(MessageFlag::RecentMessage))
+    else if (this->message_->flags.has(MessageFlag::RecentMessage))
     {
         painter.fillRect(0, y, pixmap->width(), pixmap->height(),
-                         app->themes->messages.disabled);
+                         app->themes->messages.historic);
     }

     if (!isMentions &&

Refined icon exampels and ideas,

A quick mockup of them being used:


change_type, converting exception

add an argument ignore_exception if one value of  a column can not be converted.
ignore_exception can be equal to :

False  (default)  to return exception

Fill_NaN to replace non convertible values with NaN

Keep_value to keep the same value when the conversion is not possible

@mdini

@mdini will take care of this. It's a great idea!


While choosing a MenuItem inside Select, Uncaught type Error:: Cannot read property 'removeAttribute' of null

[x] This is also a v.3.0.0 issue.tm
[x] I have searched the issues of this repository and believe that this is not a duplicate.
Example Used:
https://material-ui.com/demos/selects/
##CODE
<FormControl >         <InputLabel htmlFor="muscles">Muscles</InputLabel>         <Select           value={muscles}           className={classes.FormControl}           onChange={this.handleChange('muscles')}>           {categories.map(category=>               <MenuItem key={category} value={category}>                  {category}                </MenuItem>           )}         </Select>       </FormControl>

here categories is array contained values =  ["shoulders", "arms", "chest", "back", "legs"]
after choosing value, it goes into muscles variable.By default muscles value is none.
Expected Behavior
Want to choose any value inside array name as 'categories' and store it in a variable.

Current Behavior
But as soon as I choose any value from an array by clicking on any MenuItem, React gives an error and close my application and turn into a blank page. I have given a screenshot link below.

ERROR
Uncaught TypeError: Cannot read property 'removeAttribute' of null
at ariaHidden (manageAriaHidden.js:28)
at ModalManager.remove (ModalManager.js:188)
at Modal._this.handleClose (Modal.js:145)
at Modal.componentDidUpdate (Modal.js:221)
at commitLifeCycles (react-dom.development.js:15362)
at commitAllLifeCycles (react-dom.development.js:16703)
at HTMLUnknownElement.callCallback (react-dom.development.js:144)
at Object.invokeGuardedCallbackDev (react-dom.development.js:193)
at invokeGuardedCallback (react-dom.development.js:243)
at commitRoot (react-dom.development.js:16879)
at completeRoot (react-dom.development.js:18335)
at performWorkOnRoot (react-dom.development.js:18257)
at performWork (react-dom.development.js:18159)
at performSyncWork (react-dom.development.js:18132)
at interactiveUpdates$1 (react-dom.development.js:18442)
at interactiveUpdates (react-dom.development.js:2320)
at dispatchInteractiveEvent (react-dom.development.js:
The above error occurred in the  component:
in Modal (created by WithStyles(Modal))
in WithStyles(Modal) (created by Popover)
in Popover (created by WithStyles(Popover))
in WithStyles(Popover) (created by Menu)
in Menu (created by WithStyles(Menu))
in WithStyles(Menu) (created by SelectInput)
in div (created by SelectInput)
in SelectInput (created by InputBase)
in div (created by InputBase)
in InputBase (created by WithStyles(InputBase))
in WithStyles(InputBase) (created by Input)
in Input (created by WithStyles(Input))
in WithStyles(Input)
in Select (created by WithStyles(Select))
in WithStyles(Select) (at Create.js:92)
in div (created by FormControl)
in FormControl (created by WithStyles(FormControl))
in WithStyles(FormControl) (at Create.js:90)
in form (at Create.js:81)
in div (created by DialogContent)
in DialogContent (created by WithStyles(DialogContent))
in WithStyles(DialogContent) (at Create.js:77)
in div (created by Paper)
in Paper (created by WithStyles(Paper))
in WithStyles(Paper) (created by Dialog)
in Transition (created by Fade)
in Fade (created by WithTheme(Fade))
in WithTheme(Fade) (created by Dialog)
in RootRef (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal (created by WithStyles(Modal))
in WithStyles(Modal) (created by Dialog)
in Dialog (created by WithStyles(Dialog))
in WithStyles(Dialog) (at Create.js:70)
in div (at Create.js:66)
in _class2 (created by WithStyles(_class2))
in WithStyles(_class2) (at Header.js:93)
in div (created by Toolbar)
in Toolbar (created by WithStyles(Toolbar))
in WithStyles(Toolbar) (at Header.js:76)
in header (created by Paper)
in Paper (created by WithStyles(Paper))
in WithStyles(Paper) (created by AppBar)
in AppBar (created by WithStyles(AppBar))
in WithStyles(AppBar) (at Header.js:75)
in div (at Header.js:74)
in Header (created by WithStyles(Header))
in WithStyles(Header) (at App.js:39)
in App (at src/index.js:7)
Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
Context

Your Environment

Tech
Version

Material-UI/CORE
v3.3.1

Material-UI/ICONS
v3.0.1

React
v16.5.2

Browser
chrome-v70.0.3538.77

Node
v10.7.0

Duplicate #13365


Add MOTO payments documentation

Context
We can now set up a teams' GOV.UK Pay services so they can take MOTO payments (payments by over the phone or by post).
Changes proposed in this pull request

Add documentation about MOTO payments, including error codes
Alphabetise the 'Optional feature' page so it's easier to navigate

Guidance to review
Please check if factually correct.

@katiebates @oswaldquek I've rejigged things quite a bit in https://github.com/alphagov/pay-tech-docs/pull/381/commits/4d1aa9669282c9a0f0641d1f68647ac42d40fe28 following our chat - hope it's more accurate now. Let me know if anything needs changing.


covecov.io for colossus

adding test coverage tracking

Current coverage is 78.47%

Merging #234 into master will increase coverage by +3.53% as of ca76a2c

@@            master    #234   diff @@
======================================
  Files           85      69    -16
  Stmts         3596    3247   -349
  Branches       433     412    -21
  Methods          0       0
======================================
- Hit           2695    2548   -147
  Partial          0       0
+ Missed         901     699   -202

Review entire Coverage Diff

Powered by Codecov

Current coverage is 78.47%

Merging codecov into master will increase coverage by +3.53% as of 0a1c343

@@            master   codecov   diff @@
========================================
  Files           85        69    -16
  Stmts         3596      3247   -349
  Branches       433       412    -21
  Methods          0         0
========================================
- Hit           2695      2548   -147
  Partial          0         0
+ Missed         901       699   -202

Review entire Coverage Diff

Powered by Codecov

:+1:


Canvas unit tests broken?

Increased a threshold on one test, will need to test on other browsers.

Passing.


If you get a class that does not have a predefined alias, then the args are not passed

When the system looks up an alias during a get that is not defined & has to reflect it, then the args to not get passed in the get request do not get passed.  I am about to submit a test & a patch to show the issue.

@philipobenito or @nikic, could one of you please look into this issue & the submitted PR?
I have a package that I want to release, but it is not usable unless this is accepted or I aliase all of the classes.
Thanks!

It will be looked at asap, @nikic is not part of this repo.

@philipobenito, Thanks.


fix: tvm.StackEntryList + null parsing

Please merge this

@aSpite @Ghost-Drive please check if fix implemented in #45 works for the lists


ClientSecret, required or not? "Not required by this scenario"

[Enter feedback here]
HI
Working on an Frontend Blazor app using Azure AD auth to backend API and also for Graph access.
According to this guide client secret is not required  by this scenario. Is it correct?
Whithout "ClientSecret" in appsettings.json i get error:
MsalClientException: One client credential type required either: ClientSecret, Certificate, ClientAssertion or AppTokenProvider must be defined when creating a Confidential Client. Only specify one. See https://aka.ms/msal-net-client-credentials.
With client secret, i get access and can read I.E my profile picture from Azure AD. Nothing else changed.
Is the guide correct or why do I get this error without client secret?
Program.cs
builder.Services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme)
.AddMicrosoftIdentityWebApp(options =>
{
options.SaveTokens = true;
options.MaxAge = TimeSpan.FromDays(1);
builder.Configuration.Bind("AzureAd", options);
},
options => builder.Configuration.Bind("AzureAd", options)
)
.EnableTokenAcquisitionToCallDownstreamApi()
.AddMicrosoftGraph(builder.Configuration.GetSection("Graph"))
.AddInMemoryTokenCaches();

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 957649d9-8576-a551-716a-e273b9f3dadb
Version Independent ID: af706ddf-6af2-9158-c153-998c6d56cbc5
Content: Tutorial - .NET Web app accesses Microsoft Graph as the user - Azure App Service
Content Source: articles/app-service/scenario-secure-app-access-microsoft-graph-as-user.md
Service: app-service
Sub-service: web-apps
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@niemert
Thanks for your feedback! We will investigate and update as appropriate.

niemert, Apologies for the delay. Based on your issue description and the error message you are seeing, it appears that a client secret is required when creating a confidential client for Microsoft Authentication Library (MSAL) in your Blazor app.
As  suggested in the doc, that a client secret is not required for the scenario of accessing Microsoft Graph as a user, typically, a client secret is used to authenticate a confidential client, which is a client that can keep a secret, such as a web app or a daemon service. If your Blazor app is acting as a confidential client, then it may require a client secret to authenticate with Azure AD.
Just to isolate, you may try the following steps:
It is possible that the error is caused by a misconfiguration in your appsettings.json file. Please double-check that the configuration is correct and that there are no typos or syntax errors.
You may try adding a client secret to your appsettings.json file. You can create a client secret in the Azure portal by going to your app registration and selecting "Certificates & secrets". Then, you can add a new client secret and copy the value to your appsettings.json file.
Hope this helps. Let us know if you have any further questions or concerns.

niemert, We will close this now, if there are further questions regarding this matter, please let us know, and we will gladly continue the discussion.

Possibly related: Get Access Token For App later than v1.16.1 #1857
It looks like client secret may be required (incorrectly or not) with newer versions of the Microsoft.Identity.Web library.


NOISSUE - Add property based testing to bootstrap API

What type of PR is this?
This is a feature PR as it adds property-based testing to bootstrap API. In addition it is a refactor to error handling on the API

What does this do?
Adds schemathesis to bootstrap service

Which issue(s) does this PR fix/relate to?

No issue
Have you included tests for your changes?
Yes, I have included tests for my changes.

Did you document any new/modified feature?
No

Notes
To be merged after https://github.com/absmach/magistrala/pull/2094

Closed in favour of https://github.com/absmach/magistrala/pull/2095


Move to C++SDK 2.4.0

Only code change required here is SDK now expects reference to shared_ptr of video_frame_handler's and video_sink's.
-> The SDK drops its reference when the sink is replaced or the track is removed.
-> The SDK still guarantees that when streaming stops, the pointer will not be used anymore.
Read the default SDK version from file instead of hardcoding into scripts
-> This stil needs to be tested on windows to ensure properly read

Still needs to be tested on linux/mac/windows to ensure no regressions with new SDK and script changes.


External Type / extend API

Hi man,
I just discovered your POC.
I'm huge fan of the concept but one question,
would it be possible in the main app to use external Type class from plugin ?
If so how ?
Because the main app would not normally recongize type at compile ...
Or an other case could plugin add route to the ones registered in the main app ?
thanks in advance,
Best regards

would it be possible in the main app to use external Type class from plugin ?

If by "use" you mean "reference at compile-time", then yes, of course it's possible...but then you're not really in a situation where you need this library. Your plugin is not really a plugin... it's a regular .NET dependency.
The scenario this library is designed to help with is when you don't have a compilation reference from the main app to any plugins. In this scenario, there is pretty much one way to "use" the type from a plugin, which is that you use reflection to find a type dynamically and create and instance. See the sample in https://github.com/natemcmaster/DotNetCorePlugins#the-host for how to do this.

Or an other case could plugin add route to the ones registered in the main app ?

Can you elaborate? I'm not sure what this means.
Hope that helps,
Nate


Maybe allocate bug ?

Describe the bug
The cfile is uploaded as
test-c.txt
The wasm file is uploaded as
test-wasm.txt
The initial file size of Data/hello.txt is 30, and the test case is trying to allocate file space from 125, which should not be permitted.
This may be a bug.
To Reproduce
command : wazero run -mount=./Data test.wasm
Expected behavior
Print:
Successfully get the file fd.
Error allocating file space.
Error getting file attributes.

And the file is not updated into 125.
Actual behavior
Print:
Successfully get the file fd.
File 'Data/hello.txt' created and allocated with 0 bytes of space.
File Size: 125 bytes

Environment
Ubuntu20.04(x86_64)
wazero 1.5.0

Sorry, I feel confused. Isn't this a bug? Why is Wazero not producing the correct results? I am not quite sure.


Suggestion to improve docs

Currently the python code is not formatted and difficult to read in the docs - a couple of line addition will improve this, e.g.
import torch
import torchvision
model = torchvision.models.swin_transformer.swin_v2_b()
# Make sure to load a multi-image model here.
# Only the multi-image models are trained to provide robust features after max temporal pooling.
full_state_dict = torch.load('satlas-model-v1-lowres-multi.pth')
# Extract just the Swin backbone parameters from the full state dict.
swin_prefix = 'backbone.backbone.backbone.'
swin_state_dict = {k[len(swin_prefix):]: v for k, v in full_state_dict.items() if k.startswith(swin_prefix)}
model.load_state_dict(swin_state_dict)

# Assume im is shape (N, C, H, W), with N aligned images of the same location at different times.
# First get feature maps of each individual image.
x = im
outputs = []
for layer in model.features:
    x = layer(x)
    outputs.append(x.permute(0, 3, 1, 2))
feature_maps = [outputs[-7], outputs[-5], outputs[-3], outputs[-1]]
# Now apply max temporal pooling.
feature_maps = [
    m.amax(dim=0)
    for m in feature_maps
]
# feature_maps can be passed to a head, and the head or entire model can be trained to fine-tune on task-specific labels.

using ```python etc

Thanks, I have replaced the spaced Python code blocks with fenced ones.