Can't declare Boolean attributes with default of true?

The way attributes are deserialized seems to preclude the declaration of attributes that default to true.
From the docs: "Boolean properties set based on the existence of the attribute: if the attribute exists at all, its value is true, regardless of its string-value (and the value is only false if the attribute does not exist)."
That works for attributes with a default value of false. If someone wants the default value, they leave the attribute off. If they want the non-default value of true, they can explicitly say attr="true" (or any string).
But I don't see how to declare support for a Boolean attribute that defaults to true. See http://jsbin.com/neyaxu/1/edit?html,output. Here, I want to be able to override the default behavior by saying red="false". Since Polymer interprets any string value of true, however, it doesn't appear to be possible to declaratively set the attribute to false. That can be done imperatively, but it should also be possible imperatively.
While an attribute's logic can always be flipped such that its default value is false, there are cases where an attribute's obviously API name naturally suggests a default value of true.

+1 to being able to use prop="false" and have Polymer deserialize it as a Boolean false. Any other String value can be true. Or maybe also accept "0".
One more thing. It also causes more confusion when I use dom-repeat to create a bunch of custom elements, with Boolean properties. What am I supposed to set for the attribute?
<template is="dom-repeat" items="{{arr}}">
  <x-test bool-attr="{{item.foo}}"></x-test>
</template>

If Polymer were strict about "Boolean properties set based on the existence of the attribute", then there is no way to set bool-attr to false, since there's no way to conditionally set the presence of an attribute (you can only set an attribute's value). But actually, Polymer is fine with the above syntax... it reads the Boolean value of property foo in Objects in arr, and passes them on correctly to x-test's bool-attr property.

Note that this isn't really Polymer's definition of a boolean attribute, it's HTML's definition of a boolean attribute:
http://www.w3.org/TR/2008/WD-html5-20080610/semantics.html#boolean
I think there's a tension here between something that's arguably more flexible (foo="false") and something that's arguably more idiomatic with native elements (presence == true). Even the web platform is incoherent here, since ARIA uses string values for "true" and "false".
@punzki you're confusing setting an HTML attribute and data binding to a property. The value of item.foo isn't being deserialized here. You're assigning x-test.boolAttr the value of item.foo.

@arthurevans - That's precisely my point, that it is confusing, and inconsistent. When you put x-test in regular HTML markup, you set x-test.boolAttr by the presence/absence of the bool-attr HTML boolean attribute. But when it's used inside a dom-repeat, you're supposed to assign it by using a non-boolean HTML attribute.

I'm curious to better understand the use-case for having a boolean property have a default of true. Would it not be possible to simply reverse the logic behind the property such that the desired functionality would be possible with a default of false?
For example, assuming we're working with an element that validates villains to see whether or not they're fit of being someone's arch-nemesis, instead of using evilLairRequired with a default of true, there would be a property evilLairOptional with a default of false.
Basically, what I'm getting at is: what's a expectable use-case where this is not possible?

@vsimonian There are cases where the most natural and desirable attribute name would be framed in the positive. While attributes are just symbols, and their meaning can be inverted and still make logical sense, an API is tantamount to language, and humans want language to read naturally. In some cases, the positive form of a word may be more concise or common than the negative form. (Some rare words like "inert" have no opposite form.) In other cases, the negative form may be misleading or inaccurate. And it's often desired that an API should mirror the corresponding terms in the user interface.

A component wants an auto-size attribute that defaults to true. It's hard to come up with a natural-sounding word or phrase that means the opposite of "auto-size".
A window component has a maximize attribute that defaults to true. The meaning of maximize="true" is different than minimize="false". Something like not-maximized="false" may be accurate but quite awkward and hard to parse.
A site has some type of object that can be marked as a "favorite", and for whatever reason, the default is true. Because the UI uses the term "favorite", it's desirable to have the attribute be called favorite, with a corresponding default value of true.

I encountered this when migrating elements from 0.5 to 1.0. To avoid coming up with corresponding negative forms, I just used an additional word in front of the attribute names to represent an attribute is disabled or its effects have been inhibited or its dimensions have been reduced (something like disable-).
Although more than one word, this seemed to:

preserve the UI jargon
aide in keeping the inherent truth and default behavior of the element
provide type hinting for attributes named similar to favorite where its boolean nature is rather obscure

The prefix disable- may not be great in all contexts but other familiar words may be juxtaposed to have the similar effects.

As Arthur mentioned, Boolean attributes have a specific platform meaning from which we do not want to stray.  We also feel that the practice of defaulting booleans to false makes sense in the vast majority of cases, and places where the platform has strayed (e.g. draggable="true") were poor design decisions that result in confusing and unintuitive API and are warts of the platform that we are stuck with.  For these reasons, we have no plan to change how type: Boolean values are deserialized by default.
That said, there are some options if you choose to go forward implementing this type of API for your elements.

Use type: Object - this actually hints Polymer to use JSON.parse which result in the desired behavior ("true" and "false" parse desired):
http://jsbin.com/zawale/edit?html,output

Implement a custom serialize/deserialize function for your element.  We intentionally made these methods easily overridable for cases when authors need to augment the default approach.
http://jsbin.com/rerevu/edit?html,output

@kevinpschaaf I think Polymer's position is reasonable. Thanks for letting us know about those options!

This is a shame. It is not intuitive at all. I need to programatically set the value for paper-input-container's noLabelFloat boolean property  It's wrapped in a custome element and I need to disable noLableFloat in some cases.. It cannot be done via a binding thanks to this behaviour. I have to resort to dom-if logic, or write code that sets the property value manually.  All that could be avoided if I could just bind a value.

This isn't related to data binding. This only affects configuring the element from static markup.
You can easily use a data binding to toggle noLabelFloat:
http://jsbin.com/gosaza/edit?html,output

Many thanks.  I got it working with the binding.  In my state of confusion when I first countered this I issue I messed up my binding declaration and concluded incorrectly that it didn't work.

Glad to hear it :+1:


Incorrect module path

Please fix go.mod so that the module path is correct. This is preventing me from importing the module into my project and giving me the following error when issuing go get -u github.com/austinh115/lz-string-go
go: downloading github.com/austinh115/lz-string-go v0.0.0-20210415205647-9ede4c0014d0
go get: github.com/austinh115/lz-string-go@none updating to
<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: lz-string-go
                but was required as: github.com/austinh115/lz-string-go

Current go.mod:
module lz-string-go

go 1.16

Proposed go.mod:
module github.com/austinh115/lz-string-go

go 1.16

Done, feel free to pr next time

Much appreciated, thanks you


cannot run on Google Colab

i executed the cell but after a few seconds, there was an error with ^C at the end.
(i wanted to convert a 30fps video to 60fps, the input video resolution is 2304x4096, the length is 19s)

It seems that original demo can still run successfully. Could you please give me a screenshot to show the error?

@hzwer

It just ran for 5 seconds then stopped. The ram usage was very high:

write_buffer = Queue(maxsize=500)
I guess it might be useful to turn down maxsize. However, colab may not be able to handle videos with too high resolution.

what maxsize do you recommend for each resolution? thanks so much

I am very sorry that I cannot answer this question. If RAM overhead is important, I will consider how to optimize it.

@hzwer I think you should add some arguments, like tile size in some upscaling apps to put less stress on GPU, increasing processing time while the output quality is the same.


update/site/components-page-lighthouse

This PR increases the components page Lighthouse scores.

Looks like these changes have fixed the issues and now component pages are scoring 100 across the board.
There are a few pages with lower performance scores but they feature components with images. I'll be looking at improving images in the future.


Shorten cumbersome property names

@marksem I agree that the current versions using "geographically" are cumbersome and should be changed back to "geo."  We might want to check for other cumbersome property names as well.

This opens pandora's box.  We have a policy for not abbreviating. If we allow abbreviations sometimes, but not others, what are the guidelines?

@uscholdm  You're right. No backpedaling.


[SPARK-40197][SQL] Replace query plan with context for MULTI_VALUE_SUBQUERY_ERROR

What changes were proposed in this pull request?

Replace query plan with context for MULTI_VALUE_SUBQUERY_ERROR
Why are the changes needed?

User-friendly errors.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Unit test

@gengliangwang @MaxGekk

Can one of the admins verify this patch?

+1, LGTM. Merging to master.
Thank you, @vitaliili-db and @gengliangwang for review.


Thanks for the patch, seems good to merge, you just have to fix formatting by using tabs like the rest of the file.

@packowitz can you replace spaces by tabs in order to merge it please ?

My second commit should have done exactly that.

it doesn't seem so, really :p


JBEHAVE-1174 Fix reporting of afterStory for AfterStories in multithreaded run

JBEHAVE-1174 Fix reporting of afterStory for AfterStories in multithreaded run
JBEHAVE-1174 Invoke delegated delayed story reporters

This will also fix: https://github.com/serenity-bdd/serenity-jbehave/issues/89

@maurotalevi , could you please review the changes?

Added comment to https://jbehave.atlassian.net/browse/JBEHAVE-1174 https://jbehave.atlassian.net/browse/JBEHAVE-1174

On 1 Aug 2017, at 16:46, Valery Yatsynovich<EMAIL_ADDRESS>wrote:
@maurotalevi https://github.com/maurotalevi , could you please review the changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jbehave/jbehave-core/pull/146#issuecomment-319392389, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPXzVxJWchBdpy0CbZD7v1eDX7K9RYAks5sTzosgaJpZM4N2973.

@maurotalevi , could you please review the changes?

@maurotalevi , could you please review the changes?

The fixes are added to the master branch: 3aaa1b2fcfab7bc2e6a8904dbdd638380ec1a821, adf9497b5621555d8e9f6fe5c702f3fb93296d09


Add pyproject.toml for Custom Node Registry

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:

[x] Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
[x] Write a short the description.
[x] Merge the separate Github Actions PR and run the workflow.
If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

hey @hackkhai, wanted to send a small nudge and ask if you had any questions!

publisher id: hackkhai

Its done!


keyboard mapping buggy

Microsoft PowerToys version
0.43.0
Running as admin

[ ] Yes

Area(s) with issue?
Keyboard Manager
Steps to reproduce
Assign left command key (apple keyboard) to left alt key. After a while win10 begins to remap command key to windows key.
✔ Expected Behavior
Expected my keymap would be respected by OS.
❌ Actual Behavior
Strang behaviour
Other Software
No response

Thanks for reporting this @dbpodrasky! Can you please attach the logs generated by the Report Bug tool in the systray?

I think the Command key of Apple's keyboard is by default mapped to the Windows key, right?
It might be the case that you're seeing the default remapping on focused elements that belong to the system or are running as administrator.
Does running PowerToys as an Administrator fix your issue?

Thanks for reporting this @dbpodrasky! Can you please attach the logs generated by the Report Bug tool in the systray?

@dedavis6797
Here they are. Thanks for telling me where to find/generate logs!
PowerToysReport_2021-08-05-09-51-53.zip

@jaimecbernardo
So far, remapping keys in Admin mode results in the expected behavior. It seems that this isn't really a PowerToys issue per se, but why should I have to use elevated privileges to remap keys? Silly, MS "security" decisions...
If weirdness reemerges (say, after reboot) I'll update with a new comment.

Need to reopen as the previous bad behavior came back after a system reboot.

@dbpodrasky it's happening even when in Admin mode?

Yes. After reboot.
Sent from my Apple Watch

On Aug 5, 2021, at 18:32, Deondre Davis @.***> wrote:
@dbpodrasky it's happening even when in Admin mode?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

@dbpodrasky ,
Do you have both of these options turned on?

Both? I turned on Admin Mode as previously mentioned. After reboot, even with Admin Mode, settings were not respected by OS. What other option are you referring to, @jaimecbernardo?

Sorry, was missing the screenshot.
Both these options:

I guess github.com is having a problem uploading pictures right now.
@jaimecbernardo, yes both options are selected (admin and startup).

I've tried using this remapping for a bit and rebooting, but it keeps working as expected.
I've been unable to reproduce this with admin and startup turned on.
(Except for the shortcuts reserved by the OS: https://docs.microsoft.com/en-us/windows/powertoys/keyboard-manager )

I'm experiencing similar issues with assigning keyboard shortcuts for left win + R and a bunch of similar shortcuts. The annoying thing is that they do work for a while but then silently stops working. Need to reboot to get things up and running again.

@jaimecbernardo, as previously established, admin mode is not the issue. Also, the reserved shortcuts do not apply to either win + R or win + tab. Have you attempted key mappings using left win key?

Yes, I've used left win key in my tests.

Is there any way we can reroduce this? If not I think we will have to close this issue.

I can't repro this.  This mapping works on my machine and would be the mapping needed for a boot camp scenario.

@dbpodrasky can you test on a 0.51.1 build?  I tested on a test build of 0.53 but I think we didn't touch KBM in the 0.53 span so code should be the same.


feat: handle multiple commits in a single message

Summary
This PR enhances the breaking change detection mechanism and improves the parsing of commit messages to handle multiple conventional commits and nested commit blocks mentioned in #2357
Changes

Added additional breaking change detection from the commit body in toConventionalChangelogFormat and postProcessCommits functions.
Enhanced splitMessages function to:

Separate conventional commits within the main message.
Extract nested commits enclosed in BEGIN_NESTED_COMMIT/END_NESTED_COMMIT blocks.
Preserve the original message structure outside of nested commit blocks.
Handle multiple nested commits and conventional commits in a single message.

Updated tests in test/commits.ts to reflect the changes and added new test cases for multiple commits in a single message.
Added a new fixture multiple-commits-single-message.txt for testing multiple commits in a single message.

Additional Notes

The changes ensure that breaking changes mentioned in the commit body are correctly appended to the breaking change notes.
The splitMessages function now correctly handles and separates multiple conventional commits and nested commit blocks, improving the accuracy of commit parsing.
Updated test cases ensure the robustness of the new functionality and maintain backward compatibility.
First time contributing to release-please so please review carefully as the splitMessages function seems to be a critical function 🙃

Fixes #2357

Hi @chingor13, thanks for the review.
I want to clarify the necessity of including the breaking change detection lines in src/commit.ts (Lines 172 to 184 and 329 to 344) from this branch. Without these lines, the following two tests fail, which is why I felt it was essential to add the additional checks.

"DefaultChangelogNotes buildNotes with commit parsing should handle meta commits"

This test fails because the generated changelog is missing the "BREAKING CHANGES" section. The expected output includes a breaking change for the recaptchaenterprise component, but the actual output does not contain this section, leading to a mismatch.

"parseConventionalCommits parses meta commits"

This test fails because it expects a commit to be recognized as a breaking change (true), but it is incorrectly identified as false. This discrepancy arises from the lack of additional breaking change detection logic, which is crucial for accurately parsing and recognizing breaking changes in commit messages.

From my understanding, the library you mentioned is not capable of detecting breaking changes in the body of the commit out of the box. If it were, I would expect the tests to pass without the additional checks. By including these lines, I ensure that the tests pass and that the changelog accurately reflects the intended breaking changes, thus maintaining the integrity of the commit parsing process and stay backward compatible.
I would be happy to try out any ideas you might have to keep the scope of this PR limited to the splitting of the commit messages, without including any breaking change detection. If you have any suggestions on how to accomplish this without affecting the breaking change logic, I would appreciate your input.


[Bug]浏览器直接访问ipv6地址出错

Describe the bug【描述 bug】
浏览器直接访问http://[ipv6 address]
无法访问
Expected behavior【预期的行为】
打开ipv6网页
Config file 【配置文件，客户端服务端配置都提供】
[[listen]]
tag = "vlesss"
protocol = "vlesss"
users = [
]
host = "<IP_ADDRESS>"
port = 443
version = -1
insecure = false
cert = "/etc/verysimple/cert.pem"
key = "/etc/verysimple/cert.key"
advancedLayer = "ws"
path =

配置文件，客户端服务端配置都提供

服务端
[[listen]]
tag = "vlesss"
protocol = "vlesss"
users = [
]
host = "<IP_ADDRESS>"
port = 443
version = -1
insecure = false
cert = "/etc/verysimple/cert.pem"
key = "/etc/verysimple/cert.key"
advancedLayer = "ws"
path =

客户端
v2rayn

补充一下细节，本地没有ipv6，代理服务器有ipv6，打开代理。
访问http://[2402:4e00:1013:e500:0:940e:29d7:3443]
无法访问。
照理可以访问此网站。

debug日志

v2rayN 客户端日志
2022/06/05 23:58:48 [Info] [2680934917] proxy/socks: TCP Connect request to tcp:[2402:4e00:1013:e500:0:940e:29d7:3443]:80
2022/06/05 23:58:48 [Info] [2680934917] app/dispatcher: taking detour [proxy] for [tcp:[2402:4e00:1013:e500:0:940e:29d7:3443]:80]
2022/06/05 23:58:48 tcp:<IP_ADDRESS>:62026 accepted tcp:[2402:4e00:1013:e500:0:940e:29d7:3443]:80 [proxy]
2022/06/05 23:58:48 [Info] [2680934917] transport/internet/websocket: creating connection to tcp:***
2022/06/05 23:58:48 [Info] [2680934917] proxy/vless/outbound: tunneling request to tcp:[2402:4e00:1013:e500:0:940e:29d7:3443]:80 via tcp:***
2022/06/05 23:58:48 [Info] [2680934917] app/proxyman/outbound: failed to process outbound traffic > proxy/vless/outbound: connection ends > proxy/vless/outbound: failed to decode response header > proxy/vless/encoding: unexpected response version. Expecting 0 but actually 72
2022/06/05 23:58:48 [Info] [2680934917] app/proxyman/inbound: connection ends > proxy/socks: connection ends > proxy/socks: failed to transport all TCP response > io: read/write on closed pipe

服务端
verysimple    | 2022-06-06 07:04:38.658 INFO    New Accepted Conn       {"connid": 785157, "from": "***", "handler": "tcp+tls+ws+vless://<IP_ADDRESS>:443#vlesss"}
verysimple    | 2022-06-06 07:04:38.738 WARN    failed in inServer proxy handshake      {"connid": 785157, "handler": "<IP_ADDRESS>:443", "error": " [ fallback, reason 4 , Detail: short read ] , with Buffer."}
verysimple    | 2022-06-06 07:04:38.742 DEBUG   Fallback to     {"addr": "/dev/shm/myreject", "params": ["http/1.1", "***"]}
verysimple    | 2022-06-06 07:04:38.745 DEBUG   Try routing     {"connid": 785157, "source": {"Addr":{"Network":"unix","Name":"/dev/shm/myreject","IP":"","Port":0},"InTag":"vlesss","UserIdentityStr":""}}
verysimple    | 2022-06-06 07:04:38.747 DEBUG   Default Route   {"connid": 785157, "source": "/dev/shm/myreject", "client": "direct", "addr": ""}
verysimple    | 2022-06-06 07:04:38.749 INFO    Request {"connid": 785157, "from": "****", "target": "unix://%2Fdev%2Fshm%2Fmyreject", "through": "direct://"}
verysimple    | 2022-06-06 07:04:38.752 DEBUG   handshake client with first payload     {"connid": 785157, "len": 536}
verysimple    | 2022-06-06 07:04:38.753 DEBUG   TryCopy {"id": 785157, "from": "*net.UnixConn", "->": "*ws.Conn"}
verysimple    | 2022-06-06 07:04:38.754 DEBUG   copying with readv      {"id": 785157}
verysimple    | 2022-06-06 07:04:38.755 DEBUG   TryCopy {"id": 785157, "from": "*ws.Conn", "->": "*net.UnixConn"}
verysimple    | 2022-06-06 07:04:38.758 DEBUG   copying with classic method     {"id": 785157}
verysimple    | 2022-06-06 07:04:38.759 INFO    New Accepted Conn       {"connid": 602846, "from": "@", "handler": "unix+reject:///dev/shm/myreject#myreject"}
verysimple    | 2022-06-06 07:04:38.761 DEBUG   Relay End       {"id": 785157, "direction": "R->L", "target": "/dev/shm/myreject", "bytes": 288, "error": "EOF"}
verysimple    | 2022-06-06 07:04:38.763 DEBUG   Relay End       {"id": 785157, "direction": "L->R", "target": "/dev/shm/myreject", "bytes": 0, "error": "read tcp ***->***: use of closed network connection"}


No longer getting warnings about names

Given this source:
package main

// Bar should not be OK as the first word...
const Foo = 42

I would expect golint to complain like: comment on exported const Foo should be of the form "Foo ..." but it does not, it seems happy with it.
Updated to the very latest golint right now, still does the same. Go version is go version go1.4 linux/amd64.
Thank you :)

This sounds like #166. Maybe I did something wrong in 32a8716.

Sorry for opening a duplicate issue then, yes, it seems like that exact issue. I only searched in the Open issues before creating this one. Please feel free to close/merge. Thank you! :)

I can't reproduce your bug report. I do get golint reporting that. I suspect it's because you're on an old version of Go, and I'm using Go 1.5.

Thank you, upgraded to 1.5.2 and indeed, it works as expected. Cheers!


Upgrade to readable-stream 3

Upgrade to readable-stream 3 for Node.js 10 for await functionality

PR welcome @kyrylkov

This issue is fixed I think


Code not places one order and crashes

Hey @bmino!
I just recently cloned your repo, honestly looks pretty neat. I've had the same problem where its not been placing orders even at really high percentages of 4% that have been going own for an age of around 40 to 100 seconds. I have a very similar config file. The logs still show that WebSocket are being disconnected so i increased the bundle size in hopes of reducing the number of sockets but that didn't fix the issue. The program would run on the HUD make a max of one trade and exit with the following error:

I hope to reopen this issue to help make this program work!
Originally posted by @georgekhanachat in https://github.com/bmino/binance-triangle-arbitrage/issues/116#issuecomment-773969331

There are a few questions in that issue haha.

The bot is configured to stop after one trade by default (EXECUTION.CAP). Check out the config readme on how that is configured
Orders will only be placed that match your thresholds. This includes age thresholds and profit thresholds. Check out the config readme on how these work.
ELIFECYCLE errors will happen when your system can't handle too many requests or a request is blocked. It happens

Also, I haven't personally found that modifying the websocket bundle size had an affect on disconnecting websockets. That was put in there as a debugging tool before the underlying issue was discovered which was the cpu being overloaded and becoming unable to handle websocket ping/pong packets

I believe this might be caused by some limitation on Binance's side. Regardless of configuration I seem to crash after 9 seconds of subscriptions consistently.
This is also the case using most conservative configuration such as DEPTH 5, INTERVAL 1000 (bundle size 1).

Funny enough, setting
    "BINANCE_OPTIONS": {
      "recvWdindow": 60000,
      "useServerTime": true
    }

As sugested here allows me to get through the Opening 315 depth websockets for 315 tickers ... section but crashes inmediatly after Waiting for all tickers to receive initial depth snapshot ... with another Timeout.
I have also tried increasing the receive timeout with no success.
Binance must be under heavy load with the recent pump and dump campaigns.

What do you see in your performance log about cpu cycle usage?

What do you see in your performance log about cpu cycle usage?

No reference to CPU cycle usage, only latency messages (very high btw, about 3600ms)

The cpu output is configured by default every 2 minutes by the LOG.STATUS_UPDATE_INTERVAL

Pinging will only resolve the url, that is not interacting with the api and getting an api response so it should be faster

The cpu output will not be logged because it is configured after the line 58, where it crashes. I can modify the code to overcome this but im not sure if the ouput will then be relevant to you, let me know.

Ahh okay, so the bot isn't successfully initializing the depth caches. This means it is failing to either open a websocket, or make the depth cache init request.

What cpu is this running on?

What cpu is this running on?

Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
On Ubuntu 20.04.2 LTS

I assume you are using the latest version right? In the original screenshot posted, the output implies that the depth caches were already setup successfully and the error occurred during runtime.
Once all startup logic has completed and the depth caches are initialized, there is a "Initialized" log output as the bot is now running calculations

Binance had upgraded their API, we are not experiencing heavy load related issues since a couple of days.
Curious if running
    "BINANCE_OPTIONS": {       "recvWdindow": 60000,       "useServerTime": true     }
Now, still gives the same result.

I am closing this issue as discussion has drifted in many directions from the original issue. Please feel free to open any new specific issues and we can address them individually


Implemented logging token usage (solves #322)

Token usage is now tracked and logged into the file memory/logs/token_usage.
Solves #322
How it works:

every time ai.next is called, the token usage is computed and tracked
after the whole run, the token usage is formatted and printed to the file memory/logs/token_usage.

Output:
File in csv format with column:

step_name
prompt_tokens_in_step
completion_tokens_in_step
total_tokens_in_step
total_prompt_tokens
total_completion_tokens
total_tokens

Notable changes:

each step now passes its name to ai.next, which is used for logging
added dependency to package tiktoken as it's needed to compute token usage when using streaming

Thanks for this!
Two questions:

Shouldn't we use the response from the OpenAI API to compute the token usage? See screenshot.
How can we solve the "name" of the steps with python? Can't merge it with hardcoded string for step name like this :/.  I think you should be able to ask chatgpt4.

Hey @AntonOsika!
Re 1: Those usage stats are only available when you don't stream. When streaming, you have to calculate the token usage afterwards using tiktoken (see this post on the openai forums)

Re 2: Have changed it so the step names are now inferred from the function name via step.__name__. Does that work for you?

Makes sense!
Great job @UmerHA. Was about to say "let's merge" but I realized it can be done in a way that preserves what people complement this project for: How simple and clean it is.
If you would check my comments, resolve any conflicts, and run black (black should run if you setup pre-commit hooks like in CONTRIBUTING.md I'd love to merge!

@AntonOsika all done! Lmk if there's anything else!

Fantastic

Merging — just checking, did you test this runs as expected, and if not could you do it? (Traveling for work atm)

Merging — just checking, did you test this runs as expected, and if not could you do it? (Traveling for work atm)

Of course I did :)


Native fails when set any Extra Data for User

OS:

[ ]  Windows
[x]  MacOS
[ ]  Linux

Platform:

[x]  iOS
[ ]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
v8.10.0
5.7.1

Config:
Sentry.config('🔑').install()

I have following issue:
Tha app fails when tries to set extra data for a user inside user's context object (setUserContext) or directly extra context (setUserContext)
The App doesn't send JavaScript Exception to JS Engine
Error:
2018-03-27 16:19:54.483105+0300 AppName[45067:4432257] [User Defaults] Attempt to set a non-property-list object {
        status = Approved;
...

2018-03-27 16:19:54.485246+0300 AppName[45067:4432257] Exception 'Attempt to insert non-property list object {
        status = Approved;
...

for key sentry.io.extra' was thrown while invoking setExtra on target RNSentry with params (
        {
        status = ...

2018-03-27 16:19:54.497 [info][tid:com.facebook.react.JavaScript]

Steps to reproduce:

Write in the code Sentry.setUserContext({id: ..., extra: {...}}) or Sentry.setExtraContext({...})
run the app
app fails

Actual result:

App fails with exception in Native code execution but no message/error/warning on JS thread

Expected result:

The App should send to JavaScript engine the Exception at least
OR
Set extra data to send in each error/message/capture log

Hey, sorry for the late reply.
Please make sure the data you pass in is JSON compatible containing only primitive types.
I am not able to reproduce this issue for me this is working fine:
Sentry.setUserContext({
  email<EMAIL_ADDRESS>  userID: '12341',
  username: 'username',
  extra: {
    is_admin: false
  }
});

Please feel free to reopen this issue if you are still having troubles.


uart: set baudrate as configured in config file

This PR extends the method for connecting to a serially connected sbg Ellipse D with unknown baudrate. If the baudrate from the .yaml config file does not work, one after the other possible baudrate is tried. Once a baudrate is found where connecting succeeds, it is used to set the baudrate from the .yaml config file on the device and re-connect.

@grischi
Thanks you for your feedback.
When running your solution with an Ellipse D it doesn't work as expected.
The baudrate is found but we don't receive any data from the Ellipse.
By removing the call of setDeviceBaudrate() it works.
However, having a fixed list of baudrate in the code avoids being able to update it easily.
A preferred solution would be to support a baudrate list directly in the yaml configuration file so each user can define the baudrates he wants to test.
For example you could have the following configuration and then test for only 921600 and 115200 baudrates that would match with the desired and the default baudrates.
[...]
baudRate:
    - 921600
    - 115200
[...]

Moreover that would allow to extend with new possible values without having to build a new firmware.

Hi @tolesam ,
I was able to reproduce the problem on our side and pushed a fix, so setting the baudrate shall now work.

@grischi
Thank you, however fallback baudrates are still hardcoded and then avoid to make it evolved using the configuration only.
Could you change to support the following in the configuration file and then remove hardcoded baurates list:
      # Baud rate (4800 ,9600 ,19200 ,38400 ,115200 [default],230400 ,460800 ,921600)
      baudRate: 115200

      # Fallback baud rates to test if baudRate doesn't work
      fallbackBaudRates:
        - 115200
        - 921600

replaced with https://github.com/SBG-Systems/sbg_ros2_driver/pull/41


AWS Accept/Reject Action field in exporter report for VPC logs

This is work-in-progress to support the "action" feature of aws.
For each flow, specify whether it was Accepted or Rejected.
This code was forked from master before refactor resolver code and before  subscribe to flows by capture_id.
Keep this in mind when reviewing the code and ignore those parts that are impacted by these other merges.
The assumption is that we have 2 points where the flows are captured: one on each side of a firewall. If a flow appears on only one side, we declare it as Rejected. If the flow appears on both sides, we declare it as Accepted.
@hunchback @eranra

@KalmanMeth - please rebase and squash commits

please rebase

rebased to master.

run tests

please add a unit test

There is a unit test called action_test.go in secadvisor/mod.

feedback from @safchain was that he rather we dont alter the flow Flow structure so this means that operations should be done after the transform step on the SecurityAdvisorFlow struct.

I removed the field from the Flow structure and performed the Action after the Transform step.

run skydive-functional-tests-backend-orientdb

@KalmanMeth - please convert to use Mangler (just as log status).

This was moved to skydive-flows-exporters: https://github.com/skydive-project/skydive-flow-exporter/pull/9


[C-1195] Github integration : fetch discussion

Actually github discussion are not fetched by the github integration.
Since github discussion is more and more popular, we need to track them as github issues
C-1195

Hi @tchiotludo, thanks for pointing this out. We should be fetching GitHub discussions already, we will check this out and get back to you

duplicate

@tchiotludo FYI: this should be fixed next week :)

this should be fixed now @tchiotludo!


'Laste updated at' is showing time in the future

As you can see in the screenshot, I've just imported a mirrored repository, but the last updated at is showing time in the future. I'm in GMT+8 and the time this repo was imported is 2015-09-25 16:28 local time.

Here is the result of date command on my server.
$ date
Fri Sep 25 16:35:41 CST 2015

Thanks your feedback!

What is your Gogs version?
Which database are you using?

I'm using the binary build downloaded from official site with MySQL database.

Version string from page footer is <IP_ADDRESS>3 Beta

Thanks your info!
Can you upgrade to master so we are on the same page?

Same issue on <IP_ADDRESS>3 using SQLite3 storage

Ok, I've not upgraded to master yet, but I think this seems to be a one-time issue after the first installation.
At first I transferred a Gogs server from Linode to Aliyun, and forgot to migrate the MySQL database. And I reinstalled this new server with Gogs running behind nginx (under /projects/ path), and the styles, js and other resources were broken when I launched the installation page, thus leading me to use SQLite database (because without styling I can't really tell which was selected).
Then, right before I first reported this issue, I found I was using SQLite instead of MySQL, and I ran another re-installation. This issue then was found right after the installation finished as I mirrored my first repository.
Now I don't see any more time issue, I've mirrored some more repositories just now and they're ok.

Thanks your details!
Please comment on https://github.com/gogits/gogs/issues/1500 in the future for this issue. Closing this right now.


SDFGI: Slight occlusion improvements.

Slight improvements to occlusion.

Thanks!

Before/after comparison:
Preview
Before

After


[New game]: Fruit Catch Game

🎮 Game Request
The player controls a basket at the bottom of the screen to catch fruits falling from the top. The game ends when the player misses 5 fruits.

Point down the features

Levels and Difficulty: Increase the speed and frequency of falling fruits as the player's score increases.
Different Fruit Types: There will be different types of fruits.
Friendly user interface

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @its-kritika !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @its-kritika ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Java issue

Hi, Im really bad in Java and I just install maven so.. pls understand i'm really noob on this type of programs.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.475 s
[INFO] Finished at: 2021-09-19T23:25:35-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project Celestial: Could not resolve dependencies for project me.hulipvp.celestial:Celestial:jar:1.0.0-DEV: The following artifacts could not be resolved: org.github.paperspigot:paperspigot:jar:1.7.10-R0.1-SNAPSHOT, org.github.paperspigot:paperspigot-api:jar:1.7.10-R0.1-SNAPSHOT: Could not find artifact org.github.paperspigot:paperspigot:jar:1.7.10-R0.1-SNAPSHOT -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Thanks

Have you tried adding the repositories
<repositories>
        <repository>
            <id>papermc</id>
            <url>https://papermc.io/repo/repository/maven-public/</url>
        </repository>
    </repositories>

Also u, can remove this and try if the code doesn't bug, and if it doesn't just compile.
<dependency>
            <groupId>org.github.paperspigot</groupId>
            <artifactId>paperspigot</artifactId>
            <version>1.7.10-R0.1-SNAPSHOT</version>
            <scope>provided</scope>
</dependency>


Footer Padding

Proposed changes
Added 20px left-right-padding to footer-copyright, so that whenever someone opens the footer section in the documentation, the copyright text will have some gap between the text and its borders.
It looks in a manner for the documentation readers.
Screenshots (if appropriate) or codepen:
Before:

After:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Surely the issue here is a missing container tag on the example? The footer markup includes a container inside the footer-copyright and this should provide the spacing rather than some arbitrary padding added later? Or is that not how the docs display?

The footer contains a container div but the footer-copyright doesnt..
Thats why I added padding to footer copyright..
Otherwise I can also move the footer-copyright section inside the
container...
Any of these two ways are suitable..
Thanks for looking into it.
On Sat, Oct 5, 2019, 4:11 PM pwcreative<EMAIL_ADDRESS>wrote:

Surely the issue here is a missing container tag on the example? The
footer markup includes a container inside the footer-copyright and this
should provide the spacing rather than some arbitrary padding added later?
Or is that not how the docs display?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Dogfalo/materialize/pull/6456?email_source=notifications&email_token=AKYW4NJKG6OPM4K3GVRNE3TQNBY6DA5CNFSM4I5SIOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANQASA#issuecomment-538640456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYW4NNADYLW4KVOZVXHKCTQNBY6DANCNFSM4I5SIOOA
.

I think adding the container into the markup seeing as this is how the element is structured.

I have moved the footer-copyright inside the container to avoid additional padding..


upgrade: luajit to version 2.1-20240815

In LuaJit version 2.1-20240815, some performance and security issues have been fixed. OpenResty version <IP_ADDRESS> has already used this version, and we hope that the enterprise version will also be upgraded to this version.
LuaJIT updated to 2.1-20240815 with various optimizations and bugfixes:
Improved error handling and stack overflow management

Enhanced cross-32/64 bit and deterministic bytecode generation

Disabled hash computation optimization in the OpenResty branch due to potential severe performance degradation (CVE-2024-39702). This issue only exists in the OpenResty branch (agentzh-v2.1) and not in upstream LuaJIT. We thank Zhongwei Yao from Kong Inc. for reporting this issue.

EE CI passing with this commit. Ref: https://github.com/api7/api7-ee-3-gateway/pull/696


Collection hooks generated twice

Dear @perak ,
There is the bug related to generate collection hooks twice in version 0.9.39.
Please help me check it.

@baysao OK, let's do it now before I upload 0.9.40. Let me see...

Ooops, yes it's a bug. Fixing...

Fixed. Will upload new version (0.9.40) in ~1 hour

thanks @perak for extremely supportive.

Uploaded v0.9.40


ask for password confirmation in npm-script

Aks to confirm password when running the script 'first-time-setup'
You can insert wrong pairs of passwords up to three times

HI, I made the changes. Now the test passes. Regards.

After further review, I'm not sure this is necessary. I'm going to close for now. Thanks again for being active and creating a PR.


Added an alias for HTTPS in fish completions

Ensure that fish completion is working with the https command.
It just wraps the identical completions from http to https.
Documentation for fish-functions, see --wraps

Inherit completions from the given WRAPPED_COMMAND. See the documentation for complete for more information.

this unfortunately breaks https for fish users. I defined https as http --default-scheme https $argv, but now the default-scheme argument gets lost, because my function is overwritten by the one defined here. (and httpie is invoked as http, so it can't tell that it should do anything different, as it's documented to.)


Fix the bug primitives cannot handle circuits with ndarray parameters

Summary
Fixes #9102
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 84.545%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
62465

Relevant Lines:
73884

💛  - Coveralls

Shall I merge this PR?


Inverted FloatingPanel?

Is there a way to invert the floating panel? That is, it starts from the top and expands towards the bottom.

Of course. Please try "Show Top Positioned Panel" in Samples.app. The panel uses this layout, https://github.com/scenee/FloatingPanel/blob/2.4.0/Examples/Samples/Sources/Layouts.swift#L23.

Thank you very much ^_^!


Update mocha related dependencies

Motivation
Use latest dependencies.
Description

Update Typescript
Update Mocha
Update Chai
Update Yargs

Steps to test or reproduce

Run all tests

Thanks! There's CI failures

@dapplion  Seems like the error related tot he permission for the repo.

HttpError: Resource not accessible by integration

As locally it's passing fine.
❯ yarn benchmark --local ./cache
yarn run v1.22.22
$ node -r ts-node/register src/cli.ts 'test/perf/**/*.test.ts' --local ./cache
(node:82834) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Connected to historyProvider: LocalHistoryProvider, dirpath ./cache
No previous bencharmk found for latestCommitInBranch 'main'

  Array iteration
    ✔ Regular test
    ✔ sum array with raw for loop                                         849.7938 ops/s    1.176756 ms/op        -       8683 runs   10.7 s
    ✔ sum array with reduce                                               170.7566 ops/s    5.856289 ms/op        -        127 runs   1.25 s
    ✔ sum array with reduce beforeEach                                    171.8360 ops/s    5.819502 ms/op        -        171 runs   1.56 s
    ✔ sum array with reduce before beforeEach                             175.4948 ops/s    5.698174 ms/op        -        220 runs   1.76 s
    - sum array with reduce
    ✔ sum array with reduce high threshold                                175.2783 ops/s    5.705213 ms/op        -        548 runs   3.63 s
    ✔ sum array with reduce no threshold                                  180.2968 ops/s    5.546410 ms/op        -        152 runs   1.35 s

  7 passing (20s)
  1 pending

✨  Done in 21.71s.

Would like to have green CI, do you have capacity to look into the permissions issue? I can make you mantainer too

Would like to have green CI, do you have capacity to look into the permissions issue? I can make you mantainer too

Sure that will be helpful to debug.

Closing in favor of https://github.com/dapplion/benchmark/pull/24


fix(LinearAlgebra/Dimension): make LinearMap.rank an abbrev

Previously, a statement like:
import Mathlib.LinearAlgebra.Dimension
import Mathlib.Tactic

variable {K : Type} [Field K]
variable {V W : Type} [AddCommGroup V] [AddCommGroup W] [Module K V] [Module K W]
variable {L : V →ₗ[K] W}

open LinearMap (ker)
open Module (rank)

example : rank K V = L.rank + rank K (ker L) := by
    sorry

required rewriting LinearMap.rank before manually finding the existence of rank_range_add_rank_ker.
After this change though, exact? successfully finds the lemma / solves the above.

Thanks!
bors merge


Fix bundle binstubs stanadlone flag

What was the end-user problem that led to this PR?
Currently, specifying the --standalone flag breaks bundler binstubs unless you have the path setting set in your bundle config. This is breaking in different ways but mostly for the same reason.
Bundler Master:
RuntimeError: Can't standalone without an explicit path set
  /Users/c/Desktop/Projects/bundler/lib/bundler/installer.rb:158:in `generate_standalone_bundler_executable_stubs'
  /Users/c/Desktop/Projects/bundler/lib/bundler/cli/binstubs.rb:36:in `block in run'
  /Users/c/Desktop/Projects/bundler/lib/bundler/cli/binstubs.rb:26:in `each'

Bundler 1.15.4:
TypeError: no implicit conversion of nil into String
  /Users/c/.rubies/ruby-2.4.1/lib/ruby/2.4.0/pathname.rb:409:in `initialize'
  /Users/c/.rubies/ruby-2.4.1/lib/ruby/2.4.0/pathname.rb:409:in `new'
  /Users/c/.rubies/ruby-2.4.1/lib/ruby/2.4.0/pathname.rb:409:in `join'
  /Users/c/.gem/ruby/2.4.1/gems/bundler-1.15.4/lib/bundler/installer.rb:142:in `generate_standalone_bundler_executable_stubs'

This was not caught in our tests because the --standalone flag was infact not being tested.
Another issue is that we have command options for the bundle binstubs command which are missing documentation in the man pages.
What was your diagnosis of the problem?
This error occurs when the path setting is not set which generate_standalone_bundler_executable_stubs expects to be set
What is your fix for the problem, implemented in this PR?
Set a temporary path setting in the binstubs command of either any currently set path setting or use Bundler.root instead.
Why did you choose this fix out of the possible options?
This was the most simplest solution that i can think of without having to change the standalone binstub generator.

Seems reasonable to me!
@bundlerbot r+


Refactor DiscoveryServer caches

We've met many panics caused by concurrent map r/w. So I abstract the cached resources in DiscoveryServer, to prevent missing lock in future.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
0ca0498ca01dfcc4dc223aee2190bb5ffc57536a
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
0ca0498ca01dfcc4dc223aee2190bb5ffc57536a
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
0ca0498ca01dfcc4dc223aee2190bb5ffc57536a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
0ca0498ca01dfcc4dc223aee2190bb5ffc57536a
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9df341f2f2dbb06f9987c1d0490ec4caaf9736b3
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
9df341f2f2dbb06f9987c1d0490ec4caaf9736b3
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
9df341f2f2dbb06f9987c1d0490ec4caaf9736b3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9df341f2f2dbb06f9987c1d0490ec4caaf9736b3
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9df341f2f2dbb06f9987c1d0490ec4caaf9736b3
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The eds part is a mess(lock abusing ), hard to refine the related code . I will have a deep analysis.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b56c5f74db80b08791fe180bc109d0823ebdc6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b56c5f74db80b08791fe180bc109d0823ebdc6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
61c2d87c410011a168eec8fa00666426e37f3fe2
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
a2b8da6b8a8cd9d4bf15968aeb354f02d50d2ca8
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
a73f9539902aa11e2be30b95b5cf98dcb24c2e5a
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
a73f9539902aa11e2be30b95b5cf98dcb24c2e5a
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
a73f9539902aa11e2be30b95b5cf98dcb24c2e5a
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Form refactoring

Changes

Add field group pattern – universal "container" for individual field items (i.e. label + input element). All spacing between field elements should be handled by "field groups" now, instead of having bottom-margins on individual elements.
Adds .-inline field group modifier for single-line forms (such as search fields, or filters).
Adds .-padded field group modifier for form elements within page layouts.
Refactors validation classes to prepare for decoupling this code in the future.
Remove unused short and medium modifiers on input fields.

For review: @DoSomething/front-end
Screenshots
Field Groups

:+1:


fix(gh-actions): handle virtual environments in python pre-commit test

What
Denis and Cristiam reported an issue while running the pytest pre-commit
Testing done

tested locally
tested in this GH action

Decisions made
We use bash to run multiple commands. We now require bash to be in the system
Checks

[ ] I have tested this code
[ ] I have reviewed my own PR
[ ] I have created an issue for this PR
[ ] I have set a descriptive PR title compliant with conventional commits

Reviewing tips
Please test in your local machine with
 pre-commit run backend-unit-pytest --all-files
User facing release notes
Fixed pre-commit pytest configuration for developers

closing in favor of https://github.com/yeagerai/genlayer-simulator/pull/525


Home Assistant automatic discovery needs updating

In the upcoming version of Home Assistant 0.84. the light .mqtt_json has been merged into light.mqtt.
For people with HA automatic discovery set the lights will not show until this is updated or they manually create the light.
https://rc--home-assistant-docs.netlify.com/blog/2018/12/06/release-84/
https://rc--home-assistant-docs.netlify.com/components/light.mqtt/

Thank you for pointing this out, so only thing that has changed is mqtt_json should be changed to mqtt? I'll add this change to develop version, could you check later today? Keep a lookout for a commit.

Could you try the develop branch out and check before we merge this into master. Haven't updated my HA yet to test this.

Hi Debsahu
I tried the new version (sorry for the delay) and we still have an error in Home assistant
"platform": "mqtt" is deprecated, replace with "schema":"basic"
i believe there is more to the new mqtt platford  (schema)
https://www.home-assistant.io/components/light.mqtt/#json-schema---configuration

I think that is just a warning, are you to control McLighting from HA. I have a patched up HA version with components that I upgraded manually, so can't test.
McLighting >2.1.9 version does indeed send that out unless the sketch also needs extra memory as required by ArduinoJSON v6.7.0. if you want to try, could you add + 1500 to 2 locations DynamicJsonDocument jsonBuffer(JSON_ARRAY_SIZE(strip.getModeCount()) + JSON_OBJECT_SIZE(12)); + 1500 in request_handlers.h

Hi debashu
tried updating as requested but error is still there. At the moment i agree it just a warning, but if the do deprecate in future the component may stop

But can you control McLighting from HA?

Hi Debashu
No the light doesnt appear in HA to be able to control it

Ok I upgraded mine and broke a few things! Upgrades shouldnt be this painful. So everything is ok on our end, it is just that HA is sending out commands not as json! Trying to figure this thing out. I'm working on it!

there is a breaking change in HA 0.84.
All mqtt lights are merged into mqtt (no more mqtt_json)
On Tue, 18 Dec 2018 at 14:03, Debashish Sahu<EMAIL_ADDRESS>wrote:

Ok I upgraded mine and broke a few things! Upgrades shouldnt be this
painful. So everything is ok on our end, it is just that HA is sending out
commands not as json! Trying to figure this thing out. I'm working on it!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/toblum/McLighting/issues/286#issuecomment-448084661,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEFh4E1PHK486ddjVY91AOH2KmSKP4I6ks5u6GH7gaJpZM4ZNGzL
.

yes we are tracking that change here, I followed what was adviced. added schema: "json" sent out to auto-discovery.
The master branch code sends the following to topic: homeassistant/light/McLighting01/config
{
   "name":"McLighting01",
   "platform":"mqtt",
   "schema":"json",
   "state_topic":"home/McLighting01_ha/state/out",
   "command_topic":"home/McLighting01_ha/state/in",
   "on_command_type":"first",
   "brightness":"true",
   "rgb":"true",
   "optimistic":"false",
   "color_temp":"true",
   "effect":"true",
   "effect_list":[
      "Static",
      "Blink",
      "Breath",
      "Color Wipe",
      "Color Wipe Inverse",
      "Color Wipe Reverse",
      "Color Wipe Reverse Inverse",
      "Color Wipe Random",
      "Random Color",
      "Single Dynamic",
      "Multi Dynamic",
      "Rainbow",
      "Rainbow Cycle",
      "Scan",
      "Dual Scan",
      "Fade",
      "Theater Chase",
      "Theater Chase Rainbow",
      "Running Lights",
      "Twinkle",
      "Twinkle Random",
      "Twinkle Fade",
      "Twinkle Fade Random",
      "Sparkle",
      "Flash Sparkle",
      "Hyper Sparkle",
      "Strobe",
      "Strobe Rainbow",
      "Multi Strobe",
      "Blink Rainbow",
      "Chase White"
   ]
}

Any advice would help.

Ok I upgraded mine and broke a few things! Upgrades shouldnt be this painful. So everything is ok on our end, it is just that HA is sending out commands not as json! Trying to figure this thing out. I'm working on it!

Yeah some fairly big breaking changes in last few updates. i think they are trying to get a lot of things in place so that upgrades can be less painful in future and also so people don't have to spend to much time editing files and things can be done from the UI. Yeah mate thanks for looking into this

Should be fixed in v1.1.11!

Confirmed working. Thanks Debsahu

Hi Debsahu.
Just found a possible bug.
Whilst the discovery now seems to work and the led is visible in the front end of HA and is controllable. i not the following in the HA error log when i restart the led device.
Error doing job: Exception in callback <bound method MQTT._mqtt_handle_message of <homeassistant.components.mqtt.MQTT object at 0x7fd6d4381518>>
it all seems to work, it just this error when a restart is performed


Global class link

Zeplin: https://app.zeplin.io/project/5bcd9657767a220982a4ab61/screen/5bcd968831bd7d099aae25c4

[x] link - global class.
[x] link-secondary - global class.
[ ] do a demo

On second thought, let's make link-secondary into a global class. Issue updated.


install without docker

install steps for without docker?
I use this for NPM https://github.com/ej52/proxmox-scripts/tree/main/apps/nginx-proxy-manager
whats the equivalent for NPMplus?

just use docker


Derivative

Working on derivative parsing.

Leibniz notation is going to be hard to handle within the parser.  I would suggest parsing d/dx x^2 as
{ type: 'Apply', op: 'mul', args: [
   { type: 'Apply': op: 'div', args: [d, dx] },
   { type: 'Apply': op: 'pow', args: [x, 2] },
]}

And then performing a transform on the AST that converts fractions that look like d/dx etc. to differentials.


Pharmacy fix checkincontroller

Coverage increased (+0.01%) to 33.133% when pulling f26571068c90ea72a09338c3e2b7648563e63042 on Guimino:pharmacy-fix-checkincontroller into c28afbef83c010d2877e9edacedbf714b2b82c1e on esaude:master.

Closing in favor of #274.


Persist options

First of all, love this reporter!
It would be nice if options (showPassed etc.) persisted using localStorage or sessionStorage. I could submit a PR if you think it's a good idea.

I think its an interesting idea. Are you looking to just persist options after a refresh or after a new test run? How would you identify one test report from another in local storage? Or are you thinking these would more like global options applied to all test reports?

I was thinking about making them global, that would be the most intuitive I think. But the test file name is a unique identifier that could be used to store options otherwise. And persistence should be after refreshing an existing test and running new tests.


Add class-defined scalar test case for SchemaExtenderTest

See #933

It seems like extending class-based scalar types does not work at all as of now, given the implementation of SchemaExtender: https://github.com/webonyx/graphql-php/blob/2abac8cdd9cdbc892dd09d05eae15b1431eb3b7c/src/Utils/SchemaExtender.php#L132-L143
The $config values do not exist in a class. How else could we extend it then? Perhaps using closures to reference the orginal scalar's methods?

I've implemented a fix using closures as you suggested and it doesn't appear to break any tests.  But at the same time, the testing for scalars is probably not compleate?  Only serialize() is really tested.

I've implemented a fix using closures as you suggested and it doesn't appear to break any tests. But at the same time, the testing for scalars is probably not compleate? Only serialize() is really tested.

I cut down the test case to be as minimal as possible and cover all three methods.


Add support for TLS in InfluxBD connector

As requested by email, implement support for TLS connection to a InfluxDB backend.

Shipped in f889be93015607ee139afdbb2aa36d2b1e40ad53.


Missing strings in Portuguese translation

Message when I adjust user permissions on Share plan page

Example Answer & Guidance on Templates page when creating questions

these strings are still appearing in English. it's not essential that we fix everything prior to release tomorrow. i'll keep this open to document any additional things i find (hope not).

status remains the same as my above comment @briri - if you can't find these strings no need to let them prevent today's release. but we do want to sort it out.

These have been addressed as part of the Roadmap PR: https://github.com/DMPRoadmap/roadmap/pull/2267


Rout exception on build

Reopen from Stacker issue:
I got this error using the latest released version and latest master version. Not exactly sure where to look to fix this issue. The same configuration and environment files worked two months ago.
[2017-09-17T12:09:25] INFO stacker.commands.stacker:32(configure): Using Default AWS Provider
[2017-09-17T12:09:25] DEBUG stacker.plan:288(outline): Plan "Create/Update stacks":
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 1: target: "vdt-dev-vpc", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 2: target: "vdt-dev-empireDB", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 3: target: "vdt-dev-empireController", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 4: target: "vdt-dev-bastion", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 5: target: "vdt-dev-empireMinion", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.plan:296(outline):   - step: 6: target: "vdt-dev-empireDaemon", action: "_launch_stack"
[2017-09-17T12:09:25] DEBUG stacker.actions.build:303(run): Launching stacks: vdt-dev-vpc, vdt-dev-empireDB, vdt-dev-empireController, vdt-dev-bastion, vdt-dev-empireMinion, vdt-dev-empireDaemon
[2017-09-17T12:09:25] INFO stacker.plan:358(_check_point): Plan Status:
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-vpc:              pending
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-empireDB:         pending
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-empireController: pending
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-bastion:          pending
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-empireMinion:     pending
[2017-09-17T12:09:25] INFO stacker.plan:380(_check_point): 	vdt-dev-empireDaemon:     pending
[2017-09-17T12:09:25] DEBUG stacker.util:58(retry_with_backoff): Calling <bound method CloudFormation.describe_stacks of <botocore.client.CloudFormation object at 0x103c193d0>>, attempt 1.
[2017-09-17T12:09:25] DEBUG stacker.actions.build:231(_launch_stack): Resolving stack vdt-dev-vpc
[2017-09-17T12:09:25] DEBUG stacker.actions.build:234(_launch_stack): Launching stack vdt-dev-vpc now.
[2017-09-17T12:09:25] DEBUG stacker.blueprints.base:448(import_mappings): Adding mapping AmiMap.
[2017-09-17T12:09:25] DEBUG stacker.blueprints.base:369(setup_parameters): No parameters defined.
Traceback (most recent call last):
File "/Users//dev/projects/viditure/vt_env/bin/stacker", line 4, in
import('pkg_resources').run_script('stacker==1.0.4', 'stacker')
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/pkg_resources/init.py", line 748, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/pkg_resources/init.py", line 1524, in run_script
exec(script_code, namespace, namespace)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/stacker-1.0.4-py2.7.egg/EGG-INFO/scripts/stacker", line 9, in
File "build/bdist.macosx-10.12-intel/egg/stacker/commands/stacker/build.py", line 52, in run
File "build/bdist.macosx-10.12-intel/egg/stacker/actions/base.py", line 127, in execute
File "build/bdist.macosx-10.12-intel/egg/stacker/actions/build.py", line 304, in run
File "build/bdist.macosx-10.12-intel/egg/stacker/plan.py", line 267, in execute
File "build/bdist.macosx-10.12-intel/egg/stacker/plan.py", line 227, in _single_run
File "build/bdist.macosx-10.12-intel/egg/stacker/plan.py", line 74, in run
File "build/bdist.macosx-10.12-intel/egg/stacker/actions/build.py", line 235, in _launch_stack
File "build/bdist.macosx-10.12-intel/egg/stacker/actions/base.py", line 101, in s3_stack_push
File "build/bdist.macosx-10.12-intel/egg/stacker/actions/base.py", line 25, in stack_template_key_name
File "build/bdist.macosx-10.12-intel/egg/stacker/blueprints/base.py", line 491, in version
File "build/bdist.macosx-10.12-intel/egg/stacker/blueprints/base.py", line 461, in render_template
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 609, in to_json
return json.dumps(self.to_dict(), indent=indent,
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 606, in to_dict
return encode_to_dict(t)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 63, in encode_to_dict
props[name] = encode_to_dict(prop)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 63, in encode_to_dict
props[name] = encode_to_dict(prop)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 54, in encode_to_dict
return encode_to_dict(obj.to_dict())
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/init.py", line 226, in to_dict
self.validate()
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/ec2.py", line 344, in validate
exactly_one(self.class.name, self.properties, gateway_conds)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/validators.py", line 201, in exactly_one
specified_count = mutually_exclusive(class_name, properties, conditionals)
File "/Users//dev/projects/viditure/vt_env/lib/python2.7/site-packages/troposphere-1.9.5-py2.7.egg/troposphere/validators.py", line 196, in mutually_exclusive
class_name, ', '.join(conditionals)))
ValueError: Route: only one of the following can be specified: EgressOnlyInternetGatewayId, GatewayId, InstanceId, NatGatewayId, NetworkInterfaceId, VpcPeeringConnectionId

I saw the same thing, the error is coming from the VPC blueprint, in this chunk of code.
`                    # Private subnets are where actual instances will live
# so their gateway needs to be through the nat instances
if variables["UseNatGateway"]:
instance_id = NOVALUE
nat_gateway_id = Ref(NAT_GATEWAY_NAME % name_suffix)
else:
instance_id = Ref(NAT_INSTANCE_NAME % name_suffix)
nat_gateway_id = NOVALUE
                t.add_resource(
                    ec2.Route(
                        route_name,
                        RouteTableId=Ref(route_table_name),
                        DestinationCidrBlock='<IP_ADDRESS>/0',
                        InstanceId=instance_id,
                        NatGatewayId=nat_gateway_id,
                    )
                )`

To get around it, I moved the route to be into the if/else. So if use natgateway, I built a route without the InstanceID, and vice versa.

Thanks @jseiser that workaround worked for me.

Thanks @jseiser - btw, PRs gladly accepted :) Hint hint!


chore(plugin-stripe): fixes broken link in README

The link to the ecommerce template was broken due to a typo.

Thanks @zaaakher!


Publish appium_flutter in maven repository

Hi @truongsinh I'm starting a PoC with Java using your code, but I had to build the Java Finder in my machine.
Do you have plans to publish this package on Maven ? I think this would make much easier for Java users to start using your library.

@andreroggeri There is no plan for now. But I will do it soon.

@jamesvanhorn For now you can do it but using the .jar found in the releases
https://github.com/appium-userland/appium-flutter-driver/releases

check Here
https://github.com/ashwithpoojary98/javaflutterfinder


TTS not working on Google Nest when audio is playing

What version of Music Assistant has the issue?
2.3.3
What version of the Home Assistant Integration have you got installed?
No response
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
When a google nest (mini or hub) is already playing music (for example from spotify), a TTS to that device isn't working.
I use the following script in one of my automations:
action: tts.google_cloud_say
data:
  cache: true
  entity_id: media_player.nest_mini_mass
  message: "{{message}}"
  language: de-DE

If media_player.nest_mini_mass is idle, TTS works.
If it's playing music, the below exception occurs and the script stops working.
If I use the home assistant media player instead of the one music assistant created, it works again.
Exception:
Error: CastMediaPlayerEntity.media_stop Failed: Execution of stop timed out after 10.0 s.
How to reproduce
Start music on a google nest player and try to call a TTS action on that device.
Music Providers
Spotify
Player Providers
Home Assistant MediaPlayers
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.12.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Add the full log entry as requested in the issue template.
I cannot recreate this with a Google Mini using  tts.google_say
Try without the language option. Try a different tts action. Try with other cast devices if you have them

I tried without the language option and also the action tts.speak with entity_id tts.home_assistant_cloud and tts.google_cloud. Same problem.
Unfortuntely I don't have other cast devices to try.

You need to fix the problems with Spotify before this can be looked at. Review the docs and get your own clientid

I have re-added the Spotify provider with 2 other (since we use 3 different accounts), all with a clientid. Same problem, log shows no new entries, except the known 2024-12-19 11:21:00.764 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: CastMediaPlayerEntity.media_stop Failed: Execution of stop timed out after 10.0 s.

 Try completely removing Spotify. Wait until you see an entry in the log that the removal is complete, then restart MA and then re-add the Spotify provider with your clientid

I'm sorry but I cannot see any problems with the clientid. The new log messages after re-adding the spotify account start with the log Removing provider spotify--ooeoYr2c. From there on the only error I got was when trying to play an announcement as I described earlier. Other than that I only see 4 warnings about the RadioBrowser which should be unrelated to my problem.

Then you have attached the wrong log above

It looks like I'm the only one with this problem.
I also still don't understand what an incomplete Spotify configuration has to do with the TTS functionallity. And since my attached log files don't seem to lead to any possible error analysis, I've now simply built a workaround:
In my automation, when the player is playing, I call the TTS action with the original entity and if not, I call it with the music assistant entity.
This is not really a solution to my problem, but at least the TTS and the subsequent actions in my automation work without interruption.
Thanks anyway for your effort.

I didn’t comment further as you never did attach the log file without all the Spotify errors. However, if you are satisfied with your workaround then ok.


Sign the aether assemblies with a strong name

Have you considered signing your assemblies with a strong name?
The problem with not signing your assemblies is that you alienate the inclusion of your library in a project that is strongly named. I can get around this temporarily, but I have to actually sign your dlls with my own key. This is a bit of a hassle, especially if I want to release my work as an open source project.

Hi @ptcoda - the short and honest answer is no I hadn't considered it 😄  - mainly because nobody has asked before! My impression had been that in general people had moved away from signing libraries (it's not something I've ever done) but I'm definitely willing to admit that I'm not an expert on the issues around it. I'll do a bit of background reading on it. If it can be non-disruptive and potentially just integrated in to the CI process, then i'm happy to do it if it's useful.

(If you've got any advice on the best way to do it, feel free to let me know too!)

I still believe there is value in signing assemblies, as it ensures the identity of your work (definitely not something that should be used for security purposes). Plus the added benefit of allowing your work to be used by everyone (both in open source and enterprise). Having an unsigned assembly is more restrictive.
I have noticed that you are building this project with Appveyor. The good news is that they provide you with the tools for handling private keys quite easily (I am doing this currently on a project that I have just started)

Generate your signing key by opening up a Visual Studio Command Prompt and then using the Strong Name tool, generate a private key as follows:
sn -k Aether.snk

With an F# project you will need to modify the AssemblyInfo.fs file to include a reference to the key. This reference is relative to the location of the fsproj file:
[<assembly: AssemblyKeyFileAttribute("../keys/Aether.snk")>]

As you will know, a private key should not be stored within your source control. So to get around this, appveyor has a Nuget package called secure-file. This allows you to encrypt the key with Rijandael encryption. The output, typically a .enc file should be stored in source control.
secure-file -encrypt Aether.snk -secret <passphrase>

Your passphrase needs to be added to your appveyor.yml file as a secure environment variable. Doing this is pretty straightforward, and is done directly on your project website. Follow this link for further instructions.

To get Appveyor to use this key. You need to customise your build script (or the appveyor.yml directly), to decrypt your key with your chosen passphrase. This key should be in the expected location, as defined within the AssemblyInfo.fs file in step 2:
secure-file -decrypt Aether.snk.enc -secret <passphrase>

If you need some further context, please have a look at my github project. It is not on the master branch, and is still a work in progress.
Hope this helps.

Thanks for the detailed feedback! I'll have a look into that and see how straightforward it would be to make my standard build work with that.

(There is another part of me which is beginning to remember some of the reasons i've never engaged with the process in the past though, often due to situations like this: https://jeremydmiller.com/2014/04/28/fubumvc-lessons-learned-strong-naming-woes-and-workarounds/ . What's the goal of signing/strong naming for you, with your assemblies? I'm interested in what you gain from it!)

Thanks for posting that link, was a good article to read. I will be honest, I never realised how controversial strong naming appears to be. My reasons for strong naming, is probably a little naive. I prefer to strong name, so that my assemblies are available to everyone. I guess it depends on what type of assembly you are creating, about whether it needs to be signed. I didn't quite realise the pain people experienced with binding redirects and strong named assemblies. I will have to say, that I must have been lucky, because I personally have never experienced it.
I guess the strategy by Newtonsoft Json is the best for signed assemblies and that is to lock down the version on the DLL and up version within Nuget only.
I will leave the decision to you. After having read that article, I can understand if you choose not to.

It is a tricky one. I've not had any problems without strong naming (that I know of) and so I'm leaning towards leaving things as is for now. I wonder whether you also might find life easier without signing too! I'm not sure it's gaining you anything (although the targets for your assemblies may be different from mine). If it would really help you to stick with signing and have various xyncro libraries also signed, I'd be open to setting up an alternative signing build and publishing those to a different feed - MyGet or similar perhaps. Although it would definitely need to be useful enough to justify it 😄

Thanks for the comments. I may give it a try with some of my work in future without signing and see what happens. I'll close the ticket
👍

No worries 👍  If you find a reason to come back and open this, feel free, I'm definitely open to arguments for doing so if it'll really help people!


VEText Push Notification Response Inadequate

Value Statement
Push notifications do not currently return a response, simply a result: 'success' and a code of 201.
While not a bug, this is not what we want to respond with. At a minimum we should be responding with VEText's response.
Long-term we should plan on a full notification, which seems to be generated with this. You can follow how sms notifications are generated to get there.
Checklist

[ ] Add logger for VEText response and other relevant logging events

Note: ensure logged response does not contain sensitive information

[ ] VEText Client updated with reponse return
[ ] Push endpoint returns response from vetext_client.send_push_notification
[ ] Unit tests updated
[ ] System/Integration/Functional tests planned with @Jake-Uhteg

Hey team! Please add your planning poker estimate with ZenHub @EvanParish @ianperera @jessecanderson @k-macmillan @kalbfled @maham360

Please add your planning poker estimate with ZenHub @Jake-Uhteg

Push is being completely reworked. This is no longer necessary.


Deleting a sprite in the Sprite Editor and adding a modified one by the same name shows the 'old' sprite

Details:
https://discord.com/channels/593735633130749972/593813232888578049/987293044262981643
Looks like a cache problem in the browser. Reloading the page seems to help.

To add to this, this also happens if you paste a sprite onto another.


Resizer not active on iOS Safari, but works fine on other mobile devices

Hi, I have the iframe resizer working very well (an awesome tool, thank you) on every browser I can test it on except safari on iOS.
The web page is here: https://www.breastcancercare.org.uk/sign-host-strawberry-tea
I've tested on up to date versions of Firefox/Chrome/Safari (mac), Firefrox/Chrome (windows), Chrome (Android), and Safari (iOS).
Any ideas? Can I do anything else to debug?

What’s the output from the console log look like?

On 22 Apr 2016, at 09:13, Tim<EMAIL_ADDRESS>wrote:
Hi, I have the iframe resizer working very well (an awesome tool, thank you) on every browser I can test it on except safari on iOS.
The web page is here: https://www.breastcancercare.org.uk/sign-host-strawberry-tea https://www.breastcancercare.org.uk/sign-host-strawberry-tea
I've tested on up to date versions of Firefox/Chrome/Safari (mac), Firefrox/Chrome (windows), Chrome (Android), and Safari (iOS).
Any ideas? Can I do anything else to debug?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/davidjbradshaw/iframe-resizer/issues/346

Hi David,
Thank you for the quick reply!
I have this error in the iphone log that I don't get anywhere else:
[Error] Failed to load resource: the server responded with a status of 404
(Not Found) (iframeResizer.contentWindow.map, line 0)
The link is set up correctly. I see the console recording touches on the
phone screen.
Screenshot:

Tim
On Fri, Apr 22, 2016 at 9:51 AM, David J. Bradshaw<EMAIL_ADDRESS>
wrote:

What’s the output from the console log look like?

On 22 Apr 2016, at 09:13, Tim<EMAIL_ADDRESS>wrote:
Hi, I have the iframe resizer working very well (an awesome tool, thank
you) on every browser I can test it on except safari on iOS.
The web page is here:
https://www.breastcancercare.org.uk/sign-host-strawberry-tea <
https://www.breastcancercare.org.uk/sign-host-strawberry-tea>
I've tested on up to date versions of Firefox/Chrome/Safari (mac),
Firefrox/Chrome (windows), Chrome (Android), and Safari (iOS).
Any ideas? Can I do anything else to debug?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub <
https://github.com/davidjbradshaw/iframe-resizer/issues/346>

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/346#issuecomment-213334913

Hi David,
This has fixed by accident. I had
.row .entry select {
width: auto;
}
in my CSS, replaced it with
.row .entry select {
width:100%;
}
and it's fixed. Not strictly sure why.
Thank you again for a great plugin.
TB

Thanks for the update.

On 22 Apr 2016, at 16:12, Tim<EMAIL_ADDRESS>wrote:
Closed #346 https://github.com/davidjbradshaw/iframe-resizer/issues/346.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/davidjbradshaw/iframe-resizer/issues/346#event-637836234


Join three tables on same column name

I just tried to upgrade to 0.3.0 and ran into the following issue:
We have 3 tables which all have the call_id column and I want to join them all together:
table output = (
  from hungup
  join side:left beginning [==call_id]
  join side:left accepted [==call_id]
  [...]
)

This now fails at the line join side:left accepted [==call_id] with the error Ambiguous reference. Could be from any of _frame.hungup.call_id, _frame.beginning.call_id.
Is this a bug or do I need to do something differently?

When running this in the playground, I don't see an error:
table output = (
  from hungup
  join side:left beginning [==call_id]
  join side:left accepted [==call_id]
)

from output

However, since 0.3.0, the compiler is indeed more strict in general around expecting you to be explicit when there's potential ambiguity – there's a difference between these two left joins:
accepted on beginning.call_id = accepted.call_id

and
accepted on hungup.call_id = accepted.call_id

You can satisfy the compiler by being more explicit:
table output = (
  from hungup
  join side:left beginning [hungup.call_id == beginning.call_id]
  join side:left accepted [hungup.call_id == accepted.call_id]
  [...]
)

Makes sense and works for me. Thanks for the help.

Yeah, this is a downside of not using USING (foo) any longer — instead we use ON x.foo = y.foo — but that means that multiple tables can't be joined without being explicit, since USING collapses them into one column, but ON doesn't.
I'll reopen this to see whether others have views. I was a fan of USING but maybe alone in that!

Given that we decide in favor of option 1 from #1193, this should error out.
As @mklopets pointed out there are 3 possible call_id columns which are not necessarily identical - because of side:left, some values in some of the columns may be null. So the distinction between them is important.
That said, maybe we need a better solution for multiple joins. Possibly via referring to the foreign key and using database schema to derive the table name and join filter.

Given that we decide in favor of option 1 from #1193, this should error out.

I'm not sure we've decided this yet! :) (Though nod to Do-ocracy...)

As @mklopets pointed out there are 3 possible call_id columns which are not necessarily identical - because of side:left, some values in some of the columns may be null. So the distinction between them is important.

Ah, this is a good point in this example given they are left-joins; I don't think there's a way around that. That might be difficult to encode in the compiler, though possible. Though in the case that that they are equi-joins; i.e.:
from hungup
join beginning [==call_id]
join accepted [==call_id]

...then we could use the same column, but I think it relies on using USING, which collapses the columns. The current result for this isn't valid, but the diff here would be:
SELECT
  hungup.*,
  beginning.*,
  accepted.*
FROM
  hungup
-  JOIN beginning ON hungup.call_id = beginning.call_id
-  JOIN accepted ON call_id = accepted.call_id
+  JOIN beginning USING (call_id)
+  JOIN accepted USING (call_id)

That said, maybe we need a better solution for multiple joins. Possibly via referring to the foreign key and using database schema to derive the table name and join filter.

Yes, many of these discussions end up with something like "If we knew the semantic model, we could know how to join the tables, at least in 90% of cases". I don't have a great visualization of what that would look like though, without a big jump in the language. I'm also reminded of https://github.com/prql/prql/issues/723 & https://github.com/prql/prql/issues/716

I meant:

In scenario when we decide in favor of option 1 from https://github.com/prql/prql/issues/1193, this should error out.

I regularly have to join 4 or 5 different tables and it's very important to me that the join syntax is as clean as possible.
In join syntax, what's most important to me is that column names are specified only once to reduce noise and mistakes/typos.
I'm happy with the current behaviour as described in #1335 (i.e. not generating USING), but I'd like to ask for syntax that makes it easy to reference the table that we just joined.
For example, something like this would be nice
from hungup
join beginning [==call_id]
join accepted [=={last,that}.call_id]

In the above example, last is referring to the table we just joined (accepted). (Yes last is a confusing name we can definitely come up with something better).
The benefit is apparent when you have a long chain of one-to-many relationship you need to join
from grandparent
join parent [==grandparent_id]
join child [=={last,that}.parent_id]
join grandchild [=={last,that}.child_id]

Now as a reader is only presented with the important information (table / column names) only once.

The issue with having concepts such as last is it makes the pipeline state much more complicated — we have to consider the order of the transforms that came before it, not just the result of the pipeline. The additional complication affects both the compiler and users — e.g. copying & pasting some lines isn't quite as reliable.
I agree something like that would make doing lots of joins easier, though.
Would using USING achieve that too though? At first glance, it seems that would condense these repeated joins too?

I believe that USING is very well specified in the standard (e.g. https://community.snowflake.com/s/question/0D50Z00008WRZBBSA5/bug-with-join-using-) and the coalesce behavior removes flexibility.

I believe that USING is very well specified in the standard

The accepted answer for the question you've linked to says that USING is not part of the ANSI standard and discouraged by Snowflake team. We've had a similar experience when trying to achieve the same behavior on different DBMSs.
In any case, we should be discussing "how PRQL does joins", not "how SQL does joins".
Current behavior is indeed pragmatic and tedious, there should be a better way to do it.

Current behavior is indeed pragmatic and tedious, there should be a better way to do it.

(typo? Or you mean it is pragmatic?)

The accepted answer for the question you've linked to says that USING is not part of the ANSI standard and discouraged by Snowflake team.

Interesting, good point.
I do think USING has solved so many of my JOIN issues through time, I've even structured my tables to work well with it (e.g. ensuring columns were named the same across tables). But I recognize our views differ, and I do update on the opinion from snowflake at that link.

I do think this is a difficult issue — we can either:

make it quite easy iff we know all the columns — i.e. a more complete version of USING
...but if we don't know all the columns, then we can't, since from a | join b (==x) | join c (==y) doesn't know where each column is[^1]

A language with them can be confusing, and it's rare we encounter them. So the current approach doesn't use the information that it often-but-not-always-has.
[^1]: this was an advantage of  USING — that the DB knows the columns!

Sorry @aljazerzen yes I meant NOT very well specified 😅 Edited


setup problem

Installed at https://mysite.com/pathfinder/
In environment.ini
BASE                        =   /pathfinder
URL                         =   https://mysite.com

In .htaccess
RewriteBase /pathfinder/
But:
setup link https://mysite.com/setup instead of https://mysite.com/pathfinder/setup
Sign Up link https://mysite.com/sso/requestAuthorization instead of https://mysite.com/pathfinder/sso/requestAuthorization
if i'am manualy go to https://mysite.com/pathfinder/setup
i see blank page and error in apache log
PHP Parse error:  syntax error, unexpected '(' in /var/www/pathfinder/app/main/lib/socket.php on line 47
47 string at socket.php    protected $ttl = ( self::DEFAULT_TTL_MAX / self::DEFAULT_RETRY_MAX );

Have you enabled AllowOverride All in your Apache settings, as mentioned in this comment?

I'm also having this issue, but with a fairly default setup. Hosted on local server,
Base is blank (default)
URL = http://(local-ip)
SSO works, The landing page works, but if I try to access http://(local-ip)/setup, I get a 500 error and in the error log it lists:
PHP Parse error:  syntax error, unexpected '(' in /var/www/html/app/main/lib/socket.php on line 47
Using PHP version 7.1.3, mysql version 14.14, on a Debian based system.
Thanks ahead for the help.

@glyyf The problem you have relates to this like:
protected $ttl = (self::DEFAULT_TTL_MAX / self::DEFAULT_RETRY_MAX);
Assigning Class member variables works in PHP 7.1 but not in older PHP versions (I think < 7.0).
You have 7.1.3, I have no problems with 7.1.2 and can not image this has changed :(
Please re-check your PHP version on /setup page.

@exodus4d
Yup, that was it, it was using PHP 5 for some reason.
For anybody working with the same issue, I am working of a debian based system, so I ran
sudo a2dismod php5.0
sudo a2enmod php7.1
and then restarted the server with sudo service apache2 restart
and it looks like we're good to go.
Thanks for your help!