Failure to find obj file on windows

When building from maven on Windows 10, the process gets pretty much to the end and then fails with the error
[Wed May 05 11:30:17 EDT 2021][INFO] Additional information: Objectfile should be called com.soartech.isaac.application.isaacmainapp.obj but we didn't find that under C:\Users\bob.marinier\git\isaac\isaac\isaac-ui\target\client\x86_64-windows\gvm

Here's the several lines before the error for context:
[Wed May 05 11:28:59 EDT 2021][INFO] [SUB] # Other libraries: version
[Wed May 05 11:28:59 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]   (typeflow):  29,239.39 ms,  6.57 GB
[Wed May 05 11:28:59 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]    (objects):  72,445.52 ms,  6.57 GB
[Wed May 05 11:28:59 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]   (features):   5,534.02 ms,  6.57 GB
[Wed May 05 11:28:59 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]     analysis: 113,261.59 ms,  6.57 GB
[Wed May 05 11:29:02 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]     universe:   2,851.84 ms,  6.57 GB
[Wed May 05 11:29:11 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]      (parse):   8,911.66 ms,  7.43 GB
[Wed May 05 11:29:26 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]     (inline):  14,379.52 ms,  8.45 GB
[Wed May 05 11:29:56 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]    (compile):  29,593.11 ms,  8.99 GB
[Wed May 05 11:29:59 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]      compile:  56,933.98 ms,  8.99 GB
[Wed May 05 11:30:15 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]        image:  15,668.02 ms,  6.63 GB
[Wed May 05 11:30:15 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]        write:     254.04 ms,  6.63 GB
[Wed May 05 11:30:15 EDT 2021][INFO] [SUB] # Printing build artifacts to: IsaacMainApp.build_artifacts.txt
[Wed May 05 11:30:15 EDT 2021][INFO] [SUB] [IsaacMainApp:15492]      [total]: 199,862.12 ms,  6.63 GB
[Wed May 05 11:30:17 EDT 2021][INFO] Additional information: Objectfile should be called com.soartech.isaac.application.isaacmainapp.obj but we didn't find that under C:\Users\bob.marinier\git\isaac\isaac\isaac-ui\target\client\x86_64-windows\gvm
[INFO] ------------------------------------------------------------------------
[Wed May 05 11:30:17 EDT 2021][SEVERE] Compiling failed.
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

GraalVM version: graalvm-svm-windows-gluon-21.1.0-dev
JavaFX version: 16
Client plugin version: 0.1.39
Attach version: 4.0.11
maven.compiler.release: 11
There is an IsaacMainApp.obj file in C:\Users\bob.marinier\git\isaac\isaac\isaac-ui\target\client\x86_64-windows\gvm\tmp\SVM-1620228421074, and if I copy and rename this to the expected location the build succeeds, but then the resulting executable does nothing (immediately exits with no output).

The issue appears to be that I was this line in my native-image.properties file: ImageName=IsaacMainApp. If I remove this line, then it builds successfully. This setting should work (it does when using graalvm's native image maven plugin).

The plugin doesn't expect a native-image.properties file. You are modifying the properties of the native-image directly but the plugin expects other values.


Update README.md

change realtime to real-time

Codecov Report

Merging #3110 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3110      +/-   ##
============================================
+ Coverage     70.08%   70.14%   +0.05%
  Complexity        4        4
============================================
  Files           936      936
  Lines         43493    43493
  Branches       5901     5901
============================================
+ Hits          30483    30506      +23
+ Misses        10958    10936      -22
+ Partials       2052     2051       -1

Impacted Files
Coverage Δ
Complexity Δ

.../impl/dictionary/FloatOnHeapMutableDictionary.java
80% <0%> (-13.34%)
0% <0%> (ø)

...impl/dictionary/FloatOffHeapMutableDictionary.java
81.81% <0%> (-7.28%)
0% <0%> (ø)

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
76.36% <0%> (-7.28%)
0% <0%> (ø)

...e/operator/dociditerators/MVScanDocIdIterator.java
63.63% <0%> (-3.04%)
0% <0%> (ø)

...com/linkedin/pinot/core/common/DataBlockCache.java
77.86% <0%> (-0.77%)
0% <0%> (ø)

.../broker/routing/HelixExternalViewBasedRouting.java
91.33% <0%> (-0.67%)
0% <0%> (ø)

...re/realtime/impl/kafka/KafkaConnectionHandler.java
74.05% <0%> (-0.64%)
0% <0%> (ø)

...regation/function/customobject/QuantileDigest.java
47.81% <0%> (-0.42%)
0% <0%> (ø)

...ot/common/protocols/SegmentCompletionProtocol.java
93.14% <0%> (+0.57%)
0% <0%> (ø)
:arrow_down:

...core/startree/operator/StarTreeFilterOperator.java
95.73% <0%> (+0.6%)
0% <0%> (ø)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655a9c5...0d323e6. Read the comment docs.


Very slow inference on video feed

Hi,
I saved the session using:
tf.saved_model.simple_save(tf_sess, "./save_dir/", inputs={"tf_input":tf_input}, outputs={"tf_scores":tf_scores, "tf_boxes":tf_boxes,"tf_classes":tf_classes})
And called the session again in a different script using:
tf.saved_model.loader.load(tf_sess, [tag_constants.SERVING], "./save_dir/")
When running,
scores, boxes, classes = tf_sess.run([tf_scores, tf_boxes, tf_classes], feed_dict={tf_input:image_resized[None, ...]})
I get in average around 4-5fps.
Is there any advice to run inference on a video feed to achieve the frame rate mentioned in the README?
Many thanks!
PS: I did run before doing inference /jetson_clocks and nvpmodel -m 0

Never mind, I changed the way the session was being called and it runs now at 15fps.

@hirovi How did you change it? I am having the same issue


Code for Figure 8 in the paper

Can you please share the code for Figure 8 in your paper about interpolation?
thanks

Hello @yaseryacoob,
Thanks for checking in. We will release the code/notebook within the next few days.
Meanwhile, it's very easy to implement, please refer to the below instructions:

Fix the seed for the prior and unet model.
Given all four combinations of subjects extract and save prior model output.
You can perform linear or spherical interpolations between these four embeddings from prior models.
Use UNet model to generate images corresponding to each interpolations.

Hello @yaseryacoob,
Thanks for waiting! Please find the corresponding interpolation script: interpolation.py
Best!


[Code Change] - Only login with credentials if old JWT has expired

The implementation currently is flawed as we're using the user credentials for sign in again and again when executing the script, this enforces rate limiting.
Ideally, the script should:

Login once with the user credentials
Store the JWT returned from the server into the config.json file

When the script is executed again, it should:

Use the old JWT for the requests from config.json
If that JWT has expired, try and request a new JWT from /uaa/auth/refresh-token endpoint
If that fails, then and only then, login with the user credentials

This should help with the rate limiting currently imposed on sign in attempts.

Hey, I will comment on this issue because I cannot found the JWT, and I can´t inject any document.cookie  for example on browser console

Hi, I could solver this problem, I don´t know how, but, I tried sometimes and it´worked just with email and password, I thought that problem it's because I didn't have JWT


section 3.4.1

667 removed the reference to the Vote token as a  "currency" from Time/UBI section + corrected typos
673 grammar edit so subject & predicate agree

too many changes on an older version of the text. unfortunately i can't merge this one.

I will resubmit - concerned that referring to the vote token explicitly as a currency in section 3.4.1.


mac force use external gpu

hi, I found that this app will force the use of mac Discrete gpu. Is there a way to ignore the use Discrete gpu

Hi :)
Thanks for the issue report.
Hmmm, I've done some research on my end, but no idea at this point.
As a matter of fact, I haven't written anything that uses the GPU in my implementation of Goneovim. However, it is possible that the library that Goneovim uses may contain code that uses the GPU.
What menu in MacOS did you refer to in the screenshot you provided?


feat: collection points integration

Codecov Report

Merging #8 (2c3eaae) into develop (018701c) will decrease coverage by 0.28%.
The diff coverage is 94.35%.

@@              Coverage Diff              @@
##             develop       #8      +/-   ##
=============================================
- Coverage      93.58%   93.30%   -0.29%
- Complexity        43       66      +23
=============================================
  Files             14       24      +10
  Lines            156      224      +68
  Branches          11       11
=============================================
+ Hits             146      209      +63
- Misses             4        9       +5
  Partials           6        6

Impacted Files
Coverage Δ

...ases/collectionpoint/GetCollectionPointsUseCase.kt
0.00% <0.00%> (ø)

...tlin/swc/usecases/dumpster/CloseDumpsterUseCase.kt
100.00% <ø> (ø)

...in/swc/usecases/dumpster/GetDumpsterByIdUseCase.kt
100.00% <ø> (ø)

...otlin/swc/usecases/dumpster/OpenDumpsterUseCase.kt
100.00% <ø> (ø)

...c/usecases/dumpster/UpdateDumpsterVolumeUseCase.kt
100.00% <ø> (ø)

src/main/kotlin/swc/controllers/AzureDTManager.kt
88.63% <88.63%> (ø)

...otlin/swc/adapters/CollectionPointsPresentation.kt
100.00% <100.00%> (ø)

...c/main/kotlin/swc/adapters/DumpsterPresentation.kt
100.00% <100.00%> (ø)

...tlin/swc/controllers/AzureDTRelationshipFactory.kt
100.00% <100.00%> (ø)

...rollers/errors/CollectionPointNotFoundException.kt
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018701c...2c3eaae. Read the comment docs.


eth_nxp_enet_qos_mac: enable pass through of multicasts

eth_nxp_enet_qos: enable the multicast packet pass through
for eth module implementation where there is no hash table
the patch sets the PERMIT_MULTICAST bit to let multicast packets
pass the hardware mac filtering
tested for MCXN947

Please force push to this PR instead of opening a new one each time.

Your commit need a description body, use git commit --amend and force push after.

Your commit need a description body, use git commit --amend and force push after.

thanks, that did the trick. Adib.


Add Dockerfile

-- Based on jupyter/base-notebook
-- Python3
-- Octave
-- SoS Kernel
-- plotly, numpy, scipy

Coverage remained the same at 41.696% when pulling 8e4c10b69a4ee20351fc69157b5601e380782011 on Dockerize into<PHONE_NUMBER>6672499c3e8d77a247ea136609b020 on master.


us-va-hanover

{
    "coverage": {
        "country": "us",
        "state": "va",
        "county": "Hanover"
    },
    "data": "http://www.hanovercountygis.org/Hanover/hanover/proxy.ashx?http://pc61198svmh/ArcGIS/rest/services/Hanover/Buildings/MapServer/0",
    "type": "ESRI",
    "website": "http://www.hanovercountygis.org/Hanover/hanover/"
}

ESRI dump error
TypeError: Uncaught, unspecified "error" event.
    at TypeError (<anonymous>)
    at Transform.emit (events.js:74:15)
    at Request._callback (/home/unknown/Developement/openaddresses/openaddresses-cache/node_modules/openaddresses-download/node_modules/esri-dump/index.js:41:24)
    at Request.self.callback (/home/unknown/Developement/openaddresses/openaddresses-cache/node_modules/openaddresses-download/node_modules/request/request.js:121:22)
    at Request.emit (events.js:98:17)
    at Request.<anonymous> (/home/unknown/Developement/openaddresses/openaddresses-cache/node_modules/openaddresses-download/node_modules/request/request.js:978:14)
    at Request.emit (events.js:117:20)
    at IncomingMessage.<anonymous> (/home/unknown/Developement/openaddresses/openaddresses-cache/node_modules/openaddresses-download/node_modules/request/request.js:929:12)
    at IncomingMessage.emit (events.js:117:20)
    at _stream_readable.js:929:16

Closing as stale - we have a statewide layer.


Add JSON as a runtime dependency

Ruby 1.9+ has it, but Ruby 1.8 installations generally don't by default.

see https://travis-ci.org/domcleal/puppet-dhcp/jobs/45684271

Thanks @domcleal.
Any idea why the few unit tests I wrote for rspec-puppet-facts worked with ruby 1.8.7?

@mcanevet it was already in the Gemfile so was getting installed by Travis for your tests.. the problem was when I added it to our puppet-* modules as there was no runtime dependency in the gem itself.


How do I load filtered data?

Please help me.
The following serialized data can be loaded with loadFromJSON()
{"objects":[{"type":"image","originX":"center","originY":"center","left":72.5,"top":91.5,"width":658,"height":982,"fill":"rgb(0,0,0)","stroke":null,"strokeWidth":0,"strokeDashArray":null,"strokeLineCap":"butt","strokeLineJoin":"miter","strokeMiterLimit":10,"scaleX":0.22,"scaleY":0.22,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"clipTo":null,"backgroundColor":"","fillRule":"nonzero","globalCompositeOperation":"source-over","transformMatrix":null,"skewX":0,"skewY":0,"crossOrigin":"","cropX":0,"cropY":0,"src":"https://ss1.bdstatic.com/70cFuXSh_Q1YnxGkpoWK1HF6hhy/it/u=361494400,3587695219&fm=27&gp=0.jpg","filters":[]}]}
but the following serialized data cannot be loaded with loadFromJSON()
{"objects":[{"type":"image","originX":"center","originY":"center","left":96.5,"top":186.5,"width":658,"height":982,"fill":"rgb(0,0,0)","stroke":null,"strokeWidth":0,"strokeDashArray":null,"strokeLineCap":"butt","strokeLineJoin":"miter","strokeMiterLimit":10,"scaleX":0.46,"scaleY":0.46,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"clipTo":null,"backgroundColor":"","fillRule":"nonzero","globalCompositeOperation":"source-over","transformMatrix":null,"skewX":0,"skewY":0,"crossOrigin":"","cropX":0,"cropY":0,"src":"https://ss1.bdstatic.com/70cFuXSh_Q1YnxGkpoWK1HF6hhy/it/u=361494400,3587695219&fm=27&gp=0.jpg","filters":[{"type":"Saturation","saturation":"0.913448"}]}]}
var canvas = new fabric.Canvas('c');
canvas.setWidth(500)
canvas.setHeight(500)

canvas.loadFromJSON('{"objects":[{"type":"image","originX":"center","originY":"center","left":96.5,"top":186.5,"width":658,"height":982,"fill":"rgb(0,0,0)","stroke":null,"strokeWidth":0,"strokeDashArray":null,"strokeLineCap":"butt","strokeLineJoin":"miter","strokeMiterLimit":10,"scaleX":0.46,"scaleY":0.46,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"clipTo":null,"backgroundColor":"","fillRule":"nonzero","globalCompositeOperation":"source-over","transformMatrix":null,"skewX":0,"skewY":0,"crossOrigin":"","cropX":0,"cropY":0,"src":"https://ss1.bdstatic.com/70cFuXSh_Q1YnxGkpoWK1HF6hhy/it/u=361494400,3587695219&fm=27&gp=0.jpg","filters":[{"type":"Saturation","saturation":"0.913448"}]}]}', canvas.renderAll.bind(canvas));

How do I load filtered data?

I found other ways to solve my project, but I still want to know the reason for this problem

What kind of problem does it give you ? not sure about it, but maybe you have to pass custom function to deal with 'filters' property, that is an empty array in the first example and an array of objects in the second example, and JSON stringify may be parsing it in an unexpected way for you.
what happens with ?
try {
 // your loadFromJSON()
} catch(err) { console.log(err) }


TestContainerInspectContainsPortConfig: support Docker 20.10.6

Close #182
Close #183

Vagrant CI failure is unrelated
Run vagrant up
Vagrant failed to initialize at a very early stage:

The "metadata.json" file for the box 'fedora/33-cloud-base' was not found.


Marathon 0.13 compatible with Mesos 0.26.0?

Mesos 0.26.0 was recently released, any idea if it is compatible with Marathon 0.13.0?
Based on the upgrade instructions it seems like it probably should, though it mentions some "compile time adjustments" might be required.

I've tested mesos 0.26.0 with marathon 0.13.0, everything seems to be fine.

I can also validate that mesos-0.26.0-0.2.145.centos701406.x86_64 & marathon-0.13.0-1.0.440.el7.x86_64 work wonderfully together. Make sure you have upto date patches, else you will see SASL auth issues.

@mindscratch unfortunately, we're not seeing that, see: https://github.com/mesosphere/marathon/issues/2870
They changed something related to tasks IPs with Docker containers.

@scalp42 Marathon v0.13.0 doesn't use the IP address in NetworkInfo for health checks, so it should still be compatible with Mesos 0.26.0.


chore: purge unconstrained + batch simulate improvements

Recovers work done by @LHerskind in https://github.com/AztecProtocol/aztec-packages/pull/5819 combining it with batched simulations to avoid 💀 ⏳ in tests

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,706
1,550
713 (+1%)
780
775 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,440
9,464
9,452

l1_rollup_execution_gas
616,081
616,105
616,093

l2_block_processing_time_in_ms
1,365 (+1%)
5,081 (-1%)
10,115

l2_block_building_time_in_ms
46,808 (+1%)
185,337
370,633

l2_block_rollup_simulation_time_in_ms
46,637 (+1%)
184,701
369,376

l2_block_public_tx_process_time_in_ms
25,014 (+1%)
104,268
213,456

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
10,028
15,318

node_database_size_in_bytes
14,471,248
21,356,624

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
protocol_circuit_simulation_time_in_ms
protocol_circuit_witness_generation_time_in_ms
protocol_circuit_proving_time_in_ms
protocol_circuit_input_size_in_bytes
protocol_circuit_output_size_in_bytes
protocol_circuit_proof_size_in_bytes
protocol_circuit_num_public_inputs
protocol_circuit_size_in_gates

private-kernel-init
159 (+1%)
3,665
22,077
19,990
61,798
86,720
2,643
1,048,576

private-kernel-inner
606 (+1%)
4,240
48,381
88,862
61,798
86,720
2,643
2,097,152

private-kernel-tail
531 (+1%)
2,847
35,499 (-1%)
86,653
76,130
10,624
265
2,097,152

base-parity
6.54 (-1%)
1,323 (+8%)
2,887
128
64.0
2,208
2.00
131,072

root-parity
49.8
62.4 (-1%)
43,708
27,084
64.0
2,720
18.0
2,097,152

base-rollup
770 (+1%)
2,325
73,961
119,578
756
3,648
47.0
4,194,304

root-rollup
115
65.5
19,333 (-1%)
25,297
620
3,456
41.0
1,048,576

public-kernel-app-logic
524 (+1%)
2,839 (-1%)
46,992 (-1%)
103,405
84,766
116,832
3,584
2,097,152

public-kernel-tail
1,188 (+1%)
23,802 (-7%)
160,197 (+3%)
393,850
7,490
10,624
265
8,388,608

private-kernel-reset-small
582 (+1%)
2,264 (+1%)
24,680 (-2%)
118,173
61,798
86,720
2,643
1,048,576

merge-rollup
28.8
N/A
N/A
16,534
756
N/A
N/A
N/A

public-kernel-setup
640 (+1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

public-kernel-teardown
540 (+1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
9,596 (-2%)
81,353 (-1%)
N/A
N/A
116,832
3,584
4,194,304

Stats on running time collected for app circuits

Function
app_circuit_proof_size_in_bytes
app_circuit_proving_time_in_ms
app_circuit_size_in_gates
app_circuit_num_public_inputs

SchnorrAccount:entrypoint
16,128
46,050
2,097,152
437

Token:transfer
16,128
43,165 (+1%)
2,097,152
437

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.4 (+1%)
18.5
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.663 (+1%)
0.568
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
52.7 (-1%)
82.5 (+2%)
262
509
992 (-1%)
1,961
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.539 (-1%)
0.509 (+2%)
0.476
0.474
0.470 (-1%)
0.469
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
62.8
120 (+1%)
380 (+1%)
745
1,473 (-1%)
2,935
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.545
0.539 (+1%)
0.517 (+1%)
0.512
0.510 (-1%)
0.510
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.1

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.596

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
82,348
664,768

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
11,114
4,217
57,476

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
3,207 (+1%)
2,146 (+1%)
6,210 (+2%)
2,308
2,609 (+1%)


Middle click closes the tab

Is your feature request related to a problem? Please describe.
When you middle click a tab in most things it will close the tab. It would be nice if storage explorer behaved the same.
Describe the solution you'd like
Mouse over tab. Middle Click. Tab is closed.
Describe alternatives you've considered
None
Additional context
Today middle click will "highlight" the tab. It's not clear what the highlight does.

This feature request has been implemented on the latest master build 20190715.7. So closed it.


Adding docker support

Adding docker support for easier setup and configuring of envs
Updating .gitignore to remove .env file tracking
Moving .env file to inside backend folder instead of backend/src

Sorry @bonadio , my bad. I hit the sync and pushed to main branch to the original remote, I will create a fork


Using RN CLI Exception

When copying the Project Driving to a fresh RN CLI project, i imported all the necessary packages and updated some files accordigly
but when executing it gives me a error :
You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of 'Welcome'
Any help will be appreciated

It's just a simple error, it is actually with your import statements, may be you haven't used { } to include the required component. Just show the code snippet of your import.

@Namec can you share with us any errors screenshots?

@alenthomas678 currently i haven't changed any export or import statement, just copy and paste from an Expo project to an RN Cli project
@hetmann the screenshot currently doesnt offer more information thant this message :
You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of 'Welcome'

Did you clone the project or just copy paste the code from github and inserted into the files in folders which you created your own. If that the case, you have messed up something within your files and they were not properly imported.

Currently i just copied the files, since Expo eject can lead to worst problems


[3.5] Crash in libc.so.6 called from mono_jit_init_version after Linux system updates

Godot version
3.5.stable, 3.6.beta2
System information
Fedora 38, Fedora 37 (inside podman with unchanged image)
Issue description
Recently I have started to see Godot crash very often when it tries to start on my Linux desktop (Fedora 38, Edit: there was a typo here). This makes debugging and testing a bit difficult but still doable if I try to start Godot many times. So this crash doesn't happen always, just more than half the time. The crashing started likely about 2 weeks ago when I last installed updates.
I was hoping that 3.6 wouldn't have the same problem, but I just tested it and it does also randomly crash when starting. So I'm reporting this issue in the hopes that this could be fixed before 3.6 is fully released.
I suspect that the problem is related to Linux system updates as just today our CI servers started having failed builds. They fail like this:
ERROR: Unable to open file: res://.import/default.png-0ecb64421bbeb83f3647ba16f0738ab3.stex.
   at: _load_data (scene/resources/texture.cpp:470)
ERROR: Failed loading resource: res://.import/default.png-0ecb64421bbeb83f3647ba16f0738ab3.stex. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:270)
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.5.stable.mono.official (991bb6ac74ac8c09d7683041b50a8ced3a2defb1)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib64/libc.so.6(+0x3cb50) [0x7f4b04ef6b50] ()
[2] godot() [0xf6d9a5] ()
[3] godot() [0xf5807f] ()
[4] godot() [0xf0d1e9] ()
[5] godot() [0xf52da8] ()
[6] godot(mono_jit_init_version+0xb) [0xeaa85b] ()
[7] GDMono::initialize() ()
[8] CSharpLanguage::init() ()
[9] ScriptServer::init_languages() ()
[10] Main::setup2(unsigned long) ()
[11] Main::setup(char const*, int, char**, bool) ()
[12] godot(main+0x2d) [0xe6b63d] ()
[13] /lib64/libc.so.6(+0x27510) [0x7f4b04ee1510] ()
[14] /lib64/libc.so.6(__libc_start_main+0x89) [0x7f4b04ee15c9] ()
[15] godot() [0xe6ef8e] ()
-- END OF BACKTRACE --
================================================================

The Godot process is ran inside podman with the exact same image that worked a few days ago. Also I disabled the build servers that were updated yesterday, and the servers that still haven't had latest updates (last updated a month ago) still build fine.
Steps to reproduce
Try to start Godot 3.5 or 3.6 beta 2 on an up to date Fedora system (probably some other distros will soon have new enough packages to have the same problem):
$ ./Godot_v3.6-beta2_mono_x11.64
Godot Engine v3.6.beta2.mono.official.68c507f59 - https://godotengine.org
OpenGL ES 3.0 Renderer: AMD Radeon Graphics (gfx1100, LLVM 16.0.1, DRM 3.49, 6.2.14-300.fc38.x86_64)
Async. shader compilation: OFF

Mono: Log file is: '/home/hhyyrylainen/.local/share/godot/mono/mono_logs/2023-05-26_10.15.38_2759507.log'

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x1009f9d - ./Godot_v3.6-beta2_mono_x11.64 :
	0x100a329 - ./Godot_v3.6-beta2_mono_x11.64 :
	0xffc9df - ./Godot_v3.6-beta2_mono_x11.64 :
	0x100d3ff - ./Godot_v3.6-beta2_mono_x11.64 :
	0x7f9d39702b70 - /lib64/libc.so.6 :
	0x102f3bb - ./Godot_v3.6-beta2_mono_x11.64 :
	0x10197bd - ./Godot_v3.6-beta2_mono_x11.64 :
	0x100ebc6 - ./Godot_v3.6-beta2_mono_x11.64 :
	0x114946f - ./Godot_v3.6-beta2_mono_x11.64 :
	0x114bfb0 - ./Godot_v3.6-beta2_mono_x11.64 :
	0x10841be - ./Godot_v3.6-beta2_mono_x11.64 :
	0x10169a9 - ./Godot_v3.6-beta2_mono_x11.64 :
	0xf6c98b - ./Godot_v3.6-beta2_mono_x11.64 : mono_jit_init_version
	0x14a6dbb - ./Godot_v3.6-beta2_mono_x11.64 : _ZN6GDMono10initializeEv
	0x1866272 - ./Godot_v3.6-beta2_mono_x11.64 : _ZN14CSharpLanguage4initEv
	0x3b610ef - ./Godot_v3.6-beta2_mono_x11.64 : _ZN12ScriptServer14init_languagesEv
	0x1280130 - ./Godot_v3.6-beta2_mono_x11.64 : _ZN4Main6setup2Em
	0x128584e - ./Godot_v3.6-beta2_mono_x11.64 : _ZN4Main5setupEPKciPPcb
	0xf2bf47 - ./Godot_v3.6-beta2_mono_x11.64 : main
	0x7f9d396ecb4a - /lib64/libc.so.6 :
	0x7f9d396ecc0b - /lib64/libc.so.6 : __libc_start_main
	0xf310be - ./Godot_v3.6-beta2_mono_x11.64 :

=================================================================
	Telemetry Dumper:
=================================================================
No threads attached to runtime.

=================================================================
	External Debugger Dump:
=================================================================
[New LWP 2759508]
[New LWP 2759521]
[New LWP 2759522]
[New LWP 2759523]
[New LWP 2759524]
[New LWP 2759525]
[New LWP 2759526]
[New LWP 2759527]
[New LWP 2759528]
[New LWP 2759529]
[New LWP 2759530]
[New LWP 2759531]
[New LWP 2759532]

This GDB supports auto-downloading debuginfo from the following URLs:
  <https://debuginfod.fedoraproject.org/>
Enable debuginfod for this session? (y or [n]) [answered N; input not from terminal]
Debuginfod has been disabled.
To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
0x00007f9d3979fc73 in wait4 () from /lib64/libc.so.6
  Id   Target Id                                             Frame
* 1    Thread 0x7f9d3959dc00 (LWP 2759507) "Godot_v3.6-beta" 0x00007f9d3979fc73 in wait4 () from /lib64/libc.so.6
  2    Thread 0x7f9d2bb7e6c0 (LWP 2759508) "Godot_v3.6-beta" 0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  3    Thread 0x7f9d219ff6c0 (LWP 2759521) "Godot_v3.6:cs0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  4    Thread 0x7f9d211fe6c0 (LWP 2759522) "Godot_v:disk$0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  5    Thread 0x7f9d209fd6c0 (LWP 2759523) "Godot_v3.6:sh0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  6    Thread 0x7f9d1bfff6c0 (LWP 2759524) "Godot_v3:shlo0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  7    Thread 0x7f9d1b3fe6c0 (LWP 2759525) "Godot_v3:gdrv0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  8    Thread 0x7f9d1abfd6c0 (LWP 2759526) "Godot_v3:gdrv0"  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  9    Thread 0x7f9d1a1fc6c0 (LWP 2759527) "Godot_v3.6-beta" 0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
  10   Thread 0x7f9cfffff6c0 (LWP 2759528) "Godot_v3.6-beta" 0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
  11   Thread 0x7f9cff7fe6c0 (LWP 2759529) "Godot_v3.6-beta" 0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
  12   Thread 0x7f9cfeffd6c0 (LWP 2759530) "Godot_v3.6-beta" 0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
  13   Thread 0x7f9cfe7fc6c0 (LWP 2759531) "Godot_v3.6-beta" 0x00007f9d397ccb77 in select () from /lib64/libc.so.6
  14   Thread 0x7f9cfd7ff6c0 (LWP 2759532) "SGen worker"     0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6

Thread 14 (Thread 0x7f9cfd7ff6c0 (LWP 2759532) "SGen worker"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00000000011fa5db in ?? ()
#3  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#4  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 13 (Thread 0x7f9cfe7fc6c0 (LWP 2759531) "Godot_v3.6-beta"):
#0  0x00007f9d397ccb77 in select () from /lib64/libc.so.6
#1  0x000000000125637a in OS_X11::_wait_for_events() const ()
#2  0x00000000012564f5 in OS_X11::_poll_events_thread(void*) ()
#3  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#4  0x00000000041312b0 in ?? ()
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 12 (Thread 0x7f9cfeffd6c0 (LWP 2759530) "Godot_v3.6-beta"):
#0  0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
#1  0x00007f9d3979feb7 in nanosleep () from /lib64/libc.so.6
#2  0x00007f9d397cd48c in usleep () from /lib64/libc.so.6
#3  0x0000000001252d2d in JoypadLinux::joypad_events_thread_run() ()
#4  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#5  0x00000000041312b0 in ?? ()
#6  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#7  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 11 (Thread 0x7f9cff7fe6c0 (LWP 2759529) "Godot_v3.6-beta"):
#0  0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
#1  0x00007f9d3979feb7 in nanosleep () from /lib64/libc.so.6
#2  0x00007f9d397cd48c in usleep () from /lib64/libc.so.6
#3  0x000000000125bb12 in JoypadLinux::monitor_joypads(udev*) ()
#4  0x000000000125bd83 in JoypadLinux::monitor_joypads_thread_run() ()
#5  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#6  0x00000000041312b0 in ?? ()
#7  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#8  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 10 (Thread 0x7f9cfffff6c0 (LWP 2759528) "Godot_v3.6-beta"):
#0  0x00007f9d3979b413 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
#1  0x00007f9d3979feb7 in nanosleep () from /lib64/libc.so.6
#2  0x0000000003f72868 in ?? ()
#3  0x0000000001f4c61b in AudioDriverPulseAudio::thread_func(void*) ()
#4  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#5  0x00000000041312b0 in ?? ()
#6  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#7  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 9 (Thread 0x7f9d1a1fc6c0 (LWP 2759527) "Godot_v3.6-beta"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00000000040c74dc in std::condition_variable::wait(std::unique_lock<std::mutex>&) ()
#3  0x00000000037cc2bb in VisualServerScene::_gi_probe_bake_thread() ()
#4  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#5  0x00000000041312b0 in ?? ()
#6  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#7  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 8 (Thread 0x7f9d1abfd6c0 (LWP 2759526) "Godot_v3:gdrv0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 7 (Thread 0x7f9d1b3fe6c0 (LWP 2759525) "Godot_v3:gdrv0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 6 (Thread 0x7f9d1bfff6c0 (LWP 2759524) "Godot_v3:shlo0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 5 (Thread 0x7f9d209fd6c0 (LWP 2759523) "Godot_v3.6:sh0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 4 (Thread 0x7f9d211fe6c0 (LWP 2759522) "Godot_v:disk$0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 3 (Thread 0x7f9d219ff6c0 (LWP 2759521) "Godot_v3.6:cs0"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00007f9d295113fd in cnd_wait () from /usr/lib64/dri/radeonsi_dri.so
#3  0x00007f9d294c05bb in util_queue_thread_func () from /usr/lib64/dri/radeonsi_dri.so
#4  0x00007f9d2951132c in impl_thrd_routine () from /usr/lib64/dri/radeonsi_dri.so
#5  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#6  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 2 (Thread 0x7f9d2bb7e6c0 (LWP 2759508) "Godot_v3.6-beta"):
#0  0x00007f9d3974e1d9 in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007f9d39750b79 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00000000040c74dc in std::condition_variable::wait(std::unique_lock<std::mutex>&) ()
#3  0x0000000003d17aab in _IP_ResolverPrivate::_thread_function(void*) ()
#4  0x0000000003c1f3c8 in Thread::callback(Thread*, Thread::Settings const&, void (*)(void*), void*) ()
#5  0x00000000041312b0 in ?? ()
#6  0x00007f9d39751907 in start_thread () from /lib64/libc.so.6
#7  0x00007f9d397d7870 in clone3 () from /lib64/libc.so.6

Thread 1 (Thread 0x7f9d3959dc00 (LWP 2759507) "Godot_v3.6-beta"):
#0  0x00007f9d3979fc73 in wait4 () from /lib64/libc.so.6
#1  0x000000000100a22a in ?? ()
#2  0x000000000100a329 in ?? ()
#3  0x0000000000ffc9df in ?? ()
#4  0x000000000100d3ff in ?? ()
#5  <signal handler called>
#6  0x000000000102f3bb in ?? ()
#7  0x00000000010197bd in ?? ()
#8  0x000000000100ebc6 in ?? ()
#9  0x000000000114946f in ?? ()
#10 0x000000000114bfb0 in ?? ()
#11 0x00000000010841be in ?? ()
#12 0x00000000010169a9 in ?? ()
#13 0x0000000000f6c98b in mono_jit_init_version ()
#14 0x00000000014a6dbb in GDMono::initialize() ()
#15 0x0000000001866272 in CSharpLanguage::init() ()
#16 0x0000000003b610ef in ScriptServer::init_languages() ()
#17 0x0000000001280130 in Main::setup2(unsigned long) ()
#18 0x000000000128584e in Main::setup(char const*, int, char**, bool) ()
#19 0x0000000000f2bf47 in main ()
[Inferior 1 (process 2759507) detached]

=================================================================
	Basic Fault Address Reporting
=================================================================
Memory around native instruction pointer (0x102f3bb):0x102f3ab  83 c2 01 48 83 fa 01 0f 87 b5 00 00 00 83 e8 05  ...H............
0x102f3bb  41 c6 04 24 e8 41 89 44 24 01 48 85 db 74 56 41  A..$.A.D$.H..tVA
0x102f3cb  c6 44 24 05 08 4d 89 6c 24 06 4d 8d 6c 24 0e 4d  .D$..M.l$.M.l$.M
0x102f3db  29 e5 48 63 c5 49 39 c5 7f 53 4d 85 ff 74 03 41  ).Hc.I9..SM..t.A
Keskeytetty (luotiin core-tiedosto)

Note that the problem doesn't trigger each time, but for me it triggers often enough for it not to take more than 30 seconds of just continually trying to open Godot to see it crash at least once.
Minimal reproduction project
No project required, the Godot Editor itself can crash when opening.

Thanks for the detailed report. I hadn't tried the Mono build recently, but just did on my distro (Mageia 9, development release fairly up to date on packages) and I can reproduce the crash too.
Running kernel 6.3.3-desktop-1.mga9 and glibc-2.36-40.mga9. I'll get a stacktrace.

This bug sounds related: https://github.com/mono/mono/issues/21651
There's a patch available, I'll give it a try.

I've confirmed that the patch from https://github.com/mono/mono/issues/21651 fixes the issue, with this test build of Mono: https://github.com/godotengine/godot-mono-builds/actions/runs/5089774213
I made a minor fix to that test and started a new build which should be available as a GitHub Release in a few hours: https://github.com/godotengine/godot-mono-builds
(Same as the artifacts from the above build, just with a cleaner commit history.)
I'll use this build for the next 3.5 and 3.6 builds, possibly fast-tracking a 3.5.3 release to make that fix readily available.
It's a regression in the Linux kernel which should hopefully be patched soon, and thus this Mono workaround wouldn't be needed, but I don't know the ETA for the kernel fix to make it to a stable branch, and whether it will be backported to 6.1, 6.2 and 6.3.

The upstream regression is fixed in kernel 6.1.30 and 6.3.4.
6.2 seems to have gone EOL before this could be backported, so it will stay vulnerable, but most distros should upgrade to 6.3 since 6.2 isn't an EOL.
So this can likely be considered fixed, without me needing to actually use the mono workaround. I'll keep this issue open for now so users can have visibility over this if they're still on a kernel with the regression.


Swedish Translation Fix

Grammatical, spelling and consistency error fixed.

Please send the pull request to the github branch. That way it will be easier to someday merge it back.
Sorry for the inconvenience.


Adding worker's configuration to support export batch time shift.

/assign @sethvargo

I'm open to suggestions of a better name for this configuration parameter.

/test all

/test all

/retest


How to avoid trigger when input Non-English languages

Thank you for this awesome plugin, I love it when input English words.
But I have an issue when inputting Chinese.
Here, it will also suggest the English words:

Hi, @chenyukang!
I understood what you bother to because I think so many times while inputting Japanese with IME. So I am trying to add a new option, Disable suggestions during IME On. Would it be possible to resolve your issue?
Before (current version)
https://user-images.githubusercontent.com/9500018/143461975-79777fa6-e030-4053-bbdd-7ee5e17eb565.mp4
After (The version I am trying to)
https://user-images.githubusercontent.com/9500018/143462206-8409f71b-1c4c-4546-a9f4-69c20b4ac08a.mp4
I don't know which works correctly with your IME, but it probably works :)

Hi, @chenyukang!
I understood what you bother to because I think so many times while inputting Japanese with IME. So I am trying to add a new option, Disable suggestions during IME On. Would it be possible to resolve your issue?
Before (current version)
2021-11-25_23h47_18.mp4
After (The version I am trying to)
2021-11-25_23h49_01.mp4
I don't know which works correctly with your IME, but it probably works :)

Thanks for reply!
If you have pre-release version for testing, I would like to have a try. 😊

Btw, I guess most users in Windows use Microsoft Input.

@chenyukang
I have uploaded pre-release version 🚀
If you use BRAT, you can install it from tadashi-aikawa/obsidian-plugin-dev-sandbox. It includes some breaking changes because it corresponds to v3.0.0. You can see what changes are at https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/issues/28.
Best regards.

@chenyukang I have uploaded pre-release version 🚀
If you use BRAT, you can install it from tadashi-aikawa/obsidian-plugin-dev-sandbox. It includes some breaking changes because it corresponds to v3.0.0. You can see what changes are at #28.
Best regards.

Confirmed it works perfectly, and we can also complete links now, awesome!
Thanks for your contribution. 🙌

Btw, do you have any better English dictionary files to config my dictionary.

I tried this words for complete, but it seems too big, it will hang up the plugin.
https://raw.githubusercontent.com/dwyl/english-words/master/words.txt

The above dictionary works perfect.
But I found another improvement we may implement.
For instance, we have 'banana' in dictionary,

but if I will type this word in the beginning of a sentence, I will type "Ba", but it will not complete, I guess ignore uppercase will be better:

Thank you for your reply!

Confirmed it works perfectly

Glad to hear that 😄

do you have any better English dictionary files to config my dictionary.

Sorry, I have no idea because I don't use the custom dictionary feature.. 😅

but if I will type this word in the beginning of a sentence, I will type "Ba", but it will not complete, I guess ignore uppercase will be better:

That is very interesting :) Would you create another issue?

Done 97d772877b224dbcf4d50b25482716acd6e44c1e


Specialized CritterStackHostBuilder to simplify Marten & Wolverine usage

This is a placeholder for a longer conversation. There's starting to be more and more boilerplate code for bootstrapping both a headless application or a web application with both Wolverine and Marten -- plus the overhead of registering "do this in development" vs "do this in production mode".
I'd like to maybe consider some kind of customized ApplicationHostBuilder and/or WebHostBuilder that's a bit customized for using the two tools. I'd like to drop the WolverineOptions and Marten's StoreOptions on the actual builder too. Maybe separate "hive" properties for Development vs Production.
I'm also concerned about some of the dev vs prod settings like codegen or the application assembly location where both tools have the same settings. It would be nice to centralize some of that as well.
Of course, this could be beaten with just a new AddCritterStack(opts => ) where the opts let you configure both Marten & Wolverine at one time.
I kind of like a var builder = CritterStackHost.CreateApplicationBuilder() and/or a var builder = CritterStackWebHost.****()

I think this is getting kicked back to Marten 8 / Wolverine 4

I've been looking into it and wow they do not make it easy to create a Host Builder. Making a super opinionated one like you are suggesting here would be doable, but how well it would play with other things people might want to poke into it looks sketchy.
I think an extension of AddCritterStack(opts =>) like you suggested is probably the best, but that opts is what'll be challenging. Unless it keeps growing, eventually they'll want to bail and do it old-skool, and I feel like at that point even having a "default" builder for the WolverineOptions and StoreOptions (that they could override) would make me nervous because those could change underneath me.
One sorta big advantage of a custom host builder is it could "hide" the Oakton stuff. From the people I show and from the number of people that don't know about that, mess it up, etc. it would be good if that could be made more implicit.
I'm working on that template thing - I'm going to iterate a bit more on it. If nothing else, it will help answer the important question explicit in this issue - which is something like "What is a reasonable default configuration for a full-tilt CritterStack application?". I love the idea of having a "batteries included" template or something that is way less than any kind of "reference app", but it would have to be "tweakable" as your needs change and understanding grows.

I feel like the AddCriterStack method is more consistent with how other projects work and is easier to understand. If an org already has their own HostBuilder they create in-house, it would be a pain to try and balance both (at least I assume, I have not looked into how HostBuilder works internally).
Unifying things would be good for us around type loading and serializer. I worry a bit about assembly discovery as someone may want to discover something for Marten but not Wolverine (not sure what, I just feel like this may be something someone wants to do)

Here's an early take on this for Wolverine 4 / Marten 8 / Ermine 1:
        var builder = Host.CreateApplicationBuilder();

        // This would apply to both Marten, Wolverine, and future critters....
        builder.Services.JasperFxDefaults(x =>
        {
            // This expands in importance to be the master "AutoCreate"
            // over every resource at runtime and not just databases
            // So this would maybe take the place of AutoProvision() in Wolverine world too
            x.Production.AutoCreate = AutoCreate.None;
            x.Production.GeneratedCodeMode = TypeLoadMode.Static;
            x.Production.AssertAllPreGeneratedTypesExist = true;

            // Just for completeness sake
            x.Development.AutoCreate = AutoCreate.All; // default is still CreateOrUpdate

            // Unify the Marten/Wolverine/future critter application assembly
            // Default will always be the entry assembly
            x.ApplicationAssembly = typeof(Message1).Assembly;
        });

        // keep bootstrapping...

I'm closing this for now just because Wolverine 4 is a ways away. There is a unified model in jasperfx for common options that was meant for this.


go-sqlite3 doesn't set sql.ColumnType.DatabaseTypeName() when query contains MAX(column_name)

Hi,
I have written a test in my Go ORM, github.com/rbastic/dyndao, to show that SQLite has a flaw in DatabaseTypeName handling when a query contains a MAX() function:
https://github.com/rbastic/dyndao/commit/02d053c5c55c574e7635131b7521d922c90328ad
If you change line 393 to read SELECT %s instead of SELECT MAX(%s) you will see that wrapping a column name with a SQL function call will break the ORM.
Is it possible to fix this? This works in other database drivers (MySQL, Oracle, and Postgres, from what I just checked.)
rbastic@marvin:~/go-src/src/github.com/rbastic/dyndao/adapters/sqlite$ DB_TRACE=1 make test
[....output snipped....]
=== RUN   TestMain/MaxWhereQuery
panic: dyndao GenColumnPointers: ct.DatabaseTypeName() does not appear to be implemented - typeName was an empty string [recovered]
panic: dyndao GenColumnPointers: ct.DatabaseTypeName() does not appear to be implemented - typeName was an empty string
goroutine 7 [running]:
testing.tRunner.func1(0xc4203a8000)
/home/rbastic/go1.10/src/testing/testing.go:742 +0x29d
panic(0x821180, 0x904190)
/home/rbastic/go1.10/src/runtime/panic.go:505 +0x229
github.com/rbastic/dyndao/adapters/sqlite.MakeColumnPointers(0xc420073680, 0xc4200aa2c0, 0xc420025de0, 0x1, 0x1, 0xc42000e040, 0x1, 0x1, 0x0, 0x4c71c9, ...)
/home/rbastic/go-src/src/github.com/rbastic/dyndao/adapters/sqlite/bind.go:186 +0x858
github.com/rbastic/dyndao/orm.(*ORM).RetrieveManyWithSQLTx(0xc420094820, 0x908c60, 0xc420138780, 0x0, 0x8a9c5b, 0x6, 0xc420014420, 0x2f, 0xc420025de0, 0x1, ...)
/home/rbastic/go-src/src/github.com/rbastic/dyndao/orm/retrieve.go:247 +0x542
github.com/rbastic/dyndao/orm.(*ORM).RetrieveManyWithSQL(0xc420094820, 0x908c60, 0xc420138780, 0x8a9c5b, 0x6, 0xc420014420, 0x2f, 0xc420025de0, 0x1, 0x1, ...)
/home/rbastic/go-src/src/github.com/rbastic/dyndao/orm/retrieve.go:195 +0xe5
github.com/rbastic/dyndao/adapters/core/test.testMaxWhereQueryBug(0xc420094820, 0xc4203a8000)
/home/rbastic/go-src/src/github.com/rbastic/dyndao/adapters/core/test/test.go:398 +0x412
github.com/rbastic/dyndao/adapters/core/test.TestSuiteNested.func17(0xc4203a8000)
/home/rbastic/go-src/src/github.com/rbastic

What do you expect? SQLite3 return typeof("") as text.

no worries. it's the fault of my orm's design. i bypassed it by querying directly with database/sql.
thanks.


Reduce the pre-image flood

We previously took a rather aggressive approach to pre-image
propagation, which leads to a lot of unnecessary traffic. So
We check that the pre-images to be sent are already posted in
order to prevent the too heavy traffic.
Fixes #2356

Ready for review with all green.

Test is lacking

Thanks for the review. I will make a unit test more proper. Anyway, do you think this approach is right?

Yes

I think it would be better to check the exact number of posts.
I don't think it's meaningful because I found that the number of posts could be changed with just a little change in the environment, like some unintended delay based on machines on which it tested.

Also, the test you previously had for pre-image catchup is maybe worth adding back as a commit if it is not already covered by another test.
I agree with you. Will add it again.

Applied suggestions to the code.


IBES

Hi this is awesome! Keep going, and quick question, are you interested in partnering with someone with IBES access it would bring it closer in line with this R package https://github.com/OpenSourceAP/CrossSection

Hi,
Thank you for your interest in pyanomaly. I do have access to IBES and plan to add firm characteristics that use IBES data. However, IBES data have a rather short history and it's not the top priority. Hopefully, it doesn't take too long though. You're also welcome to contribute to the library!


⚠ RPC server - Binance BSCT has degraded performance

In 8226be7, RPC server - Binance BSCT ($BINANCE_BSCT_RPC_URL) experienced degraded performance:

HTTP code: 504
Response time: 10600 ms

Resolved: RPC server - Binance BSCT performance has improved in 38525b8.


Allow HyperLogLog where T: !Sized

This is useful for cases like HyperLogLog<[u8]> where the [u8] slice doesn't outlive the HyperLogLog (so you can't use HyperLogLog<&[u8]>).

example usage:
let mut h: HyperLogLog<[u8]> = HyperLogLog::new(4);
{
    let v = vec![0; 64];
    h.add(&v);
}
// `h` is still usable after `v` is dropped:
let n = h.count();

Ah, sorry for the extremely late review. This PR kinda slipped through my notifications.
Can you please add a test for the vec case and the extend implementation?

Added tests.

bors r+

Thanks a lot :)


Remove Docker proxy.

With these changes, which remove a large amount of code, the collector talks only to the Kubernetes API, and not to Docker.
There is a bit of new code to synthesize container and image graph nodes from the pod resources returned by the Kubernetes API.
See the enclosed commits for the details.

Minor inconsistency in one of the commits due to a missing file. But otherwise looks good. Merging this PR.

Thank you!


Fixes DistictIterator to not eat null values

Fixes #2425

Codecov Report

Merging #2426 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #2426      +/-   ##
===========================================
+ Coverage     95.89%   95.9%   +<.01%
  Complexity     5479    5479
===========================================
  Files            94      94
  Lines         13340   13344       +4
  Branches       1612    1612
===========================================
+ Hits          12793   12797       +4
  Misses          408     408
  Partials        139     139

Impacted Files
Coverage Δ
Complexity Δ

...avr/src/main/java/io/vavr/collection/Iterator.java
99.23% <100%> (ø)
182 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1243c...6eb08a8. Read the comment docs.

Codecov Report

Merging #2426 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #2426      +/-   ##
===========================================
+ Coverage     95.89%   95.9%   +<.01%
  Complexity     5479    5479
===========================================
  Files            94      94
  Lines         13340   13344       +4
  Branches       1612    1612
===========================================
+ Hits          12793   12797       +4
  Misses          408     408
  Partials        139     139

Impacted Files
Coverage Δ
Complexity Δ

...avr/src/main/java/io/vavr/collection/Iterator.java
99.23% <100%> (ø)
182 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1243c...6eb08a8. Read the comment docs.


Show average bitrate and estimated size

@john-black-3k do you agree with this change?

It should work. Thanks!


Intellisense sometimes fails to show anything for Node modules

VSCode Version: 1.32.0-insider
OS Version: Windows 7 64 bit

Steps to Reproduce:

In a new Node project, type const http = require('http'); on line 1
Copy and paste that line to line 2 (must copy and paste to reproduce most of the time)
Edit line 2's http to fs (doesn't have to be http or fs, just any two modules)
Now on line 3 type http. and you will see that Intellisense is not working.

Here is a video of the entire bug:
https://www.youtube.com/watch?v=kIshFgrrYyw

Does this issue occur when all extensions are disabled?: Pretty sure extensions need to be on for it to work properly in the first place right?

Quick follow up, seems that the relevant intellisense extension is this one:


Blacklisted sites to consider adding

Here's my list of blacklisted sites to consider blocking by default.
beta\.crunchyroll\.com; #content > div > div.app-body-wrapper > div > div > div.content-wrapper--MF5LS > div > div.commenting-wrapper

For some reason, it just redirects me to the main site when I go to the beta site. I added the elements you posted; let me know how it goes. Thanks.

Oh, you actually need an account registered in the beta to access the beta site, I completely forgot about this, sorry. But I checked and it's working fine, thank you.

Awesome, good to hear!


Ban multibyte enum discriminants in combination with endian-aware archive features

This is a two-parter.
The first part is to ban enum discriminants other than u8 when using endian-aware archives. This is because although the tags can be serialized and deserialized properly, they won't match right unless the variants are explicitly set to particular values. This will entail adding the same endian-aware features to rkyv_derive and returning an error if the user attempts to have multibyte enum discriminants with either of the features on.
The second part is to add a feature gate for arbitrary enum discriminants and implement them in the derive. This should just require checking if the archive endianness does not match the target endianness and swapping the bytes of the discriminant.

Part 1 fixed by 9fa984a83feb031c78594accb01299211e5b0e95

Part 2 fixed by 2dd6b89ca9af18ffafceb43c766f975abd2509cd


Items not picked, Shenk not done (stands in params = 1)

Botty Version
0.3.0
Describe the bug
after kill, "alt" would not be pushed and items analysed. (Color-Settings are done)
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
etc.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots / Video
If applicable, add screenshots or even better a short video of the error happening to help explain your problem. Botty often automatically makes screenshots when something goes wrong. Add these also.
Logs
2021-11-23 10:48:51,440] INFO       Run Pindle
Exception in thread Thread-4:
Traceback (most recent call last):
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\threading.py", line 932, in bootstrap_inner
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\threading.py", line 870, in run
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\bot.py", line 270, in doit
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\char\hammerdin.py", line 65, in kill_pindle
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\char\hammerdin.py", line 51, in do_redemption
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init.py", line 379, in send
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init.py", line 358, in parse_hotkey
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init_.py", line 358, in
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init_.py", line 309, in key_to_scan_codes
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_canonical_names.py", line 1239, in normalize_name
ValueError: Can only normalize non-empty string names. Unexpected ''
[2021-11-23 10:49:25,844] INFO       Run Eldritch
Exception in thread Thread-7:
Traceback (most recent call last):
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\threading.py", line 932, in bootstrap_inner
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\threading.py", line 870, in run
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\bot.py", line 309, in doit
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\char\hammerdin.py", line 76, in kill_eldritch
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\char\hammerdin.py", line 51, in do_redemption
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init.py", line 379, in send
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init.py", line 358, in parse_hotkey
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init_.py", line 358, in
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_init_.py", line 309, in key_to_scan_codes
File "C:\Users\blubb\AppData\Local\Temp\ONEFIL~2\keyboard_canonical_names.py", line 1239, in normalize_name
ValueError: Can only normalize non-empty string names. Unexpected ''
[2021-11-23 10:49:48,676] INFO       End game. Elapsed time: 76.45s
Additional info
i am using shadow.tech as cloud gaming computer. so my keyboard is connected through cloud session.

2 things.

Current version it says redemption is optional. It really is not because of a bug. You must use it.
If alt pressing issues as eld it often is caused by not setting item pickup to hold but to toggle instead.

redemption used, and now the pick up items, too.
now i get only a stuck error on teleport to shenk

Sounds good, different issue. Closing


Random thoughts about optimizations

LMDB has a mode where you append to a table, and it doesn't do key comparisons except for with the previous highest key, and the append fails if the key isn't higher than the previous highest key. I don't think it's actually super useful for ord, since I don't think we spend much time doing key comparisons, but it's interesting.

We have some tables where the keys are contiguous integers, starting at 0, and entries in the table are never removed. Is there an optimization here that would allow avoiding storing keys? Or an optimization which is possible because values are never removed?

We tried to create a super large table where the overhead from redb wound up being prohibitive. Is there a way to avoid this overhead somehow? We could do somewhat inconvenient things like guarantee we were only appending, only do bulk inserts, never remove keys, etc, if it could reduce the overhead.

LMDB has a mode where you append to a table, and it doesn't do key comparisons except for with the previous highest key, and the append fails if the key isn't higher than the previous highest key. I don't think it's actually super useful for ord, since I don't think we spend much time doing key comparisons, but it's interesting.

That'd be easy to add. I'd want to see a convincing use case with benchmarks showing it's valuable though. It seems like a weird API

We have some tables where the keys are contiguous integers, starting at 0, and entries in the table are never removed. Is there an optimization here that would allow avoiding storing keys? Or an optimization which is possible because values are never removed?

What type is the value?

We tried to create a super large table where the overhead from redb wound up being prohibitive. Is there a way to avoid this overhead somehow? We could do somewhat inconvenient things like guarantee we were only appending, only do bulk inserts, never remove keys, etc, if it could reduce the overhead.

What are the key & value types?

We have some tables where the keys are contiguous integers, starting at 0, and entries in the table are never removed. Is there an optimization here that would allow avoiding storing keys? Or an optimization which is possible because values are never removed?

What type is the value?

The values are big tuples:
pub(crate) type InscriptionEntryValue = (
  u16,                // charms
  u64,                // fee
  u32,                // height
  InscriptionIdValue, // inscription id
  i32,                // inscription number
  Option<u32>,        // parent
  Option<u64>,        // sat
  u32,                // sequence number
  u32,                // timestamp
);

We tried to create a super large table where the overhead from redb wound up being prohibitive. Is there a way to avoid this overhead somehow? We could do somewhat inconvenient things like guarantee we were only appending, only do bulk inserts, never remove keys, etc, if it could reduce the overhead.

What are the key & value types?

The keys are [u8; 32] and the values are &[u8]. Value sizes are from 100 bytes to 100,000 bytes.

The values are big tuples:
pub(crate) type InscriptionEntryValue = (
  u16,                // charms
  u64,                // fee
  u32,                // height
  InscriptionIdValue, // inscription id
  i32,                // inscription number
  Option<u32>,        // parent
  Option<u64>,        // sat
  u32,                // sequence number
  u32,                // timestamp
);

Eliding the keys isn't going to make a big difference. I assume they're u32 or something, so 4bytes? The page pointer and checksum in the internal branch pages are much larger, 64bit and 128bit respectively: https://github.com/cberner/redb/blob/d8be9580591aa063469df6a7faf243d17a5a59a6/docs/design.md#branch-page
I might be able to optimize the packing of redb's internal pages since you're inserting in sorted order. I'll give that some thought.
Since it looks like your value is fixed width. I would move those out of redb into a flat file. You could store the latest key in redb, so you know the length of valid data in your file, and then doing lookups in that file is simply multiplying the value width by the index you want to read and doing a seek.

The keys are [u8; 32] and the values are &[u8]. Value sizes are from 100 bytes to 100,000 bytes.

Interesting. Do the keys have any structure to them, or are they effectively random bytes? Do you know the distribution of value lengths? Or at least the mean length?

Sorry, I spaced and never responded to this!

Eliding the keys isn't going to make a big difference. I assume they're u32 or something, so 4bytes? The page pointer and checksum in the internal branch pages are much larger, 64bit and 128bit respectively: https://github.com/cberner/redb/blob/d8be9580591aa063469df6a7faf243d17a5a59a6/docs/design.md#branch-page

Makes sense! Are the checksums unused if not doing the checksum commit strategy?

Since it looks like your value is fixed width. I would move those out of redb into a flat file. You could store the latest key in redb, so you know the length of valid data in your file, and then doing lookups in that file is simply multiplying the value width by the index you want to read and doing a seek.

Yeah, that's probably what we need to do. It's annoying not to have the simplicity of a single database to work with.

Interesting. Do the keys have any structure to them, or are they effectively random bytes? Do you know the distribution of value lengths? Or at least the mean length?

The keys are random bytes, since they're transaction IDs, and the values are bitcoin transactions, so really they have minimal structure.

No worries!
The checksums are still there and are used by the check_integrity() method. For a while they were only in the file when the checksum commit strategy was used, but I decided it complicated the code too much and this way the user can switch between commit strategies at will.

The keys are random bytes, since they're transaction IDs, and the values are bitcoin transactions, so really they have minimal structure.

I can't think of much to optimize then. Even removing the checksums wouldn't help much, since the values are so large. And there's no duplication of values in redb, so nothing is being wasted there. There is a fair bit of empty space in the file because when a node in the tree splits it creates two half filled nodes. I'm pretty sure that's all zero initialized, so you could try storing it on a compressed filesystem


Remove cumulus_password from setup.py

No user should ever login as the cumulus user, so we can just use a long random generated password.

Fixed by #23


Tutorial reviewed and corrected for better understanding

@shyba @acamino ready

This one already contains the changes introduced in 3482bd3.


traefik 3.0 does not find services on swarm with new syntax

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I upgraded from 2.11.2 to 3.0.0
What did you see instead?
None of my services showed up on the dashboard anymore. I would really appreciate if you could refrain from breaking configurations through new commands. I am happy that you are developing Traefik further but it is really frustrating that after an upgrade nothing works. Like last time with 2.11.1 I spent hours trying to make traefik work again. I ended up going back to 2.11.2 to have my services running again.
What version of Traefik are you using?
3.0.0
What is your environment & configuration?
command:
  - "--log.level=ERROR"
  - "--log.filepath=logs/traefik.log"
  - "--accesslog.filepath=logs/access.log"
  - "--api.dashboard=true"
  - "--api.insecure=true"
  - "--providers.docker=true"
  - "--providers.swarm.endpoint=tcp://<IP_ADDRESS>:2377"
  - "--providers.docker.exposedbydefault=false"
  - "--providers.docker.watch"
  - "--providers.docker.network=proxy"
  - "--providers.docker.endpoint=unix:///var/run/docker.sock"
  - "--entrypoints.http.address=:80"
  - "--entrypoints.https.address=:443"
  - "--certificatesresolvers.letsencrypt.acme.dnschallenge=true"
  -<EMAIL_ADDRESS>  - "--certificatesresolvers.letsencrypt.acme.storage=/letsencrypt/acme.json"
  - "--certificatesresolvers.letsencrypt.acme.dnschallenge.provider=allinkl"
  - "--certificatesresolvers.letsencrypt.acme.dnschallenge.resolvers=<IP_ADDRESS>:53"
  - "--certificatesresolvers.letsencrypt.acme.dnschallenge.resolvers=<IP_ADDRESS>:53"

If applicable, please paste the log output in DEBUG level
No response

Hello,
swarm is now a dedicated provider:

https://doc.traefik.io/traefik/routing/providers/swarm/
https://doc.traefik.io/traefik/migration/v2-to-v3/#docker-docker-swarm
https://doc.traefik.io/traefik/providers/docker/

In your configuration, you are mixing the 2 providers (Docker and Swarm), if you want to use Swarm only then you should migrate your Docker provider configuration to the Swarm provider.

After another hour of going through the three documents I finally have it working:
command:
- "--log.level=ERROR"
- "--log.filepath=logs/traefik.log"
- "--accesslog.filepath=logs/access.log"
- "--api.dashboard=true"
- "--api.insecure=true"
- "--providers.swarm.network=proxy"
- "--providers.swarm.endpoint=unix:///var/run/docker.sock"
- "--providers.swarm.exposedByDefault=false"
- "--entryPoints.http.address=:80"
- "--entryPoints.https.address=:443"
It would be nice if there would be a basic configuration, step by step and not only snippets here and there. It would be a lot less trial and error and would scare of people a lot less. It took me about half a year to get everything running including TLS with letsencrypt (the letsencrypt part took me several month alone because the link between the entry points and the services is not really documented well, it took me ages to figure out that the only thing I was missing was specifying the correct network, so traefik could route the request to the service.
When you know this, it is obvious but if you don't, you just see 404s every time you try something and you do not get any hint what might be wrong.
Same for this configuration here: the guide to upgrade only specifies to connect to localhost port 2377. In my case this did not work. the docker socket connection worked.
If you do not know where the problem is, you have to try different things which usually messes up the configuration. I found that half of my traefik labels were wrong as I copied them from the examples until traefik sort of worked. At least I was able to sort that out now.

Hello @Twiederh,
Thanks for reaching out.

It would be nice if there would be a basic configuration, step by step and not only snippets here and there.

The idea sounds great, such documentation would help a lot of people I guess.
Do not hesitate to open a PR: Traefik is an Open Source project and any help is appreciated (and, concerning the documentation, it's more than appreciated 😅 ).

I would be happy to help but when trying to submit a PR, I received "must be a collaborator. This is what I entered:

What does this PR do?

For the initial configuration of Traefik there should be basic configuration examples that show completely how to configure Traefik from scratch to get new users up to speed very quickly. The configuration examples should show a complete scenario, from my own experience I see two areas that took me long to figure out the configuration:

Basic setup with initial configuration items for both yaml and toml files and for environment variables in Docker configuration files
complete TLS configuration steps end-to-end

Also they should only cover the absolute minimum configuration necessary. The additional documentation then helps the user to find the additional configuration documentation for additional features but then there would be a minimum a new user could get back to knowing that it works
Motivation

I struggled big time trying to get things like TLS working completely, the changes in 3..0 with Docker Swarm again took me hours to get back to a working configuration. There is a lot of documentation but sometimes it would be great if there would be configuration examples that can be used to compare ones own configuration to. For example for TLS and the loadbalancer piece of the configuration I never understood that there needs to be a network connection between Traefik and the container that is configured for TLS. In hindsight, it is obvious but if you do not know where to look and how to troubleshoot, you configure the steps in the documentation and they do not work - and even worse, you do not see why.
More

[ ] Added/updated tests
[X] Added/updated documentation

Additional Notes

I would be happy to help here, I an "only" running a setup with Docker Swarm but I have at least some configurations that would help others as well - in return maybe someone can remove the unnecessary bits of the configuration to make them cleaner.

Hello @Twiederh,

I received "must be a collaborato

This error happens when people try to push on Traefik repo. Have you forked traefik before opening the PR?

I tried to open a PR again but I still receive the message that I need to be a collaborator to be able to open a PR. I tried to find out how to become one but I was unable. I only have a private GitHub account, could that be the reason? Or do you need to invite me as a collaborator?

Hello @Twiederh,
You cannot create a PR directly on the traefik repo.
Have you forked it?


GTest example doesn't work with MSVC 11

The GTest example actually doesn't work with MSVC 11 (toolset v110) due to VC++ not supporting variadic templates.
The problem can be fixed by defining GTEST_HAS_TR1_TUPLE to 0 or _VARIADIC_MAX to 10, although the latter is more of a band aid than a solution.
This is just a heads up for anyone who might want to use this with an old version of MSVC

To clarify, it's the build of gtest itself that fails, not the downloading? In other words, you have this problem regardless of how you obtain the gtest sources?

yes it's an issue of gtest. Like I said, I just posted this issue to give a heads up to people who want to simply copy&paste your example (probably the majority of users) and are surprised that their build doesn't work, I wasn't expecting a "fix" from you.

Okay, no worries. Thanks for documenting it and providing a workaround. I'll close this issue now.

In my opinion it is not an issue of gtest. In gtest they already put the workaround to compile but being called from a parent CMake file is not working because we are forcing to not change compiling options.
For me the solution is to add the snipped code under the download_project.
`include(DownloadProject.cmake)
download_project(PROJ                googletest
GIT_REPOSITORY      https://github.com/google/googletest.git
GIT_TAG             master
${UPDATE_DISCONNECTED_IF_AVAILABLE}
)
if (MSVC AND MSVC_VERSION EQUAL 1700)
add_definitions(/D _VARIADIC_MAX=10)
endif()`

@limdor Does gtest change compile options only for it's own targets or globally? Otherwise it is definitely necessary to prevent gtest from changing compile options, as it would also affect your own targets and might lead to unexpected behaviour. But I do see your point.
Also have a look at this project of mine which I created specifically for configuring gtest with cmake, as gtest is really just an example usage of DownloadProject. I tested it with several versions of gcc, clang and msvc.

I understand the point about blocking the compiler options.
To reproduce this it is only necessary to try to compile the DownloadProject with VS2012.


error when running on a new thread

Hi I'm a newbie who just started exploring TikTok world and thank you for developing this great toolkit!
I found a weird behavior as below. Could you confirm it as expected or not? Thanks!
Describe the bug
When I execute TikTokLiveClient.run on a newly created thread, it crashes.
To Reproduce
Run the code below:
import threading
import time
import asyncio
from TikTokLive import TikTokLiveClient

def start_tiktok():
    # loop = asyncio.new_event_loop()
    # asyncio.set_event_loop(loop)
    client = TikTokLiveClient(unique_id='@isaackogz')
    client.run()

thread = threading.Thread(target=start_tiktok)
thread.daemon = True
thread.start()

time.sleep(10)

and we get this error:
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home/ec2-user/.local/lib/python3.7/site-packages/TikTokLive/client/base.py", line 73, in __init__
    self.loop: AbstractEventLoop = asyncio.get_event_loop()
  File "/usr/lib64/python3.7/asyncio/events.py", line 644, in get_event_loop
    % threading.current_thread().name)
RuntimeError: There is no current event loop in thread 'Thread-1'.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.7/threading.py", line 926, in _bootstrap_inner
    self.run()
  File "/usr/lib64/python3.7/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "repro.py", line 9, in start_tiktok
    subscription = TikTokLiveClient(unique_id='@tv_asahi_news')
  File "/home/ec2-user/.local/lib/python3.7/site-packages/TikTokLive/client/client.py", line 31, in __init__
    BaseClient.__init__(self, unique_id, **options)
  File "/home/ec2-user/.local/lib/python3.7/site-packages/TikTokLive/client/base.py", line 75, in __init__
    self.loop: AbstractEventLoop = asyncio.get_running_loop()
RuntimeError: no running event loop

If I uncomment the two lines, it works without problem.
     loop = asyncio.new_event_loop()
     asyncio.set_event_loop(loop)

Shouldn't this be handled inside the library? I saw the following description in README.md

Optionally supply your own asyncio event loop for usage by the client. When set to None, the client pulls the current active loop or creates a new one. This option is mostly useful for people trying to nest asyncio.

Expected behavior
Code runs without problem.
Additional context
Add any other context about the problem here.

It's interesting because it works in the main thread, but not in new threads. I do not know why this is.

If we want to achieve the below behavior, how about this code?

the client pulls the current active loop or creates a new one.

            try:
                self.loop: AbstractEventLoop = asyncio.get_running_loop()
            except RuntimeError:
                # if there is no running loop, create a new event loop
                self.loop: AbstractEventLoop = asyncio.new_event_loop()

I guess no event loop is set by default for a new thread.
Also note that starting from python 3.10, get_event_loop becomes deprecated and it will be identical with get_running_loop (doc)

If we want to achieve the below behavior, how about this code?

the client pulls the current active loop or creates a new one.

            try:
                self.loop: AbstractEventLoop = asyncio.get_running_loop()
            except RuntimeError:
                # if there is no running loop, create a new event loop
                self.loop: AbstractEventLoop = asyncio.new_event_loop()

I guess no event loop is set by default for a new thread.
Also note that starting from python 3.10, get_event_loop becomes deprecated and it will be identical with get_running_loop (doc)

Looks good. Do you want to make a pull request? If not, I will when I next have time to review the package

@isaackogan Hi thanks for the offer. I submitted a PR for this. Hope you can check it when you get a chance 🙏 .

Tested locally in 3.8, looks good. Merged into master and will be released in today's update

One comment, @tmokmss
If your intention is to run multiple clients, there's an IP rate limit for signing connections to respect fair use of TikTok services.
There are a million different reasons to thread, so I won't presume that's why you want to, but, just in-case you wanted to set up a bunch of clients at once, you will need an API key.
Thanks for the contribution, releasing the update now!

New API key feature? Sounds cool, thanks!
I'm currently using it in my small hobby project (hoping it is not harming your server :pray: ) but I'll definitely contact you when I need larger-scale access.

For sure! The server can handle a few hundred requests a second before I'd need to up the capacity, which will never happen. Just don't want TikTok to tighten security again!
Thanks for the help, enjoy the new version!
Isaac


Document connection pooling behavior and configuration

How does connection pooling work? What are its defaults? What are the levers available to modify its behavior?

Pushing out since I have no info with which to fulfill this task. I have a query out to Sam and Erik, and will pull it back in to 8.0-4 if I can get what I need in time.

I added a one-liner in 8.0-5 to the effect that we use HttpClient for connection pooling. Since I have not been able to get any more detailed information than that from the devs, that's all I'm planning to say.
Is that sufficient to address your needs, Justin? If not, please reassign to Sam.

Sorry, Kim, that this missed my radar.  It's assigned to me now, so I'll get you something during EA4.

Due to bug load right now, I need to push this to 4.0.1

Each time you call DatabaseClientFactory.newClient you create a new DatabaseClient instance which is associated 1-1 with a connection pool.  The connection pool makes efficient reuse of connections and therefore a DatabaseClient instance should be reused as much as possible throughout the life of an application rather than used, discarded, then re-created.  After initial configuration the DatabaseClient instance is thread-safe (it can be reused across many threads).  The connection pool is configured to have 100 connections.  This means the maximum number of HTTP socket connections per DatabaseClient is 100.  Each DatabaseClient is only pointed to one combination of host, port, database, and security configuration.  If an application needs to create additional DatabaseClient instances (because it needs to connect with multiple hosts or ports or databases or users) keep in mind that a separate connection pool will be associated with each DatabaseClient instance.
When any call to the Java Client API makes a new request to the MarkLogic server, an available connection is drawn from the pool and used for the HTTP request.  When the HTTP response is received, processed, and closed, the connection is made available again to the connection pool.  No state information is maintained with the connection.  All cookies are discarded unless a Transaction is in use, in which case the cookies are associated with the transaction, not the connection.
As of 4.0.0 the connection pool can only be adjusted by implementing HttpClientConfigurator and doing any adjustment in the configure method.  However, it should be noted that HttpClient will likely be replaced in a future version and thereafter this ClientConfigurator will be ignored.

@jmakeig please take a look and provide me any feedback.

Kim, I'm assuming that when Justin marked it "ship" he means he reviewed and it's ok as is and he has nothing to add.  Please reach out to me when you're ready to work on this if you need help fitting in what we already have.

A topic on connection management and configuration has been added to the dev, under the discussion of DatabaseClient, and reviewed by Sam. All revisions are in, so I think this is good to go for 4.0-1/9.0-1.

The new sections are titled "Expected Client Lifetime" and "Connection Management and Configuration".


Use CMake CUDA language support

Since we now require CMake 3.13 we could potentially significantly clean up our CUDA support (https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html, enable_language(CUDA)). This would be a good task for someone familiar (or willing to get familiar) with CMake's CUDA support. The only caveat is that we'd have to make sure that clang CUDA compilation still works normally.

For libraries that only need the CUDA runtime libraries we should be using https://cmake.org/cmake/help/v3.17/module/FindCUDAToolkit.html#module:FindCUDAToolkit and the CUDA::cudart target (CMake 3.17 onwards).

In progress in #5162.


option to pass in a graphql-js schema instead of a file path

I'm happy to include an option for this, but I don't have a personal need for it or the time to build it out. Would accept a PR


Weekly Dining/Cafe Hours

At the bottom of each dining hall or cafe, it would be a good idea to put the weekly hours for the place so that people can plan trips to places like the Dairy Bar in advance.

+1
(Note for history: this was discussed offline).

Resolved in https://github.com/TrevorEdwards/bigredapp-android/commit/0c257165ef02dfd49bf0a12718b8a6dbd9246540 .  You can click on a location to see its full hours now.


No dependencies recognized for go 1.14

license_finder reports no dependencies recognized if go in go.mod is set to 1.14
Sample go.mod
module github.com/foo/foo-service

go 1.14

require github.com/stretchr/testify v1.5.1

Sample go.sum
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4=
github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=

$ license_finder
LicenseFinder::GoModules: is active

No dependencies recognized!

If I used the docker image v6.4.0 in GitLab CI as image to run the job, then I would get the following unknown license type.
/bin/bash -lc license_finder action_items -p
 mesg: ttyname failed: Inappropriate ioctl for device
 LicenseFinder::GoModules: is active
 Dependencies that need approval:
 github.com/stretchr/testify, v1.5.1, unknown

If I update go.mod to go 1.13, then license_finder is able to find the dependencies for approval.
$ license_finder
LicenseFinder::GoModules: is active

Dependencies that need approval:
github.com/davecgh/go-spew, v1.1.0, unknown
github.com/pmezard/go-difflib, v1.0.0, "New BSD"
github.com/stretchr/objx, v0.1.0, MIT
github.com/stretchr/testify, v1.5.1, MIT
gopkg.in/check.v1, v0.0.0-20161208181325-20d25e280405, "Simplified BSD"
gopkg.in/yaml.v2, v2.2.2, "Apache 2.0, MIT"

Hey @faraonc! This is an interesting one. So it looks like the go modules package manager triggers on if a go.sum file exists. That is why when you just create a go.mod file, it says no package managers active.
I'm guessing why your CI reports something is that there is a go.sum file in there. Would you be able to share that as well? Then we will be able to experiment with different versions of go mod to see what is happening.
One note is that the installed version of go on the docker image is 1.13.3. I wonder if some kind of format changed in 1.14. If so, we will need to build in some kind of compatibility parsing.
Let me know if you can get my a more reproducible example with a go.sum :)

Hey @faraonc! This is an interesting one. So it looks like the go modules package manager triggers on if a go.sum file exists. That is why when you just create a go.mod file, it says no package managers active.
I'm guessing why your CI reports something is that there is a go.sum file in there. Would you be able to share that as well? Then we will be able to experiment with different versions of go mod to see what is happening.
One note is that the installed version of go on the docker image is 1.13.3. I wonder if some kind of format changed in 1.14. If so, we will need to build in some kind of compatibility parsing.
Let me know if you can get my a more reproducible example with a go.sum :)

I have updated the the issue above to include the go.sum.
There was a go.sum when it was ran in 1.14 locally (go 1.14.3)
I was thinking it might have something to do with an environment variable when it ran in the CI using Docker. I did not look in detail in the codebase, but I might when I get the chance.

The file to look at for functionality is https://github.com/pivotal/LicenseFinder/blob/master/lib/license_finder/package_managers/go_modules.rb
When running prepare commands, we do run go mod tidy which will clear out the sum file if things are unused. Locally with go version 1.13.3 I managed to reproduce your results with github.com/stretchr/testify, v1.5.1, unknown
I cannot seem to get the full results that you outlined after that but that could just be because of the actual project missing locally. I am not convinced that this is a version specific issue. To be honest, I am not a Go expert by any means so I wonder if Gomod is doing something weird with the go version in the .mod file when running one of the commands.

The file to look at for functionality is https://github.com/pivotal/LicenseFinder/blob/master/lib/license_finder/package_managers/go_modules.rb
When running prepare commands, we do run go mod tidy which will clear out the sum file if things are unused. Locally with go version 1.13.3 I managed to reproduce your results with github.com/stretchr/testify, v1.5.1, unknown

This is what we are seeing in the CI, as it is running the Docker image which is using the go version specified in the Dockerfile, so I think the repro is good.

I cannot seem to get the full results that you outlined after that but that could just be because of the actual project missing locally. I am not convinced that this is a version specific issue. To be honest, I am not a Go expert by any means so I wonder if Gomod is doing something weird with the go version in the .mod file when running one of the commands.

It seems like they did change a bunch of stuff related to go modules on the major update https://golang.org/doc/go1.14. We might be missing a flag somewhere

We actually just made a PR to bump the golang version. I'm not sure if this is gonna fix this issue. I also still cannot reproduce the output you put last when changing the go.mod file to have 1.13 in it. Maybe the golang docker bump will shed some light!

I will keep you posted once the image is in DockerHub

It looks like they change defaults in 1.14 from being --mod=mod to --mod=vendor. We had code that depended on this so we flipped the logic at the same time of this upgrade and will be fixed in the next release. https://github.com/pivotal/LicenseFinder/pull/743

I was able to verify this to work against GitLab Enterprise Edition 12.10.6-ee using 6.5.0 release.
Thank you so much!


OAuth2: Check the token of a server

https://github.com/FroxyNetwork/WebSocket/issues/3
Check if a token is correct AND linked with specific server.
Example input:
{
"token": "the token",
"server": "GAME_1"
}
Output:
HTTP CODE 403 => If the websocket doesn't have a correct token or doesn't have the scope "websocket_check_token"
HTTP CODE 200 => If the websocket has a correct token and has the scope "websocket_check_token":
Body:
{
"valid": false
}
=> Invalid token
,
{
"valid": true
}
=> Valid token

Done


Update apis.md

fix total_messages link

@usr-icon-foundation To shorten the document, I already modified the basic URL. It already contains api.


[Bug] Kite: not installed

Issue Type: Bug
Extension Name: kite
Extension Version: 0.81.0
OS Version: Linux x64 4.19.10-041910-generic
VSCode version: 1.33.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:
{
	"messages": [],
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 175,
		"activateCallTime": 8,
		"activateResolvedTime": 23,
		"activationEvent": "*"
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": ""
		},
		{
			"name": "Error",
			"message": ""
		}
	]
}

@Pk13055 how did you install the Kite extension?


Ensure the result of simulation is normalized

Normalize the final state vector of a simulation, fixes #https://github.com/quantumlib/Cirq/issues/6402

I considered doing this in the past when the earlier issue came up, but was concerned it was like sweeping dirt under the rug. Does doing this then make other invariants start failing? I think it's worth looking at what other projects do here, and try to follow prior art on the subject.

@daxfohl for state vector there is not an issue
for density matrix it doesn't work (I reverted my changes and restricted this PR to state vector simulation). the invariant of density matrix is that $Tr[\rho^2] \leq 1$ with equality if and only if $\rho$ is pure. I don't think we should implicitly add the computation $Tr[\rho^2]$


Draft: [Relation Viewer] Introduce Relation Viewer

this commit introduces Relation Viewer
ONE-vscode-DCO-1.0-Signed-off-by: jihong-yu<EMAIL_ADDRESS>

@jihong-yu Could you format this files using 'eslint' and 'clang-format'?

@jihong-yu It seems this PR includes some files and changes related to Metadata Viewer. Please remove them :-D

@jihong-yu Could you make it as a PR if it's ready?


Additional privacy related Firefox tweaks

Hi! 👋
I don't know if this is acceptable that the video and reference materials would differ, but I'd recommend adding some additional Firefox tweaks to the list:

beacon.enabled = false This method is intended for analytics and diagnostics code to send data to a server.
browser.send_pings = false The attribute would be useful for letting websites track visitors' clicks.
dom.battery.enabled = false Website owners can track the battery status of your device

Thanks @AmadeuszL!
Looks like browser.send_pings is false by default.
Do you still suggest including this property in the PR?

No, I don't. That's an oversight 🙃

I really appreciate you raising awareness to these settings.
Standby for updated PR and will merge.

Hey @AmadeuszL, just noticed you closed the issue... why?

I deleted my fork of the repo yesterday and therefore lost the ability to make changes to patch-1 branch and by the same token to this PR :clown_face:


[PowerPoint] (slides) APIs for adding slides

Also moves the "Delete slides" section from the "Insert slides" article to the new "Add slides" article.

Docs Build status updates of commit f7b9685:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/powerpoint/add-slides.md
:white_check_mark:Succeeded
View

docs/powerpoint/insert-slides-into-presentation.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7565b57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/powerpoint/add-slides.md
:white_check_mark:Succeeded
View

docs/powerpoint/insert-slides-into-presentation.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel