Fixes #2358 - BREAKING CHANGE: Pos.Combine is incorrect for scenarios involving PosAbsolute.

Fixes #2358 - This a set of commits on https://github.com/tig/Terminal.Gui/pull/10. The redraw button behavior doesn't occurs anymore.
Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[ ] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

@tig initially I did cherry picks from PR https://github.com/tig/Terminal.Gui/pull/10 into this PR, Later I noticed that some of the changes I made didn't exist and end up to do a merge. After fixed some merge conflicts and errors it seem it's reasonable. I also removed the HeightAsBuffer which was still exist in the v2. We need to have a stable v2 merged as base to continue working.

Arrrrrrg!

The crazy thing is when I git merge v2_develop in to BDisp-v2_layout-improvements I get a clean merge.

The crazy thing is when I git merge v2_develop in to BDisp-v2_layout-improvements I get a clean merge.

I failed to pull your latest version of this PR locally before merge, which is why I didn't see the merge conflicts locally.

PR to this PR with merge fixes incoming...

Strange behavior vertical label not showing all.

I fixed this broken test in my PR:
https://github.com/gui-cs/Terminal.Gui/actions/runs/4326573444/jobs/7554150952#step:6:439

Ok is more than clear the NeedDisplay must always be the view bounds because on frame changes sometimes gives a false value. So i will remove the code that handle this property size to the default which is only to indicates that need redraw.

@tig please see this. Running separated doesn't throws exceptions.
[xUnit.net 00:00:47.31]     Terminal.Gui.ConfigurationTests.ConfigurationManagerTests.TestConfigurationManagerToJson [FAIL]
[xUnit.net 00:00:47.31]       System.NotSupportedException : The collection type 'NStack.ustring' is abstract, an interface, or is read only, and could not be instantiated and populated. Path: $.Child.Id | LineNumber: 35 | BytePositionInLine: 19.
[xUnit.net 00:00:47.31]       ---- System.NotSupportedException : The collection type 'NStack.ustring' is abstract, an interface, or is read only, and could not be instantiated and populated.
[xUnit.net 00:00:47.31]       Stack Trace:
[xUnit.net 00:00:47.31]            at System.Text.Json.ThrowHelper.ThrowNotSupportedException(ReadStack& state, Utf8JsonReader& reader, NotSupportedException ex)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.Converters.IEnumerableOfTConverter`2.CreateCollection(Utf8JsonReader& reader, ReadStack& state, JsonSerializerOptions options)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonCollectionConverter`2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.ReadCoreAsObject(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
[xUnit.net 00:00:47.31]            at System.Text.Json.JsonSerializer.ReadCore[TValue](Utf8JsonReader& reader, JsonTypeInfo jsonTypeInfo, ReadStack& state)
[xUnit.net 00:00:47.31]            at System.Text.Json.JsonSerializer.Read[TValue](Utf8JsonReader& reader, JsonTypeInfo jsonTypeInfo)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Configuration/Scope.cs(134,0): at Terminal.Gui.Configuration.ConfigurationManager.ScopeJsonConverter`1.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
[xUnit.net 00:00:47.31]            at System.Text.Json.JsonSerializer.Read[TValue](Utf8JsonReader& reader, JsonTypeInfo jsonTypeInfo)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Configuration/DictionaryJsonConverter.cs(18,0): at Terminal.Gui.Configuration.DictionaryJsonConverter`1.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Configuration/Scope.cs(98,0): at Terminal.Gui.Configuration.ConfigurationManager.ScopeJsonConverter`1.ReadHelper`1.Read(Utf8JsonReader& reader, Type type, JsonSerializerOptions options)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Configuration/Scope.cs(132,0): at Terminal.Gui.Configuration.ConfigurationManager.ScopeJsonConverter`1.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
[xUnit.net 00:00:47.31]            at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
[xUnit.net 00:00:47.31]            at System.Text.Json.JsonSerializer.ContinueDeserialize[TValue](ReadBufferState& bufferState, JsonReaderState& jsonReaderState, ReadStack& readStack, JsonTypeInfo jsonTypeInfo)
[xUnit.net 00:00:47.31]            at System.Text.Json.JsonSerializer.ReadFromStream[TValue](Stream utf8Json, JsonTypeInfo jsonTypeInfo)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Configuration/SettingsScope.cs(51,0): at Terminal.Gui.Configuration.ConfigurationManager.SettingsScope.Update(Stream stream, String source)
[xUnit.net 00:00:47.31]         /home/runner/work/Terminal.Gui/Terminal.Gui/UnitTests/Configuration/ConfigurationMangerTests.cs(323,0): at Terminal.Gui.ConfigurationTests.ConfigurationManagerTests.TestConfigurationManagerToJson()
[xUnit.net 00:00:47.31]            at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
[xUnit.net 00:00:47.32]            at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
[xUnit.net 00:00:47.32]         ----- Inner Stack Trace -----
[xUnit.net 00:00:47.32]

@tig please see this. Running separated doesn't throws exceptions.
[xUnit.net 00:00:47.31]     Terminal.Gui.ConfigurationTests.ConfigurationManagerTests.TestConfigurationManagerToJson [FAIL]
[xUnit.net 00:00:47.31]       System.NotSupportedException : The collection type 'NStack.ustring' is abstract, an interface, or is read only, and could not be instantiated and populated. Path: $.Child.Id | LineNumber: 35 | BytePositionInLine: 19.

This is fixed in my PR: https://github.com/BDisp/Terminal.Gui/pull/134 with this:

This is fixed in my PR: https://github.com/BDisp/Terminal.Gui/pull/134 with this:

@tig but even I want to merge your PR I can't because it has conflicts that must be resolved and so it not work with this my PR.

This is fixed in my PR: BDisp#134 with this:

@tig but even I want to merge your PR I can't because it has conflicts that must be resolved and so it not work with this my PR.

Fixed.

@tig I already finished this PR. The cause of Scrolling scenario is also fixed. Thanks for your merge conflicts fix by submitting the PR. I would like to explain about the Toplevel.Redraw. I did the prior changes because the LayoutNeeded was set to false after the base.Redraw (Bounds); call and thus clearing any sets to true on the View.Redraw. For this reason the tests were failing when calling the Application.Top.Redraw(Application.Top.Bounds)by not call LayoutSubviews. Before it weren't fail but I don't know what cause the failures and and definitely change the Toplevel.Redraw to not call the ClearLayoutNeeded (); and ClearNeedsDisplay (); because the base.Redraw (Bounds); will call it on the View.Redraw. I recommend call the Application.Refresh() which will layout and redraw.

@tig the Border changes I'll submit on a separate PR that is still in WIP but is merged on this PR and thus having a solid base branch to continue working.

@tig the Border changes I'll submit on a separate PR that is still in WIP but is merged on this PR and thus having a solid base branch to continue working.

I recommend you do not spend any more time on Border for v2. It will all be negated by the new View design.

I recommend you do not spend any more time on Border for v2. It will all be negated by the new View design.

@tig I know it's already been negated by the new View design, but I added the Margin on the border scenarios that we can leverage and adapted to the new design. Do you agree?

Do you mean what you're working on is adding the ability to set Margin in the scenarios like you can set Padding and Border? If it's just Scenario work, then, yes, I agree.

Do you mean what you're working on is adding the ability to set Margin in the scenarios like you can set Padding and Border? If it's just Scenario work, then, yes, I agree.

Yes it's that. Border has already the ability to handle with Margin but content views has a bug by not dealing with the layout of theirs subviews and thus some subviews positions aren't set before they processes the layout of their subviews. Do you want I submit a fix for this bug on a new issue or may I send with the border improvements?

Do you mean what you're working on is adding the ability to set Margin in the scenarios like you can set Padding and Border? If it's just Scenario work, then, yes, I agree.

Yes it's that. Border has already the ability to handle with Margin but content views has a bug by not dealing with the layout of theirs subviews and thus some subviews positions aren't set before they processes the layout of their subviews. Do you want I submit a fix for this bug on a new issue or may I send with the border improvements?

I think I understand you, but to make sure, please verify that you understand that the definition of Margin and Padding in v1 are incorrect and in v2 they will use these definitions. Also verify you understand my intent to remove the current Border class completely.

See https://github.com/gui-cs/Terminal.Gui/blob/5826321b89512cff8f39c6a5e62864d95135e594/docfx/v2specs/View.md


Carthage Support

Any chance there is gonna be support for carthage?

@pinda
Thanks!
I'll try to support Carthage now.

I tried to support Carthage but I am running into an issue with the AtomicBridges modulemap, but don't have a good enough understanding of the library to make changes.


Add new azure regions and sort them alphabetically.

This adds regions to the regions.rb file based on the output of azure location list (which is the same as the ArmrestService#locations output).
It adds regions for Australia, Canada and India. I also put them in alphabetical order.

@blomquisg @bronaghs @Fryguy Please review.

@djberg96 - Does this list match the portal or is this the list returned by the API?
We decided in the past to stick with the former, explanation was given here

It does not match the portal, but the portal isn't showing the Australian regions. Not yet, anyway, so I don't know how they choose what to display. I ran this:
locations = []

conf.providers.each{ |prov|
  next unless prov.namespace == 'Microsoft.Compute'
  prov.resource_types.each{ |rt|
    if rt.resource_type == 'virtualMachines'
      locations << rt.locations
    end
  }
}

locations = locations.reject{ |loc| loc =~ /stage|global/i }
pp locations.flatten.uniq.sort

Even restricting it to the Microsoft.Compute namespace for the virtualMachine provider, I still get the current list, which is more than what the new portal allows for VM creation at the moment. The only new ones I saw in the portal I saw that we don't have yet are Canada East and Canada Central.
They are still valid regions for inventory collection, though, so I don't know how we want to proceed.

@djberg96 -
Can an instance be provisioned to the new regions we are adding that are not listed on the portal?

@bronaghs It doesn't look like it. I think we'll need clarification from MS for how they are generating their list. In the meantime, I'll update the PR to just add the Canadian locations.

From https://azure.microsoft.com/en-in/regions/:
The Australia Regions are available to customers with a business presence in Australia or New Zealand.
The India regions are available to volume licensing customers and partners with a local enrolment in India. The India regions will open to direct online Azure subscriptions in 2016.


Generation of application image from runtime image could be disabled

We are in a case were we want to only generate the xxx-build-artifacts part. We should be able to disable the runtime image generation.

wWe could add a buildApplicationImage  field that would not create the application image resources (ImageStream and BuildConfig) if it is set to false.
If this field is false , the user would have to disable the deployment by setting deploy.enabled to true (as we would not have an application image to deploy).
The configuration would look like:
build:
  git:
     ....
  s2i:
    buildApplicationImage: false
deploy:
  enabled: false


Normalize m' to m, to undo the Great Apostrophication

Ended up rolling back from backup. Thanks for the quick patch nevertheless.


[MM-44344] Restore zip build for Windows and remove auto-updater from it

Summary
We chose to remove the ZIP build for Windows since we did not believe it was relevant, and the auto-updater caused some odd issues with it. We have decided after a few people have mentioned it to restore it with the auto-updater removed.
Ticket Link
https://mattermost.atlassian.net/browse/MM-44344
Closes https://github.com/mattermost/desktop/issues/2112
Release Note
Restore Windows ZIP build

@amyblais This is technically a story, since we made a conscious choice to remove this, but it is a regression in v5.1 and I'd like to add it to a dot release.

Thank you for fixing this! Great to have a portable windows option without unwanted network requests again. (The typical use case.)
This incident made me analyze our situation again, though, and there are some issues I wasn't aware of. I'll write an issue.

Cherry pick is scheduled.


Remove seemingly unused SymbolLink constEnumReferenced

This SymbolLink isn't referenced anywhere other than where it's set - presumably we stopped using it awhile ago and didn't notice we removed its' last reference.

Via @andrewbranch

Ah, it supported the error in
--importsNotUsedAsValues error
which we decided not to replace with non-deprecated options, so that code became dead when we recently removed the 5.0 deprecations


GC warnings on large allocations

When allocating or resizing large arrays or hash tables the GC will output the following warning:
GC Warning: Repeated allocation of very large block (appr. size 134221824):
	May lead to memory leak and poor performance
GC Warning: Repeated allocation of very large block (appr. size<PHONE_NUMBER>):
	May lead to memory leak and poor performance

This feels quite ugly to me and it would be nice if Crystal would allow big containers without emitting warnings.
In #4441 which also discussed the issue it was suggested to set the GC_LARGE_ALLOC_WARN_INTERVAL variable. This however feels quite ugly to me as it involves action from the user and it is not very discoverable.
While looking for some other information I ran into https://github.com/ivmai/bdwgc/blob/master/doc/debugging.md#warning-messages-about-needing-to-allocate-blacklisted-blocks , which suggests to use GC_malloc_ignore_off_page for dealing with the issue. That is a GC_malloc replacement that does not warn on big allocations. So what does using it mean? Well, any memory allocated by it will be collected if not pointed to by a pointer to somewhere in the first 512 bytes of the memory. Or in other words, any pointer to INSIDE the internals of the memory is unsafe. This can be contrasted to with GC_malloc_atomic which means internal pointers pointing OUT from the memory won't be collected. There is also a GC_malloc_atomic_ignore_off_page for when the allocator cares neither about pointers pointing in or out of the inside of allocations which could be interesting too, but not for this particular discussion as the containers in question definitely need to keep what they contain alive.
One notable lack of the API is that there is only a malloc, not a realloc so realloc needs to be implemented, and it will involve an extra write to the size of the original allocation. This means it is slightly slower than the original realloc and should only be used when necessary. The choice between warning and performance is a bit unfun.
So is GC_malloc_ignore_off_page safe for hashes or arrays? Well, in the case of hash I'd say that it definitely is, as I can't think of any reasonable way to get a pointer into the internal allocations. In the case of Array it is slightly more controversial as arrays have to_unsafe and people could do whatever with that pointer. That already doesn't work if people resize the array (as GC_realloc invoke GC_free on the old allocation) but it is at least a bit feasible that someone somewhere could initialize a big array and then keep the allocation alive by a pointer to the inside.
Anyhow, I implemented a proof of concept in https://gist.github.com/yxhuvud/1d3f03a11fa0cc45f4d4574529068ee6.
Current implementation:
GC Warning: Repeated allocation of very large block (appr. size 201330688):
	May lead to memory leak and poor performance
GC Warning: Repeated allocation of very large block (appr. size<PHONE_NUMBER>):
	May lead to memory leak and poor performance
   1  28.33M ( 35.29ns) (±16.27%)    128B/op               fastest
  10   5.14M (194.39ns) (± 9.90%)    448B/op          5.51× slower
 100 538.58k (  1.86µs) (± 9.18%)  4.14kB/op         52.61× slower
  1k  47.05k ( 21.25µs) (± 4.98%)  32.5kB/op        602.19× slower
 10k   3.84k (260.39µs) (± 8.75%)   513kB/op       7377.66× slower
100k 346.09  (  2.89ms) (± 3.08%)  4.75MB/op      81867.22× slower
  1M  24.55  ( 40.73ms) (± 8.45%)  39.8MB/op    1153921.94× slower
 10M 805.41m (  1.24s ) (± 0.99%)   640MB/op   35178860.75× slower
100M  73.12m ( 13.68s ) (± 0.00%)   5.0GB/op  387509098.57× slower

This monkeypatch:
   1  27.56M ( 36.28ns) (±15.40%)    128B/op               fastest
  10   5.29M (188.98ns) (± 9.23%)    448B/op          5.21× slower
 100 538.74k (  1.86µs) (± 8.41%)  4.14kB/op         51.16× slower
  1k  47.28k ( 21.15µs) (± 9.25%)  32.5kB/op        582.95× slower
 10k   3.83k (260.80µs) (± 8.18%)   513kB/op       7187.47× slower
100k 337.42  (  2.96ms) (± 2.66%)  4.75MB/op      81676.93× slower
  1M  22.86  ( 43.75ms) (± 5.73%)  39.8MB/op    1205716.64× slower
 10M 783.16m (  1.28s ) (± 0.90%)   640MB/op   35190337.11× slower
100M  70.33m ( 14.22s ) (± 0.00%)   5.0GB/op  391868489.88× slower

So as you can see the difference is small (and often a lot less than the variance between runs), though the last one is a bit more noticeable. As far as I've been able to determine, that difference is due to the lack of realloc.
Thoughts? Is this a path worth pursuing? If so, do we want it only for Hash or also for Array allocations?

I think we should just silence/ignore all GC warnings and that's it.

Hmm, any pointers to where that could be done? I'm finding no initialization in gc/boehm.cr .

https://github.com/ivmai/bdwgc/blob/dee02534adbdb1ea03e7ba2772bdee22e744df04/include/gc.h#L1399
We use that and set a function that does nothing. Let me know if that works!

Can we just set GC_LARGE_ALLOC_WARN_INTERVAL to a large number? Only if the env var is not already defined. This would allow to override the default configuration at runtime.

Could GC_malloc_ignore_off_page be used for large arrays and large hashes (like the warning message kind of implies) and GC_malloc_atomic_ignore_off_page  for large Strings?  Or not?  Or leave that for a separate discussion?

I'll admit I saw this the other day GC Warning: Repeated allocation of very large block (appr. size 266240): and wondered "what is allocating something so large? why'? I guess this would help me answer that, thanks for the tip.

Right, but there's no way to know what that memory of chunk is related to...


the submit button on the demo is disabled

the button seems to be disabled

Hi! You need to tap the "Build Vector Index" button first. I'm open to other UI ideas though if you have them. The reason I made it two step is the Build Vector Index step takes a while.


Unified user component

We should have a unified User component that you either give a User or userID to and it'll either just display the user you've given and or fetch it from the backend.
It could also be good to have multiple styles, e.g. a small one in lists/search results/mutual friends lists, and a bigger one in the user page or similar.

Vue specific


The "command" argument must be of type string. Received an instance of Object

Describe the bug
It seems that installing inshellisense using pnpm cause to print error when writing commands especially pnpm add -g
To Reproduce
Just after installing inshellisense using pnpm
Write pnpm add -g pnpm
Expected behavior
Not to print
{   error: TypeError [ERR_INVALID_ARG_TYPE]: The "command" argument must be of type string. Received an instance of Object       at new NodeError (node:internal/errors:399:5)       at validateString (node:internal/validators:163:11)       at normalizeExecArgs (node:child_process:188:3)       at exec (node:child_process:231:16)       at file:///Users/floriaaan/Library/pnpm/global/5/.pnpm/@microsoft+inshellisense@0.0.1-rc.4/node_modules/@microsoft/inshellisense/build/runtime/utils.js:8:9       at new Promise (<anonymous>)       at file:///Users/floriaaan/Library/pnpm/global/5/.pnpm/@microsoft+inshellisense@0.0.1-rc.4/node_modules/@microsoft/inshellisense/build/runtime/utils.js:7:12       at f (file:///Users/floriaaan/Library/pnpm/global/5/.pnpm/@withfig+autocomplete@2.640.3/node_modules/@withfig/autocomplete/build/pnpm.js:1:1143)       at file:///Users/floriaaan/Library/pnpm/global/5/.pnpm/@withfig+autocomplete@2.640.3/node_modules/@withfig/autocomplete/build/pnpm.js:1:1263       at Generator.next (<anonymous>) {     code: 'ERR_INVALID_ARG_TYPE'   } }
Environment

OS: macOS Sonoma 14.2
Output of inshellisense --version: 0.0.1-rc.4
Nodejs Version: v18.16.1

Closing as this was fixed since we no longer depend on key bindings in 0.0.1-rc.5

I still have this same error on 0.0.1-rc.7


Update Documentation with New Helm Output option

🚀 Feature Description
As a developer, I'd like to be able to see helm as an output format, in order to know how to utilize the helm generation feature.
✔ Goals

[ ] Add Helm argument to the output format argument list in the generate page

I did with the code changes - just forgot to publish the updated docs I think - will publish now

Yeah that was it - doh! 😄
https://prom3theu5.github.io/aspirational-manifests/generate-command.html#helm-chart


Rename isSet

isSet naming is too confusing, imo. My first guess would be that it is either has or is(Set).

allUniq

:+1:

Renaming the function R.allUniq would be a huge improvement. The other option is to deprecate the function, since its functionality can (less efficiently) be achieved via R.uniq(xs).length === xs.length. I'm fine with keeping this function even though I've never used it, as it is well specified.

I like it too,


Queries with DEFINE statement are not executed

When i try to execute some query like DEFINE INDEX.. or DEFINE ANALYZER.. the execution never ends and the application stays
locked waiting for the end. But other queries like SELECT, UPDATE, DELETE... work fine.
Obs: The DEFINE execution never ends, and the change do not reflet on data base.
Connection:
private async _connectAndSignIn() {
    const username = this.config.get<string>('SURREAL_DB_USER');
    const password = this.config.get<string>('SURREAL_DB_PASSWORD');
    const namespace = this.config.get<string>('SURREAL_DB_NS');
    const database = this.config.get<string>('SURREAL_DB_DATABASE');
    const dbUrl = this.config.get<string>('SURREAL_DB_PORT');

    this.logger.log(
      "Connecting to local Surrealdb ${inspect({
        namespace,
        database,
        url: dbUrl,
      })}",
    );
    try {
      await this.db.connect(dbUrl);

      this.logger.log("Surrealdb connection works");

      await this.db.use({ ns: namespace, db: database });

      await this.db.signin({
        username: username,
        password: password,
      });

      this.logger.log("Surrealdb signIn works");
    } catch (error) {
      this.logger.error(
        '_connectAndSignIn error: ',
        inspect({ error }, { depth: null }),
      );
    }
  }

Query method:
async query<T = any>(query: string): Promise<T[]> {
    try {
      const result = (await this.db.query(query)) as T[];

      return result;
    } catch (error) {
      const err = `query error: ${inspect({ error })}`;
      this.logger.error(err);
      throw new InternalServerErrorException(error);
    }
  }

Query:
DEFINE ANALYZER simplePt TOKENIZERS blank, class, punct FILTERS snowball(Portuguese), edgengram(1,3);
App log:

What version are you running?

SurrealDB version: 1.5.2
surrealdb.node: 0.3.0

I'd recommend trying 1.0.0-beta.1 tho you have to check the readme as usage has changed a little


On GUI crash, have button to access log files easily

Example of the idea

Requires custom error on https://github.com/SlimeVR/SlimeVR-Server/blob/e8afb49685854d636905c7d545b7832060e89dc3/gui/src-tauri/src/main.rs#L308-L310


Azure Data Studio does not remember the cursor position when switching between multiple tabs

Azure Data Studio Version:

Azure Data Studio does not remember the cursor position when switching between multiple tabs.  This was fixed months ago and it seem like this bug was reintroduced to Azure Data Studio for some reason.
Steps to Reproduce:

Have multiple tabs of files open in Azure Data Studio.
Click on the first tab and ensure there is multiple lines that require you to scroll to the bottom. Then place your cursor at the bottom.
Now click on another tab then click back on the first tab.
You will see the azure data studio does not remember when your cursor was at and you will have to scroll back to where you were as.

@JASM2007 this should be fixed in the latest insiders builds.  And will be fixed in the stable build planned for later this week.  Sorry for the inconvenience from this regression.


AuthorizationPermissionMismatch when trying to read blob files via DefaultAzureCredential() from cloud shell

Package Name: azure-storage-blob
Package Version: 12.19.0
Operating System: Ubuntu 22.04 LTS
Python Version: 3.10.12

Describe the bug
I am unable to read/download blobs using via DefaultAzureCredential(). I am able to use powershell to read the same blob with the same service account just fine...
To Reproduce
Steps to reproduce the behavior:
I've used az storage account show -n <REDACTED> -g <REDACTED> --query "primaryEndpoints.blob" to get the correct connection string...

Open an azure cloud shell
python3 -m pip install azure-storage-blob azure-identity
Run the following code in an interactive python3 shell
from azure.identity import DefaultAzureCredential
from azure.storage.blob import BlobServiceClient
blob_service_client = BlobServiceClient("https://<REDACTED>.blob.core.windows.net/", DefaultAzureCredential())
container_client = blob_service_client.get_container_client(container='<REDACTED>')
container_client.download_blob('test.yaml').readall()

  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.9/site-packages/azure/core/tracing/decorator.py", line 78, in wrapper_use_tracer
    return func(*args, **kwargs)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_container_client.py", line 1313, in download_blob
    return blob_client.download_blob(
  File "/usr/lib/python3.9/site-packages/azure/core/tracing/decorator.py", line 78, in wrapper_use_tracer
    return func(*args, **kwargs)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_blob_client.py", line 942, in download_blob
    return StorageStreamDownloader(**options)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_download.py", line 366, in __init__
    self._response = self._initial_request()
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_download.py", line 462, in _initial_request
    process_storage_error(error)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_shared/response_handlers.py", line 184, in process_storage_error
    exec("raise error from None")   # pylint: disable=exec-used # nosec
  File "<string>", line 1, in <module>
azure.core.exceptions.HttpResponseError: This request is not authorized to perform this operation using this permission.
RequestId:<REDACTED>
Time:2024-03-01T10:50:03.9012904Z
ErrorCode:AuthorizationPermissionMismatch
Content: <?xml version="1.0" encoding="utf-8"?><Error>AuthorizationPermissionMismatch<Message>This request is not authorized to perform this operation using this permission.
RequestId:<REDACTED>
Time:2024-03-01T10:50:03.9012904Z</Message></Error>

However, when trying to do the same thing using powershell, it works fine...
$storageAccount = Get-AzStorageAccount -ResourceGroupName <REDACTED> -Name <REDACTED>
(Get-AzStorageBlobContent -Container "<REDACTED>" -Blob "test.yaml" -Destination "/home/dylan/test" -Context $storageAccount.Context).Content
Here i receive the content of the file ok!
(I also obviously have access to download these blobs via the Azure Portal GUI)
Expected behavior
I expect the python sdk to receive the blob content just the same way as the powershell code does above.
Screenshots
None
Additional context
I've been following this page as a guide: https://learn.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-python
Is this a bug in the python SDK? Is there something else I need to give to the python SDK in order to identify myself?
I have reproduced this error on in the Azure portal Cloud Shell, Using my local machine with an az login using my account, using az login --service-principal, and by using EnvironmentCredential variables as per https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/TROUBLESHOOTING.md#troubleshoot-environmentcredential-authentication-issues.

Thanks for reaching out.
DefaultAzureCredential is a chain of different credentials.
It is possible that a credential before powershell failed and it did not try powershell credential.
Could you enable debugging and share the logs?
You can add code like:
import logging
logging.basicConfig(filename='c:/temp/log.log', level=logging.DEBUG)
to enable logging.

Heya,
Here's the logs as requested...
INFO:azure.identity._credentials.environment:No environment configuration found.
INFO:azure.identity._credentials.managed_identity:ManagedIdentityCredential will use Cloud Shell managed identity
DEBUG:azure.identity._internal.decorators:EnvironmentCredential.get_token failed: EnvironmentCredential authentication unavailable. Environment variables are not fully configured.
Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot this issue.
Traceback (most recent call last):
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/identity/_internal/decorators.py", line 33, in wrapper
    token = fn(*args, **kwargs)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/identity/_credentials/environment.py", line 150, in get_token
    raise CredentialUnavailableError(message=message)
azure.identity._exceptions.CredentialUnavailableError: EnvironmentCredential authentication unavailable. Environment variables are not fully configured.
Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot this issue.
INFO:azure.core.pipeline.policies.http_logging_policy:Request URL: 'http://localhost:50342/oauth2/token'
Request method: 'POST'
Request headers:
    'Metadata': 'REDACTED'
    'User-Agent': 'azsdk-python-identity/1.15.0 Python/3.9.14 (Linux-<IP_ADDRESS>-microsoft-standard-x86_64-with-glibc2.35) cloud-shell/1.0'
A body is sent with the request
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): localhost:50342
DEBUG:urllib3.connectionpool:http://localhost:50342 "POST /oauth2/token HTTP/1.1" 200 2422
INFO:azure.core.pipeline.policies.http_logging_policy:Response status: 200
Response headers:
    'X-Powered-By': 'REDACTED'
    'Content-Type': 'application/json; charset=utf-8'
    'Content-Length': '2422'
    'ETag': 'W/"976-lcodna4W9NJ8U/mTFlHamPjfhAM"'
    'Date': 'Tue, 05 Mar 2024 09:16:07 GMT'
    'Connection': 'keep-alive'
    'Keep-Alive': 'REDACTED'
DEBUG:msal.token_cache:event={
    "data": {},
    "response": {
        "access_token": "********",
        "expires_in": "4442",
        "expires_on":<PHONE_NUMBER>,
        "not_before": "1709628919",
        "refresh_token": "********",
        "resource": "https://storage.azure.com/",
        "token_type": "Bearer"
    },
    "scope": [
        "https://storage.azure.com/"
    ]
}
DEBUG:azure.identity._internal.get_token_mixin:CloudShellCredential.get_token succeeded
DEBUG:azure.identity._internal.decorators:ManagedIdentityCredential.get_token succeeded
DEBUG:azure.identity._internal.decorators:[Authenticated account] Client ID: <REDACTED>. Tenant ID: <REDACTED>. User Principal Name: unavailableUpn. Object ID (user): <REDACTED>
INFO:azure.identity._credentials.chained:DefaultAzureCredential acquired a token from ManagedIdentityCredential
INFO:azure.core.pipeline.policies.http_logging_policy:Request URL: 'https://<REDACTED>.blob.core.windows.net/dsl-images/test.yaml'
Request method: 'GET'
Request headers:
    'x-ms-range': 'REDACTED'
    'x-ms-version': 'REDACTED'
    'Accept': 'application/xml'
    'User-Agent': 'azsdk-python-storage-blob/12.19.0 Python/3.9.14 (Linux-<IP_ADDRESS>-microsoft-standard-x86_64-with-glibc2.35) cloud-shell/1.0'
    'x-ms-date': 'REDACTED'
    'x-ms-client-request-id': '<REDACTED>'
    'Authorization': 'REDACTED'
No body was attached to the request
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): <REDACTED>.blob.core.windows.net:443
DEBUG:urllib3.connectionpool:https://<REDACTED>.blob.core.windows.net:443 "GET /dsl-images/test.yaml HTTP/1.1" 403 279
INFO:azure.core.pipeline.policies.http_logging_policy:Response status: 403
Response headers:
    'Content-Length': '279'
    'Content-Type': 'application/xml'
    'Server': 'Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0'
    'x-ms-request-id': '<REDACTED>'
    'x-ms-client-request-id': '<REDACTED>'
    'x-ms-version': 'REDACTED'
    'x-ms-error-code': 'AuthorizationPermissionMismatch'
    'Date': 'Tue, 05 Mar 2024 09:16:07 GMT'
DEBUG:azure.storage.blob._generated._serialization:Ran into a deserialization error. Ignoring since this is failsafe deserialization
Traceback (most recent call last):
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_generated/_serialization.py", line 1542, in failsafe_deserialize
    return self(target_obj, data, content_type=content_type)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_generated/_serialization.py", line 1413, in __call__
    data = self._unpack_content(response_data, content_type)
  File "/home/dylan/.local/lib/python3.9/site-packages/azure/storage/blob/_generated/_serialization.py", line 1571, in _unpack_content
    raise ValueError("This pipeline didn't have the RawDeserializer policy; can't deserialize")
ValueError: This pipeline didn't have the RawDeserializer policy; can't deserialize
To note: the Object ID (user) given is the same one when running az ad signed-in-user show in an azure cloud shell

@vincenttran-msft @jalauzon-msft seems like the app successfully got the token using the cloud shell extra id.
Could you check what permission the CloudShellCredential needs to access the blob?

My account has the Contributor BuiltInRole, so I believe I should just work as-is?. Also when using the powershell commands from the same cloud shell session I do have access, and I also have access to read/write blobs in the Azure portal UI, so I don't think it's a permissions issue?

Hi @OCDolan, this is a pretty common issue we get, and the likely cause is you need one of the "Storage Blob Data *" built-in roles as well to use these credentials with the SDK. There is Storage Blob Data Contributor, Owner, and Reader. These are separate from the built-in role of Contributor.
I don't fully understand why this is the case, but CloudShell/Azure CLI/Portal have a special auth mechanism that allows them to work without these roles. The SDK makes direct REST calls to the service, without any pre-authentication and therefore requires the Storage specific roles to be present. I will do some research internally and find out why specifically this is and get back to you but for now, try granting your account one of the Storage specific roles and it should work.

@OCDolan, thanks for confirming. Glad the fix worked for you.
So, I checked with our Powershell team and did learn why this is the case. CloudShell (as well as Azure CLI and Portal) do in fact work a little differently. When you run a command like Get-AzStorageAccount, PSH makes a call to fetch the Storage account keys and cache them into memory for that session. Then when you make blob requests, it will actually use the account key to authenticate the request. The "Contributor" role is enough permission to allow you to access the account keys on the account through the management plane.
This differs for the SDK as DefaultAzureCredential just grabs the identity from CloudShell, not the session (with the account key) and then tries to use OAuth with that identity. OAuth for dataplane operations (Blob access) requires the "Storage Blob Data *" roles.
If you wanted to force CloudShell to use OAuth like the SDK, that could be done like this:
$ctx = New-AzStorageContext -StorageAccountName <REDACTED>
(Get-AzStorageBlobContent -Container "<REDACTED>" -Blob "test.yaml" -Destination "/home/dylan/test" -Context $ctx).Content

Hopefully that makes some sense and helps to clarify what is happening. I am going to close this as resolved now but feel free to reach out if you have any more questions. Thanks.

Thanks for getting back to me @jalauzon-msft !
Ah that makes a bit more sense, thanks. Could that explanation be added to the documentation for the azure blob SDKs? It feels very un-intuitive that the permissions required to read a storage blob can differ depending on the language that you are using.


libgcc_s.so is missing from glibc when cross compiling

Issue description
I'm not sure what the intended behavior actually is, but there is an issue with libgcc_s.so when cross-compiling, or perhaps the native case is actually incorrect.
I came across this problem when debugging why tmon crashes with the error: libgcc_s.so.1 must be installed for pthread_cancel to work when exiting, but only when it is cross-compiled. I noticed that, for native builds only, glibc copies libgcc_s.so from bootstrap gcc. This  libgcc_s.so from the bootstrap tools is present in the glibc used to build all other derivations, which does not seem right to me (it doesn't seem like normal derivations should have access to any libraries/binaries from the the bootstrap tools).
pthreads needs libgcc_s.so, and it is able to find it when built natively because libgcc_s.so is part of glibc, which is on the RPATH. When cross-compiling, glibc does not have libgcc_s.so, and the gcc libs are not on the RPATH, so pthreads cannot find libgcc_s.so.
I can see that there are a number of cases where people have worked around this problem in nixpkgs, by manually linking to libgcc_s. This solves the problem for tmon, but I still think there is a bug because of the different behavior between native and cross builds.
cc @vcunat

See https://github.com/NixOS/nixpkgs/pull/36948.

We really should try to get this fixed for next release! Please :).

I stumbled on it today as well. I think I vaguely understand why loss of libgcc_s.so.1 happens. I'd say it's a bug. Native and cross builds should both have (or both not have) libgcc_s.so.1. As native does have it let's try to alight cross to it (unless it's too hard, then we can try the other way around).
The real project to provide libgcc_s.so.1 is gcc. The reason we seem to copy the file into glibc is to fool bootstrapTools (and probably gcc itself) to workaround missing RPATHs for binaries and libraries. Let's ignore the complications and focus on glibc's way to pull libgcc_s.so in.
Native case pulls libgcc_s.so.1 in glibc derivation in preInstall from ${stdenv.cc.cc}/lib/libgcc_s.so.1: https://github.com/NixOS/nixpkgs/blob/b3da007795a64366c1e5a20227ce0eac6bb16e91/pkgs/development/libraries/glibc/default.nix#L69-L76
A few notes:

it always happens (regardless of bootstrap stages or not)
it uses gcc's ${stdenv.cc.cc}/lib/libgcc_s.so.1 path

Cross case goes a great length to break this mechanism. A few things I noticed:

The path is invalid if gcc is a cross-compiler (build != host). The correct path would be something like ${stdenv.cc.cc}/${stdenv.hostPlatform.config}/lib/libgcc_s.so.1
preInstall is completely removed for cross: https://github.com/NixOS/nixpkgs/blob/b3da007795a64366c1e5a20227ce0eac6bb16e91/pkgs/development/libraries/glibc/common.nix#L295 (probably, out of fear to copy library for a wrong target?)
[I'm not very certain here] Cross-built glibc (say, via pkgsCross.aarch64-multiplatform.glibc or via pkgsCross.aarch64-multiplatform.stdenv.cc.libc) both use gcc without shared library support. Thus gcc does not provide any libgcc_s.so.1 at that stage.
make-bootstrap-tools also assumes non-cross paths even for cross builds: https://github.com/NixOS/nixpkgs/blob/b3da007795a64366c1e5a20227ce0eac6bb16e91/pkgs/stdenv/linux/make-bootstrap-tools.nix#L130

I 'll try to tackle a few of these problems.

Oh, it's even trickier: ${stdenv.cc.cc}/lib/libgcc_s.so.1 is a valid path only for bootstrapTools's gcc (as nixpkgs's gcc install those files to ${stdenv.cc.cc.lib}/lib/libgcc_s.so.1 output). gcc never gets built by nixpkgs gcc:
$ nix build -L --impure --expr 'with import <nixpkgs> {}; runCommandCC "hm?" {} "gcc --version | head -n 1; strings ${stdenv.cc.libc}/lib/libc.so.6 | fgrep GCC"'
hm?> gcc (GCC) 11.3.0
hm?> GCC: (GNU) 8.3.0

Here we see that on a system with gcc-11 as a default glibc is built by gcc-8.3.0 from bootstrapTools. It's not even a gcc-static (used by cross builds to get an equivalent).

Removing libgcc_s.so.1 from glibc also needs a bit of work. Added TODOs in https://github.com/NixOS/nixpkgs/pull/187225

This is most likely resolved now by PR #209870 or related changes.  Or at least it needs more concrete reformulation of what's wrong, based on the changed situation.

Ah, it still doesn't find the library, at least by the reproducer described in #213453  (so let's keep that one open)

The complete fix is in https://github.com/NixOS/nixpkgs/pull/238154


fix(overflow-menu): remove add from menu

Closes https://github.com/carbon-design-system/carbon-components/issues/2248
Removes an incorrect example of having an Add +  button in an OverflowMenu

Oops missed visual review mark - My apologies. @jeanservaas I think the change is straightforward as this merely removes the usage pattern as you requested, but please don't hesitate to raise any concerns if there are. Thanks!


#777 implement reusable select component

Created new folder for reusable dropdown component. Inside that folder, I put the dropdown component and a "test form" component to test the dropdown component.
resolves #777

And we are waiting for #779 to be merged so that we can start writing tests

Thanks for working on this @asiahaslam. I'm really happy to see people writing some good React code. Thanks to you too @Aleks1908


Compatibility Issue: Plugin Incompatible with Latest App and Firebase Versions

I'm encountering a compatibility issue with a custom plugin when integrating it with the latest app and Firebase versions. The build fails due to a mismatch between the Java and Kotlin target versions (Java 1.8 vs. Kotlin 17) and conflicts with the Firebase dependencies. The plugin needs to be updated to align with the app's configuration, including the JVM target version and Firebase library versions, to ensure it compiles and runs correctly.
Also facing conflict with firebase plugins.

The new version 1.3.1 now includes the related fixes.


[DO NOT REVIEW] GEODE-7465: Set eventProcessor to null in serial AEQ when it is stopped

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@agingade: Thats great. Do you want to push test to this branch?


actions: bump node 18.17.1

Applied mkpr on .github/workflows/*.yml
sed s/18.17.0/18.17.1/

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.883%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
109

Relevant Lines:
182

💛  - Coveralls


Post release automated changes for core releases

Post release automated changes for azure-core-tracing

API change check
API changes are not detected in this pull request.


Fix Juno snapshots path

It looks like the main snapshots directory inside the tar file was renamed from juno_mainnet to juno-mainnet. I had an older snapshot tar file, which when I unzipped created snapshots/juno_mainnet. However, upon downloading the latest, it looks like the main directory is now snapshots/juno-mainner. Was pulling my hair out on why my sync was starting from the very beginning haha.

Thanks for reporting that! We will just update folder name in the snapshot to not make any confusion as same path is already used in other docs or tutorials


Make build fails with error

Describe the bug
make -j1 build fails with error
To Reproduce
Steps to reproduce the behavior:

Download https://github.com/lensapp/lens/archive/v4.1.1.tar.gz
Decompress and enter intro directory
Do make -j1 build
After several time, see error

[compile:renderer] yarn run compile:renderer exited with code 0
  • electron-builder  version=22.7.0 os=5.10.16-arch1-1
  • loaded configuration  file=package.json ("build" field)
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • rebuilding native dependency  name=node-pty version=0.9.0
  • packaging       platform=linux arch=x64 electron=9.4.0 appOutDir=dist/linux-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip size=73 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip duration=5.161s
  • file source doesn't exist  from=/build/lens/src/lens-4.1.1/locales
  • building        target=snap arch=x64 file=dist/Lens-4.1.1.amd64.snap
  • building        target=AppImage arch=x64 file=dist/Lens-4.1.1.x86_64.AppImage
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z size=1.6 MB parts=1
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z size=1.5 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z duration=646ms
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z duration=703ms
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z size=1.6 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z duration=705ms
  • cannot move downloaded into final location (another process downloaded faster?)  path=/build/.cache/electron-builder/appimage/appimage-12.0.1
                                                                                tempFile=/build/.cache/electron-builder/appimage/680898106
                                                                                error=rename /build/.cache/electron-builder/appimage/680898106 /build/.cache/electron-builder/appimage/appimage-12.0.1: file exists
  • building        target=deb arch=x64 file=dist/Lens-4.1.1.amd64.deb
  ⨯ Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage  stackTrace=
                                                                                Error: Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage
                                                                                at FpmTarget.computeFpmMetaInfoOptions (/build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/targets/fpm.ts:82:13)
                                                                                at FpmTarget.build (/build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/targets/fpm.ts:135:24)
                                                                                at /build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/platformPackager.ts:133:11
                                                                                at async Promise.all (index 0)
                                                                                at AsyncTaskManager.awaitTasks (/build/lens/src/lens-4.1.1/node_modules/builder-util/src/asyncTaskManager.ts:65:25)
                                                                                at Packager.doBuild (/build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/packager.ts:456:5)
                                                                                at executeFinally (/build/lens/src/lens-4.1.1/node_modules/builder-util/src/promise.ts:12:14)
                                                                                at Packager._build (/build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/packager.ts:373:31)
                                                                                at Packager.build (/build/lens/src/lens-4.1.1/node_modules/app-builder-lib/src/packager.ts:337:12)
                                                                                at executeFinally (/build/lens/src/lens-4.1.1/node_modules/builder-util/src/promise.ts:12:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:63: build] Error 1

Environment (please complete the following information):

Lens Version: 4.1.1
OS: ArchLinux
Installation method: Trying to build from source
Versions: nodejs-lts-erbium-12.20.1-1  npm-6.14.11-1  yarn-1.22.10-1

Same error with 4.1.2
[compile:renderer] yarn run compile:renderer exited with code 0
  • electron-builder  version=22.7.0 os=5.10.16-arch1-1
  • loaded configuration  file=package.json ("build" field)
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • rebuilding native dependency  name=node-pty version=0.9.0
  • packaging       platform=linux arch=x64 electron=9.4.0 appOutDir=dist/linux-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip size=73 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip duration=5.343s
  • file source doesn't exist  from=/build/lens/src/lens-4.1.2/locales
  • building        target=snap arch=x64 file=dist/Lens-4.1.2.amd64.snap
  • building        target=AppImage arch=x64 file=dist/Lens-4.1.2.x86_64.AppImage
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z size=1.6 MB parts=1
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z size=1.5 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z duration=843ms
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z duration=861ms
  • building        target=deb arch=x64 file=dist/Lens-4.1.2.amd64.deb
  ⨯ Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage  stackTrace=
                                                                                Error: Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage
                                                                                at FpmTarget.computeFpmMetaInfoOptions (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/targets/fpm.ts:82:13)
                                                                                at FpmTarget.build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/targets/fpm.ts:135:24)
                                                                                at /build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/platformPackager.ts:133:11
                                                                                at async Promise.all (index 0)
                                                                                at AsyncTaskManager.awaitTasks (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/asyncTaskManager.ts:65:25)
                                                                                at Packager.doBuild (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:456:5)
                                                                                at executeFinally (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/promise.ts:12:14)
                                                                                at Packager._build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:373:31)
                                                                                at Packager.build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:337:12)
                                                                                at executeFinally (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/promise.ts:12:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:63: build] Error 1

Can you try running make -B?

@jim-docker same error
[compile:renderer] yarn run compile:renderer exited with code 0
  • electron-builder  version=22.7.0 os=5.10.16-arch1-1
  • loaded configuration  file=package.json ("build" field)
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • rebuilding native dependency  name=node-pty version=0.9.0
  • packaging       platform=linux arch=x64 electron=9.4.0 appOutDir=dist/linux-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip size=73 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-linux-x64.zip duration=5.985s
  • file source doesn't exist  from=/build/lens/src/lens-4.1.2/locales
  • building        target=snap arch=x64 file=dist/Lens-4.1.2.amd64.snap
  • building        target=AppImage arch=x64 file=dist/Lens-4.1.2.x86_64.AppImage
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z size=1.6 MB parts=1
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z size=1.5 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-<IP_ADDRESS>z duration=674ms
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z duration=902ms
  • building        target=deb arch=x64 file=dist/Lens-4.1.2.amd64.deb
  ⨯ Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage  stackTrace=
                                                                                Error: Please specify project homepage, see https://electron.build/configuration/configuration#Metadata-homepage
                                                                                at FpmTarget.computeFpmMetaInfoOptions (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/targets/fpm.ts:82:13)
                                                                                at FpmTarget.build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/targets/fpm.ts:135:24)
                                                                                at /build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/platformPackager.ts:133:11
                                                                                at async Promise.all (index 0)
                                                                                at AsyncTaskManager.awaitTasks (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/asyncTaskManager.ts:65:25)
                                                                                at Packager.doBuild (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:456:5)
                                                                                at executeFinally (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/promise.ts:12:14)
                                                                                at Packager._build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:373:31)
                                                                                at Packager.build (/build/lens/src/lens-4.1.2/node_modules/app-builder-lib/src/packager.ts:337:12)
                                                                                at executeFinally (/build/lens/src/lens-4.1.2/node_modules/builder-util/src/promise.ts:12:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:63: build] Error 1

I can reproduce using https://github.com/lensapp/lens/archive/v4.1.2.tar.gz on Ubuntu 20.04. You should be able to workaround this by adding in the metadata section of the ./package.json:
  "homepage": "https://github.com/lensapp/lens",

Or use your fork, if you have one(?)
There might be some magic to getting homepage when building in a cloned repo. We'll look to see if there is a more proper solution for working with an archive.

@jim-docker yes, add homepage in ./package.json do the trick. I do it with sed:
sed -i '3 i "homepage": "https://k8slens.dev",' package.json
make -j1 build

But as you say, there should be a more permanent solution. :-)


Error: Cannot find module './format'

Get that error after including the package as a nodejs module. Installing the 'format' node module doesn't resolve the issue.

I pushed a fix to github, can you update your package.json and point to this repo instead of specifying a version?
...
personality-text-summary: 'https://github.com/personality-insights/text-summary'
...

If it works I will publish the release

Thank you soo much! It's better.

I'm now getting the same error for the next line :

Error: Cannot find module './i18n/en'

(I was afraid I would, but couldn't passed the ./format part.)

Best regards,
Rob
Rob Morin                                                                                Systems Integration Architect/Developer
Silverpop, an IBM Company

Office:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>                                                                      6303 Barfield Rd
Atlanta, GA 30328                                                                                Twitter | Facebook | LinkedIn

----- Original message -----From: German Attanasio<EMAIL_ADDRESS>personality-insights/text-summary<EMAIL_ADDRESS>Rob Morin/Atlanta/IBM@IBMUS, Author<EMAIL_ADDRESS>Re: [personality-insights/text-summary] Error: Cannot find module './format' (#3)Date: Wed, Dec 14, 2016 2:21 PM
I pushed a fix to github, can you update your package.json and point to this repo instead of specifying a version?
...personality-text-summary: 'https://github.com/personality-insights/text-summary'...
If it works I will publish the release
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

German,

Thank you. I got it to work by providing ./i18n/en.js and ./i18n/es.js and commenting out the line that requires ja.js in the i18n.js file.

I still did not get it to work with V3 of Personality Insights.

So your fix addressed the primary problem that would have kept me stumped for days.  THANK YOU!!!

Have a great evening!Rob
Rob Morin                                                                                Systems Integration Architect/Developer
Silverpop, an IBM Company

Office:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>                                                                      6303 Barfield Rd
Atlanta, GA 30328                                                                                Twitter | Facebook | LinkedIn

----- Original message -----From: Rob Morin/Atlanta/IBMTo<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [personality-insights/text-summary] Error: Cannot find module './format' (#3)Date: Wed, Dec 14, 2016 2:37 PM
Thank you soo much! It's better.

I'm now getting the same error for the next line :

Error: Cannot find module './i18n/en'

(I was afraid I would, but couldn't passed the ./format part.)

Best regards,
Rob
Rob Morin                                                                                Systems Integration Architect/Developer
Silverpop, an IBM Company

Office:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>                                                                      6303 Barfield Rd
Atlanta, GA 30328                                                                                Twitter | Facebook | LinkedIn

----- Original message -----From: German Attanasio<EMAIL_ADDRESS>personality-insights/text-summary<EMAIL_ADDRESS>Rob Morin/Atlanta/IBM@IBMUS, Author<EMAIL_ADDRESS>Re: [personality-insights/text-summary] Error: Cannot find module './format' (#3)Date: Wed, Dec 14, 2016 2:21 PM
I pushed a fix to github, can you update your package.json and point to this repo instead of specifying a version?
...personality-text-summary: 'https://github.com/personality-insights/text-summary'...
If it works I will publish the release
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

This was fixed in v2.0.3. @bravehack feel free to open the issue again if this is not the case.
The new version also supports the new v3 API and should be backward compatible


Dots not displayed

Bug or feature request?
Bug
If it's a bug, please provide the full method to reproduce.
in the examples there is no typing animation (dots).

Sorry (typeSpeed for decrease typing). Closed/


Garbled on Windows CMD

As shown above, there are some issues with Win CMD.
There might be a useful issue that can help solve this problem. https://github.com/sirupsen/logrus/issues/496
By the way, I only can get readable output on Git Bash with no color output.

@kice hmmm, what shell is this?  Does it support any colors?

haven't heard back for a while, so closing.  if you can provide more info we can re-open.

Same problem for me, on windows 10, version: 0.8.1
The colour does work on the page that comes up when you just call todolist, but it garbles text just like @kice had on listing todos:

Dupe of #143


Does this app support to run in web mode

I've built it with flutter 1.6.4 successfully, but have no idea to run in browser.

It currently does not work on the web as some of the lower-level rendering methods used by Flare and Nima are not yet supported by Flutter Web.


incorporate other PRs, finish fixing timer handling

Description

stop the timer if timer is disabled
de-dupe env-file path referencing
ensure env file exists before service that references it
restart timer if timer changed

Issues Resolved
#477
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

i left out #483 for now; i don't personally have a need for it, and the comment context around the circumstances that call for it seem unlikely to hit production users, so figure if it's needed the request will be resurrected.

@nathwill any reason not to cut a release at this point?

@tas50 none i know of!


Design data release portal (website)

Overview
I want to create a website for publishing summary information about all our data releases. I want to have live statistics and figures that update as data or code changes. I also want to share the results and methods.

Plan A

Code the website in Jupyter notebooks and use Quarto to publish as a website.
Upload code to this GitHub repository.
Use Google Cloud Build to publish website to Cloud Run.

Reasoning for doing this is:

I want the site to update when code is updated. In this case, any change to the code in GitHub will trigger a new Cloud Build... build.
I want the site to update when data is updated. With Cloud Run instances running within my Google environment I can pull images/data/etc. from cloud storage without exposing any project specific information on GitHub. I could also have it rerun queries or analyses if needed because it will have project credentials.
I don't want to put any credentials or project information on GitHub.
I want interactive data exploration and figures which means Quarto and Plotly as opposed to PNGs that I could just link from a web page.

Plan B

Code the website using Jekyll with the Just the Docs theme or similar.
Upload code to this GitHub repo.
Use Google Cloud Build to publish website to Cloud Run

How to serve latest data + code?
I want to run the app in GCP so I can load the latest data to generate figures and metrics and with Cloud Build, each user will see a fresh server, that pulls the latest data. So that is solved regardless of the website technology.
How to serve interactive visualizations?
I think everything is going to be rendered when the app instance is launched, so I don't need Shiny or anything. This blog post indicates you need to use Shiny to serve dynamic content, but I'm not sure what that means. Regardless, I don't think we need it.
So then, the value of using Quarto is you can see the actual code/queries that are being used to generate each result. I could copy-paste code/queries into a web page but then there is no functional connection to the results and so you have to apply significant effort to keep everything in sync.


Vulnerability roundup 111: mruby-3.0.0: 5 advisories [9.1]

search, files

[ ] CVE-2022-0525 CVSSv3=9.1 (nixos-21.11, nixos-unstable)
[ ] CVE-2021-46020 CVSSv3=7.5 (nixos-21.11, nixos-unstable)
[ ] CVE-2022-0240 CVSSv3=7.5 (nixos-21.11, nixos-unstable)
[ ] CVE-2022-0481 CVSSv3=7.5 (nixos-21.11, nixos-unstable)
[ ] CVE-2022-0326 CVSSv3=5.5 (nixos-21.11, nixos-unstable)

CVE details
CVE-2022-0525
Out-of-bounds Read in Homebrew mruby prior to 3.2.
CVE-2021-46020
An untrusted pointer dereference in mrb_vm_exec() of mruby v3.0.0 can lead to a segmentation fault or application crash.
CVE-2022-0240
mruby is vulnerable to NULL Pointer Dereference
CVE-2022-0481
NULL Pointer Dereference in Homebrew mruby prior to 3.2.
CVE-2022-0326
NULL Pointer Dereference in Homebrew mruby prior to 3.2.

Scanned versions: nixos-21.11: 2128d0aa28e; nixos-unstable: 5aaed40d22f.
Cc @nicknovitski

CVE-2022-0525: 3.0.0 not vulnerable. Bug is in keyword argument support of (unreleased) 3.1.0 which is quite different from 3.0.0's implementation. Tested personally.

CVE-2021-46020: I don't think 3.0.0 is vulnerable as it doesn't implement the variant of shift that tries to coerce an argument to an integer.

CVE-2022-0240: the provided example doesn't exhibit the issue, but it couldn't hurt adding the extra check anyway.

CVE-2022-0481: 3.0.0 not vulnerable. Issue is in function added for ruby 3.0 keyword argument support, which hasn't made it into a release yet.

Let's close it.


Add Floating Feedback Button and Customizable Page Titles

What type of PR is this?
Please check the category that applies:

[x] Feature
[ ] Bug Fix
[ ] Refactor
[x] Documentation Update

Description
This pull request introduces two main enhancements to the OpenFeedback plugin:

Floating Feedback Button:

Added the ability to render the feedback button as a floating action button (FAB) anywhere on the page. This is customizable using the floating prop and can be positioned with inline styles.
Updated Root.tsx to demonstrate the floating button implementation with a feedback icon.

Customizable Page Titles and Subtitles:

Modified the OpenFeedbackPage component to allow passing custom titles and subtitles via props. This enables more flexibility when integrating the feedback page into different sections of the Backstage app.
Included unit tests to verify that the custom title and subtitle are correctly rendered.

Related Issues
(No specific issues linked)
Testing

[x] I have included or updated unit tests for my changes.
[x] I would like some help writing tests.
[ ] These changes do not require tests.

Hey! 👋
Some cool stuff in here! 🚀
Thanks a lot!
Will take a look 👀

added changes from https://github.com/Parsifal-M/backstage-open-feedback/pull/48#issuecomment-2265308474

added changes from #48 (comment)

Thanks a lot!
I have to run for the day now 😢
Will try give it a proper review later today/weekend and get back to you!
Thanks again!  🚀

LGTM!
Well Done! Awesome stuff 🚀
Will try set some time aside this week to release this 😄
Thanks again!

Brilliant!!
Happy to help!
Thank you so much for the review! 🥇


[google_sign_in] Latest Android dependencies & added NonNull annotations

This upgrade of dependencies when used in conjunction with the other new firebase plugin versions causes problems due to the transitive android.arch.core version 1.1.0 dependencies from play-services-auth.
When mixing the 1.1.0 and 1.1.1 versions the dex fails as follows:
Gradle build fails while trying to dex with "Program type already present: android.arch.core.util.Function"

see: https://stackoverflow.com/questions/50524672/build-fails-with-program-type-already-present-android-arch-core-util-function
As a workaround until 'play-services-auth' bumps it's dependency I recommend either explicitly specifying version 1.1.1 of these libraries as a dependency or adding a note in the README documentation.
implementation "android.arch.core:runtime:1.1.1"
implementation "android.arch.core:common:1.1.1"

@JamesMcIntosh Would adding:
implementation "android.arch.core:runtime:1.1.1"
implementation "android.arch.core:common:1.1.1"

To this components build.gradle help? If so I will update the PR.

In my project I have declared it as a dependency, I think it specifying it in this project should be enough to bring it all inline with the other firebase projects, I'll test it tomorrow morning and let you know.

I tested and adding them as api dependencies fixes the issue.
api "android.arch.core:runtime:1.1.1"
api "android.arch.core:common:1.1.1"

I'm feel more like this should be added to the README as a known issue for this release, suggested workaround as this is a problem of interop between libraries, but since they are both libraries un the same project maybe one of the Google crew would like to throw in their thoughts. @bparrishMines ?
I dug a little bit further to see where the dependency incompatibility came from:

cloud_firestore bumps the version of firebase
This in turn bumps the version of android.arch.lifecycle to 1.1.1
This bumps the transitive dependency of android.arch.lifecycle in google_sign_in
It falls apart because android.arch.core:runtime is not a dependency of android.arch.lifecycle so remains at 1.1.0.

+--- project :google_sign_in
|    \--- com.google.android.gms:play-services-auth:16.0.1
|         +--- com.google.android.gms:play-services-auth-api-phone:16.0.0
|         |    +--- com.google.android.gms:play-services-base:16.0.1
|         |    |    +--- com.google.android.gms:play-services-basement:16.0.1
|         |    |    |    \--- com.android.support:support-v4:26.1.0 -> 27.1.1
|         |    |    |         +--- com.android.support:support-compat:27.1.1
|         |    |    |         |    +--- com.android.support:support-annotations:27.1.1
|         |    |    |         |    \--- android.arch.lifecycle:runtime:1.1.0 -> 1.1.1
|         |    |    |         |         +--- android.arch.lifecycle:common:1.1.1
...
+--- project :cloud_firestore
|    \--- com.google.firebase:firebase-firestore:17.1.1
|         +--- android.arch.lifecycle:common:1.1.1 (*)
|         +--- android.arch.lifecycle:runtime:1.1.1 (*)

@JamesMcIntosh updated the PR to match latest status on master. This would be good for a review now as it's a lot simpler.

Looks good to me but one of the Google crew will need to accept it.

@ened It seems like the CI is not happy about the formatting, I think I can merge this after you fix the CI errors.

@cyanglaz The CI is not happy about other things, too - but I don't think it's related to my PR. Please take a look.

@cyanglaz it’s green


Status of this project

Sorry for not respecting the template, but since it's rather a question it doesn't make much sense.
Which is the status of this project? I'm a newcomer and noticed that at some point commits stopped but releases are still coming out. Was development moved to some JetBrains private repository and this repository is open for filing issues? README.md doesn't reflect this, so just wondering.
Thanks!

@kir4h From what I've picked up, I believe the plugin has been internalised by JetBrains, and that @VladRassokhin is contract-bound to not discuss, which is why issues & comments asking about the state of the repo are being ignored.
As Vlad works for JetBrains as one of their senior devs, my guess is that this plugin started as a side project to explore HCL support in IntelliJ, and that JetBrains decided to pull into their internal wing when it was clear how promising a plugin it was.
Hopefully what's happening now is that things are being ironed out before an official posting & rebranding occurs by JetBrains, at which point we'll see the plugin get some form of update (i.e the README being updated to point to YouTrack if JetBrains decides to track issues for it there).
It could also be that they're looking to integrate this into Space, but 🤷♂
Personally, I think the state this plugin currently is in is a little sad, as if the source code remained up to date, people like me would be happily contributing towards it - but it's a tough one for JetBrains: some people would be understandably angry if they were allowed to work on an open source project only to have it (and their contributed code) suddenly turn private due to contracts signed 6 months beforehand (if JetBrains didn't say that was going to happen), or otherwise people might not want to contribute to a project they've been told will turn private some day in the future (if JetBrains did tell).
Regardless, this is the state we're in: the plugin is on JetBrains rader and getting some love, but this repository is only good as an issue tracker for bugs right now.

Thanks @G-Rath. That's the impression I got, that at some point development was moved out from here for some reason. But I couldn't find any statement so I was curious if the reason was clear.
No matter the reason, I think either @VladRassokhin or Jetbrains should update the README on this project to reflect current status so that any developer landing here is pretty clear about it. (if PR or new issues are welcome or this repository is totally deprecated).

Hi, thanks for reminding about that.
Hopefully recent commit https://github.com/VladRassokhin/intellij-hcl/commit/0bd7ddd6153e62f7f7c92beb7c6b8de7880a6586 answers some questions.

is contract-bound to not discuss

Nope, I just had no time to publish update (it was prepared two months ago)

as if the source code remained up to date, people like me would be happily contributing towards it

Unfortunately, I've seen almost zero contributions over all four years of plugin, so closing sources is fine for me.

some people would be understandably angry if they were allowed to work on an open source project only to have it (and their contributed code) suddenly turn private due to contracts signed 6 months beforehand

Don't get it. I've asked all contributors about that and asked to sign CLA somewhere around February. Nothing is 'suddenly' turns private. I've just not had time to communicate that publically.

this repository is only good as an issue tracker for bugs right now.

Exactly.

Thanks for the clarifications @VladRassokhin, this is exactly the kind of information I was looking for :)


Hotel Website

Closes #37
Checklist:

[x] Added files or activities for learners.
[x]  Give the solution hints for fixing the bugs.
[x]  Reference material for well understand for learners.
[x]  Comment the code in the file where the learner needs to write the code.
[x] Added images so that learner compares their project after completing it.

Please review my MB.

Hey @deepak-prajapatii. We will review your PR as soon as possible.
Meanwhile, can you edit your comment with the numbering of all requirements you have covered into checkboxes?
For example -

Added files or activities for learners.

replaced by

[x] Added files or activities for learners.

Hey @deepak-prajapatii. We will review your PR as soon as possible.
Meanwhile, can you edit your comment with the numbering of all requirements you have covered into checkboxes?
For example -

Added files or activities for learners.

replaced by

[x] Added files or activities for learners.

Sure, I'll try to edit my comments as soons as possible.

Hey @deepak-prajapatii. We will review your PR as soon as possible.
Meanwhile, can you edit your comment with the numbering of all requirements you have covered into checkboxes?
For example -

Added files or activities for learners.

replaced by

[x]  Added files or activities for learners.

Sure, I'll try to edit my comments as soon as possible.

@amoghrajesh  How much time it takes to review  my PR?

Hey @deepak-prajapatii! Will get on it as soon as possible 🛩

Hey @deepak-prajapatii this is a good start to what you want to achieve through this MicroByte.
I would like to suggest a few changes to make it better:

The initial intro of HTML and CSS can be cropped out and maybe add it in the prerequisite.
I see you are using classes like bg-light which needs bootstrap too, so you probably need to make a mention of it.
The screenshot at the end doesn't relate to any of the code written so far, check if it is the right one.
You have a good file structure but which changes to make where are not very clear. (Maybe instead of designing all the pages, try to just post instructions for designing the index.html page that will make it much easier)
Although I really like your idea of TODO based filling of code by learners, you will need to provide more references as the learner can be extremely novice too.
My thinking is that you can make the learner design index.html and the rest of them can be added as learner issues. (This is my opinion, you can use what works best for you)

Again, great start. Make these small improvements and we shall re review it asap 😄

I like your ideas and try to make my this contribution at its best. Thanks for your suggestion. Once I have done, I'll mention you in comments. Thank you!

Sure @deepak-prajapatii.
Take your time and let's make this one a valuable one 😄

Sure @deepak-prajapatii.
Take your time and let's make this one a valuable one 😄

@amoghrajesh Done from my side, and there is no other framework like bootstrap in this micro bytes and I removed all other unnecessary things and provide more reference for the learner so that He/She will be able to contribute easily without any hesitation. Please review my PR.

Hey @deepak-prajapatii!
I was going through it and it is much improved now.
I still have a few more changes to request for:

You have not made a mention of which files to edit as a learner (A learner might not know if he has to edit index.html and the CSS file, he might pick about.html)
Provide some references for Activity 2 and Activity 3 as right now it is completely open and the learner won't know how to do it.
Correct typo 'index.html' in Activity 3 and put the file names in `` so that readme file marks them as code lines and it looks visible.

Great work on improving it. Hoping to see these changes soon too 🚀

Sure

@amoghrajesh  Done.

Hi @deepak-prajapatii !
This is pretty awesome now.
It looks very nice with individual tasks having hints of their own.
I like this content. Let's see what the other reviewers feel about this 😄
I am really impressed by you making timely changes and coming up with what it is right now 👍🏽
Start to think of some learner issues too until this one completes review

Sure and Thanks for guiding me.

@all-contributors kindly add @deepak-prajapatii for:

[x] code
[x] content
[x] ideas
[x] doc

@deepak-prajapatii Kindly showcase your new MicroByte in the #microbyte-showcase channel over at our slack workspace using this template.


[rv_core_ibex] Double Fault Handling

Double fault handling should be added into the ibex wrapper once lowrisc/ibex#1117 is ready

@tomroberts-lowrisc
@udinator
@sriyerg


why are old versions of pretty-assertion more popular?

Why do people prefer old versions? :confused:
How can we improve this?
Downloads as of 2017-10-17
... over the last 90 days

... per version

Version
Downloads
Release Date

0.1.0
105
March 26, 2017

0.1.1
44
March 29, 2017

0.1.2
16_725
March 29, 2017

0.2.0
708
April 29, 2017

0.2.1
6_295
June 24, 2017

0.3.0
26
August 30, 2017

0.3.1
18
August 31, 2017

0.3.2
20
August 31, 2017

0.3.3
18
September 1, 2017

0.3.4
573
September 2, 2017

0.4.0
8
October 15, 2017

v0.1.2

v0.2.1

v0.3.4

v0.4.0

Oh ! Good question. Is there a room for this question on some topics in https://users.rust-lang.org/ ?
Florent

There are 61 Cargo.toml files on github containing the string pretty_assertions  (as of 2017-10-18). I checked roughly 20 of them via blame. I compared the crate version in Cargo.toml with the most recent pretty_assertions version at the commit date the dependency was introduced.
Only 1 out of 20 crates (5%) was using an outdated version. Thats not a significant number.
Which means 95% were using the most recent version at the time of introducing pretty_assertions.
So, at first glance it looks like (a) earlier versions of pretty_assertions just had more impact on the crates and (b) a lot of people are not updating their dependencies very regularly. Could that be it?

v0.1.2 had 16_725 downloads in 152 days (110 per day)
v0.2.1 had 6_295 downloads in 116 days (54 per day)
v0.3.4 had 573 downloads in 46 days (12 per day)

A question comes to my mind: how relevant are those metrics (i.e. the number of downloads) for the popularity?
Consider this scenario: if a company use a crate in a CI and that CI is run hundreds of time a day (without any cache), can that distort the metrics?
Probably worth to know more about how those metrics work, maybe by discussing with the maintainers of crates.io.

yes, it's not a measure of "unique projects" and can be heavily distorted by single very CI-active projects. I think most important part is to ask people if there is something wrong with newer versions. :-) Like on the rust-lang post (or here).

I can speak from personal experience that I installed pretty_assertions during the pre-release development of my crate nifti, and it was quite useful then. Once that step was done, and the bugs were squashed, there was little incentive to keep it updated as a dev dependency.
I can also understand some reluctance from the fact that the crate is still on a 0 major version, which might give the wrong impression that a minor version bump requires adjustments to user code. When do you think it's appropriate to release v1.0?

@Enet4 thx for your feedback.
1.0 is a good question. A must-have is a good cross-platform story #1 and some bugs fixed in our dependency difference.rs (https://github.com/johannhof/difference.rs/issues/25). Apart from that I would just ask people what they expect from 1.0.