Option to disable the default routing on the index.html file

I'm submitting a...

[ ] Regression
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

I have an API that serves basic endpoints (get/post). I want to add an endpoint which serve a directory which contains files.
NestJS return an error 500 because I don't have an index.html file in the folder ...
Expected behavior

Add an option to disable the default routing on the index.html file and therefore be able to list the contents of a folder.
What is the motivation / use case for changing the behavior?

Build a basic API with get/post endpoints and also serve a directory on a custom path (for example: files uploaded or generated by the API).
Environment

Nest version: 7.0.0
@nestjs/serve-static version: 2.1.3

If you need more flexibility, take a look at app.useStaticAssets() method (or express.static directly https://expressjs.com/en/starter/static-files.html)
Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.


PowerShell v6-Alpha availability on Ubuntu 17.04

Just want to know the plan for supporting PowerShellCore in the upcoming Ubuntu Version 17.04.
I tried to installed it but I getting some library errors:
"Package libicu55 is not installed."
Steps to reproduce

Download PowerShell v<IP_ADDRESS>-alpha.18-1ubuntu<IP_ADDRESS>_amd64.deb
sudo dpkg -i powershell v<IP_ADDRESS>-alpha.18-1ubuntu<IP_ADDRESS>_amd64.deb

Expected behavior
Installation to complete without errors
Actual behavior
"Package libicu55 is not installed."
Environment data
Ubuntu 17.04

> $PSVersionTable

A simple rule is - first CoreFX/CoreCLR should add support a planform.

@iSazonov perhaps add the Resolution - External label?

@pcgeek86 The Issue is "Waiting external" 😄

Hi,
I've chatted with the corefs guys and they said that the latest portable dotnet core 2.0 works fine on Ubuntu 17.04:

and the PS run (not install) file  AppImage PowerShell-6.0.0-beta.1-x86_64.AppImage also works with Ubuntu 17.04
but not the other install .deb files.
So it's now should be possible to port PS to Ubuntu 17,04.

@joeyaiello @TravisEz13 CoreFX team support Ubuntu 17,04. What is a PowerShell team plan?

@joeyaiello @TravisEz13 @SteveL-MSFT  CoreFX team support Ubuntu 17,04. What is a PowerShell team plan?
Update: I see CoreFX team change their support policy. For .Net Core 1.0.1 they support specific versions. For .Net Core 2.0 they indicate the minimum OS version.

Not sure what the problem is here, but we should get this working.
Also, I should read the entirety of an issue before I start adding labels. ;)

So, what's the steps to install PowerShell in Ubuntu 17.04?
As of now, with PowerShell Beta.2, I'm getting the following message with .Net Core 2.0 Preview installed:
The following packages have unmet dependencies:
powershell : Depends: libicu55 but it is not installable
E: Unable to correct problems, you have held broken packages.
:)

@joeyaiello I expect that we should have new clear policy in our docs to support different OS versions. Because now dotnet support is based on minimal OS version our current policy "we follow CoreFX" is too vague - unlike a CoreFX, we have OS version dependencies.

Adding context from the duped issue. Apparently, running PowerShell dumps this:
powershell: pal_io.cpp:758: int64_t SystemNative_SysConf(SysConfName): Assertion false && "Unknown SysConfName"' failed.`

Talked to @janvorli and by portable, he means targeting runtime id linux-x64 and standalone (specify the runtime id when publishing, which will inclued all the assemblies and native shared libraries)

When running a generic app on .NET Core 1.1 and 2.0 I get no issues on my 17.04 machine, the same machine of the "duped" issue. The interface for certain system calls gets updated after a few kernel releases. I'd recommend depending on common shell builtins for getting system information or at least using the latest .NET Core at all times which does get tested on newer kernels AFAIK. I do realise that it is hard tracking a kernel that is not maintained in house

@TravisEz13 Good catch! Should we create a tracking Issue for  linux-x64  ?

One of more problematic libraries is ICU which gets updated each year. There are ways to have an older version installed side by side.

remind:
debian9 formal edition will release on july , please pay attention to compatible

@chuanjiao10 we are already compatible with debian 9.

@borgdylan CoreCLR is now resilient to ICU version, it should work with any future version up to version number 70, provided there is no breaking change in the interface. But the ICU doc says that stable APIs should stay in the future versions and we are using stable APIs only.

@iSazonov We will try to come up with a plan and get back to you on how to track the work.  I changed this issue to an enhancement for now.

@iSazonov I have filed an issue.  Thanks.

@MaximoTrinidad  See https://github.com/PowerShell/PowerShell/issues/3961 with PowerShell team plan.

The bug is because an incorrect string is being passed in: https://github.com/dotnet/corefx/blob/master/src/Native/Unix/System.Native/pal_io.cpp#L844 . The allowed strings are only three based on specific constants.

@borgdylan is there an issue opened for corefx?

I have opened an issue against corefx.

@borgdylan Please add cross link here to the Issue.

https://github.com/dotnet/corefx/issues/21386


Adding proxy values to API calls for schema generation

The company I work for requires proxies for service calls. I am getting timeouts for "yarn mesh dev" for all APIs I am trying to use, which always means I need to set up a proxy. I cannot find a way to set proxies for these service calls. Does this capability exist?

You can use customFetch to provide a custom fetch implementation that uses a custom proxy.
Closing this issue for now and feel free to create another one if that solution doesn't work for you.


Can't view missing module name when path is too long

VSCode Version:  0.10.11
OS Version: OS X 10.11.4

Steps to Reproduce:

start a project in a long path: eg /Users/accountname/work/my-project
require a file with the full path: var x = require(__dirname + "/file.js"),
launch your app and you'll get an exception with a character limit used up by the folder structure

Maybe the project's root directory could be truncated from the exception messages?

@benlowry in the April release we only truncate strings that are longer than 10000 characters.

Is there a way to view the full exception message coming?  I can't get from the truncated version in my screenshot to the full detail - copying the value also copies the snipped version.


Incorporate Credential Definitions into MeshModel for Improved Integration

Current Behavior

Currently, the MeshModel lacks the capability to determine the required credentials for a specific model, resulting in a lack of awareness regarding necessary credentials.
Desired Behavior

The desired enhancement involves integrating Credential Definitions into the MeshModel, allowing credentials to be bundled with the model. This proposal outlines the incorporation of Prometheus and Grafana credentials as examples:
{
  type : "object",
  title : "Prometheus",
  properties : {
    credentialName : {
      title : "Credential Name",
      type : "string",
      description : "Name of your credential"
    },
    secret : {
      type : "object",
      title : "Credential Secret",
      description : "Credential secret for the Prometheus instance",
      properties : {
        prometheusURL : {
          type : "string",
          title : "URL",
          description : "URL of the Prometheus instance"
        }
      },
      required : ["prometheusURL"]
    }
  },
  required : ["credentialName"]
}

{
  type : "object",
  title : "Grafana",
  properties : {
    credentialName : {
      title : "Credential Name",
      type : "string",
      description : "Name of your credential"
    },
    secret : {
      type : "object",
      title : "Credential Secret",
      description : "Credential secret for the Grafana instance",
      properties : {
        grafanaURL : {
          type : "string",
          title : "URL",
          description : "URL of the Grafana instance"
        },
        grafanaAPIKey : {
          type : "string",
          title : "API Key",
          description : "API Key for the Grafana instance"
        }
      },
      required : ["grafanaURL", "grafanaAPIKey"]
    }
  },
  required : ["credentialName"]
}

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I would like to work on this issue

I want to work on this. Please assign it to me.


Access Violation exception when running as a service

Description
When hosting a consumer as a windows service (using TopShelf), I am getting an access violation exception. Code works fine when running as  a console program.
Exception Info: System.AccessViolationException
at Confluent.Kafka.Impl.LibRdKafka+NativeMethods.rd_kafka_subscribe(IntPtr, IntPtr)
at Confluent.Kafka.Impl.SafeKafkaHandle.Subscribe(System.Collections.Generic.IEnumerable`1<System.String>)
at Confluent.Kafka.Consumer.Subscribe(System.String)
I tried running the service as an admin. However, I still see the access violation exception.

I never used topshelf, but you are probably dealing with #107 : it seems you are directly disposing your consumer before subscribing
Could you provide some reproductible code? We can't help from just those informations

I get this exception when we start the service. On start of service, I am setting a reader to the kafka topic. I am pasting the snippet below. Please note that when i run this from visual studio, everything works fine. We only see this when the code is installed as service. Exception details:
Exception Info: System.AccessViolationException
at Confluent.Kafka.Impl.LibRdKafka+NativeMethods.rd_kafka_subscribe(IntPtr, IntPtr)
at Confluent.Kafka.Impl.SafeKafkaHandle.Subscribe(System.Collections.Generic.IEnumerable`1<System.String>)
at Confluent.Kafka.Consumer.Subscribe(System.String)
Code:
-- Start of service
Task.Factory.StartNew(() => reader.ReadMessage(readTopic));
-- Reader here is  our custom class
public bool BeginRead(string topicName, string groupId, ITargetBlock target)
{
targetBuffer = target;
        Run_Poll(topicName);

        return true;
    }

public void Run_Poll(string topics)
{
try
{
sw = Stopwatch.StartNew();
            MessageConsumer.OnMessage += Consumer_OnMessage;

I was able to fix this after removing IDisposable interface on the classes that instantiated KafkaConsumer object. I am still investigating if we get the same behavior when we host the code in IIS.

in newer versions of the library, access violation exception's that were occurring due to an attempt to use a disposed consumer (librdkafka handle) should now produce object disposed exceptions. If access violation exceptions are still occurring in the above scenario with 0.11.5, that is an indication this is a different problem. I'm closing this under the assumption the problem is using a disposed consumer, however if access violation exceptions are still occurring with 0.11.5, please re-open.

For me, the problem was that I subscribed to NULL topic. Like:
consumer.Subscribe(null);

So it was a configuration problem. I'll leave it here in case it helps anyone since I myself stumbled upon this issue.

@mekk1t - a check for that was put in a couple of years ago - suggest upgrading, there are many other fixes and improvements as well.


Respect case

Details

Read the Docs project URL:  goosempl.readthedocs.io
Build URL (if applicable):
Read the Docs username (if applicable): tdegeus

Expected Result
I have a Python module that contains upper-case letters. I would like to autodoc the module, however it appears that the readthedocs converts everything to lower-case.

I currently have a work around replacing all upper-case instances for autodoc to lower-case instances. But this is not a very durable solution.

Can you please link to the specific module and page? Also, does this behaviour happens locally? I don't think this is a rtd issue, but from autodoc.

@stsewd

This happens for http://goosempl.readthedocs.io / https://github.com/tdegeus/GooseMPL
There are no issues what so locally, the case is respected.
It has so far only happened on rtd. Some snippets from the raw build are listed below, all displaying that rtd partially looses the upper-cases.

Project: goosempl
...
git remote set-url origin https://github.com/tdegeus/GooseMPL.git
...
copying build/lib.linux-x86_64-2.7/goosempl/__init__.py -> /home/docs/checkouts/readthedocs.org/user_builds/goosempl/envs/latest/lib/python2.7/site-packages/goosempl
...
writing GooseMPL.egg-info/PKG-INFO
...

I can see that your package originally is in lowercase, also that you have some try..catch around lowercase and uppercase, not sure why. Anyway, your package is in lowercase.
I suppose this is working locally because you are using Windows (case insensitive filesystem)

@stsewd
The try ... except are simply a workaround to get rtd working. But thanks for your remark! I had not realised that GitHub did not get informed of the case when I changed and pushed it (probably because my macOS is not really case sensitive).
Sorry for the false issue.

No worries!


Ministries & Assignments performance

several changes that worked together

utilize CursorAdapter for Ministries auto-complete text box
reworked load & save all ministries into single syncMinistries background process
implemented a syncAssignments background process
removed unnecessary AuthService and replaced it with direct calls to syncAssignments and syncAllMinistries
made MinistriesService multi-threaded
added Refresh action to action overflow that actually refreshes ministries and assignments from the API

@wrandall22 @mattfred
lots of smaller changes, on a fresh install current assignments and all ministries are now loaded in under 5 seconds.

this was based on work done in #27

Looks good to me.


Upgrading Scenarios

Currently, Huginn Scenarios contain a set of Agents.  They are much like tags, in that an Agent can be “in” many Scenarios at once, and the Scenario serves mostly as a label and as a means of import and export.  There are a couple of things that currently make Scenario reuse challenging.
First, it’s challenging to share and reuse Scenarios because they are not variablized, meaning that if I make a RainWarningScenario and give it to you, you have to manually edit the contained WeatherAgent and change the location that it watches, instead of just setting a location variable on the Scenario itself.  This gets more difficult with complex Scenarios where necessary configuration may be scattered across a bunch of Agents.
Second, it’s not currently possible to make Scenarios that themselves act like Agents, meaning that you can’t currently create a blackbox “Should Send Alert Scenario”, containing some number of Agents, where some Agent(s) in the Scenario subscribe to outside Events, other contained Agents process them, and finally some Agent(s) emit them again back to the outside world.  If this were possible, you could create complex Scenarios and treat them as single abstract Agents in a larger system.
Solving these two problems would make Huginn Scenarios much more powerful and reusable.
Proposed changes:

Agents can no longer be in multiple Scenarios at the same time.

Add migrator that duplicates any Agents that exist in multiple Scenarios, wiring them into the Event flow correctly.

Options

Scenarios have options that can be edited.  All contained Agents have access to these options via a Liquid tag.  (Something like scenerio_option ‘foo’)
Scenarios have editable default_options.
When exporting a Scenario, the default_options are included, but the options are not.  This way you can share a Scenario without sharing your configuration of it. (Or perhaps inclusion of options is optional?)

Event flow

One or more Agents can be selected as the “input” Agents of a Scenario.
One or more Agents can be selected as the “output” Agents of a Scenario.
Add an indexed scenario_id to Event
Scenarios that have at least one output Agent show up in Agent's Source lists, so an Agent can listen for all Events from a given Scenario.
A Scenario can subscribe to Events from an Agent, and all Agents in the Scenario marked as “input” Agents will receive those Events. (Is there a cleaner way to do this than having it on the Scenario edit page?)

Scenarios are displayed in the primary Agent diagram as a single node, or perhaps as a set of nodes with a box around them.
Reuse

Option 1: Every Scenario has a “prototype” Scenario that is abstract and cannot receive or emit events.  You can make “instances” of the base prototype Scenario for use, which cannot be edited, but can receive and emit events.
Option 2: All Scenarios can be used and edited.  You can make a copy of a Scenario for reuse.  When developing a Scenario, it’s up to the user to be careful to avoid having a bunch of different copies with small edits in them.  (I think I prefer this option.)

Realistically, I don’t think I have time to build all of this myself, but I do have time to help manage it if I can find some volunteers to collaborate on the effort.  I’d also be glad to mentor an intern over the summer on this effort, if anyone here is interested, or knows someone who would be.
Questions and thoughts:

This can happen in parallel with the #390 effort to build a community Scenario sharing site. @nerdbaggy
How do we make Scenario options work with FormConfigurable? @dsander
In addition to Scenario options, do we need a concept of Scenario memory?  Should Agents be able to write to shared memory that others can access without using Events?  This would facilitate coupled systems for synchronization (“When I post to Twitter, send it to Facebook.  When I post to Facebook, send it to Twitter.  Please avoid infinite loops!”) and other more complex problem solving. #708 and @adambedford
I’ve been thinking about behavior trees, a concept from video game AI, and thinking about how they could be used in Huginn for more complex systems.  However, as a programer, I’m hesitant to make a larger and larger visual programming environment.  (Perhaps what I’d prefer would be an asynchronous programming language with function calls that can encapsulate complex, long-running asynchronous behavior.)

Feedback and discussion greatly appreciated! @knu, @chriseidhof, @alias1, @andrewcurioso, @virtadpt, @bennlich, @akilism, @albertsun, @CloCkWeRX, @icblenke, @dsander, @gtramontina  and everyone else.

"Agents can no longer be in multiple Scenarios at the same time."
Hear, hear.  If one doesn't keep a close eye on which scenario an agent needs to go in (I've adopted the convention of putting " - " in front of each agent's name) it's easy for them to wind up someplace unexpected, which makes debugging suck.
"Options"
This would be useful, sort of like a subset of the Credentials export functionality.  Having an option to check or un-check to clear the options on a scenario as its exported would be nice, to minimize the risk of accidentally outing one's API keys or credentials.
"Event flow"
If I'm reading this right you mean tinkertoying scenarios - GenericRSSInputNetwork, GenericXMPPOutputNetwork, stuff like that.
"A Scenario can subscribe to Events from an Agent, and all Agents in the Scenario marked as “input” Agents will receive those Events."
I'm not entirely sure how useful this bit would be but I'd like to hear from everybody else before forming an opinion.
"Scenarios are displayed in the primary Agent diagram as a single node, or perhaps as a set of nodes with a box around them."
I'm inclined to ++ the latter, if only to make it easier to look at the name of the input variable the agent network requries.  The former would be helpful if there was a way to click on or hover over it to glimpse at the nodes in that particular network, I think.
"Reuse - Option 2"
This would be my preferred means of implementation because specifics could be tweaked as necessary.  For example, setting the "clean" option in instances of the WebsiteAgent because some websites and RSS feeds are only parsable when it's turned on, and some are only parsable when it's turned off.  Needing two prototype scenarios set both ways would be clunky to say the least.  Being able to clone a scenario would be great under this option.
I like the idea of scenario memory for just the sample you gave.  It would be a huge timesaver for crossposting.
As for adding behavior trees, I'd be more inclined to implement those outside of Huginn as separate software systems (virtadpt/exocortex-halo) and expose REST APIs to instances of WebsiteAgent to make better use of system resources and not tax Huginn's scheduler overmuch.  These seem specialized enough that they're probably not a good fit for Huginn.

Overall sounds like good ideas to me.
I like the idea of the scenario as a whole being a 'black box' with defined inputs/outputs. I think there would be a lot more value in subscribing it to inputs if they had a 'type' though (eg. EventDomain/EventType I talked about a while back)
Displaying on the graph as a single node, but with the ability to 'inspect' it and see it's inner agents is a good idea I think.
If we can black box a scenario, and it's agents are self contained, for composability we should allow scenarios to use other scenarios within them. Which brings up the question of versioning.
Shared memory for scenarios for sure. This is similar to how the rulesets for a pico can all read/write from the pico PDS (personal data store), or from their own local store (for private memory) in CloudOS and/or github.com/welcomer/framework
Don't know enough about behaviour trees to comment, but as far as a sync language/etc, that's why we chose to use scala and akka for the welcomer framework. Not sure of the parallels in rails-land.
—
Sent from Mailbox
On Sun, May 3, 2015 at 5:19 AM, Andrew Cantino<EMAIL_ADDRESS>wrote:

Currently, Huginn Scenarios contain a set of Agents.  They are much like tags, in that an Agent can be “in” many Scenarios at once, and the Scenario serves mostly as a label and as a means of import and export.  There are a couple of things that currently make Scenario reuse challenging.
First, it’s challenging to share and reuse Scenarios because they are not variablized, meaning that if I make a RainWarningScenario and give it to you, you have to manually edit the contained WeatherAgent and change the location that it watches, instead of just setting a location variable on the Scenario itself.  This gets more difficult with complex Scenarios where necessary configuration may be scattered across a bunch of Agents.
Second, it’s not currently possible to make Scenarios that themselves act like Agents, meaning that you can’t currently create a blackbox “Should Send Alert Scenario”, containing some number of Agents, where some Agent(s) in the Scenario subscribe to outside Events, other contained Agents process them, and finally some Agent(s) emit them again back to the outside world.  If this were possible, you could create complex Scenarios and treat them as single abstract Agents in a larger system.
Solving these two problems would make Huginn Scenarios much more powerful and reusable.
Proposed changes:

Agents can no longer be in multiple Scenarios at the same time.

Add migrator that duplicates any Agents that exist in multiple Scenarios, wiring them into the Event flow correctly.

Options

Scenarios have options that can be edited.  All contained Agents have access to these options via a Liquid tag.  (Something like scenerio_option ‘foo’)
Scenarios have editable default_options.
When exporting a Scenario, the default_options are included, but the options are not.  This way you can share a Scenario without sharing your configuration of it. (Or perhaps inclusion of options is optional?)

Event flow

One or more Agents can be selected as the “input” Agents of a Scenario.
One or more Agents can be selected as the “output” Agents of a Scenario.
Add an indexed scenario_id to Event
Scenarios that have at least one output Agent show up in Agent's Source lists, so an Agent can listen for all Events from a given Scenario.
A Scenario can subscribe to Events from an Agent, and all Agents in the Scenario marked as “input” Agents will receive those Events. (Is there a cleaner way to do this than having it on the Scenario edit page?)

Scenarios are displayed in the primary Agent diagram as a single node, or perhaps as a set of nodes with a box around them.
Reuse

Option 1: Every Scenario has a “prototype” Scenario that is abstract and cannot receive or emit events.  You can make “instances” of the base prototype Scenario for use, which cannot be edited, but can receive and emit events.
Option 2: All Scenarios can be used and edited.  You can make a copy of a Scenario for reuse.  When developing a Scenario, it’s up to the user to be careful to avoid having a bunch of different copies with small edits in them.  (I think I prefer this option.)
Realistically, I don’t think I have time to build all of this myself, but I do have time to help manage it if I can find some volunteers to collaborate on the effort.  I’d also be glad to mentor an intern over the summer on this effort, if anyone here is interested, or knows someone who would be.
Questions and thoughts:

This can happen in parallel with the #390 effort to build a community Scenario sharing site. @nerdbaggy
How do we make Scenario options work with FormConfigurable? @dsander
In addition to Scenario options, do we need a concept of Scenario memory?  Should Agents be able to write to shared memory that others can access without using Events?  This would facilitate coupled systems for synchronization (“When I post to Twitter, send it to Facebook.  When I post to Facebook, send it to Twitter.  Please avoid infinite loops!”) and other more complex problem solving. #708 and @adambedford
I’ve been thinking about behavior trees, a concept from video game AI, and thinking about how they could be used in Huginn for more complex systems.  However, as a programer, I’m hesitant to make a larger and larger visual programming environment.  (Perhaps what I’d prefer would be an asynchronous programming language with function calls that can encapsulate complex, long-running asynchronous behavior.)
Feedback and discussion greatly appreciated! @knu, @chriseidhof, @alias1, @andrewcurioso, @virtadpt, @bennlich, @akilism, @albertsun, @CloCkWeRX, @icblenke, @dsander, @gtramontina  and everyone else.

Reply to this email directly or view it on GitHub:
https://github.com/cantino/huginn/issues/813

Overall sounds like good ideas to me.
I like the idea of the scenario as a whole being a 'black box' with defined inputs/outputs. I think there would be a lot more value in subscribing it to inputs if they had a 'type' though (eg. EventDomain/EventType I talked about a while back)
Displaying on the graph as a single node, but with the ability to 'inspect' it and see it's inner agents is a good idea I think.
If we can black box a scenario, and it's agents are self contained, for composability we should allow scenarios to use other scenarios within them. Which brings up the question of versioning.
Shared memory for scenarios for sure. This is similar to how the rulesets for a pico can all read/write from the pico PDS (personal data store), or from their own local store (for private memory) in CloudOS and/or https://github.com/welcomer/framework
Don't know enough about behaviour trees to comment, but as far as async language/etc, that's why we chose to use scala and akka for the welcomer framework. Not sure of the parallels in rails-land (though I still have it on my backlog to look into running huginn on jruby / jRoR )

One thing: It would be handy for scenarios to some space set aside in the JSON document for internal documentation or arbitrary text, explaining what it was used for, maybe with some versioning or licensing information.

This sounds like a great idea.

Agents can no longer be in multiple Scenarios at the same time.

Shouldn't that something the user decides? I find it handy to have a source agent in multiple scenarios which contain the agents that are 'processing' the events the source emits.
I could move the source agent out of the scenario, but that would mean an export of the scenario would miss the source agent. If I move the processing agents into one scenario I would end up with a scenario doing two different things.

Add migrator that duplicates any Agents that exist in multiple Scenarios, wiring them into the Event flow correctly.

In my example that would mean you would end up with duplicated source agents what are both doing the same check to an external service. That brings back #543 which we could use to advice the user to restructure their scenarios to avoid having duplicate source agents.

Scenarios have options that can be edited. All contained Agents have access to these options via a Liquid tag. (Something like scenerio_option ‘foo’)

You would use the scenario options to simplify the agent configuration? For simple (form configurable) agents it could be enough to expose the autocompletable fields when the scenario is imported.

Options, Event flow

Maybe the Scenario should inherit from Agent (or a slimmed down BaseAgent), so it can be used in the existing event propagation flow and job queues?

I think I like this idea of scenarios being more like a blackbox too...
A few things/questions that come to my mind (I couldn't read the whole thread yet, so forgive me if anything here has been mentioned already):

"Agents can no longer be in multiple Scenarios at the same time." – to be clear, are we talking about agent instances? If they really can't be in multiple scenarios at the same time, but we can communicate (in terms of input/output) between scenarios, we could have a "single-agent" scenario to aid that case.
How (or if) this relates to extracting agents into plugins/gems (https://github.com/cantino/huginn/pull/554, https://github.com/cantino/huginn/issues/293)?
Could we borrow some ideas from https://github.com/soundcloud/pipeline-generator? I'm thinking more about the way "jobs" are described and connected to each other – and represented visually.
Regarding scenario options and default_options, maybe that could be handled during the scenario installation/import process. Huginn would detect that there are required fields/settings, such as credentials, and ask the user to set it up, because this can be very environment-specific.
We could think of a way of describing the agent graph and event flow with a simple language (don't know of any from the top of my head, but something like the following – note that this is very pseudo, but based on neo4j's cypher' syntax):

// -[external_in_event]->(agent_1)-[out_1]->
// -[out_1]->(agent_2)-[out_2]->
// -[out_1]->(agent_3)-[out_3]->
// -[out_2]->(agent_4)                              # note that this agent does not emit anything.
// -[out_3]->(agent_5)-[out_event_to_the_world]->   # would need to find a way to identify external in/out events

Just a tiny suggestion: I would like to see the nodes coloured in the diagram view in the same way how scenario labels are shown in the agent view.

Nice idea @elvetemedve, would you mind submitting a separate issue for this?

@cantino Here you go: https://github.com/cantino/huginn/issues/1345

I love the scenario blackbox idea. In my use case, I've had to duplicate a lot of my scenarios by hand since I'm doing the same thing a lot for slightly different variables (i.e. crawling different pages of a site, just the url is different). Being able to reuse scenarios with different variables would be interesting and powerful.

Has anyone here been an active user of Yahoo Pipes?
Pipes can give us many good ideas for Hugin's improvement.
I was a heavy user of Pipes and discovered Hugin when I was orphaned by the death of the project.
Hugin's proposal is different from Pipes but I was able to adapt. But sometimes I find myself thinking "if Hugin did such a thing as Pipes would be great."
One of the features that I miss the most is the one that is being discussed here.
Let me give you an example.
I have to monitor multiple feeds, perform specific procedures depending on each item, then merge them into a single feed ensuring uniqueness. The problem is that there are more than 30 feeds and many of the procedures are the same, but they are not all the same.
In Pipes I would create some operators and reuse them for each stream. In Hugin I have to duplicate the entire structure. If there is any modification in the operator I have to make the same modification 30 times (okay, I know there are many ways to solve this, but it's just a didactic example).
Now with this idea I can create the scenarios as operators and reuse them in each of the 30 feeds, just as it could be done in Pipes.
Perhaps this discussion concludes that the concept of scenario is nothing more than a simple labeler for agents and continue as is and a new concept should be created: an Operator Reusable and Shareable, which receives an input, processes and returns an exit.
So, I'm eagerly tracking the progress on this issue.
It's a shame I'm not a Ruby programmer to help them.

In some of my scenarios, I do pretty much what you describe.  The way I handle that use case is like this:

Allocate agents that pull the feeds in question.
Group those agents by the transformations that need to be done (none, filter, extraction, math, whatever).
Feed all of them, where feasible, into a single agent that carries out the transformation.
Feed all of the transformations into a Deduplication Agent.
Output the Deduplication Agent.

It takes some planning but it's pretty easy once you have the pattern down.


[FEATURE]: Don't throw when .values() is called with an empty array

Describe what you want
I recently converted my codebase over from Prisma to drizzle, and I have had multiple runtime bugs slip into production where I was passing in an empty array to insert.values() and getting this error: values() must be called with at least one value

The problem is, sometimes you need to dynamically create an array before passing it into the insert function,
const oldItems = [/* some retrieved array of items of unknown length */]
const newItems = oldItems.map(old => ({
    ...old,
    id: randomId()
}))

and it is very easy to forget to wrap the code in:
if(newItems.length){
    // perform insert
}

I propose allowing empty arrays to be passed in by simply resolving the promise with an early return instead of throwing an error. To me, this seems like the lesser of two evils.

👍 Would be great to also have this for inArray. It is work-aroundable, like OP said, but generates significant amount of noise in the code, and acts as potential source for runtime errors due to something being a "bug" TS is not able to catch.
Fun fact: While I was checking my code for one of the usages to include here as an example, I did notice a bug because of exactly that.
        if (onlyIds.length) {
          await tx.insert(applicationServiceConnections).values(
            onlyIds.map((serviceId) => ({
              serviceId,
              applicationId: id,
            }))
          )
        }

        const serviceRows = await tx.query.services.findMany({
          with: {
            applications: true,
          },
          where: inArray(services.id, onlyIds),
        })

In the first block, I thought about the length check. But for the following query, I forgot it => runtime error.
If it could be made a TS Error, that would work for me, too.

@emdede Agreed, if it was possible to make it a TS error, that might be the ideal solution.

It's hard to provide an API that everybody is happy with. Please see #441 for additional context.
I try to not make any db call without a try-catch because it's an over-the-wire request and errors do occur.
In your case it's a dynamic array so TS can't help either. I don't think returning early is a good option either because the return type will depend on the driver and if the query has a .returning() or not. It's will also be breaking change.
Maybe find a way to use a linter to detect this type of issues?
Please feel free to reopen if you have any other ideas.


Stops sending useless analytics

We realized that a few analytics had never been used since their introduction a few years ago; thus, we decided to get rid of them.
The following list of events has been removed from the code and blocked in segment immediately even for the older version of meilisearch:

Health Seen
Stats Seen
Task Seen
Version Seen

Fixed by #4578


Revert "Factor database implementations into secondary node_modules (redux)"

Reverts PolymerLabs/arcs#4277
#4277 breaks bazel builds due to firebase modules failing to load.

No longer needed; fixed in #4343


webstomp.over is not a function anymore?

Bumping from 1.2.0 and 1.2.2 I stared to get an exception saying webstomp.over is not a function.
    const WebSocket = require('ws'); // v5.2.1
    const webstomp = require('webstomp-client');

    const webSocket = new WebSocket('ws://<IP_ADDRESS>:15674/ws');
    // https://github.com/JSteunou/webstomp-client#overws-options
    const client = webstomp.over(webSocket, {debug: false}); // This line throws

Yeah I am getting the same errors. I thought patch bumps weren't supposed to add breaking changes.

@Way2nnadi I though too. Ho but maybe I did not do it on purpose...

@pmeijer could you inspect your webstomp object after the require('webstomp-client')? over method is still here, nothing change, I suspect the build to have brake something on the exported object.

That's weird, that is the prototype of WebSocket object. If you look at the src or the dist files, the export module is clearly the webstomp object.
What bundler are you using? webpack? Are you using js or ts?

The thing I'm using it already and I do not have this issue. I cannot reproduce it, but I'm not in TS nor Angular environment. Could your try without the index.d.ts shipped in this project, maybe it is outdated?

I don't think this is a TS issue, because this is a runtime error... Maybe it's an Angular CLI issue, I don't know if the OP is also using Angular CLI? But it's the only library that shows such an issue...
Anyway, I did my best to make a reproduction.
See https://github.com/cexbrayat/webstomp-client-issue-73
This is a simple Angular CLI application (generated with ng new webstomp-issue) .
I then added webstomp-client: npm i --save-exact<EMAIL_ADDRESS>Then I updated the code to add a Webstomp connection:
    const url = 'ws://ponyracer.ninja-squad.com/ws';
    const websocket: WebSocket = new WebSocket(url);
    const stompClient: Client = Webstomp.over(websocket);
    stompClient.connect({ login: null, passcode: null }, () => {
        stompClient.subscribe('player/2179', message => {

      });
    });

This works.
To check it out yourself, clone the repo, run npm i then npm start, open http://localhost:4200, there is no error in the console.
Now if I try to update to 1.2.2 (see https://github.com/cexbrayat/webstomp-client-issue-73/pull/1), then I see the error webstomp_client__WEBPACK_IMPORTED_MODULE_1__.over is not a function.
You can try to switch to the branch  reproduce-issue-73, run npm i and npm start again, and you'll see the error.
I hope this helps.

I can see the bug, but I still dont know why it happens :(
In standard build with webpack it does not behave the same. I'll try to fix by moving from webpack to rollup to build the dist files.

@cexbrayat I just publish 1.2.3 hoping it solves the issue without breaking for others people. I saw different weird thinks in export / ts definition and build. Anyway, waiting for your feedback before closing this. Appreciate your help ;)

@JSteunou The good news is that it looks like the issue is fixed (no error in the repoduction repo) 🎆
Bad news is that I get:
ERROR in node_modules/webstomp-client/index.d.ts(145,5): error TS7008: Member 'VERSIONS' implicitly has an 'any' type.
node_modules/webstomp-client/index.d.ts(146,5): error TS7008: Member 'client' implicitly has an 'any' type.
node_modules/webstomp-client/index.d.ts(147,5): error TS7008: Member 'over' implicitly has an 'any' type.

in another project. So I think you need to type more strictly what you introduced in https://github.com/JSteunou/webstomp-client/commit/35e50a91bbc8550a6006ffbfed21bbf605cd2b1c to make it perfect 🙂

I think something like :
declare const webstomp: {
    Frame: Frame,
    VERSIONS: typeof VERSIONS,
    client: Client,
    over: Client,
}

would do the job (the type of VERSIONS can maybe be improved, but that should work)

Got this ERROR in src/app/app.component.ts(16,33): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'Client' has no compatible call signatures.

I used typeof all the way. I'm not a TS expert so if someone wants to make a better index.d.ts I'm taking it
1.2.4 is published

@JSteunou 👍 I updated my app to 1.2.4 and I have no issues anymore. Thanks for your help!


Add Inactive Status to ‘Editor setting’ button

This is a...

[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report
[ ] Documentation issue or request

The problem
Currently on Data Mapper, the ‘Editor Setting’ button is always highlighted no matter activated or not.
Expected behavior

The ‘Editor Setting’ button should be displayed by dark gray color while inactive Status, which is similar color with "Add a mapping" for example.

Screenshot

Active Status of "Editor Setting" button

Inactive Status of "Editor Setting" button

I got what is happening a bit more, so the gear is blue from beginning because Editor Settings -> Show Lines is enabled by default. Once you disable Show Lines, then the gear turns into black. So it shows blue if at least one of its sub-option is enabled.
@nding-anges do you think we still want to make it blue only when a dropdown list of sub-options are shown?

We might want to make the sub-option icon blue instead.

Hi @igarashitm  Since the sub-menu is by default hidden and for 90% of time, there will at lease  one sub menu is enable, as a new user , they won’t understand why the gear looks always active.
I'd like suggest that the active status of the gear as well as other icons on the top right will indicate they open a new panel.For example: icon of Open/Close Mapping detail panel.  In this case , I think that the gear will be blue when-sub menu panel is open. That will be consistent action as other icons .
At the same time,  I’d like suggest to improve the design of the sub-menu in oder to better visualize their enable and disable status. This is related  to another Issue #77

@nding-anges sounds cool! feel free to file separate issue to improve sub-menu design.


feat(steps): add transform for polynomial features

Add polynomial features
Resolve #41

Codecov Report
Attention: Patch coverage is 92.00000% with 4 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@3e64906). Click here to learn what that means.

Files
Patch %
Lines

ibisml/steps/feature_engineering.py
88.23%
4 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   81.05%
=======================================
  Files           ?       19
  Lines           ?     1362
  Branches        ?        0
=======================================
  Hits            ?     1104
  Misses          ?      258
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Expose Headers on NatsSvcMsg

Thi pr adds the following

Exposes Heades on NatsSvcMsg (forwarded from the underlying NastMsg)
A simple service test to make sure headers gets passed to and from service endpoints.

Fixes #370

note test failures are flappers #344

@niklasfp looks good + love the test! Just an admin we need: could you please sign your commits?


Fix rootfs on RB5 (dunfell)

I merged the PR against master. can you please update this PR and do a proper cherry-pick instead?

I merged the PR against master. can you please update this PR and do a proper cherry-pick instead?

Done


Bug when encoding datetime64 with NaT as first value

Thanks @hdail for the report

@shoyer - this looks good... Although, what's up with the branch name datetime65?

@jhamman

Merging this....
I have no idea where datetime65 came from :)

:thumbsup:


Add more detail to the description field of pubspec.yaml.

According to flutter pub score, it is not good about description.
And write more comment to classes and methods.

Done.


Add --force-confnew to apt-get install

When apt has a problem installing a package because a config file has changed, it will ask the user what to do. This requires stdin which breaks the downstream container build.
I think (though this is a bit of a guess) that we'll always want the new, packaged version of the config file.

Thanks to @JayH5 for the better solution: https://github.com/praekelt/casepro/pull/188 :)


Upgrade Checker Framework dependency to 2.5.5

This gives us anonymous class UI-effect polymorphism inference and the -AstubWarnIfNotFoundIgnoresClasses flag.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@msridhar Any idea why I am getting asked about the CLA. I can sign it, of course, but I thought that should show up only to external contributors.

@msridhar Any idea why I am getting asked about the CLA. I can sign it, of course, but I thought that should show up only to external contributors.

That's weird.  Just go ahead and sign.


How to train on more than one gpus?

Even if I set the CUDA_VISIBLE_DEVICES as 0,1,2,3 , still this code can only run on the first gpu.
I added the nn.DataParallel function by myself, but here comes  AssertionError when testing.
Thus I wonder if this model can be trained on two or mare gpus naturally, or it just because my wrong operation.
Thanks a lot.

Sorry, I haven't tried multi-gpu training. But it seems to be a common issue...


i18n(fr): update resources/community-content.mdx

Description
This PR updates the French version of the resources/community-content page with the changes from #1789.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
resources/community-content.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Fix FS Events forwarding to xhyve VM

Just noticed that today and I tracked down the root cause to a blanky SSHKeyPath on the VM's state that results in wrong arguments being passed on to fsevents_to_vm:
$ docker-machine create remove --driver xhyve
....
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on
this virtual machine, run: docker-machine env remove

$ docker-machine inspect remove | grep -i sshkey
        "SSHKeyPath": "",

This might be something to be fixed on the driver's side but I guess it does the trick for now.

Oh good catch thanks. Have you filed an issue with the xhyve driver? It does seem like something they should fix.

Have you filed an issue with the xhyve driver? It does seem like something they should fix.

Not yet, I haven't had a chance to dig into it as I was unable to build it locally neither I know how exactly drivers should behave in regard to that. But I'll try to look into it tomorrow.
Either way, unless we want to implement custom logic based on the driver version, I guess we might want to keep this little hack around while the behavior gets dealt with upstream and a new release is out :sweat_smile:
WDYT?

Yeah for sure, I just want to make sure they're aware of it

Doh, I just released dinghy 4.3.0 and forgot to merge this first :dizzy_face:
Merging and releasing 4.3.1. Thanks again!


[Layer] Fine grained data type definition for Attention and MLP

Main modification:

Make xFT support any data type for input, output and intermediate buffer, by adding more template parameters to Attention and MLP.
Llama model data type definition according to type selector
more data type support for some utility functions
BF16 communication
Some little refactor (like in CommonDecoder)

(Please be noted, this PR targets to make the pure BF16 flow works, the performance is not optimized yet)

@pujiang2018

added the license header.

@pujiang2018  Have a conflict.


Remove proto_version from build.gradle

This doesn't seem to be used anywhere. It has been replaced by the value in dependencies.properties.

PTAL

@vam will it be ok for gapic-generator's gradle build to rely on Java 8?

@andreamlin Oh, the build fails, because there is no 3.7.1 maven artifact released for some reason (https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/3.7.0)

@vam-google yeah i think yoshi had the same problem, so google-cloud-java uses 3.7.0 instead of 3.7.1.
So, should we revert to 3.7.0? or like have different versions for the gapic-generator gradle vs bazel?

asking protobuf team to make a java release too protocolbuffers/protobuf#5972

@vam-google the bazel build definitely fails using this PR. in fact, bazel test ... fails locally if i checkout master branch and then change the protobuf version to 3.7.1 in dependencies.properties.
What should we do?


2DSE: Undo/Redo support in the 2D Shape Editor window.

Over at Twitter Wulightsun asked how to CTRL+Z undo.
I had significant trouble implementing this because there's no game object associated with the shape editor window which Unity needs in order to undo things.

Perhaps you could store some contextual information on a scriptable object instance

I'm not certain - but if you're serializing these states in an EditorWindow seeing as that inherits from ScriptableObject you can probably register an Undo on it in the usual ways.

I created a pull request #201.
When I close the 2D Shape Editor window the undo/redo history remains. Is there a way to discard it or what's the best practice to handle this?

A discussion on Discord revealed that I am not keeping to the Unity paradigm where every action causes a reaction in an object, scene or setting. The 2D Shape Editor would need its own undo/redo stack while the window has focus and/or have all undo/redo history of actions taken in that window cleared when it's closed (it calls OnDestroy and does in fact garbage collect the window).
Currently, if the user were to sketch up a 2D project but then change their mind, they'd have to press CTRL+Z say 50+ times to get back to scene changes, even when the window has been closed, a most unfortunate situation.
Modifications in the 2D Shape Editor project may be mixed with scene activity. If you were to make a note of the current group identifier when the window is shown to then call Undo.RevertAllDownToGroup when the window is closed it essentially discards all of the editor activity but also undoes any scene modifications done while the window was open.
I also had a look at the reference source but the undo stack is extremely native and it appears that reflection can't help me solve this issue. There also doesn't appear to be a way to intercept and cancel undo/redo events which would have let me take control over the situation.
Optimal Solution

A custom undo/redo stack just for the editor window.
Intercept undo/redo events if the window has focus to use the custom stack instead.
Clean separation between Unity editor's stack and the editor window's stack.

... but this may not be possible.


Update CGM.md

nits

Ah okay
I need to understand that. I'll catch up with u on Gitter soon
11 mile hike today
Rig did great
I need to read docs about offline display. Obviously Nightscout wasn't available
Need to get something to work on hikes
Dirk
On Jul 23, 2017, at 10:16 AM, Scott Leibrand <notifications<EMAIL_ADDRESS>wrote:
@scottleibrand requested changes on this pull request.

In docs/docs/Gear Up/CGM.mdhttps://github.com/openaps/docs/pull/969#discussion_r128924692:

@@ -5,7 +5,7 @@

Medtronic (MiniMed Paradigm REAL-Time Revel or Enlite)

-The openaps tool set currently primarily supports three different CGM systems: the Dexcom G4 Platinum system (with or without the Share functionality), the newer Dexcom G5 Mobile system and the Medtronic system. Other CGM or CGM-like devices (Libre) can also be used if the data is uploaded to Nightscout and the OpenAPS rig has Internet connectivity.
This is talking about the underling openaps toolkit, so should not be capitalized.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/openaps/docs/pull/969#pullrequestreview-51648559, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbwwkZsINwibqtQ-GSdb24Bhc4jquE7oks5sQ3_RgaJpZM4OgXDI.


Wrong expected/received values.

Hello,
Attached you can find two json eaxmples, which are only a small part of jsons I'm trying to compare.
There is a change found in
{'signals': {'LockUnlock': {'rx_nodes': {'_content': {0:  which is correct, but received value is incorectly assigned to None instead of Vector__XXX.
When comparing in the other direction, expected value is incorectly assigned to None instead of HCP.
Is there any workaround for this? Im writing interactive tool where user can decide if he wants to accept or reject changes, and generate new json automatically out of that, so I would appreciate any solution.

Ok, I guess that's just how it works with a lists.
I would expect sth like valuees not equal when list is just one element.
Nevertheless, closing issue.


Update for Forestry 4.0.3

Mostly container/class renames.

Thanks, will merging this after the Release of Forestry 4.0

Forestry 4 has been released

Thanks @mezz
@jaredlll08 a last modtweaker release for the old forestry version? To have a modtweaker version with the latest Zenscript Signature Changes?

fixed with 4bea2e5fc92e59994303283c49c0326934d78163


onlykey-agent: add missing pkg_resources dependency

Description of changes
The onlykey-agent package fails to run on a recent master, as the pkg_resources dependency is missing. This pr adds it.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 287758 run on x86_64-linux 1

2 packages built:

onlykey-agent
onlykey-agent.dist

I don't think that's needed anymore


Definition for ATtiny102

Hi,
I'm new with the Atmel Studio and with AVR family. I'm traying to use your library with an ATtiny102 working at 8Mhz or at 12MHz.
I have some concern about how define the ATiny102 on the yaMBSiavr.h file.
Can you give me a hand to do this?
Thanks
BullT

Hi,
the ATtiny102 does not have enough flash. You will have to use another controller.
Best,
Max


skytemple: 1.3.0 -> 1.3.1

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138951 at 1c0d8b47 run on aarch64-linux 1

7 packages built successfully:

python38Packages.skytemple-dtef
python38Packages.skytemple-files
python38Packages.skytemple-ssb-debugger
python39Packages.skytemple-dtef
python39Packages.skytemple-files
python39Packages.skytemple-ssb-debugger
skytemple


Fix the grammar issue for iterable unpacking in the return statements in Python before 3.8

Hi, I noticed that using this package with Python 3.7 will result in Syntax Error while I was testing CogView2.
If I recall correctly, that is a deficiency of Python grammar specification before Python 3.8, which only allows parenthesized unpacking in the return statements^1.
And here is a fix for this issue.
Related issue:

https://github.com/THUDM/CogView2/issues/4

Thank you for your fix! I will update the package.


added images in features

Fixes #35

Thanks @Megatank58, however the screenshots that need to be updated are the ones on this page, which is the landing page of the website.
Can you please add a commit to your pull request with those changes? 🙏

Oh my bad sorry I'll do the changes

I have updated the images and reverted readme

That's perfect! Thanks a lot. I'll close the PR and merge it so that it counts for your hacktoberfest 😉

Closes #35


Alignment issues when source cog is in non-native projection

We are having problems where COGs are not positioned correctly on the cesium globe when they are reprojected by TIFFImageryProvider:

This COG is in EPSG:32756, available here: https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/56/J/NP/2023/4/S2A_56JNP_20230410_0_L2A/TCI.tif

I don't know what's going on either, but there may be some issues with the simple bbox's coordinate system conversion. Do you know how to improve it?

Thank you for your help! All the code related to reprojection is here: https://github.com/hongfaqiu/TIFFImageryProvider/blob/main/packages/TIFFImageryProvider/src/TIFFImageryProvider.ts#L200-L227
I have just simply obtained the bounding box of the TIFF, converted it to the bounding box in the 4326 coordinate system, and passed it into the rectangle. May be I should rewrite the entire TilingScheme?

Im not sure, Ill have a look at this tomorrow, perhaps your method is not sufficient. Thanks for your work so far! We are trying to use your code in our open source tool TerriaJS

Thank you for your recognition! I really love TerriaJS, and have learned a lot from it.

I have confirmed that reprojecting a cog to EPSG:4326 fixes the alignment problem:

Datasets
Original cog that appears misaligned: https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/56/J/NP/2023/4/S2A_56JNP_20230410_0_L2A/TCI.tif
Reprojected with gdal and uploaded to S3: https://stafs-cogs.s3.ap-southeast-2.amazonaws.com/Whian_Whian_TCI_4326_cog.tif

Cool! I have found a repo geotiff-geokeys-to-proj4 that can perform coordinate system transformation on TIFF files. It seems to perform the transformation on every pixel rather than just the bounding box. I'm not sure if this will be effective.

Yes I dont think reprojecting the bounding box is sufficient. This is how OpenLayers handles it: https://openlayers.org/doc/tutorials/raster-reprojection.html

@hongfaqiu this is great news, thanks for your efforts! I will check it out now

Dear @hongfaqiu , I have incorporated your changes into my terriajs test branch, and it resolved the alignment issue, thanks so much for your work! However, it does present a different problem: the COGs are sometimes displayed in the wrong location when zoomed out:

Dear @hongfaqiu , our cesium expert suggests that you can fix this by changing how this._rectangle is computed, to account for the northwest and southwest corners having different longitudes - I think this code should do it:
 const swMeters = new Cartesian3();
    options.rectangleSouthwestInMeters.clone(swMeters);
    const neMeters = new Cartesian3();
    options.rectangleNortheastInMeters.clone(neMeters);
    const seMeters = new Cartesian3(neMeters.x, swMeters.y);
    const nwMeters = new Cartesian3(swMeters.x, neMeters.y);

    const southwest = this.projection.unproject(swMeters);
    const southeast = this.projection.unproject(seMeters);
    const northwest = this.projection.unproject(nwMeters);
    const northeast = this.projection.unproject(neMeters);

 this._rectangle = new Rectangle(
      Math.min(
        southwest.longitude,
        southeast.longitude,
        northwest.longitude,
        northeast.longitude
      ),
      Math.min(
        southwest.latitude,
        southeast.latitude,
        northwest.latitude,
        northeast.latitude
      ),
      Math.max(
        southwest.longitude,
        southeast.longitude,
        northwest.longitude,
        northeast.longitude
      ),
      Math.max(
        southwest.latitude,
        southeast.latitude,
        northwest.latitude,
        northeast.latitude
      )
    );

Dear @staffordsmith83, thank you and your team for the work you have done. It's working great now!
There is still a lot of room for improvement in this library, and I look forward to working with you to build it together.

When I project the non-3857 coordinate system into the 4326 coordinate system, I noticed that the four vertices constructed using the bbox attribute of the geotiff do not form a regular rectangle. This also causes the failure of constructing a Cesium.Rectangle.
The TilingScheme only performs projection transformation and mapping on regular rectangular tile boundaries, and it cannot handle tile seams.
I am considering implementing the coordinate transformation of projections in a different way in the frontend. It seems that the TilingScheme approach is incorrect.

I have developed a front-end grid reprojection method, which produces the following results as shown in the image. It addresses some issues but there are still some remaining problems to be resolved.

Thanks for your work on this @hongfaqiu , we are following with great interest

Dear @hongfaqiu how did you go resolving these issues? Any luck?

Dear @staffordsmith83, I was busy with other things recently, but today I had some time to update the code. However, the results are not satisfactory, and there are areas for improvement.
Originally, my idea was to make the implementation of the tileXYToRectangle function consistent with the GeographicTilingScheme, where I would request additional tile data to ensure complete coverage after reprojection. However, this approach encountered some issues, and I had to switch to a solution similar to the WebMercatorTilingScheme.
In any case, the reprojection function is currently executing sequentially on the CPU, which makes it inefficient and blocks the rendering process. That's why I have marked the reprojection method as experimental.

Dear @hongfaqiu thanks somuch for your efforts! Yes its a difficult issue, the library that we are using for 2d mode, georaster-layer-for leaflet also has issues reprojecting. Also busy with other things, but can hopefully come back to this soon. Thanks again!

@staffordsmith83 Thank you very much for your ongoing support. I will also continue to follow your progress in terriaJS and look forward to finding a more effective general solution. It would be even better if this could help advance Cesium's capabilities in reprojection.

Dear @hongfaqiu did you make any progress with the reprojection? I notice in your changelog you have implemented some web based reprojection that is slow but works? Perhaps GeoWarp is an option? https://github.com/DanielJDufour/geowarp

Dear @hongfaqiu did you make any progress with the reprojection? I notice in your changelog you have implemented some web based reprojection that is slow but works? Perhaps GeoWarp is an option? https://github.com/DanielJDufour/geowarp

Excellent repo! I will try it next week. Thanks your sharing.

I have looked at DanielJDufour's code, and its reprojection is also based on CPU computation. Furthermore, it performs poorly on non-rectangular boundaries as it clips a portion of the content.
If there is no solution that offers performance improvements of 1-2 orders of magnitude, the feasibility of browser-based reprojection remains low.
I still have other work tasks this week, so I hope to have some free time next week to investigate this issue.


feat: AdminAPI GET for verified accounts

High Level Overview of Change
Admin API can now return identity_key field for verified accounts
Context of Change
Series of PRs implementing verifiable PayID
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[x] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Before / After
AdminAPI now returns identity keys
Test Plan
Previous tests continue to pass + 1 new one to confirm it returns as expected

@dino-rodriguez nope the base64 encoded values put in the DB are bogus right now. I agree, we'll likely want to swap them for real ones eventually. Let's punt on that for now to make sure we hit the sprint goals & incorporate that validation testing into our next sprint.


Connect-Splunk: connection closed unexpectedly

See this post: http://answers.splunk.com/answers/147886/splunk-powershell-module-why-was-connection-closed-unexpectedly
Not able to repro internally, need more details.

User resolved their own issue in a later post - the management port always uses https, and they also were still using the default self-signed certificate.


Duplicate warnings and/or running twice

Hi - I am seeing duplicate warnings for both autoprefixer and stylelint. Not sure if this is specific to postcss-loader or postcss itself, but I figured I'd start here. Anyone have an idea how to solve this? Thanks in advance!
From webpack.config:
module: {
    loaders: [
        { test: /\.scss/, loader: ExtractTextPlugin.extract('style', 'css!postcss!sass') },
        { test: /\.(woff2?|ttf|eot|svg)(\?v=[0-9]\.[0-9]\.[0-9])?$/, loader: 'file?name=/assets/fonts/[hash].[ext]' },
        { test: /\.(jpeg|jpeg|gif|png|tiff)(\?v=[0-9]\.[0-9]\.[0-9])?$/, loader: 'file?name=/assets/images/[hash].[ext]' }
    ]
},
plugins: [
    new ExtractTextPlugin('assets/css/[name].min.css')
],
postcss: [
    autoprefixer({ browsers: ['> 5% in US', 'last 2 versions', 'IE 9'] }),
    stylelint(),
    reporter({ clearMessages: true })
]

Example output in console:
app/assets/styles/default/cards/index.scss
203:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
206:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
213:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
216:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]

app/assets/styles/default/cards/index.scss
203:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
206:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
213:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]
216:5   ‼  Expected indentation of 4 spaces (indentation) [stylelint]

Could I ask you to help me a little a create small demo project to reproduce issue?

No demo project, no help ;).
I think problem is in used reporter — it doesn’t clean result.warnings() after output them to CLI.

@ai My apologies... stylelint became a low priority on the project I was working on, so this was the first time I've looked again at this ticket.
To note, I totally removed postcss-reporter, and was still seeing duplicate warnings in the console. I've since switched to a webpack plugin called stylelint-webpack-plugin, and duplicate warnings/errors went away.
I'll see if I can create a demo project to replicate when time permits. Thanks!

@ai I've put a project together that's experiencing the issue: https://github.com/tysonnero/react-webpack-postcss-loader. Just clone it, run npm install, then npm run build or npm run watch.
There is one error in the SCSS. You should see two duplicate errors reported in the console. You can remove postcss-reporter or autoprefixer from webpack, and the problem will persist.
Thanks!

Thanks. I try to look it today evening or tomorrow.

You asked about this warnings?
><EMAIL_ADDRESS>build /home/ai/react-webpack-postcss-loader
> webpack --config webpack.config.js --progress --colors

 45% 83/140 build modules
src/components/HelloWorld/HelloWorld.scss
7:15	⚠  Unexpected invalid hex color "#00000" (color-no-invalid-hex) [stylelint]

 69% 178/180 build modules
src/components/HelloWorld/HelloWorld.scss
7:15	⚠  Unexpected invalid hex color "#00000" (color-no-invalid-hex) [stylelint]

Hash: 86a7f4064d10da29a716

@ai
Yes, those duplicate warnings.  Do you know why they're displaying double?

@tysonnero this warnings came from postcss-reporter, not from loader itself. Seems like it is result of some conflict with webpack output magic.
Maybe we could fix it, but I think using special stylelint loader is better.
Also, maybe console it not a best way for webpack. I think you should:

Add linter to Atom.
Add linter to lint-staged to lint changed files before commit.
Add linter to CI.

So you don’t really need linter in webpack loader.

@ai Thanks for checking on that. I removed postcss-reporter and autoprefixr from the webpack.config and pushed the changes: https://github.com/tysonnero/react-webpack-postcss-loader/commit/934144176cb82958b749b9bfea2ec883e6f3434c.
I am still seeing duplicate warnings in the console. Any thoughts? I'd like to keep the linter in webpack for both JS and CSS for my company's build process. We actually have things we want to fail the build per the whole team

@tysonnero I pulled changed, run build and didn’t get any watnings:
➤ npm run build

><EMAIL_ADDRESS>build /home/ai/react-webpack-postcss-loader
> webpack --config webpack.config.js --progress --colors

Hash: 86a7f4064d10da29a716
Version: webpack 1.13.1
Time: 4028ms
       Asset     Size  Chunks             Chunk Names
js/bundle.js  1.92 MB       0  [emitted]  main
    + 179 hidden modules

ERROR in ./src/index.js

/home/ai/react-webpack-postcss-loader/src/index.js
  1:27  error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  2:34  error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  3:61  error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  4:1   error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style

✖ 4 problems (4 errors, 0 warnings)

ERROR in ./src/components/HelloWorld/HelloWorld.js

/home/ai/react-webpack-postcss-loader/src/components/HelloWorld/HelloWorld.js
  1:27   error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  2:40   error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  3:1    error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  4:43   error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  5:13   error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  6:117  error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  7:4    error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  8:2    error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style
  9:1    error  Expected linebreaks to be 'CRLF' but found 'LF'  linebreak-style

✖ 9 problems (9 errors, 0 warnings)

ERROR in ./~/css-loader?modules&importLoaders=2!./~/sass-loader!./~/postcss-loader!./src/components/HelloWorld/HelloWorld.scss
Module build failed:
  font-color: #00000;
            ^
      Invalid CSS after "  font-color:": expected expression (e.g. 1px, bold), was "#00000;"
      in /home/ai/react-webpack-postcss-loader/src/components/HelloWorld/HelloWorld.scss (line 7, column 14)
 @ ./src/components/HelloWorld/HelloWorld.scss 4:14-205

ERROR in ./src/components/HelloWorld/HelloWorld.scss
Module build failed: ModuleBuildError: Module build failed:
  font-color: #00000;
            ^
      Invalid CSS after "  font-color:": expected expression (e.g. 1px, bold), was "#00000;"
      in /home/ai/react-webpack-postcss-loader/src/components/HelloWorld/HelloWorld.scss (line 7, column 14)
    at DependenciesBlock.onModuleBuildFailed (/home/ai/react-webpack-postcss-loader/node_modules/webpack-core/lib/NormalModuleMixin.js:315:19)
    at nextLoader (/home/ai/react-webpack-postcss-loader/node_modules/webpack-core/lib/NormalModuleMixin.js:270:31)
    at /home/ai/react-webpack-postcss-loader/node_modules/webpack-core/lib/NormalModuleMixin.js:292:15
    at context.callback (/home/ai/react-webpack-postcss-loader/node_modules/webpack-core/lib/NormalModuleMixin.js:148:14)
    at Object.onRender (/home/ai/react-webpack-postcss-loader/node_modules/sass-loader/index.js:272:13)
    at /home/ai/react-webpack-postcss-loader/node_modules/async/lib/async.js:906:35
    at _arrayEach (/home/ai/react-webpack-postcss-loader/node_modules/async/lib/async.js:85:13)
    at Object.<anonymous> (/home/ai/react-webpack-postcss-loader/node_modules/async/lib/async.js:898:17)
    at Object.callback (/home/ai/react-webpack-postcss-loader/node_modules/async/lib/async.js:44:16)
    at options.error (/home/ai/react-webpack-postcss-loader/node_modules/node-sass/lib/index.js:275:32)
Child extract-text-webpack-plugin:
        + 1 hidden modules

    ERROR in ./~/css-loader?modules&importLoaders=2!./~/sass-loader!./~/postcss-loader!./src/components/HelloWorld/HelloWorld.scss
    Module build failed:
      font-color: #00000;
                ^
          Invalid CSS after "  font-color:": expected expression (e.g. 1px, bold), was "#00000;"
          in /home/ai/react-webpack-postcss-loader/src/components/HelloWorld/HelloWorld.scss (line 7, column 14)

@ai The bottom half is reporting the "font-color: #00000;" warning/error twice. That was the same duplicate warning/error when I had the reporter in.

Seems like it is ExtractTextPlugin issue :(. Sorry, I am not good in webpack internal parts. I use official API to set a warning.
ExtractTextPlugin has many issues (it is a reason why I came back to Gulp).

@ai @tysonnero
Very late comment, Hope maybe useful to someone.
Setting { allChunks: true } option in ExtractTextPlugin solve the issue for me.
FYI: https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/217


Remove top-level tests and test data

Issue is #182.  Changes:

Removes the top-level tests/test_Solver.py, because it really is a test of PCE.  I will move that test to pce (or at least parts of it that do not overlap with the existing pce tests).  The issue to track this is https://github.com/atlanticwave-sdx/pce/issues/132.
Remove associated test data.
Remove top level samples directory, because the topology files are broken.

Also see #168.

coverage: 45.352%. remained the same when pulling 1c816a283dcea2ead2db5870b03c0cce463f2b6e on 182.consolidate-tests-and-topologies into<PHONE_NUMBER>fef042d91572c7bb0387b4dcdd3557 on main.

These tests are largely the same as those in PCE. The purpose originally was to let Cong to test the PCE APIs within the SDX-Controller before integrating into the controller code in confidence. So it's Cong's call @congwang09.

That makes sense as an interim measure.  However if we keep the tests here, it is going to duplicate the code that's been already moved to pce (in https://github.com/atlanticwave-sdx/pce/pull/134).  That is less than ideal.
If we really don't mind duplicating tests, we should still remove the static JSON files from here and use the ones from pce once https://github.com/atlanticwave-sdx/pce/pull/139 is merged.  I will update this PR based on Cong's feedback.


fix: some updates to the github_repo_pr_commits implementation

fix some typos
add some columns
add test fixtures

Codecov Report

:exclamation: No coverage uploaded for pull request base (github_commits@a6ef581). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             github_commits     #227   +/-   ##
=================================================
  Coverage                  ?   70.50%
=================================================
  Files                     ?       49
  Lines                     ?     2699
  Branches                  ?        0
=================================================
  Hits                      ?     1903
  Misses                    ?      502
  Partials                  ?      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ef581...dca6e49. Read the comment docs.


[Question] Monitor Sidekiq Cron Workers

Hi,
First, thanks for all the hard work you put into keeping this gem running smoothly. It's really helpful.
Recently, I ran into a problem because some cron workers didn't run like they were supposed to. This happened because the pod restarted, which was caused by some bad queries inside the worker class. I'm wondering how you all keep track of whether all the sidekiq-cron processes are running as they should.
I've been thinking about using sidekiq middleware to store a key before a worker starts and then remove the key once the worker is done. This way, I could check if the key is still there to know if the worker didn't run correctly. What do you think about this idea?

Hello @rslhdyt,
I'm actually using the https://github.com/smartinez87/exception_notification gem. You can use for example the manual notification approach inside your job class. So if any error (or specific condition) raises inside your job, you'll receive a notification via email, Slack, Datadog, ...
It seems you may also want to know if the job even run (not only if there is an error). For that, your idea seems feasible, why not? The gem didn't provide any api/option to handle that, as we rely on the Sidekiq process itself to boot our scheduler.


fixed footer issue

Issue
Fixes #75
Description
New content container add to Home & Bookmarked. Modified footer css.
Type of change

[x] Bug fix #75  (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change

Screenshot

Checklist:

[x] My code follows the style guidelines of this project
[x] The app runs properly
[x] I have performed a self-review of my own code
[x] I have formatted and commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Please check if this can be merged.

Please remove the merge conflicts too.

Please remove the merge conflicts too.

As per the instructions, I have reverted all the changes done in all the files which was affected due to the code editor format on save. Later, I made changes to the required CSS.
Also regarding the merge conflict it was occurring in Home.js file which was also changed by the editor on save option as per my knowledge. So, in my opinion reverting everything would have solved that too.

As per the instructions, I have reverted all the changes done in all the files which was affected due to the code editor format on save. Later, I made changes to the required CSS.
Also regarding the merge conflict it was occurring in Home.js file which was also changed by the editor on save option as per my knowledge. So, in my opinion reverting everything would have solved that too.

Regarding the last part pushing them to my PR. I did not understand that very well.

Should I make a new PR & close this one?
Should I commit the changes to same PR?

If it's the later one, I have no idea to how to push changes to same PR. Can you please guide me through. Thanks.

Regarding the last part pushing them to my PR. I did not understand that very well.

Should I make a new PR & close this one?
Should I commit the changes to same PR?

If it's the later one, I have no idea to how to push changes to same PR. Can you please guide me through. Thanks.

As per the instructions, I have reverted all the changes done in all the files which was affected due to the code editor format on save. Later, I made changes to the required CSS.
Also regarding the merge conflict it was occurring in Home.js file which was also changed by the editor on save option as per my knowledge. So, in my opinion reverting everything would have solved that too.

Just a correction to your second point: The merge conflict is not due to the editor. It occurs when someone also proposed some changes on the same line of code that you were working and his/her changes got merged first before you. That's why you faced a merged conflict. To resolve this, I'd suggest you to watch any tutorial on "How to resolve merge conflicts"

Regarding the last part pushing them to my PR. I did not understand that very well.

Should I make a new PR & close this one?
Should I commit the changes to same PR?

If it's the later one, I have no idea to how to push changes to same PR. Can you please guide me through. Thanks.

By pushing I meant, just do a new commit to your current PR and push those latest changes. By pushing, your newly added commits will also reflect here, and I will be able to see your updated code.

I've done the changes. Please check once. I hope this time it's right.


feat: add codeql security checks status

Codecov Report

Merging #7 (6f1c8a3) into master (49aa868) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   53.21%   53.21%
=======================================
  Files           4        4
  Lines         218      218
=======================================
  Hits          116      116
  Misses         96       96
  Partials        6        6


Revise query logic of following authors for new registered user

Close it due to dropped in wrong repo.


[builder] ttfautohint not found

I have a message saying that ttfautohint command not found when building with the last gftools
[4/8] ttfautohint ../fonts/ttf/Borel-R...ts/ttf/Borel-Regular.ttf.autohintstamp
FAILED: ../fonts/ttf/Borel-Regular.ttf.autohintstamp
ttfautohint ../fonts/ttf/Borel-Regular.ttf ../fonts/ttf/Borel-Regular.ttf.autohinted && mv ../fonts/ttf/Borel-Regular.ttf.autohinted ../fonts/ttf/Borel-Regular.ttf && touch ../fonts/ttf/Borel-Regular.ttf.autohintstamp
/bin/sh: ttfautohint: command not found

gftools depends on ttfautohint-py; the latter does not install a ttfautohint script. If you want to call it from the command line you need to do python -m ttfautohint. I recommend you use sys.executable when you define the ttfautohint build rule so you call the same python that gftools was called with.

gftools depends on ttfautohint-py; the latter does not install a ttfautohint script. If you want to call it from the command line you need to do python -m ttfautohint.

I got that, thanks. But several stuff have changed with the last version of gftools, and I think ttfautohint-py was part of gftools package and we didn't need to install it locally. Otherwise all the fonts using the google fonts project template with a gh-action for building wouldn't be autohinted, right?

ttautohint-py is still listed among gftools' setup.py install_requires so when one does pip install gftools they will also automatically get ttfautohint-py.

we didn't need to install it locally

that's right, you should not need to install it separately. The build rule for running ttfautohint from the ninja-based gftools builder needs to be changed so that it invokes the ttfautohint-py console entry point ("{sys.executable} -m ttfautohint") instead of plain ttfautohint command which is not available normally (unless one also happens to have ttfautohint command installed independently from gftools itself, e.g. via homebrew, but I would not recommend that)

The new builder uses gftools-autohint, and the old one should too.

Confirming that it is now working youpi!


fix: fixing monocdk imports + feat: Improve context stack deployment speed as a patch release

Description of Changes
patch release including

https://github.com/aws/amazon-genomics-cli/pull/190
https://github.com/aws/amazon-genomics-cli/pull/150

Description of how you validated changes
[//]: #  built the sources locally with npm run build
Checklist

[ ] If this change would make any existing documentation invalid, I have included those updates within this PR
[ ] I have added unit tests that prove my fix is effective or that my feature works
[x] I have linted my code before raising the PR
[x] Title of this Pull Request follows Conventional Commits standard: https://www.conventionalcommits.org/en/v1.0.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

closing in favor of a smaller footprint of https://github.com/aws/amazon-genomics-cli/pull/192


Factory reset doesn't clear KVS admin pairings

Problem
Factory reset doesn't reset admin pairings. This definitely happens on M5, unsure about others
Proposed Solution
Reset admins on Factory reset - should be done in a way that this works for all platforms.

@cecille any idea if this is still an issue?

I'm not sure - sorry. I do think we need factory resets to be working properly for v1.0, but I'm not sure if it's something that's explicitly covered by the SDK vs. something that's covered by platform. @harimau-qirex may have a better idea as it touches on storage.

Factory reset is handled per platform, as the matter doesn't really support Factory reset at this point.


Improving the set theory ergonomics

The tactics such as ∈⇔P are pretty nice, but there is of course the issue that we have to copy&paste it everywhere. Maybe there's some solution that doesn't require a major Agda patch.

Conversions between different types of sets with extra structure are a big source of clutter. #23 is related to this, but there's also an inverse problem of how to add structure to sets. Type classes might be a solution, but it would be nice to find something that doesn't pollute every definition. Related to this is that inference sometimes breaks because of this (since when we prove a theorem about things that are projected out from something, there's no information to unify it back from, even if it's obvious what it should be).

Closed in favour of https://github.com/input-output-hk/agda-sets/issues/4 and https://github.com/input-output-hk/agda-sets/issues/5


[Improve] Improve streampark-common module base on [3.5 Concurrent Processing]

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Improve streampark-common module base on 3.5 Concurrent Processing
Usage Scenario
No response
Related issues
#2986
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

N.A

hi @RocMarshal  i am a new person who wants to participate in this project, Can you assign this task to me?


Themes/Templates

Hi there,
i am currently looking for smoe themes. But sadly i wasn't able to implement one...
Could anybody please share some resource links? It could also be a bundle or anything where i have to pay a little bit. Free to use would be prefered but it's  no must have.
I am also looking for a complete pool dashboard. I am running multiple instances of MPOS pools for different coins, and i would like to setup a dashboard with all coins like on http://ispace.co.uk/ pool.
Anybody here who can help me out? :)

This is a bug reporting tool, not a community forum to find support on implementing custom features :-) Please refer to an online source of your choice to contact developers to implement a new custom theme.
MPOS comes with a default theme which is the only one we support.


Add Unique Serial ID to X-Input Device Descriptor

Currently we have an X-Input String version with a static value of "08FEC93" in XInputDescriptors.h
According to https://learn.microsoft.com/en-us/windows-hardware/test/hlk/testref/0f2d5113-cf70-4cda-8afc-b7005d1e2739 the version ID with the serial should be unique per device to tell Windows when a "new" device has been plugged in versus an already recognized device.
What we should do is remove our 4 byte serial and replace it with the first-last-hash? 4 bytes of the unique Pico ID serial. This can be done at driver start-up once.

We are already doing this for the Xbox One which uses a much larger 16 byte serial ID. We are doing it with the following code:
`static const uint8_t * xbone_get_string_descriptor(int index) {
if ( index == 3 ) {
// Generate a serial number from the pico's unique ID
pico_unique_board_id_t id;
pico_get_unique_board_id(&id);
memcpy(uniqueSerial, (uint8_t*)&id, PICO_UNIQUE_BOARD_ID_SIZE_BYTES);
return uniqueSerial;
} else if ( index == 4 ) { // security method used
return xboxSecurityMethod;
} else if ( index == 0xEE ) { // ONLY WINDOWS DOES THIS??
return xboxOSDescriptor;
}
return xbone_string_descriptors[index];

}`
If we could convert this to our 3-byte serial ID for the xbox OG, we'd be in good shape


CachePadded: use 128-byte alignment on x86-64

Motivation: https://www.reddit.com/r/rust/comments/akzas0/lockfree_rust_crossbeam_in_2019/efa26r1/

bors r+


Adding a check for chaincodeName/Path/ID

Description
This change adds a check for chaincodeName/chaincodePath/chaincodeID when triggering deploy, invoke, and query operations through the Node.js sdk.
Motivation and Context
Adding a check for the presence of chaincodeName or chaincodePath in the deploy request as well as the presence of chaincodeID in the invoke and query requests. If the chaincodeName/Path/ID are not supplied, an error will be returned.
How Has This Been Tested?
This change has been tested with the existing sdk unit test cases. I have also added three new tests cases to chain-test.js file in order to check for the missing parameter and make sure the tests fail as expected.
Checklist:

[x] I have added a Signed-off-by.
[x] I have either added documentation to cover my changes or this change requires no new documentation.
[x] I have either added unit tests to cover my changes or this change requires no new tests.
[x] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Anna D Derbakova<EMAIL_ADDRESS>Adding a check for the presence of chaincodeName or chaincodePath in
the deploy request as well as the presence of chaincodeID in the invoke
and query requests. If the chaincodeName/Path/ID are not supplied, an
error will be returned.
Fixes #1891

This has a merge conflict, likely due to the merge of PR #2042. Please rebase on master.

Reopening another PR from a rebased branch. Thanks.


Deploy without Docker command incorrect

I tried to run the fdp example.com 80 --db='http://dbpedia.org/sparql' command described at https://github.com/NLeSC/fairdatapoint#deploy-without-docker, but got a error about the graphviz executable fdp.
What did work was
fdp-run localhost 8888 --db='http://dbpedia.org/sparql'

Can the README be updated?

Trying out http://localhost:8888/catalog and http://localhost:8888/fdp gave no content and not found errors respectively.
Can I not use http://dbpedia.org/sparql as a database?

It is a bad example to use 'http://dbpedia.org/sparql', because you cannot use it.
The SPARQL must be a SPARQL database to which you have write access.

solved in #62 .


RFC: Use different default queue path

/tmp is cleaned up regularly by systemd-tmpfiles, so persistent queues will be lost if the service is down for prolonged times. Examples of this are e.g. https://github.com/indigo-dc/oidc-agent/issues/519
On some systems, /tmp is stored on a ramdisk, so it will be lost upon reboot.
For persistent storage, /var/lib should be used according to FHS, and it seems reasonable to use the name of the package as subdirectory there to ensure correct namespacing / prevent collisions.
Ideally, this directory would be created (with correct SELinux contexts) by the RPM / DEB files — if someone can point me to the location of these, I can also create a PR for these.

You could change the defaults here: https://github.com/opensciencegrid/xrootd-monitoring-shoveler/blob/main/config/config.yaml#L43 and https://github.com/opensciencegrid/xrootd-monitoring-shoveler/blob/main/queue.go#L47
And also add to the .goreleaser.yaml under contents:
- dst: /var/lib/xrootd-monitoring-shoveler
  type: dir
  file_info:
    mode: 0700

@djw8605 Thanks, will do that in a follow-up commit and add it to the PR :+1: .
I realize only now, looking at your YAML snippet, that the tool seems to expect that it is executed as root, and also the systemd unit does not specify a user it is executing as.
Is this really expected? Since WLCG is asking whether we put this tool into production, and not even xrootd itself is running as root, I'd rather not run a monitoring tool as root user.
For sure, this can go in a follow-up PR (or an issue, since my knowledge of Go is very limited...), but it seems running this as `root is not really necessary.

Should the queue be in a sub directory under /var/lib/xrootd-monitoring-collector?  For example /var/lib/xrootd-monitoring-collector/queue

Should the queue be in a sub directory [...]

Sure, that is very reasonable! Especially in case other files will ever be added at a later point which may be stored persistently.
I'll adapt the commits later on and re-push.

may I suggest to use /var/spool to store persistent data instead of /var/lib? it seems a more proper place

may I suggest to use /var/spool to store persistent data instead of /var/lib? it seems a more proper place

You are correct, indeed, while both are persistent, for queue data, spool is a much better fit since it is data meant to be processed later.
I'll edit the commits accordingly later on, thanks! :+1:

@kazeborja Done, it's now changed to /var/spool/xrootd-monitoring-shoveler/queue, this is definitely more correct :+1: .

@djw8605 Happy New Year to you :+1: .
Just pinging to check whether you had time to look at this PR? I keep getting reminders by GGUS/WLCG to roll this tool out every few days, and plan to open another PR (I already have to code developed) to implement "running as user" once this PR and my other one are in.
Thanks in advance!

All looks good to me. Any idea how an upgrade would go from the current version?

That's a good question. The way things are now, I would expect things to be abandoned indeed if there is still something left in the queue before the upgrade.
Adding an explicit migration procedure is likely too heavy to cover this unlikely (one-time) case — maybe it would be sufficient to mention this in the release notes? Those who have a not-yet-submitted queue to carry over could either configure xrootd-monitoring-shoveler to use the old path manually, or migrate the queue and use the new default.
What do you think?

Indeed, I think it's probably enough to add it to the release notes (as if anyone reads that though).

@djw8605 Thanks for merging! In fact, I read the release notes of (almost) all packages which I run in production and which are not distro-maintained before upgrading them, but that's indeed not the usual site-admin approach, sadly.


question about the ws server implementation

Hi paldepind,
What do you think about replace ws in the backend with uWebSockets?
It has a benchmark table where it seems that performed really well and is completly compatible with ws.
I know that the game wilds uses this behind.

I'm also interested in using other WebSocket module, ws is simple but a kind of hard to insert authentication logic


fix(step-challenge): Fix duplicate keys in Step

This PR fixes an issue in Step.jsx where if the step had no associated image, react would lose track of elements because of duplicate keys.
This PR addresses that by assigning unique keys to Step elements using strings and an index

Are there step challenges that don't have images? Should the issue be address there?

@BerkeleyTrue Yes - there are step challenges that don't have images.

@QuincyLarson is this intentional? Step challenges where designed to have an image per step

Block introductions are step challenges without images

@Bouncey thanks I see now. We should change the key from using the image url to using the a substring of the text of the step since this should always be defined