Theme

✨ Codu Pull Request 💻

👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
Pull Request details:
Installation of next themes, tailwind animations plugin. Theme provider creation and basic theme toggler. Only nav styling bg updated. Future styles to be applied for all elements with pseudo class.
Any Breaking changes:

Potential client components for next 13 application. Stable in 12.

Associated Screenshots:

Something is causing the build to break too 🤔 You might need to run npm run build locally to see if you can find the error.

I think I fixed the error, but I am unsure as it requires authorization to deploy. Basically an empty prop interface can break things


Color Theme not Matching OS Settings

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
The default theme for Docusaurus sites should match the OS theme (dark vs light mode). Currently it always defaults to light mode.
Steps to reproduce

Open site

Expected behavior
Default theme to match OS setting (dark mode vs light mode).
Actual behavior
Always defaults to light mode.
Your environment

Public source code: https://github.com/dynamoose/dynamoose
Public site URL: https://v3.dynamoose.pages.dev
Docusaurus version used: 2.0.0-beta.9
Environment name and version (e.g. Chrome 89, Node.js 16.4): Safari Version 15.1 (17612.3.5), Node.js 16.13.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS): macOS 12.1 Beta (21C5039b)

Reproducible demo
No response
Self-service

[ ] I'd be willing to fix this bug myself.

Hi, Docusaurus has set respectPrefersColorScheme: true, in our website:
https://github.com/facebook/docusaurus/blob/cd96ce165c052fe1c6f82b9e1e41e31b03314722/website/docusaurus.config.js#L324
So on first visit to the website, the prefers-color-scheme is indeed respected. However, we also preserve the color mode you chose in local storage, so that on next visit, you still see the same color mode.
If you open Docusaurus website in a private / incognito window, you should see a default dark mode. I have confirmed with tests on Chrome and Safari.
If it's not the case for you, I suggest you open the browser console and enter window.matchMedia('(prefers-color-scheme: dark)').matches. If the return value is not true, that means your browser doesn't pick up your system preferences.

Just realized you are not talking about Docusaurus site but your own site. I had no idea why I misunderstood😅 Please read the docs: https://docusaurus.io/docs/next/api/themes/configuration#respectPrefersColorScheme


f1 metric for query_named_entity_recognition_new task

Thanks for this awesome benchmark! It's a great gift for the community.
I just have a question regarding the f1 metric for the query_named_entity_recognition_new task. My intuition is we should compute an f-1 score for each sample, and then average them to get the task-wise score. However in the code here, the task-wise score is the f-1 computed across all samples. What is the rationale for this calculation, and why is this preferred over the former more intuitive method? Thank you

Hi, thank you for your interest in our work!
According to this paper, the TP, FP, FN, etc. are first evaluated over the whole corpus, before calculating the F1 score.

Got it. Thanks for the pointer and explanation.


Prevent adding yourself as a DM recipient when other recipients are present.

This PR changes -

When composing a DM, if there are already addressees present, we restrict own user suggestion in the typeahead, and not pillify name if you type it out. It should not be possible to add own user to the list of recipients in this case.
If there are no addressees present, it should be possible to add own user as it is now (so that you can DM yourself). However, if user then adds any other addressees, we clear the current user_pill widget.

Fixes: zulip#31629

Screenshots and screen captures:
Screencast from 18-09-24 04:12:21 AM IST.webm

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Adding a group that includes the current user throws an error:

The UX feels good to me; please add the maintainer review label and tag @evykassirer for review when the feedback above has been addressed.

@alya Checked and this is available on main as well. Not quite sure what the exact reproducer is but group with small number of participants doesn't throw error and also I am seeing this error on chrome only(no error on firefox).

Adding a group that includes the current user

This shouldn't matter much since adding group members doesn't add own user pill by default.

@zulipbot add "maintainer review"

@evykassirer can you review sometime

I also wasn't able to reproduce this error on Firefox. @alya can you check if you can reproduce it on Chrome on CZO? And if so then we should open a separate issue for that.
I've confirmed that (on Firefox, at least) adding a group with the current user in it doesn't add that user's pill.

LGTM!

Oh, good point, I didn't think to check -- I do see the same error without this PR.

@zulipbot remove "maintainer review"
@zulipbot add "integration review"

@timabbott ready for you to review

Merged, thanks @pratik-pc and @evykassirer!


(null): Name is required error showing up for sidekicks without names

Rancher Version: v1.2.0
Steps to Reproduce:

Add service
Add two sidekicks but don't fill out name
Click on create

Results: (null): Name is required error showing up

Expected:  Might want to replace null with sidekick1, sidekick2.  Or just maybe sidekick so they where to look.

Changed in 2.0..

Version - master 9/15
Verified


Set up MongoDB database

A database to store the default values

Additional Info: Reports are currently saved to disk. The goal is to implement MongoDB to store these reports. The backend should be able to retrieve data from the database, and users should be able to access specific reports.
This is how it currently looks in the React app:

Phase 1/3 Sub-Issues:

[ ] https://github.com/oss-slu/DroneWorld/issues/107
[ ] https://github.com/oss-slu/DroneWorld/issues/108
[ ] https://github.com/oss-slu/DroneWorld/issues/109


⚠ SceneTime has degraded performance

In 1be02b9, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1653 ms

Resolved: SceneTime performance has improved in 417d07f after 7 minutes.


Error after update 4.0.6 to 4.0.9

After update sqlite3 from 4.0.6 to 4.0.9, application crash with error:
TypeError: Cannot read property 'prototype' of undefined
    at inherits (/app-test/node_modules/sqlite3/lib/sqlite3.js:27:16)
    at Object.<anonymous> (/app-test/node_modules/sqlite3/lib/sqlite3.js:66:1)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at ConnectionManager._loadDialectModule (/app-test/node_modules/sequelize/lib/dialects/abstract/connection-manager.js:74:14)
    at new ConnectionManager (/app-test/node_modules/sequelize/lib/dialects/sqlite/connection-manager.js:22:21)
    at new SqliteDialect (/app-test/node_modules/sequelize/lib/dialects/sqlite/index.js:14:30)
    at new Sequelize (/app-test/node_modules/sequelize/lib/sequelize.js:320:20)
    at MySQLInitializer.initialize (/app-test/initializers/mysql.js:24:25)
    at Utils.initializeFunction (/app-test/node_modules/actionhero/classes/process.js:138:31)
    at Object.api.utils.asyncWaterfall (/app-test/node_modules/actionhero/initializers/utils.js:77:31)

Node: 10.15.1
npm: 6.7.0
OS: SunOS Solaris <IP_ADDRESS>.0

Need a simple code example for the failure, thanks.

@kewde It fail on initializing:
api.config.mysql = {
  user: 'some_user',
  password: 'some_pass',
  database: 'some_db',
  host: 'some_host',
  port: 3306,
  pool: {
      maxConnections: 20,
      maxIdleTime: 30000,
  },
  charset: 'utf8mb4',
  timezone: '+00:00',

  dialectOptions: { decimalNumbers: true },
  dialect: 'sqlite',
  storage: ':memory:',
  omitNull: true,
  logging: false,
};

const { database, user, password } = api.config.mysql;
api.config.mysql.logging = (text, params) => {
    api.logger.info(`${text}. Bind: [${params.bind || []}]`);
};

const sequelize = new Sequelize(database, user, password, api.config.mysql); // FAIL HERE

This is an SQLite library, I don't understand what all this MySQL related configuration code is doing in there?

https://www.npmjs.com/package/sequelize use SQLite  as dialect. If I update only sqlite from 4.0.6 to 4.0.9 it cause fail on Solaris

I have this same issue using this module as a test mock for native sqlite in a react native project. If I comment out inherits(Backup, EventEmitter); on line 62 in lib/sqlite3.js it doesn't throw with Cannot read property 'prototype' of undefined and what functionality I use for my test mocks completes without issue. my binding is node-v64-darwin-x64. I'm just sticking with 4.0.6 for now.

nevermind, running node-pre-gyp reinstall in the sqlite3 node_module folder fixes this for me. I'm guessing I was hitting an old local cache.


Translations

Hello, how are you? I've implemented the plugin in my application but when the user isn't logged, the messages aren't translated, when the user is logged all works ok. Do you know the reason of this problem? Maybe the plugin has some configuration that block translations when the user isn't logged.
I would appreciate if you can help me with this issue! :)

The extension does not differentiate between logged in and visitor state during translation.
Best Regards


README documentation link error.

clickYaml version: 1.1.1
Python version: 3.10.5
Operating System: Windows 10

Description
Error regarding the README. The documentation link (https://clickyaml.readthedocs.io/) does not return a valid documentation page:

Hi, Thanks for submitting the issue. I am working on the documentations. Should be up soon.

Hi,
This has been fixed. The documentation is up and running.


AWS EKS cluster autoscaler implementation

Description
This implementation allows to deploy AWS EKS multi-az cluster and and it's infrastructure including VPC, subnets and cluster autoscaler.
How Has This Been Tested?

[x] Cluster deployed

Test Configuration

Platform: AWS

Screenshots

[x] No screenshot

Could you fix the formatting here please?


Improve rate limit policy

This PR improves the rate limit policy according to the comments of PR #665.
From #703.

Apart from what I commented above, the PR looks good to me :+1:


projects support like jest?

Clear and concise description of the problem
For example, I want to test browser and node entry at the same time with correct coverage
Suggested solution
As title
Alternative
For now, I'm using
{
  "test": "run-p test:*",
  "test:browser": "vitest run --coverage",
  "test:node": "cross-env TEST_ENV=node vitest run --coverage"
}

This works, but the coverage is partial
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Duplicate of https://github.com/vitest-dev/vitest/issues/256

@sheremet-va I think they are not the same? The issue you linked is related to monorepo, this one is not, but for different environments.

@sheremet-va I think they are not the same? The issue you linked is related to monorepo, this one is not, but for different environments.

It's the same implementation.

It's the same implementation.

But you closed this issue as not-planned? And the linked issue's title can be updated IMO.


Update next/yjs/slate example

Added some details for setting up yjs/slate with the older Next /pages/api routes

Excellent changes, thank you for leaving a PR for us! 😄 Would you mind applying my changes?

Glad to help!


[Cryptographer] / [Can encrypt and decrypt all the text in a document and stores in a new file]

[x] Create a folder in the Projects Folder with the name of your project
[x] Create a README.md file describing your project briefly

I will do all the necessary things and will create a pull request.. Please accept this for hacktober fest..

/assign


Support Coursier plugins via customizing FileCache used (with classloaders)

Currently loading a Coursier plugin is not possible, because the ClassLoaders that are used by Mill's Coursier cannot be changed. I ran into this when trying to use my plugin which adds support for a new protocol. Loading via $ivy. or anything else doesn't work because Mill uses the default Coursier cache
This PR adds a hook to allow altering the FileCache used. With this, I can put the following in my build module:
  override def cacheCustomizer: Task[Option[FileCache[coursier.util.Task] => FileCache[coursier.util.Task]]] = T.task {
    Some( (fc: FileCache[coursier.util.Task]) => {
      fc.withClassLoaders(Seq(classOf[coursier.cache.protocol.S3Handler].getClassLoader)) }
    )
  }

Which then fixes the resolution so that when it looks for plugins it can find my class.
This PR borrows ideas from #775
If there's better way to achieve this lmk

thx @lefou - how do I find a build with this that I can try using with .mill-version?

@nitay Our release pipeline is currently broken. Once, we fixed it, I'll release a 0.10.1.

Coming back at this PR 2+ years later. I'm seeing that it's the one that added a call to noCredentials on FileCache. Was there a specific motivation for that? Or was it… something that you tried while debugging, and that made it anyway, say?

I would blame that for https://github.com/com-lihaoyi/mill/issues/3408

@alexarchambault Can't tell. It probably slipped through my radar, since the term credentials isn't anywhere in this changeset.


[Gauge] [ERROR] notif #0: initialized: current runner is not compatible with gauge LSP

Describe the bug
Created a project using "Create new Gauge Project"
Run spec of Default example.spec (vowels)
Python is installed and added to environment variable.
17-04-2020 17:10:41.107 [Gauge] [DEBUG] Unable to connect to runner : Timed out connecting to python
Some of the gauge lsp feature will not work as expected.
17-04-2020 17:10:41.107 [Gauge] [INFO] LangServer: reading on stdin, writing on stdout
17-04-2020 17:10:41.112 [Gauge] [ERROR] notif #0: initialized: current runner is not compatible with gauge LSP
What command(s) did you run when you found the bug?
Run Spec

### Output, stack trace or logs related to the bug
17-04-2020 17:10:11.105 [Gauge] [DEBUG] Adding specs from xxx\specs\example.spec
17-04-2020 17:10:11.105 [Gauge] [INFO] Initializing steps cache with 1 steps
17-04-2020 17:10:11.106 [Gauge] [INFO] Starting language runner
'"xxx\AppData\Local\Programs\Python\Python38-32\python.exe -m pip install getgauge==0.3.7 --user"' is not recognized as an internal or external command,
operable program or batch file.
Traceback (most recent call last):
File "check_and_install_getgauge.py", line 32, in assert_versions
getgauge_version = pkg_resources.get_distribution('getgauge').version
File "xxxx\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pkg_resources\__init__.py", line 481, in get_distribution
dist = get_provider(dist)
File "xxxx\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pkg_resources\__init__.py", line 357, in get_provider
return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
File "xxxx\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pkg_resources\__init__.py", line 900, in require
needed = self.resolve(parse_requirements(requirements))
File "xxxxAppData\Local\Programs\Python\Python38-32\lib\site-packages\pkg_resources\__init__.py", line 786, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'getgauge' distribution was not found and is required by the application

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "check_and_install_getgauge.py", line 40, in <module>
assert_versions()
File "check_and_install_getgauge.py", line 36, in assert_versions
install_getgauge("getgauge=="+expected_gauge_version)
File "check_and_install_getgauge.py", line 20, in install_getgauge
check_output([" ".join(install_cmd)], shell=True)
File "xxxx\AppData\Local\Programs\Python\Python38-32\lib\subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "xxxx\AppData\Local\Programs\Python\Python38-32\lib\subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['xxx\\AppData\\Local\\Programs\\Python\\Python38-32\\python.exe -m pip install getgauge==0.3.7 --user']' returned non-zero exit status 1.
Traceback (most recent call last):
File "start.py", line 8, in <module>
import grpc
ModuleNotFoundError: No module named 'grpc'
17-04-2020 17:10:41.107 [Gauge] [DEBUG] Unable to connect to runner : Timed out connecting to python
Some of the gauge lsp feature will not work as expected.
17-04-2020 17:10:41.107 [Gauge] [INFO] LangServer: reading on stdin, writing on stdout
17-04-2020 17:10:41.112 [Gauge] [ERROR] notif #0: initialized: current runner is not compatible with gauge LSP

### Versions
Python Version :3.8
VScode version : 1442.
Gauge Extension Version : 0.0.13

#### Gauge (Output of `gauge -v`)
Gauge version: 1.0.6
Commit Hash: 2bc49db

Plugins
-------
html-report (4.0.8)
python (0.3.7)
screenshot (0.0.1)
spectacle (0.1.3)
xml-report (0.2.2)

#### Node.js/Java/Python/.Net/Ruby version
Python
#### Operating System information
Windows 10 1809 OS build 17763.1098
#### IDE information
Visual studio code 1.44.2

can you try with latest gauge and gauge-python (i.e 0.3.9 at the time of writing this)?
I am able to create a new project using gauge 1.0.8 and gauge-python0.3.9.

@nischt - are you still facing this issue? Is there a project that I can see this failure -  that'll help investigate better.
PS - There have been new releases, please try upgrading as well.

Closing due to inactivity.. feel free to reopen if you are still facing the issue with latest versions


compressio and encryption

pls provide an meta section with magic number and compression and encryption

Those are both out of the scope of this project.  You will need to handle compression/encryption yourself, prior to parsing the data with BeeSchema.


@input decorator dose not check is input provided or not

I have defined a schema for input decorator but it doesn't check if the parameters provided or not
My route example:
@bp.get("/test")
@bp.input({"a": String(), "b": Integer()}) # data
@bp.output({"a": String()})
def test(data):
    return data

My json body:
{
    "a":"string"
}

I got this as response:
{
    "a":"string"
}

but I expect some error like missing field(s) ['b']

PLease help me!!! Am I wrong somewhere?

Environment:

Python version: 3.7.9
Flask version: 2.1.2
APIFlask version: 1.0.3.dev0

You need to set required to True to mark a field as required:
@bp.input({"a": String(), "b": Integer(required=True)})


LSTM layer trained on GPU -> cannot load on CPU (No OpKernel was registered to support Op 'CudnnRNN' )

Hi.
I'm training a model with a LSTM layer, which gets trained on GPU, and for which I believe the "cuda optimized" implementation is automatically being used at train time.
If I save this model as a TF savedmodel, upon loading I get the following error:
tensorflow.python.framework.errors_impl.InvalidArgumentError: No OpKernel was registered to support Op 'CudnnRNN' used by {{node StatefulPartitionedCall/lstm_1/CudnnRNN}} with these attrs: [rnn_mode="lstm", dropout=0, seed=0, is_training=true, direction="unidirectional", T=DT_FLOAT, seed2=0, input_mode="linear_input"]
Registered devices: [CPU]

tf.keras does not exhibit the same behaviour - I suspect it's automatically dealing with falling back to a non-Cudnn version of the RNN layer?
Code to reproduce:
1: Train + save code (run with GPU available)
NB: Switching the keras import to tf.keras makes the model load work correctly!
import os

os.environ["KERAS_BACKEND"] = "tensorflow"

import numpy as np

import keras_core as keras
# from tensorflow import keras # If I switch to this keras implementation, the model load works correctly!

window_size = 500
X = np.zeros((1024, window_size, 1))
Y = np.zeros((1024, window_size, 1))

n_layers = 2
n_units = 256
n_epochs = 2
batch_size = 32

# MODEL
x_in = keras.layers.Input(shape=(window_size, 1))

x = x_in

for _ in range(n_layers):
    x = keras.layers.LSTM(n_units, return_sequences=True, stateful=False, activation='tanh')(x)

y = keras.layers.Dense(1, activation='linear')(x)

model = keras.models.Model(inputs=x_in, outputs=y)

model.compile(optimizer=keras.optimizers.Adam(), loss=keras.losses.mean_squared_error)

model.summary()

print(f'X shape: {X.shape}')

model.fit(X, Y, epochs=n_epochs, batch_size=batch_size)

model.save('lstm_model.keras')

import tensorflow as tf

module = tf.Module()
module.model = model

# batch size = 1 in inference, variable length
SHAPE = (batch_size, window_size, 1)

# SHAPE = (1, None, 1)
@tf.function(autograph=True, input_signature=[tf.TensorSpec(shape=SHAPE, dtype=tf.float32)])
def fn(x):
    outputs = model(x)
    return outputs

module.fn = fn

tf.saved_model.save(module, 'lstm_model.tf', signatures={'serving_default': module.fn})

2: Load model code (run without GPU available)
import numpy as np
import tensorflow as tf

model = tf.saved_model.load('lstm_model.tf')

batch_size = 32
window_size = 500

X = np.zeros((batch_size, window_size, 1))

Y_pred = model.fn(X)

Versions
Python 3.10
TF 2.14.0rc1
keras-core 0.1.7

Thank you for your report, as a temporary workaround you could save your model as a .keras model and then reload it on your cpu. You can then export this using saved model.
Could you take a look @qlzh727, thank you!

@sampathweb

Sorry for the very late reply.  I think this issue is caused by RNN implemention in TF backend, which is bit different from the existing tf-keras. We should port the existing tf keras implementation to the new keras, which will solving this issue.
There are multiple issue related to this root cause, and I think @sampathweb will try to fix that when he have more cycle.,

As the current walkaround (as @grasskin suggested), you can save your model and load back on CPU devices, which then will be able to export as proper saved model.

Revisiting this: the issue here is that TF SavedModel is a low-level format that includes device-related information (in this case, kernels that are only registered for GPU). As such it cannot move across devices in the general case (though in practice the LSTM and GRU layers are the only ones that will show this issue).
Legacy tf.keras was going out of its way to pave over this limitation, but this is no longer a good idea in the multi-backend setting. As such I recommend the workaround mentioned in this issue: just save your model as a .keras file (which can move across devices), reload it on CPU, and export it to SavedModel there.


Implement loose cooking parsing

This enables correct execution of code like document.cookie = 'foo'.
Blocked on either https://github.com/request/request/pull/1811 or https://github.com/SalesforceEng/tough-cookie/pull/56.

LGTM except for the commit message (s/cooking/cookie), so once one of the prereqs gets merged feel free to merge.

@domenic Added loose mode to the constructor too now. The problem right now is (without request merging the PR), if a user of jsdom provides a cookie jar without loose mode, we'll handle malformatted cookies in document.cookie differently, than if we get the cookie from a resource request, which kind of sucks. We could set jar.enableLooseMode, but I'm not sure if it's considered public API.

Modified to only set loose mode on jars we create ourselves. If a user passes us a jar without loose mode, we'll behave strict and refuse malformed cookies.

LGTM!


Add std.math.isPowerOf2(). Supports floating-point and integers.

This is intended to supersede PR #4308, which adds std.math.isPowerOf2(). Improvements:

Support floating-point numbers.
Corrected handling of signed integers.
Reduced template bloat, by marking x as const.

@JackStouffer I have now added a commit to update std.allocator (and a few other places). Please review.

@ibuclaw

Wouldn't this fall under the too trivial for phobos category?

Phobos already contains two or three independent implementations of this function for integers; this PR just consolidates them and makes isPowerOf2() public.

When people try to implement this themselves, they often mishandle 0, and pretty much always mishandle int.min.

This PR also supports floating-point, which is harder to get right.

Making the floating-point implementation work at CTFE sadly is not trivial at the moment, because so much of std.math is off-limits.

Needs tests for FP numbers around -F.max and F.max. Both CT and RT. Also needs a proof that CT implementation is correct

This PR also supports floating-point, which is harder to get right.

This is not so hard.

Making the floating-point implementation work at CTFE sadly is not trivial at the moment, because so much of std.math is off-limits.

We don't need CTFE-able math until CTFE-able unions.

@9il

Needs tests for FP numbers around -F.max and F.max.

Done.

Both CT and RT. Also needs a proof that CT implementation is correct

The CTFE path is covered by the unit test now, also.

This is not so hard.

Most people are really bad about covering all the corner cases with floating-point (and integer, for that matter). The purpose of the standard library is not only to save people effort, but also to promote the usage of correct, properly tested algorithms.

We don't need CTFE-able math until CTFE-able unions.

I have a specific use case in mind for CTFE isPowerOf2!real(). However, since you pointed out in another thread that if(__ctfe) blocks inlining - perhaps I should just remove the CTFE support from this for now?
(I can sort of do what I want just with isPowerOf2!long(), so this part isn't strictly necessary.)

I have a specific use case in mind for CTFE isPowerOf2!real(). However, since you pointed out in another thread that if(__ctfe) blocks inlining - perhaps I should just remove the CTFE support from this for now?

Yes

@9il I have removed the if (__ctfe) block.

Rebased.

Rebased, again.

Ping @andralex .

If you want @andralex's opinion you're going to have to email him

you're going to have to email him

I did so earlier today.

Good work, thx.

Auto-merge toggled on


[WIP] Pipeline/feature extractor

Model for feature extractor pre-training.
I don't think that we should push it to main, as it is just a tool for pre-training, however, it is good to have it on github.
Until we have data, we can not use it.

It is highly probable, that this PR will not pass the check.

@mariaogryczak the error says: "FileNotFoundError: [Errno 2] No such file or directory: 'assets/sanity_check_data/test_hamnosys2.txt'" so maybe switching the path in the annotation_file will be ok for now

There is exactly a substitution of model by model_for_pretraining and additional changes in train, dataset and classification_mode to make it work, but the last three should be

In that case, I will add a parameter and do a PR to main :)

Option of pre-training was added in parser that allows using a model_for_pretraining.py file instead of model.py.
Additionally, all model parameters were gathered into MODEL_CONFIG dict to prevent parameters duplication for each possible model.


Difference between include_bitcode and enable_bitcode?

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Description
For iOS, Is the include_bitcode different than enable_bitcode? I am confused what the difference here is; the only parameter I see in Xcode's build settings is enable_bitcode but no include_bitcode

include_bitcode is an option of build_ios_app/gym ("Should the ipa file include bitcode?"), enable_bitcode is not.
From looking at the code, include_bitcode influences if uploadBitcode is set in the export options.


Add Vmotion Guidelines to EKS-A docs

Issue #, if available:
2572
Description of changes:
Added section to vsphere troubleshooting to give guidance on using VMware vmotion with EKS-A clusters.
Testing (if applicable):
Documentation added/planned (if applicable):
Adding section to vsphere troubleshooting.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.21

/cherry-pick release-0.20

/cherry-pick release-0.19


issue 4189: keystore upgrade

This PR is step 1 of a 2 step approach to allows the usage of different passwords for the for the unlocking of a Java keystore and the private key contained within:

upgrade keystore-go to v4
add support for private key passwords to the cert-manager API

The PR fixes #4189
This PR should be followed by another one that implements no 2. above to be able to close #4189 .

@mol-george Looks like the PR will need a rebase against master

/retest

closing this due to issue with running bazel on my arm mbp; submitted https://github.com/jetstack/cert-manager/pull/4428 instead


Migrate to MIT license

I'd like to migrate this repo to be under the MIT license, but to do that I need the approval of other contributors.  If each of you agree to this, can you add a comment below indicating this?
@andreaswatch relevant commits:

Wrong parsing result with decimals like 1.8 (3c7085b5230957f6b2123ff8e614be133ef98394)
Resolve Problem with other DateTimeFormat (bde3a0b4509893a2e7a5d449218b5e41e44f88cc)

@jherink relevant commits:

Corrected definition of ellipse, use axis2_placement rather than ax… (af5ae27d4853559854fccc1f16854f19f9beb939)

Yes I approve

Yes I approve
jherink<EMAIL_ADDRESS>schrieb am Fr. 17. Apr. 2020 um 20:02:

Yes I approve
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ixmilia/step/issues/13#issuecomment-615386445, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIPTSERQTI3RYMGRYO2KM3RNCKUVANCNFSM4MK5TLXQ
.


Updated demo notebook to document how to plot light curves using PyCS

Hello Dr. Marshall,
I have updated the demo notebook so that it explains how to plot light curves using PyCS. Please merge if possible. Thank you!
Milan

Thanks @milanwilliams !
I see a couple of things you need to fix before we merge (the notebook almost, but doesn't quite, run for me):

The paths to the output files should just be filenames, without the '/data/' prefix
We are importing print_function which means that print statements need parentheses, as in:

print(l.longinfo())

After that we'll be good to merge and you can move on to including the next script! I think we want this one notebook to run the whole analysis, so we can see it all together. I'll merge it in pieces though, to keep base/master up to date. Thanks!

Great! All looks good now.


Add support for multiple azure deployments

Hey @tsogp @Hankaji @LaansDole ,
This PR adds support for letting users call across multiple Azure deployments. It uses LiteLLM's proxy server to manage multiple azure deployments, behind 1 fixed endpoint.
Happy to hop on a call and talk through the PR / Proxy server if that helps!

Hi @krrishdholakia, I appreciate your time and efforts to contribute to our project. However, I have taken a look at your other forked and see pr duplication through multiple project. In addition, this repo is only for personal usage. Therefore, I will close your pr. Thank you a lot!


False positives in check122

We're seeing several reports of IAM policies that allow for Full Administrative privileges, Policy arn:aws:iam..... allows *:*, for policies that don't upon manual inspection don't seem to match that warning.
An example policy that is being matched is
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": "aws-portal:View*",
            "Resource": "*"
        },
        {
            "Effect": "Deny",
            "Action": "aws-portal:*Account",
            "Resource": "*"
        }
    ]
}

We've tried running the command invoked to do this check manually (https://github.com/toniblyx/prowler/blob/459a688b7a00cf62b1dd439874b6f622be1ace85/checks/check122#L25) on the offending policies, but when run that way they return nothing.

Hi @jamesgarfield, I'm not sure if I understood this. I tested your policy and in that case it doesn't catch that policy because of this filter [?Effect == 'Allow' && Resource == '*' && Action == '*']" so the action has to be * to be everything to everybody (full privileges). Do you have the latest version from master? I just used your policy.

I'll double check to make sure we're up to date

@toniblyx Sorry for the noise. It turns out we were using the latest tag (v2) which on closer inspection is super old. When I use the latest master this test passes fine.
Sorry again!

it's all right, thanks for using Prowler!


[deliver] add retry when fetching edit app version and edit app info

Motivation and Context
Fixes #16991
Description

Add 5 retries (with 10 second sleep) to fetching edit app version and edit app info
Big diff in tests is because of indenting a whole section 🤷♂

Testing Steps
Update Gemfile and run bundle install, bundle update fastlane, or bundle update
gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-deliver-add-retry-fetching-edit-versions"

@rogerluan We could totally do that here if we wanted but my gut here is that just one try of 10 seconds will be enough. This probably works on the web because using users interfaces are slow. We are doing things programmatically so we are probably too fast for the API 🤷♂

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


Structure of OAM Paths

Structure of OAM Paths to be explained in guideline document.

Has been done a long while ago.


DryRunMemory

With the PR i try to fix #1538. The changes fix the issue but i'm not sure if other agents are affected in a negative way.

Thanks @Enfop, looks good to me. I do not think there are negative effects for other agents, as I see it it only makes the dry-run match the actual run more closely.

Makes sense to me too.  I wonder if we should eventually allow you to edit the memory in the dry run UI.

@cantino For advanced JavaScriptAgent use cases that would be neat, don't know how many other agents could benefit from it.

I'm going to go ahead and merge this.  Thanks @Enfop!


wasm: Add WAMR support

Commit Message: Enabling WAMR(Webassembly Micro Runtime) as wasm runtime in Envoy
Additional Description:
WebAssembly Micro Runtime (WAMR) is a standalone WebAssembly (WASM) runtime with a small footprint. It includes a few parts as below:

The "iwasm" VM core, supporting WebAssembly interpreter, ahead of time compilation (AoT) and Just-in-Time compilation (JIT)

The application framework and the supporting API's for the WASM applications

The dynamic management of the WASM applications

Risk Level: Medium
Testing: Runtime unit testing, integration testing and manual testing
...
//test/integration:http2_flood_integration_test                          PASSED in 13.5s
  Stats over 4 runs: max = 13.5s, min = 11.3s, avg = 12.7s, dev = 0.8s
//test/integration:multiplexed_integration_test                          PASSED in 19.1s
  Stats over 4 runs: max = 19.1s, min = 13.5s, avg = 16.5s, dev = 2.0s
//test/common/http/http2:codec_impl_test                                 PASSED in 4.9s
  Stats over 5 runs: max = 4.9s, min = 3.6s, avg = 4.2s, dev = 0.5s
//test/integration:protocol_integration_test                             PASSED in 40.3s
  Stats over 5 runs: max = 40.3s, min = 32.0s, avg = 35.4s, dev = 2.9s
//test/integration:quic_http_integration_test                            PASSED in 13.0s
  Stats over 6 runs: max = 13.0s, min = 9.6s, avg = 10.7s, dev = 1.2s
//test/integration:quic_protocol_integration_test                        PASSED in 40.3s
  Stats over 8 runs: max = 40.3s, min = 23.5s, avg = 29.4s, dev = 5.4s
//test/extensions/filters/http/wasm:config_test                          PASSED in 3.2s
  Stats over 50 runs: max = 3.2s, min = 0.4s, avg = 0.7s, dev = 0.6s
//test/extensions/filters/http/wasm:wasm_filter_test                     PASSED in 6.2s
  Stats over 50 runs: max = 6.2s, min = 0.9s, avg = 3.5s, dev = 1.2s

Executed 855 out of 855 tests: 855 tests pass.

Docs Changes: N/A
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

The PR is waiting for https://github.com/envoyproxy/envoy/pull/16112 merging.

The PR is waiting for #16112 merging.

The fix for removed getCustomSection() was merged in https://github.com/envoyproxy/envoy/pull/16162, so you should be able to unblock this PR when you update your PR in Proxy-Wasm C++ Host repo, and merge with main branch here.

it based on “llvm 10 config” and plus manually adjustment. literally “homemade”.

From: Piotr Sikora @.>
Sent: Friday, May 7, 2021 11:31:16 AM
To: envoyproxy/envoy @.>
Cc: He, Liang @.>; Comment @.>
Subject: Re: [envoyproxy/envoy] wasm: Add WAMR support (#16057)
@PiotrSikora commented on this pull request.

In bazel/foreign_cc/BUILDhttps://github.com/envoyproxy/envoy/pull/16057#discussion_r627900557:

         "libLLVMBinaryFormat.a",

         "libLLVMSupport.a",
         "libLLVMDemangle.a",

       "libLLVMRemarks.a",

       "libLLVMCFGuard.a",

       "libLLVMTextAPI.a",

That's great, thanks for testing. It sounds like the reordering is justified.
However, 2 questions still remain unanswered:

What's the source of this new order?
Does the order produced by llvm-config --libnames from LLVM 10 also work?

Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/envoyproxy/envoy/pull/16057#discussion_r627900557, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO2CJMIGEVJBTUMUSFPBPSDTMNNIJANCNFSM43FDL7WA.

good to know. thanks

From: Piotr Sikora @.>
Sent: Friday, May 7, 2021 11:45:17 AM
To: envoyproxy/envoy @.>
Cc: He, Liang @.>; Comment @.>
Subject: Re: [envoyproxy/envoy] wasm: Add WAMR support (#16057)
@PiotrSikora commented on this pull request.

In test/per_file_coverage.shhttps://github.com/envoyproxy/envoy/pull/16057#discussion_r627904073:

@@ -57,6 +57,7 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/extensions/transport_sockets/tls/private_key:76.9"
"source/extensions/transport_sockets/tls:95.0"
"source/extensions/wasm_runtime:50.0"

You need to lower this to 40.0 to pass coverage:
(NullVM + V8) / (NullVM + V8 + WAMR + Wasmtime + WAVM) ~= 2 / 5 ~= 40%
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/envoyproxy/envoy/pull/16057#pullrequestreview-654056721, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO2CJMMSB4JBPR5V75S7L43TMNO43ANCNFSM43FDL7WA.

it based on “llvm 10 config” and plus manually adjustment. literally “homemade”.

That's not great, but hopefully it won't be an issue for the maintainers.

let me see what we can do

From: Piotr Sikora @.>
Sent: Friday, May 7, 2021 12:28:37 PM
To: envoyproxy/envoy @.>
Cc: He, Liang @.>; Comment @.>
Subject: Re: [envoyproxy/envoy] wasm: Add WAMR support (#16057)
it based on “llvm 10 config” and plus manually adjustment. literally “homemade”.
That's not great, but hopefully it won't be an issue for the maintainers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/envoyproxy/envoy/pull/16057#issuecomment-834055303, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO2CJMKUPW7NKGV3A3LGNUDTMNT7LANCNFSM43FDL7WA.

@moderation @lizan PTAL.

/lgtm deps

About the API change, what should I do to pass the check?

About the API change, what should I do to pass the check?

Wait for one of the @envoyproxy/api-shepherds to approve.

/lgtm api

@leyao-daily this needs merge with master to resolve conflicts.
@htuch @lizan could one of you please take a look at this PR?

/lgtm deps

Once the CI/CD pass, I think this PR is ready to be merged.


Client returning Incomplete consistently when using a reqwest client w/rayon

I am using rayon to map over an vec and posting that data to an API. I am using reqwest to handle the client and setting up my timeouts. If I reduce my threadpool down to 1 the issue goes away so I am thinking it is some sort of race condition between threads and some sort of shutdown that happens.
Here is the error:
RequestError(Inner { kind: Hyper(Error { kind: Incomplete, cause: None }), url: Some("http://localhost:5001/mypath/") })
I can send over trace logging to an email, if that helps.

The "incomplete" error means a request was written, but the server closed the connection before a response could be read.
This could also happen if the request was written on a kept alive socket that the server was just about to close...

I can’t reproduce this with any other client nor am I able to reproduce it with hyper when I’m doing it with only a single thread on rayon. It seems the client is shutting down before some of the parallel requests are finished.
The requests themselves can take awhile to process (30ish seconds). The keep alive on the server is 600 seconds.

What does the reqwest code look like? If it can't be reproduced with just hyper, it may be something wrong in reqwest.


[CO] Matlib reorganization

Hello all,
I had some issues with the material library when checking the machine/library behaviour, so I took the opportunity to reorganize the code. The main modifications are:

I have added a "ignore_list" parameter to compare so it is now way easier to compare the materials to find the differences
Machine.get_materials_list is now get_materials_dict(is_unique) and returns the path to the materials which simplify a lot the get/set of machine materials
I have replaced the Matlib object by its content: dict_mat (now material_dict) and all the material manipulation are handled in a single place: DMatlib.
I have rename/remove several functions and property to be more consistent and understandable
I have reorganized and added new tests to check that the behaviour is as expected: Tests\GUI\DMatLib\test_Workflow_Matlib.py now check edit, rename, delete, new, matlib=> machine and machine => matlib.

I'm only talking about these modifications now because I didn't realized how much work I was about to do. The structure and usage of the code is mostly the same as before, the new functions enabled to do the same things with fewer code lines. The code should be easier to maintain. @SebGue I hope that these modifications are matching your usages of pyleecan, I'm willing to update them if necessary.
Best regards,
Pierre

Hello Pierre,
I haven't look at your code but I got no special needs. The only nice to have feature is the capability to use more than one machine with the MatLib.
OT: At the moment I don't have too much time for contribution, so I hope you don't expect/need my input on any issue.
BR Sebastian

Hello,
Thank you for the feedback. As I used the same principal: a dictionary with a key for the library and a key for the machine we can extend it to other machine. I just wanted to be sure that you had no particular constraints since I know that we talked several times about the Material Library. So if you have no specific needs I will merge this PR (anyway the test coverage is better than before).
Best regards,
Pierre


Create Character “scorbit-the-horifying”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
4901ece5a2096ebcf25ed2c38d49b96d10201905

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/63262d2d9aa6410009e2396c


Add semver compliant build metadata to Pyro version

Addresses #921 (with a caveat. See below).
After looking at how a few projects have implemented including the commit sha in their version info, I decided on the following approach (same as that of PyTorch):

Only the version_prefix needs to be changed anytime we are doing a public release.
When setup.py is called we read the version_prefix, append the current commit information and write to _version.py.
__init__.py reads __version__ from the _version.py.

The caveat is that this will not be sufficient when Pyro is an editable install (i.e. installed via -e / --editable). In that case the source may have been modified beyond what is indicated by the commit sha in _version.py. For the case of an editable install, we will need a dynamic __version__, which first detects (via pip helper utilities) that pyro-ppl is an editable installation, and then runs the git incantations to get the current commit information. We will need to be a bit careful with this, but it can be included, if we need.

I'll wait for @jpchen's review. I realize this adds complexity, but I think it could help reduce confusion on forum.pyro.ai, on internal chat channels, and in possibly stale notebooks.

I don't see how to support pip install -e without calling git rev-parse each time pyro is loaded.

Yeah, we will definitely have to call rev-parse and use some pip helper utils to detect that the install is editable. Since pyro will be loaded only once though, it may not be noticeable. If we are willing to take on this additional complexity, I can make that change in this PR or a separate one.

@neerajprad May I merge this?

Yes, this should be good to merge! Thanks for the review.

I think we can hold off on the dynamic __version__ for now.


Org-roam: Add keybinding for org-roam-insert-immediate

This function allows the creation of file references in org-roam, without opening org-capture

Thanks!


Why I don't use PySoundFile

I saw that issue #20 was closed yesterday without an option being added for users who need to interpret two's complement fixed-point WAV files in the same way that hardware manufacturers do.  Erik de Castro Lopo's 32767 scale factor for 16-bit WAV files produces audible distortion, so it is usable for me.  Therefore, I wrote my own code to translate between 64-bit float and fixed-point WAV files.

For Windows, Python package binaries (such as libsndfile.dll) need to be compiled with the same MSVC compiler as is used to compile Python.  Otherwise, the different runtime libraries for Python and packages can result in crashes and strange error conditions.  As I understand, the PySoundFile team is using libsndfile.dll supplied by Erik de Castro Lopo rather than building from source with the MSVC version that matches each Python's version.

My work-around to problem 2) is to use pure Python packages:
a) https://github.com/WarrenWeckesser/wavio  for 24-bit WAV files
b) scipy.io.wavfile for other WAV files
Did I make any false assumptions about problem 2)?

I never ran into any problems regarding 2). Also, you are simply mistaken about 1). sndfile's scaling is simply that: scaling. If you hear any distortion, it is an artifact of something else.
Feel free to use whatever software you like though. No one is forcing you to use PySoundFile.

We should probably try to be a bit more constructive here ...
@Whistler7: I'm moving your point 1) to https://github.com/bastibe/PySoundFile/issues/20#issuecomment-76675917. Feel free to re-open #20 if you think it's necessary.
As for 2), the only problem I'm aware of, is that file descriptors cannot be used in Windows if the DLL isn't compiled with the same compiler as the Python interpreter.
Using file descriptors can cause an error to be raised (there should be no crash).
See #63 for more details.
Did you actually experience a crash?
How can we reproduce it?
Can you give an example for the "strange error conditions"?

As I understand, the PySoundFile team is using libsndfile.dll supplied by Erik de Castro Lopo rather than building from source with the MSVC version that matches each Python's version.

We're currently providing DLLs with with our installers, which were not created with MSVC.
But you can easily replace the DLL with any other DLL of yours. If you're having problems doing that, feel free to ask here for help.


External Storage disconnecting on world reload.

It seems that when I quit and reload my world, my network requires me to break and replace my External Storage (or the cable connecting it to the network). This is connected to a drawer controller by the way.

Ah, will fix this for next version.


Change the order of state.on_enter and transition.action

It seems like an order of state.on_enter handler and transition specific action is incorrect.
Test code:
binary_sensor:
  - platform: gpio
    pin:
      number: GPIO16
      mode: INPUT_PULLDOWN_16
    name: "Button #2"
    on_click:
      - min_length: 50ms
        max_length: 350ms
        then:
          - state_machine.transition: BTN2_SHORT_CLICK

script:
  - id: filling
    mode: single
    then:
      - delay: 2s
      - state_machine.transition: FILLING_OK

state_machine:
  - name: State Machine
    id: fsm
    initial_state: FSM_STATUS_OK
    states:
      - name: FSM_STATUS_OK
      - name: FSM_IN_PROGRESS
        on_set:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_set handler");'
        on_enter:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_enter handler");'
        on_leave:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_leave handler");'
    inputs:
      - name: BTN2_SHORT_CLICK
        transitions:
          - from: FSM_STATUS_OK
            to: FSM_IN_PROGRESS
            action:
              - lambda: 'ESP_LOGW("BTN2_SHORT_CLICK: FSM_STATUS_OK -> FSM_IN_PROGRESS", "action handler");'
              - script.execute: filling
        action:
          - lambda: 'ESP_LOGW("BTN2_SHORT_CLICK", "action handler");'
      - name: FILLING_OK
        transitions:
          - FSM_IN_PROGRESS -> FSM_STATUS_OK

Log output:
[18:25:19][D][binary_sensor:036]: 'Button #2': Sending state ON
[18:25:19][D][binary_sensor:036]: 'Button #2': Sending state OFF
[18:25:19][D][state_machine:099]: BTN2_SHORT_CLICK: transitioned from FSM_STATUS_OK to FSM_IN_PROGRESS
[18:25:19][W][FSM_IN_PROGRESS:072]: on_enter handler
[18:25:19][W][BTN2_SHORT_CLICK: FSM_STATUS_OK -> FSM_IN_PROGRESS:082]: action handler
[18:25:19][W][BTN2_SHORT_CLICK:085]: action handler
[18:25:21][D][state_machine:099]: FILLING_OK: transitioned from FSM_IN_PROGRESS to FSM_STATUS_OK
[18:25:21][W][FSM_IN_PROGRESS:074]: on_leave handler

Expected sequence of events:

Button pressed
Input BTN2_SHORT_CLICK processed
BTN2_SHORT_CLICK transition-specific action done
BTN2_SHORT_CLICK action done
State machine state changed
State machine state.on_enter called
...
State machine state.on_leave called

The actual sequence of events:

Button pressed
Input BTN2_SHORT_CLICK processed
State machine state changed
State machine state.on_enter called
BTN2_SHORT_CLICK transition-specific action done
BTN2_SHORT_CLICK action done
...
State machine state.on_leave called

The impact and the result are mixed up. I think the sequence will be significantly more logical if the impact precedes the result.

@muxa I don't know what version it has =) How can I check it?
I think I use the latest version of state machine (but I'm not sure) cause I use it as external component:
external_components:
  - source:
      type: git
      url: https://github.com/muxa/esphome-state-machine

ESPHome version is 2021.9.3 if it matters.
It seems we have a misunderstanding here. In my example I referred to this sequence:
transition.on_action -> input.on_action -> new_state.on_enter -> ... -> new_state.on_leave
Are you talking about on_leave handler of previous state?  Like this:
prev_state.on_leave -> transition.on_action -> input.on_action -> new_state.on_enter

The sequence of calling the action should probably be:
on_leave -> transition.on_action -> input.on_action -> on_enter
If in this case prev_state.on_leave and new_state.on_enter then I completely agree with you. But my test yaml generates this sequence:
new_state.on_enter -> transition.on_action -> input.on_action -> new_state.on_leave
It looks strange.

Would it be useful to split the two on_action configs into on_leave and on_enter to allow for more fine-grained control?
Yep. That would be my next suggestion =) The only wish is to name them before_state and after_state. I think it will be clearer this way.
Thus, the sequence will be as follows:
prev_state.on_leave -> prev_transition.after_state -> prev_input.after_state -> new_input.before_state -> new_transition.before_state -> new_state.on_enter

What do you think about it?

@GrKoR
I'm thinking of adding support for conditional transitions in future, so in order to support that I think the following sequence will be more appropriate (I've used on_before_transition and on_after_transition to make it a bit more semantic):
prev_transition.on_before_transition -> prev_input.on_before_transition -> prev_state.on_leave -> new_input.on_after_transition -> new_transition.on_after_transition -> new_state.on_enter
I'm not sure about the order of new_input and new_transition though...

I might fix the callback order first before going too far down the rabbit hole of the new structure of actions.

@GrKoR I've pushed a small update:

1.0.0-rc.8
Moved transition/input actions to before on_leave actions

This produces the following output:
[20:34:33][D][binary_sensor:036]: 'Button #2': Sending state ON
[20:34:33][D][binary_sensor:036]: 'Button #2': Sending state OFF
[20:34:33][D][state_machine:099]: BTN2_SHORT_CLICK: transitioned from FSM_STATUS_OK to FSM_IN_PROGRESS
[20:34:33][W][BTN2_SHORT_CLICK: FSM_STATUS_OK -> FSM_IN_PROGRESS:054]: transition action handler
[20:34:33][W][BTN2_SHORT_CLICK:057]: input action handler
[20:34:33][W][FSM_STATUS_OK:040]: on_leave handler
[20:34:33][W][FSM_IN_PROGRESS:045]: on_enter handler
[20:34:35][D][state_machine:099]: FILLING_OK: transitioned from FSM_IN_PROGRESS to FSM_STATUS_OK
[20:34:35][W][FSM_IN_PROGRESS:047]: on_leave handler
[20:34:35][W][FSM_STATUS_OK:038]: on_enter handler

I've tweaked logging a bit:
state_machine:
  - name: State Machine
    id: fsm
    initial_state: FSM_STATUS_OK
    states:
      - name: FSM_STATUS_OK
        on_enter:
          - lambda: 'ESP_LOGW("FSM_STATUS_OK", "on_enter handler");'
        on_leave:
          - lambda: 'ESP_LOGW("FSM_STATUS_OK", "on_leave handler");'
      - name: FSM_IN_PROGRESS
        on_set:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_set handler");'
        on_enter:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_enter handler");'
        on_leave:
          - lambda: 'ESP_LOGW("FSM_IN_PROGRESS", "on_leave handler");'
    inputs:
      - name: BTN2_SHORT_CLICK
        transitions:
          - from: FSM_STATUS_OK
            to: FSM_IN_PROGRESS
            action:
              - lambda: 'ESP_LOGW("BTN2_SHORT_CLICK: FSM_STATUS_OK -> FSM_IN_PROGRESS", "transition action handler");'
              - script.execute: filling
        action:
          - lambda: 'ESP_LOGW("BTN2_SHORT_CLICK", "input action handler");'
      - name: FILLING_OK
        transitions:
          - FSM_IN_PROGRESS -> FSM_STATUS_OK

This still changes the current state before calling the actions, but at least the order of actions is more correct now.
The plan is to split the transition/input actions as illustrated in previous comments.

@muxa
When I suggested before_state and after_state actions I was wrong. I was thinking in a hierarchical paradigm like this:

But now I understand that I was totally wrong.
The correct hierarchy should be formed around the transitions as you suggest. But it seems to me that you chose the wrong order of events for inputs and transitions. Here is a diagram of how I see it:

The diagram is for this state machine:

If this hierarchy is correct it looks like the input.before_transition should be called before transition.before_transition and the input.after_transition should be activated after transition.after_transition. Something like constructors for inherited classes. Input is the logical "parent" for transition cause input always prefaces transition and it is possible to have an input without transition, rather than vice versa.
P.S.
And one another thing to think about. At the bottom of diagram with transition based hierarchy I drew input.action_if_no_transition. This action handles the events that occur when there is no suitable transition. It may be useful.

@GrKoR I like the idea on before_transition and after_transition. I also can see a benefit of adding on_transition which gets called between on_leave and on_enter.
I'm still weighing the two options for input-first-transition-second approach and transition-first-input-second. I can see how each of those can be useful in different situations. And making things very flexible could make the config too complex, e.g:

The project in which I used the state machine component is frozen now. So I'll discuss things theoretically.
It seems reasonable to me to adhere to the approach of "first input - then transition". At least it corresponds more to the physical view of the process. And it helps to stick to integrity.
For example, we drop the dye into the water. The initial state (state1) will be when the water in the vessel is clean. The final state (state2) will be when the water in the vessel has a dye in approximately equal concentration throughout the volume and all mixing processes have completed.
For this physical system the steps will be as follows:
0. the system is in its initial state (state1) - the water is clean.

first there is an impact on the system (input) - a drop of dye touches the surface of the water. An input.on_input event will be here.
the drop starts the transition process - the distribution of the dye over the volume of pure water. A transition.before_transition event I think should be here.
At this stage, the system is no longer in its original state - the water is not clean. But it has not yet come to its final state. So the system has already left the state1, but has not yet come to the state2. The state1.on_leave event will be here.
then the mixing process takes place, it lasts for some time. A transition.on_transition event will be at this stage.
The mixing process is completed.
Only here we can say with confidence that the state of the system has changed and it has finally moved to state2.

The only thing that makes me doubt is the input duration. For the physical system input isn't a continuous process but instantaneous... So it may looks inconsistent if state machine will have input.after_input event that will be called after all state changes. And in general any events except input.on_input will look strange. But some of them may be useful.
May be it will be more accurate if you keep only input.on_input and input.after_transition as I draw below.

I think what you are suggesting makes sense. I think input.on_transition and input.after_transition can be omitted (or some hook is required there then transition.on_transition and transition.after_transition can be used. And if in future something on input needs to be added then can do it when there's actually a use case.
So what I'm proposing is:

For comparison the current flow is:

Great! 👍🏼
I like it! :)

@GrKoR do you mind having a look at the PR #27? There's a test.yaml that has some logs that illustrate the order of execution

@muxa I'll try to do it in a couple of days (on Thursday or Friday).

@muxa I've tested PR #27. All actions works as expected.
Great update!

Implemented in https://github.com/muxa/esphome-state-machine/releases/tag/1.0.0-rc.12


Update method names

Update method name of remove to delete to follow standards set here: https://github.com/howdyai/botkit/blob/master/docs/storage.md

Thanks for the PR and bringing this in line with the storage interface 😄 I added a few comments, nothing too big. Thanks again!

@Trudeaucj hey, thanks for a PR, there is already issue created in the repo https://github.com/howdyai/botkit-storage-redis/issues/14. Please reference it in the body of this PR as Close #14. So, the issue can be closed automatically, when PR is merged.

Ref. to existing issue #14


WIP: Updates for per site redis

[x] Update redis from global to per site container.
[x] Remove letsencrypt support temporarily as we are replacing nginx-proxy with traefik reverse proxy.
[x] Add db function to get site enabled status.

Tested. LGTM. :+1:


ci: add clippy/rustfmt workflow

Adds a "check" workflow to run Clippy and rustfmt, also makes the workflows a little more consistent across files.

Looks good to me, thank you alot!


Linear Regression

Solved issue: https://github.com/nushell/nushell/issues/11392
Added Linear Regression Algorithm that will return the line that goes the best through a set of points in @D.
My method will either return d : y = a * x + b or d : x = a.

Please checkout the README in crates/nu-command/src/math/nushell-liniar-regression/README.md, where I explained my method.

Looks good, please send it to upstream and place a link to it here.

https://github.com/nushell/nushell/pull/11542


Registering a new operation triggers an error when trying to start reporting

Describe the Bug:
Register a new operation, SFO for instance
Head to reporting dashboard and hit 'Start'
An error appears with a wrong URL parameter

Probability:
(How likely the bug is to happen, scored from 1-5. For example, probability of 5 is something like "it happens to all users every time they log in." whereas probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Impact:
(How bad the bug is when it does happen, scored from 1-5. For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected." whereas effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

Step #1
Step #2
Step #3

Screenshots:
Additional information:
OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional Context

@patriciarussellCAS this might also be high priority?

@pbastia - for this week's walkthrough we can show them operations that are already in the system, but good to have in the next sprint backlog. Unless we need this working to set things up for the walk-through? But I don't think so.

@dleard


API to use ink tools

Is there an API to use the ink tools? For example a function that let us draw path or text with specific color, font and style.
I don't see ink functions in api.js and ink.js doesn't look like it is supposed to be used publicly.
https://github.com/mozilla/pdf.js/blob/master/src/display/api.js
https://github.com/mozilla/pdf.js/blob/master/src/display/editor/ink.js

Is there an API to use the ink tools? For example a function that let us draw path or text with specific color, font and style.

Similar to other pre-existing viewer layers, you'd need to initialize it and then set the necessary parameter like the viewer does. (Note though that the FreeText-editor only supports a default font family/style, so there's no choice there.)

I don't see ink functions in api.js and ink.js doesn't look like it is supposed to be used publicly.

Please keep in mind that the editor tools are intended to be used as one more layer in the viewer (similar to the existing textLayer, annotationLayer, and xfaLayer), hence none of this functionality is really expected to show up in the core API (as found in the `src/display/api.js file).
To see how this is being initialized/used in the viewer, please see https://github.com/mozilla/pdf.js/blob/master/web/annotation_editor_layer_builder.js and https://github.com/mozilla/pdf.js/blob/master/web/pdf_viewer.js

Thank you for the links. The editor let you draw and add text to the pdf. When downloading the document the added annotations are included. I'm interested in the functions that add the path and text to the document and not in the pen and text UI widgets. Where can I find the path and text functions?

Please note: What's described below (at a high level) should probably be regarded as mostly internal implementation details, and thus isn't something that you really want to rely too heavily upon since the format may change (if deemed necessary).
All annotations, be it form-data or editor-tools, are stored in the AnnotationStorage, see https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/display/api.js#L722-L727 and https://github.com/mozilla/pdf.js/blob/master/src/display/annotation_storage.js
To save a modified document we invoke https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/display/api.js#L967-L973 which serializes the editor-tools with https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/display/editor/editor.js#L422-L431
On the worker-thread this is handled in https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/core/worker.js#L567-L584 which calls https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/core/document.js#L268-L321 and finally https://github.com/mozilla/pdf.js/blob/ae7c97aef81aa2934fbbbdc4a5511e0b274e086a/src/core/annotation.js#L261-L301

Thank you for the information. I'll try to call the function to add an annotation. It will be useful to have such functions as a public stable api (feature request).

hi @Snuffleupagus. I'm trying to add annotations and save them with a document without using the viewer UI and editors.
The saveDocument handler in the worker converts the annotations to a plain JSON format. Is it possible to add annotations with this format and save them with the document?
https://github.com/mozilla/pdf.js/blob/3d49459d642e8dfbd11f1acab9a55118bee119f9/src/core/worker.js#L567
Annotation as json:
{
    annotationType: 15,
    color: [0, 0, 0],
    opacity: 1,
    pageIndex: 0.
    paths: [{
        bezier: [...],
        points: [...]
    }],
    rect: [...],
    rotation: 0,
    thickness: 1
}```

You might want to try something similar to our reference tests (although there's no guarantees about long-term stability):

https://github.com/mozilla/pdf.js/blob/fa54a587906100eb8198de2e95d6b1e0bfa88846/test/test_manifest.json#L6782-L6817
https://github.com/mozilla/pdf.js/blob/fa54a587906100eb8198de2e95d6b1e0bfa88846/test/driver.js#L673-L677

It's working thanks!
Will you accept a PR to add a function addAnnotation to api.js?

Will you accept a PR to add a function addAnnotation to api.js?

No, as already explained in https://github.com/mozilla/pdf.js/issues/15712#issuecomment-1321079511 this functionality doesn't belong in that file and adding official support for this somewhat special use-case doesn't seem great from an overall maintainability/support perspective.

hi @benbro , could you post the full working code demonstrating how to programmatically add an annotation (which is then visible on the pdf?)

Hi @Snuffleupagus , I have tried the above solution but it seems like this not working as expected for me. Please find the code here.
// atob() is used to convert base64 encoded PDF to binary-like data.
// (See also https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/
// Base64_encoding_and_decoding.)
var pdfData = atob(
  'JVBERi0xLjcKCjEgMCBvYmogICUgZW50cnkgcG9pbnQKPDwKICAvVHlwZSAvQ2F0YWxvZwog' +
  'IC9QYWdlcyAyIDAgUgo+PgplbmRvYmoKCjIgMCBvYmoKPDwKICAvVHlwZSAvUGFnZXMKICAv' +
  'TWVkaWFCb3ggWyAwIDAgMjAwIDIwMCBdCiAgL0NvdW50IDEKICAvS2lkcyBbIDMgMCBSIF0K' +
  'Pj4KZW5kb2JqCgozIDAgb2JqCjw8CiAgL1R5cGUgL1BhZ2UKICAvUGFyZW50IDIgMCBSCiAg' +
  'L1Jlc291cmNlcyA8PAogICAgL0ZvbnQgPDwKICAgICAgL0YxIDQgMCBSIAogICAgPj4KICA+' +
  'PgogIC9Db250ZW50cyA1IDAgUgo+PgplbmRvYmoKCjQgMCBvYmoKPDwKICAvVHlwZSAvRm9u' +
  'dAogIC9TdWJ0eXBlIC9UeXBlMQogIC9CYXNlRm9udCAvVGltZXMtUm9tYW4KPj4KZW5kb2Jq' +
  'Cgo1IDAgb2JqICAlIHBhZ2UgY29udGVudAo8PAogIC9MZW5ndGggNDQKPj4Kc3RyZWFtCkJU' +
  'CjcwIDUwIFRECi9GMSAxMiBUZgooSGVsbG8sIHdvcmxkISkgVGoKRVQKZW5kc3RyZWFtCmVu' +
  'ZG9iagoKeHJlZgowIDYKMDAwMDAwMDAwMCA2NTUzNSBmIAowMDAwMDAwMDEwIDAwMDAwIG4g' +
  'CjAwMDAwMDAwNzkgMDAwMDAgbiAKMDAwMDAwMDE3MyAwMDAwMCBuIAowMDAwMDAwMzAxIDAw' +
  'MDAwIG4gCjAwMDAwMDAzODAgMDAwMDAgbiAKdHJhaWxlcgo8PAogIC9TaXplIDYKICAvUm9v' +
  'dCAxIDAgUgo+PgpzdGFydHhyZWYKNDkyCiUlRU9G');

// Loaded via <script> tag, create shortcut to access PDF.js exports.
var pdfjsLib = window['pdfjs-dist/build/pdf'];

// The workerSrc property shall be specified.
pdfjsLib.GlobalWorkerOptions.workerSrc = '//mozilla.github.io/pdf.js/build/pdf.worker.js';

// Using DocumentInitParameters object to load binary data.
var loadingTask = pdfjsLib.getDocument({data: pdfData});
loadingTask.promise.then(function(pdf) {
  console.log('PDF loaded', pdf);
    pdf.annotationStorage.setValue("edit1",  {
     "annotationType": 3,
     "color": [0, 0, 0],
     "fontSize": 10,
     "value": "Hello World",
     "pageIndex": 0,
     "rect": [67.5, 543, 119, 55.5],
     "rotation": 0
   })
		pdf.saveDocument();

  // Fetch the first page
  var pageNumber = 1;
  pdf.getPage(pageNumber).then(function(page) {
    console.log('Page loaded', page);

    var scale = 1.5;
    var viewport = page.getViewport({scale: scale});

    // Prepare canvas using PDF page dimensions
    var canvas = document.getElementById('the-canvas');
    var context = canvas.getContext('2d');
    canvas.height = viewport.height;
    canvas.width = viewport.width;

    // Render PDF page into canvas context
    var renderContext = {
      canvasContext: context,
      viewport: viewport,
			annotationMode: 3,
    };
    var renderTask = page.render(renderContext);
    renderTask.promise.then(function () {
      console.log('Page rendered');
    });
  });
}, function (reason) {
  // PDF loading error
  console.error(reason);
});

@VigneshSonaiya @ghepardo82
If you guys are still seeking a solution to programmatically add annotations to PDFs and use the PDF.js viewer for rendering, I highly recommend checking out this repository: pdfAnnotate.
I experienced the same pain when needed to add annotations programmatically on the server side and display them on the client side, and this incredible work saved me.
For me, using the "AnnotationStorage" feature from PDF.js proved to be complex and nearly impossible to achieve. However, after discovering this repository, I found that it provided a straightforward solution. Its integration with PDF.js is seamless, making it incredibly easy to work with. Additionally, it offers a variety of annotation types and is extensively documented, making the entire process smooth and efficient.

Hi @sinatayebati , I've seen you mentionned this library several times, but reading it I have a few questions if you could answer it:

how easy do you think it is to navigate between the annotations ? I have a right pannel with the list of the annotations like in Adobe Reader, I managed to bind the annotations from pdfjs to this panel and make them scroll if I click on the binded annotation or the navigation div, but I fear to do it again if I switch to pdfAnnotate
the reason I want to switch is to be able to filter the annotations: it seems easier with PDFJS to make the annotations invisible and unprintable
isn't it a problem that the last commit is from 2 years ago ? is it compatible with the last version of pdfjs ?
is it suited for rectangle annotations filled with a low opacity ? I've not seen it in the options
Thanks a lot !

@QuentinAndre11
Hi there. I just put together a demo in this repo and tried to document integration of pdfAnnotate and PDFjs; I think you will find it helpful for your questions, so please take a look.
Following your questions, I couldn't quite understand your first question/concern, but bellow are my answers to the rest:

with pdfAnnotate I was able to programmatically add highlight annotation with "hidden" flag.
I don't think the last commit is a problem, the package worked perfectly for me and I even tested it in production with dedicated backend. But in case you want to open an issue, you won't probably get an answer from the developer.
Yes, I have tried various annotation including rectangle with different colors and opacities.


Align look & feel of terms of deposit w/ design doc

Why was this change made?
Fixes #38
Also includes:

Rename modal component to better describe its function

This will reduce friction when creating future modal components.

How was this change tested?
CI and local browser.
Which documentation and/or configurations were updated?
None

@astridu How does the screencap above look? Close enough for me? Or are there changes you'd recommend making? Thanks!

@mjgiarlo Looks good! Could we make it just an inch wider? Thank you!

@jcoyne @astridu I've widened the ToD modal. See the updated .gif above. Take another look?

@mjgiarlo Perfect. Thank you!


ODH 2.22.0 Tracker

Links to tracker issues for components planning updates in this.  Please update you manifests before Dec 6th
Release Date: Dec 9th
Comment Template for automation
#Release#
- component_name|release-branch/release-tag|release-notes

List of component_name:

[ ] modelregistry
[ ] notebook-controller
[ ] notebooks
[ ] codeflare
[ ] ray
[ ] kueue
[ ] trainingoperator
[ ] trustyai
[ ] odh-dashboard
[ ] data-science-pipelines-operator
[ ] model-mesh
[ ] kserve
[ ] model-mesh-serving
[ ] odh-model-controller

#Release#
notebooks| https://github.com/opendatahub-io/notebooks/tree/v1.27.0 | https://github.com/opendatahub-io/notebooks/releases/tag/v1.27.0
notebook-controller| https://github.com/opendatahub-io/kubeflow/tree/v1.9.0-5 | https://github.com/opendatahub-io/kubeflow/releases/tag/v1.9.0-5

#Release#
odh-dashboard | https://github.com/opendatahub-io/odh-dashboard/tree/v2.29.2-odh-release | https://github.com/opendatahub-io/odh-dashboard/releases/tag/v2.29.2-odh

#Release#

odh-model-controller|https://github.com/opendatahub-io/odh-model-controller/tree/odh-v2.22|https://github.com/opendatahub-io/odh-model-controller/releases/tag/odh-v2.22

model-mesh-serving|https://github.com/opendatahub-io/modelmesh-serving/tree/odh-v2.22|https://github.com/opendatahub-io/modelmesh-serving/releases/tag/odh-v2.22

model-mesh|https://github.com/opendatahub-io/modelmesh-serving/tree/odh-v2.22|https://github.com/opendatahub-io/modelmesh-serving/releases/tag/odh-v2.22

kserve|https://github.com/opendatahub-io/kserve/tree/odh-v2.22|https://github.com/opendatahub-io/kserve/releases/tag/odh-v2.22

#Release#
modelregistry | https://github.com/opendatahub-io/model-registry-operator/tree/release/v0.2.11 | https://github.com/opendatahub-io/model-registry-operator/releases/tag/v0.2.11

#Release#

trustyai| https://github.com/trustyai-explainability/trustyai-service-operator/tree/release/1.30.0 | https://github.com/trustyai-explainability/trustyai-service-operator/releases/tag/v1.30.0

#Release#
data-science-pipelines-operator|https://github.com/opendatahub-io/data-science-pipelines-operator/tree/v2.8.0 | https://github.com/opendatahub-io/data-science-pipelines-operator/releases/tag/v2.8.0


[DOC]: Morpheus Examples link to symlinks

How would you describe the priority of this documentation request
Medium
Please provide a link or source to the relevant docs
https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/examples.md
Describe the problems in the documentation
Possible side effect of #536, the links within the Morpheus Examples document link to respective symlinks located at docs/source/examples.
However, the symlinks link to respective docs within the examples folder. This approach makes the documentation a bit difficult to read as github doesn't render symlinks, and feels a bit redundant, therefore I would like to report it as a bug.
(Optional) Propose a correction
Update links in this file from ./examples/__example_model__/README.md to ../../../../examples/__example_model__/README.md
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open documentation issues and have found no duplicates for this bug report

Hi @pranavm7!
Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

It is a pretty simple fix! I would like to create a PR with the same  :)


[FEATURE REQUEST] CI pipelines: scaling up and down k8s worker nodes

Is your feature request related to a problem? Please describe.
Original task is #1051. We don't test scaling up/down components in our pipelines.
Scalability status is described in documentation.
Describe the solution you'd like
Create new pipelines with scaling up/down Epiphany components in Azure.

A pipeline was created to test the scalability of the main components.
https://dev.azure.com/abb-epiphany/epiphany/_release?_a=releases&view=mine&definitionId=215


Use HTTPS to fetch Bartender

The sparkle feed for Bartender is now served over HTTPS, and plain requests receive HTTP 302. AutoPkg doesn't deal with this gracefully so instead the recipe fails. A tiny change to SPARKLE_FEED_URL should sort that out!

Thanks!


doc: Fix unaligned number in the charts

Previously I exported these SVG graph from Safari, which incorrectly added spaces for formatting purpose that causes the numbers to be not aligned. I reexported these SVG graph from Chrome / Edge and now they look good.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.285%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1572

Relevant Lines:
1801

💛  - Coveralls

How about

I'm not sure, but for me after moving these badges, they seems to be distractive, i.e. I'm harder to notice the real important links above these notable badges (Docs, Getting Started, ...).

@andylokandy @sticnarf What do you think?

I further reduced the badge size, hope they are less attractive.

The new svg looks great on my Firefox too.
A bit off-topic, anyone else thinks the padding here is too large?

The new svg looks great on my Firefox too.
A bit off-topic, anyone else thinks the padding here is too large?

Good catch. I introduced some more spacing lines after the initial links:

This makes these links more highlighted!

Prefer badges to be as close to the title as possible.
Would like to hear your reasons for laying out the badges this way.

The new svg looks great on my Firefox too.
A bit off-topic, anyone else thinks the padding here is too large?

Good catch. I introduced some more spacing lines after the initial links:

This makes these links more highlighted!

I was hoping to reduce the padding a bit... This looks tooooo spacious to me...
If you mean to highlight the links, is it a good idea to make them bold?

Prefer badges to be as close to the title as possible.
Would like to hear your reasons for laying out the badges this way.

The current arrangement is to make sure that initial links (Docs | Getting Started | Examples | FAQ) are notable enough, because in the rest of the README readers are hard to discover these information any more. See  https://github.com/tikv/minitrace-rust/pull/105#issuecomment-1058892229 for a bad example that the badges are more attractive and easily gain users focus. What do you think about the philosophy?

Another choice is like https://github.com/d3/d3, use a separate list for the resource links:

A bit off-topic, anyone else thinks the padding here is too large?

Maybe the beget can be put between the padding?


Security problem with plain saved passwords

When I want to use Coder as autostart on my server, It needs to be password saved plain (systemd unit, et cetera). But this way is not very secure.
What about option of encryption of passwords?

The next version will have a configuration file you can put the password in, then you can restrict access to the configuration file.

Going to always hash the password.

So unfortunately we can't do this right now because we randomly generate the password by default and we need users to be able to see it so they can login and we don't want to print it into the logs.

The config file should help with this as @code-asher mentioned as you can restrict access to it.


 on placeholder or vowel or both?

@danbalogh —
At the transition between these two lines we expect po. The e-marker was probably engraved at the end of the first line, but is very unclear. Logically, the reading o on the next line is hence also unclear. Where to apply the <unclear> tags?

bhandāra yām̃ <unclear>⌈</unclear><lb n="B9" break="no"/>po ku śrīśānabhadreśvara
bhandāra yām̃ <unclear>⌈</unclear><lb n="B9" break="no"/>p<unclear>o</unclear> ku śrīśānabhadreśvara
bhandāra yām̃ ⌈<lb n="B9" break="no"/>p<unclear>o</unclear> ku śrīśānabhadreśvara

It's number 1.
EGD §4.1.4:
if some of the components involved are unclear,
[...]
separately apply the tag to the placeholder only if the split-off component is itself affected
[...]
for example:
[...]
(ெ)<>கா would be encoded as ⌈<>ko
I agree that the reading of what we transliterate as o is on the whole logically unclear, but when the placeholder ceiling character is present, then the ceiling and the "o" together correspond to that o, with the ceiling standing for the left-hand component and the "o" standing for the right-hand component. If we chose any alternative other than 1, then we'd have no way of representing a case where only the marker after the consonant body was unclear.

Thanks. So it seems you mean alternative number 2 instead of 1. Please confirm.

Hmm, thanks for pointing out my mistake. It seems that the guide is not as unequivocal on this as it should be. Indeed, you should follow your 2 as per the example in the EGD. But that means that my reasoning above is wrong. It was based on my misconstruing of the EGD instruction as "apply the tag to the placeholder only" instead of "apply ... only if the split-off component is itself affected". This means that we do not, actually, have a way of explicitly encoding the fact that the right-hand component of the o is clear, so disregard the explanation above. The underlying rationale for preferring this solution must have been the importance of encoding the transliterated "o" as unclear. We should not change the rule, but I'll rewrite this bit in the guide to make it clearer.

Thanks. Feel free to close this after having made the necessary edits to EGD.


fix: correct the bugs of major version 7 (pre-release)

Description
Corrects all bugs of the pre-release version 7 of the module before roll-out

First test with the Hapag-Lloyd test setup successfully done. Runner and Executors are up and running. Jobs were processed.

Second test with the live environment. Module conversion with script worked out of the box. Runner were up and running. All jobs were processed.
Spot instances, shared cache and fleet support.

Another test with a non-shared cache created by the module: Works

Like before, but the Agent is running on an on-demand instance. Works also fine.

Do not specify the runner_worker block: Works fine. I see default values in the config.toml

Switched from docker+machine to docker. Wow, how easy that is. Everything up and running and all jobs were processed on the Runner.


Fix issue #1405: Update test.rs to see the expected output in the tutorial

Fix issue #1405: Update test.rs to see the expected output when running the command 'cargo test' in this tutorial "https://developers.stellar.org/docs/build/smart-contracts/getting-started/hello-world".
What
Modified Line 9.
Why
Because of this error.

Known limitations
[TODO or N/A]

@yskwmt is this the increment contract from the soroban-examples repo? I think the fix probably needs reopening there.
I'll close the PR so you can reopen it. If I was mistaken please feel free to reopen this PR.


mwc-slider does not snap to values corresponding to the step attribute (& visually represented by the markers attribute) if set to a non-integer

Describe the bug
If a non-integer is set to the step attribute of mwc-slider , the slider does not behavior correctly. When interacted with, mwc-slider instances will skip non-integer values to the next integer.
The UI toggable by marker & pin has no problem respecting such values, making this behavior extremely confusing.
This behavior occurs even when the initial minimum value is a non-integer valid within the min & max of an instance.
This behavior is completely deviant from paper-slider; the Material 1 version of this component.
To Reproduce
Steps to reproduce the behavior:

Instantiate or in mark-up define a mwc-slider
Set the step attribute to a non-integer (i.e. 0.5)
Set the markers attribute ; optionally the pin, min & max attributes to more clearly identify the problem (the latter two should have sensible bounds:

<mwc-slider
    pin
    markers
    min="0"
    max="2"
    value="0.5"
    step="0.5">
</mwc-slider>

Interact with the knob of the slider back-n-forth

Expected behavior
That the component can step to all possible values of the slider based on the step  & max attributes aligning with how the Material 1 version of this component, paper-slider, behaves.
Screenshots
Video demonstration of problem: https://user-images.githubusercontent.com/1223224/105733034-efe1b380-5ee5-11eb-88b1-70745eeac652.mov
Browser Version (please complete the following information):

OS: MacOS Catalina & Big Sur
Browser: Chrome
Version: 87.0.4280.141+

Additional context
Discussed in detail w/ @dfreedm & @e111077

I am working on the M2 implementation of slider right now, and this is fixed there. Keeping open until that is merged

I am working on the M2 implementation of slider right now, and this is fixed there. Keeping open until that is merged

I am working on the M2 implementation of slider right now, and this is fixed there. Keeping open until that is merged

Thanks @e111077, this is good to know. Any tentative ETA ?


Update variable name within Anomaly Detection example

Thank you for submitting a TensorFlow documentation issue. Per our GitHub
policy, we only address code/doc bugs, performance issues, feature requests, and
build/installation issues on GitHub.
The TensorFlow docs are open source! To get involved, read the documentation
contributor guide: https://www.tensorflow.org/community/contribute/docs
URL(s) with the issue:https://www.tensorflow.org/tutorials/generative/autoencoder?hl=en
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/MyMethod
Description of issue (what needs changing):
Within Anomaly Detection section, within Build the Model, some variables names are misleading with regard to data that is handled when using the encoder and decoder after training.
As a matter of fact, data here are ECG time series and no longer images like in previous example with mnist and fashion_mnist
Clear description
encoded_imgs = autoencoder.encoder(normal_test_data).numpy()
decoded_imgs = autoencoder.decoder(encoded_imgs).numpy()
should be replaced by something like:
encoded_data = autoencoder.encoder(normal_test_data).numpy()
decoded_data = autoencoder.decoder(encoded_data).numpy()
Correct links
Is the link to the source code correct?
Parameters defined
Are all parameters defined and formatted correctly?
Returns defined
Are return values defined?
Raises listed and defined
Are the errors defined? For example,
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/feature_column/categorical_column_with_vocabulary_file#raises
Usage example
Is there a usage example?
See the API guide: https://www.tensorflow.org/community/contribute/docs_ref
on how to write testable usage examples.
Request visuals, if applicable
Are there currently visuals? If not, will it clarify the content?
Submit a pull request?
Are you planning to also submit a pull request to fix the issue? See the docs
contributor guide: https://www.tensorflow.org/community/contribute/docs,
docs API guide: https://www.tensorflow.org/community/contribute/docs_ref and the
docs style guide: https://www.tensorflow.org/community/contribute/docs_style

@cl3m3nt
Thank you for your update, we will review the changes and submit a pr accordingly.

@Saduf2019 @cl3m3nt Thank you, will review.

https://github.com/tensorflow/docs/pull/1905 ✅

@8bitmp3
Thank you for the update, shall i move this issue to closed status.


Change null_resource on Terraform scripts for helm_release

Issue

Change null_resource on Terraform scripts used with helm apps, for helm_release

Docs
https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release

The strategy of deploy was switched by helmfile


Improve UseEffect in components

The loading process of the Canvas is at the moment quite fragile due to the need of separability between components to allow continuous calls without refreshing whole component, the useEffects probably could get improved but it require some more dedicated time
https://github.com/inmanta/web-console/pull/5985#discussion_r1804533832

https://github.com/inmanta/web-console/pull/5985#discussion_r1810567826

Check refreshing of the sidebar if that will interrupt the flow, break the composer, if so, either save state of the composer and reset the whole view and apply it once again or don't remove the the objects but clear and append new items


JSXHint doesn't lint errors (config via .jshintrc)

I have installed both SublimeLinter-jsxhint and SublimeLinter-jshint installed in my Sublime 3.
Files with .js extension are linted fine (as it was before) but files with .jsx extension are not linted at all.. I have .jshintrc in the root folder as always. It's content:
{
    "predef": [
        "after",
        "afterEach",
        "angular",
        "before",
        "beforeEach",
        "define",
        "describe",
        "expect",
        "it",
        "xit",
        "xdescribe",
        "should"
    ],

    "asi" : false,
    "bitwise" : true,
    "browser": true,
    "boss" : false,
    "curly" : true,
    "debug": false,
    "devel": false,
    "eqeqeq": true,
    "evil": false,
    "esnext": true,
    "expr": true,
    "forin": false,
    "immed": true,
    "indent": 4,
    "latedef" : false,
    "laxbreak": false,
    "multistr": true,
    "newcap": true,
    "noarg": true,
    "node" : true,
    "noempty": false,
    "nonew": true,
    "onevar": false,
    "plusplus": false,
    "quotmark": "single",
    "regexp": false,
    "strict": true,
    "sub": false,
    "trailing" : true,
    "undef": true,
    "unused": "vars"
}

Do I need to add some additional configuration for .jsx files?

Are you sure you are using the JavaScript (JSX) syntax pack for JSX
files? It is required for sublimelinter-jsxhint to detect that it should
lint a file.
On 1/11/15 5:58 PM, Dmitri Voronianski wrote:

I have installed both |SublimeLinter-jsxhint| and
|SublimeLinter-jshint| installed in my Sublime Text 3.
Files with |.js| extension are linted fine (as it was before) but
files with |.jsx| extension are not linted at all.. I have |.jshintrc|
in the root folder as always. It's content:
{
"predef": [
"after",
"afterEach",
"angular",
"before",
"beforeEach",
"define",
"describe",
"expect",
"it",
"xit",
"xdescribe",
"should"
],
"asi" : false,
"bitwise" : true,
"browser": true,
"boss" : false,
"curly" : true,
"debug": false,
"devel": false,
"eqeqeq": true,
"evil": false,
"esnext": true,
"expr": true,
"forin": false,
"immed": true,
"indent": 4,
"latedef" : false,
"laxbreak": false,
"multistr": true,
"newcap": true,
"noarg": true,
"node" : true,
"noempty": false,
"nonew": true,
"onevar": false,
"plusplus": false,
"quotmark": "single",
"regexp": false,
"strict": true,
"sub": false,
"trailing" : true,
"undef": true,
"unused": "vars"

}
Do I need to add some additional configuration for |.jsx| files?
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/16.

@STRML I have such packages https://github.com/allanhortle/JSX and https://github.com/reactjs/sublime-react

Okay. Sometimes we've seen conflicts between them. TBH, I should remove
the JSX syntax type from this package as most people have already
installed one, and I am not interested in maintaining a syntax package
as well as a linting package.
Could you iterate through your syntax types and see if that gets it to
start linting? If not, please check your console (ctrl-tilde) and see if
you have any messages there.
On 1/11/15 6:09 PM, Dmitri Voronianski wrote:

@STRML https://github.com/STRML I have such packages
https://github.com/allanhortle/JSX and
https://github.com/reactjs/sublime-react
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/16#issuecomment-69501746.

@STRML yeah, I've found another JavaScript (JSX) in the list of extensions and linting began to work.

Cool. It might have something to do with the name of the syntax
definition. If you can trace it down let me know and I'll work on a patch.
On 1/11/15 6:16 PM, Dmitri Voronianski wrote:

@STRML https://github.com/STRML yeah, I've found another |JavaScript
(JSX)| in the list of extensions and linting began to work.
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/16#issuecomment-69502043.

@STRML also I'm experiencing a lot of linting warnings 'String must use singlequote' because I prefer to have explicit rule  "quotmark": "single" in .jshintrc.
Maybe you know some solution to have this rule but to not lint markup part of jsx?

Unfortunately at this time there is no explicit solution for that. You
generally just need to place a conforming jshintrc in the folder to
squelch this.
There are a few open issues claiming the same thing, as well as some
issues on react-tools itself. I don't have any way to transform output
created by react-tools.
In the hopefully near future ESLint will do a more thorough job of
linting the actual pre-transformation content and we can deprecate this
project.
On 1/11/15 6:21 PM, Dmitri Voronianski wrote:

@STRML https://github.com/STRML also I'm experiencing a lot of
linting warnings |'String must use singlequote'| because I prefer to
have explicit rule |"quotmark": "single"| in |.jshintrc|.
Maybe you know some solution to have this rule but to not lint markup
part of jsx?
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/16#issuecomment-69502226.

@STRML thanks for a quick answer

It might have something to do with the name of the syntax
definition. If you can trace it down let me know and I'll work on a patch.

Is there a way to get that name?

Yeah, see
https://github.com/SublimeLinter/SublimeLinter-jsxhint/blob/master/linter.py#L23
On 1/11/15 6:36 PM, Dmitri Voronianski wrote:

It might have something to do with the name of the syntax
definition. If you can trace it down let me know and I'll work on
a patch.

Is there a way to get that name?
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/16#issuecomment-69502864.

@STRML They are both JavaScript (JSX), see screenshot:

The selected one is that works fine with linter.

@voronianski As of 1.1.0 the bundled JSX syntax has been removed. Please let me know if you still have this problem. Try 6to5-sublime.

Please reopen if you still have an issue.


provision/libvirt: debug messages need string

Otherwise this would blow up in an exception on <F29.
Signed-off-by: Miroslav Vadkerti<EMAIL_ADDRESS>

Thanks!


Add method to convert DialogFlow fulfillment requests to DetectIntentResponse objects

I use DialogFlow for Actions on Google, Facebook Messenger, and for bots on websites.
I use this SDK for Facebook, rather than DialogFlow's own integration method, because DialogFlow's automatic Facebook integration does not support deep links.
I'd like to convert the JSON payload sent from DialogFlow to my webhook from JSON into a DetectIntentResponse object, so that I can use the same fulfillment logic for all platforms.
Could you please add and document a method for this? I'm trying to write my own, but I'm having difficulty understanding the best way to instantiate an instance of the DetectIntentResponse object.

I don't need this.


Create skeleton activitys for all umade activitys

Goal is to have at least some screen for every activity in our storyboard for basic navigation. Even if its just a single button leading to the next activity that's fine, we just want to have something.

Activity's created and look great


[google_maps_flutter] [Request] Add support for drag/pan gesture

Already tried with
gestureRecognizers: <Factory<OneSequenceGestureRecognizer>>[           Factory<OneSequenceGestureRecognizer>(             () => PanGestureRecognizer()               ..onUpdate = (data) {                 print(data.localPosition);               },           ),         ].toSet(),
but without succes.

Hi does this solution allow you to achieve the feature you are requesting?
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

No, solution given in stackoverflow link is not working. I was requesting a pan gesture that return the pressed location on map. It's not available and cannot be done with any workarouds at the moment.
I've also asked for it on stackoverflow but without answers