Fire forget  publishing of observations

Publishing of observations was essentially synchronous (as it was the last await before returning from an experiment).
I have refactored the  Scientist.PublishObservation()  to use a, thread safe, BlockingCollection which is not async (not that it matters in this case). Blocking collections allow fast, thread safe, adds; which a consumer then blocks reading from until there is an item to process at the other end.
This did mean that using the Scientist.ObservationPublisher property stopped work properly. (but Ihave it working now) As the Experiment may have ended before the Observation had been published (which messed up a bunch of unit tests). This lead to race conditions where one unit test would be Asserting against another tests Observations.
I then implemented an IQbservable<Observation> property Observations this allows us to have multiple Observation subscribers with filtering! Snazzy Which then pipes back intoScientist.ObservationPublisher
Finally to allow unit-tests to find their own observations, I added a CallingMethodName property to the Observation Class  and infrastructure to automatically populate the method name of where an experiment was run from. That with the TestHelper.ObservationsGeneratedInThisMethod() a unit test's correct observations can be found.
Example:

        [Fact]
        public async Task AllowsReturningNullFromControlOrTest()
        {
            var result = Scientist.Science<object>("failure", experiment =>
                {
                    experiment.Use(() => null);
                    experiment.Try(() => null);
                });

            Assert.Null(result);

            var observation = await TestHelper.ObservationsGeneratedInThisMethod().FirstAsync();

            Assert.True(observation.Success);
        }

I was hoping to start with a simpler solution that doesn't add a lot of dependencies to the library. For example, the Ruby library simply defers the responsibility to the publisher implementation. That might be a fair approach.

I was hopeing sor a simpler solution too!
The downside to offloading that to the publisher, is that an experiment will block until the publisher has completed. So a slow publisher reduces the performance of a system, with otherwise fast experiments.
That being said I could remove the RX stuff; leaving just the concurrent collections dependency. However the down side is we would need to put in a bunch of Thread.Sleep(1)  in all if the unit tests (looking at published results) to wait for the blocking collection consumer to pass on the result to the publisher instance. That and make sure one test doesn't steal another's published result. (I was having lots of issues with that while working thus all out)
Using the Rx IQbservable seemed a really good use case for this kind of data flow, and a superb way of sorting out the publishing race conditions.

Instead of using Thread.Sleep(1), could you expose some kind of member on Scientist, or even InMemoryResultPublisher that exposes a Task which can be awaited while all observations are being published?

@joncloud I like that idea. Expose it on InMemoryResultPublisher.

You still have a race condition problem. (The unit tests are run in parallel) .
You would need to replace the ViewBag with a List which each test could query until their result came through.
It all seems a bit hacky / potentially memory leak / poor man IQbervable.
However I am just looking at the code on github (not in VS) and my have got myself into a mental rut.
I will have a look a bit deeper this weekend.

I think unit tests may run in [parallel][].  Definitely an important piece to keep in mind though.
[parallel]: https://xunit.github.io/docs/running-tests-in-parallel.html
By default, each test class is a unique test collection. Tests within the same test class will not run in parallel against each other.

Could the entire tracking be handled within the InMemoryResultPublisher class?  For example it handles batching of results, and then starts a new Task for submitting each of the results?

My bad; the tests are not running in parallel, but since the Experiment exits before the BlockingCollection consumer publishes, you still can get race conditions. (Well I was at least)

Thanks for your contribution! We ended up going with a different approach in #83. Even so, that approach builds on ideas and work done in other PRs like this one which is much appreciated.


snapshot_download edge case exception

Describe the bug
In some cases (I haven't fully debugged yet, but I have a repro), a repo with subdirectories being downloaded to a "local directory" raises an exception when downloading to a partially complete local snapshot, because parent subdirectories don't exist. This only seems to happen on subsequent downloads in the same process. I think the repro will be clearer, please consider the file structure in this repo being downloaded:
from huggingface_hub import HfApi
import shutil

api = HfApi()
model_id = "pcuenq/t"
local_dir = "t"

def download():
    try:
        api.snapshot_download(repo_id=model_id, local_dir=local_dir)
    except Exception as e:
        print(e)

download()
shutil.rmtree("t/b")
download()

The first download succeeds, but the second one fails (the exception is raised) when attempting to move this file to the b directory.
I have verified that creating the directory before this line "fixes" the problem, but there's surely a better way to deal with this, since the first time the subdirectory is created while the second one it's not.
    dst.parent.mkdir(parents=True, exist_ok=True)
    shutil.move(str(src), str(dst), copy_function=_copy_no_matter_what)

This is occasionally breaking gguf-my-repo (cc @Vaibhavs10) when quantizing models that contain subfolders (there's another bug there where the download patterns are not correctly defined, but I found this issue while debugging it).
Reproduction
As explained above.
Logs
No response
System info
hf_transfer enabled

- huggingface_hub version: 0.25.2
- Platform: Linux-6.8.0-45-generic-x86_64-with-glibc2.35
- Python version: 3.10.12
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Running in Google Colab Enterprise ?: No
- Token path ?: /home/pedro/.cache/huggingface/token
- Has saved token ?: True
- Who am I ?: pcuenq
- Configured git credential helpers: store
- FastAI: N/A
- Tensorflow: N/A
- Torch: 2.4.0
- Jinja2: 3.1.2
- Graphviz: N/A
- keras: N/A
- Pydot: N/A
- Pillow: 10.2.0
- hf_transfer: 0.1.5
- gradio: 4.44.1
- tensorboard: <IP_ADDRESS>
- numpy: 1.26.4
- pydantic: 2.0.3
- aiohttp: 3.8.4
- ENDPOINT: https://huggingface.co
- HF_HUB_CACHE: /home/pedro/.cache/huggingface/hub
- HF_ASSETS_CACHE: /home/pedro/.cache/huggingface/assets
- HF_TOKEN_PATH: /home/pedro/.cache/huggingface/token
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: True
- HF_HUB_ETAG_TIMEOUT: 10
- HF_HUB_DOWNLOAD_TIMEOUT: 10

Happy to submit the PR with the workaround above or dig deeper.

Wow, thanks @pcuenca for providing such a reproducible example (would have taken a lot of time to reproduce^^).
Looks like the error is happening because when getting the local file paths (both metadata and destination), we create the directories here:
https://github.com/huggingface/huggingface_hub/blob/9bb6bd680d507223fef6e40c99ef087086194b58/src/huggingface_hub/_local_folder.py#L218
But as an optimization to avoid reading the disk multiple times when downloading a file, I used a lru_cache here. Therefore if a same script is downloading twice the same repo AND the subfolder has been deleted in between, then the mkdir call is made only once which leads to the error.
This is a corner case to fix but let's fix it right:

either we say that get_local_download_paths shouldn't ensure the paths exist => the rest of the code would have to deals with it (such as the suggested solution with the dst.parent.mkdir call)
either we don't add the lru_cache => more filesystem calls but is it so problematic?
either we add the dst.parent.mkdir call in all cases to ensure double-check => feels clunky

cc @hanouticelina if you see another option

thanks a lot @pcuenca for reporting this with a repro!
@Wauplin in my opinion, the first option is the best, i.e. get_local_download_paths should not create directories or modify the filesystem, as it might lead to caching side effects like this one. as you said, we can keep the @lru_cache but making get_local_download_paths code as "pure" as possible.

My instinct would be to remove the lru cache, as it reduces complexity overall.
For additional context, I'm still not sure why this problem is affecting the gguf-my-repo. I think it's because the Space is a long-lived process that downloads and converts models non-stop, and downloaded snapshots are removed upon completion. It could be the case that one person converts a model, then later another person tries to convert the same and we hit this issue, but I haven't been able to verify if that's the case. So the TL;DR: is: caching interacts with long processes.
A completely different solution would be to provide a context manager that downloads a repo to a random temporary location, people do whatever they need to do and then the context manager removes the downloaded snapshot. This would address this use case, but I feel it's out of scope of what huggingface_hub should do.


feat: add x-real-ip and x-real-port to metadata

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

默认把 x-real-ip 和 x-real-port 加入到 metadata 中

还是在内网做好了


C# Test Tracking Issue

Track issues found during testing for C# notebooks.

Documentation

[ ] Update README to reflect .NET versions

Notebook: Embedding_Wikipedia_articles_for_search.ipynb
The client should be wikiClient?

First pass on finding in this pr https://github.com/Azure-Samples/openai/pull/60


remove debug noise

Codecov Report

Merging #553 into master will decrease coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   43.99%   42.15%   -1.85%
==========================================
  Files         179      182       +3
  Lines       16016    15961      -55
==========================================
- Hits         7046     6728     -318
- Misses       8970     9233     +263

Impacted Files
Coverage Δ

chain-impl-mockchain/src/block/mod.rs
46.55% <ø> (-0.91%)
:arrow_down:

imhamt/src/hash.rs
0% <0%> (-88.89%)
:arrow_down:

imhamt/src/bitmap.rs
0% <0%> (-78.95%)
:arrow_down:

chain-impl-mockchain/src/legacy.rs
0% <0%> (-75%)
:arrow_down:

chain-impl-mockchain/src/transaction/utxo.rs
0% <0%> (-60%)
:arrow_down:

chain-impl-mockchain/src/ledger.rs
0% <0%> (-55.29%)
:arrow_down:

chain-impl-mockchain/src/utxo.rs
0% <0%> (-45.46%)
:arrow_down:

...hain-impl-mockchain/src/transaction/transaction.rs
59.25% <0%> (-37.04%)
:arrow_down:

chain-impl-mockchain/src/value.rs
30% <0%> (-36.67%)
:arrow_down:

chain-impl-mockchain/src/fee.rs
0% <0%> (-28.58%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802f4a6...1740078. Read the comment docs.

already in ledger-unification


protos: Remove squash from api:v2_protos

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message: protos: Remove squash from api:v2_protos
Additional Description:
this is a follow up to #16336 as in a subsequent PR proto_format was trying to remove this
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@htuch i separated this out from #16903 as i wanted to check its safe to do this - that PR was trying to remove this and also the same for other protos that are being removed

...also im concerned that something similar might start happening on other peoples PRs - ie trying to remove this proto

Why wasn't this caught in CI on #16336?

Why wasn't this caught in CI on #16336?

i was rather hoping you would know the answer to that
proto_sync.py etc is a bit of a mystery to me - mostly i have been using trial and error to make it happy as im not entirely clear as to what its doing

@htuch i tried making some arbitrary changes to proto files to see if i could trigger the problem (#16923 ) - it did not
its a mystery to me why removal is being enforced in https://github.com/envoyproxy/envoy/pull/16903
either way - i think we want to do this - no ?

Yep, sure. I think once v2 is gone we get rid of proto_sync.py anyway.


binding names should allow dashes and similar non-word characters

originally filed as https://github.com/engineblock/engineblock/issues/139

This is no longer valid according to current workload template standards.


BEEFY voter bugfixes

BEEFY gadget should always use current validator set.
The gadget/client-voter was using previous' session validator set to sign the 1st block in the new session (to have chained validator set handoffs).
This is not necessary because:

BEEFY piggy-backs on GRANDPA and only works on canonical chain, so it need not concern itself with the validity of the block header (which contains digest with the new session's validator set). It can safely assume header is valid and simply use new validator set.
The BEEFY payload itself already contains a merkle root for the next validator set keys. So at the BEEFY-payload layer we already have a validated/trusted hand-off of authority.

BEEFY gadget should also buffer votes for blocks not yet finalized by GRANDPA.
Fixes https://github.com/paritytech/grandpa-bridge-gadget/issues/414
Fixes https://github.com/paritytech/grandpa-bridge-gadget/issues/415

bot merge


Add loader for deleting source

Description

Adds loader for deleting a source.
Also the source is deleted from the application state, so no more refreshing the whole list.

Before

Success

Error

TODO

[x] remove double errors
[x] refactor the list
[x] Tests

@terezanovotna

I like it!

Codecov Report

Merging #95 into master will increase coverage by 0.47%.
The diff coverage is 59.09%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   66.03%   66.51%   +0.47%
==========================================
  Files          37       37
  Lines         424      433       +9
  Branches       50       54       +4
==========================================
+ Hits          280      288       +8
+ Misses        123      121       -2
- Partials       21       24       +3

Impacted Files
Coverage Δ

src/App.js
0% <ø> (ø)
:arrow_up:

src/api/entities.js
34.69% <0%> (ø)
:arrow_up:

src/components/SourcesSimpleView.js
85.71% <100%> (+1.09%)
:arrow_up:

src/components/SourceRemoveModal.js
95.45% <100%> (+4.97%)
:arrow_up:

src/redux/actions/providers.js
79.31% <50%> (+2.64%)
:arrow_up:

src/redux/reducers/providers.js
67.64% <50%> (-3.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c61de...217ade7. Read the comment docs.

@Hyperkid123


blackeye not working

i downloaded the blackeye phishing tool on your website here but its not loading up the website i'm trying to clone... i kept getting error messages

On Tue, 28 Jun 2022 at 11:24, Himprakash Deka @.***>
wrote:

What error messages?
—
Reply to this email directly, view it on GitHub
https://github.com/HiDe-Techno-Tips/Blackeye-for-Windows/issues/17#issuecomment-1168926345,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZCIEVBENQXICOBNZ64TJGDVRMRLXANCNFSM5VXSHPBA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Couldn’t upload files


ExtEventLoop: EventBase private visibility

I am working on a project that I think could be complementary to your project:
https://github.com/cameronjacobson/Spas
** Look at examples/* files for a quick glimpse into what I'm trying to do.
Not as a component of React, but by using react as an injectable component in my project.  Similar to how "Request" variables are injected into callbacks in Silex.  I would write a ControllerResolver that injected additional components.  The reason I'm writing this note is because my project assumes its own EventBase (using EventHttp) is already instantiated.  And since using React as an injectable component would be optional, it wouldn't necessarily make sense to do all the React initialization up front.  So if a user could inject a React event-loop (using the EventBase already instantiated) the user could use React inside the Silex controller seamlessly.
When reviewing the event-loop project I noted the 'private' visibility for the EventBase.  I understand that my use-case may not be something you have thought of, but I think it's a valid one and I think would be pretty powerful way to utilize React.
I see that another option is for me to just implement the LoopInterface in my own implementation of an EventLoop for your project, and perhaps you feel better going that route, but given the new use case it seems it could open alot of possibilities for your project if either visibility was increased / getters / setters, and / or perhaps EventBase was injectable into the event-loop itself.

I have the same problem - I have a project that uses its own EventBase, without using the react loop. However, one dependency is cboden/ratchet, and that project requires an react event loop.
I'd like to just add the react event loop to my own EventBase, and not create a timer event on my own EventBase, in which the tick()-method of the react loop is called.

Thanks for reporting this! :+1: While I agree that this is certainly not React's main focus, I think it's reasonable to (optionally) inject the EventBase into the ExtEventLoop.
Does anybody feel like creating a PR for this? :+1:

@clue I'm certainly willing to if someone doesn't beat me to it.  I should have time this weekend.  Thanks.

@clue not sure how much time you'd want to spend discussing this, but I at least just wanted to clarify "scope" of what I'm going to do here before I send a pull request.
I can see a "fast path" where we are only concerned with making the change to the ExtEventLoop.  I did this so far locally.  I can also imagine concerns such as wanting to try and keep the interface for the __construct method and/or behaviors / capabilities similar across the different LoopInterface implementations.
Of the 4 LoopInterface implementations, it looks like it's relatively straightforward to add the change to 3 of them (ExtEventLoop, LibEventLoop, and LibEvLoop).  The 4th (StreamSelectLoop) I think would be possible, to optionally "decouple" the stream_select loop from ReactPHP, but I would need to put more thought into it.

Ping @cameronjacobson, what is the status here? I'm unsure where we left off and whether there's still interest in this issue. Also, it's currently a bit unclear how much value this provides and whether it's worth the effort implementing and maintaining this.

@clue I think it could be an extremely powerful capability.  In other words, the design currently assumes ReactPHP will be the "container" for all functionality.  This would allow ReactPHP to behave in a supporting role inside some other application.  My only concern was I wanted to circle back with you to discuss whether it would be a problem that there doesn't appear to be a straightforward way to implement this capability with the StreamSelectLoop.
I do see a potential path forward with StreamSelectLoop but it would require de-coupling that class to where it also had an "EventBase" that would be optionally injected like the other loop classes.
Before I submitted a pull request I wanted to know what you thought about both approaches (ie. ensuring all Loop classes had same semantics, or if it would be better to leave StreamSelectLoop out of the equation).  And I wanted to confirm whether there was any development on the horizon that could interfere with the additional optional argument on the constructor, which would mean that if we proceeded we probably should ensure consistency across all Loop classes.

Sorry, previously submitted this comment using the wrong account :)
@clue I think it could be an extremely powerful capability. In other words, the design currently assumes ReactPHP will be the "container" for all functionality. This would allow ReactPHP to behave in a supporting role inside some other application. My only concern was I wanted to circle back with you to discuss whether it would be a problem that there doesn't appear to be a straightforward way to implement this capability with the StreamSelectLoop.
I do see a potential path forward with StreamSelectLoop but it would require de-coupling that class to where it also had an "EventBase" that would be optionally injected like the other loop classes.
Before I submitted a pull request I wanted to know what you thought about both approaches (ie. ensuring all Loop classes had same semantics, or if it would be better to leave StreamSelectLoop out of the equation). And I wanted to confirm whether there was any development on the horizon that could interfere with the additional optional argument on the constructor, which would mean that if we proceeded we probably should ensure consistency across all Loop classes.

@cameronjacobson I think a better way would be to add an additional method (a setter, plus maybe a getter), to set the EventBase (or equivalent) for those loop implementations, which have it (e.g. no select() system call implementation). This way, you would not interfere with the constructor definition, plus only those which support some sort of base, have it. The only downside of this would be, that the constructor will create one anyway, even if it's not needed, but I think that's a compromise.

@cameronjacobson I think a better way would be to add an additional method (a setter, plus maybe a getter), to set the EventBase (or equivalent) for those loop implementations, which have it (e.g. no select() system call implementation). This way, you would not interfere with the constructor definition, plus only those which support some sort of base, have it. The only downside of this would be, that the constructor will create one anyway, even if it's not needed, but I think that's a compromise.

This is not better, it's way worse:

It violates encapsulation
It messes with the internal state of the loop instance (i.e. registered listeners)

Constructor injection is the only acceptable solution here. This could be done BC compatible as optional Constructor parameter.

@clue I think it could be an extremely powerful capability. In other words, the design currently assumes ReactPHP will be the "container" for all functionality. This would allow ReactPHP to behave in a supporting role inside some other application. My only concern was I wanted to circle back with you to discuss whether it would be a problem that there doesn't appear to be a straightforward way to implement this capability with the StreamSelectLoop.

I agree that there is some potential (perhaps hypothetical) advantage in said applications. From real world experience in production applications I would highly recommend against trying to use multiple event loops or abstractions thereof in a single application. I would argue that this often leads to more problems down the road, so I would suggest either using a single loop implementation, adapters for specific implementations or breaking up a larger application into smaller parts.

I do see a potential path forward with StreamSelectLoop but it would require de-coupling that class to where it also had an "EventBase" that would be optionally injected like the other loop classes.

This sounds interesting… and hard. See above, I don't currently see any major benefit over the current architecture, but that doesn't mean that there's no value in it. With the current state of this discussion, I'm not sure it's worth the effort, but if you feel like working on this, then I'm happy to take a look at it and help reviewing.
I'm closing this for now as it hasn't received any input in a while and I believe this has been answered. Please report back with more details if this is still an issue for you and we can reopen this :+1:


Kerlink iFemtoCell does not send (or lora-gateway-bridge does not receive) timestamp

Kerlink iFemtoCell with Semtech Packet Forwarder does not send (or lora-gateway-bridge does not receive) timestamp.
Packet from Kerlink iFemtoCell:
{"applicationID":"1","applicationName":"0000000000000077","nodeName":"0018b20000000298","devEUI":"0018b20000000298",
"rxInfo":[{"mac":"7276ff00390301cb","rssi":-48,"loRaSNR":6.5,"name":"Kerlink-Home-2","latitude":55.776826451225254,"longitude":37.730076313018806,"altitude":0}],
"txInfo":{"frequency":868500000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":true,"codeRate":"4/5"},"fCnt":347,"fPort":1,"data":"nx1VRmBgA3Q3kFxbDOA6Bw=="}
Packet from Kerlink LoRa station (Wirnet Station):
{"applicationID":"1","applicationName":"0000000000000077","nodeName":"0018b20000000298","devEUI":"0018b20000000298","rxInfo":[{"mac":"0000024b080e0e0c","time":"2017-06-06T13:45:08.343905Z","rssi":-15,"loRaSNR":9.5,"name":"KERLINK-GTL-EU","latitude":55.77681,"longitude":37.73001,"altitude":89}],"txInfo":{"frequency":868300000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":true,"codeRate":"4/5"},"fCnt":388,"fPort":1,"data":"nh1VRlmQA3Q3kIV9DOA="}

This is UDP dumps from both gateways
KERLINK iFemtoCell
\02|\c2\00rv\ff\009\03\01\cb{"rxpk":[{"tmst":38690196,"chan":6,"rfch":1,"freq":868.300000,"stat":1,"modu":"LORA","datr":"SF12BW125","codr":"4/5","lsnr":9.8,"rssi":-55,"size":27,"data":"gAHe3t6A6QEBreNWenV8IrHbytfFOxNXaZ3R"}]}
\02\9b\b4\00rv\ff\009\03\01\cb{"rxpk":[{"tmst":118689572,"chan":5,"rfch":1,"freq":868.100000,"stat":1,"modu":"LORA","datr":"SF12BW125","codr":"4/5","lsnr":9.8,"rssi":-46,"size":27,"data":"gAHe3t6A6gEBNnjozjVRsC+o0P0TRhO1MnRI"}]}
KERLINK OUTDOOR
\01J\ec\00\00\00\02K\08\0e\0e\0c{"rxpk":[{"tmst":25766268,"chan":1,"rfch":1,"freq":868.300000,"stat":1,"modu":"LORA","datr":"SF12BW125","codr":"4/5","lsnr":9.0,"rssi":-10,"size":27,"data":"gAHe3t6A8QEBo25xEPXG7S7tamAYotw3lDzr"}]}
\013\9f\00\00\00\02K\08\0e\0e\0c{"rxpk":[{"tmst":65765940,"chan":2,"rfch":1,"freq":868.500000,"stat":1,"modu":"LORA","datr":"SF12BW125","codr":"4/5","lsnr":8.2,"rssi":-10,"size":29,"data":"gAHe3t6A8gEB5nzMqpx1cPMIBbhqcYCfL1b5mLo="}]}
\01!=\00\00\00\02K\08\0e\0e\0c{"rxpk":[{"tmst":125765492,"chan":0,"rfch":1,"freq":868.100000,"stat":1,"modu":"LORA","datr":"SF12BW125","codr":"4/5","lsnr":10.0,"rssi":-33,"size":29,"data":"gAHe3t6A8wEBQdNOB6SHrqolgbWfN59j4sfILDc="}]}

Hello,
I just got iFemtoCell to my desk, no doc, no binaries, did you succesfully compilesrc form Github repo?
May be missing time is because fw expect GPS type info?

When the iFemtoCell does not have a GPS, then the above is expected behaviour.

iFemtoCell does not have a GPS at all.
In that case, where do I get the payload timestamp?

You don't get any timestamp in case the gateway does not have a GPS.

but with Loriot Blob GW app time is there. In fact GPS acurate time may be usable for localisation purposes, In other case NTP based time (and iFemtocell does run ntpd) is acurate enough. So may be code for ntp time use is by mistake disabled for iFemtocell. Timestamp is usualy quite usable info (and sensors usualy do not have RTC and does not send time in payload).

Next question. why I receive latitude and longitude?
application/1/node/0018b20000000298/rx
{"applicationID":"1","applicationName":"0000000000000077","nodeName":"0018b20000000298","devEUI":"0018b20000000298","rxInfo":[{"mac":"7276ff00390301cb","rssi":-39,"loRaSNR":7.5,"name":"Kerlink-Home-2","latitude":55.776826451225254,"longitude":37.730076313018806,"altitude":0}],"txInfo":{"frequency":868500000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":true,"codeRate":"4/5"},"fCnt":80,"fPort":1,"data":"jxxRUAzhMAk="}

I guess because you configured the lat / longitude in LoRa App Server :-)


Version 2023.06.00

PR #48 shows nearly all tests are passing with mpirun -np 4. There are a couple failures that still need to be resolved, particularly Cholesky on AMD, but I haven't been able to reproduce it manually. This seems a good cut-off for this release.

CUDA failures are due to module conflict on xsdk.


[Feature Request] Simple container renaming

Any way we could get a button to rename a container without going through the Duplicate/Edit menu? There are times when I'd prefer users not to have a container restart in order to change the name, especially if I don't grant shell access to some of them.
Seems like it would be fairly simple to pipe a text field into the docker rename command.

Closing as there has been no activity.


Flask-Admin and React/React-Router

I have a setup with ReactJS where the routing is handled client sided by React-Router.
Flask-Admin sets up routes prefixed by '/admin'. However, when trying to use these together, the React-Router is clobbering the calls to Flask-Admin.
Is there a way to use Flask-Admin as a REST service and then I could call it from the client to yield the entire template?

Unfortunately no - Flask-Admin is not a REST framework and probably won't work great with single-page apps. Closing this for now.


MTFontManager manager is nil

manager is accessible to external apps, fontManager is inaccessible, the below fixes manager nil issue.

public class MTFontManager {
static public private(set) var manager: MTFontManager = {
    MTFontManager()
}()

let kDefaultFontSize = CGFloat(20)

static var fontManager : MTFontManager {
    return manager
}

Included the above in pull request

Pull merged.


⚠ Bofrost.lu has degraded performance

In 851a657, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1992 ms

Resolved: Bofrost.lu performance has improved in c888293 after 10 minutes.


Build failure in flight_sql.rs

Describe the bug
There is a build failure in flight_sql.rs.  See https://github.com/apache/arrow-ballista/actions/runs/6420012638/job/17431145489
Will provide a PR to fix

Updated to_proto.rs where there were build failures due to deprecations from the use of timestamp_nano() which is now deprecated in chrono crate.


Uncaught (in promise) This extension is not running inside an iframe, desktop, or popup window. Initialization failed.

I have installed tableau desktop (2019.4), tried to add extension and I  have a problem
so i tried to debug, i ran the following command:
"C:\Program Files\Tableau\Tableau 2019.4\bin\tableau.exe" --remote-debugging-port=3000
tried to open this in chromium and got ab error:
(index):1 Uncaught (in promise) This extension is not running inside an iframe, desktop, or popup window. Initialization failed.
Can you help me??
Thank you

Yes, it seems like you might be opening the Extension in the Chromium browser? Instead you should add the Extension to the dashboard and then go to localhost:3000 in Chromium to debug.

Thanks for the response,
I tried now again
first 1 ran the command,
Then I opened the extension and after this open chromium - and got the error - and didnt get the option to debug
Is there anything didn't do right
Thanks

Hi,
Just to be clear...

"C:\Program Files\Tableau\Tableau 2019.4\bin\tableau.exe" --remote-debugging-port=3000
Load your workbook, and go to the dashboard that has your extension
Click Okay  in the "Allow Extension" dialog.
Open chromium on localhost:3000, select your extension from the list (that might be one item long)
You should then be able to debug.
Note that after step 4, do not press F5. That reloads your extension, but it loads it directly in the browser so that you get the initialization failed error.

Hopefully that helps.
John

Hi John,
Thanks for the response...
I did all the steps you said - my problem is when I open the chromium I don't have options to choose anything
what's my wrong?
thank you so much!!

Hmmm... could you share a screen shot? I'd love to see the terminal where you launch tableau with --remote-debugging-port=3000, also Tableau with the extension running, and finally Chromium after loading localhost:3000.
Perhaps together we can spot something that is going wrong. Thanks!
John

Hi John,
I'm facing an issue while downloading a file from Dockerized application to my local system.
Its an extension on Tableau, and I'm expecting while downloading a report from that Tableau extension it should download.
But its giving an error in Console when download for report method initiates:
Uncaught (in promise) This extension is not running inside an iframe, desktop, or popup window. Initialization failed.
It would be great if you could please help me out with that... if you need more details I'll be providing it to you.
Thanks
Utkarsh Sharma

Hi Utkarsh
It sounds like the extension is running outside of Tableau. Did you install the extension by dragging it from the objects panel into your dashboard? Could you share the workbook with us? If your workbook has confidential information, perhaps a test workbook that also duplicates the issue.
Could you also explain your Tableau and docker set up? Are you using Tableau server, or Tableau desktop?
Thanks,
John

Hi John,
Thanks for replying back!
Yes, I installed extension by dragging it from the objects panel into dashboard.
Workbook is in Test environment I'm working on, its owned by our client so not sure if it will be correct to share it on public platform.
We are using Tableau server owned by our client, docker setup is done to fulfil a use case of our client that the users can run the application (which is a Tableau extension) on dockerized platform.
We have created dockerized images of the code and running the code in container, all other things remains the same.
Steps:
Initially will go to Tableau server website and login , select Site, then go to dashboard.

I drag and drop the extension from object panel to Tableau dashboard.
Then, .trex file is selected from my extensions
Configure the extension
It will launch the client application in a separate pop up window
There I downloads a report and it redirects me to the parent window
There a new tab opens where I believe that report(pdf) should be opened, but it opens front page of the application and in devtools window on console tab it gives that error "Uncaught (in promise) This extension is not running inside an iframe, desktop, or popup window. Initialization failed."

We are not facing that issue where we are running the application using springboot in Eclipse, there also reports open from local file system, but may be not sure some issues with docker local setup.
Please let me know if you could help any further.
Thanks
Utkarsh Sharma

I'm going to close out this older issue because there were two different reports mingled together here.
@utkarssh01 and @chavikau, if you are still facing this problem would you please open new issues with current status of what you've tried?


Wrong marker angle

What happened?

lib
pic

svg

ink

resvg

rsvg

What should have happened?
arrow at the top (GTAW bead) should point in a different direction see (chrome, firefox, inkscape, librsvg)
Copyright
source https://commons.wikimedia.org/wiki/File:GTAW_broken.svg
author Duk
license https://creativecommons.org/licenses/by-sa/3.0/deed.de
Version and Operating System:

Inkscape Version: 1.1dev
resvg version: 0.9.0
rsvg Version: 2.40.21
Operating System: Ubuntu 18.04

confirm that the issue is fixed, thanks.


Revert "Adding NPS rating for docs pages"

Reverts mattermost/docs#3469

Reverting due to some sizing and performance changes that need to be made.


serviio: 2.1 -> 2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/serviio/versions.
meta.description for serviio is: "UPnP Media Streaming Server"
meta.homepage for serviio is: "https://serviio.org"
meta.changelog for serviio is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.2 with grep in /nix/store/iijb0ridjhb86301935ija2k7mlbngl2-serviio-2.2

found 2.2 in filename of file in /nix/store/iijb0ridjhb86301935ija2k7mlbngl2-serviio-2.2

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
serviio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/iijb0ridjhb86301935ija2k7mlbngl2-serviio-2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A serviio https://github.com/r-ryantm/nixpkgs/archive/3d41ca07b4ae9098d61d6375fadf8c86f797aad6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/iijb0ridjhb86301935ija2k7mlbngl2-serviio-2.2
ls -la /nix/store/iijb0ridjhb86301935ija2k7mlbngl2-serviio-2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

serviio

Maintainer pings
cc @thpham for testing.

Upstream is ahead already

Upstream is ahead already


Update README.md with local network IP access.

More accurate information from linked source. I've also tested and verified local IP address works on a real device.

When I tried last year it didn't work. But I tested now and you're right. Thanks 👍


Create Dockerfile

Thank you so much! I don't have experience using Docker. Hope you'll maintain it & answer if any issue occur.


Distributed table engine cannot merge distinctly ordered columns

Clickhouse version: 1.1.54231
Steps to reproduce

Set up clickhouse-server on two physical servers.
Create the following table on the first server:

CREATE TABLE foobar (
    EventDate Date,
    EventTime DateTime,
    Payload1 String,
    Payload2 String
) Engine = MergeTree(EventDate, (EventTime), 8192)

Create the following table on the second server. The table contains the same set of columns, but the Payload1 is swapped with the Payload2:

CREATE TABLE foobar (
    EventDate Date,
    EventTime DateTime,
    Payload2 String,
    Payload1 String
) Engine = MergeTree(EventDate, (EventTime), 8192)

Insert sample rows into foobar tables on both servers.

Create Distributed table foobar_all on top of foobar tables from the previous steps.

Issue the following query on the foobar_all table:

SELECT
    Payload1,
    Payload2
FROM foobar_all
WHERE EventTime > now() - 60
ORDER BY EventTime

Expected behavior
The query must succeed, since the query selects identical set of columns from both foobar tables.
Actual behavior
The following error is returned:
Code: 171. DB::Exception: Received from ....:9000, ..... DB::Exception: Merging blocks has different names or types of columns:
EventTime DateTime ColumnVector<UInt32> 1, Payload1 String ColumnString 1, Payload2 String ColumnString 1
and
EventTime DateTime ColumnVector<UInt32> 0, Payload2 String ColumnString 0, Payload1 String ColumnString 0.

Converting both tables to same structure could be possible workaround for this situation.
It is possible to change column order via editing metadata of table by replacing them in the .sql file at /clickhouseWorkDir/metadata/default/foobar.sql. CH-server must be restarted after changes.
@alexey-milovidov can there be some hidden consequences connected with this workaround?

This workaround won't work with Replicated tables.

There is yet another workaround: just wrap the original SELECT query into another SELECT and move ORDER BY into outer select:
SELECT
    Payload1,
    Payload2
FROM (
    SELECT
        Payload1,
        Payload2
    FROM foobar_all
    WHERE EventTime > now() - 60
)
ORDER BY EventTime

Is this issue resolved ?

Resolved.
docker run -d --name some-clickhouse-server-2 --ulimit nofile=262144:262144 -p9001:9000 yandex/clickhouse-server
docker run -d --name some-clickhouse-server-3 --ulimit nofile=262144:262144 -p9002:9000 yandex/clickhouse-server

$ clickhouse-client --port=9001
ClickHouse client version 18.11.0.
Connecting to localhost:9001.
Connected to ClickHouse server version 18.14.9 revision 54409.

177e57b55add :) CREATE TABLE foobar (
:-]     EventDate Date,
:-]     EventTime DateTime,
:-]     Payload1 String,
:-]     Payload2 String
:-] ) Engine = MergeTree(EventDate, (EventTime), 8192)

CREATE TABLE foobar
(
    EventDate Date,
    EventTime DateTime,
    Payload1 String,
    Payload2 String
)
ENGINE = MergeTree(EventDate, EventTime, 8192)

Ok.

$ clickhouse-client --port=9002
ClickHouse client version 18.11.0.
Connecting to localhost:9002.
Connected to ClickHouse server version 18.14.9 revision 54409.

884273d60842 :) CREATE TABLE foobar (
:-]     EventDate Date,
:-]     EventTime DateTime,
:-]     Payload2 String,
:-]     Payload1 String
:-] ) Engine = MergeTree(EventDate, (EventTime), 8192)

CREATE TABLE foobar
(
    EventDate Date,
    EventTime DateTime,
    Payload2 String,
    Payload1 String
)
ENGINE = MergeTree(EventDate, EventTime, 8192)

Ok.

$ clickhouse-client --port=9000

milovidov-Latitude-E7470 :) SELECT     Payload1,     Payload2 FROM remote('localhost:{9001,9002}', default.foobar) WHERE EventTime > now() - 60 ORDER BY EventTime

SELECT
    Payload1,
    Payload2
FROM remote('localhost:{9001,9002}', default.foobar)
WHERE EventTime > (now() - 60)
ORDER BY EventTime ASC

Ok.

Result data structure is converted to the data structure of the Distributed table.


Switchable user defined function highlightitg

Add check for g:cpp_no_function_highlight to enable/disable user
defined function highlighting.

This pull request has typo, so I created a new one.


Overriding the current time tracking does not override the comment

when you start a to track something and then press on an existing time entry (play button), the old time tracking is stored and a copy of the clicked time entry is tracked. But the comment of the old time tracking remains.

fixed @1.4.0


moead algorithm problem evaluation

I am implementing parallel problem evaluation using a queuing system assuming that X is a matrix, each x in X is sent to a queue, with elementwise_evaluation set to False.
However, it seems that when moead algorithm is used, population X is always a vector (1 row matrix) instead of a matrix, which prevents parallel evaluation. I checked the source code a bit, it seems (not tested) to be caused by https://github.com/msu-coinlab/pymoo/blob/6679c9c89648deb468790022dc5d8691fb7bf82b/pymoo/algorithms/moead.py#L91
I am not sure if this is intentional or not, correct me if I am wrong. Thank you.

Yes that is correct. But that is because MOEAD does not evaluate the population as a whole but uses a for loop. This is simply as the algorithm was proposed. Changing that (and I have tried even though it deviates from the paper) also changes the performance of the algorithm. The for loop implementation makes the algorithm being more greedy because during the loop the evaluation of a single individual is already known.

Thanks for your respond, that's very informative. I will try some other algorithms then. moead does give better performance tho, given the same computation resources.


Approval Container Integration with UI

Allow approve workflows with approval step from job details page.

[ ] Job details page should list all pending approvals from all approval steps
[ ] If current user is one of approvers when 'Approve' button should be rendered on step panel

I need to check this as approval is a step just like any other user-defined steps. From the image above, I can see it tries to show a status for the workflow. However, this is not accurate as if there are multiple approval steps in the workflow and they are in parallel steps, how would the UI shows the status correctly...
I was thinking more of a UI status for each individual approval step (showing in the small box), which will require the UI to recognize the approval step. I can provide an api to check whether a workflow_id/step_id is an approval step and the approval details for this step. Is this something we  can start with?

I think that we need details about approval step in exists api. Details I mean: who is assigned to approve and who approved.

Closing v1 issues.


Clean up directory and remove unused files

What does this PR do?
This commits cleans up the repo by removing and reorganizing files
What ticket does this PR close?
Resolves #-
Checklists
Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

@sigalsax looks like the build is broken :)

@sigalsax looks like the build is broken :)

yeah things got undone 🙃


Session Time out after during transcoding

Nower days I receive the following message playing 'direct play'
UnicornTranscoder:Transcoder Failed to start ku3wwpr7k1byydsz08ut9n1n: StatusCodeError: 400 - "{"error":{"code":"SESSION_TIMEOUT","message":"The session wasn't launched in time, request fails"}}" +21s
To start a move in transcoded version never reaches the status of playing (plex keeps buffering)
UnicornTranscoder:Transcoder FFMPEG(stderr): [dash @ 0x2ba3a40] Opening 'http://<IP_ADDRESS>:3000/video/:/transcode/session/w7s5dcrsd8szwaeo744amoqe/f6f60841-b59a-4dcf-9540-f9e29c35747f/manifest?X-Plex-Http-Pipeline=infinite' for writing
UnicornTranscoder:Transcoder  +327ms
UnicornTranscoder:Transcoder FFMPEG(stderr): [dash @ 0x2ba3a40] Opening 'chunk-stream0-00003.m4s.tmp' for writing
UnicornTranscoder:Transcoder  +1ms
UnicornTranscoder:Transcoder FFMPEG(stderr): [dash @ 0x2ba3a40] Opening 'chunk-stream1-00003.m4s.tmp' for writing
UnicornTranscoder:Transcoder  +18ms
UnicornTranscoder:Dash Serving chunk-stream0-00001.m4s for session w7s5dcrsd8szwaeo744amoqe +22s
UnicornTranscoder:Dash Serving chunk-stream1-00001.m4s for session w7s5dcrsd8szwaeo744amoqe +89ms
UnicornTranscoder:Dash Serving init-stream1.m4s for session w7s5dcrsd8szwaeo744amoqe +46ms
UnicornTranscoder:Dash Serving init-stream0.m4s for session w7s5dcrsd8szwaeo744amoqe +34ms
UnicornTranscoder:SessionManager ku3wwpr7k1byydsz08ut9n1n not found, restarting (DASH) +18s
Would you know what is the cause for this behavior?

It's not a direct play issue, you are transcoding the file, can you try:

Check you correctly replaced the Plex Transcoder binary
Check the url of your load balancer url in your transcoder configuration

The Plex transcoder binary has been replaced with the version of 'UnicornFFMPEG'
the URL https://subdomain.mydomain,net point to my Loadbalancer on another server

Can you share the configuration of UnicornFFmpeg and UnicornLoadBlaancer?

Can I PM the config to you? Well I use environment variables ;)

Of course<EMAIL_ADDRESS>

Thanks, on its way

Got it!

Can you publish the result of a https://loadbalancer.com/api/stats ?
Are you sure the transcoder have access to the load balancer on public network?
Are you sure your database path is correct?
Did you blocket the 32400 port ?
Did you removed Plex Relay binary ?

point #1: shows {} only
point #: express:router dispatching GET /api/stats +17s
express:router query  : /api/stats +1ms
express:router expressInit  : /api/stats +0ms
express:router corsMiddleware  : /api/stats +0ms
express:router jsonParser  : /api/stats +0ms
body-parser:json skip empty body +17s
express:router urlencodedParser  : /api/stats +0ms
body-parser:urlencoded skip empty body +1ms
express:router   : /api/stats +1ms
express:router dispatching POST /api/update +54s
express:router query  : /api/update +0ms
express:router expressInit  : /api/update +0ms
express:router corsMiddleware  : /api/update +0ms
express:router jsonParser  : /api/update +0ms
body-parser:json content-type "application/json" +54s
body-parser:json content-encoding "identity" +2ms
body-parser:json read body +0ms
body-parser:json parse body +37ms
body-parser:json parse json +0ms
express:router urlencodedParser  : /api/update +39ms
body-parser:urlencoded body already parsed +0ms
express:router   : /api/update +1ms
point #3: Yes is blocked on Loadbalancer Server
point #4: Yes I did

If /api/stats is empty, your transcoder isn't registered to your loadbalancer, the issue start here, your transcoder can't contact your loadbalancer 🤨

Send you PM

So your api/stats works: the transcoder is registered to the loadbalancer.
Do you always have the issue? Can you reproduce it step by step ?

Normal if I chose 'Direct play' I have no issues, it route the call from LB in Germany to my transcoder in Singapore. But once I start transcoding (iPhone/iPad) it will not start the movie. I Plex it keeps saying "Buffering"

I saw in your configuration CUSTOM_DOWNLOAD_FORWARD=true
Your medias files are mounted on your transcoder serveur ? On the same location than the load balancer ?

Yes they are (GTeamDrive)

I don't know, maybe @drouarb have an idea?

If you have a session timeout, it means that the LoadBalancer didn't recieved Plex Transcoder arguments. This can come:

You didn't replaced Plex Transcoder binary in the plex folder (/usr/lib/plexmediaserver/) with UnicornFFMPEG.
UnicornFFMPEG isn't properly configured to your LoadBalancer. (Remember, you need to rebuild UnicornFFMPEG if you change the configuration)
UnicornTranscoder failed to request Plex to start the session

This error means that you got redirected from the Transcoder but it can't fetch transcoding arguments
With the environement DEBUG=* in UnicornLoadBalancer logs you should first see a request to /api/plex/video/:/transcode/universal/start.mpd
then a requests to /api/ffmpeg/<sessionId>

Hi thanks for the feedback:
Point #1: Plex Transcoder has been changed with UnicornFFMPEG
Point #2: UnicornFFMPEG is on the same Server as the LoadBalancer. Therefore the URL_LB='<IP_ADDRESS>' [Unless this must be the Public IP]
I'd built a TransCoder Server in AMS, with the same configuration. This is working without any problem, Direct Play and Transcoded, too.
Could it have something to du with the higher Latency to SIN (+230ms). I know from my own experience that some apps can't handle high latencies.

There is a timeout of 20 seconds when we try to start a session, maybe it's the issue ?

Well from my testing I can say that it is latency problem. The LB stays in a DC in GER. One Server with TransCoder in the same DC. Result no Problem with Direct Play and transcoded Movies. Other Server with TransCoder in DC AMS, alo no problems. However Serer with TransCoder in SIN, plays sometime Direct Pay but never transcoded Movies

Thanks for your feedback, happy to hear it's not a software issue 👌
Feel free to reopen the issue if needed 😉

Is there a chance to change the timeout time of 20 seconds?

Because it's not recommended for regular users, we don't want to increase the timeout value, I invite you to edit the code here:
https://github.com/UnicornTranscoder/UnicornLoadBalancer/blob/master/src/store/local.js#L32

Great, thank you, I will give you my feedback

Awesome! 👌


fix: Amundsen Gremlin - issue 1946 - TornadoTransport init correction and moved order direction decr to desc

Summary of Changes

Removed useless parameters during TornadoTransport initialization
Moved Order.decr to Order.desc for gremlin queries using the deprecated order direction (the deprecated Order.decr doesn't work with Neptune)

Tests

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

CI fails

Hi @feng-tao, thank you for your reply.
From what I see, the pipeline fails due to flake8 verification on two files that I didn't modify.
python3 -m flake8
./tests/conftest.py:16: [E501] line too long (128 > 120 characters)
./tests/conftest.py:20: [E501] line too long (131 > 120 characters)
Makefile:16: recipe for target 'lint' failed
make: *** [lint] Error 1
Error: Process completed with exit code 2.

(amundsen4_gremlin) [ec2-user@ip-10-30-204-31 metadata]$ sudo systemctl status egdh_metadata_gremlin -l
● egdh_metadata_gremlin.service - EGDH metadata service
Loaded: loaded (/usr/lib/systemd/system/egdh_metadata_gremlin.service; disabled; vendor preset: disabled)
Active: active (running) since Thu 2022-11-17 07:44:51 UTC; 38s ago
Main PID: 19061 (python)
CGroup: /system.slice/egdh_metadata_gremlin.service
└─19061 /home/ec2-user/amundsen4_gremlin/bin/python /home/ec2-user/amundsen-gremlin/metadata/metadata_service/metadata_wsgi.py
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: /home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/marshmallow/schema.py:388: ResourceWarning: unclosed file <_io.FileIO name=35 mode='rb' closefd=True>
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: self.dump_only = set(dump_only) or set(self.opts.dump_only)
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: ResourceWarning: Enable tracemalloc to get the object allocation traceback
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: /home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/marshmallow/schema.py:388: ResourceWarning: unclosed file <_io.FileIO name=36 mode='wb' closefd=True>
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: self.dump_only = set(dump_only) or set(self.opts.dump_only)
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: ResourceWarning: Enable tracemalloc to get the object allocation traceback
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: /home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/marshmallow/schema.py:388: ResourceWarning: unclosed <ssl.SSLSocket fd=37, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('<IP_ADDRESS>', 48784), raddr=('<IP_ADDRESS>', 8182)>
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: self.dump_only = set(dump_only) or set(self.opts.dump_only)
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: ResourceWarning: Enable tracemalloc to get the object allocation traceback
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_metadata4[19061]: 2022-11-17T07:45:22+0000.137 [INFO] _internal._log:225 (19061:Thread-4) - <IP_ADDRESS> - - [17/Nov/2022 07:45:22] "GET /table/glue://na_usa_ecs_na-bi-prod_awsglue.awsglue_database_jbtest/aws_glue_jbtest HTTP/1.1" 200 -
(amundsen4_gremlin) [ec2-user@ip-10-30-204-31 metadata]$ sudo systemctl status egdh_frontend_gremlin -l
● egdh_frontend_gremlin.service - EGDH frontend service
Loaded: loaded (/usr/lib/systemd/system/egdh_frontend_gremlin.service; disabled; vendor preset: disabled)
Active: active (running) since Thu 2022-11-17 07:29:47 UTC; 16min ago
Main PID: 16429 (python)
CGroup: /system.slice/egdh_frontend_gremlin.service
└─16429 /home/ec2-user/amundsen4_gremlin/bin/python /home/ec2-user/amundsen-gremlin/frontend/amundsen_application/wsgi.py
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: File "/home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/marshmallow/schema.py", line 723, in load
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: data, many=many, partial=partial, unknown=unknown, postprocess=True
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: File "/home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/marshmallow/schema.py", line 904, in _do_load
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: raise exc
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: marshmallow.exceptions.ValidationError: {'row_count': ['Unknown field.']}
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.146 [DEBUG] action_log_callback.on_post_execution:70 (16429:Thread-30) - Calling callbacks: [<function logging_action_log at 0x7ff321b9eae0>]
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.146 [DEBUG] action_log_callback.logging_action_log:85 (16429:Thread-30) - logging_action_log: ActionLogParams(command='_get_table_metadata', start_epoch_ms=1668671121941, end_epoch_ms=1668671122146, user='root', host_name='ip-10-30-204-31.ec2.internal', pos_args_json='[]', keyword_args_json='{"table_key": "glue://na_usa_ecs_na-bi-prod_awsglue.awsglue_database_jbtest/aws_glue_jbtest", "index": "0", "source": "inline_search"}', output='{"tableData": {}, "msg": "Encountered exception: {'row_count': ['Unknown field.']}", "status_code": 500}', error=None)
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: /home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/flask/json/init.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: rv = _json.dumps(obj, **kwargs)
Nov 17 07:45:22 ip-10-30-204-31.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.147 [INFO] _internal._log:225 (16429:Thread-30) - <IP_ADDRESS> - - [17/Nov/2022 07:45:22] "GET /api/metadata/v0/table?key=glue%3A%2F%2Fna_usa_ecs_na-bi-prod_awsglue.awsglue_database_jbtest%2Faws_glue_jbtest&index=0&source=inline_search HTTP/1.1" 500 -
(amundsen4_gremlin) [ec2-user@ip-10-30-204-31 metadata]$

@ggirodda any news on this?

Hi @Golodhros and @sangram23 , sorry for the late answer.
The problem is caused by some customization to the table and column structure that I made to the my fork of amundsen. Those modifications are not related to this error. I'll update the pull request with the isolated correction

I created a new Pull Request, because I can't change the source branch of this one. The source branch is not yet the master branch.
Here is the new PR:
https://github.com/amundsen-io/amundsen/pull/2104
I'm closing this one


Update information related to EKS Instance Resource Tags

Summary:
On page and under table: https://ranchermanager.docs.rancher.com/reference-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration#bring-your-own-launch-template
Need to modify below:
Old value:

Instance Resource Tags
Tag each EC2 instance in the node group

New value:

Instance Resource Tags
Tag each EC2 instance and its volumes in the node group

Relates to https://github.com/rancher/eks-operator/issues/205
cc: @richardcase

@cpinjani do changes apply to v2.5?


chore: Fix typos and enforce on CI

Could you also add a pre-commit hook if it exists? Id rather find out locally then on CI

I like it! only a small nitpick - maybe we could move this workflow to lint_pr? I think they have a similar scope so we could keep them together

I moved it to pre-commit and removed the separate GitHub Action workflow.
Thanks for the input!


Fit genetic

Adding a genetic algorithm to modnet.
I added parralelization to it.

Ready to be merged.


fix(nuxt): use generic addBuildPlugin interface

this automatically allows all build plugins unplugin supports and which nuxt also supports, currently webpack + vite, and rspack in future

I didn’t even knowaddBuildPlugin was a thing 👏


Do you have plan to support some Text to Speech Model？

Thanks for your meaningful work I found the examples are T2I and T2V work. Do you have a plan to support some Text to Speech Models, like https://github.com/SWivid/F5-TTS

Its backbone is DiT

Yeah, I will try. Thank you!


fix date picker date format

https://day.js.org/docs/en/display/format

@dumitrudanu We can't do these change, the react-datepicker use date-fns and the formats are incompatible


'Install' target for dlib_python

Expected Behavior
I'm building python bindings for dlib (dlib/tools/python) with CMake. The only one thing I'm missing is INSTALL target which would move dlib.cpython lib to a proper location. This is a problem for me as without it I need to use ugly workaround in my project (which uses dlib as a subproject), to locate and install dlib.cpython lib.
Current Behavior
No install target.
Steps to Reproduce

Version: current master (3aad318e)
Where did you get dlib: github
Platform: 64bit Arch Linux
Compiler: gcc

You are supposed to use setup.py. Why don’t you want to do that?

Oh thx. I wasn't aware of this script.

One more thing: cmake target would be easier to integrate with existing cmake projects. Script still requires some hacks.

You are using python right?  Why don’t you want to use python’s package system for python modules?

I'm using c++ which launches some python scripts. It would be easier for me to build dlib together with my app, but currently it is not easy to do.

What do you do about all the other python modules you use. Like numpy?

Generally speaking I do not have that much problem on linux, where dlib and other python modules are installed on my system. Now I'm trying to get things work on windows where I need to provide everything which my app depends on. At this moment I'm trying to find nice way to install dlib. Other python stuff is in a queue ;)

You should really use the python package manager.

Anyway, I'm not going to add an install target in cmake.  I used to have one but most people who use python haven't got any idea how to use the dlib.so file if it's not installed by the python package manager into dist-packages.  That is, they don't know what the python path is, or what dist-packages is, or what a .so file is, or any of that stuff.  They just know they type some magic command and then they can write import dlib and it works or doesn't.  I still get many confused questions from people who have multiple copies of python installed and they installed dlib in one python's dist-packages but then started using a different python where isn't not installed and they are confused.  Many of them don't seem to even understand what a filesystem is.
So I used to have a cmake install target that would copy the dlib.so file into the python_examples folder because that lets you just run the examples, since python always searches the current folder for modules.  That seems like the simplest possible example to show what's going on.  You got the .py example program and the dlib.so you are loading, which is what the example is about.  But like I was saying above, it turns out that most python users can't handle that.  I honestly think many of the people who email me don't understand what a filesystem is.
Anyway, because of all that there is no way I'm giving python users more than one path to install dlib.  I get enough confused emails already. You have to generally assume that many python users are just learning to use a computer so things need to be as easy and 'this is the one and only path' as possible.

I see ok, I'll handle it all somehow :)


Documentation updates

Codecov Report

Merging #994 (309d494) into main (4c217f3) will increase coverage by 1.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   77.87%   79.34%   +1.47%
==========================================
  Files         141      145       +4
  Lines        4817     5146     +329
  Branches      628      664      +36
==========================================
+ Hits         3751     4083     +332
- Misses        933      937       +4
+ Partials      133      126       -7

Impacted Files
Coverage Δ

src/CreeDictionary/API/schema.py
100.00% <0.00%> (ø)

src/CreeDictionary/phrase_translate/crk_tag_map.py
100.00% <0.00%> (ø)

...ctionary/phrase_translate/definition_processing.py
100.00% <0.00%> (ø)

...ary/phrase_translate/definition_processing_test.py
100.00% <0.00%> (ø)

...ranslate/management/commands/translatewordforms.py

...hodict/lexicon/management/commands/randomsubset.py
43.24% <0.00%> (ø)

...dict/lexicon/migrations/0004_keyword_uniqueness.py
100.00% <0.00%> (ø)

src/morphodict/lexicon/importer/test_importer.py
99.52% <0.00%> (ø)

.../morphodict/lexicon/migrations/0005_import_hash.py
100.00% <0.00%> (ø)

src/morphodict/lexicon/importer/conftest.py
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c217f3...309d494. Read the comment docs.


SPIKE: Choose an initial set of integration tests

Choose an initial set of functionalities/flows to test via integration tests. These tests should balance bug detection with impact on development throughput.
Update the testing document from issue #514 with the chosen set of tests

Potential source of inspiration: The Critical User Tasks from the Site Reliability Plan:
https://docs.google.com/document/d/1ou2CsZdz2ddDBzySxguTvU4Yh0Hw7zrm95THT_LcLC4/edit#

One test case we should include: credential refresh
We've had recurring issues where we forget to whitelist a domain with Google or something else goes wrong and our attempts to refresh the token to save notebooks in leo fails. This causes users to lose all  their work after the first hour. An especially bad bug


[Bug]: After moduleFederation is turned on, polyfill does not take effect.

Version
latest

Details
The minimum configuration is as follows:
moduleFederation: {
    options: {},
  },
  output: {
    polyfill: 'entry',
    overrideBrowserslist: ['chrome 70'],
  },

At this time, corejs injection does not take effect.
In addition, this seems to be a problem with rspack, webpack is ok
Reproduce link
no
Reproduce Steps
no

You can find the core-js code in this chunk:

The default lib-polyfill chunk will not be generated when using moduleFederation.options, see https://rsbuild.dev/config/module-federation/options

@chenjiahan  You need to run it under chrome 70, and then the following error will appear.

The problem is that the polyfill does not take effect, not the splitChunk rule.

Any new progress？ @chenjiahan

Any reproduction?

Sorry, my description is wrong, in fact the problem is that mf requires globalThis. However, after rsbuild turns on mf, corejs will be additionally divided into chunks and executed later, thus causing an error.
Uncaught ReferenceError: globalThis is not defined

https://github.com/nanianlisao/rsbuild-repro/tree/main
pnpm run dev
Open it in chrome 70 and you'll find the error

Get, I have reproduced this problem. The MF runtime runs earlier than core-js, so the core-js globalThis polyfill cannot work as expected.
I will discuss with MF members how to fix this.

A workaround is to use polyfill: "usage", this ensures that the polyfills can run before the MF runtime code.
export default defineConfig({
  plugins: [
    pluginReact({
      fastRefresh: false,
    }),
  ],
  moduleFederation: {
    options: {},
  },
  output: {
    polyfill: "usage",
    overrideBrowserslist: ["chrome 70"],
  },
});

Yes, it works. But I would like to inject polyfill via entry, for example for compatibility with some third-party packages, and it works fine in webpack.

Do you mean webpack's Module Federation v1 plugin or Module Federation enhanced?
Module Federation v1 does not use globalThis.

I have discussed this with @2heal1 and MF will consider adding a minimal globalThis polyfill to the runtime code.

Try<EMAIL_ADDRESS>by setting implementation options


Consolidate duplicated code in BaseActivity

Some examples, the same routine for wiping the app is in MainActivity and FallbackActivity. MainActivity and TextMessageActivity both have the same logic for choosing text colour depending on background colour.

This issue has been resolved, I have placed the offending code in BaseActivity to reduce duplication for both instances. Update with this will be pushed to the play store soon.


feat: scania colors for storybook ui

Describe pull-request
Updating Storybook with Scania colors
How to test

Open the Storybook link that will build this PR
Compare it with Production one
Check to see if you see new colors in menu, tabs selector...

Additional context
Alex can approve visual changes but the developer would need to confirm the code side.
More about Storybook theming here

@alexlioliopoulos - Last PR had some issues with generating Netlify links. I made this one, it seems fine now.

Looks good :D Is it possible to use design tokens instead of hex codes?

At the moment I have no idea if we can somehow connect our CSS color file with theme JS in Storybook to load colors with our tokens.
What I did is to add comments of what is a token name of given hex color so we can easily track it and update it later on if needed.


Is Object detection possible using MobilenetSSD with snpe

Hi, I converted my mobilenetSSD caffe model to .DLC file with snpe APIs. When i run snpe-net-run command it returns .raw files as output. Can i get the detection coordinates to draw the Bounding boxes? Is it possible with this .dlc file?

We are looking into it.

@v-prsasa , Thanks for the reply and effort. This guy has shown me the result -
https://github.com/globaledgesoft/AIML-Board-App/issues/4#issuecomment-626290832
It will be helpful if you could show me how to run this in qcs605 or similar board. I mean what all snpe files need to copied into the board. I'm copying snpe-<IP_ADDRESS>8/lib/aarch64-linux-gcc4.9 files, but still getting error.

@Devinwong Hi Devin, can you look into this issue?

@PiyalGeorge  the SNPE along with VAIDK firmware is 1.25. If I understand correctly, you are trying to upgrade the firmware to SNPE1.37 in order to run your DLC which was also converted by SNPE 1.37 SDK. This is not trivial and it also needs official support from Qualcomm to make an upgrade.

@PiyalGeorge Is this issue resolved?

@PiyalGeorge Is your issue resolved?

Yes @v-prsasa , the issue is resolved. https://github.com/globaledgesoft/AIML-Board-App/issues/4#issuecomment-626290832
Thanks for the help.


redis directory shell script entrypoint.sh fails on windows based docker desktop

_#!/bin/bash
start a background process that periodically runs redis-cli CLIENT PAUSE to stall the server, if the env var TOGGLE_CLIENT_PAUSE is set to true
echo "performing backup" >&1
if [ "$TOGGLE_CLIENT_PAUSE" = "true" ]; then
echo "Starting redis client-pause loop"
while true; do
echo "performing backup" >&1
redis-cli CLIENT PAUSE 3000 >&1
sleep 30
done &
fi
start redis
echo "Starting redis-server"
exec redis-server_
fails with message
Syntax error: Bad fd number

solution was remove all  >&1.. pl. check if ok as per the chatgpt..
#```
!/bin/bash
Start a background process that periodically runs redis-cli CLIENT PAUSE to stall the server, if the env var TOGGLE_CLIENT_PAUSE is set to true
echo "performing backup"
if [ "$TOGGLE_CLIENT_PAUSE" = "true" ]; then
echo "Starting redis client-pause loop"
while true; do
echo "performing backup"
redis-cli CLIENT PAUSE 3000
sleep 30
done &
fi
Start redis
echo "Starting redis-server"
exec redis-server

after this change redis did work fine..

<img width="1277" alt="image" src="https://github.com/elastic/observability-examples/assets/332234/e7f2e772-498c-43b5-9836-de06f8241d72">


drive not available in AUR (Arch User Repository)

drive seems to have gone missing from AUR:
yaourt -S drive
error: target not found: drive
the Platform Packages information is, therefore, outdated.
I would appreciate an indication of other means of installing under Arch-based distros.

You can install drive using Go.
Follow the Golang installation guide, make sure you have the path configured:
cat << ! >> ~/.bashrc
> export GOPATH=\$HOME/gopath
> export PATH=\$GOPATH:\$GOPATH/bin:\$PATH
> !
source ~/.bashrc # To reload the settings and get the newly set ones # Or open a fresh terminal

and do:
go get -u github.com/odeke-em/drive/cmd/drive

Source: drive installation guide, I'm currently using drive in Arch.

@mr-avila you can use instead yaourt -S drive-bin
i found it from this thread https://bbs.archlinux.org/viewtopic.php?id=240413

@mr-avila this should be fixed now with b76b1f2f1ae8ee35b1ce76fa28b230718b8b5db4

Great, thanks everyone, thank you @avila for the report, @cgxeiji @cniw @m-svo for chiming in! The issue was reported as fixed by @m-svo in https://github.com/odeke-em/drive/issues/1042#issuecomment-503914082 and so I shall close this one.


Donut Chart : Is it possible to add images on each part of donut ?

Hi ! Great job with Chart.js!
I have to create some donut charts with images on each part of donut, like this (do not include red line):

Is it possible with Chart.js?
What is the trick?
Thx a lot for any answers

@ticlekiwi this is not currently possible in the core. There are number of solutions out there for drawing text, you can adapt them to use the canvas drawImage function instead.

@etimberg thx for your answer!
I will try to adapt this with the canvas drawImage when I will have time for that!
I close this issue.


Update README.md, fix broken link

Replace broken dev_guide link with url.
Also add a sentence on what happens when cookiecutter is executed.

It's not "broken", it's only broken if you browse the readme ;) It's working in the deployed website.
To avoid copying the same files around, it takes the guide from the cookiecutter docs dir directly
(docs_dir: "{{ cookiecutter.__project_slug }}/docs")
Have you tried your "fix"? I think if you'd do it like this, then you'll ACTUALLY break the link on the website (because the local md paths are mapped to urls, and if you never refer to a file, the site/URL will not be created in the first place).
I guess you just read the README.md on Github? the problem is, I can't "symlink" the file to the top level (as a better actual fix) because Github does not make symlinks transparent (it would link to a file that says this is a symlink to some path).
So, TL;DR: short of copying the file (and updating the copy automatically or manually whenever it changes) I see no solution.
I think maybe it's actually better to leave it as is until I set up the synchronized "demo repository" and link to that repository (containing also this file), instead to the guide.


Adding LICENSE to match package.json

Including the full text of the license with the source makes it easy to discover and review the full terms and conditions.

From a man who knows licenses. ;-)
thanks!


Mattbullock/ch15225/add link to reporting form from trading page

https://app.clubhouse.io/augur/story/15225/add-link-to-reporting-form-from-trading-page

This pull request introduces 1 alert when merging 58d1512544f970f561450a33726584810613dece into af21f458942e2f44d03d62cc4a9fb231f6086d5c - view on LGTM.com
new alerts:

1 for Expression has no effect

Comment posted by LGTM.com

Coverage remained the same at 64.493% when pulling 58d1512544f970f561450a33726584810613dece on mattbullock/ch15225/add-link-to-reporting-form-from-trading-page into af21f458942e2f44d03d62cc4a9fb231f6086d5c on master.


problem about value of

the current version (1.0.8) in npm
<select name="s">
    <option value="">empty</option>
    <option value="1">1</option>
</select>

when the <select> above selected the empty option,
formToObject will return
  {
    s: "empty"
  }

but I was expecting that it would return false;
I remembered that the previous version of form_to_object would return false, is the value is "";

sorry, my fault,


Picking up 2 tips on a 1-channel chatterbox backend fails with unclear error

I understand that this is not the intended usage, but naive users like me would (perhaps) land in this spot too, and get stuck.

It seems that PLR is not "realising" that the backend has 1 channel, and failing to use the second channel (with "Key 1").
I'd like to suggest adding a check to (at least) the pick_up_tips command, that handles this kind of inconsistency.
I'd suggest a spot but I'm have no clue where (yet). Let me know if I can help.

A similar error appears with aspirate:

Note that as a regular user of the R language, I tend to assume that all operations are vectorized. I expected lh.aspirate(plate["A1:A2"], vols=[100.0, 50.0]) to mean "aspirate 100 from A1 into channel 1, and then 50 from A2 into channel 1."

Thanks for reporting!
Fixed with https://github.com/PyLabRobot/pylabrobot/commit/48fb5cda5c888fea0f7257e73881974b829bbdd6.

Note that as a regular user of the R language, I tend to assume that all operations are vectorized. I expected lh.aspirate(plate["A1:A2"], vols=[100.0, 50.0]) to mean "aspirate 100 from A1 into channel 1, and then 50 from A2 into channel 1."

Correct

Thank you Rick :) I'll be making some basic hardware tests this weekend on
a rudimentary backend.
Best!
On Mon, 3 Apr 2023, 19:34 Rick Wierenga, @.***> wrote:

Closed #26 https://github.com/PyLabRobot/pylabrobot/issues/26 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/PyLabRobot/pylabrobot/issues/26#event-8917926492, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY3XPSU4IUJJKAPWN3XPP3W7NGALANCNFSM6AAAAAAWQUPSFQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Rick, sorry to bring this up again.

Note that as a regular user of the R language, I tend to assume that all operations are vectorized. I expected lh.aspirate(plate["A1:A2"], vols=[100.0, 50.0]) to mean "aspirate 100 from A1 into channel 1, and then 50 from A2 into channel 1."

Correct

I just want to check if that really is correct.
I am still getting the error:

I think the vectorization in those functions is only channel-wise (i.e. to operate multi-channel pipettes).

aspirate 100 from A1 into channel 1, and then 50 from A2 into channel 1."
Channels are actually 0-indexed. Excuse the oversight: 100 from A1 into channel 0 :)

The error you see is because you're aspirating from two wells simultaneously (A1 and A2), whereas your backend echo only has one channel (as set by the num_channels property).
All atomic operations (aspirate, pick_up_tips, drop_tips, dispense) are expected to be executed simultaneously. Big robots like STAR support this up to 16 channels, although 8 is typical. If the user wants to do things separately, they should make two method calls on lh.

sorry to bring this up again.

this is technically a separate issue, but in general please don't hesitate to tell me about anything you think can be improved.


Update some tests for pandas 2.1

[ ] Closes #xxxx
[ ] Tests added / passed
[ ] Passes pre-commit run --all-files

Addresses some of them

catch_warnings for concat seems flaky, not sure if this is expected. But this raises errors even if we always filter future warnings
the arrow roundtrip test is weird, we shouldn't put Decimals into string[pyarrow] generally
idxmax/idxmin is tricky, I am skipping the warnings for now and opened #10464

The sql tests and the groupby failures will get fixed upstream

Let's see how this looks now. I patched a bunch of things upstream, so might see new issues

XREF https://github.com/dask/distributed/issues/8147

This LGTM, thanks for handling this @phofl. Will merge once CI finishes

@phofl you mentioned wanting to skip the ValueError: Buffer dtype mismatch, expected 'const intp_t' but got 'int' (upstream issue) separately -- could you push up a PR for that?

#10488


DS3 A Apte

Sprint Challenge Code Review
Week 3 - Creating Professional Portfolios

Part 1 — Lede
A good lede. You could make this stronger by applying "when's" and "how's". This is a great sell on the topic, but it does not tell me what will you do in the project.
Try also using Hemingway to make your writing accessible to wider audiences!

Part 2— Sources
Strong sources - make sure you find the time to read through so much content!

Part 3 — Action Plan
Nice start on the action plan, good markdown formatting. Looking forward to seeing more of your project!
Well done!


[SPARK-15633][minor] Make package name for Java tests consistent

What changes were proposed in this pull request?
This is a simple patch that makes package names for Java 8 test suites consistent. I moved everything to test.org.apache.spark to we can test package private APIs properly. Also added "java8" as the package name so we can easily run all the tests related to Java 8.
How was this patch tested?
This is a test only change.

cc @andrewor14

Test build #59527 has started for PR 13364 at commit f44883f.

Test build #59527 has finished for PR 13364 at commit f44883f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class Java8RDDAPISuite implements Serializable
public class Java8APISuite extends LocalJavaStreamingContext implements Serializable
public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext
public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
 static class IntSumOf extends Aggregator<Tuple2<String, Integer>, Integer, Integer>
public class JavaDatasetAggregatorSuiteBase implements Serializable
public class JavaSaveLoadSuite

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59527/
Test FAILed.

Test build #3029 has started for PR 13364 at commit f44883f.

Test build #3029 has finished for PR 13364 at commit f44883f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class Java8RDDAPISuite implements Serializable
public class Java8APISuite extends LocalJavaStreamingContext implements Serializable
public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext
public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
 static class IntSumOf extends Aggregator<Tuple2<String, Integer>, Integer, Integer>
public class JavaDatasetAggregatorSuiteBase implements Serializable
public class JavaSaveLoadSuite

Merging in master/2.0.


Update UG

Codecov Report

Merging #357 (d4eb4cf) into master (7b6a2c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #357   +/-   ##
=========================================
  Coverage     63.43%   63.43%
  Complexity      835      835
=========================================
  Files           136      136
  Lines          3140     3140
  Branches        412      412
=========================================
  Hits           1992     1992
  Misses         1067     1067
  Partials         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6a2c8...d4eb4cf. Read the comment docs.


Calendar:fix not correct day of week when the day is Sunday

Calendar:fix not correct day of week when the day is Sunday
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

#15368

Thank you for your contributions!


Error when adding product policy price in rupees sign (₹)

I have tested this bug on your live demo - demo.bagisto.com/
and also on v1.3.3 of bagisto.
Scenario:
I have edited product policy first line (Free Shipping on Order $20 or More) in velocity meta data from admin in rupees sign (Free Shipping on Order ₹20 or More) and on the user side it is mixing the symbol with price I am attaching the screenshots for both user and admin side .

This issue is duplicate: https://github.com/bagisto/bagisto/issues/5324

This issue has resolved product policy meta data error but in product card it is still there , the special price is coming right but original price is still being overlapped


Turn dex data into first-class citizens

There's too much code duplication surrounding the interpretation of DexData objects and the subtle ways in which they affect different inferences. Centralize these aspects into active objects that encapsulate these connected features and inferences.
This could be done by turning PossibilityClass into a type of monad by utilizing its #then() method and using it more often, while also including variants of the method representing the different uses of this class.
Also stabilize PokemonTraits and StatTable by making them immutable once narrowed, and creating new instances when something changes significantly (e.g. transform, form changes, etc). This can be useful for establishing a "paper trail" of sorts in order to allow inferences/assertions to be made in retrospect which could simplify much of the AbilityInference/ItemInference code.

Closing in favor of #288.

Closing in favor of #288.


Running without fps or the equivalent can get poor results

I've noted this before.
For example, if you have a control sending data to an empty animation, if you don't set an fps and the processor runs flat out, the updates to simpixel are extremely intermittent.

Personally I think we should have a default capped FPS, like 60 at the
most. Honestly, anything above that is just silly. I usually even just run
at 30fps as it looks smooth but doesn't put too much strain on the CPU.
On Fri, May 4, 2018 at 6:54 AM Tom Swirly<EMAIL_ADDRESS>wrote:

I've noted this before.
For example, if you have a control sending data to an empty animation, if
you don't set an fps and the processor runs flat out, the updates to
simpixel are extremely intermittent.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/792, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6a6i9VeSPWbaAEbUHOeTpU75QE_WSZks5tvDNrgaJpZM4TydjF
.


Switch to Material Design

Current design seems suffice for the use scenario, perhaps this might be needed later, but as of now, I'm closing the issue.


Question: what is the .vsts-ci.yml file used for?

I noticed a .vsts-ci.yml file in this repository, and I am wondering if it does what it seems like (i.e. is to VSTS what a .travis.yml file is to Travis-CI)
Does the VSTS build (and/or release) system support defining the build in a yaml file in the same repo as the rest of the content? If so is there any documentation on this you could point me to?

Yes.  We're self hosting by building this repo using it.  It is getting ready for an early internal preview and we hope to have an early public preview soon.
Here's a link showing our general direction:  https://youtu.be/lkPnv5H2ANI  (that video is a bit old but will give you an idea)

Thanks Bryan, that is exciting news!


ArgumentError in url_for in Comfy admin partials after deploy

Expected behavior
After installing and creating migrations, pushing CMS configurations to a remote server should result in a correctly configured CMS instance.
Actual behavior

When attempting to access the CMS admin area, I get errors like the above.
Steps to reproduce
I deployed a healthy working local configuration of Comfy to a Dev instance backed by AWS Elastic Beanstalk. I expected to be able to configure the first site in the admin area as normal, but was greeted by this instead.
System configuration
Rails version:
5.2.2
CMS version:
2.0.0
Ruby version:
Local: 2.5.1p57
Server: 2.5.3p105

Been tearing my hair out over this one for a few days! routes.rb does include
  comfy_route :cms_admin, path: "/admin"
  # Ensure that this route is defined last
  comfy_route :cms, path: "/cms"

at the end.

Does it work normally locally? Line that's causing the issue is this: https://github.com/comfy/comfortable-mexican-sofa/blob/master/app/views/comfy/admin/cms/categories/_index.html.haml#L7
That should just generate current url without ?categories param. Nothing special going on here.
Does you app do something weird with url generation in production environment?

This does work locally. We're not doing anything special or environment-specific with URL generation on production--they have the same routes.rb file.
Here's the full routes.rb file:
Rails.application.routes.draw do
  namespace :admin do
    resources :press_about_us_links
  end

  scope path: "app" do
    # Devise Routes
    devise_for :users,
               # Override default controllers to Users Controllers
               controllers: {
                 confirmations: "users/confirmations",
                 registrations: "users/registrations",
                 sessions: "users/sessions"
               }

    devise_scope :user do
      post "/users/confirmation" => "users/confirmations#resend"
      patch "/users/confirmation" => "users/confirmations#confirm"
    end

    scope path: "verifications" do
      get "authentication_failed" => "verifications#authentication_failed"
    end
    resources :verifications

    resources :profiles

    # For Incident Form controllers
    resources :incidents, only: %i[new edit show] do
      resources :steps, controller: "incidents/steps", except: [:destroy]
    end

    resources :offenders, except: [:destroy] do
      resources :steps, controller: "offenders/steps", except: [:destroy]
    end

    get "dashboard" => "dashboard#show"
    scope path: "progress" do
      get "welcome" => "progress#welcome"
      get "offender_completion" => "progress#offender_completion"
      get "incident_completion" => "progress#incident_completion"
      get "wait_for_connections" => "progress#wait_for_connections"
      get "understood" => "progress#understood"
    end

    authenticated :user do
      root "dashboard#show", as: :authenticated_root
    end

    root to: redirect("/home")
  end

  root to: "marketing#home"
  get "home" => "marketing#home"
  get "what_we_do" => "marketing#what_we_do"
  get "take_action" => "marketing#take_action"
  get "take_action/human_resources" => "marketing#human_resources"
  get "take_action/anonymous_systems" => "marketing#anonymous_systems"
  get "take_action/audit_committee" => "marketing#audit_committee"
  get "take_action/eeoc" => "marketing#eeoc"
  get "take_action/attorneys" => "marketing#attorneys"
  get "take_action/law_enforcement" => "marketing#law_enforcement"
  get "take_action/professional_associations" => "marketing#professional_associations"
  get "resources" => "marketing#resources"
  get "answers" => "marketing#answers"
  get "about" => "marketing#about"
  get "about/contact" => "contact#show"
  post "about/contact" => "contact#create"
  get "about/press" => "marketing#press"
  get "about/press/about_us" => "marketing#press_about_us"
  get "about/media" => "marketing#media"
  get "privacy_policy" => "marketing#privacy_policy"
  get "terms_and_conditions" => "marketing#terms_and_conditions"
  get "security" => "marketing#security"

  comfy_route :cms_admin, path: "/admin"
  # Ensure that this route is defined last
  comfy_route :cms, path: "/cms"
end

It's not the issue with routes file. Something is going on with url_for helper. Googling around suggests that might be a thing if routing helpers are explicitly included somewhere. The fact that it works in development suggests that there's an environment-based code that does something odd.

Interestingly, it turns out that this also doesn't work on any of my colleagues' local environments. It's still not clear to me why... somehow there's something special about my local environment. So far don't have any good leads--I thought if I wiped my DB and tried again that I'd be left with the error, but that didn't work.

I do have a mailer where I included the url_helpers... I don't have a good understanding of why these would be related, but I suppose it's worth seeing what happens if I remove it.
include Rails.application.routes.url_helpers

class Users::Mailer < Devise::Mailer
  layout "transactional_email"

  def devise_mail(record, action, opts={})
    initialize_from_record(record)
    mail(headers_for(action, opts)) do |format|
      format.text
      format.html
    end
  end
end

I don't know much about Devise mailers, but in regular Rails mailers you don't need to include route url helpers as mailer views are treated like normal views. The only catch is defining a host.
Also, if you are including, make sure it's inside the mailer class. Right now you basically including them into the global namespace. Who knows what weird things that does.

Cool, yeah, I think this somehow had something to do with that include line. Removing it appears to have gotten us to a good place across all environments. Thanks for the help!!


Using INSTANCE_ID in a shader renders it useless.

Godot 3.0.2 + Windows 10
Reproduction: use this shader when rendering 2 (not tested in other cases) instances with a MultiMeshInstance object:
shader_type spatial;
render_mode blend_mix,unshaded,cull_back;

void vertex() {
        //removing the line below will make the shader work
	INSTANCE_ID;
       //same applies to "int a = INSTANCE_ID;"
}

void fragment() {
	ALBEDO = vec3(1.0,0.0,0.0);
}

When INSTANCE_ID is not used, shader draws the meshes as normal, when it is used, nothing is rendered.
This makes instancing useless.

I'm not sure the line you wrote is valid shader code, though.

It is valid statement which does nothing. Also, you can change it to int a = INSTANCE_ID; and get the same result. Optimizing it out could be an issue, but this a reduced example, which I encountered when attempting to use the variable in a more complex shader.