[feature request] Majority voting

ndimage.filters has quite useful filters, but in my opinion one filter could be implemented:
An occurrence based filter, such as a majority filter.
The filter would go over an array, count occurrences within the given window size and take the n-ths most occuring value as an output, e.g.:
arr = [1,1,2,3,4,4,5,6,6,6,7,8,8,8]
res = occurence_filter(arr, size=5, rank=-1,  mode='valid')
# pseudocode
for i in range(len(arr)-size):
    w = arr[i:i+size]
    occurences = count_unique_values(w) # e.g [2:1,3:1,4:1,1:2]
    ranked = occurences[rank] # =1
    res[i] = ranked

# res = [1,4,4,4,4,4,6,6,6,6,8]

would it make sense to implement such a filter?
Or is there any other way I can express such an operation that I haven't seen yet?

Sounds reasonable, and there's at least some demand for it: https://stackoverflow.com/questions/39829716/majority-filter-python
May be a bit specialized though and fit better in scikit-image. @stefanv @jni any opinion on this functionality?

Seems like a job for ndi.generic_filter and LowLevelCallables! =) We would certainly welcome this in scikit-image filters, but given that it is straightforward (cough) to implement with ndimage primitives, possibly it could sit there as a model for how to use these features.
@skjerns for references on how to use these:
https://ilovesymposia.com/2017/03/12/scipys-new-lowlevelcallable-is-a-game-changer/
https://ilovesymposia.com/2017/03/15/prettier-lowlevelcallables-with-numba-jit-and-decorators/
Those both use Numba, which neither SciPy nor scikit-image have as a dependency yet. This notebook from @kne42 has a reference about how to do this with Cython:
https://gist.github.com/kne42/b487af595332db468654a5c5b1ce416c
And of course see also the SciPy documentation:
https://docs.scipy.org/doc/scipy/reference/tutorial/ndimage.html#ndimage-ccallbacks

This sounds like it may be implemented effectively with skimage.filters.rank.  The generic-filter version is going to be pretty slow without some kind of acceleration (such as the ones mentioned above).

@stefanv what do you mean exactly? I'm probably missing a step in my brain, but I can't map a rank filter to "bincount" which is what needs to happen here?

@jni Rank filters calculate the histogram of values under the window, and that histogram is updated each time the window moves.  From that, you can find the n-th most occurring value, I suspect?

🤯
Having said that, the real solution is to fix SciPy's filters to use this technique, right? =) See #4878

The rank filters only operate on integers, though, and SciPy's API is quite complex (as discussed in #4878).  That said, we need to find a champion for ndimage: it is in maintenance mode right now, and as we discovered during the GSoC that @jaimefrio mentored, there is a lot of room for improvement.

The rank filters only operate on integers

and are 2D only, if I remember correctly.

Great that there seems to be some interested in this.
@jni I can have a look at the low-level API and see if I can come up with a solution. However, this would be new terrain for me and I always had a bit of respect for contributing to such important packages as scipy.

The rank filters only operate on integers
and are 2D only, if I remember correctly.

indeed, however the 1D operation can just be reframed as a 2D problem via reshaping?

However, this would be new terrain for me and I always had a bit of respect for contributing to such important packages as scipy.

Welcome and never fear! Packages like SciPy have coalesced into something of extremely high quality, but it is through the gradual contributions and improvement of scientists who have not been trained as software engineers.
Having said this the ndimage code base is quite challenging, as hinted at by @stefanv. Where are you based, @skjerns? Any chance you'll be coming to the SciPy conference in July or EuroSciPy in August?

however the 1D operation can just be reframed as a 2D problem via reshaping?

It is not 1D arrays that I am worried about, but 3D and higher. =)

On Wed, 27 Feb 2019 04:08:51 -0800, Juan Nunez-Iglesias wrote:

however the 1D operation can just be reframed as a 2D problem via reshaping?

It is not 1D arrays that I am worried about, but 3D and higher. =)

The principles of rank filtering hold in higher dimensions, but we'll
have to rewrite the window sliding code to be more general.  That said,
I suspect there is code like that inside of NumPy already, which one may
be able to co-opt.

So the preliminary solution right now is to write some code based on ‘generic_filter’ and (possibly) ‘numba’ and include that as a.. tutorial or something like that? Or as a function to ndimage?

Having said this the ndimage code base is quite challenging, as hinted at by @stefanv. Where are you based, @skjerns? Any chance you'll be coming to the SciPy conference in July or EuroSciPy in August?

I’m europe based, but I don’t think I will come to the conference, sorry :-/

So the preliminary solution right now is to write some code based on ‘generic_filter’ and (possibly) ‘numba’ and include that as a.. tutorial or something like that? Or as a function to ndimage?

I'll let @stefanv and @jni comment on the generic_filter bit, but regarding Numba: we can't accept it as a dependency (yet, we'd like to get there at some point), but it may be the most user-friendly way to implement this functionality in a performant way. I haven't used it yet, but
Numba's @stencil decorator may be very helpful here.

@skjerns some of the links I shared show how to use Cython instead of Numba. You could implement it with Cython and then add it as a PR either here or in scikit-image. Both places make sense to me.

I gave it a try and created a pure-python version using C++ map
majority_filter.pyx
cimport cython
import numpy as np
cimport numpy as np
from collections import defaultdict
from numpy cimport npy_intp
from libcpp.map cimport map as cpp_map # using ordered map seems faster than unordered map
cdef extern from "math.h":
    float INFINITY

# version to compare to using standard python objects
@cython.boundscheck(False)
@cython.wraparound(False)
def vanilla(np.ndarray x not None):
    cdef:
        Py_ssize_t i,n
    n = len(x)
    dx = defaultdict(int)
    for i from 0 <= i < n:
        dx[x[i]] += 1
    max_v = max(sorted(dx), key=lambda k: dx[k])
    return max_v

# pure - Cython variant
cdef api int llc_cython(double *buffer, npy_intp filter_size,
             double *return_value, void *user_data):

    cdef cpp_map[double, int] counter
    cdef int c
    cdef int c_largest = -1
    cdef double k
    cdef double k_largest = INFINITY
    for i from 0 <= i < filter_size:
        k = buffer[i]
        c = counter[k] + 1
        counter[k] = c
        if c >= c_largest:
            if k<k_largest:
                c_largest = c
                k_largest =  k
    return_value[0] = k_largest
    return 1

test.py
from scipy.ndimage.filters import generic_filter
from scipy import LowLevelCallable
import time
import numpy as np
import pyximport
pyximport.install(inplace=True, reload_support=True)
import majority_filter

#%%
np.random.seed(0)
arr = np.random.rand(512,512)
footprint = np.ones(25).reshape([5,5])
llc_python = LowLevelCallable.from_cython(majority_filter, "llc_cython")

start = time.time()
res1 = generic_filter(arr, majority_filter.vanilla , footprint=footprint, mode='constant')
print(time.time() - start) # -> 3.7 s

start = time.time()
res2= generic_filter(arr, llc_python , footprint=footprint, mode='constant')
print(time.time() - start) # -> 0.8 s

print(np.mean(np.isclose(res1, res2))) # -> all close with this mode. 'reflect' seems to differ

Maybe you can have a quick look at it and see if I'm going in the right direction?
0.8 seconds seems still rather slow for 512x512 image, yet I don't know how else to implement a counter in Cython?

Hey @skjerns! Thanks for the code samples.

Broad picture, I think this gets back to @stefanv's comment that the correct way to implement this is with rolling histograms, or, if you want to support floats, a rolling map as you have. The point is that you are actually iterating over a length-25 array on every pixel of the image. So you should think about processing a (25, 1024, 1024) array to get a bit closer to reasonable expectations.

More specifically for your code, have you run cython -a on it? It'll tell you if it's expected to be slow in various bits. If you are not touching Python code (all lines of your Cython function are white), then there is likely not much else for you to do. I don't think you'll go much faster than a cpp map for this problem. Having said that I don't know why you didn't turn off bounds checking and wrap around in your "fast" version?

@jni  Thanks!

That's true. Rolling map will require another solution than generic_filter I guess. 25x1024x1024 takes around X seconds, far to slow I assume
There's no dependency of Python, all lines are white.
I've created a version that assumes ints of 0-256. It's (of course) much faster, however, still slow. The bounds and wrap checks were not intentional. I've adapted some code from the internet, removing them makes no difference.

So to wrap up: We leave this solution for now?
Or should I somehow still add it as an example of Cython-LLC-generic_filter?

Personally I think it would make a very cool documentation example. @rgommers what do you think? The thing is it's best put in a gallery kind of setting, which I don't think (?) SciPy has?

So to wrap up: We leave this solution for now?

Yeah, I think the function is too slow to add it to ndimage.

The thing is it's best put in a gallery kind of setting, which I don't think (?) SciPy has?

We've got a pretty big one: https://scipy-cookbook.readthedocs.io/. A lot of content is quite old, but that is our user-contributed gallery. We accept PRs with notebooks for it (repo at https://github.com/scipy/scipy-cookbook).
We also have a doc section where this would fit, http://scipy.github.io/devdocs/tutorial/ndimage.html#extending-scipy-ndimage-in-c, however I'm not sure how much it adds over the example that's already there. So I think adding it to scipy-cookbook and perhaps linking it from that "extending ndimage" doc section would be quite nice.

Hi all,
I made a PR related to this issue in scikit-image. The proposed implementation relies on the skimage.rank Cython framework. Its major drawback is that it only supports uint8 and uint16 data type.
May be a generalization to more dtypes can be implemented in scipy?


Added note that this feature is only avalable for paid subscriptions

Saw this passing by on slack, people searching for this feature. while they didn't have a paid subscription and didn't find this in the documentation

Thanks René!


Fix "Combine Items" button overlap with "Use as substitution"

Close https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/11959
I also noticed clicking "Search Box Mode" removes the combine items button, but haven't tracked down the cause.

havent looked at the code, but works and fixes the problem in game!


Improved Command Line with CLI11

Implemented the CLI11 as new command line parser as requested in #150 .

I haven't looked at details but could you also update readme?
(@iomaganaris also take a look when you time permits.)

please retest

please retest

This looks fine. My only question is when to trigger the merge. As this changes all command line option, before merge we have to make sure following things are updated:

https://github.com/nrnhines/ringtest
lib/modlib/CoreConfig.mod in old neurodamus as well new neurodamus

How should we handle blueconfigs/scx-v5-plasticity/output/sim.conf for example, producing old parameters scheme?

I reduce impact of this patch.

Please retest

Please retest

Do it à la boost.
0.16.0 => 001600
1.2.3 => 010203
Easy to compare

Exactly! But I left patch out, I dont expect that level of granularity to be required. But what do you think?

So let's go ;)


Support parse JSON format with keys containing special characters

Hi,
I would like to perform dynamic selection, querying again based on a path from the response of a previous request.
But response json key not common pattern. Slumber occurs error:
Error loading data from "/home/ranly/projects/s1f/apis/abmc.yml"
└─at position 13, in dot member name, must start with lowercase alpha or '_'

Get reponse body of accounts request:
{
<EMAIL_ADDRESS>"/redfish/v1/$metadata#ManagerAccountCollection.ManagerAccountCollection",
<EMAIL_ADDRESS>"\"1643076270\"",
<EMAIL_ADDRESS>"/redfish/v1/AccountService/Accounts",
<EMAIL_ADDRESS>"#ManagerAccountCollection.ManagerAccountCollection",
  "Description": "Collection for Manager Accounts",
  "Members": [
    {
<EMAIL_ADDRESS>"/redfish/v1/AccountService/Accounts/1"
    },
    {
<EMAIL_ADDRESS>"/redfish/v1/AccountService/Accounts/2"
    },
    {
<EMAIL_ADDRESS>"/redfish/v1/AccountService/Accounts/3"
    }
  ],
<EMAIL_ADDRESS>3,
  "Name": "Accounts Collection"
}

The chains of my collection:
chains:
  account_id:
    source: !select
      message: Select a account
      options: "{{chains.account_list}}"
  account_list:
    source: !request
      recipe: get_account_collection
    selector<EMAIL_ADDRESS>    selector_mode: array

Has this feature already been implemented, or is it actually an issue?
It seems that I couldn't find any explanation of the valid parsing method in the documentation.
Thank you

Slumber uses JSONPath for data selection. For string keys with special characters you can use the [] syntax<EMAIL_ADDRESS>


Add Elemental2DomUtil (utility methods for interacting with the DOM)

Regarding the Elemental2DomUtil, it's an Elemental2 approach for the deprecated DOMUtil (https://github.com/errai/errai/blob/master/errai-common/src/main/java/org/jboss/errai/common/client/dom/DOMUtil.java).
Regarding the errai-internal-bom/pom.xml, the elemental2-dom artifact is being added to avoid classes referenced via transitive dependencies. Since we're deprecating Errai elements in favor of Elementa2, we should make them available errai-internal-bom/pom.xml.

@manstis @mbarkley Could you please take a look? :-)

Jenkins please retest this.

Jenkins, please retest this.

Thank you for the valuable review @mbarkley. Regarding the topics that you raised:

2-spaces for indentation: fixed;
errai-internal-bom: fixed;
injectable-dom-util: fixed;
concerns about Widget.onAttach: answered (in-line).

I hope to have covered everything that you pointed out.

@mbarkley Changes applied.
I tested with the reproducer that you provided, and with kie-wb-distributions (master with -Dfull). Everything is working as expected.


Cannot use special characters on HTTP paths (http resource function name)

Description:
When defining HTTP resource functions, we cannot specify paths with special characters like $.
Ex. resource function get User/$export() returns string { ...
It shows an error when defining paths with special characters like the example above, but if we use escape character \,
Ex. resource function get User/\$export() returns string { ...
it compiles successfully, but when calling the endpoint, if we call it as http://localhost:9393/User/$export, it returns a 404 error.
To get it working, we have to url encode the special character like this http://localhost:9393/User/%24export which is not the intended way of accessing the endpoint.
Steps to reproduce:
Try this code segment
import ballerina/http;
service / on new http:Listener(9393) {
    resource function get User/\$export() returns string {
        return "Hello";
    }
}

Affected Versions:
Tried out on Ballerina Swan Lake Update 3:  2201.3.1
OS, DB, other environment details and versions:
Windows 10
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

As per the current implementation we have used Java URLEncoder class for all the URL path-related encodings. And from this class, encodes all the reserved characters given in the specification.
But as per the specification's path segment some characters are not supposed to encode and they can be used directly without encoding. For example, characters that fall under sub-delims are allowed in the path segment.
   sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
                 / "*" / "+" / "," / ";" / "="

This is not captured from the Java URLEncoder class.
So as per the initial discussion we had, decided to search for a new java library that adheres to all the requirements and use it. I found this UriUtils spring library convenient. It has separate APIs to encode separate segments in the URI.
Tried using the encodePath in our implementation. But there were test cases that fails after introducing this. So need to check if this breaks the current functionality. And also, to fix some of them will need to change the dispatching logic as well which needs to be done carefully.
A draft PR was sent for changing the library: https://github.com/ballerina-platform/module-ballerina-http/pull/1490


 It extends BasicObject. BasicObject.describe is defined by RSpec.
This pull-request removes the monkey patch.
This pull-request changes the following things.

Add disable_monkey_patching! configuration to the spec_helper.rb
Replace top level describe with RSpec.describe
Refactor formatter specs

beforemodule RuboCop
  module Formatter
    describe BaseFormatter do
      # ...

afterRSpec.describe RuboCop::Formatter::BaseFormatter do
  # ...

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

👍


Created CONTRIBUTORS.md

This is auto-generated from our GitHub commit history, and each user's GitHub user profile. If you want your name spelled differently (e.g. not "?") let me know.

Ah, looks like you need to add it to the MANIFEST.in file.

Also, does this have a script we can check in as well?  so we can update it with releases or something?

Yeah, where is a good place to add the script?

How about we add a maintainers folder with that script in it?  we can put other automation there if need be.

On Apr 16, 2020, at 5:38 PM, Joshua Minor<EMAIL_ADDRESS>wrote:
Yeah, where is a good place to add the script?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/685#issuecomment-614969668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAO4WJLTBKVOFVDPBMZG3DRM6QJZANCNFSM4MKCGM7A.

Codecov Report

Merging #685 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   81.70%   81.70%
=======================================
  Files          72       72
  Lines        2728     2728
=======================================
  Hits         2229     2229
  Misses        499      499

Flag
Coverage Δ

#py27
81.70% <ø> (?)

#py36
?

#py37
?

Impacted Files
Coverage Δ

...ntimelineio/opentimelineio-bindings/otio_utils.cpp
87.05% <0.00%> (ø)

...elineio/opentimelineio-bindings/otio_anyVector.cpp
100.00% <0.00%> (ø)

...eio/opentimelineio-bindings/otio_anyDictionary.cpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89badc7...31bced2. Read the comment docs.


How to use multipass

Does anyone know to use multipass with this docker ?
Thx

multistage ?
What are you trying to do with multistage ?

sorry I mean I want to do 2-pass  :
ffmpeg -i  -c:v libx264 -b:v 1M -pass 1 -f mp4 /dev/null
ffmpeg -i  -c:v libx264 -b:v 1M -pass 2 .mp4
how to do it ? thx

That seems correct what issue do you have ?  can you paste the command with docker. I can help support on the image integration not really ffmpeg

srry for late reply ,
I can't do this :
$ docker run  jrottenberg/ffmpeg -i < input > -c:v libx264 -b:v 1M -pass 1 -f mp4 /dev/null
$ docker run  jrottenberg/ffmpeg  -i < input > -c:v libx264 -b:v 1M -pass 2 < output >.mp4
since it become 2 different container

For this method you would also need to add -passlogfile /var/tmp/<prefix>  to both commands.
This will persist the log files for sharing between the executions

Thx ,
I end up with
--entrypoint "/bin/bash" jrottenberg/ffmpeg -c "ffmpeg ... ffmpeg ... "


Remove also if no zone

@jonmv please review
This logic simplification broke tests. I think that is wrong but not important enough that I want to track it down.

Yes!


Fix logrotate, add travis

Fixes #9
Add .github folder

There are some problems using Ansible 2.4.x.x (Travis said) :)

Maybe, but the Travis push test has passed with Ansible 2.4.x.x, so it looks like it's a Travis thing

They weren't Ansible's problems, were Travis'. Fixed, anyway.


Enhancement: Implement tar source plugin

In GitLab by @jonathanmaw on Apr 10, 2017, 12:58
From https://wiki.gnome.org/Projects/BuildStream/Roadmap/SourcePlugins
Tarball Source
This should simply use host wget to obtain and cache tarballs in the local users source directory.
The source should make a sha256 sum of the downloaded tarball in the track() method, so that users need not list the checksums themselves.
The source should be able to detect and extract the tarball by itself, regardless of compression types, using host tar.
If it is not good enough to derive what compression format from the file extension, then a configuration option for the source can be added for the tarball Source so a user can explicitly say this tarball is bzip2.
A source plugin needs to implement:

configure
preflight
get_unique_key
get_consistency
get_ref
set_ref
track
fetch
stage

In GitLab by @jonathanmaw on Apr 10, 2017, 13:39
Following discussion on #buildstream (https://irclogs.baserock.org/buildstream/latest.log.html#t2017-04-10T13:32:40), authentication over http will be skipped for now.

In GitLab by @jonathanmaw on Apr 10, 2017, 13:42
Discussion also led to the clarification that where possible, builtins from the python standard library can be used to replace shelling out (i.e. urllib replacing wget, and tarfile replacing tar)

In GitLab by @jonathanmaw on Apr 11, 2017, 14:03
I have a WIP branch at https://gitlab.com/jonathanmaw/buildstream/tree/jonathan/tar-source, and am currently investigating what test cases I ought to cover.

In GitLab by @jonathanmaw on Apr 12, 2017, 12:18
A merge request has been created at https://gitlab.com/BuildStream/buildstream/merge_requests/18

In GitLab by @tristanvb on Apr 13, 2017, 10:46
This is merged !
We now have tarball support.

In GitLab by @tristanvb on Apr 13, 2017, 10:46
closed


Use random default port instead of a fix one

Before submitting

[y] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[y] Did you read the contributor guideline?
[y] Did you make sure to update the docs?
[n] Did you write any new necessary tests?

What does this PR do?
Fixes https://github.com/williamFalcon/pytorch-lightning/issues/485.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

actually, this won’t work.
All processes need the same port. making the port random will break ddp

so what about random port which will be the save over the package?

how? ddp starts a process independently for each GPU, and you can’t guarantee the same number.

You would have to set it in init, but I need to have look at it in detail...

can’t set in init because the processes all run at different times without guarantee of the same start time

How about hashing the python cmd args to a get a fix random number for all processes as a workaround?

well if you set numpy.random.seed(42)then all random numbers are the same, it is commonly used for tests with random matrixes to have every time/run the same random numbers...

random seed is standard for anything ML. that doesn’t solve the problem though.  hashing the command might be a good option


trying to render emojis causes system freeze

hard to provide a reproducer as I've modified stuff in different places. also it would be bordering on distributing malware. any suggestions how to debug a system freeze?

It's very hard to diagnose. Can you say more about what you're running it on?
I do have one place I'm seeing GPU timeouts, which is #139. I started digging into it but have put it on the back burner for now.

so made sure that the thing panics before rendering to avoid system freezes. seems like the problem is that the glyph only provides a bitmap and no outlines which isn't handled and then causes a ctx.fill_glyph without a glyph being encoded. Letting make_path return None doesn't render the emoji, but it prevents a freeze.
next question would be, how to go about rendering the bitmap?

There is FillImage support in the shaders, but the CPU-side support for it is currently missing. I will add it, but no guarantees when.

Since this issue was opened, we've migrated to wgpu (in https://github.com/linebender/vello/pull/193)
I think things are likely to be different enough since then, and since no reproduction was reached, I'm going to close this out.


Created Jira guide

NOTE:

Please fill out the template below

Did you read the instructions in the README?

Y

Have you read the instructions in CONTRIBUTING?

Y

Have you written this article by yourself? Have you taken inspiration from anywhere and then written it in your words?

Written in own words, information gathered from the Jira website which is linked to within the article for further information.

In response to issue #197

Merging it :+1:


Incorrect link in docs

A link in Chapter 2 of the docs points to Chapter 2 rather than Chapter 3, as intended.
Search for "Chapter 3. Lexical Analysis (Tokenization)" on this page: https://esprima.readthedocs.io/en/latest/syntactic-analysis.html
PR incoming 👍

This has been resolved. Thank you!


docstring fix or anim_translate + change when from and to are given

PR Checklist
If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

[x] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
[x] Did I make sure to only change the part of the file where I introduced a new change/feature?
[x] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
[x] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
[x] Did I properly add test dependencies to the test directory (if applicable)?
[x] Did I check relevant tutorials that may be affected by changes in this PR?
[x] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #367
How did you address these issues with this PR? What methods did you use?
anim_translate was broken and this is one possible fix.
It was broken in the sense that we mentioned in the docstring that we move to a specific position but actually we move by a vector/into a direction.
Additionally I've updated the behavior when from and to are both given such that it assumes we are already at from because at that stage it is unknown where we are... Previously it assumed we are at the origin but this should be clearer now.

Also ran the test suite and am still running into the VideoIO error for mp4 on my end here:
Dancing circles (mp4): Test Failed at /home/src/Projects/javis/test/animations.jl:88
  Expression: isapprox(VideoIO.get_duration("dancing.mp4"), 30.0, atol = 0.1)
   Evaluated: isapprox(28.0, 30.0; atol = 0.1)
Stacktrace:
 [1] macro expansion
   @ /home/src/Projects/javis/test/animations.jl:88 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl
:1151 [inlined]
 [3] top-level scope
   @ /home/src/Projects/javis/test/animations.jl:64

If you can clarify that part of anim_translate as I mentioned earlier, feel free to merge. Thanks!

Also ran the test suite and am still running into the VideoIO error for mp4 on my end here:
Dancing circles (mp4): Test Failed at /home/src/Projects/javis/test/animations.jl:88
  Expression: isapprox(VideoIO.get_duration("dancing.mp4"), 30.0, atol = 0.1)
   Evaluated: isapprox(28.0, 30.0; atol = 0.1)

That is expected as it is another PR #368


default_root_path vs default_root_dir

I noticed that the argument to Trainer is default_root_dir, but the docs sometimes show default_root_path. I did a grep on the codebase for default_root_path, and here are the results:
./notebooks/05-trainer-flags-overview.ipynb:2155:    "trainer = pl.Trainer(default_root_path=os.getcwd())\n",
./pytorch_lightning/trainer/properties.py:51:    default_root_path: str
./docs/source/trainer.rst:618:    trainer = Trainer(default_root_path=os.getcwd())

I'm fairly convinced it's simply a documentation issue, but it requires some code changes (the 2nd line), and I'm not sure whether that will affect anything.

It should be fine. Can you open a PR?


[FR] Make search field active

Would it be possible to make all search fields active so you can immediately begin typing instead of having to click it first?

Yes, there is already a way! Change the search box mode to "autoselected" through the sidebuttons in the GUI.


NVME path support for deepspeed

PR to add NVme path support for offloading Stage 3 (optimizer & parameter)
Issue: https://github.com/huggingface/accelerate/issues/1463
[Draft mode until tests are added]
@sgugger

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@pacman100


Default-explorer-setting won't turn off.

Description
Hello there,
the app is very cool and I really liked it so far. It just takes a little long to start.
Now I had activated the experimental function "Use as standard explorer". However, this can no longer be deactivated and so I can no longer use my old, normal Windows Explorer.
Please help quickly!
LG
Steps To Reproduce

Activate "Use as Default-Explorer"
Try to disable it.

Expected behavior
The function should turn off and i can use the Windows-Explorer via "Win + E" and in the Taskbar normally.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.19044.1415
Windows Version
Windows 10 21H2 19044.1415
Relevant Assets/Logs

Hi to restore classis Explorer, download this zip and run "UnsetFilesAsDefault.reg".

Hi,
thank you so much! It worked for me.
Greetings from Germany,
Jonas

From: Marco Gavelli @.>
Sent: Saturday, December 18, 2021 8:59:04 PM
To: files-community/Files @.>
Cc: T-electroJo @.>; Author @.>
Subject: Re: [files-community/Files] Default-explorer-setting won't turn off. (Issue #7317)
Hi to restore classis Explorer, download this ziphttps://raw.githubusercontent.com/files-community/files-community.github.io/main/data/SetFilesAsDefault.zip and run "UnsetFilesAsDefault.reg".
—
Reply to this email directly, view it on GitHubhttps://github.com/files-community/Files/issues/7317#issuecomment-997277294, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW7DSJRZCMMZRRHPEDRYRP3URTRYRANCNFSM5KK7NTTA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>


Chore: Updated Bigtable 'Create' samples to use the new format

@saranshdhingra we need to update the tests to use runFunctionSnippet but otherwise these all look great!


chefdk 0.3.6

Not sure if we need to do anything else
cc @opscode/client-engineers

:+1: LGTM, also Berks maintainers had a look and gave a :+1:


Refactor orchestration phase 1.1.1

Changes proposed in this pull request:

remove Sets&Maps referred from guava

Pull Request Test Coverage Report for Build 2055

7 of 9 (77.78%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 59.107%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java
1
3
33.33%

Totals

Change from base Build 1037:
0.08%

Covered Lines:
12114

Relevant Lines:
20495

💛  - Coveralls

Codecov Report

Merging #4687 into master will increase coverage by <.01%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #4687      +/-   ##
============================================
+ Coverage     55.48%   55.48%   +<.01%
  Complexity      426      426
============================================
  Files          1134     1135       +1
  Lines         20492    20495       +3
  Branches       3799     3799
============================================
+ Hits          11369    11372       +3
  Misses         8409     8409
  Partials        714      714

Impacted Files
Coverage Δ
Complexity Δ

.../orchestration/center/instance/ApolloInstance.java
59.45% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ngsphere/orchestration/internal/util/MapUtils.java
100% <100%> (ø)
0 <0> (?)

.../registry/config/service/ConfigurationService.java
76% <100%> (ø)
0 <0> (ø)
:arrow_down:

...egistry/config/listener/SchemaChangedListener.java
71.42% <33.33%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcd9b4...d2710b0. Read the comment docs.


[4.0] [Constraint system] Improve SE-0110 exception by allowing optional in…

…jection.
There was an oversight in the exception that was added to SE-0110 to
maintain compatibility for closure arguments. We were not allowing
optional injection to happen for the closure being passed in, so things
like:
  func test(_ fn: ((Int, Int))->()) {}
  test { x, y in }

worked, but
  func test(_ fn: (((Int, Int))->())?) {}
  test { x, y in }

did not.
Fixes SR-5433 (rdar://problem/33239714).
(cherry picked from commit 8605b29951cf27c36c1bb26b548efe1c754e9927)

@swift-ci Please test

@swift-ci Please test source compatibility


Want to add PhoneHub - Sell/Buy Phone Website Issue No. - #1277

🛠 Issue (Number)
Want to add PhoneHub - Sell/Buy Phone Website Issue No. - #1277
Closes #1277
Description
Want to add PhoneHub - Sell/Buy Phone Website made with CSS, tailwind, html, js
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Hi !!
Is it merged should I close this PR.

Pls merge this repo

Make it responsive and make fresh PR


[3677] Add cohort filter

Context
https://trello.com/c/KwLaruTJ/3909-cohort-filter-front-end-basic-implementation
Changes proposed in this pull request

Add basic three checkbox filter on draft and registered trainees
Only show cohort options that are relevant for that provider's trainees
Don’t show filter if provider has one cohort
Auto-select ‘current’ when linking through to drafts/registered trainees.. but clear if you press ‘clear filters’

Guidance to review

Pick a provider with no Apply drafts
Check that there is no cohort filter
Pick a provider with Apply drafts
Check that there is a cohort filter and that this works
Click the 'Draft' and 'Registered' tabs (and links from the homepage)
Check that the default is that 'current' cohort is applied

Important business
~* Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?`~
~* Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?~

 Cohort filter front end - basic implementation


Extend to user-provided data

Hi @NickCrews, after encountering similar frustrations with libpostal and using spacy for other NLP tasks, I'm very interested by this repo.
I have a lot of proprietary address data from different countries that I would like to use to train NER models using this repo as a framework.
Are there any plans to extend this to facilitate the training of address parsers using non-US and/or non-english language addresses?
For testing, I think I should be able to do this by creating the appropriate datasets in train.nerf and dev.nerf, but I expect there are some other parts that may need modifying.
Happy to help contribute to this if needed!

Hey @jstammers, sorry this fell through the cracks and I'm not responding until now.
I don't really want to become responsible for maintaining the extra data. I am fine maintaining the actual code and scripts on a best-effort basis, as I'm doing here. I would be willing to make minor adjustments to the code/scripts here so that you/3rd parties can pull in their own data and config.cfg but use these scripts. Would that work? I think you can do this currently, just by modifying the existing justfile recipe as a seprate bash script:
python nerf.py yourdata/train.nerf yourdata/train.spacy
python nerf.py yourdata/dev.nerf yourdata/dev.spacy
mkdir -p models/yourmodel/training
python -m spacy train models/yourmodel/config.cfg --output models/yourmodel/training --paths.train ./yourdata/train.spacy --paths.dev ./yourdata/dev.spacy  --gpu-id {{gpu}}

If there are changes that would make this easier, I'm down to here.
Honestly, if I were you, I might just copy this whole repo, start from there, and never worry about pulling in new changes. It might just be easier for you if you had a totally separate branch that you have complete control over.


Gutter Marks question

I like gutter marks but the bright green strip is rather jarring in my dark theme.  Is it possible to change that by changing one of the LESS or CSS files?  If you can point me in the right direction I am happy to play with the colors to find something that works with my theme.

You're probably looking for this: https://github.com/zaggino/brackets-git/blob/master/styles/commit-diff.less#L101-L108

Awesome!  Thanks for the pointer.  New to Brackets but very much like your plugin for interacting with Git.


videosN1 support

Multi-page instructions (the introduction field in settings.json in the experiment can a string or a list so shouldn't break existing experiments)
Added support for videos (N1 only)

need a play: "watch video or whatever" field in wording.run.json

Changed code in jsPsych's plugin-video-keyboard-response.js

Added parameters:

play_key: str define which key to press to start video
change_prompt: bool change style of prompt once video ends to indicate participant can respond

added EventListener to allow starting video with keyboard

Have tested with
"kind": "video",
"nInterval": 1,
"fileExtension": "mp4",

& worked ok.
Suggestions:

mention the "kind": "video" tag, supported video extensions (tried ".mp4", worked)
create a video_int1, video_int2 example (with short videos so they're not too big)
note reaction time logged in result appears to include the video duration (which is ok, but should be documented somewhere)

What's "N1" by the way ?

1-interval. In the functions they're written as imagesN1 and imagesN2, for example. It is admittedly not particularly clear.


Arrangement and execution of the meeting for presentation of practical usage of base_setup method (issue #1063 related)

The goal is to arrange and execute the meeting for presentation of practical usage of base_setup method. The following things should be prepared:

[x] scope and schedule of meeting (in one week);

[x] conducting team (in two weeks);

[x] guide or instructions with examples (one week before meeting);

[x] announcement (in Slack and Teams channel) with basic information (conducting persons, date,scope,schedule) (one week before meeting);

[x] exemplary code in Jupyter (link) (one week before meeting).

Meeting has been executed.


formulate nanopublication that disputes a claim in existing publication (e.g. Page 2023)

For sake of exercise, I was hoping to figure out a way to dispute a claim in a recent publication:
Page R (2023) Ten years and a million links: building a global taxonomic library connecting persistent identifiers for names, publications and people. Biodiversity Data Journal 11: e107914. https://doi.org/10.3897/BDJ.11.e107914
with the claim being (emphasis mine)

[...] For each database, a new entry was created in ChecklistBank. A data release in the Catalogue of Life Data Package (CoLDP) format (Döring and Ower 2019) was created and uploaded to Zenodo where it received a DOI. The same data are then uploaded to ChecklistBank. [...]

For additional context, see attached screenshot.

see also https://github.com/bio-guoda/preston/issues/259

I'd like to find a way to structure a nanopublication to say the following:
In a version of content associated with https://doi.org/10.3897/BDJ.11.e107914, the author makes the claim that:
"For each database, a new entry was created in ChecklistBank. A data release in the Catalogue of Life Data Package (CoLDP) format (Döring and Ower 2019) was created and uploaded to Zenodo where it received a DOI. The same data are then uploaded to ChecklistBank."
To verify this claim for the IPNI database (table 2. second row), I found that:
A data release for IPNI was associated with https://doi.org/10.5281/zenodo.7208699, checklist bank id 164203, and github repository https://github.com/rdmpage/ipni-coldp .
In order to verify the author claim, I made the following (machine readable) assumptions:
<https://doi.org/10.5281/zenodo.7208699> <http://www.w3.org/ns/prov#hadMember> <https://zenodo.org/record/7974720> .

<https://zenodo.org/record/7974720> <http://www.w3.org/ns/prov#hadMember> <https://zenodo.org/record/7974720/files/rdmpage/ipni-coldp-2023-05-26.zip> .

<https://checklistbank.org/dataset/164203> <http://www.w3.org/ns/prov#hadMember> <https://api.checklistbank.org/dataset/164203/archive.zip> .

Following, the content was retrieved and associated content ids were calculated.
<https://zenodo.org/record/7974720/files/rdmpage/ipni-coldp-2023-05-26.zip> <http://purl.org/pav/hasVersion> <hash://md5/759e54ff69803f9759ca4464b7a5d4bd> .

<https://api.checklistbank.org/dataset/164203/archive.zip> <http://purl.org/pav/hasVersion> <hash://md5/57a32540fa4db2fefdf461bc6b353e68> .

Note that hash://md5/759e54ff69803f9759ca4464b7a5d4bd is not the same as hash://md5/57a32540fa4db2fefdf461bc6b353e68 .
Note, however, that some of the entries in the respective zip archives did appear to contain the same content. However, the archives were not the same.
Suggest to alter text:
"[...] The same data are then uploaded to ChecklistBank. [...]"
to something along the lines of:
"[...] An copy of this data was then slightly altered and then uploaded to ChecklistBank. [...]"
Thank you for considering my observations and suggestion.
Note if the provenance of the data was cited/provided in machine readable form.

@tkuhn - how would you recommend to go about making a claim such as above in the form of a nanopublication?

Interesting case!
I think the first question is: how can this be represented in RDF? (or some other type of logic) That's independent of nanopublications.
It seems to me that quite some modeling effort is required for this. There might be existing vocabularies, but I am not aware of any that would cover this.
We'd need statements like these:
:va a x:VerificationAttempt .
:va x:target :claim .
:claim x:expressedIn :text .
:text oa:exact "The same data are then uploaded to ChecklistBank." .
:text x:partOf <https://doi.org/10.3897/BDJ.11.e107914> .
:claim x:hasInterpretation :i .
:i x:by <https://github.com/jhpoelen> .
:i {
   <https://doi.org/10.5281/zenodo.7208699> <http://www.w3.org/ns/prov#hadMember> <https://zenodo.org/record/7974720> .
   <https://zenodo.org/record/7974720> <http://www.w3.org/ns/prov#hadMember> <https://zenodo.org/record/7974720/files/rdmpage/ipni-coldp-2023-05-26.zip> .
   <https://checklistbank.org/dataset/164203> <http://www.w3.org/ns/prov#hadMember> <https://api.checklistbank.org/dataset/164203/archive.zip> .
}
...

This is just some unfinishd sketch from the top of my mind on how this could be modeled. But once we have such a more solid representation in RDF, it's then relatively straightforward to package these in nanopublications.
I hope that answer makes sense?

@tkuhn thanks for your rdf draft of a comment that refutes / questions a claim. I imagine that refuting a claim is a common annotation. Please do share any related examples as I am scraping up the courage to speak clearly articulated, well-formed rdf ; )

Now, I wonder - who'd be interested in this kind of nanopublication. Are there any plans to feed these kind of structure statements into a "letter to the editor" or "request revision" workflow?

Nevertheless, I do feel the urge to present my example in some kind of structured form.
I noticed that you collaborator Michel Dumontier wrote on the "Semanticscience Integrated Ontology (SIO)" .
Do you @tkuhn , or @micheldumontier, think SIO would be a good pick to help describe the refutation of a statement made in a published paper (like the one presented above)?
Dumontier, M., Baker, C.J., Baran, J. et al. The Semanticscience Integrated Ontology (SIO) for biomedical research and knowledge discovery. J Biomed Semant 5, 14 (2014). https://doi.org/10.1186/2041-1480-5-14

I am not aware of anything in SIO that would be directly covering this. There seems to be 'is refuted by' as a type of (document-to-document) reference. Similarly, you have 'refutes' in CiTO. That gives you a way to point to something that you'd like to refute, but doesn't really cover the modeling of the content and reason of the refutation.

there is some support for argumentation .e.g references / cites / is supported by / is disputed by / is refuted by
http://semanticscience.org/resource/SIO_000772
SIO might represent this as:
:statement a sio:Statement.
:statement sio:hasValue "The same data are then uploaded to ChecklistBank." .
:statement sio:isPartOf https://doi.org/10.3897/BDJ.11.e107914 .
:statement sio:isDisputedBy :claim .
:claim sio:hasCreator https://github.com/jhpoelen .
:claim sio:hasValue "The data at BioDiversity Journal and ChecklistBank are not the same as evidenced by a different md5 hash of the respective files" .
:claim sio:hasEvidence :evidence ;
:evidence {
https://zenodo.org/record/7974720/files/rdmpage/ipni-coldp-2023-05-26.zip
sio:hasAttribute hash://md5/759e54ff69803f9759ca4464b7a5d4bd .
https://api.checklistbank.org/dataset/164203/archive.zip sio:hasAttribute <hash://md5/57a32540fa4db2fefdf461bc6b353e68 >
}
i was a bit lazy on the evidence part. honestly, we would instead use some kind of object (e.g. :Comparison/) with two inputs and one output ("not equal")
i'd be happy to further develop if needed.
m.


Fix case sensitivity in POST input for services

Fix case sensitivity in POST input for services, case with two input  properties with the same jsonname , and differente casing.
Issue 107486

Temporarily close it until the failing unit test is resolved


Something goes wrong with memory and CASE sessions

Problem
Steps to reproduce:

Pull ToT (rev 34bccf5d90edd8c1c465f59c565cd13a0b058d62 for me right now).
Build all-clusters-app for m5stack:% cd examples/all-clusters-app/esp32
% source idf.sh
% idf make erase_flash flash monitor -j16 ESPPORT=/dev/tty.SLAB_USBtoUART

In another terminal:% ./gn_build.sh
% ./out/debug/standalone/chip-tool pairing ble-wifi SSID PASSWD 0 12345678 3840
% ./out/debug/standalone/chip-tool onoff toggle 1
% ./out/debug/standalone/chip-tool onoff toggle 1
% ./out/debug/standalone/chip-tool onoff toggle 1
% ./out/debug/standalone/chip-tool onoff toggle 1

I see a bunch of asserts/crashes/backtraces on the m5stack.  See attached log, search for "backtrace".  They generally seem to be happening during heap operations from crypto code.
Proposed Solution
Figure out what's going on (are we running out of heap?) and fix it.
@pan-apple
log.txt

It seems we are running out of heap on ESP32 platform. Likely a memory leak somewhere.
    /* Note: this check must be done while holding the lock as both
       malloc & realloc may temporarily shrink the free_bytes value
       before they split a large block. This can result in false negatives,
       especially if the heap is unfragmented.
    */
    if (heap->free_bytes < size) {
        MULTI_HEAP_UNLOCK(heap->lock);
        return NULL;
    }

I just realized all-clusters-app actually logs its free heap amounts.

Yes, haven't hit this in a while.


Clicking on Show render code for the  component gives an error

Version
6.0.0-beta.15
Browser and OS info
Chrome: Version 91.0.4472.124 (64-bit) / Windows 10
Steps to reproduce
Open Vue DevTools, select a <transition> element in the Component-tree, then click the show render code option
What is expected?
The render code should be displayed
What is actually happening?
We get this error:
An error occured in hook getComponentRenderCode
callHandlers @ backend.js:582
callHook @ backend.js:184
getComponentRenderCode @ backend.js:310
(anonymous) @ backend.js:1632
emit @ backend.js:6734
_emit @ backend.js:5156
(anonymous) @ backend.js:5088
(anonymous) @ backend.js:5088
listener @ backend.js:7731
postMessage (async)
n @ proxy.js:1
13:14:39.242 backend.js:583 TypeError: Cannot read property 'toString' of null
    at backend.js:4926
    at DevtoolsHookable.callHandlers (backend.js:579)
    at DevtoolsApi.callHook (backend.js:184)
    at DevtoolsApi.getComponentRenderCode (backend.js:310)
    at Bridge.<anonymous> (backend.js:1632)
    at Bridge.emit (backend.js:6734)
    at Bridge._emit (backend.js:5156)
    at backend.js:5088
    at Array.forEach (<anonymous>)
    at backend.js:5088

Transition is an instance of class FunctionalComponent in vue3.x, in other words it is a functional component without render code. I would like to create a PR to resolve it.


[MXNET-703] Remove unused TensorRT code

Removing some python code that isn't in the current TensorRT execution paths.
This should make the code more readable and avoid potential linting errors.
Thanks to @vandanavk for pointing out the dead code and @cclauss for a quick
alternative fix.
Co-authored-by: Vandana Kannan<EMAIL_ADDRESS>Co-authored-by: cclauss<EMAIL_ADDRESS>Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

As discussed off-line, hope it's ok if we remove this code @mkolod.  We've got it in git history if needed.
@cclauss @vandanavk Hope it's ok add you as co-authors on this, since you did most of the work here.  LMK if you object.


Responsive Design

Description: Verify the website's responsive design on a desktop browser (Chrome, latest version).
Preconditions: The website https://oportunitatisicariere.ro/ is live and accessible.

Step 1 : Open Chrome on a desktop
Expected Result: The website layout should adjust appropriately at different screen widths without breaking.

Step 2 : Resize the browser window to various widths (e.g., 1920px, 1366px, 768px, 375px).
Expected Result: The website layout should adjust appropriately at different screen widths without

Step 3 :	Observe the layout and content adjustments
Expected Result: The website layout should adjust appropriately at different screen widths without breaking.


Added files are not filtered out

When adding files while in dev mode, they do not get filtered out through the watcher

I ran in to a bug while creating a new route for example test/[testid] but I wanted it to be test/[testId] with a capital i. After renaming the file it created two routes and while in dev capital i worked but when building it did not. Had to rename it to [testid]
Is it related to this issue or should I open a new one?

Related


Adding Command Line support

To Fix #10 - Have Added CLI support.  If you issue the command is-windows the CLI returns true / false.
Developed this on a mac  - tested as best I can - but can someone please confirm on windows?

Hi @jonschlinkert  - have you had time to take a look at this PR?  thanks

So a package that is used over 2 million times is not even responding to a PR after almost a full year has passed? To me, that shows the stupidity of this package.

@i3anaan I usually don't respond to trolls, but I will make an exception.
Let's zoom out and look at this from a different angle. How about a simple question:
Why would someone create such a library such as this?
Well, thank you for asking. I'm glad you didn't make any assumptions. The answer is simple: some of our users created bug reports to notify us that their OS wasn't correctly identified. Namely, when using msys and cygwin. Given that:

I don't use either
I only use Windows for testing
I have created dozens of CLI libraries and we have millions of users, I didn't want to repeat this one line of code manually, over and over again.

Now that we got that out of the way.
Closing the PR and blocking @computamike since this is obviously an attempt at trolling. Unfortunately, I'm also blocking @i3anaan for the hostility.

@computamike if I misunderstood, and this was a serious PR, then I apologize, and please contact me at my email address on my profile and I'll get you unblocked.


MMFR

When running prepare_mm_representations.py, a large number of warnings are received during the import of CLIP weights, for example: UserWarning: for vision_model.post_layernorm.bias: copying from a non-meta parameter in the checkpoint to a meta parameter in the current model, which is a no-op. (Did you mean to pass assign=True to assign items in the state dictionary to their corresponding key in the module instead of copying them in place?)
warnings.warn(f'for {key}: copying from a non-meta parameter in the checkpoint to a meta', is this normal, and will it affect the results?

Hi. This warning is normal, which refers to the initialization and transition of parameters between 'cuda' and 'meta' device. It will not affect the result, because all parameters are provided in the checkpoint. For more information, please refer to the official documentations of PyTorch for 'meta' device.

Thank you very much for your answer. Have you considered releasing the code for creating the fine-tuning dataset for LLaVA?


WIP: Primer on bayesian inference

This PR attempts to explain Bayesian inference in a language that is accessible by people familiar with:

Basic probability theory, and
Basic machine learning, e.g. linear regression or clustering.

The goal is to turn it into a complete guide for practitioners who would like to use Turing including debugging and diagnosis techniques. This was originally part of #940 . Some additional points to include in this primer in the future, perhaps by others here who are more expert in MCMC, include:

The advantages and disadvantages of each MCMC algorithm including the intuitive role of each parameter,
When model re-parameterization is useful and why,
MCMC result diagnosis techniques, and
Some case studies discussing all the above.

I'm closing this for now. I'll open a new PR later.


Extract operation response parser

Introduce OperationResponseParser responsible for parsing response from buffered source.
Can be used in tests with mocked raw response string.
Closes #653

@digitalbuddha yes we should definitely think about this API, but for now this PR just refactors internal parsing logic and as a side effect of this it can be used in tests. So I would leave it for now as is and the next step to provide test support on ApolloClient level itself with API you proposed. And we have for this a ticket already https://github.com/apollographql/apollo-android/issues/430 created by you


Add admin oc apply for geneva actions

geneva side: https://msazure.visualstudio.com/One/_git/Compute-ARO-GenevaActions/pullrequest/2788499?_a=overview

thanks for the additional :eyes: , will merge on green


Of 1042 merge to staging

connected-spaces-platform Pull Request
For the reviewer

[ ] If required, are the changes covered by appropriate tests?
[ ] Are any public-facing API changes well documented?
[ ] Is the code easily readable and extensible and/or follow existing conventions?

Closed as wrong process followed.


Is this project still in development?

Hello, I wish to use this project for my game which needs fast scripting,
However my game will run on .NET Core and this is a .NET Framework app, I also wish to port it to other .NET Standard platforms, so it would be nice for this library to run on .NET Standard.
Also, it would be nice (not necessary) for there to be an option to use Reflection.Emit to speed up run times.

Hi @hamarb123!
I've updated this project's source code and the accompanying Wasm NuGet package to target .NET Standard 2.0 in addition to .NET 4.7. Does that work for you, or would it be helpful if I tried targeting an earlier version of .NET Standard for compat reasons?
Good point about having a Reflection.Emit back-end. cs-wasm doesn't have one at the moment. I'd like to implement one in the future. I might have to implement a WebAssembly text format parser first to get better test coverage before I start building a Reflection.Emit back-end.
Anyway, thanks a bunch for your interest in cs-wasm! I'd love to hear more about how you plan to use it to implement scripting and why you're so interested in WebAssembly/cs-wasm in particular.

Yes, NET Standard 2.0 is old enough.
I look forward to a Reflection.Emit back-end back-end option, let me know when it is ready.
I plan to implement scripting with WebAssembly by loading the file from a memory stream, and then when a function needs to be called, finding a function with the predetermined name (which has been exported) and calling it. The reason I chose WebAssembly specifically is that I think it is useful to be able to compile from basically any programming language, I chose cs-wasm as it is one of the only 2 options in C# (that I could find) to load a WebAssembly file and be able to execute it, but I could not work out how to get the other project to execute it and I was originally going to use Jint, but it would have been to slow.

Cool! Do let me know if you run into any cs-wasm-related issues; I'm happy to help.

Hi, won't using Reflection.Emit exclude strictly-AoT platform, e.g. iOS? see https://github.com/jonathanvdc/cs-wasm/issues/4 for context. If said use case is applicable, will a backend selection be afforded?


Add ability to specify chart generation url for self hosted QuickChart

Thank you!

Could you please deploy a new version of the nuget package, including this work? Thanks

Released in 2.3.0 :)

Thank you !
From: Ian Webster @.>
Sent: 15 March 2022 06:23
To: typpo/quickchart-csharp @.>
Cc: Diana Duca @.>; Author @.>
Subject: Re: [typpo/quickchart-csharp] Add ability to specify chart generation url for self hosted QuickChart (PR #5)
Released in 2.3.0 :)
—
Reply to this email directly, view it on GitHubhttps://github.com/typpo/quickchart-csharp/pull/5#issuecomment-1067608086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWNRJF474CXGMJJZYFRW4CLVAAUE5ANCNFSM5QQF3BIA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

***** E-mail confidentiality notice *****
[Law Business Research]https://lbresearch.com/
Law Business Researchhttps://lbresearch.com is the trading name of Law Business Research Ltd and its subsidiaries.
This message is intended for the addressee only. It is private and confidential. If you have received this message in error, please notify @.*** and remove it from your system.
Law Business Research Ltd. Registered company in England & Wales. No. 03281866. Registered Office address: Meridian House, 34-35 Farringdon Street, London, EC4A 4HL


Subscriptions actions unclear

in the readme subscriptions is listed as a context but no actions are given
The is an action under azure account, list  List subscriptions for the logged in user.
Confusing

I think we'll just remove the readme and point to the official docs.

Closing as obsolete.


DNN-7483: reset app start elapse time after install site complete, set the write lock file exception logged in Debug level.

This change should remove unnecessary write.lock errors during startup / installation.


Accuracy :: Not so good

Check for this image :: https://ecs7.tokopedia.net/img/cache/200-square/product-1/2018/11/16/44005912/44005912_38d3d852-4b67-4ef0-9e7a-d4006bf07202_700_700.jpg
The results for this are, i am mentioning only the relevant output classes -->
[Sweater, Short Sleeves, V-Shape, Graphics,None, None, Is Female, None, Wears Necktie, None ]

It is not comparable to what you mentioned in your slides


Incorrect examples

This statement could be extremely confusing to new comers as it doesn't make sense in the context in which it is used: Logger.WriteMessage += LogToConsole;
It should be: Logger.WriteMessage += Logger.LogToConsole;
Also, In general these examples are confusing and lack essential information in both description and example content.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4da25ace-6dcf-3dfa-7b98-c0b29c769e46
Version Independent ID: f6f03e15-36cb-d7ee-cb99-eee9a5ecc477
Content: Common Patterns for Delegates
Content Source: docs/csharp/delegates-patterns.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for adding this @SalFicara
We'll make sure to address this when we next update this document.
In the meantime, I've added the "up for grabs" label for any community members to address.

Actually, if you have a closer look to the full sample here, the line of code you pointed out is correct.
However I agree with you @SalFicara on the fact that the way it is explained in the article is quite confusing as we can't really understand where the LogToConsole method is located in the example program.

@BillWagner , based on the sample, it looks alright. Is this a bug or not?

@eddynaka
The previous comment is correct. The code is correct, but the explanation does not help readers find that information.

@BillWagner so should we change the code or explanation?

As the code is correct, we should rephrase the explanation only

I attempted to address this in two PRs across the docs & the samples.

I extracted to a static class called LoggingMethods so that we could show the full context of the class within the docs sample.
Updated the docs to show the new class for the contents of the LogToConsole method
Updated the docs to clearly use the static class
Added a comment to the first time we reference LoggingMethods out of context, to remind the reader it's one we created earlier.

Feedback on the overall approach welcome, but this seemed to find the sweet spot of:

Making a concept explicit
Allowing the code samples to be shown in the full context


Update ci image

Now this is fun, the linter warning makes me us something that was added only in rust 1.76 and it seems epel 9 at least is using something older.
Also the integration test are still flaky/broken with the new images https://github.com/containers/netavark/pull/1069


HA-Addon: missing machine-id mapping

Describe the bug
To use the home assistant add-on in combination with the VW Elli Wallbox, the so called machine-id file needs to be mapped into the docker container.
The add-on presently only supports the mapping of the yaml file and the sql Database but not the machine-id
Please add support for mapping of the machine-id file.
Steps to reproduce
n.A.
Configuration details
n.A.

Log details
n.A.

What type of operating system are you running?
Linux
Version
V.127

https://docs.evcc.io/docs/reference/configuration/hems/#deviceid
Did you config the device-id?

I am not using a hems.
I would need the machine-id to connect to my Elli Wallbox.

https://docs.evcc.io/docs/installation/docker#manuell
Alternatively, you can define a Machine ID under the plant key in your evcc.yaml.

Did you solve it?

yes, this particular problem is solved but the overall solution is working very, very unreliable.


Make schemaVersion public

I'm seeing errors when applying @IndexKeyRecord to a public model.
The other Macro generated properties are public so it seems like this one should be too.
Unrelated: moved swift-syntax to the new canonical repo location

Thank you so much for this!

(It's expected the tests fail right now - kinda pushing the limits at the moment)


(PUP-10477) remove non-local return from agent.rb

When agent run is done in a forked process and an error is raised,
having an explicitly return in a block ends up in hitting a
LocalJumpError.
-- Logs begin at Thu 2020-04-30 10:08:03 UTC, end at Thu 2020-04-30 10:09:20 UTC. --
Apr 30 10:08:12 formative-child systemd[1]: Started Puppet agent.
Apr 30 10:08:12 formative-child systemd[1]: Starting Puppet agent...
Apr 30 10:08:17 formative-child puppet-agent[874]: Starting Puppet client version 6.15.0
Apr 30 10:08:17 formative-child puppet-agent[1265]: Could not run Puppet configuration client: undefined local variable or method `a' for #<Puppet::Agent:0x0000000002c8aad0>
Apr 30 10:08:17 formative-child puppet[874]: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:98:in `fork': unexpected return

CLA signed by all contributors.

Looks good to me, though thinking maybe target 5.5.x?

jenkins please test this


Opening a HDF5 file that is not in 4D shape gives a confusing error message in the GUI

How to reproduce: Open a HDF5 file with 3D contents with the GUI.
Observed behavior:

The server output is more helpful:
tornado.application - ERROR - Uncaught exception PUT /api/datasets/24793536-6195-477d-8080-b04381d5c04b/ (::1)
HTTPServerRequest(protocol='http', host='localhost:9000', method='PUT', uri='/api/datasets/24793536-6195-477d-8080-b04381d5c04b/', version='HTTP/1.1', remote_ip='::1')
Traceback (most recent call last):
  File "c:\users\weber\appdata\local\conda\conda\envs\libertem\lib\site-packages\tornado\web.py", line 1699, in _execute
    result = await result
  File "c:\users\weber\documents\libertem\libertem\src\libertem\web\dataset.py", line 36, in put
    dataset_params = converter.to_python(params)
  File "c:\users\weber\documents\libertem\libertem\src\libertem\web\messages.py", line 176, in to_python
    self.validate(raw_data)
  File "c:\users\weber\documents\libertem\libertem\src\libertem\web\messages.py", line 170, in validate
    jsonschema.validate(schema=self.SCHEMA, instance=raw_data)
  File "c:\users\weber\appdata\local\conda\conda\envs\libertem\lib\site-packages\jsonschema\validators.py", line 541, in validate
    cls(schema, *args, **kwargs).validate(instance)
  File "c:\users\weber\appdata\local\conda\conda\envs\libertem\lib\site-packages\jsonschema\validators.py", line 130, in validate
    raise error
jsonschema.exceptions.ValidationError: [1, 8, 157] is too short

Failed validating 'minItems' in schema['properties']['tileshape']:
    {'items': {'type': 'number'},
     'maxItems': 4,
     'minItems': 4,
     'type': 'array'}

On instance['tileshape']:
    [1, 8, 157]

Expected behavior:
An error message that gives more information on the cause of the error, for example the text of the exception.
See also #441!

Related to #316 - this has actually multiple parts.
In case of an invalid message, the server should send some human-(and/or machine)-readable message instead of 500-crashing.
The GUI should then display this error in the correct context - in case of input-parameter related errors, the error should be displayed next to the input element.
In addition, the message can be pre-validated on the client-side, as we now have json schema definitions at least for opening datasets. Error-displaying as above also applies to this pre-validation, with some care taken regarding usability (in other words: it should not be annoying!).


After images of missiles appears sometimes

Sometimes the boosting/ missile flying sound keeps playing.

[moved from #93 -- crazy GitHub login redirect every time!]
Just some notes

Initial idea is that this has something to do with dropped data somewhere (but where!).
It seems (relatively?) unlikely to be threading issue, it is at least too consistent for that.
It seems to happen more with many bots playing.
When it happens for shield, the client JS oddly is smart enough to stop the shield animation, but not (what appears to be) the previous frame of the animation itself. That might point at an issue with the order messages are sent to the client.

On an unrelated journey, I found:
https://github.com/steamroller-airmash/airmash-server/blob/674435c931d61c2b785310d535c910ec37f74249/server/src/utils/event_handler.rs#L25-L31
I could not find where this magic '50' number comes from, however the presence of an upper limit that leads to internal queues dropping data at least sounds worth investigating further


CUPS removes job from queue but printer doesn't print

When the printer's out of paper, CUPS doesn't store the job, instead it removes it. The printer also doesn't print, since there's no paper. So is there a way to get the status code for a job or something likewise?

Hi,
what is your CUPS version? What is your printer uri?

CUPS 2.2.7
URI socket://<IP_ADDRESS>:9100

@NeuralFlux
without details I guess CUPS does not "just remove" the job.
I think CUPS can successfully submit the print job data to your printer
so that the job is "successfully printed" from CUPS's point of view and
finally CUPS removes the print job data of "successfully printed" jobs,
cf. "What is a CUPS backend and how does it work?" in
https://en.opensuse.org/SDB:CUPS_in_a_Nutshell
For details what actually happens in your particular case
inspect your CUPS log file (in debug mode), cf.
https://en.opensuse.org/SDB:How_to_Report_a_Printing_Issue
You may also have a look at
https://en.opensuse.org/SDB:Using_Your_Own_Backends_to_Print_with_CUPS
what you might do to debug this issue with your printer.

Thank you so much for helping!


Tile unfocus time is too short

Describe the bug
video tile is unfocused as soon as cursor is hovered over, defying the purpose of the extension.
To Reproduce
Steps to reproduce the behavior:

Go to youtube
Hover on any blurred video tile
video is unfocused without any delay, which may also be the result of unintended hovering

Expected behavior
Video tile must be unfocused after atleast 1-2 seconds of hovering
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows
Browser  chrome

All good, Work on this


Implement Post market creation

After the market is created redirect user to portfolio page.
Show new market in user's "My created markets" section.
Show the tx is pending
After market is confirmed show button for user to create liquidity.

Preferring #2492


Notification icon problem

Hi, in the documentation is not clear how to change the notification icon in android. In the Notification Bar I would like to see a different icon than the one in the application. Can anyone explain the procedure to do this in detail?
Thank you.

You need to specify the icon like below from the server-side script like below. For my case, I am using a PHP script.
$message = array(
                'registration_ids' => $registrationIDs,
                //'to' => $registrationIDs,

                'notification' => array(
                        "title" => $title,
                        "body" => $messageText,
                        //"click_action" => "MainActivity",  //Must be present for Android
                        "icon" => "icon",
                        "sound" => ""
                ),

                'data' => array(
                        "message" => $messageText,
                        "id" => $id
                )
        );

Ok but in my ionic application I have to configure something?

First you need generate your icons here;
Next you should add the icons generated files in /plataforms/android/res folder;
After you should add in your AndroidManifest.xml this:

<meta-data
android:name="com.google.firebase.messaging.default_notification_icon"
android:resource="@drawable/notification_icon" />

*where notification_icon is the filename of your icon.

@pablozandona Can I also set the notification icon color from my AndroidManifest.xml?

@pablozandona I followed your instructions to a tee and it did not work for me

@hkhamm

Create resources/android/values/styles.xml file with your color like this:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="red">#FF8614</color>
</resources>

After you should add in your /plataforms/android/AndroidManifest.xml another meta-data:

<meta-data android:name="com.google.firebase.messaging.default_notification_color" android:resource="@color/red"/>

@jskidd3 what exactly didn't work?

@pablozandona The icon stayed the same. It was a solid grey/white version of the app icon. I eventually managed to get it working by following the instructions found here: https://github.com/arnesson/cordova-plugin-firebase/issues/53#issuecomment-304573222

In case it helps anyone in the future, the meta-data tag goes within the application tag in the AndroidManifest.xml file. Like:
<?xml version='1.0' encoding='utf-8'?>
<manifest android:hardwareAccelerated="true" android:versionCode="1091" android:versionName="<IP_ADDRESS>" package="..." xmlns:android="http://schemas.android.com/apk/res/android">
    ...
    <application android:hardwareAccelerated="true" android:icon="@mipmap/icon" android:label="@string/app_name" android:supportsRtl="true">
        ...
        <meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@drawable/notification_icon" />
    </application>
    ...
</manifest>

does the icon needs to be in @drawable or could it be in @mipmap. @gecko-8 . Thanks

hi @gecko-8, this solution doesnt work for me, i even type the tag manually in manifest and nothing. I dont know what i could be missing

i also notice in this repo that icons are weir (for a lack of a better term). Are the icons supposed to be on some kind of special format?

Nope, just a 48x48 png. The alpha channel in the image provides the icon shape.

On Apr 19, 2018, at 3:49 PM, Lexy Feito<EMAIL_ADDRESS>wrote:
i also notice in this repo that icons are weir (for a lack of a better term). Are the icons supposed to be on some kind of special format?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

To be totally clear, if you use my above code, make sure the image is 48x48, named notification_icon.png and is located in the platforms/android/res/drawable folder. I have a step in my build script to copy the image there so if I remove the platform it gets put back. To add the above to AndroidManifest.xml I used the cordova-custom-config plugin with the following in the  tag in config.xml:
<config-file parent="./application" target="AndroidManifest.xml">
    <meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@drawable/notification_icon" />
</config-file>

In case this happens to anyone else:
@gecko-8
ionic cordoba run android was givinig me this error:

Error parsing XML: unbound prefix

I solved it by adding the android namespace at the root:
<widget android-versionCode="145" id="your.app.id" ios-CFBundleVersion="1.0" version="1.0" xmlns="http://www.w3.org/ns/widgets" **xmlns:android="http://schemas.android.com/apk/res/android"** xmlns:cdv="http://cordova.apache.org/ns/1.0">

In case it helps anyone in the future, the meta-data tag goes within the application tag in the AndroidManifest.xml file. Like:
<?xml version='1.0' encoding='utf-8'?>
<manifest android:hardwareAccelerated="true" android:versionCode="1091" android:versionName="<IP_ADDRESS>" package="..." xmlns:android="http://schemas.android.com/apk/res/android">
    ...
    <application android:hardwareAccelerated="true" android:icon="@mipmap/icon" android:label="@string/app_name" android:supportsRtl="true">
        ...
        <meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@drawable/notification_icon" />
    </application>
    ...
</manifest>

This is very useful, working for my issue in oreo+ version.

I've got this error message when building project in Android platform.

The prefix "ns1" for attribute "ns1:name" associated with an element type "meta-data" is not bound.

This is my widget
<widget id="test" version="0.0.3" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools">
And my config file tag:
<hook src="package-hooks/android_custom_resources.js" type="after_prepare" />
<hook src="package-hooks/android_custom_values.js" type="after_prepare" />
<config-file parent="./application" target="AndroidManifest.xml">
<meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@drawable/notification_icon" />
<meta-data android:name="com.google.firebase.messaging.default_notification_color" android:resource="@color/red" />
</config-file>


evoked file with aspect_kind==105 causes a KeyError

Dear mne,
a colleague gave me an evoked fiff file created with mne Matlab toolbox. When trying to load it in mne-python, the Evoked instance is created fine. However when trying to look at it, I get:
  File "C:\Users\hus20664877\projects\mne-python\mne\evoked.py", line 179, in __repr__
    s = "'%s' (%s, N=%s)" % (self.comment, _kind_swap[self.kind],

KeyError: 'unknown'

It looks like self.kind is 'unknown'. If that's not OK, It seems to me that the situation should be handled before __repr__ is invoked. Further, why is self.kind limited to average or standard deviation? This file seems to have aspect_kind set to 105, which corresponds to FIFFV_ASPECT_SAMPLE.

This is a bug, I'll see if it's easy to fix it.

why is self.kind limited to average or standard deviation

These are the only kinds produced by MNE-Python, and (apparently) the only ones people have tried to read with MNE-Python so far. But we might as well add the remaining ones to the list:
https://github.com/mne-tools/fiff-constants/blob/a3feddb3011335586d50bc40d1c4e36cea20913f/DictionaryTypes.txt#L347-L360


Fix failing tests due to modifications to imperatives

With the recent addition of "initiate" to the list of imperatives,
both "initialize" and "initiate" stem to the same verb - "initi"
which causes an error since we use Initialize in our docs and due
to the way the imperative suggestion logic is implemented.
Since initiate occurs later in the file - when constructing a
dictionary - it trumps initialize and replaces it.
This patch fixes it by changing the dictionary to a list of verbs
instead of a single stem-verb map.
Thanks for submitting a PR!
Please make sure to check for the following items:

[X] Add unit tests and integration tests where applicable.
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under tests/test_cases/ and add
it to the list under tests/test_definitions.py.
If you've added or changed a command line option,
you should probably add or change a test in tests/test_integration.py.
[ ] Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@Nurdok with the latest push to the master - the tests broke. Can you take a look at this PR?
Because of the master all the other PRs are failing as well.

NVM, didn't see there was an open PR #382 which does this in a much better way. Closing this.


No return value for instance.terminate()

The library docs say when instance.terminate() method is called, we should get a True/False return value (https://github.com/gvlproject/cloudbridge/blob/master/cloudbridge/cloud/interfaces/resources.py#L514). However, AWS and OpenStack implementations do not adhere to that interface (OS: https://github.com/gvlproject/cloudbridge/blob/master/cloudbridge/cloud/providers/openstack/resources.py#L297; AWS: https://github.com/gvlproject/cloudbridge/blob/master/cloudbridge/cloud/providers/aws/resources.py#L282)
The issue is that short of get-ing the just-deleted instance, there doesn't seem to be a good way of getting that info. So should we get the instance or modify the interface?

@afgane I'm thinking we should modify the interface and just return void?

Fixed in: https://github.com/gvlproject/cloudbridge/commit/922e0a0af1b5716840bcbb100c11637b1df87b30


What happens if we don't use cross-validation (CV) and just use trainset and test-set within our forecasting on tail of time data?

@JoaquinAmatRodrigo I have a question that I did not use cross-validation (CV) like you have done in Data Partition section in recent notebook. I just split dat into train and test-set (without validation-set) and I plotted for your consideration.

Do you think is it critical and used ML-based  regression models' learning could be suffer from over/under-fiting when i did not consider CV-set?
base on the picture do you think I damaged nature of time-data in the plot after pre-processing stage (de-noise filter, fill missing sequences, detect and replaced global outliers)? in the plot as legend shows cleaned data divided into train-set and test-set and plot over raw time data.

I also did not also use GridSerachCV within my pipeline also due to save runtime! I have lost of dfs samples I need to apply the designed pipeline. Can  you kindly comment on these Qs separately

Hi @clevilll
For question 1, in my experience, what you are doing is evaluating you model's performance in only a small portion of the data. In order to have more robust idea about this performance, CV should be used in some cases (if it is possible, of course). In your case, your test data is quite long (I suppose because your forecast horizon is quite large, approximately 2000 time steps). If you need to predict so many steps in the future, is true that in your case you won't have too much data to create the splits (probably not more than 3 folds, since you need some data to train with). Anyway, I would encourage you to implement the CV with 3 folds, since in this way are you going to have a more realistic idea about the model performance over time.
In terms of over/under-fitting, this concept is specially important when you decide to fine-tune your model hyperparameters. In this case I think that is even more important to do that using a small CV process in order to not bias results.
About question 2, I do not fully understand. In some cases, it is needed to apply pre-processing steps as you mention and in most of the cases is totally justified to remove noise and fill missing points. In some of my projects (for example, related to price prediction) when I observe anomalies I try to correct them, since it is not the expected behavior. Anyway, everything depends on the context. There are other situation where forecasters do not recommend to threat outliers and model them through the model.
Hopes this can help you

@MarcosBelver, thanks for your reply.
I'm experimenting with conformal prediction over high-frequent time data using the following forest-based regression models for an in-sample forecasting task. The size of univariate (1D) time-series data is (8640, 1), meaning a single column value over time for 8460 time steps.

short note:
8460 means $30×288$  (every day has 288 observations) -- data collected with epochs of 5 mins which leads $12×24$ = 288 observations\data per day

So, what is the best setup for my experiment? [2w:1w:1w] Is ok? Assuming having 4weeks time data like:
# Configuration
# ==============================================================================
steps = 2017 #7*288
lags = 288
name_columns = "avgcpu"

When I was checking this point: avoid potential overfitting, I checked this post Overfitting - how to detect it and reduce it? for R language that led me to this post how to choose a good validation set. Please let me know what you suggest for my time data.

Hi @clevilll
I think everything depends on the validation set (your forecast horizon, actually) because, in my opinion, it is what is going to indicate the configuration of your experiment to a great extent.
In this case you want to predict always one week ahead. In that case, I think you should create a CV-3 folds or something like that (if you want to do fine-tuning, then I would reconsider this, leaving maybe a one test set aside to evaluate performance on unseen data).
If you use skforecast CV method, it will do it automatically for you. You will obtain something like this (fixing your fh=2017):
CV-1:
Train set: from 0 to 2588
Val set: from 2589 to 4605
CV-2:
Train set: from 0 to 4605
Val set: from 4606 to 6622
CV-3:
Train set: from 0 to 6622
Val set: from 6623 to 8639
This is orientative and representing the indexes. There are many other alternatives already implemented in skforecast.
Check this:
https://skforecast.org/0.13.0/user_guides/backtesting
In your case, I would consider the simple approach (the one I used above) and the approach based on fixed window (for example, training with a size of 1 week and forecasting the next one. This approach could be interesting in your case I think).

But remember, this is for testing purposes. With 3-cv fold approach you will obtain a more robust evaluation through the historical data. If you want to do fine-tuning, I would reconsider this a bit, perhaps leaving the last week as unseen data for not overfitting the model. In that case, a 3-cv fold approach could not be suitable given the amount of remaining data.
Let me know if it is clearer now.
Regards,

Thanks for your recommendations.
I will definitely use the different backtesting sk proposed.
Let me see if I understand you correctly, so you say instead of doing Data Partition section in a recent notebook means slicing data into train-set, val-set, and test-set (unseen) and we do  3-cv fold  as you proposed to the apply  ForecasterRecursive() (recommended by @JoaquinAmatRodrigo in this issue)
or
we can directly use backtesting with fixed traind size means backtesting_forecaster(refit=True, fixed_train_size=True) and configure (fixing my future-horizon=7*288=2016) which automatically does the job 3-CV, right?
Then I will have something like :
Number of observations used for initial training: ...
Number of observations used for backtesting: ..
    Number of folds: 3
    Number skipped folds: 0
    Number of steps per fold: ..
....

Fold: 0
    Training:   1991-07-01 00:00:00 -- 2002-01-01 00:00:00  (n=127)
    Validation: 2002-07-01 00:00:00 -- 2003-04-01 00:00:00  (n=10)
Fold: 1
    Training:   1991-07-01 00:00:00 -- 2002-11-01 00:00:00  (n=137)
    Validation: 2003-05-01 00:00:00 -- 2004-02-01 00:00:00  (n=10)
Fold: 2
    Training:   1991-07-01 00:00:00 -- 2003-09-01 00:00:00  (n=147)
    Validation: 2004-03-01 00:00:00 -- 2004-12-01 00:00:00  (n=10)


HOUSNAV-20: Download Results To PDF

HOUSNAV-20
Overview & Purpose

Create a component to print the results of the walkthrough to PDF.
Summary of Changes

Added PdfResultDownload component
Added PrintContent component which will be used for all the hidden content html we want to print
Updated getQuestionAnswerValueDisplay to return user friendly values for more answer types
Added parseComponentToPlainText which removes the html from components so the pdf text is clean.
Added findBuildingCodeByNumberReference which will return the relevant building code section a given reference number

This will be used later to display the building code content

Added findSectionTitleByQuestionId which is used to get the display friendly title for a question
Added DownloadIcon component

Side Effects

I did some preliminary testing merging this with Workflow 2 but once that's merged this may need to be re-tested to make sure the pdfs print out properly for all of workflow 2.

Testing

Known variations from design

Question Id  ie. "P(1)" not displayed.
Display intro questions without building code column since there is no reference
Not displaying logic at bottom of answer
Currently only showing the building code reference and not the whole code. Will be completed in HOUSNAV-97
Not displaying the possible answers, only the answers the user gave.

This actually increases the complexity a good bit because of the logic to account for the possible answers and then get that into a format that can be printed with the selected answer highlighted. I'd make that it's own ticket if we want it during the last week or phase 3. HOUSNAV-123 "Display Possible Answers In PDF Download"

Not showing a building code section at the bottom, only the right if the question references the code.
Width of tables may be less if not enough content is there. I'm looking to resolve this in HOUSNAV-97 since there seems to be a conflicting css class that I haven't found yet. Don't want to hold this pr up for that right now.

Notes & Resources

Checklist

[x] I have written or updated vitests for this work
[x] I have reviewed the accessibility guidelines relevant to this work
[x] I have reviewed this work with at least one screen reader (when applicable)
[x] I have added/updated any related documentation

Had some failures for a type matching issue I didn't catch locally since it was still working.


MSID: 93487 Version: 1 DOI: 2<IP_ADDRESS>1122

"msas": "Neuroscience"
"msid": "93487"
"preprintDoi": "10.1101/2<IP_ADDRESS>1122"
"Reviewed Preprint posted": "2024-01-05"
"Sent for peer review": "2023-10-28"
"Posted to bioRxiv": "2023-10-14" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1122v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=93487)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/previews/93487v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1122)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/93487/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/93487)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/93487

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/93487

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/93487/v1/93487-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/93487)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Equation 15 captured as figure, and also two references incorrectly formatted

Corrected package uploaded to s3://prod-elife-epp-meca/93487-v1-meca.zip for the references. Equation/figure issue will require an xslt