Proposal for community updates to target 2.15 release

Through researching several continuing issues in both emberjs/data and emberfire, along with the rise of @rmmmp's emberfire-utils package to help alleviate these issues, I think it is time for a larger refactor.
With the target being emberjs/data 2.15, which includes a significant improvement over 2.14 and previous (synchronous findOrCreate styles, entire changes in event APIs like recordWillUnload no longer existing at the adapter level), as well as the monkey patches necessary for ember 1 commented in the emberfire code, there is a lot of room for good cleanup.
I am offering my help, and would like to see if we can integrate some of the improvements from emberfire-utils as well. We'll need to start by triaging which current issues are a) emberfire, b) emberjs/data, and which are fixed now. New problems are more likely emberjs/data.
Along with bug fixes, we can simplify and remove a lot of legacy code with the current state of emberjs and emberjs/data, like the monkeypatches. We'll want to triage all of those areas too.
I will update this issue with a checklist of things we can improve later today.

@elgordino what are your thoughts on adding your gist to the list here? it might make more sense as a separate PR, but I'm triaging a few things and this is where we should discuss :)

Just laying out here what I've said in slack.
My original intention for emberfire-utils was to do experimentations outside of this addon and see what we can integrate in here. From being an experiment, my apps are now very dependent on it.
With that said, some of my addon's feature I believe are too opinionated as a default setup here. We'll need to cherry pick stuff (if any) that makes sense to be built-in here.
Lastly, I'm in favor of the goals laid out by @mileszim but Ember Data 2.15 as a target might not be realistic (it's happening in Aug 14th if on time). I think a better target is just to keep on refactoring if it won't break anything (if not, deprecate), then remove the deprecations in EmberFire 3.0. When will EmberFire 3.0 be released? Not sure, but I'd say when it's ready. 😁

You bring up good points @rmmmp, and you are correct I was not implying porting your work into emberfire, merely bringing it up as a topic of discussion, which we are having now :)
As for the target release date, I don't mean anything negative towards the team but the delay of the latest release, combined with the sheer amount of bugs in it, makes me think 2.15 is a bit further from aug 14th.
Additionally, I like the idea about piecemeal-updates, but the dev team here has not responded or merged PRs or even made a code change in almost 2 months, so my thought process was -> refactor a bunch of stuff all at once and then... i dunno.. appeal for the PR to be brought in? otherwise just keep it a hard fork and carry on if firebase is not interested in maintaining this repo.
I am conflicted either way, as I want to keep the work here, but at the same time piecemeal PRs will do no good if we don't have a responsive dev team to review and merge them consistently.
In other words, I have no idea, but I'm still grooming the list of work to be done so once I can get that up it will be more clear (hopefully) how to proceed.

@mileszim perhaps we should just create a new addon for integrating with firebase and use some of the work from here and improve upon it? I agree it would be nice to have the official version updated and working, but something with this many moving parts cannot just sit idle for months with no updates.

Thanks for getting this discussion going @mileszim . I would love to see a ember firebase integration that was quicker to evolve and more future focused. I think the ideal would be for this to happen within the current project, and I think we should allow for the opportunity for that to happen, however it appears that it will be unsuccessful then a fork/rewrite would be the only option really.
The priority features that I think emberfire is missing right now:

Atomically committing relationships, eg A <-> B, if the relationship is added / removed then it should happen on both A & B in the same update(). This is critical for records that are not parent/child related.
Deleting records automatically updating other records with relationships into that record.
Transaction Support. Initially covering relationship updates in the first two items. In the longer term I would like to be able to something like .save(transactionID) on multiple records and then later commit(transactionId).

I have a gist that I put together to achieve some of this because I need to for my current project. I'm certainly not suggesting it as a proposed implementation, but I would like to see something that provided this functionality.

Models to be able to express their own path prefixes (determined at runtime), or for id's to contain paths. There has been discussion on this topic in #432 and @rmmmp has done some work already in emberfire-utils. I am currently using a different, perhaps orthogonal, approach to the same requirement detailed in this gist.

A simple way to automatically set the server timestamp each time a record is saved, e.g. for a lastModified field. gist.

Some other ideas

Drop support for everything but the the latest LTS and the one prior? Or even just latest LTS?
Feature flags for new features, this will help ensure we stay in sync around a single branch as more complex/experimental features are delivered

This is great @elgordino, thanks for taking the time to write all this out.
The three bullets at the top, I'll weight in my opinion: I'm, preferential for having a transaction being a function wrapper instead of a separate entity, but that depends on the firebase js API. Something like this:
this.get('store').transaction((store) => {
  const record = store.createRecord(...);
  ...
  record.save();
});

Atomic relationship saving in firebase, if I remember, are harder (or used to be not possible)? I just woke up so I'm could be totally wrong, but I'd love to see that and what you've tried or successfully implemented! Once we have the list (soon i promise :)) this could be delegated to you @elgordino?
As for deleting the relationship to the a record that's deleted, that will be a fun ride down internal model map and emberfire's legacy code. It should be implemented correctly in ember/data 2.15 from the code I've read so our work should in theory be based around correctly handling it on the emberfire side.
The middle two features regarding path prefixes and lastModified, you've done great work getting the ball rolling so I think that will be a straightforward one :)
For the last bit, as far as I know emberfire as it stands now works with 2.12 (or at least I used it a lot just fine), its 2.13 and up that introduced issues. If community consensus wants that, lets do it, and continue these kinds of discussions as we update piecemeal.
How does this all sound?

Just FYI I've spoken to my manager and will be setting aside some time this quarter to give some major love to the project; including dealing with the legacy code. I have some angularfire2 commitments on my plate this month though, so I probably won't start doing any heavy lifting until September.
Let's keep the conversation going on what we want this library to look like + I'd welcome help from anyone in the community 😄

Résumé submitted. (jking).

Just floating it but it would be much much much easier for us on the Firebase team to maintain this project it we slimmed it down. Wrapping the entirety of the Firebase JS SDK, which has dedicated staff and is constantly fixing bugs + releasing new features, is untenable IMO.
The framework-specific libraries are maintained as side-projects by those of us interested. Then of course as we get settled in at Google we no longer use Ember in our day-job and our interest / knowledge of the state-of-the-art wanes.
Emberfire should be the very base driver, allowing Firebase to work with Ember with the minimal amount of fuss; rather than completely abstracting Firebase away. We've taken this approach with angularfire2 which I've been doing some work on lately and I've found it refreshing.
If the community wanted to completely wrap and abstract away Firebase making it a 100% drop in replacement for a traditional backend+RDMS w/transactions, which Ember-data was really made for, then they could build on top... but it would be never ending pile of work.

@jamesdaniels, are you implying that emberfire should just expose a firebase service then adapters, sessions, etc. would be dependent on that service and each being a community maintained addon outside of this? If so, I'm in favor of that though it would be nice if the separate addons were also maintained officially. However, I can understand the reasoning why it would be hard for those to be officially maintained.

@jamesdaniels if I am understanding you correctly, I disagree with that idea. The beauty of Emberfire is that any Ember developer can essentially just set up their models correctly in Ember data and all the firebase stuff is handled for them behind the scenes. It allows for rapid prototyping and for anyone to quickly spin up a database and not have to worry about how it works.

@jamesdaniels what are your plans for firestore? :wink:

@rmmmp as mentioned on #529, Cloud Firestore support will be coming as a WIP soon. This will become our preferred adapter as it much better aligns with the needs of ember-data than the Firebase Realtime Database. Cross collection transactions, shallow fetches, etc.
Knowing Cloud FIrestore was coming was also my reasoning behind tempering expectations with the current ember-data adapter.
I will release a roadmap shortly. I am hoping to roughly align the new Cloud Firestore based adapter with the Ember 3.0 schedule.

@rmmmp happy to work with you and the rest of the community FYI + not do this in a vacuum.

@jamesdaniels happy to help where I can, just need some direction on what needs to be done 😄


Add a vue-cli Configure Sass-Resources-Loader Example

What problem does this feature solve?
I read the vue-cli docs about sass-resources-loader section and can not understand how to configure the vue-cli project for this.
After some codes reading,I write these codes for that loader to work out:
//vue.config.js
var path = require('path');
module.exports = {
    chainWebpack: config => {
        config.module
            .rule('vue')
            .use('vue-loader')
            .tap(options => {
                var scssResourceLoader = {
                    loader: 'sass-resources-loader',
                    options: {
                        resources: path.resolve(__dirname, 'src/assets/_variables.scss')
                    }
                };
                options.loaders.scss.push(scssResourceLoader);
                return options;
            });
    }
}

I hope this will help others.
What does the proposed API look like?
...

Thanks! Soon it will be a lot easier with the next version of vue-loader. 😉

Yeah,I hope the wiki for webpack config could be a bit more easier for new user.Because of the webpack is a bit complex to use and it will make the vue-cli complex to use too.

sorry to hijack this issue, but it seems like there is a lot of confusion about how to configure stuff in the new vue-cli.
i thought it would be relatively easy to configure a new project the same way i had the old one configured with cssSourceMap: true, but i can't get it to work properly. maybe someone can point me in the right direction...
// vue.config.js
var merge = require('webpack-merge')

module.exports = {
  chainWebpack: config => {

    config.module
      .rule('vue')
      .use('vue-loader')
      .tap(options =>
        merge(options, {
          cssSourceMap: true,
          extractCSS: true,
        })
      )
  }
}

i tried a bunch of other configuration options on the loaders, but it all resulted in css still included via style tags.

Maybe it works, when you add a "return options" after your merge, like @vaxilicaihouxian did.

@Akryum Will it then be possible to set / overwrite file names and paths for the different file types?
Currently I like to adjust the paths for css, font, image, media and html files to something different than "css", "font", "img" and "media". Additionally I would like to remove the hashes of the names, because I want to use the generated codes inside a cms system with its special naming conventions and not for a SPA.

@mediaessenz the return is implicit, it's also working, i can see that by checking the diff of vue inspect > config_template.js

I got some similar running with this syntax:
module.exports = {
    chainWebpack: config => {
        config.module.rule('images').use('url-loader')
            .tap(options =>
                Object.assign({}, options, { name: 'Images/[name].[ext]' })
            )
        config.module.rule('svg').use('file-loader')
            .tap(options =>
                Object.assign({}, options, { name: 'Images/[name].[ext]' })
            )
        config.module.rule('media').use('url-loader')
            .tap(options =>
                Object.assign({}, options, { name: 'Media/[name].[ext]' })
            )
        config.module.rule('fonts').use('url-loader')
            .tap(options =>
                Object.assign({}, options, { name: 'Fonts/[name].[ext]' })
            )
        config.plugin('extract-css')
            .tap(([options, ...args]) => [
                Object.assign({}, options, { filename: 'Css/[name].css' }),
                ...args
            ])
    },
}

Maybe this help you @phoet in any kind.

@phoet
or you try this parameter:
module.exports = {
    css: {
        // extract CSS in components into a single CSS file (only in production)
        extract: true,

        // enable CSS source maps?
        sourceMap: true
    }
}

@phoet @mediaessenz
The cssSourceMap depends on the plugin  ** optimize-css-assets-webpack-plugin ** in vue-cli project.
see @vue/cli-service/lib/config/prod.js :
//optimize CSS (dedupe)
      webpackConfig
        .plugin('optimize-css')
        .use(require('optimize-css-assets-webpack-plugin'), [{
          cssProcessorOptions: options.productionSourceMap && options.cssSourceMap
            ? { safe: true, map: { inline: false } }
            : {safe: true }
        }])

options.cssSourceMap can not set via the vue.config.js file.So it always return {safe:true}
Then there is no css sourcemap in the output file.
PS:
If you set options.cssSourceMap=true ,it will just generate a sourcemap for you base on the Extract-Text-Plugin output. I think the vue-cli use this optimize plugin it's that they don't need source map for css on the production env.

@mediaessenz  @vaxilicaihouxian
Hello guys, very good your demonstrations I have a doubt how I could make the project when it is generated to production does not put as relative path to the root because in the server where I will upload it will be a subfolder e tested with baseUrl: './' it works so that the files js, css and images remain with "./" but the error is now generated in the final css file because it puts the paths of the fonts and background images as './' and I want that I stay as in development ../ because I need a folder to be returned

any update ?

@andercard baseUrl is what webpack will use at compile time to generate the path to your assets in the built code. For example, you can put /my-subfolder/ and in the code loaded in the user browser, assets will be loaded from the /mu-subfolder/<path-to-asset> URL. You can also put an origin (useful when using a CDN): baseUrl: 'https://my-cdn.com/assets/'.

@andercard If you have an issue which isn't related to this thread please open a new one.

We'll close this for now because we are upgrading to vue-loader 15 soon, which will make this a lot easier.

// vue.config.js module.exports = {   css: {     loaderOptions: {       // 给 sass-loader 传递选项       sass: {         // @/ 是 src/ 的别名         // 所以这里假设你有src/variables.scss这个文件         data:@import <EMAIL_ADDRESS>     }     }   } }

// note: in sass-loader v8
prependData: @import<EMAIL_ADDRESS>


First attempt at texture-based fonts / custom glyphs

This is a feature for custom glyphs and entirely custom fonts. It consists of two things:

A lovr.texture.newTextureFont() — this creates a font which is not backed by a TTF file. Instead, a texture is provided at creation time. (To mesh well with other Lovr APIs, the font does have a rasterizer, but it is a "dummy" rasterizer with no TTF.)
A font:addTextureGlyph() — this takes an existing font (it does not have to be a texture font) and adds a custom glyph with specific metrics and with manually supplied texture coordinates.

Potential uses for this are:

"Pixel art fonts" which do not use SDF (this is what I developed it for)

Create a font as a prebaked SDF texture instead of a TTF

Potential future work: Add additional glyphs to a TTF font— if we:

Add the ability to add arbitrary image content to a TTF font's texture (notice that all I've added is the ability to add glyphs, with specified texture coordinates— the image content must already be present)
Add a SVG->MSDF converter

Then we could create the ability to add custom glyphs for unicode symbols by selecting SVGs, converting them to MSDF, and adding the glyph to the font. This would allow you to, for example, print icons relevant to your game into the middle of printed text.

Attached is a demo. It uses a PNG containing a dump of the font bitmap from the original Apple // computer and creates a font out of it (with custom per-character advance— the image is packed as 7x8 glyphs but displays as 8x8 glyphs). It does require some fancy footwork on the Lua side (see pixelFont.lua), but I think that may be necessary here to have a simple and general interface that accommodates a range of ways of importing custom fonts.
textureFontDemo.zip

I will just post this incomplete thought early but I am still working to understand everything here: it seems like if Rasterizer can preserve or strengthen its role as "object that stores or generates glyphs" then that would somehow be good.  If this image font was simply an official second type of Rasterizer that had an ImageData, maybe there are advantages compared to having a somewhat awkward dummy rasterizer.  Maybe it would reduce conditionals or simplify the stuff Font needs to care about or allow things to be done if you aren't using the GPU (e.g. on threads).

It might depend on, when using this feature, whether your atlas is more likely to be stored in RAM (Image, Rasterizer) or more likely to be stored in VRAM (Texture, Font).

Thinking out loud:

it seems like if Rasterizer can preserve or strengthen its role as "object that stores or generates glyphs" then that would somehow be good

At the moment, in the Lovr code, a Font is a thing that tracks a texture and an atlas of glyphs within that texture, and a Rasterizer is a thing that knows how to render glyphs and on demand amends a texture by rendering a new glyph into it. The Rasterizer, at present, does no management of the texture. Expanding the texture, and even deciding where in the texture a glyph is to be rendered, is the Font's job. The Rasterizer only serves to tell the font how big a glyph is going to be before the glyph is rendered (so it knows how to pack it) and then rendering it. It is a box for managing a TrueType/OTF font and pulling metric and image data out of that font.
In my model I'm proposing, there will sometimes be fonts that have no TrueType/OTF source associated with them. There will still be a rasterizer, because in the Lovr API the rasterizer is responsible for reporting certain kinds of "defaults" and those defaults might still be meaningful for a dummy (no OTF source) font. In the current patch, the dummy rasterizer does no work at all because the rasterizer's only job in the Lovr font model is to be a fallback (ie: a glyph is requested, it is not already, here is a source for producing a new one) and with the dummy rasterizer all glyphs that will ever be supported are present from the beginning.
If we move forward with my proposed improvements, we will be adding glyphs to the font after its first initialization, but not on demand. The model I'm suggesting is that when the font (whether dummy or normal) is first created, before the font is used the client code will go over a list of symbols it expects to need and add those symbols to the texture. If the symbols are added from SVGs, we will need some sort of logic for rendering MSDFs, and if it makes more sense to keep MSDF rendering in rasterizer.c then sure, maybe that code can live in rasterizer.c. However my initial inclination is that this function (add an image to the texture and register it as a glyph) most naturally lies with the font rather than the rasterizer, because the rasterizer's model is about being a fallback which renders glyphs on demand. If it makes sense for there to be a "second kind" of rasterizer (as opposed to the do-nothing dummy rasterizer) the only thing I could think of would be some kind of callback you register with a rasterizer— when a rasterizer is asked to rasterize a glyph it looks for it in its font, if the glyph isn't in the font or the rasterizer doesn't have a font then instead it talks to the callback which pulls SVGs from a directory or does something algorithmic (?). I feel like I can't think of a really good use case for this callback approach, but maybe if I was trying to render CJK I'd feel differently.

I agree with the distinction between

when a rasterizer is asked to rasterize a glyph it looks for it in its font, if the glyph isn't in the font or the rasterizer doesn't have a font then instead it talks to the callback

LÖVE actually supports this "fallback font" system.  You can specify a list of Rasterizer objects that the Font is able to pull glyphs from, instead of just 1.  When it needs to paste a new glyph into its atlas it will try all of its Rasterizers in order until one of them has the glyph.
It seems like this could be useful for one of the features presented in the original PR description

Add the ability to add arbitrary image content to a TTF font's texture

If I have a TTF font, and I want to augment it with an atlas of emoji or SVG icons that I made (ignoring MSDF for now), I think both approaches could work:

With the current patch, the process would be:

Offline step: Create a combined atlas of the TTF glyphs and the icon atlas (LÖVR can't rasterize the TTF glyphs for me because the rasterizer needs to be a dummy rasterizer, right?)
Upload it to the GPU (newTexture)
Load it as a texture font
Specify glyph codepoints/uvs/metrics

If there were two types of rasterizers (Image and TTF), and Font could have fallback rasterizers, the process is:

Create a TTF Rasterizer from the font file
Create an Image Rasterizer from the emoji atlas

Specify glyph codepoints/uvs/metrics for this rasterizer's atlas

Create a Font from both rasterizers, the current atlas system would function unmodified

Observations:

When using a custom font texture, I need to make sure that the Texture has all the glyphs I need, and I'll probably need to make combined atlases for that.  To me that offline step and atlas combining feels cumbersome.  Maybe being able to add individual glyphs/Images/Textures to the Font after it's created would help with that, but I'm not sure how that would work since the Texture is supposed to be static.
The Image Rasterizer isn't convenient if I am generating glyphs/atlases dynamically using the GPU.  I'd need to render them, read back the texture into an Image, and then create a rasterizer from that.  Not sure how common that is.

This needs design work resolved before it can move forwards, I'm going to close but discussion should still continue


Build error in function std.json.toJSON

../../.dub/packages/doveralls-1.3.1/doveralls/source/doveralls/request.d(8,23): Error: function std.json.toJSON (ref const(JSONValue) root, const(bool) pretty = false, const(JSONOptions) options = cast(JSONOptions)0) is not callable using argument types (JSONValue*, bool)

@ColdenCullen any chance of getting the PR merged and a new release? I'm also affected by this:
$ dub run doveralls
Building package doveralls in /Users/travis/.dub/packages/doveralls-1.3.1/doveralls/
Performing "debug" build using /Users/travis/dlang/dmd-2.080.1/osx/bin/dmd for x86_64.
doveralls 1.3.1: building configuration "application"...
../../../.dub/packages/doveralls-1.3.1/doveralls/source/doveralls/request.d(8,23): Error: function `std.json.toJSON(ref const(JSONValue) root, const(bool) pretty = false, const(JSONOptions) options = cast(JSONOptions)0)` is not callable using argument types `(JSONValue*, bool)`
../../../.dub/packages/doveralls-1.3.1/doveralls/source/doveralls/request.d(8,23):        cannot pass rvalue argument `& data` of type `JSONValue*` to parameter `ref const(JSONValue) root`
/Users/travis/dlang/dmd-2.080.1/osx/bin/dmd failed with exit code 1

cheers, the new release has fixed it for me

Glad to hear it! Sorry for the delay.


Stojanovic/ep 34 fix search page rendering

@mirekys I've made the changes to layout like we discussed. Also, I pushed the result count to the right side next to sort options - not 100% sure if we like this or not.
Main changes are in file ActiveFiltersElement.jsx. Some notes regarding the file (as I understand it might seem a bit weird at first):

I brought aggregations in, so that I would have access to facet group labels
Only way to conditionally render things in semantic UI based on screen size seems to be by using grid columns/rows with "only" prop. Otherwise, if we don't like this, I could add some selectors and write media queries in CSS to achieve this. Or maybe there is another approach I don't know about?
Grid.Row is flexed by default and this made groups of facets be inline with one another and I did not like this - but not sure if this is actually a problem

I prefer it like on Alza:

I had alignment issues with Clear filters button on mobile/tablet, so I solved it with inline style

Please take a look and let me know!

@mirekys I've made the changes to layout like we discussed. Also, I pushed the result count to the right side next to sort options - not 100% sure if we like this or not.
Main changes are in file ActiveFiltersElement.jsx. Some notes regarding the file (as I understand it might seem a bit weird at first):

I brought aggregations in, so that I would have access to facet group labels
Only way to conditionally render things in semantic UI based on screen size seems to be by using grid columns/rows with "only" prop. Otherwise, if we don't like this, I could add some selectors and write media queries in CSS to achieve this. Or maybe there is another approach I don't know about?
Grid.Row is flexed by default and this made groups of facets be inline with one another and I did not like this - but not sure if this is actually a problem

I prefer it like on Alza:

I had alignment issues with Clear filters button on mobile/tablet, so I solved it with inline style

Please take a look and let me know!

Thans a lot @Ducica, I also prefer Alza layout with filter groups layed out as flex column (I saw it like that in current implementation)

@mirekys Zdar, I tried implementing changes as per today's discussion, please take a look and thanks!


Consuming documents including barcodes fails

Whenever I try to import a document that includes one or some EAN barcode it fails.
Addon log shows:
[2024-02-28 07:27:16,191] [INFO] [celery.worker.strategy] Task documents.tasks.consume_file[ff6a4898-a7b2-4eeb-b9bf-61c8dc2f279a] received  celery@ca5234a0-paperless-ngx:ForkPoolWorker-144]: ./core/src/Result.cpp:140: bool ZXing::Result::operator==(const ZXing::Result&) const: Assertion lineCount() == 1' failed.
[2024-02-28 07:27:19,066: ERROR/MainProcess] Process 'ForkPoolWorker-144' pid:450501 exited with 'signal 6 (SIGABRT)'
[2024-02-28 07:27:19,126] [ERROR] [celery.worker.request] Task handler raised error: WorkerLostError('Worker exited prematurely: signal 6 (SIGABRT) Job: 143.')
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/billiard/pool.py", line 1264, in mark_as_worker_lost
raise WorkerLostError(
billiard.einfo.ExceptionWithTraceback:
"""
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/billiard/pool.py", line 1264, in mark_as_worker_lost
raise WorkerLostError(
billiard.exceptions.WorkerLostError: Worker exited prematurely: signal 6 (SIGABRT) Job: 143.
"""
Current version: 1.2.5
Core 2024.2.4
Supervisor 2024.02.0
Operating System 12.0
Frontend 20240207.1
Raspberry Pi 4
4 GB RAM
example:
European Article Number – Wikipedia.pdf
regards
Thomas

filename: "{created_year}/{correspondent}/{title}" language: deu language_packages: eng deu default_superuser:   username: ngxadmin   email<EMAIL_ADDRESS> password: password timezone: Europe/Berlin ssl: false certfile: fullchain.pem keyfile: privkey.pem barcodes_asn: true barcodes_enabled: false

It seem to be related to ZXing library, you can try to use PYZBAR but the recognition is better with ZXing
PAPERLESS_CONSUMER_BARCODE_SCANNER=PYZBAR
I'll try to replicate the error and check if its related to last Paperless-NGX updates


Automated cherry pick of #1756: region: server order by account and remove models stale comments

Cherry pick of #1756 on release/2.11.0.
#1756: region: server order by account and remove models stale comments

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@87460dd). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.11.0   #1759   +/-   ##
================================================
  Coverage                  ?   7.63%
================================================
  Files                     ?     412
  Lines                     ?   63226
  Branches                  ?       0
================================================
  Hits                      ?    4829
  Misses                    ?   57986
  Partials                  ?     411

Flag
Coverage Δ

#aFlag
7.63% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.4% <ø> (ø)

pkg/compute/models/zones.go
2.48% <ø> (ø)

pkg/compute/models/storages.go
1.24% <ø> (ø)

pkg/compute/models/guests.go
0.69% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87460dd...73b25b8. Read the comment docs.

/lgtm
/approve


Add support for integer and double option choices.

According to the discord API, paramater choices can be string, integer, or doubles for parameters that are registered as STRING, INTEGER, or NUMBER.
There is currently no way to register options in.
What I would like to see is support for this, ideally in the same form as entering descriptions.
#[poise::command(slash_command)]
async fn my_method(
    ctx: Context<'_>,
    #[description = "Description"] // This form is great and easy to use.  Why make it cumbersome with the enum form?
    #[choices = (1u8, 2u8, 3u8, 4u8, 5u8, 9u8)] name: u8, // tuple works best
) -> Result<(), Error> {
  // ...
}

The syntax should be #[choices(1, 2, 3, 4, 5, 9)] name: u8, but I agree this is a good feature. It should work for all types that implement Display and can be parsed from a literal token
I'm just not quite sure how the macro should handle the types. Like
type MyInt = u32;
#[poise::command]
async fn my_method(ctx: Context<'_>, #[choices(1, 2, 3, 4, 5, 9u] name: MyInt)

The macro only sees ambiguous integer literals and "MyInt"

Having written that code snippet out, it doesn't seem hard anymore lol. The macro can generate the string labels with $value.to_string() and dispatch from the choice index to the value with a match statement match index { 0 => $value0, 1 => $value2 }; and as the type it can just use literally MyInt everywhere. That should work

The devil is being in the details, as always

I've implemented this in the inline-choice branch, could I interest you in trying it out / testing it?

I've implemented this in the inline-choice branch, could I interest you in trying it out / testing it?

Yup! I'll test it here in a moment.

This works great!

That's fun to hear, if you knew the messy data flow I've had to wedge into to implement this :D But great then. I suppose we can close the issue and release, then?

Works for me!
On Wed, Dec 20, 2023, 12:09 PM kangalio @.***> wrote:

That's fun to hear, if you knew the messy data flow I've had to wedge into
to implement this :D But great then. I suppose we can close the issue and
release, then?
—
Reply to this email directly, view it on GitHub
https://github.com/serenity-rs/poise/issues/230#issuecomment-1864916239,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYCSI6GBQ2C4MXU57NW5VDYKMSXFAVCNFSM6AAAAABAQT4GCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUHEYTMMRTHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


TextChanged Error

receiving this error:
zsh 1796 [1] % vi .vim/bundle/vim-auto-save/plugin/AutoSave.vim
Error detected while processing /Users/toddbush/.vim/bundle/vim-auto-save/plugin/AutoSave.vim:
line   46:
E216: No such group or event: TextChanged * nested call AutoSave()
Press ENTER or type command to continue
vim version:
zsh 1796 [1] % vi --version
VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Jun 14 2016 16:06:49)
Compiled by<EMAIL_ADDRESS>Normal version without GUI.   Thank you for reporting this! It seems like you're using old Vim version which has no support for TextChanged event. I have updated the plugin to handle such situation and show an appropriate message to the user.
Vim 7.4 is required for plugin to work correctly with a default configuration. It also can work with older Vim version, but you will need to manually configure when to auto-save a file. Please, use g:auto_save_events option.

Ah.  thanks @907th.  I see the new error message.  I'll upgrade my vim.  Closing this issue.


Use sourceType instead of rootTyping for following<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 418774210

10 of 11 (90.91%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 85.659%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/protoc-gen-nexus/src/printer.ts
10
11
90.91%

Totals

Change from base Build 418773683:
0.9%

Covered Lines:
152

Relevant Lines:
171

💛  - Coveralls


Support Slurm (or other cluster management and job scheduling system)

There are lots of  school and company which use slurm or other cluster management and job scheduling system.
It will be great if mars can support it.

This is sort of duplicate with #97 , we will discuss to see if we can support those scheduling systems.


Fix HITL simulation

By not publising HIL_STATE_QUATERNION by default.
fyi @mpaperno @kd0aij

@bkueng Does this break SITL for me? How do I get the same behavior I had before?

It shouldn't. The required changed on FW side are in https://github.com/PX4/Firmware/pull/5706

:+1:

PX4 changes are in.


Add codecoverage using codecov and jacoco

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d92d1d4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   86.82%
  Complexity        ?      233
=========================================
  Files             ?       39
  Lines             ?      858
  Branches          ?       50
=========================================
  Hits              ?      745
  Misses            ?       88
  Partials          ?       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92d1d4...17b969e. Read the comment docs.


1-off error in MobileStepper

[X] This is a v1.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Mobile stepper should show correct percentage of steps in progress bar
Current Behavior
Right now it's calculating the percentage complete based on (active step)/(total steps - 1) * 100.  This gives weird results where the progress is 0 on first step, 33% on second, 66% on third and 100% on fourth.  It should either show 0 on step 1 and 75% on last step, or (and probably preferred) 25% on first step and 100% on last step.  So: (active step + 1) / (total steps) * 100
Steps to Reproduce
Look at the existing demo on the demos page, which has 6 steps.  Actually count and at step 3 of 6 the stepper is not 50%.
Link: https://material-ui.com/demos/steppers/
Context
We show "Step [x]/[total]" on our mobile stepper and it looks very weird when it's step 2/4 and not 50%
Your Environment

Tech
Version

Material-UI
v1.4.2

@ScottieR The MobileStepper accounts for the number of steps completed. It's opinionated. The specification seems to encourage (I have done the math with the number of pixels) the number of steps in progress: https://material.io/archive/guidelines/components/steppers.html#steppers-types-of-steps. I fear changing the logic is a breaking change.


GitHub repo's not showing in list even with recent commits.

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dret5c7ityp6b
Region
eu-west-2
Amplify Console feature
Webhooks
Describe the bug
Builds fail occasionally with this message.

There was an issue connecting to your repo provider, click "Reconnect repository" in General Settings, and then try your build again.

I go to reconnect it, but I can't get the repo to show in the list.
I have tried:

Adding a commit to the repo.
Revoking access on my GH profile in the applications section and then re-authorizing AWS
Removing the old webhooks manually.
Deleting the app from amplify and re-adding it.

I have the same issues when adding new regions sometimes. I go to select the repo and I can't get it to show in the list.
Extra info:

I have instances/apps for production, develop and staging on different sub accounts watching different branches in the same repo if that affects anything.
The repo list is very large for the org
The only thing that does seem to fix it is renaming the repo, which isn't ideal.

Expected behavior
I would like to be able to select the repo as needed. Failing that if there was a field I could just paste the path that would do too.
Reproduction steps
This is intermittent. It is resolved at the moment.
Just going to the reconnect repo dropdown and sometimes it doesn't have the required repo listed.
Build Settings
No response
Additional information
No response

Hi @Beancow 👋🏽 thank you for raising this issue. It seems like this is intermittent behavior without clear reproduction steps. I've not been able to reproduce this behavior so far. Please update this issue if this behavior occurs again.


install modsecurity-nginx error

My environment is centos 6.8 and  I already installed the libmodsecurity but when I install nginx it show "checking for ModSecurity library ... not found
checking for ModSecurity library in /usr/local/modsecurity ... not found" why?

Please, check if you have files under: /usr/local/modsecurity

@zimmerle  secondly, the /usr/local/modsecurity is already exist,why is not found???

Make sure you have LD_LIBRARY_PATH pointing to /usr/local/modsecurity/lib.

@zimmerle   I  try run the export MODSECURITY_INC=/usr/local/modsecurity/lib
export MODSECURITY_LIB=/usr/local/modsecurity/include  but  it is invalid

@zimmerle  I can give you a advice?You personally use centos install modsecurity - nginx?I doubt you now the waf - nginx is not suitable for centos version


Issue with atypical Latex indentation

e.g. https://github.com/peterjc/biopython/blob/biopython-175/Doc/Tutorial/chapter_phenotype.tex
Reduced to a smaller test case, note the inconsistent indentation of lines 4 and 6 (which LaTeX does not care about):
\begin{description}
  \item[Well identifier]
    If you know the well identifier (row + column identifiers) you can access the desired well directly.
\begin{minted}{pycon}
    >>> record["A02"]
    \end{minted}

  \item[Well plate coordinates]
    The same well can be retrieved by using the row and columns numbers (0-based index).

%doctest examples lib:numpy
\begin{minted}{pycon}
>>> from Bio import phenotype
>>> record = list(phenotype.parse("Plates.csv", "pm-csv"))[-1]
>>> print(record[0, 1].id)
A02
\end{minted}

more text here...

\end{description}

The output:
\begin{description}
  \item[Well identifier]
    If you know the well identifier (row + column identifiers) you can access the desired well directly.
\begin{minted}{pycon}
>>> record["A02"]
\end{minted}

tem[Well plate coordinates]
The same well can be retrieved by using the row and columns numbers (0-based index).

test examples lib:numpy
in{minted}{pycon}
>>> from Bio import phenotype
>>> record = list(phenotype.parse("Plates.csv", "pm-csv"))[-1]
>>> print(record[0, 1].id)

\end{minted}

more text here...

\end{description}

Notice line 8 onwards (after the end of the code snippet) has lost the first few characters, it should still start   \item
I suspect the issue is the two code blocks with text in between being treated as one code block?

I suspected you might say that - I'm not sure without digging into it if this is an oversight in just the recently added \begin{minted}{pycon} regex, or all the LaTeX patterns in general. LaTeX can be frustratingly flexible on somethings (like the white space indentation here) while incredibly precise on others.
I've been off work sick this week, and am unlikely to look any further at this in the next week or so.


Add October 7, 2024 solution

Added .java solution file for October 7, 2024 leetcode daily solution
Proper commenting for better comprehension

Do let me know if any changes are to be made.

good @Krounosity

good @Krounosity

Thank you!


Failing to build 1.21.4 (possibly others) due to 404 for protoc-gen-validate

Description:
When trying to build Envoy 1.21.4 (and possibly others), it's fetching an archive which doesn't appear to exist any more:
WARNING: Download from https://github.com/envoyproxy/protoc-gen-validate/archive/v0.6.2.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
Repro steps:
Attempt to build Envoy 1.21.4 (possibly others)
Admin and Stats Output:
N/A
Config:
N/A
Logs:
ERROR: An error occurred during the fetch of repository 'com_envoyproxy_protoc_gen_validate':
   Traceback (most recent call last):
	File "/build/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/envoyproxy/protoc-gen-validate/archive/v0.6.2.tar.gz] to /build/external/com_envoyproxy_protoc_gen_validate/temp257660383487356965/v0.6.2.tar.gz: GET returned 404 Not Found```

thanks @madpsy - just in time for the next 1.21 release - ill address this now
what is odd is that this has not triggered in our CI - did this just start happening ?
the underlying cause is that protoc-gen-validate has moved -> bufbuild

Yup within the past hour (was working earlier today).

yep - got it in CI now also - https://dev.azure.com/cncf/envoy/_build/results?buildId=120555&view=logs&j=e969334a-0e55-5c18-ac96-8b546753391e&t=b5329a9e-93c7-5412-9f4c-6f8d659e1b57&l=116

Thanks for confirming. I'm up for any kind of bodge fix for now (even sed'ing the source in my pipeline) or a patch release version etc. If you have any ideas I'm all ears!

I thought redirects solve this? Did they delete the release archive?

seems so
correcting the url makes the dl work

curl -v https://github.com/envoyproxy/protoc-gen-validate/archive/v0.6.2.tar.gz results in a 302 for:
location: https://codeload.github.com/envoyproxy/protoc-gen-validate/tar.gz/v0.6.2
which results in a 404

@madpsy  fix is in #23997

Not going to recommend anyone does this but I needed a very quick fix so in my Dockerfile I added this after a git clone
RUN sed -i 's#envoyproxy/protoc-gen-validate#bufbuild/protoc-gen-validate#' /source/api/bazel/repository_locations.bzl

Seeing the same issue on 1.22.5. Can we do a backport for that version too? @phlax

fixes for all stable branches are just waiting on CI now to land

cc @ggreenway


Build and Deploy Your SAP Fiori App to SAP Business Technology Platform

Tutorials: https://developers.sap.com/tutorials/appstudio-fioriapps-mta-build-deploy.html
Write here what you need help with ...
Once cf command executed showing below error.
user: DIBS_FIORI_DEMO $ cf html5-list -di DIBS_FIORI_DEMO-destination-service -u
Getting list of HTML5 applications available via destinations in org 7ce93f55trial / space dev as<EMAIL_ADDRESS>FAILED
Could not create service instance of app-runtime plan:
Service broker error: Service broker html5-apps-repo-sb failed with: Internal Server Error

Hi @Omrocks ,
Does this still happen?
If so, I can think of the following:

Need to re-login from BAS to the CF org/space.

Check that the app is configured to use Managed Application Router: In the manifest.json of the HTML5 module there should be a "sap.cloud" section  with two attributes: (1) "public": true, (2) "service": "name of the AppRouter service".

Check that the SAP launchpad service is enabled (tutorial).

Check that app deployment was successful: The easiest way is to go to CF subaccount in SAP BTP cockpit > HTML5 Applications tab and check that the app appears there. (BTW - You can also run the app by pressing its link in the cockpit.) Deployment status should also be available in BAS log during the app's deployment operation.

Trial account resource limitations were reached: See issue 215.

Regards - Raz

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions and want to continue the conversation, feel free to reopen the issue.


coffee script tag

I've never had to try and modify a coffee script tag. I don't even know if that's possible. How do I add nonce to it?
:coffee{ nonce: "#{@content_security_policy_nonce}" }
I don't want to search the web for hours only to find out I can't do this. It would be nice if the docs had examples.

Neither have I and this is certainly out of scope for the project. Please consult your necessary documentation.


feat(users): Ability to allow login only for approved users

any user logged in gets database row created
then you approve it
if we don't care about the scenario when we have multiple IDP (like google and facebook at the same time) we may pre-invite users for their email as described in the task (or implement fullscale workflow with invitation links and so on, might not be useful yet)
@monkeypants @simra
#47

This probably works for the time being.
Creating a row for every random user that signs in might be an issue later- say we have some splashy press coverage and 10000 users sign in and leave a row for us to approve. It might be better to separate these requests into another table, but maybe it's no big issue.
What's the workflow for approval? will we need app UI for that or could we do it via a shell script?

The simplest approval way I see is to add API endpoint to list users, insert new users (filling only their emails) and change flags for existing users (is_active, is_superuser). Swagger will generate the UI and it's easy to use then. These endpoints will be available only to existing superusers, first ones are created based on that hardcoded hack (I guess we may just move list of very trusted emails to ENV variable instead of hardcoding it)
Good point about not creating new records in the users tab automatically, will try to implement something like that right now in this PR

Changed the workflow a bit so users table is not bloated too much but superusers are still can login (note: must configure that env variable on each real setup now)
next step is to create quick API endpoints so superusers can add emails to the users table manually so they can login later


Human-written responses: citation popover should wrap

At the moment if it's long it touches the edge of the viewport.
Site:

So these aren't actually citations but footnotes. I would rather just remove the hover altogether, and the brackets around the numbers, to make it more clear these are footnotes.

I very much like on hover footnotes, and actively dislike when a website doesn't have on hover footnotes, so that should be kept, as it's super useful. I'll remove the brackets, though

Update: Myles or Melissa does CSS


Sort by portal id - should sort as number values

They currently sort using string values, so the numbers are not sorted correctly, see

Maybe the simple-table should have some way of adding custom sort logic, so we can implement logic to sort ip adresses

Okay adding support for custom sorting to simple table.

The next release of hawtio-ui has support for custom functions.


Update dependencies to latest

test this

test this

Codecov Report

Merging #779 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   97.77%   97.84%   +0.06%
==========================================
  Files          32       33       +1
  Lines        3011     3294     +283
  Branches      254      476     +222
==========================================
+ Hits         2944     3223     +279
+ Misses         67       63       -4
- Partials        0        8       +8

Impacted Files
Coverage Δ

browser/model/jbosseap.js
98.09% <0%> (-1.91%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/model/cdk.js
99.22% <0%> (-0.78%)
:arrow_down:

browser/model/devstudio.js
88.49% <0%> (-0.7%)
:arrow_down:

browser/model/jdk-install.js
97.29% <0%> (-0.45%)
:arrow_down:

browser/services/data.js
99.25% <0%> (-0.27%)
:arrow_down:

browser/model/hyperv.js
100% <0%> (ø)
:arrow_up:

browser/directives/breadcrumb.js
100% <0%> (ø)
:arrow_up:

browser/model/kompose.js
100% <0%> (ø)
:arrow_up:

browser/pages/start/controller.js
100% <0%> (ø)
:arrow_up:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e332c04...e964e65. Read the comment docs.


Error with FluentCpp Feed: Failed to parse time string (max-age=2592000, public)

Hi,
I encountered the following error, when I tried to add the FluentCpp Feed to Miniflux:
Uncaught Exception: DateTime::__construct(): Failed to parse time string (max-age=2592000, public) at position 0 (m): The timezone could not be found in the database in miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Client/Client.php:699
Stack trace:
#0 miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Client/Client.php(699): DateTime->__construct('max-age=2592000...')
#1 miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Client/Client.php(225): PicoFeed\Client\Client->parseExpiration(Object(PicoFeed\Client\HttpHeaders))
#2 miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Reader/Reader.php(53): PicoFeed\Client\Client->execute('http://www.flue...')
#3 miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Reader/Reader.php(69): PicoFeed\Reader\Reader->download('http://www.flue...', NULL, NULL, '', '') in miniflux/vendor/fguillot/picofeed/lib/PicoFeed/Client/Client.php on line 699

I added a print_r($header); statement at the top of parseExpiration(), to get more Information about what get's passed in from FluentCpp:
PicoFeed\Client\HttpHeaders Object
(
    [headers:PicoFeed\Client\HttpHeaders:private] => Array
        (
            [server] => nginx/1.12.0
            [date] => Tue, 06 Jun 2017 10:36:09 GMT
            [content-type] => application/rss+xml; charset=UTF-8
            [content-length] => 44162
            [connection] => close
            [etag] => "cd595f0b4da900af27c43cb0cb91f4ef"
            [x-robots-tag] => noindex, follow
            [link] => <http://www.fluentcpp.com/wp-json/>; rel="https://api.w.org/"
            [last-modified] => Tue, 06 Jun 2017 03:20:33 GMT
            [vary] => Accept-Encoding
            [content-encoding] => gzip
            [expires] => max-age=2592000, public
            [x-acc-exp] => 600
            [x-proxy-cache] => MISS www.fluentcpp.com
        )
)

This prevents running Miniflux' Cronjob as well. Thanks for your help!

While picoFeed should not be producing an error here, the server is unquestionably broken: it is sending an Expires header-field when what it clearly intended to send was Cache-Control.


Update make-motion-more-natural-using-a-bezier-curve.md

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Thanks for you interest in contributing @SaikrishnaBijja :tada: However, we don't accept PR's to non English curriculum files. The English versions are translated into other languages on Crowdin. You can read more about it here. I would suggest to look over that and make this suggestion over Crowdin if you think it's appropriate. Thanks and happy coding :tada:


[5.1] [Serialization] Recover when a typealias can't be deserialized

Cherry-pick of #23419 to the 5.1 branch. Reviewed by @harlanhaskins and @slavapestov.
SR-9811

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 08595c78da301f2a18acdbba20bc2ff57f730bf5

@swift-ci Please test macOS

Build failed
Swift Test OS X Platform
Git Sha - 08595c78da301f2a18acdbba20bc2ff57f730bf5

@swift-ci Please clean test macOS

Build failed
Swift Test OS X Platform
Git Sha - 08595c78da301f2a18acdbba20bc2ff57f730bf5

@devincoughlin, the failures are in configuring? copying? scan-build helper files. Is this a known issue?

This isn't a known issue. It looks like other OS X PR tests are failing when copying other (non-scan-build) files, so I think something odd is going on here.

@dexonsmith, who's responsible for Clang CMake stuff these days?

I talked about this with @shahmishal and he is investigating. The CMake copy actions are getting killed. He is rebooting the node to see if that fixes the issue.

@swift-ci Please test macOS

@swift-ci Please test macOS


Cookies are leaking from the "should isolate cookies in browser contexts" test

Apparently, only in Firefox CDP.
Enable the following two tests:
  Cookie specs
    Page.setCookie
      ✔ should isolate cookies in browser contexts (122ms)

  DefaultBrowserContext
    ✔ page.cookies() should work (58ms)

Run npm run test:firefox:headless
Actual results:
  1) Cookie specs
       Page.setCookie
         should isolate cookies in browser contexts:
     Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [{"domain": "localhost", "expires": -1, "httpOnly": false, "name": "page1cookie", "path": "/", "secure": false, "session": true, "size": 21, "value": "page1value"}, {"domain": "localhost", "expires": -1, "httpOnly": false, "name": "page2cookie", "path": "/", "secure": false, "session": true, "size": 21, "value": "page2value"}]
      at Context.<anonymous> (test/src/cookies.spec.ts:240:24)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

  2) DefaultBrowserContext
       page.cookies() should work:
     Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 3
Received array:  [{"domain": "localhost", "expires": -1, "httpOnly": false, "name": "page1cookie", "path": "/", "secure": false, "session": true, "size": 21, "value": "page1value"}, {"domain": "localhost", "expires": -1, "httpOnly": false, "name": "page2cookie", "path": "/", "secure": false, "session": true, "size": 21, "value": "page2value"}, {"domain": "localhost", "expires": -1, "httpOnly": false, "name": "username", "path": "/", "secure": false, "session": true, "size": 16, "value": "John Doe"}]
      at expectCookieEquals (test/src/mocha-utils.ts:396:19)
      at Context.<anonymous> (test/src/defaultbrowsercontext.spec.ts:25:29)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Regressed since v21.10.0

@whimboo it looks like the root cause of this is that Firefox CDP does not isolate the user contexts.

The context is closed and re-created in getTestState so the second test should have blank state.

The context is closed and re-created in getTestState so the second test should have blank state.

Not for the page1cookie cookie given that this is added to the default context. In both tests we use the page and not context to set it. As such it will not be removed after removing a given user context. Or do I miss something?

@whimboo the default context is an incognito user context as well (see GetTestState)

@OrKoN would it be ok with you if we mark [defaultbrowsercontext.spec] DefaultBrowserContext page.cookies() should work as intermittently failing with CDP for Firefox? It's perma failing in our CI when I sync 22.4.0

@whimboo I have opened a PR to mark it as pass/fail


Inactive user placing order issue fixed #6407

Issue Reference
#6407
Description
Inactive user should not allow to place an order.

@papnoisanjeev
The warning message is not correct, please find the screenshot Here
The message should be like: Your account is Inactive by admin.

@papnoisanjeev
It's working fine now, please find the screenshot Here


Update README.md

My company has been added to the user-list.

I don't really want to have individuals on this list

This is my company, with multiple people being employed.

Yeah, but it is named after you using your full name, making it sound like a personal endorsement, which I am uncomfortable with.

Alright. Your project, your choice.


Python prompt as code = 1001 (going away), no reason

My code is like this,
connected = set()
async def live_server(websocket, path):
    connected.add(websocket)
    try:
        while True:
            if not q.empty():
                message = q.get()
                await asyncio.wait([asyncio.ensure_future(ws.send(message)) for ws in connected])
            await asyncio.sleep(1)
    finally:
        connected.remove(websocket)

async def main():
    start_server = websockets.serve(live_server, 'localhost', 5678)
    await start_server
    await room.connect() # Keep connected to another service

if __name__ == "__main__":
    asyncio.run(main())

When I connect from a browser, and refresh page, python will prompt as follows
Task exception was never retrieved
future: <Task finished name='Task-26' coro=<WebSocketCommonProtocol.send() done, defined at C:\Users\Misaka\AppData\Local\Programs\Python\Python39\lib\site-packages\websockets\legacy\protocol.py:433> exception=ConnectionClosedOK('code = 1001 (going away), no reason')>
Traceback (most recent call last):
  File "C:\Users\Misaka\AppData\Local\Programs\Python\Python39\lib\site-packages\websockets\legacy\protocol.py", line 471, in send
    await self.ensure_open()
  File "C:\Users\Misaka\AppData\Local\Programs\Python\Python39\lib\site-packages\websockets\legacy\protocol.py", line 726, in ensure_open
    raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedOK: code = 1001 (going away), no reason

I saw #397, That is to say don't treat close code 1001 as an error.
In addition, the program is currently running normally, I am not sure if this issue has an impact.

This exception is the expected behavior when the browser closes a connection.
Maybe it's logged because you never recover the result of asyncio.ensure_future(ws.send(message)). I'm not completely sure how to deal properly with tasks raising exceptions in asyncio.wait([...]). You'd have the same logging behavior with any other task that could raise an exception inside asyncio.wait([...]), so that part is really a question about asyncio.


Airbnb

Hey @Khanhquoc03 :)
Don't quite get what you mean by this issue.  Could you please add a description to the issue?
If you need any help please feel free to contact me.
Closing this as it does not quite make sense without a description.


Unusual learning curve

Hello, I try to finetune your model in another language but the loss of model both train and val set are 0 for first few epoches.
The loss curve

Is this normal or I do anything wrong?

Hello, I am having the same issue. I am trying to finetune it using a German language dataset and it is giving me almost exactly the same picture that you got.
Were you able to find a solution? (or explanation)
Thank you.

I think this come from the model loss function from e2e-coref

The model starts with predicting random result. So there is the peak at step 0.
Due to the loss function that try to only maximize the likelihood of positive prediction but ignore true negative case, the model can just predict "there is no mention in the document" and loss is remain at 0.
With some luck (I guess), the model firstly identifies some mentions and it's wrong. The loss is starting to increase.
After that the model can be train properly. The loss decrease until it's converge.

If you get the loss curve like I did, it's fine since the model already converged. (According to my curve, it start to converge after step 7,000)
But if the loss remain 0 after the training is conclude, I suggest to change your hyperparameters (or may be using new seed) and train your model again several times.
By the way, the best way to fix these is to fix the loss function to cover true negative case.


AttributeError: 'PokemonGoBot' object has no attribute 'position'

Expected Behavior
Bot runs
Actual Behavior
[2016-07-30 17:53:40] [x] PokemonGO Bot v1.0
[2016-07-30 17:53:40] [x] Configuration initialized
[2016-07-30 17:53:40] [x] The location given using -l could not be parsed. Checking for a cached location.
[2016-07-30 17:53:44] [#] x
[2016-07-30 17:53:44] [#] x
[2016-07-30 17:53:45] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#] x
[2016-07-30 17:53:46] [#]
Traceback (most recent call last):
File "pokecli.py", line 220, in
main()
File "pokecli.py", line 206, in main
bot.start()
File "/usr/src/app/pokemongo_bot/init.py", line 32, in start
self.stepper = Stepper(self)
File "/usr/src/app/pokemongo_bot/stepper.py", line 32, in init
self.origin_lat = self.bot.position[0]
AttributeError: 'PokemonGoBot' object has no attribute 'position'
My Configuration
{
"auth_service": "google",
"username": "x",
"password": "x",
"location": "40.762723, 14.025207",
"gmapkey": "xxx",
"max_steps": 5,
"mode": "all",
"walk": 10,
"catch_pokemon": true,
"debug": false,
"test": false,
"initial_transfer": 0,
"location_cache": true,
"distance_unit": "km",
"item_filter": "101,102,103,104",
"evolve_all": "NONE",
"softban_fix": true
}
Steps to Reproduce
Running it on my server.
Other Information
OS: Arch Linux // GNOME 3
Git Commit: 55390cfd7fcedace99c2c3d372b3790ef5b7cfd7

changing "location": "40.762723, 14.025207", to "location": "40.762723,14.025207", (removing the space) might fix this

I have the same error with the latest master branch .

The error is in pokemongo_bot/init.py.  The code to parse a lat/lon is incorrectly hard set to 6/7 decimal places, bombing if you have any less or more.  The below code changes it to 4-7 places, which if you search for a location in Google, it reports only 4 significant figures of decimal minutes.  In reality, it should be set to any number with an optional decimal.
diff --git a/pokemongo_bot/init.py b/pokemongo_bot/init.py
index 6dc13bb..f5eb002 100644
--- a/pokemongo_bot/init.py
+++ b/pokemongo_bot/init.py
@@ -333,7 +333,7 @@ class PokemonGoBot(object):
def _get_pos_by_name(self, location_name):
# Check if the given location is already a coordinate.
if ',' in location_name:

       possibleCoordinates = re.findall("[-]?\d{1,3}[.]\d{6,7}", location_name)

       possibleCoordinates = re.findall("[-]?\d{1,3}[.]\d{4,7}", location_name)
       if len(possibleCoordinates) == 2:
           # 2 matches, this must be a coordinate. We'll bypass the Google geocode so we keep the exact location.
           logger.log(

go to the slack chatroom then in #help someone will help you setup the bot correctly
closed: NOT A BUG

@gregtampa, I disagree.  There is no requirement that lat/lons have any specific number of decimal degrees, which the regexp requires.  There are no comments or documentation that state this 6/7 decimal degrees requirement, and Google returns 4 decimal places which means you will have many reported bugs with this.
It should match with or without a specific number of decimal degrees, and, in addition, bug #1854 means that this input and regexp should be changed to allow altitude anyway.  Please reconsider this bugs status.
Recommend a fix for an embedded json for location which has: location name, and lat/lon/altitude, documenting which one is prioritized.


Monitor tab shows no data

My Azure Functions monitoring tab shows no data for invocation logs, even though the function is up and running. Additionally, when pressing the "refresh" button the call seems to fail with 404 Not Found

The Function App is called "bushman", if you need to investigate this internally
Let me know if there are any more details I can provide you with

@ahmelsayed Could you take a look?

The issue is that there is a background indexing task that populates the Monitor tab, so you'll see a delay.

@lindydonna It's been a week and there is still no data showing up 😟

@ahmelsayed Could you investigate?

ah okay, sorry about that @flagbug. I think the problem has to do with having a hostId in your host.json. There must be some issue in the logging path that doesn't put stuff under the right key. Can you try removing that id from host.json and see if the data shows up?

ref: https://github.com/Azure/azure-webjobs-sdk-script/issues/1393

@ahmelsayed Thanks, that worked!
The Azure functions CLI automatically added this ID, maybe you should document somewhere that this has to be removed in order to get the logging working right now

@flagbug We hope to have this fixed within the next few weeks.

Closing in favor of https://github.com/Azure/azure-webjobs-sdk-script/issues/1393


[CARBONDATA-2714] Support merge index files for the segment

Completing and stabilizing Merge Index feature.
This PR depends on PR#2307

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
UT and SDV added

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6997/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5777/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5757/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7013/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5790/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5765/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7031/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5814/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7048/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5825/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5791/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7052/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5829/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7056/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7063/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5838/

retest this please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5845/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7072/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5806/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5849/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7089/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5866/

retest this please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5830/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7176/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5952/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7201/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5975/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7202/

@dhatchayani  can you provide the detail, this pr including both(level1 and level2) ?   as per the mailing list discussion : http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Discussion-Merging-carbonindex-files-for-each-segments-and-across-segments-td24441.html

@chenliang613 We are supporting only level 1 (within segment) as discussed in the community. level 2 (across segments) is not supported as it will be already taken care through compaction

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5866/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5867/

LGTM

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5868/


Is there anyway to have dynamic min and max dates?

Passing a scope variable to the attributes doesn't work.

Yes, check out at #52 .


PDFkit is not considering Image orientation details

The PDF generating is not considering the Image orientation details and printing the image in wrong ways.. How can I fix this?

Have you verified that this is an issue with pdfkit and not with the wkhtmltopdf library?
Please note that pdfkit is just a wrapper around the wkhtmltopdf library to allow it to be used in ruby.
I'm going to close this issue, but if you are able to reproduce the problem using pdfkit, but cannot reproduce it by directly executing wkhtmltopdf from the command line, then feel free to re-open it.

It worked well when I am giving an image path rather than the buffer.
I got this problem when Im trying to use buffer.
On Fri, Oct 11, 2019 at 7:23 PM Serene Yew<EMAIL_ADDRESS>wrote:

Closed #454.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

--
Thanks,
Mounika Kella.


dont mutate hash object when serializing

fixes: https://github.com/rails-api/active_model_serializers/issues/1834

Would it be possible to get this merged? We are using case_transform directly and got bitten by this.


Firebase functions for sendgrid emails for auth related email

Use firebase functions and sendgrid to send an email on account creation and deletion

Use the functions for:

Password Reset
Email Verification
Account Creation
Account Deletion
EBoard status change

Didn't do eboard as on further thought it didn't seem necessary


fix unclickable cause by corner bar

address issue  #132

@jamalex  found an issue with this solution, please don't merge until I address it in the next commit

@jamalex  OK, it's ready to merge


[Field] Base UI components link to hidden input id

In Checkbox, Switch, Select, the id points to the hidden <input> which causes a violation when clicking Field.Label and focus is not placed on the rendered control/button
Search keywords:

Could you provide a simple repro? I tried https://codesandbox.io/p/sandbox/jolly-violet-jy2zx3?file=%2Fsrc%2FDemo.tsx%3A12%2C36 but don't see any violations.

It happens in that sandbox

It does now indeed. Strange as I was looking at it before and could trigger the warning...


The plugin system prevents static NextJS builds

Describe the bug
With a static NextJS build, using output: 'export',, the redirects configuration causes a build error:
Error: Specified "redirects" cannot but used with "output: export". See more info here: https://nextjs.org/docs/advanced-features/static-html-export

To Reproduce
Steps to reproduce the behavior:

Download and install the starter blog. Upgrade to NextJS 13.2.4
Set output: 'export'
Try to build.

Expected behavior
I'd expect to be able to build a static site, even if I manually need to run some commands to have the 'watch mode' work with contentlayer

Sorry for the late reply here, but for future reference it depends on which particular functionality of the library is used. Aside from the newsletter API route, the other components do not require a backend server and will work in a static build. For an end to end demo of all the functionalities, you can check out my template blog and the instructions for a static build.


v1.9 backports 2021-02-17

v1.9 backports 2021-02-18

#14966 -- Revert kernel-check CLI (@joestringer)
#14991 -- Fix ENI compatibility regression between 1.7 <-> 1.8 (@tgraf)
~#14999 -- cilium: encryption fix, ipv4-pod-subnets without encryptnode fails (@jrfastab)~
#14994 -- iptables: Skip CILIUM_TRANSIENT_FORWARD for IPv6 (@pchaigno)
#14899 -- Install Cilium in kube-system on GKE (@pchaigno)
#14938 -- test: Avoid unnecessary restarts of unmanaged pods (@pchaigno)
#14942 -- test: Delete all unmanaged pods with a single kubectl delete (@pchaigno)
#14995 -- bpf: Enable monitor aggregation in complexity tests (@pchaigno)
#15010 -- test: Use Endpoint instead of EndpointSlice in 1.17 (@nebril)
#15008 -- backporting: Add support for forked cilium repositories  (@gandro)
#14902 -- datapath: Do not log when kernel config not found (@brb)

Once this PR is merged, you can update the PR labels via:
$ for pr in 14966 14991 14994 14899 14938 14942 14995 15010 15008 14902; do contrib/backporting/set-labels.py $pr done 1.9; done

test-backport-1.9

GKE seems to have hit two known flakes and one which I don't recognize, but seems unrelated to the commits here.
Suite-k8s-1.17.K8sDatapathConfig Host firewall Check connectivity with IPv6 disabled unknown
Suite-k8s-1.17.K8sServicesTest Checks service across nodes Tests NodePort (kube-proxy) with the host firewall and externalTrafficPolicy=Local #12511
Suite-k8s-1.17.K8sServicesTest External services To Services first endpoint creation #14996
https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4390/

retest-gke

The two host firewall failures have the error:
Cilium DaemonSet not ready yet: desired number of pods is zero

We don't have the kubectl describe ds cilium unfortunately, but when I saw the same error happen locally it was caused by the fact that we were not running in the kube-system namespace. It's not related to the host firewall per se, but to the succession of quick Cilium deployments as far as I could see.
Maybe we should backport https://github.com/cilium/cilium/pull/14899 and related PRs?

GKE hit the same known flakes again: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4394/
@pchaigno To me it makes sense to backport the above CI change. We can do it in the next batch however.
@jrfastab We removed #14999 from the 1.8 backport because there was an issue for it? https://github.com/cilium/cilium/pull/15011#issuecomment-780862805 Should I also remove it from this commit_

@pchaigno To me it makes sense to backport the above CI change. We can do it in the next batch however.

I'll mark the PRs for backport then.

@jrfastab We removed #14999 from the 1.8 backport because there was an issue for it? #15011 (comment) Should I also remove it from this PR?

I believe the #14999 fix is incomplete. I removed the needs-backport label and we should probably remove the PR from this set of backports. We can backport everything once we have the complete fix.

OK, I dropped #14999  and pulled in the latest backports to ensure GKE can actually get green.

The failing BPF check can be ignored, it's a warning due to a overly long commit message.

test-backport-1.9

@nebril K8s-1.17-kernel-4.9 (not GKE) hit the K8sServicesTest External services To Services issue now. Could this be related to https://github.com/cilium/cilium/pull/15010 somehow?
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.9/42/

retest-gke

retest-1.17-4.9

retest-1.17-4.9

Discussed in the Cilium community meeting: The K8sServicesTest External services To Services is also occurring on the master pipeline.
Therefore, this needs to be fixed in master first. Marking this ready to merge.


Update pipeline-faq.md

typo/broken link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65f0ab872102fe32c028852d--harness-developer.netlify.app