Fix the k8s discovery flaky test

Testing if the discovery refactoring https://github.com/prometheus/prometheus/pull/4013 fixes the flaky test.

after about 50 runs and no failures it seems that the k8s refacotring fixes the flaky test.


Docker not utilizing all cores effectively

Currently running around 40 containers on a 40 core machine. However, the load on the machine is pretty low and only two cores are ever at 100%. The system works fine on lower core count machines and also works when I individually cpuset each container to a core. Any known issues with cpu resource sharing?

Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This is all handled by the kernel. Certainly cgroups lets you assign processes to specific cores, but otherwise I'd let the kernel do what it does.
As far as the Docker daemon itself, it will by default only startup using a single core as this is the go default.

Okay thanks I'll handle this on my own then

As @cpuguy83 has also stated, whatever you run in containers has nothing to do with Docker itself when it comes to using all cores, it depends on the software you run and on the kernel itself.
The Docker daemon uses only one core by default. This will change when we switch to Go 1.5.
I'm going to close this issue now as I've seen containers scale to 32+ cores and there's really nothing to fix there.

It wasn't an issue with Docker but with the scheduler. Thanks to @cpuguy83 for the info


GLTF bone names are not imported properly

Godot version:
3.0.4
GLTF Exporter Version:
1.0 (Commit 618ad1f)
https://github.com/KhronosGroup/glTF-Blender-Exporter
Blender Version:
2.79
OS/device including version:
Windows 10 64-bit
Issue description:
In contrast to the DAE format, when importing a GLTF file exported in Blender, bone names are not properly imported in Godot.  Since bones are part of the nodes property of GLTF files and each node has a name, it should be possible to retrieve it.
Instead of the name of the bone, Godot generates bone names by enumerating them, i.e. "Bone 1", "Bone 2". This seems to be a hard-coded behavior, as can be seen in EditorSceneImporterGLTF::_generate_bone.
I also saw that commit d8765dd103b806129ff762480fc919f6727ad7ad changed the import process and introduced the numbering of bones.
Bones names can be used in a lot of ways and it's crucial to be able to identify them.
Steps to reproduce:

Create a mesh in Blender
Add an armature
Add bones and name them
Assign mesh to the armature
Export the file using the GLTF exporter (Export Animations, Export Skinning)
Import in Godot, look at the Armature node

Minimal reproduction project:
Bone Names.zip

Contains Blend file in root
Contains DAE file in ./dae
Contains GLTF file in ./gltf

I have a patch for this lying around.

Your samples don't actually have any animations, but these are my two patches:
Fix bone parent indexing.
https://github.com/fire/godot/commit/254ce87f5564b2e62725ee91e0a7355433fe9b41
Gltf2 bones have names!
https://github.com/fire/godot/commit/497351b19a34902fff5fa6f6841d395921ae06d7

Thanks a lot! I'll give it a shot. I made some adaptions myself but they don't cover the parent indexing. That will certainly help for my use case.
On a rather unrelated note: Unfortunately, Blender's glTF exporter also exports the Armature as part of the bone name, e.g. Armature1_bone1... I slightly altered the export plugin so that it just exports the bone name as is. If anybody is interested, I can upload it.
Not sure why they did that, since the name is optional anyway and it's not consistent with other Blender exporters like DAE.

I am working on gltf2 fixes. This is my branch https://github.com/fire/godot/tree/gltf2_names_2
I have it working when the animation is playing, but not the default pose. Please review and improve it.

Fixed by #20422.


Feature/issue 1526 manual 2.7.1

Summary:
Fix all known issues with manual for 2.7.1.
Intended Effect:
See summary.
How to Verify:
Check all those checkboxes.
Side Effects:
no
Documentation:
yes
Reviewer Suggestions:
anyone

Did you remove all mc-stan.org email addresses (if there were any)? That
checkbox is still unchecked.
On Friday, August 14, 2015, Bob Carpenter<EMAIL_ADDRESS>wrote:

Summary:
Fix all known issues with manual for 2.7.1.
Intended Effect:
See summary.
How to Verify:
Check all those checkboxes.
Side Effects:
no
Documentation:
yes
Reviewer Suggestions:
anyone
You can view, comment on, or merge this pull request online at:
https://github.com/stan-dev/stan/pull/1585
Commit Summary

Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
revised manual, completing issue #1526
chapter on prob funs, cdfs, ccdfs, rngs, moved vectorization here

File Changes

M src/docs/stan-reference/acknowledgements.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-0 (115)
M src/docs/stan-reference/algorithms.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-1 (2)
M src/docs/stan-reference/distributions.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-2 (286)
M src/docs/stan-reference/functions.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-3 (87)
M src/docs/stan-reference/introduction.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-4 (9)
M src/docs/stan-reference/preface.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-5 (2)
M src/docs/stan-reference/programming.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-6 (134)
M src/docs/stan-reference/stan-reference.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-7 (2)
M src/docs/stan-reference/title.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-8 (33)

Patch Links:

https://github.com/stan-dev/stan/pull/1585.patch
https://github.com/stan-dev/stan/pull/1585.diff

—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1585.

I thought I had, but it looks from grep like I missed one.
Fixed and pushed.

Bob

On Aug 14, 2015, at 7:52 PM, Jonah Gabry<EMAIL_ADDRESS>wrote:
Did you remove all mc-stan.org email addresses (if there were any)? That
checkbox is still unchecked.
On Friday, August 14, 2015, Bob Carpenter<EMAIL_ADDRESS>wrote:

Summary:
Fix all known issues with manual for 2.7.1.
Intended Effect:
See summary.
How to Verify:
Check all those checkboxes.
Side Effects:
no
Documentation:
yes
Reviewer Suggestions:
anyone
You can view, comment on, or merge this pull request online at:
https://github.com/stan-dev/stan/pull/1585
Commit Summary

Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
Merge branch 'develop' of https://github.com/stan-dev/stan into
develop
revised manual, completing issue #1526
chapter on prob funs, cdfs, ccdfs, rngs, moved vectorization here

File Changes

M src/docs/stan-reference/acknowledgements.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-0 (115)
M src/docs/stan-reference/algorithms.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-1 (2)
M src/docs/stan-reference/distributions.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-2 (286)
M src/docs/stan-reference/functions.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-3 (87)
M src/docs/stan-reference/introduction.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-4 (9)
M src/docs/stan-reference/preface.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-5 (2)
M src/docs/stan-reference/programming.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-6 (134)
M src/docs/stan-reference/stan-reference.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-7 (2)
M src/docs/stan-reference/title.tex
https://github.com/stan-dev/stan/pull/1585/files#diff-8 (33)

Patch Links:

https://github.com/stan-dev/stan/pull/1585.patch
https://github.com/stan-dev/stan/pull/1585.diff

—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/pull/1585.

—
Reply to this email directly or view it on GitHub.

@bob-carpenter, I'm going to leave this pull request open until we're ready to go.

Sounds good.  I don't have any more things to add, but you
never know what'll turn up.

Bob

On Aug 17, 2015, at 7:24 PM, Daniel Lee<EMAIL_ADDRESS>wrote:
@bob-carpenter, I'm going to leave this pull request open until we're ready to go.
—
Reply to this email directly or view it on GitHub.


Fixed typo in spotiflow.model.predict

What type of PR is this? (check all applicable)

[ ] Bug Fix
[ ] Feature
[ ] Optimization
[ ] Documentation Update

Description
Related issues (if applicable)

Related Issue #
Closes #

Thanks!


Typo in SerialTreeLearner header

I believe this may be a typo in serial_tree_learner.h:
https://github.com/Microsoft/LightGBM/blob/master/src/treelearner/serial_tree_learner.h#L160
Should leafIdx be changed to leaf_idx? See the class declaration:
https://github.com/Microsoft/LightGBM/blob/master/src/treelearner/serial_tree_learner.h#L100
Happy to submit a patch if that is required.

@lgrz yeah, welcome to fix it.

Fixed in #1149.


Missing Id?

Hi, I found this project today and it looks really interesting. Nice work :+1:
In this example:
http://jsbin.com/fayenexoyu/1/edit?html,js,output
It seems to output an empty id. Is this a bug?
<div id="" class="target cycleCustomElement-MY-ELEMENT">

Could be. I'll investigate if it's Cycle or virtual-dom.

This issue was moved to cyclejs/cycle-web#3


Store receiver in variable when generating Python code

Is your feature request related to a problem?
Given this Safe-DS code
@Impure([ImpurityReason.Other]) fun f(param: Any?)

class C() {
    @Pure
    @PythonCall("$param.i($this)")
    fun i(param: Any?) -> result: Boolean
}

pipeline test {
    f(C().i(1));
}

the following Python code is created:
    f(safeds_runner.memoized_static_call(
        "tests.generator.memberAccessWithRunnerIntegration.C.i",
        lambda *_ : 1.i(safeds_runner.memoized_static_call(
            "tests.generator.memberAccessWithRunnerIntegration.C",
            C,
            [],
            {},
            []
        )),
        [safeds_runner.memoized_static_call(
            "tests.generator.memberAccessWithRunnerIntegration.C",
            C,
            [],
            {},
            []
        ), 1],
        {},
        []
    ))

The receiver is computed twice. Even though the call is memoized, we might still have to expensively compute and compare memoization keys. Moreover, the code is hard to read.
Finally, if the receiver cannot be memoized, the generated code is just wrong, since two separate instances are created.
Desired solution
Save the receiver once into a Python variable and reference it as often as needed.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
This is also needed for #1107.

:tada: This issue has been resolved in version 0.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
v0.14.0
GitHub release

Your semantic-release bot :package::rocket:


Probably a version miss-match .. the signing format changed .. Check the versions at the top of the README.. Let me know if you have any questions.

This is a duplicate of #123 closing for now we'll follow additional comments in the other thread @healthwallet @gleehokie


add script to generate config reference tables

For the Jenkins package, we maintain a configuration reference with our
documentation. Up to this point, we've generated Markdown tables with
configuration properties by hand, but the package is at the point where
it's no longer feasible for someone to do this by hand.
This commit introduces a script that walks the Universe package
repository and builds a single Markdown file with a configuration
reference. A user can run this script, get a single Markdown file in
their current working directory, and copy/paste the resulting table into
their documentation tool of choice.

For example, the latest version of the Jenkins package produces the following:
jenkins version 9
storage configuration properties

Property
Type
Description
Default Value

host-volume
string
The location of a volume on the host to be used for persisting Jenkins configuration and build data. The final location will be derived from this value plus the name set in name (e.g. /mnt/host_volume/jenkins). Note that this path must be the same on all DCOS agents.
/tmp

pinned-hostname
string
An optional DCOS agent hostname to run this Jenkins instance on (e.g. <IP_ADDRESS>).
No default.

networking configuration properties

Property
Type
Description
Default Value

root-url
string
The web address of the Jenkins installation (e.g. http://jenkins.example.com). This is used by Jenkins to refer to itself when creating links in emails, chat notifications, etc.
No default.

known-hosts
string
A space-separated list of hosts used to populate the SSH known hosts file on the Jenkins master.
github.com

virtual-host
string
The virtual host address to configure for integration with Marathon-lb.
No default.

https-redirect
boolean
Whether Marathon-lb should redirect HTTP traffic to HTTPS. This requires 'virtual-host' to be set. By default, this is false.
False

service configuration properties

Property
Type
Description
Default Value

cpus
number
CPU shares to allocate to each Jenkins master.
1.0

mem
number
Memory (in MB) to allocate to each Jenkins master.
2048.0

name
string
The name of the service to display in the DC/OS dashboard.
jenkins

advanced configuration properties

Property
Type
Description
Default Value

jvm-opts
string
Optional arguments to pass to the JVM.
-Xms1024m -Xmx1024m

role
string
The accepted resource roles (e.g. slave_public). By default, this will deploy to any agents with the * role.
*

docker-credentials-uri
string
An optional URI to be fetched and extracted that contains docker credentials (e.g. file:///etc/docker/docker.tar.gz).
No default.

docker-image
string
The Docker image to use for the Jenkins service. By default, this package will use the Velocity image in the Mesosphere organization on Docker Hub, which you must be authenticated against. Otherwise, specify the host, image, and tag for the Velocity image on your private Docker Registry.
No default.

mesos-master
string
URL of this cluster's Mesos master.
zk://leader.mesos:2181/mesos

Very very cool!

Saw two +1's here, going to hit the button.


[FLINK-28219] Refactor TableStoreCatalog: Introduce a dedicated Catalog for table store

We currently have developed a Flink's Catalog.
If we expose this Catalog directly to other connector developers, it is not good and there will be many unsupported interfaces and capabilities.
So here we create a tablestore dedicated catalog.

Q1: What are the criteria for choosing which interface not to implement. E.g. createDatabase is unsupported, which is confusing to me.

I was previously considering database creation all the way to lazy, but exposing it is more comprehensive.
So yes, I will change this.

O2: It seems like FlinkCatalog serves as a wrapper to interact with Flink. Does it only accept the 3-rd party ecosystem's database as the inner impl?

See above comment, we should change back to support the previous functionality


Unable to use Teams - crashes after about 20 minutes every time. Error caa70004

When I re-start my computer, Teams will work fine for about 20 minutes. After that, every time, I end up on the 'D'oh, something went wrong!' page, with error message caa70004.
I've tried reinstalling Teams from scratch and clearing all credentials from Windows Credentials Manager, but once I end up on the 'D'oh' screen, neither of the options there (restart or sign out) can make Teams work again.

Are you still facing this issue? Could you please share your Teams client log and re-open this issue?
Windows:
Keyboard shortcut: Ctrl + Alt + Shift + 1
Mac OSX:
Keyboard shortcut: Option + Command + Shift+1


Update Package.swift for CI.

OK to merge this and follow up with the sed script and spm.yml separately

The change will not fail the current workflows with sed, so we can have separate PRs for that.


Hotfix/minor changes

Pretty raw, but you can see the sim tests and how to use them. In particular, I think the simulate_next_epoch will be interesting to flesh out. Had to dig in a little to see how to do it with the new SDK.

This is great! Love the refactor and setup of sims!


fix readme of packages/safe-web3-lib

What it solves
Only fix readme of packages/safe-web3-lib.
Before fix, errors are happen when use ethAdapter
# example
const id = await ethAdapter.getChainId()
-> TypeError: Cannot read properties of undefined (reading 'getChainId')

I have read the CLA Document and I hereby sign the CLA


fix(OCPADVISOR-85): Render check icon if no risks

Implements https://issues.redhat.com/browse/OCPADVISOR-85.
Mocked at https://www.sketch.com/s/c5c07e06-f4a1-4c64-9cdf-8b12d8ac9ad5/a/3ooJoZz.
If there are no alerts or cluster operators, then render the green check mark with green label showing 0 upgrade risks.

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Switch to MIT license

This is the standard licensing which is used by any RingCentral-related community-focused tools, sample applications and code resources.

Fixed.


VRS references fix

Following discussions with and new links provided by @ahwagner this fixes the broken
https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json
entries to the now canonical
https://w3id.org/ga4gh/schema/vrs/1.2/vrs.json
A separate change should consider updating the VRS references from 1.2 => 1.3 (before a general variant format update to 2.x).

Merging this since this part is a bug fix.


Unexpected value 'displayName' at azure-pipeline.yml file

Hi,
I am following learning path and while performing an exercise as on the below given section, I am getting error on Azure DevOps at the time of running pipeline at CI build time.
_https://docs.microsoft.com/en-us/learn/modules/create-a-build-pipeline/6-create-the-pipeline_
Is there any change in the steps or I need to take care or something?
Attached Error msg at build time and azure-pipeline.yml file for refernamce.

Any help on azure-pipeline.yml file ..
Thanks,

Now... it is building the CI pipeline with above mentioned azure-pipelines.yml file.


Why my custom 404 page didn't work?

I tried to access the nonexistent url of my Github Pages, it redirect to the Github 404 page, not my custom 404 page. As the following picture shows:

I have read the official Github doc, see at: https://help.github.com/articles/custom-404-pages/, but it didn't work.
Another question is, I access the url: https://dbarobin.github.io/404, it shows, but why the Google Search don't display?
Thanks! Have a nice day!

Thanks! I fix it.

Thanks! I fix it.


Database provider

Database provider to have information about databases and their tables.

Newly added tables are not added to the table list. When I restart the IDE, the list of newly added tables disappears. I wish there was a refresh function.

@thinkingtree2 open up an issue.. and CC me on it. thanks

@thinkingtree2이슈를 열어주세요.. 그리고 제게 CC를 보내주세요. 감사합니다.

issue link
Added ability to rescan @Database or @PostgreSQL table list #1990
https://github.com/continuedev/continue/issues/1990#issue-2459954929


Use zstd as compressor of peaks

What does the code in this PR do / what does it improve?
Because sometimes peaks chunk is very large.
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

Coverage: 93.752% (-0.01%) from 93.763% when pulling c04615708bb4e0263aa6baaaf2a8a8cb0a124b01 on peaks_zstd into fca35df0ca2fbc52bf0aab2a60d3d41c3690a646 on master.


Error	XLS0503 Error in CarouselSampleEmbeddedView

When open CarouselSampleEmbeddedView.xaml appear the error XLS0503: A value of type 'ArrayExtension' cannot be added to a collection or dictionary of type 'IList'. It does not prevent the execution, however it's problematic to work with de xaml code looking at the whole page underlined.

Hi @AlfredoSolisFrausto
It's good point, i think.
I will have to change type of ItemsSource property to IEnumerable and create additional private property for internal needs =)

@AlfredoSolisFrausto try it now please

I don't know, why this issue appears at your machine. Probably, you use Win PC/Laptop.. because on Mac it works fine

if you like this plugin, you can set star on the project)

Yeah, you have my star!


⚠ ClamAV has degraded performance

In fc91136, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: ClamAV performance has improved in 7a33096.


Sync headers needed

Hey! Could you please trigger headers sync? This would trigger .def files generation which is required for https://github.com/microsoft/vcpkg/pull/29743 @NickNaso

Hi @legendecas , this is because git diff does not report changes for untracked files. #21 should resolve this.

Hi everybody,
after the merge of https://github.com/nodejs/node-api-headers/pull/21 I will make the new release v0.0.5.

Done in https://github.com/nodejs/node-api-headers/pull/22

Thanks a lot!


Deploy NuGet package fails if Source Alias has spaces

When artifact path contains whitespace "Deploy NuGet package" if fails as it does not use the whole path.
Path should be 'D:\a\r1\a_Malorama - Site\drop' not 'D:\a\r1\a_Malorama'
Example Source alias: '_Malorama - Site'

Error message:
##[error]Get-ChildItem : Cannot find path 'D:\a\r1\a_Malorama' because it does not exist.

rename?

v2.2.14


[SYSTEMML-1891] Prevent 'Script string is blank' exception for Python…

… toNumPy()

With this change, the expected results was observed for both toNumPy() and toPandas():
`
result.toNumPy()
SystemML Statistics:
Total execution time:  0.017 sec.
Number of executed Spark inst: 2.
array([[-60.],
[-60.],
[-60.]])
`

This is a quick work-around but I'm open to suggestions for better way or location to ensure non-blank script string.
cc @niketanpansare @asurve

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2054/Failed Tests: 1SystemML-PullRequestBuilder/org.apache.systemml:systemml: 1org.apache.sysml.test.integration.functions.parfor.ParForBlockwiseDataPartitioningTest.testParForColBlockPartitioningRemoteLocalSparseNegative

Note this change also resolved similar "Script string is blank" exception test failures for test_matrix_agg_fn.py and test_matrix_binary_op.py under src/main/python/tests.  The single test failure reported for corresponding pull request build is not applicable.

Resolved by https://github.com/apache/systemml/pull/659.


Pickup (remove) items on overlap without collision impact resolution

I'm trying to setup a simple system for overlap and collision detection in p5.play v3 before starting I read through the relevant wiki page on Contacts https://github.com/shakiba/planck.js/wiki/Contact
Check out this example of what I'm trying to do:

picking up an item should not cause the player sprite to be moved or rotated in any way
picking up an item should happen only when the item and player sprite actually make contact and overlap

https://molleindustria.github.io/p5.play/examples/v3.html?fileName=pickup.js
Behind the scenes I'm using shouldCollide to prevent collisions between the player sprite and any sprite from the items group. I also save the callback and run it after the time step.
pl.Fixture.prototype.shouldCollide = function (that) {
    // should this and that collide?
    const a = this.m_body.sprite;
    const b = that.m_body.sprite;

    let cb = _findContactCB('overlaps', a, b);
    if (cb) {
	    if (typeof cb == 'function') {
		    contacts.push([cb, a, b]);
	    }
	    return false;
    }
    cb = _findContactCB('overlaps', b, a);
    if (cb) {
	    if (typeof cb == 'function') {
		    contacts.push([cb, b, a]);
	    }
	    return false;
    }

    return true;
 };

// in the updateSprites function

world.step(timeStep || 1 / 60, velocityIterations || 8, positionIterations || 3);

for (let c of contacts) {
	c[0](c[1], c[2]);
}
contacts = [];

https://github.com/molleindustria/p5.play/blob/gh-pages/v3/p5.play.js
I know that the problem here is that shouldCollide is called in anticipation of possible contact between objects. Therefore sometimes the player will collect items to the left and right of it that it shouldn't be able to. Often items will disappear before they've come close enough to touch the player sprite. How could I fix this?

@zOadT I'm still stuck on this. Do you have any ideas of what I can do?

Hey!
I don't know how much you want to generalize your solution, but for this situation my initial idea to set this up would be a bit different:
Use sensor fixtures for the items and listen to the beginContact event (then you should be able to use the isTouching method on the contact). When you want the items to collide with each other you can define a non-sensor fixture on top of the sensor fixture (same position and shape) and prevent collisions with the player by setting appropriate collision masks (just be sure to set the density of the sensors to 0 in that case)
Otherwise, I think you have to check whether the fixtures collide manually (for polygons see this example, for more general cases you could maybe use the distance function) But you probably already tried this and did not like it 😅

@zOadT thanks for the advice! I used sensors.
https://molleindustria.github.io/p5.play/v3_examples/index.html?fileName=pickup.js


Update MemAdviceProvider::merge_roots() implementation to be compliant with specs

Currently, MemAdviceProvider::merge_roots() is infallible, but according to the specs it should fail if any of the roots is not present in the Merkle store (see https://github.com/0xPolygonMiden/miden-vm/pull/933#discussion_r1231094566 for original comment).
We should update it to be compliant with specs. I believe making it compliant with specs will break MMR implementation in stdlib. So, we should update the implementation too to make sure it works.

Solution of this issue turned out to be quite complicated.
MMR is the only structure which is not quite a tree, and functions which we have to manipulate the Merkle tree are not always perfect for MMR.
Implementation of the additional check in the merge_roots() allow us to be sure that the nodes which we want to merge are indeed roots, and this check is working for the SMT: there cannot be a situation when we want to merge a root and an arbitrary value. At the same time for the MMR it is a common situation: every add of the node to the MMR (MMR with even number of leaves) contains a merge of two nodes, which is done using merge_roots(), but neither of these nodes are roots.
The crutial thing is that every node with depth != 0 should be added to the MerkleStore (to get this node from the MMR we use mtree_get), but the only way to do so is to use the mtree_merge. That's why in my mind there are two options: make merging nodes a roots (by somehow adding them to the Merkle store) or merge them regardless of whether are these nodes are roots (just ignore the check).
So I have two solutions in mind:

Create new function (instruction, decorator) to be able to add a single node as a tree root to the Merkle store (maybe in a form like Node {parent: hash, left: zero_hash, right: zero_hash}).
Create essentially a copy of merge_root function but only for MMR without check of the roots.
Both solutions are bad (maybe the first is a little bit better, but still).

For me the first option looks slightly better: I think I can create a decorator, which can add a node to the Merkle set.
@bobbinth What do you think?

It's been a while since I looked at the MASM code of the MMR, but I thought all trees of the MMR with depth >= 1 are in the Merkle store. The only problem was the single leaf that was added to the MMR most recently when the number of leaves is odd. Such a leaf cannot be in the Merkle store because it has no children.
So, I thought that the problem arises only when we add a new leaf to the MMR and this leaf is odd. If that's the case, one solution could be to use an empty tree of depth 1 (where both children are [ZERO; 4]) and then insert relevant leaves into it (relevant nodes here would be the odd leaf and the new leaf).
This would work, but might be not super efficient (e.g., probably adds a 50 - 60 cycles).
Another solution could be as you've suggested to create another version of mtree_merge but which allows merging of nodes which are not in the store.
Also, we could just update the definition (and maybe rename) the mtree_merge operation to make this behavior explicitly allowed.
The last one is probably the simplest solution. The approach with adding a new operation may be cleaner, but I'm actually not sure about this.

Closed by #1260.


Cannot set profile picture

It's impossible to set an avatar. Not even for webhooks.

I'm unable to replicate. Is there a specific control that isn't working properly?

Clicking on Upload image does not show anything,
but when switching to another app and then back to Discord the upload window opens.
Nevermind, it seems to be another one of the many issues of recent BD updates.


chore(doc) minor change on typo

some minor change on the comment.

Thank you for your patch @ming535! Would you mind rebasing this to the current main? I've changed CI settings a bit so required checks should pass for first-time contributors.

Thanks, @ming535! It worked :)


🧩 Feature Request: Mask Preview/Production URLs from log output

Description
Upon execution of /usr/local/bin/npx vercel  -t ... Preview/Production URLs are currently exposed in the deploy logs. This may not always be desirable in public repos.
Vercel CLI 21.0.1
- Deploying colinwilson/static-exp

- Deploying colinwilson/static-exp

Inspect: https://vercel.com/colinwilson/static-exp/k9vv3xpaw [2s]

Inspect: https://vercel.com/colinwilson/static-exp/k9vv3xpaw [2s]
https://static-exp-k9vv3xpaw.vercel.app
https://static-exp-k9vv3xpaw.vercel.app- Queued

- Queued

- Building

- Building

Preview: https://static-exp-git-refs-headsmaster.colinwilson.vercel.app [10s]
To deploy to production (static-exp.vercel.app), run `vercel --prod`

Preview: https://static-exp-git-refs-headsmaster.colinwilson.vercel.app [10s]
To deploy to production (static-exp.vercel.app), run `vercel --prod`
set preview-url output
/usr/local/bin/npx vercel inspect https://static-exp-k9vv3xpaw.vercel.app -t ***
Vercel CLI 21.0.1

Vercel CLI 21.0.1
- Fetching deployment "https://static-exp-k9vv3xpaw.vercel.app" in colinwilson

- Fetching deployment "https://static-exp-k9vv3xpaw.vercel.app" in colinwilson

> Fetched deployment "static-exp-k9vv3xpaw.vercel.app" in colinwilson [950ms]

> Fetched deployment "static-exp-k9vv3xpaw.vercel.app" in colinwilson [950ms]

  General

    id		dpl_FcBSCF7JhEekRNYgYefdZdnCjr12
    name	static-exp

  General

    id		dpl_FcBSCF7JhEekRNYgYefdZdnCjr12
    name	static-exp
    readyState	READY
    url		static-exp-k9vv3xpaw.vercel.app

    readyState	READY
    url		static-exp-k9vv3xpaw.vercel.app

https://github.com/colinwilson/static-site-to-vercel/runs/1535193554?check_suite_focus=true#step:4:15
Request
Add a (boolean/string) parameter to mask the Preview/Production URLs from the output?
Do you think this could be useful?

@colinwilson Yes it might be useful to someone. The log seems to be output from vercel cli. I'll check if I can mask that url.

@amondnet Thank you.


Correctly detect if protocol is enabled when using netty-tcnative

Motivation:
We sometimes did not correctly detect when a protocol is not enabled when using netty-tcnative as we did not take into account when the option flag is 0 (as for example in BoringSSL for SSLv2).
Modifications:

Correctly take an option flag with 0 into account.
Add unit tests.

Result:
Fixes https://github.com/netty/netty/issues/7935.

@dschobel PTAL


Remove view from show episode

Codecov Report

Merging #147 into master will increase coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   88.91%   89.18%   +0.26%
==========================================
  Files         120      122       +2
  Lines        2861     2875      +14
==========================================
+ Hits         2544     2564      +20
+ Misses        317      311       -6

Impacted Files
Coverage Δ

CouchTrackerCore/Realm/GenreRealm.swift
42.85% <ø> (+25.21%)
:arrow_up:

...ore/Show/Episode/ShowEpisodeDefaultPresenter.swift
100% <100%> (ø)
:arrow_up:

CouchTrackerCore/Extensions/ShowIds+TMDBType.swift
100% <100%> (ø)
:arrow_up:

...ackerCore/Show/Episode/ShowEpisodeImageState.swift
100% <100%> (ø)

...rackerCore/Show/Episode/ShowEpisodeViewState.swift
100% <100%> (ø)

...ouchTrackerCore/Extensions/MovieIds+TMDBType.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1dee51...0f3edc0. Read the comment docs.


Unable to confirm email address.

Describe the bug
I am unable to confirm my email address. I never get the email.  I see the "Resend" button at the end of "Please confirm your email to enable alerts"

And then

It would be useful to say "Please confirm your email<EMAIL_ADDRESS>to enable alerts" rather than just "Please confirm your email to enable alerts"
I think I used that email, but always good to confirm.
Also, the fact that the snack bar is above other elements is in itself an accessibility error.

I went ahead and checked the email messenger and it shows it sent the email a couple of times. The snackbar above other elements can you point out how this is an accessibility error?


Update technical service failed

Hi Team,
We have CTMG v17.3 with Technical service 'Vmware sync'. We created marketable service based on this technical service. Also we having multiple subscriptions on the same marketable service. Now we want to add one/two more parameters into the existing Technical service. We deactivated the marketable service and tried to import same technical service. But unfortunately we are getting below error.

Please suggest

Hi @DashThink
As the error message says, technical service parameters cannot be not changed if the service is already in use. However, it is possible to add single parameters, with active subscriptions, as long as those parameters are not impacting existing definitions.
I am not clear which issue you are facing here. Can you give an example?

Hi @GoebelL
In the current scenario we have deactivated existing marketable service and tried to add one more parameter to Technical service. At the same time we face this issue. In simple words we need to add one more parameter into existing technical service.

We haven't faced any issues with adding parameters on existing services. We'd need more details about the present definition and about the parameters you try to add.

Any details? Does the issue still persist?


[doc] Add how to run locally.

I did rebase my commit, so this PR got corrupted. I have just cherry-picked your last commits.


[DO NOT MERGE]LP5523 Engine pr_instruction fix

The LP5523 does not like two-byte writes to the program memory. This PR changes lp5523_verify_pr_instruction, lp5523_set_pr_instruction and lp5523_get_pr_instruction to write the 2 byte instruction one byte at a time.
Also, added callbacks to imgmgr needed to signal that a DFU has started or stopped.

@JustineKH you should be creating two separate PRs for these, one for imgr stuff and one for lp5523 driver. Also, it seems that you are breaking up a combined transaction into two separate transactions, are you seeing issues with a combined transaction ?

@JustineKH Now that you have opened the other two PR's closing this one.


Refactor codebase

Expected Behavior
Break down the src folders content into multiple files/folders to improve readability
Current Behavior
The current repo is not too understandable as everything is stored in 2-3 files
Detailed Description
Break the codebase down into smaller more understandable chunks & functions. Adding comments to document the functions are welcome as well

I am happy to pick this one up. :)

Go ahead :)


Make unpack_nested_data a lot more flexible with supported column types

Now this can handle columns that are arrays of simple objects like strings, rather than just arrays of maps.

Hold on, I need to add two quick tests.


react-native-xcode.sh should still sort out IP when SKIP_BUNDLING

I'm using SKIP_BUNDLING=true when running on my iPad. This works fine, but it skips the entire react-native-xcode.sh script, which means the IP detection is never run.
Skip bundling should just skip the bundling, but still do the other steps.

Agree with @jliebrand, I'm faced with the same situation. Here are more info
Environment
OS:  macOS Sierra 10.12.6
Node:  9.0.0
Yarn:  0.24.6
npm:  5.5.1
Watchman:  4.9.0
Xcode:  Xcode 9.1 Build version 9B55
Android Studio:  2.3 AI-162.3934792
Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.4 => 0.48.4
Steps to Reproduce

Run SKIP_BUNDLING=true react-native run-ios --device
Wait app build and install on device
Open app

Expected Behavior

App loads bundle from local packager

Actual Behavior

App shows 'No bundle url present'
SKIP_BUNDLING shouldn't abort react-native-xcode.sh script too early to allow making important IP config steps.


Add Large Gallery Fails with DiagCode: 404#5152 on p2p calls

Describe the issue
The Recording Application I have adds Large Gallery Bot for Participant Video feed (to have up to 50 Video Streams in one Combined).
But I have an issue in the following scenario
Two users under Policy start a p2p call/ user A calls user B:
as soon as user B accepts the call user A is forwaded to voicemail and no call between the two parties is initiated, voicemail can be recorded just fine.
My logs show an exception of the AddLargeGallery() Method
exception: Code: 404
      Message: Unexpected 'Failed' status for operation 84630ecd-a5a8-4839-8dda-4575b3e0cc3d:
Not Found. DiagCode: 404#5152.@
      AdditionalData:
        subcode: 5152

@samarthasthana
@zhengni-msft
@ssulzer

What is subcode 5152?
What should I do to avoid this error?
Why does this error cancel the whole call? (I would expect it just stops adding the LargeGalleryApplication)

Graph SDK (please complete the following information):

Package
Version

Micrsoft.Skype.Bots.Media
<IP_ADDRESS>-alpha

Microsoft.Graph.Communications.Calls
<IP_ADDRESS>70

Microsoft.Graph.Communications.Calls.Media
<IP_ADDRESS>70

Call ID

781f5c00-ab72-4d8d-89e2-be110c58261d at 2024-02-27T09:03 UTC

To be more precise, the call ended 9 milliseconds after the addLargeGalleryView request arrived.

@Hunterjet Is there also an explanation as to why it would be ended after adding the large gallery view bot? It's a reproducable behavior on our end.

Thanks @Hunterjet.
Also I now found, if I wait for other participants than the bot itself to join and then add the large gallery it works as expected. So I assume there is some issue with large gallery added to p2p calls before any other participant is connected, even though the call of the bot shows it's established.

The behavior is definitely not what I would expect. Could this still be a bug in the Teams platform?

@InDieTasten @1fabi0 I might be misunderstanding the scenario. From looking at the call logs it seems to me that the reason the call went to voicemail is that one of the users rejected the call. It seems to be completely unrelated to the AddLargeGalleryView request. Are you saying this rejection didn't actually happen? If so could you elaborate on what the Teams Client behavior is for these two users? Does one of the user not pick up the incoming call? Could the call be timing out, or does it end unnaturally when the AddLargeGalleryView request is sent? What happens if the user picks up the incoming call, does it still end? Does it end while being established?

@Hunterjet user b answers the call and user A is immediately forwarded to voicemail it seems very much related to answering as user b can vary the timing for accepting/answering the call. Also it seems that the call end unnaturally when the AddLargeGalleryView is called, because without the AddLargeGalleryView it works fine( I would have to replay the scenario to log which users bot AddLargeGalleryView is called first etc.)
Also as I mentioned if the Bot waits for other participants to join, it also works fine.
Maybe some more info's about the logical setup of the recording bot:
As soon as call established: AddLargeGalleryView
Does not work
As soon as call established:
Does the participant list contain a participant that has other participant id than recorders participant ID?
yes: AddLargeGalleryView
No: wait for participant list Update -> AddLargeGalleryView
If you have any further questions please do not hesitate to ask, I would be happy to find the issue here 😃

@1fabi0 Thanks for the extra information! We did an investigation of this call in the back end and couldn't find anything unusual about it. Would it be possible for you to collect Teams client logs for the user that accepts the incoming call in the failure case? Let me know if you need some help to figure out how to do that. With that we can continue the investigation from the client side.
I also just want to confirm that I'm understanding the scenario correctly: for call 781f5c00-ab72-4d8d-89e2-be110c58261d, the user accepted the incoming call in the Teams client, but the calling user was sent to voicemail regardless.

@Hunterjet yes correct but both users in the scenario had the same policy assigned, and I'm not sure of which of the two users the mentioned bot call had this response code.
I will try to collect the teams logs in the next few days.

@Hunterjet I retried this today, to do the logging, now I don't have any problems with calling AddLargeGalleryAsync directl 🤔


The wpf VlcControl Have AirSpace problem

Now,in the new version,the wpf VlcControl is not a real wpf control,which have  airspace problem,how to solve it?thanks!

Closed as duplicate of #143


Show correct Pickup Location flag. Fixes UIORG-118

https://issues.folio.org/browse/UIORG-118

yarn run v1.9.4
$ eslint .
/home/jenkins/workspace/folio-org/ui-organization/PR-141/settings/LocationLocations/LocationManager.js
6:1  error  '@folio/stripes-components' should be listed in the project's dependencies. Run 'npm i -S @folio/stripes-components' to add it  import/no-extraneous-dependencies
✖ 1 problem (1 error, 0 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


eye tracking with tensorflow model

hello author,
cheers for the great work. i have some queries regarding your implementation. i read your article on how tensorflow overcomes the dlib landmarks. but while testing there are some false detections. is it because of the dataset used when training?

the tensorflow version of landmarks which you linked with other author works good. but it detects the keypoints even when the face parts are covered.  for example when i cover my eyes or nose, there is false detection. how can we overcome this?

Cannot necessarily point this to the dataset, beacuse this model always return 68 points without any confidence values for them. So maybe if the confidence could be taken into account and provided the dataset has these cases then I guess this problem could be overcomed.

Thank you for your reply,
How is this different from openpose or tfpose. When testing those models, the occlusion is considered, if the eyes are covered, it won’t detect those key points . Is it because of the coco dataset which consists of occlusion flag.

Cannot necessarily point this to the dataset, beacuse this model always return 68 points without any confidence values for them. So maybe if the confidence could be taken into account and provided the dataset has these cases then I guess this problem could be overcomed.

does this mean that if coco dataset is used with this model, it detects all keypoints? please can you tell me the difference between openpose and your method.


Relation of frame indices

From the lines here https://github.com/facebookresearch/r3m/blob/b2334e726887fa0206962d7984c69c5fb09cceab/r3m/utils/data_loaders.py#L77 , it seems possible for frame im0 to be after frames imts0/imts1/imts2 (or some subset thereof). Is this not a problem for the loss terms where we want to train G(e_0, e_t, l) to be higher than G(e_0, e_<t, l) and G(e*0, e*<t, l)?

Hi, thanks for the question. In short - yes it can on occasion happen but depending on the choice of alpha should be rare enough that it won't impact training. See this issue https://github.com/facebookresearch/r3m/issues/19 for a longer explanation.


How use the SignalR with token based authentication?

I want to use the token based authentication and I've been wondering how insert the token to the SignalR connection.
I've found some example where is token insert in the query string but I can't use it because the url could be find in some logs.
How can I send the JWT token to the HUB and validate it?
Thank you.

I've found some example where is token insert in the query string but I can't use it because the url could be find in some logs.

You have to use the query string. The WebSockets javascript client doesn't support custom headers.

I am wondering to add the JWT add the parameter of the client side function and validate it on the server for example:
What do you think about it instead of use the querystring? Is this way more secure than querystring?
$(function () {

    var chat = $.connection.chatHub;

    $.connection.hub.start().done(function () {
                    chat.server.send(JWT);
        });
});

 public class ChatHub : Hub
    {
        public void Send(string jwt)
        {
            var validate = ValidateJwt(jwt);

            if(validate){
                    //DO SOMETHING
            }
        }
    }

Thank you.

That wouldn't be any more secure that using the querystring, but it would work fine if you wanted to do it that way. In either case, unless you're using HTTPS, a man-in-the-middle attack could see the token. So if it's simpler to use the querystring, go ahead.
I do strongly encourage you to use HTTPS though, to prevent man-in-the-middle attacks.

@anurse Can you be more specific about how one might use querystring to pass the token? Is there an existing ASP.NET authentication mechanism that reads auth tokens from querystring?
I've been exploring the ChatSample and it appears to use cookie authentication to covert the hub endpoints.

@bromanko I don't know if there's a more elegant way, but I read the token from the query string in middleware and pass it on as though it were a regular Authentication header, e.g.:
https://github.com/mikebridge/IdentityServer4SignalR/blob/master/src/ChatAPI/Auth/JWTSignalRExtensions.cs
Then you can use the regular UseJwtBearerAuthentication call:
https://github.com/mikebridge/IdentityServer4SignalR/blob/master/src/ChatAPI/Auth/JWTInitialization.cs#L80-L87

I use the following
`      private Task OnMessageReceived(MessageReceivedContext context)
{
//DumpHeaders(context.Request.Headers);
var headers = context.Request.Headers;
var header = headers.Any(kp => string.Compare(kp.Key, CONNECTION_UPGRADE, StringComparison.InvariantCultureIgnoreCase) == 0 && kp.Value.Any(h => string.Compare(h, UPGRADE_WEB_SOCKET, StringComparison.InvariantCultureIgnoreCase) == 0));
if (header && context.Request.Query.ContainsKey(AUTHORIZATION))
{
// pull the bearer token out of the QueryString for WebSocket connections
_logger.LogInformation($"{nameof(OnMessageReceived)} processing websocket querystring authentication");
context.Token = context.Request.Query[AUTHORIZATION];
}
        return Task.FromResult(0);
    }

`
rich

@fuocor you don't need to manually look at headers to determine if the current request is a websocket request. There's a first class property on the HttpContext:
private Task OnMessageReceived(MessageReceivedContext context)
{
    if (context.HttpContext.WebSockets.IsWebSocketRequest && context.Request.Query.ContainsKey(AUTHORIZATION))
    {
        // pull the bearer token out of the QueryString for WebSocket connections
        _logger.LogInformation($"{nameof(OnMessageReceived)} processing websocket querystring authentication");
        context.Token = context.Request.Query[AUTHORIZATION];
    }

    return Task.CompletedTask;
}

@mikebridge Is it possible set the authorization header for SignalR connection from Javascript? How do you set it if you have used the authrozitation headers in middleware? The reason why I have used the jwt token in query string, because It was'nt able pass jwt as an authorization header from javascript side.
Thank you.

@Jenan no, the javascript websocket client doesn't allow it.

@davidfowl Thanks, I have removed my question because I don't read correctly, thank you.

i was looking into getting the jwt token in the header when creating the initial connection, and this seems to work. However, I can't find anything server-side that contains that token.
OPTIONS http://<IP_ADDRESS>:5000/hubs/events HTTP/1.1
User-Agent: Microsoft.AspNetCore.Sockets.Client.Http/1.0.0-alpha
Authorization: Bearer eyJ0e...
Host: <IP_ADDRESS>:56419
Content-Length: 0

HTTP/1.1 200 OK
Date: Fri, 06 Oct 2017 17:16:08 GMT
Content-Type: application/json
Server: Kestrel
Content-Length: 125
Allow: GET,POST,OPTIONS
Request-Context: appId=cid-v1:b91b490a-68aa-4451-829d-55b1076112c2
{"connectionId":"63284d81-88fa-4200-95e9-8171213cacc3","availableTransports":["WebSockets","ServerSentEvents","LongPolling"]}

GET http://<IP_ADDRESS>:5000/hubs/events?id=63284d81-88fa-4200-95e9-8171213cacc3 HTTP/1.1
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Key: Xsl/8XU4BT4NXsV3+MVDPA==
Sec-WebSocket-Version: 13
Host: <IP_ADDRESS>:56419

HTTP/1.1 101 Switching Protocols
Connection: Upgrade
Date: Fri, 06 Oct 2017 17:16:08 GMT
Server: Kestrel
Upgrade: websocket
Request-Context: appId=cid-v1:b91b490a-68aa-4451-829d-55b1076112c2
Sec-WebSocket-Accept: dlqwfi6JHEQZJsRq8xbDTcFv9kg=

The initial OPTIONS call is authenticated, and it creates the connection id, which can only be used once if I'm not mistaken. This means, that at this point, the server knows the mapping from the connection id to the ClaimsPrincipal of the user. Without the JWT token ever appearing in any logs. So the token is basically swapped out for a one-time use password (the connection id).
So in theory, if this could work, this should be more secure than the query parameter unless I'm missing something vital?
The first OPTIONS call and the GET with the connection upgrade need to be handled by the same server instance? Because another node won't know the connection id?
And for the long-polling transport it could just fall back to providing the Authorize header in each request.

I merged a change (0bafb304c2707739578e635bc9e00d0cd36420a7 18a65496b7adab684a9af2ac255c7128699c96ee) today that adds an API that allows to pass a JWT token when starting a connection. When using the C# client the JWT token will be passed in the header. When using the TS client the token will be passed in the header when sending an HTTP request with XmlHttpRequest (i.e. for negotiate, long polling - send/poll request, server sent events - send request) or in the query string if the underlying API does not allow setting headers (webSockets, eventSource used for the server-to-client channel in the ServerSentEvents transport) as the signalRTokenHeader queryString parameter. When using the TS client it is required to copy the token to the MessageReceivedContext.Token as shown in the sample.

I just wanted to point out that I've got headers to work with SignalR.
Has support for headers must been added recently? I can access the headers in the context when connecting.
I have been passing an "Authorization: Bearer xxxx"  header with an authentication token for my api, and resolved to use the method of copying the bearer token into a cookie to pass to SignalR. However, I didn't like having to clean up the cookies on my setup (it's quite complicated), so after a little experimentation I implemented the same OAuthBearerAuthenticationOptions as in my api and it appears to work (even though the Authorization is a header!)
This code is inside the Configuration(IAppBuilder app) section of my Startup class.
app.Map("/signalr", map =>
            {
                var hubConfiguration = new Microsoft.AspNet.SignalR.HubConfiguration();
                hubConfiguration.EnableDetailedErrors = true;
                map.UseOAuthAuthorizationServer(WebApiConfig.OAuthServerOptions);

                // Use the same bearer token authentication method as the general api.
                map.UseOAuthBearerAuthentication(new OAuthBearerAuthenticationOptions());

                map.RunSignalR(hubConfiguration);
            });

Hi @rexxmagnus ,
I am trying to also authenticate using a header token.
What I am not sure, is if your use case is to authenticate the entire SignalR endpoint to not "expose it" to everyone, or by the contrary you want to have the identity of the current user in the context of SignalR itself (which is my case).
In other words, I have the following code:
public class NotificationHub : Hub
{
	public async override Task OnConnectedAsync()
	{
		var identity = Context.User.Identity;

		if (identity.IsAuthenticated)
		{
			await Groups.AddAsync(Context.ConnectionId, GetGroupName(identity.Id)).ConfigureAwait(false);
		}

		await base.OnConnectedAsync();
	}
}

and I wonder how your code can be used in conjunction with mine to provide an Identity to SignalR. (assuming that is your aim)
Thanks in advance,
Mictian

@mictian, I use it for internal authentication and for obtaining the claims that are set by my api. Because it's using the oauth methods that the API uses to encode/decode them, the shouldn't be readable off-system anyway.
In my OnConnected method, I call another method that takes the Context.User and returns my own internal identity object (bear in mind this is only the constructor for the class, and that the strings must match whatever claims you set in your authentication setup):
public ApiAuthObject(System.Security.Principal.IPrincipal user)
{
    _Identity = user.Identity as ClaimsIdentity;
    if (_Identity != null)
    {
       if (_identity.FindFirst("AuthID") != null)
       {
           _ID = new Guid(_identity.FindFirst("AuthID").Value);
       }

       if (_identity.FindFirst("AuthUserName") != null)
       {
           _Username = _identity.FindFirst("AuthUserName").Value;
       }
    }
}

@rexxmagnus  how did you pass the oauth token to the connection in javascript?
$.connection  doesn't have headers

SignalR for ASP.NET (non-Core) doesn't support headers in the JavaScript client because browser WebSockets and Server-Sent Events APIs don't provide any way to send headers. We recommend using the query string (via $.connection.qs) to send authentication tokens.
FYI: The ASP.NET SignalR repo is at http://github.com/signalr/signalr. This repo is for ASP.NET Core SignalR, which is a new version of SignalR for ASP.NET Core.

@anurse  so in Core version, we can send the headers?

Ordinarily, there's no way to directly send the headers in that api, but I'm using an angular wrapper for the hub, and a custom http interceptor to add headers to any requests sent by angular's $http module. I'll try to post a minimum working example soon.

Thanks @rexxmagnus  looking forward to the code snippet :grin:

Here is my minimum example. I have an app that expands angular's http provider by adding an interceptor that injects the headers with the authorization and refreshtoken. The refresh tokens are handled by oauth in an api, so they're not entirely necessary for the context of signalr. You have to use the same oauth configuration as for your authorization if you are sharing the auth ticket between api and signalr.
The app provides a signalrFactory, to which the angular controllers can subscribe for events from signalr. Whether there's a way of injecting the headers into signalr without using the angular wrapper is something other devs will know about (and seems unlikely to be possible).
Hope this helps.

var app;
if (typeof (angular) !== 'undefined') {

    app = angular.module('myApp', ['SignalR']);//includes the signalr module mentioned below

    app.factory('authInterceptorService', ['$q', '$injector', function ($q, $injector) { //mirror this functionality in global.js $.ajaxSetup for non-angular calls
        var _handleRequest = function (config) {
            //Retrieve auth token from storage (or wherever you put it) and append to the transmission as a header.
            // The angular signalr wrapper will also contain these headers that can be read during the onConnect of the hub.
            var _authData = getFromStorage('auth') || {};
            if (_authData) {
                if (_authData.access_token && _authData.access_token.length) {
                    config.headers["Authorization"] = 'Bearer ' + _authData.access_token;
                }
                //Also including the refreshtoken if necessary
                if (_authData.refresh_token && _authData.refresh_token.length) {
                    config.headers["RefreshToken"] = _authData.refresh_token;
                }
            }
            return config;
        };

        var _handleResponse = function (response) {
            if (response) {
                if (response && response.data && response.data.Error) {
                    // Here I handle my custom (intentionally returned) error data
                } else return response;
            }
        };

        var _handleResponseError = function (rejection) {
            var deferred = $q.defer();
            if (rejection.status === 401) {
                //On auth failure, try to get the refresh token then re-send the original request
            } else {
                // Handle your error
                deferred.reject(rejection);
            }
            return deferred.promise;
        };

        return {
            request: _handleRequest,
            response: _handleResponse,
            responseError: _handleResponseError,
        };
    }]);

    app.config(["$httpProvider", function ($httpProvider) {

        // Bind the authinterceptor
        $httpProvider.interceptors.push('authInterceptorService');

        $httpProvider.defaults.transformResponse.push(function (responseData) {
            // Here I also run a method that transforms date strings into real dates to be returned to the methods that call $http in my controllers
            return responseData;
        });

        $httpProvider.useApplyAsync(true);//make data that returns at roughly the same time cause only one digest
    }]);

    //Signalr factory - https://github.com/JustMaier/angular-signalr-hub used for easy mapping
    app.factory('signalFactory', ['$rootScope', 'Hub',
        function ($rootScope, Hub) {
            var _broadcastEventName = 'signalr-service-event';
            //declaring the hub connection
            var hub = new Hub('myHub', {

                //client side methods called by the service
                listeners: {
                    broadcastMessage: function (message) {
                        $rootScope.$emit(_broadcastEventName, {message: message });
                    },
                },

                //server side methods for injection - call these with hub.xxx
                methods: ['send'],

                //query params sent on initial connection
                queryParams: {
                    // You can use the following to add querystrings
                    //    'token': 'exampletoken'
                },

                //handle connection error
                errorHandler: function (error) {

                    if (!!error.message && error.message == 'WebSocket closed.') {
                        // Fire disconnected event
                        // Handle the disconnection
                    } else {
                        console.error(error);
                    }

                },

                //specify a non default root (I have modified this, since the default is /signalr which omits the initial path when running locally
                rootPath: 'signalr',

                stateChanged: function (state) {
                    //console.log('state changed', state);
                    switch (state.newState) {
                        case $.signalR.connectionState.connecting:
                            //your code here
                            break;
                        case $.signalR.connectionState.connected:
                            //your code here
                            break;
                        case $.signalR.connectionState.reconnecting:
                            //your code here
                            break;
                        case $.signalR.connectionState.disconnected:
                            //your code here
                            break;
                    }
                }
            });

            //Exported object
            var signalFactory = {};

            // Allow controllers to subscribe to broadcast events
            signalFactory.subscribe = function (scope, callback) {
                if (typeof callback === 'function') {
                    var handler = $rootScope.$on(_broadcastEventName, function (event, args) {
                        callback(args);
                    });//Returns the destructor for the handler

                    //Unbind the event handler if the scope of a controller has been passed. Factories have no scope and thus are assumed to only exist once and therefore require no unbinding
                    if (scope) {
                        scope.$on('$destroy', handler);//unbind when the scope is destroyed
                    }
                }
            };

            // Client sending methods

            signalFactory.send = function (type, message) {
                hub.send(type, message); //Calling a server method
            };

            return signalFactory;
        }
    ]);

}

is there a sample on how to send the Bearer token in asp.net core from an angular 5 application?

There is no specific sample as far as I'm aware. There are some examples using Angular above as well as the JwtSample in this repo that shows the client and server (in Startup.cs) code necessary to flow a JWT token through WebSockets/Server-Sent Events

I'm trying to use the approach @davidfowl  suggested by doing a context.WebSockets.IsWebSocketRequest test but I'm always getting false on that. Any idea why that would be? That approach seems to be the cleanest so I'd like to use that as opposed to checking headers or comparing path value to see if the request is going to my hub. For some reason though, IsWebSocketRequest is always false.

You'll need to add app.UseWebSockets() above your app.UseAuthentication() call.

Just to be clear, the app.UseWebSockets() middleware is for me to have the ability to determine the nature of incoming request, correct? It's not really required for SignalR to work. I'm already using app.UseSignalR() and it's working fine.

Thats because UseSignalR() calls UseWebSockets(). However because you're using auth before SignalR you need to add WebSockets yourself before auth.
Although, now that I'm thinking about it, you might be able to move the auth after SignalR because we already run auth internally in SignalR, unless you have other things running before SignalR that need auth.

No that’s not recommended. Other things will fail


Proposal: Template values files

To limit the need to duplicate values it would be helpful to be able to template the values files.

Also, just want to throw this out there: https://github.com/hairyhenderson/gomplate
gomplate > sprig
richer library of functions. pretty much everything sprig can do, but more! =)

@osterman Thx for the info! gomplate looks promising :)
Just to sync up with you, it looks like there is a momentum to let helmfile close to helm's spec/behavior.
sprig sounded a good idea at the time we introduced it in that regard, but practically saying there can be more options.
That being said, I'm eager to providing options to use an alternative template engine like gomplate as long as it doesn't lock helmfile to single template engine, and the implementation is not so hard.
Actually, I prefer jsonnet as suggested in #92 here but it is attracted to no one 🤣
WDYT? Any input is welcomed!

Overall I would tend to stick with sprig unless we supported both.

@sstarcher I was considering to support this simply like:
releases:
- name: myrelease
   values:
   - myvalues.yaml

This configuration would just instruct helmfile to render a temporary yaml file from ./myvalues.yaml. The extension can be anything. So, even if it is .yaml, it's considered a sprig template. To be extra clear, it can be a standard yaml if the yaml doesn't include any golang text/template expressions in it.
An alternative to the above is:
releases:
- name: myrelease
   values:
   - template: myvalues.yaml.tmpl

This looks more explicit which I personally prefer, but I guess the momentum in helmfile community is not make it too explicit like that, similar to helm's own template(no .tmpl extension, no distinction between template vs regular yaml file).
WDYT?

I would transparently support it s in your first example.  Run the templates across all values files.

@sstarcher Thx. Sounds good. I've posted an enhanced example in https://github.com/roboll/helmfile/issues/119#issuecomment-384830608.

Just submitted #216 for this


[longtalk]: LINPS: a database for cancer-cell-specific perturbations of biological networks

Contact Details
<EMAIL_ADDRESS>Abstract
Screening for potential cancer therapies using existing large datasets of drug perturbations requires expertise and resources not available to all. This is often a barrier for lab scientists to tap into these valuable resources. To address these issues, one can take advantage of prior knowledge especially those coded in standard formats such as causal biological networks (CBN). Large datasets can be converted into appropriate structures, analyzed once and the results made freely available in easy-to-use formats. We used the Library of Integrated Cellular Signatures to model the cell-specific effect of hundreds of drug treatments on gene expression. These signatures were then used to predict the effect of the treatments on several CBN using the network perturbation amplitudes analysis. We packaged the pre-computed scores in a database with an interactive web interface. The intuitive user-friendly interface can be used to query the database for drug perturbations and quantify their effect on multiple key biological functions in cancer cell lines. In addition to describing the process of building the database and the interface, we provide a realistic use case to explain how to use and interpret the results. To sum, we pre-computed cancer-cell-specific perturbation amplitudes of several biological networks and made the output available in a database with an interactive web interface.
Convenient day for your Long talk.
Monday or Tuesday
Comment field
This is an example of an application that uses R/Bioconductor to build a model and make it available as an interactive Shiny application. Multiple Bioconductor data structures, annotation resources, and tools are essential for the work, which I will highlight during the presentation.

A link to the published article
Links to the app and docker image
Links to the source code: database and app

Checklist

[x] This Long talk has a Bioconductor focus or interest to Bioconductor users/developers.
[X] I checked and confirmed the BioC Asia 2021 Code of Conduct.

@MahShaaban Thank you for submitting the abstract.
The Assignees will start the review.
Once accepted by the Assignees, this issue will be closed and your abstract will be posted on https://biocasia2021.bioconductor.org/ .

Three Assignees checked this abstract and indicated that they would all accept it.
After adding your abstract to https://biocasia2021.bioconductor.org/ ,
I will send a comment addressed to you again.
Thank you for your contribution. @MahShaaban


Set appropriate security context for OpenShift

This would override helm's default security context values to make it work on OpenShift deployment.
Signed-off-by: Periyasamy Palanisamy<EMAIL_ADDRESS>

LGTM


Presentation/interaction layer for the model

It's important for both model evaluation (against subject matter expertise) and presentation to the public/planners/engineers to have some kind of way to interact with model predictions. This could be anything from a barebones map to a webmap with more interactivity. This could happen concurrently with model development—we could generate predictions from the benchmark model or use dummy data.

@alicefeng has done most of the work here.  The visualization folder contains scripts related to generating visualizations.  We still need additional polish and thought going into these.

Closing this now, we have at least a partial solution done.


Install plugin for Visual Studio Code - Insiders

The VSCode plugin can be used with the Insiders version by manually install it from the vsix package . It will be great to have cargo install-code do this for users.

I would say that, if you are using insiders, you probably should just install manually? We could add this to install-code, but then we'd need to decide what to do if you have both insiders and usual code.... It seems like we are hitting the point of diminishing returns here?

I primarily use the insiders build and what I’ve done is set code as an alias for code-insiders in my shell config. Then cargo install-code installs it to insiders.

Maybe add a cargo install-code-insiders?

Or just a command line flag --code-binary

We currently support several versions of VSCode when installing via xtask, and we're also on the marketplace. Closing.


Diners Club International

I went to:
https://www.getnewidentity.com/diners-club-credit-card.php
but the numbers in the DC International column did not validate.

The big question is: is this a reliable source?


Remove DisableProtectedAudioDG section

On RS1+, AudioDG runs unprotected. This regkey is no longer required to test unsigned APOs.

@nehinnan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks for the PR @nehinnan this should be live within minutes


Fixed changelog for Jakarta JSF

What does this PR do?
moved changelog entry from 1.27.0 to 1.28.0
Checklist

[x] This is something else

[x] I have updated CHANGELOG.asciidoc

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-11-17T13:20:09.131+0000

Duration: 4 min 32 sec

Commit: 63e3ac55d85058d592e9c3f5376c5559859baf14

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark test.

run compatibility tests : Run the JDK Compatibility test.

run integration tests : Run the APM-ITs.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Remove unused, accidentally added file

Codecov Report

Merging #51 (64ad284) into main (ce4e3a9) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   94.26%   93.98%   -0.29%
==========================================
  Files           3        3
  Lines         279      266      -13
==========================================
- Hits          263      250      -13
  Misses         16       16

Impacted Files
Coverage Δ

src/parsing.jl
98.79% <0.00%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4e3a9...64ad284. Read the comment docs.


Raise upper bound on hashable

Resolves #394
Generates a couple of warnings with hashable-1.4, because Eq is now a superclass of Hashable:
src/Relude/Nub.hs:115:1: warning: [-Wredundant-constraints]
    • Redundant constraint: Eq a
    • In the type signature for:
           hashNub :: forall a. (Eq a, Hashable a) => [a] -> [a]
    |
115 | hashNub :: forall a . (Eq a, Hashable a) => [a] -> [a]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Relude/Nub.hs:142:1: warning: [-Wredundant-constraints]
    • Redundant constraint: Eq a
    • In the type signature for:
           unstableNub :: forall a. (Eq a, Hashable a) => [a] -> [a]
    |
142 | unstableNub :: (Eq a, Hashable a) => [a] -> [a]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I can fix the type signatures with CPP if you like.
Checklist:

HLint

[ ] I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).

[ ] I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
[ ] I've generated the new .hlint.yaml file (see this instructions).

General

[X] I've updated the CHANGELOG with the short description of my latest changes.
[X] All new and existing tests pass.
[X] I keep the code style used in the files I've changed (see style-guide for more details).
[ ] I've used the stylish-haskell file.
[ ] My change requires the documentation updates.

[ ] I've updated the documentation accordingly.

[X] I've added the [ci skip] text to the docs-only related commit's name.

Hi @JackKelly-Bellroy !
Thanks a lot for your contributions 🙏🏼
Regarding warning, I would say yes, I think we should add the CPP pragma so we will keep our eye on this one.
Would you like to do that as part of this PR?

CPP is done. There are several ways to do this: write constraint over multiple lines, CPP away the Eq a,; CPP over the type signature; CPP over the whole function definition. I chose to CPP the type signature because it seemed the least likely to confuse code formatters and syntax highlighters. Let me know if this needs to change.


Migration staging updates

Closes: #17 #18

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9384ccd) 74.30% compared to head (30235e0) 82.08%.
Report is 48 commits behind head on main.

Files
Patch %
Lines

contracts/MigrationContractStaging.cdc
93.75%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   74.30%   82.08%   +7.77%
==========================================
  Files           1        2       +1
  Lines         144      240      +96
==========================================
+ Hits          107      197      +90
- Misses         37       43       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


regression fix - follow up from #182 for 1.0.x

follow up #182

created as regression - by https://github.com/opendevstack/ods-jenkins-shared-library/pull/66 (@renedupont )


Fix starlark function to not drop id annotation

We attempt to do this in https://github.com/kubernetes-sigs/kustomize/pull/4059.

Rebased on #474 and added a test.


Add support for Gitea tls client cert

This PR adds support for TLS client certificate authentication on Gitea remote source. Client certificate is expected to be available PEM encoded (.key and .crt).

@nitrotm Thanks for the PR.
Unfortunately, if your intent is to do user authentication in place of oauth,  it won't work since using tls authentication means that every user should have a different client cert to identify itself. But the remotesource is global and not per user so it cannot be used the authenticate users.

That's correct.
My use-case is slightly different as I am still authenticating the user based on oauth but at the same time, the external https endpoint of gitea is requiring a client certificate (to control who can have access to the repository apis, whether a server or client).

@nitrotm Understood. So:

This isn't a gitea thing and so should be added also to the other remote source types (gitlab, github).
I have some doubts about storing the certificates/keys inside the remote source type since it'll increase the size of the data. Perhaps we could map them from an outside source. For example by providing some list of certificates in the config file and on the local filesystem of every instance and then in the remote source just save the mapping name to the certs/keys. This will be less consistent since will require instances to be in sync (but this is already required for other cases).

It might apply to other kind of sources indeed (not github as far as I am aware, but I assume gitlab self-hosted or any other self-hosted solution could be configured to require a client cert).
After some trial period, I switched to another lightweight CI solution mainly due to the overhead of requiring a dedicated etcd cluster to run agola. Unfortunately, that was a cpu resource killer for our small k8s cluster and tiny CI needs (a constant ~15% additional cpu on 3 etcd node).
So if you don't feel like keeping this PR, I wouldn't mind.


net/haproxy: Bind frontend to interface

I would like the frontend to be listening independent from an IP address but to all IP addresses of a specific interface. Main use case would be to listen to an interface with dynamic IP address, like with PPP dial-up connections (xDSL).
From the HAproxy documentation, I think one should be able to enter <IP_ADDRESS>: and ::: as listen address first, and then add something like "interface pppoe0". I tried to add this through the Advanced SSL settings under Bind options but it seems dynamic content is not excepted there, see screenshot:

If such settings would work, it might even be nicer to just select one (or more) interfaces from a dropdown menu as an alternative to the "Bind address" text field so it does not get mixed with the SSL Advanced Settings (even though in the generated config file it will belong together).

Realized that "advanced mode" would allow me to add something to the bind options at the right place.
However, interface support was not build in to this version on OPNsense it seems :-(

'interface' option is not implemented in this version (check build options).

FreeBSD port doesn't seem to be aware of this option, at quick glance nothing that seems to match the description here https://github.com/opnsense/ports/blob/master/net/haproxy-devel/Makefile#L26

From the HAProxy documentation:

This is currently only supported on Linux.

Unless HAProxy adds support for this feature on FreeBSD, there's nothing we can do. :(

You can achieve this by using a virtual IP.
Interfaces -> Virtual IPs -> Setting -> ADD
Mode: IP Alias
Interface: Loopback
Network/Address: <IP_ADDRESS>/32
Deny service binding: Uncheck
VHID Group: leave empty
Firewall -> Aliases -> ADD
Name: HAProxy
Type: Port(s)
Content: 80 443
Firewall -> NAT -> Port Forward -> ADD
Interface: WAN
Protocol: TCP
Destination: WAN address
Destination port range FROM: HAProxy TO: HAProxy
Redirect target IP: Single Host or Network: <IP_ADDRESS>
Redirect target port: HAProxy
Services -> HAProxy -> Settings -> Vitrual Server -> Public servers -> edit your public server
Listen Addresses: <IP_ADDRESS>:443


how to handle 'mempool min fee not met'

Hi,
Let me know if this is not the right place to raise issues like this, I am posting here because I couldn't  find a discord link anywhere. I minted a realm and transferred the required btc amount. However,  after a few minutes I see the following error in the terminal window where I executed the mint-realm command: 'mempool min fee not met, 1665 < 2505'. I set a fee in my transaction from my wallet (which was already very low, probably too low).

Is there a way to resolve this?
Bumping the fee from mempool.space is very expensive, is there an alternative?
If I did bump the fee will the transaction finish, i.e. will I be the owner of the realm?
Are there some cool yarn cli commands to set fees or bump fees or check status?

thanks
PS where can I discuss ways to e.g. create a website around atomicals? I consider myself pretty technical, but these concepts go a bit too deep.

I got the same problem,did you sovle this?

@yirenheihei nope, not yet.


Fix cascade delete error

@ajcvickers can you take a quick look at this

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

entity-framework/core/modeling/relationships.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

entity-framework/core/modeling/relationships.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Reconfigured main.py it should be a bit more optimised now as well as added documentation.

Changed to correct error statement due to leaving except open ended causes other issues

Seeing as you haven't commented, I'll just merge it.


One-word component names

I've noticed that there are components named with only one word, this is strongly discourage by Vue style guide and W3C specifications because it could encounter conflicts in future HTML5 tags.
Maybe we should think about a refactoring of these components name? 😁

My opinion is: it would be good to refactor it, but how about the backward compatibility? I think it would be much easier to develop new theme (and we're designing one from scratch now) to improve this and other architectureal/component things; rather than pushing incremental changes to the existing theme
WDYT?

Yes, I didn't know about the "new theme" project until one hour ago when I talked with @filrak . Now that I know what's on the plate I could say yes, it makes sense implemented it in the new one along with other code improvements 😁

OK, I think we'll close it for now?

Could be closed if you don't forget it 😝 😇

@filrak please put it on Your checklist please :)

Isn't better to keep it open and just add a proper label and milestone, rather than keeping it on some private "TO DO" list?

@Igloczek @lorenaramonda no problem


Updating supported OSes and versions.

Updated supported OSes and versions and updated the format in the which they were displayed.

@Pooja-Harjani : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@genlin and @anandhms - Could you review the changes in your article(s)? Thanks.

#sign-off

Thanks @anandhms
@genlin Could you review the changes in articles/virtual-machines/troubleshooting/performance-diagnostics-vm-extension.md? Thanks!

Hi Kristine,
I am the new Program Manager for Azure Performance Diagnostics.
Could you kindly let me know if it would be possible to add me as a co-admin of the articles that are related to Azure Performance Diagnostics?
The article are under azure-docs\articles\virtual-machines\troubleshooting and they are

how-to-use-perfInsights.md
how-to-use-perfInsights-linux.md
performance-diagnostics.md
performance-diagnostics-vm-extension.md

Thank you for your help!
Thanks,
Pooja
From: Kristine Toliver<EMAIL_ADDRESS>Sent: Monday, September 14, 2020 9:28 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Pooja Harjani<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Updating supported OSes and versions. (#62374)
Thanks @anandhmshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanandhms&data=02|01|Pooja.Harjani%40microsoft.com|eeeb7c42a8c440bec64908d858cb1ff8|72f988bf86f141af91ab2d7cd011db47|1|0|637356976725017071&sdata=RqaKoW1cTr9PfCUUvLAgphrkx1KdVYuij67zPGSg%2BBA%3D&reserved=0
@genlinhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgenlin&data=02|01|Pooja.Harjani%40microsoft.com|eeeb7c42a8c440bec64908d858cb1ff8|72f988bf86f141af91ab2d7cd011db47|1|0|637356976725017071&sdata=849bl66AKKPf09kVxpq78BOyiyoHiqBbW%2FqPoi6h4kk%3D&reserved=0 Could you review the changes in articles/virtual-machines/troubleshooting/performance-diagnostics-vm-extension.md? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F62374%23issuecomment-692168525&data=02|01|Pooja.Harjani%40microsoft.com|eeeb7c42a8c440bec64908d858cb1ff8|72f988bf86f141af91ab2d7cd011db47|1|0|637356976725027065&sdata=k8KJiCTw8AVlmjHEukRjyUEn4qq8oZRbrAI90Y3nwzg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBQK6GP7FJWZARU4YCUAKDSFZAANANCNFSM4RELHEFQ&data=02|01|Pooja.Harjani%40microsoft.com|eeeb7c42a8c440bec64908d858cb1ff8|72f988bf86f141af91ab2d7cd011db47|1|0|637356976725027065&sdata=fzF5p%2F%2Fa7xaFkvdyO%2FZ%2BEFNHn2BgERPhZ4Oo%2B%2BA579k%3D&reserved=0.

 As a PM, you should be working in the private repository. There, in addition to many other good things, you can sign off on your own PRs.
In the public repo, the reviewer request is made automatically based on the metadata author attribute.
I'll send you email with information about linking your accounts and working in the private repo.

Thank you Kristine for the explanation, sorry I wasn’t aware. I look forward to your email with the info.
 As a PM, you should be working in the private repository. There, in addition to many other good things, you can sign off on your own PRs.
In the public repo, the reviewer request is made automatically based on the metadata author attribute.
I'll send you email with information about linking your accounts and working in the private repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F62374%23issuecomment-692206985&data=02|01|Pooja.Harjani%40microsoft.com|a924326ea4de47319ea908d858d52912|72f988bf86f141af91ab2d7cd011db47|1|0|637357020406141832&sdata=X7gve2qFePmaYr%2FbM4%2FFk5JYTNh8ETLYEBr6%2FLM0eNs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBQK6CI7KQ7KAJUF7OGSS3SFZIN3ANCNFSM4RELHEFQ&data=02|01|Pooja.Harjani%40microsoft.com|a924326ea4de47319ea908d858d52912|72f988bf86f141af91ab2d7cd011db47|1|0|637357020406141832&sdata=eCAMd%2BMuBpLXU2qAnL5NK5bGm6AFjpKi5exQYaEMWVw%3D&reserved=0.

The update in performance-diagnostics-vm-extension.md aligns with the update approved in how-to-use-perfInsights.md, so we'll merge the PR. I've sent information to the contributor about linking their accounts and working in the private repo in the future.


[Documentation]: Minor changes to the collation doc section

Contact Details
<EMAIL_ADDRESS>What happened?
Two very minor comments (the rest looks good):
the text "For column definitions, you can also use case insensitive or accent sensitive versions"
you meant to say "accent insensitive" instead of "accent sensitive".
Also, in the section heading "Character(SC) expansion", I'm not sure what (SC) means here and I think it should just be deleted.

there is a third comment that is correct but I'm wondering if it should be removed:
bin | BIN  requests data to be sorted in code point order, treating the first  character as a wchar. Code point order is a fast deterministic  collation.
Note that we don't include other options in this table that we do not currently support, such as _WS or _VSS or _SC.  Well, we don't support _BIN2 either, and the reason why is that the first character is encoded as a wchar, NOT in the server encoding of UTF8.  So with _BIN2, the first character is encoded differently from the rest of the string, and so the comment that it is sorted in code point order seems not quite correct, since the first character is not a Unicode code point.
In any case, we don't support it, just like we don't support _SC collations etc. either, which are not in this table.  I think bin2 should be removed from this table for consistency.
Version
main (Default)
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have fixed the first two points.
I am not sure about the third.
_bin2 collations are supported in the code; I reverse engineered it.  But I can still remove the reference.
These two uncertainties remain for me:

should I remove only _bin from the text or also the _bin2 collations?
There is a whole section dealing with "bin and bin2 that says that bbf_latin1_general_bin2 is supported. Should that chapter go as well?


CLI argument does not work if not administrator

Describe the Bug
When executing the WinDebloatTools.ps1 script from a non-admin shell (particularly cmd.exe) the arguments are dropped in the process of obtaining admin privileges. I am not a powershell savvy guy, but I thing the issue is in the Request-AdminPrivilege() function, the call is made to start the process passing "$PSCommandPath without $Mode
The log shows
Arguments: None, running GUI
How can this issue be reproduced?
Run the script from a non-admin shell:
CMD: powershell -File .\WinDebloatTools.ps1 CLI
PS> .\WinDebloatTools.ps1 CLI
Expected behavior?
Expected CLI argument to invoke CLI version...
Operating System
Windows 11
Operating System Version
Version	10.0.22621 Build 22621
Logs
WinDebloatTools-2023-11.log

@LeDragoX  - Thanks for the super quick fix on this!!! checked out develop branch and it worked like as it should
👍


Crash in Shots

INFO : SwitchController : <<<<< switch: s_switch4, State:0 >>>>>
INFO : SwitchController : <<<<< switch: s_switch4, State:1 >>>>>
INFO : Mode.attract : Mode Starting. Priority: 10
INFO : Machine : Shutting down...
INFO : Machine : Shutting down...
ERROR : asyncio : Exception in callback EventManager._done(<Task finishe...scriptable",)>)
handle: <Handle EventManager._done(<Task finishe...scriptable",)>)>
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/events.py", line 125, in _run
    self._callback(*self._args)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/mpf/core/events.py", line 530, in _done
    future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/mpf/core/events.py", line 462, in _run_handlers_sequential
    handler.callback(queue=queue, **merged_kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/mpf/core/mode.py", line 487, in _control_event_handler
    callback(mode=self)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/mpf/devices/shot.py", line 696, in reset
    self.jump(mode, state=0)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/mpf/devices/shot.py", line 655, in jump
    if state == self.player[self.get_profile_by_key('mode', mode)['settings']['player_variable']]:

From: https://groups.google.com/forum/#!topic/mpf-users/WgK4AOVWEvM

This is also a symptom of #838 since it also happens during fuzzing

fixed in dev


update versions

https://github.com/martindurant/adlfs/blob/569f9196956bf1cfef66f49d13650af19a2f1dfa/adlfs/spec.py#L1569
It seems we can write
            expiry=datetime.datetime.now(datetime.timezone.utc) + timedelta(seconds=expires),

The proposal comes from the fact that most of the warning
DeprecationWarning: Testing an element's truth value will raise an exception in future versions.  Use specific 'len(elem)' or 'elem is not None' test instead.

is related to datetime.utcnow(), from my Google search.

I already fixed one here.
But there are still some warnings coming from dep packages, which I think we should ignore for the "earliest" run.


Login PIN questions

Hey, thanks for making this python package.
Is there a guide on how to get the PIN for the login? When I went to incognito to login to the brokerage, there is a 2 factor authentication(sending a code to email or phone number) but when using that pin to try to login, I am unable to login.
I tried cloning my browser's cookies and using that as the cookie for this package but it did not work, not sure if there is another workaround to this pin.
Thanks in advance!

Nevermind, I figured it out, the PIN is the "Verify another way" PIN, not the 1 time pin.


How to transfer multiple filed one after another send in a loop and get the callbacks in same order (not by the completed first item)

Hello Team,
I am working on chat application where I need to send media files (Image Audio Video..etc) on S3 storage.
I an sending all files for upload in a loop using AWSS3FileTransferManager by creating multiple upload request, The upload are working with callbacks coming from files in order of the one that finished first.
I am looking for an input as to how S3 can manage to send me the finish callbacks in sequential order as the one i send the upload request order.
Example
Order I send

Image (10KB)
Video (2MB)
Image (10MB)
Video (50MB)
Audio (5MB)
Image (5KB)

Expected order received

Image (10KB)
Video (2MB)
Image (10MB)
Video (50MB)
Audio (5MB)
Image (5KB)

Observed order received
6) Image (5KB)

Image (10KB)
Video (2MB)
Audio (5MB)
Image (10MB)
Video (50MB)

Can there be some provision that even if the task is finished its work for upload the callback is received only after its previous task are completed and send or else queued. And if the previous task is timed out and failed then only the immediate next task is processed.
Appreciate if I can get any help on this.
Thanks,
Team Rappier

The progress callbacks will happen in the order that the SDK has finished uploading, which as you've noticed will result in callbacks for smaller files coming in before larger files. If you need an alternate order of callbacks, you'll need to implement that logic yourself.

Thanks @PavelSafronov , can you suggest how I can do this using Coredata. Actually I am implementing a chat application in which we send media and chat in the same order a whatsapp. What I want this feature is when media uploading its actually queued for sending chat not yet sent to the other person.
However once the media that is finished first (if the first media) then ill send that chat , (if not the first and someone in middle) I queue this item but upload state to YES and then when that point of call comes ill send actually chat. Coz XMPP don't rearrange stanzas but send it as it received to server.
Hope you can provide some direction.

This is more of a general application architecture/design question than a question about the SDK. I would propose asking your question to a more general audience like Stack Overflow.