install problem

onDebian (LMDE 5) i installed  dependencies.
pip3 install -U lnxlink doesnt work, but python3 -m pip install -U lnxlink.
but then i have errors:
$ python3 lnxlink -c config.yaml
python3: can't open file '/home/xxx/lnxlink': [Errno 2] No such file or directory

what can i do?

That is not the correct way to run it.
You have added the python3 before lnxlink which is wrong.
Once installed a new command is created called lnxlink which is located /home/xxx/.local/bin/lnxlink.
If you run it without python3, it should be working fine.

I added python3 because it was not working. Searched for it in .local/lib/python3.9/site-packages.
I found it now and called it with path.
After creating the config and changing the paths in it manually it seems no to work.
But nothing happens on mqtt.  I can login using mqttExplorer as user lnxlink.
Du i need to install something else for mqtt?

After the config is created, you need to edit it and restart lnxlink.
Please send me the command you are using to run the app and the logs that it shows.

It seems that the service keeps crashing.
Send me the latest logs using this command:
journalctl --user -u lnxlink -n 300 --no-pager

oh, silly me - wrong IP address, missed number due to bad working key.
Feb 06 17:15:39 xxx lnxlink[1205605]: OSError: [Errno 101] Network is unreachable
Feb 06 17:15:39 xxx systemd[2029]: lnxlink.service: Main process exited, code=exited, status=1/FAILURE

Now its working. But whats the meaning of  bluetooth_battery 55% on a Desktop PC without bluetooth? :-)

That's a great question!
For bluetooth battery I am getting the information from this command:
upower --dump | grep percentage

Maybe it's the laptop battery?
If you find out, please let me know.

Its a Desktop PC, no batteries there. I cannot see the connection between BT and Battery, even in Laptops.
$ upower --dump | grep percentage
    percentage:          55% (should be ignored)
    percentage:          55% (should be ignored)

I am not fully familiar with the upower command, but from my understanding it shows any device with battery and it's status. This includes bluetooth devices and laptop battery.
To fully understand what these values are you should run it without the grep:
upower --dump

In your case which is a desktop pc without any bluetooth device, you should remove it from your config or disable it on home assistant.

The  lines belong to keyboard and mouse (both wired).
Maybe you can test for the "(should be ignored)".
I have commented out the batterie modul :-)


Render the response from the API in the feedback box

The API response should be specified in the Swagger and returned by the API implemented by #123
One note here: the Swagger may not be correct :)

User Story

As a developer,
I want to display the content created by the new API,
So we can see the proper responses returned from the API.

Acceptance Criteria:

We want to display responses from the API.

Estimated time to complete:

3 hours

Activities Documentation

Date
Activity
Time Spent

2/12/22
Changed two files for the Get request
30 minutes

2/12/22
Tested it but there was issue, as data doesn't show up as expected
10 minutes

2/15/22
Researched iterating through JSON to check if something was wrong with my codes, but my codes were correct. I went ahead to add the other two files with different JSON to upload to the S3 bucket and tested them. It turned out that the fetch method doesn't have access to get data from links of the S3 bucket
1.30 hours

2/15/22
Adjusted my codes and tested if everything was working as expected with the Lambda API
10 minutes

Total time: 2.20 hours

Changes in files:

Comment out the Post request without removing it and change the method to Get request in the SubmitBtn.js file to get data from the URL.
In the FeedBox.js file, the map method is added to loop through JSON to indicate the data in the feedbox/analysis box.

Documentation (step-by-step):

cd frontend
Type as you like in the comment box access to the 'Submit 'button
You would see the data that came from the link, https://9u4xt4nqr1.execute-api.us-west-2.amazonaws.com/default/test in the analysis box


Swiping SmoothAppBarLayout causes Tabs to be swiped as well.

Hey Henry,
First of all, thank you for this super useful library.
I have seen the following behavior in the example app.
In the parallax example, where the size of the SmoothAppBarLayout/CollapsingToolbarLayout is defined to be of a specific value, the horizontal swiping of the view above the tabs seems to trigger a change in the tabs as well. I was wondering if this behavior is a limitation of the library or if it can be suppressed.

Hi @hvijayh
Nice catch. This is a limitation of SmoothAppBarLayout. I need to investigate more in android touch events in order to fix it. It's also related to clickable in SmoothAppBarLayout here https://github.com/henrytao-me/smooth-app-bar-layout/issues/105.
Thanks for considering using this library. Happy coding.

Cool. Thanks for the update. It'll be great if you could let me know if you find a fix for it.


undefined method `reverse' for nil:NilClass error

When pushing to a new repo, the repo will show up on the _catalog endpoint but there are no tags yet... so clicking on the item will give you a 500. We should handle this case.

fixed


[Test SmartScreen] New version: DelugeTeam.Deluge version 2.1.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Closes #83138

Microsoft Reviewers: Open in CodeFlow

@ppvnf Can't be added, still blocked.

Thanks for trying, maybe SmartScreen doesn't like FTP. Anyway, I'm gonna report it as safe and hopefully they are gonna fix it...


Add support for path and method based rate limiting for Routes

This does not make sense, does it? The route object does not have path or methods defined. So, it is hard to have custom rate limit description per route.
The path and method based rate limited can be achieved by generating with virtualhost level actions description entries with the path and the method and then, limits based on path and method. All implemented with the RateLimitpolicy. Something like the following:
---
apiVersion: apim.kuadrant.io/v1alpha1
kind: RateLimitPolicy
metadata:
  name: toystore
spec:
  rateLimits:
    - stage: PREAUTH
      actions:
        - request_headers:
            descriptor_key: "path"
            header_name: ":path"
        - request_headers:
            descriptor_key: "method"
            header_name: ":method"
  limits:
    - conditions:
        - "method == GET"
        - "path == \"/toys\""
      max_value: 2
      namespace: toystore
      seconds: 10
      variables: []

I think we can close this issue

I think with this issue it was focused on the WASM implmentation where we can inject the descriptors based on the RLP

I think we can close this issue, but not 100% sure. @maleck13 ??


adds jsx docs to site

Heads up, formatting is hideous. Not sure what configuration is broken here but I've created a separate ticket to fix it in the Trello here: https://trello.com/c/6hUqYdO8/97-code-should-be-formatted-on-pull-request


Don't share the secret with the failure URL.  They should know this.

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   58.62%   58.62%
=======================================
  Files           6        6
  Lines         406      406
=======================================
  Hits          238      238
  Misses        161      161
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c99efe...479518c. Read the comment docs.


Suggestion for additional test

I think there is a specific test case that could be added to this file to improve the testing coverage: https://github.com/exercism/php/blob/1df6486b88f85a77387f25fb2d97db8fbf98f967/exercises/practice/matching-brackets/MatchingBracketsTest.php
I do not know what the procedure for making this type of change is and would be happy to read through any documentation if I am missing some crutial step. Here is the test I would propose:
/**
 * uuid [ not sure how this is generated ]
 * @testdox Nested followed by pair
 */
public function testNestedThenPair(): void
{
    $this->assertTrue(brackets_match("if (foo[1] === 0){return true;}"));
}

The way I discovered this is that my original approach was only considering matching brackets from the outside-in (eg. [({})]), or matching pairs that are side-by-side (eg. ()[]{}). I knew this was a limited approach and expected to have some tests fail and was surprised that everything passed.
If there is some way I could contribute further to help get this (or something like it) included, I would enjoy slowly working through the process of learning how to submit a formal PR (or whatever process precedes that step). I do not wish to cause any annoyance though and understand that dealing with a very inexperienced individual is not always desirable.

Thanks for raising this issue. There is many things to say about that, in short:

Suggestions for additional tests in practice exercises should be discussed in the Discord forum
All tests come from a central repository and are used by 70+ tracks
Tests intentionally do not cover all edge cases

Looking forward to join the discussion in the forum!

Thanks, I'll have a look over at the forum. I must admit that when I first read the message a saw "Discord", I felt a bit deflated because I did not look forward to the noise/chaos that tends to categorize Discord conversations. I'm very encouraged by your edit though because I think a forum is is a much better place for this type of discussion.
Please let me know if I should close this ticket in the meantime (or feel free to close it on my behalf).

I discovered that someone else had already brought up the same point in the python track and the conversation didn't get very far. I've chosen to add a comment to the existing topic, rather than create another that would likely be viewed as a duplicate. https://forum.exercism.org/t/additional-test-case-to-matching-brackets/10295/6


Try not verifying tls

@JZebra yea, it's not a great solution, but I couldn't figure out anything else at the time and the exposure is pretty low since it's just the slack connection.
I think there were SSL upgrades that went out recently and older libraries don't support the newer certificates. So we could try updating our ruby version and networking libraries to fix this. But we might be blocked on that due to the lita libraries not being maintained.

@maalur that sounds annoying. I'm being negligent but I think we can use this for now. Try to tackle the upgrade during a gardening week or I can put it into a devops sprint.


Added two blogs and reduced the header size

Header size for sections was quite big. I reduced it a little so that it reads better.

LGTM

Great to hear :)


takeEvery / takeLatest arguments being passed differently from the example and docs

Any reasons of having other implementation than specified in docs?
It should be implemented as:
function* takeEvery(pattern, saga, ...args) {
  while(true) {
    const action = yield take(pattern)
    yield fork(saga, ...args.concat(action))
  }
}

But de facto:
function* takeEvery(pattern, saga, args = []) {
  while(true) {
    const action = yield take(pattern)
    yield fork(saga, ...args, action)
  }
}

So, the example will not work. It should be:
yield* takeEvery(actions.GET_ALL_PRODUCTS, checkout, [getState])

which is confusing as we expect passing arguments as for fork and other methods.

No there are no reason, that was as an implementation mistake. The correct is what's in the API and examples.
Thanks for pointing on this. already released a patch for this (and of course added tests cases for args passing)

Thanks a lot for such a fast fix! Works as expected now.

This got me wondering too.
Thanks for resolving this.

takeLatest.js still passing action as the last argument.
const yFork = ac => ({ done: false, value: fork(worker, ...args, ac) })

But example in docs mentions
const takeLatest = (patternOrChannel, saga, ...args) => fork(function*() {
  let lastTask
  while (true) {
    const action = yield take(patternOrChannel)
    if (lastTask) {
      yield cancel(lastTask) // cancel is no-op if the task has already terminated
    }
    lastTask = yield fork(saga, ...args.concat(action))
  }
})


[PL-48750] PL 1.33.x Release Notes

PL-48750
https://harness.atlassian.net/wiki/spaces/PD/pages/21724594239/NG+Release+SAAS+April+1st+2024+for+1.32.x-+Build
https://harness.atlassian.net/wiki/spaces/PD/pages/21734916118/NG+Release+SAAS+April+5th+2024+for+1.33.x-+Build
Merge requirements

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660fccb70939f07c42215b03--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660fe560ddb95408c1fffc4b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6615080a6901c0944afcde2e--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6617fdd6beb06b2ade7e1107--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6619031f01efaf0092fc1fab--harness-developer.netlify.app

@saifeemustafaqharness Suggest following up on two items before review:
https://harness.atlassian.net/browse/PL-46947 - check with Bharat for RN requirements
https://harness.atlassian.net/browse/PL-48935?focusedCommentId=710519 - check with Marko for RN requirements

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://661e35762350130bc1c2ce07--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://661e39084ae80800b02cc55b--harness-developer.netlify.app


Fix #45 Remove py dependency as pytest dropped it too.

I installed pytest-isort from git checkout, and no more errors. Messing up the import order in a file and running pytest again triggers the usual error. So no complaints from me. And kudos for the improved solution :+1:


Query: Fixes ResponseMessage not parsing the IndexMetrics as text in latest sdk

Pull Request Template
Description
Newer version of SDKs expects IndexMetrics header to come back as full text instead of base64.  A code path on ResponseMessage was still parsing the IndexMetrics as base64, causing FormatException error. This PR addresses that issue
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues
To automatically close an issue: closes #4396

/azp run


1.10 use mouseDrag not work，err is AttributeError: 'SelectReactor' object has no attribute 'doPoll'

env: windows10 system
err detail:
  File "G:\Anaconda\envs\mhxy\lib\site-packages\vncdotool\api.py", line 109, in callable_threaded_proxy result.raiseException() File "G:\Anaconda\envs\mhxy\lib\site-packages\twisted\python\failure.py", line 504, in raiseException raise self.value.with_traceback(self.tb) AttributeError: 'SelectReactor' object has no attribute 'doPoll'

env: windows10 system
err detail:
  File "G:\Anaconda\envs\mhxy\lib\site-packages\vncdotool\api.py", line 109, in callable_threaded_proxy     result.raiseException()   File "G:\Anaconda\envs\mhxy\lib\site-packages\twisted\python\failure.py", line 504, in raiseException     raise self.value.with_traceback(self.tb) AttributeError: 'SelectReactor' object has no attribute 'doPoll'

Do not support dopoll under win10, just replace it with Doselet IO model

Probably fixed by #289


Fix memory leak when hot swapping route files.

There is a slow memory leak when route files get hot swapped.  In a production environment, this can result in a complete meltdown of the node.js instance once it eats all the memory.
I'm not 100% sure what is causing the leak at this time.  The workaround is to only enable hot swappable controllers in a development environment, and turn off that feature in production.

A year later and I understand this a whole lot better.
The memory leak is happening because we're only deleting the cache of the route file, but not the objects that the route file creates, especially if another module references it.
I'm not sure that this is so bad.  All this means is that the option hot needs to be false when you're in production, because you probably aren't going to be swapping files in production.
What I'm likely going to do is allow this memory leak, but make the hot option default to false (you have to opt in to the hot swapping) and make very certain that it is clear the hot option is not intended for production use.


Add lotties

Added lottie animations for the homepage
Added lottie animation fallback images
Updated almost all images to use Vercel CDN

📝 Changed routes:

/team

(view full size)

Commit eeb946960b6332b47141400ceeeb8bb214d15361 (https://fairdataihub-website-2cjtl6caa-fairdataihub.vercel.app).


Feature/my tasks organizing

@dottorer Some more german translations for you:
circle.tasks.my.organizer-header
circle.tasks.my.volunteer-header


Typo in Programming Languages chapter

Section 3.2.

It starts by adding 2 numbers (that have been put in registers $t0 and $t1) and printing out the result. It then prints “Hello World!” Don’t worry, we aren’t about to make you learn how to actually program in this language! And if you don’t really understand the program, that’s also fine because many software engineers wouldn’t either! (We are showing it to you to help you to appreciate high level languages!)

This should be low level languages.

Not sure whether to actually consider this a typo or not, as both interpretations kind of make sense, best to check with an author to see what they were trying to say.

I remember this one coming up often, could be rephrased as:

We are showing it to you to help you to appreciate the purpose of both low and high level languages!


Bug Report: Action Builds DONT wORK

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as deleting the YoshiCrafter29 folder from AppData) before submitting an issue.
If you're using an older version of the engine, check if the bug haven't been already fixed
PS : the "everything goes black while changing state in developer mode bug" is not a bug, it's been designed this way to refresh all bitmaps between states to allow easier modding.
Which target are you using?

[x] Windows
[ ] Linux
[ ] Mac

What version of the engine are you using (Bottom left of the screen in main menu) ?
Actionbuild
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
https://github.com/YoshiCrafter29/YoshiEngine/actions
Please describe your issue. Provide extensive detail and images if possible.
---X on action build no work :(

Fixed the Linux one. Windows was already fixed.


ChangeNotifier

Any way to be notified of a type changing and so to update the widget ?

Seems to be in the 0.40 Change log.

It works already using box.watch() the new version will notify you immediately even when the changes have not been written to the disk.

Please reopen this issue if you still have problems...


backend/local: use range properties to optimize region range estimate

What problem does this PR solve?
Add a RangePropertiesCollector in pebble db so we can use the range properties to make region range estimation more precisely.
What is changed and how it works?
Since pebble support TablePropertyCollector . This pr implement RangePropertiesCollector like what implements in tikv at here.
~After https://github.com/cockroachdb/pebble/pull/963, we can fetch the user properties for each stable, so we can decode range properties from the user properties and use it as sample data to estimate range split.~
There is a small difference in this pr compare to the implement in tikv-importer. Since we only write level 0 sst files and avoid compaction, our range properties are not as precise, so the split ranges are not as precise as what in tikv-importer. But In our benchmark with different datasets, this approach is good enough.
Benchmark Result:
This pr use the following three data set to benchmark lightning performance:

tpcc. 14k warehouse tpcc csv files generated by go-tpc.
zipf. 10 billion rows SQL files generated by dbgen with following template:

CREATE TABLE `test`.`dbgen` (
        "id"    INTEGER,
        /*{{ rownum }}*/
        "g_id"  INTEGER,
        /*{{ rand.zipf(26, 2) }}*/
        PRIMARY KEY ("g_id", "id")
);

sysbench. table with about 500 million rows generated by sysbench prepare  --test=oltp_insert

The benchmark is running on a 40-cpu machine with source files on a nvme-ssd disk.  The bench cluster is v4.0.6 tidb with 1tidb/1pd/6tikv.
The master branch is run on the current newest commit aa83de1692ad384c3d243132d7d0eb28a14bd986
Result:

Data Set
Code Branch
Time Cost

tpcc
master
2h25m

tpcc
range-property
2h25m

zipf
master
15h40m

zipf
range-property
3h23m

sysbench
master
46m

sysbench
range-property
34m

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes
Release Note

Use range properties to make range split more precise with local backend

Waiting for https://github.com/cockroachdb/pebble/pull/963 to be merged, and add benchmark result

Please add a unit test that creating a pebble instance to test if property works. Rest LGTM

done. PTAL, again @overvenus

@kennytm  PTAL again


Workaround to allow the wizard to skip the matchmake/optimization/dam-generation step.

This will allow to the dashboard to skip the third step to be able to deploy applications with seaclouds if the user already has all the neccessary inputs (Deployment yaml, monitoring rules and sla agreements).
@andreaturli  could you take a look?

lgtm, thanks @adriannieto


Add support for property parameters

Codecov Report

Merging #58 (b7e5e9d) into main (396f73a) will decrease coverage by 0.47%.
The diff coverage is 89.88%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.27%   95.79%   -0.48%
==========================================
  Files          14       15       +1
  Lines        1128     1214      +86
==========================================
+ Hits         1086     1163      +77
- Misses         42       51       +9

Impacted Files
Coverage Δ

ical/parameters.py
88.88% <88.88%> (ø)

ical/types.py
95.66% <92.30%> (-0.23%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Couldn't sign in for both CN or US version, ERROR tunneling socket could not be established

[ERROR] Error: tunneling socket could not be established, cause=connect ECONNREFUSED <IP_ADDRESS>:8080
occurs to both version , so I couldn't sign in,what's that?
my Note.js's PATH is right

Seems to be caused by the proxy.

[ERROR] Error: tunneling socket could not be established, cause=connect ECONNREFUSED <IP_ADDRESS>:8080
occurs to both version , so I couldn't sign in,what's that?
my Note.js's PATH is right

Have you resolved the issue? I just met the same issue, which is annoying.

GFW.
Please try to use your phone as a hotspot and try again.


Failed to create plugin instance

I upgraded the plugin from v1.5.25 to next version
find some error

ERROR in ./node_modules/strip-ansi/index.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: failed to handle: failed to invoke plugin: failed to invoke plugin on 'Some(".../node_modules/strip-ansi/index.js")'
Caused by:
0: Failed to create plugin instance
1: Error while importing "wbindgen_placeholder"."__wbindgen_object_drop_ref": unknown import. Expected Function(FunctionType { params: [I32], results: [] })
@ ./node_modules/webpack-hot-middleware/client.js?path=/__webpack_hmr&timeout=20000 163:14-35
ERROR in ./src/main.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: failed to handle: failed to invoke plugin: failed to invoke plugin on 'Some(".../src/main.js")'
Caused by:
0: Failed to create plugin instance
1: Error while importing "wbindgen_placeholder"."__wbindgen_object_drop_ref": unknown import. Expected Function(FunctionType { params: [I32], results: [] })

Does the latest version fails?
cc @kwonoj Do you have any idea?

Isn't this occurred when we upgraded deps altogether? It still happens after revert?

Yeah it seems like.
@wz57c Can you confirm?

The same error occurred with version 2.5.27 of @swc/plugin-emotion.
When I reverted to version 2.5.21, the error stopped occurring.

Does the latest version fail?
cc @kwonoj Do you have any idea?

Yes, I updated to 1.5.29, but there is still an error

@kwonoj I think it's an issue of wasm-pack.
I reverted all dependencies except swc crates

Where do we use wasm-pack? Plugin itself builds with rust wasm target directly without wasm-pack.

Oh. Then I'm not sure about the cause...

I just noticed weired

Some(".../node_modules/strip-ansi/index.js")

Why swc tries to load js file as plugin?

I just noticed weired

Some(".../node_modules/strip-ansi/index.js")

Why swc tries to load js file as plugin?

No, this is my own dependency, I can remove it, but there is still an error, another error file is my project entry

I think there should be a minimal reproducible codes, either using codebsandbox or github repo.

Hit this issue with @swc/plugin-relay today, wanna say it worked fine a couple of days ago 🤔 🤷
https://codesandbox.io/s/currying-haze-gwn2z4?file=/index.js
run yarn start and you should see the error

Same issue with @swc/plugin-loadable-components after update > 0.3.25

I believe this occurs on every plugins with specific versions, so do not need to repeat each individual plugins. We need some investigations when / how this started happen.

@kdy1 I tried bisect this bit, and looks like something's going on with publish stage.
These are things I found:

Published binary is about 5.2MB

(https://unpkg.com/browse/<EMAIL_ADDRESS>

But if I locally build with cargo build -p swc_plugin_relay --target wasm32-wasi --release, it is actuallt ~1.4MB

Comparing those 2 binaries, it indeed have differences that published binary expects some exports unexpectedly

(Left: published plugin binary wat / Right: locally built release build binary wat)

Lastly I tried build script myself https://github.com/swc-project/plugins/blob/main/.github/workflows/publish.yml#L41

cargo build --all --release --target wasm32-wasi, it indeed generates 5.2MB binary instead of actually expected release build.
Not sure why building pkg individually vs. build all makes this difference.

Oh... I'll check

I'm hitting this issue with any version of @swc/plugin-styled-jsx from 1.5.26 and up. I've had to lock it to<EMAIL_ADDRESS>for it to work. Otherwise see the following error:
ERROR in ./src/components/index.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: failed to handle: failed to invoke plugin: failed to invoke plugin on 'Some("/[...]/src/components/index.js")'

Caused by:
    0: Failed to create plugin instance
    1: Error while importing "__wbindgen_placeholder__"."__wbindgen_object_drop_ref": unknown import. Expected Function(FunctionType { params: [I32], results: [] })

webpack 5.75.0 compiled with 1 error in 360 ms


[ENG-1091] Add files widget to schema-block-renderer

Ticket: https://openscience.atlassian.net/browse/ENG-1091
Feature flag: n/a

Purpose

To add files-widget to the schema-block-renderer component

Summary of Changes

Add check for files-input in read-only and editable mapper files
Add components for files that renders the read-only and editable versions
Update test to include files widget
Add SchemaBlockNode to default scenario that includes both contributors and files

Side Effects
N/A
QA Notes
N/A

Pull Request Test Coverage Report for Build 3541

26 of 46 (56.52%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 75.436%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/osf-components/addon/components/registries/schema-block-renderer/editable/files/component.ts
16
25
64.0%

lib/osf-components/addon/components/registries/schema-block-renderer/read-only/files/component.ts
7
18
38.89%

Files with Coverage Reduction
New Missed Lines
%

lib/osf-components/addon/components/files/manager/component.ts
4
71.07%

Totals

Change from base Build 3529:
-0.1%

Covered Lines:
8013

Relevant Lines:
9326

💛  - Coveralls


Always returns Error: unauthorized

Seems to be related to the addition of the Operational Yes/No question in the latest version of beacon.
I added passing an additional "operational" variable to the POST form in lib/index.js which stopped this error but the message isn't being sent. Will need to investigate further.

I tested this yesterday and didn't have a problem. Has that option been added since then?

It was introduced in the version of beacon that went live earlier this month.

Problem was caused by default HQ setting. It didn't have permissions for the group I was trying to send to.


DC Pet lottery

Description:
Adds Lottery for A batch of Discontinued pets
Changes:
Other checks:

[x] I have tested all my changes thoroughly.

no lotto for you


missing bytes in BLE advertising (Eddystone-UID)

Hi, I'm trying to advertise Eddystone-UID. I checked this issue with reference code example (examples/bluetooth/ble_adv).
I replaced service name sequence by Eddystone-UID sequence in example code and run it.
When byte 27 is 0x(2-0)(0-f), broadcasting sequence ends on this byte. (code below)

Expected UID:<PHONE_NUMBER>0000000000-112233445566
Observed UID:<PHONE_NUMBER>0000000000-112233440000

Chip is ESP32D0WDQ6 (revision 0)
Tested on master & 2.1.
static void hci_cmd_send_ble_set_adv_data()
{
	uint8_t adv_data[31] =
	{
          2,      // Len
	  0x01,   // Type Flags
	  0x06,   // GENERAL_DISC_MODE 0x02 | BR_EDR_NOT_SUPPORTED 0x04
	  3,      // Len
	  0x03,   // Type 16-Bit UUID
	  0xAA,   // Eddystone UUID 2 -> 0xFEAA LSB
	  0xFE,   // Eddystone UUID 1 MSB
	  19,     // Length of Beacon Data
	  0x16,   // Type Service Data
	  0xAA,   // Eddystone UUID 2 -> 0xFEAA LSB
	  0xFE, // Eddystone UUID 1 MSB
	  0x00,  // Frame type: URL
	  0x01, // Power - 1dbm - https://github.com/espressif/esp-idf/blob/master/components/bt/include/esp_bt.h
	  0x00, // NID 0-9
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x00,
	  0x11, // BID 0-5
	  0x22,
	  0x33,
	  0x44,
	  0x55, // 0xY5 - Y >= 2
	  0x66,
	  0x00, //RFU
	  0x00, //RFU
	};
	uint8_t adv_data_len = 31;

    uint16_t sz = make_cmd_ble_set_adv_data(hci_cmd_buf, adv_data_len, (uint8_t *)adv_data);
    esp_vhci_host_send_packet(hci_cmd_buf, sz);
}

Hi
try to compare your code and advertising settings with this example. Its edystone example and i think its better start for you:
https://github.com/espressif/esp-idf/tree/master/examples/bluetooth/ble_eddystone

Hi @MartinSadovy I think your data lenght is too small. It should be 23 bytes and not 19 like in your code.
This way client probably is trucating data to 19 bytes and then adds 2 0x00 bytes since last 2 bytes are reserved and need to be 0x00.

@chegewara Thank you!


Everedit URL incorrect

everedit link is correct. please enable multi-threaded downloading with aria2
scoop install aria2


Add option addUTF8

I would like to add an option 'addUTF8'.
If I tried to read the parquet files generated by this plugin from Apache Spark 2.1.0, string and timestamp columns are converted to binary type in spark and it is inconvenient.
If this option set to true, string and timestamp columns are stored with OriginalType.UTF8 and spark can load them as string column.
Default of this option is false, So I believe this option will not break compatibility.

Thank you, and sorry for being inactive for a while. LGTM.


Adopt CSS Classes From Initial Options

IMHO, the CSS classes from the initial option elements should be adopted to the respective li classes.
Would you accept a PR adding this, @zoltantothcom?

Could you please give me feedback here, @zoltantothcom?


Adding lifetime of the OATH software token

Adding the expected lifetime of the OATH software token generated by Microsoft Authenticator App.

@custorod : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close


IROCADERU
80

Describe the bug
A clear and concise description of what the bug is.
Information

Collection link/name
Contract standard
Chain

To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

OS: [e.g. iOS]
Python [e.g. 3.10.3]
Library Version [e.g. 1.0]

Additional context
Add any other context about the problem here.

Wrong description


Fix to non-deterministic behaviour by removing long-range side effects

Description
This PR achieve two things

It streamlines the CI so that we test [osx,windows]x[pip,conda]x[3.10] + [linux]x[pip,conda]x[3.8,3.9,3.10]. This reduces build times since osx and windows are reduced by a factor of 3, and expands the (much faster) linux builds to include 3.9.
We aim to remove all side effects from pandas plotting functions

(2) is an insidious bug which has been affecting all current PRs non-deterministically. Tests pass on local machines, but when lifted to the CI servers sometimes break in certain functions. The hypothesis is that pandas plotting is very inconsistent, for example .plot.box() creates a new axis, whilst .boxplot() uses the 'current axis' with e.g. plt.gca(). It is the latter functions which cause the problem by potentially getting a current axis somewhere else in the test suite, which depends on how fast/parallel/ordered the builds are. Failing tests can thus arise in either function depending on the current axis and the effect of both things writing to it simultaneously, so apparently healthy functions can fail. We aimed to control this by copious plt.close() commands, but this only partially solves the issue since presumably a new axis can be created in between the last plt.close() and the next plt.gca().
The solution is to go through the test suite and find any functions which have plt.gca() functionality, and to explicitly pass them a newly created axis. I have done this, and removed all plt.close() commands.
This has been re-visited in #235 #221 #222
Checklist:

[X] I have performed a self-review of my own code
[X] My code is PEP8 compliant (flake8 anesthetic tests)
[X] My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
[X] New and existing unit tests pass locally with my changes (python -m pytest)
[X] I have added tests that prove my fix is effective or that my feature works

Tests failed again with the now well-known but not understood limits mismatch in AreaPlot. Maybe #244 can resolve this...

...
Would we prefer creating new figure and axes at the start of test_AreaPlot (which is where things kept going awry, if not where the problems originated...)?

agree

The AreaPlot issue seems to have reappeared...

Yeah -- I spotted this in https://github.com/williamjameshandley/anesthetic/pull/243#issuecomment-1407439986. There are still a couple of uses of gcf and gca in the hist and bootstrap plots, but even if this were the issue, it wouldn't be consistent with our previous hypothesis


non-owner permalink updates

Changes

Commenting helper functions I made for social
If there is a solution fact, show that, otherwise show the solution statement. Always should the solution supporting statement, if it exists. Fixes #4153
Add the bottom border back to the share cta. Fixes #4173

@DoSomething/front-end

:shipit:!


refactor!: remove resolvePackageEntry and resolvePackageData APIs

Description

They are preventing caching optimizations that we can do. IIRC the setResolvedCache API isn't correct too and is causing bugs. (have to find the issue)
Additional context

After a lot of yak shaving, I finally got to what I wanted to do!

Admittedly I didn't plan this ahead since it would be better with a deprecation phase, but I think it's fine as these APIs are rather internal.
GitHub search for resolvePackageEntry and resolvePackageData usage
Unfortunately resolvePackageEntry affects some Vite plugins, and resolvePackageData affects two big projects: qwik and slidev. But they're usage are simple enough that the migration guide should work.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

IIRC the setResolvedCache API isn't correct too and is causing bugs. (have to find the issue)

I guess it's https://github.com/vitejs/vite/issues/12957#issuecomment-1546664484.

Yeah once this is unblocked we should be able to refine the API to be public again for sure 👍 (especially the package.json handling). I definitely have also thought about creating new @vitejs/* packages to really generalize it, but maybe that's for another day.

I think we can hold off merging for now and get qwik and slidev migrated first.

Out of curiosity, is there a detailed explanation of the optimizations blocked by this API, the bugs caused by it, and how removing it will fix them?
From a quick look, I have no packages depending on the API.

I've sent the PRs upstream to remove them. Will go ahead and merge this.


Updating Snapshots After Commit in Watch Mode

🐛 Bug Report
After committing changes without updating snapshots it is no longer possible to update those snapshots in watch mode.
It is an easy enough problem to work around by cancelling the watch and running jest -u, but I find I still bump into it every now and again.
To Reproduce
Steps to reproduce the behavior:

Commit changes to a function that is tested via snapshot without updating the snapshots
Run jest --watch and input a when prompted to run the full suite
The tests will fail (as expected) on the out of date snapshot
Input u to update snapshots
Jest will log that no changes were found and not update any snapshots

No tests found related to files changed since last commit.
Press `a` to run all tests, or run Jest with `--watchAll`.

Watch Usage: Press w to show more.

Expected behavior
I expected Jest to update the failed snapshots from the previous run.
Link to repl or repo (highly encouraged)
https://github.com/r-walsh/jest-snapshot-update-bug
The above repo already has changes committed with out of date snapshots, so start at 2 in the reproduction steps.
Run npx envinfo --preset jest
  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.9.4 - /usr/local/bin/node
    Yarn: 1.5.1 - /usr/local/bin/yarn
    npm: 6.0.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^22.4.3 => 22.4.3

Pretty sure this is fixed in #5696. Mind installing jest@beta to verify?

@SimenB Yup! Just verified locally. Thanks for the quick response


New UUID generation method, allowing for a fixed prefix on the FILE e…

New UUID generation method, allowing for a fixed prefix on the FILE entity_type.  New dictionary added to configuration files with prefix values. Issue #91

@yuanzhou One more change coming for this-- hold off merging until you hear from Karl.

Moved prefix from app configuration file to UUIDWorker code, reducing risk of accidental modification or absence during execution.  Ready for review.


npm continuatiion

Type: Feature Request
npm -new -install --i
VS Code version: Code 1.74.3 (Universal) (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T17:07:18.579Z)
OS version: Darwin x64 22.2.0
Modes:
Sandboxed: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/needsMoreInfo
Please describe exact problem and steps to reproduce.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


settings: Do not use bootstrap tabs in bots panel.

This PR replaces the boostrap tabs with our own tabs implementation in components.ts.
This is part of the bootstrap removal project.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@alya I think you can have a first look at this to see if we need any UI changes. For now I have just changed the tabs and nothing else.

Looks very plausible to me.

Hm, I'm finding it a bit hard to parse the tabs as controlling the area below. Maybe putting a line above the tabs would help?

While we're here, would it be easy to move this line to the Active bots tab?

Download config of all active outgoing webhook bots in Zulip Botserver format.

It relates to active bots, so structurally it belongs there.

Hm, I'm finding it a bit hard to parse the tabs as controlling the area below. Maybe putting a line above the tabs would help?

What do you mean by line here? Do we need a blank line, i.e. a linebreak or a thin horizontal divider?

While we're here, would it be easy to move this line to the Active bots tab?

Download config of all active outgoing webhook bots in Zulip Botserver format.

It relates to active bots, so structurally it belongs there.

Yeah, can do that. Do we want to show that text if the user has no active bots?

I think a thin horizontal divider was what she had in mind.
And yeah, we probably don't need that text if there are no active bots.

I think a thin horizontal divider was what she had in mind.

Heh, yep!

And yeah, we probably don't need that text if there are no active bots.

Makes sense to me.

Updated the PR as per feedback. I am not sure about the design of divider, so that may still need some tweaks.

Download config of all active outgoing webhook bots in Zulip Botserver format.

I guess we can actually further restrict when this is shown to situations where there's at least one outgoing webhook bot? Not worth worrying about if it's non-trivial, though.

The divider line looks OK to me, but the vertical spacing feels too tight. Can we add a good amount more space above? Possibly a bit more space below would look better as well.

While looking around the settings to see if there are dividers elsewhere, I noticed an extraneous divider here. Could you please add a commit to drop it?

Updated the PR -

The text is now shown only if there is atleast one active outgoing webhook bot.
Increased space below and above the header.
Added commit to remove the extraneous separator.

Merged, thanks @sahil839!


Disable scroll actions for embedded Flutter web app

I have created Flutter App and have implement the App about a iFrame in my website. The problem is that, when the cursor is about the iFrame and I try to scroll nothing happened. The Flutter App has no scrollable widgets, so I don't need scroll event in the iFrame.
I haven't found a way to make this possible with CSS or JavaScript Code. Is there anyway to make it possible to give the scroll event from the iFrame to the parent page?

Version:
Flutter: (Channel master, 2.1.0-13.0.pre.64)
Expected results:
When I scroll on the iFrame, the parent page should scroll.
Actual results:
When I scroll on the iFrame, nothing happened, because the Flutter App has no scrollable widgets.
Code to reproduce:
Flutter App:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'Sample text',
            ),
          ],
        ),
      ),
    );
  }
}

HTML Code:
The sample Text is only to make the site larger, so that you can scroll on the page.

Headline

            Lorem ipsum dolor sit amet

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.

            Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi. Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.

            Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi.

            Nam liber tempor cum soluta nobis eleifend option congue nihil imperdiet doming id quod mazim placerat facer possim assum. Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat.

            Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis.

            Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.

            Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi. Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.

            Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi.

            Nam liber tempor cum soluta nobis eleifend option congue nihil imperdiet doming id quod mazim placerat facer possim assum. Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat.

            Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis.

@dospringer
There's similar open issue describing your case, https://github.com/flutter/flutter/issues/65786.
Can you check and confirm if it resemble yours ?

@darshankawar Thanks for you answer :) Yes I have checked the issue and tried the solutions, but unfortunately it don't fix my scroll problem.

@dospringer Hi,
By referring that issue, my idea was to gauge if this can be closed in favor of it, for better tracking and avoid duplicates. That issue still seems to be opened and already has a priority assigned.

@darshankawar The issue #65786 is about that the iframe is not responding for touch events. This issue here is about, to disable the scroll function for the iframe.
I think that are two different problems.

@dospringer Thanks for clarifying.
Looking at your code sample, it doesn't seem to have iFrame related code, as I just see a Sample Text on screen. Could you update it so that we can properly address this issue ?

@darshankawar
I have added the iFrame related Code. Can it helps when I put the website online with the Flutter Web App inside?
Thank you for your help :)

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.2, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.2 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 8962f6dc68 (5 days ago), 2021-03-11 13:22:20 -0800
    • Engine revision 5d8bf811b3
    • Dart version 2.12.1

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.54.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 89.0.4389.82

! Doctor found issues in 1 category.

I think to fix this we need the framework to communicate to the engine whether a scroll event was handled. Currently, we unconditionally prevent default behavior of the scroll event in order to prevent the browser to do unexpected overscroll events, such as the bounce effect that Safari does.
/cc @goderbauer @Piinks

I have the same problem. I need the iframe not to "absorb" the vertical scroll gesture

Hi @yjbanov, would it be possible to bump the priority of this? For any website with a header and a footer, wrapping a flutter app in an iframe will be very weird, since the scroll basically stuck in the iframe.
Or could you point to the related code? I'm hoping to find a workaround or a fix.

Hi @terryl1900 @syfulin I have found a little "workaround" for this issue:

Build your project with flutter build web
Open build/web/main.dart.js
Search and delete s.addEventListener.apply(s,["wheel",q,r])

Warning: It's not recommend to edit build files, but this is the only way I have found to disable scroll actions in the iFrame. When you delete the Event Listener you are not able to scroll in the iFrame and this workaround works only for desktop.

Hi all, a higher priority for this would be great for the already explained reasons by @terryl1900.

 Wenn Sie den Ereignis-Listener löschen, können Sie nicht im iFrame scrollen und diese Problemumgehung funktioniert nur für den Desktop.

Also ich habe das ausprobiert, aber bei mir befindet sich der Punkt 3 in mant.dart.js nicht.
Konnte das Problem noch anders behoben? Ich stecke auch seit Tagen an diesem Problem fest.

@DennisSchmidt2
I think now the line is A.bC(this.a,"addEventListener",["wheel",r,s])},

Has there been any progress on this issue? It's really blocking us use Flutter in more places as we're forced to use the iFrame. See https://github.com/flutter/flutter/issues/32329

I have the same issue. I would love to know a solution for this.

Also hitting this.
Note that removing the "wheel" event listener does not work for mobile web embedding. Any suggestions?

Guys, any news about this issue ? this way embedding flutter web app is totally useless.

Ok, the only workaround who worked for me has been implementing the solution posted in this link, for me is optimal since it's completely detached from flutter code.
https://www.great-tit.com/disable-scrolling-in-iframe-when-scrolling-page/

Ok, the only workaround who worked for me has been implementing the solution posted in this link, for me is optimal since it's completely detached from flutter code.
https://www.great-tit.com/disable-scrolling-in-iframe-when-scrolling-page/
By the way on mobile still does not respond properly on scroll gesture. Still working on this solution.

@sommovir any luck on the touch devices (mobile)?

@dospringer Any luck with solutions for touch devices(mobile)?  also didn’t find A.bC(this.a,"addEventListener",["wheel",r,s])}, inside main.dart.js file.

nay new Info's here ? I have the Same Problem on my website

I am having the same problem

I solved it for my case.
My case: Flutter inside iframe, which is a part of another site. I don't need scroll at all, iframe always should be the full height.
My solution:
First, I investigated what A.bC(this.a,"addEventListener",["wheel",r,s])} code is doing inside dart.main.js. It is adding a wheel event listener to the flt-glass-pane html element and stops its propagation. I don't like the idea of doing corrections inside minified js file, so I found a bit less dirter hack (depends on point of view, lol) - I prevented attachment of wheel listener to the html element.
Added this to the web/index.html:

This code already fixes the issue of scrolling, but I will also attach a code, which dynamically makes the iframe full height.
(It is an adapted version of this article).

I took a MeasureSize widget from the article.
Added js function which sends a postMessage to the parent page in web/index.html.

 window.onFlutterHeightChange = (newHeight) => {
        window.parent.postMessage(JSON.stringify({
            type: "flutter_size_changed",
            height: newHeight
        }), 'http://localhost:3000');
    }

Added this dart-to-jst binding using official js lib for dart:

import 'package:js/js.dart';

@JS('onFlutterHeightChange')
external heightChanged(double height);

Added this:

window.addEventListener('message', (e) => {
      const flutterIframe = document.getElementById('flutter')
      if(!flutterIframe){
        return;
      }

      try {
        const event = JSON.parse(e.data)
        switch (event.type) {
          case 'flutter_size_changed':
            flutterIframe.style.height = `${event.height}px`
            break;
        }
      } catch (e) {
        console.error(e)
      }
    }, false);

The last piece - measuring widgets height and calling linked function:

MeasureSize(
    onChange: (Size size) {
      heightChanged(children.length * size.height);
    },
    child: e,
  )

I was unable to implement this solution today. As Flutter also targets being useful for web apps, using it properly inside iframes should in my view be easier than having to hack build files post-hoc... Even if more experienced devs than me can make it work (i couldn't even find the right code in the dart.main.js-file)

@Vitaliy-Svinchyak Thank you for sharing your solution. I tried it and for desktop it works great!
For mobile however I still have not found a way to block the scrolling events. This is due to the fact that on mobile there is no wheel event, but touch events. I cannot block all touch events because then a normal tap would also fail to be captured.
I really hope the flutter team can make time to fix this on framework level. For true web support the embedded flutter element should react the same as a normal web element. At this moment, is does not because the flutter element captures everthing.

Problems
Yea I've built a few apps for clients, the quickest way to release them, which is recommended in the flutter documentation, is to present them as an iframe. We have some scrollable content inside flutter but want the scroll to overflow past the iframe once flutter has reached the end, as expected in the web context. This means that the above workaround cannot work for us as it will stop the flutter scroll from working.
If documentation recommends we use iframes and embedded flutter as a part of a larger web app, then I expect for it to act as expected.
Workarounds
Does anyone know if there is a way to listen for unhandled scrolls at the top of the flutter widget tree? If so we could just listen for that and, if so, write a hack to propagate the scroll back to web.
An alternate workaround for now could be something similar to how google maps handles scrolling inside their embed? A little popup that tells the user they can hold a button (Like CMD) to allow scrolling to continue? Definitely a bit janky but I think it will be easier than users having to move their cursor in and out of the iframe in order to change what is scrolling.

@Vitaliy-Svinchyak Thank you for sharing your solution. I tried it and for desktop it works great!
For mobile however I still have not found a way to block the scrolling events. This is due to the fact that on mobile there is no wheel event, but touch events. I cannot block all touch events because then a normal tap would also fail to be captured.
I really hope the flutter team can make time to fix this on framework level. For true web support the embedded flutter element should react the same as a normal web element. At this moment, is does not because the flutter element captures everthing.

Did you find any solution for mobile yet? Dragging a dropdown menu with list of items scrolls the whole page instead of the just the dropdowns

Every thrid-party payment card form on web is iframe. And we have bad user experience in payment screen and payments have critical issue. I dont understand. How implement payments card form from banks on web in flutter when scrolling is broken? Any workeround? i need pointer-events enable because need form inputs but scroll with wheell or touch when iframe input is active completely messes up the layout.


handle scrolling by Y nodePosition

TODO:

fix 1 failing spec

Summary
tackles issue #304
Test Plan
When you have a big paragraph and you press enter in the middle, instead of keeping the focus in the middle of the page, the editor scrolls all the way to the bottom.
Steps to reproduce bug in current draft :

Go to https://facebook.github.io/draft-js/
Copy paste in a large continuous paragraph without any newlines in between.
Scroll to the middle of the big paragraph and press enter.
The editor will have scrolled to the bottom
This doesn't seem to happen consistently all the time, but I've seen it come up enough times on big paragraphs.

What happened to this issue?

+1 on getting this reviewed and merged

+1


proposal: math/rand: make global Seed a no-op

In Go 1.24, I propose to make rand.Seed (the top-level function) a no-op, controlled by GODEBUG=randseednop=1. (Because it is GODEBUG-controlled, specific programs could opt back to the old behavior using a //go:debug line, through Go 1.27 at least.)
The rationale is that rand.Seed is already deprecated, but it is preventing math/rand users from getting more secure randomness by default. There exist imported packages that call rand.Seed(time.Now().UnixNano()) “just in case”, and that makes math/rand fall back to the old Go 1 generator.
There no doubt exist some programs that use rand.Seed correctly for a reproducible simulation or the like, with only one goroutine at a time using the randomness, and being careful not to call any standard library or other packages that themselves contain even a single call to rand.Int or any other top-level function. It is possible, but it is fragile. (This is the same argument we made to auto-seed and deprecate Seed in the first place.)
Those programs can do what we said back then: instead of rand.Seed(s), use r := rand.New(rand.NewSource(s)) and pass r around. They can even name the variable rand to minimize code updates. They can even:
import mathrand "math/rand"
var rand = mathrand.New(mathrand.NewSource(seed))

Making those already-fragile programs convert to this form will remove the fragility, and it will let us fix the majority case of programs that don't care about reproducibility but are getting the insecure Go 1 generator when they could instead be getting the secure ChaCha8 generator.
If Go 1.28 retired the GODEBUG (following our “minimum four release” policy for GODEBUGs), then at that point we could make math/rand's top-level functions trivial wrappers around math/rand/v2's top-level functions, making them eligible for gofix to update. (Note that Go 1.28 would not arrive until the year 2027 - this is very much playing the long game.)

I am tangentially responsible for a codebase that does use fixed seeding to produce reproducible random numbers, and so I was initially concerned by this proposal, but I see that it's talking specifically about the global rand.Seed and would not affect the ability to instantiate a source with a specified seed.
That seems very reasonable to me. Expecting the shared global source to have a predictable seed, even though literally anything in the program could reseed it at any time, seems like an unreasonable expectation.

The current docs for rand.Seed promise that one can call rand.Seed(1) to achieve behavior from older versions of Go. Would that promise somehow be kept, e.g. by treating the argument 1 differently than other values? Or do you think it's defensible to break that contract? (I don't have any strong opinion either way)

Prior to Go 1.20, the generator was seeded like Seed(1) at program startup. To force the old behavior, call Seed(1) at program startup. Alternately, set GODEBUG=randautoseed=0 in the environment before making any calls to functions in this package.

I am tangentially responsible for a codebase that does use fixed seeding to produce reproducible random numbers, and so I was initially concerned by this proposal, but I see that it's talking specifically about the global rand.Seed and would not affect the ability to instantiate a source with a specified seed.

Indeed. I added "global" to the title. Thanks for pointing out the potential confusion.

The current docs for rand.Seed promise that one can call rand.Seed(1) to achieve behavior from older versions of Go. Would that promise somehow be kept, e.g. by treating the argument 1 differently than other values? Or do you think it's defensible to break that contract? (I don't have any strong opinion either way)

No, the promise would be broken, just with a 2+ year grace period. We already broke the promise for what happens when you don't seed, so it's the same promise, broken twice.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Have all remaining concerns about this proposal been addressed?
The proposal details are in https://github.com/golang/go/issues/67273#issue-2288189812.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group
The proposal details are in https://github.com/golang/go/issues/67273#issue-2288189812.

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group
The proposal details are in https://github.com/golang/go/issues/67273#issue-2288189812.


Add " N/A" option to ClinVar ID for variants

For some variants,  such as "Loss," a ClinVar ID is not available. This would allow that section to still be complete instead of leaving it as "None Specified."

It seems like this is allowed now but perhaps this issue didn't get closed?

This has been done!


Project status

Hi,
I just wrote an email to<EMAIL_ADDRESS>and it bounced and wanted to find out if the project is still active. There don't seem to be any new commits over the last 7 months.
Regards,
Eric

It’s definitely in limbo from what I can tell, been waiting months for my signed CLA to be acknowledged for a tiny docs build fix 🥃

So we can conclude this project is no longer active?

I've revived the project here. Not maintaining, just getting to a running state:
https://github.com/DatadudeDev/logai
working on a docker image now


Format semicolon-delimited value lists in labels

Whenever a feature’s name contains multiple values separated by semicolons, the label now puts each value on a separate line or separates them with an elegant bullet, for up to nine values, honoring the ;; escape sequence.
This implementation includes a general-purpose polyfill for a string replacement expression operator. We can use it for any purpose in an expression or filter but need to be careful about avoiding a combinatoric explosion in the size of an expression’s code. I’ve included a comprehensive battery of unit tests.

Kaser and New Square, New York

Machahe/Caiyuan/Liucandong/Houyukou/Wangshilou/Lichahe/Chahexin/Fukangxin/Qianyukou villages in Liangshan County, Jining City, Shandong, China

Viet Heritage Garden, San José, California

Columbus Cincinnati Road/Cincinnati–Columbus Road in West Chester Township, Butler County, Ohio

Southbound Interstate 275 at exits 63A/B in Union Township, Clermont County, Ohio
Fixes #665.

Test location below.
Performance measurement in Chrome on my laptop (multiple refreshes based on network tab in the Chrome debugger console
Current master (remote github): 1.9-2.1s
Current master (localhost): 1.9-2.1s
This branch (localhost): 2.6-2.9s
Approximately 37% slowdown.
Current/New:

(localhost link)
Cursory testing seems to indicate that these numbers are independent of location (high zoom on an ocean tile yields the same results).
I'm curious to understand if the performance difference is due to execution or building the style.json.

Cursory testing seems to indicate that these numbers are independent of location (high zoom on an ocean tile yields the same results).

Yes, the expression is only evaluated at runtime when loading a tile or reevaluating a symbol layer, so the impact is uniform everywhere. That said, it would be possible to limit this semicolon replacement to certain layers that are more likely to have semicolons in them. Or we could create a separate copy of each layer prefiltered to just the features that contain semicolons in them, but at the cost of additional layers that participate in symbol collision.

I'm curious to understand if the performance difference is due to execution or building the style.json.

The new code probably isn’t a significant contributor to the time it takes to build the JSON. (It happens in memory; there’s no file involved.) However, the step right after that loads the JSON requires more memory than before. Under the hood, GL JS compiles the expression to a type-safe, object-oriented data structure, which becomes more expensive as the expression becomes more deeply nested. Whenever a new tile needs to be displayed, a Web Worker needs to evaluate more massive expressions. The case statements should allow the evaluator to short-circuit most of the expression unless there are semicolons, but it still requires work to ferry around such a large data structure.
With a built-in string replacement operator, the performance concern would essentially go away. The operator’s performance would be similar to the upcase and downcase operators, which no one bats an eye about. Deduplicating values would require slightly more involved string splitting and array joining operators, but those probably wouldn’t have this performance impact either.

Pending anyone else's review of the code changes, I think it's a good idea to proceed with the proposed change to handle semicolon-delimited lists.  I'm concerned about the 1/3 performance drop for processing up to 9 semi-colons, though I understand that future improvements to MapLibre may make it possible for use to be more efficient about this. Perhaps we could reduce the 9 down to a number that captures the vast majority of the sane delimiter use cases while ignoring the silly ones that are probably tagging errors.

Should spaces before and after semicolons be trimmed, or is that considered a tagging error?

Should spaces before and after semicolons be trimmed, or is that considered a tagging error?

I believe that’s a tagging error. In fact, editors such as iD automatically remove the space when you touch the name.

Should spaces before and after semicolons be trimmed, or is that considered a tagging error?

The wiki mentions a single space after a semicolon being valid:
https://wiki.openstreetmap.org/wiki/Semi-colon_value_separator#Space_character_padding
I'm sure handling either ; or ;  would make for more complex code, but it could be a strategically good choice if it's doable.  On maps that don't replace semicolons with something nicer looking, mappers will probably find "First Name; Second Name" a bit more tolerable than "First Name;Second Name".

Editors strip out the space in general, but preserve it for certain syntaxes like opening_hours and *:conditional.

Editors strip out the space in general

Well iD does anyway.  I didn't have any problem including a space here with JOSM: https://www.openstreetmap.org/way/971815925

For place nodes, stats on prevalence:

# Semi-colons
Prevalence

1+ semicolon
444

2+ semicolons
9

3+ semicolons
6

4+ semicolons
3

5+ semicolons
2

6+ semicolons
1

For reference, the semicolon delimiter was first documented (without a space) in 2007, when it replaced a recommendation to use a comma.[^comma] There continued to be some uncertainty about the delimiter until 2008.

Editors strip out the space in general

Well iD does anyway.  I didn't have any problem including a space here with JOSM: https://www.openstreetmap.org/way/971815925

You can do anything you want in JOSM. 😉 But it too prefers a semicolon whenever it constructs a value list for you. The main reason space-padded semicolons appear in the database today is because Potlatch used to insert this delimiter when merging two ways. It was usually a mistake caused by its confusing shortcut for merging ways. Based on that behavior, mappers (including yours truly) used to manually insert the same delimiter for consistency, but it has been rare for a long time: openstreetmap/iD#941.
Documentation about space padding is pretty stale, dating back to when the same page pointed out that characters other than a semicolon were being used as value delimiters. This page is the product of past edit-warring and also flamewarring on the tagging list, so people have probably been hesitant to do much cleanup on it since. (The controversy was not about the choice of delimiter but rather about multiple-value lists in the first place.) I updated the documentation to reflect longstanding reality.
If there’s a strong need to support the space after the semicolon, then there will be an additional performance hit as long as we build upon this magnificent workaround for the lack of a string replacement operator. This extra padding is more noticeable with the inline treatment than with the newline treatment. We could replace the bullet with a series of spaces, which would make the imbalance imperceptible, but at the cost of making it even more likely for a dual-named label to get collided out.
Given this complexity, I’d suggest tracking support for space-padded semicolons as tail work, which I would consider blocked by a string replacement operator. I’m not opposed to it in principle, since a value’s leading and trailing spaces are always extraneous, but the cost-benefit ratio isn’t superb.

For place nodes, stats on prevalence:

Thanks, this argues strongly in favor of setting the limit to just one or two semicolons for now. I suppose it would be difficult to gather similar statistics about ad-hoc delimiters that would be candidates for conversion to semicolons – which is the point of using semicolons in the first place. But out of curiosity, is there a similar distribution on places if we naïvely assume all space-padded slashes and hyphens are intended to be value delimiters?
[^comma]: A comma continues to be used very commonly in addr:housenumber to this day as part of the Karlsruhe schema, authored by the same mapper who originally documented the comma as a more general delimiter.

You can do anything you want in JOSM. 😉

Indeed 💪💪

Given this complexity, I’d suggest tracking support for space-padded semicolons as tail work, which I would consider blocked by a string replacement operator. I’m not opposed to it in principle, since a value’s leading and trailing spaces are always extraneous, but the cost-benefit ratio isn’t superb.

Sounds good to me.  Even without explicitly handling the extra space after a semicolon, the bullet delimiter is far superior to to displaying the raw value with the semicolon.  I don't really find the extra space on one side of the bullet all that noticeable.  I just didn't think we ought to necessarily consider a space after a semicolon to be a tagging error.  At least not while the raw, semicolon delimited values are displayed on the osm.org standard layer.

Query for all types of objects this time.

1 semi-colon 31,953
2 semi-colons 2,163
3 semi-colon 539
4 semi-colon 34
5 semi-colon 10
6+ semi-colon 6

Should spaces before and after semicolons be trimmed, or is that considered a tagging error?

#670 collapses up to one space following a semicolon. If a mapper does intentionally use ;  to make the label look nicer in some other renderers, it’ll still work fine in this style. However, iD does strip it out, so if this becomes an important tagging style, iD will need a one-line fix.


Access Electron shell on injected JS-files

Is it somehow possible to access the Electron Shell if you would like to open links in the user's default browser?

Hi @Blueblau, thanks for the feedback. Opening links in the user's default browser is doable via the "Open with default browser" context menu :)

Yeah, I know... But I would like to control that with Javascript, so that all external links would be opened in the users default browser. Is it possible within an injected script — to access the Electron shell methods?

I would like [...] all external links [...] opened in the users default browser

@Blueblau that's clearer, thanks. Could --internal-urls <regex> work for you? See discussion at https://github.com/jiahaog/nativefier/issues/212#issuecomment-292689727 .

Thanks... I'm building from the scriptfile, not with the CLI. So internalUsrls: <regex> should be the equal solution right? Or does some things work with the CLI and not within the scriptfile?

@Blueblau should be, yes! And things should work equally well from the CLI vs. programmatically, if they don't it's a bug, and then please share your triggering code for easy reproducing on my side :) .
By the way, I have the same request on your bug https://github.com/jiahaog/nativefier/issues/359 "Build to folder", which is also about programmatic usage (this time of the out option): please share your code on the bug, it makes things easier for anyone to test and work on a fix.
Thanks.


An Update is ready to install. Atom is trying to add a new helper tool. / Error checking for Updates

I installed Atom via Brew Cask (Version 1.3.2). I am Using OS X El Capitan Version 10.11.2
While I am using Atom this Alert is always popping up:

Even if i Type Username&Password and Click on "Add Helper" it keeps popping up.

I tried updating Atom from within the Programm.

But after a while this Error Message pops up.

I get the same issue every time I open atom.

I'm on OSX 10.11.6 (15G31) and am getting the same thing.

Hi, same here MacOS 10.12.2 atom 1.12.6 and get prompted to update every single time I open Atom. Thanks for your time :)

how do i fix this?

installed from atom.io, having the same problem

MacOS 10.12.3 and Atom 1.13.0. Same problem with "An update is ready to install..." message.

Having same issue (macOS 10.12.3, Atom 1.14.3 x64, installed from atom.io). Some additional info:
Atom claims I have an update. I click on the squirrel, it says Downloading Update, which never finishes. Instead, the helper tool popup shows on the screen, and if I dismiss it by pressing Cancel, in the Atom update screen I get this:

If I then press "Check now" again, I get a popup telling me Atom is up to date.

I deleted Atom and reinstalled which seems to have fixed it. All my settings were kept.

It looks like the solution has been found here: https://github.com/atom/atom/issues/7058


Using Symlink Function

Is creating symlinks no longer possible/supported?
I'm not able to create any symlinks at all, error is always:
Error: link /path/folder/ -> /path/folder2/ - OP_NOT_SUPPORTED

It's been removed as a feature by 🍏 Inc. since iOS 10


add special href attribute for manage cookies in footer

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
relates #52
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/
After: https://feat-cookies-link--danaher-ls-aem--hlxsites.hlx.page/

As requested by @dicagno


49 | Group Anagrams | C++

Group Anagrams -
What will change -
Type of Issue -

[x] Adding New Code

Programming Language

[x] C++

Self Check

Ask for an issue assignment and wait to get assigned to it before making Pull Request.
Add your file to the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign this issue to me. I will follow proper guidelines and provide an optimized solution

i can do it you can assign this to me.


UI/UX: Create a rendered web version of awesome-oss-docs

hello there 👋
We want to create the web interface for awesome oss docs repo.
But the data are to be splitted into company-supported OSS projects and community based OSS projects.
issue #75

hello there 👋
We want to create the web interface for awesome oss docs repo.
But the data are to be splitted into company-supported OSS projects and community based OSS projects.

#75

Interested boss

Any update? @saintmalik

Solved #86


Further storage iterator refactoring

Followup of https://github.com/paritytech/substrate/pull/13284
This PR further cleans up the storage backend trait and gets rid of (now unnecessary) callback-based iteration methods.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432863

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432861

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432868

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432862

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432914

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432915

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2432913

Downstream showed up that https://github.com/paritytech/substrate/pull/13284 incurs an additional p number of reads for the weight of kill_prefix.

I assume this is expected. Anyway, please re-bench at the end of this MR to confirm :smile:

Downstream showed up that #13284 incurs an additional p number of reads for the weight of kill_prefix.  I assume this is expected. Anyway, please re-bench at the end of this MR to confirm smile

Thanks for letting me know; I'll verify this.

@ggwpez This is where the extra read's coming from:
   0: <sc_client_db::bench::RawIter<B> as sp_state_machine::backend::StorageIterator<<<B as sp_runtime::traits::Block>::Header as sp_runtime::traits::Header>::Hashing>>::next_key
             at substrate/client/db/src/bench.rs:104:32
   1: <sp_state_machine::backend::KeysIter<H,I> as core::iter::traits::iterator::Iterator>::next
             at substrate/primitives/state-machine/src/backend.rs:153:3
   2: sp_state_machine::ext::Ext<H,B>::limit_remove_from_backend
             at substrate/primitives/state-machine/src/ext.rs:776:14
   3: <sp_state_machine::ext::Ext<H,B> as sp_externalities::Externalities>::clear_prefix
             at substrate/primitives/state-machine/src/ext.rs:484:4
   4: <&mut dyn sp_externalities::Externalities as sp_io::storage::Storage>::clear_prefix_version_2
             at substrate/primitives/io/src/lib.rs:194:3
   5: sp_io::storage::clear_prefix_version_2::{{closure}}::{{closure}}
             at substrate/primitives/io/src/lib.rs:125:1
   6: sp_externalities::scope_limited::ext::with::{{closure}}
             at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/environmental-1.1.4/src/lib.rs:302:31
   7: environmental::with::{{closure}}
             at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/environmental-1.1.4/src/lib.rs:171:10
   8: std::thread::local::LocalKey<T>::try_with
             at /rustc/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/library/std/src/thread/local.rs:446:16
   9: std::thread::local::LocalKey<T>::with
             at /rustc/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/library/std/src/thread/local.rs:422:9
  10: environmental::with
             at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/environmental-1.1.4/src/lib.rs:163:2
  11: sp_externalities::scope_limited::ext::with
             at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/environmental-1.1.4/src/lib.rs:302:5
  12: sp_externalities::scope_limited::with_externalities
             at substrate/primitives/externalities/src/scope_limited.rs:38:2
  13: sp_io::storage::clear_prefix_version_2::{{closure}}
             at substrate/primitives/io/src/lib.rs:125:1
  14: tracing::span::Span::in_scope
             at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tracing-0.1.37/src/span.rs:1102:9
  15: sp_io::storage::clear_prefix_version_2
             at substrate/primitives/io/src/lib.rs:125:1
  16: sp_io::storage::ExtStorageClearPrefixVersion2::call
             at substrate/primitives/io/src/lib.rs:125:1

If I'm reading this right then the limit_remove_from_backend function iterates over a bunch of keys in the storage backend with a given prefix and adds those keys to the overlay so that those entries will be removed once the transaction is committed. So the extra weight looks correct to me here, as iterations weren't previously tracked in the benchmarks and now they are after my changes.

bot merge

Awesome work @koute (cc @bkchr ), I've done a basic benchmark (not accurate as it was hard to control the cache):
rocksdb                       => 514 secs
rocksdb (9.40, new iterator)  => 492 secs
paritydb                      => 66 secs
paritydb (9.40, new iterator) => 16 secs


[DEFECT] Meta object becomes nested

Defect Description
Describe the defect
When using a transfer function in a component, the meta object becomes nested with call the the evaluate method.
What did you expect to see happen?
The meta object should be updated, but not become nested when a component transfer function is evaluated.
What did you see instead?
The meta object nested once for each iteration causing a crash later on.
Do you have a suggested fix for the development team?
I have a fix with a unit test addressing this is a PR.
Describe how to Reproduce
Steps to reproduce the behavior:

Write a custom dispatcher that evaluates a dispatch using a user-provided transfer function.

Screenshots and Input Files
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.
Platform (please complete the following information):

OS: Fedora
Version: 32
Dependencies Installation: CONDA

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

This issue currently isn't seen by the Pyomo dispatcher because it directly uses the transfer function rather than calling the produce method. This will help future dispatchers work as expected.


Continuous scroll option is not working

The option to reflow an entire EPUB into one long galley document is currently broken.  Instead of concatenating all the spine items into one long galley, Readium concatenates some limited number (like 2 or 3 spine items) then stops.  In fact, you can't even navigate past the point where it stops.  If you try to choose the next spine item after that stoppage (via the TOC), Readium apparently re-paginates and then stops at the same place.
Tested in both the CloudReader 0.23-alpha and the Chrome Extension currently in the Chrome Store 2.22.2.  Tests run on MacBook Pro, OSX 10.10. Happens with all reflowable books tested, including Alice in Wonderland and the EPUB Test Suite 100.

This is working fine in my Chrome web browser on Android 6
https://readium.firebaseapp.com/?epub=https%3A%2F%2Freadium.firebaseapp.com%2Fepub_content%2Faccessible_epub_3
..it's the latest cloud reader app build from develop, which includes the jQuery regression bug fix. Could you please try again? (in your desktop browser)
Thanks!

That seems to work on my MBP with Chrome, Safari and Firefox.  But it is broken in the current Chrome Extension on the store.  Let's discuss briefly in the eng meeting tomorrow.

Sounds like jQuery 2.2.0 which breaks the '.position()' function. Fixed in the develop branch:
https://github.com/readium/readium-shared-js/compare/5693ddf514d1f47326c479ad791705be14a6dd00...d8e3da04e489c84376921c58134f1e9ff3834a20
See:
https://github.com/readium/readium-cfi-js/pull/48#issuecomment-184581089

Verified that it is fixed in the current 2.23-alpha build on github/releases

Thanks Ric! Can this issue be closed now?

Sorry, folks, more testing is showing some serious issues.  If I open Alice 3 EPUB, and use continuous scrolling mode in 2.22.3 it seems to work fine.  BUT if you look closely, you'll note that the page-arrows are still displayed. And if you press them it takes you to somewhere a couple of "pages" ahead of where you are in the current "page".  It looks like it is essentially switching to a new column or something and doing a normal page-turn's worth of advancing.
Worse, if you select scroll-doc, it presents the page-turn arrows, and they work, but instead of taking you to the next spine item, it just shows the same spine item again.  And, if you had been in paginated or continuous mode and went to spine item 6, then you're stuck in spine item 6.
So our scroll support is still seriously broken.  We can't release this. I have bumped the priority to blocking.

Continuous and per-document scrolling view seems to work just fine in my tests:
https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3
(Chrome browser, Windows 10)
I have been able to "get stuck" when using the mouse / trackpad scroll
gesture, because the HTML scroll control sometimes does not respond when there's no remaining pixels to move.
However I have never experienced this with arrow keys (i.e. previous/next "page", which the scroll view does perfectly well, in a keyboard-accessible way).
Maybe I do not understand the issue?

No it is clearly broken.  I just tried Accessible EPUB and it looks OK UNTIL you go to Chapter 1 which is longer.  Then you're stuck in Chapter 1.

@rkwright I am afraid I am not able to reproduce the problem you describe, so I can't help debug this issue right now. I will make further attempts with other web-browser / window-size / font-size dimensions. I will let you know if I find anything conclusive. Thanks @JCCR for looking into this too! :)

OK, now I see what is happening.  When I open a reflowable document and
set document scroll mode.  I see the start of a spine item. I can scroll
up and down in that spine item. I hit the arrow key and what Readium does
is scroll DOWN a page in the current spine item.  If I keep hitting the
arrow key I go down in the spine item and when I reach the end of spine
item it loads the next spine item.  That’s not what the EPUB TestSuite
expects, but the spec isn’t really clear:
EPUB 3.0.1 <IP_ADDRESS>.2 Allowed values
The Reading System should render all Content Documents such that overflow
content is scrollable, and each spine item should be presented as a
separate scrollable document.
EPUB Test Suite 111:
If each of the documents in this publication is vertically scrollable, and
swiping horizontally moves from one to the next, the test passes.
So what the EPUB Test Suite expects is behaviour like Adobe’s DPS where
horizontal navigation is BETWEEN “spine items” and vertical navigation is
WITHIN the spine item.
Note that the behaviour with continuous scrolling is the same, the arrows move you down one page.
So we’re not doing it quite right, but the spec isn’t really clear, so I
think we’re OK.

Yes, from the very beginning, Readium's scroll-view implementation always considered that the page previous/next commands (i.e. arrow keyboard shortcut, left/right user interface button, horizontal swipe touch gesture, etc.) would "paginate". In the specific context of a vertically (or horizontally) scrolling viewport, this means offsetting / panning the content by a distance corresponding to the height (or width) of the visible part of the viewport. This way, keyboard users (i.e. those not interested in using the scrollbar directly) can efficiently navigate the linear content stream.

Fixed with release of Chrome Extension 2.22.3


Link remote add to remote modify

This section in remote add docs touches on some remote modify functionality, since you need it to set up some of the remotes, but it's incomplete.
I suggest adding something like "See full list of remote options you may modify at remote modify page" in the end of the section.

Looks good - for simple things like this, it would easier to PRs right away? :)


in Gallery.js a setData was initialized but never used so fixed that …

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Made some changes in HackathonBanner.jsx file, in this file there were some unused imports like useState and AiFillGithub so i removed that unused code.
In Gallery.js file there was a state setData which was defined but was never in used so now after that filter function the filtered data can be found in result variable and using setData(result) it will reflect on the screen also.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

@Deepakbabani ?

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

@Deepakbabani ?

Some warnings were there so i just removed some unused imports in those files.

Hi @Deepakbabani Please take care of it.


CODEOWNERS: add Profpatsch to various paths

I hope this works.

I dislike that certain people are now "owner" of various parts of Nixpkgs, without any sort of decision procedure.

@edolstra I see it as a notification mechanism. Maybe we should add a comment at the top?