Concurrent connections on ModbusRTU from different integrations - read errors

I'm not sure if this is a issue with the integration or with HA DataUpdateCoordinator, so clarifying will be helpful.
I have a one Modbus serial bus, with multiple devices on it. It's connected to HA via USB-RS485 adapter.
There is 2 integrations which using Modbus RTU, one is Nilan, the other is native Modbus Integration built in a HA which reads all other devices on the bus.
Update interval for both is set to 30 sek.
When HA starts and run, both integrations tries to read registers from different devices at the same time. It resulting in communications errors and unavailable sensors.
My workaround for this is to disable Nilan integration manually and observe the led's on usb adapter. When led's stops flashing (native Modbus integration is done with serial bus for now), I'm enabling Nilan after few seconds.  In that way I have those 2 integrations shifted in time with theirs readings, and everything working well.... until next HA restart.

Yes. It is a complicated problem. The main issue is the lack of capabilities of your modbus tcp bridge and/or too slow end devices. There is no clever solution for this. The problem is that you now have two different connections to the bridge and it does not handle it properly.
Trying a different bridge device might solve the problem. Or creating your own. Best solution is to have separate bridge devices so that there is only one connection per modbus network.
Does the device hang completely? Does not anwser to either connection?

Sorry, misread at first. It is surprising it lets you connect to the latter when using a USB adapter. The problem is even more severe when using USB since the COM port only supports one instance. Easier is to use a separate USB adapter.

Yes, I use USB adapter, this one.
Sometimes, when HA starts, Nilan integration fail to start and I need to reload it. Sometimes is starting well but lot of entities for both integrations (the native one and Nilan) goes "Unknown" on and off,  and spits errors in log:
2023-07-25 20:31:20.253 ERROR (MainThread) [custom_components.nilan.device] Could not read get_ventilation_state 2023-07-25 20:31:20.349 ERROR (SyncWorker_14) [homeassistant.components.modbus.modbus] Pymodbus: nilanhub: Modbus Error: [Input/Output] No Response received from the remote slave/Unable to decode response 2023-07-25 20:31:20.429 ERROR (MainThread) [custom_components.nilan.device] Could not read get_supply_fan_level 2023-07-25 20:31:20.430 ERROR (MainThread) [homeassistant.helpers.entity] Update for climate.nilan_hvac fails Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 695, in async_update_ha_state await self.async_device_update() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 940, in async_device_update await self.async_update() File "/config/custom_components/nilan/climate.py", line 183, in async_update elif fan_supply_level > 0: ^^^^^^^^^^^^^^^^^^^^ TypeError: '>' not supported between instances of 'NoneType' and 'int' 2023-07-25 20:31:45.470 WARNING (SyncWorker_19) [pymodbus.logging] Cleanup recv buffer before send: 0x1e 0x3 0x2 0x0 0x2 0xac 0x47 2023-07-25 20:31:45.502 ERROR (SyncWorker_11) [homeassistant.components.modbus.modbus] Pymodbus: Nilan: Modbus Error: [Input/Output] No Response received from the remote slave/Unable to decode response 2023-07-25 20:31:45.534 ERROR (MainThread) [custom_components.nilan.device] Could not read get_ventilation_step 2023-07-25 20:31:45.622 ERROR (SyncWorker_19) [homeassistant.components.modbus.modbus] Pymodbus: nilanhub: Modbus Error: [Input/Output] No Response received from the remote slave/Unable to decode response 2023-07-25 20:31:45.703 ERROR (MainThread) [custom_components.nilan.device] Could not read get_control_state 2023-07-25 20:31:48.392 ERROR (SyncWorker_8) [homeassistant.components.modbus.modbus] Pymodbus: Nilan: Modbus Error: [Input/Output] No Response received from the remote slave/Unable to decode response 2023-07-25 20:31:48.424 ERROR (MainThread) [custom_components.nilan.device] Could not read get_supply_fan_level
Besides Nilan, I have 28 more entities on native integration. When the issue is happening, HA can get maybe 10 values read per update, so is not completely fails.
Using different adapters is not a option for me, house is wired with one bus only, and devices are far away.
Before I installed Nilan integration, everything was connected with native Modbus integration, (with name nilanhub, therefore it show up in logs), but your integration is far more advanced than this I had wrote down in yaml by myself, so I started using yours.
Maybe I should write an enhancement "wish" on HA core Github, so those smart guys can implement some kind of coordinator for pymodbus, when there are coming calls from different integrations on the same physical device, it can be  queued somehow..


where can I find the code for paper

Hi, I am interested in the Locally Weighted Linear Regression method in paper Boosting Monocular Depth Estimation with Sparse Guided Points. Where can I find this part code?

We will release the code under this project later.

any updates on this please @YvanYin


Performance -FPS

How does DiffMOT compare to OC-SORT in terms inference speed (fps)? Is it faster or slower?
According to the OC-SORT paper
"The inference speed is ~28FPS by a RTX 2080Ti GPU. If the detections are provided, the inference speed of OC-SORT association is 700FPS by a i9-3.0GHz CPU."
What is the inference speed of DiffMOT if the detections are provided?
Thanks

Please refer to the table 4 of the original paper, in which the results are without provided detection.
Note that the results are tested on a RTX 3090 GPU.
We don’t have fps statistics of provided detection. In my opinion, it would have around 4x faster speed at least.


[BUG] window on unbounded preceeding and unbounded following can produce incorrect results.

Describe the bug
I tried to do a very basic window operation. The simplest I could think of.
spark.time(spark.range(5L).selectExpr("SUM(1) OVER()").show(truncate=false))

This produces nulls for all values on the GPU, but on the CPU it is all 5s. I thought this might be related to ordering, but it is not.
spark.time(spark.range(5L).selectExpr("SUM(1) OVER(ORDER BY id ROWS BETWEEN unbounded preceding and unbounded following)").collect())

does the same thing.
It gets even odder with COUNT, that returns values, that are wrong, but the cast to string is all empty strings...

This is a cudf bug
https://github.com/rapidsai/cudf/issues/9672
I'll see if I can come up with a fix, but if we cannot get a fix soon we will have to fall back to the CPU for any row based window query where the values could overflow. (which might be all of them? or might be anything larger than 1/2 Int.MaxValue) I need to do some math to figure it out.

The CUDF fix was just merged. I'll put up some tests soon.


api: Change config_from to a oneof

Make this field more extensible. The current field inside the oneof is a
string pointing to another network by name, but in the future we will be
able to add other configuration locators.
cc @aboch @cpuguy83

Thanks for taking care of this change.
Looks good to me


show weather details on user search

Description
get coords on users input and display weather accordingly

Fixes #19

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Chore items (this includes basic clean up of files, or updates to packages)
[ ] Updates to documentation

Checklist

[x] I have a descriptive title for my PR
[x] I have linked the issue to this PR. Instruction how to link issues to pull requests here
[x] I have run the project locally and reviewed the code changes
[x] My changes generate no new warnings

ok , i'm not done 100%... what do you think so far?are there too many variables and things on one function?


initial module fails in jshintrc

angular.module('modem', [
  'ionic',
  'ngCordova',
  'ui.router',
  // TODO: load other modules selected during generation
])

too much , see ui.router (there is an additional comma after 'ui-router')

Hi @DrMabuse23, that's only a problem in older versions of IE. It's only an error in jshint if the es3 options is enabled which is not the case when generating a project with generator-m, since we're not supporting legacy browsers (just as angular and ionic btw).
See more info here: https://jslinterrors.com/extra-comma
Did any of the gulp tasks report this error, or is it just your IDE? If it's just your IDE you might solve this issue by configuring your IDE to use the .jshintrc file that comes with the generated project instead of a different one (which obviously has the es3 option enabled).


merge

bugfix

Coverage decreased (-0.01%) to 84.108% when pulling 2d5bfbb344a962139dfc0f9355ca000717dfc3fa on rmillikin:master into 083d5ca4c0b4e20dfdb4c5a5d4e2e810178b43e8 on smith-chem-wisc:master.

Coverage increased (+2.4%) to 86.526% when pulling 6bb98388981a82e0eb9cbf38dd18ea3953bfd208 on rmillikin:master into 083d5ca4c0b4e20dfdb4c5a5d4e2e810178b43e8 on smith-chem-wisc:master.

Coverage increased (+1.2%) to 85.33% when pulling d8cf2404c4b595667045bc3bd1b86ac8977a4df0 on rmillikin:master into 083d5ca4c0b4e20dfdb4c5a5d4e2e810178b43e8 on smith-chem-wisc:master.

Coverage increased (+1.2%) to 85.326% when pulling 839675ec90ad6339a8635b0b70e8380801fe9ed0 on rmillikin:master into 083d5ca4c0b4e20dfdb4c5a5d4e2e810178b43e8 on smith-chem-wisc:master.

Coverage increased (+1.2%) to 85.453% when pulling a0be80716d3b4114a44fe7076d1609b0f4b4b972 on rmillikin:master into bcc707e7e2f387075ee456908d9e83622dabc1cc on smith-chem-wisc:master.


Is It Possible To Show Full Screen Modal?

@jonahfang Indeed it is possible.  The easiest way would be to do something like this:
<ReactModal
  showModal={true}
  contentLabel="Description of the Modal for Screenreaders"
  onRequestClose={closeModalFunction}
  style={{
    content : {
      top: 0,
      left: 0,
      right: 0,
      bottom: 0,
    }
  }
/>


Strange saving/loading behaviour

I didn't use PoeSkillTree for a while but now that I do use it again I find the build saving/loading behaviour extremely strange and unintuitive. For some reason the program seems to automatically save changes. Sometimes I create a build and then re-iterate it entirely. When I want to go back to the original version, I used to be able to just 'load' the previously saved version. Now it won't let me. The changes I made are automatically saved. I have to start a new build for each iteration.
I hope you get what I am saying. It's really not that easy to explain. But something definitely feels way off!

The program doesn't auto save any changes. Can you give me steps to reproduce the program auto-saving?

The program now keeps a dirty state of the current build, that is it marks if you change anything. This is shown with an asterisk (*).  If you want to you can discard all the changes done, but on mobile atm so I can't post a screenshot.

Thanks for the heads up. It's exactly like SpaceOgre said.
I used to create a build, save, then change a few points around and if I didn't like it I would just hit 'load build' again so that the previously saved version would come back up. This doesn't work anymore. Instead you have to rightclick the build, then hit 'Discard changes' - which is incredibly unintuitive and awkward to use if you ask me.
Probably related to this issue: I can no longer delete ALL the builds. It gives me an 'The currently opened build can not be deleted.' error when I try to delete the last one.
I guess it all boils down to the fact that there's no longer a 'neutral mode' where you can freely allocate points and save when you're finished. Instead you now have to always work inside a currently open build. I used to be able to just launch the program and start allocating points, then hit save and name the build. Now I have to first create a build (name and 'save' it) and then allocate points.
It doesn't seem like much but for me it is incredibly disruptive when trying to come up with builds.
I am sorry if my explanations are lacking. Engrish hard.

This now basically works like every other program that uses with files, so I don't really see where it would be unintuitive. The problem probably is that this system work worse for experimentation (and much better for storage and organization) than what we had before. Maybe we can change it to only require naming on save, but that's about as much as we can do while keeping it file based.

Yeah I think it would be good to be able to start a new build without having to name it first, just like you can start writing a new Word document without first naming it/saving it.

file based

Ah yes! That's exactly what it feels like. It is indeed way better for storage and organization. I just don't use the program for that. I barely store anything :P It's all experimentation for me, so perhaps that's why it feels unintuitive for me. Thanks for clearifying. Issue can be closed I assume

I also think people like to reopen already open builds, so we might be able
to something like that? It would be like closing a file without saving and
reopening it.
On Nov 22, 2016 3:11 AM, "852Foofer"<EMAIL_ADDRESS>wrote:

file based
Ah yes! That's exactly what it feels like. It is indeed way better for
storage and organization. I just don't use the program for that. I barely
store anything :P It's all experimentation for me, so perhaps that's why it
feels unintuitive for me. Thanks for clearifying. Issue can be closed I
assume
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/400#issuecomment-262213311,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIbbenD0Y87-t76MYTKYCzN--CWj7A3ks5rAs3HgaJpZM4K4xd0
.

Isn't that exactly what "discard changes" does?

Yes, but I don't think people like it being hidden behind the right click
menu
On Nov 22, 2016 10:26 AM, "brather1ng"<EMAIL_ADDRESS>wrote:

Isn't that exactly what "discard changes" does?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/400#issuecomment-262323509,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIbbZTV3lKkejBPXvErqBqsBL07Iz5dks5rAzPugaJpZM4K4xd0
.

Discarding could get a menu entry and keyboard shortcut (for the current build). Making it another button under the build list would be too much clutter imo.

If the a build is double clicked and has changes to discard then prompt to
discard changes
On Nov 22, 2016 12:00 PM, "brather1ng"<EMAIL_ADDRESS>wrote:

Discarding could get a menu entry and keyboard shortcut (for the current
build). Making it another button under the build list would be too much
clutter imo.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/400#issuecomment-262349356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIbbR3RPFb63grLTWdH0WX6zfTf3Sz7ks5rA0nugaJpZM4K4xd0
.

I don't really like that idea. It wouldn't save much time as opposed to a keyboard shortcut or the context menu entry and would require different double click behaviours for the current build (ask for discarding changes) and other builds (load it). Asking to discard when loading other builds would be annyoing, imo.
I think this is mainly just an issue of people being used to the weird behaviour we had for a long time. It should be fine after a bit of getting used to it.

I 100% agree with EmmittJ, if my opinion counts at all.
Personally I don't use any key shortcuts in any program other than ctrl c/v and ctrl z. I also don't know of anyone who really does use a lot of shortcuts either. Perhaps its a thing tech afine people love but I think for the general public, shortcuts really are not a thing. The dropdown menu-option is absolutely weird if you ask me. It took me hours to figure out it was a thing. And even now I rarely use it. It feels so weird!
I would totally prefere a discard prompt to the current solution.

Sorry, I don't think I made my statement too clear. This prompt would only appear if you are trying to load the current build over again. It would just prompt the user to discard changes. I don't think hotkeys are really used by the average user.
if current_build && build has changes:
    prompt for discard
else
    do current stuff

Implemented both the naming on first save and not on new build creation, and the double click discarding,


Update NetworkController to keep a list of connectable networks (and keep track of which ones are connected)

The list here will be roughly equivalent to the list that is kept currently in PreferencesController for now (but bringing the terminology up to date). In the future we will extend the implementation so that we can maintain a set of connected networks along with the provider objects for those networks, so our design should be future-looking.
Each network should have its own id, which we can expose to the UI for updating/deleting networks or switching networks.
We need new CRUD methods in NetworkController so that consumers can work with the list. We also want a way to keep track of which network is current.
Keep in mind that NetworkController already has methods for working with the network. These are badly named. The new methods we add should be the methods we wanted to add. In future releases we will eventually change the existing API to use the new API, then deprecate it, then remove it, but for now the new methods will live alongside the old ones.

We decided that while completing this task is necessary to finish the multi-chain network project, it isn't necessary to complete the particular epic that we are working, which is to merge the two network controllers together. So we are going to deprioritize this for now.

The work described here comprises a combination of #969 and #1045. That is to say, adding CRUD methods to be able to manage the network list is necessary to complete #969. Past this, keeping track of which network is connected to may in fact not be necessary. After all, one could ask, what does it mean to be "connected" to a network? If it means whether or not a block tracker is actively polling for a network, we may or may not remove this functionality in the future so that's not a guaranteed way to know. We are still thinking that through. For now, however, we can close this ticket as it overlaps with other tickets.


KeyError: 'gene_id'

modbamtools plot -r mtDNA:1-16626 --gtf /cluster/projects/nn9337k/as1_nanopolish/all_context/sequence.sorted.gtf.gz --out . --prefix unmethylated --samples unmethylated --track-titles Genes unmethylated.bam
Traceback (most recent call last):
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/bin/modbamtools", line 8, in
sys.exit(cli())
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/cli.py", line 334, in plot
fig = Plotter(
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/modbamviz.py", line 47, in init
self.tracks, self.num_tracks = get_tracks_gl(
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/tracks_webgl.py", line 236, in get_tracks_gl
genes = parse_gtf_exons(gtf, chrom, start, end)
File "/cluster/projects/nn9337k/anaconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/gene_models.py", line 162, in parse_gtf_exons
if record.gene_id not in recs.keys():
File "pysam/libctabixproxies.pyx", line 638, in pysam.libctabixproxies.GTFProxy.getattr
KeyError: 'gene_id'

Hi Partha434,
I think this likely stems from the GTF you are using.
Unfortunately, we have not had a chance to update this. Since GTFs can come in different formats, modbamtools may fail if it encounters a GTF format different from what is expected. modbamtools seems to be hardcoded (currently) to parse a GENCODE-style GTF (as shown in the tutorial).
I would suggest using a GENCODE GTF to fix the issue in the short term. The long term fix will involve updating the code.
Paul


Accessibility projects

To complete this milestone;
I completed the following instruction:

Page titles - no issues found.
Have added alternative text ("https://github.com/axcell-0/Thierrys-portfolio/blob/e5c5b120ad2094e8da37adaa6342a114f727c149/index.html#L13-L183").
Text headings - no issues found.
Color contrast - no issues found.
Resize text - no issues found.
Moving content- no issues found.
Multimedia - no issues found.
The basic structure of the page - no issues found

thanks very much for this reminder but I have a question if the partner is
not available what should I do
On Tue, Jun 20, 2023 at 2:32 PM ennio @.***> wrote:

Hi @axcell-0 https://github.com/axcell-0, please note that @joskalenda
https://github.com/joskalenda should have invalidated this request as
you worked solo on it.
This is a pair-programming activity and we should see commits also from
your coding partners.
I will now manually change the status of the activity on your dashboard so
you can request another code review request.
—
Reply to this email directly, view it on GitHub
https://github.com/axcell-0/Thierrys-portfolio/pull/10#issuecomment-1598800788,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A432YAGKWWALLEAHPEWWAHDXMGQ73ANCNFSM6AAAAAAZM6I7KY
.
You are receiving this because you were mentioned.Message ID:
@.***>


[WIP] Remove ng-app, use miq_bootstrap instead

In order to support angularified toolbars (https://github.com/ManageIQ/manageiq/pull/9753), we need to get rid of ng-app in our application and bootstrap each angular module using miq_bootstrap (which is our wrapper around angular.bootstrap).
This converts all these ng-app instances to use miq_bootstrap instead.
WIP - need to test properly, might be edge cases or missing strictDi..

@himdel : I have tested this branch except for Network topology (ping @Ladas : could you test thin in the network topology, please, we need this merged ASAP).
While testing I have noticed that when you enter stuff into the search field and press Enter it does not run the search function but reloads the screen instead. But that is not an issue of this PR. Issue: https://github.com/ManageIQ/manageiq/issues/10252

Thanks, I have clicked through all the topologies and dashboard and not seeing any problems.. so unless @Ladas finds something.. :) removing WIP..


Aead packet support

AEAD Encrypted Data and V5 Symmetric Key Encrypted packets support
Implement streaming API for Authenticated Encryption with Associated Data as described in RFC4880bis, sec. 5.16, and add version 5 support to Symmetric Key Encrypted packet.
Feature overview

EncryptedData interface, implemented by both SymmetricallyEncrypted and the new AEADEncrypted data packets.
Version 5 support for Symmetric Key Encrypted packets, serialized automatically if AEADis enabled.
Integration in crypto/openpgp API: NewEntity (key generation), SymetricallyEncrypt, EncryptText, ReadMessage, with sensible defaults.

AEADEncrypted Data packet implemented in openpgp/packet
This packet (tag 20) complies with the new EncryptedDataPacket interface:
type EncryptedDataPacket interface {
	Decrypt(CipherFunction, []byte) (io.ReadCloser, error)
}

It supersedes the Symmetrically Encrypted Data packet (tag 18) for authenticated encryption.
V5 Symmetric Key Encrypted packet
If AEAD is enabled in the configuration, the SymmetricKeyEncrypted packet encrypts and authenticates key material using the given AEAD algorithm. The following tests were added:

TestRandomSerializeSymmetricKeyEncryptedV5: Sample a random key, serialize the v5 Symmetric Key Encrypted packet, parse the resulting packet, decrypt, and check correctness.
TestDecryptSymmetricKeyAndEncryptedDataPacket: Parse and decrypt foreign v4 and v5 packets (includes RFC test vectors).

AEAD streaming interface internals
Interface is also implemented by symmetrically_encrypted.go. The streamer writes plaintext bytes to an io.writeCloser that are automatically encrypted and written to an AEAD Encrypted Data Packet (tag 20) with partial lengths. The writing is handled by encrypting chunks of fixed size, and buffering plaintext bytes when necessary. Each chunk is authenticated by a tag, and at the end of the stream, an additional authentication is appended (allowing to detect missing or extra chunks of data).
Configuration
An AEADConfig consists of the following values
DefaultMode  AEADMode  // Defaults to EAX
ChunkSize    uint64  // Defaults to 1 << 18

and the packet.Config object has the following new attributes:
AEADConfig   AEADConfig  // Can be nil
AEADEnabled  bool  // Defaults to false

Streaming
Given a private key, get a writeCloser that receives plaintext bytes and writes ciphertext bytes:
packetBytes := bytes.NewBuffer(nil)
writeCloser, err := SerializedAEADEncrypted(packetBytes, key, config)
// Check err

Given any amount of plaintext bytes, encrypt and write into packetBytes as follows:
n, err := writeCloser.Write(plaintextBytes)
// Check err

The last step can be done repeatedly until the end of the stream:
// Close MUST be called - it appends the final auth. tag
err = writeCloser.Close()
// Check err

The AEAD packet is ready in packetBytes.
Reading stream
Given key and at least the first chunk of packetBytes constructed above, to decrypt the stream first parse the packet and initialize the streamReader:
packet := new(AEADEncrypted)
err = packet.parse(packetBytes)
// Check err

rc, err := packet.Decrypt(nil, key)  // First argument is for interface compliance only
// Check err

The Read method of rc automatically decrypts and buffers as necessary:
decrypted := make([]byte, amountOfBytesToRead)
n, errRead := rc.Read(decrypted)
//Check errRead

At the end of the stream, the summary tag is automatically verified within the Read call. The following instruction wipes the reader.
rc.Close()

Tests

TestAeadEmptyStream verifies a stream with empty contents
TestAeadRFCParse validates RFC4880 test vectors
TestAeadNilConfigStream tests a random stream passing nil as the config parameter.
TestAeadRandomStream streams a random plaintext, decrypts the stream, and check correctness
TestAeadRandomCorruptStream alters some bytes of a valid packet, and check that an error is raised when reading.
TestAeadRandomTruncatedStream strip a random amount of trailing bytes of the stream and checks the fail
TestAeadRandomUnclosedStream decrypts a stream which was not Close()d and checks the fail

Acknowledgements
Thanks to @twiss for debugging help and for providing OpenPGPjs test vectors.

Bug in openpgp.Encrypt with long plaintext messages
Current bug behavior
The message encrypting function openpgp.Encrypt panics on Write for long plaintext messages.
When calling openpgp.Encrypt on plaintexts of length around 1<<20, EndToEndTest fails with
	panic: bytes.Buffer.WriteTo: invalid Write count

(see the whole stack trace below)
Expected behavior
TestEndToEnd should be able to encrypt messages of this size and larger.
How to reproduce
Go to openpgp/integration_tests/utils_test.go function randMessage() and increase the size of random test messages:
	maxMessageLength := 1 << 20

(previous value set at 1 << 12), and run the test:
go test ./... -run EndToEnd
Posible cause
Definitely related to AEADEncrypted writer or closer, according to the stack trace, which is in turn related to the implementation of partialLengthWriter. The panic arises when closing a partialLengthWriter.
Also, there's no panic if AEAD is disabled (indicated by the absence of a packet.AEADConfig inside the packet.Config passed to openpgp.Encrypt).
Posible fix
WIP
Related PRs
#36 - Aead packet support.
Complete traceback
=== RUN   TestEndToEnd/rsa_foreign/encryptDecrypt/ed25519_fresh
panic: bytes.Buffer.WriteTo: invalid Write count [recovered]
	panic: bytes.Buffer.WriteTo: invalid Write count

goroutine 69 [running]:
testing.tRunner.func1(0xc0000b6500)
	/usr/local/go/src/testing/testing.go:874 +0x3a3
panic(0x600d00, 0x691f40)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
bytes.(*Buffer).WriteTo(0xc0000749d0, 0x7fbf723016b8, 0xc00004a210, 0x7fbf723016b8, 0xc00004a210, 0xc00032a4e0)
	/usr/local/go/src/bytes/buffer.go:241 +0x145
golang.org/x/crypto/openpgp/packet.(*partialLengthWriter).Close(0xc0000749c0, 0x69a180, 0xc00007a000)
	/home/botvinnik/go/src/golang.org/x/crypto/openpgp/packet/packet.go:135 +0xd5
golang.org/x/crypto/openpgp.signatureWriter.Close(0x698000, 0xc0000a2280, 0x698040, 0xc0000749c0, 0x5, 0x69a180, 0xc00007a000, 0x69a180, 0xc00007a000, 0xc000001c80, ...)
	/home/botvinnik/go/src/golang.org/x/crypto/openpgp/write.go:462 +0x140
golang.org/x/crypto/openpgp/integration_tests.encDecTest.func1(0xc0000b6500)
	/home/botvinnik/go/src/golang.org/x/crypto/openpgp/integration_tests/end_to_end_test.go:175 +0x3e2
testing.tRunner(0xc0000b6500, 0xc00031a000)
	/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x350
exit status 2
FAIL	golang.org/x/crypto/openpgp/integration_tests	1.393s


JAV-104 clean up unused methods whose tests fail on windows

Coverage increased (+0.05%) to 81.671% when pulling dea9900417e84173353008598b0b0278c352199c on JAV-104_code_cleanup into f5c55a86379e47f0958ebb650b0b00eaf366d30d on master.


Fix Travis CI build

Coverage decreased (-0.3%) to 33.461% when pulling e7b006f98c5ac62741191eb7569a8ec606fc0d1c on morckx:fix-travis-build into 94c1907df5a76726d3492e959c6c08778c893d76 on connectbot:master.

Thanks!


mediaLesson, interactiveVideo: syncpoints do not alwasy work with more than one mediaLesson or intrecativeVideo

It depends even on the order of the pages in the LO.
Suppose that you have a mediaLesson, mediaLesson, nav, mediaLesson
The syncpoints of the 3rd mediaLesson do not work anymore. This has to do with the way the popcorn library and specifically the plugins are loaded. A mediaLesson does not reload the popcorn library if there is already a mediaLesson in the LO. However, the nav page loads popcorn, and specificaaly with a different set of plugins. The 3rd mediaLesson does not reload the needed plugins and fails.

Probably the best fix is to always load popcorn with all plugins instead of trying to do it on the fly.
For now the mediaLesson and interactiveVideo page just reload popcorn and the plugins


Error 0xc03a001a when installing ArchWSL

IMPORTANT
Please read README and Docs before creating the issue. -> Done
Please fill out the below information:
Describe the issue
The installer via the .zip method fails if

the filesystem is NTFS
the filesystem has compression enabled

To Reproduce
Steps to reproduce the behavior:

Prepare the zip installation
Make the folder compressed, by

Clicking Properties in an empty area of Explorer when in the folder
Clicking Advanced
Check the Compression option if unchecked

Run the installer.

Expected behavior
A clear and concise description of what you expected to happen.
The issue seems a WSL one:
https://github.com/microsoft/WSL/issues/4103#issuecomment-501885534
My suggestion is to report it in the README file and in the known issues.
Screenshots
The error log is:
> .\ArchFail.exe
Using: D:\WSL\ArchLinux - Copy\rootfs.tar.gz
Installing...
ERROR:Installation Failed!
HRESULT:0xc03a001a
Press any key to continue...

I can make a video presenting the issue.
Enviroment:

Windows build number: 10.0.19042.746
Security Software: Windows Defender
WSL version 1/2: WSL2
ArchWSL version:  <IP_ADDRESS>
ArchWSL Installer type: zip clean
Launcher version: 20112500

Additional context
Add any other context about the problem here.

Although it's interesting to know that we should avoid installing in this way, I feel not confident about changing documentation of ArchWSL to address this kind of potential problem.
This is an issue which is caused by upstream implementation just as you stated. And I don't feel pretty helpful to copy and list every kind of error code and their cause/solution here. The the error code is consistent with other distorts will give and by searching that first people could found the answer they needed at a better place and discuss there.

Although it's interesting to know that we should avoid installing in this way, I feel not confident about changing documentation of ArchWSL to address this kind of potential problem.
This is an issue which is caused by upstream implementation just as you stated. And I don't feel pretty helpful to copy and list every kind of error code and their cause/solution here. The the error code is consistent with other distorts will give and by searching that first people could found the answer they needed at a better place and discuss there.

I believe then that a good approach is to

mention the possible issue
refer to the upstream issue
so that

People know that is a WSL issue and not of this project
People won't have to try a bunch of stuff & Googling, which I had to do

Lemme know if you have a better suggestion 😄

I believe then that a good approach is to

mention the possible issue
refer to the upstream issue
so that

People know that is a WSL issue and not of this project
People won't have to try a bunch of stuff & Googling, which I had to do

Lemme know if you have a better suggestion 😄

Hummm, that sounds interesting. For me, when I encounter errors report like this, the first thing I'll do is to Google/DuckDuckGo the error code which is 0xc03a001a here. If I don't get something related I'll go to search for WSL + error code, or ArchWSL + error code, or full error report, etc.
And actually using Google and the first search term, I can already find useful information in the first result.
But, well, I can see the error report it self is somewhat not descriptive. Maybe include some extra information like which step / system(dependency) call threw the error could be helpful. I think by that we can guide people to search for solution in the correct scope.

Hummm, that sounds interesting. For me, when I encounter errors report like this, the first thing I'll do is to Google/DuckDuckGo the error code which is 0xc03a001a here. If I don't get something related I'll go to search for WSL + error code, or ArchWSL + error code, or full error report, etc.
And actually using Google and the first search term, I can already find useful information in the first result.
But, well, I can see the error report it self is somewhat not descriptive. Maybe include some extra information like which step / system(dependency) call threw the error could be helpful. I think by that we can guide people to search for solution in the correct scope.

Sounds quite good for me :)
So, what should be the next steps?

Sounds quite good for me :)
So, what should be the next steps?

(Sorry for being late to reply, I'm preparing for an entry level foreign language proficiency test and after the exam I'll try to look into this...

No problem at all! Life is busy for everyone :)
In my case, work is 🤣
Ping back after the exam 😉


Update Blog “test1”

Automatically generated by Netlify CMS

👷 Deploy Preview for endearing-sfogliatella-6c7dea processing.

Name
Link

🔨 Latest commit
43c964448ac19dbcbfe0cfe6b6a3fe754bdecb05

🔍 Latest deploy log
https://app.netlify.com/sites/endearing-sfogliatella-6c7dea/deploys/643a39e0877a7900085cf2dd


⚠ Bofrost.lu has degraded performance

In 5fd6671, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1095 ms

Resolved: Bofrost.lu performance has improved in c1a4a41.


Default Keyboard Shortcut for toggleTerminal Does Not Match Documentation

Opening as a bug since I don't think the documentation is wrong. I think something strange happened in a recent update.
The default shortcut to toggle the intergrated terminal change from CTRL + ` to CTRL + '. Notice from the screenshot that the source is Default and Reset Keybinding is grayed out.

CTRL + ` is now mapped to splitEditor:

VS Code Version: 1.53.1
OS Version: Windows 10 Enterprise 20H2

Steps to Reproduce:

Press CTRL + `
Expect The Integrated Terminal to open/close

Does this issue occur when all extensions are disabled?: Yes

It's looking correct to me and using the Ctrl and backtick works in toggling the terminal

Try Insider's perhaps?

What keyboard layout are you using?

@Tyriar English / US if you're asking about the windows keyboard layout.
No keymaps curently installed if you're asking about VS Code. I had installed IntelliJ keymaps at one point, but I've since removed them. I think VS Code should say extentsion rather than default though if the key map is the issue.

@meganrogge Same issue on insiders. Didn't install anything additional.

I can't repro here:

Do you have en-US set as the system language as well?

@Tyriar @meganrogge I did a little digging this morning. Everything seems to be configured correctly, but there are other factors outside of VS Code that are likely contributing to my problem. I've moved this to Stack Overflow at the link below.
What Causes Default VS Code Keyboard Shortcuts to Differ From Official Defaults?


Operational Semantics For DSL

This short issue serves to mark a reminder to mark a longer issue and series of checkpoints for this task.

Per 9/26's meeting with Prof. Foster, we find that in stream-to-stream based transformations, a need for operational semantics will cleanly be able to model how packets should be processed in order via any given DSL program, with leaves organized in FIFO order.
How this extends to policies which model set-to-stream level transformations is not immediately clear. But we intend to use our type system and arbitration to rule out malformed programs with this ambiguity.

#67 Tracker


ImportError: undefined symbol: PyExc_ValueError

I cannot seem to get this plugin to work. Below is some system information:
$ vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Mar 29 2019 20:08:59)
$ python3 --version
Python 3.7.3
$ uname -roms
Linux 5.0.5-arch1-1-ARCH x86_64 GNU/Linux

Vim:
:echo has('pythonx') 1
:echo has('python3) 1
:set pyxversion? pyxversion=3
It should be noted that importing pynvim through standard python3 shell works without errors. But when I try to import pynvim through vim, this error happens:
:python3 import pynvim
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/pynvim/__init__.py", line 11, in <module>
    from .msgpack_rpc import (ErrorResponse, child_session, socket_session,
  File "/usr/lib/python3.7/site-packages/pynvim/msgpack_rpc/__init__.py", line 10, in <module>
    from .session import ErrorResponse, Session
  File "/usr/lib/python3.7/site-packages/pynvim/msgpack_rpc/session.py", line 7, in <module>
    import greenlet
ImportError: /usr/lib/python3.7/site-packages/greenlet.cpython-37m-x86_64-linux-gnu.so: undefined symbol: PyExc_ValueError
Press ENTER or type command to continue

What could be the cause of this issue?

I guess I should have looked a bit longer. This is a duplicate of this issue: https://github.com/roxma/vim-hug-neovim-rpc/issues/28 solved by uninstalling pip version of greenlet and installing the repository version of this package.


Update favicon.ico

Fixed Favicon.
256x246
48x48
32x32
16x16
Fixed visual artifacts found in the original favicon.
Filled in Hop Florette and Script F with white to allow for better icon visualizations on dark themed browsers.
Changed the Scrip F orange to match the dashboard device chamber orange .
(Don’t laugh!  For now, you get fluff!)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for this!


[Google_Maps_Flutter] The release mode of the app has problems with rendering of Google Maps widget

Dear Team,
Please, advise anything regarding the following:
I use Google Map in a widget like this:
class EventMap extends StatefulWidget {
  final bool isOrganizerMap;
  final double latitude;
  final double longitude;

  EventMap(this.isOrganizerMap, this.latitude, this.longitude);

  @override
  _EventMapState createState() => _EventMapState();
}

class _EventMapState extends State<EventMap> {
  late Set<Marker> markers;
  late GoogleMapController controller;
  late LatLng position;

  @override
  void initState() {
    markers = Set<Marker>.of([]);
    position = LatLng(widget.latitude, widget.longitude);
    controller = null as GoogleMapController;
    super.initState();
  }
  @override
  Widget build(BuildContext context) {
    // ignore: unnecessary_null_comparison
    if (controller != null && widget.isOrganizerMap) {
      setState(() {
        markers.clear();
        markers.add(Marker(markerId: MarkerId(Uuid().v4()), position: LatLng(widget.latitude, widget.longitude)));
      });
      controller.animateCamera(CameraUpdate.newCameraPosition(CameraPosition(zoom: widget.isOrganizerMap ? 17.0 : 16.0, target: LatLng(widget.latitude, widget.longitude))));
    }
    return GoogleMap(
      initialCameraPosition: CameraPosition(zoom: widget.isOrganizerMap ? 17.0 : 16.0, target: position),
      mapType: MapType.normal,
      markers: markers,
      circles: widget.isOrganizerMap ? Set.of([]) : Set.of([Circle(circleId: CircleId(Uuid().v4()),
        center: position, radius: baseUnit(9), strokeWidth: 1, strokeColor: Color(0x3300FFFF), fillColor: Color(0x3300FFFF),)]),
      onMapCreated: (controller) => _onMapCreatedCb(controller)
    );
  }
  void _onMapCreatedCb(GoogleMapController controller) {
    if (widget.isOrganizerMap) {
      setState(() {
        this.controller = controller;
      });
    }
  }
}

The Problem
When i run flutter build apk (!!!no param --no-sound-null-safety) and install both on Android device and on PC Simulator i get failures rendered

And i get the following message as a stack trace:
The following _CastError was thrown building Container(constraints: BoxConstraints(0.0<=w<=Infinity, h=128.0)):
type 'Null' is not a subtype of type 'GoogleMapController' in type cast

When i run the build with parameter --no-sound-null-safety - it all works.
It fails both for iOS and Android emulator. google_maps_flutter version is 2.0.6
Here is my flutter doctor -v:
[✓] Flutter (Channel stable, 2.2.1, on Mac OS X 10.15.7 19H15 darwin-x64, locale en-ES)
    • Flutter version 2.2.1 at
    • Framework revision 02c026b03c (3 months ago), 2021-05-27 12:24:44 -0700
    • Engine revision 0fdb562ac8
    • Dart version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 59.0.4
    • Dart plugin version 212.4746.57

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 11 (mobile)      • EEDEB002-55D1-4739-834D-327FB55D983A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-1 (simulator)
    • macOS (desktop)         • macos                                • darwin-x64     • Mac OS X 10.15.7 19H15 darwin-x64
    • Chrome (web)            • chrome                               • web-javascript • Google Chrome 92.0.4515.159

• No issues found!

Thank you so much in advance!

@mike392
Looking at the error you are getting type 'Null' is not a subtype of type 'GoogleMapController' in type cast and you being on null safety version Dart version 2.13.1, the default types do not accept null values so to accept null as value to a variable, you should re-evaluate your code or use Nullable types by appending a ? to the type where it is complaining.
Try the above and see if it works.


Rename LICENSE-CODE to LICENSE-CODEs

Howdy @mccoystevenst, not entirely sure what you're trying to accomplish here, so closing it out.
Feel free to re-open with more context.


[55] Added a few improvements

Converted from OptionParser to ArgParser
Provide a human readable error if output.xml does not exist
Provide path to the results file once it's generated

This addresses #55 and a bit more

Thanks @bkhouri changes looks good, let me do some testing before merge!

Speaking of testing, it would be nice to have some unit tests :) to aid in gaining confidence when making changes.


Fix README to say Xcode 10.0 and Swift 4.2

🚀
Hey, sorry I missed this for the 4.6.0 release. Do we need to create a 4.6.1 release now in order to update the README file?
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 4.
[ ] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 525 tests, with 0 failures (0 unexpected) in 12.588 (13.596) seconds

:book:
tvOS: Executed 494 tests, with 0 failures (0 unexpected) in 7.043 (7.895) seconds

:book:
macOS: Executed 359 tests, with 0 failures (0 unexpected) in 1.116 (1.447) seconds

  Generated by :no_entry_sign: Danger

So do I need to update the podspec and whatnot for marking it as version 4.6.1? And how do we update the public cocoapods spec? @omaralbeik ?

Catching up now


333

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Close this issue.

If you have specific feedback about the docs site, please comment in the issue. For now, I'm going to close it.


v10.5 cannot add upstreams for kong version 0.11.x

v10.5 cannot add upstreams for kong version 0.11.x
when i click submit upstream button, no response.

met the same problem... = = i cant create new upstreams

regression issue.
Check the new commit. 0.10.6

angular.js?r=0.10.6:14199 AddUpstreamModalController:created upstream error Object
(anonymous) @ angular.js?r=0.10.6:14199

can you  expand the data obj so we can see what it?

"hash_on is an unknown field"

yes, it makes sense.
hash_on as a field is not introduced in kong 0.11.x
i will have to check the version there.
I'll fix it and keep you notified.

i have no idea how to upgrade several kong nodes from 0.11.x to 0.12.x meanwhile.
i need a lot of time to test kong verison upgrade.

pull the latest commit and see what happens.
(I'm making these changes on the fly so i cannot properly test them)

ok, i will test it later.

it works.
thanks


Autorollback doesn't work after upgrading to EF Core 3.0

Project: WebAPI .NET Core 3.0
EF release: EF Core 3.0
Test framework: xUnit 2.4.1 (latest)
DB: MsSql 2016
The issue is Autorollback on scope dispose stopped working, it was working fine before upgrading to 3.0. The example code is here: CLICK
It's used as attribute for Class or Method so it's simply:
[Fact]
[Autorollback]
public async Task TestMethod(){}

It used to rollback db changes after method ends, now it does nothing even though Dispose() method is called and there is no exceptions or any suspicious behavior. I've already asked xUnit team and they suggested reporting EF 3.0 issue. DB is a real one, not in-memory.
Is that a real issue or does 3.0 need some additional settings to make it work fine again?

@MichalLechowski What is the Autorollback attribute and where does it come from?

@ajcvickers - It is coming from xunit. Runs some code before & after the test. The OP has link to the attribute if that helps in what processing it does and how it would work with EF.

@MichalLechowski What is the Autorollback attribute and where does it come from?

There's a link in the first post, start from there.

@ajcvickers - It is coming from xunit. Runs some code before & after the test. The OP has link to the attribute if that helps in what processing it does and how it would work with EF.

Yep and it's pretty basic stuff, it simply creates instance of transaction scope before method and calls Dispose() on scope instance after method ends.

@MichalLechowski The attribute is working for me--my test code is below. In the test I update a value in the database, confirm that it has updated in the test. Without Rollback, the test fails the second time it is run. With rollback it can be run many times, indicating that the change was committed.
Can you please post a small, runnable project/solution that demonstrates the behavior you are seeing.
    public class UnitTest1
    {
        [Fact]
        [AutoRollback]
        public void Test1()
        {
            using (var context = new BloggingContext())
            {
                var x = context.Set<Blog>().Single();

                Assert.Equal(0, x.NotId);

                x.NotId = -99;

                context.SaveChanges();
            }

            using (var context = new BloggingContext())
            {
                var x = context.Set<Blog>().Single();

                Assert.Equal(-99, x.NotId);
            }
        }
    }

    /// <summary>
    /// Apply this attribute to your test method to automatically create a <see cref="TransactionScope"/>
    /// that is rolled back when the test is finished.
    /// </summary>
    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = false, Inherited = true)]
    public sealed class AutoRollbackAttribute : BeforeAfterTestAttribute
    {
        TransactionScope scope;

        /// <summary>
        /// Gets or sets whether transaction flow across thread continuations is enabled for TransactionScope.
        /// By default transaction flow across thread continuations is enabled.
        /// </summary>
        public TransactionScopeAsyncFlowOption AsyncFlowOption { get; set; } = TransactionScopeAsyncFlowOption.Enabled;

        /// <summary>
        /// Gets or sets the isolation level of the transaction.
        /// Default value is <see cref="IsolationLevel"/>.Unspecified.
        /// </summary>
        public IsolationLevel IsolationLevel { get; set; } = IsolationLevel.Unspecified;

        /// <summary>
        /// Gets or sets the scope option for the transaction.
        /// Default value is <see cref="TransactionScopeOption"/>.Required.
        /// </summary>
        public TransactionScopeOption ScopeOption { get; set; } = TransactionScopeOption.Required;

        /// <summary>
        /// Gets or sets the timeout of the transaction, in milliseconds.
        /// By default, the transaction will not timeout.
        /// </summary>
        public long TimeoutInMS { get; set; } = -1;

        /// <summary>
        /// Rolls back the transaction.
        /// </summary>
        public override void After(MethodInfo methodUnderTest)
        {
            scope.Dispose();
        }

        /// <summary>
        /// Creates the transaction.
        /// </summary>
        public override void Before(MethodInfo methodUnderTest)
        {
            var options = new TransactionOptions { IsolationLevel = IsolationLevel };
            if (TimeoutInMS > 0)
                options.Timeout = TimeSpan.FromMilliseconds(TimeoutInMS);

            scope = new TransactionScope(ScopeOption, options, AsyncFlowOption);
        }
    }
}

Ok, so your example is pretty basic and I guess it might work fine when context is retrieved inside test method. But that's just a guess. In my case there's a whole test setup and context is provided by Fixture.
Something like this (I can't copy/paste production code, sory) so I'll try to write something similar with crucial aspects:
[Collection("collectionname")]
public class TestClass
{

private readonly TestHostFixture _testHostFixture;

public TestClass(TestHostFixture testHostFixture)
{
     _testHostFixture = testHostFixture;
}

[Fact]
[AutoRollback]
public async Task TestSomething()
{
   var response = await testHostFixture.Client.PostAsync(path, object);
   Assert.Equal(HttpStatusCode.OK, response.StatusCode);
}

}

So that's how the test looks like but there's nothing special in it. But the test config might be something that causes the issue:
 public abstract class TestHostFixture : ICollectionFixture<WebApplicationFactory<IntegrationTestsStartup>>
    {
        public readonly HttpClient Client;
        public readonly DbContext Context;
        public readonly AppSettings AppSettings;
        public TestHostFixture(string userName, string password) //params here to use through other, specific classes (different kind of test users)
        {
            var factory = new CustomWebApplicationFactory();
            Client = factory.CreateClient();

            var user = new AuthenticateCommand()
            {
                UserName = userName,
                Password = password
            };

            var jsoncontent = JsonConvert.SerializeObject(user);
            var httpcontent = new StringContent(jsoncontent, Encoding.UTF8, "application/json");
            var result = Client.PostAsync("/authenticateEndpoint", httpcontent);
            var token = JsonConvert.DeserializeObject<UserModel>(result.Result.Content.ReadAsStringAsync().Result);

            Client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", token.Token);

            var provider = factory.Server.Host.Services;
            Context = provider.GetRequiredService<DbContext>();
            AppSettings = provider.GetRequiredService<AppSettings>();
        }
    }

where IntegrationTestsStartup is a class that inherits from app Startup, in a nutshell:

sets new instance and get jsons, creates context:

public IntegrationTestsStartup(IHostingEnvironment env) :
            base(new ConfigurationBuilder()
                 .SetBasePath(env.ContentRootPath)
                 .AddJsonFile("appsettings.tests.json", optional: false, reloadOnChange: true)
                 .AddJsonFile("appsettings.tests.local.json", optional: true, reloadOnChange: true)
                 .AddEnvironmentVariables()
                 .Build())
        {
        }

services.AddDbContext<DbContext>(
                 options => options.UseSqlServer(Configuration.GetConnectionString("CONNSTRING"), b => b.MigrationsAssembly("MIGRATION_PROJECT"))
            );

Applies migrations
Seeds data + test data

  public override void SeedData(IServiceScope serviceScope)
        {
            base.SeedData(serviceScope); //base means Startup seed (system seed)
            new IntegrationTestData().SeedData(serviceScope.ServiceProvider.GetService<DbContext>()); //this is additional test data seed
        }

So that's pretty much it. Does this help?

@MichalLechowski The part that EF plays in all this seems very minimal--that is, EF enlists the connection into a transaction scope if one has been created. Currently I don't see anything indicating that that is not working. If you are able to create a small, runnable project/solution that demonstrates the behavior you are seeing, then we will investigate further.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Syntax error

path_dependency = "PATH_TO_GUEB+"/dependency/"
SyntaxError: no viable alternative at character '"'

Thanks!


Remove version: Calibre 6.20.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/109634&drop=dogfoodAlpha

What's the reason for removal?

What's the reason for removal?

It appears to have been removed by the publisher:

That's because they keep historic releases on their website, and only the latest on GitHub
https://download.calibre-ebook.com

@russellbanks @stephengillie, is there a standard policy on number of versions retained in the codebase?
There are 18 old versions of calibre in that package.

is there a standard policy on number of versions retained in the codebase?

No, there no limit or policy on the number of versions


Circuit Breaker config names are not the same as in Precipice

Here: https://github.com/tbrooks8/Beehive/blob/master/src/beehive/service.clj#L50
trailingPeriodMillisis changed to time-period-in-millis and so on.
Also, not all the config is exposed for reading.
-- Akshay and Nid

I believe that is is completed.
fa9edfac7f32f47dcf871af3903f57be7371ea0d


juicy-tile-grid should be loaded on-demand

Dependent on #99
Once we use stored CSS to display layouts, we can load juicy-tile-grid (including packer.js, etc) only when there are layout elements missing in CSS.
Discussed with @Starcounter-Jack and @tomalec on Monday

Closing, because it is related to the old layout editor which was phased out.


RuntimeError: NerfbustersTrainer is not attached to a Trainer.

It's me again. Here is another problem.
Traceback (most recent call last):
  File "nerfstudio/scripts/train.py", line 286, in <module>
    entrypoint()
  File "nerfstudio/scripts/train.py", line 275, in entrypoint
    main(
  File "nerfstudio/scripts/train.py", line 258, in main
    launch(
  File "nerfstudio/scripts/train.py", line 193, in launch
    main_func(local_rank=0, world_size=world_size, config=config)
  File "nerfstudio/scripts/train.py", line 102, in train_loop
    trainer.setup()
  File "/home/mypath/projects/nerfstudio/nerfstudio/engine/trainer.py", line 178, in setup
    self.viewer_state = ViewerState(
  File "/home/mypath/projects/nerfstudio/nerfstudio/viewer/viewer.py", line 240, in __init__
    if len(parse_object(pipeline, LegacyViewerElement, "Custom Elements")) > 0:
  File "/home/mypath/projects/nerfstudio/nerfstudio/viewer/utils.py", line 151, in parse_object
    lower_rets = parse_object(v, type_check, new_tree_stub)
  File "/home/mypath/projects/nerfstudio/nerfstudio/viewer/utils.py", line 139, in parse_object
    obj_props = [(k, getattr(obj, k)) for k in dir(obj)]
  File "/home/mypath/projects/nerfstudio/nerfstudio/viewer/utils.py", line 139, in <listcomp>
    obj_props = [(k, getattr(obj, k)) for k in dir(obj)]
  File "/home/mypath/.conda/envs/nerfstudio/lib/python3.8/site-packages/pytorch_lightning/core/module.py", line 179, in trainer
    raise RuntimeError(f"{self.__class__.__qualname__} is not attached to a `Trainer`.")
RuntimeError: NerfbustersTrainer is not attached to a `Trainer`.

I solved it by adding a dummy Trainer in the code.
Add this in line 47 of nerfbusters/lightning/nerfbusters_trainer.py
self._trainer = pl.Trainer()


AEP padding

Measured power values for wind speed bins in the AEP with no (or possibly very low) data count are being padded/gap filled with the measured power from the max wind speed bin. This appears to only occur if there are values in wind speed bins above and below the bins in question. See example files linked here.

To add to this, the AEP sheet in the Excel report still has the correct per bin values, even for incomplete bins, so until a fix is implemented you can sum the energy columns to get the correct value.

This is the problematic piece of code:
https://github.com/peterdougstuart/PCWG/blob/master/Analysis.py#L1227
It just pads when the bin is undefined, it needs to interpolate from adjacent bins using the specified interpolation method in cases when the bin is less than the last complete bin. This operation of interpolating intermediate bins should possibly be carried out before passing to the padder.

My fix does not account for padding below the first complete bin so reopening to solve this.


Name search not working through FME anymore

Hello this is Javier Merino working on EUNIS database.
I have been using the name search API through FME processes for quite a while but today it is not working.
I see the website and search is actually working but not through FME.
Has there been a change in security measures or a proxy?
The error can also be from the FME side. I am not sure if there has been an update.
Below is the error message I get in case you can help. Thank you!
HTTPCaller_CoL_API (HTTPFactory): [1]: HTTP transfer error: SSL connect error
HTTPCaller_CoL_API (HTTPFactory): [1]: Please ensure that your network connection is properly set up
HTTPCaller_CoL_API (HTTPFactory): [1]: No proxy settings have been entered.  If you require a proxy to access external URLs, please ensure the appropriate information has been entered
HTTPCaller_CoL_API (HTTPFactory): An error occurred while accessing the URL 'https://api.catalogue.life/dataset/3LR/nameusage/search?q=Vulpes vulpes indutus&limit=10'

Hi Javier. I dont know FME, but it looks like a general ssl connection problem. Me and our sysadmin are out this week, but we'll look into this next week. Can you get some more logs of why its failing to connect?

Hello Markus,
Thanks for the quick response.
Here is the log file from FME. I believe those lines pertaining to the issue are those I shared already but maybe there is more here that can help. We have not changed anything in the FME and it has always worked until today.
Test-Search-CoL.log

I figured out the issue. It seems to be related to the certificate. It has either changed or has expired.
If I turn the "Verify SSL-certificates" parameter in the HTTP Caller to "No", the call works

@MattBlissett the SSL certificates for production COL have expired on 27th december.

DEV seems to have 40 more days before that expires, but seems to have a bad domain name associated:

Oh, I just realized now this is the old, deprecated domain!
Please use api.catalogueoflife.org instead!

Thank you!


Request for source code for "Practical Swarm Intelligence in Python"

Dear Professor Ronald T. Kneusel,
My name is Alireza, and I am a Master's student at Qom University.
I am writing to ask for your assistance in obtaining the source code for your book Practical Swarm Intelligence in Python. I believe that this code would be a valuable resource for my research, as it would allow me to implement and test the algorithms and techniques that you describe in the book.
Also, my teacher (Professor Farjami) is also eagerly looking for these codes to explain them to his other students.
I understand that you may not be able to provide me with the code, but I would be grateful if you would consider my request.
Thank you for your time and consideration.
Sincerely,
Alireza Parchami

Please email me directly at<EMAIL_ADDRESS> Thanks!

Of course
thanks a lot.


Commands Pattern

I just realized there isn't any documentation here. I'll add that in later. Remind me if I haven't done it by the end of the sprint.

Whipped up documentation real quick.
Austin: This was designed mainly for the CLI and I don't think all of the commands need to be done in the same way. Noah was going to confirm on Thursday.
Tess: I think it's because it's initialized by a command. Ask Noah about it.

Sounds good! hopefully all is good then for thursday.


Bug: JSON schema references

What is the issue?
When using the JSON Schema in VSCode the following error is thrown:
Problems loading reference 'https://tier.run/docs/$defs/plan': Unable to load schema from 'https://tier.run/docs/$defs/plan': Not Found. The requested location could not be found.
<!DOCTYPE html><!-- Last Published: Tue Nov 01 2022 23:11:41 GMT+0000 (Coordinated Universal Time) -->
<html data-wf-domain="webflow.tier.run" data-wf-page="..." data-wf-site="61e.(768)

Steps to reproduce
Setup a pricing.json with the following in VSCode 1.73.0
{
  "$schema": "https://tier.run/docs/pricing.schema.json",
  "plans": {
    "plan:workshop@0": {
      "period": "@monthly",
      "features": {
        "feature:seat": {
          "aggregate": "perpetual",
          "tiers": [
            {
              "upto": 5,
              "base": 0
            },
            {
              "price": 9900
            }
          ]
        }
      }
    }
  }
}

Are there any recent changes that introduced the issue?
N/A
OS
Windows
OS version
Windows 11
Tier version
0.4.1

Aha, VSCode handles relative links a bit differently than the schema validator I was using locally.
Updated to correct the problem, seems to work now. You might need to restart VSCode to pick up the updated schema.

Wrote up how to wire this into nvim and vscode on our blog: https://blog.tier.run/validating-pricingjson-in-your-editor


Sanity check: Sample sizes of Kolomogorov Smirnov always the length of the distribution?

I noticed that KolmogorovSmirnov.hs#L103 mentions that m and n are "effective sizes" and use sample length as a proxy. I'm used to a different interface, passing in a pdf and size, so I'm wondering if someone can sanity check me that (a) the input samples are supposed to be raw frequencies instead of a pdf, and (b) if that isn't the case, why would we take the length of the input as our effective size.
Thank you!
-s

Okay, this is relatively tangent and I can ask it elsewhere. Going to close this for now.


Website push should point to new server

We have a new server, so let's use it! (There are changes to make in other packages as well....)

Not sure why this didn't get auto-closed


feat: treat git-error file as log (#176222)

Fixes #176222

See https://github.com/microsoft/vscode/issues/176222#issuecomment-1523283224


Investigate existing "Remote GPIO" projects

I believe that remote GPIO on RPi already is a thing, so investigate what is out there and if could be used, or learned from.

there are lot of python remote gpio libraries available

https://github.com/golemparts/rppal
there is also a rust library available for it

Yes, I'm using rppal in my old phone project, is pretty easy to use and works well. I will correct the reference in readme.
But it's not "remote" in the sense of accessing GPIO from a difference machine

yaa true

https://www.youtube.com/watch?v=b1IJfsaedSk
https://gpiozero.readthedocs.io/en/v1.3.1/api_pins.html
https://gpiozero.readthedocs.io/en/stable/remote_gpio.html
https://www.instructables.com/Raspberry-Pi-Remote-GPIO/
https://www.reddit.com/r/Python/comments/1b0cxwc/remoteio_a_remote_gpio_library_for_the_raspberry/
https://www.home-assistant.io/integrations/remote_rpi_gpio/

https://www.instructables.com/Raspberry-Pi-Remote-GPIO/
https://www.home-assistant.io/integrations/remote_rpi_gpio/

I tried remote gpio. It seemed to connect, but I couldn't get the simple python led flash example to change the LED....
Want to try @sundaram123krishnan and let me know if you get it working?

Sure, will try

Consider the pros and cons of using some existing method before we decide on our networking path

Neither of us could get remoteGPIO working so far...
If we can get it working AND it seems people use it already, or prefer it for some reason, then we can consider adding it as an additional networking option.

If having an accessible IP is acceptable to people, then accessing over SSH maybe worth looking at.
The user experience of remote dev/run using VSCode from host to RPi over SSH is excellent, and it can even install the required binaries on the target for you once SSH connection is established, and SSH offers you some level of security for who is accessing the target also.


Add Waiter for Athena

I want waiter for Athena.
Because this issue(boto/boto3#1212) and this Pull Request(#1358) remained unattended, I was created a new Pull Request.

Codecov Report

Merging #1868 into develop will decrease coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1868      +/-   ##
===========================================
- Coverage    92.56%   92.25%   -0.31%
===========================================
  Files           53       53
  Lines        10001    10001
===========================================
- Hits          9257     9226      -31
- Misses         744      775      +31

Impacted Files
Coverage Δ

botocore/awsrequest.py
92.45% <0%> (-5.91%)
:arrow_down:

botocore/compat.py
88.95% <0%> (-4.98%)
:arrow_down:

botocore/handlers.py
96.45% <0%> (-0.48%)
:arrow_down:

botocore/hooks.py
95.98% <0%> (-0.41%)
:arrow_down:

botocore/utils.py
97.81% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3576ba6...d27414a. Read the comment docs.

This is really needed as we always need to wait for the queries to complete!

Any update on when this will be added?

Hi all,
Thanks again for the request. We are now submitting requests for paginators and waiters upstream so that all AWS SDKs benefit from a consistent implementation. I will pass on the request for these waiters to the service team. We will also update the guidance in the contributing guide to better reflect this policy. I've added an issue to track this here:
aws/aws-sdk#80
Thanks again for bringing this to our attention!


Include CITE-seq processing in docs

As part of this Epic https://github.com/AlexsLemonade/scpca-nf/issues/291, we'll need to document processing steps taken for CITE-Seq (ADT) counts, including what those steps were, why we made those choices, and what is now contained in the relevant _processed_sce.rds objects.
Files to update include:

sce_file_contents.md
processing_information.md section on CITE-Seq quantification

add an additional subsection here to describe post-processing

This should probably be tackled in parallel with https://github.com/AlexsLemonade/scpca-nf/issues/293 (add ADT filtering) and https://github.com/AlexsLemonade/scpca-nf/issues/294 (add ADT normalization), at least in terms of getting started in its branch.
We may want to break this up into smaller issues, e.g. processing steps vs. SCE object contents. Along these lines, since we are not really planning to use positive controls/spike-ins (if present) during processing, we should include some minimal docs (essentially 1-2 sentences and a link to OSCA) explaining to that users could do processing differently if they wanted to on the unfiltered SCE object.

Note also the final SCE object will now have the output qc data frame from cleanTagCounts() in the CITEseq altexp's colData, if relevant.
The columns will differ based on whether there are negative controls, see: https://rdrr.io/github/MarioniLab/DropletUtils/man/cleanTagCounts.html

Closed by #110.


Merge v0.7.33 to prevent ReDoS

https://nvd.nist.gov/vuln/detail/CVE-2022-25927
Please merge v0.7.33 from base repo

@dnshi is this something you can help with? I see you merged the most recent pull request :)


Potential memory leak during Llama 3 8b model fine-tuning with LoRA

While trying to fine-tune meta-llama/Meta-Llama-3-8B-Instruct during training, the peak memory slowly grew to around 300GB and eventually caused the mlx-lm crashes.
How to reproduce

mlx 0.11.0
training dataset from https://huggingface.co/datasets/mzbac/function-calling-llama-3-format-v1.1/tree/main
lora_config.yaml

# The path to the local model directory or Hugging Face repo.
model: "meta-llama/Meta-Llama-3-8B-Instruct"
# Whether or not to train (boolean)
train: true

# Directory with {train, valid, test}.jsonl files
data: "data"

# The PRNG seed
seed: 0

# Number of layers to fine-tune
lora_layers: 32

# Minibatch size.
batch_size: 1

# Iterations to train for.
iters: 6000

# Number of validation batches, -1 uses the entire validation set.
val_batches: 25

# Adam learning rate.
learning_rate: 1e-6

# Number of training steps between loss reporting.
steps_per_report: 10

# Number of training steps between validations.
steps_per_eval: 200

# Load path to resume training with the given adapter weights.
resume_adapter_file: null

# Save/load path for the trained adapter weights.
adapter_path: "adapters"

# Save the model every N iterations.
save_every: 1000

# Evaluate on the test set after training
test: false

# Number of test set batches, -1 uses the entire test set.
test_batches: 100

# Maximum sequence length.
max_seq_length: 8192

# Use gradient checkpointing to reduce memory use.
grad_checkpoint: true

# LoRA parameters can only be specified in a config file
lora_parameters:
  # The layer keys to apply LoRA to.
  # These will be applied for the last lora_layers
  keys: ['mlp.gate_proj', 'mlp.down_proj', 'self_attn.q_proj', 'mlp.up_proj', 'self_attn.o_proj','self_attn.v_proj', 'self_attn.k_proj']
  rank: 128
  alpha: 256
  scale: 10.0
  dropout: 0.05

# Schedule can only be specified in a config file, uncomment to use.
# lr_schedule:
#  name: cosine_decay
#  warmup: 100 # 0 for no warmup
#  warmup_init: 1e-7 # 0 if not specified
#  arguments: [1e-6, 1000, 1e-7] # passed to scheduler

logs
Iter 6010: Train loss 0.430, Learning Rate 1.000e-06, It/sec 0.106, Tokens/sec 47.476, Trained Tokens 3213544, Peak mem 289.013 GB
Iter 6020: Train loss 0.313, Learning Rate 1.000e-06, It/sec 0.109, Tokens/sec 49.663, Trained Tokens 3218096, Peak mem 289.013 GB
Iter 6030: Train loss 0.503, Learning Rate 1.000e-06, It/sec 0.085, Tokens/sec 61.099, Trained Tokens 3225260, Peak mem 289.013 GB
Iter 6040: Train loss 0.332, Learning Rate 1.000e-06, It/sec 0.108, Tokens/sec 49.178, Trained Tokens 3229793, Peak mem 289.013 GB
Iter 6050: Train loss 0.268, Learning Rate 1.000e-06, It/sec 0.104, Tokens/sec 52.523, Trained Tokens 3234820, Peak mem 289.013 GB

Very strange .. seems like there is a leak of some sort.

and the crash logs:
Iter 7320: Train loss 0.216, Learning Rate 1.000e-06, It/sec 0.116, Tokens/sec 40.214, Trained Tokens 3893259, Peak mem 342.467 GB
libc++abi: terminating due to uncaught exception of type std::runtime_error: [malloc_or_wait] Unable to allocate 554319936 bytes.
zsh: abort      mlx_lm.lora --config lora_config.yaml

Seems to be related to gradient checkpointing but that's all I know so far.. turning off gradient checkpointing and the peak memory is constant for a fixed sequence length as expected.

Seems to be related to gradient checkpointing but that's all I know so far.. turning off gradient checkpointing and the peak memory is constant for a fixed sequence length as expected.

After disabling gradient checkpointing, the peak memory has stabilized. I will continue training for a few thousand iterations to see if everything is running as expected. Thanks @awni 🚀

@mzbac, a bit off topic and please let me know if I'm breaking some rules so I'll delete the comment.
But can you share an example of your dataset used for finetuning llama3 instruct? I am a bit confued by its template.
Thanks

@mzbac, a bit off topic and please let me know if I'm breaking some rules so I'll delete the comment.
But can you share an example of your dataset used for finetuning llama3 instruct? I am a bit confued by its template.
Thanks

@Satyam7166-tech  You can check the data here at https://huggingface.co/datasets/mzbac/function-calling-llama-3-format-v1.1/viewer and feel free to create a discussion there if you have any questions about the dataset.

@awni I can confirm that the issue is related to gradient checkpointing. With gradient checkpointing disabled, I trained the model for 8000 iterations and the peak memory is consistent and works as expected.

Just FYI, the leak should be fixed now with gradient checkpointing enabled.

Thanks for the fix!


Fix opcode cost

To ensure that we will not overflow in fast gas counter on multiplication - add check in VM instantiation.

Hm, I think this still runs into a risk of overflowing the gas cost during the intermediate multiplication calculation and miscounting the gas. In particular taking the sample reproducer from before, this is the assembly that we get:
   0x00007ffff54263c0: mov    0x128(%r15,%riz,1),%rax
   0x00007ffff54263c8: mov    0x10(%rax,%riz,1),%rcx
   0x00007ffff54263d0: mov    $0x64,%rdx
   0x00007ffff54263d7: rex    imul %edx,%ecx
   0x00007ffff54263db: mov    0x0(%rax,%riz,1),%rdx
   0x00007ffff54263e3: add    %rcx,%rdx
   0x00007ffff54263e6: jo     0x7ffff5426433
   0x00007ffff54263ec: cmp    %rdx,0x8(%rax,%riz,1)
   0x00007ffff54263f4: mov    %rdx,0x0(%rax,%riz,1)
   0x00007ffff54263fc: jbe    0x7ffff54264db
   0x00007ffff5426402: jmp    0x7ffff54263c0

For this specific example we multiply the provided opcode cost multiplier with the function argument (in this case a 0x64) as passed in through the test wasm code. So e.g. even an opcode cost of 0x28f5c29 is problematic as we'll ultimately count very little gas as an actual operation cost due to an overflow.
I don't know how the calls to the gas function end up materializing but at least to me the tests indicate to me that it may be called by anybody who wishes to do so?

it may be called by anybody who wishes to do so? In that case it seems to me that making the implementation robust is the approach we must take.

Yeah, that's sadly true. gas is just a usual host function, and you can just call it:
https://github.com/near/nearcore/blob/73bb54a7665e6aa0fa6bbd9930159a6669042a77/runtime/near-vm-runner/src/imports.rs#L364-L365
"Add intrinsics mechanism which isn't accessable to the contract itself" is on a todo list.

Not sure if it's a bug in our assembler or in disassembler you use. rex    imul %edx,%ecx looks wrong, it must be imulq $rdx, rcx.

Since the we multiply 32-bit integers imul %edx,%ecx is the expected instruction. x64 ignores the rex prefix for 32 bit operations AFAIK. The dissassembler is gdb.

Reworked logic by just avoiding intrinsification in cases where we shouldn't do it.

I think this is reasonable. Now that we verify that neither operand to multiply shall exceed i32::MAX, the multiplication itself can't overflow either.


SDK crash

SDK crashes

Hi @ahmedAsoliman ,
Can you please share more details,

Steps to reproduce the behavior

Environment (please complete the following information):
Xcode version:
CleverTap SDK Version:
Device:
OS:

CleverTap SDK integration code

If possible, a sample app with reproducible bug

Thanks!

this issue happens when user try to open deep link when app is closed
Xcode version: 15.1
CleverTap SDK Version: 5.2.2
Device: ANY
OS: 17.0 , 17.2.1

@AishwaryaNanna

Hi @ahmedAsoliman,
Thanks for the input, we will try to reproduce this.
Meanwhile can you try our latest release v6.0.0 and see if it helps?
Thanks!

@AishwaryaNanna  thanks for your quick response but it's the same issue

@AishwaryaNanna
1-  Integration method  manually
2- it happens when we user clicks on deep link not notification  when app is closed

Hi @ahmedAsoliman ,
Can you please share Sample payload to trigger same notification?
Thanks!


Produces attribute is not working

There's a long lasting reported issue about Produce attribute not working: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/63
I'll work on fixing it in this PR. I've managed to create a failing test so far. I'm completely new to Swashbuckle codebase, so if anyone can hint me the direction where to go, I would be extremely grateful.

I'm now hitting an issue caused by produces being empty (See https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/292). Have you had any luck at finding a solution.

just replace FromBody with FromForm

Just replace FromBody with FromForm


csharp-fibonacci-series

Why:
Closes [issue link]
What's being changed:

Added new folder csharp/programme
Added the solution .cs file

Check off the following:

[X ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ X] For content changes, I have completed the self-review checklist.

Hii @SrgjanX
Thanks for contributing to this open source project 😃

@SrgjanX Is there any issue with this PR ?


fix: don't lie about updated files

Updating involves some low-level git-fu. This can cause unpredicted files to get updated, and the report to the user sometimes is fake.
It'd be great to tell the truth, but for now at least let's just not lie.
Fix https://github.com/copier-org/copier/issues/943.

Well, it seemed more simpler but it seems to break too many things... I'll publish a better fix when I have time.

@yajo You nearly had it working, only the answers need recorded in the temporary (quiet) worker need to be assigned back to the main worker. I took the liberty to reopen this PR and add the missing piece.


system_installer fix cloud config partition not showing up

Merging this, not fully tested (waiting for hardware) but will clean up later as needed.


Use context manager form of rclpy.init()

Rolling-specific code for #4780

THis one needs a merge/rebase, then we can merge it in.


Settings not being saved in cookies

After choosing option to allow cookies, settings are not being saved.

Thanks for opening an issue, we'll check on that :)

So in looking closer at this, I turned on Developer tools and looked at the cookie information being stored.  I am seeing things like ability cards and gear being stored in the cookies, but it looks like only the gear is being restored when the site is reopened.  I also completely missed the save button at the bottom.

I did some more digging and I see what the issue is.  It loads the ability cards fine, if you have a character from the base "Vanilla" version.  If you have a character from Jaws of the Lion or Frosthaven, it doesn't load that.  I think you need to add a cookie for the version you selected, then load that data.  Then when it loads ability cards it will work fine.

I think I have a fix for this.  It is working on my local machine.  I don't want to mess up your github repository, as I am really new to this.  So here is the main.js file I modified.  I added the extra cookie for the version of the game and then when loading, use that.
main.js.txt

This is great, thanks a lot :-)
I'll merge this as soon as possible !


the inference is very slow

Hi all, when I try deepseek vl2 model at one A800 card, the inference time is about 3-4 minutes, is it correct?

The inference time at one A800 card should be in seconds.


Remove self-referential link

Reference: https://github.com/Zewo/CURIParser/pull/3
As requested by @Danappelxx

Great!


Removed not necessary NIB MSDN link

This PR removes/replaces the following NIB link
[NIB: How to: Handle Exceptions Thrown by Tasks](https://msdn.microsoft.com/library/d6c47ec8-9de9-4880-beb3-ff19ae51565d)
from the docs.
It's replaced by
https://docs.microsoft.com/en-us/dotnet/standard/parallel-programming/exception-handling-task-parallel-library
that contains the content of the MSDN link and much more.
Contributes to #1787
Also fixed couple of typos in the dataflow topic.

Thanks for making the additional change, @pkulikov. I'll merge your PR now.


boolean values allow true only on generated schema

We are generated schema automatically from java pojos using jackson libraries.  in that library boolean values automatically get "required", which makes sense as in java this is a primitive and so cannot contain null.
Unfortunately, forms are now generating with a checkbox  that only allows "true" as the value.  This appears new as it did not occur in prior versions of angular-schema-form.  Also, I don't believe this matches the schema where required would allow true or false but not null.
@json-schema-form/angular-schema-form-lead

Rereading my post, apologies if my ranting is unclear.  So to clarify, the schema below has "myBoolean" as a required field.  The generated form using the default form ["*"] displays an error when the checkbox is empty even though the underlying json value is set to false, which is valid according to the schema.  This started occurring after upgrading to the latest download.
{"$schema":"http://json-schema.org/draft-04/schema#",
"title":"my_schema",
"type":"object",
"additionalProperties":true,
"properties":{
"myArray":{"type":"array","items":{"type":"string","pattern":"^\d+$"},
"description":"string of numbers","title":"numbers"},
"myBoolean":{"type":"boolean","description":"If true, do something","title":"Do Something"}},
"required":["myArray","myBoolean"]}}

@jagould thanks for the report :)
I can see what you mean, I made a Gist of the working one that doesn't work in the current version to test against:
http://schemaform.io/examples/bootstrap-example.html#/3bc648fe6e7d6e3e348b396fc41f8ede

This is ready to be released in the next alpha as it was a logic fail when I moved Angular specific code into the core and replaced it with code that wasn't identical.


Some ideas about type reflection

What about reflection types in runtime, for example:
function myFn(a: string): string {
 return a + '1'
}

transpiled to

import t from 'tcomb'

function myFn(a) {
  myFn.__$.in(a)
  var res = a + '1'
  myFn.__$.out(res)
  return res
}

myFn.__$ = {
  in: t.Str
  out: t.Str
}

Now we can easy parse types in runtime and extract some info, this bridge for React.proptypes. We can easily build plugins for working with types in runtime.
class AnyComponent extends React.Component {
   propTypes: {
      a: string
   }
}

transpile to
import t from 'tcomb'
class Any {
  $schema: t.struct({a: t.Str})
}

What about using https://github.com/gcanti/tcomb for type checking?
Why tcomb? Because it's great runtime type specification. It's powerfull type assertion library with many types, which you reimplement internally in you plugin.

I don't like the idea of depending on another module for this, people forget to install it, it's hard to keep up to date with the babel plugin version etc. I want to keep things simple and fast.
However, whether we should support some kind of reflection is a different question, we could do that without requiring an external lib. E.g.
function foo (a: string, b: string): Array<string> {
  return [a, b];
}

could compile to:
function foo (a, b) {
  return [a, b];
}
foo[Symbol.for('types')] = [["string", "string"], "Array<string>"];

Obviously it'd have to be optional.

What about reusing typecheck in external libraries, not only local project. When we produce babel compiled library and publish it to npm (example: https://github.com/zerkalica/immutable-di/blob/master/package.json#L19) ? I produce production-ready code with external sourcemaps.

I don't want to parse all code in node_modules for each project. I want to compile my external library once and give to programmers option to use or not use sourcemaps and to enable or disable typechecking. Run-time checking must be optionally disabled in runtime via environment vars.

Look at babel-runtime, it's very good practice to extract helpers. Example: https://github.com/seangenabe/delayer, Promises - is very fat abstraction, but the shared via babel-runtime.

"hard to keep up to date" external library - it's strange, any application has many dependencies and just write correct version to package.json.

https://github.com/shuhei/babel-plugin-type-assertion uses external library rtts_assert and you don't need include it in you scripts.

We can reduce their size by generating specialized helper functions for each type we need to verify in a particular file. Most of the rest of the size is in the error message which is very tailored to the specific function and not reusable. The other advantage of this approach is that we get accurate stack traces which makes debugging very easy. This is not possible with a typecheck library, and I don't think that using one really buys us anything in practise.


Added few Traditional Chinese Characters into converting list.

Contribute to the converting list.

Hm, I guess failed AppVeyor test isn't issue from my end?

Not all pairs are valid. 「犭」is not simplified.

Not all pairs are valid. 「犭」is not simplified.

@BYVoid Do you mean that 犭 does not exists in Simplified Chinese at all, so no conversion needed?


clear-pr-merge-commit-message: broken

Description
The field is marked as "seen", but I merged a few PRs today and it never worked.
Related:

https://github.com/refined-github/refined-github/issues/6611

How to replicate the issue + URL
Any PRs you can merge in https://github.com/pulls?q=is%3Apr+is%3Aopen+user%3A%40me+archived%3Afalse+ or https://github.com/pulls
Extension version
24.10.22
Browser(s) used
Chrome
Token ⚠

[X] I set a token in the options page. I understand that some features require a token to work.

Ok it finally worked:

I assume it's just still:

https://github.com/refined-github/refined-github/issues/6611


Use only Uint8Array with gl.UNSIGNED_BYTE for browser compatibility

Fixes a compatibility issue with can be seen on the Data Tiles example with IE11 and some less old Chromium based Android browsers

https://bugs.chromium.org/p/chromium/issues/detail?id=961658

This will conflict with #12761.

It will need changing to texType != gl.UNSIGNED_BYTE || data instanceof Uint8Array ? data : new Uint8Array(data.buffer)
It might be easier to add that to #12761.

If the problem is just with using Uint8ClampedArray in the data tile example, I'd rather see us change that example (to convert to Uint8Array).

That is how I initially checked to confirm the problem, but the function could potentially be called from anywhere.  If there is no check for mis-matched gl and data types made in ol/webgl/TileTexture.js the typedef imported from ol/DataTile.js should not include Uint8ClampedArray and DataView and the calling code should ensure only Uint8Array and Float32Array are passed.

We document that the DataTile expects Uint8Array, Uint8ClampedArray, DataView, or Float32Array (as of #12761).  This is type checked for people that use tsc.  It is true that users could provide other garbage and that things would fail.
This data is ultimately passed to the gl.texImage2D() function that accepts ArrayBufferView type data.  As you pointed out, Chrome didn't support Uint8ClampedArray until version 76 (when https://bugs.chromium.org/p/chromium/issues/detail?id=961658 was addressed).
I gather from what you are saying that IE 11 also expects 8-bit data to be Uint8Array and not Uint8ClampedArray.  I don't think it makes sense to have a workaround in the library for IE 11 on this.  I do think it could make sense to update the data-tile.js example so it works in IE 11.  And if we want to add additional documentation to clarify what data types the DataTile loader expects, that could also make sense.

If the only browser affected was IE this would only affect the Data Tiles example as there is no way GeoTIFF can work without browser support for Symbol and Promise used by the workers.
Chromium based browsers should support GeoTIFF from version 38 (subject to a main thread polyfill for Promise.allSettled being needed up to version 76).  With Uint8ClampedArray converted to Uint8Array I can get the COG example working in Chrome 71 on an old Android tablet - but without that conversion there is simply a black screen similar to current Data Tiles example on IE.

Thanks for the additional detail, @mike-000.  I opened #12770 with a proposed fix.