Cannot create two CiliumEgressNATPolicy with the same egressSourceIP

The Cilium agents rejects egress gateway policies if they have the same egressSourceIP has an existing egress gateway policy.
level=warning msg="Failed to add CiliumEgressNATPolicy." ciliumEgressNATPolicyName=egress-sample2 error="CiliumEgressNatPolicy for egress IP <IP_ADDRESS> already exists" k8sApiVersion= k8sUID=4fd8cf1d-9592-4256-b248-201ddd6a5ded subsys=k8s-watcher

Reproduction steps
./cilium install --kube-proxy-replacement strict --config enable-bpf-masquerade=true --config enable-egress-gateway=true
cat << EOF > test-egresspolicy1.yaml
apiVersion: cilium.io/v2alpha1
kind: CiliumEgressNATPolicy
metadata:
  name: egress-sample1
spec:
  egress:
  - podSelector:
      matchLabels:
        kind: client
  destinationCIDRs:
  - <IP_ADDRESS>/32
  egressSourceIP: "<IP_ADDRESS>"
---
apiVersion: cilium.io/v2alpha1
kind: CiliumEgressNATPolicy
metadata:
  name: egress-sample2
spec:
  egress:
  - podSelector:
      matchLabels:
        kind: echo
  destinationCIDRs:
  - <IP_ADDRESS>/32
  egressSourceIP: "<IP_ADDRESS>"
EOF

Root cause
That is explicitly disallowed by the code at https://github.com/cilium/cilium/blob/e057d6058e426fbea5ff44946b46d2263e063e42/pkg/egressgateway/manager.go#L249-L255
Workaround
It's possible to achieve almost the same by combining the two policies:
apiVersion: cilium.io/v2alpha1
kind: CiliumEgressNATPolicy
metadata:
  name: egress-sample2
spec:
  egress:
  - podSelector:
      matchLabels:
        kind: client
  - podSelector:
      matchLabels:
        kind: echo
  destinationCIDRs:
  - <IP_ADDRESS>/32
  - <IP_ADDRESS>/32
  egressSourceIP: "<IP_ADDRESS>"

Note however that this new egress gateway policy will redirect traffic from kind=client destined to <IP_ADDRESS>/32 to the gateway even though the two original policies did not.

@MasterZ40 @anfernee Do you remember why you added that check? I can't think of a reason why that would be required.

Thanks for the answer and explanation @anfernee!

The reason being lots of times the IP carries some security identity to external applications (firewalls). We don’t want it to be hijacked intentionally (or unintentionally) by another workload.

I understand the intent, but shouldn't this be enforced by some other tool/software than the CNI? This is encoding a specific (legitimate) use case into the implementation and we'd rather avoid that. As outlined above, this limitation prevents at least one other legitimate use case. If folks want to prevent having two egress policies with the same egress IP, it seems they could easily implement that on top of Cilium without blocking other use cases, no?


Enhance documentation to reference new pipeline "options"

We are adding new "static_resolver" option (aka. group) to the "inspect_package" pipeline and the documentation needs to be updated
This is a follow up of:

https://github.com/nexB/scancode.io/issues/1066

This there now on the docs (with updates in the run command to support this from @tdruez ) with https://github.com/nexB/scancode.io/commit/f56daa287194bea415fbe921ecb5330a9aac0ed4, closing!


filter conn by addr/pubkey. closes #3

Introduce functions for filtering peers by address and by pubkey

LGTM


search reset and optimization #1421 #1392

Files modified
1.Checkproject.html
2.All Projects.html
3.MyProjects.html
4.project_private_view.html
5.Project_public_view.html

merged changes,


MGDOBR-13: Allow a user to update the Filter on a Sink Processor

https://issues.redhat.com/browse/MGDOBR-13
You can try updates to the filter using HTTP PUT. I have verified updated filters are deployed through our Controller and (in my test) a Processor configured to send events to Slack responded correctly to changes in the Filter.
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[x] Check if code and Github action workflows have been modified and if the modification is safe
[x] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Created https://issues.redhat.com/browse/MGDOBR-547 for e2e test coverage

Hi @r00ta updates completed. Thank-you.

@sutaakar Do you know if e2e tests are broken with Managed Connectors:-
Then Slack channel contains message with text "${bridge.mybridge.cloud-event.my-id.id}" within 1 minute      # com.redhat.service.bridge.integration.tests.steps.SlackSteps.slackActionTest(java.lang.String,int)
      org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in com.redhat.service.bridge.integration.tests.steps.Hooks that uses java.lang.String, java.lang.Stringjava.lang.String was not fulfilled within 2 minutes.

This PR has been rebased with main today.
I will retest and keep an eye on it.

@manstis E2E was working properly on master branch 3 hours ago.

The error in your comment came from the cleanup code which was trying to delete the processor (the logging should be improved to be more readable) and failed waiting until processor is removed. There would be more info in manager/operator log.


Dispelling Attacks Fix Causes Dispelling Attacks To Work Incorrectly On Inciter

The dispelling attacks fix causes Inciter dispelling attack on companions (sorry, I can't recall if it effects the Inciter themselves and I forgot to test before turning it off) seem to always cause the checks to be made as if the character was level 0.  After turning it off, it appears to be making the check correctly.
At a guess, I'm assuming you check the class to make sure they should properly contribute to the dispelling attack's caster level, and inciter isn't on the list?

Looks like I need to figure how inciter is supposed to work :/
On Tue, Jun 25, 2024, 13:21 Vaeliorin @.***> wrote:

The dispelling attacks fix causes Inciter dispelling attack on companions
(sorry, I can't recall if it effects the Inciter themselves and I forgot to
test before turning it off) seem to always cause the checks to be made as
if the character was level 0. After turning it off, it appears to be making
the check correctly.
At a guess, I'm assuming you check the class to make sure they should
properly contribute to the dispelling attack's caster level, and inciter
isn't on the list?
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/720, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPDAZTZXBTEZXSJ3GSLZJGYKDAVCNFSM6AAAAABJ4L4ZY6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TGMZVGIZTOMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


could you add "proxy" function?

when you gonna to visit some site which block your IP , you can solving that with proxy ,So is there any idea of this function?

Thanks, the Proxy method has been added


Pylance imports are not automatically resolved

 Environment data

Language Server version: 2021.4.1
OS and version: linux x64
Python version (and distribution if applicable, e.g. Anaconda): 3.8
python.analysis.indexing: undefined
python.analysis.typeCheckingMode: off

 Expected behaviour
pylance automatically resolves a package imports when it is installed.
 Actual behaviour
After installing a package, pylance is unable to resolve the import unless reopening the window. Instead it is returning an error reportMissingImports

OS: WSL 2 Ubuntu 20.04
VSCode 1.55.2 + Remote - WSL 0.39.6
Python extension: 2021.3.1
Pylance: 2021.4.1
Python 3.8.2
Can confirm something similar, if not the same issue.

This is largely a dupe of #68 or #253.
Our canonical solution to this is to set extraPaths, see the troubleshooting doc: https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#unresolved-import-warnings
But, if you could try out this WIP option, it may help your case:
"python.analysis.useImportHeuristic": true

Hey @jakebailey
I did try explicitly mentioning site-packages path in extra paths, but no luck there. btw I am facing this issue in both my local and remove dev container environments.
Let me try the WIP option.

Agh, I'm sorry; I was referring to @navneethc and missed your actual issue. Don't set that to fix your issue with installing packages. That's a known issue for interpreters that live outside the workspace, and I'll find the issue we have for that already.

The issue about needing a reload on package install is #923; I tried to fix it once but it caused some problems so was reverted. You can follow that issue instead.


Support more format of memory maps

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 79.21%

Files with Coverage Reduction
New Missed Lines
%

src/Lib/Process/MemoryMap/ProcessMemoryMapParser.php
1
96.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
1905

Relevant Lines:
2405

💛  - Coveralls


⚠ ClamAV has degraded performance

In 5082b8b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 457 ms

Resolved: ClamAV performance has improved in 01c33d6 after 542 days, 21 hours, 40 minutes.


Rename incorrect "collection" to be "container".

When following the steps for the API for Gremlin section of connecting to the emulator, the docs say to create a database called "db1" and a collection called "coll1", when the user is actually creating a container named "coll1" using the emulator's data explorer.

@StefArroyo

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@noamaster, I will pull this in using another PR so you will get contributor credit.


Add Belebele Retrieval

Checklist for adding MMTEB dataset

Belebele is a multiple-choice machine reading comprehension (MRC) dataset spanning 115 distinct languages

[x] I have tested that the dataset runs with the mteb package.
[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[x] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
[x] I have filled out the metadata object in the dataset file (find documentation on it here).
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.
[x] I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

I would agree we are ready to merge when we fix my minor comments.

@Andrian0s I think your comments were not posted, they're not visible on my side

@Andrian0s I think your comments were not posted, they're not visible on my side

ah, thank you, should be visible now

As far as I know, this dataset spawns from FLORES, which is already covered from datasets likes SIB. Not a retrieval dataset, but still covers the languages

I'm sure the languages are covered if you consider all tasks/datasets on mteb, but from what I understand you get a bonus if the language is new for its task type, in this case for retrieval

@jupyterjazz, sorry for taking over this PR with a discussion on points. I believe you can merge this as long as it is acceptable to you that we might reduce the point at a later stage (following the discussion above).

@KennethEnevoldsen, thanks for the review and the discussion. I changed my score to 100 based on this comment https://github.com/embeddings-benchmark/mteb/pull/636#discussion_r1597467581
If everything looks good, please feel free to merge the PR as I'm not allowed to do it myself. Thanks again!

@KennethEnevoldsen, thanks for the review and the discussion. I changed my score to 100 based on this comment https://github.com/embeddings-benchmark/mteb/pull/636#discussion_r1597467581
If everything looks good, please feel free to merge the PR as I'm not allowed to do it myself. Thanks again!

It should be 50 according to this rule: https://github.com/embeddings-benchmark/mteb/pull/666
@KennethEnevoldsen  @isaac-chung

@imenelydiaker let us keep it at 100 for existing contributions (as they started their contributions before the above discussion).


It's unable to press space in HTML input/textarea

Describe the bug
We cannot insert spaces in HTML input/textarea in the same page as Toast UI
To Reproduce

Go to 'http://jsfiddle.net/m3h2cvfz/40/'
Click on 'input area'
Type anything + space
See error

Expected behavior
Expect to insert space in any HTML textarea or input area correctly.
Screenshots
None.
Desktop (please complete the following information):

OS: [Windows 10 Home]
Browser [Chrome]
Version [89]

Smartphone (please complete the following information):
None.
Additional context
Is there a way to disable the hand button?
Because everytime when I press the space it would press the hand button.

@ArtElect
Thank you for reporting. It seems to be the same issue as #555 and I will resolve with it quickly.

@ArtElect
Resolved in v3.14.1. Thank you.

Tried installing the version, 3.14.1 it still exists

@yashrahurikar23 yeah, if you only press once it won't work but if you hold down the Space it will work.

@yashrahurikar23 @ArtElect
I have exactly identified the problem! I will fix it ASAP.

Thanks @lja1018

When will a version be released with this fix in it? It is causing problems in my client's platform as we render the image editor in a modal. So once the modal is closed the spacebar issue is shown in all inputs across the web page. Needless to say this is quite a glaring problem for us

@marcodafonseca
It will probably be resolved tomorrow through the 3.14.2 release. Thank you!

@yashrahurikar23 @ArtElect @marcodafonseca
Resolved in v3.14.2. Thank you :)

it also fire v3.15.2
when i use addText method.
textarea open and focusing but when i typing english or number and type space focus out
but korean is work very well (but i typing korean and click space twice same)
example
abc(space)<- focus out
123(space)<- focus out
가나다(space)라마바사<- work well
가나다(space)(space)<-focus out


Remove empty selectable option

Hello. I think it is quite confusing and possible error-prone if you allow user to select an empty value. Do not know what is purpose of it but if you still want to keep and you do not accept this PR then we can include some conditional and add a prop to remove it as again it could produce bugs if we allow selecting null as a value.

Sorry for the late replies...
I think it is better to create a prop to either remove or put it there. However, the reason for putting the empty selectable there is that on iOS by default, the first option is selected and if a user wanted that option it will not trigger the on change event in order to change the state of the selected item.
Let me know if your test shows otherwise.


Try using PyMuPDF ("fitz") library for redaction

Previously we used a vendored / customised PDF redactor for this
purpose, but it doesn't always work 1. In this circumstance, we
rely on DVLA being able to manually print these letters 2, which
isn't ideal. Using the PyMuPDF redactor should always work, as it
uses a simpler technique of wiping all text in the box 3, while
the previous redactor tried to find the first address-like string.
This is just a test commit - to make testing easy, I've hooked up
the "/preview" endpoint so it runs a full sanitise on page #1.
A possible flaw with this approach is that it will wipe any other
text that it will wipe any other content in the address box, but
that should be fine because there can't be any: we're using the
same box we use to extract the address 5, so we should never get
as far as redacting the address if there is any extraneous text in
there, as the letter would be marked as invalid because of it.
Still, this is something that would need more scrutiny. In addition,
we're now passing each PDF through the PyMUPDF library, which may
make other dodgy changes - I haven't seen anything bad in my tests.
Screenshots
The green fill is just to show where the redaction is happening. I
manually tested with the PDF mentioned in https://github.com/alphagov/notifications-template-preview/pull/617 :

Confirmed the old redactor fails to redact it.
Confirmed redaction works with PyMUPDF.

Old redactor
PyMUPDF

Things to do

[ ] Decide if we want to pursue this work (bug card / impact / effort)
[ ] Update DVLA (email subject: "Alignment Issue - Hackney")

Thanks @CrystalPea. Yes, it's an exciting development 😃.
I was also a bit sceptical, but I've done an experiment to reassure myself:

I reused part of the deployment instructions to process a PDF before and after the change and save the results to separate files - one file being how we do it now, and one with the change in this PR.
I also commented out this line and ran the same testing code to produce a PDF with one address hidden beneath the other (like you mentioned in your comment).
I than ran all three PDFs through the following code (adapted from extracting the address block). For the before/after PDFs there is only one instance of "nceyshktvrai", whereas for the overlap PDF there are two.

import fitz
f = open('over_hackney_sample.pdf', 'rb')
doc = fitz.open('pdf', f.read())
words = doc[0].get_text_words()
[w[4] for w in words if 'nceyshktvrai' in w[4]] # the fourth element is the actual text

It could be the original address is still hidden in the PDF somewhere, but there's no evidence of this. To get a little more reassurance, I've sent two test PDFs to DVLA to see if they can print them:

One PDF was processed using the new approach in this PR (ideally this prints OK).
One PDF was not redacted and the original address is hidden (ideally this confirms previous issues).

Hey @benthorner what you did to test this new way is really thorough and methodical, and looks really promising, well done! Fingers crossed that results from DVLA are as expected, that would mean our process can be improved <3


Change error vars (e.g. BAD_SUBJECT_ERR) to strings

Working out an issue implementing the node-nats-streaming library and I was initially confused by the stack trace until I realized that it's because the Error objects are being instantiated as soon as the library was required, causing the stack trace to show the trace to the point the objects are instantiated, not the point that they're thrown.
Obvious suggestion is to set the error vars to strings and instantiate Error when throwing, e.g. throw(new Error(BAD_SUBJECT_ERR)). This change also seems slightly more efficient, as right now you have error objects always hanging around in memory whether they're needed or not.
Before this change, the stack trace looks like this:
<path>/node_modules/node-nats-streaming/node_modules/nats/lib/nats.js:938
      throw(BAD_SUBJECT_ERR);
      ^
Error: Subject must be supplied
    at Object.<anonymous> (<path>/node_modules/node-nats-streaming/node_modules/nats/lib/nats.js:70:23)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (<path>/node_modules/node-nats-streaming/node_modules/nats/index.js:1:80)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (<path>/node_modules/node-nats-streaming/lib/stan.js:15:12)
    at Module._compile (module.js:409:26)

After the suggested change:
Error: Subject must be supplied
    at Client.publish (<path>/node_modules/node-nats-streaming/node_modules/nats/lib/nats.js:938:13)
    at Client.request (<path>/node_modules/node-nats-streaming/node_modules/nats/lib/nats.js:1116:8)
    at Stan.subscribe (<path>/node_modules/node-nats-streaming/lib/stan.js:490:11)
[ stack trace from my code truncated ]

As you can see, the second stack trace is informative, the first is not.
Happy to submit a pull request for this unless you want to handle it a different way.

Hi there thanks for the report. This issue as you have found above, affects both node-nats and node-nats-streaming. The issue should be fairly easy to fix, since we can easily identify all the throw points. Let me do a fix.
Thanks for the report.

Thanks!

Fix for node-nats-streaming is ed6bdc7ea965eeeaa3b693451c9ca8043c0d2d4b


using in chrome app background/event page prevents it from going inactive

Once you load the google-analytics-bundle.js into an event/background page, it will never go "inactive", which an event page should do when there are no pending callbacks, etc.
Probably I just need to run my GA code in a hidden window which I create/destroy on demand, but perhaps there is a better solution.

This is probably a question for chromium-dev. The background page should go inactive. I recall that in certain IO intensive situations it will not, but if I recall correctly only disk IO will keep the background from going inactive.


graphql query to GitHub yields wrong results

likely reason: The updated security token has not been accepted at fly. Maybe need to re-deploy...

yep, fixed with re-deploy


Elm 0.17.1 doesn't build

Issue description
I'm on unstable.  When doing nix-env --upgrade, the Elm compile fails, leaving me with the previous version.  The specific error:
[75 of 88] Compiling Elm.Docs         ( src/Elm/Docs.hs, dist/build/Elm/Docs.o )

src/Elm/Docs.hs:102:25: error:
    • No instance for (Num Json.Indent) arising from the literal ‘2’
    • In the ‘confIndent’ field of a record
      In the expression:
        Json.Config
          {Json.confIndent = 2, Json.confCompare = Json.keyOrder keys}
      In an equation for ‘config’:
          config
            = Json.Config
                {Json.confIndent = 2, Json.confCompare = Json.keyOrder keys}
            where
                keys = ["tag", ....]
builder for ‘/nix/store/irjap10vl1idnkk0flmxjncj1nlqnagq-elm-compiler-0.17.1.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/v7w2l6vjngs67z9pxmnnd91z368bw309-elm-0.17.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/v7w2l6vjngs67z9pxmnnd91z368bw309-elm-0.17.1.drv’ failed

Steps to reproduce
Have elm installed, execute nix-env --upgrade.  Or presumably not have elm installed, be on unstable, and install it.
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)

16.09pre87733.dbd856d (Flounder)

Nix version: (run nix-env --version)

nix-env (Nix) 1.11.2

Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

"16.09pre87733.dbd856d"

Related to https://github.com/elm-lang/elm-compiler/pull/1431. elm 0.17.1 is broken against aeson-pretty 0.8.
Bulids for me locally by locking the upstream aeson-pretty dependency to aeson-pretty_0_7_2 within both elm-package and elm-compiler; however I'm not submitting a PR for that as this was fixed upstream and we're just waiting for a new elm release to drop.

Because my teachers always asked me to show my work, here is my patch... it's just a temporary solution until upstream cuts a new release.
https://gist.github.com/bradediger/f0b478259b3c494b9cbf08ad19446bfc

@bradediger  when applying your patch I get error: undefined variable ‘aeson-pretty_0_7_2’ at /home/despairblue/git/nixpkgs/pkgs/development/compilers/elm/packages/elm-package.nix:25:11
Do I need to declare that specific version somewhere else as well?

Nevermind, working now :confused:

Could someone open a PR?

@domenkozar: #17511. Thanks!


correct batch_norm docstring

In response to #4361

Can one of the admins verify this patch?

@tensorflow-jenkins Test this please.


Supply nix cache secrets to builder

Why
So, this error:

seems to be due to scripts/setup_nix_binary_cache.py's create_netrc() needing these envvars

which would be provided by

if this secret were available

What changed
Expose that secret to the build phase
Test plan
Verify that warning disappears. Presumably the build cache being present will only make the build faster, and we can rely on nix to not ship something broken beyond that.
Rollout
N/A

[x] This is fully backward and forward compatible

As I was requesting Ryan, GitHub's UI got excited and re-added devex, which then re-triggered the round-robbin, hence the PR party. Please pardon the noise.

Looks like it shaved off ~15m from the build time 🎉


Take control of crtl + c

Ciphey should print out the prob table and some extra info if people cancel the program halfway through running

Oh! Maybe, Ciphey can print this at the start?


Updating FR.json translations

Hi!
I've fixed a translation error ("Punaise" is a french word that refers to a real bug, with legs and all that kind of stuff) and I also changed some words and punctuations marks that I found more relevant.
Feel free to ask me anything regarding this commit!

Haha, that is a funny error to make :) Thank you for catching that and raising a PR to fix it. Really appreciate it.


:+1: Use Streams API instead

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e6f5562). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   67.21%
=======================================
  Files           ?        8
  Lines           ?      302
  Branches        ?       16
=======================================
  Hits            ?      203
  Misses          ?       99
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat(world): require namespace to exist before registering systems/tables in it [C-01]

There are a couple other places where we can explicitly check for resource existence, will do that in the PR for L-09


elasticsearch.keystore: Device or resource busy

Chart version: 8.5.1
Kubernetes version: 1.23.12-gke.1600
Kubernetes provider:  GKE (Google Kubernetes Engine)
Helm Version: version.BuildInfo{Version:"v3.9.3", GitCommit:"414ff28d4029ae8c8b05d62aa06c7fe3dee2bc58", GitTreeState:"clean", GoVersion:"go1.19"}

Describe the bug:
Exception in thread "main" java.nio.file.FileSystemException: /usr/share/elasticsearch/config/elasticsearch.keystore.tmp -> /usr/share/elasticsearch/config/elasticsearch.keystore: Device or resource busy
Steps to reproduce:

Create the secret

kubectl create secret generic elk-backup --from-file=gcs.client.elk-backup.credentials_file=./elk-backup.json

To add these secrets to the keystore:

keystore:
  - secretName: elk-backup

Expected behavior:
mount the secret in keystore should work
Provide logs and/or server output (if relevant):
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting
Exception in thread "main" java.nio.file.FileSystemException: /usr/share/elasticsearch/config/elasticsearch.keystore.tmp -> /usr/share/elasticsearch/config/elasticsearch.keystore: Device or resource busy
at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:100)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:420)
at java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266)
at java.base/java.nio.file.Files.move(Files.java:1430)
at org.elasticsearch.common.settings.KeyStoreWrapper.save(KeyStoreWrapper.java:498)
at org.elasticsearch.common.settings.KeyStoreWrapper.save(KeyStoreWrapper.java:412)
at org.elasticsearch.cli.keystore.AddStringKeyStoreCommand.executeCommand(AddStringKeyStoreCommand.java:102)
at org.elasticsearch.cli.keystore.BaseKeyStoreCommand.execute(BaseKeyStoreCommand.java:64)
at org.elasticsearch.common.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:54)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:85)
at org.elasticsearch.cli.MultiCommand.execute(MultiCommand.java:94)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:85)
at org.elasticsearch.cli.Command.main(Command.java:50)
at org.elasticsearch.launcher.CliToolLauncher.main(CliToolLauncher.java:64)

Any additional context:
I can seeing this error in pod with role master

I'm not sure but maybe it's because the keystore file is mounted as a subpath in the chart
- name: keystore
  mountPath: /usr/share/elasticsearch/config/elasticsearch.keystore
  subPath: elasticsearch.keystore

I don't know how elasticsearch-keystore tool works but it looks like it's trying to replace elasticsearch.keystore file by elasticsearch.keystore.tmp file instead of replacing the content of it.
I reproduce the issue by trying to do the following command:
mv elasticsearch.keystore.tmp elasticsearch.keystore
mv: cannot move 'elasticsearch.keystore.tmp' to 'elasticsearch.keystore': Device or resource busy

cp command works just fine
cp elasticsearch.keystore.tmp elasticsearch.keystore

I see 2 possibilities to fix that:

change the way elasticsearch-keystore write content in keystore file
add the possibility to specify a custom path for the keystore file and mount it in is own directory to prevent the use of subpath

Hi @TanguyPatte

seems like there is something wrong with the current statefulset.yaml that causes this issue.
FWIW deploying with this template works well for elasticsearch 8.6.2 : https://github.com/elastic/helm-charts/blob/d4e9f6bc47cf7f7ad4dfaaec102e1327d8a345e3/elasticsearch/templates/statefulset.yaml
but there may be more recent iterations that may work.

Chart version: 8.5.1
Kubernetes version: 1.23.12-gke.1600
Kubernetes provider: GKE (Google Kubernetes Engine)
Helm Version: version.BuildInfo{Version:"v3.9.3", GitCommit:"414ff28d4029ae8c8b05d62aa06c7fe3dee2bc58", GitTreeState:"clean", GoVersion:"go1.19"}
Describe the bug: Exception in thread "main" java.nio.file.FileSystemException: /usr/share/elasticsearch/config/elasticsearch.keystore.tmp -> /usr/share/elasticsearch/config/elasticsearch.keystore: Device or resource busy
Steps to reproduce:

Create the secret

kubectl create secret generic elk-backup --from-file=gcs.client.elk-backup.credentials_file=./elk-backup.json

To add these secrets to the keystore:

keystore:
  - secretName: elk-backup

Expected behavior: mount the secret in keystore should work
Provide logs and/or server output (if relevant):
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting
Exception in thread "main" java.nio.file.FileSystemException: /usr/share/elasticsearch/config/elasticsearch.keystore.tmp -> /usr/share/elasticsearch/config/elasticsearch.keystore: Device or resource busy
at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:100)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:420)
at java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266)
at java.base/java.nio.file.Files.move(Files.java:1430)
at org.elasticsearch.common.settings.KeyStoreWrapper.save(KeyStoreWrapper.java:498)
at org.elasticsearch.common.settings.KeyStoreWrapper.save(KeyStoreWrapper.java:412)
at org.elasticsearch.cli.keystore.AddStringKeyStoreCommand.executeCommand(AddStringKeyStoreCommand.java:102)
at org.elasticsearch.cli.keystore.BaseKeyStoreCommand.execute(BaseKeyStoreCommand.java:64)
at org.elasticsearch.common.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:54)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:85)
at org.elasticsearch.cli.MultiCommand.execute(MultiCommand.java:94)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:85)
at org.elasticsearch.cli.Command.main(Command.java:50)
at org.elasticsearch.launcher.CliToolLauncher.main(CliToolLauncher.java:64)

Any additional context: I can seeing this error in pod with role master

@SashaShcherbyna
I have got the same error, Did you have a solution to resolve this issue?

I can resolve this issue because I have not set ELASTIC_PASSWORD with my own credential.
Just add
extraEnvs:
  - name: ELASTIC_PASSWORD
    valueFrom:
      secretKeyRef:
        name: elastic-config-credentials
        key: password

secret:
  enabled: false

and then add the keystore just normal.


fastlane ios analyze does not work

@KrauseFx : I am attaching this screenshot. Everything works fine till 'fastlane test'. After that, it starts showing errors on commands. I am not able to understand how to go about taking the screenshots.

Could you also share your Fastfile?

I haven't made any changes to the FastFile as such.

Hi @ankitgupta1309
I think you may misunderstand how Fastlane works.
If you want to be able to call fastlane ios analyse, you need to have a lane analyze in the platform :iossection of your Fastfile. Something like this:
lane :analyse do
  # xcodebuild analyze
end

However, as you can see in my code snippet, I am not aware of any direct command to execute analyze on a project from Fastlane. I think something can be done using the xcodebuild action to achieve that.

Thanks for jumping in @Liquidsoul :+1:

going to close this issue for now because it has been inactive for quite a while. feel free to reopen if necessary!! :cat2:


Use Touch Display on first Bootup over GPIO per default

we should enable the output on the GPIO Display per default, cause its easyer for people to set up, and no external monitor is required then.
I think the best is to install necessary drivers and do system changes before the initial setup automatically.
Some simple commands should be enough:
sudo rm -rf LCD-show
git clone https://github.com/goodtft/LCD-show.git
chmod -R 755 LCD-show
cd LCD-show
sudo ./LCD35-show
but we have to test tis solution. Would be great to hear feedback.

is it possible to use Both, GPIO and USB to display the same?

just use touch display with micro hdmi port...


fatal error: concurrent map writes

This error occurs after about 2 minutes of running the program.
2024/02/28 13:53:01 [nodegraph plugin] Connection: src=<IP_ADDRESS> srcName=service-info-68744b99bd-6g88q srcPort=49444 srcNS=defaultdst=<IP_ADDRESS> dstName= dstPort=4337 dstNS= closed=true bytesSent=1354 bytesReceived=649 duration=0.134677404
fatal error: concurrent map writes

k8spacket version: 1.2.1
k8s version: 1.21

Hi @zzl221000
Version < 2.0.0 uses a global map to keep connection items indeed and this causes the problem (although used sync.RWMutex lock).
In version 2.0.0 k8spacket uses the bbolt KV database with transactions and this is concurrency-safe
Are you able to use version 2.0.0?
It's faster, better, more efficient. Remember about the limitation - Linux kernel >= 5.8

Linux kernel >= 5.8

All of our machines have linux kernel version 4.18, so it looks like we'll have to give up on k8spacket

Hi @zzl221000
It's a good idea to upgrade the kernel version. 4.18 had EOL in 2018.
It sounds like a win-win option - better security and the possibility to try k8spacket 😉
I'm going to close this issue.
If you have more questions feel free to reopen it.


Implement decompose_qpd_instructions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

83 of 83 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 86.368%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
1755

Relevant Lines:
2032

💛  - Coveralls


never use check-missing: false

previously: #903

https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/4545/ (404 til Jenkins queue clears)

SUCCESS 122 BLOCKERS: 17 cats-effect, 14 jawn-0-11, 12 wartremover, 11 metaconfig, 10 akka-http, 9 jawn-0-10, 9 twirl, 3 tut, 2 scrooge, 1 scalacheck-shapeless, 1 parboiled2

I think this is likelier to happen if I chip away at it, rather than try to get it through as one big PR


error NU1100: Unable to resolve 'Newtonsoft.Json (>= 12.0.1)' for '.NETCoreApp,Version=v2.1'

I get this error when i build :-1:
error NU1100: Unable to resolve 'Newtonsoft.Json (>= 12.0.1)' for '.NETCoreApp,Version=v2.1'

Were there any updates to this that resolved this issue? This is outside of my area of expertise but it's preventing me from continuing with the MS Learn module.

Honestly I'd need to run through the module again to give you specific details. I had someone else build it and send me the files that included the dependency after they changed some things. I'll get back to you on this.

I am also facing the same issue.

This is also outside of my skillset, but I resolved this by:

The build error message states that it cannot find version <= 12.0.1 but found the nearest version 9.0.1.
In Visual Studio, open the NuGet Package Manager (Menu bar, Project/Manage NuGet Packages...
Locate Newtonsoft.json, change version from 12.0.1 to 9.0.1.
Build again, should be good to go.

How i solve it on my side:
Using VSC i've opened terminal, and i went to the folder where i have the project:

cd .\Tailspin.SpaceGame.Web\
dotnet add package Newtonsoft.Json

After this dotnet build --configuration Release succeed.

none of the above resolutions worked for me
even i'm getting the same error, can someone please help

Apologies for any issues folks encountered while building the app. We've removed the dependency on this package, so you won't see that error going forward. Closing this for now.


(PUP-5482) Flag that a type could not be found

If a Ruby type is not available in the file system, every time it is found by
the parser, the Autoloader will scan all over again the directories in
search_directories for it. This generates tons of stat()s that can be saved.
This patch annotates that a type could not be found so the next time it is
required during the compilation of a catalog, the file system is not hammered
again unnecessarily.
This optimization has given us a ~61% reduction in the number of stats per
compilation, as we make an extensive use of the concat module which only
provides Puppet "defined types".

Thank you for your contribution @nbarrientos. This is reminiscent of PUP-1592, in which we short circuited the lookup process for defined types. Perhaps we have regressed? /cc @hlindberg

Sure sounds familiar. What we did then was to not search for ruby resource types when the name was namespaced (since currently types cannot be name spaced). We did nothing for user defined types though. Back when this was done, it was expected that adding a missing file would mean it got picked up. Now with environment caching it is different.
Note that the new loaders (currently only used for 4.x functions) scans the file system once for an environment and keeps that information. The intent is to switch to the new loaders also for types and defines.

While I am not completely familiar with the lifecycle of metatype/manager.rb stuff - the change looks ok - it is just checking if it knows or not, the change does not affect anything having to do with how this information is bound/cached etc. Looks ok for 4.x. (This change would not have worked on 3.x due to the expectancy to be able to find added files).

I am curious - are there lots of user defined types that have a name that is not fully qualified? Otherwise I cannot see how the change in this PR helps since the first thing the type method does is to return nil if there is a ':' in the name.

Thanks both for looking at the patch. Probably we wouldn't have hit this in the first place if we were using concat fully qualified as you mentioned due to this. However, the optimization might still make sense to avoid degrading the performance if users don't use the types sensibly.
@hlindberg, We're actually testing the patch on 3.8.4 as we haven't moved to 4.x yet, could you please elaborate on why it wouldn't work? We're seeing a significant improvement in the performance with the patch however we might be breaking something else without noticing :)

Actually in our case this makes a big difference as, even though our catalog only contains 6 resources of type Concat, type() is called with "concat" as parameter 172 times per compilation forcing the autoloader to scan the disk. However, we have plenty of Concat::Fragment resources so maybe there's a bug somewhere triggering a call to type("concat") when a Concat::Fragment is found. Otherwise I fail to find right now an explanation for such a big number of calls. Nevertheless, with the patch on, the situation becomes less dramatic as only one of those 172 has to actually stat() the disk.
However, I can also see that the function is called several times with "::concat::fragment" as parameter and those calls return indeed immediately after the check in L140.

Well, I've just repeated the same experiment with the Service type and the behavior described above showed up so I'm assuming that's normal. There are only 15 resources of type Service in our catalog, however type("service") is called 100 times. This has no impact though as the type is found the first time that the function is called so no disk hammering here.
However these multiple calls that are taking place kind of justify in my opinion the need to have a protection aimed to types that are not Ruby ones, in order to avoid unnecessary stat()s that are issued when resolving the few Puppet defined types that don't have "::" in their names (like concat).

The problem with 3.x (non directory environments) is that it is expected to be able to find files dynamically at any time. A 3.x environment keeps monitoring files that are in use, and if they change the cache is evicted. That works fine for existing (or files being removed), but it does not work when files are added if the cache contains a blocking not-found/nil entry since there will never again be a search for  the corresponding file (until cache is evicted for other reasons). You would need to touch another file if a type is added or restart the master. In practice, say when using r10k, it is most likely that other files are changed at the same time. Thus for 3.x and some users configurations, the proposed patch would change the behavior when switching between versions of the environment and if a user is unlucky the change would not be recognized.
This is in contrast to 4.x and directory based environments where the caching semantics are different.
I suggest that the patch is accepted for 4.x, but not for 3.x, and that module authors should be encouraged to change all unqualified references to qualified (since that also speeds up the resolution in other ways).
There are test errors to deal with as well before accepting.

Okay, thanks. A question, though. Would it be safe to backport the patch a deploy it locally as we're using 3.x and directory environments?

@nbarrientos yes, in your own environment - I don't think we want to merge the patch into 3.x since it supports both dynamic and directory based environments. With 4.x (and directory based env in 3.x), everything (including types cache) is evicted when the environment expires.

Okay, will then add it to our local 3.x Puppet build and roll it out. We'll take it out from our list of patches to apply once we're on 4.x :) I'm trying to turn the tests green now. Thanks again.

Alright, so everything is green now. However, I'm not totally sure that the way I've made the tests happy is ideal. Let me know :)

FTR, today we started to roll out the patch to one of our pools of Puppet masters at around 16:35. The following plot represents the number of stat()s made by all Puppet masters in that pool vs time. The results in production match what he saw during the testing phase, a 55-60% gain. The average compilation time has also decreased 40%.

Ping @hlindberg, are you alright with cherry-picking and merging this after we do some testing?

@HAIL9000 I am fine with this patch for 4.x - so stable and master are fine targets. (Should not be cherry picked to 3.x as noted in comments earlier).

I'm not sure this is desired behavior on the agent, since pluginsync can make new types and providers available during its run.
It's probably ok on the puppet master, but I know some people rely on the agent running on the master to bootstrap the master (which is why we couldn't separate the agent and master libdir), so I think the same problem could happen on the master and would be considering a breaking change.
That said, we added an always_cache_features puppet setting that will cache the result of feature evaluation, so for example if Puppet.features.msgpack? is false, cache the result, and don't try to load msgpack again.
What about putting this new behavior behind a feature flag? In retrospect, it might have been better to create one puppet setting that meant "disable agent cache invalidation", rather than have N different settings...
Another area of improvement would be to not clear gem paths when loading a feature: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/feature.rb#L85 That logic is mainly for the agent, so that we can use a gem installed in the same run. But probably has negative performance impact on the server.
/cc @camlow325 @cprice404

I like the idea of putting this behind a feature flag.
See also #2951, which proposed a similar PR to address https://tickets.puppetlabs.com/browse/PUP-3038.

Long term, the compiler will use the 4.x loaders instead of the @autoloader route. It already does that for new things; 4x functions, type aliases, but will use those loaders more. In 4.4.0 we will be loading resource types that way (for type references; only light use still). As that continues the code paths will become more and more separate.
Frankly I would like to see as little change as possible to 3.x code - one fix always breaks something else... this one looked like it was worth it.

@hlindberg I understand your concerns about not adding new caching behaviors, and am +1 to using 4.x loaders in the future. Having well-defined environment lifetimes makes sense.
But if 4.x loaders cache misses then it will break use cases where hiera backends, functions, and report processors are delivered via agents running on the master. We ran into that issue when we tried to separate the agent and server libdir. IOW, separate the libdirs is a prerequisite for having 4.x loaders always cache misses. There are some on-going discussions about that. /cc @kylog
Second, this PR adds a fairly significant performance improvement to puppetserver. It seems worthwhile to me to add this caching behavior under the existing always_cache_features feature for the time being.
@camlow325 can you take ownership of this PR and work with the contributor or close?

@joshcooper I would like to understand the use cases where agents bring new things and why that means that loaders cannot cache. The 4.x loaders are tied to the lifecycle of the environment when compiling, they could just as easily be tied to something else (or not at all - which would be the same thing as only caching hits and misses inside the task when the loaders were bound to something. (This because loaders are not in charge of their own overall life cycle). But, maybe it is a case of allowing the "environment" on the agent to change during the course of the agent "apply" ? Could it perhaps detect when it would need to rest the loaders?

My $.02:

:+1: on adding this behind either a new always_cache setting or a more-specific new always_cache_types (or ??? - naming is hard) setting
I'd rather not reuse the always_cache_features setting for this because that will confuse future me

Ping @haus since you're on rotation for puppetserver.

If you want a new setting I would reluctantly support that, but please make it default to on. Having N+1 settings where N > 200 and requiring the user to find it and flip the default in order to get a 40% performance boost is... perverse.

@joshcooper thanks for the ping. I'll pick this up soon.

@ahpook I don't think we need to default it to true. We could/should explicitly set it to true on the server side as was done for always_cache_features https://github.com/puppetlabs/puppet-server/blob/master/src/ruby/puppet-server-lib/puppet/server/puppet_config.rb#L26. Then there would be no needed work for folks running puppetserver, and for those running agents, they wouldn't experience regressions around loading new types that were delivered during runs, as @joshcooper mentioned in https://github.com/puppetlabs/puppet/pull/4427#issuecomment-159436599.
I don't care much about new setting vs using always_cache_features, largely because I can't imagine a case where a user would need/want to enable one and not the other.

Ping @thallgren - in light of #4812 which is related to this.

There is one case that worries me here, which is if a user begins using a new type in manifests before it is available (say they forgot to install the module first). In that case compiles will fail, but the type load miss will be cached for the life of the server process, so even after the user installs the type compiles will fail until the jruby expires or the server is restarted/reloaded.
I have a branch that would resolve this case here (the branch also guards the caching behind a setting): https://github.com/haus/puppet/commits/tickets/master/pup-5482

I've added a few commits to put this caching behind a setting in #4818. So I'll close this out in favor of that PR.


Fix RejectedExecutionException when using DnsAddressResolverGroup

Motivation:
AddressResolverGroup adds a listener to the termination future of an
EventExecutor when a new AddressResolver is created. The listener calls
AddressResolver.close() when the EventExecutor is terminated to give the
AddressResolver a chance to release its resources.
When using DnsAddressResolverGroup, the AddressResolver.close() will
eventually trigger DnsNameResolver.close(), which closes its underlying
DatagramChannel.
DatagramChannel.close() (or any Channel.close()) will travel through
pipeline and trigger EventExecutor.execute() because
DnsNameResolver.close() has been invoked from a non-I/O thread.
(NB: A terminationFuture is always notified from the GlobalEventExecutor
thread.)
However, because we are doing this in the listener of the termination
future of the terminated EventLoop we are trying to execute a task upon,
the attempt to close the channel fails due to RejectedExecutionException.
Modifications:

Do not call Channel.close() in DnsNameResolver.close() if the Channel
has been closed by EventLoop already

Result:
No more RejectedExecutionException when shutting down an event loop.

@trustin LGTM

Cherry-picked as b2f1ef57c8ad0fd9f4cc2b42f5518487d6771b98 into 4.1

Thanks!


Please add 3202 Error: Jobs is not fully initialized yet. Please retry later.

Please update the documentation to include additional info and actions I can take to prevent/fix this ADF error when running a Databricks Notebook.  In general, I as a user should not be experience an error that isn't already described in the documentation. Thanks!
{
"errorCode": "3202",
"message": "Jobs is not fully initialized yet. Please retry later.",
"failureType": "UserError",
"target": "Update Active Agents",
"details": []
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b57894dd-9bb6-0900-63c5-71c6b902abdf
Version Independent ID: 048a747c-7ac0-e9a1-2c36-8cdf82cfd143
Content: Troubleshoot Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/data-factory-troubleshoot-guide.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@sebcruz Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

@nabhishek Could you take a look at this request to provide more information on an undocumented error? Thank you!

@sebcruz, thank you for catching this.  I updated the Azure Data Factory Troubleshooting Guide to include this error message for error 3202 as well.  I will close this issue out now but you can still reply here and the discussion can continue if necessary later.
#please-close

Thank you @jonburchel for taking care of this!


Add new Dockerfiles and an initial Jenkinsfile to easily run ORT on a Git project

Please have a look at the individual commit messages for the details.

This change is

Can you please add documentation to this PR explaining how the different Docker and Jenkins files can be used and how they relate to the Docker Gradle build task, e.g. in the global README.md?

I promise to do that as a follow-up, if possible, as I'd like to get this merged ASAP. This PR indeed deprecates the Docker image built via Gradle, and I plan to remove that code also as a follow-up.


[spaceship] Version bump

Update spaceship to work with the new Dev Portal token handling (https://github.com/fastlane/fastlane/pull/5803)

👍


Fix bucket name in verify_backpressure_get_object test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Addressed in #916


Integration Test - Release - 2019/02/13 19:02:55

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@adunndevster : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


How to use "direct" strategy in ReducedRegressionForecaster[DOC]

When using the "direct" strategy in ReducedRegressionForecaster.
It is confusing what is the right "fh" to input into fit() method.

@EternalConfession thanks for the feedback, could you give a bit more details: Why is it confusing? What do you mean by "right" fh? How could we make the documentation clearer?


DOCS-Fix-version

Product Version(s):
CE 3.17.1
Issue:

Link to docs preview:

SME review:

[x] An SME has approved this change.

DOCS review:

[x] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[x] Deploy preview inspected wherever changes were made
[x] Build completed successfully
[x] Test have passed

This PR has odd dead link that rebasing doesn't fix. Closing out this PR in favor of this one: https://github.com/tigera/docs/pull/865.

Decision by Rene, Erik, Dan is that v3.25 is the version for now. Closing out.


Add new problems

Add new problems that you think are a must-solve while learning programming.
The solutions can be in any language.

Hi I would like to help

@kmalki feel free to pitch in!
But please keep in mind that if you want your contributions to be counted for the Hacktoberfest, they must be made in October only.

Thank you, I just want to make my first contributions on github

@kmalki
That's fantastic. :tada:
It is never too early to begin contributing!
Please see the contributing guidelines and the code of conduct for more information.
You can also look at the previously opened issues here, or start your own right away!
All the best for your contributions! :gift_heart:

Add new problems that you think are a must-solve while learning programming. The solutions can be in any language.
Have a look at this for more explanation on how to address this issue.
Also check out the contributing-guidelines and code-of-conduct.
Happy Contributing! gift_heart

Anybody and Everybody is free to contribute to this issue.
Since this repository is a sort of question bank, we will appreciate problems of all difficulty levels, and languages to be added! :smiling_face_with_three_hearts:


serde_amqp::read::IoReader unit test fails after rust is updated to 1.80

The two unit tests that are failing are

read::ioread::tests::test_incomplete_read_const_bytes_after_peek
read::ioread::tests::test_incomplete_read_const_bytes_without_peek

The cause of this is introduced in a change of behaviour in std::io::Cursor (rust-lang/rust#125123) where the cursor would drain (ie. move pos to the end) even if read_exact or read_buf_exact fails.
This is a more general problem than just Cursor as we were relying on unspecified behaviour. There's a warning for the error case in std::io::Read::read_exact

If this function returns an error, it is unspecified how many bytes it has read, but it will never read more than would be necessary to completely fill the buffer.

However, the change in std::io::Cursor should not be a problem for fe2o3-amqp as the IoReader is only used with bytes::Buf::reader(), which would never return an error according to its doc (https://docs.rs/bytes/latest/bytes/buf/trait.Buf.html#method.reader)

This function returns a new value which implements Read by adapting the Read trait functions to the Buf trait functions. Given that Buf operations are infallible, none of the Read functions will return with Err.

This should not be a problem for fe2o3-amqp because the IoReader is used within the frame decoder which is only called after FramedRead with LengthDelimitedCodec, which ensures that the bytes are only returned when a whole buffer is ready.

The FrameDecoder probably doesn't need much change other than what would be necessary as a result of the two mentioned above because it is chained with a LengthDelimitedCodec, however, it might be worth considering not consuming all the bytes before the decoding succeeds.

[ ] Do not consume src buffer before decoding succeeds.


Java wrapper for xgboost

hi, @tqchen
I've reforked the project and made some basic modifications:

JavaDoc is added in the folder "java/apidocs"
docfile "xgboost4j.md" has added in "java/doc/"
basic examples added in "java/xgboost4j-demo" (further improvement is needed, I'll add more examples in the future)
"Makefile" has merged to root

you may just ignore the previous pull-request.

Thanks! @yanqingmen This was much better, let us do a few more changes:

Remove the test data and the html generated by javadoc from the repo

the html can change frequently so it is better not to include them(add to gitignore)
Sorry i didn't make it clear last time, I meant javadoc comment all the blocks
There is an example data in root/demo/data, please try reuse that when possible
You may need to do another refork since these files do occupies a lot of space

Please do another PR and I will do more reviews:)

oh, got it, sorry I'm not proficient in using git, I'll make it better next time ~

You can try to add .gitignore files to filter out the files folders that you do not want to add to git:)


Anyway to upgrade latest geth in container?

hi, is there anyway to quickly run or upgrade new version of geth in container by quorum-dev-quickstart?

Hello @cauta we are using the latest release of goquorum in the containers https://github.com/Consensys/quorum-dev-quickstart/blob/master/files/common/.env#L5.
GoQ releases are here: https://github.com/ConsenSys/quorum/releases


python311Packages.aliyun-python-sdk-kms: 2.16.1 -> 2.16.2

Changelog: https://github.com/aliyun/aliyun-openapi-python-sdk/blob/master/aliyun-python-sdk-kms/ChangeLog.txt
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 254617 run on x86_64-linux 1

12 packages failed to build:

python310Packages.aiooss2
python310Packages.aiooss2.dist
python310Packages.oss2
python310Packages.oss2.dist
python310Packages.ossfs
python310Packages.ossfs.dist
python311Packages.aiooss2
python311Packages.aiooss2.dist
python311Packages.oss2
python311Packages.oss2.dist
python311Packages.ossfs
python311Packages.ossfs.dist

4 packages built:

python310Packages.aliyun-python-sdk-kms
python310Packages.aliyun-python-sdk-kms.dist
python311Packages.aliyun-python-sdk-kms
python311Packages.aliyun-python-sdk-kms.dist

Result of nixpkgs-review pr 254617 run on x86_64-linux 1

16 packages built:

python310Packages.aiooss2
python310Packages.aiooss2.dist
python310Packages.aliyun-python-sdk-kms
python310Packages.aliyun-python-sdk-kms.dist
python310Packages.oss2
python310Packages.oss2.dist
python310Packages.ossfs
python310Packages.ossfs.dist
python311Packages.aiooss2
python311Packages.aiooss2.dist
python311Packages.aliyun-python-sdk-kms
python311Packages.aliyun-python-sdk-kms.dist
python311Packages.oss2
python311Packages.oss2.dist
python311Packages.ossfs
python311Packages.ossfs.dist


Link Verification and Type Inference tickets in the spec

So far, whenever we encountered misalignments between the spec and verifiers / type inference implemented in the StableHLO dialect, we opened tickets and marked Verification and Type Inference columns in status.md as "revisit".
This is useful, but in practice this loses some important information. When seeing those revisits in status.md, I'm having a hard time remembering what was the reason for them. Similarly, when reading the spec, I sometimes struggle to remember the status of the StableHLO dialect with respect to it.
As discussed earlier, we should:

Go through all Verification and Type Inference tickets.
Identify the tickets which describe misalignments with the spec (not new features, but bugs!).
Mention these tickets in specs, right next to relevant parts of Inputs/Outputs/Constraints.

I've briefly looked through all these tickets, and while most of them affect individual ops or small groups of ops, there are tickets that affect lots of ops:

#22.
#369.
#481.

I think that for the three tickets mentioned above (and potentially other tickets that we might discover in the coming days) we shouldn't call them out in the spec to avoid spamming and similarly we shouldn't flip Verification / Type Inference to "revisit" because of them.

Fixed in https://github.com/openxla/stablehlo/pull/1076 which links almost all Frontend Contract tickets (except for four tickets for which I haven't come up with an ergonomic way to call them out), as well as select tickets from other projects.
When originally opening this ticket, I was mainly thinking about linking Specification Compliance tickets, but then I realized that linking them in the spec is not a great idea. Frontend Contract tickets are interesting because they identify gaps in the spec - something that's likely very relevant to readers of the spec - whereas Specification Compliance tickets talk about gaps in the StableHLO dialect, which is just one possible implementation.


Remove excessive permissions from the OrbStack directory

Is your feature request related to a problem? Please describe.
On Mac, Orbstack creates a directory named OrbStack in the home directory with permissions set to 777. Is this absolutely necessary? If possible, should the permissions be minimized as much as possible?

Fixed for the next version, thanks for reporting. It's not intentional — I just didn't notice it.

Released in v0.5.2.


Prebuild Binaries Again

cargo-generate is useful enough outside of the Rust ecosystem for templating projects that it's worth while to have pre-built binaries available for non-Rustaceans. Also nice to have a single source of truth to pull binaries from for any CI jobs.
Looks like v0.5.1 was the last release with binary assets attached. PR #377 does something similar via GH Actions.

lgtm.
Thanks for your contribution, very appreciated.

@jashandeep-sohi do you know if there is a delay between the GH Release creation and the GH Actions workflow being triggered?
I'm asking because the GH Release for v0.7.2 should have triggered the workflow already, but this did not happened to now (15min past the trigger). Maybe that is expected behaviour thou.

Huh...interesting. When I was testing manually it was immediate. Let me look into it.

@sassman Ahhh turns out if you make API requests using the auto generated Actions GITHUB_TOKEN it doesn't generate any events apparently to prevent "accidentally creating recursive workflow runs". :roll_eyes: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

You have created and published the GH Release manually right? It might be that this is the key to get it working.
As you can see the workflow takes care of creating the GH Release, so that might then not trigger follow-ups.

I can either rework this so that it's part of the main release workflow or you can create a personal access token for the job?

What might help, is to change the on trigger to something like shown here:

So the event would not be the GH Release creation, but the successful completion of the "Release" workflow run

True, that might work too.

I can either rework this so that it's part of the main release workflow
I'd rather not do this, in favour of smaller separated pipelines.

or you can create a personal access token for the job
I will also have a look at this then.

Actually maybe no. The release event has info about the git sha & branch name. I don't know if a workflow completed event would have it too.

I can either rework this so that it's part of the main release workflow

I'd rather not do this, in favour of smaller separated pipelines.

or you can create a personal access token for the job

I will also have a look at this then.

Agreed, but PATs have their own security problems. i.e. you can't scope them to a particular repo and they're associated with a github account (not the repo or org)

I've prepared a GH PAT and made small adjustments on the pipelines. Let's see how this works out.
For v0.7.2 I've worked around the problem by deleting and recreating the GH Release, and all artefacts had been created as expected.
Thanks for your work and help!


Add get_account_fees()

#172
Implemented for Binance and Coinbase. Didn't find Nash API docs, so for now it will return a not implemented error. I can implement it for Nash if anyone post a link to relevant docs.
I tested this in my personal project for both exchanges (not via cargo test). Not sure how to set up the tests - a lot of tests (including the new tests) failed after adding .env file with my sandbox credentials for Binance.
I'm new to both rust and this project. I'll happily make an required changes.
Note: there are 2 unrelated changes in binance account tests:

VS code insisted to format this line:  let get_price_ticker_request = GetPriceTickerRequest { - it is the only place, so it doesn't seem like my editor config is different than what you guys are using - it may actually be a good change.
Spelling correction at .expect("Couldn't get acount balances.");

@mkazlauskas thanks for the PR. I will review it ASAP

As a first though: Nash should also be supported. I will check how to do it.

nash-rust needs to implement getAccountVolumes


Suggestion: Rspec/NestedGroups maximum option

This is just a suggestion from my part since I got a bit confused while trying to set custom maximum value for nested groups example.
The maximum value set for most of the cops use key Max but for NestedGroups it is MaxNesting.
https://github.com/backus/rubocop-rspec/blob/master/config/default.yml#L130
Perhaps I might be wrong or I might be too late to suggest but I think it would be a consistent behaviour among cops if we can use just Max as key to set maximum values. Thanks for your time and efforts. 🙇

Yeah I should make that consistent in the next version. Thanks for the input!

Thank you for such a quick and positive response. Since you have labelled it as a bug, should I submit a PR with the change?

I was about to actually. To do this properly I think I need to add a check to the config that warns about MaxNesting but still respects it. That is a more involved change so it might be easier for me to do it.
If you're interested in helping though there are plenty of cops that can be implemented. I think these are way more fun to work on too.

Sounds great! Thank you once again 🙇

#287 should fix this issue. Not sure when we'll release it FYI. Thanks again for the feedback


Import export

refactor models to use URI, URI Prefix, and Key
refactor tests, remove factory_boy
add test fixtures
add XML export
add XML import
fix i18n switcher
fix dates in project_answers_tree
fix yes/no widget

Coverage decreased (-16.9%) to 62.385% when pulling 18872b3854c2118084d4f619f3c552e9a8e79884 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.9%) to 62.385% when pulling 18872b3854c2118084d4f619f3c552e9a8e79884 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.9%) to 62.385% when pulling 18872b3854c2118084d4f619f3c552e9a8e79884 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.9%) to 62.385% when pulling 18872b3854c2118084d4f619f3c552e9a8e79884 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.3%) to 63.017% when pulling e122afae2f4ff3512a65ed5b1bf3bd7927aacb66 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.3%) to 63.017% when pulling b5303039a3c7f51e751583d921b8ee69f7994479 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.3%) to 63.017% when pulling b5303039a3c7f51e751583d921b8ee69f7994479 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.3%) to 63.017% when pulling b5303039a3c7f51e751583d921b8ee69f7994479 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-16.3%) to 63.017% when pulling b5303039a3c7f51e751583d921b8ee69f7994479 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-15.9%) to 63.36% when pulling 48c398fa97ddbb2e90eea4fe0de7b825347550e8 on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.

Coverage decreased (-15.9%) to 63.36% when pulling 26ed248324e49a1658f5a89994d0ad7aa87204bd on import_export into f63c3fab42b2574239e007e584b3c66bde7e3b1e on master.


Broken on UE 5.5

After updates, chaarcter is doing trajectory only in one direction
How to replicate this error:

Update project to UE5.5

I am sick, I can't give support right now. sorry

I suggest you work on the project for 5.5

No worries, get well mate!
Yep, that 5.5 project. I think problem with smooth sync + updated 5.5 unreal plugins


Fix examples linking with CMake and -DPLATFORM=SDL

Currently, every example fails linking likeso:
[  3%] Linking C executable audio_mixed_processor
/usr/bin/ld: ../raylib/libraylib.a(raudio.c.o): undefined reference to symbol 'exp@@GLIBC_2.29' /usr/bin/ld: /usr/lib/libm.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status
Apparently, linking libm explicitly is the solution.

Yikes. This breaks building on visual studio. Will investigate further later.

Okay, libm shouldn't be linked on "WIN32". Should be fine now.

The Linux CI build failiure is some network issue, not related.

@Peter0x44 thanks for the review!


Partial static render for gradually shifting from traditional ssr web server to SPA

What problem does this feature solve?
Currently I am trying to shift an existing website written in Django, a server side render web server written in python, to vue. I have already used prerender plugin to compile the SPA, but I have to use the generated static html files as template to the Django server, which means partials of the element is already rendered by the server and I don't want this portion to be affected (or controled) by vue. Since vue will replace this portion (, which is generated by Django) with the virtual DOM info generated when building the SPA with prerender plugin， so I am asking if there is a way that stop vue from updating some parts of the SPA or component and just keep those fraction as same as what is initially sent by the server.
What does the proposed API look like?

No matter under what circustance I will not be changed

//Layout is a component

You can use inline-template to let Vue reuse the content and have some kind of hybrid. People use different techniques that can be found in tutorials and forums.

Please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂

You can use inline-template to let Vue reuse the content and have some kind of hybrid. People use different techniques that can be found in tutorials and forums.
Please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug

Thank you very much. I have been looking around for a solution for this for a long time including searching stack overflow but could not find an approach, so I suspect that vue may not implement or support this feature from the mechanism basis. Thanks for your help and I will have a try.

@AlanYiNew keep in mind that inline templates might be removed in 3.0 https://github.com/vuejs/rfcs/pull/98


Migration Dropping and Creating indexes

Not sure if this is intentional or not but it seems to be a bug.    This is really annoying as it fills migrations with unrelated commands that sometimes cause errors.  Is this intentional or could it be fixed somehow?  I am getting about 5 of these per migration.
DROP INDEX tablename_u_8db8bc ON tablename;
CREATE UNIQUE INDEX tablename_u_8db8bc ON tablename (columnname(60));

I'm happy to take a look.
Could you provide an example of a schema definition causing this and the database type (mysql), postgres, sqlite) so i can attempt to reproduce it.


MM-38140 - show only enterprise for professional upgrade

Summary
When a customer is upgrading to Enterprise from professional, we want to only show the Enterprise option.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38140
Related Pull Requests
none
Screenshots

before
after

Release Note
NONE

@neallred I want to approve but I feel like I should wait until all the PM feedback is completed since there would be code changes.


[Ubuntu] Fix pipx version on software report

Description
pipx --version command writes some symbols to stderr:

Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run ubuntu1804, ubuntu1604, ubuntu2004


FROM command error

What is the issue?
When I use Windows CMD to create a Modelfile from the huggingface model, I run the command 'FROM path-to-safetensors-directory', but it reports an error that the FROM keyword is not supported. Using git bash doesn't work either.
OS
Windows
GPU
Nvidia
CPU
Intel
Ollama version
0.4.6

What's the content of your Modelfile?  What's the actual error message?

What's the content of your Modelfile? What's the actual error message?

The model file is llama3-8B that I downloaded from huggingface. The error message is as follows

That's not how you create a Modelfile.  The Modelfile contains the FROM command.
C:\Users\szh> copy con Modelfile
FROM C:/Users/szh/Downloads/Llama-3-8B
^Z
C:\Users\szf> ollama create llama-3-8b

That's not how you create a Modelfile. The Modelfile contains the FROM command.
C:\Users\szh> copy con Modelfile
FROM C:/Users/szh/Downloads/Llama-3-8B
^Z
C:\Users\szh> ollama create llama-3-8b -f Modelfile

or
C:\Users\szh> echo FROM C:/Users/szh/Downloads/Llama-3-8B > Modelfile
C:\Users\szh> ollama create llama-3-8b -f Modelfile

or
C:\Users\szh> cd Downloads/Llama-3-8B
C:\Users\szh\Downloads/Llama-3-8B> echo FROM . > Modelfile
C:\Users\szh\Downloads/Llama-3-8B> ollama create llama-3-8b -f Modelfile

OK. Thanks.


ver 4.0.0: lgb.cv returns a dict whose keys have an extra "valid" prefix

Description
For the code below, lgb.cv version 3.3.2 gives a dictionary with keys
['binary_logloss-mean', 'binary_logloss-stdv']
but lgb version 4.0.0 gives an output
['valid binary_logloss-mean', 'valid binary_logloss-stdv']
Reproducible example
import lightgbm as lgb
from sklearn.datasets import load_iris
from sklearn.model_selection import KFold

X, y = load_iris(return_X_y=True, as_frame=True)
y = y > 0

data = lgb.Dataset(data=X, label=y)
metric={'name': 'binary_logloss', 'maximize': False}
folds=KFold(n_splits=3, shuffle=True, random_state=23)

params = {'boosting_type': 'gbdt', 'objective': 'binary',
'verbose': -1, 'feature_pre_filter': False, 'num_leaves': 82, 'max_depth': 8,
'learning_rate': 0.15543735428541233, 'min_data_in_leaf': 28, 'lambda_l2': 0.04420907265233052}

eval_hist = lgb.cv(
    params, train_set=data, folds=folds, seed=23, metrics='binary_logloss'
)
print(lgb.__version__)
print(eval_hist.keys())

Environment info
4.0.0
Command(s) you used to install LightGBM
conda install -c conda-forge lightgbm

Additional Comments
Screenshot of the result comparsion:

Hey @xinwang0312, thanks for using LightGBM. This was a breaking changed introduced in #4947 to be consistent with the names of the metrics, previously it would only have the prefix if you set eval_train_metric=True, now it always does. Sorry for the troubles.

Hi @jmoralez, thanks for the quick reply. I was not aware of it. Will adapt my code to this change.


Various RBAC API and CLI improvements (and some bonus bug fixes)

This pull request includes various RBAC API and CLI improvements (and also some openapi related fixes):

Fix system query param filter in /v1/rbac/roles API endpoint so it works correctly
Update /v1/rbac/roles API endpoint so includes corresponding permission grant objects (see below for example). Previously we only included raw IDs so the response wasn't all that useful.
Add new CLI commands for viewing RBAC roles:

st2 role list [--system]
st2 role get <role id or name>

Add CLI commands for viewing RBAC user role assignments:

st2 role-assignment list [--role=<role name>] [--user=<username>]
st2 role-assignment get <role assignment id>

Examples
/v1/roles/ API endpoint
Example output of /v1/roles/ API endpoint before the above mentioned change:
curl http://<IP_ADDRESS>:9101/v1/rbac/roles/role_timer
{
    "name": "role_timer",
    "permission_grants": [
        "58f4e3ad0640fd2a7948631f",
        "58f4e3ad0640fd2a79486320"
    ],
    "system": false,
    "id": "58f4e3ad0640fd2a7948631e",
    "description": "Role which grants all the action permissions on pack config_demo"
}

And after the change:
curl http://<IP_ADDRESS>:9101/v1/rbac/roles/role_timer
{
    "name": "role_timer",
    "permission_grants": [
        "58f4e3ad0640fd2a7948631f",
        "58f4e3ad0640fd2a79486320"
    ],
    "system": false,
    "permission_grant_objects": [
        {
            "permission_types": [
                "trigger_list"
            ],
            "id": "58f4e3ad0640fd2a7948631f"
        },
        {
            "permission_types": [
                "trigger_view"
            ],
            "id": "58f4e3ad0640fd2a79486320",
            "resource_type": "trigger",
            "resource_uid": "trigger:core:c625e485-ceb8-45c6-8c7e-53577e7007cf:889c1c0b04f53100997af85f35ad3979"
        }
    ],
    "permission_grant_ids": [
        "58f4e3ad0640fd2a7948631f",
        "58f4e3ad0640fd2a79486320"
    ],
    "id": "58f4e3ad0640fd2a7948631e",
    "description": "Role which grants all the action permissions on pack config_demo"
}

Note: permission_grants field is duplicated and is there for backward compatibility reasons.
st2 role CLI commands
st2 role list
2017-05-08 12:06:10,511  WARNING - Auth API server is not available, skipping authentication.
+--------------------------+--------------+--------+------------------------------------------+
| id                       | name         | system | description                              |
+--------------------------+--------------+--------+------------------------------------------+
| 58f4decf0640fd24a8fde770 | admin        | True   | admin                                    |
| 58f4decf0640fd24a8fde771 | observer     | True   | observer                                 |
| 58f4e3ad0640fd2a7948632a | role_one     | False  | Role which grants all the action         |
|                          |              |        | permissions on pack config_demo          |
| 58f4e3ad0640fd2a79486324 | role_three   | False  | Role which grants all the action         |
|                          |              |        | permissions on pack config_demo          |
| 58f4e3ad0640fd2a7948631e | role_timer   | False  | Role which grants all the action         |
|                          |              |        | permissions on pack config_demo          |
| 58f4e3ad0640fd2a79486321 | role_two     | False  | Role which grants all the action         |
|                          |              |        | permissions on pack config_demo          |
| 58f4e3ad0640fd2a79486327 | st2_admin    | False  | ST2 Admin Role                           |
| 58f4decf0640fd24a8fde772 | system_admin | True   | system_admin                             |
+--------------------------+--------------+--------+------------------------------------------+

st2 role list --system
+--------------------------+--------------+--------+--------------+
| id                       | name         | system | description  |
+--------------------------+--------------+--------+--------------+
| 58f4decf0640fd24a8fde770 | admin        | True   | admin        |
| 58f4decf0640fd24a8fde771 | observer     | True   | observer     |
| 58f4decf0640fd24a8fde772 | system_admin | True   | system_admin |
+--------------------------+--------------+--------+--------------+

st2 role-assignment CLI commands
st2 role-assignment list
+--------------------------+----------+-------+-----------+----------------------------------+
| id                       | role     | user  | is_remote | description                      |
+--------------------------+----------+-------+-----------+----------------------------------+
| 58f4e3ad0640fd2a7948632d | observer | tomaz | False     |                                  |
| 59045aef58a5f53a3c85d417 | x        | a     | False     |                                  |
| 59045bed58a5f53a3c85d418 | x        | tomaz | False     |                                  |
| 5909c9140640fd0ee1b3981f | role_one | tomaz | True      | Automatic role assignment based  |
|                          |          |       |           | on the remote user membership in |
|                          |          |       |           | group "CN=stormers,OU=groups,DC= |
|                          |          |       |           | stackstorm,DC=net"               |
| 5909c9140640fd0ee1b39820 | role_two | tomaz | True      | Automatic role assignment based  |
|                          |          |       |           | on the remote user membership in |
|                          |          |       |           | group "CN=stormers,OU=groups,DC= |
|                          |          |       |           | stackstorm,DC=net"               |
+--------------------------+----------+-------+-----------+----------------------------------+

st2 role-assignment list --user=a
+--------------------------+------+------+-----------+-------------+
| id                       | role | user | is_remote | description |
+--------------------------+------+------+-----------+-------------+
| 59045aef58a5f53a3c85d417 | x    | a    | False     |             |
+--------------------------+------+------+-----------+-------------+

TODO

[x] RBAC for role assignments API endpoint (admins can view all the assignments, users can view their own assignments)
[x] Tests for role assignments API RBAC

Cool - new commands look really useful

Also remember to merge the latest master into this now that we've fixed the mongoengine dep issue, to make sure u16 passes

@Mierdin Done - thanks for the reminder.


Add context path when listing routes

Hi Simon et al
This PR is to add context path support when listing routes. Basically we will also now display "path" for when doing a cf routes.
See tracker item for more info:
https://www.pivotaltracker.com/story/show/104020832
Cheers
[#104020832]

Hi @markstgodard,
Is this PR complete? I see the branch it's on is prefixed with wip- and the story mentions it as being such.

@krishicks Sorry, habit.  Yeah its complete, its not wip.

Will resubmit this PR once @shalako accepts https://www.pivotaltracker.com/story/show/104020832


Implement internalization

Closes #115
This PR introduces the ability to switch languages, as well as translations for most of the, if not the entire, application.
General Notes

all translations are provided in a way that conveys the same meaning as their English counterparts and are not meant to be word-for-word translations for most parts. In fact, I would heavily discourage against word-for-word translations.

With that said, translations can be adjusted accordingly. I don't hold special feelings for my own translations. Some of them were provided just to have something, so not every translation is bound to be perfect.

there are many places where the UI looks weird due to the Bulgarian translations being longer than the English ones. Those have not been fixed in this PR, as I'd rather document them all first and tackle them in a separate PR (or multiple PRs)
for stuff like the FAQ and the changelog, where the content is rendered dynamically from constants, the constants that are used for rendering now point to translation keys, which hold the actual content.

Translation files
Translation files are stored in src/translation/{language} as .json files, where {language} is any of our supported languages. The files are split as follows:

common.json - translations for components that appear throughout the app, like the navigation menu, or translations used in multiple places across the app.
toast.json - translation keys for the toast mesasges. Note: the reason they are no longer grouped as "success" and "error" was because I was trying something with TypeScript typing and initially removed them to make it easier, but it ultimately failed and never bothered to restore it.

Note: the previous errorToast utility function has been removed and replaced with a hook, this is so that it can use the useTranslation hook.

validationErrorMessages - translation keys for validation error messages, self-explanatory
all other .json files represent a group of pages. For example, the about.json file holds the translation keys for all About pages. Each subpage is represented by a top-level JSON key. In some cases, those files may also have a common key, which holds translations used across the page group, but not used outside of the page group itself

Note: occassionally, stuff like table headers, which happen to be the same across multiple pages, are still translated within their page files and are not extracted in common.json, this is mostly because I'd rather avoid accidental side effects if we decide we want to change the specific translation and do not intend to do it globally.
Change language menu
As mentioned in #115, the menu's implementation is temporary for now. For new users, the menu will detect the browser language and select the translation (and therefore corresponding option) automatically. After that, the menu will appropriately save the user's preference (if they decide to change it)
Although I mentioned that the mobile variant will implement the menu with a native select, it turns out that there are several limitations to the  component such as that my mobile wireframe will prove impossible to implement, so the mobile variant for now is also a standard dropdown menu
Other notes

I have added a placeholder Suspense element, as it is needed for the translations to load correctly. It goes without saying that we willl want to create something more than a mere heading to improve the UX while the user is waiting for the app to load (we can also consider lazy loading some of the modules and components), but this is obviously out of scope for this PR.
for the changelog translations, while you could theoritically represent the entire archive as a JSON array, I have still left the version and date as a JavaScript object, this is mostly because I'd rather have a single source of truth for those (and the date has to be formatted as something that can be parsed as a date, so having a single source of truth for it reduces the chance of errors)

Let me know if I missed any translation

I appreciate the hard work. Looks really good! I spot a few typos here and there but they will be fixed another time when we do a deeper UI review.


Introduce listing_for_url

Codecov Report

Merging #157 into develop will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    88.52%   88.57%   +0.05%
===========================================
  Files           12       12
  Lines          845      849       +4
===========================================
+ Hits           748      752       +4
  Misses          97       97

Impacted Files
Coverage Δ

ssds/__init__.py
90.99% <100.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8776f5c...c89e3a2. Read the comment docs.


Dotplot : Added functionality to plot multiple dots,Fixed some errors in plot_line function

#17  Added functionality to plot multiple dots (even single) on a figure.
#85  Fixed all the issues mentioned here except Documentation

@realsdx Nice work, just a few suggestions which you can follow from next time.
Please do not club issues together while creating PRs. If necessary create multiple PRs :) In this way length of PRs will remain small and also it is easier to review and track.
Welcome On board.

Deleted test.py

Thanks for the suggestion.

No.. that time I don't know that I can't remove a file from remote using gitignore

@realsdx Congrats, your first PR has been merged.
From next time, when you make multiple commits, please squash them into a single one before making PR :) It keeps things more organised :)


adding  social media icons in the footer

What feature?
adding social media icons with relevant links.
Add screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

we don't want to add


Student ID Card: UX for Barcode Use

Mockups for user interaction when needing to scan the barcode. Screen brightness increase temporarily and then back to user's original brightness level.

Do we need a full-size barcode?

user taps on homescreen student ID, barcode overlay displays and device brightness goes to 100%. To dismiss, user clicks away from overlay or clicks "Close" and brightness goes back to user's preferred setting.

Cllicking "Expand" produces even larger, vertically displayed barcode. Programmatically hide/show "Expand" based on device screensize?

All set here, closing

This work has been completed, closing.