Incremented version number(s).

New Features:

Infinite then and error blocks. Utilizes a child future / linked list pattern.
Joined futures. Call class method joining and pass in an array of Future objects, and get a single Future<[T]> which will complete when all have succeeded or any have failed.
Added similar syntactic sugar to StreamState as exists on Result: .onNew(_:) and .onError(_:)
Added handy, static preResolved(value:) and preRejected(error:) methods for synchronous/immediate futures.
Added .map(_:) method to Future for translating from one future to another.
Added finally(_:) block to future that executes on either type of completion.
Improved performance and thread safety.
Future now uses a single Result<T>? under the hood instead of two separate optionals (T? and Error?)

For reference, this is the full diff against v0.1.0: https://github.com/jakehawken/Concurrency/compare/0.1.0...v1.0.0


.NET Core 2 Toolkit

Hello Guys,
Could you please take .NET core 2 into account when releasing the API.
Thank's!

I put that on the roadmap for this upcoming PR https://github.com/tringler/FIFA-Ultimate-Team-Toolkit/tree/FUT18

Hello @DjTrilogic - I think we need to wait some more time, because the most NuGet packages are not compatible to .Net Standard 2.0, yet. In example:
https://www.nuget.org/packages/Newtonsoft.Json/
As far as I understood you need to be compatible to .NET Standard 2.0 to target .NET Core and .NET Framework at the same time: https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/
Any other ideas?

Developing Libraries with Cross Platform Tools

@trydis - I'm a bit unsure about that link - Do you think there is an option to get the needed nuGet packages with .NET Standard 2.0?
In my opinion it would be good idea to change to .NET Standard 1.0 to support all platforms.

Yes, i think so. I've made a few .NET Core apps and 2.0 makes a lot more API´s available, but the toolkit doesn't really need that much.
The templates that ship with VS default to 1.4:

...which gives you access to most APIs on .NET Standard while still being compatible with UWP,  > .NET Framework 4.6.1, and the forthcoming .NET Standard 2.0.

I don't mind 1.0, if possible, although MS support has ended for .NET Framework <= 4.5.1. Windows Phone Silverlight and Windows 8.x apps (Metro?) are dead as well.
I guess it's easier to check what could be the lowest target when the fifa 18 related stuff has been merged.

Yes, Ok. - Then let's wait for some testing feedback from the FUT18 branch and after it applied, we can see which option we can choose.

Alright, Fair enough !
Thank's mates

#360

Please guys, can we review this issue again, I'm facing a problem with the used version of .net standard.
Do you think that an update of .net core version would resolve it ? (i put the link of the issue i'm facing in the comment above)


feat: Improve library interface

Fix #675
ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface

Awesome, thanks! A bunch of folks will appreciate this I'm sure 🥰.

Sorry for requesting review again.
Try to fix the commit sign issue

Thank you @EltonChou! This makes the developer experience when using this library much better when using an IDE + mypy (an IDE like PyCharm will auto-import from the root models but mypy will warn that the classes weren't explicitly re-exported).


feat: A mini progress bar library.

This is an initial commit. Docs are pending... Also some more features to be added before the final merge.

The functionality i wanted is added. Although would have like if the progbar  could automatically be generated for Bounded and Unbounded states without first using the UnBounded as the default state and then setting Bounded state with with_delims method. But such is life... full of compromises.
Merging for now.


Annual automation to update license headers

/kind epic
Which area/kind this issue is related to?

/area ci
/area releng
Issue Description

The tasks performed for #1004 should be automated process, this process would run annually at the start of the new year to remove the need to do this manually on a yearly basis.
Acceptance Criteria

[ ] #1241
[ ] #1242
[ ] #1243
[ ] #1244
[ ] #1250
[ ] #1252

Should update acceptance criteria to include Devfile API on completion of #1104.

Out of curiosity, is this an issue related to alizer too?

Out of curiosity, is this an issue related to alizer too?

@thepetk Yeah this would include alizer too, good catch!

I just found an article titled Copyright Notices for Open Source Projects on The Source. It mentions:
"**
[...]
Method One: State “Copyright the XYZ Authors” (or similar formulation — see below) where XYZ is the project name. Under this approach, the project does not make use of traditional individual and company-specific copyright notices.
Method Two: State “Copyright Red Hat”.
For either of these two methods, don’t bother including years, copyright symbols (i.e., © or approximations like (C)), or (for the second method) the “Inc.” in the Red Hat corporate name.**"
So I am wondering if this needs to be automated if there is no need to bother including the year.. Doing it only once should be fine then, I guess. WDYT?

Also to note, if a year is included, it's only the modified file that gets updated with the year it was changed.  Untouched files do not need to get updated

So I am wondering if this needs to be automated if there is no need to bother including the year.. Doing it only once should be fine then, I guess. WDYT?

+1 to use the Copyright Red Hat way as it is also the preferred one inside the source guidelines where it is clearly stated that "inc" and year are not necessary fields for open source copyrights.
I've opened 4 PRs for:

Devfile Web: https://github.com/devfile/devfile-web/pull/95
Devfile Library: https://github.com/devfile/library/pull/182
Registry Support: https://github.com/devfile/registry-support/pull/185
Alizer: https://github.com/devfile/alizer/pull/26

So I am wondering if this needs to be automated if there is no need to bother including the year.. Doing it only once should be fine then, I guess. WDYT?

+1 to use the Copyright Red Hat way as it is also the preferred one inside the source guidelines where it is clearly stated that "inc" and year are not necessary fields for open source copyrights.
I've opened 4 PRs for:
* [Devfile Web](https://github.com/devfile/api/issues/1241): [[Devtools week] Update license headers devfile-web#95](https://github.com/devfile/devfile-web/pull/95)

* [Devfile Library](https://github.com/devfile/api/issues/1244): [[Devtools week] Update license headers library#182](https://github.com/devfile/library/pull/182)

* [Registry Support](https://github.com/devfile/api/issues/1242): [[Devtools week] Update license headers registry-support#185](https://github.com/devfile/registry-support/pull/185)

* [Alizer](https://github.com/devfile/api/issues/1250): [[Devtools week] Create license header doc alizer#26](https://github.com/devfile/alizer/pull/26)

We should update the issue titles and descriptions to reflect these changes.

So I am wondering if this needs to be automated if there is no need to bother including the year.. Doing it only once should be fine then, I guess. WDYT?

+1 to use the Copyright Red Hat way as it is also the preferred one inside the source guidelines where it is clearly stated that "inc" and year are not necessary fields for open source copyrights.
I've opened 4 PRs for:
* [Devfile Web](https://github.com/devfile/api/issues/1241): [[Devtools week] Update license headers devfile-web#95](https://github.com/devfile/devfile-web/pull/95)

* [Devfile Library](https://github.com/devfile/api/issues/1244): [[Devtools week] Update license headers library#182](https://github.com/devfile/library/pull/182)

* [Registry Support](https://github.com/devfile/api/issues/1242): [[Devtools week] Update license headers registry-support#185](https://github.com/devfile/registry-support/pull/185)

* [Alizer](https://github.com/devfile/api/issues/1250): [[Devtools week] Create license header doc alizer#26](https://github.com/devfile/alizer/pull/26)

We should update the issue titles and descriptions to reflect these changes.

Done.

All child items completed, closing this epic now.


wrongly rewritten URLs

This relatively simple page's image URLs are rewritten wrongly:
http://speichern-unter.net/alle-einreichungen.html

It has to do with the <base> tag which always makes things confusing... (For certain sites, rewriting it needs to be disabled, but not for others.. It can be toggled with rewrite_base). For this site, it should be rewritten.. But, the trailing slash is missing, so it was being rewritten to `, thus dropping the host part.
Will add a fix.

Fixed in pywb 0.8.3


Next button doesn't work in nested subpages

Report
It's probably easiest to look at the diagram or video below. When there are 3 levels of pages, and the last subpage on level two has sub-sub-pages on level 3, the "next" button goes to the following page on level 1 instead of the sub-sub-page on level3.

Page 1

Subpage 1
Subpage 2 <-- "next" from here goes to page 2 instead of sub-sub-page 1

Sub-sub-page 1
Sub-sub-page 2

Page 2

https://github.com/iterative/dvc.org/assets/2308172/078e0671-b9c2-4336-b840-1ba20007ff59

@dberenbaum I think that was fixed by https://github.com/iterative/gatsby-theme-iterative/pull/201 ? We just need to deploy it (@yathomasi had some issues with the websites and Heroku recently, and give an estimate?)

Okay I thought I was going crazy because I couldn't find the issue 😄 . Yep, it would be great to deploy it since it makes navigating the experiments get started really confusing.

Thanks @yathomasi! I can confirm that it's working as expected now.


Add Shortcuts for keyboard

Description of the new feature/enhancement
Add Shortcuts
If shortcuts are already implemented, my mistake was. I cannot find any abbreviations

Proposed technical implementation details (optional)

Thanks. You should be able to open your settings file and add whatever keyboard shortcuts ("keybindings") you want.


width and height should be mandatory

I don't know if this is a result of a change on Google Maps side, but without providing width and height with {% easy_map %} tag, the map doesn't show up.
The solution is to either make both parameters mandatory or set a default width and height in the code.

Bitbucket: https://bitbucket.org/kmike/django-easy-maps/issue/9
Originally reported by: Anonymous
Originally created at: 2012-10-04T11:30:46.503

update easy_maps, here how it's done https://github.com/kmike/django-easy-maps/blob/master/easy_maps/templates/easy_maps/map.html#L11


Parameter types not colour-coded properly

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-08T23:31:51.320Z)
OS Version: Darwin x64 16.4.0
Extensions:

Extension
Author
Version

code-gnu-global
austin
0.2.1

code-runner
formulahendry
0.6.10

cpptools
ms-vscode
0.10.1

vscode-icons
robertohuertasm
7.2.0

ayu
teabyii
0.2.1

debug
webfreak
0.17.0

Steps to Reproduce:
In the following code snippet, all of the parameter types such as double, int, char, should colour-coded as a type.
double fn(double (*f)(double), double a, int b, char c) {
...
}

Instead, only the doubles in the first parameter (double (*f)(double)) are coloured differently.

what language is that?

C

This issue was moved to atom/language-c#209


Coud not record audio

version: 4.4.x
target: win32
Could not record mic audio by command:
ffmpeg -f dshow -i audio="Micphone (HIK 720P Camera-Audio)" -f gdigrab -show_region 1 -framerate 6 -video_size cif -offset_x 10 -offset_y 20 -i desktop out22222.mp4

Try recording only the audio (ffmpeg -f dshow -i audio="Micphone (HIK 720P Camera-Audio)" out.mp3") and check if that works

Uh,
Is there any other input devices available?
Try using a recent version (win32, gpl)
One more thing, you can use obs-studio to capture your desktop


issue476/477 debugging

Debug issue 476 and 477 via Jenkins. Not intended to be merged.

Fails only on cvxopt? Hmmm...

Confirmed on my computer.

@cjk12, you might want to update your MOSEK license, it looks like CVXopt could be the issue.

ready to close this with the conclusion that the example is a GP solver error for cvxopt?

I am!

closing; @cjk12 let us know if you disagree


add onScrollListener

please add onScrollListener for Controller

Did OnTouchEventListener  unmet your demand？I think onMoveUpdate(double x, double y) equals to scroll

NO, I need to always be aware
 onMoveUpdate When we touch, it works

so，how the chart can auto scroll， I don’t know the scene

Did OnTouchEventListener unmet your demand？I think onMoveUpdate(double x, double y) equals to scroll

Actually no. If we drag and release the chart, the chart has a intertia (惯性) will continue to scroll for a little distance. We cannot get the last position it scrolled to.

#54


Fix Join-String cmdlet FormatString parameter logic

PR Summary
Fix #8448
PR changes logic when applying FormatString parameter value.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

@sethvs Please add tests.

@iSazonov Done.

Looking...


Cannot use object of type stdClass as array

https://github.com/teamreflex/DiscordPHP/blob/8e9db5cff2fa17034ff57fa5e1b0bfcded8e1d52/src/Discord/WebSockets/Events/MessageReactionAdd.php#L34

Merged the reaction repository branch which will change the way these events are handled, will leave open until confirmed fixed

I has the same issue. it seems fixed with the update.
Thank you ;)


map ballshooter launch command to joystick button

It would be convenient for testing to make it possible for someone using gamepad teleop to be able to fire the ballshooter by pressing a button on the gamepad. In the past we have done something similar on other projects.

@bsb808 Could you point us to an example of a project where we've done this before?

@M1chaelM
I've got a working version of this on branch jessica/ball_shooter_teleop, in case you want to try it.  I won't put in a pull request until after 1.5 is out of the way.
To test:
Run scan/dock/deliver task
roslaunch vrx_gazebo scan_dock_deliver.launch
Run teleop node
roslaunch vrx_gazebo usv_joydrive.launch
To confirm the ball shooter actually fires, listen on the appropriate topic
rostopic echo /wamv/shooters/ball_shooter/fire
Hit the left lower trigger and you should see the ball shoot, as well as an empty message (---) on the firing topic.


Test cleanup - improve config and local auth

I'm working on implementing something similar to https://grafana.com/docs/grafana/latest/auth/auth-proxy/, and realized that the current tests don't work great for testing different authentication methods.
This PR has a few improvements for config/testing related things:

make<SomeAuth> routes now instantiate router inside the function. It was otherwise being reused, causing issues when testing with different configs
Consolidate config unit tests, leaving single argv param for testUtil
Consolidate local auth tests to not rely on pre-defined user vars in test utils (now uses the user created during signup to signin).

fyi @koszti I don't think this conflicts with anything you are working on but wanted to make you aware.


"Terminate Program" existing solution

Not sure if this is the right place for this comment, please feel free to move it / tag it differently.
I just read the spec document for the proposed "Terminate Program" PowerToy, and it sounded very familiar as I have for many years been using a small open source Windows app for that exact purpose. It may be interesting to mention it under "existing solutions"?
The program in question is called SuperF4, and as it happens is also hosted here on GitHub: https://stefansundin.github.io/superf4/

closing this as dup of #322 so we have a single tracking item.  They have been xref'ed


node-workflow does not include the Error JavaScript builtin constructor in tasks' sandboxes

Any workflow task that creates an instance of Error currently uses a different Error constructor than the one used by modules that are injected in the sandbox.
For instance, if a task uses the module Foo which exports the following assertIsError function:
modules.exports = {
  assertIsError: function assertIsError(someError) { assert(someError instanceof Error); }
}

then a task running the following code:
var err = new Error('some error');
Foo.assertIsError(err);

would assert.
For a real-world use case in Triton, this caused tasks run by sdc-workflow to not be able to call the callback of a vasync parallel/forEachParallel async workflow with an error object. Indeed, the Error instance created from the task would be passed to verror's MultiError constructor, which would in turn check if that instance is an instanceof Error. It would determine it's not, since the workflow task and the vasync (and thus verror) module would use a different Error constructor. Finally, that would make verror use extsprintf.sprintf on an object rather than a string, which would make it assert.
In that specific case, upgrading sdc-workflow's node-workflow (or wf) dependency to the tip of joyent/node-workflow#master fixes the symptom, because that version upgrades verror to a version that doesn't use instanceof Error in the same way, but the original problem is still there, and still causes some problems e.g when formatting the error message.

Fixed by cac32eec0fa906adeba683f7f9436a9247740f11.


Compile Error

I must be doing something dumb. Please advise. I'm getting a build error on initialization:
indicator = EMTLoadingIndicator(interfaceController: self, interfaceImage: image!,
                                        width: 40, height: 40, style: .line)

error: Use of unresolved identifier 'image'

Thanks!

@daviddelmonte Is the "image" variable declared correctly in your code?

I don't understand, sorry.. How should the image variable be declared? Thanks

@daviddelmonte You need to add some WKInterfaceImage object on the Interface Controller in Storyboard. Then declare IBOutlet variable such as 'image' in its custom class and connect to the above object.

OK. Got it !! Thanks!
On May 27, 2019, at 3:53 PM, Hironobu Kimura<EMAIL_ADDRESS>wrote:
@daviddelmonte https://github.com/daviddelmonte You need to add some WKInterfaceImage object on the Interface Controller in Storyboard. Then declare IBOutlet variable such as 'image' in its custom class and connect to the above object.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hirokimu/EMTLoadingIndicator/issues/4?email_source=notifications&email_token=AAA36N676IWHKAK5W4MBZVDPXPKTLA5CNFSM4HP2KSP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJXKNY#issuecomment-496203063, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA36N527MDAFSKSINNEWL3PXPKTLANCNFSM4HP2KSPQ.

Sorry, add-on question. I have the control working. However, how did you make the image take the whole watch window? I want to show the control while I'm downloading info from a web service.

@daviddelmonte Simply enlarge WKInterfaceImage's size and pass its size to EMTLoadingIndicator's initializer. You need to styling the indicator properly. But the graphic resource files of dot indicator are made for 80x80px size so it is not suitable for larger size.
You can make larger resource files with waitIndicatorGraphic.fla on your own (Flash CC or Animate CC required).

Thanks! it’s brilliant. Works perfectly..
On May 28, 2019, at 1:35 PM, Hironobu Kimura<EMAIL_ADDRESS>wrote:
@daviddelmonte https://github.com/daviddelmonte Simply enlarge WKInterfaceImage's size and pass its size to EMTLoadingIndicator's initializer. You need to styling the indicator properly. But the graphic resource files of dot indicator are made for 80x80px size so it is not suitable for larger size.
You can make larger resource files with waitIndicatorGraphic.fla on your own (Flash CC or Animate CC required).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hirokimu/EMTLoadingIndicator/issues/4?email_source=notifications&email_token=AAA36N6DYALMYBESYK5ATILPXUDG5A5CNFSM4HP2KSP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLWOUI#issuecomment-496461649, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA36N7CI3ENGW53FNAEQBTPXUDG5ANCNFSM4HP2KSPQ.


13...)  As a developer I want chirp to handle exceptions when cheeps are too long to become more user friendly

User Story
As a developer I want chirp to handle exceptions when cheeps are too long to become more user friendly
Description of the solution you'd like
Some error message should be handled when trying to send a cheep more than 160(?) characters
Definition of Done
Chirp should not puke on the user

done


Examples showing how to use auth modules for social logins

I think it would be beneficial if we add different examples for all the possible logins. Clear and easy to understand.

There is an example here for logging in via GitHub. The other providers should be similar.
Does that help?

It does definitely help. But I think it's just easier for developers, easy with sample code. Sometimes they can just stuck with small things. Plus I think we should just focus on "making product as easy as possible". So they can just focus on product. We can take care of the rest. Just a thought, you don't have to take this too seriously. 🙂

No, it's a great suggestion, and I agree the process should be easier.
One of the tricky parts about the social logins is that you need to tweak the configuration for the native app, so it's not quite as copy-pasteable as other examples, even when all the Dart code is right in front of you. And then there's also the backend config, and having to set that up properly.
Maybe the ideal would be to add some capability to nhost_flutter_auth, or a new package (one that includes the necessary plugins). An API where you could say nhost.auth.loginWithGitHub().
Maybe the package could even check your configuration (native app, and backend). Complain if it's wrong?

So We can keep 2 packages. One is the core. Few devs might not want to add these but we will still add these dependencies, which is not good I think.
The other package/packages, which will have all the native, and devs just plug it in and use it. Might be okay adding easy config in native if really needed to.
@elitan and I keen to make developer experiences as easy we can. Just like no-code but legos.

@elitan and I keen to make developer experiences as easy we can. Just like no-code but legos.

Makes sense. I think we can get something like that going.

Sorry, to be clear, that seems like a good goal, and is certainly possible. Whether to pursue is not my call.

Well I had been playing around with nhost-dart for a while now. Few observations.

Using app_links for the login, very smart move but I haven't able to make it work with.
Docs we need to work on.

So this is what I did.

I have used flutter_web_auth.
Setting the callback urls to 'io.higgle.dakuapp://login-callback

Future googleSignIn() async {
    try {
      final result = await FlutterWebAuth.authenticate(
        url: nhostGoogleLoginUrl,
        callbackUrlScheme: 'io.higgle.dakuapp://login-callback',
      );
      nhostClient.auth.completeOAuthProviderLogin(Uri.parse(result));
      return true;
    } catch (e) {
      print(e);
      return false;
    }
  }

And this works. But what about the web support? https://daku.app has web support. Any idea?


The 'Delete' icons are not aligned to the right after adding one user with a long UPN on ACL dialog

Storage Explorer Version: 1.9.0
Branch: master
Build: 20190731.1
Platform/OS: Windows 10
Architecture: ia32
Regression From: Previous release(1.9.0)
Steps to reproduce:

Expand one ADLS Gen2 account -> 'Blob Containers' node.
Right click one blob container then select 'Manage Access...'.
Add one user with a long UPN -> Check the 'Delete' icon next to the added UPN.

Expect Experience:
The 'Delete' icons are aligned to the right on the user/group list.
Actual Experience:
The 'Delete' icons are not aligned to the right.

More info:
This issue doesn't reproduce on Linux/Mac.

Fix merged into master.


Regarding Current Company

There should be an option saying that Presently you are working here .

Let's say suppose we are currently working in present company there is no option saying that presently working here

If you leave the end date blank. It should automatically do it.

Working fine .Thanks
On Sun, 25 Jul, 2021, 9:07 am Andrew Chumchal, @.***>
wrote:

If you leave the end date blank. It should automatically do it.
[image: image]
https://user-images.githubusercontent.com/8008169/126886946-3d2e87c2-12ea-4d0b-a9be-4b05889e6b0f.png
[image: image]
https://user-images.githubusercontent.com/8008169/126886947-e35a78aa-3e6d-470f-bbee-f7f51621d55f.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/539#issuecomment-886141904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULYU75NMRGLQFSE2CZJTJ3TZOBJPANCNFSM5A5WSPAA
.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


Find a solution for NoMethodError found by Travis CI

Finally hit the issue locally on seed 1441 in the features folder. My initial thoughts were that it was due to the deprecation of the each method for Strings in the Ruby version we're on. I'll investigate a bisect as well as the potential of deprecation.

Apparently bisect will never be useful and is just an insane use of time. I'll currently work under the assumption its due to .each deprecation.

All attempts to change "each" in children_node_ng lead to exceeding amounts of errors among multiple test paths and controllers.

children_node_ng's NoMethodError cannot be easily resolved and modifying it extends to multiple other tests and methods.


Button to reset the expense form

Some people sometimes get stuck on the expense form. Can be because of a bug, or a misunderstanding. Anyway, it would be great for them to have a "Reset" button that would clear the form and remove the draft saved in localStorage. We should make sure to show a confirmation before triggering the reset, to prevent misclicks.
@Memo-Es Could you suggest a position for such a button?

Link to the Production File

:gift: :money_with_wings: A $200 bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with $300 when the Pull Request is reviewed, accepted, and merged.
:arrow_right: More info

@Betree there are two different amounts in the comment above.

:trophy: This issue has been completed by @snitin315
To claim the bounty, you can either:

Submit an invoice to https://opencollective.com/engineering/expenses/new (please mention the issue number)
Or ask for an Open Collective gift card of the same value (to donate to other collectives)


[stable/hlf-peer] Update owners

What this PR does / why we need it:
Update hlf-peer owners
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

@nicolapaoli, pre-approving, but @dbandin and @inzamam-iqbal need to be members of the Helm organisation to be added as Owners

/verify-owners


Testing updates

According to https://gis.nicd.ac.za/portal/apps/opsdashboard/index.html#/0ec12f471aaa4055999366669b38482d

@JayWelsh Can you assist with extending the confirmed.csv with just pending but reflecting the numbers per provice.


deselectExclusiveOptionAdjective parameter of mutually-exclusive component is not documented

@jrbarnes9 this changed recently but will need doing as a part of the macro options.

Fixed in #2126


Fixing web_origins and allowed_origins update

Every time it deploys. It overrides my web_origins and allowed_origins config.

Thank you for you submission, this is spot on


Create Hosted Engine disks with the corresponding content type

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@tiraboschi please review

Looks OK to me, @tnisan did you verified it ?

Not yet as I'm waiting for the API model, VDSM and the Engine patches to be merged first

ci please build

ci please build

ci please build

This specific change is required in the Engine and was added to the <IP_ADDRESS> build


Improve Code Coverage

In response to #67

Branching off of in-progress work by @Symmetric
Currently, the only un-accounted for lines involve calicoctl calls that are subject to change soon.

A few more points of review feedback; mostly minor markups, so I think next round should be the last.

LGTM


fix: updating data sources and resources for fabric cloud router

Moved fabric_cloud_Router_read schema to fabric_cloud_router data_source.go
Moved fabric_cloud_router_schema to fabric_cloud_router_resource.go
Moved Cloud router dependent methods from fabric_mapping_helpers.go to fabric_cloud_router_resource.go
Updated documentation for fabric cloud router data sources & resources

References https://github.com/equinix/terraform-provider-equinix/issues/423

I have tested above changes with cloud-router-2-aws example script:

Codecov Report
Attention: 783 lines in your changes are missing coverage. Please review.

Comparison is base (a60c71f) 44.71% compared to head (e2d3d95) 40.67%.
Report is 33 commits behind head on main.

Files
Patch %
Lines

equinix/resource_fabric_port.go
59.16%
147 Missing :warning:

...ternal/resources/metal/project_ssh_key/resource.go
0.00%
131 Missing :warning:

internal/resources/metal/ssh_key/resource.go
0.00%
130 Missing :warning:

equinix/resource_fabric_cloud_router.go
59.49%
113 Missing :warning:

...rnal/resources/metal/project_ssh_key/datasource.go
0.00%
61 Missing :warning:

...nternal/resources/metal/ssh_key/resource_schema.go
0.00%
45 Missing :warning:

equinix/resource_fabric_connection.go
95.36%
26 Missing and 1 partial :warning:

internal/schema/fabric_common_schemas.go
0.00%
23 Missing :warning:

internal/resources/metal/project_ssh_key/models.go
0.00%
20 Missing :warning:

internal/schema/fabric_common_mapping_helpers.go
0.00%
18 Missing :warning:

... and 9 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   44.71%   40.67%   -4.04%
==========================================
  Files          98       98
  Lines       19888    18781    -1107
==========================================
- Hits         8893     7640    -1253
- Misses      10961    11105     +144
- Partials       34       36       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


C* read timeout during asynchronous checkpoint

Too much request are sent to C*.

https://datastax.github.io/java-driver/2.1.10/manual/retries/
http://stackoverflow.com/questions/30329956/cassandra-datastax-driver-retry-policy
Try to apply policy directly to the statement.

No more repeats.


WIP - Making DAP available in the adapter

The following PR intends to provide the feature requested in the issue: #7
Currently it's just WIP.

So far that's the result:

This occurs after starting the Adapter Lua Server running:
lua require("osv").launch({ port = 8086 })
That's recommended in the LazyVim configuration (link)
Currently investigating which can be the cause of the issue in the one-small-step-for-vimkind dap adapter.


Add Custom Projection to Camera3D

Add custom_projection property to Camera3D

Bugsquad edit, closes: https://github.com/godotengine/godot-proposals/issues/2713*

Can you test what happens if you create a projection that produces invalid output values, like NaN and what happens if they are injected into the renderer, it could cause serious issues (like what happens when you do the same for audio, where it cuts all audio)

Can you test what happens if you create a projection that produces invalid output values, like NaN and what happens if they are injected into the renderer, it could cause serious issues (like what happens when you do the same for audio, where it cuts all audio)

Actually this implementation affect just the projection matrix it works very well with oblique projection... , then it's for people that want to do some tweaks like 3d looks parallel in one dimensions, then it doesn't cause issues with viewports ..., I think it's so useful.
I started working on global shader overriding which will allow doing stuffs like curved world..., my problem now with the camera frustum.

What do you mean? I'm not asking for that, I'm asking what happens if you provide a broken Projection, that transforms values to NaN, the problem isn't "what limitations does it have?", it is "will adding an invalid projection mess up the rendering or crash?"

What do you mean? I'm not asking for that, I'm asking what happens if you provide a broken Projection, that transforms values to NaN, the problem isn't "what limitations does it have?", it is "will adding an invalid projection mess up the rendering or crash?"

I tested playing with the projection as i can it never crash the rendering.

Try with something like: Projection.create_orthogonal(-1, 1, -1, 1, 0, INF)

Projection.create_orthogonal(-1, 1, -1, 1, 0, INF)

I tested it, then it does not cause any problems, even with the frustum.

I also need this for my project, and I also have my own implementation (roughly the same): https://github.com/PitouGames/godot/tree/custom_projection
I don't understand why the projection matrix is accessible in the editor GUI in this PR after your comment: https://github.com/godotengine/godot-proposals/issues/2713#issuecomment-1773917923. User will still be able to show it with scripts like that:
extends Camera3D

@export var projection_matrix: Projection

func _process(delta):
	custom_projection = projection_matrix

There are the camera's functions set_perspective,  set_orthogonal,  set_frustum but the set_custom to switch the camera to the custom mode from code is missing (or I didn't found it).
Can we also take advantage of this PR to move the field "Current" up? It's in the middle of projection settings.

Can we also take advantage of this PR to move the field "Current" up? It's in the middle of projection settings.

While we're at it, I'd move Current at the very top and move Keep Aspect just above FOV.

I don't understand why the projection matrix is accessible in the editor GUI in this PR after your comment

Actually I just make it accessible because it makes it a little bit harder to test some values theoretically then making it accessible from the editor is pointless as the projection must be recalculated if the viewport had resized but still annoying to export another projection as a script variable then make a setter..., I think it's OK now.

See also:

https://github.com/godotengine/godot/pull/85529

Hello,
I stumbled upon a problem playing with this PR. It appear that shadows doesn't render correctly when the camera projection is set to custom and mimic orthogonal view (even if we just copy the projection matrix from another camera) :

It seems to work just fine when mimic a perspective view :

I'm sure that the two camera have the same projection matrix since I basically did :
$SubViewport2/Camera3D.custom_projection = $SubViewport/Camera3D.get_camera_projection()
I know that the problem as something to do with the shadow rendering but can't figure out what exactly ...

@BrunkMortel I'll check it because I don't have this issue in my projects, can provide which renderer are you using?

@DxUr I'm using the Forward+ renderer and everything else is by default.
Here is a simple scene setup that show the probleme : simple_scene.zip

Tested locally, I get a Vulkan device lost error if I adjust the Camera3D's projection matrix in the editor while the project is running:
ERROR: Vulkan: Did not create swapchain successfully. Error code: VK_NOT_READY
   at: prepare_buffers (drivers/vulkan/vulkan_context.cpp:2491)
ERROR: Vulkan: Cannot submit graphics queue. Error code: VK_ERROR_DEVICE_LOST
   at: swap_buffers (drivers/vulkan/vulkan_context.cpp:2571)

This only occurs if SDFGI is enabled. VoxelGI doesn't have these errors but renders incorrectly if any values in the custom projection are modified.
Also, running a project with a Camera3D that has its projection mode to Custom prints the following error (even if run outside the editor):
ERROR: Camera is not inside the scene tree.
   at: get_camera_projection (./scene/3d/camera_3d.cpp:212)

Directional shadow rendering also breaks if you change any values in the custom camera projection, with the following errors printed:
ERROR: Condition "!res" is true. Returning: false
   at: get_endpoints (./core/math/projection.cpp:502)
ERROR: Condition "!res" is true. Continuing.
   at: _light_instance_setup_directional_shadow (./servers/rendering/renderer_scene_cull.cpp:2153)

Point light shadow rendering breaks with certain values too (even though the rest of the scene still renders), but not as often as directional shadows. There are also no errors printed in this case.
Testing project: test_pr_84454.zip

@DxUr what's the status on this? Is there work to be done or are you waiting on more feedback?

@DxUr I would like to continue working on this PR, since it's nearly complete and I would benefit from it.

Hope this helps then: https://github.com/otonashixav/godot/tree/pr/DxUr/84454; I've fixed the issues reported so far, though I don't know if my solutions are satisfactory since I'm not really well versed in 3D.

I've just tried using otonashixav's branch, and every seems to work without error for my use case. One thing I will note is that the complete lack of a camera gizmo in custom projection mode is somewhat annoying. Showing the view frustum (maybe with an artificially shortened far plane) could be good, or bar that something like what DirectionalLight has just to indicate direction

I will make a PR with my branch this weekend if this PR isn't ready by then, since it seems like 4.3 will enter beta soon based on the dev5 blogpost.

Hope this helps then: https://github.com/otonashixav/godot/tree/pr/DxUr/84454; I've fixed the issues reported so far, though I don't know if my solutions are satisfactory since I'm not really well versed in 3D.

Thank you for fixing all the issues, I checked your solution and I think it's enough.

@otonashixav But it works fine for me, I had tried every possible case!

I mean it does work fine. I'm just concerned about some points that the reviewers might be able to clear up.

If I tilt the camera perspective upwards, the object "moves" downwards, but the background sky also moves downwards (into the brown area) instead of showing the sky above the object (see video).
The same thing happens when you tilt the camera perspective down, only in the opposite direction.
Is this intentional or a bug?

My specific use case

I want to create an camera array to make one big screenshot usig multiple cameras with custom projection but the sky is incorrect.

Using one camera
Using 4 cameras with custom projection

https://github.com/godotengine/godot/assets/71942164/2b8f0ab6-fc8b-405c-9d41-67ff83a0e99c
Video project: customprojection.zip
I used the latest build artifacts (one hour ago) on Windows 11.

If I tilt the camera perspective upwards, the object "moves" downwards, but the background sky also moves downwards (into the brown area) instead of showing the sky above the object (see video). The same thing happens when you tilt the camera perspective down, only in the opposite direction. Is this intentional or a bug?

This is not a bug, this is expected due to what a projection matrix is. The Projection matrix is 4x4 Matrix, you should not change it manually you must use a script to do that, Than you can fix the tilting by playing with all components.
Note that using a proper calculations is required.

The Projection matrix is 4x4 Matrix, you should not change it manually you must use a script to do that, Than you can fix the tilting by playing with all components.
Note that using a proper calculations is required.

In this case, it should be marked read-only in the inspector to prevent accidental changes. This can be done using PROPERTY_USAGE_READ_ONLY in _bind_methods().

Is the PROPERTY_USAGE_READ_ONLY flag all that is needed for this PR to be merged or are we waiting on responses to the comments from @otonashixav?

Thanks for writing this PR. I don't mind building from source but would love to see this merged so I can be confident relying on it in my project. Are there any remaining blockers? If more needs to be done, I'd be happy to help out.

This hasn't been reviewed entirely yet, so it needs to be reviewed properly first, so nothing you can help with necessarily, we're getting close to feature freeze as well meaning this is likely not going to be in 4.3

I have been using this feature for a few weeks now and would appreciate a merge for the 4.4 release.
From a user-perspective this feature seems to be stable.
My use case is a top-down projection with some additional care to make it pixel-perfect.

FYI I attended the Rendering Meeting, the main takeaway was that without screen space effects and all forward lighting pathways working with custom projection this would not get merged:
"Not clear how to maintain support for depth-related effects (SSAO, SSIL, SSR, SSS, lighting, SDFGI, VoxelGI, etc.)"
If you are using a custom projection with capacity to fully change the matrix I am not sure if you can deliver all those features reliably or not. Verifying what you can support lighting and effects wise and under what conditions seems to be the key to advancing this PR.


OsString support and regen

Part of https://github.com/gtk-rs/gir/issues/592
cc @GuillaumeGomez, @sdroege, @tmiasko

Upstream annotations seem to be incorrect for g_unix_is_system_device_path and
g_unix_is_system_fs_type. Those probably should accept path / filename
arguments.
Everything else looks great, thanks!

@tmiasko By test from gio source, seems it just string.
static void
test_is_system_fs_type (void)
{
  g_assert_true (g_unix_is_system_fs_type ("tmpfs"));
  g_assert_false (g_unix_is_system_fs_type ("ext4"));
}

Updated

I restarted Apveyor.
@GuillaumeGomez Please, restart travis too.

Restarted.

Again all passed except single Travis build (due nightly futures)

Then it's good enough for me. Thanks @EPashkin! :)

@GuillaumeGomez Seems this PR ready for merge, I even forget about it.

Weird I forgot it as well... Sorry about that...


[FEATURE] Access to GTK CSS inside stylesheet

Description of the requested feature
I have noticed that GTK specific CSS works, but only in the yuck file with the style macro.
This works inside eww.yuck
(box :class "box" :style "background-color: @window_fg_color" (children))
But this does not inside eww.scss
.box { background-color: @window_fg_color; }
I have tried importing the gtk.css, however some of the @ functions that GTK uses, are not in standard SCSS. ie @define-color, so this does not work either.
This is fine for most things, until you want to use a selector, or access themed icons.
I had a quick look and it looks like SCSS parsing is done by grass, so this probably isn't a trivial solution. However, having a GTK application have access to GTK CSS kinda makes sense.
Proposed configuration syntax
No response
Additional context
https://docs.gtk.org/gtk3/css-overview.html

I just had a look at somethemes, this is how they do it
$window_bg_color: gtkcolor(window_bg_color); .box { background-color: $window_bg_color; }
This successfully compiles with sassc, but fails with grass.

I had a look at how it's done in some gtk themes
.box { background-color: gtkcolor(window_bg_color); }
This compiles with sassc, grass-cli, but fails in eww.

error: 'gtkcolor' is not a valid color name
┌─ /home/lucas/Projects/nix/homemanager/lucas/dotfiles/eww/eww.scss:34:1
│
34 │   background-color: gtkcolor(window_bg_color);
│ ──────────────────────────────────────────────

Yup same issue here
id love to have this work as this would make me be able to have it change colors very nicely if my GTK theme changes


Bump version to 0.5.0 for release

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage     71.03%   71.03%
  Complexity      523      523
=========================================
  Files            75       75
  Lines          2593     2593
  Branches        267      267
=========================================
  Hits           1842     1842
  Misses          648      648
  Partials        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb7021...7900e51. Read the comment docs.

LGTM


[10.1.x] ISPN-11198 rolling upgrade docs

https://issues.redhat.com/browse/ISPN-11198

Merged into 10.1.x, thanks @oraNod


Update README.md

Added the absolute path format to find command

@trimstray please review!

Ok, but it doesn't do anything special. Maybe something more for hackers? :) You know - something rarely seen.
On the other hand, why this one-liner is good for you? Look at this.

Ok


BUG: Gitlab Commits Before Date Needs More Logic

Describe the bug
Using the first commit returned has proven to not be the best source for the retrieval of merge requests details.
Expected behavior
The before field is intended to help limit the number of merge request details based on the last commit date for the default branch. By using the first record, this may not always include all of the related merge requests, throwing the scoring calculation off.
Additional context
I believe it would be better to calculate the date by cycling through the commits to determine the best date to use. I have a this is a working branch that I'm working through while validating the Code-Review check's scores

By default, GitLab GraphQL returns the most recent merges on a GitLab repo. But we don't guarantee the merge request that brought in a commit on a GitLab repo's main branch is captured by our check - we may undercount - or miss - merge requests in zip if GraphQL and the REST API don't line up. (We use 1 GraphQL query + 1 REST API call instead of 1 REST API call per commit to find the linked Merge Request, which wouldn't scale).
The purpose of using mergedBefore in getMergeRequestDetail is to improve this - "don't give me any merge requests newer than the newest commit I've listed". But, I think you're right that before := commitsRaw[0].CommittedDate may not reflect the commit date of the newest commit (it might be much older, therefore leading to a lower score). We might fix this is to find a better bound commit date in commitsRaw, or by making a single API query to ListMergeRequestsByCommit to get the right date for before.


Update Scrim Status in all cases

Task linked: CU-2k53pg1 Bug: Scrim status is not being updated consistently


Italy

http://www.dati.gov.it/catalog/dataset

Stale - no response. Someone else is welcome to take this on.


Documentation out of sync between English and German

Hey folks!
currently, the documentation to this article is out of sync between English and German.
In English it's described that it is possible to use a user-assigned identity.
And in German it's described that it's only possible with a system-assigned identity and NOT with a user-assigned.

PS: On the German Page there is also no Feedback Button ;-)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7feaa3d0-7233-a3cb-cb9b-a9a55b1f0d7a
Version Independent ID: f41f9d51-52f8-1f45-1043-1344a3b74458
Content: Use Key Vault references - Azure App Service
Content Source: articles/app-service/app-service-key-vault-references.md
Service: app-service
GitHub Login: @mattchenderson
Microsoft Alias: mahender

Thanks for the feedback @AndiD42! I have assigned the issue to the content author to investigate further and update the document as appropriate.

This was already updated. #please-close


🐛 BUG: wrangler dev crashes unless run via sudo

Which Cloudflare product(s) does this pertain to?
Wrangler core, Miniflare
What version(s) of the tool(s) are you using?
3.15.0 [Wrangler]
What version of Node are you using?
18.16.0
What operating system are you using?
MacOS Ventura 13.6.2 (22G320)
Describe the Bug
Wrangler always fails to start when not run using sudo.
Not using sudo:
% npm run start

><EMAIL_ADDRESS>start
> wrangler dev

 ⛅ wrangler 3.15.0
-------------------
⎔ Starting local server...
workerd/util/symbolizer.c++:98: warning: Not symbolizing stack traces because $LLVM_SYMBOLIZER is not set. To symbolize stack traces, set $LLVM_SYMBOLIZER to the location of the llvm-symbolizer binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
*** Fatal uncaught kj::Exception: kj/compat/tls.c++:72: failed: OpenSSL error; message = error:0900006e:PEM routines:OPENSSL_internal:NO_START_LINE
stack: 10559e1db 10559ff63 1048caf5f 1048ccf77 1048d3fcf 1048d758f 1048c4d57 1048c8317 1048c8153 1048c813b 1067799bf 106779d07 106778467 106778237 1048bc1af 196703f27
✘ [ERROR] MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.

With sudo:
% sudo npm run start
Password:

><EMAIL_ADDRESS>start
> wrangler dev

 ⛅ wrangler 3.15.0
-------------------
⎔ Starting local server...
[mf:inf] Ready on http://<IP_ADDRESS>:8787
[mf:inf] - http://<IP_ADDRESS>:8787
[mf:inf] - http://<IP_ADDRESS>:8787

This worker was created using the standard template:
(This is why I didn't link a minimal-repo...)
% npm create cloudflare\@2

using create-cloudflare version 2.6.2

╭ Create an application with Cloudflare Step 1 of 3
│
├ In which directory do you want to create your application?
│ dir ./twilight-fire-7daa
│
├ What type of application do you want to create?
│ type "Hello World" Worker
│
├ Do you want to use TypeScript?
│ no typescript
│
├ Copying files from "hello-world" template
│
├ Retrieving current workerd compatibility date
│ compatibility date 2023-10-30
│
╰ Application created

╭ Installing dependencies Step 2 of 3
│
├ Installing dependencies
│ installed via `npm install`
│
├ Committing new files
│ git commit
│
╰ Dependencies Installed

╭ Deploy with Cloudflare Step 3 of 3
│
├ Do you want to deploy your application?
│ no deploy via `npm run deploy`
│
├  APPLICATION CREATED  Deploy your application with npm run deploy
│
│ Navigate to the new directory cd twilight-fire-7daa
│ Run the development server npm run start
│ Deploy your application npm run deploy
│ Read the documentation https://developers.cloudflare.com/workers
│ Stuck? Join us at https://discord.gg/cloudflaredev
│
╰ See you again soon!

Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

This is likely to be a specific issue with your local computer's configuration—Wrangler doesn't usually (and shouldn't) require sudo in order to run. A couple followup questions to help with diagnosing the root cause here:

What is the output of npx workerd --version
Can you run other NodeJS programs and npm scripts without sudo?

This StackOverflow thread may also be helpful in diagnosing general permissions issues with npm and NodeJS
For issues like this, the Cloudflare developer discord is a great place to go for help.

I have many other projects that I run on my system which use Node pretty much every way you can imagine. I can install global dependencies without permission issues, run servers, build applications, etc...
My workderd version is "2023-10-25", which is just what you get from the boilerplate. I don't have workerd installed globally.

More info: I have an cloudflare pages project which we've occasionally used wrangler pages dev with a static build to debug in the past. I just tried firing that up, and it works on wrangler 2.20.1 but has the same issue on 3.15.0.
wrangler 2 output
% npx wrangler@2 pages dev public
🚧 'wrangler pages <command>' is a beta command. Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose
REDACTED FROM LOGS - removed warning about no compatibility_date specified

Compiling worker to "/var/folders/zy/p56997jd7fxd5_tj6ck7dxsh0000gp/T/functionsWorker-0.11757179851197308.mjs"...
✨ Compiled Worker successfully
 ⛅ wrangler 2.20.1 (update available 3.15.0)
-------------------------------------------------------
Want to try out the next version of local mode using the open-source Workers runtime?
Switch out --local for --experimental-local and let us know what you think at https://discord.gg/cloudflaredev !
⎔ Starting a local server...
REDACTED FROM LOGS - removed a bunch of warnings about redirects
[mf:inf] Worker reloaded! (125.34KiB)
[mf:inf] Listening on <IP_ADDRESS>:8788
[mf:inf] - http://<IP_ADDRESS>:8788
[mf:inf] - http://<IP_ADDRESS>:8788

wrangler 3 output
% npx wrangler pages dev public
REDACTED FROM LOGS - removed warning about no compatibility_date specified
Compiling worker to "[REDACTED]/.wrangler/tmp/pages-9yACYq/functionsWorker-0.9515818751260783.mjs"...
✨ Compiled Worker successfully
 ⛅ wrangler 3.15.0
-------------------
▲ [WARNING] --local is no longer required and will be removed in a future version.

  `wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉

⎔ Starting local server...
▲ [WARNING] Parsed 813 valid redirect rules.
REDACTED FROM LOGS - removed a bunch of warnings about redirects
workerd/util/symbolizer.c++:98: warning: Not symbolizing stack traces because $LLVM_SYMBOLIZER is not set. To symbolize stack traces, set $LLVM_SYMBOLIZER to the location of the llvm-symbolizer binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
*** Fatal uncaught kj::Exception: kj/compat/tls.c++:72: failed: OpenSSL error; message = error:0900006e:PEM routines:OPENSSL_internal:NO_START_LINE
stack: 1056661db 105667f63 104992f5f 104994f77 10499bfcf 10499f58f 10498cd57 104990317 104990153 10499013b 1068419bf 106841d07 106840467 106840237 1049841af 196703f27
✘ [ERROR] MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.

I actually have this exact issue with a fresh bootstrapped app:
>% npm create cloudflare@2

using create-cloudflare version 2.6.2

╭ Create an application with Cloudflare Step 1 of 3
│
├ In which directory do you want to create your application?
│ dir ./dry-cell-e210
│
├ What type of application do you want to create?
│ type "Hello World" Worker
│
├ Do you want to use TypeScript?
│ no typescript
│
├ Copying files from "hello-world" template
│
├ Retrieving current workerd compatibility date
│ compatibility date 2023-10-30
│
╰ Application created

╭ Installing dependencies Step 2 of 3
│
├ Installing dependencies
│ installed via `npm install`
│
╰ Dependencies Installed

╭ Deploy with Cloudflare Step 3 of 3
│
├ Do you want to deploy your application?
│ no deploy via `npm run deploy`
│
├  APPLICATION CREATED  Deploy your application with npm run deploy
│
│ Navigate to the new directory cd dry-cell-e210
│ Run the development server npm run start
│ Deploy your application npm run deploy
│ Read the documentation https://developers.cloudflare.com/workers
│ Stuck? Join us at https://discord.gg/cloudflaredev
│
╰ See you again soon!

>% cd dry-cell-e210
>% npm run dev

><EMAIL_ADDRESS>dev
> wrangler dev

 ⛅ wrangler 3.15.0
-------------------
⎔ Starting local server...
workerd/util/symbolizer.c++:98: warning: Not symbolizing stack traces because $LLVM_SYMBOLIZER is not set. To symbolize stack traces, set $LLVM_SYMBOLIZER to the location of the llvm-symbolizer binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
*** Fatal uncaught kj::Exception: kj/compat/tls.c++:72: failed: OpenSSL error; message = error:0900006e:PEM routines:OPENSSL_internal:NO_START_LINE
stack: 101a0a1db 101a0bf63 100d36f5f 100d38f77 100d3ffcf 100d4358f 100d30d57 100d34317 100d34153 100d3413b 102be59bf 102be5d07 102be4467 102be4237 100d281af 19d913f27
✘ [ERROR] MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.

>% sudo npm run dev

><EMAIL_ADDRESS>dev
> wrangler dev

 ⛅ wrangler 3.15.0
-------------------
⎔ Starting local server...

% npx workerd --version
workerd 2023-10-25

echoing NODE_EXTRA_CA_CERTS does indeed return one item, which is a self-signed cert for another project on my machine. I checked that file and it looks like it's already got permissions which shouldn't have an issue:
% echo $NODE_EXTRA_CA_CERTS
/Users/trappar/Dev/local-development/packages/local-proxy/tls/combined.pem
% ls -al /Users/trappar/Dev/local-development/packages/local-proxy/tls/combined.pem
-rw-r--r--@ 1 trappar  staff  3762 Jul 10 15:33 /Users/trappar/Dev/local-development/packages/local-proxy/tls/combined.pem

Just to be sure I tried setting the permissions for that file to 777, but doing so made no difference when trying to run wrangler. So then I tried just running NODE_EXTRA_CA_CERTS="" pnpm dev, and that did the trick.
Any idea why that file is causing wrangler to crash? I believe it's a valid certificate. It doesn't seem to cause issues with any other node invocations, and the code that uses it also works (i.e. when running that local-proxy package, I'm able to access resources through SSL without issue)

Having investigated this a bit more, it looks like I can reproduce this when NODE_EXTRA_CA_CERTS is set to a private key file (or combined file), rather than a certificate file. I wonder if this is what's happening here for you, especially since the file is called combined.pem.
Could you try setting NODE_EXTRA_CA_CERTS to just the certificate file from /Users/trappar/Dev/local-development/packages/local-proxy/tls/combined.pem, and see if that works?

I seem to have the same issue and I'm very much confused. My NODE_EXTRA_CA_CERTS is already empty, but running with sudo works.
I got even more confused when I realised I had another worker locally that had the same version of wrangler (3.20.0) that worked. I compared the wrangler.toml files and basically only the port differed.
Changing the port number worked for me. 80 (not set by me) worked fine in v2, but in v3 it didn't. Set it to 8081 and all was good.
Hopefully changing the port works for others too.

I think this needs to be reopened as it's still a problem. The docs for NODE_EXTRA_CA_CERTS indicate that the file should be in .pem format. In changing NODE_EXTRA_CA_CERTS to the .crt file instead Wrangler does work as expected.


Add support for non-async APIs like chrome.i18n?

Right now all APIs are asynchronous because under the hood, IJSRuntime is being used. This is very bad when we need APIs call from .razor pages (which do not support async) and every chrome.i18n.getMessage call is asynchronous which is not very fast IMO and there is no way to batch call this as far as I am aware of.
Can we add suport for IJSInProcessRuntime? I am happy to do a PR for this.

Sorry for the late reply. The APIs are mostly asynchronous and if you look at the implementation in Chrome, they have a callback parameter, which is being converted to asynchronous promise-based APIs by the polyfill.
The APIs that are not asynchronous are not many, but it is exactly the same as of now with IJSRuntime and IJSInProcessRuntime due to being single threaded in the browser.


DOC: correct docstring on bluesky.utils.snake_cyclers

Thanks to @cmazzoli for bring this to my attention.

Description

Fixes a docstring to match what the code does.
Motivation and Context

The docstring was wrong and confused @cmazzoli
How Has This Been Tested?

N/A

this is now covered here https://github.com/bluesky/bluesky/pull/1776,
closing


Fixes leak of ssl_ocsp_response_path_only on reload

This may be occurring in 9.0.x as well.

Cherry-picked to v9.2.x


Create reproducible builds for TDP Hadoop

This PR aims to achieve reproducibility in TDP Hadoop. See issue #1
Changes in this PR:

hadoop-maven-plugin: return project.build.outputTimestamp maven properties if present instead of system date in getDate method.

Add project.build.outputTimestamp in a few places to enable reproducibility

Maven plugins upgrade:
maven-antrun-plugin.version: 1.7 -> 3.1.0
maven-assembly-plugin.version: 2.4 -> 3.4.2
maven-jar-plugin.version: 2.5 -> 3.3.0
maven-resources-plugin.version: 2.6 -> 3.3.0
maven-shade-plugin.version: 2.4.3 -> 3.4.1
maven-source-plugin.version: 2.3 -> 3.2.1
maven-war-plugin.version: 3.1.0 -> 3.3.2

These Maven plugin updates breaks compilation of some module. According changes have been made in their pom.xml.
A more thorough investigation is still needed to verify that the binaries included after theses changes are still valid. They have not yet been tested in a Hadoop cluster

Update to this PR:

the .tar.gz used in TDP (built by the hadoop-dist) module is now reproducible.
Only one file in the project is flagged as non-reproducible and I don't understand why (the .pom file is compared to .jar file in hadoop-dist-project for some reason)
The .tar.gz has been succesfully installed on a test cluster.

What I have not done:

Launch the test using maven
Do some integration test on the newly created cluster

I've requested an account to the Apache JIRA (you need an authorisation to create an issue as of November 22)
I have also looked on the Tez and Hbase reproducibility. HBase was easy to make reproducible, tez a bit more tricky.
The real challenge will probably be Hive.

Closing due to inactivity


Update README.md - Include required perl packages

Discovered some additional perl packages that needed to be installed beyond just "perl" when trying to run errata-sync.sh. Added a "Prerequisites" section to indicate this.

Thanks for the catch, I had these installed for the errata sync scripts for Debian/Ubuntu https://github.com/philicious/spacewalk-scripts


Clean up Diff Resource modal

The diff modal looks very busy to me - see below - could we "clean this up" somehow?

move all buttons/options to the top?
improve alignment of buttons/labels?
change Local/Cluster to not look like buttons?

if this is just me we can ignore :D

The modal has been slightly redesigned since


Time duration picker

Can you add an example for a time duration picker. Like somehow two wheel picker next to each other. One for the hours and the other one for minutes.

It would be nice to have a design sample that I can refer to. thank you.


Ensure lack of sections does not break styleguide and update examples

This fixes issues introduced by the merge of #108 in to master.
Both @paulj and @sapegin may have some ideas on the changes to index.js here, but this ensures that sections not being provided will not break the styleguide. There were issues with running examples as a result of this merge.
This also adds a basic example using sections for testing this new feature.

Please also check Travis log.

@sapegin The other option here is to move these to the process* functions, which means that this base code should remain quite simple?

But how would you check for required sections or components? (Not sure it’s necessary.)
And in you current implementation you can use only sections or components, not both. (No sure it’s critical or bad.)

@sapegin Yes, It wasn't clear whether or not they could both be supplied or if components were ignored when sections was provided, so I expected you or @paulj would have some information on this front.

So to be clear here, my understanding is this:

Components is not required, if the Sections property of the config is provided
If no Sections property is provided, then Components is expected/required to exist
Both Components and Sections can be provided and the styleguide takes these both in to account without issue

That last point is something I am not clear on. I assume that they can both be provided, however if a section contains a component that is provided within the components configuration property, then that component will be listed twice within the style guide. Is this correct @sapegin and @paulj?

@karlbright Yes. If the same files ended up being listed twice (either in components and sections, or even just in two different sections), then they would end up being included twice.

@paulj Cool, figured as much. Updated to cleaner syntax, much happier.

Thanks @karlbright @paulj!


feat/predict-recurrence

Please review before merging.

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Video not looping on Android

I've put the repeat prop to true, but the video stops playing when it reaches the end

Hi, I submitted a PR for that today. Check #587.

Can confirm. The video loops, if the source isn't changed. If the source changes without the component being mounted again, the video doesn't loop.

Having the same issue, any updates? @radko93 any momentum on your PR?

@zachrnolan someone from the contributors needs to merge. Maybe it will be helpful if someone else could review it too.

This PR was just merged.


Chat room - cannot join and communicate

Hello,
I tried your lib to run a bot on a chat room, but I can't get it to work as expected

On a simple "friend chat" it's working perfectly (receiving messages & can send responses)
On a room chat, I try to join the chat (using steamFriends.joinChat('id') as shown in the exemple) and I'm getting on chatEnter event a status 1 (Success), but I don't see the bot in the chat room, cannot send message and do not recieve messages 😞
I tried with group's chats and private chats, for group's chat I have the chatEnter event but not for the private ones

There is an issue with the ID itself ?
For the group chat I used this technique :
For a given group : https://steamcommunity.com/groups/the-name
I check : https://steamcommunity.com/groups/the-name/memberslistxml/?xml=1 -> groupID64
For a private chat I tried many ids found on the steam web client (chat_id, chat_group_id) but I don't have result with any of them
Am I supposed to build a SteamID with "accountId" being this id (chat_id ?) and the rest like a group id ?
var steamID = new SteamID({
  accountID: 123456,
  accountInstance: SteamID.ChatInstanceFlags.Clan,
  accountType: Steam.EAccountType.Chat,
  accountUniverse: Steam.EUniverse.Public
});

About the code, I'm not trying anything fancy yet, it's almost the exemple code with other credentials, chat id and some debuging lines (like listing all messages)
Running node 12.13.1 and npm 6.12.1
Can you help me with this ?

The chat functionality works only with "old" chats which are not visible in the Steam client unless you run it with the -no-browser argument. To work with "new" chats, you have to use unified messages. See https://github.com/seishun/node-steam/issues/432#issuecomment-445967970 for details.

OK, I'll try with this method
It might be useful to have some helper method for this and update the doc for future users

After a bit of SK2 documentation and testing I have something working :
To send a message :
const chatRoom = new Steam.SteamUnifiedMessages(steamClient, 'ChatRoom');
chatRoom.send('SendChatMessage', {
	chat_id : '',
	chat_group_id : '',
	message: 'message'
}, (eresult, resp) => { console.log(eresult, resp); });

--
To recieve messages :
steamClient.send({
	msg: Steam.EMsg.ClientCurrentUIMode,
	proto: {}
}, new Steam.Internal.CMsgClientUIMode({ chat_mode: 2 }).toBuffer());

Then
const friendMessagesClient = new Steam.SteamUnifiedMessages(steamClient, 'ChatRoomClient');
friendMessagesClient.on('message', (methodName, body) => {
	if (methodName === 'NotifyIncomingChatMessage') {
		// do things with body
	}
});


Build: update by mix deps.update --all

https://github.com/elixir-nx/xla/issues/52

The fail is only for macOS, and it caused by failing to download XLA, so I decided to merge this PR.


[GE/Common integration] GE unable to find the openlineage integration starting with 0.19.1

Beginning with OpenLineage 0.19.1 , Great Expectations is seemingly unable to find the openlineage.common.provider.great_expectations module.
$ great_expectations checkpoint run <checkpoint> throws the following error:
No module named `openlineage.common.provider.great_expectations` could be found in your plugins directory.
    - Please verify your plugins directory is configured correctly.
    - Please verify you have a module named `openlineage.common.provider.great_expectations` in your plugins directory.

When an earlier version of the integration is used, the command executes without the error being thrown.

We investigated this issue and it is caused by a hidden new dependency: the Great Expectations integration, to run, now needs openlineage-sql==0.19.2 installed. This may also be the case for other common providers.
Either these common providers do need the SQL dependency, in which case a better error message is required, or they do not and this is a bug that is causing a breaking change.


Error fetching sheet

$ cat gsheet.js
#!/usr/bin/env node

var GoogleSpreadsheets = require("google-spreadsheets");

var key = process.argv[2];

console.log("sheet:", key);

GoogleSpreadsheets(
      {
        key: key
      },
      function(err, sheet) {
        console.log(err, sheet);
      }
);
$ gsheet.js 1Bb-SLy4E-alUUSJ68Qb5nNmZG6HsPbG2j6Ye_QZO77Y
sheet: 1Bb-SLy4E-alUUSJ68Qb5nNmZG6HsPbG2j6Ye_QZO77Y
[TypeError: Cannot read property 'title' of undefined] null

Trying to fetch this sheet.

I think this is a dupe of #34?

Pretty similar: the sheet didn't have the right permissions, as you noted.
Can I rephrase this as: "Improve error message when fetching sheet with incorrect permissions"?
I filed this separately from #34 because it goes via a different API and gives a different, also unhelpful, error message to what I was hitting in #34.

This issue is now fixed in 0.5.0 of the lib. If you try to access a non-public sheet without auth you'll get the error No access to that spreadsheet, check your auth..


Flutter shouldn't grow image cache arbitrarily

https://b.corp.google.com/issues/147479267.
cc @cbracken , @mehmetf  (to whom the internal bug was originally assigned).

I think that this is a duplicate of https://github.com/flutter/flutter/issues/45643.


mark up license in README.md

so that GitHub renders it correctly
(An alternative would be to wrap it in ``` lines, so that it'd be rendered as a preformatted verbatim ("code") block. But monospace fonts don't make prose very readable, so I'd prefer the change I propose here.)

Thank you!


[meta] maintenance status of service discovery mechanisms

Proposal
Over the years, the project accumulated 29 service discovery mechanisms. While some SDs are widely used (e.g. Kubernetes, EC2, GCP, Azure, ...), the project faces a couple of issues:

No clear ownership for some SDs. For instance, nobody part of the Prometheus team has direct experience with Azure (dev summit notes).
"Critical" service discoveries like Kubernetes sometimes lack timely reviews.
Very limited end-to-end testing (e.g. manual only).
A high number of SDs means bigger binary size because of SDK dependencies.

The goals of this issue are to:

Identify official maintainers for each SD.
Evaluate whether we want/need to deprecate some of them (since Prometheus 3.0 is around the corner, it might be the right time).

I've put together a spreadsheet to detail the current state.

Ideas that came up during DevSummit today:

Remove all SDs from in Prometheus 3.0, and re-add only those with clear maintainership.
Escalate the problem to CNCF, hoping CNCF can find help from cloud providers to maintain their respective SDs.
Keep the current state.

My 2 cents:
Seeing how often this subject comes up, I think we're not happy with the current state and our real choices are one of the first two options above.
It's my first time maintaining a CNCF project when I joined the team here, 2-3 months ago, so my opinion is not based on facts but just a feeling. My feeling is that reaching out to CNCF usually takes waaaaaay too much time to see results, time that we don't have for 3.0.
Option 1 is quite aggressive, but there's the counterpoint that we're super happy to re-add service discoveries once they meet certain criteria.
If we move forward with option 1, I think we need to act fast here. We need to decide what this criteria is, send a blog post about this decision, and call for action on our social media platforms so cloud providers aren't caught by surprise.

If it's helpful, I'll volunteer to "officially" maintain Linode SD -- I no longer work for Linode, but I am the primary author of that SD and do my best to keep an eye on issues/PRs that touch it. Happy to work with anyone currently employed by Linode as well, if that's more desirable (perhaps @wbh1 can help on that front)

Maybe another option: should prometheus adopt something similar to how the otel-collector has a core and contrib set of builds? Core being the officially maintained components, contrib being "all SDs enabled, use at your own risk"?
It's already possible to pick and choose which SDs are included when building prometheus using the SD plugin config, perhaps the release process for prometheus could be expanded to build 2 binaries for each platform/arch; a slimmed down core build with whatever SDs are determined to make that list, and a contrib style build that has *?

Just an update, I was feeling a bit anxious about this topic and raised it internally. The general feedback was that this is not as urgent as it seemed to me, we won't remove anything with 3.0 and it's more productive to discuss everything with the community (like we're doing in this issue) 🙂

Maybe another option: should prometheus adopt something similar to how the otel-collector has a core and contrib set of builds? Core being the officially maintained components, contrib being "all SDs enabled, use at your own risk"?
It's already possible to pick and choose which SDs are included when building prometheus using the SD plugin config, perhaps the release process for prometheus could be expanded to build 2 binaries for each platform/arch; a slimmed down core build with whatever SDs are determined to make that list, and a contrib style build that has *?

That sounds like a good idea honestly! A separate repository to handle SDs might make it easier to handle code ownership. If this repository lives under the prometheus-community org, it's even easier to add new folks with write/maintainership roles.

That sounds like a good idea honestly! A separate repository to handle SDs might make it easier to handle code ownership. If this repository lives under the prometheus-community org, it's even easier to add new folks with write/maintainership roles.

💯

BTW, I hope that with the new governance, the formal difference between the prometheus and prometheus-community GH orgs will mostly disappear.


Fold button submits forms

If you use the fold property to collapse a layer group, and the map is within a form, clicking the arrow (which is a <button>) to expand the group submits the form.
I think we just need to add e.preventDefault(); to fix this. Here is the click function:
https://github.com/walkermatt/ol-layerswitcher/blob/32735005cb5eaa3c20310856dc346fb0261f7c4c/src/ol-layerswitcher.js#L308
For reference, here is the click callback for the main LayerSwitcher button, which does have a e.preventDefault(); in it:
https://github.com/walkermatt/ol-layerswitcher/blob/32735005cb5eaa3c20310856dc346fb0261f7c4c/src/ol-layerswitcher.js#L57

I created a pull request for review: #260

@mstenta thanks for reporting and the PR 👍


Write out release instructions as a bullet pointed list

A public release how-to (usually consisting of a bullet-pointed list) allows all maintainers to have the ability to publish a release of the new version of the package by following straightforward steps.
This allows the release procedure to be evaluated & commented on by contributors.
For example:
It would be easier for me to comment on how to avoid some of the issues related I've most recently commented on in #20 if these instructions were made explicit. It's hard for me to do more than guess about what went wrong because I can't work off of that document.

@sbassi
Could you document how you are doing your releases? It will help me diagnose why your 0.8.1 package is not working correctly on legacy pypi.

Yes, in the next release I will make notes.


Issue with handling invalid channels

Calling getTwitchChannel on an invalid channel is not handled.

Now handled with a InvalidTwitchChannel exception.


Fix Error in Add Field Method

Add field was calling keys() method on uninstantiated column_family instance. Changed it to call keys on ._columns instead.

Coverage remained the same at 67.687% when pulling d47023185a62aa5e2d08e9c517293659dc51a4d9 on sethdenner:fix-error-in-add-field into 915e83649174b7055960c3b112645faeed0b1964 on Knotis:master.


Local module descriptor class for com.google.android.gms.providerinstaller.dynamite not found

when ever using cloud_firestore to upload data or get data from firebase it gives this error

@t00fi
When opening an issue, please use new issue template and fill out requested details so that we'll have enough info to work with.
Currently, no details are provided so we can't proceed to make it actionable.
Closing for now due to lack of details.


SCED code for foreign language and literature

The enumeration for School Courses for the Exchange of Data Course Subject Area (C001518) is missing Foreign Language and Literature. There is also a gap in the URI numbering where it would fit (NI001518118409). Is this an error

The "Foreign Language and Literature" subject area was reclassified, which is why you do not see it in CEDS V12.  Below is a description from SCED's FAQ:
From https://nces.ed.gov/forum/pdf/sced_faq_508.pdf :
Where are Foreign Language and Literature courses that were previously included in Subject Area 06
located?
SCED Version 4 reclassified Foreign Language and Literature courses in the newly created Subject Area 24:
World Languages. This reclassification was necessary to update existing courses and add new courses that were
SCED Frequently Asked Questions 6 recommended by subject matter experts and SCED users.

Thank you @aemnathanclinton


Update Patched VS Code version to 1.93.1 with patches applied

Issue #, if available:
This PR adds patches for code editor and applies them on Patched VS Code.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Where are the patches in the diff?


ordering for embedding rows

many users want to do things like retrieve the last three things entered into chroma. This requires an idea of ordering that chroma currently does not support.

Dupe of this https://github.com/chroma-core/chroma/issues/469


Apply MVVM to session detail page

Overview
https://github.com/konifar/droidkaigi2016/issues/382
Applied MVVM architecture to SessionDetailFragment. Baby steps 😉

Created SessionDetailViewModel

Moved some logic and view status from SessionDetailFragment to SessionDetailViewModel
Replaced session to viewModel in fragment_session_detail.xml

TODO

[ ] Add SessionDetailViewModelTest
[ ] Use ObservableField or BaseObservable to manage Fab status
[ ] Modify circle.yml to run Robolectric test on CI

@hotchemi @amay077
Hi, I tackled #382. This is WIP but I'm glad you review this if you have a time. Thanks!

So fast! It blew my mind actually 👍

Here we go!!!!!!!!!!

Thanks!


game crashes on launch

game immediately returned to launcher and gave me this message
The game crashed whilst initializing game
Error: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
Exit Code: -1
i have used an earlier version of the mod in the past for a 1.17 snapshot but completely removed it from my folder
i have other mods including
entity culling
optifabric
and simple voice chat
does anyone know what's causing this

Please post your full crash report and minecraft log. Also try it without optifabric.

Duplicate of #95


Implement complex.abs

The question is, why u'1e+06' is falling back in float.__repr__? I should check unicode implementation

@trotterdylan just fixed the float.__repr__, but we still need to modify some of assertions in expr_visitor_test.py, to be like this:
testNumFloatNoDecimal = _MakeLiteralTest('5.', '5.0')
testNumFloatSci = _MakeLiteralTest('1e16', '1e+16')
testNumFloatSciCap = _MakeLiteralTest('1E16', '1e+16')
testNumFloatSciCapPlus = _MakeLiteralTest('1E+16', '1e+16')

from CPython:
$ python -c "print repr(5.)"
5.0
$ python -c "print repr(1e+06)"
1000000.0
$ python -c "print repr(1e+15)"
1000000000000000.0
$ python -c "print repr(1e+16)"
1e+16

@trotterdylan it's ready to review

Looks great! Thanks for the PR. Merging.


Consider a better name

For example, Rewriter of Messages

it's called message bender now

[ ] update gif with this name


MutabilityAnalysisException thrown during analysis

ERROR:
[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ fb-tests ---
[INFO] Fork Value is true
[java] Registered plugin detector [MutabilityDetector4FindBugs]
[java] The following errors occurred during analysis:
[java]   Exception analyzing nick.HistoryItem using detector org.mutabilitydetector.findbugs.MutabilityDetector4FindBugs
[java]     org.mutabilitydetector.checkers.MutabilityAnalysisException:
[java] An unhandled error occurred. Please read message at end of this output.
[java] Class being analysed: nick.HistoryItem
[java] Checker that failed: CanSubclassChecker
[java] Classes analysed so far:
[java] An unhandled error occurred. This is probably my fault, not yours, and I am sorry.
[java] I'd love to get an opportunity to fix this, please report as an issue at:
[java]  https://github.com/MutabilityDetector/MutabilityDetector/issues/
[java] Pasting in this error message and stack trace, and if possible,
[java] information about the code causing the error.
[java] For example, one of:
[java]     .class files (preferably with source);
[java]     compilable .java files;
[java]     a jar (again preferably with source);
[java]     or, if your project is open source, information on where I can get the code from
[java]         (I'm happy to checkout and build your project in order to investigate the error).
[java] Apologies, and thank you for using Mutability Detector.
[java]       At org.mutabilitydetector.checkers.UnhandledExceptionBuilder.unhandledException(UnhandledExceptionBuilder.java:54)
[java]       At org.mutabilitydetector.checkers.CheckerRunner.attemptRecovery(CheckerRunner.java:79)
[java]       At org.mutabilitydetector.checkers.CheckerRunner.run(CheckerRunner.java:66)
[java]       At org.mutabilitydetector.checkers.AllChecksRunner.runCheckers(AllChecksRunner.java:65)
[java]       At org.mutabilitydetector.ThreadUnsafeAnalysisSession.requestAnalysis(ThreadUnsafeAnalysisSession.java:118)
[java]       At org.mutabilitydetector.ThreadUnsafeAnalysisSession.resultFor(ThreadUnsafeAnalysisSession.java:104)
[java]       At org.mutabilitydetector.findbugs.IncorrectlyAppliedImmutableAnnotationDetector.doMutabilityAnalysis(IncorrectlyAppliedImmutableAnnotationDetector.java:72)
[java]       At org.mutabilitydetector.findbugs.IncorrectlyAppliedImmutableAnnotationDetector.visitClassContext(IncorrectlyAppliedImmutableAnnotationDetector.java:66)
[java]       At org.mutabilitydetector.findbugs.MutabilityDetector4FindBugs.visitClassContext(MutabilityDetector4FindBugs.java:47)
[java]       At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
[java]       At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1089)
[java]       At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:283)
[java]       At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
[java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
[INFO] Done FindBugs Analysis....
===============================================================
CODE: Class under analysis
package nick;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import jdk.nashorn.internal.ir.annotations.Immutable;
@SuppressWarnings("checkstyle:designforextension")
@SuppressFBWarnings
@Immutable
public class HistoryItem {
private final int id;
private int amount;
private final String operation;
private final int total;

HistoryItem(final int id, final int amount, final String operation, final int total) {
    this.id = id;
    this.amount = amount;
    this.operation = operation;
    this.total = total;

}

public int getId() {
    return id;
}

public int getAmount() {
    return amount;
}

public void setAmount(final int amount) {
    this.amount = amount;
}

public String getOperation() {
    return operation;
}

public int getTotal() {
    return total;
}

}
==============================================
Upon further review, I found that the exception being thrown was a result of my
using the wrong annotation. I tried using "import javax.annotation.concurrent.Immutable" but that failed too with the same exception. I then tried "import net.jcip.annotations.Immutable" which allowed the detector to run without error - but it didn't catch the fact that the HistoryItem class is not immutable, it has a setAmount() method.

Hey @nickantzoulis, thanks for taking the time to report.
Unfortunately it looks like the stack trace you have access to has just about everything except the interesting bit :( with all the wrapping of exceptions to try to be helpful, it looks to have lost the origin of the exception.
However, looking at the most recent version of the FindBugs plugin, I'm not surprised there are issues. I'm going to do a quick release that brings versions of things up to date, it could be something as irritating as a bytecode incompatibility that an update would fix.
I'll update when a new release is available, and see if that happens to fix it. If not, I may need a bit more help to reproduce (version numbers, more stack trace if available, etc).

Version 0.9.3 of the FindBugs plugin should be winging it's way to Maven Central. If you get a chance could you give that a try and get back to me?

Will do. Which version of the '@Immutable' annotation should I be using?

It should work with any annotation called "Immutable", the package doesn't
matter. See the logic for that here:
https://github.com/MutabilityDetector/MutabilityDetector4FindBugs/blob/fc29a7a39e054f1d58c8079fa6e06beae06f53be/src/main/java/org/mutabilitydetector/findbugs/IncorrectlyAppliedImmutableAnnotationDetector.java#L57
Although, it seems a bit sensitive to the casing. Does the annotation
you're using actually start with a lowercase 'i'? I don't think the plugin
needs to be specific about that so maybe that could be an enhancement to
work on. Though I don't expect that would account for the runtime exception.
On Mon, 25 Jun 2018, 23:54 nickantzoulis<EMAIL_ADDRESS>wrote:

Will do. Which version of the '@immutable https://github.com/immutable'
annotation should I be using?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MutabilityDetector/MutabilityDetector/issues/115#issuecomment-400121132,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcLq0Gn4veauMB8e7HHloE9elxwW0Kdks5uAWoTgaJpZM4Ui7Yd
.

No, not using lowercase 'i'. The comment editor changed the case on me on submit:) Haven't had a chance to check the fix yet, but its on my list.


Reinstate computing and assessing Elixir test coverage

Backstory
Way back in the day much of CTD used CodeCov and got coverage reports there. But they weren't very reliable, often returning wonky/incorrect results, so we weren't too enamored with it.
Then we migrated all of our projects to use Github Actions, during which we overwhelmingly adopted lcov_ex to generate coverage information, incorporating into our workflows and using our own fork of a Github action, github-actions-report-lcov, to report coverage using this data.
All well and good for most, but it never computed coverage for Dotcom, and after some frustration we disabled the coverage check and moved on with our lives.
Until now...
The diagnosis
It turns out that the prior workflow didn't work as expected on Elixir umbrella projects. It would generate coverage for each app individually, and its output contained a mix of relative and absolute links to source files. Later on, resolving the relative links would cause the action to try to parse incorrect source files, leading to failure.
The fix
I decided to go back to the coverage tool we were using before, ExCoveralls, and instead of reporting it to CodeCov, we'll save the output as an artifact here in GitHub.
The only caveat is there's no obvious way to generate a PR comment with more detailed coverage information -- I'm leaving that as an exercise for another day.
What will happen in PRs

The tests will run as normal, but will also will fail CI if the Elixir test coverage is found to be below 90%. That will look something like this (example from my fork here):

A .zip file containing the output HTML coverage report is added as an artifact to the workflow run, see bottom of screenshot:

Will that .zip file be a human-readable HTML report like we used to get with coveralls -html? For less savvy users like me, I'll need a clear idea of which files->lines were missed.

@amaisano yep! it's a big HTML report that looks like this

To your second question, yes! You'd be able to run the same command (CI uses a variation on mix coveralls.html) and produce the HTML output locally.

Rebased / resolved some conflicts. bump @bfauble


Imagine not working when midjourney responds with "(Open on website for full quality)"

Sometimes midjourney response with prompt - @user (Open on website for full quality) (fast) as the final message when the image is ready.
In such cases, the Imagine API is returning no response. Can a timeout be configured at least so that I don't wait endlessly?

@zcpua After further looking into this, it seems like when you set a higher quality value for your image, sometimes Midjourney does what I explained above. From what I could see, what happens in such cases is that the image returned is not a png, but a webp. You can adjust the logic over here https://github.com/erictik/midjourney-api/blob/876e689137d60ee498511ead204bbf304ba84042/src/midjourney.message.ts#LL49C8-L71C8 to take into account this custom text (Open on website for full quality) as you only receive this when the image is done processing.


Feature request: dithered ppi

I've been experimenting with different settings and noticed at some speed/ppi combinations a repeating pattern is visible. Would it be possible to add a dithering option to the ppi settings so that any resultant patterns are less noticeable?

Hm. I tended to add more patterning with dot length etc, so you could do more interesting ppi patterns, and cut dashed lines etc. I guess it would be possible to avoid patterning by reframing how ppi works. It adds the ppi value to a counter, then if above 1000 fires the laser for that dot. So at 100 ppi it will always fire a laser exactly every 10th step. It would be possible to instead randomize the PPI so that rather than add ppi, it simply has a ppi/1000 chance of firing the laser. At small enough scales it would seem quite likely to avoid any inadvertent patterning caused by the highly deterministic nature of how ppi works.

Random might work, but what about some sort of Floyd-Steinberg error diffusion? That should remove any chance of patterning.

While Floyd-Steinberg works it's built around the idea of dithering a 2d image. This is certainly a step with any raster preprocessing event. And it has a pretty good ability to avoid artifacting with fairly minimal amounts of work, though there are better ones out there. For PPI it doesn't have this sort of look-ahead within Eulerian space. PPI just knows there's an official on-off laser signal and makes a carry ahead patterning. In effect, it's dithering in 1 dimension. And for some things like drawing a rectangle outline that's the only method of dithering that is available. It seems like carry ahead with a degree of randomness would also be quite possible where I could tweak the math to adjust the amount of random pattern breaking involved but the dithering would need to be 1d plot processing adjusting the on/off values sent to the beam.

Sounds good.


Move image definitions to subcharts

Description
Changes proposed in this pull request:

the docker images should not be defined in the main values.yaml

Reasons:

less spams from Github where someone creates a PR

/retest

/retest

/retest

/retest

/retest

/retest

/test  pre-main-control-plane-gke-provisioner-integration

https://github.com/kyma-project/control-plane/pull/2218

/test pre-main-control-plane-reconciler-e2e
/test pre-main-control-plane-reconciler-e2e-latest-release
/test pre-main-control-plane-reconciler-upgrade-kyma2-latest-to-main-gardener


Replace CRI-O incubator links.

Update CRI-O links from Kubernetes incubator to the official CRI-O
homepage. Most links were already updated, but there were a few
stragglers in minikube documentation and old blog posts.

/approve


Drop weighty dependencies to keep subsequent libraries light

Currently, the bulk of the dependencies come from the various lock file api's. They amount to nothing but two kinds of things:

finding the right lock file with a find-up style convention
parsing yaml
stuffing the info obtained into a in-memory collection

I believe we can achieve these with much fewer dependencies so this library isn't so heavy

#41 alleviates the problem here, but we still don't really use lockfile implementations much other than just reading the yaml file. We honestly should be doing it ourselves with no deps to make it a faster installation process

git-url-parse contributes a substantial set of deps too. It's only used by getRepositoryName (used by getDefaultRemote and getDefaultRemoteBranch), so possibly we could put those utilities in a separate package. Or replace git-url-parse with a custom URL parsing implementation that only extracts the org, owner, and repo since that's all we care about, and we already have to do some custom parsing to work around bugs in git-url-parse.


Feature/post-release

removed postinstall hook from scripts to fix package install failure.
removed skipping of integration tests and linting
removed travis in favor of github actions
updated README badges to reflect
linting the project are the cause of most of the changes in this PR
added override rule to unicorn/prevent-abbreviations because it incorrectly made suggestions and would have add 150+ changes along with avoidParens in .prettierrc

Not sure about the release github action workflow, @nellyk could use your advice on this please

Much of the diff is linting fixes and not any functionality change. Right?

@mtomcal Correct, no functionality change only formatting.


[ozone] Fix edge case when volume name start with service_id in path

What changes were proposed in this pull request?

Improve path traversal by checking for cases when volume name can be similar to service_id.
Also handle an edge case explicitly, when volume name is equal to service_id in which we introduced a flag to explicitly add ofs://<service_id> for such paths at all directory levels.

How was this patch tested?

Manually
Unit tests

Will add unit test in sometime.

Unit tests added


Remove dead code from couch_file

This code was left over after removing 8kB read-ahead
https://github.com/apache/couchdb-couch/pull/223/commits/d52a5335d930d11ade4953c8576d22f55872ff6f
COUCHDB-3284

+1


Add react/stream 0.7 to dependency list

Seems to cause no issues here either.
Signed-off-by: Yoshi2889<EMAIL_ADDRESS>

Nice! Thanks for filing this PR! :shipit: