docs: add link to ceremony video on twitch.tv

Don't I need a verified account to do this?

@wilsonmar you need to sign the commit, can you do that?
git commit --amend --no-edit --signoff

There's no content up at https://www.twitch.tv/videos/1060206516 for me.

@dlorenc @asraa Do either of y'all have the ceremony recorded? Otherwise, we should probably close this. We also didn't record the v3 signing - did we want to record v4?

https://www.youtube.com/watch?v=GEuFsc8Zm9U

https://www.youtube.com/watch?v=GEuFsc8Zm9U

Look at that handsome guy in the end

Closing, made a new PR with the youtube link


add get_config() to SeedGenerator

KerasCV serialization tests were failing from
TypeError: Cannot serialize object <keras.src.random.seed_generator.SeedGenerator object at 0x7fe3582b5610> of type <class 'keras.src.random.seed_generator.SeedGenerator'>. To be serializable, a class must implement the get_config() method.

https://github.com/keras-team/keras-cv/actions/runs/7175074758/job/19537736102?pr=2232

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e237f08) 78.81% compared to head (dcd7325) 55.96%.
Report is 262 commits behind head on master.

Files
Patch %
Lines

keras/random/seed_generator.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18933       +/-   ##
===========================================
- Coverage   78.81%   55.96%   -22.86%
===========================================
  Files         336      336
  Lines       33591    34976     +1385
  Branches     6579     6863      +284
===========================================
- Hits        26476    19575     -6901
- Misses       5540    13933     +8393
+ Partials     1575     1468      -107

Flag
Coverage Δ

keras
55.96% <50.00%> (-22.75%)
:arrow_down:

keras-jax
?

keras-numpy
55.96% <50.00%> (-0.43%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Word Wrap feature not working correctly

Type: Bug
Make a simple text file with lorem ipsum verbiage and fill a paragraph. Turn on word wrap feature. Keep lines at 70 characters. Shorten the viewport to overflow the line character limit. Now pick any random line and place a few characters at the end of the line. If the line ends with a set of continuous characters (NOT carriage return, example a word or a stream of dots or dashes) the wrapping hides the left side of the viewport by a few pixels
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:03:37.738Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

@mkhlz Could you please share sample text and a screenshot demonstrating the problem? Have you tried editor.wrappingStrategy: "advanced"?

Hey! Sorry I should have put a screenshot. Some more context:
Here's the normal flow when you go to the next line after carriage return. The gutter and viewport looks as expected. All good no problems here.

But now let me end the line without the carriage return. In this case I'll simply add some period characters . to achieve that. Notice the gutter area gets jacked up after the caret goes to the next line.

Apologies for the lack of info. This should clear things up. Let me know if you need more info.
Also, let me check if the option you suggested works.
By the way, there is a workaround hack. Just fix the line width to be less than the viewport. And in the wrap settings, use wordWrapColumn or bounded but the like I said the original bug still exists

I can confirm that "editor.wrappingStrategy": "advanced" does not work @alexdima

closing this issue and making a new one, cuz of non-response

@mkhlz Does this reproduce when disabling the gitlens extension?

No, the issue is non-reproduceable after disabling the git lens extension. Although I really need that extension :(
In this case, how are things handled? By the extension developer, or VSCode? @alexdima

Let's track in https://github.com/microsoft/vscode/issues/32856


Make AttachContext transitive

Make AttachContext transitive, e.g. remember its previously attached context.
Fixes https://github.com/savsgio/atreugo/issues/67

Pull Request Test Coverage Report for Build 322

8 of 17 (47.06%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 98.539%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

context.go
8
17
47.06%

Totals

Change from base Build 320:
-1.5%

Covered Lines:
607

Relevant Lines:
616

💛  - Coveralls

Pull Request Test Coverage Report for Build 322

8 of 17 (47.06%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 98.539%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

context.go
8
17
47.06%

Totals

Change from base Build 320:
-1.5%

Covered Lines:
607

Relevant Lines:
616

💛  - Coveralls


Migrate to ESLint

ESLint is the new way to do linting. I basically followed the guidelines here:
https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration
It does most of work for you. However after migrating I had to fix up a bunch of stuff. Mostly the rules we apply. Almost all of the source changes are changing TS Lint disable comments to ES Lint disable comments.
After this change, you'll need this extension instead of the tslint one:
https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

Codecov Report

Merging #4397 (d89dd6f) into main (9e143e3) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4397   +/-   ##
=====================================
- Coverage     75%     75%   -1%
=====================================
  Files        392     392
  Lines      25627   25627
  Branches    3661    3661
=====================================
- Hits       19348   19344    -4
- Misses      4774    4779    +5
+ Partials    1505    1504    -1

Impacted Files
Coverage Δ

...nt/activation/migrateDataScienceSettingsService.ts
83% <ø> (ø)

src/client/activation/serviceRegistry.ts
100% <ø> (ø)

src/client/api.ts
58% <ø> (ø)

src/client/api/pythonApi.ts
64% <ø> (ø)

...lient/common/application/applicationEnvironment.ts
58% <ø> (ø)

src/client/common/application/applicationShell.ts
23% <ø> (ø)

src/client/common/application/commandManager.ts
63% <ø> (ø)

...c/client/common/application/customEditorService.ts
58% <ø> (ø)

src/client/common/application/debugService.ts
46% <ø> (ø)

src/client/common/application/documentManager.ts
60% <ø> (ø)

... and 197 more

Codecov Report

Merging #4397 (d89dd6f) into main (9e143e3) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4397   +/-   ##
=====================================
- Coverage     75%     75%   -1%
=====================================
  Files        392     392
  Lines      25627   25627
  Branches    3661    3661
=====================================
- Hits       19348   19344    -4
- Misses      4774    4779    +5
+ Partials    1505    1504    -1

Impacted Files
Coverage Δ

...nt/activation/migrateDataScienceSettingsService.ts
83% <ø> (ø)

src/client/activation/serviceRegistry.ts
100% <ø> (ø)

src/client/api.ts
58% <ø> (ø)

src/client/api/pythonApi.ts
64% <ø> (ø)

...lient/common/application/applicationEnvironment.ts
58% <ø> (ø)

src/client/common/application/applicationShell.ts
23% <ø> (ø)

src/client/common/application/commandManager.ts
63% <ø> (ø)

...c/client/common/application/customEditorService.ts
58% <ø> (ø)

src/client/common/application/debugService.ts
46% <ø> (ø)

src/client/common/application/documentManager.ts
60% <ø> (ø)

... and 197 more


Missing drawable for ?homeAsUpIndicator in XHDPI

Release 3.4.2
Hi,
I'm using the theme dependent drawable for the home-as-up-indicator in that way:
<ImageButton
        ....
        android:src="?homeAsUpIndicator" />

Running this on Galaxy Nexus leads to a crash due to a missing resource.
Stack trace from Android 4 emulator:
12-17 09:08:59.651: E/AndroidRuntime(972): Caused by: android.content.res.Resources$NotFoundException: Resource is not a Drawable (color or path): TypedValue{t=0x2/d=0x7f01000d a=-1}
12-17 09:08:59.651: E/AndroidRuntime(972): 	at android.content.res.Resources.loadDrawable(Resources.java:1899)
12-17 09:08:59.651: E/AndroidRuntime(972): 	at android.content.res.TypedArray.getDrawable(TypedArray.java:601)
12-17 09:08:59.651: E/AndroidRuntime(972): 	at android.widget.ImageView.(ImageView.java:119)
12-17 09:08:59.651: E/AndroidRuntime(972): 	at android.widget.ImageButton.(ImageButton.java:85)
12-17 09:08:59.651: E/AndroidRuntime(972): 	at android.widget.ImageButton.(ImageButton.java:81)

When the app is running on Android 3.0+ it uses the native action bar and not the implementation from the library.

I understand. This means there is no homeAsUpIndicator for the native implementation?

I've tested about 15 apps using ActionBarSherlock on my Galaxy Nexus and they all work fine. Are you positive that the error is related to this library? What attribute does 0x7f01000d map to in your R.java? Can you provide a test project that produces this behavior?

Are you positive that the error is related to this library?
Yes. As I said, I tested on Android 4 emulator

What attribute does 0x7f01000d map to in your R.java?
From com.actionbarsherlock.R.
public static int homeAsUpIndicator=0x7f01000d;

It happened to me if I used the ImageButton from above in an arbitrary layout. If the layout is shown on devices which are using your implementation, everything works fine. But If I try this on native devices, I get the error. To be honest, I didn't tried on 3.x devices.
I worked around the problem by copying your abs__ic_ab_back_holo_dark.png file to my drawable folder.
I still use your Theme.Sherlock.Light theme as my parent theme on all platforms. Is it possible that the attribute "homeAsUpIndicator" is not defined on native platforms?

It is a custom attribute defined in the library. It will always be present because it gets put in your apps R.java and thus is present no matter what platform you are running it on.
Things like this are usually a result of having different versions of ADT and the ADT Eclipse Plugin. If you can create a reproducible test case I'd be happy to take a look.


Unmount fails

At the end of installation, unmounting fail.
https://github.com/suikan4github/kaiten-yaki/blob/40264ce02f6ebbe965990b8dd11ae18ac1451613/script/lib/common.sh#L320
This is negligible. But the warning message makes users uncomfortable.
It should be fixed or unmount command have to be removed.

merged to develop
Ready to release.


Display short field when running tasks

This is a feature request. Not sure this is an actual use case.

The fact that Orbit does not show any information about the tasks it runs is a bit confusing. I had to recode some artificial debug info to make that more easy:
{{- $title := printf "Render and deploy app for %s to %s on %s" $.Orbit.Values.app.name $deploy.k8s_cluster $deploy.aws_account}}
  - use: {{ $stage }}
    short: {{ $title}}
    run:
      - echo "{{ $title }}"

The alternative is to run Orbit -d but this is very verbose!
I wanted to know if it could be possible:

either have a -i (like info) flag that would display this information
or inject an env variable so that the run code can access this information
or always print this information

Let me know what you think of this...

+1 on this!
I would also like something like to see the following behaviour:

print task names by default. Add a -q/--quiet to remove those
Add a -v/--verbose option that would print the actual commands that are being run. This would serve as an alternative to -d which is too verbose for regular end-users.


[REFACTOR][UI] Extract common code to utils or components

Is your improvement request related to a feature? Please describe
After discussed with @derekbit, there are too many UI components or functions are copied and paste.
The codebase needs some refactoring to extract the same logic in the independent UI components or utils functions
Describe the solution you'd like
Describe alternatives you've considered
Additional context

cc @longhorn/dev @innobead


added Returns and Raises for Reshape class

Updated Reshape class with Returns and Raises
Here is a gist to show the Value_error.

@jvishnuvardhan  Can you please check @mihaimaruseac's comments and keep us posted ? Thanks!

@jvishnuvardhan  Any update on this PR? Please. Thanks!


Problems with installing https://github.com/sigstore/cosign/releases/tag/v1.6.0

Description

Hi, This afternoon I was trying to install cosign with the following command:
go install github.com/sigstore/cosign/cmd/cosign@latest

And I'm seeing this error:
go: downloading github.com/sigstore/cosign v1.6.0
go install: github.com/sigstore/cosign/cmd/cosign@latest (in github.com/sigstore/cosign@v1.6.0):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

It looks like the replace directive was recently introduced in this PR. I'm not entirely sure what can be done to fix the issue for @latest but for now we're installing with a pinned version.
I'm hoping that can be fixed in a future release.
cc @mattmoor in case there is a plan to change that.

Yep, this is the reason, the plans are remove those replacement asap

Hello there
any update?
I had the same error when I tried to install cosign from a docker image or aws buildspec
go version
go version go1.17.8 linux/amd64

go install<EMAIL_ADDRESS>
go: downloading github.com/sigstore/cosign v1.6.0
go install<EMAIL_ADDRESS>module<EMAIL_ADDRESS>found, but does not contain package github.com/sigstore/cosign

go install github.com/sigstore/cosign/cmd/cosign@latest
go install: github.com/sigstore/cosign/cmd/cosign@latest (in github.com/sigstore/cosign@v1.6.0):
        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

I also tried to install an older cosign version
go install<EMAIL_ADDRESS>go: downloading github.com/sigstore/cosign v1.5.2

go install<EMAIL_ADDRESS>module<EMAIL_ADDRESS>found, but does not contain package github.com/sigstore/cosign

Latest version that works using go install is v1.5.2.
go install<EMAIL_ADDRESS>go install<EMAIL_ADDRESS>…

The problem is caused by https://github.com/sigstore/cosign/blob/main/go.mod#L314-L318
Hopefully there is soon a fix for this.

go 1.18 workspaces may help to moveing  replace to go.work


Mixcloud-Bridge seems to have stopped working

Hi folks,
not sure when this actually started, but it must have worked up until August 12th at least.
I'm on commit 77657a9
When I'm now fetching a mixcloud user's feed via rss-bridge, I get the following:
<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:thr="http://purl.org/syndication/thread/1.0">

	<title type="text">MixCloud - SamJahFrequency</title>
	<id>https://my.host.name/</id>
	<icon>http://icons.better-idea.org/icon?url=https://mixcloud.com/&size=64</icon>
	<logo>http://icons.better-idea.org/icon?url=https://mixcloud.com/&size=64</logo>
	<updated>2017-09-25T13:44:57+00:00</updated>
	<link rel="alternate" type="text/html" href="https://mixcloud.com/" />
	<link rel="self" href="https://my.host.name/rss-bridge/?action=display&bridge=MixCloud&u=SamJahFrequency&format=Atom" />

</feed>

Any further information I can provide? :)
Cheers
Thomas

Did a bit of debugging and it seems that Mixcloud is now also blocking based on the User-Agent header m( ... I created a PR to "fix" this: https://github.com/RSS-Bridge/rss-bridge/pull/602
Cheers
Thomas


PS-1773 abs file manifests

There may be a touch up or two needed if the tests fail, but I think it can generally be reviewed now.  I'll make some inline comments for some of the changes.
@JakubMatejka I added you in case you were interested

@odinuv updated re: ur comments.  shall I merge it?

yes please :)


DF-801-Prototype/author pages merged

Ticket URL:https://national-archives.atlassian.net/browse/DF-801
About these changes
This is a merged branch of the BE and FE worrk around the Authors section
How to check these changes
Create and Authors page and a child page of an individual Author, publish and check layouts across viewports.
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[x] Waited for all CI jobs to pass before requesting a review.
[x] Added/updated tests and documentation where relevant.

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

@ahosgood and @jamesbiggs I've setup a meeting today 14:30pm for a quick chat if you have questions for myself or Lauren on the Author Profile Page. I'd like to get this up on Develop for testing

Replaced by https://github.com/nationalarchives/ds-wagtail/pull/1373


pollPod add handle inactive pod.ignore inactive pod.

Kubernetes will not force delete pods and change pod's status.phase, if node unready or lost, the
status.phase still Running, but set deletionTimestamp.
If deletionTimestamp set we think the pods not Running.
[skip ci]

If deletionTimestamp is not nil, the pod will normally be deleted soon. It's by design that we won't remove membership until pod is entirely deleted from API.
The problem you described is that node is lost. If this happens, it needs external manual or automatic process to remove the dead node and add a new one.

i am closing this now. deletion timestamp is designed for graceful shutdown. when it is set, the pod will be deleted soon anyway. this seems like an optimization that we do not need.


Clarification:  Collaborate document across app users

In a web environment, we share documents, presentations (say using Google Docs, Google Sheet).The above assumes that all users are authenticated using Google OAuth2
How do we mimic the same in react native application. Note: Here user shouldn't have gmail account

Need to know how the documents are collabrate in mobile app


The script wont start.

Hey, i am currently on version 23.2.1.
i started the game with the command starrail start
the game startet but now i dont know what to do do start a script.
I dont see any overlay(I know its in dev. right now but in the setup thread i didnt find any commands or guides how i can use it.
https://imgur.com/a/IzCvqRE

Is the problem solved?

Sadly not, there was no update since 3 months.

Sorry for the late reply. The project has been completely revamped with most of the features modified/changed. See the updated README  for more details.


Django 1.9 not support url data

This error occurs when I add: url(r'^tinymce/', include('tinymce.urls')) to urls.py (urlpatterns).
urlpatterns = [
    url(r'^admin/', admin.site.urls),
    url(r'^$', views.home, name='home'),
    url(r'^tinymce/', include('tinymce.urls')),
]

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:10: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got textareas_js). Pass the callable instead.
  url(r'^js/textareas/(?P<name>.+)/$', 'textareas_js', name='tinymce-js'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:11: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got textareas_js). Pass the callable instead.
  url(r'^js/textareas/(?P<name>.+)/(?P<lang>.*)$', 'textareas_js', name='tinymce-js-lang'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:12: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got spell_check). Pass the callable instead.
  url(r'^spellchecker/$', 'spell_check'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:13: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got flatpages_link_list). Pass the callable instead.
  url(r'^flatpages_link_list/$', 'flatpages_link_list'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:14: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got compressor). Pass the callable instead.
  url(r'^compressor/$', 'compressor', name='tinymce-compressor'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:15: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got filebrowser). Pass the callable instead.
  url(r'^filebrowser/$', 'filebrowser', name='tinymce-filebrowser'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:16: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got preview). Pass the callable instead.
  url(r'^preview/(?P<name>.+)/$', 'preview', name='tinymce-preview'),

/usr/local/lib/python3.4/site-packages/tinymce/urls.py:16: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  url(r'^preview/(?P<name>.+)/$', 'preview', name='tinymce-preview'),

+1

+1

Feel free to file a PR to fix this I will look at it afterwards.

@Natim made a pull request to master : #148 . I hope it was the right branch to do so. Please tell me if otherwise

Released with in django-tinymce 2.1.0


Regression: Async validation failing causes Uncaught promise error (6.6.1)

Are you submitting a bug report or a feature request?

bug report
What is the current behavior?

Yes. In 6.6.1
To reproduce:

Go to

http://redux-form.com/6.6.1/examples/asyncValidation/

Submit

Inspect the Dev tools

It is actually a regression of https://github.com/erikras/redux-form/issues/1297 which is already closed.
What is the expected behavior?
No uncaught exception
What's your environment?

"redux": "3.6.0"
Other informations

+1 same happening here

+1

I'm going to close this as a duplicate of #1297 and re-open that issue.


Remove conf.N setting

This resulted from a discussion in #89.
The idea is that the user don't have to specify the desired impulse response link with conf.N, but that the Toolbox automatically decides what is the best length.
This would be beneficial, especially for new users. The only downside I see at the moment is that the resulting impulse responses could be very long if the original data from the SOFA file is long.

@VeraE: I have updated ir_correct_distance() and removed conf.N there. Could you have a look if this is still ok, please.

I started working on removing conf.N from the time-domain driving functions. For WFS it should work now.
@VeraE, @fietew: for wfs_preequalization() and driving_function_imp_nfchoa() I'm not sure how to do it.
1.) For driving_function_imp_nfchoa() the size is specified at line 88 and it will not work if there are no zeros padded at the end. But I don't know how to calculate how many zeros we need.
2.) For wfs_preequalization() zeros are added at line 83 for IIR filtering, is this needed and how we can replace it?
@fietew: could you have a look at driving_function_imp_localwfs() and driving_function_imp_wfs_vss() and see if you can replace conf.N there in a similar way I have done it for driving_function_imp_wfs()?

I did some updates on ir_correct_distance().
Now there remains the problem that in ir_generic() the impulse responses that are delivered by get_ir() could have different lengths but should be saved in one array. At the moment the impulse responses are first convoluted and then truncated to conf.N, so calculations finish succesfully. Getting rid of the conf.N restriction here would mean to either pre-calculate the maximum delay or adapt the size of the array in every loop over x0.  I fear both options would increase computation time. Which do you think we should try first?

Mh, too bad, this does not sound like there is an easy solution.
I'm a little bit afraid of your second approach and changing sizes inside a loop is normally a bad idea in Matlab. The first one would require something very similar to #67, which also would require a pre-scanning of the needed impulse responses. So far I was not very motivated to do this as I was afraid that the code of ir_generic() would not be easy to understand afterwards.
Do you still think it is worse trying to remove conf.N also from ir_generic()?
In my opinion it would be ok, to only use it there (and maybe rename it). In this way we would also maintain the nice possibility of shortening the impulse response in ir_generic().

You are right both approaches are not a good idea.
To me it doesn't make sense to only remove conf.N in some parts of the calculation, though. As long as there is one step where impulse responses are shortened the user has to know before how to set conf.N sensibly. I was hoping we could come up with a solution that would not make the code much more complicated or slower. Unfortunately, I couldn't think of a better way to implement this so far. So maybe, we have to drop this completely?

For the impulse responses part we could still think about if it is a good idea to not include it into get_ir() and ir_correct_distance() or if we should stay with the old approach. For me both would be fine. At the current master version get_ir() returns already a length of conf.N (only for the HRIR case, for BRIR we have to modify it).
But I'm still very interested in getting rid of conf.N from all the time-domain driving functions. There should be no need for the user to specify it there.

Fiete has just helped me to fix this branch as I managed to mess up the three commits you did before my merge.
So your idea would be to have truncating to conf.N at a higher level in the code? We can do that. So I'd leave ir_correct_distance() as it now in this branch and have a look at the commits done by you for the driving functions.

Time-domain driving function for WFS looks fine. I just got one question: why is the impulse response zero-padded by delay_offset as well in line 140 of driving_function_imp_wfs()? I'd think this is unnecessary but maybe I am missing something here...?
The WFS IIR pre-equalization does not work properly without the zero-padding as the Matlab function sosfilt() in wfs_prequalization() is returning a signal with the same length as its input signal (which is 1 when called from driving_function_imp_wfs()). We would have to specify a new parameter here if conf.N is not used, I fear.
I had a look at driving_function_imp_nfchoa() too, but have no idea how to precalculate the zeros either at the moment. I've never used this function extensively.

With the delay_offset you are probably right. I was not sure, so I have been gone for the safe choice.
As it also seems complicated to remove conf.N from the driving functions, we maybe give up on it altogether. I will wait for @fietew opinion.

@VeraE, @fietew: for wfs_preequalization() and driving_function_imp_nfchoa() I'm not sure how to do it.
1.) For driving_function_imp_nfchoa() the size is specified at line 88 and it will not work if there are no zeros padded at the end. But I don't know how to calculate how many zeros we need.
2.) For wfs_preequalization() zeros are added at line 83 for IIR filtering, is this needed and how we can replace it?

It's an IIR-Filter. You theoretically need an infinite number of zeros. Maybe we could truncate the impulse responses if the power/amplitude of the last coefficient is below a given threshold.

@fietew: could you have a look at driving_function_imp_localwfs() and driving_function_imp_wfs_vss() and see if you can replace conf.N there in a similar way I have done it for driving_function_imp_wfs()?

There is no driving_function_imp_wfs_vss(), btw. I think the current implementation does not take the delay offset caused by the fractional delay filter into account. I necessary, I could implement a function which returns just the delay of the chosen fractional delay method.

@fietew:
Here you can find driving_function_imp_wfs_vss().
At line 64 conf.N is used. And in driving_function_imp_localwfs() at line 84.
And do we have to account for the delay offset of the fractional delay filter for specifying the driving signal length? For the normal WFS case I'm considering now only the maximum delay without possible delay offsets.

I discussed with @trettberg and we somehow agreed, that keeping conf.N is a more consistent way than perhaps dealing with driving signal of different lengths. Imho this can be closed.

OK, I agree.


fix: added validation to the Community Newsletter form

Description
Added validation to the Community Newsletter form, the first name and last name should accept alphabetical input only.
This PR fixes #1974
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@aakankshabhende
Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). Add it as an agenda item to the meeting minutes, if you would :)

Yes, its still in draft, I'll send a fix for styling and minimum length requirement and make it ready to review.


[Google Bard] Add Gemini Pro?

Extension
https://www.raycast.com/EvanZhouDev/raycast-bard-ai
Description
We can now use the Google Gemini pro API for free, so it would be great to add support for it.
Who will benefit from this feature?
everyone don't wanna pay to use AI!
Anything else?
No response

+1

#9797

#9797 i created a PR for this

Thanks, but this PR is closed?

#9797 i created a PR for this

Thanks, but this PR is closed?

i make a mistakes, try the new one: #9798


refactor: Migrate to Spring Boot 3.3

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_3?organizationId=RklOT1M%3D

Is it possible to share common application.properties in a root? Same with gradle plugins, etc?

In general, it's possible, but there's still the open debate on whether this should behave like a true mono-repo or more of a simulation of separate/independently developed projects that need more weaving together.  So for the moment, this is by design, but we shoudl discuss changing it.


Fix failing tests

Locally tests were found to be failing after implementation of account types feature.

Fixed with dac063312631a685c9bce7e0e284dc5d080d42f3


Add more examples to Tensor type

I would like to see examples for every method in Tensor types.
That would be useful from people that came from PyTorch. Because Python language is highly dynamic and Rust is not, it's not easy to map PyTorch code to Rust with Burn

I would also be awesome if you could show how to use indexing, like there:
https://docs.rs/tch/latest/tch/index/index.html


Bump version to 2.7.0

coverage: 89.527%. remained the same
when pulling b1f331bda520922e7bad0fa25495cd369de4468a on jombr:bump-version-2.7.0
into 03dff108f8736970b37854f8b4eb542fc75dacca on djc:main.

Uploading distributions to https://upload.pypi.org/legacy/
Uploading rnc2rng-2.7.0-py3-none-any.whl
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 18.5/18.5 kB • 00:00 • 5.1 MB/s
Uploading rnc2rng-2.7.0.tar.gz
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 25.0/25.0 kB • 00:00 • 19.7 MB/s

View at:
https://pypi.org/project/rnc2rng/2.7.0/


Random coloring of lineage trees only for vizu enhancement

Hi,
this simple PR offers a menu command that allows a user to simply (and quickly) color every spot in the tracking data.
The user first chooses a TagSet to be used, or have a new TagSet created and then used. The plugin then takes Tags (colors) one by one, each color assigning to all spots within the same lineage tree, but switching colors between the trees.
The individual lineage trees are then visually enhanced, and that is the only purpose of this plugin.

As a side effect, this PR proposes to extend the TagSetUtils with three variants of rgbToValidColor() method. (I have originally forgotten about the alpha value and took me a little while to realize it... hope this helps for some next time.)
Questions (in case this PR should make it to this repo):

Where should this land in the Plugins menu? I failed to figure it out, and so ended up in the Plugin's root menu...
The plugin hosts a 16-colors palette, and we have already Glasbey class... new package with palettes? Some interface around them (consider on-the-fly generated palettes)?

(FYI: @tinevez)

Hi Vlado,
This is a nice feature! Normally I would make a color scheme based on the track index to create vizu that depends on the track of spots. But right now the color scheme we have interpolate between scarce color.
Another approach that would circumvent the need to create tags would be to see if we can retrofit a Glasbey LUT on the Colormap class:
https://github.com/mastodon-sc/mastodon/blob/dev/src/main/java/org/mastodon/ui/coloring/ColorMap.java
If the get(double) method could return one of the Glasbey color, it's a win.
https://github.com/mastodon-sc/mastodon/blob/dev/src/main/java/org/mastodon/ui/coloring/ColorMap.java#L210
Do you think it could be extended to do so?
If not we have to rely on the Tag-Set like you did.

I didn't know we can draw spots with different colors, I always thought the coloring is either following chosen TagSet or uses some one default color (albeit user-changeable via the preferences dialog)
I have to investigate, ATM I'm not 100% sure I understand all you're saying..
especially I feel I need to reverse engineer how/in_what_principle inputs to the get() are provided - but that's doable
conclusion: I'll try the get() path; and have an option-toggle in some menu (to allow user to keep the current standard or the per-tree colors)
thanks for the pointers!

(or if anyone knows already... go ahead please... I have busy weeks ahead of me, worried this thread will take forever)

I have the feeling @tinevez had in mind a similar in looking, yet different coloring principle.
While I was proposing a persistent, robust to changes (at least to track deletion) solution based on tagset, Jean-Yves probably meant an (optional feature of) online/on-the-fly coloring of spots and edges (when no tagset is selected/activated) during their drawing in the TrackScheme canvas and elsewhere.
If that is the case, I would then merge this PR and create an issue in the Mastodon main repo to decide how the on-the-fly solution could look like. What do you think @tinevez ?

(besides I could really use to have this ability to colorize lineage in the Mastodon-sciview Bridge project)

@stefanhahmann Thank you sincerely for your kind review of the code. I'll now react to the first question, the code-related suggestions I'll implement unf. later

This may be useful for some use cases.

My intention was really only to visually set apart the individual trees (from the full lineage) and avoid tagging them manually. There's nothing more behind it. And I wanted a permanent assignment -- when testing some analysis code, the coloring can help one to get back to what she was inspecting before (the data reload).

However, it is unclear to me, why in this dialog, the existing tag sets are shown:
I understand the 2 options on the bottom (creating tagsets with random colors), but the other options in this select box I do not understand how they would work. When testing, I could not see the effect of choosing existing tagsets, but maybe I was doing something wrong.

The plugin essentially combines two things. In order to color individual trees, one needs a palette (tagset in this case) first, and then processes the lineage. For the former, either one can use an existing tagset or create a new one -- and that's the purpose of the dialog, choose from an existing or create a new one.  So, unless there is a mistake in the code (can always happen), choosing an existing tagset should be assigning colors from it (in a round-robin fashion).

The plugin essentially combines two things. In order to color individual trees, one needs a palette (tagset in this case) first, and then processes the lineage. For the former, either one can use an existing tagset or create a new one -- and that's the purpose of the dialog, choose from an existing or create a new one. So, unless there is a mistake in the code (can always happen), choosing an existing tagset should be assigning colors from it (in a round-robin fashion).

I am still not sure, if I understand the intended behavior correctly. Cf. e.g. the following example. The trees are colored with using a tagset. Then I apply the function from the plugin. After that the trees are colored exactly the same. Is this the intended behavior in this case or am I using the plugin in an unintended way?

The trees are colored with using a tagset. Then I apply the function from the plugin. After that the trees are colored exactly the same. Is this the intended behavior in this case or am I using the plugin in an unintended way?

That was actually unintended behavior, but it's correct behavior given the state of the code :( The code is discovering the individual lineages (individual roots) in fact in deterministic order and it iteratively assigns colors to the lineages, so executing the code on the same lineage with the same tagset leads to exactly the same re-assignment, thus no visible change.
But you are right the plugin name misleads the user to expect something different -- maybe I could, besides the requested code changes, insert in deed a bit of randomness into the process -- e.g. start with random index in the tagset (not always from 0 like it is now). So that, for example, calling the plugin on the same tagset again and again would yield different assignments (from still the same pool of colors).
Maybe this should be an option of the plugin:

once user added more of the tracking and wants to "add the same color to the new spots",
other time the user is not happy with the assignment (e.g. two colors ended up closeby) and would like to give it another chance

(I'm afraid I'll fix/finish this thing only during the hackathon in Brno... hope it's okay)

The trees are colored with using a tagset. Then I apply the function from the plugin. After that the trees are colored exactly the same. Is this the intended behavior in this case or am I using the plugin in an unintended way?

That was actually unintended behavior, but it's correct behavior given the state of the code :( The code is discovering the individual lineages (individual roots) in fact in deterministic order and it iteratively assigns colors to the lineages, so executing the code on the same lineage with the same tagset leads to exactly the same re-assignment, thus no visible change.
But you are right the plugin name misleads the user to expect something different -- maybe I could, besides the requested code changes, insert in deed a bit of randomness into the process -- e.g. start with random index in the tagset (not always from 0 like it is now). So that, for example, calling the plugin on the same tagset again and again would yield different assignments (from still the same pool of colors).
Maybe this should be an option of the plugin:
* once user added more of the tracking and wants to "add the same color to the new spots" (which is to keep the assignment),

* other time the user is not happy with the assignment (e.g. two colors ended up closeby) and would like to give it another chance (which is to randomize the assignment)

(I'm afraid I'll fix/finish this thing only during the hackathon in Brno... hope it's okay)

Thanks for the clarification of the functionality of the plugin. The 2 suggested options sound useful to me. Regarding time schedule: I think there is no pressure.

Hello.
FYI I worked on a track coloring on-the-fly:
https://github.com/mastodon-sc/mastodon/pull/254

I'm aware of https://github.com/mastodon-sc/mastodon/pull/254 , yet I think these two could live side by side
the PR254 is on-the-fly coloring, while this one here is persistent assignment of tags. Visually for the moment they achieve the same thing but in the TagSet variant the user can adjust colors any time later and is also type of coloring information that mastodon-to-* tools can carry over
but this PR should use the code-base from the PR254, there seems to be a good stuff to reuse


Vagrant up fails because of the vagrant-berkshelf

Hi.
I've just tried to start a standalone vagrant-mesos.
I've installed all the software required:
$ aptitude versions chefdk vagrant virtualbox
Package chefdk:
i   0.5.1-1                                                                                100
Package vagrant:
i   1.4.3-1                                                                                trusty                                                                                500
Package virtualbox:
i   4.3.10-dfsg-1ubuntu4                                                                                trusty-updates                                                                        500

$ vagrant plugin list
vagrant-berkshelf (4.0.3)
vagrant-cachier (1.2.0)
vagrant-hosts (2.4.0)
vagrant-omnibus (1.4.1)

But the vagrant up command still fails
.../standalone$ vagrant up
Failed to load the "vagrant-berkshelf" plugin. View logs for more details.

Bringing machine 'default' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

vm:
* The box 'everpeace/mesos' could not be found.

Vagrant:
* Unknown configuration section 'berkshelf'.

I've upgraded vagrant to the latest version (1.7.2) and it worked well.
Seems that the ubuntu 14.04 officially distributed vagrant (1.4.3) is not supported by this repo.
Maybe should add a note about min version in the prerequisites?

Hi! Firstly, thank you for trying this project!

Maybe should add a note about min version in the prerequisites?

I explicitly wrote the prerequisites in README.md.

vagrant 1.6.5+: http://www.vagrantup.com/


Sorts with bar_chart renderer are incorrect

With a query along the lines of
explore 'malloy-303216.fluidstate.items'
| reduce
  category
  item_count is count()
  top_items is (reduce
    top 5
    item
    item_count is count()
  )

By default, top_items will be ordered by top_items.item_count, but the bar_chart renderer is instead ordering by category.

I believe this is a dup of https://github.com/looker-open-source/malloy/issues/446 @anikaks

Note that an explicit order_by is even ignored.

Fixed by https://github.com/looker-open-source/malloy/pull/546


Remove double dispatching from refresh stmt analysis

@matriv please review

Current coverage is 80.95% (diff: 100%)

Merging #4192 into master will decrease coverage by 0.09%

@@             master      #4192   diff @@
==========================================
  Files          1300       1300
  Lines         44294      44293     -1
  Methods           0          0
  Messages          0          0
  Branches       7056       7056
==========================================
- Hits          35901      35857    -44
- Misses         5747       5791    +44
+ Partials       2646       2645     -1

Powered by Codecov. Last update 7370954...83ac10c

Suberseded by https://github.com/crate/crate/pull/4194


support decorators

Are you submitting a bug report or a feature request?
feature request
What is the expected behavior?
just like react-final-form.

You can by doing this:
const { form } = useForm({ onSubmit });

decorator(form);

Or, regarding https://github.com/final-form/react-final-form/blob/v5.1.0/src/ReactFinalForm.js#L94, maybe more something like that:
useEffect(() => {
  const unsubscribe = calculator(form);
  return () => unsubscribe();
});

and perhaps we can use this useEffect only on mount
useEffect(() => {
  const unsubscribe = calculator(form);
  return () => unsubscribe();
}, []);

or maybe form
useEffect(() => {
  const unsubscribe = calculator(form);
  return () => unsubscribe();
}, [form]);


AttributeError: 'NoneType' object has no attribute 'image_mean'

in app.py file,  init meth setting model_name = "cambrian_qwen" and model_path = "./checkpoints/longvu_qwen"。  but README tell us to download models for LongVU_Qwen2_7B_img 、LongVU_Qwen2_7B  or LongVU_Llama3_2_3B_img  LongVU_Llama3_2_3B.
when  I setting one of those model_path :
    model_path = "./checkpoints/LongVU_Qwen2_7B"
    # model_path = "./checkpoints/LongVU_Qwen2_7B_img"
    # model_path = "./checkpoints/LongVU_Llama3_2_3B_img"
    # model_path = "./checkpoints/LongVU_Llama3_2_3B"

I found the model_name must be model_name = "cambrian_qwen" ， if not , it will caused exception :
AttributeError: 'NoneType' object has no attribute 'image_mean'
so:
what is the  relation for model_name = "cambrian_qwen" and model_path   and if I setting model_path = "./checkpoints/LongVU_Llama3_2_3B  then model_name  also is "cambrian_qwen" ?

Thanks for raising this question. Since our model built on top of Cambrian architecture and we decide which module to use based on the model name here.


Async-Support

Hi,
I added some basic support for async-operation.
Its in my fork. Feel free to pull it in here.
I'll test it a bit during development.
Greetings

Hi there, it is an interesting proposal. However, I think it should be provided as a different VS project, as I know there are other people using it in old .net, mono, compact framework, etc. Maybe it would be better to create an additional folder structure here in github.

I updated my fork to the latest version and dropped a few things (and fixed others):
Please see my pull request: https://github.com/jaime-olivares/zipstorer/pull/13


Support for mqtts and client certificates.

I've set up my broker to require client sertificates, which homebridge-mqtt does not support. I'm not too familiar with javascript, but made an attempt to add this support. (Also, I'm not familiar with github, so I don't have a proper patch.)
Making the change below to enable the new support:
diff model.js.orig model.js
4a5

var fs = require('fs');
43a45
options.port     = this.config.port || 1883;
47a50,58
if(this.config.cert != null) {
options.cert = fs.readFileSync(this.config.cert);
}
if(this.config.key != null) {
options.key = fs.readFileSync(this.config.key);
}
if(this.config.ca != null) {
options.ca = fs.readFileSync(this.config.ca);
}

This will add the following configuration options:
"platforms": [
    {
        "platform": "mqtt",
        "name": "mqtt",
        "url": "mqtts://mqtt.example.com",
        "port": 8883,
        "topic_prefix": "homebridge",
        "username": "username",
        "password": "password",
        "cert": "/path/to/certificate.pem",
        "key":  "/path/to/key.pem",
        "ca":   "/path/to/ca_certificate.pem"
    },

I've made some basic testing and it did not break anything in my setup. Hope this can be added so I don't have to maintain my own patch.
Frank

Seems like there is one issue, which I have not found a resolution for, but you might be able to understand this.
With the above patch, I can successfully connect to my broker using mqtts and client certificates. homebridge-mqtt publish several messages and subscribe to some topics. Then it disconnects and reconnects every few seconds. There's no extra output from homebridge, so it looks like the homebridge-mqtt is unaware that the client is disconnecting.
From the logs it looks like the client tries to connect a second time, which causes the disconnect.
I've tried both mosquitto v1.4.8 and mosquitto v1.4.11 with the same result.
1494113633: mosquitto version 1.4.11 (build date Mon, 20 Feb 2017 22:47:27 +0000) starting
1494113633: Config loaded from /etc/mosquitto/mosquitto.conf.
1494113633: Opening ipv4 listen socket on port 8883.
1494113633: Opening ipv6 listen socket on port 8883.
1494113634: New connection from <IP_ADDRESS> on port 8883.
1494113634: New client connected from <IP_ADDRESS> as mqttjs_470dec79 (c1, k60, u'username').
1494113634: Sending CONNACK to mqttjs_470dec79 (0, 0)
1494113634: Received SUBSCRIBE from mqttjs_470dec79
1494113634:     homebridge/to/# (QoS 0)
1494113634: mqttjs_470dec79 0 homebridge/to/#
1494113634: Sending SUBACK to mqttjs_470dec79
1494113634: Received SUBSCRIBE from mqttjs_470dec79
1494113634:     homebridge/to/# (QoS 0)
1494113634: mqttjs_470dec79 0 homebridge/to/#
1494113634: Sending SUBACK to mqttjs_470dec79
1494113634: Received SUBSCRIBE from mqttjs_470dec79
1494113634:     homebridge/to/# (QoS 0)
1494113634: mqttjs_470dec79 0 homebridge/to/#
1494113634: Sending SUBACK to mqttjs_470dec79
1494113634: Received SUBSCRIBE from mqttjs_470dec79
1494113634:     homebridge/to/# (QoS 0)
1494113634: mqttjs_470dec79 0 homebridge/to/#
1494113634: Sending SUBACK to mqttjs_470dec79
1494113634: Received SUBSCRIBE from mqttjs_470dec79
1494113634:     homebridge/to/# (QoS 0)
1494113634: mqttjs_470dec79 0 homebridge/to/#
1494113634: Sending SUBACK to mqttjs_470dec79
1494113634: Received PUBLISH from mqttjs_470dec79 (d0, q0, r0, m0, 'homebridge/from/connected', ... (30 bytes))
1494113634: New connection from <IP_ADDRESS> on port 8883.
1494113634: Sending CONNACK to <IP_ADDRESS> (0, 5)
1494113634: Socket error on client , disconnecting.
1494113635: New connection from <IP_ADDRESS> on port 8883.
1494113635: Sending CONNACK to <IP_ADDRESS> (0, 5)
1494113635: Socket error on client , disconnecting.

Doing some further debugging on my patch, I found that the disconnects happens because another python client is misbehaving. Disabling the python client makes everything work as expected.

And to close this from my side....
You need to pass the options when connecting anonymously as well, to enable certificates with anonymous connections. (This is probably very relevant as the username/password is likely to be dropped when you authenticate with certificates).
It looks like these lines could be simplified to allow this:
if(options.username === null || options.password === null) {
this.log("connect Anonymous");
client = mqtt.connect(url);
} else {
this.log("connect Authentication with username/password");
client = mqtt.connect(url, options);
}
Changing the above lines to:
this.log("connecting");
client = mqtt.connect(url, options);
Would work for both anonymous connections and when using username/password.


Partially add string methods

I have only added two functions -- len and byte.
Addition:
When I was trying adding more functions (not the len and byte function in this PR), I have encountered some issues about lifetime when using String::new, possibly due to my limitation of Rust knowledge.
[0] % cargo check
    Checking luster v0.1.0 (/mnt/working/Programming/Rust/luster)
error[E0477]: the type `[closure@src/stdlib/string.rs:12:41: 26:14 mc:&gc_arena::context::MutationContext<'gc, '_>]` does not fulfill the required lifetime
  --> src/stdlib/string.rs:12:13
   |
12 |             Callback::new_immediate(mc, |args| {
   |             ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: type must satisfy the static lifetime

error[E0621]: explicit lifetime required in the type of `mc`
  --> src/stdlib/string.rs:12:13
   |
5  | pub fn load_string<'gc>(mc: MutationContext<'gc, '_>, _: Root<'gc>, env: Table<'gc>) {
   |                             ------------------------ help: add explicit lifetime `'static` to the type of `mc`: `gc_arena::context::MutationContext<'gc, 'static>`
...
12 |             Callback::new_immediate(mc, |args| {
   |             ^^^^^^^^^^^^^^^^^^^^^^^ lifetime `'static` required

error: aborting due to 2 previous errors

Some errors occurred: E0477, E0621.
For more information about an error, try `rustc --explain E0477`.
error: Could not compile `luster`.

To learn more, run the command again with --verbose.

Do you have a gist of the code that errors?


Translation not loading, normal behavior?

I can clearly see the translations in the resource folder but for some reason, they are not loaded when a language is added to the platform or used on the website. Is this normal or is something wrong on my end?
Thank you for your time

Fixed for 1.2.16, will release soon


Remove temporary/uncomplete data when timedout to avoid unstable contribution resumes

Description
Suddenly interrupting a contribution due to a timeout results in the possibility of having incomplete or temporary information saved in the Firestore database. Consequently, a clean-up action must be contemplated when a timeout is triggered.

Done https://github.com/privacy-scaling-explorations/groth-p0tion/issues/3


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
[ ] Write a short description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @ForeignGods, wanted to send a small nudge and ask if you had any questions!

@ForeignGods, wondering if there's any way we can support you on this PR!


fix bug when leader lost swan crash

Current coverage is 45.05% (diff: 0.00%)

Merging #195 into master will increase coverage by 0.81%

@@             master       #195   diff @@
==========================================
  Files            11         11
  Lines          8917       8922     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3945       4020    +75
+ Misses         3936       3851    -85
- Partials       1036       1051    +15

Powered by Codecov. Last update 1e3139e...2c9bfad

LGTM


Question - globals,  contexts & threading

I'm trying to understand the capability of ChakraCore in regards to multi-threaded environment with multiple run times and multiple contexts.
We are currently using an older version of Spidermonkey which gives us full control of global objects and can have multiple threads access objects at the same time.
I know this is not possible with ChakraCore.  However, I need to understand how & why the global object seems to be tied directly to context.    It seems to only way to access the global is to call JsGetGlobalObject(). i.e. There is no JsSetGlobalObject() to allow you to set your own.
One of my use cases is a javascript enabled web server.  There is a pool of runtimes and a pool of contexts and a map containing pre-compiled scripts that we use on the contexts for execution speed.
We also need to maintain session state and keep a "Session Global" around between trips to the web server so that all objects and properties exist on the next trip back to the web server.
Assuming i need a context for each session with the web server (since the global is tied to this) how many can I have in my pool at a time?  Is a 1000 too many? How lightweight are contexts?
What are the recommendations here regarding context and runtime pools? I was thinking of starting with 5 runtimes.
Where are the standard classes stored?  Is this on the global?  or someplace else?
We want the standard classes to already exist on the global on the next trip back to the web server to make it as fast as possible.
Is it possible to have a resolver hook so we can lazy load objects into global as needed?
If a session is invalidated we would like to be able to clear the global object while preserving standard classes.  Similar to JS_ClearScope() in Spidermonkey.
Lastly, we need need to be able to suspend running a script (similar to JS_SuspendRequest in spidermoney) which we run another backround script on a different context in the same thread and wait for the return before resuming execution of the mainline script.
Spidermonkey has been great, but it has no future for advanced use cases.
Thanks!
Mike

Hi Mike thanks for the questions.
As a first point, please note that chakracore is currently in the process of transitioning from being maintained by microsoft to being managed by a group of community volunteers - whilst I'd like to encourage you to use chakracore I don't want to do so under false pretences. Please see the documents and discussion in this PR for details of that: https://github.com/microsoft/ChakraCore/pull/6399
That aside onto your specific questions:

Currently a global object is created and initialised as part of creating a context - the contents of the global object is the bulk of the context.

We could in theory create an api for transferring a global object between contexts OR more efficiently, for creating a new context with access to the global object from a different context - I'd have to put some thought into exactly how it would work and how to avoid any serious errors/internal pitfalls. At the moment you can transfer data by reading properties off of the global object for one context and then providing that data to another context.

I'm not entirely sure if you'd need a context for every session with your webserver - it would depend exactly what you're storing on the global; as for how many you can have - I don't know, I've not tried these sort of use case however I can comment that I've seen prior discussion of such cases and no specific limits being noted - the memory use of an individual context is not high. Personal action: research this further and add some of this sort of information should be added to our documentation.

With runtimes again there are no specific limits, you need one for each simultaneous thread of Javascript execution you want. Personal action: create a multi-threaded CC demo to show how this works

The standard classes are all stored on the global, however most of them are lazily initialised, when a context (and global) are created the standard classes are set up on that global as objects that will trigger their own initialisation when accessed.

By a resolver hook do you mean the equivalent of a JS getter that overwrites itself with some loaded data when first accessed? This is certainly possible.

Currently there is no way to clear the Global object without clearing the standard classes - as the standard classes are all properties of the global

To suspend a running script there are two methods I'm aware of:
a) have it wait on a promise that you resolve when it's ready to continue OR
b) use JsDisableRuntimeExecution - however you may then need to run your other script in a different runtime - you can potentially shunt runtimes between threads to do this.

As an extra point I think it's worth asking what Spidermonkey doesn't do for you that you're hoping chakracore will do?

Thanks for your reply.
Spidermonkey is a dead project for these kind of uses.  Mozilla doesn't care about its embedders (only the browser) and is constantly breaking their API.  More recent builds have become impossible to use for multi-threaded users.  ChakraCore seems to have a much more a stable API.  Opening this to the community will likely draw other users to it like me who are having he same frustrations with other engines like V8 and Spidermoney.  I've used both engines extensively.  ChakraCore seems refreshingly simple in comparison to V8.  Both have broken their API's so much I cannot even count.
Based on your responses above it seems to me that in order to reuse a generic context from pool of context for each incoming request we would need a way of clearing out or dis-associating the global object from the context.  Otherwise if we re-used a context on a new thread it could have artifacts left over from a previous script hanging around on its global.
Either that or have a way of storing session related properties and objects its own global.
We would want the sessionGlobal to contain the standard classes too.
Then using that global as the prototype for the global associated with the script/context execution.
Something like this:
JsSetPrototype(scriptGlobal, sessionGlobal);
When a request hits the web server we check to see if the request has a session. If it does we do the above and the script now has access to all the objects and properties from previous runs.
Then upon script completion, we do this to break the chain:
JsSetPrototype(scriptGlobal, NULL);
and this maybe this:
JsClearScope(scriptGlobal);
to clear out any properties and objects between runs.
When I said resolver hook, I meant a callback that is fired whenever a script is trying to access a property on the global that doesn't already exist.  The resolver hook code can then define the missing properties "on the fly" as a way of lazy loading seldom used classes into the global.
Thanks for your help.
What would it take to become a committer of ChakraCore?

Having through more about this, if I'm understanding your use case correctly a context per session will likely be most efficient and will avoid pain.

There isn't currently an API to set up a resolver hook of that kind BUT it can be done, you can actually do it within Javascript like this - you could inject a snippet of this kind into the start of your context:

const originalProto = globalThis.__proto__;

function resolveHook(prop) {
    print(`attempted to resolve ${prop}`); // demonstrate
    return globalThis[prop] = Math.random();
}

globalThis.__proto__ = new Proxy(originalProto, {
    get (targ, prop) {
        if (targ.hasOwnProperty(prop)) {
            return Reflect.get(targ, prop);
        }
        else {
            return resolveHook(prop);
        }
    }
});

In terms of doing it with the ChakraCore API instead of injecting some JS - you should be able to do the same sequence of steps via the API:

Get the global object with JsGetGlobalObject
Get it's prototype with JsGetPrototype
Create your resolver hook as a Js Function with JsCreateFunction or JsCreateEnhancedFunction - note you may need to include a reference to Reflect.get - which you may have to grab from the context by running a script snippet.
Setup a JsGetterSetterInterceptor struct with the get trap as one of its properties
Create the proxy using JsCreateCustomExternalObject
Use JsSetPrototype to set the proxy as the prototype of the global

With regards to committing changes, if you look at the PR I linked above we're still establishing how the project is going to be run as a community effort - we'll hopefully have the terms largely agreed within a week - the current draft says anyone who wants to can open a PR, and we will actively encourage volunteer contributions, though of course any additions will be subject to the core team's review.

a context per session will likely be most efficient and will avoid pain.

I'm totally fine with that.
In the absence of clearing a global, is the process of creating and throwing out contexts expensive?
What API do you propose we'll need for this?
We'll be pre-compiling scripts and executing them in rapid fire.  Is there anything that links a script to its context or global or a runtime?  or are they completely separate entities.  I'm trying to determine if I can just pick up a script and run it willy nilly on any context.

With the existing API, in terms of creating and storing contexts, you'll need to use JsCreateContext and then store them in some kind of array - note you'll need to JsAddRef the non-active ones so they don't get garbage collected, when you want to dispose of one, use JsRelease AND ensure you don't keep a reference to it on the stack. (ChakraCore scans your native stack for JsValueRefs of any kind and protects them from garbage collection)
For pre-compiling and repeatedly running scripts, how pre-compiled do you mean? You can use JsSerialize to convert a script into bytecode that can then be repeatedly run with JsRunSerialized.
If you mean you want CC to hold an internal representation of a function that you can repeatedly call - e.g. so it could internally be jitted early on - you'd need a script that returns the function that you could execute and then catch the return value which you could then call with JsCallFunction - I haven't tried moving the result of this kind of action across contexts so don't know straight off if it will work/how well it will work.


groups in multi-label stratification unreliable?

I would expect something like a group being labeled as the unique set of all labels in all its members.
But as it stands, I'm getting groups with elements in both train and test parts.
Is this a fallback to provide adequate coverage of the actual labels? Is the grouping not guaranteed?

@munael I also hope we have this functionalities. That said, in scikit-learn, groups parameter ignored and maybe it's the same here.


Update indirect dependencies

Motivation
Update indirect dependencies (not covered by dependabot).
Changes
Update dependencies
Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors merge

bors merge


Close tensorboard summary writer on finalize

What does this PR do?

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Would be great to do this for other loggers too

I was wondering about the case where you would want to log additional metrics after training (for example on test set, or other manual interpretatability metrics).

if we call close, we can replace the explicit flush: https://github.com/pytorch/pytorch/blob/master/torch/utils/tensorboard/writer.py#L1029-L1035
if we were to close, i think this should happen in on fit end, not on train end.
@borisdayma that's a good point. if you're calling trainer.fit() and then trainer.test(), the summary writer would be re-initialized. i think this would cause a version change, meaning logs from fit would go in 1 directory and logs from test into another.


Article: Branded Types

Overview
The topic of 'branded types' keeps coming up once in a while. There aren't too many resources on it right now - and no article is as deep on them as I want. Time to write it myself!

Marking as blocked on #134. Some common strategies around branded types involve asserts, which I think necessitates writing an article first on why throwing errors isn't type-safe.


Properly set pod as privileged

There is no pod-level security policy to set privileged. Instead, explicitly set privileged for every container in the pod that needs it (the two that mount audit-dir)
Signed-off-by: Peter Hunt<EMAIL_ADDRESS>

/test e2e-aws

@deads2k @sttts PTAL

/lgtm
Last one on credit.  Next time prove it first

@deads2k deal


Bump Dependencies #2177115245

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2177115245

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


has no method 'remove'

Error log
`TypeError: Object # has no method 'remove'  at link (file:///android_asset/www/lib/ionic-modal-select/dist/ionic-modal-select.js:120:17)`
Won't load on older devices.

@danielpflood thanks for your PR. merged!


CDMA [vzw & sprint], usa

Will this benefit those with CDMA (3G, 1x) handsets with LTE (cat4, cat6)?

At present the code looks for instances of CellInfoGsm and CellInfoWcdma. I will add code to support CellInfoCdma and CellInfoLte. But even after that I cannot say whether or not OpenCellID and/or Mozilla location services have information about LTE towers in their databases as I do not have a LTE phone to check.

I don't see data in Mozilla for CDMA or LTE, so closing this until data becomes available.

Hi, at least on my phone (Sprint EVO 3D with 4.2.2), the API functions for CdmaCellLocation that are supposed to return tower location do actually work. Since CDMA is required to have a GPS receiver at the tower for synchronization purposes, this information is probably just broadcast by the tower itself. There is actually no need for a database, but adding code to just return the coordinates provided by the API in the case of CDMA should be trivial.


Asset Image not loading while using Cupertino Picker in bottom sheet

Hi Everyone
I am trying to show country flag and names using Cupertino Picker which is used inside a bottom sheet.When the bottom sheet opens up for the first time, Cupertino Picker is throwing an error saying "The method 'toDouble' was called on null."
**I would like to point out two things here:-

This issue is coming when I am displaying images by fetching it from assets in cupertino picker.  If I use Inbuilt flutter icons then the same code works fine.
Also note that if you comment this line   Image.asset('images/image_2.jpg', height: 200), , the same code will work**

Below is the stack trace.
════════ Exception caught by image resource service ════════════════════════════════════════════════
The following NoSuchMethodError was thrown while resolving an image:
The method 'toDouble' was called on null.
Receiver: null
Tried calling: toDouble()

When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      double.> (dart:core-patch/double.dart:94:31)
#2      max (dart:math-patch/math_patch.dart:43:9)
#3      _clipOffsetToScrollableRange (package:flutter/src/widgets/list_wheel_scroll_view.dart:362:19)
#4      _getItemFromOffset (package:flutter/src/widgets/list_wheel_scroll_view.dart:354:11)
...
Image provider: ScrollAwareImageProvider<dynamic>()
Image configuration: ImageConfiguration(bundle: PlatformAssetBundle#b5efd(), devicePixelRatio: 3.0, locale: en_US, textDirection: TextDirection.ltr, size: Size(30.0, 30.0), platform: android)
Image key: AssetBundleImageKey(bundle: PlatformAssetBundle#b5efd(), name: "images/flags/in.png", scale: 1.0)

Also check the code that I have used to show the flag and name of country:-

code sample
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

List<Map<String, String>> flagData = [
  {"name": "India", "flag": "images/flags/in.png"},
  {"name": "France", "flag": "images/flags/fr.png"},
  {"name": "Italy", "flag": "images/flags/it.png"},
  {"name": "Germany", "flag": "images/flags/de.png"},
  {"name": "Belgium", "flag": "images/flags/be.png"},
];

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  double hgt;
  double wdth;

  @override
  Widget build(BuildContext context) {
    var size = MediaQuery.of(context).size;
    hgt = size.height;
    wdth = size.width;

    return Scaffold(
        appBar: AppBar(
          title: Text("ScrollWheel in bottom sheet"),
        ),
        body: SingleChildScrollView(
          child: Column(children: [
          Image.asset('images/image_2.jpg', height: 200),
           SizedBox(height: 10),
            RaisedButton(
                child: Text("Tap To Open"),
                onPressed: () async {
                  _showBottomSheetModal();
                })
          ]),
        ));
  }

  _showBottomSheetModal() {
    showModalBottomSheet(
        backgroundColor: Colors.white,
        context: context,
        builder: (context) {
          return Column(
            mainAxisSize: MainAxisSize.min,
            children: <Widget>[
              SizedBox(
                height: 250,
                child: CupertinoPicker(
                  onSelectedItemChanged: (int item) {
                    print("item - $item");
                  },
                  itemExtent: 80,
                  diameterRatio: 2,
                  children: flagData.map((e) {
                    print(e['flag']);
                    return Row(
                      children: <Widget>[
                        Image.asset(
                          e['flag'],
                          width: 30,
                          height: 30,
                        ),
                        Text(e['name'])
                      ],
                    );
                  }).toList(),
                ),
              ),
            ],
          );
        });
  }
}

here is the flutter doctor stacktrace:-
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, 1.19.0-4.3.pre, on Microsoft Windows [Version 10.0.17763.168], locale en-IN)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[√] VS Code (version 1.46.1)
[√] Connected device (1 available)

• No issues found!

Also check screenshots for actual output (having no flag) and expected output (having flag with country name).

@sherrychhabra51
could you attach minimal reproducible project?
What device are you using? do you have another device/emulator to check if it persists?
I tried to run it on my Redmi Note 7 Android 9 (API 28) with master 1.20.0-8.0.pre.40 and beta 1.19.0-4.3.pre (as you used) with this image instead of image_2.jpg and flags. But it is working as intended

@VladyslavBondarenko
Can you please clone repo from below mentioned URL:-
https://github.com/sherrychhabra51/flutter-wheel-view.git
I have tested this in Google Pixel 2 and MI A-1 device and able to reproduce this in both of these devices .
Here are some steps which might help you :-

Run the app and tap on Tap To Open Button.
Bottom sheet pops up  and in this bottom sheet, only last items which are not visible on screen will have flag and country name both loaded properly but the items that are visible on screen will have only country name and while loading image it will throw an exception.
Do scroll up and down, all images will be loaded.

I am facing this issue with CupertinoPicker only, if i use List view instead of Cupertino Picker , it seems to be working fine without any issue.
Let me know if more details are required.

@sherrychhabra51
thank you, with this repo I can reproduce it, with current master 1.20.0-8.0.pre.57 as well

Yes. That's correct. The issue only occurs when we  use Image.asset and the same code works fine if used with Icon class or Image.network class.

I am facing the same issue.

Hey guys I am facing it as well. Any chance to give us a timeframe, when the issue will be fixed on stable channel? And any available workaround in the meantime? Thanks!

I am also facing same issue
The following NoSuchMethodError was thrown while resolving an image:
The method 'toDouble' was called on null.
Receiver: null
Tried calling: toDouble()

I am facing the same issue for a while now.  I thought version 1.20.1 would have address this issue.

ok..  i know this isnt a fix or even the a very eloquent but.. it works and allows me to move on and hopefully will help someone else meanwhile, until the issue is resolved.
so just as @VladyslavBondarenko said:
"Bottom sheet pops up and in this bottom sheet, only last items which are not visible on screen will have flag and country name both loaded properly but the items that are visible on screen will have only country name and while loading image it will throw an exception.
--->> Do scroll up and down, all images will be loaded."
thats how it worked for me as well. it reminded me of image preloading issues so i took that approach and i tried preloading all the images on the first screen of my app, and it worked.
like so:
Row(
children: [
Image(image: AssetImage("lib/foundation/assets/flags/en.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/il.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/es.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/in.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/de.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/ru.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/fr.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/jp.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/br.png"), width: 1, height: 1),
Image(image: AssetImage("lib/foundation/assets/flags/cn.png"), width: 1, height: 1),
],
))

Hi @yaaqovadam ,
I have tried on my side but it's not working even by loading picture on the main screen.
See : https://youtu.be/d8Q8SlcwJ7Y
I really hope that Flutter team will fix this issue ASAP because I have no idea how to find a proper workaround...

Duplicate of #60578
Check my comment

Duplicate of #60578
Check my comment

@Adavo
hrmmm.. wellll.........:) i dunno.. i actually preload mine on the sign in screen, the top most widget in the widget tree, before i navigate to the screen with the picker. try  doing that.
"I really hope that Flutter team will fix this issue ASAP"
me too :)

I am experiencing this same issue.  Used @yaaqovadam's workaround, which worked.  It would be nice to have this work out of the box, though.

Try (for each image):
Image someImage;

void initState() {
   super.initState();
   someImage = Image.asset('assets/my_image.png');
}

@override
void didChangeDependencies() {
   super.didChangeDependencies();
   precacheImage(someImage.image, context);
}

Source

Please look at @XxLuckyMxX comment.
Pre-caching with a builder is counterproductive...

@darshankawar So any updates on this ?

This is a serious problem with the ListWheelScrollView widget, I can't understand how it takes years and this is still is not fixed...

I'm using FancyShimmerImage inside ListWheelScrollView, which is basically the CachedNetworkImage with a shimmer. I noticed the problem was only happening to me for the visible widgets in the ListWheelScrollView, but when scrolling to the parts where it starts hidden, those images were loading well. So I realized it happens just in the first rendering. Then I had what I thought was a stupid idea, that I set the errorWidget to be displayed in the CachedNetworkImage as the FancyShimmerImage itself, and it ended up that when it tries to load the image again it works.

thanh @hyungtaecf
this is how it work for me
Image.asset(
                widget.country.flagUri!,
                package: 'country_pick_screen',
                width: 40,
                errorBuilder: (_,__, ___) {
                  return Image.asset(
                    widget.country.flagUri!,
                    package: 'country_pick_screen',
                    width: 40,
                    errorBuilder: (_,__, ___) {
                      return SizedBox();
                    },
                  );
                },
              )

@sherrychhabra51  I tried running your code sample and it seems to work as expected, I believe the bug is fixed.

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-3.0.pre.33, on macOS 12.6 21G115 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-3.0.pre.33 on channel master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (38 minutes ago), 2022-12-05 18:27:21 -0800
    • Engine revision a309d239c4
    • Dart version 2.19.0 (build 2.19.0-463.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.55.20221129

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Closing for now. Incase you still encounter the issue please feel free to write in the comments and we will reopen it.
Thank you.


ENH: Support to handling race results data

Runpandas comes now with new features that enables it to reading the race event results from runpandas dataset repository. The goal is to extract more data from race results since demographics, finishing times, splits time and demographics.
It closes #16 .

Codecov Report
Base: 93.73% // Head: 94.23% // Increases project coverage by +0.49% :tada:

Coverage data is based on head (60bcfdf) compared to base (d3b7202).
Patch coverage: 96.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   93.73%   94.23%   +0.49%
==========================================
  Files          23       26       +3
  Lines        1022     1300     +278
  Branches      168      173       +5
==========================================
+ Hits          958     1225     +267
- Misses         44       54      +10
- Partials       20       21       +1

Impacted Files
Coverage Δ

runpandas/types/summary.py
92.92% <78.37%> (-7.08%)
:arrow_down:

runpandas/types/frame.py
94.66% <95.74%> (+0.49%)
:arrow_up:

runpandas/io/result/_parser.py
97.29% <97.29%> (ø)

runpandas/datasets/schema.py
100.00% <100.00%> (ø)

runpandas/datasets/utils.py
100.00% <100.00%> (ø)

runpandas/exceptions.py
88.88% <100.00%> (+8.88%)
:arrow_up:

runpandas/io/__init__.py
100.00% <100.00%> (ø)

runpandas/io/result/__init__.py
100.00% <100.00%> (ø)

runpandas/reader.py
96.07% <100.00%> (+1.20%)
:arrow_up:

runpandas/types/__init__.py
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Bluetooth: Mesh: A few fixes, clarifications & cleanups

A couple of issues I came across while looking at the existing code, as well as some preparation for subsequent patches I have lined up.

@rymanluk @michal-narajowski FYI

recheck


feat: add neovim/neovim

aqua is exactly what I have wanted for a long time!
This PR is to add neovim.
neovim is supported by asdf too. https://github.com/aquaproj/aqua-registry/issues/858#issue-1071213906

Thank you for your contribution!

v0.10.17 has been released 🎉
Thank you!


instead of regexing in frontend, send back wikidata url from backend

right now, frontend checks if there's a wikidata entry for a property/item in a weird way.
we can just have the backend return the wikidata url for the property/item and spare the frontend the trouble plus ourselves some bugs

released in 2.3.9, not relevant for testing


Clarification of App ID meaning

The documentation says to enter the Application ID, however the JWT contains aud: api://**. So it is the application ID URI that needs to be entered and not the application ID. This makes it clearer.

@nihil0 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fix MSYS2 compatibility

Hey @mm2,
This PR groups together the fixes needed to enable CI for all Intel MSYS2 flavors:

used concurrency groups to supersede builds quickly when force-pushing
fixed the missing exported APIs issue I reported in the mialing list
fixed your usage of timespec_get in the threaded plugin test bench, which on Windows, is UCRT-only and C11 or higher

As regards the missing private APIs-- given that you intend to use GCC's visibility to export the functions in Windows, do you want me to remove the vs_module_defs in that case?

@dragonmux @kmilos Seems that newer setup-msys2 takes care of both of these, so I've moved forward with the requested changes.

@amyspark  ok, I was done exactly that, you sent the PR before I could commit.


add fabric maven url under allprojects

Previously just writing repositories makes it confusing whether to add the url under buildscript or allprojects.
I was facing issue #392 because of this.

This seems like a good idea, thanks!


[Feature] Showcase Section in README - Urls changed for demo and repo for 'Covid-19 SA Data' project.

Is your feature request related to a problem? Please describe.
In the main README for this repo under the showcase section the urls for my Covid19 visualizations website (Covid-19 SA Data) no longer correspond to the correct repo and demo url.
Describe the solution you'd like
Repos: There are now two repos that now correlate to my site. One that compromises the actual site (i.e. the js and html) located at https://github.com/SimonRosen173/Covid19SAData_JS and the other compromises the data processing code and data (which uses data from this repo). The later repo is located at https://github.com/SimonRosen173/Covid19SAData_Data.
Demo: The url of the actual website has been changed to https://covid19data.co.za/
Describe alternatives you've considered
N/A
Additional context
Apologies for the wrong tag used as I believe none of the available tags corresponded to this particular issue.

Yes @lrossouw

@lrossouw chicking about the scraping again.

Closed by 09e6c1d8ae7e8223f74a2e30971723647204c90b


Manifest merging error

Adding a dependency on LoggingInterceptor results in:
.../app/src/main/AndroidManifest.xml:23:5-32 Error:
        Attribute application@allowBackup value=(false) from AndroidManifest.xml:23:5-32
        is also present at [com.github.ihsanbal:LoggingInterceptor:1.0.3] AndroidManifest.xml:12:9-35 value=(true).
        Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:21:3-198:17 to override.
.../app/src/main/AndroidManifest.xml:26:5-32 Error:
        Attribute application@supportsRtl value=(false) from AndroidManifest.xml:26:5-32
        is also present at [com.github.ihsanbal:LoggingInterceptor:1.0.3] AndroidManifest.xml:14:9-35 value=(true).
        Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:21:3-198:17 to override.

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

Seems like these flags should be removed from the manifest?

Now you can try this Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml
@andrewmunn
your manifest.xml
<application
        android:name=".LogApplication"
        android:allowBackup="false"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:roundIcon="@mipmap/ic_launcher_round"
        android:supportsRtl="true"
        tools:replace="android:allowBackup">

1.0.4
Will remove  allowBackup and supportRlt attributes.

<application
        android:allowBackup="true"
        android:supportsRtl="true">

@andrewmunn you can try version 1.0.4.

1.04 works perfectly! Thanks @ihsanbal for the lightning fast fix.


Tests

now the tests pass, hooray

This fixes #5

CI is broken because the GitHub Action that I copied and pasted from a random blog post doesn't actually work. Fun, huh? That's up next.


Enhance CREATE PIPE to process INSERT Select from starrocks tables as well

CREATE PIPE is awesome help to load data from s3 compatible object storage.
It basically processes INSERT SELECT from FILES.
An enhancement to it to allow INSERT SELECT form TABLES/VIEWS would make starrocks very powerful and cater to 10x times use cases in implementing systems like Data Vault 2.0 data warehouses.
Please consider this at a priority as high as possible.

I believe you can already do this.  https://docs.starrocks.io/docs/loading/InsertInto/#insert-data-via-insert-into-select

Hi Albert,
I'm asking for a PIPE for it. CREATE PIPE ..INSERT ...SELECT ..from
<starrocks table/view> is not supported currently.
CREATE PIPE ..INSERT ...SELECT ..from FILES( ) is supported now.
Thanks,
Pugazendhi Asaimuthu
On Sun, Dec 24, 2023 at 6:12 PM Albert T. Wong @.***>
wrote:

I believe you can already do this.
https://docs.starrocks.io/docs/loading/InsertInto/#insert-data-via-insert-into-select
—
Reply to this email directly, view it on GitHub
https://github.com/StarRocks/starrocks-kubernetes-operator/issues/382#issuecomment-1868609549,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQ7IASN5HMBKTSMAD574GLYLCZG7AVCNFSM6AAAAABBBIPAJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGYYDSNJUHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Since PIPE just got released in 3.2, it may take another release for this feature to be implemented.

Thanks for being on it. Can you give a date so I can plan my development around it.

Since StarRocks is a community project, dates come from the committers and vendors who write code for the project.

Hello, I am not sure if the latest version of StarRocks has resolved your issue. If it hasn't been resolved, I suggest you can go to https://github.com/StarRocks/starrocks and raise this issue again. Because this project is the StarRocks Kubernetes Operator, it mainly deals with issues related to deployment and Kubernetes.


Add ID for Create Grid

As the grid will be used for spatial joining, so Adding  GRIDID for that  will facilitate  the subsequent progress

solved

closed as solved


How to use redis datasource to collect a lot of redis

I have many redis.
How to collect these redis?
Do I have to add multiple data sources?

one by one?

Hello @wangxin0529
Yes, you need to add an instance of Datasource for each Redis database you're using. After that, you can use multiple data sources in one dashboard and even in one panel in multiple query mode. Please also note, Grafana template variables support Datasource type, so you can automatically repeat panels and rows for all databases, which you defined.
Thank you

@wangxin0529 you can add Data sources manually as @alex6058 explained or use Data source API to automate: https://grafana.com/docs/grafana/latest/http_api/data_source/
Please let us know if you have any questions.

you can use multiple data sources in one dashboard and even in one panel in multiple query mode.

How to do this？

OH, I get it, THANK YOU!

@wangxin0529, Unfortunately, this is a limitation of Grafana 7. We can't export the dashboard which supports multiple data sources and share it within datasource.
I have added dashboard which supports multiple Redis instances: https://github.com/RedisTimeSeries/grafana-redis-datasource/blob/master/dashboards/redis.json
Do you want to try and let me know if it works for you?

@mikhailredis I use multiple data sources in one dashboard ,and define a variable named server like this


Post comment once status uploaded.

Maybe using https://github.com/marketplace/actions/github-status-action ?

Actually I think we can create a GH app, and after asking authorisation, we shoudl post a status update once we receive the ping.