[Snyk] Upgrade @pingidentity-developers-experience/ping-oidc-client-sdk from 2.3.1 to 2.3.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @pingidentity-developers-experience/ping-oidc-client-sdk from 2.3.1 to 2.3.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 5 months ago, on 2023-11-30.

Release notes

Package name: @pingidentity-developers-experience/ping-oidc-client-sdk

2.3.2 - 2023-11-30
Resolved some dependabot findings

2.3.1 - 2023-10-26Merge pull request #59 from pingidentity-developers-experience/qa
Merge pull request #58 from pingidentity-developers-experience/oct-jo

    from @pingidentity-developers-experience/ping-oidc-client-sdk GitHub release notes

Commit messages

Package name: @pingidentity-developers-experience/ping-oidc-client-sdk

3fdf12f New SBOM for NPM release
4d9ff03 Merge branch 'qa' into release-2-3-2
5beb063 Merge pull request #61 from pingidentity-developers-experience/dependabot-ea
92164fe Ensured the test apps have bumped vesions of postcss and tough-cookie #186304939
4b263c7 Ensured the test apps have bumped vesions of postcss and tough-cookie #186304939
687b8aa Merge branch 'dependabot/npm_and_yarn/test_apps/react/babel/traverse-7.23.2' into dependabot-ea
16e9bcd Merge branch 'dependabot/npm_and_yarn/test_apps/angular/babel/traverse-7.23.2' into dependabot-ea
4be4ad0 Merge branch 'dependabot/npm_and_yarn/babel/traverse-7.23.2' into dependabot-ea
7f1f23c Merge pull request #60 from pingidentity-developers-experience/november23-sdk-ms
db0d4cc Corrected a path typo and markdown spacing.
c64d99d Bumped the patch version for test app and readme updates.
401f1a3 Changes to testing apps and their READMES to be more intuitive.
21fc680 Merge pull request #59 from pingidentity-developers-experience/qa
1da74d0 Merge pull request #58 from pingidentity-developers-experience/oct-jo
154b327 Bump @ babel/traverse from 7.22.10 to 7.23.2 in /test_apps/angular
d9a1592 Bump @ babel/traverse from 7.22.10 to 7.23.2
6b27028 Bump @ babel/traverse from 7.21.5 to 7.23.2 in /test_apps/react

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closed because quarterly patching resulted in a newer version


[Bug Report] Einops shape error when use_attn_result = True

Describe the bug
Setting use_attn_result = True results in an error when running the model due to an einops shape error.
Code example
Minimal working example here: https://colab.research.google.com/drive/1vaPKk-C2xcvCGZmwGePY044nlwI5tFcL?usp=sharing
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Fixed in 2.2.1. Thanks for the report!


End to end testing of majorly used components

Test and verify that the system works as intended only using the UI with respect to:

[ ] Evaluation building. Majorly used task types / task type templates etc. for campaigns such as VBS and LSC
[ ] Evaluation running. The viewer and admin view with respect to campaigns such as VBS and LSC
[ ] User management
[ ] Collection management

Ad "Evaluation running": Properly test submission -> verdict pipline including deduplication and judgements

processes were successfully tested in VBS'24


padreati's third submission

I managed to reduce time on local machine to 13 seconds. Some notes regarding what I have done:

no memory mapped files
split file processing in chunks
use vector api in a better way than previously
create a shared name registry with synchronization to avoid creating new string objects and work on hashes
various other improvements

On my local laptop i7 4 cores, 8 threads, AVX512 it takes ~13 seconds. I expect to be slower, around 15 secs on benchmark machine.

Could you rebase this one to the latest main branch and ideally squash everything into a single commit too? And then remove the "needs rebase" label? Thanks!


🪡 Infer the value of patched record fields

This PR implements the proposal in #326 to infer the value of patched record fields. The examples from the proposal are included as tests. I think the next step should be @TOTBWF's suggestion to use ✨elaborator magic ✨ to eliminate the need to write struct (fib : foo) and foo.fib when working with the total space of a type family.

@mmcqd PS: I noticed that Refiner.ml might not be completely ocp-indent-ed and free of trailing whitespace. (It's okay!) There are ways to format files automatically depending on what editors you are using. :wink:


add tyshko

add tyshko scool domain

@andrewt82 I am sorry, this domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.


Optimizing Azure VM Selection for Cost-Effective Deployment of Candle LLMs

Hello,
I'm a graduate student from Duke University, collaborating with Professor Noah noahgift on the Candle project. I believe he has already reached out to you earlier (you can see the details here).
We're currently encountering an issue as we're setting up an Azure Virtual Machine to act as the Azure Spot Runner for Github Actions, with the purpose of running the Candle binary. We would greatly appreciate your insights on selecting the most cost-effective Cuda-enabled VM on Azure for this task.
Thank you.

Hello,
I'm afraid I don't know anything about azure. Are there some candle specific parts to your problem, e.g. an error message that we could look at? Otherwise I would suggest going for the same thing as people would for running PyTorch models on azure and hopefully that should work for candle too.

Cool, I will proceed to identify a suitable CUDA-enabled virtual machine for this purpose then, will keep you updated. Thank you!

Closing this for now as hopefully you will have sorted things out now.


Implement obvious feedback for improperly filled forms

Currently forms prevent you from inputting bad data.
This is very non-transparent for users and bad UX/UI.
Instead, block the form submission if fields are improperly filled and provide obvious dynamic error feedback of what's wrong (number must be between 0 and 7, etc)


docs: Write down some high-level thoughts on doing code reviews.

This started as a PSA in the form of a series of chat messages in
#general on chat.zulip.org; putting them here, with some editing,
to make their value more durable.
Also rearrange this doc slightly so that it's not specific to
the server codebase, except in a few explicit spots.
The bit that's for authors should probably be somewhere else.
I think there isn't right now a great natural spot for it --
probably the top of docs/git-guide, some parts of docs/version-control,
and that paragraph here should all turn into a top-level "guide
to submitting code to Zulip" doc, which would link to the rest
of docs/git-guide and to some other resources.  Leaving that
for another day.

Automated message from Dropbox CLA bot
@gnprice, it looks like you've already signed the Dropbox CLA. Thanks!

Codecov Report

Merging #5584 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #5584      +/-   ##
=========================================
+ Coverage   87.46%   87.5%   +0.03%
=========================================
  Files         434     434
  Lines       54313   54313
  Branches     2098    2098
=========================================
+ Hits        47506   47527      +21
+ Misses       6807    6786      -21

Impacted Files
Coverage Δ

zerver/tornado/ioloop_logging.py
93.33% <0%> (+46.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e4855...4f5e86a. Read the comment docs.

Merged!  Thanks @gnprice!  (I read through this, and didn't find any typos or confusing sections, so I merged this, but we should probably get folks to read it on the site to get more feedback and maybe a few small doc patches.)


vcpkg search fail!

PS E:\vcpkg> .\vcpkg.exe search sqlite
The result may be outdated. Run `git pull` to get the latest results.

If your port is not listed, please open an issue at and/or consider making a pull request:
    https://github.com/Microsoft/vcpkg/issues
PS E:\vcpkg> .\vcpkg install sqlite3
Error: invalid triplet: x86-windows
Available architecture triplets
VCPKG built-in triplets:

VCPKG community triplets:

Your complete installation seems broken. Maybe try to delete vcpkg and clone it again.

I reinstall it. There's still a problem

vcpkg.exe integrate install fail


Create Retreat Agenda

1-2pg overview

Rough draft here: https://docs.google.com/document/d/1kGcb6s9wJnec8SuCJ-BtFvgvnnn6Yx8ESfENsAHPBSw/edit?usp=sharing - will continue to iterate with @beckkles and @dazuck but this story is complete


Persistence/add transactions to block

Description
Populate the transactions in the persisted blocks using txIndexer.
Issue
Fixes the following sub-issues of #352:

PR3: [Consensus] Adding transactions via transaction indexer

Type of change
Please mark the relevant option(s):

[X] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Update prepareBlock() function to include transactions with txIndexer.

Testing

[X] make develop_test; if any code changes were made
[X] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[ ] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[X] I have tested my changes using the available tooling
[X] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

/reviewpad summarize


Datagrid performace issue: DatagridContent from Datagrid is re-rendering 4 times

Package
Carbon for IBM Products
Description
We are noticing real performance issues caused by the Datagrid in our App where we have around 7 tables in a single page/panel and each time any state data changes (which is irrelevant to Datagrid data), the DatagridContent and its children components re-render 3-4 times! On that same panel we have input fields, on every keystroke each DatagridContent re-renders 4 times resulting in a sluggish experience. It easily gets to hundreds of re-renders on a simple input change by the user.
We also tried creating a very basic data grid just with few basic static column and row data without any other fancy stuff, and it still re-renders the DatagridContent and its children 4 times on any change affect data that is completely unrelated to the Datagrid data.
Note: We are also memoizing all the column and data objects.
Component(s) impacted
All the component in our project where we have used Datagrid are getting impacted by multiple rendering.

Browser
Chrome
@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version
2.43.1
Suggested Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Product/offering
Datagrid
CodeSandbox or Stackblitz example
https://codesandbox.io/p/sandbox/github/carbon-design-system/ibm-products/tree/main/examples/carbon-for-ibm-products/Datagrid?file=%2Fsrc%2FExample%2FExample.jsx
Steps to reproduce the issue (if applicable)

Adding the Datagrid component to the our component with static columns
Having an controlled input field in the same component.
We need the React Dev tool Profiler.
Now if we type 1 character in the input field then we will see 3-4 times DatagirdContent being re-rendered even thought both the input field data & Datagrid our unrelated.

Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

Hi @tushardhamor ,
I think here  when you update the state of the input element, the parent component in which both input element and Datagrid contained will re-render. This will in-turn re-renders the Datagrid component which is as  expected.
https://github.com/user-attachments/assets/e4efdf50-f0f2-4a77-a878-f6c4cef27172
But if you wrap your inputs to a separate component, and there by preventing the re-renders of parent , we can prevent  the re-rendering of Datagrid as well. Could you able to try any similar solutions?
https://github.com/user-attachments/assets/ec46b1a2-5437-43ed-ac06-3e07a2fb6ba8


SCSS warning: .indenter" failed to @extend ".icon-check"

WARNING on line 91 of /Users/justin/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/browse-everything-0.6.3/app/assets/stylesheets/browse_everything.css.scss: "#browse-everything .fa3 .ev-selected .indenter" failed to @extend ".icon-check".
  The selector ".icon-check" was not found.
  This will be an error in future releases of Sass.
  Use "@extend .icon-check !optional" if the extend should be able to fail.

I'm guessing this is now .ui-icon-check:
https://api.jqueryui.com/theming/icons/
Sound plausible?


Help Please

Challenge Waypoint: Uncomment HTML has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Hello World

CatPhotoApp

Hello Paragraph

Closing. Please feel free to re-open with steps and a description on how to reproduce the issue.
Happy Coding!


consider skipping unusual whitespace characters while parsing

Parser.parse!/2 was crashing for me despite the fact that the JSON I fetched from external service looked completely fine. It turns out that the JSON started with a zero-width non-breaking space (U+FEFF).
Shall we change this line to pattern match all whitespace characters (a list is available at wikipedia) instead of only '\s\n\t\r' ? How much it will hurt the performance?
I understand this case may be unusual, but apparently these things may happen.
JSX handles this JSON just fine.

Any thoughts on that? Shall I submit a PR? Should this be configurable in any way?


automatically publish draft PR from core/sxl

currently specific drafts are handled with a workflow for each. since we don't plan to have frequent releases of the specs that might be ok.
but otherwise i think we could make a workflow that triggers on a PR to master in core/sxl repos and outputs to a matching folder on the published GitHub pages site.

This is now possible. The only thing remaining is to figure out how to move the sxl.yaml from rsmp_schema to the sxl repo. The sxl.yaml is needed to generate the html/pdf versions


Improve preview stage of progress on stream Datasource creation

Is your feature request related to a problem? Please describe.
Improve stream data source
Describe the solution you'd like
Management > Data Storage > Datasource >Create > stream

Improve UX preview sample data
CSV format sample files are supported.

@koeun222 We need to improve the design below.

@AnnieHwang @koeun222 We do not use the term schema after the topic. I hope you make a phrase that means that you can set up the schema on the next stage through the data in the topic.

@minhyun2 The design is complete. I will upload the label after modifying the wireframe.


Add dynamic methods to check and transition state

I suggest to add dynamic created method to check and transition state, for example we have state machine (from wiki)
class Connection
  include Celluloid::FSM
  default_state :connected

  state :connected, :to => :disconnected do
    puts "Connected!"
  end

  state :disconnected
end

I propose to add methods connected?, disconnected?, connected!, disconnected!. First pair chech current state and returns true or false. Second pair transfer state.

Thanks @aderyabin. This is something I've implemented too, but didn't commit. I think I was hesitant to do this because one might introduce unintended behavior ( theory issue, not logic issue ) ... but I think this "at your own risk" behavior is more valuable than its risk. Let's sit on this for a little bit then merge.

Also, please update the changelog. I prepared that for you ( in 0.20.6 )
Thank you for doing this with tests.

Done!

@digitalextremist I don't want to create new issue to ask a question what is the plan of the gem development? Probably, do you have a list of issues/tasks?

All issues planned would be in the tracker. This gem currently has no planned additions -- it is a very simple gem. If you have ideas, by all means post them in the issue tracker -- then post PRs against them.


Support for defaultRule

Instead of defining Host label under each service, i have a default rule in the traefik.yml configuration as shown below:
providers:
  docker:
    endpoint: "unix:///var/run/docker.sock"
    exposedByDefault: false
    swarmMode: false
    network: traefik_2
    defaultRule: "Host(`{{ index .Labels \"com.docker.compose.service\"}}.domain.com`)"

Is their any work around for this scenario or possibility to add support?

Really need this feature, too

A possible solution would be to get the hostnames via traefik v2 api (https://doc.traefik.io/traefik/operations/api/). The endpoint /api/http/routers contains every Host rule for all routers. This solution also avoids using the docker socket.

A possible solution would be to get the hostnames via traefik v2 api (https://doc.traefik.io/traefik/operations/api/). The endpoint /api/http/routers contains every Host rule for all routers. This solution also avoids using the docker socket.

I too am effected by this.


Add "evaluate expressions" flag to CommandDescription (for defs, routines, ...)

We need to add a flag so that certain commands (namely /def, /routine, /for -- and possibly future /if, /else and related conditionals) will not evaluate expressions (described by {expr}) or variables (described by $var). These evaluations need to be deferred, so that variables such as time or random numbers are evaluated at the "last moment", just before actually being executed. In the case of /def and /routine, these commands are only storing a list of commands to be evaluated later.
We currently have argsAsArray and toGdScript flags, so we should just add another one, evalExpressions.

This was implemented (for /def and /routine) in b48222a3. I added an inner class CommandDescription.Flags to be used to make initialization of commands more explicit (it was confusing to have three bools in a row!).


OCPBUGS-6473: bump gopkg.in/yaml.v2

There is a known vulnerability in versions of gopkg.in/yaml.v2 prior to v2.2.4 [1]. Currently this vulnerability is indirectly references as follows:
github.com/stretchr/testify requires gopkg.in/yaml.v2 v2.2.2
github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 requires gitub.com/stretchr/testify v1.5.1, and is required by a number of packages.
To remove this vulnerability, ginkgo must be migrated to v2.
Additionally, bump the versions of the following to remove dependency on vulnerable version of ginkgo, gomega, and slim-sprig:
github.com/onsi/gomega
github.com/containernetworking/cni
github.com/containernetworking/plugins
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2161274
[1] https://pkg.go.dev/vuln/GO-2022-0956

/cc @vrindle

Is it possible to get this reviewed / merged? This update is required to fix https://issues.redhat.com/browse/OCPBUGS-6473

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.027%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
424

Relevant Lines:
1115

💛  - Coveralls

cc @adrianchiris @SchSeba

@wizhao

there is an issue with the go-lint but there is no output :(
I will need to try and run it locally with the same version to see if it also failed on my laptop

/retest-required

@e0ne, @adrianchiris can we have some clues about Mellanox CI failure?

@adrianchiris @e0ne Looks like the Mellanox CI is no longer auto-failing, but it has been stuck on pending for over 24 hours. Any idea as to how we can get this PR merged?

/test-all

/test-all

Hi @zeeke is it possible to get this merged? Looks like the Mellanox CI is running / passing

/lgtm


I can not reproduce "imagenet 18" with fp32

Hi @yaroslavvb
I tried to reproduce "imagenet 18" on my host, it works well with fp16(top1 acc get 75.776% at the 27th epoch), but only get 51.018% top1-acc at the 27th epoch when fp32.

It should work with fp32, note that learning rates are tuned for specific batch sizes, if you modify batch-size you should modify the learning rate as well


Custom fields not being logged when Rails controller raises exception

I have configured custom log fields as follows:
  config.lograge.custom_options = lambda do |event|
    user = User.find_by_auth_token!(event.payload[:cookies]['auth_token']) unless event.payload[:cookies].try(:[], 'auth_token').blank?
    params = event.payload[:params].reject do |k|
      ['controller', 'action'].include? k
    end
    { "params" => params, 'user_id' => user.try(:id), 'request_id' => event.payload[:uuid], 'ip' => event.payload[:ip] }
  end

Most of the time, the custom fields are logged just fine.
» 27 Jun 2016 16:20:11.242 351 <190>1 2016-06-27T23:20:10.958993+00:00 app web.1 - - [70284120350340] method=GET path=/images/book_covers/38290 format=html controller=book_covers action=show status=304 duration=45.60 view=0.00 db=32.23 params={"book_id"=>"38290"} user_id=2131 request_id=bbe0aea0-566f-4456-8c88-20026c8f506b ip=<IP_ADDRESS>

But, when the controller throws an exception, all of the custom fields are blank.
» 28 Jun 2016 14:21:03.662 826 <190>1 2016-06-28T21:21:03.362381+00:00 app web.1 - - [70120415641220] method=POST path=/users/251 format=html controller=users action=update status=500 error='ActionView::Template::Error: undefined method '>' for nil:NilClass' duration=184.65 params={"utf8"=>"✓", "_method"=>"put", "authenticity_token"=>"XiB/p2e2vW3rhbxhlSyAkAn/tKJJSqJfhTMLfwDuAWw="<EMAIL_ADDRESS>"password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]", "full_name"=>"Janelle Denison", "friendly_name"=>"Janelle", "currency"=>"USD", "time_zone"=>"Pacific Time (US & Canada)", "daily_email"=>"10", "extra_emails"=>"", "my_referral_code"=>"G251", "my_referral_link"=>"https://www.booktrakr.com/?rcode=G251"}, "commit"=>"Save Changes", "id"=>"251"} user_id= request_id= ip=
Exceptions are being handled by the default exception handler for Rails. I'm using Unicorn 4.6.2 with Ruby 2.0.0 and Rails 3.2.21. Lograge is 0.3.4.

I couldn't replicate this in Rails 4 and above. We ended support for Rails 3.2 after v0.3.6, unfortunately. You may have some luck bumping your lograge version to 0.3.6 so I'd try there first.


Bulk_Read tool

Give Claude a Bulk_Read tool which asks for a list of filepaths that Claude would like to read ordered from most to least desired.
Will then pass all those files to claude, discarding any files once token limit is exceeded. Obviously when passed each file should be wrapped by markdown codeblock with language & filepath.
To augment Claudes ability to use this tool, the recursive files list tool should provide files sizes in calculated tokens

Would be a great feature to add.

Claude can already make a tool request to read multiple files at once. I've pushed the boundaries of this and I've gotten him to read 6 files at once, but it seems anymore than that might defeat the purpose since he tends to re-read files before editing. I also have to be careful with how many tools I define in the schema since too many tools can affect claude's ability to use the right tools effectively, so I'm gonna close this ticket bc I don't have any plans to add a bulk read tool for now.


Remove -t and -tt functionality from ironpython

This is a PR for issue #982, which removes console flags for indentation inconsistency. As suggested by @BCSharp, the arguments parser ignores -t and -tt by taking no action on them.
I have not updated the test suite. I see that the relevant test is test_t() in test_stdconsole.py. Curiously, the test suite only fails on net46 after I make these changes.
Your comments are appreciated!

[x]  Ignore -t and -tt command line arguments
[x] Remove -t and -tt from command line help
[x] Remove sys.flags.tabcheck
[x] Remove PythonOptions.IndentationInconsistencySeverity and related code

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dc366 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

As for test_stdconsole only failing on net46 it's because the whole suite is disabled in .NET Core.

I moved the initialization of indentFormat to the State constructor. In testing on my end, there are a few new test cases which fail as a result of this change.
I realized I went beyond the scope of the original issue, from simply ignoring the command line flags for indentation warnings to forcing the tokenizer to check for inconsistent indentation (though this is the desired behavior in Python3). I am not sure I have the ability to debug the behavior of the new ReadNewline() function without spending a lot more time. Let me know what you think a reasonable stopping point is.

Thanks for the PR!


Fix list's filter

There is an error with dynamic filter applied to SourceList - #164
The error exists because IsMatch might be not actual in filteredResult.
Transform is not called on remove, and is not called when filter is changed, so internally it saves previous state of the matched item, which is returned on remove.
And if it was updated on remove, IsMatch might be set to false because item was internally changed and must be filtered off, but item will not be removed.
The fast fix is to remove the optimization check on IsMatch when remove is called.

Thanks for the effort with the investigation and fix


EPEL check in install seems to be broken

"_check_no_epel()" routine within the install script seems to be broken
The routine tests the output of yum info epel-release and if this returns zero return code, EPEL is assumed to have been installed.
The info command will return with return code zero even if the package is not installed, therefore this is an inappropriate test.
Suggest verifying the package is installed using yum list installed epel-release

The info command will return with return code zero even if the package is not installed, therefore this is an inappropriate test.

That's not what I observe:
# yum info epel-release
Loaded plugins: auto-update-debuginfo, changelog, fastestmirror
Loading mirror speeds from cached hostfile
Installed Packages
Name        : epel-release
Arch        : noarch
Version     : 7
Release     : 10
Size        : 24 k
Repo        : installed
From repo   : epel
Summary     : Extra Packages for Enterprise Linux repository configuration
URL         : http://download.fedoraproject.org/pub/epel
License     : GPLv2
Description : This package contains the Extra Packages for Enterprise Linux (EPEL) repository
            : GPG key as well as configuration for yum.

# echo $?
0
# yum info foo
Loaded plugins: auto-update-debuginfo, changelog, fastestmirror
Loading mirror speeds from cached hostfile
Error: No matching Packages to list
# echo $?
1

yum info will show you information about a package that it knows about (has cached metadata), even if it is not installed. easy way to show that is to uninstall epel-release and then run info, command will then return rc zero even though the package is not installed

I think we should be able to close this now.

this has subsequently been addressed in #142 according to @brianjmurrell


Fixed remote-e2e-test target to remove stale files

The remote-e2e-test make target now cleans up the spec/e2e/screenshots directory
before submitting a new test, leaving only the .baseline.png files.

Coverage remained the same at 87.48% when pulling d50b711aac078ac0e8c6b6c0d7d8d6ff70a73e61 on job13er:clear-old-regressions into 3cc87029f58d9fd615b8e3a4620db84c7003446e on cyaninc:master.

Coverage remained the same at 87.48% when pulling 8bdf4ee73347253aa4a0bdd0ff70208647c5ff18 on job13er:clear-old-regressions into 3cc87029f58d9fd615b8e3a4620db84c7003446e on cyaninc:master.


Modbus TCP---> Modbus ASCII gateway

Can an example program for Modbus TCP ---> Modbus ASCII be added?

Actually it should be enough to change backend's mode to ASCII (.mode = MODBUS_MODE_ASCII), if not there is a bug somewhere, probably 😃 ...

I tried like this, but the message sent to RTU is wrong.
I also need to make a Modbus gateway with RTU as the master, can you add a sample program?

Actually it should be enough to change backend's mode to ASCII (.mode = MODBUS_MODE_ASCII), if not there is a bug somewhere, probably 😃 ...

I tried like this, but the message sent to RTU is wrong.
I also need to make a Modbus gateway with RTU as the master, can you add a sample program?
@jfischer-no


[bug] Mod crashes on Minecraft 1.19.2 (Forge)

Description
Mod does not work on Minecraft 1.19.2 when using Forge.
Steps to Reproduce

Use Minecraft 1.19.2 with Forge

Expected Behavior

Game launches

Actual Behavior

Game crashes

Operating System
Windows
Java Version
N/A
Mod Loader
Forge
Minecraft Version
1.19.2
Mod Version
0.3.3
Launcher
N/A
Mod Portal
CurseForge
Additional Information
Imported from https://legacy.curseforge.com/minecraft/mc-mods/expanded-gamerules?comment=5
Original text:

hi y`y have a crash report for the forge version of your mod for minecraft 1.19.2 https://textup.fr/792777jb (for the crash report) can y fix it?
sorry for my english

Disclaimer

[X] I have searched for existing issues and this is not a duplicate.
[X] I have read the project's contributing guidelines.
[X] I have read and understood the project's code of conduct.

Looks like this line is wrong for 1.19.2 compared to later versions of 1.19.x since Forge saw a major version bump between 1.19.2 and 1.19.3+
Solution is to split 1.19.2 and 1.19.3+ into separate branches and recompile as separate builds.

Fixed with the release of v0.3.4 for Forge.


Crossplane update

upgrade Crossplane
Update retagger to sync core crossplane from xpkg.upbound.io as it wont be pushed to docker hub anymore after v1.11.0 (https://github.com/crossplane/crossplane/releases/tag/v1.11.0)

current update to 1.11 done


Internazionalization

It's time to refile to be more sexy :)
I'm Russian native speaker and I know deutsch.

@asiniy development can't be reliant on that. Imagine if we add a dozen languages. We now need to add a new translation. Should I keep a list of who the twelve people are who added the languages, email them and wait for each of their responses. What if one of them doesn't respond for whatever reason? I'm sure you can see how problematic that is, and what kind of burden it puts on me as maintainer.
Other gems don't do this either. Devise only has english translations, and has a list of translations to other languages in their wiki. This puts the burden on those who include the translation files, not on the maintainers of the gem.

@jnicklas you're right. Sorry for wasting your time

@asiniy absolutely no worries :)


subyt :: migrate current Subytclass towards New Style "Service" Interface from sema.bench requiring a Core process call with str args only

To align with the new style "service" interface introduced by sembench, we propose supporting a method of calling the core process using string arguments only. This enhancement will make it easier to integrate and use the core functionalities in a more streamlined and consistent manner. Below are the specific tasks and considerations for implementing this feature:

Design and Implementation:

Extend the core process interface to support invocation using string arguments.
Ensure that the new style "service" interface is compatible with the existing system and can be integrated seamlessly.
Maintain backward compatibility with existing methods of calling the core process.

Tasks

Design and Implementation:

[ ] Extend the core process interface to accept and handle string arguments in the style of the new "service" interface introduced by sembench.
[ ] Implement necessary changes to ensure smooth integration with the existing system.
[ ] Ensure backward compatibility with the current methods of invoking the core process.

relates to / depends on #72


Pylance reports errors in EJS file

Environment data

Language Server version: 2023.7.10
OS and version: macOS 13.4.1
Python version: 3.10.12

Repro Steps
Create a directory with an index.ejs file:
mkdir reproduction
cd reproduction
touch index.ejs

Open this directory in VSCode:
code .

Place the following contents in index.ejs:
<!doctype html>
<html lang="en">
  <head>
    <title>Hello, world.</title>
  </head>
</html>

Observe that the editor does not contain any errors.
Create a main.py file and open it in the editor. Switch back to the index.ejs file and wait a few seconds; you may also need to reload the editor.
Expected behavior
Pylance should not show any errors on an EJS file.

Additional information
I also have an extension installed for EJS language support: https://marketplace.visualstudio.com/items?itemName=DigitalBrainstem.javascript-ejs-support. Disabling this extension had no effect on Pylance incorrectly reporting errors in this file.
This started happening quite recently. I wasn't able to find a reference to this in any other issues, and I also couldn't find many references to it on the internet, though I did find this post on StackOverflow: https://stackoverflow.com/questions/76629174/ejs-file-full-of-pylance-errors

{ scheme: 'file', language: 'html' } added for jinja exp is causing all html document type to be passed to us. we should either define our own jinja document type with html\htm file extensions or explicitly check py/pyi/html/htm in server side.

This issue has been fixed in prerelease version 2023.7.31, which we've just released. You can find the changelog here: CHANGELOG.md


Awake couses Windows 10 to blue screen

Microsoft PowerToys version
0.85.1
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
Awake
Steps to reproduce
Have Awake active : Keep screen on, Keep on Indefinitely
✔ Expected Behavior
No Blue screen
❌ Actual Behavior
bug report of power toys and blue-screen log
Crash Report.zip
PowerToysReport_2024-10-29-21-06-08.zip
I have had awake off with the others on and my computer not crashing. the moment i turned it on the computer crashed.
Other Software
No response

I don't think Awake was the cause of the blue screen here - there is nothing it does that should really crash the system in this manner. Can you still reproduce this reliably? Can you look inside the Event Viewer and see that the Awake process caused the BSOD?


Transient props (with a $) are not available to a styled component when used in "as"

Ite seems that transient props (with a $) are not available to a styled component that is being used in "as" by a wrapper component.
Environment
styled-components @ 5.2.1
Reproduction
https://codesandbox.io/s/styled-component-transient-bug-gpzrv?file=/src/App.js
One would expect both lines to be bold and underlined.
Expected Behavior
It should be possible to pass transient props (with a $) in combination with using "as".
Actual Behavior
The properties with a transient props (with $ sign) don't get passed to the styled component that is being used in the "as" of a wrapping component.

Why would we expect this? Transient props are there so that they're never passed and only available to styling rules 🤔
In case of props being actually passed you want to use any other prop, so non-transient props without the $ prefix.
https://github.com/styled-components/styled-components/blob/08390f25fa7e353107f0a30080075104cec6426f/packages/styled-components/src/models/StyledComponent.js#L143
cc @probablyup

The library behavior is correct, transient props exist only at the styled component layer and are not forwarded. Use typical unprefixed props if you want them to go down to the next layer.

Although now that I'm thinking about it... if the target component is a styled component I think we could feasibly do this. Hmm.

@probablyup I think it is but that being said, maybe usually it does work because of folding? I think we may have not payed enough attention to as={C} behaving identically to styled(C)

@probablyup This could be changed in v6, but we did also get some issues re. folding, since that's potentially a little confusing and only works because of it. So, given that it already has unintuitive use-cases, I'd make sure that we have a test case covering the current behaviour and not changing it to keep current apps working as is.

For anyone struggling with this in v6, instead of passing $props, I pass the original prop name (without the $ prefix). I then started using:
import isValidProp from '@emotion/is-prop-valid';
styled('SOME_HTML_ELEMENT').withConfig({
    shouldForwardProp: isValidProp,
})

on the components that I wrap.


Add README explanation on how to limit the memory usage of the node

This change is

README.md line 106 at r1 (raw file):
Previously, ShahakShama wrote…
Why not?

It applies also for running the node not in a container


How to select or remove Rectangle or Oval or Line?

How to select or remove Rectangle or Oval or Line ?

Hi @winthesky ,
Totally missed this--sorry for the delayed response.
As you've likely already discovered, you cannot select or remove a shape directly (as you might be accustomed to with a diagramming/draw tool like Visio).
JMonet is a raster graphics editor which operates at the bitmap level. You can select and "erase" a region of paint; you can use the eraser tool to change pixels back into their original transparent state; or you can use the undo function to remove recent changes. But you cannot select or edit individual shapes.
Hope this helps--
Matt


Editable Remix URL In Navigation Bar.

Problem:
We want the URL bar for Remix to function a lot more like the URL bar in a browser, supporting editing and setting favourites directly from the URL bar.
Fix:
The groundwork for this change was the following:

Separating out the control for marking favourites into its own file.
Customising StringInput: Firstly to expand automatically with the content so that it imitates the label that was used previously; Secondly to visually imitate the previous look by hiding the box shadows that ordinarily are shown.

The star control needed very little additional changes as it's mostly self contained once supplied with a URL.
Some more complicated handling for various cases were added when committing the URL, as it may be invalid or non-existent in the current project.
Commit Details:

Added handler functions to RemixNavigationBar that manage updates and committing the URL to the now editable field.
Extracted out StarUnstarIcon component into its own file.
Added a small fix to updatePackageJsonInEditorState to increment the version number of the package.json file.
RemixNavigationBar now uses StringInput to control the URL.
StarUnstarIcon also included in RemixNavigationBar.
Added a growInputAutomatically option to StringInput which creates an invisible span which is used to gauge the size that the input field should be.
Added includeBoxShadow option to StringInput so that the box shadows can be optionally hidden.
testId is made mandatory in HeadlessStringInput.

Manual Tests:
I hereby swear that:

[x] I opened a hydrogen project and it loaded
[x] I could navigate to various routes in Preview mode

Fixes #5325

(I'll make a follow-up ticket for this) the text field has broken copy-paste, which I think is pretty important as URL writing is frequently done using cut-copy-paste (one of our global event listeners seem to be the culprit)


Update rust ci version to be explicitly numbered

What's the rationale for this? We've been doing quite fine with using the latest stable version.

As you can see from the now failing build of this PR, the main branch is failing CI because clippy lints are very not stable between Rust versions. I think it's a frustrating contributor experience to first have to fix unrelated clippy lints before getting your change in, and so this is a proposal to switch to upgrading the Rust version used in CI manually.

I think the cost of having a slightly older version of Rust running in CI is very low, and the cost of having the build randomly break once a month is somewhat higher. Although it sounds like maybe you prefer auto-updating to the latest stable?

I'm in favor of pinning a version for CI. (We can also run latest stable, but not have it be required for merging.) With the current level of activity on this repo, a significant fraction of PRs get blocked on clippy complaining about issues not related to that PR.

What you're saying has some merit, but unfortunately it doesn't fully resolve the issue. It just shifts it.
If the CI is pinned to an older version, then all contributors also need to be using an older Rust version on their own machines. I think the Rust culture is heavily biased towards people doing rustup update very frequently. So contributors with newer Rust versions would either not run clippy at all (which we don't want) or have their clippy fail and we would be less aware because the CI would still be green.
The issue of CI failing is still real though. The solution I've been moving towards is solving clippy issues with the beta toolchain. This very same issue for example was resolved during beta for Druid in druid#2363.

There is another issue with pinning the CI. It doesn't actually introduce a brand new issue, but it greatly increases its scope.
Imagine a PR that is waiting for review for some time. As long as the modified files don't conflict with changes in main, this PR branch doesn't need to be rebased on main. That means the CI for this PR is always running 1.68.
Meanwhile 1.69 has come out and main has an updated CI config.
Because there is no conflict with the PR branch, all changes to the PR continue to run with clippy 1.68. Once merged, suddenly main will be broken.
If the CI config has stable, then any fresh trigger of CI will actually use 1.69 and catch the new errors before merge. Though yes there is still a chance of main breakage if the PR is sitting without changes for a long time and then merged without rerunning the CI (e.g. due to a new commit).

If the CI is pinned to an older version, then all contributors also need to be using an older Rust version on their own machines.

Could you elaborate on this? I don't see why it's a problem: if I'm using a newer rustc than CI, I might get a few clippy warnings and then I have the option to fix them or not. And if the clippy warnings are in code that I'm not touching, I can fix and PR them later instead of having to fix them first.
The other thing that happened to me fairly regularly in druid-shell is that I'll miss clippy warnings because they're on a different platform or feature-gated out. I used to have a git hook to run clippy on all targets, but I got rid of it because it took lots of time and disk space...

I might get a few clippy warnings

It's not uncommon to have 10 warnings, sometimes even 30. A real warning that is part of your new code is among them. I don't think it's trivial to see which are which. You have to read through the output every time or use some sort of IDE that does squigglies.

I used to have a git hook

That's also an important point. These hooks don't differentiate between your code and old code, they just treat all warnings the same.
I'm not saying that it's impossible, but I am saying it would be a brand new annoyance to deal with.

Ultimately my perspective here is that main should pass clippy without errors on the latest stable version. Pinning just hides the symptoms. This doesn't mean that main can be left to rot, like happened here.
I would advocate for a more systematic approach across repos. A train schedule based on the Rust release schedule. Ensuring that main passes beta clippy e.g. 1 week before that beta is promoted to stable. A proactive approach based on policy, not a reactive approach based on last minute breakage discovery.

How about a compromise here? A proactive, train-like upgrade schedule based on Rust releases sounds like a good idea, and I'd be in favor. But it would be great if, were we to slip and take an extra couple of weeks to do the fix, we don't break the main CI build for everybody. Perhaps we could keep the upgrade schedule as you propose, but rather than upgrading and releasing the week before the Rust release, we upgrade and release within a couple days after the Rust version bumps. The version of Rust would be explicitly listed in CI as this feature updates, and the scheduled release would bump this version number as well as fix any associated clippy lints.

Because there is no conflict with the PR branch, all changes to the PR continue to run with clippy 1.68. Once merged, suddenly main will be broken.

I think this is a valid concern. Perhaps we should use commit queues or bors or something like that?

How about a compromise here?

Perhaps we should use commit queues

Maybe. I'll allocate some time for thinking this stuff through more thoroughly on Monday, including looking at merge queues etc. Then I can give a more informed reply.

Sounds good, thanks for considering all this!

This is the kind of thing that might be worth bringing up at the office hours.

I've been looking into the merge queues and initial impressions are promising. I haven't found as much time to think about this as I'd like, but hopefully that will happen soon. It does look like we might be able to change policies in a way that will alleviate the issues of pinning a version.
Unfortunately we ran into technical difficulties during office hours today, so couldn't talk about it in any depth. Will try again next week to bring up this topic for discussion and meanwhile I'll continue gathering my thoughts.

Sounds good to me! How does this look?


Add option to enable all compiler warnings in GCC/Clang

ENABLE_ALL_WARNINGS option will add -Wall -Wextra flag to all CMake targets, enabling all compiler warnings from GCC/Clang. Also, the Jenkins CI will now perform Linux builds with ENABLE_ALL_WARNINGS turned on.

Codecov Report

Merging #5897 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5897   +/-   ##
=======================================
  Coverage   81.16%   81.16%
=======================================
  Files          12       12
  Lines        2835     2835
=======================================
  Hits         2301     2301
  Misses        534      534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c40f4a...73f84f8. Read the comment docs.


Implement node-run-script to paketo-buildpacks/node-run-script

Summary

This implements the specifications for the node-run-script buildpack as noted in the RFC and the corresponding implementation issue.
Use Cases

As the RFC mentions, when building node framework apps like Angular, Vue, or React, there are scripts that are usually ran to build the frameworks into static resources. Additionally, any other arbitrary scripts that may be desired to run by users is currently impossible without the use of stacking commands onto the "start" script, since that is a script that can get run with the npm/yarn start buildpack.
Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

LGTM. I'll wait for @thitch97 to review and merge


Version 3.0.0 crashes Homebridge v1.3.1

When updating homebridge-wiz-lan to 3.0.0, homebridge crashes on restart. The following log appears:
Started Homebridge v1.3.1 with PID: 31751
Initializing HAP-NodeJS v0.9.2...
[26/02/2021, 15:42:44] Loaded config.json with 0 accessories and 2 platforms.
[26/02/2021, 15:42:44] Loaded 1 cached accessories from cachedAccessories.
[26/02/2021, 15:42:44] ---
[26/02/2021, 15:42:51] Loaded plugin<EMAIL_ADDRESS>[26/02/2021, 15:42:51] Registering platform 'homebridge-config-ui-x.config'
[26/02/2021, 15:42:51] ---
[26/02/2021, 15:42:52] Loaded plugin<EMAIL_ADDRESS>[26/02/2021, 15:42:53] Registering platform 'homebridge-rpi.Lib'
[26/02/2021, 15:42:53] Registering platform 'homebridge-rpi.RPi'
[26/02/2021, 15:42:53] ---
[26/02/2021, 15:42:53] Loaded plugin<EMAIL_ADDRESS>[26/02/2021, 15:42:53] Registering platform 'homebridge-wiz-lan.WizSmarthome'
[26/02/2021, 15:42:53] ---
[26/02/2021, 15:42:53] Loading 2 platforms...
[26/02/2021, 15:42:53] [Config] Initializing config platform...
[26/02/2021, 15:42:53] [Config] Running in Service Mode
[26/02/2021, 15:42:54] [WizSmarthome] Initializing WizSmarthome platform...
[26/02/2021, 15:42:54] [WizSmarthome] Loading accessory from cache: a8bb50d63554
[26/02/2021, 15:42:56] [homebridge-wiz-lan] This plugin generated a warning from the characteristic 'Model': characteristic value expected string and received undefined. See https://git.io/JtMGR for more info.
[26/02/2021, 15:42:56] [homebridge-wiz-lan] This plugin generated a warning from the characteristic 'Model': [Model] characteristic must have a length of more than 1 character otherwise HomeKit will reject this accessory, ignoring new value. See https://git.io/JtMGR for more info.
[26/02/2021, 15:42:56] [homebridge-wiz-lan] This plugin generated a warning from the characteristic 'Serial Number': characteristic value expected string and received undefined. See https://git.io/JtMGR for more info.
[26/02/2021, 15:42:56] TypeError: Cannot read property 'includes' of undefined
    at /usr/local/lib/node_modules/homebridge-wiz-lan/src/accessories/WizBulb/index.ts:19:57
    at Array.some (<anonymous>)
    at Object.is (/usr/local/lib/node_modules/homebridge-wiz-lan/src/accessories/WizBulb/index.ts:19:31)
    at /usr/local/lib/node_modules/homebridge-wiz-lan/src/wiz.ts:54:63
    at Array.find (<anonymous>)
    at HomebridgeWizLan.initAccessory (/usr/local/lib/node_modules/homebridge-wiz-lan/src/wiz.ts:54:35)
    at HomebridgeWizLan.configureAccessory (/usr/local/lib/node_modules/homebridge-wiz-lan/src/wiz.ts:72:10)
    at /usr/local/lib/node_modules/homebridge/src/bridgeService.ts:317:25
    at Array.filter (<anonymous>)
    at BridgeService.restoreCachedPlatformAccessories (/usr/local/lib/node_modules/homebridge/src/bridgeService.ts:277:69)
[26/02/2021, 15:42:56] Got SIGTERM, shutting down Homebridge...

Downgrading back to 2.2.0 fixes this.

same here

I just released 3.0.1 which should hopefully fix this. Let me know if it does!

Yes. The crash is gone. Unfortunately the existing bulbs from V2 did not work after the update. I had to reset the cached accessories, afterwards everything works fine! Thanks for your work on V3! I love it that the network usage is lowered!


Added additional custom attributes to handle "tap", "press", and "hold" events using hammer.js

self-explanatory. Check README.md for details on press vs hold.

@nderscore thank you so much for the contribution. This is released with 0.1.0.

@benib I hope it helps somebody else :grinning:


Request: a new version release

I see that the last available gem version was released in January 2013: https://rubygems.org/gems/audite
Could you release a new version with all the changes from the last year?
Thank you!

Here we go: https://rubygems.org/gems/audite/versions/0.4.0

Well that's just lovely. Thank you!


Ability to share state of read articles across Vienna installations

Hi, is there a way to import/export the state of the articles I've read?
Example:

I use Vienna in laptop X and laptop Y
I use laptop X and receive a notification for a new article "Men go to Mars". Total articles to read counter is at 1.
I read the article on laptop X. Total articles to read counter is at 0.
I close laptop X and go home.

Later on..

I open laptop Y at home.
I receive notification for a new article "Men go to Mars"...but I've already read this article on laptop X..

Hope the example above explains it. I use Vienna on various laptops and I currently import/export my subscriptions via a couple of AppleScript scripts (while I wait for #711 to allow me to do so differently). But every time I change my subscriptions I receive the same notifications, so I have to "Mark all as read" all the time.
Thank you very much.

Hi!
Hrm no there isn't, but it's a good idea. Let's set this as a feature request and see if other people upvote it.

Syncing with an Open Reader Server would take care of your issue.

I agree with @DavidMunch. There are some ad supported OpenReader servers. I'll close the issue for now.


Transparent background doesn't seem to work with arrow labels

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Arrow labels have a background picker. While it has an option to set background color to "none", it is, in fact, set to white.
To Reproduce

Create an arrow between two elements, add a text label to it (enter, type something, click elsewere to save);
Open the label for editing again, open bg color picker;
Select transparent (none), apply;
Close the label editing mode.

Expected behavior
The label should have no background color.
Screenshots

Environment:

draw.io version: 21.3.6
OS: Windows 10 x64
Browser: Vivaldi 6.0.2979.15 (stable channel, 64 bit); also reproduced in Firefox 111.0.1 (64 bit)

Works for me. Please attach a test case.

Well, here it is, but it seems the background change isn't applied at all

Could you attach a diagram where you've successfully applied transparent background to a label? I'll test at least whether it's displayed correctly for me.
Just in case, I've also saved it as .drawio and .xml, and the result is the same, but GitHub supports attaching neither of these.

Here is an example. Uncheck background color in the text section:

Right, what you've created is a separate text element. I'm talking about an arrow label

Please attach a test case. (Use Export as URL and attach the link.)

Here

There (Select the edge, go the Text tab, uncheck Background Color.)

Right, thanks! But closing this is not a good idea: I've described the expected behavior, and the actual one which definitely is a bug (the color picker has the transparent option, but applying it doesn't provide what's expected). It's great that I now know the workaround, but for UX it's definitely better to either make transparent option to work as expected, or remove it from there.

Happy to reopen this, but again, it works for me, and without the reproduction steps or a test case we can't fix this.

Ah, that's because you don't follow the steps to reproduce like I've described them. I've checked: indeed, if I don't enter the edit label mode, like you do in the gif, the picking works. But if you follow

Open the label for editing again, open bg color picker;

you'll find that (unlike for other colors!) picking transparent in this mode doesn't work.

In editing mode, the background color is changed for the current text selection.

Oh, I see, that's not trivial. Thaks for the explanation!


Type definitions only for development

@types are only needed for development. Installing them as dependencies installs them on every project that uses typedocs which may lead to duplicate identifiers if @types isn't used in the project or if @types expose functions that are not really available.

No, this was already correct. If we're using them as a dependency, the type must also be a dependency otherwise you need to re-install them all again. If there's an issue with the definition causing duplicates, that needs to be fixed in DefinitelyTyped first.

That can't be fixed with DefinitleyTyped because I'm not using @types but still typings. And that's why there are duplicate definitions. Typings are not needed for runtime!

@DaSchTour I didn't say they are needed for runtime. But they are needed for sub-dependencies that are exposed transitively. I can feel your pain, I still use Typings myself too because @types is still not complete, but saying the solution is to remove all dependencies is even more wrong. Have you tried changing types in tsconfig.json?

@blakeembrey I still don't get why @types are added to dependencies while they are not needed at runtime. Typings are for development only. NPM-Package should be like a binary. Just executable. So there is no need to add type definitions as there also shouldn't be any typescript left for runtime.

I'm not sure you understand the difference here then. devDependencies would mean that you have to install the @types. Again, I said nothing about runtime. It's needed for TypeScript compilation.

But I don't want and don't need to compile typedoc package so I don't want the typings.

Again, this is not about compiling the typedoc package. This is for other people using it programmatically.


Fix flaky test: testInstantTCPConnectionResetThrowsError

Motivation:
Running this test in a loop will fail. It's understandable because the test itself is trying to trigger a race condition. We wouldn't see this on our PR CI because it only runs on Darwin.
Modifications:
Extend the test server used in the test with another promise that allows the test to wait for the channel to become active before continuing with the rest of the test.
Result:
Can now run this test repeatedly without failure.

Actually, hold up. This didn't actually make it go away, just a lot more rare. Used to fail ~1:100, now it's ~1:3000.


Error of load_model : AttributeError: 'float' object has no attribute 'tolist'

AttributeError: 'float' object has no attribute 'tolist'
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Mac OS 10.14.4
TensorFlow backend (yes / no):  yes
TensorFlow version:  1.13.1
Keras version:  2.2.4
Python version:  3.6.7
CUDA/cuDNN version:  None
GPU model and memory:  None

Code to reproduce the issue
import tensorflow as tf
from keras.models import load_model
k_model = load_model( 'iter_57000_model.h5', custom_objects={'tf':tf})
Other info / logs
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/saving.py", line 419, in load_model
model = _deserialize_model(f, custom_objects, compile)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/saving.py", line 225, in _deserialize_model
model = model_from_config(model_config, custom_objects=custom_objects)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/saving.py", line 458, in model_from_config
return deserialize(config, custom_objects=custom_objects)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/layers/init.py", line 55, in deserialize
printable_module_name='layer')
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/utils/generic_utils.py", line 145, in deserialize_keras_object
list(custom_objects.items())))
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/network.py", line 1032, in from_config
process_node(layer, node_data)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/network.py", line 991, in process_node
layer(unpack_singleton(input_tensors), **kwargs)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/engine/base_layer.py", line 457, in call
output = self.call(inputs, **kwargs)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/keras/layers/core.py", line 687, in call
return self.function(inputs, **arguments)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/pytorch2keras/constant_layers.py", line 27, in target_layer
return tf.constant(value.tolist(), shape=value.shape)
AttributeError: 'float' object has no attribute 'tolist'

@TFDeeplearner There is no bug with load_model. Please check the code below (from keras website).

import keras

mnist = keras.datasets.mnist

(x_train, y_train),(x_test, y_test) = mnist.load_data()
x_train, x_test = x_train / 255.0, x_test / 255.0

model = keras.models.Sequential([
  keras.layers.Flatten(input_shape=(28, 28)),
  keras.layers.Dense(128, activation='relu'),
  keras.layers.Dropout(0.2),
  keras.layers.Dense(10, activation='softmax')
])

model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])

model.fit(x_train, y_train, epochs=5)
model.evaluate(x_test, y_test)

#save model
model.save('my_model.h5')  # creates a HDF5 file 'my_model.h5'
del model  # deletes the existing model

# returns a compiled model
# identical to the previous one
loaded_model = load_model('my_model.h5')
loaded_model.evaluate(x_test, y_test) # the results are same as with the original model

May be there is something wrong how you save your model. Thanks!


amp-ac channel in amphtml.slack.com workspace

I suggest we start a private channel (#amp-ac) in the amphtml.slack.com workspace. Any thoughts on that one way or another?
(If you need an invite to that workspace, it looks like I have (everyone has?) privileges to do so, let me know)

cc @ampproject/ac

I don't know what the practice is, here, but we probably want to keep it open, as I suspect the WG have theirs. Let's just check with @mrjoro what the practice is here, and follow along (including for naming consistency).

(If you need an invite to that workspace, it looks like I have (everyone has?) privileges to do so, let me know)

I invited everyone.

The Working Group channels are open so that people who are interested can follow along/participate.  We looked into whether we could have "anyone can view, only members can post" channels, but it appears that Slack doesn't support that.

@mrjoro any thoughts on channel naming for consistency purposes?

I don't think there's a pattern for non-wg channels.  amp-ac sounds fine to me.

I went ahead and created #amp-ac

Thanks, @levidurfee. Can you announce it on the mailing list, please?


Mempool: impose maximum capacity

Currently our mempool can grow without bound. We should impose a limit.
If we want this limit to be useful as backpressure, then perhaps calls to add more transactions should be blocking..?

For node -> node tx submission, blocking is fine. For local -> node it's probably fine too but we might want to add a timeout, and that could be done locally in the submitting thread. So overall, fine if it blocks.


Incorrect routes mapped for apps with context paths

Note: I'm currently using the Staging version to work around #58.
Here's my manifest:
applications:
- name: my-app
  routes:
  - route: my-hostname.my.domain/my/path

where the hostname is my-hostname, the configured domain is my.domain and the context path is /my/path.
After BGD, this is the output of cf app my-app:
name:   my-app
routes: my-app-new.my.domain, my-app-new.my.domain/my/path, my-hostname.my.domain

Instead of the expected single route, I see 3 different ones.

The specified route my-hostname.my.domain/my/path is not mapped at all.
Instead, the non-context route my-hostname.my.domain is mapped. This may break other apps which map to the generic route.
The my-app-new route is now blocked by this app. If we were to run BGD for the same app in a different space (with the same domain), it would fail with a "route already in use" error.

faced the same problem #61

we have the same issue -we try several workarounds
e.g. remove the routes property from the manifest.yml --> the creation of the new route was without the contextual path and the application
Creating app -new in org myOrg / space mySpace  as ****...OK
Creating route -new....OK
Binding -new. to -new... OK
Uploading -new...
Removing route -new. from app -new in org myOrg / space mySpace  as ****... OK
Deleting route -new.... OK
Creating route myHost. for org myOrg / space mySpace  as ****... OK - why?
Adding route myHost. to app -new in org myOrg / space mySpace  as ****... OK
Renaming app  to -old in org myOrg / space mySpace  as ****... OK
Renaming app -new to  in org myOrg / space mySpace  as ****... OK
Removing route myHost./myPath from app -old in org myOrg / space mySpace  as ****... OK
Deleting app -old in org myOrg / space mySpace  as ****... OK


Create a UUID for every type or type instance which was created.

Until now we store all instances (of any type) in a std::vector. We also store all types name (by std::string) in an std::unordered_map.
Now we want to store them by UUID.
Since we've added stduuid (see https://github.com/inexorgame/entity-system/issues/15 and https://github.com/inexorgame/entity-system/commit/6689d7016307e0e6000a81fd6f1dd41f8be03596) we can create a UUID every time we create a type of an instance.

We will implement this by creating a EntSysGUID class!
(In there we can migrate to any other GUID library if neccesary.)
/// TODO: Fix conan package manager for dependencies!
/// This file will not be contained in the repository itself.
/// https://github.com/graeme-hill/crossguid
#include <crossguid/guid.hpp>

class EntSysGUID
{
   private:
   // Use C++11 class member initialisation instead of constructor.
   xg::Guid entsys_guid = xg::newGuid();

   // Make this protected so it can be inherited
   protected:

   EntSysGUID() {  }

   xg::Guid get_guid() const
   {
      return entsys_guid;
   }

}

We can then inherit this class wherever we need it.

This feature has been implemented. See: https://github.com/inexorgame/entity-system/commit/907face3efe83adccf3a61d5e697df46468b7d72.
Because GUIDBase is the base class for all the other classes which use GUIDs, we can switch our GUID library easily later on.


Remove version: Tencent.QQMusic version 18.47

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dldir1.qq.com/music/clntupate/QQMusic_Setup_1847.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 911)


fix(layout): properly apply desktop-only to toc component

Summary
Fix a bug where DesktopOnly isn't properly applied to the TableOfContents component.
Preview

Before

Mobile

Desktop

After

Mobile

Desktop

Just a thought, it might be more comprehensive to edit quartz/styles/base.scss to add !important to the display: none line?
.desktop-only {
  display: initial;
  @media all and ($mobile) {
    display: none !important;
  }
}

While experimenting, I noticed the Explorer component has similar issues as well.
(Was planning to open a PR for this earlier, but got a seemingly condescending comment from a maintainer for a previous PR so did not propose :)

Just a thought, it might be more comprehensive to edit quartz/styles/base.scss to add !important to the display: none line?
.desktop-only {
  display: initial;
  @media all and ($mobile) {
    display: none !important;
  }
}

While experimenting, I noticed the Explorer component has similar issues as well.
(Was planning to open a PR for this earlier, but got a seemingly condescending comment from a maintainer for a previous PR so did not propose :)

I'll look into it. I suspect the desktop-only/mobile-only don't cascade properly on the non-default layout. I'm would prefer a more systematic solution, as the table of contents component is likely not the only component with this issue. I'm not a big fan of using !important if it can be avoided.

Closing this as it seems like the issue was resolved in #1502.


Unauthorized request from ... This may happen because of a conflicting browser extension to intercept HTTP requests

I would like to load build of my reactjs application in webveiw.
My code is:
import React, { Component } from 'react';
import { SafeAreaView, StyleSheet, Text, View } from 'react-native';
import { WebView } from 'react-native-webview';

const Index: React.FC = () => (
	<SafeAreaView style={{ flex: 1, width: '100%' }}>
		<WebView
			source={require('./resources/index.html')}
			javaScriptEnabled
			domStorageEnabled
			allowUniversalAccessFromFileURLs
			style={{ flex: 1 }}
		/>
	</SafeAreaView>
);

export default Index;

After start I am getting an error:
Error: Unauthorized request from http://<IP_ADDRESS>:8081. This may happen because of a conflicting browser extension to intercept HTTP requests. Please try again without browser extensions or using incognito mode.
    at remoteDevtoolsSecurityHeadersMiddleware (C:\Coding\mobile\node_modules\@expo\dev-server\build\middleware\remoteDevtoolsSecurityHeadersMiddleware.js:12:10)
    at call (C:\Coding\mobile\node_modules\connect\index.js:239:7)
    at next (C:\Coding\mobile\node_modules\connect\index.js:183:5)
    at suppressRemoteDebuggingErrorMiddleware (C:\Coding\mobile\node_modules\@expo\dev-server\build\middleware\suppressErrorMiddleware.js:17:3)
    at call (C:\Coding\mobile\node_modules\connect\index.js:239:7)
    at next (C:\Coding\mobile\node_modules\connect\index.js:183:5)
    at C:\Coding\mobile\node_modules\@expo\cli\build\src\start\server\middleware\ContextModuleSourceMapsMiddleware.js:21:13
    at call (C:\Coding\mobile\node_modules\connect\index.js:239:7)
    at next (C:\Coding\mobile\node_modules\connect\index.js:183:5)
    at middleware (C:\Coding\mobile\node_modules\@expo\cli\build\src\start\server\middleware\ExpoMiddleware.js:67:24)

What is wrong with my code?
"expo": "49.0.6",
"react-native-webview": "^13.6.0",

could you try like:
import React, { Component } from 'react';
import { SafeAreaView, StyleSheet, Text, View } from 'react-native';
import { WebView } from 'react-native-webview';

const webSite = require('./resources/index.html');

const Index: React.FC = () => (
	<SafeAreaView style={{ flex: 1, width: '100%' }}>
		<WebView
			source={webSite}
			javaScriptEnabled
			domStorageEnabled
			allowUniversalAccessFromFileURLs
			style={{ flex: 1 }}
		/>
	</SafeAreaView>
);

export default Index;

@zaferatli Same problem.

I have the same problem, any news?

I have the same problem, any news?

Hi sir did you fix ? @andre-ols

Hi sir, I have fixed it. It's due to one my fonts didn't loaded correctly
as expected dynamically. Thanks.
On Mon, Mar 11, 2024, 6:55 PM André Oliveira Silva @.***>
wrote:

I have the same problem, any news?
Hi sir did you fix ? @andre-ols https://github.com/andre-ols
To solve the issue, I employed a method where I built the application into
a single HTML file. By doing so, since the HTML doesn't need to access the
file system to read the JavaScript, everything is encapsulated within the
HTML itself, ensuring the webview operates smoothly.
In my particular case, as I was using Vite, I utilized the Vite plugin
called vite-plugin-singlefile
https://www.npmjs.com/package/vite-plugin-singlefile.
—
Reply to this email directly, view it on GitHub
https://github.com/react-native-webview/react-native-webview/issues/3165#issuecomment-1988436471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BB7VKYQIYNF23NR6YDPDWWTYXWWDVAVCNFSM6AAAAAA5IFIKE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYGQZTMNBXGE
.
You are receiving this because you commented.Message ID:
@.***
com>

Hi sir, I have fixed it. It's due to one my fonts didn't loaded correctly as expected dynamically. Thanks.
…
On Mon, Mar 11, 2024, 6:55 PM André Oliveira Silva @.> wrote: I have the same problem, any news? Hi sir did you fix ? @andre-ols https://github.com/andre-ols To solve the issue, I employed a method where I built the application into a single HTML file. By doing so, since the HTML doesn't need to access the file system to read the JavaScript, everything is encapsulated within the HTML itself, ensuring the webview operates smoothly. In my particular case, as I was using Vite, I utilized the Vite plugin called vite-plugin-singlefile https://www.npmjs.com/package/vite-plugin-singlefile. — Reply to this email directly, view it on GitHub <#3165 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB7VKYQIYNF23NR6YDPDWWTYXWWDVAVCNFSM6AAAAAA5IFIKE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYGQZTMNBXGE . You are receiving this because you commented.Message ID: @. com>

Could you describe the process that resulted in solving your problem? Other people may face similar problems.


Dexsearch: fix error reply lag

By having return here, the line room.update(); never happens, so it gives the illusion that the server is lagging when it's probably not.

Going to update this, I found more bugs with other commands within this plugin

Thanks!

np


Rails 5.2 support

Any news?

Got tired of waiting and rolled my own implementation (for SimpleForm). Anyone who uses SimpleForm, you can use this gist:
https://gist.github.com/gregblass/b43ac32c85d666139f1b13ee081d8513


Add to .gitignore line "docs/reference/generated/"

Sphinx documentation
docs/_build/
docs/reference/generated/

merged


Drag/Scroll behaviours arnt registered if a TextInput has focus.

Steps to reproduce
Many apps that have scrollable views become inoperable if the cursor enters a text input.
Can be reproduced with a simple jetpack compose view consisting of a TextField and scrollable column/view. The second view will be scrollable until the TextField takes cursor focus. Scroll functionality can only be resumed by shifting focus outside of the TextField (Ctr+Tab) then clicking outside the application, then bringing the application back into the foreground.
The same application running on an mobile device or AVD emulator doesnt suffer from the gesture swallowing and this seems locallised to WSA.
✔ Expected Behavior
Drag/Scroll behaviours continue to function regardless of TextInput focus
❌ Actual Behavior
Drag/Scroll behaviours become inoperable after TextInput focus.
Other Software
No response
Have you specified the version of Windows Subsystem for Android under Milestone?

[X] I have set this issue's milestone

Hi, could you please let us know the subsystem version number you're running?

We'll investigate and follow up on this. Thank you for bringing this to our attention!

For context, WSA typically emulates mouse input as touch input for application compatibility, but if a text field has focus, we temporarily disable the touch emulation to ensure text highlighting behaves appropriately.  If you drag a finger in a text field on your phone, you'll notice it moves a magnified text cursor rather than highlighting the text, which isn't appropriate for mouse.
Therefore, it is expected that dragging with mouse to pan doesn't work while a text field has focus.  However, we could probably fix scrolling while a text field has focus without impacting text highlighting since scroll input is handled separately from cursor input.  Can you share a minimal repro app (either source or apk)?

I had an hour so I threw this demo together. Its a bit sloppy but it demontrates the issue well enough.
https://github.com/libbaz/wsafocus-demo

Thanks for providing a repro.  I updated WSA to enable our emulated touch scrolling while text fields have focus, which fixed scrolling in your scroll view while your text field is focused.  This fix should be available in WSA preview builds early next year.  In the meantime, you can make this scenario work by handling MotionEvent.ACTION_SCROLL events in your app.

Fixed in Build 2211.


Left outer join isn't translated correctly

My query is:
from t1 in Table1
from t2 in Table2.Where(t => t.MyField == t1.MyField).DefaultIsEmpty()
select new
{
    Id = t1.Id
}

EF Core translate this to
SELECT [t1].[Id]
FROM [Table1] AS [t1]
CROSS APPLY (
    SELECT [t0].*
    FROM (
        SELECT NULL AS [empty]
    ) AS [empty0]
    LEFT JOIN (
        SELECT [t20].*
        FROM [Table2AS [t20]
        WHERE [t20].[MyField] = [t1].[MyField]
    ) AS [t0] ON 1 = 1
) AS [t3]
ORDER BY (SELECT 1)
OFFSET @__p_0 ROWS FETCH NEXT @__p_1 ROWS ONLY

while EF6 correctly translates:
SELECT [t0].[Id] AS [Id]
FROM [Table1] AS [t0], [Table2] AS [t1]
WHERE [t1].[MyField] = [t0].[Myfield]

Further technical details
EF Core version: 1.1.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2015 & LinqPad

Putting on the backlog to look at improving the query.

Any progress on this issue?


Swift Error Enum for Storage

Initial thoughts about a Swift Error enum for Firebase Storage.
Thoughts about this approach and recommendations for next steps appreciated.
Should we add localizedDescription implementations like https://www.swiftbysundell.com/basics/error-handling/

@ryanwilson Let me know what you think before I write up an API proposal

Since it looks like adding Swift error codes will require a breaking change release. I'm going to merge this to a storage-v9 branch and investigate merging FirebaseStorage and FirebaseStorageSwift to a single public library before continuing with the error code implementation.


Fix SMS confirmation not sending

verified with test env

Fixed in https://github.com/ethyca/fides/pull/2499


Updating scrollbars options doesn't work

monaco-editor version: 0.21.3
Browser: Chrome 88
OS: macOS
Playground code that reproduces the issue:
The following code is supposed to make scrollbars behave like "auto" rather than "visible" after a couple of seconds, but it just doesn't work.
var editor = monaco.editor.create(document.getElementById("container"), {
	value: "// First line\nfunction hello() {\n\talert('Hello world!');\n}\n// Last line",
	language: "javascript",
    scrollbar: {
        horizontal: 'visible',
        vertical: 'visible'
    }
});
setTimeout(function() {
	editor.updateOptions({
        scrollbar: {
            horizontal: 'auto',
            vertical: 'auto'
        }
	});
}, 2000);

This may look like something so minor that's not worth addressing, but I'm using Monaco in an Electron app that can detect when the user changes the visibility status of their scrollbars at the system level under macOS, if I can't update how scrollbars behave in Monaco too I can't provide a good consistent experience to my users in this regard.

Following


script v1.6 fails under Alpine 3.7 with permission denied

Hi,
I am running the script under Alpine 3.7, and I hit the following issue:
root@host# ls -1 dind-cluster-v1.6.sh
dind-cluster-v1.6.sh
root@host# docker run --privileged -v $PWD:/mnt -it alpine:3.7 /bin/sh
root@container# apk update && apk add curl bash docker
root@container# ./dind-cluster-v1.6.sh up
[...]
No resources found
* Setting cluster config
./dind-cluster-v1.6.sh: line 615: /root/.kubeadm-dind-cluster/kubectl: Permission denied

If I do a chmod +x on it, it then works fine.

Closing as we do not support 1.6 anymore. If the issue appears on newer versions feel free ro reopen it.


Automate - Retirement - Allow VM's with unknown power state to retire.

This change in the retirement process will allow VM's with an unknown power state to proceed past the check_pre_retirement automate method to the next state. That should allow retirement to fall through and retire even if there is no ems.
Modified check_pre_retirement and amazon_check_pre_retirement methods to continue if power state is unknown or if ems is nil.
Added a test for ems nil and ems.try in log messages was removed.
https://www.pivotaltracker.com/story/show/130661861

@tinaafitz
Please Review

@billfitzgerald0120 Can we add some tests?

@tinaafitz
Added tests
Please Review

@billfitzgerald0120 @tinaafitz
Does this only apply to Amazon, do we need this for other providers?

@tinaafitz
Please Review

@mkanoor
Amazon is the only vendor with a specific check_pre_retirement method.

@tinaafitz
Please Review

@billfitzgerald0120 Looks good.
@mkanoor Please review.

Euwe Backport details:
$ git log -1
commit 33723eeac7b05319e2b3d3ac41b795b742cefc90
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Thu Oct 20 12:13:33 2016 -0400

    Merge pull request #11261 from billfitzgerald0120/retire_unknown_power_state

    Automate - Retirement - Allow VM's with unknown power state to retire.
    (cherry picked from commit e51ec5bbaae765fe83856399cbd956c5b9879e7b)


X-axis labels for character variables

It seems that for character variables with very few unique values, the values are displayed to the right of the graphic in a horizontal bar chart. However, when there are more unique values, the chart becomes vertical (which is nice!), but there are no labels for the x-axis. This may be better than only having the pop-up description.
As an example see the following dataset's "site" variable:
dat <- tibble(a = rep('01', 100),
              b = sample(c('02', '03', '07', '09'), 100, replace = T),
              c = sample(1000:9999, 100, replace = T)) %>%
  mutate(id = glue("{a}-{b}-{c}"),
         site = sample(c("bost", "nyc", "phil", "chic", "la", "sd", "sf"), 100, replace = T)) %>%
  select(id, site)

Labels are tricky since they will start to overlap once N is large enough.  Instead, we've set it up so the user can actually specify the point when a chart flips from horizontal to vertical bars using this setting. Default is 5 (which is maybe a little low), but one could definitely bump that up a bit if there are variables where you want the labels shown.


Update the build process for templates to create an NPM package of the templates.

PR Checklist
Update the build process for templates to create an NPM package of the templates.
after this is done, will need to update the release pipeline to add a stage to grab the package output part and publish it to the msazure package repo that the InsightsPortal project uses to build. all of the template content will then be published via the hosting service and will be updated on the portal's standard schedule with the portal's hotfix process.
the template content will be treated the same way the portal's iframes are currently, where a specific package version is used in the deployment.
simplified some of the current script was change the way the localized repos were sync'd so that the whole language specific repo gets synced at once with en-us to make sure all the required content is there, instead of doing it piece by piece as things are enumerated
this build:
https://github-private.visualstudio.com/microsoft/_build/results?buildId=1423&view=results
has the new artifact:

which is a 9mb npm package, compared to the current language specific file artifact which is 18x16mb processed files deployed to storage and synced with alm service.

although it looks like my changes that require msazure for the official build might have broken the CI build too, as now it needs auth to get that specific package (which the CI build does not need)

i've queued a build of this branch to make sure it will succeed before i actually complete the PR.


Final Page Report has incorrect field labels for MINIMUM safe distances

Each field labeled "Maximum Safe Distance" should really be "Minimum Safe Distance

Resolved in 91eaa7f


Expose loadConfig from CLI for use from external tools

Currently only the CLI version of JSHint loads the .jshintrc file.
It would be nice if the config file would still be respected when jshint is used from tools like Grunt.
If  loadConfig function was  exposed, that would be possible.
And I can't just use grunt.file.readJSON() because .jshintrc isn't strictly a JSON file since it may contain comments (which I think is a great idea).
Please see related discussion here: https://github.com/gruntjs/grunt-contrib-jshint/issues/2

... .jshintrc isn't strictly a JSON file since it may contain comments (which I think is a great idea).

Is this publicly documented somewhere? I just want to make sure using comments in my .jshintrc files won't have side-effects in the future and it will be mentioned in changelog if something is changed.


SA1122: Missfires in switch statement

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/56654921e587211db0acc725ff33404dd623f720/documentation/SA1122.md?plain=1#L20
This rule is not correct in every context.
If we have code like
string foo = ...;

var bar = foo switch
{
    "" => ..., // this "" will trigger the SA1122 rule
}

But replacing it with string.Empty causes the error CS0150

Duplicate of #3028


field->pointIsInDefenceArea is broken

I just noticed that the test does not pass. I checked the values and it appears the test is right and the implementation is wrong.

fixed in #449


Fix major esm inconsistency

Fix major inconsistency in v1.0.0-beta.2
NPM package is published as module but the file chess.js is exported as commonJs
The situation in the current stable version (v0.13.4) : the package is published as an ESM module (see source here https://www.npmjs.com/package/chess.js/v/0.13.4?activeTab=explore)
In this PR:

commit ce815a9: restores the v0.13.4 situation
commit 7345604: add sourceMap to the npm package (it is a good practice)
commit 27214ca: transpile in ES2017 instead of ES2015 to publish native async/await (supported from Node >= 8 and every browser for the past 5 years)

@justinfagnani any thoughts?

Thanks for the PR @GabrielDelepine!  The changes in your PR are failing in the build step (tsc --build) with the errors below.  Any ideas?
Error: node_modules/@types/babel__generator/index.d.ts(10,20): error TS2792: Cannot find module '@babel/types'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__template/index.d.ts(9,31): error TS2792: Cannot find module '@babel/parser'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__template/index.d.ts(10,48): error TS2792: Cannot find module '@babel/types'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__traverse/index.d.ts(13,20): error TS2792: Cannot find module '@babel/types'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__traverse/index.d.ts(63,18): error TS2411: Property 'blacklist' of type 'any[] | undefined' is not assignable to 'string' index type '(VisitNode<S, any> & VisitNode<S, t.Aliases>) | undefined'.
Error: node_modules/@types/babel__traverse/index.d.ts(63,18): error TS2411: Property 'denylist' of type 'any[] | undefined' is not assignable to 'string' index type '(VisitNode<S, any> & VisitNode<S, t.Aliases>) | undefined'.
Error: node_modules/@types/babel__traverse/index.d.ts(64,5): error TS2411: Property 'scope' of type 'Scope | undefined' is not assignable to 'string' index type '(VisitNode<S, any> & VisitNode<S, t.Aliases>) | undefined'.
Error: node_modules/@types/babel__traverse/index.d.ts(65,5): error TS2411: Property 'noScope' of type 'boolean | undefined' is not assignable to 'string' index type '(VisitNode<S, any> & VisitNode<S, t.Aliases>) | undefined'.
Error: node_modules/@types/babel__traverse/index.d.ts(248,69): error TS2536: Type '"type"' cannot be used to index type 'T'.
Error: node_modules/@types/babel__core/index.d.ts(12,31): error TS2792: Cannot find module '@babel/parser'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__core/index.d.ts(15,20): error TS2792: Cannot find module '@babel/types'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/babel__core/index.d.ts(20,52): error TS2792: Cannot find module '@babel/parser'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/jest/index.d.ts(501,30): error TS2792: Cannot find module 'jest-matcher-utils'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: node_modules/@types/jest/index.d.ts(528,44): error TS2792: Cannot find module 'pretty-format'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
Error: Process completed with exit code 1.

Sorry about that. I fixed my initial commit by adding
"moduleResolution": "node", to fix import in some @types/* packages
"esModuleInterop": true, to allow Typescript to import packages from node_modules that would be published as CommonJS

Awesome, thanks @GabrielDelepine!

FYI, I've included your latest changes in 1.0.0-beta.3 and published to npm.


Can't build

Firstly, https://www.mingw.org was hijacked and now points to one of those "Click Allow to continue" scams.
Anyway,
C:\Users\[REDACTED]\Downloads\Craft-master>cmake -D CMAKE_C_COMPILER="C:/Users/[REDACTED]/mingw64/bin/gcc.exe"
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.

CMake Deprecation Warning at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- The C compiler identification is GNU 13.2.0
-- The CXX compiler identification is GNU 13.2.0
-- Check for working C compiler: C:/Users/[REDACTED]/mingw64/bin/x86_64-w64-mingw32-gcc.exe
-- Check for working C compiler: C:/Users/[REDACTED]/mingw64/bin/x86_64-w64-mingw32-gcc.exe - broken
CMake Error at C:/Program Files/CMake/share/cmake-3.28/Modules/CMakeTestCCompiler.cmake:67 (message):
  The C compiler

    "C:/Users/[REDACTED]/mingw64/bin/x86_64-w64-mingw32-gcc.exe"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: 'C:/Users/[REDACTED]/Downloads/Craft-master/CMakeFiles/CMakeScratch/TryCompile-7hxwuo'

    Run Build Command(s): "C:/Program Files/CMake/bin/cmake.exe" -E env VERBOSE=1 C:/Users/[REDACTED]/mingw64/bin/cmake.exe -f Makefile cmTC_ea186/fast
    CMake Warning:
      Ignoring extra path from command line:

       "cmTC_ea186/fast"

    CMake Error: Unknown argument -f
    CMake Error: Run 'cmake --help' for all supported options.

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:6 (project)

-- Configuring incomplete, errors occurred!

regarding the failure mode, there's this DenverCoder9 issue with the same pattern of "Makefile cmTC_[hex digits]/fast [...] Unknown argument -f".

using MinGW from WinLibs "GCC 13.2.0 (with POSIX threads) + LLVM/Clang/LLD/LLDB 17.0.6 + MinGW-w64 11.0.1 (UCRT) - release 4" (Win64), and curl 8.5.0 (curl-for-win).

i cannot build the game to play it either, relateable.


Add from2-array to a See Also section

Found out about from2 and from2-array today.  This would make from2-array a little more discoverable, and was inspired by github.com/rvagg/through2#see-also.  Are there any other known from2 wrappers that should also be added?
Just wondering, is there a to2 that is a similar Convince wrapper for writable streams?

neat! from2-string is probably worth mentioning too https://github.com/yoshuawuyts/from2-string

@yoshuawuyts send a pr :)

@bcomnes i've been using this for purely writeable streams, https://github.com/mafintosh/flush-write-stream

from2-string looks great!  I'll pr it toady unless someone beats me to it.
Flush-write looks perfect :+1:


Julia's MIToS.PDB benchmarks

Include MIToS.PDB benchmarks (https://github.com/jgreener64/pdb-benchmarks/issues/1).
Thanks!
Julia FTW! ;)

Great thanks, will merge now and run the benchmarks when I get a chance 👍


BUG: ZeroDivisionError while creating Textatistic object

The code Textatistic('Sunfeast Dark Fantasy Choco Fills, 600g, Original Filled Cookies with Choco CrÃ¨me\n') raises ZeroDivisionError. This is because, in flesch_score function, vars['sent_count'] is 0 at the return statement.
def flesch_score(text=None, abbr=None, hyphen=None, vars={}):
    """Calculate Flesch Reading Ease score."""
    if text:
        if not abbr:
            abbr = Abbreviations()
        if not hyphen:
            hyphen = Hyphenator('en_US')
        text = punct_clean(text, abbr)
        vars['sent_count'] = sent_count(text, abbr, True)
        text = word_array(text, abbr, True)
        vars['word_count'] = word_count(text, abbr, True)
        vars['sybl_count'] = sybl_counts(text, abbr, hyphen, True)['sybl_count']
    return 206.835 - 1.015 * (vars['word_count'] / vars['sent_count']) - 84.6 * (vars['sybl_count'] / vars['word_count'])

I have the same issue and I've mitigated it by creating a new feature which adds '.' to the original text. Not the most elegant solution, I know.

@MarcinKamil84 One issue with adding '.' could be that if a text already has '.' at the end of sentence, then extra '.' could (wrongly) increase sent_count.

@sohang3112 Totally agreed. It's just a not-so-elegant workaround.

@erinhengel I would like to work on this issue - would you be interested in a Pull Request to fix this bug?


Added email footer (es)

It is footer for mails in Spanish

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   63.11%   63.11%
=======================================
  Files          35       35
  Lines        3264     3264
  Branches      497      497
=======================================
  Hits         2060     2060
  Misses       1068     1068
  Partials      136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bda30d...db223ab. Read the comment docs.


decorating a ViewModel during programmatic composition

I was wondering if it's possible to "decorate" a viewModel with custom methods such that they will be available to the resulting view? Specifically if I had:
my-element.html:
<template><button click.delegate="doSomething()"></template>

my-element.js:
export class MyElement {}

Could I somehow add doSomething to the my-element's viewModel when I'm using either CompositionEngine.createController or CompositionEngine.compose?
Thanks, and sorry for the potentially confusing terminology wrt decoration.

Probably there's a way to do what you want...especially in the next release. However, I'm not 100% clear on the scenario.

@EisenbergEffect thanks for the quick response. I'm experimenting with a toast component, which is very similar to aurelia-dialog, however I find the implementation of the dialog to be a bit... involved. It seems like there a lot of contortions done there in terms of dynamically injecting a special controller, and that controllers use within the renderer.
The toasts are a far simpler implementation, and at least in the initial implementation do not require the ability to pass in a custom viewModel.  I thought it would be very convenient to directly decorate the internally composed component with methods to control the "renderer" during the creation of the component rather than through an injected controller.
Sorry if that description itself is a bit convoluted, I'm trying to mentally work through alternative implementations - so I'm a bit scattered :smile:

If you just want to add methods, you can use a decorator to mix in the methods to a class. You probably need some toast service though, which would need to be injected.
I would avoid any sort of "magic" of adding methods to a view model that aren't in some way visible.

@EisenbergEffect that's what I'm currently doing, you can see the existing code here: https://github.com/mbroadst/aurelia-toast-demo/tree/master/src/toast
I have a ToastService that dynamically creates a ToastElement and places it into a host (there are six possible positions, so six different toast hosts, this is another issue). This all works quite well, however I need to signal back to the renderer (or really manager) when certain things happen, like a click on the toast itself.
As you can see, this is all derived from aurelia-dialog, however I'm trying to avoid injecting the DialogController and using it the way it's done in that project because:

I just find that approach to be righteously confusing
I think there is opportunity to design this in far less coupled way
aesthetically I think it's more desirable to use direct methods in the toast view, rather than referencing a controller object (e.g. controller.close() etc)

I was hoping that when I composed the toast-element I could inject the methods needed for interaction with the ToastRenderer at that point.

ah it looks like maybe I can do this as part of Controller.automate

At your own risk....

Note that that is a semi-private api.

Are there any other examples of programmatically creating a view + view model and binding data to it? There seem to be few resources on this, and I'm not sure its clear through the existing documentation what route I should be taking.