Switch DTLS default role when answering

Run DTLS as Passive instead of Active when answering

Codecov Report

Merging #886 into master will decrease coverage by 0.06%.
The diff coverage is 70.45%.

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   76.29%   76.22%   -0.07%
==========================================
  Files          59       59
  Lines        4294     4316      +22
==========================================
+ Hits         3276     3290      +14
- Misses        741      746       +5
- Partials      277      280       +3

Impacted Files
Coverage Δ

peerconnection.go
73% <55.55%> (+0.07%)
:arrow_up:

settingengine.go
56.75% <60%> (+0.5%)
:arrow_up:

dtlstransport.go
71.66% <70.58%> (-1.63%)
:arrow_down:

dtlsrole.go
94.11% <84.61%> (-5.89%)
:arrow_down:

sctptransport.go
75.92% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca0099...6309a02. Read the comment docs.


failed to build with mingw-w64-x86_64-clang

hello, it seems failed to build with mingw on Windows, and it reports
thread 'main' panicked at 'Unable to find libclang: "the `libclang` shared library at C:\\msys64\\mingw64\\bin\\libclang.dll could not be opened:

the clang version is 8.0.1 from mingw, does it require specific clang version and msvc?
I'm trying to follow this post and to build his repo.
thanks

@jonirrings any news on this?

@frederikhors not yet

@jonirrings install from here: https://releases.llvm.org/download.html and it works.

@frederikhors thx


Icon submission: 1040.com

[x] I have read and followed CONTRIBUTING document.
URL of the site or app (required, unless it's generic icon): https://www.1040.com
Where did you take the BG color(s) (required, unless it's generic icon): Logo color
Logo resources for the icon:

https://1040.staticserve.net/assets/images/2019/logo-mark-1040-2.svg

Uploaded files:
1040.com.zip

Added to the repo! 👍


Anybody got this working with react?

I could use some help using this plugin with react-medium-editor

I just use the old jquery.. It works but clunky


Add default endpoint used by Docker for Mac

I've verified this works with Docker for Mac. No DOCKER_HOST required.

@johnflavin thanks. It looks like Docker for Mac also sets up a symlink at /var/run/docker.sock -> /var/tmp/docker.sock, so maybe there is no need to add a new constant?

Yeah, good point. I don't know if the new constant is necessary. It's a style thing, really. It's your code (in some sense) so I leave the decision to you.
The change to the conditional is necessary, though. Before, it would only use the socket by default for Linux. Now, that should also be the default on OS X.

I opened https://github.com/spotify/docker-client/pull/436 to use the symlink and the correct socket.


Cannot cast Double to Integer

Plugin Version: 1.6.2
Spigot Version: Paper 1.11.2 (with ViaVersion, ViaBackward and ProtocolSupport)
Log: https://pastebin.com/nwd2ubPT
Config: https://pastebin.com/0s2vTxYf

Are you wearing any items with custom NBT tags on them?

Yes, with Health Attribute

Were the NBT tags added by a plugin or with a command?

by a plugin, I used Myitems

Are you giving any command/order to tell that plugin how to make the item?


State API should panic when missing StatePlugin

Bevy version
0.14
What you did
use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(MinimalPlugins)
        .init_state::<AppState>()
        .run();
}

#[derive(Debug, Clone, Copy, Default, Eq, PartialEq, Hash, States)]
struct AppState;

What went wrong
Crashes inside init_state on an unwrap that assumed a resource would be available from the plugin.
The plugin detection should crash instead with information about missing plugin.

Related: #14151

Is this issue resolved? See https://github.com/bevyengine/bevy/pull/14160.

bevy = "0.14"
     Running `target\debug\bevy_experiment_test.exe`
thread 'main' panicked at C:\Users\BenjaminBrienen\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bevy_state-0.14.2\src\app.rs:70:67:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\bevy_experiment_test.exe` (exit code: 101)

bevy = { path = "../bevy" }
     Running `target\debug\bevy_experiment_test.exe`
thread 'main' panicked at C:\Users\BenjaminBrienen\source\bevy\crates\bevy_state\src\app.rs:98:67:
The `StateTransition` schedule is missing. Did you forget to add StatesPlugin or DefaultPlugins before calling init_state?
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\bevy_experiment_test.exe` (exit code: 101)


undefined is not an object (evaluating ' RNNotifications.postLocalNotification')

undefined is not an object (evaluating ' RNNotifications.postLocalNotification')

android

Post your JS file..

I have the same problem. Did you solve it, @ysq1051838264 ?

+1
anyone resolved it ?


PWN-3219 - Fix link to transaction details in progress bottom sheet

Jira Ticket (Mandatory)
https://p2pvalidator.atlassian.net/browse/3219
Description of Work (Mandatory)
Fix transaction details link in explorer
Screenshots (Optional)

Screenshot #1
Screenshot #2
Screenshot #3

[Paste Pic 1]
[Paste Pic 2]
[Paste Pic 3]

Link in PR is not working!!
No asignee in PR!!


Add an effortless? helper

We now identify systems as running in the effortless pattern within node['chef_packages']. We should expose this as a helper for writing cookbooks.

This is merged into master now


TypeScript - CJS/ES set up

fixes #272

@nikithauc let me know when you're ready to merge so I can override the policies for you.
also can I suggest we rebase #1077, #993 and #992 onto this one, and merge them in here before we merge this to reduce the number of releases?

@nikithauc let me know when you're ready to merge so I can override the policies for you. also can I suggest we rebase #1077, #993 and #992 onto this one, and merge them in here before we merge this to reduce the number of releases?

Good idea! Let me try that.

@nikithauc thanks for the extended collaboration on all of that! I think we're good to merge. Just let me know when you'd like me to override the branch policies. The sooner the better so we don't run into conflicts again. I also closed the other PRs for sanity (but didn't delete the branches yet).

@nikithauc thanks for the extended collaboration on all of that! I think we're good to merge. Just let me know when you'd like me to override the branch policies. The sooner the better so we don't run into conflicts again. I also closed the other PRs for sanity (but didn't delete the branches yet).

Good to merge!


TimeLine Exports & Buttons

Very good job !!!
I am wondering if I can export something like intranet timeline chart
see here: http://www.zakon.org/robert/internet/timeline/Count_Network.gif
something like the above. maybe with lines to connect each tick group!
Is there any way , also, to set button with functionality in the cells?
something like a button to make visible and not visible some cells.
or a button to make visible or not visible some charts.
thank you very much in advance!!

Thank you. You can use the below to create the initial sheet and experiment with the different Excel chart types. Perhaps there is a chart type that is not exposed that can be.
Currently there is nothing in the PowerShell module that lets you create buttons. It's a great idea and I'll look into if it can be done and how much work it will take.

$data = @"
Type,Date,Countries
Internet,7/91,25
BitNet,7/91,45
UUCP,7/91,65
FIDONET,7/91,85
OSI,7/91,95
Internet,11/91,35
BitNet,11/91,55
UUCP,11/91,75
FIDONET,11/91,95
OSI,11/91,105
"@ | ConvertFrom-Csv

$data |Export-Excel c:\temp\timeline.xlsx -Show -IncludePivotTable -IncludePivotChart -PivotRows Date -PivotColumns Type -PivotData Countries -ChartType LineMarkers

OOhhh Thank you very much ! !
I agree it's a very good idea it will offer some interactiveness to the user I guess.
To have buttons to show you some different things in a worksheet.
Obviously this can be done by exporting separate files to show the data but it would be good idea to have all the data you like to show in a unique xlsx file!!
In any case thank you very much for helping me ! :)
I'm looking forward to see anything new on module updates :) :) :+1:
again thank you very very much!!


Improve perf of xr.corr

I think this should improve the performance of xr.corr & xr.cov, but I'm not sure about dask arrays. I haven't been able to do tests on them, but I can do that soon unless anyone has an a priori view.

Because we want an all-NaN slice to return NaN for corr, this doesn't work — we would need to add another transformation to mask out those slices after, when then requires another pass.
If there were a numba implementation of corr or cov, that would be far more performant than these, which are doing multiple passes & copies of each array, as well as blowing out any single-dimensions with the align.
I'll close this. If anyone has alternative ideas, please feel free to raise.


Add a few test cases for the legfunc keyword

Thanks for adding the new functionality! Thought I'd add these to your branch rather than trying to explain the awkwardness of the test suite...

Thanks -  I wasn’t sure if new tests would be necessary as my change is basically just plumbing!


Clarification request- Sudden cardiac arrest/death

I am wondering about MONDO:0007264, "sudden cardiac arrest."
The cross references map to multiple things: "sudden cardiac death" (SCTID:95281009), "cardiac conduction disorder" or defect NCIT: C78245 & OMIM 115080.
Should this term be renamed to "sudden cardiac death" to reflect the SNOMED and OMIM names? I think it would also map to UMLS C0085298, based on current cross references in UMLS.
For reference, there is a separate MSH/UMLS concept for "sudden cardiac arrest" (C1720824). "Sudden suspension of cardiac activity that is usually due to ARRHYTHMIA, in contrast to heart attack (MYOCARDIAL INFARCTION) which occurs due to blockage. The sudden suspension of cardiac activity generally requires RESUSCITATION. ... (MSH)"
I think there should be a clear distinction between sudden cardiac arrest (potentially reversible by resuscitation) and sudden cardiac death (by HPO, MSH definitions, this is not reversible).

Question for Ada:
is the gene associated for a susceptibility?
Should we create a class: Cardiac conduction defect, susceptibility to

to do:
need further info, but for now, remove AKAP10 from the Mondo class 'sudden cardiac arrest'

remove AKAP10 from the Mondo class 'sudden cardiac arrest'
this is done

Action item is to look into this further.

Hello. MedGen is still awaiting a decision on this ticket. Thanks :-)

Hi @kanems thanks for your patience with this.
I think this class should be split out, as the OMIM record has 'included' entries and we've now decided to split out 'included' entries as separate classes.
I propose the following terms:
[Term]
id: MONDO:NEW
name: sudden cardiac arrest
def: The sudden loss of all heart activity due to an irregular heart rhythm. [https://www.mayoclinic.org/diseases-conditions/sudden-cardiac-arrest/symptoms-causes/syc-20350634]
comment: Change to current cardiac arrthymia parent requested and confirmed as a correct use of is-a by James Ware, cardiac expert. {source="EFO:0004278"}
xref: EFO:0004278 {source="MONDO:equivalentTo"}
xref: MESH:C1720824 {source="MONDO:equivalentTo"}
is_a: MONDO:0007263 {source="https://orcid.org/0000-0001-5208-3432"} ! cardiac rhythm disease
property_value: IAO:0000233 https://github.com/monarch-initiative/mondo/issues/2419 xsd:anyURI
[Term]
id: MONDO:0007264
name: sudden cardiac death (Note, this is the existing term and I agree with your proposal to relabel it, the existing label does not match the definition)
def: "An unexpected natural death from a cardiac cause within a short time period from the onset of symptoms." [NCIT:C50911]
synonym: "sudden cardiac death" EXACT [OMIM:115080]
xref: NCIT:C50911 {source="EFO:0004278", source="MONDO:otherHierarchy"}
xref: OMIM:115080 {source="EFO:0004278", source="MONDO:includedEntryInOMIM"}
xref: MESH:D016757 {source="EFO:0004278"}
xref: SCTID:95281009 {source="EFO:0004278", source="MONDO:equivalentTo"}
xref: UMLS:C0085298 {source="MONDO:notFoundInDiseaseSubset", source="OMIM:115080"}
is_a: MONDO:0007263 {source="EFO:0004278"} ! cardiac rhythm disease
property_value: IAO:0000233 https://github.com/monarch-initiative/mondo/issues/4521 xsd:anyURI
property_value: IAO:0000233 https://github.com/monarch-initiative/mondo/issues/2419 xsd:anyURI
[Term]
id: MONDO:NEW
name: cardiac conduction defect
xref: OMIM:115080 {source="EFO:0004278", source="MONDO:equivalentTo"}
synonym: "cardiac conduction disorder" BROAD [NCIT:C78245]
synonym: "conduction disorder" BROAD [NCIT:C78245]
synonym: "disorder of cardiac conduction" BROAD [NCIT:C78245]
synonym: "heart conduction disorder" BROAD [NCIT:C78245]
xref: NCIT:C78245 {source="MONDO:mondoIsBroaderThanSource"}
xref: Orphanet:871 {source="MONDO:relatedTo", source="OMIM:115080"}
xref: UMLS:C0264886 {source="MONDO:ncbi_mim2gene_medline", source="MONDO:notFoundInDiseaseSubset", source="OMIM:115080"}
is_a: MONDO:0007263 {source="https://orcid.org/0000-0001-5208-3432"} ! cardiac rhythm disease
property_value: IAO:0000233 https://github.com/monarch-initiative/mondo/issues/2419 xsd:anyURI
[Term]
id: MONDO:NEW
name: familial sudden death
xref: OMIM:115080 {source="MONDO:equivalentTo"}
xref: UMLS:C1861884 {source="MONDO:notFoundInDiseaseSubset", source="OMIM:115080"}
is_a: MONDO:0007263 {source="https://orcid.org/0000-0001-5208-3432"} ! cardiac rhythm disease
property_value: IAO:0000233 https://github.com/monarch-initiative/mondo/issues/2419 xsd:anyURI

Let me know if you agree and I will proceed with this plan.

Hi Nicole, looking back over my original post and comments, I think your proposal covers the different facets of the original request (and clarifies the different presentations of rapid onset heart defects that I am aware of). Thanks!

@kanems - @sabrinatoro pointed out that sudden cardiac death does not sound like a disease. This term exists in HPO, I suggest that we obsolete it in Mondo and point to HPO
I think we should obsolete 'familial sudden death' as well
Please let me know if you have any objections

@nicolevasilevsky MedGen will continue to support the OMIM and HPO terms. Thus, even if these aren't in scope for Mondo, MedGen can and will still represent these terms from our other sources. It should not be a problem for Mondo to obsolete these terms.


[BUG] Wrong encoding detected for empty JSON response

Describe the bug
requests 2.26.0 switched to using charset_normalizer by default under Python 3 (see: https://github.com/googleapis/python-cloud-core/issues/117).  After this change, a response constructed with an empty JSON body (b"{}) can no longer unmarshall to the empty dict in its json method.

        This can be used to decode a JSON document from a string that may
        have extraneous data at the end.

        """
        try:
            obj, end = self.scan_once(s, idx)
        except StopIteration as err:
>           raise JSONDecodeError("Expecting value", s, err.value) from None
E           json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Expected behavior
I expect to be able unmarshall b"{}" into an empty dict, {}.
Desktop (please complete the following information):

OS: Linux
Python version: 3.6, 3.7, 3.8, 3.9
Package version: 2.0.1

Hi @tseaver
Thanks for the report,
I was able to reproduce this easily. The miss-detect fault happen in the plugin TooManySymbolOrPunctuationPlugin(MessDetectorPlugin).
Adjustments are to be done in this plugin.

The following PR should fix your issue https://github.com/Ousret/charset_normalizer/pull/59
If you have any more concerns, do not hesitate.

Now available under https://github.com/Ousret/charset_normalizer/releases/tag/2.0.2


[Enhancement] Probably shouldn't scrape the website, I found a jsonapi

The link is: https://cms.elitedangerous.com/jsonapi/node/galnet_article
The only unfortunate thing is it's paginated and caped at 50 articles per page.
The best way to navigate each page is like so: (not in order by date unfortunately)

000-049: https://cms.elitedangerous.com/jsonapi/node/galnet_article?page[offset]=0
050-099: https://cms.elitedangerous.com/jsonapi/node/galnet_article?page[offset]=50
...
350-399: https://cms.elitedangerous.com/jsonapi/node/galnet_article?page[offset]=350 (currently contains only 44 articles though)

But since it's in a lot easier format to use, and less likely to change than a html page, it would probably be best to use this.

Another issue I've noticed though is that the dates past a certain date are off by one day... which I'm not sure why that is.

Another issue I've noticed though is that the dates past a certain date are off by one day... which I'm not sure why that is.

This is due to FDev using a real leap year date, when the fictional year they are representing is not a leap year.

This is due to FDev using a real leap year date, when the fictional year they are representing is not a leap year.

Ah that would make a lot of sense then.

Ah that would make a lot of sense then.

Looking at it further, it turns out that it's not really sorted by date, sadly.

Looking at it further, it turns out that it's not really sorted by date, sadly.

On the plus side though, it would reduce your constant fetching of the website down to 7 fetches, at least for now.

On the plus side though, it would reduce your constant fetching of the website down to 7 fetches, at least for now.

@kc9eye Also, this is what I mean. http://cms.elitedangerous.com/jsonapi/node/galnet_article?page[offset]=0&filter[field_galnet_date]=22 AUG 3304
But that shows the posts that should be on 23 AUG 3304.

@kc9eye Also, this is what I mean. http://cms.elitedangerous.com/jsonapi/node/galnet_article?page[offset]=0&filter[field_galnet_date]=22 AUG 3304
But that shows the posts that should be on 23 AUG 3304.

Perhaps you should talk to the owner of that site, can't help you with that.

Perhaps you should talk to the owner of that site, can't help you with that.

I've tried Frontier Dev's contact email, but it keeps erroring for some weird reason, so instead I setup a forum account, and made a note about such an issue inside their normal api.

I've tried Frontier Dev's contact email, but it keeps erroring for some weird reason, so instead I setup a forum account, and made a note about such an issue inside their normal api.

I talked to other third party devs that had captures of those days when articles came out, and it turns out that the date in the api should be correct, meaning that the archive website dates may be wrong for some articles... hopefully the devs will notice it sometime and fix it.

I talked to other third party devs that had captures of those days when articles came out, and it turns out that the date in the api should be correct, meaning that the archive website dates may be wrong for some articles... hopefully the devs will notice it sometime and fix it.


$this->faker has no providers loaded in model factories

Laravel Version: 8.0.0
PHP Version: 7.4.2
Database Driver & Version: MySQL 5.7.29

Description:
Any attempt to use Model::factory()->create() where $this->faker is used in the definition() method will result in Faker complaining of an unknown formatter. It appears that by default there are no providers loaded.
Steps To Reproduce:
Write a test in a fresh Laravel 8 installation that uses the User factory that ships with it and run it.
public function testBasicTest()
    {
        User::factory()->create();
    }

Results in
 Unknown formatter "name"

  at vendor/fzaninotto/faker/src/Faker/Generator.php:248

Same problem if I try to use the withFaker trait on a test.

You are attempting to do this in a unit test class. Unit test classes do not boot the framework at all.

@taylorotwell @JeffreyWay
this is the source of confussion:
What's new in laravel 8, episode 8
Jeffrey creates a unit test in tests/Unit but use Test/TestCase instead of the PHPUnit\Framework\TestCase used when
php artisan make:test --unit

If you want your unit tests to boot the framework, yes you need to extend Tests\TestCase. 👍


KFLUXBUGS-1305: Show the user's first and last name on the UI

There was bug where the user's first and last name were not visible in the UI since they weren't included in the JWT token. Include the "first_name" and "last_name" claims in the JWT token.

@gbenhaim This fixed p02 but not p01


Code examples in content should be differentiated from other content

The content in the <code> blocks on some content pages should likely have a different background color and some spacing separation to ensure they're visually separated from surrounding content. Example here: https://docs-staging.apps.cloud.gov/ops/creating-a-local-dev-environment-in-Virtual-Box/

Does this issue refer only to code examples on the documentation site or does it mean changing the style guide so that sites that include it get styled code examples?
If it is the former, I think this should be closed as of 4f1f0ed223d67b22dc0d6e95a00a982d40eae77c

I think it means changing the style guide so sites that include it get styled code examples.


Allow importing of characters as actors

I have to look into this. This would probably require some configuration to define how to map fields. It would also be great to allow mapping of any character sheet field with any kanka attribute.

The mapping could be done in Kanka. Maybe by using a char template having the same attributes as the charsheet used by the game system?
The benefit of having that in Kanka: You don't have to configure it in all game worlds in Foundry you might have for the same charakters (I open a new game world for each campaign chapter in order to reuse the worlds for other groups). That way you can simply install your module and import.

Thanks again for your feedback! I have been contemplating this issue every now and then ever since I created it.
The biggest problem is, that I want this to be system agnostic. So people should be able to use it with 5e, PF, SWADE or whatever else they play. At most I'd add some "predefined" templates for certain systems, but I actually don't want a dependency to other modules (or systems) to maintain this way.
The "problem" about Attributes in Kanka is, that they are by design "flat". So you can't nest them (the best you have are "sections", but those are basically just headlines). Also you probably don't want your attributes to have technical names that map to a Foundry system like attributes.strength.value or the like. This would also necessitate that you know what the value must be, even outside of foundry (which is already a pain in foundry itself).
That is the reason I'd prefer to do some kind of mapping inside of foundry – because I have the possibility to give the user all the info they need (up to a certain degree). But I hear you and your use case. I also see the need to make it simple to reuse configurations between worlds with the same system, in whatever form that configuration might be done.
That being said: I'm not sure I will ever implement this feature for multiple reasons.

It is already a bit of work to maintain this module as it is.
The difference in how systems handle characters is overwhelming, especially when we also take stuff like different kind of items into account.
It would probably necessitate a 2 way sync, which can become a pain quickly. Especially for stuff that can't be mapped.

So I will probably not do this in the near future at least. But I keep this (and the other similar) issues open, because I do see value in those features (and some of those other issues, like syncing items, might actually be more likely for me to start with at some point, because they tend to be simpler) and want people to know that they are at least on my mind.
And depending on how foundry / kanka evolve over time, or depending on what ideas I (or others) come up with, it might become a lot more feasible and I might tackle this feature.

Would it be possible to see if an actor with the same name exists and insert a reference to that actor into the journal entry? Ideally in the top section with Type and Location. Then, the gamemaster can go in and manually link to the journal entry in the actor and be able to bounce back and forth. It's a bit clunky, but I'd hope that it's not that much extra work.

This is actually kind of possible. You can add an attribute to the character in Kanka (let's call it "Actor") and add a Foundry-Link as a value (like @Actor[E2N5voHMjnZXuAdv]). If you star this attribute it will be displayed on the first tab in Foundry.
There are a few downsides to this:

The attribute will also be pinned in Kanka itself (which some people might not like)
I'm not sure if you can use "long form" links like @Actor[E2N5voHMjnZXuAdv]{Some Name}, because Kanka tries to interpret everything in curly braces. I'll have to find out if there is a way to escape them somehow to avoid this behavior.
The link wont be right at the top of the list because pinned attributes are displayed last in the table on the first tab.

Just tried this, it works well enough for my needs, thanks!
As you suspected you can't use long form links, at least I wasn't able to figure out a way to escape the curly braces.

I wasn't able to find a way either. I'll bring this up with Kanka, but I can't guarantee anything. :)

Some foundry systems such as Pathfinder 2e support the import and export of characters.
Kanka now supports json attachments for characters. Could simply load this character's associated json file (or choose from a list of json files on the character) and then import the character using the system's import functionality.
Can even expand this, allowing for saving a character to Kanka directly, which is exceptionally useful for Pathfinder Society games / Characters who hop between Foundry instances

I would be interested to develop it for a specific game system not yet existing in foundry (I would share only in private due to legal issues).
How would you address kanka -> actor import ?
I would try to have a shot.

I really can't tell you yet tbh, because I haven't come up with a great idea – especially not for single systems.
If you want this to work in a fork of yours for just a single system, you might get away with copying some of the stuff that's already there, but instead of creating new Journals, you create new Actors and map specific Attributes on your Kanka entity to their counterparts in the Foundry Actor – maybe with some type conversion if necessary. You can probably skip the part where the whole Kanka entity is saved as a flag on the foundry document, because you would already have most of the important stats on the Character anyway.
Then you would probably want to listen to changes on the actor and update the entity in Kanka - something I haven't implemented yet.
What I would ideally want to do someday, is to allow GMs to provide their own mappings and maybe add some default mappings based on Foundry Systems and maybe Kanka-Marketplace-Sheets.

thanks for the feedback !
Indeed, as you mentioned earlier, I will need to define a mapping into kanka beforehand. Not a problem for me but it is a hassle. Point is, kanka marketplace is not as important as foundry's. Maybe later.
I will go this way.


LOAN-149 - Additional Loan refactoring is needed, including merging SecuredLoans and UnsecuredLoans with LoanCore

Signed-off-by: Elisa Kendall<EMAIL_ADDRESS>Description
This resolution represents the next phase in loan 'coagulation' / refactoring, including moving mortgage-specific content to the mortgage loans ontology, moving application-specific content to the loan applications ontology, moving construction-related content to the construction loans ontology, merging secured and unsecured loan ontologies, which were tiny, into the loan core ontology, and improving integration with other FIBO content related to debt instruments.  Although there is still work to be done, the LoanCore, LoanApplications and MortgageLoans ontologies are much improved, better modularized, and are now logically consistent.
Fixes: #1108 / LOAN-149
Checklist:

[x] I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
[x] My contribution follows the principles of best practices for FIBO.
[x] My changes have been reconciled with latest master and no merge conflicts remain.
[x] This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
[x] Hygiene tests have been applied by a PR with "(WIP)" in title.
[x] The issue has been tested locally using a reasoner (for ontology changes).

Hi Liza,
Exiting to see progress on Loans, hopefully, the first core in Q3 Prod.
The refactoring makes sense. However, I would caution about decommissioning the Secured Loans Ontology. There may be only a skeleton of classes right now, but Credit Risk Mitigation is huge in banking. I expect to see dozens of classes for Collateral, Guarantee, and Loan Insurance in the future.
And then you would have to move Secured Loans back into its own ontology again.
Regards
Jurgen

@jziemer2 - Hi Jurgen,
I realize that there will be a lot of extensions, especially for areas including collateral management, but the concept of a secured loan, and its two children, are really so fundamental that it made sense to merge them, and the ontologies were tiny.  Any additional work could, of course, create new ontologies, and I would expect that to be the case.  A couple of the banks I've worked with have extensive collateral management systems (multiples, depending on the domain area - different for property from securities for example), so I'm sure that will come into play down the road.  Same is true for pricing and a lot of other areas.  But the fundamental ideas can be extended in a straightforward way, and I'm looking forward to having Fannie Mae, Citi, and Wells Fargo take a crack at it once I've done a bit more triage on what we have.  The biggest change here was to refactor LoanCore to move things to their "proper home", out of the core loan ontology and into mortgages or applications, etc. to make it easier to work with and extend those ontologies as needed.  All 3 of those - LoanCore, LoanApplications, and MortgageLoans are now logically consistent and consistent with one another, which I'm happy to share.  There are still some things to clean up further, but at least we have a starting point in those 3 ontologies for a new FCT to use.
Thanks for taking a look -- I really appreciate it.
Best,
Elisa

In other words, SecuredLoan and its subclasses will stay in core, even when new collateral management ontologies expand the design.
Makes sense :)

The distinction of collateralized and uncollateralized debt (not just loans) and of resources/assets playing the role of collateral (including pooled resources) is one of the fundamental partitions we needed in the Fannie-Mae ontology.
From: Elisa Kendall<EMAIL_ADDRESS>Sent: Sunday, July 19, 2020 1:03 PM
To: edmcouncil/fibo<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [edmcouncil/fibo] LOAN-149 - Additional Loan refactoring is needed, including merging SecuredLoans and UnsecuredLoans with LoanCore (#1109)
@jziemer2https://github.com/jziemer2 - Hi Jurgen,
I realize that there will be a lot of extensions, especially for areas including collateral management, but the concept of a secured loan, and its two children, are really so fundamental that it made sense to merge them, and the ontologies were tiny. Any additional work could, of course, create new ontologies, and I would expect that to be the case. A couple of the banks I've worked with have extensive collateral management systems (multiples, depending on the domain area - different for property from securities for example), so I'm sure that will come into play down the road. Same is true for pricing and a lot of other areas. But the fundamental ideas can be extended in a straightforward way, and I'm looking forward to having Fannie Mae, Citi, and Wells Fargo take a crack at it once I've done a bit more triage on what we have. The biggest change here was to refactor LoanCore to move things to their "proper home", out of the core loan ontology and into mortgages or applications, etc. to make it easier to work with and extend those ontologies as needed. All 3 of those - LoanCore, LoanApplications, and MortgageLoans are now logically consistent and consistent with one another, which I'm happy to share. There are still some things to clean up further, but at least we have a starting point in those 3 ontologies for a new FCT to use.
Thanks for taking a look -- I really appreciate it.
Best,
Elisa
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/edmcouncil/fibo/pull/1109#issuecomment-660676581, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIJNJF2ZT44BHTHWFVVNOTR4MRLJANCNFSM4PA2QS6Q.


Add s_bend option to gf.routing.get_route

Thank you Skandan!

Would you still like me to change it from Route -> ComponentSpec? route_manhattan (I think) is supposed to return a Route and not a Component, no?

im sending this PR with some small fixed on this PR and the cdc
they both look great


issue: isLoading always returns true

Version Number
7.42.1
Codesandbox/Expo snack
https://codesandbox.io/s/react-hook-form-isloading-form-xl8dk9?file=/src/TestForm.tsx
Steps to reproduce
First i have to say that i really enjoy using this library, excellent DX.
Steps to reproduce:

Make a standard form with useForm.
Make a spinner which renders based on formState isLoading

Expected behaviour
I'm not sure if it's my understanding of the documentation, but to me this seems like a bug.
I'm expecting to see the form input and not the spinner, it seems like isLoading is always returning true even if the form is done loading.
From the docs:
isLoading | boolean: true if the form is currently loading async default values.
I might be wrong here, but shouldn't it be false if the form is done rendering and defaultValues is set?
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@bluebill1049 Thanks for the quick reply.
If you could give some more context here that would be great.
true if the form is currently loading async default values.
Have a nice weekend man! :)


Ubuntu: GRADLE_HOME set to nonexistent directory

Description
java-tools.sh
unpacks the latest Gradle distribution directly into /usr/share, leading to a directory like /usr/share/gradle-7.0. It then correctly links /usr/bin/gradle to /usr/share/gradle-7.0/bin/gradle. But then it sets GRADLE_HOME to /usr/share/gradle, which doesn't exist.
I think it should set GRADLE_HOME to /usr/share/gradle-7.0, or it should symlink or rename /usr/share/gradle-7.0 to /usr/share/gradle.
Area for Triage:
Java
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[x] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Image version
https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210412.1
Expected behavior
GRADLE_HOME set to a directory containing the Gradle installation.
Actual behavior
GRADLE_HOME set to a nonexistent directory.
Repro steps
Depend on GRADLE_HOME to contain a Gradle installation.

Hello, @eamonnmcmanus. Thank you for your report. We will take a look and come back with the results.

Hello, @hashtagchris. We have merged PR with the fix. Images should be available with the next week's Rollout. I'll post an update message.

Hello @eamonnmcmanus. Images with the fix were successfully updated. I'm going to close this issue. Feel free to contact us if you have any concerns.


Tanzu standalone-cluster error init.go.108] worker node are still being created

Bug Report
Tanzu standalone deployment failed with :
error init.go.108] unable to set up standalone cluster, unable to wait for cluster getting ready for move, worker nodes are still being created for machine deployment 'Kubernetes-md-0', Desired relicas=1 Replica=1 ReadyReplicas=0 UpdatedReplicas=1
Tested with windows 11 ans Debian 10 / 11 machines with same result
Environment Details

Build version (tanzu version): 0.9.1
Deployment (Managed/Standalone cluster): Standalone cluster
Infrastructure Provider (Docker/AWS/Azure/vSphere): vSphere
Operating System (client): Windows 11 - Debian 10 / 11

Screenshot

Experiencing the same thing here - identical error on all platforms below.
Bootstrap platforms:

Windows 10 x64

Windows Server 2019 Standard

Ubuntu Server 20.04.3

Ubuntu (WSL v2, 20.04.3)

Target:

vSphere 7.0.2 (vCenter Server <IP_ADDRESS>00)

Attached logs are the result of bootstrapping from Windows 10 x64.
tanzu management-cluster create --ui -b "<IP_ADDRESS>:8088"
Should note that I've tried with releases 0.9.0 and 0.9.1
ui_logs.txt
esdi3jwf2d_sanitized.yaml.txt


Update frontend

Update NLP filter taking average confidence
Rename dlp template div
Add separate checkbox controller for two filters.
Optimize hide and show logic.
Print err back to frontend

Tested-by: zlq

/gcbrun

/gcbrun


Upgrade reaction-force

          1 Warning

:warning:
Please include a PR summary

  Generated by :no_entry_sign: Danger


reporter output to a file

I am trying to use circle ci with my meteor app, however I need the reporter to write its output to a file, any clues how to accomplish this?
Thanks

Maybe this would work? https://www.npmjs.com/package/reporter-file
You can specify the "reporter-file" reporter for dispatch:mocha as explained here: https://github.com/DispatchMe/meteor-mocha#run-with-a-different-reporter

thanks @aldeed  for your reply
I added reporter file to my project devDependencies but when running tests with this command:
SERVER_TEST_REPORTER='xunit-file' meteor test  --once --driver-package dispatch:mocha
I got this error Error: invalid reporter "xunit-file" seems that the reporter
It seems that the mocha driver can not 'see' the new reporter

@ayhid I haven't tried, but the way I read the docs, the command should be:
MOCHA_REPORTER=XUnit SERVER_TEST_REPORTER=reporter-file meteor test --once --driver-package dispatch:mocha

And you can also add MOCHA_REPORTER_FILE=something.xml if you don't want the default filename of xunit.xml in the current directory
I you just want xunit file, you could also use https://www.npmjs.com/package/xunit-file package and then SERVER_TEST_REPORTER='xunit-file' would work.

@aldeed I tried the command you suggested but I still have Error: invalid reporter "reporter-file" exception for some reason the "reporter-file" module is not "seen" by dispatch:mocha.

OK, I wasn't sure. We can accept a PR for this or look into it when there's time.

I added 'xunit-file' as a dependency for practicalmeteor:mocha-core and with this command MOCHA_REPORTER=XUnit SERVER_TEST_REPORTER=xunit-file XUNIT_FILE=/home/optimus/cleanio/orders-microservice/output/xunit.xml  meteor test --once --driver-package dispatch:mocha` I finally got my report on a file.
I would like to make a PR but I have to admit I don't know where to start, any help is much appreciated.
Thanks

@aldeed thanks for this package! It seems to work fine for standard console output which is a big step up for us as spacejam has been broken for us for quite a while.
We too are interested in using an xunit file reporter as we have xunit parsers in our CI environment. I've read through your discussion above and tried a number of things but cannot seem to get the underlying practicalmeteor:mocha-core to see the new reporter.
@ayhid would you mind describing further how you added xunit-file as a dependency for practicalmeteor:mocha-core? Did you actually clone the repo locally and add the dependency to the package.js file?
I am doing package testing and am pulling dispatch:mocha-phantomjs in as a test dependency in our project. I'm not sure how to add the said dependency outside cloning the repo and modifying it. Not an ideal solution but if thats what it takes...

hey @jeffryan  , like you said I just added the package to my fork dependecies.
And I added it locally as a submodule, it's not the cleanest solution ever, but it's does the job for now.

Hey thanks @ayhid - I'm just going to use your fork then ;)

Hello,
i am concerned about Continus Integration, and I also failed to get a xunit file. but I dont know how to apply your solution, I mean pratically. Is it possible that you add some explanations ? Thanks.

Hi guys,
can you please post an update on this? Any news?
I am trying to output a CircleCi compatible xml, but am getting a Error: invalid reporter "xunit-file" error, if I run something like MOCHA_REPORTER=XUnit SERVER_TEST_REPORTER=xunit-file XUNIT_FILE=xunit.xml  meteor test --once --driver-package dispatch:mocha.
This is a more detailed description of my usecase https://forums.meteor.com/t/enhanced-but-simply-stupid-circleci-setup-that-first-runs-unit-integration-tests-and-then-chimp-acceptance-tests/35086
Thanks a lot for your help!

@jeffryan @ayhid : Can please share a step-by-step instruction on how to do this? This would be really awesome!!!

ok this is what worked out for me:
meteor add practicalmeteor:mocha  # we'll use this package to generate CircleCi compatible xml-files
meteor remove practicalmeteor:mocha;  # cleanup for `dispatch:mocha` (otherwise we'll get a version-constraint)
meteor add practicalmeteor:chai
cd packages; git clone https://github.com/ayhid/meteor-mocha-core.git
# finally create the xml file
targetXmlFilePath="$(pwd)/unit.xml"; MOCHA_REPORTER=XUnit SERVER_TEST_REPORTER=xunit-file XUNIT_FILE=$targetXmlFilePath meteor test --once --driver-package dispatch:mocha

@aldeed : How about getting a CircleCi-compatible reporter build right into this package to make it easy for future users?

@thebarty Just published 0.3.0, which should let you do SERVER_TEST_REPORTER=xunit XUNIT_FILE=$PWD/unit.xml without needing the forked core or any other workarounds.


1.19.4 Native Support [SUGGESTION]

Is your feature request related to a problem? Please describe.
1.19.4 Native Support
Describe the solution you'd like
1.19.4 Native Support
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi! Could you specify any reason to follow this huge change?

Cobblemon will be moving to 1.19.4 in its next update and alot of fabric based servers use this mod. I'm just trying to prepare my servers for that change and try to get everything that I don't have at 1.19.4 ready so that nothing ends up breaking. I was also wondering if its possible to add permissions onto stuff like dimension restrictions via perm node etc.


:lock: ITHC Offboarding

User Story
Now that ITHC activities have concluded we need to offboard NCC users from the system
Useful Contacts
Julia Lawrene, Tevin Jemide
Additional Information
NCC Users in moj-analytical-services
CP Prod

ncctest1
ncctest2
ncctest3
ncctest5

CP Dev

at-test-account-1
at-test-account-2
at-test-account-3
at-test-account-4

Definition of Done

[x] ITHC terraform component destroyed
[x] Github Users removed from moj-analytical-services
[x] NCC Users deleted from Development Control Panel
[x] NCC Users deleted from Production Control Panel
[x] Resources created by ITHC NCC contractors identified and deleted in Analytical Platform Data Production
[x] Resources created by ITHC NCC contractors identified and deleted in Analytical Platform Development
[x] This PR reverted
[x] Contents of #analytical-platform-ithc-2024 exported and channel archived

Completed. Channel archived.


The receiver similarly stops receiving anything:
Subscribing to udp://localhost:40123 on stream Id 10
0.0 msgs/sec, 0.0 bytes/sec, totals 0 messages 0 MB
new connection on udp://localhost:40123 streamId 10 sessionId 56153033 from <IP_ADDRESS>:56120
1.6e+04 msgs/sec, 6.4e+07 bytes/sec, totals 15985 messages 61 MB
1.1e+05 msgs/sec, 4.3e+08 bytes/sec, totals 123524 messages 478 MB
9.7e+04 msgs/sec, 4.0e+08 bytes/sec, totals 221404 messages 858 MB
9.9e+04 msgs/sec, 4.0e+08 bytes/sec, totals 321132 messages 1244 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 421841 messages 1635 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 523183 messages 2027 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 624001 messages 2418 MB
9.7e+04 msgs/sec, 3.9e+08 bytes/sec, totals 721437 messages 2796 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 823391 messages 3191 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 923508 messages 3579 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 1025915 messages 3976 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 1128058 messages 4372 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 1229930 messages 4767 MB
9.8e+04 msgs/sec, 4.0e+08 bytes/sec, totals 1328385 messages 5148 MB
1.0e+05 msgs/sec, 4.1e+08 bytes/sec, totals 1428736 messages 5537 MB
9.3e+04 msgs/sec, 3.8e+08 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
0.0 msgs/sec, 0.0 bytes/sec, totals 1522080 messages 5899 MB
... etc.

(Notice that the total "messages" received reported by the receiver are actually the total fragments received, which is another small bug in the sample app output, but ignore that for now...)
The publisher now appears to be unable to send forever.  Running AeronStat shows that SMs are still being sent and received (and sent/received counters match) and the "Heartbeats sent" and "Client Keep Alives" counters are still incrementing, but there's no other activity.  Here's some sample output from AeronStat when in this state:
10:10:33 - Aeron Stat
=========================
  0:        6,372,048,880 - Bytes sent
  1:        6,372,048,880 - Bytes received
  2:                    0 - Failed offers to ReceiverProxy
  3:                    0 - Failed offers to SenderProxy
  4:                    0 - Failed offers to DriverConductorProxy
  5:                1,283 - NAKs sent
  6:                1,283 - NAKs received
  7:              159,530 - SMs sent
  8:              159,530 - SMs received
  9:                1,756 - Heartbeats sent
 10:                1,283 - Retransmits sent
 11:                1,616 - Flow control under runs
 12:                    0 - Flow control over runs
 13:                    0 - Invalid packets
 14:                    0 - Driver Exceptions
 15:                    0 - Data Frame short sends
 16:                    0 - Setup Frame short sends
 17:                    0 - NAK Frame short sends
 18:                    0 - SM Frame short sends
 19:                1,441 - Client Keep Alives
 20:        6,372,048,880 - sender pos: udp://localhost:40123 56153033 a
 21:        6,388,826,096 - publisher limit: udp://localhost:40123 56153033 a
 22:        6,372,048,880 - subscriber pos: udp://localhost:40123 56153033 a
 23:        6,372,048,880 - receiver pos: udp://localhost:40123 56153033 a
 24:        6,372,048,880 - receiver hwm: udp://localhost:40123 56153033 a

The publisher and the driver are both burning a CPU core - the publisher probably from constantly trying and failing to send.  The receiver is fairly idle (and jstack shows it's just waiting for something to do).

Doing similar tests (sending large random-sized messages as fast as I can) using my own modified versions of the BasicPublisher/BasicSubscriber apps sometimes also results in the driver spewing out a stream of these:
[94314.322378] EXCEPTION [591/591]: java.lang.IndexOutOfBoundsException(index=-967317636, length=4, capacity=33554432)
uk.co.real_logic.agrona.concurrent.UnsafeBuffer.boundsCheck UnsafeBuffer.java:795
uk.co.real_logic.agrona.concurrent.UnsafeBuffer.getIntVolatile UnsafeBuffer.java:423
uk.co.real_logic.aeron.common.concurrent.logbuffer.FrameDescriptor.frameLengthVolatile FrameDescriptor.java:262
uk.co.real_logic.aeron.common.concurrent.logbuffer.LogScanner.scanNext LogScanner.java:114
uk.co.real_logic.aeron.driver.DriverPublication.onRetransmit DriverPublication.java:235

While my test apps have been modified a bit to do some message checksumming, etc., the driver hasn't been changed and is running in its own separate process.

I have also seen cases where, in AeronStat, the counts of NAKs and retransmissions also both go up slowly (along with the other counters originally mentioned in this report).

I can recreate this with the following code in the StreamingPublisher.
                ATOMIC_BUFFER.putLong(0, i);

                final int len = ThreadLocalRandom.current().nextInt(SIZE_OF_LONG, ATOMIC_BUFFER.capacity());

                while (!publication.offer(ATOMIC_BUFFER, 0, len))
                {
                    OFFER_IDLE_STRATEGY.idle(0);
                }

I believe this is due to fragmentation getting the tail off. I can reproduce this behavior with the following.
$ java -cp aeron-samples/build/libs/samples.jar -Daeron.sample.messageLength=8144 uk.co.real_logic.aeron.samples.EmbeddedThroughput

8144 should be exactly 2 full frames. 8192 - (2* header length).

@tmontgomery This does fix one class of bug but I can still make it happen with message lengths that are less than MTU size minus header.

drat! Everything lined up on that one. But now we have a data point that it isn't just fragmented messages.

Turned out to be an off-by-one error. Hate those!

@strangelydim can you re-run with the latest changes and see if these changes work for you?

Yep, will do.


Update mill-main to 0.10.4-18-e8ef33

Updates com.lihaoyi:mill-main from 0.10.4-5-d623fd to 0.10.4-18-e8ef33.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "mill-main" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.lihaoyi", artifactId = "mill-main" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #24.


A worker is stuck every time there is a error rendering

I'm rendering a map collection from workshop and as far as i know, the map autor has used non utf-8 characteres in the room name, bringing this error.

Every time it happens, i lost an worker until there is no one left (frezze)
Rendering only the top I found the "faulty" chunks (since they didn't render) and removed them from the project, however I think it would be very useful for the worker to abandon the rendering in case of failure.

First top rendering, stuck in 3 chunks.
Was able to found the faulty ones,

Here they are in case you want to see
maps.zip

added support for room name encoding commit

Added task retry and error handling. See commit


[Feature request] Allow different prism color schemes for light and dark mode

Feature request
Description
The current version of plugin vuepress-plugin-prism does not provide userful configuration options. Under light mode of Vuepress, a light background of code block is more appropriate for reading, like the VS color scheme. Currently the default color scheme only fits the dark background.
Different prism color scheme configurations for light and dark modes are very required.
Proposed Solution
Two options of plugin-prism in config.ts: colorScheme : <string> and colorSchemeDark : <string>

I think it's better to importing the prism theme manually 🤔
The documentation should be improved

vuepress-theme-hope supports it, you can see it's implementation. I think it's not necessary for default theme to support it if we want the theme to be simple.


Use lower quorum for smaller validator sets

Codecov Report

Merging #2044 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2044      +/-   ##
===========================================
- Coverage    67.66%   67.63%   -0.03%
===========================================
  Files          680      680
  Lines        49199    49204       +5
===========================================
- Hits         33289    33278      -11
- Misses       15910    15926      +16

Impacted Files
Coverage Δ

src/ripple/app/misc/ValidatorList.h
96.61% <100%> (-1.7%)
:x:

src/ripple/app/misc/impl/ValidatorList.cpp
83.33% <100%> (+1.46%)
:white_check_mark:

src/ripple/core/Stoppable.h
90% <0%> (-10%)
:x:

src/ripple/basics/DecayingSample.h
77.77% <0%> (-8.34%)
:x:

src/ripple/app/ledger/PendingSaves.h
93.54% <0%> (-6.46%)
:x:

src/ripple/app/misc/impl/LoadFeeTrack.cpp
81.53% <0%> (-4.62%)
:x:

src/ripple/app/main/LoadManager.cpp
69.86% <0%> (-4.11%)
:x:

src/ripple/basics/impl/make_SSLContext.cpp
52.22% <0%> (-1.28%)
:x:

src/ripple/core/impl/Workers.cpp
98.86% <0%> (-1.14%)
:x:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69bc58c...c2d3ce0. Read the comment docs.

:neckbeard::+1:

In 0.60.0-rc3


reload datatables every x seconds

Is it okay to use setTimeout to reload my datatables in every 5 seconds ?
I tried to put in drawcallback

"drawCallback": function( settings ) {
          setTimeout(function(){
              mytable.ajax.reload();

          },5000);

      }

I don't see why not. I would use setInterval myself if you want to do it periodically.
In future, please post support requests in the DataTables forums. GitHub issues are got bugs only not support.

I apologize.  Thank you I will use setInterval :)


[spinel] add reboot to bootloader command

implemented for erf32 which requires setting the reset reason

Overall looks great.
Can you also please help update the spinel documentation about the newly added  command SPINEL_CMD_REBOOT_BOOTLOADER here spinel-commands.md? Thanks.

@jwhui I just noticed this existing PR after implementing identical functionality (https://github.com/puddly/openthread/commit/76db52357c4274aa3e601daa3e681e08ecba7a34) by instead adding a new reset type and using SPINEL_CMD_RESET.
I'd like to upstream my changes. Would you prefer the approach in this PR (a new command), or is extending SPINEL_CMD_RESET fine?


fix: support secret patching for issuing controller

Signed-off-by: Yuval Manor<EMAIL_ADDRESS>Pull Request Motivation

Resolves:  #4880
Kind

Release Note

Hi, thanks for opening the PR, however the issuing controller is part of certificates controllers and has already been granted a permission to patch Secrets here (in any case all the controllers are bundled into a singe cert-manager controller deployment, so the splitting into separate roles is for readability and maintenance)
I've commented on the original issue.

The issue was closed because the fix was already done on v.1.71, and the fix is for v1.6.1


travis: no such file or directory

SEE: https://travis-ci.org/futagoza/ePEG.js/builds
If you look at the first 9 build attempts at travis you will notice it keeps failing because of the ENOENT error 'No such file or directory', but at build 10 this is fixed.
It seems the error was only popping up because of the command line:
pegjs --output lib/parser.js src/parser.pegjs

But it worked as soon as I put my parser generator into a JavaScript file and ran it via:
node scripts/generate-parser.js

@futagoza Please provide steps to reproduce the problem using an official PEG.js release or code from master. I won’t debug CI builds of third-party projects. Thanks.

@dmajda which do you mean:

to use the npm package pegjs instead of pegjs-dev
something other then https://github.com/futagoza/ePEG.js

I used to use https://www.npmjs.com/package/pegjs, and never had this issue with Travis when using PEG.js's CLI, but after switching to the latest changes via https://www.npmjs.com/package/pegjs-dev, I had started using scripts so that I could do some pre-processing work on the grammar.
Now when I started work on https://github.com/futagoza/ePEG.js I decided to use PEG.js's CLI since I didn't require the need of any pre-processing, but found this bug via Travis.
From what I can tell, it seems to be only cropping up on Linux (Travis only use's Linux, doesn't it?), where on my OS (Windows 10 Home x64) it works fine, via CLI or module, weather it's pegjs or pegjs-dev

@dmajda which do you mean:

to use the npm package pegjs instead of pegjs-dev
something other then https://github.com/futagoza/ePEG.js

Both, really. The issue is that both the pegjs-dev package and ePEG.js introduce additional variables into the equation, making it possible that the bug lies there, not in PEG.js itself. This is why I insisted on reproducing the problem with PEG.js itself.
The way I see it, in situations like this the burden of proof that the bug is indeed in PEG.js lies on the reporter. If he/she can’t provide such proof or at least a convincing argument, I have to assume the bug lies elsewhere. Anything else would mean I’d end up debugging third-party code, which is simply something I’m not willing to do.

Anyway, thanks for the reproducing steps. I distilled them into a shell script which I put up as a gist. I tried to run this script in two environments:

OS X El Capitan (10.11.5) with Node.js 6.0.0 installed via nvm.
Ubuntu 14.04 with Node.js 6.0.0 installed via nvm.

In both cases there was no error and the parser was generated in lib/parser.js. This indicates bin/pegjs works just fine.
To proceed further I need to reproduce the problem. If you can reproduce it in some environment with the script I wrote (or some modification of it), please describe such environment. Otherwise I’ll have to close this bug.

I just tried it (the '434.sh' script you provided) on both my Windows 10 laptop (using Cygwin) and on Linux (using Travis), and it seems to work fine.


Update MySqlConnector to 1.2.0

MySqlConnector 1.0 changes the primary namespace to MySqlConnector: https://github.com/mysql-net/MySqlConnector/issues/824; this updates all relevant code.
This starts the discussion around updating MySqlConnector to 1.0, but doesn't need to be merged until it's out of beta.

@bgrainger Thanks for doing this! I'll be reviewing the PR asap. I should also update other dependencies as well.

PR updated to 1.0 (RTM).

@bgrainger sorry the delay and the long due response to this. This was a crazy year. I'm getting back at this, primarily I created the docker configuration files to launch all the target dbs to run the tests, so I can move forward and updated all the nuget packages and configurations being 100% sure that I'll be able to run the tests.
I'll need to updated the mysql package. I created a new branch new-v2.4.0 for all the updates. I don't know if it's best to do this change there, If you want me to do the update, or you want to make a new pull request for that branch. I don't know if changing the base branch will work. I don't want to bother you, so I can do it myself, but I want to check first.
Thanks!

I can retarget this PR against new-v2.4.0.

Done; also updated to MySqlConnector 1.2.0 since that's been out for a bit now.

Thanks again @bgrainger for your change! The PR has been merged.


Build docs action

add an action that automatically places docs into different folders depending on their version, e.g. dev, 0.3.4, etc.
I also have a bad-looking index page to add to the docs repo once this gets merged. I might look into this more and see if I can do it with Github Pages instead so it looks okay.

Thanks @kne42! I see this is still marked as draft, did you want us to review/ merge now or did you want us to wait until you've looked into Github Pages more?

I want to look into GH Pages more so the index page doesn't look so terrible

I want to look into GH Pages more so the index page doesn't look so terrible

Sounds good! Let us know when this is ready for review :-)

Looks like there has been an error in the build because of a missing token
github-actions
/ Build & Publish Docs

.github#L1
Input required and not supplied: token

see here https://github.com/napari/napari/actions/runs/283517324
Any ideas for a fix @kne42?


notification receives but doesn't appear on Ios 10.2

@evollu Hey,
i am using version 2.5.6.
This is my backend request object;
{
  to: "XXXX"
  notification: {
    body: "notification",
    sound: 'default'
  },
  priority: "high",
  show_in_foreground: true,
  content_available: true
}

and this is the object i log inside didReceiveRemoteNotification;
{
 aps:
   {
    alert: 'notification',
     sound: 'default',
     'content-available': '1'
  },
  opened_from_tray: 0,
  'gcm.message_id': '0:1487863844312842%6b84bc066b84bc06'
}

İt works under ios 10, but doesn't appear on ios 10.2, both in foreground and background.

can you put "show_in_foreground" in "data"?
{
  to: "XXXX"
  notification: {
    body: "notification",
    sound: 'default',
    priority: "high"
  },
  data: {
    show_in_foreground: true,
  }
  content_available: true
}

i did but no changes...

my phone is 10.2.1 and it works fine. here is my payload
{
    "to":"xxxx",
    "content_available": true,
    "notification": {
        "title": "hello",
      "body": "yo",
        "click_action": "123"
    },
    "data": {
    	"show_in_foreground": true,
        "a": 1
    },
  "priority": "high"
  }

@evollu if I send message from firebase notification console UI, how do I set show_in_foreground ? I tried the custom data section, but didn't help.

@evollu  sorry, ignore it. I misunderstood

Hi, this problem is still happening for devices with ios 10 and above and using react native fcm  version 2.5.6.
I receive the notification in FCM.on, but it doesn't pop up in tray or when app is in background.

@evollu Can you confirm that version 2.5.6 works on ios 10.2+?
I'd like to know if it's a problem with my configuration or if I'll need to update to the latest version of react-native-fcm to receive the notifications.

close due to inactivity

was this solved? im having this problem in ios version 10+. RN version 0.34.0 and FCM version 2.5.6. the notification can be received but not displayed

Same problem here, it works well in all iOS version but in 10.2 is not...


Updated for linter 2.0.0

Closes #36

What is the status on this being merged and released?

@Arcanemagus - I have the same question as @jeremyf. Is there anything else I can do to help this along?

It looks good to me, since I sent in an approval review... unfortunately as this isn't under the AtomLinter organization that's all I can do here. We'll need to wait for @gepoch to merge this and release a version that includes these changes.
Unfortunately it doesn't look like they have been active on GitHub in several years so you might be better off forking this. If you do go that route and want it placed under the AtomLinter organization so this isn't an issue in the future for it just let me know. The same goes for you @gepoch! If you want to transfer this to the AtomLinter organization so it can continue to be maintained just let me know!

Thanks, @Arcanemagus! I'll give @gepoch a week to respond. If he doesn't, I'll fork it and work with you to put it under the AtomLinter org.

Hey folks, sorry for the delay... I haven't been using Atom for a couple of years now, so I'm happy to transfer this over to the atom linter org. If you lemme know what I need to do, I'll take care of it!

Full article is here: Migrating a repository
The tl;dr though is to transfer it to me and I'll get it moved into the organization 😉. Thanks!

@Arcanemagus transfer request sent! Thanks for taking care of it!

Transferred to the organization, thanks!

@davidlday Let me know if you want to be added to the maintainers team for this repository, I'll be doing some cleanup and maintenance on it and getting a release published, but it would be great to have somebody that uses it 😉.

@Arcanemagus Would love to help out as part of the maintainers team.

:tada: This PR is included in version 0.9.1 :tada:
The release is available on:

GitHub release
Atom package

Your semantic-release bot :package::rocket:


Using two GC9A01 multiple displays at the same time

Hi, all I'm trying to use multiple display with lv_port_esp32 lib and lvgl_esp32_drivers
Both displays are shared the same SPI (SCL, SDA, DC) control by different CS pins (14 & 15)
I have modified the lvgl_helpers.c to allow register both displays
disp_spi_add_device(TFT_SPI_HOST,15);

    disp_driver_init();

    static lv_color_t buf1[DISP_BUF_SIZE];
    static lv_color_t buf2[DISP_BUF_SIZE];
    static lv_disp_buf_t disp_buf;

    uint32_t size_in_px = DISP_BUF_SIZE;

    lv_disp_buf_init(&disp_buf, buf1, buf2, size_in_px);

    lv_disp_drv_t disp_drv;
    lv_disp_drv_init(&disp_drv);
    disp_drv.flush_cb = disp_driver_flush;

    disp_drv.buffer = &disp_buf;
    dis1 = lv_disp_drv_register(&disp_drv);

    //dis1 = lv_disp_get_default();

    disp_spi_add_device(TFT_SPI_HOST,14);

    disp_driver_init();

    static lv_color_t buf21[DISP_BUF_SIZE];
    static lv_color_t buf22[DISP_BUF_SIZE];
    static lv_disp_buf_t disp_buf2;

    lv_disp_buf_init(&disp_buf2, buf21, buf22, DISP_BUF_SIZE);

    lv_disp_drv_t disp_drv2;
    lv_disp_drv_init(&disp_drv2);
    disp_drv2.flush_cb = disp_driver_flush;

    disp_drv2.buffer = &disp_buf2;
    dis2 = lv_disp_drv_register(&disp_drv2);

As well the disp_spi.c to allow spi_bus_add_device for different CS pin
void disp_spi_add_device_with_speed(spi_host_device_t host, int clock_speed_hz, int cs_pin)
{
    ESP_LOGI(TAG, "Adding SPI device");
    ESP_LOGI(TAG, "Clock speed: %dHz, mode: %d, CS pin: %d",
        clock_speed_hz, SPI_TFT_SPI_MODE, cs_pin);

    spi_device_interface_config_t devcfg={
        .clock_speed_hz = clock_speed_hz,
        .mode = SPI_TFT_SPI_MODE,
//		.mode = 3,
        .spics_io_num=cs_pin,              // CS pin
        //.spics_io_num=-1,
        .input_delay_ns=DISP_SPI_INPUT_DELAY_NS,
        .queue_size=1,
        .pre_cb=NULL,
        .post_cb=NULL,
#if defined (CONFIG_LVGL_TFT_DISPLAY_CONTROLLER_FT81X)
        .flags = 0,
#elif defined (CONFIG_LVGL_TFT_DISPLAY_CONTROLLER_RA8875)
        .flags = SPI_DEVICE_NO_DUMMY,
#else
        //.flags = SPI_DEVICE_NO_DUMMY | SPI_DEVICE_HALFDUPLEX,
#endif
    };

    disp_spi_add_device_config(host, &devcfg);
}

With use of lv_obj_t *scr1 = lv_disp_get_scr_act(dis1) & lv_obj_t *scr1 = lv_disp_get_scr_act(dis2)
To switch between displays, however, only the last init display shows graphs
I suspect the dis1 and dis2 are the same, is there any way to tell which is which by printout display information?
Also thought of the disp_driver_flush callback from this line:
disp_drv.flush_cb = disp_driver_flush;

It ends here:
void GC9A01_flush(lv_disp_drv_t * drv, const lv_area_t * area, lv_color_t * color_map)
{
	uint8_t data[4];

	/*Column addresses*/
	GC9A01_send_cmd(0x2A);				//0x2A
	data[0] = (area->x1 >> 8) & 0xFF;
	data[1] = area->x1 & 0xFF;
	data[2] = (area->x2 >> 8) & 0xFF;
	data[3] = area->x2 & 0xFF;
	GC9A01_send_data(data, 4);

	/*Page addresses*/
	GC9A01_send_cmd(0x2B);				//0x2B
	data[0] = (area->y1 >> 8) & 0xFF;
	data[1] = area->y1 & 0xFF;
	data[2] = (area->y2 >> 8) & 0xFF;
	data[3] = area->y2 & 0xFF;
	GC9A01_send_data(data, 4);

	/*Memory write*/
	GC9A01_send_cmd(0x2C);				//0x2C

	uint32_t size = lv_area_get_width(area) * lv_area_get_height(area);

	GC9A01_send_color((void*)color_map, size * 2);
}

It didn't use the variable "drv", how does it know which display to flush?
I have seem other drivers using this in the end of function:
lv_disp_flush_ready(drv);

However, it does not help... any thought will be appreciate!

Hello @poky ,
I didn't dig too deep into the code, but here are few tips:

Let's assume that your modifications to the SPI driver are working (your spi send function can switch CS between displays)
The you basically need to do this section of code https://github.com/lvgl/lv_port_esp32/blob/master/main/main.c#L85-126 (lines 85-126) twice: Define two drivers and their buffers and register them.
This will create a separate task for each driver, the task calls disp_drv.flush_cb() with correct arguments, when needed
I have a suspicion that your lv_disp_drv_t disp_drv; definition becomes invalid after disp_spi_add_device function exits, so please make it static or refactor

Thank you @tore-espressif
I have followed your suggestion, now it works independently!

Another question, if I want to make it mirror, according to the LVGL doc

To mirror the image of the display to another display, you don't need to use the multi-display support. Just transfer the buffer received in drv.flush_cb to another display too.

I now have :
lv_disp_t* dis1;
lv_disp_t* dis2;

Could you suggest how do  I suppose to send dis1's buffer to dis2?
Thanks!

Good job :)
I've never tried mirroring, but this is the idea:

You have just one driver, one buffer and one task
You need to modify GC9A01.c driver to write/flush two devices at once
Functions like GC9A01_send_cmd GC9A01_send_data GC9A01_send_color must send the same data to both displays
Don't forget to initialize both displays and their pins (DC, RST, possibly BCKL) in GC9A01_init

Thank you! I have figured out how to do it, this issue may closed


Update "Pokédex" and "Offense Pokédex Coverage" for Generation 9

https://pokemondb.net/pokedex/game/scarlet-violet
https://pokemondb.net/scarlet-violet/exclusive
https://pokemondb.net/pokedex/stats/gen9

well that was fast lol. i'm hoping that pokeapi.co gets updated with this data soon, but i miiiight try to make a temporary update that uses both data sources combined...
the stats table in particular has all the data i need for the pokedex... so i might see if i can whip something up tonight

Done! Thanks for the stats table, that was perfect.
https://www.pkmn.help/pokedex/


add @clientName

fixes #114
Bigger code change because I found out that our scoped decorator can't handle multiple different values per scope

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/127/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/127/

also fixes: https://github.com/Azure/typespec-azure-pr/issues/3496


[ENG-275] Fix/tier listing not found

Description

handle "no results" error from tierListing as not found rather than ZodError
set all beta getStaticProps to return paths: []

to tell Netlify in no uncertain terms not to try to generate pages at build time
also because we've not been maintaining the getPaths functions in light of the teachers-2023 changes, so best to remove them, otherwise they represent tech debt

remove all references got curriculumApi.get...Paths() functions

How to test

Go to https://deploy-preview-1757--oak-web-application.netlify.thenational.academy/beta/teachers-2023/key-stages/ks4/subjects/NOT_A_SUBJECT/programmes
It should return 404 but because of Netlify flaws, it will return Internal server error in preview env

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

Looks good, with these changes will there be no static pages built at build time ?

@JBR90 no static pages at build time, which Netlify doesn't support and we don't want currently.
See discussion here: https://oaknationalacademy.slack.com/archives/C011QBA2VU5/p1689930848305909

:tada: This PR is included in version 1.203.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


drivers: wifi: esp: optimize +CIPRECVDATA handling

It seems that we don't need to keep track of how many bytes were notified as "ready/waiting" using +IPD message in passive mode. It is enough to always request MRU number of bytes whenever +IPD has been received.
Additionally we can rely on receiving +IPD after each +CIPRECVDATA (assuming there will be more bytes to read), so we can safely schedule AT+CIPRECVDATA only after receving +IPD, removing any other logic (e.g. scheduling automatically after AT+CIPRECVDATA hasn't retrieved all data in single shot).

Have you tried this with ESP8266 NONOS? IIRC there was some difference between the two firmwares 🤔

@tsvehagen No, I haven't tested NONOS version... just ESP AT v2.1.0_esp8266. Unfortunately I can't test that now, maybe beginning of next year I will manage to get NONOS on my board...

@tsvehagen I wasn't able to get NONOS version for the board I am using. Is there a chance you could test those changes when you have some spare time? Or could you point me to the fastest way to do tests on my side (which board to use, where to download firmware or how to compile). I am no expert in ESP related stuff and most links point to newer (RTOS) version of ESP AT command interface.
I have some pending patches which introduce thread safe operations on esp_socket objects. They however depend on open PRs related to ESP WiFi driver, including this one. So I would really like to move this forward.

@tsvehagen I wasn't able to get NONOS version for the board I am using. Is there a chance you could test those changes when you have some spare time? Or could you point me to the fastest way to do tests on my side (which board to use, where to download firmware or how to compile). I am no expert in ESP related stuff and most links point to newer (RTOS) version of ESP AT command interface.
I have some pending patches which introduce thread safe operations on esp_socket objects. They however depend on open PRs related to ESP WiFi driver, including this one. So I would really like to move this forward.

@mniestroj I have used a esp8266 board with NONOS 3.0 (https://github.com/espressif/ESP8266_NONOS_SDK/releases/tag/v3.0) before.
I haven't been able to test this yet but I think it's ok to go ahead with this anyway. Maybe NONOS firmware support can be dropped anyway since Espressif is no longer developing it. The only reason to keep I guess would be to support boards without users needing to reflash the firmware.

@mniestroj I have used a esp8266 board with NONOS 3.0 (https://github.com/espressif/ESP8266_NONOS_SDK/releases/tag/v3.0) before.
I haven't been able to test this yet but I think it's ok to go ahead with this anyway. Maybe NONOS firmware support can be dropped anyway since Espressif is no longer developing it. The only reason to keep I guess would be to support boards without users needing to reflash the firmware.


Android 10 device: SELinux gives permission denied when trying to replay

Unfortunately it seems that on Android 10 it's no longer allowed to write to /dev/input/eventX.
Errors:
could not open /dev/input/event2, Permission denied
And in logcat:
mysendevent: type=1400 audit(0.0:18056): avc: denied { write } for name="event2" dev="tmpfs" ino=13462 scontext=u:r:shell:s0 tcontext=u:object_r:input_device:s0 tclass=chr_file permissive=0
So i am afraid you need root access for replay. Recording goes well.

So, could not get replay to work on my Andorid 10 device, but I did succeed in recording on device, and then replaying on 10.0 Emulator. Really cool.
Use
su
setenforce 0

to disable SELinux in adb shell on the emulator.
I wrote a script to convert the absolute x,y positions from the recording to relative coordinates, since the emulator uses a different scale on both x,y event though I recreated the exact screen specs in a emulator. So using these MAX_Y and MAX_X properly, I can now reproduce my touch event recording on device on a emulator.

Thank you for sharing this info. At least we can use in the emulator.

So this won't run on Android 10 devices because I am getting the same error 😔?

@fadiaburaid I don't think so, they keep adding extra security making these kinds of scripts harder to run

Thanks @Cartucho . I have managed to translate the hex getevent codes for taps to "adb shell input" format with the delay time between taps using the timestamps. However translating swipes will be very tricky.


Review repo branch protections rule on main

After review and discussion with @bjlittle the branch protection rules have been updated.


profile edit: contact

currently when user is in profile/edit and clicks the contact button it is missleading where the email is sent to:

actually the email isn't been sent to the Speakerinnen-Team but to the person itself.
I think we should

disable that button in the edit view
add the footer on every site

Done.
https://github.com/rubymonsters/speakerinnen_liste/commit/1dedfd949d0596135baadcfe7480f8a3ab97c9e3


Variables from .env not being loaded

I'm trying to use dotenv to run a Sinatra-based application locally ( https://github.com/FlorianZ/hadashboard -- built on Dashing) but am not having any success. Note that I'm more of a Python person and am pretty rusty on Ruby.
I've installed the dotenv gem and have added it to my Gemfile as described in the README (see my Gemfile below). I've also tried it without the :groups qualifiers.
I then added it to the "config.ru" file, which is where I understood it to belong as far as adding it to the bootstrapping process of the app:
require 'omniauth-heroku'
require 'dashing'
require 'dotenv'

# Load environment variables using Dotenv. If a .env file exists, it will
# set environment variables from that file (useful for dev environments)
Dotenv.load
...

However, even though I've added a .env file to my project root, when I start the server (using dashing start) it doesn't seem to be picking up any of the environment variables set in that file.
Gemfile:
source 'https://rubygems.org'

gem 'dotenv-rails', :groups => [:development, :test], :require => 'dotenv/rails-now'

gem 'eventmachine', '= 1.0.6'
gem 'dashing'
gem 'thor'

# Authentication
gem 'oa-openid'
gem 'omniauth-heroku', '~> 0.2.0.pre'
gem 'oauth2'

# JSON
gem 'json'

# Database
gem 'data_mapper'

# Development
group :development do
	gem 'dm-sqlite-adapter'
end

# Production
group :production do
	gem 'dm-postgres-adapter'
end

There are no errors when running the application, except for those caused by my environment variables being empty. Any help would be appreciated. Again, talk to me like I haven't touched Ruby in 8 years. Because I haven't. ;)

I think the problem here is that you required dotenv-rails in the Gemfile which is for rails, instead of dotenv which is for pure ruby. So with that and placing Dotenv.load a bit higher up in config.ru I got the variables loaded.
Here are the relevant changes:

Gemfile:

source 'https://rubygems.org'

gem 'dotenv'
gem 'dashing'
gem 'thor'
...

config.ru

require 'dotenv'
Dotenv.load
require 'omniauth-heroku'
require 'dashing'
...

Hope it helps!

@rogersmj let us know if @z2s8's answer doesn't help you out.
@z2s8 thanks for helping out!


Better fix for crash on member selects inside module-info.java

Now, in matchMemberSelectTree(), we check if the MemberSelectTree represents a reference to a module.  If it does, we do not check if its base expression could be null.  This change gives us a stronger invariant in mayBeNullExpr(): any IdentifierTree or MemberSelectTree passed to mayBeNullExpr() should have a non-null symbol.  We explicitly check this to help us flag any future weird cases more easily.
Unfortunately, to maintain JDK 8 compatibility, the check for whether a MemberSelectTree represents a module requires reflection.  I don't expect any measurable impact on performance but I will check.  If / when NullAway requires JDK 11, we can and should get rid of the reflection.
Code coverage is reduced due to the new runtime checks for (hopefully) impossible cases in mayBeNullExpr().
Fixes #533

Pull Request Test Coverage Report for Build #683

0 of 0   changed or added relevant lines in 0 files are covered.
51 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 89.602%

Files with Coverage Reduction
New Missed Lines
%

../nullaway/src/main/java/com/uber/nullaway/NullAway.java
51
93.75%

Totals

Change from base Build #681:
-0.07%

Covered Lines:
4119

Relevant Lines:
4597

💛  - Coveralls

I ran a jmh test with current master and with a branch including this PR and also #543.  Master results:
Benchmark                      Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile  thrpt   25  17.290 ± 0.193  ops/s
CaffeineBenchmark.compile     thrpt   25   4.176 ± 0.042  ops/s

With the PRs applied:
Benchmark                      Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile  thrpt   25  17.310 ± 0.173  ops/s
CaffeineBenchmark.compile     thrpt   25   4.118 ± 0.036  ops/s

Differences are in the noise, but barely so for Caffeine.  Also, in this previous test from a few weeks ago things seemed to be running every so slightly faster.  Of course, something could have changed on my machine between then and now.  I'll try to do some more tests of recent versions to see if I can consistently find some issue.
For now, I don't think any potential perf regression is at a worrysome level.  Will poke a bit more.

After trying some more measurements, I think our jmh setup is a bit too noisy to detect possible 1-2% perf regressions.  It's possible running the jmh harness outside of Gradle (i.e., killing the Gradle daemon and invoking the JVM directly) might stabilize things a bit more, but I'm not sure.  I am comfortable that these changes do not seem to be introducing a large perf regression.  But @lazaroclapp if you want me to try to do more careful testing, let me know.

Another perf update: I managed to run jmh on a different machine in a config where the noise was reduced a bit.  (Running jmh directly rather than via Gradle does seem to help a bit.)  Bottom line, it looks like any perf differences are in the noise.  It's still hard to be 100% confident of this without doing a ton of runs.  I do worry about very slight perf regressions adding up over time...but we're still doing a lot better than we used to with this stuff.  Probably would be good to dig into profiles once in a while to see if anything new pops out.

Not related to this PR, but I wonder if there is a good automatic way that we can check for long term performance regressions. Maybe just run our perf testing on a dedicated machine for the last ~5 NullAway releases before cutting a new release? Will probably not happen for 0.9.5, though.

Not related to this PR, but I wonder if there is a good automatic way that we can check for long term performance regressions. Maybe just run our perf testing on a dedicated machine for the last ~5 NullAway releases before cutting a new release? Will probably not happen for 0.9.5, though.

Yes, this is a really good idea.    We don't consistently do perf testing for every PR, so this could catch larger unexpected regressions as well.


DB Connection Pool Exhaustion

I'm facing a problem with an Asp.Net Core app where database connections get exhausted  the application crashes with this exception:
System.InvalidOperationException: Timeout expired.  The timeout period elapsed prior to obtaining a connection from the pool.  This may have occurred because all pooled connections were in use and max pool size was reached.
The action method in question is as below:
       [HttpPost]
        public async void Post(DeviceState state)
        {
            using (var connection =  new SqlConnection("Data Source=localhost;Integrated Security=True");) // Using the default max pool size of 100
            {
                await connection.OpenAsync();
                (var command = new SqlCommand($"INSERT INTO test_db.dbo.DeviceState (fqdn, content_name, bytes_from_peer, bytes_from_source, total_size) VALUES(@fqdn, @content_name, @bytes_a, @bytes_b, @total_size)",
                    connection))
                {
                    AddParameter(command, "@fqdn", SqlDbType.VarChar, state.Fqdn + Guid.NewGuid());
                    AddParameter(command, "@content_name", SqlDbType.VarChar, state.ContentName);
                    AddParameter(command, "@bytes_a", SqlDbType.BigInt, state.BytesA);
                    AddParameter(command, "@bytes_b", SqlDbType.BigInt, state.BytesB);
                    AddParameter(command, "@total_size", SqlDbType.BigInt, state.TotalSize);

                    await command.ExecuteNonQueryAsync();
                }
            }
        }

And this is the AddParamter() helper method:
 private static void AddParameter(SqlCommand command, string name, SqlDbType type, object value)
        {
            var param = command.CreateParameter();
            param.ParameterName = name;
            param.SqlDbType = type;
            param.Value = value;
            command.Parameters.Add(param);
        }

What the Post() method is doing is INSERTing a row into a table called DeviceState every time it is called. DeviceState table was created with the below T-SQL snippet:
  create table [cdc_test_db].[dbo].[DeviceState](
   fqdn varchar(255) primary key not null,
   content_name varchar(500) not null,
   bytes_a bigint,
   bytes_b bigint,
   total_size bigint
)

I'm using the default max pool size of 100. I'm seeing these exceptions at 20000 requests/s. But interestingly enough I see that the app starts to use all 100 connections even at very low request rates like 1000 requests/s. This is different from the behaviour of classic Asp.Net (4.8) which never goes beyond 10 connections even while delivering 4000-5000 requests/s. Is Asp.Net Core designed to be aggressive when opening DB connections?
I've also observed this problem occurs only when my action method is async and uses  async versions of all data APIs. When I switch everything to synchronous code, the problem goes away. So I wonder if this is something caused by async tasks holding onto the DB connections for too long while waiting to be scheduled on the thread pool. What am I doing wrong?
Or is it just a manifestation of this issue: https://github.com/dotnet/SqlClient/issues/18, which from what I know should've been fixed in the Microsoft.Data.SqlClient version I'm using (see below).
Details:

Asp.Net Core version: 3.1
OS: Windows Server 2016
Database: SQL Server 2016 Standard Edition
Microsoft.Data.SqlClient version: 1.0.19269.1

From what it sounds like, this issue is probably better filed in the SqlClient repo. cc @ajcvickers @smitpatel any thoughts?

@gurry As @jkotalik says, this is a SqlClient issue.  If so, then this is likely the issue your linked since the fix has not yet been ported to System.Data.SqlClient. If not, please file a new issue on the SqlClient repo.

@ajcvickers  Yeah I'm certainly using Microsoft.Data.SqlClient. As per @cheenamalhotra the version I'm using, 1.0.19269.1, should contain the fix. Just to be sure, I tried with version 1.1.0 also just now, but the issue still occurred even with that version.
Arthur, if you can transfer the issue to SqlClient repo, please do. Otherwise I'll go and copy-paste it there. Thanks :).

Can you provide the link to the new issue once it's created? I've been experiencing problems like this ever since async/await was introduced into ADO.NET. My solution has always been to use the sync APIs as they don't exhibit the problem.

Reported it under SqlClient as suggested: https://github.com/dotnet/SqlClient/issues/364

Turned out to be not an issue in SqlClient or AspNetCore. It was due to an error in my code. See my closing comment on dotnet/SqlClient#364.


Parsing: Sources that aren't URL-encoded can contain URLs with brackets, parens, and other separator symbols

Describe the bug
I was trying to archive this Wikipedia page:
https://en.wikipedia.org/wiki/Insert_(effects_processing)
Archivebox sees it as:
https://en.wikipedia.org/wiki/Insert_
Bad box! No cookie! :)
Steps to reproduce
echo 'https://en.wikipedia.org/wiki/Insert_(effects_processing)' | archivebox add
Screenshots or log output
[+] [2019-05-06 22:21:48] "en.wikipedia.org/wiki/Insert_"
    https://en.wikipedia.org/wiki/Insert_
    > ./archive/1557178364.70
      > title
      > favicon
      > wget
      > pdf
      > screenshot
      > dom
      > media
      > archive_org

Software versions

OS: Debian buster 10
ArchiveBox version: 0.4.1 installed from pypi
Python version: 3.7.3 something
Chrome version: irrelevant?

Workaround
Run sed 's/(/%28/;s/)/%29/' over the list of URLs, although I suspect more special characters might be affected.

Ah damn, I explicitly stop parsing at those characters because of cases like this:
>>>parse('This is some text in a markdown file with [a link](https://example.com)/[some other link](https://example.com/b/)...')
['https://example.com)/[some', 'https://example.com/b/)...']

The current regex looks like this:
URL_REGEX = re.compile(
    r'http[s]?://'                    # start matching from allowed schemes
    r'(?:[a-zA-Z]|[0-9]'              # followed by allowed alphanum characters
    r'|[$-_@.&+]|[!*\(\),]'           #    or allowed symbols
    r'|(?:%[0-9a-fA-F][0-9a-fA-F]))'  #    or allowed unicode bytes
    r'[^\]\[\(\)<>\""\'\s]+',         # stop parsing at these symbols
    re.IGNORECASE,
)

I don't see any easy solutions, but there are a few crappy options:

require all URLs be URL-encoded before parsing
add a config option to enable parsing of () and [] in URLs
attempt to autodetect the import format and parse accordingly (this is extremely hard)

I don't think the problem is limited to markdown files unfortunately, so I'm hesitant to add a separate parser just for markdown to paper over the issue. there are lots of formats that have meaningful symbols to break up URLs that are also valid URL characters.

i think it might be worth making it possible for archivebox add to be told what kind of input to expect.
if it's a "one URL per line" file, it shouldn't do any parsing except for splitting on newlines. same with known JSON or bookmarks formats...

if it's a "one URL per line" file, it shouldn't do any parsing except for splitting on newlines. same with known JSON or bookmarks formats...

I think this is reasonable, if the first line starts with http... and ends with \n we can probably consider the whole import to be raw URLs separated by newlines.
It gets harder when parsing other types of sources though (e.g. txt, markdown, arbitrary html, etc):
http://what.if.it's.a.markdown/document/that/just/happens/to/start/with/a/url.html?difficult=true&thought=required
# This is some *markdown text [containing](http://exmaple.com/several/example_urls(abc)).*
There may be raw http://urls.example.com embedded in the text with whitespace too.


Upgrade cosmwasm 0.6

Closes #30
This just uses a rust mock out for the api functions (human/canonical address).
We will properly handle those with go callbacks in #25

Hit error with the Params format.
the simple serde-json-wasm uses normal arrays for binary data... eg
{"block":{"height":12345,"time":1571797419,"chain_id":"cosmos-testnet-14002"},"message":{"signer":[109,121,32,110,97,109,101,0,0,0,0,0,0,0,0,0,0,0,0,0],"sent_funds":null},"contract":{"address":[99,111,115,109,111,115,50,99,111,110,116,114,97,99,116,0,0,0,0,0],"balance":[{"denom":"atom","amount":"100"}]}}

Note: "signer":[109,121,32,110,97,109,101,0,0,0,0,0,0,0,0,0,0,0,0,0] whereas go encodes it like: "signer":"Y3JlYXRvcgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
Correct is to update the json parser in cosmwasm, but that will take a while.
For now, I will just force go to serialize like this.


Search editor revealDefinition resolves to an invalid path

VSCode Version: 1.47.2
OS Version: macOS Mojave 10.14.6

Steps to Reproduce:

Open a search editor window with a query via search.action.openNewEditor
Use reveal definition on an entry editor.action.revealDefinition
You should see an error like the following:

Unable to open 'types.ts': Unable to read file '/Users/user/project/folder/folder/src/types.ts' (Error: Unable to resolve non-existing file '/Users/user/project/folder/folder/src/types.ts').

Although the path for /Users/user/project/folder/folder/src/types.ts (without an extra /folder) exists, the issue is that VSCode inserts a duplicate folder upon revealing the definition.

Does this issue occur when all extensions are disabled?: Yes

Thanks for reporting this!
Do you have a multi-root workspace set up?

Yes I do:
	"folders": [
		{
			"name": "Frontend",
			"path": "frontend"
		},
		{
			"name": "Webserver",
			"path": "backend"
		},
		{
			"name": "Mock Backend",
			"path": "tests/mock-backend"
		},
		{
			"name": "E2E",
			"path": "tests"
		}
	],

This should be fixed in Insiders, original issue: #100929


docs: Write a blogpost on using Move2Kube on your personal project

Description
Move2Kube is a tool used for replatforming applications to kubernetes. It does this by analysing the source artifacts and then generates required target platform artifacts such as Kubernetes yamls, CI/CD pipelines etc. Use Move2Kube on one of your personal projects that needs to be replatformed to Kubernetes. Once the target artifacts are generated, deploy the application and write a blogpost on it.
How to get started
Use the below resources and feel free to use the slack channel to raise concerns if stuck: https://kubernetes.slack.com/archives/CR85S82A2

Install move2kube CLI: https://move2kube.konveyor.io/installation/cli
How to use move2kube CLI: https://move2kube.konveyor.io/tutorials/cli
Other tutorials: https://move2kube.konveyor.io/tutorials
YouTube videos on move2kube: https://www.youtube.com/playlist?list=PL4aUFFbk56EMwb9xoYs-3RjgkD38C6nPO

please assign this to me

Hi @sumedhav2004 feel free to reach out if you are stuck anywhere. You can use this issue thread or the slack channel here:  https://kubernetes.slack.com/archives/CR85S82A2 to ask questions or doubts you have any related to Move2Kube.
Excited to see what you would come up with. Thanks!


Settings

@seanmonstar's proposal contains a builder API for connection that would accept the few settings available defined by HTTP/3, and QPACK:
Connection::builder().max_field_section_size(1024 * 64).handshake(quic_connection)

While this is clearly an ergonomic advantage for the user, I think we should also have a Settings type:

This makes it possible to reuse the same settings for many connections.
Yes ConnecitonBuilder::handshake() could take &self instead of self
But maybe we'd like to be sure we're in possession of a valid Settings (of which parameters need to be bound-checked).
Having a type for that is an opportunity to "encapsulate" bound checks and default values.

The QPACK settings are not to be neglected even if the plan is not to integrate QPACK for now because it blocks streams: Headers are always encoded with QPACK, what changes when disabling it is that there is no dynamic table in the encoding game. This configuration is linked to qpack's SETTINGS_QPACK_MAX_TABLE_CAPACITY: a value of 0 means this is disabled.
The Settings type, available from a builder-pattern thing, can be passed when building a connection, like so:
let settings = Settings::builder()
    .max_field_section_size(1024 * 64)
    .qpack_max_table_capacity(4096)
    .build()?;

Connection::builder().settings(settings).handshake(server1)
Connection::builder().settings(settings).handshake(server2)

I've got a similar type in quinn_h3::Settings, but the ergonomics are not that great.

following the proposal:

A user could create their QUIC implementation’s concept of a Connection, and then pass that to h3. This is a similar design to h2, which asks users to do any transport building before handing it to server::handshake(conn) or client::handshake(conn).

h2::server::Builder::handshake takes &self which is cloned inside and can therefore be used for multiple connections.
Can't this be achieved with a similar api to h2:
let builder = Connection::builder()
    .max_field_section_size(1024 * 64)
    .qpack_max_table_capacity(4096);

let srv1 = builder.handshake(server1)
let srv2 = builder.handshake(server2)

?

Yea, like @jxs mentioned, the builder in h2 basically is the "settings" type, and we could do similar here.

Okay, that's fine to do as it's done in h2.

I think this works already


Exercsises for "Texts" lesson

Random comment.
"Exercises" :D Typo :shipit:

Random comment.
"Exercises" :D Typo :shipit:

Random comment.
"Exercises" :D Typo :shipit:

Haha, thanks! Leave your name and description and we'll add you to the contributors list 🤣

Random comment.
"Exercises" :D Typo :shipit:

Haha, thanks! Leave your name and description and we'll add you to the contributors list 🤣


VPC link present under Create Menu when account has no permission

ISSUE TYPE

Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

N/A
OS / ENVIRONMENT

Ubuntu 22.04
Single-node Management Server
MySQL 5.7
SUMMARY

When setting all permissions for VPC networks to deny, the link to create a VPC is still present under create menu.   I have attached a screenshot.

STEPS TO REPRODUCE
Set all permissions on role for VPC to deny.  This was tested on both Domain Admins and User roles types.  The link to create a VPC is still present under create menu and if you click on the link it brings up a 404-error page since user has no permissions to VPC networks.  The link on the left nav does disappear as expected.

N/A

EXPECTED RESULTS

VPC link not be present in the create dropdown when user has no permission to do anything with VPC networks.

ACTUAL RESULTS

VPC link is present in the create dropdown when user has no permission to do anything with VPC networks.

Fixed with #9104


Talend Open Studio 7.3.1 no longer available for download

Talend has been acquired by Qlik last May 16, 2023 and removed access to the 7.3.1 version of TOS. We have no choice but download version 8.0.1.
I tried installing OpenPIM integration as per documentation just to see. No dice.

Hi @killertilapia,
Sorry, it was a link to outdated documentation on our site. The right document is https://openpim.org/university/import_export
Out components fully support Talend 8.0.1 so you should not have problems with them.
If you want we can organize a call and I can help you to resolve this issue. Please send an email to<EMAIL_ADDRESS>Thanks,
Slava Pedak