Add status to organization membership

Description
Adds status attribute to the organization membership.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.25%. Comparing base (68133ff) to head (1375544).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   97.25%   97.25%
=======================================
  Files          56       56
  Lines        1347     1349    +2
=======================================
+ Hits         1310     1312    +2
  Misses         37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document all scenarios that cause a retry

This describes the retry on timeout, but we also retry when the bot returns certain failure HTTP status codes. Please document those.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6ec6c2e8-0af6-7984-a780-e5bb6ae113ef
Version Independent ID: e0c9ab4e-0d6d-a4c5-f705-b78a0f2a87fb
Content: Bot activity handlers - Teams
Content Source: msteams-platform/bots/bot-basics.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: anclear

@aosolis - Thank you for reporting your issue. Could you please confirm if we should add the following status code to the document?


"Send to" dind't work

I usually using "send to" working normally and loads in few seconds
Now it just *loading animation endlessly

Can you please provide more information about the environment you are using and how you are running the "send to" feature? Specifically, are you using the SD-WebUI, Python, or desktop version?


No entity match error

Hi,
i get an error in protocoll.
[13:16:44] INFO: Starting Alexa Shopping List Sync
[2024-09-03 13:16:59 +0200] [85] [INFO] Running on http://<IP_ADDRESS>:5000 (CTRL + C to quit)
[2024-09-03 13:16:59,279] [ERROR] An error occurred while fetching items: Failed to get items: {'code': 'home_assistant_error', 'message': 'Service call requested response data but did not match any entities'}
Verison is 0.1.4, installed on Intel Nuc, running HASS OS.
There is one item in my Alexa-List, which I created new.

OK, try 0.1.5 and let me know how you get on

Hi, unfortunately I get the same error. BrVon meinem iPhone gesendetAm 03.09.2024 um 17:32 schrieb Oliver Sayers @.***>:
OK, try 0.1.5 and let me know how you get on
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hmm, can you try the request manually for me? Download insomnia and create a new WebSocket request.
The url to replace wss://example.com/chat is your ha_url
Select JSON in the first dropdown and send the auth request:
{
  "type": "auth",
  "access_token": "ey..."
}

Replacing access_token with ha_token then click Send. That should connect you and you'll receive auth_ok back.
Then enter the following JSON to make the request:
{
  "id": 1,
  "type": "call_service",
  "domain": "todo",
  "service": "get_items",
  "return_response": true,
  "service_data": {
    "entity_id": "todo.shopping_list"
  }
}

What is shown under data?
If HA is working correctly then you should receive similar to this:
{
	"id": 1,
	"type": "result",
	"success": true,
	"result": {
		"context": {
			"id": "",
			"parent_id": null,
			"user_id": ""
		},
		"response": {
			"todo.shopping_list": {
				"items": [
					{
						"summary": "Milk",
						"uid": "",
						"status": "needs_action"
					}
				]
			}
		}
	}
}

Also just to check, the shopping list intergration is installed, right? https://www.home-assistant.io/integrations/shopping_list
Do you get the same issue if you manually add something else to the list?

Hi,
i think there ist he problem. I tried to connect and only get the response „401: Unauthorized“
I think we can close this point, it has something todo with my configuration.
Many thanks for your help!
Br,
Sascha
Von: Oliver Sayers @.>
Gesendet: Dienstag, 3. September 2024 20:34
An: SavageCore/HA_Addons @.>
Cc: RocketKuhr @.>; Author @.>
Betreff: Re: [SavageCore/HA_Addons] No entity match error (Issue #12)
Hmm, can you try the request manually for me? Download insomnia https://insomnia.rest/  and create a new WebSocket request.
The url to replace wss://example.com/chat is your ha_url
Select JSON in the first dropdown and send the auth request:
{
"type": "auth",
"access_token": "ey..."
}
Replacing access_token with ha_token then click Send. That should connect you and you'll receive auth_ok back.
Then enter the following JSON to make the request:
{
"id": 1,
"type": "call_service",
"domain": "todo",
"service": "get_items",
"return_response": true,
"service_data": {
"entity_id": "todo.shopping_list"
}
}
What is shown under data?
If HA is working correctly then you should receive similar to this:
{
"id": 1,
"type": "result",
"success": true,
"result": {
"context": {
"id": "",
"parent_id": null,
"user_id": ""
},
"response": {
"todo.shopping_list": {
"items": [
{
"summary": "Milk",
"uid": "",
"status": "needs_action"
}
]
}
}
}
}
Also just to check, the shopping list intergration is installed, right? https://www.home-assistant.io/integrations/shopping_list
Do you get the same issue if you manually add something else to the list?
—
Reply to this email directly, view it on GitHub https://github.com/SavageCore/HA_Addons/issues/12#issuecomment-2327169996 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5YYRESTYBSZYB7R7Z7KDUDZUX6JBAVCNFSM6AAAAABNR5JHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGE3DSOJZGY .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/A5YYREQSNC3XXUP2YVU4SWLZUX6JBA5CNFSM6AAAAABNR5JHWWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUKWXF4Y.gif Message ID: @.*** @.***> >

Hi again,
get it now…had to change the entity_id to „todo.einkaufsliste“ (german 😉 )
this is the response:
{
"id": 1,
"type": "result",
"success": true,
"result": {
"context": {
"id": "01J6Y5YYA0JP0CGH0NX38KQFC4",
"parent_id": null,
"user_id": "98aa881e02724d80ad623249ee4a863e"
},
"response": {
"todo.einkaufsliste": {
"items": [
{
"summary": "test",
"uid": "95a279323f8c49ec9a69966c09094522",
"status": "needs_action"
},
{
"summary": "bla",
"uid": "f4e87f90d3fe4a23b77a7850b6ab010e",
"status": "needs_action"
}
]
}
}
}
}

Thanks for doing that. Yup, the issue is the entity_id.
2 ways around this. First is to just change your entity_id:
Go to Settings  => Devices & Services => Entities then search for todo and change Shopping list / Einkaufsliste Entity ID* to todo.shopping_list
That should work. However, I've also reworked the code to change this based on selected language. I'd appreciate if you can test it! My entity_id wasn't updating when changing language, so I believe that gets set on first install or something.
To try it out, you can stop the add-on from my repo. Then install it locally. To do that:

Enable and setup the Samba share add-on or otherwise get to your addons directory
Download the code and extract it into addons/alexa_shopping_list_sync so you have addons/alexa_shopping_list_sync/Dockerfile etc.
Go to the HA add-on store and check for updates (top right 3 dot menu)
Install Alexa Shopping List Sync from under Local add-ons
Configure and start as usual

This works!
I´ve tried it with the locally from my samba share. First I got an error "requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url:..."  But saw then, that i generated the HA_Token for a user which is only allowd to login locally. After i changed that, it works.
Now I got all new items from alexa-shopping list in my HA-shopping list. Nice work man!!

Thanks for confirming, I will push an update later, once that happens you can then uninstall the local version and continue with the one from the repo.
Ideally I'll get a full list of translations for this...


Does setupmeta take care of entry points when packaging sdist or bdist_wheel?

Hi zsimic, I have another general question. Does setupmeta take care of entry points when building binaries with applications that include an init or main py file? Are there any special actions that I need to take when packaging files with setupmeta installed?

Do entrypoints look good when running python setup.py explain ?

All setupmeta does is provide a convenience way of specifying your entry points: namely looks for a file called entry_points.ini, and exposes it as entry_points= named argument to the setuptools.setup() call.
This is a very mild added-value: all it does is save you from having to write this:
setup(
    ...
    entry_points=...
    ...
)

Instead, you create a file entry_points.ini (which gets nicely syntax-colored by IDEs typically), with something like this in it:
[console_scripts]
my-program = my_package.my_module:my_main

That's all it does regarding entry points.

a file called entry_points.ini

Just my 2 cents: I've decided to not use a separate file just for this, since it is something that rarely gets changed/read, and I found that using an extra file (that is visible when listing a directory) is not worth it.
But I can see that it is useful/clearer, and it is nice that setupmeta is flexible enough here for both use cases.


Support Apple Silicon and add Live View

Adds support for Apple Silicon and Intel
Adds a Live View page to see what CB is doing being the scenes
Minor bug fixes and improvements
Moves to port :3000 and :3001 to fix Apple AirPlay conflict

Closes #9
Closes #8
Closes #6
Closes #7

Aw hell yeah! Thanks so much!


immediate submit only submitting first job in workflow before shutdown

Snakemake version
Snakemake v5.8.1
Describe the bug
In Snakemake v5.7.4 I could use the --immediate-submit argument to submit all the jobs in a workflow to a cluster in one go without waiting for input files. In v5.8.1, only the first job in the workflow is submitted when using immediate submit, after which Snakemake shuts down without an error message.
In scheduler.py v5.7.4 (Lines 404 - 417)
        """ Do stuff after job is finished. """
        with self._lock:
            if handle_job_success:
                # by calling this behind the lock, we avoid race conditions
                try:
                    self.get_executor(job).handle_job_success(job)
                except (RuleException, WorkflowError) as e:
                    # if an error occurs while processing job output,
                    # we do the same as in case of errors during execution
                    print_exception(e, self.workflow.linemaps)
                    self._handle_error(job)
                    return

            self.dag.finish(job, update_dynamic=update_dynamic)

In scheduler.py v5.8.1 (Lines 403 - 415)
        """ Do stuff after job is finished. """
        with self._lock:
            if handle_job_success:
                # by calling this behind the lock, we avoid race conditions
                try:
                    self.get_executor(job).handle_job_success(job)
                    self.dag.finish(job, update_dynamic=update_dynamic)
                except (RuleException, WorkflowError) as e:
                    # if an error occurs while processing job output,
                    # we do the same as in case of errors during execution
                    print_exception(e, self.workflow.linemaps)
                    self._handle_error(job)
                    return

The line self.dag.finish(job, update_dynamic=update_dynamic) has been moved into the if handle_job_success: statement. handle_job_success is false when using --immediate-submit, therefore dag.finish() does not get called, the ready jobs aren't updated, the scheduler thinks all the jobs are completed, and Snakemake shuts down.
Minimal example
Snakefile:
rule test_3:
	input:
		"test_2.py"

	output:
		"test_3.py"

	shell:
		"touch {input} && touch {output}"

rule test_1:
	output:
		"test_1.py"

	shell:
		"touch {output}"

rule test_2:
	input:
		"test_1.py"

	output:
		"test_2.py"

	shell:
		"touch {input} && touch {output}"

Submit command:
snakemake --cluster 'qsub' --jobs 100 --notemp --immediate-submit
It would be expected that all three jobs be submitted to the cluster without waiting for input files. Instead, only the first job in this workflow, test_1, is submitted, and then Snakemake shuts down.

Thanks for reporting and digging into it. Once PR #129 is merged, may I ask you to try again and close this issue if the fix works?


Benchmark 0.10.x

Special for memory usage of qos1/2 messages.

packets dropped

 netstat -s -p | grep buffer
    20775 packets pruned from receive queue because of socket buffer overrun
    249281 packets collapsed in receive queue due to low socket buffer
 so without logs i got up to 350K+ solid connections
 also i am getting these at times

eaddrnotavail

client 34962 EXIT: {shutdown,eaddrnotavail}
client 34959 EXIT: {shutdown,eaddrnotavail}

server kernel

fs.file-max = 1000000
net.core.somaxconn = 65536
net.ipv4.ip_local_port_range = 500 65535
net.nf_conntrack_max = 1000000
net.netfilter.nf_conntrack_max = 1000000
net.ipv4.tcp_rmem = 4096 4096 16777216
net.ipv4.tcp_wmem = 4096 4096 16777216

client kernel

sysctl -w net.ipv4.ip_local_port_range="500   65535"
echo 1000000 > /proc/sys/fs/nr_open

done in 0.12.0


[SPARK-42379][SS] Use FileSystem.exists in FileSystemBasedCheckpointFileManager.exists

What changes were proposed in this pull request?
This PR proposes to use FileSystem.exists in FileSystemBasedCheckpointFileManager.exists, which is consistent with other methods in FileSystemBasedCheckpointFileManager.
Why are the changes needed?
Other methods in FileSystemBasedCheckpointFileManager already uses FileSystem.exists for all cases checking existence of the path.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

cc. @cloud-fan @viirya

Done.

I'd argue that the test case itself is incorrect. It's heavily bound to the internal implementation - it relies on custom filesystem instance which returns true for all exists() calls, but it does not apply to the getFileStatus() hence it will end up with "file does not exist".
That said, test only passes if filesystem behaves incorrectly. If we change the custom filesystem instance to also provide dummy status for all getFileStatus() calls, the test case will fail.
I don't know how we can test the exception in E2E query. As the exception class denotes, it mainly occurs from concurrent writes for same offset/commit log file. We should have created offset log file concurrently, between "determining start microbatch" and "writing offset log after planning", which is super hard from outside of the query.
I'd suggest just remove the test. WDYT?

I am fine w/ removing it.

+1 to remove it.

Test removed. Will merge once the build passes.

Sounds reasonable to remove it.

Thanks, merging to master.


Tracking open issue #33

https://github.com/lannonbr/issue-label-manager-action/issues/33

@ArcadeMode it seems the repo is dead.
https://github.com/DesarrolloORT/issue-label-manager-action seems to have a node v20 release at august 13. can you re-link this repo to that one


Minor Fix for Logical and Physical Expr Conversions

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Merged upstream.


OpenShift CRC is being unstable at regular intervals in our local machine.

OpenShift CRC is being unstable at regular intervals in our local machine. It says while doing oc login: "connection refused".
We have a machine with the following configuration:

CPU- 6 cores
RAM- 16GB
Storage- 100GB

Please provide any vital suggestions for this problem.

@saaj562 please use the issue template https://github.com/code-ready/crc/issues/new/choose (bug report) to create the issue which provide use more information around the host and also what fails for CRC.
Closing this since it have lack of info.


Installer broken by Dell Advanced Threat Prevention

Prerequisites
Not applicable. This is a notification only.
Description
If your organisation has chosen Dell Advanced Threat Prevention (ATP) as its security suite, the install of Atom will fail.
Pro tip: In our site, at least, Dell ATP does not show notifications. I highly recommend setting this on. This is a setting a user can change from the Dell ATP tray application link.
Dell ATP will also prevent you from running Atom as a portable application.
Yes, other AV vendors' product will cause similar problems but they are not identical and I wasted a lot of time troubleshooting this.
Steps to Reproduce

Run AtomSetup-x64.exe
Install fails

Expected behavior: Atom to install.
Actual behavior: Atom fails to install. Unfortunately the SquirrelSetup.log I had is no longer available but the last exception will contain: System.ComponentModel.Win32Exception. Yeah, I know that is not terribly helpful.
Reproduces how often: 100%
Versions
This was found with Atom 1.25 and 1.26.
Additional Information
In the Dell ATP Events or Threats tab, you will mentions of Atom and Squirrel objects being quarantined.

As I noted above, this is a notification only. Closing issue.


further update within spyder

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
what else do I put here: Preparing transaction: done
Verifying transaction: done
Executing transaction: done
(base) PS C:\Users\rmiller>
What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

Closing because it's not clear what this problem is about and it seems you already understood what to do.


Update s3_allow_ssl_only.py

@omershliva it should be approved and merged (a small change in the bot's documentation)


fails to compile

Describe the bug
== Compilation error in file lib/live_admin/view.ex ==
** (CompileError) lib/live_admin/view.ex:4: module Phoenix.View is not loaded and could not be found
(elixir 1.14.4) expanding macro: Kernel.use/2
lib/live_admin/view.ex:4: LiveAdmin.View (module)
Brand new app generated by mix phx.new and gen.auth
phoenix 1.7.5, liveview 0.19.2

Which version of LiveAdmin are you using?

0.7.3 also fails with liveview 0.19
so for now, last possible liveview is 0.18.3

It didn't look like there should be any breaking changes in 0.19 so I have bumped the version in main. After I've had a chance to do a bit more testing I will backport that upgrade to 0.7.x and 0.8.x. In the meantime you can try locking to 3adc9a6c09483838244f483a9ca3f0b9e421e8e2 but there are various changes still in dev there so I can't guarantee it's stable.

Resolved in https://github.com/tfwright/live_admin/commit/3adc9a6c09483838244f483a9ca3f0b9e421e8e2


ivar outputs in vcf

hi,
reading from https://nf-co.re/viralrecon/1.0.0/output#ivar-variants-and-ivar-consensus
it seems you suggests ivar can output in vcf format top of tsv:
variants/ivar/
.tsv: Low frequency variants in TSV format.
.vcf.gz: Low frequency variants VCF file.
.vcf.gz.tbi: Low frequency variants VCF index file.
I cannot read anywhere how to run ivar to call variants outputs in vcf. any suggestions?
thanks!
ibseq

Hi @ibseq iVar doesn't currently output variants in VCF format. We wrote a custom script for this pipeline that does the conversion from tsv -> vcf. The latest version of the script is here
We have also shared this with the author of iVar just in case it comes in handy for them to add a native implementation :)
https://github.com/andersen-lab/ivar/issues/17
Hope that helps!

Thanks!

On 27 Apr 2021, at 16:03, Harshil Patel @.***> wrote:
Hi @ibseq https://github.com/ibseq iVar doesn't currently output variants in VCF format. We wrote a custom script for this pipeline that does the conversion from tsv -> vcf. The latest version of the script is here https://github.com/nf-core/viralrecon/blob/dev/bin/ivar_variants_to_vcf.py
We have also shared this with the author of iVar just in case it comes in handy for them to add a native implementation :)
andersen-lab/ivar#17 https://github.com/andersen-lab/ivar/issues/17
Hope that helps!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nf-core/viralrecon/issues/177#issuecomment-827677783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH76DQ3346O3ESYFEQ6NEP3TK3G5VANCNFSM43VEVC5A.


Zoom level must be between 0-20

Hey,
I am using ngx-leaflet among side with mapbox.
Once calling to mapbox with styles : https://{s}.api.mapbox.com/styles/v1 ...
the response is "Zoom level must be between 0-20" (with zoom level 24).
Any idea how can I solve it?
Thanks

This is a warning from MapBox. You should set a max zoom level of 20 in ngx-leaflet in the map options. See the Leaflet and ngx-leaflet docs for more details.
If you have any more questions, you should post your questions to Stack Overflow using the 'leaflet' and 'ngx-leaflet' tags.

Closing as the provided guidance on using the map options will solve the problem.


Improving mapping.nest error message

If you pass mapping.nest something that is a list rather than a tuple, you get a completely unrelated error message:
  File "/usr/local/google/home/goodfellow/pylearn2/pylearn2/utils/data_specs.py", line 273, in nest
    assert self.n_unique_specs == 1
AssertionError

I don't really understand this portion of the codebase so @lamblin should probably comment on this.

It would make sense to convert lists as tuples.
In general, what we want to detect is if "flat" is actually a single element that we want at different places in the nested tuple, and raise an exception if the mapping actually refers to more than one specs.


unicode text support

Right now unicode text seems to be displayed as rectangles.

See #33, #208, and #213.


Is not a but request

Can you make dxd 11 for Mali GPU please 🥺 I really like to sone good game but dxd 11 🙏

Using dxvk on any device is just about having proper Vulkan drivers (1.3 for dxvk 2.0+) and software to run the games (e.g Wine on Linux).
dxvk only officially supports Linux and the drivers mentioned here https://github.com/doitsujin/dxvk/wiki/Driver-support

Mali GPUs are missing various hardware features that are required to run D3D11 games.


Naming convention: volume/surface integral → terms

I started to think about implementing FD methods today. I will use the DG struct for that, since block SBP FD methods are just DG methods with another basis (and another structure of the derivative operator, changing the way to efficient implementations completely). Since FD methods are usually implemented in strong form, the term integral for volume/surface contributions doesn't really make sense anymore, I think. Something like volume/surface terms seems to be more appropriate and general, I think.
We should discuss this. If we agree to make the change, we should add appropriate deprecations, mention them in the NEWS.md, and remove the deprecated stuff in Trixi v0.4.

Could you give a few examples regarding what would change and how?

VolumeIntegralWeakForm → VolumeTermsWeakForm etc. These are exported/documented and need to be deprecated.
calc_volume_integral! → calc_volume_terms! or just volume_terms! etc. These are not exported/documented, so we don't need to deprecate them.

In principle, DG is based on integrals and hence one could argue calling it VolumeIntegral or SurfaceIntegral makes sense.
SBP FD could/should have different names, I agree.
Is it necessary, that DG and SBP have the same names? We could have different names for different solvers if you ask me.
Why do you want to unify the naming?

I am strongly against using different names for the same abstraction depending on the context. That totally defeats multiple dispatch and code reuse.
As an extreme example, your proposal would mean to write dgemm for matrix multiplication of real elements, zgemm for complex matrices etc. I prefer to write * (or the in-place version mul!) for all of them.

Additionally, I don't think DGSEM people will be confused by VolumeTerms or SurfaceTerms. In contrast, FD people will have no clue what kind of integral you're talking about. Why shouldn't we pick the more general name that's easier to understand for a broader audience?
In addition, we don't see the integrals anymore in the implementations of DGSEM...

(I'm using some rather extreme wording here to play the devil's advocate. I knew that we will have such discussions and we definitely need them to find a good solution for all of us and Trixi. That's why I chose the tag discussion for this issue.)

Why shouldn't we pick the more general name that's easier to understand for a broader audience?

For similar reasons why we have separate implementations for 1D/2D/3D: If you are omniscient and/or have multiple years of high-order numerical analysis experience under your belt, all naming conventions are more or less OK for you. However, especially for new users it can be easier to only see a particular name/implementation that is specific to the community you're coming from. For instance, volume integral and surface integral are terms that are immediately recognizable for anyone growing up on David Kopriva's blue book. "Volume terms" and "surface terms" might also refer to other details, or just part of the integrals etc.
I am not saying that we shouldn't do it, I am just saying what's "easier to understand" can usually not be determined in an absolute sense, but depends heavily on the perspective...

For instance, volume integral and surface integral are terms that are immediately recognizable for anyone growing up on David Kopriva's blue book.

Well, I didn't grow up that way. I'm more an autodidact and never had any formal lecture about DG methods or numerical methods for hyperbolic PDEs. Personally, I see DGSEM as "just" a special case of SBP methods.
But you're right, there are reasons to keep the current name. On the other hand, there are also reasons to change it. What I would really like to avoid is having the same abstraction multiple times but doing the same thing.

If it is the consensus to rename it to volume_terms/surface_terms, I can live with it as well. It would be great to have a comment somewhere - maybe in the respective docstrings of the DGSEM and FDSBP types - explaining what the terms volume_terms/surface_terms means in this context? I know I tend to ask for a lot of commentary, but I feel like this makes it much easier for new users to understand the code, especially if they are still learning the underlying methods as well (= students).
In any case, I would propose to do this in a different PR than #617 to make it not a bigger PR than necessary.


TypeError: Cannot read property 'isClosed' of undefined during svg deserialization

Expected Behavior
The SVG below is successfully deserialized
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="5.791015625" height="11.71875"><path d="M1.84-3.17L0.53-3.48L0.97-7.11L5.12-7.11L5.12-5.83L2.30-5.83L2.14-4.42Q2.32-4.52 2.60-4.60Q2.89-4.68 3.16-4.68L3.16-4.68Q4.22-4.68 4.79-4.05Q5.36-3.42 5.36-2.29L5.36-2.29Q5.36-1.61 5.06-1.05Q4.75-0.50 4.20-0.20Q3.65 0.10 2.90 0.10L2.90 0.10Q2.23 0.10 1.64-0.18Q1.05-0.45 0.72-0.94Q0.39-1.42 0.40-2.02L0.40-2.02L2.05-2.02Q2.07-1.63 2.29-1.40Q2.52-1.17 2.89-1.17L2.89-1.17Q3.72-1.17 3.72-2.40L3.72-2.40Q3.72-3.54 2.70-3.54L2.70-3.54Q2.12-3.54 1.84-3.17L1.84-3.17Z"/></svg>

Actual Behavior
Deserializer throws Cannot read property 'isClosed' of undefined
Steps to Reproduce the Problem
run
import { deserializers } from "@jscad/io";

const svg =
  '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="5.791015625" height="11.71875"><path d="M1.84-3.17L0.53-3.48L0.97-7.11L5.12-7.11L5.12-5.83L2.30-5.83L2.14-4.42Q2.32-4.52 2.60-4.60Q2.89-4.68 3.16-4.68L3.16-4.68Q4.22-4.68 4.79-4.05Q5.36-3.42 5.36-2.29L5.36-2.29Q5.36-1.61 5.06-1.05Q4.75-0.50 4.20-0.20Q3.65 0.10 2.90 0.10L2.90 0.10Q2.23 0.10 1.64-0.18Q1.05-0.45 0.72-0.94Q0.39-1.42 0.40-2.02L0.40-2.02L2.05-2.02Q2.07-1.63 2.29-1.40Q2.52-1.17 2.89-1.17L2.89-1.17Q3.72-1.17 3.72-2.40L3.72-2.40Q3.72-3.54 2.70-3.54L2.70-3.54Q2.12-3.54 1.84-3.17L1.84-3.17Z"/></svg>';
const shapes = deserializers.svg({ output: "geometry" }, svg);

Specifications

Version: "@jscad/modeling": "^2.5.0",
Platform: mac/chrome
Environment: browser

The above is from running in my own app. Running this at https://www.openjscad.xyz/ it throws a different error:
cannot append points to a closed path
const { deserializers } = require("@jscad/io");

const main = () => {
  const svg = '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="5.791015625" height="11.71875"><path d="M1.84-3.17L0.53-3.48L0.97-7.11L5.12-7.11L5.12-5.83L2.30-5.83L2.14-4.42Q2.32-4.52 2.60-4.60Q2.89-4.68 3.16-4.68L3.16-4.68Q4.22-4.68 4.79-4.05Q5.36-3.42 5.36-2.29L5.36-2.29Q5.36-1.61 5.06-1.05Q4.75-0.50 4.20-0.20Q3.65 0.10 2.90 0.10L2.90 0.10Q2.23 0.10 1.64-0.18Q1.05-0.45 0.72-0.94Q0.39-1.42 0.40-2.02L0.40-2.02L2.05-2.02Q2.07-1.63 2.29-1.40Q2.52-1.17 2.89-1.17L2.89-1.17Q3.72-1.17 3.72-2.40L3.72-2.40Q3.72-3.54 2.70-3.54L2.70-3.54Q2.12-3.54 1.84-3.17L1.84-3.17Z"/></svg>';
  return deserializers.svg({ output: "geometry" }, svg);
}

module.exports = { main }

@brucedjones if you are ok with starting local jscad from source can you check if this fix #886 works for you.

i can take a look at this tonight, thanks for looking in to it!

Tested locally and that appears to work, thanks!

Looks like the same bug existed in appendBezier and appendArc
https://github.com/jscad/OpenJSCAD.org/blob/2e52f104e569f2bb7dd9e1be3d238f471f4d3dfa/packages/modeling/src/geometries/path2/appendBezier.js#L40
https://github.com/jscad/OpenJSCAD.org/blob/2e52f104e569f2bb7dd9e1be3d238f471f4d3dfa/packages/modeling/src/geometries/path2/appendArc.js#L50

@brucedjones my first attempt did remove the error. But it was not the right way to fix. New version of the fix will still complain but will tell you what part of svg is broken.
as mentioned in #886 :
The problem is that the test sample svg is malformed and now error is thrown
Malformed svg path at 2:445. Path closed itself with command #29: Q2.12 -3.54 1.84 -3.17
The problem is that the mentioned command adds last point that is the same as first point in the path, so the appendPoints closes it. So I have added a check for such case and throw an error with the location of the problematic svg.

Interesting. If this is detecting that the path closed itself, wouldn't it be better to be robust to this and handle it accordingly rather than throwing an error? At the very least an option to ignore this would be nice.

wouldn't it be better to be robust to this and handle it accordingly rather than throwing an error?

well, what would be "accordingly" ?  different users would have different expectations 😐

At the very least an option to ignore this would be nice.

that would be nice, but also what would it mean ?
What to do with a line that is added to a closed path:

return as an additional path ?
ignore it ?
...

So in this case you specifically noted that the polygon is self closing ie the last point is coincident with the first. The code could be robust to this specific case. The outstanding edge case is, as you noted, what happens if there are points after the point that is coincident with the first point. You could

throw an error
ignore it
add an additional path.

IMO returning an additional path is what I would expect. That option is robust and the most faithful representation of the STL possible.

So in this case you specifically noted that the polygon is self closing ie the last point is coincident with the first. The code could be robust to this specific case.

that case is ok :) it does not throw an error.
I would go in this direction

pathSelfClosed: 'error' - default throw an error
pathSelfClosed: 'trim' - ignore it
pathSelfClosed: 'split' - add an additional path.

default would make it less likely to break extrude if it passes

Sounds good!

@brucedjones the latest version of openjscad.xyz has the modified SVG deserializer (import function), but the default is 'error' at this time. hopefully, the error message will be meaningful.
please try it out, and let us know if anything should be adjusted.

Nice thanks!


Continue refactoring

What this PR resolves:

Improve logging of AYS
give duration of a Job
add some error handling

No we dont do that. This is an overkill.

We cannot run a new build each commit, that will make everything slower. Changes will be be tested before they are merged to master once you create a PR.

I will revert that change. If you want to test a specific change without creating a PR then you should test it locally. You can check who to run the tests using the testrunner docs from here: https://github.com/Jumpscale/ays9/tree/master/ays_testrunner

I will revert that change. If you want to test a specific change without creating a PR then you should test it locally. You can check who to run the tests using the testrunner docs from here: https://github.com/Jumpscale/ays9/tree/master/ays_testrunner

This is not working, we tried with Reem to execute the test locally, impossible.

Then we need to make sure that everyone can run the tests locally. I will take care of that.


fix: replacing avo file with main branch

I ran
avo pull --branch main "Oak Web Application"
to  bring Avo up to date with its main branch

:tada: This PR is included in version 1.388.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Intellisense Completion doesn't respect space after equal sign (.html file)

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

path-intellisense
christian-kohler
1.4.2

prettier-vscode
esbenp
0.19.1

beautify
HookyQR
1.1.1

ftp-simple
humy2833
0.5.0

Theme-MaterialKit
ms-vscode
0.1.4

material-icon-theme
PKief
2.0.9

remote-vscode
rafaelmaiolla
1.0.1

JavaScriptSnippets
xabikos
1.4.0

Material-theme
zhuangtongfa
2.8.9

html-css-class-completion
Zignd
1.7.0

Steps to Reproduce:

In a .html file, within a script tag
Declare a variable, say const abc = 5;
On another line, type const def =. Intellisense will pop up. Press the space key to place a space after the equal sign.
Start typing ab to filter the list to the abc variable from the previous line. Press Enter or Tab to select that item.
The space after the equal sign disappeared, and it now reads const def =abc. Ideally even if you didn't put a space after the equal, it should for you, but that's a stylistic issue.

Notes: I tried the same thing in a (.js) file and it did not happen.

Update: same thing if typing - (minus sign) then using intellisense. It doesn't do it with a + (plus sign) or some other operators though. With the plus sign, intellisense pops up not after I type + or space, but after I type the first letter of the next word. But the equal sign and minus sign pop up intellisense immediately. Maybe this is only an issue with operators that immediately launch intellisense (as opposed to typing another word or value).

@jrieken This looks like a bug in code assist:
<script>
const abc = 5;
const def =

code assist after = brings up a list of proposals
entering a space does not filter any proposals, all seem to be still valid, no new request is made against to Language server
applying the proposal will insert it without space.

I checked that this issue is also present in 1.13.1.

Hm, that came in when fixing https://github.com/Microsoft/vscode/issues/26096 which was about ignore whitespace in some cases...

Also a little unhappy because when having requested intellisense explicit via Ctrl+Space we don't hide the box when nothing matches anymore. So, even after fixing the filtering you will see the exact same behaviour. This issue is actually half as-designed and half a bug. Not sure what to do

I have pushed changes to cancel intellisense when non-word characters are being typed when otherwise go to the frozen state. That fixes this issue, the IntelliSense window closes after typing space.


Force Query Plans

We want users to be able to force join orders, see e.g.:
https://mariadb.com/kb/en/index-hints-how-to-force-query-plans/

I think something like STRAIGHT_JOIN as mentioned in the linked page is best.


New language request: Toki Pona

General information

App version: 0.15.1
System: Stock Android

Description
pona!
I'm a fluid speaker of Toki Pona and would love to translate some of your projects into that wonderful language. Unfortunately, the language list doesn't include Toki Pona yet.
I'd be grateful!
~ Julie

Thanks! Sadly said language is list is generated based on the locales from your device, so if Android doesn't have it it's probably not supported?

Aw, that's unfortunate. Is there no way for custom languages?

It's possible to special-case and to maintain an extra separated list, but if it's not even supported by Android… how would you select the language in the first place? Well we have a custom settings for that but not all applications do.

Hm... I just wanted to translate Markor. :\
Well, if it's impossible or not worth the effort, that's okay though mildly disappointing.
Thanks for the quick response. c:


Add consent

Issue Reference
This PR addresses the Issue : Fixes #767
Summarize
Added

Page to confirm/cancel volunteer opt-in
has_consented flag in db

Please add malayalam test in ./templates/mainapp/volunteer_consent_success.html
Screenshots
Register as Volunteer with disclaimer

Consent page

**Consent success

**

@bjacobt could you leave some instructions to test this locally, in the absence of SMS?

@bjacobt need to check the incoming ID/ts to confirm which volunteer to apply this to

Think we need to validate the last 4 digits of timestamp

lgtm

lgtm, no breaking stuff here


Hide Keypad when EditText out of focus

Hey!
To enhance the user experience, the soft keyboard is now being hidden whenever the EditText loses focus. The changes have been made to the following:

acitivity_login
fragment_categorization
fragment_multiple_upload_lists
This PR references the issue #1109

Please review :-)
Thanks!

Codecov Report

Merging #1167 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1167      +/-   ##
=========================================
- Coverage    3.85%   3.83%   -0.03%
=========================================
  Files         125     125
  Lines        5757    5796      +39
  Branches      567     568       +1
=========================================
  Hits          222     222
- Misses       5520    5559      +39
  Partials       15      15

Impacted Files
Coverage Δ

...nrw/commons/upload/MultipleUploadListFragment.java
0% <0%> (ø)
:arrow_up:

...n/java/fr/free/nrw/commons/auth/LoginActivity.java
0% <0%> (ø)
:arrow_up:

...e/nrw/commons/category/CategorizationFragment.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054fa93...bf0067a. Read the comment docs.

I've made the changes and removed the logging statements. Kindly review :)
Thanks

Seems like the CI checks are not passing. Is it because of me pushing 3 commits back to back? @misaochan It would be great if you could guide me with this.
Thanks

Hi @gupta-meghna64 , is there a reason why you closed this? You can always leave PRs open and add as many commits as you want, that shouldn't break anything in and of itself. Generally it is recommended to modify existing PRs, and not start a new one for every change needed. We can review #1168 now since it has already been submitted, but keep in mind for the next time. :)

I'll keep in mind @misaochan from the next time


build(deps): update detox to 19.10.0

Description
Update to Detox 19.10.0
Other changes
Don't display out of Sync Banner during e2e tests.
Tested
Tested in CI.
How others should test

Reviewers: check E2E actions on this branch - First one was prior to removing out of sync banner.
QA: N/A

Related issues
N/A
Backwards compatibility
Yes

Hey @MuckT  since NA is mentioned in how others should test ,we are skipping this PR
Thanks.!


OpenCV 4 with extensions fails to link under Linux

Environment
Operating System: Linux (Pengwin Linux running under WSL 2)
OpenCV Installation: vcpkg under Linux
OpenCV Version: 4.3.0
rustc version: rustc 1.47.0 (18bf6b4f0 2020-10-07) (latest stable)
Problem
The application builds and runs successfuly with the following base install of OpenCV, installed using vcpkg under Linux:
vcpkg install "opencv4[core,contrib,nonfree]"

With the same configuration, the OpenCV install with the following extensions fails to link properly, citing undefined references. This occurs with a clean build of the application as well as with a clean installation of OpenCV.
vcpkg install "opencv4[core,contrib,nonfree,dnn,ffmpeg,jpeg,opengl,openmp,png,webp]"

Sample Project

cargo.toml
[package]
name = "hex-vision"
version = "0.1.0"
authors = ["Zalán Bálint Lévai<EMAIL_ADDRESS>edition = "2018"

[dependencies]
opencv = { version = "0.46.1", features = ["opencv-4", "contrib", "buildtime-bindgen"] }

src/main.rs
#[allow(clippy::all)]

use opencv::prelude::*;
use opencv::videoio::{
    VideoCapture,
    // CAP_FFMPEG,
    // CAP_GSTREAMER,
    CAP_ANY,
};
use opencv::highgui::{
    imshow,
    named_window,
    wait_key,
    // WindowFlags,
    WINDOW_AUTOSIZE,
};

#[derive(Debug)]
enum ControlError {
    InternalError { error: opencv::Error },
    VideoStreamNotOpenError,
    VideoStreamEmptyError,
}

impl From<opencv::Error> for ControlError {
    fn from(error: opencv::Error) -> Self {
        ControlError::InternalError { error }
    }
}

fn run_control() -> Result<(), ControlError> {
    let mut video = VideoCapture::from_file("footage.mp4", CAP_ANY)?;

    if !video.is_opened()? {
        return Err(ControlError::VideoStreamNotOpenError);
    }

    let window = "Camera 0";
    named_window(window, WINDOW_AUTOSIZE)?;

    loop {
        let mut frame = Mat::default()?;
        video.read(&mut frame)?;

        if frame.empty()? {
            return Err(ControlError::VideoStreamEmptyError);
        }

        imshow(window, &frame)?;

        let ch = wait_key(1)?;
        if ch == 27 {
            break;
        }
    }

    Ok(())
}

fn main() {
    run_control().unwrap()
}

Build Log
Build Log (RUST_BACKTRACE=full cargo build -vv output)

When doing static linking on Linux the link argument order becomes critical and vcpkg discovery doesn't seem to get it always right. In your case the cmake discovery (which yields correct argument order) process failed so the crate is falling back to pure vcpkg. So to fix it you have 2 options:

Fix cmake discovery, it's currently failing with: CMake Error at /home/zalanlevai/vcpkg/scripts/buildsystems/vcpkg.cmake:536 (_find_package):\n  Could not find a package configuration file provided by "OpenMP" with any\n  of the following names:\n\n    OpenMPConfig.cmake\n    openmp-config.cmake\n\n  Add the installation prefix of "OpenMP" to CMAKE_PREFIX_PATH or set\n  "OpenMP_DIR" to a directory containing one of the above files.
Use the OPENCV_LINK_LIBS environment variable to fix the link argument order. For the specific error you're getting you need to specify OPENCV_LINK_LIBS="+,opencv_core". But you're most likely receive another bunch of linking errors with different symbols so you'll need to add another library to the list and so on until it compiles. If you go this way and get stuck please do post the new linking errors you're getting I will help you in figuring out which library they belong to.

Have you managed to get it to work?

I'll assume that you managed to workaround the issue and close this issue, if it's not the case please feel free to reopen it.


Use default arguments naming

When I call a NSTimer.after and pass a function, it doesn't have a argument name for second argument. This feels not natural for me regarding that all other functions usually used default or external names.
  NSTimer.after(1.second, close)

Using default names don't change the nice trailing closure syntax
public class func after(interval: NSTimeInterval, block: () -> Void) -> NSTimer
...
NSTimer.after(1.second) {
  print("done")
}

If you agree I can make a PR :)

Thanks, but I think that's unnecessary. It reads quite naturally as the passed methods are going to be named with verbs generally. No need for verbosity.

 What I was thinking hmmm .... :D


detect/bypass/v6: add test for detect-bypass

Adds test for DetectBypassTestSig01
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4911
Previous PR: #685
Corresponding Suricata PR: OISF/suricata#6873

Merged in #695, thanks!


feat(flux2-sync): update git repository resource to v1beta2

What this PR does / why we need it:
Update the apiVersion for the GitRepository resource in the flux2-sync chart to v1beta2. This api version was released in source-controller v0.22.0 as of 17-MAR-2022.
Which issue this PR fixes
Fixes: #89
Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] helm-docs are updated
[x] Helm chart is tested
[x] Update artifacthub.io/changes in Chart.yaml
[x] Run make reviewable

@dwerder -- appears that the README.md for the flux2 chart was not updated when the appVersion was incremented to 0.29.3 in a previous PR somehow -- let me know if you would like me to bump the flux2 chart (even though no other changes were made) to compensate.

@dmccaffery the chart release failed https://github.com/fluxcd-community/helm-charts/runs/6287049398?check_suite_focus=true

Yeah... a previous PR forgot to update the readme for the flux2 chart via helm-docs. When I ran it, it corrected the readme but I didn't bump the flux2 chart version. Apparently the readme is enough to be detected as a change.
I'll put out a PR to bump the flux2 chart version. :-/

Thanks @dmccaffery for sorting this out 🤗


Expired files cleanup

When files are expired, they should be automatically cleaned up and deleted from the file system to save space.
This may not happen immediately but often enough to keep the disk free.
Either a cron job or some other type of scheduled task should take care of this.
If a user tries to download a file that has expired but has not yet been cleaned up it should still 404. This ensures when the clean up does run it is free to delete the file - it shouldnt be being used by another process.
To look into: if a file expires while someone is downloading the file it should probably be kept until they have finished downloading it.

Implementation PR: #33

Closed by #33


VK Embed Post

Will you add VK posts?

@web-xaser Nice idea, I will add support for VK hopefully in evening.

@web-xaser I tried to add support for it, using open_api calls, even tried by authorizing app. Its seems there is a lack of documentation that states how to generate a hash value for post (ref: https://vk.com/dev/widget_post), which is generated as a widget connection.

If you could figure out how to decode it, I will further add it. Currently I can't support this service due to lack of resources.


Is reportbot really working?

Hey Marc3842h,
I have reportbot-ed 5 accounts (11 reports each) successfully with matchid , with no success none of them got banned.
Please advised.
                                                                                Thank you,JerkReject

I'm pretty sure reportbot is working as Zoner still works but yeah i also reportbotted 2x (22 reports) 3 spinbotters and ragers but none got banned even after 48 hours :P

Yes, yesterday i banned 2 fagg0ts, but there is no 100% chance that it will be banned. To OW can get another game or rounds, when he didnt play.

as long as 8 rounds going into overwatch, a guy raging a single game should get banned 100%!
if a guy playing some legit games and maybe gets some reports in it too... chance are good but not best for OW to detect him
(IF he got good kda in the legit games some of this games can go into OW too)
I had same problems a week ago but since 1 week its working good (I god lucky?)
I do allways check if the guy is continuing playing or not (if profile is public)
And if he gets ban I check some rep bot sides for the BANlist to be sure my bot (Titan) worked.
last 5 days 3BANs 90% did by Titan (maybe 1 was playing too many games and got player reports, but i dont think so because everyone of them stopped playing after they game against me)

Right now it looks like for some people its a Hit&Miss. I'd advise to check if any bot accounts received a blue banner saying a reported player was banned. Keep in mind that Griefing bans don't show up on public Steam profiles (and yes, it may happen that some people that are obviously raging only receive a Griefing conviction - It happened to myself).
I myself had much more success with Match ID than without, but also not 100% Hit rate.
*IMPORTANT TO KNOW IS that Titan still has 6h cooldown in its index calculator. This is incorrect and the cooldown is in fact 12h. I'lm change that in the next few commits.

i believe it is because like what marc said ive gone on at least one of the alts and someone i recently reported was banned off of it

As this discussion is kind of dead, I'll close this. People are reporting that this report bot works and you'll need to investigate if it doesn't work for you.


Use a kubernetes go client instead of running external CLIs with os/exec package

In the integration tests we currently use os/exec go package to run ko and kubectl CLIs to interact with Kubernetes.
Kubernetes provides several go clients for kubernetes under the client-go library.
We use different clients for different things in the operator, API server and sink.
See if there is a chance to prevent running a CLI and use the go clients to interact with kubernetes.

Over time we changed the approach organically and we don't use os.exec anymore on the integration tests.


Fix typo

Hi @davcri ! I fixed the error of the itch.io and android release variable.

Thanks @Andrea-Miele for your help!


ResourceHierarchyChecker False Positive

Hello,
I think there's a bug with this checker that leads to false positives. The following sequence triggers a ResourceHierarchyChecker vulnerability:
This request creates customer1:
2020-12-04 11:03:13.322: Sending: 'PUT /Marketplace_vuln_fixed-rest/rest/customers/customer1 HTTP/1.1\r\nAccept: application/json\r\nHost: <IP_ADDRESS>:8080\r\nContent-Length: 0\r\nUser-Agent: restler/7.1.0\r\n\r\n'
2020-12-04 11:03:13.327: Received: 'HTTP/1.1 200 OK\r\nContent-Type: application/json\r\nContent-Length: 69\r\nX-Frame-Options: SAMEORIGIN\r\n\r\n{"customer":"customer1","password":"customer1","rolename":"customer"}'
This requests posts a message of customer1 and returns the messageID of the new message (12):
2020-12-04 11:03:13.329: Sending: 'POST /Marketplace_vuln_fixed-rest/rest/customers/customer1/messages HTTP/1.1\r\nAccept: application/json\r\nHost: <IP_ADDRESS>:8080\r\nContent-Type: application/json\r\nContent-Length: 30\r\nUser-Agent: restler/7.1.0\r\n\r\n{\n    "message":"customer1"}\r\n'
2020-12-04 11:03:13.341: Received: 'HTTP/1.1 200 OK\r\nContent-Type: application/json\r\nContent-Length: 61\r\nX-Frame-Options: SAMEORIGIN\r\n\r\n{"customer":"customer1","message":"customer1","messageID":12}'
This accesses message 12 of customer1, which is legitimate:
2020-12-04 11:03:13.343: Sending: 'GET /Marketplace_vuln_fixed-rest/rest/customers/customer1/messages/12 HTTP/1.1\r\nAccept: application/json\r\nHost: <IP_ADDRESS>:8080\r\nContent-Length: 0\r\nUser-Agent: restler/7.1.0\r\n\r\n'
2020-12-04 11:03:13.351: Received: 'HTTP/1.1 200 OK\r\nContent-Type: application/json\r\nContent-Length: 61\r\nX-Frame-Options: SAMEORIGIN\r\n\r\n{"customer":"customer1","message":"customer1","messageID":12}'
However, this sequence triggers a ResourceHierarchyChecker vulnerability, which is a false positive.
Note that the fuzzer never uses another customer than customer1 in the final GET request (although I've added "customer2" to restler_fuzzable_string in dict.json).
Any help is appreciated, thanks a lot!
Marc

@rennhard Hello, thank you for your feedback. What you describe looks indeed very strange. Specifically, we do not understand why the ResourceHierarchyChecker would ever flag the behavior above since message-ID=12 is a child of customerID=customer1 (the POST request you describe should establish this parent-child relation).
Could you please share with us the network logs and the ResourceHierarchyChecker output/logs so we can investigate?
Thanks much!

Hi Patrice
I don't have the original logs anymore, but did another run, which shows the same behavior (now with messageID=10).
--Marc
network.testing.140491490572032.1.txt
ResourceHierarchyChecker_20x_1.txt

Hi Marc, thanks for the repro info. The checker output is interesting:
-> PUT /Marketplace_vuln_fixed-rest/rest/customers/customer1 HTTP/1.1\r\nAccept: application/json\r\nHost: <IP_ADDRESS>:8080\r\n\r\n
! producer_timing_delay 0
! max_async_wait_time 20
PREVIOUS RESPONSE: 'HTTP/1.1 200 OK\r\nServer: Payara Server  5.201 #badassfish\r\nX-Powered-By: Servlet/4.0 JSP/2.3 (Payara Server  5.201 #badassfish Java/Oracle Corporation/11)\r\nAccess-Control-Allow-Origin: *\r\nAccess-Control-Allow-Methods: OPTIONS, GET, POST, PUT, DELETE\r\nAccess-Control-Allow-Headers: *\r\nContent-Type: application/json\r\nContent-Length: 69\r\nX-Frame-Options: SAMEORIGIN\r\n\r\n{"customer":"customer1","password":"customer1","rolename":"customer"}'

-> GET /Marketplace_vuln_fixed-rest/rest/customers/customer1/messages/10 HTTP/1.1\r\nAccept: application/json\r\nHost: <IP_ADDRESS>:8080\r\n\r\n
! producer_timing_delay 0
! max_async_wait_time 20
PREVIOUS RESPONSE: 'HTTP/1.1 200 OK\r\nServer: Payara Server  5.201 #badassfish\r\nX-Powered-By: Servlet/4.0 JSP/2.3 (Payara Server  5.201 #badassfish Java/Oracle Corporation/11)\r\nAccess-Control-Allow-Origin: *\r\nAccess-Control-Allow-Methods: OPTIONS, GET, POST, PUT, DELETE\r\nAccess-Control-Allow-Headers: *\r\nContent-Type: application/json\r\nContent-Length: 61\r\nX-Frame-Options: SAMEORIGIN\r\n\r\n{"customer":"customer1","message":"customer1","messageID":10}'

The checker complains that the second GET request referring to resource messageID:10 is successful after executing only the first PUT request -- that is, without executing the POST request creating the resource messageID:10.
Note that, in general, this is a real security bug and not a false alarm: if an attacker can guess a customerID and a message ID, it could access (GET) this message of that customer without being allowed to create (POST) messages for that customer.
So the checker is doing its job in this case, even though this can be a false alarm in your particular context.
This alarm is probably triggered because the resource "customer1" is hard-coded and not cleaned up between fuzzing iterations/tests.
If your service allows arbitrary strings as customer names (that is, not just customer1 and customer2), you can avoid these alarms by using randomly generated customer names. To do this, you need to add something like this in your fuzzing dictionary file:
"restler_custom_payload_uuid4_suffix": {
    "customerID": "customer-",

so that your grammar will be changed so that
['customer1', 'customer2']
is replaced by
+ restler_custom_payload_uuid4_suffix: customerID
By using randomly generated customer names, this alarm will disappear.
Best,
Patrice
PS: @rifiles please have a look to confirm when you get a chance - thanks!

@PatGod That description sounds perfect to me.
To add, for this example the customer1 / customer2 line will need to be updated to restler_custom_payload_uuid4_suffix('customerID') in the grammar (it's currently restler_fuzzable_string).

Yes, this makes sense. I did another run with randomly generated customer IDs and the issue is not reported.
Thanks a lot, I'm closing the issue.


Adding aliases when creating index.

This addreses issue #289
It does not introduce breaking change.
Added field in template_v7.json for unit tests.
Tested on ElasticSearch 7.x locally.
Adding aliases when creating index.
Changes in Serilog.Sinks.Elasticsearch

I think I added comments to this one: https://github.com/serilog/serilog-sinks-elasticsearch/pull/290 but you closed that one in favour of this PR. Any differences?

You are right, I've reopened #290 and closing this one.