Load custom rules from directory

Add an option to load additional custom rules from an arbitrary directory.
Discovered rules must be an instance of olivertwist.ruleengine.rule.Rule. This can be achieved by instantiating an instance of the class, or applying the @rule decorator (olivertwist.ruleengine.rule.rule) to a plain function with the signature (manifest: Manifest) -> (passes: List[Node], failures: List[Node])
Closes #27

Sorry, totally missed this request... Will try and get that done


Fixed bug in spotify component.

Description:
Fixed bug that causes errors while updating state of spotify component. Error occurred when player_devices is None, because in this casedevices is referenced in line 164 before assignment.
If the code communicates with devices, web services, or third-party tools:

[] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Thanks


rba values in css or sass are not handled correctly

background: rgba(255, 87, 34, 0.8) becomes
background: rgba(255,
87,
34,
0.8);
after beautify. The newlines that are inserted should not be inserted.

This no longer repro's.  Closing.


EventListener can't access wire-level request in case of failure

I'm trying to log the URI of failed requests using an EventListener. The URI may be rewritten by Interceptors and I'm interested in the URI of the wire-level request.
In case of a successful request, the URI of the wire-level request can be obtained by by calling Response.request(). But if the request fails and there is no Response object, there seems to be no way to get this information; Only the original is accessible through Call.request().

2 possible solutions are:

Add a Call.wireLevelRequest() method. This is not strictly backward compatible, but may be acceptable.
Change EventListener.requestHeadersStart()'s signature to EventListener.requestHeadersStart(Call call, Request wireLevelRequest). This is not backward compatible, but there is a disclaimer in https://github.com/square/okhttp/wiki/Events#availability stating that this interface is subject to change.

If any of the above works, or if you can suggest a better solution, I can send a PR.

If you need a quick & dirty fix you can use Call tags and interceptors to hack around this. Here’s a sketch:
public void callOkHttp() {
  Request request = new Request.Builder()
      .url(...)
      .tag(HackWireLevelRequestHolder.class, new HackWireLevelRequestHolder())
      .build();
  ...
}

class HackWireLevelRequestHolder {
  public static final Interceptor INTERCEPTOR = new Interceptor() {
    public Response intercept(Chain chain) throws IOException {
      Request request = chain.request();
      request.tag(HackWireLevelRequestHolder.class).wireLevelRequest = request;
      return chain.proceed(request);
    }
  }

  Request wireLevelRequest = null;
}

Will this help?
https://github.com/square/okhttp/issues/4638

Yes, it can help, assuming that the wire-level request will be reachable from the parameters of the new methods.

Closing in favour of the request events.

Just hit this but without the ability to control the creation of the request.  Just realised I'm saved by the Call.Factory which I can trivially decorate to set the tag I need.
I don't actually need to check it, just use Call.Factory wrapper instead of an interceptor.


CelebA-HQ inpainting masks

Hi,
where can I find the masks used for celeba-hq inpainting? It seems that previous works like IR-SDE, GOUD and this one utilize masks from the same source, but I cannot recover them from anywhere

Nevermind, they are here: https://github.com/Algolzw/daclip-uir/tree/main/scripts/inpainting_masks


How to keep the connection open without having to wait for getline ?

Hi,
in my code I do not want to froze everything in order to wait for a getline.
If I comment the getline code as below then the connection ends although I haven't told so.
???
    bind_events();

    HIGHLIGHT("Event listeners binded :) \n")

 //    HIGHLIGHT(" - HINT: Type exit to stop HWs client")
 //    for (std::string line; std::getline(std::cin, line);) {
 //
 //         if (line == "exit")
 //         {
 //             HIGHLIGHT("Closing...")
 //
 //             client.sync_close();
 //             client.clear_con_listeners();
 //
 //             return 0;
 //         }
 //    }
 //
	// return 1;

I found it.  I had to make the client variable as a field/global variable outside the function that it is destoyed  😵💫


Fix Manifest Entrypoint

No such package: org.quiltmc.impl. It's actually org.quiltmc.loader.impl.

Thanks for spotting this - I guess we missed that during the package rename?


#Feature - Writer limits the amount of chars baseada on Alphanumeric …

…Picture Kind #198
Strict Approach should be set by using GRAMMAR.SetStrictAlphanumericCharLimit(strictAlphanumericCharLimit) function

This is a nice addition. Can you alter it so that it is an option under The EdiWriter insted of the Grammar? Something like EscapeDecimalMarkInText

Hi, Constantinos.
I've adjusted as you suggested, let me know what you think about the modifications. Thanks for the lib!


add opentelemetry-demo chart

[ ] document
[ ] test

https://github.com/open-telemetry/opentelemetry-demo-webstore/issues/153

Hi @wph95, thanks for the contribution. Few suggestions/questions:

I believe the chart should be called the same name as the repo
I would recommend splitting deployments.yaml template by components
Looks like prometheus is missing. Is this intentional?

I believe the chart should be called the same name as the repo
done

Looks like prometheus is missing. Is this intentional?
Yes, the current version does not include metrics (grafana and prometheus)
I'm a little concerned that PR is too big to review, so metric is not included yet.

Yes, the current version does not include metrics (grafana and prometheus)
I'm a little concerned that PR is too big to review, so metric is not included yet. plan add it in next PR :)

Sounds good 👍

otel-col is failing for me with error

@dineshg13  fixed it :)

What's the best way to test this PR. I tried below steps after looking at README but ran into below error :
helm repo add open-telemetry https://open-telemetry.github.io/opentelemetry-helm-charts
helm install my-otel-demo open-telemetry/opentelemetry-demo-webstore
Error: INSTALLATION FAILED: failed to download "open-telemetry/opentelemetry-demo-webstore"
The error seems to be happening because the chart doesn't yet exist in the repo. Any suggestions on how to get workaround this issue so i can test this PR?
helm search repo open-telemetry
NAME                                  	CHART VERSION	APP VERSION	DESCRIPTION
open-telemetry/opentelemetry-collector	0.22.2       	0.55.0     	OpenTelemetry Collector Helm chart for Kubernetes
open-telemetry/opentelemetry-operator 	0.9.4        	0.54.0     	OpenTelemetry Operator Helm chart for Kubernetes

What's the best way to test this PR.

If you do gh pr checkout 280 you'll be able to checkout this PR. Then you'd be able to do normal helm commands by pointing to ./charts/opentelemetry-demo-webstore. For example, you could do helm template testing ./charts/opentelemetry-demo-webstore --output-dir ./testing to see the files that would be rendered during a default install of the chart.

thanks @TylerHelmuth ! I was able to deploy the services successfully in my AKS cluster.

@wph95 what the reason for not including prometheus & grafana ? we do have some metrics & I believe we are working to adding more

I noticed that in Jaeger  "cart-service" is missing in this K8s helm setup and present in docker-compose setup - attaching Jaeger pics for both. I do see t

he cart-service pod running in both cases  with no errors, so likely some instrumentation setup in K8s helm case but not sure.

I noticed that in Jaeger "cart-service" is missing in this K8s helm setup and present in docker-compose setup - attaching Jaeger pics for both. I do see the cart-service pod running in both cases with no errors, so likely some instrumentation setup in K8s helm case but not sure.

Thank you for your carefulness, it has been fixed.
(I was using the wrong env, and although this env OTEL_EXPORTER_OTLP_ENDPOINT , it is defined in the spec, some sdk's, such as dotnet for cart-service, do not support this env.
https://github.com/open-telemetry/opentelemetry-helm-charts/pull/280/commits/176aae6c45610237399d033f46311aa44552b08b

I noticed that in Jaeger "cart-service" is missing in this K8s helm setup and present in docker-compose setup - attaching Jaeger pics for both. I do see the cart-service pod running in both cases with no errors, so likely some instrumentation setup in K8s helm case but not sure.

Thank you for your carefulness, it has been fixed. (I was using the wrong env, and although this env OTEL_EXPORTER_OTLP_ENDPOINT , it is defined in the spec, some sdk's, such as dotnet for cart-service, do not support this env.
176aae6

thanks @wph95 for the quick fix ! I now see cart-service in Jaeger after doing helm deploy.

I believe we should remove the chart back now give https://github.com/open-telemetry/opentelemetry-demo/issues/222 :)

I believe we should rename the chart back now given https://github.com/open-telemetry/opentelemetry-demo/issues/222 :)

Nice, I like it way more without "webstore"

@wph95 what the reason for not including prometheus & grafana ? we do have some metrics & I believe we are working to adding more

https://github.com/open-telemetry/opentelemetry-helm-charts/pull/280#issuecomment-1190375707
https://github.com/wph95/opentelemetry-helm-charts/pull/1 (wait this pr merge

@Allex1 would appreciate your review on this PR.

@wph95 test meanings examples like https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-collector/examples?
Will it i added in this PR or another separated?

separated

I think it is better to submit separately

@wph95 test meanings examples like https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-collector/examples? Will it i added in this PR or another separated?

I think it is better to PR separately

@wph95 test meanings examples like https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-collector/examples? Will it i added in this PR or another separated?

I think it is better to PR separately

+1

@wph95 can you add a values.json.schema like https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/values.schema.json

Good suggestion, just added


Create a checklist of things to verify when new crates are introduced.

Two things that were missed in the ockam_transport_ble review that we should be sure not to miss for new crates (for example ockam_transport_smoltcp in #2213):

No CHANGELOG.md file. Initially, it should be empty. It's possible this should instead be handled by the changelog generation script.
Use of a path = ... and no version = ... for the dependency on ockam (#2525). This failure manifests quite late in the process, and not during a part that handles interruption well so it's pretty important we catch this one in the future.

More broadly, there are certainly other things to check as well. We should make a list of these somewhere. It probably is too rare that we add new crates to be worth automating, but perhaps that's worthwhile too.

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

Hi @thomcc
Can I work on this issue. it seems no one is working on it. Can I have a look at this issue?

@PsychoPunkSage it’s all yours

Hi @metaclips
I made a PR. Please have a look at it.
Thank You


Auto-tesseract building buttons appear, despite not being unlocked.

I'm unsure if the autobuyers are actually functional or not; I haven't gotten far enough on the beta build to discern that yet.

extends to upgrades as well https://discord.com/channels/677271830838640680/730669598738743306/808774441504735326

Fixed


Account list page does not show organization

Hi,
We found it confusing that on the Account list page (/accounts/list), accounts are listed only with their group but not the organization.
As the group is in almost all cases called "Default Group", this makes it hard to tell which organization the user is from.
We are thinking about adding an additional column to the listing that would also show the Organization.
Would you be interested in accepting a Pull Request if we implement this?
Cheers,
Vlad

FYI, this got implemented in #189 and can be closed ... so closing now.


Slave does not sync key updates during downtime after restart

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
Kvrocks 2.7.0
Minimal reproduce step

shutdown slave node
update key test1 and create a new key test2 in master node
bring up the slave node and check the keys in slave, test1 in slave is not updated and test2 is created

What did you expect to see?
after restart, slave should have the updated value of test1
What did you see instead?
test1 key in slave is not updated
Anything Else?
I also tried updating key test2 in master node to see if this could trigger the sync of key test1 between slave and master, but only to find test2 is updated in slave
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

@sam-hn Can you check if the replication is correct while restarting via the command info replication. Did you add the slaveof {maseter_ip} {master_port} to your slave configuration file? if no, it won't reconnect the master after restarting.

@sam-hn Can you check if the replication is correct while restarting via the command info replication. Did you add the slaveof {maseter_ip} {master_port} to your slave configuration file? if no, it won't reconnect the master after restarting.
thanks for your feedback.
the replication is correct, info replication shows slave is connected, actually slave configuration is not the problem, because slave can sync test2-- the new key from master, it's just test1 key that has problem

@sam-hn I cannot reproduce this issue on my side, what I do is:
1. start S1 and S2, and S2 slaveof S1
2. SET a 100 to S1, then shutdown the S2
3. SET a 101 and SET b 1 to S1, then restart S2 and S2 slaveof S1
4. GET a and GET b from S2, and returns 101 and 1

@git-hulk thanks for your test results. This is the exact steps I tried except I was testing with cluster mode.
Then I did another test with two new kvrocks nodes which had cluster mode disabled, and this time I could not reproduce the issue either. After that, I removed db dir and enabled cluster mode on the nodes, called controller API to create new cluster then did the test again, and the issue came back.
So I think the issue only happens with master-slave replication in a cluster. Can you please try the same and see if issue can reproduce this time?

Attached my test results for reference, below is the cluster info
<IP_ADDRESS>:6672> cluster nodes
qxpiIgvNeJN2DMLgwMwDmud8luIYw6uY7dIEuFtH <IP_ADDRESS>:6673@16673 slave kcf0WSVWymTh6AjTuw1JxL2e4AMNLXgkK9XFSzm8<PHONE_NUMBER>610<PHONE_NUMBER>611 1 connected
kcf0WSVWymTh6AjTuw1JxL2e4AMNLXgkK9XFSzm8 <IP_ADDRESS>:6672@16672 myself,master -<PHONE_NUMBER>610<PHONE_NUMBER>611 1 connected 0-16383

during slave downtime, update a to 101 and create b
<IP_ADDRESS>:6672> info replication
# Replication
role:master
connected_slaves:0
master_repl_offset:3
<IP_ADDRESS>:6672> set a 101
OK
<IP_ADDRESS>:6672> set b 1
OK

after slave restarted, key a still keeps old value
<IP_ADDRESS>:6673> keys *
1) "b"
2) "a"
<IP_ADDRESS>:6673> get a
"100"
<IP_ADDRESS>:6673> get b
"1"

@sam-hn Thank you, I will have a try soon when I get time.

slave-config.txt
attached slave configs which has use-reid-psync enabled

slave-config.txt attached slave configs which has use-rsid-psync enabled

@sam-hn Thanks for your input. I know what's root cause now, and will submit a PR to resolve this soon.


For Disabled people pre update Super mouse sensitive was best

Is it possible to revert the mouse sensitivity to the pre-update settings? or increase the setting past 10?

Hello,
although this might be possible I'd suggest trying to increase DPI on your mouse instead. Modern gaming mice go up to 32000 dpi which would let you do a 360° turn in less than 2cm.

Like I get close to that to with my mouse max 25600 dpi but at least for me that's just not enough, which was sad because like I had mentioned the pre-update was perfect, but I know it might not be possible. I actually wonder if maybe they added mouse smoothing in the update, in my experience turning it off fixes most of my problems.

windows settings max +25600 dpi will make your mouse move an entire 4k screen in 2 millimeters

windows settings max +25600 dpi will make your mouse move an entire 4k screen in 2 millimeters

you're right if you're not gaming and just doing normal computer stuff, but some games like Elden Ring and others override or set max level that pretty much negates dpi settings.

I've just tried to increase my dpi and at least in windowed fullscreen, the game starts spinning incredibly fast at the slightest movement.

I've just tried to increase my dpi and at least in windowed fullscreen, the game starts spinning incredibly fast at the slightest movement.

Please don't take this the wrong way, but that may be true for you but trust me when I say it's just not that way for everyone depending on the disability as insane as it sounds it's too slow.
Now for me do you think it's my game settings that could be messing with me?

Now for me do you think it's my game settings that could be messing with me?

Yeah, I think it's your game doing weird things. Either because of fullscreen, or because... elden ring. I've had such strange issues with this game that seemingly came out of nowhere and had no fixed, I reinstalled windows clean and everything is working great.. for now.

I'll give that a try.

If you can't make it work I'll look into the sensitivity scaling of the game and see if I can offer a specialized tool/CheatEngine Table to adjust it on the fly.

If you can't make it work I'll look into the sensitivity scaling of the game and see if I can offer a specialized tool/CheatEngine Table to adjust it on the fly.

if possible u should I'm sure others would appreciate it. :)


ZBBridge 'no longer being provided by the sonoff integration'

I don't know if this is a new problem as I have only recently started re-using a ZIGBEE_DOOR_AND_WINDOW_SENSOR that is accessed via the ZBBRIDGE. The ZBBRIDGE shows up fine in the eWelink app with the ZIGBEE_DOOR_AND_WINDOW_SENSOR as a child device.
They both show up in HA and the ZIGBEE_DOOR_AND_WINDOW_SENSOR shows the Open / Close state correctly. The ZBBRIDGE shows as 'Unavailable' and HA displays the message 'This entity is no longer being provided by the sonoff integration. If the entity is no longer in use, delete it in settings.' The ZBBRIDGE is present in the json list of devices file.
Diagnostics for ZBBRIDGE :
sonoff-07c74bf60db06045e12b47e3d446da39-ZigBee Bridge-483da79b2d6d80a3f82c25c3b5be4103.json.txt

Show scree. ZBBridge shouldn't have any entities.

Diagnostics:
sonoff-07c74bf60db06045e12b47e3d446da39-ZigBee Bridge-483da79b2d6d80a3f82c25c3b5be4103.json.txt

This sensor deprecated since v3, I think. You can safely remove it manually.

Sorry, when you say 'deprecated since v3'. What does that mean ? I couldn't see anything in the release notes.
Is there a reason the ZBBridge is no longer supported by this integration ?
Would it be an enhancement request to have it added (back) ?

Sensor deprecated. Not bridge. Sensor means nothing. And not provide anything useful.

Oh, I see, the mist clears. Thank you. I see the Diagnostic RSSI sensor entity is still available.
The ZBBridge does have other attributes that show up in the log but these are not supplied by the integration.
e.g. Online / Offline (sensor), sledonline (switch), zled (sensor)
Can these be added by the integration ? Should I create a new issue to request these be added as an enhancement request ?
2023-02-04 15:15:18 [D] 1000eedf06 UIID 0066 | {'addSubDevState': 'off', 'rssi': -67, 'subDevices': [{'subDevId': '6162901f004b12003026', 'deviceid': 'a480001496', 'uiid': '3026', 'index': 0}], 'fwVersion': '1.7.0', 'zled': 'off', 'sledOnline': 'on', 'subDevMaxNum': 32, 'subDevNum': 1, 'version': 8, 'only_device': {'ota': 'success'}, 'addDevTime': 180, 'timeZone': 0}
2023-02-04 15:27:36 [D] 1000eedf06 <= Cloud3 | {'online': True} | None
2023-02-04 15:27:36 [D] 1000eedf06 <= Cloud3 | {'subDevNum': 1, 'subDevMaxNum': 32, 'sledOnline': 'on', 'zled': 'off', 'fwVersion': '1.7.0'} | None
Network Indicator Turned Off in Ewelink App
2023-02-04 15:41:55 [D] 1000eedf06 <= Cloud3 | {'sledOnline': 'off', 'zled': 'off'} |<PHONE_NUMBER>301
2023-02-04 15:45:28 [D] 1000eedf06 <= Cloud3 | {'online': True} | None
2023-02-04 15:45:28 [D] 1000eedf06 <= Cloud3 | {'subDevNum': 1, 'subDevMaxNum': 32, 'sledOnline': 'off', 'zled': 'on', 'fwVersion': '1.7.0'} | None
Network Indicator Turned On in Ewelink App - First attempt failed
2023-02-04 15:46:02 [D] 1000eedf06 <= Cloud3 | {'online': False} | None
2023-02-04 15:46:03 [D] 1000eedf06 <= Cloud3 | {'online': True} | None
2023-02-04 15:46:03 [D] 1000eedf06 <= Cloud3 | {'subDevNum': 1, 'subDevMaxNum': 32, 'sledOnline': 'off', 'zled': 'on', 'fwVersion': '1.7.0'} | None
2023-02-04 15:46:05 [D] 1000eedf06 <= Cloud3 | {'sledOnline': 'on', 'zled': 'on'} |<PHONE_NUMBER>070
Turned Network Indicator Off and On again
2023-02-04 15:49:29 [D] 1000eedf06 <= Cloud3 | {'sledOnline': 'off', 'zled': 'off'} |<PHONE_NUMBER>183
2023-02-04 15:50:08 [D] 1000eedf06 <= Cloud3 | {'sledOnline': 'on', 'zled': 'on'} |<PHONE_NUMBER>622
Powered Off
2023-02-04 16:02:49 [D] 1000eedf06 <= Cloud3 | {'online': False} | None
powered On
2023-02-04 16:03:46 [D] 1000eedf06 <= Cloud3 | {'online': True} | None
2023-02-04 16:03:46 [D] 1000eedf06 <= Cloud3 | {'subDevNum': 1, 'subDevMaxNum': 32, 'sledOnline': 'on', 'zled': 'off', 'fwVersion': '1.7.0'} | None
2023-02-04 16:03:46 [D] 1000eedf06 <= Cloud3 | {'rssi': -67, 'fwVersion': '1.7.0'} | None

You can rename this issue

https://github.com/AlexxIT/SonoffLAN/releases/tag/v3.5.2


Using Modia with Sundials on julia lts causes invalid free in Sundials

using Modia.Synchronous: sample, Clock, previous, hold, positive
using ModiaMath
using PyPlot

@model main begin
    depth = Variable(start = 1.0)
    enableIO = Variable(start = false)
    maxDepth =  Parameter(0.8)
    minDepth =  Parameter(0.4)
    depthOver = Variable(start=true)
    depthUnder = Variable(start = false)
    @equations begin
        der(depth) = Bool(enableIO) ? .1 : -0.1
        depthOver = depthOver < depth
        depthUnder = depthUnder > depth
        enableIO = Bool(depthOver) ? true : Bool(depthUnder) ? false : previous(enableIO, Clock(.0001))

    end
end

result = simulate(main, 50,storeEliminated= false, logTranslation=true,removeSingularities=false);
ModiaMath.plot(result, "depth")

results in
┌ Warning: `getindex(o::PyObject, s::AbstractString)` is deprecated in favor of dot overloading (`getproperty`) so elements should now be accessed as e.g. `o."s"` instead of `o["s"]`.
│   caller = top-level scope at _module.jl:82
└ @ Core ~/.julia/packages/ModiaMath/FTD2B/src/Result/_module.jl:82
WARNING: using PyPlot.hold in module Main conflicts with an existing identifier.
logTranslation = true
removeSingularities = false
storeEliminated = false
Log file: /home/brenthalonen/ModiaResults/main.txt

Simulating model: main
Number of equations: 4
Number of variables: 5
Number of continuous states: 1
Multiple occurances of unknown: depthOver = depthOver < depth
Multiple occurances of unknown: depthUnder = depthUnder > depth
free(): invalid pointer

signal (6): Aborted
in expression starting at /home/brenthalonen/projects/Cod/notebooks/test_output.jl:27
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f499c3163ed)
unknown function (ip: 0x7f499c31e47b)
unknown function (ip: 0x7f499c31fcab)
N_VDestroy_Serial at /home/brenthalonen/.julia/packages/Sundials/SKP8f/deps/usr/lib/libsundials_nvecserial.so (unknown line)
KINFree at /home/brenthalonen/.julia/packages/Sundials/SKP8f/deps/usr/lib/libsundials_kinsol.so (unknown line)
KINFree at /home/brenthalonen/.julia/packages/Sundials/SKP8f/src/wrapped_api/kinsol.jl:215 [inlined]
#solveNonlinearEquations!#3 at /home/brenthalonen/.julia/packages/ModiaMath/FTD2B/src/NonlinearEquations/sundials_kinsol.jl:173
unknown function (ip: 0x7f492df18d8c)
jl_fptr_trampoline at /buildworker/worker/package_linux64/build/src/gf.c:1809
jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2312
#solveNonlinearEquations! at ./none:0 [inlined]
reinitialize! at /home/brenthalonen/.julia/packages/ModiaMath/FTD2B/src/DAE/simulationState.jl:668

version
julia> versioninfo()
Julia Version 1.0.5
Commit 3af96bcefc (2019-09-09 19:06 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, skylake)

This might be an issue for Modia? Sounds like they are directly freeing something that shouldn't be freed. Did you try using the latest Julia release? (v1.5)

Suggest reopening if still an issue in a recent release.


Prepare for dub

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

ping @tuulos


Aquire SCHISM-3D test cases

Need 2-3 3D SCHISM test cases for the UFS-Coastal test suite
from UFS-Coastal WW3 tag-up on 4/1/2024 @josephzhang8 will help point us in the right direction

@janahaddad I transferred this issue to right place.

@janahaddad I am closing this since there are lots of issues related with SCHSIM+WW3 coupling. We will keep continue to use https://github.com/oceanmodeling/WW3/issues/11


Ron Hope Misidentified As Rob Hope

Typo identifies Ron Hope as "Rob Hope" during the mission A Light In The Darkness.

Details
During the mission A Light In The Darkness, when telling Nadia Muffaz about the events of the Freestar Ranger faction quest The Hammer Falls.
At a later part of the dialogue you'll be asked what you think about Hopetech as a company, and one of the options is "Despite what Rob Hope did, HopeTech is a great company. I know it'll weather this storm."
Obviously this is meant to be Ron Hope, not Rob.
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
Simply complete the mission "The Hammer Falls" then go to SSNN in New Atlantis with the mission "A Light In The Darkness" active and tell Nadia about what happened.

Form ID [0008CD36]


Use in Ledger-only mode

Stories
As a user with a Ledger-only account, I want to login with my Ledger and view my account, so I can view my balances, history, and manage my account.
As a user with a Ledger-only account, I want to connect my Ledger to sign transactions, so I can use Wallet features and easily interact with apps.
Acceptance Criteria

[ ] User can "Login with Ledger"
[ ] User can view account without Ledger connected after login
[ ] User can sign each transaction type

[ ] Send NEAR (/send)
[ ] Sign TX (/sign)
[ ] Login/create access key (/login)
[ ] Remove access key (/authorized-apps)
[ ] Add recovery option (/profile)
[ ] Remove recovery option (/profile)

[ ] Mobile ok
[ ] Tested

Login Flow

User selects "Login with Ledger" on /create
Prompted to "Connect your Ledger and open the NEAR app"
a. If successful, user is redirected to Dashboard (/)
b. If unsuccessful, user sees "Connection failed. Please reconnect your Ledger and try again"

Signing Flow

User selects "Confirm & Send" (/send-money) or "Allow" (/login, /sign)
Prompted to "Connect your Ledger and open the NEAR app"
Once connected, prompted to "Confirm the transaction on your Ledger"
a. If signing is successful, user sees normal TX status flow "Transferring..." etc.
b. If signing is unsuccessful, user sees "Transaction signing failed. Please reconnect your Ledger and try again"

@corwinharrell @Patrick1904 Thoughts on using a modal for the "Sign with Ledger" communication, rather than redirecting them to a page for the signing flow?

@corwinharrell @Patrick1904 Thoughts on using a modal for the "Sign with Ledger" communication, rather than redirecting them to a page for the signing flow?

Could do a modal for quick implementation but an inline Ledger element confirming that the user is in a 'Ledger-only mode' and saying 'Have your Ledger ready to sign' would be slightly better UX IMO. More consistent signing UX = better.

[ ] Design Complete: https://www.figma.com/file/BhrKSEYsyegyZ0jKsFJ3QR/NEAR-Wallet?node-id=439%3A4892


moment().subtract(55, 'days').fromNow(true) is "54 days"

Describe the bug
Bug, or at least surprising behaviour, when humanizing time deltas in the past with high relativeTimeThresholds
To Reproduce
Running moment 2.24:
moment.relativeTimeThreshold("h", 73);
moment.relativeTimeThreshold("d", 91);
moment.relativeTimeThreshold("M", 25);
moment.relativeTimeRounding(x => x); // I use moment.relativeTimeRounding(x => x.toFixed(1)); in my application
moment.unix(Date.now() / 1000 - 86400*54).fromNow(true) // 54 days
moment.unix(Date.now() / 1000 - 86400*55).fromNow(true) // 54.00000001157407 days
moment.unix(Date.now() / 1000 - 86400*56).fromNow(true) // 55 days

moment().subtract(54, 'days').fromNow(true) // 54 days
moment().subtract(55, 'days').fromNow(true) // 54 days
moment().subtract(56, 'days').fromNow(true) // 55 days

Expected behavior
I perhaps incorrectly expect moment.unix(Date.now() / 1000 - 86400*55).fromNow(true) to return "55 days" (should I use a different moment constructor?)
I definitely expect moment().subtract(55, 'days').fromNow(true) to return "55 days"
Desktop (please complete the following information):

OS: Ubuntu
Browser: Chrome
Version: 79.0.3938.0 (Official Build) dev (64-bit)

Moment-specific environment

The time zone setting of the machine the code is running on: CEST, Europe/Amsterdam
The time and date at which the code was run: "2019-10-24T17:24:19+02:00"
Other libraries in use (TypeScript, Immutable.js, etc): can be reproduced on the browser console for momentjs.com

Please run the following code in your environment and include the output:
console.log((new Date()).toString())
console.log((new Date()).toLocaleString())
console.log((new Date()).getTimezoneOffset())
console.log(navigator.userAgent)
console.log(moment.version)

Thu Oct 24 2019 17:25:41 GMT+0200 (Central European Summer Time)
10/24/2019, 5:25:41 PM
-120
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3938.0 Safari/537.36
2.24.0

I and a buddy attempted to binary search the exact number of seconds that cause the number of days to be off by one. It appears that this number shifts upwards over time (so 54.745 days would first appear as "53 days" then seconds later as "54 days"). Looks like something is breaking in the division depending on which end of the relevant midnight you end up on?

This is interesting:
moment.unix(Date.now() / 1000 - 86400*55).fromNow(true) // 54.00000001157407 days

Try that again, and again, and again...
The problem is fromNow and the constantly-changing concept of 'now'.
The .00000001157407 is (1/86_400_000).toFixed(14) - i.e. it's 1 millisecond.
The problem is that the system clock will tick over from one millisecond to another in between evaluating moment.unix(Date.now() ...) and calling .fromNow(true)

I changed the subject line to underline I'm not worried about the millisecond as much as I am by the error by a whole day :)

Would you look at that, a day has passed and the bug has shifted by a day
moment.unix(Date.now() / 1000 - 86400*54).fromNow(true) // "54.00000001157407 days"
moment.unix(Date.now() / 1000 - 86400*55).fromNow(true) // "55 days"
moment.unix(Date.now() / 1000 - 86400*56).fromNow(true) // "55 days"
moment.unix(Date.now() / 1000 - 86400*57).fromNow(true) // "56 days"

//perhaps more meaningfully
> moment("2019-08-31 00:00:05").from(moment("2019-10-25 12:00:00"))
'55.49994212962963 days ago'
> moment("2019-08-31 00:00:04").from(moment("2019-10-25 12:00:00"))
'55.4999537037037 days ago'
> moment("2019-08-31 00:00:03").from(moment("2019-10-25 12:00:00"))
'55.499965277777775 days ago'
> moment("2019-08-31 00:00:02").from(moment("2019-10-25 12:00:00"))
'55.499976851851855 days ago'
> moment("2019-08-31 00:00:01").from(moment("2019-10-25 12:00:00"))
'55.49998842592593 days ago'
> moment("2019-08-31 00:00:00").from(moment("2019-10-25 12:00:00"))
'55.5 days ago'
> moment("2019-08-30 23:59:59").from(moment("2019-10-25 12:00:00"))
'54.50001157407407 days ago'
> moment("2019-08-30 23:59:58").from(moment("2019-10-25 12:00:00"))
'54.500023148148145 days ago'
> moment("2019-08-30 23:59:57").from(moment("2019-10-25 12:00:00"))
'54.500034722222225 days ago'
> moment("2019-08-30 23:59:56").from(moment("2019-10-25 12:00:00"))
'54.5000462962963 days ago'
> moment("2019-08-30 23:59:55").from(moment("2019-10-25 12:00:00"))
'54.50005787037037 days ago'

I'll change the title to reflect this finding...

The way from works is to create a duration between the two timestamps, then calculate the difference.
I suspect there's a problem on this line (but haven't got time to go into it now):
https://github.com/moment/moment/blob/develop/src/lib/duration/create.js#L101


Need help in media queries

Hi,
We are trying to get an HTML response as below with your plugin but we couldn't create the "1x, 2x" sizes in source files with it
Can you help us please

<picture>
    <source media="(min-width: 1440px)" srcset="/media/tytmj3of/web-header-darkb.jpg?rxy=2c0.23142480436991725&width=1920&height=584&rnd=133330203507330000&format=webp&quality=80 1x, /media/tytmj3of/web-header-darkb.jpg?rxy=2c0.23142480436991725&width=3840&height=1168&rnd=133330203507330000&format=webp&quality=80 2x" type="image/webp">
    <source media="(min-width: 768px)" srcset="/media/tytmj3of/web-header-darkb.jpg?rxy=2c0.23142480436991725&width=1200&height=464&rnd=133330203507330000&format=webp&quality=80 1x, /media/tytmj3of/web-header-darkb.jpg?rxy=2c0.23142480436991725&width=2400&height=928&rnd=133330203507330000&format=webp&quality=80 2x" type="image/webp">
    <source media="(min-width: 375px)" srcset="/media/tytmj3of/web-header-darkb.jpg?cc=2c0%2c0.07131845920029152%2c0&width=768&height=528&rnd=133330203507330000&format=webp&quality=80 1x, /media/tytmj3of/web-header-darkb.jpg?cc=0.48653172261789%2c0%2c0.07131845920029152%2c0&width=1536&height=1056&rnd=133330203507330000&format=webp&quality=80 2x" type="image/webp">
    <img class="event-page__imag header-block__image" srcset="/media/tytmj3of/web-header-darkb.jpg?rxy=0.7057628900729893%2c0.23142480436991725&width=1920&height=584&rnd=133330203507330000&format=webp&quality=80 1x, /media/tytmj3of/web-header-darkb.jpg?rxy=0.7057628900729893%2c0.23142480436991725&width=3840&height=1168&rnd=133330203507330000&format=webp&quality=80 2x" alt="Web Header Darkb" loading="eager" height="584" width="1920">
</picture>

cc: @sekmenhuseyin

Hi. I'm not sure that you actually want to do that 😉.
Look at my sample picture profile for a Thumbnail image. Even though the picture width is always 150px, I specify that there should be two images, one 150px and one 300px. That way the browser can select the 300px image if the screen has a high pixel density.
You define what the picture width is in different view-port widths, and then you define the image widths that should be available. Then its up to the browser to select the best image.

I've tried this code and get a slightly similar html code

Yes that is the correct behavior. 100w tells the browser that this is an image that is 100 pixels wide, and 200w tells the browser that this is an image that is 200 pixels wide.
150px tells the browser that the picture width always is 150px.
The browser can now select which image it thinks fits the best. In your case it will always select the 200w image. But if you had had a 150w and 300w it probably would have selected 150w for a regular screen with pixel density 1x, and the 300w images for a mobile screen with pixel density 2x.
There are a couple of links that explains the picture element more in the ReadMe.

thanks